* net/dbus.el (dbus-unregister-object): Don't release services for
[bpt/emacs.git] / src / ChangeLog
CommitLineData
32bbb17c
GM
12011-09-25 Glenn Morris <rgm@gnu.org>
2
3 * buffer.c (truncate-lines): Doc fix.
4
94e0933e
CY
52011-09-24 Chong Yidong <cyd@stupidchicken.com>
6
7 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8 (Fset_window_next_buffers): Doc fix.
9
cddde921
GM
102011-09-24 Glenn Morris <rgm@gnu.org>
11
12 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
13
1260aef1
PE
142011-09-24 Paul Eggert <eggert@cs.ucla.edu>
15
25b4bfa0
PE
16 Fix minor problems found by static checking.
17 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
18 * indent.c (Fvertical_motion): Fix == vs = typo.
19
e3cbd34b
EZ
202011-09-24 Eli Zaretskii <eliz@gnu.org>
21
6bf7006f
EZ
22 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
23 value is now t. Doc fix.
24
e3cbd34b
EZ
25 * indent.c (Fvertical_motion): Compute and apply the overshoot
26 logic when moving up, not only when moving down. Fix the
27 confusing name and values of the it_overshoot_expected variable;
28 logic changes accordingly. (Bug#9254) (Bug#9549)
29
30 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
31 CHARPOS is covered by a display string which includes newlines.
32 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
33 is covered by a display string with embedded newlines.
34
a3de0cbd
MA
352011-09-24 Michael Albinus <michael.albinus@gmx.de>
36
37 * dbusbind.c (Fdbus_register_signal): Add match rule to
38 Vdbus_registered_objects_table. (Bug#9581)
39 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
40 docstring.
41
b260039d
JM
422011-09-24 Jim Meyering <meyering@redhat.com>
43
44 do not ignore write error for any output size
45 The previous change was incomplete.
46 While it makes emacs --batch detect the vast majority of stdout
47 write failures, errors were still ignored whenever the output size is
48 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
49 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
50 && echo FAIL: ignored write error
51 FAIL: ignored write error
52 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
53 && echo FAIL: ignored write error
54 FAIL: ignored write error
55 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
56
8eca8a7c
AS
572011-09-23 Andreas Schwab <schwab@linux-m68k.org>
58
59 * emacs.c (Fkill_emacs): In noninteractive mode exit
60 non-successfully if a write error occurred on stdout. (Bug#9574)
61
3341db62
EZ
622011-09-21 Eli Zaretskii <eliz@gnu.org>
63
64 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
65 the xassert test.
66
67 * dispextern.h (struct it): Update the comment documenting what
68 can it->OBJECT be.
69
8c203dbf
EZ
702011-09-20 Eli Zaretskii <eliz@gnu.org>
71
72 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
73 a display string, extend search for cursor position to end of row.
74 (find_row_edges): If the row ends in a newline from a display
75 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
76 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
77 (Fcurrent_bidi_paragraph_direction): Fix search for previous
78 non-empty line. Fixes confusing cursor motion with arrow keys at
79 the beginning of a line that starts with whitespace.
8c203dbf 80
a4824228
LMI
812011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
82
83 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
84 (bug#9493).
85
33ed493b
CY
862011-09-18 Chong Yidong <cyd@stupidchicken.com>
87
88 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
89 boolean (Bug#9154).
90
56cd55c8
EZ
912011-09-18 Eli Zaretskii <eliz@gnu.org>
92
93 * xdisp.c (display_line): Record maximum and minimum buffer
94 positions even if no glyphs were produced (e.g., by a zero-width
95 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
96 buffer positions that will be removed from the glyph row because
97 they don't fit.
c02dcedf
EZ
98 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
99 column is beyond frame width: don't subtract 1 "pixel" when
100 computing width of the stretch.
3e62b7e0
EZ
101 (reseat_at_next_visible_line_start): Undo the change made on
102 2011-09-17 that saved paragraph information and restored it after
103 the call to `reseat'. (Bug#9545)
56cd55c8 104
5ed99d36 1052011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
106
107 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
108 and turn window cursor on if cleared (Bug#9415).
109
5ed99d36 1102011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
111
112 * search.c (boyer_moore): Take unibyte characters from pattern
113 literally. (Bug#9458)
114
9bade7b2
EZ
1152011-09-18 Eli Zaretskii <eliz@gnu.org>
116
117 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
118
e5e9d610
PE
1192011-09-18 Paul Eggert <eggert@cs.ucla.edu>
120
87e4427a
PE
121 Fix minor problem found by static checking.
122 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
123 initialized, to pacify gcc -Wuninitialized.
124
e5e9d610
PE
125 * fileio.c: Report proper errno when syscall falls.
126 (Finsert_file_contents): Save and restore errno,
127 so that report_file_error outputs the correct diagnostic.
128 (Fwrite_region) [CLASH_DETECTION]: Likewise.
129
a1674f0b
EZ
1302011-09-18 Eli Zaretskii <eliz@gnu.org>
131
132 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
133
fbfb6dd4
EZ
1342011-09-17 Eli Zaretskii <eliz@gnu.org>
135
136 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
137 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
138
bb187662
EZ
1392011-09-17 Eli Zaretskii <eliz@gnu.org>
140
1137e8b8
EZ
141 * xdisp.c (reseat_at_next_visible_line_start): Keep information
142 about the current paragraph and restore it after the call to
143 reseat.
144
145 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
146 (bidi_find_paragraph_start): Search back for paragraph beginning
147 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
148 (bidi_move_to_visually_next): Only trigger paragraph-related
149 computations when the last character is a newline or at EOB, not
150 just any NEUTRAL_B. (Bug#9470)
151
bb187662
EZ
152 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
153 truncated lines if point is covered by a display string. (Bug#9524)
154
2e621251
PE
1552011-09-16 Paul Eggert <eggert@cs.ucla.edu>
156
157 * xselect.c: Relax test for outgoing X longs (Bug#9498).
158 (cons_to_x_long): New function.
159 (lisp_data_to_selection_data): Use it. Correct the test for
160 short-versus-long data; it was negated. Break out of vector
161 loop, for efficiency, when a long datum is discovered.
162
91a15bc6
SM
1632011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
164
165 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
166
b41c3a35
EZ
1672011-09-16 Eli Zaretskii <eliz@gnu.org>
168
169 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
170 GCC PR/17406) by declaring this function with external scope.
171
7812ba2d
PE
1722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
173
174 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
175 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
176
cf7edc2a
AS
1772011-09-15 Andreas Schwab <schwab@linux-m68k.org>
178
179 * editfns.c (Fformat): Correctly handle text properties on "%%".
180
bd01620e
EZ
1812011-09-15 Eli Zaretskii <eliz@gnu.org>
182
183 * xterm.c (x_draw_composite_glyph_string_foreground):
184 * w32term.c (x_draw_composite_glyph_string_foreground):
185 * term.c (encode_terminal_code):
186 * composite.c (composition_update_it, get_composition_id):
187 * xdisp.c (get_next_display_element)
188 (fill_composite_glyph_string): Add comments about special meaning
189 of TAB characters in a composition.
190
a02719a3
PE
1912011-09-15 Paul Eggert <eggert@cs.ucla.edu>
192
193 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
194 This occurs when processing a multibyte format.
195 Problem reported by Wolfgang Jenker.
a02719a3 196
72589a3c
JB
1972011-09-15 Johan Bockgård <bojohan@gnu.org>
198
199 * xdisp.c (try_cursor_movement): Only check for exact match if
200 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
201
1c14176c
PE
2022011-09-14 Paul Eggert <eggert@cs.ucla.edu>
203
204 Remove unused external symbols.
205 * dispextern.h (calc_pixel_width_or_height): Remove decl.
206 * xdisp.c (calc_pixel_width_or_height): Now static.
207 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
208 * indent.c (check_display_width):
209 * w32term.c: Fix comment to match code.
210 * xterm.c, xterm.h (x_catching_errors): Remove.
211
d2eea5b5
PE
2122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
213
214 * xselect.c: Use signed conversions more consistently (Bug#9498).
215 (selection_data_to_lisp_data): Assume incoming selection data are
216 signed integers, not unsigned. This is to be consistent with
217 outgoing selection data, which was modified to use signed integers
218 in as part of the fix to Bug#9196 in response to Jan D.'s comment
219 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
220 expects long, not unsigned long.
221
46888499
EZ
2222011-09-14 Eli Zaretskii <eliz@gnu.org>
223
224 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
225 computation of loop end. Reported by Johan Bockgård
226 <bojohan@gnu.org>.
227
ef8ef9fb
CY
2282011-09-13 Chong Yidong <cyd@stupidchicken.com>
229
230 * frame.c (Fother_visible_frames_p): Function deleted.
231
fa819fed
EZ
2322011-09-12 Eli Zaretskii <eliz@gnu.org>
233
234 * indent.c (compute_motion): Process display vector front to back
235 rather than the other way around. (Bug#2496)
236
2ba8e008
SM
2372011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
238
239 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
240
20f53c69
CY
2412011-09-11 Chong Yidong <cyd@stupidchicken.com>
242
243 * minibuf.c (Fread_from_minibuffer): Doc fix.
244
d562d7a4
EZ
2452011-09-11 Eli Zaretskii <eliz@gnu.org>
246
247 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
248 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
249
1c4d7f3d
LMI
2502011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
251
252 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
253 value for non-existent files.
254
b885bf36
EZ
2552011-09-11 Eli Zaretskii <eliz@gnu.org>
256
257 * fileio.c (Finsert_file_contents): If the file cannot be opened,
258 set its "size" to -1. This will set the modtime_size field of
259 the corresponding buffer to -1, which is what
260 verify-visited-file-modtime expects for files that do not exist.
261 (Bug#9139)
262
6612f0bf
PE
2632011-09-11 Paul Eggert <eggert@cs.ucla.edu>
264
265 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
266 here ...
267 * lisp.h: ... from here. push_key_description is no longer
268 defined in keyboard.c, so its declaration should not be in
269 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
270 logically belongs with push_key_description.
271
dfb3f755
PE
2722011-09-10 Paul Eggert <eggert@cs.ucla.edu>
273
274 * buffer.h: Include <sys/types.h> instead of <time.h>.
275 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
276 Problem reported by Herbert J. Skuhra.
277
3134906c
LMI
2782011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
279
280 * xml.c (parse_region): Make the parsing work for
281 non-comment-starting XML files again (bug#9144).
282
8d903f4e
AS
2832011-09-10 Andreas Schwab <schwab@linux-m68k.org>
284
285 * image.c (gif_load): Fix calculation of bottom and right corner.
286 (Bug#9468)
287
80ad64f4
EZ
2882011-09-10 Eli Zaretskii <eliz@gnu.org>
289
290 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
291 redisplay in small windows.
292
208a048d
EZ
2932011-09-09 Eli Zaretskii <eliz@gnu.org>
294
295 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
296
9b1c252e
MR
2972011-09-08 Martin Rudalics <rudalics@gmx.at>
298
299 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
300 Operate on live windows only.
301
2949f33b
JB
3022011-09-08 Juanma Barranquero <lekktu@gmail.com>
303
304 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
305
e08dcafd
EZ
3062011-09-07 Eli Zaretskii <eliz@gnu.org>
307
308 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
309 only under bidi iteration.
310
115b96bd
JD
3112011-09-07 Jan Djärv <jan.h.d@swipnet.se>
312
313 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
314
c8199d0f
PE
3152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
316
317 isnan: Fix porting problem to Solaris 10 with bundled gcc.
318 Without this fix, the command to link temacs failed due to an
319 undefined symbol __builtin_isnan. This is because
320 /usr/include/iso/math_c99.h #defines isnan(x) to
321 __builtin_isnan(x), but the bundled gcc, which identifies itself
322 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
323 a __builtin_isnan.
324 * floatfns.c (isnan): #undef, and then #define to a clone of
325 what's in data.c.
326 (Fisnan): Always define, since it's always available now.
327 (syms_of_floatfns): Always define isnan at the Lisp level.
328
e39b275c 3292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
330
331 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
332
b2db44d9 3332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 334
f4af5137 335 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
336 The previous code assumed that file offsets (off_t values) fit in
337 EMACS_INT variables, which is not true on typical 32-bit hosts.
338 The code messed up by falsely reporting buffer overflow in cases
339 such as (insert-file-contents "big" nil 1 2) into an empty buffer
340 when "big" contains more than 2**29 bytes, even though this
341 inserts just one byte and does not overflow the buffer.
342 (Finsert_file_contents): Store file offsets as off_t
343 values, not as EMACS_INT values. Check for overflow when
344 converting between EMACS_INT and off_t. When checking for
345 buffer overflow or for overlap, take the offsets into account.
346 Don't use EMACS_INT for small values where int suffices.
347 When checking for overlap, fix a typo: ZV was used where
348 ZV_BYTE was intended.
349 (Fwrite_region): Don't assume off_t fits into 'long'.
350 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
351
ecfc0a49
MA
3522011-09-05 Michael Albinus <michael.albinus@gmx.de>
353
354 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
355
6511acf2 3562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 357
0999621a 358 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
359
360 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 361 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
362 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
363 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
364 (modify_event_symbol): Do not assume that the length of
365 name_alist_or_stem is safe to alloca and fits in int.
366 (Fexecute_extended_command): Likewise for function name and binding.
367 (Frecursion_depth): Wrap around reliably on integer overflow.
368 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
369 since some callers pass EMACS_INT values.
370 (Fsingle_key_description): Don't crash if symbol name contains more
371 than MAX_ALLOCA bytes.
372 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
373 (get_minibuffer): Arg is now EMACS_INT, not int.
374 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 375 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
376 * window.h (command_loop_level, minibuf_level): Reflect API changes.
377
2be7d702
PE
378 * dbusbind.c (signature_cat): New function.
379 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
380 Do not overrun buffer; instead, report string overflow.
381
9d1df220
PE
382 * dispnew.c (add_window_display_history): Don't overrun buffer.
383 Truncate instead; this is OK since it's just a log.
384
33ef5c64
PE
385 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
386 even if the time zone offset is outlandishly large.
387 Don't mishandle offset == INT_MIN.
388
66c6fdd5
PE
389 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
390 when creating daemon; the previous buffer-overflow check was incorrect.
391
d749b01b
PE
392 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
393 which has the guts of the old verror function.
394
b5cd1905
PE
395 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
396 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
397
6e1a67fb
PE
398 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
399 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 400 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 401 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
402 length of string rather than counting it via multiple sprintfs;
403 that's simpler and more reliable.
c21721cc
PE
404 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
405 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
406 sprintf, in case result does not fit in int.
407
c57b67fc
PE
408 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
409 (fontset_from_font): Print it.
410
8a401434
PE
411 * frame.c (tty_frame_count): Now printmax_t, not int.
412 (make_terminal_frame, set_term_frame_name): Print it.
413 (x_report_frame_params): In X, window IDs are unsigned long,
414 not signed long, so print them as unsigned.
415 (validate_x_resource_name): Check for implausibly long names,
416 and don't assume name length fits in 'int'.
417 (x_get_resource_string): Don't blindly alloca invocation name;
418 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
419 not fit in int.
420
6e1a67fb
PE
421 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
422 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
423 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
424
0df02bf3
PE
425 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
426 Use esprintf, not sprintf, in case result does not fit in int.
427
48e30793
PE
428 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
429 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
430 it as a large positive number.
431 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
432 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
433
a66ff6d8
PE
434 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
435 in case result does not fit in int.
436
aca216ff
PE
437 * print.c (float_to_string): Detect width overflow more reliably.
438 (print_object): Make sprintf buffer a bit bigger, to avoid potential
439 buffer overrun. Don't assume list length fits in 'int'. Treat
440 print length of 0 as 0, not as infinity; to be consistent with other
441 uses of print length in this function. Don't overflow print length
442 index. Don't assume hash table size fits in 'long', or that
443 vectorlike size fits in 'unsigned long'.
444
31c286f7
PE
445 * process.c (make_process): Use printmax_t, not int, to format
446 process-name gensyms.
447
55e5faa1
PE
448 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
449
80f2e268
PE
450 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
451 to avoid potential buffer overrun.
452
670741ab
PE
453 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
454 if X resource line is longer than 512 bytes.
455
b7163a50
PE
456 * xfns.c (x_window): Make sprintf buffer a bit bigger
457 to avoid potential buffer overrun.
458
ae58ff1f
PE
459 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
460
c43c8a6a
PE
461 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
462
3f8236f4
PE
4632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
464
53e9fe90 465 Integer overflow fixes for scrolling, etc.
6511acf2
PE
466 Without these, Emacs silently mishandles large integers sometimes.
467 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
468 it were "C-u 1 M-x recenter" on a typical 64-bit host.
469
6511acf2
PE
470 * xdisp.c (try_window_id): Check Emacs fixnum range before
471 converting to 'int'.
806add1d 472
6511acf2 473 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
474 Check that an Emacs fixnum is in range before assigning it to 'int'.
475 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
476 values converted from Emacs fixnums.
477 (Frecenter): Don't wrap around a line count if it is out of 'int'
478 range; instead, treat it as an extreme value.
479 (Fset_window_configuration, compare_window_configurations):
480 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
481
6511acf2
PE
482 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
483 that can exceed INT_MAX. Check that EMACS_INT value is in range
484 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
485 (match_limit): Don't assume that a fixnum can fit in 'int'.
486
6511acf2 487 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
488 exceed INT_MAX.
489
6511acf2 490 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
491 (Fvertical_motion): Don't wrap around LINES values that don't fit
492 in 'int'. Instead, treat them as extreme values. This is good
493 enough for windows, which can't have more than INT_MAX lines anyway.
494
fcb901a7
LMI
4952011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
496
0f2f6b6d
LMI
497 * Require libxml/parser.h to avoid compilation warning.
498
fcb901a7
LMI
499 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
500
501 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
502 since this reportedly can destroy thread storage.
503
6e20a0d4
CY
5042011-08-30 Chong Yidong <cyd@stupidchicken.com>
505
506 * syntax.c (find_defun_start): Update all cache variables if
507 exiting early (Bug#9401).
508
148ae00e
EZ
5092011-08-30 Eli Zaretskii <eliz@gnu.org>
510
f6cfbd8f
EZ
511 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
512
148ae00e
EZ
513 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
514 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
515 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
516
517 * term.c (tty_append_glyph): New function.
518 (produce_stretch_glyph): Static function and its prototype deleted.
519
520 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
521 prototypes.
522
c4a07a4c
PE
5232011-08-29 Paul Eggert <eggert@cs.ucla.edu>
524
525 * image.c (parse_image_spec): Check for nonnegative, not for positive,
526 when checking :margin (Bug#9390).
527 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
528 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
529 so that the name doesn't mislead. All uses changed.
530
6bc8cd65
JB
5312011-08-28 Johan Bockgård <bojohan@gnu.org>
532
533 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
534 set_tty_hooks.
535
dca4927e
EZ
5362011-08-27 Eli Zaretskii <eliz@gnu.org>
537
538 * xdisp.c (move_it_to): Don't bail out early when reaching
539 position beyond to_charpos, if we are scanning backwards.
540 (move_it_vertically_backward): When DY == 0, make sure we get to
541 the first character in the line after the newline.
542
f2cad773
PE
5432011-08-27 Paul Eggert <eggert@cs.ucla.edu>
544
545 * ccl.c: Improve and simplify overflow checking (Bug#9196).
546 (ccl_driver): Do not generate an out-of-range pointer.
547 (Fccl_execute_on_string): Remove unnecessary check for
548 integer overflow, noted by Stefan Monnier in
549 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
550 Remove a FIXME that didn't need fixing.
551 Simplify the newly-introduced buffer reallocation code.
552
0cae2cdb
JB
5532011-08-27 Juanma Barranquero <lekktu@gmail.com>
554
555 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
556
5fc295a4 5572011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 558
70c60eb2 559 Integer and memory overflow issues (Bug#9196).
726e0ab1 560
d31850da
PE
561 * doc.c (get_doc_string): Rework so that
562 get_doc_string_buffer_size is the actual buffer size, rather than
563 being 1 less than the actual buffer size; this makes xpalloc more
564 convenient.
565
a69fbedb
PE
566 * image.c (x_allocate_bitmap_record, cache_image):
567 * xselect.c (Fx_register_dnd_atom):
568 Simplify previous changes by using xpalloc.
569
fe5c5d37
PE
570 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
571 since either will do and ptrdiff_t is convenient with xpalloc.
572
0065d054
PE
573 * charset.c (charset_table_size)
574 (struct charset_sort_data.priority): Now ptrdiff_t.
575 (charset_compare): Don't overflow if priorities differ greatly.
576 (Fsort_charsets): Don't assume list length fits in int.
577 Check for size-calculation overflow when allocating sort data.
578 (syms_of_charset): Allocate an initial charset table that is
579 just under 64 KiB, to avoid problems with glibc malloc and mmap.
580
581 * cmds.c (internal_self_insert): Check for size-calculation overflow.
582
583 * composite.h (struct composition.glyph_len): Now int, not unsigned.
584 The actual value is always <= INT_MAX, and leaving it unsigned made
585 overflow checking harder.
586
587 * dispextern.h (struct glyph_matrix.rows_allocated)
588 (struct face_cache.size): Now ptrdiff_t, for convenience in use
589 with xpalloc. The values are still always <= INT_MAX.
590
591 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
592
593 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
594 (SAFE_NALLOCA): New macro.
595
596 * region-cache.c (struct boundary.pos, find_cache_boundary)
597 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
598 (set_cache_region, invalidate_region_cache)
599 (revalidate_region_cache, know_region_cache, region_cache_forward)
600 (region_cache_backward, pp_cache):
601 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
602 so that ptrdiff_t * can be passed to xpalloc.
603 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
604 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
605 (pp_cache): Don't assume cache_len fits in int.
606 * region-cache.h: Adjust extern decls to match.
607
608 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
609 EMACS_INT, since either will do, for xpalloc.
610
611 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
612 (xnmalloc, xnrealloc, xpalloc): New functions.
613
726e0ab1
PE
614 * bidi.c (bidi_shelve_header_size): New constant.
615 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
616 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
617
51f30bc5 618 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
619 * buffer.c (overlays_at, overlays_in, record_overlay_string)
620 (overlay_strings):
621 Don't update size of array until after memory allocation succeeds,
622 because xmalloc/xrealloc may not return.
0065d054
PE
623 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
624 now that we have proper integer overflow checking.
625 (record_overlay_string, overlay_strings): Catch overflows when
626 calculating size of overlay_str_buf.
726e0ab1 627
0065d054
PE
628 * callproc.c (Fcall_process): Check for size overflow when
629 calculating size of args2.
630 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
631 Normally we prefer signed values, but sticking with ptrdiff_t would
632 require adding more-complicated checks.
726e0ab1
PE
633
634 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
635 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
636 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 637 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
638
639 * character.c (Fstring): Check for size-calculation overflow.
640
641 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
642 unnecessary integer overflow. Check for size overflow.
643 (encode_coding_object): Don't update size until xmalloc succeeds.
644
645 * composite.c (get_composition_id): Check for overflow in glyph
646 length calculations.
647
648 Integer and memory overflow fixes for display code.
649 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
650 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
651 (scrolling_window): Check for overflow in size calculations.
652 (line_draw_cost, realloc_glyph_pool, add_row_entry):
653 Don't assume glyph table len fits in int.
654 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
655 (row_table_size): Now ptrdiff_t, not int.
656 (scrolling_window): Avoid overflow in size calculations.
657 Don't update size until allocation succeeds.
658 * fns.c (concat): Check for overflow in size calculations.
659 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
660 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
661 (NEXT_ALMOST_PRIME_LIMIT): New constant.
662
663 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
664 (get_doc_string): Check for size calculation overflow.
665 Don't update size until allocation succeeds.
666 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
667 EMACS_INT, where ptrdiff_t will do.
668 (Fsubstitute_command_keys): Check for string overflow.
669
670 * editfns.c (set_time_zone_rule): Don't assume environment length
671 fits in int.
672 (message_length): Now ptrdiff_t, not int.
673 (Fmessage_box): Don't update size until allocation succeeds.
674 Don't assume message length fits in int.
675 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
676
0065d054
PE
677 * emacs.c (main): Do not reallocate argv, since there is a null at
678 the end that can be overwritten, and this way there's no need to
679 worry about size-calculation overflow.
680 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
681
682 * eval.c (init_eval_once, grow_specpdl): Don't update size until
683 alloc succeeds.
684 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
685
686 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
687 (x_set_scroll_bar_width, x_figure_window_size):
688 Check for integer overflow.
689 (x_set_alpha): Do not assume XINT fits in int.
690
691 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
692 This is for the members text_lines, text_cols, total_lines, total_cols,
693 where the system imposes an 'int' limit.
694
695 * fringe.c (Fdefine_fringe_bitmap):
696 Don't update size until alloc works.
697
698 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
699 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
700
701 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
702 Check for size-calculation overflow.
703 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
704 do, as we prefer signed integers.
705 (id_to_widget.max_size, id_to_widget.used)
706 (xg_store_widget_in_map, xg_remove_widget_from_map)
707 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
708 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
709 Use and return ptrdiff_t, not int.
710 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
711 * gtkutil.h: Change prototypes to match the above.
712
713 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
714 are duplicate now that they've been promoted to lisp.h.
715 (x_allocate_bitmap_record, x_alloc_image_color)
716 (make_image_cache, cache_image, xpm_load):
717 Don't update size until alloc is done.
718 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
719 (x_detect_edges):
3256efce 720 Check for size calculation overflow.
726e0ab1
PE
721 (ct_colors_allocated_max): New constant.
722 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
723 overflow.
3256efce 724
726e0ab1
PE
725 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
726 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
727 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
728 Use ptrdiff_t, not int, to count maps.
729 (read_char_minibuf_menu_prompt): Check for overflow in size
730 calculations. Don't update size until allocation succeeds. Redo
731 calculations to avoid overflow.
732 * keyboard.h: Change prototypes to match the above.
733
734 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
735 to count maps.
736 (current_minor_maps): Check for size calculation overflow.
737 * keymap.h: Change prototypes to match the above.
738
739 * lread.c (read1, init_obarray): Don't update size until alloc done.
740
741 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
742 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
743
726e0ab1
PE
744 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
745 Now ptrdiff_t, not int.
746 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
747 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
748
749 * process.c (Fnetwork_interface_list): Check for overflow
750 in size calculation.
751
752 * region-cache.c (move_cache_gap): Check for size calculation overflow.
753
754 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
755 overflow. Don't bother calling xmalloc when xrealloc will do.
756
757 * search.c (Freplace_match): Check for size calculation overflow.
758 (Fset_match_data): Don't assume list lengths fit in 'int'.
759
760 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
761 for command line length. Do not attempt to address one before the
762 beginning of an array, as that's not portable.
763
764 * term.c (max_frame_lines): Remove; unused.
765 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
766 not int.
767 (encode_terminal_code, calculate_costs): Check for size
768 calculation overflow.
769 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
770 table lengths and related sizes. Don't update size until alloc
771 done. Redo calculations to avoid overflow.
772 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
773
774 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
775 subtracting pointers.
776 (gobble_line): Check for overflow more carefully. Don't update size
777 until alloc done.
778
779 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
780 Don't update size until alloc done.
781 Redo size calculations to avoid overflow.
782 Check for size calculation overflow.
0065d054 783 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
784
785 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
786 Use ptrdiff_t, not int, for sizes.
787 (store_mode_line_noprop_char): Don't update size until alloc done.
788
0065d054
PE
789 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
790 Use ptrdiff_t, not int, for sizes.
791 (Finternal_make_lisp_face, cache_face):
792 Check for size calculation overflow.
793 (cache_face): Treat size calculation overflows as if they were
794 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
795
796 * xfns.c (x_encode_text, x_set_name_internal)
797 (Fx_change_window_property): Use ptrdiff_t, not int, to count
798 sizes, since they can exceed INT_MAX in size. Check for size
799 calculation overflow.
800
0065d054
PE
801 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
802 (xg_select): Check for size calculation overflow.
726e0ab1
PE
803 Don't update size until alloc done.
804
0065d054 805 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 806 as sprintf is limited to int lengths.
1d526e2f 807
252c5ee1
PE
808 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
809 (X_LONG_MIN): New macros.
864d7ce7
PE
810 Use them to make the following changes clearer.
811 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
812 This change doesn't affect the value now, but it may help remind
813 future maintainers not to raise the value too much later.
814 (SELECTION_QUANTUM): Remove, replacing with ...
815 (selection_quantum): ... new function, which avoids overflow.
816 All uses changed.
817 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
818 assumption that selection length fits in 'int'.
819 (x_reply_selection_request, x_handle_selection_request)
820 (x_get_window_property, receive_incremental_selection)
821 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
822 (lisp_data_to_selection_data, clean_local_selection_data):
823 Use ptrdiff_t, not int, to record length of selection.
824 (x_reply_selection_request, x_get_window_property)
825 (receive_incremental_selection, x_property_data_to_lisp):
826 Redo calculations to avoid overflow.
827 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 828 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
829 something.
830 (x_get_window_property, receive_incremental_selection)
831 (lisp_data_to_selection_data, x_property_data_to_lisp):
832 Check for size-calculation overflow.
833 (x_get_window_property, receive_incremental_selection)
834 (lisp_data_to_selection_data, Fx_register_dnd_atom):
835 Don't store size until memory allocation succeeds.
836 (x_get_window_property): Plug memory leak on memory exhaustion.
837 Don't double-block input; malloc is safe here. Don't assume 2**34
838 - 4 fits in unsigned long. Add an xassert to check
839 XGetWindowProperty overflow. Be more careful about overflow
840 calculations, and distinguish size from memory overflow better.
841 (receive_incremental_selection): When tracing, don't assume
842 unsigned int is less than INT_MAX.
843 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
844 harmful) conversions of unsigned short to int.
845 (lisp_data_to_selection_data): Don't assume that integers
846 in the range -65535 through -1 fit in an X unsigned short.
847 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
848 result parameters unless successful. Rely on cons_to_unsigned
849 to report problems with elements; the old code wasn't right anyway.
850 (x_check_property_data): Check for int overflow; we cannot use
851 a wider type due to X limits.
852 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
853
726e0ab1 854 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 855
0065d054
PE
856 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
857 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
858 (x_color_cells): Don't store size until memory allocation succeeds.
859 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 860 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
861 (x_term_init): Don't assume length fits in int (sprintf is limited
862 to int size).
bc18e09d 863
ebfa62c0
PE
864 Use ptrdiff_t for composition IDs.
865 * character.c (lisp_string_width):
866 * composite.c (composition_table_size, n_compositions)
867 (get_composition_id, composition_gstring_from_id):
868 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
869 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
870 * window.c (Frecenter):
871 Use ptrdiff_t, not int, for composition IDs.
872 * composite.c (get_composition_id): Check for integer overflow.
873 * composite.h: Adjust prototypes to match the above changes.
874
d3411f89
PE
875 Use ptrdiff_t for hash table indexes.
876 * category.c (hash_get_category_set):
877 * ccl.c (ccl_driver):
878 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
879 * coding.c (coding_system_charset_list, detect_coding_system):
880 * coding.h (struct coding_system.id):
881 * composite.c (get_composition_id, gstring_lookup_cache):
882 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
883 * image.c (xpm_get_color_table_h):
884 * lisp.h (hash_lookup, hash_put):
885 * minibuf.c (Ftest_completion):
886 Use ptrdiff_t for hash table indexes, not int (which is too
887 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
888 32-bit --with-wide-int hosts).
889
e097a6fa
PE
890 * charset.c (Fdefine_charset_internal): Check for integer overflow.
891 Add a FIXME comment about memory leaks.
892 (syms_of_charset): Don't assume xmalloc returns.
893
5637687f
PE
894 Don't assume that stated character widths fit in int.
895 * character.c (Fchar_width, c_string_width, lisp_string_width):
896 * character.h (CHAR_WIDTH):
897 * indent.c (MULTIBYTE_BYTES_WIDTH):
898 Use sanitize_char_width to avoid undefined and/or bad behavior
899 with outlandish widths.
900 * character.h (sanitize_tab_width): Renamed from sanitize_width,
901 now that we have two such functions. All uses changed.
902 (sanitize_char_width): New inline function.
903
a2271ba2
PE
904 Don't assume that tab-width fits in int.
905 * character.h (sanitize_width): New inline function.
906 (SANE_TAB_WIDTH): New macro.
907 (ASCII_CHAR_WIDTH): Use it.
908 * indent.c (sane_tab_width): Remove. All uses replaced by
909 SANE_TAB_WIDTH (current_buffer).
910 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
911
18c52557
PE
912 * fileio.c: Integer overflow issues with file modes.
913 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
914
caeeedc1
PE
915 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
916 Remove unreachable code.
917 (read_hex, load_charset_map_from_file): Check for integer overflow.
918
50849c52
PE
919 * xterm.c: don't go over XClientMessageEvent limit
920 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
921 (x_send_scroll_bar_event): Likewise. Check that the size does not
922 exceed limits imposed by XClientMessageEvent, as well as the usual
923 ptrdiff_t and size_t limits.
924
b13995db
PE
925 * keyboard.c: Overflow, signedness and related fixes.
926 (make_lispy_movement): Use same integer type in forward decl
927 that is used in the definition.
928 (read_key_sequence, keyremap_step):
929 Change bufsize argument back to int, undoing my 2011-03-30 change.
930 We prefer signed types, and int is wide enough here.
931 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
932 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
933 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
934 length, not size_t. Use ptrdiff_t for index, not int.
935 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
936 possibility of integer overflow.
937
13464394
PE
938 Overflow, signedness and related fixes for images.
939
940 * dispextern.h (struct it.stack[0].u.image.image_id)
941 (struct_it.image_id, struct image.id, struct image_cache.size)
942 (struct image_cache.used, struct image_cache.ref_count):
943 * gtkutil.c (update_frame_tool_bar):
944 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
945 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
946 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
947 * nsmenu.m (update_frame_tool_bar):
948 * xdisp.c (calc_pixel_width_or_height):
949 * xfns.c (image_cache_refcount):
950 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
951 on typical 64-bit hosts.
952
953 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
954 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
955 Omit unnecessary casts to int.
956 (parse_image_spec): Check that integers fall into 'int' range
957 when the callers expect that.
958 (image_ascent): Redo ascent calculation to avoid int overflow.
959 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
960 (lookup_image): Remove unnecessary tests.
961 (xbm_image_p): Locals are now of int, not EMACS_INT,
962 since parse_image_check makes sure they fit into int.
963 (png_load, gif_load, svg_load_image):
964 Prefer int to unsigned where either will do.
965 (tiff_handler): New function, combining the cores of the
966 old tiff_error_handler and tiff_warning_handler. This
967 function is rewritten to use vsnprintf and thereby avoid
968 stack buffer overflows. It uses only the features of vsnprintf
969 that are common to both POSIX and native Microsoft.
970 (tiff_error_handler, tiff_warning_handler): Use it.
971 (tiff_load, gif_load, imagemagick_load_image):
972 Don't assume :index value fits in 'int'.
973 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
974 (imagemagick_load_image): Check that crop parameters fit into
975 the integer types that MagickCropImage accepts. Don't assume
976 Vimagemagick_render_type has a nonnegative value. Don't assume
977 size_t fits in 'long'.
978 (gs_load): Use printmax_t to print the widest integers possible.
979 Check for integer overflow when computing image height and width.
980
c11821d4
EZ
9812011-08-26 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (redisplay_window): Don't force window start if point
984 will be invisible in the resulting window. (Bug#9324)
985
0c95fcf7
EZ
9862011-08-25 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
989 the display spec is of the form `(space ...)'.
990 (handle_display_spec): Return the value returned by
991 handle_single_display_spec, not just 1 or zero.
992 (handle_single_display_spec): If the display spec is of the form
993 `(space ...)', and specifies display in the text area, return 2
994 rather than 1.
fee65a97 995 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
996 accurately, and prefer exact match for point under bidi. Don't
997 advance `row' beyond the last row of the window.
0c95fcf7
EZ
998
999 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1000 into disp_prop; all users changed.
1001
1002 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1003 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1004 for the text covered by the display property.
1005
e4ed06f1
CY
10062011-08-25 Chong Yidong <cyd@stupidchicken.com>
1007
1008 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1009 Change return value to nil.
1010 (Frecord_buffer): Delete unused function.
1011
f67cdd7f
EZ
10122011-08-24 Eli Zaretskii <eliz@gnu.org>
1013
5980d4c6
EZ
1014 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1015 buffers, return left-to-right.
8610fe8b
EZ
1016 (set_cursor_from_row): Consider candidate row a win if its glyph
1017 represents a newline and point is on that newline. Fixes cursor
1018 positioning on the newline at EOL of R2L text within L2R
1019 paragraph, and vice versa.
1020 (try_cursor_movement): Check continued rows, in addition to
1021 continuation rows. Fixes unwarranted scroll when point enters a
1022 continued line of R2L text within an L2R paragraph, or vice versa.
1023 (cursor_row_p): Consider the case of point being equal to
1024 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1025 from the end of a short line to the beginning of a continued line
1026 of R2L text within L2R paragraph.
1027 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1028 composed characters.
5980d4c6 1029
f67cdd7f
EZ
1030 * bidi.c (bidi_check_type): Use xassert.
1031 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1032 members.
1033
bca633fb
EZ
10342011-08-23 Eli Zaretskii <eliz@gnu.org>
1035
1036 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1037 a character.
1038
4a5885a7
CY
10392011-08-23 Chong Yidong <cyd@stupidchicken.com>
1040
1041 * nsfont.m (ns_otf_to_script): Fix typo.
1042
0902a04e
KH
10432011-08-22 Kenichi Handa <handa@m17n.org>
1044
1045 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1046 extra slot even if the purpose is char-code-property-table.
1047
1a2e6670
EZ
10482011-08-23 Eli Zaretskii <eliz@gnu.org>
1049
8ddde651
EZ
1050 * xdisp.c (redisplay_window): When computing centering_position,
1051 account for the height of the header line. (Bug#8874)
1052
425cc014
EZ
1053 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1054 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1055 candidate is selected by the mouse, and that candidate has a
1056 composed character under the mouse.
1057
1a2e6670
EZ
1058 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1059 coordinates reported by pos-visible-in-window-p for a composed
1060 character in column zero.
1061
8b76d6f8
SM
10622011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1063
1064 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1065
dac347dd
EZ
10662011-08-22 Eli Zaretskii <eliz@gnu.org>
1067
1068 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1069 consider it a hit if to_charpos is anywhere in the range of the
1070 composed buffer positions.
1071
e013fb34
CY
10722011-08-22 Chong Yidong <cyd@stupidchicken.com>
1073
1074 * image.c (gif_load): Don't assume that each subimage has the same
1075 dimensions as the base image. Handle disposal method that is
1076 "undefined" by the gif spec (Bug#9335).
1077
bd1ba3e8
CY
10782011-08-20 Chong Yidong <cyd@stupidchicken.com>
1079
1080 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1081 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1082
54a1215b
EZ
10832011-08-19 Eli Zaretskii <eliz@gnu.org>
1084
823564e5
EZ
1085 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1086 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1087 from an Org mode buffer to a Speedbar frame.
1088
54a1215b
EZ
1089 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1090 a composition, take its buffer position from IT->cmp_it.charpos.
1091 Fixes cursor positioning at the beginning of a line that begins
1092 with a composed character.
1093
9778ebcc
EZ
10942011-08-18 Eli Zaretskii <eliz@gnu.org>
1095
0be6ee06
EZ
1096 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1097 character bidirectional type, use STRONG_L instead. Fixes crashes
1098 in a buffer produced by `describe-categories'.
1099
9778ebcc
EZ
1100 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1101 members before the level stack, so they would be saved and
1102 restored when copying iterator state. Fixes incorrect reordering
1103 around TABs covered by display properties.
1104
156bffbe
AS
11052011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1106
1107 * process.c (Fnetwork_interface_list): Correctly determine buffer
1108 size.
1109
72ad093b
CY
11102011-08-17 Chong Yidong <cyd@stupidchicken.com>
1111
1112 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1113 (internal_condition_case_2, internal_condition_case_n):
1114 Remove unnecessary aborts (Bug#9081).
72ad093b 1115
35774242
EZ
11162011-08-17 Eli Zaretskii <eliz@gnu.org>
1117
1118 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1119 has no `load' handler, try opening the file locally. (Bug#9311)
1120
db76dd85
KB
11212011-08-16 Ken Brown <kbrown@cornell.edu>
1122
1123 * gmalloc.c: Expand comment.
1124
b215eee5
EZ
11252011-08-16 Eli Zaretskii <eliz@gnu.org>
1126
1127 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1128 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1129
a4579d33
KB
11302011-08-16 Ken Brown <kbrown@cornell.edu>
1131
1132 Fix memory allocation problems in Cygwin build (Bug#9273).
1133
1134 * unexcw.c ( __malloc_initialized): Declare external variable.
1135 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1136
8b76d6f8
SM
1137 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1138 New variables.
a4579d33
KB
1139 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1140 dumped emacs.
1141 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1142 in the static heap.
1143 [CYGWIN] (special_realloc): New function.
1144 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1145 requests to realloc storage in the static heap.
1146
3ebec551
PE
11472011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 * bidi.c (bidi_initialize): Remove unused local.
1150
9fd8be00
EZ
11512011-08-15 Eli Zaretskii <eliz@gnu.org>
1152
474a8465
EZ
1153 * biditype.h: File removed.
1154
1155 * bidimirror.h: File removed.
1156
1157 * deps.mk (bidi.o): Remove biditype.h and
1158 bidimirror.h.
1159
1160 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1161 bidimirror.h.
1162
1163 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1164
1165 * chartab.c: Improve commentary for the uniprop_table API.
1166
32413314
EZ
1167 * bidi.c (bidi_paragraph_init): Support zero value of
1168 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1169 (bidi_initialize): Use uniprop_table instead of including
1170 biditype.h and bidimirror.h.
32413314 1171
9fd8be00
EZ
1172 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1173 coordinates of the iterator when restoring from ppos_it.
1174 (Bug#9296)
1175
5cf2b69b
KH
11762011-08-14 Kenichi Handa <handa@m17n.org>
1177
1178 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1179 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1180
daf17d00
EZ
11812011-08-14 Eli Zaretskii <eliz@gnu.org>
1182
1183 * xdisp.c (move_it_in_display_line_to): Don't invoke
1184 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1185 ppos_it. Fixes vertical cursor motion when line beginning is
1186 covered by an image. (Bug#9296)
1187
08e3161a
JD
11882011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1189
1190 * nsterm.h (ns_run_ascript): Declare.
1191 (NSAPP_DATA2_RUNASSCRIPT): Define.
1192
1193 * nsfns.m (as_script, as_result, as_status): New static variables.
1194 (ns_run_ascript): New function.
5e617bc2 1195 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1196 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1197 the event loop. Get status from as_status (Bug#7276).
1198
1199 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1200 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1201 the event loop (Bug#7276).
1202
a3720aa2
AS
12032011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1204
1205 * gnutls.c (QCgnutls_bootprop_priority)
1206 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1207 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1208 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1209 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1210 (QCgnutls_bootprop_verify_hostname_error)
1211 (QCgnutls_bootprop_callbacks_verify): Rename from
1212 Qgnutls_bootprop_..., all uses changed.
1213
1214 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1215 uses changed.
1216
0a0d27fb
PE
12172011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1218
19d5c50c
PE
1219 * xfaces.c (Qframe_set_background_mode): Now static.
1220 * dispextern.h (Qframe_set_background_mode): Remove decl.
1221
0a0d27fb
PE
1222 * process.c (Fnetwork_interface_info): Declare local only if needed.
1223
377538cb
JD
12242011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1225
1226 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1227 (Fnetwork_interface_list): Allocate in increments of bytes instead
1228 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1229 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1230 sockaddr.
1231 (struct ifflag_def): notrailers is smart on OSX.
1232 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1233 Get hardware address with getifaddrs if available.
1234
08fff70c
EZ
12352011-08-12 Eli Zaretskii <eliz@gnu.org>
1236
1237 * xdisp.c (iterate_out_of_display_property): xassert that
1238 IT->position is set to within IT->object's boundaries. Break from
1239 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1240 when IT->position is set up wrongly due to some bug.
1241 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1242 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1243 entry. Force push_it to save on the stack the current
1244 buffer/string position, to be restored by pop_it. Fix flags in
1245 the iterator structure wrt the object coming from a display
1246 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1247 properties. (Bug#9284)
1248
7be1c708 12492011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1250
7be1c708
CY
1251 * fontset.c (fontset_get_font_group): Add proper type checks.
1252 (Bug#9172)
aac0c6e3 1253
7be1c708 12542011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1255
7be1c708
CY
1256 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1257 and LC_VERSION_MIN_MACOSX.
1258 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1259 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1260
97bb72a6
EZ
12612011-08-08 Eli Zaretskii <eliz@gnu.org>
1262
1263 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1264 no-display-properties-and-no-overlays under bidi display.
1265 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1266 properties and overlays.
97bb72a6 1267
d5617611
CY
12682011-08-08 Chong Yidong <cyd@stupidchicken.com>
1269
37e11a63
CY
1270 * editfns.c (Fset_time_zone_rule): Document relationship with the
1271 setenv function.
1272
d5617611
CY
1273 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1274 the font entity extracted from the cache (Bug#8109).
1275
58872834
CY
12762011-08-07 Chong Yidong <cyd@stupidchicken.com>
1277
1278 * composite.c (autocmp_chars): Don't reset point. That is done by
1279 restore_point_unwind (Bug#5984).
1280
75bfc667
JL
12812011-08-07 Juri Linkov <juri@jurta.org>
1282
1283 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1284 to show the arg `TIME' instead of `TIMEVAL'.
1285
d1410150
EZ
12862011-08-06 Eli Zaretskii <eliz@gnu.org>
1287
1288 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1289 display property strides EOL and includes a newline, as in
1290 longlines-mode. (Bug#9254)
75b771e4
EZ
1291 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1292 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1293
1294 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1295 is non-zero, even if the data buffer is NULL. Fixes a crash in
1296 vertical-motion with longlines-mode. (Bug#9254)
1297
35928349
EZ
12982011-08-05 Eli Zaretskii <eliz@gnu.org>
1299
ec7cc85b
EZ
1300 * bidi.c <bidi_cache_total_alloc>: Now static.
1301 (bidi_initialize): Initialize bidi_cache_total_alloc.
1302
8b76d6f8 1303 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1304 cache. (Bug#9221)
1305
1306 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1307 amount allocated this far in `bidi_cache_total_alloc'.
1308 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1309 non-zero, only free the data buffer without restoring the cache
1310 contents. All callers changed.
1311
1312 * dispextern.h (bidi_unshelve_cache): Update prototype.
1313
1314 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1315 (move_it_in_display_line, move_it_to)
1316 (move_it_vertically_backward, move_it_by_lines): Replace the call
1317 to xfree to an equivalent call to bidi_unshelve_cache.
1318 (move_it_in_display_line_to): Fix logic of returning
412b6358 1319 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1320
e2e2423b
EZ
13212011-08-05 Eli Zaretskii <eliz@gnu.org>
1322
1323 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1324 came from a string character with a `cursor' property. (Bug#9229)
1325
ae9e757a
JD
13262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1327
1328 * Makefile.in (LIB_PTHREAD): New variable.
1329 (LIBES): Add LIB_PTHREAD (Bug#9216).
1330
1331 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1332 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1333
213bd7f2
AS
13342011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1335
1336 * regex.c (re_iswctype): Remove some redundant boolean
1337 conversions.
1338
99aaf75f
JD
13392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1340
1341 * xterm.c (x_find_topmost_parent): New function.
1342 (x_set_frame_alpha): Find topmost parent window with
1343 x_find_topmost_parent and set the property there also (bug#9181).
1344 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1345
c74e9d86
PE
13462011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 * callproc.c (Fcall_process): Avoid vfork clobbering
1349 the local vars buffer, coding_systems, current_dir.
1350
640c8776
SM
13512011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1352
1353 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1354
f26d0e4c
PE
13552011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1356
8a10d76c
PE
1357 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1358 so that it is not optimized away.
1359
f26d0e4c
PE
1360 * xdisp.c (compute_display_string_pos): Remove unused local.
1361
55439c61
EZ
13622011-08-02 Eli Zaretskii <eliz@gnu.org>
1363
1364 Fix slow cursor motion and scrolling in large buffers with
1365 selective display, like Org Mode buffers. (Bug#9218)
1366
1367 * dispextern.h (struct bidi_it): New member disp_prop_p.
1368
1369 * xdisp.c: Remove one-slot cache of display string positions.
1370 (compute_display_string_pos): Accept an additional argument
5e617bc2 1371 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1372 for a display string or property. If found, set DISP_PROP_P
1373 non-zero.
1374
1375 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1376 DISP_PROP_P, and pass it to compute_display_string_pos.
1377 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1378 non-zero. All callers of bidi_fetch_char changed.
1379
fb33fa43
SM
13802011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1381
1382 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1383
b099e063
DM
13842010-12-03 Don March <don@ohspite.net>
1385
1386 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1387 last character M-[char] is translated to ESC [char] (bug#7541).
1388
5cc7f7af
KH
13892011-08-02 Kenichi Handa <handa@m17n.org>
1390
d0fffa3f 1391 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1392
1393 * chartab.c (uniprop_table): Make it non-static.
1394
525d5e6e
EZ
13952011-08-01 Eli Zaretskii <eliz@gnu.org>
1396
1397 * xdisp.c (forward_to_next_line_start): Accept additional argument
1398 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1399 on the newline.
1400 (reseat_at_next_visible_line_start): Use the bidi iterator state
1401 returned by forward_to_next_line_start to restore the state of
1402 it->bidi_it after backing up to previous newline. (Bug#9212)
1403
31011111
AS
14042011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1405
1406 * regex.c (re_comp): Protoize.
1407 (re_exec): Fix return type.
1408 (regexec): Fix type of `ret'. (Bug#9203)
1409
476371c4
PE
14102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1411
e5d76069
PE
1412 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1413 This is needed if max-image-size is a floating-point number.
1414
9a79b20c
AS
14152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1416
1417 * print.c (print_object): Print empty symbol as ##.
1418
1419 * lread.c (read1): Read ## as empty symbol.
1420
d8c2fa78
AA
14212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1422
1423 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1424 setting frame foreground color (Bug#9175).
1425 (x_set_background_color): Likewise.
1426
ffe57a7a
AA
1427 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1428 contents (Bug#9176).
1429 (EmacsTooltip -init): Remove bezels and add shadows to
1430 tooltip windows.
1431
bf3492a5
AA
1432 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1433 or scroll bar (Bug#8470).
1434
d55e9c53
AA
1435 * nsfont.m (nsfont_open): Remove assignment to voffset and
1436 unnecessary vars hshink, expand, hd, full_height, min_height.
1437 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1438
1439 * nsterm.h (nsfont_info): Remove voffset field.
1440
d8c2fa78 14412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1442
1443 Implement strike-through and overline on NextStep (Bug#8863).
1444
1445 * nsfont.m (nsfont_open): Use underline position provided by font,
1446 instead of hard-coded value of 2.
1447 (nsfont_draw): Call ns_draw_text_decoration instead.
1448
1449 * nsterm.h: Add declaration for ns_draw_text_decoration.
1450
1451 * nsterm.m (ns_draw_text_decoration): New function for drawing
1452 underline, overline, and strike-through.
1453 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1454 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1455 accommodate underlining, etc.
4843aac3 1456
4cc60b9b
EZ
14572011-07-28 Eli Zaretskii <eliz@gnu.org>
1458
bc7ece87
EZ
1459 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1460 default.
4cc60b9b 1461
476371c4
PE
14622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1463
66606eea
PE
1464 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1465 Without this fix, if a signal arrives just after memory fills up,
1466 'malloc' might be invoked reentrantly.
1467
476371c4
PE
1468 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1469 In other words, assume that every image size is allowed, on non-X
1470 hosts. This assumption is probably wrong, but it lets Emacs compile.
1471
f3fcc40d
AS
14722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1473
1474 * regex.c (re_iswctype): Convert return values to boolean.
1475
350c992f
EZ
14762011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1477
1478 * xdisp.c (compute_display_string_pos): Don't use cached display
1479 string position if the buffer had its restriction changed.
1480 (Bug#9184)
1481
5266b4bb
PE
14822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1485
2573a837 14862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1487
41f55ccd 1488 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1489
39e378da
PE
1490 * bidi.c: Integer size and overflow fixes.
1491 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1492 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1493 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1494 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1495 (bidi_find_other_level_edge):
1496 Use ptrdiff_t instead of EMACS_INT where either will do.
1497 This works better on 32-bit hosts configured --with-wide-int.
1498 (bidi_cache_ensure_space): Check for size-calculation overflow.
1499 Use % rather than repeated addition, for better worst-case speed.
1500 Don't set bidi_cache_size until after xrealloc returns, because it
1501 might not return.
1502 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1503 (bidi_cache_ensure_space): Also check that the bidi cache size
1504 does not exceed that of the largest Lisp string or buffer. See Eli
1505 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1506
5e927815
PE
1507 * alloc.c (__malloc_size_t): Remove.
1508 All uses replaced by size_t. See Andreas Schwab's note
1509 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1510
ca4aa935
PE
1511 * image.c: Improve checking for integer overflow.
1512 (check_image_size): Assume that f is nonnull, since
1513 it is always nonnull in practice. This is one less thing to
1514 worry about when checking for integer overflow later.
1515 (x_check_image_size): New function, which checks for integer
1516 overflow issues inside X.
1517 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1518 This removes the need for a memory_full check.
1519 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1520 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1521 (xbm_read_bitmap_data): Change locals back to 'int', since
1522 their values must fit in 'int'.
1523 (xpm_load_image, png_load, tiff_load):
1524 Invoke x_create_x_image_and_pixmap earlier,
1525 to avoid much needless work if the image is too large.
1526 (tiff_load): Treat overly large images as if
1527 x_create_x_image_and_pixmap failed, not as malloc failures.
1528 (gs_load): Use x_check_image_size.
1529
5f8f9cc2
PE
1530 * gtkutil.c: Omit integer casts.
1531 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1532 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1533
5adf60bc
PE
1534 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1535
c8907a93
PE
1536 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1537 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1538 would wrongly return t on a 64-bit host.
1539
e3c25c68
PE
1540 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1541 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1542 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1543 and therefore cause GCC to emit a bogus diagnostic in some cases.
1544
3f791afe
PE
1545 * image.c: Integer signedness and overflow and related fixes.
1546 This is not an exhaustive set of fixes, but it's time to
1547 record what I've got.
1548 (lookup_pixel_color, check_image_size): Remove redundant decls.
1549 (check_image_size): Don't assume that arbitrary EMACS_INT values
1550 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1551 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1552 (tiff_load, imagemagick_load_image):
1553 Check for overflow in size calculations.
1554 (x_create_x_image_and_pixmap): Remove unnecessary test for
1555 xmalloc returning NULL; that can't happen.
1556 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1557 (xpm_color_bucket): Use better integer hashing function.
1558 (xpm_cache_color): Don't possibly over-allocate memory.
1559 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1560 (gif_memory_source):
1561 Use ptrdiff_t, not int or size_t, to record sizes.
1562 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1563 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1564 either works, as we prefer signed integers.
1565 (tiff_read_from_memory, tiff_write_from_memory):
1566 Return tsize_t, not size_t, since that's what the TIFF API wants.
1567 (tiff_read_from_memory): Don't fail simply because the read would
1568 go past EOF; instead, return a short read.
1569 (tiff_load): Omit no-longer-needed casts.
1570 (Fimagemagick_types): Don't assume size fits into 'int'.
1571
3cc5a532
PE
1572 Improve hashing quality when configured --with-wide-int.
1573 * fns.c (hash_string): New function, taken from sxhash_string.
1574 Do not discard information about ASCII character case; this
1575 discarding is no longer needed.
1576 (sxhash-string): Use it. Change sig to match it. Caller changed.
1577 * lisp.h: Declare it.
1578 * lread.c (hash_string): Remove, since we now use fns.c's version.
1579 The fns.c version returns a wider integer if --with-wide-int is
1580 specified, so this should help the quality of the hashing a bit.
1581
b312a492
PE
1582 * emacs.c: Integer overflow minor fix.
1583 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1584 Define only if GNU_LINUX.
1585 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1586
dfd153ae
PE
1587 * dispnew.c: Integer signedness and overflow fixes.
1588 Remove unnecessary forward decls, that were a maintenance hassle.
1589 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1590 All uses changed.
1591 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1592 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1593 (prepare_desired_row, line_draw_cost):
1594 Use int, not unsigned, where either works.
1595 (save_current_matrix, restore_current_matrix):
1596 Use ptrdiff_t, not size_t, where either works.
1597 (init_display): Check for overflow more accurately, and without
1598 relying on undefined behavior.
1599
a81d11a3
PE
1600 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1601 Remove, replacing with the new symbols in lisp.h. All uses changed.
1602 * fileio.c (make_temp_name):
1603 * filelock.c (lock_file_1, lock_file):
1604 * xdisp.c (message_dolog):
1605 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1606 Use pMd etc. instead.
1607 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1608 replacing the pWIDE etc. symbols removed from editfns.c.
1609
3300e6fd
PE
1610 * keyboard.h (num_input_events): Now uintmax_t.
1611 This is (very slightly) less likely to mess up due to wraparound.
1612 All uses changed.
1613
fd05c7e9
PE
1614 * buffer.c: Integer signedness fixes.
1615 (alloc_buffer_text, enlarge_buffer_text):
1616 Use ptrdiff_t rather than size_t when either will do, as we prefer
1617 signed integers.
1618
903fe15d
PE
1619 * alloc.c: Integer signedness and overflow fixes.
1620 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1621 (__malloc_size_t): Default to size_t, not to int.
1622 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1623 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1624 Prefer ptrdiff_t to size_t when either would do, as we prefer
1625 signed integers.
1626 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1627 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1628 Now const. Initialize with values that are in range even if char
1629 is signed.
1630 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1631 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1632 These functions do the right thing with sizes > 2**32.
1633 (check_depth): Now ptrdiff_t, not int.
1634 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1635 Adjust to new way of storing sizes. Check for size overflow bugs
1636 in rest of code.
1637 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1638 slightly wrong anyway, as it missed one instance of
1639 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1640 (refill_memory_reserve): Omit needless cast to size_t.
1641 (mark_object_loop_halt): Mark as externally visible.
1642
ac82cc6a
PE
1643 * xselect.c: Integer signedness and overflow fixes.
1644 (Fx_register_dnd_atom, x_handle_dnd_message):
1645 Use ptrdiff_t, not size_t, since we prefer signed.
1646 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1647 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1648 x_dnd_atoms_size and x_dnd_atoms_length.
1649
c2d1e36d
PE
1650 * doprnt.c: Prefer signed to unsigned when either works.
1651 * eval.c (verror):
1652 * doprnt.c (doprnt):
1653 * lisp.h (doprnt):
1654 * xdisp.c (vmessage):
1655 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1656 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1657 prefer signed arithmetic to avoid comparison confusion.
1658 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1659 but is a bit tricky.
1660
0e926e56
PE
1661 Assume freestanding C89 headers, string.h, stdlib.h.
1662 * data.c, doprnt.c, floatfns.c, print.c:
1663 Include float.h unconditionally.
1664 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1665 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1666 * regex.c: Likewise for stddef.h, string.h.
1667 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1668 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1669 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1670 (STDC_HEADERS): Remove obsolete defines.
1671 * sysdep.c: Include limits.h unconditionally.
1672
9cfdb3ec
PE
1673 Assume support for memcmp, memcpy, memmove, memset.
1674 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1675 * regex.c (memcmp, memcpy):
1676 Remove; we assume C89 now.
1677
1678 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1679 (__malloc_safe_bcopy): Remove; no longer needed.
1680
cf950e6b 1681 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1682 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1683 well either way, and we prefer signed to unsigned.
1684
dbf38e02
LMI
16852011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1686
1687 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1688 closes the connection while we're reading (bug#9182).
1689
d6f0886c 16902011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1691
d6f0886c
JD
1692 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1693 are specified (Bug#9168).
24e0f6b1 1694
2eb1f9e6
PE
16952011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1696
1697 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1698 Found by GCC static checking and --with-wide-int on a 32-bit host.
1699
22381272 17002011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1701
1702 * xdisp.c (compute_display_string_pos): Fix logic of caching
1703 previous display string position. Initialize cached_prev_pos to
1704 -1. Fixes slow-down at the beginning of a buffer.
1705
f25e39b4
EZ
17062011-07-24 Eli Zaretskii <eliz@gnu.org>
1707
1708 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1709 for attrs[LFACE_FONTSET_INDEX].
1710
04c4b52e
PE
17112011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * xml.c (parse_region): Remove unused local
1714 that was recently introduced.
1715
c1734fbd
EZ
17162011-07-23 Eli Zaretskii <eliz@gnu.org>
1717
be18c5a5
EZ
1718 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1719 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1720
c1734fbd
EZ
1721 * xdisp.c (move_it_in_display_line_to): Record the best matching
1722 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1723 exit if none of the characters scanned was an exact match.
1724 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1725 when exact match is impossible due to invisible text, and the
1726 lines are truncated.
1727
a258d627
JD
17282011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1729
1730 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1731 for OSX >= 10.7.
1732
b6d5a689
EZ
17332011-07-22 Eli Zaretskii <eliz@gnu.org>
1734
0f74f785
EZ
1735 Fix a significant slow-down of cursor motion with C-n, C-p,
1736 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1737 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1738 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1739 (next_element_from_buffer): Call compute_stop_pos_backwards to
1740 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1741 base_level_stop.
1742 (reseat): Don't look for prev_stop, as that could mean a very long
1743 run.
1744 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1745 <cached_disp_overlay_modiff>: Cache for last found display string
1746 position.
551918c1 1747 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1748 about the same buffer in the same area of character positions, and
1749 the buffer wasn't changed since the time the display string
1750 position was cached.
551918c1 1751
b2d0c91a
EZ
17522011-07-22 Eli Zaretskii <eliz@gnu.org>
1753
1754 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1755 is an integer, which is important for empty lines. (Bug#9149)
1756
043604ee
CY
17572011-07-22 Chong Yidong <cyd@stupidchicken.com>
1758
1759 * frame.c (Fmodify_frame_parameters): In tty case, update the
1760 default face if necessary (Bug#4238).
1761
da4adb04
CY
17622011-07-21 Chong Yidong <cyd@stupidchicken.com>
1763
1764 * editfns.c (Fstring_to_char): No need to explain what a character
1765 is in the docstring (Bug#6576).
1766
9abd0532
LMI
17672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1768
1769 * xml.c (parse_region): Make sure we always return a tree.
1770
36881d16
HK
17712011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1772
1773 * xml.c (parse_region): If a document contains only comments,
1774 return that, too.
1775
1e98674d
LMI
17762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1777
1778 * xml.c (make_dom): Return comments, too.
1779
590bd467
PE
17802011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 Port to OpenBSD.
1783 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1784 and the surrounding thread.
1785 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1786 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1787 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1788 timer goes off.
1789 * s/openbsd.h (BROKEN_SIGIO): Define.
1790 * unexelf.c (unexec) [__OpenBSD__]:
1791 Don't update the .mdebug section of the Alpha COFF symbol table.
1792
f41628b2
LMI
17932011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1794
1795 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1796 (bug#8460).
1797
b59b67c5
PE
17982011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1799
15e3a074
PE
1800 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1801 This fixes some race conditions on the permissions of any newly
1802 created file.
1803
41bed37d
PE
1804 * alloc.c (valid_pointer_p): Use pipe, not open.
1805 This fixes some permissions issues when debugging.
1806
b59b67c5
PE
1807 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1808 If fchown fails to set both uid and gid, try to set just gid,
1809 as that is sometimes allowed. Adjust the file's mode to eliminate
1810 setuid or setgid bits that are inappropriate if fchown fails.
1811
925a6be7
SM
18122011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1815 to compare Lisp_Objects.
1816 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1817 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1818 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1819
52968808
AS
18202011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1821
0a6a104b
AS
1822 * lread.c (read_integer): Unread even EOF character.
1823 (read1): Likewise. Properly record start position of symbol.
1824
52968808
AS
1825 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1826 symbol character follows.
1827
9e381cdd
PE
18282011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1831 This works around a problem with the previous change to Fcopy_file.
1832 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1833 and without this change, GCC might complain about discarding
1834 fchown's return value.
1835
b5641435
JB
18362011-07-16 Juanma Barranquero <lekktu@gmail.com>
1837
1838 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1839
a8031457
PE
18402011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1843
dd889327
LMI
18442011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1845
750c33f7
LMI
1846 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1847 it's used from the C level.
1848
dd889327
LMI
1849 * process.c: Use the same condition for POLL_FOR_INPUT in both
1850 keyboard.c and process.c (bug#1858).
1851
87e86684
LM
18522011-07-09 Lawrence Mitchell <wence@gmx.li>
1853
1854 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1855 (Fgnutls_boot): Use it.
1856
64348f40
AS
18572011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1858
1859 * doc.c (Fsubstitute_command_keys): Revert last change.
1860
1d698799
LMI
18612011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1862
f863868c
LMI
1863 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1864 quotes the next character, and doesn't affect other longer
1865 sequences (bug#8935).
1866
1d698799
LMI
1867 * lread.c (syms_of_lread): Clarify that is isn't only
1868 `eval-buffer' and `eval-defun' that's affected by
1869 `lexical-binding' (bug#8460).
1870
aa4b6df6
EZ
18712011-07-15 Eli Zaretskii <eliz@gnu.org>
1872
1873 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1874 bidi redisplay when a line includes both an image and is
1875 truncated.
1876
5d856da6
PE
18772011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1878
ad6042bb
PE
1879 Fix minor problems found by static checking.
1880 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1881 (elsz): Now a signed constant, not a size_t var. We prefer signed
1882 types to unsigned, to avoid integer comparison confusion. Without
1883 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1884 "cannot optimize loop, the loop counter may overflow", a symptom
1885 of the confusion.
f00bbb22 1886 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1887 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1888
6468f31c
LMI
18892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1890
49080b10
LMI
1891 * search.c (Fre_search_backward): Mention `case-fold-search' in
1892 all the re_search_* functions (bug#8138).
1893
6468f31c
LMI
1894 * keyboard.c (Fopen_dribble_file): Document when the file is
1895 closed (bug#8056).
1896
c965adc5
EZ
18972011-07-14 Eli Zaretskii <eliz@gnu.org>
1898
df9733bf
EZ
1899 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1900 bidi_cache_idx.
1901
0bb23927
EZ
1902 Support bidi reordering of display and overlay strings.
1903 * xdisp.c (compute_display_string_pos)
1904 (compute_display_string_end): Accept additional argument STRING.
1905 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1906 (reseat_to_string): Initialize bidi_it->string.s and
1907 bidi_it->string.schars.
1908 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1909 NULL (avoids a crash in bidi_paragraph_init).
1910 Initialize itb.string.lstring.
0bb23927
EZ
1911 (init_iterator): Call bidi_init_it only of a valid
1912 buffer position was specified. Initialize paragraph_embedding to
1913 L2R.
1914 (reseat_to_string): Initialize the bidi iterator.
1915 (display_string): If we need to ignore text properties of
1916 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1917 original value of -1 will not work with bidi.)
1918 (compute_display_string_pos): First arg is now struct
1919 `text_pos *'; all callers changed. Support display properties on
1920 Lisp strings.
1921 (compute_display_string_end): Support display properties on Lisp
1922 strings.
1923 (init_iterator, reseat_1, reseat_to_string): Initialize the
1924 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1925 when iterating on a string not from display properties).
640c8776
SM
1926 (compute_display_string_pos, compute_display_string_end):
1927 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1928 arrow keys.
1929 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1930 base_level_stop; instead, set base_level_stop to BEGV.
1931 Fixes crashes in vertical-motion.
0bb23927
EZ
1932 (next_element_from_buffer): Improve commentary for when
1933 the iterator is before prev_stop.
1934 (init_iterator): Initialize bidi_p from the default value of
1935 bidi-display-reordering, not from buffer-local value. Use the
1936 buffer-local value only if initializing for buffer iteration.
1937 (handle_invisible_prop): Support invisible properties on strings
1938 that are being bidi-reordered.
1939 (set_iterator_to_next): Support bidi reordering of C strings and
1940 Lisp strings.
1941 (next_element_from_string): Support bidi reordering of Lisp
1942 strings.
1943 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1944 (display_string): Support display of R2L glyph rows.
1945 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1946 (init_iterator): Don't initialize it->bidi_p for strings
1947 here.
1948 (reseat_to_string): Initialize it->bidi_p for strings here.
1949 (next_element_from_string, next_element_from_c_string)
1950 (next_element_from_buffer): Add xassert's for correspondence
1951 between IT's object being iterated and it->bidi_it.string
1952 structure.
1953 (face_before_or_after_it_pos): Support bidi iteration.
1954 (next_element_from_c_string): Handle the case of the first string
1955 character that is not the first one in the visual order.
1956 (get_visually_first_element): New function, refactored from common
1957 parts of next_element_from_buffer, next_element_from_string, and
1958 next_element_from_c_string.
1959 (tool_bar_lines_needed, redisplay_tool_bar)
1960 (display_menu_bar): Force left-to-right direction. Add a FIXME
1961 comment for making that be controlled by a user option.
1962 (push_it, pop_it): Save and restore the state of the
1963 bidi iterator. Save and restore the bidi_p flag.
1964 (pop_it): Iterate out of display property for string iteration as
1965 well.
1966 (iterate_out_of_display_property): Support iteration over strings.
1967 (handle_single_display_spec): Set up it->bidi_it for iteration
1968 over a display string, and call bidi_init_it.
1969 (handle_single_display_spec, next_overlay_string)
1970 (get_overlay_strings_1, push_display_prop): Set up the bidi
1971 iterator for displaying display or overlay strings.
1972 (forward_to_next_line_start): Don't use the shortcut if
1973 bidi-iterating.
1974 (back_to_previous_visible_line_start): If handle_display_prop
1975 pushed the iterator stack, restore the internal state of the bidi
1976 iterator by calling bidi_pop_it same number of times.
1977 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1978 and we are bidi-iterating, don't decrement the iterator position;
1979 instead, set the first_elt flag in the bidi iterator, to produce
1980 the same effect.
1981 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1982 (push_display_prop): xassert that we are iterating a buffer.
1983 (push_it, pop_it): Save and restore paragraph_embedding member.
1984 (handle_single_display_spec, next_overlay_string)
1985 (get_overlay_strings_1, reseat_1, reseat_to_string)
1986 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1987 correctly. Don't assume unibyte strings are not bidi-reordered.
1988 (compute_display_string_pos)
1989 (compute_display_string_end): Fix handling the case of C string.
1990 (push_it, pop_it): Save and restore from_disp_prop_p.
1991 (handle_single_display_spec, push_display_prop): Set the
1992 from_disp_prop_p flag.
1993 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1994 (pop_it): Call iterate_out_of_display_property only if we are
1995 popping after iteration over a string that came from a display
1996 property. Fix a typo in popping stretch info. Add an assertion
1997 for verifying that the iterator position is in sync with the bidi
1998 iterator.
1999 (handle_single_display_spec, get_overlay_strings_1)
2000 (push_display_prop): Fix initialization of paragraph direction for
2001 string when that of the parent object is not yet determined.
2002 (reseat_1): Call bidi_init_it to resync the bidi
2003 iterator with IT's position. (Bug#7616)
2004 (find_row_edges): If ROW->start.pos gives position
2005 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2006 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2007 Reset the from_disp_prop_p flag.
2008 (SAVE_IT, RESTORE_IT): New macros.
2009 (pos_visible_p, face_before_or_after_it_pos)
2010 (back_to_previous_visible_line_start)
2011 (move_it_in_display_line_to, move_it_in_display_line)
2012 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2013 (try_scrolling, redisplay_window, display_line): Use them when
2014 saving a temporary copy of the iterator and restoring it back.
2015 (back_to_previous_visible_line_start, reseat_1)
2016 (init_iterator): Empty the bidi cache "stack".
2017 (move_it_in_display_line_to): If iterator ended up at
2018 EOL, but we never saw any buffer positions smaller than
2019 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2020 motion in bidi-reordered lines.
2021 (move_it_in_display_line_to): Record prev_method and prev_pos
2022 immediately before the call to set_iterator_to_next. Fixes cursor
2023 motion in bidi-reordered lines with stretch glyphs and strings
2024 displayed in margins. (Bug#8133) (Bug#8867)
2025 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2026 TO_CHARPOS.
640c8776
SM
2027 (pos_visible_p): Support positions in bidi-reordered lines.
2028 Save and restore bidi cache.
0bb23927
EZ
2029
2030 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2031 (bidi_paragraph_info): Delete unused struct.
2032 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2033 (bidi_cache_start): New variable.
2034 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2035 to zero.
2036 (bidi_cache_fetch_state, bidi_cache_search)
2037 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2038 (bidi_cache_find, bidi_peek_at_next_level)
2039 (bidi_level_of_next_char, bidi_find_other_level_edge)
2040 (bidi_move_to_visually_next): Compare cache index with
2041 bidi_cache_start rather than with zero.
2042 (bidi_fetch_char): Accept new argument STRING; all callers
2043 changed. Support iteration over a string. Support strings with
2044 display properties. Support unibyte strings. Fix the type of
2045 `len' according to what STRING_CHAR_AND_LENGTH expects.
2046 (bidi_paragraph_init, bidi_resolve_explicit_1)
2047 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2048 (bidi_level_of_next_char, bidi_move_to_visually_next):
2049 Support iteration over a string.
0bb23927
EZ
2050 (bidi_set_sor_type, bidi_resolve_explicit_1)
2051 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2052 can now be zero (for strings); special values 0 and -1 were
2053 changed to -1 and -2, respectively.
2054 (bidi_char_at_pos): New function.
2055 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2056 Call it instead of FETCH_MULTIBYTE_CHAR.
2057 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2058 initialized to valid values.
2059 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2060 values.
2061 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2062 the test for valid cached positions. Fix the logic for looking up
2063 the sentinel state in the cache. GCPRO the Lisp string we are
2064 iterating.
2065 (bidi_push_it, bidi_pop_it): New functions.
2066 (bidi_initialize): Initialize the bidi cache start stack pointer.
2067 (bidi_cache_ensure_space): New function, refactored from part of
2068 bidi_cache_iterator_state. Don't assume the required size is just
2069 one BIDI_CACHE_CHUNK away.
2070 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2071 (bidi_count_bytes, bidi_char_at_pos): New functions.
2072 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2073 always valid if bidi_cache_idx is valid.
2074 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2075 is valid if it's going to be used.
2076 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2077 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2078 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2079 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2080 (bidi_find_other_level_edge, bidi_cache_start_stack):
2081 All variables related to cache indices are now EMACS_INT.
c965adc5 2082
0bb23927
EZ
2083 * dispextern.h (struct bidi_string_data): New structure.
2084 (struct bidi_it): New member `string'. Make flag members be 1-bit
2085 fields, and put them last in the struct.
640c8776
SM
2086 (compute_display_string_pos, compute_display_string_end):
2087 Update prototypes.
0bb23927
EZ
2088 (bidi_push_it, bidi_pop_it): Add prototypes.
2089 (struct iterator_stack_entry): New members bidi_p,
2090 paragraph_embedding, and from_disp_prop_p.
2091 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2092 (bidi_shelve_cache, bidi_unshelve_cache):
2093 Declare prototypes.
0bb23927
EZ
2094
2095 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2096 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2097 and vector-like objects.
2098
2099 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2100 cache around display iteration.
2101
2102 * window.c (Fwindow_end, window_scroll_pixel_based)
2103 (displayed_window_lines, Frecenter): Save and restore the bidi
2104 cache around display iteration.
2105
3bbd2265
LMI
21062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2107
2108 * editfns.c (Fdelete_region): Clarify the use of the named
2109 parameters (bug#6788).
2110
adc47434
MR
21112011-07-14 Martin Rudalics <rudalics@gmx.at>
2112
2113 * indent.c (Fvertical_motion): Set and restore w->pointm when
2114 saving and restoring the window's buffer (Bug#9006).
2115
837c31f8
LMI
21162011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2117
2118 * editfns.c (Fstring_to_char): Clarify just what is returned
2119 (bug#6576). Text by Eli Zaretskii.
2120
ac389d0c
JB
21212011-07-13 Juanma Barranquero <lekktu@gmail.com>
2122
2123 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2124
0be0ce47
EZ
21252011-07-13 Eli Zaretskii <eliz@gnu.org>
2126
2127 * buffer.c (mmap_find): Fix a typo.
2128
cd18e7e3
JB
21292011-07-13 Johan Bockgård <bojohan@gnu.org>
2130
2131 Fix execution of x selection hooks.
2132 * xselect.c (Qx_lost_selection_functions)
2133 (Qx_sent_selection_functions): New vars.
2134 (syms_of_xselect): DEFSYM them.
2135 (x_handle_selection_request): Pass Qx_sent_selection_functions
2136 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2137 (x_handle_selection_clear,x_clear_frame_selections):
2138 Pass Qx_lost_selection_functions rather than
2139 Vx_lost_selection_functions to Frun_hook_with_args.
2140
47ea7f44
PE
21412011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2142
ac389d0c 2143 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2144 The old code sometimes used this field without initializing it.
2145
47ea7f44
PE
2146 * alloc.c (gc_sweep): Don't read past end of array.
2147 In theory, the old code could also have corrupted Emacs internals,
2148 though it'd be very unlikely.
2149
bc985c87
AS
21502011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2151
2152 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2153 argument. (Bug#4026)
bc985c87 2154
0cf34688
LMI
21552011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2156
b3dadd76
LMI
2157 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2158 key" (bug#4257).
2159
0cf34688
LMI
2160 * window.c (Fset_window_start): Doc fix (bug#4199).
2161 (Fset_window_hscroll): Ditto.
2162
270768cd
PE
21632011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2164
077e3dda 2165 Fix minor new problems caught by GCC 4.6.1.
270768cd 2166 * term.c (init_tty): Remove unused local.
490011a6 2167 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2168 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2169 not used otherwise.
270768cd 2170
b1f58454
CY
21712011-07-12 Chong Yidong <cyd@stupidchicken.com>
2172
2173 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2174
22b9578d
LMI
21752011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2176
6e70ab07
LMI
2177 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2178 are the mini-buffer and the echo area (bug#3320).
2179
22b9578d
LMI
2180 * term.c (init_tty): Remove support for supdup, c10 and perq
2181 terminals, which are no longer supported (bug#1482).
2182
8974cc9f
JB
21832011-07-10 Johan Bockgård <bojohan@gnu.org>
2184
2185 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2186
a560d974
JD
21872011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2188
2189 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2190 for non-popups (Bug#3642).
2191
1dae0f0a
AS
21922011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2193
268c2c36 2194 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2195 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2196 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2197 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2198 * data.c (fmod): Likewise.
2199 * dispnew.c (swap_glyphs_in_rows): Likewise.
2200 * emacs.c (memory_warning_signal): Likewise.
2201 * floatfns.c (float_error): Likewise.
2202 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2203 (otf_open, font_otf_capability, generate_otf_features)
2204 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2205 Likewise.
2206 * image.c (pbm_read_file): Likewise.
2207 * indent.c (string_display_width): Likewise.
2208 * intervals.c (check_for_interval, search_for_interval)
2209 (inc_interval_count, count_intervals, root_interval)
2210 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2211 * lread.c (defalias): Likewise.
268c2c36 2212 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2213 * regex.c (set_image_of_range_1, set_image_of_range)
2214 (regex_grow_registers): Likewise.
2215 * sysdep.c (strerror): Likewise.
2216 * termcap.c (valid_filename_p, tprint, main): Likewise.
2217 * tparam.c (main): Likewise.
2218 * unexhp9k800.c (run_time_remap, save_data_space)
2219 (update_file_ptrs, read_header, write_header, calculate_checksum)
2220 (copy_file, copy_rest, display_header): Likewise.
2221 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2222 Likewise.
2223 * xdisp.c (check_it): Likewise.
2224 * xfaces.c (register_color, unregister_color, unregister_colors):
2225 Likewise.
2226 * xfns.c (print_fontset_result): Likewise.
2227 * xrdb.c (member, fatal, main): Likewise.
2228
99033785
PE
22292011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 Fix minor problems found by static checking (Bug#9031).
2232 * chartab.c (char_table_set_range, map_sub_char_table):
2233 Remove unused locals.
2234 (uniprop_table): Now static.
2235 * composite.c (_work_char): Remove unused static var.
2236
9cb2ac56
JB
22372011-07-09 Juanma Barranquero <lekktu@gmail.com>
2238
2239 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2240
f25661f0
JD
22412011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2242
2243 * gtkutil.c (qttip_cb): Remove code without function.
2244
8278c4fe
EZ
22452011-07-09 Eli Zaretskii <eliz@gnu.org>
2246
2247 * w32.c (pthread_sigmask): New stub.
2248
1692ae2d 22492011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2250
8a6ebd58 2251 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2252 sigprocmask is portable only for single-threaded applications, and
2253 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2254 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2255 (LIBES): Use it.
2256 * callproc.c (Fcall_process):
2257 * process.c (create_process):
2258 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2259 Use pthread_sigmask, not sigprocmask.
123403e4 2260
1b854618
JD
22612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2262
2263 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2264 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2265 wrong (Bug#8591).
2266
3fe4b549
JD
22672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2268
0ce7e563
JD
2269 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2270 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2271 (xg_hide_tooltip): Fix comment.
2272
3fe4b549
JD
2273 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2274 in registerServicesMenuSendTypes.
2275 (validRequestorForSendType): Don't check ns_return_types.
2276
2277 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2278 ns_return_type.
2279
5df75e47
JR
22802011-07-08 Jason Rumney <jasonr@gnu.org>
2281
2282 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2283 frame struct members of non-existent frames (Bug#6284).
2284
699c10bd
JD
22852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2286
4393663b
JD
2287 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2288 variable firstTime not needed on OSX >= 10.6.
2289 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2290 >= 10.5. Use setKnobProportion, setDoubleValue.
2291
2292 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2293 (MAC_OS_X_VERSION_10_5): Define if not defined.
2294 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2295 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2296 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2297
2298 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2299 cString and lossyCString on OSX >= 10.4
2300
2301 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2302 sizeToFit on OSX >= 10.2.
2303
2304 * nsimage.m (allocInitFromFile): Don't use deprecated method
2305 bestRepresentationForDevice on OSX >= 10.6.
2306
2307 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2308 to avoid warning.
2309
2310 * emacs.c: Declare unexec_init_emacs_zone.
2311
a63e0781
JD
2312 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2313
699c10bd
JD
2314 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2315
2316 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2317 on svcsMenu (Bug#8842).
2318
2319 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2320 ns_return_types.
2321 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2322
2323 * nsterm.m (QUTF8_STRING): Declare.
2324 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2325 (validRequestorForSendType): Return type is (id).
2326 Change indexOfObjectIdenticalTo to indexOfObject.
2327 Check if we have local selection before returning self (Bug#8842).
2328 (writeSelectionToPasteboard): Put local selection into paste board
2329 if we have a local selection (Bug#8842).
2330 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2331
2332 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2333 (ns_get_local_selection): Declare.
2334
54e10184
LMI
23352011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2336
9888ff71
LMI
2337 * keymap.c (describe_map_tree): Don't insert a double newline at
2338 the end of the buffer (bug#1169) and return whether we inserted
2339 something.
2340
54e10184
LMI
2341 * callint.c (Fcall_interactively): Change "reading args" to
2342 "providing args" to try to clarify what it does (bug#1010).
2343
15fa4783
KH
23442011-07-07 Kenichi Handa <handa@m17n.org>
2345
2346 * composite.c (composition_compute_stop_pos): Ignore a static
2347 composition starting before CHARPOS (Bug#8915).
2348
2349 * xdisp.c (handle_composition_prop): Likewise.
2350
a8815b00
EZ
23512011-07-07 Eli Zaretskii <eliz@gnu.org>
2352
2353 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2354 (Bug#9015)
2355
ef7b981d 23562011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2357
2358 * character.h (unicode_category_t): New enum type.
2359
2360 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2361 (Qchar_code_property_table): New variable.
2362 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2363 (UNIPROP_COMPRESSED_FORM_P): New macros.
2364 (char_table_ascii): Uncompress the compressed values.
2365 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2366 Uncompress the compressed values.
ac389d0c 2367 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2368 (char_table_ref_and_range): Uncompress the compressed values.
2369 (sub_char_table_set): New arg is_uniprop. Callers changed.
2370 Uncompress the compressed values.
2371 (sub_char_table_set_range): Args changed. Callers changed.
2372 (char_table_set_range): Adjuted for the above change.
2373 (map_sub_char_table): Delete args default_val and parent. Add arg
2374 top. Give decoded values to a Lisp function.
640c8776 2375 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2376 values to a Lisp function. Gcpro more variables.
2377 (uniprop_table_uncompress)
2378 (uniprop_decode_value_run_length): New functions.
2379 (uniprop_decoder, uniprop_decoder_count): New variables.
2380 (uniprop_get_decoder, uniprop_encode_value_character)
2381 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2382 New functions.
2383 (uniprop_encoder, uniprop_encoder_count): New variables.
2384 (uniprop_get_encoder, uniprop_table)
2385 (Funicode_property_table_internal, Fget_unicode_property_internal)
2386 (Fput_unicode_property_internal): New functions.
2387 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2388 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2389 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2390 char-code-property-alist.
2391
640c8776 2392 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2393 Vunicode_category_table.
2394
640c8776 2395 * font.c (font_range): Adjust for the change of
c805dec0
KH
2396 Vunicode_category_table.
2397
76b397fb
DN
23982011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2399
2400 * m/iris4d.h: Remove file, move contents ...
2401 * s/irix6-5.h: ... here.
2402
22b4128e
PE
24032011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2406 * alloc.c (mark_buffer):
2407 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2408 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2409 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2410 This isn't true in general, and it's particularly not true
2411 if Emacs is configured with --with-wide-int.
2412 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2413 New macros, used in the buffer.c change.
2414
869795d6
JD
24152011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2416
2417 * xsettings.c: Use both GConf and GSettings if both are available.
2418 (store_config_changed_event): Add comment.
2419 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2420 (store_tool_bar_style_changed): New functions.
5e617bc2 2421 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2422 (struct xsettings): Move font inside HAVE_XFT.
2423 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2424 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2425 Move inside HAVE_XFT.
640c8776 2426 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2427 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2428 also.
2429 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2430 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2431 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2432 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2433 (parse_settings): Move check for font inside HAVE_XFT.
2434 (read_settings, apply_xft_settings): Add comment.
2435 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2436 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2437 call store_font_name_changed.
2438 (xft_settings_event): Add comment.
2439 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2440 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2441 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2442 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2443 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2444 (xsettings_get_system_font, xsettings_get_system_normal_font):
2445 Add comment.
869795d6 2446
d8ed26bd
PE
24472011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 Random fixes. E.g., (random) never returned negative values.
2450 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2451 subseconds part to the entropy, as that's a bit more random.
2452 Prefer signed to unsigned, since the signedness doesn't matter and
2453 in general we prefer signed. When given a limit, use a
2454 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2455 latter isn't right if USE_2_TAGS_FOR_INTS.
2456 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2457 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2458
cabf1cac
SM
24592011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2460
2461 * textprop.c (text_property_stickiness):
2462 Obey Vtext_property_default_nonsticky.
2463 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2464 * w32fns.c (syms_of_w32fns):
2465 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2466
6e9b2be9
PE
24672011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2470 This is more efficient than Ffile_directory_p and avoids a minor race.
2471
90186c68
LMI
24722011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2473
7c301272
LMI
2474 * buffer.c (Foverlay_put): Say what the return value is
2475 (bug#7835).
2476
c4f2d8d4
LMI
2477 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2478 is a directory before asking whether to use the file name
2479 (bug#7564).
ad637907
LMI
2480 (barf_or_query_if_file_exists): Make the "File is a directory"
2481 error be more correct.
c4f2d8d4 2482
90186c68
LMI
2483 * fns.c (Frequire): Remove the mention of the .gz files, since
2484 that's installation-specific, but keep the mention of
2485 `get-load-suffixes'.
2486
da64016e
PE
24872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2488
2489 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2490 Report string overflow if the output is too long.
2491
7d47b580
JB
24922011-07-04 Juanma Barranquero <lekktu@gmail.com>
2493
a555cb87
JB
2494 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2495 (syms_of_gnutls): Remove duplicate DEFSYM for
2496 Qgnutls_bootprop_verify_hostname_error, an error for
2497 Qgnutls_bootprop_verify_error (which is no longer used).
2498
7d47b580
JB
2499 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2500 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2501 Also (re)move comments that are misplaced or no longer relevant.
2502
1e49bfab
LMI
25032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2504
2505 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2506
1485f4c0
CY
25072011-07-03 Chong Yidong <cyd@stupidchicken.com>
2508
2509 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2510 and background color parameters if they have been changed.
2511
a9ab721e
LMI
25122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2513
2514 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2515
cf7cff57
PE
25162011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2517
2e13213d
PE
2518 * xsettings.c (SYSTEM_FONT): Define only when used.
2519 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2520
cf7cff57
PE
2521 * keymap.c (access_keymap_1): Now static.
2522
7a8e04f7
CY
25232011-07-02 Chong Yidong <cyd@stupidchicken.com>
2524
2525 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2526 leave any prefix arg for the up event (Bug#1586).
2527
61352f62
LMI
25282011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2529
69bb1ef7
LMI
2530 * lread.c (syms_of_lread): Mention single symbols defined by
2531 `defvar' or `defconst' (bug#7154).
2532
61352f62 2533 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2534 (Frequire): Mention get-load-suffixes.
61352f62 2535
28545e04
MR
25362011-07-02 Martin Rudalics <rudalics@gmx.at>
2537
2538 * window.h (window): Remove clone_number slot.
2539 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2540 Remove.
2541 (make_parent_window, make_window, saved_window)
2542 (Fset_window_configuration, save_window_save): Don't deal with
2543 clone numbers.
2544 * buffer.c (Qclone_number): Remove declaration.
2545 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2546
3349e122
SM
25472011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2548
2549 Add multiple inheritance to keymaps.
2550 * keymap.c (Fmake_composed_keymap): New function.
2551 (Fset_keymap_parent): Simplify.
2552 (fix_submap_inheritance): Remove.
2553 (access_keymap_1): New function extracted from access_keymap to handle
2554 embedded parents and handle lists of maps.
2555 (access_keymap): Use it.
2556 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2557 (Fcopy_keymap): Handle embedded parents.
2558 (Fcommand_remapping, define_as_prefix): Simplify.
2559 (Fkey_binding): Simplify.
2560 (syms_of_keymap): Move minibuffer-local-completion-map,
2561 minibuffer-local-filename-completion-map,
2562 minibuffer-local-must-match-map, and
2563 minibuffer-local-filename-must-match-map to Elisp.
2564 (syms_of_keymap): Defsubr make-composed-keymap.
2565 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2566 (parse_menu_item): Trivial simplification.
2567
3279eb87
GM
25682011-07-01 Glenn Morris <rgm@gnu.org>
2569
2570 * Makefile.in (SETTINGS_LIBS): Fix typo.
2571
4550efdf
KI
25722011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2573
2574 * coding.c (Fencode_coding_string): Record the last coding system
2575 used, as the function doc string says (bug#8738).
2576
0949d2b6
JD
25772011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2578
2579 * xsettings.c (store_monospaced_changed): Take new font as arg and
2580 check for change against current_mono_font.
2581 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2582 (emacs_settings_constructor, emacs_settings_get_property)
2583 (emacs_settings_set_property, emacs_settings_class_init)
2584 (emacs_settings_init, gsettings_obj): Remove.
2585 (something_changedCB): New function for HAVE_GSETTINGS.
2586 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2587 with value as argument.
2588 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2589 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2590 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2591 "changed".
2592
2593 * xgselect.c: Add defined (HAVE_GSETTINGS).
2594 (xgselect_initialize): Ditto.
2595
2596 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2597 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2598 xg_select.
2599
bbc6b304
PE
26002011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2601
2602 * eval.c (struct backtrace): Simplify and port the data structure.
2603 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2604 signed bit field, as this assumption is not portable and it makes
2605 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2606 "char debug_on_exit : 1" as this is not portable either; instead,
2607 use the portable "unsigned int debug_on_exit : 1". Remove unused
2608 member evalargs. Remove obsolete comments about cc bombing out.
2609
9851bfc5
JD
26102011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2611
51bb811f 2612 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2613 Let HAVE_GSETTINGS override HAVE_GCONF.
2614 (store_monospaced_changed): New function.
2615 (EMACS_SETTINGS): A new type derived from GObject to handle
2616 GSettings notifications.
2617 (emacs_settings_constructor, emacs_settings_get_property)
2618 (emacs_settings_set_property, emacs_settings_class_init):
2619 New functions.
2620 (gsettings_client, gsettings_obj): New variables.
2621 (GSETTINGS_SCHEMA): New define.
2622 (something_changedCB): Call store_monospaced_changed.
2623 (init_gsettings): New function.
2624 (xsettings_initialize): Call init_gsettings.
2625 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2626 to NULL.
2627
640c8776 2628 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2629 GCONF_CFLAGS/LIBS.
2630
5386012d
MR
26312011-06-29 Martin Rudalics <rudalics@gmx.at>
2632
2633 * window.c (resize_root_window, grow_mini_window)
2634 (shrink_mini_window): Rename Qresize_root_window to
2635 Qwindow_resize_root_window and Qresize_root_window_vertically to
2636 Qwindow_resize_root_window_vertically.
2637
f13e0b08
PE
26382011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2639
2640 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2641
94515237
JB
26422011-06-27 Juanma Barranquero <lekktu@gmail.com>
2643
2644 * makefile.w32-in: Redesign dependencies so they reflect more
2645 clearly which files are directly included by each source file,
2646 and not through other includes.
2647
e43b6e43
MR
26482011-06-27 Martin Rudalics <rudalics@gmx.at>
2649
2650 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2651 (sort_overlays, overlay_strings): When an overlay's clone number
2652 matches the window's clone number process the overlay even if
2653 the overlay's window property doesn't match the current window.
2654
d68443dc
MR
2655 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2656 (Fwindow_hchild): Rename to Fwindow_left_child.
2657 (Fwindow_next): Rename to Fwindow_next_sibling.
2658 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2659 (resize_window_check): Rename to window_resize_check.
2660 (resize_window_apply): Rename to window_resize_apply.
2661 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2662 (Fdelete_other_windows_internal, resize_frame_windows)
2663 (Fsplit_window_internal, Fdelete_window_internal)
2664 (grow_mini_window, shrink_mini_window)
2665 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2666
c7e73be5
JD
26672011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2668
2669 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2670 (emacs_fixed_set_min_size): Remove.
2671 (emacs_fixed_new): Take frame as argument.
2672
2673 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2674 (_EmacsFixedPrivate): Remove minwidth/height.
2675 Add struct frame *f.
2676 (emacs_fixed_init): Initialize priv->f.
2677 (get_parent_class, emacs_fixed_set_min_size): Remove.
2678 (emacs_fixed_new): Set priv->f to argument.
2679 (emacs_fixed_get_preferred_width)
2680 (emacs_fixed_get_preferred_height): Use min_width/height from
2681 frames size_hint to set minimum and natural (Bug#8919).
2682 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2683 and use min_width/height from frames size_hint to set
2684 min_width/height (Bug#8919).
2685
2686 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2687 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2688 Fix indentation.
c7e73be5 2689
cf99dcf8
EZ
26902011-06-26 Eli Zaretskii <eliz@gnu.org>
2691
2692 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2693 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2694 called at ZV.
2695
029529ac
CY
26962011-06-26 Chong Yidong <cyd@stupidchicken.com>
2697
2698 * process.c (wait_reading_process_output): Bypass select if
2699 waiting for a cell while ignoring keyboard input, and input is
2700 pending. Suggested by Jan Djärv (Bug#8869).
2701
7a7ef429
PE
27022011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 Use gnulib's dup2 module instead of rolling our own.
2705 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2706
11fdef7d 27072011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2708
2709 * dispnew.c (scrolling_window): Before scrolling, turn off a
2710 mouse-highlight in the window being scrolled.
2711
cd3520a4
JB
27122011-06-24 Juanma Barranquero <lekktu@gmail.com>
2713
2714 Move DEFSYM to lisp.h and use everywhere.
2715
2716 * character.h (DEFSYM): Move declaration...
2717 * lisp.h (DEFSYM): ...here.
2718
2719 * gnutls.c:
2720 * minibuf.c:
2721 * w32menu.c:
2722 * w32proc.c:
2723 * w32select.c: Don't include character.h.
2724
2725 * alloc.c (syms_of_alloc):
2726 * buffer.c (syms_of_buffer):
2727 * bytecode.c (syms_of_bytecode):
2728 * callint.c (syms_of_callint):
2729 * casefiddle.c (syms_of_casefiddle):
2730 * casetab.c (init_casetab_once):
2731 * category.c (init_category_once, syms_of_category):
2732 * ccl.c (syms_of_ccl):
2733 * cmds.c (syms_of_cmds):
2734 * composite.c (syms_of_composite):
2735 * dbusbind.c (syms_of_dbusbind):
2736 * dired.c (syms_of_dired):
2737 * dispnew.c (syms_of_display):
2738 * doc.c (syms_of_doc):
2739 * editfns.c (syms_of_editfns):
2740 * emacs.c (syms_of_emacs):
2741 * eval.c (syms_of_eval):
2742 * fileio.c (syms_of_fileio):
2743 * fns.c (syms_of_fns):
2744 * frame.c (syms_of_frame):
2745 * fringe.c (syms_of_fringe):
2746 * insdel.c (syms_of_insdel):
2747 * keymap.c (syms_of_keymap):
2748 * lread.c (init_obarray, syms_of_lread):
2749 * macros.c (syms_of_macros):
2750 * msdos.c (syms_of_msdos):
2751 * print.c (syms_of_print):
2752 * process.c (syms_of_process):
2753 * search.c (syms_of_search):
2754 * sound.c (syms_of_sound):
2755 * syntax.c (init_syntax_once, syms_of_syntax):
2756 * terminal.c (syms_of_terminal):
2757 * textprop.c (syms_of_textprop):
2758 * undo.c (syms_of_undo):
2759 * w32.c (globals_of_w32):
2760 * window.c (syms_of_window):
2761 * xdisp.c (syms_of_xdisp):
2762 * xfaces.c (syms_of_xfaces):
2763 * xfns.c (syms_of_xfns):
2764 * xmenu.c (syms_of_xmenu):
2765 * xsettings.c (syms_of_xsettings):
2766 * xterm.c (syms_of_xterm): Use DEFSYM.
2767
4228cf16
TZ
27682011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2769
cd3520a4 2770 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2771
7fcccf1e
PE
27722011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2773
7efb4e0e
PE
2774 Integer and buffer overflow fixes (Bug#8873).
2775
ff5844ad
PE
2776 * print.c (printchar, strout): Check for string overflow.
2777 (PRINTPREPARE, printchar, strout):
2778 Don't set size unless allocation succeeds.
2779
90532f02
PE
2780 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2781 for sizes. Check for string overflow more accurately.
2782 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2783
6d84508d
PE
2784 * macros.c: Integer and buffer overflow fixes.
2785 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2786 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2787 Use ptrdiff_t, not int, for sizes.
2788 Don't increment bufsize until after realloc succeeds.
2789 Check for size-calculation overflow.
2790 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2791
437b2cb4
PE
2792 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2793
8b9ac8b4
PE
2794 * lread.c: Integer overflow fixes.
2795 (read_integer): Radix is now EMACS_INT, not int,
2796 to improve quality of diagnostics for out-of-range radices.
2797 Calculate buffer size correctly for out-of-range radices.
2798 (read1): Check for integer overflow in radices, and in
2799 read-circle numbers.
82cb60d3
PE
2800 (read_escape): Avoid int overflow.
2801 (Fload, openp, read_buffer_size, read1)
2802 (substitute_object_recurse, read_vector, read_list, map_obarray):
2803 Use ptrdiff_t, not int, for sizes.
2804 (read1): Use EMACS_INT, not int, for sizes.
20270765 2805 Check for size overflow.
8b9ac8b4 2806
7fcccf1e
PE
2807 * image.c (cache_image): Check for size arithmetic overflow.
2808
bfbbd7e7
PE
2809 * lread.c: Integer overflow issues.
2810 (saved_doc_string_size, saved_doc_string_length)
2811 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2812 Now ptrdiff_t, not int.
2813 (read1): Don't assume doc string length fits in int. Check for
2814 out-of-range doc string lengths.
2815 (read_list): Don't assume file position fits in int.
39019e54 2816 (read_escape): Check for hex character overflow.
bfbbd7e7 2817
4e323265
LL
28182011-06-22 Leo Liu <sdl.web@gmail.com>
2819
2820 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2821 Move to minibuffer.el.
2822
85fece3e
PE
28232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2824
20b84ce9 2825 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2826 The following patches are for when GLYPH_DEBUG && !XASSERT.
2827 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2828 * dispnew.c (flush_stdout):
2829 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2830 Mark as externally visible.
2831 * dispnew.c (check_window_matrix_pointers): Now static.
2832 * dispnew.c (window_to_frame_vpos):
2833 * xfns.c (unwind_create_frame):
2834 * xterm.c (x_check_font): Remove unused local.
2835 * scroll.c (CHECK_BOUNDS):
2836 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2837 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2838 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2839 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2840 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2841 Now static.
2842 (debug_method_add): Use va_list and vsprintf rather than relying
2843 on undefined behavior with wrong number of arguments.
2844 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2845 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2846 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2847 since we're not interested in debugging glyphs with old libraries.
2848 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2849 GCC 4.6.0's static checking.
2850
0766b489
PE
28512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2852
31fd4b32
PE
2853 Integer overflow and signedness fixes (Bug#8873).
2854 A few related buffer overrun fixes, too.
2855
b79e8648
PE
2856 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2857
0766b489
PE
2858 * dispextern.h (struct face.stipple):
2859 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2860 (x_bitmap_mask, x_allocate_bitmap_record)
2861 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2862 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2863 (x_create_bitmap_from_xpm_data):
2864 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2865 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2866 (.bitmaps_last):
2867 * xfaces.c (load_pixmap):
2868 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2869 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2870 (.bitmaps_last, struct x_output.icon_bitmap):
2871 Use ptrdiff_t, not int, for bitmap indexes.
2872 (x_allocate_bitmap_record): Check for size overflow.
2873 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2874
b081724f
PE
2875 Use ptrdiff_t, not int, for overlay counts.
2876 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2877 * editfns.c (overlays_around, get_pos_property):
2878 * textprop.c (get_char_property_and_overlay):
2879 * xdisp.c (next_overlay_change, note_mouse_highlight):
2880 * xfaces.c (face_at_buffer_position):
21514da7
PE
2881 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2882 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2883 (Fnext_overlay_change, Fprevious_overlay_change)
2884 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2885 Use ptrdiff_t, not int, for sizes.
21514da7 2886 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2887
3de73e5e
PE
2888 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2889
2606c57b
PE
2890 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2891 (x_session_initialize): Do not assume string length fits in int.
2892
aaafe47a
PE
2893 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2894 This is unlikely, but can occur if DPI is outlandish.
2895
2674ddc8 2896 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2897 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2898
28154962
PE
2899 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2900 * xrdb.c (magic_file_p, search_magic_path):
2901 Omit last arg SUFFIX; it was always 0. All callers changed.
2902 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2903
7de51af5
PE
2904 * xfont.c (xfont_match): Avoid need for strlen.
2905
25ed6cc3
PE
2906 * xfns.c: Don't assume strlen fits in int.
2907 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2908
4eab31dd
PE
2909 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2910 not unsigned long, as we prefer signed integers. All callers changed.
2911 Detect integer overflow in repeat count.
2912 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2913 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2914
171e2a58
PE
2915 * termcap.c: Don't assume sizes fit in int and never overflow.
2916 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2917 (gobble_line): Check for size-calculation overflow.
2918
ad39faca 2919 * minibuf.c (Fread_buffer):
6e5bb2dc 2920 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2921 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2922 Don't assume string length fits in int.
2923
52c61c22 2924 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2925 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2926
b5b8c9e5
PE
2927 * font.c: Don't assume string length fits in int.
2928 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2929 Use ptrdiff_t, not int.
ccd6111c
PE
2930 (font_intern_prop): Don't assume string length fits in int.
2931 Don't assume integer property fits in fixnum.
2932 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2933
882f0d81 2934 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2935 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2936 Reformulate so as not to need the command string.
2937 Invoke gzip -cd rather than gunzip, as it's more portable.
2938 (lock_info_type, lock_file_1, lock_file):
2939 Don't assume pid_t and time_t fit in unsigned long.
2940 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2941 (current_lock_owner): Prefer signed type for sizes.
2942 Use memcpy, not strncpy, where memcpy is what is really wanted.
2943 Don't assume (via atoi) that time_t and pid_t fit in int.
2944 Check for time_t and/or pid_t out of range, e.g., via a network share.
2945 Don't alloca where an auto var works fine.
2946
93f4cf88
PE
2947 * fileio.c: Fix some integer overflow issues.
2948 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2949 Don't assume string length fits in int.
2950 (directory_file_name): Don't assume string length fits in long.
2951 (make_temp_name): Don't assume pid fits in int, or that its print
2952 length is less than 20.
2953
f3e92b69
PE
2954 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2955
1bfdaf10
PE
2956 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2957
35016e9a
PE
2958 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2959
3d1e65a1
PE
2960 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2961 We prefer signed integers, even for size calculations.
2962
0b963a93
PE
2963 * emacs.c: Don't assume string length fits in 'int'.
2964 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2965 (main): Don't invoke strlen when not needed.
2966
573f4b54
PE
2967 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2968 (XD_DEBUG_MESSAGE): Don't waste a byte.
2969
989f33ba
PE
2970 * callproc.c (getenv_internal_1, getenv_internal)
2971 (Fgetenv_internal):
965d34eb
PE
2972 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2973
e4d29b33
PE
2974 * lread.c (invalid_syntax): Omit length argument.
2975 All uses changed. This doesn't fix a bug, but it simplifies the
2976 code away from its former Hollerith-constant appearance, and it's
2977 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2978 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2979
eb49b136
PE
2980 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2981 This didn't break anything, but it didn't help either.
2982 It's confusing to put a bogus integer in a place where the actual
2983 value does not matter.
9f62aeb1 2984 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2985 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2986
15375a22
PE
2987 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2988 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2989 implementation.
b61cc01c
PE
2990 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2991 We prefer signed types, and the value cannot exceed the EMACS_INT
2992 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2993 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2994 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2995 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2996
53b2623d
PE
2997 * indent.c (sane_tab_width): New function.
2998 (current_column, scan_for_column, Findent_to, position_indentation)
2999 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3000 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3001
51cab52b 3002 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3003
f2ed8a70
PE
3004 * lisp.h (lint_assume): New macro.
3005 * composite.c (composition_gstring_put_cache):
3006 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3007
abe80cc6
PE
3008 * editfns.c, insdel.c:
3009 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3010
b02c740e
PE
3011 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3012
ebc96716
PE
3013 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3014
b4e50fa0 3015 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3016 Use much-faster test for byte-length change.
311d5d7c 3017 Don't assume string byte-length fits in 'int'.
a4cf38e4 3018 Check that character arg fits in 'int'.
85461888 3019 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3020
c0c1ee9f
PE
3021 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3022
a498d7f4
PE
3023 * fns.c (concat): Catch string overflow earlier.
3024 Do not rely on integer wraparound.
3025
51cab52b
PE
3026 * dispextern.h (struct it.overlay_strings_charpos)
3027 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3028 * xdisp.c (forward_to_next_line_start)
3029 (back_to_previous_visible_line_start)
3030 (reseat_at_next_visible_line_start, next_element_from_buffer):
3031 Don't arbitrarily truncate the value of 'selective' to int.
3032
76031fad
PE
3033 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3034
5eb55db9
PE
3035 * composite.c: Don't truncate sizes to 'int'.
3036 (composition_gstring_p, composition_reseat_it)
3037 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3038 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3039 not EMACS_UINT, for indexes.
5eb55db9 3040
0703a717
PE
3041 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3042
d6202519
PE
3043 * buffer.c: Include <verify.h>.
3044 (struct sortvec.priority, struct sortstr.priority):
8961a454 3045 Now EMACS_INT, not int.
c20998a7 3046 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3047 (struct sortstr.size, record_overlay_string)
3048 (struct sortstrlist.size, struct sortlist.used):
3049 Don't truncate size to int.
3050 (record_overlay_string): Check for size-calculation overflow.
d6202519 3051 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3052
d5a19415
JM
30532011-06-22 Jim Meyering <meyering@redhat.com>
3054
029529ac 3055 Don't leak an XBM-image-sized buffer
d5a19415
JM
3056 * image.c (xbm_load): Free the image buffer after using it.
3057
a9041e6c
PE
30582011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 Port to Sun C.
3061 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3062 that Sun C diagnosed.
3063 * fns.c (secure_hash): Fix pointer signedness issue.
3064 * intervals.c (static_offset_intervals): New function.
3065 (offset_intervals): Use it.
3066
7f3f739f
LL
30672011-06-21 Leo Liu <sdl.web@gmail.com>
3068
3069 * deps.mk (fns.o):
3070 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3071 sha512.h.
3072
3073 * fns.c (secure_hash): Rename from crypto_hash_function and change
3074 the first arg to accept symbols.
5b66d427 3075 (Fsecure_hash): New primitive.
7f3f739f
LL
3076 (syms_of_fns): New symbols.
3077
76147d94
DD
30782011-06-20 Deniz Dogan <deniz@dogan.se>
3079
3080 * process.c (Fset_process_buffer): Clarify return value in
3081 docstring.
3082
7d7d0045
CY
30832011-06-18 Chong Yidong <cyd@stupidchicken.com>
3084
3085 * dispnew.c (add_window_display_history): Use BVAR.
3086
3087 * xdisp.c (debug_method_add): Use BVAR.
3088 (check_window_end, dump_glyph_matrix, dump_glyph)
3089 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3090
3091 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3092 Likewise.
3093
3094 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3095 check till after the cache is created in init_frame_faces.
3096
ff2bc410
SM
30972011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3098
3099 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3100
28177add
PE
31012011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3102
dd3482fe
PE
3103 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3104 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3105 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3106
393d71f3 3107 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3108 * fileio.c (Finsert_file_contents):
3109 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3110 Remove the old (too-loose) buffer overflow checks.
3111 They weren't needed, since make_gap checks for buffer overflow.
3112 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3113 The old code merely checked for Emacs fixnum overflow, and relied
3114 on undefined (wraparound) behavior. The new code avoids undefined
3115 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3116
2e6813b0 3117 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3118 Tune. Don't use wider integers than needed. Don't use alloca.
3119 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3120
599a9e4f
PE
3121 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3122
99561444
PE
3123 * insdel.c, lisp.h (buffer_overflow): New function.
3124 (insert_from_buffer_1, replace_range, replace_range_2):
3125 * insdel.c (make_gap_larger):
3126 * editfns.c (Finsert_char):
3127 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3128
28177add
PE
3129 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3130
e69dafad
PE
31312011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3132
a7af7fde 3133 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3134
b1c46f02
PE
3135 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3136 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3137
e69dafad
PE
3138 * fileio.c: Don't assume EMACS_INT fits in off_t.
3139 (emacs_lseek): New static function.
3140 (Finsert_file_contents, Fwrite_region): Use it.
3141 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3142
566684ea
PE
3143 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3144
e6966cd6
PE
3145 * fns.c: Don't overflow int when computing a list length.
3146 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3147 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3148 truncation on 64-bit hosts. Check for QUIT every
3149 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3150 faster and is responsive enough.
3151 (Flength): Report an error instead of overflowing an integer.
3152 (Fsafe_length): Return a float if the value is not representable
3153 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3154 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3155 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3156
dd0b0efb
PE
3157 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3158 (header_size, word_size): New constants.
3159 (allocate_vectorlike): Don't check size overflow here.
3160 (allocate_vector): Check it here instead, since this is the only
3161 caller of allocate_vectorlike that could cause overflow.
3162 Check that the new vector's length is representable as a fixnum.
3163
86fe5cfe
PE
3164 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3165 The previous code was bogus. For example, next_almost_prime (32)
3166 returned 39, which is undesirable as it is a multiple of 3; and
3167 next_almost_prime (24) returned 25, which is a multiple of 5 so
3168 why was the code bothering to check for multiples of 7?
3169
80e88859
PE
3170 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3171
4a2f0ad6
PE
3172 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3173
f66c7cf8
PE
3174 Variadic C functions now count arguments with ptrdiff_t.
3175 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3176 Back then I didn't know that the Emacs coding style prefers signed int.
3177 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3178 were being counted with int, which may truncate counts on 64-bit
3179 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3180 * lisp.h (struct Lisp_Subr.function.aMANY)
3181 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3182 Arg counts are now ptrdiff_t, not size_t.
3183 All variadic functions and their callers changed accordingly.
3184 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3185 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3186 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3187 * callint.c (Fcall_interactively): Check arg count for overflow,
3188 to avoid potential buffer overrun. Use signed char, not 'int',
3189 for 'varies' array, so that we needn't bother to check its size
3190 calculation for overflow.
3191 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3192 * eval.c (apply_lambda):
3193 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3194 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3195 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3196
a1759b76
PE
3197 * callint.c (Fcall_interactively): Don't use index var as event count.
3198
d96be9fc
PE
3199 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3200 * mem-limits.h (SIZE): Remove; no longer used.
3201
a690a978 3202 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3203
578c21e6
PE
3204 Remove unnecessary casts.
3205 * xterm.c (x_term_init):
3206 * xfns.c (x_set_border_pixel):
3207 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3208 These aren't needed now that we assume ANSI C.
3209
96f53c6c
PE
3210 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3211 It's more likely to cause problems (due to unsigned overflow)
3212 than to cure them.
3213
83c77d31
PE
3214 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3215
ee2079f1
PE
3216 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3217
6da65536
PE
3218 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3219
7147c4a4
PE
3220 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3221
193e32d9
PE
3222 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3223
e5533da6
PE
3224 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3225
9910e595
PE
3226 GLYPH_CODE_FACE returns EMACS_INT, not int.
3227 * dispextern.h (merge_faces):
3228 * xfaces.c (merge_faces):
01103c44
PE
3229 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3230 Don't assume EMACS_INT fits in int.
9910e595 3231
2638320e
PE
3232 * character.h (CHAR_VALID_P): Remove unused parameter.
3233 * fontset.c, lisp.h, xdisp.c: All uses changed.
3234
045eb8d9
PE
3235 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3236
c1f134b5
PE
3237 * fns.c (concat): Minor tuning based on overflow analysis.
3238 This doesn't fix any bugs. Use int to hold character, instead
3239 of constantly refetching from Emacs object. Use XFASTINT, not
3240 XINT, for value known to be a character. Don't bother comparing
3241 a single byte to 0400, as it's always less.
3242
395fcb93 3243 * floatfns.c (Fexpt):
327eeec8
PE
3244 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3245
abbd3d23
PE
3246 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3247 for characters.
3248
684a03ef
PE
3249 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3250
0fed43f3
PE
3251 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3252 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3253 incorrectly succeed when S was a string, because 4294967386 was
3254 truncated before it was used.
3255
8fd02eb7
PE
3256 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3257 Otherwise, an out-of-range integer could cause undefined behavior
3258 on a 64-bit host.
3259
f8c86b69
PE
3260 * composite.c: Use int, not EMACS_INT, for characters.
3261 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3262 EMACS_INT, for values that are known to be in character range.
3263 This doesn't fix any bugs but is the usual style inside Emacs and
3264 may generate better code on 32-bit machines.
3265
34206dd2
PE
3266 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3267 This is for reasons similar to the recent CHAR_STRING fix.
3268 * charset.c (Fencode_char): Check that character arg is actually
3269 a character. Pass an int to ENCODE_CHAR.
3270 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3271 wider than 'int', as a compile-time check to prevent future regressions
3272 in this area.
3273
c5958d4c 3274 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3275
3276 Make sure a 64-bit char is never passed to CHAR_STRING.
3277 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3278 by silently ignoring the top 32 bits, allowing some values
3279 that were far too large to be valid characters.
3280 * character.h: Include <verify.h>.
3281 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3282 arguments are no wider than unsigned, as a compile-time check
3283 to prevent future regressions in this area.
3284 * data.c (Faset):
01103c44 3285 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3286 (Fsubst_char_in_region):
3287 * fns.c (concat):
3288 * xdisp.c (decode_mode_spec_coding):
3289 Adjust to CHAR_STRING's new requirement.
3290 * editfns.c (Finsert_char, Fsubst_char_in_region):
3291 * fns.c (concat): Check that character args are actually
3292 characters. Without this test, these functions did the wrong
3293 thing with wildly out-of-range values on 64-bit hosts.
3294
d37ca623
PE
3295 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3296 These casts should not be needed on 32-bit hosts, either.
3297 * keyboard.c (read_char):
3298 * lread.c (Fload): Remove casts to unsigned.
3299
ea204efb
PE
3300 * lisp.h (UNSIGNED_CMP): New macro.
3301 This fixes comparison bugs on 64-bit hosts.
3302 (ASCII_CHAR_P): Use it.
3303 * casefiddle.c (casify_object):
01103c44 3304 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3305 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3306 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3307 * dispextern.h (FACE_FROM_ID):
3308 * keyboard.c (read_char): Use UNSIGNED_CMP.
3309
41cb286c
PE
3310 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3311 not to EMACS_INT, to avoid GCC warning.
3312
4a1b9832
PE
3313 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3314
55daad71
PE
3315 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3316 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3317 isn't needed on 32-bit machines.
8f95c75c 3318
01103c44
PE
3319 * buffer.c (Fgenerate_new_buffer_name):
3320 Use EMACS_INT for count, not int.
0ceccced 3321 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3322
3323 * data.c (Qcompiled_function): Now static.
3324
c6f072e7
PE
3325 * window.c (window_body_lines): Now static.
3326
20ce5912
PE
3327 * image.c (gif_load): Rename local to avoid shadowing.
3328
9c4c5f81
PE
3329 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3330 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3331 * alloc.c (make_save_value): Integer argument is now of type
3332 ptrdiff_t, not int.
3333 (mark_object): Use ptrdiff_t, not int.
3334 * lisp.h (pD): New macro.
3335 * print.c (print_object): Use it.
3336
c0c5c8ae
PE
3337 * alloc.c: Use EMACS_INT, not int, to count objects.
3338 (total_conses, total_markers, total_symbols, total_vector_size)
3339 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3340 (total_free_floats, total_floats, total_free_intervals)
3341 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3342 Now EMACS_INT, not int. All uses changed.
3343 (Fgarbage_collect): Compute overall total using a double, so that
3344 integer overflow is less likely to be a problem. Check for overflow
3345 when converting back to an integer.
5a25e253
PE
3346 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3347 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3348 These were 'int' variables that could overflow on 64-bit hosts;
3349 they were never used, so remove them instead of repairing them.
211a0b2a 3350 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3351 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3352 Previously, this ceilinged at INT_MAX, but that doesn't work on
3353 64-bit machines.
e46bb31a 3354 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3355
c78baabf 3356 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3357 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3358 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3359 when a (possibly-narrower) signed value would do just as well.
3360 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3361
c9d624c6
PE
3362 * alloc.c: Catch some string size overflows that we were missing.
3363 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3364 for convenience in STRING_BYTES_MAX.
3365 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3366 The definition here is exact; the one in lisp.h was approximate.
3367 (allocate_string_data): Check for string overflow. This catches
3368 some instances we weren't catching before. Also, it catches
3369 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3370 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3371 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3372
c9d624c6
PE
3373 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3374 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3375 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3376
353032ce
PE
3377 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3378
2bccce07
PE
3379 * alloc.c (Fmake_string): Check for out-of-range init.
3380
0ac30604
SM
33812011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3382
3383 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3384
c195f2de
JD
33852011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3386
3387 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3388 xg_get_default_scrollbar_width.
3389
3390 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3391 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3392 (style_changed_cb): Call update_theme_scrollbar_width and call
3393 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3394 all frames (Bug#8505).
3395 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3396 Call gtk_window_set_resizable if HAVE_GTK3.
3397 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3398 and height if HAVE_GTK3 (Bug#8505).
3399 (scroll_bar_width_for_theme): New variable.
3400 (update_theme_scrollbar_width): New function.
3401 (xg_get_default_scrollbar_width): Move code to
3402 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3403 (xg_initialize): Call update_theme_scrollbar_width.
3404
3405 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3406
3407 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3408
e10ac9f1
MR
34092011-06-12 Martin Rudalics <rudalics@gmx.at>
3410
3411 * frame.c (make_frame): Call other_buffer_safely instead of
3412 other_buffer.
3413
3414 * window.c (temp_output_buffer_show): Call display_buffer with
3415 second argument Vtemp_buffer_show_specifiers and reset latter
3416 immediately after the call.
3417 (Vtemp_buffer_show_specifiers): New variable.
3418 (auto_window_vscroll_p, next_screen_context_lines)
3419 (Vscroll_preserve_screen_position): Remove leading asterisks from
3420 doc-strings.
3421
2d3c217e 34222011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3423
7b7f97e8 3424 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3425 * buffer.c (Qclone_number): Remove for now, as it's unused.
3426 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3427 (record_buffer): Remove unused local.
3428 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3429 (set_frame_buffer_list): Remove; unused.
3430 * frame.h (other_visible_frames): Remove decl.
3431 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3432 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3433 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3434 if HAVE_GPM.
3435 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3436 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3437 Define only if HAVE_GPM.
3438 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3439 (update_hints_inhibit): Remove; never set. All uses removed.
3440 * widgetprv.h (emacsFrameClassRec): Remove decl.
3441 * window.c (delete_deletable_window): Now returns void, since it
3442 wasn't returning anything.
3443 (compare_window_configurations): Remove unused locals.
3444 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3445 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3446 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3447 the same widths as pointers. This follows up on the 2011-05-06 patch.
3448 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3449 * xterm.h: Likewise.
3450 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3451
1384b89e
JB
34522011-06-12 Juanma Barranquero <lekktu@gmail.com>
3453
3454 * makefile.w32-in: Update dependencies.
3455 (LISP_H): Add lib/intprops.h.
3456
1100a63c
CY
34572011-06-11 Chong Yidong <cyd@stupidchicken.com>
3458
3459 * image.c (gif_load): Add animation frame delay to the metadata.
3460 (syms_of_image): Use DEFSYM. New symbol `delay'.
3461
6198ccd0
MR
34622011-06-11 Martin Rudalics <rudalics@gmx.at>
3463
3464 * window.c (delete_deletable_window): Re-add.
3465 (Fset_window_configuration): Rewrite to handle dead buffers and
3466 consequently deletable windows.
3467 (window_tree, Fwindow_tree): Remove. Supply functionality in
3468 window.el.
3469 (compare_window_configurations): Simplify code.
3470
b6e3633c
AS
34712011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3472
1ab0dee5
AS
3473 * image.c (imagemagick_load_image): Fix type mismatch.
3474 (Fimagemagick_types): Likewise.
3475
b6e3633c
AS
3476 * window.h (replace_buffer_in_windows): Declare.
3477
9397e56f
MR
34782011-06-11 Martin Rudalics <rudalics@gmx.at>
3479
3480 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3481 Qclone_number. Remove external declaration of Qdelete_window.
3482 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3483 code.
640c8776
SM
3484 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3485 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3486 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3487 buffer list implementation.
3488 (other_buffer_safely): New function.
3489 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3490 calls to replace_buffer_in_windows and
3491 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3492 if allowed.
3493 (record_buffer): Inhibit quitting and rewrite using quittable
3494 functions. Run Qbuffer_list_update_hook if allowed.
3495 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3496 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3497 Move switch-to-buffer to window.el.
9397e56f
MR
3498 (bury-buffer): Move to window.el.
3499 (Vbuffer_list_update_hook): New variable.
3500
3501 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3502 section.
3503
3504 * window.h (resize_frame_windows): Move up in code.
3505 (Fwindow_frame): Remove EXFUN.
3506 (replace_buffer_in_all_windows): Remove prototype.
3507 (replace_buffer_in_windows_safely): Add prototype.
3508
3509 * window.c: Declare Qdelete_window static again. Move down
3510 declaration of select_count.
3511 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3512 (Fother_window): Move to window.el.
3513 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3514 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3515 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3516 window.el.
3517 (replace_buffer_in_windows): Implement by calling
3518 Qreplace_buffer_in_windows.
3519 (replace_buffer_in_all_windows): Remove with some functionality
3520 moved into replace_buffer_in_windows_safely.
3521 (replace_buffer_in_windows_safely): New function.
3522 (select_window_norecord, select_frame_norecord): Move in front
3523 of run_window_configuration_change_hook. Remove now obsolete
3524 declarations.
640c8776
SM
3525 (Fset_window_buffer): Rewrite doc-string.
3526 Call Qrecord_window_buffer.
9397e56f
MR
3527 (keys_of_window): Move binding for other-window to window.el.
3528
b50691aa
CY
35292011-06-11 Chong Yidong <cyd@stupidchicken.com>
3530
3531 * dispextern.h (struct image): Replace data member, whose int_val
3532 and ptr_val fields were not used by anything, with a single
3533 lisp_val object.
3534
3535 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3536 (gif_clear_image, gif_load, imagemagick_load_image)
3537 (gs_clear_image, gs_load): Callers changed.
3538
3f754b86
PE
35392011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3540
cca69397
PE
3541 * buffer.h: Include <time.h>, for time_t.
3542 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3543
109e28d0
PE
3544 Fix minor problems found by static checking.
3545
60737f02
PE
3546 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3547
4b66faf3
PE
3548 Make identifiers static if they are not used in other modules.
3549 * data.c (Qcompiled_function, Qframe, Qvector):
3550 * image.c (QimageMagick, Qsvg):
3551 * minibuf.c (Qmetadata):
3552 * window.c (resize_window_check, resize_root_window): Now static.
3553 * window.h (resize_window_check, resize_root_window): Remove decls.
3554
109e28d0
PE
3555 * window.c (window_deletion_count, delete_deletable_window):
3556 Remove; unused.
46a4ce9e
PE
3557 (window_body_lines): Now static.
3558 (Fdelete_other_windows_internal): Mark vars as initialized.
3559 Make sure 'resize_failed' is initialized.
3560 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3561 (resize_window_apply): Remove unused local.
3562 * window.h (delete_deletable_window): Remove decl.
3563
109e28d0 3564 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3565 (imagemagick_load_image): Fix pointer signedness problem by changing
3566 last arg from unsigned char * to char *. All uses changed.
3567 Also, fix a local for similar reasons.
3568 Remove unused locals. Remove locals to avoid shadowing.
3569 (fn_rsvg_handle_free): Remove; unused.
3570 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3571 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3572
3f754b86
PE
3573 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3574
2547adb1
CY
35752011-06-10 Chong Yidong <cyd@stupidchicken.com>
3576
3577 * image.c (gif_load): Fix omitted cast error introduced by
3578 2011-06-06 change.
3579
2c8e37d4
MR
35802011-06-10 Martin Rudalics <rudalics@gmx.at>
3581
3582 * window.h (resize_proportionally, orig_total_lines)
3583 (orig_top_line): Remove from window structure.
3584 (set_window_height, set_window_width, change_window_heights)
3585 (Fdelete_window): Remove prototypes.
3586 (resize_frame_windows): Remove duplicate declaration.
3587
440a42e3
EZ
35882011-06-10 Eli Zaretskii <eliz@gnu.org>
3589
3590 * window.h (resize_frame_windows, resize_window_check)
3591 (delete_deletable_window, resize_root_window)
3592 (resize_frame_windows): Declare prototypes.
3593
3594 * window.c (resize_window_apply): Make definition be "static" to
3595 match the prototype.
3596
562dd5e9
MR
35972011-06-10 Martin Rudalics <rudalics@gmx.at>
3598
3599 * window.c: Remove declarations of Qwindow_size_fixed,
3600 window_min_size_1, window_min_size_2, window_min_size,
3601 size_window, window_fixed_size_p, enlarge_window, delete_window.
3602 Remove static from declaration of Qdelete_window, it's
3603 temporarily needed by Fbury_buffer.
3604 (replace_window): Don't assign orig_top_line and
3605 orig_total_lines.
3606 (Fdelete_window, delete_window): Remove. Window deletion is
3607 handled by window.el.
640c8776
SM
3608 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3609 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3610 (Fdelete_other_windows): Remove. Deleting other windows is
3611 handled by window.el.
3612 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3613 handled in window.el.
3614 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3615 Window minimum sizes are handled in window.el.
3616 (shrink_windows, size_window, set_window_height)
3617 (set_window_width, change_window_heights, window_height)
3618 (window_width, CURBEG, CURSIZE, enlarge_window)
3619 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3620 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3621 handled in window.el.
3622 (make_dummy_parent): Rename to make_parent_window and give it a
3623 second argument horflag.
3624 (make_window): Don't set resize_proportionally any more.
3625 (Fsplit_window): Remove. Windows are split in window.el.
3626 (save_restore_action, save_restore_orig_size)
3627 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3628 Resize mini windows in window.el.
3629 (grow_mini_window, shrink_mini_window): Implement by calling
3630 Qresize_root_window_vertically, resize_window_check and
3631 resize_window_apply.
640c8776
SM
3632 (saved_window, Fset_window_configuration, save_window_save):
3633 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3634 resize_proportionally.
3635 (window_min_height, window_min_width): Move to window.el.
3636 (keys_of_window): Move bindings for delete-other-windows,
3637 split-window, delete-window and enlarge-window to window.el.
3638
3639 * buffer.c: Temporarily extern Qdelete_window.
3640 (Fbury_buffer): Temporarily call Qdelete_window instead of
3641 Fdelete_window (Fbury_buffer will move to window.el soon).
3642
3643 * frame.c (set_menu_bar_lines_1): Remove code handling
3644 orig_top_line and orig_total_lines.
3645
3646 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3647 set_window_height but set heights directly.
3648 (change_frame_size_1): Use resize_frame_windows.
3649
3650 * xdisp.c (init_xdisp): Don't use set_window_height but set
3651 heights directly.
3652
640c8776
SM
3653 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3654 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3655 run_window_configuration_change_hook.
3656
3657 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3658 instead of change_window_heights and run
3659 run_window_configuration_change_hook.
3660
1a13852e
MR
36612011-06-09 Martin Rudalics <rudalics@gmx.at>
3662
3663 * window.c (replace_window): Rename second argument REPLACEMENT to
3664 NEW. New third argument SETFLAG. Rewrite.
3665 (delete_window, make_dummy_parent): Call replace_window with
3666 third argument 1.
3667 (window_list_1): Move down in code.
3668 (run_window_configuration_change_hook): Move set_buffer part
3669 before select_frame_norecord part in order to unwind correctly.
3670 Rename count1 to count.
3671 (recombine_windows, delete_deletable_window, resize_root_window)
3672 (Fdelete_other_windows_internal)
3673 (Frun_window_configuration_change_hook, make_parent_window)
3674 (resize_window_check, resize_window_apply, Fresize_window_apply)
3675 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3676 (Fdelete_window_internal, Fresize_mini_window_internal):
3677 New functions.
1a13852e
MR
3678 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3679
f3d1777e
MR
36802011-06-08 Martin Rudalics <rudalics@gmx.at>
3681
496e208e
MR
3682 * window.h (window): Add some new members to window structure -
3683 normal_lines, normal_cols, new_total, new_normal, clone_number,
3684 splits, nest, prev_buffers, next_buffers.
3685 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3686 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3687
f3d1777e
MR
3688 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3689 Remove.
496e208e
MR
3690 (make_dummy_parent): Set new members of windows structure.
3691 (make_window): Move down in code. Handle new members of window
3692 structure.
3693 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3694 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3695 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3696 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3697 (Fset_window_next_buffers, Fset_window_clone_number):
3698 New functions.
496e208e
MR
3699 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3700 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3701 Doc-string fixes.
3702 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3703 Argument WINDOW can be now internal window too.
3704 (Fwindow_use_time): Move up in code.
3705 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3706 Rewrite doc-string.
3707 (Fset_window_configuration, saved_window)
3708 (Fcurrent_window_configuration, save_window_save): Handle new
3709 members of window structure.
b9e809c2
MR
3710 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3711 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3712 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3713 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3714 Qget_mru_window, Qresize_root_window,
3715 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3716 Qauto_buffer_name; staticpro them.
f3d1777e 3717
abde8f8c
MR
37182011-06-07 Martin Rudalics <rudalics@gmx.at>
3719
3720 * window.c (Fwindow_total_size, Fwindow_left_column)
3721 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3722 (Fwindow_list_1): New functions.
3723 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3724 (Fwindow_width, Fscroll_left, Fscroll_right):
3725 Use window_body_cols instead of window_box_text_cols.
3726 (delete_window, Fset_window_configuration):
3727 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3728 (delete_all_subwindows): Take a window as argument and not a
3729 structure. Rewrite.
190b47e6
MR
3730 (window_loop): Remove handling of GET_LRU_WINDOW and
3731 GET_LARGEST_WINDOW.
3732 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3733
3734 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3735 window_box_text_cols. delete_all_subwindows now takes a
3736 Lisp_Object as argument.
abde8f8c 3737
640c8776
SM
3738 * indent.c (compute_motion, Fcompute_motion):
3739 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3740
fa8a67e6
MR
3741 * frame.c (delete_frame): Call delete_all_subwindows with root
3742 window as argument.
3743
a54e3482
DC
37442011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3745
3746 * fns.c (Fputhash): Document return value.
3747
60002bf5
CY
37482011-06-06 Chong Yidong <cyd@stupidchicken.com>
3749
3750 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3751
0c671da6 37522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3753
b862a52a 3754 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3755
be44ca6c
PE
3756 Check for overflow when converting integer to cons and back.
3757 * charset.c (Fdefine_charset_internal, Fdecode_char):
3758 Use cons_to_unsigned to catch overflow.
3759 (Fencode_char): Use INTEGER_TO_CONS.
3760 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3761 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3762 * data.c (long_to_cons, cons_to_long): Remove.
3763 (cons_to_unsigned, cons_to_signed): New functions.
3764 These signal an error for invalid or out-of-range values.
3765 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3766 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3767 * font.c (Ffont_variation_glyphs):
3768 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3769 * lisp.h: Include <intprops.h>.
3770 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3771 (cons_to_signed, cons_to_unsigned): New decls.
3772 (long_to_cons, cons_to_long): Remove decls.
3773 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3774 (Fprimitive_undo): Use CONS_TO_INTEGER.
3775 * xfns.c (Fx_window_property): Likewise.
3776 * xselect.c: Include <limits.h>.
3777 (x_own_selection, selection_data_to_lisp_data):
3778 Use INTEGER_TO_CONS.
3779 (x_handle_selection_request, x_handle_selection_clear)
3780 (x_get_foreign_selection, Fx_disown_selection_internal)
3781 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3782 (lisp_data_to_selection_data): Use cons_to_unsigned.
3783 (x_fill_property_data): Use cons_to_signed.
3784 Report values out of range.
3785
d1f3d2af
PE
3786 Check for buffer and string overflow more precisely.
3787 * buffer.h (BUF_BYTES_MAX): New macro.
3788 * lisp.h (STRING_BYTES_MAX): New macro.
3789 * alloc.c (Fmake_string):
3790 * character.c (string_escape_byte8):
3791 * coding.c (coding_alloc_by_realloc):
3792 * doprnt.c (doprnt):
3793 * editfns.c (Fformat):
3794 * eval.c (verror):
3795 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3796 since they may not be the same number.
3797 * editfns.c (Finsert_char):
3798 * fileio.c (Finsert_file_contents):
3799 Likewise for BUF_BYTES_MAX.
3800
dd52fcea
PE
3801 * image.c: Use ptrdiff_t, not int, for sizes.
3802 (slurp_file): Switch from int to ptrdiff_t.
3803 All uses changed.
3804 (slurp_file): Check that file size fits in both size_t (for
3805 malloc) and ptrdiff_t (for sanity and safety).
3806
7f9bbdbb
PE
3807 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3808 if b->modtime has its maximal value.
3809
dfe18f82
PE
3810 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3811
84acfcf0
PE
3812 Don't assume time_t can fit into int.
3813 * buffer.h (struct buffer.modtime): Now time_t, not int.
3814 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3815 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3816
ccd9a01a
PE
3817 Minor fixes for signed vs unsigned integers.
3818 * character.h (MAYBE_UNIFY_CHAR):
3819 * charset.c (maybe_unify_char):
3820 * keyboard.c (read_char, reorder_modifiers):
3821 XINT -> XFASTINT, since the integer must be nonnegative.
3822 * ftfont.c (ftfont_spec_pattern):
3823 * keymap.c (access_keymap, silly_event_symbol_error):
3824 XUINT -> XFASTINT, since the integer must be nonnegative.
3825 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3826 since it makes no difference and we prefer signed.
3827 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3828 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3829 nonnegative.
3830
d6d100dd
SM
38312011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3832
3833 * window.h (Fwindow_frame): Declare.
3834
2b6148e4
PE
38352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3836
3837 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3838 (SPARE_MEMORY): Always define.
3839 (LARGE_REQUEST): Remove.
3840 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3841
f230ecc9
MR
38422011-06-06 Martin Rudalics <rudalics@gmx.at>
3843
727e958e
MR
3844 * lisp.h: Move EXFUNS for Fframe_root_window,
3845 Fframe_first_window and Fset_frame_selected_window to window.h.
3846
3847 * window.h: Move EXFUNS for Fframe_root_window,
3848 Fframe_first_window and Fset_frame_selected_window here from
3849 lisp.h.
3850
3851 * frame.c (Fwindow_frame, Fframe_first_window)
3852 (Fframe_root_window, Fframe_selected_window)
3853 (Fset_frame_selected_window): Move to window.c.
3854 (Factive_minibuffer_window): Move to minibuf.c.
3855 (Fother_visible_frames_p): New function.
3856
3857 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3858
f230ecc9
MR
3859 * window.c (decode_window, decode_any_window): Move up in code.
3860 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3861 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3862 (Fwindow_buffer): Move up and rewrite doc-string.
3863 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3864 (Fwindow_prev): New functions.
727e958e
MR
3865 (Fwindow_frame): Move here from frame.c. Accept any window as
3866 argument.
3867 (Fframe_root_window, Fframe_first_window)
3868 (Fframe_selected_window): Move here from frame.c. Accept frame
3869 or arbitrary window as argument. Update doc-strings.
3870 (Fminibuffer_window): Move up in code.
3871 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3872 (Fset_frame_selected_window): Move here from frame.c.
3873 Marginal rewrite.
727e958e
MR
3874 (Fselected_window, select_window, Fselect_window): Move up in
3875 code. Minor doc-string fixes.
f230ecc9 3876
4d09bcf6
PE
38772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3880 Do not assume that spare memory exists; that assumption is valid
3881 only if SYSTEM_MALLOC.
3882 (LARGE_REQUEST): New macro, so that the issue of large requests
3883 is separated from the issue of spare memory.
3884
810928a2
AS
38852011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3886
172418ad
AS
3887 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3888 format. (Bug#8806)
3889
43f862f7
AS
3890 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3891
810928a2
AS
3892 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3893 before statements.
3894
a059fe24
JD
38952011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3896
3897 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3898
3899 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3900
3901 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3902 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3903
989bf368
JB
39042011-06-05 Juanma Barranquero <lekktu@gmail.com>
3905
3906 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3907
4b80f674
CY
39082011-06-04 Chong Yidong <cyd@stupidchicken.com>
3909
3910 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3911 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3912 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3913 New error handlers.
4b80f674
CY
3914 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3915 Obey Vx_select_enable_clipboard_manager. Catch errors in
3916 x_clipboard_manager_save (Bug#8779).
3917 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3918 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3919
99a33b77 39202011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3921
3922 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3923
99a33b77 39242011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3925
3926 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3927 in the current matrix if keep_current_p is non-zero.
3928
8264569d
EZ
39292011-06-04 Eli Zaretskii <eliz@gnu.org>
3930
3931 * bidi.c (bidi_level_of_next_char): Fix last change.
3932
57f97249
EZ
39332011-06-03 Eli Zaretskii <eliz@gnu.org>
3934
fec2107c 3935 Support bidi reordering of text covered by display properties.
57f97249 3936
fec2107c
EZ
3937 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3938 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3939 (bidi_cache_search, bidi_cache_iterator_state)
3940 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3941 (bidi_level_of_next_char, bidi_move_to_visually_next):
3942 Support character positions inside a run of characters covered by a
fec2107c
EZ
3943 display string.
3944 (bidi_paragraph_init, bidi_resolve_explicit_1)
3945 (bidi_level_of_next_char): Call bidi_fetch_char and
3946 bidi_fetch_char_advance instead of FETCH_CHAR and
3947 FETCH_CHAR_ADVANCE.
3948 (bidi_init_it): Initialize new members.
3949 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3950 definitions.
3951 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3952 instead of using explicit *_CHAR codes.
d6d100dd
SM
3953 (bidi_resolve_explicit, bidi_resolve_weak):
3954 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3955 bidirectional text is supported only in multibyte buffers.
3956 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3957 it to initialize the frame_window_p member of struct bidi_it.
3958 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3959 (bidi_resolve_explicit, bidi_resolve_weak)
3960 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3961 bidi_it->nchars is non-positive.
3962 (bidi_level_of_next_char): Don't try to lookup the cache for the
3963 next/previous character if nothing is cached there yet, or if we
3964 were just reseat()'ed to a new position.
c40e2fb2 3965
0e14fe90
EZ
3966 * xdisp.c (set_cursor_from_row): Set start and stop points
3967 according to the row's direction when priming the loop that looks
3968 for the glyph on which to display cursor.
3969 (single_display_spec_intangible_p): Function deleted.
3970 (display_prop_intangible_p): Reimplement to call
3971 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3972 Accept 3 additional arguments needed by handle_display_spec.
3973 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3974 values: lists, `(when COND...)' forms, etc.
3975 (single_display_spec_string_p): Support property values that are
3976 lists with the argument STRING its top-level element.
3977 (display_prop_string_p): Fix the condition for processing a
3978 property that is a list to be consistent with handle_display_spec.
fec2107c 3979 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3980 last portion of handle_display_prop.
3981 (compute_display_string_pos): Accept additional argument
3982 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3983 value of a `display' property is a "replacing spec".
3984 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3985 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3986 the display property, but just return a value indicating whether
3987 the display property will replace the characters it covers.
3988 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3989 frame_window_p members of struct bidi_it.
d6d100dd
SM
3990 (compute_display_string_pos, compute_display_string_end):
3991 New functions.
fec2107c
EZ
3992 (push_it): Accept second argument POSITION, where pop_it should
3993 jump to continue iteration.
3994 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3995
fec2107c
EZ
3996 * keyboard.c (adjust_point_for_property): Adjust the call to
3997 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3998
3999 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4000 (bidi_init_it): Update prototypes.
4001 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4002 (compute_display_string_pos, compute_display_string_end):
4003 Declare prototypes.
fec2107c
EZ
4004 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4005 EMACS_INT.
fc6f18ce 4006
40087514 40072011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4008
57f53182
PE
4009 Malloc failure behavior now depends on size of allocation.
4010 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4011 * lisp.h: Change signatures accordingly.
4012 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4013 All callers changed. (Bug#8762)
4014
4015 * gnutls.c: Use Emacs's memory allocators.
4016 Without this change, the gnutls library would invoke malloc etc.
4017 directly, which causes problems on non-SYNC_INPUT hosts, and which
4018 runs afoul of improving memory_full behavior. (Bug#8761)
4019 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4020 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4021 xfree instead of the default malloc, realloc, free.
4022 (Fgnutls_boot): No need to check for memory allocation failure,
4023 since xmalloc does that for us.
4024
ac32cd99 4025 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4026 * category.c (hash_get_category_set):
4027 * ccl.c (ccl_driver):
4028 * charset.c (Fdefine_charset_internal):
4029 * charset.h (struct charset.hash_index):
4030 * composite.c (get_composition_id, gstring_lookup_cache)
4031 (composition_gstring_put_cache):
4032 * composite.h (struct composition.hash_index):
4033 * dispextern.h (struct image.hash):
4034 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4035 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4036 (hashfn_equal, hashfn_user_defined, make_hash_table)
4037 (maybe_resize_hash_table, hash_lookup, hash_put)
4038 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4039 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4040 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4041 * image.c (make_image, search_image_cache, lookup_image)
4042 (xpm_put_color_table_h):
4043 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4044 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4045 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4046 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4047 * alloc.c (allocate_vectorlike):
4048 Check for overflow in vector size calculations.
4049 * ccl.c (ccl_driver):
4050 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4051 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4052 need to be updated by these changes.
40087514
PE
4053 * fns.c (make_hash_table, maybe_resize_hash_table):
4054 Check for integer overflow with large hash tables.
0de4bb68
PE
4055 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4056 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4057 (SXHASH_REDUCE): New macro.
4058 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4059 Use it instead of discarding useful hash info with large hash values.
4060 (sxhash_float): New function.
4061 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4062 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4063 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4064 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4065 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4066 Adjust signatures to match updated version of code.
4067 (consing_since_gc): Now EMACS_INT, since a single hash table can
4068 use more than INT_MAX bytes.
4069
698d32e2
DN
40702011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4071
4072 Make it possible to build with GCC-4.6+ -O2 -flto.
4073
4074 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4075
fd6fa53f
SM
40762011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4077
4078 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4079 Call minibuffer-inactive-mode.
4080
864db017
JB
40812011-05-31 Juanma Barranquero <lekktu@gmail.com>
4082
4083 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4084 Update dependencies.
4085
2ad0baf4
DN
40862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4087
4088 * data.c (init_data): Remove code for UTS, this system is not
4089 supported anymore.
4090
4fcc2638
DN
40912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4092
4093 Don't force ./temacs to start in terminal mode.
4094
4095 * frame.c (make_initial_frame): Initialize faces in all cases, not
4096 only when CANNOT_DUMP is defined.
4097 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4098
c56e0fd5
DN
40992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4100
4101 * dispnew.c (add_window_display_history): Use const for the string
4102 pointer. Remove declaration, not needed.
4103
333d54da 41042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4105
55d4c1b2 4106 Use 'inline', not 'INLINE'.
333d54da 4107 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4108 * alloc.c, fontset.c (INLINE): Remove.
4109 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4110 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4111 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4112 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4113 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4114
738db178
DN
41152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4116
4117 Make it possible to run ./temacs.
4118
4119 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4120 syms_of_callproc does the same thing. Remove test for
4121 "initialized", do it in the caller.
4122 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4123
620c53a6
SM
41242011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4125
4126 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4127 (read_minibuf): Use get_minibuffer.
4128 (syms_of_minibuf): Use DEFSYM.
4129 (Qmetadata): New var.
4130 * data.c (Qbuffer): Don't make it static.
4131 (syms_of_data): Use DEFSYM.
4132
e003a292
PE
41332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4136 (CCL_CODE_MIN): New macro.
4137
ed008a6d
PE
41382011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4139
3687c2ef
PE
4140 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4141
ed008a6d
PE
4142 * eval.c (Qdebug): Now static.
4143 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4144 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4145 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4146
d66c4c7c
CY
41472011-05-29 Chong Yidong <cyd@stupidchicken.com>
4148
4149 * image.c: Various fixes to ImageMagick code comments.
4150 (Fimagemagick_types): Doc fix.
4151
5fbc2025
PE
41522011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4153
0196f88a
PE
4154 Minor fixes prompted by GCC 4.6.0 warnings.
4155
4156 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4157
5fbc2025
PE
4158 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4159 (x_clipboard_manager_save_all): Move extern decl to ...
4160 * xterm.h: ... here, so that it can be checked for consistency.
4161
1dd3c2d9
CY
41622011-05-29 Chong Yidong <cyd@stupidchicken.com>
4163
4164 * xselect.c (x_clipboard_manager_save_frame)
4165 (x_clipboard_manager_save_all): New functions.
4166 (Fx_clipboard_manager_save): Lisp function deleted.
4167
4168 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4169 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4170
4171 * xterm.h: Update prototype.
4172
5ba6571d
WX
41732011-05-28 William Xu <william.xwl@gmail.com>
4174
4175 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4176 exiting (Bug#8239).
4177
3eaff834
JM
41782011-05-28 Jim Meyering <meyering@redhat.com>
4179
e1900994 4180 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4181 * fns.c (to_uchar): Define.
4182 (crypto_hash_function): Use it to convert some newly-signed
4183 variables to unsigned, to avoid sign-extension bugs. For example,
4184 without this change, (md5 "truc") would evaluate to
4185 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4186 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4187 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4188
0f6990a7
PE
41892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 Integer overflow fixes.
c8a9ca5a 4192
08686060
PE
4193 * dbusbind.c: Serial number integer overflow fixes.
4194 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4195 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4196 to hold a serial number that is too large for a fixnum.
4197 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4198 Check for serial numbers out of range. Decode any serial number
59568bf0 4199 that was so large that it became a float. (Bug#8722)
08686060 4200
2d1fc3c7
PE
4201 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4202 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4203 Use XFASTINT rather than XUINT when numbers are nonnegative.
4204 (xd_append_arg, Fdbus_method_return_internal):
4205 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4206 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4207 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4208 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4209 (Bug#8722)
2d1fc3c7 4210
c8a9ca5a
PE
4211 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4212
519e1d69
PE
4213 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4214
30569699
PE
4215 ccl: add integer overflow checks
4216 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4217 (IN_INT_RANGE): New macros.
4218 (ccl_driver): Use them to check for integer overflow when
4219 decoding a CCL program. Many of the new checks are whether XINT (x)
4220 fits in int; it doesn't always, on 64-bit hosts. The new version
4221 doesn't catch all possible integer overflows, but it's an
847044ea 4222 improvement. (Bug#8719)
30569699 4223
c11285dc
PE
4224 * alloc.c (make_event_array): Use XINT, not XUINT.
4225 There's no need for unsigned here.
4226
fdccd48e
PE
4227 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4228 This follows up to the 2011-05-06 change that substituted uintptr_t
4229 for EMACS_INT. This case wasn't caught back then.
4230
37910ab2
PE
4231 Rework Fformat to avoid integer overflow issues.
4232 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4233 now (part of C89). Include <verify.h>.
4234 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4235 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4236 (Fformat): Avoid the prepass trying to compute sizes; it was only
4237 approximate and thus did not catch overflow reliably. Instead, walk
4238 through the format just once, formatting and computing sizes as we go,
4239 checking for integer overflow at every step, and allocating a larger
4240 buffer as needed. Keep track separately whether the format is
4241 multibyte. Keep only the most-recently calculated precision, rather
4242 than them all. Record whether each argument has been converted to
4243 string. Use EMACS_INT, not int, for byte and char and arg counts.
4244 Support field widths and precisions larger than INT_MAX. Avoid
4245 sprintf's undefined behavior with conversion specifications such as %#d
4246 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4247 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4248 formatting out-of-range floating point numbers with int
9173deec 4249 formats. (Bug#8668)
37910ab2 4250
2e6578fb
PE
4251 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4252
0ae6bdee
PE
4253 * data.c: Avoid integer truncation in expressions involving floats.
4254 * data.c: Include <intprops.h>.
4255 (arith_driver): When there's an integer overflow in an expression
4256 involving floating point, convert the integers to floating point
4257 so that the resulting value does not suffer from catastrophic
4258 integer truncation. For example, on a 64-bit host (* 4
4259 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4260 Do not rely on undefined behavior after integer overflow.
4261
de883a70
PE
4262 merge count_size_as_multibyte, parse_str_to_multibyte
4263 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4264 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4265 Check for integer overflow.
4266 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4267 since it's now a duplicate of the other. This is more of
4268 a character than a buffer op, so better that it's in character.c.
4269 * fns.c, print.c: Adjust to above changes.
4270
2ff916cb
PE
42712011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4272
4273 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4274
f1b54466
PE
42752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4276
fb1ac845
PE
4277 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4278 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4279 (x_clipboard_manager_save): Now static.
4280 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4281
f1b54466
PE
4282 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4283 (crypto_hash_function): Now static.
4284 Fix pointer signedness problems. Avoid unnecessary initializations.
4285
a9f737ee
CY
42862011-05-27 Chong Yidong <cyd@stupidchicken.com>
4287
4288 * termhooks.h (Vselection_alist): Make it terminal-local.
4289
4290 * terminal.c (create_terminal): Initialize it.
4291
4292 * xselect.c: Support for clipboard managers.
4293 (Vselection_alist): Move to termhooks.h as terminal-local var.
4294 (LOCAL_SELECTION): New macro.
4295 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4296 (symbol_to_x_atom): Remove gratuitous arg.
4297 (x_handle_selection_request, lisp_data_to_selection_data)
4298 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4299 (x_own_selection, x_get_local_selection, x_convert_selection):
4300 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4301 (some_frame_on_display): Delete unused function.
4302 (Fx_own_selection_internal, Fx_get_selection_internal)
4303 (Fx_disown_selection_internal, Fx_selection_owner_p)
4304 (Fx_selection_exists_p): New optional frame arg.
4305 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4306 (x_handle_selection_clear): Don't treat other terminals with the
4307 same keyboard specially. Use the terminal-local Vselection_alist.
4308 (x_clear_frame_selections): Use Frun_hook_with_args.
4309
4310 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4311
4312 * xterm.h: Add support for those atoms.
4313
e067f0c1
CY
43142011-05-26 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4317 (converted_selections, conversion_fail_tag): New global variables.
4318 (x_selection_request_lisp_error): Free the above.
4319 (x_get_local_selection): Remove unnecessary code.
4320 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4321 of converted selections stored in converted_selections.
4322 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4323 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4324 (x_convert_selection): New function.
4325 (x_handle_selection_event): Simplify.
4326 (x_get_foreign_selection): Don't ignore incoming requests while
4327 waiting for an answer; this will fail when we implement
4328 SAVE_TARGETS, and seems unnecessary anyway.
4329 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4330 (Vx_sent_selection_functions): Doc fix.
4331
0f4aebc0
LL
43322011-05-26 Leo Liu <sdl.web@gmail.com>
4333
4334 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4335
e61124cd
YM
43362011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4337
4338 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4339
4340 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4341 for fringe update if it has periodic bitmap.
ac389d0c 4342 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4343 and fringe_bitmap_periodic_p.
4344
4345 * fringe.c (get_fringe_bitmap_data): New function.
4346 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4347 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4348 row. Mark glyph row for fringe update if periodicity changed.
4349
4350 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4351 for fringe update unless it has periodic bitmap.
4352
f16d9837
KH
43532011-05-25 Kenichi Handa <handa@m17n.org>
4354
4355 * xdisp.c (get_next_display_element): Set correct it->face_id for
4356 a static composition.
4357
e1b90ef6
LL
43582011-05-24 Leo Liu <sdl.web@gmail.com>
4359
4360 * deps.mk (fns.o):
4361 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4362
4363 * fns.c (crypto_hash_function, Fsha1): New function.
4364 (Fmd5): Use crypto_hash_function.
4365 (syms_of_fns): Add Ssha1.
4366
7400048f
PE
43672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4368
4369 * gnutls.c: Remove unused macros.
4370 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4371 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4372 Remove macros that are defined and never used.
4373 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4374
abb71cf4
CY
43752011-05-22 Chong Yidong <cyd@stupidchicken.com>
4376
4377 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4378 (Fx_get_selection_internal): Minor cleanup.
4379 (Fx_own_selection_internal): Rename arguments for consistency with
4380 select.el.
4381
6307db39
PE
43822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4383
4384 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4385
f3d4e0a4
CY
43862011-05-22 Chong Yidong <cyd@stupidchicken.com>
4387
4388 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4389
4d8ade89
YM
43902011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4391
4392 * dispnew.c (scrolling_window): Don't exclude the case that the
4393 last enabled row in the desired matrix touches the bottom boundary.
4394
32078c8d
GM
43952011-05-21 Glenn Morris <rgm@gnu.org>
4396
4397 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4398 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4399 and add some more files.
32078c8d 4400
7285dc67
EZ
44012011-05-20 Eli Zaretskii <eliz@gnu.org>
4402
4403 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4404 report_file_error introduced by the change from 2011-05-07.
4405
89d1bd22
PE
44062011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4407
4408 * systime.h (Time): Define only if emacs is defined.
4409 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4410 where the include path doesn't have X11/X.h by default. See
4411 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4412
e23640bb 44132011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4414
4415 * composite.c (find_automatic_composition): Fix previous change.
4416
b9704ad9
GM
44172011-05-20 Glenn Morris <rgm@gnu.org>
4418
4419 * lisp.mk: New file, split from Makefile.in.
4420 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4421 (shortlisp): Remove.
4422 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4423
4a720484
GM
44242011-05-19 Glenn Morris <rgm@gnu.org>
4425
4426 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4427 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4428 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4429 (lisp): Set the order to that of loadup.el.
4430 (shortlisp): Make it a copy of $lisp.
4431 (SOME_MACHINE_LISP): Remove.
4432 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4433 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4434
a28d4396
KH
44352011-05-18 Kenichi Handa <handa@m17n.org>
4436
4437 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4438 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4439 (find_automatic_composition): Mostly rewrite for efficiency.
4440
a2b1fa8e
JB
44412011-05-18 Juanma Barranquero <lekktu@gmail.com>
4442
4443 * makefile.w32-in: Update dependencies.
4444
8e1f5610
CS
44452011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4446
4447 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4448 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4449
7025ee00 44502011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4451
cdfa6eab
PE
4452 Fix some integer overflow issues, such as string length overflow.
4453
06d6db33
PE
4454 * insdel.c (count_size_as_multibyte): Check for string overflow.
4455
2b4560a8
PE
4456 * character.c (lisp_string_width): Check for string overflow.
4457 Use EMACS_INT, not int, for string indexes and lengths; in
4458 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4459 the resulting string length overflows an EMACS_INT; instead,
4460 report a string overflow if no precision given. When checking for
4461 precision exhaustion, use a check that cannot possibly have
4462 integer overflow. (Bug#8675)
4463 * character.h (lisp_string_width): Adjust to new signature.
4464
cb93f9be
PE
4465 * alloc.c (string_overflow): New function.
4466 (Fmake_string): Use it. This doesn't change behavior, but saves
4467 a few bytes and will simplify future changes.
4468 * character.c (string_escape_byte8): Likewise.
4469 * lisp.h (string_overflow): New decl.
4470
1a1f3366
PE
4471 Fixups, following up to the user-interface timestamp change.
4472 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4473 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4474 * msdos.c (mouse_get_pos): Likewise.
4475 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4476 * w32gui.h (Time): Define by including "systime.h" rather than by
4477 declaring it ourselves. (Bug#8664)
4478
d4e3e4d3
PE
4479 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4480 * image.c (clear_image_cache): Likewise.
4481
f6a24d19
PE
4482 * term.c (term_mouse_position): Don't assume time_t wraparound.
4483
08dc5ae6
PE
4484 Be more systematic about user-interface timestamps.
4485 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4486 and sometimes 'EMACS_UINT', to represent these timestamps.
4487 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4488 This makes the code easier to follow, and makes it easier to catch
4489 integer overflow bugs such as Bug#8664.
4490 * frame.c (Fmouse_position, Fmouse_pixel_position):
4491 Use Time, not unsigned long, for user-interface timestamps.
4492 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4493 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4494 * keyboard.h (last_event_timestamp): Likewise.
4495 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4496 * menu.h (xmenu_show): Likewise.
4497 * term.c (term_mouse_position): Likewise.
4498 * termhooks.h (struct input_event.timestamp): Likewise.
4499 (struct terminal.mouse_position_hook): Likewise.
4500 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4501 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4502 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4503 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4504 what it was before.
4505 * menu.h, termhooks.h: Include "systime.h", for Time.
4506
8e55734a
PE
4507 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4508 Don't assume that the difference between two unsigned long values
4509 can fit into an integer. At this point, we know button_down_time
4510 <= event->timestamp, so the difference must be nonnegative, so
4511 there's no need to cast the result if double-click-time is
4512 nonnegative, as it should be; check that it's nonnegative, just in
4513 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4514 apart (about 25 days). (Bug#8664)
8e55734a 4515
841f1b75 4516 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4517 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4518
3e26f69c
PE
4519 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4520 that always fit in int. Use a sentinel instead of a counter, to
4521 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4522 * frame.h (struct frame): Use int for menu_bar_items_used
4523 instead of EMACS_INT, since it always fits in int.
3e26f69c 4524
5cc152c0
PE
4525 * menu.c (grow_menu_items): Check for int overflow.
4526
d89eb65e
PE
4527 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4528
5235bd3e
PE
4529 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4530 Before, the code was not consistent. These values cannot exceed
4531 2**31 - 1 so there's no need to make them unsigned.
4532 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4533 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4534 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4535 as modifiers.
4536 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4537
bc827e23
PE
4538 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4539 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4540 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4541 presumably because the widths might not match.
4542
78eb494e
PE
4543 * window.c (size_window): Avoid needless test at loop start.
4544
04f2d78b
CB
45452011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4546
4547 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4548
d2fc7e3d 45492011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4550
4551 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4552
d2fc7e3d 45532011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4554
4555 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4556 `width' to `bar_area_x' and `bar_area_width', respectively.
4557 (x_scroll_run): Take account of fringe background extension.
4558
04f2d78b
CB
4559 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4560 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4561 `bar_area_width', respectively.
4562 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4563 background extension.
4564
79b70037
GM
45652011-05-10 Jim Meyering <meyering@redhat.com>
4566
4567 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4568
2f142cc5
JB
45692011-05-10 Juanma Barranquero <lekktu@gmail.com>
4570
4571 * image.c (Finit_image_library): Return t for built-in image types,
4572 like pbm and xbm. (Bug#8640)
4573
57679c86
AS
45742011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4575
4576 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4577
888c9e86
EZ
45782011-05-07 Eli Zaretskii <eliz@gnu.org>
4579
b0512a1d
EZ
4580 * w32console.c (Fset_screen_color): Doc fix.
4581 (Fget_screen_color): New function.
4582 (syms_of_ntterm): Defsubr it.
4583
7285dc67
EZ
4584 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4585 unlink the temporary file if Fcall_process didn't create it in the
4586 first place.
4587 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4588 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4589 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4590 cue to call_process_cleanup not to close that handle.
4591
4d3fcc8e
BK
45922011-05-07 Ben Key <bkey76@gmail.com>
4593
4594 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4595 one of two shell specific rules, either bootstrap-temacs-CMD or
4596 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4597 to the previous implementation of the bootstrap-temacs rule.
4598 The bootstrap-temacs-CMD rule is similar to the previous
4599 implementation of the bootstrap-temacs rule except that it
4600 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4601 variable.
4602
4603 These changes, along with some changes to nt/configure.bat,
4604 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4605 earlier fix to add support for --cflags and --ldflags options
4606 that include quotes so that it works whether make uses cmd or
4607 sh as the shell.
4608
b4289b64
MA
46092011-05-06 Michael Albinus <michael.albinus@gmx.de>
4610
4611 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4612 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4613 is a constant.
4614 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4615 a string. Handle both cases.
4616 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4617 (Fdbus_register_method): Use Qinvalid_function.
4618
af4c0e28
JB
46192011-05-06 Juanma Barranquero <lekktu@gmail.com>
4620
4621 * makefile.w32-in: Update dependencies.
4622 (LISP_H): Add inttypes.h and stdin.h.
4623 (PROCESS_H): Add unistd.h.
4624
c51453d9
EZ
46252011-05-06 Eli Zaretskii <eliz@gnu.org>
4626
4627 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4628 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4629
8ff0ac3c 46302011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4631
4c4b566b
PE
4632 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4633
aab2b9b5
PE
4634 * term.c (vfatal): Remove stray call to va_end.
4635 It's not needed and the C Standard doesn't allow it here anyway.
4636
c378da0b
PE
4637 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4638 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4639
288b08c7
PE
4640 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4641 bytes.
4642
e3601888
PE
4643 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4644
db6c0e74
PE
4645 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4646
dd5963ea
PE
4647 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4648
88c9450f
PE
4649 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4650
2f9442b8
PE
4651 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4652
c032b5f8
PE
4653 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4654 * charset.c (Fdefine_charset_internal): Don't initialize
4655 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4656 32-bit int (Bug#8600).
a108c10b
PE
4657
4658 * lread.c (read_integer): Be more consistent with string-to-number.
4659 Use string_to_number to do the actual conversion; this avoids
4660 rounding errors and fixes some other screwups. Without this fix,
4661 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4662 (digit_to_number): Move earlier, for benefit of read_integer.
4663 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4664 not a digit in any supported base. (Bug#8602)
a108c10b 4665
ad5f9eea
PE
4666 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4667
aec1708a
PE
4668 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4669 to match comment at start of function. This also removes a
4670 GCC warning about overflow in a 32+64-bit port.
4671
47be4ab5
PE
4672 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4673
371cac43
PE
4674 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4675 Reported by Stefan Monnier in
4676 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4677 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4678 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4679
d01a7826
PE
4680 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4681 (EMACS_UINTPTR): Likewise, with uintptr_t.
4682
7fd47d5c
PE
4683 * lisp.h: Prefer 64-bit EMACS_INT if available.
4684 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4685 on 32-bit hosts that have 64-bit int, so that they can access
4686 large files.
122b0c86
PE
4687 However, temporarily disable this change unless the temporary
4688 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4689
8727937b
PE
4690 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4691
8ac068ac
PE
4692 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4693 This removes an assumption that EMACS_INT and long are the same
4694 width as pointers. The assumption is true for Emacs porting targets
4695 now, but we want to make other targets possible.
4696 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4697 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4698 In the rest of the code, change types of integers that hold casted
4699 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4700 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4701 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4702 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4703 No need to cast type when ORing.
4704 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4705 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4706 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4707 assume EMACS_INT is the same width as char *.
4708 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4709 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4710 Remove no-longer-needed casts.
4711 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4712 (xg_tool_bar_help_callback, xg_make_tool_item):
4713 Use EMACS_INTPTR to hold an integer
4714 that will be cast to void *; this can avoid a GCC warning
4715 if EMACS_INT is not the same width as void *.
4716 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4717 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4718 (current_message_1, set_message_1):
4719 Use a local to convert to proper width without a cast.
4720 * xmenu.c (dialog_selection_callback): Likewise.
4721
ede49d71
PE
4722 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4723 Also, don't assume VALBITS / RAND_BITS is less than 5,
4724 and don't rely on undefined behavior when shifting a 1 left into
4725 the sign bit.
4726 * lisp.h (get_random): Change signature to match.
4727
2f30ecd0
PE
4728 * lread.c (hash_string): Use size_t, not int, for hash computation.
4729 Normally we prefer signed values; but hashing is special, because
4730 it's better to use unsigned division on hash table sizes so that
4731 the remainder is nonnegative. Also, size_t is the natural width
4732 for hashing into memory. The previous code used 'int', which doesn't
4733 retain enough info to hash well into very large tables.
4734 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4735
2a866e7b
PE
4736 * dbusbind.c: Don't possibly lose pointer info when converting.
4737 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4738 Use XPNTR rather than XHASH, so that the high-order bits of
4739 the pointer aren't lost when converting through void *.
4740
51639eac
PE
4741 * eval.c (Fautoload): Don't double-shift a pointer.
4742
92394119
PE
4743 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4744
dbdb9a7c
JB
47452011-05-06 Juanma Barranquero <lekktu@gmail.com>
4746
4747 * gnutls.c (DEF_GNUTLS_FN):
4748 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4749
db7a0b4f
AS
47502011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4751
4752 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4753 marker. (Bug#8610)
4754
f7ff1b0f 47552011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4756
4757 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4758 New version that can reserve upto 2GB of heap space.
4759
f7ff1b0f 47602011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4761
4762 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4763
639c109b
TZ
47642011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4765
4766 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4767 `gnutls_certificate_set_x509_key_file'.
4768
d2127135
JB
47692011-05-05 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4772 Update dependencies.
4773
e968f4f3
JB
47742011-05-04 Juanma Barranquero <lekktu@gmail.com>
4775
4776 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4777 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4778 Remove unused parameter `fildes'.
4779 * process.c (read_process_output, send_process): Don't pass it.
4780
84d358f0
JB
47812011-05-04 Juanma Barranquero <lekktu@gmail.com>
4782
4783 Fix previous change: the library cache is defined in w32.c.
4784 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4785 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4786
0898ca10
JB
47872011-05-04 Juanma Barranquero <lekktu@gmail.com>
4788
4789 Implement dynamic loading of GnuTLS on Windows.
4790
4791 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4792 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4793 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4794 Declare.
4795
4796 * gnutls.c (Qgnutls_dll): Define.
4797 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4798 (gnutls_*): Declare function pointers.
4799 (init_gnutls_functions): New function to initialize function pointers.
4800 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4801 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4802 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4803 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4804 (emacs_gnutls_write, emacs_gnutls_read)
4805 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4806 (Fgnutls_available_p): New function.
4807 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4808 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4809 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4810
4811 * image.c: Include w32.h.
4812 (Vimage_type_cache): Delete.
4813 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4814 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4815 (w32_delayed_load): Move to w32.c.
4816
4817 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4818
4819 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4820 (w32_delayed_load): Move from image.c. When loading a library, record
4821 its filename in the :loaded-from property of the library id.
4822 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4823 Initialize and staticpro them.
4824 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4825
4826 * process.c: Include lisp.h before w32.h, not after.
4827 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4828 instead of gnutls_record_check_pending.
4829
4830 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4831
ff4de4aa
TZ
48322011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4833
4834 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4835 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4836 as passed in.
4837
abe95abb
JD
48382011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4839
4840 * xterm.c (x_set_frame_alpha): Do not set property on anything
4841 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4842
e16e55d4
JB
48432011-05-02 Juanma Barranquero <lekktu@gmail.com>
4844
4845 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4846
bafcf6a5
JB
48472011-05-02 Juanma Barranquero <lekktu@gmail.com>
4848
4849 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4850 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4851 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4852 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4853 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4854 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4855 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4856 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4857 (Qgnutls_bootprop_callbacks_verify): Make static.
4858
e7a6747f
AS
48592011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4860
19ed11ba
AS
4861 * callproc.c: Indentation fixup.
4862
e7a6747f 4863 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4864 (wait_for_termination, interruptible_wait_for_termination):
4865 Move after wait_for_termination_1.
e7a6747f 4866
1ef14cb4
LMI
48672011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4868
4869 * sysdep.c (interruptible_wait_for_termination): New function
4870 which is like wait_for_termination, but allows keyboard
4871 interruptions.
4872
4873 * callproc.c (Fcall_process): Add (:file "file") as an option for
4874 the STDOUT buffer.
4875 (Fcall_process_region): Ditto.
4876
330d880c
EZ
48772011-04-30 Eli Zaretskii <eliz@gnu.org>
4878
8db90b73
EZ
4879 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4880 rather than `XVECTOR (FOO)->size'.
4881
330d880c
EZ
4882 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4883 inttypes.h, as a gnulib replacement is used if it not available in
4884 system headers.
4885
15cbd324
EZ
48862011-04-21 Eli Zaretskii <eliz@gnu.org>
4887
4888 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4889 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4890 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4891
4892 * coding.c (coding_alloc_by_realloc): Error out if destination
4893 will grow beyond MOST_POSITIVE_FIXNUM.
4894 (decode_coding_emacs_mule): Abort if there isn't enough place in
4895 charbuf for the composition carryover bytes. Reserve an extra
4896 space for up to 2 characters produced in a loop.
4897 (decode_coding_iso_2022): Abort if there isn't enough place in
4898 charbuf for the composition carryover bytes.
4899
49002011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4901
ae940cca
EZ
4902 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4903 aborting when %lld or %lll format is passed.
4904 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4905 %llo or %llx format is passed. (Bug#8545)
4906
03ab8921
EZ
4907 * window.c (window_scroll_line_based): Use a marker instead of
4908 simple variables to record original value of point. (Bug#7952)
4909
afda1437
EZ
4910 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4911 produced by %s or %c overflows available buffer space. (Bug#8545)
4912
f76dee0c
PE
49132011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4914
4915 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4916 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4917
fdc5744d
JB
49182011-04-28 Juanma Barranquero <lekktu@gmail.com>
4919
4920 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4921
638f053a
JB
49222011-04-28 Juanma Barranquero <lekktu@gmail.com>
4923
4924 * keyboard.c (Qdelayed_warnings_hook): Define.
4925 (command_loop_1): Run `delayed-warnings-hook'
4926 if Vdelayed_warnings_list is non-nil.
4927 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4928 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4929
d178f871
EZ
49302011-04-28 Eli Zaretskii <eliz@gnu.org>
4931
4932 * doprnt.c (doprnt): Don't return value smaller than the buffer
4933 size if the message was truncated. (Bug#8545).
4934
b124fd93
JB
49352011-04-28 Juanma Barranquero <lekktu@gmail.com>
4936
4937 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4938 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4939
e810457d
PE
49402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4943
ea51cceb
JB
49442011-04-27 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * makefile.w32-in: Update dependencies.
4947
94dcfacf
EZ
49482011-04-27 Eli Zaretskii <eliz@gnu.org>
4949
4950 Improve `doprnt' and its usage. (Bug#8545)
4951 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4952 `format_end'. Remove support for %l as a conversion specifier.
4953 Don't use xrealloc. Improve diagnostics when the %l size modifier
4954 is used. Update the commentary.
4955
4956 * eval.c (verror): Simplify calculation of size_t.
4957
4958 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4959 messages.
4960
f61f41d7
PE
49612011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4962
4963 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4964 change.
4965
96fb4434
PE
49662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4969 This makes this file independent of the recent pseudovector change.
4970
671875da 49712011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4972
69e9b5a3
PE
4973 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4974
b5f869a7 4975 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4976 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4977 Remove unused local.
c8926152 4978 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4979
841a1577 4980 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4981 GCC 4.6.0 optimizes based on type-based alias analysis.
4982 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4983 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4984 != &v->size, and therefore "v->size = 1; b->size = 2; return
4985 v->size;" must therefore return 1. This assumption is incorrect
4986 for Emacs, since it type-puns struct Lisp_Vector * with many other
4987 types. To fix this problem, this patch adds a new type struct
f904488f 4988 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4989 and pseudovectors, and helps optimizing compilers not get fooled
4990 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4991 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4992 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4993 the size member.
eab3844f
PE
4994 (XSETPVECTYPE): Rewrite in terms of new macro.
4995 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4996 This is a bit clearer, and further avoids the possibility of
4997 undesirable aliasing.
4998 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4999 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5000 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5001 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5002 (ASIZE): Now uses header.size rather than size.
5003 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5004 to avoid the hassle of writing XVECTOR (foo)->header.size.
5005 (struct vectorlike_header): New type.
eab3844f
PE
5006 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5007 object, to help avoid aliasing.
5008 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5009 (SUBRP): Likewise, since Lisp_Subr is a special case.
5010 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5011 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5012 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5013 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5014 changed to be "header.size" and "header.next".
5015 * buffer.h (struct buffer): Likewise.
5016 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5017 * frame.h (struct frame): Likewise.
5018 * process.h (struct Lisp_Process): Likewise.
5019 * termhooks.h (struct terminal): Likewise.
5020 * window.c (struct save_window_data, struct saved_window): Likewise.
5021 * window.h (struct window): Likewise.
5022 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5023 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5024 * buffer.c (init_buffer_once): Likewise.
5025 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5026 special case.
5027 * process.c (Fformat_network_address): Use local var for size,
5028 for brevity.
5029
0df1eac5
PE
5030 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5031
847ab9d1 5032 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5033 * data.c (atof): Remove decl; no longer used or needed.
5034 (digit_to_number): Move to lread.c.
5035 (Fstring_to_number): Use new string_to_number function, to be
5036 consistent with how the Lisp reader treats infinities and NaNs.
5037 Do not assume that floating-point numbers represent EMACS_INT
5038 without losing information; this is not true on most 64-bit hosts.
5039 Avoid double-rounding errors, by insisting on integers when
5040 parsing non-base-10 numbers, as the documentation specifies.
5041 * lisp.h (string_to_number): New decl, replacing ...
5042 (isfloat_string): Remove.
bc0a5c13 5043 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5044 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5045 appears to have been a coding error. Similarly, do not accept
5046 strings like +-1e0 as floating point numbers. Do not report
5047 overflow for integer overflows unless the base is not 10 which
5048 means we have no simple and reliable way to continue.
5049 Break out the floating-point parsing into a new
5050 function string_to_number, so that Fstring_to_number parses
5051 floating point numbers consistently with the Lisp reader.
04f2d78b 5052 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5053 (E_CHAR, EXP_INT): Remove, replacing with ...
5054 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5055 (string_to_number): New function, replacing isfloat_string.
5056 This function checks for valid syntax and produces the resulting
5057 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5058 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5059 so that overflow for non-base-10 numbers is reported only when
5060 there's no portable and simple way to convert to floating point.
452f4150 5061
67769ffc
PE
5062 * textprop.c (set_text_properties_1): Rewrite for clarity,
5063 and to avoid GCC warning about integer overflow.
5064
c20db43f
PE
5065 * intervals.h (struct interval): Use EMACS_INT for members
5066 where EMACS_UINT might cause problems. See
5067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5068 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5069 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5070 All uses changed.
37aa2f85
PE
5071 (offset_intervals): Tell GCC not to worry about length overflow
5072 when negating a negative length.
c20db43f 5073
2538aa2f
PE
5074 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5075 (overrun_check_free): Likewise.
5076
f2d3008d
PE
5077 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5078 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5079 word size.
5080
ec8df744
PE
5081 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5082 (gnutls_make_error): Rename local to avoid shadowing.
5083 (gnutls_emacs_global_deinit): ifdef out; not used.
5084 (Fgnutls_boot): Use const for pointer to readonly storage.
5085 Comment out unused local. Fix pointer signedness problems.
5086
640ee02d
PE
5087 * lread.c (openp): Don't stuff size_t into an 'int'.
5088 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5089 about possible signed overflow.
5090
6048fb2a
PE
5091 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5092 (GDK_KEY_g): Don't define if already defined.
5093 (xg_prepare_tooltip): Avoid pointer signedness problem.
5094 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5095
fa3c87e1
PE
5096 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5097 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5098
2172544b
PE
5099 * xfns.c (Fx_window_property): Simplify a bit,
5100 to make a bit faster and to avoid GCC 4.6.0 warning.
5101 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5102
9b821a21
PE
5103 * fns.c (internal_equal): Don't assume size_t fits in int.
5104
3c616cfa
PE
5105 * alloc.c (compact_small_strings): Tighten assertion a little.
5106
c2982e87
PE
5107 Replace pEd with more-general pI, and fix some printf arg casts.
5108 * lisp.h (pI): New macro, generalizing old pEd macro to other
5109 conversion specifiers. For example, use "...%"pI"d..." rather
5110 than "...%"pEd"...".
5111 (pEd): Remove. All uses replaced with similar uses of pI.
5112 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5113 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5114 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5115 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5116 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5117 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5118 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5119 64-bit hosts.
5120 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5121 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5122 * print.c (safe_debug_print, print_object): Likewise.
5123 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5124 to int.
6f04d126
PE
5125 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5126 avoiding the 0 flag, which is not portable.
c2982e87
PE
5127 * process.c (Fmake_network_process): Use pI to avoid cast.
5128 * region-cache.c (pp_cache): Likewise.
5129 * xdisp.c (decode_mode_spec): Likewise.
5130 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5131 behavior on 64-bit hosts with printf arg.
6f04d126 5132 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5133 (x_stop_queuing_selection_requests): Likewise.
5134 (x_get_window_property): Don't truncate byte count to an 'int'
5135 when tracing.
0b432f21 5136
5e073ec7
PE
5137 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5138 here, since it parses constructs like leading '-' and spaces,
5139 which are not wanted; and it overflows with large numbers.
5140 Instead, simply match F[0-9]+, which is what is wanted anyway.
5141
36372bf9
PE
5142 * alloc.c: Remove unportable assumptions about struct layout.
5143 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5144 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5145 (allocate_vectorlike, make_pure_vector): Use the new macros,
5146 plus offsetof, to remove unportable assumptions about struct layout.
5147 These assumptions hold on all porting targets that I know of, but
5148 they are not guaranteed, they're easy to remove, and removing them
5149 makes further changes easier.
5150
0b432f21
PE
5151 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5152 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5153 (string_overrun_cookie): Now const. Use initializers that
5154 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5155 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5156 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5157 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5158 multiple of sizeof (EMACS_INT); it need not be, if
5159 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5160 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5161
895009e1
JB
51622011-04-26 Juanma Barranquero <lekktu@gmail.com>
5163
5164 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5165
6a7a1b0b
TZ
51662011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5167
5168 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5169 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5170 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5171
841a1577 51722011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5173
5174 * lisp.h (Qdebug): List symbol.
895009e1 5175 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5176 * keyboard.c (debug-on-event): New variable.
5177 (handle_user_signal): Break into debugger when debug-on-event
5178 matches the current signal symbol.
5179
f2d3ba6f
DN
51802011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5181
5182 * alloc.c (check_sblock, check_string_bytes)
5183 (check_string_free_list): Convert to standard C.
5184
42ce4c63
TZ
51852011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5186
5187 * w32.c (emacs_gnutls_push): Fix typo.
5188
825cd63c
EZ
51892011-04-25 Eli Zaretskii <eliz@gnu.org>
5190
fb11d64d
EZ
5191 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5192 "cast to pointer from integer of different size".
5193
825cd63c
EZ
5194 Improve doprnt and its use in verror. (Bug#8545)
5195 * doprnt.c (doprnt): Document the set of format control sequences
5196 supported by the function. Use SAFE_ALLOCA instead of always
5197 using `alloca'.
5198
5199 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5200 is one byte too soon. Don't use xrealloc; instead xfree and
5201 xmalloc anew.
5202
e061a11b
TZ
52032011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5204
5205 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5206 callbacks stage.
5207
5208 * gnutls.c: Renamed global_initialized to
5209 gnutls_global_initialized. Added internals for the
5210 :verify-hostname-error, :verify-error, and :verify-flags
5211 parameters of `gnutls-boot' and documented those parameters in the
5212 docstring. Start callback support.
9173deec
JB
5213 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5214 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5215 on error. Return error code.
e061a11b
TZ
5216 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5217 (emacs_gnutls_read): Likewise.
5218 (Fgnutls_boot): Return handshake error code.
5219 (emacs_gnutls_handle_error): New function.
5220 (wsaerror_to_errno): Likewise.
5221
5222 * w32.h (emacs_gnutls_pull): Add prototype.
5223 (emacs_gnutls_push): Likewise.
5224
5225 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5226 (emacs_gnutls_push): Likewise.
5227
52282011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5229
5230 * process.c (wait_reading_process_output): Check if GnuTLS
5231 buffered some data internally if no FDs are set for TLS
5232 connections.
5233
5234 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5235 (LIBS): Link to USER_LIBS.
5236 ($(BLD)/gnutls.$(0)): New target.
5237
fa6996bc
EZ
52382011-04-24 Eli Zaretskii <eliz@gnu.org>
5239
eb35682e
EZ
5240 * xdisp.c (handle_single_display_spec): Rename the
5241 display_replaced_before_p argument into display_replaced_p, to
5242 make it consistent with the commentary. Fix typos in the
5243 commentary.
5244
e2ad650c
EZ
5245 * textprop.c (syms_of_textprop): Remove dead code.
5246 (copy_text_properties): Delete obsolete commentary about an
5247 interface that was deleted long ago. Fix typos in the description
5248 of arguments.
5249
1b2de274
EZ
5250 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5251 to changes in oldXMenu/XMenu.h from 2011-04-16.
5252 <menu_help_message, prev_menu_help_message>: Constify.
5253 (IT_menu_make_room): menu->help_text is now `const char **';
5254 adjust.
5255
5256 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5257 to changes in oldXMenu/XMenu.h from 2011-04-16.
5258 (struct XMenu): Declare `help_text' `const char **'.
5259
5260 * xfaces.c <Qunspecified>: Make extern again.
5261
5262 * syntax.c: Include sys/types.h before including regex.h, as
5263 required by Posix.
5264
762b15be
EZ
5265 * doc.c (get_doc_string): Improve the format passed to `error'.
5266
5267 * doprnt.c (doprnt): Improve commentary.
5268
5269 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5270
5271 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5272 them with etags.
5273
f1052e5d
EZ
5274 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5275 changes in globals.h immediately force recompilation.
762b15be
EZ
5276 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5277 $(CURDIR)/s/ms-w32.h.
5278 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5279
fa6996bc
EZ
5280 * character.c (Fchar_direction): Function deleted.
5281 (syms_of_character): Don't defsubr it.
5282 <char-direction-table>: Deleted.
5283
e6c3da20
EZ
52842011-04-23 Eli Zaretskii <eliz@gnu.org>
5285
5286 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5287 * doprnt.c: Include limits.h.
5288 (SIZE_MAX): New macro.
04f2d78b
CB
5289 (doprnt): Return a size_t value. 2nd arg is now size_t.
5290 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5291 Improve overflow protection. Support `l' modifier for integer
5292 conversions. Support %l conversion. Don't assume an EMACS_INT
5293 argument for integer conversions and for %c.
5294
5295 * lisp.h (doprnt): Restore prototype.
5296
5297 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5298 $(SRC)/character.h.
5299
5300 * Makefile.in (base_obj): Add back doprnt.o.
5301
5302 * deps.mk (doprnt.o): Add back prerequisites.
5303 (callint.o): Depend on character.h.
5304
5305 * eval.c (internal_lisp_condition_case): Include the handler
5306 representation in the error message.
5307 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5308 when breaking from the loop.
5309
5310 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5311
5312 * callint.c (Fcall_interactively): When displaying error message
5313 about invalid control letter, pass the character's codepoint, not
5314 a pointer to its multibyte form. Improve display of the character
5315 in octal and display also its hex code.
5316
5317 * character.c (char_string): Use %x to display the (unsigned)
5318 codepoint of an invalid character, to avoid displaying a bogus
5319 negative value.
5320
5321 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5322 `error', not SYMBOL_NAME itself.
5323
5324 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5325 character arguments to `error'.
5326
5327 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5328 to `error' in error message about FINAL_CHAR argument. Make sure
5329 FINAL_CHAR is a character, and use %c when it is passed as
5330 argument to `error'.
5331
4ffd0d6b 53322011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5333
5334 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5335
5336 * w32.c: Include <time.h>.
5337 (sys_localtime): New function.
5338
4ffd0d6b 53392011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5340
5341 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5342
4ffd0d6b 5343 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5344
4ffd0d6b 53452011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5346
4ffd0d6b
GM
5347 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5348 zombies (Bug#8467).
aac0c6e3 5349
04c56954
EZ
53502011-04-19 Eli Zaretskii <eliz@gnu.org>
5351
5352 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5353 gl_state.e_property when gl_state.object is Qt.
5354
5355 * insdel.c (make_gap_larger): Remove limitation of buffer size
5356 to <= INT_MAX.
5357
16a43933
CY
53582011-04-18 Chong Yidong <cyd@stupidchicken.com>
5359
5360 * xdisp.c (lookup_glyphless_char_display)
5361 (produce_glyphless_glyph): Handle cons cell entry in
5362 glyphless-char-display.
5363 (Vglyphless_char_display): Document it.
5364
5365 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5366 glyphless-char-display.
5367
4581706e
CY
53682011-04-17 Chong Yidong <cyd@stupidchicken.com>
5369
5370 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5371
5372 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5373
5374 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5375 definition for no-X builds.
5376
4887c6e2 53772011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5378
fd35b6f9
PE
5379 Static checks with GCC 4.6.0 and non-default toolkits.
5380
5c1ccb01
PE
5381 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5382
006c5daa
PE
5383 * process.c (keyboard_bit_set): Define only if SIGIO.
5384 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5385 (send_process): Repair possible setjmp clobbering.
5386
efc736d3
PE
5387 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5388
4e2fe2e6
PE
5389 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5390
f97334a2
PE
5391 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5392
4e75f29d
PE
5393 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5394 Define only if needed.
5395
90efadd1
PE
5396 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5397 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5398 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5399
3c647824
PE
5400 * dispextern.h (struct redisplay_interface): Rename param
5401 to avoid shadowing.
e264f262 5402 * termhooks.h (struct terminal): Likewise.
761383f4 5403 * xterm.c (xembed_send_message): Likewise.
3c647824 5404
b58c5c4a
PE
5405 * insdel.c (make_gap_smaller): Define only if
5406 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5407
cad59032
PE
5408 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5409 it.
5410
c339dc2e
PE
5411 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5412 so that we aren't warned about unused symbols.
5413
91a3e27b
PE
5414 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5415
399c71d3 5416 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5417
8ffc96f5
PE
5418 * xfns.c (x_real_positions): Mark locals as initialized.
5419
eef9bc79
PE
5420 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5421
098db9dd
PE
5422 * xterm.c: Fix problems found by static analysis with other toolkits.
5423 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5424 (x_dispatch_event): Declare static if USE_GTK, and
5425 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5426 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5427 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5428 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5429 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5430
eb18f6cc
PE
5431 * xmenu.c (menu_help_callback): Pointer type fixes.
5432 Use const pointers when pointing at readonly data. Avoid pointer
5433 signedness clashes.
5434 (FALSE): Remove unused macro.
5435 (update_frame_menubar): Remove unused decl.
5436
1fe72bf8
PE
5437 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5438
60d9e1db
PE
5439 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5440 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5441 (single_menu_item): Rename local to avoid shadowing.
5442
39261c26
PE
5443 * keyboard.c (make_lispy_event): Remove unused local var.
5444
018c5e19
PE
5445 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5446 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5447
63d2b86e
PE
5448 * bitmaps: Change bitmaps from unsigned char back to the X11
5449 compatible char. Avoid the old compiler warnings about
5450 out-of-range initializers by using, for example, '\xab' rather
5451 than 0xab.
5452
aefd87e1
PE
5453 * xgselect.c (xgselect_initialize): Check vs interface
5454 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5455
bf501fb9
PE
5456 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5457
e9829fdf
PE
5458 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5459 to read-only memory.
5460
1086c095
PE
5461 * fns.c (vector): Remove; this old hack is no longer needed.
5462
2baccd04 5463 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5464 Remove unused var.
dde42981 5465 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5466
72391843 5467 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5468
436c16df 5469 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5470 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5471 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5472
92bb796d 5473 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5474 (x_term_init): Remove local to avoid shadowing.
92bb796d 5475
764430a3 5476 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5477
5478 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5479 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5480
d1dfb56c
EZ
54812011-04-16 Eli Zaretskii <eliz@gnu.org>
5482
c4354cb4
EZ
5483 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5484
d1dfb56c
EZ
5485 Fix regex.c, syntax.c and friends for buffers > 2GB.
5486 * syntax.h (struct gl_state_s): Declare character position members
5487 EMACS_INT.
5488
5489 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5490
04f2d78b
CB
5491 * textprop.c (verify_interval_modification, interval_of):
5492 Declare arguments EMACS_INT.
d1dfb56c
EZ
5493
5494 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5495 EMACS_INT.
5496
5497 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5498
5499 * indent.c (Fvertical_motion): Local variable it_start is now
5500 EMACS_INT.
5501
5502 * regex.c (re_match, re_match_2, re_match_2_internal)
5503 (bcmp_translate, regcomp, regexec, print_double_string)
5504 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5505 (re_compile_pattern, re_exec): Declare arguments and local
5506 variables `size_t' and `ssize_t' and return values `regoff_t', as
5507 appropriate.
5508 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5509 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5510 <compile_stack_type>: `size' and `avail' are now `size_t'.
5511
5512 * regex.h <regoff_t>: Use ssize_t, not int.
5513 (re_search, re_search_2, re_match, re_match_2): Arguments that
5514 specify buffer/string position and length are now ssize_t and
5515 size_t. Return type is regoff_t.
5516
613052cd
BK
55172011-04-16 Ben Key <bkey76@gmail.com>
5518
5519 * nsfont.m: Fixed bugs in ns_get_family and
5520 ns_descriptor_to_entity that were caused by using free to
5521 deallocate memory blocks that were allocated by xmalloc (via
5522 xstrdup). This caused Emacs to crash when compiled with
5523 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5524 --enable-checking=xmallocoverrun). xfree is now used to
5525 deallocate these memory blocks.
5526
4170f62f 55272011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5528
71b41406
PE
5529 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5530
9587a89d
PE
5531 emacs_write: Accept and return EMACS_INT for sizes.
5532 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5533 et seq.
5534 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5535 Accept and return EMACS_INT.
5536 (emacs_gnutls_write): Return the number of bytes written on
5537 partial writes.
5538 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5539 (emacs_read, emacs_write): Remove check for negative size, as the
5540 Emacs source code has been audited now.
9587a89d
PE
5541 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5542 (emacs_read, emacs_write): Use it.
273a5f82
PE
5543 * process.c (send_process): Adjust to the new signatures of
5544 emacs_write and emacs_gnutls_write. Do not attempt to store
5545 a byte offset into an 'int'; it might overflow.
9587a89d 5546 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5547
3e047f51
PE
5548 * sound.c: Don't assume sizes fit in 'int'.
5549 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5550 Return EMACS_INT, not int.
3e047f51 5551 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5552 Accept EMACS_INT, not int.
5553 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5554 record read return values.
5555
cc39a9db
BK
55562011-04-15 Ben Key <bkey76@gmail.com>
5557
c9d0ec6d
JB
5558 * keyboard.c (Qundefined): Don't declare static since it is used
5559 in nsfns.m.
5560 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5561 static since they are used in nsfont.m.
cc39a9db 5562
6c60eb9f
SM
55632011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5564
5565 * process.c (Qprocessp): Don't declare static.
5566 * lisp.h (Qprocessp): Declare again.
5567
7990b61a
JB
55682011-04-15 Juanma Barranquero <lekktu@gmail.com>
5569
5570 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5571
5d4cb038
PE
55722011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5573
8bd7b830 5574 Improve C-level modularity by making more things 'static'.
cd64ea1d 5575
e3b27b31
PE
5576 Don't publish debugger-only interfaces to other modules.
5577 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5578 (verify_bytepos, count_markers): Move decls to the only modules
5579 that need them.
5580 * region-cache.h (pp_cache): Likewise.
5581 * window.h (check_all_windows): Likewise.
5582 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5583
5d4cb038
PE
5584 * sysdep.c (croak): Now static, if
5585 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5586 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5587
5588 * alloc.c (refill_memory_reserve): Now static if
5589 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5590 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5591
e87b6180
PE
5592 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5593 Define only if USE_LUCID.
5594
ac64929e
PE
5595 * xrdb.c (x_customization_string, x_rm_string): Now static.
5596
6f37259d
PE
5597 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5598 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5599
1683e3ab
PE
5600 * xdisp.c (draw_row_with_mouse_face): Now static.
5601 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5602
de9c2632
PE
5603 * window.h (check_all_windows): Mark externally visible.
5604
2b96acb7
PE
5605 * window.c (window_deletion_count): Now static.
5606
5607 * undo.c: Make symbols static if they're not exported.
5608 (last_undo_buffer, last_boundary_position, pending_boundary):
5609 Now static.
5610
50436f33
PE
5611 * textprop.c (interval_insert_behind_hooks): Now static.
5612 (interval_insert_in_front_hooks): Likewise.
5613
64520e5c
PE
5614 * term.c: Make symbols static if they're not exported.
5615 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5616 (max_frame_lines, tty_set_terminal_modes):
5617 (tty_reset_terminal_modes, tty_turn_off_highlight):
5618 (get_tty_terminal): Now static.
5619 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5620 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5621 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5622 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5623 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5624
1fa53021
PE
5625 * sysdep.c: Make symbols static if they're not exported.
5626 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5627 Now static.
5628 (sigprocmask_set, full_mask): Remove; unused.
5629 (wait_debugging): Mark as visible.
5630 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5631 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5632
d4b43b22
PE
5633 * syntax.c (syntax_temp): Define only if !__GNUC__.
5634
b7c513d0
PE
5635 * sound.c (current_sound_device, current_sound): Now static.
5636
989b29ad
PE
5637 * search.c (searchbufs, searchbuf_head): Now static.
5638
13a55a78
PE
5639 * scroll.c (scroll_cost): Remove; unused.
5640 * dispextern.h (scroll_cost): Remove decl.
5641
de68a1fc
PE
5642 * region-cache.h (pp_cache): Mark as externally visible.
5643
40ccffa6
PE
5644 * process.c: Make symbols static if they're not exported.
5645 (process_tick, update_tick, create_process, chan_process):
5646 (Vprocess_alist, proc_buffered_char, datagram_access):
5647 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5648 (deactivate_process): Mark defn as static, as well as decl.
5649 * lisp.h (create_process): Remove decl.
5650 * process.h (chan_process, Vprocess_alist): Remove decls.
5651
ad64fc97
PE
5652 * print.c: Make symbols static if they're not exported.
5653 (print_depth, new_backquote_output, being_printed, print_buffer):
5654 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5655 (print_interval, print_number_index, initial_stderr_stream):
5656 Now static.
5657 * lisp.h (Fprinc): Remove decl.
5658 (debug_output_compilation_hack): Mark as externally visible.
5659
adddb265
PE
5660 * sysdep.c (croak): Move decl from here to syssignal.h.
5661 * syssignal.h (croak): Put it here, so the API can be checked when
5662 'croak' is called from dissociate_if_controlling_tty.
5663
1717ede2
PE
5664 * minibuf.c: Make symbols static if they're not exported.
5665 (minibuf_save_list, choose_minibuf_frame): Now static.
5666 * lisp.h (choose_minibuf_frame): Remove decl.
5667
fa5fb2bc
PE
5668 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5669
1e3890d1
PE
5670 * lread.c: Make symbols static if they're not exported.
5671 (read_objects, initial_obarray, oblookup_last_bucket_number):
5672 Now static.
5673 (make_symbol): Remove; unused.
5674 * lisp.h (initial_obarray, make_symbol): Remove decls.
5675
8a1414fa
PE
5676 * keyboard.c: Make symbols static if they're not exported.
5677 (single_kboard, recent_keys_index, total_keys, recent_keys):
5678 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5679 (this_single_command_key_start, echoing, last_auto_save):
5680 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5681 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5682 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5683 (Vlispy_mouse_stem, double_click_count):
5684 Now static.
5685 (force_auto_save_soon): Define only if SIGDANGER.
5686 (ignore_mouse_drag_p): Now static if
5687 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5688 (print_help): Remove; unused.
5689 (stop_character, last_timer_event): Mark as externally visible.
5690 * keyboard.h (ignore_mouse_drag_p): Declare only if
5691 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5692 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5693 * lisp.h (echoing): Remove decl.
5694 (force_auto_save_soon): Declare only if SIGDANGER.
5695 * xdisp.c (redisplay_window): Simplify code, to make it more
5696 obvious that ignore_mouse_drag_p is not accessed if !defined
5697 USE_GTK && !defined HAVE_NS.
5698
93ea6e8f
PE
5699 * intervals.c: Make symbols static if they're not exported.
5700 (merge_properties_sticky, merge_interval_right, delete_interval):
5701 Now static.
5702 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5703
77382fcc
PE
5704 * insdel.c: Make symbols static if they're not exported.
5705 However, leave prepare_to_modify_buffer alone. It's never
5706 called from outside this function, but that appears to be a bug.
5707 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5708 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5709 (adjust_after_replace_noundo): Remove; unused.
5710 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5711 (signal_before_change): Remove decls.
77382fcc 5712
9306c32e
PE
5713 * indent.c (val_compute_motion, val_vmotion): Now static.
5714
cd44d2eb
PE
5715 * image.c: Make symbols static if they're not exported.
5716 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5717 if USE_GTK.
5718 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5719 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5720
ad9a7a06
PE
5721 * fringe.c (standard_bitmaps): Now static.
5722 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5723
81626931
PE
5724 * frame.c: Make symbols static if they're not exported.
5725 (x_report_frame_params, make_terminal_frame): Now static.
5726 (get_frame_param): Now static, unless HAVE_NS.
5727 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5728 (x_get_resource_string): Remove; not used.
5729 * frame.h (make_terminal_frame, x_report_frame_params):
5730 (x_get_resource_string); Remove decls.
5731 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5732 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5733
239f9db9
PE
5734 * font.c, fontset.c: Make symbols static if they're not exported.
5735 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5736 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5737 * font.c (font_close_object): Now static.
5738 * font.h (font_close_object): Remove.
5739 * fontset.c (FONTSET_OBJLIST): Remove.
5740 (free_realized_fontset) #if-0 the body, which does nothing.
5741 (face_suitable_for_char_p): #if-0, as it's never called.
5742 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5743 * xfaces.c (face_at_string_position):
5744 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5745 since 0 is always ASCII.
5746
dfcf3579
PE
5747 * fns.c (weak_hash_tables): Now static.
5748
5045092b
PE
5749 * fileio.c: Make symbols static if they're not exported.
5750 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5751 (Vwrite_region_annotation_buffers): Now static.
5752
57a96f5c
PE
5753 * eval.c: Make symbols static if they're not exported.
5754 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5755 * lisp.h (backtrace_list): Remove decl.
5756
35f08c38
PE
5757 * emacs.c: Make symbols static if they're not exported.
5758 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5759 (fatal_error_code, fatal_error_signal_hook, standard_args):
5760 Now static.
5761 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5762 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5763 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5764 * lisp.h (fatal_error_signal_hook): Remove decl.
5765 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5766
f44bd759
PE
5767 * editfns.c: Move a (normally-unused) function to its only use.
5768 * editfns.c, lisp.h (get_operating_system_release): Remove.
5769 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5770 worth the hassle of breaking this out.
5771
b532497d
PE
5772 * xterm.c: Make symbols static if they're not exported.
5773 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5774 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5775 (x_destroy_window, x_delete_display):
5776 Now static.
5777 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5778 (x_mouse_leave): Remove; unused.
5779 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5780 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5781 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5782 Remove decls.
5783 (x_mouse_leave): Declare only if WINDOWSNT.
5784 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5785 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5786 USE_X_TOOLKIT.
5787
1675728f
PE
5788 * ftxfont.c: Make symbols static if they're not exported.
5789 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5790 HAVE_FREETYPE.
5791 * font.h (ftxfont_driver): Likewise.
5792
e4cebfca
PE
5793 * xfns.c: Make symbols static if they're not exported.
5794 (x_last_font_name, x_display_info_for_name):
5795 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5796 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5797 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5798 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5799 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5800 (last_show_tip_args): Now static.
5801 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5802 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5803 (x_screen_planes): Remove; unused.
5804 * dispextern.h (x_screen_planes): Remove decl.
5805
5bf46f05
PE
5806 * dispnew.c: Make symbols static if they're not exported.
5807 * dispextern.h (redraw_garbaged_frames, scrolling):
5808 (increment_row_positions): Remove.
5809 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5810 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5811 Now static.
5812 (redraw_garbaged_frames): Remove; unused.
5813
435f4c28
PE
5814 * xfaces.c: Make symbols static if they're not exported.
5815 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5816 Remove decls.
5817 * xterm.h (defined_color): Remove decls.
5818 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5819 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5820 (menu_face_changed_default, defined_color, free_realized_face):
5821 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5822 (ascii_face_of_lisp_face): Remove; unused.
5823
8524aef3
PE
5824 * xdisp.c: Make symbols static if they're not exported.
5825 * dispextern.h (scratch_glyph_row, window_box_edges):
5826 (glyph_to_pixel_coords, set_cursor_from_row):
5827 (get_next_display_element, set_iterator_to_next):
5828 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5829 (show_mouse_face): Remove decls
5830 * frame.h (message_buf_print): Likewise.
5831 * lisp.h (pop_message, set_message, check_point_in_composition):
5832 Likewise.
5833 * xterm.h (set_vertical_scroll_bar): Likewise.
5834 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5835 (message_buf_print, scratch_glyph_row, displayed_buffer):
5836 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5837 (get_next_display_element, show_mouse_face, window_box_edges):
5838 (frame_to_window_pixel_xy, check_point_in_composition):
5839 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5840 (glyph_to_pixel_coords): Remove; unused.
5841
16390cd2
PE
5842 * dired.c (file_name_completion): Now static.
5843
5844 * dbusbind.c (xd_in_read_queued_messages): Now static.
5845
a25f4dfa
PE
5846 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5847 * data.c (circular_list_error): Remove.
5848
14a9c8df
PE
5849 * commands.h (last_point_position, last_point_position_buffer):
5850 (last_point_position_window): Remove decls.
5851 * keyboard.c: Make these variables static.
5852
04f2d78b
CB
5853 * coding.h (coding, code_convert_region, encode_coding_gap):
5854 Remove decls.
74ab6df5
PE
5855 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5856 (iso_code_class, detect_coding, code_convert_region): Now static.
5857 (encode_coding_gap): Remove; unused.
5858
38dfbee1
PE
5859 * chartab.c (chartab_chars, chartab_bits): Now static.
5860
a2cb4e63
PE
5861 * charset.h (charset_iso_8859_1): Remove decl.
5862 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5863 Now static.
5864
127198fd
PE
5865 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5866 * ccl.c (Vccl_program_table): Now static.
5867 (check_ccl_update): Remove; unused.
5868
d85b608f
PE
5869 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5870 * category.h: ... from here.
5871 * category.c (check_category_table, set_category_set): Now static.
5872
31cd66f3
PE
5873 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5874 * lisp.h: Remove these decls.
5875
c358e587
PE
5876 * buffer.c (buffer_count): Remove unused var.
5877
e78aecca
PE
5878 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5879 so that it's not optimized away.
5880 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5881 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5882 exported only to the debugger.
5883
e192d7d3 5884 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5885 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5886
92470028
PE
5887 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5888 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5889 was inaccessible from Lisp.
5890 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5891 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5892
244ed907
PE
5893 alloc.c: Import and export fewer symbols, and remove unused items.
5894 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5895 is defined.
5896 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5897 it's not optimized away by whole-program optimization.
5898 (message_enable_multibyte, free_misc): Remove.
5899 (catchlist, handlerlist, mark_backtrace):
5900 Declare only if BYTE_MARK_STACK.
5901 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5902 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5903 (message_enable_multibyte): Remove decl.
5904 (free_misc, interval_free_list, float_block, float_block_index):
5905 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5906 (cons_free_list, last_marked_index):
5907 Now static.
5908 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5909 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5910 (mark_backtrace): Define only if BYTE_MARK_STACK.
5911 * xdisp.c (message_enable_multibyte): Now static.
5912
61c2b50e 5913 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5914 This makes it easier for human readers (and static analyzers)
5915 to see whether these variables are used from other modules.
5916 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5917 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5918 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5919 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5920 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5921 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5922 * xmenu.c, xselect.c:
5923 Declare Q* vars static if they are not used in other modules.
5924 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5925 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5926 Remove decls of unexported vars.
5927 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5928
95c82688
PE
5929 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5930
16a97296
PE
5931 Make Emacs functions such as Fatom 'static' by default.
5932 This makes it easier for human readers (and static analyzers)
5933 to see whether these functions can be called from other modules.
5934 DEFUN now defines a static function. To make the function external
5935 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5936 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5937 (Finit_image_library):
16a97296
PE
5938 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5939 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5940 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5941 Remove decls, since these functions are now static.
5942 (Funintern, Fget_internal_run_time): New decls, since these functions
5943 were already external.
95c82688 5944
16a97296
PE
5945 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5946 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5947 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5948 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5949 * keyboard.c, keymap.c, lread.c:
5950 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5951 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5952 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5953 Mark functions with DEFUE instead of DEFUN,
5954 if they are used in other modules.
5955 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5956 decls for now-static functions.
5957 * buffer.h (Fdelete_overlay): Remove decl.
5958 * callproc.c (Fgetenv_internal): Mark as internal.
5959 * composite.c (Fremove_list_of_text_properties): Remove decl.
5960 (Fcomposition_get_gstring): New forward static decl.
5961 * composite.h (Fcomposite_get_gstring): Remove decl.
5962 * dired.c (Ffile_attributes): New forward static decl.
5963 * doc.c (Fdocumntation_property): New forward static decl.
5964 * eval.c (Ffetch_bytecode): New forward static decl.
5965 (Funintern): Remove extern decl; now in .h file where it belongs.
5966 * fileio.c (Fmake_symbolic_link): New forward static decl.
5967 * image.c (Finit_image_library): New forward static decl.
5968 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5969 * intervals.h (Fprevious_property_change):
5970 (Fremove_list_of_text_properties): Remove decls.
5971 * keyboard.c (Fthis_command_keys): Remove decl.
5972 (Fcommand_execute): New forward static decl.
5973 * keymap.c (Flookup_key): New forward static decl.
5974 (Fcopy_keymap): Now static.
5975 * keymap.h (Flookup_key): Remove decl.
5976 * process.c (Fget_process): New forward static decl.
5977 (Fprocess_datagram_address): Mark as internal.
5978 * syntax.c (Fsyntax_table_p): New forward static decl.
5979 (skip_chars): Remove duplicate decl.
5980 * textprop.c (Fprevious_property_change): New forward static decl.
5981 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5982 Now internal.
5983 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5984 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5985
785bbd42
PE
5986 * editfns.c (Fformat): Remove unreachable code.
5987
8b913b57
AS
59882011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5989
5990 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5991 change. (Bug#8496)
5992
a6744a35
EZ
59932011-04-13 Eli Zaretskii <eliz@gnu.org>
5994
5995 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5996 when at ZV. (Bug#8487)
5997
e7974947
AS
59982011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5999
baad03f0
AS
6000 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6001 (Bug#8437)
6002 * keyboard.c (parse_tool_bar_item): Likewise.
6003 * sound.c (sound_cleanup, alsa_close): Likewise.
6004 * termcap.c (tgetent): Likewise.
6005 * xfns.c (x_default_font_parameter): Likewise.
6006 * xsettings.c (read_and_apply_settings): Likewise.
6007
e7974947
AS
6008 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6009 (overrun_check_free): Protoize.
6010
28272684
PE
60112011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6012
6013 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6014 since callers should never pass a negative size.
6015 Change the signature to match that of plain 'read' and 'write'; see
6016 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6017 * lisp.h: Update prototypes of emacs_write and emacs_read.
6018
11997c76
EZ
60192011-04-11 Eli Zaretskii <eliz@gnu.org>
6020
6021 * xdisp.c (redisplay_window): Don't try to determine the character
6022 position of the scroll margin if the window start point w->startp
e896f03c 6023 is outside the buffer's accessible region. (Bug#8468)
11997c76 6024
8a2cbd72
EZ
60252011-04-10 Eli Zaretskii <eliz@gnu.org>
6026
6027 Fix write-region and its subroutines for buffers > 2GB.
6028 * fileio.c (a_write, e_write): Modify declaration of arguments and
6029 local variables to support buffers larger than 2GB.
6030 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6031
6032 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6033 argument, local variables, and return value.
6034
6035 * lisp.h: Update prototypes of emacs_write and emacs_read.
6036
6037 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6038
4073e537 60392011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6040
1ebfdcb6
PE
6041 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6042
b2ded58d
PE
6043 Fix more problems found by GCC 4.6.0's static checks.
6044
7d66342c
PE
6045 * xdisp.c (vmessage): Use a better test for character truncation.
6046
bbf47d44
PE
6047 * charset.c (load_charset_map): <, not <=, for optimization,
6048 and to avoid potential problems with integer overflow.
9248994d 6049 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6050 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6051 * editfns.c (Fformat): Likewise.
1e69125e 6052 * syntax.c (skip_chars): Likewise.
3befa583 6053
e3019616
PE
6054 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6055 This also lets GCC 4.6.0 generate slightly better loop code.
6056
becfa255
PE
6057 * callint.c (Fcall_interactively): <, not <=, for optimization.
6058 (Fcall_interactively): Count the number of arguments produced,
6059 not the number of arguments given. This is simpler and lets GCC
6060 4.6.0 generate slightly better code.
6061
dae0cd48
PE
6062 * ftfont.c: Distingish more carefully between FcChar8 and char.
6063 The previous code passed unsigned char * to a functions like
6064 strlen and xstrcasecmp that expect char *, which does not
6065 conform to the C standard.
6066 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6067 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6068 char * when the C standard requires it.
6069
76032d70
PE
6070 * keyboard.c (read_char): Remove unused var.
6071
eb3f1cc8
PE
6072 * eval.c: Port to Windows vsnprintf (Bug#8435).
6073 Include <limits.h>.
6074 (SIZE_MAX): Define if the headers do not.
6075 (verror): Do not give up if vsnprintf returns a negative count.
6076 Instead, grow the buffer. This ports to Windows vsnprintf, which
6077 does not conform to C99. Problem reported by Eli Zaretskii.
6078 Also, simplify the allocation scheme, by avoiding the need for
6079 calling realloc, and removing the ALLOCATED variable.
6080
70476b54
PE
6081 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6082
12020a9e
PE
6083 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6084 But keep the doprint source code for now, as we might revamp it
6085 and use it again (Bug#8435).
ea6c7ae6
PE
6086 * lisp.h (doprnt): Remove.
6087 * Makefile.in (base_obj): Remove doprnt.o.
6088 * deps.mk (doprnt.o): Remove.
6089
5fdb398c
PE
6090 error: Print 32- and 64-bit integers portably (Bug#8435).
6091 Without this change, on typical 64-bit hosts error ("...%d...", N)
6092 was used to print both 32- and 64-bit integers N, which relied on
6093 undefined behavior.
6094 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6095 New macro.
6096 * lisp.h (error, verror): Mark as printf-like functions.
6097 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6098 Report overflow in size calculations when allocating printf buffer.
6099 Do not truncate output string at its first null byte.
6100 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6101 Truncate the output at a character boundary, since vsnprintf does not
6102 do that.
6103 * charset.c (check_iso_charset_parameter): Convert internal
6104 character to string before calling 'error', since %c now has the
6105 printf meaning.
6106 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6107 overflow when computing char to be passed to 'error'. Do not
6108 pass Lisp_Object to 'error'; pass the integer instead.
6109 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6110 formatted with plain %d.
6111
b189fa66
PE
6112 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6113
bff87ef0
PE
6114 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6115
7e2cac20
PE
6116 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6117
ce4d90b5
PE
6118 * xterm.c (x_catch_errors): Remove duplicate declaration.
6119
266c9547
PE
6120 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6121
79c49ad2
PE
6122 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6123
368f4090
JM
61242011-04-10 Jim Meyering <meyering@redhat.com>
6125
6126 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6127 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6128 return ssize_t not "int", and use size_t as the buffer length.
6129 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6130 * gnutls.h: Update declarations.
6131 * process.c (read_process_output): Use ssize_t, to match.
6132 (send_process): Likewise.
6133
a32d4040
CY
61342011-04-09 Chong Yidong <cyd@stupidchicken.com>
6135
6136 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6137
8546720e 61382011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6139
04f2d78b
CB
6140 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6141 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6142
8546720e
GM
6143 * xterm.c (handle_one_xevent):
6144 * xmenu.c (create_and_show_popup_menu):
6145 * xselect.c (x_decline_selection_request)
6146 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6147
0a2f5c1a 61482011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6149
6150 Fix some uses of `int' instead of EMACS_INT.
6151 * search.c (string_match_1, fast_string_match)
6152 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6153 (scan_buffer, find_next_newline_no_quit)
6154 (find_before_next_newline, search_command, Freplace_match)
6155 (Fmatch_data): Make some `int' variables be EMACS_INT.
6156
6157 * xdisp.c (display_count_lines): 3rd argument and return value now
6158 EMACS_INT. All callers changed.
6159 (pint2hrstr): Last argument is now EMACS_INT.
6160
6161 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6162 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6163 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6164 (decode_coding_utf_16, decode_coding_emacs_mule)
6165 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6166 (decode_coding_ccl, decode_coding_charset)
6167 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6168 (decode_coding_iso_2022, decode_coding_emacs_mule)
6169 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6170 <char_offset, last_offset>: Declare EMACS_INT.
6171 (encode_coding_utf_8, encode_coding_utf_16)
6172 (encode_coding_emacs_mule, encode_invocation_designation)
6173 (encode_designation_at_bol, encode_coding_iso_2022)
6174 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6175 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6176 Declare EMACS_INT.
6177 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6178 (encode_invocation_designation): Last argument P_NCHARS is now
6179 EMACS_INT.
6180 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6181 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6182
6183 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6184 All users changed.
6185
6186 * ccl.c (Fccl_execute_on_string): Declare some variables
6187 EMACS_INT.
6188
8546720e 61892011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6190
6191 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6192
4e19a977
CS
61932011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6194
6195 * process.c (Fformat_network_address): Doc fix.
6196
87302331
R
61972011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6198
6199 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6200
cbb59342
CY
62012011-04-08 Chong Yidong <cyd@stupidchicken.com>
6202
6203 * keyboard.c (read_char): Call Lisp function help-form-show,
6204 instead of using internal_with_output_to_temp_buffer.
6205 (Qhelp_form_show): New var.
e0d38eeb 6206 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6207
6208 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6209
6210 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6211
e67a13ab
CY
62122011-04-06 Chong Yidong <cyd@stupidchicken.com>
6213
04f2d78b
CB
6214 * process.c (Flist_processes): Remove to Lisp.
6215 (list_processes_1): Delete.
e67a13ab 6216
973f782d
EZ
62172011-04-06 Eli Zaretskii <eliz@gnu.org>
6218
7c106b1e
EZ
6219 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6220
973f782d
EZ
6221 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6222
41cf7d1a 62232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6224
ca23cc88
PE
6225 Fix more problems found by GCC 4.6.0's static checks.
6226
f390e2d5
PE
6227 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6228
42eea0d0
PE
6229 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6230
b69769da 6231 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6232
f9541e84
PE
6233 * xdisp.c (vmessage): Mark as a printf-like function.
6234
13841b55
PE
6235 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6236
c136c10f
PE
6237 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6238
5e2d4a30
PE
6239 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6240 printf-like functions.
6241 (tiff_load): Add casts to remove these marks before passing them
6242 to system-supplied API.
6243
583f48b9
PE
6244 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6245
b25d760e
PE
6246 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6247 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6248 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6249 directly, rather than having caller test rule sign. This avoids
6250 some unnecessary tests.
6251 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6252 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6253 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6254
bc7b6697 6255 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6256 (xfont_open): Avoid unnecessary tests.
bc7b6697 6257
27ccc379
PE
6258 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6259
dcd5c89a
PE
6260 * composite.h, composite.c (composition_gstring_put_cache):
6261 Use EMACS_INT, not int, for length.
6262
b13a45c6
PE
6263 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6264 breaking out part of COMPOSITION_DECODE_RULE.
6265 (COMPOSITION_DECODE_RULE): Use it.
6266 * composite.c (get_composition_id): Remove unused local vars,
6267 by using the new macro.
6268
1e792e4d
PE
6269 * textprop.c (set_text_properties_1): Change while to do-while,
6270 since the condition is always true at first.
6271
dc6c6455 6272 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6273 (interval_deletion_adjustment): Return unsigned value.
6274 All uses changed.
dc6c6455 6275
aba7731a
PE
6276 * process.c (list_processes_1, create_pty, read_process_output):
6277 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6278 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6279 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6280 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6281 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6282
fdfc4bf3
PE
6283 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6284
fca8fe46 6285 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6286 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6287
06a0259a 6288 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6289 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6290 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6291
e7b9e80f
PE
6292 * print.c (print_error_message): Avoid int overflow.
6293
56201685
PE
6294 * font.c (font_list_entities): Redo for clarity,
6295 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6296
78834453 6297 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6298 (font_score): Avoid potential overflow in diff calculation.
78834453 6299
0bc0b309 6300 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6301 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6302
e610eaca
PE
6303 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6304
b895abce
PE
6305 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6306 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6307 can always succeed if overflow has undefined behavior.
6308
1f1d9321 6309 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6310 (wordify): Omit three unnecessary tests.
1f1d9321 6311
c59478bc
PE
6312 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6313 All callers changed. This avoids the need for an unused var.
6314
79b73827
PE
6315 * casefiddle.c (casify_region): Remove var that is set but not used.
6316
a4db5dfe
PE
6317 * dired.c (file_name_completion): Remove var that is set but not used.
6318
43aae36e
PE
6319 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6320
2a47c44d 6321 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6322 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6323
a37c69bf
PE
6324 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6325 Check for integer overflow on size calculations.
6326
328ab8e7
PE
6327 * buffer.c (Fprevious_overlay_change): Remove var that is set
6328 but not used.
6329
e5a2a5cb
PE
6330 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6331 Remove vars that are set but not used.
8d84a6eb 6332 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6333 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6334
a60e5f68
PE
6335 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6336
f661cb61 6337 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6338 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6339
f0397f5a
PE
6340 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6341 that are set but not used.
6342
8664db06 6343 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6344 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6345
6abdaa4a
PE
6346 * xselect.c (x_get_local_selection, x_handle_property_notify):
6347 Remove vars that are set but not used.
6348
0ce7538d 6349 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6350 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6351
9ae848fc
PE
6352 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6353 Remove var that is set but not used.
0b918413
PE
6354 (scroll_bar_windows_size): Now size_t, not int.
6355 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6356 Check for overflow.
9ae848fc 6357
a5a62657
PE
6358 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6359 (map_tty_color) [!defined MSDOS]: Likewise.
6360
5c5cdd39
PE
6361 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6362
66ebf983
PE
6363 * coding.c: Remove vars that are set but not used.
6364 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6365 All callers changed.
6366 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6367 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6368 (decode_coding_charset): Remove vars that are set but not used.
6369
1be4d761
PE
6370 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6371 that is set but not used.
6372
47553fa8
PE
6373 * print.c (print_object): Remove var that is set but not used.
6374
1f7196bf 6375 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6376 The gnulib version avoids calling malloc in the usual case,
6377 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6378 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6379 * filelock.c (current_lock_owner): Likewise.
6380 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6381 * sysdep.c: Include allocator.h, careadlinkat.h.
6382 (emacs_no_realloc_allocator): New static constant.
6383 (emacs_readlink): New function.
fdb61804
PE
6384 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6385 ../lib/careadlinkat.h.
d1fdcab7 6386
f84c17c7
SM
63872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6388
6389 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6390 first non-nil return value).
6391
ef3862ad
JD
63922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6393
6394 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6395 if not defined (Bug#8403).
6396
376a7006
JB
63972011-04-02 Juanma Barranquero <lekktu@gmail.com>
6398
6399 * xdisp.c (display_count_lines): Remove parameter `start',
6400 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6401 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6402 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6403 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6404 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6405 and thereabouts. All callers changed.
6406 (get_per_char_metric): Remove parameter `f', unused since
6407 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6408
6ca3801d
JM
64092011-04-02 Jim Meyering <meyering@redhat.com>
6410
6411 do not dereference NULL upon failed strdup
6412 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6413 (ns_get_family): Likewise.
6414
d8e2b5ba
JB
64152011-04-02 Juanma Barranquero <lekktu@gmail.com>
6416
6417 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6418
8c74fcbd
JD
64192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6420
6421 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6422 later (Bug#8403).
6423
7200d79c
SM
64242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6425
03408648 6426 Add lexical binding.
7200d79c 6427
03408648
SM
6428 * window.c (Ftemp_output_buffer_show): New fun.
6429 (Fsave_window_excursion):
6430 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6431
6432 * lread.c (lisp_file_lexically_bound_p): New function.
6433 (Fload): Bind Qlexical_binding.
6434 (readevalloop): Remove `evalfun' arg.
6435 Bind Qinternal_interpreter_environment.
6436 (Feval_buffer): Bind Qlexical_binding.
6437 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6438 Mark as dynamic.
6439 (syms_of_lread): Declare `lexical-binding'.
6440
6441 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6442
6443 * keyboard.c (eval_dyn): New fun.
6444 (menu_item_eval_property): Use it.
ca105506
SM
6445
6446 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6447
03408648
SM
6448 * fns.c (concat, mapcar1): Accept byte-code-functions.
6449
6450 * eval.c (Fsetq): Handle lexical vars.
6451 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6452 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6453 (FletX, Flet): Obey lexical binding.
6454 (Fcommandp): Handle closures.
6455 (Feval): New `lexical' arg.
6456 (eval_sub): New function extracted from Feval. Use it almost
6457 everywhere where Feval was used. Look up vars in lexical env.
6458 Handle closures.
6459 (Ffunctionp): Move from subr.el.
6460 (Ffuncall): Handle closures.
6461 (apply_lambda): Remove `eval_flags'.
6462 (funcall_lambda): Handle closures and new byte-code-functions.
6463 (Fspecial_variable_p): New function.
6464 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6465 but without exporting it to Lisp.
23aba0ea 6466
23aba0ea 6467 * doc.c (Fdocumentation, store_function_docstring):
03408648 6468 * data.c (Finteractive_form): Handle closures.
23aba0ea 6469
03408648
SM
6470 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6471 interactive spec.
ba83908c 6472
04f2d78b
CB
6473 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6474 New byte-codes.
03408648
SM
6475 (exec_byte_code): New function extracted from Fbyte_code to handle new
6476 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6477
03408648 6478 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6479
03408648 6480 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6481
e2abce01
JB
64822011-03-31 Juanma Barranquero <lekktu@gmail.com>
6483
6484 * xdisp.c (redisplay_internal): Fix prototype.
6485
63696a73 64862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6487
63696a73 6488 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6489 (try_scrolling): Use it when setting scroll_limit.
6490 Limit scrolling to 100 screen lines.
63696a73
EZ
6491 (redisplay_window): Even when falling back on "recentering",
6492 position point in the window according to scroll-conservatively,
6493 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6494
6495 (try_scrolling): When point is above the window, allow searching
6496 as far as scroll_max, or one screenful, to compute vertical
6497 distance from PT to the scroll margin position. This prevents
6498 try_scrolling from unnecessarily failing when
6499 scroll-conservatively is set to a value slightly larger than the
6500 window height. Clean up the case of PT below the margin at bottom
6501 of window: scroll_max can no longer be INT_MAX. When aggressive
6502 scrolling is in use, don't let point enter the opposite scroll
6503 margin as result of the scroll.
6504 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6505 threshold of 100 lines for never-recentering scrolling.
6506
e4cc2dfc
JB
65072011-03-31 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * dispextern.h (move_it_by_lines):
6510 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6511 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6512 (message_log_check_duplicate): Remove parameters `prev_bol' and
6513 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6514 (redisplay_internal): Remove parameter `preserve_echo_area',
6515 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6516
6517 * indent.c (Fvertical_motion):
6518 * window.c (window_scroll_pixel_based, Frecenter):
6519 Don't pass `need_y_p' to `move_it_by_lines'.
6520
1c470562
SM
65212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6522
44f230aa
SM
6523 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6524 steal a few bits to be more compact.
6525 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6526 Remove unneeded casts.
6527
1c470562
SM
6528 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6529
888adce9
ZK
65302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6531
6532 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6533 binding" message (bug#7967).
6534
f838ed7b
PE
65352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6536
77861b95
PE
6537 Fix more problems found by GCC 4.6.0's static checks.
6538
de6dbc14
PE
6539 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6540 Remove unused local var.
6541
f838ed7b
PE
6542 * editfns.c (Fmessage_box): Remove unused local var.
6543
792c7b2b
PE
6544 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6545 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6546 Omit unused local vars.
c499e557 6547 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6548 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6549 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6550 Omit unused local var.
6551
ba0165e1
PE
6552 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6553 Don't assume string length fits in int.
32ad8845 6554 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6555 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6556
3c59b4c9
PE
6557 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6558 instead of alloca (Bug#8344).
6559
a3eed478 6560 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6561 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6562
eb4d412d
PE
6563 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6564
1658b401
PE
6565 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6566 concerns.
6567
6568 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6569
6570 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6571
9a2c6e05
PE
6572 * keyboard.c (syms_of_keyboard): Use the same style as later
6573 in this function when indexing through an array. This also
6574 works around GCC bug 48267.
6575
03d0a109
PE
6576 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6577
44f730c8
PE
6578 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6579
fe75f926
PE
6580 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6581 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6582
ffa8c828
PE
6583 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6584 This avoids undefined behavior on integer overflow, and is a bit
6585 more convenient anyway since it is compared to a size_t variable.
6586
c5101a77
PE
6587 Variadic C functions now count arguments with size_t, not int.
6588 This avoids an unnecessary limitation on 64-bit machines, which
6589 caused (substring ...) to crash on large vectors (Bug#8344).
6590 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6591 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6592 All variadic functions and their callers changed accordingly.
c5101a77
PE
6593 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6594 * data.c (arith_driver, float_arith_driver): Likewise.
6595 * editfns.c (general_insert_function): Likewise.
6596 * eval.c (struct backtrace.nargs, interactive_p)
6597 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6598 (funcall_lambda, mark_backtrace): Likewise.
6599 * fns.c (concat): Likewise.
6600 * frame.c (x_set_frame_parameters): Likewise.
6601 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6602 0 if not found, not -1. All callers changed.
6603
dd3f25f7
PE
6604 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6605 (stack_copy_size): Now size_t, not int.
6606 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6607
461c2ab9
JB
66082011-03-28 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6611 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6612 All callers changed.
6613
6614 * lisp.h (multibyte_char_to_unibyte):
6615 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6616 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6617 * character.h (CHAR_TO_BYTE8):
6618 * cmds.c (internal_self_insert):
6619 * editfns.c (general_insert_function):
6620 * keymap.c (push_key_description):
6621 * search.c (Freplace_match):
6622 * xdisp.c (message_dolog, set_message_1): All callers changed.
6623
f6d62986
SM
66242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6625
6626 * keyboard.c (safe_run_hook_funcall): New function.
6627 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6628 don't set the hook to nil, but remove the offending function instead.
6629 (Qcommand_hook_internal): Remove, unused.
6630 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6631 Vcommand_hook_internal.
6632
6633 * eval.c (enum run_hooks_condition): Remove.
6634 (funcall_nil, funcall_not): New functions.
6635 (run_hook_with_args): Call each function through a `funcall' argument.
6636 Remove `cond' argument, now redundant.
6637 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6638 (Frun_hook_with_args_until_failure): Adjust accordingly.
6639 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6640
1db5b1ad
JB
66412011-03-28 Juanma Barranquero <lekktu@gmail.com>
6642
6643 * dispextern.h (string_buffer_position): Remove declaration.
6644
6645 * print.c (strout): Remove parameter `multibyte', unused since
6646 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6647
6648 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6649 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6650 All callers changed.
6651
6652 * w32.c (_wsa_errlist): Use braces for struct initializers.
6653
6654 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6655 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6656 All callers changed.
6657 (string_buffer_position): Likewise. Also, make static (it's never
6658 used outside xdisp.c).
6659 (cursor_row_p): Remove parameter `w', unused since
6660 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6661 (decode_mode_spec): Remove parameter `precision', introduced during
6662 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6663 All callers changed.
6664
5ffb62aa
JD
66652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6666
6667 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6668
461c2ab9 66692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6670
6671 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6672 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6673 (ns_update_auto_hide_menu_bar): New functions.
6674 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6675 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6676 ns_constrain_all_frames.
6677 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6678 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6679
5c380ffb
JD
66802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6681
6682 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6683
9af30bdf
GM
66842011-03-27 Glenn Morris <rgm@gnu.org>
6685
6686 * syssignal.h: Replace RETSIGTYPE with void.
6687 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6688 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6689 Replace SIGTYPE with void everywhere.
6690 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6691 * s/template.h (SIGTYPE): Remove commented out definition.
6692
e2abce01
JB
66932011-03-26 Eli Zaretskii <eliz@gnu.org>
6694
6695 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6696 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6697
f868cd8a
JB
66982011-03-26 Juanma Barranquero <lekktu@gmail.com>
6699
59eb0929
JB
6700 * w32.c (read_unc_volume): Use parameter `henum', instead of
6701 global variable `wget_enum_handle'.
6702
6703 * keymap.c (describe_vector): Remove parameters `indices' and
6704 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6705 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6706
f868cd8a
JB
6707 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6708
6709 * keyboard.c (timer_check): Remove parameter `do_it_now',
6710 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6711 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6712 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6713
6714 * keyboard.c (read_char):
6715 * w32menu.c (w32_menu_display_help):
6716 * xmenu.c (show_help_event, menu_help_callback):
6717 Adjust calls to `show_help_echo'.
6718
6719 * gtkutil.c (xg_maybe_add_timer):
6720 * keyboard.c (readable_events):
6721 * process.c (wait_reading_process_output):
6722 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6723
6724 * insdel.c (adjust_markers_gap_motion):
6725 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6726 (gap_left, gap_right): Don't call it.
6727
2ecf6fdb
CY
67282011-03-25 Chong Yidong <cyd@stupidchicken.com>
6729
6730 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6731 incurred during fontification.
6732
6b1f9ba4
JB
67332011-03-25 Juanma Barranquero <lekktu@gmail.com>
6734
6735 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6736 (DEFVAR_PER_BUFFER): Don't pass it.
6737
6738 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6739 (scrolling_window): Don't pass it.
6740
0f4a96b5
JB
67412011-03-25 Juanma Barranquero <lekktu@gmail.com>
6742
6743 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6744
6745 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6746 and `suffix'.
6747 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6748 of variables specific to SELinux and computation of `encoded_absname'.
6749
6750 * image.c (XPutPixel): Remove unused variable `height'.
6751
6752 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6753
6754 * unexw32.c (get_section_info): Remove unused variable `section'.
6755
6756 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6757 (system_process_attributes): Remove unused variable `sess'.
6758 (sys_read): Remove unused variable `err'.
6759
6760 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6761 (w32_wnd_proc): Remove unused variable `isdead'.
6762 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6763 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6764 (x_create_tip_frame): Remove unused variable `tem'.
6765
6766 * w32inevt.c (w32_console_read_socket):
6767 Remove unused variable `no_events'.
6768
6769 * w32term.c (x_draw_composite_glyph_string_foreground):
6770 Remove unused variable `width'.
6771
1149507c
JB
67722011-03-24 Juanma Barranquero <lekktu@gmail.com>
6773
6774 * w32term.c (x_set_glyph_string_clipping):
6775 Don't pass uninitialized region to CombineRgn.
6776
9c88f339
JB
67772011-03-23 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6780 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6781 (Fx_close_connection): Remove unused variable `i'.
6782
6783 * w32font.c (w32font_draw): Return number of glyphs.
6784 (w32font_open_internal): Remove unused variable `i'.
6785 (w32font_driver): Add missing initializer.
6786
6787 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6788 (fill_in_menu): Remove unused variable `items_added'.
6789
6790 * w32term.c (last_mouse_press_frame): Remove static global variable.
6791 (w32_clip_to_row): Remove unused variable `f'.
6792 (x_delete_terminal): Remove unused variable `i'.
6793
6794 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6795 (NOTHING): Remove unused static global variable.
6796 (uniscribe_check_otf): Remove unused variable `table'.
6797 (uniscribe_font_driver): Add missing initializers.
6798
dee091a3
JD
67992011-03-23 Julien Danjou <julien@danjou.info>
6800
6801 * term.c (Fsuspend_tty, Fresume_tty):
6802 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6803 * window.c (temp_output_buffer_show):
6804 * insdel.c (signal_before_change):
6805 * frame.c (Fhandle_switch_frame):
6806 * fileio.c (Fdo_auto_save):
6807 * emacs.c (Fkill_emacs):
6808 * editfns.c (save_excursion_restore):
6809 * cmds.c (internal_self_insert):
6810 * callint.c (Fcall_interactively):
6811 * buffer.c (Fkill_all_local_variables):
6812 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6813 Use Frun_hooks.
0f4a96b5 6814 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6815 unconditionnaly since it does the check itself.
6816
2c520ab5 68172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6818
c9c49752
PE
6819 Fix more problems found by GCC 4.5.2's static checks.
6820
8abc3f12
PE
6821 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6822 the first time through the loop, since we know p0 < p1 then.
6823 This also avoids a gcc -Wstrict-overflow warning.
6824
a2d26660
PE
6825 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6826 leading to a memory leak, possible in functions like
6827 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6828 of objects (Bug#8318).
a2d26660 6829
916c72e9
PE
6830 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6831 that could (at least in theory) be that large.
6832
19ab8a18
PE
6833 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6834 This is less likely to overflow, and avoids undefined behavior if
6835 overflow does occur. All callers changed. Use strtoul to scan
6836 for the unsigned long integer.
b7cbbd6f
PE
6837 (pint2hrstr): Simplify and tune code slightly.
6838 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6839
f0641eff
PE
6840 * scroll.c (do_scrolling): Work around GCC bug 48228.
6841 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6842
7f650bb9
PE
6843 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6844 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6845 (validate_x_resource_name): Simplify count usage.
6846 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6847
37dd57d1
PE
6848 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6849 fail (Bug#8306).
81e56e61 6850
699979fc 6851 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6852
401bf9b4
PE
6853 * process.c (Fmake_network_process): Use socklen_t, not int,
6854 where POSIX says socklen_t is required in portable programs.
6855 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6856 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6857 (Fmake_network_process, server_accept_connection):
6858 (wait_reading_process_output, read_process_output):
6859 Likewise.
6860
b93aacde
PE
6861 * process.c: Rename or move locals to avoid shadowing.
6862 (list_processes_1, Fmake_network_process):
6863 (read_process_output_error_handler, exec_sentinel_error_handler):
6864 Rename or move locals.
4dc343ee 6865 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6866 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6867 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6868 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6869 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6870
af8a867c 6871 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6872 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6873 Include tparam.h instead, since it declares them.
af8a867c
PE
6874 * cm.h (PC): Remove extern decl; tparam.h now does this.
6875 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6876 * terminfo.c: Include tparam.h, to check interfaces.
6877 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6878 (tparam): Adjust signature to match interface in tparam.h;
6879 this removes some undefined behavior. Check that outstring and len
6880 are zero, which they always are with Emacs.
6881 * tparam.h (PC, BC, UP): New extern decls.
6882
0248044d 6883 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6884 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6885
8ff096c1 6886 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6887 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6888 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6889 (ftfont_list): Remove unused local.
49eaafba
PE
6890 (get_adstyle_property, ftfont_pattern_entity):
6891 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6892 Rename locals to avoid shadowing.
8ff096c1 6893
e2be39f6
PE
6894 * xfont.c (xfont_list_family): Mark var as initialized.
6895
c9735e30
PE
6896 * xml.c (make_dom): Now static.
6897
8f5201ae
PE
6898 * composite.c (composition_compute_stop_pos): Rename local to
6899 avoid shadowing.
b246f932
PE
6900 (composition_reseat_it): Remove unused locals.
6901 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6902 (composition_update_it): Mark var as initialized.
11b61122
PE
6903 (find_automatic_composition): Mark vars as initialized,
6904 with a FIXME (Bug#8290).
8f5201ae 6905
760fbc2c
PE
6906 character.h: Rename locals to avoid shadowing.
6907 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6908 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6909 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6910 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6911 to avoid shadowing.
6912
ff08eb85
PE
6913 * textprop.c (property_change_between_p): Remove; unused.
6914
fc7bf025
PE
6915 * intervals.c (interval_start_pos): Now static.
6916
235d7abc
PE
6917 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6918
44f230aa
SM
6919 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6920 Rename locals to avoid shadowing.
3e7d6594 6921
50060332
PE
6922 * sound.c (wav_play, au_play, Fplay_sound_internal):
6923 Fix pointer signedness.
d01f234b 6924 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6925 (wav_play): Initialize a variable to 0, to prevent undefined
6926 behavior (Bug#8278).
50060332 6927
c4fc4e30
PE
6928 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6929
918436ed
PE
6930 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6931
c939f91b
PE
6932 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6933 clobbering (Bug#8298).
b9c7f648
PE
6934 * sysdep.c (sys_subshell): Likewise.
6935 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6936
6bd8c144
PE
6937 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6938 This should get cleaned up, so that child_setup has the
6939 same signature on all platforms.
6940
7710357c 6941 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6942 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6943
c59da222
CY
69442011-03-22 Chong Yidong <cyd@stupidchicken.com>
6945
6946 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6947 not to be necessary, and produces flickering.
6948
66b87493
GM
69492011-03-20 Glenn Morris <rgm@gnu.org>
6950
6951 * config.in: Remove file.
6952
45b6f6d5
JB
69532011-03-20 Juanma Barranquero <lekktu@gmail.com>
6954
6955 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6956 are now in src/globals.h.
6957 (syms_of_minibuf): Remove spurious & from previous change.
6958
3ec03f7e
LL
69592011-03-20 Leo <sdl.web@gmail.com>
6960
6961 * minibuf.c (completing-read-function): New variable.
6962 (completing-read-default): Rename from completing-read.
6963 (completing-read): Call completing-read-function.
6964
b14e3e21
CY
69652011-03-19 Juanma Barranquero <lekktu@gmail.com>
6966
6967 * xfaces.c (Fx_load_color_file):
6968 Read color file from absolute filename (bug#8250).
6969
f2b726e6
JB
69702011-03-19 Juanma Barranquero <lekktu@gmail.com>
6971
6972 * makefile.w32-in: Update dependencies.
6973
09f6ff02
EZ
69742011-03-17 Eli Zaretskii <eliz@gnu.org>
6975
6976 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6977
29a6015a
PE
69782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6979
a3a6c54e
PE
6980 Fix more problems found by GCC 4.5.2's static checks.
6981
b766f867
PE
6982 * process.c (make_serial_process_unwind, send_process_trap):
6983 (sigchld_handler): Now static.
6984
be02381c
PE
6985 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6986 That way, the code declares only the vars that it needs.
6987 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6988 * s/cygwin.h (PTY_ITERATION): Likewise.
6989 * s/darwin.h (PTY_ITERATION): Likewise.
6990 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6991
57048744
PE
6992 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6993 * process.c (allocate_pty): Don't declare stb unless it's needed.
6994
7914961c 6995 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6996 (CONSTANTLIM): Remove; unused.
6997 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6998 Define only if needed.
7914961c 6999
b3967b18
PE
7000 * unexelf.c (unexec): Name an expression,
7001 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7002 Use a different way to cause a compilation error if anyone uses
7003 n rather than nn, a way that does not involve shadowing.
73366a00 7004 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7005
29a6015a
PE
7006 * deps.mk (unexalpha.o): Remove; unused.
7007
43cfc33e 7008 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7009 * unexec.h: New file.
ce701a33
PE
7010 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7011 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7012 Depend on unexec.h.
7013 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7014 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7015 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7016 Change as necessary to match prototype in unexec.h.
ce701a33 7017
01f44d5a
PE
7018 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7019 shadowing.
4f63c6bb 7020 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7021
a6670b0b
PE
7022 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7023 Rename locals to avoid shadowing.
7024
cef2010d 7025 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7026 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7027
d4d7173a
PE
7028 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7029
f08b802a
PE
7030 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7031 warning when compiling print.c.
7032
3ddb0639
PE
7033 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7034 instead of using an uninitialized var.
5ad03b97 7035 (font_sort_entities): Mark var as initialized.
3ddb0639 7036
170a2692
PE
7037 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7038
e663c700
PE
7039 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7040 pointers to constants.
89bc529a 7041 (font_parse_fcname): Remove unused vars.
7b81e2d0 7042 (font_delete_unmatched): Now static.
ea838e10 7043 (font_get_spec): Remove; unused.
13a547c6
PE
7044 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7045 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7046 Rename or move locals to avoid shadowing.
e663c700 7047
2a80c887 7048 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7049 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7050
1384fa33 7051 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7052 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7053
8b2c52e9
PE
7054 * alloc.c (mark_backtrace): Move decl from here ...
7055 * lisp.h: ... to here, so that it can be checked.
7056
475545b5 7057 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7058 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7059 (lisp_indirect_variable): Name an expression,
7060 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7061 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7062
b1349114 7063 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7064 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7065 Use const pointer when appropriate.
b1349114 7066
a2928364
PE
7067 * lisp.h (get_system_name, get_operating_system_release):
7068 Move decls here, to check interfaces.
7069 * process.c (get_operating_system_release): Move decl to lisp.h.
7070 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7071 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7072 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7073 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7074 (Fformat_time_string, Fencode_time, Finsert_char):
7075 (Ftranslate_region_internal, Fformat):
7076 Rename or remove local vars to avoid shadowing.
9710023e 7077 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7078
a415e694
PE
7079 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7080 avoid shadowing.
7081
8ef4622d
PE
7082 * lisp.h (eassert): Check that the argument compiles, even if
7083 ENABLE_CHECKING is not defined.
7084
946f9a5b
PE
7085 * data.c (Findirect_variable): Name an expression, to avoid
7086 gcc -Wbad-function-cast warning.
112396d6 7087 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7088 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7089 (Fmake_variable_buffer_local, Fmake_local_variable):
7090 Mark variables as initialized.
52746918 7091 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7092
e5aab7e7 7093 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7094 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7095 Rename locals to avoid shadowing.
dff45157
PE
7096 (mark_stack): Move local variables into the #ifdef region where
7097 they're used.
7bc26fdb
PE
7098 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7099 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7100 needed otherwise.
7101 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7102 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7103 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7104
e5aab7e7
PE
7105 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7106 avoids undefined behavior in theory.
7107
4da60324
PE
7108 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7109
88043301
PE
7110 Use functions, not macros, for up- and down-casing (Bug#8254).
7111 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7112 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7113 to use the following functions instead of these macros.
7114 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7115 EMACS_INT, since callers assume the returned value fits in int.
7116 (upcase1): Likewise, for UPCASE_TABLE.
7117 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7118 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7119 the race-condition problem in the old DOWNCASE.
88043301 7120
19ed5445
PE
7121 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7122 Rename locals to avoid shadowing.
7123 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7124 (regex_compile, re_search_2, re_match_2_internal):
7125 Remove unused local vars.
952db0d7
PE
7126 (FREE_VAR): Rewrite so as not to use empty "else",
7127 which gcc can warn about.
da053e48 7128 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7129 (RETALLOC_IF): Define only if needed.
7130 (WORDCHAR_P): Likewise. This one is never needed, but is used
7131 only in a comment talking about a compiler bug, so put inside
7132 the #if 0 of that comment.
7133 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7134 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7135 Remove; unused.
19ed5445 7136
1f3561e4 7137 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7138 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7139 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7140
ded6f8f7
PE
7141 * search.c (simple_search): Remove unused var.
7142
dbd37a95
PE
7143 * dired.c (compile_pattern): Move decl from here ...
7144 * lisp.h: ... to here, so that it can be checked.
7145 (struct re_registers): New forward decl.
7146
7e47afad
PE
7147 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7148
85f24f61
PE
7149 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7150 All uses changed.
7151 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7152 Rename locals to avoid shadowing.
5671df8f 7153 (Fvertical_motion): Mark locals as initialized.
85f24f61 7154
181aa2be 7155 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7156 (casify_region): Mark local as initialized.
181aa2be 7157
930d429c
PE
7158 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7159
7082eac6
PE
7160 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7161 New macros, so that the caller can use some names other than
7162 gcpro1, gcpro2, etc.
7163 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7164 of the new macros.
7165 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7166 argument, for consistency with GCPRO2_VAR, etc: it is now the
7167 prefix of the variable, not the variable itself. All uses
7168 changed.
38b2c076
PE
7169 * dired.c (directory_files_internal, file_name_completion):
7170 Rename locals to avoid shadowing.
7171
15206ed9
PE
7172 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7173 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7174 dired.c's scmp function, had undefined behavior.
7175 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7176 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7177 * buffer.h: ... to here, because these macros use current_buffer,
7178 and the new implementation with inline functions needs to have
7179 current_buffer in scope now, rather than later when the macros
7180 are used.
7181 (downcase, upcase1): New static inline functions.
7182 (DOWNCASE, UPCASE1): Reimplement using these functions.
7183 This avoids undefined behavior in expressions like
7184 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7185 from race conditions in accessing the global variables
7186 case_temp1 and case_temp2.
7187 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7188 * lisp.h (case_temp1, case_temp2): Remove their decls.
7189 * character.h (ASCII_CHAR_P): Move from here ...
7190 * lisp.h: ... to here, so that the inline functions mentioned
7191 above can use them.
7192
4a6bea26
PE
7193 * dired.c (directory_files_internal_unwind): Now static.
7194
f14b7e14
PE
7195 * fileio.c (file_name_as_directory, directory_file_name):
7196 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7197 Now static.
2893f146
PE
7198 (file_name_as_directory): Use const pointers when appropriate.
7199 (Fexpand_file_name): Likewise. In particular, newdir might
7200 point at constant storage, so make it a const pointer.
fd4ead52 7201 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7202 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7203 signedness issues.
f839df0c
PE
7204 (Fset_file_times, Finsert_file_contents, auto_save_error):
7205 Rename locals to avoid shadowing.
f14b7e14 7206
5716756e 7207 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7208 (Ftry_completion, Fall_completions): Rename or remove locals
7209 to avoid shadowing.
5716756e 7210
b4c3046a
PE
7211 * marker.c (bytepos_to_charpos): Remove; unused.
7212
b45db522
PE
7213 * lisp.h (verify_bytepos, count_markers): New decls,
7214 so that gcc does not warn that these functions aren't declared.
7215
85876d07
PE
7216 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7217 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7218 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7219 (copy_text): Remove unused local var.
85876d07 7220
03d78a21 7221 * filelock.c (within_one_second): Now static.
b3dd38ab 7222 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7223
5df8f01b
PE
7224 * buffer.c (fix_overlays_before): Mark locals as initialized.
7225 (fix_start_end_in_overlays): Likewise. This function should be
7226 simplified by using pointers-to-pointers, but that's a different
7227 matter.
b1d876f1 7228 (switch_to_buffer_1): Now static.
8f54f30a
PE
7229 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7230 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7231
a70072c9 7232 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7233 Fix pointer signedness issue.
edced198
PE
7234 (sys_subshell): Mark local as volatile if checking for lint,
7235 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7236 (MAXPATHLEN): Define only if needed.
a70072c9 7237
a0977c44
PE
7238 * process.c (serial_open, serial_configure): Move decls from here ...
7239 * systty.h: ... to here, so that they can be checked.
7240
a884fdcc
PE
7241 * fns.c (get_random, seed_random): Move extern decls from here ...
7242 * lisp.h: ... to here, so that they can be checked.
7243
604efe86 7244 * sysdep.c (reset_io): Now static.
b8950c94 7245 (wait_for_termination_signal): Remove; unused.
604efe86 7246
38fc62d9
PE
7247 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7248 (copy_keymap_item, append_key, push_text_char_description):
7249 Now static.
1004a21a 7250 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7251 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7252 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7253 (describe_map_tree):
7254 Rename locals to avoid shadowing.
38fc62d9 7255
2f2650da
PE
7256 * keyboard.c: Declare functions static if they are not used elsewhere.
7257 (echo_char, echo_dash, cmd_error, top_level_2):
7258 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7259 (read_char, kbd_buffer_get_event, make_lispy_position):
7260 (make_lispy_event, make_lispy_movement, apply_modifiers):
7261 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7262 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7263 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7264 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7265 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7266
a053e86c 7267 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7268 (mark_kboards): Move decl here ...
7269 * alloc.c (mark_kboards): ... from here.
a053e86c 7270
4752793e
PE
7271 * lisp.h (force_auto_save_soon): New decl.
7272
74f10ca7 7273 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7274 (DEFINE_DUMMY_FUNCTION): New macro.
7275 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7276 Use it.
c03cd23f
PE
7277 (main): Add casts to avoid warnings
7278 if GCC considers string literals to be constants.
74f10ca7 7279
022e70d4
PE
7280 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7281
59d6fe83
PE
7282 * dbusbind.c: Pointer signedness fixes.
7283 (xd_signature, xd_append_arg, xd_initialize):
7284 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7285 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7286 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7287 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7288
78320123
PE
7289 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7290 if GCC considers string literals to be constants.
49cebcca 7291 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7292
35ac2a97
SM
72932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7294
fb103ca9
SM
7295 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7296 (print_preprocess, print_object): New macro to fix last change.
7297
35ac2a97
SM
7298 * print.c (print_preprocess): Don't forget font objects.
7299
62973b41
JB
73002011-03-16 Juanma Barranquero <lekktu@gmail.com>
7301
7302 * emacs.c (USAGE3): Doc fixes.
7303
0e48bb22
AS
73042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7305
7306 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7307 structure.
7308
7684e57b
JB
73092011-03-14 Juanma Barranquero <lekktu@gmail.com>
7310
7311 * lisp.h (VWindow_system, Qfile_name_history):
7312 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7313 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7314 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7315
7316 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7317 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7318
7319 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7320 * w32console.c (detect_input_pending, read_input_pending)
7321 (encode_terminal_code):
7322 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7323 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7324 (w32_system_caret_y, Qfile_name_history):
7325 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7326 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7327 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7328 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7329 * w32proc.c (Qlocal, report_file_error):
7330 * w32term.c (Vwindow_system, updating_frame):
7331 * w32uniscribe.c (initialized, uniscribe_font_driver):
7332 Remove unneeded extern declarations.
7333
2aa46d6c
CY
73342011-03-14 Chong Yidong <cyd@stupidchicken.com>
7335
c96bbc66 7336 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7337
cffc6f3b
CY
73382011-03-13 Chong Yidong <cyd@stupidchicken.com>
7339
7340 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7341 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7342 These macros can no longer be used for assignment.
7343
44f230aa
SM
7344 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7345 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7346 (record_buffer_markers, fetch_buffer_markers): New functions for
7347 recording and fetching special buffer markers.
7348 (set_buffer_internal_1, set_buffer_temp): Use them.
7349
7350 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7351
7352 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7353
7354 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7355 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7356
7357 * xdisp.c (hscroll_window_tree):
7358 (reconsider_clip_changes): Use PT instead of BUF_PT.
7359
d251f04b
EZ
73602011-03-13 Eli Zaretskii <eliz@gnu.org>
7361
7362 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7363 $(EMACS_ROOT)/lib/intprops.h.
7364
f0c77cd1
PE
73652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7366
3eca4629
PE
7367 Fix more problems found by GCC 4.5.2's static checks.
7368
7c86ee98
PE
7369 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7370 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7371 (xg_free_frame_widgets): Make it clear that a local variable is
7372 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7373 (gdk_window_get_screen): Make it clear that this macro is needed
7374 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7375 (int_gtk_range_get_value): New function, which avoids a diagnostic
7376 from gcc -Wbad-function-cast.
7377 (xg_set_toolkit_scroll_bar_thumb): Use it.
7378 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7379 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7380 (get_utf8_string, xg_get_file_with_chooser):
7381 Rename locals to avoid shadowing.
7382 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7383
41729b81
PE
7384 * xgselect.c (xg_select): Remove unused var.
7385
f0c77cd1
PE
7386 * image.c (four_corners_best): Mark locals as initialized.
7387 (gif_load): Initialize transparent_p to zero (Bug#8238).
7388 Mark another local as initialized.
ec6cf4c6 7389 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7390
ce0ad53d 7391 * image.c (clear_image_cache): Now static.
d5d5a617 7392 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7393 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7394 (x_edge_detection): Remove unnecessary cast that
7395 gcc -Wbad-function-cast diagnoses.
2037898d 7396 (gif_load): Fix pointer signedness.
6ae141d6
PE
7397 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7398 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7399
33383987 74002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7401
d32df629
PE
7402 Improve quality of tests for time stamp overflow.
7403 For example, without this patch (encode-time 0 0 0 1 1
7404 1152921504606846976) returns the obviously-bogus value (-948597
7405 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7406 reports time overflow. See
7407 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7408 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7409 * editfns.c: Include limits.h and intprops.h.
7410 (TIME_T_MIN, TIME_T_MAX): New macros.
7411 (time_overflow): Move earlier, to before first use.
7412 (hi_time, lo_time): New functions, for an accurate test for
7413 out-of-range times.
7414 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7415 (Fget_internal_run_time): Don't assume time_t fits in int.
7416 (make_time): Use list2 instead of Fcons twice.
7417 (Fdecode_time): More accurate test for out-of-range times.
7418 (check_tm_member): New function.
7419 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7420 (lisp_time_argument): Don't rely on undefined left-shift and
7421 right-shift behavior when checking for time stamp overflow.
8be6f318 7422
fe31d94c
PE
7423 * editfns.c (time_overflow): New function, refactoring common code.
7424 (Fformat_time_string, Fdecode_time, Fencode_time):
7425 (Fcurrent_time_string): Use it.
7426
8be6f318
PE
7427 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7428 * dired.c (make_time): Move to ...
7429 * editfns.c (make_time): ... here.
7430 * systime.h: Note the move.
7431
09d9db2c 74322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7433
126bc0dc
YM
7434 * fringe.c (update_window_fringes): Remove unused variables.
7435
c47cbdfd
YM
7436 * unexmacosx.c (copy_data_segment): Also copy __got section.
7437 (Bug#8223)
7438
7ac80be9
EZ
74392011-03-12 Eli Zaretskii <eliz@gnu.org>
7440
c96bbc66 7441 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7442 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7443 Constify `char *' arguments and their references according to
7444 prototypes in tparam.h.
7445
ecb0f94d 7446 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7447
7ac80be9
EZ
7448 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7449 Adapt all references accordingly.
7450
7451 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7452
ef1fd07e
TT
74532011-03-11 Tom Tromey <tromey@redhat.com>
7454
7455 * buffer.c (syms_of_buffer): Remove obsolete comment.
7456
7ef4b50c
EZ
74572011-03-11 Eli Zaretskii <eliz@gnu.org>
7458
7459 * termhooks.h (encode_terminal_code): Declare prototype.
7460
7461 * msdos.c (encode_terminal_code): Don't declare prototype.
7462
7463 * term.c (encode_terminal_code): Now external again, used by
7464 w32console.c and msdos.c.
7465
44f230aa
SM
7466 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7467 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7468
4b1ec863 74692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7470
1714f52b 7471 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7472
4b1ec863
PE
7473 * fringe.c (update_window_fringes): Mark locals as initialized
7474 (Bug#8227).
7475 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7476
524c7aa6
PE
7477 * alloc.c (mark_fringe_data): Move decl from here ...
7478 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7479 to check its interface.
7480 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7481
a5c0af81 7482 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7483 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7484 (fontset_font): Mark local as initialized.
a9a06e0b 7485 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7486
b4716021
PE
7487 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7488
811e9bac 7489 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7490 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7491 (x_own_selection, Fx_disown_selection_internal): Rename locals
7492 to avoid shadowing.
7493 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7494
7e3ab302
PE
7495 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7496 so that the caller can use some name other than gcpro1.
7497 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7498 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7499 (Fx_backspace_delete_keys_p):
7500 Use them to avoid shadowing, and rename vars to avoid shadowing.
7501 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7502 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7503 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7504 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7505 Remove unused locals.
7e3ab302
PE
7506 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7507 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7508 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7509 macros.
f78faa98 7510
e2b13473
PE
7511 * xterm.h (x_mouse_leave): New decl.
7512
77f23912
PE
7513 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7514 Remove unused functions.
cdf4ba58
PE
7515 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7516 (x_calc_absolute_position): Now static.
7411c686 7517 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7518 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7519 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7520 unless they are used.
38d0b34a
PE
7521 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7522 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7523 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7524 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7525 (x_error_catcher, x_connection_closed, x_error_handler):
7526 (x_error_quitter, xembed_send_message, x_iconify_frame):
7527 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7528 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7529 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7530
44f230aa
SM
7531 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7532 Rename or move locals to avoid shadowing.
6b463e58 7533 (tty_defined_color, merge_face_heights): Now static.
5967d051 7534 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7535 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7536 does not deduce is never used uninitialized.
73719eba
PE
7537 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7538 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7539
426994c3 7540 * terminal.c (store_terminal_param): Now static.
5489860b 7541
032f1620 7542 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7543 (set_frame_menubar): Remove unused local.
d4323972 7544 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7545 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7546 since they might point to immutable storage.
281585b0
PE
7547 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7548 since it's unused otherwise.
032f1620 7549
367c19e5 7550 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7551 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7552 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7553 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7554 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7555 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7556 does not deduce are never used uninitialized.
70739cbe 7557
07b48fa9
PE
7558 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7559
8868a238 7560 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7561 * window.c (window_loop, size_window):
7562 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7563
7e5cf297 7564 * window.c (display_buffer): Now static.
d6550a9f
PE
7565 (size_window): Mark variables that gcc -Wuninitialized
7566 does not deduce are never used uninitialized.
a586633d
PE
7567 * window.h (check_all_windows): New decl, to forestall
7568 gcc -Wmissing-prototypes diagnostic.
5b555da1 7569 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7570
f6095868
PE
7571 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7572 shadowing.
7573 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7574 Include <limits.h>.
7575 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7576 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7577 (load_charset_map): Mark variables that gcc -Wuninitialized
7578 does not deduce are never used uninitialized.
53df7c11 7579 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7580
f38b440c
PE
7581 * coding.c (coding_set_source, coding_set_destination):
7582 Use "else { /* comment */ }" rather than "else /* comment */;"
7583 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7584 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7585 a block, when the outer 'i' will do.
7586 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7587 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7588 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7589 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7590 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7591 Rename locals to avoid shadowing.
7592 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7593 * coding.c (emacs_mule_char, encode_invocation_designation):
7594 Now static, since they're not used elsewhere.
413bb2db 7595 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7596 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7597 (decode_coding_emacs_mule): Mark variables that gcc
7598 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7599 (detect_coding_iso_2022): Initialize a local variable that might
7600 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7601 this initialization is needed. (Bug#8211)
5f58e762
PE
7602 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7603 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7604 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7605 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7606 Remove unused macros.
f38b440c 7607
232b38b9 7608 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7609 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7610 * character.c (string_count_byte8): Likewise.
232b38b9 7611
fb90da1b
PE
7612 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7613 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7614
fb93dbc2
PE
7615 * chartab.c (copy_sub_char_table): Now static, since it's not used
7616 elsewhere.
5c156ace
PE
7617 (sub_char_table_ref_and_range, char_table_ref_and_range):
7618 Rename locals to avoid shadowing.
bbcd0949 7619 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7620
7d3b3862 7621 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7622 (BIDI_BOB): Remove unused macro.
7d3b3862 7623
6be7d3da
PE
7624 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7625 deduce are never used uninitialized.
c2ed9c8b 7626 * term.c (encode_terminal_code): Likewise.
6be7d3da 7627
75f8807f 7628 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7629
50938595
PE
7630 * tparam.h: New file.
7631 * term.c, tparam.h: Include it.
7632 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7633 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7634 Move these decls to tparam.h, and make them agree with what
7635 is actually in tparam.c. The previous trick of using incompatible
7636 decls in different modules does not conform to the C standard.
7637 All callers of tparam changed to use tparam's actual API.
7638 * tparam.c (tparam1, tparam, tgoto):
7639 Use const pointers where appropriate.
7640
fbceeba2
PE
7641 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7642 * cm.h (struct cm): Likewise.
7643 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7644 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7645 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7646 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7647 (turn_on_face, init_tty): Likewise.
7648 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7649
7f3f1250
PE
7650 * term.c (term_mouse_position): Rename local to avoid shadowing.
7651
e6ca6543
PE
7652 * alloc.c (mark_ttys): Move decl from here ...
7653 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7654
c40f8d15
AS
76552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7656
7657 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7658
cfe0661d
JB
76592011-03-09 Juanma Barranquero <lekktu@gmail.com>
7660
7661 * search.c (compile_pattern_1): Remove argument regp, unused since
7662 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7663 (compile_pattern): Don't pass it.
7664
0afb4571
J
76652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7666
7667 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7668 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7669 for ! HAVE_GTK3.
7670 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7671
7672 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7673
7674 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7675 gdk_window_get_screen, gdk_window_get_geometry,
7676 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7677 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7678 (xg_get_pixbuf_from_pixmap): New function.
7679 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7680 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7681 Call xg_get_pixbuf_from_pixmap instead of
7682 gdk_pixbuf_get_from_drawable.
7683 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7684 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7685 (xg_check_special_colors): Use GtkStyleContext and its functions
7686 for HAVE_GTK3.
7687 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7688 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7689 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7690 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7691 Call gtk_widget_get_preferred_size.
0afb4571
J
7692 (xg_frame_resized): gdk_window_get_geometry only takes 5
7693 parameters.
44f230aa
SM
7694 (xg_win_to_widget, xg_event_is_for_menubar):
7695 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7696 (xg_set_widget_bg): New function.
7697 (delete_cb): New function.
895009e1 7698 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7699 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7700 (xg_set_background_color): Call xg_set_widget_bg.
7701 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7702 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7703 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7704 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7705 if ! HAVE_GTK3.
7706 (update_frame_tool_bar): Call gtk_widget_hide.
7707 (xg_initialize): Use GDK_KEY_g.
7708
7709 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7710 if ! HAVE_GTK3
7711 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7712
7713 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7714 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7715 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7716
1c2cc4ef
JB
77172011-03-08 Juanma Barranquero <lekktu@gmail.com>
7718
7719 * w32xfns.c (select_palette): Check success of RealizePalette against
7720 GDI_ERROR, not zero.
7721
33383987 7722See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7723
7724;; Local Variables:
7725;; coding: utf-8
aac0c6e3
MR
7726;; End:
7727
33383987 7728 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7729
7730 This file is part of GNU Emacs.
7731
7732 GNU Emacs is free software: you can redistribute it and/or modify
7733 it under the terms of the GNU General Public License as published by
7734 the Free Software Foundation, either version 3 of the License, or
7735 (at your option) any later version.
7736
7737 GNU Emacs is distributed in the hope that it will be useful,
7738 but WITHOUT ANY WARRANTY; without even the implied warranty of
7739 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7740 GNU General Public License for more details.
7741
7742 You should have received a copy of the GNU General Public License
7743 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.