Fix doc-string of recenter-redisplay.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
454592a6
MR
12011-12-13 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (Vwindow_combination_resize)
4 (Vwindow_combination_limit): Use t instead of non-nil in
5 doc-strings.
61d4b438
MR
6 (Vrecenter_redisplay): Add first sentence of doc-string on
7 separate line.
454592a6 8
3633e3aa
KH
92011-12-11 Kenichi Handa <handa@m17n.org>
10
11 * coding.c (Funencodable_char_position): Pay attention to the
12 buffer text relocation (Bug#9389).
13
7b9d523a
JD
142011-12-10 Jan Djärv <jan.h.d@swipnet.se>
15
16 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
17 gtk_init (Bug#10100).
18
b73189c6
EZ
192011-12-10 Eli Zaretskii <eliz@gnu.org>
20
21 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
22 IT->string is nil. (Bug#10263)
23
f7dfe5d6
JD
242011-12-10 Jan Djärv <jan.h.d@swipnet.se>
25
83faebb4
JD
26 * nsterm.h (x_free_frame_resources): Declare.
27
f7dfe5d6
JD
28 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
29 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
30
31 * nsterm.h (ns_get_defaults_value): Declare.
32
33 * nsterm.m (ns_default): Call ns_get_defaults_value.
34
7cd4e72c
EZ
352011-12-09 Eli Zaretskii <eliz@gnu.org>
36
37 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
38 (Bug#10170)
39
b34d7317
YM
402011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
41
42 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
43 that where the value of an _OBJC_* symbol points to is in the .bss
44 section (Bug#10240).
45
76470ad1
KH
462011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
47
48 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 49 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 50
745fff94
KH
512011-12-08 Kenichi Handa <handa@m17n.org>
52
53 * ftfont.c (get_adstyle_property): Fix previous change
54 (Bug#10233).
55
6e44397c
JB
562011-12-07 Juanma Barranquero <lekktu@gmail.com>
57
58 * w32.c (init_environment): If no_site_lisp, remove site-lisp
59 dirs from the default value of EMACSLOADPATH (bug#10208).
60
7efa6272
GM
612011-12-07 Glenn Morris <rgm@gnu.org>
62
63 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
64 installation and source directories as well. (Bug#10208)
65
f6fc4d87
CY
662011-12-06 Chong Yidong <cyd@gnu.org>
67
68 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
69
2bf26180
GM
702011-12-06 Glenn Morris <rgm@gnu.org>
71
72 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
73 as an error, not just -1. (Bug#10217)
74
3a6ad4f0
CY
752011-12-05 Chong Yidong <cyd@gnu.org>
76
77 * keyboard.c (process_special_events): New function.
78 (swallow_events, Finput_pending_p): Use it (Bug#10195).
79
75a3b399
PE
802011-12-05 Paul Eggert <eggert@cs.ucla.edu>
81
82 * coding.c (encode_designation_at_bol): Don't use uninitialized
83 local variable (Bug#9318).
84
c3c9e25e
KH
852011-12-05 Kenichi Handa <handa@m17n.org>
86
87 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
88 return Qnil (Bug#8046, Bug#10193).
89
5eb05ea3
KH
902011-12-05 Kenichi Handa <handa@m17n.org>
91
92 * coding.c (encode_designation_at_bol): New args charbuf_end and
93 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
94 (coding_set_source): Return how many bytes coding->source was
95 relocated.
96 (coding_set_destination): Return how many bytes
97 coding->destination was relocated.
98 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
99 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
100
1012011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
102
103 * coding.c (CODING_CHAR_CHARSET_P): New macro.
104 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
105 macro (Bug#9318).
106
1072011-12-05 Andreas Schwab <schwab@linux-m68k.org>
108
109 The following changes are to fix Bug#9318.
110
a79703f5 111 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
112 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
113 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 114 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 115
7dbda6df
JB
1162011-12-05 Juanma Barranquero <lekktu@gmail.com>
117
118 * lisp.h (process_quit_flag): Fix external declaration.
119
6d5eb5b0
SM
1202011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
121
122 Don't macro-inline non-performance-critical code.
123 * eval.c (process_quit_flag): New function.
124 * lisp.h (QUIT): Use it.
125
a0c3fad0
JD
1262011-12-04 Jan Djärv <jan.h.d@swipnet.se>
127
128 * nsfns.m (get_geometry_from_preferences): New function.
129 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
130
6c07aac2
AS
1312011-12-04 Andreas Schwab <schwab@linux-m68k.org>
132
133 * emacs.c (Qkill_emacs): Define.
134 (syms_of_emacs): Initialize it.
135 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
136 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
137 (quit_throw_to_read_char): Add parameter `from_signal'.
138 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
139 * lisp.h (QUIT): Call Fkill_emacs if requested.
140
c052ead4
JD
1412011-12-03 Jan Djärv <jan.h.d@swipnet.se>
142
143 * widget.c (update_wm_hints): Return if wmshell is null.
144 (widget_update_wm_size_hints): New function.
145
146 * widget.h (widget_update_wm_size_hints): Declare.
147
148 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
149 widget_update_wm_size_hints (Bug#10104).
150
9e49252b
EZ
1512011-12-03 Eli Zaretskii <eliz@gnu.org>
152
153 * xdisp.c (handle_invisible_prop): If the invisible text ends just
154 before a newline, prepare the bidi iterator for consuming the
155 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 156 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 157
02b16839
JL
1582011-12-02 Juri Linkov <juri@jurta.org>
159
160 * search.c (Fword_search_regexp): New Lisp function created from
161 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
162 (Fword_search_backward, Fword_search_forward)
163 (Fword_search_backward_lax, Fword_search_forward_lax):
164 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
165 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
166
0068070e
SM
1672011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
168
169 * fileio.c (Finsert_file_contents): Move after-change-function call
170 to before the "handled:" label, since all "goto handled" appear in
171 cases where the *-change-functions have already been properly called
172 (bug#10117).
173
3360a3fc
AS
1742011-12-01 Andreas Schwab <schwab@linux-m68k.org>
175
176 * keyboard.c (interrupt_signal): Don't call kill-emacs when
177 waiting for input. (Bug#10169)
178
73d6c093
EZ
1792011-11-30 Eli Zaretskii <eliz@gnu.org>
180
181 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
182 verifies glyph row's hash code--we have just reallocated the
183 glyphs, so their contents can be complete garbage. (Bug#10164)
184
febe6bea
JB
1852011-11-30 Juanma Barranquero <lekktu@gmail.com>
186
187 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
188
801a4313
EZ
1892011-11-30 Eli Zaretskii <eliz@gnu.org>
190
191 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
192 attributes are tested _before_ calling verify_row_hash, to protect
193 against GCC re-ordering of the tests. (Bug#10164)
194
2b56b87e
JD
1952011-11-29 Jan Djärv <jan.h.d@swipnet.se>
196
197 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
198
199 * xterm.c (handle_one_xevent): Only set async_visible and friends
200 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 201 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
202 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
203
dbf31225
PE
2042011-11-28 Paul Eggert <eggert@cs.ucla.edu>
205
206 Remove GCPRO-related macros that exist only to avoid shadowing locals.
207 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
208 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
209 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
210 All uses changed to use GCPRO1 etc.
211 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
212 Revert to old implementation (i.e., before 2011-03-11).
213
1305621b
YM
2142011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
215
216 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
217 of scroll runs so as to avoid assigning disabled bogus rows and
218 unnecessary graphics copy operations.
219
8c9afb46
EZ
2202011-11-27 Eli Zaretskii <eliz@gnu.org>
221
222 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
223 (snprintf) [_MSC_VER]: Redirect to _snprintf.
224 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
225 (malloc, free, realloc, calloc): Redirect to e_* only when
226 compiling Emacs.
227
228 * lisp.h (GCTYPEBITS): Move before first use.
229 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
230 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
231 this macro definition.
232
233 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
234 _MSC_VER.
235
54e9e3bf
JD
2362011-11-27 Jan Djärv <jan.h.d@swipnet.se>
237
6d5eb5b0
SM
238 * gtkutil.c (xg_create_frame_widgets):
239 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
240 present with Gtk+ 2.0.
241
83aca1cb
PE
2422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
243
244 * fileio.c (Finsert_file_contents): Undo previous change; see
245 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
246
5b76caa4
PE
2472011-11-26 Paul Eggert <eggert@cs.ucla.edu>
248
249 Rename locals to avoid shadowing.
250 * fileio.c (Finsert_file_contents):
251 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
252 * process.c (wait_reading_process_output):
253 Rename inner 'proc' to 'p' to avoid shadowing.
254 Indent for consistency with usual Emacs style.
255
8c535114
EZ
2562011-11-25 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (redisplay_window): If cursor row is not fully visible
259 after recentering, and scroll-conservatively is set to a large
260 number, scroll window by a few more lines to make the cursor fully
261 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
262 (start_display): Don't move to the next line if the display should
263 start at a newline that is part of a display vector or an overlay
264 string. (Bug#10119)
8c535114 265
fa4fdb5c
JL
2662011-11-24 Juri Linkov <juri@jurta.org>
267
268 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
269 after the `MagickPingImage' call. (Bug#10112)
270
90ec88df
CY
2712011-11-23 Chong Yidong <cyd@gnu.org>
272
273 * window.c (Fcoordinates_in_window_p): Accept only live windows.
274
56e2e794
MR
2752011-11-23 Martin Rudalics <rudalics@gmx.at>
276
277 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
278 making another buffer current. (Bug#10114)
279
b6e64c41
GM
2802011-11-23 Glenn Morris <rgm@gnu.org>
281
282 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
283
6b21de18
CY
2842011-11-23 Chong Yidong <cyd@gnu.org>
285
286 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
287 using it (Bug#5984).
288
b12cd789
EZ
2892011-11-22 Eli Zaretskii <eliz@gnu.org>
290
291 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
292 and header-lines, as they don't have one computed for them.
293 (Bug#10098)
294
295 * .gdbinit (prow): Make displayed values more self-explaining.
296 Add row's hash code.
297
261b6fd4
LMI
2982011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
299
300 * process.c (wait_reading_process_output): Fix asynchrounous
301 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 302 (wait_reading_process_output): Add comment and URL.
261b6fd4 303
e7cfd277
JD
3042011-11-21 Jan Djärv <jan.h.d@swipnet.se>
305
306 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
307
a9b9b7f5
CY
3082011-11-21 Chong Yidong <cyd@gnu.org>
309
310 * window.c (Fnext_window, Fprevious_window): Doc fix.
311
b0d15b4f
SM
3122011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
313
314 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
315
fe7a3057
JB
3162011-11-20 Juanma Barranquero <lekktu@gmail.com>
317
318 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
319
d2999b1a
MR
3202011-11-20 Martin Rudalics <rudalics@gmx.at>
321
322 * window.c (Fset_window_combination_limit): Rename argument
323 STATUS to LIMIT.
324 (Vwindow_combination_limit): Remove "status" from doc-string.
325
d5ff9cd0
AS
3262011-11-20 Andreas Schwab <schwab@linux-m68k.org>
327
328 * m/ibms390.h: Remove.
329 * m/ibms390x.h: Don't include "ibms390.h".
330
a5bb9bd3
SM
3312011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
332
333 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
334 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
335
cd1181db
JB
3362011-11-20 Juanma Barranquero <lekktu@gmail.com>
337
338 * casetab.c (Fset_case_table):
339 * charset.c (Fcharset_after): Fix typos.
340
615a3b8d 3412011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 342
17e845af
PE
343 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
344 Otherwise, valgrind does not work on some platforms.
345 Problem reported by Andreas Schwab in
6a0bf43d
PE
346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
347 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
348 is set, removing the need for VIRT_ADDRESS_VARIES.
349 (PURE_P): Use a more-efficient implementation that needs just one
350 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
351 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
352 to 4 (xorl, subq, cmpq, setbe).
353 * alloc.c (pure): Always extern now, since that's the
354 VIRT_ADDR_VARIES behavior.
355 (PURE_POINTER_P): Use a single comparison, not two, for
356 consistency with the new puresize.h.
357 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
358 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
359 Remove VIRT_ADDR_VARIES no longer needed.
360
f8fe6f96
EZ
3612011-11-19 Eli Zaretskii <eliz@gnu.org>
362
363 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
364 (erase_phys_cursor, update_window_cursor, show_mouse_face)
365 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
366 behave as if the cursor position were at the window margin.
367
368 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
369 and the cursor position is out of bounds, behave as if the cursor
370 position were at the window margin. (Bug#10075)
371
df05a53c
CY
3722011-11-18 Chong Yidong <cyd@gnu.org>
373
374 * window.c (Fwindow_combination_limit): Make first argument
375 non-optional, since it is meaningless for live windows like the
376 selected window.
377
2071918e
DA
3782011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
379
380 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
381
b50a28de
SM
3822011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
383
384 * intervals.c: Fix grafting over the whole buffer (bug#10071).
385 (graft_intervals_into_buffer): Simplify.
386
015137db
EZ
3872011-11-18 Eli Zaretskii <eliz@gnu.org>
388
389 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
390 hash values of the two rows.
391 (copy_row_except_pointers): Preserve the used[] arrays and the
392 hash values of the two rows. (Bug#10035)
68c95424 393 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
394
395 * xdisp.c (row_hash): New function, body extracted from
396 compute_line_metrics.
397 (compute_line_metrics): Call row_hash, instead of computing the
398 hash code inline.
399
400 * dispnew.c (verify_row_hash): Call row_hash for computing the
401 hash code of a row, instead of duplicating code from xdisp.c.
402
403 * dispextern.h (row_hash): Add prototype.
404
a2addb04
TH
4052011-11-18 Tassilo Horn <tassilo@member.fsf.org>
406
407 * frame.c (delete_frame): Don't delete the terminal when the last
408 X frame is closed if emacs is built with GTK toolkit.
409
df85d315
JB
4102011-11-17 Juanma Barranquero <lekktu@gmail.com>
411
412 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
413
a0c2d0ae
MR
4142011-11-17 Martin Rudalics <rudalics@gmx.at>
415
416 * window.c (Vwindow_splits): Rename to
417 Vwindow_combination_resize. Suggested by Juri Linkov.
418 (Fsplit_window_internal): Use Vwindow_combination_resize instead
419 of Vwindow_splits.
420
58179cce
JB
4212011-11-16 Juanma Barranquero <lekktu@gmail.com>
422
7877f373
JB
423 * nsfns.m (Fns_font_name):
424 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 425
b6f67890
MR
4262011-11-16 Martin Rudalics <rudalics@gmx.at>
427
428 * window.h (window): Rename slot "nest" to "combination_limit".
429 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
430 (Fset_window_nest): Rename to Fset_window_combination_limit.
431 (Vwindow_nest): Rename to Vwindow_combination_limit.
432 (recombine_windows, make_parent_window, make_window)
433 (Fsplit_window_internal, saved_window)
434 (Fset_window_configuration, save_window_save): Rename all
435 occurrences of window_nest to window_combination_limit.
436
c7015153
JB
4372011-11-15 Juanma Barranquero <lekktu@gmail.com>
438
439 * image.c (imagemagick_load_image): Fix typo.
440
322ad6ec
EZ
4412011-11-14 Eli Zaretskii <eliz@gnu.org>
442
443 * xdisp.c (display_line): Move the call to
444 highlight_trailing_whitespace before the call to
445 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
446 faces of all the glyphs to compute ROW's hash value.
447 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 448
f067b8ec
JB
4492011-11-14 Juanma Barranquero <lekktu@gmail.com>
450
451 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
452 just return (bug#10044).
453
1e5b2111
EZ
4542011-11-12 Eli Zaretskii <eliz@gnu.org>
455
7ef3cbd5
EZ
456 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
457 with user-defined heap size. Bump the default size of the temacs
458 heap to 27MB, to avoid memory warning when running temacs.
459 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
460
1e5b2111
EZ
461 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
462 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
463 (verify_row_hash) [XASSERTS]: New function.
464 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
465 that the hash value of glyph rows is correct.
1e5b2111 466
89d61221
MR
4672011-11-12 Martin Rudalics <rudalics@gmx.at>
468
469 * window.h (window): Remove splits slot.
470 * window.c (Fwindow_splits, Fset_window_splits): Remove.
471 (Fdelete_other_windows_internal, make_parent_window)
472 (make_window, Fsplit_window_internal, Fdelete_window_internal)
473 (Fset_window_configuration, save_window_save): Don't deal with
474 split status of windows.
475 (saved_window): Remove splits slot.
476 (Vwindow_splits): Rewrite doc-string.
477
97f18cc8
JD
4782011-11-11 Jan Djärv <jan.h.d@swipnet.se>
479
480 * xfns.c (unwind_create_frame):
481 * nsfns.m (unwind_create_frame):
482 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
483 Vframe_list (Bug#9999).
484
22a648b4
DA
4852011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
486
0b381c7e 487 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 488
659afede
KH
4892011-11-11 Kenichi Handa <handa@m17n.org>
490
491 * callproc.c (Fcall_process): Set the member dst_multibyte of
492 process_coding.
493
9ac0394b
KH
4942011-11-11 Johan Bockgård <bojohan@gnu.org>
495
496 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
497 avoid a crash (bug#9496).
498
2fbdc249
CY
4992011-11-09 Chong Yidong <cyd@gnu.org>
500
501 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
502 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
503
ac6b1f81
PE
5042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
505
506 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
507
09db192c
PE
5082011-11-08 Paul Eggert <eggert@cs.ucla.edu>
509
510 Avoid some portability problems by eschewing 'extern inline' functions.
511 The trivial performance wins aren't worth the portability hassles; see
512 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
513 et seq.
514 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
515 (window_box_width, window_box_left, window_box_left_offset)
516 (window_box_right, window_box_right_offset): Undo previous change,
517 by removing the "extern"s.
518 * intervals.c (adjust_intervals_for_insertion)
519 (adjust_intervals_for_deletion): Undo previous change,
520 making these static again.
521 (offset_intervals, temp_set_point_both, temp_set_point)
522 (copy_intervals_to_string): No longer inline.
523 * xdisp.c (window_text_bottom_y, window_box_width)
524 (window_box_height, window_box_left_offset)
525 (window_box_right_offset, window_box_left, window_box_right)
526 (window_box): No longer inline.
527
105216ed
CY
5282011-11-08 Chong Yidong <cyd@gnu.org>
529
530 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
531 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
532 Signal an error if not a live window.
105216ed
CY
533 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
534 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
535
ae9e237f
JB
5362011-11-07 Juanma Barranquero <lekktu@gmail.com>
537
538 * lisp.h (syms_of_abbrev): Remove declaration.
539 Reported by CHENG Gao <chenggao@royau.me>.
540
c7aa8333
EZ
5412011-11-07 Eli Zaretskii <eliz@gnu.org>
542
543 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
544 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
545 of temacs in GUI mode.
546
be7f5545
MR
5472011-11-07 Martin Rudalics <rudalics@gmx.at>
548
549 * window.h: Declare delete_all_child_windows instead of
550 delete_all_subwindows.
551 * window.c (Fwindow_nest, Fset_window_nest)
552 (Fset_window_new_total, Fset_window_new_normal)
553 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
554 (delete_all_subwindows): Rename to delete_all_child_windows.
555 (Fdelete_other_windows_internal, Fset_window_configuration):
556 Call delete_all_child_windows instead of delete_all_subwindows.
557 * frame.c (delete_frame): Call delete_all_child_windows instead
558 of delete_all_subwindows.
559
ca78dc43
PE
5602011-11-07 Paul Eggert <eggert@cs.ucla.edu>
561
562 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
563 This is also needed for porting to any host where GC_MARK_STACK is
564 not GC_MAKE_GCPROS_NOOPS.
565 (which_symbols): Use it.
566
a0241d01
KH
5672011-11-07 Kenichi Handa <handa@m17n.org>
568
569 * coding.c (coding_set_destination): Check coding->src_pos only
570 when coding->src_object is a buffer (bug#9910).
571
572 * process.c (send_process): Set the member src_multibyte of coding
573 to 0 (bug#9911) when sending a unibyte text.
574
575 * callproc.c (Fcall_process): Set the member src_multibyte of
576 process_coding to 0 (bug#9912).
577
a64bfdfa 5782011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
579
580 * xmenu.c (cleanup_widget_value_tree): New function.
581 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
582 calling free_menubar_widget_value_tree directly (Bug#9830).
583
cb41b32a
PE
5842011-11-06 Paul Eggert <eggert@cs.ucla.edu>
585
586 Fix some portability problems with 'inline'.
587 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
588 (window_box_width, window_box_left, window_box_left_offset)
589 (window_box_right, window_box_right_offset): Declare extern.
590 Otherwise, these inline functions do not conform to C99 and
591 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
592 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
593 * intervals.c (adjust_intervals_for_insertion)
594 (adjust_intervals_for_deletion): Now extern, because otherwise the
595 extern inline functions 'offset_intervals' couldn't refer to it.
596 (static_offset_intervals): Remove.
597 (offset_intervals): Rewrite using the old contents of
598 static_offset_intervals. The old version didn't conform to C99
599 because an extern inline function contained a reference to an
600 identifier with static linkage.
601
b7041366
AS
6022011-11-06 Andreas Schwab <schwab@linux-m68k.org>
603
604 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
605 GC.
606
88a37c4d
EZ
6072011-11-06 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (init_iterator, reseat_to_string): Don't set the
610 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
611 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
612 return Qleft_to_right.
613
49745b39
CY
6142011-11-06 Chong Yidong <cyd@gnu.org>
615
616 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
617 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
618 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
619 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
620 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
621 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
622 (Fwindow_vscroll): Doc fix.
623 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
624 argument, since it makes no sense to pass a live window and for
625 consistency with window-child.
626
1f05cd82
CS
6272011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
628
629 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
630 support MSVC.
631
22610910
JR
6322011-11-05 Jason Rumney <jasonr@gnu.org>
633
634 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
635 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
636 fonts (Bug#6029).
637 (add_font_entity_to_list): Fix logic errors in mixed boolean and
638 bitwise arithmetic preventing use of unicode-sip and non-truetype
639 opentype fonts.
640
a06776b2
EZ
6412011-11-05 Eli Zaretskii <eliz@gnu.org>
642
3ad924ba
EZ
643 * s/ms-w32.h (fstat, stat, utime): Move redirections to
644 "emacs"-only part.
645
a06776b2
EZ
646 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
647 initialization code to keep similarity to xfns.c after changes
648 from 2011-11-05.
649
c9e7db78
JD
6502011-11-05 Jan Djärv <jan.h.d@swipnet.se>
651
a97f8f3f
JD
652 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
653 (unwind_create_frame): New function (Bug#9943).
654 (Fx_create_frame): Restructure code to be more similar to the one in
655 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
656 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
657 Move terminal->reference_count++ just before making the frame official
658 (Bug#9943).
659
660 * nsterm.m (x_free_frame_resources): New function.
661 (x_destroy_window): Move code to x_free_frame_resources.
662
c9e7db78 663 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
664 (Fx_create_frame, x_create_tip_frame):
665 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
666 official. Move initialization of image_cache_refcount and
667 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
668
a6fc3b5c
EZ
6692011-11-05 Eli Zaretskii <eliz@gnu.org>
670
671 Support MSVC build with newer versions of Visual Studio.
672 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
673 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
674 nt/gmake.defs.
675
676 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
677 which are not supported by MSVC.
678 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
679 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
680 bitfields.
681 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
682 types in bitfields.
683 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
684
685 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
686
58179cce 6872011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
688
689 Support MSVC build with newer versions of Visual Studio.
690 * w32.c: Don't include w32api.h for MSVC.
691 (init_environment) [_MSC_VER]: Call sys_access, not _access.
692
693 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
694 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
695 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
696 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
697 e_* cousins.
698 (alloca) [_MSC_VER]: Define to _alloca.
699
700 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
701
702 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
703
a58c13ed
EZ
7042011-11-04 Eli Zaretskii <eliz@gnu.org>
705
706 * xdisp.c (note_mouse_highlight): If either of
707 previous/next-single-property-change returns nil, treat that as
708 the beginning or the end of the buffer. (Bug#9955)
709
fe0b6370
JD
7102011-11-04 Jan Djärv <jan.h.d@swipnet.se>
711
a58c13ed 712 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
713 label is not null (Bug#9951).
714 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
715 may be NULL.
716
89bd5ee1
EZ
7172011-11-04 Eli Zaretskii <eliz@gnu.org>
718
719 * window.c (Fwindow_body_size): Mention in the doc string that the
720 return value is in frame's canonical units. (Bug#9949)
721
84c3edb9
EZ
7222011-11-03 Eli Zaretskii <eliz@gnu.org>
723
4e2fb5c7
EZ
724 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
725
84c3edb9 726 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 727 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 728 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 729
bc17a887
EZ
7302011-11-01 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
733 Don't stop backward scan on the continuation glyph, even though
734 its CHARPOS is positive.
6d5eb5b0
SM
735 (mouse_face_from_buffer_pos, note_mouse_highlight):
736 Rename cover_string to disp_string.
bc17a887 737
4ee88440
MR
7382011-11-01 Martin Rudalics <rudalics@gmx.at>
739
740 * window.c (temp_output_buffer_show): Don't use
741 Vtemp_buffer_show_specifiers.
742 (Vtemp_buffer_show_specifiers): Remove unused variable.
743
c2ff3c02
EZ
7442011-10-30 Eli Zaretskii <eliz@gnu.org>
745
746 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
747 past the beginning of the current glyph matrix.
748
58179cce 7492011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
750
751 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
752 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
753 HAVE_GTK3 (Bug#9869).
b77a6a7f 754
3b574623
JD
755 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
756 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
757
b77a6a7f
JD
758 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
759
760 * xterm.c: Declare x_handle_net_wm_state to return int.
761 (handle_one_xevent): Check if we are iconified but don't have
762 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
763 (get_current_wm_state): Return non-zero if not hidden,
764 check for _NET_WM_STATE_HIDDEN (Bug#9893).
765 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
766 (x_handle_net_wm_state): Return what get_current_wm_state returns.
767 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
768
196e41e4
PE
7692011-10-29 Paul Eggert <eggert@cs.ucla.edu>
770
771 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
772 so that this new function doesn't get optimized away by a
773 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
774
021f2e1a
AS
7752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
776
777 * frame.h (MOUSE_HL_INFO): Remove excess parens.
778
8b058d44
EZ
7792011-10-29 Eli Zaretskii <eliz@gnu.org>
780
781 Fix the `xbytecode' command.
782 * .gdbinit (xprintbytestr): New command.
b50a28de 783 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
784 (xbytecode): Print the byte-code string as well.
785
4452fb80
EZ
7862011-10-29 Kim Storm <storm@cua.dk>
787
8b058d44
EZ
788 * alloc.c (which_symbols): New function.
789
21b72067
AS
7902011-10-29 Andreas Schwab <schwab@linux-m68k.org>
791
792 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
793 line. (Bug#9903)
794
83ed7b5c
GM
7952011-10-29 Glenn Morris <rgm@gnu.org>
796
797 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
798 Not clear what it was for, and it causes various bugs. (Bug#9839)
799
5a7a728b
EZ
8002011-10-28 Eli Zaretskii <eliz@gnu.org>
801
802 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
803 possible random value that matches one of those tested as
804 condition to clear the mouse face.
805
d3d0842f
CY
8062011-10-28 Chong Yidong <cyd@gnu.org>
807
808 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
809
31b39d13
DN
8102011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
811
812 * window.c (make_window): Initialize phys_cursor_on_p.
813
9aba6043
SM
8142011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
815
816 * lisp.h (struct Lisp_Symbol): Update comments.
817
c20992f4
JB
8182011-10-28 Juanma Barranquero <lekktu@gmail.com>
819
820 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
821
db4f02f2
EZ
8222011-10-28 Eli Zaretskii <eliz@gnu.org>
823
824 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
825 <oslsachem@gmail.com> for helping to debug this.
826
827 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
828 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
829 (g_b_init_get_glyph_outline_w): New static variables.
830 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
831 (GetGlyphOutlineW_Proc): New typedefs.
832 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
833 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
834 New functions.
835 (w32font_open_internal, compute_metrics):
836 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
837 instead of calling the "wide" APIs directly.
838
839 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
840
841 * w32.h (syms_of_w32font): Add prototype.
842
87e68db4
JB
8432011-10-27 Juanma Barranquero <lekktu@gmail.com>
844
845 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
846 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
847 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
848 (Fmove_to_window_line): Doc fix.
849
435c1d67
CY
8502011-10-27 Chong Yidong <cyd@gnu.org>
851
852 * process.c (make_process): Set gnutls_state to NULL.
853
854 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
855 non-NULL, regardless of GNUTLS_INITSTAGE.
856 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
857 an error. Set process slots as soon as we allocate them.
858
859 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
860
9c6c6f49
CY
8612011-10-27 Chong Yidong <cyd@gnu.org>
862
9aba6043
SM
863 * gnutls.c (emacs_gnutls_deinit): New function.
864 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
865 (Fgnutls_deinit, Fgnutls_boot): Use it.
866
867 * process.c (make_process): Initialize GnuTLS credentials to NULL.
868 (deactivate_process): Call emacs_gnutls_deinit.
869
657d08d3
JB
8702011-10-27 Juanma Barranquero <lekktu@gmail.com>
871
872 * image.c (x_create_x_image_and_pixmap):
873 * w32.c (sys_rename, w32_delayed_load):
874 * w32font.c (fill_in_logfont):
875 * w32reg.c (x_get_string_resource): Silence compiler warnings.
876
5430d399
JB
8772011-10-26 Juanma Barranquero <lekktu@gmail.com>
878
879 * w32fns.c (w32_default_color_map): New function,
880 extracted from Fw32_default_color_map.
a7ef684b 881 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 882
fe0055fa
PE
8832011-10-25 Paul Eggert <eggert@cs.ucla.edu>
884
885 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
886
e6346438
SM
8872011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
888
889 * keyboard.c (test_undefined): New function (bug#9751).
890 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
891
e112cc37
ET
8922011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
893
894 * sysdep.c (init_sys_modes): Fix the check for the controlling
895 terminal (Bug#6649).
896
7b5d6677
EZ
8972011-10-20 Eli Zaretskii <eliz@gnu.org>
898
899 * dispextern.h (struct bidi_it): New member next_en_type.
900
901 * bidi.c (bidi_line_init): Initialize the next_en_type member.
902 (bidi_resolve_explicit_1): When next_en_pos is valid for the
903 current character, check also for next_en_type being WEAK_EN.
904 (bidi_resolve_weak): Don't enter the expensive loop if the current
905 position is before next_en_pos. Record the bidi type of the first
906 non-ET, non-BN character we find, in addition to its position.
907 (bidi_level_of_next_char): Invalidate next_en_type when
908 next_en_pos is over-stepped.
909
7da0b018
PE
9102011-10-20 Paul Eggert <eggert@cs.ucla.edu>
911
912 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
913 * editfns.c: Rewrite current-time-zone so that it invokes
914 the equivalent of (format-time-string "%Z") to get the time zone name.
915 This fixes a bug when the time zone name contains characters that
916 need converting from the system time locale to Emacs internal format.
917 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
918 that patch fixed format-time-string to do the conversion, but
919 I forgot to fix current-time-zone.
920 (format_time_string): New function, containing most of
921 what Fformat_time_string used to contain.
922 (Fformat_time_string): Rewrite in terms of format_time_string.
923 This doesn't change this function's behavior.
924 (current-time-zone): Rewrite to use format_time_string.
925 This fixes the bug reported by Michael Schierl in
926 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
927 Jason Rumney's 2007-06-07 change worked around this bug, but
928 didn't fix it.
929 * systime.h (tzname, timezone): Remove no-longer-used declarations.
930
8547b010
EZ
9312011-10-19 Eli Zaretskii <eliz@gnu.org>
932
933 * xdisp.c (start_display): If the character at POS is displayed
934 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
935 (try_window_reusing_current_matrix): If a line ends in a display
936 vector or the next line starts in a display vector, continue
937 redrawing the window even though the character position of
938 start_row was reached.
8547b010
EZ
939 (Bug#9771, part 2)
940
4e948d15
CY
9412011-10-18 Chong Yidong <cyd@gnu.org>
942
943 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
944 with nobreak-char-display too.
945
4787455f
EZ
9462011-10-18 Eli Zaretskii <eliz@gnu.org>
947
948 Fix part 3 of bug#9771.
949 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
950 (bidi_resolve_neutral): Don't enter the expensive loop looking for
951 non-neutral characters if the current character is a paragraph
952 separator (a.k.a. Newline). This avoids running the same
953 expensive loop twice, once when we consume the preceding newline
954 and the other time when the line actually needs to be displayed.
955 Avoid the loop when we see neutrals on the base embedding level
956 following a character whose directionality is the same as the
957 paragraph's. This avoids running the expensive loop when a line
958 ends in a long sequence of neutrals, like control characters.
959 Add assertion against STRONG_AL type. Slightly rearrange code
960 that determines the type of a neutral given the first non-neutral
961 that follows it.
962 (bidi_level_of_next_char): Set next_en_pos to zero when
963 invalidating its info.
964
2c91f553
EZ
9652011-10-17 Eli Zaretskii <eliz@gnu.org>
966
967 * xdisp.c (push_display_prop): Determine whether to record string
968 or buffer position by IT->string, not by IT->method. Allow
969 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
970 (move_it_vertically_backward): Don't look for character position
971 immediately after the newline when in a continuation line.
972 (Bug#9771, part 1)
2c91f553 973
c7b08b0d
MR
9742011-10-15 Martin Rudalics <rudalics@gmx.at>
975
976 * window.c (coordinates_in_window): Rewrite and delabelize
977 vertical border check. (Bug#5357) (Bug#9618)
978
6b02f655
SM
9792011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
980
981 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
982 errors in XSetWindowBorder (bug#9310).
983
81d40c92
DA
9842011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
985
986 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
987 avoid crash when xmalloc overrun checking is enabled.
988
d4172c3b
EZ
9892011-10-13 Eli Zaretskii <eliz@gnu.org>
990
991 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
992 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
993 cursor motion with <left> and <right> arrow keys.
994
995 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
996 some callers set that themselves.
997
b00eea75
EZ
9982011-10-12 Eli Zaretskii <eliz@gnu.org>
999
1000 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1001 display string and the previous row comes from the same string and
1002 is empty. (Bug#9739) (Bug#9738)
1003
8fe012c4
SM
10042011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1005
1006 * doc.c (get_doc_string): Encode file name (bug#9735).
1007
0074aef2
EZ
10082011-10-12 Eli Zaretskii <eliz@gnu.org>
1009
79beb178
EZ
1010 * bidi.c (bidi_level_of_next_char):
1011 * xdisp.c (get_visually_first_element): Remove old incorrect
1012 comments regarding the Unicode Line Separator character.
1013
0074aef2
EZ
1014 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1015
6e4b3fbe
DA
10162011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1017
1018 * alloc.c (Fgc_status): Do not access beyond zombies array
1019 boundary if nzombies > MAX_ZOMBIES.
1020 * alloc.c (dump_zombies): Add missing format specifier.
1021
0324f3af
PE
10222011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1023
b5525cac
PE
1024 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1025 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1026
0324f3af
PE
1027 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1028 Some packages use them to denote characters with modifiers.
1029
e9b5f888
AS
10302011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1031
1032 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1033 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1034 matching a pp-number. Rename parameter var to var1.
1035
127827c0
SM
10362011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1037
1038 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1039
c8fd3bd0
GM
10402011-10-08 Glenn Morris <rgm@gnu.org>
1041
1042 * callint.c (Fcall_interactively): Give a more explicit error for the
1043 'c' case with a non-character input. (Bug#8479)
1044
352ec8ff
EZ
10452011-10-08 Eli Zaretskii <eliz@gnu.org>
1046
03669ccb
EZ
1047 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1048 lines.
7061c986
EZ
1049 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1050 lines that are hscrolled on the left.
03669ccb 1051
352ec8ff
EZ
1052 * dispnew.c (buffer_posn_from_coords): Account for a possible
1053 presence of header-line. (Bug#4426)
1054
a66cfb1c
SM
10552011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1056
6b02f655
SM
1057 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1058 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1059
7c5ee88e
PE
10602011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1063 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1064 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1065 this makes Emacs dump core during garbage collection on rare
1066 occasions. sizeof is obviously inferior to offsetof here, so
1067 stick with offsetof.
1068 (GC_POINTER_ALIGNMENT): New macro.
1069 (mark_memory): Omit 3rd (offset) arg; caller changed.
1070 Don't assume EMACS_INT alignment is the same as pointer alignment.
1071
df1bbe5b
SM
10722011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1073
1074 * keyboard.c (read_key_sequence_remapped): New var.
1075 (read_key_sequence): Compute remapping in the right buffer.
1076 (command_loop_1): Use read_key_sequence's remapping directly.
1077
51553db6
SM
10782011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1079
32c1fffd
SM
1080 * dired.c (file_name_completion): Don't expand file name.
1081 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1082 before checking file name handler.
1083
51553db6
SM
1084 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1085 they've been requested explicitly (bug#9591).
1086
b6bd1599 10872011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1088
1089 * keymap.c (Fsingle_key_description): Use make_specified_string
1090 instead of build_string to build string from push_key_description.
1091 (Bug#5193)
1092
f701dc2a
PE
10932011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1094
4222c55d
PE
1095 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1096 This fixes a Y2038 bug on 64-bit hosts.
1097 * buffer.c (reset_buffer):
1098 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1099 (Fclear_buffer_auto_save_failure):
1100 Use 0, not -1, to represent an unset failure time, since time_t
1101 might not be signed.
1102
f701dc2a
PE
1103 Remove dependency on glibc malloc internals.
1104 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1105 Move back here from lisp.h, but with their new implementations.
1106 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1107 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1108 * charset.c (charset_table_init): New static var.
1109 (syms_of_charset): Use it instead of xmalloc. This removes a
1110 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1111 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1112 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1113 Move back to alloc.c.
1114 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1115 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1116
9ceebf39
JD
11172011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1118
1119 * nsterm.m (windowDidResize): Call x_set_window_size only when
1120 ns_in_resize is true. Otherwise set pixelwidth/height and
1121 call change_frame_size (Bug#9628).
1122
cb993c58
PE
11232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1124
3930c88b
PE
1125 Port --enable-checking=all to Fedora 14 x86-64.
1126 * charset.c (syms_of_charset): Also account for glibc malloc's
1127 internal overhead when calculating the initial malloc maximum.
1128
cb993c58
PE
1129 Port --enable-checking=all to Fedora 14 x86.
1130 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1131 Move to lisp.h.
1132 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1133 (overrun_check_realloc, overrun_check_free):
1134 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1135 That way, xmalloc returns a properly-aligned pointer even if
1136 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1137 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1138 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1139 into account when calculating the initial malloc maximum.
1140 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1141 Move here from alloc.c, so that charset.c can use it too.
1142 Properly align; the old code wasn't right for common 32-bit hosts
1143 when configured with --enable-checking=all.
1144 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1145 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1146
31bed486
EZ
11472011-09-29 Eli Zaretskii <eliz@gnu.org>
1148
04c70788 1149 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1150 use EDOM.
1151
fbcaa2f3
EZ
11522011-09-28 Eli Zaretskii <eliz@gnu.org>
1153
1154 * xdisp.c (compute_display_string_end): If there's no display
1155 string at CHARPOS, return -1.
1156
1157 * bidi.c (bidi_fetch_char): When compute_display_string_end
1158 returns a negative value, treat the character as a normal
1159 character not covered by a display string. (Bug#9624)
1160
a239d4e9
JB
11612011-09-28 Juanma Barranquero <lekktu@gmail.com>
1162
1163 * lread.c (Fread_from_string): Fix typo in docstring.
1164
88652fd5
EZ
11652011-09-27 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1168 newline, reseat the iterator instead of bidi-iterating there one
1169 character at a time. (Bug#9610)
32c1fffd
SM
1170 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1171 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1172
ed497dd4
AS
11732011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1174
1175 * lread.c (readevalloop): Use correct code for NBSP.
1176 (read1): Likewise. (Bug#9608)
1177
b2bf61aa
MA
11782011-09-25 Michael Albinus <michael.albinus@gmx.de>
1179
1180 * dbusbind.c (Fdbus_register_signal): When service is not
1181 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1182
32bbb17c
GM
11832011-09-25 Glenn Morris <rgm@gnu.org>
1184
1185 * buffer.c (truncate-lines): Doc fix.
1186
94e0933e
CY
11872011-09-24 Chong Yidong <cyd@stupidchicken.com>
1188
1189 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1190 (Fset_window_next_buffers): Doc fix.
1191
cddde921
GM
11922011-09-24 Glenn Morris <rgm@gnu.org>
1193
1194 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1195
1260aef1
PE
11962011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1197
25b4bfa0
PE
1198 Fix minor problems found by static checking.
1199 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1200 * indent.c (Fvertical_motion): Fix == vs = typo.
1201
e3cbd34b
EZ
12022011-09-24 Eli Zaretskii <eliz@gnu.org>
1203
a66cfb1c
SM
1204 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1205 Default value is now t. Doc fix.
6bf7006f 1206
e3cbd34b 1207 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1208 logic when moving up, not only when moving down. Fix the
e3cbd34b 1209 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1210 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1211
1212 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1213 CHARPOS is covered by a display string which includes newlines.
1214 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1215 is covered by a display string with embedded newlines.
1216
a3de0cbd
MA
12172011-09-24 Michael Albinus <michael.albinus@gmx.de>
1218
1219 * dbusbind.c (Fdbus_register_signal): Add match rule to
1220 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1221 (Fdbus_register_method, Vdbus_registered_objects_table):
1222 Fix docstring.
a3de0cbd 1223
b260039d
JM
12242011-09-24 Jim Meyering <meyering@redhat.com>
1225
32c1fffd 1226 do not ignore write error for any output size
b260039d
JM
1227 The previous change was incomplete.
1228 While it makes emacs --batch detect the vast majority of stdout
1229 write failures, errors were still ignored whenever the output size is
1230 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1231 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1232 && echo FAIL: ignored write error
1233 FAIL: ignored write error
1234 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1235 && echo FAIL: ignored write error
1236 FAIL: ignored write error
1237 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1238
8eca8a7c
AS
12392011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1240
1241 * emacs.c (Fkill_emacs): In noninteractive mode exit
1242 non-successfully if a write error occurred on stdout. (Bug#9574)
1243
3341db62
EZ
12442011-09-21 Eli Zaretskii <eliz@gnu.org>
1245
1246 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1247 the xassert test.
1248
1249 * dispextern.h (struct it): Update the comment documenting what
1250 can it->OBJECT be.
1251
8c203dbf
EZ
12522011-09-20 Eli Zaretskii <eliz@gnu.org>
1253
1254 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1255 a display string, extend search for cursor position to end of row.
1256 (find_row_edges): If the row ends in a newline from a display
1257 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1258 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1259 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1260 non-empty line. Fixes confusing cursor motion with arrow keys at
1261 the beginning of a line that starts with whitespace.
8c203dbf 1262
a4824228
LMI
12632011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1264
1265 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1266 (bug#9493).
1267
33ed493b
CY
12682011-09-18 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1271 boolean (Bug#9154).
1272
56cd55c8
EZ
12732011-09-18 Eli Zaretskii <eliz@gnu.org>
1274
1275 * xdisp.c (display_line): Record maximum and minimum buffer
1276 positions even if no glyphs were produced (e.g., by a zero-width
1277 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1278 buffer positions that will be removed from the glyph row because
1279 they don't fit.
c02dcedf
EZ
1280 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1281 column is beyond frame width: don't subtract 1 "pixel" when
1282 computing width of the stretch.
3e62b7e0
EZ
1283 (reseat_at_next_visible_line_start): Undo the change made on
1284 2011-09-17 that saved paragraph information and restored it after
1285 the call to `reseat'. (Bug#9545)
56cd55c8 1286
5ed99d36 12872011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1288
1289 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1290 and turn window cursor on if cleared (Bug#9415).
1291
5ed99d36 12922011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1293
1294 * search.c (boyer_moore): Take unibyte characters from pattern
1295 literally. (Bug#9458)
1296
9bade7b2
EZ
12972011-09-18 Eli Zaretskii <eliz@gnu.org>
1298
1299 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1300
e5e9d610
PE
13012011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1302
87e4427a
PE
1303 Fix minor problem found by static checking.
1304 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1305 initialized, to pacify gcc -Wuninitialized.
1306
e5e9d610
PE
1307 * fileio.c: Report proper errno when syscall falls.
1308 (Finsert_file_contents): Save and restore errno,
1309 so that report_file_error outputs the correct diagnostic.
1310 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1311
a1674f0b
EZ
13122011-09-18 Eli Zaretskii <eliz@gnu.org>
1313
1314 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1315
fbfb6dd4
EZ
13162011-09-17 Eli Zaretskii <eliz@gnu.org>
1317
1318 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1319 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1320
bb187662
EZ
13212011-09-17 Eli Zaretskii <eliz@gnu.org>
1322
1137e8b8 1323 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1324 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1325
1326 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1327 (bidi_find_paragraph_start): Search back for paragraph beginning
1328 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1329 (bidi_move_to_visually_next): Only trigger paragraph-related
1330 computations when the last character is a newline or at EOB, not
1331 just any NEUTRAL_B. (Bug#9470)
1332
bb187662
EZ
1333 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1334 truncated lines if point is covered by a display string. (Bug#9524)
1335
2e621251
PE
13362011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1339 (cons_to_x_long): New function.
1340 (lisp_data_to_selection_data): Use it. Correct the test for
1341 short-versus-long data; it was negated. Break out of vector
1342 loop, for efficiency, when a long datum is discovered.
1343
91a15bc6
SM
13442011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1345
1346 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1347
b41c3a35
EZ
13482011-09-16 Eli Zaretskii <eliz@gnu.org>
1349
1350 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1351 GCC PR/17406) by declaring this function with external scope.
1352
7812ba2d
PE
13532011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1356 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1357
cf7edc2a
AS
13582011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1359
1360 * editfns.c (Fformat): Correctly handle text properties on "%%".
1361
bd01620e
EZ
13622011-09-15 Eli Zaretskii <eliz@gnu.org>
1363
1364 * xterm.c (x_draw_composite_glyph_string_foreground):
1365 * w32term.c (x_draw_composite_glyph_string_foreground):
1366 * term.c (encode_terminal_code):
1367 * composite.c (composition_update_it, get_composition_id):
1368 * xdisp.c (get_next_display_element)
1369 (fill_composite_glyph_string): Add comments about special meaning
1370 of TAB characters in a composition.
1371
a02719a3
PE
13722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1375 This occurs when processing a multibyte format.
1376 Problem reported by Wolfgang Jenker.
a02719a3 1377
72589a3c
JB
13782011-09-15 Johan Bockgård <bojohan@gnu.org>
1379
1380 * xdisp.c (try_cursor_movement): Only check for exact match if
1381 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1382
1c14176c
PE
13832011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 Remove unused external symbols.
1386 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1387 * xdisp.c (calc_pixel_width_or_height): Now static.
1388 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1389 * indent.c (check_display_width):
1390 * w32term.c: Fix comment to match code.
1391 * xterm.c, xterm.h (x_catching_errors): Remove.
1392
d2eea5b5
PE
13932011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1394
1395 * xselect.c: Use signed conversions more consistently (Bug#9498).
1396 (selection_data_to_lisp_data): Assume incoming selection data are
1397 signed integers, not unsigned. This is to be consistent with
1398 outgoing selection data, which was modified to use signed integers
1399 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1400 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1401 expects long, not unsigned long.
1402
46888499
EZ
14032011-09-14 Eli Zaretskii <eliz@gnu.org>
1404
1405 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1406 computation of loop end. Reported by Johan Bockgård
1407 <bojohan@gnu.org>.
1408
ef8ef9fb
CY
14092011-09-13 Chong Yidong <cyd@stupidchicken.com>
1410
1411 * frame.c (Fother_visible_frames_p): Function deleted.
1412
fa819fed
EZ
14132011-09-12 Eli Zaretskii <eliz@gnu.org>
1414
1415 * indent.c (compute_motion): Process display vector front to back
1416 rather than the other way around. (Bug#2496)
1417
2ba8e008
SM
14182011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1419
1420 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1421
20f53c69
CY
14222011-09-11 Chong Yidong <cyd@stupidchicken.com>
1423
1424 * minibuf.c (Fread_from_minibuffer): Doc fix.
1425
d562d7a4
EZ
14262011-09-11 Eli Zaretskii <eliz@gnu.org>
1427
1428 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1429 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1430
1c4d7f3d
LMI
14312011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1432
1433 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1434 value for non-existent files.
1435
b885bf36
EZ
14362011-09-11 Eli Zaretskii <eliz@gnu.org>
1437
1438 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1439 set its "size" to -1. This will set the modtime_size field of
1440 the corresponding buffer to -1, which is what
1441 verify-visited-file-modtime expects for files that do not exist.
1442 (Bug#9139)
1443
6612f0bf
PE
14442011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1447 here ...
1448 * lisp.h: ... from here. push_key_description is no longer
1449 defined in keyboard.c, so its declaration should not be in
1450 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1451 logically belongs with push_key_description.
1452
dfb3f755
PE
14532011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1454
1455 * buffer.h: Include <sys/types.h> instead of <time.h>.
1456 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1457 Problem reported by Herbert J. Skuhra.
1458
3134906c
LMI
14592011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1460
1461 * xml.c (parse_region): Make the parsing work for
1462 non-comment-starting XML files again (bug#9144).
1463
8d903f4e
AS
14642011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1465
1466 * image.c (gif_load): Fix calculation of bottom and right corner.
1467 (Bug#9468)
1468
80ad64f4
EZ
14692011-09-10 Eli Zaretskii <eliz@gnu.org>
1470
1471 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1472 redisplay in small windows.
1473
208a048d
EZ
14742011-09-09 Eli Zaretskii <eliz@gnu.org>
1475
1476 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1477
9b1c252e
MR
14782011-09-08 Martin Rudalics <rudalics@gmx.at>
1479
1480 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1481 Operate on live windows only.
1482
2949f33b
JB
14832011-09-08 Juanma Barranquero <lekktu@gmail.com>
1484
1485 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1486
e08dcafd
EZ
14872011-09-07 Eli Zaretskii <eliz@gnu.org>
1488
1489 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1490 only under bidi iteration.
1491
115b96bd
JD
14922011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1493
1494 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1495
c8199d0f
PE
14962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1499 Without this fix, the command to link temacs failed due to an
1500 undefined symbol __builtin_isnan. This is because
1501 /usr/include/iso/math_c99.h #defines isnan(x) to
1502 __builtin_isnan(x), but the bundled gcc, which identifies itself
1503 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1504 a __builtin_isnan.
1505 * floatfns.c (isnan): #undef, and then #define to a clone of
1506 what's in data.c.
1507 (Fisnan): Always define, since it's always available now.
1508 (syms_of_floatfns): Always define isnan at the Lisp level.
1509
e39b275c 15102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1511
1512 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1513
b2db44d9 15142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1515
f4af5137 1516 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1517 The previous code assumed that file offsets (off_t values) fit in
1518 EMACS_INT variables, which is not true on typical 32-bit hosts.
1519 The code messed up by falsely reporting buffer overflow in cases
1520 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1521 when "big" contains more than 2**29 bytes, even though this
1522 inserts just one byte and does not overflow the buffer.
1523 (Finsert_file_contents): Store file offsets as off_t
1524 values, not as EMACS_INT values. Check for overflow when
1525 converting between EMACS_INT and off_t. When checking for
1526 buffer overflow or for overlap, take the offsets into account.
1527 Don't use EMACS_INT for small values where int suffices.
1528 When checking for overlap, fix a typo: ZV was used where
1529 ZV_BYTE was intended.
1530 (Fwrite_region): Don't assume off_t fits into 'long'.
1531 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1532
ecfc0a49
MA
15332011-09-05 Michael Albinus <michael.albinus@gmx.de>
1534
1535 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1536
6511acf2 15372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1538
0999621a 1539 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1540
1541 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1542 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1543 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1544 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1545 (modify_event_symbol): Do not assume that the length of
1546 name_alist_or_stem is safe to alloca and fits in int.
1547 (Fexecute_extended_command): Likewise for function name and binding.
1548 (Frecursion_depth): Wrap around reliably on integer overflow.
1549 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1550 since some callers pass EMACS_INT values.
1551 (Fsingle_key_description): Don't crash if symbol name contains more
1552 than MAX_ALLOCA bytes.
1553 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1554 (get_minibuffer): Arg is now EMACS_INT, not int.
1555 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1556 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1557 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1558
2be7d702
PE
1559 * dbusbind.c (signature_cat): New function.
1560 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1561 Do not overrun buffer; instead, report string overflow.
1562
9d1df220
PE
1563 * dispnew.c (add_window_display_history): Don't overrun buffer.
1564 Truncate instead; this is OK since it's just a log.
1565
33ef5c64
PE
1566 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1567 even if the time zone offset is outlandishly large.
1568 Don't mishandle offset == INT_MIN.
1569
66c6fdd5
PE
1570 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1571 when creating daemon; the previous buffer-overflow check was incorrect.
1572
d749b01b
PE
1573 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1574 which has the guts of the old verror function.
1575
b5cd1905
PE
1576 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1577 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1578
6e1a67fb
PE
1579 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1580 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1581 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1582 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1583 length of string rather than counting it via multiple sprintfs;
1584 that's simpler and more reliable.
c21721cc
PE
1585 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1586 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1587 sprintf, in case result does not fit in int.
1588
c57b67fc
PE
1589 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1590 (fontset_from_font): Print it.
1591
8a401434
PE
1592 * frame.c (tty_frame_count): Now printmax_t, not int.
1593 (make_terminal_frame, set_term_frame_name): Print it.
1594 (x_report_frame_params): In X, window IDs are unsigned long,
1595 not signed long, so print them as unsigned.
1596 (validate_x_resource_name): Check for implausibly long names,
1597 and don't assume name length fits in 'int'.
1598 (x_get_resource_string): Don't blindly alloca invocation name;
1599 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1600 not fit in int.
1601
6e1a67fb
PE
1602 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1603 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1604 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1605
0df02bf3
PE
1606 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1607 Use esprintf, not sprintf, in case result does not fit in int.
1608
48e30793
PE
1609 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1610 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1611 it as a large positive number.
1612 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1613 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1614
a66ff6d8
PE
1615 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1616 in case result does not fit in int.
1617
aca216ff
PE
1618 * print.c (float_to_string): Detect width overflow more reliably.
1619 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1620 buffer overrun. Don't assume list length fits in 'int'. Treat
1621 print length of 0 as 0, not as infinity; to be consistent with other
1622 uses of print length in this function. Don't overflow print length
1623 index. Don't assume hash table size fits in 'long', or that
1624 vectorlike size fits in 'unsigned long'.
1625
31c286f7
PE
1626 * process.c (make_process): Use printmax_t, not int, to format
1627 process-name gensyms.
1628
55e5faa1
PE
1629 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1630
80f2e268
PE
1631 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1632 to avoid potential buffer overrun.
1633
670741ab
PE
1634 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1635 if X resource line is longer than 512 bytes.
1636
b7163a50
PE
1637 * xfns.c (x_window): Make sprintf buffer a bit bigger
1638 to avoid potential buffer overrun.
1639
ae58ff1f
PE
1640 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1641
c43c8a6a
PE
1642 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1643
3f8236f4
PE
16442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1645
53e9fe90 1646 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1647 Without these, Emacs silently mishandles large integers sometimes.
1648 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1649 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1650
6511acf2
PE
1651 * xdisp.c (try_window_id): Check Emacs fixnum range before
1652 converting to 'int'.
806add1d 1653
6511acf2 1654 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1655 Check that an Emacs fixnum is in range before assigning it to 'int'.
1656 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1657 values converted from Emacs fixnums.
1658 (Frecenter): Don't wrap around a line count if it is out of 'int'
1659 range; instead, treat it as an extreme value.
1660 (Fset_window_configuration, compare_window_configurations):
1661 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1662
6511acf2
PE
1663 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1664 that can exceed INT_MAX. Check that EMACS_INT value is in range
1665 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1666 (match_limit): Don't assume that a fixnum can fit in 'int'.
1667
6511acf2 1668 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1669 exceed INT_MAX.
1670
6511acf2 1671 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1672 (Fvertical_motion): Don't wrap around LINES values that don't fit
1673 in 'int'. Instead, treat them as extreme values. This is good
1674 enough for windows, which can't have more than INT_MAX lines anyway.
1675
fcb901a7
LMI
16762011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1677
0f2f6b6d
LMI
1678 * Require libxml/parser.h to avoid compilation warning.
1679
fcb901a7
LMI
1680 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1681
1682 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1683 since this reportedly can destroy thread storage.
1684
6e20a0d4
CY
16852011-08-30 Chong Yidong <cyd@stupidchicken.com>
1686
1687 * syntax.c (find_defun_start): Update all cache variables if
1688 exiting early (Bug#9401).
1689
148ae00e
EZ
16902011-08-30 Eli Zaretskii <eliz@gnu.org>
1691
f6cfbd8f
EZ
1692 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1693
148ae00e
EZ
1694 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1695 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1696 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1697
1698 * term.c (tty_append_glyph): New function.
1699 (produce_stretch_glyph): Static function and its prototype deleted.
1700
a66cfb1c
SM
1701 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1702 Add prototypes.
148ae00e 1703
c4a07a4c
PE
17042011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1705
1706 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1707 when checking :margin (Bug#9390).
1708 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1709 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1710 so that the name doesn't mislead. All uses changed.
1711
6bc8cd65
JB
17122011-08-28 Johan Bockgård <bojohan@gnu.org>
1713
1714 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1715 set_tty_hooks.
1716
dca4927e
EZ
17172011-08-27 Eli Zaretskii <eliz@gnu.org>
1718
1719 * xdisp.c (move_it_to): Don't bail out early when reaching
1720 position beyond to_charpos, if we are scanning backwards.
1721 (move_it_vertically_backward): When DY == 0, make sure we get to
1722 the first character in the line after the newline.
1723
f2cad773
PE
17242011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1727 (ccl_driver): Do not generate an out-of-range pointer.
1728 (Fccl_execute_on_string): Remove unnecessary check for
1729 integer overflow, noted by Stefan Monnier in
1730 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1731 Remove a FIXME that didn't need fixing.
1732 Simplify the newly-introduced buffer reallocation code.
1733
0cae2cdb
JB
17342011-08-27 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1737
5fc295a4 17382011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1739
70c60eb2 1740 Integer and memory overflow issues (Bug#9196).
726e0ab1 1741
d31850da
PE
1742 * doc.c (get_doc_string): Rework so that
1743 get_doc_string_buffer_size is the actual buffer size, rather than
1744 being 1 less than the actual buffer size; this makes xpalloc more
1745 convenient.
1746
a69fbedb
PE
1747 * image.c (x_allocate_bitmap_record, cache_image):
1748 * xselect.c (Fx_register_dnd_atom):
1749 Simplify previous changes by using xpalloc.
1750
fe5c5d37
PE
1751 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1752 since either will do and ptrdiff_t is convenient with xpalloc.
1753
0065d054
PE
1754 * charset.c (charset_table_size)
1755 (struct charset_sort_data.priority): Now ptrdiff_t.
1756 (charset_compare): Don't overflow if priorities differ greatly.
1757 (Fsort_charsets): Don't assume list length fits in int.
1758 Check for size-calculation overflow when allocating sort data.
1759 (syms_of_charset): Allocate an initial charset table that is
1760 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1761
1762 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1763
1764 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1765 The actual value is always <= INT_MAX, and leaving it unsigned made
1766 overflow checking harder.
1767
1768 * dispextern.h (struct glyph_matrix.rows_allocated)
1769 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1770 with xpalloc. The values are still always <= INT_MAX.
1771
1772 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1773
1774 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1775 (SAFE_NALLOCA): New macro.
1776
1777 * region-cache.c (struct boundary.pos, find_cache_boundary)
1778 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1779 (set_cache_region, invalidate_region_cache)
1780 (revalidate_region_cache, know_region_cache, region_cache_forward)
1781 (region_cache_backward, pp_cache):
1782 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1783 so that ptrdiff_t * can be passed to xpalloc.
1784 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1785 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1786 (pp_cache): Don't assume cache_len fits in int.
1787 * region-cache.h: Adjust extern decls to match.
1788
1789 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1790 EMACS_INT, since either will do, for xpalloc.
1791
1792 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1793 (xnmalloc, xnrealloc, xpalloc): New functions.
1794
726e0ab1
PE
1795 * bidi.c (bidi_shelve_header_size): New constant.
1796 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1797 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1798
51f30bc5 1799 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1800 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1801 (overlay_strings):
1802 Don't update size of array until after memory allocation succeeds,
1803 because xmalloc/xrealloc may not return.
0065d054
PE
1804 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1805 now that we have proper integer overflow checking.
1806 (record_overlay_string, overlay_strings): Catch overflows when
1807 calculating size of overlay_str_buf.
726e0ab1 1808
0065d054
PE
1809 * callproc.c (Fcall_process): Check for size overflow when
1810 calculating size of args2.
1811 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1812 Normally we prefer signed values, but sticking with ptrdiff_t would
1813 require adding more-complicated checks.
726e0ab1
PE
1814
1815 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1816 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1817 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1818 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1819
1820 * character.c (Fstring): Check for size-calculation overflow.
1821
1822 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1823 unnecessary integer overflow. Check for size overflow.
1824 (encode_coding_object): Don't update size until xmalloc succeeds.
1825
1826 * composite.c (get_composition_id): Check for overflow in glyph
1827 length calculations.
1828
1829 Integer and memory overflow fixes for display code.
1830 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1831 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1832 (scrolling_window): Check for overflow in size calculations.
1833 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1834 Don't assume glyph table len fits in int.
1835 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1836 (row_table_size): Now ptrdiff_t, not int.
1837 (scrolling_window): Avoid overflow in size calculations.
1838 Don't update size until allocation succeeds.
1839 * fns.c (concat): Check for overflow in size calculations.
1840 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1841 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1842 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1843
1844 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1845 (get_doc_string): Check for size calculation overflow.
1846 Don't update size until allocation succeeds.
1847 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1848 EMACS_INT, where ptrdiff_t will do.
1849 (Fsubstitute_command_keys): Check for string overflow.
1850
1851 * editfns.c (set_time_zone_rule): Don't assume environment length
1852 fits in int.
1853 (message_length): Now ptrdiff_t, not int.
1854 (Fmessage_box): Don't update size until allocation succeeds.
1855 Don't assume message length fits in int.
1856 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1857
0065d054
PE
1858 * emacs.c (main): Do not reallocate argv, since there is a null at
1859 the end that can be overwritten, and this way there's no need to
1860 worry about size-calculation overflow.
1861 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1862
1863 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1864 alloc succeeds.
1865 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1866
1867 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1868 (x_set_scroll_bar_width, x_figure_window_size):
1869 Check for integer overflow.
1870 (x_set_alpha): Do not assume XINT fits in int.
1871
1872 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1873 This is for the members text_lines, text_cols, total_lines, total_cols,
1874 where the system imposes an 'int' limit.
1875
1876 * fringe.c (Fdefine_fringe_bitmap):
1877 Don't update size until alloc works.
1878
1879 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1880 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1881
1882 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1883 Check for size-calculation overflow.
1884 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1885 do, as we prefer signed integers.
1886 (id_to_widget.max_size, id_to_widget.used)
1887 (xg_store_widget_in_map, xg_remove_widget_from_map)
1888 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1889 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1890 Use and return ptrdiff_t, not int.
1891 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1892 * gtkutil.h: Change prototypes to match the above.
1893
1894 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1895 are duplicate now that they've been promoted to lisp.h.
1896 (x_allocate_bitmap_record, x_alloc_image_color)
1897 (make_image_cache, cache_image, xpm_load):
1898 Don't update size until alloc is done.
1899 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1900 (x_detect_edges):
3256efce 1901 Check for size calculation overflow.
726e0ab1
PE
1902 (ct_colors_allocated_max): New constant.
1903 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1904 overflow.
3256efce 1905
726e0ab1
PE
1906 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1907 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1908 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1909 Use ptrdiff_t, not int, to count maps.
1910 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1911 calculations. Don't update size until allocation succeeds.
1912 Redo calculations to avoid overflow.
726e0ab1
PE
1913 * keyboard.h: Change prototypes to match the above.
1914
1915 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1916 to count maps.
1917 (current_minor_maps): Check for size calculation overflow.
1918 * keymap.h: Change prototypes to match the above.
1919
1920 * lread.c (read1, init_obarray): Don't update size until alloc done.
1921
1922 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1923 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1924
726e0ab1
PE
1925 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1926 Now ptrdiff_t, not int.
1927 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1928 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1929
1930 * process.c (Fnetwork_interface_list): Check for overflow
1931 in size calculation.
1932
1933 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1934
1935 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1936 overflow. Don't bother calling xmalloc when xrealloc will do.
1937
1938 * search.c (Freplace_match): Check for size calculation overflow.
1939 (Fset_match_data): Don't assume list lengths fit in 'int'.
1940
1941 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1942 for command line length. Do not attempt to address one before the
1943 beginning of an array, as that's not portable.
1944
1945 * term.c (max_frame_lines): Remove; unused.
1946 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1947 not int.
1948 (encode_terminal_code, calculate_costs): Check for size
1949 calculation overflow.
1950 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1951 table lengths and related sizes. Don't update size until alloc
1952 done. Redo calculations to avoid overflow.
1953 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1954
1955 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1956 subtracting pointers.
1957 (gobble_line): Check for overflow more carefully. Don't update size
1958 until alloc done.
1959
1960 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1961 Don't update size until alloc done.
1962 Redo size calculations to avoid overflow.
1963 Check for size calculation overflow.
0065d054 1964 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1965
1966 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1967 Use ptrdiff_t, not int, for sizes.
1968 (store_mode_line_noprop_char): Don't update size until alloc done.
1969
0065d054
PE
1970 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1971 Use ptrdiff_t, not int, for sizes.
1972 (Finternal_make_lisp_face, cache_face):
1973 Check for size calculation overflow.
1974 (cache_face): Treat size calculation overflows as if they were
1975 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1976
1977 * xfns.c (x_encode_text, x_set_name_internal)
1978 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1979 sizes, since they can exceed INT_MAX in size. Check for size
1980 calculation overflow.
1981
0065d054
PE
1982 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1983 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1984 Don't update size until alloc done.
1985
0065d054 1986 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1987 as sprintf is limited to int lengths.
1d526e2f 1988
252c5ee1
PE
1989 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1990 (X_LONG_MIN): New macros.
864d7ce7
PE
1991 Use them to make the following changes clearer.
1992 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1993 This change doesn't affect the value now, but it may help remind
1994 future maintainers not to raise the value too much later.
1995 (SELECTION_QUANTUM): Remove, replacing with ...
1996 (selection_quantum): ... new function, which avoids overflow.
1997 All uses changed.
1998 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1999 assumption that selection length fits in 'int'.
2000 (x_reply_selection_request, x_handle_selection_request)
2001 (x_get_window_property, receive_incremental_selection)
2002 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2003 (lisp_data_to_selection_data, clean_local_selection_data):
2004 Use ptrdiff_t, not int, to record length of selection.
2005 (x_reply_selection_request, x_get_window_property)
2006 (receive_incremental_selection, x_property_data_to_lisp):
2007 Redo calculations to avoid overflow.
2008 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2009 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2010 something.
2011 (x_get_window_property, receive_incremental_selection)
2012 (lisp_data_to_selection_data, x_property_data_to_lisp):
2013 Check for size-calculation overflow.
2014 (x_get_window_property, receive_incremental_selection)
2015 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2016 Don't store size until memory allocation succeeds.
2017 (x_get_window_property): Plug memory leak on memory exhaustion.
2018 Don't double-block input; malloc is safe here. Don't assume 2**34
2019 - 4 fits in unsigned long. Add an xassert to check
2020 XGetWindowProperty overflow. Be more careful about overflow
2021 calculations, and distinguish size from memory overflow better.
2022 (receive_incremental_selection): When tracing, don't assume
2023 unsigned int is less than INT_MAX.
2024 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2025 harmful) conversions of unsigned short to int.
2026 (lisp_data_to_selection_data): Don't assume that integers
2027 in the range -65535 through -1 fit in an X unsigned short.
2028 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2029 result parameters unless successful. Rely on cons_to_unsigned
2030 to report problems with elements; the old code wasn't right anyway.
2031 (x_check_property_data): Check for int overflow; we cannot use
2032 a wider type due to X limits.
2033 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2034
726e0ab1 2035 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2036
0065d054
PE
2037 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2038 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2039 (x_color_cells): Don't store size until memory allocation succeeds.
2040 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2041 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2042 (x_term_init): Don't assume length fits in int (sprintf is limited
2043 to int size).
bc18e09d 2044
ebfa62c0
PE
2045 Use ptrdiff_t for composition IDs.
2046 * character.c (lisp_string_width):
2047 * composite.c (composition_table_size, n_compositions)
2048 (get_composition_id, composition_gstring_from_id):
2049 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2050 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2051 * window.c (Frecenter):
2052 Use ptrdiff_t, not int, for composition IDs.
2053 * composite.c (get_composition_id): Check for integer overflow.
2054 * composite.h: Adjust prototypes to match the above changes.
2055
d3411f89
PE
2056 Use ptrdiff_t for hash table indexes.
2057 * category.c (hash_get_category_set):
2058 * ccl.c (ccl_driver):
2059 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2060 * coding.c (coding_system_charset_list, detect_coding_system):
2061 * coding.h (struct coding_system.id):
2062 * composite.c (get_composition_id, gstring_lookup_cache):
2063 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2064 * image.c (xpm_get_color_table_h):
2065 * lisp.h (hash_lookup, hash_put):
2066 * minibuf.c (Ftest_completion):
2067 Use ptrdiff_t for hash table indexes, not int (which is too
2068 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2069 32-bit --with-wide-int hosts).
2070
e097a6fa
PE
2071 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2072 Add a FIXME comment about memory leaks.
2073 (syms_of_charset): Don't assume xmalloc returns.
2074
5637687f
PE
2075 Don't assume that stated character widths fit in int.
2076 * character.c (Fchar_width, c_string_width, lisp_string_width):
2077 * character.h (CHAR_WIDTH):
2078 * indent.c (MULTIBYTE_BYTES_WIDTH):
2079 Use sanitize_char_width to avoid undefined and/or bad behavior
2080 with outlandish widths.
a66cfb1c 2081 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2082 now that we have two such functions. All uses changed.
2083 (sanitize_char_width): New inline function.
2084
a2271ba2
PE
2085 Don't assume that tab-width fits in int.
2086 * character.h (sanitize_width): New inline function.
2087 (SANE_TAB_WIDTH): New macro.
2088 (ASCII_CHAR_WIDTH): Use it.
2089 * indent.c (sane_tab_width): Remove. All uses replaced by
2090 SANE_TAB_WIDTH (current_buffer).
2091 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2092
18c52557
PE
2093 * fileio.c: Integer overflow issues with file modes.
2094 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2095
caeeedc1
PE
2096 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2097 Remove unreachable code.
2098 (read_hex, load_charset_map_from_file): Check for integer overflow.
2099
50849c52
PE
2100 * xterm.c: don't go over XClientMessageEvent limit
2101 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2102 (x_send_scroll_bar_event): Likewise. Check that the size does not
2103 exceed limits imposed by XClientMessageEvent, as well as the usual
2104 ptrdiff_t and size_t limits.
2105
b13995db
PE
2106 * keyboard.c: Overflow, signedness and related fixes.
2107 (make_lispy_movement): Use same integer type in forward decl
2108 that is used in the definition.
2109 (read_key_sequence, keyremap_step):
2110 Change bufsize argument back to int, undoing my 2011-03-30 change.
2111 We prefer signed types, and int is wide enough here.
2112 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2113 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2114 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2115 length, not size_t. Use ptrdiff_t for index, not int.
2116 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2117 possibility of integer overflow.
2118
13464394
PE
2119 Overflow, signedness and related fixes for images.
2120
2121 * dispextern.h (struct it.stack[0].u.image.image_id)
2122 (struct_it.image_id, struct image.id, struct image_cache.size)
2123 (struct image_cache.used, struct image_cache.ref_count):
2124 * gtkutil.c (update_frame_tool_bar):
2125 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2126 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2127 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2128 * nsmenu.m (update_frame_tool_bar):
2129 * xdisp.c (calc_pixel_width_or_height):
2130 * xfns.c (image_cache_refcount):
2131 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2132 on typical 64-bit hosts.
2133
2134 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2135 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2136 Omit unnecessary casts to int.
2137 (parse_image_spec): Check that integers fall into 'int' range
2138 when the callers expect that.
2139 (image_ascent): Redo ascent calculation to avoid int overflow.
2140 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2141 (lookup_image): Remove unnecessary tests.
2142 (xbm_image_p): Locals are now of int, not EMACS_INT,
2143 since parse_image_check makes sure they fit into int.
2144 (png_load, gif_load, svg_load_image):
2145 Prefer int to unsigned where either will do.
2146 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2147 old tiff_error_handler and tiff_warning_handler.
2148 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2149 stack buffer overflows. It uses only the features of vsnprintf
2150 that are common to both POSIX and native Microsoft.
2151 (tiff_error_handler, tiff_warning_handler): Use it.
2152 (tiff_load, gif_load, imagemagick_load_image):
2153 Don't assume :index value fits in 'int'.
2154 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2155 (imagemagick_load_image): Check that crop parameters fit into
2156 the integer types that MagickCropImage accepts. Don't assume
2157 Vimagemagick_render_type has a nonnegative value. Don't assume
2158 size_t fits in 'long'.
2159 (gs_load): Use printmax_t to print the widest integers possible.
2160 Check for integer overflow when computing image height and width.
2161
c11821d4
EZ
21622011-08-26 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (redisplay_window): Don't force window start if point
2165 will be invisible in the resulting window. (Bug#9324)
2166
0c95fcf7
EZ
21672011-08-25 Eli Zaretskii <eliz@gnu.org>
2168
2169 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2170 the display spec is of the form `(space ...)'.
2171 (handle_display_spec): Return the value returned by
2172 handle_single_display_spec, not just 1 or zero.
2173 (handle_single_display_spec): If the display spec is of the form
2174 `(space ...)', and specifies display in the text area, return 2
2175 rather than 1.
fee65a97 2176 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2177 accurately, and prefer exact match for point under bidi.
2178 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2179
2180 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2181 into disp_prop; all users changed.
2182
2183 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2184 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2185 for the text covered by the display property.
2186
e4ed06f1
CY
21872011-08-25 Chong Yidong <cyd@stupidchicken.com>
2188
2189 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2190 Change return value to nil.
2191 (Frecord_buffer): Delete unused function.
2192
f67cdd7f
EZ
21932011-08-24 Eli Zaretskii <eliz@gnu.org>
2194
5980d4c6
EZ
2195 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2196 buffers, return left-to-right.
8610fe8b
EZ
2197 (set_cursor_from_row): Consider candidate row a win if its glyph
2198 represents a newline and point is on that newline. Fixes cursor
2199 positioning on the newline at EOL of R2L text within L2R
2200 paragraph, and vice versa.
2201 (try_cursor_movement): Check continued rows, in addition to
2202 continuation rows. Fixes unwarranted scroll when point enters a
2203 continued line of R2L text within an L2R paragraph, or vice versa.
2204 (cursor_row_p): Consider the case of point being equal to
2205 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2206 from the end of a short line to the beginning of a continued line
2207 of R2L text within L2R paragraph.
2208 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2209 composed characters.
5980d4c6 2210
f67cdd7f
EZ
2211 * bidi.c (bidi_check_type): Use xassert.
2212 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2213 members.
2214
bca633fb
EZ
22152011-08-23 Eli Zaretskii <eliz@gnu.org>
2216
2217 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2218 a character.
2219
4a5885a7
CY
22202011-08-23 Chong Yidong <cyd@stupidchicken.com>
2221
2222 * nsfont.m (ns_otf_to_script): Fix typo.
2223
0902a04e
KH
22242011-08-22 Kenichi Handa <handa@m17n.org>
2225
2226 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2227 extra slot even if the purpose is char-code-property-table.
2228
1a2e6670
EZ
22292011-08-23 Eli Zaretskii <eliz@gnu.org>
2230
8ddde651
EZ
2231 * xdisp.c (redisplay_window): When computing centering_position,
2232 account for the height of the header line. (Bug#8874)
2233
425cc014
EZ
2234 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2235 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2236 candidate is selected by the mouse, and that candidate has a
2237 composed character under the mouse.
2238
1a2e6670
EZ
2239 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2240 coordinates reported by pos-visible-in-window-p for a composed
2241 character in column zero.
2242
8b76d6f8
SM
22432011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2244
2245 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2246
dac347dd
EZ
22472011-08-22 Eli Zaretskii <eliz@gnu.org>
2248
2249 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2250 consider it a hit if to_charpos is anywhere in the range of the
2251 composed buffer positions.
2252
e013fb34
CY
22532011-08-22 Chong Yidong <cyd@stupidchicken.com>
2254
2255 * image.c (gif_load): Don't assume that each subimage has the same
2256 dimensions as the base image. Handle disposal method that is
2257 "undefined" by the gif spec (Bug#9335).
2258
bd1ba3e8
CY
22592011-08-20 Chong Yidong <cyd@stupidchicken.com>
2260
2261 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2262 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2263
54a1215b
EZ
22642011-08-19 Eli Zaretskii <eliz@gnu.org>
2265
823564e5
EZ
2266 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2267 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2268 from an Org mode buffer to a Speedbar frame.
2269
54a1215b
EZ
2270 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2271 a composition, take its buffer position from IT->cmp_it.charpos.
2272 Fixes cursor positioning at the beginning of a line that begins
2273 with a composed character.
2274
9778ebcc
EZ
22752011-08-18 Eli Zaretskii <eliz@gnu.org>
2276
0be6ee06
EZ
2277 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2278 character bidirectional type, use STRONG_L instead. Fixes crashes
2279 in a buffer produced by `describe-categories'.
2280
9778ebcc
EZ
2281 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2282 members before the level stack, so they would be saved and
2283 restored when copying iterator state. Fixes incorrect reordering
2284 around TABs covered by display properties.
2285
156bffbe
AS
22862011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2287
6b02f655 2288 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2289
72ad093b
CY
22902011-08-17 Chong Yidong <cyd@stupidchicken.com>
2291
2292 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2293 (internal_condition_case_2, internal_condition_case_n):
2294 Remove unnecessary aborts (Bug#9081).
72ad093b 2295
35774242
EZ
22962011-08-17 Eli Zaretskii <eliz@gnu.org>
2297
2298 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2299 has no `load' handler, try opening the file locally. (Bug#9311)
2300
db76dd85
KB
23012011-08-16 Ken Brown <kbrown@cornell.edu>
2302
2303 * gmalloc.c: Expand comment.
2304
b215eee5
EZ
23052011-08-16 Eli Zaretskii <eliz@gnu.org>
2306
2307 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2308 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2309
a4579d33
KB
23102011-08-16 Ken Brown <kbrown@cornell.edu>
2311
2312 Fix memory allocation problems in Cygwin build (Bug#9273).
2313
2314 * unexcw.c ( __malloc_initialized): Declare external variable.
2315 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2316
8b76d6f8
SM
2317 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2318 New variables.
a4579d33
KB
2319 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2320 dumped emacs.
2321 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2322 in the static heap.
2323 [CYGWIN] (special_realloc): New function.
2324 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2325 requests to realloc storage in the static heap.
2326
3ebec551
PE
23272011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 * bidi.c (bidi_initialize): Remove unused local.
2330
9fd8be00
EZ
23312011-08-15 Eli Zaretskii <eliz@gnu.org>
2332
6b02f655
SM
2333 * bidimirror.h:
2334 * biditype.h: Remove file.
2335 * makefile.w32-in ($(BLD)/bidi.$(O)):
2336 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2337
2338 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2339
2340 * chartab.c: Improve commentary for the uniprop_table API.
2341
32413314
EZ
2342 * bidi.c (bidi_paragraph_init): Support zero value of
2343 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2344 (bidi_initialize): Use uniprop_table instead of including
2345 biditype.h and bidimirror.h.
32413314 2346
9fd8be00
EZ
2347 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2348 coordinates of the iterator when restoring from ppos_it.
2349 (Bug#9296)
2350
5cf2b69b
KH
23512011-08-14 Kenichi Handa <handa@m17n.org>
2352
2353 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2354 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2355
daf17d00
EZ
23562011-08-14 Eli Zaretskii <eliz@gnu.org>
2357
2358 * xdisp.c (move_it_in_display_line_to): Don't invoke
2359 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2360 ppos_it. Fixes vertical cursor motion when line beginning is
2361 covered by an image. (Bug#9296)
2362
08e3161a
JD
23632011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2364
2365 * nsterm.h (ns_run_ascript): Declare.
2366 (NSAPP_DATA2_RUNASSCRIPT): Define.
2367
2368 * nsfns.m (as_script, as_result, as_status): New static variables.
2369 (ns_run_ascript): New function.
5e617bc2 2370 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2371 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2372 the event loop. Get status from as_status (Bug#7276).
2373
2374 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2375 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2376 the event loop (Bug#7276).
2377
a3720aa2
AS
23782011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2379
2380 * gnutls.c (QCgnutls_bootprop_priority)
2381 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2382 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2383 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2384 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2385 (QCgnutls_bootprop_verify_hostname_error)
2386 (QCgnutls_bootprop_callbacks_verify): Rename from
2387 Qgnutls_bootprop_..., all uses changed.
2388
2389 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2390 uses changed.
2391
0a0d27fb
PE
23922011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2393
19d5c50c
PE
2394 * xfaces.c (Qframe_set_background_mode): Now static.
2395 * dispextern.h (Qframe_set_background_mode): Remove decl.
2396
0a0d27fb
PE
2397 * process.c (Fnetwork_interface_info): Declare local only if needed.
2398
377538cb
JD
23992011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2400
2401 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2402 (Fnetwork_interface_list): Allocate in increments of bytes instead
2403 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2404 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2405 sockaddr.
2406 (struct ifflag_def): notrailers is smart on OSX.
2407 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2408 Get hardware address with getifaddrs if available.
2409
08fff70c
EZ
24102011-08-12 Eli Zaretskii <eliz@gnu.org>
2411
2412 * xdisp.c (iterate_out_of_display_property): xassert that
2413 IT->position is set to within IT->object's boundaries. Break from
2414 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2415 when IT->position is set up wrongly due to some bug.
2416 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2417 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2418 entry. Force push_it to save on the stack the current
2419 buffer/string position, to be restored by pop_it. Fix flags in
2420 the iterator structure wrt the object coming from a display
2421 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2422 properties. (Bug#9284)
2423
7be1c708 24242011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2425
7be1c708
CY
2426 * fontset.c (fontset_get_font_group): Add proper type checks.
2427 (Bug#9172)
aac0c6e3 2428
7be1c708 24292011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2430
7be1c708
CY
2431 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2432 and LC_VERSION_MIN_MACOSX.
2433 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2434 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2435
97bb72a6
EZ
24362011-08-08 Eli Zaretskii <eliz@gnu.org>
2437
2438 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2439 no-display-properties-and-no-overlays under bidi display.
2440 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2441 properties and overlays.
97bb72a6 2442
d5617611
CY
24432011-08-08 Chong Yidong <cyd@stupidchicken.com>
2444
37e11a63
CY
2445 * editfns.c (Fset_time_zone_rule): Document relationship with the
2446 setenv function.
2447
d5617611
CY
2448 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2449 the font entity extracted from the cache (Bug#8109).
2450
58872834
CY
24512011-08-07 Chong Yidong <cyd@stupidchicken.com>
2452
2453 * composite.c (autocmp_chars): Don't reset point. That is done by
2454 restore_point_unwind (Bug#5984).
2455
75bfc667
JL
24562011-08-07 Juri Linkov <juri@jurta.org>
2457
2458 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2459 to show the arg `TIME' instead of `TIMEVAL'.
2460
d1410150
EZ
24612011-08-06 Eli Zaretskii <eliz@gnu.org>
2462
2463 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2464 display property strides EOL and includes a newline, as in
2465 longlines-mode. (Bug#9254)
75b771e4
EZ
2466 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2467 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2468
2469 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2470 is non-zero, even if the data buffer is NULL. Fixes a crash in
2471 vertical-motion with longlines-mode. (Bug#9254)
2472
35928349
EZ
24732011-08-05 Eli Zaretskii <eliz@gnu.org>
2474
ec7cc85b
EZ
2475 * bidi.c <bidi_cache_total_alloc>: Now static.
2476 (bidi_initialize): Initialize bidi_cache_total_alloc.
2477
8b76d6f8 2478 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2479 cache. (Bug#9221)
2480
2481 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2482 amount allocated this far in `bidi_cache_total_alloc'.
2483 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2484 non-zero, only free the data buffer without restoring the cache
2485 contents. All callers changed.
2486
2487 * dispextern.h (bidi_unshelve_cache): Update prototype.
2488
2489 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2490 (move_it_in_display_line, move_it_to)
2491 (move_it_vertically_backward, move_it_by_lines): Replace the call
2492 to xfree to an equivalent call to bidi_unshelve_cache.
2493 (move_it_in_display_line_to): Fix logic of returning
412b6358 2494 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2495
e2e2423b
EZ
24962011-08-05 Eli Zaretskii <eliz@gnu.org>
2497
2498 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2499 came from a string character with a `cursor' property. (Bug#9229)
2500
ae9e757a
JD
25012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2502
2503 * Makefile.in (LIB_PTHREAD): New variable.
2504 (LIBES): Add LIB_PTHREAD (Bug#9216).
2505
2506 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2507 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2508
213bd7f2
AS
25092011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2510
6b02f655 2511 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2512
99aaf75f
JD
25132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2514
2515 * xterm.c (x_find_topmost_parent): New function.
2516 (x_set_frame_alpha): Find topmost parent window with
2517 x_find_topmost_parent and set the property there also (bug#9181).
2518 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2519
c74e9d86
PE
25202011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 * callproc.c (Fcall_process): Avoid vfork clobbering
2523 the local vars buffer, coding_systems, current_dir.
2524
640c8776
SM
25252011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2526
2527 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2528
f26d0e4c
PE
25292011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2530
8a10d76c
PE
2531 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2532 so that it is not optimized away.
2533
f26d0e4c
PE
2534 * xdisp.c (compute_display_string_pos): Remove unused local.
2535
55439c61
EZ
25362011-08-02 Eli Zaretskii <eliz@gnu.org>
2537
2538 Fix slow cursor motion and scrolling in large buffers with
2539 selective display, like Org Mode buffers. (Bug#9218)
2540
2541 * dispextern.h (struct bidi_it): New member disp_prop_p.
2542
2543 * xdisp.c: Remove one-slot cache of display string positions.
2544 (compute_display_string_pos): Accept an additional argument
5e617bc2 2545 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2546 for a display string or property. If found, set DISP_PROP_P
2547 non-zero.
2548
2549 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2550 DISP_PROP_P, and pass it to compute_display_string_pos.
2551 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2552 non-zero. All callers of bidi_fetch_char changed.
2553
fb33fa43
SM
25542011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2555
2556 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2557
b099e063
DM
25582010-12-03 Don March <don@ohspite.net>
2559
2560 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2561 last character M-[char] is translated to ESC [char] (bug#7541).
2562
5cc7f7af
KH
25632011-08-02 Kenichi Handa <handa@m17n.org>
2564
d0fffa3f 2565 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2566
2567 * chartab.c (uniprop_table): Make it non-static.
2568
525d5e6e
EZ
25692011-08-01 Eli Zaretskii <eliz@gnu.org>
2570
2571 * xdisp.c (forward_to_next_line_start): Accept additional argument
2572 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2573 on the newline.
2574 (reseat_at_next_visible_line_start): Use the bidi iterator state
2575 returned by forward_to_next_line_start to restore the state of
2576 it->bidi_it after backing up to previous newline. (Bug#9212)
2577
31011111
AS
25782011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2579
2580 * regex.c (re_comp): Protoize.
2581 (re_exec): Fix return type.
2582 (regexec): Fix type of `ret'. (Bug#9203)
2583
476371c4
PE
25842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2585
e5d76069
PE
2586 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2587 This is needed if max-image-size is a floating-point number.
2588
9a79b20c
AS
25892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2590
2591 * print.c (print_object): Print empty symbol as ##.
2592
2593 * lread.c (read1): Read ## as empty symbol.
2594
d8c2fa78
AA
25952011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2596
2597 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2598 setting frame foreground color (Bug#9175).
2599 (x_set_background_color): Likewise.
2600
ffe57a7a
AA
2601 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2602 contents (Bug#9176).
2603 (EmacsTooltip -init): Remove bezels and add shadows to
2604 tooltip windows.
2605
bf3492a5
AA
2606 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2607 or scroll bar (Bug#8470).
2608
d55e9c53
AA
2609 * nsfont.m (nsfont_open): Remove assignment to voffset and
2610 unnecessary vars hshink, expand, hd, full_height, min_height.
2611 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2612
2613 * nsterm.h (nsfont_info): Remove voffset field.
2614
d8c2fa78 26152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2616
2617 Implement strike-through and overline on NextStep (Bug#8863).
2618
2619 * nsfont.m (nsfont_open): Use underline position provided by font,
2620 instead of hard-coded value of 2.
2621 (nsfont_draw): Call ns_draw_text_decoration instead.
2622
2623 * nsterm.h: Add declaration for ns_draw_text_decoration.
2624
2625 * nsterm.m (ns_draw_text_decoration): New function for drawing
2626 underline, overline, and strike-through.
2627 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2628 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2629 accommodate underlining, etc.
4843aac3 2630
4cc60b9b
EZ
26312011-07-28 Eli Zaretskii <eliz@gnu.org>
2632
bc7ece87
EZ
2633 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2634 default.
4cc60b9b 2635
476371c4
PE
26362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2637
66606eea
PE
2638 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2639 Without this fix, if a signal arrives just after memory fills up,
2640 'malloc' might be invoked reentrantly.
2641
476371c4
PE
2642 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2643 In other words, assume that every image size is allowed, on non-X
2644 hosts. This assumption is probably wrong, but it lets Emacs compile.
2645
f3fcc40d
AS
26462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2647
2648 * regex.c (re_iswctype): Convert return values to boolean.
2649
350c992f
EZ
26502011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2651
2652 * xdisp.c (compute_display_string_pos): Don't use cached display
2653 string position if the buffer had its restriction changed.
2654 (Bug#9184)
2655
5266b4bb
PE
26562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2659
2573a837 26602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2661
41f55ccd 2662 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2663
39e378da
PE
2664 * bidi.c: Integer size and overflow fixes.
2665 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2666 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2667 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2668 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2669 (bidi_find_other_level_edge):
2670 Use ptrdiff_t instead of EMACS_INT where either will do.
2671 This works better on 32-bit hosts configured --with-wide-int.
2672 (bidi_cache_ensure_space): Check for size-calculation overflow.
2673 Use % rather than repeated addition, for better worst-case speed.
2674 Don't set bidi_cache_size until after xrealloc returns, because it
2675 might not return.
2676 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2677 (bidi_cache_ensure_space): Also check that the bidi cache size
2678 does not exceed that of the largest Lisp string or buffer. See Eli
2679 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2680
5e927815
PE
2681 * alloc.c (__malloc_size_t): Remove.
2682 All uses replaced by size_t. See Andreas Schwab's note
2683 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2684
ca4aa935
PE
2685 * image.c: Improve checking for integer overflow.
2686 (check_image_size): Assume that f is nonnull, since
2687 it is always nonnull in practice. This is one less thing to
2688 worry about when checking for integer overflow later.
2689 (x_check_image_size): New function, which checks for integer
2690 overflow issues inside X.
2691 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2692 This removes the need for a memory_full check.
2693 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2694 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2695 (xbm_read_bitmap_data): Change locals back to 'int', since
2696 their values must fit in 'int'.
2697 (xpm_load_image, png_load, tiff_load):
2698 Invoke x_create_x_image_and_pixmap earlier,
2699 to avoid much needless work if the image is too large.
2700 (tiff_load): Treat overly large images as if
2701 x_create_x_image_and_pixmap failed, not as malloc failures.
2702 (gs_load): Use x_check_image_size.
2703
5f8f9cc2
PE
2704 * gtkutil.c: Omit integer casts.
2705 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2706 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2707
5adf60bc
PE
2708 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2709
c8907a93
PE
2710 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2711 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2712 would wrongly return t on a 64-bit host.
2713
e3c25c68
PE
2714 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2715 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2716 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2717 and therefore cause GCC to emit a bogus diagnostic in some cases.
2718
3f791afe
PE
2719 * image.c: Integer signedness and overflow and related fixes.
2720 This is not an exhaustive set of fixes, but it's time to
2721 record what I've got.
2722 (lookup_pixel_color, check_image_size): Remove redundant decls.
2723 (check_image_size): Don't assume that arbitrary EMACS_INT values
2724 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2725 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2726 (tiff_load, imagemagick_load_image):
2727 Check for overflow in size calculations.
2728 (x_create_x_image_and_pixmap): Remove unnecessary test for
2729 xmalloc returning NULL; that can't happen.
2730 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2731 (xpm_color_bucket): Use better integer hashing function.
2732 (xpm_cache_color): Don't possibly over-allocate memory.
2733 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2734 (gif_memory_source):
2735 Use ptrdiff_t, not int or size_t, to record sizes.
2736 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2737 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2738 either works, as we prefer signed integers.
2739 (tiff_read_from_memory, tiff_write_from_memory):
2740 Return tsize_t, not size_t, since that's what the TIFF API wants.
2741 (tiff_read_from_memory): Don't fail simply because the read would
2742 go past EOF; instead, return a short read.
2743 (tiff_load): Omit no-longer-needed casts.
2744 (Fimagemagick_types): Don't assume size fits into 'int'.
2745
3cc5a532
PE
2746 Improve hashing quality when configured --with-wide-int.
2747 * fns.c (hash_string): New function, taken from sxhash_string.
2748 Do not discard information about ASCII character case; this
2749 discarding is no longer needed.
2750 (sxhash-string): Use it. Change sig to match it. Caller changed.
2751 * lisp.h: Declare it.
2752 * lread.c (hash_string): Remove, since we now use fns.c's version.
2753 The fns.c version returns a wider integer if --with-wide-int is
2754 specified, so this should help the quality of the hashing a bit.
2755
b312a492
PE
2756 * emacs.c: Integer overflow minor fix.
2757 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2758 Define only if GNU_LINUX.
2759 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2760
dfd153ae
PE
2761 * dispnew.c: Integer signedness and overflow fixes.
2762 Remove unnecessary forward decls, that were a maintenance hassle.
2763 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2764 All uses changed.
2765 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2766 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2767 (prepare_desired_row, line_draw_cost):
2768 Use int, not unsigned, where either works.
2769 (save_current_matrix, restore_current_matrix):
2770 Use ptrdiff_t, not size_t, where either works.
2771 (init_display): Check for overflow more accurately, and without
2772 relying on undefined behavior.
2773
a81d11a3
PE
2774 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2775 Remove, replacing with the new symbols in lisp.h. All uses changed.
2776 * fileio.c (make_temp_name):
2777 * filelock.c (lock_file_1, lock_file):
2778 * xdisp.c (message_dolog):
2779 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2780 Use pMd etc. instead.
2781 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2782 replacing the pWIDE etc. symbols removed from editfns.c.
2783
3300e6fd
PE
2784 * keyboard.h (num_input_events): Now uintmax_t.
2785 This is (very slightly) less likely to mess up due to wraparound.
2786 All uses changed.
2787
fd05c7e9
PE
2788 * buffer.c: Integer signedness fixes.
2789 (alloc_buffer_text, enlarge_buffer_text):
2790 Use ptrdiff_t rather than size_t when either will do, as we prefer
2791 signed integers.
2792
903fe15d
PE
2793 * alloc.c: Integer signedness and overflow fixes.
2794 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2795 (__malloc_size_t): Default to size_t, not to int.
2796 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2797 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2798 Prefer ptrdiff_t to size_t when either would do, as we prefer
2799 signed integers.
2800 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2801 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2802 Now const. Initialize with values that are in range even if char
2803 is signed.
2804 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2805 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2806 These functions do the right thing with sizes > 2**32.
2807 (check_depth): Now ptrdiff_t, not int.
2808 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2809 Adjust to new way of storing sizes. Check for size overflow bugs
2810 in rest of code.
2811 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2812 slightly wrong anyway, as it missed one instance of
2813 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2814 (refill_memory_reserve): Omit needless cast to size_t.
2815 (mark_object_loop_halt): Mark as externally visible.
2816
ac82cc6a
PE
2817 * xselect.c: Integer signedness and overflow fixes.
2818 (Fx_register_dnd_atom, x_handle_dnd_message):
2819 Use ptrdiff_t, not size_t, since we prefer signed.
2820 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2821 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2822 x_dnd_atoms_size and x_dnd_atoms_length.
2823
c2d1e36d
PE
2824 * doprnt.c: Prefer signed to unsigned when either works.
2825 * eval.c (verror):
2826 * doprnt.c (doprnt):
2827 * lisp.h (doprnt):
2828 * xdisp.c (vmessage):
2829 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2830 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2831 prefer signed arithmetic to avoid comparison confusion.
2832 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2833 but is a bit tricky.
2834
0e926e56
PE
2835 Assume freestanding C89 headers, string.h, stdlib.h.
2836 * data.c, doprnt.c, floatfns.c, print.c:
2837 Include float.h unconditionally.
2838 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2839 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2840 * regex.c: Likewise for stddef.h, string.h.
2841 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2842 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2843 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2844 (STDC_HEADERS): Remove obsolete defines.
2845 * sysdep.c: Include limits.h unconditionally.
2846
9cfdb3ec
PE
2847 Assume support for memcmp, memcpy, memmove, memset.
2848 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2849 * regex.c (memcmp, memcpy):
2850 Remove; we assume C89 now.
2851
2852 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2853 (__malloc_safe_bcopy): Remove; no longer needed.
2854
cf950e6b 2855 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2856 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2857 well either way, and we prefer signed to unsigned.
2858
dbf38e02
LMI
28592011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2860
2861 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2862 closes the connection while we're reading (bug#9182).
2863
d6f0886c 28642011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2865
d6f0886c
JD
2866 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2867 are specified (Bug#9168).
24e0f6b1 2868
2eb1f9e6
PE
28692011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2870
2871 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2872 Found by GCC static checking and --with-wide-int on a 32-bit host.
2873
22381272 28742011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2875
2876 * xdisp.c (compute_display_string_pos): Fix logic of caching
2877 previous display string position. Initialize cached_prev_pos to
2878 -1. Fixes slow-down at the beginning of a buffer.
2879
f25e39b4
EZ
28802011-07-24 Eli Zaretskii <eliz@gnu.org>
2881
2882 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2883 for attrs[LFACE_FONTSET_INDEX].
2884
04c4b52e
PE
28852011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 * xml.c (parse_region): Remove unused local
2888 that was recently introduced.
2889
c1734fbd
EZ
28902011-07-23 Eli Zaretskii <eliz@gnu.org>
2891
be18c5a5
EZ
2892 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2893 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2894
c1734fbd
EZ
2895 * xdisp.c (move_it_in_display_line_to): Record the best matching
2896 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2897 exit if none of the characters scanned was an exact match.
2898 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2899 when exact match is impossible due to invisible text, and the
2900 lines are truncated.
2901
a258d627
JD
29022011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2903
2904 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2905 for OSX >= 10.7.
2906
b6d5a689
EZ
29072011-07-22 Eli Zaretskii <eliz@gnu.org>
2908
0f74f785
EZ
2909 Fix a significant slow-down of cursor motion with C-n, C-p,
2910 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2911 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2912 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2913 (next_element_from_buffer): Call compute_stop_pos_backwards to
2914 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2915 base_level_stop.
2916 (reseat): Don't look for prev_stop, as that could mean a very long
2917 run.
2918 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2919 <cached_disp_overlay_modiff>: Cache for last found display string
2920 position.
551918c1 2921 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2922 about the same buffer in the same area of character positions, and
2923 the buffer wasn't changed since the time the display string
2924 position was cached.
551918c1 2925
b2d0c91a
EZ
29262011-07-22 Eli Zaretskii <eliz@gnu.org>
2927
2928 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2929 is an integer, which is important for empty lines. (Bug#9149)
2930
043604ee
CY
29312011-07-22 Chong Yidong <cyd@stupidchicken.com>
2932
2933 * frame.c (Fmodify_frame_parameters): In tty case, update the
2934 default face if necessary (Bug#4238).
2935
da4adb04
CY
29362011-07-21 Chong Yidong <cyd@stupidchicken.com>
2937
2938 * editfns.c (Fstring_to_char): No need to explain what a character
2939 is in the docstring (Bug#6576).
2940
9abd0532
LMI
29412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2942
2943 * xml.c (parse_region): Make sure we always return a tree.
2944
36881d16
HK
29452011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2946
2947 * xml.c (parse_region): If a document contains only comments,
2948 return that, too.
2949
1e98674d
LMI
29502011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2951
2952 * xml.c (make_dom): Return comments, too.
2953
590bd467
PE
29542011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2955
2956 Port to OpenBSD.
2957 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2958 and the surrounding thread.
2959 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2960 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2961 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2962 timer goes off.
2963 * s/openbsd.h (BROKEN_SIGIO): Define.
2964 * unexelf.c (unexec) [__OpenBSD__]:
2965 Don't update the .mdebug section of the Alpha COFF symbol table.
2966
f41628b2
LMI
29672011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2968
2969 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2970 (bug#8460).
2971
b59b67c5
PE
29722011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2973
15e3a074
PE
2974 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2975 This fixes some race conditions on the permissions of any newly
2976 created file.
2977
41bed37d
PE
2978 * alloc.c (valid_pointer_p): Use pipe, not open.
2979 This fixes some permissions issues when debugging.
2980
b59b67c5
PE
2981 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2982 If fchown fails to set both uid and gid, try to set just gid,
2983 as that is sometimes allowed. Adjust the file's mode to eliminate
2984 setuid or setgid bits that are inappropriate if fchown fails.
2985
925a6be7
SM
29862011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2987
2988 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2989 to compare Lisp_Objects.
2990 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2991 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2992 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2993
52968808
AS
29942011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2995
0a6a104b
AS
2996 * lread.c (read_integer): Unread even EOF character.
2997 (read1): Likewise. Properly record start position of symbol.
2998
52968808
AS
2999 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3000 symbol character follows.
3001
9e381cdd
PE
30022011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3003
3004 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3005 This works around a problem with the previous change to Fcopy_file.
3006 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3007 and without this change, GCC might complain about discarding
3008 fchown's return value.
3009
b5641435
JB
30102011-07-16 Juanma Barranquero <lekktu@gmail.com>
3011
3012 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3013
a8031457
PE
30142011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3015
3016 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3017
dd889327
LMI
30182011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3019
750c33f7
LMI
3020 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3021 it's used from the C level.
3022
dd889327
LMI
3023 * process.c: Use the same condition for POLL_FOR_INPUT in both
3024 keyboard.c and process.c (bug#1858).
3025
87e86684
LM
30262011-07-09 Lawrence Mitchell <wence@gmx.li>
3027
3028 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3029 (Fgnutls_boot): Use it.
3030
64348f40
AS
30312011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3032
3033 * doc.c (Fsubstitute_command_keys): Revert last change.
3034
1d698799
LMI
30352011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3036
f863868c
LMI
3037 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3038 quotes the next character, and doesn't affect other longer
3039 sequences (bug#8935).
3040
1d698799
LMI
3041 * lread.c (syms_of_lread): Clarify that is isn't only
3042 `eval-buffer' and `eval-defun' that's affected by
3043 `lexical-binding' (bug#8460).
3044
aa4b6df6
EZ
30452011-07-15 Eli Zaretskii <eliz@gnu.org>
3046
3047 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3048 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3049
5d856da6
PE
30502011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3051
ad6042bb
PE
3052 Fix minor problems found by static checking.
3053 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3054 (elsz): Now a signed constant, not a size_t var. We prefer signed
3055 types to unsigned, to avoid integer comparison confusion. Without
3056 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3057 "cannot optimize loop, the loop counter may overflow", a symptom
3058 of the confusion.
f00bbb22 3059 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3060 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3061
6468f31c
LMI
30622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3063
49080b10
LMI
3064 * search.c (Fre_search_backward): Mention `case-fold-search' in
3065 all the re_search_* functions (bug#8138).
3066
6468f31c
LMI
3067 * keyboard.c (Fopen_dribble_file): Document when the file is
3068 closed (bug#8056).
3069
c965adc5
EZ
30702011-07-14 Eli Zaretskii <eliz@gnu.org>
3071
df9733bf
EZ
3072 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3073 bidi_cache_idx.
3074
0bb23927
EZ
3075 Support bidi reordering of display and overlay strings.
3076 * xdisp.c (compute_display_string_pos)
3077 (compute_display_string_end): Accept additional argument STRING.
3078 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3079 (reseat_to_string): Initialize bidi_it->string.s and
3080 bidi_it->string.schars.
3081 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3082 NULL (avoids a crash in bidi_paragraph_init).
3083 Initialize itb.string.lstring.
0bb23927
EZ
3084 (init_iterator): Call bidi_init_it only of a valid
3085 buffer position was specified. Initialize paragraph_embedding to
3086 L2R.
3087 (reseat_to_string): Initialize the bidi iterator.
3088 (display_string): If we need to ignore text properties of
3089 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3090 original value of -1 will not work with bidi.)
3091 (compute_display_string_pos): First arg is now struct
3092 `text_pos *'; all callers changed. Support display properties on
3093 Lisp strings.
3094 (compute_display_string_end): Support display properties on Lisp
3095 strings.
3096 (init_iterator, reseat_1, reseat_to_string): Initialize the
3097 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3098 when iterating on a string not from display properties).
640c8776
SM
3099 (compute_display_string_pos, compute_display_string_end):
3100 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3101 arrow keys.
3102 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3103 base_level_stop; instead, set base_level_stop to BEGV.
3104 Fixes crashes in vertical-motion.
0bb23927
EZ
3105 (next_element_from_buffer): Improve commentary for when
3106 the iterator is before prev_stop.
3107 (init_iterator): Initialize bidi_p from the default value of
3108 bidi-display-reordering, not from buffer-local value. Use the
3109 buffer-local value only if initializing for buffer iteration.
3110 (handle_invisible_prop): Support invisible properties on strings
3111 that are being bidi-reordered.
3112 (set_iterator_to_next): Support bidi reordering of C strings and
3113 Lisp strings.
3114 (next_element_from_string): Support bidi reordering of Lisp
3115 strings.
3116 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3117 (display_string): Support display of R2L glyph rows.
3118 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3119 (init_iterator): Don't initialize it->bidi_p for strings
3120 here.
3121 (reseat_to_string): Initialize it->bidi_p for strings here.
3122 (next_element_from_string, next_element_from_c_string)
3123 (next_element_from_buffer): Add xassert's for correspondence
3124 between IT's object being iterated and it->bidi_it.string
3125 structure.
3126 (face_before_or_after_it_pos): Support bidi iteration.
3127 (next_element_from_c_string): Handle the case of the first string
3128 character that is not the first one in the visual order.
3129 (get_visually_first_element): New function, refactored from common
3130 parts of next_element_from_buffer, next_element_from_string, and
3131 next_element_from_c_string.
3132 (tool_bar_lines_needed, redisplay_tool_bar)
3133 (display_menu_bar): Force left-to-right direction. Add a FIXME
3134 comment for making that be controlled by a user option.
3135 (push_it, pop_it): Save and restore the state of the
3136 bidi iterator. Save and restore the bidi_p flag.
3137 (pop_it): Iterate out of display property for string iteration as
3138 well.
3139 (iterate_out_of_display_property): Support iteration over strings.
3140 (handle_single_display_spec): Set up it->bidi_it for iteration
3141 over a display string, and call bidi_init_it.
3142 (handle_single_display_spec, next_overlay_string)
3143 (get_overlay_strings_1, push_display_prop): Set up the bidi
3144 iterator for displaying display or overlay strings.
3145 (forward_to_next_line_start): Don't use the shortcut if
3146 bidi-iterating.
3147 (back_to_previous_visible_line_start): If handle_display_prop
3148 pushed the iterator stack, restore the internal state of the bidi
3149 iterator by calling bidi_pop_it same number of times.
3150 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3151 and we are bidi-iterating, don't decrement the iterator position;
3152 instead, set the first_elt flag in the bidi iterator, to produce
3153 the same effect.
3154 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3155 (push_display_prop): xassert that we are iterating a buffer.
3156 (push_it, pop_it): Save and restore paragraph_embedding member.
3157 (handle_single_display_spec, next_overlay_string)
3158 (get_overlay_strings_1, reseat_1, reseat_to_string)
3159 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3160 correctly. Don't assume unibyte strings are not bidi-reordered.
3161 (compute_display_string_pos)
3162 (compute_display_string_end): Fix handling the case of C string.
3163 (push_it, pop_it): Save and restore from_disp_prop_p.
3164 (handle_single_display_spec, push_display_prop): Set the
3165 from_disp_prop_p flag.
3166 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3167 (pop_it): Call iterate_out_of_display_property only if we are
3168 popping after iteration over a string that came from a display
3169 property. Fix a typo in popping stretch info. Add an assertion
3170 for verifying that the iterator position is in sync with the bidi
3171 iterator.
3172 (handle_single_display_spec, get_overlay_strings_1)
3173 (push_display_prop): Fix initialization of paragraph direction for
3174 string when that of the parent object is not yet determined.
3175 (reseat_1): Call bidi_init_it to resync the bidi
3176 iterator with IT's position. (Bug#7616)
3177 (find_row_edges): If ROW->start.pos gives position
3178 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3179 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3180 Reset the from_disp_prop_p flag.
3181 (SAVE_IT, RESTORE_IT): New macros.
3182 (pos_visible_p, face_before_or_after_it_pos)
3183 (back_to_previous_visible_line_start)
3184 (move_it_in_display_line_to, move_it_in_display_line)
3185 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3186 (try_scrolling, redisplay_window, display_line): Use them when
3187 saving a temporary copy of the iterator and restoring it back.
3188 (back_to_previous_visible_line_start, reseat_1)
3189 (init_iterator): Empty the bidi cache "stack".
3190 (move_it_in_display_line_to): If iterator ended up at
3191 EOL, but we never saw any buffer positions smaller than
3192 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3193 motion in bidi-reordered lines.
3194 (move_it_in_display_line_to): Record prev_method and prev_pos
3195 immediately before the call to set_iterator_to_next. Fixes cursor
3196 motion in bidi-reordered lines with stretch glyphs and strings
3197 displayed in margins. (Bug#8133) (Bug#8867)
3198 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3199 TO_CHARPOS.
640c8776
SM
3200 (pos_visible_p): Support positions in bidi-reordered lines.
3201 Save and restore bidi cache.
0bb23927
EZ
3202
3203 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3204 (bidi_paragraph_info): Delete unused struct.
3205 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3206 (bidi_cache_start): New variable.
3207 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3208 to zero.
3209 (bidi_cache_fetch_state, bidi_cache_search)
3210 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3211 (bidi_cache_find, bidi_peek_at_next_level)
3212 (bidi_level_of_next_char, bidi_find_other_level_edge)
3213 (bidi_move_to_visually_next): Compare cache index with
3214 bidi_cache_start rather than with zero.
3215 (bidi_fetch_char): Accept new argument STRING; all callers
3216 changed. Support iteration over a string. Support strings with
3217 display properties. Support unibyte strings. Fix the type of
3218 `len' according to what STRING_CHAR_AND_LENGTH expects.
3219 (bidi_paragraph_init, bidi_resolve_explicit_1)
3220 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3221 (bidi_level_of_next_char, bidi_move_to_visually_next):
3222 Support iteration over a string.
0bb23927
EZ
3223 (bidi_set_sor_type, bidi_resolve_explicit_1)
3224 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3225 can now be zero (for strings); special values 0 and -1 were
3226 changed to -1 and -2, respectively.
3227 (bidi_char_at_pos): New function.
3228 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3229 Call it instead of FETCH_MULTIBYTE_CHAR.
3230 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3231 initialized to valid values.
3232 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3233 values.
3234 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3235 the test for valid cached positions. Fix the logic for looking up
3236 the sentinel state in the cache. GCPRO the Lisp string we are
3237 iterating.
3238 (bidi_push_it, bidi_pop_it): New functions.
3239 (bidi_initialize): Initialize the bidi cache start stack pointer.
3240 (bidi_cache_ensure_space): New function, refactored from part of
3241 bidi_cache_iterator_state. Don't assume the required size is just
3242 one BIDI_CACHE_CHUNK away.
3243 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3244 (bidi_count_bytes, bidi_char_at_pos): New functions.
3245 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3246 always valid if bidi_cache_idx is valid.
3247 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3248 is valid if it's going to be used.
3249 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3250 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3251 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3252 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3253 (bidi_find_other_level_edge, bidi_cache_start_stack):
3254 All variables related to cache indices are now EMACS_INT.
c965adc5 3255
0bb23927
EZ
3256 * dispextern.h (struct bidi_string_data): New structure.
3257 (struct bidi_it): New member `string'. Make flag members be 1-bit
3258 fields, and put them last in the struct.
640c8776
SM
3259 (compute_display_string_pos, compute_display_string_end):
3260 Update prototypes.
0bb23927
EZ
3261 (bidi_push_it, bidi_pop_it): Add prototypes.
3262 (struct iterator_stack_entry): New members bidi_p,
3263 paragraph_embedding, and from_disp_prop_p.
3264 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3265 (bidi_shelve_cache, bidi_unshelve_cache):
3266 Declare prototypes.
0bb23927
EZ
3267
3268 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3269 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3270 and vector-like objects.
3271
3272 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3273 cache around display iteration.
3274
3275 * window.c (Fwindow_end, window_scroll_pixel_based)
3276 (displayed_window_lines, Frecenter): Save and restore the bidi
3277 cache around display iteration.
3278
3bbd2265
LMI
32792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3280
3281 * editfns.c (Fdelete_region): Clarify the use of the named
3282 parameters (bug#6788).
3283
adc47434
MR
32842011-07-14 Martin Rudalics <rudalics@gmx.at>
3285
3286 * indent.c (Fvertical_motion): Set and restore w->pointm when
3287 saving and restoring the window's buffer (Bug#9006).
3288
837c31f8
LMI
32892011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3290
3291 * editfns.c (Fstring_to_char): Clarify just what is returned
3292 (bug#6576). Text by Eli Zaretskii.
3293
ac389d0c
JB
32942011-07-13 Juanma Barranquero <lekktu@gmail.com>
3295
3296 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3297
0be0ce47
EZ
32982011-07-13 Eli Zaretskii <eliz@gnu.org>
3299
3300 * buffer.c (mmap_find): Fix a typo.
3301
cd18e7e3
JB
33022011-07-13 Johan Bockgård <bojohan@gnu.org>
3303
3304 Fix execution of x selection hooks.
3305 * xselect.c (Qx_lost_selection_functions)
3306 (Qx_sent_selection_functions): New vars.
3307 (syms_of_xselect): DEFSYM them.
3308 (x_handle_selection_request): Pass Qx_sent_selection_functions
3309 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3310 (x_handle_selection_clear,x_clear_frame_selections):
3311 Pass Qx_lost_selection_functions rather than
3312 Vx_lost_selection_functions to Frun_hook_with_args.
3313
47ea7f44
PE
33142011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3315
ac389d0c 3316 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3317 The old code sometimes used this field without initializing it.
3318
47ea7f44
PE
3319 * alloc.c (gc_sweep): Don't read past end of array.
3320 In theory, the old code could also have corrupted Emacs internals,
3321 though it'd be very unlikely.
3322
bc985c87
AS
33232011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3324
3325 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3326 argument. (Bug#4026)
bc985c87 3327
0cf34688
LMI
33282011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3329
b3dadd76
LMI
3330 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3331 key" (bug#4257).
3332
0cf34688
LMI
3333 * window.c (Fset_window_start): Doc fix (bug#4199).
3334 (Fset_window_hscroll): Ditto.
3335
270768cd
PE
33362011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3337
077e3dda 3338 Fix minor new problems caught by GCC 4.6.1.
270768cd 3339 * term.c (init_tty): Remove unused local.
490011a6 3340 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3341 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3342 not used otherwise.
270768cd 3343
b1f58454
CY
33442011-07-12 Chong Yidong <cyd@stupidchicken.com>
3345
3346 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3347
22b9578d
LMI
33482011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3349
6e70ab07
LMI
3350 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3351 are the mini-buffer and the echo area (bug#3320).
3352
22b9578d
LMI
3353 * term.c (init_tty): Remove support for supdup, c10 and perq
3354 terminals, which are no longer supported (bug#1482).
3355
8974cc9f
JB
33562011-07-10 Johan Bockgård <bojohan@gnu.org>
3357
3358 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3359
a560d974
JD
33602011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3361
3362 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3363 for non-popups (Bug#3642).
3364
1dae0f0a
AS
33652011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3366
268c2c36 3367 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3368 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3369 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3370 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3371 * data.c (fmod): Likewise.
3372 * dispnew.c (swap_glyphs_in_rows): Likewise.
3373 * emacs.c (memory_warning_signal): Likewise.
3374 * floatfns.c (float_error): Likewise.
3375 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3376 (otf_open, font_otf_capability, generate_otf_features)
3377 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3378 Likewise.
3379 * image.c (pbm_read_file): Likewise.
3380 * indent.c (string_display_width): Likewise.
3381 * intervals.c (check_for_interval, search_for_interval)
3382 (inc_interval_count, count_intervals, root_interval)
3383 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3384 * lread.c (defalias): Likewise.
268c2c36 3385 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3386 * regex.c (set_image_of_range_1, set_image_of_range)
3387 (regex_grow_registers): Likewise.
3388 * sysdep.c (strerror): Likewise.
3389 * termcap.c (valid_filename_p, tprint, main): Likewise.
3390 * tparam.c (main): Likewise.
3391 * unexhp9k800.c (run_time_remap, save_data_space)
3392 (update_file_ptrs, read_header, write_header, calculate_checksum)
3393 (copy_file, copy_rest, display_header): Likewise.
3394 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3395 Likewise.
3396 * xdisp.c (check_it): Likewise.
3397 * xfaces.c (register_color, unregister_color, unregister_colors):
3398 Likewise.
3399 * xfns.c (print_fontset_result): Likewise.
3400 * xrdb.c (member, fatal, main): Likewise.
3401
99033785
PE
34022011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 Fix minor problems found by static checking (Bug#9031).
3405 * chartab.c (char_table_set_range, map_sub_char_table):
3406 Remove unused locals.
3407 (uniprop_table): Now static.
3408 * composite.c (_work_char): Remove unused static var.
3409
9cb2ac56
JB
34102011-07-09 Juanma Barranquero <lekktu@gmail.com>
3411
3412 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3413
f25661f0
JD
34142011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3415
3416 * gtkutil.c (qttip_cb): Remove code without function.
3417
8278c4fe
EZ
34182011-07-09 Eli Zaretskii <eliz@gnu.org>
3419
3420 * w32.c (pthread_sigmask): New stub.
3421
1692ae2d 34222011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3423
8a6ebd58 3424 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3425 sigprocmask is portable only for single-threaded applications, and
3426 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3427 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3428 (LIBES): Use it.
3429 * callproc.c (Fcall_process):
3430 * process.c (create_process):
3431 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3432 Use pthread_sigmask, not sigprocmask.
123403e4 3433
1b854618
JD
34342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3435
3436 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3437 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3438 wrong (Bug#8591).
3439
3fe4b549
JD
34402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3441
0ce7e563
JD
3442 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3443 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3444 (xg_hide_tooltip): Fix comment.
3445
3fe4b549
JD
3446 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3447 in registerServicesMenuSendTypes.
3448 (validRequestorForSendType): Don't check ns_return_types.
3449
3450 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3451 ns_return_type.
3452
5df75e47
JR
34532011-07-08 Jason Rumney <jasonr@gnu.org>
3454
22610910
JR
3455 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3456 SH_SHOW for hidden windows (Bug#5482).
3457
5df75e47
JR
3458 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3459 frame struct members of non-existent frames (Bug#6284).
3460
699c10bd
JD
34612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3462
4393663b
JD
3463 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3464 variable firstTime not needed on OSX >= 10.6.
3465 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3466 >= 10.5. Use setKnobProportion, setDoubleValue.
3467
3468 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3469 (MAC_OS_X_VERSION_10_5): Define if not defined.
3470 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3471 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3472 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3473
3474 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3475 cString and lossyCString on OSX >= 10.4
3476
58179cce 3477 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3478 sizeToFit on OSX >= 10.2.
3479
3480 * nsimage.m (allocInitFromFile): Don't use deprecated method
3481 bestRepresentationForDevice on OSX >= 10.6.
3482
3483 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3484 to avoid warning.
3485
3486 * emacs.c: Declare unexec_init_emacs_zone.
3487
a63e0781
JD
3488 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3489
699c10bd
JD
3490 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3491
3492 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3493 on svcsMenu (Bug#8842).
3494
3495 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3496 ns_return_types.
3497 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3498
3499 * nsterm.m (QUTF8_STRING): Declare.
3500 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3501 (validRequestorForSendType): Return type is (id).
3502 Change indexOfObjectIdenticalTo to indexOfObject.
3503 Check if we have local selection before returning self (Bug#8842).
3504 (writeSelectionToPasteboard): Put local selection into paste board
3505 if we have a local selection (Bug#8842).
3506 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3507
3508 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3509 (ns_get_local_selection): Declare.
3510
54e10184
LMI
35112011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3512
9888ff71
LMI
3513 * keymap.c (describe_map_tree): Don't insert a double newline at
3514 the end of the buffer (bug#1169) and return whether we inserted
3515 something.
3516
54e10184
LMI
3517 * callint.c (Fcall_interactively): Change "reading args" to
3518 "providing args" to try to clarify what it does (bug#1010).
3519
15fa4783
KH
35202011-07-07 Kenichi Handa <handa@m17n.org>
3521
3522 * composite.c (composition_compute_stop_pos): Ignore a static
3523 composition starting before CHARPOS (Bug#8915).
3524
3525 * xdisp.c (handle_composition_prop): Likewise.
3526
a8815b00
EZ
35272011-07-07 Eli Zaretskii <eliz@gnu.org>
3528
3529 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3530 (Bug#9015)
3531
ef7b981d 35322011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3533
3534 * character.h (unicode_category_t): New enum type.
3535
3536 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3537 (Qchar_code_property_table): New variable.
3538 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3539 (UNIPROP_COMPRESSED_FORM_P): New macros.
3540 (char_table_ascii): Uncompress the compressed values.
3541 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3542 Uncompress the compressed values.
ac389d0c 3543 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3544 (char_table_ref_and_range): Uncompress the compressed values.
3545 (sub_char_table_set): New arg is_uniprop. Callers changed.
3546 Uncompress the compressed values.
3547 (sub_char_table_set_range): Args changed. Callers changed.
3548 (char_table_set_range): Adjuted for the above change.
3549 (map_sub_char_table): Delete args default_val and parent. Add arg
3550 top. Give decoded values to a Lisp function.
640c8776 3551 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3552 values to a Lisp function. Gcpro more variables.
3553 (uniprop_table_uncompress)
3554 (uniprop_decode_value_run_length): New functions.
3555 (uniprop_decoder, uniprop_decoder_count): New variables.
3556 (uniprop_get_decoder, uniprop_encode_value_character)
3557 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3558 New functions.
3559 (uniprop_encoder, uniprop_encoder_count): New variables.
3560 (uniprop_get_encoder, uniprop_table)
3561 (Funicode_property_table_internal, Fget_unicode_property_internal)
3562 (Fput_unicode_property_internal): New functions.
3563 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3564 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3565 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3566 char-code-property-alist.
3567
640c8776 3568 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3569 Vunicode_category_table.
3570
640c8776 3571 * font.c (font_range): Adjust for the change of
c805dec0
KH
3572 Vunicode_category_table.
3573
76b397fb
DN
35742011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3575
3576 * m/iris4d.h: Remove file, move contents ...
3577 * s/irix6-5.h: ... here.
3578
22b4128e
PE
35792011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3580
3581 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3582 * alloc.c (mark_buffer):
3583 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3584 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3585 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3586 This isn't true in general, and it's particularly not true
3587 if Emacs is configured with --with-wide-int.
3588 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3589 New macros, used in the buffer.c change.
3590
869795d6
JD
35912011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3592
3593 * xsettings.c: Use both GConf and GSettings if both are available.
3594 (store_config_changed_event): Add comment.
3595 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3596 (store_tool_bar_style_changed): New functions.
5e617bc2 3597 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3598 (struct xsettings): Move font inside HAVE_XFT.
3599 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3600 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3601 Move inside HAVE_XFT.
640c8776 3602 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3603 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3604 also.
3605 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3606 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3607 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3608 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3609 (parse_settings): Move check for font inside HAVE_XFT.
3610 (read_settings, apply_xft_settings): Add comment.
3611 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3612 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3613 call store_font_name_changed.
3614 (xft_settings_event): Add comment.
3615 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3616 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3617 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3618 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3619 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3620 (xsettings_get_system_font, xsettings_get_system_normal_font):
3621 Add comment.
869795d6 3622
d8ed26bd
PE
36232011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3624
3625 Random fixes. E.g., (random) never returned negative values.
3626 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3627 subseconds part to the entropy, as that's a bit more random.
3628 Prefer signed to unsigned, since the signedness doesn't matter and
3629 in general we prefer signed. When given a limit, use a
3630 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3631 latter isn't right if USE_2_TAGS_FOR_INTS.
3632 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3633 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3634
cabf1cac
SM
36352011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3636
3637 * textprop.c (text_property_stickiness):
3638 Obey Vtext_property_default_nonsticky.
3639 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3640 * w32fns.c (syms_of_w32fns):
3641 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3642
6e9b2be9
PE
36432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3644
3645 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3646 This is more efficient than Ffile_directory_p and avoids a minor race.
3647
90186c68
LMI
36482011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3649
7c301272
LMI
3650 * buffer.c (Foverlay_put): Say what the return value is
3651 (bug#7835).
3652
c4f2d8d4
LMI
3653 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3654 is a directory before asking whether to use the file name
3655 (bug#7564).
ad637907
LMI
3656 (barf_or_query_if_file_exists): Make the "File is a directory"
3657 error be more correct.
c4f2d8d4 3658
90186c68
LMI
3659 * fns.c (Frequire): Remove the mention of the .gz files, since
3660 that's installation-specific, but keep the mention of
3661 `get-load-suffixes'.
3662
da64016e
PE
36632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3664
3665 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3666 Report string overflow if the output is too long.
3667
7d47b580
JB
36682011-07-04 Juanma Barranquero <lekktu@gmail.com>
3669
a555cb87
JB
3670 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3671 (syms_of_gnutls): Remove duplicate DEFSYM for
3672 Qgnutls_bootprop_verify_hostname_error, an error for
3673 Qgnutls_bootprop_verify_error (which is no longer used).
3674
7d47b580
JB
3675 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3676 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3677 Also (re)move comments that are misplaced or no longer relevant.
3678
1e49bfab
LMI
36792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3680
3681 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3682
1485f4c0
CY
36832011-07-03 Chong Yidong <cyd@stupidchicken.com>
3684
3685 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3686 and background color parameters if they have been changed.
3687
a9ab721e
LMI
36882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3689
3690 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3691
cf7cff57
PE
36922011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3693
2e13213d
PE
3694 * xsettings.c (SYSTEM_FONT): Define only when used.
3695 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3696
cf7cff57
PE
3697 * keymap.c (access_keymap_1): Now static.
3698
7a8e04f7
CY
36992011-07-02 Chong Yidong <cyd@stupidchicken.com>
3700
3701 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3702 leave any prefix arg for the up event (Bug#1586).
3703
61352f62
LMI
37042011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3705
69bb1ef7
LMI
3706 * lread.c (syms_of_lread): Mention single symbols defined by
3707 `defvar' or `defconst' (bug#7154).
3708
61352f62 3709 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3710 (Frequire): Mention get-load-suffixes.
61352f62 3711
28545e04
MR
37122011-07-02 Martin Rudalics <rudalics@gmx.at>
3713
3714 * window.h (window): Remove clone_number slot.
3715 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3716 Remove.
3717 (make_parent_window, make_window, saved_window)
3718 (Fset_window_configuration, save_window_save): Don't deal with
3719 clone numbers.
3720 * buffer.c (Qclone_number): Remove declaration.
3721 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3722
3349e122
SM
37232011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3724
3725 Add multiple inheritance to keymaps.
3726 * keymap.c (Fmake_composed_keymap): New function.
3727 (Fset_keymap_parent): Simplify.
3728 (fix_submap_inheritance): Remove.
3729 (access_keymap_1): New function extracted from access_keymap to handle
3730 embedded parents and handle lists of maps.
3731 (access_keymap): Use it.
3732 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3733 (Fcopy_keymap): Handle embedded parents.
3734 (Fcommand_remapping, define_as_prefix): Simplify.
3735 (Fkey_binding): Simplify.
3736 (syms_of_keymap): Move minibuffer-local-completion-map,
3737 minibuffer-local-filename-completion-map,
3738 minibuffer-local-must-match-map, and
3739 minibuffer-local-filename-must-match-map to Elisp.
3740 (syms_of_keymap): Defsubr make-composed-keymap.
3741 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3742 (parse_menu_item): Trivial simplification.
3743
3279eb87
GM
37442011-07-01 Glenn Morris <rgm@gnu.org>
3745
3746 * Makefile.in (SETTINGS_LIBS): Fix typo.
3747
4550efdf
KI
37482011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3749
3750 * coding.c (Fencode_coding_string): Record the last coding system
3751 used, as the function doc string says (bug#8738).
3752
0949d2b6
JD
37532011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3754
3755 * xsettings.c (store_monospaced_changed): Take new font as arg and
3756 check for change against current_mono_font.
3757 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3758 (emacs_settings_constructor, emacs_settings_get_property)
3759 (emacs_settings_set_property, emacs_settings_class_init)
3760 (emacs_settings_init, gsettings_obj): Remove.
3761 (something_changedCB): New function for HAVE_GSETTINGS.
3762 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3763 with value as argument.
3764 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3765 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3766 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3767 "changed".
3768
3769 * xgselect.c: Add defined (HAVE_GSETTINGS).
3770 (xgselect_initialize): Ditto.
3771
3772 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3773 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3774 xg_select.
3775
bbc6b304
PE
37762011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3777
3778 * eval.c (struct backtrace): Simplify and port the data structure.
3779 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3780 signed bit field, as this assumption is not portable and it makes
3781 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3782 "char debug_on_exit : 1" as this is not portable either; instead,
3783 use the portable "unsigned int debug_on_exit : 1". Remove unused
3784 member evalargs. Remove obsolete comments about cc bombing out.
3785
9851bfc5
JD
37862011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3787
51bb811f 3788 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3789 Let HAVE_GSETTINGS override HAVE_GCONF.
3790 (store_monospaced_changed): New function.
3791 (EMACS_SETTINGS): A new type derived from GObject to handle
3792 GSettings notifications.
3793 (emacs_settings_constructor, emacs_settings_get_property)
3794 (emacs_settings_set_property, emacs_settings_class_init):
3795 New functions.
3796 (gsettings_client, gsettings_obj): New variables.
3797 (GSETTINGS_SCHEMA): New define.
3798 (something_changedCB): Call store_monospaced_changed.
3799 (init_gsettings): New function.
3800 (xsettings_initialize): Call init_gsettings.
3801 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3802 to NULL.
3803
640c8776 3804 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3805 GCONF_CFLAGS/LIBS.
3806
5386012d
MR
38072011-06-29 Martin Rudalics <rudalics@gmx.at>
3808
3809 * window.c (resize_root_window, grow_mini_window)
3810 (shrink_mini_window): Rename Qresize_root_window to
3811 Qwindow_resize_root_window and Qresize_root_window_vertically to
3812 Qwindow_resize_root_window_vertically.
3813
f13e0b08
PE
38142011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3817
94515237
JB
38182011-06-27 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * makefile.w32-in: Redesign dependencies so they reflect more
3821 clearly which files are directly included by each source file,
3822 and not through other includes.
3823
e43b6e43
MR
38242011-06-27 Martin Rudalics <rudalics@gmx.at>
3825
3826 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3827 (sort_overlays, overlay_strings): When an overlay's clone number
3828 matches the window's clone number process the overlay even if
3829 the overlay's window property doesn't match the current window.
3830
d68443dc
MR
3831 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3832 (Fwindow_hchild): Rename to Fwindow_left_child.
3833 (Fwindow_next): Rename to Fwindow_next_sibling.
3834 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3835 (resize_window_check): Rename to window_resize_check.
3836 (resize_window_apply): Rename to window_resize_apply.
3837 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3838 (Fdelete_other_windows_internal, resize_frame_windows)
3839 (Fsplit_window_internal, Fdelete_window_internal)
3840 (grow_mini_window, shrink_mini_window)
3841 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3842
c7e73be5
JD
38432011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3844
3845 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3846 (emacs_fixed_set_min_size): Remove.
3847 (emacs_fixed_new): Take frame as argument.
3848
3849 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3850 (_EmacsFixedPrivate): Remove minwidth/height.
3851 Add struct frame *f.
3852 (emacs_fixed_init): Initialize priv->f.
3853 (get_parent_class, emacs_fixed_set_min_size): Remove.
3854 (emacs_fixed_new): Set priv->f to argument.
3855 (emacs_fixed_get_preferred_width)
3856 (emacs_fixed_get_preferred_height): Use min_width/height from
3857 frames size_hint to set minimum and natural (Bug#8919).
3858 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3859 and use min_width/height from frames size_hint to set
3860 min_width/height (Bug#8919).
3861
3862 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3863 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3864 Fix indentation.
c7e73be5 3865
cf99dcf8
EZ
38662011-06-26 Eli Zaretskii <eliz@gnu.org>
3867
3868 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3869 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3870 called at ZV.
3871
029529ac
CY
38722011-06-26 Chong Yidong <cyd@stupidchicken.com>
3873
3874 * process.c (wait_reading_process_output): Bypass select if
3875 waiting for a cell while ignoring keyboard input, and input is
3876 pending. Suggested by Jan Djärv (Bug#8869).
3877
7a7ef429
PE
38782011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3879
3880 Use gnulib's dup2 module instead of rolling our own.
3881 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3882
11fdef7d 38832011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3884
3885 * dispnew.c (scrolling_window): Before scrolling, turn off a
3886 mouse-highlight in the window being scrolled.
3887
cd3520a4
JB
38882011-06-24 Juanma Barranquero <lekktu@gmail.com>
3889
3890 Move DEFSYM to lisp.h and use everywhere.
3891
3892 * character.h (DEFSYM): Move declaration...
3893 * lisp.h (DEFSYM): ...here.
3894
3895 * gnutls.c:
3896 * minibuf.c:
3897 * w32menu.c:
3898 * w32proc.c:
3899 * w32select.c: Don't include character.h.
3900
3901 * alloc.c (syms_of_alloc):
3902 * buffer.c (syms_of_buffer):
3903 * bytecode.c (syms_of_bytecode):
3904 * callint.c (syms_of_callint):
3905 * casefiddle.c (syms_of_casefiddle):
3906 * casetab.c (init_casetab_once):
3907 * category.c (init_category_once, syms_of_category):
3908 * ccl.c (syms_of_ccl):
3909 * cmds.c (syms_of_cmds):
3910 * composite.c (syms_of_composite):
3911 * dbusbind.c (syms_of_dbusbind):
3912 * dired.c (syms_of_dired):
3913 * dispnew.c (syms_of_display):
3914 * doc.c (syms_of_doc):
3915 * editfns.c (syms_of_editfns):
3916 * emacs.c (syms_of_emacs):
3917 * eval.c (syms_of_eval):
3918 * fileio.c (syms_of_fileio):
3919 * fns.c (syms_of_fns):
3920 * frame.c (syms_of_frame):
3921 * fringe.c (syms_of_fringe):
3922 * insdel.c (syms_of_insdel):
3923 * keymap.c (syms_of_keymap):
3924 * lread.c (init_obarray, syms_of_lread):
3925 * macros.c (syms_of_macros):
3926 * msdos.c (syms_of_msdos):
3927 * print.c (syms_of_print):
3928 * process.c (syms_of_process):
3929 * search.c (syms_of_search):
3930 * sound.c (syms_of_sound):
3931 * syntax.c (init_syntax_once, syms_of_syntax):
3932 * terminal.c (syms_of_terminal):
3933 * textprop.c (syms_of_textprop):
3934 * undo.c (syms_of_undo):
3935 * w32.c (globals_of_w32):
3936 * window.c (syms_of_window):
3937 * xdisp.c (syms_of_xdisp):
3938 * xfaces.c (syms_of_xfaces):
3939 * xfns.c (syms_of_xfns):
3940 * xmenu.c (syms_of_xmenu):
3941 * xsettings.c (syms_of_xsettings):
3942 * xterm.c (syms_of_xterm): Use DEFSYM.
3943
4228cf16
TZ
39442011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3945
cd3520a4 3946 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3947
7fcccf1e
PE
39482011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3949
7efb4e0e
PE
3950 Integer and buffer overflow fixes (Bug#8873).
3951
ff5844ad
PE
3952 * print.c (printchar, strout): Check for string overflow.
3953 (PRINTPREPARE, printchar, strout):
3954 Don't set size unless allocation succeeds.
3955
90532f02
PE
3956 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3957 for sizes. Check for string overflow more accurately.
3958 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3959
6d84508d
PE
3960 * macros.c: Integer and buffer overflow fixes.
3961 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3962 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3963 Use ptrdiff_t, not int, for sizes.
3964 Don't increment bufsize until after realloc succeeds.
3965 Check for size-calculation overflow.
3966 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3967
437b2cb4
PE
3968 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3969
8b9ac8b4
PE
3970 * lread.c: Integer overflow fixes.
3971 (read_integer): Radix is now EMACS_INT, not int,
3972 to improve quality of diagnostics for out-of-range radices.
3973 Calculate buffer size correctly for out-of-range radices.
3974 (read1): Check for integer overflow in radices, and in
3975 read-circle numbers.
82cb60d3
PE
3976 (read_escape): Avoid int overflow.
3977 (Fload, openp, read_buffer_size, read1)
3978 (substitute_object_recurse, read_vector, read_list, map_obarray):
3979 Use ptrdiff_t, not int, for sizes.
3980 (read1): Use EMACS_INT, not int, for sizes.
20270765 3981 Check for size overflow.
8b9ac8b4 3982
7fcccf1e
PE
3983 * image.c (cache_image): Check for size arithmetic overflow.
3984
bfbbd7e7
PE
3985 * lread.c: Integer overflow issues.
3986 (saved_doc_string_size, saved_doc_string_length)
3987 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3988 Now ptrdiff_t, not int.
3989 (read1): Don't assume doc string length fits in int. Check for
3990 out-of-range doc string lengths.
3991 (read_list): Don't assume file position fits in int.
39019e54 3992 (read_escape): Check for hex character overflow.
bfbbd7e7 3993
4e323265
LL
39942011-06-22 Leo Liu <sdl.web@gmail.com>
3995
3996 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3997 Move to minibuffer.el.
3998
85fece3e
PE
39992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4000
20b84ce9 4001 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4002 The following patches are for when GLYPH_DEBUG && !XASSERT.
4003 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4004 * dispnew.c (flush_stdout):
4005 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4006 Mark as externally visible.
4007 * dispnew.c (check_window_matrix_pointers): Now static.
4008 * dispnew.c (window_to_frame_vpos):
4009 * xfns.c (unwind_create_frame):
4010 * xterm.c (x_check_font): Remove unused local.
4011 * scroll.c (CHECK_BOUNDS):
4012 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4013 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4014 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4015 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4016 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4017 Now static.
4018 (debug_method_add): Use va_list and vsprintf rather than relying
4019 on undefined behavior with wrong number of arguments.
4020 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4021 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4022 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4023 since we're not interested in debugging glyphs with old libraries.
4024 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4025 GCC 4.6.0's static checking.
4026
0766b489
PE
40272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4028
31fd4b32
PE
4029 Integer overflow and signedness fixes (Bug#8873).
4030 A few related buffer overrun fixes, too.
4031
b79e8648
PE
4032 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4033
0766b489
PE
4034 * dispextern.h (struct face.stipple):
4035 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4036 (x_bitmap_mask, x_allocate_bitmap_record)
4037 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4038 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4039 (x_create_bitmap_from_xpm_data):
4040 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4041 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4042 (.bitmaps_last):
4043 * xfaces.c (load_pixmap):
4044 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4045 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4046 (.bitmaps_last, struct x_output.icon_bitmap):
4047 Use ptrdiff_t, not int, for bitmap indexes.
4048 (x_allocate_bitmap_record): Check for size overflow.
4049 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4050
b081724f
PE
4051 Use ptrdiff_t, not int, for overlay counts.
4052 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4053 * editfns.c (overlays_around, get_pos_property):
4054 * textprop.c (get_char_property_and_overlay):
4055 * xdisp.c (next_overlay_change, note_mouse_highlight):
4056 * xfaces.c (face_at_buffer_position):
21514da7
PE
4057 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4058 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4059 (Fnext_overlay_change, Fprevious_overlay_change)
4060 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4061 Use ptrdiff_t, not int, for sizes.
21514da7 4062 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4063
3de73e5e
PE
4064 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4065
2606c57b
PE
4066 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4067 (x_session_initialize): Do not assume string length fits in int.
4068
aaafe47a
PE
4069 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4070 This is unlikely, but can occur if DPI is outlandish.
4071
2674ddc8 4072 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4073 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4074
28154962
PE
4075 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4076 * xrdb.c (magic_file_p, search_magic_path):
4077 Omit last arg SUFFIX; it was always 0. All callers changed.
4078 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4079
7de51af5
PE
4080 * xfont.c (xfont_match): Avoid need for strlen.
4081
25ed6cc3
PE
4082 * xfns.c: Don't assume strlen fits in int.
4083 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4084
4eab31dd
PE
4085 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4086 not unsigned long, as we prefer signed integers. All callers changed.
4087 Detect integer overflow in repeat count.
4088 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4089 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4090
171e2a58
PE
4091 * termcap.c: Don't assume sizes fit in int and never overflow.
4092 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4093 (gobble_line): Check for size-calculation overflow.
4094
ad39faca 4095 * minibuf.c (Fread_buffer):
6e5bb2dc 4096 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4097 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4098 Don't assume string length fits in int.
4099
52c61c22 4100 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4101 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4102
b5b8c9e5
PE
4103 * font.c: Don't assume string length fits in int.
4104 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4105 Use ptrdiff_t, not int.
ccd6111c
PE
4106 (font_intern_prop): Don't assume string length fits in int.
4107 Don't assume integer property fits in fixnum.
4108 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4109
882f0d81 4110 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4111 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4112 Reformulate so as not to need the command string.
4113 Invoke gzip -cd rather than gunzip, as it's more portable.
4114 (lock_info_type, lock_file_1, lock_file):
4115 Don't assume pid_t and time_t fit in unsigned long.
4116 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4117 (current_lock_owner): Prefer signed type for sizes.
4118 Use memcpy, not strncpy, where memcpy is what is really wanted.
4119 Don't assume (via atoi) that time_t and pid_t fit in int.
4120 Check for time_t and/or pid_t out of range, e.g., via a network share.
4121 Don't alloca where an auto var works fine.
4122
93f4cf88
PE
4123 * fileio.c: Fix some integer overflow issues.
4124 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4125 Don't assume string length fits in int.
4126 (directory_file_name): Don't assume string length fits in long.
4127 (make_temp_name): Don't assume pid fits in int, or that its print
4128 length is less than 20.
4129
f3e92b69
PE
4130 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4131
1bfdaf10
PE
4132 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4133
35016e9a
PE
4134 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4135
3d1e65a1
PE
4136 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4137 We prefer signed integers, even for size calculations.
4138
0b963a93
PE
4139 * emacs.c: Don't assume string length fits in 'int'.
4140 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4141 (main): Don't invoke strlen when not needed.
4142
573f4b54
PE
4143 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4144 (XD_DEBUG_MESSAGE): Don't waste a byte.
4145
989f33ba
PE
4146 * callproc.c (getenv_internal_1, getenv_internal)
4147 (Fgetenv_internal):
965d34eb
PE
4148 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4149
e4d29b33
PE
4150 * lread.c (invalid_syntax): Omit length argument.
4151 All uses changed. This doesn't fix a bug, but it simplifies the
4152 code away from its former Hollerith-constant appearance, and it's
4153 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4154 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4155
eb49b136
PE
4156 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4157 This didn't break anything, but it didn't help either.
4158 It's confusing to put a bogus integer in a place where the actual
4159 value does not matter.
9f62aeb1 4160 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4161 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4162
15375a22
PE
4163 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4164 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4165 implementation.
b61cc01c
PE
4166 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4167 We prefer signed types, and the value cannot exceed the EMACS_INT
4168 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4169 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4170 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4171 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4172
53b2623d
PE
4173 * indent.c (sane_tab_width): New function.
4174 (current_column, scan_for_column, Findent_to, position_indentation)
4175 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4176 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4177
51cab52b 4178 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4179
f2ed8a70
PE
4180 * lisp.h (lint_assume): New macro.
4181 * composite.c (composition_gstring_put_cache):
4182 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4183
abe80cc6
PE
4184 * editfns.c, insdel.c:
4185 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4186
b02c740e
PE
4187 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4188
ebc96716
PE
4189 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4190
b4e50fa0 4191 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4192 Use much-faster test for byte-length change.
311d5d7c 4193 Don't assume string byte-length fits in 'int'.
a4cf38e4 4194 Check that character arg fits in 'int'.
85461888 4195 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4196
c0c1ee9f
PE
4197 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4198
a498d7f4
PE
4199 * fns.c (concat): Catch string overflow earlier.
4200 Do not rely on integer wraparound.
4201
51cab52b
PE
4202 * dispextern.h (struct it.overlay_strings_charpos)
4203 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4204 * xdisp.c (forward_to_next_line_start)
4205 (back_to_previous_visible_line_start)
4206 (reseat_at_next_visible_line_start, next_element_from_buffer):
4207 Don't arbitrarily truncate the value of 'selective' to int.
4208
76031fad
PE
4209 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4210
5eb55db9
PE
4211 * composite.c: Don't truncate sizes to 'int'.
4212 (composition_gstring_p, composition_reseat_it)
4213 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4214 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4215 not EMACS_UINT, for indexes.
5eb55db9 4216
0703a717
PE
4217 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4218
d6202519
PE
4219 * buffer.c: Include <verify.h>.
4220 (struct sortvec.priority, struct sortstr.priority):
8961a454 4221 Now EMACS_INT, not int.
c20998a7 4222 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4223 (struct sortstr.size, record_overlay_string)
4224 (struct sortstrlist.size, struct sortlist.used):
4225 Don't truncate size to int.
4226 (record_overlay_string): Check for size-calculation overflow.
d6202519 4227 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4228
d5a19415
JM
42292011-06-22 Jim Meyering <meyering@redhat.com>
4230
029529ac 4231 Don't leak an XBM-image-sized buffer
d5a19415
JM
4232 * image.c (xbm_load): Free the image buffer after using it.
4233
a9041e6c
PE
42342011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 Port to Sun C.
4237 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4238 that Sun C diagnosed.
4239 * fns.c (secure_hash): Fix pointer signedness issue.
4240 * intervals.c (static_offset_intervals): New function.
4241 (offset_intervals): Use it.
4242
7f3f739f
LL
42432011-06-21 Leo Liu <sdl.web@gmail.com>
4244
4245 * deps.mk (fns.o):
4246 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4247 sha512.h.
4248
4249 * fns.c (secure_hash): Rename from crypto_hash_function and change
4250 the first arg to accept symbols.
5b66d427 4251 (Fsecure_hash): New primitive.
7f3f739f
LL
4252 (syms_of_fns): New symbols.
4253
76147d94
DD
42542011-06-20 Deniz Dogan <deniz@dogan.se>
4255
4256 * process.c (Fset_process_buffer): Clarify return value in
4257 docstring.
4258
7d7d0045
CY
42592011-06-18 Chong Yidong <cyd@stupidchicken.com>
4260
4261 * dispnew.c (add_window_display_history): Use BVAR.
4262
4263 * xdisp.c (debug_method_add): Use BVAR.
4264 (check_window_end, dump_glyph_matrix, dump_glyph)
4265 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4266
4267 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4268 Likewise.
4269
4270 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4271 check till after the cache is created in init_frame_faces.
4272
ff2bc410
SM
42732011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4274
4275 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4276
28177add
PE
42772011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4278
dd3482fe
PE
4279 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4280 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4281 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4282
393d71f3 4283 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4284 * fileio.c (Finsert_file_contents):
4285 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4286 Remove the old (too-loose) buffer overflow checks.
4287 They weren't needed, since make_gap checks for buffer overflow.
4288 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4289 The old code merely checked for Emacs fixnum overflow, and relied
4290 on undefined (wraparound) behavior. The new code avoids undefined
4291 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4292
2e6813b0 4293 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4294 Tune. Don't use wider integers than needed. Don't use alloca.
4295 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4296
599a9e4f
PE
4297 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4298
99561444
PE
4299 * insdel.c, lisp.h (buffer_overflow): New function.
4300 (insert_from_buffer_1, replace_range, replace_range_2):
4301 * insdel.c (make_gap_larger):
4302 * editfns.c (Finsert_char):
4303 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4304
28177add
PE
4305 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4306
e69dafad
PE
43072011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4308
a7af7fde 4309 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4310
b1c46f02
PE
4311 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4312 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4313
e69dafad
PE
4314 * fileio.c: Don't assume EMACS_INT fits in off_t.
4315 (emacs_lseek): New static function.
4316 (Finsert_file_contents, Fwrite_region): Use it.
4317 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4318
566684ea
PE
4319 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4320
e6966cd6
PE
4321 * fns.c: Don't overflow int when computing a list length.
4322 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4323 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4324 truncation on 64-bit hosts. Check for QUIT every
4325 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4326 faster and is responsive enough.
4327 (Flength): Report an error instead of overflowing an integer.
4328 (Fsafe_length): Return a float if the value is not representable
4329 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4330 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4331 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4332
dd0b0efb
PE
4333 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4334 (header_size, word_size): New constants.
4335 (allocate_vectorlike): Don't check size overflow here.
4336 (allocate_vector): Check it here instead, since this is the only
4337 caller of allocate_vectorlike that could cause overflow.
4338 Check that the new vector's length is representable as a fixnum.
4339
86fe5cfe
PE
4340 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4341 The previous code was bogus. For example, next_almost_prime (32)
4342 returned 39, which is undesirable as it is a multiple of 3; and
4343 next_almost_prime (24) returned 25, which is a multiple of 5 so
4344 why was the code bothering to check for multiples of 7?
4345
80e88859
PE
4346 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4347
4a2f0ad6
PE
4348 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4349
f66c7cf8
PE
4350 Variadic C functions now count arguments with ptrdiff_t.
4351 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4352 Back then I didn't know that the Emacs coding style prefers signed int.
4353 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4354 were being counted with int, which may truncate counts on 64-bit
4355 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4356 * lisp.h (struct Lisp_Subr.function.aMANY)
4357 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4358 Arg counts are now ptrdiff_t, not size_t.
4359 All variadic functions and their callers changed accordingly.
4360 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4361 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4362 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4363 * callint.c (Fcall_interactively): Check arg count for overflow,
4364 to avoid potential buffer overrun. Use signed char, not 'int',
4365 for 'varies' array, so that we needn't bother to check its size
4366 calculation for overflow.
4367 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4368 * eval.c (apply_lambda):
4369 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4370 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4371 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4372
a1759b76
PE
4373 * callint.c (Fcall_interactively): Don't use index var as event count.
4374
d96be9fc
PE
4375 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4376 * mem-limits.h (SIZE): Remove; no longer used.
4377
a690a978 4378 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4379
578c21e6
PE
4380 Remove unnecessary casts.
4381 * xterm.c (x_term_init):
4382 * xfns.c (x_set_border_pixel):
4383 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4384 These aren't needed now that we assume ANSI C.
4385
96f53c6c
PE
4386 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4387 It's more likely to cause problems (due to unsigned overflow)
4388 than to cure them.
4389
83c77d31
PE
4390 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4391
ee2079f1
PE
4392 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4393
6da65536
PE
4394 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4395
7147c4a4
PE
4396 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4397
193e32d9
PE
4398 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4399
e5533da6
PE
4400 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4401
9910e595
PE
4402 GLYPH_CODE_FACE returns EMACS_INT, not int.
4403 * dispextern.h (merge_faces):
4404 * xfaces.c (merge_faces):
01103c44
PE
4405 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4406 Don't assume EMACS_INT fits in int.
9910e595 4407
2638320e
PE
4408 * character.h (CHAR_VALID_P): Remove unused parameter.
4409 * fontset.c, lisp.h, xdisp.c: All uses changed.
4410
045eb8d9
PE
4411 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4412
c1f134b5
PE
4413 * fns.c (concat): Minor tuning based on overflow analysis.
4414 This doesn't fix any bugs. Use int to hold character, instead
4415 of constantly refetching from Emacs object. Use XFASTINT, not
4416 XINT, for value known to be a character. Don't bother comparing
4417 a single byte to 0400, as it's always less.
4418
395fcb93 4419 * floatfns.c (Fexpt):
327eeec8
PE
4420 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4421
abbd3d23
PE
4422 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4423 for characters.
4424
684a03ef
PE
4425 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4426
0fed43f3
PE
4427 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4428 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4429 incorrectly succeed when S was a string, because 4294967386 was
4430 truncated before it was used.
4431
8fd02eb7
PE
4432 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4433 Otherwise, an out-of-range integer could cause undefined behavior
4434 on a 64-bit host.
4435
f8c86b69
PE
4436 * composite.c: Use int, not EMACS_INT, for characters.
4437 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4438 EMACS_INT, for values that are known to be in character range.
4439 This doesn't fix any bugs but is the usual style inside Emacs and
4440 may generate better code on 32-bit machines.
4441
34206dd2
PE
4442 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4443 This is for reasons similar to the recent CHAR_STRING fix.
4444 * charset.c (Fencode_char): Check that character arg is actually
4445 a character. Pass an int to ENCODE_CHAR.
4446 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4447 wider than 'int', as a compile-time check to prevent future regressions
4448 in this area.
4449
c5958d4c 4450 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4451
4452 Make sure a 64-bit char is never passed to CHAR_STRING.
4453 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4454 by silently ignoring the top 32 bits, allowing some values
4455 that were far too large to be valid characters.
4456 * character.h: Include <verify.h>.
4457 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4458 arguments are no wider than unsigned, as a compile-time check
4459 to prevent future regressions in this area.
4460 * data.c (Faset):
01103c44 4461 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4462 (Fsubst_char_in_region):
4463 * fns.c (concat):
4464 * xdisp.c (decode_mode_spec_coding):
4465 Adjust to CHAR_STRING's new requirement.
4466 * editfns.c (Finsert_char, Fsubst_char_in_region):
4467 * fns.c (concat): Check that character args are actually
4468 characters. Without this test, these functions did the wrong
4469 thing with wildly out-of-range values on 64-bit hosts.
4470
d37ca623
PE
4471 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4472 These casts should not be needed on 32-bit hosts, either.
4473 * keyboard.c (read_char):
4474 * lread.c (Fload): Remove casts to unsigned.
4475
ea204efb
PE
4476 * lisp.h (UNSIGNED_CMP): New macro.
4477 This fixes comparison bugs on 64-bit hosts.
4478 (ASCII_CHAR_P): Use it.
4479 * casefiddle.c (casify_object):
01103c44 4480 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4481 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4482 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4483 * dispextern.h (FACE_FROM_ID):
4484 * keyboard.c (read_char): Use UNSIGNED_CMP.
4485
41cb286c
PE
4486 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4487 not to EMACS_INT, to avoid GCC warning.
4488
4a1b9832
PE
4489 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4490
55daad71
PE
4491 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4492 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4493 isn't needed on 32-bit machines.
8f95c75c 4494
01103c44
PE
4495 * buffer.c (Fgenerate_new_buffer_name):
4496 Use EMACS_INT for count, not int.
0ceccced 4497 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4498
4499 * data.c (Qcompiled_function): Now static.
4500
c6f072e7
PE
4501 * window.c (window_body_lines): Now static.
4502
20ce5912
PE
4503 * image.c (gif_load): Rename local to avoid shadowing.
4504
9c4c5f81
PE
4505 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4506 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4507 * alloc.c (make_save_value): Integer argument is now of type
4508 ptrdiff_t, not int.
4509 (mark_object): Use ptrdiff_t, not int.
4510 * lisp.h (pD): New macro.
4511 * print.c (print_object): Use it.
4512
c0c5c8ae
PE
4513 * alloc.c: Use EMACS_INT, not int, to count objects.
4514 (total_conses, total_markers, total_symbols, total_vector_size)
4515 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4516 (total_free_floats, total_floats, total_free_intervals)
4517 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4518 Now EMACS_INT, not int. All uses changed.
4519 (Fgarbage_collect): Compute overall total using a double, so that
4520 integer overflow is less likely to be a problem. Check for overflow
4521 when converting back to an integer.
5a25e253
PE
4522 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4523 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4524 These were 'int' variables that could overflow on 64-bit hosts;
4525 they were never used, so remove them instead of repairing them.
211a0b2a 4526 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4527 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4528 Previously, this ceilinged at INT_MAX, but that doesn't work on
4529 64-bit machines.
e46bb31a 4530 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4531
c78baabf 4532 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4533 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4534 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4535 when a (possibly-narrower) signed value would do just as well.
4536 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4537
c9d624c6
PE
4538 * alloc.c: Catch some string size overflows that we were missing.
4539 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4540 for convenience in STRING_BYTES_MAX.
4541 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4542 The definition here is exact; the one in lisp.h was approximate.
4543 (allocate_string_data): Check for string overflow. This catches
4544 some instances we weren't catching before. Also, it catches
4545 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4546 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4547 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4548
c9d624c6
PE
4549 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4550 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4551 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4552
353032ce
PE
4553 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4554
2bccce07
PE
4555 * alloc.c (Fmake_string): Check for out-of-range init.
4556
0ac30604
SM
45572011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4558
4559 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4560
c195f2de
JD
45612011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4562
4563 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4564 xg_get_default_scrollbar_width.
4565
4566 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4567 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4568 (style_changed_cb): Call update_theme_scrollbar_width and call
4569 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4570 all frames (Bug#8505).
4571 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4572 Call gtk_window_set_resizable if HAVE_GTK3.
4573 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4574 and height if HAVE_GTK3 (Bug#8505).
4575 (scroll_bar_width_for_theme): New variable.
4576 (update_theme_scrollbar_width): New function.
4577 (xg_get_default_scrollbar_width): Move code to
4578 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4579 (xg_initialize): Call update_theme_scrollbar_width.
4580
4581 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4582
4583 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4584
e10ac9f1
MR
45852011-06-12 Martin Rudalics <rudalics@gmx.at>
4586
4587 * frame.c (make_frame): Call other_buffer_safely instead of
4588 other_buffer.
4589
4590 * window.c (temp_output_buffer_show): Call display_buffer with
4591 second argument Vtemp_buffer_show_specifiers and reset latter
4592 immediately after the call.
4593 (Vtemp_buffer_show_specifiers): New variable.
4594 (auto_window_vscroll_p, next_screen_context_lines)
4595 (Vscroll_preserve_screen_position): Remove leading asterisks from
4596 doc-strings.
4597
2d3c217e 45982011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4599
7b7f97e8 4600 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4601 * buffer.c (Qclone_number): Remove for now, as it's unused.
4602 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4603 (record_buffer): Remove unused local.
4604 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4605 (set_frame_buffer_list): Remove; unused.
4606 * frame.h (other_visible_frames): Remove decl.
4607 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4608 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4609 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4610 if HAVE_GPM.
4611 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4612 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4613 Define only if HAVE_GPM.
4614 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4615 (update_hints_inhibit): Remove; never set. All uses removed.
4616 * widgetprv.h (emacsFrameClassRec): Remove decl.
4617 * window.c (delete_deletable_window): Now returns void, since it
4618 wasn't returning anything.
4619 (compare_window_configurations): Remove unused locals.
4620 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4621 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4622 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4623 the same widths as pointers. This follows up on the 2011-05-06 patch.
4624 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4625 * xterm.h: Likewise.
4626 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4627
1384b89e
JB
46282011-06-12 Juanma Barranquero <lekktu@gmail.com>
4629
4630 * makefile.w32-in: Update dependencies.
4631 (LISP_H): Add lib/intprops.h.
4632
1100a63c
CY
46332011-06-11 Chong Yidong <cyd@stupidchicken.com>
4634
4635 * image.c (gif_load): Add animation frame delay to the metadata.
4636 (syms_of_image): Use DEFSYM. New symbol `delay'.
4637
6198ccd0
MR
46382011-06-11 Martin Rudalics <rudalics@gmx.at>
4639
4640 * window.c (delete_deletable_window): Re-add.
4641 (Fset_window_configuration): Rewrite to handle dead buffers and
4642 consequently deletable windows.
4643 (window_tree, Fwindow_tree): Remove. Supply functionality in
4644 window.el.
4645 (compare_window_configurations): Simplify code.
4646
b6e3633c
AS
46472011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4648
1ab0dee5
AS
4649 * image.c (imagemagick_load_image): Fix type mismatch.
4650 (Fimagemagick_types): Likewise.
4651
b6e3633c
AS
4652 * window.h (replace_buffer_in_windows): Declare.
4653
9397e56f
MR
46542011-06-11 Martin Rudalics <rudalics@gmx.at>
4655
4656 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4657 Qclone_number. Remove external declaration of Qdelete_window.
4658 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4659 code.
640c8776
SM
4660 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4661 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4662 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4663 buffer list implementation.
4664 (other_buffer_safely): New function.
4665 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4666 calls to replace_buffer_in_windows and
4667 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4668 if allowed.
4669 (record_buffer): Inhibit quitting and rewrite using quittable
4670 functions. Run Qbuffer_list_update_hook if allowed.
4671 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4672 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4673 Move switch-to-buffer to window.el.
9397e56f
MR
4674 (bury-buffer): Move to window.el.
4675 (Vbuffer_list_update_hook): New variable.
4676
4677 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4678 section.
4679
4680 * window.h (resize_frame_windows): Move up in code.
4681 (Fwindow_frame): Remove EXFUN.
4682 (replace_buffer_in_all_windows): Remove prototype.
4683 (replace_buffer_in_windows_safely): Add prototype.
4684
4685 * window.c: Declare Qdelete_window static again. Move down
4686 declaration of select_count.
4687 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4688 (Fother_window): Move to window.el.
4689 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4690 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4691 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4692 window.el.
4693 (replace_buffer_in_windows): Implement by calling
4694 Qreplace_buffer_in_windows.
4695 (replace_buffer_in_all_windows): Remove with some functionality
4696 moved into replace_buffer_in_windows_safely.
4697 (replace_buffer_in_windows_safely): New function.
4698 (select_window_norecord, select_frame_norecord): Move in front
4699 of run_window_configuration_change_hook. Remove now obsolete
4700 declarations.
640c8776
SM
4701 (Fset_window_buffer): Rewrite doc-string.
4702 Call Qrecord_window_buffer.
9397e56f
MR
4703 (keys_of_window): Move binding for other-window to window.el.
4704
b50691aa
CY
47052011-06-11 Chong Yidong <cyd@stupidchicken.com>
4706
4707 * dispextern.h (struct image): Replace data member, whose int_val
4708 and ptr_val fields were not used by anything, with a single
4709 lisp_val object.
4710
4711 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4712 (gif_clear_image, gif_load, imagemagick_load_image)
4713 (gs_clear_image, gs_load): Callers changed.
4714
3f754b86
PE
47152011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4716
cca69397
PE
4717 * buffer.h: Include <time.h>, for time_t.
4718 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4719
109e28d0
PE
4720 Fix minor problems found by static checking.
4721
60737f02
PE
4722 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4723
4b66faf3
PE
4724 Make identifiers static if they are not used in other modules.
4725 * data.c (Qcompiled_function, Qframe, Qvector):
4726 * image.c (QimageMagick, Qsvg):
4727 * minibuf.c (Qmetadata):
4728 * window.c (resize_window_check, resize_root_window): Now static.
4729 * window.h (resize_window_check, resize_root_window): Remove decls.
4730
109e28d0
PE
4731 * window.c (window_deletion_count, delete_deletable_window):
4732 Remove; unused.
46a4ce9e
PE
4733 (window_body_lines): Now static.
4734 (Fdelete_other_windows_internal): Mark vars as initialized.
4735 Make sure 'resize_failed' is initialized.
4736 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4737 (resize_window_apply): Remove unused local.
4738 * window.h (delete_deletable_window): Remove decl.
4739
109e28d0 4740 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4741 (imagemagick_load_image): Fix pointer signedness problem by changing
4742 last arg from unsigned char * to char *. All uses changed.
4743 Also, fix a local for similar reasons.
4744 Remove unused locals. Remove locals to avoid shadowing.
4745 (fn_rsvg_handle_free): Remove; unused.
4746 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4747 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4748
3f754b86
PE
4749 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4750
2547adb1
CY
47512011-06-10 Chong Yidong <cyd@stupidchicken.com>
4752
4753 * image.c (gif_load): Fix omitted cast error introduced by
4754 2011-06-06 change.
4755
2c8e37d4
MR
47562011-06-10 Martin Rudalics <rudalics@gmx.at>
4757
4758 * window.h (resize_proportionally, orig_total_lines)
4759 (orig_top_line): Remove from window structure.
4760 (set_window_height, set_window_width, change_window_heights)
4761 (Fdelete_window): Remove prototypes.
4762 (resize_frame_windows): Remove duplicate declaration.
4763
440a42e3
EZ
47642011-06-10 Eli Zaretskii <eliz@gnu.org>
4765
4766 * window.h (resize_frame_windows, resize_window_check)
4767 (delete_deletable_window, resize_root_window)
4768 (resize_frame_windows): Declare prototypes.
4769
4770 * window.c (resize_window_apply): Make definition be "static" to
4771 match the prototype.
4772
562dd5e9
MR
47732011-06-10 Martin Rudalics <rudalics@gmx.at>
4774
4775 * window.c: Remove declarations of Qwindow_size_fixed,
4776 window_min_size_1, window_min_size_2, window_min_size,
4777 size_window, window_fixed_size_p, enlarge_window, delete_window.
4778 Remove static from declaration of Qdelete_window, it's
4779 temporarily needed by Fbury_buffer.
4780 (replace_window): Don't assign orig_top_line and
4781 orig_total_lines.
4782 (Fdelete_window, delete_window): Remove. Window deletion is
4783 handled by window.el.
640c8776
SM
4784 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4785 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4786 (Fdelete_other_windows): Remove. Deleting other windows is
4787 handled by window.el.
4788 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4789 handled in window.el.
4790 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4791 Window minimum sizes are handled in window.el.
4792 (shrink_windows, size_window, set_window_height)
4793 (set_window_width, change_window_heights, window_height)
4794 (window_width, CURBEG, CURSIZE, enlarge_window)
4795 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4796 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4797 handled in window.el.
4798 (make_dummy_parent): Rename to make_parent_window and give it a
4799 second argument horflag.
4800 (make_window): Don't set resize_proportionally any more.
4801 (Fsplit_window): Remove. Windows are split in window.el.
4802 (save_restore_action, save_restore_orig_size)
4803 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4804 Resize mini windows in window.el.
4805 (grow_mini_window, shrink_mini_window): Implement by calling
4806 Qresize_root_window_vertically, resize_window_check and
4807 resize_window_apply.
640c8776
SM
4808 (saved_window, Fset_window_configuration, save_window_save):
4809 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4810 resize_proportionally.
4811 (window_min_height, window_min_width): Move to window.el.
4812 (keys_of_window): Move bindings for delete-other-windows,
4813 split-window, delete-window and enlarge-window to window.el.
4814
4815 * buffer.c: Temporarily extern Qdelete_window.
4816 (Fbury_buffer): Temporarily call Qdelete_window instead of
4817 Fdelete_window (Fbury_buffer will move to window.el soon).
4818
4819 * frame.c (set_menu_bar_lines_1): Remove code handling
4820 orig_top_line and orig_total_lines.
4821
4822 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4823 set_window_height but set heights directly.
4824 (change_frame_size_1): Use resize_frame_windows.
4825
4826 * xdisp.c (init_xdisp): Don't use set_window_height but set
4827 heights directly.
4828
640c8776
SM
4829 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4830 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4831 run_window_configuration_change_hook.
4832
4833 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4834 instead of change_window_heights and run
4835 run_window_configuration_change_hook.
4836
1a13852e
MR
48372011-06-09 Martin Rudalics <rudalics@gmx.at>
4838
4839 * window.c (replace_window): Rename second argument REPLACEMENT to
4840 NEW. New third argument SETFLAG. Rewrite.
4841 (delete_window, make_dummy_parent): Call replace_window with
4842 third argument 1.
4843 (window_list_1): Move down in code.
4844 (run_window_configuration_change_hook): Move set_buffer part
4845 before select_frame_norecord part in order to unwind correctly.
4846 Rename count1 to count.
4847 (recombine_windows, delete_deletable_window, resize_root_window)
4848 (Fdelete_other_windows_internal)
4849 (Frun_window_configuration_change_hook, make_parent_window)
4850 (resize_window_check, resize_window_apply, Fresize_window_apply)
4851 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4852 (Fdelete_window_internal, Fresize_mini_window_internal):
4853 New functions.
1a13852e
MR
4854 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4855
f3d1777e
MR
48562011-06-08 Martin Rudalics <rudalics@gmx.at>
4857
496e208e
MR
4858 * window.h (window): Add some new members to window structure -
4859 normal_lines, normal_cols, new_total, new_normal, clone_number,
4860 splits, nest, prev_buffers, next_buffers.
4861 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4862 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4863
f3d1777e
MR
4864 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4865 Remove.
496e208e
MR
4866 (make_dummy_parent): Set new members of windows structure.
4867 (make_window): Move down in code. Handle new members of window
4868 structure.
4869 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4870 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4871 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4872 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4873 (Fset_window_next_buffers, Fset_window_clone_number):
4874 New functions.
496e208e
MR
4875 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4876 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4877 Doc-string fixes.
4878 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4879 Argument WINDOW can be now internal window too.
4880 (Fwindow_use_time): Move up in code.
4881 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4882 Rewrite doc-string.
4883 (Fset_window_configuration, saved_window)
4884 (Fcurrent_window_configuration, save_window_save): Handle new
4885 members of window structure.
b9e809c2
MR
4886 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4887 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4888 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4889 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4890 Qget_mru_window, Qresize_root_window,
4891 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4892 Qauto_buffer_name; staticpro them.
f3d1777e 4893
abde8f8c
MR
48942011-06-07 Martin Rudalics <rudalics@gmx.at>
4895
4896 * window.c (Fwindow_total_size, Fwindow_left_column)
4897 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4898 (Fwindow_list_1): New functions.
4899 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4900 (Fwindow_width, Fscroll_left, Fscroll_right):
4901 Use window_body_cols instead of window_box_text_cols.
4902 (delete_window, Fset_window_configuration):
4903 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4904 (delete_all_subwindows): Take a window as argument and not a
4905 structure. Rewrite.
190b47e6
MR
4906 (window_loop): Remove handling of GET_LRU_WINDOW and
4907 GET_LARGEST_WINDOW.
4908 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4909
4910 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4911 window_box_text_cols. delete_all_subwindows now takes a
4912 Lisp_Object as argument.
abde8f8c 4913
640c8776
SM
4914 * indent.c (compute_motion, Fcompute_motion):
4915 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4916
fa8a67e6
MR
4917 * frame.c (delete_frame): Call delete_all_subwindows with root
4918 window as argument.
4919
a54e3482
DC
49202011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4921
4922 * fns.c (Fputhash): Document return value.
4923
60002bf5
CY
49242011-06-06 Chong Yidong <cyd@stupidchicken.com>
4925
4926 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4927
0c671da6 49282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4929
b862a52a 4930 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4931
be44ca6c
PE
4932 Check for overflow when converting integer to cons and back.
4933 * charset.c (Fdefine_charset_internal, Fdecode_char):
4934 Use cons_to_unsigned to catch overflow.
4935 (Fencode_char): Use INTEGER_TO_CONS.
4936 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4937 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4938 * data.c (long_to_cons, cons_to_long): Remove.
4939 (cons_to_unsigned, cons_to_signed): New functions.
4940 These signal an error for invalid or out-of-range values.
4941 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4942 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4943 * font.c (Ffont_variation_glyphs):
4944 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4945 * lisp.h: Include <intprops.h>.
4946 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4947 (cons_to_signed, cons_to_unsigned): New decls.
4948 (long_to_cons, cons_to_long): Remove decls.
4949 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4950 (Fprimitive_undo): Use CONS_TO_INTEGER.
4951 * xfns.c (Fx_window_property): Likewise.
4952 * xselect.c: Include <limits.h>.
4953 (x_own_selection, selection_data_to_lisp_data):
4954 Use INTEGER_TO_CONS.
4955 (x_handle_selection_request, x_handle_selection_clear)
4956 (x_get_foreign_selection, Fx_disown_selection_internal)
4957 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4958 (lisp_data_to_selection_data): Use cons_to_unsigned.
4959 (x_fill_property_data): Use cons_to_signed.
4960 Report values out of range.
4961
d1f3d2af
PE
4962 Check for buffer and string overflow more precisely.
4963 * buffer.h (BUF_BYTES_MAX): New macro.
4964 * lisp.h (STRING_BYTES_MAX): New macro.
4965 * alloc.c (Fmake_string):
4966 * character.c (string_escape_byte8):
4967 * coding.c (coding_alloc_by_realloc):
4968 * doprnt.c (doprnt):
4969 * editfns.c (Fformat):
4970 * eval.c (verror):
4971 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4972 since they may not be the same number.
4973 * editfns.c (Finsert_char):
4974 * fileio.c (Finsert_file_contents):
4975 Likewise for BUF_BYTES_MAX.
4976
dd52fcea
PE
4977 * image.c: Use ptrdiff_t, not int, for sizes.
4978 (slurp_file): Switch from int to ptrdiff_t.
4979 All uses changed.
4980 (slurp_file): Check that file size fits in both size_t (for
4981 malloc) and ptrdiff_t (for sanity and safety).
4982
7f9bbdbb
PE
4983 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4984 if b->modtime has its maximal value.
4985
dfe18f82
PE
4986 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4987
84acfcf0
PE
4988 Don't assume time_t can fit into int.
4989 * buffer.h (struct buffer.modtime): Now time_t, not int.
4990 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4991 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4992
ccd9a01a
PE
4993 Minor fixes for signed vs unsigned integers.
4994 * character.h (MAYBE_UNIFY_CHAR):
4995 * charset.c (maybe_unify_char):
4996 * keyboard.c (read_char, reorder_modifiers):
4997 XINT -> XFASTINT, since the integer must be nonnegative.
4998 * ftfont.c (ftfont_spec_pattern):
4999 * keymap.c (access_keymap, silly_event_symbol_error):
5000 XUINT -> XFASTINT, since the integer must be nonnegative.
5001 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5002 since it makes no difference and we prefer signed.
5003 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5004 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5005 nonnegative.
5006
d6d100dd
SM
50072011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5008
5009 * window.h (Fwindow_frame): Declare.
5010
2b6148e4
PE
50112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5012
5013 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5014 (SPARE_MEMORY): Always define.
5015 (LARGE_REQUEST): Remove.
5016 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5017
f230ecc9
MR
50182011-06-06 Martin Rudalics <rudalics@gmx.at>
5019
727e958e
MR
5020 * lisp.h: Move EXFUNS for Fframe_root_window,
5021 Fframe_first_window and Fset_frame_selected_window to window.h.
5022
5023 * window.h: Move EXFUNS for Fframe_root_window,
5024 Fframe_first_window and Fset_frame_selected_window here from
5025 lisp.h.
5026
5027 * frame.c (Fwindow_frame, Fframe_first_window)
5028 (Fframe_root_window, Fframe_selected_window)
5029 (Fset_frame_selected_window): Move to window.c.
5030 (Factive_minibuffer_window): Move to minibuf.c.
5031 (Fother_visible_frames_p): New function.
5032
5033 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5034
f230ecc9
MR
5035 * window.c (decode_window, decode_any_window): Move up in code.
5036 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5037 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5038 (Fwindow_buffer): Move up and rewrite doc-string.
5039 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5040 (Fwindow_prev): New functions.
727e958e
MR
5041 (Fwindow_frame): Move here from frame.c. Accept any window as
5042 argument.
5043 (Fframe_root_window, Fframe_first_window)
5044 (Fframe_selected_window): Move here from frame.c. Accept frame
5045 or arbitrary window as argument. Update doc-strings.
5046 (Fminibuffer_window): Move up in code.
5047 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5048 (Fset_frame_selected_window): Move here from frame.c.
5049 Marginal rewrite.
727e958e
MR
5050 (Fselected_window, select_window, Fselect_window): Move up in
5051 code. Minor doc-string fixes.
f230ecc9 5052
4d09bcf6
PE
50532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5054
5055 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5056 Do not assume that spare memory exists; that assumption is valid
5057 only if SYSTEM_MALLOC.
5058 (LARGE_REQUEST): New macro, so that the issue of large requests
5059 is separated from the issue of spare memory.
5060
810928a2
AS
50612011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5062
172418ad
AS
5063 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5064 format. (Bug#8806)
5065
43f862f7
AS
5066 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5067
810928a2
AS
5068 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5069 before statements.
5070
a059fe24
JD
50712011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5072
5073 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5074
5075 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5076
5077 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5078 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5079
989bf368
JB
50802011-06-05 Juanma Barranquero <lekktu@gmail.com>
5081
5082 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5083
4b80f674
CY
50842011-06-04 Chong Yidong <cyd@stupidchicken.com>
5085
5086 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5087 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5088 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5089 New error handlers.
4b80f674
CY
5090 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5091 Obey Vx_select_enable_clipboard_manager. Catch errors in
5092 x_clipboard_manager_save (Bug#8779).
5093 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5094 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5095
99a33b77 50962011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5097
5098 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5099
99a33b77 51002011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5101
5102 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5103 in the current matrix if keep_current_p is non-zero.
5104
8264569d
EZ
51052011-06-04 Eli Zaretskii <eliz@gnu.org>
5106
5107 * bidi.c (bidi_level_of_next_char): Fix last change.
5108
57f97249
EZ
51092011-06-03 Eli Zaretskii <eliz@gnu.org>
5110
fec2107c 5111 Support bidi reordering of text covered by display properties.
57f97249 5112
fec2107c
EZ
5113 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5114 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5115 (bidi_cache_search, bidi_cache_iterator_state)
5116 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5117 (bidi_level_of_next_char, bidi_move_to_visually_next):
5118 Support character positions inside a run of characters covered by a
fec2107c
EZ
5119 display string.
5120 (bidi_paragraph_init, bidi_resolve_explicit_1)
5121 (bidi_level_of_next_char): Call bidi_fetch_char and
5122 bidi_fetch_char_advance instead of FETCH_CHAR and
5123 FETCH_CHAR_ADVANCE.
5124 (bidi_init_it): Initialize new members.
5125 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5126 definitions.
5127 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5128 instead of using explicit *_CHAR codes.
d6d100dd
SM
5129 (bidi_resolve_explicit, bidi_resolve_weak):
5130 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5131 bidirectional text is supported only in multibyte buffers.
5132 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5133 it to initialize the frame_window_p member of struct bidi_it.
5134 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5135 (bidi_resolve_explicit, bidi_resolve_weak)
5136 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5137 bidi_it->nchars is non-positive.
5138 (bidi_level_of_next_char): Don't try to lookup the cache for the
5139 next/previous character if nothing is cached there yet, or if we
5140 were just reseat()'ed to a new position.
c40e2fb2 5141
0e14fe90
EZ
5142 * xdisp.c (set_cursor_from_row): Set start and stop points
5143 according to the row's direction when priming the loop that looks
5144 for the glyph on which to display cursor.
5145 (single_display_spec_intangible_p): Function deleted.
5146 (display_prop_intangible_p): Reimplement to call
5147 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5148 Accept 3 additional arguments needed by handle_display_spec.
5149 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5150 values: lists, `(when COND...)' forms, etc.
5151 (single_display_spec_string_p): Support property values that are
5152 lists with the argument STRING its top-level element.
5153 (display_prop_string_p): Fix the condition for processing a
5154 property that is a list to be consistent with handle_display_spec.
fec2107c 5155 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5156 last portion of handle_display_prop.
5157 (compute_display_string_pos): Accept additional argument
5158 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5159 value of a `display' property is a "replacing spec".
5160 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5161 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5162 the display property, but just return a value indicating whether
5163 the display property will replace the characters it covers.
5164 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5165 frame_window_p members of struct bidi_it.
d6d100dd
SM
5166 (compute_display_string_pos, compute_display_string_end):
5167 New functions.
fec2107c
EZ
5168 (push_it): Accept second argument POSITION, where pop_it should
5169 jump to continue iteration.
5170 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5171
fec2107c
EZ
5172 * keyboard.c (adjust_point_for_property): Adjust the call to
5173 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5174
5175 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5176 (bidi_init_it): Update prototypes.
5177 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5178 (compute_display_string_pos, compute_display_string_end):
5179 Declare prototypes.
fec2107c
EZ
5180 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5181 EMACS_INT.
fc6f18ce 5182
40087514 51832011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5184
57f53182
PE
5185 Malloc failure behavior now depends on size of allocation.
5186 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5187 * lisp.h: Change signatures accordingly.
5188 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5189 All callers changed. (Bug#8762)
5190
5191 * gnutls.c: Use Emacs's memory allocators.
5192 Without this change, the gnutls library would invoke malloc etc.
5193 directly, which causes problems on non-SYNC_INPUT hosts, and which
5194 runs afoul of improving memory_full behavior. (Bug#8761)
5195 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5196 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5197 xfree instead of the default malloc, realloc, free.
5198 (Fgnutls_boot): No need to check for memory allocation failure,
5199 since xmalloc does that for us.
5200
ac32cd99 5201 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5202 * category.c (hash_get_category_set):
5203 * ccl.c (ccl_driver):
5204 * charset.c (Fdefine_charset_internal):
5205 * charset.h (struct charset.hash_index):
5206 * composite.c (get_composition_id, gstring_lookup_cache)
5207 (composition_gstring_put_cache):
5208 * composite.h (struct composition.hash_index):
5209 * dispextern.h (struct image.hash):
5210 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5211 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5212 (hashfn_equal, hashfn_user_defined, make_hash_table)
5213 (maybe_resize_hash_table, hash_lookup, hash_put)
5214 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5215 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5216 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5217 * image.c (make_image, search_image_cache, lookup_image)
5218 (xpm_put_color_table_h):
5219 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5220 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5221 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5222 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5223 * alloc.c (allocate_vectorlike):
5224 Check for overflow in vector size calculations.
5225 * ccl.c (ccl_driver):
5226 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5227 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5228 need to be updated by these changes.
40087514
PE
5229 * fns.c (make_hash_table, maybe_resize_hash_table):
5230 Check for integer overflow with large hash tables.
0de4bb68
PE
5231 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5232 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5233 (SXHASH_REDUCE): New macro.
5234 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5235 Use it instead of discarding useful hash info with large hash values.
5236 (sxhash_float): New function.
5237 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5238 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5239 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5240 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5241 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5242 Adjust signatures to match updated version of code.
5243 (consing_since_gc): Now EMACS_INT, since a single hash table can
5244 use more than INT_MAX bytes.
5245
698d32e2
DN
52462011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5247
5248 Make it possible to build with GCC-4.6+ -O2 -flto.
5249
5250 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5251
fd6fa53f
SM
52522011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5253
5254 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5255 Call minibuffer-inactive-mode.
5256
864db017
JB
52572011-05-31 Juanma Barranquero <lekktu@gmail.com>
5258
5259 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5260 Update dependencies.
5261
2ad0baf4
DN
52622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5263
5264 * data.c (init_data): Remove code for UTS, this system is not
5265 supported anymore.
5266
4fcc2638
DN
52672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5268
5269 Don't force ./temacs to start in terminal mode.
5270
5271 * frame.c (make_initial_frame): Initialize faces in all cases, not
5272 only when CANNOT_DUMP is defined.
5273 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5274
c56e0fd5
DN
52752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5276
5277 * dispnew.c (add_window_display_history): Use const for the string
5278 pointer. Remove declaration, not needed.
5279
333d54da 52802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5281
55d4c1b2 5282 Use 'inline', not 'INLINE'.
333d54da 5283 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5284 * alloc.c, fontset.c (INLINE): Remove.
5285 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5286 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5287 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5288 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5289 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5290
738db178
DN
52912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5292
5293 Make it possible to run ./temacs.
5294
5295 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5296 syms_of_callproc does the same thing. Remove test for
5297 "initialized", do it in the caller.
5298 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5299
620c53a6
SM
53002011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5301
5302 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5303 (read_minibuf): Use get_minibuffer.
5304 (syms_of_minibuf): Use DEFSYM.
5305 (Qmetadata): New var.
5306 * data.c (Qbuffer): Don't make it static.
5307 (syms_of_data): Use DEFSYM.
5308
e003a292
PE
53092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5312 (CCL_CODE_MIN): New macro.
5313
ed008a6d
PE
53142011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5315
3687c2ef
PE
5316 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5317
ed008a6d
PE
5318 * eval.c (Qdebug): Now static.
5319 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5320 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5321 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5322
d66c4c7c
CY
53232011-05-29 Chong Yidong <cyd@stupidchicken.com>
5324
5325 * image.c: Various fixes to ImageMagick code comments.
5326 (Fimagemagick_types): Doc fix.
5327
5fbc2025
PE
53282011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5329
0196f88a
PE
5330 Minor fixes prompted by GCC 4.6.0 warnings.
5331
5332 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5333
5fbc2025
PE
5334 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5335 (x_clipboard_manager_save_all): Move extern decl to ...
5336 * xterm.h: ... here, so that it can be checked for consistency.
5337
1dd3c2d9
CY
53382011-05-29 Chong Yidong <cyd@stupidchicken.com>
5339
5340 * xselect.c (x_clipboard_manager_save_frame)
5341 (x_clipboard_manager_save_all): New functions.
5342 (Fx_clipboard_manager_save): Lisp function deleted.
5343
5344 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5345 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5346
5347 * xterm.h: Update prototype.
5348
5ba6571d
WX
53492011-05-28 William Xu <william.xwl@gmail.com>
5350
5351 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5352 exiting (Bug#8239).
5353
3eaff834
JM
53542011-05-28 Jim Meyering <meyering@redhat.com>
5355
e1900994 5356 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5357 * fns.c (to_uchar): Define.
5358 (crypto_hash_function): Use it to convert some newly-signed
5359 variables to unsigned, to avoid sign-extension bugs. For example,
5360 without this change, (md5 "truc") would evaluate to
5361 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5362 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5363 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5364
0f6990a7
PE
53652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5366
5367 Integer overflow fixes.
c8a9ca5a 5368
08686060
PE
5369 * dbusbind.c: Serial number integer overflow fixes.
5370 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5371 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5372 to hold a serial number that is too large for a fixnum.
5373 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5374 Check for serial numbers out of range. Decode any serial number
59568bf0 5375 that was so large that it became a float. (Bug#8722)
08686060 5376
2d1fc3c7
PE
5377 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5378 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5379 Use XFASTINT rather than XUINT when numbers are nonnegative.
5380 (xd_append_arg, Fdbus_method_return_internal):
5381 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5382 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5383 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5384 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5385 (Bug#8722)
2d1fc3c7 5386
c8a9ca5a
PE
5387 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5388
519e1d69
PE
5389 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5390
30569699
PE
5391 ccl: add integer overflow checks
5392 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5393 (IN_INT_RANGE): New macros.
5394 (ccl_driver): Use them to check for integer overflow when
5395 decoding a CCL program. Many of the new checks are whether XINT (x)
5396 fits in int; it doesn't always, on 64-bit hosts. The new version
5397 doesn't catch all possible integer overflows, but it's an
847044ea 5398 improvement. (Bug#8719)
30569699 5399
c11285dc
PE
5400 * alloc.c (make_event_array): Use XINT, not XUINT.
5401 There's no need for unsigned here.
5402
fdccd48e
PE
5403 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5404 This follows up to the 2011-05-06 change that substituted uintptr_t
5405 for EMACS_INT. This case wasn't caught back then.
5406
37910ab2
PE
5407 Rework Fformat to avoid integer overflow issues.
5408 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5409 now (part of C89). Include <verify.h>.
5410 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5411 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5412 (Fformat): Avoid the prepass trying to compute sizes; it was only
5413 approximate and thus did not catch overflow reliably. Instead, walk
5414 through the format just once, formatting and computing sizes as we go,
5415 checking for integer overflow at every step, and allocating a larger
5416 buffer as needed. Keep track separately whether the format is
5417 multibyte. Keep only the most-recently calculated precision, rather
5418 than them all. Record whether each argument has been converted to
5419 string. Use EMACS_INT, not int, for byte and char and arg counts.
5420 Support field widths and precisions larger than INT_MAX. Avoid
5421 sprintf's undefined behavior with conversion specifications such as %#d
5422 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5423 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5424 formatting out-of-range floating point numbers with int
9173deec 5425 formats. (Bug#8668)
37910ab2 5426
2e6578fb
PE
5427 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5428
0ae6bdee
PE
5429 * data.c: Avoid integer truncation in expressions involving floats.
5430 * data.c: Include <intprops.h>.
5431 (arith_driver): When there's an integer overflow in an expression
5432 involving floating point, convert the integers to floating point
5433 so that the resulting value does not suffer from catastrophic
5434 integer truncation. For example, on a 64-bit host (* 4
5435 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5436 Do not rely on undefined behavior after integer overflow.
5437
de883a70
PE
5438 merge count_size_as_multibyte, parse_str_to_multibyte
5439 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5440 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5441 Check for integer overflow.
5442 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5443 since it's now a duplicate of the other. This is more of
5444 a character than a buffer op, so better that it's in character.c.
5445 * fns.c, print.c: Adjust to above changes.
5446
2ff916cb
PE
54472011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5448
5449 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5450
f1b54466
PE
54512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5452
fb1ac845
PE
5453 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5454 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5455 (x_clipboard_manager_save): Now static.
5456 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5457
f1b54466
PE
5458 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5459 (crypto_hash_function): Now static.
5460 Fix pointer signedness problems. Avoid unnecessary initializations.
5461
a9f737ee
CY
54622011-05-27 Chong Yidong <cyd@stupidchicken.com>
5463
5464 * termhooks.h (Vselection_alist): Make it terminal-local.
5465
5466 * terminal.c (create_terminal): Initialize it.
5467
5468 * xselect.c: Support for clipboard managers.
5469 (Vselection_alist): Move to termhooks.h as terminal-local var.
5470 (LOCAL_SELECTION): New macro.
5471 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5472 (symbol_to_x_atom): Remove gratuitous arg.
5473 (x_handle_selection_request, lisp_data_to_selection_data)
5474 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5475 (x_own_selection, x_get_local_selection, x_convert_selection):
5476 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5477 (some_frame_on_display): Delete unused function.
5478 (Fx_own_selection_internal, Fx_get_selection_internal)
5479 (Fx_disown_selection_internal, Fx_selection_owner_p)
5480 (Fx_selection_exists_p): New optional frame arg.
5481 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5482 (x_handle_selection_clear): Don't treat other terminals with the
5483 same keyboard specially. Use the terminal-local Vselection_alist.
5484 (x_clear_frame_selections): Use Frun_hook_with_args.
5485
5486 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5487
5488 * xterm.h: Add support for those atoms.
5489
e067f0c1
CY
54902011-05-26 Chong Yidong <cyd@stupidchicken.com>
5491
5492 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5493 (converted_selections, conversion_fail_tag): New global variables.
5494 (x_selection_request_lisp_error): Free the above.
5495 (x_get_local_selection): Remove unnecessary code.
5496 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5497 of converted selections stored in converted_selections.
5498 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5499 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5500 (x_convert_selection): New function.
5501 (x_handle_selection_event): Simplify.
5502 (x_get_foreign_selection): Don't ignore incoming requests while
5503 waiting for an answer; this will fail when we implement
5504 SAVE_TARGETS, and seems unnecessary anyway.
5505 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5506 (Vx_sent_selection_functions): Doc fix.
5507
0f4aebc0
LL
55082011-05-26 Leo Liu <sdl.web@gmail.com>
5509
5510 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5511
e61124cd
YM
55122011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5513
5514 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5515
5516 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5517 for fringe update if it has periodic bitmap.
ac389d0c 5518 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5519 and fringe_bitmap_periodic_p.
5520
5521 * fringe.c (get_fringe_bitmap_data): New function.
5522 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5523 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5524 row. Mark glyph row for fringe update if periodicity changed.
5525
5526 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5527 for fringe update unless it has periodic bitmap.
5528
f16d9837
KH
55292011-05-25 Kenichi Handa <handa@m17n.org>
5530
5531 * xdisp.c (get_next_display_element): Set correct it->face_id for
5532 a static composition.
5533
e1b90ef6
LL
55342011-05-24 Leo Liu <sdl.web@gmail.com>
5535
5536 * deps.mk (fns.o):
5537 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5538
5539 * fns.c (crypto_hash_function, Fsha1): New function.
5540 (Fmd5): Use crypto_hash_function.
5541 (syms_of_fns): Add Ssha1.
5542
7400048f
PE
55432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5544
5545 * gnutls.c: Remove unused macros.
5546 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5547 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5548 Remove macros that are defined and never used.
5549 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5550
abb71cf4
CY
55512011-05-22 Chong Yidong <cyd@stupidchicken.com>
5552
5553 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5554 (Fx_get_selection_internal): Minor cleanup.
5555 (Fx_own_selection_internal): Rename arguments for consistency with
5556 select.el.
5557
6307db39
PE
55582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5559
5560 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5561
f3d4e0a4
CY
55622011-05-22 Chong Yidong <cyd@stupidchicken.com>
5563
5564 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5565
4d8ade89
YM
55662011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5567
5568 * dispnew.c (scrolling_window): Don't exclude the case that the
5569 last enabled row in the desired matrix touches the bottom boundary.
5570
32078c8d
GM
55712011-05-21 Glenn Morris <rgm@gnu.org>
5572
5573 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5574 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5575 and add some more files.
32078c8d 5576
7285dc67
EZ
55772011-05-20 Eli Zaretskii <eliz@gnu.org>
5578
5579 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5580 report_file_error introduced by the change from 2011-05-07.
5581
89d1bd22
PE
55822011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5583
5584 * systime.h (Time): Define only if emacs is defined.
5585 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5586 where the include path doesn't have X11/X.h by default. See
5587 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5588
e23640bb 55892011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5590
5591 * composite.c (find_automatic_composition): Fix previous change.
5592
b9704ad9
GM
55932011-05-20 Glenn Morris <rgm@gnu.org>
5594
5595 * lisp.mk: New file, split from Makefile.in.
5596 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5597 (shortlisp): Remove.
5598 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5599
4a720484
GM
56002011-05-19 Glenn Morris <rgm@gnu.org>
5601
5602 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5603 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5604 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5605 (lisp): Set the order to that of loadup.el.
5606 (shortlisp): Make it a copy of $lisp.
5607 (SOME_MACHINE_LISP): Remove.
5608 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5609 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5610
a28d4396
KH
56112011-05-18 Kenichi Handa <handa@m17n.org>
5612
5613 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5614 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5615 (find_automatic_composition): Mostly rewrite for efficiency.
5616
a2b1fa8e
JB
56172011-05-18 Juanma Barranquero <lekktu@gmail.com>
5618
5619 * makefile.w32-in: Update dependencies.
5620
8e1f5610
CS
56212011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5622
5623 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5624 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5625
7025ee00 56262011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5627
cdfa6eab
PE
5628 Fix some integer overflow issues, such as string length overflow.
5629
06d6db33
PE
5630 * insdel.c (count_size_as_multibyte): Check for string overflow.
5631
2b4560a8
PE
5632 * character.c (lisp_string_width): Check for string overflow.
5633 Use EMACS_INT, not int, for string indexes and lengths; in
5634 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5635 the resulting string length overflows an EMACS_INT; instead,
5636 report a string overflow if no precision given. When checking for
5637 precision exhaustion, use a check that cannot possibly have
5638 integer overflow. (Bug#8675)
5639 * character.h (lisp_string_width): Adjust to new signature.
5640
cb93f9be
PE
5641 * alloc.c (string_overflow): New function.
5642 (Fmake_string): Use it. This doesn't change behavior, but saves
5643 a few bytes and will simplify future changes.
5644 * character.c (string_escape_byte8): Likewise.
5645 * lisp.h (string_overflow): New decl.
5646
1a1f3366
PE
5647 Fixups, following up to the user-interface timestamp change.
5648 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5649 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5650 * msdos.c (mouse_get_pos): Likewise.
5651 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5652 * w32gui.h (Time): Define by including "systime.h" rather than by
5653 declaring it ourselves. (Bug#8664)
5654
d4e3e4d3
PE
5655 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5656 * image.c (clear_image_cache): Likewise.
5657
f6a24d19
PE
5658 * term.c (term_mouse_position): Don't assume time_t wraparound.
5659
08dc5ae6
PE
5660 Be more systematic about user-interface timestamps.
5661 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5662 and sometimes 'EMACS_UINT', to represent these timestamps.
5663 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5664 This makes the code easier to follow, and makes it easier to catch
5665 integer overflow bugs such as Bug#8664.
5666 * frame.c (Fmouse_position, Fmouse_pixel_position):
5667 Use Time, not unsigned long, for user-interface timestamps.
5668 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5669 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5670 * keyboard.h (last_event_timestamp): Likewise.
5671 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5672 * menu.h (xmenu_show): Likewise.
5673 * term.c (term_mouse_position): Likewise.
5674 * termhooks.h (struct input_event.timestamp): Likewise.
5675 (struct terminal.mouse_position_hook): Likewise.
5676 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5677 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5678 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5679 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5680 what it was before.
5681 * menu.h, termhooks.h: Include "systime.h", for Time.
5682
8e55734a
PE
5683 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5684 Don't assume that the difference between two unsigned long values
5685 can fit into an integer. At this point, we know button_down_time
5686 <= event->timestamp, so the difference must be nonnegative, so
5687 there's no need to cast the result if double-click-time is
5688 nonnegative, as it should be; check that it's nonnegative, just in
5689 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5690 apart (about 25 days). (Bug#8664)
8e55734a 5691
841f1b75 5692 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5693 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5694
3e26f69c
PE
5695 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5696 that always fit in int. Use a sentinel instead of a counter, to
5697 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5698 * frame.h (struct frame): Use int for menu_bar_items_used
5699 instead of EMACS_INT, since it always fits in int.
3e26f69c 5700
5cc152c0
PE
5701 * menu.c (grow_menu_items): Check for int overflow.
5702
d89eb65e
PE
5703 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5704
5235bd3e
PE
5705 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5706 Before, the code was not consistent. These values cannot exceed
5707 2**31 - 1 so there's no need to make them unsigned.
5708 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5709 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5710 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5711 as modifiers.
5712 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5713
bc827e23
PE
5714 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5715 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5716 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5717 presumably because the widths might not match.
5718
78eb494e
PE
5719 * window.c (size_window): Avoid needless test at loop start.
5720
04f2d78b
CB
57212011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5722
5723 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5724
d2fc7e3d 57252011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5726
5727 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5728
d2fc7e3d 57292011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5730
5731 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5732 `width' to `bar_area_x' and `bar_area_width', respectively.
5733 (x_scroll_run): Take account of fringe background extension.
5734
04f2d78b
CB
5735 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5736 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5737 `bar_area_width', respectively.
5738 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5739 background extension.
5740
79b70037
GM
57412011-05-10 Jim Meyering <meyering@redhat.com>
5742
5743 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5744
2f142cc5
JB
57452011-05-10 Juanma Barranquero <lekktu@gmail.com>
5746
5747 * image.c (Finit_image_library): Return t for built-in image types,
5748 like pbm and xbm. (Bug#8640)
5749
57679c86
AS
57502011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5751
5752 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5753
888c9e86
EZ
57542011-05-07 Eli Zaretskii <eliz@gnu.org>
5755
b0512a1d
EZ
5756 * w32console.c (Fset_screen_color): Doc fix.
5757 (Fget_screen_color): New function.
5758 (syms_of_ntterm): Defsubr it.
5759
7285dc67
EZ
5760 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5761 unlink the temporary file if Fcall_process didn't create it in the
5762 first place.
5763 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5764 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5765 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5766 cue to call_process_cleanup not to close that handle.
5767
4d3fcc8e
BK
57682011-05-07 Ben Key <bkey76@gmail.com>
5769
5770 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5771 one of two shell specific rules, either bootstrap-temacs-CMD or
5772 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5773 to the previous implementation of the bootstrap-temacs rule.
5774 The bootstrap-temacs-CMD rule is similar to the previous
5775 implementation of the bootstrap-temacs rule except that it
5776 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5777 variable.
5778
5779 These changes, along with some changes to nt/configure.bat,
5780 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5781 earlier fix to add support for --cflags and --ldflags options
5782 that include quotes so that it works whether make uses cmd or
5783 sh as the shell.
5784
b4289b64
MA
57852011-05-06 Michael Albinus <michael.albinus@gmx.de>
5786
5787 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5788 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5789 is a constant.
5790 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5791 a string. Handle both cases.
5792 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5793 (Fdbus_register_method): Use Qinvalid_function.
5794
af4c0e28
JB
57952011-05-06 Juanma Barranquero <lekktu@gmail.com>
5796
5797 * makefile.w32-in: Update dependencies.
5798 (LISP_H): Add inttypes.h and stdin.h.
5799 (PROCESS_H): Add unistd.h.
5800
c51453d9
EZ
58012011-05-06 Eli Zaretskii <eliz@gnu.org>
5802
5803 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5804 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5805
8ff0ac3c 58062011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5807
4c4b566b
PE
5808 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5809
aab2b9b5
PE
5810 * term.c (vfatal): Remove stray call to va_end.
5811 It's not needed and the C Standard doesn't allow it here anyway.
5812
c378da0b
PE
5813 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5814 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5815
288b08c7
PE
5816 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5817 bytes.
5818
e3601888
PE
5819 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5820
db6c0e74
PE
5821 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5822
dd5963ea
PE
5823 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5824
88c9450f
PE
5825 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5826
2f9442b8
PE
5827 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5828
c032b5f8
PE
5829 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5830 * charset.c (Fdefine_charset_internal): Don't initialize
5831 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5832 32-bit int (Bug#8600).
a108c10b
PE
5833
5834 * lread.c (read_integer): Be more consistent with string-to-number.
5835 Use string_to_number to do the actual conversion; this avoids
5836 rounding errors and fixes some other screwups. Without this fix,
5837 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5838 (digit_to_number): Move earlier, for benefit of read_integer.
5839 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5840 not a digit in any supported base. (Bug#8602)
a108c10b 5841
ad5f9eea
PE
5842 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5843
aec1708a
PE
5844 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5845 to match comment at start of function. This also removes a
5846 GCC warning about overflow in a 32+64-bit port.
5847
47be4ab5
PE
5848 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5849
371cac43
PE
5850 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5851 Reported by Stefan Monnier in
5852 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5853 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5854 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5855
d01a7826
PE
5856 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5857 (EMACS_UINTPTR): Likewise, with uintptr_t.
5858
7fd47d5c
PE
5859 * lisp.h: Prefer 64-bit EMACS_INT if available.
5860 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5861 on 32-bit hosts that have 64-bit int, so that they can access
5862 large files.
122b0c86
PE
5863 However, temporarily disable this change unless the temporary
5864 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5865
8727937b
PE
5866 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5867
8ac068ac
PE
5868 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5869 This removes an assumption that EMACS_INT and long are the same
5870 width as pointers. The assumption is true for Emacs porting targets
5871 now, but we want to make other targets possible.
5872 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5873 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5874 In the rest of the code, change types of integers that hold casted
5875 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5876 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5877 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5878 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5879 No need to cast type when ORing.
5880 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5881 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5882 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5883 assume EMACS_INT is the same width as char *.
5884 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5885 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5886 Remove no-longer-needed casts.
5887 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5888 (xg_tool_bar_help_callback, xg_make_tool_item):
5889 Use EMACS_INTPTR to hold an integer
5890 that will be cast to void *; this can avoid a GCC warning
5891 if EMACS_INT is not the same width as void *.
5892 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5893 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5894 (current_message_1, set_message_1):
5895 Use a local to convert to proper width without a cast.
5896 * xmenu.c (dialog_selection_callback): Likewise.
5897
ede49d71
PE
5898 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5899 Also, don't assume VALBITS / RAND_BITS is less than 5,
5900 and don't rely on undefined behavior when shifting a 1 left into
5901 the sign bit.
5902 * lisp.h (get_random): Change signature to match.
5903
2f30ecd0
PE
5904 * lread.c (hash_string): Use size_t, not int, for hash computation.
5905 Normally we prefer signed values; but hashing is special, because
5906 it's better to use unsigned division on hash table sizes so that
5907 the remainder is nonnegative. Also, size_t is the natural width
5908 for hashing into memory. The previous code used 'int', which doesn't
5909 retain enough info to hash well into very large tables.
5910 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5911
2a866e7b
PE
5912 * dbusbind.c: Don't possibly lose pointer info when converting.
5913 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5914 Use XPNTR rather than XHASH, so that the high-order bits of
5915 the pointer aren't lost when converting through void *.
5916
51639eac
PE
5917 * eval.c (Fautoload): Don't double-shift a pointer.
5918
92394119
PE
5919 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5920
dbdb9a7c
JB
59212011-05-06 Juanma Barranquero <lekktu@gmail.com>
5922
5923 * gnutls.c (DEF_GNUTLS_FN):
5924 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5925
db7a0b4f
AS
59262011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5927
5928 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5929 marker. (Bug#8610)
5930
f7ff1b0f 59312011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5932
5933 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5934 New version that can reserve upto 2GB of heap space.
5935
f7ff1b0f 59362011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5937
5938 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5939
639c109b
TZ
59402011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5941
5942 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5943 `gnutls_certificate_set_x509_key_file'.
5944
d2127135
JB
59452011-05-05 Juanma Barranquero <lekktu@gmail.com>
5946
5947 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5948 Update dependencies.
5949
e968f4f3
JB
59502011-05-04 Juanma Barranquero <lekktu@gmail.com>
5951
5952 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5953 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5954 Remove unused parameter `fildes'.
5955 * process.c (read_process_output, send_process): Don't pass it.
5956
84d358f0
JB
59572011-05-04 Juanma Barranquero <lekktu@gmail.com>
5958
5959 Fix previous change: the library cache is defined in w32.c.
5960 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5961 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5962
0898ca10
JB
59632011-05-04 Juanma Barranquero <lekktu@gmail.com>
5964
5965 Implement dynamic loading of GnuTLS on Windows.
5966
5967 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5968 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5969 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5970 Declare.
5971
5972 * gnutls.c (Qgnutls_dll): Define.
5973 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5974 (gnutls_*): Declare function pointers.
5975 (init_gnutls_functions): New function to initialize function pointers.
5976 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5977 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5978 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5979 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5980 (emacs_gnutls_write, emacs_gnutls_read)
5981 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5982 (Fgnutls_available_p): New function.
5983 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5984 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5985 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5986
5987 * image.c: Include w32.h.
5988 (Vimage_type_cache): Delete.
5989 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5990 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5991 (w32_delayed_load): Move to w32.c.
5992
5993 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5994
5995 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5996 (w32_delayed_load): Move from image.c. When loading a library, record
5997 its filename in the :loaded-from property of the library id.
5998 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5999 Initialize and staticpro them.
6000 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6001
6002 * process.c: Include lisp.h before w32.h, not after.
6003 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6004 instead of gnutls_record_check_pending.
6005
6006 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6007
ff4de4aa
TZ
60082011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6009
6010 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6011 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6012 as passed in.
6013
abe95abb
JD
60142011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6015
6016 * xterm.c (x_set_frame_alpha): Do not set property on anything
6017 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6018
e16e55d4
JB
60192011-05-02 Juanma Barranquero <lekktu@gmail.com>
6020
6021 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6022
bafcf6a5
JB
60232011-05-02 Juanma Barranquero <lekktu@gmail.com>
6024
6025 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6026 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6027 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6028 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6029 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6030 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6031 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6032 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6033 (Qgnutls_bootprop_callbacks_verify): Make static.
6034
e7a6747f
AS
60352011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6036
19ed11ba
AS
6037 * callproc.c: Indentation fixup.
6038
e7a6747f 6039 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6040 (wait_for_termination, interruptible_wait_for_termination):
6041 Move after wait_for_termination_1.
e7a6747f 6042
1ef14cb4
LMI
60432011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6044
6045 * sysdep.c (interruptible_wait_for_termination): New function
6046 which is like wait_for_termination, but allows keyboard
6047 interruptions.
6048
6049 * callproc.c (Fcall_process): Add (:file "file") as an option for
6050 the STDOUT buffer.
6051 (Fcall_process_region): Ditto.
6052
330d880c
EZ
60532011-04-30 Eli Zaretskii <eliz@gnu.org>
6054
8db90b73
EZ
6055 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6056 rather than `XVECTOR (FOO)->size'.
6057
330d880c
EZ
6058 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6059 inttypes.h, as a gnulib replacement is used if it not available in
6060 system headers.
6061
15cbd324
EZ
60622011-04-21 Eli Zaretskii <eliz@gnu.org>
6063
6064 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6065 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6066 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6067
6068 * coding.c (coding_alloc_by_realloc): Error out if destination
6069 will grow beyond MOST_POSITIVE_FIXNUM.
6070 (decode_coding_emacs_mule): Abort if there isn't enough place in
6071 charbuf for the composition carryover bytes. Reserve an extra
6072 space for up to 2 characters produced in a loop.
6073 (decode_coding_iso_2022): Abort if there isn't enough place in
6074 charbuf for the composition carryover bytes.
6075
60762011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6077
ae940cca
EZ
6078 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6079 aborting when %lld or %lll format is passed.
6080 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6081 %llo or %llx format is passed. (Bug#8545)
6082
03ab8921
EZ
6083 * window.c (window_scroll_line_based): Use a marker instead of
6084 simple variables to record original value of point. (Bug#7952)
6085
afda1437
EZ
6086 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6087 produced by %s or %c overflows available buffer space. (Bug#8545)
6088
f76dee0c
PE
60892011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6090
6091 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6092 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6093
fdc5744d
JB
60942011-04-28 Juanma Barranquero <lekktu@gmail.com>
6095
6096 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6097
638f053a
JB
60982011-04-28 Juanma Barranquero <lekktu@gmail.com>
6099
6100 * keyboard.c (Qdelayed_warnings_hook): Define.
6101 (command_loop_1): Run `delayed-warnings-hook'
6102 if Vdelayed_warnings_list is non-nil.
6103 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6104 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6105
d178f871
EZ
61062011-04-28 Eli Zaretskii <eliz@gnu.org>
6107
6108 * doprnt.c (doprnt): Don't return value smaller than the buffer
6109 size if the message was truncated. (Bug#8545).
6110
b124fd93
JB
61112011-04-28 Juanma Barranquero <lekktu@gmail.com>
6112
6113 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6114 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6115
e810457d
PE
61162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6117
6118 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6119
ea51cceb
JB
61202011-04-27 Juanma Barranquero <lekktu@gmail.com>
6121
6122 * makefile.w32-in: Update dependencies.
6123
94dcfacf
EZ
61242011-04-27 Eli Zaretskii <eliz@gnu.org>
6125
6126 Improve `doprnt' and its usage. (Bug#8545)
6127 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6128 `format_end'. Remove support for %l as a conversion specifier.
6129 Don't use xrealloc. Improve diagnostics when the %l size modifier
6130 is used. Update the commentary.
6131
6132 * eval.c (verror): Simplify calculation of size_t.
6133
6134 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6135 messages.
6136
f61f41d7
PE
61372011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6138
6139 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6140 change.
6141
96fb4434
PE
61422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6143
6144 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6145 This makes this file independent of the recent pseudovector change.
6146
671875da 61472011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6148
69e9b5a3
PE
6149 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6150
b5f869a7 6151 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6152 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6153 Remove unused local.
c8926152 6154 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6155
841a1577 6156 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6157 GCC 4.6.0 optimizes based on type-based alias analysis.
6158 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6159 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6160 != &v->size, and therefore "v->size = 1; b->size = 2; return
6161 v->size;" must therefore return 1. This assumption is incorrect
6162 for Emacs, since it type-puns struct Lisp_Vector * with many other
6163 types. To fix this problem, this patch adds a new type struct
f904488f 6164 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6165 and pseudovectors, and helps optimizing compilers not get fooled
6166 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6167 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6168 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6169 the size member.
eab3844f
PE
6170 (XSETPVECTYPE): Rewrite in terms of new macro.
6171 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6172 This is a bit clearer, and further avoids the possibility of
6173 undesirable aliasing.
6174 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6175 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6176 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6177 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6178 (ASIZE): Now uses header.size rather than size.
6179 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6180 to avoid the hassle of writing XVECTOR (foo)->header.size.
6181 (struct vectorlike_header): New type.
eab3844f
PE
6182 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6183 object, to help avoid aliasing.
6184 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6185 (SUBRP): Likewise, since Lisp_Subr is a special case.
6186 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6187 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6188 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6189 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6190 changed to be "header.size" and "header.next".
6191 * buffer.h (struct buffer): Likewise.
6192 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6193 * frame.h (struct frame): Likewise.
6194 * process.h (struct Lisp_Process): Likewise.
6195 * termhooks.h (struct terminal): Likewise.
6196 * window.c (struct save_window_data, struct saved_window): Likewise.
6197 * window.h (struct window): Likewise.
6198 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6199 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6200 * buffer.c (init_buffer_once): Likewise.
6201 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6202 special case.
6203 * process.c (Fformat_network_address): Use local var for size,
6204 for brevity.
6205
0df1eac5
PE
6206 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6207
847ab9d1 6208 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6209 * data.c (atof): Remove decl; no longer used or needed.
6210 (digit_to_number): Move to lread.c.
6211 (Fstring_to_number): Use new string_to_number function, to be
6212 consistent with how the Lisp reader treats infinities and NaNs.
6213 Do not assume that floating-point numbers represent EMACS_INT
6214 without losing information; this is not true on most 64-bit hosts.
6215 Avoid double-rounding errors, by insisting on integers when
6216 parsing non-base-10 numbers, as the documentation specifies.
6217 * lisp.h (string_to_number): New decl, replacing ...
6218 (isfloat_string): Remove.
bc0a5c13 6219 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6220 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6221 appears to have been a coding error. Similarly, do not accept
6222 strings like +-1e0 as floating point numbers. Do not report
6223 overflow for integer overflows unless the base is not 10 which
6224 means we have no simple and reliable way to continue.
6225 Break out the floating-point parsing into a new
6226 function string_to_number, so that Fstring_to_number parses
6227 floating point numbers consistently with the Lisp reader.
04f2d78b 6228 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6229 (E_CHAR, EXP_INT): Remove, replacing with ...
6230 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6231 (string_to_number): New function, replacing isfloat_string.
6232 This function checks for valid syntax and produces the resulting
6233 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6234 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6235 so that overflow for non-base-10 numbers is reported only when
6236 there's no portable and simple way to convert to floating point.
452f4150 6237
67769ffc
PE
6238 * textprop.c (set_text_properties_1): Rewrite for clarity,
6239 and to avoid GCC warning about integer overflow.
6240
c20db43f
PE
6241 * intervals.h (struct interval): Use EMACS_INT for members
6242 where EMACS_UINT might cause problems. See
6243 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6244 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6245 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6246 All uses changed.
37aa2f85
PE
6247 (offset_intervals): Tell GCC not to worry about length overflow
6248 when negating a negative length.
c20db43f 6249
2538aa2f
PE
6250 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6251 (overrun_check_free): Likewise.
6252
f2d3008d
PE
6253 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6254 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6255 word size.
6256
ec8df744
PE
6257 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6258 (gnutls_make_error): Rename local to avoid shadowing.
6259 (gnutls_emacs_global_deinit): ifdef out; not used.
6260 (Fgnutls_boot): Use const for pointer to readonly storage.
6261 Comment out unused local. Fix pointer signedness problems.
6262
640ee02d
PE
6263 * lread.c (openp): Don't stuff size_t into an 'int'.
6264 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6265 about possible signed overflow.
6266
6048fb2a
PE
6267 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6268 (GDK_KEY_g): Don't define if already defined.
6269 (xg_prepare_tooltip): Avoid pointer signedness problem.
6270 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6271
fa3c87e1
PE
6272 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6273 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6274
2172544b
PE
6275 * xfns.c (Fx_window_property): Simplify a bit,
6276 to make a bit faster and to avoid GCC 4.6.0 warning.
6277 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6278
9b821a21
PE
6279 * fns.c (internal_equal): Don't assume size_t fits in int.
6280
3c616cfa
PE
6281 * alloc.c (compact_small_strings): Tighten assertion a little.
6282
c2982e87
PE
6283 Replace pEd with more-general pI, and fix some printf arg casts.
6284 * lisp.h (pI): New macro, generalizing old pEd macro to other
6285 conversion specifiers. For example, use "...%"pI"d..." rather
6286 than "...%"pEd"...".
6287 (pEd): Remove. All uses replaced with similar uses of pI.
6288 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6289 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6290 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6291 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6292 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6293 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6294 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6295 64-bit hosts.
6296 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6297 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6298 * print.c (safe_debug_print, print_object): Likewise.
6299 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6300 to int.
6f04d126
PE
6301 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6302 avoiding the 0 flag, which is not portable.
c2982e87
PE
6303 * process.c (Fmake_network_process): Use pI to avoid cast.
6304 * region-cache.c (pp_cache): Likewise.
6305 * xdisp.c (decode_mode_spec): Likewise.
6306 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6307 behavior on 64-bit hosts with printf arg.
6f04d126 6308 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6309 (x_stop_queuing_selection_requests): Likewise.
6310 (x_get_window_property): Don't truncate byte count to an 'int'
6311 when tracing.
0b432f21 6312
5e073ec7
PE
6313 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6314 here, since it parses constructs like leading '-' and spaces,
6315 which are not wanted; and it overflows with large numbers.
6316 Instead, simply match F[0-9]+, which is what is wanted anyway.
6317
36372bf9
PE
6318 * alloc.c: Remove unportable assumptions about struct layout.
6319 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6320 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6321 (allocate_vectorlike, make_pure_vector): Use the new macros,
6322 plus offsetof, to remove unportable assumptions about struct layout.
6323 These assumptions hold on all porting targets that I know of, but
6324 they are not guaranteed, they're easy to remove, and removing them
6325 makes further changes easier.
6326
0b432f21
PE
6327 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6328 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6329 (string_overrun_cookie): Now const. Use initializers that
6330 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6331 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6332 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6333 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6334 multiple of sizeof (EMACS_INT); it need not be, if
6335 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6336 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6337
895009e1
JB
63382011-04-26 Juanma Barranquero <lekktu@gmail.com>
6339
6340 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6341
6a7a1b0b
TZ
63422011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6343
6344 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6345 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6346 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6347
841a1577 63482011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6349
6350 * lisp.h (Qdebug): List symbol.
895009e1 6351 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6352 * keyboard.c (debug-on-event): New variable.
6353 (handle_user_signal): Break into debugger when debug-on-event
6354 matches the current signal symbol.
6355
f2d3ba6f
DN
63562011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6357
6358 * alloc.c (check_sblock, check_string_bytes)
6359 (check_string_free_list): Convert to standard C.
6360
42ce4c63
TZ
63612011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6362
6363 * w32.c (emacs_gnutls_push): Fix typo.
6364
825cd63c
EZ
63652011-04-25 Eli Zaretskii <eliz@gnu.org>
6366
fb11d64d
EZ
6367 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6368 "cast to pointer from integer of different size".
6369
825cd63c
EZ
6370 Improve doprnt and its use in verror. (Bug#8545)
6371 * doprnt.c (doprnt): Document the set of format control sequences
6372 supported by the function. Use SAFE_ALLOCA instead of always
6373 using `alloca'.
6374
6375 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6376 is one byte too soon. Don't use xrealloc; instead xfree and
6377 xmalloc anew.
6378
e061a11b
TZ
63792011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6380
6381 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6382 callbacks stage.
6383
6384 * gnutls.c: Renamed global_initialized to
6385 gnutls_global_initialized. Added internals for the
6386 :verify-hostname-error, :verify-error, and :verify-flags
6387 parameters of `gnutls-boot' and documented those parameters in the
6388 docstring. Start callback support.
9173deec
JB
6389 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6390 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6391 on error. Return error code.
e061a11b
TZ
6392 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6393 (emacs_gnutls_read): Likewise.
6394 (Fgnutls_boot): Return handshake error code.
6395 (emacs_gnutls_handle_error): New function.
6396 (wsaerror_to_errno): Likewise.
6397
6398 * w32.h (emacs_gnutls_pull): Add prototype.
6399 (emacs_gnutls_push): Likewise.
6400
6401 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6402 (emacs_gnutls_push): Likewise.
6403
64042011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6405
6406 * process.c (wait_reading_process_output): Check if GnuTLS
6407 buffered some data internally if no FDs are set for TLS
6408 connections.
6409
6410 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6411 (LIBS): Link to USER_LIBS.
6412 ($(BLD)/gnutls.$(0)): New target.
6413
fa6996bc
EZ
64142011-04-24 Eli Zaretskii <eliz@gnu.org>
6415
eb35682e
EZ
6416 * xdisp.c (handle_single_display_spec): Rename the
6417 display_replaced_before_p argument into display_replaced_p, to
6418 make it consistent with the commentary. Fix typos in the
6419 commentary.
6420
e2ad650c
EZ
6421 * textprop.c (syms_of_textprop): Remove dead code.
6422 (copy_text_properties): Delete obsolete commentary about an
6423 interface that was deleted long ago. Fix typos in the description
6424 of arguments.
6425
1b2de274
EZ
6426 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6427 to changes in oldXMenu/XMenu.h from 2011-04-16.
6428 <menu_help_message, prev_menu_help_message>: Constify.
6429 (IT_menu_make_room): menu->help_text is now `const char **';
6430 adjust.
6431
6432 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6433 to changes in oldXMenu/XMenu.h from 2011-04-16.
6434 (struct XMenu): Declare `help_text' `const char **'.
6435
6436 * xfaces.c <Qunspecified>: Make extern again.
6437
6438 * syntax.c: Include sys/types.h before including regex.h, as
6439 required by Posix.
6440
762b15be
EZ
6441 * doc.c (get_doc_string): Improve the format passed to `error'.
6442
6443 * doprnt.c (doprnt): Improve commentary.
6444
6445 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6446
6447 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6448 them with etags.
6449
f1052e5d
EZ
6450 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6451 changes in globals.h immediately force recompilation.
762b15be
EZ
6452 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6453 $(CURDIR)/s/ms-w32.h.
6454 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6455
fa6996bc
EZ
6456 * character.c (Fchar_direction): Function deleted.
6457 (syms_of_character): Don't defsubr it.
6458 <char-direction-table>: Deleted.
6459
e6c3da20
EZ
64602011-04-23 Eli Zaretskii <eliz@gnu.org>
6461
6462 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6463 * doprnt.c: Include limits.h.
6464 (SIZE_MAX): New macro.
04f2d78b
CB
6465 (doprnt): Return a size_t value. 2nd arg is now size_t.
6466 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6467 Improve overflow protection. Support `l' modifier for integer
6468 conversions. Support %l conversion. Don't assume an EMACS_INT
6469 argument for integer conversions and for %c.
6470
6471 * lisp.h (doprnt): Restore prototype.
6472
6473 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6474 $(SRC)/character.h.
6475
6476 * Makefile.in (base_obj): Add back doprnt.o.
6477
6478 * deps.mk (doprnt.o): Add back prerequisites.
6479 (callint.o): Depend on character.h.
6480
6481 * eval.c (internal_lisp_condition_case): Include the handler
6482 representation in the error message.
6483 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6484 when breaking from the loop.
6485
6486 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6487
6488 * callint.c (Fcall_interactively): When displaying error message
6489 about invalid control letter, pass the character's codepoint, not
6490 a pointer to its multibyte form. Improve display of the character
6491 in octal and display also its hex code.
6492
6493 * character.c (char_string): Use %x to display the (unsigned)
6494 codepoint of an invalid character, to avoid displaying a bogus
6495 negative value.
6496
6497 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6498 `error', not SYMBOL_NAME itself.
6499
6500 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6501 character arguments to `error'.
6502
6503 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6504 to `error' in error message about FINAL_CHAR argument. Make sure
6505 FINAL_CHAR is a character, and use %c when it is passed as
6506 argument to `error'.
6507
4ffd0d6b 65082011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6509
6510 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6511
6512 * w32.c: Include <time.h>.
6513 (sys_localtime): New function.
6514
4ffd0d6b 65152011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6516
6517 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6518
4ffd0d6b 6519 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6520
4ffd0d6b 65212011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6522
4ffd0d6b
GM
6523 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6524 zombies (Bug#8467).
aac0c6e3 6525
04c56954
EZ
65262011-04-19 Eli Zaretskii <eliz@gnu.org>
6527
6528 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6529 gl_state.e_property when gl_state.object is Qt.
6530
6531 * insdel.c (make_gap_larger): Remove limitation of buffer size
6532 to <= INT_MAX.
6533
16a43933
CY
65342011-04-18 Chong Yidong <cyd@stupidchicken.com>
6535
6536 * xdisp.c (lookup_glyphless_char_display)
6537 (produce_glyphless_glyph): Handle cons cell entry in
6538 glyphless-char-display.
6539 (Vglyphless_char_display): Document it.
6540
6541 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6542 glyphless-char-display.
6543
4581706e
CY
65442011-04-17 Chong Yidong <cyd@stupidchicken.com>
6545
6546 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6547
6548 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6549
6550 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6551 definition for no-X builds.
6552
4887c6e2 65532011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6554
fd35b6f9
PE
6555 Static checks with GCC 4.6.0 and non-default toolkits.
6556
5c1ccb01
PE
6557 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6558
006c5daa
PE
6559 * process.c (keyboard_bit_set): Define only if SIGIO.
6560 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6561 (send_process): Repair possible setjmp clobbering.
6562
efc736d3
PE
6563 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6564
4e2fe2e6
PE
6565 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6566
f97334a2
PE
6567 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6568
4e75f29d
PE
6569 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6570 Define only if needed.
6571
90efadd1
PE
6572 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6573 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6574 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6575
3c647824
PE
6576 * dispextern.h (struct redisplay_interface): Rename param
6577 to avoid shadowing.
e264f262 6578 * termhooks.h (struct terminal): Likewise.
761383f4 6579 * xterm.c (xembed_send_message): Likewise.
3c647824 6580
b58c5c4a
PE
6581 * insdel.c (make_gap_smaller): Define only if
6582 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6583
cad59032
PE
6584 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6585 it.
6586
c339dc2e
PE
6587 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6588 so that we aren't warned about unused symbols.
6589
91a3e27b
PE
6590 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6591
399c71d3 6592 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6593
8ffc96f5
PE
6594 * xfns.c (x_real_positions): Mark locals as initialized.
6595
eef9bc79
PE
6596 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6597
098db9dd
PE
6598 * xterm.c: Fix problems found by static analysis with other toolkits.
6599 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6600 (x_dispatch_event): Declare static if USE_GTK, and
6601 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6602 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6603 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6604 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6605 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6606
eb18f6cc
PE
6607 * xmenu.c (menu_help_callback): Pointer type fixes.
6608 Use const pointers when pointing at readonly data. Avoid pointer
6609 signedness clashes.
6610 (FALSE): Remove unused macro.
6611 (update_frame_menubar): Remove unused decl.
6612
1fe72bf8
PE
6613 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6614
60d9e1db
PE
6615 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6616 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6617 (single_menu_item): Rename local to avoid shadowing.
6618
39261c26
PE
6619 * keyboard.c (make_lispy_event): Remove unused local var.
6620
018c5e19
PE
6621 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6622 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6623
63d2b86e
PE
6624 * bitmaps: Change bitmaps from unsigned char back to the X11
6625 compatible char. Avoid the old compiler warnings about
6626 out-of-range initializers by using, for example, '\xab' rather
6627 than 0xab.
6628
aefd87e1
PE
6629 * xgselect.c (xgselect_initialize): Check vs interface
6630 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6631
bf501fb9
PE
6632 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6633
e9829fdf
PE
6634 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6635 to read-only memory.
6636
1086c095
PE
6637 * fns.c (vector): Remove; this old hack is no longer needed.
6638
2baccd04 6639 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6640 Remove unused var.
dde42981 6641 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6642
72391843 6643 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6644
436c16df 6645 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6646 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6647 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6648
92bb796d 6649 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6650 (x_term_init): Remove local to avoid shadowing.
92bb796d 6651
764430a3 6652 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6653
6654 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6655 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6656
d1dfb56c
EZ
66572011-04-16 Eli Zaretskii <eliz@gnu.org>
6658
c4354cb4
EZ
6659 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6660
d1dfb56c
EZ
6661 Fix regex.c, syntax.c and friends for buffers > 2GB.
6662 * syntax.h (struct gl_state_s): Declare character position members
6663 EMACS_INT.
6664
6665 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6666
04f2d78b
CB
6667 * textprop.c (verify_interval_modification, interval_of):
6668 Declare arguments EMACS_INT.
d1dfb56c
EZ
6669
6670 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6671 EMACS_INT.
6672
6673 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6674
6675 * indent.c (Fvertical_motion): Local variable it_start is now
6676 EMACS_INT.
6677
6678 * regex.c (re_match, re_match_2, re_match_2_internal)
6679 (bcmp_translate, regcomp, regexec, print_double_string)
6680 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6681 (re_compile_pattern, re_exec): Declare arguments and local
6682 variables `size_t' and `ssize_t' and return values `regoff_t', as
6683 appropriate.
6684 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6685 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6686 <compile_stack_type>: `size' and `avail' are now `size_t'.
6687
6688 * regex.h <regoff_t>: Use ssize_t, not int.
6689 (re_search, re_search_2, re_match, re_match_2): Arguments that
6690 specify buffer/string position and length are now ssize_t and
6691 size_t. Return type is regoff_t.
6692
613052cd
BK
66932011-04-16 Ben Key <bkey76@gmail.com>
6694
6695 * nsfont.m: Fixed bugs in ns_get_family and
6696 ns_descriptor_to_entity that were caused by using free to
6697 deallocate memory blocks that were allocated by xmalloc (via
6698 xstrdup). This caused Emacs to crash when compiled with
6699 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6700 --enable-checking=xmallocoverrun). xfree is now used to
6701 deallocate these memory blocks.
6702
4170f62f 67032011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6704
71b41406
PE
6705 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6706
9587a89d
PE
6707 emacs_write: Accept and return EMACS_INT for sizes.
6708 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6709 et seq.
6710 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6711 Accept and return EMACS_INT.
6712 (emacs_gnutls_write): Return the number of bytes written on
6713 partial writes.
6714 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6715 (emacs_read, emacs_write): Remove check for negative size, as the
6716 Emacs source code has been audited now.
9587a89d
PE
6717 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6718 (emacs_read, emacs_write): Use it.
273a5f82
PE
6719 * process.c (send_process): Adjust to the new signatures of
6720 emacs_write and emacs_gnutls_write. Do not attempt to store
6721 a byte offset into an 'int'; it might overflow.
9587a89d 6722 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6723
3e047f51
PE
6724 * sound.c: Don't assume sizes fit in 'int'.
6725 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6726 Return EMACS_INT, not int.
3e047f51 6727 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6728 Accept EMACS_INT, not int.
6729 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6730 record read return values.
6731
cc39a9db
BK
67322011-04-15 Ben Key <bkey76@gmail.com>
6733
c9d0ec6d
JB
6734 * keyboard.c (Qundefined): Don't declare static since it is used
6735 in nsfns.m.
6736 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6737 static since they are used in nsfont.m.
cc39a9db 6738
6c60eb9f
SM
67392011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6740
6741 * process.c (Qprocessp): Don't declare static.
6742 * lisp.h (Qprocessp): Declare again.
6743
7990b61a
JB
67442011-04-15 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6747
5d4cb038
PE
67482011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6749
8bd7b830 6750 Improve C-level modularity by making more things 'static'.
cd64ea1d 6751
e3b27b31
PE
6752 Don't publish debugger-only interfaces to other modules.
6753 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6754 (verify_bytepos, count_markers): Move decls to the only modules
6755 that need them.
6756 * region-cache.h (pp_cache): Likewise.
6757 * window.h (check_all_windows): Likewise.
6758 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6759
5d4cb038
PE
6760 * sysdep.c (croak): Now static, if
6761 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6762 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6763
6764 * alloc.c (refill_memory_reserve): Now static if
6765 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6766 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6767
e87b6180
PE
6768 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6769 Define only if USE_LUCID.
6770
ac64929e
PE
6771 * xrdb.c (x_customization_string, x_rm_string): Now static.
6772
6f37259d
PE
6773 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6774 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6775
1683e3ab
PE
6776 * xdisp.c (draw_row_with_mouse_face): Now static.
6777 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6778
de9c2632
PE
6779 * window.h (check_all_windows): Mark externally visible.
6780
2b96acb7
PE
6781 * window.c (window_deletion_count): Now static.
6782
6783 * undo.c: Make symbols static if they're not exported.
6784 (last_undo_buffer, last_boundary_position, pending_boundary):
6785 Now static.
6786
50436f33
PE
6787 * textprop.c (interval_insert_behind_hooks): Now static.
6788 (interval_insert_in_front_hooks): Likewise.
6789
64520e5c
PE
6790 * term.c: Make symbols static if they're not exported.
6791 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6792 (max_frame_lines, tty_set_terminal_modes):
6793 (tty_reset_terminal_modes, tty_turn_off_highlight):
6794 (get_tty_terminal): Now static.
6795 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6796 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6797 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6798 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6799 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6800
1fa53021
PE
6801 * sysdep.c: Make symbols static if they're not exported.
6802 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6803 Now static.
6804 (sigprocmask_set, full_mask): Remove; unused.
6805 (wait_debugging): Mark as visible.
6806 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6807 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6808
d4b43b22
PE
6809 * syntax.c (syntax_temp): Define only if !__GNUC__.
6810
b7c513d0
PE
6811 * sound.c (current_sound_device, current_sound): Now static.
6812
989b29ad
PE
6813 * search.c (searchbufs, searchbuf_head): Now static.
6814
13a55a78
PE
6815 * scroll.c (scroll_cost): Remove; unused.
6816 * dispextern.h (scroll_cost): Remove decl.
6817
de68a1fc
PE
6818 * region-cache.h (pp_cache): Mark as externally visible.
6819
40ccffa6
PE
6820 * process.c: Make symbols static if they're not exported.
6821 (process_tick, update_tick, create_process, chan_process):
6822 (Vprocess_alist, proc_buffered_char, datagram_access):
6823 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6824 (deactivate_process): Mark defn as static, as well as decl.
6825 * lisp.h (create_process): Remove decl.
6826 * process.h (chan_process, Vprocess_alist): Remove decls.
6827
ad64fc97
PE
6828 * print.c: Make symbols static if they're not exported.
6829 (print_depth, new_backquote_output, being_printed, print_buffer):
6830 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6831 (print_interval, print_number_index, initial_stderr_stream):
6832 Now static.
6833 * lisp.h (Fprinc): Remove decl.
6834 (debug_output_compilation_hack): Mark as externally visible.
6835
adddb265
PE
6836 * sysdep.c (croak): Move decl from here to syssignal.h.
6837 * syssignal.h (croak): Put it here, so the API can be checked when
6838 'croak' is called from dissociate_if_controlling_tty.
6839
1717ede2
PE
6840 * minibuf.c: Make symbols static if they're not exported.
6841 (minibuf_save_list, choose_minibuf_frame): Now static.
6842 * lisp.h (choose_minibuf_frame): Remove decl.
6843
fa5fb2bc
PE
6844 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6845
1e3890d1
PE
6846 * lread.c: Make symbols static if they're not exported.
6847 (read_objects, initial_obarray, oblookup_last_bucket_number):
6848 Now static.
6849 (make_symbol): Remove; unused.
6850 * lisp.h (initial_obarray, make_symbol): Remove decls.
6851
8a1414fa
PE
6852 * keyboard.c: Make symbols static if they're not exported.
6853 (single_kboard, recent_keys_index, total_keys, recent_keys):
6854 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6855 (this_single_command_key_start, echoing, last_auto_save):
6856 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6857 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6858 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6859 (Vlispy_mouse_stem, double_click_count):
6860 Now static.
6861 (force_auto_save_soon): Define only if SIGDANGER.
6862 (ignore_mouse_drag_p): Now static if
6863 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6864 (print_help): Remove; unused.
6865 (stop_character, last_timer_event): Mark as externally visible.
6866 * keyboard.h (ignore_mouse_drag_p): Declare only if
6867 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6868 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6869 * lisp.h (echoing): Remove decl.
6870 (force_auto_save_soon): Declare only if SIGDANGER.
6871 * xdisp.c (redisplay_window): Simplify code, to make it more
6872 obvious that ignore_mouse_drag_p is not accessed if !defined
6873 USE_GTK && !defined HAVE_NS.
6874
93ea6e8f
PE
6875 * intervals.c: Make symbols static if they're not exported.
6876 (merge_properties_sticky, merge_interval_right, delete_interval):
6877 Now static.
6878 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6879
77382fcc
PE
6880 * insdel.c: Make symbols static if they're not exported.
6881 However, leave prepare_to_modify_buffer alone. It's never
6882 called from outside this function, but that appears to be a bug.
6883 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6884 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6885 (adjust_after_replace_noundo): Remove; unused.
6886 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6887 (signal_before_change): Remove decls.
77382fcc 6888
9306c32e
PE
6889 * indent.c (val_compute_motion, val_vmotion): Now static.
6890
cd44d2eb
PE
6891 * image.c: Make symbols static if they're not exported.
6892 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6893 if USE_GTK.
6894 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6895 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6896
ad9a7a06
PE
6897 * fringe.c (standard_bitmaps): Now static.
6898 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6899
81626931
PE
6900 * frame.c: Make symbols static if they're not exported.
6901 (x_report_frame_params, make_terminal_frame): Now static.
6902 (get_frame_param): Now static, unless HAVE_NS.
6903 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6904 (x_get_resource_string): Remove; not used.
6905 * frame.h (make_terminal_frame, x_report_frame_params):
6906 (x_get_resource_string); Remove decls.
6907 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6908 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6909
239f9db9
PE
6910 * font.c, fontset.c: Make symbols static if they're not exported.
6911 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6912 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6913 * font.c (font_close_object): Now static.
6914 * font.h (font_close_object): Remove.
6915 * fontset.c (FONTSET_OBJLIST): Remove.
6916 (free_realized_fontset) #if-0 the body, which does nothing.
6917 (face_suitable_for_char_p): #if-0, as it's never called.
6918 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6919 * xfaces.c (face_at_string_position):
6920 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6921 since 0 is always ASCII.
6922
dfcf3579
PE
6923 * fns.c (weak_hash_tables): Now static.
6924
5045092b
PE
6925 * fileio.c: Make symbols static if they're not exported.
6926 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6927 (Vwrite_region_annotation_buffers): Now static.
6928
57a96f5c
PE
6929 * eval.c: Make symbols static if they're not exported.
6930 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6931 * lisp.h (backtrace_list): Remove decl.
6932
35f08c38
PE
6933 * emacs.c: Make symbols static if they're not exported.
6934 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6935 (fatal_error_code, fatal_error_signal_hook, standard_args):
6936 Now static.
6937 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6938 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6939 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6940 * lisp.h (fatal_error_signal_hook): Remove decl.
6941 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6942
f44bd759
PE
6943 * editfns.c: Move a (normally-unused) function to its only use.
6944 * editfns.c, lisp.h (get_operating_system_release): Remove.
6945 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6946 worth the hassle of breaking this out.
6947
b532497d
PE
6948 * xterm.c: Make symbols static if they're not exported.
6949 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6950 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6951 (x_destroy_window, x_delete_display):
6952 Now static.
6953 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6954 (x_mouse_leave): Remove; unused.
6955 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6956 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6957 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6958 Remove decls.
6959 (x_mouse_leave): Declare only if WINDOWSNT.
6960 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6961 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6962 USE_X_TOOLKIT.
6963
1675728f
PE
6964 * ftxfont.c: Make symbols static if they're not exported.
6965 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6966 HAVE_FREETYPE.
6967 * font.h (ftxfont_driver): Likewise.
6968
e4cebfca
PE
6969 * xfns.c: Make symbols static if they're not exported.
6970 (x_last_font_name, x_display_info_for_name):
6971 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6972 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6973 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6974 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6975 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6976 (last_show_tip_args): Now static.
6977 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6978 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6979 (x_screen_planes): Remove; unused.
6980 * dispextern.h (x_screen_planes): Remove decl.
6981
5bf46f05
PE
6982 * dispnew.c: Make symbols static if they're not exported.
6983 * dispextern.h (redraw_garbaged_frames, scrolling):
6984 (increment_row_positions): Remove.
6985 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6986 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6987 Now static.
6988 (redraw_garbaged_frames): Remove; unused.
6989
435f4c28
PE
6990 * xfaces.c: Make symbols static if they're not exported.
6991 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6992 Remove decls.
6993 * xterm.h (defined_color): Remove decls.
6994 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6995 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6996 (menu_face_changed_default, defined_color, free_realized_face):
6997 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6998 (ascii_face_of_lisp_face): Remove; unused.
6999
8524aef3
PE
7000 * xdisp.c: Make symbols static if they're not exported.
7001 * dispextern.h (scratch_glyph_row, window_box_edges):
7002 (glyph_to_pixel_coords, set_cursor_from_row):
7003 (get_next_display_element, set_iterator_to_next):
7004 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7005 (show_mouse_face): Remove decls
7006 * frame.h (message_buf_print): Likewise.
7007 * lisp.h (pop_message, set_message, check_point_in_composition):
7008 Likewise.
7009 * xterm.h (set_vertical_scroll_bar): Likewise.
7010 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7011 (message_buf_print, scratch_glyph_row, displayed_buffer):
7012 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7013 (get_next_display_element, show_mouse_face, window_box_edges):
7014 (frame_to_window_pixel_xy, check_point_in_composition):
7015 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7016 (glyph_to_pixel_coords): Remove; unused.
7017
16390cd2
PE
7018 * dired.c (file_name_completion): Now static.
7019
7020 * dbusbind.c (xd_in_read_queued_messages): Now static.
7021
a25f4dfa
PE
7022 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7023 * data.c (circular_list_error): Remove.
7024
14a9c8df
PE
7025 * commands.h (last_point_position, last_point_position_buffer):
7026 (last_point_position_window): Remove decls.
7027 * keyboard.c: Make these variables static.
7028
04f2d78b
CB
7029 * coding.h (coding, code_convert_region, encode_coding_gap):
7030 Remove decls.
74ab6df5
PE
7031 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7032 (iso_code_class, detect_coding, code_convert_region): Now static.
7033 (encode_coding_gap): Remove; unused.
7034
38dfbee1
PE
7035 * chartab.c (chartab_chars, chartab_bits): Now static.
7036
a2cb4e63
PE
7037 * charset.h (charset_iso_8859_1): Remove decl.
7038 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7039 Now static.
7040
127198fd
PE
7041 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7042 * ccl.c (Vccl_program_table): Now static.
7043 (check_ccl_update): Remove; unused.
7044
d85b608f
PE
7045 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7046 * category.h: ... from here.
7047 * category.c (check_category_table, set_category_set): Now static.
7048
31cd66f3
PE
7049 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7050 * lisp.h: Remove these decls.
7051
c358e587
PE
7052 * buffer.c (buffer_count): Remove unused var.
7053
e78aecca
PE
7054 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7055 so that it's not optimized away.
7056 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7057 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7058 exported only to the debugger.
7059
e192d7d3 7060 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7061 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7062
92470028
PE
7063 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7064 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7065 was inaccessible from Lisp.
7066 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7067 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7068
244ed907
PE
7069 alloc.c: Import and export fewer symbols, and remove unused items.
7070 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7071 is defined.
7072 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7073 it's not optimized away by whole-program optimization.
7074 (message_enable_multibyte, free_misc): Remove.
7075 (catchlist, handlerlist, mark_backtrace):
7076 Declare only if BYTE_MARK_STACK.
7077 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7078 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7079 (message_enable_multibyte): Remove decl.
7080 (free_misc, interval_free_list, float_block, float_block_index):
7081 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7082 (cons_free_list, last_marked_index):
7083 Now static.
7084 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7085 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7086 (mark_backtrace): Define only if BYTE_MARK_STACK.
7087 * xdisp.c (message_enable_multibyte): Now static.
7088
61c2b50e 7089 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7090 This makes it easier for human readers (and static analyzers)
7091 to see whether these variables are used from other modules.
7092 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7093 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7094 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7095 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7096 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7097 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7098 * xmenu.c, xselect.c:
7099 Declare Q* vars static if they are not used in other modules.
7100 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7101 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7102 Remove decls of unexported vars.
7103 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7104
95c82688
PE
7105 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7106
16a97296
PE
7107 Make Emacs functions such as Fatom 'static' by default.
7108 This makes it easier for human readers (and static analyzers)
7109 to see whether these functions can be called from other modules.
7110 DEFUN now defines a static function. To make the function external
7111 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7112 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7113 (Finit_image_library):
16a97296
PE
7114 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7115 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7116 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7117 Remove decls, since these functions are now static.
7118 (Funintern, Fget_internal_run_time): New decls, since these functions
7119 were already external.
95c82688 7120
16a97296
PE
7121 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7122 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7123 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7124 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7125 * keyboard.c, keymap.c, lread.c:
7126 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7127 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7128 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7129 Mark functions with DEFUE instead of DEFUN,
7130 if they are used in other modules.
7131 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7132 decls for now-static functions.
7133 * buffer.h (Fdelete_overlay): Remove decl.
7134 * callproc.c (Fgetenv_internal): Mark as internal.
7135 * composite.c (Fremove_list_of_text_properties): Remove decl.
7136 (Fcomposition_get_gstring): New forward static decl.
7137 * composite.h (Fcomposite_get_gstring): Remove decl.
7138 * dired.c (Ffile_attributes): New forward static decl.
7139 * doc.c (Fdocumntation_property): New forward static decl.
7140 * eval.c (Ffetch_bytecode): New forward static decl.
7141 (Funintern): Remove extern decl; now in .h file where it belongs.
7142 * fileio.c (Fmake_symbolic_link): New forward static decl.
7143 * image.c (Finit_image_library): New forward static decl.
7144 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7145 * intervals.h (Fprevious_property_change):
7146 (Fremove_list_of_text_properties): Remove decls.
7147 * keyboard.c (Fthis_command_keys): Remove decl.
7148 (Fcommand_execute): New forward static decl.
7149 * keymap.c (Flookup_key): New forward static decl.
7150 (Fcopy_keymap): Now static.
7151 * keymap.h (Flookup_key): Remove decl.
7152 * process.c (Fget_process): New forward static decl.
7153 (Fprocess_datagram_address): Mark as internal.
7154 * syntax.c (Fsyntax_table_p): New forward static decl.
7155 (skip_chars): Remove duplicate decl.
7156 * textprop.c (Fprevious_property_change): New forward static decl.
7157 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7158 Now internal.
7159 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7160 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7161
785bbd42
PE
7162 * editfns.c (Fformat): Remove unreachable code.
7163
8b913b57
AS
71642011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7165
7166 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7167 change. (Bug#8496)
7168
a6744a35
EZ
71692011-04-13 Eli Zaretskii <eliz@gnu.org>
7170
7171 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7172 when at ZV. (Bug#8487)
7173
e7974947
AS
71742011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7175
baad03f0
AS
7176 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7177 (Bug#8437)
7178 * keyboard.c (parse_tool_bar_item): Likewise.
7179 * sound.c (sound_cleanup, alsa_close): Likewise.
7180 * termcap.c (tgetent): Likewise.
7181 * xfns.c (x_default_font_parameter): Likewise.
7182 * xsettings.c (read_and_apply_settings): Likewise.
7183
e7974947
AS
7184 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7185 (overrun_check_free): Protoize.
7186
28272684
PE
71872011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7188
7189 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7190 since callers should never pass a negative size.
7191 Change the signature to match that of plain 'read' and 'write'; see
7192 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7193 * lisp.h: Update prototypes of emacs_write and emacs_read.
7194
11997c76
EZ
71952011-04-11 Eli Zaretskii <eliz@gnu.org>
7196
7197 * xdisp.c (redisplay_window): Don't try to determine the character
7198 position of the scroll margin if the window start point w->startp
e896f03c 7199 is outside the buffer's accessible region. (Bug#8468)
11997c76 7200
8a2cbd72
EZ
72012011-04-10 Eli Zaretskii <eliz@gnu.org>
7202
7203 Fix write-region and its subroutines for buffers > 2GB.
7204 * fileio.c (a_write, e_write): Modify declaration of arguments and
7205 local variables to support buffers larger than 2GB.
7206 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7207
7208 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7209 argument, local variables, and return value.
7210
7211 * lisp.h: Update prototypes of emacs_write and emacs_read.
7212
7213 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7214
4073e537 72152011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7216
1ebfdcb6
PE
7217 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7218
b2ded58d
PE
7219 Fix more problems found by GCC 4.6.0's static checks.
7220
7d66342c
PE
7221 * xdisp.c (vmessage): Use a better test for character truncation.
7222
bbf47d44
PE
7223 * charset.c (load_charset_map): <, not <=, for optimization,
7224 and to avoid potential problems with integer overflow.
9248994d 7225 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7226 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7227 * editfns.c (Fformat): Likewise.
1e69125e 7228 * syntax.c (skip_chars): Likewise.
3befa583 7229
e3019616
PE
7230 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7231 This also lets GCC 4.6.0 generate slightly better loop code.
7232
becfa255
PE
7233 * callint.c (Fcall_interactively): <, not <=, for optimization.
7234 (Fcall_interactively): Count the number of arguments produced,
7235 not the number of arguments given. This is simpler and lets GCC
7236 4.6.0 generate slightly better code.
7237
dae0cd48
PE
7238 * ftfont.c: Distingish more carefully between FcChar8 and char.
7239 The previous code passed unsigned char * to a functions like
7240 strlen and xstrcasecmp that expect char *, which does not
7241 conform to the C standard.
7242 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7243 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7244 char * when the C standard requires it.
7245
76032d70
PE
7246 * keyboard.c (read_char): Remove unused var.
7247
eb3f1cc8
PE
7248 * eval.c: Port to Windows vsnprintf (Bug#8435).
7249 Include <limits.h>.
7250 (SIZE_MAX): Define if the headers do not.
7251 (verror): Do not give up if vsnprintf returns a negative count.
7252 Instead, grow the buffer. This ports to Windows vsnprintf, which
7253 does not conform to C99. Problem reported by Eli Zaretskii.
7254 Also, simplify the allocation scheme, by avoiding the need for
7255 calling realloc, and removing the ALLOCATED variable.
7256
70476b54
PE
7257 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7258
12020a9e
PE
7259 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7260 But keep the doprint source code for now, as we might revamp it
7261 and use it again (Bug#8435).
ea6c7ae6
PE
7262 * lisp.h (doprnt): Remove.
7263 * Makefile.in (base_obj): Remove doprnt.o.
7264 * deps.mk (doprnt.o): Remove.
7265
5fdb398c
PE
7266 error: Print 32- and 64-bit integers portably (Bug#8435).
7267 Without this change, on typical 64-bit hosts error ("...%d...", N)
7268 was used to print both 32- and 64-bit integers N, which relied on
7269 undefined behavior.
7270 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7271 New macro.
7272 * lisp.h (error, verror): Mark as printf-like functions.
7273 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7274 Report overflow in size calculations when allocating printf buffer.
7275 Do not truncate output string at its first null byte.
7276 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7277 Truncate the output at a character boundary, since vsnprintf does not
7278 do that.
7279 * charset.c (check_iso_charset_parameter): Convert internal
7280 character to string before calling 'error', since %c now has the
7281 printf meaning.
7282 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7283 overflow when computing char to be passed to 'error'. Do not
7284 pass Lisp_Object to 'error'; pass the integer instead.
7285 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7286 formatted with plain %d.
7287
b189fa66
PE
7288 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7289
bff87ef0
PE
7290 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7291
7e2cac20
PE
7292 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7293
ce4d90b5
PE
7294 * xterm.c (x_catch_errors): Remove duplicate declaration.
7295
266c9547
PE
7296 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7297
79c49ad2
PE
7298 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7299
368f4090
JM
73002011-04-10 Jim Meyering <meyering@redhat.com>
7301
7302 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7303 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7304 return ssize_t not "int", and use size_t as the buffer length.
7305 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7306 * gnutls.h: Update declarations.
7307 * process.c (read_process_output): Use ssize_t, to match.
7308 (send_process): Likewise.
7309
a32d4040
CY
73102011-04-09 Chong Yidong <cyd@stupidchicken.com>
7311
7312 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7313
8546720e 73142011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7315
04f2d78b
CB
7316 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7317 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7318
8546720e
GM
7319 * xterm.c (handle_one_xevent):
7320 * xmenu.c (create_and_show_popup_menu):
7321 * xselect.c (x_decline_selection_request)
7322 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7323
0a2f5c1a 73242011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7325
7326 Fix some uses of `int' instead of EMACS_INT.
7327 * search.c (string_match_1, fast_string_match)
7328 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7329 (scan_buffer, find_next_newline_no_quit)
7330 (find_before_next_newline, search_command, Freplace_match)
7331 (Fmatch_data): Make some `int' variables be EMACS_INT.
7332
7333 * xdisp.c (display_count_lines): 3rd argument and return value now
7334 EMACS_INT. All callers changed.
7335 (pint2hrstr): Last argument is now EMACS_INT.
7336
7337 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7338 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7339 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7340 (decode_coding_utf_16, decode_coding_emacs_mule)
7341 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7342 (decode_coding_ccl, decode_coding_charset)
7343 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7344 (decode_coding_iso_2022, decode_coding_emacs_mule)
7345 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7346 <char_offset, last_offset>: Declare EMACS_INT.
7347 (encode_coding_utf_8, encode_coding_utf_16)
7348 (encode_coding_emacs_mule, encode_invocation_designation)
7349 (encode_designation_at_bol, encode_coding_iso_2022)
7350 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7351 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7352 Declare EMACS_INT.
7353 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7354 (encode_invocation_designation): Last argument P_NCHARS is now
7355 EMACS_INT.
7356 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7357 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7358
7359 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7360 All users changed.
7361
7362 * ccl.c (Fccl_execute_on_string): Declare some variables
7363 EMACS_INT.
7364
8546720e 73652011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7366
7367 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7368
4e19a977
CS
73692011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7370
7371 * process.c (Fformat_network_address): Doc fix.
7372
87302331
R
73732011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7374
ee7683eb 7375 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7376
cbb59342
CY
73772011-04-08 Chong Yidong <cyd@stupidchicken.com>
7378
7379 * keyboard.c (read_char): Call Lisp function help-form-show,
7380 instead of using internal_with_output_to_temp_buffer.
7381 (Qhelp_form_show): New var.
e0d38eeb 7382 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7383
7384 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7385
7386 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7387
e67a13ab
CY
73882011-04-06 Chong Yidong <cyd@stupidchicken.com>
7389
04f2d78b
CB
7390 * process.c (Flist_processes): Remove to Lisp.
7391 (list_processes_1): Delete.
e67a13ab 7392
973f782d
EZ
73932011-04-06 Eli Zaretskii <eliz@gnu.org>
7394
7c106b1e
EZ
7395 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7396
973f782d
EZ
7397 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7398
41cf7d1a 73992011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7400
ca23cc88
PE
7401 Fix more problems found by GCC 4.6.0's static checks.
7402
f390e2d5
PE
7403 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7404
42eea0d0
PE
7405 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7406
b69769da 7407 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7408
f9541e84
PE
7409 * xdisp.c (vmessage): Mark as a printf-like function.
7410
13841b55
PE
7411 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7412
c136c10f
PE
7413 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7414
5e2d4a30
PE
7415 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7416 printf-like functions.
7417 (tiff_load): Add casts to remove these marks before passing them
7418 to system-supplied API.
7419
583f48b9
PE
7420 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7421
b25d760e
PE
7422 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7423 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7424 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7425 directly, rather than having caller test rule sign. This avoids
7426 some unnecessary tests.
7427 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7428 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7429 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7430
bc7b6697 7431 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7432 (xfont_open): Avoid unnecessary tests.
bc7b6697 7433
27ccc379
PE
7434 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7435
dcd5c89a
PE
7436 * composite.h, composite.c (composition_gstring_put_cache):
7437 Use EMACS_INT, not int, for length.
7438
b13a45c6
PE
7439 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7440 breaking out part of COMPOSITION_DECODE_RULE.
7441 (COMPOSITION_DECODE_RULE): Use it.
7442 * composite.c (get_composition_id): Remove unused local vars,
7443 by using the new macro.
7444
1e792e4d
PE
7445 * textprop.c (set_text_properties_1): Change while to do-while,
7446 since the condition is always true at first.
7447
dc6c6455 7448 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7449 (interval_deletion_adjustment): Return unsigned value.
7450 All uses changed.
dc6c6455 7451
aba7731a
PE
7452 * process.c (list_processes_1, create_pty, read_process_output):
7453 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7454 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7455 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7456 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7457 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7458
fdfc4bf3
PE
7459 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7460
fca8fe46 7461 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7462 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7463
06a0259a 7464 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7465 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7466 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7467
e7b9e80f
PE
7468 * print.c (print_error_message): Avoid int overflow.
7469
56201685
PE
7470 * font.c (font_list_entities): Redo for clarity,
7471 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7472
78834453 7473 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7474 (font_score): Avoid potential overflow in diff calculation.
78834453 7475
0bc0b309 7476 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7477 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7478
e610eaca
PE
7479 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7480
b895abce
PE
7481 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7482 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7483 can always succeed if overflow has undefined behavior.
7484
1f1d9321 7485 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7486 (wordify): Omit three unnecessary tests.
1f1d9321 7487
c59478bc
PE
7488 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7489 All callers changed. This avoids the need for an unused var.
7490
79b73827
PE
7491 * casefiddle.c (casify_region): Remove var that is set but not used.
7492
a4db5dfe
PE
7493 * dired.c (file_name_completion): Remove var that is set but not used.
7494
43aae36e
PE
7495 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7496
2a47c44d 7497 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7498 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7499
a37c69bf
PE
7500 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7501 Check for integer overflow on size calculations.
7502
328ab8e7
PE
7503 * buffer.c (Fprevious_overlay_change): Remove var that is set
7504 but not used.
7505
e5a2a5cb
PE
7506 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7507 Remove vars that are set but not used.
8d84a6eb 7508 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7509 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7510
a60e5f68
PE
7511 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7512
f661cb61 7513 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7514 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7515
f0397f5a
PE
7516 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7517 that are set but not used.
7518
8664db06 7519 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7520 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7521
6abdaa4a
PE
7522 * xselect.c (x_get_local_selection, x_handle_property_notify):
7523 Remove vars that are set but not used.
7524
0ce7538d 7525 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7526 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7527
9ae848fc
PE
7528 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7529 Remove var that is set but not used.
0b918413
PE
7530 (scroll_bar_windows_size): Now size_t, not int.
7531 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7532 Check for overflow.
9ae848fc 7533
a5a62657
PE
7534 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7535 (map_tty_color) [!defined MSDOS]: Likewise.
7536
5c5cdd39
PE
7537 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7538
66ebf983
PE
7539 * coding.c: Remove vars that are set but not used.
7540 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7541 All callers changed.
7542 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7543 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7544 (decode_coding_charset): Remove vars that are set but not used.
7545
1be4d761
PE
7546 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7547 that is set but not used.
7548
47553fa8
PE
7549 * print.c (print_object): Remove var that is set but not used.
7550
1f7196bf 7551 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7552 The gnulib version avoids calling malloc in the usual case,
7553 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7554 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7555 * filelock.c (current_lock_owner): Likewise.
7556 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7557 * sysdep.c: Include allocator.h, careadlinkat.h.
7558 (emacs_no_realloc_allocator): New static constant.
7559 (emacs_readlink): New function.
fdb61804
PE
7560 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7561 ../lib/careadlinkat.h.
d1fdcab7 7562
f84c17c7
SM
75632011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7564
7565 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7566 first non-nil return value).
7567
ef3862ad
JD
75682011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7569
7570 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7571 if not defined (Bug#8403).
7572
376a7006
JB
75732011-04-02 Juanma Barranquero <lekktu@gmail.com>
7574
7575 * xdisp.c (display_count_lines): Remove parameter `start',
7576 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7577 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7578 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7579 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7580 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7581 and thereabouts. All callers changed.
7582 (get_per_char_metric): Remove parameter `f', unused since
7583 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7584
6ca3801d
JM
75852011-04-02 Jim Meyering <meyering@redhat.com>
7586
7587 do not dereference NULL upon failed strdup
7588 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7589 (ns_get_family): Likewise.
7590
d8e2b5ba
JB
75912011-04-02 Juanma Barranquero <lekktu@gmail.com>
7592
7593 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7594
8c74fcbd
JD
75952011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7596
7597 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7598 later (Bug#8403).
7599
7200d79c
SM
76002011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7601
03408648 7602 Add lexical binding.
7200d79c 7603
03408648
SM
7604 * window.c (Ftemp_output_buffer_show): New fun.
7605 (Fsave_window_excursion):
7606 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7607
7608 * lread.c (lisp_file_lexically_bound_p): New function.
7609 (Fload): Bind Qlexical_binding.
7610 (readevalloop): Remove `evalfun' arg.
7611 Bind Qinternal_interpreter_environment.
7612 (Feval_buffer): Bind Qlexical_binding.
7613 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7614 Mark as dynamic.
7615 (syms_of_lread): Declare `lexical-binding'.
7616
7617 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7618
7619 * keyboard.c (eval_dyn): New fun.
7620 (menu_item_eval_property): Use it.
ca105506
SM
7621
7622 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7623
03408648
SM
7624 * fns.c (concat, mapcar1): Accept byte-code-functions.
7625
7626 * eval.c (Fsetq): Handle lexical vars.
7627 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7628 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7629 (FletX, Flet): Obey lexical binding.
7630 (Fcommandp): Handle closures.
7631 (Feval): New `lexical' arg.
7632 (eval_sub): New function extracted from Feval. Use it almost
7633 everywhere where Feval was used. Look up vars in lexical env.
7634 Handle closures.
7635 (Ffunctionp): Move from subr.el.
7636 (Ffuncall): Handle closures.
7637 (apply_lambda): Remove `eval_flags'.
7638 (funcall_lambda): Handle closures and new byte-code-functions.
7639 (Fspecial_variable_p): New function.
7640 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7641 but without exporting it to Lisp.
23aba0ea 7642
23aba0ea 7643 * doc.c (Fdocumentation, store_function_docstring):
03408648 7644 * data.c (Finteractive_form): Handle closures.
23aba0ea 7645
03408648
SM
7646 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7647 interactive spec.
ba83908c 7648
04f2d78b
CB
7649 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7650 New byte-codes.
03408648
SM
7651 (exec_byte_code): New function extracted from Fbyte_code to handle new
7652 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7653
03408648 7654 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7655
03408648 7656 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7657
e2abce01
JB
76582011-03-31 Juanma Barranquero <lekktu@gmail.com>
7659
7660 * xdisp.c (redisplay_internal): Fix prototype.
7661
63696a73 76622011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7663
63696a73 7664 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7665 (try_scrolling): Use it when setting scroll_limit.
7666 Limit scrolling to 100 screen lines.
63696a73
EZ
7667 (redisplay_window): Even when falling back on "recentering",
7668 position point in the window according to scroll-conservatively,
7669 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7670
7671 (try_scrolling): When point is above the window, allow searching
7672 as far as scroll_max, or one screenful, to compute vertical
7673 distance from PT to the scroll margin position. This prevents
7674 try_scrolling from unnecessarily failing when
7675 scroll-conservatively is set to a value slightly larger than the
7676 window height. Clean up the case of PT below the margin at bottom
7677 of window: scroll_max can no longer be INT_MAX. When aggressive
7678 scrolling is in use, don't let point enter the opposite scroll
7679 margin as result of the scroll.
7680 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7681 threshold of 100 lines for never-recentering scrolling.
7682
e4cc2dfc
JB
76832011-03-31 Juanma Barranquero <lekktu@gmail.com>
7684
7685 * dispextern.h (move_it_by_lines):
7686 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7687 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7688 (message_log_check_duplicate): Remove parameters `prev_bol' and
7689 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7690 (redisplay_internal): Remove parameter `preserve_echo_area',
7691 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7692
7693 * indent.c (Fvertical_motion):
7694 * window.c (window_scroll_pixel_based, Frecenter):
7695 Don't pass `need_y_p' to `move_it_by_lines'.
7696
1c470562
SM
76972011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7698
44f230aa
SM
7699 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7700 steal a few bits to be more compact.
7701 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7702 Remove unneeded casts.
7703
1c470562
SM
7704 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7705
888adce9
ZK
77062011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7707
7708 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7709 binding" message (bug#7967).
7710
f838ed7b
PE
77112011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7712
77861b95
PE
7713 Fix more problems found by GCC 4.6.0's static checks.
7714
de6dbc14
PE
7715 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7716 Remove unused local var.
7717
f838ed7b
PE
7718 * editfns.c (Fmessage_box): Remove unused local var.
7719
792c7b2b
PE
7720 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7721 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7722 Omit unused local vars.
c499e557 7723 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7724 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7725 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7726 Omit unused local var.
7727
ba0165e1
PE
7728 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7729 Don't assume string length fits in int.
32ad8845 7730 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7731 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7732
3c59b4c9
PE
7733 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7734 instead of alloca (Bug#8344).
7735
a3eed478 7736 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7737 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7738
eb4d412d
PE
7739 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7740
1658b401
PE
7741 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7742 concerns.
7743
7744 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7745
7746 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7747
9a2c6e05
PE
7748 * keyboard.c (syms_of_keyboard): Use the same style as later
7749 in this function when indexing through an array. This also
7750 works around GCC bug 48267.
7751
03d0a109
PE
7752 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7753
44f730c8
PE
7754 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7755
fe75f926
PE
7756 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7757 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7758
ffa8c828
PE
7759 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7760 This avoids undefined behavior on integer overflow, and is a bit
7761 more convenient anyway since it is compared to a size_t variable.
7762
c5101a77
PE
7763 Variadic C functions now count arguments with size_t, not int.
7764 This avoids an unnecessary limitation on 64-bit machines, which
7765 caused (substring ...) to crash on large vectors (Bug#8344).
7766 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7767 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7768 All variadic functions and their callers changed accordingly.
c5101a77
PE
7769 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7770 * data.c (arith_driver, float_arith_driver): Likewise.
7771 * editfns.c (general_insert_function): Likewise.
7772 * eval.c (struct backtrace.nargs, interactive_p)
7773 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7774 (funcall_lambda, mark_backtrace): Likewise.
7775 * fns.c (concat): Likewise.
7776 * frame.c (x_set_frame_parameters): Likewise.
7777 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7778 0 if not found, not -1. All callers changed.
7779
dd3f25f7
PE
7780 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7781 (stack_copy_size): Now size_t, not int.
7782 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7783
461c2ab9
JB
77842011-03-28 Juanma Barranquero <lekktu@gmail.com>
7785
7786 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7787 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7788 All callers changed.
7789
7790 * lisp.h (multibyte_char_to_unibyte):
7791 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7792 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7793 * character.h (CHAR_TO_BYTE8):
7794 * cmds.c (internal_self_insert):
7795 * editfns.c (general_insert_function):
7796 * keymap.c (push_key_description):
7797 * search.c (Freplace_match):
7798 * xdisp.c (message_dolog, set_message_1): All callers changed.
7799
f6d62986
SM
78002011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7801
7802 * keyboard.c (safe_run_hook_funcall): New function.
7803 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7804 don't set the hook to nil, but remove the offending function instead.
7805 (Qcommand_hook_internal): Remove, unused.
7806 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7807 Vcommand_hook_internal.
7808
7809 * eval.c (enum run_hooks_condition): Remove.
7810 (funcall_nil, funcall_not): New functions.
7811 (run_hook_with_args): Call each function through a `funcall' argument.
7812 Remove `cond' argument, now redundant.
7813 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7814 (Frun_hook_with_args_until_failure): Adjust accordingly.
7815 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7816
1db5b1ad
JB
78172011-03-28 Juanma Barranquero <lekktu@gmail.com>
7818
7819 * dispextern.h (string_buffer_position): Remove declaration.
7820
7821 * print.c (strout): Remove parameter `multibyte', unused since
7822 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7823
7824 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7825 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7826 All callers changed.
7827
7828 * w32.c (_wsa_errlist): Use braces for struct initializers.
7829
7830 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7831 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7832 All callers changed.
7833 (string_buffer_position): Likewise. Also, make static (it's never
7834 used outside xdisp.c).
7835 (cursor_row_p): Remove parameter `w', unused since
7836 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7837 (decode_mode_spec): Remove parameter `precision', introduced during
7838 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7839 All callers changed.
7840
5ffb62aa
JD
78412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7842
7843 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7844
461c2ab9 78452011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7846
7847 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7848 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7849 (ns_update_auto_hide_menu_bar): New functions.
7850 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7851 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7852 ns_constrain_all_frames.
7853 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7854 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7855
5c380ffb
JD
78562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7857
7858 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7859
9af30bdf
GM
78602011-03-27 Glenn Morris <rgm@gnu.org>
7861
7862 * syssignal.h: Replace RETSIGTYPE with void.
7863 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7864 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7865 Replace SIGTYPE with void everywhere.
7866 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7867 * s/template.h (SIGTYPE): Remove commented out definition.
7868
e2abce01
JB
78692011-03-26 Eli Zaretskii <eliz@gnu.org>
7870
7871 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7872 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7873
f868cd8a
JB
78742011-03-26 Juanma Barranquero <lekktu@gmail.com>
7875
59eb0929
JB
7876 * w32.c (read_unc_volume): Use parameter `henum', instead of
7877 global variable `wget_enum_handle'.
7878
7879 * keymap.c (describe_vector): Remove parameters `indices' and
7880 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7881 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7882
f868cd8a
JB
7883 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7884
7885 * keyboard.c (timer_check): Remove parameter `do_it_now',
7886 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7887 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7888 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7889
7890 * keyboard.c (read_char):
7891 * w32menu.c (w32_menu_display_help):
7892 * xmenu.c (show_help_event, menu_help_callback):
7893 Adjust calls to `show_help_echo'.
7894
7895 * gtkutil.c (xg_maybe_add_timer):
7896 * keyboard.c (readable_events):
7897 * process.c (wait_reading_process_output):
7898 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7899
7900 * insdel.c (adjust_markers_gap_motion):
7901 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7902 (gap_left, gap_right): Don't call it.
7903
2ecf6fdb
CY
79042011-03-25 Chong Yidong <cyd@stupidchicken.com>
7905
7906 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7907 incurred during fontification.
7908
6b1f9ba4
JB
79092011-03-25 Juanma Barranquero <lekktu@gmail.com>
7910
7911 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7912 (DEFVAR_PER_BUFFER): Don't pass it.
7913
7914 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7915 (scrolling_window): Don't pass it.
7916
0f4a96b5
JB
79172011-03-25 Juanma Barranquero <lekktu@gmail.com>
7918
7919 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7920
7921 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7922 and `suffix'.
7923 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7924 of variables specific to SELinux and computation of `encoded_absname'.
7925
7926 * image.c (XPutPixel): Remove unused variable `height'.
7927
7928 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7929
7930 * unexw32.c (get_section_info): Remove unused variable `section'.
7931
7932 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7933 (system_process_attributes): Remove unused variable `sess'.
7934 (sys_read): Remove unused variable `err'.
7935
7936 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7937 (w32_wnd_proc): Remove unused variable `isdead'.
7938 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7939 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7940 (x_create_tip_frame): Remove unused variable `tem'.
7941
7942 * w32inevt.c (w32_console_read_socket):
7943 Remove unused variable `no_events'.
7944
7945 * w32term.c (x_draw_composite_glyph_string_foreground):
7946 Remove unused variable `width'.
7947
1149507c
JB
79482011-03-24 Juanma Barranquero <lekktu@gmail.com>
7949
7950 * w32term.c (x_set_glyph_string_clipping):
7951 Don't pass uninitialized region to CombineRgn.
7952
9c88f339
JB
79532011-03-23 Juanma Barranquero <lekktu@gmail.com>
7954
7955 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7956 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7957 (Fx_close_connection): Remove unused variable `i'.
7958
7959 * w32font.c (w32font_draw): Return number of glyphs.
7960 (w32font_open_internal): Remove unused variable `i'.
7961 (w32font_driver): Add missing initializer.
7962
7963 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7964 (fill_in_menu): Remove unused variable `items_added'.
7965
7966 * w32term.c (last_mouse_press_frame): Remove static global variable.
7967 (w32_clip_to_row): Remove unused variable `f'.
7968 (x_delete_terminal): Remove unused variable `i'.
7969
7970 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7971 (NOTHING): Remove unused static global variable.
7972 (uniscribe_check_otf): Remove unused variable `table'.
7973 (uniscribe_font_driver): Add missing initializers.
7974
dee091a3
JD
79752011-03-23 Julien Danjou <julien@danjou.info>
7976
7977 * term.c (Fsuspend_tty, Fresume_tty):
7978 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7979 * window.c (temp_output_buffer_show):
7980 * insdel.c (signal_before_change):
7981 * frame.c (Fhandle_switch_frame):
7982 * fileio.c (Fdo_auto_save):
7983 * emacs.c (Fkill_emacs):
7984 * editfns.c (save_excursion_restore):
7985 * cmds.c (internal_self_insert):
7986 * callint.c (Fcall_interactively):
7987 * buffer.c (Fkill_all_local_variables):
7988 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7989 Use Frun_hooks.
0f4a96b5 7990 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7991 unconditionally since it does the check itself.
dee091a3 7992
2c520ab5 79932011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7994
c9c49752
PE
7995 Fix more problems found by GCC 4.5.2's static checks.
7996
8abc3f12
PE
7997 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7998 the first time through the loop, since we know p0 < p1 then.
7999 This also avoids a gcc -Wstrict-overflow warning.
8000
a2d26660
PE
8001 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8002 leading to a memory leak, possible in functions like
8003 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8004 of objects (Bug#8318).
a2d26660 8005
916c72e9
PE
8006 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8007 that could (at least in theory) be that large.
8008
19ab8a18
PE
8009 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8010 This is less likely to overflow, and avoids undefined behavior if
8011 overflow does occur. All callers changed. Use strtoul to scan
8012 for the unsigned long integer.
b7cbbd6f
PE
8013 (pint2hrstr): Simplify and tune code slightly.
8014 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8015
f0641eff
PE
8016 * scroll.c (do_scrolling): Work around GCC bug 48228.
8017 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8018
7f650bb9
PE
8019 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8020 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8021 (validate_x_resource_name): Simplify count usage.
8022 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8023
37dd57d1
PE
8024 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8025 fail (Bug#8306).
81e56e61 8026
699979fc 8027 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8028
401bf9b4
PE
8029 * process.c (Fmake_network_process): Use socklen_t, not int,
8030 where POSIX says socklen_t is required in portable programs.
8031 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8032 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8033 (Fmake_network_process, server_accept_connection):
8034 (wait_reading_process_output, read_process_output):
8035 Likewise.
8036
b93aacde
PE
8037 * process.c: Rename or move locals to avoid shadowing.
8038 (list_processes_1, Fmake_network_process):
8039 (read_process_output_error_handler, exec_sentinel_error_handler):
8040 Rename or move locals.
4dc343ee 8041 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8042 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8043 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8044 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8045 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8046
af8a867c 8047 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8048 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8049 Include tparam.h instead, since it declares them.
af8a867c
PE
8050 * cm.h (PC): Remove extern decl; tparam.h now does this.
8051 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8052 * terminfo.c: Include tparam.h, to check interfaces.
8053 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8054 (tparam): Adjust signature to match interface in tparam.h;
8055 this removes some undefined behavior. Check that outstring and len
8056 are zero, which they always are with Emacs.
8057 * tparam.h (PC, BC, UP): New extern decls.
8058
0248044d 8059 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8060 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8061
8ff096c1 8062 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8063 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8064 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8065 (ftfont_list): Remove unused local.
49eaafba
PE
8066 (get_adstyle_property, ftfont_pattern_entity):
8067 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8068 Rename locals to avoid shadowing.
8ff096c1 8069
e2be39f6
PE
8070 * xfont.c (xfont_list_family): Mark var as initialized.
8071
c9735e30
PE
8072 * xml.c (make_dom): Now static.
8073
8f5201ae
PE
8074 * composite.c (composition_compute_stop_pos): Rename local to
8075 avoid shadowing.
b246f932
PE
8076 (composition_reseat_it): Remove unused locals.
8077 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8078 (composition_update_it): Mark var as initialized.
11b61122
PE
8079 (find_automatic_composition): Mark vars as initialized,
8080 with a FIXME (Bug#8290).
8f5201ae 8081
760fbc2c
PE
8082 character.h: Rename locals to avoid shadowing.
8083 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8084 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8085 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8086 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8087 to avoid shadowing.
8088
ff08eb85
PE
8089 * textprop.c (property_change_between_p): Remove; unused.
8090
fc7bf025
PE
8091 * intervals.c (interval_start_pos): Now static.
8092
235d7abc
PE
8093 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8094
44f230aa
SM
8095 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8096 Rename locals to avoid shadowing.
3e7d6594 8097
50060332
PE
8098 * sound.c (wav_play, au_play, Fplay_sound_internal):
8099 Fix pointer signedness.
d01f234b 8100 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8101 (wav_play): Initialize a variable to 0, to prevent undefined
8102 behavior (Bug#8278).
50060332 8103
c4fc4e30
PE
8104 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8105
918436ed
PE
8106 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8107
c939f91b
PE
8108 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8109 clobbering (Bug#8298).
b9c7f648
PE
8110 * sysdep.c (sys_subshell): Likewise.
8111 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8112
6bd8c144
PE
8113 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8114 This should get cleaned up, so that child_setup has the
8115 same signature on all platforms.
8116
7710357c 8117 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8118 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8119
c59da222
CY
81202011-03-22 Chong Yidong <cyd@stupidchicken.com>
8121
8122 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8123 not to be necessary, and produces flickering.
8124
66b87493
GM
81252011-03-20 Glenn Morris <rgm@gnu.org>
8126
8127 * config.in: Remove file.
8128
45b6f6d5
JB
81292011-03-20 Juanma Barranquero <lekktu@gmail.com>
8130
8131 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8132 are now in src/globals.h.
8133 (syms_of_minibuf): Remove spurious & from previous change.
8134
3ec03f7e
LL
81352011-03-20 Leo <sdl.web@gmail.com>
8136
8137 * minibuf.c (completing-read-function): New variable.
8138 (completing-read-default): Rename from completing-read.
8139 (completing-read): Call completing-read-function.
8140
b14e3e21
CY
81412011-03-19 Juanma Barranquero <lekktu@gmail.com>
8142
8143 * xfaces.c (Fx_load_color_file):
8144 Read color file from absolute filename (bug#8250).
8145
f2b726e6
JB
81462011-03-19 Juanma Barranquero <lekktu@gmail.com>
8147
8148 * makefile.w32-in: Update dependencies.
8149
09f6ff02
EZ
81502011-03-17 Eli Zaretskii <eliz@gnu.org>
8151
8152 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8153
29a6015a
PE
81542011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8155
a3a6c54e
PE
8156 Fix more problems found by GCC 4.5.2's static checks.
8157
b766f867
PE
8158 * process.c (make_serial_process_unwind, send_process_trap):
8159 (sigchld_handler): Now static.
8160
be02381c
PE
8161 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8162 That way, the code declares only the vars that it needs.
8163 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8164 * s/cygwin.h (PTY_ITERATION): Likewise.
8165 * s/darwin.h (PTY_ITERATION): Likewise.
8166 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8167
57048744
PE
8168 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8169 * process.c (allocate_pty): Don't declare stb unless it's needed.
8170
7914961c 8171 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8172 (CONSTANTLIM): Remove; unused.
8173 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8174 Define only if needed.
7914961c 8175
b3967b18
PE
8176 * unexelf.c (unexec): Name an expression,
8177 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8178 Use a different way to cause a compilation error if anyone uses
8179 n rather than nn, a way that does not involve shadowing.
73366a00 8180 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8181
29a6015a
PE
8182 * deps.mk (unexalpha.o): Remove; unused.
8183
43cfc33e 8184 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8185 * unexec.h: New file.
ce701a33
PE
8186 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8187 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8188 Depend on unexec.h.
8189 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8190 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8191 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8192 Change as necessary to match prototype in unexec.h.
ce701a33 8193
01f44d5a
PE
8194 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8195 shadowing.
4f63c6bb 8196 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8197
a6670b0b
PE
8198 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8199 Rename locals to avoid shadowing.
8200
cef2010d 8201 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8202 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8203
d4d7173a
PE
8204 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8205
f08b802a
PE
8206 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8207 warning when compiling print.c.
8208
3ddb0639
PE
8209 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8210 instead of using an uninitialized var.
5ad03b97 8211 (font_sort_entities): Mark var as initialized.
3ddb0639 8212
170a2692
PE
8213 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8214
e663c700
PE
8215 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8216 pointers to constants.
89bc529a 8217 (font_parse_fcname): Remove unused vars.
7b81e2d0 8218 (font_delete_unmatched): Now static.
ea838e10 8219 (font_get_spec): Remove; unused.
13a547c6
PE
8220 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8221 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8222 Rename or move locals to avoid shadowing.
e663c700 8223
2a80c887 8224 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8225 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8226
1384fa33 8227 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8228 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8229
8b2c52e9
PE
8230 * alloc.c (mark_backtrace): Move decl from here ...
8231 * lisp.h: ... to here, so that it can be checked.
8232
475545b5 8233 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8234 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8235 (lisp_indirect_variable): Name an expression,
8236 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8237 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8238
b1349114 8239 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8240 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8241 Use const pointer when appropriate.
b1349114 8242
a2928364
PE
8243 * lisp.h (get_system_name, get_operating_system_release):
8244 Move decls here, to check interfaces.
8245 * process.c (get_operating_system_release): Move decl to lisp.h.
8246 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8247 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8248 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8249 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8250 (Fformat_time_string, Fencode_time, Finsert_char):
8251 (Ftranslate_region_internal, Fformat):
8252 Rename or remove local vars to avoid shadowing.
9710023e 8253 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8254
a415e694
PE
8255 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8256 avoid shadowing.
8257
8ef4622d
PE
8258 * lisp.h (eassert): Check that the argument compiles, even if
8259 ENABLE_CHECKING is not defined.
8260
946f9a5b
PE
8261 * data.c (Findirect_variable): Name an expression, to avoid
8262 gcc -Wbad-function-cast warning.
112396d6 8263 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8264 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8265 (Fmake_variable_buffer_local, Fmake_local_variable):
8266 Mark variables as initialized.
52746918 8267 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8268
e5aab7e7 8269 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8270 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8271 Rename locals to avoid shadowing.
dff45157
PE
8272 (mark_stack): Move local variables into the #ifdef region where
8273 they're used.
7bc26fdb
PE
8274 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8275 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8276 needed otherwise.
8277 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8278 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8279 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8280
e5aab7e7
PE
8281 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8282 avoids undefined behavior in theory.
8283
4da60324
PE
8284 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8285
88043301
PE
8286 Use functions, not macros, for up- and down-casing (Bug#8254).
8287 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8288 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8289 to use the following functions instead of these macros.
8290 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8291 EMACS_INT, since callers assume the returned value fits in int.
8292 (upcase1): Likewise, for UPCASE_TABLE.
8293 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8294 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8295 the race-condition problem in the old DOWNCASE.
88043301 8296
19ed5445
PE
8297 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8298 Rename locals to avoid shadowing.
8299 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8300 (regex_compile, re_search_2, re_match_2_internal):
8301 Remove unused local vars.
952db0d7
PE
8302 (FREE_VAR): Rewrite so as not to use empty "else",
8303 which gcc can warn about.
da053e48 8304 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8305 (RETALLOC_IF): Define only if needed.
8306 (WORDCHAR_P): Likewise. This one is never needed, but is used
8307 only in a comment talking about a compiler bug, so put inside
8308 the #if 0 of that comment.
8309 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8310 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8311 Remove; unused.
19ed5445 8312
1f3561e4 8313 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8314 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8315 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8316
ded6f8f7
PE
8317 * search.c (simple_search): Remove unused var.
8318
dbd37a95
PE
8319 * dired.c (compile_pattern): Move decl from here ...
8320 * lisp.h: ... to here, so that it can be checked.
8321 (struct re_registers): New forward decl.
8322
7e47afad
PE
8323 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8324
85f24f61
PE
8325 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8326 All uses changed.
8327 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8328 Rename locals to avoid shadowing.
5671df8f 8329 (Fvertical_motion): Mark locals as initialized.
85f24f61 8330
181aa2be 8331 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8332 (casify_region): Mark local as initialized.
181aa2be 8333
930d429c
PE
8334 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8335
7082eac6
PE
8336 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8337 New macros, so that the caller can use some names other than
8338 gcpro1, gcpro2, etc.
8339 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8340 of the new macros.
8341 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8342 argument, for consistency with GCPRO2_VAR, etc: it is now the
8343 prefix of the variable, not the variable itself. All uses
8344 changed.
38b2c076
PE
8345 * dired.c (directory_files_internal, file_name_completion):
8346 Rename locals to avoid shadowing.
8347
15206ed9
PE
8348 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8349 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8350 dired.c's scmp function, had undefined behavior.
8351 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8352 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8353 * buffer.h: ... to here, because these macros use current_buffer,
8354 and the new implementation with inline functions needs to have
8355 current_buffer in scope now, rather than later when the macros
8356 are used.
8357 (downcase, upcase1): New static inline functions.
8358 (DOWNCASE, UPCASE1): Reimplement using these functions.
8359 This avoids undefined behavior in expressions like
8360 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8361 from race conditions in accessing the global variables
8362 case_temp1 and case_temp2.
8363 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8364 * lisp.h (case_temp1, case_temp2): Remove their decls.
8365 * character.h (ASCII_CHAR_P): Move from here ...
8366 * lisp.h: ... to here, so that the inline functions mentioned
8367 above can use them.
8368
4a6bea26
PE
8369 * dired.c (directory_files_internal_unwind): Now static.
8370
f14b7e14
PE
8371 * fileio.c (file_name_as_directory, directory_file_name):
8372 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8373 Now static.
2893f146
PE
8374 (file_name_as_directory): Use const pointers when appropriate.
8375 (Fexpand_file_name): Likewise. In particular, newdir might
8376 point at constant storage, so make it a const pointer.
fd4ead52 8377 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8378 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8379 signedness issues.
f839df0c
PE
8380 (Fset_file_times, Finsert_file_contents, auto_save_error):
8381 Rename locals to avoid shadowing.
f14b7e14 8382
5716756e 8383 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8384 (Ftry_completion, Fall_completions): Rename or remove locals
8385 to avoid shadowing.
5716756e 8386
b4c3046a
PE
8387 * marker.c (bytepos_to_charpos): Remove; unused.
8388
b45db522
PE
8389 * lisp.h (verify_bytepos, count_markers): New decls,
8390 so that gcc does not warn that these functions aren't declared.
8391
85876d07
PE
8392 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8393 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8394 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8395 (copy_text): Remove unused local var.
85876d07 8396
03d78a21 8397 * filelock.c (within_one_second): Now static.
b3dd38ab 8398 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8399
5df8f01b
PE
8400 * buffer.c (fix_overlays_before): Mark locals as initialized.
8401 (fix_start_end_in_overlays): Likewise. This function should be
8402 simplified by using pointers-to-pointers, but that's a different
8403 matter.
b1d876f1 8404 (switch_to_buffer_1): Now static.
8f54f30a
PE
8405 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8406 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8407
a70072c9 8408 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8409 Fix pointer signedness issue.
edced198
PE
8410 (sys_subshell): Mark local as volatile if checking for lint,
8411 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8412 (MAXPATHLEN): Define only if needed.
a70072c9 8413
a0977c44
PE
8414 * process.c (serial_open, serial_configure): Move decls from here ...
8415 * systty.h: ... to here, so that they can be checked.
8416
a884fdcc
PE
8417 * fns.c (get_random, seed_random): Move extern decls from here ...
8418 * lisp.h: ... to here, so that they can be checked.
8419
604efe86 8420 * sysdep.c (reset_io): Now static.
b8950c94 8421 (wait_for_termination_signal): Remove; unused.
604efe86 8422
38fc62d9
PE
8423 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8424 (copy_keymap_item, append_key, push_text_char_description):
8425 Now static.
1004a21a 8426 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8427 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8428 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8429 (describe_map_tree):
8430 Rename locals to avoid shadowing.
38fc62d9 8431
2f2650da
PE
8432 * keyboard.c: Declare functions static if they are not used elsewhere.
8433 (echo_char, echo_dash, cmd_error, top_level_2):
8434 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8435 (read_char, kbd_buffer_get_event, make_lispy_position):
8436 (make_lispy_event, make_lispy_movement, apply_modifiers):
8437 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8438 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8439 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8440 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8441 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8442
a053e86c 8443 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8444 (mark_kboards): Move decl here ...
8445 * alloc.c (mark_kboards): ... from here.
a053e86c 8446
4752793e
PE
8447 * lisp.h (force_auto_save_soon): New decl.
8448
74f10ca7 8449 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8450 (DEFINE_DUMMY_FUNCTION): New macro.
8451 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8452 Use it.
c03cd23f
PE
8453 (main): Add casts to avoid warnings
8454 if GCC considers string literals to be constants.
74f10ca7 8455
022e70d4
PE
8456 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8457
59d6fe83
PE
8458 * dbusbind.c: Pointer signedness fixes.
8459 (xd_signature, xd_append_arg, xd_initialize):
8460 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8461 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8462 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8463 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8464
78320123
PE
8465 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8466 if GCC considers string literals to be constants.
49cebcca 8467 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8468
35ac2a97
SM
84692011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8470
fb103ca9
SM
8471 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8472 (print_preprocess, print_object): New macro to fix last change.
8473
35ac2a97
SM
8474 * print.c (print_preprocess): Don't forget font objects.
8475
62973b41
JB
84762011-03-16 Juanma Barranquero <lekktu@gmail.com>
8477
8478 * emacs.c (USAGE3): Doc fixes.
8479
0e48bb22
AS
84802011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8481
8482 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8483 structure.
8484
7684e57b
JB
84852011-03-14 Juanma Barranquero <lekktu@gmail.com>
8486
8487 * lisp.h (VWindow_system, Qfile_name_history):
8488 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8489 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8490 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8491
8492 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8493 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8494
8495 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8496 * w32console.c (detect_input_pending, read_input_pending)
8497 (encode_terminal_code):
8498 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8499 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8500 (w32_system_caret_y, Qfile_name_history):
8501 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8502 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8503 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8504 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8505 * w32proc.c (Qlocal, report_file_error):
8506 * w32term.c (Vwindow_system, updating_frame):
8507 * w32uniscribe.c (initialized, uniscribe_font_driver):
8508 Remove unneeded extern declarations.
8509
2aa46d6c
CY
85102011-03-14 Chong Yidong <cyd@stupidchicken.com>
8511
c96bbc66 8512 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8513
cffc6f3b
CY
85142011-03-13 Chong Yidong <cyd@stupidchicken.com>
8515
8516 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8517 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8518 These macros can no longer be used for assignment.
8519
44f230aa
SM
8520 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8521 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8522 (record_buffer_markers, fetch_buffer_markers): New functions for
8523 recording and fetching special buffer markers.
8524 (set_buffer_internal_1, set_buffer_temp): Use them.
8525
8526 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8527
8528 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8529
8530 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8531 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8532
8533 * xdisp.c (hscroll_window_tree):
8534 (reconsider_clip_changes): Use PT instead of BUF_PT.
8535
d251f04b
EZ
85362011-03-13 Eli Zaretskii <eliz@gnu.org>
8537
8538 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8539 $(EMACS_ROOT)/lib/intprops.h.
8540
f0c77cd1
PE
85412011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8542
3eca4629
PE
8543 Fix more problems found by GCC 4.5.2's static checks.
8544
7c86ee98
PE
8545 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8546 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8547 (xg_free_frame_widgets): Make it clear that a local variable is
8548 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8549 (gdk_window_get_screen): Make it clear that this macro is needed
8550 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8551 (int_gtk_range_get_value): New function, which avoids a diagnostic
8552 from gcc -Wbad-function-cast.
8553 (xg_set_toolkit_scroll_bar_thumb): Use it.
8554 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8555 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8556 (get_utf8_string, xg_get_file_with_chooser):
8557 Rename locals to avoid shadowing.
8558 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8559
41729b81
PE
8560 * xgselect.c (xg_select): Remove unused var.
8561
f0c77cd1
PE
8562 * image.c (four_corners_best): Mark locals as initialized.
8563 (gif_load): Initialize transparent_p to zero (Bug#8238).
8564 Mark another local as initialized.
ec6cf4c6 8565 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8566
ce0ad53d 8567 * image.c (clear_image_cache): Now static.
d5d5a617 8568 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8569 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8570 (x_edge_detection): Remove unnecessary cast that
8571 gcc -Wbad-function-cast diagnoses.
2037898d 8572 (gif_load): Fix pointer signedness.
6ae141d6
PE
8573 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8574 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8575
33383987 85762011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8577
d32df629
PE
8578 Improve quality of tests for time stamp overflow.
8579 For example, without this patch (encode-time 0 0 0 1 1
8580 1152921504606846976) returns the obviously-bogus value (-948597
8581 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8582 reports time overflow. See
8583 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8584 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8585 * editfns.c: Include limits.h and intprops.h.
8586 (TIME_T_MIN, TIME_T_MAX): New macros.
8587 (time_overflow): Move earlier, to before first use.
8588 (hi_time, lo_time): New functions, for an accurate test for
8589 out-of-range times.
8590 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8591 (Fget_internal_run_time): Don't assume time_t fits in int.
8592 (make_time): Use list2 instead of Fcons twice.
8593 (Fdecode_time): More accurate test for out-of-range times.
8594 (check_tm_member): New function.
8595 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8596 (lisp_time_argument): Don't rely on undefined left-shift and
8597 right-shift behavior when checking for time stamp overflow.
8be6f318 8598
fe31d94c
PE
8599 * editfns.c (time_overflow): New function, refactoring common code.
8600 (Fformat_time_string, Fdecode_time, Fencode_time):
8601 (Fcurrent_time_string): Use it.
8602
8be6f318
PE
8603 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8604 * dired.c (make_time): Move to ...
8605 * editfns.c (make_time): ... here.
8606 * systime.h: Note the move.
8607
09d9db2c 86082011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8609
126bc0dc
YM
8610 * fringe.c (update_window_fringes): Remove unused variables.
8611
c47cbdfd
YM
8612 * unexmacosx.c (copy_data_segment): Also copy __got section.
8613 (Bug#8223)
8614
7ac80be9
EZ
86152011-03-12 Eli Zaretskii <eliz@gnu.org>
8616
c96bbc66 8617 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8618 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8619 Constify `char *' arguments and their references according to
8620 prototypes in tparam.h.
8621
ecb0f94d 8622 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8623
7ac80be9
EZ
8624 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8625 Adapt all references accordingly.
8626
8627 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8628
ef1fd07e
TT
86292011-03-11 Tom Tromey <tromey@redhat.com>
8630
8631 * buffer.c (syms_of_buffer): Remove obsolete comment.
8632
7ef4b50c
EZ
86332011-03-11 Eli Zaretskii <eliz@gnu.org>
8634
8635 * termhooks.h (encode_terminal_code): Declare prototype.
8636
8637 * msdos.c (encode_terminal_code): Don't declare prototype.
8638
8639 * term.c (encode_terminal_code): Now external again, used by
8640 w32console.c and msdos.c.
8641
44f230aa
SM
8642 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8643 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8644
4b1ec863 86452011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8646
1714f52b 8647 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8648
4b1ec863
PE
8649 * fringe.c (update_window_fringes): Mark locals as initialized
8650 (Bug#8227).
8651 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8652
524c7aa6
PE
8653 * alloc.c (mark_fringe_data): Move decl from here ...
8654 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8655 to check its interface.
8656 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8657
a5c0af81 8658 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8659 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8660 (fontset_font): Mark local as initialized.
a9a06e0b 8661 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8662
b4716021
PE
8663 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8664
811e9bac 8665 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8666 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8667 (x_own_selection, Fx_disown_selection_internal): Rename locals
8668 to avoid shadowing.
8669 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8670
7e3ab302
PE
8671 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8672 so that the caller can use some name other than gcpro1.
8673 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8674 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8675 (Fx_backspace_delete_keys_p):
8676 Use them to avoid shadowing, and rename vars to avoid shadowing.
8677 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8678 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8679 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8680 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8681 Remove unused locals.
7e3ab302
PE
8682 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8683 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8684 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8685 macros.
f78faa98 8686
e2b13473
PE
8687 * xterm.h (x_mouse_leave): New decl.
8688
77f23912
PE
8689 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8690 Remove unused functions.
cdf4ba58
PE
8691 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8692 (x_calc_absolute_position): Now static.
7411c686 8693 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8694 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8695 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8696 unless they are used.
38d0b34a
PE
8697 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8698 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8699 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8700 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8701 (x_error_catcher, x_connection_closed, x_error_handler):
8702 (x_error_quitter, xembed_send_message, x_iconify_frame):
8703 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8704 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8705 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8706
44f230aa
SM
8707 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8708 Rename or move locals to avoid shadowing.
6b463e58 8709 (tty_defined_color, merge_face_heights): Now static.
5967d051 8710 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8711 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8712 does not deduce is never used uninitialized.
73719eba
PE
8713 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8714 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8715
426994c3 8716 * terminal.c (store_terminal_param): Now static.
5489860b 8717
032f1620 8718 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8719 (set_frame_menubar): Remove unused local.
d4323972 8720 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8721 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8722 since they might point to immutable storage.
281585b0
PE
8723 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8724 since it's unused otherwise.
032f1620 8725
367c19e5 8726 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8727 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8728 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8729 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8730 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8731 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8732 does not deduce are never used uninitialized.
70739cbe 8733
07b48fa9
PE
8734 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8735
8868a238 8736 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8737 * window.c (window_loop, size_window):
8738 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8739
7e5cf297 8740 * window.c (display_buffer): Now static.
d6550a9f
PE
8741 (size_window): Mark variables that gcc -Wuninitialized
8742 does not deduce are never used uninitialized.
a586633d
PE
8743 * window.h (check_all_windows): New decl, to forestall
8744 gcc -Wmissing-prototypes diagnostic.
5b555da1 8745 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8746
f6095868
PE
8747 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8748 shadowing.
8749 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8750 Include <limits.h>.
8751 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8752 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8753 (load_charset_map): Mark variables that gcc -Wuninitialized
8754 does not deduce are never used uninitialized.
53df7c11 8755 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8756
f38b440c
PE
8757 * coding.c (coding_set_source, coding_set_destination):
8758 Use "else { /* comment */ }" rather than "else /* comment */;"
8759 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8760 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8761 a block, when the outer 'i' will do.
8762 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8763 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8764 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8765 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8766 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8767 Rename locals to avoid shadowing.
8768 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8769 * coding.c (emacs_mule_char, encode_invocation_designation):
8770 Now static, since they're not used elsewhere.
413bb2db 8771 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8772 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8773 (decode_coding_emacs_mule): Mark variables that gcc
8774 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8775 (detect_coding_iso_2022): Initialize a local variable that might
8776 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8777 this initialization is needed. (Bug#8211)
5f58e762
PE
8778 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8779 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8780 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8781 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8782 Remove unused macros.
f38b440c 8783
232b38b9 8784 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8785 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8786 * character.c (string_count_byte8): Likewise.
232b38b9 8787
fb90da1b
PE
8788 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8789 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8790
fb93dbc2
PE
8791 * chartab.c (copy_sub_char_table): Now static, since it's not used
8792 elsewhere.
5c156ace
PE
8793 (sub_char_table_ref_and_range, char_table_ref_and_range):
8794 Rename locals to avoid shadowing.
bbcd0949 8795 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8796
7d3b3862 8797 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8798 (BIDI_BOB): Remove unused macro.
7d3b3862 8799
6be7d3da
PE
8800 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8801 deduce are never used uninitialized.
c2ed9c8b 8802 * term.c (encode_terminal_code): Likewise.
6be7d3da 8803
75f8807f 8804 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8805
50938595
PE
8806 * tparam.h: New file.
8807 * term.c, tparam.h: Include it.
8808 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8809 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8810 Move these decls to tparam.h, and make them agree with what
8811 is actually in tparam.c. The previous trick of using incompatible
8812 decls in different modules does not conform to the C standard.
8813 All callers of tparam changed to use tparam's actual API.
8814 * tparam.c (tparam1, tparam, tgoto):
8815 Use const pointers where appropriate.
8816
fbceeba2
PE
8817 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8818 * cm.h (struct cm): Likewise.
8819 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8820 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8821 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8822 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8823 (turn_on_face, init_tty): Likewise.
8824 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8825
7f3f1250
PE
8826 * term.c (term_mouse_position): Rename local to avoid shadowing.
8827
e6ca6543
PE
8828 * alloc.c (mark_ttys): Move decl from here ...
8829 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8830
c40f8d15
AS
88312011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8832
8833 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8834
cfe0661d
JB
88352011-03-09 Juanma Barranquero <lekktu@gmail.com>
8836
8837 * search.c (compile_pattern_1): Remove argument regp, unused since
8838 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8839 (compile_pattern): Don't pass it.
8840
0afb4571
J
88412011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8842
8843 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8844 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8845 for ! HAVE_GTK3.
8846 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8847
8848 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8849
8850 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8851 gdk_window_get_screen, gdk_window_get_geometry,
8852 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8853 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8854 (xg_get_pixbuf_from_pixmap): New function.
8855 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8856 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8857 Call xg_get_pixbuf_from_pixmap instead of
8858 gdk_pixbuf_get_from_drawable.
8859 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8860 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8861 (xg_check_special_colors): Use GtkStyleContext and its functions
8862 for HAVE_GTK3.
8863 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8864 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8865 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8866 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8867 Call gtk_widget_get_preferred_size.
0afb4571
J
8868 (xg_frame_resized): gdk_window_get_geometry only takes 5
8869 parameters.
44f230aa
SM
8870 (xg_win_to_widget, xg_event_is_for_menubar):
8871 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8872 (xg_set_widget_bg): New function.
8873 (delete_cb): New function.
895009e1 8874 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8875 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8876 (xg_set_background_color): Call xg_set_widget_bg.
8877 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8878 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8879 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8880 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8881 if ! HAVE_GTK3.
8882 (update_frame_tool_bar): Call gtk_widget_hide.
8883 (xg_initialize): Use GDK_KEY_g.
8884
8885 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8886 if ! HAVE_GTK3
8887 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8888
8889 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8890 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8891 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8892
1c2cc4ef
JB
88932011-03-08 Juanma Barranquero <lekktu@gmail.com>
8894
8895 * w32xfns.c (select_palette): Check success of RealizePalette against
8896 GDI_ERROR, not zero.
8897
33383987 8898See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8899
8900;; Local Variables:
8901;; coding: utf-8
aac0c6e3
MR
8902;; End:
8903
33383987 8904 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8905
8906 This file is part of GNU Emacs.
8907
8908 GNU Emacs is free software: you can redistribute it and/or modify
8909 it under the terms of the GNU General Public License as published by
8910 the Free Software Foundation, either version 3 of the License, or
8911 (at your option) any later version.
8912
8913 GNU Emacs is distributed in the hope that it will be useful,
8914 but WITHOUT ANY WARRANTY; without even the implied warranty of
8915 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8916 GNU General Public License for more details.
8917
8918 You should have received a copy of the GNU General Public License
8919 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.