Mark display-buffer-function as obsolete.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
39a57ad0
PE
12012-09-15 Paul Eggert <eggert@cs.ucla.edu>
2
3 Port _setjmp fix to POSIXish hosts as well as Microsoft.
4 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
5 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
6 the Microsoft problem in a different way, by altering ../nt/config.nt.
7
7105c8cb
EZ
82012-09-15 Eli Zaretskii <eliz@gnu.org>
9
10 * w32xfns.c:
11 * w32uniscribe.c:
12 * w32term.c:
13 * w32select.c:
14 * w32reg.c:
15 * w32proc.c:
16 * w32menu.c:
17 * w32inevt.c:
18 * w32heap.c:
19 * w32font.c:
20 * w32fns.c:
21 * w32console.c:
22 * w32.c:
23 * w16select.c: Remove inclusion of setjmp.h, as it is now included
24 by lisp.h. This completes removal of setjmp.h inclusion
25 erroneously announced in the previous commit. (Bug#12446)
26
27 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
28 more accurate.
29
30 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
31 not defined as a macro. The latter happens on MS-Windows.
32 (Bug#12446)
33
0328b6de
PE
342012-09-15 Paul Eggert <eggert@cs.ucla.edu>
35
36 Port better to POSIX hosts lacking _setjmp (Bug#12446).
37 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 38 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
39 only reason for the instance was because "lisp.h" was included.
40 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
41 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
42 and _longjmp with the new symbols. Emacs already uses _setjmp if
43 available, so this change affects only POSIXish hosts that have
44 sigsetjmp but not _setjmp, such as some versions of Solaris and
45 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
46 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
47 (png_load_body) [HAVE_PNG]:
48 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
49 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
50 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
51 since PNG requires jmp_buf. This is the only exception to the
52 general rule that we now use sys_setjmp and sys_longjmp.
53 This exception is OK since this code does not change the signal
54 mask or longjmp out of a signal handler.
55
2af03429
PE
562012-09-14 Paul Eggert <eggert@cs.ucla.edu>
57
58 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
59 Include "syssignal.h", for 'main_thread'.
60
2f294edf
DA
612012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
62
63 Avoid out-of-range marker position (Bug#12426).
64 * insdel.c (replace_range, replace_range_2): Adjust
65 markers before overlays, as suggested by comments.
66 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
67 Remove redundant check before calling offset_intervals.
68
6b533e9c
MR
692012-09-14 Martin Rudalics <rudalics@gmx.at>
70
71 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
72 current buffer (Bug#12387).
73
2a7931e3
JB
742012-09-14 Juanma Barranquero <lekktu@gmail.com>
75
76 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
77
c18e885b
PE
782012-09-13 Paul Eggert <eggert@cs.ucla.edu>
79
80 Use a more backwards-compatible timer format (Bug#12430).
81 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
82 vector element, not from the 4th, since PSECS is now at the end.
83 (Fcurrent_idle_time): Doc fix.
84
d59a1afb
DA
852012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Function to mark objects and remove killed buffers at once.
88 * alloc.c (discard_killed_buffers): Rename to ...
89 (mark_discard_killed buffers) ... new name. Add marking
90 of remaining objects. Fix comment. Adjust users.
91 (mark_object): Do not touch frame buffer lists here.
92 * frame.c (delete_frame): Reset frame buffer lists here.
93
5f0cb45a
PE
942012-09-13 Paul Eggert <eggert@cs.ucla.edu>
95
8ea47e3a
PE
96 Better workaround for GNOME bug when --enable-gcc-warnings.
97 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
98 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
99 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
100
4a4bbad2
PE
101 Simplify SIGIO usage (Bug#12408).
102 The code that dealt with SIGIO was crufty and confusing, e.g., it
103 played tricks like "#undef SIGIO" but these tricks were not used
104 consistently. Simplify mostly by not #undeffing standard symbols,
105 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
106 or not as we please) rather than "defined SIGIO" (standard symbol
107 that we probably shouldn't #undef).
108 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
109 Modules that need it can include it.
110 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
111 * dispextern.h (ignore_sigio): New decl.
112 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
113 unconditionally, since it's now a no-op if !USABLE_SIGIO.
114 * emacs.c (shut_down_emacs):
115 * keyboard.c (kbd_buffer_store_event_hold):
116 Use ignore_sigio rather than invoking 'signal' directly.
117 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
118 for FIONREAD.
119 (FIONREAD, SIGIO): Do not #undef.
120 (tty_read_avail_input): Use #error rather than a syntax error.
121 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
122 for I_PIPE, used by SETUP_SLAVE_PTY.
123 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
124 * sysdep.c (croak): Remove; no longer needed. This bit of
125 temporary code, with Fred N. Fish's comment that it's temporary,
126 has been in Emacs since at least 1992!
127 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
128 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
129 * syssignal.h (croak): Remove decl.
130 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
131 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
132 now that we're termios-only.
133 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
134 * term.c (dissociate_if_controlling_tty): Use #error rather than
135 a run-time error.
136
5f0cb45a
PE
137 Work around GCC and GNOME bugs when --enable-gcc-warnings.
138 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
139 to work around GNOME bug 683906.
140 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
141 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
142 This works around GCC bug 54561.
143
40bce90b
PE
1442012-09-12 Paul Eggert <eggert@cs.ucla.edu>
145
146 More fixes for 'volatile' and setjmp/longjmp.
147 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
148 * image.c (struct png_load_context) [HAVE_PNG]: New type.
149 (png_load_body) [HAVE_PNG]:
150 (jpeg_load_body) [HAVE_JPEG]:
151 New function, with most of the old parent function's body.
152 (png_load) [HAVE_PNG]:
153 (jpeg_load) [HAVE_JPEG]:
154 Invoke the new function, to avoid longjmp munging our locals.
155 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
156 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
157 longjmp is passed 2, as the C standard doesn't guarantee this.
158 Instead, store the failure code into mgr->failure_code.
159
bfeae2cf
SM
1602012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
161
162 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
163 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
164 (syms_of_keyboard): Remove support for unread-command-char.
165
8099e36b
EZ
1662012-09-12 Eli Zaretskii <eliz@gnu.org>
167
168 * w32proc.c (sys_kill): If PID is our process ID and the signal is
169 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
170 violation. (Bug#12426)
171
92547ff9
PE
1722012-09-12 Paul Eggert <eggert@cs.ucla.edu>
173
174 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
175
45b82ad0
SM
1762012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * eval.c: Add `inhibit-debugger'.
179 (Qinhibit_debugger): New symbol.
180 (call_debugger): Bind it instead of Qdebug_on_error.
181 (maybe_call_debugger): Test Vinhibit_debugger.
182 (syms_of_eval): Define inhibit-debugger.
183 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
184 (syms_of_xdisp): Remove inhibit-debug-on-message.
185
5779a1dc
PE
1862012-09-11 Paul Eggert <eggert@cs.ucla.edu>
187
50f2e553
PE
188 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
189 If a nonvolatile local variable is written before a _longjmp to
190 the frame containing the variable, and is read after the _longjmp,
191 the value read is indeterminate. Some local variables of type
192 'struct handler' and 'struct catchtag' are used in this way, so
193 mark each of their slots as volatile if the slot can be set before
194 _longjmp and read afterwards.
195 * lisp.h (struct handler): var and chosen_clause are now volatile.
196 (struct catchtag): val, next, and pdlcount are now volatile.
197
ae1d87e2
PE
198 * bidi.c (bidi_push_it, bidi_pop_it):
199 * fns.c (copy_hash_table):
200 * image.c (define_image_type):
201 * keyboard.c (kbd_buffer_store_event_hold):
202 * process.c (Fprocess_send_eof):
203 * xfaces.c (x_create_gc) [HAVE_NS]:
204 * xgselect.c (xg_select):
205 Prefer assignment to memcpy when either will do.
206
5779a1dc
PE
207 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
208 Use pointer-to-a-pointer to simplify and avoid a NILP check each
209 time an item is removed. No need to mark this function 'inline';
210 the compiler knows better than we do.
211
c4c9756b
JD
2122012-09-11 Jan Djärv <jan.h.d@swipnet.se>
213
214 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
215 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
216 to change_frame_size (Bug#12388).
217 (windowDidResize:): Pass YES to updateFrameSize.
218
219 * nsterm.h: Add delay parameter to updateFrameSize.
220
d73e321c
DA
2212012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
222
223 Discard killed buffers from deleted window and frame objects.
224 This reduces an amount of references to killed buffers and
225 helps GC to reclaim them faster.
226 * alloc.c (discard_killed_buffers): New function.
227 (mark_object): Use it for deleted windows and frames.
228 (mark_object): If symbol's value is set up for a killed buffer
229 or deleted frame, restore it's global binding.
230 * data.c (swap_in_global_binding): Add GC notice.
231 (swap_in_symval_forwarding): Use convenient set_blv_where.
232 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
233 * window.h: ... to here.
234
e578f381
DA
2352012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
236
237 Convenient macro to check whether the buffer is live.
238 * buffer.h (BUFFER_LIVE_P): New macro.
239 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
240 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
241
3057e615
YM
2422012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
243
244 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
245 composition cases (Bug#12364).
246
247 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
248 overhang of succeeding glyphs overlapping box cursor.
249
250 * w32term.c (x_draw_glyph_string): Likewise.
251
6fda35f2
PE
2522012-09-11 Paul Eggert <eggert@cs.ucla.edu>
253
c990426a
PE
254 Simplify, document, and port floating-point (Bug#12381).
255 The porting part of this patch fixes bugs on non-IEEE platforms
256 with frexp, ldexp, logb.
257 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
258 Now static.
259 * floatfns.c: Simplify discussion of functions that Emacs doesn't
260 support, by removing commented-out code and briefly listing the
261 C89 functions excluded. The commented-out stuff was confusing
262 maintenance, e.g., we thought we needed cbrt but it was commented out.
263 (logb): Remove decl; no longer needed.
264 (isfinite): New macro, if not already supplied.
265 (isnan): Don't replace any existing macro.
266 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
267 are present on all C89 platforms.
268 (Ffrexp): Do not special-case zero, as frexp does the right thing
269 for that case.
270 (Flogb): Do not use logb, as it doesn't have the desired meaning
271 on hosts that use non-base-2 floating point. Instead, stick with
272 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
273 frexp, to avoid getting an unspecified result.
274
6fda35f2
PE
275 * xdisp.c (Qinhibit_debug_on_message): Now static.
276
16130a58
JD
2772012-09-10 Jan Djärv <jan.h.d@swipnet.se>
278
279 * nsterm.m (ns_update_begin): Set clip path to whole view by using
280 NSBezierPath (Bug#12131).
281
d105a573
CY
2822012-09-10 Chong Yidong <cyd@gnu.org>
283
284 * fns.c (Fdelq, Fdelete): Doc fix.
285
ff55dfe8
PE
2862012-09-10 Paul Eggert <eggert@cs.ucla.edu>
287
288 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
289 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
290
e7032e7c
SM
2912012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
292
293 * lisp.h (make_lisp_ptr): New macro to replace XSET.
294 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
295 Use it.
296
e9957956
EZ
2972012-09-09 Eli Zaretskii <eliz@gnu.org>
298
aba05ce9
EZ
299 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
300 left fringe if the window has a left margin. This avoids leaving
301 traces of the cursor because its leftmost pixel is not drawn over.
302
e9957956
EZ
303 * dispnew.c (update_window_line): When the left margin area of a
304 screen line is updated, set the redraw_fringe_bitmaps_p flag of
305 that screen line. (Bug#12277)
306
f6196b87
PE
3072012-09-09 Paul Eggert <eggert@cs.ucla.edu>
308
309 Assume C89 or later for math functions (Bug#12381).
310 This simplifies the code, and makes it a bit smaller and faster,
311 and (most important) makes it easier to clean up signal handling
312 since we can stop worring about floating-point exceptions in
313 library code. That was a problem before C89, but the problem
314 went away many years ago on all practical Emacs targets.
315 * data.c, image.c, lread.c, print.c:
316 Don't include <math.h>; no longer needed.
317 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
318 might be autoconfigured, as that never happens.
319 * data.c (fmod):
320 * doprnt.c (DBL_MAX_10_EXP):
321 * print.c (DBL_DIG):
322 Remove. C89 or later always defines these.
323 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
324 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
325 (arith_error, domain_error, domain_error2):
326 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
327 no longer needed -- we simply return what C returns. All uses removed.
328 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
329 the wrapped code.
330 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
331 Remove. All uses expanded, as these macros are no longer used
332 more than once and are now more trouble than they're worth.
333 (Ftan): Use tan, not sin / cos.
334 (Flogb): Assume C89 frexp.
335 (fmod_float): Assume C89 fmod.
336 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
337 (init_floatfns): Remove. All uses removed.
338
9d7f1863
JD
3392012-09-08 Jan Djärv <jan.h.d@swipnet.se>
340
341 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
342 compositeToPoint for OSX < 10.6 (Bug#12390).
343
eabf0404
PE
3442012-09-08 Paul Eggert <eggert@cs.ucla.edu>
345
346 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
347 This produces more-accurate results.
348
0b3b1d23
JD
3492012-09-08 Jan Djärv <jan.h.d@swipnet.se>
350
351 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
352 changes (Bug#12088).
353
6dcef6ec
CY
3542012-09-08 Chong Yidong <cyd@gnu.org>
355
356 * syntax.c (Fstring_to_syntax): Doc fix.
357
aa7d57c5
JD
3582012-09-08 Jan Djärv <jan.h.d@swipnet.se>
359
360 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
361 in the internal border.
362 (x_set_window_size): Remove static variables and their usage.
363 (ns_redraw_scroll_bars): Fix NSTRACE arg.
364 (ns_after_update_window_line, ns_draw_fringe_bitmap): Remove
365 fringe/internal border adjustment (Bug#11052).
366 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
367 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
368 (ns_fix_rect_ibw): Remove.
369 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
370 (ns_dumpglyphs_box_or_relief): Ditto.
371 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
372 adjustment.
373 (ns_dumpglyphs_image): Ditto.
fc0c31f8 374 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
375 border adjustment.
376 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
377 their usage. Add fringe_extended_p and its use as in other terms.
378 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
379 scroll bar was removed.
380 (updateFrameSize): New function.
381 (windowDidResize): Move code to updateFrameSize and call it.
382
383 * nsterm.h (EmacsView): Add updateFrameSize.
384
1a5432bc
CY
3852012-09-07 Chong Yidong <cyd@gnu.org>
386
b4f5313e
CY
387 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
388
1a5432bc
CY
389 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
390
1a4f1e9b
PE
3912012-09-07 Paul Eggert <eggert@cs.ucla.edu>
392
393 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
394 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
395 Problem introduced when merging patches. Noted by Eli Zaretskii in
396 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
397 * floatfns.c: Comment fix.
398 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
399 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
400 and anyway the declaration is harmless even if SIGDANGER is not defined.
401 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
402 defined BROKEN_FIONREAD). systty.h formerly did this, but other
403 source files not surprisingly expected syssignal.h to define, or
404 not define, SIGIO, and it's cleaner to do it that way, for consistency.
405 Include <sys/ioctl.h>, for FIONREAD.
406 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
407 This eliminates a problem whereby other files mysteriously had
408 to include "syssignal.h" before including "systty.h" if they
409 wanted to use "#ifdef SIGIO".
410
bc8000ff
EZ
4112012-09-07 Eli Zaretskii <eliz@gnu.org>
412
3e6d6928
EZ
413 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
414
415 * w32.c (sigemptyset): Empty the set.
416 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
417
bc8000ff
EZ
418 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
419
b4fa72f2
DA
4202012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
421
422 * alloc.c (mark_buffer): Revert unsafe marking optimization.
423 (mark_object): Likewise for frame objects.
424
30730c93
PE
4252012-09-07 Paul Eggert <eggert@cs.ucla.edu>
426
427 * syssignal.h (handle_on_main_thread): Always declare,
428 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
429 This ports to platforms without HAVE_PTHREAD.
430
2fe28299
PE
4312012-09-06 Paul Eggert <eggert@cs.ucla.edu>
432
433 Signal-handler cleanup (Bug#12327).
434 Emacs's signal handlers were written in the old 4.2BSD style with
435 sigblock and sigmask and so forth, and this led to some
436 inefficiencies and confusion. Rewrite these to use
437 pthread_sigmask etc. without copying signal sets around. Also,
438 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
439 'signal', and instead use functions that do not attempt to take
440 over the system name space. This patch causes Emacs's text
441 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
442 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
443 Do not include <signal.h> or "syssignal.h", as these
444 modules do not use signals.
445 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
446 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
447 Do not include <signal.h>, as "syssignal.h" does that for us now.
448 * atimer.c (sigmask_atimers): New function.
449 (block_atimers, unblock_atimers): New functions,
450 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
451 All uses replaced.
452 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
453 no longer needed here.
454 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 455 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
456 * sysdep.c (struct save_signal): New member 'action', replacing
457 old member 'handler'.
458 (save_signal_handlers, restore_signal_handlers):
459 Use sigaction instead of 'signal' to save and restore.
460 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
461 New function. All users of 'signal' modified to use set_sighandler
462 if they're writeonly, and to use sys_signal if they're read+write.
463 (emacs_sigaction_init, forwarded_signal): New functions.
464 (sys_signal): Remove. All uses replaced by calls to sigaction
465 and emacs_sigaction_init, or by direct calls to 'signal'.
466 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
467 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
468 all uses replaced by pthread_sigmask etc. calls.
469 * syssignal.h: Include <signal.h>.
470 (emacs_sigaction_init, forwarded_signal): New decls.
471 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
472 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
473 (sigmask, sys_sigmask): Remove; no longer needed.
474 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
475 (sigblock, sigunblock, sigfree):
476 (sigsetmask) [!defined sigsetmask]:
477 Remove. All uses replaced by pthread_sigmask.
478 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
479 no longer need to be replaced, and its typical old uses
480 are now done via emacs_sigaction_init and sigaction.
481 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
482 (sys_sigdel): Remove; unused.
483 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
484
0216c128
EZ
4852012-09-06 Eli Zaretskii <eliz@gnu.org>
486
487 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
488 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
489
c752cfa9
DA
4902012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
491
492 Explicitly mark buffer_defaults and buffer_local_symbols.
493 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
494 mark_local_symbols here.
495 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
496 since special buffers aren't marked here any more.
497 (allocate_buffer): Chain new buffer with all_buffers here...
498 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
499 not here.
500 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
501 (syms_of_buffer): Remove staticpro of the above.
502 (init_buffer_once): Set names for buffer_defaults and
503 buffer_local_symbols.
504
a864ef14
PE
5052012-09-06 Paul Eggert <eggert@cs.ucla.edu>
506
507 Use bool for booleans in font-related modules.
508 * font.c (font_intern_prop, font_style_to_value)
509 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
510 (generate_otf_features, font_check_otf_features, font_check_otf)
511 (font_match_p, font_list_entities, font_at):
512 * fontset.c (fontset_id_valid_p, reorder_font_vector
513 (fontset_find_font, Fset_fontset_font)
514 (face_suitable_for_char_p) [0]:
515 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
516 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
517 (m17n_flt_initialized, ftfont_shape_by_flt):
518 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
519 * nsfont.m (nsfont_draw):
520 * w32font.c (w32font_draw):
521 * w32term.c (x_draw_glyphless_glyph_string_foreground):
522 Use bool for booleans.
523 * font.h: Adjust to above API changes.
524 (struct font, struct font_driver, struct font_driver_list):
525 Use bool for booleans.
526 (struct font): Remove useless member encoding_type.
527 All users removed.
528 * fontset.c, xftfont.c: Omit unnecessary static decls.
529
0699fc18
DA
5302012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
531
532 * alloc.c (mark_object): Revert window marking code
533 since it's unsafe for the Fset_window_configuration.
534
20ef56db
PE
5352012-09-05 Paul Eggert <eggert@cs.ucla.edu>
536
2fe28299 537 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
538 Be more systematic about preserving errno whenever a signal
539 handler returns, even if it's not in the main thread. Do this by
540 renaming signal handlers to distinguish between signal delivery
541 and signal handling. All uses changed.
542 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
543 * data.c (deliver_arith_signal): Rename from arith_error.
544 * dispnew.c (deliver_window_change_signal): Rename from
545 window_change_signal.
546 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
547 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
548 * keyboard.c (deliver_input_available_signal): Rename from
549 input_available_signal.
550 (deliver_user_signal): Rename from handle_user_signal.
551 (deliver_interrupt_signal): Rename from interrupt_signal.
552 * process.c (deliver_pipe_signal): Rename from send_process_trap.
553 (deliver_child_signal): Rename from sigchld_handler.
554 * atimer.c (handle_alarm_signal):
555 * data.c (handle_arith_signal):
556 * dispnew.c (handle_window_change_signal):
557 * emacs.c (handle_fatal_signal, handle_danger_signal):
558 * keyboard.c (handle_input_available_signal):
559 * keyboard.c (handle_user_signal, handle_interrupt_signal):
560 * process.c (handle_pipe_signal, handle_child_signal):
561 New functions, with the actual signal-handling code taken from the
562 original respective signal handlers, sans the sporadic attempts to
563 preserve errno, since that's now done by handle_on_main_thread.
564 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
565 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
566 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
567 Move to sysdep.c.
568 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
569 Move initialization of main_thread to sysdep.c's init_signals.
570 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
571 our usage, and simplifies the mainline code.
572 (record_child_status_change): New static function, as a helper
573 for handle_child_signal, and with most of the old child handler's
574 contents.
575 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
576 (handle_child_signal): Use the above.
577 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
578 Moved here from emacs.c.
579 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
580 code moved here from emacs.c's main function.
581 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
582 replacing the old SIGNAL_THREAD_CHECK. All uses changed. This
583 lets callers save and restore errno properly.
584
e3ccf108
DA
5852012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
586
587 Remove redundant or unused things here and there.
588 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
589 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
590 * editfns.c (Fcompare_buffer_substrings): Likewise.
591 * frame.h (struct terminal, struct font_driver_list):
592 Remove redundant declarations.
593 * window.h (Qleft, Qright): Likewise.
594
697e1e39
DA
5952012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
596
597 Do not mark objects from deleted buffers, windows and frames.
598 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
599 (mark_object): Likewise for windows and frames.
600
c1ca42ca
DA
6012012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
602
603 * alloc.c (valid_lisp_object_p): Treat killed buffers,
604 buffer_defaults and buffer_local_symbols as valid objects.
605 Return special value to denote them.
606
014d93be
PE
6072012-09-05 Paul Eggert <eggert@cs.ucla.edu>
608
f75d7a91
PE
609 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
610 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
611 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
612 (file_name_absolute_p, Fsubstitute_in_file_name):
613 (check_executable, check_writable, Ffile_accessible_directory_p)
614 (Fset_file_selinux_context, Fdefault_file_modes)
615 (Finsert_file_contents, choose_write_coding_system)
616 (Fwrite_region, build_annotations, a_write, e_write)
617 (Fdo_auto_save):
618 * filelock.c (boot_time_initialized, get_boot_time)
619 (get_boot_time_1, lock_file_1, within_one_second):
620 * floatfns.c (in_float):
621 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
622 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
623 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
624 * lisp.h (struct Lisp_Hash_Table.cmpfn):
625 * window.c (compare_window_configurations):
626 Use bool for booleans.
627 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
628 (Fdefault_file_modes): Now mode_t, not int, for modes.
629 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
630 (internal_delete_file): Now returns void, not a (boolean) int,
631 since nobody was looking at the return value.
632 * lisp.h, window.h: Adjust to above API changes.
633
014d93be
PE
634 * xdisp.c (set_message): Simplify and reindent last change.
635
776f29e1
JB
6362012-09-05 Juanma Barranquero <lekktu@gmail.com>
637
638 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
639
7f7e0167
LI
6402012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
641
642 * eval.c (call_debugger): Make the function non-static so that we
643 can call it from set_message.
644
645 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
646 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
647
cf29dd84
PE
6482012-09-04 Paul Eggert <eggert@cs.ucla.edu>
649
650 Give more-useful info on a fatal error (Bug#12328).
651 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
652 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
653 of doing the work ourselves.
654 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
655 do most of the work.
656 (fatal_error_backtrace): New function, taken from the guts
657 of the old fatal_error_signal, but with a new option to output
658 a backtrace.
659 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
660 info about the signal than just its number.
661 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
662 * sysdep.c: Include <execinfo.h>
663 (emacs_backtrace): New function, taken partly from the previous
664 code of the 'die' function.
665 (emacs_abort): Call fatal_error_backtrace rather than abort.
666
972debf2
SM
6672012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
668
669 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
670 eager (load-time) macro-expansion.
671 * lisp.mk (lisp): Add macroexp.
672
1088b922
PE
6732012-09-04 Paul Eggert <eggert@cs.ucla.edu>
674
675 Simplify redefinition of 'abort' (Bug#12316).
676 Do not try to redefine the 'abort' function. Instead, redo
677 the code so that it calls 'emacs_abort' rather than 'abort'.
678 This removes the need for the NO_ABORT configure-time macro
679 and makes it easier to change the abort code to do a backtrace.
680 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
681 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
682 Remove; sysdep.c's emacs_abort now takes its place.
683 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
684 'abort' changed to use 'emacs_abort'.
685 * msdos.c (dos_abort) [defined abort]: Remove; not used.
686 (abort) [!defined abort]: Rename to ...
687 (emacs_abort): ... new name.
688 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
689 the place of the old 'abort' in emacs.c.
690 * w32.c, w32fns.c (abort): Do not #undef.
691 * w32.c (emacs_abort): Rename from w32_abort.
692
30934d33
EZ
6932012-09-04 Eli Zaretskii <eliz@gnu.org>
694
695 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
696 offsets[j].dv, since the y axis of the screen coordinates points
697 down, while the y axis of the font definition coordinates points
698 up. This fixes display of Arabic diacritics such as KASRA and
699 KASRATAN. (Bug#11860)
700
af26b72c
PE
7012012-09-04 Paul Eggert <eggert@cs.ucla.edu>
702
703 Be more systematic about _setjmp vs setjmp.
704 * alloc.c (test_setjmp, mark_stack):
705 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
706 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
707 (png_load, my_error_exit, jpeg_load):
708 * process.c (send_process_trap, send_process):
709 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
710 The underscored versions are up to 30x faster on some hosts.
711 Formerly, the code used setjmp+longjmp sometimes and
712 _setjmp+_longjmp at other times, with no particular reason to
713 prefer setjmp+longjmp.
714
26d4541d
PE
7152012-09-03 Paul Eggert <eggert@cs.ucla.edu>
716
d42f4f0f 717 Fix minor problem found by static checking.
26d4541d 718 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 719
c5e28e39
MR
7202012-09-03 Martin Rudalics <rudalics@gmx.at>
721
722 * buffer.c (Fdelete_all_overlays): New function.
723
3eab3ca9
CY
7242012-09-03 Chong Yidong <cyd@gnu.org>
725
726 * gtkutil.c: Add extern decl for Qxft.
727
c04889f8
PE
7282012-09-02 Paul Eggert <eggert@cs.ucla.edu>
729
1882aa38
PE
730 * emacs.c, eval.c: Use bool for boolean.
731 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
732 (malloc_using_checking) [DOUG_LEA_MALLOC]:
733 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
734 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
735 (main, decode_env_path, Fdaemon_initialized):
736 * eval.c (call_debugger, Finteractive_p, interactive_p):
737 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
738 (maybe_call_debugger, Fbacktrace):
739 * process.c (read_process_output, exec_sentinel):
740 Use bool for booleans.
741 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
742 All callers changed.
743 * eval.c (interactive_p): Omit always-true boolean argument
744 EXCLUDE_SUBRS_P. All callers changed.
745 * dispextern.h, lisp.h: Reflect above API changes.
746 * firstfile.c (dummy): Use the address of 'main', whose signature
747 won't change, instead of the address of 'initialize', whose
748 signature just changed from int to bool.
749 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
750 * msdos.c (fatal_error_in_progress): ... from here.
751 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
752 of incrementing it.
753 (redisplay_internal, unwind_redisplay): Simply clear
754 REDISPLAYING_P when unwinding, instead of saving its previous,
755 always-false value and then restoring it.
756
a411ac43
PE
757 Clean up some extern decls.
758 Mostly, this hoists extern decls out of .c files and into .h files.
759 That way, we're more likely to catch errors if the interfaces change.
760 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
761 declare xg_mark_data.
762 * dispextern.h (x_frame_parm_handlers):
763 * font.h (Qxft):
764 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
765 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
766 (Qultra_bold, Qoblique, Qitalic):
767 Move extern decl here from .c file.
768 * alloc.c (xg_mark_data) [USE_GTK]:
769 * doc.c (Qclosure):
770 * eval.c (Qlexical_binding):
771 * fns.c (time) [!HAVE_UNISTD_H]:
772 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
773 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
774 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
775 * lread.c (Qinternal_interpreter_environment):
776 * minibuf.c (Qbuffer):
777 * process.c (QCfamily, QCfilter):
778 * widget.c (free_frame_faces):
779 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
780 * xfont.c (x_clear_errors):
781 * xterm.c (x_frame_parm_handlers):
782 Remove now-redundant extern decls.
783 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
784 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
785 Now static.
786 * xfaces.c: Remove unnecessary static decls.
787 * xterm.c (updating_frame): Remove decl of nonexistent object.
788
c04889f8
PE
789 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
790 when building globals.h, as the objects that are not built on
791 this host are not needed to compile C files on this host.
792
8b339673
JD
7932012-09-02 Jan Djärv <jan.h.d@swipnet.se>
794
795 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
796
797 * frame.h: Add missing prototype for x_wm_set_size_hint.
798
a08d4ba7
PE
7992012-09-02 Paul Eggert <eggert@cs.ucla.edu>
800
801 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
802 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
803 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
804 (Fsubstitute_command_keys):
805 * editfns.c (region_limit, find_field, Fconstrain_to_field)
806 (save_excursion_save, save_excursion_restore)
807 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
808 (format_time_string, general_insert_function)
809 (make_buffer_string, make_buffer_string_both)
810 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
811 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
812 (copy_text, insert_1, insert_1_both, insert_from_string)
813 (insert_from_string_before_markers, insert_from_string_1)
814 (insert_from_buffer, insert_from_buffer_1, replace_range)
815 (replace_range_2, del_range_1, del_range_byte, del_range_both)
816 (del_range_2, modify_region):
817 * intervals.c (intervals_equal, balance_possible_root_interval)
818 (adjust_intervals_for_insertion, merge_properties_sticky)
819 (graft_intervals_into_buffer, lookup_char_property)
820 (adjust_for_invis_intang, set_point_both)
821 (get_property_and_range, compare_string_intervals)
822 (set_intervals_multibyte_1, set_intervals_multibyte):
823 * keyboard.c (decode_timer):
824 Use bool for boolean.
825 * intervals.h, lisp.h, systime.h: Reflect above API changes.
826 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
827
48c948de
CY
8282012-09-02 Chong Yidong <cyd@gnu.org>
829
830 * keymap.c (push_key_description): Print M-TAB as C-M-i
831 (Bug#11758).
832
6c49a40b
JB
8332012-09-02 Juanma Barranquero <lekktu@gmail.com>
834
835 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
836 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
837 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
838 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
839 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
840 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
841 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
842
4dfbd238
EZ
8432012-09-01 Eli Zaretskii <eliz@gnu.org>
844
7e510e28
EZ
845 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
846 more than one grapheme cluster passed to the shaper: compute the
847 offset adjustment values separately for each cluster. (Bug#11860)
848
4dfbd238
EZ
849 * image.c: Restore mistakenly removed inclusion of w32.h. Without
850 it, GCC doesn't see prototypes of w32_delayed_load, and complains
851 about implicit conversions from integer to pointer.
852
86571ae0
DC
8532012-09-01 Daniel Colascione <dancol@dancol.org>
854
855 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
856 system used too early.
857
0e23ef9d
PE
8582012-09-01 Paul Eggert <eggert@cs.ucla.edu>
859
860 Better seed support for (random).
861 * emacs.c (main): Call init_random.
862 * fns.c (Frandom): Set the seed from a string argument, if given.
863 Remove long-obsolete Gentzel cruft.
864 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
865 (init_random): New function.
866
17a2cbbd
DC
8672012-09-01 Daniel Colascione <dancol@dancol.org>
868
869 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
870 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
871 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
872 x_wm_set_size_hint, x_query_colors, x_real_positions,
873 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
874 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
875 all of which have been moved to common code.
876
877 * xfaces.c: Include TERM_HEADER instead of listing all possible
878 window-system headers.
879
880 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
881 to match header.
882
883 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
884 directly accessing frame internals.
885
f18cbb28 886 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
887 globals_of_w32font.
888
889 * process.c: Include TERM_HEADER instead of listing all possible
890 window-system headers.
891
892 * nsterm.h: Remove declarations now in frame.h. Define
893 FRAME_X_SCREEN, FRAME_X_VISUAL.
894
895 * menu.c: Include TERM_HEADER instead of listing all possible
896 window-system headers.
897
898 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
899 window system.
900
901 * keyboard.c: Include TERM_HEADER instead of listing all possible
902 window-system headers.
903
904 * image.c: Include TERM_HEADER instead of listing all possible
905 window-system headers. Declare Vlibrary_cache when compiling for
906 Windows.
907
908 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
909 window system declarations.
910
911 * frame.h: Move common functions here: set_frame_menubar,
912 x_set_window_size, x_sync, x_get_focus_frame,
913 x_set_mouse_position, x_set_mouse_pixel_position,
914 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
915 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
916 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
917 x_activate_menubar, x_real_positions, x_bitmap_icon,
918 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
919 and x_query_colors.
920
921 * frame.c: Include TERM_HEADER instead of listing all possible
922 window-system headers.
923
924 * font.c: Include TERM_HEADER instead of listing all possible
925 window-system headers.
926
927 * emacs.c: Include TERM_HEADER.
928
f18cbb28
EZ
929 * dispnew.c: Include TERM_HEADER instead of listing all possible
930 window-system headers.
17a2cbbd 931
f18cbb28 932 * ccl.h: Include character.h.
17a2cbbd
DC
933
934 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
935 the current window system; include in list of objects to link into
936 Emacs.
937
c650a5de
DA
9382012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
939
940 Remove mark_ttys function and fix tty_display_info initialization.
941 * lisp.h (mark_ttys): Remove prototype.
942 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
943 to mark_ttys because all possible values of 'top_frame' slot are
944 the frames which are reachable from Vframe_list.
945 * term.c (mark_ttys): Remove.
946 (init_tty): Safely initialize 'top_frame' slot with Qnil.
947
4e0f6479
DA
9482012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
949
950 Change struct frame bitfields from unsigned char to unsigned.
951 * frame.h (struct frame): Change type of 'display_preempted',
952 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
953 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
954 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
955 bitfields from unsigned char to unsigned.
956
8b96a52c
DA
9572012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
958
959 Remove unused member of struct x_output and struct w32_output.
960 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
961 * w32term.h (struct w32_output): Likewise.
962
b4444c8a
JD
9632012-08-30 Jan Djärv <jan.h.d@swipnet.se>
964
965 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
966 does not become zero (Bug#12234).
967
b98521db
PE
9682012-08-30 Paul Eggert <eggert@cs.ucla.edu>
969
970 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
971 for GCC 4.7.1 x86-64.
972
31d02438
GM
9732012-08-30 Glenn Morris <rgm@gnu.org>
974
975 * lread.c (init_lread): For out-of-tree builds, only add the
976 source directory's site-lisp dir to the load-path if it exists,
977 consistent with in-tree builds. (Bug#12302)
978
7f8941d8
JD
9792012-08-28 Jan Djärv <jan.h.d@swipnet.se>
980
981 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 982 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
983 (windowShouldClose:): Set window_closed.
984 (dealloc): New member, free button_values.
fc0c31f8
JB
985 (process_dialog:): Make member function. Remove window argument,
986 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
987 in button_values.
988 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 989 with tag. Remove return self, declare return value as void.
7f8941d8
JD
990 (addString:row:): Remove return self, declare return value as void.
991 (addSplit): Remove return self, declare return value as void.
992 (clicked:): Remove return self, declare return value as void.
fc0c31f8 993 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
994 (initFromContents:isQuestion:): Adjust call to process_dialog.
995 Code formatting change.
996 (timeout_handler:): Set timer_fired to YES.
997 (runDialogAt:): Set timer_fired to NO.
998 Handle click on close button as quit.
999
1000 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
1001 Add window_closed and button_values. Add void as return value for
1002 add(Button|String|Split). addButton takes int instead of Lisp_Object.
1003 Add process_dialog as new member.
1004
eada0861 10052012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 1006
eada0861
GM
1007 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
1008 is not one of the heaps we manage. (Bug#12242)
1009
10102012-08-28 Glenn Morris <rgm@gnu.org>
1011
1012 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
1013
457294dd
MR
10142012-08-28 Martin Rudalics <rudalics@gmx.at>
1015
1016 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
1017 auto-buffer-name window parameter. Install revision of reverted
1018 fix.
457294dd 1019
4f2daf31
DA
10202012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1021
1022 Do not allow to set major mode for a dead buffer.
1023 * buffer.c (Fset_buffer_major_mode): Signal an error
1024 if the buffer is dead.
1025 (Fother_buffer, other_buffer_safely): Remove redundant
1026 nested declaration.
1027
66322887
DA
10282012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 Always use set_buffer_if_live to restore original buffer at unwind.
1031 * buffer.h (record_unwind_current_buffer): New function.
1032 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
1033 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
1034 * undo.c, window.c: Adjust users.
1035 * buffer.c (set_buffer_if_live): Fix comment.
1036
a3d794a1
DA
10372012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1038
1039 Fix usage of set_buffer_internal.
1040 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
1041 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
1042 * coding.c (decode_coding): Omit redundant test.
1043 * fileio.c (decide_coding_unwind): Likewise.
1044 * fns.c (secure_hash): Likewise.
1045 * insdel.c (modify_region): Likewise.
1046 * keyboard.c (command_loop_1): Likewise.
1047 * print.c (PRINTFINISH): Likewise.
1048 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
1049
59ea14cd
PE
10502012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 * dispnew.c: Use bool for boolean.
1053 (frame_garbaged, display_completed, delayed_size_change)
1054 (fonts_changed_p, add_window_display_history)
1055 (add_frame_display_history, verify_row_hash)
1056 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
1057 (row_equal_p, realloc_glyph_pool)
1058 (allocate_matrices_for_frame_redisplay)
1059 (showing_window_margins_p)
1060 (adjust_frame_glyphs_for_frame_redisplay)
1061 (build_frame_matrix_from_leaf_window, make_current)
1062 (mirrored_line_dance, mirror_line_dance, update_frame)
1063 (update_window_tree, update_single_window)
1064 (check_current_matrix_flags, update_window, update_text_area)
1065 (update_window_line, set_window_update_flags, scrolling_window)
1066 (update_frame_1, scrolling, buffer_posn_from_coords)
1067 (do_pending_window_change, change_frame_size)
1068 (change_frame_size_1, sit_for):
1069 Use bool for boolean.
1070 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
1071 and remove last int (actually boolean) argument, which was always 0.
1072 All callers changed.
1073 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
1074 * dispextern.h (struct composition_it): Use bool for boolean.
1075 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
1076 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
1077 * dired.c (file_name_completion):
1078 Use bool for boolean. (This was missed in an earlier change.)
1079
95072a94
MR
10802012-08-27 Martin Rudalics <rudalics@gmx.at>
1081
1082 * window.c (Fset_window_configuration): Revert first part of
1083 last change.
1084
0f19feff
JD
10852012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1086
1087 * nsterm.h (NSPanel): New class variable dialog_return.
1088
1089 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
1090 dialog_return.
1091 (windowShouldClose:): Use stop instead of stopModalWithCode.
1092 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1093 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1094 event.
1095 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1096 modal loop returns.
1097
f10fe38f
PE
10982012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1099
de1339b0
PE
1100 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1101 * composite.c (find_composition, composition_gstring_p)
1102 (composition_reseat_it, find_automatic_composition):
1103 * data.c (let_shadows_buffer_binding_p)
1104 (let_shadows_global_binding_p, set_internal, make_blv)
1105 (Fmake_variable_buffer_local, Fmake_local_variable)
1106 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1107 (cons_to_signed, arith_driver):
1108 * dbusbind.c (xd_in_read_queued_messages):
1109 * dired.c (directory_files_internal, file_name_completion):
1110 Use bool for booleans.
1111 * dired.c (file_name_completion):
1112 * process.h (fd_callback):
1113 Omit int (actually boolean) argument. It wasn't being used.
1114 All uses changed.
1115 * composite.h, lisp.h: Reflect above API changes.
1116
f10fe38f
PE
1117 * cmds.c, coding.c: Use bool for booleans.
1118 * cmds.c (move_point, Fself_insert_command):
1119 * coding.h (struct composition status, struct coding_system):
1120 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1121 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1122 (emacs_mule_char, decode_coding_emacs_mule)
1123 (encode_coding_emacs_mule, detect_coding_iso_2022)
1124 (decode_coding_iso_2022, encode_invocation_designation)
1125 (encode_designation_at_bol, encode_coding_iso_2022)
1126 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1127 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1128 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1129 (encode_coding_raw_text, detect_coding_charset)
1130 (decode_coding_charset, encode_coding_charset, detect_eol)
1131 (detect_coding, get_translation_table, produce_chars)
1132 (consume_chars, reused_workbuf_in_use)
1133 (make_conversion_work_buffer, code_conversion_save)
1134 (decode_coding_object, encode_coding_object)
1135 (detect_coding_system, char_encodable_p)
1136 (Funencodable_char_position, code_convert_region)
1137 (code_convert_string, code_convert_string_norecord)
1138 (Fset_coding_system_priority):
1139 * fileio.c (Finsert_file_contents):
1140 Use bool for booleans.
1141 * coding.h, lisp.h: Reflect above API changes.
1142 * coding.c: Remove unnecessary static function decls.
1143 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1144 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1145 not a boolean 'int', since callers never look at the return value.
1146 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1147 * coding.h (decoding_buffer_size, encoding_buffer_size)
1148 (emacs_mule_string_char): Remove unused extern decls.
1149 (struct iso_2022_spec, struct coding_system):
1150 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1151 (struct emacs_mule_spec): Remove unused field 'full_support'.
1152 All initializations removed.
1153 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1154
5474c384
DA
11552012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1156
f10fe38f 1157 Fix spare memory change (Bug#12286).
5474c384
DA
1158 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1159 (valid_lisp_object_p): Likewise.
1160
c4b6914d
MR
11612012-08-27 Martin Rudalics <rudalics@gmx.at>
1162
1163 * window.c (Fset_window_configuration): Record any window's old
1164 buffer if it's replaced (see Bug#8789). If the new current
1165 buffer doesn't appear in the selected window, go to its old
1166 point (Bug#12208).
1167
35aaa1ea
DA
11682012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1169
1170 Special MEM_TYPE_SPARE to denote reserved memory.
1171 * alloc.c (enum mem_type): New memory type.
1172 (refill_memory_reserve): Use new type for spare memory.
1173 This prevents live_cons_p and live_string_p from incorrect
1174 detection of uninitialized objects from spare memory as live.
1175
6af64513
PE
11762012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1177
8b2e00a3
PE
1178 Spelling fixes.
1179 * Makefile.in (.PHONY): versioclean -> versionclean.
1180
b52d6985
PE
1181 Remove unused external symbols.
1182 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1183 * window.c (Qwindow_valid_p, decode_valid_window):
1184 Now static, not extern.
1185 * data.c (Qinterval): Remove; unused.
1186 (syms_of_data): Do not define 'interval'.
1187 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1188 * window.h (decode_valid_window):
1189 Remove decls.
1190
d5172d4f
PE
1191 * character.c, charset.c, chartab.c: Use bool for booleans.
1192 * character.c (lisp_string_width, string_count_byte8)
1193 (string_escape_byte8):
1194 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1195 (load_charset_map_from_file, map_charset_chars)
1196 (Fdefine_charset_internal, define_charset_internal)
1197 (Fdeclare_equiv_charset, find_charsets_in_text)
1198 (Ffind_charset_region, char_charset, Fiso_charset):
1199 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1200 (sub_char_table_set, sub_char_table_set_range)
1201 (char_table_set_range, optimize_sub_char_table)
1202 (map_sub_char_table):
1203 Use bool for boolean.
1204 * character.c (str_to_unibyte): Omit last boolean argument; it was
1205 always 0. All callers changed.
1206 * character.h, charset.h: Adjust to match previous changes.
1207 * character.h (char_printable_p): Remove decl of nonexistent function.
1208 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1209 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1210 are all boolean, so make them single-bit bitfields.
1211
6af64513
PE
1212 * lisp.h (ASET): Remove attempt to detect side effects.
1213 It was meant to be temporary and it often doesn't work,
1214 because when IDX has side effects the behavior of IDX==IDX
1215 is undefined. See Stefan Monnier in
1216 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1217
e1f29348
BR
12182012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1219
1220 * lisp.h (functionp): New function (extracted from Ffunctionp).
1221 (FUNCTIONP): Use it.
1222 * eval.c (Ffunctionp): Use it.
1223
17c05d74
PE
12242012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1225
0f46bc75
PE
1226 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1227 as that's faster and simpler than static storage. Don't bother
1228 with the g_main_context_query overhead if g_main_context_pending
1229 says no events are pending.
1230 (gfds, gfds_size): Remove these static vars.
1231 (xgselect_initialize): Remove; no longer needed.
1232 All uses and decls removed.
1233
ee4c0f69
PE
1234 * emacs.c (fatal_error_signal_hook): Remove.
1235 All uses removed. This leftover from old code was always 0.
1236
17c05d74
PE
1237 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1238 * casefiddle.c (casify_object, casify_region):
1239 * casetab.c (set_case_table):
1240 * category.c, category.h (word_boundary_p):
1241 * category.h (CHAR_HAS_CATEGORY):
1242 Use bool for booleans, instead of int.
1243
391ceac5
EZ
12442012-08-25 Eli Zaretskii <eliz@gnu.org>
1245
1246 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1247
2f221583
PE
12482012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1249
f4a681b0
PE
1250 On assertion failure, print backtrace if available.
1251 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1252 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1253 * Makefile.in (LIB_EXECINFO): New macro.
1254 (LIBES): Use it.
1255
2f221583
PE
1256 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1257 * bytecode.c (exec_byte_code):
1258 * callint.c (check_mark, Fcall_interactively):
1259 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1260 (getenv_internal, sync_process_alive, call_process_exited):
1261 * lisp.h (USE_SAFE_ALLOCA):
1262 Use bool for booleans, instead of int.
1263 * lisp.h, process.h: Adjust prototypes to match above changes.
1264 * callint.c (Fcall_interactively): Don't assume the mark's
1265 offset fits in 'int'.
1266
37ef52bb
PE
12672012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * buffer.c, buffer.h: Use bool for boolean.
1270 * buffer.c (reset_buffer_local_variables)
1271 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1272 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1273 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1274 (overlay_touches_p, overlay_strings, Foverlay_put)
1275 (report_overlay_modification, call_overlay_mod_hooks):
1276 (mmap_enlarge, mmap_set_vars):
1277 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1278 Use bool for booleans, instead of int.
1279 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1280 since the 1-or-0 return value is always ignored anyway.
1281 (mmap_initialized_p):
1282 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1283 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1284
2cc21167
PE
12852012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1286
1287 * bidi.c: Use bool for boolean.
1288 This is a bit more readable, and makes the text segment of bidi.o
1289 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1290 Presumably it's faster too.
1291 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1292 Now bool.
1293 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1294 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1295 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1296 (bidi_explicit_dir_char, bidi_level_of_next_char)
1297 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1298 Use bool for booleans, instead of int.
1299 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1300 (bidi_unshelve_cache): Adjust decls to match code.
1301
7db4ddf4
MR
13022012-08-23 Martin Rudalics <rudalics@gmx.at>
1303
1304 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1305 argument.
1306
b1bb8011
PE
13072012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1310 * atimer.h: Include <stdbool.h>.
1311
ff687885
DN
13122012-08-22 Dan Nicolaescu <dann@gnu.org>
1313
1314 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1315 compile time tests instead of run time tests on systems that do
1316 not use them.
1317 (FRAME_MAC_P): Remove leftover from deleted code.
1318 * frame.c (syms_of_frame): Remove leftover from deleted code.
1319
4ce7a138
JD
13202012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1321
1322 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1323
d733ec6d
PE
13242012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
1327 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 1328 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
1329 (fontset_add): Return void, for FONTSET_ADD.
1330
d0d2d26f
PE
13312012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1332
fce31d69
PE
1333 * alloc.c: Use bool for booleans.
1334 (gc_in_progress, abort_on_gc)
1335 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1336 (dont_register_blocks) [GC_MALLOC_CHECK]:
1337 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
1338 (check_string_bytes, make_specified_string, memory_full)
1339 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
1340 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
1341 (mark_stack, valid_pointer_p, make_pure_string)
1342 (Fgarbage_collect, survives_gc_p, gc_sweep):
1343 Use bool for booleans, instead of int.
1344 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1345 Remove unused local.
1346 * alloc.c (PURE_POINTER_P):
1347 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
1348 * editfns.c (Fformat):
1349 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
1350 (Fdo_auto_save):
1351 * fns.c (sweep_weak_table):
1352 * lisp.h (suppress_checking, push_message, survives_gc_p)
1353 (make_pure_string, gc_in_progress, abort_on_gc):
1354 * lread.c (readchar, read1):
1355 * print.c (Fprin1_to_string):
1356 * xdisp.c (push_message):
1357 Use bool for booleans affected directly or indirectly by
1358 alloc.c's changes.
1359
d0d2d26f
PE
1360 Make recently-introduced setters macros.
1361 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
1362 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
1363 (set_fontset_default, set_fontset_fallback): Rename from their
1364 upper-case counterparts, and make them functions rather than macros.
1365 This is more consistent with the other recently-introduced setters.
1366 These don't need to be inline, since they're local.
1367
d18e2bb6
JD
13682012-08-21 Jan Djärv <jan.h.d@swipnet.se>
1369
1370 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
1371 the loop (Bug#12247).
1372
1b9d9d16
PE
13732012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * lisp.h (vcopy): Use memcpy rather than our own loop.
1376 This fixes a performance regression introduced by the recent
1377 addition of vcopy. This means 'vcopy' will need to be modified
1378 for a copying collector, but that's OK. Also, tighten the
1379 checking in the assertion.
1380
b2f09701
EZ
13812012-08-21 Eli Zaretskii <eliz@gnu.org>
1382
1383 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
1384 components for RTL text (Bug#11860). Adjust X-OFFSET of each
1385 non-base glyph for the width of the base character, according to
e1f29348
BR
1386 what x_draw_composite_glyph_string_foreground expects.
1387 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
1388 expectations, to produce correct width of the composed character.
1389 Reverse the sign of the DU offset produced by ScriptPlace.
1390
9b994fed
PE
13912012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
1394
086ca913
DA
13952012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1396
1397 Avoid direct writes to contents member of struct Lisp_Vector.
1398 * lisp.h (vcopy): New function to copy data into vector.
1399 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
1400 * fns.c (Ffillarray): Use ASET.
1401 * keyboard.c (timer_check_2): Use AREF and ASET.
1402 (append_tool_bar_item, Frecent_keys): Use vcopy.
1403 * lread.c (read_vector): Use ASET.
1404 * msdos.c (Frecent_doskeys): Use vcopy.
1405 * xface.c (Finternal_copy_lisp_face): Use vcopy.
1406 (Finternal_merge_in_global_face): Use ASET and vcopy.
1407 * xfont.c (xfont_list_pattern): Likewise.
1408
5481664a
MR
14092012-08-21 Martin Rudalics <rudalics@gmx.at>
1410
1411 * window.c (Fwindow_point): For the selected window always return
1412 the position of its buffer's point.
1413 (Fset_window_point): For the selected window always go in its
1414 buffer to the specified position.
1415
6d470bdd
DA
14162012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 Setter macros for fontsets.
1419 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
1420 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
1421 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
1422 Adjust users.
1423
24564fe1
GM
14242012-08-20 Glenn Morris <rgm@gnu.org>
1425
1426 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1427 Don't assume that `ln -f' works.
1428
0a05a035
EZ
14292012-08-20 Eli Zaretskii <eliz@gnu.org>
1430
1431 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
1432 and later about non-assignments with no effect. See discussion at
1433 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
1434 details.
1435
e46f2325
DA
14362012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1437
1438 Inline setter functions for Lisp_Objects slots of struct specbinding.
1439 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
1440 Adjust users.
1441
734fbd86
MR
14422012-08-20 Martin Rudalics <rudalics@gmx.at>
1443
1444 * window.c (select_window): Always make selected window's buffer
1445 current.
1446
f1a95992
DA
14472012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1448
1449 Use AREF and ASET for docstrings of category tables.
1450 * category.h (CATEGORY_DOCSTRING): Use AREF.
1451 (SET_CATEGORY_DOCSTRING): Use ASET.
1452 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
1453
e83064be
DA
14542012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1455
1456 Inline setter functions for hash table members.
1457 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
1458 (set_hash_hash, set_hash_index): Rename with _slot suffix.
1459 (set_hash_key_and_value, set_hash_index, set_hash_next)
1460 (set_hash_hash): New functions.
1461 * charset.c, fns.c: Adjust users.
1462
4ce60d2e
DA
14632012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1464
1465 Inline getter and setter functions for per-buffer values.
1466 * buffer.h (per_buffer_default, set_per_buffer_default)
1467 (per_buffer_value, set_per_buffer_value): New functions.
1468 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
1469 * buffer.c, data.c: Adjust users.
1470
c06c9690
JB
14712012-08-20 Juanma Barranquero <lekktu@gmail.com>
1472
1473 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
1474
32bd4250
PE
14752012-08-19 Paul Eggert <eggert@cs.ucla.edu>
1476
bad03192 1477 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
1478 as gnulib does this if the system doesn't.
1479 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
1480 Remove declaration. MS-Windows declares it on stdlib.h which is
1481 included by conf_post.h.
b69a6d22
PE
1482 * emacs.c (environ) [DOUG_LEA_MALLOC]:
1483 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
1484 * vm-limit.c: Include <unistd.h>, for 'environ'.
1485
22d7feb2
PE
1486 * unexaix.c, unexcoff.c: Include "mem-limits.h".
1487 (start_of_data): Remove decl; mem-limits.h provides it.
1488
32bd4250
PE
1489 * xdisp.c (handle_invisible_prop): Make it a bit faster
1490 and avoid a gcc -Wmaybe-uninitialized diagnostic.
1491
450809af
CY
14922012-08-19 Chong Yidong <cyd@gnu.org>
1493
1494 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
1495 ends (Bug#3874).
1496
9e677988
AS
14972012-08-19 Andreas Schwab <schwab@linux-m68k.org>
1498
6b1319ce
AS
1499 * .gdbinit: Use call instead of set when calling a function in the
1500 inferior.
1501
9e677988
AS
1502 * data.c (set_internal): Don't use set_blv_found.
1503 (Fkill_local_variable): Likewise.
1504
d7191076
AA
15052012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
1506
1507 * nsfont.m (ns_ascii_average_width): Ensure the string
1508 ascii_printable is initialized with a null-terminated character
1509 array. Otherwise, it can contain undesired extra characters.
1510
e757f1c6
PE
15112012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 port new setting code to Sun C 5.8 2005/10/13
1514 * chartab.c, lisp.h (char_table_set, char_table_set_range):
1515 Return void, not Lisp_Object. Otherwise, the compiler
1516 complains about (A?B:C) where B is void and C is Lisp_Object
1517 when compiling CHAR_TABLE_SET, due to the recent change to
1518 the API of sub_char_table_set_contents.
1519
a999ce26
CY
15202012-08-18 Chong Yidong <cyd@gnu.org>
1521
1522 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
1523 for the string case (Bug#3874).
1524
3f22b86f
PE
15252012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1526
39eb03f1
PE
1527 * buffer.h (BSET): Remove (Bug#12215).
1528 Replace all uses with calls to new setter functions.
1529 (bset_bidi_paragraph_direction, bset_case_canon_table)
1530 (bset_case_eqv_table, bset_directory, bset_display_count)
1531 (bset_display_time, bset_downcase_table)
1532 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
1533 (bset_last_selected_window, bset_local_var_alist)
1534 (bset_mark_active, bset_point_before_scroll, bset_read_only)
1535 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
1536 (bset_width_table):
1537 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
1538 (bset_auto_fill_function, bset_auto_save_file_format)
1539 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
1540 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
1541 (bset_cache_long_line_scans, bset_case_fold_search)
1542 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
1543 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
1544 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
1545 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
1546 (bset_header_line_format, bset_indicate_buffer_boundaries)
1547 (bset_indicate_empty_lines, bset_invisibility_spec)
1548 (bset_left_fringe_width, bset_major_mode, bset_mark)
1549 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
1550 (bset_name, bset_overwrite_mode, bset_pt_marker)
1551 (bset_right_fringe_width, bset_save_length)
1552 (bset_scroll_bar_width, bset_scroll_down_aggressively)
1553 (bset_scroll_up_aggressively, bset_selective_display)
1554 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
1555 (bset_word_wrap, bset_zv_marker):
1556 * category.c (bset_category_table):
1557 * syntax.c (bset_syntax_table):
1558 New setter functions.
1559
6a09a33b
PE
1560 * process.h (PSET): Remove (Bug#12215).
1561 Replace all uses with calls to new setter functions.
1562 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1563 (PROCESS_INLINE): New macro.
1564 (pset_childp): New setter function.
1565 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
1566 * process.c (PROCESS_INLINE):
1567 Define to EXTERN_INLINE, so that the corresponding functions
1568 are compiled into code.
1569 (pset_buffer, pset_command, pset_decode_coding_system)
1570 (pset_decoding_buf, pset_encode_coding_system)
1571 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
1572 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
1573 (pset_type, pset_write_queue): New setter functions.
1574
e8c17b81
PE
1575 * window.h (WSET): Remove (Bug#12215).
1576 Replace all uses with calls to new setter functions.
1577 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1578 (WINDOW_INLINE): New macro.
1579 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
1580 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
1581 (wset_total_lines, wset_vertical_scroll_bar)
1582 (wset_window_end_pos, wset_window_end_valid)
1583 (wset_window_end_vpos): New setter functions.
1584 * window.c (WINDOW_INLINE):
1585 Define to EXTERN_INLINE, so that the corresponding functions
1586 are compiled into code.
1587 (wset_combination_limit, wset_dedicated, wset_display_table)
1588 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
1589 (wset_new_normal, wset_new_total, wset_next_buffers)
1590 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
1591 (wset_prev_buffers, wset_right_fringe_width)
1592 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
1593 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
1594 (wset_window_parameters):
1595 * xdisp.c (wset_base_line_number, wset_base_line_pos)
1596 (wset_column_number_displayed, wset_region_showing):
1597 New setter functions.
1598
3f22b86f
PE
1599 * termhooks.h (TSET): Remove (Bug#12215).
1600 Replace all uses with calls to new setter functions.
1601 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1602 (TERMHOOKS_INLINE): New macro.
1603 (tset_charset_list, tset_selection_alist): New setter functions.
1604 * terminal.c (TERMHOOKS_INLINE):
1605 Define to EXTERN_INLINE, so that the corresponding functions
1606 are compiled into code.
1607 (tset_param_alist): New setter function.
1608
742af32f
PE
16092012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1610
15dbb4d6
PE
1611 * keyboard.h (KSET): Remove (Bug#12215).
1612 Replace all uses with calls to new setter functions.
1613 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1614 (KEYBOARD_INLINE): New macro.
1615 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
1616 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
1617 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
1618 New setter functions.
1619 * keyboard.c (KEYBOARD_INLINE):
1620 Define to EXTERN_INLINE, so that the corresponding functions
1621 are compiled into code.
1622 (kset_echo_string, kset_kbd_queue)
1623 (kset_keyboard_translate_table, kset_last_prefix_arg)
1624 (kset_last_repeatable_command, kset_local_function_key_map)
1625 (kset_overriding_terminal_local_map, kset_real_last_command)
1626 (kset_system_key_syms): New setter functions.
1627
f00af5b1
PE
1628 * frame.h (FSET): Remove (Bug#12215).
1629 Replace all uses with calls to new setter functions.
1630 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1631 (FRAME_INLINE): New macro.
1632 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
1633 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1634 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
1635 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
1636 (fset_param_alist, fset_root_window, fset_scroll_bars)
1637 (fset_selected_window, fset_title, fset_tool_bar_items)
1638 (fset_tool_bar_position, fset_tool_bar_window): New functions.
1639 * frame.c (FRAME_INLINE):
1640 Define to EXTERN_INLINE, so that the corresponding functions
1641 are compiled into code.
1642 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
1643
0c94c8d6
PE
1644 A few more naming-convention fixes for getters and setters.
1645 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
1646 and rename from buffer_overlays_set_before.
1647 (set_buffer_overlays_after): Move here from buffer.h, and rename
1648 from buffer_overlays_set_after.
1649 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
1650 All uses changed.
1651 (set_buffer_intervals): Rename from buffer_set_intervals.
1652 * intervals.c (set_interval_object): Move here from intervals.h,
1653 and rename from interval_set_object.
1654 (set_interval_left): Move here from intervals.h, and rename from
1655 interval_set_left.
1656 (set_interval_right): Move here from intervals.h, and rename from
1657 interval_set_right.
1658 (copy_interval_parent): Move here from intervals.h, and rename from
1659 interval_copy_parent.
1660 * intervals.h (set_interval_parent): Rename from interval_set_parent.
1661 (set_interval_plist): Rename from interval_set_plist.
1662 Return void, not Lisp_Object, since no caller uses the result.
1663 * lisp.h (string_intervals): Rename from string_get_intervals.
1664 (set_string_intervals): Rename from string_set_intervals.
1665
34dabdb7
PE
1666 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
1667 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 1668 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
1669 All uses changed. See the end of
1670 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
1671
742af32f
PE
1672 * lisp.h (CSET): Remove (Bug#12215).
1673 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
1674 (set_char_table_purpose): New functions,
1675 replacing CSET. All uses changed. For example, replace
1676 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 1677 "set_char_table_parent (char_table, parent);".
742af32f
PE
1678 The old version was confusing because it used the same name
1679 'parent' for two different things.
1680
a04e2c62
DA
16812012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1682
1683 Functions to get and set Lisp_Object fields of buffer-local variables.
1684 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
1685 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
1686 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
1687 * data.c, eval.c, frame.c: Adjust users.
1688
383dcbf9
CY
16892012-08-17 Chong Yidong <cyd@gnu.org>
1690
1691 * xfaces.c (merge_face_vectors): If the target font specfies a
1692 font spec, make the font's attributes take precedence over
1693 directly-specified attributes.
1694 (merge_face_ref): Recognize :font.
1695
44386687
DA
16962012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1697
1698 Do not use memcpy for copying intervals.
1699 * intervals.c (reproduce_interval): New function.
1700 (reproduce_tree, reproduce_tree_obj): Use it.
1701 (reproduce_tree_obj): Remove prototype.
1702
927c7216
PE
17032012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1704
1705 * lisp.h (duration_to_sec_usec): Remove unused decl.
1706
93044f7b
AA
17072012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
1708
1709 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
1710 to an allocated instance of NSString, not to the class itself.
1711
9851e4a5
JB
17122012-08-17 Juanma Barranquero <lekktu@gmail.com>
1713
1714 * makefile.w32-in (C_CTYPE_H): New macro.
1715 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
1716 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
1717 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1718
620f13b0
PE
17192012-08-16 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 Use ASCII tests for character types.
1722 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
1723 * xfns.c, xterm.c:
1724 Don't include <ctype.h>; was not needed.
1725 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
1726 * sysdep.c, xfaces.c:
1727 Include <c-ctype.h> instead of <ctype.h>.
1728 * nsterm.m: Include <c-ctype.h>.
1729 * charset.c (read_hex):
1730 * doc.c (Fsnarf_documentation):
1731 * fileio.c (IS_DRIVE) [WINDOWSNT]:
1732 (DRIVE_LETTER) [DOS_NT]:
1733 (Ffile_name_directory, Fexpand_file_name)
1734 (Fsubstitute_in_file_name):
1735 * font.c (font_parse_xlfd, font_parse_fcname):
1736 * frame.c (x_set_font_backend):
1737 * gtkutil.c (xg_get_font):
1738 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
1739 * nsimage.m (hexchar):
1740 * nsterm.m (ns_xlfd_to_fontname):
1741 * sysdep.c (system_process_attributes):
1742 * xfaces.c (hash_string_case_insensitive):
1743 Use C-locale tests instead of locale-specific tests for character
1744 types, since we want the ASCII interpretation here, not the
1745 interpretation suitable for whatever happens to be the current locale.
1746
52162052
MR
17472012-08-16 Martin Rudalics <rudalics@gmx.at>
1748
1749 Consistently check windows for validity/liveness
1750 (Bug#11984, Bug#12025, Bug#12026).
1751 * lisp.h (CHECK_VALID_WINDOW): New macro.
1752 * window.c (decode_window): Rename to decode_live_window.
1753 (decode_valid_window, Fwindow_valid_p): New functions.
1754 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
1755 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
1756 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
1757 (Fwindow_prev_sibling, Fwindow_combination_limit)
1758 (Fset_window_combination_limit, Fwindow_use_time)
1759 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
1760 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
1761 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
1762 (Fwindow_hscroll, Fset_window_hscroll)
1763 (Fwindow_redisplay_end_trigger)
1764 (Fset_window_redisplay_end_trigger, Fwindow_edges)
1765 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
1766 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1767 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
1768 (Fwindow_end, Fset_window_point, Fset_window_start)
1769 (Fpos_visible_in_window_p, Fwindow_line_height)
1770 (Fwindow_dedicated_p, Fset_window_dedicated_p)
1771 (Fwindow_prev_buffers, Fset_window_prev_buffers)
1772 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
1773 (Fset_window_parameter, Fwindow_display_table)
1774 (Fset_window_display_table, Fdelete_other_windows_internal)
1775 (Fset_window_buffer, Fset_window_new_total)
1776 (Fset_window_new_normal, Fdelete_window_internal)
1777 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
1778 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
1779 (Fwindow_scroll_bars): Check whether argument window is a valid or
1780 live window. Update doc-strings.
1781 (syms_of_window): New symbol Qwindow_valid_p.
1782 * keyboard.c (Fposn_at_x_y): Check whether argument
1783 frame_or_window denotes a valid window.
1784
2751c80f
DA
17852012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1786
1787 Fix previous char table change.
1788 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
1789 * chartab.c (optimize_sub_char_table): Likewise.
1790
032a42c8
CY
17912012-08-16 Chong Yidong <cyd@gnu.org>
1792
a2d19368
CY
1793 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
1794
032a42c8
CY
1795 * xfont.c (xfont_open):
1796 * xftfont.c (xftfont_open): Set the font's max_width field.
1797
1798 * nsfont.m (nsfont_open): Similar to the Xft backend, set
1799 min_width to space_width and average_width to the average over
1800 printable ASCII characters.
1801 (ns_char_width): Code cleanup.
1802 (ns_ascii_average_width): New utility function.
1803
1804 * font.h (struct font): Update comments.
1805
a098c930
DA
18062012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1807
032a42c8 1808 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
1809 * lisp.h (CSET): New macro.
1810 (char_table_set_extras, char_table_set_contents)
1811 (sub_char_table_set_contents): New function.
1812 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
1813 * syntax.c: Adjust users.
1814
8be3a09c
SM
18152012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
1816
1817 * eval.c (eval_sub): Bind lexical-binding.
1818 * lread.c (Qlexical_binding): Make non-static.
1819
ac4845a6
JD
18202012-08-15 Jan Djärv <jan.h.d@swipnet.se>
1821
ddee6515
JD
1822 * nsmenu.m (popupSession): Remove.
1823 (pop_down_menu): Remove endModalSession.
1824 (timeout_handler:): New method.
1825 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
1826 Call runModalForWindow. Check timer_fired when it returns.
1827 If not set, cancel timer and break out of loop.
1828 Otherwise loop again, with a new timeout.
1829
1830 * nsterm.m: Include fcntl.h if present.
1831 (fd_entry, t_readfds, inNsSelect): Remove.
1832 (select_writefds, select_valid, select_timeout, selfds)
1833 (select_mutex, apploopnr): Add.
1834 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
1835 Otherwise call kbd_buffer_store_event.
1836 (ns_send_appdefined): Remove release of fd_entry.
1837 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
1838 Increment and decrement apploopnr.
1839 (ns_select): If no file descriptors, just do a NSTimer.
1840 Otherwise copy read/write masks and start select thread (fd_handler).
1841 Start main loop and wait for application defined event.
1842 Inform select thread to stop selecting after main loop is exited.
1843 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 1844 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
1845 (fd_handler:): Loop forever, wait for info from the main thread
1846 to either start or stop selecting. When select returns, send
1847 and appdefined event.
1848 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
1849 If not call kbd_buffer_store_event.
1850
1851 * nsterm.h (EmacsApp): fd_handler takes id argument.
1852 (EmacsDialogPanel): Add timer_fired and timeout_handler.
1853
ac4845a6
JD
1854 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
1855
eb424fe3
EZ
18562012-08-15 Eli Zaretskii <eliz@gnu.org>
1857
1858 * region-cache.c (move_cache_gap): Update gap_len using the actual
1859 growth of the boundaries array. Do not change cache_len.
1860 (Bug#12196)
1861
4e6a86c6
DA
18622012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1863
1864 Generalize and cleanup font subsystem checks.
1865 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
1866 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
1867 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 1868
5bf192ca
DA
18692012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1870
1871 * gtkutil.c (xg_get_font): Use pango_units_to_double.
1872
f2045622
CY
18732012-08-15 Chong Yidong <cyd@gnu.org>
1874
8be3a09c
SM
1875 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
1876 When using the new font chooser, use gtk_font_chooser_get_font_desc to
1877 extract the font descriptor instead of just the font name.
1878 In that case, return a font spec instead of a string.
f2045622
CY
1879 (x_last_font_name): Move to this file from xfns.c.
1880
1881 * xfns.c (Fx_select_font): The return value can also be a font
1882 spec. Move x_last_font_name management to gtkutil.c.
1883
1884 * xfaces.c: Make font weight and style symbols non-static.
1885
7f6feb56
SM
18862012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
1887
1888 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
1889 (bug#12117).
1890
fecbd8ff
SM
18912012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
1892
1893 * alloc.c (Fgarbage_collect): Use plural form consistently.
1894
9b8d5165
EZ
18952012-08-14 Eli Zaretskii <eliz@gnu.org>
1896
1897 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
1898 iteration through the command loop. Fixes a problem whereby mouse
1899 movements are ignored until the first mouse click.
1900
f5d9e83a
PE
19012012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 Use bool, not int, for Lisp booleans.
1904 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
1905 makes Emacs a bit smaller and presumably a bit faster.
1906 * lisp.h: Include <stdbool.h>.
1907 (struct Lisp_Boolfwd, defvar_bool):
1908 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
1909 * regex.c [!emacs]: Include <stdbool.h>.
1910 (false, true): Remove; <stdbool.h> does this for us now.
1911
55802e4a
CY
19122012-08-14 Chong Yidong <cyd@gnu.org>
1913
4abcdac8
CY
1914 * character.c (Fcharacterp): Doc fix (Bug#12076).
1915
1916 * data.c (Findirect_variable): Doc fix (Bug#11040).
1917
55802e4a
CY
1918 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
1919
1920 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 1921 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 1922
8e99d072
BR
19232012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1924
1925 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
1926 (bug#12022).
1927
08908aca
MR
19282012-08-14 Martin Rudalics <rudalics@gmx.at>
1929
1930 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
1931 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1932 * minibuf.c (choose_minibuf_frame, read_minibuf):
1933 * w32fns.c (x_create_tip_frame):
1934 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
1935 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
1936
56120d6f
PE
19372012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 * intervals.c (offset_intervals): Remove obsolete comment.
1940
67b77c0b
AS
19412012-08-14 Andreas Schwab <schwab@linux-m68k.org>
1942
1943 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
1944
f48b82fd
GR
19452012-08-14 Gergely Risko <gergely@risko.hu>
1946
1947 * coding.c (decode_coding): Record buffer modification before
1948 disabling undo_list (Bug#11773).
1949
fd318b54
DA
19502012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1951
1952 Revert and cleanup some recent overlay changes.
1953 * buffer.h (enum overlay_type): Remove.
1954 (buffer_get_overlays, buffer_set_overlays): Likewise.
1955 (buffer_set_overlays_before, buffer_set_overlays_after):
1956 New function. Adjust users.
1957 (unchain_both): Add eassert.
1958
41a62dd9
DA
19592012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1960
1961 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1962
5884c324
PE
19632012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 * gtkutil.c (xg_mark_data): Don't assume C99.
1966
ca06f160
JD
19672012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1968
1969 * gtkutil.c (xg_frame_tb_info): New struct.
1970 (TB_INFO_KEY): New define.
1971 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1972 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1973 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1974 if not present.
1975 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 1976 is up to date. Otherwise store new data.
ca06f160
JD
1977 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1978
7864a3f7
DA
19792012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1980
1981 Use KSET for write access to Lisp_Object members of struct kboard.
1982 * keyboard.h (KSET): New macro.
1983 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1984 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1985 * xterm.c: Adjust users.
1986
4c31be61
DA
19872012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1988
1989 Use BSET for write access to Lisp_Object members of struct buffer.
1990 * buffer.h (BSET): New macro.
1991 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1992 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1993 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1994 * window.c, xdisp.c, xfns.c: Adjust users.
1995
14ae4239
BT
19962012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1997
1998 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1999
32bcadb4
JD
20002012-08-11 Jan Djärv <jan.h.d@swipnet.se>
2001
3d29b2ce 2002 * nsterm.m (not_in_argv): New function.
fc0c31f8 2003 (application:openFile, application:openTempFile:):
3d29b2ce
JD
2004 (application:openFileWithoutUI:, application:openFiles:): Open file
2005 if not_in_argv returns non-zero (bug#12171).
2006
32bcadb4 2007 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
2008 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
2009 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
2010 (xg_get_font_name): Use those functions/macros here.
2011 Reported by Frans Oilinki <moilinki@gmail.com>.
2012
9ff9402d 20132012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
2014
2015 * unexmacosx.c (copy_data_segment): Copy initialized data in
2016 statically linked libraries from input file rather than memory.
2017
db74a5fc
YM
2018 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
2019 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
2020 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
2021
25e65510
GM
20222012-08-10 Glenn Morris <rgm@gnu.org>
2023
2024 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
2025 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
2026
7961135c
DA
20272012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2028
2029 Fix last change to allow compilation with low optimization levels.
2030 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
2031 Reported by Jan Djärv <jan.h.d@swipnet.se>.
2032
42b3a444
DA
20332012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2034
2035 Use common inline syntax in intervals.h.
2036 * intervals.h (INTERVALS_INLINE): New macro.
2037 Change all users from LISP_INLINE.
2038
9fb0c957
DA
20392012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2040
2041 Define Qnone once for all platforms.
2042 * frame.c (Qnone): Define here.
2043 (syms_of_frame): DEFSYM it.
2044 * lisp.h (Qnone): New declaration.
2045 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
2046 * xfns.c: Remove duplication. Adjust users.
2047
65e8ee52
DA
20482012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2049
2050 Remove unused macros from intervals.h.
2051 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
2052 * intervals.c: Adjust comment.
2053
9b855fd6
EZ
20542012-08-10 Eli Zaretskii <eliz@gnu.org>
2055
2056 * w32fns.c <w32_unicode_gui>: New static variable.
2057 (globals_of_w32fns): Initialize it according to os_subtype.
2058 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
2059 testing os_subtype.
2060
39cb9e56 20612012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
2062 Eli Zaretskii <eliz@gnu.org>
2063
2064 Fix bug #10299 with Unicode characters sent by customized
2065 keyboards created by MSKLC.
2066 * w32fns.c (INIT_WINDOW_CLASS): New macro.
2067 (w32_init_class): Use it to initialize the Emacs class with either
2068 ANSI or Unicode API calls.
2069 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
2070 later.
2071 (w32_wnd_proc): If the character code sent by WM_CHAR or
2072 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
2073 original message. Call DefWindowProcW on NT and later.
2074
9374581a
GM
20752012-08-10 Glenn Morris <rgm@gnu.org>
2076
4b94e8cf
GM
2077 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
2078
9374581a
GM
2079 * lisp.h (DIRECTORY_SEP): Let configure set it.
2080
a2752828
DA
20812012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2082
2083 Use TSET for write access to Lisp_Object slots of struct terminal.
2084 * termhooks.h (TSET): New macro.
2085 * coding.c, terminal.c, xselect.c: Adjust users.
2086
cc92c454
SM
20872012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2090 the failing expression, include them in the error message.
2091 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2092 * lisp.h (internal_condition_case_n): Update declaration.
2093
4cb3e6b3
DA
20942012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2095
2096 Inline functions to examine and change buffer overlays.
2097 * buffer.c (unchain_both): New function.
2098 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2099 (buffer_has_overlays): New function.
2100 (enum overlay_type): New enum.
2101 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2102 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2103
8707c1e5
DA
21042012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2105
2106 Inline functions to examine and change buffer intervals.
2107 * alloc.c (mark_interval_tree): Remove.
2108 (MARK_INTERVAL_TREE): Simplify.
2109 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2110 * intervals.c (buffer_balance_intervals): New function.
2111 (graft_intervals_into_buffer): Adjust indentation.
2112 (set_intervals_multibyte): Simplify.
2113 * buffer.h (BUF_INTERVALS): Remove.
2114 (buffer_get_intervals, buffer_set_intervals): New function.
2115 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2116 * intervals.c, textprop.c: Adjust users.
2117
ad8c997f
DA
21182012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2119
2120 Inline functions to examine and change string intervals.
2121 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2122 (string_get_intervals, string_set_intervals): New function.
2123 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2124 * lread.c, print.c, textprop.c: Adjust users.
2125
32ac3a6b
GM
21262012-08-08 Glenn Morris <rgm@gnu.org>
2127
2128 * lisp.mk (lisp): Remove language/persian.elc.
2129
77c7bcb1
DA
21302012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2131
2132 Cleanup intervals.
2133 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2134 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2135 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2136 Adjust comment. Move under #if 0.
77c7bcb1
DA
2137 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2138 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2139
9c08a8d4
DA
21402012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2141
2142 Check total length of intervals with eassert.
2143 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2144 * intervals.c: Change all users to eassert.
2145
26d16b35
EZ
21462012-08-07 Eli Zaretskii <eliz@gnu.org>
2147
14ae4239
BT
2148 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2149 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2150 INTERNAL_FIELD in Lisp_Cons.
2151
c644523b
DA
21522012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2153
2154 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2155 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2156 name since all xname users are fixed long time ago. Do not
2157 use INTERNAL_FIELD.
2158 (set_symbol_name, set_symbol_function, set_symbol_plist):
2159 (set_symbol_next, set_overlay_plist): New function.
2160 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2161 (struct Lisp_Overlay): Likewise.
2162 (CVAR, MVAR, SVAR): Remove.
2163 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2164 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2165 * xterm.c: Adjust users.
2166 * .gdbinit: Change to use name field of struct Lisp_Symbol
2167 where appropriate.
2168
6a3d20cc
DA
21692012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Basic functions to set Lisp_Object and pointer slots of intervals.
2172 * intervals.h (interval_set_parent, interval_set_object):
2173 (interval_set_left, interval_set_right, interval_set_plist):
2174 (interval_copy_parent): New function.
2175 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2176 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2177 Adjust indentation.
6a3d20cc
DA
2178 (INTERVAL_SIZE): Remove. Adjust users.
2179 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2180
4d2b044c
DA
21812012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2182
2183 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2184 * process.h (PGET): Remove.
2185 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2186 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2187
d3d50620
DA
21882012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2189
2190 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2191 * window.h (WGET): Remove.
2192 (struct window): Do not use INTERNAL_FIELD.
2193 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2194 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2195 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2196 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2197 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2198 Adjust users.
2199
d10a51dc
CY
22002012-08-07 Chong Yidong <cyd@gnu.org>
2201
2202 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2203 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2204 (Fdelete_window_internal): Signal an error if the window is not on
2205 a live frame (Bug#12025).
2206
e69b0960
DA
22072012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2208
2209 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2210 * frame.h (FGET): Remove.
2211 (struct frame): Do not use INTERNAL_FIELD.
2212 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2213 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2214 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2215 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2216
25a20a3a
JB
22172012-08-06 Juanma Barranquero <lekktu@gmail.com>
2218
2219 * w32.c: Silence compiler warnings.
2220 (map_w32_filename): Remove unused variable `is_fat'.
2221 (chase_symlinks): Add parentheses around expression.
2222
1c6f11f4
GM
22232012-08-06 Glenn Morris <rgm@gnu.org>
2224
1db4583a
GM
2225 * sysdep.c: Respect BROKEN_GETWD.
2226
1c6f11f4
GM
2227 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2228 Let configure handle it.
2229 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2230
2b90362b
DA
22312012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2232
2233 Use GCALIGNMENT where appropriate.
2234 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2235 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2236 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2237
5f50daf2
EZ
22382012-08-06 Eli Zaretskii <eliz@gnu.org>
2239
14ae4239
BT
2240 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2241 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2242
cbcc7007
SM
22432012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2244
2245 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2246 that should be sufficient for everyone.
2247
4d365fa4
JD
22482012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2249
2250 * keyboard.c (timer_check_2): Add break so timer_check returns next
2251 timeout.
2252
dd86bd82
DA
22532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2254
2255 Fix Windows build errors introduced after converting to WGET and WSET.
2256 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2257 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2258
054e1668
JD
22592012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2260
2261 * nsterm.m (ns_frame_rehighlight): Use FSET.
2262
2263 * nsmenu.m (ns_update_menubar): Use FSET.
2264
21238f11
DA
22652012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2266
2267 Separate read and write access to Lisp_Object slots of Lisp_Process.
2268 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2269 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2270
077288cf
DA
22712012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2272
2273 Separate read and write access to Lisp_Object slots of struct window.
2274 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2275 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2276 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2277 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2278 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2279 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2280 Adjust users.
2281
71688bd7
DA
22822012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2283
2284 Fix Windows build errors introduced after converting to FGET and FSET.
2285 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2286 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2287 (w32_judge_scroll_bars): Change to use FSET.
2288 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2289
f99bac93
DA
22902012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2291
2292 Fix replacement typo.
2293 * window.c (replace_window): Set root_window instead of
2294 selected_window. This fixes a total window subsystem
2295 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2296
8c2a0f2d
GM
22972012-08-06 Glenn Morris <rgm@gnu.org>
2298
2299 * lisp.mk (lisp): Add language/persian.elc.
2300
edd74c35
DA
23012012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2302
2303 Separate read and write access to Lisp_Object slots of struct frame.
2304 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2305 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2306 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2307 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2308 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2309
8671676c
AS
23102012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2311
2312 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2313
663e2b3f
DA
23142012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2315
2316 Generalize common compile-time constants.
2317 * lisp.h (header_size, bool_header_size, word_size): Now here.
2318 (struct Lisp_Vector): Add comment.
2319 (struct Lisp_Bool_Vector): Move up to define handy constants.
2320 (VECSIZE, PSEUDOVECSIZE): Simplify.
2321 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2322 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2323 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2324 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2325 * xfont.c, xmenu.c: Use word_size where appropriate.
2326
d32e47af
LM
23272012-08-05 Lawrence Mitchell <wence@gmx.li>
2328
2329 * search.c (Freplace_match): Treat \? in the replacement text
2330 literally (Bug#8161).
2331
e5d9c0d1
CY
23322012-08-05 Chong Yidong <cyd@gnu.org>
2333
2334 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
2335 * frame.c (Vdelete_frame_functions):
2336 * emacs.c (Vkill_emacs_hook): Doc fix.
2337
8da0576b
EZ
23382012-08-04 Eli Zaretskii <eliz@gnu.org>
2339
2340 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
2341 --with-x-toolkit=no builds.
2342 Reported by Carsten Mattner <carstenmattner@gmail.com>.
2343
02676e5d
CY
23442012-08-04 Chong Yidong <cyd@gnu.org>
2345
2346 * syntax.c (Fmodify_syntax_entry): Doc fix.
2347
97147da9
EZ
23482012-08-04 Eli Zaretskii <eliz@gnu.org>
2349
76151e2c
EZ
2350 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
2351 * w32.c (init_environment): Change the default values of many
2352 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
2353 them into environment when they were not already defined.
2354 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 2355 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
2356 (check_windows_init_file): Now external, not static.
2357 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
2358 called when Vload_path is already set up.
2359
2360 * w32.h (check_windows_init_file): Add prototype.
2361
2362 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
2363 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
2364 compatibility with Posix platforms.
2365 (main): Move the call to check_windows_init_file to here from
2366 w32.c.
2367 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
2368 any, in the DEFALT argument into the root of the Emacs build or
2369 installation tree, as appropriate.
2370
2371 * callproc.c (init_callproc_1): Call decode_env_path instead of
2372 doing its equivalent by hand.
2373 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
2374 the code that sets Vexec_path run on MS-Windows.
2375
2376 * lread.c (init_lread): Add comments to #ifdef's.
2377
97147da9
EZ
2378 * msdos.c (dos_set_window_size, IT_update_begin)
2379 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
2380 instead of direct references.
2381
185ee146
PE
23822012-08-04 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 Export DEFAULT_REHASH_* to GDB.
2385 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
2386 Now constants, not macros.
2387
8834c57a
PE
23882012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2389
98c6f1e3
PE
2390 Remove unnecessary casts involving pointers.
2391 These casts are no longer needed now that we assume C89 or later,
2392 since they involve casting to or from void *.
2393 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
2394 (make_pure_float, make_pure_vector):
2395 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
2396 * macros.c (Fstart_kbd_macro):
2397 * menu.c (find_and_return_menu_selection):
2398 * minibuf.c (read_minibuf_noninteractive):
2399 * sysdep.c (closedir):
2400 * xdisp.c (x_produce_glyphs):
2401 * xfaces.c (compare_fonts_by_sort_order):
2402 * xfns.c (x_real_positions, select_visual):
2403 * xselect.c (x_stop_queuing_selection_requests)
2404 (x_get_window_property, x_get_window_property_as_lisp_data):
2405 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
2406 Remove unnecessary pointer casts.
2407 * alloc.c (record_xmalloc): New function.
2408 * lisp.h (record_xmalloc): New decl.
2409 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
2410 more like a function. This is because the pointer cast is not
2411 needed. All uses changed.
2412 * print.c (print_string, print_error_message): Avoid length recalc.
2413
8834c57a
PE
2414 Improve fix for macroexp crash with debugging (Bug#12118).
2415 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
2416 ARRAY_MARK_FLAG when checking subscripts, because ASET is
2417 not supposed to be invoked from the garbage collector.
2418 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
2419 (gc_aset): New function, which is like ASET but can be
2420 used in the garbage collector.
2421 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2422 (set_hash_index): Use it instead of ASET.
2423
6dad7178
EZ
24242012-08-03 Eli Zaretskii <eliz@gnu.org>
2425
2426 Support symlinks on latest versions of MS-Windows.
2427 * w32.c: Include winioctl.h and aclapi.h.
2428 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
2429 (revert_to_self): Forward declarations of static functions.
2430 <static BOOL g_b_init_get_security_info>:
2431 <g_b_init_create_symbolic_link>: New static flags.
2432 (globals_of_w32): Initialize them to zero.
2433 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
2434 (map_w32_filename): Improve commentary. Simplify switch.
2435 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
2436 headers (most versions of MinGW w32api don't).
2437 (get_security_info, create_symbolic_link)
2438 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
2439 New functions.
2440 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
2441 in the argument file name.
2442 (sys_access): Call unc_volume_file_attributes only if
2443 GetFileAttributes fails with network-related error codes.
2444 (sys_rename): Diagnose renaming of a symlink when the user doesn't
2445 have the required privileges.
14ae4239 2446 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
2447 get_file_security_desc.
2448 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
2449 with addition of handling of symlinks and support for 'lstat'.
2450 If possible, get file's attributes and security information by
6dad7178
EZ
2451 handle, not by name. Produce S_IFLNK bit for symlinks, when
2452 called from 'lstat'.
2453 (stat, lstat): New functions, call 'stat_worker'.
2454 (symlink, readlink, careadlinkat): Rewritten to create and resolve
2455 symlinks when the underlying filesystem supports them.
2456
f162bcc3
PE
24572012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2458
79ea6c20
PE
2459 Fix macroexp crash on Windows with debugging (Bug#12118).
2460 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
2461 checking subscripts; problem introduced with the recent
2462 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
2463 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
2464 since it's used in non-static inline functions now.
2465
c0ce93fd
PE
2466 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
2467 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 2468
f162bcc3
PE
2469 Use C99-style 'extern inline' if available.
2470 * buffer.h (BUFFER_INLINE):
2471 * category.h (CATEGORY_INLINE):
2472 * character.h (CHARACTER_INLINE):
2473 * charset.h (CHARSET_INLINE):
2474 * composite.h (COMPOSITE_INLINE):
2475 * dispextern.h (DISPEXTERN_INLINE):
2476 * lisp.h (LISP_INLINE):
2477 * systime.h (SYSTIME_INLINE):
2478 New macro, replacing 'static inline' in this header.
2479 * buffer.h, category.h, character.h, charset.h, composite.h:
2480 * dispextern.h, lisp.h, systime.h:
2481 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2482 * alloc.c (LISP_INLINE):
2483 * buffer.c (BUFFER_INLINE):
2484 * category.c (CATEGORY_INLINE):
2485 * character.c (CHARACTER_INLINE):
2486 * charset.c (CHARSET_INLINE):
2487 * composite.c (COMPOSITE_INLINE):
2488 * dispnew.c (DISPEXTERN_INLINE):
2489 * sysdep.c (SYSTIME_INLINE):
2490 Define to EXTERN_INLINE, so that the corresponding functions
2491 are compiled into code.
2492 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
2493 (INLINE_HEADER_END): New macros.
2494 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
2495 since it's used in non-static inline functions now.
a8333d03 2496 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 2497
837b365b
GM
24982012-08-02 Glenn Morris <rgm@gnu.org>
2499
d66b744d
GM
2500 * s/: Remove empty directory.
2501
837b365b
GM
2502 * s/ms-w32.h: Move to ../nt/inc.
2503 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
2504 Update for new ms-w32.h location.
2505
13294f95
PE
25062012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 Port to Solaris 8.
2509 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
2510
90df0db3
GM
25112012-08-02 Glenn Morris <rgm@gnu.org>
2512
2513 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
2514 hard-coding the path separator.
2515
4939150c
PE
25162012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
2519 This how ASET and AREF are supposed to work, and makes
2520 it easier to think about future improvements. See
2521 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
2522 * charset.h (set_charset_attr): New function.
2523 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
2524 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
2525 (aref_addr): New function. All uses of &AREF(...) changed.
2526 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2527 (set_hash_index): New functions. All lvalue-style uses of
2528 HASH_KEY etc. changed.
2529 * keyboard.c (set_prop): New function. All lvalue-style uses
2530 of PROP changed.
2531
947b2afd
AA
25322012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
2533
2534 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
2535 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
2536 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
2537 * nsfns.m (ns_set_name_as_filename): Likewise.
2538 * nsmenu.m (ns_update_menubar): Likewise.
2539 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
2540
4f5d0325
EZ
25412012-08-01 Eli Zaretskii <eliz@gnu.org>
2542
2008beae
EZ
2543 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
2544 Adapt to latest changes in field names of the corresponding Lisp
288479f6 2545 objects.
2008beae 2546
4f5d0325
EZ
2547 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
2548
fe3cc771
GM
25492012-08-01 Glenn Morris <rgm@gnu.org>
2550
2551 * s/msdos.h: Remove file.
2552 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
2553 * Makefile.in (S_FILE): Remove.
2554 (config_h): Remove S_FILE.
2555
c90acc54
JB
25562012-08-01 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
2559 Remove; moved to nt/config.nt.
2560
d8a05828
DA
25612012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2562
2563 Use INTERNAL_FIELD for conses and overlays.
2564 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
2565 Remove obsolete comment.
2566 (MVAR): New macro.
2567 (struct Lisp_Overlay): Use INTERNAL_FIELD.
2568 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
2569
8271d590
DA
25702012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2571
2572 Use INTERNAL_FIELD for symbols.
2573 * lisp.h (SVAR): New macro. Adjust users.
2574 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
2575 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
2576
3193acd2
DA
25772012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2578
2579 Use INTERNAL_FIELD for processes.
2580 * process.h (PVAR): New macro. Adjust style.
2581 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
2582 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
2583
3a45383a
DA
25842012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2585
2586 Use INTERNAL_FIELD for windows.
2587 * window.h (WVAR): New macro.
2588 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
2589 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2590 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2591 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
2592 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
2593 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2594
c1dbc63c
PE
25952012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2596
2597 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
2598
5c0c0e8a
GM
25992012-08-01 Glenn Morris <rgm@gnu.org>
2600
2601 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
2602 Move to configure.ac.
2603
552a99b4
JB
26042012-08-01 Juanma Barranquero <lekktu@gmail.com>
2605
2606 * makefile.w32-in (CONFIG_H): Update dependencies.
2607 (CONF_POST_H): New macro.
2608
2609 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
2610
8d8e2dfe
GM
26112012-07-31 Glenn Morris <rgm@gnu.org>
2612
bc96620a
GM
2613 * Makefile.in (S_FILE): No longer set by configure.
2614
476b1b2d
GM
2615 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
2616 is available.
2617 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
2618
b2c7a106
GM
2619 * process.h (NULL_DEVICE):
2620 * emacs.c (SEPCHAR):
2621 * editfns.c (USER_FULL_NAME): Let configure set them.
2622
d53d062a
GM
2623 * s/README, s/template.h: Remove files.
2624
4515017f
GM
2625 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
2626
8d8e2dfe
GM
2627 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
2628 Move to configure.ac.
2629
5b20b3cc
EZ
26302012-07-31 Eli Zaretskii <eliz@gnu.org>
2631
1e0afd9a
EZ
2632 * .gdbinit (xframe): Adapt to introduction of FVAR and the
2633 resulting renaming of 'struct frame' members.
2634
5b20b3cc
EZ
2635 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
2636
2637 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
2638 after introduction of FVAR.
2639
f1310128
JD
26402012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2641
79e721e0
JD
2642 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
2643
2644 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
2645 instead of compositeToPoint.
2646 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
2647
8d7c7eed 2648 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 2649
e34f7f79
DA
26502012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2651
2652 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
2653 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 2654 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
2655 (BVAR): Change to use INTERNAL_FIELD.
2656 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
2657 (KVAR): Change to use INTERNAL_FIELD.
2658 * frame.h (FVAR): New macro.
2659 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
2660 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
2661 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
2662 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
2663 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2664
c09bfb2f
DA
26652012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2666
2667 Miscellaneous fixes for non-default X toolkits.
2668 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
2669 * xterm.c (x_frame_of_widget): Remove redundant prototype.
2670 Move under #ifdef USE_LUCID.
2671 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
2672 definition and usage to avoid warnings.
2673
14c114ae
JD
26742012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2675
2676 * nsterm.m (openFiles): Fix previous checkin.
2677
3bd21e82
PE
26782012-07-31 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * indent.c (compute_motion): Remove unused local.
2681
c1529ded
GM
26822012-07-31 Glenn Morris <rgm@gnu.org>
2683
400d5621
GM
2684 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
2685
268e2432
GM
2686 * conf_post.h [USG5_4]:
2687 Move remaining contents of s/usg5-4-common.h here.
2688 * s/usg5-4-common.h: Remove file.
2689
7552f3ee
GM
2690 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
2691 * s/irix6-5.h: Remove file.
2692
6a381852
GM
2693 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
2694 * s/darwin.h: Remove file.
2695
c1529ded
GM
2696 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
2697 * s/hpux10-20.h: Remove file, which is now empty.
2698
b429a4ee
GM
26992012-07-30 Glenn Morris <rgm@gnu.org>
2700
2701 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
2702 * Makefile.in (config_h): Add conf_post.h.
2703 * makefile.w32-in (CONFIG_H): Add conf_post.h.
2704
adff3182
JD
27052012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2706
2707 * nsterm.m (ns_do_open_file): New variable.
b9031d69 2708 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
2709 (openFile, openTempFile, openFileWithoutUI, openFiles):
2710 Open files only if ns_do_open_file.
adff3182 2711
c32af1e4
PE
27122012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2713
7393bcbb
PE
2714 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
2715 This no-op macro hasn't been needed for many years.
2716 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
2717
c32af1e4
PE
2718 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
2719 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
2720 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
2721 gdb_make_enums_visible.
2722 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
2723 (DIRECTORY_SEP): Now a constant, not a macro.
2724
302fc036
EZ
27252012-07-30 Eli Zaretskii <eliz@gnu.org>
2726
2727 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
2728 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
2729
2730 * w32term.c <w32_keyboard_codepage>: Renamed from
2731 keyboard_codepage and now external. All users changed.
2732
2733 * w32term.h: Add declaration of w32_keyboard_codepage.
2734
2735 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
2736 the codepage to translate keys to Unicode. If this argument is
2737 -1, use the value returned by GetConsoleCP. All callers changed.
2738
88fb40b4
PE
27392012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2740
0aee6912
PE
2741 Update .PHONY listings in makefiles.
2742 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
2743 bootstrap-clean, distclean, maintainer-clean, versioclean,
2744 extraclean, frc.
2745
88fb40b4
PE
2746 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
2747 This is a bit clearer. Fix some commentary typos.
2748
0a763bd1
GM
27492012-07-30 Glenn Morris <rgm@gnu.org>
2750
32bac6d6
GM
2751 * s/netbsd.h: Let configure include signal.h if needed.
2752 Remove file, which is now empty.
2753
b65e7c46
GM
2754 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
2755 Let configure set them.
2756 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
2757 No more need to undefine.
0a763bd1 2758
169304bd
AS
27592012-07-30 Andreas Schwab <schwab@linux-m68k.org>
2760
2761 * keymap.c (Fkey_description): Don't remove 0x80 bit from
2762 non-single-byte char when adding meta modifier. (Bug#12090)
2763
6cd7a139
DA
27642012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2765
2766 Convert safe_call to use variable number of arguments.
2767 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
2768 (safe_call2): Fix comment.
2769 * lisp.h (safe_call): Adjust prototype.
2770 * coding.c (encode_coding_object): Change to use safe_call2.
2771 * xfaces.c (merge_face_heights): Change to use safe_call1.
2772
d34d6ffc
GM
27732012-07-30 Glenn Morris <rgm@gnu.org>
2774
7b8a48e4 2775 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 2776 does that unconditionally. Remove file, which is now empty.
7b8a48e4 2777
d34d6ffc
GM
2778 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
2779 Remove empty files.
2780
03a660a6
PE
27812012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2782
2783 Export to GDB most of lisp.h's remaining object-like macros.
2784 * lisp.h (min, max): Move earlier, because they're used earlier now.
2785 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
2786 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
2787 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
2788 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
2789 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
2790 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
2791 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
2792 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
2793 Now constants, for GDB. They need not be macros.
2794 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
2795 Now constants, for GDB, as well as macros, for static initializers.
2796 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
2797 Move to after the definition of struct Lisp_Char_Table,
2798 since the former now needs that type defined.
2799 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
2800 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
2801 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
2802 New enums, for gdb_make_enums_visible.
2803 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 2804 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
2805 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
2806 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
2807 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
2808 enum maxargs, enum MAX_ALLOCA.
2809 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
2810 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
2811 no longer needed, now that they are done in lisp.h.
2812
e499d0ee
DA
28132012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2814
2815 Cleanup string bytes checking.
2816 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
2817 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
2818 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
2819 (check_sblock, compact_small_strings): Simplify.
2820
d5040d2d
PE
28212012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
2824 These macros are confusing and no longer need to be defined, as
2825 the enum values now suffice. All uses replaced with definiens.
2826 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
2827
7f259ae6
JB
28282012-07-29 Juanma Barranquero <lekktu@gmail.com>
2829
2830 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
2831 ($(BLD)/w32console.$(O)): Update dependencies.
2832
7e63e0c3
DA
28332012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2834
2835 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
2836 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
2837 time. Adjust users.
2838 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
2839
ffd817eb
JD
28402012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2841
2842 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
2843 setting sitelisp (Bug#12010).
2844
417a7a0e
EZ
28452012-07-29 Eli Zaretskii <eliz@gnu.org>
2846
14ae4239 2847 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
2848
2849 * w32heap.c (cache_system_info):
2850 * w32.c (sys_rename):
2851 * w32proc.c (find_child_console, sys_kill): All users changed.
2852
387d4d92
PE
28532012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2854
2855 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
2856
55a6cca6
EZ
28572012-07-29 Eli Zaretskii <eliz@gnu.org>
2858
2859 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
2860
dbcf001c
DA
28612012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2862
2863 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
2864 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
2865 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 2866
e2688e4a
DA
28672012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2868
2869 Generalize marker debugging code under MARKER_DEBUG and use eassert.
2870 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
2871 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
2872 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
2873 (replace_range, replace_range_2, del_range_2): Change to eassert.
2874 * marker.c (byte_char_debug_check): Adjust style.
2875
b46a6a83
PE
28762012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
2879 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
2880 long-ago-commented-out code that talks about "WIN32".
2881 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
2882 All uses changed.
2883
e32a5799
PE
28842012-07-28 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 Use Gnulib stdalign module (Bug#9772, Bug#9960).
2887 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
2888 Simplify by using alignof.
2889 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
2890 * lisp.h: Include <stdalign.h>.
2891 (GCALIGNMENT): New macro and constant.
2892 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
2893 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
2894 (stdalign): New macro, if not already defined.
2895
df81cd29
EZ
28962012-07-28 Eli Zaretskii <eliz@gnu.org>
2897
01bd1b0d
EZ
2898 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
2899 * w32inevt.c: Include w32inevt.h.
2900 (w32_read_console_input): New inline function, calls either
2901 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
2902 w32_console_unicode_input.
2903 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
2904 (w32_kbd_patch_key, key_event): Use the codepage returned by
2905 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
2906 (key_event): use uChar.UnicodeChar only if
2907 w32_console_unicode_input is non-zero.
2908
2909 * w32console.c: Include w32heap.h.
2910 <w32_console_unicode_input>: New global variable.
2911 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
2912 family of Windows, zero otherwise.
2913
2914 * w32inevt.h: Declare w32_console_unicode_input.
2915
df81cd29
EZ
2916 * xdisp.c (init_iterator): Don't reference tip_frame in a build
2917 --without-x. (Bug#11742)
2918
c20fdd9e
PE
29192012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 Adjust GDB to reflect pvec_type changes (Bug#12036).
2922 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
2923 2012-07-04 changes to pseudovector representation.
2924 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 2925
32770973 29262012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
2927
2928 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
2929 bus address.
2930 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
2931
3438fe21
EZ
29322012-07-27 Eli Zaretskii <eliz@gnu.org>
2933
bcfbc9de
EZ
2934 * alloc.c (listn): Fix the order the arguments are consed onto the
2935 list.
2936
3438fe21
EZ
2937 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
2938 enumeration constants, as PURE and HEAP are too general, and clash
2939 with other headers and sources, such as gmalloc.c and the
2940 MS-Windows system headers. All users changed.
2941
eeaea515
DA
29422012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2943
2944 Revert last save_excursion_save and save_excursion_restore changes.
2945 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
2946 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2947
073c88c2
DA
29482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2949
2950 Fix recently-introduced typos in Windows port.
2951 Reported by Martin Rudalics <rudalics@gmx.at>.
2952 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2953 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2954
4706125e
PE
29552012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 Improve GDB symbol export (Bug#12036).
2958 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2959 arms of an 'if', not using conditional expressions; otherwise GDB
2960 complains about the types in the unevaluated arm when the argument
2961 is an integer literal.
2962 (xgetint): Simplify expression.
2963 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2964 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2965 Zaretskii in <http://bugs.gnu.org/12036#13>.
2966 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2967 needed now that we have gdb_make_enums_visible.
2968 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2969 (enum enum_USE_LSB_TAG):
2970 New enum types, packaging up enums that need to be exported to GDB.
2971
694b6c97
DA
29722012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2973
2974 Utility function to make a list from specified amount of objects.
2975 * lisp.h (enum constype): New datatype.
2976 (listn): New prototype.
2977 * alloc.c (listn): New function.
2978 (Fmemory_use_count, syms_of_alloc): Use it.
2979 * buffer.c (syms_of_buffer): Likewise.
2980 * callint.c (syms_of_callint): Likewise.
2981 * charset.c (define_charset_internal): Likewise.
2982 * coding.c (syms_of_coding): Likewise.
2983 * keymap.c (syms_of_keymap): Likewise.
2984 * search.c (syms_of_search): Likewise.
2985 * syntax.c (syms_of_syntax): Likewise.
2986 * w32.c (init_environment): Likewise.
2987 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2988 * xdisp.c (syms_of_xdisp): Likewise.
2989 * xfns.c (syms_of_xfns): Likewise.
2990
6195f384
DA
29912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2992
2993 Fast save_excursion_save and save_excursion_restore.
2994 * lisp.h (struct Lisp_Excursion): New data type.
2995 (PVEC_EXCURSION): New pseudovector type.
2996 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2997 to deal with it. Adjust comments.
2998 (init_marker, attach_marker): New prototype.
2999 (unchain_marker): Adjust prototype.
3000 * marker.c (attach_marker): Change to global.
3001 (init_marker): New function.
3002 * alloc.c (Fmake_marker, build_marker): Use it.
3003 (build_marker): More easserts.
3004 (mark_object): Handle struct Lisp_Excursion.
3005 * editfns.c (save_excursion_save, save_excursion_restore):
3006 Reimplement to use struct Lisp_Excursion. Add comments.
3007
5eceb8fb
PE
30082012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3009
3010 Fix export of symbols to GDB (Bug#12036).
3011 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
3012 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
3013 emacs.c, as this is a more-suitable home. Had this been done earlier
3014 the fix for 12036 would have avoided some of the problems noted in
3015 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
3016 would have been more obvious.
562157c8
PE
3017 * emacs.c: Do not include <verify.h>; no longer needed.
3018 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
3019 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
3020 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3021 Remove; now done in lisp.h.
3022 * lisp.h (PUBLISH_TO_GDB): New macro.
3023 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
3024 (DATA_SEG_BITS): Use it.
3025 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
3026 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
3027 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
3028 not be usable in #if. This simplifies things.
3029
d6749401
JB
30302012-07-26 Juanma Barranquero <lekktu@gmail.com>
3031
3032 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
3033
1781b9e9
PE
30342012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3035
d89518db 3036 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
3037 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
3038 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
3039 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
3040 Adjust to changes in lisp.h and emacs.c, by using
3041 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
3042 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
3043 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
3044 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
3045 instead of gdb_valbits.
3046 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
3047 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
3048 instead of gdb_array_mark_flag.
3049 (xboolvector): Get size from $->size, not $->header.size.
3050 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
3051 (xreload, hook-run, hookpost-run): Remove.
3052 * emacs.c: Include <verify.h>.
3053 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
3054 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
3055 Remove.
3056 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
3057 (gdb_USE_LSB_TAG): New enum constants.
3058 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3059 Also define these as enum constants, so they're visible to GDB.
3060 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
3061 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
3062 as constants, so they're visible to GDB.
3063 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
3064 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
3065 Now enum constants, not macros, so they're visible to GDB.
3066 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
3067 more convenient now. All uses changed.
3068 (VALMASK) [USE_LSB_TAG]: Also define in this case.
3069 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
3070
3628596a
DA
30712012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
3072
3073 Explicitly free restriction data that are not needed anymore.
3074 * editfns.c (save_restriction_restore): Free restriction data.
3075
7abaf5cc
SM
30762012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3077
3078 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
3079 add argument, tune behavior, and adjust all callers.
3080
71f88e00
PE
30812012-07-25 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 Use typedef for EMACS_INT, EMACS_UINT.
3084 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3085 than macros. This simplifies debugging in the usual case, since
3086 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3087 and it allows expressions involving EMACS_INT casts.
3088 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3089
57ec3034
JD
30902012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3091
3092 * nsterm.m (ns_read_socket): Return early if there is a modal
3093 window (Bug#12043).
3094
8137e7b3
MR
30952012-07-25 Martin Rudalics <rudalics@gmx.at>
3096
3097 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3098 that FOCUS-FRAME can be omitted.
3099
04e9897c
DA
31002012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3101
3102 Adjust buffer text indirection counters at the end of Fkill_buffer.
3103 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3104 buffer is definitely dead. This should really fix an issue reported
3105 by Christoph Scholtes again. (Bug#12007).
3106 (init_buffer_once): Initialize indirection counters of
3107 buffer_defaults and buffer_local_symbols (for sanity and safety).
3108
8a0484e1
EZ
31092012-07-24 Eli Zaretskii <eliz@gnu.org>
3110
3111 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3112 and continuation glyphs on tooltip frames, leave them at zero.
3113 Avoids continued lines in tooltips. (Bug#11832)
3114
fa691a83
DA
31152012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3116
3117 Simplify copy_overlay.
04e9897c 3118 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3119 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3120
436bc8e0
EZ
31212012-07-23 Eli Zaretskii <eliz@gnu.org>
3122
3123 * print.c (print_object): Don't crash when a frame's name is nil
3124 or invalid. (Bug#12025)
3125
3126 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3127 it signals an error when a tooltip frame is being created.
3128
d7a7fda3
DA
31292012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3130
3131 Cleanup miscellaneous objects allocation and initialization.
3132 * alloc.c (allocate_misc): Change to static. Add argument to
3133 specify the subtype. Adjust comment and users.
3134 (build_overlay): New function.
3135 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3136 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3137 (allocate_misc): Remove prototype.
3138 (build_overlay): Add prototype.
3139
31402012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3141
3142 Swap buffer text indirection counters in Fbuffer_swap_text.
3143 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3144 This avoids crash reported by Christoph Scholtes at
3145 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3146
9d7fa573
JD
31472012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3148
3149 * nsmenu.m (Popdown_data): New struct.
3150 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3151 free Popdown_data.
3152 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3153 (initWithContentRect): Make imgView and contentView non-static
3154 and autorelease them. Also autorelease img and matrix (Bug#12005).
3155 (dealloc): Remove (Bug#12005).
3156
0dd6d66d
DA
31572012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3158
3159 Adjust consing_since_gc when objects are explicitly freed.
3160 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3161 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3162 (free_cons, free_misc): Subtract object size from consing_since_gc.
3163
d36d71df
DA
31642012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3165
3166 Simplify and cleanup markers positioning code.
3167 * marker.c (attach_marker): More useful eassert.
3168 (live_buffer, set_marker_internal): New function.
3169 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3170 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3171
fb9ea40f
PE
31722012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3173
3174 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3175 as it's limited by the amount of memory, not by INT_MAX.
3176
2d5c5f7d
EZ
31772012-07-21 Eli Zaretskii <eliz@gnu.org>
3178
07fb592e
EZ
3179 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3180 in special-event-map. See the discussion at
3181 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3182 for the reasons.
3183
37a9eac8 3184 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3185 info.dwItemData. Fixes crashes on 64-bit Windows.
3186 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3187
c4328746
JD
31882012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3189
fc0c31f8 3190 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3191 (conversationIdentifier): Return value is NSInteger.
784051c4 3192 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3193
6e5d1c12
CY
31942012-07-21 Chong Yidong <cyd@gnu.org>
3195
3196 * window.c (decode_any_window): Signal an error if the window is
3197 on a dead frame (Bug#11984).
3198
9928463d
DA
31992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3200
3201 Add indirection counting to speed up Fkill_buffer.
3202 * buffer.h (struct buffer): New member.
3203 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3204 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3205 base buffer indirection counter.
3206 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3207 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3208 through buffer list if indirection counter is 0.
3209
f8643a6b
DA
32102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3211
3212 Extend the value returned by Fgarbage_collect with heap statistics.
3213 * alloc.c (Qheap): New symbol.
3214 (syms_of_alloc): DEFSYM it.
3215 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3216 (Fmemory_free): Remove.
3217 (syms_of_alloc): Don't defsubr it.
3218 * buffer.c (Fcompact_buffer): Remove.
3219 (syms_of_buffer): Don't defsubr it.
3220
dac616ff
DA
32212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3222
3223 Make maybe_gc inline.
3224 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3225 * lisp.h (consing_since_gc, gc_relative_threshold)
3226 (memory_full_cons_threshold): Revert declaration.
3227 (maybe_gc): Remove prototype, define as inline.
3228 * alloc.c: Remove old commented-out code.
3229 (consing_since_gc, gc_relative_threshold)
3230 (memory_full_cons_threshold): Revert to global.
3231 (maybe_gc): Remove.
3232
d7ea76b4
DA
32332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3234
3235 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3236 * lisp.h (build_unibyte_string): New function.
3237 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3238 * sysdep.c, w32fns.c, xfns.c: Use it.
3239 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3240 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3241 Adjust users accordingly.
3242 * font.h (font_open_by_name): Adjust prototype.
3243
765e61e3
DA
32442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3245
3246 Cleanup calls to Fgarbage_collect.
3247 * lisp.h (maybe_gc): New prototype.
3248 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3249 Remove declarations.
3250 * alloc.c (maybe_gc): New function.
3251 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3252 Make them static.
3253 * bytecode.c (MAYBE_GC): Use maybe_gc.
3254 * eval.c (eval_sub, Ffuncall): Likewise.
3255 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3256 to avoid dependency from auto-save feature.
3257
52b852c7
PE
32582012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3261 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3262 'for_each_per_buffer_object_at'.
3263 All uses changed. It's better to use upper-case for macros that
3264 cannot be implemented as functions, to give the reader a clue
3265 that they're special.
3266
5db81e33
SM
32672012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3268
3269 * alloc.c (Fgarbage_collect): Tweak docstring.
3270
5b835e1d
DA
32712012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3272
3273 Tweak the value returned from Fgarbage_collect again.
3274 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3275 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3276 Adjust documentation.
3277 (total_vector_bytes): Rename to total_vector_slots, adjust
3278 accounting.
3279 (total_free_vector_bytes): Rename to total_free_vector_slots,
3280 adjust accounting.
3281 (Qstring_bytes, Qvector_slots): New symbols.
3282 (syms_of_alloc): DEFSYM them.
3283
9cd47b72
DA
32842012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3285
3286 Buffer compaction primitive which may be used from Lisp.
3287 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3288 (syms_of_buffer): Register Fcompact_buffer.
3289 * alloc.c (Fgarbage_collect): Use compact_buffer.
3290 * buffer.h (compact_buffer): New prototype.
3291 (struct buffer_text): New member.
3292
d17337e5
DA
32932012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3294
3295 New macro to iterate over all buffers, miscellaneous cleanups.
3296 * lisp.h (all_buffers): Remove declaration.
3297 * buffer.h (all_buffers): Add declaration, with comment.
3298 (for_each_buffer): New macro.
3299 * alloc.c (Fgarbage_collect, mark_object): Use it.
3300 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3301 (init_buffer): Likewise.
3302 * data.c (Fset_default): Likewise.
3303 * coding.c (code_conversion_restore): Remove redundant check
3304 for dead buffer.
3305 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3306
60cfd278
AS
33072012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3308
3309 Fix bug that created negative-length intervals.
3310 * intervals.c (merge_interval_right, merge_interval_left):
3311 Do not zero out this interval if it is absorbed by its children,
3312 as this interval's total length doesn't change in that case. See
3313 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3314
d06714cb
PE
33152012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3316
83713154
PE
3317 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3318 when invoking (make-bool-vector N t) and N is a positive
3319 multiple of 8 -- the last 8 bits were mistakenly cleared.
3320
d06714cb
PE
3321 Remove some struct layout assumptions in bool vectors.
3322 * alloc.c (bool_header_size): New constant.
3323 (header_size, word_size): Move earlier, as they're now used earlier.
3324 Use 'word_size' in a few more places, where it's appropriate.
3325 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3326 padding before the data member of a bool vector.
3327 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
3328 than doing the check by hand with an abort ().
3329
464d5a5e
SM
33302012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3331
5fbc0409
SM
3332 * eval.c (Fdefvar): Don't check constants since we only set the var if
3333 it's not yet defined anyway (bug#11904).
3334
464d5a5e
SM
3335 * lisp.h (last_undo_boundary): Declare new var.
3336 * keyboard.c (command_loop_1): Set it.
3337 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
3338 were auto-added by the command loop (bug#11774).
3339
8dc2e44a
AS
33402012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3341
3342 * w32font.c (Qsymbol): Remove local definition.
3343 (syms_of_w32font): Don't DEFSYM it.
3344
169925ec
DA
33452012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3346
3347 Fix sweep_vectors to handle large bool vectors correctly.
3348 * alloc.c (sweep_vectors): Account total_vector_bytes for
3349 bool vectors larger than VBLOCK_BYTES_MAX.
3350
5fbfb018
CY
33512012-07-18 Chong Yidong <cyd@gnu.org>
3352
3353 * frame.c (x_set_frame_parameters): Revert bogus change introduced
3354 in 2012-05-25 commit by Paul Eggert (Bug#11738).
3355
3ab6e069
DA
33562012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3357
3358 Return more descriptive data from Fgarbage_collect.
3359 Suggested by Stefan Monnier in
3360 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
3361 * alloc.c (bounded_number): New function.
3362 (total_buffers, total_vectors): New variable.
3363 (total_string_size): Rename to total_string_bytes, adjust users.
3364 (total_vector_size): Rename to total_vector_bytes, adjust users.
3365 (sweep_vectors): Account total_vectors and total_vector_bytes.
3366 (Fgarbage_collect): New return value. Adjust documentation.
3367 (gc_sweep): Account total_buffers.
3368 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
3369 (VECTOR_SIZE): Remove.
3370 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
3371 (Qinterval, Qmisc): New symbols.
3372 (syms_of_data): Initialize them.
3373 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
3374 (Qcons, Qbuffer): New declarations.
3375
6d02fe5b
PE
33762012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 * alloc.c (Fmemory_free): Account for memory-free's own storage.
3379 Round up, not down. Improve doc.
3380
b7ffe040
DA
33812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3382
3383 Restore old code in allocate_string_data to avoid Faset breakage.
3384 Reported by Julien Danjou <julien@danjou.info> in
3385 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
3386 * alloc.c (allocate_string_data): Restore old code with minor
3387 adjustments, fix comment to explain this subtle issue.
3388
4dc7c8d5
SM
33892012-07-17 Eli Zaretskii <eliz@gnu.org>
3390
3391 Remove FILE_SYSTEM_CASE.
3392 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
3393
3394 * fileio.c (FILE_SYSTEM_CASE): Don't define.
3395 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
3396 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
3397 call-process-region passes it through expand-file-name.
3398
3399 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
3400
34012012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3402
3403 Fix crash when creating indirect buffer (Bug#11917)
3404 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
3405 Don't handle unbound variables specially if non-zero.
3406 (Fbuffer_local_variables): Pass zero.
3407 (clone_per_buffer_values): Pass non-zero.
3408
34092012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3410
3411 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
3412 to make the loop interruptible.
3413
34142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3415
3416 * gnutls.c (emacs_gnutls_handshake): Only retry if
3417 GNUTLS_E_INTERRUPTED.
3418
cce7fefc
DA
34192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3420
3421 Cleanup and convert miscellaneous checks to eassert.
3422 * alloc.c (mark_interval): Fix comment, partially rephrase
3423 old comment from intervals.h (see below).
3424 * intervals.c (find_interval, adjust_intervals_for_insertion)
3425 (delete_interval, adjust_intervals_for_deletion)
3426 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
3427 Convert to eassert.
3428 (adjust_intervals_for_insertion, make_new_interval):
3429 Remove obsolete and unused code.
3430 * intervals.h (struct interval): Remove obsolete comment.
3431 * textprotp.c (erase_properties): Remove unused code.
3432 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
3433 (Fremove_list_of_text_properties): Convert to eassert.
3434
9ea10cc3
CY
34352012-07-17 Chong Yidong <cyd@gnu.org>
3436
3437 * editfns.c (Finsert_char): Doc fix.
3438
3900d5de
DA
34392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3440
3441 Fix previous change to make Fmemory_free always accurate.
3442 * alloc.c (make_interval): Update total_free_intervals.
3443 (make_float): Likewise for total_free_floats.
3444 (free_cons, Fcons): Likewise for total_free_conses.
3445 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
3446 Likewise for total_free_vector_bytes.
3447 (Fmake_symbol): Likewise for total_free_symbols.
3448 (bytes_free): Remove.
3449
7098646f
DA
34502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3451
3452 Simple free memory accounting feature.
3453 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
3454 (sweep_vectors): Accumulate size of free vectors.
3455 (Fgarbage_collect): Setup bytes_free.
3456 (Fmemory_free): New function.
3457 (syms_of_alloc): Register it.
3458
22657b40
DA
34592012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3460
3461 Cleanup overlays checking.
3462 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
3463 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
3464 eassert and OVERLAYP.
3465 (sort_overlays): Change to use OVERLAYP.
3466
ddfc8813
RK
34672012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
3468
3469 * editfns.c (Finsert_char): Make it interactive, and make the
3470 second arg optional. Copy interactive spec and docstring from
3471 ucs-insert.
3472
7c26cf3c
PE
34732012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3474
3475 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
3476 Unlike the other wrapped functions, fabs has an unspecified
3477 effect on errno.
3478
5d127af9
JD
34792012-07-16 Jan Djärv <jan.h.d@swipnet.se>
3480
3481 * nsterm.m (keyDown): Interpret flags without left/right bits
3482 as the left key (Bug#11670).
3483
6a0dd1d7
DA
34842012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3485
3486 Remove empty and useless init functions.
3487 * lisp.h (init_character_once, init_fns, init_image)
3488 (init_filelock, init_sound): Remove prototype.
3489 * character.c (init_character_once): Remove.
3490 * filelock.c (init_filelock): Likewise.
3491 * fns.c (init_fns): Likewise.
3492 * image.c (init_image): Likewise.
3493 * sound.c (init_sound): Likewise.
3494 * emacs.c (main): Adjust accordingly.
3495
7a6136fd
DA
34962012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3497
3498 * gtkutil.h: Tiny cleanups.
3499 (use_old_gtk_file_dialog): Remove useless declaration.
3500 (xg_uses_old_file_dialog): Add suggested const attribute.
3501
ce811ad9
EZ
35022012-07-15 Eli Zaretskii <eliz@gnu.org>
3503
3504 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
3505 (bidi_paragraph_init): Use it to limit search forward for a strong
3506 directional character in abnormally large paragraphs full of
3507 neutral or weak characters. (Bug#11943)
3508
c9adfeaa
SF
35092012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
3510
3511 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
3512 the toolbar (Bug#9451).
3513 (xg_make_tool_item): Give the widget event box a transparent
3514 background.
3515
fff62aa9
DA
35162012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3517
3518 Cleanup basic allocation variables and functions.
3519 * alloc.c (ignore_warnings, init_intervals, init_float)
3520 (init_cons, init_symbol, init_marker): Remove.
3521 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
3522 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
3523 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
3524 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
3525 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
3526 (staticidx, init_alloc_once, init_strings, free_ablock):
3527 Remove redundant initialization.
3528 * fns.c (init_weak_hash_tables): Remove.
3529 * lisp.h (init_weak_hash_tables): Remove prototype.
3530
9730daca
DA
35312012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3532
3533 Use zero_vector where appropriate.
3534 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
3535 accordingly.
3536 * lisp.h (zero_vector): New declaration.
3537 * font.c (null_vector): Remove.
3538 (syms_of_font): Remove initialization and staticpro.
3539 (font_list_entities, font_find_for_lface): Change to use zero_vector.
3540 * keymap.c (Faccessible_keymaps): Likewise.
3541
2e2d2a13
LL
35422012-07-15 Leo Liu <sdl.web@gmail.com>
3543
3544 * fringe.c: Fix typo in comments.
3545
cd276f6e
LL
35462012-07-14 Leo Liu <sdl.web@gmail.com>
3547
3548 * fringe.c: Add a new bitmap exclamation-mark.
3549
5a1131d9
EZ
35502012-07-14 Eli Zaretskii <eliz@gnu.org>
3551
3552 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
3553
3554 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
3555 (HAVE_MENUS): Don't define, defined by editing config.in with
3556 msdos/sed2v2.inp.
3557 (GMALLOC_INHIBIT_VALLOC): Don't define.
3558 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
3559
22e983b7
JB
35602012-07-14 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
3563
5b3f250f
GM
35642012-07-14 Glenn Morris <rgm@gnu.org>
3565
3566 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
3567 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
3568 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
3569
33d63ff4
GM
35702012-07-13 Glenn Morris <rgm@gnu.org>
3571
5b633342
GM
3572 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
3573
33d63ff4
GM
3574 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
3575 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
3576
b55b9f85
JD
35772012-07-13 Jan Djärv <jan.h.d@swipnet.se>
3578
0dc8cf50
JD
3579 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
3580 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
3581 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
3582 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
3583 where appropriate.
3584 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
3585 as boolean expression.
3586 (x_set_window_size): Remove unused variable toolbar.
3587 (ns_get_color_default, ns_mod_to_lisp): Remove.
3588 (ns_mouse_position): Remove unused variables xchar and ychar.
3589 (ns_compute_glyph_string_overhangs): Remove unused variable face.
3590 (ns_set_vertical_scroll_bar): Remove unused variable count.
3591 (ns_delete_terminal): Remove unused variable i.
3592 (ns_term_init): Remove unused variables r, g and b.
3593 (mouseDown): Remove unused variable window.
3594 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
3595 (initFrameFromEmacs): Remove unused variable vbextra.
3596 (mouseEntered): Remove unused variables p and dpyinfo.
3597 (mouseExited): Remove unused variables p and r.
3598 (ns_define_frame_cursor, ns_clear_frame_area)
3599 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
3600 (menuDown): Assign [sender tag] to variable and cast the variable.
3601
3602 * nsterm.h (menuDown): Add id as type to argument sender.
3603 (ns_display_info_for_name): Add Lisp_Object argument.
3604 (ns_term_init): Add Lisp_Object argument.
3605 (ns_map_event_to_object): Add void argument.
3606 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
3607 prototype with arguments and only declare if __OBJC__.
3608 (nxatoms_of_nsselect): Add void argument.
3609 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
3610 (ns_alloc_autorelease_pool): Add void argument.
3611 (ns_release_autorelease_pool): Add void* argument.
3612 (ns_get_defaults_value): Add const char* argument.
3613
3614 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
3615 (initFromContents): Use SSDATA where appropriate.
3616 (ns_update_menubar): Add braces to ambigous if-else.
3617 (initWithTitle): Put () around assignment in if statement.
3618 (ns_menu_show): Remove unused variables window and keymap.
3619 (update_frame_tool_bar): Remove unused variable selected_p.
3620 (initWithContentRect): Remove unused variable this_cmd_name.
3621
3622 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
3623 appropriate.
3624 (setXBMColor): Remove unused variable len.
3625 (setPixmapData): Put () around assignment in loop statement.
3626
3627 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
3628 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
3629 where appropriate.
3630 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
3631 around assignment in loop statement.
3632 (nsfont_open): Remove unused variable i.
3633 (nsfont_open): Remove unused variable len.
3634 (nsfont_draw): Remove unused variable cs.
3635
3636 * nsfns.m (x_set_icon_name, ns_set_name_internal)
3637 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
3638 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
3639 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
3640 (Fns_font_name, Fns_perform_service)
3641 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
3642 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
3643 (ns_set_name): Remove unused variable view.
3644 (x_set_menu_bar_lines): Remove unused variable olines.
3645 (x_set_tool_bar_lines): Remove unused variable root_window.
3646 (Fns_list_colors): Put () around assignment in while statement.
3647 (Fns_perform_service): Remove unused variable len.
3648 (Fns_display_usable_bounds): Remove unused variable top.
3649 (syms_of_nsfns): Remove unused variable i.
3650
b55b9f85
JD
3651 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
3652 memcpy (Bug#11907).
3653
ed9265fc 36542012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
3655
3656 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
3657 and free it with DestroyExceptionInfo (Bug#11558).
3658
ef099b57
JB
36592012-07-13 Juanma Barranquero <lekktu@gmail.com>
3660
3661 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
3662 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
3663 Set here, not in nt/config.nt.
3664
ea814a5d
EZ
36652012-07-13 Eli Zaretskii <eliz@gnu.org>
3666
3667 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
3668 cursor overflow into the last glyph on display line when the right
3669 fringe is off. (Bug#11832)
3670
1a952767
PE
36712012-07-13 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 * xdisp.c (produce_special_glyphs): Now static.
3674 * dispextern.h (produce_special_glyphs): Remove decl.
3675
983188fd
GM
36762012-07-13 Glenn Morris <rgm@gnu.org>
3677
8d7c7eed 3678 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
3679 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
3680
983188fd
GM
3681 * s/usg5-4-common.h (USG, USG5):
3682 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
3683 * s/sol2-6.h (SOLARIS2):
3684 * s/irix6-5.h (IRIX6_5):
3685 * s/hpux10-20.h (USG, USG5, HPUX):
3686 * s/gnu-linux.h (USG, GNU_LINUX):
3687 * s/freebsd.h (BSD_SYSTEM):
3688 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
3689 * s/cygwin.h (CYGWIN):
3690 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
3691 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
3692
d1e68667 36932012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
3694
3695 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 3696
6de0e799
GM
36972012-07-13 Glenn Morris <rgm@gnu.org>
3698
739ae010
GM
3699 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
3700
dbee5793
GM
3701 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
3702
6de0e799
GM
3703 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
3704 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
3705
b82da769
GM
37062012-07-12 Glenn Morris <rgm@gnu.org>
3707
4fae5a7a 3708 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
3709
3710 * process.c (init_process_emacs): Rename from init_process.
3711 The old name is also the name of a Mach system call.
3712 * lisp.h, emacs.c: Update for this name change.
3713 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
3714 longer needed.
3715
5a979817
EZ
37162012-07-12 Eli Zaretskii <eliz@gnu.org>
3717
3718 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
3719 memmove call that removes glyphs covered by the left truncation
3720 glyph. Improve commentary.
3721 (display_line): Fix display of continuation glyphs on GUI frames
3722 when the right fringe is turned off and variable-size fonts are
3723 used in the window. Move the code that appends a stretch glyph to
3724 produce_special_glyphs, so that it could be used for truncation
3725 and continuation glyphs alike.
3726 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
3727 glyph of a suitably computed width, to align the special glyphs at
3728 the window margin. Code moved from display_line. (Bug#11832)
3729
3e91a053
GM
37302012-07-12 Glenn Morris <rgm@gnu.org>
3731
ba9e4b84
GM
3732 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
3733
3734 * s/gnu-linux.h, s/hpux10-20.h:
3735 Do not unconditionally define HAVE_XRMSETDATABASE.
3736
3e91a053
GM
3737 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
3738
b300b1f4
PE
37392012-07-12 Paul Eggert <eggert@cs.ucla.edu>
3740
3741 Fix typos that broke OS X build.
3742 Reported by Randal L. Schwartz in
3743 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
3744 * nsterm.m (ns_timeout): Add missing local decl.
3745 (ns_get_color): snprintf -> sprintf, to fix typo.
3746
6e777848
GM
37472012-07-12 Glenn Morris <rgm@gnu.org>
3748
3f922c37
GM
3749 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
3750 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
3751 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
3752 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
3753
0ab7b23a
GM
3754 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
3755 Move PTY_OPEN to configure.
3756
6e777848
GM
3757 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3758 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
3759 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
3760
4a7edc24
DA
37612012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
3762
3763 Use empty_unibyte_string where applicable.
3764 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
3765 * lread.c (read1): Likewise.
3766 * xsettings.c (syms_of_xsettings): Likewise.
3767
308aab79
GM
37682012-07-12 Glenn Morris <rgm@gnu.org>
3769
42bd1719
GM
3770 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
3771 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
3772 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
3773 * s/hpux10-20.h (RUN_TIME_REMAP):
3774 * s/bsd-common.h (TABDLY): Move to configure.
3775
3776 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
3777
3778 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
3779
ea0bbd17 3780 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 3781 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
3782
3783 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 3784
308aab79
GM
3785 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
3786 * s/template.h: Move NARROWPROTO to configure.
3787
ee1cf5cf
GM
37882012-07-11 Glenn Morris <rgm@gnu.org>
3789
30fe9bf4
GM
3790 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
3791 unused since 2011-01-17 change to systty.h.
3792
ee1cf5cf
GM
3793 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
3794 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3795 Move HAVE_PTYS and HAVE_SOCKETS to configure.
3796
63e47e07
PE
37972012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
3800
c43fb4c3
GM
38012012-07-11 Glenn Morris <rgm@gnu.org>
3802
3803 * s/darwin.h, s/gnu-linux.h, s/template.h:
3804 Move INTERRUPT_INPUT to configure.
3805
e8df9267
DA
38062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3807
3808 Minor adjustments to interning code.
3809 * lisp.h (intern, intern_c_string): Redefine as static inline
3810 wrappers for intern_1 and intern_c_string_1, respectively.
3811 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
3812 * lread.c (intern_1, intern_c_string_1, oblookup):
3813 Simplify Vobarray checking.
e8df9267
DA
3814 * font.c (font_intern_prop): Likewise. Adjust comment.
3815 * w32font.c (intern_font_name): Likewise.
3816
34348bd4
AS
38172012-07-11 Andreas Schwab <schwab@linux-m68k.org>
3818
d96a1e0c
AS
3819 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
3820
34348bd4
AS
3821 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
3822 of Fcar/Fcdr if possible.
3823 * font.c (check_otf_features): Likewise.
3824 * fontset.c (Fnew_fontset): Likewise.
3825 * gnutls.c (Fgnutls_boot): Likewise.
3826 * minibuf.c (read_minibuf): Likewise.
3827 * msdos.c (IT_set_frame_parameters): Likewise.
3828 * xmenu.c (Fx_popup_dialog): Likewise.
3829 * w32menu.c (Fx_popup_dialog): Likewise.
3830
c8add24e
GM
38312012-07-11 Glenn Morris <rgm@gnu.org>
3832
4b575b3c
GM
3833 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
3834 since nothing has defined it on these platforms.
3835
09f4e3b0
GM
3836 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
3837 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
3838
172bedef
GM
3839 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3840 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3841 Move CLASH_DETECTION to configure.
3842
249685df
GM
3843 * s/gnu.h: Remove file, which is now empty.
3844
c8add24e
GM
3845 * s/gnu.h, s/gnu-linux.h:
3846 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
3847
b41253a3
JW
38482012-07-11 John Wiegley <johnw@newartisans.com>
3849
3850 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
3851 function attribute, so we only use it if it exists in the
3852 compiler.
3853
d923b542
DA
38542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3855
3856 Avoid call to strlen in fast_c_string_match_ignore_case.
3857 * search.c (fast_c_string_match_ignore_case): Change to use
3858 length argument. Adjust users accordingly.
3859 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
3860
5ebbef1d
PE
38612012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3862
bb352260
PE
3863 Assume mkdir, rmdir.
3864 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
3865 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
3866
57054ddd
PE
3867 Assume rename.
3868 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
3869
b747d3f7
PE
3870 Assume perror.
3871 * s/hpux10-20.h (HAVE_PERROR): Remove.
3872 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
3873 Remove dummy definition, as this problem was obsolete long ago.
3874
5ebbef1d
PE
3875 Assume strerror.
3876 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
3877
984e7f30
DA
38782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3879
3880 Avoid calls to strlen in font processing functions.
3881 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
3882 (font_open_by_name): Change to use length argument.
3883 Adjust users accordingly.
d923b542
DA
3884 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
3885 Adjust prototypes.
3886 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
3887 Change to return ptrdiff_t.
984e7f30
DA
3888 (xfont_list_pattern, xfont_match): Use length returned by
3889 xfont_decode_coding_xlfd.
3890 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
3891
20e94fdd
GM
38922012-07-11 Glenn Morris <rgm@gnu.org>
3893
9d596af3
GM
3894 * s/darwin.h, s/freebsd.h, s/netbsd.h:
3895 Move DONT_REOPEN_PTY to configure.
3896
20e94fdd
GM
3897 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
3898 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
3899
e99a530f
PE
39002012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3901
22ffb973
PE
3902 Remove "#define unix" that is no longer needed (Bug#11905).
3903 * s/aix4-2.h (unix): Remove; no longer needed.
3904
e9a9ae03
PE
3905 EMACS_TIME simplification (Bug#11875).
3906 This replaces macros (which typically do not work in GDB)
3907 with functions, typedefs and enums, making the code easier to debug.
3908 The functional style also makes code easier to read and maintain.
3909 * systime.h: Include <sys/time.h> on all hosts, not just if
3910 WINDOWSNT, since 'struct timeval' is needed in general.
3911 (EMACS_TIME): Now a typedef, not a macro.
3912 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
3913 not macros.
3914 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
3915 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
3916 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
3917 (EMACS_TIME_LE): Now functions, not macros.
3918 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
3919 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
3920 which are not functions. All uses rewritten to use:
3921 (make_emacs_time): New function.
3922 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
3923 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
3924 not functions. All uses rewritten to use the following, respectively:
3925 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
3926 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 3927 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
3928 * fileio.c (Fcopy_file):
3929 * xterm.c (XTflash): Get the current time closer to when it's used.
3930 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
3931
ffacb126
PE
3932 * bytecode.c (targets): Suppress -Woverride-init warnings.
3933
e99a530f
PE
3934 Simplify by avoiding confusing use of strncpy etc.
3935 * doc.c (Fsnarf_documentation):
3936 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
3937 * frame.c (Fmake_terminal_frame):
3938 * gtkutil.c (get_utf8_string):
3939 * lread.c (openp):
3940 * nsmenu.m (ns_update_menubar):
3941 * regex.c (regerror):
3942 Prefer memcpy to strncpy and strncat when either will do.
3943 * fileio.c (Fsubstitute_in_file_name):
3944 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
3945 (menu_separator_name_p):
3946 * nsmenu.m (ns_update_menubar):
3947 Prefer memcmp to strncmp when either will do.
3948 * nsterm.m: Include <ftoastr.h>.
3949 (ns_get_color):
3950 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3951 Prefer snprintf to strncpy.
3952 * nsterm.m (ns_term_init):
3953 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3954 * nsterm.m (ns_term_init):
3955 Avoid the need for strncpy, by using build_string or
3956 make_unibyte_string directly. Use dtoastr, not snprintf.
3957 * process.c (Fmake_network_process): Diagnose service names that
3958 are too long, rather than silently truncating them or creating
3959 non-null-terminated names.
3960 (Fnetwork_interface_info): Likewise, for interface names.
3961 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3962 Prefer sprintf to strncat.
3963 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3964 Prefer vsnprintf to vsprintf + strncpy.
3965
c59592b3
GM
39662012-07-10 Glenn Morris <rgm@gnu.org>
3967
3968 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3969 Clarify fallback case.
3970
7d7bbefd
DA
39712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3972
3973 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3974 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3975 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3976 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3977 where argument type is known to be a Lisp_Cons.
3978
3a4c8000
TT
39792012-07-10 Tom Tromey <tromey@redhat.com>
3980
3981 * bytecode.c (BYTE_CODE_THREADED): New macro.
3982 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3983 (enum byte_code_op): New type.
3984 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3985 (exec_byte_code): Use them. Use token threading when applicable.
3986
2a0213a6
DA
39872012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3988
3989 Optimize pure C strings initialization.
3990 * lisp.h (make_pure_string): Fix prototype.
3991 (build_pure_c_string): New function, defined as static inline. This
3992 provides a better opportunity to optimize away calls to strlen when
3993 the function is called with compile-time constant argument.
3994 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3995 argument, adjust users accordingly. Use build_pure_c_string where
3996 appropriate.
3997 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3998 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3999 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
4000
cb1caeaf
DA
40012012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4002
4003 Avoid calls to strlen in miscellaneous functions.
4004 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
4005 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
4006 * lread.c (openp): Likewise.
4007
c293e30c
DA
40082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4009
4010 Avoid calls to strlen in path processing functions.
4011 * fileio.c (file_name_as_directory): Add comment. Change to add
4012 srclen argument and return the length of result. Adjust users
4013 accordingly.
4014 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
4015 swap 1st and 2nd arguments to obey the common convention.
4016 Adjust users accordingly.
c293e30c
DA
4017 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
4018
9e059e3f
GM
40192012-07-10 Glenn Morris <rgm@gnu.org>
4020
d02eb359
GM
4021 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
4022 Move PENDING_OUTPUT_COUNT definition to configure.
4023
882cf227
GM
4024 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
4025 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
4026 * s/gnu.h (DATA_START): Move definitions to configure.
4027
af6e839f
GM
4028 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
4029 We include usg5-4-common.h, which defines them both.
4030
40289a12
GM
4031 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
4032 O_RDONLY already includes it).
4033
9e059e3f
GM
4034 Stop ns builds setting the EMACSLOADPATH environment variable.
4035 * nsterm.m (ns_load_path): Rename from ns_init_paths.
4036 Now it does not set EMACSLOADPATH, just returns the load-path string.
4037 * nsterm.h: Update accordingly.
4038 * lread.c [HAVE_NS]: Include nsterm.h.
4039 (init_lread) [HAVE_NS]: Use ns_load_path.
4040 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
4041
7c4e8ec0
GM
40422012-07-09 Glenn Morris <rgm@gnu.org>
4043
d4f600ff
GM
4044 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
4045 since the included bsd-common.h does so.
4046
cbb31951
GM
4047 Stop ns builds setting the EMACSPATH environment variable.
4048 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
4049 (ns_init_paths): Do not set EMACSPATH.
4050 * nsterm.h (ns_exec_path): Add it.
4051 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
4052 Use ns_exec_path.
4053
7c4e8ec0
GM
4054 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
4055
26bccfae
PE
40562012-07-09 Paul Eggert <eggert@cs.ucla.edu>
4057
a0bee46f
PE
4058 * process.c (wait_reading_process_output): 'waitchannels' was unset
4059 when read_kbd || !NILP (wait_for_cell); fix this.
4060
5994c183
PE
4061 Add GCC-style 'const' attribute to functions that can use it.
4062 * character.h (char_resolve_modifier_mask):
4063 * keyboard.h (make_ctrl_char):
4064 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
4065 (init_character_once, next_almost_prime, init_fns, init_image)
4066 (flush_pending_output, init_sound):
4067 * mem-limits.h (start_of_data):
4068 * menu.h (finish_menu_items):
4069 Add ATTRIBUTE_CONST.
4070 * emacs.c (DEFINE_DUMMY_FUNCTION):
4071 Declare the dummy function with ATTRIBUTE_CONST.
4072 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
4073 Add decls with ATTRIBUTE_CONST.
4074
26bccfae
PE
4075 Minor improvements to make_formatted_string.
4076 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
4077 where int is good enough, as vsprintf returns an int.
4078 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
4079
a8290ec3
DA
40802012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4081
4082 Use make_formatted_string to avoid double length calculation.
4083 * lisp.h (make_formatted_string): New prototype.
4084 * alloc.c (make_formatted_string): New function.
4085 * buffer.c (Fgenerate_new_buffer_name): Use it.
4086 * dbus.c (syms_of_dbusbind): Likewise.
4087 * editfns.c (Fcurrent_time_zone): Likewise.
4088 * filelock.c (get_boot_time): Likewise.
4089 * frame.c (make_terminal_frame, set_term_frame_name)
4090 (x_report_frame_params): Likewise.
4091 * image.c (gs_load): Likewise.
4092 * minibuf.c (get_minibuffer): Likewise.
4093 * msdos.c (dos_set_window_size): Likewise.
4094 * process.c (make_process): Likewise.
4095 * xdisp.c (ensure_echo_area_buffers): Likewise.
4096 * xsettings.c (apply_xft_settings): Likewise.
4097
d01ba2f1
GM
40982012-07-09 Glenn Morris <rgm@gnu.org>
4099
4100 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4101 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4102 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4103 * nsterm.h (ns_etc_directory): Add it.
4104 * callproc.c [HAVE_NS]: Include nsterm.h.
4105 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4106
f1f924b6
DA
41072012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4108
4109 Move marker debugging code under MARKER_DEBUG.
4110 * marker.c (MARKER_DEBUG): Move marker debugging code under
4111 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4112 for bootstrap with --enable-checking (~3x slowdown reported
4113 by Juanma Barranquero <lekktu@gmail.com>).
4114 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4115
ab531b66
PE
41162012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4117
4118 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4119 See <http://bugs.gnu.org/11825#29>.
4120
c4b3bc8a
EZ
41212012-07-08 Eli Zaretskii <eliz@gnu.org>
4122
4123 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4124 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4125 (display_line): Add commentary about displaying truncation glyphs
4126 on GUI frames.
4127 (produce_special_glyphs): Move here from term.c.
4128
4129 * term.c (produce_special_glyphs): Move to xdisp.c.
4130
4131 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4132 section.
c4b3bc8a 4133
b676b881
AS
41342012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4135
f17c5273
AS
4136 * xdisp.c (display_line): Avoid warning about implicit declaration
4137 of FRAME_FONT.
4138
298819b9
AS
4139 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4140
b676b881
AS
4141 * lisp.h: Remove empty conditional.
4142
6045c4fd
PE
41432012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4144
b3350bf9
PE
4145 * lread.c (load_path_check): Now static.
4146
6045c4fd
PE
4147 Fix some minor --with-ns problems found by static checking.
4148 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4149 (x_set_font) [!HAVE_X_WINDOWS]:
4150 * image.c (xpm_load_image) [HAVE_NS]:
4151 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4152 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4153 Remove unused local.
4154 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4155 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4156 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4157 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4158 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4159 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4160 Fix pointer signedness problem.
4161 * xfaces.c (FRAME_X_FONT_TABLE):
4162 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4163
929e7845
GM
41642012-07-07 Glenn Morris <rgm@gnu.org>
4165
4166 * lread.c (load_path_check): New function, split from init_lread.
4167 (init_lread): Reorganize. Motivation:
4168 If EMACSLOADPATH is set, check/warn about that rather than the
4169 defaults, which we are not going to use. Hence we can remove
4170 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4171 Don't warn if site-lisp directories are missing.
4172 If not installed, start from a blank load-path, since
4173 PATH_LOADSEARCH refers to the eventual installation directories.
4174
58dd0aa4
EZ
41752012-07-07 Eli Zaretskii <eliz@gnu.org>
4176
4177 Support truncation and continuation glyphs on GUI frames, when
4178 fringes are disabled. (Bug#11832)
4179 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4180 continuation glyphs even if on GUI frames.
4181 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4182 or both, are absent.
4183 (start_display, move_it_in_display_line_to): Handle the case of a
4184 GUI frame without a fringe to display continuation or truncation
4185 glyphs.
4186 (insert_left_trunc_glyphs): Support GUI frames: make sure
4187 truncation glyphs overwrite enough glyphs from the current line to
4188 have sufficient space in pixels.
4189 (display_line): Support truncation and continuation glyphs on GUI
4190 frames. If some spare pixels are left on the line after inserting
4191 the truncation glyphs, fill that space with a stretch glyph of a
4192 suitably computed width.
4193
4194 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4195 produce_glyphs, to support GUI sessions.
4196
31571fd7
PE
41972012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4198
5a16b9bc
PE
4199 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4200
f3047c75
PE
4201 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4202
31571fd7
PE
4203 Do not require float-time's arg to fit in time_t (Bug#11825).
4204 This works better on hosts where time_t is unsigned, and where
4205 float-time is applied to the (negative) difference between two times.
4206 * editfns.c (decode_time_components): Last arg is now double *,
4207 not int *, and means to store all the result as a double, without
4208 worrying about whether the seconds part fits in time_t.
4209 All callers changed.
4210 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4211 All callers changed.
4212 (Ffloat_time): Do not fail merely because the specified time falls
4213 outside of time_t range.
4214
4516fbef
GM
42152012-07-07 Glenn Morris <rgm@gnu.org>
4216
4217 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4218 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4219 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4220
07adc2c6
JB
42212012-07-07 Juanma Barranquero <lekktu@gmail.com>
4222
4223 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4224 Update dependencies.
4225
4226 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4227
fd573f31
PE
42282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4229
fee5959d
PE
4230 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4231 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4232 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4233 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4234 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4235 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4236
fd573f31
PE
4237 * xfont.c (compare_font_names): Redo to omit the need for casts.
4238
ddadbc0e
AS
42392012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4240
fca8d6b6
AS
4241 * xfns.c (Fx_change_window_property): Doc fix.
4242 * w32fns.c (Fx_change_window_property): Doc fix.
4243
ddadbc0e
AS
4244 * w32fns.c (Fx_window_property): Accept the same arguments as the
4245 X Windows version. Doc fix.
4246 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4247
ed9265fc 42482012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4249 Eli Zaretskii <eliz@gnu.org>
4250
4251 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4252 Windows-specific code from nt/config.nt moved here.
4253 Obsolete settings removed.
4254
216ee680
PE
42552012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * process.c: Avoid unnecessary calls to gettime.
4258 (wait_reading_process_output): Don't get the time of day
4259 when gobbling data immediately and not waiting, as there's no need
4260 for it in that case. This removes a FIXME.
4261
bdd091e4
JD
42622012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4263
4264 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4265 is defined (Bug#11768).
4266
9d44f8ce
DA
42672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4268
4269 Fix marker debugging code.
4270 * marker.c (byte_char_debug_check): Do not perform the check
4271 if buffer is not multibyte.
090bd7cb
JB
4272 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4273 Call byte_char_debug_check with correct arguments.
9d44f8ce 4274
90fc4786
DA
42752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4276
4277 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4278 * marker.c (byte_char_debug_check, count_markers):
4279 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4280 (byte_debug_flag): Remove.
4281 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4282 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4283
7b7ae965
DA
42842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4285
4e57b342
DA
4286 Avoid code repetition in marker-related functions.
4287 * marker.c (attach_marker): New function.
4288 (Fset_marker, set_marker_restricted, set_marker_both)
4289 (set_marker_restricted_both): Use it.
4290 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4291 Consistently rename charno to charpos.
4292 (marker_position): Add eassert.
4293 (marker_byte_position): Convert to eassert.
4294
42952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4296
4297 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4298 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4299 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4300
657924ff
DA
43012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4302
4303 Introduce fast path for the widely used marker operation.
4304 * alloc.c (build_marker): New function.
4305 * lisp.h (build_marker): New prototype.
4306 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4307 * composite.c (autocmp_chars): Likewise.
4308 * editfns.c (buildmark): Remove.
4309 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4310 (save_restriction_save): Use build_marker.
4311 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4312 * window.c (save_window_save): Likewise.
4313
041a49a6
DA
43142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4315
4316 Do not use Fdelete_overlay in delete_all_overlays
4317 to avoid redundant calls to unchain_overlay.
4318 * buffer.c (drop_overlay): New function.
4319 (delete_all_overlays, Fdelete_overlay): Use it.
4320 * minibuf.c (get_minibuffer): Fix comment.
4321
7dca65a4
PE
43222012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 Port to OpenBSD 5.1 amd64.
4325 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4326 This is needed for OpenBSD, and should be harmless on all BSD systems.
4327 Also, include <sys/sysctl.h>, as it should be available on all
4328 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
4329 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
4330 use p_pid member, not kp_proc.pid.
4331
8eb876e2
GM
43322012-07-06 Glenn Morris <rgm@gnu.org>
4333
4334 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
4335
38182d90
PE
43362012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4337
4338 More xmalloc and related cleanup.
4339 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
4340 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
4341 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
4342 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
4343 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
4344 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
4345 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
4346 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
4347 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
4348 * xterm.c:
4349 Omit needless casts involving void * pointers and allocation.
4350 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
4351 as the former is more robust if P's type is changed.
4352 Prefer xzalloc to xmalloc + memset 0.
4353 Simplify malloc-or-realloc to realloc.
4354 Don't worry about xmalloc returning a null pointer.
4355 Prefer xstrdup to xmalloc + strcpy.
4356 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
4357 growing it.
4358 * keyboard.c (apply_modifiers_uncached): Prefer local array to
4359 alloca of a constant.
4360
6dd5a677
EZ
43612012-07-05 Eli Zaretskii <eliz@gnu.org>
4362
4363 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4364 hscroll is larger than the line width. Fixes long and futile
4365 looping inside extend_face_to_end_of_line (on a TTY) producing
4366 glyphs that are not needed and thrown away.
4367
6b312f0f
DA
43682012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4369
4370 * marker.c (set_marker_restricted_both): Simplify by using
4371 clip_to_bounds.
4372
f520ef9b
PE
43732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4374
4375 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4376
383b7c95
JD
43772012-07-05 Jan Djärv <jan.h.d@swipnet.se>
4378
4379 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4380 not defined (Bug#11768).
4381 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
4382 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
4383 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
4384 followed by gtk_box_set_homogeneous (Bug#11768).
4385 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
4386 (update_theme_scrollbar_width, xg_create_scroll_bar):
4387 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
4388 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
4389 (is_box_type): New function (Bug#11768).
4390 (xg_tool_item_stale_p): Call is_box_type.
5293d758 4391 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
4392 with default display (Bug#11768).
4393
d6e7bf45
EZ
43942012-07-05 Eli Zaretskii <eliz@gnu.org>
4395
4396 * xdisp.c (window_hscroll_limited): New function.
4397 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
4398 coordinates when window's hscroll is set to insanely large
4399 values. (Bug#11857)
4400
431391ec
JB
44012012-07-05 Juanma Barranquero <lekktu@gmail.com>
4402
4403 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
4404 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
4405
23f86fce
DA
44062012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4407
4408 Cleanup xmalloc.
4409 * lisp.h (xzalloc): New prototype. Omit needless casts.
4410 * alloc.c (xzalloc): New function. Omit needless casts.
4411 * charset.c: Omit needless casts. Convert all calls to
4412 xmalloc with following memset to xzalloc.
4413 * dispnew.c: Likewise.
4414 * fringe.c: Likewise.
4415 * image.c: Likewise.
4416 * sound.c: Likewise.
4417 * term.c: Likewise.
4418 * w32fns.c: Likewise.
4419 * w32font.c: Likewise.
4420 * w32term.c: Likewise.
4421 * xfaces.c: Likewise.
4422 * xfns.c: Likewise.
4423 * xterm.c: Likewise.
4424 * atimer.c: Omit needless casts.
4425 * buffer.c: Likewise.
4426 * callproc.c: Likewise.
4427 * ccl.c: Likewise.
4428 * coding.c: Likewise.
4429 * composite.c: Likewise.
4430 * doc.c: Likewise.
4431 * doprnt.c: Likewise.
4432 * editfns.c: Likewise.
4433 * emacs.c: Likewise.
4434 * eval.c: Likewise.
4435 * filelock.c: Likewise.
4436 * fns.c: Likewise.
4437 * gtkutil.c: Likewise.
4438 * keyboard.c: Likewise.
4439 * lisp.h: Likewise.
4440 * lread.c: Likewise.
4441 * minibuf.c: Likewise.
4442 * msdos.c: Likewise.
4443 * print.c: Likewise.
4444 * process.c: Likewise.
4445 * region-cache.c: Likewise.
4446 * search.c: Likewise.
4447 * sysdep.c: Likewise.
4448 * termcap.c: Likewise.
4449 * terminal.c: Likewise.
4450 * tparam.c: Likewise.
4451 * w16select.c: Likewise.
4452 * w32.c: Likewise.
4453 * w32reg.c: Likewise.
4454 * w32select.c: Likewise.
4455 * w32uniscribe.c: Likewise.
4456 * widget.c: Likewise.
4457 * xdisp.c: Likewise.
4458 * xmenu.c: Likewise.
4459 * xrdb.c: Likewise.
4460 * xselect.c: Likewise.
4461
0497dc44
PE
44622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 * fileio.c (time_error_value): Check the right error number.
4465 Problem reported by Troels Nielsen in
4466 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
4467
356e7178
PE
44682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4469
4e71fd89
PE
4470 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
4471 This should be fixed in a better way; see Eli Zaretskii in
4472 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
4473 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
4474
f0941253
PE
4475 * fileio.c (time_error_value): Rename from special_mtime.
4476 The old name's problems were noted by Eli Zaretskii in
4477 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
4478
065c9eb4
PE
4479 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
4480 This variable's comment says Emacs needs at least one GDB-visible
4481 symbol of type enum pvec_type, to work around GDB problems.
4482 The symbol's value doesn't matter.
4483
356e7178
PE
4484 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
4485 that causes compilation to fail on pre-C99 compilers.
4486
ed9265fc 44872012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
4488
4489 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
4490 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
4491
3884d954
DA
44922012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4493
d209e2fb 4494 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
4495 headers for buffer_defaults and buffer_local_symbols.
4496 Reported by Juanma Barranquero <lekktu@gmail.com>.
4497
ee28be33
SM
44982012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4499
4500 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
4501 * lisp.h (enum pvec_type): Use fewer bits.
4502 (PSEUDOVECTOR_SIZE_BITS): New constant.
4503 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
4504 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
4505 change in pvec_type.
4506 (PSEUDOVECTOR_TYPEP): New macro.
4507 (TYPED_PSEUDOVECTORP): Use it.
4508 * fns.c (internal_equal): Adapt code to extract pvectype.
4509 * emacs.c (gdb_pvec_type): Update type.
4510 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
4511 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
4512 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
4513 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
4514 (sweep_vectors): Use it. Use local var `total_bytes' instead of
4515 abusing vector->header.next.nbytes.
4516 (live_vector_p): Use PVEC_TYPE.
4517 (mark_object): Adapt code to extract pvectype. Use switch.
4518
c7f2cd7f
PE
45192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
4522 Tighten new eassert a bit.
4523
8ce70ed2
DA
45242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4525
4526 Fix compilation with --enable-gcc-warnings and -O1
4527 optimization level.
4528 * doprnt.c (doprnt): Change type of tem to int, initialize
4529 to avoid compiler warning. Add eassert.
4530 * search.c (simple_search): Initialize match_byte to avoid
4531 compiler warning. Add eassert.
4532
dea7f1e5
PE
45332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4534
24a212eb
PE
4535 Avoid weird behavior with large horizontal scrolls.
4536 Without this change, for example, large hscroll values would
4537 mess up Emacs's display on Fedora 15 x86, presumably due to
4538 overflows in int calculations in the display code.
4539 Also, if buffers had long lines, Emacs would freeze.
4540 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
4541 (set_window_hscroll): New function, containing the old guts of
4542 Fset_window_hscroll. Return the clipped value.
4543 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
4544 This avoids the need to check against PTRDIFF_MAX.
4545
dea7f1e5
PE
4546 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
4547
76046526
DA
45482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4549
4550 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
4551
39adff0d
PE
45522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4553
63807d47
PE
4554 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
4555 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
4556 since GCC 4.4.6 issues a bogus warning for them.
4557
39adff0d
PE
4558 Fix bugs in file timestamp newness comparisons.
4559 * fileio.c (Ffile_newer_than_file_p):
4560 * lread.c (Fload): Use full timestamp resolution of files,
4561 not just the 1-second resolution, so that files that are only
4562 slightly newer still count as newer.
4563 * fileio.c (Ffile_newer_than_file_p): Don't assume file
4564 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
4565
dbeed9a6
PE
45662012-07-03 Paul Eggert <eggert@cs.ucla.edu>
4567
4568 * fileio.c: Improve handling of file time marker. (Bug#11852)
4569 (special_mtime): New function.
4570 (Finsert_file_contents, Fverify_visited_file_modtime):
4571 Use it to set special mtime values consistently.
4572
636334d6
AS
45732012-07-03 Andreas Schwab <schwab@linux-m68k.org>
4574
4575 * fileio.c (Finsert_file_contents): Properly handle st_mtime
4576 marker for non-existing file. (Bug#11852)
4577
e2017fe2
GM
45782012-07-03 Glenn Morris <rgm@gnu.org>
4579
4580 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
4581 and did not make it into globals.h).
4582
404dbd37
TT
45832012-07-03 Tom Tromey <tromey@redhat.com>
4584
4585 * window.c (Fset_window_margins, Fset_window_fringes)
4586 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
4587 * textprop.c (Fprevious_property_change): No longer static.
4588 * syntax.c (Fsyntax_table_p): No longer static.
4589 * process.c (Fget_process, Fprocess_datagram_address): No longer
4590 static.
4591 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
4592 * keyboard.c (Fcommand_execute): No longer static.
4593 Remove EXFUN.
4594 * insdel.c (Fcombine_after_change_execute): No longer static.
4595 * image.c (Finit_image_library): No longer static.
4596 * fileio.c (Fmake_symbolic_link): No longer static.
4597 * eval.c (Ffetch_bytecode): No longer static.
4598 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
4599 * doc.c (Fdocumentation_property, Fsnarf_documentation):
4600 No longer static.
404dbd37
TT
4601 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
4602 static.
4603 * dired.c (Ffile_attributes): No longer static.
4604 * composite.c (Fcomposition_get_gstring): No longer static.
4605 * callproc.c (Fgetenv_internal): No longer static.
4606
4607 * ccl.h: Remove EXFUNs.
4608 * buffer.h: Remove EXFUNs.
4609 * dispextern.h: Remove EXFUNs.
4610 * intervals.h: Remove EXFUNs.
4611 * fontset.h: Remove EXFUN.
4612 * font.h: Remove EXFUNs.
4613 * dosfns.c (system_process_attributes): Remove EXFUN.
4614 * keymap.h: Remove EXFUNs.
4615 * lisp.h: Remove EXFUNs.
4616 * w32term.h: Remove EXFUNs.
4617 * window.h: Remove EXFUNs.
4618 * xsettings.h: Remove EXFUN.
4619 * xterm.h: Remove EXFUN.
4620
8e4fd1e1
GM
46212012-07-03 Glenn Morris <rgm@gnu.org>
4622
4623 * lisp.h (Frandom): Make it visible to C.
4624 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
4625 buffer for invisible buffers. (Bug#1229)
4626
ca95b3eb
DA
46272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4628
4629 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
4630 values which aren't power of 2.
14ae4239
BT
4631 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
4632 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
4633 accordingly.
4634
7555c33f
SM
46352012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
4636
4637 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
4638
4639 * alloc.c (mark_object): Revert part of last patch to use `switch'.
4640
d12e8f5a
DA
46412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4642
4643 * alloc.c (allocate_vector_block): Remove redundant
4644 calls to mallopt if DOUG_LEA_MALLOC is defined.
4645 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
4646 avoid calls to mallopt if zero_vector is returned.
4647
296094c3
DA
46482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4649
4650 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
4651 is enabled, avoid dereferencing NULL current_sblock if
4652 running undumped.
4653
36429c89
DA
46542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4655
4656 Cleanup basic buffer management.
4657 * buffer.h (struct buffer): Change layout to use generic vector
4658 marking code. Fix some comments. Change type of 'clip_changed'
4659 to bitfield. Remove unused #ifndef old.
4660 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
4661 (GET_OVERLAYS_AT): Fix indentation.
4662 (for_each_per_buffer_object_at): New macro.
4663 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
4664 (Fbuffer_local_variables): Use it.
4665 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
4666 * alloc.c (allocate_buffer): Adjust to match new layout of
4667 struct buffer. Fix comment.
4668 (mark_overlay): New function.
4669 (mark_buffer): Use it. Use mark_vectorlike to mark normal
4670 Lisp area of struct buffer.
4671 (mark_object): Use it. Adjust marking of misc objects
4672 and related comments.
4673
3b3e4cac
PE
46742012-07-02 Paul Eggert <eggert@cs.ucla.edu>
4675
4676 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
4677 wrapper that is not needed because the wrapped code is a no-op (zero
4678 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
4679 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
4680
cf5c0175
DA
46812012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
4682
4683 * alloc.c (mark_buffer): Simplify. Remove prototype.
4684 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 4685 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
4686 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
4687 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 4688
ca26824c
GM
46892012-06-30 Glenn Morris <rgm@gnu.org>
4690
2e4c5312
GM
4691 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4692
ca26824c
GM
4693 * epaths.in (PATH_SITELOADSEARCH): New.
4694 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
4695 This is rather than relying on --enable-locallisppath elements
4696 having "site-lisp" in their names. (Bug#10208#25, 11658)
4697
0d23c240
EZ
46982012-06-30 Eli Zaretskii <eliz@gnu.org>
4699
c9240d7a
EZ
4700 * w32proc.c (sys_select): Accept and ignore one more argument.
4701
4702 * w32.c (emacs_gnutls_pull): Call select with one more argument.
4703
0d23c240 4704 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 4705 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
4706
4707 * sysdep.c: Don't include dos.h and dosfns.h.
4708
4709 * process.c (sys_select):
4710 * msdos.c (sys_select): Accept one more argument and ignore it.
4711
4712 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
4713 adapt data types and code to that.
4714
4715 * dosfns.c:
4716 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
4717 which clashes with the gnulib function of the same name.
4718
af5a5a98
AS
47192012-06-30 Andreas Schwab <schwab@linux-m68k.org>
4720
c5e4379c
AS
4721 * font.c (font_style_to_value, font_style_symbolic)
4722 (font_prop_validate_style): Add type checks for values in
4723 font_style_table.
4724
af5a5a98
AS
4725 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
4726 argument.
4727 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
4728 uses.
4729
8d38f461
EZ
47302012-06-29 Eli Zaretskii <eliz@gnu.org>
4731
2e5a6631
EZ
4732 * xdisp.c (try_window_id): Undo last change.
4733
8d38f461
EZ
4734 * w32.c (getwd): Adjust commentary about startup_dir.
4735 (init_environment): Always call sys_access, even in non-MSVC
4736 builds. Don't chdir to the directory of the Emacs executable.
4737 This undoes code from 1997 which was justified by the need to
4738 "avoid conflicts when removing and renaming directories". But its
4739 downside was that every relative file name was being interpreted
4740 relative to the directory of the Emacs executable, which can never
4741 be TRT. In particular, it broke sys_access when called with
4742 relative file names.
4743 (sys_access): Map GetLastError to errno.
4744
2af3565e
DA
47452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4746
4747 * window.h (struct window): Change type of 'fringes_outside_margins'
4748 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 4749 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
4750 Adjust comment.
4751 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
4752 to ptrdiff_t.
4753
c8d3a25c 47542012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 4755
c8d3a25c
GM
4756 * gnutls.c (emacs_gnutls_handshake):
4757 Add QUIT to make the loop interruptible.
57570cd3 4758
c8d3a25c 47592012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 4760
c8d3a25c
GM
4761 * charset.c (init_charset): Make lack of etc/charsets fatal.
4762
3e984ee8
DA
47632012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4764
4765 * editfns.c (region_limit): Fix type mismatch.
4766
ef884f23
DA
47672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4768
4769 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4770 undefined. Convert from xassert to eassert.
4771 * nsmenu.m: Convert from xassert to eassert.
4772 * nsterm.m: Likewise.
4773
7d7e0027
SM
47742012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
4775
4776 * editfns.c (region_limit): Clip to narrowing (bug#11770).
4777
aa754e6a
PE
47782012-06-28 Paul Eggert <eggert@cs.ucla.edu>
4779
4780 Avoid integer overflow on scroll-left and scroll-right.
4781 * window.c (HSCROLL_MAX): New macro.
4782 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
4783 overflow when requested scroll falls outside ptrdiff_t range.
4784
80b00b08
DA
47852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4786
4787 * window.h (struct window): Change type of 'hscroll',
4788 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
4789 'last_modified' and 'last_overlay_modified' to EMACS_INT.
4790 Adjust users accordingly.
4791 * xdisp.c (try_cursor_movement): Replace type check with eassert.
4792 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
4793 from EMACS_INT to ptrdiff_t.
4794 (make_window): Omit redundant initialization.
4795
62b2bcf6
JB
47962012-06-28 Juanma Barranquero <lekktu@gmail.com>
4797
4798 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
4799
45942c7d
DA
48002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4801
4802 * window.h (struct window): Change type of 'use_time' and
4803 'sequence_number' from Lisp_Object to int.
4804 * frame.c (make_frame): Adjust users accordingly.
4805 * print.c (print_object): Likewise.
4806 * window.c (select_window, Fwindow_use_time, make_parent_window)
4807 (make_window): Likewise.
4808
e509cfa6
DA
48092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4810
4811 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4812 enabled with --enable-checking=[all,glyphs] configure option.
4813 Fix GLYPH_DEBUG usage assuming that it may be undefined,
4814 adjust comments accordingly.
4815 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
4816 undefined, adjust comments accordingly.
4817 * image.c: Likewise.
4818 * scroll.c: Likewise.
4819 * w32fns.c: Likewise.
4820 * w32term.c: Likewise.
4821 * xdisp.c: Likewise.
4822 * xfaces.c: Likewise.
4823 * xfns.c: Likewise.
4824 * xterm.c: Likewise.
4825
a54e2c05
DA
48262012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4827
4828 Generalize run-time debugging checks.
4829 * dispextern.h (XASSERTS): Remove.
4830 * fontset.c (xassert): Remove.
4831 Convert from xassert to eassert.
4832 * alloc.c: Convert from xassert to eassert.
4833 * bidi.c: Likewise.
4834 * dispnew.c: Likewise.
4835 * fns.c: Likewise.
4836 * fringe.c: Likewise.
4837 * ftfont.c: Likewise.
4838 * gtkutil.c: Likewise.
4839 * image.c: Likewise.
4840 * keyboard.c: Likewise.
4841 * menu.c: Likewise.
4842 * process.c: Likewise.
4843 * scroll.c: Likewise.
4844 * sound.c: Likewise.
4845 * term.c: Likewise.
4846 * w32console.c: Likewise.
4847 * w32fns.c: Likewise.
4848 * w32term.c: Likewise.
4849 * window.c: Likewise.
4850 * xdisp.c: Likewise.
4851 * xfaces.c: Likewise.
4852 * xfns.c: Likewise.
4853 * xselect.c: Likewise.
4854 * xterm.c: Likewise.
4855
1ec4b7b2
SM
48562012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
4857
4858 * fns.c (maybe_resize_hash_table): Output message when growing the
4859 purify-hashtable.
4860
2014308a
DA
48612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4862
4863 * alloc.c (allocate_string_data): Remove dead code.
4864 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
4865 avoid GCC warning about unused macro.
4866
246155eb
DA
48672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4868
4869 * alloc.c (allocate_string): Omit intervals initialization.
4870 * alloc.c (make_uninit_multibyte_string): Initialize intervals
4871 as in make_pure_string and make_pure_c_string.
4872
43184b7b
DA
48732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4874
d209e2fb 4875 * alloc.c (allocate_string): Fix last change.
43184b7b 4876
3fe6dd74
DA
48772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4878
d209e2fb 4879 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
4880 to memset, add explicit initialization where appropriate.
4881
1ba6038a
GM
48822012-06-27 Glenn Morris <rgm@gnu.org>
4883
4884 * lisp.mk (lisp): Remove paths.elc.
4885
c89926a5
CY
48862012-06-27 Chong Yidong <cyd@gnu.org>
4887
4888 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4889
ed6b3510
JW
48902012-06-26 John Wiegley <johnw@newartisans.com>
4891
1ec4b7b2 4892 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
4893 on Mac OS X Lion: __mod_init_func and __mod_term_func.
4894
ed6b3510
JW
4895 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
4896 when building with Clang.
4897
8edd4a2b
SM
48982012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
4899
4900 * eval.c (Fapply): Allow calling it with a single argument.
4901
f6f62d1b
EZ
49022012-06-26 Eli Zaretskii <eliz@gnu.org>
4903
4904 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
4905 _stricmp and _strnicmp.
4906 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
4907
62efea5e
DA
49082012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4909
4910 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4911 allocated window.
4912 (allocate_process): Likewise for new process.
8edd4a2b 4913 (allocate_terminal): Change to use offsetof.
62efea5e
DA
4914 (allocate_frame): Likewise.
4915 * frame.c (make_frame): Omit redundant initialization.
4916 * window.c (make_parent_window): Use memset.
4917 (make_window): Omit redundant initialization.
4918 * process.c (make_process): Omit redundant initialization.
4919 * terminal.c (create_terminal): Likewise.
4920
42997f4d
DA
49212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4922
4923 * term.c (delete_tty): Remove redundant call to memset.
4924
1130ecfc
DA
49252012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4926
4927 * alloc.c: Remove build_string.
4928 * lisp.h: Define build_string as static inline. This provides
4929 a better opportunity to optimize away calls to strlen when the
4930 function is called with compile-time constant argument.
4931 * image.c (imagemagick_error): Convert to build_string.
4932 * w32proc.c (sys_spawnve): Likewise.
4933 * xterm.c (x_term_init): Likewise.
4934
cf38a720
PE
49352012-06-26 Paul Eggert <eggert@cs.ucla.edu>
4936
99027bdd
PE
4937 Use sprintf return value instead of invoking strlen on result.
4938 In the old days this wasn't portable, since some sprintf
4939 implementations returned char *. But they died out years ago and
4940 Emacs already assumes sprintf returns int.
4941 Similarly for float_to_string.
4942 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
4943 * ccl.c (ccl_driver):
4944 * character.c (string_escape_byte8):
4945 * data.c (Fnumber_to_string):
4946 * doprnt.c (doprnt):
4947 * print.c (print_object):
4948 * xdisp.c (message_dolog):
4949 * xfns.c (syms_of_xfns):
4950 Use sprintf or float_to_string result to avoid need to call strlen.
4951 * data.c (Fnumber_to_string):
4952 Use make_unibyte_string, since the string must be ASCII.
4953 * lisp.h, print.c (float_to_string): Now returns int length.
4954 * term.c (produce_glyphless_glyph):
4955 Use sprintf result rather than recomputing it.
4956
cf38a720
PE
4957 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4958 * Makefile.in (ALL_CFLAGS):
4959 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4960 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4961
3511c784
DA
49622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4963
0a08eb21 4964 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4965 strcasecmp if available.
4966 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4967
fb7da12e
AS
49682012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4969
4970 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4971 Avoid comma operator.
4972 * menu.c (push_submenu_start, push_submenu_end)
4973 (push_left_right_boundary, push_menu_pane): Likewise.
4974 * msdos.c (dos_rawgetc): Likewise.
4975
afa2ffd8
DA
49762012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4977
4978 * xfns.c (xic_create_fontsetname): Remove redundant calls
4979 to memset.
4980
b3b4476b
PE
49812012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4982
4495ff38
PE
4983 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4984 sprintf already null-terminates its output.
4985
b3b4476b
PE
4986 * xfns.c (x_window): Remove redundant cast.
4987
b00876c9
DA
49882012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4989
4990 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4991 `const char *' to `char *' to avoid compiler warning.
4992
d188e26b
PE
49932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4994
885d1d74
PE
4995 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4996 instead of truncating it to 63 (admittedly a generous limit).
4997
d188e26b
PE
4998 * process.c: Fix spelling and caps in comments.
4999
e2f560b1
DN
50002012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
5001
e86db54b 5002 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
5003 * sysdep.c (setpgrp): Remove definition, not used in this file.
5004
7583a3a1
JB
50052012-06-24 Juanma Barranquero <lekktu@gmail.com>
5006
5007 * makefile.w32-in: Update dependencies.
5008
696056c2
EZ
50092012-06-24 Eli Zaretskii <eliz@gnu.org>
5010
5011 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
5012 (SYSTIME_H): Add nt/inc/sys/time.h.
5013
5014 * systime.h [WINDOWSNT]: Include sys/time.h.
5015
5016 * s/ms-w32.h (struct timespec): Definition moved from
5017 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
5018
845ca893
PE
50192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5020
5021 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
5022 * buffer.h (buffer_slot_type_mismatch):
5023 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5024 * eval.c (unwind_to_catch):
5025 * image.c (my_png_error, my_error_exit):
5026 * keyboard.c (quit_throw_to_read_char, user_error)
5027 (Fexit_recursive_edit, Fabort_recursive_edit):
5028 * lisp.h (die, args_out_of_range, args_out_of_range_3)
5029 (wrong_type_argument, buffer_overflow, __executable_start)
5030 (memory_full, buffer_memory_full, string_overflow, Fthrow)
5031 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
5032 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
5033 (fatal):
5034 (child_setup) [!DOS_NT]:
5035 * lread.c (end_of_file_error, invalid_syntax):
5036 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5037 * puresize.h (pure_write_error):
5038 * search.c (matcher_overflow):
5039 * sound.c (sound_perror, alsa_sound_perror):
5040 * sysdep.c, syssignal.h (croak):
5041 * term.c (maybe_fatal, vfatal):
5042 * textprop.c (text_read_only):
5043 * undo.c (user_error):
5044 * unexmacosx.c (unexec_error):
5045 * xterm.c (x_ins_del_lines, x_delete_glyphs):
5046 Use _Noreturn rather than NO_RETURN.
5047 No need for separate decl merely because of _Noreturn.
5048 * sound.c (sound_warning, parse_sound):
5049 Remove unnecessary forward decls.
5050
f1dd8073
PE
50512012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5052
5053 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
5054 * lisp.h (WAIT_READING_MAX): New macro.
5055 * dispnew.c (Fsleep_for, sit_for):
5056 * keyboard.c (kbd_buffer_get_event):
5057 * process.c (Faccept_process_output):
5058 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
5059 This improves on the previous patch, which introduced a bug
5060 when time_t is unsigned and as wide as intmax_t.
5061 See <http://bugs.gnu.org/9000#51>.
5062
b82c1755
EZ
50632012-06-23 Eli Zaretskii <eliz@gnu.org>
5064
5065 * dispnew.c (sit_for, Fsleep_for):
5066 * keyboard.c (kbd_buffer_get_event):
5067 * process.c (Faccept_process_output): Avoid compiler warnings when
5068 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
5069
ca300656
JB
50702012-06-23 Juanma Barranquero <lekktu@gmail.com>
5071
049ec95b
JB
5072 * makefile.w32-in: Update dependencies.
5073
ca300656
JB
5074 * w32.c (ltime): Add return type and declare static.
5075 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
5076
db7b8d06
PE
50772012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5078
5079 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
5080 Privately reported by Herbert J. Skuhra.
5081 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
5082 All uses changed.
5083 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5084 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5085
0bd8297f
EZ
50862012-06-23 Eli Zaretskii <eliz@gnu.org>
5087
96512555
EZ
5088 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5089 last argument of make_unibyte_string.
5090
0bd8297f
EZ
5091 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5092 language ID in the event parameters.
5093
5094 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5095 event.code, not the obscure "character set ID".
5096
63def6b6
CY
50972012-06-23 Chong Yidong <cyd@gnu.org>
5098
5099 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5100
e8a02204
EZ
51012012-06-23 Eli Zaretskii <eliz@gnu.org>
5102
388cdec0
EZ
5103 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5104 * w32.c (fdutimens): New function.
5105
5106 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5107
5108 * s/ms-w32.h (pselect): Redirect to sys_select.
5109
5110 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5111
e8a02204
EZ
5112 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5113 in the logic of incrementing and decrementing the value of
5114 use_relocatable_buffers.
5115
d054f3fb
PE
51162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5117
5118 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5119 Privately reported by Herbert J. Skuhra.
5120 [__FreeBSD__]: Remove "*/" typo after "#include".
5121 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5122 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5123 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5124 Don't assume EMACS_TIME and struct timeval are the same type.
5125
d35af63c
PE
51262012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 Support higher-resolution time stamps (Bug#9000).
5129 The time stamps are only nanosecond-resolution at the C level,
5130 since that's the best that any real-world system supports now.
5131 But they are picosecond-resolution at the Lisp level, as that's
5132 easy, and leaves room for future OS improvements.
5133
5134 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5135 (LIBES): Use it.
5136
5137 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5138 Don't get current time unless it's needed.
5139
5140 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5141 now provides it if it's absent.
5142 (start_atimer): Port to higher-res time stamps.
5143 Check for time stamp overflow. Don't get current time more
5144 often than is needed.
5145
5146 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5147 Include systime.h, not time.h.
5148 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5149
5150 * dired.c: Include stat-time.h.
5151 (Ffile-attributes): File times now have higher resolution.
5152
5153 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5154 (struct image): Timestamp now has higher resolution.
5155
5156 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5157 has at least microseconds now. All uses removed.
5158 (update_frame, update_single_window, update_window, update_frame_1)
5159 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5160 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5161
5162 * editfns.c (time_overflow): Now extern.
5163 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5164 (float-time, Fformat_time_string, Fcurrent_time_string)
5165 (Fcurrent_time_zone): Accept and generate higher-resolution
5166 time stamps.
5167 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5168 (decode_time_components, lisp_seconds_argument): New functions.
5169 (make_time): Now static.
5170 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5171 Report an error if the time is invalid, rather than having the caller
5172 do that.
5173
5174 * fileio.c: Include <stat-time.h>
5175 (Fcopy_file): Copy higher-resolution time stamps.
5176 Prefer to set the time stamp via a file descriptor if that works.
5177 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5178 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5179 (Fvisited_file_modtime, Fset_visited_file_modtime):
5180 Support higher-resolution time stamps.
5181
5182 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5183
5184 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5185
5186 * image.c (prepare_image_for_display, clear_image_cache)
5187 (lookup_image): Port to higer-resolution time stamps.
5188
5189 * keyboard.c (start_polling, bind_polling_period):
5190 Check for time stamp overflow.
5191 (read_char, kbd_buffer_get_event, timer_start_idle)
5192 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5193 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5194 Port to higher-resolution time stamps. Do not assume time_t is signed.
5195 (decode_timer): New function. Timers are now vectors of length 9,
5196 not 8, to accommodate the picosecond component.
5197 (timer_check_2): Use it.
5198
5199 * nsterm.m (select_timeout, timeval_subtract): Remove.
5200 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5201 as they're a bit more accurate and handle overflow better.
5202 (ns_select): Change prototype to be compatible with pselect.
5203 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5204 * nsterm.h (ns_select): Adjust prototype.
5205
5206 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5207 us-resolution time stamps.
5208 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5209
5210 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5211
5212 * lisp.h (time_overflow): New decl.
5213 (wait_reading_process_output): First arg is now intmax_t, not int,
5214 to accommodate larger waits.
5215
5216 * process.h (struct Lisp_Process.read_output_delay):
5217 Now counts nanoseconds, not microseconds.
5218 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5219 EMACS_HAS_USECS.
5220 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5221 (wait_reading_process_output):
5222 Port to ns-resolution time stamps.
5223 (Faccept_process_output, wait_reading_process_output):
5224 Check for time stamp overflow. Do not assume time_t is signed.
5225 (select_wrapper): Remove; we now use pselect.
5226 (Fprocess_attributes): Now generates ns-resolution time stamps.
5227
5228 * sysdep.c: Include utimens.h. Don't include utime.h
5229 or worry about struct utimbuf; gnulib does that for us now.
5230 (gettimeofday): Remove; gnulib provides a substitute.
5231 (make_timeval): New function.
5232 (set_file_times): Now sets ns-resolution time stamps.
5233 New arg FD; all uses changed.
5234 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5235 (system_process_attributes):
5236 Now returns ns-resolution time stamp. All uses changed.
5237 Check for time stamp overflow.
5238
5239 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5240 provides a substitute now.
5241
5242 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5243 since it guarantees struct timespec.
5244 (EMACS_TIME): Now struct timespec, so that we can support
5245 ns-resolution time stamps.
5246 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5247 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5248 (EMACS_USECS): Remove.
5249 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5250 so multiply the arg by 1000 before storing it.
5251 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5252 New macros.
5253 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5254 Port to ns-resolution time stamps.
5255 (EMACS_TIME_NEG_P): Remove; replaced by....
5256 (EMACS_TIME_SIGN): New macro.
5257 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5258 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5259 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5260 (make_timeval, make_lisp_time, decode_time_components): New decls.
5261 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5262 that it mishandled time_t overflow. You can't compare by subtracting!
5263 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5264 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5265
5266 * term.c: Include <sys/time.h>.
5267 (timeval_to_Time): New function, for proper overflow wraparound.
5268 (term_mouse_position, term_mouse_click): Use it.
5269
5270 * undo.c (record_first_change): Support higher-resolution time stamps
5271 in the undo buffer.
5272 (Fprimitive_undo): Use them when restoring time stamps.
5273
5274 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5275 (w32_get_internal_run_time):
5276 Port to higher-resolution Emacs time stamps.
5277 (ltime): Now accepts single 64-bit integer, as that's more convenient
5278 for callers.
5279
5280 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5281
5282 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5283 for compatibility with pselect. Support ns-resolution time stamps.
5284
5285 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5286
5287 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5288 Check for time stamp overflow, and support ns-resolution time stamps.
5289
5290 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5291 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5292 (timeval_subtract): Remove; no longer needed.
5293 (XTflash, XTring_bell, x_wait_for_event):
5294 Port to ns-resolution time stamps. Don't assume time_t is signed.
5295
b6a92dfe
CY
52962012-06-22 Chong Yidong <cyd@gnu.org>
5297
5298 * xdisp.c (x_consider_frame_title): Revert last change.
5299
d251c37c
EZ
53002012-06-22 Eli Zaretskii <eliz@gnu.org>
5301
5302 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5303 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5304 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5305 staticidx goes up to 1597 out of 1600 = 0x640.)
5306
f10deafb
PE
53072012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5308
5309 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5310 Otherwise, the umask might be mistakenly 0 while handling input signals.
5311
ec6de1e2
SM
53122012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5313
5314 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5315
28be1ada
DA
53162012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5317
5318 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5319 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5320 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5321 access to `contents' member of Lisp_Vector objects with AREF and ASET
5322 where appropriate.
5323
c6bf3022
CY
53242012-06-19 Chong Yidong <cyd@gnu.org>
5325
5326 * frame.c (delete_frame): When selecting a frame on a different
5327 text terminal, do not alter the terminal's top-frame.
5328
5329 * xdisp.c (format_mode_line_unwind_data): Record the target
5330 frame's selected window and its terminal's top-frame.
5331 (unwind_format_mode_line): Restore them.
5332 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
5333 Callers changed.
5334 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
5335 since tty frames can be explicitly named.
5336 (prepare_menu_bars): Likewise.
5337
5338 * term.c (Ftty_top_frame): New function.
5339
defd4196
PE
53402012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5341
5342 Port byte-code-meter to modern targets.
5343 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5344 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 5345 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
5346 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
5347 (METER_1, METER_2): Simplify.
5348
1053a871
SM
53492012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
5350
5351 * data.c (Fdefalias): Return `symbol' (bug#11686).
5352
b7e8d081
MR
53532012-06-18 Martin Rudalics <rudalics@gmx.at>
5354
5355 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
5356 gets killed during executing of this function (Bug#11665).
5357 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
5358 (Vkill_buffer_query_functions): In doc-string say that functions
5359 run by this hook should not change the current buffer.
5360
7ea2b339
PE
53612012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5362
5363 Fix recently-introduced process.c problems found by static checking.
5364 * process.c (write_queue_push, write_queue_pop, send_process):
5365 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
5366 (write_queue_pop): Fix pointer signedness problem.
5367 (send_process): Remove unused local.
5368
96a313a1
CY
53692012-06-17 Chong Yidong <cyd@gnu.org>
5370
5371 * xdisp.c (redisplay_internal): No need to redisplay terminal
5372 frames that are not on top.
5373
20ca2e94
TN
53742012-06-17 Troels Nielsen <bn.troels@gmail.com>
5375
5376 * process.c (make_process): Initialize write_queue.
5377 (write_queue_push, write_queue_pop): New functions.
5378 (send_process): Use them to maintain correct ordering of process
5379 writes (Bug#10815).
5380
9a900ca9
PE
53812012-06-17 Paul Eggert <eggert@cs.ucla.edu>
5382
310fbfa8
PE
5383 * lisp.h (eassert): Assume C89 or later.
5384 This removes the need for CHECK.
5385 (CHECK): Remove. Its comments about always evaluating its
5386 argument were confusing, as 'eassert' typically does not evaluate
5387 its argument.
5388
27bb1ca4
PE
5389 * coding.c (produce_chars): Use ptrdiff_t, not int.
5390
9a900ca9
PE
5391 * xterm.c (x_draw_underwave): Check for integer overflow.
5392 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
5393
41b7f8bc 53942012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
5395
5396 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
5397 referenced (Bug#11583).
5398
9b0e3eba
AA
53992012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
5400
5401 Implement wave-style variant of underlining.
5402 * dispextern.h (face_underline_type): New enum.
5403 (face): Add field for underline type.
5404 * nsterm.m (ns_draw_underwave): New function.
5405 (ns_draw_text_decoration): Use it.
5406 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
5407 New functions.
5408 (x_draw_glyph_string): Use them.
5409 * xfaces.c (Qline, Qwave): New Lisp objects.
5410 (check_lface_attrs, merge_face_ref)
1053a871
SM
5411 (Finternal_set_lisp_face_attribute, realize_x_face):
5412 Handle wave-style underline face attributes.
9b0e3eba
AA
5413 * xterm.c (x_draw_underwave): New function.
5414 (x_draw_glyph_string): Use it.
5415
0fb52f11
JB
54162012-06-16 Juanma Barranquero <lekktu@gmail.com>
5417
5418 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
5419 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
5420 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
5421 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
5422 ($(BLD)/w32select.$(O)): Update dependencies.
5423
e5560ff7
AS
54242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5425
5426 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
5427 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
5428 * character.c (_fetch_multibyte_char_p): Remove.
5429 * alloc.c: Include "character.h" before "buffer.h".
5430 * bidi.c: Likewise.
5431 * buffer.c: Likewise.
5432 * bytecode.c: Likewise.
5433 * callint.c: Likewise.
5434 * callproc.c: Likewise.
5435 * casefiddle.c: Likewise.
5436 * casetab.c: Likewise.
5437 * category.c: Likewise.
5438 * cmds.c: Likewise.
5439 * coding.c: Likewise.
5440 * composite.c: Likewise.
5441 * dired.c: Likewise.
5442 * dispnew.c: Likewise.
5443 * doc.c: Likewise.
5444 * dosfns.c: Likewise.
5445 * editfns.c: Likewise.
5446 * emacs.c: Likewise.
5447 * fileio.c: Likewise.
5448 * filelock.c: Likewise.
5449 * font.c: Likewise.
5450 * fontset.c: Likewise.
5451 * fringe.c: Likewise.
5452 * indent.c: Likewise.
5453 * insdel.c: Likewise.
5454 * intervals.c: Likewise.
5455 * keyboard.c: Likewise.
5456 * keymap.c: Likewise.
5457 * lread.c: Likewise.
5458 * macros.c: Likewise.
5459 * marker.c: Likewise.
5460 * minibuf.c: Likewise.
5461 * nsfns.m: Likewise.
5462 * nsmenu.m: Likewise.
5463 * print.c: Likewise.
5464 * process.c: Likewise.
5465 * regex.c: Likewise.
5466 * region-cache.c: Likewise.
5467 * search.c: Likewise.
5468 * syntax.c: Likewise.
5469 * term.c: Likewise.
5470 * textprop.c: Likewise.
5471 * undo.c: Likewise.
5472 * unexsol.c: Likewise.
5473 * w16select.c: Likewise.
5474 * w32fns.c: Likewise.
5475 * w32menu.c: Likewise.
5476 * window.c: Likewise.
5477 * xdisp.c: Likewise.
5478 * xfns.c: Likewise.
5479 * xmenu.c: Likewise.
5480 * xml.c: Likewise.
5481 * xselect.c: Likewise.
5482
2f07e6af
EZ
54832012-06-16 Eli Zaretskii <eliz@gnu.org>
5484
1053a871
SM
5485 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
5486 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 5487 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
5488 row.
5489 (handle_face_prop): Use chunk-relative overlay string index when
5490 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
5491 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
5492 the rightmost. (Bug#11720)
2f07e6af 5493
29b83cec
AS
54942012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5495
5496 * category.h (CHAR_HAS_CATEGORY): Define as inline.
5497 (CATEGORY_MEMBER): Enforce 1/0 value.
5498 * category.c (_temp_category_set): Remove.
5499
4c5501e9
EZ
55002012-06-16 Eli Zaretskii <eliz@gnu.org>
5501
5502 * window.c (Fdelete_other_windows_internal)
5503 (Fdelete_window_internal): Don't access frame's mouse highlight
5504 info of the initial frame. (Bug#11677)
5505
2b570124
PE
55062012-06-14 Paul Eggert <eggert@cs.ucla.edu>
5507
e93864f9
PE
5508 * .gdbinit (xgetint): Fix recently-introduced paren typo.
5509 Assume USE_2_TAGS_FOR_INTS.
5510 (xreload): Adjust $tagmask width to match recent lisp.h change.
5511
2b570124
PE
5512 Simplify lisp.h in minor ways that should not affect code.
5513 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
5514 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
5515 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
5516 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
5517 (INTTYPEBITS): New macro, for clarity.
5518 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
5519 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
5520 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
5521 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
5522 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
5523
81755f69
JB
55242012-06-13 Juanma Barranquero <lekktu@gmail.com>
5525
5526 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
5527
16192a57
GM
55282012-06-13 Glenn Morris <rgm@gnu.org>
5529
5530 * s/bsd-common.h (BSD4_3):
5531 * s/usg5-4-common.h (USG5_4): No longer define; unused.
5532
646b5f55
AS
55332012-06-13 Andreas Schwab <schwab@linux-m68k.org>
5534
5535 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
5536 instead of union.
5537 (XLI, XIL): Define.
1053a871
SM
5538 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
5539 Use them.
5540 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 5541 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 5542 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
5543 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
5544 * frame.c (delete_frame): Remove outdated comment.
5545 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
5546 USE_LISP_UNION_TYPE.
5547 (Fw32_unregister_hot_key): Likewise.
5548 (Fw32_toggle_lock_key): Likewise.
5549 * w32menu.c (add_menu_item): Likewise.
5550 (w32_menu_display_help): Use XIL instead of checking
5551 USE_LISP_UNION_TYPE.
5552 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
5553 (init_heap): Likewise.
5554 * w32term.c (w32_read_socket): Update comment.
5555
1d3823c9
GM
55562012-06-13 Glenn Morris <rgm@gnu.org>
5557
c62ff706
GM
5558 * s/usg5-4-common.h, src/s/unixware.h:
5559 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
5560
1d3823c9
GM
5561 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
5562
bfe3e0a2
PE
55632012-06-13 Paul Eggert <eggert@cs.ucla.edu>
5564
5565 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
5566 * alloc.c (make_number) [!defined make_number]:
5567 Remove, as lisp.h always defines this now.
5568 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
5569 (roundup_size): Verify that it is a power of 2.
5570 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
5571 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
5572 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
5573 -DUSE_LSB_TAG=0, to override the automatically-selected default.
5574 USE_LSB_TAG now is always defined to be either 0 or 1.
5575 All uses changed.
5576 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
5577 code works fine either way, and efficiency is not a concern here,
5578 as the union type is for debugging, not for production.
5579 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
5580 Use an inline function on all platforms when using the union type,
5581 since this is simpler and 'static inline' can be used portably
5582 within Emacs now.
5583 (LISP_INITIALLY_ZERO): New macro.
5584 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
5585 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
5586
45fa9c0f
GM
55872012-06-12 Glenn Morris <rgm@gnu.org>
5588
b4492cba
GM
5589 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
5590
5591 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 5592
45fa9c0f
GM
5593 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
5594 Move BROKEN_SIGIO to configure.
5595
5596 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
5597 Move NO_TERMIO to configure.
5598
0e25d334
CY
55992012-06-12 Chong Yidong <cyd@gnu.org>
5600
5601 * image.c (imagemagick_load_image): Use MagickFlattenImage if
5602 MagickMergeImageLayers is undefined. Use pixel pusher loop if
5603 MagickExportImagePixels is undefined.
5604
43682bb6
PE
56052012-06-12 Paul Eggert <eggert@cs.ucla.edu>
5606
5607 * image.c (imagemagick_load_image): Remove unused label.
5608
a9be7d2b
GM
56092012-06-11 Glenn Morris <rgm@gnu.org>
5610
5611 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5612 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
5613 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
5614 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
5615
3017f87f
SM
56162012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
5617
5618 * alloc.c (make_byte_code): New function.
5619 (Fmake_byte_code): Use it. Don't purify here.
5620 * lread.c (read1): Use it as well to avoid extra allocation.
5621
1b9b4cf4
CY
56222012-06-11 Chong Yidong <cyd@gnu.org>
5623
5624 * image.c (imagemagick_load_image): Implement transparency.
5625
95988fcf
AS
56262012-06-10 Andreas Schwab <schwab@linux-m68k.org>
5627
5628 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
5629 account for preceding backslashes. (Bug#11663)
5630
cd4eb164
CY
56312012-06-09 Chong Yidong <cyd@gnu.org>
5632
5633 * term.c: Support italics in capable terminals (Bug#9652).
5634 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
5635 (turn_on_face): Output using TS_enter_italic_mode if available.
5636 Don't handle unused blinking and alt-charset cases.
5637 (turn_off_face): Handle italic case; discard unused tty_blinking_p
5638 and tty_alt_charset_p cases.
5639 (tty_capable_p, init_tty): Support italics.
5640
5641 * termchar.h (struct tty_display_info): Add field for italics.
5642 Remove unused blink field.
5643
5644 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
5645 Handle slant.
5646
5647 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
5648 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
5649 tty_alt_charset_p. Add tty_italic_p.
5650
ff88beb8
MA
56512012-06-09 Michael Albinus <michael.albinus@gmx.de>
5652
5653 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
5654 dbus_type_is_basic if available.
5655 (xd_extract_signed, xd_extract_unsigned): Rename from
5656 extract_signed and extract_unsigned, respectively. Adapt callers.
5657
44286096
CY
56582012-06-09 Chong Yidong <cyd@gnu.org>
5659
1682701f
CY
5660 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
5661
44286096
CY
5662 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
5663 case (Bug#9752).
5664
d86feb17
PE
56652012-06-08 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 * xdisp.c (vmessage): Treat frame message as multibyte.
5668 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5669 would generate the diagnostic "Making \302\247 buffer-local while
5670 let-bound!".
5671
d5c20fe8
EZ
56722012-06-08 Eli Zaretskii <eliz@gnu.org>
5673
5674 * dispnew.c (showing_window_margins_p): Undo last change, which
5675 was done due to an inadvertent commit.
5676 (adjust_frame_glyphs_for_frame_redisplay): Do call
5677 showing_window_margins_p.
5678
513749ee
SM
56792012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5680
5681 * eval.c (Fmake_var_non_special): New primitive.
5682 (syms_of_eval): Defsubr it.
5683 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
5684
d4a8f5c1
JB
56852012-06-08 Juanma Barranquero <lekktu@gmail.com>
5686
5687 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
5688 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
5689
8bbbc977
EZ
56902012-06-08 Eli Zaretskii <eliz@gnu.org>
5691
5692 * alloc.c (allocate_vectorlike): Fix last change.
5693
f3372c87
DA
56942012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
5695
5696 Block-based vector allocation of small vectors.
5697 * lisp.h (struct vectorlike_header): New field `nbytes',
5698 adjust comment accordingly.
5699 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 5700 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
5701 mark_maybe_pointer, valid_lisp_object_p) accordingly.
5702 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
5703 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
5704 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
5705 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
5706 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
5707 (roundup_size): New constant.
5708 (struct vector_block): New data type.
5709 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 5710 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
5711 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
5712 (sweep_vectors): New functions.
5713 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 5714 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
5715 or equal to VBLOCK_BYTES_MAX.
5716 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
5717 (init_alloc_once): Add call to init_vectors.
5718
4f18a4ed
SM
57192012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5720
5721 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5722
86f158bc
PE
57232012-06-07 Paul Eggert <eggert@cs.ucla.edu>
5724
5725 * doprnt.c (doprnt): Truncate multibyte char correctly.
5726 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
5727 would mishandle a string argument "Xc" if X was a multibyte
5728 character of length 2: it would truncate after X's first byte
5729 rather than including all of X.
5730
c5cfcbe0
CY
57312012-06-06 Chong Yidong <cyd@gnu.org>
5732
5733 * buffer.c (word_wrap): Doc fix.
5734
c05cf390
PE
57352012-06-04 Paul Eggert <eggert@cs.ucla.edu>
5736
5737 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
5738
0c3461de
GM
57392012-06-03 Glenn Morris <rgm@gnu.org>
5740
5741 * xdisp.c (tool-bar-style): Doc fix.
5742
c71232db
UM
57432012-06-03 Ulrich Müller <ulm@gentoo.org>
5744
5745 * Makefile.in (PAXCTL): Define.
5746 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5747 binary via PaX flags if the paxctl utility is available.
5748 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
5749 Restore PaX flags to their default. (Bug#11398)
5750
383f7350
CY
57512012-06-03 Chong Yidong <cyd@gnu.org>
5752
5753 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
5754 buffer (Bug#11226).
5755
5f2c76c6
CY
57562012-06-03 Chong Yidong <cyd@gnu.org>
5757
5758 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
5759 (note_mode_line_or_margin_highlight): If there is no help echo,
5760 use mode-line-default-help-echo. Handle the case where the mouse
5761 position is past the end of the mode line string.
5762
5763 * buffer.c (buffer_local_value_1): New function, split from
5764 Fbuffer_local_value; can return Qunbound.
5765 (Fbuffer_local_value): Use it.
5766 (Vmode_line_format): Docstring tweaks.
5767
773d47f6
PE
57682012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5769
5770 * sysdep.c (system_process_attributes): Improve comment.
5771
f2d6a3df
SM
57722012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
5773
5774 * keyboard.c: Export real-this-command to Elisp.
5775 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5776 and DEFVAR it. Update all users.
5777
63810350
PE
57782012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5779
7bd5c1f4
PE
5780 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5781
63810350
PE
5782 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
5783 Convert pctcpu and pctmem to Lisp float properly.
5784 Let the compiler fold better, as 100.0/0x8000 is exact.
5785
a2821611
AS
57862012-06-02 Andreas Schwab <schwab@linux-m68k.org>
5787
5788 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
5789 cons_block.
5790
5fceba1d
PE
57912012-06-01 Paul Eggert <eggert@cs.ucla.edu>
5792
5793 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5794
c98ff5dd
DA
57952012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
5796
5797 For a 'struct window', replace some Lisp_Object fields to
5798 bitfields where appropriate, remove unused fields.
5799 * window.h (struct window): Remove unused 'last_mark_x' and
5800 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
5801 change it's type from Lisp_Object to bitfield.
5802 Change type of 'force_start', 'optional_new_start',
5803 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 5804 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 5805
ca34e0be
PE
58062012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5807
5808 Pacify gcc -Wdouble-precision when using Xaw.
5809 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5810 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
5811 Use 'float' consistently, rather than 'float' in most places
5812 and 'double' in a couple of places.
5813
efc00ab1 58142012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
5815
5816 * xdisp.c (handle_stop): Detect whether we have overlay strings
5817 loaded by testing it->current.overlay_string_index to be
5818 non-negative, instead of checking whether n_overlay_strings is
5819 positive. (Bug#11587)
5820
efc00ab1 58212012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
5822
5823 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5824
5825 * doc.c (Fsubstitute_command_keys): Doc fix.
5826
efc00ab1 58272012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
5828
5829 * search.c (search_buffer): Remove calls to
5830 r_alloc_inhibit_buffer_relocation, as it is now called by
5831 maybe_unify_char, which was the cause of relocation of buffer text
5832 in bug#11519.
5833
efc00ab1 58342012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
5835
5836 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
5837 for the duration of call to load_charset, to avoid problems with
5838 callers of maybe_unify_char that access buffer text through C
5839 pointers.
5840
5841 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
5842 decrement the inhibition flag, instead of just setting or
5843 resetting it.
5844
ba93a187
PE
58452012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5846
5847 Remove obsolete '#define static' cruft.
5848 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
5849 This #undef was "temporary" in 2000; it is no longer needed
5850 now that '#define static' has gone away.
5851 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
5852 (gray_bitmap_bits): Remove; no longer needed.
5853 All uses replaced with definiens.
5854 * xterm.c: Include "bitmaps/gray.xbm".
5855
9e4bf381
PE
58562012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5857
5858 Clean up __executable_start, monstartup when --enable-profiling.
5859 The following changes affect the code only when profiling.
5860 * dispnew.c (__executable_start): Rename from safe_bcopy.
5861 Define only on platforms that need it.
5862 * emacs.c: Include <sys/gmon.h> when profiling.
5863 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
5864 (__executable_start): Remove decl, since lisp.h does it now.
5865 (safe_bcopy): Remove decl; no longer has that name.
5866 (main): Coalesce #if into single bit of code, for simplicity.
5867 Cast pointers to uintptr_t, since standard libraries want integers
5868 and not pointers.
5869 * lisp.h (__executable_start): New decl.
5870
32d72c2f
GM
58712012-05-31 Glenn Morris <rgm@gnu.org>
5872
5873 * image.c (Fimagemagick_types): Doc fix.
5874
baac5bc7
JM
58752012-05-30 Jim Meyering <meyering@redhat.com>
5876
5877 * callproc.c (Fcall_process_region): Include directory component
5878 in mkstemp error message (Bug#11586).
5879
72cb32cf
PE
58802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5881
5882 * alloc.c, lisp.h (make_pure_vector): Now static.
5883
61b108cc
SM
58842012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
5885
5886 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5887 Move to byte-run.el.
5888 (Fautoload): Do the hash-doc more carefully.
5889 * data.c (Fdefalias): Purify definition, except for keymaps.
5890 (Qdefun): Move from eval.c.
5891 * lisp.h (Qdefun): Remove.
5892 * lread.c (read1): Tiny simplification.
5893
471fe23d
TN
58942012-05-29 Troels Nielsen <bn.troels@gmail.com>
5895
934f3f58 5896 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
5897 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
5898 Bug#9642, but explicitly check that the buffer the overlay would
5899 be moved to is live and rearrange lines to make sure that errors
5900 will not put the overlay in an inconsistent state.
5901 (Fdelete_overlay): Cosmetics.
5902
85d0efd1
EZ
59032012-05-28 Eli Zaretskii <eliz@gnu.org>
5904
5905 * w32term.c (my_bring_window_to_top): New function.
5906 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
5907 could be different from the original one.
5908 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
5909 (Bug#11513)
5910
5911 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
5912 by calling BringWindowToTop.
5913
5914 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
5915 (WM_EMACS_END): Increase by one.
5916
da92a98c
PE
59172012-05-28 Paul Eggert <eggert@cs.ucla.edu>
5918
5919 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
5920 This avoids undefined behavior that might cause the eassert
5921 to not catch an out-of-range value.
5922
74d1f848
JB
59232012-05-28 Juanma Barranquero <lekktu@gmail.com>
5924
5925 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
5926 Update dependencies.
5927
9e1a06fc
EZ
59282012-05-27 Eli Zaretskii <eliz@gnu.org>
5929
5930 * bidi.c (bidi_mirror_char): Fix last change.
5931
f3dd7312
AS
59322012-05-27 Andreas Schwab <schwab@linux-m68k.org>
5933
5934 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
5935 when referring to sectname field in printf format.
5936
81899c91
PE
59372012-05-27 Paul Eggert <eggert@cs.ucla.edu>
5938
57b81a9f
PE
5939 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
5940 Only r_alloc_inhibit_buffer_relocation needed to be added;
5941 the others were already declared.
5942
81899c91
PE
5943 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
5944 before checking whether it's out of range. Put the check inside
5945 eassert. See
5946 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5947
33017faf 59482012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5949
5950 * callproc.c (Fcall_process): Restore a line that was accidentally
5951 commented out in the 2011-02-13 change (bug#11547).
5952
33017faf 59532012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5954
5955 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5956 defined on ralloc.c.
5957
5958 * buffer.c [REL_ALLOC]: Remove prototypes of
5959 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5960 they are now on lisp.h.
5961
5962 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5963
5964 * search.c (search_buffer): Use it to inhibit relocation of buffer
5965 text while re_search_2 is doing its job, because re_search_2 is
5966 passed C pointers to buffer text. (Bug#11519)
5967
23415acf
EZ
5968 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5969 Update value to 24.
5970
44e27368
EZ
5971 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5972 state after an additional call to move_it_in_display_line_to, keep
5973 the values of it->max_ascent and it->max_descent found for the
5974 entire line.
5975 (pos_visible_p): Revert the comparison against bottom_y to what it
5976 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5977 (Bug#11464)
5978
c1892f11
PE
59792012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5980
5981 Fix coding-related core dumps with gcc -ftrapv.
5982 The code was computing A - B, where A and B are pointers, and B is
5983 random garbage. This can lead to core dumps on platforms that
5984 have special pointer registers, and it also leads to core dumps on
5985 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5986 A - B only when B is initialized properly.
5987 * coding.c (coding_set_source, coding_set_destination): Return void.
5988 (coding_change_source, coding_change_destinations): New functions,
5989 with the old behaviors of coding_set_source and coding_set_destination.
5990 All callers that need an offset changed to use these new functions.
5991
eb7afdad
GM
59922012-05-26 Glenn Morris <rgm@gnu.org>
5993
5994 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5995
f12fdf02
EZ
59962012-05-26 Eli Zaretskii <eliz@gnu.org>
5997
53a63be6 5998 Extend mouse support on W32 text-mode console.
61b108cc
SM
5999 * xdisp.c (draw_row_with_mouse_face):
6000 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 6001
eb3f6f01 6002 * w32console.c: Include window.h.
61b108cc
SM
6003 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
6004 New functions.
eb3f6f01
EZ
6005 (initialize_w32_display): Initialize mouse-highlight data.
6006
53a63be6
EZ
6007 * w32inevt.c: Include termchar.h and window.h.
6008 (do_mouse_event): Support mouse-autoselect-window. When the mouse
6009 moves, call note_mouse_highlight. If help_echo changed, call
6010 gen_help_event to produce help-echo message in the echo area.
6011 Call clear_mouse_face if mouse_face_hidden is set in the mouse
6012 highlight info.
6013
4cfd81f6
PE
60142012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6015
6016 * lread.c (read1): Simplify slightly to avoid an overflow warning
6017 with GCC 4.7.0 on x86-64.
6018
4446092a
EZ
60192012-05-26 Eli Zaretskii <eliz@gnu.org>
6020
6021 * bidi.c (bidi_mirror_char): Revert last change: an int is
6022 definitely wide enough here.
6023
42b2a986 60242012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 6025
42b2a986 6026 Fix integer width and related bugs (Bug#9874).
eb106a49 6027 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
6028 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6029 (string_bytes, check_sblock, allocate_string_data):
6030 (compact_small_strings, Fmake_bool_vector, make_string)
6031 (make_unibyte_string, make_multibyte_string)
6032 (make_string_from_bytes, make_specified_string)
6033 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
6034 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
6035 (mark_vectorlike):
6036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6037 (allocate_pseudovector):
6038 Use int, not EMACS_INT, where int is wide enough.
6039 (inhibit_garbage_collection, Fgarbage_collect):
6040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6041 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
6042 int might not be wide enough.
6043 (bidi_cache_search, bidi_cache_find, bidi_init_it)
6044 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
6045 (bidi_at_paragraph_end, bidi_find_paragraph_start)
6046 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6047 (bidi_level_of_next_char, bidi_move_to_visually_next):
6048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6049 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
6050 (Fkill_buffer, Fset_buffer_major_mode)
6051 (advance_to_char_boundary, Fbuffer_swap_text)
6052 (Fset_buffer_multibyte, overlays_at, overlays_in)
6053 (overlay_touches_p, struct sortvec, record_overlay_string)
6054 (overlay_strings, recenter_overlay_lists)
6055 (adjust_overlays_for_insert, adjust_overlays_for_delete)
6056 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
6057 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
6058 (Foverlay_recenter, last_overlay_modification_hooks_used)
6059 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
6060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
6061 (validate_region): Omit unnecessary test for b <= e,
6062 since that's guaranteed by the previous test.
d311d28c
PE
6063 (adjust_overlays_for_delete): Avoid pos + length overflow.
6064 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
6065 (report_overlay_modification):
6066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6067 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
6068 Omit pointer cast, which isn't needed anyway, and doesn't work
6069 after the EMACS_INT -> ptrdiff_t change.
02481186 6070 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
6071 * buffer.h: Adjust decls to match defn changes elsewhere.
6072 (struct buffer_text, struct buffer):
6073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6074 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
6075 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
6076 not int, to avoid needless 32-bit limit on 64-bit hosts.
6077 (exec_byte_code): Use tighter memory-full test, one that checks
6078 for alloca overflow. Don't compute the address of the object just
6079 before an array, as that's not portable. Use EMACS_INT, not
6080 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
6081 * callint.c (Fcall_interactively):
6082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6083 * callproc.c (call_process_kill, Fcall_process):
6084 Don't assume pid_t fits into an Emacs fixnum.
6085 (call_process_cleanup, Fcall_process, child_setup):
6086 Don't assume pid_t fits into int.
6087 (call_process_cleanup, Fcall_process, delete_temp_file)
6088 (Fcall_process_region):
6089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6090 (Fcall_process): Simplify handling of volatile integers.
6091 Use int, not EMACS_INT, where int will do.
6092 * casefiddle.c (casify_object, casify_region, operate_on_word)
6093 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6095 (casify_object): Avoid integer overflow when overallocating buffer.
6096 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6097 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6098 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6099 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6100 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6101 integers are now checked earlier. All uses replaced with XINT.
6102 (ccl_driver):
6103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6104 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6105 (ccl_driver, Fregister_code_conversion_map):
6106 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6107 (resolve_symbol_ccl_program): Check that vector header is in range.
6108 Always copy the vector, so that we can check its contents reliably
6109 now rather than having to recheck each instruction as it's being
6110 executed. Check that vector words fit in 'int'.
6111 (ccl_get_compiled_code, Fregister_ccl_program)
6112 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6113 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6114 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6115 contents are in range.
6116 (Fccl_execute_on_string): Check that status is in range.
6117 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6118 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6119 Accept and return EMACS_INT, not int, because callers can pass values
6120 out of 'int' range.
6121 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6122 (multibyte_chars_in_text, parse_str_as_multibyte)
6123 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6124 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6125 (string_escape_byte8, Fget_byte):
6126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6127 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6128 avoid mishandling large integers.
6129 * character.h: Adjust decls to match defn changes elsewhere.
6130 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6131 (Ffind_charset_region):
6132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6133 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6134 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6135 Don't assume fixnum fits in int.
d311d28c
PE
6136 (load_charset_map_from_vector, Fmap_charset_chars):
6137 Remove now-unnecessary CHECK_NATNUMs.
6138 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6139 Don't rely on undefined behavior with signed left shift overflow.
6140 Don't assume unsigned int fits into fixnum, or that fixnum fits
6141 into unsigned int. Don't require max_code to be a valid fixnum;
6142 that's not true for gb10830 4-byte on a 32-bit host. Allow
6143 invalid_code to be a cons, for the same reason. Require code_offset
6144 to be a character. Avoid int overflow if max_char is close
6145 to INT_MAX.
6146 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6147 this is intended anyway and avoids some undefined behavior.
6148 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6149 INDEX_TO_CODE_POINT, as that's what it expects.
6150 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6151 * charset.h (DECODE_CHAR): Return int, not unsigned;
6152 this is what was intended anyway, and it avoids undefined behavior.
6153 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6154 integer-overflow issues.
6155 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6156 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6157 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6158 * chartab.c (Fmake_char_table, Fset_char_table_range)
6159 (uniprop_get_decoder, uniprop_get_encoder):
6160 Don't assume fixnum fits in int.
6161 * cmds.c (move_point): New function, that does the gist of
6162 Fforward_char and Fbackward_char, but does so while checking
6163 for integer overflow more accurately.
c96e5d6a 6164 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6165 (Fforward_line, Fend_of_line, internal_self_insert)
6166 (internal_self_insert):
6167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6168 Fix a FIXME, by checking for integer overflow when calculating
6169 target_clm and actual_clm.
6170 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6171 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6172 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6173 (coding_alloc_by_making_gap, alloc_destination)
6174 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6175 (encode_coding_utf_16, detect_coding_emacs_mule)
6176 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6177 (detect_coding_iso_2022, decode_coding_iso_2022)
6178 (encode_invocation_designation, encode_designation_at_bol)
6179 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6180 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6181 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6182 (encode_coding_ccl, encode_coding_raw_text)
6183 (detect_coding_charset, decode_coding_charset)
6184 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6185 (produce_composition, produce_charset, produce_annotation)
6186 (decode_coding, handle_composition_annotation)
6187 (handle_charset_annotation, consume_chars, decode_coding_gap)
6188 (decode_coding_object, encode_coding_object, detect_coding_system)
6189 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6190 (code_convert_region, code_convert_string)
8f50130c
PE
6191 (Fdefine_coding_system_internal)
6192 (coding_set_source, coding_set_destination):
d311d28c
PE
6193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6194 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6195 (Fdefine_coding_system_internal):
6196 Don't assume fixnums fit in int.
6197 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6198 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6199 (Funencodable_char_position, Fcheck_coding_systems_region)
6200 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6201 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6202 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6203 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6204 Don't access memory outside of the args array.
d311d28c 6205 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6206 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6207 result of ENCODE_CHAR.
d311d28c
PE
6208 * coding.h: Adjust decls to match defn changes elsewhere.
6209 (struct coding_system):
6210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6211 * composite.c (get_composition_id, find_composition)
6212 (run_composition_function, update_compositions)
6213 (compose_text, composition_gstring_put_cache)
6214 (composition_gstring_p, composition_gstring_width)
6215 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6216 (composition_compute_stop_pos, composition_reseat_it)
6217 (composition_update_it, struct position_record)
6218 (find_automatic_composition, composition_adjust_point)
6219 (Fcomposition_get_gstring, Ffind_composition_internal):
6220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6221 (update_compositions):
6222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6223 * composite.h: Adjust decls to match defn changes elsewhere.
6224 (struct composition):
6225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6226 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6227 Do not attempt to compute the address of the object just before a
6228 buffer; this is not portable.
6229 (Faref, Faset):
6230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6231 (Faset): Use int, not EMACS_INT, where int is wide enough.
6232 (Fstring_to_number): Don't assume fixnums fit in int.
6233 (Frem): Don't assume arg is nonnegative.
6234 * dbusbind.c (xd_append_arg): Check for integers out of range.
6235 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6236 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6237 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6238 (xd_get_connection_references): Return ptrdiff_t, not int.
6239 All uses changed.
6240 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6241 (xd_read_message_1):
6242 Use int, not unsigned, where the dbus API uses int.
6243 (Fdbus_message_internal): Don't overflow mtype.
6244 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6245 * dired.c (directory_files_internal, file_name_completion, scmp)
6246 (file_name_completion_stat):
6247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6248 (file_name_completion): Don't overflow matchcount.
6249 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6250 * dispextern.h: Adjust decls to match defn changes elsewhere.
6251 (struct text_pos, struct glyph, struct bidi_saved_info)
6252 (struct bidi_string_data, struct bidi_it, struct composition_it)
6253 (struct it):
6254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6255 (struct display_pos, struct composition_it, struct it):
6256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6257 * dispnew.c (increment_matrix_positions)
6258 (increment_row_positions, mode_line_string)
6259 (marginal_area_string):
6260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6261 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6263 (duration_to_sec_usec): New function, to check for overflow better.
6264 (Fsleep_for, sit_for): Use it.
6265 * doc.c (get_doc_string, store_function_docstring):
6266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6267 (get_doc_string, Fsnarf_documentation):
6268 Use int, not EMACS_INT, where int is wide enough.
6269 (get_doc_string):
6270 Use SAFE_ALLOCA, not alloca.
6271 Check for overflow when converting EMACS_INT to off_t.
6272 * doprnt.c (doprnt):
6273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6274 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6275 Don't assume uid_t fits into fixnum.
6276 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6277 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6278 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6279 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6280 (general_insert_function)
6281 (Finsert_char, make_buffer_string, make_buffer_string_both)
6282 (update_buffer_properties, Fbuffer_substring)
6283 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6284 (Fsubst_char_in_region, check_translation)
6285 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6286 (transpose_markers, Ftranspose_regions):
6287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6288 (clip_to_bounds): Move to lisp.h as an inline function).
6289 (Fconstrain_to_field): Don't assume integers are nonnegative.
6290 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6291 (Fsubst_char_in_region, Fsave_restriction):
6292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6293 (Femacs_pid): Don't assume pid_t fits into fixnum.
6294 (lo_time): Use int, not EMACS_INT, when int suffices.
6295 (lisp_time_argument): Check for usec out of range.
6296 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6297 (Fuser_login_name, Fuser_full_name): Signal an error
6298 if a uid argument is out of range, rather than relying on
6299 undefined behavior.
c8d5c857
PE
6300 (Fformat_time_string): Remove now-unnecessary check.
6301 lisp_time_argument checks for out-of-range usec now.
243e0530 6302 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6303 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6304 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6305 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6306 (init_cmdargs, Fdump_emacs):
6307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6308 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6309 the bottom (typically) 32 bits of the fixnum.
6310 * eval.c (specpdl_size, call_debugger):
6311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6312 (when_entered_debugger, Fbacktrace_debug):
6313 Don't assume fixnum can fit in int.
6314 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6315 the object just before a buffer; this is not portable.
6316 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6317 (grow_specpdl, unbind_to):
6318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6319 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6320 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6321 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6322 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6323 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6325 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6326 (a_write, e_write):
6327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6328 (Fcopy_file, non_regular_nbytes, read_non_regular)
6329 (Finsert_file_contents):
6330 Use int, not EMACS_INT, where int is wide enough.
6331 (READ_BUF_SIZE): Verify that it fits in int.
6332 (Finsert_file_contents): Check that counts are in proper range,
6333 rather than assuming fixnums fit into ptrdiff_t etc.
6334 Don't assume fixnums fit into int.
125b3835 6335 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
6336 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
6337 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
6338 (string_char_to_byte, string_byte_to_char)
6339 (string_make_multibyte, string_to_multibyte)
6340 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
6341 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
6342 (substring_both, Fdelete, internal_equal, Ffillarray)
6343 (Fclear_string, mapcar1)
6344 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
6345 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
6346 (larger_vector, make_hash_table, maybe_resize_hash_table)
6347 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
6348 (Fmaphash, secure_hash):
6349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6350 (concat): Check for string index and length overflow.
6351 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
6352 (Frequire):
6353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6354 (larger_vector): New API (vec, incr_min, size_max) replaces old
6355 one (vec, new_size, init). This catches size overflow.
6356 INIT was removed because it was always Qnil.
6357 All callers changed.
6358 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
6359 the upper bound on a hash table index size.
6360 (make_hash_table, maybe_resize_hash_table): Use it.
6361 (secure_hash): Computer start_byte and end_byte only after
6362 they're known to be in ptrdiff_t range.
6363 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
6364 (Ffont_get_glyphs, Ffont_at):
6365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6366 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
6367 (Flist_fonts, Fopen_font):
6368 Don't assume fixnum can fit in int.
6369 (check_gstring): Don't assume index can fit in int.
6370 (font_match_p): Check that fixnum is a character, not a nonnegative
6371 fixnum, since the later code needs to stuff it into an int.
6372 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
6373 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
6374 conversion overflow issues.
6375 (Fopen_font): Check for integer out of range.
6376 (Ffont_get_glyphs): Don't assume index can fit in int.
6377 * font.h: Adjust decls to match defn changes elsewhere.
6378 * fontset.c (reorder_font_vector): Redo score calculation to avoid
6379 integer overflow.
6380 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
6381 printmax_t, where ptrdiff_t is wide enough.
6382 (Finternal_char_font):
6383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6384 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
6385 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
6386 (Fset_frame_position, x_set_frame_parameters)
6387 (x_set_line_spacing, x_set_border_width)
6388 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
6389 Check that fixnums are in proper range for system types.
6390 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
6391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6392 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
6393 Use SAFE_ALLOCA_LISP, not alloca.
6394 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
6395 intptr_t is wide enough.
6396 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
6397 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
6398 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
6399 Check for fixnum out of range.
6400 * ftfont.c (ftfont_list): Don't assume index fits in int.
6401 Check that fixnums are in proper range for system types.
6402 (ftfont_shape_by_flt):
6403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
6404 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6406 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
6407 Check that fixnums are in proper range for system types.
6408 * gnutls.h: Adjust decls to match defn changes elsewhere.
6409 * gtkutil.c (xg_dialog_run):
6410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6411 (update_frame_tool_bar):
6412 Check that fixnums are in proper range for system types.
6413 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 6414 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
6415 * indent.c (last_known_column, last_known_column_point):
6416 (current_column_bol_cache):
6417 (skip_invisible, current_column, check_display_width):
6418 (check_display_width, scan_for_column, current_column_1)
6419 (Findent_to, Fcurrent_indentation, position_indentation)
6420 (indented_beyond_p, Fmove_to_column, compute_motion):
6421 (Fcompute_motion, Fvertical_motion):
6422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6423 (last_known_column_modified): Use EMACS_INT, not int.
6424 (check_display_width):
6425 (Fcompute_motion):
6426 Check that fixnums and floats are in proper range for system types.
6427 (compute_motion): Don't assume index or fixnum fits in int.
6428 (compute_motion, Fcompute_motion):
6429 Use int, not EMACS_INT, when it is wide enough.
6430 (vmotion): Omit local var start_hpos that is always 0; that way
6431 we don't need to worry about overflow in expressions involving it.
6432 * indent.h: Adjust decls to match defn changes elsewhere.
6433 (struct position):
6434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6435 Use int, not EMACS_INT, where int is wide enough.
6436 Remove unused members ovstring_chars_done and tab_offset;
6437 all uses removed.
6438 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
6439 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
6440 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
6441 (make_gap, copy_text, insert, insert_and_inherit)
6442 (insert_before_markers, insert_before_markers_and_inherit)
6443 (insert_1, count_combining_before, count_combining_after)
6444 (insert_1_both, insert_from_string)
6445 (insert_from_string_before_markers, insert_from_string_1)
6446 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
6447 (adjust_after_replace, adjust_after_insert, replace_range)
6448 (replace_range_2, del_range, del_range_1, del_range_byte)
6449 (del_range_both, del_range_2, modify_region)
6450 (prepare_to_modify_buffer, signal_before_change)
6451 (signal_after_change, Fcombine_after_change_execute):
6452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6453 * intervals.c (traverse_intervals, rotate_right, rotate_left)
6454 (balance_an_interval, split_interval_right, split_interval_left)
6455 (find_interval, next_interval, update_interval)
6456 (adjust_intervals_for_insertion, delete_node, delete_interval)
6457 (interval_deletion_adjustment, adjust_intervals_for_deletion)
6458 (static_offset_intervals, offset_intervals)
6459 (merge_interval_right, merge_interval_left, make_new_interval)
6460 (graft_intervals_into_buffer, temp_set_point_both)
6461 (temp_set_point, set_point, adjust_for_invis_intang)
6462 (set_point_both, move_if_not_intangible, get_property_and_range)
6463 (get_local_map, copy_intervals, copy_intervals_to_string)
6464 (compare_string_intervals, set_intervals_multibyte_1):
6465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6466 * intervals.h: Adjust decls to match defn changes elsewhere.
6467 (struct interval):
6468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6469 * keyboard.c (this_command_key_count, this_single_command_key_start)
6470 (before_command_key_count, before_command_echo_length, echo_now)
6471 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
6472 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
6473 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
6474 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
6475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6476 (last_non_minibuf_size, last_point_position, echo_truncate)
6477 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
6478 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
6479 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
6480 (stuff_buffered_input):
6481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6482 (last_auto_save, command_loop_1, read_char):
6483 Use EMACS_INT, not int, to avoid integer overflow.
6484 (record_char): Avoid overflow in total_keys computation.
6485 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
6486 * keyboard.h: Adjust decls to match defn changes elsewhere.
6487 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
6488 (Fkey_description, Fdescribe_vector, Flookup_key):
6489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6490 (click_position): New function, to check that positions are in range.
6491 (Fcurrent_active_maps):
6492 (describe_command):
6493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6494 (Faccessible_keymaps, Fkey_description):
6495 (preferred_sequence_p):
6496 Don't assume fixnum can fit into int.
6497 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
6498 Check for integer overflow in size calculations.
6499 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
6500 avoid mishandling large integers.
6501 * lisp.h: Adjust decls to match defn changes elsewhere.
6502 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
6503 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
6504 (struct Lisp_Marker):
6505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6506 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
6507 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
6508 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
6509 All callers changed.
6510 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
6511 Assume the arg has valid form, since it always does.
6512 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
6513 unsigned integer system type.
6514 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
6515 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
6516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6517 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
6518 (duration_to_sec_usec): New decl.
6519 * lread.c (read_from_string_index, read_from_string_index_byte)
6520 (read_from_string_limit, readchar, unreadchar, openp)
6521 (read_internal_start, read1, oblookup):
6522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6523 (Fload, readevalloop, Feval_buffer, Feval_region):
6524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6525 (openp): Check for out-of-range argument to 'access'.
6526 (read1): Use int, not EMACS_INT, where int is wide enough.
6527 Don't assume fixnum fits into int.
6efdadfd 6528 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
6529 (read_filtered_event): Use duration_to_sec_usec
6530 to do proper overflow checking on durations.
d311d28c
PE
6531 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
6532 in size calculation.
6533 (Fexecute_kbd_macro):
6534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6535 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
6536 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
6537 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
6538 (set_marker_both, set_marker_restricted_both, marker_position)
6539 (marker_byte_position, Fbuffer_has_markers_at):
6540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6541 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 6542 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
6543 It now merely ensures that the menu is large enough, without
6544 necessarily growing it, as this avoids some integer overflow issues.
6545 All callers changed.
6546 (keymap_panes, parse_single_submenu, Fx_popup_menu):
6547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6548 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
6549 Use SAFE_ALLOCA_LISP, not alloca.
6550 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
6551 to EMACS_INT. Check that fixnums are in proper range for system types.
6552 * minibuf.c (minibuf_prompt_width, string_to_object)
6553 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
6554 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
6555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6556 (get_minibuffer, read_minibuf_unwind):
6557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6558 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
6559 this simplifies overflow checking. All callers changed.
6560 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
6561 (Ftest_completion):
6562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6563 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
6564 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
6565 Check that fixnums are in proper range for system types.
6566 (Fx_create_frame, Fx_show_tip):
6567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6568 * nsfont.m (ns_findfonts, nsfont_list_family):
6569 Don't assume fixnum fits in long.
6570 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
6571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6572 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
6573 wide enough.
17fdb222 6574 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
6575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6576 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
6577 (PRINTDECLARE, PRINTPREPARE):
6578 (strout, print_string):
6579 (print, print_preprocess, print_check_string_charset_prop)
6580 (print_object):
6581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6582 (PRINTDECLARE):
6583 (temp_output_buffer_setup, Fprin1_to_string, print_object):
6584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6585 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 6586 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 6587 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
6588 (print_error_message): Use SAFE_ALLOCA, not alloca.
6589 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
6590 (print_depth, new_backquote_output, print_number_index):
6591 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
6592 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
6593 (Fset_process_window_size, Fformat_network_address)
6594 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 6595 (sigchld_handler):
d311d28c 6596 Check that fixnums are in proper range for system types.
d44287d4 6597 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
6598 Check for process-ids out of pid_t range rather than relying on
6599 undefined behavior.
e4d81efc 6600 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
6601 (Fformat_network_address, read_process_output, send_process)
6602 (Fprocess_send_region, status_notify):
6603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6604 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
6605 (wait_reading_process_output, read_process_output, exec_sentinel):
6606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6607 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
6608 (Faccept_process_output): Use duration_to_sec_usec to do proper
6609 overflow checking on durations.
dde14581
PE
6610 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
6611 Don't assume pid_t fits in int.
02481186
PE
6612 * process.h (struct Lisp_Process): Members tick and update_tick
6613 are now of type EMACS_INT, not int.
b62b53e8
PE
6614 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
6615 configured --with-wide-int.
d311d28c
PE
6616 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
6617 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
6618 * search.c (looking_at_1, string_match_1):
6619 (fast_string_match, fast_c_string_match_ignore_case)
6620 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
6621 (scan_newline, find_before_next_newline, search_command)
6622 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
6623 (set_search_regs, wordify):
6624 (Freplace_match):
6625 (Fmatch_data):
6626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6627 (string_match_1, search_buffer, set_search_regs):
6628 (Fmatch_data):
6629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6630 (wordify): Check for overflow in size calculation.
6631 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
6632 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
6633 Check that fixnums are in proper range for system types.
6634 * sound.c (struct sound_device)
6635 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
6636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6637 (Fplay_sound_internal):
6638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 6639 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
6640 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
6641 (Fparse_partial_sexp):
6642 Don't assume fixnums can fit in int.
6643 (struct lisp_parse_state, find_start_pos, find_start_value)
6644 (find_start_value_byte, find_start_begv)
6645 (update_syntax_table, char_quoted, dec_bytepos)
6646 (find_defun_start, prev_char_comend_first, back_comment):
6647 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
6648 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
6649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6650 (Finternal_describe_syntax_value): Check that match_lisp is a
6651 character, not an integer, since the code stuffs it into int.
6652 (scan_words, scan_sexps_forward):
6653 Check that fixnums are in proper range for system types.
6654 (Fforward_word):
6655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6656 (scan_sexps_forward):
6657 Use CHARACTERP, not INTEGERP, since the value must fit into int.
6658 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
6659 * syntax.h: Adjust decls to match defn changes elsewhere.
6660 (struct gl_state_s):
6661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
6662 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
6663 MOST_POSITIVE_FIXNUM.
d311d28c
PE
6664 * sysdep.c (wait_for_termination_1, wait_for_termination)
6665 (interruptible_wait_for_termination, mkdir):
6666 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
6667 (emacs_read, emacs_write):
6668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
6669 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
6670 and double all fit in int.
d311d28c
PE
6671 * term.c (set_tty_color_mode):
6672 Check that fixnums are in proper range for system types.
6673 * termhooks.h (struct input_event):
6674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6675 * textprop.c (validate_interval_range, interval_of)
6676 (Fadd_text_properties, set_text_properties_1)
6677 (Fremove_text_properties, Fremove_list_of_text_properties)
6678 (Ftext_property_any, Ftext_property_not_all)
6679 (copy_text_properties, text_property_list, extend_property_ranges)
6680 (verify_interval_modification):
6681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6682 (Fnext_single_char_property_change)
6683 (Fprevious_single_char_property_change):
6684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
6685 (copy_text_properties):
6686 Check for integer overflow in index calculation.
d311d28c
PE
6687 * undo.c (last_boundary_position, record_point, record_insert)
6688 (record_delete, record_marker_adjustment, record_change)
6689 (record_property_change):
6690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6691 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
6692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6693 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6694 (Fx_hide_tip, Fx_file_dialog):
6695 * w32menu.c (set_frame_menubar):
6696 Use ptrdiff_t, not int, for consistency with rest of code.
6697 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
6698 (select_window, Fdelete_other_windows_internal)
6699 (window_scroll_pixel_based, window_scroll_line_based)
6700 (Frecenter, Fset_window_configuration):
6701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6702 (Fset_window_hscroll, run_window_configuration_change_hook)
6703 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 6704 (Fscroll_other_window, Frecenter):
d311d28c
PE
6705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6706 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
6707 Don't assume fixnum fits in int.
6708 (Fset_window_scroll_bars):
6709 Check that fixnums are in proper range for system types.
6710 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
6711 (string_pos, c_string_pos, number_of_chars, init_iterator)
6712 (in_ellipses_for_invisible_text_p, init_from_display_pos)
6713 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
6714 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
6715 (face_before_or_after_it_pos, handle_invisible_prop)
6716 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
6717 (display_prop_intangible_p, string_buffer_position_lim)
6718 (string_buffer_position, handle_composition_prop, load_overlay_strings)
6719 (get_overlay_strings_1, get_overlay_strings)
6720 (iterate_out_of_display_property, forward_to_next_line_start)
6721 (back_to_previous_visible_line_start, reseat, reseat_to_string)
6722 (get_next_display_element, set_iterator_to_next)
6723 (get_visually_first_element, compute_stop_pos_backwards)
6724 (handle_stop_backwards, next_element_from_buffer)
6725 (move_it_in_display_line_to, move_it_in_display_line)
6726 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6727 (add_to_log, message_dolog, message_log_check_duplicate)
6728 (message2, message2_nolog, message3, message3_nolog
6729 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
6730 (current_message_1, truncate_echo_area, truncate_message_1)
6731 (set_message, set_message_1, store_mode_line_noprop)
6732 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
6733 (text_outside_line_unchanged_p, check_point_in_composition)
6734 (reconsider_clip_changes)
6735 (redisplay_internal, set_cursor_from_row, try_scrolling)
6736 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
6737 (redisplay_window, find_last_unchanged_at_beg_row)
6738 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
6739 (trailing_whitespace_p, find_row_edges, display_line)
6740 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
6741 (display_mode_element, store_mode_line_string)
6742 (pint2str, pint2hrstr, decode_mode_spec)
6743 (display_count_lines, display_string, draw_glyphs)
6744 (x_produce_glyphs, x_insert_glyphs)
6745 (rows_from_pos_range, mouse_face_from_buffer_pos)
6746 (fast_find_string_pos, mouse_face_from_string_pos)
6747 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6749 (safe_call, init_from_display_pos, handle_fontified_prop)
6750 (handle_single_display_spec, load_overlay_strings)
6751 (with_echo_area_buffer, setup_echo_area_for_printing)
6752 (display_echo_area, echo_area_display)
6753 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
6754 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
6755 (redisplay_window, dump_glyph_row, display_mode_line)
6756 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 6757 (handle_display_spec, display_prop_string_p):
d311d28c
PE
6758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6759 (handle_single_display_spec, build_desired_tool_bar_string)
6760 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
6761 (get_specified_cursor_type):
6762 Check that fixnums are in proper range for system types.
6763 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
6764 (Flookup_image_map):
6765 Don't assume fixnums fit in int.
6766 (compare_overlay_entries):
6767 Avoid mishandling comparisons due to subtraction overflow.
6768 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
6769 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
6770 (handle_tool_bar_click):
6771 Use int, not unsigned, since we prefer signed and the signedness
6772 doesn't matter here.
6773 (get_next_display_element, next_element_from_display_vector):
6774 Use int, not EMACS_INT, when int is wide enough.
6775 (start_hourglass): Use duration_to_sec_usec to do proper
6776 overflow checking on durations.
6777 * xfaces.c (Fbitmap_spec_p):
6778 Check that fixnums are in proper range for system types.
6779 (compare_fonts_by_sort_order):
6780 Avoid mishandling comparisons due to subtraction overflow.
6781 (Fx_family_fonts, realize_basic_faces):
6782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6783 (Fx_family_fonts):
6784 Don't assume fixnum fits in int.
6785 Use SAFE_ALLOCA_LISP, not alloca.
6786 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
6787 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
6788 (face_at_buffer_position, face_for_overlay_string)
6789 (face_at_string_position):
6790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6791 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
6792 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
6793 (Fx_show_tip):
6794 Check that fixnums are in proper range for system types.
6795 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6796 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
6797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6798 (Fx_change_window_property): Don't assume fixnums fit in int.
6799 * xfont.c (xfont_chars_supported):
6800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6801 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
6802 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
6803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6804 * xml.c (parse_region):
6805 * xrdb.c (magic_file_p):
6806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6807 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
6808 (x_get_local_selection, x_reply_selection_request)
6809 (x_handle_selection_request, wait_for_property_change):
6810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6811 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
6812 short is wide enough.
6813 (x_send_client_event): Don't assume fixnum fits in int.
6814 * xterm.c (x_x_to_emacs_modifiers):
6815 Don't assume EMACS_INT overflows nicely into int.
6816 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
6817 may come from Lisp.
6818 (handle_one_xevent): NATNUMP can eval its arg twice.
6819 (x_connection_closed):
6820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6821 * xterm.h: Adjust decls to match defn changes elsewhere.
6822 (struct scroll_bar): Use struct vectorlike_header
6823 rather than rolling our own approximation.
6824 (SCROLL_BAR_VEC_SIZE): Remove; not used.
6825
c6574eb5
GM
68262012-05-25 Glenn Morris <rgm@gnu.org>
6827
6828 * lisp.mk (lisp): Update for more files being compiled now.
6829
e8d32c7e
SM
68302012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
6831
48def666
SM
6832 * lread.c: Remove `read_pure' which makes no difference.
6833 (read_pure): Remove var.
6834 (unreadpure): Remove function.
6835 (readevalloop): Don't call read_list with -1 flag.
6836 (read1, read_vector): Don't test read_pure any more.
6837 (read_list): Simplify.
6838
e8d32c7e
SM
6839 * fileio.c, character.h: Minor style tweaks.
6840
4b2addb7
DA
68412012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6842
6843 * window.h (clip_changed): Remove useless declaration.
6844
584461b2
JB
68452012-05-22 Juanma Barranquero <lekktu@gmail.com>
6846
6847 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
6848 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
6849
34374650
PE
68502012-05-22 Paul Eggert <eggert@cs.ucla.edu>
6851
6852 Remove src/m/*.
6853 This directory predates autoconf and is no longer needed nowadays.
6854 Move its few remaining bits of functionality to where they're needed.
6855 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
6856 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
6857 * m/template.h: Remove.
6858 * Makefile.in (M_FILE): Remove. All uses removed.
6859 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
6860 * lisp.h (USE_LSB_TAG):
6861 * mem-limits.h (EXCEEDS_LISP_PTR):
6862 Use VAL_MAX, not VALBITS, in #if.
6863 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
6864 (EMACS_UINT): Define unconditionally now.
6865 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
6866 (BITS_PER_EMACS_INT): New constants, replacing
6867 what used to be in config.h, but not useful in #if.
6868 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
6869 define them any more.
6870 (VAL_MAX): New macro.
6871 (VALMASK): Use it.
6872 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
6873 BITS_PER_EMACS_INT, in #if.
6874 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
6875 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
6876 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
6877 * s/ms-w32.h (DATA_START):
6878 Move here from removed file m/intel386.h.
6879 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
6880 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
6881
261cb4bb
PE
68822012-05-21 Paul Eggert <eggert@cs.ucla.edu>
6883
6884 Assume C89 or later.
6885 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
6886 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6887 (xrealloc):
6888 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
6889 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
6890 * textprop.c, tparam.c (NULL): Remove.
6891 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
6892 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
6893 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
6894 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
6895 * xterm.c (input_signal_count): Assume volatile works.
6896
ff23cd9f
KB
68972012-05-21 Ken Brown <kbrown@cornell.edu>
6898
6899 * xgselect.c (xg_select): Fix first argument in call to 'select'
6900 (bug#11508).
6901
1b170bc6
KB
69022012-05-20 Ken Brown <kbrown@cornell.edu>
6903
6904 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 6905 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 6906
b2f4d39f
KB
69072012-05-19 Ken Brown <kbrown@cornell.edu>
6908
6909 * xfns.c (x_in_use): Remove `static' qualifier.
6910 * xterm.h (x_in_use): Declare.
6911 * xgselect.c: Include xterm.h.
6912 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
6913 and `display_arg' (bug#9754).
6914
003fdae2
PE
69152012-05-19 Paul Eggert <eggert@cs.ucla.edu>
6916
9232a6d9
PE
6917 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
6918
003fdae2
PE
6919 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6920 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
6921
784b56e2
EZ
69222012-05-18 Eli Zaretskii <eliz@gnu.org>
6923
6924 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
6925
6926 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 6927 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
6928
6929 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
6930 reference to image_cache->refcount.
6931 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
6932
a0a79cde
JL
69332012-05-17 Juri Linkov <juri@jurta.org>
6934
6935 * search.c (Fword_search_regexp, Fword_search_backward)
6936 (Fword_search_forward, Fword_search_backward_lax)
6937 (Fword_search_forward_lax): Move functions to isearch.el
6938 (bug#10145, bug#11381).
6939
b0572523
PE
69402012-05-16 Paul Eggert <eggert@cs.ucla.edu>
6941
6942 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
6943
9660f5fc
SM
69442012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
6945
6946 * lread.c (init_obarray): Declare Qt and Qnil as special.
6947
4374de83
GM
69482012-05-14 Glenn Morris <rgm@gnu.org>
6949
6950 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6951 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6952
dc44c39a
PE
69532012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6954
078c97cb
PE
6955 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6956
dc44c39a
PE
6957 * unexaix.c: Port to more-recent AIX compilers.
6958 (report_error, report_error_1, make_hdr, copy_sym)
6959 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6960 Make arguments const char *, not char *, to avoid violations of C
6961 standard and to fix some AIX warnings reported by Gilles Pion.
6962
e18afed7 69632012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6964
6965 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6966 already have overlays loaded.
6967 (handle_single_display_spec): Before returning without displaying
6968 fringe bitmap, synchronize the bidi iterator with the main display
6969 iterator, by calling iterate_out_of_display_property.
6970 (iterate_out_of_display_property): Detect buffer iteration by
6971 testing that it->string is a Lisp string.
6972 (get_next_display_element): When the current object is exhausted,
6973 and there's something on it->stack, call set_iterator_to_next to
6974 proceed with what's on the stack, instead of returning zero.
6975 (set_iterator_to_next): If called at the end of a Lisp string,
6976 proceed to consider_string_end without incrementing string
6977 position. Don't increment display vector index past the end of
6978 the display vector. (Bug#11417)
c8fb9dc6
EZ
6979 (pos_visible_p): Don't report a position visible when move_it_to
6980 stopped at the last line of window, which happens to be scanned
6981 backwards by the bidi iteration. (Bug#11464)
ac268e67 6982
e18afed7 69832012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6984
6985 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6986 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6987 are on a TTY, and thus unable to display on the fringes.
6988 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6989 so we need to signal to the caller that this is a "replacing"
6990 display spec. This fixes display when the spec is invalid or we
6991 are on a TTY.
6992
e18afed7 69932012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6994
6995 * unexaix.c (make_hdr): Fix typo in prototype.
6996 This bug broke the build on AIX. Problem reported by Gilles Pion.
6997
9d0a235a
MA
69982012-05-14 Michael Albinus <michael.albinus@gmx.de>
6999
7000 * keyboard.c (kbd_buffer_get_event): Read special events also in
7001 batch mode. (Bug#11415)
7002
9e6b06ed
GM
70032012-05-12 Glenn Morris <rgm@gnu.org>
7004
7005 * ns.mk: Update for ns_appbindir no longer having trailing "/".
7006
c1a1d7a3
EZ
70072012-05-12 Eli Zaretskii <eliz@gnu.org>
7008
7009 * lisp.mk (lisp): Add newcomment.elc.
7010
3fe7cdc8
GM
70112012-05-12 Glenn Morris <rgm@gnu.org>
7012
7013 * Makefile.in (MKDIR_P): New, set by configure.
7014 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
7015
53f7d2c0
PE
70162012-05-11 Paul Eggert <eggert@cs.ucla.edu>
7017
7018 Remove unused function hourglass_started.
7019 * dispextern.h (hourglass_started):
7020 * w32fns.c (hourglass_started):
7021 * xdisp.c (hourglass_started): Remove.
7022
75aafb17
JB
70232012-05-10 Juanma Barranquero <lekktu@gmail.com>
7024
7025 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
7026 Update dependencies.
7027
12959e8e
PE
70282012-05-10 Paul Eggert <eggert@cs.ucla.edu>
7029
97107e2e
PE
7030 * xgselect.c (xg_select): Put maxfds+1 into a var.
7031 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
7032
12959e8e
PE
7033 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
7034
836d29b3
DA
70352012-05-10 Dave Abrahams <dave@boostpro.com>
7036
7037 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
7038 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
7039
5cb67954
MA
70402012-05-09 Michael Albinus <michael.albinus@gmx.de>
7041
7042 * dbusbind.c (xd_registered_buses): New internal Lisp object.
7043 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
7044 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
7045 Initialize xd_registered_buses.
7046
3478ec45
PE
70472012-05-09 Paul Eggert <eggert@cs.ucla.edu>
7048
b263a6b0
PE
7049 Untag more efficiently if USE_LSB_TAG.
7050 This is based on a proposal by YAMAMOTO Mitsuharu in
7051 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
7052 For an admittedly artificial (nth 8000 longlist) benchmark on
7053 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
7054 Emacs's overall text size by 1%.
7055 * lisp.h (XUNTAG): New macro.
7056 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
7057 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
7058 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
7059 * eval.c (Fautoload):
7060 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
7061 * frame.h (XFRAME): Use XUNTAG.
7062
3478ec45
PE
7063 Port recent dbusbind.c changes to 32-bit --with-wide-int.
7064 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
7065 Remove unportable assumptions about print widths of types like
7066 dbus_uint32_t.
7067 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
7068 intptr_t when converting between pointer and integer, to avoid GCC
7069 warnings about wrong width.
7070
666b903b 70712012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
7072
7073 * w32proc.c (new_child): Force Windows to reserve only 64KB of
7074 stack for each reader_thread, instead of defaulting to 8MB
7075 determined by the linker. This avoids failures in creating
7076 subprocesses on Windows 7, see the discussion in this thread:
7077 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
7078
b120cc17
JC
70792012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
7080
7081 Fix up display of the *Minibuf-0* buffer in the mini window.
7082 * keyboard.c (read_char): Don't clear the echo area if there's no
7083 message to clear.
7084 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7085 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7086
9a4b36f8
MA
70872012-05-07 Michael Albinus <michael.albinus@gmx.de>
7088
7089 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7090 batch mode.
7091
e5f9458f
CY
70922012-05-06 Chong Yidong <cyd@gnu.org>
7093
7094 * lisp.mk (lisp): Update.
7095
eceeb5fc 70962012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7097
7098 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7099
71873e2b
SM
71002012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7101
7102 * data.c (PUT_ERROR): New macro.
7103 (syms_of_data): Use it. Add new error type `user-error'.
7104 * undo.c (user_error): New function.
7105 (Fprimitive_undo): Use it.
7106 * print.c (print_error_message): Adjust print style for `user-error'.
7107 * keyboard.c (user_error): New function.
7108 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7109
ab0fa4e4
PE
71102012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7111
7112 Do not limit current-time-string to years 1000..9999.
7113 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7114 (Fcurrent_time_string): Support any year that is supported by the
7115 underlying localtime representation. Don't use asctime, as it
7116 has undefined behavior for years outside the range -999..9999.
7117
7ed806a7
PE
71182012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7119
7120 Fix race conditions involving setenv, gmtime, localtime, asctime.
7121 Without this fix, interrupts could mess up code that uses these
7122 nonreentrant functions, since setting TZ invalidates existing
7123 tm_zone or tzname values, and since most of these functions return
7124 pointers to static storage.
7125 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7126 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7127 Grow the critical sections to include not just invoking
7128 localtime/gmtime, but also accessing these functions' results
7129 including their tm_zone values if any, and any related TZ setting.
7130 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7131 so that the struct tm is saved in the critical section.
7132 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7133 motivated by the fact that memory allocation needs to be outside
7134 the critical section.
7135
0c16dfed
DA
71362012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7137
7138 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7139 with RESET_INTERVAL.
7140
7141 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7142 Remove duplicated buffer name initialization.
7143
3f83ace8
JM
71442012-05-02 Jim Meyering <jim@meyering.net>
7145
7146 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7147
c7b8541e
JM
7148 * xfns.c (x_window): Use xstrdup (Bug#11375).
7149
90207a15 71502012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7151
7152 * xdisp.c (pos_visible_p): If already at a newline from the
7153 display string before the 'while' loop, don't walk back the glyphs
7154 from it3.glyph_row. Solves assertion violation when the display
7155 string begins with a newline (egg.el). (Bug#11367)
7156
b593d6a9
AH
71572012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7158
7159 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7160 Move to simple.el.
7161
4737362e
GM
71622012-05-01 Glenn Morris <rgm@gnu.org>
7163
99cf43f9
GM
7164 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7165 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7166 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7167 All were removed before 23.1.
7168
9311dcff
GM
7169 * dispnew.c: Remove HAVE_LIBNCURSES test;
7170 it is always true on relevant platforms.
7171
4d5c6349
GM
7172 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7173 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7174
4737362e
GM
7175 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7176
74dd3a6b
AS
71772012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7178
7179 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7180 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7181 Remove.
7182
13c379ee
PE
71832012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7184
7185 Do not avoid creating empty evaporating overlays (Bug#9642).
7186 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7187 That is, do not delete an evaporating overlay if it becomes
7188 empty after its bounds are adjusted to fit within its buffer.
7189 This fix caused other problems, and I'm reverting it until we get
7190 to the bottom of them.
7191
a8e7d6d7 71922012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7193
7194 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7195
a8e7d6d7 71962012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7197
7198 * xdisp.c (pos_visible_p): If the window start position is beyond
7199 ZV, start the display from buffer beginning. Prevents assertion
7200 violation in init_iterator when the minibuffer window is scrolled
7201 via the scroll bar.
7202
7203 * window.c (window_scroll_pixel_based): Likewise.
7204
a8e7d6d7 72052012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7206
7207 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7208
a8e7d6d7 72092012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7210
7211 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7212 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7213
a8e7d6d7 72142012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7215
b593d6a9
AH
7216 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7217 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7218
1c6900d9
EZ
72192012-04-26 Eli Zaretskii <eliz@gnu.org>
7220
4c3fa1d9
EZ
7221 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7222 display element, check also the underlying string or buffer
7223 character. (Bug#11341)
7224
1c6900d9
EZ
7225 * w32menu.c: Include w32heap.h.
7226 (add_menu_item): If the call to AppendMenuW (via
7227 unicode_append_menu) fails, disable Unicode menus only if we are
7228 running on Windows 9X/Me.
7229
42bf8205
AS
72302012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7231
7232 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7233 (xgetint): Add missing shift for LSB tags.
7234
b1bac16e
MR
72352012-04-24 Martin Rudalics <rudalics@gmx.at>
7236
7237 * keyboard.c (read_char): Don't wipe echo area for select window
7238 events: These might get delayed via `mouse-autoselect-window'
7239 (Bug#11304).
7240
d69621cc
JB
72412012-04-24 Juanma Barranquero <lekktu@gmail.com>
7242
7243 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7244 manipulation of :loaded-from data.
7245
02fd101b
JB
72462012-04-23 Juanma Barranquero <lekktu@gmail.com>
7247
7248 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7249 now a cons (bug#11311).
7250
888bec30
PE
72512012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7252
89a438bd
PE
7253 Do not create empty overlays with the evaporate property (Bug#9642).
7254 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7255 if it becomes empty after its bounds are adjusted to fit within
7256 its buffer. Without this fix, in a nonempty buffer (let ((o
7257 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7258 yields an empty overlay that has the evaporate property, which is
7259 not supposed to happen.
7260
1068fe4d
PE
7261 Fix minor GTK3 problems found by static checking.
7262 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7263 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7264 (struct _EmacsFixedClass, emacs_fixed_get_type):
7265 Move decls here from emacsgtkfixed.h, since they needn't be public.
7266 (emacs_fixed_get_type): Now static.
7267 (emacs_fixed_class_init): Omit unused local.
7268 (emacs_fixed_child_type): Remove; unused.
7269 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7270 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7271 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7272 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7273 (EMACS_FIXED_GET_CLASS): Remove; unused.
7274 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7275
888bec30
PE
7276 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7277 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7278
de85e130
PE
72792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7280
d0baac98 7281 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7282 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7283 (__malloc_size_t, __malloc_ptrdiff_t):
7284 Remove. All uses removed, replaced by the definiens if needed,
7285 since we can assume C89 or better now.
7286 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7287 (protect_malloc_state, align, get_contiguous_space)
7288 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7289 (malloc_atfork_handler_child, malloc_enable_thread)
7290 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7291 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7292 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7293 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7294 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7295 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7296 Define using prototypes, not old style.
7297 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7298 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7299 (align): Don't assume that signed integer overflow wraps around.
7300 Omit unused local var.
7301 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7302 (_free_internal_nolock, memalign, mallochook, reallochook):
7303 Omit no-longer-needed casts.
7304 (valloc): Use getpagesize, not __getpagesize.
7305 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7306 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7307
de85e130
PE
7308 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7309
dcbf5805
MA
73102012-04-22 Michael Albinus <michael.albinus@gmx.de>
7311
7312 Move functions from C to Lisp. Make non-blocking method calls
7313 the default. Implement further D-Bus standard interfaces.
7314
7315 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7316 (QCdbus_request_name_allow_replacement)
7317 (QCdbus_request_name_replace_existing)
7318 (QCdbus_request_name_do_not_queue)
7319 (QCdbus_request_name_reply_primary_owner)
7320 (QCdbus_request_name_reply_in_queue)
7321 (QCdbus_request_name_reply_exists)
7322 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7323 (QCdbus_registered_serial, QCdbus_registered_method)
7324 (QCdbus_registered_signal): New Lisp objects.
7325 (XD_DEBUG_MESSAGE): Use sizeof.
7326 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
7327 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
7328 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
7329 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
7330 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
7331 (xd_signature, xd_append_arg): Allow float for integer types.
7332 (xd_get_connection_references): New function.
b593d6a9
AH
7333 (xd_get_connection_address): Rename from xd_initialize.
7334 Return cached address.
dcbf5805
MA
7335 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
7336 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
7337 level.
7338 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 7339 Return number of refcounts.
dcbf5805
MA
7340 (Fdbus_get_unique_name): Make stronger parameter check.
7341 (Fdbus_message_internal): New defun.
7342 (Fdbus_call_method, Fdbus_call_method_asynchronously)
7343 (Fdbus_method_return_internal, Fdbus_method_error_internal)
7344 (Fdbus_send_signal, Fdbus_register_service)
7345 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
7346 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
7347 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
7348 (Vdbus_compiled_version, Vdbus_runtime_version)
7349 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
7350 (Vdbus_message_type_method_return, Vdbus_message_type_error)
7351 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
7352 (Vdbus_registered_buses, Vdbus_registered_objects_table):
7353 Adapt docstring.
dcbf5805 7354
52828e02
PE
73552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7356
da05bc4c
PE
7357 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
7358 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
7359 Do not assume ptrdiff_t is the same width as 'int'.
7360
52828e02
PE
7361 * alloc.c: Handle unusual debugging option combinations.
7362 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
7363 since the two debugging options are incompatible.
7364 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
7365 is defined.
7366 (mem_init, mem_insert, mem_insert_fixup):
7367 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
7368 (NEED_MEM_INSERT): Remove; no longer needed.
7369
f01769f9
LL
73702012-04-22 Leo Liu <sdl.web@gmail.com>
7371
7372 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
7373
5790543d
PE
73742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7375
7376 * sysdep.c [__FreeBSD__]: Minor cleanups.
7377 (list_system_processes, system_process_attributes) [__FreeBSD__]:
7378 Use Emacs indenting style more consistently. Avoid some casts.
7379 Use 'double' consistently rather than mixing 'float' and 'double'.
7380
b91b7e4d
EW
73812012-04-21 Eduard Wiebe <usenet@pusto.de>
7382
b593d6a9
AH
7383 * sysdep.c (list_system_processes, system_process_attributes):
7384 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 7385
6114eb15
AS
73862012-04-21 Andreas Schwab <schwab@linux-m68k.org>
7387
7388 * lisp.mk (lisp): Update.
7389
2f38dff7
PE
73902012-04-20 Paul Eggert <eggert@cs.ucla.edu>
7391
7392 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
7393 It is never used otherwise.
7394
4ae29f89
SM
73952012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
7396
7397 * print.c (print_preprocess): Only check print_depth if print-circle
7398 is nil.
7399 (print_object): Check for cycles even when print-circle is nil and
7400 print-gensym is t, but only check print_depth if print-circle is nil.
7401
f30d612a
CY
74022012-04-20 Chong Yidong <cyd@gnu.org>
7403
7404 * process.c (wait_reading_process_output): If EIO occurs on a pty,
7405 set the status to "failed" and ensure that sentinel is run.
7406
c07a4c0b 74072012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
7408
7409 * process.c (Fset_process_inherit_coding_system_flag)
7410 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 7411 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 7412
c07a4c0b 74132012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
7414
7415 * xdisp.c (string_buffer_position_lim): Limit starting position to
7416 BEGV.
7417 (set_cursor_from_row): If called for a mode-line or header-line
7418 row, return zero immediately.
7419 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
7420 farther than the first row after the header line, if any.
7421 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
7422 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
7423
c07a4c0b 74242012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7425
4ae29f89
SM
7426 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
7427 (bug#11238).
ad3a2b41 7428
c07a4c0b 74292012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 74302012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
7431
7432 configure: new option --enable-gcc-warnings (Bug#11207)
7433 * Makefile.in (C_WARNINGS_SWITCH): Remove.
7434 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
7435 (ALL_CFLAGS): Use new macros rather than old.
7436 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
7437 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
7438 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
7439 -Wunused-result, -Wunused-variable. This should go away once
7440 the Emacs and Gnulib regex code is merged.
7441 (xmalloc, xrealloc): Now static.
7442
aba027e8
PE
74432012-04-17 Paul Eggert <eggert@cs.ucla.edu>
7444
7445 * dired.c (Fsystem_groups): Remove unused local.
7446
e5a36063
GM
74472012-04-17 Glenn Morris <rgm@gnu.org>
7448
7449 * dired.c (Fsystem_users): Doc fix.
7450
316411f0
DA
74512012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
7452
7453 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
7454 (syms_of_dired): Add them.
7455
9426aba4
PE
74562012-04-16 Paul Eggert <eggert@cs.ucla.edu>
7457
b62a57be
PE
7458 Fix minor alloc.c problems found by static checking.
7459 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
7460 New extern decls, to avoid calling undeclared functions.
7461 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7462 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
7463 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
7464 (NEED_MEM_INSERT): New macro.
7465 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 7466 Remove one incorrect comment and fix another.
b62a57be 7467
3539f31f
PE
7468 Fix minor ralloc.c problems found by static checking.
7469 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7470 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
7471 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7472 (r_alloc_sbrk): Now static.
7473
a041960a
PE
7474 Improve ralloc.c interface checking.
7475 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7476 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
7477 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
7478 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
7479 [REL_ALLOC]: ... to here, to check interface.
7480 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
7481 Remove decls. This fixes an "It stinks!".
7482
9426aba4
PE
7483 * alloc.c (which_symbols): Fix alignment issue / type clash.
7484
d55c12ed
AS
74852012-04-15 Andreas Schwab <schwab@linux-m68k.org>
7486
7487 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
7488 (struct Lisp_Misc_Any): Likewise.
7489 (struct Lisp_Free): Likewise.
7490 * alloc.c (union aligned_Lisp_Symbol): Define.
7491 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
7492 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
7493 (union aligned_Lisp_Misc): Define.
7494 (MARKER_BLOCK_SIZE, struct marker_block): Use union
7495 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 7496 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 7497
b948ce8b
PE
74982012-04-14 Paul Eggert <eggert@cs.ucla.edu>
7499
7500 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
7501 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
7502 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
7503 * s/netbsd.h, s/sol2-6.h:
7504 Remove definition of GC_MARK_STACK, since the default now works.
7505 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
7506 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
7507 no longer the default.
7508 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
7509
35dc09a1 75102012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7511
35dc09a1
GM
7512 * lread.c (lisp_file_lexically_bound_p):
7513 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 7514
35dc09a1
GM
75152012-04-14 Eli Zaretskii <eliz@gnu.org>
7516
7517 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
7518 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
7519
75202012-04-14 Jan Djärv <jan.h.d@swipnet.se>
7521
7522 * nsterm.m (constrainFrameRect): Always constrain when there is only
7523 one screen (Bug#10962).
7524
bcd86815
KB
75252012-04-13 Ken Brown <kbrown@cornell.edu>
7526
7527 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
7528
c25df26e
RT
75292012-04-13 Reuben Thomas <rrt@sc3d.org>
7530
7531 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
7532
0fc59f1e
DC
75332012-04-11 Daniel Colascione <dancol@dancol.org>
7534
7535 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
7536 against is gone. It's better to use vfork now so that when Cygwin
7537 gains a new, working vfork, we use it automatically (bug#10398).
7538
de8c03dc
SM
75392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7540
7541 * window.c (save_window_save): Obey window-point-insertion-type.
7542
2f097256
GM
75432012-04-11 Glenn Morris <rgm@gnu.org>
7544
7545 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
7546
453b951e
SM
75472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7548
7549 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
7550
75f1671a 75512012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
7552
7553 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
7554 (force_quit_count): New var.
7555 (handle_interrupt): Use it.
7556
2a8ce227
JB
75572012-04-10 Juanma Barranquero <lekktu@gmail.com>
7558
7559 * w32.c (w32_delayed_load): Record the full path of the library
7560 being loaded (bug#10424).
7561
935396c0
GM
75622012-04-09 Glenn Morris <rgm@gnu.org>
7563
05920a43
GM
7564 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
7565 not just in the obarray, before snarfing them. (Bug#11036)
7566
935396c0
GM
7567 * Makefile.in ($(leimdir)/leim-list.el):
7568 Pass EMACS rather than BUILT_EMACS.
7569
a18ecafa
TZ
75702012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
7571
7572 * process.c (make_process):
7573 * process.h: Add integer `gnutls_handshakes_tried' member to
7574 process struct.
7575
6bbef4e5
JC
7576 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
7577 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
7578
7579 * gnutls.c (gnutls_log_function2i): Convenience log function.
7580 (emacs_gnutls_read): Use new log functions,
7581 `gnutls_handshakes_tried' process member, and
7582 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
7583 attempts per process (connection).
7584
b4d3bc10
CY
75852012-04-09 Chong Yidong <cyd@gnu.org>
7586
7587 * eval.c (Fuser_variable_p, user_variable_p_eh)
7588 (lisp_indirect_variable): Functions deleted.
7589 (Fdefvar): Caller changed.
7590
7591 * callint.c (Finteractive, Fcall_interactively):
7592 * minibuf.c (Fread_variable): Callers changed.
7593
70f4d973
EZ
75942012-04-09 Eli Zaretskii <eliz@gnu.org>
7595
7596 * xdisp.c (set_cursor_from_row): If the display string appears in
7597 the buffer at position that is closer to point than the position
7598 after the display string, display the cursor on the first glyph of
7599 the display string. Fixes cursor display when a 'display' text
7600 property immediately follows invisible text. (Bug#11094)
7601
cb3c2e3e
PE
76022012-04-09 Paul Eggert <eggert@cs.ucla.edu>
7603
7604 composite.c: use 'double' consistently
7605 * composite.c (get_composition_id): Use 'double' consistently
7606 instead of converting 'float' to 'double' and vice versa; this is
7607 easier to understand and avoids a GCC warning.
7608
fd06db5d
GM
76092012-04-09 Glenn Morris <rgm@gnu.org>
7610
50fe702a
GM
7611 * Makefile.in: Generate leim-list with bootstrap-emacs, in
7612 preparation for dumping it with emacs. (Bug#4789)
7613 (leimdir): New variable.
7614 ($(leimdir)/leim-list.el): New rule.
7615 (emacs$(EXEEXT)): Depend on leim-list.el.
7616
fd06db5d
GM
7617 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
7618 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
7619 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
7620
55c131ee
AS
76212012-04-08 Andreas Schwab <schwab@linux-m68k.org>
7622
7623 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
7624 proper alignment.
7625
9209588f
JB
76262012-04-07 Juanma Barranquero <lekktu@gmail.com>
7627
7628 * xml.c (init_libxml2_functions) [WINDOWSNT]:
7629 Remove unused local variable.
7630
e3fb2efb
PE
76312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7632
7633 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
7634 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
7635 (mark_memory): Mark Lisp_Objects only if pointers might hide in
7636 objects, as mark_maybe_pointer will catch them otherwise.
7637 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
7638 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
7639
b5385551
PE
76402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7641
7642 Fix typo that broke non-Windows builds.
7643 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
7644
9078ead6
EZ
76452012-04-07 Eli Zaretskii <eliz@gnu.org>
7646
7647 Support building on MS-Windows with libxml2.
7648
7649 * makefile.w32-in (OBJ2): Add xml.$(O).
7650 (GLOBAL_SOURCES): Add xml.c.
7651 ($(BLD)/xml.$(O)): New dependency list.
7652
7653 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
7654 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
7655 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
7656 [!WINDOWSNT]: New macros.
7657 (init_libxml2_functions, libxml2_loaded_p): New functions.
7658 (parse_region): Call fn_xmlCheckVersion instead of using the macro
7659 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
7660 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
7661 Calls xmlCleanupParser only if libxml2 was loaded (or statically
7662 linked in).
6bbef4e5
JC
7663 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
7664 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
7665 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
7666
7667 * emacs.c: Don't include libxml/parser.h.
7668 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
7669 xmlCleanupParser directly.
7670
7671 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
7672
3811fdf3
EZ
76732012-04-07 Eli Zaretskii <eliz@gnu.org>
7674
7675 * indent.c (Fvertical_motion): If there is a display string at
7676 point, use it.vpos to compute how many lines to backtrack after
7677 move_it_to point. (Bug#11133)
7678
2f8e16b2
EZ
76792012-04-06 Eli Zaretskii <eliz@gnu.org>
7680
7681 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
7682 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
7683 about subtle differences between FETCH_CHAR* and STRING_CHAR*
7684 macros related to unification of CJK characters. For the details,
7685 see the discussion following the message here:
7686 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
7687
3d439cd1
CY
76882012-04-04 Chong Yidong <cyd@gnu.org>
7689
7690 * keyboard.c (Vdelayed_warnings_list): Doc fix.
7691
8bc53d00
EZ
76922012-04-01 Eli Zaretskii <eliz@gnu.org>
7693
7694 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
7695 instead of alloca. (Bug#11138)
7696
3b0512a3
AS
76972012-04-01 Andreas Schwab <schwab@linux-m68k.org>
7698
7699 * w32menu.c (is_simple_dialog): Properly check lisp types.
7700 (Bug#11141)
7701
8427ddd2
EZ
77022012-03-31 Eli Zaretskii <eliz@gnu.org>
7703
979022ef
EZ
7704 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
7705 position we get to after a call to move_it_to fails the
7706 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
7707 only if we wind up in a string from display property. (Bug#11063)
7708
a6b1c7cc
EZ
7709 * window.c (Fdelete_other_windows_internal): Invalidate the row
7710 and column information about mouse highlight, so that redisplay
7711 restores it after reallocating the glyph matrices. (Bug#7464)
7712
8427ddd2
EZ
7713 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
7714 string comes from a `display' text property, use the buffer
7715 position of that property as if we actually saw that position in
7716 the row's glyphs.
697ba24b
EZ
7717 (move_it_by_lines): Remove the assertion that
7718 "it->current_x == 0 && it->hpos == 0" which can be legitimately
7719 violated when there's a before-string at the beginning of a line.
7720 (Bug#11063)
8427ddd2 7721
65a0a738
EZ
77222012-03-30 Eli Zaretskii <eliz@gnu.org>
7723
7724 * xdisp.c (append_space_for_newline): If the default face was
7725 remapped, use the remapped face for the appended newline.
7726 (extend_face_to_end_of_line): Use the remapped default face for
7727 extending the face to the end of the line.
7728 (display_line): Call extend_face_to_end_of_line when the default
7729 face was remapped. (Bug#11068)
7730
581355cc
EZ
77312012-03-29 Eli Zaretskii <eliz@gnu.org>
7732
7733 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
7734
e8fc049f
SM
77352012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7736
7737 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
7738
4fb9a543
GM
77392012-03-27 Glenn Morris <rgm@gnu.org>
7740
7741 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
7742 Doc fixes.
7743
679910f1
KH
77442012-03-26 Kenichi Handa <handa@m17n.org>
7745
7746 * dispextern.h (struct glyph): Fix previous change. Change the
7747 bit length of glyphless.ch to 25 (Bug#11082).
7748
90d49b7f
CY
77492012-03-26 Chong Yidong <cyd@gnu.org>
7750
7751 * keyboard.c (Vselection_inhibit_update_commands): New variable.
7752 (command_loop_1): Use it; inhibit selection update for
7753 handle-select-window too (Bug#8996).
7754
f514f6f0
FP
77552012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
7756
e8fc049f 7757 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 7758
bf43fa51
KH
77592012-03-25 Kenichi Handa <handa@m17n.org>
7760
7761 * dispextern.h (struct glyph): Change the bit length of
7762 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
7763
8a0c01dd
EZ
77642012-03-24 Eli Zaretskii <eliz@gnu.org>
7765
7766 * s/ms-w32.h (tzname): Include time.h before redirecting to
7767 _tzname. Fixes the MSVC build. (Bug#9960)
7768
7d1c3a76
AS
77692012-03-24 Andreas Schwab <schwab@linux-m68k.org>
7770
8ed79523
AS
7771 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
7772 characters.
7773
7d1c3a76
AS
7774 * xterm.c (XTread_socket): Only modify handling_signal if
7775 !SYNC_INPUT. (Bug#11080)
7776
e99a9b8b
EZ
77772012-03-23 Eli Zaretskii <eliz@gnu.org>
7778
7779 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
7780 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
7781 when fetching a multibyte character consumes more bytes than
7782 CHAR_BYTES returns, due to unification of CJK characters in
7783 string_char. (Bug#11073)
7784
5063c0e1
TN
77852012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
7786
7787 * process.c (wait_reading_process_output): Handle pty disconnect
7788 by refraining from sending oneself a SIGCHLD (bug#10933).
7789
9f851fbd
CY
77902012-03-22 Chong Yidong <cyd@gnu.org>
7791
7792 * dispextern.h (struct it): New member string_from_prefix_prop_p.
7793
5063c0e1 7794 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
7795 Mark string as coming from a prefix property.
7796 (handle_face_prop): Use default face for prefix strings (Bug#4281).
7797 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
7798
fb5b8aca
CY
77992012-03-21 Chong Yidong <cyd@gnu.org>
7800
7801 * xfaces.c (Vface_remapping_alist): Doc fix.
7802
62356a1b
EZ
78032012-03-20 Eli Zaretskii <eliz@gnu.org>
7804
7805 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
7806 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
7807 Doc fixes.
62356a1b 7808
025de85b
CY
78092012-03-20 Chong Yidong <cyd@gnu.org>
7810
7811 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
7812 to reflect default non-nil value of redisplay-dont-pause.
7813
4827f94e
KH
78142012-03-19 Kenichi Handa <handa@m17n.org>
7815
7816 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
7817 it fit in a valid range (Bug#11003).
7818
e50a24a2
EZ
78192012-03-18 Eli Zaretskii <eliz@gnu.org>
7820
7821 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
7822 that is not from display property, accept the row as a "cursor
7823 row" if one of the string's character has a non-nil `cursor'
7824 property. Fixes cursor positioning when there are newlines in
7825 overlay strings, e.g. in icomplete.el. (Bug#11035)
7826
9af5ed87
PE
78272012-03-12 Paul Eggert <eggert@cs.ucla.edu>
7828
7829 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
7830
d1f55f16
CY
78312012-03-12 Chong Yidong <cyd@gnu.org>
7832
7833 * eval.c (inhibit_lisp_code): Rename from
7834 inhibit_window_configuration_change_hook; move from window.c.
7835
7836 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7837 * window.c (run_window_configuration_change_hook)
7838 (syms_of_window): Callers changed.
7839
66c5eebd
CY
78402012-03-11 Chong Yidong <cyd@gnu.org>
7841
413df973
CY
7842 * keymap.c (Fkey_description): Doc fix (Bug#9700).
7843
66c5eebd
CY
7844 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
7845
1de11f56
CY
78462012-03-10 Chong Yidong <cyd@gnu.org>
7847
7848 * frame.c (other_visible_frames): Don't assume the selected frame
7849 is visible (Bug#10955).
7850
cae07000
SM
78512012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
7852
7853 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
7854
89c94350
JD
78552012-03-08 Jan Djärv <jan.h.d@swipnet.se>
7856
7857 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
7858 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7859 zero (Bug#10954).
7860
999dd333
GM
78612012-03-03 Glenn Morris <rgm@gnu.org>
7862
01a6dcc8 7863 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 7864
de0100f2
EZ
78652012-03-02 Eli Zaretskii <eliz@gnu.org>
7866
7867 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
7868 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
7869 (redisplay_window, next_element_from_string): Fix typos in
7870 comments.
3e441275
EZ
7871 (redisplay_window): Pass to move_it_vertically the margin in
7872 pixels, not in screen lines.
de0100f2 7873
96a72ee9
GM
78742012-03-02 Glenn Morris <rgm@gnu.org>
7875
7876 * buffer.c (buffer-list-update-hook): Doc fix.
7877
312508d7
EZ
78782012-02-29 Eli Zaretskii <eliz@gnu.org>
7879
7880 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
7881 push_it before setting up the iterator for the first overlay
7882 string, even if we have an empty string loaded.
7883 (next_overlay_string): If there's an empty string on the iterator
7884 stack, pop the stack. (Bug#10903)
7885
27f3c637
PE
78862012-02-25 Paul Eggert <eggert@cs.ucla.edu>
7887
7888 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
7889 Suggested by Stefan Monnier in
7890 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
7891 * alloc.c (widen_to_Lisp_Object): New static function.
7892 (mark_memory): Also mark Lisp_Objects by fetching pointer words
7893 and widening them to Lisp_Objects. This would work even if
7894 USE_LSB_TAG is defined and wide integers are used, which might
7895 happen in a future version of Emacs.
7896
3c9dfce6
CY
78972012-02-25 Chong Yidong <cyd@gnu.org>
7898
fa74b241
CY
7899 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
7900 Doc fix.
7901
3c9dfce6
CY
7902 * xselect.c (Fx_selection_exists_p): Doc fix.
7903 (x_clipboard_manager_save_all): Print an informative message
7904 before saving to clipboard manager.
7905
9486df08
CY
79062012-02-24 Chong Yidong <cyd@gnu.org>
7907
7908 * keyboard.c (process_special_events): Handle all X selection
7909 requests in kbd_buffer, not just the next one (Bug#8869).
7910
f01d3321
CY
79112012-02-23 Chong Yidong <cyd@gnu.org>
7912
7913 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
7914 call when setting menu-bar-lines and tool-bar-lines parameters.
7915 (unwind_create_frame_1): New helper function.
7916
7917 * window.c (inhibit_window_configuration_change_hook): New var.
7918 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 7919 (syms_of_window): Initialize it.
f01d3321 7920
86b847b6
CY
79212012-02-22 Chong Yidong <cyd@gnu.org>
7922
7923 * xterm.c (x_draw_image_relief): Add missing type check for
7924 Vtool_bar_button_margin (Bug#10743).
7925
a59225b1
CY
79262012-02-21 Chong Yidong <cyd@gnu.org>
7927
7928 * fileio.c (Vfile_name_handler_alist): Doc fix.
7929
7930 * buffer.c (Fget_file_buffer): Protect against invalid file
7931 handler return value.
7932
310f5bd4
PE
79332012-02-20 Paul Eggert <eggert@cs.ucla.edu>
7934
cb3a28cc
PE
7935 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
7936 when computing $valmask.
7937
310f5bd4
PE
7938 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7939 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
7940 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
7941 It's useless in that case, and it can cause problems on hosts
7942 that allocate halves of EMACS_INT values separately.
7943 Reported by Dan Horák. Diagnosed by Andreas Schwab in
7944 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
7945 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
7946 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7947 it avoids undefined behavior on hosts where shifting right by more
7948 than the word width has undefined behavior.
7949
2375c96a
CY
79502012-02-19 Chong Yidong <cyd@gnu.org>
7951
7952 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7953 (Funhandled_file_name_directory, Ffile_name_as_directory)
7954 (Fdirectory_file_name, Fexpand_file_name)
7955 (Fsubstitute_in_file_name): Protect against invalid file handler
7956 return values (Bug#10845).
7957
3eb49e71
EZ
79582012-02-18 Eli Zaretskii <eliz@gnu.org>
7959
7960 * .gdbinit (pitx): Fix incorrect references to fields of the
7961 iterator stack.
7962
7b926f3f
CY
79632012-02-17 Chong Yidong <cyd@gnu.org>
7964
7965 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7966
11273115
PE
79672012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7968
7969 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7970 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7971
c3a70e2b
CY
79722012-02-15 Chong Yidong <cyd@gnu.org>
7973
7974 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7975 marked as special. Also, starting docstrings with * is obsolete.
7976
0ca43699
AS
79772012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7978
7979 * gnutls.c (emacs_gnutls_write): Fix last change.
7980
2e8f3c56
LI
79812012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7982
7983 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7984 send_process.
7985
af70074f
SM
79862012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7987
7988 * keymap.c (Fsingle_key_description): Handle char ranges.
7989
95986d52
CY
79902012-02-12 Chong Yidong <cyd@gnu.org>
7991
afd83bd1
CY
7992 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7993 as that creates a dangerous corner case.
7994
95986d52
CY
7995 * window.c (Fdelete_window_internal): Invalidate the mouse
7996 highlight (Bug#9904).
7997
bd7da63e
GM
79982012-02-12 Glenn Morris <rgm@gnu.org>
7999
8000 * xselect.c (Fx_own_selection_internal)
8001 (Fx_get_selection_internal, Fx_disown_selection_internal)
8002 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
8003 * nsselect.m (Fx_own_selection_internal)
8004 (Fx_disown_selection_internal, Fx_selection_exists_p)
8005 (Fx_selection_owner_p, Fx_get_selection_internal):
8006 Sync docs and argument specs with the xselect.c versions.
8007
77abcbc2
LI
80082012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
8009
8010 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
8011
90b671e2
EZ
80122012-02-11 Eli Zaretskii <eliz@gnu.org>
8013
1c0ca0b7
EZ
8014 * w32select.c (Fx_selection_exists_p): Sync doc string and
8015 argument list with xselect.c. (Bug#10783)
8016
8017 * w16select.c (Fx_selection_exists_p): Sync doc string and
8018 argument list with xselect.c. (Bug#10783)
90b671e2 8019
49241268
GM
80202012-02-10 Glenn Morris <rgm@gnu.org>
8021
8022 * fns.c (Fsecure_hash): Doc fix.
8023
f998bbe7 80242012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
8025
8026 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
8027
0992bd9c
CY
80282012-02-07 Chong Yidong <cyd@gnu.org>
8029
8030 * buffer.c (Fbuffer_local_variables)
8031 (buffer_lisp_local_variables): Handle unbound vars correctly;
8032 don't let Qunbound leak into Lisp.
8033
af008560
GM
80342012-02-07 Glenn Morris <rgm@gnu.org>
8035
dd605cc4
GM
8036 * image.c (Fimagemagick_types): Doc fix.
8037
af008560
GM
8038 * image.c (imagemagick-render-type): Change it from a lisp object
8039 to an integer. Move the doc here from the lisp manual.
8040 Treat all values not equal to 0 the same.
8041
1449fa1d
CY
80422012-02-06 Chong Yidong <cyd@gnu.org>
8043
8044 * doc.c (store_function_docstring): Avoid applying docstring of
8045 alias to base function (Bug#2603).
8046
3723ec07
AS
80472012-02-04 Andreas Schwab <schwab@linux-m68k.org>
8048
8049 * .gdbinit (pp1, pv1): Remove redundant defines.
8050 (pr): Use pp.
8051
79c1cc1e
CY
80522012-02-04 Chong Yidong <cyd@gnu.org>
8053
8054 * nsterm.m: Declare a global (Bug#10694).
8055
d7f29f8e
EZ
80562012-02-04 Eli Zaretskii <eliz@gnu.org>
8057
cae07000
SM
8058 * w32.c (get_emacs_configuration_options):
8059 Include --enable-checking, if specified, in the return value.
d7f29f8e 8060
3b95a6f9
MR
80612012-02-04 Martin Rudalics <rudalics@gmx.at>
8062
8063 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
8064 after rounding frame sizes. (Bug#9723)
8065
d6fa96a6
EZ
80662012-02-04 Eli Zaretskii <eliz@gnu.org>
8067
8068 * keyboard.c (adjust_point_for_property): Don't position point
8069 before BEGV. (Bug#10696)
8070
df0b2940
PE
80712012-02-03 Paul Eggert <eggert@cs.ucla.edu>
8072
8073 Handle overflow when computing char display width (Bug#9496).
8074 * character.c (char_width): Return EMACS_INT, not int.
8075 (char_width, c_string_width): Check for overflow when
8076 computing the width; this is possible now that individual
8077 characters can have unbounded width. Problem introduced
8078 by merge from Emacs 23 on 2012-01-19.
8079
6bee44d6
MA
80802012-02-02 Michael Albinus <michael.albinus@gmx.de>
8081
8082 * dbusbind.c (Fdbus_register_method): Mention the return value
8083 :ignore in the docstring.
8084
44f92739
GM
80852012-02-02 Glenn Morris <rgm@gnu.org>
8086
1b9f60cc
GM
8087 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8088
44f92739
GM
8089 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8090 Unconditionally set to t. (Bug#10673)
8091 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8092 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8093 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8094
c5d3843c
KH
80952012-02-02 Kenichi Handa <handa@m17n.org>
8096
8097 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8098 0, do not call append_composite_glyph.
8099
159462d4 81002012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8101
8102 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8103 NULL (Bug#6988).
8104 (x_produce_glyphs): If the component of a composition is a null
8105 string, set it->pixel_width to 1 to avoid zero-width glyph.
8106
78cef877
EZ
81072012-02-01 Eli Zaretskii <eliz@gnu.org>
8108
8109 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8110 first 2 arguments are identical. This makes inserting large
8111 output from a subprocess an order of magnitude faster on
8112 MS-Windows, where all sbrk'ed memory is always contiguous.
8113
97897668
GM
81142012-01-31 Glenn Morris <rgm@gnu.org>
8115
8116 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8117 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8118 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8119
31fd3586
GM
81202012-01-29 Glenn Morris <rgm@gnu.org>
8121
8122 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8123
0e24a8b2
CY
81242012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8125
8126 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8127
cc0adcb0
CY
81282012-01-28 Chong Yidong <cyd@gnu.org>
8129
8130 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8131
acc28cb9
CY
81322012-01-26 Chong Yidong <cyd@gnu.org>
8133
9c69cfb7
CY
8134 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8135
acc28cb9
CY
8136 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8137 repeat counts (Bug#10507).
8138
48da7392
GM
81392012-01-26 Glenn Morris <rgm@gnu.org>
8140
8141 * lread.c (syms_of_lread): Doc fix.
8142
14af5f7f
CY
81432012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8144
8145 * coding.c (encode_designation_at_bol): Change return value to
8146 EMACS_INT.
8147
0b21c100
CY
81482012-01-25 Chong Yidong <cyd@gnu.org>
8149
8150 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8151
3c2907f7
CY
81522012-01-21 Chong Yidong <cyd@gnu.org>
8153
8154 * floatfns.c (Fcopysign): Make the second argument non-optional,
8155 since nil is not allowed anyway.
8156
959ad23f
AS
81572012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8158
8159 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8160 (send_process): Likewise.
8161
34a02f46
MR
81622012-01-19 Martin Rudalics <rudalics@gmx.at>
8163
8164 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8165 (Vwindow_persistent_parameters): Do not use Qstate.
8166 Rewrite doc-strings.
34a02f46 8167
1259009a 81682012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8169
8170 * character.c (char_width): New function.
70d4fdf6
GM
8171 (Fchar_width, c_string_width, lisp_string_width):
8172 Use char_width (Bug#9496).
25ed9e61 8173
6a6ee00d
MR
81742012-01-16 Martin Rudalics <rudalics@gmx.at>
8175
8176 * window.c (Vwindow_persistent_parameters): New variable.
8177 (Fset_window_configuration, save_window_save): Handle persistent
8178 window parameters.
8179
c85efaf7
EZ
81802012-01-14 Eli Zaretskii <eliz@gnu.org>
8181
8182 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8183 thrashing the stack of the thread. (Bug#9087)
8184
5944709e
PE
81852012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8186
8187 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8188
e71f5d99
EZ
81892012-01-11 Eli Zaretskii <eliz@gnu.org>
8190
8191 * xdisp.c (rows_from_pos_range): Handle the case where the
8192 highlight ends on a newline. (Bug#10464)
8193 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8194 he end column for display of highlight that ends on a newline
8195 before a R2L line.
8196
ce316182
GM
81972012-01-11 Glenn Morris <rgm@gnu.org>
8198
8199 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8200 from load-path also when installation-directory is nil. (Bug#10208)
8201
5b43da69
GM
82022012-01-10 Glenn Morris <rgm@gnu.org>
8203
74cc8ff9
GM
8204 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8205
7d8d6e4e
GM
8206 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8207 Update template values to be closer to their typical values these days.
5b43da69 8208
a0db8d43
EZ
82092012-01-09 Eli Zaretskii <eliz@gnu.org>
8210
8211 * xdisp.c (rows_from_pos_range): Accept additional argument
8212 DISP_STRING, and accept any glyph in a row whose object is that
8213 string as eligible for mouse highlight. Fixes mouse highlight of
8214 display strings from overlays. (Bug#10464)
8215
9a0115ab 82162012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8217
b9110d6a 8218 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8219 * fileio.c (auto_saving_dir_umask): New static var.
8220 (Fmake_directory_internal): Use it.
8221 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8222 creating the directory. The old code temporarily assigns
8223 too-generous permissions to the directory.
8224 (do_auto_save_eh): Clear it.
b9110d6a 8225 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8226 that the var is always cleared.
8227
6c1bd3f3
EZ
82282012-01-07 Eli Zaretskii <eliz@gnu.org>
8229
8230 * search.c (scan_buffer): Pass character positions to
8231 know_region_cache, not byte positions. (Bug#6540)
8232
069d2b50
L
82332012-01-07 LynX <_LynX@bk.ru> (tiny change)
8234
8235 * w32.c (sys_rename): Report EXDEV when rename of a directory
8236 fails because the target is on another logical disk. (Bug#10284)
8237
75bf0d33
DB
82382012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8239
8240 * xterm.c (x_embed_request_focus): New function.
8241
8242 * xterm.h: Add prototype.
8243
8244 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8245
1c6e5a32
GM
82462012-01-05 Glenn Morris <rgm@gnu.org>
8247
8248 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8249
651e947e
EZ
82502012-01-01 Eli Zaretskii <eliz@gnu.org>
8251
8252 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8253 Load gnutls_transport_set_lowat only if GnuTLS version is below
8254 2.11.1.
8255 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8256 GnuTLS versions below 2.11.1.
8257
3778cdd8
AL
82582011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8259
8260 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8261 to the doc string advising against its use for altering the way
8262 windows are scrolled.
8263
0e5317f7
KH
82642011-12-28 Kenichi Handa <handa@m17n.org>
8265
8266 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8267 coding-system ASCII compatible only when it does not produce BOM
8268 on encoding (Bug#10383).
8269
93d5ca1f
JD
82702011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8271
8272 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8273 can scroll.
8274 (create_and_show_popup_menu): Always use menu_position_func for
8275 Gtk3 (Bug#10361).
8276
ca22b785
AS
82772011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8278
8279 * callint.c (Fcall_interactively): Don't truncate prompt string.
8280
d048e1e6
EZ
82812011-12-23 Eli Zaretskii <eliz@gnu.org>
8282
8283 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8284 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8285 resumed from there (after widening). (Bug#10360)
d048e1e6 8286
5ccaba1f
JD
82872011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8288
8289 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8290
204ee57f
JD
82912011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8292
b81d40f0
JB
8293 * nsterm.m (x_free_frame_resources):
8294 Release f->output_data.ns->miniimage.
204ee57f
JD
8295 (ns_index_color): Fix indentation. Do not retain
8296 color_table->colors[i].
8297
8298 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8299 before returning.
8300
8301 * nsfns.m (x_set_background_color): Assign return value from
8302 ns_index_color to face-background instead of NSColor*.
8303 (ns_implicitly_set_icon_type): Fix indentation.
8304 Change assignment in for loop to comparison.
8305
8306 * emacs.c (ns_pool): New variable.
8307 (main): Assign ns_pool.
8308 (Fkill_emacs): Call ns_release_autorelease_pool.
8309
8310 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8311 autorelease fdesc, release fdAttrs and tdict.
8312 (ns_get_covering_families): Release charset.
8313 (ns_findfonts): Release NSFontDescriptor created with new.
8314 (ns_uni_to_glyphs): Fix indentation.
8315 (setString): Release attrStr before assigning new value.
8316
c803b2b7
JD
83172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8318
678f4426
JD
8319 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8320 and NS_IMPL_COCOA.
8321 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8322 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8323
cd394be1 83242011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8325
5fecd5fc
JD
8326 * nsterm.m (ns_term_init): Subscribe for notifications
8327 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
8328 to method trackingNotification in EmacsMenu.
8329
8330 * nsmenu.m (trackingMenu): New variable.
3771cb17 8331 (trackingNotification): New method (from Aquamacs).
5fecd5fc 8332 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 8333 from Aquamacs (Bug#7030).
678f4426
JD
8334
83352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 8336
c803b2b7
JD
8337 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
8338 (symbol_to_nsstring): Fix indentation.
8339 (ns_symbol_to_pb): New function.
cae07000
SM
8340 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
8341 (Fns_rotate_cut_buffers_internal): Remove.
8342 (Fns_store_selection_internal): Rename from
c803b2b7
JD
8343 Fns_store_cut_buffer_internal.
8344 (ns_get_foreign_selection, Fx_own_selection_internal)
8345 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
8346 (Fns_get_selection_internal, Fns_store_selection_internal):
8347 Use ns_symbol_to_pb and check if return value is nil.
8348 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
8349 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
8350 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
8351 renamed to Sns_store_selection_internal.
8352 (ns_handle_selection_request): Move code to Fx_own_selection_internal
8353 and remove this function.
8354 (ns_handle_selection_clear): Remove, never used.
8355 (Fx_own_selection_internal): Move code from ns_handle_selection_request
8356 here.
8357
e1b01a3a
KB
83582011-12-17 Ken Brown <kbrown@cornell.edu>
8359
8360 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
8361 GID is unknown (Bug#10257).
8362
2adb6e85
PE
83632011-12-17 Paul Eggert <eggert@cs.ucla.edu>
8364
8365 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
8366 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
8367 which caused a build failure on GNU/Linux IA-64. This problem was
8368 introduced by my 2011-10-07 patch.
8369
d1d7b339
JL
83702011-12-15 Juri Linkov <juri@jurta.org>
8371
8372 * image.c (imagemagick_error): New function. (Bug#10112)
8373 (imagemagick_load_image): Comment out `MagickSetResolution' call.
8374 Use `imagemagick_error' where ImageMagick functions return
8375 `MagickFalse'.
8376 (Fimagemagick_types): Add `Fnreverse' to return the list in the
8377 proper order.
8378
100d5755
KH
83792011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8380
8381 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
8382 fill background (Bug#8992).
8383
454592a6
MR
83842011-12-13 Martin Rudalics <rudalics@gmx.at>
8385
8386 * window.c (Vwindow_combination_resize)
8387 (Vwindow_combination_limit): Use t instead of non-nil in
8388 doc-strings.
61d4b438
MR
8389 (Vrecenter_redisplay): Add first sentence of doc-string on
8390 separate line.
53524d93 8391 (Frecenter): Fix doc-string typo.
454592a6 8392
3633e3aa
KH
83932011-12-11 Kenichi Handa <handa@m17n.org>
8394
8395 * coding.c (Funencodable_char_position): Pay attention to the
8396 buffer text relocation (Bug#9389).
8397
7b9d523a 83982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 8399
7b9d523a
JD
8400 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
8401 gtk_init (Bug#10100).
8402
b73189c6
EZ
84032011-12-10 Eli Zaretskii <eliz@gnu.org>
8404
8405 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
8406 IT->string is nil. (Bug#10263)
8407
f7dfe5d6
JD
84082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
8409
83faebb4
JD
8410 * nsterm.h (x_free_frame_resources): Declare.
8411
f7dfe5d6
JD
8412 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
8413 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
8414
8415 * nsterm.h (ns_get_defaults_value): Declare.
8416
8417 * nsterm.m (ns_default): Call ns_get_defaults_value.
8418
7cd4e72c
EZ
84192011-12-09 Eli Zaretskii <eliz@gnu.org>
8420
8421 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
8422 (Bug#10170)
8423
b34d7317
YM
84242011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8425
8426 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
8427 that where the value of an _OBJC_* symbol points to is in the .bss
8428 section (Bug#10240).
8429
76470ad1
KH
84302011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8431
8432 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 8433 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 8434
745fff94
KH
84352011-12-08 Kenichi Handa <handa@m17n.org>
8436
8437 * ftfont.c (get_adstyle_property): Fix previous change
8438 (Bug#10233).
8439
6e44397c
JB
84402011-12-07 Juanma Barranquero <lekktu@gmail.com>
8441
8442 * w32.c (init_environment): If no_site_lisp, remove site-lisp
8443 dirs from the default value of EMACSLOADPATH (bug#10208).
8444
7efa6272
GM
84452011-12-07 Glenn Morris <rgm@gnu.org>
8446
8447 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
8448 installation and source directories as well. (Bug#10208)
8449
f6fc4d87
CY
84502011-12-06 Chong Yidong <cyd@gnu.org>
8451
8452 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
8453
2bf26180
GM
84542011-12-06 Glenn Morris <rgm@gnu.org>
8455
8456 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
8457 as an error, not just -1. (Bug#10217)
8458
3a6ad4f0
CY
84592011-12-05 Chong Yidong <cyd@gnu.org>
8460
8461 * keyboard.c (process_special_events): New function.
8462 (swallow_events, Finput_pending_p): Use it (Bug#10195).
8463
75a3b399
PE
84642011-12-05 Paul Eggert <eggert@cs.ucla.edu>
8465
8466 * coding.c (encode_designation_at_bol): Don't use uninitialized
8467 local variable (Bug#9318).
8468
c3c9e25e
KH
84692011-12-05 Kenichi Handa <handa@m17n.org>
8470
8471 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
8472 return Qnil (Bug#8046, Bug#10193).
8473
5eb05ea3
KH
84742011-12-05 Kenichi Handa <handa@m17n.org>
8475
8476 * coding.c (encode_designation_at_bol): New args charbuf_end and
8477 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
8478 (coding_set_source): Return how many bytes coding->source was
8479 relocated.
8480 (coding_set_destination): Return how many bytes
8481 coding->destination was relocated.
8482 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 8483 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
8484
84852011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8486
8487 * coding.c (CODING_CHAR_CHARSET_P): New macro.
8488 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
8489 macro (Bug#9318).
8490
84912011-12-05 Andreas Schwab <schwab@linux-m68k.org>
8492
8493 The following changes are to fix Bug#9318.
8494
a79703f5 8495 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
8496 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
8497 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 8498 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 8499
7dbda6df
JB
85002011-12-05 Juanma Barranquero <lekktu@gmail.com>
8501
8502 * lisp.h (process_quit_flag): Fix external declaration.
8503
6d5eb5b0
SM
85042011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
8505
8506 Don't macro-inline non-performance-critical code.
8507 * eval.c (process_quit_flag): New function.
8508 * lisp.h (QUIT): Use it.
8509
a0c3fad0
JD
85102011-12-04 Jan Djärv <jan.h.d@swipnet.se>
8511
8512 * nsfns.m (get_geometry_from_preferences): New function.
8513 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
8514
6c07aac2
AS
85152011-12-04 Andreas Schwab <schwab@linux-m68k.org>
8516
8517 * emacs.c (Qkill_emacs): Define.
8518 (syms_of_emacs): Initialize it.
8519 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
8520 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
8521 (quit_throw_to_read_char): Add parameter `from_signal'.
8522 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
8523 * lisp.h (QUIT): Call Fkill_emacs if requested.
8524
c052ead4
JD
85252011-12-03 Jan Djärv <jan.h.d@swipnet.se>
8526
8527 * widget.c (update_wm_hints): Return if wmshell is null.
8528 (widget_update_wm_size_hints): New function.
8529
8530 * widget.h (widget_update_wm_size_hints): Declare.
8531
8532 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
8533 widget_update_wm_size_hints (Bug#10104).
8534
9e49252b
EZ
85352011-12-03 Eli Zaretskii <eliz@gnu.org>
8536
8537 * xdisp.c (handle_invisible_prop): If the invisible text ends just
8538 before a newline, prepare the bidi iterator for consuming the
8539 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 8540 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 8541
02b16839
JL
85422011-12-02 Juri Linkov <juri@jurta.org>
8543
8544 * search.c (Fword_search_regexp): New Lisp function created from
8545 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
8546 (Fword_search_backward, Fword_search_forward)
8547 (Fword_search_backward_lax, Fword_search_forward_lax):
8548 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
8549 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
8550
0068070e
SM
85512011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
8552
8553 * fileio.c (Finsert_file_contents): Move after-change-function call
8554 to before the "handled:" label, since all "goto handled" appear in
8555 cases where the *-change-functions have already been properly called
8556 (bug#10117).
8557
3360a3fc
AS
85582011-12-01 Andreas Schwab <schwab@linux-m68k.org>
8559
8560 * keyboard.c (interrupt_signal): Don't call kill-emacs when
8561 waiting for input. (Bug#10169)
8562
73d6c093
EZ
85632011-11-30 Eli Zaretskii <eliz@gnu.org>
8564
8565 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
8566 verifies glyph row's hash code--we have just reallocated the
8567 glyphs, so their contents can be complete garbage. (Bug#10164)
8568
febe6bea
JB
85692011-11-30 Juanma Barranquero <lekktu@gmail.com>
8570
8571 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
8572
801a4313
EZ
85732011-11-30 Eli Zaretskii <eliz@gnu.org>
8574
8575 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
8576 attributes are tested _before_ calling verify_row_hash, to protect
8577 against GCC re-ordering of the tests. (Bug#10164)
8578
2b56b87e
JD
85792011-11-29 Jan Djärv <jan.h.d@swipnet.se>
8580
8581 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
8582
8583 * xterm.c (handle_one_xevent): Only set async_visible and friends
8584 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 8585 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
8586 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
8587
dbf31225
PE
85882011-11-28 Paul Eggert <eggert@cs.ucla.edu>
8589
8590 Remove GCPRO-related macros that exist only to avoid shadowing locals.
8591 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
8592 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
8593 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8594 All uses changed to use GCPRO1 etc.
8595 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
8596 Revert to old implementation (i.e., before 2011-03-11).
8597
1305621b
YM
85982011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8599
8600 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
8601 of scroll runs so as to avoid assigning disabled bogus rows and
8602 unnecessary graphics copy operations.
8603
8c9afb46
EZ
86042011-11-27 Eli Zaretskii <eliz@gnu.org>
8605
8606 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
8607 (snprintf) [_MSC_VER]: Redirect to _snprintf.
8608 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
8609 (malloc, free, realloc, calloc): Redirect to e_* only when
8610 compiling Emacs.
8611
8612 * lisp.h (GCTYPEBITS): Move before first use.
8613 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
8614 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
8615 this macro definition.
8616
8617 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
8618 _MSC_VER.
8619
54e9e3bf
JD
86202011-11-27 Jan Djärv <jan.h.d@swipnet.se>
8621
6d5eb5b0
SM
8622 * gtkutil.c (xg_create_frame_widgets):
8623 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
8624 present with Gtk+ 2.0.
8625
83aca1cb
PE
86262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8627
8628 * fileio.c (Finsert_file_contents): Undo previous change; see
8629 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8630
5b76caa4
PE
86312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8632
8633 Rename locals to avoid shadowing.
8634 * fileio.c (Finsert_file_contents):
8635 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
8636 * process.c (wait_reading_process_output):
8637 Rename inner 'proc' to 'p' to avoid shadowing.
8638 Indent for consistency with usual Emacs style.
8639
8c535114
EZ
86402011-11-25 Eli Zaretskii <eliz@gnu.org>
8641
8642 * xdisp.c (redisplay_window): If cursor row is not fully visible
8643 after recentering, and scroll-conservatively is set to a large
8644 number, scroll window by a few more lines to make the cursor fully
8645 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
8646 (start_display): Don't move to the next line if the display should
8647 start at a newline that is part of a display vector or an overlay
8648 string. (Bug#10119)
8c535114 8649
fa4fdb5c
JL
86502011-11-24 Juri Linkov <juri@jurta.org>
8651
8652 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
8653 after the `MagickPingImage' call. (Bug#10112)
8654
90ec88df
CY
86552011-11-23 Chong Yidong <cyd@gnu.org>
8656
8657 * window.c (Fcoordinates_in_window_p): Accept only live windows.
8658
56e2e794
MR
86592011-11-23 Martin Rudalics <rudalics@gmx.at>
8660
8661 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
8662 making another buffer current. (Bug#10114)
8663
b6e64c41
GM
86642011-11-23 Glenn Morris <rgm@gnu.org>
8665
8666 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
8667
6b21de18
CY
86682011-11-23 Chong Yidong <cyd@gnu.org>
8669
8670 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
8671 using it (Bug#5984).
8672
b12cd789
EZ
86732011-11-22 Eli Zaretskii <eliz@gnu.org>
8674
8675 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
8676 and header-lines, as they don't have one computed for them.
8677 (Bug#10098)
8678
8679 * .gdbinit (prow): Make displayed values more self-explaining.
8680 Add row's hash code.
8681
261b6fd4
LMI
86822011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
8683
8684 * process.c (wait_reading_process_output): Fix asynchrounous
8685 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 8686 (wait_reading_process_output): Add comment and URL.
261b6fd4 8687
e7cfd277
JD
86882011-11-21 Jan Djärv <jan.h.d@swipnet.se>
8689
8690 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
8691
a9b9b7f5
CY
86922011-11-21 Chong Yidong <cyd@gnu.org>
8693
8694 * window.c (Fnext_window, Fprevious_window): Doc fix.
8695
b0d15b4f
SM
86962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8697
8698 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
8699
fe7a3057
JB
87002011-11-20 Juanma Barranquero <lekktu@gmail.com>
8701
8702 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
8703
d2999b1a
MR
87042011-11-20 Martin Rudalics <rudalics@gmx.at>
8705
8706 * window.c (Fset_window_combination_limit): Rename argument
8707 STATUS to LIMIT.
8708 (Vwindow_combination_limit): Remove "status" from doc-string.
8709
d5ff9cd0
AS
87102011-11-20 Andreas Schwab <schwab@linux-m68k.org>
8711
8712 * m/ibms390.h: Remove.
8713 * m/ibms390x.h: Don't include "ibms390.h".
8714
a5bb9bd3
SM
87152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8716
8717 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
8718 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
8719
cd1181db
JB
87202011-11-20 Juanma Barranquero <lekktu@gmail.com>
8721
8722 * casetab.c (Fset_case_table):
8723 * charset.c (Fcharset_after): Fix typos.
8724
615a3b8d 87252011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 8726
17e845af
PE
8727 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
8728 Otherwise, valgrind does not work on some platforms.
8729 Problem reported by Andreas Schwab in
6a0bf43d
PE
8730 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
8731 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8732 is set, removing the need for VIRT_ADDRESS_VARIES.
8733 (PURE_P): Use a more-efficient implementation that needs just one
8734 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
8735 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
8736 to 4 (xorl, subq, cmpq, setbe).
8737 * alloc.c (pure): Always extern now, since that's the
8738 VIRT_ADDR_VARIES behavior.
8739 (PURE_POINTER_P): Use a single comparison, not two, for
8740 consistency with the new puresize.h.
8741 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
8742 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
8743 Remove VIRT_ADDR_VARIES no longer needed.
8744
f8fe6f96
EZ
87452011-11-19 Eli Zaretskii <eliz@gnu.org>
8746
8747 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
8748 (erase_phys_cursor, update_window_cursor, show_mouse_face)
8749 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
8750 behave as if the cursor position were at the window margin.
8751
8752 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
8753 and the cursor position is out of bounds, behave as if the cursor
8754 position were at the window margin. (Bug#10075)
8755
df05a53c
CY
87562011-11-18 Chong Yidong <cyd@gnu.org>
8757
8758 * window.c (Fwindow_combination_limit): Make first argument
8759 non-optional, since it is meaningless for live windows like the
8760 selected window.
61ccba97 8761
2071918e
DA
87622011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
8763
8764 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
8765
b50a28de
SM
87662011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
8767
8768 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8769 (graft_intervals_into_buffer): Simplify.
8770
015137db
EZ
87712011-11-18 Eli Zaretskii <eliz@gnu.org>
8772
8773 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
8774 hash values of the two rows.
8775 (copy_row_except_pointers): Preserve the used[] arrays and the
8776 hash values of the two rows. (Bug#10035)
68c95424 8777 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
8778
8779 * xdisp.c (row_hash): New function, body extracted from
8780 compute_line_metrics.
8781 (compute_line_metrics): Call row_hash, instead of computing the
8782 hash code inline.
8783
8784 * dispnew.c (verify_row_hash): Call row_hash for computing the
8785 hash code of a row, instead of duplicating code from xdisp.c.
8786
8787 * dispextern.h (row_hash): Add prototype.
8788
a2addb04
TH
87892011-11-18 Tassilo Horn <tassilo@member.fsf.org>
8790
8791 * frame.c (delete_frame): Don't delete the terminal when the last
8792 X frame is closed if emacs is built with GTK toolkit.
8793
df85d315
JB
87942011-11-17 Juanma Barranquero <lekktu@gmail.com>
8795
8796 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
8797
a0c2d0ae
MR
87982011-11-17 Martin Rudalics <rudalics@gmx.at>
8799
8800 * window.c (Vwindow_splits): Rename to
8801 Vwindow_combination_resize. Suggested by Juri Linkov.
8802 (Fsplit_window_internal): Use Vwindow_combination_resize instead
8803 of Vwindow_splits.
8804
58179cce
JB
88052011-11-16 Juanma Barranquero <lekktu@gmail.com>
8806
7877f373
JB
8807 * nsfns.m (Fns_font_name):
8808 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 8809
b6f67890
MR
88102011-11-16 Martin Rudalics <rudalics@gmx.at>
8811
8812 * window.h (window): Rename slot "nest" to "combination_limit".
8813 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
8814 (Fset_window_nest): Rename to Fset_window_combination_limit.
8815 (Vwindow_nest): Rename to Vwindow_combination_limit.
8816 (recombine_windows, make_parent_window, make_window)
8817 (Fsplit_window_internal, saved_window)
8818 (Fset_window_configuration, save_window_save): Rename all
8819 occurrences of window_nest to window_combination_limit.
8820
c7015153
JB
88212011-11-15 Juanma Barranquero <lekktu@gmail.com>
8822
8823 * image.c (imagemagick_load_image): Fix typo.
8824
322ad6ec
EZ
88252011-11-14 Eli Zaretskii <eliz@gnu.org>
8826
8827 * xdisp.c (display_line): Move the call to
8828 highlight_trailing_whitespace before the call to
8829 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
8830 faces of all the glyphs to compute ROW's hash value.
8831 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 8832
f067b8ec
JB
88332011-11-14 Juanma Barranquero <lekktu@gmail.com>
8834
8835 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
8836 just return (bug#10044).
8837
1e5b2111
EZ
88382011-11-12 Eli Zaretskii <eliz@gnu.org>
8839
7ef3cbd5
EZ
8840 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
8841 with user-defined heap size. Bump the default size of the temacs
8842 heap to 27MB, to avoid memory warning when running temacs.
8843 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
8844
1e5b2111
EZ
8845 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
8846 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
8847 (verify_row_hash) [XASSERTS]: New function.
8848 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
8849 that the hash value of glyph rows is correct.
1e5b2111 8850
89d61221
MR
88512011-11-12 Martin Rudalics <rudalics@gmx.at>
8852
8853 * window.h (window): Remove splits slot.
8854 * window.c (Fwindow_splits, Fset_window_splits): Remove.
8855 (Fdelete_other_windows_internal, make_parent_window)
8856 (make_window, Fsplit_window_internal, Fdelete_window_internal)
8857 (Fset_window_configuration, save_window_save): Don't deal with
8858 split status of windows.
8859 (saved_window): Remove splits slot.
8860 (Vwindow_splits): Rewrite doc-string.
8861
97f18cc8
JD
88622011-11-11 Jan Djärv <jan.h.d@swipnet.se>
8863
8864 * xfns.c (unwind_create_frame):
8865 * nsfns.m (unwind_create_frame):
8866 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
8867 Vframe_list (Bug#9999).
8868
22a648b4
DA
88692011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
8870
0b381c7e 8871 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 8872
659afede
KH
88732011-11-11 Kenichi Handa <handa@m17n.org>
8874
8875 * callproc.c (Fcall_process): Set the member dst_multibyte of
8876 process_coding.
8877
9ac0394b
KH
88782011-11-11 Johan Bockgård <bojohan@gnu.org>
8879
8880 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
8881 avoid a crash (bug#9496).
8882
2fbdc249
CY
88832011-11-09 Chong Yidong <cyd@gnu.org>
8884
8885 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
8886 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
8887
ac6b1f81
PE
88882011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8889
8890 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
8891
09db192c
PE
88922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8893
8894 Avoid some portability problems by eschewing 'extern inline' functions.
8895 The trivial performance wins aren't worth the portability hassles; see
8896 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
8897 et seq.
8898 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8899 (window_box_width, window_box_left, window_box_left_offset)
8900 (window_box_right, window_box_right_offset): Undo previous change,
8901 by removing the "extern"s.
8902 * intervals.c (adjust_intervals_for_insertion)
8903 (adjust_intervals_for_deletion): Undo previous change,
8904 making these static again.
8905 (offset_intervals, temp_set_point_both, temp_set_point)
8906 (copy_intervals_to_string): No longer inline.
8907 * xdisp.c (window_text_bottom_y, window_box_width)
8908 (window_box_height, window_box_left_offset)
8909 (window_box_right_offset, window_box_left, window_box_right)
8910 (window_box): No longer inline.
8911
105216ed
CY
89122011-11-08 Chong Yidong <cyd@gnu.org>
8913
8914 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
8915 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
8916 Signal an error if not a live window.
105216ed
CY
8917 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
8918 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
8919
ae9e237f
JB
89202011-11-07 Juanma Barranquero <lekktu@gmail.com>
8921
8922 * lisp.h (syms_of_abbrev): Remove declaration.
8923 Reported by CHENG Gao <chenggao@royau.me>.
8924
c7aa8333
EZ
89252011-11-07 Eli Zaretskii <eliz@gnu.org>
8926
8927 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
8928 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
8929 of temacs in GUI mode.
8930
be7f5545
MR
89312011-11-07 Martin Rudalics <rudalics@gmx.at>
8932
8933 * window.h: Declare delete_all_child_windows instead of
8934 delete_all_subwindows.
8935 * window.c (Fwindow_nest, Fset_window_nest)
8936 (Fset_window_new_total, Fset_window_new_normal)
8937 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8938 (delete_all_subwindows): Rename to delete_all_child_windows.
8939 (Fdelete_other_windows_internal, Fset_window_configuration):
8940 Call delete_all_child_windows instead of delete_all_subwindows.
8941 * frame.c (delete_frame): Call delete_all_child_windows instead
8942 of delete_all_subwindows.
8943
ca78dc43
PE
89442011-11-07 Paul Eggert <eggert@cs.ucla.edu>
8945
8946 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8947 This is also needed for porting to any host where GC_MARK_STACK is
8948 not GC_MAKE_GCPROS_NOOPS.
8949 (which_symbols): Use it.
8950
a0241d01
KH
89512011-11-07 Kenichi Handa <handa@m17n.org>
8952
8953 * coding.c (coding_set_destination): Check coding->src_pos only
8954 when coding->src_object is a buffer (bug#9910).
8955
8956 * process.c (send_process): Set the member src_multibyte of coding
8957 to 0 (bug#9911) when sending a unibyte text.
8958
8959 * callproc.c (Fcall_process): Set the member src_multibyte of
8960 process_coding to 0 (bug#9912).
8961
a64bfdfa 89622011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8963
8964 * xmenu.c (cleanup_widget_value_tree): New function.
8965 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8966 calling free_menubar_widget_value_tree directly (Bug#9830).
8967
cb41b32a
PE
89682011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8969
8970 Fix some portability problems with 'inline'.
8971 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8972 (window_box_width, window_box_left, window_box_left_offset)
8973 (window_box_right, window_box_right_offset): Declare extern.
8974 Otherwise, these inline functions do not conform to C99 and
8975 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8976 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8977 * intervals.c (adjust_intervals_for_insertion)
8978 (adjust_intervals_for_deletion): Now extern, because otherwise the
8979 extern inline functions 'offset_intervals' couldn't refer to it.
8980 (static_offset_intervals): Remove.
8981 (offset_intervals): Rewrite using the old contents of
8982 static_offset_intervals. The old version didn't conform to C99
8983 because an extern inline function contained a reference to an
8984 identifier with static linkage.
8985
b7041366
AS
89862011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8987
8988 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8989 GC.
8990
88a37c4d
EZ
89912011-11-06 Eli Zaretskii <eliz@gnu.org>
8992
8993 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8994 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8995 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8996 return Qleft_to_right.
8997
49745b39
CY
89982011-11-06 Chong Yidong <cyd@gnu.org>
8999
9000 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
9001 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
9002 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
9003 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
9004 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
9005 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
9006 (Fwindow_vscroll): Doc fix.
9007 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
9008 argument, since it makes no sense to pass a live window and for
9009 consistency with window-child.
9010
1f05cd82
CS
90112011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
9012
9013 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
9014 support MSVC.
9015
22610910
JR
90162011-11-05 Jason Rumney <jasonr@gnu.org>
9017
9018 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
9019 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
9020 fonts (Bug#6029).
9021 (add_font_entity_to_list): Fix logic errors in mixed boolean and
9022 bitwise arithmetic preventing use of unicode-sip and non-truetype
9023 opentype fonts.
9024
a06776b2
EZ
90252011-11-05 Eli Zaretskii <eliz@gnu.org>
9026
3ad924ba
EZ
9027 * s/ms-w32.h (fstat, stat, utime): Move redirections to
9028 "emacs"-only part.
9029
a06776b2
EZ
9030 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
9031 initialization code to keep similarity to xfns.c after changes
9032 from 2011-11-05.
9033
c9e7db78
JD
90342011-11-05 Jan Djärv <jan.h.d@swipnet.se>
9035
a97f8f3f
JD
9036 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
9037 (unwind_create_frame): New function (Bug#9943).
9038 (Fx_create_frame): Restructure code to be more similar to the one in
9039 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
9040 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
9041 Move terminal->reference_count++ just before making the frame official
9042 (Bug#9943).
9043
9044 * nsterm.m (x_free_frame_resources): New function.
9045 (x_destroy_window): Move code to x_free_frame_resources.
9046
c9e7db78 9047 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
9048 (Fx_create_frame, x_create_tip_frame):
9049 Move terminal->reference_count++ just before making the frame
75f1671a 9050 official. Move initialization of image_cache_refcount and
c9e7db78
JD
9051 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
9052
a6fc3b5c
EZ
90532011-11-05 Eli Zaretskii <eliz@gnu.org>
9054
9055 Support MSVC build with newer versions of Visual Studio.
9056 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
9057 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
9058 nt/gmake.defs.
9059
9060 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
9061 which are not supported by MSVC.
9062 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
9063 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
9064 bitfields.
9065 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
9066 types in bitfields.
9067 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
9068
9069 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
9070
58179cce 90712011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
9072
9073 Support MSVC build with newer versions of Visual Studio.
9074 * w32.c: Don't include w32api.h for MSVC.
9075 (init_environment) [_MSC_VER]: Call sys_access, not _access.
9076
9077 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
9078 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
9079 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
9080 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
9081 e_* cousins.
9082 (alloca) [_MSC_VER]: Define to _alloca.
9083
9084 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9085
9086 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9087
a58c13ed
EZ
90882011-11-04 Eli Zaretskii <eliz@gnu.org>
9089
9090 * xdisp.c (note_mouse_highlight): If either of
9091 previous/next-single-property-change returns nil, treat that as
9092 the beginning or the end of the buffer. (Bug#9955)
9093
fe0b6370
JD
90942011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9095
a58c13ed 9096 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9097 label is not null (Bug#9951).
9098 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9099 may be NULL.
9100
89bd5ee1
EZ
91012011-11-04 Eli Zaretskii <eliz@gnu.org>
9102
9103 * window.c (Fwindow_body_size): Mention in the doc string that the
9104 return value is in frame's canonical units. (Bug#9949)
9105
84c3edb9
EZ
91062011-11-03 Eli Zaretskii <eliz@gnu.org>
9107
4e2fb5c7
EZ
9108 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9109
84c3edb9 9110 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9111 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9112 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9113
bc17a887
EZ
91142011-11-01 Eli Zaretskii <eliz@gnu.org>
9115
9116 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9117 Don't stop backward scan on the continuation glyph, even though
9118 its CHARPOS is positive.
6d5eb5b0
SM
9119 (mouse_face_from_buffer_pos, note_mouse_highlight):
9120 Rename cover_string to disp_string.
bc17a887 9121
4ee88440
MR
91222011-11-01 Martin Rudalics <rudalics@gmx.at>
9123
9124 * window.c (temp_output_buffer_show): Don't use
9125 Vtemp_buffer_show_specifiers.
9126 (Vtemp_buffer_show_specifiers): Remove unused variable.
9127
c2ff3c02
EZ
91282011-10-30 Eli Zaretskii <eliz@gnu.org>
9129
9130 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9131 past the beginning of the current glyph matrix.
9132
58179cce 91332011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9134
9135 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9136 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9137 HAVE_GTK3 (Bug#9869).
b77a6a7f 9138
3b574623
JD
9139 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9140 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9141
b77a6a7f
JD
9142 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9143
9144 * xterm.c: Declare x_handle_net_wm_state to return int.
9145 (handle_one_xevent): Check if we are iconified but don't have
9146 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9147 (get_current_wm_state): Return non-zero if not hidden,
9148 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9149 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9150 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9151 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9152
196e41e4
PE
91532011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9154
9155 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9156 so that this new function doesn't get optimized away by a
9157 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9158
021f2e1a
AS
91592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9160
9161 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9162
8b058d44
EZ
91632011-10-29 Eli Zaretskii <eliz@gnu.org>
9164
9165 Fix the `xbytecode' command.
9166 * .gdbinit (xprintbytestr): New command.
b50a28de 9167 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9168 (xbytecode): Print the byte-code string as well.
9169
4452fb80
EZ
91702011-10-29 Kim Storm <storm@cua.dk>
9171
8b058d44
EZ
9172 * alloc.c (which_symbols): New function.
9173
21b72067
AS
91742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9175
9176 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9177 line. (Bug#9903)
9178
83ed7b5c
GM
91792011-10-29 Glenn Morris <rgm@gnu.org>
9180
9181 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9182 Not clear what it was for, and it causes various bugs. (Bug#9839)
9183
5a7a728b
EZ
91842011-10-28 Eli Zaretskii <eliz@gnu.org>
9185
9186 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9187 possible random value that matches one of those tested as
9188 condition to clear the mouse face.
9189
d3d0842f
CY
91902011-10-28 Chong Yidong <cyd@gnu.org>
9191
9192 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9193
31b39d13
DN
91942011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9195
9196 * window.c (make_window): Initialize phys_cursor_on_p.
9197
9aba6043
SM
91982011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9199
9200 * lisp.h (struct Lisp_Symbol): Update comments.
9201
c20992f4
JB
92022011-10-28 Juanma Barranquero <lekktu@gmail.com>
9203
9204 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9205
db4f02f2
EZ
92062011-10-28 Eli Zaretskii <eliz@gnu.org>
9207
9208 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9209 <oslsachem@gmail.com> for helping to debug this.
9210
9211 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9212 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9213 (g_b_init_get_glyph_outline_w): New static variables.
9214 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9215 (GetGlyphOutlineW_Proc): New typedefs.
9216 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9217 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9218 New functions.
9219 (w32font_open_internal, compute_metrics):
9220 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9221 instead of calling the "wide" APIs directly.
9222
9223 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9224
9225 * w32.h (syms_of_w32font): Add prototype.
9226
87e68db4
JB
92272011-10-27 Juanma Barranquero <lekktu@gmail.com>
9228
9229 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9230 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9231 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9232 (Fmove_to_window_line): Doc fix.
9233
435c1d67
CY
92342011-10-27 Chong Yidong <cyd@gnu.org>
9235
9236 * process.c (make_process): Set gnutls_state to NULL.
9237
9238 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9239 non-NULL, regardless of GNUTLS_INITSTAGE.
9240 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9241 an error. Set process slots as soon as we allocate them.
9242
9243 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9244
9c6c6f49
CY
92452011-10-27 Chong Yidong <cyd@gnu.org>
9246
9aba6043
SM
9247 * gnutls.c (emacs_gnutls_deinit): New function.
9248 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9249 (Fgnutls_deinit, Fgnutls_boot): Use it.
9250
9251 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9252 (deactivate_process): Call emacs_gnutls_deinit.
9253
657d08d3
JB
92542011-10-27 Juanma Barranquero <lekktu@gmail.com>
9255
9256 * image.c (x_create_x_image_and_pixmap):
9257 * w32.c (sys_rename, w32_delayed_load):
9258 * w32font.c (fill_in_logfont):
9259 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9260
5430d399
JB
92612011-10-26 Juanma Barranquero <lekktu@gmail.com>
9262
9263 * w32fns.c (w32_default_color_map): New function,
9264 extracted from Fw32_default_color_map.
a7ef684b 9265 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9266
fe0055fa
PE
92672011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9268
9269 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9270
e6346438
SM
92712011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9272
9273 * keyboard.c (test_undefined): New function (bug#9751).
9274 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9275
e112cc37
ET
92762011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9277
9278 * sysdep.c (init_sys_modes): Fix the check for the controlling
9279 terminal (Bug#6649).
9280
7b5d6677
EZ
92812011-10-20 Eli Zaretskii <eliz@gnu.org>
9282
9283 * dispextern.h (struct bidi_it): New member next_en_type.
9284
9285 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9286 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9287 current character, check also for next_en_type being WEAK_EN.
9288 (bidi_resolve_weak): Don't enter the expensive loop if the current
9289 position is before next_en_pos. Record the bidi type of the first
9290 non-ET, non-BN character we find, in addition to its position.
9291 (bidi_level_of_next_char): Invalidate next_en_type when
9292 next_en_pos is over-stepped.
9293
7da0b018
PE
92942011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9295
9296 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9297 * editfns.c: Rewrite current-time-zone so that it invokes
9298 the equivalent of (format-time-string "%Z") to get the time zone name.
9299 This fixes a bug when the time zone name contains characters that
9300 need converting from the system time locale to Emacs internal format.
9301 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9302 that patch fixed format-time-string to do the conversion, but
9303 I forgot to fix current-time-zone.
9304 (format_time_string): New function, containing most of
9305 what Fformat_time_string used to contain.
9306 (Fformat_time_string): Rewrite in terms of format_time_string.
9307 This doesn't change this function's behavior.
9308 (current-time-zone): Rewrite to use format_time_string.
9309 This fixes the bug reported by Michael Schierl in
9310 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9311 Jason Rumney's 2007-06-07 change worked around this bug, but
9312 didn't fix it.
9313 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9314
8547b010
EZ
93152011-10-19 Eli Zaretskii <eliz@gnu.org>
9316
9317 * xdisp.c (start_display): If the character at POS is displayed
9318 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9319 (try_window_reusing_current_matrix): If a line ends in a display
9320 vector or the next line starts in a display vector, continue
9321 redrawing the window even though the character position of
9322 start_row was reached.
8547b010
EZ
9323 (Bug#9771, part 2)
9324
4e948d15
CY
93252011-10-18 Chong Yidong <cyd@gnu.org>
9326
9327 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
9328 with nobreak-char-display too.
9329
4787455f
EZ
93302011-10-18 Eli Zaretskii <eliz@gnu.org>
9331
9332 Fix part 3 of bug#9771.
9333 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
9334 (bidi_resolve_neutral): Don't enter the expensive loop looking for
9335 non-neutral characters if the current character is a paragraph
9336 separator (a.k.a. Newline). This avoids running the same
9337 expensive loop twice, once when we consume the preceding newline
9338 and the other time when the line actually needs to be displayed.
9339 Avoid the loop when we see neutrals on the base embedding level
9340 following a character whose directionality is the same as the
9341 paragraph's. This avoids running the expensive loop when a line
9342 ends in a long sequence of neutrals, like control characters.
9343 Add assertion against STRONG_AL type. Slightly rearrange code
9344 that determines the type of a neutral given the first non-neutral
9345 that follows it.
9346 (bidi_level_of_next_char): Set next_en_pos to zero when
9347 invalidating its info.
9348
2c91f553
EZ
93492011-10-17 Eli Zaretskii <eliz@gnu.org>
9350
9351 * xdisp.c (push_display_prop): Determine whether to record string
9352 or buffer position by IT->string, not by IT->method. Allow
9353 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
9354 (move_it_vertically_backward): Don't look for character position
9355 immediately after the newline when in a continuation line.
9356 (Bug#9771, part 1)
2c91f553 9357
c7b08b0d
MR
93582011-10-15 Martin Rudalics <rudalics@gmx.at>
9359
9360 * window.c (coordinates_in_window): Rewrite and delabelize
9361 vertical border check. (Bug#5357) (Bug#9618)
9362
6b02f655
SM
93632011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
9364
9365 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9366 errors in XSetWindowBorder (bug#9310).
9367
81d40c92
DA
93682011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
9369
9370 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9371 avoid crash when xmalloc overrun checking is enabled.
9372
d4172c3b
EZ
93732011-10-13 Eli Zaretskii <eliz@gnu.org>
9374
9375 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9376 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
9377 cursor motion with <left> and <right> arrow keys.
9378
9379 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
9380 some callers set that themselves.
9381
b00eea75
EZ
93822011-10-12 Eli Zaretskii <eliz@gnu.org>
9383
9384 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
9385 display string and the previous row comes from the same string and
9386 is empty. (Bug#9739) (Bug#9738)
9387
8fe012c4
SM
93882011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
9389
9390 * doc.c (get_doc_string): Encode file name (bug#9735).
9391
0074aef2
EZ
93922011-10-12 Eli Zaretskii <eliz@gnu.org>
9393
79beb178
EZ
9394 * bidi.c (bidi_level_of_next_char):
9395 * xdisp.c (get_visually_first_element): Remove old incorrect
9396 comments regarding the Unicode Line Separator character.
9397
0074aef2
EZ
9398 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
9399
6e4b3fbe
DA
94002011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
9401
9402 * alloc.c (Fgc_status): Do not access beyond zombies array
9403 boundary if nzombies > MAX_ZOMBIES.
9404 * alloc.c (dump_zombies): Add missing format specifier.
9405
0324f3af
PE
94062011-10-12 Paul Eggert <eggert@cs.ucla.edu>
9407
b5525cac
PE
9408 * xdisp.c (set_cursor_from_row): Simplify conditionals,
9409 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
9410
0324f3af
PE
9411 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
9412 Some packages use them to denote characters with modifiers.
9413
e9b5f888
AS
94142011-10-11 Andreas Schwab <schwab@linux-m68k.org>
9415
9416 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
9417 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
9418 matching a pp-number. Rename parameter var to var1.
9419
127827c0
SM
94202011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
9421
9422 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
9423
c8fd3bd0
GM
94242011-10-08 Glenn Morris <rgm@gnu.org>
9425
9426 * callint.c (Fcall_interactively): Give a more explicit error for the
9427 'c' case with a non-character input. (Bug#8479)
9428
352ec8ff
EZ
94292011-10-08 Eli Zaretskii <eliz@gnu.org>
9430
03669ccb
EZ
9431 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
9432 lines.
7061c986
EZ
9433 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
9434 lines that are hscrolled on the left.
03669ccb 9435
352ec8ff
EZ
9436 * dispnew.c (buffer_posn_from_coords): Account for a possible
9437 presence of header-line. (Bug#4426)
9438
a66cfb1c
SM
94392011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
9440
6b02f655
SM
9441 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
9442 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 9443
7c5ee88e
PE
94442011-10-07 Paul Eggert <eggert@cs.ucla.edu>
9445
9446 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
9447 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
9448 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
9449 this makes Emacs dump core during garbage collection on rare
9450 occasions. sizeof is obviously inferior to offsetof here, so
9451 stick with offsetof.
9452 (GC_POINTER_ALIGNMENT): New macro.
9453 (mark_memory): Omit 3rd (offset) arg; caller changed.
9454 Don't assume EMACS_INT alignment is the same as pointer alignment.
9455
df1bbe5b
SM
94562011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
9457
9458 * keyboard.c (read_key_sequence_remapped): New var.
9459 (read_key_sequence): Compute remapping in the right buffer.
9460 (command_loop_1): Use read_key_sequence's remapping directly.
9461
51553db6
SM
94622011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
9463
32c1fffd
SM
9464 * dired.c (file_name_completion): Don't expand file name.
9465 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
9466 before checking file name handler.
9467
51553db6
SM
9468 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
9469 they've been requested explicitly (bug#9591).
9470
b6bd1599 94712011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
9472
9473 * keymap.c (Fsingle_key_description): Use make_specified_string
9474 instead of build_string to build string from push_key_description.
9475 (Bug#5193)
9476
f701dc2a
PE
94772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9478
4222c55d
PE
9479 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
9480 This fixes a Y2038 bug on 64-bit hosts.
9481 * buffer.c (reset_buffer):
9482 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
9483 (Fclear_buffer_auto_save_failure):
9484 Use 0, not -1, to represent an unset failure time, since time_t
9485 might not be signed.
9486
f701dc2a
PE
9487 Remove dependency on glibc malloc internals.
9488 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9489 Move back here from lisp.h, but with their new implementations.
9490 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9491 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
9492 * charset.c (charset_table_init): New static var.
9493 (syms_of_charset): Use it instead of xmalloc. This removes a
9494 dependency on glibc malloc internals. See Eli Zaretskii's comment in
9495 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
9496 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9497 Move back to alloc.c.
9498 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9499 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
9500
9ceebf39
JD
95012011-09-30 Jan Djärv <jan.h.d@swipnet.se>
9502
9503 * nsterm.m (windowDidResize): Call x_set_window_size only when
9504 ns_in_resize is true. Otherwise set pixelwidth/height and
9505 call change_frame_size (Bug#9628).
9506
cb993c58
PE
95072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9508
3930c88b
PE
9509 Port --enable-checking=all to Fedora 14 x86-64.
9510 * charset.c (syms_of_charset): Also account for glibc malloc's
9511 internal overhead when calculating the initial malloc maximum.
9512
cb993c58
PE
9513 Port --enable-checking=all to Fedora 14 x86.
9514 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9515 Move to lisp.h.
9516 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
9517 (overrun_check_realloc, overrun_check_free):
9518 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
9519 That way, xmalloc returns a properly-aligned pointer even if
9520 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
9521 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
9522 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
9523 into account when calculating the initial malloc maximum.
9524 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9525 Move here from alloc.c, so that charset.c can use it too.
9526 Properly align; the old code wasn't right for common 32-bit hosts
9527 when configured with --enable-checking=all.
9528 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9529 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
9530
31bed486
EZ
95312011-09-29 Eli Zaretskii <eliz@gnu.org>
9532
04c70788 9533 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
9534 use EDOM.
9535
fbcaa2f3
EZ
95362011-09-28 Eli Zaretskii <eliz@gnu.org>
9537
9538 * xdisp.c (compute_display_string_end): If there's no display
9539 string at CHARPOS, return -1.
9540
9541 * bidi.c (bidi_fetch_char): When compute_display_string_end
9542 returns a negative value, treat the character as a normal
9543 character not covered by a display string. (Bug#9624)
9544
a239d4e9
JB
95452011-09-28 Juanma Barranquero <lekktu@gmail.com>
9546
9547 * lread.c (Fread_from_string): Fix typo in docstring.
9548
88652fd5
EZ
95492011-09-27 Eli Zaretskii <eliz@gnu.org>
9550
9551 * xdisp.c (handle_invisible_prop): If invisible text ends on a
9552 newline, reseat the iterator instead of bidi-iterating there one
9553 character at a time. (Bug#9610)
32c1fffd
SM
9554 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
9555 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 9556
ed497dd4
AS
95572011-09-27 Andreas Schwab <schwab@linux-m68k.org>
9558
9559 * lread.c (readevalloop): Use correct code for NBSP.
9560 (read1): Likewise. (Bug#9608)
9561
b2bf61aa
MA
95622011-09-25 Michael Albinus <michael.albinus@gmx.de>
9563
9564 * dbusbind.c (Fdbus_register_signal): When service is not
9565 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
9566
32bbb17c
GM
95672011-09-25 Glenn Morris <rgm@gnu.org>
9568
9569 * buffer.c (truncate-lines): Doc fix.
9570
94e0933e
CY
95712011-09-24 Chong Yidong <cyd@stupidchicken.com>
9572
9573 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
9574 (Fset_window_next_buffers): Doc fix.
9575
cddde921
GM
95762011-09-24 Glenn Morris <rgm@gnu.org>
9577
9578 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
9579
1260aef1
PE
95802011-09-24 Paul Eggert <eggert@cs.ucla.edu>
9581
25b4bfa0
PE
9582 Fix minor problems found by static checking.
9583 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
9584 * indent.c (Fvertical_motion): Fix == vs = typo.
9585
e3cbd34b
EZ
95862011-09-24 Eli Zaretskii <eliz@gnu.org>
9587
a66cfb1c
SM
9588 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
9589 Default value is now t. Doc fix.
6bf7006f 9590
e3cbd34b 9591 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 9592 logic when moving up, not only when moving down. Fix the
e3cbd34b 9593 confusing name and values of the it_overshoot_expected variable;
32c1fffd 9594 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
9595
9596 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
9597 CHARPOS is covered by a display string which includes newlines.
9598 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
9599 is covered by a display string with embedded newlines.
9600
a3de0cbd
MA
96012011-09-24 Michael Albinus <michael.albinus@gmx.de>
9602
9603 * dbusbind.c (Fdbus_register_signal): Add match rule to
9604 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
9605 (Fdbus_register_method, Vdbus_registered_objects_table):
9606 Fix docstring.
a3de0cbd 9607
b260039d
JM
96082011-09-24 Jim Meyering <meyering@redhat.com>
9609
32c1fffd 9610 do not ignore write error for any output size
b260039d
JM
9611 The previous change was incomplete.
9612 While it makes emacs --batch detect the vast majority of stdout
9613 write failures, errors were still ignored whenever the output size is
9614 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
9615 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
9616 && echo FAIL: ignored write error
9617 FAIL: ignored write error
9618 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
9619 && echo FAIL: ignored write error
9620 FAIL: ignored write error
9621 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
9622
8eca8a7c
AS
96232011-09-23 Andreas Schwab <schwab@linux-m68k.org>
9624
9625 * emacs.c (Fkill_emacs): In noninteractive mode exit
9626 non-successfully if a write error occurred on stdout. (Bug#9574)
9627
3341db62
EZ
96282011-09-21 Eli Zaretskii <eliz@gnu.org>
9629
9630 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
9631 the xassert test.
9632
9633 * dispextern.h (struct it): Update the comment documenting what
9634 can it->OBJECT be.
9635
8c203dbf
EZ
96362011-09-20 Eli Zaretskii <eliz@gnu.org>
9637
9638 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
9639 a display string, extend search for cursor position to end of row.
9640 (find_row_edges): If the row ends in a newline from a display
9641 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
9642 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
9643 (Fcurrent_bidi_paragraph_direction): Fix search for previous
9644 non-empty line. Fixes confusing cursor motion with arrow keys at
9645 the beginning of a line that starts with whitespace.
8c203dbf 9646
a4824228
LMI
96472011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9648
9649 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
9650 (bug#9493).
9651
33ed493b
CY
96522011-09-18 Chong Yidong <cyd@stupidchicken.com>
9653
9654 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
9655 boolean (Bug#9154).
9656
56cd55c8
EZ
96572011-09-18 Eli Zaretskii <eliz@gnu.org>
9658
9659 * xdisp.c (display_line): Record maximum and minimum buffer
9660 positions even if no glyphs were produced (e.g., by a zero-width
9661 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
9662 buffer positions that will be removed from the glyph row because
9663 they don't fit.
c02dcedf
EZ
9664 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9665 column is beyond frame width: don't subtract 1 "pixel" when
9666 computing width of the stretch.
3e62b7e0
EZ
9667 (reseat_at_next_visible_line_start): Undo the change made on
9668 2011-09-17 that saved paragraph information and restored it after
9669 the call to `reseat'. (Bug#9545)
56cd55c8 9670
5ed99d36 96712011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
9672
9673 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
9674 and turn window cursor on if cleared (Bug#9415).
9675
5ed99d36 96762011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
9677
9678 * search.c (boyer_moore): Take unibyte characters from pattern
9679 literally. (Bug#9458)
9680
9bade7b2
EZ
96812011-09-18 Eli Zaretskii <eliz@gnu.org>
9682
9683 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
9684
e5e9d610
PE
96852011-09-18 Paul Eggert <eggert@cs.ucla.edu>
9686
87e4427a
PE
9687 Fix minor problem found by static checking.
9688 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9689 initialized, to pacify gcc -Wuninitialized.
9690
e5e9d610
PE
9691 * fileio.c: Report proper errno when syscall falls.
9692 (Finsert_file_contents): Save and restore errno,
9693 so that report_file_error outputs the correct diagnostic.
9694 (Fwrite_region) [CLASH_DETECTION]: Likewise.
9695
a1674f0b
EZ
96962011-09-18 Eli Zaretskii <eliz@gnu.org>
9697
9698 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
9699
fbfb6dd4
EZ
97002011-09-17 Eli Zaretskii <eliz@gnu.org>
9701
9702 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
9703 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
9704
bb187662
EZ
97052011-09-17 Eli Zaretskii <eliz@gnu.org>
9706
1137e8b8 9707 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 9708 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
9709
9710 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
9711 (bidi_find_paragraph_start): Search back for paragraph beginning
9712 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
9713 (bidi_move_to_visually_next): Only trigger paragraph-related
9714 computations when the last character is a newline or at EOB, not
9715 just any NEUTRAL_B. (Bug#9470)
9716
bb187662
EZ
9717 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
9718 truncated lines if point is covered by a display string. (Bug#9524)
9719
2e621251
PE
97202011-09-16 Paul Eggert <eggert@cs.ucla.edu>
9721
9722 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9723 (cons_to_x_long): New function.
9724 (lisp_data_to_selection_data): Use it. Correct the test for
9725 short-versus-long data; it was negated. Break out of vector
9726 loop, for efficiency, when a long datum is discovered.
9727
91a15bc6
SM
97282011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
9729
9730 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
9731
b41c3a35
EZ
97322011-09-16 Eli Zaretskii <eliz@gnu.org>
9733
9734 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
9735 GCC PR/17406) by declaring this function with external scope.
9736
7812ba2d
PE
97372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9738
9739 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9740 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
9741
cf7edc2a
AS
97422011-09-15 Andreas Schwab <schwab@linux-m68k.org>
9743
9744 * editfns.c (Fformat): Correctly handle text properties on "%%".
9745
bd01620e
EZ
97462011-09-15 Eli Zaretskii <eliz@gnu.org>
9747
9748 * xterm.c (x_draw_composite_glyph_string_foreground):
9749 * w32term.c (x_draw_composite_glyph_string_foreground):
9750 * term.c (encode_terminal_code):
9751 * composite.c (composition_update_it, get_composition_id):
9752 * xdisp.c (get_next_display_element)
9753 (fill_composite_glyph_string): Add comments about special meaning
9754 of TAB characters in a composition.
9755
a02719a3
PE
97562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9757
9758 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
9759 This occurs when processing a multibyte format.
9760 Problem reported by Wolfgang Jenker.
a02719a3 9761
72589a3c
JB
97622011-09-15 Johan Bockgård <bojohan@gnu.org>
9763
9764 * xdisp.c (try_cursor_movement): Only check for exact match if
9765 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
9766
1c14176c
PE
97672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9768
9769 Remove unused external symbols.
9770 * dispextern.h (calc_pixel_width_or_height): Remove decl.
9771 * xdisp.c (calc_pixel_width_or_height): Now static.
9772 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
9773 * indent.c (check_display_width):
9774 * w32term.c: Fix comment to match code.
9775 * xterm.c, xterm.h (x_catching_errors): Remove.
9776
d2eea5b5
PE
97772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9778
9779 * xselect.c: Use signed conversions more consistently (Bug#9498).
9780 (selection_data_to_lisp_data): Assume incoming selection data are
9781 signed integers, not unsigned. This is to be consistent with
9782 outgoing selection data, which was modified to use signed integers
9783 in as part of the fix to Bug#9196 in response to Jan D.'s comment
9784 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
9785 expects long, not unsigned long.
9786
46888499
EZ
97872011-09-14 Eli Zaretskii <eliz@gnu.org>
9788
9789 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
9790 computation of loop end. Reported by Johan Bockgård
9791 <bojohan@gnu.org>.
9792
ef8ef9fb
CY
97932011-09-13 Chong Yidong <cyd@stupidchicken.com>
9794
9795 * frame.c (Fother_visible_frames_p): Function deleted.
9796
fa819fed
EZ
97972011-09-12 Eli Zaretskii <eliz@gnu.org>
9798
9799 * indent.c (compute_motion): Process display vector front to back
9800 rather than the other way around. (Bug#2496)
9801
2ba8e008
SM
98022011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
9803
9804 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
9805
20f53c69
CY
98062011-09-11 Chong Yidong <cyd@stupidchicken.com>
9807
9808 * minibuf.c (Fread_from_minibuffer): Doc fix.
9809
d562d7a4
EZ
98102011-09-11 Eli Zaretskii <eliz@gnu.org>
9811
9812 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
9813 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
9814
1c4d7f3d
LMI
98152011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9816
9817 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
9818 value for non-existent files.
9819
b885bf36
EZ
98202011-09-11 Eli Zaretskii <eliz@gnu.org>
9821
9822 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9823 set its "size" to -1. This will set the modtime_size field of
9824 the corresponding buffer to -1, which is what
9825 verify-visited-file-modtime expects for files that do not exist.
9826 (Bug#9139)
9827
6612f0bf
PE
98282011-09-11 Paul Eggert <eggert@cs.ucla.edu>
9829
9830 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
9831 here ...
9832 * lisp.h: ... from here. push_key_description is no longer
9833 defined in keyboard.c, so its declaration should not be in
9834 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
9835 logically belongs with push_key_description.
9836
dfb3f755
PE
98372011-09-10 Paul Eggert <eggert@cs.ucla.edu>
9838
9839 * buffer.h: Include <sys/types.h> instead of <time.h>.
9840 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
9841 Problem reported by Herbert J. Skuhra.
9842
3134906c
LMI
98432011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9844
9845 * xml.c (parse_region): Make the parsing work for
9846 non-comment-starting XML files again (bug#9144).
9847
8d903f4e
AS
98482011-09-10 Andreas Schwab <schwab@linux-m68k.org>
9849
9850 * image.c (gif_load): Fix calculation of bottom and right corner.
9851 (Bug#9468)
9852
80ad64f4
EZ
98532011-09-10 Eli Zaretskii <eliz@gnu.org>
9854
9855 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9856 redisplay in small windows.
9857
208a048d
EZ
98582011-09-09 Eli Zaretskii <eliz@gnu.org>
9859
9860 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9861
9b1c252e
MR
98622011-09-08 Martin Rudalics <rudalics@gmx.at>
9863
9864 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
9865 Operate on live windows only.
9866
2949f33b
JB
98672011-09-08 Juanma Barranquero <lekktu@gmail.com>
9868
9869 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
9870
e08dcafd
EZ
98712011-09-07 Eli Zaretskii <eliz@gnu.org>
9872
9873 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
9874 only under bidi iteration.
9875
115b96bd
JD
98762011-09-07 Jan Djärv <jan.h.d@swipnet.se>
9877
9878 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
9879
c8199d0f
PE
98802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
9881
9882 isnan: Fix porting problem to Solaris 10 with bundled gcc.
9883 Without this fix, the command to link temacs failed due to an
9884 undefined symbol __builtin_isnan. This is because
9885 /usr/include/iso/math_c99.h #defines isnan(x) to
9886 __builtin_isnan(x), but the bundled gcc, which identifies itself
9887 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9888 a __builtin_isnan.
9889 * floatfns.c (isnan): #undef, and then #define to a clone of
9890 what's in data.c.
9891 (Fisnan): Always define, since it's always available now.
9892 (syms_of_floatfns): Always define isnan at the Lisp level.
9893
e39b275c 98942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
9895
9896 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
9897
b2db44d9 98982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 9899
f4af5137 9900 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
9901 The previous code assumed that file offsets (off_t values) fit in
9902 EMACS_INT variables, which is not true on typical 32-bit hosts.
9903 The code messed up by falsely reporting buffer overflow in cases
9904 such as (insert-file-contents "big" nil 1 2) into an empty buffer
9905 when "big" contains more than 2**29 bytes, even though this
9906 inserts just one byte and does not overflow the buffer.
9907 (Finsert_file_contents): Store file offsets as off_t
9908 values, not as EMACS_INT values. Check for overflow when
9909 converting between EMACS_INT and off_t. When checking for
9910 buffer overflow or for overlap, take the offsets into account.
9911 Don't use EMACS_INT for small values where int suffices.
9912 When checking for overlap, fix a typo: ZV was used where
9913 ZV_BYTE was intended.
9914 (Fwrite_region): Don't assume off_t fits into 'long'.
9915 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
9916
ecfc0a49
MA
99172011-09-05 Michael Albinus <michael.albinus@gmx.de>
9918
9919 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
9920
6511acf2 99212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 9922
0999621a 9923 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
9924
9925 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 9926 (esprintf, exprintf, evxprintf): New functions.
62f19c19 9927 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 9928 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
9929 (modify_event_symbol): Do not assume that the length of
9930 name_alist_or_stem is safe to alloca and fits in int.
9931 (Fexecute_extended_command): Likewise for function name and binding.
9932 (Frecursion_depth): Wrap around reliably on integer overflow.
9933 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
9934 since some callers pass EMACS_INT values.
9935 (Fsingle_key_description): Don't crash if symbol name contains more
9936 than MAX_ALLOCA bytes.
9937 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
9938 (get_minibuffer): Arg is now EMACS_INT, not int.
9939 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 9940 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
9941 * window.h (command_loop_level, minibuf_level): Reflect API changes.
9942
2be7d702
PE
9943 * dbusbind.c (signature_cat): New function.
9944 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
9945 Do not overrun buffer; instead, report string overflow.
9946
9d1df220
PE
9947 * dispnew.c (add_window_display_history): Don't overrun buffer.
9948 Truncate instead; this is OK since it's just a log.
9949
33ef5c64
PE
9950 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9951 even if the time zone offset is outlandishly large.
9952 Don't mishandle offset == INT_MIN.
9953
66c6fdd5
PE
9954 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9955 when creating daemon; the previous buffer-overflow check was incorrect.
9956
d749b01b
PE
9957 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9958 which has the guts of the old verror function.
9959
b5cd1905
PE
9960 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9961 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9962
6e1a67fb
PE
9963 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9964 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9965 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9966 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9967 length of string rather than counting it via multiple sprintfs;
9968 that's simpler and more reliable.
c21721cc
PE
9969 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9970 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9971 sprintf, in case result does not fit in int.
9972
c57b67fc
PE
9973 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9974 (fontset_from_font): Print it.
9975
8a401434
PE
9976 * frame.c (tty_frame_count): Now printmax_t, not int.
9977 (make_terminal_frame, set_term_frame_name): Print it.
9978 (x_report_frame_params): In X, window IDs are unsigned long,
9979 not signed long, so print them as unsigned.
9980 (validate_x_resource_name): Check for implausibly long names,
9981 and don't assume name length fits in 'int'.
9982 (x_get_resource_string): Don't blindly alloca invocation name;
9983 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9984 not fit in int.
9985
6e1a67fb
PE
9986 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9987 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9988 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9989
0df02bf3
PE
9990 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9991 Use esprintf, not sprintf, in case result does not fit in int.
9992
48e30793
PE
9993 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9994 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9995 it as a large positive number.
9996 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9997 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9998
a66ff6d8
PE
9999 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
10000 in case result does not fit in int.
10001
aca216ff
PE
10002 * print.c (float_to_string): Detect width overflow more reliably.
10003 (print_object): Make sprintf buffer a bit bigger, to avoid potential
10004 buffer overrun. Don't assume list length fits in 'int'. Treat
10005 print length of 0 as 0, not as infinity; to be consistent with other
10006 uses of print length in this function. Don't overflow print length
10007 index. Don't assume hash table size fits in 'long', or that
10008 vectorlike size fits in 'unsigned long'.
10009
31c286f7
PE
10010 * process.c (make_process): Use printmax_t, not int, to format
10011 process-name gensyms.
10012
55e5faa1
PE
10013 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
10014
80f2e268
PE
10015 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
10016 to avoid potential buffer overrun.
10017
670741ab
PE
10018 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
10019 if X resource line is longer than 512 bytes.
10020
b7163a50
PE
10021 * xfns.c (x_window): Make sprintf buffer a bit bigger
10022 to avoid potential buffer overrun.
10023
ae58ff1f
PE
10024 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
10025
c43c8a6a
PE
10026 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
10027
3f8236f4
PE
100282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
10029
53e9fe90 10030 Integer overflow fixes for scrolling, etc.
6511acf2
PE
10031 Without these, Emacs silently mishandles large integers sometimes.
10032 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
10033 it were "C-u 1 M-x recenter" on a typical 64-bit host.
10034
6511acf2
PE
10035 * xdisp.c (try_window_id): Check Emacs fixnum range before
10036 converting to 'int'.
806add1d 10037
6511acf2 10038 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
10039 Check that an Emacs fixnum is in range before assigning it to 'int'.
10040 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
10041 values converted from Emacs fixnums.
10042 (Frecenter): Don't wrap around a line count if it is out of 'int'
10043 range; instead, treat it as an extreme value.
10044 (Fset_window_configuration, compare_window_configurations):
10045 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
10046
6511acf2
PE
10047 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
10048 that can exceed INT_MAX. Check that EMACS_INT value is in range
10049 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
10050 (match_limit): Don't assume that a fixnum can fit in 'int'.
10051
6511acf2 10052 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
10053 exceed INT_MAX.
10054
6511acf2 10055 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
10056 (Fvertical_motion): Don't wrap around LINES values that don't fit
10057 in 'int'. Instead, treat them as extreme values. This is good
10058 enough for windows, which can't have more than INT_MAX lines anyway.
10059
fcb901a7
LMI
100602011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10061
0f2f6b6d
LMI
10062 * Require libxml/parser.h to avoid compilation warning.
10063
fcb901a7
LMI
10064 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
10065
10066 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
10067 since this reportedly can destroy thread storage.
10068
6e20a0d4
CY
100692011-08-30 Chong Yidong <cyd@stupidchicken.com>
10070
10071 * syntax.c (find_defun_start): Update all cache variables if
10072 exiting early (Bug#9401).
10073
148ae00e
EZ
100742011-08-30 Eli Zaretskii <eliz@gnu.org>
10075
f6cfbd8f
EZ
10076 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
10077
148ae00e
EZ
10078 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
10079 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
10080 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
10081
10082 * term.c (tty_append_glyph): New function.
10083 (produce_stretch_glyph): Static function and its prototype deleted.
10084
a66cfb1c
SM
10085 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10086 Add prototypes.
148ae00e 10087
c4a07a4c
PE
100882011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10089
10090 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10091 when checking :margin (Bug#9390).
10092 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10093 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10094 so that the name doesn't mislead. All uses changed.
10095
6bc8cd65
JB
100962011-08-28 Johan Bockgård <bojohan@gnu.org>
10097
10098 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10099 set_tty_hooks.
10100
dca4927e
EZ
101012011-08-27 Eli Zaretskii <eliz@gnu.org>
10102
10103 * xdisp.c (move_it_to): Don't bail out early when reaching
10104 position beyond to_charpos, if we are scanning backwards.
10105 (move_it_vertically_backward): When DY == 0, make sure we get to
10106 the first character in the line after the newline.
10107
f2cad773
PE
101082011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10109
10110 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10111 (ccl_driver): Do not generate an out-of-range pointer.
10112 (Fccl_execute_on_string): Remove unnecessary check for
10113 integer overflow, noted by Stefan Monnier in
10114 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10115 Remove a FIXME that didn't need fixing.
10116 Simplify the newly-introduced buffer reallocation code.
10117
0cae2cdb
JB
101182011-08-27 Juanma Barranquero <lekktu@gmail.com>
10119
10120 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10121
5fc295a4 101222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10123
70c60eb2 10124 Integer and memory overflow issues (Bug#9196).
726e0ab1 10125
d31850da
PE
10126 * doc.c (get_doc_string): Rework so that
10127 get_doc_string_buffer_size is the actual buffer size, rather than
10128 being 1 less than the actual buffer size; this makes xpalloc more
10129 convenient.
10130
a69fbedb
PE
10131 * image.c (x_allocate_bitmap_record, cache_image):
10132 * xselect.c (Fx_register_dnd_atom):
10133 Simplify previous changes by using xpalloc.
10134
fe5c5d37
PE
10135 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10136 since either will do and ptrdiff_t is convenient with xpalloc.
10137
0065d054
PE
10138 * charset.c (charset_table_size)
10139 (struct charset_sort_data.priority): Now ptrdiff_t.
10140 (charset_compare): Don't overflow if priorities differ greatly.
10141 (Fsort_charsets): Don't assume list length fits in int.
10142 Check for size-calculation overflow when allocating sort data.
10143 (syms_of_charset): Allocate an initial charset table that is
10144 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10145
10146 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10147
10148 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10149 The actual value is always <= INT_MAX, and leaving it unsigned made
10150 overflow checking harder.
10151
10152 * dispextern.h (struct glyph_matrix.rows_allocated)
10153 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10154 with xpalloc. The values are still always <= INT_MAX.
10155
10156 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10157
10158 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10159 (SAFE_NALLOCA): New macro.
10160
10161 * region-cache.c (struct boundary.pos, find_cache_boundary)
10162 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10163 (set_cache_region, invalidate_region_cache)
10164 (revalidate_region_cache, know_region_cache, region_cache_forward)
10165 (region_cache_backward, pp_cache):
10166 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10167 so that ptrdiff_t * can be passed to xpalloc.
10168 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10169 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10170 (pp_cache): Don't assume cache_len fits in int.
10171 * region-cache.h: Adjust extern decls to match.
10172
10173 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10174 EMACS_INT, since either will do, for xpalloc.
10175
10176 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10177 (xnmalloc, xnrealloc, xpalloc): New functions.
10178
726e0ab1
PE
10179 * bidi.c (bidi_shelve_header_size): New constant.
10180 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10181 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10182
51f30bc5 10183 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10184 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10185 (overlay_strings):
10186 Don't update size of array until after memory allocation succeeds,
10187 because xmalloc/xrealloc may not return.
0065d054
PE
10188 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10189 now that we have proper integer overflow checking.
10190 (record_overlay_string, overlay_strings): Catch overflows when
10191 calculating size of overlay_str_buf.
726e0ab1 10192
0065d054
PE
10193 * callproc.c (Fcall_process): Check for size overflow when
10194 calculating size of args2.
10195 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10196 Normally we prefer signed values, but sticking with ptrdiff_t would
10197 require adding more-complicated checks.
726e0ab1
PE
10198
10199 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10200 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10201 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10202 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10203
10204 * character.c (Fstring): Check for size-calculation overflow.
10205
10206 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10207 unnecessary integer overflow. Check for size overflow.
10208 (encode_coding_object): Don't update size until xmalloc succeeds.
10209
10210 * composite.c (get_composition_id): Check for overflow in glyph
10211 length calculations.
10212
10213 Integer and memory overflow fixes for display code.
10214 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10215 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10216 (scrolling_window): Check for overflow in size calculations.
10217 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10218 Don't assume glyph table len fits in int.
10219 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10220 (row_table_size): Now ptrdiff_t, not int.
10221 (scrolling_window): Avoid overflow in size calculations.
10222 Don't update size until allocation succeeds.
10223 * fns.c (concat): Check for overflow in size calculations.
10224 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10225 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10226 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10227
10228 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10229 (get_doc_string): Check for size calculation overflow.
10230 Don't update size until allocation succeeds.
10231 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10232 EMACS_INT, where ptrdiff_t will do.
10233 (Fsubstitute_command_keys): Check for string overflow.
10234
10235 * editfns.c (set_time_zone_rule): Don't assume environment length
10236 fits in int.
10237 (message_length): Now ptrdiff_t, not int.
10238 (Fmessage_box): Don't update size until allocation succeeds.
10239 Don't assume message length fits in int.
10240 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10241
0065d054
PE
10242 * emacs.c (main): Do not reallocate argv, since there is a null at
10243 the end that can be overwritten, and this way there's no need to
10244 worry about size-calculation overflow.
10245 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10246
10247 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10248 alloc succeeds.
10249 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10250
10251 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10252 (x_set_scroll_bar_width, x_figure_window_size):
10253 Check for integer overflow.
10254 (x_set_alpha): Do not assume XINT fits in int.
10255
10256 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10257 This is for the members text_lines, text_cols, total_lines, total_cols,
10258 where the system imposes an 'int' limit.
10259
10260 * fringe.c (Fdefine_fringe_bitmap):
10261 Don't update size until alloc works.
10262
10263 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10264 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10265
10266 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10267 Check for size-calculation overflow.
10268 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10269 do, as we prefer signed integers.
10270 (id_to_widget.max_size, id_to_widget.used)
10271 (xg_store_widget_in_map, xg_remove_widget_from_map)
10272 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10273 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10274 Use and return ptrdiff_t, not int.
10275 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10276 * gtkutil.h: Change prototypes to match the above.
10277
10278 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10279 are duplicate now that they've been promoted to lisp.h.
10280 (x_allocate_bitmap_record, x_alloc_image_color)
10281 (make_image_cache, cache_image, xpm_load):
10282 Don't update size until alloc is done.
10283 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10284 (x_detect_edges):
3256efce 10285 Check for size calculation overflow.
726e0ab1
PE
10286 (ct_colors_allocated_max): New constant.
10287 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10288 overflow.
3256efce 10289
726e0ab1
PE
10290 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10291 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10292 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10293 Use ptrdiff_t, not int, to count maps.
10294 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10295 calculations. Don't update size until allocation succeeds.
10296 Redo calculations to avoid overflow.
726e0ab1
PE
10297 * keyboard.h: Change prototypes to match the above.
10298
10299 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10300 to count maps.
10301 (current_minor_maps): Check for size calculation overflow.
10302 * keymap.h: Change prototypes to match the above.
10303
10304 * lread.c (read1, init_obarray): Don't update size until alloc done.
10305
10306 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10307 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10308
726e0ab1
PE
10309 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10310 Now ptrdiff_t, not int.
10311 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10312 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10313
10314 * process.c (Fnetwork_interface_list): Check for overflow
10315 in size calculation.
10316
10317 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10318
10319 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10320 overflow. Don't bother calling xmalloc when xrealloc will do.
10321
10322 * search.c (Freplace_match): Check for size calculation overflow.
10323 (Fset_match_data): Don't assume list lengths fit in 'int'.
10324
10325 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10326 for command line length. Do not attempt to address one before the
10327 beginning of an array, as that's not portable.
10328
10329 * term.c (max_frame_lines): Remove; unused.
10330 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
10331 not int.
10332 (encode_terminal_code, calculate_costs): Check for size
10333 calculation overflow.
10334 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
10335 table lengths and related sizes. Don't update size until alloc
10336 done. Redo calculations to avoid overflow.
10337 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
10338
10339 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
10340 subtracting pointers.
10341 (gobble_line): Check for overflow more carefully. Don't update size
10342 until alloc done.
10343
10344 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
10345 Don't update size until alloc done.
10346 Redo size calculations to avoid overflow.
10347 Check for size calculation overflow.
0065d054 10348 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
10349
10350 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
10351 Use ptrdiff_t, not int, for sizes.
10352 (store_mode_line_noprop_char): Don't update size until alloc done.
10353
0065d054
PE
10354 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
10355 Use ptrdiff_t, not int, for sizes.
10356 (Finternal_make_lisp_face, cache_face):
10357 Check for size calculation overflow.
10358 (cache_face): Treat size calculation overflows as if they were
10359 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
10360
10361 * xfns.c (x_encode_text, x_set_name_internal)
10362 (Fx_change_window_property): Use ptrdiff_t, not int, to count
10363 sizes, since they can exceed INT_MAX in size. Check for size
10364 calculation overflow.
10365
0065d054
PE
10366 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
10367 (xg_select): Check for size calculation overflow.
726e0ab1
PE
10368 Don't update size until alloc done.
10369
0065d054 10370 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 10371 as sprintf is limited to int lengths.
1d526e2f 10372
252c5ee1
PE
10373 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
10374 (X_LONG_MIN): New macros.
864d7ce7
PE
10375 Use them to make the following changes clearer.
10376 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
10377 This change doesn't affect the value now, but it may help remind
10378 future maintainers not to raise the value too much later.
10379 (SELECTION_QUANTUM): Remove, replacing with ...
10380 (selection_quantum): ... new function, which avoids overflow.
10381 All uses changed.
10382 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
10383 assumption that selection length fits in 'int'.
10384 (x_reply_selection_request, x_handle_selection_request)
10385 (x_get_window_property, receive_incremental_selection)
10386 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
10387 (lisp_data_to_selection_data, clean_local_selection_data):
10388 Use ptrdiff_t, not int, to record length of selection.
10389 (x_reply_selection_request, x_get_window_property)
10390 (receive_incremental_selection, x_property_data_to_lisp):
10391 Redo calculations to avoid overflow.
10392 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 10393 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
10394 something.
10395 (x_get_window_property, receive_incremental_selection)
10396 (lisp_data_to_selection_data, x_property_data_to_lisp):
10397 Check for size-calculation overflow.
10398 (x_get_window_property, receive_incremental_selection)
10399 (lisp_data_to_selection_data, Fx_register_dnd_atom):
10400 Don't store size until memory allocation succeeds.
10401 (x_get_window_property): Plug memory leak on memory exhaustion.
10402 Don't double-block input; malloc is safe here. Don't assume 2**34
10403 - 4 fits in unsigned long. Add an xassert to check
10404 XGetWindowProperty overflow. Be more careful about overflow
10405 calculations, and distinguish size from memory overflow better.
10406 (receive_incremental_selection): When tracing, don't assume
10407 unsigned int is less than INT_MAX.
10408 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
10409 harmful) conversions of unsigned short to int.
10410 (lisp_data_to_selection_data): Don't assume that integers
10411 in the range -65535 through -1 fit in an X unsigned short.
10412 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
10413 result parameters unless successful. Rely on cons_to_unsigned
10414 to report problems with elements; the old code wasn't right anyway.
10415 (x_check_property_data): Check for int overflow; we cannot use
10416 a wider type due to X limits.
10417 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
10418
726e0ab1 10419 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 10420
0065d054
PE
10421 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
10422 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
10423 (x_color_cells): Don't store size until memory allocation succeeds.
10424 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 10425 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
10426 (x_term_init): Don't assume length fits in int (sprintf is limited
10427 to int size).
bc18e09d 10428
ebfa62c0
PE
10429 Use ptrdiff_t for composition IDs.
10430 * character.c (lisp_string_width):
10431 * composite.c (composition_table_size, n_compositions)
10432 (get_composition_id, composition_gstring_from_id):
10433 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
10434 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
10435 * window.c (Frecenter):
10436 Use ptrdiff_t, not int, for composition IDs.
10437 * composite.c (get_composition_id): Check for integer overflow.
10438 * composite.h: Adjust prototypes to match the above changes.
10439
d3411f89
PE
10440 Use ptrdiff_t for hash table indexes.
10441 * category.c (hash_get_category_set):
10442 * ccl.c (ccl_driver):
10443 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
10444 * coding.c (coding_system_charset_list, detect_coding_system):
10445 * coding.h (struct coding_system.id):
10446 * composite.c (get_composition_id, gstring_lookup_cache):
10447 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
10448 * image.c (xpm_get_color_table_h):
10449 * lisp.h (hash_lookup, hash_put):
10450 * minibuf.c (Ftest_completion):
10451 Use ptrdiff_t for hash table indexes, not int (which is too
10452 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
10453 32-bit --with-wide-int hosts).
10454
e097a6fa
PE
10455 * charset.c (Fdefine_charset_internal): Check for integer overflow.
10456 Add a FIXME comment about memory leaks.
10457 (syms_of_charset): Don't assume xmalloc returns.
10458
5637687f
PE
10459 Don't assume that stated character widths fit in int.
10460 * character.c (Fchar_width, c_string_width, lisp_string_width):
10461 * character.h (CHAR_WIDTH):
10462 * indent.c (MULTIBYTE_BYTES_WIDTH):
10463 Use sanitize_char_width to avoid undefined and/or bad behavior
10464 with outlandish widths.
a66cfb1c 10465 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
10466 now that we have two such functions. All uses changed.
10467 (sanitize_char_width): New inline function.
10468
a2271ba2
PE
10469 Don't assume that tab-width fits in int.
10470 * character.h (sanitize_width): New inline function.
10471 (SANE_TAB_WIDTH): New macro.
10472 (ASCII_CHAR_WIDTH): Use it.
10473 * indent.c (sane_tab_width): Remove. All uses replaced by
10474 SANE_TAB_WIDTH (current_buffer).
10475 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
10476
18c52557
PE
10477 * fileio.c: Integer overflow issues with file modes.
10478 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
10479
caeeedc1
PE
10480 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
10481 Remove unreachable code.
10482 (read_hex, load_charset_map_from_file): Check for integer overflow.
10483
6df6ae42 10484 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
10485 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
10486 (x_send_scroll_bar_event): Likewise. Check that the size does not
10487 exceed limits imposed by XClientMessageEvent, as well as the usual
10488 ptrdiff_t and size_t limits.
10489
b13995db
PE
10490 * keyboard.c: Overflow, signedness and related fixes.
10491 (make_lispy_movement): Use same integer type in forward decl
10492 that is used in the definition.
10493 (read_key_sequence, keyremap_step):
10494 Change bufsize argument back to int, undoing my 2011-03-30 change.
10495 We prefer signed types, and int is wide enough here.
10496 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
10497 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
10498 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
10499 length, not size_t. Use ptrdiff_t for index, not int.
10500 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
10501 possibility of integer overflow.
10502
13464394
PE
10503 Overflow, signedness and related fixes for images.
10504
10505 * dispextern.h (struct it.stack[0].u.image.image_id)
10506 (struct_it.image_id, struct image.id, struct image_cache.size)
10507 (struct image_cache.used, struct image_cache.ref_count):
10508 * gtkutil.c (update_frame_tool_bar):
10509 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
10510 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
10511 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
10512 * nsmenu.m (update_frame_tool_bar):
10513 * xdisp.c (calc_pixel_width_or_height):
10514 * xfns.c (image_cache_refcount):
10515 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
10516 on typical 64-bit hosts.
10517
10518 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10519 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
10520 Omit unnecessary casts to int.
10521 (parse_image_spec): Check that integers fall into 'int' range
10522 when the callers expect that.
10523 (image_ascent): Redo ascent calculation to avoid int overflow.
10524 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
10525 (lookup_image): Remove unnecessary tests.
10526 (xbm_image_p): Locals are now of int, not EMACS_INT,
10527 since parse_image_check makes sure they fit into int.
10528 (png_load, gif_load, svg_load_image):
10529 Prefer int to unsigned where either will do.
10530 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
10531 old tiff_error_handler and tiff_warning_handler.
10532 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
10533 stack buffer overflows. It uses only the features of vsnprintf
10534 that are common to both POSIX and native Microsoft.
10535 (tiff_error_handler, tiff_warning_handler): Use it.
10536 (tiff_load, gif_load, imagemagick_load_image):
10537 Don't assume :index value fits in 'int'.
10538 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
10539 (imagemagick_load_image): Check that crop parameters fit into
10540 the integer types that MagickCropImage accepts. Don't assume
10541 Vimagemagick_render_type has a nonnegative value. Don't assume
10542 size_t fits in 'long'.
10543 (gs_load): Use printmax_t to print the widest integers possible.
10544 Check for integer overflow when computing image height and width.
10545
c11821d4
EZ
105462011-08-26 Eli Zaretskii <eliz@gnu.org>
10547
10548 * xdisp.c (redisplay_window): Don't force window start if point
10549 will be invisible in the resulting window. (Bug#9324)
10550
0c95fcf7
EZ
105512011-08-25 Eli Zaretskii <eliz@gnu.org>
10552
10553 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
10554 the display spec is of the form `(space ...)'.
10555 (handle_display_spec): Return the value returned by
10556 handle_single_display_spec, not just 1 or zero.
10557 (handle_single_display_spec): If the display spec is of the form
10558 `(space ...)', and specifies display in the text area, return 2
10559 rather than 1.
fee65a97 10560 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
10561 accurately, and prefer exact match for point under bidi.
10562 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
10563
10564 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
10565 into disp_prop; all users changed.
10566
10567 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
10568 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
10569 for the text covered by the display property.
10570
e4ed06f1
CY
105712011-08-25 Chong Yidong <cyd@stupidchicken.com>
10572
10573 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
10574 Change return value to nil.
10575 (Frecord_buffer): Delete unused function.
10576
f67cdd7f
EZ
105772011-08-24 Eli Zaretskii <eliz@gnu.org>
10578
5980d4c6
EZ
10579 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
10580 buffers, return left-to-right.
8610fe8b
EZ
10581 (set_cursor_from_row): Consider candidate row a win if its glyph
10582 represents a newline and point is on that newline. Fixes cursor
10583 positioning on the newline at EOL of R2L text within L2R
10584 paragraph, and vice versa.
10585 (try_cursor_movement): Check continued rows, in addition to
10586 continuation rows. Fixes unwarranted scroll when point enters a
10587 continued line of R2L text within an L2R paragraph, or vice versa.
10588 (cursor_row_p): Consider the case of point being equal to
10589 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
10590 from the end of a short line to the beginning of a continued line
10591 of R2L text within L2R paragraph.
10592 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
10593 composed characters.
5980d4c6 10594
f67cdd7f
EZ
10595 * bidi.c (bidi_check_type): Use xassert.
10596 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
10597 members.
10598
bca633fb
EZ
105992011-08-23 Eli Zaretskii <eliz@gnu.org>
10600
10601 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
10602 a character.
10603
4a5885a7
CY
106042011-08-23 Chong Yidong <cyd@stupidchicken.com>
10605
10606 * nsfont.m (ns_otf_to_script): Fix typo.
10607
0902a04e
KH
106082011-08-22 Kenichi Handa <handa@m17n.org>
10609
10610 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
10611 extra slot even if the purpose is char-code-property-table.
10612
1a2e6670
EZ
106132011-08-23 Eli Zaretskii <eliz@gnu.org>
10614
8ddde651
EZ
10615 * xdisp.c (redisplay_window): When computing centering_position,
10616 account for the height of the header line. (Bug#8874)
10617
425cc014
EZ
10618 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
10619 instead of CHAR_TO_BYTE. Fixes a crash when a completion
10620 candidate is selected by the mouse, and that candidate has a
10621 composed character under the mouse.
10622
1a2e6670
EZ
10623 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
10624 coordinates reported by pos-visible-in-window-p for a composed
10625 character in column zero.
10626
8b76d6f8
SM
106272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
10628
10629 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
10630
dac347dd
EZ
106312011-08-22 Eli Zaretskii <eliz@gnu.org>
10632
10633 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
10634 consider it a hit if to_charpos is anywhere in the range of the
10635 composed buffer positions.
10636
e013fb34
CY
106372011-08-22 Chong Yidong <cyd@stupidchicken.com>
10638
10639 * image.c (gif_load): Don't assume that each subimage has the same
10640 dimensions as the base image. Handle disposal method that is
10641 "undefined" by the gif spec (Bug#9335).
10642
bd1ba3e8
CY
106432011-08-20 Chong Yidong <cyd@stupidchicken.com>
10644
10645 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 10646 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 10647
54a1215b
EZ
106482011-08-19 Eli Zaretskii <eliz@gnu.org>
10649
823564e5
EZ
10650 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
10651 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
10652 from an Org mode buffer to a Speedbar frame.
10653
54a1215b
EZ
10654 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
10655 a composition, take its buffer position from IT->cmp_it.charpos.
10656 Fixes cursor positioning at the beginning of a line that begins
10657 with a composed character.
10658
9778ebcc
EZ
106592011-08-18 Eli Zaretskii <eliz@gnu.org>
10660
0be6ee06
EZ
10661 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
10662 character bidirectional type, use STRONG_L instead. Fixes crashes
10663 in a buffer produced by `describe-categories'.
10664
9778ebcc
EZ
10665 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
10666 members before the level stack, so they would be saved and
10667 restored when copying iterator state. Fixes incorrect reordering
10668 around TABs covered by display properties.
10669
156bffbe
AS
106702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10671
6b02f655 10672 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 10673
72ad093b
CY
106742011-08-17 Chong Yidong <cyd@stupidchicken.com>
10675
10676 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
10677 (internal_condition_case_2, internal_condition_case_n):
10678 Remove unnecessary aborts (Bug#9081).
72ad093b 10679
35774242
EZ
106802011-08-17 Eli Zaretskii <eliz@gnu.org>
10681
10682 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10683 has no `load' handler, try opening the file locally. (Bug#9311)
10684
db76dd85
KB
106852011-08-16 Ken Brown <kbrown@cornell.edu>
10686
10687 * gmalloc.c: Expand comment.
10688
b215eee5
EZ
106892011-08-16 Eli Zaretskii <eliz@gnu.org>
10690
10691 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
10692 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
10693
a4579d33
KB
106942011-08-16 Ken Brown <kbrown@cornell.edu>
10695
10696 Fix memory allocation problems in Cygwin build (Bug#9273).
10697
10698 * unexcw.c ( __malloc_initialized): Declare external variable.
10699 (fixup_executable): Force the dumped emacs to reinitialize malloc.
10700
8b76d6f8
SM
10701 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
10702 New variables.
a4579d33
KB
10703 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
10704 dumped emacs.
10705 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
10706 in the static heap.
10707 [CYGWIN] (special_realloc): New function.
10708 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
10709 requests to realloc storage in the static heap.
10710
3ebec551
PE
107112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
10712
10713 * bidi.c (bidi_initialize): Remove unused local.
10714
9fd8be00
EZ
107152011-08-15 Eli Zaretskii <eliz@gnu.org>
10716
6b02f655
SM
10717 * bidimirror.h:
10718 * biditype.h: Remove file.
10719 * makefile.w32-in ($(BLD)/bidi.$(O)):
10720 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
10721
10722 * dispextern.h: Fix a typo in the comment to bidi_type_t.
10723
10724 * chartab.c: Improve commentary for the uniprop_table API.
10725
32413314
EZ
10726 * bidi.c (bidi_paragraph_init): Support zero value of
10727 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
10728 (bidi_initialize): Use uniprop_table instead of including
10729 biditype.h and bidimirror.h.
32413314 10730
9fd8be00
EZ
10731 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
10732 coordinates of the iterator when restoring from ppos_it.
10733 (Bug#9296)
10734
5cf2b69b
KH
107352011-08-14 Kenichi Handa <handa@m17n.org>
10736
10737 * process.c (create_process): Call setup_process_coding_systems
72ad093b 10738 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 10739
daf17d00
EZ
107402011-08-14 Eli Zaretskii <eliz@gnu.org>
10741
10742 * xdisp.c (move_it_in_display_line_to): Don't invoke
10743 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10744 ppos_it. Fixes vertical cursor motion when line beginning is
10745 covered by an image. (Bug#9296)
10746
08e3161a
JD
107472011-08-14 Jan Djärv <jan.h.d@swipnet.se>
10748
10749 * nsterm.h (ns_run_ascript): Declare.
10750 (NSAPP_DATA2_RUNASSCRIPT): Define.
10751
10752 * nsfns.m (as_script, as_result, as_status): New static variables.
10753 (ns_run_ascript): New function.
5e617bc2 10754 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
10755 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10756 the event loop. Get status from as_status (Bug#7276).
10757
10758 * nsterm.m (sendEvent): If event is NSApplicationDefined and
10759 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
10760 the event loop (Bug#7276).
10761
a3720aa2
AS
107622011-08-14 Andreas Schwab <schwab@linux-m68k.org>
10763
10764 * gnutls.c (QCgnutls_bootprop_priority)
10765 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
10766 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
10767 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
10768 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
10769 (QCgnutls_bootprop_verify_hostname_error)
10770 (QCgnutls_bootprop_callbacks_verify): Rename from
10771 Qgnutls_bootprop_..., all uses changed.
10772
10773 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
10774 uses changed.
10775
0a0d27fb
PE
107762011-08-14 Paul Eggert <eggert@cs.ucla.edu>
10777
19d5c50c
PE
10778 * xfaces.c (Qframe_set_background_mode): Now static.
10779 * dispextern.h (Qframe_set_background_mode): Remove decl.
10780
0a0d27fb
PE
10781 * process.c (Fnetwork_interface_info): Declare local only if needed.
10782
377538cb
JD
107832011-08-13 Jan Djärv <jan.h.d@swipnet.se>
10784
10785 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
10786 (Fnetwork_interface_list): Allocate in increments of bytes instead
10787 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10788 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
10789 sockaddr.
10790 (struct ifflag_def): notrailers is smart on OSX.
10791 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10792 Get hardware address with getifaddrs if available.
10793
08fff70c
EZ
107942011-08-12 Eli Zaretskii <eliz@gnu.org>
10795
10796 * xdisp.c (iterate_out_of_display_property): xassert that
10797 IT->position is set to within IT->object's boundaries. Break from
10798 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
10799 when IT->position is set up wrongly due to some bug.
10800 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
10801 (push_display_prop): Allow GET_FROM_STRING as IT->method on
10802 entry. Force push_it to save on the stack the current
10803 buffer/string position, to be restored by pop_it. Fix flags in
10804 the iterator structure wrt the object coming from a display
10805 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
10806 properties. (Bug#9284)
10807
7be1c708 108082011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 10809
7be1c708
CY
10810 * fontset.c (fontset_get_font_group): Add proper type checks.
10811 (Bug#9172)
aac0c6e3 10812
7be1c708 108132011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 10814
7be1c708
CY
10815 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
10816 and LC_VERSION_MIN_MACOSX.
10817 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
10818 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 10819
97bb72a6
EZ
108202011-08-08 Eli Zaretskii <eliz@gnu.org>
10821
10822 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
10823 no-display-properties-and-no-overlays under bidi display.
10824 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 10825 properties and overlays.
97bb72a6 10826
d5617611
CY
108272011-08-08 Chong Yidong <cyd@stupidchicken.com>
10828
37e11a63
CY
10829 * editfns.c (Fset_time_zone_rule): Document relationship with the
10830 setenv function.
10831
d5617611
CY
10832 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
10833 the font entity extracted from the cache (Bug#8109).
10834
58872834
CY
108352011-08-07 Chong Yidong <cyd@stupidchicken.com>
10836
10837 * composite.c (autocmp_chars): Don't reset point. That is done by
10838 restore_point_unwind (Bug#5984).
10839
75bfc667
JL
108402011-08-07 Juri Linkov <juri@jurta.org>
10841
10842 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
10843 to show the arg `TIME' instead of `TIMEVAL'.
10844
d1410150
EZ
108452011-08-06 Eli Zaretskii <eliz@gnu.org>
10846
10847 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
10848 display property strides EOL and includes a newline, as in
10849 longlines-mode. (Bug#9254)
75b771e4
EZ
10850 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
10851 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
10852
10853 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10854 is non-zero, even if the data buffer is NULL. Fixes a crash in
10855 vertical-motion with longlines-mode. (Bug#9254)
10856
35928349
EZ
108572011-08-05 Eli Zaretskii <eliz@gnu.org>
10858
ec7cc85b
EZ
10859 * bidi.c <bidi_cache_total_alloc>: Now static.
10860 (bidi_initialize): Initialize bidi_cache_total_alloc.
10861
8b76d6f8 10862 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
10863 cache. (Bug#9221)
10864
10865 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10866 amount allocated this far in `bidi_cache_total_alloc'.
10867 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
10868 non-zero, only free the data buffer without restoring the cache
10869 contents. All callers changed.
10870
10871 * dispextern.h (bidi_unshelve_cache): Update prototype.
10872
10873 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
10874 (move_it_in_display_line, move_it_to)
10875 (move_it_vertically_backward, move_it_by_lines): Replace the call
10876 to xfree to an equivalent call to bidi_unshelve_cache.
10877 (move_it_in_display_line_to): Fix logic of returning
412b6358 10878 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 10879
e2e2423b
EZ
108802011-08-05 Eli Zaretskii <eliz@gnu.org>
10881
10882 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
10883 came from a string character with a `cursor' property. (Bug#9229)
10884
ae9e757a
JD
108852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10886
10887 * Makefile.in (LIB_PTHREAD): New variable.
10888 (LIBES): Add LIB_PTHREAD (Bug#9216).
10889
10890 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
10891 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
10892
213bd7f2
AS
108932011-08-04 Andreas Schwab <schwab@linux-m68k.org>
10894
6b02f655 10895 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 10896
99aaf75f
JD
108972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10898
10899 * xterm.c (x_find_topmost_parent): New function.
10900 (x_set_frame_alpha): Find topmost parent window with
10901 x_find_topmost_parent and set the property there also (bug#9181).
10902 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
10903
c74e9d86
PE
109042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
10905
10906 * callproc.c (Fcall_process): Avoid vfork clobbering
10907 the local vars buffer, coding_systems, current_dir.
10908
640c8776
SM
109092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
10910
10911 * keymap.c (Fmake_composed_keymap): Move to subr.el.
10912
f26d0e4c
PE
109132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
10914
8a10d76c
PE
10915 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
10916 so that it is not optimized away.
10917
f26d0e4c
PE
10918 * xdisp.c (compute_display_string_pos): Remove unused local.
10919
55439c61
EZ
109202011-08-02 Eli Zaretskii <eliz@gnu.org>
10921
10922 Fix slow cursor motion and scrolling in large buffers with
10923 selective display, like Org Mode buffers. (Bug#9218)
10924
10925 * dispextern.h (struct bidi_it): New member disp_prop_p.
10926
10927 * xdisp.c: Remove one-slot cache of display string positions.
10928 (compute_display_string_pos): Accept an additional argument
5e617bc2 10929 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
10930 for a display string or property. If found, set DISP_PROP_P
10931 non-zero.
10932
10933 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
10934 DISP_PROP_P, and pass it to compute_display_string_pos.
10935 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
10936 non-zero. All callers of bidi_fetch_char changed.
10937
fb33fa43
SM
109382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
10939
10940 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
10941
b099e063
DM
109422010-12-03 Don March <don@ohspite.net>
10943
10944 * keymap.c (Fdefine_key): Fix non-prefix key error message when
10945 last character M-[char] is translated to ESC [char] (bug#7541).
10946
5cc7f7af
KH
109472011-08-02 Kenichi Handa <handa@m17n.org>
10948
d0fffa3f 10949 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10950
10951 * chartab.c (uniprop_table): Make it non-static.
10952
525d5e6e
EZ
109532011-08-01 Eli Zaretskii <eliz@gnu.org>
10954
10955 * xdisp.c (forward_to_next_line_start): Accept additional argument
10956 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10957 on the newline.
10958 (reseat_at_next_visible_line_start): Use the bidi iterator state
10959 returned by forward_to_next_line_start to restore the state of
10960 it->bidi_it after backing up to previous newline. (Bug#9212)
10961
31011111
AS
109622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10963
10964 * regex.c (re_comp): Protoize.
10965 (re_exec): Fix return type.
10966 (regexec): Fix type of `ret'. (Bug#9203)
10967
476371c4
PE
109682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10969
e5d76069
PE
10970 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10971 This is needed if max-image-size is a floating-point number.
10972
9a79b20c
AS
109732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10974
10975 * print.c (print_object): Print empty symbol as ##.
10976
10977 * lread.c (read1): Read ## as empty symbol.
10978
d8c2fa78
AA
109792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10980
10981 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10982 setting frame foreground color (Bug#9175).
10983 (x_set_background_color): Likewise.
10984
ffe57a7a
AA
10985 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10986 contents (Bug#9176).
10987 (EmacsTooltip -init): Remove bezels and add shadows to
10988 tooltip windows.
10989
bf3492a5
AA
10990 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10991 or scroll bar (Bug#8470).
10992
d55e9c53
AA
10993 * nsfont.m (nsfont_open): Remove assignment to voffset and
10994 unnecessary vars hshink, expand, hd, full_height, min_height.
10995 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10996
10997 * nsterm.h (nsfont_info): Remove voffset field.
10998
d8c2fa78 109992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
11000
11001 Implement strike-through and overline on NextStep (Bug#8863).
11002
11003 * nsfont.m (nsfont_open): Use underline position provided by font,
11004 instead of hard-coded value of 2.
11005 (nsfont_draw): Call ns_draw_text_decoration instead.
11006
11007 * nsterm.h: Add declaration for ns_draw_text_decoration.
11008
11009 * nsterm.m (ns_draw_text_decoration): New function for drawing
11010 underline, overline, and strike-through.
11011 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
11012 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 11013 accommodate underlining, etc.
4843aac3 11014
4cc60b9b
EZ
110152011-07-28 Eli Zaretskii <eliz@gnu.org>
11016
bc7ece87
EZ
11017 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
11018 default.
4cc60b9b 11019
476371c4
PE
110202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11021
66606eea
PE
11022 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
11023 Without this fix, if a signal arrives just after memory fills up,
11024 'malloc' might be invoked reentrantly.
11025
476371c4
PE
11026 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
11027 In other words, assume that every image size is allowed, on non-X
11028 hosts. This assumption is probably wrong, but it lets Emacs compile.
11029
f3fcc40d
AS
110302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11031
11032 * regex.c (re_iswctype): Convert return values to boolean.
11033
350c992f
EZ
110342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
11035
11036 * xdisp.c (compute_display_string_pos): Don't use cached display
11037 string position if the buffer had its restriction changed.
11038 (Bug#9184)
11039
5266b4bb
PE
110402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11041
11042 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11043
2573a837 110442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 11045
41f55ccd 11046 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 11047
39e378da
PE
11048 * bidi.c: Integer size and overflow fixes.
11049 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
11050 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
11051 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11052 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
11053 (bidi_find_other_level_edge):
11054 Use ptrdiff_t instead of EMACS_INT where either will do.
11055 This works better on 32-bit hosts configured --with-wide-int.
11056 (bidi_cache_ensure_space): Check for size-calculation overflow.
11057 Use % rather than repeated addition, for better worst-case speed.
11058 Don't set bidi_cache_size until after xrealloc returns, because it
11059 might not return.
11060 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
11061 (bidi_cache_ensure_space): Also check that the bidi cache size
11062 does not exceed that of the largest Lisp string or buffer. See Eli
11063 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 11064
5e927815
PE
11065 * alloc.c (__malloc_size_t): Remove.
11066 All uses replaced by size_t. See Andreas Schwab's note
11067 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
11068
ca4aa935
PE
11069 * image.c: Improve checking for integer overflow.
11070 (check_image_size): Assume that f is nonnull, since
11071 it is always nonnull in practice. This is one less thing to
11072 worry about when checking for integer overflow later.
11073 (x_check_image_size): New function, which checks for integer
11074 overflow issues inside X.
11075 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
11076 This removes the need for a memory_full check.
11077 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
11078 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
11079 (xbm_read_bitmap_data): Change locals back to 'int', since
11080 their values must fit in 'int'.
11081 (xpm_load_image, png_load, tiff_load):
11082 Invoke x_create_x_image_and_pixmap earlier,
11083 to avoid much needless work if the image is too large.
11084 (tiff_load): Treat overly large images as if
11085 x_create_x_image_and_pixmap failed, not as malloc failures.
11086 (gs_load): Use x_check_image_size.
11087
5f8f9cc2
PE
11088 * gtkutil.c: Omit integer casts.
11089 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11090 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11091
5adf60bc
PE
11092 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11093
c8907a93
PE
11094 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11095 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11096 would wrongly return t on a 64-bit host.
11097
e3c25c68
PE
11098 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11099 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11100 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11101 and therefore cause GCC to emit a bogus diagnostic in some cases.
11102
3f791afe
PE
11103 * image.c: Integer signedness and overflow and related fixes.
11104 This is not an exhaustive set of fixes, but it's time to
11105 record what I've got.
11106 (lookup_pixel_color, check_image_size): Remove redundant decls.
11107 (check_image_size): Don't assume that arbitrary EMACS_INT values
11108 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11109 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11110 (tiff_load, imagemagick_load_image):
11111 Check for overflow in size calculations.
11112 (x_create_x_image_and_pixmap): Remove unnecessary test for
11113 xmalloc returning NULL; that can't happen.
11114 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11115 (xpm_color_bucket): Use better integer hashing function.
11116 (xpm_cache_color): Don't possibly over-allocate memory.
11117 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11118 (gif_memory_source):
11119 Use ptrdiff_t, not int or size_t, to record sizes.
11120 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11121 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11122 either works, as we prefer signed integers.
11123 (tiff_read_from_memory, tiff_write_from_memory):
11124 Return tsize_t, not size_t, since that's what the TIFF API wants.
11125 (tiff_read_from_memory): Don't fail simply because the read would
11126 go past EOF; instead, return a short read.
11127 (tiff_load): Omit no-longer-needed casts.
11128 (Fimagemagick_types): Don't assume size fits into 'int'.
11129
3cc5a532
PE
11130 Improve hashing quality when configured --with-wide-int.
11131 * fns.c (hash_string): New function, taken from sxhash_string.
11132 Do not discard information about ASCII character case; this
11133 discarding is no longer needed.
11134 (sxhash-string): Use it. Change sig to match it. Caller changed.
11135 * lisp.h: Declare it.
11136 * lread.c (hash_string): Remove, since we now use fns.c's version.
11137 The fns.c version returns a wider integer if --with-wide-int is
11138 specified, so this should help the quality of the hashing a bit.
11139
b312a492
PE
11140 * emacs.c: Integer overflow minor fix.
11141 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11142 Define only if GNU_LINUX.
11143 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11144
dfd153ae
PE
11145 * dispnew.c: Integer signedness and overflow fixes.
11146 Remove unnecessary forward decls, that were a maintenance hassle.
11147 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11148 All uses changed.
11149 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11150 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11151 (prepare_desired_row, line_draw_cost):
11152 Use int, not unsigned, where either works.
11153 (save_current_matrix, restore_current_matrix):
11154 Use ptrdiff_t, not size_t, where either works.
11155 (init_display): Check for overflow more accurately, and without
11156 relying on undefined behavior.
11157
a81d11a3
PE
11158 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11159 Remove, replacing with the new symbols in lisp.h. All uses changed.
11160 * fileio.c (make_temp_name):
11161 * filelock.c (lock_file_1, lock_file):
11162 * xdisp.c (message_dolog):
11163 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11164 Use pMd etc. instead.
11165 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11166 replacing the pWIDE etc. symbols removed from editfns.c.
11167
3300e6fd
PE
11168 * keyboard.h (num_input_events): Now uintmax_t.
11169 This is (very slightly) less likely to mess up due to wraparound.
11170 All uses changed.
11171
fd05c7e9
PE
11172 * buffer.c: Integer signedness fixes.
11173 (alloc_buffer_text, enlarge_buffer_text):
11174 Use ptrdiff_t rather than size_t when either will do, as we prefer
11175 signed integers.
11176
903fe15d
PE
11177 * alloc.c: Integer signedness and overflow fixes.
11178 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11179 (__malloc_size_t): Default to size_t, not to int.
11180 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11181 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11182 Prefer ptrdiff_t to size_t when either would do, as we prefer
11183 signed integers.
11184 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11185 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11186 Now const. Initialize with values that are in range even if char
11187 is signed.
11188 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11189 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11190 These functions do the right thing with sizes > 2**32.
11191 (check_depth): Now ptrdiff_t, not int.
11192 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11193 Adjust to new way of storing sizes. Check for size overflow bugs
11194 in rest of code.
11195 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11196 slightly wrong anyway, as it missed one instance of
11197 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11198 (refill_memory_reserve): Omit needless cast to size_t.
11199 (mark_object_loop_halt): Mark as externally visible.
11200
ac82cc6a
PE
11201 * xselect.c: Integer signedness and overflow fixes.
11202 (Fx_register_dnd_atom, x_handle_dnd_message):
11203 Use ptrdiff_t, not size_t, since we prefer signed.
11204 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11205 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11206 x_dnd_atoms_size and x_dnd_atoms_length.
11207
c2d1e36d
PE
11208 * doprnt.c: Prefer signed to unsigned when either works.
11209 * eval.c (verror):
11210 * doprnt.c (doprnt):
11211 * lisp.h (doprnt):
11212 * xdisp.c (vmessage):
11213 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11214 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11215 prefer signed arithmetic to avoid comparison confusion.
11216 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11217 but is a bit tricky.
11218
0e926e56
PE
11219 Assume freestanding C89 headers, string.h, stdlib.h.
11220 * data.c, doprnt.c, floatfns.c, print.c:
11221 Include float.h unconditionally.
11222 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11223 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11224 * regex.c: Likewise for stddef.h, string.h.
11225 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11226 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11227 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11228 (STDC_HEADERS): Remove obsolete defines.
11229 * sysdep.c: Include limits.h unconditionally.
11230
9cfdb3ec
PE
11231 Assume support for memcmp, memcpy, memmove, memset.
11232 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11233 * regex.c (memcmp, memcpy):
11234 Remove; we assume C89 now.
11235
11236 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11237 (__malloc_safe_bcopy): Remove; no longer needed.
11238
cf950e6b 11239 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11240 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11241 well either way, and we prefer signed to unsigned.
11242
dbf38e02
LMI
112432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11244
11245 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11246 closes the connection while we're reading (bug#9182).
11247
d6f0886c 112482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11249
d6f0886c
JD
11250 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11251 are specified (Bug#9168).
24e0f6b1 11252
2eb1f9e6
PE
112532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11254
11255 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11256 Found by GCC static checking and --with-wide-int on a 32-bit host.
11257
22381272 112582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11259
11260 * xdisp.c (compute_display_string_pos): Fix logic of caching
11261 previous display string position. Initialize cached_prev_pos to
11262 -1. Fixes slow-down at the beginning of a buffer.
11263
f25e39b4
EZ
112642011-07-24 Eli Zaretskii <eliz@gnu.org>
11265
11266 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11267 for attrs[LFACE_FONTSET_INDEX].
11268
04c4b52e
PE
112692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11270
11271 * xml.c (parse_region): Remove unused local
11272 that was recently introduced.
11273
c1734fbd
EZ
112742011-07-23 Eli Zaretskii <eliz@gnu.org>
11275
be18c5a5
EZ
11276 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11277 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11278
c1734fbd
EZ
11279 * xdisp.c (move_it_in_display_line_to): Record the best matching
11280 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11281 exit if none of the characters scanned was an exact match.
11282 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11283 when exact match is impossible due to invisible text, and the
11284 lines are truncated.
11285
a258d627
JD
112862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11287
11288 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11289 for OSX >= 10.7.
11290
b6d5a689
EZ
112912011-07-22 Eli Zaretskii <eliz@gnu.org>
11292
0f74f785
EZ
11293 Fix a significant slow-down of cursor motion with C-n, C-p,
11294 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11295 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11296 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11297 (next_element_from_buffer): Call compute_stop_pos_backwards to
11298 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11299 base_level_stop.
11300 (reseat): Don't look for prev_stop, as that could mean a very long
11301 run.
11302 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11303 <cached_disp_overlay_modiff>: Cache for last found display string
11304 position.
551918c1 11305 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11306 about the same buffer in the same area of character positions, and
11307 the buffer wasn't changed since the time the display string
11308 position was cached.
551918c1 11309
b2d0c91a
EZ
113102011-07-22 Eli Zaretskii <eliz@gnu.org>
11311
11312 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11313 is an integer, which is important for empty lines. (Bug#9149)
11314
043604ee
CY
113152011-07-22 Chong Yidong <cyd@stupidchicken.com>
11316
11317 * frame.c (Fmodify_frame_parameters): In tty case, update the
11318 default face if necessary (Bug#4238).
11319
da4adb04
CY
113202011-07-21 Chong Yidong <cyd@stupidchicken.com>
11321
11322 * editfns.c (Fstring_to_char): No need to explain what a character
11323 is in the docstring (Bug#6576).
11324
9abd0532
LMI
113252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11326
11327 * xml.c (parse_region): Make sure we always return a tree.
11328
36881d16
HK
113292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
11330
11331 * xml.c (parse_region): If a document contains only comments,
11332 return that, too.
11333
1e98674d
LMI
113342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11335
11336 * xml.c (make_dom): Return comments, too.
11337
590bd467
PE
113382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
11339
11340 Port to OpenBSD.
11341 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
11342 and the surrounding thread.
11343 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11344 rather than fgets, and retry after EINTR. Otherwise, 'emacs
11345 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
11346 timer goes off.
11347 * s/openbsd.h (BROKEN_SIGIO): Define.
11348 * unexelf.c (unexec) [__OpenBSD__]:
11349 Don't update the .mdebug section of the Alpha COFF symbol table.
11350
f41628b2
LMI
113512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11352
11353 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
11354 (bug#8460).
11355
b59b67c5
PE
113562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
11357
15e3a074
PE
11358 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
11359 This fixes some race conditions on the permissions of any newly
11360 created file.
11361
41bed37d
PE
11362 * alloc.c (valid_pointer_p): Use pipe, not open.
11363 This fixes some permissions issues when debugging.
11364
b59b67c5
PE
11365 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11366 If fchown fails to set both uid and gid, try to set just gid,
11367 as that is sometimes allowed. Adjust the file's mode to eliminate
11368 setuid or setgid bits that are inappropriate if fchown fails.
11369
925a6be7
SM
113702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
11371
11372 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11373 to compare Lisp_Objects.
11374 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
11375 global_gnutls_log_level, don't mistake it for a Lisp_Object.
11376 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
11377
52968808
AS
113782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
11379
0a6a104b
AS
11380 * lread.c (read_integer): Unread even EOF character.
11381 (read1): Likewise. Properly record start position of symbol.
11382
52968808
AS
11383 * lread.c (read1): Read `#:' as empty uninterned symbol if no
11384 symbol character follows.
11385
9e381cdd
PE
113862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
11387
11388 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
11389 This works around a problem with the previous change to Fcopy_file.
11390 Recent glibc declares fchown with __attribute__((warn_unused_result)),
11391 and without this change, GCC might complain about discarding
11392 fchown's return value.
11393
b5641435
JB
113942011-07-16 Juanma Barranquero <lekktu@gmail.com>
11395
11396 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
11397
a8031457
PE
113982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
11399
11400 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
11401
dd889327
LMI
114022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
11403
750c33f7
LMI
11404 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
11405 it's used from the C level.
11406
dd889327
LMI
11407 * process.c: Use the same condition for POLL_FOR_INPUT in both
11408 keyboard.c and process.c (bug#1858).
11409
87e86684
LM
114102011-07-09 Lawrence Mitchell <wence@gmx.li>
11411
11412 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
11413 (Fgnutls_boot): Use it.
11414
64348f40
AS
114152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
11416
11417 * doc.c (Fsubstitute_command_keys): Revert last change.
11418
1d698799
LMI
114192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
11420
f863868c
LMI
11421 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
11422 quotes the next character, and doesn't affect other longer
11423 sequences (bug#8935).
11424
1d698799
LMI
11425 * lread.c (syms_of_lread): Clarify that is isn't only
11426 `eval-buffer' and `eval-defun' that's affected by
11427 `lexical-binding' (bug#8460).
11428
aa4b6df6
EZ
114292011-07-15 Eli Zaretskii <eliz@gnu.org>
11430
11431 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 11432 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 11433
5d856da6
PE
114342011-07-14 Paul Eggert <eggert@cs.ucla.edu>
11435
ad6042bb
PE
11436 Fix minor problems found by static checking.
11437 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
11438 (elsz): Now a signed constant, not a size_t var. We prefer signed
11439 types to unsigned, to avoid integer comparison confusion. Without
11440 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
11441 "cannot optimize loop, the loop counter may overflow", a symptom
11442 of the confusion.
f00bbb22 11443 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
11444 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
11445
6468f31c
LMI
114462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11447
49080b10
LMI
11448 * search.c (Fre_search_backward): Mention `case-fold-search' in
11449 all the re_search_* functions (bug#8138).
11450
6468f31c
LMI
11451 * keyboard.c (Fopen_dribble_file): Document when the file is
11452 closed (bug#8056).
11453
c965adc5
EZ
114542011-07-14 Eli Zaretskii <eliz@gnu.org>
11455
df9733bf
EZ
11456 * bidi.c (bidi_dump_cached_states): Fix format of displaying
11457 bidi_cache_idx.
11458
0bb23927
EZ
11459 Support bidi reordering of display and overlay strings.
11460 * xdisp.c (compute_display_string_pos)
11461 (compute_display_string_end): Accept additional argument STRING.
11462 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
11463 (reseat_to_string): Initialize bidi_it->string.s and
11464 bidi_it->string.schars.
11465 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
11466 NULL (avoids a crash in bidi_paragraph_init).
11467 Initialize itb.string.lstring.
0bb23927
EZ
11468 (init_iterator): Call bidi_init_it only of a valid
11469 buffer position was specified. Initialize paragraph_embedding to
11470 L2R.
11471 (reseat_to_string): Initialize the bidi iterator.
11472 (display_string): If we need to ignore text properties of
11473 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
11474 original value of -1 will not work with bidi.)
11475 (compute_display_string_pos): First arg is now struct
11476 `text_pos *'; all callers changed. Support display properties on
11477 Lisp strings.
11478 (compute_display_string_end): Support display properties on Lisp
11479 strings.
11480 (init_iterator, reseat_1, reseat_to_string): Initialize the
11481 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
11482 when iterating on a string not from display properties).
640c8776
SM
11483 (compute_display_string_pos, compute_display_string_end):
11484 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
11485 arrow keys.
11486 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
11487 base_level_stop; instead, set base_level_stop to BEGV.
11488 Fixes crashes in vertical-motion.
0bb23927
EZ
11489 (next_element_from_buffer): Improve commentary for when
11490 the iterator is before prev_stop.
11491 (init_iterator): Initialize bidi_p from the default value of
11492 bidi-display-reordering, not from buffer-local value. Use the
11493 buffer-local value only if initializing for buffer iteration.
11494 (handle_invisible_prop): Support invisible properties on strings
11495 that are being bidi-reordered.
11496 (set_iterator_to_next): Support bidi reordering of C strings and
11497 Lisp strings.
11498 (next_element_from_string): Support bidi reordering of Lisp
11499 strings.
11500 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
11501 (display_string): Support display of R2L glyph rows.
11502 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
11503 (init_iterator): Don't initialize it->bidi_p for strings
11504 here.
11505 (reseat_to_string): Initialize it->bidi_p for strings here.
11506 (next_element_from_string, next_element_from_c_string)
11507 (next_element_from_buffer): Add xassert's for correspondence
11508 between IT's object being iterated and it->bidi_it.string
11509 structure.
11510 (face_before_or_after_it_pos): Support bidi iteration.
11511 (next_element_from_c_string): Handle the case of the first string
11512 character that is not the first one in the visual order.
11513 (get_visually_first_element): New function, refactored from common
11514 parts of next_element_from_buffer, next_element_from_string, and
11515 next_element_from_c_string.
11516 (tool_bar_lines_needed, redisplay_tool_bar)
11517 (display_menu_bar): Force left-to-right direction. Add a FIXME
11518 comment for making that be controlled by a user option.
11519 (push_it, pop_it): Save and restore the state of the
11520 bidi iterator. Save and restore the bidi_p flag.
11521 (pop_it): Iterate out of display property for string iteration as
11522 well.
11523 (iterate_out_of_display_property): Support iteration over strings.
11524 (handle_single_display_spec): Set up it->bidi_it for iteration
11525 over a display string, and call bidi_init_it.
11526 (handle_single_display_spec, next_overlay_string)
11527 (get_overlay_strings_1, push_display_prop): Set up the bidi
11528 iterator for displaying display or overlay strings.
11529 (forward_to_next_line_start): Don't use the shortcut if
11530 bidi-iterating.
11531 (back_to_previous_visible_line_start): If handle_display_prop
11532 pushed the iterator stack, restore the internal state of the bidi
11533 iterator by calling bidi_pop_it same number of times.
11534 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
11535 and we are bidi-iterating, don't decrement the iterator position;
11536 instead, set the first_elt flag in the bidi iterator, to produce
11537 the same effect.
11538 (reseat_1): Remove redundant setting of string_from_display_prop_p.
11539 (push_display_prop): xassert that we are iterating a buffer.
11540 (push_it, pop_it): Save and restore paragraph_embedding member.
11541 (handle_single_display_spec, next_overlay_string)
11542 (get_overlay_strings_1, reseat_1, reseat_to_string)
11543 (push_display_prop): Set up the `unibyte' member of bidi_it.string
11544 correctly. Don't assume unibyte strings are not bidi-reordered.
11545 (compute_display_string_pos)
11546 (compute_display_string_end): Fix handling the case of C string.
11547 (push_it, pop_it): Save and restore from_disp_prop_p.
11548 (handle_single_display_spec, push_display_prop): Set the
11549 from_disp_prop_p flag.
11550 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
11551 (pop_it): Call iterate_out_of_display_property only if we are
11552 popping after iteration over a string that came from a display
11553 property. Fix a typo in popping stretch info. Add an assertion
11554 for verifying that the iterator position is in sync with the bidi
11555 iterator.
11556 (handle_single_display_spec, get_overlay_strings_1)
11557 (push_display_prop): Fix initialization of paragraph direction for
11558 string when that of the parent object is not yet determined.
11559 (reseat_1): Call bidi_init_it to resync the bidi
11560 iterator with IT's position. (Bug#7616)
11561 (find_row_edges): If ROW->start.pos gives position
11562 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
11563 (handle_stop, back_to_previous_visible_line_start, reseat_1):
11564 Reset the from_disp_prop_p flag.
11565 (SAVE_IT, RESTORE_IT): New macros.
11566 (pos_visible_p, face_before_or_after_it_pos)
11567 (back_to_previous_visible_line_start)
11568 (move_it_in_display_line_to, move_it_in_display_line)
11569 (move_it_to, move_it_vertically_backward, move_it_by_lines)
11570 (try_scrolling, redisplay_window, display_line): Use them when
11571 saving a temporary copy of the iterator and restoring it back.
11572 (back_to_previous_visible_line_start, reseat_1)
11573 (init_iterator): Empty the bidi cache "stack".
11574 (move_it_in_display_line_to): If iterator ended up at
11575 EOL, but we never saw any buffer positions smaller than
11576 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
11577 motion in bidi-reordered lines.
11578 (move_it_in_display_line_to): Record prev_method and prev_pos
11579 immediately before the call to set_iterator_to_next. Fixes cursor
11580 motion in bidi-reordered lines with stretch glyphs and strings
11581 displayed in margins. (Bug#8133) (Bug#8867)
11582 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
11583 TO_CHARPOS.
640c8776
SM
11584 (pos_visible_p): Support positions in bidi-reordered lines.
11585 Save and restore bidi cache.
0bb23927
EZ
11586
11587 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
11588 (bidi_paragraph_info): Delete unused struct.
11589 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
11590 (bidi_cache_start): New variable.
11591 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
11592 to zero.
11593 (bidi_cache_fetch_state, bidi_cache_search)
11594 (bidi_cache_find_level_change, bidi_cache_iterator_state)
11595 (bidi_cache_find, bidi_peek_at_next_level)
11596 (bidi_level_of_next_char, bidi_find_other_level_edge)
11597 (bidi_move_to_visually_next): Compare cache index with
11598 bidi_cache_start rather than with zero.
11599 (bidi_fetch_char): Accept new argument STRING; all callers
11600 changed. Support iteration over a string. Support strings with
11601 display properties. Support unibyte strings. Fix the type of
11602 `len' according to what STRING_CHAR_AND_LENGTH expects.
11603 (bidi_paragraph_init, bidi_resolve_explicit_1)
11604 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
11605 (bidi_level_of_next_char, bidi_move_to_visually_next):
11606 Support iteration over a string.
0bb23927
EZ
11607 (bidi_set_sor_type, bidi_resolve_explicit_1)
11608 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
11609 can now be zero (for strings); special values 0 and -1 were
11610 changed to -1 and -2, respectively.
11611 (bidi_char_at_pos): New function.
11612 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
11613 Call it instead of FETCH_MULTIBYTE_CHAR.
11614 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
11615 initialized to valid values.
11616 (bidi_init_it): Don't initialize charpos and bytepos with invalid
11617 values.
11618 (bidi_level_of_next_char): Allow the sentinel "position" to pass
11619 the test for valid cached positions. Fix the logic for looking up
11620 the sentinel state in the cache. GCPRO the Lisp string we are
11621 iterating.
11622 (bidi_push_it, bidi_pop_it): New functions.
11623 (bidi_initialize): Initialize the bidi cache start stack pointer.
11624 (bidi_cache_ensure_space): New function, refactored from part of
11625 bidi_cache_iterator_state. Don't assume the required size is just
11626 one BIDI_CACHE_CHUNK away.
11627 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
11628 (bidi_count_bytes, bidi_char_at_pos): New functions.
11629 (bidi_cache_search): Don't assume bidi_cache_last_idx is
11630 always valid if bidi_cache_idx is valid.
11631 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
11632 is valid if it's going to be used.
11633 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
11634 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
11635 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11636 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
11637 (bidi_find_other_level_edge, bidi_cache_start_stack):
11638 All variables related to cache indices are now EMACS_INT.
c965adc5 11639
0bb23927
EZ
11640 * dispextern.h (struct bidi_string_data): New structure.
11641 (struct bidi_it): New member `string'. Make flag members be 1-bit
11642 fields, and put them last in the struct.
640c8776
SM
11643 (compute_display_string_pos, compute_display_string_end):
11644 Update prototypes.
0bb23927
EZ
11645 (bidi_push_it, bidi_pop_it): Add prototypes.
11646 (struct iterator_stack_entry): New members bidi_p,
11647 paragraph_embedding, and from_disp_prop_p.
11648 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
11649 (bidi_shelve_cache, bidi_unshelve_cache):
11650 Declare prototypes.
0bb23927
EZ
11651
11652 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
11653 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
11654 and vector-like objects.
11655
11656 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
11657 cache around display iteration.
11658
11659 * window.c (Fwindow_end, window_scroll_pixel_based)
11660 (displayed_window_lines, Frecenter): Save and restore the bidi
11661 cache around display iteration.
11662
3bbd2265
LMI
116632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11664
11665 * editfns.c (Fdelete_region): Clarify the use of the named
11666 parameters (bug#6788).
11667
adc47434
MR
116682011-07-14 Martin Rudalics <rudalics@gmx.at>
11669
11670 * indent.c (Fvertical_motion): Set and restore w->pointm when
11671 saving and restoring the window's buffer (Bug#9006).
11672
837c31f8
LMI
116732011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
11674
11675 * editfns.c (Fstring_to_char): Clarify just what is returned
11676 (bug#6576). Text by Eli Zaretskii.
11677
ac389d0c
JB
116782011-07-13 Juanma Barranquero <lekktu@gmail.com>
11679
11680 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
11681
0be0ce47
EZ
116822011-07-13 Eli Zaretskii <eliz@gnu.org>
11683
11684 * buffer.c (mmap_find): Fix a typo.
11685
cd18e7e3
JB
116862011-07-13 Johan Bockgård <bojohan@gnu.org>
11687
11688 Fix execution of x selection hooks.
11689 * xselect.c (Qx_lost_selection_functions)
11690 (Qx_sent_selection_functions): New vars.
11691 (syms_of_xselect): DEFSYM them.
11692 (x_handle_selection_request): Pass Qx_sent_selection_functions
11693 rather than Vx_sent_selection_functions to Frun_hook_with_args.
11694 (x_handle_selection_clear,x_clear_frame_selections):
11695 Pass Qx_lost_selection_functions rather than
11696 Vx_lost_selection_functions to Frun_hook_with_args.
11697
47ea7f44
PE
116982011-07-13 Paul Eggert <eggert@cs.ucla.edu>
11699
ac389d0c 11700 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
11701 The old code sometimes used this field without initializing it.
11702
47ea7f44
PE
11703 * alloc.c (gc_sweep): Don't read past end of array.
11704 In theory, the old code could also have corrupted Emacs internals,
11705 though it'd be very unlikely.
11706
bc985c87
AS
117072011-07-12 Andreas Schwab <schwab@linux-m68k.org>
11708
11709 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 11710 argument. (Bug#4026)
bc985c87 11711
0cf34688
LMI
117122011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
11713
b3dadd76
LMI
11714 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
11715 key" (bug#4257).
11716
0cf34688
LMI
11717 * window.c (Fset_window_start): Doc fix (bug#4199).
11718 (Fset_window_hscroll): Ditto.
11719
270768cd
PE
117202011-07-12 Paul Eggert <eggert@cs.ucla.edu>
11721
077e3dda 11722 Fix minor new problems caught by GCC 4.6.1.
270768cd 11723 * term.c (init_tty): Remove unused local.
490011a6 11724 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 11725 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 11726 not used otherwise.
270768cd 11727
b1f58454
CY
117282011-07-12 Chong Yidong <cyd@stupidchicken.com>
11729
11730 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
11731
22b9578d
LMI
117322011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11733
6e70ab07
LMI
11734 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
11735 are the mini-buffer and the echo area (bug#3320).
11736
22b9578d
LMI
11737 * term.c (init_tty): Remove support for supdup, c10 and perq
11738 terminals, which are no longer supported (bug#1482).
11739
8974cc9f
JB
117402011-07-10 Johan Bockgård <bojohan@gnu.org>
11741
11742 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
11743
a560d974
JD
117442011-07-10 Jan Djärv <jan.h.d@swipnet.se>
11745
11746 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
11747 for non-popups (Bug#3642).
11748
1dae0f0a
AS
117492011-07-10 Andreas Schwab <schwab@linux-m68k.org>
11750
268c2c36 11751 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 11752 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
11753 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
11754 * cm.c (losecursor): Likewise.
1dae0f0a
AS
11755 * data.c (fmod): Likewise.
11756 * dispnew.c (swap_glyphs_in_rows): Likewise.
11757 * emacs.c (memory_warning_signal): Likewise.
11758 * floatfns.c (float_error): Likewise.
11759 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
11760 (otf_open, font_otf_capability, generate_otf_features)
11761 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
11762 Likewise.
11763 * image.c (pbm_read_file): Likewise.
11764 * indent.c (string_display_width): Likewise.
11765 * intervals.c (check_for_interval, search_for_interval)
11766 (inc_interval_count, count_intervals, root_interval)
11767 (adjust_intervals_for_insertion, make_new_interval): Likewise.
11768 * lread.c (defalias): Likewise.
268c2c36 11769 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
11770 * regex.c (set_image_of_range_1, set_image_of_range)
11771 (regex_grow_registers): Likewise.
11772 * sysdep.c (strerror): Likewise.
11773 * termcap.c (valid_filename_p, tprint, main): Likewise.
11774 * tparam.c (main): Likewise.
11775 * unexhp9k800.c (run_time_remap, save_data_space)
11776 (update_file_ptrs, read_header, write_header, calculate_checksum)
11777 (copy_file, copy_rest, display_header): Likewise.
11778 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
11779 Likewise.
11780 * xdisp.c (check_it): Likewise.
11781 * xfaces.c (register_color, unregister_color, unregister_colors):
11782 Likewise.
11783 * xfns.c (print_fontset_result): Likewise.
11784 * xrdb.c (member, fatal, main): Likewise.
11785
99033785
PE
117862011-07-10 Paul Eggert <eggert@cs.ucla.edu>
11787
11788 Fix minor problems found by static checking (Bug#9031).
11789 * chartab.c (char_table_set_range, map_sub_char_table):
11790 Remove unused locals.
11791 (uniprop_table): Now static.
11792 * composite.c (_work_char): Remove unused static var.
11793
9cb2ac56
JB
117942011-07-09 Juanma Barranquero <lekktu@gmail.com>
11795
11796 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
11797
f25661f0
JD
117982011-07-09 Jan Djärv <jan.h.d@swipnet.se>
11799
11800 * gtkutil.c (qttip_cb): Remove code without function.
11801
8278c4fe
EZ
118022011-07-09 Eli Zaretskii <eliz@gnu.org>
11803
11804 * w32.c (pthread_sigmask): New stub.
11805
1692ae2d 118062011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 11807
8a6ebd58 11808 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11809 sigprocmask is portable only for single-threaded applications, and
11810 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
11811 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
11812 (LIBES): Use it.
11813 * callproc.c (Fcall_process):
11814 * process.c (create_process):
11815 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11816 Use pthread_sigmask, not sigprocmask.
123403e4 11817
1b854618
JD
118182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11819
11820 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
11821 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
11822 wrong (Bug#8591).
11823
3fe4b549
JD
118242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11825
0ce7e563
JD
11826 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
11827 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11828 (xg_hide_tooltip): Fix comment.
11829
3fe4b549
JD
11830 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
11831 in registerServicesMenuSendTypes.
11832 (validRequestorForSendType): Don't check ns_return_types.
11833
11834 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
11835 ns_return_type.
11836
5df75e47
JR
118372011-07-08 Jason Rumney <jasonr@gnu.org>
11838
22610910
JR
11839 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
11840 SH_SHOW for hidden windows (Bug#5482).
11841
5df75e47
JR
11842 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
11843 frame struct members of non-existent frames (Bug#6284).
11844
699c10bd
JD
118452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11846
4393663b
JD
11847 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
11848 variable firstTime not needed on OSX >= 10.6.
11849 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
11850 >= 10.5. Use setKnobProportion, setDoubleValue.
11851
11852 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
11853 (MAC_OS_X_VERSION_10_5): Define if not defined.
11854 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
11855 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
11856 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
11857
11858 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 11859 cString and lossyCString on OSX >= 10.4.
4393663b 11860
58179cce 11861 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
11862 sizeToFit on OSX >= 10.2.
11863
11864 * nsimage.m (allocInitFromFile): Don't use deprecated method
11865 bestRepresentationForDevice on OSX >= 10.6.
11866
11867 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
11868 to avoid warning.
11869
11870 * emacs.c: Declare unexec_init_emacs_zone.
11871
a63e0781
JD
11872 * nsgui.h: Fix compiler warning about gnulib redefining verify.
11873
699c10bd
JD
11874 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
11875
11876 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
11877 on svcsMenu (Bug#8842).
11878
11879 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
11880 ns_return_types.
11881 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11882
11883 * nsterm.m (QUTF8_STRING): Declare.
11884 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
11885 (validRequestorForSendType): Return type is (id).
11886 Change indexOfObjectIdenticalTo to indexOfObject.
11887 Check if we have local selection before returning self (Bug#8842).
11888 (writeSelectionToPasteboard): Put local selection into paste board
11889 if we have a local selection (Bug#8842).
11890 (syms_of_nsterm): DEFSYM QUTF8_STRING.
11891
11892 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
11893 (ns_get_local_selection): Declare.
11894
54e10184
LMI
118952011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
11896
9888ff71
LMI
11897 * keymap.c (describe_map_tree): Don't insert a double newline at
11898 the end of the buffer (bug#1169) and return whether we inserted
11899 something.
11900
54e10184
LMI
11901 * callint.c (Fcall_interactively): Change "reading args" to
11902 "providing args" to try to clarify what it does (bug#1010).
11903
15fa4783
KH
119042011-07-07 Kenichi Handa <handa@m17n.org>
11905
11906 * composite.c (composition_compute_stop_pos): Ignore a static
11907 composition starting before CHARPOS (Bug#8915).
11908
11909 * xdisp.c (handle_composition_prop): Likewise.
11910
a8815b00
EZ
119112011-07-07 Eli Zaretskii <eliz@gnu.org>
11912
11913 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11914 (Bug#9015)
11915
ef7b981d 119162011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
11917
11918 * character.h (unicode_category_t): New enum type.
11919
11920 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
11921 (Qchar_code_property_table): New variable.
11922 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
11923 (UNIPROP_COMPRESSED_FORM_P): New macros.
11924 (char_table_ascii): Uncompress the compressed values.
11925 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11926 Uncompress the compressed values.
ac389d0c 11927 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
11928 (char_table_ref_and_range): Uncompress the compressed values.
11929 (sub_char_table_set): New arg is_uniprop. Callers changed.
11930 Uncompress the compressed values.
11931 (sub_char_table_set_range): Args changed. Callers changed.
11932 (char_table_set_range): Adjuted for the above change.
11933 (map_sub_char_table): Delete args default_val and parent. Add arg
11934 top. Give decoded values to a Lisp function.
640c8776 11935 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
11936 values to a Lisp function. Gcpro more variables.
11937 (uniprop_table_uncompress)
11938 (uniprop_decode_value_run_length): New functions.
11939 (uniprop_decoder, uniprop_decoder_count): New variables.
11940 (uniprop_get_decoder, uniprop_encode_value_character)
11941 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
11942 New functions.
11943 (uniprop_encoder, uniprop_encoder_count): New variables.
11944 (uniprop_get_encoder, uniprop_table)
11945 (Funicode_property_table_internal, Fget_unicode_property_internal)
11946 (Fput_unicode_property_internal): New functions.
11947 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11948 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11949 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11950 char-code-property-alist.
11951
640c8776 11952 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11953 Vunicode_category_table.
11954
640c8776 11955 * font.c (font_range): Adjust for the change of
c805dec0
KH
11956 Vunicode_category_table.
11957
76b397fb
DN
119582011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11959
11960 * m/iris4d.h: Remove file, move contents ...
11961 * s/irix6-5.h: ... here.
11962
22b4128e
PE
119632011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11964
11965 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11966 * alloc.c (mark_buffer):
11967 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11968 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11969 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11970 This isn't true in general, and it's particularly not true
11971 if Emacs is configured with --with-wide-int.
11972 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11973 New macros, used in the buffer.c change.
11974
869795d6
JD
119752011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11976
11977 * xsettings.c: Use both GConf and GSettings if both are available.
11978 (store_config_changed_event): Add comment.
11979 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11980 (store_tool_bar_style_changed): New functions.
5e617bc2 11981 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11982 (struct xsettings): Move font inside HAVE_XFT.
11983 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11984 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11985 Move inside HAVE_XFT.
640c8776 11986 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11987 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11988 also.
11989 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11990 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11991 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11992 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11993 (parse_settings): Move check for font inside HAVE_XFT.
11994 (read_settings, apply_xft_settings): Add comment.
11995 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11996 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11997 call store_font_name_changed.
11998 (xft_settings_event): Add comment.
11999 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
12000 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
12001 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
12002 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
12003 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
12004 (xsettings_get_system_font, xsettings_get_system_normal_font):
12005 Add comment.
869795d6 12006
d8ed26bd
PE
120072011-07-05 Paul Eggert <eggert@cs.ucla.edu>
12008
12009 Random fixes. E.g., (random) never returned negative values.
12010 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
12011 subseconds part to the entropy, as that's a bit more random.
12012 Prefer signed to unsigned, since the signedness doesn't matter and
12013 in general we prefer signed. When given a limit, use a
12014 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
12015 latter isn't right if USE_2_TAGS_FOR_INTS.
12016 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
12017 not 0..VALMASK. Don't discard "excess" bits that random () returns.
12018
cabf1cac
SM
120192011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
12020
12021 * textprop.c (text_property_stickiness):
12022 Obey Vtext_property_default_nonsticky.
12023 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
12024 * w32fns.c (syms_of_w32fns):
12025 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
12026
6e9b2be9
PE
120272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12028
12029 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
12030 This is more efficient than Ffile_directory_p and avoids a minor race.
12031
90186c68
LMI
120322011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
12033
7c301272
LMI
12034 * buffer.c (Foverlay_put): Say what the return value is
12035 (bug#7835).
12036
c4f2d8d4
LMI
12037 * fileio.c (barf_or_query_if_file_exists): Check first if the file
12038 is a directory before asking whether to use the file name
12039 (bug#7564).
ad637907
LMI
12040 (barf_or_query_if_file_exists): Make the "File is a directory"
12041 error be more correct.
c4f2d8d4 12042
90186c68
LMI
12043 * fns.c (Frequire): Remove the mention of the .gz files, since
12044 that's installation-specific, but keep the mention of
12045 `get-load-suffixes'.
12046
da64016e
PE
120472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12048
12049 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
12050 Report string overflow if the output is too long.
12051
7d47b580
JB
120522011-07-04 Juanma Barranquero <lekktu@gmail.com>
12053
a555cb87
JB
12054 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
12055 (syms_of_gnutls): Remove duplicate DEFSYM for
12056 Qgnutls_bootprop_verify_hostname_error, an error for
12057 Qgnutls_bootprop_verify_error (which is no longer used).
12058
7d47b580
JB
12059 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
12060 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
12061 Also (re)move comments that are misplaced or no longer relevant.
12062
1e49bfab
LMI
120632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12064
12065 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
12066
1485f4c0
CY
120672011-07-03 Chong Yidong <cyd@stupidchicken.com>
12068
12069 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
12070 and background color parameters if they have been changed.
12071
a9ab721e
LMI
120722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12073
12074 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
12075
cf7cff57
PE
120762011-07-03 Paul Eggert <eggert@cs.ucla.edu>
12077
2e13213d
PE
12078 * xsettings.c (SYSTEM_FONT): Define only when used.
12079 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
12080
cf7cff57
PE
12081 * keymap.c (access_keymap_1): Now static.
12082
7a8e04f7
CY
120832011-07-02 Chong Yidong <cyd@stupidchicken.com>
12084
12085 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12086 leave any prefix arg for the up event (Bug#1586).
12087
61352f62
LMI
120882011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12089
69bb1ef7
LMI
12090 * lread.c (syms_of_lread): Mention single symbols defined by
12091 `defvar' or `defconst' (bug#7154).
12092
61352f62 12093 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12094 (Frequire): Mention get-load-suffixes.
61352f62 12095
28545e04
MR
120962011-07-02 Martin Rudalics <rudalics@gmx.at>
12097
12098 * window.h (window): Remove clone_number slot.
12099 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12100 Remove.
12101 (make_parent_window, make_window, saved_window)
12102 (Fset_window_configuration, save_window_save): Don't deal with
12103 clone numbers.
12104 * buffer.c (Qclone_number): Remove declaration.
12105 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12106
3349e122
SM
121072011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12108
12109 Add multiple inheritance to keymaps.
12110 * keymap.c (Fmake_composed_keymap): New function.
12111 (Fset_keymap_parent): Simplify.
12112 (fix_submap_inheritance): Remove.
12113 (access_keymap_1): New function extracted from access_keymap to handle
12114 embedded parents and handle lists of maps.
12115 (access_keymap): Use it.
12116 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12117 (Fcopy_keymap): Handle embedded parents.
12118 (Fcommand_remapping, define_as_prefix): Simplify.
12119 (Fkey_binding): Simplify.
12120 (syms_of_keymap): Move minibuffer-local-completion-map,
12121 minibuffer-local-filename-completion-map,
12122 minibuffer-local-must-match-map, and
12123 minibuffer-local-filename-must-match-map to Elisp.
12124 (syms_of_keymap): Defsubr make-composed-keymap.
12125 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12126 (parse_menu_item): Trivial simplification.
12127
3279eb87
GM
121282011-07-01 Glenn Morris <rgm@gnu.org>
12129
12130 * Makefile.in (SETTINGS_LIBS): Fix typo.
12131
39cb9e56 121322011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12133
12134 * coding.c (Fencode_coding_string): Record the last coding system
12135 used, as the function doc string says (bug#8738).
12136
0949d2b6
JD
121372011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12138
12139 * xsettings.c (store_monospaced_changed): Take new font as arg and
12140 check for change against current_mono_font.
12141 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12142 (emacs_settings_constructor, emacs_settings_get_property)
12143 (emacs_settings_set_property, emacs_settings_class_init)
12144 (emacs_settings_init, gsettings_obj): Remove.
12145 (something_changedCB): New function for HAVE_GSETTINGS.
12146 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12147 with value as argument.
12148 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12149 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12150 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12151 "changed".
12152
12153 * xgselect.c: Add defined (HAVE_GSETTINGS).
12154 (xgselect_initialize): Ditto.
12155
12156 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12157 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12158 xg_select.
12159
bbc6b304
PE
121602011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12161
12162 * eval.c (struct backtrace): Simplify and port the data structure.
12163 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12164 signed bit field, as this assumption is not portable and it makes
12165 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12166 "char debug_on_exit : 1" as this is not portable either; instead,
12167 use the portable "unsigned int debug_on_exit : 1". Remove unused
12168 member evalargs. Remove obsolete comments about cc bombing out.
12169
9851bfc5
JD
121702011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12171
51bb811f 12172 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12173 Let HAVE_GSETTINGS override HAVE_GCONF.
12174 (store_monospaced_changed): New function.
12175 (EMACS_SETTINGS): A new type derived from GObject to handle
12176 GSettings notifications.
12177 (emacs_settings_constructor, emacs_settings_get_property)
12178 (emacs_settings_set_property, emacs_settings_class_init):
12179 New functions.
12180 (gsettings_client, gsettings_obj): New variables.
12181 (GSETTINGS_SCHEMA): New define.
12182 (something_changedCB): Call store_monospaced_changed.
12183 (init_gsettings): New function.
12184 (xsettings_initialize): Call init_gsettings.
12185 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12186 to NULL.
12187
640c8776 12188 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12189 GCONF_CFLAGS/LIBS.
12190
5386012d
MR
121912011-06-29 Martin Rudalics <rudalics@gmx.at>
12192
12193 * window.c (resize_root_window, grow_mini_window)
12194 (shrink_mini_window): Rename Qresize_root_window to
12195 Qwindow_resize_root_window and Qresize_root_window_vertically to
12196 Qwindow_resize_root_window_vertically.
12197
f13e0b08
PE
121982011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12199
12200 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12201
94515237
JB
122022011-06-27 Juanma Barranquero <lekktu@gmail.com>
12203
12204 * makefile.w32-in: Redesign dependencies so they reflect more
12205 clearly which files are directly included by each source file,
12206 and not through other includes.
12207
e43b6e43
MR
122082011-06-27 Martin Rudalics <rudalics@gmx.at>
12209
12210 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12211 (sort_overlays, overlay_strings): When an overlay's clone number
12212 matches the window's clone number process the overlay even if
12213 the overlay's window property doesn't match the current window.
12214
d68443dc
MR
12215 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12216 (Fwindow_hchild): Rename to Fwindow_left_child.
12217 (Fwindow_next): Rename to Fwindow_next_sibling.
12218 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12219 (resize_window_check): Rename to window_resize_check.
12220 (resize_window_apply): Rename to window_resize_apply.
12221 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12222 (Fdelete_other_windows_internal, resize_frame_windows)
12223 (Fsplit_window_internal, Fdelete_window_internal)
12224 (grow_mini_window, shrink_mini_window)
12225 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12226
c7e73be5
JD
122272011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12228
12229 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12230 (emacs_fixed_set_min_size): Remove.
12231 (emacs_fixed_new): Take frame as argument.
12232
12233 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12234 (_EmacsFixedPrivate): Remove minwidth/height.
12235 Add struct frame *f.
12236 (emacs_fixed_init): Initialize priv->f.
12237 (get_parent_class, emacs_fixed_set_min_size): Remove.
12238 (emacs_fixed_new): Set priv->f to argument.
12239 (emacs_fixed_get_preferred_width)
12240 (emacs_fixed_get_preferred_height): Use min_width/height from
12241 frames size_hint to set minimum and natural (Bug#8919).
12242 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12243 and use min_width/height from frames size_hint to set
12244 min_width/height (Bug#8919).
12245
12246 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12247 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12248 Fix indentation.
c7e73be5 12249
cf99dcf8
EZ
122502011-06-26 Eli Zaretskii <eliz@gnu.org>
12251
12252 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12253 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12254 called at ZV.
12255
029529ac
CY
122562011-06-26 Chong Yidong <cyd@stupidchicken.com>
12257
12258 * process.c (wait_reading_process_output): Bypass select if
12259 waiting for a cell while ignoring keyboard input, and input is
12260 pending. Suggested by Jan Djärv (Bug#8869).
12261
7a7ef429
PE
122622011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12263
12264 Use gnulib's dup2 module instead of rolling our own.
12265 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12266
11fdef7d 122672011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12268
12269 * dispnew.c (scrolling_window): Before scrolling, turn off a
12270 mouse-highlight in the window being scrolled.
12271
cd3520a4
JB
122722011-06-24 Juanma Barranquero <lekktu@gmail.com>
12273
12274 Move DEFSYM to lisp.h and use everywhere.
12275
12276 * character.h (DEFSYM): Move declaration...
12277 * lisp.h (DEFSYM): ...here.
12278
12279 * gnutls.c:
12280 * minibuf.c:
12281 * w32menu.c:
12282 * w32proc.c:
12283 * w32select.c: Don't include character.h.
12284
12285 * alloc.c (syms_of_alloc):
12286 * buffer.c (syms_of_buffer):
12287 * bytecode.c (syms_of_bytecode):
12288 * callint.c (syms_of_callint):
12289 * casefiddle.c (syms_of_casefiddle):
12290 * casetab.c (init_casetab_once):
12291 * category.c (init_category_once, syms_of_category):
12292 * ccl.c (syms_of_ccl):
12293 * cmds.c (syms_of_cmds):
12294 * composite.c (syms_of_composite):
12295 * dbusbind.c (syms_of_dbusbind):
12296 * dired.c (syms_of_dired):
12297 * dispnew.c (syms_of_display):
12298 * doc.c (syms_of_doc):
12299 * editfns.c (syms_of_editfns):
12300 * emacs.c (syms_of_emacs):
12301 * eval.c (syms_of_eval):
12302 * fileio.c (syms_of_fileio):
12303 * fns.c (syms_of_fns):
12304 * frame.c (syms_of_frame):
12305 * fringe.c (syms_of_fringe):
12306 * insdel.c (syms_of_insdel):
12307 * keymap.c (syms_of_keymap):
12308 * lread.c (init_obarray, syms_of_lread):
12309 * macros.c (syms_of_macros):
12310 * msdos.c (syms_of_msdos):
12311 * print.c (syms_of_print):
12312 * process.c (syms_of_process):
12313 * search.c (syms_of_search):
12314 * sound.c (syms_of_sound):
12315 * syntax.c (init_syntax_once, syms_of_syntax):
12316 * terminal.c (syms_of_terminal):
12317 * textprop.c (syms_of_textprop):
12318 * undo.c (syms_of_undo):
12319 * w32.c (globals_of_w32):
12320 * window.c (syms_of_window):
12321 * xdisp.c (syms_of_xdisp):
12322 * xfaces.c (syms_of_xfaces):
12323 * xfns.c (syms_of_xfns):
12324 * xmenu.c (syms_of_xmenu):
12325 * xsettings.c (syms_of_xsettings):
12326 * xterm.c (syms_of_xterm): Use DEFSYM.
12327
4228cf16
TZ
123282011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
12329
cd3520a4 12330 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 12331
7fcccf1e
PE
123322011-06-23 Paul Eggert <eggert@cs.ucla.edu>
12333
7efb4e0e
PE
12334 Integer and buffer overflow fixes (Bug#8873).
12335
ff5844ad
PE
12336 * print.c (printchar, strout): Check for string overflow.
12337 (PRINTPREPARE, printchar, strout):
12338 Don't set size unless allocation succeeds.
12339
90532f02
PE
12340 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
12341 for sizes. Check for string overflow more accurately.
12342 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12343
6d84508d
PE
12344 * macros.c: Integer and buffer overflow fixes.
12345 * keyboard.h (struct keyboard.kbd_macro_bufsize):
12346 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
12347 Use ptrdiff_t, not int, for sizes.
12348 Don't increment bufsize until after realloc succeeds.
12349 Check for size-calculation overflow.
12350 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
12351
437b2cb4
PE
12352 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12353
8b9ac8b4
PE
12354 * lread.c: Integer overflow fixes.
12355 (read_integer): Radix is now EMACS_INT, not int,
12356 to improve quality of diagnostics for out-of-range radices.
12357 Calculate buffer size correctly for out-of-range radices.
12358 (read1): Check for integer overflow in radices, and in
12359 read-circle numbers.
82cb60d3
PE
12360 (read_escape): Avoid int overflow.
12361 (Fload, openp, read_buffer_size, read1)
12362 (substitute_object_recurse, read_vector, read_list, map_obarray):
12363 Use ptrdiff_t, not int, for sizes.
12364 (read1): Use EMACS_INT, not int, for sizes.
20270765 12365 Check for size overflow.
8b9ac8b4 12366
7fcccf1e
PE
12367 * image.c (cache_image): Check for size arithmetic overflow.
12368
bfbbd7e7
PE
12369 * lread.c: Integer overflow issues.
12370 (saved_doc_string_size, saved_doc_string_length)
12371 (prev_saved_doc_string_size, prev_saved_doc_string_length):
12372 Now ptrdiff_t, not int.
12373 (read1): Don't assume doc string length fits in int. Check for
12374 out-of-range doc string lengths.
12375 (read_list): Don't assume file position fits in int.
39019e54 12376 (read_escape): Check for hex character overflow.
bfbbd7e7 12377
4e323265
LL
123782011-06-22 Leo Liu <sdl.web@gmail.com>
12379
12380 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
12381 Move to minibuffer.el.
12382
85fece3e
PE
123832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12384
20b84ce9 12385 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
12386 The following patches are for when GLYPH_DEBUG && !XASSERT.
12387 * dispextern.h (trace_redisplay_p, dump_glyph_string):
12388 * dispnew.c (flush_stdout):
12389 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
12390 Mark as externally visible.
12391 * dispnew.c (check_window_matrix_pointers): Now static.
12392 * dispnew.c (window_to_frame_vpos):
12393 * xfns.c (unwind_create_frame):
12394 * xterm.c (x_check_font): Remove unused local.
12395 * scroll.c (CHECK_BOUNDS):
12396 * xfaces.c (cache_fache): Rename local to avoid shadowing.
12397 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
12398 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
12399 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
12400 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
12401 Now static.
12402 (debug_method_add): Use va_list and vsprintf rather than relying
12403 on undefined behavior with wrong number of arguments.
12404 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
12405 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
12406 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
12407 since we're not interested in debugging glyphs with old libraries.
12408 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
12409 GCC 4.6.0's static checking.
12410
0766b489
PE
124112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12412
31fd4b32
PE
12413 Integer overflow and signedness fixes (Bug#8873).
12414 A few related buffer overrun fixes, too.
12415
b79e8648
PE
12416 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
12417
0766b489
PE
12418 * dispextern.h (struct face.stipple):
12419 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
12420 (x_bitmap_mask, x_allocate_bitmap_record)
12421 (x_create_bitmap_from_data, x_create_bitmap_from_file)
12422 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
12423 (x_create_bitmap_from_xpm_data):
12424 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
12425 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
12426 (.bitmaps_last):
12427 * xfaces.c (load_pixmap):
12428 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
12429 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
12430 (.bitmaps_last, struct x_output.icon_bitmap):
12431 Use ptrdiff_t, not int, for bitmap indexes.
12432 (x_allocate_bitmap_record): Check for size overflow.
12433 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
12434
b081724f
PE
12435 Use ptrdiff_t, not int, for overlay counts.
12436 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
12437 * editfns.c (overlays_around, get_pos_property):
12438 * textprop.c (get_char_property_and_overlay):
12439 * xdisp.c (next_overlay_change, note_mouse_highlight):
12440 * xfaces.c (face_at_buffer_position):
21514da7
PE
12441 * buffer.c (OVERLAY_COUNT_MAX): New macro.
12442 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
12443 (Fnext_overlay_change, Fprevious_overlay_change)
12444 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 12445 Use ptrdiff_t, not int, for sizes.
21514da7 12446 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 12447
3de73e5e
PE
12448 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
12449
2606c57b
PE
12450 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
12451 (x_session_initialize): Do not assume string length fits in int.
12452
aaafe47a
PE
12453 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
12454 This is unlikely, but can occur if DPI is outlandish.
12455
2674ddc8 12456 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
12457 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
12458
28154962
PE
12459 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
12460 * xrdb.c (magic_file_p, search_magic_path):
12461 Omit last arg SUFFIX; it was always 0. All callers changed.
12462 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
12463
7de51af5
PE
12464 * xfont.c (xfont_match): Avoid need for strlen.
12465
25ed6cc3
PE
12466 * xfns.c: Don't assume strlen fits in int.
12467 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
12468
4eab31dd
PE
12469 * xdisp.c (message_log_check_duplicate): Return intmax_t,
12470 not unsigned long, as we prefer signed integers. All callers changed.
12471 Detect integer overflow in repeat count.
12472 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 12473 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 12474
171e2a58
PE
12475 * termcap.c: Don't assume sizes fit in int and never overflow.
12476 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
12477 (gobble_line): Check for size-calculation overflow.
12478
ad39faca 12479 * minibuf.c (Fread_buffer):
6e5bb2dc 12480 * lread.c (intern, intern_c_string):
74ca2eb3
PE
12481 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
12482 Don't assume string length fits in int.
12483
52c61c22 12484 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
12485 * gtkutil.c (style_changed_cb): Avoid need for strlen.
12486
b5b8c9e5
PE
12487 * font.c: Don't assume string length fits in int.
12488 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
12489 Use ptrdiff_t, not int.
ccd6111c
PE
12490 (font_intern_prop): Don't assume string length fits in int.
12491 Don't assume integer property fits in fixnum.
12492 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 12493
882f0d81 12494 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 12495 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
12496 Reformulate so as not to need the command string.
12497 Invoke gzip -cd rather than gunzip, as it's more portable.
12498 (lock_info_type, lock_file_1, lock_file):
12499 Don't assume pid_t and time_t fit in unsigned long.
12500 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
12501 (current_lock_owner): Prefer signed type for sizes.
12502 Use memcpy, not strncpy, where memcpy is what is really wanted.
12503 Don't assume (via atoi) that time_t and pid_t fit in int.
12504 Check for time_t and/or pid_t out of range, e.g., via a network share.
12505 Don't alloca where an auto var works fine.
12506
93f4cf88
PE
12507 * fileio.c: Fix some integer overflow issues.
12508 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
12509 Don't assume string length fits in int.
12510 (directory_file_name): Don't assume string length fits in long.
12511 (make_temp_name): Don't assume pid fits in int, or that its print
12512 length is less than 20.
12513
f3e92b69
PE
12514 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
12515
1bfdaf10
PE
12516 * coding.c (make_subsidiaries): Don't assume string length fits in int.
12517
35016e9a
PE
12518 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
12519
3d1e65a1
PE
12520 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
12521 We prefer signed integers, even for size calculations.
12522
0b963a93
PE
12523 * emacs.c: Don't assume string length fits in 'int'.
12524 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
12525 (main): Don't invoke strlen when not needed.
12526
573f4b54
PE
12527 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
12528 (XD_DEBUG_MESSAGE): Don't waste a byte.
12529
989f33ba
PE
12530 * callproc.c (getenv_internal_1, getenv_internal)
12531 (Fgetenv_internal):
965d34eb
PE
12532 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
12533
e4d29b33
PE
12534 * lread.c (invalid_syntax): Omit length argument.
12535 All uses changed. This doesn't fix a bug, but it simplifies the
12536 code away from its former Hollerith-constant appearance, and it's
12537 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 12538 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 12539
eb49b136
PE
12540 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
12541 This didn't break anything, but it didn't help either.
12542 It's confusing to put a bogus integer in a place where the actual
12543 value does not matter.
9f62aeb1 12544 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 12545 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 12546
15375a22
PE
12547 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
12548 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
12549 implementation.
b61cc01c
PE
12550 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
12551 We prefer signed types, and the value cannot exceed the EMACS_INT
12552 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
12553 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
12554 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
12555 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 12556
53b2623d
PE
12557 * indent.c (sane_tab_width): New function.
12558 (current_column, scan_for_column, Findent_to, position_indentation)
12559 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 12560 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 12561
51cab52b 12562 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 12563
f2ed8a70
PE
12564 * lisp.h (lint_assume): New macro.
12565 * composite.c (composition_gstring_put_cache):
12566 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
12567
abe80cc6
PE
12568 * editfns.c, insdel.c:
12569 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 12570
b02c740e
PE
12571 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
12572
ebc96716
PE
12573 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
12574
b4e50fa0 12575 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 12576 Use much-faster test for byte-length change.
311d5d7c 12577 Don't assume string byte-length fits in 'int'.
a4cf38e4 12578 Check that character arg fits in 'int'.
85461888 12579 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 12580
c0c1ee9f
PE
12581 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
12582
a498d7f4
PE
12583 * fns.c (concat): Catch string overflow earlier.
12584 Do not rely on integer wraparound.
12585
51cab52b
PE
12586 * dispextern.h (struct it.overlay_strings_charpos)
12587 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
12588 * xdisp.c (forward_to_next_line_start)
12589 (back_to_previous_visible_line_start)
12590 (reseat_at_next_visible_line_start, next_element_from_buffer):
12591 Don't arbitrarily truncate the value of 'selective' to int.
12592
76031fad
PE
12593 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
12594
5eb55db9
PE
12595 * composite.c: Don't truncate sizes to 'int'.
12596 (composition_gstring_p, composition_reseat_it)
12597 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
12598 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
12599 not EMACS_UINT, for indexes.
5eb55db9 12600
0703a717
PE
12601 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
12602
d6202519
PE
12603 * buffer.c: Include <verify.h>.
12604 (struct sortvec.priority, struct sortstr.priority):
8961a454 12605 Now EMACS_INT, not int.
c20998a7 12606 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
12607 (struct sortstr.size, record_overlay_string)
12608 (struct sortstrlist.size, struct sortlist.used):
12609 Don't truncate size to int.
12610 (record_overlay_string): Check for size-calculation overflow.
d6202519 12611 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 12612
d5a19415
JM
126132011-06-22 Jim Meyering <meyering@redhat.com>
12614
029529ac 12615 Don't leak an XBM-image-sized buffer
d5a19415
JM
12616 * image.c (xbm_load): Free the image buffer after using it.
12617
a9041e6c
PE
126182011-06-21 Paul Eggert <eggert@cs.ucla.edu>
12619
12620 Port to Sun C.
12621 * composite.c (find_automatic_composition): Omit needless 'return 0;'
12622 that Sun C diagnosed.
12623 * fns.c (secure_hash): Fix pointer signedness issue.
12624 * intervals.c (static_offset_intervals): New function.
12625 (offset_intervals): Use it.
12626
7f3f739f
LL
126272011-06-21 Leo Liu <sdl.web@gmail.com>
12628
12629 * deps.mk (fns.o):
12630 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
12631 sha512.h.
12632
12633 * fns.c (secure_hash): Rename from crypto_hash_function and change
12634 the first arg to accept symbols.
5b66d427 12635 (Fsecure_hash): New primitive.
7f3f739f
LL
12636 (syms_of_fns): New symbols.
12637
76147d94
DD
126382011-06-20 Deniz Dogan <deniz@dogan.se>
12639
12640 * process.c (Fset_process_buffer): Clarify return value in
12641 docstring.
12642
7d7d0045
CY
126432011-06-18 Chong Yidong <cyd@stupidchicken.com>
12644
12645 * dispnew.c (add_window_display_history): Use BVAR.
12646
12647 * xdisp.c (debug_method_add): Use BVAR.
12648 (check_window_end, dump_glyph_matrix, dump_glyph)
12649 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
12650
12651 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
12652 Likewise.
12653
12654 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
12655 check till after the cache is created in init_frame_faces.
12656
ff2bc410
SM
126572011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
12658
12659 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
12660
28177add
PE
126612011-06-16 Paul Eggert <eggert@cs.ucla.edu>
12662
dd3482fe
PE
12663 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
12664 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
12665 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
12666
393d71f3 12667 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
12668 * fileio.c (Finsert_file_contents):
12669 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
12670 Remove the old (too-loose) buffer overflow checks.
12671 They weren't needed, since make_gap checks for buffer overflow.
12672 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
12673 The old code merely checked for Emacs fixnum overflow, and relied
12674 on undefined (wraparound) behavior. The new code avoids undefined
12675 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12676
2e6813b0 12677 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
12678 Tune. Don't use wider integers than needed. Don't use alloca.
12679 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 12680
599a9e4f
PE
12681 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
12682
99561444
PE
12683 * insdel.c, lisp.h (buffer_overflow): New function.
12684 (insert_from_buffer_1, replace_range, replace_range_2):
12685 * insdel.c (make_gap_larger):
12686 * editfns.c (Finsert_char):
12687 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
12688
28177add
PE
12689 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12690
e69dafad
PE
126912011-06-15 Paul Eggert <eggert@cs.ucla.edu>
12692
4baa020d 12693 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 12694
b1c46f02
PE
12695 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
12696 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
12697
e69dafad
PE
12698 * fileio.c: Don't assume EMACS_INT fits in off_t.
12699 (emacs_lseek): New static function.
12700 (Finsert_file_contents, Fwrite_region): Use it.
12701 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
12702
566684ea
PE
12703 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12704
e6966cd6
PE
12705 * fns.c: Don't overflow int when computing a list length.
12706 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
12707 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
12708 truncation on 64-bit hosts. Check for QUIT every
12709 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
12710 faster and is responsive enough.
12711 (Flength): Report an error instead of overflowing an integer.
12712 (Fsafe_length): Return a float if the value is not representable
12713 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 12714 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 12715 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 12716
dd0b0efb
PE
12717 * alloc.c: Check that resized vectors' lengths fit in fixnums.
12718 (header_size, word_size): New constants.
12719 (allocate_vectorlike): Don't check size overflow here.
12720 (allocate_vector): Check it here instead, since this is the only
12721 caller of allocate_vectorlike that could cause overflow.
12722 Check that the new vector's length is representable as a fixnum.
12723
86fe5cfe
PE
12724 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
12725 The previous code was bogus. For example, next_almost_prime (32)
12726 returned 39, which is undesirable as it is a multiple of 3; and
12727 next_almost_prime (24) returned 25, which is a multiple of 5 so
12728 why was the code bothering to check for multiples of 7?
12729
80e88859
PE
12730 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
12731
4a2f0ad6
PE
12732 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
12733
f66c7cf8
PE
12734 Variadic C functions now count arguments with ptrdiff_t.
12735 This partly undoes my 2011-03-30 change, which replaced int with size_t.
12736 Back then I didn't know that the Emacs coding style prefers signed int.
12737 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
12738 were being counted with int, which may truncate counts on 64-bit
12739 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
12740 * lisp.h (struct Lisp_Subr.function.aMANY)
12741 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
12742 Arg counts are now ptrdiff_t, not size_t.
12743 All variadic functions and their callers changed accordingly.
12744 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
12745 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
12746 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
12747 * callint.c (Fcall_interactively): Check arg count for overflow,
12748 to avoid potential buffer overrun. Use signed char, not 'int',
12749 for 'varies' array, so that we needn't bother to check its size
12750 calculation for overflow.
12751 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
12752 * eval.c (apply_lambda):
12753 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
12754 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
12755 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
12756
a1759b76
PE
12757 * callint.c (Fcall_interactively): Don't use index var as event count.
12758
d96be9fc
PE
12759 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
12760 * mem-limits.h (SIZE): Remove; no longer used.
12761
a690a978 12762 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 12763
578c21e6
PE
12764 Remove unnecessary casts.
12765 * xterm.c (x_term_init):
12766 * xfns.c (x_set_border_pixel):
12767 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
12768 These aren't needed now that we assume ANSI C.
12769
96f53c6c
PE
12770 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12771 It's more likely to cause problems (due to unsigned overflow)
12772 than to cure them.
12773
83c77d31
PE
12774 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
12775
ee2079f1
PE
12776 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
12777
6da65536
PE
12778 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12779
7147c4a4
PE
12780 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
12781
193e32d9
PE
12782 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
12783
e5533da6
PE
12784 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
12785
9910e595
PE
12786 GLYPH_CODE_FACE returns EMACS_INT, not int.
12787 * dispextern.h (merge_faces):
12788 * xfaces.c (merge_faces):
01103c44
PE
12789 * xdisp.c (get_next_display_element, next_element_from_display_vector):
12790 Don't assume EMACS_INT fits in int.
9910e595 12791
2638320e
PE
12792 * character.h (CHAR_VALID_P): Remove unused parameter.
12793 * fontset.c, lisp.h, xdisp.c: All uses changed.
12794
045eb8d9
PE
12795 * editfns.c (Ftranslate_region_internal): Omit redundant test.
12796
c1f134b5
PE
12797 * fns.c (concat): Minor tuning based on overflow analysis.
12798 This doesn't fix any bugs. Use int to hold character, instead
12799 of constantly refetching from Emacs object. Use XFASTINT, not
12800 XINT, for value known to be a character. Don't bother comparing
12801 a single byte to 0400, as it's always less.
12802
395fcb93 12803 * floatfns.c (Fexpt):
327eeec8
PE
12804 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
12805
abbd3d23
PE
12806 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
12807 for characters.
12808
684a03ef
PE
12809 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
12810
0fed43f3
PE
12811 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12812 Without this fix, on a 64-bit host (aset S 0 4294967386) would
12813 incorrectly succeed when S was a string, because 4294967386 was
12814 truncated before it was used.
12815
8fd02eb7
PE
12816 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
12817 Otherwise, an out-of-range integer could cause undefined behavior
12818 on a 64-bit host.
12819
f8c86b69
PE
12820 * composite.c: Use int, not EMACS_INT, for characters.
12821 (fill_gstring_body, composition_compute_stop_pos): Use int, not
12822 EMACS_INT, for values that are known to be in character range.
12823 This doesn't fix any bugs but is the usual style inside Emacs and
12824 may generate better code on 32-bit machines.
12825
34206dd2
PE
12826 Make sure a 64-bit char is never passed to ENCODE_CHAR.
12827 This is for reasons similar to the recent CHAR_STRING fix.
12828 * charset.c (Fencode_char): Check that character arg is actually
12829 a character. Pass an int to ENCODE_CHAR.
12830 * charset.h (ENCODE_CHAR): Verify that the character argument is no
12831 wider than 'int', as a compile-time check to prevent future regressions
12832 in this area.
12833
c5958d4c 12834 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
12835
12836 Make sure a 64-bit char is never passed to CHAR_STRING.
12837 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
12838 by silently ignoring the top 32 bits, allowing some values
12839 that were far too large to be valid characters.
12840 * character.h: Include <verify.h>.
12841 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
12842 arguments are no wider than unsigned, as a compile-time check
12843 to prevent future regressions in this area.
12844 * data.c (Faset):
01103c44 12845 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
12846 (Fsubst_char_in_region):
12847 * fns.c (concat):
12848 * xdisp.c (decode_mode_spec_coding):
12849 Adjust to CHAR_STRING's new requirement.
12850 * editfns.c (Finsert_char, Fsubst_char_in_region):
12851 * fns.c (concat): Check that character args are actually
12852 characters. Without this test, these functions did the wrong
12853 thing with wildly out-of-range values on 64-bit hosts.
12854
d37ca623
PE
12855 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
12856 These casts should not be needed on 32-bit hosts, either.
12857 * keyboard.c (read_char):
12858 * lread.c (Fload): Remove casts to unsigned.
12859
ea204efb
PE
12860 * lisp.h (UNSIGNED_CMP): New macro.
12861 This fixes comparison bugs on 64-bit hosts.
12862 (ASCII_CHAR_P): Use it.
12863 * casefiddle.c (casify_object):
01103c44 12864 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
12865 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
12866 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
12867 * dispextern.h (FACE_FROM_ID):
12868 * keyboard.c (read_char): Use UNSIGNED_CMP.
12869
41cb286c
PE
12870 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
12871 not to EMACS_INT, to avoid GCC warning.
12872
4a1b9832
PE
12873 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
12874
55daad71
PE
12875 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
12876 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
12877 isn't needed on 32-bit machines.
8f95c75c 12878
01103c44
PE
12879 * buffer.c (Fgenerate_new_buffer_name):
12880 Use EMACS_INT for count, not int.
0ceccced 12881 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
12882
12883 * data.c (Qcompiled_function): Now static.
12884
c6f072e7
PE
12885 * window.c (window_body_lines): Now static.
12886
20ce5912
PE
12887 * image.c (gif_load): Rename local to avoid shadowing.
12888
9c4c5f81
PE
12889 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
12890 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
12891 * alloc.c (make_save_value): Integer argument is now of type
12892 ptrdiff_t, not int.
12893 (mark_object): Use ptrdiff_t, not int.
12894 * lisp.h (pD): New macro.
12895 * print.c (print_object): Use it.
12896
c0c5c8ae
PE
12897 * alloc.c: Use EMACS_INT, not int, to count objects.
12898 (total_conses, total_markers, total_symbols, total_vector_size)
12899 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
12900 (total_free_floats, total_floats, total_free_intervals)
12901 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
12902 Now EMACS_INT, not int. All uses changed.
12903 (Fgarbage_collect): Compute overall total using a double, so that
12904 integer overflow is less likely to be a problem. Check for overflow
12905 when converting back to an integer.
5a25e253
PE
12906 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
12907 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
12908 These were 'int' variables that could overflow on 64-bit hosts;
12909 they were never used, so remove them instead of repairing them.
211a0b2a 12910 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
12911 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
12912 Previously, this ceilinged at INT_MAX, but that doesn't work on
12913 64-bit machines.
e46bb31a 12914 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 12915
c78baabf 12916 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 12917 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
12918 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
12919 when a (possibly-narrower) signed value would do just as well.
12920 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 12921
c9d624c6
PE
12922 * alloc.c: Catch some string size overflows that we were missing.
12923 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
12924 for convenience in STRING_BYTES_MAX.
12925 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
12926 The definition here is exact; the one in lisp.h was approximate.
12927 (allocate_string_data): Check for string overflow. This catches
12928 some instances we weren't catching before. Also, it catches
12929 size_t overflow on (unusual) hosts where SIZE_MAX <= min
12930 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
12931 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 12932
c9d624c6
PE
12933 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
12934 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 12935 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 12936
353032ce
PE
12937 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
12938
2bccce07
PE
12939 * alloc.c (Fmake_string): Check for out-of-range init.
12940
0ac30604
SM
129412011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
12942
12943 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
12944
c195f2de
JD
129452011-06-14 Jan Djärv <jan.h.d@swipnet.se>
12946
12947 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12948 xg_get_default_scrollbar_width.
12949
12950 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12951 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12952 (style_changed_cb): Call update_theme_scrollbar_width and call
12953 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12954 all frames (Bug#8505).
12955 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12956 Call gtk_window_set_resizable if HAVE_GTK3.
12957 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12958 and height if HAVE_GTK3 (Bug#8505).
12959 (scroll_bar_width_for_theme): New variable.
12960 (update_theme_scrollbar_width): New function.
12961 (xg_get_default_scrollbar_width): Move code to
12962 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12963 (xg_initialize): Call update_theme_scrollbar_width.
12964
12965 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12966
12967 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12968
e10ac9f1
MR
129692011-06-12 Martin Rudalics <rudalics@gmx.at>
12970
12971 * frame.c (make_frame): Call other_buffer_safely instead of
12972 other_buffer.
12973
12974 * window.c (temp_output_buffer_show): Call display_buffer with
12975 second argument Vtemp_buffer_show_specifiers and reset latter
12976 immediately after the call.
12977 (Vtemp_buffer_show_specifiers): New variable.
12978 (auto_window_vscroll_p, next_screen_context_lines)
12979 (Vscroll_preserve_screen_position): Remove leading asterisks from
12980 doc-strings.
12981
2d3c217e 129822011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12983
7b7f97e8 12984 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12985 * buffer.c (Qclone_number): Remove for now, as it's unused.
12986 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12987 (record_buffer): Remove unused local.
12988 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12989 (set_frame_buffer_list): Remove; unused.
12990 * frame.h (other_visible_frames): Remove decl.
12991 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12992 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12993 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12994 if HAVE_GPM.
12995 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12996 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12997 Define only if HAVE_GPM.
12998 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12999 (update_hints_inhibit): Remove; never set. All uses removed.
13000 * widgetprv.h (emacsFrameClassRec): Remove decl.
13001 * window.c (delete_deletable_window): Now returns void, since it
13002 wasn't returning anything.
13003 (compare_window_configurations): Remove unused locals.
13004 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
13005 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
13006 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
13007 the same widths as pointers. This follows up on the 2011-05-06 patch.
13008 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
13009 * xterm.h: Likewise.
13010 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
13011
1384b89e
JB
130122011-06-12 Juanma Barranquero <lekktu@gmail.com>
13013
13014 * makefile.w32-in: Update dependencies.
13015 (LISP_H): Add lib/intprops.h.
13016
1100a63c
CY
130172011-06-11 Chong Yidong <cyd@stupidchicken.com>
13018
13019 * image.c (gif_load): Add animation frame delay to the metadata.
13020 (syms_of_image): Use DEFSYM. New symbol `delay'.
13021
6198ccd0
MR
130222011-06-11 Martin Rudalics <rudalics@gmx.at>
13023
13024 * window.c (delete_deletable_window): Re-add.
13025 (Fset_window_configuration): Rewrite to handle dead buffers and
13026 consequently deletable windows.
13027 (window_tree, Fwindow_tree): Remove. Supply functionality in
13028 window.el.
13029 (compare_window_configurations): Simplify code.
13030
b6e3633c
AS
130312011-06-11 Andreas Schwab <schwab@linux-m68k.org>
13032
1ab0dee5
AS
13033 * image.c (imagemagick_load_image): Fix type mismatch.
13034 (Fimagemagick_types): Likewise.
13035
b6e3633c
AS
13036 * window.h (replace_buffer_in_windows): Declare.
13037
9397e56f
MR
130382011-06-11 Martin Rudalics <rudalics@gmx.at>
13039
13040 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
13041 Qclone_number. Remove external declaration of Qdelete_window.
13042 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
13043 code.
640c8776
SM
13044 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
13045 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
13046 (Fother_buffer): Rewrite doc-string. Major rewrite for new
13047 buffer list implementation.
13048 (other_buffer_safely): New function.
13049 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
13050 calls to replace_buffer_in_windows and
13051 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
13052 if allowed.
13053 (record_buffer): Inhibit quitting and rewrite using quittable
13054 functions. Run Qbuffer_list_update_hook if allowed.
13055 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
13056 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
13057 Move switch-to-buffer to window.el.
9397e56f
MR
13058 (bury-buffer): Move to window.el.
13059 (Vbuffer_list_update_hook): New variable.
13060
13061 * lisp.h (other_buffer_safely): Add prototype in buffer.c
13062 section.
13063
13064 * window.h (resize_frame_windows): Move up in code.
13065 (Fwindow_frame): Remove EXFUN.
13066 (replace_buffer_in_all_windows): Remove prototype.
13067 (replace_buffer_in_windows_safely): Add prototype.
13068
13069 * window.c: Declare Qdelete_window static again. Move down
13070 declaration of select_count.
13071 (Fnext_window, Fprevious_window): Rewrite doc-strings.
13072 (Fother_window): Move to window.el.
13073 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
13074 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
13075 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
13076 window.el.
13077 (replace_buffer_in_windows): Implement by calling
13078 Qreplace_buffer_in_windows.
13079 (replace_buffer_in_all_windows): Remove with some functionality
13080 moved into replace_buffer_in_windows_safely.
13081 (replace_buffer_in_windows_safely): New function.
13082 (select_window_norecord, select_frame_norecord): Move in front
13083 of run_window_configuration_change_hook. Remove now obsolete
13084 declarations.
640c8776
SM
13085 (Fset_window_buffer): Rewrite doc-string.
13086 Call Qrecord_window_buffer.
9397e56f
MR
13087 (keys_of_window): Move binding for other-window to window.el.
13088
b50691aa
CY
130892011-06-11 Chong Yidong <cyd@stupidchicken.com>
13090
13091 * dispextern.h (struct image): Replace data member, whose int_val
13092 and ptr_val fields were not used by anything, with a single
13093 lisp_val object.
13094
13095 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13096 (gif_clear_image, gif_load, imagemagick_load_image)
13097 (gs_clear_image, gs_load): Callers changed.
13098
3f754b86
PE
130992011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13100
cca69397
PE
13101 * buffer.h: Include <time.h>, for time_t.
13102 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13103
109e28d0
PE
13104 Fix minor problems found by static checking.
13105
60737f02
PE
13106 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13107
4b66faf3
PE
13108 Make identifiers static if they are not used in other modules.
13109 * data.c (Qcompiled_function, Qframe, Qvector):
13110 * image.c (QimageMagick, Qsvg):
13111 * minibuf.c (Qmetadata):
13112 * window.c (resize_window_check, resize_root_window): Now static.
13113 * window.h (resize_window_check, resize_root_window): Remove decls.
13114
109e28d0
PE
13115 * window.c (window_deletion_count, delete_deletable_window):
13116 Remove; unused.
46a4ce9e
PE
13117 (window_body_lines): Now static.
13118 (Fdelete_other_windows_internal): Mark vars as initialized.
13119 Make sure 'resize_failed' is initialized.
13120 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13121 (resize_window_apply): Remove unused local.
13122 * window.h (delete_deletable_window): Remove decl.
13123
109e28d0 13124 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13125 (imagemagick_load_image): Fix pointer signedness problem by changing
13126 last arg from unsigned char * to char *. All uses changed.
13127 Also, fix a local for similar reasons.
13128 Remove unused locals. Remove locals to avoid shadowing.
13129 (fn_rsvg_handle_free): Remove; unused.
13130 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13131 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13132
3f754b86
PE
13133 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13134
2547adb1
CY
131352011-06-10 Chong Yidong <cyd@stupidchicken.com>
13136
13137 * image.c (gif_load): Fix omitted cast error introduced by
13138 2011-06-06 change.
13139
2c8e37d4
MR
131402011-06-10 Martin Rudalics <rudalics@gmx.at>
13141
13142 * window.h (resize_proportionally, orig_total_lines)
13143 (orig_top_line): Remove from window structure.
13144 (set_window_height, set_window_width, change_window_heights)
13145 (Fdelete_window): Remove prototypes.
13146 (resize_frame_windows): Remove duplicate declaration.
13147
440a42e3
EZ
131482011-06-10 Eli Zaretskii <eliz@gnu.org>
13149
13150 * window.h (resize_frame_windows, resize_window_check)
13151 (delete_deletable_window, resize_root_window)
13152 (resize_frame_windows): Declare prototypes.
13153
13154 * window.c (resize_window_apply): Make definition be "static" to
13155 match the prototype.
13156
562dd5e9
MR
131572011-06-10 Martin Rudalics <rudalics@gmx.at>
13158
13159 * window.c: Remove declarations of Qwindow_size_fixed,
13160 window_min_size_1, window_min_size_2, window_min_size,
13161 size_window, window_fixed_size_p, enlarge_window, delete_window.
13162 Remove static from declaration of Qdelete_window, it's
13163 temporarily needed by Fbury_buffer.
13164 (replace_window): Don't assign orig_top_line and
13165 orig_total_lines.
13166 (Fdelete_window, delete_window): Remove. Window deletion is
13167 handled by window.el.
640c8776
SM
13168 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13169 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13170 (Fdelete_other_windows): Remove. Deleting other windows is
13171 handled by window.el.
13172 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13173 handled in window.el.
13174 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13175 Window minimum sizes are handled in window.el.
13176 (shrink_windows, size_window, set_window_height)
13177 (set_window_width, change_window_heights, window_height)
13178 (window_width, CURBEG, CURSIZE, enlarge_window)
13179 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13180 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13181 handled in window.el.
13182 (make_dummy_parent): Rename to make_parent_window and give it a
13183 second argument horflag.
13184 (make_window): Don't set resize_proportionally any more.
13185 (Fsplit_window): Remove. Windows are split in window.el.
13186 (save_restore_action, save_restore_orig_size)
13187 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13188 Resize mini windows in window.el.
13189 (grow_mini_window, shrink_mini_window): Implement by calling
13190 Qresize_root_window_vertically, resize_window_check and
13191 resize_window_apply.
640c8776
SM
13192 (saved_window, Fset_window_configuration, save_window_save):
13193 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13194 resize_proportionally.
13195 (window_min_height, window_min_width): Move to window.el.
13196 (keys_of_window): Move bindings for delete-other-windows,
13197 split-window, delete-window and enlarge-window to window.el.
13198
13199 * buffer.c: Temporarily extern Qdelete_window.
13200 (Fbury_buffer): Temporarily call Qdelete_window instead of
13201 Fdelete_window (Fbury_buffer will move to window.el soon).
13202
13203 * frame.c (set_menu_bar_lines_1): Remove code handling
13204 orig_top_line and orig_total_lines.
13205
13206 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13207 set_window_height but set heights directly.
13208 (change_frame_size_1): Use resize_frame_windows.
13209
13210 * xdisp.c (init_xdisp): Don't use set_window_height but set
13211 heights directly.
13212
640c8776
SM
13213 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13214 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13215 run_window_configuration_change_hook.
13216
13217 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13218 instead of change_window_heights and run
13219 run_window_configuration_change_hook.
13220
1a13852e
MR
132212011-06-09 Martin Rudalics <rudalics@gmx.at>
13222
13223 * window.c (replace_window): Rename second argument REPLACEMENT to
13224 NEW. New third argument SETFLAG. Rewrite.
13225 (delete_window, make_dummy_parent): Call replace_window with
13226 third argument 1.
13227 (window_list_1): Move down in code.
13228 (run_window_configuration_change_hook): Move set_buffer part
13229 before select_frame_norecord part in order to unwind correctly.
13230 Rename count1 to count.
13231 (recombine_windows, delete_deletable_window, resize_root_window)
13232 (Fdelete_other_windows_internal)
13233 (Frun_window_configuration_change_hook, make_parent_window)
13234 (resize_window_check, resize_window_apply, Fresize_window_apply)
13235 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13236 (Fdelete_window_internal, Fresize_mini_window_internal):
13237 New functions.
1a13852e
MR
13238 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13239
f3d1777e
MR
132402011-06-08 Martin Rudalics <rudalics@gmx.at>
13241
496e208e
MR
13242 * window.h (window): Add some new members to window structure -
13243 normal_lines, normal_cols, new_total, new_normal, clone_number,
13244 splits, nest, prev_buffers, next_buffers.
13245 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13246 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13247
f3d1777e
MR
13248 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13249 Remove.
496e208e
MR
13250 (make_dummy_parent): Set new members of windows structure.
13251 (make_window): Move down in code. Handle new members of window
13252 structure.
13253 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13254 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13255 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13256 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13257 (Fset_window_next_buffers, Fset_window_clone_number):
13258 New functions.
496e208e
MR
13259 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13260 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13261 Doc-string fixes.
13262 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13263 Argument WINDOW can be now internal window too.
13264 (Fwindow_use_time): Move up in code.
13265 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13266 Rewrite doc-string.
13267 (Fset_window_configuration, saved_window)
13268 (Fcurrent_window_configuration, save_window_save): Handle new
13269 members of window structure.
b9e809c2
MR
13270 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13271 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13272 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13273 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13274 Qget_mru_window, Qresize_root_window,
13275 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13276 Qauto_buffer_name; staticpro them.
f3d1777e 13277
abde8f8c
MR
132782011-06-07 Martin Rudalics <rudalics@gmx.at>
13279
13280 * window.c (Fwindow_total_size, Fwindow_left_column)
13281 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13282 (Fwindow_list_1): New functions.
13283 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13284 (Fwindow_width, Fscroll_left, Fscroll_right):
13285 Use window_body_cols instead of window_box_text_cols.
13286 (delete_window, Fset_window_configuration):
13287 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13288 (delete_all_subwindows): Take a window as argument and not a
13289 structure. Rewrite.
190b47e6
MR
13290 (window_loop): Remove handling of GET_LRU_WINDOW and
13291 GET_LARGEST_WINDOW.
13292 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13293
13294 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13295 window_box_text_cols. delete_all_subwindows now takes a
13296 Lisp_Object as argument.
abde8f8c 13297
640c8776
SM
13298 * indent.c (compute_motion, Fcompute_motion):
13299 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13300
fa8a67e6
MR
13301 * frame.c (delete_frame): Call delete_all_subwindows with root
13302 window as argument.
13303
a54e3482
DC
133042011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13305
13306 * fns.c (Fputhash): Document return value.
13307
60002bf5
CY
133082011-06-06 Chong Yidong <cyd@stupidchicken.com>
13309
13310 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13311
0c671da6 133122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13313
b862a52a 13314 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13315
be44ca6c
PE
13316 Check for overflow when converting integer to cons and back.
13317 * charset.c (Fdefine_charset_internal, Fdecode_char):
13318 Use cons_to_unsigned to catch overflow.
13319 (Fencode_char): Use INTEGER_TO_CONS.
13320 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13321 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13322 * data.c (long_to_cons, cons_to_long): Remove.
13323 (cons_to_unsigned, cons_to_signed): New functions.
13324 These signal an error for invalid or out-of-range values.
13325 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13326 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
13327 * font.c (Ffont_variation_glyphs):
13328 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
13329 * lisp.h: Include <intprops.h>.
13330 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
13331 (cons_to_signed, cons_to_unsigned): New decls.
13332 (long_to_cons, cons_to_long): Remove decls.
13333 * undo.c (record_first_change): Use INTEGER_TO_CONS.
13334 (Fprimitive_undo): Use CONS_TO_INTEGER.
13335 * xfns.c (Fx_window_property): Likewise.
13336 * xselect.c: Include <limits.h>.
13337 (x_own_selection, selection_data_to_lisp_data):
13338 Use INTEGER_TO_CONS.
13339 (x_handle_selection_request, x_handle_selection_clear)
13340 (x_get_foreign_selection, Fx_disown_selection_internal)
13341 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
13342 (lisp_data_to_selection_data): Use cons_to_unsigned.
13343 (x_fill_property_data): Use cons_to_signed.
13344 Report values out of range.
13345
d1f3d2af
PE
13346 Check for buffer and string overflow more precisely.
13347 * buffer.h (BUF_BYTES_MAX): New macro.
13348 * lisp.h (STRING_BYTES_MAX): New macro.
13349 * alloc.c (Fmake_string):
13350 * character.c (string_escape_byte8):
13351 * coding.c (coding_alloc_by_realloc):
13352 * doprnt.c (doprnt):
13353 * editfns.c (Fformat):
13354 * eval.c (verror):
13355 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13356 since they may not be the same number.
13357 * editfns.c (Finsert_char):
13358 * fileio.c (Finsert_file_contents):
13359 Likewise for BUF_BYTES_MAX.
13360
dd52fcea
PE
13361 * image.c: Use ptrdiff_t, not int, for sizes.
13362 (slurp_file): Switch from int to ptrdiff_t.
13363 All uses changed.
13364 (slurp_file): Check that file size fits in both size_t (for
13365 malloc) and ptrdiff_t (for sanity and safety).
13366
7f9bbdbb
PE
13367 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
13368 if b->modtime has its maximal value.
13369
dfe18f82
PE
13370 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
13371
84acfcf0
PE
13372 Don't assume time_t can fit into int.
13373 * buffer.h (struct buffer.modtime): Now time_t, not int.
13374 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
13375 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
13376
ccd9a01a
PE
13377 Minor fixes for signed vs unsigned integers.
13378 * character.h (MAYBE_UNIFY_CHAR):
13379 * charset.c (maybe_unify_char):
13380 * keyboard.c (read_char, reorder_modifiers):
13381 XINT -> XFASTINT, since the integer must be nonnegative.
13382 * ftfont.c (ftfont_spec_pattern):
13383 * keymap.c (access_keymap, silly_event_symbol_error):
13384 XUINT -> XFASTINT, since the integer must be nonnegative.
13385 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
13386 since it makes no difference and we prefer signed.
13387 * keyboard.c (record_char): Use XUINT when all the neighbors do.
13388 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
13389 nonnegative.
13390
d6d100dd
SM
133912011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
13392
13393 * window.h (Fwindow_frame): Declare.
13394
2b6148e4
PE
133952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13396
13397 * alloc.c: Simplify handling of large-request failures (Bug#8800).
13398 (SPARE_MEMORY): Always define.
13399 (LARGE_REQUEST): Remove.
13400 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
13401
f230ecc9
MR
134022011-06-06 Martin Rudalics <rudalics@gmx.at>
13403
727e958e
MR
13404 * lisp.h: Move EXFUNS for Fframe_root_window,
13405 Fframe_first_window and Fset_frame_selected_window to window.h.
13406
13407 * window.h: Move EXFUNS for Fframe_root_window,
13408 Fframe_first_window and Fset_frame_selected_window here from
13409 lisp.h.
13410
13411 * frame.c (Fwindow_frame, Fframe_first_window)
13412 (Fframe_root_window, Fframe_selected_window)
13413 (Fset_frame_selected_window): Move to window.c.
13414 (Factive_minibuffer_window): Move to minibuf.c.
13415 (Fother_visible_frames_p): New function.
13416
13417 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
13418
f230ecc9
MR
13419 * window.c (decode_window, decode_any_window): Move up in code.
13420 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
13421 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
13422 (Fwindow_buffer): Move up and rewrite doc-string.
13423 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
13424 (Fwindow_prev): New functions.
727e958e
MR
13425 (Fwindow_frame): Move here from frame.c. Accept any window as
13426 argument.
13427 (Fframe_root_window, Fframe_first_window)
13428 (Fframe_selected_window): Move here from frame.c. Accept frame
13429 or arbitrary window as argument. Update doc-strings.
13430 (Fminibuffer_window): Move up in code.
13431 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
13432 (Fset_frame_selected_window): Move here from frame.c.
13433 Marginal rewrite.
727e958e
MR
13434 (Fselected_window, select_window, Fselect_window): Move up in
13435 code. Minor doc-string fixes.
f230ecc9 13436
4d09bcf6
PE
134372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13438
13439 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
13440 Do not assume that spare memory exists; that assumption is valid
13441 only if SYSTEM_MALLOC.
13442 (LARGE_REQUEST): New macro, so that the issue of large requests
13443 is separated from the issue of spare memory.
13444
810928a2
AS
134452011-06-05 Andreas Schwab <schwab@linux-m68k.org>
13446
172418ad
AS
13447 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
13448 format. (Bug#8806)
13449
43f862f7
AS
13450 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
13451
810928a2
AS
13452 * xfns.c (x_set_scroll_bar_default_width): Move declarations
13453 before statements.
13454
a059fe24
JD
134552011-06-05 Jan Djärv <jan.h.d@swipnet.se>
13456
13457 * gtkutil.c (xg_get_default_scrollbar_width): New function.
13458
13459 * gtkutil.h: Declare xg_get_default_scrollbar_width.
13460
13461 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
13462 min width by calling x_set_scroll_bar_default_width (Bug#8505).
13463
989bf368
JB
134642011-06-05 Juanma Barranquero <lekktu@gmail.com>
13465
13466 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
13467
4b80f674
CY
134682011-06-04 Chong Yidong <cyd@stupidchicken.com>
13469
13470 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
13471 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
13472 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
13473 New error handlers.
4b80f674
CY
13474 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
13475 Obey Vx_select_enable_clipboard_manager. Catch errors in
13476 x_clipboard_manager_save (Bug#8779).
13477 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 13478 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 13479
99a33b77 134802011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
13481
13482 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
13483
99a33b77 134842011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
13485
13486 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
13487 in the current matrix if keep_current_p is non-zero.
13488
8264569d
EZ
134892011-06-04 Eli Zaretskii <eliz@gnu.org>
13490
13491 * bidi.c (bidi_level_of_next_char): Fix last change.
13492
57f97249
EZ
134932011-06-03 Eli Zaretskii <eliz@gnu.org>
13494
fec2107c 13495 Support bidi reordering of text covered by display properties.
57f97249 13496
fec2107c
EZ
13497 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
13498 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
13499 (bidi_cache_search, bidi_cache_iterator_state)
13500 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
13501 (bidi_level_of_next_char, bidi_move_to_visually_next):
13502 Support character positions inside a run of characters covered by a
fec2107c
EZ
13503 display string.
13504 (bidi_paragraph_init, bidi_resolve_explicit_1)
13505 (bidi_level_of_next_char): Call bidi_fetch_char and
13506 bidi_fetch_char_advance instead of FETCH_CHAR and
13507 FETCH_CHAR_ADVANCE.
13508 (bidi_init_it): Initialize new members.
13509 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
13510 definitions.
13511 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
13512 instead of using explicit *_CHAR codes.
d6d100dd
SM
13513 (bidi_resolve_explicit, bidi_resolve_weak):
13514 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
13515 bidirectional text is supported only in multibyte buffers.
13516 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
13517 it to initialize the frame_window_p member of struct bidi_it.
13518 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
13519 (bidi_resolve_explicit, bidi_resolve_weak)
13520 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
13521 bidi_it->nchars is non-positive.
13522 (bidi_level_of_next_char): Don't try to lookup the cache for the
13523 next/previous character if nothing is cached there yet, or if we
13524 were just reseat()'ed to a new position.
c40e2fb2 13525
0e14fe90
EZ
13526 * xdisp.c (set_cursor_from_row): Set start and stop points
13527 according to the row's direction when priming the loop that looks
13528 for the glyph on which to display cursor.
13529 (single_display_spec_intangible_p): Function deleted.
13530 (display_prop_intangible_p): Reimplement to call
13531 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
13532 Accept 3 additional arguments needed by handle_display_spec.
13533 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
13534 values: lists, `(when COND...)' forms, etc.
13535 (single_display_spec_string_p): Support property values that are
13536 lists with the argument STRING its top-level element.
13537 (display_prop_string_p): Fix the condition for processing a
13538 property that is a list to be consistent with handle_display_spec.
fec2107c 13539 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
13540 last portion of handle_display_prop.
13541 (compute_display_string_pos): Accept additional argument
13542 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
13543 value of a `display' property is a "replacing spec".
13544 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
13545 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
13546 the display property, but just return a value indicating whether
13547 the display property will replace the characters it covers.
13548 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
13549 frame_window_p members of struct bidi_it.
d6d100dd
SM
13550 (compute_display_string_pos, compute_display_string_end):
13551 New functions.
fec2107c
EZ
13552 (push_it): Accept second argument POSITION, where pop_it should
13553 jump to continue iteration.
13554 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 13555
fec2107c
EZ
13556 * keyboard.c (adjust_point_for_property): Adjust the call to
13557 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
13558
13559 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
13560 (bidi_init_it): Update prototypes.
13561 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
13562 (compute_display_string_pos, compute_display_string_end):
13563 Declare prototypes.
fec2107c
EZ
13564 (struct bidi_it): New members nchars and disp_pos. ch_len is now
13565 EMACS_INT.
fc6f18ce 13566
40087514 135672011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 13568
57f53182
PE
13569 Malloc failure behavior now depends on size of allocation.
13570 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
13571 * lisp.h: Change signatures accordingly.
13572 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
13573 All callers changed. (Bug#8762)
13574
13575 * gnutls.c: Use Emacs's memory allocators.
13576 Without this change, the gnutls library would invoke malloc etc.
13577 directly, which causes problems on non-SYNC_INPUT hosts, and which
13578 runs afoul of improving memory_full behavior. (Bug#8761)
13579 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
13580 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
13581 xfree instead of the default malloc, realloc, free.
13582 (Fgnutls_boot): No need to check for memory allocation failure,
13583 since xmalloc does that for us.
13584
ac32cd99 13585 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
13586 * category.c (hash_get_category_set):
13587 * ccl.c (ccl_driver):
13588 * charset.c (Fdefine_charset_internal):
13589 * charset.h (struct charset.hash_index):
13590 * composite.c (get_composition_id, gstring_lookup_cache)
13591 (composition_gstring_put_cache):
13592 * composite.h (struct composition.hash_index):
13593 * dispextern.h (struct image.hash):
13594 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
13595 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
13596 (hashfn_equal, hashfn_user_defined, make_hash_table)
13597 (maybe_resize_hash_table, hash_lookup, hash_put)
13598 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
13599 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
13600 (Fsxhash, Fgethash, Fputhash, Fmaphash):
13601 * image.c (make_image, search_image_cache, lookup_image)
13602 (xpm_put_color_table_h):
13603 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 13604 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 13605 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 13606 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
13607 * alloc.c (allocate_vectorlike):
13608 Check for overflow in vector size calculations.
13609 * ccl.c (ccl_driver):
13610 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
13611 * fns.c, image.c: Remove unnecessary static decls that would otherwise
13612 need to be updated by these changes.
40087514
PE
13613 * fns.c (make_hash_table, maybe_resize_hash_table):
13614 Check for integer overflow with large hash tables.
0de4bb68
PE
13615 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
13616 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
13617 (SXHASH_REDUCE): New macro.
13618 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
13619 Use it instead of discarding useful hash info with large hash values.
13620 (sxhash_float): New function.
13621 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
13622 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
13623 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
13624 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
13625 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
13626 Adjust signatures to match updated version of code.
13627 (consing_since_gc): Now EMACS_INT, since a single hash table can
13628 use more than INT_MAX bytes.
13629
698d32e2
DN
136302011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
13631
13632 Make it possible to build with GCC-4.6+ -O2 -flto.
13633
13634 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
13635
fd6fa53f
SM
136362011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
13637
13638 * minibuf.c (get_minibuffer, read_minibuf_unwind):
13639 Call minibuffer-inactive-mode.
13640
864db017
JB
136412011-05-31 Juanma Barranquero <lekktu@gmail.com>
13642
13643 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
13644 Update dependencies.
13645
2ad0baf4
DN
136462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13647
13648 * data.c (init_data): Remove code for UTS, this system is not
13649 supported anymore.
13650
4fcc2638
DN
136512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13652
13653 Don't force ./temacs to start in terminal mode.
13654
13655 * frame.c (make_initial_frame): Initialize faces in all cases, not
13656 only when CANNOT_DUMP is defined.
13657 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
13658
c56e0fd5
DN
136592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13660
13661 * dispnew.c (add_window_display_history): Use const for the string
13662 pointer. Remove declaration, not needed.
13663
333d54da 136642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 13665
55d4c1b2 13666 Use 'inline', not 'INLINE'.
333d54da 13667 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
13668 * alloc.c, fontset.c (INLINE): Remove.
13669 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
13670 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13671 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
13672 * gmalloc.c (register_heapinfo): Use inline unconditionally.
13673 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
13674
738db178
DN
136752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13676
13677 Make it possible to run ./temacs.
13678
13679 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
13680 syms_of_callproc does the same thing. Remove test for
13681 "initialized", do it in the caller.
13682 * emacs.c (main): Avoid calling set_initial_environment when dumping.
13683
620c53a6
SM
136842011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
13685
13686 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
13687 (read_minibuf): Use get_minibuffer.
13688 (syms_of_minibuf): Use DEFSYM.
13689 (Qmetadata): New var.
13690 * data.c (Qbuffer): Don't make it static.
13691 (syms_of_data): Use DEFSYM.
13692
e003a292
PE
136932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
13694
13695 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13696 (CCL_CODE_MIN): New macro.
13697
ed008a6d
PE
136982011-05-30 Paul Eggert <eggert@cs.ucla.edu>
13699
3687c2ef
PE
13700 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
13701
ed008a6d
PE
13702 * eval.c (Qdebug): Now static.
13703 * lisp.h (Qdebug): Remove decl. This reverts a part of the
13704 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13705 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
13706
d66c4c7c
CY
137072011-05-29 Chong Yidong <cyd@stupidchicken.com>
13708
13709 * image.c: Various fixes to ImageMagick code comments.
13710 (Fimagemagick_types): Doc fix.
13711
5fbc2025
PE
137122011-05-29 Paul Eggert <eggert@cs.ucla.edu>
13713
0196f88a
PE
13714 Minor fixes prompted by GCC 4.6.0 warnings.
13715
13716 * xselect.c (converted_selections, conversion_fail_tag): Now static.
13717
5fbc2025
PE
13718 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13719 (x_clipboard_manager_save_all): Move extern decl to ...
13720 * xterm.h: ... here, so that it can be checked for consistency.
13721
1dd3c2d9
CY
137222011-05-29 Chong Yidong <cyd@stupidchicken.com>
13723
13724 * xselect.c (x_clipboard_manager_save_frame)
13725 (x_clipboard_manager_save_all): New functions.
13726 (Fx_clipboard_manager_save): Lisp function deleted.
13727
13728 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
13729 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
13730
13731 * xterm.h: Update prototype.
13732
5ba6571d
WX
137332011-05-28 William Xu <william.xwl@gmail.com>
13734
13735 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
13736 exiting (Bug#8239).
13737
3eaff834
JM
137382011-05-28 Jim Meyering <meyering@redhat.com>
13739
e1900994 13740 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
13741 * fns.c (to_uchar): Define.
13742 (crypto_hash_function): Use it to convert some newly-signed
13743 variables to unsigned, to avoid sign-extension bugs. For example,
13744 without this change, (md5 "truc") would evaluate to
13745 45723a2aff78ff4fff7fff1114760e62 rather than the expected
13746 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 13747 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 13748
0f6990a7
PE
137492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13750
13751 Integer overflow fixes.
c8a9ca5a 13752
08686060
PE
13753 * dbusbind.c: Serial number integer overflow fixes.
13754 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
13755 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
13756 to hold a serial number that is too large for a fixnum.
13757 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13758 Check for serial numbers out of range. Decode any serial number
59568bf0 13759 that was so large that it became a float. (Bug#8722)
08686060 13760
2d1fc3c7
PE
13761 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
13762 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13763 Use XFASTINT rather than XUINT when numbers are nonnegative.
13764 (xd_append_arg, Fdbus_method_return_internal):
13765 (Fdbus_method_error_internal): Likewise. Also, for unsigned
13766 arguments, check that Lisp number is nonnegative, rather than
59568bf0 13767 silently wrapping negative numbers around. (Bug#8722)
30217ff0 13768 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 13769 (Bug#8722)
2d1fc3c7 13770
c8a9ca5a
PE
13771 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
13772
519e1d69
PE
13773 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
13774
6df6ae42 13775 ccl: Add integer overflow checks.
30569699
PE
13776 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
13777 (IN_INT_RANGE): New macros.
13778 (ccl_driver): Use them to check for integer overflow when
13779 decoding a CCL program. Many of the new checks are whether XINT (x)
13780 fits in int; it doesn't always, on 64-bit hosts. The new version
13781 doesn't catch all possible integer overflows, but it's an
847044ea 13782 improvement. (Bug#8719)
30569699 13783
c11285dc
PE
13784 * alloc.c (make_event_array): Use XINT, not XUINT.
13785 There's no need for unsigned here.
13786
fdccd48e
PE
13787 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
13788 This follows up to the 2011-05-06 change that substituted uintptr_t
13789 for EMACS_INT. This case wasn't caught back then.
13790
37910ab2
PE
13791 Rework Fformat to avoid integer overflow issues.
13792 * editfns.c: Include <float.h> unconditionally, as it's everywhere
13793 now (part of C89). Include <verify.h>.
13794 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
13795 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
13796 (Fformat): Avoid the prepass trying to compute sizes; it was only
13797 approximate and thus did not catch overflow reliably. Instead, walk
13798 through the format just once, formatting and computing sizes as we go,
13799 checking for integer overflow at every step, and allocating a larger
13800 buffer as needed. Keep track separately whether the format is
13801 multibyte. Keep only the most-recently calculated precision, rather
13802 than them all. Record whether each argument has been converted to
13803 string. Use EMACS_INT, not int, for byte and char and arg counts.
13804 Support field widths and precisions larger than INT_MAX. Avoid
13805 sprintf's undefined behavior with conversion specifications such as %#d
13806 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
13807 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
13808 formatting out-of-range floating point numbers with int
9173deec 13809 formats. (Bug#8668)
37910ab2 13810
2e6578fb
PE
13811 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
13812
0ae6bdee
PE
13813 * data.c: Avoid integer truncation in expressions involving floats.
13814 * data.c: Include <intprops.h>.
13815 (arith_driver): When there's an integer overflow in an expression
13816 involving floating point, convert the integers to floating point
13817 so that the resulting value does not suffer from catastrophic
13818 integer truncation. For example, on a 64-bit host (* 4
13819 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
13820 Do not rely on undefined behavior after integer overflow.
13821
de883a70
PE
13822 merge count_size_as_multibyte, parse_str_to_multibyte
13823 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 13824 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
13825 Check for integer overflow.
13826 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
13827 since it's now a duplicate of the other. This is more of
13828 a character than a buffer op, so better that it's in character.c.
13829 * fns.c, print.c: Adjust to above changes.
13830
2ff916cb
PE
138312011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
13832
13833 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
13834
f1b54466
PE
138352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13836
fb1ac845
PE
13837 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13838 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
13839 (x_clipboard_manager_save): Now static.
13840 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
13841
f1b54466
PE
13842 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13843 (crypto_hash_function): Now static.
13844 Fix pointer signedness problems. Avoid unnecessary initializations.
13845
a9f737ee
CY
138462011-05-27 Chong Yidong <cyd@stupidchicken.com>
13847
13848 * termhooks.h (Vselection_alist): Make it terminal-local.
13849
13850 * terminal.c (create_terminal): Initialize it.
13851
13852 * xselect.c: Support for clipboard managers.
13853 (Vselection_alist): Move to termhooks.h as terminal-local var.
13854 (LOCAL_SELECTION): New macro.
13855 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
13856 (symbol_to_x_atom): Remove gratuitous arg.
13857 (x_handle_selection_request, lisp_data_to_selection_data)
13858 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
13859 (x_own_selection, x_get_local_selection, x_convert_selection):
13860 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
13861 (some_frame_on_display): Delete unused function.
13862 (Fx_own_selection_internal, Fx_get_selection_internal)
13863 (Fx_disown_selection_internal, Fx_selection_owner_p)
13864 (Fx_selection_exists_p): New optional frame arg.
13865 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
13866 (x_handle_selection_clear): Don't treat other terminals with the
13867 same keyboard specially. Use the terminal-local Vselection_alist.
13868 (x_clear_frame_selections): Use Frun_hook_with_args.
13869
13870 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
13871
13872 * xterm.h: Add support for those atoms.
13873
e067f0c1
CY
138742011-05-26 Chong Yidong <cyd@stupidchicken.com>
13875
13876 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
13877 (converted_selections, conversion_fail_tag): New global variables.
13878 (x_selection_request_lisp_error): Free the above.
13879 (x_get_local_selection): Remove unnecessary code.
13880 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
13881 of converted selections stored in converted_selections.
13882 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
13883 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
13884 (x_convert_selection): New function.
13885 (x_handle_selection_event): Simplify.
13886 (x_get_foreign_selection): Don't ignore incoming requests while
13887 waiting for an answer; this will fail when we implement
13888 SAVE_TARGETS, and seems unnecessary anyway.
13889 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
13890 (Vx_sent_selection_functions): Doc fix.
13891
0f4aebc0
LL
138922011-05-26 Leo Liu <sdl.web@gmail.com>
13893
13894 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
13895
e61124cd
YM
138962011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13897
13898 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
13899
13900 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
13901 for fringe update if it has periodic bitmap.
ac389d0c 13902 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
13903 and fringe_bitmap_periodic_p.
13904
13905 * fringe.c (get_fringe_bitmap_data): New function.
13906 (draw_fringe_bitmap_1, update_window_fringes): Use it.
13907 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13908 row. Mark glyph row for fringe update if periodicity changed.
13909
13910 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
13911 for fringe update unless it has periodic bitmap.
13912
f16d9837
KH
139132011-05-25 Kenichi Handa <handa@m17n.org>
13914
13915 * xdisp.c (get_next_display_element): Set correct it->face_id for
13916 a static composition.
13917
e1b90ef6
LL
139182011-05-24 Leo Liu <sdl.web@gmail.com>
13919
13920 * deps.mk (fns.o):
13921 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
13922
13923 * fns.c (crypto_hash_function, Fsha1): New function.
13924 (Fmd5): Use crypto_hash_function.
13925 (syms_of_fns): Add Ssha1.
13926
7400048f
PE
139272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13928
13929 * gnutls.c: Remove unused macros.
13930 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
13931 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
13932 Remove macros that are defined and never used.
13933 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
13934
abb71cf4
CY
139352011-05-22 Chong Yidong <cyd@stupidchicken.com>
13936
13937 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
13938 (Fx_get_selection_internal): Minor cleanup.
13939 (Fx_own_selection_internal): Rename arguments for consistency with
13940 select.el.
13941
6307db39
PE
139422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13943
13944 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
13945
f3d4e0a4
CY
139462011-05-22 Chong Yidong <cyd@stupidchicken.com>
13947
13948 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13949
4d8ade89
YM
139502011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13951
13952 * dispnew.c (scrolling_window): Don't exclude the case that the
13953 last enabled row in the desired matrix touches the bottom boundary.
13954
32078c8d
GM
139552011-05-21 Glenn Morris <rgm@gnu.org>
13956
13957 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13958 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13959 and add some more files.
32078c8d 13960
7285dc67
EZ
139612011-05-20 Eli Zaretskii <eliz@gnu.org>
13962
13963 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13964 report_file_error introduced by the change from 2011-05-07.
13965
89d1bd22
PE
139662011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13967
13968 * systime.h (Time): Define only if emacs is defined.
13969 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13970 where the include path doesn't have X11/X.h by default. See
13971 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13972
cd394be1 139732011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13974
13975 * composite.c (find_automatic_composition): Fix previous change.
13976
b9704ad9
GM
139772011-05-20 Glenn Morris <rgm@gnu.org>
13978
13979 * lisp.mk: New file, split from Makefile.in.
13980 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13981 (shortlisp): Remove.
13982 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13983
4a720484
GM
139842011-05-19 Glenn Morris <rgm@gnu.org>
13985
13986 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13987 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13988 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13989 (lisp): Set the order to that of loadup.el.
13990 (shortlisp): Make it a copy of $lisp.
13991 (SOME_MACHINE_LISP): Remove.
13992 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13993 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13994
a28d4396
KH
139952011-05-18 Kenichi Handa <handa@m17n.org>
13996
13997 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13998 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13999 (find_automatic_composition): Mostly rewrite for efficiency.
14000
a2b1fa8e
JB
140012011-05-18 Juanma Barranquero <lekktu@gmail.com>
14002
14003 * makefile.w32-in: Update dependencies.
14004
8e1f5610
CS
140052011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
14006
14007 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 14008 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 14009
7025ee00 140102011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 14011
cdfa6eab
PE
14012 Fix some integer overflow issues, such as string length overflow.
14013
06d6db33
PE
14014 * insdel.c (count_size_as_multibyte): Check for string overflow.
14015
2b4560a8
PE
14016 * character.c (lisp_string_width): Check for string overflow.
14017 Use EMACS_INT, not int, for string indexes and lengths; in
14018 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
14019 the resulting string length overflows an EMACS_INT; instead,
14020 report a string overflow if no precision given. When checking for
14021 precision exhaustion, use a check that cannot possibly have
14022 integer overflow. (Bug#8675)
14023 * character.h (lisp_string_width): Adjust to new signature.
14024
cb93f9be
PE
14025 * alloc.c (string_overflow): New function.
14026 (Fmake_string): Use it. This doesn't change behavior, but saves
14027 a few bytes and will simplify future changes.
14028 * character.c (string_escape_byte8): Likewise.
14029 * lisp.h (string_overflow): New decl.
14030
1a1f3366
PE
14031 Fixups, following up to the user-interface timestamp change.
14032 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
14033 for UI timestamps, instead of unsigned long.
9fbd6841
PE
14034 * msdos.c (mouse_get_pos): Likewise.
14035 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
14036 * w32gui.h (Time): Define by including "systime.h" rather than by
14037 declaring it ourselves. (Bug#8664)
14038
d4e3e4d3
PE
14039 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
14040 * image.c (clear_image_cache): Likewise.
14041
f6a24d19
PE
14042 * term.c (term_mouse_position): Don't assume time_t wraparound.
14043
08dc5ae6
PE
14044 Be more systematic about user-interface timestamps.
14045 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
14046 and sometimes 'EMACS_UINT', to represent these timestamps.
14047 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
14048 This makes the code easier to follow, and makes it easier to catch
14049 integer overflow bugs such as Bug#8664.
14050 * frame.c (Fmouse_position, Fmouse_pixel_position):
14051 Use Time, not unsigned long, for user-interface timestamps.
14052 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
14053 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
14054 * keyboard.h (last_event_timestamp): Likewise.
14055 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
14056 * menu.h (xmenu_show): Likewise.
14057 * term.c (term_mouse_position): Likewise.
14058 * termhooks.h (struct input_event.timestamp): Likewise.
14059 (struct terminal.mouse_position_hook): Likewise.
14060 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
14061 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
14062 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
14063 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
14064 what it was before.
14065 * menu.h, termhooks.h: Include "systime.h", for Time.
14066
8e55734a
PE
14067 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
14068 Don't assume that the difference between two unsigned long values
14069 can fit into an integer. At this point, we know button_down_time
14070 <= event->timestamp, so the difference must be nonnegative, so
14071 there's no need to cast the result if double-click-time is
14072 nonnegative, as it should be; check that it's nonnegative, just in
14073 case. This bug is triggered when events are more than 2**31 ms
86db42d2 14074 apart (about 25 days). (Bug#8664)
8e55734a 14075
841f1b75 14076 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 14077 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14078
3e26f69c
PE
14079 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
14080 that always fit in int. Use a sentinel instead of a counter, to
14081 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
14082 * frame.h (struct frame): Use int for menu_bar_items_used
14083 instead of EMACS_INT, since it always fits in int.
3e26f69c 14084
5cc152c0
PE
14085 * menu.c (grow_menu_items): Check for int overflow.
14086
d89eb65e
PE
14087 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14088
5235bd3e
PE
14089 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14090 Before, the code was not consistent. These values cannot exceed
14091 2**31 - 1 so there's no need to make them unsigned.
14092 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14093 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14094 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14095 as modifiers.
14096 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14097
bc827e23
PE
14098 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14099 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14100 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14101 presumably because the widths might not match.
14102
78eb494e
PE
14103 * window.c (size_window): Avoid needless test at loop start.
14104
04f2d78b
CB
141052011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14106
14107 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14108
d2fc7e3d 141092011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14110
14111 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14112
d2fc7e3d 141132011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14114
14115 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14116 `width' to `bar_area_x' and `bar_area_width', respectively.
14117 (x_scroll_run): Take account of fringe background extension.
14118
04f2d78b
CB
14119 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14120 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14121 `bar_area_width', respectively.
14122 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14123 background extension.
14124
79b70037
GM
141252011-05-10 Jim Meyering <meyering@redhat.com>
14126
14127 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14128
2f142cc5
JB
141292011-05-10 Juanma Barranquero <lekktu@gmail.com>
14130
14131 * image.c (Finit_image_library): Return t for built-in image types,
14132 like pbm and xbm. (Bug#8640)
14133
57679c86
AS
141342011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14135
14136 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14137
888c9e86
EZ
141382011-05-07 Eli Zaretskii <eliz@gnu.org>
14139
b0512a1d
EZ
14140 * w32console.c (Fset_screen_color): Doc fix.
14141 (Fget_screen_color): New function.
14142 (syms_of_ntterm): Defsubr it.
14143
7285dc67
EZ
14144 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14145 unlink the temporary file if Fcall_process didn't create it in the
14146 first place.
14147 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14148 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14149 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14150 cue to call_process_cleanup not to close that handle.
14151
4d3fcc8e
BK
141522011-05-07 Ben Key <bkey76@gmail.com>
14153
14154 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14155 one of two shell specific rules, either bootstrap-temacs-CMD or
14156 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14157 to the previous implementation of the bootstrap-temacs rule.
14158 The bootstrap-temacs-CMD rule is similar to the previous
14159 implementation of the bootstrap-temacs rule except that it
14160 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14161 variable.
14162
14163 These changes, along with some changes to nt/configure.bat,
14164 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14165 earlier fix to add support for --cflags and --ldflags options
14166 that include quotes so that it works whether make uses cmd or
14167 sh as the shell.
14168
b4289b64
MA
141692011-05-06 Michael Albinus <michael.albinus@gmx.de>
14170
14171 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14172 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14173 is a constant.
14174 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14175 a string. Handle both cases.
14176 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14177 (Fdbus_register_method): Use Qinvalid_function.
14178
af4c0e28
JB
141792011-05-06 Juanma Barranquero <lekktu@gmail.com>
14180
14181 * makefile.w32-in: Update dependencies.
14182 (LISP_H): Add inttypes.h and stdin.h.
14183 (PROCESS_H): Add unistd.h.
14184
c51453d9
EZ
141852011-05-06 Eli Zaretskii <eliz@gnu.org>
14186
14187 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14188 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14189
8ff0ac3c 141902011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14191
4c4b566b
PE
14192 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14193
aab2b9b5
PE
14194 * term.c (vfatal): Remove stray call to va_end.
14195 It's not needed and the C Standard doesn't allow it here anyway.
14196
c378da0b
PE
14197 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14198 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14199
288b08c7
PE
14200 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14201 bytes.
14202
e3601888
PE
14203 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14204
db6c0e74
PE
14205 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14206
dd5963ea
PE
14207 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14208
88c9450f
PE
14209 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14210
2f9442b8
PE
14211 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14212
c032b5f8
PE
14213 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14214 * charset.c (Fdefine_charset_internal): Don't initialize
14215 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14216 32-bit int (Bug#8600).
a108c10b
PE
14217
14218 * lread.c (read_integer): Be more consistent with string-to-number.
14219 Use string_to_number to do the actual conversion; this avoids
14220 rounding errors and fixes some other screwups. Without this fix,
14221 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14222 (digit_to_number): Move earlier, for benefit of read_integer.
14223 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14224 not a digit in any supported base. (Bug#8602)
a108c10b 14225
ad5f9eea
PE
14226 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14227
aec1708a
PE
14228 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14229 to match comment at start of function. This also removes a
14230 GCC warning about overflow in a 32+64-bit port.
14231
47be4ab5
PE
14232 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14233
371cac43
PE
14234 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14235 Reported by Stefan Monnier in
14236 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14237 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14238 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14239
d01a7826
PE
14240 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14241 (EMACS_UINTPTR): Likewise, with uintptr_t.
14242
7fd47d5c
PE
14243 * lisp.h: Prefer 64-bit EMACS_INT if available.
14244 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14245 on 32-bit hosts that have 64-bit int, so that they can access
14246 large files.
122b0c86
PE
14247 However, temporarily disable this change unless the temporary
14248 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14249
8727937b
PE
14250 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14251
8ac068ac
PE
14252 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14253 This removes an assumption that EMACS_INT and long are the same
14254 width as pointers. The assumption is true for Emacs porting targets
14255 now, but we want to make other targets possible.
14256 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14257 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14258 In the rest of the code, change types of integers that hold casted
14259 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14260 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14261 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14262 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14263 No need to cast type when ORing.
14264 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14265 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14266 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14267 assume EMACS_INT is the same width as char *.
14268 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14269 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14270 Remove no-longer-needed casts.
14271 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14272 (xg_tool_bar_help_callback, xg_make_tool_item):
14273 Use EMACS_INTPTR to hold an integer
14274 that will be cast to void *; this can avoid a GCC warning
14275 if EMACS_INT is not the same width as void *.
14276 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14277 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14278 (current_message_1, set_message_1):
14279 Use a local to convert to proper width without a cast.
14280 * xmenu.c (dialog_selection_callback): Likewise.
14281
ede49d71
PE
14282 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14283 Also, don't assume VALBITS / RAND_BITS is less than 5,
14284 and don't rely on undefined behavior when shifting a 1 left into
14285 the sign bit.
14286 * lisp.h (get_random): Change signature to match.
14287
2f30ecd0
PE
14288 * lread.c (hash_string): Use size_t, not int, for hash computation.
14289 Normally we prefer signed values; but hashing is special, because
14290 it's better to use unsigned division on hash table sizes so that
14291 the remainder is nonnegative. Also, size_t is the natural width
14292 for hashing into memory. The previous code used 'int', which doesn't
14293 retain enough info to hash well into very large tables.
14294 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14295
2a866e7b
PE
14296 * dbusbind.c: Don't possibly lose pointer info when converting.
14297 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14298 Use XPNTR rather than XHASH, so that the high-order bits of
14299 the pointer aren't lost when converting through void *.
14300
51639eac
PE
14301 * eval.c (Fautoload): Don't double-shift a pointer.
14302
92394119
PE
14303 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14304
dbdb9a7c
JB
143052011-05-06 Juanma Barranquero <lekktu@gmail.com>
14306
14307 * gnutls.c (DEF_GNUTLS_FN):
14308 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14309
db7a0b4f
AS
143102011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14311
14312 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14313 marker. (Bug#8610)
14314
cd394be1 143152011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14316
14317 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14318 New version that can reserve upto 2GB of heap space.
14319
f7ff1b0f 143202011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14321
14322 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14323
639c109b
TZ
143242011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14325
14326 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
14327 `gnutls_certificate_set_x509_key_file'.
14328
d2127135
JB
143292011-05-05 Juanma Barranquero <lekktu@gmail.com>
14330
14331 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
14332 Update dependencies.
14333
e968f4f3
JB
143342011-05-04 Juanma Barranquero <lekktu@gmail.com>
14335
14336 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14337 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
14338 Remove unused parameter `fildes'.
14339 * process.c (read_process_output, send_process): Don't pass it.
14340
84d358f0
JB
143412011-05-04 Juanma Barranquero <lekktu@gmail.com>
14342
14343 Fix previous change: the library cache is defined in w32.c.
14344 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
14345 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
14346
0898ca10
JB
143472011-05-04 Juanma Barranquero <lekktu@gmail.com>
14348
14349 Implement dynamic loading of GnuTLS on Windows.
14350
14351 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
14352 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
14353 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14354 Declare.
14355
14356 * gnutls.c (Qgnutls_dll): Define.
14357 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
14358 (gnutls_*): Declare function pointers.
14359 (init_gnutls_functions): New function to initialize function pointers.
14360 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
14361 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
14362 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14363 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
14364 (emacs_gnutls_write, emacs_gnutls_read)
14365 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
14366 (Fgnutls_available_p): New function.
14367 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
14368 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
14369 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
14370
14371 * image.c: Include w32.h.
14372 (Vimage_type_cache): Delete.
14373 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
14374 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
14375 (w32_delayed_load): Move to w32.c.
14376
14377 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
14378
14379 * w32.c (QCloaded_from, Vlibrary_cache): Define.
14380 (w32_delayed_load): Move from image.c. When loading a library, record
14381 its filename in the :loaded-from property of the library id.
14382 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
14383 Initialize and staticpro them.
14384 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
14385
14386 * process.c: Include lisp.h before w32.h, not after.
14387 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
14388 instead of gnutls_record_check_pending.
14389
14390 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
14391
ff4de4aa
TZ
143922011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
14393
14394 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
14395 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
14396 as passed in.
14397
abe95abb
JD
143982011-05-03 Jan Djärv <jan.h.d@swipnet.se>
14399
14400 * xterm.c (x_set_frame_alpha): Do not set property on anything
14401 else than FRAME_X_OUTER_WINDOW (Bug#8608).
14402
e16e55d4
JB
144032011-05-02 Juanma Barranquero <lekktu@gmail.com>
14404
14405 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
14406
bafcf6a5
JB
144072011-05-02 Juanma Barranquero <lekktu@gmail.com>
14408
14409 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
14410 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
14411 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
14412 (gnutls_global_initialized, Qgnutls_bootprop_priority)
14413 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
14414 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
14415 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
14416 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
14417 (Qgnutls_bootprop_callbacks_verify): Make static.
14418
e7a6747f
AS
144192011-05-01 Andreas Schwab <schwab@linux-m68k.org>
14420
19ed11ba
AS
14421 * callproc.c: Indentation fixup.
14422
e7a6747f 14423 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
14424 (wait_for_termination, interruptible_wait_for_termination):
14425 Move after wait_for_termination_1.
e7a6747f 14426
1ef14cb4
LMI
144272011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
14428
14429 * sysdep.c (interruptible_wait_for_termination): New function
14430 which is like wait_for_termination, but allows keyboard
14431 interruptions.
14432
14433 * callproc.c (Fcall_process): Add (:file "file") as an option for
14434 the STDOUT buffer.
14435 (Fcall_process_region): Ditto.
14436
330d880c
EZ
144372011-04-30 Eli Zaretskii <eliz@gnu.org>
14438
8db90b73
EZ
14439 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
14440 rather than `XVECTOR (FOO)->size'.
14441
330d880c
EZ
14442 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
14443 inttypes.h, as a gnulib replacement is used if it not available in
14444 system headers.
14445
15cbd324
EZ
144462011-04-21 Eli Zaretskii <eliz@gnu.org>
14447
14448 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
14449 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
14450 of MOST_POSITIVE_FIXNUM. (Bug#8528)
14451
14452 * coding.c (coding_alloc_by_realloc): Error out if destination
14453 will grow beyond MOST_POSITIVE_FIXNUM.
14454 (decode_coding_emacs_mule): Abort if there isn't enough place in
14455 charbuf for the composition carryover bytes. Reserve an extra
14456 space for up to 2 characters produced in a loop.
14457 (decode_coding_iso_2022): Abort if there isn't enough place in
14458 charbuf for the composition carryover bytes.
14459
144602011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 14461
ae940cca
EZ
14462 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
14463 aborting when %lld or %lll format is passed.
14464 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
14465 %llo or %llx format is passed. (Bug#8545)
14466
03ab8921
EZ
14467 * window.c (window_scroll_line_based): Use a marker instead of
14468 simple variables to record original value of point. (Bug#7952)
14469
afda1437
EZ
14470 * doprnt.c (doprnt): Fix the case where a multibyte sequence
14471 produced by %s or %c overflows available buffer space. (Bug#8545)
14472
f76dee0c
PE
144732011-04-28 Paul Eggert <eggert@cs.ucla.edu>
14474
14475 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 14476 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 14477
fdc5744d
JB
144782011-04-28 Juanma Barranquero <lekktu@gmail.com>
14479
14480 * w32.c (init_environment): Warn about defaulting HOME to C:\.
14481
638f053a
JB
144822011-04-28 Juanma Barranquero <lekktu@gmail.com>
14483
14484 * keyboard.c (Qdelayed_warnings_hook): Define.
14485 (command_loop_1): Run `delayed-warnings-hook'
14486 if Vdelayed_warnings_list is non-nil.
14487 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
14488 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
14489
d178f871
EZ
144902011-04-28 Eli Zaretskii <eliz@gnu.org>
14491
14492 * doprnt.c (doprnt): Don't return value smaller than the buffer
14493 size if the message was truncated. (Bug#8545).
14494
b124fd93
JB
144952011-04-28 Juanma Barranquero <lekktu@gmail.com>
14496
14497 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
14498 (Fx_window_property): #if-0 the whole functions, not just the bodies.
14499
e810457d
PE
145002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14501
14502 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
14503
ea51cceb
JB
145042011-04-27 Juanma Barranquero <lekktu@gmail.com>
14505
14506 * makefile.w32-in: Update dependencies.
14507
94dcfacf
EZ
145082011-04-27 Eli Zaretskii <eliz@gnu.org>
14509
14510 Improve `doprnt' and its usage. (Bug#8545)
14511 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
14512 `format_end'. Remove support for %l as a conversion specifier.
14513 Don't use xrealloc. Improve diagnostics when the %l size modifier
14514 is used. Update the commentary.
14515
14516 * eval.c (verror): Simplify calculation of size_t.
14517
14518 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
14519 messages.
14520
f61f41d7
PE
145212011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
14522
14523 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
14524 change.
14525
96fb4434
PE
145262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14527
14528 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
14529 This makes this file independent of the recent pseudovector change.
14530
671875da 145312011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 14532
69e9b5a3
PE
14533 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
14534
b5f869a7 14535 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 14536 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 14537 Remove unused local.
c8926152 14538 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 14539
841a1577 14540 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
14541 GCC 4.6.0 optimizes based on type-based alias analysis.
14542 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
14543 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
14544 != &v->size, and therefore "v->size = 1; b->size = 2; return
14545 v->size;" must therefore return 1. This assumption is incorrect
14546 for Emacs, since it type-puns struct Lisp_Vector * with many other
14547 types. To fix this problem, this patch adds a new type struct
f904488f 14548 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
14549 and pseudovectors, and helps optimizing compilers not get fooled
14550 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
14551 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
14552 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
14553 the size member.
eab3844f
PE
14554 (XSETPVECTYPE): Rewrite in terms of new macro.
14555 (XSETPVECTYPESIZE): New macro, specifying both type and size.
14556 This is a bit clearer, and further avoids the possibility of
14557 undesirable aliasing.
14558 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 14559 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
14560 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
14561 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
14562 (ASIZE): Now uses header.size rather than size.
14563 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
14564 to avoid the hassle of writing XVECTOR (foo)->header.size.
14565 (struct vectorlike_header): New type.
eab3844f
PE
14566 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
14567 object, to help avoid aliasing.
14568 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
14569 (SUBRP): Likewise, since Lisp_Subr is a special case.
14570 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
14571 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
14572 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 14573 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
14574 changed to be "header.size" and "header.next".
14575 * buffer.h (struct buffer): Likewise.
14576 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
14577 * frame.h (struct frame): Likewise.
14578 * process.h (struct Lisp_Process): Likewise.
14579 * termhooks.h (struct terminal): Likewise.
14580 * window.c (struct save_window_data, struct saved_window): Likewise.
14581 * window.h (struct window): Likewise.
14582 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
14583 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
14584 * buffer.c (init_buffer_once): Likewise.
14585 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
14586 special case.
14587 * process.c (Fformat_network_address): Use local var for size,
14588 for brevity.
14589
0df1eac5
PE
14590 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
14591
847ab9d1 14592 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
14593 * data.c (atof): Remove decl; no longer used or needed.
14594 (digit_to_number): Move to lread.c.
14595 (Fstring_to_number): Use new string_to_number function, to be
14596 consistent with how the Lisp reader treats infinities and NaNs.
14597 Do not assume that floating-point numbers represent EMACS_INT
14598 without losing information; this is not true on most 64-bit hosts.
14599 Avoid double-rounding errors, by insisting on integers when
14600 parsing non-base-10 numbers, as the documentation specifies.
14601 * lisp.h (string_to_number): New decl, replacing ...
14602 (isfloat_string): Remove.
bc0a5c13 14603 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 14604 (read1): Do not accept +. and -. as integers; this
452f4150
PE
14605 appears to have been a coding error. Similarly, do not accept
14606 strings like +-1e0 as floating point numbers. Do not report
14607 overflow for integer overflows unless the base is not 10 which
14608 means we have no simple and reliable way to continue.
14609 Break out the floating-point parsing into a new
14610 function string_to_number, so that Fstring_to_number parses
14611 floating point numbers consistently with the Lisp reader.
04f2d78b 14612 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
14613 (E_CHAR, EXP_INT): Remove, replacing with ...
14614 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
14615 (string_to_number): New function, replacing isfloat_string.
14616 This function checks for valid syntax and produces the resulting
14617 Lisp float number too. Rework it so that string-to-number
bc0a5c13 14618 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
14619 so that overflow for non-base-10 numbers is reported only when
14620 there's no portable and simple way to convert to floating point.
452f4150 14621
67769ffc
PE
14622 * textprop.c (set_text_properties_1): Rewrite for clarity,
14623 and to avoid GCC warning about integer overflow.
14624
c20db43f
PE
14625 * intervals.h (struct interval): Use EMACS_INT for members
14626 where EMACS_UINT might cause problems. See
14627 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
14628 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
14629 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
14630 All uses changed.
37aa2f85
PE
14631 (offset_intervals): Tell GCC not to worry about length overflow
14632 when negating a negative length.
c20db43f 14633
2538aa2f
PE
14634 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
14635 (overrun_check_free): Likewise.
14636
f2d3008d
PE
14637 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
14638 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
14639 word size.
14640
ec8df744
PE
14641 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14642 (gnutls_make_error): Rename local to avoid shadowing.
14643 (gnutls_emacs_global_deinit): ifdef out; not used.
14644 (Fgnutls_boot): Use const for pointer to readonly storage.
14645 Comment out unused local. Fix pointer signedness problems.
14646
640ee02d
PE
14647 * lread.c (openp): Don't stuff size_t into an 'int'.
14648 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
14649 about possible signed overflow.
14650
6048fb2a
PE
14651 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14652 (GDK_KEY_g): Don't define if already defined.
14653 (xg_prepare_tooltip): Avoid pointer signedness problem.
14654 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
14655
fa3c87e1
PE
14656 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
14657 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
14658
2172544b
PE
14659 * xfns.c (Fx_window_property): Simplify a bit,
14660 to make a bit faster and to avoid GCC 4.6.0 warning.
14661 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
14662
9b821a21
PE
14663 * fns.c (internal_equal): Don't assume size_t fits in int.
14664
3c616cfa
PE
14665 * alloc.c (compact_small_strings): Tighten assertion a little.
14666
c2982e87
PE
14667 Replace pEd with more-general pI, and fix some printf arg casts.
14668 * lisp.h (pI): New macro, generalizing old pEd macro to other
14669 conversion specifiers. For example, use "...%"pI"d..." rather
14670 than "...%"pEd"...".
14671 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 14672 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
14673 * alloc.c (check_pure_size): Don't overflow by converting size to int.
14674 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
14675 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
14676 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
14677 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14678 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
14679 64-bit hosts.
14680 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
14681 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
14682 * print.c (safe_debug_print, print_object): Likewise.
14683 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
14684 to int.
6f04d126
PE
14685 Use pI instead of if-then-else-abort. Use %p to avoid casts,
14686 avoiding the 0 flag, which is not portable.
c2982e87
PE
14687 * process.c (Fmake_network_process): Use pI to avoid cast.
14688 * region-cache.c (pp_cache): Likewise.
14689 * xdisp.c (decode_mode_spec): Likewise.
14690 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
14691 behavior on 64-bit hosts with printf arg.
6f04d126 14692 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
14693 (x_stop_queuing_selection_requests): Likewise.
14694 (x_get_window_property): Don't truncate byte count to an 'int'
14695 when tracing.
0b432f21 14696
5e073ec7
PE
14697 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
14698 here, since it parses constructs like leading '-' and spaces,
14699 which are not wanted; and it overflows with large numbers.
14700 Instead, simply match F[0-9]+, which is what is wanted anyway.
14701
36372bf9
PE
14702 * alloc.c: Remove unportable assumptions about struct layout.
14703 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
14704 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
14705 (allocate_vectorlike, make_pure_vector): Use the new macros,
14706 plus offsetof, to remove unportable assumptions about struct layout.
14707 These assumptions hold on all porting targets that I know of, but
14708 they are not guaranteed, they're easy to remove, and removing them
14709 makes further changes easier.
14710
0b432f21
PE
14711 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
14712 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
14713 (string_overrun_cookie): Now const. Use initializers that
14714 don't formally overflow signed char, to avoid warnings.
000098c1
PE
14715 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
14716 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
14717 (allocate_buffer): Don't assume sizeof (struct buffer) is a
14718 multiple of sizeof (EMACS_INT); it need not be, if
14719 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 14720 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 14721
895009e1
JB
147222011-04-26 Juanma Barranquero <lekktu@gmail.com>
14723
14724 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
14725
6a7a1b0b
TZ
147262011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
14727
14728 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 14729 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
14730 Reported by Paul Eggert <eggert@cs.ucla.edu>.
14731
841a1577 147322011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
14733
14734 * lisp.h (Qdebug): List symbol.
895009e1 14735 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
14736 * keyboard.c (debug-on-event): New variable.
14737 (handle_user_signal): Break into debugger when debug-on-event
14738 matches the current signal symbol.
14739
f2d3ba6f
DN
147402011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
14741
14742 * alloc.c (check_sblock, check_string_bytes)
14743 (check_string_free_list): Convert to standard C.
14744
42ce4c63
TZ
147452011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
14746
14747 * w32.c (emacs_gnutls_push): Fix typo.
14748
825cd63c
EZ
147492011-04-25 Eli Zaretskii <eliz@gnu.org>
14750
fb11d64d
EZ
14751 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
14752 "cast to pointer from integer of different size".
14753
825cd63c
EZ
14754 Improve doprnt and its use in verror. (Bug#8545)
14755 * doprnt.c (doprnt): Document the set of format control sequences
14756 supported by the function. Use SAFE_ALLOCA instead of always
14757 using `alloca'.
14758
14759 * eval.c (verror): Don't limit the buffer size at size_max-1, that
14760 is one byte too soon. Don't use xrealloc; instead xfree and
14761 xmalloc anew.
14762
e061a11b
TZ
147632011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
14764
14765 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
14766 callbacks stage.
14767
14768 * gnutls.c: Renamed global_initialized to
14769 gnutls_global_initialized. Added internals for the
14770 :verify-hostname-error, :verify-error, and :verify-flags
14771 parameters of `gnutls-boot' and documented those parameters in the
14772 docstring. Start callback support.
9173deec
JB
14773 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
14774 unless a fatal error occurred. Call gnutls_alert_send_appropriate
14775 on error. Return error code.
e061a11b
TZ
14776 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
14777 (emacs_gnutls_read): Likewise.
14778 (Fgnutls_boot): Return handshake error code.
14779 (emacs_gnutls_handle_error): New function.
14780 (wsaerror_to_errno): Likewise.
14781
14782 * w32.h (emacs_gnutls_pull): Add prototype.
14783 (emacs_gnutls_push): Likewise.
14784
14785 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
14786 (emacs_gnutls_push): Likewise.
14787
147882011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
14789
14790 * process.c (wait_reading_process_output): Check if GnuTLS
14791 buffered some data internally if no FDs are set for TLS
14792 connections.
14793
14794 * makefile.w32-in (OBJ2): Add gnutls.$(O).
14795 (LIBS): Link to USER_LIBS.
14796 ($(BLD)/gnutls.$(0)): New target.
14797
fa6996bc
EZ
147982011-04-24 Eli Zaretskii <eliz@gnu.org>
14799
eb35682e
EZ
14800 * xdisp.c (handle_single_display_spec): Rename the
14801 display_replaced_before_p argument into display_replaced_p, to
14802 make it consistent with the commentary. Fix typos in the
14803 commentary.
14804
e2ad650c
EZ
14805 * textprop.c (syms_of_textprop): Remove dead code.
14806 (copy_text_properties): Delete obsolete commentary about an
14807 interface that was deleted long ago. Fix typos in the description
14808 of arguments.
14809
1b2de274
EZ
14810 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
14811 to changes in oldXMenu/XMenu.h from 2011-04-16.
14812 <menu_help_message, prev_menu_help_message>: Constify.
14813 (IT_menu_make_room): menu->help_text is now `const char **';
14814 adjust.
14815
14816 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
14817 to changes in oldXMenu/XMenu.h from 2011-04-16.
14818 (struct XMenu): Declare `help_text' `const char **'.
14819
14820 * xfaces.c <Qunspecified>: Make extern again.
14821
14822 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 14823 required by POSIX.
1b2de274 14824
762b15be
EZ
14825 * doc.c (get_doc_string): Improve the format passed to `error'.
14826
14827 * doprnt.c (doprnt): Improve commentary.
14828
14829 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
14830
14831 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
14832 them with etags.
14833
f1052e5d
EZ
14834 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
14835 changes in globals.h immediately force recompilation.
762b15be
EZ
14836 (TAGS): Depend on $(CURDIR)/m/intel386.h and
14837 $(CURDIR)/s/ms-w32.h.
14838 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 14839
fa6996bc
EZ
14840 * character.c (Fchar_direction): Function deleted.
14841 (syms_of_character): Don't defsubr it.
14842 <char-direction-table>: Deleted.
14843
e6c3da20
EZ
148442011-04-23 Eli Zaretskii <eliz@gnu.org>
14845
14846 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
14847 * doprnt.c: Include limits.h.
14848 (SIZE_MAX): New macro.
04f2d78b
CB
14849 (doprnt): Return a size_t value. 2nd arg is now size_t.
14850 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
14851 Improve overflow protection. Support `l' modifier for integer
14852 conversions. Support %l conversion. Don't assume an EMACS_INT
14853 argument for integer conversions and for %c.
14854
14855 * lisp.h (doprnt): Restore prototype.
14856
14857 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
14858 $(SRC)/character.h.
14859
14860 * Makefile.in (base_obj): Add back doprnt.o.
14861
14862 * deps.mk (doprnt.o): Add back prerequisites.
14863 (callint.o): Depend on character.h.
14864
14865 * eval.c (internal_lisp_condition_case): Include the handler
14866 representation in the error message.
14867 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
14868 when breaking from the loop.
14869
14870 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
14871
14872 * callint.c (Fcall_interactively): When displaying error message
14873 about invalid control letter, pass the character's codepoint, not
14874 a pointer to its multibyte form. Improve display of the character
14875 in octal and display also its hex code.
14876
14877 * character.c (char_string): Use %x to display the (unsigned)
14878 codepoint of an invalid character, to avoid displaying a bogus
14879 negative value.
14880
14881 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
14882 `error', not SYMBOL_NAME itself.
14883
14884 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
14885 character arguments to `error'.
14886
14887 * charset.c (check_iso_charset_parameter): Fix incorrect argument
14888 to `error' in error message about FINAL_CHAR argument. Make sure
14889 FINAL_CHAR is a character, and use %c when it is passed as
14890 argument to `error'.
14891
4ffd0d6b 148922011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
14893
14894 * s/ms-w32.h (localtime): Redirect to sys_localtime.
14895
14896 * w32.c: Include <time.h>.
14897 (sys_localtime): New function.
14898
4ffd0d6b 148992011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
14900
14901 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
14902
4ffd0d6b 14903 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 14904
4ffd0d6b 149052011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 14906
4ffd0d6b
GM
14907 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
14908 zombies (Bug#8467).
aac0c6e3 14909
04c56954
EZ
149102011-04-19 Eli Zaretskii <eliz@gnu.org>
14911
14912 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
14913 gl_state.e_property when gl_state.object is Qt.
14914
14915 * insdel.c (make_gap_larger): Remove limitation of buffer size
14916 to <= INT_MAX.
14917
16a43933
CY
149182011-04-18 Chong Yidong <cyd@stupidchicken.com>
14919
14920 * xdisp.c (lookup_glyphless_char_display)
14921 (produce_glyphless_glyph): Handle cons cell entry in
14922 glyphless-char-display.
14923 (Vglyphless_char_display): Document it.
14924
14925 * term.c (produce_glyphless_glyph): Handle cons cell entry in
14926 glyphless-char-display.
14927
4581706e
CY
149282011-04-17 Chong Yidong <cyd@stupidchicken.com>
14929
14930 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
14931
14932 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
14933
14934 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
14935 definition for no-X builds.
14936
4887c6e2 149372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 14938
fd35b6f9
PE
14939 Static checks with GCC 4.6.0 and non-default toolkits.
14940
5c1ccb01
PE
14941 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
14942
006c5daa
PE
14943 * process.c (keyboard_bit_set): Define only if SIGIO.
14944 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
14945 (send_process): Repair possible setjmp clobbering.
14946
efc736d3
PE
14947 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14948
4e2fe2e6
PE
14949 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14950
f97334a2
PE
14951 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14952
4e75f29d
PE
14953 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14954 Define only if needed.
14955
90efadd1
PE
14956 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14957 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14958 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14959
3c647824
PE
14960 * dispextern.h (struct redisplay_interface): Rename param
14961 to avoid shadowing.
e264f262 14962 * termhooks.h (struct terminal): Likewise.
761383f4 14963 * xterm.c (xembed_send_message): Likewise.
3c647824 14964
b58c5c4a
PE
14965 * insdel.c (make_gap_smaller): Define only if
14966 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14967
cad59032
PE
14968 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14969 it.
14970
c339dc2e
PE
14971 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14972 so that we aren't warned about unused symbols.
14973
91a3e27b
PE
14974 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14975
399c71d3 14976 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14977
8ffc96f5
PE
14978 * xfns.c (x_real_positions): Mark locals as initialized.
14979
eef9bc79
PE
14980 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14981
098db9dd
PE
14982 * xterm.c: Fix problems found by static analysis with other toolkits.
14983 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14984 (x_dispatch_event): Declare static if USE_GTK, and
14985 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14986 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14987 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14988 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14989 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14990
eb18f6cc
PE
14991 * xmenu.c (menu_help_callback): Pointer type fixes.
14992 Use const pointers when pointing at readonly data. Avoid pointer
14993 signedness clashes.
14994 (FALSE): Remove unused macro.
14995 (update_frame_menubar): Remove unused decl.
14996
1fe72bf8
PE
14997 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14998
60d9e1db
PE
14999 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
15000 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
15001 (single_menu_item): Rename local to avoid shadowing.
15002
39261c26
PE
15003 * keyboard.c (make_lispy_event): Remove unused local var.
15004
018c5e19
PE
15005 * frame.c, frame.h (x_get_resource_string): Bring this back, but
15006 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
15007
63d2b86e
PE
15008 * bitmaps: Change bitmaps from unsigned char back to the X11
15009 compatible char. Avoid the old compiler warnings about
15010 out-of-range initializers by using, for example, '\xab' rather
15011 than 0xab.
15012
aefd87e1
PE
15013 * xgselect.c (xgselect_initialize): Check vs interface
15014 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
15015
bf501fb9
PE
15016 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
15017
e9829fdf
PE
15018 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
15019 to read-only memory.
15020
1086c095
PE
15021 * fns.c (vector): Remove; this old hack is no longer needed.
15022
2baccd04 15023 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 15024 Remove unused var.
dde42981 15025 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 15026
72391843 15027 * xrdb.c (x_load_resources): Omit unused local.
3565b346 15028
436c16df 15029 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 15030 (x_window): Rename locals to avoid shadowing.
dc5ddd85 15031 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 15032
92bb796d 15033 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 15034 (x_term_init): Remove local to avoid shadowing.
92bb796d 15035
764430a3 15036 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
15037
15038 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
15039 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
15040
d1dfb56c
EZ
150412011-04-16 Eli Zaretskii <eliz@gnu.org>
15042
c4354cb4
EZ
15043 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
15044
d1dfb56c
EZ
15045 Fix regex.c, syntax.c and friends for buffers > 2GB.
15046 * syntax.h (struct gl_state_s): Declare character position members
15047 EMACS_INT.
15048
15049 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
15050
04f2d78b
CB
15051 * textprop.c (verify_interval_modification, interval_of):
15052 Declare arguments EMACS_INT.
d1dfb56c
EZ
15053
15054 * intervals.c (adjust_intervals_for_insertion): Declare arguments
15055 EMACS_INT.
15056
15057 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
15058
15059 * indent.c (Fvertical_motion): Local variable it_start is now
15060 EMACS_INT.
15061
15062 * regex.c (re_match, re_match_2, re_match_2_internal)
15063 (bcmp_translate, regcomp, regexec, print_double_string)
15064 (group_in_compile_stack, re_search, re_search_2, regex_compile)
15065 (re_compile_pattern, re_exec): Declare arguments and local
15066 variables `size_t' and `ssize_t' and return values `regoff_t', as
15067 appropriate.
15068 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
15069 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
15070 <compile_stack_type>: `size' and `avail' are now `size_t'.
15071
15072 * regex.h <regoff_t>: Use ssize_t, not int.
15073 (re_search, re_search_2, re_match, re_match_2): Arguments that
15074 specify buffer/string position and length are now ssize_t and
15075 size_t. Return type is regoff_t.
15076
613052cd
BK
150772011-04-16 Ben Key <bkey76@gmail.com>
15078
15079 * nsfont.m: Fixed bugs in ns_get_family and
15080 ns_descriptor_to_entity that were caused by using free to
15081 deallocate memory blocks that were allocated by xmalloc (via
15082 xstrdup). This caused Emacs to crash when compiled with
15083 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15084 --enable-checking=xmallocoverrun). xfree is now used to
15085 deallocate these memory blocks.
15086
4170f62f 150872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15088
71b41406
PE
15089 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15090
9587a89d
PE
15091 emacs_write: Accept and return EMACS_INT for sizes.
15092 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15093 et seq.
15094 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15095 Accept and return EMACS_INT.
15096 (emacs_gnutls_write): Return the number of bytes written on
15097 partial writes.
15098 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15099 (emacs_read, emacs_write): Remove check for negative size, as the
15100 Emacs source code has been audited now.
9587a89d
PE
15101 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15102 (emacs_read, emacs_write): Use it.
273a5f82
PE
15103 * process.c (send_process): Adjust to the new signatures of
15104 emacs_write and emacs_gnutls_write. Do not attempt to store
15105 a byte offset into an 'int'; it might overflow.
9587a89d 15106 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15107
3e047f51
PE
15108 * sound.c: Don't assume sizes fit in 'int'.
15109 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15110 Return EMACS_INT, not int.
3e047f51 15111 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15112 Accept EMACS_INT, not int.
15113 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15114 record read return values.
15115
cc39a9db
BK
151162011-04-15 Ben Key <bkey76@gmail.com>
15117
c9d0ec6d
JB
15118 * keyboard.c (Qundefined): Don't declare static since it is used
15119 in nsfns.m.
15120 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15121 static since they are used in nsfont.m.
cc39a9db 15122
6c60eb9f
SM
151232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15124
15125 * process.c (Qprocessp): Don't declare static.
15126 * lisp.h (Qprocessp): Declare again.
15127
7990b61a
JB
151282011-04-15 Juanma Barranquero <lekktu@gmail.com>
15129
15130 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15131
5d4cb038
PE
151322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15133
8bd7b830 15134 Improve C-level modularity by making more things 'static'.
cd64ea1d 15135
e3b27b31
PE
15136 Don't publish debugger-only interfaces to other modules.
15137 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15138 (verify_bytepos, count_markers): Move decls to the only modules
15139 that need them.
15140 * region-cache.h (pp_cache): Likewise.
15141 * window.h (check_all_windows): Likewise.
15142 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15143
5d4cb038
PE
15144 * sysdep.c (croak): Now static, if
15145 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15146 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15147
15148 * alloc.c (refill_memory_reserve): Now static if
15149 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15150 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15151
e87b6180
PE
15152 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15153 Define only if USE_LUCID.
15154
ac64929e
PE
15155 * xrdb.c (x_customization_string, x_rm_string): Now static.
15156
6f37259d
PE
15157 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15158 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15159
1683e3ab
PE
15160 * xdisp.c (draw_row_with_mouse_face): Now static.
15161 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15162
de9c2632
PE
15163 * window.h (check_all_windows): Mark externally visible.
15164
2b96acb7
PE
15165 * window.c (window_deletion_count): Now static.
15166
15167 * undo.c: Make symbols static if they're not exported.
15168 (last_undo_buffer, last_boundary_position, pending_boundary):
15169 Now static.
15170
50436f33
PE
15171 * textprop.c (interval_insert_behind_hooks): Now static.
15172 (interval_insert_in_front_hooks): Likewise.
15173
64520e5c
PE
15174 * term.c: Make symbols static if they're not exported.
15175 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15176 (max_frame_lines, tty_set_terminal_modes):
15177 (tty_reset_terminal_modes, tty_turn_off_highlight):
15178 (get_tty_terminal): Now static.
15179 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15180 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15181 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15182 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15183 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15184
1fa53021
PE
15185 * sysdep.c: Make symbols static if they're not exported.
15186 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15187 Now static.
15188 (sigprocmask_set, full_mask): Remove; unused.
15189 (wait_debugging): Mark as visible.
15190 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15191 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15192
d4b43b22
PE
15193 * syntax.c (syntax_temp): Define only if !__GNUC__.
15194
b7c513d0
PE
15195 * sound.c (current_sound_device, current_sound): Now static.
15196
989b29ad
PE
15197 * search.c (searchbufs, searchbuf_head): Now static.
15198
13a55a78
PE
15199 * scroll.c (scroll_cost): Remove; unused.
15200 * dispextern.h (scroll_cost): Remove decl.
15201
de68a1fc
PE
15202 * region-cache.h (pp_cache): Mark as externally visible.
15203
40ccffa6
PE
15204 * process.c: Make symbols static if they're not exported.
15205 (process_tick, update_tick, create_process, chan_process):
15206 (Vprocess_alist, proc_buffered_char, datagram_access):
15207 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15208 (deactivate_process): Mark defn as static, as well as decl.
15209 * lisp.h (create_process): Remove decl.
15210 * process.h (chan_process, Vprocess_alist): Remove decls.
15211
ad64fc97
PE
15212 * print.c: Make symbols static if they're not exported.
15213 (print_depth, new_backquote_output, being_printed, print_buffer):
15214 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15215 (print_interval, print_number_index, initial_stderr_stream):
15216 Now static.
15217 * lisp.h (Fprinc): Remove decl.
15218 (debug_output_compilation_hack): Mark as externally visible.
15219
adddb265
PE
15220 * sysdep.c (croak): Move decl from here to syssignal.h.
15221 * syssignal.h (croak): Put it here, so the API can be checked when
15222 'croak' is called from dissociate_if_controlling_tty.
15223
1717ede2
PE
15224 * minibuf.c: Make symbols static if they're not exported.
15225 (minibuf_save_list, choose_minibuf_frame): Now static.
15226 * lisp.h (choose_minibuf_frame): Remove decl.
15227
fa5fb2bc
PE
15228 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15229
1e3890d1
PE
15230 * lread.c: Make symbols static if they're not exported.
15231 (read_objects, initial_obarray, oblookup_last_bucket_number):
15232 Now static.
15233 (make_symbol): Remove; unused.
15234 * lisp.h (initial_obarray, make_symbol): Remove decls.
15235
8a1414fa
PE
15236 * keyboard.c: Make symbols static if they're not exported.
15237 (single_kboard, recent_keys_index, total_keys, recent_keys):
15238 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15239 (this_single_command_key_start, echoing, last_auto_save):
15240 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15241 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15242 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15243 (Vlispy_mouse_stem, double_click_count):
15244 Now static.
15245 (force_auto_save_soon): Define only if SIGDANGER.
15246 (ignore_mouse_drag_p): Now static if
15247 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15248 (print_help): Remove; unused.
15249 (stop_character, last_timer_event): Mark as externally visible.
15250 * keyboard.h (ignore_mouse_drag_p): Declare only if
15251 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15252 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15253 * lisp.h (echoing): Remove decl.
15254 (force_auto_save_soon): Declare only if SIGDANGER.
15255 * xdisp.c (redisplay_window): Simplify code, to make it more
15256 obvious that ignore_mouse_drag_p is not accessed if !defined
15257 USE_GTK && !defined HAVE_NS.
15258
93ea6e8f
PE
15259 * intervals.c: Make symbols static if they're not exported.
15260 (merge_properties_sticky, merge_interval_right, delete_interval):
15261 Now static.
15262 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15263
77382fcc
PE
15264 * insdel.c: Make symbols static if they're not exported.
15265 However, leave prepare_to_modify_buffer alone. It's never
15266 called from outside this function, but that appears to be a bug.
15267 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15268 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15269 (adjust_after_replace_noundo): Remove; unused.
15270 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15271 (signal_before_change): Remove decls.
77382fcc 15272
9306c32e
PE
15273 * indent.c (val_compute_motion, val_vmotion): Now static.
15274
cd44d2eb
PE
15275 * image.c: Make symbols static if they're not exported.
15276 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15277 if USE_GTK.
15278 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15279 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15280
ad9a7a06
PE
15281 * fringe.c (standard_bitmaps): Now static.
15282 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15283
81626931
PE
15284 * frame.c: Make symbols static if they're not exported.
15285 (x_report_frame_params, make_terminal_frame): Now static.
15286 (get_frame_param): Now static, unless HAVE_NS.
15287 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15288 (x_get_resource_string): Remove; not used.
15289 * frame.h (make_terminal_frame, x_report_frame_params):
15290 (x_get_resource_string); Remove decls.
15291 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15292 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15293
239f9db9
PE
15294 * font.c, fontset.c: Make symbols static if they're not exported.
15295 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15296 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15297 * font.c (font_close_object): Now static.
15298 * font.h (font_close_object): Remove.
15299 * fontset.c (FONTSET_OBJLIST): Remove.
15300 (free_realized_fontset) #if-0 the body, which does nothing.
15301 (face_suitable_for_char_p): #if-0, as it's never called.
15302 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15303 * xfaces.c (face_at_string_position):
15304 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15305 since 0 is always ASCII.
15306
dfcf3579
PE
15307 * fns.c (weak_hash_tables): Now static.
15308
5045092b
PE
15309 * fileio.c: Make symbols static if they're not exported.
15310 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15311 (Vwrite_region_annotation_buffers): Now static.
15312
57a96f5c
PE
15313 * eval.c: Make symbols static if they're not exported.
15314 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15315 * lisp.h (backtrace_list): Remove decl.
15316
35f08c38
PE
15317 * emacs.c: Make symbols static if they're not exported.
15318 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15319 (fatal_error_code, fatal_error_signal_hook, standard_args):
15320 Now static.
15321 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15322 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15323 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15324 * lisp.h (fatal_error_signal_hook): Remove decl.
15325 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15326
f44bd759
PE
15327 * editfns.c: Move a (normally-unused) function to its only use.
15328 * editfns.c, lisp.h (get_operating_system_release): Remove.
15329 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
15330 worth the hassle of breaking this out.
15331
b532497d
PE
15332 * xterm.c: Make symbols static if they're not exported.
15333 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
15334 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
15335 (x_destroy_window, x_delete_display):
15336 Now static.
15337 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
15338 (x_mouse_leave): Remove; unused.
15339 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
15340 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
15341 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
15342 Remove decls.
15343 (x_mouse_leave): Declare only if WINDOWSNT.
15344 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
15345 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
15346 USE_X_TOOLKIT.
15347
1675728f
PE
15348 * ftxfont.c: Make symbols static if they're not exported.
15349 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
15350 HAVE_FREETYPE.
15351 * font.h (ftxfont_driver): Likewise.
15352
e4cebfca
PE
15353 * xfns.c: Make symbols static if they're not exported.
15354 (x_last_font_name, x_display_info_for_name):
15355 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
15356 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
15357 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
15358 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
15359 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15360 (last_show_tip_args): Now static.
15361 (xic_defaut_fontset, xic_create_fontsetname): Define only if
15362 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
15363 (x_screen_planes): Remove; unused.
15364 * dispextern.h (x_screen_planes): Remove decl.
15365
5bf46f05
PE
15366 * dispnew.c: Make symbols static if they're not exported.
15367 * dispextern.h (redraw_garbaged_frames, scrolling):
15368 (increment_row_positions): Remove.
15369 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
15370 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
15371 Now static.
15372 (redraw_garbaged_frames): Remove; unused.
15373
435f4c28
PE
15374 * xfaces.c: Make symbols static if they're not exported.
15375 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
15376 Remove decls.
15377 * xterm.h (defined_color): Remove decls.
15378 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
15379 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
15380 (menu_face_changed_default, defined_color, free_realized_face):
15381 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
15382 (ascii_face_of_lisp_face): Remove; unused.
15383
8524aef3
PE
15384 * xdisp.c: Make symbols static if they're not exported.
15385 * dispextern.h (scratch_glyph_row, window_box_edges):
15386 (glyph_to_pixel_coords, set_cursor_from_row):
15387 (get_next_display_element, set_iterator_to_next):
15388 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
15389 (show_mouse_face): Remove decls
15390 * frame.h (message_buf_print): Likewise.
15391 * lisp.h (pop_message, set_message, check_point_in_composition):
15392 Likewise.
15393 * xterm.h (set_vertical_scroll_bar): Likewise.
15394 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
15395 (message_buf_print, scratch_glyph_row, displayed_buffer):
15396 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
15397 (get_next_display_element, show_mouse_face, window_box_edges):
15398 (frame_to_window_pixel_xy, check_point_in_composition):
15399 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
15400 (glyph_to_pixel_coords): Remove; unused.
15401
16390cd2
PE
15402 * dired.c (file_name_completion): Now static.
15403
15404 * dbusbind.c (xd_in_read_queued_messages): Now static.
15405
a25f4dfa
PE
15406 * lisp.h (circular_list_error, FOREACH): Remove; unused.
15407 * data.c (circular_list_error): Remove.
15408
14a9c8df
PE
15409 * commands.h (last_point_position, last_point_position_buffer):
15410 (last_point_position_window): Remove decls.
15411 * keyboard.c: Make these variables static.
15412
04f2d78b
CB
15413 * coding.h (coding, code_convert_region, encode_coding_gap):
15414 Remove decls.
74ab6df5
PE
15415 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
15416 (iso_code_class, detect_coding, code_convert_region): Now static.
15417 (encode_coding_gap): Remove; unused.
15418
38dfbee1
PE
15419 * chartab.c (chartab_chars, chartab_bits): Now static.
15420
a2cb4e63
PE
15421 * charset.h (charset_iso_8859_1): Remove decl.
15422 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
15423 Now static.
15424
127198fd
PE
15425 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
15426 * ccl.c (Vccl_program_table): Now static.
15427 (check_ccl_update): Remove; unused.
15428
d85b608f
PE
15429 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
15430 * category.h: ... from here.
15431 * category.c (check_category_table, set_category_set): Now static.
15432
31cd66f3
PE
15433 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
15434 * lisp.h: Remove these decls.
15435
c358e587
PE
15436 * buffer.c (buffer_count): Remove unused var.
15437
e78aecca
PE
15438 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
15439 so that it's not optimized away.
15440 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
15441 * dispextern.h (bidi_dump_cached_states): Remove, since it's
15442 exported only to the debugger.
15443
e192d7d3 15444 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 15445 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 15446
92470028
PE
15447 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
15448 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
15449 was inaccessible from Lisp.
15450 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
15451 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
15452
244ed907
PE
15453 alloc.c: Import and export fewer symbols, and remove unused items.
15454 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
15455 is defined.
15456 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
15457 it's not optimized away by whole-program optimization.
15458 (message_enable_multibyte, free_misc): Remove.
15459 (catchlist, handlerlist, mark_backtrace):
15460 Declare only if BYTE_MARK_STACK.
15461 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
15462 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
15463 (message_enable_multibyte): Remove decl.
15464 (free_misc, interval_free_list, float_block, float_block_index):
15465 (n_float_blocks, float_free_list, cons_block, cons_block_index):
15466 (cons_free_list, last_marked_index):
15467 Now static.
15468 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
15469 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
15470 (mark_backtrace): Define only if BYTE_MARK_STACK.
15471 * xdisp.c (message_enable_multibyte): Now static.
15472
61c2b50e 15473 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
15474 This makes it easier for human readers (and static analyzers)
15475 to see whether these variables are used from other modules.
15476 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
15477 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
15478 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
15479 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
15480 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
15481 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
15482 * xmenu.c, xselect.c:
15483 Declare Q* vars static if they are not used in other modules.
15484 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
15485 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
15486 Remove decls of unexported vars.
15487 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
15488
95c82688
PE
15489 * lisp.h (DEFINE_FUNC): Make sname 'static'.
15490
16a97296
PE
15491 Make Emacs functions such as Fatom 'static' by default.
15492 This makes it easier for human readers (and static analyzers)
15493 to see whether these functions can be called from other modules.
15494 DEFUN now defines a static function. To make the function external
15495 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
15496 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
15497 (Finit_image_library):
16a97296
PE
15498 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
15499 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
15500 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
15501 Remove decls, since these functions are now static.
15502 (Funintern, Fget_internal_run_time): New decls, since these functions
15503 were already external.
95c82688 15504
16a97296
PE
15505 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
15506 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
15507 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
15508 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
15509 * keyboard.c, keymap.c, lread.c:
15510 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
15511 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
15512 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
15513 Mark functions with DEFUE instead of DEFUN,
15514 if they are used in other modules.
15515 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
15516 decls for now-static functions.
15517 * buffer.h (Fdelete_overlay): Remove decl.
15518 * callproc.c (Fgetenv_internal): Mark as internal.
15519 * composite.c (Fremove_list_of_text_properties): Remove decl.
15520 (Fcomposition_get_gstring): New forward static decl.
15521 * composite.h (Fcomposite_get_gstring): Remove decl.
15522 * dired.c (Ffile_attributes): New forward static decl.
15523 * doc.c (Fdocumntation_property): New forward static decl.
15524 * eval.c (Ffetch_bytecode): New forward static decl.
15525 (Funintern): Remove extern decl; now in .h file where it belongs.
15526 * fileio.c (Fmake_symbolic_link): New forward static decl.
15527 * image.c (Finit_image_library): New forward static decl.
15528 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
15529 * intervals.h (Fprevious_property_change):
15530 (Fremove_list_of_text_properties): Remove decls.
15531 * keyboard.c (Fthis_command_keys): Remove decl.
15532 (Fcommand_execute): New forward static decl.
15533 * keymap.c (Flookup_key): New forward static decl.
15534 (Fcopy_keymap): Now static.
15535 * keymap.h (Flookup_key): Remove decl.
15536 * process.c (Fget_process): New forward static decl.
15537 (Fprocess_datagram_address): Mark as internal.
15538 * syntax.c (Fsyntax_table_p): New forward static decl.
15539 (skip_chars): Remove duplicate decl.
15540 * textprop.c (Fprevious_property_change): New forward static decl.
15541 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
15542 Now internal.
15543 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
15544 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
15545
785bbd42
PE
15546 * editfns.c (Fformat): Remove unreachable code.
15547
8b913b57
AS
155482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
15549
15550 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
15551 change. (Bug#8496)
15552
a6744a35
EZ
155532011-04-13 Eli Zaretskii <eliz@gnu.org>
15554
15555 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
15556 when at ZV. (Bug#8487)
15557
e7974947
AS
155582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
15559
baad03f0
AS
15560 * charset.c (Fclear_charset_maps): Use xfree instead of free.
15561 (Bug#8437)
15562 * keyboard.c (parse_tool_bar_item): Likewise.
15563 * sound.c (sound_cleanup, alsa_close): Likewise.
15564 * termcap.c (tgetent): Likewise.
15565 * xfns.c (x_default_font_parameter): Likewise.
15566 * xsettings.c (read_and_apply_settings): Likewise.
15567
e7974947
AS
15568 * alloc.c (overrun_check_malloc, overrun_check_realloc)
15569 (overrun_check_free): Protoize.
15570
28272684
PE
155712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
15572
15573 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
15574 since callers should never pass a negative size.
15575 Change the signature to match that of plain 'read' and 'write'; see
15576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
15577 * lisp.h: Update prototypes of emacs_write and emacs_read.
15578
11997c76
EZ
155792011-04-11 Eli Zaretskii <eliz@gnu.org>
15580
15581 * xdisp.c (redisplay_window): Don't try to determine the character
15582 position of the scroll margin if the window start point w->startp
e896f03c 15583 is outside the buffer's accessible region. (Bug#8468)
11997c76 15584
8a2cbd72
EZ
155852011-04-10 Eli Zaretskii <eliz@gnu.org>
15586
15587 Fix write-region and its subroutines for buffers > 2GB.
15588 * fileio.c (a_write, e_write): Modify declaration of arguments and
15589 local variables to support buffers larger than 2GB.
15590 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
15591
15592 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
15593 argument, local variables, and return value.
15594
15595 * lisp.h: Update prototypes of emacs_write and emacs_read.
15596
15597 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
15598
4073e537 155992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 15600
1ebfdcb6
PE
15601 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
15602
b2ded58d
PE
15603 Fix more problems found by GCC 4.6.0's static checks.
15604
7d66342c
PE
15605 * xdisp.c (vmessage): Use a better test for character truncation.
15606
bbf47d44
PE
15607 * charset.c (load_charset_map): <, not <=, for optimization,
15608 and to avoid potential problems with integer overflow.
9248994d 15609 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 15610 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 15611 * editfns.c (Fformat): Likewise.
1e69125e 15612 * syntax.c (skip_chars): Likewise.
3befa583 15613
e3019616
PE
15614 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
15615 This also lets GCC 4.6.0 generate slightly better loop code.
15616
becfa255
PE
15617 * callint.c (Fcall_interactively): <, not <=, for optimization.
15618 (Fcall_interactively): Count the number of arguments produced,
15619 not the number of arguments given. This is simpler and lets GCC
15620 4.6.0 generate slightly better code.
15621
dae0cd48
PE
15622 * ftfont.c: Distingish more carefully between FcChar8 and char.
15623 The previous code passed unsigned char * to a functions like
15624 strlen and xstrcasecmp that expect char *, which does not
15625 conform to the C standard.
15626 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
15627 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
15628 char * when the C standard requires it.
15629
76032d70
PE
15630 * keyboard.c (read_char): Remove unused var.
15631
eb3f1cc8
PE
15632 * eval.c: Port to Windows vsnprintf (Bug#8435).
15633 Include <limits.h>.
15634 (SIZE_MAX): Define if the headers do not.
15635 (verror): Do not give up if vsnprintf returns a negative count.
15636 Instead, grow the buffer. This ports to Windows vsnprintf, which
15637 does not conform to C99. Problem reported by Eli Zaretskii.
15638 Also, simplify the allocation scheme, by avoiding the need for
15639 calling realloc, and removing the ALLOCATED variable.
15640
70476b54
PE
15641 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
15642
12020a9e
PE
15643 Remove invocations of doprnt, as Emacs now uses vsnprintf.
15644 But keep the doprint source code for now, as we might revamp it
15645 and use it again (Bug#8435).
ea6c7ae6
PE
15646 * lisp.h (doprnt): Remove.
15647 * Makefile.in (base_obj): Remove doprnt.o.
15648 * deps.mk (doprnt.o): Remove.
15649
5fdb398c
PE
15650 error: Print 32- and 64-bit integers portably (Bug#8435).
15651 Without this change, on typical 64-bit hosts error ("...%d...", N)
15652 was used to print both 32- and 64-bit integers N, which relied on
15653 undefined behavior.
61bdb816 15654 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
15655 * lisp.h (error, verror): Mark as printf-like functions.
15656 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
15657 Report overflow in size calculations when allocating printf buffer.
15658 Do not truncate output string at its first null byte.
15659 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
15660 Truncate the output at a character boundary, since vsnprintf does not
15661 do that.
15662 * charset.c (check_iso_charset_parameter): Convert internal
15663 character to string before calling 'error', since %c now has the
15664 printf meaning.
15665 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
15666 overflow when computing char to be passed to 'error'. Do not
15667 pass Lisp_Object to 'error'; pass the integer instead.
15668 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
15669 formatted with plain %d.
15670
b189fa66
PE
15671 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
15672
bff87ef0
PE
15673 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
15674
7e2cac20
PE
15675 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
15676
ce4d90b5
PE
15677 * xterm.c (x_catch_errors): Remove duplicate declaration.
15678
266c9547
PE
15679 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
15680
79c49ad2
PE
15681 * xdisp.c, lisp.h (message_nolog): Remove; unused.
15682
368f4090
JM
156832011-04-10 Jim Meyering <meyering@redhat.com>
15684
15685 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
15686 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
15687 return ssize_t not "int", and use size_t as the buffer length.
15688 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
15689 * gnutls.h: Update declarations.
15690 * process.c (read_process_output): Use ssize_t, to match.
15691 (send_process): Likewise.
15692
a32d4040
CY
156932011-04-09 Chong Yidong <cyd@stupidchicken.com>
15694
15695 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
15696
8546720e 156972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 15698
04f2d78b
CB
15699 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
15700 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 15701
8546720e
GM
15702 * xterm.c (handle_one_xevent):
15703 * xmenu.c (create_and_show_popup_menu):
15704 * xselect.c (x_decline_selection_request)
15705 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 15706
0a2f5c1a 157072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
15708
15709 Fix some uses of `int' instead of EMACS_INT.
15710 * search.c (string_match_1, fast_string_match)
15711 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
15712 (scan_buffer, find_next_newline_no_quit)
15713 (find_before_next_newline, search_command, Freplace_match)
15714 (Fmatch_data): Make some `int' variables be EMACS_INT.
15715
15716 * xdisp.c (display_count_lines): 3rd argument and return value now
15717 EMACS_INT. All callers changed.
15718 (pint2hrstr): Last argument is now EMACS_INT.
15719
15720 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
15721 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
15722 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
15723 (decode_coding_utf_16, decode_coding_emacs_mule)
15724 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
15725 (decode_coding_ccl, decode_coding_charset)
15726 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
15727 (decode_coding_iso_2022, decode_coding_emacs_mule)
15728 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
15729 <char_offset, last_offset>: Declare EMACS_INT.
15730 (encode_coding_utf_8, encode_coding_utf_16)
15731 (encode_coding_emacs_mule, encode_invocation_designation)
15732 (encode_designation_at_bol, encode_coding_iso_2022)
15733 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
15734 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
15735 Declare EMACS_INT.
15736 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
15737 (encode_invocation_designation): Last argument P_NCHARS is now
15738 EMACS_INT.
15739 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
15740 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
15741
15742 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
15743 All users changed.
15744
15745 * ccl.c (Fccl_execute_on_string): Declare some variables
15746 EMACS_INT.
15747
8546720e 157482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
15749
15750 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
15751
4e19a977
CS
157522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
15753
15754 * process.c (Fformat_network_address): Doc fix.
15755
87302331
R
157562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
15757
ee7683eb 15758 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 15759
cbb59342
CY
157602011-04-08 Chong Yidong <cyd@stupidchicken.com>
15761
15762 * keyboard.c (read_char): Call Lisp function help-form-show,
15763 instead of using internal_with_output_to_temp_buffer.
15764 (Qhelp_form_show): New var.
e0d38eeb 15765 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
15766
15767 * print.c (internal_with_output_to_temp_buffer): Function deleted.
15768
15769 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15770
e67a13ab
CY
157712011-04-06 Chong Yidong <cyd@stupidchicken.com>
15772
04f2d78b
CB
15773 * process.c (Flist_processes): Remove to Lisp.
15774 (list_processes_1): Delete.
e67a13ab 15775
973f782d
EZ
157762011-04-06 Eli Zaretskii <eliz@gnu.org>
15777
7c106b1e
EZ
15778 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
15779
973f782d
EZ
15780 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15781
41cf7d1a 157822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 15783
ca23cc88
PE
15784 Fix more problems found by GCC 4.6.0's static checks.
15785
f390e2d5
PE
15786 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
15787
42eea0d0
PE
15788 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
15789
b69769da 15790 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 15791
f9541e84
PE
15792 * xdisp.c (vmessage): Mark as a printf-like function.
15793
13841b55
PE
15794 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
15795
c136c10f
PE
15796 * sound.c (sound_warning): Don't crash if arg contains a printf format.
15797
5e2d4a30
PE
15798 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
15799 printf-like functions.
15800 (tiff_load): Add casts to remove these marks before passing them
15801 to system-supplied API.
15802
583f48b9
PE
15803 * eval.c (Fsignal): Remove excess argument to 'fatal'.
15804
b25d760e
PE
15805 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
15806 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
15807 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
15808 directly, rather than having caller test rule sign. This avoids
15809 some unnecessary tests.
15810 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
15811 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
15812 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 15813
bc7b6697 15814 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 15815 (xfont_open): Avoid unnecessary tests.
bc7b6697 15816
27ccc379
PE
15817 * composite.c (composition_gstring_put_cache): Use unsigned integer.
15818
dcd5c89a
PE
15819 * composite.h, composite.c (composition_gstring_put_cache):
15820 Use EMACS_INT, not int, for length.
15821
b13a45c6
PE
15822 * composite.h (COMPOSITION_DECODE_REFS): New macro,
15823 breaking out part of COMPOSITION_DECODE_RULE.
15824 (COMPOSITION_DECODE_RULE): Use it.
15825 * composite.c (get_composition_id): Remove unused local vars,
15826 by using the new macro.
15827
1e792e4d
PE
15828 * textprop.c (set_text_properties_1): Change while to do-while,
15829 since the condition is always true at first.
15830
dc6c6455 15831 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
15832 (interval_deletion_adjustment): Return unsigned value.
15833 All uses changed.
dc6c6455 15834
aba7731a
PE
15835 * process.c (list_processes_1, create_pty, read_process_output):
15836 (exec_sentinel): Remove vars that were set but not used.
afd4052b 15837 (create_pty): Remove unnecessary "volatile"s.
bc57d757 15838 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 15839 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 15840 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 15841
fdfc4bf3
PE
15842 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
15843
fca8fe46 15844 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 15845 (update_syntax_table): Use unsigned instead of int.
fca8fe46 15846
06a0259a 15847 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 15848 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 15849 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 15850
e7b9e80f
PE
15851 * print.c (print_error_message): Avoid int overflow.
15852
56201685
PE
15853 * font.c (font_list_entities): Redo for clarity,
15854 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
15855
78834453 15856 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 15857 (font_score): Avoid potential overflow in diff calculation.
78834453 15858
0bc0b309 15859 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 15860 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 15861
e610eaca
PE
15862 * eval.c (funcall_lambda): Rename local to avoid shadowing.
15863
b895abce
PE
15864 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
15865 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
15866 can always succeed if overflow has undefined behavior.
15867
1f1d9321 15868 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 15869 (wordify): Omit three unnecessary tests.
1f1d9321 15870
c59478bc
PE
15871 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
15872 All callers changed. This avoids the need for an unused var.
15873
79b73827
PE
15874 * casefiddle.c (casify_region): Remove var that is set but not used.
15875
a4db5dfe
PE
15876 * dired.c (file_name_completion): Remove var that is set but not used.
15877
43aae36e
PE
15878 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
15879
2a47c44d 15880 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 15881 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 15882
a37c69bf
PE
15883 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
15884 Check for integer overflow on size calculations.
15885
328ab8e7
PE
15886 * buffer.c (Fprevious_overlay_change): Remove var that is set
15887 but not used.
15888
e5a2a5cb
PE
15889 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
15890 Remove vars that are set but not used.
8d84a6eb 15891 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 15892 (timer_check_2): Mark vars as initialized.
e5a2a5cb 15893
a60e5f68
PE
15894 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
15895
f661cb61 15896 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 15897 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 15898
f0397f5a
PE
15899 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
15900 that are set but not used.
15901
8664db06 15902 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 15903 if XCreateBitmapFromData fails (Bug#8410).
8664db06 15904
6abdaa4a
PE
15905 * xselect.c (x_get_local_selection, x_handle_property_notify):
15906 Remove vars that are set but not used.
15907
0ce7538d 15908 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 15909 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 15910
9ae848fc
PE
15911 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
15912 Remove var that is set but not used.
0b918413
PE
15913 (scroll_bar_windows_size): Now size_t, not int.
15914 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
15915 Check for overflow.
9ae848fc 15916
a5a62657
PE
15917 * xfaces.c (realize_named_face): Remove vars that are set but not used.
15918 (map_tty_color) [!defined MSDOS]: Likewise.
15919
5c5cdd39
PE
15920 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
15921
66ebf983
PE
15922 * coding.c: Remove vars that are set but not used.
15923 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
15924 All callers changed.
15925 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
15926 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
15927 (decode_coding_charset): Remove vars that are set but not used.
15928
1be4d761
PE
15929 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
15930 that is set but not used.
15931
47553fa8
PE
15932 * print.c (print_object): Remove var that is set but not used.
15933
1f7196bf 15934 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
15935 The gnulib version avoids calling malloc in the usual case,
15936 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
15937 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
15938 * filelock.c (current_lock_owner): Likewise.
15939 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
15940 * sysdep.c: Include allocator.h, careadlinkat.h.
15941 (emacs_no_realloc_allocator): New static constant.
15942 (emacs_readlink): New function.
fdb61804
PE
15943 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
15944 ../lib/careadlinkat.h.
d1fdcab7 15945
f84c17c7
SM
159462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15947
15948 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15949 first non-nil return value).
15950
ef3862ad
JD
159512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15952
15953 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15954 if not defined (Bug#8403).
15955
376a7006
JB
159562011-04-02 Juanma Barranquero <lekktu@gmail.com>
15957
15958 * xdisp.c (display_count_lines): Remove parameter `start',
15959 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15960 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15961 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15962 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15963 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15964 and thereabouts. All callers changed.
15965 (get_per_char_metric): Remove parameter `f', unused since
15966 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15967
6ca3801d
JM
159682011-04-02 Jim Meyering <meyering@redhat.com>
15969
15970 do not dereference NULL upon failed strdup
15971 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15972 (ns_get_family): Likewise.
15973
d8e2b5ba
JB
159742011-04-02 Juanma Barranquero <lekktu@gmail.com>
15975
15976 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15977
8c74fcbd
JD
159782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15979
15980 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15981 later (Bug#8403).
15982
7200d79c
SM
159832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15984
03408648 15985 Add lexical binding.
7200d79c 15986
03408648
SM
15987 * window.c (Ftemp_output_buffer_show): New fun.
15988 (Fsave_window_excursion):
15989 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15990
15991 * lread.c (lisp_file_lexically_bound_p): New function.
15992 (Fload): Bind Qlexical_binding.
15993 (readevalloop): Remove `evalfun' arg.
15994 Bind Qinternal_interpreter_environment.
15995 (Feval_buffer): Bind Qlexical_binding.
15996 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15997 Mark as dynamic.
15998 (syms_of_lread): Declare `lexical-binding'.
15999
16000 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
16001
16002 * keyboard.c (eval_dyn): New fun.
16003 (menu_item_eval_property): Use it.
ca105506
SM
16004
16005 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 16006
03408648
SM
16007 * fns.c (concat, mapcar1): Accept byte-code-functions.
16008
16009 * eval.c (Fsetq): Handle lexical vars.
16010 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
16011 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
16012 (FletX, Flet): Obey lexical binding.
16013 (Fcommandp): Handle closures.
16014 (Feval): New `lexical' arg.
16015 (eval_sub): New function extracted from Feval. Use it almost
16016 everywhere where Feval was used. Look up vars in lexical env.
16017 Handle closures.
16018 (Ffunctionp): Move from subr.el.
16019 (Ffuncall): Handle closures.
16020 (apply_lambda): Remove `eval_flags'.
16021 (funcall_lambda): Handle closures and new byte-code-functions.
16022 (Fspecial_variable_p): New function.
16023 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
16024 but without exporting it to Lisp.
23aba0ea 16025
23aba0ea 16026 * doc.c (Fdocumentation, store_function_docstring):
03408648 16027 * data.c (Finteractive_form): Handle closures.
23aba0ea 16028
03408648
SM
16029 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
16030 interactive spec.
ba83908c 16031
04f2d78b
CB
16032 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
16033 New byte-codes.
03408648
SM
16034 (exec_byte_code): New function extracted from Fbyte_code to handle new
16035 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 16036
03408648 16037 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 16038
03408648 16039 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 16040
e2abce01
JB
160412011-03-31 Juanma Barranquero <lekktu@gmail.com>
16042
16043 * xdisp.c (redisplay_internal): Fix prototype.
16044
63696a73 160452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 16046
63696a73 16047 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
16048 (try_scrolling): Use it when setting scroll_limit.
16049 Limit scrolling to 100 screen lines.
63696a73
EZ
16050 (redisplay_window): Even when falling back on "recentering",
16051 position point in the window according to scroll-conservatively,
16052 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
16053
16054 (try_scrolling): When point is above the window, allow searching
16055 as far as scroll_max, or one screenful, to compute vertical
16056 distance from PT to the scroll margin position. This prevents
16057 try_scrolling from unnecessarily failing when
16058 scroll-conservatively is set to a value slightly larger than the
16059 window height. Clean up the case of PT below the margin at bottom
16060 of window: scroll_max can no longer be INT_MAX. When aggressive
16061 scrolling is in use, don't let point enter the opposite scroll
16062 margin as result of the scroll.
16063 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
16064 threshold of 100 lines for never-recentering scrolling.
16065
e4cc2dfc
JB
160662011-03-31 Juanma Barranquero <lekktu@gmail.com>
16067
16068 * dispextern.h (move_it_by_lines):
16069 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
16070 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
16071 (message_log_check_duplicate): Remove parameters `prev_bol' and
16072 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16073 (redisplay_internal): Remove parameter `preserve_echo_area',
16074 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
16075
16076 * indent.c (Fvertical_motion):
16077 * window.c (window_scroll_pixel_based, Frecenter):
16078 Don't pass `need_y_p' to `move_it_by_lines'.
16079
1c470562
SM
160802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
16081
44f230aa
SM
16082 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
16083 steal a few bits to be more compact.
16084 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16085 Remove unneeded casts.
16086
1c470562
SM
16087 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16088
888adce9
ZK
160892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16090
16091 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16092 binding" message (bug#7967).
16093
f838ed7b
PE
160942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16095
77861b95
PE
16096 Fix more problems found by GCC 4.6.0's static checks.
16097
de6dbc14
PE
16098 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16099 Remove unused local var.
16100
f838ed7b
PE
16101 * editfns.c (Fmessage_box): Remove unused local var.
16102
792c7b2b
PE
16103 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16104 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16105 Omit unused local vars.
c499e557 16106 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16107 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16108 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16109 Omit unused local var.
16110
ba0165e1
PE
16111 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16112 Don't assume string length fits in int.
32ad8845 16113 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16114 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16115
3c59b4c9
PE
16116 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16117 instead of alloca (Bug#8344).
16118
a3eed478 16119 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16120 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16121
eb4d412d
PE
16122 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16123
1658b401
PE
16124 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16125 concerns.
16126
16127 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16128
16129 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16130
9a2c6e05
PE
16131 * keyboard.c (syms_of_keyboard): Use the same style as later
16132 in this function when indexing through an array. This also
16133 works around GCC bug 48267.
16134
03d0a109
PE
16135 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16136
44f730c8
PE
16137 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16138
fe75f926
PE
16139 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16140 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16141
ffa8c828
PE
16142 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16143 This avoids undefined behavior on integer overflow, and is a bit
16144 more convenient anyway since it is compared to a size_t variable.
16145
c5101a77
PE
16146 Variadic C functions now count arguments with size_t, not int.
16147 This avoids an unnecessary limitation on 64-bit machines, which
16148 caused (substring ...) to crash on large vectors (Bug#8344).
16149 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16150 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16151 All variadic functions and their callers changed accordingly.
c5101a77
PE
16152 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16153 * data.c (arith_driver, float_arith_driver): Likewise.
16154 * editfns.c (general_insert_function): Likewise.
16155 * eval.c (struct backtrace.nargs, interactive_p)
16156 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16157 (funcall_lambda, mark_backtrace): Likewise.
16158 * fns.c (concat): Likewise.
16159 * frame.c (x_set_frame_parameters): Likewise.
16160 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16161 0 if not found, not -1. All callers changed.
16162
dd3f25f7
PE
16163 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16164 (stack_copy_size): Now size_t, not int.
16165 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16166
461c2ab9
JB
161672011-03-28 Juanma Barranquero <lekktu@gmail.com>
16168
16169 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16170 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16171 All callers changed.
16172
16173 * lisp.h (multibyte_char_to_unibyte):
16174 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16175 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16176 * character.h (CHAR_TO_BYTE8):
16177 * cmds.c (internal_self_insert):
16178 * editfns.c (general_insert_function):
16179 * keymap.c (push_key_description):
16180 * search.c (Freplace_match):
16181 * xdisp.c (message_dolog, set_message_1): All callers changed.
16182
f6d62986
SM
161832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16184
16185 * keyboard.c (safe_run_hook_funcall): New function.
16186 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16187 don't set the hook to nil, but remove the offending function instead.
16188 (Qcommand_hook_internal): Remove, unused.
16189 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16190 Vcommand_hook_internal.
16191
16192 * eval.c (enum run_hooks_condition): Remove.
16193 (funcall_nil, funcall_not): New functions.
16194 (run_hook_with_args): Call each function through a `funcall' argument.
16195 Remove `cond' argument, now redundant.
16196 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16197 (Frun_hook_with_args_until_failure): Adjust accordingly.
16198 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16199
1db5b1ad
JB
162002011-03-28 Juanma Barranquero <lekktu@gmail.com>
16201
16202 * dispextern.h (string_buffer_position): Remove declaration.
16203
16204 * print.c (strout): Remove parameter `multibyte', unused since
16205 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16206
16207 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16208 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16209 All callers changed.
16210
16211 * w32.c (_wsa_errlist): Use braces for struct initializers.
16212
16213 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16214 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16215 All callers changed.
16216 (string_buffer_position): Likewise. Also, make static (it's never
16217 used outside xdisp.c).
16218 (cursor_row_p): Remove parameter `w', unused since
16219 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16220 (decode_mode_spec): Remove parameter `precision', introduced during
16221 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16222 All callers changed.
16223
5ffb62aa
JD
162242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16225
16226 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16227
461c2ab9 162282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16229
16230 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16231 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16232 (ns_update_auto_hide_menu_bar): New functions.
16233 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16234 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16235 ns_constrain_all_frames.
16236 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16237 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16238
5c380ffb
JD
162392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16240
16241 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16242
9af30bdf
GM
162432011-03-27 Glenn Morris <rgm@gnu.org>
16244
16245 * syssignal.h: Replace RETSIGTYPE with void.
16246 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16247 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16248 Replace SIGTYPE with void everywhere.
16249 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16250 * s/template.h (SIGTYPE): Remove commented out definition.
16251
e2abce01
JB
162522011-03-26 Eli Zaretskii <eliz@gnu.org>
16253
16254 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16255 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16256
f868cd8a
JB
162572011-03-26 Juanma Barranquero <lekktu@gmail.com>
16258
59eb0929
JB
16259 * w32.c (read_unc_volume): Use parameter `henum', instead of
16260 global variable `wget_enum_handle'.
16261
16262 * keymap.c (describe_vector): Remove parameters `indices' and
16263 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16264 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16265
f868cd8a
JB
16266 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16267
16268 * keyboard.c (timer_check): Remove parameter `do_it_now',
16269 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16270 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16271 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16272
16273 * keyboard.c (read_char):
16274 * w32menu.c (w32_menu_display_help):
16275 * xmenu.c (show_help_event, menu_help_callback):
16276 Adjust calls to `show_help_echo'.
16277
16278 * gtkutil.c (xg_maybe_add_timer):
16279 * keyboard.c (readable_events):
16280 * process.c (wait_reading_process_output):
16281 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16282
16283 * insdel.c (adjust_markers_gap_motion):
16284 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16285 (gap_left, gap_right): Don't call it.
16286
2ecf6fdb
CY
162872011-03-25 Chong Yidong <cyd@stupidchicken.com>
16288
16289 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16290 incurred during fontification.
16291
6b1f9ba4
JB
162922011-03-25 Juanma Barranquero <lekktu@gmail.com>
16293
16294 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16295 (DEFVAR_PER_BUFFER): Don't pass it.
16296
16297 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16298 (scrolling_window): Don't pass it.
16299
0f4a96b5
JB
163002011-03-25 Juanma Barranquero <lekktu@gmail.com>
16301
16302 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16303
16304 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16305 and `suffix'.
16306 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16307 of variables specific to SELinux and computation of `encoded_absname'.
16308
16309 * image.c (XPutPixel): Remove unused variable `height'.
16310
16311 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16312
16313 * unexw32.c (get_section_info): Remove unused variable `section'.
16314
16315 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16316 (system_process_attributes): Remove unused variable `sess'.
16317 (sys_read): Remove unused variable `err'.
16318
16319 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16320 (w32_wnd_proc): Remove unused variable `isdead'.
16321 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16322 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16323 (x_create_tip_frame): Remove unused variable `tem'.
16324
16325 * w32inevt.c (w32_console_read_socket):
16326 Remove unused variable `no_events'.
16327
16328 * w32term.c (x_draw_composite_glyph_string_foreground):
16329 Remove unused variable `width'.
16330
1149507c
JB
163312011-03-24 Juanma Barranquero <lekktu@gmail.com>
16332
16333 * w32term.c (x_set_glyph_string_clipping):
16334 Don't pass uninitialized region to CombineRgn.
16335
9c88f339
JB
163362011-03-23 Juanma Barranquero <lekktu@gmail.com>
16337
16338 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
16339 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
16340 (Fx_close_connection): Remove unused variable `i'.
16341
16342 * w32font.c (w32font_draw): Return number of glyphs.
16343 (w32font_open_internal): Remove unused variable `i'.
16344 (w32font_driver): Add missing initializer.
16345
16346 * w32menu.c (utf8to16): Remove unused variable `utf16'.
16347 (fill_in_menu): Remove unused variable `items_added'.
16348
16349 * w32term.c (last_mouse_press_frame): Remove static global variable.
16350 (w32_clip_to_row): Remove unused variable `f'.
16351 (x_delete_terminal): Remove unused variable `i'.
16352
16353 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
16354 (NOTHING): Remove unused static global variable.
16355 (uniscribe_check_otf): Remove unused variable `table'.
16356 (uniscribe_font_driver): Add missing initializers.
16357
dee091a3
JD
163582011-03-23 Julien Danjou <julien@danjou.info>
16359
16360 * term.c (Fsuspend_tty, Fresume_tty):
16361 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
16362 * window.c (temp_output_buffer_show):
16363 * insdel.c (signal_before_change):
16364 * frame.c (Fhandle_switch_frame):
16365 * fileio.c (Fdo_auto_save):
16366 * emacs.c (Fkill_emacs):
16367 * editfns.c (save_excursion_restore):
16368 * cmds.c (internal_self_insert):
16369 * callint.c (Fcall_interactively):
16370 * buffer.c (Fkill_all_local_variables):
16371 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
16372 Use Frun_hooks.
0f4a96b5 16373 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 16374 unconditionally since it does the check itself.
dee091a3 16375
2c520ab5 163762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 16377
c9c49752
PE
16378 Fix more problems found by GCC 4.5.2's static checks.
16379
8abc3f12
PE
16380 * coding.c (encode_coding_raw_text): Avoid unnecessary test
16381 the first time through the loop, since we know p0 < p1 then.
16382 This also avoids a gcc -Wstrict-overflow warning.
16383
a2d26660
PE
16384 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
16385 leading to a memory leak, possible in functions like
16386 load_charset_map_from_file that can allocate an unbounded number
b12ef411 16387 of objects (Bug#8318).
a2d26660 16388
916c72e9
PE
16389 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
16390 that could (at least in theory) be that large.
16391
19ab8a18
PE
16392 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
16393 This is less likely to overflow, and avoids undefined behavior if
16394 overflow does occur. All callers changed. Use strtoul to scan
16395 for the unsigned long integer.
b7cbbd6f
PE
16396 (pint2hrstr): Simplify and tune code slightly.
16397 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 16398
f0641eff
PE
16399 * scroll.c (do_scrolling): Work around GCC bug 48228.
16400 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
16401
7f650bb9
PE
16402 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
16403 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
16404 (validate_x_resource_name): Simplify count usage.
16405 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 16406
37dd57d1
PE
16407 * fileio.c (Fcopy_file): Report error if fchown or fchmod
16408 fail (Bug#8306).
81e56e61 16409
699979fc 16410 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 16411
401bf9b4
PE
16412 * process.c (Fmake_network_process): Use socklen_t, not int,
16413 where POSIX says socklen_t is required in portable programs.
16414 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 16415 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
16416 (Fmake_network_process, server_accept_connection):
16417 (wait_reading_process_output, read_process_output):
16418 Likewise.
16419
b93aacde
PE
16420 * process.c: Rename or move locals to avoid shadowing.
16421 (list_processes_1, Fmake_network_process):
16422 (read_process_output_error_handler, exec_sentinel_error_handler):
16423 Rename or move locals.
4dc343ee 16424 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 16425 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 16426 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 16427 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 16428 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 16429
af8a867c 16430 Make tparam.h and terminfo.c consistent.
44f230aa
SM
16431 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
16432 Include tparam.h instead, since it declares them.
af8a867c
PE
16433 * cm.h (PC): Remove extern decl; tparam.h now does this.
16434 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
16435 * terminfo.c: Include tparam.h, to check interfaces.
16436 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
16437 (tparam): Adjust signature to match interface in tparam.h;
16438 this removes some undefined behavior. Check that outstring and len
16439 are zero, which they always are with Emacs.
16440 * tparam.h (PC, BC, UP): New extern decls.
16441
0248044d 16442 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 16443 (xftfont_open): Rename locals to avoid shadowing.
0248044d 16444
8ff096c1 16445 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
16446 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
16447 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 16448 (ftfont_list): Remove unused local.
49eaafba
PE
16449 (get_adstyle_property, ftfont_pattern_entity):
16450 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
16451 Rename locals to avoid shadowing.
8ff096c1 16452
e2be39f6
PE
16453 * xfont.c (xfont_list_family): Mark var as initialized.
16454
c9735e30
PE
16455 * xml.c (make_dom): Now static.
16456
8f5201ae
PE
16457 * composite.c (composition_compute_stop_pos): Rename local to
16458 avoid shadowing.
b246f932
PE
16459 (composition_reseat_it): Remove unused locals.
16460 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 16461 (composition_update_it): Mark var as initialized.
11b61122
PE
16462 (find_automatic_composition): Mark vars as initialized,
16463 with a FIXME (Bug#8290).
8f5201ae 16464
760fbc2c
PE
16465 character.h: Rename locals to avoid shadowing.
16466 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
16467 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
16468 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
16469 (BUF_DEC_POS): Be more systematic about renaming local temporaries
16470 to avoid shadowing.
16471
ff08eb85
PE
16472 * textprop.c (property_change_between_p): Remove; unused.
16473
fc7bf025
PE
16474 * intervals.c (interval_start_pos): Now static.
16475
235d7abc
PE
16476 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
16477
44f230aa
SM
16478 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
16479 Rename locals to avoid shadowing.
3e7d6594 16480
50060332
PE
16481 * sound.c (wav_play, au_play, Fplay_sound_internal):
16482 Fix pointer signedness.
d01f234b 16483 (alsa_choose_format): Remove unused local var.
c83b8872
PE
16484 (wav_play): Initialize a variable to 0, to prevent undefined
16485 behavior (Bug#8278).
50060332 16486
c4fc4e30
PE
16487 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
16488
918436ed
PE
16489 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
16490
c939f91b
PE
16491 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
16492 clobbering (Bug#8298).
b9c7f648
PE
16493 * sysdep.c (sys_subshell): Likewise.
16494 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 16495
6bd8c144
PE
16496 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
16497 This should get cleaned up, so that child_setup has the
16498 same signature on all platforms.
16499
7710357c 16500 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 16501 (relocate_fd): Rename locals to avoid shadowing.
7710357c 16502
c59da222
CY
165032011-03-22 Chong Yidong <cyd@stupidchicken.com>
16504
16505 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
16506 not to be necessary, and produces flickering.
16507
66b87493
GM
165082011-03-20 Glenn Morris <rgm@gnu.org>
16509
16510 * config.in: Remove file.
16511
45b6f6d5
JB
165122011-03-20 Juanma Barranquero <lekktu@gmail.com>
16513
16514 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
16515 are now in src/globals.h.
16516 (syms_of_minibuf): Remove spurious & from previous change.
16517
cd394be1 165182011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
16519
16520 * minibuf.c (completing-read-function): New variable.
16521 (completing-read-default): Rename from completing-read.
16522 (completing-read): Call completing-read-function.
16523
b14e3e21
CY
165242011-03-19 Juanma Barranquero <lekktu@gmail.com>
16525
16526 * xfaces.c (Fx_load_color_file):
16527 Read color file from absolute filename (bug#8250).
16528
f2b726e6
JB
165292011-03-19 Juanma Barranquero <lekktu@gmail.com>
16530
16531 * makefile.w32-in: Update dependencies.
16532
09f6ff02
EZ
165332011-03-17 Eli Zaretskii <eliz@gnu.org>
16534
16535 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
16536
29a6015a
PE
165372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
16538
a3a6c54e
PE
16539 Fix more problems found by GCC 4.5.2's static checks.
16540
b766f867
PE
16541 * process.c (make_serial_process_unwind, send_process_trap):
16542 (sigchld_handler): Now static.
16543
be02381c
PE
16544 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
16545 That way, the code declares only the vars that it needs.
16546 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
16547 * s/cygwin.h (PTY_ITERATION): Likewise.
16548 * s/darwin.h (PTY_ITERATION): Likewise.
16549 * s/gnu-linux.h (PTY_ITERATION): Likewise.
16550
57048744
PE
16551 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
16552 * process.c (allocate_pty): Don't declare stb unless it's needed.
16553
7914961c 16554 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
16555 (CONSTANTLIM): Remove; unused.
16556 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
16557 Define only if needed.
7914961c 16558
b3967b18
PE
16559 * unexelf.c (unexec): Name an expression,
16560 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
16561 Use a different way to cause a compilation error if anyone uses
16562 n rather than nn, a way that does not involve shadowing.
73366a00 16563 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 16564
29a6015a
PE
16565 * deps.mk (unexalpha.o): Remove; unused.
16566
43cfc33e 16567 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 16568 * unexec.h: New file.
ce701a33
PE
16569 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
16570 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
16571 Depend on unexec.h.
16572 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
16573 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
16574 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 16575 Change as necessary to match prototype in unexec.h.
ce701a33 16576
01f44d5a
PE
16577 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
16578 shadowing.
4f63c6bb 16579 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 16580
a6670b0b
PE
16581 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
16582 Rename locals to avoid shadowing.
16583
cef2010d 16584 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 16585 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 16586
d4d7173a
PE
16587 * print.c (Fredirect_debugging_output): Fix pointer signedess.
16588
f08b802a
PE
16589 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
16590 warning when compiling print.c.
16591
3ddb0639
PE
16592 * font.c (font_unparse_fcname): Abort in an "impossible" situation
16593 instead of using an uninitialized var.
5ad03b97 16594 (font_sort_entities): Mark var as initialized.
3ddb0639 16595
170a2692
PE
16596 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
16597
e663c700
PE
16598 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
16599 pointers to constants.
89bc529a 16600 (font_parse_fcname): Remove unused vars.
7b81e2d0 16601 (font_delete_unmatched): Now static.
ea838e10 16602 (font_get_spec): Remove; unused.
13a547c6
PE
16603 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
16604 (font_update_drivers, Ffont_get_glyphs, font_add_log):
16605 Rename or move locals to avoid shadowing.
e663c700 16606
2a80c887 16607 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 16608 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 16609
1384fa33 16610 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 16611 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 16612
8b2c52e9
PE
16613 * alloc.c (mark_backtrace): Move decl from here ...
16614 * lisp.h: ... to here, so that it can be checked.
16615
475545b5 16616 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 16617 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
16618 (lisp_indirect_variable): Name an expression,
16619 to avoid gcc -Wbad-function-cast warning.
1faed8ae 16620 (Fdefvar): Rename locals to avoid shadowing.
475545b5 16621
b1349114 16622 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 16623 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 16624 Use const pointer when appropriate.
b1349114 16625
a2928364
PE
16626 * lisp.h (get_system_name, get_operating_system_release):
16627 Move decls here, to check interfaces.
16628 * process.c (get_operating_system_release): Move decl to lisp.h.
16629 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
16630 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
16631 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
16632 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
16633 (Fformat_time_string, Fencode_time, Finsert_char):
16634 (Ftranslate_region_internal, Fformat):
16635 Rename or remove local vars to avoid shadowing.
9710023e 16636 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 16637
a415e694
PE
16638 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
16639 avoid shadowing.
16640
8ef4622d
PE
16641 * lisp.h (eassert): Check that the argument compiles, even if
16642 ENABLE_CHECKING is not defined.
16643
946f9a5b
PE
16644 * data.c (Findirect_variable): Name an expression, to avoid
16645 gcc -Wbad-function-cast warning.
112396d6 16646 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 16647 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
16648 (Fmake_variable_buffer_local, Fmake_local_variable):
16649 Mark variables as initialized.
52746918 16650 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 16651
e5aab7e7 16652 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
16653 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
16654 Rename locals to avoid shadowing.
dff45157
PE
16655 (mark_stack): Move local variables into the #ifdef region where
16656 they're used.
7bc26fdb
PE
16657 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
16658 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
16659 needed otherwise.
16660 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
16661 (GC_STRING_CHARS): Remove; not used.
d40d4be1 16662 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 16663
e5aab7e7
PE
16664 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
16665 avoids undefined behavior in theory.
16666
4da60324
PE
16667 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
16668
88043301
PE
16669 Use functions, not macros, for up- and down-casing (Bug#8254).
16670 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16671 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
16672 to use the following functions instead of these macros.
16673 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
16674 EMACS_INT, since callers assume the returned value fits in int.
16675 (upcase1): Likewise, for UPCASE_TABLE.
16676 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 16677 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 16678 the race-condition problem in the old DOWNCASE.
88043301 16679
19ed5445
PE
16680 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
16681 Rename locals to avoid shadowing.
16682 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
16683 (regex_compile, re_search_2, re_match_2_internal):
16684 Remove unused local vars.
952db0d7
PE
16685 (FREE_VAR): Rewrite so as not to use empty "else",
16686 which gcc can warn about.
da053e48 16687 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
16688 (RETALLOC_IF): Define only if needed.
16689 (WORDCHAR_P): Likewise. This one is never needed, but is used
16690 only in a comment talking about a compiler bug, so put inside
16691 the #if 0 of that comment.
16692 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
16693 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
16694 Remove; unused.
19ed5445 16695
1f3561e4 16696 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
16697 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
16698 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 16699
ded6f8f7
PE
16700 * search.c (simple_search): Remove unused var.
16701
dbd37a95
PE
16702 * dired.c (compile_pattern): Move decl from here ...
16703 * lisp.h: ... to here, so that it can be checked.
16704 (struct re_registers): New forward decl.
16705
7e47afad
PE
16706 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
16707
85f24f61
PE
16708 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
16709 All uses changed.
16710 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
16711 Rename locals to avoid shadowing.
5671df8f 16712 (Fvertical_motion): Mark locals as initialized.
85f24f61 16713
181aa2be 16714 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 16715 (casify_region): Mark local as initialized.
181aa2be 16716
930d429c
PE
16717 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
16718
7082eac6
PE
16719 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
16720 New macros, so that the caller can use some names other than
16721 gcpro1, gcpro2, etc.
16722 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
16723 of the new macros.
16724 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
16725 argument, for consistency with GCPRO2_VAR, etc: it is now the
16726 prefix of the variable, not the variable itself. All uses
16727 changed.
38b2c076
PE
16728 * dired.c (directory_files_internal, file_name_completion):
16729 Rename locals to avoid shadowing.
16730
15206ed9
PE
16731 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
16732 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
16733 dired.c's scmp function, had undefined behavior.
16734 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16735 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
16736 * buffer.h: ... to here, because these macros use current_buffer,
16737 and the new implementation with inline functions needs to have
16738 current_buffer in scope now, rather than later when the macros
16739 are used.
16740 (downcase, upcase1): New static inline functions.
16741 (DOWNCASE, UPCASE1): Reimplement using these functions.
16742 This avoids undefined behavior in expressions like
16743 DOWNCASE (x) == DOWNCASE (y), which previously suffered
16744 from race conditions in accessing the global variables
16745 case_temp1 and case_temp2.
16746 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
16747 * lisp.h (case_temp1, case_temp2): Remove their decls.
16748 * character.h (ASCII_CHAR_P): Move from here ...
16749 * lisp.h: ... to here, so that the inline functions mentioned
16750 above can use them.
16751
4a6bea26
PE
16752 * dired.c (directory_files_internal_unwind): Now static.
16753
f14b7e14
PE
16754 * fileio.c (file_name_as_directory, directory_file_name):
16755 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
16756 Now static.
2893f146
PE
16757 (file_name_as_directory): Use const pointers when appropriate.
16758 (Fexpand_file_name): Likewise. In particular, newdir might
16759 point at constant storage, so make it a const pointer.
fd4ead52 16760 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
16761 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
16762 signedness issues.
f839df0c
PE
16763 (Fset_file_times, Finsert_file_contents, auto_save_error):
16764 Rename locals to avoid shadowing.
f14b7e14 16765
5716756e 16766 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
16767 (Ftry_completion, Fall_completions): Rename or remove locals
16768 to avoid shadowing.
5716756e 16769
b4c3046a
PE
16770 * marker.c (bytepos_to_charpos): Remove; unused.
16771
b45db522
PE
16772 * lisp.h (verify_bytepos, count_markers): New decls,
16773 so that gcc does not warn that these functions aren't declared.
16774
85876d07
PE
16775 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
16776 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 16777 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 16778 (copy_text): Remove unused local var.
85876d07 16779
03d78a21 16780 * filelock.c (within_one_second): Now static.
b3dd38ab 16781 (lock_file_1): Rename local to avoid shadowing.
03d78a21 16782
5df8f01b
PE
16783 * buffer.c (fix_overlays_before): Mark locals as initialized.
16784 (fix_start_end_in_overlays): Likewise. This function should be
16785 simplified by using pointers-to-pointers, but that's a different
16786 matter.
b1d876f1 16787 (switch_to_buffer_1): Now static.
8f54f30a
PE
16788 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
16789 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 16790
a70072c9 16791 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 16792 Fix pointer signedness issue.
edced198
PE
16793 (sys_subshell): Mark local as volatile if checking for lint,
16794 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 16795 (MAXPATHLEN): Define only if needed.
a70072c9 16796
a0977c44
PE
16797 * process.c (serial_open, serial_configure): Move decls from here ...
16798 * systty.h: ... to here, so that they can be checked.
16799
a884fdcc
PE
16800 * fns.c (get_random, seed_random): Move extern decls from here ...
16801 * lisp.h: ... to here, so that they can be checked.
16802
604efe86 16803 * sysdep.c (reset_io): Now static.
b8950c94 16804 (wait_for_termination_signal): Remove; unused.
604efe86 16805
38fc62d9
PE
16806 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
16807 (copy_keymap_item, append_key, push_text_char_description):
16808 Now static.
1004a21a 16809 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 16810 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
16811 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
16812 (describe_map_tree):
16813 Rename locals to avoid shadowing.
38fc62d9 16814
2f2650da
PE
16815 * keyboard.c: Declare functions static if they are not used elsewhere.
16816 (echo_char, echo_dash, cmd_error, top_level_2):
16817 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
16818 (read_char, kbd_buffer_get_event, make_lispy_position):
16819 (make_lispy_event, make_lispy_movement, apply_modifiers):
16820 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
16821 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
16822 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 16823 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 16824 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 16825
a053e86c 16826 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
16827 (mark_kboards): Move decl here ...
16828 * alloc.c (mark_kboards): ... from here.
a053e86c 16829
4752793e
PE
16830 * lisp.h (force_auto_save_soon): New decl.
16831
74f10ca7 16832 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
16833 (DEFINE_DUMMY_FUNCTION): New macro.
16834 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
16835 Use it.
c03cd23f
PE
16836 (main): Add casts to avoid warnings
16837 if GCC considers string literals to be constants.
74f10ca7 16838
022e70d4
PE
16839 * lisp.h (fatal_error_signal): Add decl, since it's exported.
16840
59d6fe83
PE
16841 * dbusbind.c: Pointer signedness fixes.
16842 (xd_signature, xd_append_arg, xd_initialize):
16843 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16844 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16845 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
16846 (Fdbus_register_signal): Use SSDATA when the context wants char *.
16847
78320123
PE
16848 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
16849 if GCC considers string literals to be constants.
49cebcca 16850 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 16851
35ac2a97
SM
168522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
16853
fb103ca9
SM
16854 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
16855 (print_preprocess, print_object): New macro to fix last change.
16856
35ac2a97
SM
16857 * print.c (print_preprocess): Don't forget font objects.
16858
62973b41
JB
168592011-03-16 Juanma Barranquero <lekktu@gmail.com>
16860
16861 * emacs.c (USAGE3): Doc fixes.
16862
0e48bb22
AS
168632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
16864
16865 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
16866 structure.
16867
7684e57b
JB
168682011-03-14 Juanma Barranquero <lekktu@gmail.com>
16869
16870 * lisp.h (VWindow_system, Qfile_name_history):
16871 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
16872 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
16873 (w32_system_caret_x, w32_system_caret_y): Declare extern.
16874
16875 * w32select.c: Don't #include "keyboard.h".
c96bbc66 16876 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
16877
16878 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
16879 * w32console.c (detect_input_pending, read_input_pending)
16880 (encode_terminal_code):
16881 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
16882 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
16883 (w32_system_caret_y, Qfile_name_history):
16884 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
16885 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
16886 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
16887 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
16888 * w32proc.c (Qlocal, report_file_error):
16889 * w32term.c (Vwindow_system, updating_frame):
16890 * w32uniscribe.c (initialized, uniscribe_font_driver):
16891 Remove unneeded extern declarations.
16892
2aa46d6c
CY
168932011-03-14 Chong Yidong <cyd@stupidchicken.com>
16894
c96bbc66 16895 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 16896
cffc6f3b
CY
168972011-03-13 Chong Yidong <cyd@stupidchicken.com>
16898
16899 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
16900 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
16901 These macros can no longer be used for assignment.
16902
44f230aa
SM
16903 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
16904 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
16905 (record_buffer_markers, fetch_buffer_markers): New functions for
16906 recording and fetching special buffer markers.
16907 (set_buffer_internal_1, set_buffer_temp): Use them.
16908
16909 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
16910
16911 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
16912
16913 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
16914 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
16915
16916 * xdisp.c (hscroll_window_tree):
16917 (reconsider_clip_changes): Use PT instead of BUF_PT.
16918
d251f04b
EZ
169192011-03-13 Eli Zaretskii <eliz@gnu.org>
16920
16921 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
16922 $(EMACS_ROOT)/lib/intprops.h.
16923
f0c77cd1
PE
169242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
16925
3eca4629
PE
16926 Fix more problems found by GCC 4.5.2's static checks.
16927
7c86ee98
PE
16928 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
16929 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
16930 (xg_free_frame_widgets): Make it clear that a local variable is
16931 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
16932 (gdk_window_get_screen): Make it clear that this macro is needed
16933 only if USE_GTK_TOOLTIP.
1e5524e7
PE
16934 (int_gtk_range_get_value): New function, which avoids a diagnostic
16935 from gcc -Wbad-function-cast.
16936 (xg_set_toolkit_scroll_bar_thumb): Use it.
16937 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
16938 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
16939 (get_utf8_string, xg_get_file_with_chooser):
16940 Rename locals to avoid shadowing.
16941 (create_dialog): Move locals to avoid shadowing.
7c86ee98 16942
41729b81
PE
16943 * xgselect.c (xg_select): Remove unused var.
16944
f0c77cd1
PE
16945 * image.c (four_corners_best): Mark locals as initialized.
16946 (gif_load): Initialize transparent_p to zero (Bug#8238).
16947 Mark another local as initialized.
ec6cf4c6 16948 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16949
ce0ad53d 16950 * image.c (clear_image_cache): Now static.
d5d5a617 16951 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16952 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16953 (x_edge_detection): Remove unnecessary cast that
16954 gcc -Wbad-function-cast diagnoses.
2037898d 16955 (gif_load): Fix pointer signedness.
6ae141d6
PE
16956 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16957 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16958
33383987 169592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16960
d32df629
PE
16961 Improve quality of tests for time stamp overflow.
16962 For example, without this patch (encode-time 0 0 0 1 1
16963 1152921504606846976) returns the obviously-bogus value (-948597
16964 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16965 reports time overflow. See
16966 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16967 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16968 * editfns.c: Include limits.h and intprops.h.
16969 (TIME_T_MIN, TIME_T_MAX): New macros.
16970 (time_overflow): Move earlier, to before first use.
16971 (hi_time, lo_time): New functions, for an accurate test for
16972 out-of-range times.
16973 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16974 (Fget_internal_run_time): Don't assume time_t fits in int.
16975 (make_time): Use list2 instead of Fcons twice.
16976 (Fdecode_time): More accurate test for out-of-range times.
16977 (check_tm_member): New function.
16978 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16979 (lisp_time_argument): Don't rely on undefined left-shift and
16980 right-shift behavior when checking for time stamp overflow.
8be6f318 16981
fe31d94c
PE
16982 * editfns.c (time_overflow): New function, refactoring common code.
16983 (Fformat_time_string, Fdecode_time, Fencode_time):
16984 (Fcurrent_time_string): Use it.
16985
8be6f318
PE
16986 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16987 * dired.c (make_time): Move to ...
16988 * editfns.c (make_time): ... here.
16989 * systime.h: Note the move.
16990
09d9db2c 169912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16992
126bc0dc
YM
16993 * fringe.c (update_window_fringes): Remove unused variables.
16994
c47cbdfd
YM
16995 * unexmacosx.c (copy_data_segment): Also copy __got section.
16996 (Bug#8223)
16997
7ac80be9
EZ
169982011-03-12 Eli Zaretskii <eliz@gnu.org>
16999
c96bbc66 17000 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
17001 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
17002 Constify `char *' arguments and their references according to
17003 prototypes in tparam.h.
17004
ecb0f94d 17005 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 17006
7ac80be9
EZ
17007 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
17008 Adapt all references accordingly.
17009
17010 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
17011
ef1fd07e
TT
170122011-03-11 Tom Tromey <tromey@redhat.com>
17013
17014 * buffer.c (syms_of_buffer): Remove obsolete comment.
17015
7ef4b50c
EZ
170162011-03-11 Eli Zaretskii <eliz@gnu.org>
17017
17018 * termhooks.h (encode_terminal_code): Declare prototype.
17019
17020 * msdos.c (encode_terminal_code): Don't declare prototype.
17021
17022 * term.c (encode_terminal_code): Now external again, used by
17023 w32console.c and msdos.c.
17024
44f230aa
SM
17025 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
17026 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 17027
4b1ec863 170282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 17029
1714f52b 17030 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 17031
4b1ec863
PE
17032 * fringe.c (update_window_fringes): Mark locals as initialized
17033 (Bug#8227).
17034 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 17035
524c7aa6
PE
17036 * alloc.c (mark_fringe_data): Move decl from here ...
17037 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
17038 to check its interface.
17039 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
17040
a5c0af81 17041 * fontset.c (free_realized_fontset): Now static.
7519b8cd 17042 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 17043 (fontset_font): Mark local as initialized.
a9a06e0b 17044 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 17045
b4716021
PE
17046 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
17047
811e9bac 17048 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 17049 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
17050 (x_own_selection, Fx_disown_selection_internal): Rename locals
17051 to avoid shadowing.
17052 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 17053
7e3ab302
PE
17054 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
17055 so that the caller can use some name other than gcpro1.
17056 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
17057 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17058 (Fx_backspace_delete_keys_p):
17059 Use them to avoid shadowing, and rename vars to avoid shadowing.
17060 (x_decode_color, x_set_name, x_window): Now static.
6b437900 17061 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 17062 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
17063 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
17064 Remove unused locals.
7e3ab302
PE
17065 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17066 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
17067 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
17068 macros.
f78faa98 17069
e2b13473
PE
17070 * xterm.h (x_mouse_leave): New decl.
17071
77f23912
PE
17072 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
17073 Remove unused functions.
cdf4ba58
PE
17074 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
17075 (x_calc_absolute_position): Now static.
7411c686 17076 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 17077 Don't declare local "event" unless it's used.
ed7bf3a5
PE
17078 (x_iconify_frame, x_free_frame_resources): Don't declare locals
17079 unless they are used.
38d0b34a
PE
17080 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
17081 (x_fatal_error_signal): Remove; not used.
a6067996
PE
17082 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
17083 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17084 (x_error_catcher, x_connection_closed, x_error_handler):
17085 (x_error_quitter, xembed_send_message, x_iconify_frame):
17086 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17087 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17088 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17089
44f230aa
SM
17090 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17091 Rename or move locals to avoid shadowing.
6b463e58 17092 (tty_defined_color, merge_face_heights): Now static.
5967d051 17093 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17094 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17095 does not deduce is never used uninitialized.
73719eba
PE
17096 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17097 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17098
426994c3 17099 * terminal.c (store_terminal_param): Now static.
5489860b 17100
032f1620 17101 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17102 (set_frame_menubar): Remove unused local.
d4323972 17103 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17104 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17105 since they might point to immutable storage.
281585b0
PE
17106 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17107 since it's unused otherwise.
032f1620 17108
367c19e5 17109 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17110 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17111 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17112 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17113 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17114 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17115 does not deduce are never used uninitialized.
70739cbe 17116
07b48fa9
PE
17117 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17118
8868a238 17119 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17120 * window.c (window_loop, size_window):
17121 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17122
7e5cf297 17123 * window.c (display_buffer): Now static.
d6550a9f
PE
17124 (size_window): Mark variables that gcc -Wuninitialized
17125 does not deduce are never used uninitialized.
a586633d
PE
17126 * window.h (check_all_windows): New decl, to forestall
17127 gcc -Wmissing-prototypes diagnostic.
5b555da1 17128 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17129
f6095868
PE
17130 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17131 shadowing.
17132 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17133 Include <limits.h>.
17134 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17135 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17136 (load_charset_map): Mark variables that gcc -Wuninitialized
17137 does not deduce are never used uninitialized.
53df7c11 17138 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17139
f38b440c
PE
17140 * coding.c (coding_set_source, coding_set_destination):
17141 Use "else { /* comment */ }" rather than "else /* comment */;"
17142 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17143 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17144 a block, when the outer 'i' will do.
17145 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17146 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17147 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17148 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17149 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17150 Rename locals to avoid shadowing.
17151 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17152 * coding.c (emacs_mule_char, encode_invocation_designation):
17153 Now static, since they're not used elsewhere.
413bb2db 17154 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17155 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17156 (decode_coding_emacs_mule): Mark variables that gcc
17157 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17158 (detect_coding_iso_2022): Initialize a local variable that might
17159 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17160 this initialization is needed. (Bug#8211)
5f58e762
PE
17161 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17162 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17163 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17164 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17165 Remove unused macros.
f38b440c 17166
232b38b9 17167 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17168 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17169 * character.c (string_count_byte8): Likewise.
232b38b9 17170
fb90da1b
PE
17171 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17172 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17173
fb93dbc2
PE
17174 * chartab.c (copy_sub_char_table): Now static, since it's not used
17175 elsewhere.
5c156ace
PE
17176 (sub_char_table_ref_and_range, char_table_ref_and_range):
17177 Rename locals to avoid shadowing.
bbcd0949 17178 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17179
7d3b3862 17180 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17181 (BIDI_BOB): Remove unused macro.
7d3b3862 17182
6be7d3da
PE
17183 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17184 deduce are never used uninitialized.
c2ed9c8b 17185 * term.c (encode_terminal_code): Likewise.
6be7d3da 17186
75f8807f 17187 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17188
50938595
PE
17189 * tparam.h: New file.
17190 * term.c, tparam.h: Include it.
17191 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17192 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17193 Move these decls to tparam.h, and make them agree with what
17194 is actually in tparam.c. The previous trick of using incompatible
17195 decls in different modules does not conform to the C standard.
17196 All callers of tparam changed to use tparam's actual API.
17197 * tparam.c (tparam1, tparam, tgoto):
17198 Use const pointers where appropriate.
17199
fbceeba2
PE
17200 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17201 * cm.h (struct cm): Likewise.
17202 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17203 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17204 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17205 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17206 (turn_on_face, init_tty): Likewise.
17207 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17208
7f3f1250
PE
17209 * term.c (term_mouse_position): Rename local to avoid shadowing.
17210
e6ca6543
PE
17211 * alloc.c (mark_ttys): Move decl from here ...
17212 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17213
c40f8d15
AS
172142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17215
17216 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17217
cfe0661d
JB
172182011-03-09 Juanma Barranquero <lekktu@gmail.com>
17219
17220 * search.c (compile_pattern_1): Remove argument regp, unused since
17221 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17222 (compile_pattern): Don't pass it.
17223
0afb4571
J
172242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17225
17226 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17227 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17228 for ! HAVE_GTK3.
17229 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17230
17231 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17232
17233 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17234 gdk_window_get_screen, gdk_window_get_geometry,
17235 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17236 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17237 (xg_get_pixbuf_from_pixmap): New function.
17238 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17239 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17240 Call xg_get_pixbuf_from_pixmap instead of
17241 gdk_pixbuf_get_from_drawable.
17242 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17243 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17244 (xg_check_special_colors): Use GtkStyleContext and its functions
17245 for HAVE_GTK3.
17246 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17247 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17248 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17249 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17250 Call gtk_widget_get_preferred_size.
0afb4571
J
17251 (xg_frame_resized): gdk_window_get_geometry only takes 5
17252 parameters.
44f230aa
SM
17253 (xg_win_to_widget, xg_event_is_for_menubar):
17254 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17255 (xg_set_widget_bg): New function.
17256 (delete_cb): New function.
895009e1 17257 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17258 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17259 (xg_set_background_color): Call xg_set_widget_bg.
17260 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17261 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17262 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17263 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17264 if ! HAVE_GTK3.
17265 (update_frame_tool_bar): Call gtk_widget_hide.
17266 (xg_initialize): Use GDK_KEY_g.
17267
17268 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17269 if ! HAVE_GTK3
17270 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17271
17272 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17273 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17274 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17275
1c2cc4ef
JB
172762011-03-08 Juanma Barranquero <lekktu@gmail.com>
17277
17278 * w32xfns.c (select_palette): Check success of RealizePalette against
17279 GDI_ERROR, not zero.
17280
33383987 17281See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17282
17283;; Local Variables:
17284;; coding: utf-8
aac0c6e3
MR
17285;; End:
17286
2f097256 17287 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17288
17289 This file is part of GNU Emacs.
17290
17291 GNU Emacs is free software: you can redistribute it and/or modify
17292 it under the terms of the GNU General Public License as published by
17293 the Free Software Foundation, either version 3 of the License, or
17294 (at your option) any later version.
17295
17296 GNU Emacs is distributed in the hope that it will be useful,
17297 but WITHOUT ANY WARRANTY; without even the implied warranty of
17298 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17299 GNU General Public License for more details.
17300
17301 You should have received a copy of the GNU General Public License
17302 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.