Update Abbrevs and Dired chapters of Emacs manual.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ca22b785
AS
12011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2
3 * callint.c (Fcall_interactively): Don't truncate prompt string.
4
d048e1e6
EZ
52011-12-23 Eli Zaretskii <eliz@gnu.org>
6
7 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9 resumed from there (after widening). (Bug#10360)
d048e1e6 10
5ccaba1f
JD
112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
12
13 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
14
204ee57f
JD
152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
16
17 * nsterm.m (x_free_frame_resources): Release
18 f->output_data.ns->miniimage
19 (ns_index_color): Fix indentation. Do not retain
20 color_table->colors[i].
21
22 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
23 before returning.
24
25 * nsfns.m (x_set_background_color): Assign return value from
26 ns_index_color to face-background instead of NSColor*.
27 (ns_implicitly_set_icon_type): Fix indentation.
28 Change assignment in for loop to comparison.
29
30 * emacs.c (ns_pool): New variable.
31 (main): Assign ns_pool.
32 (Fkill_emacs): Call ns_release_autorelease_pool.
33
34 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
35 autorelease fdesc, release fdAttrs and tdict.
36 (ns_get_covering_families): Release charset.
37 (ns_findfonts): Release NSFontDescriptor created with new.
38 (ns_uni_to_glyphs): Fix indentation.
39 (setString): Release attrStr before assigning new value.
40
c803b2b7
JD
412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
42
678f4426
JD
43 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
44 and NS_IMPL_COCOA.
45 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
46 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
47
482011-12-18 David Reitter <reitter@cmu.edu>
49
5fecd5fc
JD
50 * nsterm.m (ns_term_init): Subscribe for notifications
51 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
52 to method trackingNotification in EmacsMenu.
53
54 * nsmenu.m (trackingMenu): New variable.
3771cb17 55 (trackingNotification): New method (from Aquamacs).
5fecd5fc 56 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 57 from Aquamacs (Bug#7030).
678f4426
JD
58
592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 60
c803b2b7
JD
61 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
62 (symbol_to_nsstring): Fix indentation.
63 (ns_symbol_to_pb): New function.
64 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
65 (Fns_rotate_cut_buffers_internal): Removed.
66 (Fns_store_selection_internal): Renamed from
67 Fns_store_cut_buffer_internal.
68 (ns_get_foreign_selection, Fx_own_selection_internal)
69 (Fx_disown_selection_internal, Fx_selection_exists_p)
70 (Fns_get_selection_internal, Fns_store_selection_internal): Use
71 ns_symbol_to_pb and check if return value is nil.
72 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
73 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
74 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
75 renamed to Sns_store_selection_internal.
76 (ns_handle_selection_request): Move code to Fx_own_selection_internal
77 and remove this function.
78 (ns_handle_selection_clear): Remove, never used.
79 (Fx_own_selection_internal): Move code from ns_handle_selection_request
80 here.
81
e1b01a3a
KB
822011-12-17 Ken Brown <kbrown@cornell.edu>
83
84 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
85 GID is unknown (Bug#10257).
86
2adb6e85
PE
872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
88
89 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
90 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
91 which caused a build failure on GNU/Linux IA-64. This problem was
92 introduced by my 2011-10-07 patch.
93
d1d7b339
JL
942011-12-15 Juri Linkov <juri@jurta.org>
95
96 * image.c (imagemagick_error): New function. (Bug#10112)
97 (imagemagick_load_image): Comment out `MagickSetResolution' call.
98 Use `imagemagick_error' where ImageMagick functions return
99 `MagickFalse'.
100 (Fimagemagick_types): Add `Fnreverse' to return the list in the
101 proper order.
102
100d5755
KH
1032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
104
105 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
106 fill background (Bug#8992).
107
454592a6
MR
1082011-12-13 Martin Rudalics <rudalics@gmx.at>
109
110 * window.c (Vwindow_combination_resize)
111 (Vwindow_combination_limit): Use t instead of non-nil in
112 doc-strings.
61d4b438
MR
113 (Vrecenter_redisplay): Add first sentence of doc-string on
114 separate line.
53524d93 115 (Frecenter): Fix doc-string typo.
454592a6 116
3633e3aa
KH
1172011-12-11 Kenichi Handa <handa@m17n.org>
118
119 * coding.c (Funencodable_char_position): Pay attention to the
120 buffer text relocation (Bug#9389).
121
7b9d523a
JD
1222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
123
124 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
125 gtk_init (Bug#10100).
126
b73189c6
EZ
1272011-12-10 Eli Zaretskii <eliz@gnu.org>
128
129 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
130 IT->string is nil. (Bug#10263)
131
f7dfe5d6
JD
1322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
133
83faebb4
JD
134 * nsterm.h (x_free_frame_resources): Declare.
135
f7dfe5d6
JD
136 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
137 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
138
139 * nsterm.h (ns_get_defaults_value): Declare.
140
141 * nsterm.m (ns_default): Call ns_get_defaults_value.
142
7cd4e72c
EZ
1432011-12-09 Eli Zaretskii <eliz@gnu.org>
144
145 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
146 (Bug#10170)
147
b34d7317
YM
1482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
149
150 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
151 that where the value of an _OBJC_* symbol points to is in the .bss
152 section (Bug#10240).
153
76470ad1
KH
1542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
155
156 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 157 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 158
745fff94
KH
1592011-12-08 Kenichi Handa <handa@m17n.org>
160
161 * ftfont.c (get_adstyle_property): Fix previous change
162 (Bug#10233).
163
6e44397c
JB
1642011-12-07 Juanma Barranquero <lekktu@gmail.com>
165
166 * w32.c (init_environment): If no_site_lisp, remove site-lisp
167 dirs from the default value of EMACSLOADPATH (bug#10208).
168
7efa6272
GM
1692011-12-07 Glenn Morris <rgm@gnu.org>
170
171 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
172 installation and source directories as well. (Bug#10208)
173
f6fc4d87
CY
1742011-12-06 Chong Yidong <cyd@gnu.org>
175
176 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
177
2bf26180
GM
1782011-12-06 Glenn Morris <rgm@gnu.org>
179
180 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
181 as an error, not just -1. (Bug#10217)
182
3a6ad4f0
CY
1832011-12-05 Chong Yidong <cyd@gnu.org>
184
185 * keyboard.c (process_special_events): New function.
186 (swallow_events, Finput_pending_p): Use it (Bug#10195).
187
75a3b399
PE
1882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
189
190 * coding.c (encode_designation_at_bol): Don't use uninitialized
191 local variable (Bug#9318).
192
c3c9e25e
KH
1932011-12-05 Kenichi Handa <handa@m17n.org>
194
195 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
196 return Qnil (Bug#8046, Bug#10193).
197
5eb05ea3
KH
1982011-12-05 Kenichi Handa <handa@m17n.org>
199
200 * coding.c (encode_designation_at_bol): New args charbuf_end and
201 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
202 (coding_set_source): Return how many bytes coding->source was
203 relocated.
204 (coding_set_destination): Return how many bytes
205 coding->destination was relocated.
206 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
207 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
208
2092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
210
211 * coding.c (CODING_CHAR_CHARSET_P): New macro.
212 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
213 macro (Bug#9318).
214
2152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
216
217 The following changes are to fix Bug#9318.
218
a79703f5 219 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
220 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
221 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 222 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 223
7dbda6df
JB
2242011-12-05 Juanma Barranquero <lekktu@gmail.com>
225
226 * lisp.h (process_quit_flag): Fix external declaration.
227
6d5eb5b0
SM
2282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
229
230 Don't macro-inline non-performance-critical code.
231 * eval.c (process_quit_flag): New function.
232 * lisp.h (QUIT): Use it.
233
a0c3fad0
JD
2342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
235
236 * nsfns.m (get_geometry_from_preferences): New function.
237 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
238
6c07aac2
AS
2392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
240
241 * emacs.c (Qkill_emacs): Define.
242 (syms_of_emacs): Initialize it.
243 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
244 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
245 (quit_throw_to_read_char): Add parameter `from_signal'.
246 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
247 * lisp.h (QUIT): Call Fkill_emacs if requested.
248
c052ead4
JD
2492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
250
251 * widget.c (update_wm_hints): Return if wmshell is null.
252 (widget_update_wm_size_hints): New function.
253
254 * widget.h (widget_update_wm_size_hints): Declare.
255
256 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
257 widget_update_wm_size_hints (Bug#10104).
258
9e49252b
EZ
2592011-12-03 Eli Zaretskii <eliz@gnu.org>
260
261 * xdisp.c (handle_invisible_prop): If the invisible text ends just
262 before a newline, prepare the bidi iterator for consuming the
263 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 264 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 265
02b16839
JL
2662011-12-02 Juri Linkov <juri@jurta.org>
267
268 * search.c (Fword_search_regexp): New Lisp function created from
269 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
270 (Fword_search_backward, Fword_search_forward)
271 (Fword_search_backward_lax, Fword_search_forward_lax):
272 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
273 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
274
0068070e
SM
2752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
276
277 * fileio.c (Finsert_file_contents): Move after-change-function call
278 to before the "handled:" label, since all "goto handled" appear in
279 cases where the *-change-functions have already been properly called
280 (bug#10117).
281
3360a3fc
AS
2822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
283
284 * keyboard.c (interrupt_signal): Don't call kill-emacs when
285 waiting for input. (Bug#10169)
286
73d6c093
EZ
2872011-11-30 Eli Zaretskii <eliz@gnu.org>
288
289 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
290 verifies glyph row's hash code--we have just reallocated the
291 glyphs, so their contents can be complete garbage. (Bug#10164)
292
febe6bea
JB
2932011-11-30 Juanma Barranquero <lekktu@gmail.com>
294
295 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
296
801a4313
EZ
2972011-11-30 Eli Zaretskii <eliz@gnu.org>
298
299 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
300 attributes are tested _before_ calling verify_row_hash, to protect
301 against GCC re-ordering of the tests. (Bug#10164)
302
2b56b87e
JD
3032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
304
305 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
306
307 * xterm.c (handle_one_xevent): Only set async_visible and friends
308 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 309 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
310 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
311
dbf31225
PE
3122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
313
314 Remove GCPRO-related macros that exist only to avoid shadowing locals.
315 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
316 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
317 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
318 All uses changed to use GCPRO1 etc.
319 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
320 Revert to old implementation (i.e., before 2011-03-11).
321
1305621b
YM
3222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
323
324 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
325 of scroll runs so as to avoid assigning disabled bogus rows and
326 unnecessary graphics copy operations.
327
8c9afb46
EZ
3282011-11-27 Eli Zaretskii <eliz@gnu.org>
329
330 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
331 (snprintf) [_MSC_VER]: Redirect to _snprintf.
332 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
333 (malloc, free, realloc, calloc): Redirect to e_* only when
334 compiling Emacs.
335
336 * lisp.h (GCTYPEBITS): Move before first use.
337 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
338 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
339 this macro definition.
340
341 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
342 _MSC_VER.
343
54e9e3bf
JD
3442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
345
6d5eb5b0
SM
346 * gtkutil.c (xg_create_frame_widgets):
347 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
348 present with Gtk+ 2.0.
349
83aca1cb
PE
3502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
351
352 * fileio.c (Finsert_file_contents): Undo previous change; see
353 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
354
5b76caa4
PE
3552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
356
357 Rename locals to avoid shadowing.
358 * fileio.c (Finsert_file_contents):
359 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
360 * process.c (wait_reading_process_output):
361 Rename inner 'proc' to 'p' to avoid shadowing.
362 Indent for consistency with usual Emacs style.
363
8c535114
EZ
3642011-11-25 Eli Zaretskii <eliz@gnu.org>
365
366 * xdisp.c (redisplay_window): If cursor row is not fully visible
367 after recentering, and scroll-conservatively is set to a large
368 number, scroll window by a few more lines to make the cursor fully
369 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
370 (start_display): Don't move to the next line if the display should
371 start at a newline that is part of a display vector or an overlay
372 string. (Bug#10119)
8c535114 373
fa4fdb5c
JL
3742011-11-24 Juri Linkov <juri@jurta.org>
375
376 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
377 after the `MagickPingImage' call. (Bug#10112)
378
90ec88df
CY
3792011-11-23 Chong Yidong <cyd@gnu.org>
380
381 * window.c (Fcoordinates_in_window_p): Accept only live windows.
382
56e2e794
MR
3832011-11-23 Martin Rudalics <rudalics@gmx.at>
384
385 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
386 making another buffer current. (Bug#10114)
387
b6e64c41
GM
3882011-11-23 Glenn Morris <rgm@gnu.org>
389
390 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
391
6b21de18
CY
3922011-11-23 Chong Yidong <cyd@gnu.org>
393
394 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
395 using it (Bug#5984).
396
b12cd789
EZ
3972011-11-22 Eli Zaretskii <eliz@gnu.org>
398
399 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
400 and header-lines, as they don't have one computed for them.
401 (Bug#10098)
402
403 * .gdbinit (prow): Make displayed values more self-explaining.
404 Add row's hash code.
405
261b6fd4
LMI
4062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
407
408 * process.c (wait_reading_process_output): Fix asynchrounous
409 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 410 (wait_reading_process_output): Add comment and URL.
261b6fd4 411
e7cfd277
JD
4122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
413
414 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
415
a9b9b7f5
CY
4162011-11-21 Chong Yidong <cyd@gnu.org>
417
418 * window.c (Fnext_window, Fprevious_window): Doc fix.
419
b0d15b4f
SM
4202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
421
422 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
423
fe7a3057
JB
4242011-11-20 Juanma Barranquero <lekktu@gmail.com>
425
426 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
427
d2999b1a
MR
4282011-11-20 Martin Rudalics <rudalics@gmx.at>
429
430 * window.c (Fset_window_combination_limit): Rename argument
431 STATUS to LIMIT.
432 (Vwindow_combination_limit): Remove "status" from doc-string.
433
d5ff9cd0
AS
4342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
435
436 * m/ibms390.h: Remove.
437 * m/ibms390x.h: Don't include "ibms390.h".
438
a5bb9bd3
SM
4392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
440
441 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
442 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
443
cd1181db
JB
4442011-11-20 Juanma Barranquero <lekktu@gmail.com>
445
446 * casetab.c (Fset_case_table):
447 * charset.c (Fcharset_after): Fix typos.
448
615a3b8d 4492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 450
17e845af
PE
451 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
452 Otherwise, valgrind does not work on some platforms.
453 Problem reported by Andreas Schwab in
6a0bf43d
PE
454 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
455 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
456 is set, removing the need for VIRT_ADDRESS_VARIES.
457 (PURE_P): Use a more-efficient implementation that needs just one
458 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
459 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
460 to 4 (xorl, subq, cmpq, setbe).
461 * alloc.c (pure): Always extern now, since that's the
462 VIRT_ADDR_VARIES behavior.
463 (PURE_POINTER_P): Use a single comparison, not two, for
464 consistency with the new puresize.h.
465 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
466 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
467 Remove VIRT_ADDR_VARIES no longer needed.
468
f8fe6f96
EZ
4692011-11-19 Eli Zaretskii <eliz@gnu.org>
470
471 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
472 (erase_phys_cursor, update_window_cursor, show_mouse_face)
473 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
474 behave as if the cursor position were at the window margin.
475
476 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
477 and the cursor position is out of bounds, behave as if the cursor
478 position were at the window margin. (Bug#10075)
479
df05a53c
CY
4802011-11-18 Chong Yidong <cyd@gnu.org>
481
482 * window.c (Fwindow_combination_limit): Make first argument
483 non-optional, since it is meaningless for live windows like the
484 selected window.
485
2071918e
DA
4862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
487
488 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
489
b50a28de
SM
4902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
491
492 * intervals.c: Fix grafting over the whole buffer (bug#10071).
493 (graft_intervals_into_buffer): Simplify.
494
015137db
EZ
4952011-11-18 Eli Zaretskii <eliz@gnu.org>
496
497 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
498 hash values of the two rows.
499 (copy_row_except_pointers): Preserve the used[] arrays and the
500 hash values of the two rows. (Bug#10035)
68c95424 501 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
502
503 * xdisp.c (row_hash): New function, body extracted from
504 compute_line_metrics.
505 (compute_line_metrics): Call row_hash, instead of computing the
506 hash code inline.
507
508 * dispnew.c (verify_row_hash): Call row_hash for computing the
509 hash code of a row, instead of duplicating code from xdisp.c.
510
511 * dispextern.h (row_hash): Add prototype.
512
a2addb04
TH
5132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
514
515 * frame.c (delete_frame): Don't delete the terminal when the last
516 X frame is closed if emacs is built with GTK toolkit.
517
df85d315
JB
5182011-11-17 Juanma Barranquero <lekktu@gmail.com>
519
520 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
521
a0c2d0ae
MR
5222011-11-17 Martin Rudalics <rudalics@gmx.at>
523
524 * window.c (Vwindow_splits): Rename to
525 Vwindow_combination_resize. Suggested by Juri Linkov.
526 (Fsplit_window_internal): Use Vwindow_combination_resize instead
527 of Vwindow_splits.
528
58179cce
JB
5292011-11-16 Juanma Barranquero <lekktu@gmail.com>
530
7877f373
JB
531 * nsfns.m (Fns_font_name):
532 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 533
b6f67890
MR
5342011-11-16 Martin Rudalics <rudalics@gmx.at>
535
536 * window.h (window): Rename slot "nest" to "combination_limit".
537 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
538 (Fset_window_nest): Rename to Fset_window_combination_limit.
539 (Vwindow_nest): Rename to Vwindow_combination_limit.
540 (recombine_windows, make_parent_window, make_window)
541 (Fsplit_window_internal, saved_window)
542 (Fset_window_configuration, save_window_save): Rename all
543 occurrences of window_nest to window_combination_limit.
544
c7015153
JB
5452011-11-15 Juanma Barranquero <lekktu@gmail.com>
546
547 * image.c (imagemagick_load_image): Fix typo.
548
322ad6ec
EZ
5492011-11-14 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (display_line): Move the call to
552 highlight_trailing_whitespace before the call to
553 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
554 faces of all the glyphs to compute ROW's hash value.
555 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 556
f067b8ec
JB
5572011-11-14 Juanma Barranquero <lekktu@gmail.com>
558
559 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
560 just return (bug#10044).
561
1e5b2111
EZ
5622011-11-12 Eli Zaretskii <eliz@gnu.org>
563
7ef3cbd5
EZ
564 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
565 with user-defined heap size. Bump the default size of the temacs
566 heap to 27MB, to avoid memory warning when running temacs.
567 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
568
1e5b2111
EZ
569 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
570 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
571 (verify_row_hash) [XASSERTS]: New function.
572 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
573 that the hash value of glyph rows is correct.
1e5b2111 574
89d61221
MR
5752011-11-12 Martin Rudalics <rudalics@gmx.at>
576
577 * window.h (window): Remove splits slot.
578 * window.c (Fwindow_splits, Fset_window_splits): Remove.
579 (Fdelete_other_windows_internal, make_parent_window)
580 (make_window, Fsplit_window_internal, Fdelete_window_internal)
581 (Fset_window_configuration, save_window_save): Don't deal with
582 split status of windows.
583 (saved_window): Remove splits slot.
584 (Vwindow_splits): Rewrite doc-string.
585
97f18cc8
JD
5862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
587
588 * xfns.c (unwind_create_frame):
589 * nsfns.m (unwind_create_frame):
590 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
591 Vframe_list (Bug#9999).
592
22a648b4
DA
5932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
594
0b381c7e 595 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 596
659afede
KH
5972011-11-11 Kenichi Handa <handa@m17n.org>
598
599 * callproc.c (Fcall_process): Set the member dst_multibyte of
600 process_coding.
601
9ac0394b
KH
6022011-11-11 Johan Bockgård <bojohan@gnu.org>
603
604 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
605 avoid a crash (bug#9496).
606
2fbdc249
CY
6072011-11-09 Chong Yidong <cyd@gnu.org>
608
609 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
610 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
611
ac6b1f81
PE
6122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
613
614 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
615
09db192c
PE
6162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
617
618 Avoid some portability problems by eschewing 'extern inline' functions.
619 The trivial performance wins aren't worth the portability hassles; see
620 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
621 et seq.
622 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
623 (window_box_width, window_box_left, window_box_left_offset)
624 (window_box_right, window_box_right_offset): Undo previous change,
625 by removing the "extern"s.
626 * intervals.c (adjust_intervals_for_insertion)
627 (adjust_intervals_for_deletion): Undo previous change,
628 making these static again.
629 (offset_intervals, temp_set_point_both, temp_set_point)
630 (copy_intervals_to_string): No longer inline.
631 * xdisp.c (window_text_bottom_y, window_box_width)
632 (window_box_height, window_box_left_offset)
633 (window_box_right_offset, window_box_left, window_box_right)
634 (window_box): No longer inline.
635
105216ed
CY
6362011-11-08 Chong Yidong <cyd@gnu.org>
637
638 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
639 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
640 Signal an error if not a live window.
105216ed
CY
641 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
642 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
643
ae9e237f
JB
6442011-11-07 Juanma Barranquero <lekktu@gmail.com>
645
646 * lisp.h (syms_of_abbrev): Remove declaration.
647 Reported by CHENG Gao <chenggao@royau.me>.
648
c7aa8333
EZ
6492011-11-07 Eli Zaretskii <eliz@gnu.org>
650
651 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
652 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
653 of temacs in GUI mode.
654
be7f5545
MR
6552011-11-07 Martin Rudalics <rudalics@gmx.at>
656
657 * window.h: Declare delete_all_child_windows instead of
658 delete_all_subwindows.
659 * window.c (Fwindow_nest, Fset_window_nest)
660 (Fset_window_new_total, Fset_window_new_normal)
661 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
662 (delete_all_subwindows): Rename to delete_all_child_windows.
663 (Fdelete_other_windows_internal, Fset_window_configuration):
664 Call delete_all_child_windows instead of delete_all_subwindows.
665 * frame.c (delete_frame): Call delete_all_child_windows instead
666 of delete_all_subwindows.
667
ca78dc43
PE
6682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
669
670 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
671 This is also needed for porting to any host where GC_MARK_STACK is
672 not GC_MAKE_GCPROS_NOOPS.
673 (which_symbols): Use it.
674
a0241d01
KH
6752011-11-07 Kenichi Handa <handa@m17n.org>
676
677 * coding.c (coding_set_destination): Check coding->src_pos only
678 when coding->src_object is a buffer (bug#9910).
679
680 * process.c (send_process): Set the member src_multibyte of coding
681 to 0 (bug#9911) when sending a unibyte text.
682
683 * callproc.c (Fcall_process): Set the member src_multibyte of
684 process_coding to 0 (bug#9912).
685
a64bfdfa 6862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
687
688 * xmenu.c (cleanup_widget_value_tree): New function.
689 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
690 calling free_menubar_widget_value_tree directly (Bug#9830).
691
cb41b32a
PE
6922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
693
694 Fix some portability problems with 'inline'.
695 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
696 (window_box_width, window_box_left, window_box_left_offset)
697 (window_box_right, window_box_right_offset): Declare extern.
698 Otherwise, these inline functions do not conform to C99 and
699 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
700 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
701 * intervals.c (adjust_intervals_for_insertion)
702 (adjust_intervals_for_deletion): Now extern, because otherwise the
703 extern inline functions 'offset_intervals' couldn't refer to it.
704 (static_offset_intervals): Remove.
705 (offset_intervals): Rewrite using the old contents of
706 static_offset_intervals. The old version didn't conform to C99
707 because an extern inline function contained a reference to an
708 identifier with static linkage.
709
b7041366
AS
7102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
711
712 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
713 GC.
714
88a37c4d
EZ
7152011-11-06 Eli Zaretskii <eliz@gnu.org>
716
717 * xdisp.c (init_iterator, reseat_to_string): Don't set the
718 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
719 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
720 return Qleft_to_right.
721
49745b39
CY
7222011-11-06 Chong Yidong <cyd@gnu.org>
723
724 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
725 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
726 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
727 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
728 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
729 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
730 (Fwindow_vscroll): Doc fix.
731 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
732 argument, since it makes no sense to pass a live window and for
733 consistency with window-child.
734
1f05cd82
CS
7352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
736
737 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
738 support MSVC.
739
22610910
JR
7402011-11-05 Jason Rumney <jasonr@gnu.org>
741
742 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
743 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
744 fonts (Bug#6029).
745 (add_font_entity_to_list): Fix logic errors in mixed boolean and
746 bitwise arithmetic preventing use of unicode-sip and non-truetype
747 opentype fonts.
748
a06776b2
EZ
7492011-11-05 Eli Zaretskii <eliz@gnu.org>
750
3ad924ba
EZ
751 * s/ms-w32.h (fstat, stat, utime): Move redirections to
752 "emacs"-only part.
753
a06776b2
EZ
754 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
755 initialization code to keep similarity to xfns.c after changes
756 from 2011-11-05.
757
c9e7db78
JD
7582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
759
a97f8f3f
JD
760 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
761 (unwind_create_frame): New function (Bug#9943).
762 (Fx_create_frame): Restructure code to be more similar to the one in
763 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
764 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
765 Move terminal->reference_count++ just before making the frame official
766 (Bug#9943).
767
768 * nsterm.m (x_free_frame_resources): New function.
769 (x_destroy_window): Move code to x_free_frame_resources.
770
c9e7db78 771 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
772 (Fx_create_frame, x_create_tip_frame):
773 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
774 official. Move initialization of image_cache_refcount and
775 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
776
a6fc3b5c
EZ
7772011-11-05 Eli Zaretskii <eliz@gnu.org>
778
779 Support MSVC build with newer versions of Visual Studio.
780 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
781 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
782 nt/gmake.defs.
783
784 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
785 which are not supported by MSVC.
786 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
787 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
788 bitfields.
789 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
790 types in bitfields.
791 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
792
793 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
794
58179cce 7952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
796
797 Support MSVC build with newer versions of Visual Studio.
798 * w32.c: Don't include w32api.h for MSVC.
799 (init_environment) [_MSC_VER]: Call sys_access, not _access.
800
801 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
802 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
803 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
804 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
805 e_* cousins.
806 (alloca) [_MSC_VER]: Define to _alloca.
807
808 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
809
810 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
811
a58c13ed
EZ
8122011-11-04 Eli Zaretskii <eliz@gnu.org>
813
814 * xdisp.c (note_mouse_highlight): If either of
815 previous/next-single-property-change returns nil, treat that as
816 the beginning or the end of the buffer. (Bug#9955)
817
fe0b6370
JD
8182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
819
a58c13ed 820 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
821 label is not null (Bug#9951).
822 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
823 may be NULL.
824
89bd5ee1
EZ
8252011-11-04 Eli Zaretskii <eliz@gnu.org>
826
827 * window.c (Fwindow_body_size): Mention in the doc string that the
828 return value is in frame's canonical units. (Bug#9949)
829
84c3edb9
EZ
8302011-11-03 Eli Zaretskii <eliz@gnu.org>
831
4e2fb5c7
EZ
832 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
833
84c3edb9 834 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 835 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 836 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 837
bc17a887
EZ
8382011-11-01 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
841 Don't stop backward scan on the continuation glyph, even though
842 its CHARPOS is positive.
6d5eb5b0
SM
843 (mouse_face_from_buffer_pos, note_mouse_highlight):
844 Rename cover_string to disp_string.
bc17a887 845
4ee88440
MR
8462011-11-01 Martin Rudalics <rudalics@gmx.at>
847
848 * window.c (temp_output_buffer_show): Don't use
849 Vtemp_buffer_show_specifiers.
850 (Vtemp_buffer_show_specifiers): Remove unused variable.
851
c2ff3c02
EZ
8522011-10-30 Eli Zaretskii <eliz@gnu.org>
853
854 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
855 past the beginning of the current glyph matrix.
856
58179cce 8572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
858
859 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
860 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
861 HAVE_GTK3 (Bug#9869).
b77a6a7f 862
3b574623
JD
863 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
864 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
865
b77a6a7f
JD
866 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
867
868 * xterm.c: Declare x_handle_net_wm_state to return int.
869 (handle_one_xevent): Check if we are iconified but don't have
870 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
871 (get_current_wm_state): Return non-zero if not hidden,
872 check for _NET_WM_STATE_HIDDEN (Bug#9893).
873 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
874 (x_handle_net_wm_state): Return what get_current_wm_state returns.
875 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
876
196e41e4
PE
8772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
878
879 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
880 so that this new function doesn't get optimized away by a
881 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
882
021f2e1a
AS
8832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
884
885 * frame.h (MOUSE_HL_INFO): Remove excess parens.
886
8b058d44
EZ
8872011-10-29 Eli Zaretskii <eliz@gnu.org>
888
889 Fix the `xbytecode' command.
890 * .gdbinit (xprintbytestr): New command.
b50a28de 891 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
892 (xbytecode): Print the byte-code string as well.
893
4452fb80
EZ
8942011-10-29 Kim Storm <storm@cua.dk>
895
8b058d44
EZ
896 * alloc.c (which_symbols): New function.
897
21b72067
AS
8982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
899
900 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
901 line. (Bug#9903)
902
83ed7b5c
GM
9032011-10-29 Glenn Morris <rgm@gnu.org>
904
905 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
906 Not clear what it was for, and it causes various bugs. (Bug#9839)
907
5a7a728b
EZ
9082011-10-28 Eli Zaretskii <eliz@gnu.org>
909
910 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
911 possible random value that matches one of those tested as
912 condition to clear the mouse face.
913
d3d0842f
CY
9142011-10-28 Chong Yidong <cyd@gnu.org>
915
916 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
917
31b39d13
DN
9182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
919
920 * window.c (make_window): Initialize phys_cursor_on_p.
921
9aba6043
SM
9222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
923
924 * lisp.h (struct Lisp_Symbol): Update comments.
925
c20992f4
JB
9262011-10-28 Juanma Barranquero <lekktu@gmail.com>
927
928 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
929
db4f02f2
EZ
9302011-10-28 Eli Zaretskii <eliz@gnu.org>
931
932 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
933 <oslsachem@gmail.com> for helping to debug this.
934
935 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
936 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
937 (g_b_init_get_glyph_outline_w): New static variables.
938 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
939 (GetGlyphOutlineW_Proc): New typedefs.
940 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
941 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
942 New functions.
943 (w32font_open_internal, compute_metrics):
944 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
945 instead of calling the "wide" APIs directly.
946
947 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
948
949 * w32.h (syms_of_w32font): Add prototype.
950
87e68db4
JB
9512011-10-27 Juanma Barranquero <lekktu@gmail.com>
952
953 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
954 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
955 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
956 (Fmove_to_window_line): Doc fix.
957
435c1d67
CY
9582011-10-27 Chong Yidong <cyd@gnu.org>
959
960 * process.c (make_process): Set gnutls_state to NULL.
961
962 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
963 non-NULL, regardless of GNUTLS_INITSTAGE.
964 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
965 an error. Set process slots as soon as we allocate them.
966
967 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
968
9c6c6f49
CY
9692011-10-27 Chong Yidong <cyd@gnu.org>
970
9aba6043
SM
971 * gnutls.c (emacs_gnutls_deinit): New function.
972 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
973 (Fgnutls_deinit, Fgnutls_boot): Use it.
974
975 * process.c (make_process): Initialize GnuTLS credentials to NULL.
976 (deactivate_process): Call emacs_gnutls_deinit.
977
657d08d3
JB
9782011-10-27 Juanma Barranquero <lekktu@gmail.com>
979
980 * image.c (x_create_x_image_and_pixmap):
981 * w32.c (sys_rename, w32_delayed_load):
982 * w32font.c (fill_in_logfont):
983 * w32reg.c (x_get_string_resource): Silence compiler warnings.
984
5430d399
JB
9852011-10-26 Juanma Barranquero <lekktu@gmail.com>
986
987 * w32fns.c (w32_default_color_map): New function,
988 extracted from Fw32_default_color_map.
a7ef684b 989 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 990
fe0055fa
PE
9912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
992
993 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
994
e6346438
SM
9952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
996
997 * keyboard.c (test_undefined): New function (bug#9751).
998 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
999
e112cc37
ET
10002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1001
1002 * sysdep.c (init_sys_modes): Fix the check for the controlling
1003 terminal (Bug#6649).
1004
7b5d6677
EZ
10052011-10-20 Eli Zaretskii <eliz@gnu.org>
1006
1007 * dispextern.h (struct bidi_it): New member next_en_type.
1008
1009 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1010 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1011 current character, check also for next_en_type being WEAK_EN.
1012 (bidi_resolve_weak): Don't enter the expensive loop if the current
1013 position is before next_en_pos. Record the bidi type of the first
1014 non-ET, non-BN character we find, in addition to its position.
1015 (bidi_level_of_next_char): Invalidate next_en_type when
1016 next_en_pos is over-stepped.
1017
7da0b018
PE
10182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1021 * editfns.c: Rewrite current-time-zone so that it invokes
1022 the equivalent of (format-time-string "%Z") to get the time zone name.
1023 This fixes a bug when the time zone name contains characters that
1024 need converting from the system time locale to Emacs internal format.
1025 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1026 that patch fixed format-time-string to do the conversion, but
1027 I forgot to fix current-time-zone.
1028 (format_time_string): New function, containing most of
1029 what Fformat_time_string used to contain.
1030 (Fformat_time_string): Rewrite in terms of format_time_string.
1031 This doesn't change this function's behavior.
1032 (current-time-zone): Rewrite to use format_time_string.
1033 This fixes the bug reported by Michael Schierl in
1034 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1035 Jason Rumney's 2007-06-07 change worked around this bug, but
1036 didn't fix it.
1037 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1038
8547b010
EZ
10392011-10-19 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (start_display): If the character at POS is displayed
1042 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1043 (try_window_reusing_current_matrix): If a line ends in a display
1044 vector or the next line starts in a display vector, continue
1045 redrawing the window even though the character position of
1046 start_row was reached.
8547b010
EZ
1047 (Bug#9771, part 2)
1048
4e948d15
CY
10492011-10-18 Chong Yidong <cyd@gnu.org>
1050
1051 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1052 with nobreak-char-display too.
1053
4787455f
EZ
10542011-10-18 Eli Zaretskii <eliz@gnu.org>
1055
1056 Fix part 3 of bug#9771.
1057 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1058 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1059 non-neutral characters if the current character is a paragraph
1060 separator (a.k.a. Newline). This avoids running the same
1061 expensive loop twice, once when we consume the preceding newline
1062 and the other time when the line actually needs to be displayed.
1063 Avoid the loop when we see neutrals on the base embedding level
1064 following a character whose directionality is the same as the
1065 paragraph's. This avoids running the expensive loop when a line
1066 ends in a long sequence of neutrals, like control characters.
1067 Add assertion against STRONG_AL type. Slightly rearrange code
1068 that determines the type of a neutral given the first non-neutral
1069 that follows it.
1070 (bidi_level_of_next_char): Set next_en_pos to zero when
1071 invalidating its info.
1072
2c91f553
EZ
10732011-10-17 Eli Zaretskii <eliz@gnu.org>
1074
1075 * xdisp.c (push_display_prop): Determine whether to record string
1076 or buffer position by IT->string, not by IT->method. Allow
1077 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1078 (move_it_vertically_backward): Don't look for character position
1079 immediately after the newline when in a continuation line.
1080 (Bug#9771, part 1)
2c91f553 1081
c7b08b0d
MR
10822011-10-15 Martin Rudalics <rudalics@gmx.at>
1083
1084 * window.c (coordinates_in_window): Rewrite and delabelize
1085 vertical border check. (Bug#5357) (Bug#9618)
1086
6b02f655
SM
10872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1088
1089 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1090 errors in XSetWindowBorder (bug#9310).
1091
81d40c92
DA
10922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1095 avoid crash when xmalloc overrun checking is enabled.
1096
d4172c3b
EZ
10972011-10-13 Eli Zaretskii <eliz@gnu.org>
1098
1099 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1100 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1101 cursor motion with <left> and <right> arrow keys.
1102
1103 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1104 some callers set that themselves.
1105
b00eea75
EZ
11062011-10-12 Eli Zaretskii <eliz@gnu.org>
1107
1108 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1109 display string and the previous row comes from the same string and
1110 is empty. (Bug#9739) (Bug#9738)
1111
8fe012c4
SM
11122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1113
1114 * doc.c (get_doc_string): Encode file name (bug#9735).
1115
0074aef2
EZ
11162011-10-12 Eli Zaretskii <eliz@gnu.org>
1117
79beb178
EZ
1118 * bidi.c (bidi_level_of_next_char):
1119 * xdisp.c (get_visually_first_element): Remove old incorrect
1120 comments regarding the Unicode Line Separator character.
1121
0074aef2
EZ
1122 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1123
6e4b3fbe
DA
11242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1125
1126 * alloc.c (Fgc_status): Do not access beyond zombies array
1127 boundary if nzombies > MAX_ZOMBIES.
1128 * alloc.c (dump_zombies): Add missing format specifier.
1129
0324f3af
PE
11302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1131
b5525cac
PE
1132 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1133 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1134
0324f3af
PE
1135 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1136 Some packages use them to denote characters with modifiers.
1137
e9b5f888
AS
11382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1139
1140 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1141 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1142 matching a pp-number. Rename parameter var to var1.
1143
127827c0
SM
11442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1145
1146 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1147
c8fd3bd0
GM
11482011-10-08 Glenn Morris <rgm@gnu.org>
1149
1150 * callint.c (Fcall_interactively): Give a more explicit error for the
1151 'c' case with a non-character input. (Bug#8479)
1152
352ec8ff
EZ
11532011-10-08 Eli Zaretskii <eliz@gnu.org>
1154
03669ccb
EZ
1155 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1156 lines.
7061c986
EZ
1157 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1158 lines that are hscrolled on the left.
03669ccb 1159
352ec8ff
EZ
1160 * dispnew.c (buffer_posn_from_coords): Account for a possible
1161 presence of header-line. (Bug#4426)
1162
a66cfb1c
SM
11632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1164
6b02f655
SM
1165 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1166 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1167
7c5ee88e
PE
11682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1171 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1172 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1173 this makes Emacs dump core during garbage collection on rare
1174 occasions. sizeof is obviously inferior to offsetof here, so
1175 stick with offsetof.
1176 (GC_POINTER_ALIGNMENT): New macro.
1177 (mark_memory): Omit 3rd (offset) arg; caller changed.
1178 Don't assume EMACS_INT alignment is the same as pointer alignment.
1179
df1bbe5b
SM
11802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1181
1182 * keyboard.c (read_key_sequence_remapped): New var.
1183 (read_key_sequence): Compute remapping in the right buffer.
1184 (command_loop_1): Use read_key_sequence's remapping directly.
1185
51553db6
SM
11862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1187
32c1fffd
SM
1188 * dired.c (file_name_completion): Don't expand file name.
1189 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1190 before checking file name handler.
1191
51553db6
SM
1192 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1193 they've been requested explicitly (bug#9591).
1194
b6bd1599 11952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1196
1197 * keymap.c (Fsingle_key_description): Use make_specified_string
1198 instead of build_string to build string from push_key_description.
1199 (Bug#5193)
1200
f701dc2a
PE
12012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1202
4222c55d
PE
1203 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1204 This fixes a Y2038 bug on 64-bit hosts.
1205 * buffer.c (reset_buffer):
1206 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1207 (Fclear_buffer_auto_save_failure):
1208 Use 0, not -1, to represent an unset failure time, since time_t
1209 might not be signed.
1210
f701dc2a
PE
1211 Remove dependency on glibc malloc internals.
1212 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1213 Move back here from lisp.h, but with their new implementations.
1214 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1215 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1216 * charset.c (charset_table_init): New static var.
1217 (syms_of_charset): Use it instead of xmalloc. This removes a
1218 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1219 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1220 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1221 Move back to alloc.c.
1222 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1223 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1224
9ceebf39
JD
12252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1226
1227 * nsterm.m (windowDidResize): Call x_set_window_size only when
1228 ns_in_resize is true. Otherwise set pixelwidth/height and
1229 call change_frame_size (Bug#9628).
1230
cb993c58
PE
12312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1232
3930c88b
PE
1233 Port --enable-checking=all to Fedora 14 x86-64.
1234 * charset.c (syms_of_charset): Also account for glibc malloc's
1235 internal overhead when calculating the initial malloc maximum.
1236
cb993c58
PE
1237 Port --enable-checking=all to Fedora 14 x86.
1238 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1239 Move to lisp.h.
1240 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1241 (overrun_check_realloc, overrun_check_free):
1242 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1243 That way, xmalloc returns a properly-aligned pointer even if
1244 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1245 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1246 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1247 into account when calculating the initial malloc maximum.
1248 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1249 Move here from alloc.c, so that charset.c can use it too.
1250 Properly align; the old code wasn't right for common 32-bit hosts
1251 when configured with --enable-checking=all.
1252 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1253 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1254
31bed486
EZ
12552011-09-29 Eli Zaretskii <eliz@gnu.org>
1256
04c70788 1257 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1258 use EDOM.
1259
fbcaa2f3
EZ
12602011-09-28 Eli Zaretskii <eliz@gnu.org>
1261
1262 * xdisp.c (compute_display_string_end): If there's no display
1263 string at CHARPOS, return -1.
1264
1265 * bidi.c (bidi_fetch_char): When compute_display_string_end
1266 returns a negative value, treat the character as a normal
1267 character not covered by a display string. (Bug#9624)
1268
a239d4e9
JB
12692011-09-28 Juanma Barranquero <lekktu@gmail.com>
1270
1271 * lread.c (Fread_from_string): Fix typo in docstring.
1272
88652fd5
EZ
12732011-09-27 Eli Zaretskii <eliz@gnu.org>
1274
1275 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1276 newline, reseat the iterator instead of bidi-iterating there one
1277 character at a time. (Bug#9610)
32c1fffd
SM
1278 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1279 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1280
ed497dd4
AS
12812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1282
1283 * lread.c (readevalloop): Use correct code for NBSP.
1284 (read1): Likewise. (Bug#9608)
1285
b2bf61aa
MA
12862011-09-25 Michael Albinus <michael.albinus@gmx.de>
1287
1288 * dbusbind.c (Fdbus_register_signal): When service is not
1289 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1290
32bbb17c
GM
12912011-09-25 Glenn Morris <rgm@gnu.org>
1292
1293 * buffer.c (truncate-lines): Doc fix.
1294
94e0933e
CY
12952011-09-24 Chong Yidong <cyd@stupidchicken.com>
1296
1297 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1298 (Fset_window_next_buffers): Doc fix.
1299
cddde921
GM
13002011-09-24 Glenn Morris <rgm@gnu.org>
1301
1302 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1303
1260aef1
PE
13042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1305
25b4bfa0
PE
1306 Fix minor problems found by static checking.
1307 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1308 * indent.c (Fvertical_motion): Fix == vs = typo.
1309
e3cbd34b
EZ
13102011-09-24 Eli Zaretskii <eliz@gnu.org>
1311
a66cfb1c
SM
1312 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1313 Default value is now t. Doc fix.
6bf7006f 1314
e3cbd34b 1315 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1316 logic when moving up, not only when moving down. Fix the
e3cbd34b 1317 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1318 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1319
1320 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1321 CHARPOS is covered by a display string which includes newlines.
1322 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1323 is covered by a display string with embedded newlines.
1324
a3de0cbd
MA
13252011-09-24 Michael Albinus <michael.albinus@gmx.de>
1326
1327 * dbusbind.c (Fdbus_register_signal): Add match rule to
1328 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1329 (Fdbus_register_method, Vdbus_registered_objects_table):
1330 Fix docstring.
a3de0cbd 1331
b260039d
JM
13322011-09-24 Jim Meyering <meyering@redhat.com>
1333
32c1fffd 1334 do not ignore write error for any output size
b260039d
JM
1335 The previous change was incomplete.
1336 While it makes emacs --batch detect the vast majority of stdout
1337 write failures, errors were still ignored whenever the output size is
1338 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1339 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1340 && echo FAIL: ignored write error
1341 FAIL: ignored write error
1342 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1343 && echo FAIL: ignored write error
1344 FAIL: ignored write error
1345 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1346
8eca8a7c
AS
13472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1348
1349 * emacs.c (Fkill_emacs): In noninteractive mode exit
1350 non-successfully if a write error occurred on stdout. (Bug#9574)
1351
3341db62
EZ
13522011-09-21 Eli Zaretskii <eliz@gnu.org>
1353
1354 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1355 the xassert test.
1356
1357 * dispextern.h (struct it): Update the comment documenting what
1358 can it->OBJECT be.
1359
8c203dbf
EZ
13602011-09-20 Eli Zaretskii <eliz@gnu.org>
1361
1362 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1363 a display string, extend search for cursor position to end of row.
1364 (find_row_edges): If the row ends in a newline from a display
1365 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1366 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1367 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1368 non-empty line. Fixes confusing cursor motion with arrow keys at
1369 the beginning of a line that starts with whitespace.
8c203dbf 1370
a4824228
LMI
13712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1372
1373 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1374 (bug#9493).
1375
33ed493b
CY
13762011-09-18 Chong Yidong <cyd@stupidchicken.com>
1377
1378 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1379 boolean (Bug#9154).
1380
56cd55c8
EZ
13812011-09-18 Eli Zaretskii <eliz@gnu.org>
1382
1383 * xdisp.c (display_line): Record maximum and minimum buffer
1384 positions even if no glyphs were produced (e.g., by a zero-width
1385 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1386 buffer positions that will be removed from the glyph row because
1387 they don't fit.
c02dcedf
EZ
1388 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1389 column is beyond frame width: don't subtract 1 "pixel" when
1390 computing width of the stretch.
3e62b7e0
EZ
1391 (reseat_at_next_visible_line_start): Undo the change made on
1392 2011-09-17 that saved paragraph information and restored it after
1393 the call to `reseat'. (Bug#9545)
56cd55c8 1394
5ed99d36 13952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1396
1397 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1398 and turn window cursor on if cleared (Bug#9415).
1399
5ed99d36 14002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1401
1402 * search.c (boyer_moore): Take unibyte characters from pattern
1403 literally. (Bug#9458)
1404
9bade7b2
EZ
14052011-09-18 Eli Zaretskii <eliz@gnu.org>
1406
1407 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1408
e5e9d610
PE
14092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1410
87e4427a
PE
1411 Fix minor problem found by static checking.
1412 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1413 initialized, to pacify gcc -Wuninitialized.
1414
e5e9d610
PE
1415 * fileio.c: Report proper errno when syscall falls.
1416 (Finsert_file_contents): Save and restore errno,
1417 so that report_file_error outputs the correct diagnostic.
1418 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1419
a1674f0b
EZ
14202011-09-18 Eli Zaretskii <eliz@gnu.org>
1421
1422 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1423
fbfb6dd4
EZ
14242011-09-17 Eli Zaretskii <eliz@gnu.org>
1425
1426 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1427 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1428
bb187662
EZ
14292011-09-17 Eli Zaretskii <eliz@gnu.org>
1430
1137e8b8 1431 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1432 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1433
1434 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1435 (bidi_find_paragraph_start): Search back for paragraph beginning
1436 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1437 (bidi_move_to_visually_next): Only trigger paragraph-related
1438 computations when the last character is a newline or at EOB, not
1439 just any NEUTRAL_B. (Bug#9470)
1440
bb187662
EZ
1441 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1442 truncated lines if point is covered by a display string. (Bug#9524)
1443
2e621251
PE
14442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1447 (cons_to_x_long): New function.
1448 (lisp_data_to_selection_data): Use it. Correct the test for
1449 short-versus-long data; it was negated. Break out of vector
1450 loop, for efficiency, when a long datum is discovered.
1451
91a15bc6
SM
14522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1453
1454 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1455
b41c3a35
EZ
14562011-09-16 Eli Zaretskii <eliz@gnu.org>
1457
1458 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1459 GCC PR/17406) by declaring this function with external scope.
1460
7812ba2d
PE
14612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1464 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1465
cf7edc2a
AS
14662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1467
1468 * editfns.c (Fformat): Correctly handle text properties on "%%".
1469
bd01620e
EZ
14702011-09-15 Eli Zaretskii <eliz@gnu.org>
1471
1472 * xterm.c (x_draw_composite_glyph_string_foreground):
1473 * w32term.c (x_draw_composite_glyph_string_foreground):
1474 * term.c (encode_terminal_code):
1475 * composite.c (composition_update_it, get_composition_id):
1476 * xdisp.c (get_next_display_element)
1477 (fill_composite_glyph_string): Add comments about special meaning
1478 of TAB characters in a composition.
1479
a02719a3
PE
14802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1483 This occurs when processing a multibyte format.
1484 Problem reported by Wolfgang Jenker.
a02719a3 1485
72589a3c
JB
14862011-09-15 Johan Bockgård <bojohan@gnu.org>
1487
1488 * xdisp.c (try_cursor_movement): Only check for exact match if
1489 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1490
1c14176c
PE
14912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 Remove unused external symbols.
1494 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1495 * xdisp.c (calc_pixel_width_or_height): Now static.
1496 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1497 * indent.c (check_display_width):
1498 * w32term.c: Fix comment to match code.
1499 * xterm.c, xterm.h (x_catching_errors): Remove.
1500
d2eea5b5
PE
15012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * xselect.c: Use signed conversions more consistently (Bug#9498).
1504 (selection_data_to_lisp_data): Assume incoming selection data are
1505 signed integers, not unsigned. This is to be consistent with
1506 outgoing selection data, which was modified to use signed integers
1507 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1508 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1509 expects long, not unsigned long.
1510
46888499
EZ
15112011-09-14 Eli Zaretskii <eliz@gnu.org>
1512
1513 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1514 computation of loop end. Reported by Johan Bockgård
1515 <bojohan@gnu.org>.
1516
ef8ef9fb
CY
15172011-09-13 Chong Yidong <cyd@stupidchicken.com>
1518
1519 * frame.c (Fother_visible_frames_p): Function deleted.
1520
fa819fed
EZ
15212011-09-12 Eli Zaretskii <eliz@gnu.org>
1522
1523 * indent.c (compute_motion): Process display vector front to back
1524 rather than the other way around. (Bug#2496)
1525
2ba8e008
SM
15262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1527
1528 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1529
20f53c69
CY
15302011-09-11 Chong Yidong <cyd@stupidchicken.com>
1531
1532 * minibuf.c (Fread_from_minibuffer): Doc fix.
1533
d562d7a4
EZ
15342011-09-11 Eli Zaretskii <eliz@gnu.org>
1535
1536 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1537 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1538
1c4d7f3d
LMI
15392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1540
1541 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1542 value for non-existent files.
1543
b885bf36
EZ
15442011-09-11 Eli Zaretskii <eliz@gnu.org>
1545
1546 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1547 set its "size" to -1. This will set the modtime_size field of
1548 the corresponding buffer to -1, which is what
1549 verify-visited-file-modtime expects for files that do not exist.
1550 (Bug#9139)
1551
6612f0bf
PE
15522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1555 here ...
1556 * lisp.h: ... from here. push_key_description is no longer
1557 defined in keyboard.c, so its declaration should not be in
1558 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1559 logically belongs with push_key_description.
1560
dfb3f755
PE
15612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 * buffer.h: Include <sys/types.h> instead of <time.h>.
1564 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1565 Problem reported by Herbert J. Skuhra.
1566
3134906c
LMI
15672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1568
1569 * xml.c (parse_region): Make the parsing work for
1570 non-comment-starting XML files again (bug#9144).
1571
8d903f4e
AS
15722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1573
1574 * image.c (gif_load): Fix calculation of bottom and right corner.
1575 (Bug#9468)
1576
80ad64f4
EZ
15772011-09-10 Eli Zaretskii <eliz@gnu.org>
1578
1579 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1580 redisplay in small windows.
1581
208a048d
EZ
15822011-09-09 Eli Zaretskii <eliz@gnu.org>
1583
1584 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1585
9b1c252e
MR
15862011-09-08 Martin Rudalics <rudalics@gmx.at>
1587
1588 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1589 Operate on live windows only.
1590
2949f33b
JB
15912011-09-08 Juanma Barranquero <lekktu@gmail.com>
1592
1593 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1594
e08dcafd
EZ
15952011-09-07 Eli Zaretskii <eliz@gnu.org>
1596
1597 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1598 only under bidi iteration.
1599
115b96bd
JD
16002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1601
1602 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1603
c8199d0f
PE
16042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1607 Without this fix, the command to link temacs failed due to an
1608 undefined symbol __builtin_isnan. This is because
1609 /usr/include/iso/math_c99.h #defines isnan(x) to
1610 __builtin_isnan(x), but the bundled gcc, which identifies itself
1611 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1612 a __builtin_isnan.
1613 * floatfns.c (isnan): #undef, and then #define to a clone of
1614 what's in data.c.
1615 (Fisnan): Always define, since it's always available now.
1616 (syms_of_floatfns): Always define isnan at the Lisp level.
1617
e39b275c 16182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1619
1620 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1621
b2db44d9 16222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1623
f4af5137 1624 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1625 The previous code assumed that file offsets (off_t values) fit in
1626 EMACS_INT variables, which is not true on typical 32-bit hosts.
1627 The code messed up by falsely reporting buffer overflow in cases
1628 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1629 when "big" contains more than 2**29 bytes, even though this
1630 inserts just one byte and does not overflow the buffer.
1631 (Finsert_file_contents): Store file offsets as off_t
1632 values, not as EMACS_INT values. Check for overflow when
1633 converting between EMACS_INT and off_t. When checking for
1634 buffer overflow or for overlap, take the offsets into account.
1635 Don't use EMACS_INT for small values where int suffices.
1636 When checking for overlap, fix a typo: ZV was used where
1637 ZV_BYTE was intended.
1638 (Fwrite_region): Don't assume off_t fits into 'long'.
1639 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1640
ecfc0a49
MA
16412011-09-05 Michael Albinus <michael.albinus@gmx.de>
1642
1643 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1644
6511acf2 16452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1646
0999621a 1647 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1648
1649 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1650 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1651 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1652 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1653 (modify_event_symbol): Do not assume that the length of
1654 name_alist_or_stem is safe to alloca and fits in int.
1655 (Fexecute_extended_command): Likewise for function name and binding.
1656 (Frecursion_depth): Wrap around reliably on integer overflow.
1657 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1658 since some callers pass EMACS_INT values.
1659 (Fsingle_key_description): Don't crash if symbol name contains more
1660 than MAX_ALLOCA bytes.
1661 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1662 (get_minibuffer): Arg is now EMACS_INT, not int.
1663 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1664 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1665 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1666
2be7d702
PE
1667 * dbusbind.c (signature_cat): New function.
1668 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1669 Do not overrun buffer; instead, report string overflow.
1670
9d1df220
PE
1671 * dispnew.c (add_window_display_history): Don't overrun buffer.
1672 Truncate instead; this is OK since it's just a log.
1673
33ef5c64
PE
1674 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1675 even if the time zone offset is outlandishly large.
1676 Don't mishandle offset == INT_MIN.
1677
66c6fdd5
PE
1678 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1679 when creating daemon; the previous buffer-overflow check was incorrect.
1680
d749b01b
PE
1681 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1682 which has the guts of the old verror function.
1683
b5cd1905
PE
1684 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1685 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1686
6e1a67fb
PE
1687 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1688 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1689 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1690 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1691 length of string rather than counting it via multiple sprintfs;
1692 that's simpler and more reliable.
c21721cc
PE
1693 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1694 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1695 sprintf, in case result does not fit in int.
1696
c57b67fc
PE
1697 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1698 (fontset_from_font): Print it.
1699
8a401434
PE
1700 * frame.c (tty_frame_count): Now printmax_t, not int.
1701 (make_terminal_frame, set_term_frame_name): Print it.
1702 (x_report_frame_params): In X, window IDs are unsigned long,
1703 not signed long, so print them as unsigned.
1704 (validate_x_resource_name): Check for implausibly long names,
1705 and don't assume name length fits in 'int'.
1706 (x_get_resource_string): Don't blindly alloca invocation name;
1707 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1708 not fit in int.
1709
6e1a67fb
PE
1710 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1711 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1712 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1713
0df02bf3
PE
1714 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1715 Use esprintf, not sprintf, in case result does not fit in int.
1716
48e30793
PE
1717 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1718 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1719 it as a large positive number.
1720 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1721 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1722
a66ff6d8
PE
1723 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1724 in case result does not fit in int.
1725
aca216ff
PE
1726 * print.c (float_to_string): Detect width overflow more reliably.
1727 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1728 buffer overrun. Don't assume list length fits in 'int'. Treat
1729 print length of 0 as 0, not as infinity; to be consistent with other
1730 uses of print length in this function. Don't overflow print length
1731 index. Don't assume hash table size fits in 'long', or that
1732 vectorlike size fits in 'unsigned long'.
1733
31c286f7
PE
1734 * process.c (make_process): Use printmax_t, not int, to format
1735 process-name gensyms.
1736
55e5faa1
PE
1737 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1738
80f2e268
PE
1739 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1740 to avoid potential buffer overrun.
1741
670741ab
PE
1742 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1743 if X resource line is longer than 512 bytes.
1744
b7163a50
PE
1745 * xfns.c (x_window): Make sprintf buffer a bit bigger
1746 to avoid potential buffer overrun.
1747
ae58ff1f
PE
1748 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1749
c43c8a6a
PE
1750 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1751
3f8236f4
PE
17522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1753
53e9fe90 1754 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1755 Without these, Emacs silently mishandles large integers sometimes.
1756 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1757 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1758
6511acf2
PE
1759 * xdisp.c (try_window_id): Check Emacs fixnum range before
1760 converting to 'int'.
806add1d 1761
6511acf2 1762 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1763 Check that an Emacs fixnum is in range before assigning it to 'int'.
1764 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1765 values converted from Emacs fixnums.
1766 (Frecenter): Don't wrap around a line count if it is out of 'int'
1767 range; instead, treat it as an extreme value.
1768 (Fset_window_configuration, compare_window_configurations):
1769 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1770
6511acf2
PE
1771 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1772 that can exceed INT_MAX. Check that EMACS_INT value is in range
1773 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1774 (match_limit): Don't assume that a fixnum can fit in 'int'.
1775
6511acf2 1776 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1777 exceed INT_MAX.
1778
6511acf2 1779 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1780 (Fvertical_motion): Don't wrap around LINES values that don't fit
1781 in 'int'. Instead, treat them as extreme values. This is good
1782 enough for windows, which can't have more than INT_MAX lines anyway.
1783
fcb901a7
LMI
17842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1785
0f2f6b6d
LMI
1786 * Require libxml/parser.h to avoid compilation warning.
1787
fcb901a7
LMI
1788 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1789
1790 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1791 since this reportedly can destroy thread storage.
1792
6e20a0d4
CY
17932011-08-30 Chong Yidong <cyd@stupidchicken.com>
1794
1795 * syntax.c (find_defun_start): Update all cache variables if
1796 exiting early (Bug#9401).
1797
148ae00e
EZ
17982011-08-30 Eli Zaretskii <eliz@gnu.org>
1799
f6cfbd8f
EZ
1800 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1801
148ae00e
EZ
1802 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1803 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1804 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1805
1806 * term.c (tty_append_glyph): New function.
1807 (produce_stretch_glyph): Static function and its prototype deleted.
1808
a66cfb1c
SM
1809 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1810 Add prototypes.
148ae00e 1811
c4a07a4c
PE
18122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1813
1814 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1815 when checking :margin (Bug#9390).
1816 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1817 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1818 so that the name doesn't mislead. All uses changed.
1819
6bc8cd65
JB
18202011-08-28 Johan Bockgård <bojohan@gnu.org>
1821
1822 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1823 set_tty_hooks.
1824
dca4927e
EZ
18252011-08-27 Eli Zaretskii <eliz@gnu.org>
1826
1827 * xdisp.c (move_it_to): Don't bail out early when reaching
1828 position beyond to_charpos, if we are scanning backwards.
1829 (move_it_vertically_backward): When DY == 0, make sure we get to
1830 the first character in the line after the newline.
1831
f2cad773
PE
18322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1833
1834 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1835 (ccl_driver): Do not generate an out-of-range pointer.
1836 (Fccl_execute_on_string): Remove unnecessary check for
1837 integer overflow, noted by Stefan Monnier in
1838 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1839 Remove a FIXME that didn't need fixing.
1840 Simplify the newly-introduced buffer reallocation code.
1841
0cae2cdb
JB
18422011-08-27 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1845
5fc295a4 18462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1847
70c60eb2 1848 Integer and memory overflow issues (Bug#9196).
726e0ab1 1849
d31850da
PE
1850 * doc.c (get_doc_string): Rework so that
1851 get_doc_string_buffer_size is the actual buffer size, rather than
1852 being 1 less than the actual buffer size; this makes xpalloc more
1853 convenient.
1854
a69fbedb
PE
1855 * image.c (x_allocate_bitmap_record, cache_image):
1856 * xselect.c (Fx_register_dnd_atom):
1857 Simplify previous changes by using xpalloc.
1858
fe5c5d37
PE
1859 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1860 since either will do and ptrdiff_t is convenient with xpalloc.
1861
0065d054
PE
1862 * charset.c (charset_table_size)
1863 (struct charset_sort_data.priority): Now ptrdiff_t.
1864 (charset_compare): Don't overflow if priorities differ greatly.
1865 (Fsort_charsets): Don't assume list length fits in int.
1866 Check for size-calculation overflow when allocating sort data.
1867 (syms_of_charset): Allocate an initial charset table that is
1868 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1869
1870 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1871
1872 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1873 The actual value is always <= INT_MAX, and leaving it unsigned made
1874 overflow checking harder.
1875
1876 * dispextern.h (struct glyph_matrix.rows_allocated)
1877 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1878 with xpalloc. The values are still always <= INT_MAX.
1879
1880 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1881
1882 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1883 (SAFE_NALLOCA): New macro.
1884
1885 * region-cache.c (struct boundary.pos, find_cache_boundary)
1886 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1887 (set_cache_region, invalidate_region_cache)
1888 (revalidate_region_cache, know_region_cache, region_cache_forward)
1889 (region_cache_backward, pp_cache):
1890 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1891 so that ptrdiff_t * can be passed to xpalloc.
1892 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1893 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1894 (pp_cache): Don't assume cache_len fits in int.
1895 * region-cache.h: Adjust extern decls to match.
1896
1897 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1898 EMACS_INT, since either will do, for xpalloc.
1899
1900 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1901 (xnmalloc, xnrealloc, xpalloc): New functions.
1902
726e0ab1
PE
1903 * bidi.c (bidi_shelve_header_size): New constant.
1904 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1905 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1906
51f30bc5 1907 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1908 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1909 (overlay_strings):
1910 Don't update size of array until after memory allocation succeeds,
1911 because xmalloc/xrealloc may not return.
0065d054
PE
1912 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1913 now that we have proper integer overflow checking.
1914 (record_overlay_string, overlay_strings): Catch overflows when
1915 calculating size of overlay_str_buf.
726e0ab1 1916
0065d054
PE
1917 * callproc.c (Fcall_process): Check for size overflow when
1918 calculating size of args2.
1919 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1920 Normally we prefer signed values, but sticking with ptrdiff_t would
1921 require adding more-complicated checks.
726e0ab1
PE
1922
1923 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1924 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1925 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1926 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1927
1928 * character.c (Fstring): Check for size-calculation overflow.
1929
1930 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1931 unnecessary integer overflow. Check for size overflow.
1932 (encode_coding_object): Don't update size until xmalloc succeeds.
1933
1934 * composite.c (get_composition_id): Check for overflow in glyph
1935 length calculations.
1936
1937 Integer and memory overflow fixes for display code.
1938 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1939 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1940 (scrolling_window): Check for overflow in size calculations.
1941 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1942 Don't assume glyph table len fits in int.
1943 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1944 (row_table_size): Now ptrdiff_t, not int.
1945 (scrolling_window): Avoid overflow in size calculations.
1946 Don't update size until allocation succeeds.
1947 * fns.c (concat): Check for overflow in size calculations.
1948 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1949 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1950 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1951
1952 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1953 (get_doc_string): Check for size calculation overflow.
1954 Don't update size until allocation succeeds.
1955 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1956 EMACS_INT, where ptrdiff_t will do.
1957 (Fsubstitute_command_keys): Check for string overflow.
1958
1959 * editfns.c (set_time_zone_rule): Don't assume environment length
1960 fits in int.
1961 (message_length): Now ptrdiff_t, not int.
1962 (Fmessage_box): Don't update size until allocation succeeds.
1963 Don't assume message length fits in int.
1964 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1965
0065d054
PE
1966 * emacs.c (main): Do not reallocate argv, since there is a null at
1967 the end that can be overwritten, and this way there's no need to
1968 worry about size-calculation overflow.
1969 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1970
1971 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1972 alloc succeeds.
1973 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1974
1975 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1976 (x_set_scroll_bar_width, x_figure_window_size):
1977 Check for integer overflow.
1978 (x_set_alpha): Do not assume XINT fits in int.
1979
1980 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1981 This is for the members text_lines, text_cols, total_lines, total_cols,
1982 where the system imposes an 'int' limit.
1983
1984 * fringe.c (Fdefine_fringe_bitmap):
1985 Don't update size until alloc works.
1986
1987 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1988 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1989
1990 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1991 Check for size-calculation overflow.
1992 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1993 do, as we prefer signed integers.
1994 (id_to_widget.max_size, id_to_widget.used)
1995 (xg_store_widget_in_map, xg_remove_widget_from_map)
1996 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1997 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1998 Use and return ptrdiff_t, not int.
1999 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2000 * gtkutil.h: Change prototypes to match the above.
2001
2002 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2003 are duplicate now that they've been promoted to lisp.h.
2004 (x_allocate_bitmap_record, x_alloc_image_color)
2005 (make_image_cache, cache_image, xpm_load):
2006 Don't update size until alloc is done.
2007 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2008 (x_detect_edges):
3256efce 2009 Check for size calculation overflow.
726e0ab1
PE
2010 (ct_colors_allocated_max): New constant.
2011 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2012 overflow.
3256efce 2013
726e0ab1
PE
2014 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2015 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2016 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2017 Use ptrdiff_t, not int, to count maps.
2018 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2019 calculations. Don't update size until allocation succeeds.
2020 Redo calculations to avoid overflow.
726e0ab1
PE
2021 * keyboard.h: Change prototypes to match the above.
2022
2023 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2024 to count maps.
2025 (current_minor_maps): Check for size calculation overflow.
2026 * keymap.h: Change prototypes to match the above.
2027
2028 * lread.c (read1, init_obarray): Don't update size until alloc done.
2029
2030 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2031 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2032
726e0ab1
PE
2033 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2034 Now ptrdiff_t, not int.
2035 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2036 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2037
2038 * process.c (Fnetwork_interface_list): Check for overflow
2039 in size calculation.
2040
2041 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2042
2043 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2044 overflow. Don't bother calling xmalloc when xrealloc will do.
2045
2046 * search.c (Freplace_match): Check for size calculation overflow.
2047 (Fset_match_data): Don't assume list lengths fit in 'int'.
2048
2049 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2050 for command line length. Do not attempt to address one before the
2051 beginning of an array, as that's not portable.
2052
2053 * term.c (max_frame_lines): Remove; unused.
2054 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2055 not int.
2056 (encode_terminal_code, calculate_costs): Check for size
2057 calculation overflow.
2058 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2059 table lengths and related sizes. Don't update size until alloc
2060 done. Redo calculations to avoid overflow.
2061 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2062
2063 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2064 subtracting pointers.
2065 (gobble_line): Check for overflow more carefully. Don't update size
2066 until alloc done.
2067
2068 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2069 Don't update size until alloc done.
2070 Redo size calculations to avoid overflow.
2071 Check for size calculation overflow.
0065d054 2072 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2073
2074 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2075 Use ptrdiff_t, not int, for sizes.
2076 (store_mode_line_noprop_char): Don't update size until alloc done.
2077
0065d054
PE
2078 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2079 Use ptrdiff_t, not int, for sizes.
2080 (Finternal_make_lisp_face, cache_face):
2081 Check for size calculation overflow.
2082 (cache_face): Treat size calculation overflows as if they were
2083 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2084
2085 * xfns.c (x_encode_text, x_set_name_internal)
2086 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2087 sizes, since they can exceed INT_MAX in size. Check for size
2088 calculation overflow.
2089
0065d054
PE
2090 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2091 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2092 Don't update size until alloc done.
2093
0065d054 2094 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2095 as sprintf is limited to int lengths.
1d526e2f 2096
252c5ee1
PE
2097 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2098 (X_LONG_MIN): New macros.
864d7ce7
PE
2099 Use them to make the following changes clearer.
2100 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2101 This change doesn't affect the value now, but it may help remind
2102 future maintainers not to raise the value too much later.
2103 (SELECTION_QUANTUM): Remove, replacing with ...
2104 (selection_quantum): ... new function, which avoids overflow.
2105 All uses changed.
2106 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2107 assumption that selection length fits in 'int'.
2108 (x_reply_selection_request, x_handle_selection_request)
2109 (x_get_window_property, receive_incremental_selection)
2110 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2111 (lisp_data_to_selection_data, clean_local_selection_data):
2112 Use ptrdiff_t, not int, to record length of selection.
2113 (x_reply_selection_request, x_get_window_property)
2114 (receive_incremental_selection, x_property_data_to_lisp):
2115 Redo calculations to avoid overflow.
2116 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2117 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2118 something.
2119 (x_get_window_property, receive_incremental_selection)
2120 (lisp_data_to_selection_data, x_property_data_to_lisp):
2121 Check for size-calculation overflow.
2122 (x_get_window_property, receive_incremental_selection)
2123 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2124 Don't store size until memory allocation succeeds.
2125 (x_get_window_property): Plug memory leak on memory exhaustion.
2126 Don't double-block input; malloc is safe here. Don't assume 2**34
2127 - 4 fits in unsigned long. Add an xassert to check
2128 XGetWindowProperty overflow. Be more careful about overflow
2129 calculations, and distinguish size from memory overflow better.
2130 (receive_incremental_selection): When tracing, don't assume
2131 unsigned int is less than INT_MAX.
2132 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2133 harmful) conversions of unsigned short to int.
2134 (lisp_data_to_selection_data): Don't assume that integers
2135 in the range -65535 through -1 fit in an X unsigned short.
2136 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2137 result parameters unless successful. Rely on cons_to_unsigned
2138 to report problems with elements; the old code wasn't right anyway.
2139 (x_check_property_data): Check for int overflow; we cannot use
2140 a wider type due to X limits.
2141 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2142
726e0ab1 2143 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2144
0065d054
PE
2145 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2146 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2147 (x_color_cells): Don't store size until memory allocation succeeds.
2148 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2149 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2150 (x_term_init): Don't assume length fits in int (sprintf is limited
2151 to int size).
bc18e09d 2152
ebfa62c0
PE
2153 Use ptrdiff_t for composition IDs.
2154 * character.c (lisp_string_width):
2155 * composite.c (composition_table_size, n_compositions)
2156 (get_composition_id, composition_gstring_from_id):
2157 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2158 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2159 * window.c (Frecenter):
2160 Use ptrdiff_t, not int, for composition IDs.
2161 * composite.c (get_composition_id): Check for integer overflow.
2162 * composite.h: Adjust prototypes to match the above changes.
2163
d3411f89
PE
2164 Use ptrdiff_t for hash table indexes.
2165 * category.c (hash_get_category_set):
2166 * ccl.c (ccl_driver):
2167 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2168 * coding.c (coding_system_charset_list, detect_coding_system):
2169 * coding.h (struct coding_system.id):
2170 * composite.c (get_composition_id, gstring_lookup_cache):
2171 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2172 * image.c (xpm_get_color_table_h):
2173 * lisp.h (hash_lookup, hash_put):
2174 * minibuf.c (Ftest_completion):
2175 Use ptrdiff_t for hash table indexes, not int (which is too
2176 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2177 32-bit --with-wide-int hosts).
2178
e097a6fa
PE
2179 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2180 Add a FIXME comment about memory leaks.
2181 (syms_of_charset): Don't assume xmalloc returns.
2182
5637687f
PE
2183 Don't assume that stated character widths fit in int.
2184 * character.c (Fchar_width, c_string_width, lisp_string_width):
2185 * character.h (CHAR_WIDTH):
2186 * indent.c (MULTIBYTE_BYTES_WIDTH):
2187 Use sanitize_char_width to avoid undefined and/or bad behavior
2188 with outlandish widths.
a66cfb1c 2189 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2190 now that we have two such functions. All uses changed.
2191 (sanitize_char_width): New inline function.
2192
a2271ba2
PE
2193 Don't assume that tab-width fits in int.
2194 * character.h (sanitize_width): New inline function.
2195 (SANE_TAB_WIDTH): New macro.
2196 (ASCII_CHAR_WIDTH): Use it.
2197 * indent.c (sane_tab_width): Remove. All uses replaced by
2198 SANE_TAB_WIDTH (current_buffer).
2199 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2200
18c52557
PE
2201 * fileio.c: Integer overflow issues with file modes.
2202 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2203
caeeedc1
PE
2204 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2205 Remove unreachable code.
2206 (read_hex, load_charset_map_from_file): Check for integer overflow.
2207
50849c52
PE
2208 * xterm.c: don't go over XClientMessageEvent limit
2209 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2210 (x_send_scroll_bar_event): Likewise. Check that the size does not
2211 exceed limits imposed by XClientMessageEvent, as well as the usual
2212 ptrdiff_t and size_t limits.
2213
b13995db
PE
2214 * keyboard.c: Overflow, signedness and related fixes.
2215 (make_lispy_movement): Use same integer type in forward decl
2216 that is used in the definition.
2217 (read_key_sequence, keyremap_step):
2218 Change bufsize argument back to int, undoing my 2011-03-30 change.
2219 We prefer signed types, and int is wide enough here.
2220 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2221 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2222 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2223 length, not size_t. Use ptrdiff_t for index, not int.
2224 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2225 possibility of integer overflow.
2226
13464394
PE
2227 Overflow, signedness and related fixes for images.
2228
2229 * dispextern.h (struct it.stack[0].u.image.image_id)
2230 (struct_it.image_id, struct image.id, struct image_cache.size)
2231 (struct image_cache.used, struct image_cache.ref_count):
2232 * gtkutil.c (update_frame_tool_bar):
2233 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2234 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2235 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2236 * nsmenu.m (update_frame_tool_bar):
2237 * xdisp.c (calc_pixel_width_or_height):
2238 * xfns.c (image_cache_refcount):
2239 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2240 on typical 64-bit hosts.
2241
2242 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2243 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2244 Omit unnecessary casts to int.
2245 (parse_image_spec): Check that integers fall into 'int' range
2246 when the callers expect that.
2247 (image_ascent): Redo ascent calculation to avoid int overflow.
2248 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2249 (lookup_image): Remove unnecessary tests.
2250 (xbm_image_p): Locals are now of int, not EMACS_INT,
2251 since parse_image_check makes sure they fit into int.
2252 (png_load, gif_load, svg_load_image):
2253 Prefer int to unsigned where either will do.
2254 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2255 old tiff_error_handler and tiff_warning_handler.
2256 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2257 stack buffer overflows. It uses only the features of vsnprintf
2258 that are common to both POSIX and native Microsoft.
2259 (tiff_error_handler, tiff_warning_handler): Use it.
2260 (tiff_load, gif_load, imagemagick_load_image):
2261 Don't assume :index value fits in 'int'.
2262 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2263 (imagemagick_load_image): Check that crop parameters fit into
2264 the integer types that MagickCropImage accepts. Don't assume
2265 Vimagemagick_render_type has a nonnegative value. Don't assume
2266 size_t fits in 'long'.
2267 (gs_load): Use printmax_t to print the widest integers possible.
2268 Check for integer overflow when computing image height and width.
2269
c11821d4
EZ
22702011-08-26 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xdisp.c (redisplay_window): Don't force window start if point
2273 will be invisible in the resulting window. (Bug#9324)
2274
0c95fcf7
EZ
22752011-08-25 Eli Zaretskii <eliz@gnu.org>
2276
2277 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2278 the display spec is of the form `(space ...)'.
2279 (handle_display_spec): Return the value returned by
2280 handle_single_display_spec, not just 1 or zero.
2281 (handle_single_display_spec): If the display spec is of the form
2282 `(space ...)', and specifies display in the text area, return 2
2283 rather than 1.
fee65a97 2284 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2285 accurately, and prefer exact match for point under bidi.
2286 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2287
2288 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2289 into disp_prop; all users changed.
2290
2291 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2292 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2293 for the text covered by the display property.
2294
e4ed06f1
CY
22952011-08-25 Chong Yidong <cyd@stupidchicken.com>
2296
2297 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2298 Change return value to nil.
2299 (Frecord_buffer): Delete unused function.
2300
f67cdd7f
EZ
23012011-08-24 Eli Zaretskii <eliz@gnu.org>
2302
5980d4c6
EZ
2303 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2304 buffers, return left-to-right.
8610fe8b
EZ
2305 (set_cursor_from_row): Consider candidate row a win if its glyph
2306 represents a newline and point is on that newline. Fixes cursor
2307 positioning on the newline at EOL of R2L text within L2R
2308 paragraph, and vice versa.
2309 (try_cursor_movement): Check continued rows, in addition to
2310 continuation rows. Fixes unwarranted scroll when point enters a
2311 continued line of R2L text within an L2R paragraph, or vice versa.
2312 (cursor_row_p): Consider the case of point being equal to
2313 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2314 from the end of a short line to the beginning of a continued line
2315 of R2L text within L2R paragraph.
2316 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2317 composed characters.
5980d4c6 2318
f67cdd7f
EZ
2319 * bidi.c (bidi_check_type): Use xassert.
2320 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2321 members.
2322
bca633fb
EZ
23232011-08-23 Eli Zaretskii <eliz@gnu.org>
2324
2325 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2326 a character.
2327
4a5885a7
CY
23282011-08-23 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * nsfont.m (ns_otf_to_script): Fix typo.
2331
0902a04e
KH
23322011-08-22 Kenichi Handa <handa@m17n.org>
2333
2334 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2335 extra slot even if the purpose is char-code-property-table.
2336
1a2e6670
EZ
23372011-08-23 Eli Zaretskii <eliz@gnu.org>
2338
8ddde651
EZ
2339 * xdisp.c (redisplay_window): When computing centering_position,
2340 account for the height of the header line. (Bug#8874)
2341
425cc014
EZ
2342 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2343 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2344 candidate is selected by the mouse, and that candidate has a
2345 composed character under the mouse.
2346
1a2e6670
EZ
2347 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2348 coordinates reported by pos-visible-in-window-p for a composed
2349 character in column zero.
2350
8b76d6f8
SM
23512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2352
2353 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2354
dac347dd
EZ
23552011-08-22 Eli Zaretskii <eliz@gnu.org>
2356
2357 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2358 consider it a hit if to_charpos is anywhere in the range of the
2359 composed buffer positions.
2360
e013fb34
CY
23612011-08-22 Chong Yidong <cyd@stupidchicken.com>
2362
2363 * image.c (gif_load): Don't assume that each subimage has the same
2364 dimensions as the base image. Handle disposal method that is
2365 "undefined" by the gif spec (Bug#9335).
2366
bd1ba3e8
CY
23672011-08-20 Chong Yidong <cyd@stupidchicken.com>
2368
2369 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2370 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2371
54a1215b
EZ
23722011-08-19 Eli Zaretskii <eliz@gnu.org>
2373
823564e5
EZ
2374 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2375 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2376 from an Org mode buffer to a Speedbar frame.
2377
54a1215b
EZ
2378 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2379 a composition, take its buffer position from IT->cmp_it.charpos.
2380 Fixes cursor positioning at the beginning of a line that begins
2381 with a composed character.
2382
9778ebcc
EZ
23832011-08-18 Eli Zaretskii <eliz@gnu.org>
2384
0be6ee06
EZ
2385 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2386 character bidirectional type, use STRONG_L instead. Fixes crashes
2387 in a buffer produced by `describe-categories'.
2388
9778ebcc
EZ
2389 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2390 members before the level stack, so they would be saved and
2391 restored when copying iterator state. Fixes incorrect reordering
2392 around TABs covered by display properties.
2393
156bffbe
AS
23942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2395
6b02f655 2396 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2397
72ad093b
CY
23982011-08-17 Chong Yidong <cyd@stupidchicken.com>
2399
2400 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2401 (internal_condition_case_2, internal_condition_case_n):
2402 Remove unnecessary aborts (Bug#9081).
72ad093b 2403
35774242
EZ
24042011-08-17 Eli Zaretskii <eliz@gnu.org>
2405
2406 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2407 has no `load' handler, try opening the file locally. (Bug#9311)
2408
db76dd85
KB
24092011-08-16 Ken Brown <kbrown@cornell.edu>
2410
2411 * gmalloc.c: Expand comment.
2412
b215eee5
EZ
24132011-08-16 Eli Zaretskii <eliz@gnu.org>
2414
2415 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2416 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2417
a4579d33
KB
24182011-08-16 Ken Brown <kbrown@cornell.edu>
2419
2420 Fix memory allocation problems in Cygwin build (Bug#9273).
2421
2422 * unexcw.c ( __malloc_initialized): Declare external variable.
2423 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2424
8b76d6f8
SM
2425 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2426 New variables.
a4579d33
KB
2427 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2428 dumped emacs.
2429 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2430 in the static heap.
2431 [CYGWIN] (special_realloc): New function.
2432 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2433 requests to realloc storage in the static heap.
2434
3ebec551
PE
24352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * bidi.c (bidi_initialize): Remove unused local.
2438
9fd8be00
EZ
24392011-08-15 Eli Zaretskii <eliz@gnu.org>
2440
6b02f655
SM
2441 * bidimirror.h:
2442 * biditype.h: Remove file.
2443 * makefile.w32-in ($(BLD)/bidi.$(O)):
2444 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2445
2446 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2447
2448 * chartab.c: Improve commentary for the uniprop_table API.
2449
32413314
EZ
2450 * bidi.c (bidi_paragraph_init): Support zero value of
2451 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2452 (bidi_initialize): Use uniprop_table instead of including
2453 biditype.h and bidimirror.h.
32413314 2454
9fd8be00
EZ
2455 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2456 coordinates of the iterator when restoring from ppos_it.
2457 (Bug#9296)
2458
5cf2b69b
KH
24592011-08-14 Kenichi Handa <handa@m17n.org>
2460
2461 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2462 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2463
daf17d00
EZ
24642011-08-14 Eli Zaretskii <eliz@gnu.org>
2465
2466 * xdisp.c (move_it_in_display_line_to): Don't invoke
2467 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2468 ppos_it. Fixes vertical cursor motion when line beginning is
2469 covered by an image. (Bug#9296)
2470
08e3161a
JD
24712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2472
2473 * nsterm.h (ns_run_ascript): Declare.
2474 (NSAPP_DATA2_RUNASSCRIPT): Define.
2475
2476 * nsfns.m (as_script, as_result, as_status): New static variables.
2477 (ns_run_ascript): New function.
5e617bc2 2478 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2479 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2480 the event loop. Get status from as_status (Bug#7276).
2481
2482 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2483 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2484 the event loop (Bug#7276).
2485
a3720aa2
AS
24862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2487
2488 * gnutls.c (QCgnutls_bootprop_priority)
2489 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2490 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2491 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2492 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2493 (QCgnutls_bootprop_verify_hostname_error)
2494 (QCgnutls_bootprop_callbacks_verify): Rename from
2495 Qgnutls_bootprop_..., all uses changed.
2496
2497 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2498 uses changed.
2499
0a0d27fb
PE
25002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2501
19d5c50c
PE
2502 * xfaces.c (Qframe_set_background_mode): Now static.
2503 * dispextern.h (Qframe_set_background_mode): Remove decl.
2504
0a0d27fb
PE
2505 * process.c (Fnetwork_interface_info): Declare local only if needed.
2506
377538cb
JD
25072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2508
2509 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2510 (Fnetwork_interface_list): Allocate in increments of bytes instead
2511 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2512 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2513 sockaddr.
2514 (struct ifflag_def): notrailers is smart on OSX.
2515 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2516 Get hardware address with getifaddrs if available.
2517
08fff70c
EZ
25182011-08-12 Eli Zaretskii <eliz@gnu.org>
2519
2520 * xdisp.c (iterate_out_of_display_property): xassert that
2521 IT->position is set to within IT->object's boundaries. Break from
2522 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2523 when IT->position is set up wrongly due to some bug.
2524 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2525 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2526 entry. Force push_it to save on the stack the current
2527 buffer/string position, to be restored by pop_it. Fix flags in
2528 the iterator structure wrt the object coming from a display
2529 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2530 properties. (Bug#9284)
2531
7be1c708 25322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2533
7be1c708
CY
2534 * fontset.c (fontset_get_font_group): Add proper type checks.
2535 (Bug#9172)
aac0c6e3 2536
7be1c708 25372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2538
7be1c708
CY
2539 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2540 and LC_VERSION_MIN_MACOSX.
2541 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2542 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2543
97bb72a6
EZ
25442011-08-08 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2547 no-display-properties-and-no-overlays under bidi display.
2548 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2549 properties and overlays.
97bb72a6 2550
d5617611
CY
25512011-08-08 Chong Yidong <cyd@stupidchicken.com>
2552
37e11a63
CY
2553 * editfns.c (Fset_time_zone_rule): Document relationship with the
2554 setenv function.
2555
d5617611
CY
2556 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2557 the font entity extracted from the cache (Bug#8109).
2558
58872834
CY
25592011-08-07 Chong Yidong <cyd@stupidchicken.com>
2560
2561 * composite.c (autocmp_chars): Don't reset point. That is done by
2562 restore_point_unwind (Bug#5984).
2563
75bfc667
JL
25642011-08-07 Juri Linkov <juri@jurta.org>
2565
2566 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2567 to show the arg `TIME' instead of `TIMEVAL'.
2568
d1410150
EZ
25692011-08-06 Eli Zaretskii <eliz@gnu.org>
2570
2571 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2572 display property strides EOL and includes a newline, as in
2573 longlines-mode. (Bug#9254)
75b771e4
EZ
2574 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2575 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2576
2577 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2578 is non-zero, even if the data buffer is NULL. Fixes a crash in
2579 vertical-motion with longlines-mode. (Bug#9254)
2580
35928349
EZ
25812011-08-05 Eli Zaretskii <eliz@gnu.org>
2582
ec7cc85b
EZ
2583 * bidi.c <bidi_cache_total_alloc>: Now static.
2584 (bidi_initialize): Initialize bidi_cache_total_alloc.
2585
8b76d6f8 2586 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2587 cache. (Bug#9221)
2588
2589 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2590 amount allocated this far in `bidi_cache_total_alloc'.
2591 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2592 non-zero, only free the data buffer without restoring the cache
2593 contents. All callers changed.
2594
2595 * dispextern.h (bidi_unshelve_cache): Update prototype.
2596
2597 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2598 (move_it_in_display_line, move_it_to)
2599 (move_it_vertically_backward, move_it_by_lines): Replace the call
2600 to xfree to an equivalent call to bidi_unshelve_cache.
2601 (move_it_in_display_line_to): Fix logic of returning
412b6358 2602 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2603
e2e2423b
EZ
26042011-08-05 Eli Zaretskii <eliz@gnu.org>
2605
2606 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2607 came from a string character with a `cursor' property. (Bug#9229)
2608
ae9e757a
JD
26092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2610
2611 * Makefile.in (LIB_PTHREAD): New variable.
2612 (LIBES): Add LIB_PTHREAD (Bug#9216).
2613
2614 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2615 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2616
213bd7f2
AS
26172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2618
6b02f655 2619 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2620
99aaf75f
JD
26212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2622
2623 * xterm.c (x_find_topmost_parent): New function.
2624 (x_set_frame_alpha): Find topmost parent window with
2625 x_find_topmost_parent and set the property there also (bug#9181).
2626 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2627
c74e9d86
PE
26282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 * callproc.c (Fcall_process): Avoid vfork clobbering
2631 the local vars buffer, coding_systems, current_dir.
2632
640c8776
SM
26332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2634
2635 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2636
f26d0e4c
PE
26372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2638
8a10d76c
PE
2639 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2640 so that it is not optimized away.
2641
f26d0e4c
PE
2642 * xdisp.c (compute_display_string_pos): Remove unused local.
2643
55439c61
EZ
26442011-08-02 Eli Zaretskii <eliz@gnu.org>
2645
2646 Fix slow cursor motion and scrolling in large buffers with
2647 selective display, like Org Mode buffers. (Bug#9218)
2648
2649 * dispextern.h (struct bidi_it): New member disp_prop_p.
2650
2651 * xdisp.c: Remove one-slot cache of display string positions.
2652 (compute_display_string_pos): Accept an additional argument
5e617bc2 2653 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2654 for a display string or property. If found, set DISP_PROP_P
2655 non-zero.
2656
2657 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2658 DISP_PROP_P, and pass it to compute_display_string_pos.
2659 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2660 non-zero. All callers of bidi_fetch_char changed.
2661
fb33fa43
SM
26622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2663
2664 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2665
b099e063
DM
26662010-12-03 Don March <don@ohspite.net>
2667
2668 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2669 last character M-[char] is translated to ESC [char] (bug#7541).
2670
5cc7f7af
KH
26712011-08-02 Kenichi Handa <handa@m17n.org>
2672
d0fffa3f 2673 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2674
2675 * chartab.c (uniprop_table): Make it non-static.
2676
525d5e6e
EZ
26772011-08-01 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xdisp.c (forward_to_next_line_start): Accept additional argument
2680 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2681 on the newline.
2682 (reseat_at_next_visible_line_start): Use the bidi iterator state
2683 returned by forward_to_next_line_start to restore the state of
2684 it->bidi_it after backing up to previous newline. (Bug#9212)
2685
31011111
AS
26862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2687
2688 * regex.c (re_comp): Protoize.
2689 (re_exec): Fix return type.
2690 (regexec): Fix type of `ret'. (Bug#9203)
2691
476371c4
PE
26922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2693
e5d76069
PE
2694 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2695 This is needed if max-image-size is a floating-point number.
2696
9a79b20c
AS
26972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2698
2699 * print.c (print_object): Print empty symbol as ##.
2700
2701 * lread.c (read1): Read ## as empty symbol.
2702
d8c2fa78
AA
27032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2704
2705 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2706 setting frame foreground color (Bug#9175).
2707 (x_set_background_color): Likewise.
2708
ffe57a7a
AA
2709 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2710 contents (Bug#9176).
2711 (EmacsTooltip -init): Remove bezels and add shadows to
2712 tooltip windows.
2713
bf3492a5
AA
2714 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2715 or scroll bar (Bug#8470).
2716
d55e9c53
AA
2717 * nsfont.m (nsfont_open): Remove assignment to voffset and
2718 unnecessary vars hshink, expand, hd, full_height, min_height.
2719 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2720
2721 * nsterm.h (nsfont_info): Remove voffset field.
2722
d8c2fa78 27232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2724
2725 Implement strike-through and overline on NextStep (Bug#8863).
2726
2727 * nsfont.m (nsfont_open): Use underline position provided by font,
2728 instead of hard-coded value of 2.
2729 (nsfont_draw): Call ns_draw_text_decoration instead.
2730
2731 * nsterm.h: Add declaration for ns_draw_text_decoration.
2732
2733 * nsterm.m (ns_draw_text_decoration): New function for drawing
2734 underline, overline, and strike-through.
2735 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2736 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2737 accommodate underlining, etc.
4843aac3 2738
4cc60b9b
EZ
27392011-07-28 Eli Zaretskii <eliz@gnu.org>
2740
bc7ece87
EZ
2741 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2742 default.
4cc60b9b 2743
476371c4
PE
27442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2745
66606eea
PE
2746 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2747 Without this fix, if a signal arrives just after memory fills up,
2748 'malloc' might be invoked reentrantly.
2749
476371c4
PE
2750 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2751 In other words, assume that every image size is allowed, on non-X
2752 hosts. This assumption is probably wrong, but it lets Emacs compile.
2753
f3fcc40d
AS
27542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2755
2756 * regex.c (re_iswctype): Convert return values to boolean.
2757
350c992f
EZ
27582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2759
2760 * xdisp.c (compute_display_string_pos): Don't use cached display
2761 string position if the buffer had its restriction changed.
2762 (Bug#9184)
2763
5266b4bb
PE
27642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2765
2766 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2767
2573a837 27682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2769
41f55ccd 2770 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2771
39e378da
PE
2772 * bidi.c: Integer size and overflow fixes.
2773 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2774 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2775 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2776 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2777 (bidi_find_other_level_edge):
2778 Use ptrdiff_t instead of EMACS_INT where either will do.
2779 This works better on 32-bit hosts configured --with-wide-int.
2780 (bidi_cache_ensure_space): Check for size-calculation overflow.
2781 Use % rather than repeated addition, for better worst-case speed.
2782 Don't set bidi_cache_size until after xrealloc returns, because it
2783 might not return.
2784 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2785 (bidi_cache_ensure_space): Also check that the bidi cache size
2786 does not exceed that of the largest Lisp string or buffer. See Eli
2787 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2788
5e927815
PE
2789 * alloc.c (__malloc_size_t): Remove.
2790 All uses replaced by size_t. See Andreas Schwab's note
2791 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2792
ca4aa935
PE
2793 * image.c: Improve checking for integer overflow.
2794 (check_image_size): Assume that f is nonnull, since
2795 it is always nonnull in practice. This is one less thing to
2796 worry about when checking for integer overflow later.
2797 (x_check_image_size): New function, which checks for integer
2798 overflow issues inside X.
2799 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2800 This removes the need for a memory_full check.
2801 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2802 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2803 (xbm_read_bitmap_data): Change locals back to 'int', since
2804 their values must fit in 'int'.
2805 (xpm_load_image, png_load, tiff_load):
2806 Invoke x_create_x_image_and_pixmap earlier,
2807 to avoid much needless work if the image is too large.
2808 (tiff_load): Treat overly large images as if
2809 x_create_x_image_and_pixmap failed, not as malloc failures.
2810 (gs_load): Use x_check_image_size.
2811
5f8f9cc2
PE
2812 * gtkutil.c: Omit integer casts.
2813 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2814 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2815
5adf60bc
PE
2816 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2817
c8907a93
PE
2818 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2819 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2820 would wrongly return t on a 64-bit host.
2821
e3c25c68
PE
2822 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2823 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2824 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2825 and therefore cause GCC to emit a bogus diagnostic in some cases.
2826
3f791afe
PE
2827 * image.c: Integer signedness and overflow and related fixes.
2828 This is not an exhaustive set of fixes, but it's time to
2829 record what I've got.
2830 (lookup_pixel_color, check_image_size): Remove redundant decls.
2831 (check_image_size): Don't assume that arbitrary EMACS_INT values
2832 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2833 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2834 (tiff_load, imagemagick_load_image):
2835 Check for overflow in size calculations.
2836 (x_create_x_image_and_pixmap): Remove unnecessary test for
2837 xmalloc returning NULL; that can't happen.
2838 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2839 (xpm_color_bucket): Use better integer hashing function.
2840 (xpm_cache_color): Don't possibly over-allocate memory.
2841 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2842 (gif_memory_source):
2843 Use ptrdiff_t, not int or size_t, to record sizes.
2844 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2845 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2846 either works, as we prefer signed integers.
2847 (tiff_read_from_memory, tiff_write_from_memory):
2848 Return tsize_t, not size_t, since that's what the TIFF API wants.
2849 (tiff_read_from_memory): Don't fail simply because the read would
2850 go past EOF; instead, return a short read.
2851 (tiff_load): Omit no-longer-needed casts.
2852 (Fimagemagick_types): Don't assume size fits into 'int'.
2853
3cc5a532
PE
2854 Improve hashing quality when configured --with-wide-int.
2855 * fns.c (hash_string): New function, taken from sxhash_string.
2856 Do not discard information about ASCII character case; this
2857 discarding is no longer needed.
2858 (sxhash-string): Use it. Change sig to match it. Caller changed.
2859 * lisp.h: Declare it.
2860 * lread.c (hash_string): Remove, since we now use fns.c's version.
2861 The fns.c version returns a wider integer if --with-wide-int is
2862 specified, so this should help the quality of the hashing a bit.
2863
b312a492
PE
2864 * emacs.c: Integer overflow minor fix.
2865 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2866 Define only if GNU_LINUX.
2867 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2868
dfd153ae
PE
2869 * dispnew.c: Integer signedness and overflow fixes.
2870 Remove unnecessary forward decls, that were a maintenance hassle.
2871 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2872 All uses changed.
2873 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2874 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2875 (prepare_desired_row, line_draw_cost):
2876 Use int, not unsigned, where either works.
2877 (save_current_matrix, restore_current_matrix):
2878 Use ptrdiff_t, not size_t, where either works.
2879 (init_display): Check for overflow more accurately, and without
2880 relying on undefined behavior.
2881
a81d11a3
PE
2882 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2883 Remove, replacing with the new symbols in lisp.h. All uses changed.
2884 * fileio.c (make_temp_name):
2885 * filelock.c (lock_file_1, lock_file):
2886 * xdisp.c (message_dolog):
2887 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2888 Use pMd etc. instead.
2889 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2890 replacing the pWIDE etc. symbols removed from editfns.c.
2891
3300e6fd
PE
2892 * keyboard.h (num_input_events): Now uintmax_t.
2893 This is (very slightly) less likely to mess up due to wraparound.
2894 All uses changed.
2895
fd05c7e9
PE
2896 * buffer.c: Integer signedness fixes.
2897 (alloc_buffer_text, enlarge_buffer_text):
2898 Use ptrdiff_t rather than size_t when either will do, as we prefer
2899 signed integers.
2900
903fe15d
PE
2901 * alloc.c: Integer signedness and overflow fixes.
2902 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2903 (__malloc_size_t): Default to size_t, not to int.
2904 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2905 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2906 Prefer ptrdiff_t to size_t when either would do, as we prefer
2907 signed integers.
2908 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2909 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2910 Now const. Initialize with values that are in range even if char
2911 is signed.
2912 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2913 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2914 These functions do the right thing with sizes > 2**32.
2915 (check_depth): Now ptrdiff_t, not int.
2916 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2917 Adjust to new way of storing sizes. Check for size overflow bugs
2918 in rest of code.
2919 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2920 slightly wrong anyway, as it missed one instance of
2921 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2922 (refill_memory_reserve): Omit needless cast to size_t.
2923 (mark_object_loop_halt): Mark as externally visible.
2924
ac82cc6a
PE
2925 * xselect.c: Integer signedness and overflow fixes.
2926 (Fx_register_dnd_atom, x_handle_dnd_message):
2927 Use ptrdiff_t, not size_t, since we prefer signed.
2928 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2929 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2930 x_dnd_atoms_size and x_dnd_atoms_length.
2931
c2d1e36d
PE
2932 * doprnt.c: Prefer signed to unsigned when either works.
2933 * eval.c (verror):
2934 * doprnt.c (doprnt):
2935 * lisp.h (doprnt):
2936 * xdisp.c (vmessage):
2937 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2938 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2939 prefer signed arithmetic to avoid comparison confusion.
2940 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2941 but is a bit tricky.
2942
0e926e56
PE
2943 Assume freestanding C89 headers, string.h, stdlib.h.
2944 * data.c, doprnt.c, floatfns.c, print.c:
2945 Include float.h unconditionally.
2946 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2947 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2948 * regex.c: Likewise for stddef.h, string.h.
2949 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2950 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2951 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2952 (STDC_HEADERS): Remove obsolete defines.
2953 * sysdep.c: Include limits.h unconditionally.
2954
9cfdb3ec
PE
2955 Assume support for memcmp, memcpy, memmove, memset.
2956 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2957 * regex.c (memcmp, memcpy):
2958 Remove; we assume C89 now.
2959
2960 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2961 (__malloc_safe_bcopy): Remove; no longer needed.
2962
cf950e6b 2963 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2964 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2965 well either way, and we prefer signed to unsigned.
2966
dbf38e02
LMI
29672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2968
2969 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2970 closes the connection while we're reading (bug#9182).
2971
d6f0886c 29722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2973
d6f0886c
JD
2974 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2975 are specified (Bug#9168).
24e0f6b1 2976
2eb1f9e6
PE
29772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2978
2979 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2980 Found by GCC static checking and --with-wide-int on a 32-bit host.
2981
22381272 29822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2983
2984 * xdisp.c (compute_display_string_pos): Fix logic of caching
2985 previous display string position. Initialize cached_prev_pos to
2986 -1. Fixes slow-down at the beginning of a buffer.
2987
f25e39b4
EZ
29882011-07-24 Eli Zaretskii <eliz@gnu.org>
2989
2990 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2991 for attrs[LFACE_FONTSET_INDEX].
2992
04c4b52e
PE
29932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2994
2995 * xml.c (parse_region): Remove unused local
2996 that was recently introduced.
2997
c1734fbd
EZ
29982011-07-23 Eli Zaretskii <eliz@gnu.org>
2999
be18c5a5
EZ
3000 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3001 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3002
c1734fbd
EZ
3003 * xdisp.c (move_it_in_display_line_to): Record the best matching
3004 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3005 exit if none of the characters scanned was an exact match.
3006 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3007 when exact match is impossible due to invisible text, and the
3008 lines are truncated.
3009
a258d627
JD
30102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3011
3012 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3013 for OSX >= 10.7.
3014
b6d5a689
EZ
30152011-07-22 Eli Zaretskii <eliz@gnu.org>
3016
0f74f785
EZ
3017 Fix a significant slow-down of cursor motion with C-n, C-p,
3018 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3019 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3020 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3021 (next_element_from_buffer): Call compute_stop_pos_backwards to
3022 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3023 base_level_stop.
3024 (reseat): Don't look for prev_stop, as that could mean a very long
3025 run.
3026 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3027 <cached_disp_overlay_modiff>: Cache for last found display string
3028 position.
551918c1 3029 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3030 about the same buffer in the same area of character positions, and
3031 the buffer wasn't changed since the time the display string
3032 position was cached.
551918c1 3033
b2d0c91a
EZ
30342011-07-22 Eli Zaretskii <eliz@gnu.org>
3035
3036 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3037 is an integer, which is important for empty lines. (Bug#9149)
3038
043604ee
CY
30392011-07-22 Chong Yidong <cyd@stupidchicken.com>
3040
3041 * frame.c (Fmodify_frame_parameters): In tty case, update the
3042 default face if necessary (Bug#4238).
3043
da4adb04
CY
30442011-07-21 Chong Yidong <cyd@stupidchicken.com>
3045
3046 * editfns.c (Fstring_to_char): No need to explain what a character
3047 is in the docstring (Bug#6576).
3048
9abd0532
LMI
30492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3050
3051 * xml.c (parse_region): Make sure we always return a tree.
3052
36881d16
HK
30532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3054
3055 * xml.c (parse_region): If a document contains only comments,
3056 return that, too.
3057
1e98674d
LMI
30582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3059
3060 * xml.c (make_dom): Return comments, too.
3061
590bd467
PE
30622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 Port to OpenBSD.
3065 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3066 and the surrounding thread.
3067 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3068 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3069 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3070 timer goes off.
3071 * s/openbsd.h (BROKEN_SIGIO): Define.
3072 * unexelf.c (unexec) [__OpenBSD__]:
3073 Don't update the .mdebug section of the Alpha COFF symbol table.
3074
f41628b2
LMI
30752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3076
3077 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3078 (bug#8460).
3079
b59b67c5
PE
30802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3081
15e3a074
PE
3082 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3083 This fixes some race conditions on the permissions of any newly
3084 created file.
3085
41bed37d
PE
3086 * alloc.c (valid_pointer_p): Use pipe, not open.
3087 This fixes some permissions issues when debugging.
3088
b59b67c5
PE
3089 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3090 If fchown fails to set both uid and gid, try to set just gid,
3091 as that is sometimes allowed. Adjust the file's mode to eliminate
3092 setuid or setgid bits that are inappropriate if fchown fails.
3093
925a6be7
SM
30942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3095
3096 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3097 to compare Lisp_Objects.
3098 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3099 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3100 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3101
52968808
AS
31022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3103
0a6a104b
AS
3104 * lread.c (read_integer): Unread even EOF character.
3105 (read1): Likewise. Properly record start position of symbol.
3106
52968808
AS
3107 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3108 symbol character follows.
3109
9e381cdd
PE
31102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3111
3112 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3113 This works around a problem with the previous change to Fcopy_file.
3114 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3115 and without this change, GCC might complain about discarding
3116 fchown's return value.
3117
b5641435
JB
31182011-07-16 Juanma Barranquero <lekktu@gmail.com>
3119
3120 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3121
a8031457
PE
31222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3123
3124 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3125
dd889327
LMI
31262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3127
750c33f7
LMI
3128 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3129 it's used from the C level.
3130
dd889327
LMI
3131 * process.c: Use the same condition for POLL_FOR_INPUT in both
3132 keyboard.c and process.c (bug#1858).
3133
87e86684
LM
31342011-07-09 Lawrence Mitchell <wence@gmx.li>
3135
3136 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3137 (Fgnutls_boot): Use it.
3138
64348f40
AS
31392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3140
3141 * doc.c (Fsubstitute_command_keys): Revert last change.
3142
1d698799
LMI
31432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3144
f863868c
LMI
3145 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3146 quotes the next character, and doesn't affect other longer
3147 sequences (bug#8935).
3148
1d698799
LMI
3149 * lread.c (syms_of_lread): Clarify that is isn't only
3150 `eval-buffer' and `eval-defun' that's affected by
3151 `lexical-binding' (bug#8460).
3152
aa4b6df6
EZ
31532011-07-15 Eli Zaretskii <eliz@gnu.org>
3154
3155 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3156 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3157
5d856da6
PE
31582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3159
ad6042bb
PE
3160 Fix minor problems found by static checking.
3161 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3162 (elsz): Now a signed constant, not a size_t var. We prefer signed
3163 types to unsigned, to avoid integer comparison confusion. Without
3164 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3165 "cannot optimize loop, the loop counter may overflow", a symptom
3166 of the confusion.
f00bbb22 3167 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3168 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3169
6468f31c
LMI
31702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3171
49080b10
LMI
3172 * search.c (Fre_search_backward): Mention `case-fold-search' in
3173 all the re_search_* functions (bug#8138).
3174
6468f31c
LMI
3175 * keyboard.c (Fopen_dribble_file): Document when the file is
3176 closed (bug#8056).
3177
c965adc5
EZ
31782011-07-14 Eli Zaretskii <eliz@gnu.org>
3179
df9733bf
EZ
3180 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3181 bidi_cache_idx.
3182
0bb23927
EZ
3183 Support bidi reordering of display and overlay strings.
3184 * xdisp.c (compute_display_string_pos)
3185 (compute_display_string_end): Accept additional argument STRING.
3186 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3187 (reseat_to_string): Initialize bidi_it->string.s and
3188 bidi_it->string.schars.
3189 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3190 NULL (avoids a crash in bidi_paragraph_init).
3191 Initialize itb.string.lstring.
0bb23927
EZ
3192 (init_iterator): Call bidi_init_it only of a valid
3193 buffer position was specified. Initialize paragraph_embedding to
3194 L2R.
3195 (reseat_to_string): Initialize the bidi iterator.
3196 (display_string): If we need to ignore text properties of
3197 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3198 original value of -1 will not work with bidi.)
3199 (compute_display_string_pos): First arg is now struct
3200 `text_pos *'; all callers changed. Support display properties on
3201 Lisp strings.
3202 (compute_display_string_end): Support display properties on Lisp
3203 strings.
3204 (init_iterator, reseat_1, reseat_to_string): Initialize the
3205 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3206 when iterating on a string not from display properties).
640c8776
SM
3207 (compute_display_string_pos, compute_display_string_end):
3208 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3209 arrow keys.
3210 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3211 base_level_stop; instead, set base_level_stop to BEGV.
3212 Fixes crashes in vertical-motion.
0bb23927
EZ
3213 (next_element_from_buffer): Improve commentary for when
3214 the iterator is before prev_stop.
3215 (init_iterator): Initialize bidi_p from the default value of
3216 bidi-display-reordering, not from buffer-local value. Use the
3217 buffer-local value only if initializing for buffer iteration.
3218 (handle_invisible_prop): Support invisible properties on strings
3219 that are being bidi-reordered.
3220 (set_iterator_to_next): Support bidi reordering of C strings and
3221 Lisp strings.
3222 (next_element_from_string): Support bidi reordering of Lisp
3223 strings.
3224 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3225 (display_string): Support display of R2L glyph rows.
3226 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3227 (init_iterator): Don't initialize it->bidi_p for strings
3228 here.
3229 (reseat_to_string): Initialize it->bidi_p for strings here.
3230 (next_element_from_string, next_element_from_c_string)
3231 (next_element_from_buffer): Add xassert's for correspondence
3232 between IT's object being iterated and it->bidi_it.string
3233 structure.
3234 (face_before_or_after_it_pos): Support bidi iteration.
3235 (next_element_from_c_string): Handle the case of the first string
3236 character that is not the first one in the visual order.
3237 (get_visually_first_element): New function, refactored from common
3238 parts of next_element_from_buffer, next_element_from_string, and
3239 next_element_from_c_string.
3240 (tool_bar_lines_needed, redisplay_tool_bar)
3241 (display_menu_bar): Force left-to-right direction. Add a FIXME
3242 comment for making that be controlled by a user option.
3243 (push_it, pop_it): Save and restore the state of the
3244 bidi iterator. Save and restore the bidi_p flag.
3245 (pop_it): Iterate out of display property for string iteration as
3246 well.
3247 (iterate_out_of_display_property): Support iteration over strings.
3248 (handle_single_display_spec): Set up it->bidi_it for iteration
3249 over a display string, and call bidi_init_it.
3250 (handle_single_display_spec, next_overlay_string)
3251 (get_overlay_strings_1, push_display_prop): Set up the bidi
3252 iterator for displaying display or overlay strings.
3253 (forward_to_next_line_start): Don't use the shortcut if
3254 bidi-iterating.
3255 (back_to_previous_visible_line_start): If handle_display_prop
3256 pushed the iterator stack, restore the internal state of the bidi
3257 iterator by calling bidi_pop_it same number of times.
3258 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3259 and we are bidi-iterating, don't decrement the iterator position;
3260 instead, set the first_elt flag in the bidi iterator, to produce
3261 the same effect.
3262 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3263 (push_display_prop): xassert that we are iterating a buffer.
3264 (push_it, pop_it): Save and restore paragraph_embedding member.
3265 (handle_single_display_spec, next_overlay_string)
3266 (get_overlay_strings_1, reseat_1, reseat_to_string)
3267 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3268 correctly. Don't assume unibyte strings are not bidi-reordered.
3269 (compute_display_string_pos)
3270 (compute_display_string_end): Fix handling the case of C string.
3271 (push_it, pop_it): Save and restore from_disp_prop_p.
3272 (handle_single_display_spec, push_display_prop): Set the
3273 from_disp_prop_p flag.
3274 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3275 (pop_it): Call iterate_out_of_display_property only if we are
3276 popping after iteration over a string that came from a display
3277 property. Fix a typo in popping stretch info. Add an assertion
3278 for verifying that the iterator position is in sync with the bidi
3279 iterator.
3280 (handle_single_display_spec, get_overlay_strings_1)
3281 (push_display_prop): Fix initialization of paragraph direction for
3282 string when that of the parent object is not yet determined.
3283 (reseat_1): Call bidi_init_it to resync the bidi
3284 iterator with IT's position. (Bug#7616)
3285 (find_row_edges): If ROW->start.pos gives position
3286 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3287 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3288 Reset the from_disp_prop_p flag.
3289 (SAVE_IT, RESTORE_IT): New macros.
3290 (pos_visible_p, face_before_or_after_it_pos)
3291 (back_to_previous_visible_line_start)
3292 (move_it_in_display_line_to, move_it_in_display_line)
3293 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3294 (try_scrolling, redisplay_window, display_line): Use them when
3295 saving a temporary copy of the iterator and restoring it back.
3296 (back_to_previous_visible_line_start, reseat_1)
3297 (init_iterator): Empty the bidi cache "stack".
3298 (move_it_in_display_line_to): If iterator ended up at
3299 EOL, but we never saw any buffer positions smaller than
3300 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3301 motion in bidi-reordered lines.
3302 (move_it_in_display_line_to): Record prev_method and prev_pos
3303 immediately before the call to set_iterator_to_next. Fixes cursor
3304 motion in bidi-reordered lines with stretch glyphs and strings
3305 displayed in margins. (Bug#8133) (Bug#8867)
3306 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3307 TO_CHARPOS.
640c8776
SM
3308 (pos_visible_p): Support positions in bidi-reordered lines.
3309 Save and restore bidi cache.
0bb23927
EZ
3310
3311 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3312 (bidi_paragraph_info): Delete unused struct.
3313 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3314 (bidi_cache_start): New variable.
3315 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3316 to zero.
3317 (bidi_cache_fetch_state, bidi_cache_search)
3318 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3319 (bidi_cache_find, bidi_peek_at_next_level)
3320 (bidi_level_of_next_char, bidi_find_other_level_edge)
3321 (bidi_move_to_visually_next): Compare cache index with
3322 bidi_cache_start rather than with zero.
3323 (bidi_fetch_char): Accept new argument STRING; all callers
3324 changed. Support iteration over a string. Support strings with
3325 display properties. Support unibyte strings. Fix the type of
3326 `len' according to what STRING_CHAR_AND_LENGTH expects.
3327 (bidi_paragraph_init, bidi_resolve_explicit_1)
3328 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3329 (bidi_level_of_next_char, bidi_move_to_visually_next):
3330 Support iteration over a string.
0bb23927
EZ
3331 (bidi_set_sor_type, bidi_resolve_explicit_1)
3332 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3333 can now be zero (for strings); special values 0 and -1 were
3334 changed to -1 and -2, respectively.
3335 (bidi_char_at_pos): New function.
3336 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3337 Call it instead of FETCH_MULTIBYTE_CHAR.
3338 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3339 initialized to valid values.
3340 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3341 values.
3342 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3343 the test for valid cached positions. Fix the logic for looking up
3344 the sentinel state in the cache. GCPRO the Lisp string we are
3345 iterating.
3346 (bidi_push_it, bidi_pop_it): New functions.
3347 (bidi_initialize): Initialize the bidi cache start stack pointer.
3348 (bidi_cache_ensure_space): New function, refactored from part of
3349 bidi_cache_iterator_state. Don't assume the required size is just
3350 one BIDI_CACHE_CHUNK away.
3351 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3352 (bidi_count_bytes, bidi_char_at_pos): New functions.
3353 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3354 always valid if bidi_cache_idx is valid.
3355 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3356 is valid if it's going to be used.
3357 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3358 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3359 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3360 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3361 (bidi_find_other_level_edge, bidi_cache_start_stack):
3362 All variables related to cache indices are now EMACS_INT.
c965adc5 3363
0bb23927
EZ
3364 * dispextern.h (struct bidi_string_data): New structure.
3365 (struct bidi_it): New member `string'. Make flag members be 1-bit
3366 fields, and put them last in the struct.
640c8776
SM
3367 (compute_display_string_pos, compute_display_string_end):
3368 Update prototypes.
0bb23927
EZ
3369 (bidi_push_it, bidi_pop_it): Add prototypes.
3370 (struct iterator_stack_entry): New members bidi_p,
3371 paragraph_embedding, and from_disp_prop_p.
3372 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3373 (bidi_shelve_cache, bidi_unshelve_cache):
3374 Declare prototypes.
0bb23927
EZ
3375
3376 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3377 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3378 and vector-like objects.
3379
3380 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3381 cache around display iteration.
3382
3383 * window.c (Fwindow_end, window_scroll_pixel_based)
3384 (displayed_window_lines, Frecenter): Save and restore the bidi
3385 cache around display iteration.
3386
3bbd2265
LMI
33872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3388
3389 * editfns.c (Fdelete_region): Clarify the use of the named
3390 parameters (bug#6788).
3391
adc47434
MR
33922011-07-14 Martin Rudalics <rudalics@gmx.at>
3393
3394 * indent.c (Fvertical_motion): Set and restore w->pointm when
3395 saving and restoring the window's buffer (Bug#9006).
3396
837c31f8
LMI
33972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3398
3399 * editfns.c (Fstring_to_char): Clarify just what is returned
3400 (bug#6576). Text by Eli Zaretskii.
3401
ac389d0c
JB
34022011-07-13 Juanma Barranquero <lekktu@gmail.com>
3403
3404 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3405
0be0ce47
EZ
34062011-07-13 Eli Zaretskii <eliz@gnu.org>
3407
3408 * buffer.c (mmap_find): Fix a typo.
3409
cd18e7e3
JB
34102011-07-13 Johan Bockgård <bojohan@gnu.org>
3411
3412 Fix execution of x selection hooks.
3413 * xselect.c (Qx_lost_selection_functions)
3414 (Qx_sent_selection_functions): New vars.
3415 (syms_of_xselect): DEFSYM them.
3416 (x_handle_selection_request): Pass Qx_sent_selection_functions
3417 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3418 (x_handle_selection_clear,x_clear_frame_selections):
3419 Pass Qx_lost_selection_functions rather than
3420 Vx_lost_selection_functions to Frun_hook_with_args.
3421
47ea7f44
PE
34222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3423
ac389d0c 3424 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3425 The old code sometimes used this field without initializing it.
3426
47ea7f44
PE
3427 * alloc.c (gc_sweep): Don't read past end of array.
3428 In theory, the old code could also have corrupted Emacs internals,
3429 though it'd be very unlikely.
3430
bc985c87
AS
34312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3432
3433 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3434 argument. (Bug#4026)
bc985c87 3435
0cf34688
LMI
34362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3437
b3dadd76
LMI
3438 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3439 key" (bug#4257).
3440
0cf34688
LMI
3441 * window.c (Fset_window_start): Doc fix (bug#4199).
3442 (Fset_window_hscroll): Ditto.
3443
270768cd
PE
34442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3445
077e3dda 3446 Fix minor new problems caught by GCC 4.6.1.
270768cd 3447 * term.c (init_tty): Remove unused local.
490011a6 3448 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3449 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3450 not used otherwise.
270768cd 3451
b1f58454
CY
34522011-07-12 Chong Yidong <cyd@stupidchicken.com>
3453
3454 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3455
22b9578d
LMI
34562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3457
6e70ab07
LMI
3458 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3459 are the mini-buffer and the echo area (bug#3320).
3460
22b9578d
LMI
3461 * term.c (init_tty): Remove support for supdup, c10 and perq
3462 terminals, which are no longer supported (bug#1482).
3463
8974cc9f
JB
34642011-07-10 Johan Bockgård <bojohan@gnu.org>
3465
3466 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3467
a560d974
JD
34682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3469
3470 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3471 for non-popups (Bug#3642).
3472
1dae0f0a
AS
34732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3474
268c2c36 3475 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3476 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3477 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3478 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3479 * data.c (fmod): Likewise.
3480 * dispnew.c (swap_glyphs_in_rows): Likewise.
3481 * emacs.c (memory_warning_signal): Likewise.
3482 * floatfns.c (float_error): Likewise.
3483 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3484 (otf_open, font_otf_capability, generate_otf_features)
3485 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3486 Likewise.
3487 * image.c (pbm_read_file): Likewise.
3488 * indent.c (string_display_width): Likewise.
3489 * intervals.c (check_for_interval, search_for_interval)
3490 (inc_interval_count, count_intervals, root_interval)
3491 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3492 * lread.c (defalias): Likewise.
268c2c36 3493 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3494 * regex.c (set_image_of_range_1, set_image_of_range)
3495 (regex_grow_registers): Likewise.
3496 * sysdep.c (strerror): Likewise.
3497 * termcap.c (valid_filename_p, tprint, main): Likewise.
3498 * tparam.c (main): Likewise.
3499 * unexhp9k800.c (run_time_remap, save_data_space)
3500 (update_file_ptrs, read_header, write_header, calculate_checksum)
3501 (copy_file, copy_rest, display_header): Likewise.
3502 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3503 Likewise.
3504 * xdisp.c (check_it): Likewise.
3505 * xfaces.c (register_color, unregister_color, unregister_colors):
3506 Likewise.
3507 * xfns.c (print_fontset_result): Likewise.
3508 * xrdb.c (member, fatal, main): Likewise.
3509
99033785
PE
35102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3511
3512 Fix minor problems found by static checking (Bug#9031).
3513 * chartab.c (char_table_set_range, map_sub_char_table):
3514 Remove unused locals.
3515 (uniprop_table): Now static.
3516 * composite.c (_work_char): Remove unused static var.
3517
9cb2ac56
JB
35182011-07-09 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3521
f25661f0
JD
35222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3523
3524 * gtkutil.c (qttip_cb): Remove code without function.
3525
8278c4fe
EZ
35262011-07-09 Eli Zaretskii <eliz@gnu.org>
3527
3528 * w32.c (pthread_sigmask): New stub.
3529
1692ae2d 35302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3531
8a6ebd58 3532 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3533 sigprocmask is portable only for single-threaded applications, and
3534 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3535 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3536 (LIBES): Use it.
3537 * callproc.c (Fcall_process):
3538 * process.c (create_process):
3539 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3540 Use pthread_sigmask, not sigprocmask.
123403e4 3541
1b854618
JD
35422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3543
3544 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3545 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3546 wrong (Bug#8591).
3547
3fe4b549
JD
35482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3549
0ce7e563
JD
3550 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3551 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3552 (xg_hide_tooltip): Fix comment.
3553
3fe4b549
JD
3554 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3555 in registerServicesMenuSendTypes.
3556 (validRequestorForSendType): Don't check ns_return_types.
3557
3558 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3559 ns_return_type.
3560
5df75e47
JR
35612011-07-08 Jason Rumney <jasonr@gnu.org>
3562
22610910
JR
3563 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3564 SH_SHOW for hidden windows (Bug#5482).
3565
5df75e47
JR
3566 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3567 frame struct members of non-existent frames (Bug#6284).
3568
699c10bd
JD
35692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3570
4393663b
JD
3571 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3572 variable firstTime not needed on OSX >= 10.6.
3573 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3574 >= 10.5. Use setKnobProportion, setDoubleValue.
3575
3576 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3577 (MAC_OS_X_VERSION_10_5): Define if not defined.
3578 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3579 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3580 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3581
3582 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3583 cString and lossyCString on OSX >= 10.4
3584
58179cce 3585 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3586 sizeToFit on OSX >= 10.2.
3587
3588 * nsimage.m (allocInitFromFile): Don't use deprecated method
3589 bestRepresentationForDevice on OSX >= 10.6.
3590
3591 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3592 to avoid warning.
3593
3594 * emacs.c: Declare unexec_init_emacs_zone.
3595
a63e0781
JD
3596 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3597
699c10bd
JD
3598 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3599
3600 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3601 on svcsMenu (Bug#8842).
3602
3603 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3604 ns_return_types.
3605 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3606
3607 * nsterm.m (QUTF8_STRING): Declare.
3608 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3609 (validRequestorForSendType): Return type is (id).
3610 Change indexOfObjectIdenticalTo to indexOfObject.
3611 Check if we have local selection before returning self (Bug#8842).
3612 (writeSelectionToPasteboard): Put local selection into paste board
3613 if we have a local selection (Bug#8842).
3614 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3615
3616 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3617 (ns_get_local_selection): Declare.
3618
54e10184
LMI
36192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3620
9888ff71
LMI
3621 * keymap.c (describe_map_tree): Don't insert a double newline at
3622 the end of the buffer (bug#1169) and return whether we inserted
3623 something.
3624
54e10184
LMI
3625 * callint.c (Fcall_interactively): Change "reading args" to
3626 "providing args" to try to clarify what it does (bug#1010).
3627
15fa4783
KH
36282011-07-07 Kenichi Handa <handa@m17n.org>
3629
3630 * composite.c (composition_compute_stop_pos): Ignore a static
3631 composition starting before CHARPOS (Bug#8915).
3632
3633 * xdisp.c (handle_composition_prop): Likewise.
3634
a8815b00
EZ
36352011-07-07 Eli Zaretskii <eliz@gnu.org>
3636
3637 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3638 (Bug#9015)
3639
ef7b981d 36402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3641
3642 * character.h (unicode_category_t): New enum type.
3643
3644 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3645 (Qchar_code_property_table): New variable.
3646 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3647 (UNIPROP_COMPRESSED_FORM_P): New macros.
3648 (char_table_ascii): Uncompress the compressed values.
3649 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3650 Uncompress the compressed values.
ac389d0c 3651 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3652 (char_table_ref_and_range): Uncompress the compressed values.
3653 (sub_char_table_set): New arg is_uniprop. Callers changed.
3654 Uncompress the compressed values.
3655 (sub_char_table_set_range): Args changed. Callers changed.
3656 (char_table_set_range): Adjuted for the above change.
3657 (map_sub_char_table): Delete args default_val and parent. Add arg
3658 top. Give decoded values to a Lisp function.
640c8776 3659 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3660 values to a Lisp function. Gcpro more variables.
3661 (uniprop_table_uncompress)
3662 (uniprop_decode_value_run_length): New functions.
3663 (uniprop_decoder, uniprop_decoder_count): New variables.
3664 (uniprop_get_decoder, uniprop_encode_value_character)
3665 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3666 New functions.
3667 (uniprop_encoder, uniprop_encoder_count): New variables.
3668 (uniprop_get_encoder, uniprop_table)
3669 (Funicode_property_table_internal, Fget_unicode_property_internal)
3670 (Fput_unicode_property_internal): New functions.
3671 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3672 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3673 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3674 char-code-property-alist.
3675
640c8776 3676 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3677 Vunicode_category_table.
3678
640c8776 3679 * font.c (font_range): Adjust for the change of
c805dec0
KH
3680 Vunicode_category_table.
3681
76b397fb
DN
36822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3683
3684 * m/iris4d.h: Remove file, move contents ...
3685 * s/irix6-5.h: ... here.
3686
22b4128e
PE
36872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3690 * alloc.c (mark_buffer):
3691 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3692 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3693 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3694 This isn't true in general, and it's particularly not true
3695 if Emacs is configured with --with-wide-int.
3696 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3697 New macros, used in the buffer.c change.
3698
869795d6
JD
36992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3700
3701 * xsettings.c: Use both GConf and GSettings if both are available.
3702 (store_config_changed_event): Add comment.
3703 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3704 (store_tool_bar_style_changed): New functions.
5e617bc2 3705 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3706 (struct xsettings): Move font inside HAVE_XFT.
3707 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3708 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3709 Move inside HAVE_XFT.
640c8776 3710 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3711 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3712 also.
3713 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3714 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3715 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3716 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3717 (parse_settings): Move check for font inside HAVE_XFT.
3718 (read_settings, apply_xft_settings): Add comment.
3719 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3720 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3721 call store_font_name_changed.
3722 (xft_settings_event): Add comment.
3723 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3724 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3725 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3726 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3727 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3728 (xsettings_get_system_font, xsettings_get_system_normal_font):
3729 Add comment.
869795d6 3730
d8ed26bd
PE
37312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 Random fixes. E.g., (random) never returned negative values.
3734 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3735 subseconds part to the entropy, as that's a bit more random.
3736 Prefer signed to unsigned, since the signedness doesn't matter and
3737 in general we prefer signed. When given a limit, use a
3738 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3739 latter isn't right if USE_2_TAGS_FOR_INTS.
3740 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3741 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3742
cabf1cac
SM
37432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3744
3745 * textprop.c (text_property_stickiness):
3746 Obey Vtext_property_default_nonsticky.
3747 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3748 * w32fns.c (syms_of_w32fns):
3749 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3750
6e9b2be9
PE
37512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3752
3753 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3754 This is more efficient than Ffile_directory_p and avoids a minor race.
3755
90186c68
LMI
37562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3757
7c301272
LMI
3758 * buffer.c (Foverlay_put): Say what the return value is
3759 (bug#7835).
3760
c4f2d8d4
LMI
3761 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3762 is a directory before asking whether to use the file name
3763 (bug#7564).
ad637907
LMI
3764 (barf_or_query_if_file_exists): Make the "File is a directory"
3765 error be more correct.
c4f2d8d4 3766
90186c68
LMI
3767 * fns.c (Frequire): Remove the mention of the .gz files, since
3768 that's installation-specific, but keep the mention of
3769 `get-load-suffixes'.
3770
da64016e
PE
37712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3772
3773 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3774 Report string overflow if the output is too long.
3775
7d47b580
JB
37762011-07-04 Juanma Barranquero <lekktu@gmail.com>
3777
a555cb87
JB
3778 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3779 (syms_of_gnutls): Remove duplicate DEFSYM for
3780 Qgnutls_bootprop_verify_hostname_error, an error for
3781 Qgnutls_bootprop_verify_error (which is no longer used).
3782
7d47b580
JB
3783 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3784 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3785 Also (re)move comments that are misplaced or no longer relevant.
3786
1e49bfab
LMI
37872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3788
3789 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3790
1485f4c0
CY
37912011-07-03 Chong Yidong <cyd@stupidchicken.com>
3792
3793 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3794 and background color parameters if they have been changed.
3795
a9ab721e
LMI
37962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3797
3798 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3799
cf7cff57
PE
38002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3801
2e13213d
PE
3802 * xsettings.c (SYSTEM_FONT): Define only when used.
3803 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3804
cf7cff57
PE
3805 * keymap.c (access_keymap_1): Now static.
3806
7a8e04f7
CY
38072011-07-02 Chong Yidong <cyd@stupidchicken.com>
3808
3809 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3810 leave any prefix arg for the up event (Bug#1586).
3811
61352f62
LMI
38122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3813
69bb1ef7
LMI
3814 * lread.c (syms_of_lread): Mention single symbols defined by
3815 `defvar' or `defconst' (bug#7154).
3816
61352f62 3817 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3818 (Frequire): Mention get-load-suffixes.
61352f62 3819
28545e04
MR
38202011-07-02 Martin Rudalics <rudalics@gmx.at>
3821
3822 * window.h (window): Remove clone_number slot.
3823 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3824 Remove.
3825 (make_parent_window, make_window, saved_window)
3826 (Fset_window_configuration, save_window_save): Don't deal with
3827 clone numbers.
3828 * buffer.c (Qclone_number): Remove declaration.
3829 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3830
3349e122
SM
38312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3832
3833 Add multiple inheritance to keymaps.
3834 * keymap.c (Fmake_composed_keymap): New function.
3835 (Fset_keymap_parent): Simplify.
3836 (fix_submap_inheritance): Remove.
3837 (access_keymap_1): New function extracted from access_keymap to handle
3838 embedded parents and handle lists of maps.
3839 (access_keymap): Use it.
3840 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3841 (Fcopy_keymap): Handle embedded parents.
3842 (Fcommand_remapping, define_as_prefix): Simplify.
3843 (Fkey_binding): Simplify.
3844 (syms_of_keymap): Move minibuffer-local-completion-map,
3845 minibuffer-local-filename-completion-map,
3846 minibuffer-local-must-match-map, and
3847 minibuffer-local-filename-must-match-map to Elisp.
3848 (syms_of_keymap): Defsubr make-composed-keymap.
3849 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3850 (parse_menu_item): Trivial simplification.
3851
3279eb87
GM
38522011-07-01 Glenn Morris <rgm@gnu.org>
3853
3854 * Makefile.in (SETTINGS_LIBS): Fix typo.
3855
4550efdf
KI
38562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3857
3858 * coding.c (Fencode_coding_string): Record the last coding system
3859 used, as the function doc string says (bug#8738).
3860
0949d2b6
JD
38612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3862
3863 * xsettings.c (store_monospaced_changed): Take new font as arg and
3864 check for change against current_mono_font.
3865 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3866 (emacs_settings_constructor, emacs_settings_get_property)
3867 (emacs_settings_set_property, emacs_settings_class_init)
3868 (emacs_settings_init, gsettings_obj): Remove.
3869 (something_changedCB): New function for HAVE_GSETTINGS.
3870 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3871 with value as argument.
3872 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3873 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3874 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3875 "changed".
3876
3877 * xgselect.c: Add defined (HAVE_GSETTINGS).
3878 (xgselect_initialize): Ditto.
3879
3880 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3881 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3882 xg_select.
3883
bbc6b304
PE
38842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * eval.c (struct backtrace): Simplify and port the data structure.
3887 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3888 signed bit field, as this assumption is not portable and it makes
3889 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3890 "char debug_on_exit : 1" as this is not portable either; instead,
3891 use the portable "unsigned int debug_on_exit : 1". Remove unused
3892 member evalargs. Remove obsolete comments about cc bombing out.
3893
9851bfc5
JD
38942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3895
51bb811f 3896 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3897 Let HAVE_GSETTINGS override HAVE_GCONF.
3898 (store_monospaced_changed): New function.
3899 (EMACS_SETTINGS): A new type derived from GObject to handle
3900 GSettings notifications.
3901 (emacs_settings_constructor, emacs_settings_get_property)
3902 (emacs_settings_set_property, emacs_settings_class_init):
3903 New functions.
3904 (gsettings_client, gsettings_obj): New variables.
3905 (GSETTINGS_SCHEMA): New define.
3906 (something_changedCB): Call store_monospaced_changed.
3907 (init_gsettings): New function.
3908 (xsettings_initialize): Call init_gsettings.
3909 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3910 to NULL.
3911
640c8776 3912 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3913 GCONF_CFLAGS/LIBS.
3914
5386012d
MR
39152011-06-29 Martin Rudalics <rudalics@gmx.at>
3916
3917 * window.c (resize_root_window, grow_mini_window)
3918 (shrink_mini_window): Rename Qresize_root_window to
3919 Qwindow_resize_root_window and Qresize_root_window_vertically to
3920 Qwindow_resize_root_window_vertically.
3921
f13e0b08
PE
39222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3925
94515237
JB
39262011-06-27 Juanma Barranquero <lekktu@gmail.com>
3927
3928 * makefile.w32-in: Redesign dependencies so they reflect more
3929 clearly which files are directly included by each source file,
3930 and not through other includes.
3931
e43b6e43
MR
39322011-06-27 Martin Rudalics <rudalics@gmx.at>
3933
3934 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3935 (sort_overlays, overlay_strings): When an overlay's clone number
3936 matches the window's clone number process the overlay even if
3937 the overlay's window property doesn't match the current window.
3938
d68443dc
MR
3939 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3940 (Fwindow_hchild): Rename to Fwindow_left_child.
3941 (Fwindow_next): Rename to Fwindow_next_sibling.
3942 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3943 (resize_window_check): Rename to window_resize_check.
3944 (resize_window_apply): Rename to window_resize_apply.
3945 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3946 (Fdelete_other_windows_internal, resize_frame_windows)
3947 (Fsplit_window_internal, Fdelete_window_internal)
3948 (grow_mini_window, shrink_mini_window)
3949 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3950
c7e73be5
JD
39512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3952
3953 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3954 (emacs_fixed_set_min_size): Remove.
3955 (emacs_fixed_new): Take frame as argument.
3956
3957 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3958 (_EmacsFixedPrivate): Remove minwidth/height.
3959 Add struct frame *f.
3960 (emacs_fixed_init): Initialize priv->f.
3961 (get_parent_class, emacs_fixed_set_min_size): Remove.
3962 (emacs_fixed_new): Set priv->f to argument.
3963 (emacs_fixed_get_preferred_width)
3964 (emacs_fixed_get_preferred_height): Use min_width/height from
3965 frames size_hint to set minimum and natural (Bug#8919).
3966 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3967 and use min_width/height from frames size_hint to set
3968 min_width/height (Bug#8919).
3969
3970 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3971 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3972 Fix indentation.
c7e73be5 3973
cf99dcf8
EZ
39742011-06-26 Eli Zaretskii <eliz@gnu.org>
3975
3976 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3977 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3978 called at ZV.
3979
029529ac
CY
39802011-06-26 Chong Yidong <cyd@stupidchicken.com>
3981
3982 * process.c (wait_reading_process_output): Bypass select if
3983 waiting for a cell while ignoring keyboard input, and input is
3984 pending. Suggested by Jan Djärv (Bug#8869).
3985
7a7ef429
PE
39862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Use gnulib's dup2 module instead of rolling our own.
3989 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3990
11fdef7d 39912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3992
3993 * dispnew.c (scrolling_window): Before scrolling, turn off a
3994 mouse-highlight in the window being scrolled.
3995
cd3520a4
JB
39962011-06-24 Juanma Barranquero <lekktu@gmail.com>
3997
3998 Move DEFSYM to lisp.h and use everywhere.
3999
4000 * character.h (DEFSYM): Move declaration...
4001 * lisp.h (DEFSYM): ...here.
4002
4003 * gnutls.c:
4004 * minibuf.c:
4005 * w32menu.c:
4006 * w32proc.c:
4007 * w32select.c: Don't include character.h.
4008
4009 * alloc.c (syms_of_alloc):
4010 * buffer.c (syms_of_buffer):
4011 * bytecode.c (syms_of_bytecode):
4012 * callint.c (syms_of_callint):
4013 * casefiddle.c (syms_of_casefiddle):
4014 * casetab.c (init_casetab_once):
4015 * category.c (init_category_once, syms_of_category):
4016 * ccl.c (syms_of_ccl):
4017 * cmds.c (syms_of_cmds):
4018 * composite.c (syms_of_composite):
4019 * dbusbind.c (syms_of_dbusbind):
4020 * dired.c (syms_of_dired):
4021 * dispnew.c (syms_of_display):
4022 * doc.c (syms_of_doc):
4023 * editfns.c (syms_of_editfns):
4024 * emacs.c (syms_of_emacs):
4025 * eval.c (syms_of_eval):
4026 * fileio.c (syms_of_fileio):
4027 * fns.c (syms_of_fns):
4028 * frame.c (syms_of_frame):
4029 * fringe.c (syms_of_fringe):
4030 * insdel.c (syms_of_insdel):
4031 * keymap.c (syms_of_keymap):
4032 * lread.c (init_obarray, syms_of_lread):
4033 * macros.c (syms_of_macros):
4034 * msdos.c (syms_of_msdos):
4035 * print.c (syms_of_print):
4036 * process.c (syms_of_process):
4037 * search.c (syms_of_search):
4038 * sound.c (syms_of_sound):
4039 * syntax.c (init_syntax_once, syms_of_syntax):
4040 * terminal.c (syms_of_terminal):
4041 * textprop.c (syms_of_textprop):
4042 * undo.c (syms_of_undo):
4043 * w32.c (globals_of_w32):
4044 * window.c (syms_of_window):
4045 * xdisp.c (syms_of_xdisp):
4046 * xfaces.c (syms_of_xfaces):
4047 * xfns.c (syms_of_xfns):
4048 * xmenu.c (syms_of_xmenu):
4049 * xsettings.c (syms_of_xsettings):
4050 * xterm.c (syms_of_xterm): Use DEFSYM.
4051
4228cf16
TZ
40522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4053
cd3520a4 4054 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4055
7fcccf1e
PE
40562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4057
7efb4e0e
PE
4058 Integer and buffer overflow fixes (Bug#8873).
4059
ff5844ad
PE
4060 * print.c (printchar, strout): Check for string overflow.
4061 (PRINTPREPARE, printchar, strout):
4062 Don't set size unless allocation succeeds.
4063
90532f02
PE
4064 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4065 for sizes. Check for string overflow more accurately.
4066 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4067
6d84508d
PE
4068 * macros.c: Integer and buffer overflow fixes.
4069 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4070 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4071 Use ptrdiff_t, not int, for sizes.
4072 Don't increment bufsize until after realloc succeeds.
4073 Check for size-calculation overflow.
4074 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4075
437b2cb4
PE
4076 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4077
8b9ac8b4
PE
4078 * lread.c: Integer overflow fixes.
4079 (read_integer): Radix is now EMACS_INT, not int,
4080 to improve quality of diagnostics for out-of-range radices.
4081 Calculate buffer size correctly for out-of-range radices.
4082 (read1): Check for integer overflow in radices, and in
4083 read-circle numbers.
82cb60d3
PE
4084 (read_escape): Avoid int overflow.
4085 (Fload, openp, read_buffer_size, read1)
4086 (substitute_object_recurse, read_vector, read_list, map_obarray):
4087 Use ptrdiff_t, not int, for sizes.
4088 (read1): Use EMACS_INT, not int, for sizes.
20270765 4089 Check for size overflow.
8b9ac8b4 4090
7fcccf1e
PE
4091 * image.c (cache_image): Check for size arithmetic overflow.
4092
bfbbd7e7
PE
4093 * lread.c: Integer overflow issues.
4094 (saved_doc_string_size, saved_doc_string_length)
4095 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4096 Now ptrdiff_t, not int.
4097 (read1): Don't assume doc string length fits in int. Check for
4098 out-of-range doc string lengths.
4099 (read_list): Don't assume file position fits in int.
39019e54 4100 (read_escape): Check for hex character overflow.
bfbbd7e7 4101
4e323265
LL
41022011-06-22 Leo Liu <sdl.web@gmail.com>
4103
4104 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4105 Move to minibuffer.el.
4106
85fece3e
PE
41072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4108
20b84ce9 4109 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4110 The following patches are for when GLYPH_DEBUG && !XASSERT.
4111 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4112 * dispnew.c (flush_stdout):
4113 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4114 Mark as externally visible.
4115 * dispnew.c (check_window_matrix_pointers): Now static.
4116 * dispnew.c (window_to_frame_vpos):
4117 * xfns.c (unwind_create_frame):
4118 * xterm.c (x_check_font): Remove unused local.
4119 * scroll.c (CHECK_BOUNDS):
4120 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4121 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4122 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4123 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4124 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4125 Now static.
4126 (debug_method_add): Use va_list and vsprintf rather than relying
4127 on undefined behavior with wrong number of arguments.
4128 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4129 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4130 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4131 since we're not interested in debugging glyphs with old libraries.
4132 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4133 GCC 4.6.0's static checking.
4134
0766b489
PE
41352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4136
31fd4b32
PE
4137 Integer overflow and signedness fixes (Bug#8873).
4138 A few related buffer overrun fixes, too.
4139
b79e8648
PE
4140 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4141
0766b489
PE
4142 * dispextern.h (struct face.stipple):
4143 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4144 (x_bitmap_mask, x_allocate_bitmap_record)
4145 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4146 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4147 (x_create_bitmap_from_xpm_data):
4148 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4149 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4150 (.bitmaps_last):
4151 * xfaces.c (load_pixmap):
4152 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4153 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4154 (.bitmaps_last, struct x_output.icon_bitmap):
4155 Use ptrdiff_t, not int, for bitmap indexes.
4156 (x_allocate_bitmap_record): Check for size overflow.
4157 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4158
b081724f
PE
4159 Use ptrdiff_t, not int, for overlay counts.
4160 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4161 * editfns.c (overlays_around, get_pos_property):
4162 * textprop.c (get_char_property_and_overlay):
4163 * xdisp.c (next_overlay_change, note_mouse_highlight):
4164 * xfaces.c (face_at_buffer_position):
21514da7
PE
4165 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4166 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4167 (Fnext_overlay_change, Fprevious_overlay_change)
4168 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4169 Use ptrdiff_t, not int, for sizes.
21514da7 4170 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4171
3de73e5e
PE
4172 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4173
2606c57b
PE
4174 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4175 (x_session_initialize): Do not assume string length fits in int.
4176
aaafe47a
PE
4177 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4178 This is unlikely, but can occur if DPI is outlandish.
4179
2674ddc8 4180 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4181 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4182
28154962
PE
4183 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4184 * xrdb.c (magic_file_p, search_magic_path):
4185 Omit last arg SUFFIX; it was always 0. All callers changed.
4186 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4187
7de51af5
PE
4188 * xfont.c (xfont_match): Avoid need for strlen.
4189
25ed6cc3
PE
4190 * xfns.c: Don't assume strlen fits in int.
4191 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4192
4eab31dd
PE
4193 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4194 not unsigned long, as we prefer signed integers. All callers changed.
4195 Detect integer overflow in repeat count.
4196 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4197 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4198
171e2a58
PE
4199 * termcap.c: Don't assume sizes fit in int and never overflow.
4200 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4201 (gobble_line): Check for size-calculation overflow.
4202
ad39faca 4203 * minibuf.c (Fread_buffer):
6e5bb2dc 4204 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4205 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4206 Don't assume string length fits in int.
4207
52c61c22 4208 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4209 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4210
b5b8c9e5
PE
4211 * font.c: Don't assume string length fits in int.
4212 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4213 Use ptrdiff_t, not int.
ccd6111c
PE
4214 (font_intern_prop): Don't assume string length fits in int.
4215 Don't assume integer property fits in fixnum.
4216 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4217
882f0d81 4218 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4219 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4220 Reformulate so as not to need the command string.
4221 Invoke gzip -cd rather than gunzip, as it's more portable.
4222 (lock_info_type, lock_file_1, lock_file):
4223 Don't assume pid_t and time_t fit in unsigned long.
4224 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4225 (current_lock_owner): Prefer signed type for sizes.
4226 Use memcpy, not strncpy, where memcpy is what is really wanted.
4227 Don't assume (via atoi) that time_t and pid_t fit in int.
4228 Check for time_t and/or pid_t out of range, e.g., via a network share.
4229 Don't alloca where an auto var works fine.
4230
93f4cf88
PE
4231 * fileio.c: Fix some integer overflow issues.
4232 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4233 Don't assume string length fits in int.
4234 (directory_file_name): Don't assume string length fits in long.
4235 (make_temp_name): Don't assume pid fits in int, or that its print
4236 length is less than 20.
4237
f3e92b69
PE
4238 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4239
1bfdaf10
PE
4240 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4241
35016e9a
PE
4242 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4243
3d1e65a1
PE
4244 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4245 We prefer signed integers, even for size calculations.
4246
0b963a93
PE
4247 * emacs.c: Don't assume string length fits in 'int'.
4248 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4249 (main): Don't invoke strlen when not needed.
4250
573f4b54
PE
4251 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4252 (XD_DEBUG_MESSAGE): Don't waste a byte.
4253
989f33ba
PE
4254 * callproc.c (getenv_internal_1, getenv_internal)
4255 (Fgetenv_internal):
965d34eb
PE
4256 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4257
e4d29b33
PE
4258 * lread.c (invalid_syntax): Omit length argument.
4259 All uses changed. This doesn't fix a bug, but it simplifies the
4260 code away from its former Hollerith-constant appearance, and it's
4261 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4262 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4263
eb49b136
PE
4264 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4265 This didn't break anything, but it didn't help either.
4266 It's confusing to put a bogus integer in a place where the actual
4267 value does not matter.
9f62aeb1 4268 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4269 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4270
15375a22
PE
4271 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4272 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4273 implementation.
b61cc01c
PE
4274 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4275 We prefer signed types, and the value cannot exceed the EMACS_INT
4276 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4277 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4278 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4279 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4280
53b2623d
PE
4281 * indent.c (sane_tab_width): New function.
4282 (current_column, scan_for_column, Findent_to, position_indentation)
4283 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4284 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4285
51cab52b 4286 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4287
f2ed8a70
PE
4288 * lisp.h (lint_assume): New macro.
4289 * composite.c (composition_gstring_put_cache):
4290 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4291
abe80cc6
PE
4292 * editfns.c, insdel.c:
4293 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4294
b02c740e
PE
4295 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4296
ebc96716
PE
4297 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4298
b4e50fa0 4299 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4300 Use much-faster test for byte-length change.
311d5d7c 4301 Don't assume string byte-length fits in 'int'.
a4cf38e4 4302 Check that character arg fits in 'int'.
85461888 4303 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4304
c0c1ee9f
PE
4305 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4306
a498d7f4
PE
4307 * fns.c (concat): Catch string overflow earlier.
4308 Do not rely on integer wraparound.
4309
51cab52b
PE
4310 * dispextern.h (struct it.overlay_strings_charpos)
4311 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4312 * xdisp.c (forward_to_next_line_start)
4313 (back_to_previous_visible_line_start)
4314 (reseat_at_next_visible_line_start, next_element_from_buffer):
4315 Don't arbitrarily truncate the value of 'selective' to int.
4316
76031fad
PE
4317 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4318
5eb55db9
PE
4319 * composite.c: Don't truncate sizes to 'int'.
4320 (composition_gstring_p, composition_reseat_it)
4321 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4322 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4323 not EMACS_UINT, for indexes.
5eb55db9 4324
0703a717
PE
4325 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4326
d6202519
PE
4327 * buffer.c: Include <verify.h>.
4328 (struct sortvec.priority, struct sortstr.priority):
8961a454 4329 Now EMACS_INT, not int.
c20998a7 4330 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4331 (struct sortstr.size, record_overlay_string)
4332 (struct sortstrlist.size, struct sortlist.used):
4333 Don't truncate size to int.
4334 (record_overlay_string): Check for size-calculation overflow.
d6202519 4335 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4336
d5a19415
JM
43372011-06-22 Jim Meyering <meyering@redhat.com>
4338
029529ac 4339 Don't leak an XBM-image-sized buffer
d5a19415
JM
4340 * image.c (xbm_load): Free the image buffer after using it.
4341
a9041e6c
PE
43422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 Port to Sun C.
4345 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4346 that Sun C diagnosed.
4347 * fns.c (secure_hash): Fix pointer signedness issue.
4348 * intervals.c (static_offset_intervals): New function.
4349 (offset_intervals): Use it.
4350
7f3f739f
LL
43512011-06-21 Leo Liu <sdl.web@gmail.com>
4352
4353 * deps.mk (fns.o):
4354 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4355 sha512.h.
4356
4357 * fns.c (secure_hash): Rename from crypto_hash_function and change
4358 the first arg to accept symbols.
5b66d427 4359 (Fsecure_hash): New primitive.
7f3f739f
LL
4360 (syms_of_fns): New symbols.
4361
76147d94
DD
43622011-06-20 Deniz Dogan <deniz@dogan.se>
4363
4364 * process.c (Fset_process_buffer): Clarify return value in
4365 docstring.
4366
7d7d0045
CY
43672011-06-18 Chong Yidong <cyd@stupidchicken.com>
4368
4369 * dispnew.c (add_window_display_history): Use BVAR.
4370
4371 * xdisp.c (debug_method_add): Use BVAR.
4372 (check_window_end, dump_glyph_matrix, dump_glyph)
4373 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4374
4375 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4376 Likewise.
4377
4378 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4379 check till after the cache is created in init_frame_faces.
4380
ff2bc410
SM
43812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4382
4383 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4384
28177add
PE
43852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4386
dd3482fe
PE
4387 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4388 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4389 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4390
393d71f3 4391 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4392 * fileio.c (Finsert_file_contents):
4393 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4394 Remove the old (too-loose) buffer overflow checks.
4395 They weren't needed, since make_gap checks for buffer overflow.
4396 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4397 The old code merely checked for Emacs fixnum overflow, and relied
4398 on undefined (wraparound) behavior. The new code avoids undefined
4399 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4400
2e6813b0 4401 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4402 Tune. Don't use wider integers than needed. Don't use alloca.
4403 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4404
599a9e4f
PE
4405 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4406
99561444
PE
4407 * insdel.c, lisp.h (buffer_overflow): New function.
4408 (insert_from_buffer_1, replace_range, replace_range_2):
4409 * insdel.c (make_gap_larger):
4410 * editfns.c (Finsert_char):
4411 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4412
28177add
PE
4413 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4414
e69dafad
PE
44152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4416
a7af7fde 4417 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4418
b1c46f02
PE
4419 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4420 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4421
e69dafad
PE
4422 * fileio.c: Don't assume EMACS_INT fits in off_t.
4423 (emacs_lseek): New static function.
4424 (Finsert_file_contents, Fwrite_region): Use it.
4425 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4426
566684ea
PE
4427 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4428
e6966cd6
PE
4429 * fns.c: Don't overflow int when computing a list length.
4430 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4431 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4432 truncation on 64-bit hosts. Check for QUIT every
4433 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4434 faster and is responsive enough.
4435 (Flength): Report an error instead of overflowing an integer.
4436 (Fsafe_length): Return a float if the value is not representable
4437 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4438 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4439 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4440
dd0b0efb
PE
4441 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4442 (header_size, word_size): New constants.
4443 (allocate_vectorlike): Don't check size overflow here.
4444 (allocate_vector): Check it here instead, since this is the only
4445 caller of allocate_vectorlike that could cause overflow.
4446 Check that the new vector's length is representable as a fixnum.
4447
86fe5cfe
PE
4448 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4449 The previous code was bogus. For example, next_almost_prime (32)
4450 returned 39, which is undesirable as it is a multiple of 3; and
4451 next_almost_prime (24) returned 25, which is a multiple of 5 so
4452 why was the code bothering to check for multiples of 7?
4453
80e88859
PE
4454 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4455
4a2f0ad6
PE
4456 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4457
f66c7cf8
PE
4458 Variadic C functions now count arguments with ptrdiff_t.
4459 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4460 Back then I didn't know that the Emacs coding style prefers signed int.
4461 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4462 were being counted with int, which may truncate counts on 64-bit
4463 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4464 * lisp.h (struct Lisp_Subr.function.aMANY)
4465 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4466 Arg counts are now ptrdiff_t, not size_t.
4467 All variadic functions and their callers changed accordingly.
4468 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4469 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4470 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4471 * callint.c (Fcall_interactively): Check arg count for overflow,
4472 to avoid potential buffer overrun. Use signed char, not 'int',
4473 for 'varies' array, so that we needn't bother to check its size
4474 calculation for overflow.
4475 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4476 * eval.c (apply_lambda):
4477 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4478 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4479 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4480
a1759b76
PE
4481 * callint.c (Fcall_interactively): Don't use index var as event count.
4482
d96be9fc
PE
4483 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4484 * mem-limits.h (SIZE): Remove; no longer used.
4485
a690a978 4486 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4487
578c21e6
PE
4488 Remove unnecessary casts.
4489 * xterm.c (x_term_init):
4490 * xfns.c (x_set_border_pixel):
4491 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4492 These aren't needed now that we assume ANSI C.
4493
96f53c6c
PE
4494 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4495 It's more likely to cause problems (due to unsigned overflow)
4496 than to cure them.
4497
83c77d31
PE
4498 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4499
ee2079f1
PE
4500 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4501
6da65536
PE
4502 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4503
7147c4a4
PE
4504 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4505
193e32d9
PE
4506 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4507
e5533da6
PE
4508 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4509
9910e595
PE
4510 GLYPH_CODE_FACE returns EMACS_INT, not int.
4511 * dispextern.h (merge_faces):
4512 * xfaces.c (merge_faces):
01103c44
PE
4513 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4514 Don't assume EMACS_INT fits in int.
9910e595 4515
2638320e
PE
4516 * character.h (CHAR_VALID_P): Remove unused parameter.
4517 * fontset.c, lisp.h, xdisp.c: All uses changed.
4518
045eb8d9
PE
4519 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4520
c1f134b5
PE
4521 * fns.c (concat): Minor tuning based on overflow analysis.
4522 This doesn't fix any bugs. Use int to hold character, instead
4523 of constantly refetching from Emacs object. Use XFASTINT, not
4524 XINT, for value known to be a character. Don't bother comparing
4525 a single byte to 0400, as it's always less.
4526
395fcb93 4527 * floatfns.c (Fexpt):
327eeec8
PE
4528 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4529
abbd3d23
PE
4530 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4531 for characters.
4532
684a03ef
PE
4533 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4534
0fed43f3
PE
4535 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4536 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4537 incorrectly succeed when S was a string, because 4294967386 was
4538 truncated before it was used.
4539
8fd02eb7
PE
4540 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4541 Otherwise, an out-of-range integer could cause undefined behavior
4542 on a 64-bit host.
4543
f8c86b69
PE
4544 * composite.c: Use int, not EMACS_INT, for characters.
4545 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4546 EMACS_INT, for values that are known to be in character range.
4547 This doesn't fix any bugs but is the usual style inside Emacs and
4548 may generate better code on 32-bit machines.
4549
34206dd2
PE
4550 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4551 This is for reasons similar to the recent CHAR_STRING fix.
4552 * charset.c (Fencode_char): Check that character arg is actually
4553 a character. Pass an int to ENCODE_CHAR.
4554 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4555 wider than 'int', as a compile-time check to prevent future regressions
4556 in this area.
4557
c5958d4c 4558 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4559
4560 Make sure a 64-bit char is never passed to CHAR_STRING.
4561 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4562 by silently ignoring the top 32 bits, allowing some values
4563 that were far too large to be valid characters.
4564 * character.h: Include <verify.h>.
4565 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4566 arguments are no wider than unsigned, as a compile-time check
4567 to prevent future regressions in this area.
4568 * data.c (Faset):
01103c44 4569 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4570 (Fsubst_char_in_region):
4571 * fns.c (concat):
4572 * xdisp.c (decode_mode_spec_coding):
4573 Adjust to CHAR_STRING's new requirement.
4574 * editfns.c (Finsert_char, Fsubst_char_in_region):
4575 * fns.c (concat): Check that character args are actually
4576 characters. Without this test, these functions did the wrong
4577 thing with wildly out-of-range values on 64-bit hosts.
4578
d37ca623
PE
4579 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4580 These casts should not be needed on 32-bit hosts, either.
4581 * keyboard.c (read_char):
4582 * lread.c (Fload): Remove casts to unsigned.
4583
ea204efb
PE
4584 * lisp.h (UNSIGNED_CMP): New macro.
4585 This fixes comparison bugs on 64-bit hosts.
4586 (ASCII_CHAR_P): Use it.
4587 * casefiddle.c (casify_object):
01103c44 4588 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4589 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4590 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4591 * dispextern.h (FACE_FROM_ID):
4592 * keyboard.c (read_char): Use UNSIGNED_CMP.
4593
41cb286c
PE
4594 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4595 not to EMACS_INT, to avoid GCC warning.
4596
4a1b9832
PE
4597 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4598
55daad71
PE
4599 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4600 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4601 isn't needed on 32-bit machines.
8f95c75c 4602
01103c44
PE
4603 * buffer.c (Fgenerate_new_buffer_name):
4604 Use EMACS_INT for count, not int.
0ceccced 4605 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4606
4607 * data.c (Qcompiled_function): Now static.
4608
c6f072e7
PE
4609 * window.c (window_body_lines): Now static.
4610
20ce5912
PE
4611 * image.c (gif_load): Rename local to avoid shadowing.
4612
9c4c5f81
PE
4613 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4614 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4615 * alloc.c (make_save_value): Integer argument is now of type
4616 ptrdiff_t, not int.
4617 (mark_object): Use ptrdiff_t, not int.
4618 * lisp.h (pD): New macro.
4619 * print.c (print_object): Use it.
4620
c0c5c8ae
PE
4621 * alloc.c: Use EMACS_INT, not int, to count objects.
4622 (total_conses, total_markers, total_symbols, total_vector_size)
4623 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4624 (total_free_floats, total_floats, total_free_intervals)
4625 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4626 Now EMACS_INT, not int. All uses changed.
4627 (Fgarbage_collect): Compute overall total using a double, so that
4628 integer overflow is less likely to be a problem. Check for overflow
4629 when converting back to an integer.
5a25e253
PE
4630 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4631 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4632 These were 'int' variables that could overflow on 64-bit hosts;
4633 they were never used, so remove them instead of repairing them.
211a0b2a 4634 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4635 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4636 Previously, this ceilinged at INT_MAX, but that doesn't work on
4637 64-bit machines.
e46bb31a 4638 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4639
c78baabf 4640 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4641 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4642 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4643 when a (possibly-narrower) signed value would do just as well.
4644 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4645
c9d624c6
PE
4646 * alloc.c: Catch some string size overflows that we were missing.
4647 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4648 for convenience in STRING_BYTES_MAX.
4649 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4650 The definition here is exact; the one in lisp.h was approximate.
4651 (allocate_string_data): Check for string overflow. This catches
4652 some instances we weren't catching before. Also, it catches
4653 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4654 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4655 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4656
c9d624c6
PE
4657 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4658 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4659 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4660
353032ce
PE
4661 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4662
2bccce07
PE
4663 * alloc.c (Fmake_string): Check for out-of-range init.
4664
0ac30604
SM
46652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4666
4667 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4668
c195f2de
JD
46692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4670
4671 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4672 xg_get_default_scrollbar_width.
4673
4674 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4675 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4676 (style_changed_cb): Call update_theme_scrollbar_width and call
4677 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4678 all frames (Bug#8505).
4679 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4680 Call gtk_window_set_resizable if HAVE_GTK3.
4681 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4682 and height if HAVE_GTK3 (Bug#8505).
4683 (scroll_bar_width_for_theme): New variable.
4684 (update_theme_scrollbar_width): New function.
4685 (xg_get_default_scrollbar_width): Move code to
4686 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4687 (xg_initialize): Call update_theme_scrollbar_width.
4688
4689 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4690
4691 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4692
e10ac9f1
MR
46932011-06-12 Martin Rudalics <rudalics@gmx.at>
4694
4695 * frame.c (make_frame): Call other_buffer_safely instead of
4696 other_buffer.
4697
4698 * window.c (temp_output_buffer_show): Call display_buffer with
4699 second argument Vtemp_buffer_show_specifiers and reset latter
4700 immediately after the call.
4701 (Vtemp_buffer_show_specifiers): New variable.
4702 (auto_window_vscroll_p, next_screen_context_lines)
4703 (Vscroll_preserve_screen_position): Remove leading asterisks from
4704 doc-strings.
4705
2d3c217e 47062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4707
7b7f97e8 4708 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4709 * buffer.c (Qclone_number): Remove for now, as it's unused.
4710 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4711 (record_buffer): Remove unused local.
4712 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4713 (set_frame_buffer_list): Remove; unused.
4714 * frame.h (other_visible_frames): Remove decl.
4715 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4716 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4717 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4718 if HAVE_GPM.
4719 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4720 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4721 Define only if HAVE_GPM.
4722 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4723 (update_hints_inhibit): Remove; never set. All uses removed.
4724 * widgetprv.h (emacsFrameClassRec): Remove decl.
4725 * window.c (delete_deletable_window): Now returns void, since it
4726 wasn't returning anything.
4727 (compare_window_configurations): Remove unused locals.
4728 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4729 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4730 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4731 the same widths as pointers. This follows up on the 2011-05-06 patch.
4732 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4733 * xterm.h: Likewise.
4734 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4735
1384b89e
JB
47362011-06-12 Juanma Barranquero <lekktu@gmail.com>
4737
4738 * makefile.w32-in: Update dependencies.
4739 (LISP_H): Add lib/intprops.h.
4740
1100a63c
CY
47412011-06-11 Chong Yidong <cyd@stupidchicken.com>
4742
4743 * image.c (gif_load): Add animation frame delay to the metadata.
4744 (syms_of_image): Use DEFSYM. New symbol `delay'.
4745
6198ccd0
MR
47462011-06-11 Martin Rudalics <rudalics@gmx.at>
4747
4748 * window.c (delete_deletable_window): Re-add.
4749 (Fset_window_configuration): Rewrite to handle dead buffers and
4750 consequently deletable windows.
4751 (window_tree, Fwindow_tree): Remove. Supply functionality in
4752 window.el.
4753 (compare_window_configurations): Simplify code.
4754
b6e3633c
AS
47552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4756
1ab0dee5
AS
4757 * image.c (imagemagick_load_image): Fix type mismatch.
4758 (Fimagemagick_types): Likewise.
4759
b6e3633c
AS
4760 * window.h (replace_buffer_in_windows): Declare.
4761
9397e56f
MR
47622011-06-11 Martin Rudalics <rudalics@gmx.at>
4763
4764 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4765 Qclone_number. Remove external declaration of Qdelete_window.
4766 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4767 code.
640c8776
SM
4768 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4769 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4770 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4771 buffer list implementation.
4772 (other_buffer_safely): New function.
4773 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4774 calls to replace_buffer_in_windows and
4775 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4776 if allowed.
4777 (record_buffer): Inhibit quitting and rewrite using quittable
4778 functions. Run Qbuffer_list_update_hook if allowed.
4779 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4780 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4781 Move switch-to-buffer to window.el.
9397e56f
MR
4782 (bury-buffer): Move to window.el.
4783 (Vbuffer_list_update_hook): New variable.
4784
4785 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4786 section.
4787
4788 * window.h (resize_frame_windows): Move up in code.
4789 (Fwindow_frame): Remove EXFUN.
4790 (replace_buffer_in_all_windows): Remove prototype.
4791 (replace_buffer_in_windows_safely): Add prototype.
4792
4793 * window.c: Declare Qdelete_window static again. Move down
4794 declaration of select_count.
4795 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4796 (Fother_window): Move to window.el.
4797 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4798 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4799 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4800 window.el.
4801 (replace_buffer_in_windows): Implement by calling
4802 Qreplace_buffer_in_windows.
4803 (replace_buffer_in_all_windows): Remove with some functionality
4804 moved into replace_buffer_in_windows_safely.
4805 (replace_buffer_in_windows_safely): New function.
4806 (select_window_norecord, select_frame_norecord): Move in front
4807 of run_window_configuration_change_hook. Remove now obsolete
4808 declarations.
640c8776
SM
4809 (Fset_window_buffer): Rewrite doc-string.
4810 Call Qrecord_window_buffer.
9397e56f
MR
4811 (keys_of_window): Move binding for other-window to window.el.
4812
b50691aa
CY
48132011-06-11 Chong Yidong <cyd@stupidchicken.com>
4814
4815 * dispextern.h (struct image): Replace data member, whose int_val
4816 and ptr_val fields were not used by anything, with a single
4817 lisp_val object.
4818
4819 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4820 (gif_clear_image, gif_load, imagemagick_load_image)
4821 (gs_clear_image, gs_load): Callers changed.
4822
3f754b86
PE
48232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4824
cca69397
PE
4825 * buffer.h: Include <time.h>, for time_t.
4826 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4827
109e28d0
PE
4828 Fix minor problems found by static checking.
4829
60737f02
PE
4830 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4831
4b66faf3
PE
4832 Make identifiers static if they are not used in other modules.
4833 * data.c (Qcompiled_function, Qframe, Qvector):
4834 * image.c (QimageMagick, Qsvg):
4835 * minibuf.c (Qmetadata):
4836 * window.c (resize_window_check, resize_root_window): Now static.
4837 * window.h (resize_window_check, resize_root_window): Remove decls.
4838
109e28d0
PE
4839 * window.c (window_deletion_count, delete_deletable_window):
4840 Remove; unused.
46a4ce9e
PE
4841 (window_body_lines): Now static.
4842 (Fdelete_other_windows_internal): Mark vars as initialized.
4843 Make sure 'resize_failed' is initialized.
4844 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4845 (resize_window_apply): Remove unused local.
4846 * window.h (delete_deletable_window): Remove decl.
4847
109e28d0 4848 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4849 (imagemagick_load_image): Fix pointer signedness problem by changing
4850 last arg from unsigned char * to char *. All uses changed.
4851 Also, fix a local for similar reasons.
4852 Remove unused locals. Remove locals to avoid shadowing.
4853 (fn_rsvg_handle_free): Remove; unused.
4854 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4855 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4856
3f754b86
PE
4857 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4858
2547adb1
CY
48592011-06-10 Chong Yidong <cyd@stupidchicken.com>
4860
4861 * image.c (gif_load): Fix omitted cast error introduced by
4862 2011-06-06 change.
4863
2c8e37d4
MR
48642011-06-10 Martin Rudalics <rudalics@gmx.at>
4865
4866 * window.h (resize_proportionally, orig_total_lines)
4867 (orig_top_line): Remove from window structure.
4868 (set_window_height, set_window_width, change_window_heights)
4869 (Fdelete_window): Remove prototypes.
4870 (resize_frame_windows): Remove duplicate declaration.
4871
440a42e3
EZ
48722011-06-10 Eli Zaretskii <eliz@gnu.org>
4873
4874 * window.h (resize_frame_windows, resize_window_check)
4875 (delete_deletable_window, resize_root_window)
4876 (resize_frame_windows): Declare prototypes.
4877
4878 * window.c (resize_window_apply): Make definition be "static" to
4879 match the prototype.
4880
562dd5e9
MR
48812011-06-10 Martin Rudalics <rudalics@gmx.at>
4882
4883 * window.c: Remove declarations of Qwindow_size_fixed,
4884 window_min_size_1, window_min_size_2, window_min_size,
4885 size_window, window_fixed_size_p, enlarge_window, delete_window.
4886 Remove static from declaration of Qdelete_window, it's
4887 temporarily needed by Fbury_buffer.
4888 (replace_window): Don't assign orig_top_line and
4889 orig_total_lines.
4890 (Fdelete_window, delete_window): Remove. Window deletion is
4891 handled by window.el.
640c8776
SM
4892 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4893 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4894 (Fdelete_other_windows): Remove. Deleting other windows is
4895 handled by window.el.
4896 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4897 handled in window.el.
4898 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4899 Window minimum sizes are handled in window.el.
4900 (shrink_windows, size_window, set_window_height)
4901 (set_window_width, change_window_heights, window_height)
4902 (window_width, CURBEG, CURSIZE, enlarge_window)
4903 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4904 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4905 handled in window.el.
4906 (make_dummy_parent): Rename to make_parent_window and give it a
4907 second argument horflag.
4908 (make_window): Don't set resize_proportionally any more.
4909 (Fsplit_window): Remove. Windows are split in window.el.
4910 (save_restore_action, save_restore_orig_size)
4911 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4912 Resize mini windows in window.el.
4913 (grow_mini_window, shrink_mini_window): Implement by calling
4914 Qresize_root_window_vertically, resize_window_check and
4915 resize_window_apply.
640c8776
SM
4916 (saved_window, Fset_window_configuration, save_window_save):
4917 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4918 resize_proportionally.
4919 (window_min_height, window_min_width): Move to window.el.
4920 (keys_of_window): Move bindings for delete-other-windows,
4921 split-window, delete-window and enlarge-window to window.el.
4922
4923 * buffer.c: Temporarily extern Qdelete_window.
4924 (Fbury_buffer): Temporarily call Qdelete_window instead of
4925 Fdelete_window (Fbury_buffer will move to window.el soon).
4926
4927 * frame.c (set_menu_bar_lines_1): Remove code handling
4928 orig_top_line and orig_total_lines.
4929
4930 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4931 set_window_height but set heights directly.
4932 (change_frame_size_1): Use resize_frame_windows.
4933
4934 * xdisp.c (init_xdisp): Don't use set_window_height but set
4935 heights directly.
4936
640c8776
SM
4937 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4938 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4939 run_window_configuration_change_hook.
4940
4941 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4942 instead of change_window_heights and run
4943 run_window_configuration_change_hook.
4944
1a13852e
MR
49452011-06-09 Martin Rudalics <rudalics@gmx.at>
4946
4947 * window.c (replace_window): Rename second argument REPLACEMENT to
4948 NEW. New third argument SETFLAG. Rewrite.
4949 (delete_window, make_dummy_parent): Call replace_window with
4950 third argument 1.
4951 (window_list_1): Move down in code.
4952 (run_window_configuration_change_hook): Move set_buffer part
4953 before select_frame_norecord part in order to unwind correctly.
4954 Rename count1 to count.
4955 (recombine_windows, delete_deletable_window, resize_root_window)
4956 (Fdelete_other_windows_internal)
4957 (Frun_window_configuration_change_hook, make_parent_window)
4958 (resize_window_check, resize_window_apply, Fresize_window_apply)
4959 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4960 (Fdelete_window_internal, Fresize_mini_window_internal):
4961 New functions.
1a13852e
MR
4962 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4963
f3d1777e
MR
49642011-06-08 Martin Rudalics <rudalics@gmx.at>
4965
496e208e
MR
4966 * window.h (window): Add some new members to window structure -
4967 normal_lines, normal_cols, new_total, new_normal, clone_number,
4968 splits, nest, prev_buffers, next_buffers.
4969 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4970 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4971
f3d1777e
MR
4972 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4973 Remove.
496e208e
MR
4974 (make_dummy_parent): Set new members of windows structure.
4975 (make_window): Move down in code. Handle new members of window
4976 structure.
4977 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4978 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4979 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4980 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4981 (Fset_window_next_buffers, Fset_window_clone_number):
4982 New functions.
496e208e
MR
4983 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4984 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4985 Doc-string fixes.
4986 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4987 Argument WINDOW can be now internal window too.
4988 (Fwindow_use_time): Move up in code.
4989 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4990 Rewrite doc-string.
4991 (Fset_window_configuration, saved_window)
4992 (Fcurrent_window_configuration, save_window_save): Handle new
4993 members of window structure.
b9e809c2
MR
4994 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4995 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4996 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4997 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4998 Qget_mru_window, Qresize_root_window,
4999 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5000 Qauto_buffer_name; staticpro them.
f3d1777e 5001
abde8f8c
MR
50022011-06-07 Martin Rudalics <rudalics@gmx.at>
5003
5004 * window.c (Fwindow_total_size, Fwindow_left_column)
5005 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5006 (Fwindow_list_1): New functions.
5007 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5008 (Fwindow_width, Fscroll_left, Fscroll_right):
5009 Use window_body_cols instead of window_box_text_cols.
5010 (delete_window, Fset_window_configuration):
5011 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5012 (delete_all_subwindows): Take a window as argument and not a
5013 structure. Rewrite.
190b47e6
MR
5014 (window_loop): Remove handling of GET_LRU_WINDOW and
5015 GET_LARGEST_WINDOW.
5016 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5017
5018 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5019 window_box_text_cols. delete_all_subwindows now takes a
5020 Lisp_Object as argument.
abde8f8c 5021
640c8776
SM
5022 * indent.c (compute_motion, Fcompute_motion):
5023 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5024
fa8a67e6
MR
5025 * frame.c (delete_frame): Call delete_all_subwindows with root
5026 window as argument.
5027
a54e3482
DC
50282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5029
5030 * fns.c (Fputhash): Document return value.
5031
60002bf5
CY
50322011-06-06 Chong Yidong <cyd@stupidchicken.com>
5033
5034 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5035
0c671da6 50362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5037
b862a52a 5038 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5039
be44ca6c
PE
5040 Check for overflow when converting integer to cons and back.
5041 * charset.c (Fdefine_charset_internal, Fdecode_char):
5042 Use cons_to_unsigned to catch overflow.
5043 (Fencode_char): Use INTEGER_TO_CONS.
5044 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5045 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5046 * data.c (long_to_cons, cons_to_long): Remove.
5047 (cons_to_unsigned, cons_to_signed): New functions.
5048 These signal an error for invalid or out-of-range values.
5049 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5050 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5051 * font.c (Ffont_variation_glyphs):
5052 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5053 * lisp.h: Include <intprops.h>.
5054 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5055 (cons_to_signed, cons_to_unsigned): New decls.
5056 (long_to_cons, cons_to_long): Remove decls.
5057 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5058 (Fprimitive_undo): Use CONS_TO_INTEGER.
5059 * xfns.c (Fx_window_property): Likewise.
5060 * xselect.c: Include <limits.h>.
5061 (x_own_selection, selection_data_to_lisp_data):
5062 Use INTEGER_TO_CONS.
5063 (x_handle_selection_request, x_handle_selection_clear)
5064 (x_get_foreign_selection, Fx_disown_selection_internal)
5065 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5066 (lisp_data_to_selection_data): Use cons_to_unsigned.
5067 (x_fill_property_data): Use cons_to_signed.
5068 Report values out of range.
5069
d1f3d2af
PE
5070 Check for buffer and string overflow more precisely.
5071 * buffer.h (BUF_BYTES_MAX): New macro.
5072 * lisp.h (STRING_BYTES_MAX): New macro.
5073 * alloc.c (Fmake_string):
5074 * character.c (string_escape_byte8):
5075 * coding.c (coding_alloc_by_realloc):
5076 * doprnt.c (doprnt):
5077 * editfns.c (Fformat):
5078 * eval.c (verror):
5079 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5080 since they may not be the same number.
5081 * editfns.c (Finsert_char):
5082 * fileio.c (Finsert_file_contents):
5083 Likewise for BUF_BYTES_MAX.
5084
dd52fcea
PE
5085 * image.c: Use ptrdiff_t, not int, for sizes.
5086 (slurp_file): Switch from int to ptrdiff_t.
5087 All uses changed.
5088 (slurp_file): Check that file size fits in both size_t (for
5089 malloc) and ptrdiff_t (for sanity and safety).
5090
7f9bbdbb
PE
5091 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5092 if b->modtime has its maximal value.
5093
dfe18f82
PE
5094 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5095
84acfcf0
PE
5096 Don't assume time_t can fit into int.
5097 * buffer.h (struct buffer.modtime): Now time_t, not int.
5098 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5099 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5100
ccd9a01a
PE
5101 Minor fixes for signed vs unsigned integers.
5102 * character.h (MAYBE_UNIFY_CHAR):
5103 * charset.c (maybe_unify_char):
5104 * keyboard.c (read_char, reorder_modifiers):
5105 XINT -> XFASTINT, since the integer must be nonnegative.
5106 * ftfont.c (ftfont_spec_pattern):
5107 * keymap.c (access_keymap, silly_event_symbol_error):
5108 XUINT -> XFASTINT, since the integer must be nonnegative.
5109 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5110 since it makes no difference and we prefer signed.
5111 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5112 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5113 nonnegative.
5114
d6d100dd
SM
51152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5116
5117 * window.h (Fwindow_frame): Declare.
5118
2b6148e4
PE
51192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5120
5121 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5122 (SPARE_MEMORY): Always define.
5123 (LARGE_REQUEST): Remove.
5124 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5125
f230ecc9
MR
51262011-06-06 Martin Rudalics <rudalics@gmx.at>
5127
727e958e
MR
5128 * lisp.h: Move EXFUNS for Fframe_root_window,
5129 Fframe_first_window and Fset_frame_selected_window to window.h.
5130
5131 * window.h: Move EXFUNS for Fframe_root_window,
5132 Fframe_first_window and Fset_frame_selected_window here from
5133 lisp.h.
5134
5135 * frame.c (Fwindow_frame, Fframe_first_window)
5136 (Fframe_root_window, Fframe_selected_window)
5137 (Fset_frame_selected_window): Move to window.c.
5138 (Factive_minibuffer_window): Move to minibuf.c.
5139 (Fother_visible_frames_p): New function.
5140
5141 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5142
f230ecc9
MR
5143 * window.c (decode_window, decode_any_window): Move up in code.
5144 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5145 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5146 (Fwindow_buffer): Move up and rewrite doc-string.
5147 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5148 (Fwindow_prev): New functions.
727e958e
MR
5149 (Fwindow_frame): Move here from frame.c. Accept any window as
5150 argument.
5151 (Fframe_root_window, Fframe_first_window)
5152 (Fframe_selected_window): Move here from frame.c. Accept frame
5153 or arbitrary window as argument. Update doc-strings.
5154 (Fminibuffer_window): Move up in code.
5155 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5156 (Fset_frame_selected_window): Move here from frame.c.
5157 Marginal rewrite.
727e958e
MR
5158 (Fselected_window, select_window, Fselect_window): Move up in
5159 code. Minor doc-string fixes.
f230ecc9 5160
4d09bcf6
PE
51612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5164 Do not assume that spare memory exists; that assumption is valid
5165 only if SYSTEM_MALLOC.
5166 (LARGE_REQUEST): New macro, so that the issue of large requests
5167 is separated from the issue of spare memory.
5168
810928a2
AS
51692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5170
172418ad
AS
5171 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5172 format. (Bug#8806)
5173
43f862f7
AS
5174 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5175
810928a2
AS
5176 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5177 before statements.
5178
a059fe24
JD
51792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5180
5181 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5182
5183 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5184
5185 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5186 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5187
989bf368
JB
51882011-06-05 Juanma Barranquero <lekktu@gmail.com>
5189
5190 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5191
4b80f674
CY
51922011-06-04 Chong Yidong <cyd@stupidchicken.com>
5193
5194 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5195 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5196 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5197 New error handlers.
4b80f674
CY
5198 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5199 Obey Vx_select_enable_clipboard_manager. Catch errors in
5200 x_clipboard_manager_save (Bug#8779).
5201 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5202 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5203
99a33b77 52042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5205
5206 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5207
99a33b77 52082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5209
5210 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5211 in the current matrix if keep_current_p is non-zero.
5212
8264569d
EZ
52132011-06-04 Eli Zaretskii <eliz@gnu.org>
5214
5215 * bidi.c (bidi_level_of_next_char): Fix last change.
5216
57f97249
EZ
52172011-06-03 Eli Zaretskii <eliz@gnu.org>
5218
fec2107c 5219 Support bidi reordering of text covered by display properties.
57f97249 5220
fec2107c
EZ
5221 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5222 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5223 (bidi_cache_search, bidi_cache_iterator_state)
5224 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5225 (bidi_level_of_next_char, bidi_move_to_visually_next):
5226 Support character positions inside a run of characters covered by a
fec2107c
EZ
5227 display string.
5228 (bidi_paragraph_init, bidi_resolve_explicit_1)
5229 (bidi_level_of_next_char): Call bidi_fetch_char and
5230 bidi_fetch_char_advance instead of FETCH_CHAR and
5231 FETCH_CHAR_ADVANCE.
5232 (bidi_init_it): Initialize new members.
5233 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5234 definitions.
5235 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5236 instead of using explicit *_CHAR codes.
d6d100dd
SM
5237 (bidi_resolve_explicit, bidi_resolve_weak):
5238 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5239 bidirectional text is supported only in multibyte buffers.
5240 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5241 it to initialize the frame_window_p member of struct bidi_it.
5242 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5243 (bidi_resolve_explicit, bidi_resolve_weak)
5244 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5245 bidi_it->nchars is non-positive.
5246 (bidi_level_of_next_char): Don't try to lookup the cache for the
5247 next/previous character if nothing is cached there yet, or if we
5248 were just reseat()'ed to a new position.
c40e2fb2 5249
0e14fe90
EZ
5250 * xdisp.c (set_cursor_from_row): Set start and stop points
5251 according to the row's direction when priming the loop that looks
5252 for the glyph on which to display cursor.
5253 (single_display_spec_intangible_p): Function deleted.
5254 (display_prop_intangible_p): Reimplement to call
5255 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5256 Accept 3 additional arguments needed by handle_display_spec.
5257 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5258 values: lists, `(when COND...)' forms, etc.
5259 (single_display_spec_string_p): Support property values that are
5260 lists with the argument STRING its top-level element.
5261 (display_prop_string_p): Fix the condition for processing a
5262 property that is a list to be consistent with handle_display_spec.
fec2107c 5263 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5264 last portion of handle_display_prop.
5265 (compute_display_string_pos): Accept additional argument
5266 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5267 value of a `display' property is a "replacing spec".
5268 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5269 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5270 the display property, but just return a value indicating whether
5271 the display property will replace the characters it covers.
5272 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5273 frame_window_p members of struct bidi_it.
d6d100dd
SM
5274 (compute_display_string_pos, compute_display_string_end):
5275 New functions.
fec2107c
EZ
5276 (push_it): Accept second argument POSITION, where pop_it should
5277 jump to continue iteration.
5278 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5279
fec2107c
EZ
5280 * keyboard.c (adjust_point_for_property): Adjust the call to
5281 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5282
5283 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5284 (bidi_init_it): Update prototypes.
5285 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5286 (compute_display_string_pos, compute_display_string_end):
5287 Declare prototypes.
fec2107c
EZ
5288 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5289 EMACS_INT.
fc6f18ce 5290
40087514 52912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5292
57f53182
PE
5293 Malloc failure behavior now depends on size of allocation.
5294 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5295 * lisp.h: Change signatures accordingly.
5296 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5297 All callers changed. (Bug#8762)
5298
5299 * gnutls.c: Use Emacs's memory allocators.
5300 Without this change, the gnutls library would invoke malloc etc.
5301 directly, which causes problems on non-SYNC_INPUT hosts, and which
5302 runs afoul of improving memory_full behavior. (Bug#8761)
5303 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5304 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5305 xfree instead of the default malloc, realloc, free.
5306 (Fgnutls_boot): No need to check for memory allocation failure,
5307 since xmalloc does that for us.
5308
ac32cd99 5309 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5310 * category.c (hash_get_category_set):
5311 * ccl.c (ccl_driver):
5312 * charset.c (Fdefine_charset_internal):
5313 * charset.h (struct charset.hash_index):
5314 * composite.c (get_composition_id, gstring_lookup_cache)
5315 (composition_gstring_put_cache):
5316 * composite.h (struct composition.hash_index):
5317 * dispextern.h (struct image.hash):
5318 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5319 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5320 (hashfn_equal, hashfn_user_defined, make_hash_table)
5321 (maybe_resize_hash_table, hash_lookup, hash_put)
5322 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5323 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5324 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5325 * image.c (make_image, search_image_cache, lookup_image)
5326 (xpm_put_color_table_h):
5327 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5328 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5329 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5330 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5331 * alloc.c (allocate_vectorlike):
5332 Check for overflow in vector size calculations.
5333 * ccl.c (ccl_driver):
5334 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5335 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5336 need to be updated by these changes.
40087514
PE
5337 * fns.c (make_hash_table, maybe_resize_hash_table):
5338 Check for integer overflow with large hash tables.
0de4bb68
PE
5339 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5340 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5341 (SXHASH_REDUCE): New macro.
5342 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5343 Use it instead of discarding useful hash info with large hash values.
5344 (sxhash_float): New function.
5345 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5346 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5347 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5348 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5349 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5350 Adjust signatures to match updated version of code.
5351 (consing_since_gc): Now EMACS_INT, since a single hash table can
5352 use more than INT_MAX bytes.
5353
698d32e2
DN
53542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5355
5356 Make it possible to build with GCC-4.6+ -O2 -flto.
5357
5358 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5359
fd6fa53f
SM
53602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5361
5362 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5363 Call minibuffer-inactive-mode.
5364
864db017
JB
53652011-05-31 Juanma Barranquero <lekktu@gmail.com>
5366
5367 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5368 Update dependencies.
5369
2ad0baf4
DN
53702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5371
5372 * data.c (init_data): Remove code for UTS, this system is not
5373 supported anymore.
5374
4fcc2638
DN
53752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5376
5377 Don't force ./temacs to start in terminal mode.
5378
5379 * frame.c (make_initial_frame): Initialize faces in all cases, not
5380 only when CANNOT_DUMP is defined.
5381 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5382
c56e0fd5
DN
53832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5384
5385 * dispnew.c (add_window_display_history): Use const for the string
5386 pointer. Remove declaration, not needed.
5387
333d54da 53882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5389
55d4c1b2 5390 Use 'inline', not 'INLINE'.
333d54da 5391 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5392 * alloc.c, fontset.c (INLINE): Remove.
5393 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5394 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5395 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5396 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5397 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5398
738db178
DN
53992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5400
5401 Make it possible to run ./temacs.
5402
5403 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5404 syms_of_callproc does the same thing. Remove test for
5405 "initialized", do it in the caller.
5406 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5407
620c53a6
SM
54082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5409
5410 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5411 (read_minibuf): Use get_minibuffer.
5412 (syms_of_minibuf): Use DEFSYM.
5413 (Qmetadata): New var.
5414 * data.c (Qbuffer): Don't make it static.
5415 (syms_of_data): Use DEFSYM.
5416
e003a292
PE
54172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5418
5419 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5420 (CCL_CODE_MIN): New macro.
5421
ed008a6d
PE
54222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5423
3687c2ef
PE
5424 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5425
ed008a6d
PE
5426 * eval.c (Qdebug): Now static.
5427 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5428 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5429 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5430
d66c4c7c
CY
54312011-05-29 Chong Yidong <cyd@stupidchicken.com>
5432
5433 * image.c: Various fixes to ImageMagick code comments.
5434 (Fimagemagick_types): Doc fix.
5435
5fbc2025
PE
54362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5437
0196f88a
PE
5438 Minor fixes prompted by GCC 4.6.0 warnings.
5439
5440 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5441
5fbc2025
PE
5442 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5443 (x_clipboard_manager_save_all): Move extern decl to ...
5444 * xterm.h: ... here, so that it can be checked for consistency.
5445
1dd3c2d9
CY
54462011-05-29 Chong Yidong <cyd@stupidchicken.com>
5447
5448 * xselect.c (x_clipboard_manager_save_frame)
5449 (x_clipboard_manager_save_all): New functions.
5450 (Fx_clipboard_manager_save): Lisp function deleted.
5451
5452 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5453 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5454
5455 * xterm.h: Update prototype.
5456
5ba6571d
WX
54572011-05-28 William Xu <william.xwl@gmail.com>
5458
5459 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5460 exiting (Bug#8239).
5461
3eaff834
JM
54622011-05-28 Jim Meyering <meyering@redhat.com>
5463
e1900994 5464 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5465 * fns.c (to_uchar): Define.
5466 (crypto_hash_function): Use it to convert some newly-signed
5467 variables to unsigned, to avoid sign-extension bugs. For example,
5468 without this change, (md5 "truc") would evaluate to
5469 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5470 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5471 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5472
0f6990a7
PE
54732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 Integer overflow fixes.
c8a9ca5a 5476
08686060
PE
5477 * dbusbind.c: Serial number integer overflow fixes.
5478 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5479 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5480 to hold a serial number that is too large for a fixnum.
5481 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5482 Check for serial numbers out of range. Decode any serial number
59568bf0 5483 that was so large that it became a float. (Bug#8722)
08686060 5484
2d1fc3c7
PE
5485 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5486 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5487 Use XFASTINT rather than XUINT when numbers are nonnegative.
5488 (xd_append_arg, Fdbus_method_return_internal):
5489 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5490 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5491 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5492 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5493 (Bug#8722)
2d1fc3c7 5494
c8a9ca5a
PE
5495 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5496
519e1d69
PE
5497 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5498
30569699
PE
5499 ccl: add integer overflow checks
5500 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5501 (IN_INT_RANGE): New macros.
5502 (ccl_driver): Use them to check for integer overflow when
5503 decoding a CCL program. Many of the new checks are whether XINT (x)
5504 fits in int; it doesn't always, on 64-bit hosts. The new version
5505 doesn't catch all possible integer overflows, but it's an
847044ea 5506 improvement. (Bug#8719)
30569699 5507
c11285dc
PE
5508 * alloc.c (make_event_array): Use XINT, not XUINT.
5509 There's no need for unsigned here.
5510
fdccd48e
PE
5511 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5512 This follows up to the 2011-05-06 change that substituted uintptr_t
5513 for EMACS_INT. This case wasn't caught back then.
5514
37910ab2
PE
5515 Rework Fformat to avoid integer overflow issues.
5516 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5517 now (part of C89). Include <verify.h>.
5518 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5519 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5520 (Fformat): Avoid the prepass trying to compute sizes; it was only
5521 approximate and thus did not catch overflow reliably. Instead, walk
5522 through the format just once, formatting and computing sizes as we go,
5523 checking for integer overflow at every step, and allocating a larger
5524 buffer as needed. Keep track separately whether the format is
5525 multibyte. Keep only the most-recently calculated precision, rather
5526 than them all. Record whether each argument has been converted to
5527 string. Use EMACS_INT, not int, for byte and char and arg counts.
5528 Support field widths and precisions larger than INT_MAX. Avoid
5529 sprintf's undefined behavior with conversion specifications such as %#d
5530 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5531 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5532 formatting out-of-range floating point numbers with int
9173deec 5533 formats. (Bug#8668)
37910ab2 5534
2e6578fb
PE
5535 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5536
0ae6bdee
PE
5537 * data.c: Avoid integer truncation in expressions involving floats.
5538 * data.c: Include <intprops.h>.
5539 (arith_driver): When there's an integer overflow in an expression
5540 involving floating point, convert the integers to floating point
5541 so that the resulting value does not suffer from catastrophic
5542 integer truncation. For example, on a 64-bit host (* 4
5543 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5544 Do not rely on undefined behavior after integer overflow.
5545
de883a70
PE
5546 merge count_size_as_multibyte, parse_str_to_multibyte
5547 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5548 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5549 Check for integer overflow.
5550 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5551 since it's now a duplicate of the other. This is more of
5552 a character than a buffer op, so better that it's in character.c.
5553 * fns.c, print.c: Adjust to above changes.
5554
2ff916cb
PE
55552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5556
5557 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5558
f1b54466
PE
55592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5560
fb1ac845
PE
5561 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5562 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5563 (x_clipboard_manager_save): Now static.
5564 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5565
f1b54466
PE
5566 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5567 (crypto_hash_function): Now static.
5568 Fix pointer signedness problems. Avoid unnecessary initializations.
5569
a9f737ee
CY
55702011-05-27 Chong Yidong <cyd@stupidchicken.com>
5571
5572 * termhooks.h (Vselection_alist): Make it terminal-local.
5573
5574 * terminal.c (create_terminal): Initialize it.
5575
5576 * xselect.c: Support for clipboard managers.
5577 (Vselection_alist): Move to termhooks.h as terminal-local var.
5578 (LOCAL_SELECTION): New macro.
5579 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5580 (symbol_to_x_atom): Remove gratuitous arg.
5581 (x_handle_selection_request, lisp_data_to_selection_data)
5582 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5583 (x_own_selection, x_get_local_selection, x_convert_selection):
5584 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5585 (some_frame_on_display): Delete unused function.
5586 (Fx_own_selection_internal, Fx_get_selection_internal)
5587 (Fx_disown_selection_internal, Fx_selection_owner_p)
5588 (Fx_selection_exists_p): New optional frame arg.
5589 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5590 (x_handle_selection_clear): Don't treat other terminals with the
5591 same keyboard specially. Use the terminal-local Vselection_alist.
5592 (x_clear_frame_selections): Use Frun_hook_with_args.
5593
5594 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5595
5596 * xterm.h: Add support for those atoms.
5597
e067f0c1
CY
55982011-05-26 Chong Yidong <cyd@stupidchicken.com>
5599
5600 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5601 (converted_selections, conversion_fail_tag): New global variables.
5602 (x_selection_request_lisp_error): Free the above.
5603 (x_get_local_selection): Remove unnecessary code.
5604 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5605 of converted selections stored in converted_selections.
5606 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5607 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5608 (x_convert_selection): New function.
5609 (x_handle_selection_event): Simplify.
5610 (x_get_foreign_selection): Don't ignore incoming requests while
5611 waiting for an answer; this will fail when we implement
5612 SAVE_TARGETS, and seems unnecessary anyway.
5613 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5614 (Vx_sent_selection_functions): Doc fix.
5615
0f4aebc0
LL
56162011-05-26 Leo Liu <sdl.web@gmail.com>
5617
5618 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5619
e61124cd
YM
56202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5621
5622 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5623
5624 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5625 for fringe update if it has periodic bitmap.
ac389d0c 5626 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5627 and fringe_bitmap_periodic_p.
5628
5629 * fringe.c (get_fringe_bitmap_data): New function.
5630 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5631 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5632 row. Mark glyph row for fringe update if periodicity changed.
5633
5634 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5635 for fringe update unless it has periodic bitmap.
5636
f16d9837
KH
56372011-05-25 Kenichi Handa <handa@m17n.org>
5638
5639 * xdisp.c (get_next_display_element): Set correct it->face_id for
5640 a static composition.
5641
e1b90ef6
LL
56422011-05-24 Leo Liu <sdl.web@gmail.com>
5643
5644 * deps.mk (fns.o):
5645 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5646
5647 * fns.c (crypto_hash_function, Fsha1): New function.
5648 (Fmd5): Use crypto_hash_function.
5649 (syms_of_fns): Add Ssha1.
5650
7400048f
PE
56512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5652
5653 * gnutls.c: Remove unused macros.
5654 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5655 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5656 Remove macros that are defined and never used.
5657 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5658
abb71cf4
CY
56592011-05-22 Chong Yidong <cyd@stupidchicken.com>
5660
5661 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5662 (Fx_get_selection_internal): Minor cleanup.
5663 (Fx_own_selection_internal): Rename arguments for consistency with
5664 select.el.
5665
6307db39
PE
56662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5667
5668 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5669
f3d4e0a4
CY
56702011-05-22 Chong Yidong <cyd@stupidchicken.com>
5671
5672 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5673
4d8ade89
YM
56742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5675
5676 * dispnew.c (scrolling_window): Don't exclude the case that the
5677 last enabled row in the desired matrix touches the bottom boundary.
5678
32078c8d
GM
56792011-05-21 Glenn Morris <rgm@gnu.org>
5680
5681 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5682 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5683 and add some more files.
32078c8d 5684
7285dc67
EZ
56852011-05-20 Eli Zaretskii <eliz@gnu.org>
5686
5687 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5688 report_file_error introduced by the change from 2011-05-07.
5689
89d1bd22
PE
56902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5691
5692 * systime.h (Time): Define only if emacs is defined.
5693 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5694 where the include path doesn't have X11/X.h by default. See
5695 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5696
e23640bb 56972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5698
5699 * composite.c (find_automatic_composition): Fix previous change.
5700
b9704ad9
GM
57012011-05-20 Glenn Morris <rgm@gnu.org>
5702
5703 * lisp.mk: New file, split from Makefile.in.
5704 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5705 (shortlisp): Remove.
5706 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5707
4a720484
GM
57082011-05-19 Glenn Morris <rgm@gnu.org>
5709
5710 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5711 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5712 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5713 (lisp): Set the order to that of loadup.el.
5714 (shortlisp): Make it a copy of $lisp.
5715 (SOME_MACHINE_LISP): Remove.
5716 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5717 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5718
a28d4396
KH
57192011-05-18 Kenichi Handa <handa@m17n.org>
5720
5721 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5722 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5723 (find_automatic_composition): Mostly rewrite for efficiency.
5724
a2b1fa8e
JB
57252011-05-18 Juanma Barranquero <lekktu@gmail.com>
5726
5727 * makefile.w32-in: Update dependencies.
5728
8e1f5610
CS
57292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5730
5731 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5732 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5733
7025ee00 57342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5735
cdfa6eab
PE
5736 Fix some integer overflow issues, such as string length overflow.
5737
06d6db33
PE
5738 * insdel.c (count_size_as_multibyte): Check for string overflow.
5739
2b4560a8
PE
5740 * character.c (lisp_string_width): Check for string overflow.
5741 Use EMACS_INT, not int, for string indexes and lengths; in
5742 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5743 the resulting string length overflows an EMACS_INT; instead,
5744 report a string overflow if no precision given. When checking for
5745 precision exhaustion, use a check that cannot possibly have
5746 integer overflow. (Bug#8675)
5747 * character.h (lisp_string_width): Adjust to new signature.
5748
cb93f9be
PE
5749 * alloc.c (string_overflow): New function.
5750 (Fmake_string): Use it. This doesn't change behavior, but saves
5751 a few bytes and will simplify future changes.
5752 * character.c (string_escape_byte8): Likewise.
5753 * lisp.h (string_overflow): New decl.
5754
1a1f3366
PE
5755 Fixups, following up to the user-interface timestamp change.
5756 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5757 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5758 * msdos.c (mouse_get_pos): Likewise.
5759 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5760 * w32gui.h (Time): Define by including "systime.h" rather than by
5761 declaring it ourselves. (Bug#8664)
5762
d4e3e4d3
PE
5763 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5764 * image.c (clear_image_cache): Likewise.
5765
f6a24d19
PE
5766 * term.c (term_mouse_position): Don't assume time_t wraparound.
5767
08dc5ae6
PE
5768 Be more systematic about user-interface timestamps.
5769 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5770 and sometimes 'EMACS_UINT', to represent these timestamps.
5771 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5772 This makes the code easier to follow, and makes it easier to catch
5773 integer overflow bugs such as Bug#8664.
5774 * frame.c (Fmouse_position, Fmouse_pixel_position):
5775 Use Time, not unsigned long, for user-interface timestamps.
5776 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5777 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5778 * keyboard.h (last_event_timestamp): Likewise.
5779 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5780 * menu.h (xmenu_show): Likewise.
5781 * term.c (term_mouse_position): Likewise.
5782 * termhooks.h (struct input_event.timestamp): Likewise.
5783 (struct terminal.mouse_position_hook): Likewise.
5784 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5785 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5786 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5787 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5788 what it was before.
5789 * menu.h, termhooks.h: Include "systime.h", for Time.
5790
8e55734a
PE
5791 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5792 Don't assume that the difference between two unsigned long values
5793 can fit into an integer. At this point, we know button_down_time
5794 <= event->timestamp, so the difference must be nonnegative, so
5795 there's no need to cast the result if double-click-time is
5796 nonnegative, as it should be; check that it's nonnegative, just in
5797 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5798 apart (about 25 days). (Bug#8664)
8e55734a 5799
841f1b75 5800 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5801 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5802
3e26f69c
PE
5803 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5804 that always fit in int. Use a sentinel instead of a counter, to
5805 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5806 * frame.h (struct frame): Use int for menu_bar_items_used
5807 instead of EMACS_INT, since it always fits in int.
3e26f69c 5808
5cc152c0
PE
5809 * menu.c (grow_menu_items): Check for int overflow.
5810
d89eb65e
PE
5811 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5812
5235bd3e
PE
5813 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5814 Before, the code was not consistent. These values cannot exceed
5815 2**31 - 1 so there's no need to make them unsigned.
5816 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5817 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5818 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5819 as modifiers.
5820 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5821
bc827e23
PE
5822 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5823 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5824 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5825 presumably because the widths might not match.
5826
78eb494e
PE
5827 * window.c (size_window): Avoid needless test at loop start.
5828
04f2d78b
CB
58292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5830
5831 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5832
d2fc7e3d 58332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5834
5835 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5836
d2fc7e3d 58372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5838
5839 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5840 `width' to `bar_area_x' and `bar_area_width', respectively.
5841 (x_scroll_run): Take account of fringe background extension.
5842
04f2d78b
CB
5843 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5844 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5845 `bar_area_width', respectively.
5846 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5847 background extension.
5848
79b70037
GM
58492011-05-10 Jim Meyering <meyering@redhat.com>
5850
5851 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5852
2f142cc5
JB
58532011-05-10 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * image.c (Finit_image_library): Return t for built-in image types,
5856 like pbm and xbm. (Bug#8640)
5857
57679c86
AS
58582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5859
5860 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5861
888c9e86
EZ
58622011-05-07 Eli Zaretskii <eliz@gnu.org>
5863
b0512a1d
EZ
5864 * w32console.c (Fset_screen_color): Doc fix.
5865 (Fget_screen_color): New function.
5866 (syms_of_ntterm): Defsubr it.
5867
7285dc67
EZ
5868 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5869 unlink the temporary file if Fcall_process didn't create it in the
5870 first place.
5871 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5872 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5873 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5874 cue to call_process_cleanup not to close that handle.
5875
4d3fcc8e
BK
58762011-05-07 Ben Key <bkey76@gmail.com>
5877
5878 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5879 one of two shell specific rules, either bootstrap-temacs-CMD or
5880 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5881 to the previous implementation of the bootstrap-temacs rule.
5882 The bootstrap-temacs-CMD rule is similar to the previous
5883 implementation of the bootstrap-temacs rule except that it
5884 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5885 variable.
5886
5887 These changes, along with some changes to nt/configure.bat,
5888 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5889 earlier fix to add support for --cflags and --ldflags options
5890 that include quotes so that it works whether make uses cmd or
5891 sh as the shell.
5892
b4289b64
MA
58932011-05-06 Michael Albinus <michael.albinus@gmx.de>
5894
5895 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5896 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5897 is a constant.
5898 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5899 a string. Handle both cases.
5900 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5901 (Fdbus_register_method): Use Qinvalid_function.
5902
af4c0e28
JB
59032011-05-06 Juanma Barranquero <lekktu@gmail.com>
5904
5905 * makefile.w32-in: Update dependencies.
5906 (LISP_H): Add inttypes.h and stdin.h.
5907 (PROCESS_H): Add unistd.h.
5908
c51453d9
EZ
59092011-05-06 Eli Zaretskii <eliz@gnu.org>
5910
5911 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5912 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5913
8ff0ac3c 59142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5915
4c4b566b
PE
5916 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5917
aab2b9b5
PE
5918 * term.c (vfatal): Remove stray call to va_end.
5919 It's not needed and the C Standard doesn't allow it here anyway.
5920
c378da0b
PE
5921 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5922 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5923
288b08c7
PE
5924 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5925 bytes.
5926
e3601888
PE
5927 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5928
db6c0e74
PE
5929 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5930
dd5963ea
PE
5931 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5932
88c9450f
PE
5933 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5934
2f9442b8
PE
5935 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5936
c032b5f8
PE
5937 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5938 * charset.c (Fdefine_charset_internal): Don't initialize
5939 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5940 32-bit int (Bug#8600).
a108c10b
PE
5941
5942 * lread.c (read_integer): Be more consistent with string-to-number.
5943 Use string_to_number to do the actual conversion; this avoids
5944 rounding errors and fixes some other screwups. Without this fix,
5945 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5946 (digit_to_number): Move earlier, for benefit of read_integer.
5947 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5948 not a digit in any supported base. (Bug#8602)
a108c10b 5949
ad5f9eea
PE
5950 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5951
aec1708a
PE
5952 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5953 to match comment at start of function. This also removes a
5954 GCC warning about overflow in a 32+64-bit port.
5955
47be4ab5
PE
5956 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5957
371cac43
PE
5958 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5959 Reported by Stefan Monnier in
5960 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5961 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5962 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5963
d01a7826
PE
5964 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5965 (EMACS_UINTPTR): Likewise, with uintptr_t.
5966
7fd47d5c
PE
5967 * lisp.h: Prefer 64-bit EMACS_INT if available.
5968 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5969 on 32-bit hosts that have 64-bit int, so that they can access
5970 large files.
122b0c86
PE
5971 However, temporarily disable this change unless the temporary
5972 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5973
8727937b
PE
5974 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5975
8ac068ac
PE
5976 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5977 This removes an assumption that EMACS_INT and long are the same
5978 width as pointers. The assumption is true for Emacs porting targets
5979 now, but we want to make other targets possible.
5980 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5981 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5982 In the rest of the code, change types of integers that hold casted
5983 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5984 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5985 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5986 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5987 No need to cast type when ORing.
5988 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5989 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5990 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5991 assume EMACS_INT is the same width as char *.
5992 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5993 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5994 Remove no-longer-needed casts.
5995 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5996 (xg_tool_bar_help_callback, xg_make_tool_item):
5997 Use EMACS_INTPTR to hold an integer
5998 that will be cast to void *; this can avoid a GCC warning
5999 if EMACS_INT is not the same width as void *.
6000 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6001 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6002 (current_message_1, set_message_1):
6003 Use a local to convert to proper width without a cast.
6004 * xmenu.c (dialog_selection_callback): Likewise.
6005
ede49d71
PE
6006 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6007 Also, don't assume VALBITS / RAND_BITS is less than 5,
6008 and don't rely on undefined behavior when shifting a 1 left into
6009 the sign bit.
6010 * lisp.h (get_random): Change signature to match.
6011
2f30ecd0
PE
6012 * lread.c (hash_string): Use size_t, not int, for hash computation.
6013 Normally we prefer signed values; but hashing is special, because
6014 it's better to use unsigned division on hash table sizes so that
6015 the remainder is nonnegative. Also, size_t is the natural width
6016 for hashing into memory. The previous code used 'int', which doesn't
6017 retain enough info to hash well into very large tables.
6018 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6019
2a866e7b
PE
6020 * dbusbind.c: Don't possibly lose pointer info when converting.
6021 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6022 Use XPNTR rather than XHASH, so that the high-order bits of
6023 the pointer aren't lost when converting through void *.
6024
51639eac
PE
6025 * eval.c (Fautoload): Don't double-shift a pointer.
6026
92394119
PE
6027 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6028
dbdb9a7c
JB
60292011-05-06 Juanma Barranquero <lekktu@gmail.com>
6030
6031 * gnutls.c (DEF_GNUTLS_FN):
6032 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6033
db7a0b4f
AS
60342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6035
6036 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6037 marker. (Bug#8610)
6038
f7ff1b0f 60392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6040
6041 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6042 New version that can reserve upto 2GB of heap space.
6043
f7ff1b0f 60442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6045
6046 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6047
639c109b
TZ
60482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6049
6050 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6051 `gnutls_certificate_set_x509_key_file'.
6052
d2127135
JB
60532011-05-05 Juanma Barranquero <lekktu@gmail.com>
6054
6055 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6056 Update dependencies.
6057
e968f4f3
JB
60582011-05-04 Juanma Barranquero <lekktu@gmail.com>
6059
6060 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6061 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6062 Remove unused parameter `fildes'.
6063 * process.c (read_process_output, send_process): Don't pass it.
6064
84d358f0
JB
60652011-05-04 Juanma Barranquero <lekktu@gmail.com>
6066
6067 Fix previous change: the library cache is defined in w32.c.
6068 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6069 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6070
0898ca10
JB
60712011-05-04 Juanma Barranquero <lekktu@gmail.com>
6072
6073 Implement dynamic loading of GnuTLS on Windows.
6074
6075 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6076 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6077 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6078 Declare.
6079
6080 * gnutls.c (Qgnutls_dll): Define.
6081 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6082 (gnutls_*): Declare function pointers.
6083 (init_gnutls_functions): New function to initialize function pointers.
6084 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6085 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6086 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6087 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6088 (emacs_gnutls_write, emacs_gnutls_read)
6089 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6090 (Fgnutls_available_p): New function.
6091 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6092 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6093 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6094
6095 * image.c: Include w32.h.
6096 (Vimage_type_cache): Delete.
6097 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6098 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6099 (w32_delayed_load): Move to w32.c.
6100
6101 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6102
6103 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6104 (w32_delayed_load): Move from image.c. When loading a library, record
6105 its filename in the :loaded-from property of the library id.
6106 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6107 Initialize and staticpro them.
6108 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6109
6110 * process.c: Include lisp.h before w32.h, not after.
6111 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6112 instead of gnutls_record_check_pending.
6113
6114 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6115
ff4de4aa
TZ
61162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6117
6118 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6119 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6120 as passed in.
6121
abe95abb
JD
61222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6123
6124 * xterm.c (x_set_frame_alpha): Do not set property on anything
6125 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6126
e16e55d4
JB
61272011-05-02 Juanma Barranquero <lekktu@gmail.com>
6128
6129 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6130
bafcf6a5
JB
61312011-05-02 Juanma Barranquero <lekktu@gmail.com>
6132
6133 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6134 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6135 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6136 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6137 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6138 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6139 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6140 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6141 (Qgnutls_bootprop_callbacks_verify): Make static.
6142
e7a6747f
AS
61432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6144
19ed11ba
AS
6145 * callproc.c: Indentation fixup.
6146
e7a6747f 6147 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6148 (wait_for_termination, interruptible_wait_for_termination):
6149 Move after wait_for_termination_1.
e7a6747f 6150
1ef14cb4
LMI
61512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6152
6153 * sysdep.c (interruptible_wait_for_termination): New function
6154 which is like wait_for_termination, but allows keyboard
6155 interruptions.
6156
6157 * callproc.c (Fcall_process): Add (:file "file") as an option for
6158 the STDOUT buffer.
6159 (Fcall_process_region): Ditto.
6160
330d880c
EZ
61612011-04-30 Eli Zaretskii <eliz@gnu.org>
6162
8db90b73
EZ
6163 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6164 rather than `XVECTOR (FOO)->size'.
6165
330d880c
EZ
6166 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6167 inttypes.h, as a gnulib replacement is used if it not available in
6168 system headers.
6169
15cbd324
EZ
61702011-04-21 Eli Zaretskii <eliz@gnu.org>
6171
6172 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6173 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6174 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6175
6176 * coding.c (coding_alloc_by_realloc): Error out if destination
6177 will grow beyond MOST_POSITIVE_FIXNUM.
6178 (decode_coding_emacs_mule): Abort if there isn't enough place in
6179 charbuf for the composition carryover bytes. Reserve an extra
6180 space for up to 2 characters produced in a loop.
6181 (decode_coding_iso_2022): Abort if there isn't enough place in
6182 charbuf for the composition carryover bytes.
6183
61842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6185
ae940cca
EZ
6186 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6187 aborting when %lld or %lll format is passed.
6188 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6189 %llo or %llx format is passed. (Bug#8545)
6190
03ab8921
EZ
6191 * window.c (window_scroll_line_based): Use a marker instead of
6192 simple variables to record original value of point. (Bug#7952)
6193
afda1437
EZ
6194 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6195 produced by %s or %c overflows available buffer space. (Bug#8545)
6196
f76dee0c
PE
61972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6198
6199 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6200 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6201
fdc5744d
JB
62022011-04-28 Juanma Barranquero <lekktu@gmail.com>
6203
6204 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6205
638f053a
JB
62062011-04-28 Juanma Barranquero <lekktu@gmail.com>
6207
6208 * keyboard.c (Qdelayed_warnings_hook): Define.
6209 (command_loop_1): Run `delayed-warnings-hook'
6210 if Vdelayed_warnings_list is non-nil.
6211 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6212 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6213
d178f871
EZ
62142011-04-28 Eli Zaretskii <eliz@gnu.org>
6215
6216 * doprnt.c (doprnt): Don't return value smaller than the buffer
6217 size if the message was truncated. (Bug#8545).
6218
b124fd93
JB
62192011-04-28 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6222 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6223
e810457d
PE
62242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6225
6226 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6227
ea51cceb
JB
62282011-04-27 Juanma Barranquero <lekktu@gmail.com>
6229
6230 * makefile.w32-in: Update dependencies.
6231
94dcfacf
EZ
62322011-04-27 Eli Zaretskii <eliz@gnu.org>
6233
6234 Improve `doprnt' and its usage. (Bug#8545)
6235 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6236 `format_end'. Remove support for %l as a conversion specifier.
6237 Don't use xrealloc. Improve diagnostics when the %l size modifier
6238 is used. Update the commentary.
6239
6240 * eval.c (verror): Simplify calculation of size_t.
6241
6242 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6243 messages.
6244
f61f41d7
PE
62452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6246
6247 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6248 change.
6249
96fb4434
PE
62502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6253 This makes this file independent of the recent pseudovector change.
6254
671875da 62552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6256
69e9b5a3
PE
6257 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6258
b5f869a7 6259 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6260 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6261 Remove unused local.
c8926152 6262 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6263
841a1577 6264 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6265 GCC 4.6.0 optimizes based on type-based alias analysis.
6266 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6267 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6268 != &v->size, and therefore "v->size = 1; b->size = 2; return
6269 v->size;" must therefore return 1. This assumption is incorrect
6270 for Emacs, since it type-puns struct Lisp_Vector * with many other
6271 types. To fix this problem, this patch adds a new type struct
f904488f 6272 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6273 and pseudovectors, and helps optimizing compilers not get fooled
6274 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6275 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6276 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6277 the size member.
eab3844f
PE
6278 (XSETPVECTYPE): Rewrite in terms of new macro.
6279 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6280 This is a bit clearer, and further avoids the possibility of
6281 undesirable aliasing.
6282 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6283 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6284 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6285 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6286 (ASIZE): Now uses header.size rather than size.
6287 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6288 to avoid the hassle of writing XVECTOR (foo)->header.size.
6289 (struct vectorlike_header): New type.
eab3844f
PE
6290 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6291 object, to help avoid aliasing.
6292 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6293 (SUBRP): Likewise, since Lisp_Subr is a special case.
6294 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6295 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6296 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6297 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6298 changed to be "header.size" and "header.next".
6299 * buffer.h (struct buffer): Likewise.
6300 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6301 * frame.h (struct frame): Likewise.
6302 * process.h (struct Lisp_Process): Likewise.
6303 * termhooks.h (struct terminal): Likewise.
6304 * window.c (struct save_window_data, struct saved_window): Likewise.
6305 * window.h (struct window): Likewise.
6306 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6307 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6308 * buffer.c (init_buffer_once): Likewise.
6309 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6310 special case.
6311 * process.c (Fformat_network_address): Use local var for size,
6312 for brevity.
6313
0df1eac5
PE
6314 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6315
847ab9d1 6316 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6317 * data.c (atof): Remove decl; no longer used or needed.
6318 (digit_to_number): Move to lread.c.
6319 (Fstring_to_number): Use new string_to_number function, to be
6320 consistent with how the Lisp reader treats infinities and NaNs.
6321 Do not assume that floating-point numbers represent EMACS_INT
6322 without losing information; this is not true on most 64-bit hosts.
6323 Avoid double-rounding errors, by insisting on integers when
6324 parsing non-base-10 numbers, as the documentation specifies.
6325 * lisp.h (string_to_number): New decl, replacing ...
6326 (isfloat_string): Remove.
bc0a5c13 6327 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6328 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6329 appears to have been a coding error. Similarly, do not accept
6330 strings like +-1e0 as floating point numbers. Do not report
6331 overflow for integer overflows unless the base is not 10 which
6332 means we have no simple and reliable way to continue.
6333 Break out the floating-point parsing into a new
6334 function string_to_number, so that Fstring_to_number parses
6335 floating point numbers consistently with the Lisp reader.
04f2d78b 6336 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6337 (E_CHAR, EXP_INT): Remove, replacing with ...
6338 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6339 (string_to_number): New function, replacing isfloat_string.
6340 This function checks for valid syntax and produces the resulting
6341 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6342 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6343 so that overflow for non-base-10 numbers is reported only when
6344 there's no portable and simple way to convert to floating point.
452f4150 6345
67769ffc
PE
6346 * textprop.c (set_text_properties_1): Rewrite for clarity,
6347 and to avoid GCC warning about integer overflow.
6348
c20db43f
PE
6349 * intervals.h (struct interval): Use EMACS_INT for members
6350 where EMACS_UINT might cause problems. See
6351 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6352 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6353 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6354 All uses changed.
37aa2f85
PE
6355 (offset_intervals): Tell GCC not to worry about length overflow
6356 when negating a negative length.
c20db43f 6357
2538aa2f
PE
6358 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6359 (overrun_check_free): Likewise.
6360
f2d3008d
PE
6361 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6362 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6363 word size.
6364
ec8df744
PE
6365 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6366 (gnutls_make_error): Rename local to avoid shadowing.
6367 (gnutls_emacs_global_deinit): ifdef out; not used.
6368 (Fgnutls_boot): Use const for pointer to readonly storage.
6369 Comment out unused local. Fix pointer signedness problems.
6370
640ee02d
PE
6371 * lread.c (openp): Don't stuff size_t into an 'int'.
6372 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6373 about possible signed overflow.
6374
6048fb2a
PE
6375 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6376 (GDK_KEY_g): Don't define if already defined.
6377 (xg_prepare_tooltip): Avoid pointer signedness problem.
6378 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6379
fa3c87e1
PE
6380 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6381 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6382
2172544b
PE
6383 * xfns.c (Fx_window_property): Simplify a bit,
6384 to make a bit faster and to avoid GCC 4.6.0 warning.
6385 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6386
9b821a21
PE
6387 * fns.c (internal_equal): Don't assume size_t fits in int.
6388
3c616cfa
PE
6389 * alloc.c (compact_small_strings): Tighten assertion a little.
6390
c2982e87
PE
6391 Replace pEd with more-general pI, and fix some printf arg casts.
6392 * lisp.h (pI): New macro, generalizing old pEd macro to other
6393 conversion specifiers. For example, use "...%"pI"d..." rather
6394 than "...%"pEd"...".
6395 (pEd): Remove. All uses replaced with similar uses of pI.
6396 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6397 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6398 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6399 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6400 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6401 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6402 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6403 64-bit hosts.
6404 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6405 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6406 * print.c (safe_debug_print, print_object): Likewise.
6407 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6408 to int.
6f04d126
PE
6409 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6410 avoiding the 0 flag, which is not portable.
c2982e87
PE
6411 * process.c (Fmake_network_process): Use pI to avoid cast.
6412 * region-cache.c (pp_cache): Likewise.
6413 * xdisp.c (decode_mode_spec): Likewise.
6414 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6415 behavior on 64-bit hosts with printf arg.
6f04d126 6416 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6417 (x_stop_queuing_selection_requests): Likewise.
6418 (x_get_window_property): Don't truncate byte count to an 'int'
6419 when tracing.
0b432f21 6420
5e073ec7
PE
6421 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6422 here, since it parses constructs like leading '-' and spaces,
6423 which are not wanted; and it overflows with large numbers.
6424 Instead, simply match F[0-9]+, which is what is wanted anyway.
6425
36372bf9
PE
6426 * alloc.c: Remove unportable assumptions about struct layout.
6427 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6428 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6429 (allocate_vectorlike, make_pure_vector): Use the new macros,
6430 plus offsetof, to remove unportable assumptions about struct layout.
6431 These assumptions hold on all porting targets that I know of, but
6432 they are not guaranteed, they're easy to remove, and removing them
6433 makes further changes easier.
6434
0b432f21
PE
6435 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6436 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6437 (string_overrun_cookie): Now const. Use initializers that
6438 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6439 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6440 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6441 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6442 multiple of sizeof (EMACS_INT); it need not be, if
6443 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6444 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6445
895009e1
JB
64462011-04-26 Juanma Barranquero <lekktu@gmail.com>
6447
6448 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6449
6a7a1b0b
TZ
64502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6451
6452 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6453 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6454 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6455
841a1577 64562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6457
6458 * lisp.h (Qdebug): List symbol.
895009e1 6459 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6460 * keyboard.c (debug-on-event): New variable.
6461 (handle_user_signal): Break into debugger when debug-on-event
6462 matches the current signal symbol.
6463
f2d3ba6f
DN
64642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6465
6466 * alloc.c (check_sblock, check_string_bytes)
6467 (check_string_free_list): Convert to standard C.
6468
42ce4c63
TZ
64692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6470
6471 * w32.c (emacs_gnutls_push): Fix typo.
6472
825cd63c
EZ
64732011-04-25 Eli Zaretskii <eliz@gnu.org>
6474
fb11d64d
EZ
6475 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6476 "cast to pointer from integer of different size".
6477
825cd63c
EZ
6478 Improve doprnt and its use in verror. (Bug#8545)
6479 * doprnt.c (doprnt): Document the set of format control sequences
6480 supported by the function. Use SAFE_ALLOCA instead of always
6481 using `alloca'.
6482
6483 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6484 is one byte too soon. Don't use xrealloc; instead xfree and
6485 xmalloc anew.
6486
e061a11b
TZ
64872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6488
6489 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6490 callbacks stage.
6491
6492 * gnutls.c: Renamed global_initialized to
6493 gnutls_global_initialized. Added internals for the
6494 :verify-hostname-error, :verify-error, and :verify-flags
6495 parameters of `gnutls-boot' and documented those parameters in the
6496 docstring. Start callback support.
9173deec
JB
6497 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6498 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6499 on error. Return error code.
e061a11b
TZ
6500 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6501 (emacs_gnutls_read): Likewise.
6502 (Fgnutls_boot): Return handshake error code.
6503 (emacs_gnutls_handle_error): New function.
6504 (wsaerror_to_errno): Likewise.
6505
6506 * w32.h (emacs_gnutls_pull): Add prototype.
6507 (emacs_gnutls_push): Likewise.
6508
6509 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6510 (emacs_gnutls_push): Likewise.
6511
65122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6513
6514 * process.c (wait_reading_process_output): Check if GnuTLS
6515 buffered some data internally if no FDs are set for TLS
6516 connections.
6517
6518 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6519 (LIBS): Link to USER_LIBS.
6520 ($(BLD)/gnutls.$(0)): New target.
6521
fa6996bc
EZ
65222011-04-24 Eli Zaretskii <eliz@gnu.org>
6523
eb35682e
EZ
6524 * xdisp.c (handle_single_display_spec): Rename the
6525 display_replaced_before_p argument into display_replaced_p, to
6526 make it consistent with the commentary. Fix typos in the
6527 commentary.
6528
e2ad650c
EZ
6529 * textprop.c (syms_of_textprop): Remove dead code.
6530 (copy_text_properties): Delete obsolete commentary about an
6531 interface that was deleted long ago. Fix typos in the description
6532 of arguments.
6533
1b2de274
EZ
6534 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6535 to changes in oldXMenu/XMenu.h from 2011-04-16.
6536 <menu_help_message, prev_menu_help_message>: Constify.
6537 (IT_menu_make_room): menu->help_text is now `const char **';
6538 adjust.
6539
6540 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6541 to changes in oldXMenu/XMenu.h from 2011-04-16.
6542 (struct XMenu): Declare `help_text' `const char **'.
6543
6544 * xfaces.c <Qunspecified>: Make extern again.
6545
6546 * syntax.c: Include sys/types.h before including regex.h, as
6547 required by Posix.
6548
762b15be
EZ
6549 * doc.c (get_doc_string): Improve the format passed to `error'.
6550
6551 * doprnt.c (doprnt): Improve commentary.
6552
6553 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6554
6555 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6556 them with etags.
6557
f1052e5d
EZ
6558 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6559 changes in globals.h immediately force recompilation.
762b15be
EZ
6560 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6561 $(CURDIR)/s/ms-w32.h.
6562 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6563
fa6996bc
EZ
6564 * character.c (Fchar_direction): Function deleted.
6565 (syms_of_character): Don't defsubr it.
6566 <char-direction-table>: Deleted.
6567
e6c3da20
EZ
65682011-04-23 Eli Zaretskii <eliz@gnu.org>
6569
6570 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6571 * doprnt.c: Include limits.h.
6572 (SIZE_MAX): New macro.
04f2d78b
CB
6573 (doprnt): Return a size_t value. 2nd arg is now size_t.
6574 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6575 Improve overflow protection. Support `l' modifier for integer
6576 conversions. Support %l conversion. Don't assume an EMACS_INT
6577 argument for integer conversions and for %c.
6578
6579 * lisp.h (doprnt): Restore prototype.
6580
6581 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6582 $(SRC)/character.h.
6583
6584 * Makefile.in (base_obj): Add back doprnt.o.
6585
6586 * deps.mk (doprnt.o): Add back prerequisites.
6587 (callint.o): Depend on character.h.
6588
6589 * eval.c (internal_lisp_condition_case): Include the handler
6590 representation in the error message.
6591 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6592 when breaking from the loop.
6593
6594 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6595
6596 * callint.c (Fcall_interactively): When displaying error message
6597 about invalid control letter, pass the character's codepoint, not
6598 a pointer to its multibyte form. Improve display of the character
6599 in octal and display also its hex code.
6600
6601 * character.c (char_string): Use %x to display the (unsigned)
6602 codepoint of an invalid character, to avoid displaying a bogus
6603 negative value.
6604
6605 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6606 `error', not SYMBOL_NAME itself.
6607
6608 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6609 character arguments to `error'.
6610
6611 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6612 to `error' in error message about FINAL_CHAR argument. Make sure
6613 FINAL_CHAR is a character, and use %c when it is passed as
6614 argument to `error'.
6615
4ffd0d6b 66162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6617
6618 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6619
6620 * w32.c: Include <time.h>.
6621 (sys_localtime): New function.
6622
4ffd0d6b 66232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6624
6625 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6626
4ffd0d6b 6627 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6628
4ffd0d6b 66292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6630
4ffd0d6b
GM
6631 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6632 zombies (Bug#8467).
aac0c6e3 6633
04c56954
EZ
66342011-04-19 Eli Zaretskii <eliz@gnu.org>
6635
6636 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6637 gl_state.e_property when gl_state.object is Qt.
6638
6639 * insdel.c (make_gap_larger): Remove limitation of buffer size
6640 to <= INT_MAX.
6641
16a43933
CY
66422011-04-18 Chong Yidong <cyd@stupidchicken.com>
6643
6644 * xdisp.c (lookup_glyphless_char_display)
6645 (produce_glyphless_glyph): Handle cons cell entry in
6646 glyphless-char-display.
6647 (Vglyphless_char_display): Document it.
6648
6649 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6650 glyphless-char-display.
6651
4581706e
CY
66522011-04-17 Chong Yidong <cyd@stupidchicken.com>
6653
6654 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6655
6656 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6657
6658 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6659 definition for no-X builds.
6660
4887c6e2 66612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6662
fd35b6f9
PE
6663 Static checks with GCC 4.6.0 and non-default toolkits.
6664
5c1ccb01
PE
6665 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6666
006c5daa
PE
6667 * process.c (keyboard_bit_set): Define only if SIGIO.
6668 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6669 (send_process): Repair possible setjmp clobbering.
6670
efc736d3
PE
6671 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6672
4e2fe2e6
PE
6673 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6674
f97334a2
PE
6675 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6676
4e75f29d
PE
6677 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6678 Define only if needed.
6679
90efadd1
PE
6680 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6681 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6682 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6683
3c647824
PE
6684 * dispextern.h (struct redisplay_interface): Rename param
6685 to avoid shadowing.
e264f262 6686 * termhooks.h (struct terminal): Likewise.
761383f4 6687 * xterm.c (xembed_send_message): Likewise.
3c647824 6688
b58c5c4a
PE
6689 * insdel.c (make_gap_smaller): Define only if
6690 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6691
cad59032
PE
6692 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6693 it.
6694
c339dc2e
PE
6695 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6696 so that we aren't warned about unused symbols.
6697
91a3e27b
PE
6698 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6699
399c71d3 6700 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6701
8ffc96f5
PE
6702 * xfns.c (x_real_positions): Mark locals as initialized.
6703
eef9bc79
PE
6704 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6705
098db9dd
PE
6706 * xterm.c: Fix problems found by static analysis with other toolkits.
6707 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6708 (x_dispatch_event): Declare static if USE_GTK, and
6709 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6710 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6711 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6712 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6713 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6714
eb18f6cc
PE
6715 * xmenu.c (menu_help_callback): Pointer type fixes.
6716 Use const pointers when pointing at readonly data. Avoid pointer
6717 signedness clashes.
6718 (FALSE): Remove unused macro.
6719 (update_frame_menubar): Remove unused decl.
6720
1fe72bf8
PE
6721 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6722
60d9e1db
PE
6723 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6724 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6725 (single_menu_item): Rename local to avoid shadowing.
6726
39261c26
PE
6727 * keyboard.c (make_lispy_event): Remove unused local var.
6728
018c5e19
PE
6729 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6730 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6731
63d2b86e
PE
6732 * bitmaps: Change bitmaps from unsigned char back to the X11
6733 compatible char. Avoid the old compiler warnings about
6734 out-of-range initializers by using, for example, '\xab' rather
6735 than 0xab.
6736
aefd87e1
PE
6737 * xgselect.c (xgselect_initialize): Check vs interface
6738 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6739
bf501fb9
PE
6740 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6741
e9829fdf
PE
6742 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6743 to read-only memory.
6744
1086c095
PE
6745 * fns.c (vector): Remove; this old hack is no longer needed.
6746
2baccd04 6747 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6748 Remove unused var.
dde42981 6749 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6750
72391843 6751 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6752
436c16df 6753 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6754 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6755 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6756
92bb796d 6757 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6758 (x_term_init): Remove local to avoid shadowing.
92bb796d 6759
764430a3 6760 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6761
6762 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6763 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6764
d1dfb56c
EZ
67652011-04-16 Eli Zaretskii <eliz@gnu.org>
6766
c4354cb4
EZ
6767 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6768
d1dfb56c
EZ
6769 Fix regex.c, syntax.c and friends for buffers > 2GB.
6770 * syntax.h (struct gl_state_s): Declare character position members
6771 EMACS_INT.
6772
6773 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6774
04f2d78b
CB
6775 * textprop.c (verify_interval_modification, interval_of):
6776 Declare arguments EMACS_INT.
d1dfb56c
EZ
6777
6778 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6779 EMACS_INT.
6780
6781 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6782
6783 * indent.c (Fvertical_motion): Local variable it_start is now
6784 EMACS_INT.
6785
6786 * regex.c (re_match, re_match_2, re_match_2_internal)
6787 (bcmp_translate, regcomp, regexec, print_double_string)
6788 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6789 (re_compile_pattern, re_exec): Declare arguments and local
6790 variables `size_t' and `ssize_t' and return values `regoff_t', as
6791 appropriate.
6792 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6793 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6794 <compile_stack_type>: `size' and `avail' are now `size_t'.
6795
6796 * regex.h <regoff_t>: Use ssize_t, not int.
6797 (re_search, re_search_2, re_match, re_match_2): Arguments that
6798 specify buffer/string position and length are now ssize_t and
6799 size_t. Return type is regoff_t.
6800
613052cd
BK
68012011-04-16 Ben Key <bkey76@gmail.com>
6802
6803 * nsfont.m: Fixed bugs in ns_get_family and
6804 ns_descriptor_to_entity that were caused by using free to
6805 deallocate memory blocks that were allocated by xmalloc (via
6806 xstrdup). This caused Emacs to crash when compiled with
6807 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6808 --enable-checking=xmallocoverrun). xfree is now used to
6809 deallocate these memory blocks.
6810
4170f62f 68112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6812
71b41406
PE
6813 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6814
9587a89d
PE
6815 emacs_write: Accept and return EMACS_INT for sizes.
6816 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6817 et seq.
6818 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6819 Accept and return EMACS_INT.
6820 (emacs_gnutls_write): Return the number of bytes written on
6821 partial writes.
6822 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6823 (emacs_read, emacs_write): Remove check for negative size, as the
6824 Emacs source code has been audited now.
9587a89d
PE
6825 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6826 (emacs_read, emacs_write): Use it.
273a5f82
PE
6827 * process.c (send_process): Adjust to the new signatures of
6828 emacs_write and emacs_gnutls_write. Do not attempt to store
6829 a byte offset into an 'int'; it might overflow.
9587a89d 6830 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6831
3e047f51
PE
6832 * sound.c: Don't assume sizes fit in 'int'.
6833 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6834 Return EMACS_INT, not int.
3e047f51 6835 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6836 Accept EMACS_INT, not int.
6837 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6838 record read return values.
6839
cc39a9db
BK
68402011-04-15 Ben Key <bkey76@gmail.com>
6841
c9d0ec6d
JB
6842 * keyboard.c (Qundefined): Don't declare static since it is used
6843 in nsfns.m.
6844 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6845 static since they are used in nsfont.m.
cc39a9db 6846
6c60eb9f
SM
68472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6848
6849 * process.c (Qprocessp): Don't declare static.
6850 * lisp.h (Qprocessp): Declare again.
6851
7990b61a
JB
68522011-04-15 Juanma Barranquero <lekktu@gmail.com>
6853
6854 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6855
5d4cb038
PE
68562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6857
8bd7b830 6858 Improve C-level modularity by making more things 'static'.
cd64ea1d 6859
e3b27b31
PE
6860 Don't publish debugger-only interfaces to other modules.
6861 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6862 (verify_bytepos, count_markers): Move decls to the only modules
6863 that need them.
6864 * region-cache.h (pp_cache): Likewise.
6865 * window.h (check_all_windows): Likewise.
6866 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6867
5d4cb038
PE
6868 * sysdep.c (croak): Now static, if
6869 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6870 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6871
6872 * alloc.c (refill_memory_reserve): Now static if
6873 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6874 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6875
e87b6180
PE
6876 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6877 Define only if USE_LUCID.
6878
ac64929e
PE
6879 * xrdb.c (x_customization_string, x_rm_string): Now static.
6880
6f37259d
PE
6881 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6882 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6883
1683e3ab
PE
6884 * xdisp.c (draw_row_with_mouse_face): Now static.
6885 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6886
de9c2632
PE
6887 * window.h (check_all_windows): Mark externally visible.
6888
2b96acb7
PE
6889 * window.c (window_deletion_count): Now static.
6890
6891 * undo.c: Make symbols static if they're not exported.
6892 (last_undo_buffer, last_boundary_position, pending_boundary):
6893 Now static.
6894
50436f33
PE
6895 * textprop.c (interval_insert_behind_hooks): Now static.
6896 (interval_insert_in_front_hooks): Likewise.
6897
64520e5c
PE
6898 * term.c: Make symbols static if they're not exported.
6899 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6900 (max_frame_lines, tty_set_terminal_modes):
6901 (tty_reset_terminal_modes, tty_turn_off_highlight):
6902 (get_tty_terminal): Now static.
6903 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6904 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6905 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6906 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6907 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6908
1fa53021
PE
6909 * sysdep.c: Make symbols static if they're not exported.
6910 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6911 Now static.
6912 (sigprocmask_set, full_mask): Remove; unused.
6913 (wait_debugging): Mark as visible.
6914 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6915 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6916
d4b43b22
PE
6917 * syntax.c (syntax_temp): Define only if !__GNUC__.
6918
b7c513d0
PE
6919 * sound.c (current_sound_device, current_sound): Now static.
6920
989b29ad
PE
6921 * search.c (searchbufs, searchbuf_head): Now static.
6922
13a55a78
PE
6923 * scroll.c (scroll_cost): Remove; unused.
6924 * dispextern.h (scroll_cost): Remove decl.
6925
de68a1fc
PE
6926 * region-cache.h (pp_cache): Mark as externally visible.
6927
40ccffa6
PE
6928 * process.c: Make symbols static if they're not exported.
6929 (process_tick, update_tick, create_process, chan_process):
6930 (Vprocess_alist, proc_buffered_char, datagram_access):
6931 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6932 (deactivate_process): Mark defn as static, as well as decl.
6933 * lisp.h (create_process): Remove decl.
6934 * process.h (chan_process, Vprocess_alist): Remove decls.
6935
ad64fc97
PE
6936 * print.c: Make symbols static if they're not exported.
6937 (print_depth, new_backquote_output, being_printed, print_buffer):
6938 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6939 (print_interval, print_number_index, initial_stderr_stream):
6940 Now static.
6941 * lisp.h (Fprinc): Remove decl.
6942 (debug_output_compilation_hack): Mark as externally visible.
6943
adddb265
PE
6944 * sysdep.c (croak): Move decl from here to syssignal.h.
6945 * syssignal.h (croak): Put it here, so the API can be checked when
6946 'croak' is called from dissociate_if_controlling_tty.
6947
1717ede2
PE
6948 * minibuf.c: Make symbols static if they're not exported.
6949 (minibuf_save_list, choose_minibuf_frame): Now static.
6950 * lisp.h (choose_minibuf_frame): Remove decl.
6951
fa5fb2bc
PE
6952 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6953
1e3890d1
PE
6954 * lread.c: Make symbols static if they're not exported.
6955 (read_objects, initial_obarray, oblookup_last_bucket_number):
6956 Now static.
6957 (make_symbol): Remove; unused.
6958 * lisp.h (initial_obarray, make_symbol): Remove decls.
6959
8a1414fa
PE
6960 * keyboard.c: Make symbols static if they're not exported.
6961 (single_kboard, recent_keys_index, total_keys, recent_keys):
6962 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6963 (this_single_command_key_start, echoing, last_auto_save):
6964 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6965 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6966 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6967 (Vlispy_mouse_stem, double_click_count):
6968 Now static.
6969 (force_auto_save_soon): Define only if SIGDANGER.
6970 (ignore_mouse_drag_p): Now static if
6971 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6972 (print_help): Remove; unused.
6973 (stop_character, last_timer_event): Mark as externally visible.
6974 * keyboard.h (ignore_mouse_drag_p): Declare only if
6975 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6976 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6977 * lisp.h (echoing): Remove decl.
6978 (force_auto_save_soon): Declare only if SIGDANGER.
6979 * xdisp.c (redisplay_window): Simplify code, to make it more
6980 obvious that ignore_mouse_drag_p is not accessed if !defined
6981 USE_GTK && !defined HAVE_NS.
6982
93ea6e8f
PE
6983 * intervals.c: Make symbols static if they're not exported.
6984 (merge_properties_sticky, merge_interval_right, delete_interval):
6985 Now static.
6986 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6987
77382fcc
PE
6988 * insdel.c: Make symbols static if they're not exported.
6989 However, leave prepare_to_modify_buffer alone. It's never
6990 called from outside this function, but that appears to be a bug.
6991 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6992 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6993 (adjust_after_replace_noundo): Remove; unused.
6994 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6995 (signal_before_change): Remove decls.
77382fcc 6996
9306c32e
PE
6997 * indent.c (val_compute_motion, val_vmotion): Now static.
6998
cd44d2eb
PE
6999 * image.c: Make symbols static if they're not exported.
7000 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7001 if USE_GTK.
7002 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7003 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7004
ad9a7a06
PE
7005 * fringe.c (standard_bitmaps): Now static.
7006 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7007
81626931
PE
7008 * frame.c: Make symbols static if they're not exported.
7009 (x_report_frame_params, make_terminal_frame): Now static.
7010 (get_frame_param): Now static, unless HAVE_NS.
7011 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7012 (x_get_resource_string): Remove; not used.
7013 * frame.h (make_terminal_frame, x_report_frame_params):
7014 (x_get_resource_string); Remove decls.
7015 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7016 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7017
239f9db9
PE
7018 * font.c, fontset.c: Make symbols static if they're not exported.
7019 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7020 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7021 * font.c (font_close_object): Now static.
7022 * font.h (font_close_object): Remove.
7023 * fontset.c (FONTSET_OBJLIST): Remove.
7024 (free_realized_fontset) #if-0 the body, which does nothing.
7025 (face_suitable_for_char_p): #if-0, as it's never called.
7026 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7027 * xfaces.c (face_at_string_position):
7028 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7029 since 0 is always ASCII.
7030
dfcf3579
PE
7031 * fns.c (weak_hash_tables): Now static.
7032
5045092b
PE
7033 * fileio.c: Make symbols static if they're not exported.
7034 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7035 (Vwrite_region_annotation_buffers): Now static.
7036
57a96f5c
PE
7037 * eval.c: Make symbols static if they're not exported.
7038 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7039 * lisp.h (backtrace_list): Remove decl.
7040
35f08c38
PE
7041 * emacs.c: Make symbols static if they're not exported.
7042 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7043 (fatal_error_code, fatal_error_signal_hook, standard_args):
7044 Now static.
7045 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7046 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7047 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7048 * lisp.h (fatal_error_signal_hook): Remove decl.
7049 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7050
f44bd759
PE
7051 * editfns.c: Move a (normally-unused) function to its only use.
7052 * editfns.c, lisp.h (get_operating_system_release): Remove.
7053 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7054 worth the hassle of breaking this out.
7055
b532497d
PE
7056 * xterm.c: Make symbols static if they're not exported.
7057 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7058 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7059 (x_destroy_window, x_delete_display):
7060 Now static.
7061 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7062 (x_mouse_leave): Remove; unused.
7063 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7064 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7065 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7066 Remove decls.
7067 (x_mouse_leave): Declare only if WINDOWSNT.
7068 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7069 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7070 USE_X_TOOLKIT.
7071
1675728f
PE
7072 * ftxfont.c: Make symbols static if they're not exported.
7073 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7074 HAVE_FREETYPE.
7075 * font.h (ftxfont_driver): Likewise.
7076
e4cebfca
PE
7077 * xfns.c: Make symbols static if they're not exported.
7078 (x_last_font_name, x_display_info_for_name):
7079 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7080 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7081 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7082 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7083 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7084 (last_show_tip_args): Now static.
7085 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7086 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7087 (x_screen_planes): Remove; unused.
7088 * dispextern.h (x_screen_planes): Remove decl.
7089
5bf46f05
PE
7090 * dispnew.c: Make symbols static if they're not exported.
7091 * dispextern.h (redraw_garbaged_frames, scrolling):
7092 (increment_row_positions): Remove.
7093 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7094 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7095 Now static.
7096 (redraw_garbaged_frames): Remove; unused.
7097
435f4c28
PE
7098 * xfaces.c: Make symbols static if they're not exported.
7099 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7100 Remove decls.
7101 * xterm.h (defined_color): Remove decls.
7102 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7103 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7104 (menu_face_changed_default, defined_color, free_realized_face):
7105 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7106 (ascii_face_of_lisp_face): Remove; unused.
7107
8524aef3
PE
7108 * xdisp.c: Make symbols static if they're not exported.
7109 * dispextern.h (scratch_glyph_row, window_box_edges):
7110 (glyph_to_pixel_coords, set_cursor_from_row):
7111 (get_next_display_element, set_iterator_to_next):
7112 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7113 (show_mouse_face): Remove decls
7114 * frame.h (message_buf_print): Likewise.
7115 * lisp.h (pop_message, set_message, check_point_in_composition):
7116 Likewise.
7117 * xterm.h (set_vertical_scroll_bar): Likewise.
7118 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7119 (message_buf_print, scratch_glyph_row, displayed_buffer):
7120 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7121 (get_next_display_element, show_mouse_face, window_box_edges):
7122 (frame_to_window_pixel_xy, check_point_in_composition):
7123 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7124 (glyph_to_pixel_coords): Remove; unused.
7125
16390cd2
PE
7126 * dired.c (file_name_completion): Now static.
7127
7128 * dbusbind.c (xd_in_read_queued_messages): Now static.
7129
a25f4dfa
PE
7130 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7131 * data.c (circular_list_error): Remove.
7132
14a9c8df
PE
7133 * commands.h (last_point_position, last_point_position_buffer):
7134 (last_point_position_window): Remove decls.
7135 * keyboard.c: Make these variables static.
7136
04f2d78b
CB
7137 * coding.h (coding, code_convert_region, encode_coding_gap):
7138 Remove decls.
74ab6df5
PE
7139 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7140 (iso_code_class, detect_coding, code_convert_region): Now static.
7141 (encode_coding_gap): Remove; unused.
7142
38dfbee1
PE
7143 * chartab.c (chartab_chars, chartab_bits): Now static.
7144
a2cb4e63
PE
7145 * charset.h (charset_iso_8859_1): Remove decl.
7146 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7147 Now static.
7148
127198fd
PE
7149 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7150 * ccl.c (Vccl_program_table): Now static.
7151 (check_ccl_update): Remove; unused.
7152
d85b608f
PE
7153 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7154 * category.h: ... from here.
7155 * category.c (check_category_table, set_category_set): Now static.
7156
31cd66f3
PE
7157 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7158 * lisp.h: Remove these decls.
7159
c358e587
PE
7160 * buffer.c (buffer_count): Remove unused var.
7161
e78aecca
PE
7162 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7163 so that it's not optimized away.
7164 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7165 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7166 exported only to the debugger.
7167
e192d7d3 7168 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7169 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7170
92470028
PE
7171 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7172 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7173 was inaccessible from Lisp.
7174 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7175 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7176
244ed907
PE
7177 alloc.c: Import and export fewer symbols, and remove unused items.
7178 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7179 is defined.
7180 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7181 it's not optimized away by whole-program optimization.
7182 (message_enable_multibyte, free_misc): Remove.
7183 (catchlist, handlerlist, mark_backtrace):
7184 Declare only if BYTE_MARK_STACK.
7185 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7186 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7187 (message_enable_multibyte): Remove decl.
7188 (free_misc, interval_free_list, float_block, float_block_index):
7189 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7190 (cons_free_list, last_marked_index):
7191 Now static.
7192 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7193 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7194 (mark_backtrace): Define only if BYTE_MARK_STACK.
7195 * xdisp.c (message_enable_multibyte): Now static.
7196
61c2b50e 7197 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7198 This makes it easier for human readers (and static analyzers)
7199 to see whether these variables are used from other modules.
7200 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7201 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7202 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7203 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7204 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7205 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7206 * xmenu.c, xselect.c:
7207 Declare Q* vars static if they are not used in other modules.
7208 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7209 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7210 Remove decls of unexported vars.
7211 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7212
95c82688
PE
7213 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7214
16a97296
PE
7215 Make Emacs functions such as Fatom 'static' by default.
7216 This makes it easier for human readers (and static analyzers)
7217 to see whether these functions can be called from other modules.
7218 DEFUN now defines a static function. To make the function external
7219 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7220 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7221 (Finit_image_library):
16a97296
PE
7222 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7223 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7224 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7225 Remove decls, since these functions are now static.
7226 (Funintern, Fget_internal_run_time): New decls, since these functions
7227 were already external.
95c82688 7228
16a97296
PE
7229 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7230 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7231 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7232 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7233 * keyboard.c, keymap.c, lread.c:
7234 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7235 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7236 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7237 Mark functions with DEFUE instead of DEFUN,
7238 if they are used in other modules.
7239 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7240 decls for now-static functions.
7241 * buffer.h (Fdelete_overlay): Remove decl.
7242 * callproc.c (Fgetenv_internal): Mark as internal.
7243 * composite.c (Fremove_list_of_text_properties): Remove decl.
7244 (Fcomposition_get_gstring): New forward static decl.
7245 * composite.h (Fcomposite_get_gstring): Remove decl.
7246 * dired.c (Ffile_attributes): New forward static decl.
7247 * doc.c (Fdocumntation_property): New forward static decl.
7248 * eval.c (Ffetch_bytecode): New forward static decl.
7249 (Funintern): Remove extern decl; now in .h file where it belongs.
7250 * fileio.c (Fmake_symbolic_link): New forward static decl.
7251 * image.c (Finit_image_library): New forward static decl.
7252 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7253 * intervals.h (Fprevious_property_change):
7254 (Fremove_list_of_text_properties): Remove decls.
7255 * keyboard.c (Fthis_command_keys): Remove decl.
7256 (Fcommand_execute): New forward static decl.
7257 * keymap.c (Flookup_key): New forward static decl.
7258 (Fcopy_keymap): Now static.
7259 * keymap.h (Flookup_key): Remove decl.
7260 * process.c (Fget_process): New forward static decl.
7261 (Fprocess_datagram_address): Mark as internal.
7262 * syntax.c (Fsyntax_table_p): New forward static decl.
7263 (skip_chars): Remove duplicate decl.
7264 * textprop.c (Fprevious_property_change): New forward static decl.
7265 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7266 Now internal.
7267 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7268 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7269
785bbd42
PE
7270 * editfns.c (Fformat): Remove unreachable code.
7271
8b913b57
AS
72722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7273
7274 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7275 change. (Bug#8496)
7276
a6744a35
EZ
72772011-04-13 Eli Zaretskii <eliz@gnu.org>
7278
7279 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7280 when at ZV. (Bug#8487)
7281
e7974947
AS
72822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7283
baad03f0
AS
7284 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7285 (Bug#8437)
7286 * keyboard.c (parse_tool_bar_item): Likewise.
7287 * sound.c (sound_cleanup, alsa_close): Likewise.
7288 * termcap.c (tgetent): Likewise.
7289 * xfns.c (x_default_font_parameter): Likewise.
7290 * xsettings.c (read_and_apply_settings): Likewise.
7291
e7974947
AS
7292 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7293 (overrun_check_free): Protoize.
7294
28272684
PE
72952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7296
7297 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7298 since callers should never pass a negative size.
7299 Change the signature to match that of plain 'read' and 'write'; see
7300 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7301 * lisp.h: Update prototypes of emacs_write and emacs_read.
7302
11997c76
EZ
73032011-04-11 Eli Zaretskii <eliz@gnu.org>
7304
7305 * xdisp.c (redisplay_window): Don't try to determine the character
7306 position of the scroll margin if the window start point w->startp
e896f03c 7307 is outside the buffer's accessible region. (Bug#8468)
11997c76 7308
8a2cbd72
EZ
73092011-04-10 Eli Zaretskii <eliz@gnu.org>
7310
7311 Fix write-region and its subroutines for buffers > 2GB.
7312 * fileio.c (a_write, e_write): Modify declaration of arguments and
7313 local variables to support buffers larger than 2GB.
7314 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7315
7316 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7317 argument, local variables, and return value.
7318
7319 * lisp.h: Update prototypes of emacs_write and emacs_read.
7320
7321 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7322
4073e537 73232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7324
1ebfdcb6
PE
7325 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7326
b2ded58d
PE
7327 Fix more problems found by GCC 4.6.0's static checks.
7328
7d66342c
PE
7329 * xdisp.c (vmessage): Use a better test for character truncation.
7330
bbf47d44
PE
7331 * charset.c (load_charset_map): <, not <=, for optimization,
7332 and to avoid potential problems with integer overflow.
9248994d 7333 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7334 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7335 * editfns.c (Fformat): Likewise.
1e69125e 7336 * syntax.c (skip_chars): Likewise.
3befa583 7337
e3019616
PE
7338 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7339 This also lets GCC 4.6.0 generate slightly better loop code.
7340
becfa255
PE
7341 * callint.c (Fcall_interactively): <, not <=, for optimization.
7342 (Fcall_interactively): Count the number of arguments produced,
7343 not the number of arguments given. This is simpler and lets GCC
7344 4.6.0 generate slightly better code.
7345
dae0cd48
PE
7346 * ftfont.c: Distingish more carefully between FcChar8 and char.
7347 The previous code passed unsigned char * to a functions like
7348 strlen and xstrcasecmp that expect char *, which does not
7349 conform to the C standard.
7350 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7351 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7352 char * when the C standard requires it.
7353
76032d70
PE
7354 * keyboard.c (read_char): Remove unused var.
7355
eb3f1cc8
PE
7356 * eval.c: Port to Windows vsnprintf (Bug#8435).
7357 Include <limits.h>.
7358 (SIZE_MAX): Define if the headers do not.
7359 (verror): Do not give up if vsnprintf returns a negative count.
7360 Instead, grow the buffer. This ports to Windows vsnprintf, which
7361 does not conform to C99. Problem reported by Eli Zaretskii.
7362 Also, simplify the allocation scheme, by avoiding the need for
7363 calling realloc, and removing the ALLOCATED variable.
7364
70476b54
PE
7365 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7366
12020a9e
PE
7367 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7368 But keep the doprint source code for now, as we might revamp it
7369 and use it again (Bug#8435).
ea6c7ae6
PE
7370 * lisp.h (doprnt): Remove.
7371 * Makefile.in (base_obj): Remove doprnt.o.
7372 * deps.mk (doprnt.o): Remove.
7373
5fdb398c
PE
7374 error: Print 32- and 64-bit integers portably (Bug#8435).
7375 Without this change, on typical 64-bit hosts error ("...%d...", N)
7376 was used to print both 32- and 64-bit integers N, which relied on
7377 undefined behavior.
7378 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7379 New macro.
7380 * lisp.h (error, verror): Mark as printf-like functions.
7381 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7382 Report overflow in size calculations when allocating printf buffer.
7383 Do not truncate output string at its first null byte.
7384 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7385 Truncate the output at a character boundary, since vsnprintf does not
7386 do that.
7387 * charset.c (check_iso_charset_parameter): Convert internal
7388 character to string before calling 'error', since %c now has the
7389 printf meaning.
7390 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7391 overflow when computing char to be passed to 'error'. Do not
7392 pass Lisp_Object to 'error'; pass the integer instead.
7393 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7394 formatted with plain %d.
7395
b189fa66
PE
7396 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7397
bff87ef0
PE
7398 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7399
7e2cac20
PE
7400 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7401
ce4d90b5
PE
7402 * xterm.c (x_catch_errors): Remove duplicate declaration.
7403
266c9547
PE
7404 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7405
79c49ad2
PE
7406 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7407
368f4090
JM
74082011-04-10 Jim Meyering <meyering@redhat.com>
7409
7410 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7411 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7412 return ssize_t not "int", and use size_t as the buffer length.
7413 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7414 * gnutls.h: Update declarations.
7415 * process.c (read_process_output): Use ssize_t, to match.
7416 (send_process): Likewise.
7417
a32d4040
CY
74182011-04-09 Chong Yidong <cyd@stupidchicken.com>
7419
7420 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7421
8546720e 74222011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7423
04f2d78b
CB
7424 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7425 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7426
8546720e
GM
7427 * xterm.c (handle_one_xevent):
7428 * xmenu.c (create_and_show_popup_menu):
7429 * xselect.c (x_decline_selection_request)
7430 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7431
0a2f5c1a 74322011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7433
7434 Fix some uses of `int' instead of EMACS_INT.
7435 * search.c (string_match_1, fast_string_match)
7436 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7437 (scan_buffer, find_next_newline_no_quit)
7438 (find_before_next_newline, search_command, Freplace_match)
7439 (Fmatch_data): Make some `int' variables be EMACS_INT.
7440
7441 * xdisp.c (display_count_lines): 3rd argument and return value now
7442 EMACS_INT. All callers changed.
7443 (pint2hrstr): Last argument is now EMACS_INT.
7444
7445 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7446 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7447 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7448 (decode_coding_utf_16, decode_coding_emacs_mule)
7449 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7450 (decode_coding_ccl, decode_coding_charset)
7451 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7452 (decode_coding_iso_2022, decode_coding_emacs_mule)
7453 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7454 <char_offset, last_offset>: Declare EMACS_INT.
7455 (encode_coding_utf_8, encode_coding_utf_16)
7456 (encode_coding_emacs_mule, encode_invocation_designation)
7457 (encode_designation_at_bol, encode_coding_iso_2022)
7458 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7459 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7460 Declare EMACS_INT.
7461 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7462 (encode_invocation_designation): Last argument P_NCHARS is now
7463 EMACS_INT.
7464 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7465 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7466
7467 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7468 All users changed.
7469
7470 * ccl.c (Fccl_execute_on_string): Declare some variables
7471 EMACS_INT.
7472
8546720e 74732011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7474
7475 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7476
4e19a977
CS
74772011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7478
7479 * process.c (Fformat_network_address): Doc fix.
7480
87302331
R
74812011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7482
ee7683eb 7483 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7484
cbb59342
CY
74852011-04-08 Chong Yidong <cyd@stupidchicken.com>
7486
7487 * keyboard.c (read_char): Call Lisp function help-form-show,
7488 instead of using internal_with_output_to_temp_buffer.
7489 (Qhelp_form_show): New var.
e0d38eeb 7490 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7491
7492 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7493
7494 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7495
e67a13ab
CY
74962011-04-06 Chong Yidong <cyd@stupidchicken.com>
7497
04f2d78b
CB
7498 * process.c (Flist_processes): Remove to Lisp.
7499 (list_processes_1): Delete.
e67a13ab 7500
973f782d
EZ
75012011-04-06 Eli Zaretskii <eliz@gnu.org>
7502
7c106b1e
EZ
7503 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7504
973f782d
EZ
7505 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7506
41cf7d1a 75072011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7508
ca23cc88
PE
7509 Fix more problems found by GCC 4.6.0's static checks.
7510
f390e2d5
PE
7511 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7512
42eea0d0
PE
7513 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7514
b69769da 7515 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7516
f9541e84
PE
7517 * xdisp.c (vmessage): Mark as a printf-like function.
7518
13841b55
PE
7519 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7520
c136c10f
PE
7521 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7522
5e2d4a30
PE
7523 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7524 printf-like functions.
7525 (tiff_load): Add casts to remove these marks before passing them
7526 to system-supplied API.
7527
583f48b9
PE
7528 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7529
b25d760e
PE
7530 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7531 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7532 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7533 directly, rather than having caller test rule sign. This avoids
7534 some unnecessary tests.
7535 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7536 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7537 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7538
bc7b6697 7539 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7540 (xfont_open): Avoid unnecessary tests.
bc7b6697 7541
27ccc379
PE
7542 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7543
dcd5c89a
PE
7544 * composite.h, composite.c (composition_gstring_put_cache):
7545 Use EMACS_INT, not int, for length.
7546
b13a45c6
PE
7547 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7548 breaking out part of COMPOSITION_DECODE_RULE.
7549 (COMPOSITION_DECODE_RULE): Use it.
7550 * composite.c (get_composition_id): Remove unused local vars,
7551 by using the new macro.
7552
1e792e4d
PE
7553 * textprop.c (set_text_properties_1): Change while to do-while,
7554 since the condition is always true at first.
7555
dc6c6455 7556 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7557 (interval_deletion_adjustment): Return unsigned value.
7558 All uses changed.
dc6c6455 7559
aba7731a
PE
7560 * process.c (list_processes_1, create_pty, read_process_output):
7561 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7562 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7563 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7564 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7565 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7566
fdfc4bf3
PE
7567 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7568
fca8fe46 7569 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7570 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7571
06a0259a 7572 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7573 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7574 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7575
e7b9e80f
PE
7576 * print.c (print_error_message): Avoid int overflow.
7577
56201685
PE
7578 * font.c (font_list_entities): Redo for clarity,
7579 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7580
78834453 7581 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7582 (font_score): Avoid potential overflow in diff calculation.
78834453 7583
0bc0b309 7584 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7585 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7586
e610eaca
PE
7587 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7588
b895abce
PE
7589 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7590 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7591 can always succeed if overflow has undefined behavior.
7592
1f1d9321 7593 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7594 (wordify): Omit three unnecessary tests.
1f1d9321 7595
c59478bc
PE
7596 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7597 All callers changed. This avoids the need for an unused var.
7598
79b73827
PE
7599 * casefiddle.c (casify_region): Remove var that is set but not used.
7600
a4db5dfe
PE
7601 * dired.c (file_name_completion): Remove var that is set but not used.
7602
43aae36e
PE
7603 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7604
2a47c44d 7605 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7606 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7607
a37c69bf
PE
7608 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7609 Check for integer overflow on size calculations.
7610
328ab8e7
PE
7611 * buffer.c (Fprevious_overlay_change): Remove var that is set
7612 but not used.
7613
e5a2a5cb
PE
7614 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7615 Remove vars that are set but not used.
8d84a6eb 7616 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7617 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7618
a60e5f68
PE
7619 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7620
f661cb61 7621 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7622 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7623
f0397f5a
PE
7624 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7625 that are set but not used.
7626
8664db06 7627 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7628 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7629
6abdaa4a
PE
7630 * xselect.c (x_get_local_selection, x_handle_property_notify):
7631 Remove vars that are set but not used.
7632
0ce7538d 7633 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7634 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7635
9ae848fc
PE
7636 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7637 Remove var that is set but not used.
0b918413
PE
7638 (scroll_bar_windows_size): Now size_t, not int.
7639 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7640 Check for overflow.
9ae848fc 7641
a5a62657
PE
7642 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7643 (map_tty_color) [!defined MSDOS]: Likewise.
7644
5c5cdd39
PE
7645 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7646
66ebf983
PE
7647 * coding.c: Remove vars that are set but not used.
7648 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7649 All callers changed.
7650 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7651 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7652 (decode_coding_charset): Remove vars that are set but not used.
7653
1be4d761
PE
7654 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7655 that is set but not used.
7656
47553fa8
PE
7657 * print.c (print_object): Remove var that is set but not used.
7658
1f7196bf 7659 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7660 The gnulib version avoids calling malloc in the usual case,
7661 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7662 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7663 * filelock.c (current_lock_owner): Likewise.
7664 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7665 * sysdep.c: Include allocator.h, careadlinkat.h.
7666 (emacs_no_realloc_allocator): New static constant.
7667 (emacs_readlink): New function.
fdb61804
PE
7668 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7669 ../lib/careadlinkat.h.
d1fdcab7 7670
f84c17c7
SM
76712011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7672
7673 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7674 first non-nil return value).
7675
ef3862ad
JD
76762011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7677
7678 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7679 if not defined (Bug#8403).
7680
376a7006
JB
76812011-04-02 Juanma Barranquero <lekktu@gmail.com>
7682
7683 * xdisp.c (display_count_lines): Remove parameter `start',
7684 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7685 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7686 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7687 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7688 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7689 and thereabouts. All callers changed.
7690 (get_per_char_metric): Remove parameter `f', unused since
7691 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7692
6ca3801d
JM
76932011-04-02 Jim Meyering <meyering@redhat.com>
7694
7695 do not dereference NULL upon failed strdup
7696 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7697 (ns_get_family): Likewise.
7698
d8e2b5ba
JB
76992011-04-02 Juanma Barranquero <lekktu@gmail.com>
7700
7701 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7702
8c74fcbd
JD
77032011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7704
7705 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7706 later (Bug#8403).
7707
7200d79c
SM
77082011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7709
03408648 7710 Add lexical binding.
7200d79c 7711
03408648
SM
7712 * window.c (Ftemp_output_buffer_show): New fun.
7713 (Fsave_window_excursion):
7714 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7715
7716 * lread.c (lisp_file_lexically_bound_p): New function.
7717 (Fload): Bind Qlexical_binding.
7718 (readevalloop): Remove `evalfun' arg.
7719 Bind Qinternal_interpreter_environment.
7720 (Feval_buffer): Bind Qlexical_binding.
7721 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7722 Mark as dynamic.
7723 (syms_of_lread): Declare `lexical-binding'.
7724
7725 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7726
7727 * keyboard.c (eval_dyn): New fun.
7728 (menu_item_eval_property): Use it.
ca105506
SM
7729
7730 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7731
03408648
SM
7732 * fns.c (concat, mapcar1): Accept byte-code-functions.
7733
7734 * eval.c (Fsetq): Handle lexical vars.
7735 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7736 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7737 (FletX, Flet): Obey lexical binding.
7738 (Fcommandp): Handle closures.
7739 (Feval): New `lexical' arg.
7740 (eval_sub): New function extracted from Feval. Use it almost
7741 everywhere where Feval was used. Look up vars in lexical env.
7742 Handle closures.
7743 (Ffunctionp): Move from subr.el.
7744 (Ffuncall): Handle closures.
7745 (apply_lambda): Remove `eval_flags'.
7746 (funcall_lambda): Handle closures and new byte-code-functions.
7747 (Fspecial_variable_p): New function.
7748 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7749 but without exporting it to Lisp.
23aba0ea 7750
23aba0ea 7751 * doc.c (Fdocumentation, store_function_docstring):
03408648 7752 * data.c (Finteractive_form): Handle closures.
23aba0ea 7753
03408648
SM
7754 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7755 interactive spec.
ba83908c 7756
04f2d78b
CB
7757 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7758 New byte-codes.
03408648
SM
7759 (exec_byte_code): New function extracted from Fbyte_code to handle new
7760 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7761
03408648 7762 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7763
03408648 7764 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7765
e2abce01
JB
77662011-03-31 Juanma Barranquero <lekktu@gmail.com>
7767
7768 * xdisp.c (redisplay_internal): Fix prototype.
7769
63696a73 77702011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7771
63696a73 7772 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7773 (try_scrolling): Use it when setting scroll_limit.
7774 Limit scrolling to 100 screen lines.
63696a73
EZ
7775 (redisplay_window): Even when falling back on "recentering",
7776 position point in the window according to scroll-conservatively,
7777 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7778
7779 (try_scrolling): When point is above the window, allow searching
7780 as far as scroll_max, or one screenful, to compute vertical
7781 distance from PT to the scroll margin position. This prevents
7782 try_scrolling from unnecessarily failing when
7783 scroll-conservatively is set to a value slightly larger than the
7784 window height. Clean up the case of PT below the margin at bottom
7785 of window: scroll_max can no longer be INT_MAX. When aggressive
7786 scrolling is in use, don't let point enter the opposite scroll
7787 margin as result of the scroll.
7788 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7789 threshold of 100 lines for never-recentering scrolling.
7790
e4cc2dfc
JB
77912011-03-31 Juanma Barranquero <lekktu@gmail.com>
7792
7793 * dispextern.h (move_it_by_lines):
7794 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7795 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7796 (message_log_check_duplicate): Remove parameters `prev_bol' and
7797 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7798 (redisplay_internal): Remove parameter `preserve_echo_area',
7799 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7800
7801 * indent.c (Fvertical_motion):
7802 * window.c (window_scroll_pixel_based, Frecenter):
7803 Don't pass `need_y_p' to `move_it_by_lines'.
7804
1c470562
SM
78052011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7806
44f230aa
SM
7807 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7808 steal a few bits to be more compact.
7809 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7810 Remove unneeded casts.
7811
1c470562
SM
7812 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7813
888adce9
ZK
78142011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7815
7816 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7817 binding" message (bug#7967).
7818
f838ed7b
PE
78192011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7820
77861b95
PE
7821 Fix more problems found by GCC 4.6.0's static checks.
7822
de6dbc14
PE
7823 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7824 Remove unused local var.
7825
f838ed7b
PE
7826 * editfns.c (Fmessage_box): Remove unused local var.
7827
792c7b2b
PE
7828 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7829 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7830 Omit unused local vars.
c499e557 7831 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7832 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7833 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7834 Omit unused local var.
7835
ba0165e1
PE
7836 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7837 Don't assume string length fits in int.
32ad8845 7838 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7839 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7840
3c59b4c9
PE
7841 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7842 instead of alloca (Bug#8344).
7843
a3eed478 7844 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7845 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7846
eb4d412d
PE
7847 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7848
1658b401
PE
7849 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7850 concerns.
7851
7852 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7853
7854 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7855
9a2c6e05
PE
7856 * keyboard.c (syms_of_keyboard): Use the same style as later
7857 in this function when indexing through an array. This also
7858 works around GCC bug 48267.
7859
03d0a109
PE
7860 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7861
44f730c8
PE
7862 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7863
fe75f926
PE
7864 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7865 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7866
ffa8c828
PE
7867 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7868 This avoids undefined behavior on integer overflow, and is a bit
7869 more convenient anyway since it is compared to a size_t variable.
7870
c5101a77
PE
7871 Variadic C functions now count arguments with size_t, not int.
7872 This avoids an unnecessary limitation on 64-bit machines, which
7873 caused (substring ...) to crash on large vectors (Bug#8344).
7874 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7875 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7876 All variadic functions and their callers changed accordingly.
c5101a77
PE
7877 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7878 * data.c (arith_driver, float_arith_driver): Likewise.
7879 * editfns.c (general_insert_function): Likewise.
7880 * eval.c (struct backtrace.nargs, interactive_p)
7881 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7882 (funcall_lambda, mark_backtrace): Likewise.
7883 * fns.c (concat): Likewise.
7884 * frame.c (x_set_frame_parameters): Likewise.
7885 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7886 0 if not found, not -1. All callers changed.
7887
dd3f25f7
PE
7888 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7889 (stack_copy_size): Now size_t, not int.
7890 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7891
461c2ab9
JB
78922011-03-28 Juanma Barranquero <lekktu@gmail.com>
7893
7894 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7895 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7896 All callers changed.
7897
7898 * lisp.h (multibyte_char_to_unibyte):
7899 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7900 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7901 * character.h (CHAR_TO_BYTE8):
7902 * cmds.c (internal_self_insert):
7903 * editfns.c (general_insert_function):
7904 * keymap.c (push_key_description):
7905 * search.c (Freplace_match):
7906 * xdisp.c (message_dolog, set_message_1): All callers changed.
7907
f6d62986
SM
79082011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7909
7910 * keyboard.c (safe_run_hook_funcall): New function.
7911 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7912 don't set the hook to nil, but remove the offending function instead.
7913 (Qcommand_hook_internal): Remove, unused.
7914 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7915 Vcommand_hook_internal.
7916
7917 * eval.c (enum run_hooks_condition): Remove.
7918 (funcall_nil, funcall_not): New functions.
7919 (run_hook_with_args): Call each function through a `funcall' argument.
7920 Remove `cond' argument, now redundant.
7921 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7922 (Frun_hook_with_args_until_failure): Adjust accordingly.
7923 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7924
1db5b1ad
JB
79252011-03-28 Juanma Barranquero <lekktu@gmail.com>
7926
7927 * dispextern.h (string_buffer_position): Remove declaration.
7928
7929 * print.c (strout): Remove parameter `multibyte', unused since
7930 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7931
7932 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7933 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7934 All callers changed.
7935
7936 * w32.c (_wsa_errlist): Use braces for struct initializers.
7937
7938 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7939 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7940 All callers changed.
7941 (string_buffer_position): Likewise. Also, make static (it's never
7942 used outside xdisp.c).
7943 (cursor_row_p): Remove parameter `w', unused since
7944 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7945 (decode_mode_spec): Remove parameter `precision', introduced during
7946 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7947 All callers changed.
7948
5ffb62aa
JD
79492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7950
7951 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7952
461c2ab9 79532011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7954
7955 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7956 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7957 (ns_update_auto_hide_menu_bar): New functions.
7958 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7959 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7960 ns_constrain_all_frames.
7961 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7962 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7963
5c380ffb
JD
79642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7965
7966 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7967
9af30bdf
GM
79682011-03-27 Glenn Morris <rgm@gnu.org>
7969
7970 * syssignal.h: Replace RETSIGTYPE with void.
7971 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7972 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7973 Replace SIGTYPE with void everywhere.
7974 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7975 * s/template.h (SIGTYPE): Remove commented out definition.
7976
e2abce01
JB
79772011-03-26 Eli Zaretskii <eliz@gnu.org>
7978
7979 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7980 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7981
f868cd8a
JB
79822011-03-26 Juanma Barranquero <lekktu@gmail.com>
7983
59eb0929
JB
7984 * w32.c (read_unc_volume): Use parameter `henum', instead of
7985 global variable `wget_enum_handle'.
7986
7987 * keymap.c (describe_vector): Remove parameters `indices' and
7988 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7989 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7990
f868cd8a
JB
7991 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7992
7993 * keyboard.c (timer_check): Remove parameter `do_it_now',
7994 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7995 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7996 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7997
7998 * keyboard.c (read_char):
7999 * w32menu.c (w32_menu_display_help):
8000 * xmenu.c (show_help_event, menu_help_callback):
8001 Adjust calls to `show_help_echo'.
8002
8003 * gtkutil.c (xg_maybe_add_timer):
8004 * keyboard.c (readable_events):
8005 * process.c (wait_reading_process_output):
8006 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8007
8008 * insdel.c (adjust_markers_gap_motion):
8009 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8010 (gap_left, gap_right): Don't call it.
8011
2ecf6fdb
CY
80122011-03-25 Chong Yidong <cyd@stupidchicken.com>
8013
8014 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8015 incurred during fontification.
8016
6b1f9ba4
JB
80172011-03-25 Juanma Barranquero <lekktu@gmail.com>
8018
8019 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8020 (DEFVAR_PER_BUFFER): Don't pass it.
8021
8022 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8023 (scrolling_window): Don't pass it.
8024
0f4a96b5
JB
80252011-03-25 Juanma Barranquero <lekktu@gmail.com>
8026
8027 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8028
8029 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8030 and `suffix'.
8031 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8032 of variables specific to SELinux and computation of `encoded_absname'.
8033
8034 * image.c (XPutPixel): Remove unused variable `height'.
8035
8036 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8037
8038 * unexw32.c (get_section_info): Remove unused variable `section'.
8039
8040 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8041 (system_process_attributes): Remove unused variable `sess'.
8042 (sys_read): Remove unused variable `err'.
8043
8044 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8045 (w32_wnd_proc): Remove unused variable `isdead'.
8046 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8047 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8048 (x_create_tip_frame): Remove unused variable `tem'.
8049
8050 * w32inevt.c (w32_console_read_socket):
8051 Remove unused variable `no_events'.
8052
8053 * w32term.c (x_draw_composite_glyph_string_foreground):
8054 Remove unused variable `width'.
8055
1149507c
JB
80562011-03-24 Juanma Barranquero <lekktu@gmail.com>
8057
8058 * w32term.c (x_set_glyph_string_clipping):
8059 Don't pass uninitialized region to CombineRgn.
8060
9c88f339
JB
80612011-03-23 Juanma Barranquero <lekktu@gmail.com>
8062
8063 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8064 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8065 (Fx_close_connection): Remove unused variable `i'.
8066
8067 * w32font.c (w32font_draw): Return number of glyphs.
8068 (w32font_open_internal): Remove unused variable `i'.
8069 (w32font_driver): Add missing initializer.
8070
8071 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8072 (fill_in_menu): Remove unused variable `items_added'.
8073
8074 * w32term.c (last_mouse_press_frame): Remove static global variable.
8075 (w32_clip_to_row): Remove unused variable `f'.
8076 (x_delete_terminal): Remove unused variable `i'.
8077
8078 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8079 (NOTHING): Remove unused static global variable.
8080 (uniscribe_check_otf): Remove unused variable `table'.
8081 (uniscribe_font_driver): Add missing initializers.
8082
dee091a3
JD
80832011-03-23 Julien Danjou <julien@danjou.info>
8084
8085 * term.c (Fsuspend_tty, Fresume_tty):
8086 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8087 * window.c (temp_output_buffer_show):
8088 * insdel.c (signal_before_change):
8089 * frame.c (Fhandle_switch_frame):
8090 * fileio.c (Fdo_auto_save):
8091 * emacs.c (Fkill_emacs):
8092 * editfns.c (save_excursion_restore):
8093 * cmds.c (internal_self_insert):
8094 * callint.c (Fcall_interactively):
8095 * buffer.c (Fkill_all_local_variables):
8096 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8097 Use Frun_hooks.
0f4a96b5 8098 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8099 unconditionally since it does the check itself.
dee091a3 8100
2c520ab5 81012011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8102
c9c49752
PE
8103 Fix more problems found by GCC 4.5.2's static checks.
8104
8abc3f12
PE
8105 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8106 the first time through the loop, since we know p0 < p1 then.
8107 This also avoids a gcc -Wstrict-overflow warning.
8108
a2d26660
PE
8109 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8110 leading to a memory leak, possible in functions like
8111 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8112 of objects (Bug#8318).
a2d26660 8113
916c72e9
PE
8114 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8115 that could (at least in theory) be that large.
8116
19ab8a18
PE
8117 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8118 This is less likely to overflow, and avoids undefined behavior if
8119 overflow does occur. All callers changed. Use strtoul to scan
8120 for the unsigned long integer.
b7cbbd6f
PE
8121 (pint2hrstr): Simplify and tune code slightly.
8122 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8123
f0641eff
PE
8124 * scroll.c (do_scrolling): Work around GCC bug 48228.
8125 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8126
7f650bb9
PE
8127 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8128 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8129 (validate_x_resource_name): Simplify count usage.
8130 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8131
37dd57d1
PE
8132 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8133 fail (Bug#8306).
81e56e61 8134
699979fc 8135 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8136
401bf9b4
PE
8137 * process.c (Fmake_network_process): Use socklen_t, not int,
8138 where POSIX says socklen_t is required in portable programs.
8139 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8140 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8141 (Fmake_network_process, server_accept_connection):
8142 (wait_reading_process_output, read_process_output):
8143 Likewise.
8144
b93aacde
PE
8145 * process.c: Rename or move locals to avoid shadowing.
8146 (list_processes_1, Fmake_network_process):
8147 (read_process_output_error_handler, exec_sentinel_error_handler):
8148 Rename or move locals.
4dc343ee 8149 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8150 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8151 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8152 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8153 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8154
af8a867c 8155 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8156 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8157 Include tparam.h instead, since it declares them.
af8a867c
PE
8158 * cm.h (PC): Remove extern decl; tparam.h now does this.
8159 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8160 * terminfo.c: Include tparam.h, to check interfaces.
8161 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8162 (tparam): Adjust signature to match interface in tparam.h;
8163 this removes some undefined behavior. Check that outstring and len
8164 are zero, which they always are with Emacs.
8165 * tparam.h (PC, BC, UP): New extern decls.
8166
0248044d 8167 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8168 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8169
8ff096c1 8170 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8171 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8172 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8173 (ftfont_list): Remove unused local.
49eaafba
PE
8174 (get_adstyle_property, ftfont_pattern_entity):
8175 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8176 Rename locals to avoid shadowing.
8ff096c1 8177
e2be39f6
PE
8178 * xfont.c (xfont_list_family): Mark var as initialized.
8179
c9735e30
PE
8180 * xml.c (make_dom): Now static.
8181
8f5201ae
PE
8182 * composite.c (composition_compute_stop_pos): Rename local to
8183 avoid shadowing.
b246f932
PE
8184 (composition_reseat_it): Remove unused locals.
8185 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8186 (composition_update_it): Mark var as initialized.
11b61122
PE
8187 (find_automatic_composition): Mark vars as initialized,
8188 with a FIXME (Bug#8290).
8f5201ae 8189
760fbc2c
PE
8190 character.h: Rename locals to avoid shadowing.
8191 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8192 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8193 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8194 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8195 to avoid shadowing.
8196
ff08eb85
PE
8197 * textprop.c (property_change_between_p): Remove; unused.
8198
fc7bf025
PE
8199 * intervals.c (interval_start_pos): Now static.
8200
235d7abc
PE
8201 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8202
44f230aa
SM
8203 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8204 Rename locals to avoid shadowing.
3e7d6594 8205
50060332
PE
8206 * sound.c (wav_play, au_play, Fplay_sound_internal):
8207 Fix pointer signedness.
d01f234b 8208 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8209 (wav_play): Initialize a variable to 0, to prevent undefined
8210 behavior (Bug#8278).
50060332 8211
c4fc4e30
PE
8212 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8213
918436ed
PE
8214 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8215
c939f91b
PE
8216 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8217 clobbering (Bug#8298).
b9c7f648
PE
8218 * sysdep.c (sys_subshell): Likewise.
8219 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8220
6bd8c144
PE
8221 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8222 This should get cleaned up, so that child_setup has the
8223 same signature on all platforms.
8224
7710357c 8225 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8226 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8227
c59da222
CY
82282011-03-22 Chong Yidong <cyd@stupidchicken.com>
8229
8230 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8231 not to be necessary, and produces flickering.
8232
66b87493
GM
82332011-03-20 Glenn Morris <rgm@gnu.org>
8234
8235 * config.in: Remove file.
8236
45b6f6d5
JB
82372011-03-20 Juanma Barranquero <lekktu@gmail.com>
8238
8239 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8240 are now in src/globals.h.
8241 (syms_of_minibuf): Remove spurious & from previous change.
8242
3ec03f7e
LL
82432011-03-20 Leo <sdl.web@gmail.com>
8244
8245 * minibuf.c (completing-read-function): New variable.
8246 (completing-read-default): Rename from completing-read.
8247 (completing-read): Call completing-read-function.
8248
b14e3e21
CY
82492011-03-19 Juanma Barranquero <lekktu@gmail.com>
8250
8251 * xfaces.c (Fx_load_color_file):
8252 Read color file from absolute filename (bug#8250).
8253
f2b726e6
JB
82542011-03-19 Juanma Barranquero <lekktu@gmail.com>
8255
8256 * makefile.w32-in: Update dependencies.
8257
09f6ff02
EZ
82582011-03-17 Eli Zaretskii <eliz@gnu.org>
8259
8260 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8261
29a6015a
PE
82622011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8263
a3a6c54e
PE
8264 Fix more problems found by GCC 4.5.2's static checks.
8265
b766f867
PE
8266 * process.c (make_serial_process_unwind, send_process_trap):
8267 (sigchld_handler): Now static.
8268
be02381c
PE
8269 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8270 That way, the code declares only the vars that it needs.
8271 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8272 * s/cygwin.h (PTY_ITERATION): Likewise.
8273 * s/darwin.h (PTY_ITERATION): Likewise.
8274 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8275
57048744
PE
8276 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8277 * process.c (allocate_pty): Don't declare stb unless it's needed.
8278
7914961c 8279 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8280 (CONSTANTLIM): Remove; unused.
8281 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8282 Define only if needed.
7914961c 8283
b3967b18
PE
8284 * unexelf.c (unexec): Name an expression,
8285 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8286 Use a different way to cause a compilation error if anyone uses
8287 n rather than nn, a way that does not involve shadowing.
73366a00 8288 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8289
29a6015a
PE
8290 * deps.mk (unexalpha.o): Remove; unused.
8291
43cfc33e 8292 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8293 * unexec.h: New file.
ce701a33
PE
8294 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8295 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8296 Depend on unexec.h.
8297 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8298 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8299 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8300 Change as necessary to match prototype in unexec.h.
ce701a33 8301
01f44d5a
PE
8302 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8303 shadowing.
4f63c6bb 8304 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8305
a6670b0b
PE
8306 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8307 Rename locals to avoid shadowing.
8308
cef2010d 8309 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8310 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8311
d4d7173a
PE
8312 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8313
f08b802a
PE
8314 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8315 warning when compiling print.c.
8316
3ddb0639
PE
8317 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8318 instead of using an uninitialized var.
5ad03b97 8319 (font_sort_entities): Mark var as initialized.
3ddb0639 8320
170a2692
PE
8321 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8322
e663c700
PE
8323 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8324 pointers to constants.
89bc529a 8325 (font_parse_fcname): Remove unused vars.
7b81e2d0 8326 (font_delete_unmatched): Now static.
ea838e10 8327 (font_get_spec): Remove; unused.
13a547c6
PE
8328 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8329 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8330 Rename or move locals to avoid shadowing.
e663c700 8331
2a80c887 8332 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8333 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8334
1384fa33 8335 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8336 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8337
8b2c52e9
PE
8338 * alloc.c (mark_backtrace): Move decl from here ...
8339 * lisp.h: ... to here, so that it can be checked.
8340
475545b5 8341 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8342 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8343 (lisp_indirect_variable): Name an expression,
8344 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8345 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8346
b1349114 8347 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8348 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8349 Use const pointer when appropriate.
b1349114 8350
a2928364
PE
8351 * lisp.h (get_system_name, get_operating_system_release):
8352 Move decls here, to check interfaces.
8353 * process.c (get_operating_system_release): Move decl to lisp.h.
8354 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8355 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8356 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8357 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8358 (Fformat_time_string, Fencode_time, Finsert_char):
8359 (Ftranslate_region_internal, Fformat):
8360 Rename or remove local vars to avoid shadowing.
9710023e 8361 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8362
a415e694
PE
8363 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8364 avoid shadowing.
8365
8ef4622d
PE
8366 * lisp.h (eassert): Check that the argument compiles, even if
8367 ENABLE_CHECKING is not defined.
8368
946f9a5b
PE
8369 * data.c (Findirect_variable): Name an expression, to avoid
8370 gcc -Wbad-function-cast warning.
112396d6 8371 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8372 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8373 (Fmake_variable_buffer_local, Fmake_local_variable):
8374 Mark variables as initialized.
52746918 8375 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8376
e5aab7e7 8377 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8378 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8379 Rename locals to avoid shadowing.
dff45157
PE
8380 (mark_stack): Move local variables into the #ifdef region where
8381 they're used.
7bc26fdb
PE
8382 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8383 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8384 needed otherwise.
8385 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8386 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8387 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8388
e5aab7e7
PE
8389 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8390 avoids undefined behavior in theory.
8391
4da60324
PE
8392 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8393
88043301
PE
8394 Use functions, not macros, for up- and down-casing (Bug#8254).
8395 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8396 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8397 to use the following functions instead of these macros.
8398 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8399 EMACS_INT, since callers assume the returned value fits in int.
8400 (upcase1): Likewise, for UPCASE_TABLE.
8401 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8402 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8403 the race-condition problem in the old DOWNCASE.
88043301 8404
19ed5445
PE
8405 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8406 Rename locals to avoid shadowing.
8407 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8408 (regex_compile, re_search_2, re_match_2_internal):
8409 Remove unused local vars.
952db0d7
PE
8410 (FREE_VAR): Rewrite so as not to use empty "else",
8411 which gcc can warn about.
da053e48 8412 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8413 (RETALLOC_IF): Define only if needed.
8414 (WORDCHAR_P): Likewise. This one is never needed, but is used
8415 only in a comment talking about a compiler bug, so put inside
8416 the #if 0 of that comment.
8417 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8418 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8419 Remove; unused.
19ed5445 8420
1f3561e4 8421 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8422 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8423 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8424
ded6f8f7
PE
8425 * search.c (simple_search): Remove unused var.
8426
dbd37a95
PE
8427 * dired.c (compile_pattern): Move decl from here ...
8428 * lisp.h: ... to here, so that it can be checked.
8429 (struct re_registers): New forward decl.
8430
7e47afad
PE
8431 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8432
85f24f61
PE
8433 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8434 All uses changed.
8435 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8436 Rename locals to avoid shadowing.
5671df8f 8437 (Fvertical_motion): Mark locals as initialized.
85f24f61 8438
181aa2be 8439 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8440 (casify_region): Mark local as initialized.
181aa2be 8441
930d429c
PE
8442 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8443
7082eac6
PE
8444 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8445 New macros, so that the caller can use some names other than
8446 gcpro1, gcpro2, etc.
8447 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8448 of the new macros.
8449 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8450 argument, for consistency with GCPRO2_VAR, etc: it is now the
8451 prefix of the variable, not the variable itself. All uses
8452 changed.
38b2c076
PE
8453 * dired.c (directory_files_internal, file_name_completion):
8454 Rename locals to avoid shadowing.
8455
15206ed9
PE
8456 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8457 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8458 dired.c's scmp function, had undefined behavior.
8459 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8460 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8461 * buffer.h: ... to here, because these macros use current_buffer,
8462 and the new implementation with inline functions needs to have
8463 current_buffer in scope now, rather than later when the macros
8464 are used.
8465 (downcase, upcase1): New static inline functions.
8466 (DOWNCASE, UPCASE1): Reimplement using these functions.
8467 This avoids undefined behavior in expressions like
8468 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8469 from race conditions in accessing the global variables
8470 case_temp1 and case_temp2.
8471 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8472 * lisp.h (case_temp1, case_temp2): Remove their decls.
8473 * character.h (ASCII_CHAR_P): Move from here ...
8474 * lisp.h: ... to here, so that the inline functions mentioned
8475 above can use them.
8476
4a6bea26
PE
8477 * dired.c (directory_files_internal_unwind): Now static.
8478
f14b7e14
PE
8479 * fileio.c (file_name_as_directory, directory_file_name):
8480 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8481 Now static.
2893f146
PE
8482 (file_name_as_directory): Use const pointers when appropriate.
8483 (Fexpand_file_name): Likewise. In particular, newdir might
8484 point at constant storage, so make it a const pointer.
fd4ead52 8485 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8486 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8487 signedness issues.
f839df0c
PE
8488 (Fset_file_times, Finsert_file_contents, auto_save_error):
8489 Rename locals to avoid shadowing.
f14b7e14 8490
5716756e 8491 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8492 (Ftry_completion, Fall_completions): Rename or remove locals
8493 to avoid shadowing.
5716756e 8494
b4c3046a
PE
8495 * marker.c (bytepos_to_charpos): Remove; unused.
8496
b45db522
PE
8497 * lisp.h (verify_bytepos, count_markers): New decls,
8498 so that gcc does not warn that these functions aren't declared.
8499
85876d07
PE
8500 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8501 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8502 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8503 (copy_text): Remove unused local var.
85876d07 8504
03d78a21 8505 * filelock.c (within_one_second): Now static.
b3dd38ab 8506 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8507
5df8f01b
PE
8508 * buffer.c (fix_overlays_before): Mark locals as initialized.
8509 (fix_start_end_in_overlays): Likewise. This function should be
8510 simplified by using pointers-to-pointers, but that's a different
8511 matter.
b1d876f1 8512 (switch_to_buffer_1): Now static.
8f54f30a
PE
8513 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8514 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8515
a70072c9 8516 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8517 Fix pointer signedness issue.
edced198
PE
8518 (sys_subshell): Mark local as volatile if checking for lint,
8519 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8520 (MAXPATHLEN): Define only if needed.
a70072c9 8521
a0977c44
PE
8522 * process.c (serial_open, serial_configure): Move decls from here ...
8523 * systty.h: ... to here, so that they can be checked.
8524
a884fdcc
PE
8525 * fns.c (get_random, seed_random): Move extern decls from here ...
8526 * lisp.h: ... to here, so that they can be checked.
8527
604efe86 8528 * sysdep.c (reset_io): Now static.
b8950c94 8529 (wait_for_termination_signal): Remove; unused.
604efe86 8530
38fc62d9
PE
8531 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8532 (copy_keymap_item, append_key, push_text_char_description):
8533 Now static.
1004a21a 8534 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8535 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8536 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8537 (describe_map_tree):
8538 Rename locals to avoid shadowing.
38fc62d9 8539
2f2650da
PE
8540 * keyboard.c: Declare functions static if they are not used elsewhere.
8541 (echo_char, echo_dash, cmd_error, top_level_2):
8542 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8543 (read_char, kbd_buffer_get_event, make_lispy_position):
8544 (make_lispy_event, make_lispy_movement, apply_modifiers):
8545 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8546 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8547 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8548 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8549 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8550
a053e86c 8551 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8552 (mark_kboards): Move decl here ...
8553 * alloc.c (mark_kboards): ... from here.
a053e86c 8554
4752793e
PE
8555 * lisp.h (force_auto_save_soon): New decl.
8556
74f10ca7 8557 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8558 (DEFINE_DUMMY_FUNCTION): New macro.
8559 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8560 Use it.
c03cd23f
PE
8561 (main): Add casts to avoid warnings
8562 if GCC considers string literals to be constants.
74f10ca7 8563
022e70d4
PE
8564 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8565
59d6fe83
PE
8566 * dbusbind.c: Pointer signedness fixes.
8567 (xd_signature, xd_append_arg, xd_initialize):
8568 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8569 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8570 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8571 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8572
78320123
PE
8573 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8574 if GCC considers string literals to be constants.
49cebcca 8575 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8576
35ac2a97
SM
85772011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8578
fb103ca9
SM
8579 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8580 (print_preprocess, print_object): New macro to fix last change.
8581
35ac2a97
SM
8582 * print.c (print_preprocess): Don't forget font objects.
8583
62973b41
JB
85842011-03-16 Juanma Barranquero <lekktu@gmail.com>
8585
8586 * emacs.c (USAGE3): Doc fixes.
8587
0e48bb22
AS
85882011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8589
8590 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8591 structure.
8592
7684e57b
JB
85932011-03-14 Juanma Barranquero <lekktu@gmail.com>
8594
8595 * lisp.h (VWindow_system, Qfile_name_history):
8596 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8597 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8598 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8599
8600 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8601 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8602
8603 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8604 * w32console.c (detect_input_pending, read_input_pending)
8605 (encode_terminal_code):
8606 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8607 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8608 (w32_system_caret_y, Qfile_name_history):
8609 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8610 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8611 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8612 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8613 * w32proc.c (Qlocal, report_file_error):
8614 * w32term.c (Vwindow_system, updating_frame):
8615 * w32uniscribe.c (initialized, uniscribe_font_driver):
8616 Remove unneeded extern declarations.
8617
2aa46d6c
CY
86182011-03-14 Chong Yidong <cyd@stupidchicken.com>
8619
c96bbc66 8620 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8621
cffc6f3b
CY
86222011-03-13 Chong Yidong <cyd@stupidchicken.com>
8623
8624 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8625 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8626 These macros can no longer be used for assignment.
8627
44f230aa
SM
8628 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8629 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8630 (record_buffer_markers, fetch_buffer_markers): New functions for
8631 recording and fetching special buffer markers.
8632 (set_buffer_internal_1, set_buffer_temp): Use them.
8633
8634 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8635
8636 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8637
8638 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8639 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8640
8641 * xdisp.c (hscroll_window_tree):
8642 (reconsider_clip_changes): Use PT instead of BUF_PT.
8643
d251f04b
EZ
86442011-03-13 Eli Zaretskii <eliz@gnu.org>
8645
8646 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8647 $(EMACS_ROOT)/lib/intprops.h.
8648
f0c77cd1
PE
86492011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8650
3eca4629
PE
8651 Fix more problems found by GCC 4.5.2's static checks.
8652
7c86ee98
PE
8653 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8654 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8655 (xg_free_frame_widgets): Make it clear that a local variable is
8656 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8657 (gdk_window_get_screen): Make it clear that this macro is needed
8658 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8659 (int_gtk_range_get_value): New function, which avoids a diagnostic
8660 from gcc -Wbad-function-cast.
8661 (xg_set_toolkit_scroll_bar_thumb): Use it.
8662 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8663 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8664 (get_utf8_string, xg_get_file_with_chooser):
8665 Rename locals to avoid shadowing.
8666 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8667
41729b81
PE
8668 * xgselect.c (xg_select): Remove unused var.
8669
f0c77cd1
PE
8670 * image.c (four_corners_best): Mark locals as initialized.
8671 (gif_load): Initialize transparent_p to zero (Bug#8238).
8672 Mark another local as initialized.
ec6cf4c6 8673 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8674
ce0ad53d 8675 * image.c (clear_image_cache): Now static.
d5d5a617 8676 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8677 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8678 (x_edge_detection): Remove unnecessary cast that
8679 gcc -Wbad-function-cast diagnoses.
2037898d 8680 (gif_load): Fix pointer signedness.
6ae141d6
PE
8681 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8682 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8683
33383987 86842011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8685
d32df629
PE
8686 Improve quality of tests for time stamp overflow.
8687 For example, without this patch (encode-time 0 0 0 1 1
8688 1152921504606846976) returns the obviously-bogus value (-948597
8689 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8690 reports time overflow. See
8691 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8692 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8693 * editfns.c: Include limits.h and intprops.h.
8694 (TIME_T_MIN, TIME_T_MAX): New macros.
8695 (time_overflow): Move earlier, to before first use.
8696 (hi_time, lo_time): New functions, for an accurate test for
8697 out-of-range times.
8698 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8699 (Fget_internal_run_time): Don't assume time_t fits in int.
8700 (make_time): Use list2 instead of Fcons twice.
8701 (Fdecode_time): More accurate test for out-of-range times.
8702 (check_tm_member): New function.
8703 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8704 (lisp_time_argument): Don't rely on undefined left-shift and
8705 right-shift behavior when checking for time stamp overflow.
8be6f318 8706
fe31d94c
PE
8707 * editfns.c (time_overflow): New function, refactoring common code.
8708 (Fformat_time_string, Fdecode_time, Fencode_time):
8709 (Fcurrent_time_string): Use it.
8710
8be6f318
PE
8711 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8712 * dired.c (make_time): Move to ...
8713 * editfns.c (make_time): ... here.
8714 * systime.h: Note the move.
8715
09d9db2c 87162011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8717
126bc0dc
YM
8718 * fringe.c (update_window_fringes): Remove unused variables.
8719
c47cbdfd
YM
8720 * unexmacosx.c (copy_data_segment): Also copy __got section.
8721 (Bug#8223)
8722
7ac80be9
EZ
87232011-03-12 Eli Zaretskii <eliz@gnu.org>
8724
c96bbc66 8725 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8726 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8727 Constify `char *' arguments and their references according to
8728 prototypes in tparam.h.
8729
ecb0f94d 8730 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8731
7ac80be9
EZ
8732 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8733 Adapt all references accordingly.
8734
8735 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8736
ef1fd07e
TT
87372011-03-11 Tom Tromey <tromey@redhat.com>
8738
8739 * buffer.c (syms_of_buffer): Remove obsolete comment.
8740
7ef4b50c
EZ
87412011-03-11 Eli Zaretskii <eliz@gnu.org>
8742
8743 * termhooks.h (encode_terminal_code): Declare prototype.
8744
8745 * msdos.c (encode_terminal_code): Don't declare prototype.
8746
8747 * term.c (encode_terminal_code): Now external again, used by
8748 w32console.c and msdos.c.
8749
44f230aa
SM
8750 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8751 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8752
4b1ec863 87532011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8754
1714f52b 8755 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8756
4b1ec863
PE
8757 * fringe.c (update_window_fringes): Mark locals as initialized
8758 (Bug#8227).
8759 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8760
524c7aa6
PE
8761 * alloc.c (mark_fringe_data): Move decl from here ...
8762 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8763 to check its interface.
8764 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8765
a5c0af81 8766 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8767 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8768 (fontset_font): Mark local as initialized.
a9a06e0b 8769 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8770
b4716021
PE
8771 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8772
811e9bac 8773 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8774 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8775 (x_own_selection, Fx_disown_selection_internal): Rename locals
8776 to avoid shadowing.
8777 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8778
7e3ab302
PE
8779 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8780 so that the caller can use some name other than gcpro1.
8781 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8782 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8783 (Fx_backspace_delete_keys_p):
8784 Use them to avoid shadowing, and rename vars to avoid shadowing.
8785 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8786 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8787 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8788 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8789 Remove unused locals.
7e3ab302
PE
8790 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8791 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8792 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8793 macros.
f78faa98 8794
e2b13473
PE
8795 * xterm.h (x_mouse_leave): New decl.
8796
77f23912
PE
8797 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8798 Remove unused functions.
cdf4ba58
PE
8799 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8800 (x_calc_absolute_position): Now static.
7411c686 8801 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8802 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8803 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8804 unless they are used.
38d0b34a
PE
8805 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8806 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8807 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8808 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8809 (x_error_catcher, x_connection_closed, x_error_handler):
8810 (x_error_quitter, xembed_send_message, x_iconify_frame):
8811 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8812 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8813 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8814
44f230aa
SM
8815 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8816 Rename or move locals to avoid shadowing.
6b463e58 8817 (tty_defined_color, merge_face_heights): Now static.
5967d051 8818 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8819 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8820 does not deduce is never used uninitialized.
73719eba
PE
8821 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8822 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8823
426994c3 8824 * terminal.c (store_terminal_param): Now static.
5489860b 8825
032f1620 8826 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8827 (set_frame_menubar): Remove unused local.
d4323972 8828 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8829 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8830 since they might point to immutable storage.
281585b0
PE
8831 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8832 since it's unused otherwise.
032f1620 8833
367c19e5 8834 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8835 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8836 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8837 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8838 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8839 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8840 does not deduce are never used uninitialized.
70739cbe 8841
07b48fa9
PE
8842 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8843
8868a238 8844 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8845 * window.c (window_loop, size_window):
8846 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8847
7e5cf297 8848 * window.c (display_buffer): Now static.
d6550a9f
PE
8849 (size_window): Mark variables that gcc -Wuninitialized
8850 does not deduce are never used uninitialized.
a586633d
PE
8851 * window.h (check_all_windows): New decl, to forestall
8852 gcc -Wmissing-prototypes diagnostic.
5b555da1 8853 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8854
f6095868
PE
8855 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8856 shadowing.
8857 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8858 Include <limits.h>.
8859 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8860 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8861 (load_charset_map): Mark variables that gcc -Wuninitialized
8862 does not deduce are never used uninitialized.
53df7c11 8863 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8864
f38b440c
PE
8865 * coding.c (coding_set_source, coding_set_destination):
8866 Use "else { /* comment */ }" rather than "else /* comment */;"
8867 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8868 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8869 a block, when the outer 'i' will do.
8870 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8871 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8872 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8873 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8874 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8875 Rename locals to avoid shadowing.
8876 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8877 * coding.c (emacs_mule_char, encode_invocation_designation):
8878 Now static, since they're not used elsewhere.
413bb2db 8879 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8880 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8881 (decode_coding_emacs_mule): Mark variables that gcc
8882 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8883 (detect_coding_iso_2022): Initialize a local variable that might
8884 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8885 this initialization is needed. (Bug#8211)
5f58e762
PE
8886 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8887 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8888 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8889 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8890 Remove unused macros.
f38b440c 8891
232b38b9 8892 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8893 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8894 * character.c (string_count_byte8): Likewise.
232b38b9 8895
fb90da1b
PE
8896 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8897 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8898
fb93dbc2
PE
8899 * chartab.c (copy_sub_char_table): Now static, since it's not used
8900 elsewhere.
5c156ace
PE
8901 (sub_char_table_ref_and_range, char_table_ref_and_range):
8902 Rename locals to avoid shadowing.
bbcd0949 8903 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8904
7d3b3862 8905 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8906 (BIDI_BOB): Remove unused macro.
7d3b3862 8907
6be7d3da
PE
8908 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8909 deduce are never used uninitialized.
c2ed9c8b 8910 * term.c (encode_terminal_code): Likewise.
6be7d3da 8911
75f8807f 8912 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8913
50938595
PE
8914 * tparam.h: New file.
8915 * term.c, tparam.h: Include it.
8916 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8917 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8918 Move these decls to tparam.h, and make them agree with what
8919 is actually in tparam.c. The previous trick of using incompatible
8920 decls in different modules does not conform to the C standard.
8921 All callers of tparam changed to use tparam's actual API.
8922 * tparam.c (tparam1, tparam, tgoto):
8923 Use const pointers where appropriate.
8924
fbceeba2
PE
8925 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8926 * cm.h (struct cm): Likewise.
8927 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8928 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8929 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8930 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8931 (turn_on_face, init_tty): Likewise.
8932 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8933
7f3f1250
PE
8934 * term.c (term_mouse_position): Rename local to avoid shadowing.
8935
e6ca6543
PE
8936 * alloc.c (mark_ttys): Move decl from here ...
8937 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8938
c40f8d15
AS
89392011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8940
8941 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8942
cfe0661d
JB
89432011-03-09 Juanma Barranquero <lekktu@gmail.com>
8944
8945 * search.c (compile_pattern_1): Remove argument regp, unused since
8946 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8947 (compile_pattern): Don't pass it.
8948
0afb4571
J
89492011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8950
8951 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8952 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8953 for ! HAVE_GTK3.
8954 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8955
8956 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8957
8958 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8959 gdk_window_get_screen, gdk_window_get_geometry,
8960 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8961 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8962 (xg_get_pixbuf_from_pixmap): New function.
8963 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8964 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8965 Call xg_get_pixbuf_from_pixmap instead of
8966 gdk_pixbuf_get_from_drawable.
8967 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8968 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8969 (xg_check_special_colors): Use GtkStyleContext and its functions
8970 for HAVE_GTK3.
8971 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8972 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8973 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8974 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8975 Call gtk_widget_get_preferred_size.
0afb4571
J
8976 (xg_frame_resized): gdk_window_get_geometry only takes 5
8977 parameters.
44f230aa
SM
8978 (xg_win_to_widget, xg_event_is_for_menubar):
8979 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8980 (xg_set_widget_bg): New function.
8981 (delete_cb): New function.
895009e1 8982 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8983 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8984 (xg_set_background_color): Call xg_set_widget_bg.
8985 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8986 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8987 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8988 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8989 if ! HAVE_GTK3.
8990 (update_frame_tool_bar): Call gtk_widget_hide.
8991 (xg_initialize): Use GDK_KEY_g.
8992
8993 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8994 if ! HAVE_GTK3
8995 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8996
8997 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8998 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8999 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9000
1c2cc4ef
JB
90012011-03-08 Juanma Barranquero <lekktu@gmail.com>
9002
9003 * w32xfns.c (select_palette): Check success of RealizePalette against
9004 GDI_ERROR, not zero.
9005
33383987 9006See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9007
9008;; Local Variables:
9009;; coding: utf-8
aac0c6e3
MR
9010;; End:
9011
33383987 9012 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
9013
9014 This file is part of GNU Emacs.
9015
9016 GNU Emacs is free software: you can redistribute it and/or modify
9017 it under the terms of the GNU General Public License as published by
9018 the Free Software Foundation, either version 3 of the License, or
9019 (at your option) any later version.
9020
9021 GNU Emacs is distributed in the hope that it will be useful,
9022 but WITHOUT ANY WARRANTY; without even the implied warranty of
9023 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9024 GNU General Public License for more details.
9025
9026 You should have received a copy of the GNU General Public License
9027 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.