* lisp.h (UNSIGNED_CMP): New macro.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ea204efb
PE
12011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lisp.h (UNSIGNED_CMP): New macro.
4 This fixes comparison bugs on 64-bit hosts.
5 (ASCII_CHAR_P): Use it.
6 * casefiddle.c (casify_object):
7 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
8 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10 * dispextern.h (FACE_FROM_ID):
11 * keyboard.c (read_char): Use UNSIGNED_CMP.
12
fc83f7d3 132011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 14
41cb286c
PE
15 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
16 not to EMACS_INT, to avoid GCC warning.
17
4a1b9832
PE
18 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
19
55daad71
PE
20 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
21 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
22 isn't needed on 32-bit machines.
8f95c75c 23
666398f3 24 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 25 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
26
27 * data.c (Qcompiled_function): Now static.
28
c6f072e7
PE
29 * window.c (window_body_lines): Now static.
30
20ce5912
PE
31 * image.c (gif_load): Rename local to avoid shadowing.
32
9c4c5f81
PE
33 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
34 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
35 * alloc.c (make_save_value): Integer argument is now of type
36 ptrdiff_t, not int.
37 (mark_object): Use ptrdiff_t, not int.
38 * lisp.h (pD): New macro.
39 * print.c (print_object): Use it.
40
c0c5c8ae
PE
41 * alloc.c: Use EMACS_INT, not int, to count objects.
42 (total_conses, total_markers, total_symbols, total_vector_size)
43 (total_free_conses, total_free_markers, total_free_symbols)
44 (total_free_floats, total_floats, total_free_intervals, total_intervals)
45 (total_strings, total_free_strings):
46 Now EMACS_INT, not int. All uses changed.
47 (Fgarbage_collect): Compute overall total using a double, so that
48 integer overflow is less likely to be a problem. Check for overflow
49 when converting back to an integer.
5a25e253
PE
50 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
51 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
52 These were 'int' variables that could overflow on 64-bit hosts;
53 they were never used, so remove them instead of repairing them.
211a0b2a 54 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
55 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
56 Previously, this ceilinged at INT_MAX, but that doesn't work on
57 64-bit machines.
e46bb31a 58 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 59
c78baabf 60 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 61 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
62 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
63 when a (possibly-narrower) signed value would do just as well.
64 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 65
c9d624c6
PE
66 * alloc.c: Catch some string size overflows that we were missing.
67 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
68 for convenience in STRING_BYTES_MAX.
69 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
70 The definition here is exact; the one in lisp.h was approximate.
71 (allocate_string_data): Check for string overflow. This catches
72 some instances we weren't catching before. Also, it catches
73 size_t overflow on (unusual) hosts where SIZE_MAX <= min
74 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
75 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 76
c9d624c6
PE
77 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
78 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
79 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
80
353032ce
PE
81 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
82
2bccce07
PE
83 * alloc.c (Fmake_string): Check for out-of-range init.
84
b50691aa
CY
852011-06-11 Chong Yidong <cyd@stupidchicken.com>
86
87 * dispextern.h (struct image): Replace data member, whose int_val
88 and ptr_val fields were not used by anything, with a single
89 lisp_val object.
90
91 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
92 (gif_clear_image, gif_load, imagemagick_load_image)
93 (gs_clear_image, gs_load): Callers changed.
94
3f754b86
PE
952011-06-10 Paul Eggert <eggert@cs.ucla.edu>
96
cca69397
PE
97 * buffer.h: Include <time.h>, for time_t.
98 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
99
109e28d0
PE
100 Fix minor problems found by static checking.
101
60737f02
PE
102 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
103
4b66faf3
PE
104 Make identifiers static if they are not used in other modules.
105 * data.c (Qcompiled_function, Qframe, Qvector):
106 * image.c (QimageMagick, Qsvg):
107 * minibuf.c (Qmetadata):
108 * window.c (resize_window_check, resize_root_window): Now static.
109 * window.h (resize_window_check, resize_root_window): Remove decls.
110
109e28d0
PE
111 * window.c (window_deletion_count, delete_deletable_window):
112 Remove; unused.
46a4ce9e
PE
113 (window_body_lines): Now static.
114 (Fdelete_other_windows_internal): Mark vars as initialized.
115 Make sure 'resize_failed' is initialized.
116 (run_window_configuration_change_hook): Rename local to avoid shadowing.
117 (resize_window_apply): Remove unused local.
118 * window.h (delete_deletable_window): Remove decl.
119
109e28d0 120 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
121 (imagemagick_load_image): Fix pointer signedness problem by changing
122 last arg from unsigned char * to char *. All uses changed.
123 Also, fix a local for similar reasons.
124 Remove unused locals. Remove locals to avoid shadowing.
125 (fn_rsvg_handle_free): Remove; unused.
126 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 127 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 128
3f754b86
PE
129 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
130
2547adb1
CY
1312011-06-10 Chong Yidong <cyd@stupidchicken.com>
132
133 * image.c (gif_load): Fix omitted cast error introduced by
134 2011-06-06 change.
135
2c8e37d4
MR
1362011-06-10 Martin Rudalics <rudalics@gmx.at>
137
138 * window.h (resize_proportionally, orig_total_lines)
139 (orig_top_line): Remove from window structure.
140 (set_window_height, set_window_width, change_window_heights)
141 (Fdelete_window): Remove prototypes.
142 (resize_frame_windows): Remove duplicate declaration.
143
440a42e3
EZ
1442011-06-10 Eli Zaretskii <eliz@gnu.org>
145
146 * window.h (resize_frame_windows, resize_window_check)
147 (delete_deletable_window, resize_root_window)
148 (resize_frame_windows): Declare prototypes.
149
150 * window.c (resize_window_apply): Make definition be "static" to
151 match the prototype.
152
562dd5e9
MR
1532011-06-10 Martin Rudalics <rudalics@gmx.at>
154
155 * window.c: Remove declarations of Qwindow_size_fixed,
156 window_min_size_1, window_min_size_2, window_min_size,
157 size_window, window_fixed_size_p, enlarge_window, delete_window.
158 Remove static from declaration of Qdelete_window, it's
159 temporarily needed by Fbury_buffer.
160 (replace_window): Don't assign orig_top_line and
161 orig_total_lines.
162 (Fdelete_window, delete_window): Remove. Window deletion is
163 handled by window.el.
164 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
165 Fdelete_window calls with calls to Qdelete_window.
166 (Fdelete_other_windows): Remove. Deleting other windows is
167 handled by window.el.
168 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
169 handled in window.el.
170 (window_min_size_2, window_min_size_1, window_min_size): Remove.
171 Window minimum sizes are handled in window.el.
172 (shrink_windows, size_window, set_window_height)
173 (set_window_width, change_window_heights, window_height)
174 (window_width, CURBEG, CURSIZE, enlarge_window)
175 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
176 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
177 handled in window.el.
178 (make_dummy_parent): Rename to make_parent_window and give it a
179 second argument horflag.
180 (make_window): Don't set resize_proportionally any more.
181 (Fsplit_window): Remove. Windows are split in window.el.
182 (save_restore_action, save_restore_orig_size)
183 (shrink_window_lowest_first, save_restore_orig_size): Remove.
184 Resize mini windows in window.el.
185 (grow_mini_window, shrink_mini_window): Implement by calling
186 Qresize_root_window_vertically, resize_window_check and
187 resize_window_apply.
188 (saved_window, Fset_window_configuration, save_window_save): Do
189 not handle orig_top_line, orig_total_lines, and
190 resize_proportionally.
191 (window_min_height, window_min_width): Move to window.el.
192 (keys_of_window): Move bindings for delete-other-windows,
193 split-window, delete-window and enlarge-window to window.el.
194
195 * buffer.c: Temporarily extern Qdelete_window.
196 (Fbury_buffer): Temporarily call Qdelete_window instead of
197 Fdelete_window (Fbury_buffer will move to window.el soon).
198
199 * frame.c (set_menu_bar_lines_1): Remove code handling
200 orig_top_line and orig_total_lines.
201
202 * dispnew.c (adjust_frame_glyphs_initially): Don't use
203 set_window_height but set heights directly.
204 (change_frame_size_1): Use resize_frame_windows.
205
206 * xdisp.c (init_xdisp): Don't use set_window_height but set
207 heights directly.
208
209 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
210 resize_frame_windows instead of change_window_heights and run
211 run_window_configuration_change_hook.
212
213 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
214 instead of change_window_heights and run
215 run_window_configuration_change_hook.
216
1a13852e
MR
2172011-06-09 Martin Rudalics <rudalics@gmx.at>
218
219 * window.c (replace_window): Rename second argument REPLACEMENT to
220 NEW. New third argument SETFLAG. Rewrite.
221 (delete_window, make_dummy_parent): Call replace_window with
222 third argument 1.
223 (window_list_1): Move down in code.
224 (run_window_configuration_change_hook): Move set_buffer part
225 before select_frame_norecord part in order to unwind correctly.
226 Rename count1 to count.
227 (recombine_windows, delete_deletable_window, resize_root_window)
228 (Fdelete_other_windows_internal)
229 (Frun_window_configuration_change_hook, make_parent_window)
230 (resize_window_check, resize_window_apply, Fresize_window_apply)
231 (resize_frame_windows, Fsplit_window_internal)
232 (Fdelete_window_internal, Fresize_mini_window_internal): New
233 functions.
234 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
235
f3d1777e
MR
2362011-06-08 Martin Rudalics <rudalics@gmx.at>
237
496e208e
MR
238 * window.h (window): Add some new members to window structure -
239 normal_lines, normal_cols, new_total, new_normal, clone_number,
240 splits, nest, prev_buffers, next_buffers.
241 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 242 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 243
f3d1777e
MR
244 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
245 Remove.
496e208e
MR
246 (make_dummy_parent): Set new members of windows structure.
247 (make_window): Move down in code. Handle new members of window
248 structure.
249 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
250 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
251 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
252 (Fset_window_prev_buffers, Fwindow_next_buffers)
253 (Fset_window_next_buffers, Fset_window_clone_number): New
254 functions.
255 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
256 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
257 Doc-string fixes.
258 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
259 Argument WINDOW can be now internal window too.
260 (Fwindow_use_time): Move up in code.
261 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
262 Rewrite doc-string.
263 (Fset_window_configuration, saved_window)
264 (Fcurrent_window_configuration, save_window_save): Handle new
265 members of window structure.
b9e809c2
MR
266 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
267 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
268 (syms_of_window): New Lisp objects Qrecord_window_buffer,
269 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
270 Qget_mru_window, Qresize_root_window,
271 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
272 Qauto_buffer_name; staticpro them.
f3d1777e 273
abde8f8c
MR
2742011-06-07 Martin Rudalics <rudalics@gmx.at>
275
276 * window.c (Fwindow_total_size, Fwindow_left_column)
277 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
278 (Fwindow_list_1): New functions.
279 (window_box_text_cols): Replace with window_body_cols.
280 (Fwindow_width, Fscroll_left, Fscroll_right): Use
281 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
282 (delete_window, Fset_window_configuration): Call
283 delete_all_subwindows with window as argument.
284 (delete_all_subwindows): Take a window as argument and not a
285 structure. Rewrite.
190b47e6
MR
286 (window_loop): Remove handling of GET_LRU_WINDOW and
287 GET_LARGEST_WINDOW.
288 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
289
290 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
291 window_box_text_cols. delete_all_subwindows now takes a
292 Lisp_Object as argument.
abde8f8c
MR
293
294 * indent.c (compute_motion, Fcompute_motion): Use
295 window_body_cols instead of window_box_text_cols.
296
fa8a67e6
MR
297 * frame.c (delete_frame): Call delete_all_subwindows with root
298 window as argument.
299
a54e3482
DC
3002011-06-07 Daniel Colascione <dan.colascione@gmail.com>
301
302 * fns.c (Fputhash): Document return value.
303
60002bf5
CY
3042011-06-06 Chong Yidong <cyd@stupidchicken.com>
305
306 * image.c (gif_load): Implement gif89a spec "no disposal" method.
307
0c671da6 3082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 309
b862a52a 310 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 311
be44ca6c
PE
312 Check for overflow when converting integer to cons and back.
313 * charset.c (Fdefine_charset_internal, Fdecode_char):
314 Use cons_to_unsigned to catch overflow.
315 (Fencode_char): Use INTEGER_TO_CONS.
316 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
317 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
318 * data.c (long_to_cons, cons_to_long): Remove.
319 (cons_to_unsigned, cons_to_signed): New functions.
320 These signal an error for invalid or out-of-range values.
321 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
322 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
323 * font.c (Ffont_variation_glyphs):
324 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
325 * lisp.h: Include <intprops.h>.
326 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
327 (cons_to_signed, cons_to_unsigned): New decls.
328 (long_to_cons, cons_to_long): Remove decls.
329 * undo.c (record_first_change): Use INTEGER_TO_CONS.
330 (Fprimitive_undo): Use CONS_TO_INTEGER.
331 * xfns.c (Fx_window_property): Likewise.
332 * xselect.c: Include <limits.h>.
333 (x_own_selection, selection_data_to_lisp_data):
334 Use INTEGER_TO_CONS.
335 (x_handle_selection_request, x_handle_selection_clear)
336 (x_get_foreign_selection, Fx_disown_selection_internal)
337 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
338 (lisp_data_to_selection_data): Use cons_to_unsigned.
339 (x_fill_property_data): Use cons_to_signed.
340 Report values out of range.
341
d1f3d2af
PE
342 Check for buffer and string overflow more precisely.
343 * buffer.h (BUF_BYTES_MAX): New macro.
344 * lisp.h (STRING_BYTES_MAX): New macro.
345 * alloc.c (Fmake_string):
346 * character.c (string_escape_byte8):
347 * coding.c (coding_alloc_by_realloc):
348 * doprnt.c (doprnt):
349 * editfns.c (Fformat):
350 * eval.c (verror):
351 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
352 since they may not be the same number.
353 * editfns.c (Finsert_char):
354 * fileio.c (Finsert_file_contents):
355 Likewise for BUF_BYTES_MAX.
356
dd52fcea
PE
357 * image.c: Use ptrdiff_t, not int, for sizes.
358 (slurp_file): Switch from int to ptrdiff_t.
359 All uses changed.
360 (slurp_file): Check that file size fits in both size_t (for
361 malloc) and ptrdiff_t (for sanity and safety).
362
7f9bbdbb
PE
363 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
364 if b->modtime has its maximal value.
365
dfe18f82
PE
366 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
367
84acfcf0
PE
368 Don't assume time_t can fit into int.
369 * buffer.h (struct buffer.modtime): Now time_t, not int.
370 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
371 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
372
ccd9a01a
PE
373 Minor fixes for signed vs unsigned integers.
374 * character.h (MAYBE_UNIFY_CHAR):
375 * charset.c (maybe_unify_char):
376 * keyboard.c (read_char, reorder_modifiers):
377 XINT -> XFASTINT, since the integer must be nonnegative.
378 * ftfont.c (ftfont_spec_pattern):
379 * keymap.c (access_keymap, silly_event_symbol_error):
380 XUINT -> XFASTINT, since the integer must be nonnegative.
381 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
382 since it makes no difference and we prefer signed.
383 * keyboard.c (record_char): Use XUINT when all the neighbors do.
384 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
385 nonnegative.
386
d6d100dd
SM
3872011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
388
389 * window.h (Fwindow_frame): Declare.
390
2b6148e4
PE
3912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
392
393 * alloc.c: Simplify handling of large-request failures (Bug#8800).
394 (SPARE_MEMORY): Always define.
395 (LARGE_REQUEST): Remove.
396 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
397
f230ecc9
MR
3982011-06-06 Martin Rudalics <rudalics@gmx.at>
399
727e958e
MR
400 * lisp.h: Move EXFUNS for Fframe_root_window,
401 Fframe_first_window and Fset_frame_selected_window to window.h.
402
403 * window.h: Move EXFUNS for Fframe_root_window,
404 Fframe_first_window and Fset_frame_selected_window here from
405 lisp.h.
406
407 * frame.c (Fwindow_frame, Fframe_first_window)
408 (Fframe_root_window, Fframe_selected_window)
409 (Fset_frame_selected_window): Move to window.c.
410 (Factive_minibuffer_window): Move to minibuf.c.
411 (Fother_visible_frames_p): New function.
412
413 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
414
f230ecc9
MR
415 * window.c (decode_window, decode_any_window): Move up in code.
416 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
417 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
418 (Fwindow_buffer): Move up and rewrite doc-string.
419 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
420 (Fwindow_prev): New functions.
727e958e
MR
421 (Fwindow_frame): Move here from frame.c. Accept any window as
422 argument.
423 (Fframe_root_window, Fframe_first_window)
424 (Fframe_selected_window): Move here from frame.c. Accept frame
425 or arbitrary window as argument. Update doc-strings.
426 (Fminibuffer_window): Move up in code.
427 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
428 (Fset_frame_selected_window): Move here from frame.c.
429 Marginal rewrite.
727e958e
MR
430 (Fselected_window, select_window, Fselect_window): Move up in
431 code. Minor doc-string fixes.
f230ecc9 432
4d09bcf6
PE
4332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
434
435 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
436 Do not assume that spare memory exists; that assumption is valid
437 only if SYSTEM_MALLOC.
438 (LARGE_REQUEST): New macro, so that the issue of large requests
439 is separated from the issue of spare memory.
440
810928a2
AS
4412011-06-05 Andreas Schwab <schwab@linux-m68k.org>
442
172418ad
AS
443 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
444 format. (Bug#8806)
445
43f862f7
AS
446 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
447
810928a2
AS
448 * xfns.c (x_set_scroll_bar_default_width): Move declarations
449 before statements.
450
a059fe24
JD
4512011-06-05 Jan Djärv <jan.h.d@swipnet.se>
452
453 * gtkutil.c (xg_get_default_scrollbar_width): New function.
454
455 * gtkutil.h: Declare xg_get_default_scrollbar_width.
456
457 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
458 min width by calling x_set_scroll_bar_default_width (Bug#8505).
459
989bf368
JB
4602011-06-05 Juanma Barranquero <lekktu@gmail.com>
461
462 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
463
4b80f674
CY
4642011-06-04 Chong Yidong <cyd@stupidchicken.com>
465
466 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
467 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
468 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
469 New error handlers.
4b80f674
CY
470 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
471 Obey Vx_select_enable_clipboard_manager. Catch errors in
472 x_clipboard_manager_save (Bug#8779).
473 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 474 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 475
99a33b77 4762011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
477
478 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
479
99a33b77 4802011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
481
482 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
483 in the current matrix if keep_current_p is non-zero.
484
8264569d
EZ
4852011-06-04 Eli Zaretskii <eliz@gnu.org>
486
487 * bidi.c (bidi_level_of_next_char): Fix last change.
488
57f97249
EZ
4892011-06-03 Eli Zaretskii <eliz@gnu.org>
490
fec2107c 491 Support bidi reordering of text covered by display properties.
57f97249 492
fec2107c
EZ
493 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
494 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
495 (bidi_cache_search, bidi_cache_iterator_state)
496 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
497 (bidi_level_of_next_char, bidi_move_to_visually_next):
498 Support character positions inside a run of characters covered by a
fec2107c
EZ
499 display string.
500 (bidi_paragraph_init, bidi_resolve_explicit_1)
501 (bidi_level_of_next_char): Call bidi_fetch_char and
502 bidi_fetch_char_advance instead of FETCH_CHAR and
503 FETCH_CHAR_ADVANCE.
504 (bidi_init_it): Initialize new members.
505 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
506 definitions.
507 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
508 instead of using explicit *_CHAR codes.
d6d100dd
SM
509 (bidi_resolve_explicit, bidi_resolve_weak):
510 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
511 bidirectional text is supported only in multibyte buffers.
512 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
513 it to initialize the frame_window_p member of struct bidi_it.
514 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
515 (bidi_resolve_explicit, bidi_resolve_weak)
516 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
517 bidi_it->nchars is non-positive.
518 (bidi_level_of_next_char): Don't try to lookup the cache for the
519 next/previous character if nothing is cached there yet, or if we
520 were just reseat()'ed to a new position.
c40e2fb2 521
0e14fe90
EZ
522 * xdisp.c (set_cursor_from_row): Set start and stop points
523 according to the row's direction when priming the loop that looks
524 for the glyph on which to display cursor.
525 (single_display_spec_intangible_p): Function deleted.
526 (display_prop_intangible_p): Reimplement to call
527 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
528 Accept 3 additional arguments needed by handle_display_spec.
529 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
530 values: lists, `(when COND...)' forms, etc.
531 (single_display_spec_string_p): Support property values that are
532 lists with the argument STRING its top-level element.
533 (display_prop_string_p): Fix the condition for processing a
534 property that is a list to be consistent with handle_display_spec.
fec2107c 535 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
536 last portion of handle_display_prop.
537 (compute_display_string_pos): Accept additional argument
538 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
539 value of a `display' property is a "replacing spec".
540 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
541 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
542 the display property, but just return a value indicating whether
543 the display property will replace the characters it covers.
544 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
545 frame_window_p members of struct bidi_it.
d6d100dd
SM
546 (compute_display_string_pos, compute_display_string_end):
547 New functions.
fec2107c
EZ
548 (push_it): Accept second argument POSITION, where pop_it should
549 jump to continue iteration.
550 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 551
fec2107c
EZ
552 * keyboard.c (adjust_point_for_property): Adjust the call to
553 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
554
555 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
556 (bidi_init_it): Update prototypes.
557 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
558 (compute_display_string_pos, compute_display_string_end):
559 Declare prototypes.
fec2107c
EZ
560 (struct bidi_it): New members nchars and disp_pos. ch_len is now
561 EMACS_INT.
fc6f18ce 562
40087514 5632011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 564
57f53182
PE
565 Malloc failure behavior now depends on size of allocation.
566 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
567 * lisp.h: Change signatures accordingly.
568 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
569 All callers changed. (Bug#8762)
570
571 * gnutls.c: Use Emacs's memory allocators.
572 Without this change, the gnutls library would invoke malloc etc.
573 directly, which causes problems on non-SYNC_INPUT hosts, and which
574 runs afoul of improving memory_full behavior. (Bug#8761)
575 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
576 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
577 xfree instead of the default malloc, realloc, free.
578 (Fgnutls_boot): No need to check for memory allocation failure,
579 since xmalloc does that for us.
580
ac32cd99 581 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
582 * category.c (hash_get_category_set):
583 * ccl.c (ccl_driver):
584 * charset.c (Fdefine_charset_internal):
585 * charset.h (struct charset.hash_index):
586 * composite.c (get_composition_id, gstring_lookup_cache)
587 (composition_gstring_put_cache):
588 * composite.h (struct composition.hash_index):
589 * dispextern.h (struct image.hash):
590 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
591 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
592 (hashfn_equal, hashfn_user_defined, make_hash_table)
593 (maybe_resize_hash_table, hash_lookup, hash_put)
594 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
595 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
596 (Fsxhash, Fgethash, Fputhash, Fmaphash):
597 * image.c (make_image, search_image_cache, lookup_image)
598 (xpm_put_color_table_h):
599 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 600 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
601 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
602 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
603 * alloc.c (allocate_vectorlike):
604 Check for overflow in vector size calculations.
605 * ccl.c (ccl_driver):
606 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
607 * fns.c, image.c: Remove unnecessary static decls that would otherwise
608 need to be updated by these changes.
40087514
PE
609 * fns.c (make_hash_table, maybe_resize_hash_table):
610 Check for integer overflow with large hash tables.
0de4bb68
PE
611 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
612 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
613 (SXHASH_REDUCE): New macro.
614 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
615 Use it instead of discarding useful hash info with large hash values.
616 (sxhash_float): New function.
617 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
618 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
619 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
620 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
621 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
622 Adjust signatures to match updated version of code.
623 (consing_since_gc): Now EMACS_INT, since a single hash table can
624 use more than INT_MAX bytes.
625
698d32e2
DN
6262011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
627
628 Make it possible to build with GCC-4.6+ -O2 -flto.
629
630 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
631
fd6fa53f
SM
6322011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
633
634 * minibuf.c (get_minibuffer, read_minibuf_unwind):
635 Call minibuffer-inactive-mode.
636
864db017
JB
6372011-05-31 Juanma Barranquero <lekktu@gmail.com>
638
639 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
640 Update dependencies.
641
2ad0baf4
DN
6422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
643
644 * data.c (init_data): Remove code for UTS, this system is not
645 supported anymore.
646
4fcc2638
DN
6472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
648
649 Don't force ./temacs to start in terminal mode.
650
651 * frame.c (make_initial_frame): Initialize faces in all cases, not
652 only when CANNOT_DUMP is defined.
653 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
654
c56e0fd5
DN
6552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
656
657 * dispnew.c (add_window_display_history): Use const for the string
658 pointer. Remove declaration, not needed.
659
333d54da 6602011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 661
55d4c1b2 662 Use 'inline', not 'INLINE'.
333d54da 663 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
664 * alloc.c, fontset.c (INLINE): Remove.
665 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
666 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
667 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
668 * gmalloc.c (register_heapinfo): Use inline unconditionally.
669 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
670
738db178
DN
6712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
672
673 Make it possible to run ./temacs.
674
675 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
676 syms_of_callproc does the same thing. Remove test for
677 "initialized", do it in the caller.
678 * emacs.c (main): Avoid calling set_initial_environment when dumping.
679
620c53a6
SM
6802011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
681
682 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
683 (read_minibuf): Use get_minibuffer.
684 (syms_of_minibuf): Use DEFSYM.
685 (Qmetadata): New var.
686 * data.c (Qbuffer): Don't make it static.
687 (syms_of_data): Use DEFSYM.
688
e003a292
PE
6892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
690
691 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
692 (CCL_CODE_MIN): New macro.
693
ed008a6d
PE
6942011-05-30 Paul Eggert <eggert@cs.ucla.edu>
695
3687c2ef
PE
696 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
697
ed008a6d
PE
698 * eval.c (Qdebug): Now static.
699 * lisp.h (Qdebug): Remove decl. This reverts a part of the
700 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
701 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
702
d66c4c7c
CY
7032011-05-29 Chong Yidong <cyd@stupidchicken.com>
704
705 * image.c: Various fixes to ImageMagick code comments.
706 (Fimagemagick_types): Doc fix.
707
5fbc2025
PE
7082011-05-29 Paul Eggert <eggert@cs.ucla.edu>
709
0196f88a
PE
710 Minor fixes prompted by GCC 4.6.0 warnings.
711
712 * xselect.c (converted_selections, conversion_fail_tag): Now static.
713
5fbc2025
PE
714 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
715 (x_clipboard_manager_save_all): Move extern decl to ...
716 * xterm.h: ... here, so that it can be checked for consistency.
717
1dd3c2d9
CY
7182011-05-29 Chong Yidong <cyd@stupidchicken.com>
719
720 * xselect.c (x_clipboard_manager_save_frame)
721 (x_clipboard_manager_save_all): New functions.
722 (Fx_clipboard_manager_save): Lisp function deleted.
723
724 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
725 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
726
727 * xterm.h: Update prototype.
728
5ba6571d
WX
7292011-05-28 William Xu <william.xwl@gmail.com>
730
731 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
732 exiting (Bug#8239).
733
3eaff834
JM
7342011-05-28 Jim Meyering <meyering@redhat.com>
735
e1900994 736 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
737 * fns.c (to_uchar): Define.
738 (crypto_hash_function): Use it to convert some newly-signed
739 variables to unsigned, to avoid sign-extension bugs. For example,
740 without this change, (md5 "truc") would evaluate to
741 45723a2aff78ff4fff7fff1114760e62 rather than the expected
742 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 743 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 744
0f6990a7
PE
7452011-05-27 Paul Eggert <eggert@cs.ucla.edu>
746
747 Integer overflow fixes.
c8a9ca5a 748
08686060
PE
749 * dbusbind.c: Serial number integer overflow fixes.
750 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
751 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
752 to hold a serial number that is too large for a fixnum.
753 (Fdbus_method_return_internal, Fdbus_method_error_internal):
754 Check for serial numbers out of range. Decode any serial number
59568bf0 755 that was so large that it became a float. (Bug#8722)
08686060 756
2d1fc3c7
PE
757 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
758 (Fdbus_call_method, Fdbus_call_method_asynchronously):
759 Use XFASTINT rather than XUINT when numbers are nonnegative.
760 (xd_append_arg, Fdbus_method_return_internal):
761 (Fdbus_method_error_internal): Likewise. Also, for unsigned
762 arguments, check that Lisp number is nonnegative, rather than
59568bf0 763 silently wrapping negative numbers around. (Bug#8722)
30217ff0 764 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 765 (Bug#8722)
2d1fc3c7 766
c8a9ca5a
PE
767 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
768
519e1d69
PE
769 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
770
30569699
PE
771 ccl: add integer overflow checks
772 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
773 (IN_INT_RANGE): New macros.
774 (ccl_driver): Use them to check for integer overflow when
775 decoding a CCL program. Many of the new checks are whether XINT (x)
776 fits in int; it doesn't always, on 64-bit hosts. The new version
777 doesn't catch all possible integer overflows, but it's an
847044ea 778 improvement. (Bug#8719)
30569699 779
c11285dc
PE
780 * alloc.c (make_event_array): Use XINT, not XUINT.
781 There's no need for unsigned here.
782
fdccd48e
PE
783 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
784 This follows up to the 2011-05-06 change that substituted uintptr_t
785 for EMACS_INT. This case wasn't caught back then.
786
37910ab2
PE
787 Rework Fformat to avoid integer overflow issues.
788 * editfns.c: Include <float.h> unconditionally, as it's everywhere
789 now (part of C89). Include <verify.h>.
790 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
791 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
792 (Fformat): Avoid the prepass trying to compute sizes; it was only
793 approximate and thus did not catch overflow reliably. Instead, walk
794 through the format just once, formatting and computing sizes as we go,
795 checking for integer overflow at every step, and allocating a larger
796 buffer as needed. Keep track separately whether the format is
797 multibyte. Keep only the most-recently calculated precision, rather
798 than them all. Record whether each argument has been converted to
799 string. Use EMACS_INT, not int, for byte and char and arg counts.
800 Support field widths and precisions larger than INT_MAX. Avoid
801 sprintf's undefined behavior with conversion specifications such as %#d
802 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
803 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
804 formatting out-of-range floating point numbers with int
805 formats. (Bug#8668)
806
2e6578fb
PE
807 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
808
0ae6bdee
PE
809 * data.c: Avoid integer truncation in expressions involving floats.
810 * data.c: Include <intprops.h>.
811 (arith_driver): When there's an integer overflow in an expression
812 involving floating point, convert the integers to floating point
813 so that the resulting value does not suffer from catastrophic
814 integer truncation. For example, on a 64-bit host (* 4
815 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
816 Do not rely on undefined behavior after integer overflow.
817
de883a70
PE
818 merge count_size_as_multibyte, parse_str_to_multibyte
819 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 820 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
821 Check for integer overflow.
822 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
823 since it's now a duplicate of the other. This is more of
824 a character than a buffer op, so better that it's in character.c.
825 * fns.c, print.c: Adjust to above changes.
826
2ff916cb
PE
8272011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
828
829 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
830
f1b54466
PE
8312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
832
fb1ac845
PE
833 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
834 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
835 (x_clipboard_manager_save): Now static.
836 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
837
f1b54466
PE
838 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
839 (crypto_hash_function): Now static.
840 Fix pointer signedness problems. Avoid unnecessary initializations.
841
a9f737ee
CY
8422011-05-27 Chong Yidong <cyd@stupidchicken.com>
843
844 * termhooks.h (Vselection_alist): Make it terminal-local.
845
846 * terminal.c (create_terminal): Initialize it.
847
848 * xselect.c: Support for clipboard managers.
849 (Vselection_alist): Move to termhooks.h as terminal-local var.
850 (LOCAL_SELECTION): New macro.
851 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
852 (symbol_to_x_atom): Remove gratuitous arg.
853 (x_handle_selection_request, lisp_data_to_selection_data)
854 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
855 (x_own_selection, x_get_local_selection, x_convert_selection):
856 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
857 (some_frame_on_display): Delete unused function.
858 (Fx_own_selection_internal, Fx_get_selection_internal)
859 (Fx_disown_selection_internal, Fx_selection_owner_p)
860 (Fx_selection_exists_p): New optional frame arg.
861 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
862 (x_handle_selection_clear): Don't treat other terminals with the
863 same keyboard specially. Use the terminal-local Vselection_alist.
864 (x_clear_frame_selections): Use Frun_hook_with_args.
865
866 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
867
868 * xterm.h: Add support for those atoms.
869
e067f0c1
CY
8702011-05-26 Chong Yidong <cyd@stupidchicken.com>
871
872 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
873 (converted_selections, conversion_fail_tag): New global variables.
874 (x_selection_request_lisp_error): Free the above.
875 (x_get_local_selection): Remove unnecessary code.
876 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
877 of converted selections stored in converted_selections.
878 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
879 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
880 (x_convert_selection): New function.
881 (x_handle_selection_event): Simplify.
882 (x_get_foreign_selection): Don't ignore incoming requests while
883 waiting for an answer; this will fail when we implement
884 SAVE_TARGETS, and seems unnecessary anyway.
885 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
886 (Vx_sent_selection_functions): Doc fix.
887
0f4aebc0
LL
8882011-05-26 Leo Liu <sdl.web@gmail.com>
889
890 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
891
e61124cd
YM
8922011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
893
894 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
895
896 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
897 for fringe update if it has periodic bitmap.
898 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
899 and fringe_bitmap_periodic_p.
900
901 * fringe.c (get_fringe_bitmap_data): New function.
902 (draw_fringe_bitmap_1, update_window_fringes): Use it.
903 (update_window_fringes): Record periodicity of fringe bitmap in glyph
904 row. Mark glyph row for fringe update if periodicity changed.
905
906 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
907 for fringe update unless it has periodic bitmap.
908
f16d9837
KH
9092011-05-25 Kenichi Handa <handa@m17n.org>
910
911 * xdisp.c (get_next_display_element): Set correct it->face_id for
912 a static composition.
913
e1b90ef6
LL
9142011-05-24 Leo Liu <sdl.web@gmail.com>
915
916 * deps.mk (fns.o):
917 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
918
919 * fns.c (crypto_hash_function, Fsha1): New function.
920 (Fmd5): Use crypto_hash_function.
921 (syms_of_fns): Add Ssha1.
922
7400048f
PE
9232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
924
925 * gnutls.c: Remove unused macros.
926 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
927 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
928 Remove macros that are defined and never used.
929 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
930
abb71cf4
CY
9312011-05-22 Chong Yidong <cyd@stupidchicken.com>
932
933 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
934 (Fx_get_selection_internal): Minor cleanup.
935 (Fx_own_selection_internal): Rename arguments for consistency with
936 select.el.
937
6307db39
PE
9382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
939
940 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
941
f3d4e0a4
CY
9422011-05-22 Chong Yidong <cyd@stupidchicken.com>
943
944 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
945
4d8ade89
YM
9462011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
947
948 * dispnew.c (scrolling_window): Don't exclude the case that the
949 last enabled row in the desired matrix touches the bottom boundary.
950
32078c8d
GM
9512011-05-21 Glenn Morris <rgm@gnu.org>
952
953 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
954 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
955 and add some more files.
32078c8d 956
7285dc67
EZ
9572011-05-20 Eli Zaretskii <eliz@gnu.org>
958
959 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
960 report_file_error introduced by the change from 2011-05-07.
961
89d1bd22
PE
9622011-05-20 Paul Eggert <eggert@cs.ucla.edu>
963
964 * systime.h (Time): Define only if emacs is defined.
965 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
966 where the include path doesn't have X11/X.h by default. See
967 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
968
e23640bb 9692011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
970
971 * composite.c (find_automatic_composition): Fix previous change.
972
b9704ad9
GM
9732011-05-20 Glenn Morris <rgm@gnu.org>
974
975 * lisp.mk: New file, split from Makefile.in.
976 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
977 (shortlisp): Remove.
978 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
979
4a720484
GM
9802011-05-19 Glenn Morris <rgm@gnu.org>
981
982 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
983 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
984 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
985 (lisp): Set the order to that of loadup.el.
986 (shortlisp): Make it a copy of $lisp.
987 (SOME_MACHINE_LISP): Remove.
988 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
989 Use just $shortlisp, not $SOME_MACHINE_LISP too.
990
a28d4396
KH
9912011-05-18 Kenichi Handa <handa@m17n.org>
992
993 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
994 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
995 (find_automatic_composition): Mostly rewrite for efficiency.
996
a2b1fa8e
JB
9972011-05-18 Juanma Barranquero <lekktu@gmail.com>
998
999 * makefile.w32-in: Update dependencies.
1000
8e1f5610
CS
10012011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1002
1003 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1004 revision 104625).
1005
7025ee00 10062011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1007
cdfa6eab
PE
1008 Fix some integer overflow issues, such as string length overflow.
1009
06d6db33
PE
1010 * insdel.c (count_size_as_multibyte): Check for string overflow.
1011
2b4560a8
PE
1012 * character.c (lisp_string_width): Check for string overflow.
1013 Use EMACS_INT, not int, for string indexes and lengths; in
1014 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1015 the resulting string length overflows an EMACS_INT; instead,
1016 report a string overflow if no precision given. When checking for
1017 precision exhaustion, use a check that cannot possibly have
1018 integer overflow. (Bug#8675)
1019 * character.h (lisp_string_width): Adjust to new signature.
1020
cb93f9be
PE
1021 * alloc.c (string_overflow): New function.
1022 (Fmake_string): Use it. This doesn't change behavior, but saves
1023 a few bytes and will simplify future changes.
1024 * character.c (string_escape_byte8): Likewise.
1025 * lisp.h (string_overflow): New decl.
1026
1a1f3366
PE
1027 Fixups, following up to the user-interface timestamp change.
1028 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1029 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1030 * msdos.c (mouse_get_pos): Likewise.
1031 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1032 * w32gui.h (Time): Define by including "systime.h" rather than by
1033 declaring it ourselves. (Bug#8664)
1034
d4e3e4d3
PE
1035 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1036 * image.c (clear_image_cache): Likewise.
1037
f6a24d19
PE
1038 * term.c (term_mouse_position): Don't assume time_t wraparound.
1039
08dc5ae6
PE
1040 Be more systematic about user-interface timestamps.
1041 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1042 and sometimes 'EMACS_UINT', to represent these timestamps.
1043 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1044 This makes the code easier to follow, and makes it easier to catch
1045 integer overflow bugs such as Bug#8664.
1046 * frame.c (Fmouse_position, Fmouse_pixel_position):
1047 Use Time, not unsigned long, for user-interface timestamps.
1048 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1049 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1050 * keyboard.h (last_event_timestamp): Likewise.
1051 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1052 * menu.h (xmenu_show): Likewise.
1053 * term.c (term_mouse_position): Likewise.
1054 * termhooks.h (struct input_event.timestamp): Likewise.
1055 (struct terminal.mouse_position_hook): Likewise.
1056 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1057 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1058 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1059 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1060 what it was before.
1061 * menu.h, termhooks.h: Include "systime.h", for Time.
1062
8e55734a
PE
1063 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1064 Don't assume that the difference between two unsigned long values
1065 can fit into an integer. At this point, we know button_down_time
1066 <= event->timestamp, so the difference must be nonnegative, so
1067 there's no need to cast the result if double-click-time is
1068 nonnegative, as it should be; check that it's nonnegative, just in
1069 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1070 apart (about 25 days). (Bug#8664)
8e55734a 1071
841f1b75 1072 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1073 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1074
3e26f69c
PE
1075 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1076 that always fit in int. Use a sentinel instead of a counter, to
1077 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1078 * frame.h (struct frame): Use int for menu_bar_items_used
1079 instead of EMACS_INT, since it always fits in int.
3e26f69c 1080
5cc152c0
PE
1081 * menu.c (grow_menu_items): Check for int overflow.
1082
d89eb65e
PE
1083 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1084
5235bd3e
PE
1085 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1086 Before, the code was not consistent. These values cannot exceed
1087 2**31 - 1 so there's no need to make them unsigned.
1088 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1089 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1090 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1091 as modifiers.
1092 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1093
bc827e23
PE
1094 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1095 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1096 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1097 presumably because the widths might not match.
1098
78eb494e
PE
1099 * window.c (size_window): Avoid needless test at loop start.
1100
04f2d78b
CB
11012011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1102
1103 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1104
d2fc7e3d 11052011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1106
1107 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1108
d2fc7e3d 11092011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1110
1111 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1112 `width' to `bar_area_x' and `bar_area_width', respectively.
1113 (x_scroll_run): Take account of fringe background extension.
1114
04f2d78b
CB
1115 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1116 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1117 `bar_area_width', respectively.
1118 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1119 background extension.
1120
79b70037
GM
11212011-05-10 Jim Meyering <meyering@redhat.com>
1122
1123 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1124
2f142cc5
JB
11252011-05-10 Juanma Barranquero <lekktu@gmail.com>
1126
1127 * image.c (Finit_image_library): Return t for built-in image types,
1128 like pbm and xbm. (Bug#8640)
1129
57679c86
AS
11302011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1131
1132 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1133
888c9e86
EZ
11342011-05-07 Eli Zaretskii <eliz@gnu.org>
1135
b0512a1d
EZ
1136 * w32console.c (Fset_screen_color): Doc fix.
1137 (Fget_screen_color): New function.
1138 (syms_of_ntterm): Defsubr it.
1139
7285dc67
EZ
1140 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1141 unlink the temporary file if Fcall_process didn't create it in the
1142 first place.
1143 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1144 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1145 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1146 cue to call_process_cleanup not to close that handle.
1147
4d3fcc8e
BK
11482011-05-07 Ben Key <bkey76@gmail.com>
1149
1150 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1151 one of two shell specific rules, either bootstrap-temacs-CMD or
1152 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1153 to the previous implementation of the bootstrap-temacs rule.
1154 The bootstrap-temacs-CMD rule is similar to the previous
1155 implementation of the bootstrap-temacs rule except that it
1156 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1157 variable.
1158
1159 These changes, along with some changes to nt/configure.bat,
1160 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1161 earlier fix to add support for --cflags and --ldflags options
1162 that include quotes so that it works whether make uses cmd or
1163 sh as the shell.
1164
b4289b64
MA
11652011-05-06 Michael Albinus <michael.albinus@gmx.de>
1166
1167 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1168 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1169 is a constant.
1170 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1171 a string. Handle both cases.
1172 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1173 (Fdbus_register_method): Use Qinvalid_function.
1174
af4c0e28
JB
11752011-05-06 Juanma Barranquero <lekktu@gmail.com>
1176
1177 * makefile.w32-in: Update dependencies.
1178 (LISP_H): Add inttypes.h and stdin.h.
1179 (PROCESS_H): Add unistd.h.
1180
c51453d9
EZ
11812011-05-06 Eli Zaretskii <eliz@gnu.org>
1182
1183 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1184 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1185
8ff0ac3c 11862011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1187
4c4b566b
PE
1188 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1189
aab2b9b5
PE
1190 * term.c (vfatal): Remove stray call to va_end.
1191 It's not needed and the C Standard doesn't allow it here anyway.
1192
c378da0b
PE
1193 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1194 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1195
288b08c7
PE
1196 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1197 bytes.
1198
e3601888
PE
1199 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1200
db6c0e74
PE
1201 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1202
dd5963ea
PE
1203 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1204
88c9450f
PE
1205 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1206
2f9442b8
PE
1207 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1208
c032b5f8
PE
1209 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1210 * charset.c (Fdefine_charset_internal): Don't initialize
1211 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1212 32-bit int (Bug#8600).
a108c10b
PE
1213
1214 * lread.c (read_integer): Be more consistent with string-to-number.
1215 Use string_to_number to do the actual conversion; this avoids
1216 rounding errors and fixes some other screwups. Without this fix,
1217 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1218 (digit_to_number): Move earlier, for benefit of read_integer.
1219 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1220 not a digit in any supported base. (Bug#8602)
a108c10b 1221
ad5f9eea
PE
1222 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1223
aec1708a
PE
1224 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1225 to match comment at start of function. This also removes a
1226 GCC warning about overflow in a 32+64-bit port.
1227
47be4ab5
PE
1228 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1229
371cac43
PE
1230 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1231 Reported by Stefan Monnier in
1232 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1233 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1234 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1235
d01a7826
PE
1236 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1237 (EMACS_UINTPTR): Likewise, with uintptr_t.
1238
7fd47d5c
PE
1239 * lisp.h: Prefer 64-bit EMACS_INT if available.
1240 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1241 on 32-bit hosts that have 64-bit int, so that they can access
1242 large files.
122b0c86
PE
1243 However, temporarily disable this change unless the temporary
1244 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1245
8727937b
PE
1246 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1247
8ac068ac
PE
1248 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1249 This removes an assumption that EMACS_INT and long are the same
1250 width as pointers. The assumption is true for Emacs porting targets
1251 now, but we want to make other targets possible.
1252 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1253 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1254 In the rest of the code, change types of integers that hold casted
1255 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1256 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1257 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1258 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1259 No need to cast type when ORing.
1260 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1261 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1262 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1263 assume EMACS_INT is the same width as char *.
1264 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1265 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1266 Remove no-longer-needed casts.
1267 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1268 (xg_tool_bar_help_callback, xg_make_tool_item):
1269 Use EMACS_INTPTR to hold an integer
1270 that will be cast to void *; this can avoid a GCC warning
1271 if EMACS_INT is not the same width as void *.
1272 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1273 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1274 (current_message_1, set_message_1):
1275 Use a local to convert to proper width without a cast.
1276 * xmenu.c (dialog_selection_callback): Likewise.
1277
ede49d71
PE
1278 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1279 Also, don't assume VALBITS / RAND_BITS is less than 5,
1280 and don't rely on undefined behavior when shifting a 1 left into
1281 the sign bit.
1282 * lisp.h (get_random): Change signature to match.
1283
2f30ecd0
PE
1284 * lread.c (hash_string): Use size_t, not int, for hash computation.
1285 Normally we prefer signed values; but hashing is special, because
1286 it's better to use unsigned division on hash table sizes so that
1287 the remainder is nonnegative. Also, size_t is the natural width
1288 for hashing into memory. The previous code used 'int', which doesn't
1289 retain enough info to hash well into very large tables.
1290 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1291
2a866e7b
PE
1292 * dbusbind.c: Don't possibly lose pointer info when converting.
1293 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1294 Use XPNTR rather than XHASH, so that the high-order bits of
1295 the pointer aren't lost when converting through void *.
1296
51639eac
PE
1297 * eval.c (Fautoload): Don't double-shift a pointer.
1298
92394119
PE
1299 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1300
dbdb9a7c
JB
13012011-05-06 Juanma Barranquero <lekktu@gmail.com>
1302
1303 * gnutls.c (DEF_GNUTLS_FN):
1304 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1305
db7a0b4f
AS
13062011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1307
1308 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1309 marker. (Bug#8610)
1310
f7ff1b0f 13112011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1312
1313 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1314 New version that can reserve upto 2GB of heap space.
1315
f7ff1b0f 13162011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1317
1318 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1319
639c109b
TZ
13202011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1321
1322 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1323 `gnutls_certificate_set_x509_key_file'.
1324
d2127135
JB
13252011-05-05 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1328 Update dependencies.
1329
e968f4f3
JB
13302011-05-04 Juanma Barranquero <lekktu@gmail.com>
1331
1332 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1333 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1334 Remove unused parameter `fildes'.
1335 * process.c (read_process_output, send_process): Don't pass it.
1336
84d358f0
JB
13372011-05-04 Juanma Barranquero <lekktu@gmail.com>
1338
1339 Fix previous change: the library cache is defined in w32.c.
1340 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1341 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1342
0898ca10
JB
13432011-05-04 Juanma Barranquero <lekktu@gmail.com>
1344
1345 Implement dynamic loading of GnuTLS on Windows.
1346
1347 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1348 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1349 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1350 Declare.
1351
1352 * gnutls.c (Qgnutls_dll): Define.
1353 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1354 (gnutls_*): Declare function pointers.
1355 (init_gnutls_functions): New function to initialize function pointers.
1356 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1357 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1358 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1359 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1360 (emacs_gnutls_write, emacs_gnutls_read)
1361 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1362 (Fgnutls_available_p): New function.
1363 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1364 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1365 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1366
1367 * image.c: Include w32.h.
1368 (Vimage_type_cache): Delete.
1369 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1370 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1371 (w32_delayed_load): Move to w32.c.
1372
1373 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1374
1375 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1376 (w32_delayed_load): Move from image.c. When loading a library, record
1377 its filename in the :loaded-from property of the library id.
1378 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1379 Initialize and staticpro them.
1380 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1381
1382 * process.c: Include lisp.h before w32.h, not after.
1383 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1384 instead of gnutls_record_check_pending.
1385
1386 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1387
ff4de4aa
TZ
13882011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1389
1390 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1391 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1392 as passed in.
1393
abe95abb
JD
13942011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1395
1396 * xterm.c (x_set_frame_alpha): Do not set property on anything
1397 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1398
e16e55d4
JB
13992011-05-02 Juanma Barranquero <lekktu@gmail.com>
1400
1401 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1402
bafcf6a5
JB
14032011-05-02 Juanma Barranquero <lekktu@gmail.com>
1404
1405 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1406 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1407 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1408 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1409 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1410 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1411 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1412 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1413 (Qgnutls_bootprop_callbacks_verify): Make static.
1414
e7a6747f
AS
14152011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1416
19ed11ba
AS
1417 * callproc.c: Indentation fixup.
1418
e7a6747f 1419 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1420 (wait_for_termination, interruptible_wait_for_termination):
1421 Move after wait_for_termination_1.
e7a6747f 1422
1ef14cb4
LMI
14232011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1424
1425 * sysdep.c (interruptible_wait_for_termination): New function
1426 which is like wait_for_termination, but allows keyboard
1427 interruptions.
1428
1429 * callproc.c (Fcall_process): Add (:file "file") as an option for
1430 the STDOUT buffer.
1431 (Fcall_process_region): Ditto.
1432
330d880c
EZ
14332011-04-30 Eli Zaretskii <eliz@gnu.org>
1434
8db90b73
EZ
1435 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1436 rather than `XVECTOR (FOO)->size'.
1437
330d880c
EZ
1438 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1439 inttypes.h, as a gnulib replacement is used if it not available in
1440 system headers.
1441
15cbd324
EZ
14422011-04-21 Eli Zaretskii <eliz@gnu.org>
1443
1444 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1445 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1446 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1447
1448 * coding.c (coding_alloc_by_realloc): Error out if destination
1449 will grow beyond MOST_POSITIVE_FIXNUM.
1450 (decode_coding_emacs_mule): Abort if there isn't enough place in
1451 charbuf for the composition carryover bytes. Reserve an extra
1452 space for up to 2 characters produced in a loop.
1453 (decode_coding_iso_2022): Abort if there isn't enough place in
1454 charbuf for the composition carryover bytes.
1455
14562011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1457
ae940cca
EZ
1458 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1459 aborting when %lld or %lll format is passed.
1460 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1461 %llo or %llx format is passed. (Bug#8545)
1462
03ab8921
EZ
1463 * window.c (window_scroll_line_based): Use a marker instead of
1464 simple variables to record original value of point. (Bug#7952)
1465
afda1437
EZ
1466 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1467 produced by %s or %c overflows available buffer space. (Bug#8545)
1468
f76dee0c
PE
14692011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1472 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1473
fdc5744d
JB
14742011-04-28 Juanma Barranquero <lekktu@gmail.com>
1475
1476 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1477
638f053a
JB
14782011-04-28 Juanma Barranquero <lekktu@gmail.com>
1479
1480 * keyboard.c (Qdelayed_warnings_hook): Define.
1481 (command_loop_1): Run `delayed-warnings-hook'
1482 if Vdelayed_warnings_list is non-nil.
1483 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1484 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1485
d178f871
EZ
14862011-04-28 Eli Zaretskii <eliz@gnu.org>
1487
1488 * doprnt.c (doprnt): Don't return value smaller than the buffer
1489 size if the message was truncated. (Bug#8545).
1490
b124fd93
JB
14912011-04-28 Juanma Barranquero <lekktu@gmail.com>
1492
1493 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1494 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1495
e810457d
PE
14962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1499
ea51cceb
JB
15002011-04-27 Juanma Barranquero <lekktu@gmail.com>
1501
1502 * makefile.w32-in: Update dependencies.
1503
94dcfacf
EZ
15042011-04-27 Eli Zaretskii <eliz@gnu.org>
1505
1506 Improve `doprnt' and its usage. (Bug#8545)
1507 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1508 `format_end'. Remove support for %l as a conversion specifier.
1509 Don't use xrealloc. Improve diagnostics when the %l size modifier
1510 is used. Update the commentary.
1511
1512 * eval.c (verror): Simplify calculation of size_t.
1513
1514 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1515 messages.
1516
f61f41d7
PE
15172011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1518
1519 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1520 change.
1521
96fb4434
PE
15222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1525 This makes this file independent of the recent pseudovector change.
1526
671875da 15272011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1528
69e9b5a3
PE
1529 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1530
b5f869a7 1531 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1532 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1533 Remove unused local.
c8926152 1534 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1535
841a1577 1536 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1537 GCC 4.6.0 optimizes based on type-based alias analysis.
1538 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1539 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1540 != &v->size, and therefore "v->size = 1; b->size = 2; return
1541 v->size;" must therefore return 1. This assumption is incorrect
1542 for Emacs, since it type-puns struct Lisp_Vector * with many other
1543 types. To fix this problem, this patch adds a new type struct
f904488f 1544 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1545 and pseudovectors, and helps optimizing compilers not get fooled
1546 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1547 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1548 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1549 the size member.
eab3844f
PE
1550 (XSETPVECTYPE): Rewrite in terms of new macro.
1551 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1552 This is a bit clearer, and further avoids the possibility of
1553 undesirable aliasing.
1554 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1555 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1556 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1557 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1558 (ASIZE): Now uses header.size rather than size.
1559 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1560 to avoid the hassle of writing XVECTOR (foo)->header.size.
1561 (struct vectorlike_header): New type.
eab3844f
PE
1562 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1563 object, to help avoid aliasing.
1564 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1565 (SUBRP): Likewise, since Lisp_Subr is a special case.
1566 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1567 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1568 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1569 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1570 changed to be "header.size" and "header.next".
1571 * buffer.h (struct buffer): Likewise.
1572 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1573 * frame.h (struct frame): Likewise.
1574 * process.h (struct Lisp_Process): Likewise.
1575 * termhooks.h (struct terminal): Likewise.
1576 * window.c (struct save_window_data, struct saved_window): Likewise.
1577 * window.h (struct window): Likewise.
1578 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1579 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1580 * buffer.c (init_buffer_once): Likewise.
1581 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1582 special case.
1583 * process.c (Fformat_network_address): Use local var for size,
1584 for brevity.
1585
0df1eac5
PE
1586 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1587
847ab9d1 1588 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1589 * data.c (atof): Remove decl; no longer used or needed.
1590 (digit_to_number): Move to lread.c.
1591 (Fstring_to_number): Use new string_to_number function, to be
1592 consistent with how the Lisp reader treats infinities and NaNs.
1593 Do not assume that floating-point numbers represent EMACS_INT
1594 without losing information; this is not true on most 64-bit hosts.
1595 Avoid double-rounding errors, by insisting on integers when
1596 parsing non-base-10 numbers, as the documentation specifies.
1597 * lisp.h (string_to_number): New decl, replacing ...
1598 (isfloat_string): Remove.
bc0a5c13 1599 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1600 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1601 appears to have been a coding error. Similarly, do not accept
1602 strings like +-1e0 as floating point numbers. Do not report
1603 overflow for integer overflows unless the base is not 10 which
1604 means we have no simple and reliable way to continue.
1605 Break out the floating-point parsing into a new
1606 function string_to_number, so that Fstring_to_number parses
1607 floating point numbers consistently with the Lisp reader.
04f2d78b 1608 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1609 (E_CHAR, EXP_INT): Remove, replacing with ...
1610 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1611 (string_to_number): New function, replacing isfloat_string.
1612 This function checks for valid syntax and produces the resulting
1613 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1614 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1615 so that overflow for non-base-10 numbers is reported only when
1616 there's no portable and simple way to convert to floating point.
452f4150 1617
67769ffc
PE
1618 * textprop.c (set_text_properties_1): Rewrite for clarity,
1619 and to avoid GCC warning about integer overflow.
1620
c20db43f
PE
1621 * intervals.h (struct interval): Use EMACS_INT for members
1622 where EMACS_UINT might cause problems. See
1623 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1624 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1625 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1626 All uses changed.
37aa2f85
PE
1627 (offset_intervals): Tell GCC not to worry about length overflow
1628 when negating a negative length.
c20db43f 1629
2538aa2f
PE
1630 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1631 (overrun_check_free): Likewise.
1632
f2d3008d
PE
1633 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1634 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1635 word size.
1636
ec8df744
PE
1637 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1638 (gnutls_make_error): Rename local to avoid shadowing.
1639 (gnutls_emacs_global_deinit): ifdef out; not used.
1640 (Fgnutls_boot): Use const for pointer to readonly storage.
1641 Comment out unused local. Fix pointer signedness problems.
1642
640ee02d
PE
1643 * lread.c (openp): Don't stuff size_t into an 'int'.
1644 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1645 about possible signed overflow.
1646
6048fb2a
PE
1647 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1648 (GDK_KEY_g): Don't define if already defined.
1649 (xg_prepare_tooltip): Avoid pointer signedness problem.
1650 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1651
fa3c87e1
PE
1652 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1653 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1654
2172544b
PE
1655 * xfns.c (Fx_window_property): Simplify a bit,
1656 to make a bit faster and to avoid GCC 4.6.0 warning.
1657 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1658
9b821a21
PE
1659 * fns.c (internal_equal): Don't assume size_t fits in int.
1660
3c616cfa
PE
1661 * alloc.c (compact_small_strings): Tighten assertion a little.
1662
c2982e87
PE
1663 Replace pEd with more-general pI, and fix some printf arg casts.
1664 * lisp.h (pI): New macro, generalizing old pEd macro to other
1665 conversion specifiers. For example, use "...%"pI"d..." rather
1666 than "...%"pEd"...".
1667 (pEd): Remove. All uses replaced with similar uses of pI.
1668 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1669 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1670 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1671 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1672 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1673 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1674 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1675 64-bit hosts.
1676 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1677 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1678 * print.c (safe_debug_print, print_object): Likewise.
1679 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1680 to int.
6f04d126
PE
1681 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1682 avoiding the 0 flag, which is not portable.
c2982e87
PE
1683 * process.c (Fmake_network_process): Use pI to avoid cast.
1684 * region-cache.c (pp_cache): Likewise.
1685 * xdisp.c (decode_mode_spec): Likewise.
1686 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1687 behavior on 64-bit hosts with printf arg.
6f04d126 1688 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1689 (x_stop_queuing_selection_requests): Likewise.
1690 (x_get_window_property): Don't truncate byte count to an 'int'
1691 when tracing.
0b432f21 1692
5e073ec7
PE
1693 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1694 here, since it parses constructs like leading '-' and spaces,
1695 which are not wanted; and it overflows with large numbers.
1696 Instead, simply match F[0-9]+, which is what is wanted anyway.
1697
36372bf9
PE
1698 * alloc.c: Remove unportable assumptions about struct layout.
1699 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1700 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1701 (allocate_vectorlike, make_pure_vector): Use the new macros,
1702 plus offsetof, to remove unportable assumptions about struct layout.
1703 These assumptions hold on all porting targets that I know of, but
1704 they are not guaranteed, they're easy to remove, and removing them
1705 makes further changes easier.
1706
0b432f21
PE
1707 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1708 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1709 (string_overrun_cookie): Now const. Use initializers that
1710 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1711 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1712 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1713 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1714 multiple of sizeof (EMACS_INT); it need not be, if
1715 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1716 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1717
895009e1
JB
17182011-04-26 Juanma Barranquero <lekktu@gmail.com>
1719
1720 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1721
6a7a1b0b
TZ
17222011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1723
1724 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1725 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1726 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1727
841a1577 17282011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1729
1730 * lisp.h (Qdebug): List symbol.
895009e1 1731 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1732 * keyboard.c (debug-on-event): New variable.
1733 (handle_user_signal): Break into debugger when debug-on-event
1734 matches the current signal symbol.
1735
f2d3ba6f
DN
17362011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1737
1738 * alloc.c (check_sblock, check_string_bytes)
1739 (check_string_free_list): Convert to standard C.
1740
42ce4c63
TZ
17412011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1742
1743 * w32.c (emacs_gnutls_push): Fix typo.
1744
825cd63c
EZ
17452011-04-25 Eli Zaretskii <eliz@gnu.org>
1746
fb11d64d
EZ
1747 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1748 "cast to pointer from integer of different size".
1749
825cd63c
EZ
1750 Improve doprnt and its use in verror. (Bug#8545)
1751 * doprnt.c (doprnt): Document the set of format control sequences
1752 supported by the function. Use SAFE_ALLOCA instead of always
1753 using `alloca'.
1754
1755 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1756 is one byte too soon. Don't use xrealloc; instead xfree and
1757 xmalloc anew.
1758
e061a11b
TZ
17592011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1760
1761 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1762 callbacks stage.
1763
1764 * gnutls.c: Renamed global_initialized to
1765 gnutls_global_initialized. Added internals for the
1766 :verify-hostname-error, :verify-error, and :verify-flags
1767 parameters of `gnutls-boot' and documented those parameters in the
1768 docstring. Start callback support.
1769 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1770 unless a fatal error occured. Call gnutls_alert_send_appropriate
1771 on error. Return error code.
1772 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1773 (emacs_gnutls_read): Likewise.
1774 (Fgnutls_boot): Return handshake error code.
1775 (emacs_gnutls_handle_error): New function.
1776 (wsaerror_to_errno): Likewise.
1777
1778 * w32.h (emacs_gnutls_pull): Add prototype.
1779 (emacs_gnutls_push): Likewise.
1780
1781 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1782 (emacs_gnutls_push): Likewise.
1783
17842011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1785
1786 * process.c (wait_reading_process_output): Check if GnuTLS
1787 buffered some data internally if no FDs are set for TLS
1788 connections.
1789
1790 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1791 (LIBS): Link to USER_LIBS.
1792 ($(BLD)/gnutls.$(0)): New target.
1793
fa6996bc
EZ
17942011-04-24 Eli Zaretskii <eliz@gnu.org>
1795
eb35682e
EZ
1796 * xdisp.c (handle_single_display_spec): Rename the
1797 display_replaced_before_p argument into display_replaced_p, to
1798 make it consistent with the commentary. Fix typos in the
1799 commentary.
1800
e2ad650c
EZ
1801 * textprop.c (syms_of_textprop): Remove dead code.
1802 (copy_text_properties): Delete obsolete commentary about an
1803 interface that was deleted long ago. Fix typos in the description
1804 of arguments.
1805
1b2de274
EZ
1806 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1807 to changes in oldXMenu/XMenu.h from 2011-04-16.
1808 <menu_help_message, prev_menu_help_message>: Constify.
1809 (IT_menu_make_room): menu->help_text is now `const char **';
1810 adjust.
1811
1812 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1813 to changes in oldXMenu/XMenu.h from 2011-04-16.
1814 (struct XMenu): Declare `help_text' `const char **'.
1815
1816 * xfaces.c <Qunspecified>: Make extern again.
1817
1818 * syntax.c: Include sys/types.h before including regex.h, as
1819 required by Posix.
1820
762b15be
EZ
1821 * doc.c (get_doc_string): Improve the format passed to `error'.
1822
1823 * doprnt.c (doprnt): Improve commentary.
1824
1825 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1826
1827 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1828 them with etags.
1829
f1052e5d
EZ
1830 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1831 changes in globals.h immediately force recompilation.
762b15be
EZ
1832 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1833 $(CURDIR)/s/ms-w32.h.
1834 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1835
fa6996bc
EZ
1836 * character.c (Fchar_direction): Function deleted.
1837 (syms_of_character): Don't defsubr it.
1838 <char-direction-table>: Deleted.
1839
e6c3da20
EZ
18402011-04-23 Eli Zaretskii <eliz@gnu.org>
1841
1842 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1843 * doprnt.c: Include limits.h.
1844 (SIZE_MAX): New macro.
04f2d78b
CB
1845 (doprnt): Return a size_t value. 2nd arg is now size_t.
1846 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1847 Improve overflow protection. Support `l' modifier for integer
1848 conversions. Support %l conversion. Don't assume an EMACS_INT
1849 argument for integer conversions and for %c.
1850
1851 * lisp.h (doprnt): Restore prototype.
1852
1853 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1854 $(SRC)/character.h.
1855
1856 * Makefile.in (base_obj): Add back doprnt.o.
1857
1858 * deps.mk (doprnt.o): Add back prerequisites.
1859 (callint.o): Depend on character.h.
1860
1861 * eval.c (internal_lisp_condition_case): Include the handler
1862 representation in the error message.
1863 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1864 when breaking from the loop.
1865
1866 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1867
1868 * callint.c (Fcall_interactively): When displaying error message
1869 about invalid control letter, pass the character's codepoint, not
1870 a pointer to its multibyte form. Improve display of the character
1871 in octal and display also its hex code.
1872
1873 * character.c (char_string): Use %x to display the (unsigned)
1874 codepoint of an invalid character, to avoid displaying a bogus
1875 negative value.
1876
1877 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1878 `error', not SYMBOL_NAME itself.
1879
1880 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1881 character arguments to `error'.
1882
1883 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1884 to `error' in error message about FINAL_CHAR argument. Make sure
1885 FINAL_CHAR is a character, and use %c when it is passed as
1886 argument to `error'.
1887
4ffd0d6b 18882011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1889
1890 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1891
1892 * w32.c: Include <time.h>.
1893 (sys_localtime): New function.
1894
4ffd0d6b 18952011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1896
1897 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1898
4ffd0d6b 1899 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1900
4ffd0d6b 19012011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1902
4ffd0d6b
GM
1903 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1904 zombies (Bug#8467).
aac0c6e3 1905
04c56954
EZ
19062011-04-19 Eli Zaretskii <eliz@gnu.org>
1907
1908 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1909 gl_state.e_property when gl_state.object is Qt.
1910
1911 * insdel.c (make_gap_larger): Remove limitation of buffer size
1912 to <= INT_MAX.
1913
16a43933
CY
19142011-04-18 Chong Yidong <cyd@stupidchicken.com>
1915
1916 * xdisp.c (lookup_glyphless_char_display)
1917 (produce_glyphless_glyph): Handle cons cell entry in
1918 glyphless-char-display.
1919 (Vglyphless_char_display): Document it.
1920
1921 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1922 glyphless-char-display.
1923
4581706e
CY
19242011-04-17 Chong Yidong <cyd@stupidchicken.com>
1925
1926 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1927
1928 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1929
1930 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1931 definition for no-X builds.
1932
4887c6e2 19332011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1934
fd35b6f9
PE
1935 Static checks with GCC 4.6.0 and non-default toolkits.
1936
5c1ccb01
PE
1937 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1938
006c5daa
PE
1939 * process.c (keyboard_bit_set): Define only if SIGIO.
1940 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1941 (send_process): Repair possible setjmp clobbering.
1942
efc736d3
PE
1943 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1944
4e2fe2e6
PE
1945 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1946
f97334a2
PE
1947 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1948
4e75f29d
PE
1949 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1950 Define only if needed.
1951
90efadd1
PE
1952 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1953 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1954 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1955
3c647824
PE
1956 * dispextern.h (struct redisplay_interface): Rename param
1957 to avoid shadowing.
e264f262 1958 * termhooks.h (struct terminal): Likewise.
761383f4 1959 * xterm.c (xembed_send_message): Likewise.
3c647824 1960
b58c5c4a
PE
1961 * insdel.c (make_gap_smaller): Define only if
1962 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1963
cad59032
PE
1964 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1965 it.
1966
c339dc2e
PE
1967 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1968 so that we aren't warned about unused symbols.
1969
91a3e27b
PE
1970 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1971
399c71d3 1972 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1973
8ffc96f5
PE
1974 * xfns.c (x_real_positions): Mark locals as initialized.
1975
eef9bc79
PE
1976 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1977
098db9dd
PE
1978 * xterm.c: Fix problems found by static analysis with other toolkits.
1979 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1980 (x_dispatch_event): Declare static if USE_GTK, and
1981 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1982 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1983 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1984 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1985 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1986
eb18f6cc
PE
1987 * xmenu.c (menu_help_callback): Pointer type fixes.
1988 Use const pointers when pointing at readonly data. Avoid pointer
1989 signedness clashes.
1990 (FALSE): Remove unused macro.
1991 (update_frame_menubar): Remove unused decl.
1992
1fe72bf8
PE
1993 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1994
60d9e1db
PE
1995 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1996 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1997 (single_menu_item): Rename local to avoid shadowing.
1998
39261c26
PE
1999 * keyboard.c (make_lispy_event): Remove unused local var.
2000
018c5e19
PE
2001 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2002 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2003
63d2b86e
PE
2004 * bitmaps: Change bitmaps from unsigned char back to the X11
2005 compatible char. Avoid the old compiler warnings about
2006 out-of-range initializers by using, for example, '\xab' rather
2007 than 0xab.
2008
aefd87e1
PE
2009 * xgselect.c (xgselect_initialize): Check vs interface
2010 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2011
bf501fb9
PE
2012 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2013
e9829fdf
PE
2014 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2015 to read-only memory.
2016
1086c095
PE
2017 * fns.c (vector): Remove; this old hack is no longer needed.
2018
2baccd04 2019 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2020 Remove unused var.
dde42981 2021 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2022
72391843 2023 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2024
436c16df 2025 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2026 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2027 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2028
92bb796d 2029 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2030 (x_term_init): Remove local to avoid shadowing.
92bb796d 2031
764430a3 2032 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2033
2034 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2035 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2036
d1dfb56c
EZ
20372011-04-16 Eli Zaretskii <eliz@gnu.org>
2038
c4354cb4
EZ
2039 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2040
d1dfb56c
EZ
2041 Fix regex.c, syntax.c and friends for buffers > 2GB.
2042 * syntax.h (struct gl_state_s): Declare character position members
2043 EMACS_INT.
2044
2045 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2046
04f2d78b
CB
2047 * textprop.c (verify_interval_modification, interval_of):
2048 Declare arguments EMACS_INT.
d1dfb56c
EZ
2049
2050 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2051 EMACS_INT.
2052
2053 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2054
2055 * indent.c (Fvertical_motion): Local variable it_start is now
2056 EMACS_INT.
2057
2058 * regex.c (re_match, re_match_2, re_match_2_internal)
2059 (bcmp_translate, regcomp, regexec, print_double_string)
2060 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2061 (re_compile_pattern, re_exec): Declare arguments and local
2062 variables `size_t' and `ssize_t' and return values `regoff_t', as
2063 appropriate.
2064 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2065 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2066 <compile_stack_type>: `size' and `avail' are now `size_t'.
2067
2068 * regex.h <regoff_t>: Use ssize_t, not int.
2069 (re_search, re_search_2, re_match, re_match_2): Arguments that
2070 specify buffer/string position and length are now ssize_t and
2071 size_t. Return type is regoff_t.
2072
613052cd
BK
20732011-04-16 Ben Key <bkey76@gmail.com>
2074
2075 * nsfont.m: Fixed bugs in ns_get_family and
2076 ns_descriptor_to_entity that were caused by using free to
2077 deallocate memory blocks that were allocated by xmalloc (via
2078 xstrdup). This caused Emacs to crash when compiled with
2079 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2080 --enable-checking=xmallocoverrun). xfree is now used to
2081 deallocate these memory blocks.
2082
4170f62f 20832011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2084
71b41406
PE
2085 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2086
9587a89d
PE
2087 emacs_write: Accept and return EMACS_INT for sizes.
2088 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2089 et seq.
2090 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2091 Accept and return EMACS_INT.
2092 (emacs_gnutls_write): Return the number of bytes written on
2093 partial writes.
2094 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2095 (emacs_read, emacs_write): Remove check for negative size, as the
2096 Emacs source code has been audited now.
9587a89d
PE
2097 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2098 (emacs_read, emacs_write): Use it.
273a5f82
PE
2099 * process.c (send_process): Adjust to the new signatures of
2100 emacs_write and emacs_gnutls_write. Do not attempt to store
2101 a byte offset into an 'int'; it might overflow.
9587a89d 2102 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2103
3e047f51
PE
2104 * sound.c: Don't assume sizes fit in 'int'.
2105 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2106 Return EMACS_INT, not int.
3e047f51 2107 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2108 Accept EMACS_INT, not int.
2109 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2110 record read return values.
2111
cc39a9db
BK
21122011-04-15 Ben Key <bkey76@gmail.com>
2113
c9d0ec6d
JB
2114 * keyboard.c (Qundefined): Don't declare static since it is used
2115 in nsfns.m.
2116 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2117 static since they are used in nsfont.m.
cc39a9db 2118
6c60eb9f
SM
21192011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2120
2121 * process.c (Qprocessp): Don't declare static.
2122 * lisp.h (Qprocessp): Declare again.
2123
7990b61a
JB
21242011-04-15 Juanma Barranquero <lekktu@gmail.com>
2125
2126 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2127
5d4cb038
PE
21282011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2129
8bd7b830 2130 Improve C-level modularity by making more things 'static'.
cd64ea1d 2131
e3b27b31
PE
2132 Don't publish debugger-only interfaces to other modules.
2133 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2134 (verify_bytepos, count_markers): Move decls to the only modules
2135 that need them.
2136 * region-cache.h (pp_cache): Likewise.
2137 * window.h (check_all_windows): Likewise.
2138 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2139
5d4cb038
PE
2140 * sysdep.c (croak): Now static, if
2141 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2142 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2143
2144 * alloc.c (refill_memory_reserve): Now static if
2145 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2146 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2147
e87b6180
PE
2148 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2149 Define only if USE_LUCID.
2150
ac64929e
PE
2151 * xrdb.c (x_customization_string, x_rm_string): Now static.
2152
6f37259d
PE
2153 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2154 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2155
1683e3ab
PE
2156 * xdisp.c (draw_row_with_mouse_face): Now static.
2157 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2158
de9c2632
PE
2159 * window.h (check_all_windows): Mark externally visible.
2160
2b96acb7
PE
2161 * window.c (window_deletion_count): Now static.
2162
2163 * undo.c: Make symbols static if they're not exported.
2164 (last_undo_buffer, last_boundary_position, pending_boundary):
2165 Now static.
2166
50436f33
PE
2167 * textprop.c (interval_insert_behind_hooks): Now static.
2168 (interval_insert_in_front_hooks): Likewise.
2169
64520e5c
PE
2170 * term.c: Make symbols static if they're not exported.
2171 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2172 (max_frame_lines, tty_set_terminal_modes):
2173 (tty_reset_terminal_modes, tty_turn_off_highlight):
2174 (get_tty_terminal): Now static.
2175 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2176 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2177 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2178 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2179 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2180
1fa53021
PE
2181 * sysdep.c: Make symbols static if they're not exported.
2182 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2183 Now static.
2184 (sigprocmask_set, full_mask): Remove; unused.
2185 (wait_debugging): Mark as visible.
2186 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2187 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2188
d4b43b22
PE
2189 * syntax.c (syntax_temp): Define only if !__GNUC__.
2190
b7c513d0
PE
2191 * sound.c (current_sound_device, current_sound): Now static.
2192
989b29ad
PE
2193 * search.c (searchbufs, searchbuf_head): Now static.
2194
13a55a78
PE
2195 * scroll.c (scroll_cost): Remove; unused.
2196 * dispextern.h (scroll_cost): Remove decl.
2197
de68a1fc
PE
2198 * region-cache.h (pp_cache): Mark as externally visible.
2199
40ccffa6
PE
2200 * process.c: Make symbols static if they're not exported.
2201 (process_tick, update_tick, create_process, chan_process):
2202 (Vprocess_alist, proc_buffered_char, datagram_access):
2203 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2204 (deactivate_process): Mark defn as static, as well as decl.
2205 * lisp.h (create_process): Remove decl.
2206 * process.h (chan_process, Vprocess_alist): Remove decls.
2207
ad64fc97
PE
2208 * print.c: Make symbols static if they're not exported.
2209 (print_depth, new_backquote_output, being_printed, print_buffer):
2210 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2211 (print_interval, print_number_index, initial_stderr_stream):
2212 Now static.
2213 * lisp.h (Fprinc): Remove decl.
2214 (debug_output_compilation_hack): Mark as externally visible.
2215
adddb265
PE
2216 * sysdep.c (croak): Move decl from here to syssignal.h.
2217 * syssignal.h (croak): Put it here, so the API can be checked when
2218 'croak' is called from dissociate_if_controlling_tty.
2219
1717ede2
PE
2220 * minibuf.c: Make symbols static if they're not exported.
2221 (minibuf_save_list, choose_minibuf_frame): Now static.
2222 * lisp.h (choose_minibuf_frame): Remove decl.
2223
fa5fb2bc
PE
2224 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2225
1e3890d1
PE
2226 * lread.c: Make symbols static if they're not exported.
2227 (read_objects, initial_obarray, oblookup_last_bucket_number):
2228 Now static.
2229 (make_symbol): Remove; unused.
2230 * lisp.h (initial_obarray, make_symbol): Remove decls.
2231
8a1414fa
PE
2232 * keyboard.c: Make symbols static if they're not exported.
2233 (single_kboard, recent_keys_index, total_keys, recent_keys):
2234 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2235 (this_single_command_key_start, echoing, last_auto_save):
2236 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2237 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2238 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2239 (Vlispy_mouse_stem, double_click_count):
2240 Now static.
2241 (force_auto_save_soon): Define only if SIGDANGER.
2242 (ignore_mouse_drag_p): Now static if
2243 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2244 (print_help): Remove; unused.
2245 (stop_character, last_timer_event): Mark as externally visible.
2246 * keyboard.h (ignore_mouse_drag_p): Declare only if
2247 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2248 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2249 * lisp.h (echoing): Remove decl.
2250 (force_auto_save_soon): Declare only if SIGDANGER.
2251 * xdisp.c (redisplay_window): Simplify code, to make it more
2252 obvious that ignore_mouse_drag_p is not accessed if !defined
2253 USE_GTK && !defined HAVE_NS.
2254
93ea6e8f
PE
2255 * intervals.c: Make symbols static if they're not exported.
2256 (merge_properties_sticky, merge_interval_right, delete_interval):
2257 Now static.
2258 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2259
77382fcc
PE
2260 * insdel.c: Make symbols static if they're not exported.
2261 However, leave prepare_to_modify_buffer alone. It's never
2262 called from outside this function, but that appears to be a bug.
2263 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2264 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2265 (adjust_after_replace_noundo): Remove; unused.
2266 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2267 (signal_before_change): Remove decls.
77382fcc 2268
9306c32e
PE
2269 * indent.c (val_compute_motion, val_vmotion): Now static.
2270
cd44d2eb
PE
2271 * image.c: Make symbols static if they're not exported.
2272 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2273 if USE_GTK.
2274 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2275 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2276
ad9a7a06
PE
2277 * fringe.c (standard_bitmaps): Now static.
2278 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2279
81626931
PE
2280 * frame.c: Make symbols static if they're not exported.
2281 (x_report_frame_params, make_terminal_frame): Now static.
2282 (get_frame_param): Now static, unless HAVE_NS.
2283 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2284 (x_get_resource_string): Remove; not used.
2285 * frame.h (make_terminal_frame, x_report_frame_params):
2286 (x_get_resource_string); Remove decls.
2287 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2288 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2289
239f9db9
PE
2290 * font.c, fontset.c: Make symbols static if they're not exported.
2291 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2292 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2293 * font.c (font_close_object): Now static.
2294 * font.h (font_close_object): Remove.
2295 * fontset.c (FONTSET_OBJLIST): Remove.
2296 (free_realized_fontset) #if-0 the body, which does nothing.
2297 (face_suitable_for_char_p): #if-0, as it's never called.
2298 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2299 * xfaces.c (face_at_string_position):
2300 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2301 since 0 is always ASCII.
2302
dfcf3579
PE
2303 * fns.c (weak_hash_tables): Now static.
2304
5045092b
PE
2305 * fileio.c: Make symbols static if they're not exported.
2306 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2307 (Vwrite_region_annotation_buffers): Now static.
2308
57a96f5c
PE
2309 * eval.c: Make symbols static if they're not exported.
2310 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2311 * lisp.h (backtrace_list): Remove decl.
2312
35f08c38
PE
2313 * emacs.c: Make symbols static if they're not exported.
2314 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2315 (fatal_error_code, fatal_error_signal_hook, standard_args):
2316 Now static.
2317 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2318 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2319 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2320 * lisp.h (fatal_error_signal_hook): Remove decl.
2321 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2322
f44bd759
PE
2323 * editfns.c: Move a (normally-unused) function to its only use.
2324 * editfns.c, lisp.h (get_operating_system_release): Remove.
2325 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2326 worth the hassle of breaking this out.
2327
b532497d
PE
2328 * xterm.c: Make symbols static if they're not exported.
2329 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2330 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2331 (x_destroy_window, x_delete_display):
2332 Now static.
2333 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2334 (x_mouse_leave): Remove; unused.
2335 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2336 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2337 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2338 Remove decls.
2339 (x_mouse_leave): Declare only if WINDOWSNT.
2340 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2341 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2342 USE_X_TOOLKIT.
2343
1675728f
PE
2344 * ftxfont.c: Make symbols static if they're not exported.
2345 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2346 HAVE_FREETYPE.
2347 * font.h (ftxfont_driver): Likewise.
2348
e4cebfca
PE
2349 * xfns.c: Make symbols static if they're not exported.
2350 (x_last_font_name, x_display_info_for_name):
2351 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2352 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2353 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2354 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2355 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2356 (last_show_tip_args): Now static.
2357 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2358 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2359 (x_screen_planes): Remove; unused.
2360 * dispextern.h (x_screen_planes): Remove decl.
2361
5bf46f05
PE
2362 * dispnew.c: Make symbols static if they're not exported.
2363 * dispextern.h (redraw_garbaged_frames, scrolling):
2364 (increment_row_positions): Remove.
2365 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2366 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2367 Now static.
2368 (redraw_garbaged_frames): Remove; unused.
2369
435f4c28
PE
2370 * xfaces.c: Make symbols static if they're not exported.
2371 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2372 Remove decls.
2373 * xterm.h (defined_color): Remove decls.
2374 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2375 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2376 (menu_face_changed_default, defined_color, free_realized_face):
2377 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2378 (ascii_face_of_lisp_face): Remove; unused.
2379
8524aef3
PE
2380 * xdisp.c: Make symbols static if they're not exported.
2381 * dispextern.h (scratch_glyph_row, window_box_edges):
2382 (glyph_to_pixel_coords, set_cursor_from_row):
2383 (get_next_display_element, set_iterator_to_next):
2384 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2385 (show_mouse_face): Remove decls
2386 * frame.h (message_buf_print): Likewise.
2387 * lisp.h (pop_message, set_message, check_point_in_composition):
2388 Likewise.
2389 * xterm.h (set_vertical_scroll_bar): Likewise.
2390 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2391 (message_buf_print, scratch_glyph_row, displayed_buffer):
2392 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2393 (get_next_display_element, show_mouse_face, window_box_edges):
2394 (frame_to_window_pixel_xy, check_point_in_composition):
2395 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2396 (glyph_to_pixel_coords): Remove; unused.
2397
16390cd2
PE
2398 * dired.c (file_name_completion): Now static.
2399
2400 * dbusbind.c (xd_in_read_queued_messages): Now static.
2401
a25f4dfa
PE
2402 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2403 * data.c (circular_list_error): Remove.
2404
14a9c8df
PE
2405 * commands.h (last_point_position, last_point_position_buffer):
2406 (last_point_position_window): Remove decls.
2407 * keyboard.c: Make these variables static.
2408
04f2d78b
CB
2409 * coding.h (coding, code_convert_region, encode_coding_gap):
2410 Remove decls.
74ab6df5
PE
2411 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2412 (iso_code_class, detect_coding, code_convert_region): Now static.
2413 (encode_coding_gap): Remove; unused.
2414
38dfbee1
PE
2415 * chartab.c (chartab_chars, chartab_bits): Now static.
2416
a2cb4e63
PE
2417 * charset.h (charset_iso_8859_1): Remove decl.
2418 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2419 Now static.
2420
127198fd
PE
2421 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2422 * ccl.c (Vccl_program_table): Now static.
2423 (check_ccl_update): Remove; unused.
2424
d85b608f
PE
2425 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2426 * category.h: ... from here.
2427 * category.c (check_category_table, set_category_set): Now static.
2428
31cd66f3
PE
2429 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2430 * lisp.h: Remove these decls.
2431
c358e587
PE
2432 * buffer.c (buffer_count): Remove unused var.
2433
e78aecca
PE
2434 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2435 so that it's not optimized away.
2436 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2437 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2438 exported only to the debugger.
2439
e192d7d3 2440 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2441 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2442
92470028
PE
2443 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2444 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2445 was inaccessible from Lisp.
2446 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2447 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2448
244ed907
PE
2449 alloc.c: Import and export fewer symbols, and remove unused items.
2450 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2451 is defined.
2452 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2453 it's not optimized away by whole-program optimization.
2454 (message_enable_multibyte, free_misc): Remove.
2455 (catchlist, handlerlist, mark_backtrace):
2456 Declare only if BYTE_MARK_STACK.
2457 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2458 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2459 (message_enable_multibyte): Remove decl.
2460 (free_misc, interval_free_list, float_block, float_block_index):
2461 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2462 (cons_free_list, last_marked_index):
2463 Now static.
2464 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2465 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2466 (mark_backtrace): Define only if BYTE_MARK_STACK.
2467 * xdisp.c (message_enable_multibyte): Now static.
2468
61c2b50e 2469 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2470 This makes it easier for human readers (and static analyzers)
2471 to see whether these variables are used from other modules.
2472 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2473 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2474 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2475 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2476 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2477 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2478 * xmenu.c, xselect.c:
2479 Declare Q* vars static if they are not used in other modules.
2480 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2481 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2482 Remove decls of unexported vars.
2483 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2484
95c82688
PE
2485 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2486
16a97296
PE
2487 Make Emacs functions such as Fatom 'static' by default.
2488 This makes it easier for human readers (and static analyzers)
2489 to see whether these functions can be called from other modules.
2490 DEFUN now defines a static function. To make the function external
2491 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2492 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2493 (Finit_image_library):
16a97296
PE
2494 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2495 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2496 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2497 Remove decls, since these functions are now static.
2498 (Funintern, Fget_internal_run_time): New decls, since these functions
2499 were already external.
95c82688 2500
16a97296
PE
2501 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2502 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2503 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2504 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2505 * keyboard.c, keymap.c, lread.c:
2506 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2507 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2508 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2509 Mark functions with DEFUE instead of DEFUN,
2510 if they are used in other modules.
2511 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2512 decls for now-static functions.
2513 * buffer.h (Fdelete_overlay): Remove decl.
2514 * callproc.c (Fgetenv_internal): Mark as internal.
2515 * composite.c (Fremove_list_of_text_properties): Remove decl.
2516 (Fcomposition_get_gstring): New forward static decl.
2517 * composite.h (Fcomposite_get_gstring): Remove decl.
2518 * dired.c (Ffile_attributes): New forward static decl.
2519 * doc.c (Fdocumntation_property): New forward static decl.
2520 * eval.c (Ffetch_bytecode): New forward static decl.
2521 (Funintern): Remove extern decl; now in .h file where it belongs.
2522 * fileio.c (Fmake_symbolic_link): New forward static decl.
2523 * image.c (Finit_image_library): New forward static decl.
2524 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2525 * intervals.h (Fprevious_property_change):
2526 (Fremove_list_of_text_properties): Remove decls.
2527 * keyboard.c (Fthis_command_keys): Remove decl.
2528 (Fcommand_execute): New forward static decl.
2529 * keymap.c (Flookup_key): New forward static decl.
2530 (Fcopy_keymap): Now static.
2531 * keymap.h (Flookup_key): Remove decl.
2532 * process.c (Fget_process): New forward static decl.
2533 (Fprocess_datagram_address): Mark as internal.
2534 * syntax.c (Fsyntax_table_p): New forward static decl.
2535 (skip_chars): Remove duplicate decl.
2536 * textprop.c (Fprevious_property_change): New forward static decl.
2537 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2538 Now internal.
2539 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2540 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2541
785bbd42
PE
2542 * editfns.c (Fformat): Remove unreachable code.
2543
8b913b57
AS
25442011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2545
2546 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2547 change. (Bug#8496)
2548
a6744a35
EZ
25492011-04-13 Eli Zaretskii <eliz@gnu.org>
2550
2551 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2552 when at ZV. (Bug#8487)
2553
e7974947
AS
25542011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2555
baad03f0
AS
2556 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2557 (Bug#8437)
2558 * keyboard.c (parse_tool_bar_item): Likewise.
2559 * sound.c (sound_cleanup, alsa_close): Likewise.
2560 * termcap.c (tgetent): Likewise.
2561 * xfns.c (x_default_font_parameter): Likewise.
2562 * xsettings.c (read_and_apply_settings): Likewise.
2563
e7974947
AS
2564 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2565 (overrun_check_free): Protoize.
2566
28272684
PE
25672011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2570 since callers should never pass a negative size.
2571 Change the signature to match that of plain 'read' and 'write'; see
2572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2573 * lisp.h: Update prototypes of emacs_write and emacs_read.
2574
11997c76
EZ
25752011-04-11 Eli Zaretskii <eliz@gnu.org>
2576
2577 * xdisp.c (redisplay_window): Don't try to determine the character
2578 position of the scroll margin if the window start point w->startp
e896f03c 2579 is outside the buffer's accessible region. (Bug#8468)
11997c76 2580
8a2cbd72
EZ
25812011-04-10 Eli Zaretskii <eliz@gnu.org>
2582
2583 Fix write-region and its subroutines for buffers > 2GB.
2584 * fileio.c (a_write, e_write): Modify declaration of arguments and
2585 local variables to support buffers larger than 2GB.
2586 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2587
2588 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2589 argument, local variables, and return value.
2590
2591 * lisp.h: Update prototypes of emacs_write and emacs_read.
2592
2593 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2594
4073e537 25952011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2596
1ebfdcb6
PE
2597 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2598
b2ded58d
PE
2599 Fix more problems found by GCC 4.6.0's static checks.
2600
7d66342c
PE
2601 * xdisp.c (vmessage): Use a better test for character truncation.
2602
bbf47d44
PE
2603 * charset.c (load_charset_map): <, not <=, for optimization,
2604 and to avoid potential problems with integer overflow.
9248994d 2605 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2606 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2607 * editfns.c (Fformat): Likewise.
1e69125e 2608 * syntax.c (skip_chars): Likewise.
3befa583 2609
e3019616
PE
2610 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2611 This also lets GCC 4.6.0 generate slightly better loop code.
2612
becfa255
PE
2613 * callint.c (Fcall_interactively): <, not <=, for optimization.
2614 (Fcall_interactively): Count the number of arguments produced,
2615 not the number of arguments given. This is simpler and lets GCC
2616 4.6.0 generate slightly better code.
2617
dae0cd48
PE
2618 * ftfont.c: Distingish more carefully between FcChar8 and char.
2619 The previous code passed unsigned char * to a functions like
2620 strlen and xstrcasecmp that expect char *, which does not
2621 conform to the C standard.
2622 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2623 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2624 char * when the C standard requires it.
2625
76032d70
PE
2626 * keyboard.c (read_char): Remove unused var.
2627
eb3f1cc8
PE
2628 * eval.c: Port to Windows vsnprintf (Bug#8435).
2629 Include <limits.h>.
2630 (SIZE_MAX): Define if the headers do not.
2631 (verror): Do not give up if vsnprintf returns a negative count.
2632 Instead, grow the buffer. This ports to Windows vsnprintf, which
2633 does not conform to C99. Problem reported by Eli Zaretskii.
2634 Also, simplify the allocation scheme, by avoiding the need for
2635 calling realloc, and removing the ALLOCATED variable.
2636
70476b54
PE
2637 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2638
12020a9e
PE
2639 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2640 But keep the doprint source code for now, as we might revamp it
2641 and use it again (Bug#8435).
ea6c7ae6
PE
2642 * lisp.h (doprnt): Remove.
2643 * Makefile.in (base_obj): Remove doprnt.o.
2644 * deps.mk (doprnt.o): Remove.
2645
5fdb398c
PE
2646 error: Print 32- and 64-bit integers portably (Bug#8435).
2647 Without this change, on typical 64-bit hosts error ("...%d...", N)
2648 was used to print both 32- and 64-bit integers N, which relied on
2649 undefined behavior.
2650 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2651 New macro.
2652 * lisp.h (error, verror): Mark as printf-like functions.
2653 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2654 Report overflow in size calculations when allocating printf buffer.
2655 Do not truncate output string at its first null byte.
2656 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2657 Truncate the output at a character boundary, since vsnprintf does not
2658 do that.
2659 * charset.c (check_iso_charset_parameter): Convert internal
2660 character to string before calling 'error', since %c now has the
2661 printf meaning.
2662 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2663 overflow when computing char to be passed to 'error'. Do not
2664 pass Lisp_Object to 'error'; pass the integer instead.
2665 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2666 formatted with plain %d.
2667
b189fa66
PE
2668 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2669
bff87ef0
PE
2670 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2671
7e2cac20
PE
2672 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2673
ce4d90b5
PE
2674 * xterm.c (x_catch_errors): Remove duplicate declaration.
2675
266c9547
PE
2676 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2677
79c49ad2
PE
2678 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2679
368f4090
JM
26802011-04-10 Jim Meyering <meyering@redhat.com>
2681
2682 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2683 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2684 return ssize_t not "int", and use size_t as the buffer length.
2685 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2686 * gnutls.h: Update declarations.
2687 * process.c (read_process_output): Use ssize_t, to match.
2688 (send_process): Likewise.
2689
a32d4040
CY
26902011-04-09 Chong Yidong <cyd@stupidchicken.com>
2691
2692 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2693
8546720e 26942011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2695
04f2d78b
CB
2696 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2697 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2698
8546720e
GM
2699 * xterm.c (handle_one_xevent):
2700 * xmenu.c (create_and_show_popup_menu):
2701 * xselect.c (x_decline_selection_request)
2702 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2703
0a2f5c1a 27042011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2705
2706 Fix some uses of `int' instead of EMACS_INT.
2707 * search.c (string_match_1, fast_string_match)
2708 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2709 (scan_buffer, find_next_newline_no_quit)
2710 (find_before_next_newline, search_command, Freplace_match)
2711 (Fmatch_data): Make some `int' variables be EMACS_INT.
2712
2713 * xdisp.c (display_count_lines): 3rd argument and return value now
2714 EMACS_INT. All callers changed.
2715 (pint2hrstr): Last argument is now EMACS_INT.
2716
2717 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2718 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2719 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2720 (decode_coding_utf_16, decode_coding_emacs_mule)
2721 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2722 (decode_coding_ccl, decode_coding_charset)
2723 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2724 (decode_coding_iso_2022, decode_coding_emacs_mule)
2725 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2726 <char_offset, last_offset>: Declare EMACS_INT.
2727 (encode_coding_utf_8, encode_coding_utf_16)
2728 (encode_coding_emacs_mule, encode_invocation_designation)
2729 (encode_designation_at_bol, encode_coding_iso_2022)
2730 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2731 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2732 Declare EMACS_INT.
2733 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2734 (encode_invocation_designation): Last argument P_NCHARS is now
2735 EMACS_INT.
2736 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2737 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2738
2739 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2740 All users changed.
2741
2742 * ccl.c (Fccl_execute_on_string): Declare some variables
2743 EMACS_INT.
2744
8546720e 27452011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2746
2747 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2748
4e19a977
CS
27492011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2750
2751 * process.c (Fformat_network_address): Doc fix.
2752
87302331
R
27532011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2754
2755 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2756
cbb59342
CY
27572011-04-08 Chong Yidong <cyd@stupidchicken.com>
2758
2759 * keyboard.c (read_char): Call Lisp function help-form-show,
2760 instead of using internal_with_output_to_temp_buffer.
2761 (Qhelp_form_show): New var.
e0d38eeb 2762 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2763
2764 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2765
2766 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2767
e67a13ab
CY
27682011-04-06 Chong Yidong <cyd@stupidchicken.com>
2769
04f2d78b
CB
2770 * process.c (Flist_processes): Remove to Lisp.
2771 (list_processes_1): Delete.
e67a13ab 2772
973f782d
EZ
27732011-04-06 Eli Zaretskii <eliz@gnu.org>
2774
7c106b1e
EZ
2775 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2776
973f782d
EZ
2777 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2778
41cf7d1a 27792011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2780
ca23cc88
PE
2781 Fix more problems found by GCC 4.6.0's static checks.
2782
f390e2d5
PE
2783 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2784
42eea0d0
PE
2785 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2786
b69769da 2787 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2788
f9541e84
PE
2789 * xdisp.c (vmessage): Mark as a printf-like function.
2790
13841b55
PE
2791 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2792
c136c10f
PE
2793 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2794
5e2d4a30
PE
2795 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2796 printf-like functions.
2797 (tiff_load): Add casts to remove these marks before passing them
2798 to system-supplied API.
2799
583f48b9
PE
2800 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2801
b25d760e
PE
2802 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2803 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2804 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2805 directly, rather than having caller test rule sign. This avoids
2806 some unnecessary tests.
2807 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2808 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2809 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2810
bc7b6697 2811 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2812 (xfont_open): Avoid unnecessary tests.
bc7b6697 2813
27ccc379
PE
2814 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2815
dcd5c89a
PE
2816 * composite.h, composite.c (composition_gstring_put_cache):
2817 Use EMACS_INT, not int, for length.
2818
b13a45c6
PE
2819 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2820 breaking out part of COMPOSITION_DECODE_RULE.
2821 (COMPOSITION_DECODE_RULE): Use it.
2822 * composite.c (get_composition_id): Remove unused local vars,
2823 by using the new macro.
2824
1e792e4d
PE
2825 * textprop.c (set_text_properties_1): Change while to do-while,
2826 since the condition is always true at first.
2827
dc6c6455 2828 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2829 (interval_deletion_adjustment): Return unsigned value.
2830 All uses changed.
dc6c6455 2831
aba7731a
PE
2832 * process.c (list_processes_1, create_pty, read_process_output):
2833 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2834 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2835 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2836 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2837 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2838
fdfc4bf3
PE
2839 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2840
fca8fe46 2841 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2842 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2843
06a0259a 2844 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2845 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2846 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2847
e7b9e80f
PE
2848 * print.c (print_error_message): Avoid int overflow.
2849
56201685
PE
2850 * font.c (font_list_entities): Redo for clarity,
2851 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2852
78834453 2853 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2854 (font_score): Avoid potential overflow in diff calculation.
78834453 2855
0bc0b309 2856 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2857 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2858
e610eaca
PE
2859 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2860
b895abce
PE
2861 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2862 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2863 can always succeed if overflow has undefined behavior.
2864
1f1d9321 2865 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2866 (wordify): Omit three unnecessary tests.
1f1d9321 2867
c59478bc
PE
2868 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2869 All callers changed. This avoids the need for an unused var.
2870
79b73827
PE
2871 * casefiddle.c (casify_region): Remove var that is set but not used.
2872
a4db5dfe
PE
2873 * dired.c (file_name_completion): Remove var that is set but not used.
2874
43aae36e
PE
2875 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2876
2a47c44d 2877 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2878 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2879
a37c69bf
PE
2880 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2881 Check for integer overflow on size calculations.
2882
328ab8e7
PE
2883 * buffer.c (Fprevious_overlay_change): Remove var that is set
2884 but not used.
2885
e5a2a5cb
PE
2886 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2887 Remove vars that are set but not used.
8d84a6eb 2888 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2889 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2890
a60e5f68
PE
2891 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2892
f661cb61 2893 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2894 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2895
f0397f5a
PE
2896 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2897 that are set but not used.
2898
8664db06 2899 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2900 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2901
6abdaa4a
PE
2902 * xselect.c (x_get_local_selection, x_handle_property_notify):
2903 Remove vars that are set but not used.
2904
0ce7538d 2905 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2906 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2907
9ae848fc
PE
2908 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2909 Remove var that is set but not used.
0b918413
PE
2910 (scroll_bar_windows_size): Now size_t, not int.
2911 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2912 Check for overflow.
9ae848fc 2913
a5a62657
PE
2914 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2915 (map_tty_color) [!defined MSDOS]: Likewise.
2916
5c5cdd39
PE
2917 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2918
66ebf983
PE
2919 * coding.c: Remove vars that are set but not used.
2920 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2921 All callers changed.
2922 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2923 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2924 (decode_coding_charset): Remove vars that are set but not used.
2925
1be4d761
PE
2926 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2927 that is set but not used.
2928
47553fa8
PE
2929 * print.c (print_object): Remove var that is set but not used.
2930
1f7196bf 2931 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2932 The gnulib version avoids calling malloc in the usual case,
2933 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2934 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2935 * filelock.c (current_lock_owner): Likewise.
2936 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2937 * sysdep.c: Include allocator.h, careadlinkat.h.
2938 (emacs_no_realloc_allocator): New static constant.
2939 (emacs_readlink): New function.
fdb61804
PE
2940 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2941 ../lib/careadlinkat.h.
d1fdcab7 2942
f84c17c7
SM
29432011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2944
2945 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2946 first non-nil return value).
2947
ef3862ad
JD
29482011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2949
2950 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2951 if not defined (Bug#8403).
2952
376a7006
JB
29532011-04-02 Juanma Barranquero <lekktu@gmail.com>
2954
2955 * xdisp.c (display_count_lines): Remove parameter `start',
2956 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2957 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2958 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2959 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2960 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2961 and thereabouts. All callers changed.
2962 (get_per_char_metric): Remove parameter `f', unused since
2963 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2964
6ca3801d
JM
29652011-04-02 Jim Meyering <meyering@redhat.com>
2966
2967 do not dereference NULL upon failed strdup
2968 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2969 (ns_get_family): Likewise.
2970
d8e2b5ba
JB
29712011-04-02 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2974
8c74fcbd
JD
29752011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2976
2977 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2978 later (Bug#8403).
2979
7200d79c
SM
29802011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2981
03408648 2982 Add lexical binding.
7200d79c 2983
03408648
SM
2984 * window.c (Ftemp_output_buffer_show): New fun.
2985 (Fsave_window_excursion):
2986 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2987
2988 * lread.c (lisp_file_lexically_bound_p): New function.
2989 (Fload): Bind Qlexical_binding.
2990 (readevalloop): Remove `evalfun' arg.
2991 Bind Qinternal_interpreter_environment.
2992 (Feval_buffer): Bind Qlexical_binding.
2993 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2994 Mark as dynamic.
2995 (syms_of_lread): Declare `lexical-binding'.
2996
2997 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2998
2999 * keyboard.c (eval_dyn): New fun.
3000 (menu_item_eval_property): Use it.
ca105506
SM
3001
3002 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3003
03408648
SM
3004 * fns.c (concat, mapcar1): Accept byte-code-functions.
3005
3006 * eval.c (Fsetq): Handle lexical vars.
3007 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3008 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3009 (FletX, Flet): Obey lexical binding.
3010 (Fcommandp): Handle closures.
3011 (Feval): New `lexical' arg.
3012 (eval_sub): New function extracted from Feval. Use it almost
3013 everywhere where Feval was used. Look up vars in lexical env.
3014 Handle closures.
3015 (Ffunctionp): Move from subr.el.
3016 (Ffuncall): Handle closures.
3017 (apply_lambda): Remove `eval_flags'.
3018 (funcall_lambda): Handle closures and new byte-code-functions.
3019 (Fspecial_variable_p): New function.
3020 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3021 but without exporting it to Lisp.
23aba0ea 3022
23aba0ea 3023 * doc.c (Fdocumentation, store_function_docstring):
03408648 3024 * data.c (Finteractive_form): Handle closures.
23aba0ea 3025
03408648
SM
3026 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3027 interactive spec.
ba83908c 3028
04f2d78b
CB
3029 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3030 New byte-codes.
03408648
SM
3031 (exec_byte_code): New function extracted from Fbyte_code to handle new
3032 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3033
03408648 3034 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3035
03408648 3036 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3037
e2abce01
JB
30382011-03-31 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * xdisp.c (redisplay_internal): Fix prototype.
3041
63696a73 30422011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3043
63696a73 3044 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3045 (try_scrolling): Use it when setting scroll_limit.
3046 Limit scrolling to 100 screen lines.
63696a73
EZ
3047 (redisplay_window): Even when falling back on "recentering",
3048 position point in the window according to scroll-conservatively,
3049 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3050
3051 (try_scrolling): When point is above the window, allow searching
3052 as far as scroll_max, or one screenful, to compute vertical
3053 distance from PT to the scroll margin position. This prevents
3054 try_scrolling from unnecessarily failing when
3055 scroll-conservatively is set to a value slightly larger than the
3056 window height. Clean up the case of PT below the margin at bottom
3057 of window: scroll_max can no longer be INT_MAX. When aggressive
3058 scrolling is in use, don't let point enter the opposite scroll
3059 margin as result of the scroll.
3060 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3061 threshold of 100 lines for never-recentering scrolling.
3062
e4cc2dfc
JB
30632011-03-31 Juanma Barranquero <lekktu@gmail.com>
3064
3065 * dispextern.h (move_it_by_lines):
3066 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3067 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3068 (message_log_check_duplicate): Remove parameters `prev_bol' and
3069 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3070 (redisplay_internal): Remove parameter `preserve_echo_area',
3071 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3072
3073 * indent.c (Fvertical_motion):
3074 * window.c (window_scroll_pixel_based, Frecenter):
3075 Don't pass `need_y_p' to `move_it_by_lines'.
3076
1c470562
SM
30772011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3078
44f230aa
SM
3079 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3080 steal a few bits to be more compact.
3081 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3082 Remove unneeded casts.
3083
1c470562
SM
3084 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3085
888adce9
ZK
30862011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3087
3088 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3089 binding" message (bug#7967).
3090
f838ed7b
PE
30912011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3092
77861b95
PE
3093 Fix more problems found by GCC 4.6.0's static checks.
3094
de6dbc14
PE
3095 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3096 Remove unused local var.
3097
f838ed7b
PE
3098 * editfns.c (Fmessage_box): Remove unused local var.
3099
792c7b2b
PE
3100 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3101 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3102 Omit unused local vars.
c499e557 3103 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3104 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3105 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3106 Omit unused local var.
3107
ba0165e1
PE
3108 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3109 Don't assume string length fits in int.
32ad8845 3110 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3111 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3112
3c59b4c9
PE
3113 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3114 instead of alloca (Bug#8344).
3115
a3eed478 3116 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3117 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3118
eb4d412d
PE
3119 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3120
1658b401
PE
3121 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3122 concerns.
3123
3124 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3125
3126 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3127
9a2c6e05
PE
3128 * keyboard.c (syms_of_keyboard): Use the same style as later
3129 in this function when indexing through an array. This also
3130 works around GCC bug 48267.
3131
03d0a109
PE
3132 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3133
44f730c8
PE
3134 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3135
fe75f926
PE
3136 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3137 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3138
ffa8c828
PE
3139 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3140 This avoids undefined behavior on integer overflow, and is a bit
3141 more convenient anyway since it is compared to a size_t variable.
3142
c5101a77
PE
3143 Variadic C functions now count arguments with size_t, not int.
3144 This avoids an unnecessary limitation on 64-bit machines, which
3145 caused (substring ...) to crash on large vectors (Bug#8344).
3146 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3147 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3148 All variadic functions and their callers changed accordingly.
c5101a77
PE
3149 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3150 * data.c (arith_driver, float_arith_driver): Likewise.
3151 * editfns.c (general_insert_function): Likewise.
3152 * eval.c (struct backtrace.nargs, interactive_p)
3153 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3154 (funcall_lambda, mark_backtrace): Likewise.
3155 * fns.c (concat): Likewise.
3156 * frame.c (x_set_frame_parameters): Likewise.
3157 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3158 0 if not found, not -1. All callers changed.
3159
dd3f25f7
PE
3160 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3161 (stack_copy_size): Now size_t, not int.
3162 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3163
461c2ab9
JB
31642011-03-28 Juanma Barranquero <lekktu@gmail.com>
3165
3166 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3167 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3168 All callers changed.
3169
3170 * lisp.h (multibyte_char_to_unibyte):
3171 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3172 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3173 * character.h (CHAR_TO_BYTE8):
3174 * cmds.c (internal_self_insert):
3175 * editfns.c (general_insert_function):
3176 * keymap.c (push_key_description):
3177 * search.c (Freplace_match):
3178 * xdisp.c (message_dolog, set_message_1): All callers changed.
3179
f6d62986
SM
31802011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3181
3182 * keyboard.c (safe_run_hook_funcall): New function.
3183 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3184 don't set the hook to nil, but remove the offending function instead.
3185 (Qcommand_hook_internal): Remove, unused.
3186 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3187 Vcommand_hook_internal.
3188
3189 * eval.c (enum run_hooks_condition): Remove.
3190 (funcall_nil, funcall_not): New functions.
3191 (run_hook_with_args): Call each function through a `funcall' argument.
3192 Remove `cond' argument, now redundant.
3193 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3194 (Frun_hook_with_args_until_failure): Adjust accordingly.
3195 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3196
1db5b1ad
JB
31972011-03-28 Juanma Barranquero <lekktu@gmail.com>
3198
3199 * dispextern.h (string_buffer_position): Remove declaration.
3200
3201 * print.c (strout): Remove parameter `multibyte', unused since
3202 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3203
3204 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3205 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3206 All callers changed.
3207
3208 * w32.c (_wsa_errlist): Use braces for struct initializers.
3209
3210 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3211 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3212 All callers changed.
3213 (string_buffer_position): Likewise. Also, make static (it's never
3214 used outside xdisp.c).
3215 (cursor_row_p): Remove parameter `w', unused since
3216 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3217 (decode_mode_spec): Remove parameter `precision', introduced during
3218 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3219 All callers changed.
3220
5ffb62aa
JD
32212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3222
3223 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3224
461c2ab9 32252011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3226
3227 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3228 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3229 (ns_update_auto_hide_menu_bar): New functions.
3230 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3231 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3232 ns_constrain_all_frames.
3233 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3234 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3235
5c380ffb
JD
32362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3237
3238 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3239
9af30bdf
GM
32402011-03-27 Glenn Morris <rgm@gnu.org>
3241
3242 * syssignal.h: Replace RETSIGTYPE with void.
3243 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3244 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3245 Replace SIGTYPE with void everywhere.
3246 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3247 * s/template.h (SIGTYPE): Remove commented out definition.
3248
e2abce01
JB
32492011-03-26 Eli Zaretskii <eliz@gnu.org>
3250
3251 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3252 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3253
f868cd8a
JB
32542011-03-26 Juanma Barranquero <lekktu@gmail.com>
3255
59eb0929
JB
3256 * w32.c (read_unc_volume): Use parameter `henum', instead of
3257 global variable `wget_enum_handle'.
3258
3259 * keymap.c (describe_vector): Remove parameters `indices' and
3260 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3261 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3262
f868cd8a
JB
3263 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3264
3265 * keyboard.c (timer_check): Remove parameter `do_it_now',
3266 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3267 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3268 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3269
3270 * keyboard.c (read_char):
3271 * w32menu.c (w32_menu_display_help):
3272 * xmenu.c (show_help_event, menu_help_callback):
3273 Adjust calls to `show_help_echo'.
3274
3275 * gtkutil.c (xg_maybe_add_timer):
3276 * keyboard.c (readable_events):
3277 * process.c (wait_reading_process_output):
3278 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3279
3280 * insdel.c (adjust_markers_gap_motion):
3281 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3282 (gap_left, gap_right): Don't call it.
3283
2ecf6fdb
CY
32842011-03-25 Chong Yidong <cyd@stupidchicken.com>
3285
3286 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3287 incurred during fontification.
3288
6b1f9ba4
JB
32892011-03-25 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3292 (DEFVAR_PER_BUFFER): Don't pass it.
3293
3294 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3295 (scrolling_window): Don't pass it.
3296
0f4a96b5
JB
32972011-03-25 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3300
3301 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3302 and `suffix'.
3303 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3304 of variables specific to SELinux and computation of `encoded_absname'.
3305
3306 * image.c (XPutPixel): Remove unused variable `height'.
3307
3308 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3309
3310 * unexw32.c (get_section_info): Remove unused variable `section'.
3311
3312 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3313 (system_process_attributes): Remove unused variable `sess'.
3314 (sys_read): Remove unused variable `err'.
3315
3316 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3317 (w32_wnd_proc): Remove unused variable `isdead'.
3318 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3319 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3320 (x_create_tip_frame): Remove unused variable `tem'.
3321
3322 * w32inevt.c (w32_console_read_socket):
3323 Remove unused variable `no_events'.
3324
3325 * w32term.c (x_draw_composite_glyph_string_foreground):
3326 Remove unused variable `width'.
3327
1149507c
JB
33282011-03-24 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * w32term.c (x_set_glyph_string_clipping):
3331 Don't pass uninitialized region to CombineRgn.
3332
9c88f339
JB
33332011-03-23 Juanma Barranquero <lekktu@gmail.com>
3334
3335 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3336 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3337 (Fx_close_connection): Remove unused variable `i'.
3338
3339 * w32font.c (w32font_draw): Return number of glyphs.
3340 (w32font_open_internal): Remove unused variable `i'.
3341 (w32font_driver): Add missing initializer.
3342
3343 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3344 (fill_in_menu): Remove unused variable `items_added'.
3345
3346 * w32term.c (last_mouse_press_frame): Remove static global variable.
3347 (w32_clip_to_row): Remove unused variable `f'.
3348 (x_delete_terminal): Remove unused variable `i'.
3349
3350 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3351 (NOTHING): Remove unused static global variable.
3352 (uniscribe_check_otf): Remove unused variable `table'.
3353 (uniscribe_font_driver): Add missing initializers.
3354
dee091a3
JD
33552011-03-23 Julien Danjou <julien@danjou.info>
3356
3357 * term.c (Fsuspend_tty, Fresume_tty):
3358 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3359 * window.c (temp_output_buffer_show):
3360 * insdel.c (signal_before_change):
3361 * frame.c (Fhandle_switch_frame):
3362 * fileio.c (Fdo_auto_save):
3363 * emacs.c (Fkill_emacs):
3364 * editfns.c (save_excursion_restore):
3365 * cmds.c (internal_self_insert):
3366 * callint.c (Fcall_interactively):
3367 * buffer.c (Fkill_all_local_variables):
3368 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3369 Use Frun_hooks.
0f4a96b5 3370 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3371 unconditionnaly since it does the check itself.
3372
2c520ab5 33732011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3374
c9c49752
PE
3375 Fix more problems found by GCC 4.5.2's static checks.
3376
8abc3f12
PE
3377 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3378 the first time through the loop, since we know p0 < p1 then.
3379 This also avoids a gcc -Wstrict-overflow warning.
3380
a2d26660
PE
3381 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3382 leading to a memory leak, possible in functions like
3383 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3384 of objects (Bug#8318).
a2d26660 3385
916c72e9
PE
3386 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3387 that could (at least in theory) be that large.
3388
19ab8a18
PE
3389 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3390 This is less likely to overflow, and avoids undefined behavior if
3391 overflow does occur. All callers changed. Use strtoul to scan
3392 for the unsigned long integer.
b7cbbd6f
PE
3393 (pint2hrstr): Simplify and tune code slightly.
3394 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3395
f0641eff
PE
3396 * scroll.c (do_scrolling): Work around GCC bug 48228.
3397 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3398
7f650bb9
PE
3399 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3400 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3401 (validate_x_resource_name): Simplify count usage.
3402 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3403
37dd57d1
PE
3404 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3405 fail (Bug#8306).
81e56e61 3406
699979fc 3407 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3408
401bf9b4
PE
3409 * process.c (Fmake_network_process): Use socklen_t, not int,
3410 where POSIX says socklen_t is required in portable programs.
3411 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3412 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3413 (Fmake_network_process, server_accept_connection):
3414 (wait_reading_process_output, read_process_output):
3415 Likewise.
3416
b93aacde
PE
3417 * process.c: Rename or move locals to avoid shadowing.
3418 (list_processes_1, Fmake_network_process):
3419 (read_process_output_error_handler, exec_sentinel_error_handler):
3420 Rename or move locals.
4dc343ee 3421 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3422 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3423 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3424 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3425 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3426
af8a867c 3427 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3428 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3429 Include tparam.h instead, since it declares them.
af8a867c
PE
3430 * cm.h (PC): Remove extern decl; tparam.h now does this.
3431 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3432 * terminfo.c: Include tparam.h, to check interfaces.
3433 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3434 (tparam): Adjust signature to match interface in tparam.h;
3435 this removes some undefined behavior. Check that outstring and len
3436 are zero, which they always are with Emacs.
3437 * tparam.h (PC, BC, UP): New extern decls.
3438
0248044d 3439 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3440 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3441
8ff096c1 3442 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3443 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3444 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3445 (ftfont_list): Remove unused local.
49eaafba
PE
3446 (get_adstyle_property, ftfont_pattern_entity):
3447 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3448 Rename locals to avoid shadowing.
8ff096c1 3449
e2be39f6
PE
3450 * xfont.c (xfont_list_family): Mark var as initialized.
3451
c9735e30
PE
3452 * xml.c (make_dom): Now static.
3453
8f5201ae
PE
3454 * composite.c (composition_compute_stop_pos): Rename local to
3455 avoid shadowing.
b246f932
PE
3456 (composition_reseat_it): Remove unused locals.
3457 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3458 (composition_update_it): Mark var as initialized.
11b61122
PE
3459 (find_automatic_composition): Mark vars as initialized,
3460 with a FIXME (Bug#8290).
8f5201ae 3461
760fbc2c
PE
3462 character.h: Rename locals to avoid shadowing.
3463 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3464 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3465 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3466 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3467 to avoid shadowing.
3468
ff08eb85
PE
3469 * textprop.c (property_change_between_p): Remove; unused.
3470
fc7bf025
PE
3471 * intervals.c (interval_start_pos): Now static.
3472
235d7abc
PE
3473 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3474
44f230aa
SM
3475 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3476 Rename locals to avoid shadowing.
3e7d6594 3477
50060332
PE
3478 * sound.c (wav_play, au_play, Fplay_sound_internal):
3479 Fix pointer signedness.
d01f234b 3480 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3481 (wav_play): Initialize a variable to 0, to prevent undefined
3482 behavior (Bug#8278).
50060332 3483
c4fc4e30
PE
3484 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3485
918436ed
PE
3486 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3487
c939f91b
PE
3488 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3489 clobbering (Bug#8298).
b9c7f648
PE
3490 * sysdep.c (sys_subshell): Likewise.
3491 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3492
6bd8c144
PE
3493 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3494 This should get cleaned up, so that child_setup has the
3495 same signature on all platforms.
3496
7710357c 3497 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3498 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3499
c59da222
CY
35002011-03-22 Chong Yidong <cyd@stupidchicken.com>
3501
3502 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3503 not to be necessary, and produces flickering.
3504
66b87493
GM
35052011-03-20 Glenn Morris <rgm@gnu.org>
3506
3507 * config.in: Remove file.
3508
45b6f6d5
JB
35092011-03-20 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3512 are now in src/globals.h.
3513 (syms_of_minibuf): Remove spurious & from previous change.
3514
3ec03f7e
LL
35152011-03-20 Leo <sdl.web@gmail.com>
3516
3517 * minibuf.c (completing-read-function): New variable.
3518 (completing-read-default): Rename from completing-read.
3519 (completing-read): Call completing-read-function.
3520
b14e3e21
CY
35212011-03-19 Juanma Barranquero <lekktu@gmail.com>
3522
3523 * xfaces.c (Fx_load_color_file):
3524 Read color file from absolute filename (bug#8250).
3525
f2b726e6
JB
35262011-03-19 Juanma Barranquero <lekktu@gmail.com>
3527
3528 * makefile.w32-in: Update dependencies.
3529
09f6ff02
EZ
35302011-03-17 Eli Zaretskii <eliz@gnu.org>
3531
3532 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3533
29a6015a
PE
35342011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3535
a3a6c54e
PE
3536 Fix more problems found by GCC 4.5.2's static checks.
3537
b766f867
PE
3538 * process.c (make_serial_process_unwind, send_process_trap):
3539 (sigchld_handler): Now static.
3540
be02381c
PE
3541 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3542 That way, the code declares only the vars that it needs.
3543 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3544 * s/cygwin.h (PTY_ITERATION): Likewise.
3545 * s/darwin.h (PTY_ITERATION): Likewise.
3546 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3547
57048744
PE
3548 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3549 * process.c (allocate_pty): Don't declare stb unless it's needed.
3550
7914961c 3551 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3552 (CONSTANTLIM): Remove; unused.
3553 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3554 Define only if needed.
7914961c 3555
b3967b18
PE
3556 * unexelf.c (unexec): Name an expression,
3557 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3558 Use a different way to cause a compilation error if anyone uses
3559 n rather than nn, a way that does not involve shadowing.
73366a00 3560 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3561
29a6015a
PE
3562 * deps.mk (unexalpha.o): Remove; unused.
3563
43cfc33e 3564 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3565 * unexec.h: New file.
ce701a33
PE
3566 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3567 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3568 Depend on unexec.h.
3569 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3570 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3571 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3572 Change as necessary to match prototype in unexec.h.
ce701a33 3573
01f44d5a
PE
3574 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3575 shadowing.
4f63c6bb 3576 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3577
a6670b0b
PE
3578 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3579 Rename locals to avoid shadowing.
3580
cef2010d 3581 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3582 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3583
d4d7173a
PE
3584 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3585
f08b802a
PE
3586 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3587 warning when compiling print.c.
3588
3ddb0639
PE
3589 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3590 instead of using an uninitialized var.
5ad03b97 3591 (font_sort_entities): Mark var as initialized.
3ddb0639 3592
170a2692
PE
3593 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3594
e663c700
PE
3595 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3596 pointers to constants.
89bc529a 3597 (font_parse_fcname): Remove unused vars.
7b81e2d0 3598 (font_delete_unmatched): Now static.
ea838e10 3599 (font_get_spec): Remove; unused.
13a547c6
PE
3600 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3601 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3602 Rename or move locals to avoid shadowing.
e663c700 3603
2a80c887 3604 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3605 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3606
1384fa33 3607 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3608 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3609
8b2c52e9
PE
3610 * alloc.c (mark_backtrace): Move decl from here ...
3611 * lisp.h: ... to here, so that it can be checked.
3612
475545b5 3613 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3614 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3615 (lisp_indirect_variable): Name an expression,
3616 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3617 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3618
b1349114 3619 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3620 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3621 Use const pointer when appropriate.
b1349114 3622
a2928364
PE
3623 * lisp.h (get_system_name, get_operating_system_release):
3624 Move decls here, to check interfaces.
3625 * process.c (get_operating_system_release): Move decl to lisp.h.
3626 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3627 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3628 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3629 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3630 (Fformat_time_string, Fencode_time, Finsert_char):
3631 (Ftranslate_region_internal, Fformat):
3632 Rename or remove local vars to avoid shadowing.
9710023e 3633 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3634
a415e694
PE
3635 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3636 avoid shadowing.
3637
8ef4622d
PE
3638 * lisp.h (eassert): Check that the argument compiles, even if
3639 ENABLE_CHECKING is not defined.
3640
946f9a5b
PE
3641 * data.c (Findirect_variable): Name an expression, to avoid
3642 gcc -Wbad-function-cast warning.
112396d6 3643 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3644 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3645 (Fmake_variable_buffer_local, Fmake_local_variable):
3646 Mark variables as initialized.
52746918 3647 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3648
e5aab7e7 3649 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3650 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3651 Rename locals to avoid shadowing.
dff45157
PE
3652 (mark_stack): Move local variables into the #ifdef region where
3653 they're used.
7bc26fdb
PE
3654 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3655 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3656 needed otherwise.
3657 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3658 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3659 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3660
e5aab7e7
PE
3661 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3662 avoids undefined behavior in theory.
3663
4da60324
PE
3664 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3665
88043301
PE
3666 Use functions, not macros, for up- and down-casing (Bug#8254).
3667 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3668 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3669 to use the following functions instead of these macros.
3670 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3671 EMACS_INT, since callers assume the returned value fits in int.
3672 (upcase1): Likewise, for UPCASE_TABLE.
3673 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3674 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3675 the race-condition problem in the old DOWNCASE.
88043301 3676
19ed5445
PE
3677 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3678 Rename locals to avoid shadowing.
3679 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3680 (regex_compile, re_search_2, re_match_2_internal):
3681 Remove unused local vars.
952db0d7
PE
3682 (FREE_VAR): Rewrite so as not to use empty "else",
3683 which gcc can warn about.
da053e48 3684 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3685 (RETALLOC_IF): Define only if needed.
3686 (WORDCHAR_P): Likewise. This one is never needed, but is used
3687 only in a comment talking about a compiler bug, so put inside
3688 the #if 0 of that comment.
3689 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3690 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3691 Remove; unused.
19ed5445 3692
1f3561e4 3693 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3694 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3695 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3696
ded6f8f7
PE
3697 * search.c (simple_search): Remove unused var.
3698
dbd37a95
PE
3699 * dired.c (compile_pattern): Move decl from here ...
3700 * lisp.h: ... to here, so that it can be checked.
3701 (struct re_registers): New forward decl.
3702
7e47afad
PE
3703 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3704
85f24f61
PE
3705 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3706 All uses changed.
3707 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3708 Rename locals to avoid shadowing.
5671df8f 3709 (Fvertical_motion): Mark locals as initialized.
85f24f61 3710
181aa2be 3711 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3712 (casify_region): Mark local as initialized.
181aa2be 3713
930d429c
PE
3714 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3715
7082eac6
PE
3716 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3717 New macros, so that the caller can use some names other than
3718 gcpro1, gcpro2, etc.
3719 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3720 of the new macros.
3721 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3722 argument, for consistency with GCPRO2_VAR, etc: it is now the
3723 prefix of the variable, not the variable itself. All uses
3724 changed.
38b2c076
PE
3725 * dired.c (directory_files_internal, file_name_completion):
3726 Rename locals to avoid shadowing.
3727
15206ed9
PE
3728 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3729 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3730 dired.c's scmp function, had undefined behavior.
3731 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3732 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3733 * buffer.h: ... to here, because these macros use current_buffer,
3734 and the new implementation with inline functions needs to have
3735 current_buffer in scope now, rather than later when the macros
3736 are used.
3737 (downcase, upcase1): New static inline functions.
3738 (DOWNCASE, UPCASE1): Reimplement using these functions.
3739 This avoids undefined behavior in expressions like
3740 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3741 from race conditions in accessing the global variables
3742 case_temp1 and case_temp2.
3743 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3744 * lisp.h (case_temp1, case_temp2): Remove their decls.
3745 * character.h (ASCII_CHAR_P): Move from here ...
3746 * lisp.h: ... to here, so that the inline functions mentioned
3747 above can use them.
3748
4a6bea26
PE
3749 * dired.c (directory_files_internal_unwind): Now static.
3750
f14b7e14
PE
3751 * fileio.c (file_name_as_directory, directory_file_name):
3752 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3753 Now static.
2893f146
PE
3754 (file_name_as_directory): Use const pointers when appropriate.
3755 (Fexpand_file_name): Likewise. In particular, newdir might
3756 point at constant storage, so make it a const pointer.
fd4ead52 3757 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3758 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3759 signedness issues.
f839df0c
PE
3760 (Fset_file_times, Finsert_file_contents, auto_save_error):
3761 Rename locals to avoid shadowing.
f14b7e14 3762
5716756e 3763 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3764 (Ftry_completion, Fall_completions): Rename or remove locals
3765 to avoid shadowing.
5716756e 3766
b4c3046a
PE
3767 * marker.c (bytepos_to_charpos): Remove; unused.
3768
b45db522
PE
3769 * lisp.h (verify_bytepos, count_markers): New decls,
3770 so that gcc does not warn that these functions aren't declared.
3771
85876d07
PE
3772 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3773 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3774 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3775 (copy_text): Remove unused local var.
85876d07 3776
03d78a21 3777 * filelock.c (within_one_second): Now static.
b3dd38ab 3778 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3779
5df8f01b
PE
3780 * buffer.c (fix_overlays_before): Mark locals as initialized.
3781 (fix_start_end_in_overlays): Likewise. This function should be
3782 simplified by using pointers-to-pointers, but that's a different
3783 matter.
b1d876f1 3784 (switch_to_buffer_1): Now static.
8f54f30a
PE
3785 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3786 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3787
a70072c9 3788 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3789 Fix pointer signedness issue.
edced198
PE
3790 (sys_subshell): Mark local as volatile if checking for lint,
3791 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3792 (MAXPATHLEN): Define only if needed.
a70072c9 3793
a0977c44
PE
3794 * process.c (serial_open, serial_configure): Move decls from here ...
3795 * systty.h: ... to here, so that they can be checked.
3796
a884fdcc
PE
3797 * fns.c (get_random, seed_random): Move extern decls from here ...
3798 * lisp.h: ... to here, so that they can be checked.
3799
604efe86 3800 * sysdep.c (reset_io): Now static.
b8950c94 3801 (wait_for_termination_signal): Remove; unused.
604efe86 3802
38fc62d9
PE
3803 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3804 (copy_keymap_item, append_key, push_text_char_description):
3805 Now static.
1004a21a 3806 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3807 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3808 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3809 (describe_map_tree):
3810 Rename locals to avoid shadowing.
38fc62d9 3811
2f2650da
PE
3812 * keyboard.c: Declare functions static if they are not used elsewhere.
3813 (echo_char, echo_dash, cmd_error, top_level_2):
3814 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3815 (read_char, kbd_buffer_get_event, make_lispy_position):
3816 (make_lispy_event, make_lispy_movement, apply_modifiers):
3817 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3818 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3819 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3820 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3821 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3822
a053e86c 3823 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3824 (mark_kboards): Move decl here ...
3825 * alloc.c (mark_kboards): ... from here.
a053e86c 3826
4752793e
PE
3827 * lisp.h (force_auto_save_soon): New decl.
3828
74f10ca7 3829 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3830 (DEFINE_DUMMY_FUNCTION): New macro.
3831 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3832 Use it.
c03cd23f
PE
3833 (main): Add casts to avoid warnings
3834 if GCC considers string literals to be constants.
74f10ca7 3835
022e70d4
PE
3836 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3837
59d6fe83
PE
3838 * dbusbind.c: Pointer signedness fixes.
3839 (xd_signature, xd_append_arg, xd_initialize):
3840 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3841 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3842 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3843 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3844
78320123
PE
3845 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3846 if GCC considers string literals to be constants.
49cebcca 3847 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3848
35ac2a97
SM
38492011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3850
fb103ca9
SM
3851 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3852 (print_preprocess, print_object): New macro to fix last change.
3853
35ac2a97
SM
3854 * print.c (print_preprocess): Don't forget font objects.
3855
62973b41
JB
38562011-03-16 Juanma Barranquero <lekktu@gmail.com>
3857
3858 * emacs.c (USAGE3): Doc fixes.
3859
0e48bb22
AS
38602011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3861
3862 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3863 structure.
3864
7684e57b
JB
38652011-03-14 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * lisp.h (VWindow_system, Qfile_name_history):
3868 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3869 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3870 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3871
3872 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3873 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3874
3875 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3876 * w32console.c (detect_input_pending, read_input_pending)
3877 (encode_terminal_code):
3878 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3879 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3880 (w32_system_caret_y, Qfile_name_history):
3881 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3882 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3883 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3884 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3885 * w32proc.c (Qlocal, report_file_error):
3886 * w32term.c (Vwindow_system, updating_frame):
3887 * w32uniscribe.c (initialized, uniscribe_font_driver):
3888 Remove unneeded extern declarations.
3889
2aa46d6c
CY
38902011-03-14 Chong Yidong <cyd@stupidchicken.com>
3891
c96bbc66 3892 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3893
cffc6f3b
CY
38942011-03-13 Chong Yidong <cyd@stupidchicken.com>
3895
3896 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3897 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3898 These macros can no longer be used for assignment.
3899
44f230aa
SM
3900 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3901 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3902 (record_buffer_markers, fetch_buffer_markers): New functions for
3903 recording and fetching special buffer markers.
3904 (set_buffer_internal_1, set_buffer_temp): Use them.
3905
3906 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3907
3908 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3909
3910 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3911 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3912
3913 * xdisp.c (hscroll_window_tree):
3914 (reconsider_clip_changes): Use PT instead of BUF_PT.
3915
d251f04b
EZ
39162011-03-13 Eli Zaretskii <eliz@gnu.org>
3917
3918 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3919 $(EMACS_ROOT)/lib/intprops.h.
3920
f0c77cd1
PE
39212011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3922
3eca4629
PE
3923 Fix more problems found by GCC 4.5.2's static checks.
3924
7c86ee98
PE
3925 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3926 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3927 (xg_free_frame_widgets): Make it clear that a local variable is
3928 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3929 (gdk_window_get_screen): Make it clear that this macro is needed
3930 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3931 (int_gtk_range_get_value): New function, which avoids a diagnostic
3932 from gcc -Wbad-function-cast.
3933 (xg_set_toolkit_scroll_bar_thumb): Use it.
3934 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3935 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3936 (get_utf8_string, xg_get_file_with_chooser):
3937 Rename locals to avoid shadowing.
3938 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3939
41729b81
PE
3940 * xgselect.c (xg_select): Remove unused var.
3941
f0c77cd1
PE
3942 * image.c (four_corners_best): Mark locals as initialized.
3943 (gif_load): Initialize transparent_p to zero (Bug#8238).
3944 Mark another local as initialized.
ec6cf4c6 3945 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3946
ce0ad53d 3947 * image.c (clear_image_cache): Now static.
d5d5a617 3948 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3949 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3950 (x_edge_detection): Remove unnecessary cast that
3951 gcc -Wbad-function-cast diagnoses.
2037898d 3952 (gif_load): Fix pointer signedness.
6ae141d6
PE
3953 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3954 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3955
33383987 39562011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3957
d32df629
PE
3958 Improve quality of tests for time stamp overflow.
3959 For example, without this patch (encode-time 0 0 0 1 1
3960 1152921504606846976) returns the obviously-bogus value (-948597
3961 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3962 reports time overflow. See
3963 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3964 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3965 * editfns.c: Include limits.h and intprops.h.
3966 (TIME_T_MIN, TIME_T_MAX): New macros.
3967 (time_overflow): Move earlier, to before first use.
3968 (hi_time, lo_time): New functions, for an accurate test for
3969 out-of-range times.
3970 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3971 (Fget_internal_run_time): Don't assume time_t fits in int.
3972 (make_time): Use list2 instead of Fcons twice.
3973 (Fdecode_time): More accurate test for out-of-range times.
3974 (check_tm_member): New function.
3975 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3976 (lisp_time_argument): Don't rely on undefined left-shift and
3977 right-shift behavior when checking for time stamp overflow.
8be6f318 3978
fe31d94c
PE
3979 * editfns.c (time_overflow): New function, refactoring common code.
3980 (Fformat_time_string, Fdecode_time, Fencode_time):
3981 (Fcurrent_time_string): Use it.
3982
8be6f318
PE
3983 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3984 * dired.c (make_time): Move to ...
3985 * editfns.c (make_time): ... here.
3986 * systime.h: Note the move.
3987
09d9db2c 39882011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3989
126bc0dc
YM
3990 * fringe.c (update_window_fringes): Remove unused variables.
3991
c47cbdfd
YM
3992 * unexmacosx.c (copy_data_segment): Also copy __got section.
3993 (Bug#8223)
3994
7ac80be9
EZ
39952011-03-12 Eli Zaretskii <eliz@gnu.org>
3996
c96bbc66 3997 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3998 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3999 Constify `char *' arguments and their references according to
4000 prototypes in tparam.h.
4001
ecb0f94d 4002 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4003
7ac80be9
EZ
4004 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4005 Adapt all references accordingly.
4006
4007 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4008
ef1fd07e
TT
40092011-03-11 Tom Tromey <tromey@redhat.com>
4010
4011 * buffer.c (syms_of_buffer): Remove obsolete comment.
4012
7ef4b50c
EZ
40132011-03-11 Eli Zaretskii <eliz@gnu.org>
4014
4015 * termhooks.h (encode_terminal_code): Declare prototype.
4016
4017 * msdos.c (encode_terminal_code): Don't declare prototype.
4018
4019 * term.c (encode_terminal_code): Now external again, used by
4020 w32console.c and msdos.c.
4021
44f230aa
SM
4022 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4023 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4024
4b1ec863 40252011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4026
1714f52b 4027 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4028
4b1ec863
PE
4029 * fringe.c (update_window_fringes): Mark locals as initialized
4030 (Bug#8227).
4031 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4032
524c7aa6
PE
4033 * alloc.c (mark_fringe_data): Move decl from here ...
4034 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4035 to check its interface.
4036 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4037
a5c0af81 4038 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4039 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4040 (fontset_font): Mark local as initialized.
a9a06e0b 4041 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4042
b4716021
PE
4043 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4044
811e9bac 4045 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4046 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4047 (x_own_selection, Fx_disown_selection_internal): Rename locals
4048 to avoid shadowing.
4049 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4050
7e3ab302
PE
4051 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4052 so that the caller can use some name other than gcpro1.
4053 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4054 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4055 (Fx_backspace_delete_keys_p):
4056 Use them to avoid shadowing, and rename vars to avoid shadowing.
4057 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4058 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4059 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4060 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4061 Remove unused locals.
7e3ab302
PE
4062 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4063 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4064 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4065 macros.
f78faa98 4066
e2b13473
PE
4067 * xterm.h (x_mouse_leave): New decl.
4068
77f23912
PE
4069 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4070 Remove unused functions.
cdf4ba58
PE
4071 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4072 (x_calc_absolute_position): Now static.
7411c686 4073 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4074 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4075 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4076 unless they are used.
38d0b34a
PE
4077 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4078 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4079 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4080 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4081 (x_error_catcher, x_connection_closed, x_error_handler):
4082 (x_error_quitter, xembed_send_message, x_iconify_frame):
4083 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4084 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4085 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4086
44f230aa
SM
4087 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4088 Rename or move locals to avoid shadowing.
6b463e58 4089 (tty_defined_color, merge_face_heights): Now static.
5967d051 4090 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4091 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4092 does not deduce is never used uninitialized.
73719eba
PE
4093 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4094 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4095
426994c3 4096 * terminal.c (store_terminal_param): Now static.
5489860b 4097
032f1620 4098 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4099 (set_frame_menubar): Remove unused local.
d4323972 4100 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4101 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4102 since they might point to immutable storage.
281585b0
PE
4103 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4104 since it's unused otherwise.
032f1620 4105
367c19e5 4106 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4107 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4108 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4109 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4110 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4111 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4112 does not deduce are never used uninitialized.
70739cbe 4113
07b48fa9
PE
4114 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4115
8868a238 4116 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4117 * window.c (window_loop, size_window):
4118 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4119
7e5cf297 4120 * window.c (display_buffer): Now static.
d6550a9f
PE
4121 (size_window): Mark variables that gcc -Wuninitialized
4122 does not deduce are never used uninitialized.
a586633d
PE
4123 * window.h (check_all_windows): New decl, to forestall
4124 gcc -Wmissing-prototypes diagnostic.
5b555da1 4125 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4126
f6095868
PE
4127 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4128 shadowing.
4129 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4130 Include <limits.h>.
4131 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4132 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4133 (load_charset_map): Mark variables that gcc -Wuninitialized
4134 does not deduce are never used uninitialized.
53df7c11 4135 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4136
f38b440c
PE
4137 * coding.c (coding_set_source, coding_set_destination):
4138 Use "else { /* comment */ }" rather than "else /* comment */;"
4139 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4140 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4141 a block, when the outer 'i' will do.
4142 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4143 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4144 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4145 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4146 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4147 Rename locals to avoid shadowing.
4148 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4149 * coding.c (emacs_mule_char, encode_invocation_designation):
4150 Now static, since they're not used elsewhere.
413bb2db 4151 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4152 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4153 (decode_coding_emacs_mule): Mark variables that gcc
4154 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4155 (detect_coding_iso_2022): Initialize a local variable that might
4156 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4157 this initialization is needed. (Bug#8211)
5f58e762
PE
4158 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4159 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4160 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4161 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4162 Remove unused macros.
f38b440c 4163
232b38b9 4164 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4165 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4166 * character.c (string_count_byte8): Likewise.
232b38b9 4167
fb90da1b
PE
4168 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4169 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4170
fb93dbc2
PE
4171 * chartab.c (copy_sub_char_table): Now static, since it's not used
4172 elsewhere.
5c156ace
PE
4173 (sub_char_table_ref_and_range, char_table_ref_and_range):
4174 Rename locals to avoid shadowing.
bbcd0949 4175 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4176
7d3b3862 4177 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4178 (BIDI_BOB): Remove unused macro.
7d3b3862 4179
6be7d3da
PE
4180 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4181 deduce are never used uninitialized.
c2ed9c8b 4182 * term.c (encode_terminal_code): Likewise.
6be7d3da 4183
75f8807f 4184 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4185
50938595
PE
4186 * tparam.h: New file.
4187 * term.c, tparam.h: Include it.
4188 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4189 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4190 Move these decls to tparam.h, and make them agree with what
4191 is actually in tparam.c. The previous trick of using incompatible
4192 decls in different modules does not conform to the C standard.
4193 All callers of tparam changed to use tparam's actual API.
4194 * tparam.c (tparam1, tparam, tgoto):
4195 Use const pointers where appropriate.
4196
fbceeba2
PE
4197 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4198 * cm.h (struct cm): Likewise.
4199 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4200 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4201 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4202 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4203 (turn_on_face, init_tty): Likewise.
4204 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4205
7f3f1250
PE
4206 * term.c (term_mouse_position): Rename local to avoid shadowing.
4207
e6ca6543
PE
4208 * alloc.c (mark_ttys): Move decl from here ...
4209 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4210
c40f8d15
AS
42112011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4212
4213 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4214
cfe0661d
JB
42152011-03-09 Juanma Barranquero <lekktu@gmail.com>
4216
4217 * search.c (compile_pattern_1): Remove argument regp, unused since
4218 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4219 (compile_pattern): Don't pass it.
4220
0afb4571
J
42212011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4222
4223 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4224 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4225 for ! HAVE_GTK3.
4226 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4227
4228 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4229
4230 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4231 gdk_window_get_screen, gdk_window_get_geometry,
4232 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4233 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4234 (xg_get_pixbuf_from_pixmap): New function.
4235 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4236 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4237 Call xg_get_pixbuf_from_pixmap instead of
4238 gdk_pixbuf_get_from_drawable.
4239 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4240 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4241 (xg_check_special_colors): Use GtkStyleContext and its functions
4242 for HAVE_GTK3.
4243 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4244 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4245 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4246 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4247 Call gtk_widget_get_preferred_size.
0afb4571
J
4248 (xg_frame_resized): gdk_window_get_geometry only takes 5
4249 parameters.
44f230aa
SM
4250 (xg_win_to_widget, xg_event_is_for_menubar):
4251 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4252 (xg_set_widget_bg): New function.
4253 (delete_cb): New function.
895009e1 4254 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4255 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4256 (xg_set_background_color): Call xg_set_widget_bg.
4257 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4258 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4259 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4260 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4261 if ! HAVE_GTK3.
4262 (update_frame_tool_bar): Call gtk_widget_hide.
4263 (xg_initialize): Use GDK_KEY_g.
4264
4265 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4266 if ! HAVE_GTK3
4267 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4268
4269 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4270 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4271 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4272
1c2cc4ef
JB
42732011-03-08 Juanma Barranquero <lekktu@gmail.com>
4274
4275 * w32xfns.c (select_palette): Check success of RealizePalette against
4276 GDI_ERROR, not zero.
4277
33383987 4278See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4279
4280;; Local Variables:
4281;; coding: utf-8
aac0c6e3
MR
4282;; End:
4283
33383987 4284 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4285
4286 This file is part of GNU Emacs.
4287
4288 GNU Emacs is free software: you can redistribute it and/or modify
4289 it under the terms of the GNU General Public License as published by
4290 the Free Software Foundation, either version 3 of the License, or
4291 (at your option) any later version.
4292
4293 GNU Emacs is distributed in the hope that it will be useful,
4294 but WITHOUT ANY WARRANTY; without even the implied warranty of
4295 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4296 GNU General Public License for more details.
4297
4298 You should have received a copy of the GNU General Public License
4299 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.