Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9426aba4
PE
12012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2
b62a57be
PE
3 Fix minor alloc.c problems found by static checking.
4 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5 New extern decls, to avoid calling undeclared functions.
6 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
9 (NEED_MEM_INSERT): New macro.
10 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 11 Remove one incorrect comment and fix another.
b62a57be 12
3539f31f
PE
13 Fix minor ralloc.c problems found by static checking.
14 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
15 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
16 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
17 (r_alloc_sbrk): Now static.
18
a041960a
PE
19 Improve ralloc.c interface checking.
20 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
21 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
22 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
23 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
24 [REL_ALLOC]: ... to here, to check interface.
25 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
26 Remove decls. This fixes an "It stinks!".
27
9426aba4
PE
28 * alloc.c (which_symbols): Fix alignment issue / type clash.
29
d55c12ed
AS
302012-04-15 Andreas Schwab <schwab@linux-m68k.org>
31
32 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
33 (struct Lisp_Misc_Any): Likewise.
34 (struct Lisp_Free): Likewise.
35 * alloc.c (union aligned_Lisp_Symbol): Define.
36 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
37 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
38 (union aligned_Lisp_Misc): Define.
39 (MARKER_BLOCK_SIZE, struct marker_block): Use union
40 aligned_Lisp_Misc instead of union Lisp_Misc.
41 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
42
bdf35b6a 432012-04-14 Paul Eggert <eggert@cs.ucla.edu>
b8df54ff 44
9f46df23 45 configure: new option --enable-gcc-warnings (Bug#11207)
b8df54ff
PE
46 * Makefile.in (C_WARNINGS_SWITCH): Remove.
47 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
48 (ALL_CFLAGS): Use new macros rather than old.
49 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
50 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
51 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
52 -Wunused-result, -Wunused-variable. This should go away once
53 the Emacs and Gnulib regex code is merged.
54 (xmalloc, xrealloc): Now static.
55
b948ce8b
PE
562012-04-14 Paul Eggert <eggert@cs.ucla.edu>
57
58 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
59 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
60 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
61 * s/netbsd.h, s/sol2-6.h:
62 Remove definition of GC_MARK_STACK, since the default now works.
63 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
64 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
65 no longer the default.
66 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
67
35dc09a1 682012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 69
35dc09a1
GM
70 * lread.c (lisp_file_lexically_bound_p):
71 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 72
35dc09a1
GM
732012-04-14 Eli Zaretskii <eliz@gnu.org>
74
75 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
76 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
77
782012-04-14 Jan Djärv <jan.h.d@swipnet.se>
79
80 * nsterm.m (constrainFrameRect): Always constrain when there is only
81 one screen (Bug#10962).
82
bcd86815
KB
832012-04-13 Ken Brown <kbrown@cornell.edu>
84
85 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
86
c25df26e
RT
872012-04-13 Reuben Thomas <rrt@sc3d.org>
88
89 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
90
0fc59f1e
DC
912012-04-11 Daniel Colascione <dancol@dancol.org>
92
93 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
94 against is gone. It's better to use vfork now so that when Cygwin
95 gains a new, working vfork, we use it automatically (bug#10398).
96
de8c03dc
SM
972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
98
99 * window.c (save_window_save): Obey window-point-insertion-type.
100
2f097256
GM
1012012-04-11 Glenn Morris <rgm@gnu.org>
102
103 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
104
453b951e
SM
1052012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
106
107 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
108
75f1671a 1092012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
110
111 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
112 (force_quit_count): New var.
113 (handle_interrupt): Use it.
114
2a8ce227
JB
1152012-04-10 Juanma Barranquero <lekktu@gmail.com>
116
117 * w32.c (w32_delayed_load): Record the full path of the library
118 being loaded (bug#10424).
119
935396c0
GM
1202012-04-09 Glenn Morris <rgm@gnu.org>
121
05920a43
GM
122 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
123 not just in the obarray, before snarfing them. (Bug#11036)
124
935396c0
GM
125 * Makefile.in ($(leimdir)/leim-list.el):
126 Pass EMACS rather than BUILT_EMACS.
127
a18ecafa
TZ
1282012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
129
130 * process.c (make_process):
131 * process.h: Add integer `gnutls_handshakes_tried' member to
132 process struct.
133
6bbef4e5
JC
134 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
135 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
136
137 * gnutls.c (gnutls_log_function2i): Convenience log function.
138 (emacs_gnutls_read): Use new log functions,
139 `gnutls_handshakes_tried' process member, and
140 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
141 attempts per process (connection).
142
b4d3bc10
CY
1432012-04-09 Chong Yidong <cyd@gnu.org>
144
145 * eval.c (Fuser_variable_p, user_variable_p_eh)
146 (lisp_indirect_variable): Functions deleted.
147 (Fdefvar): Caller changed.
148
149 * callint.c (Finteractive, Fcall_interactively):
150 * minibuf.c (Fread_variable): Callers changed.
151
70f4d973
EZ
1522012-04-09 Eli Zaretskii <eliz@gnu.org>
153
154 * xdisp.c (set_cursor_from_row): If the display string appears in
155 the buffer at position that is closer to point than the position
156 after the display string, display the cursor on the first glyph of
157 the display string. Fixes cursor display when a 'display' text
158 property immediately follows invisible text. (Bug#11094)
159
cb3c2e3e
PE
1602012-04-09 Paul Eggert <eggert@cs.ucla.edu>
161
162 composite.c: use 'double' consistently
163 * composite.c (get_composition_id): Use 'double' consistently
164 instead of converting 'float' to 'double' and vice versa; this is
165 easier to understand and avoids a GCC warning.
166
fd06db5d
GM
1672012-04-09 Glenn Morris <rgm@gnu.org>
168
50fe702a
GM
169 * Makefile.in: Generate leim-list with bootstrap-emacs, in
170 preparation for dumping it with emacs. (Bug#4789)
171 (leimdir): New variable.
172 ($(leimdir)/leim-list.el): New rule.
173 (emacs$(EXEEXT)): Depend on leim-list.el.
174
fd06db5d
GM
175 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
176 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
177 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
178
55c131ee
AS
1792012-04-08 Andreas Schwab <schwab@linux-m68k.org>
180
181 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
182 proper alignment.
183
9209588f
JB
1842012-04-07 Juanma Barranquero <lekktu@gmail.com>
185
186 * xml.c (init_libxml2_functions) [WINDOWSNT]:
187 Remove unused local variable.
188
e3fb2efb
PE
1892012-04-07 Paul Eggert <eggert@cs.ucla.edu>
190
191 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
192 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
193 (mark_memory): Mark Lisp_Objects only if pointers might hide in
194 objects, as mark_maybe_pointer will catch them otherwise.
195 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
196 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
197
b5385551
PE
1982012-04-07 Paul Eggert <eggert@cs.ucla.edu>
199
200 Fix typo that broke non-Windows builds.
201 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
202
9078ead6
EZ
2032012-04-07 Eli Zaretskii <eliz@gnu.org>
204
205 Support building on MS-Windows with libxml2.
206
207 * makefile.w32-in (OBJ2): Add xml.$(O).
208 (GLOBAL_SOURCES): Add xml.c.
209 ($(BLD)/xml.$(O)): New dependency list.
210
211 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
212 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
213 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
214 [!WINDOWSNT]: New macros.
215 (init_libxml2_functions, libxml2_loaded_p): New functions.
216 (parse_region): Call fn_xmlCheckVersion instead of using the macro
217 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
218 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
219 Calls xmlCleanupParser only if libxml2 was loaded (or statically
220 linked in).
6bbef4e5
JC
221 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
222 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
223 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
224
225 * emacs.c: Don't include libxml/parser.h.
226 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
227 xmlCleanupParser directly.
228
229 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
230
3811fdf3
EZ
2312012-04-07 Eli Zaretskii <eliz@gnu.org>
232
233 * indent.c (Fvertical_motion): If there is a display string at
234 point, use it.vpos to compute how many lines to backtrack after
235 move_it_to point. (Bug#11133)
236
2f8e16b2
EZ
2372012-04-06 Eli Zaretskii <eliz@gnu.org>
238
239 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
240 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
241 about subtle differences between FETCH_CHAR* and STRING_CHAR*
242 macros related to unification of CJK characters. For the details,
243 see the discussion following the message here:
244 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
245
3d439cd1
CY
2462012-04-04 Chong Yidong <cyd@gnu.org>
247
248 * keyboard.c (Vdelayed_warnings_list): Doc fix.
249
8bc53d00
EZ
2502012-04-01 Eli Zaretskii <eliz@gnu.org>
251
252 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
253 instead of alloca. (Bug#11138)
254
3b0512a3
AS
2552012-04-01 Andreas Schwab <schwab@linux-m68k.org>
256
257 * w32menu.c (is_simple_dialog): Properly check lisp types.
258 (Bug#11141)
259
8427ddd2
EZ
2602012-03-31 Eli Zaretskii <eliz@gnu.org>
261
979022ef
EZ
262 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
263 position we get to after a call to move_it_to fails the
264 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
265 only if we wind up in a string from display property. (Bug#11063)
266
a6b1c7cc
EZ
267 * window.c (Fdelete_other_windows_internal): Invalidate the row
268 and column information about mouse highlight, so that redisplay
269 restores it after reallocating the glyph matrices. (Bug#7464)
270
8427ddd2
EZ
271 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
272 string comes from a `display' text property, use the buffer
273 position of that property as if we actually saw that position in
274 the row's glyphs.
697ba24b
EZ
275 (move_it_by_lines): Remove the assertion that
276 "it->current_x == 0 && it->hpos == 0" which can be legitimately
277 violated when there's a before-string at the beginning of a line.
278 (Bug#11063)
8427ddd2 279
65a0a738
EZ
2802012-03-30 Eli Zaretskii <eliz@gnu.org>
281
282 * xdisp.c (append_space_for_newline): If the default face was
283 remapped, use the remapped face for the appended newline.
284 (extend_face_to_end_of_line): Use the remapped default face for
285 extending the face to the end of the line.
286 (display_line): Call extend_face_to_end_of_line when the default
287 face was remapped. (Bug#11068)
288
581355cc
EZ
2892012-03-29 Eli Zaretskii <eliz@gnu.org>
290
291 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
292
e8fc049f
SM
2932012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
294
295 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
296
4fb9a543
GM
2972012-03-27 Glenn Morris <rgm@gnu.org>
298
299 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
300 Doc fixes.
301
679910f1
KH
3022012-03-26 Kenichi Handa <handa@m17n.org>
303
304 * dispextern.h (struct glyph): Fix previous change. Change the
305 bit length of glyphless.ch to 25 (Bug#11082).
306
90d49b7f
CY
3072012-03-26 Chong Yidong <cyd@gnu.org>
308
309 * keyboard.c (Vselection_inhibit_update_commands): New variable.
310 (command_loop_1): Use it; inhibit selection update for
311 handle-select-window too (Bug#8996).
312
f514f6f0
FP
3132012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
314
e8fc049f 315 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 316
bf43fa51
KH
3172012-03-25 Kenichi Handa <handa@m17n.org>
318
319 * dispextern.h (struct glyph): Change the bit length of
320 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
321
8a0c01dd
EZ
3222012-03-24 Eli Zaretskii <eliz@gnu.org>
323
324 * s/ms-w32.h (tzname): Include time.h before redirecting to
325 _tzname. Fixes the MSVC build. (Bug#9960)
326
7d1c3a76
AS
3272012-03-24 Andreas Schwab <schwab@linux-m68k.org>
328
8ed79523
AS
329 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
330 characters.
331
7d1c3a76
AS
332 * xterm.c (XTread_socket): Only modify handling_signal if
333 !SYNC_INPUT. (Bug#11080)
334
e99a9b8b
EZ
3352012-03-23 Eli Zaretskii <eliz@gnu.org>
336
337 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
338 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
339 when fetching a multibyte character consumes more bytes than
340 CHAR_BYTES returns, due to unification of CJK characters in
341 string_char. (Bug#11073)
342
5063c0e1
TN
3432012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
344
345 * process.c (wait_reading_process_output): Handle pty disconnect
346 by refraining from sending oneself a SIGCHLD (bug#10933).
347
9f851fbd
CY
3482012-03-22 Chong Yidong <cyd@gnu.org>
349
350 * dispextern.h (struct it): New member string_from_prefix_prop_p.
351
5063c0e1 352 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
353 Mark string as coming from a prefix property.
354 (handle_face_prop): Use default face for prefix strings (Bug#4281).
355 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
356
fb5b8aca
CY
3572012-03-21 Chong Yidong <cyd@gnu.org>
358
359 * xfaces.c (Vface_remapping_alist): Doc fix.
360
62356a1b
EZ
3612012-03-20 Eli Zaretskii <eliz@gnu.org>
362
363 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
364 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
365 Doc fixes.
62356a1b 366
025de85b
CY
3672012-03-20 Chong Yidong <cyd@gnu.org>
368
369 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
370 to reflect default non-nil value of redisplay-dont-pause.
371
4827f94e
KH
3722012-03-19 Kenichi Handa <handa@m17n.org>
373
374 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
375 it fit in a valid range (Bug#11003).
376
e50a24a2
EZ
3772012-03-18 Eli Zaretskii <eliz@gnu.org>
378
379 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
380 that is not from display property, accept the row as a "cursor
381 row" if one of the string's character has a non-nil `cursor'
382 property. Fixes cursor positioning when there are newlines in
383 overlay strings, e.g. in icomplete.el. (Bug#11035)
384
9af5ed87
PE
3852012-03-12 Paul Eggert <eggert@cs.ucla.edu>
386
387 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
388
d1f55f16
CY
3892012-03-12 Chong Yidong <cyd@gnu.org>
390
391 * eval.c (inhibit_lisp_code): Rename from
392 inhibit_window_configuration_change_hook; move from window.c.
393
394 * xfns.c (unwind_create_frame_1, Fx_create_frame):
395 * window.c (run_window_configuration_change_hook)
396 (syms_of_window): Callers changed.
397
66c5eebd
CY
3982012-03-11 Chong Yidong <cyd@gnu.org>
399
413df973
CY
400 * keymap.c (Fkey_description): Doc fix (Bug#9700).
401
66c5eebd
CY
402 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
403
1de11f56
CY
4042012-03-10 Chong Yidong <cyd@gnu.org>
405
406 * frame.c (other_visible_frames): Don't assume the selected frame
407 is visible (Bug#10955).
408
cae07000
SM
4092012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
410
411 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
412
89c94350
JD
4132012-03-08 Jan Djärv <jan.h.d@swipnet.se>
414
415 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
416 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
417 zero (Bug#10954).
418
999dd333
GM
4192012-03-03 Glenn Morris <rgm@gnu.org>
420
01a6dcc8 421 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 422
de0100f2
EZ
4232012-03-02 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
426 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
427 (redisplay_window, next_element_from_string): Fix typos in
428 comments.
3e441275
EZ
429 (redisplay_window): Pass to move_it_vertically the margin in
430 pixels, not in screen lines.
de0100f2 431
96a72ee9
GM
4322012-03-02 Glenn Morris <rgm@gnu.org>
433
434 * buffer.c (buffer-list-update-hook): Doc fix.
435
312508d7
EZ
4362012-02-29 Eli Zaretskii <eliz@gnu.org>
437
438 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
439 push_it before setting up the iterator for the first overlay
440 string, even if we have an empty string loaded.
441 (next_overlay_string): If there's an empty string on the iterator
442 stack, pop the stack. (Bug#10903)
443
27f3c637
PE
4442012-02-25 Paul Eggert <eggert@cs.ucla.edu>
445
446 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
447 Suggested by Stefan Monnier in
448 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
449 * alloc.c (widen_to_Lisp_Object): New static function.
450 (mark_memory): Also mark Lisp_Objects by fetching pointer words
451 and widening them to Lisp_Objects. This would work even if
452 USE_LSB_TAG is defined and wide integers are used, which might
453 happen in a future version of Emacs.
454
3c9dfce6
CY
4552012-02-25 Chong Yidong <cyd@gnu.org>
456
fa74b241
CY
457 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
458 Doc fix.
459
3c9dfce6
CY
460 * xselect.c (Fx_selection_exists_p): Doc fix.
461 (x_clipboard_manager_save_all): Print an informative message
462 before saving to clipboard manager.
463
9486df08
CY
4642012-02-24 Chong Yidong <cyd@gnu.org>
465
466 * keyboard.c (process_special_events): Handle all X selection
467 requests in kbd_buffer, not just the next one (Bug#8869).
468
f01d3321
CY
4692012-02-23 Chong Yidong <cyd@gnu.org>
470
471 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
472 call when setting menu-bar-lines and tool-bar-lines parameters.
473 (unwind_create_frame_1): New helper function.
474
475 * window.c (inhibit_window_configuration_change_hook): New var.
476 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 477 (syms_of_window): Initialize it.
f01d3321 478
86b847b6
CY
4792012-02-22 Chong Yidong <cyd@gnu.org>
480
481 * xterm.c (x_draw_image_relief): Add missing type check for
482 Vtool_bar_button_margin (Bug#10743).
483
a59225b1
CY
4842012-02-21 Chong Yidong <cyd@gnu.org>
485
486 * fileio.c (Vfile_name_handler_alist): Doc fix.
487
488 * buffer.c (Fget_file_buffer): Protect against invalid file
489 handler return value.
490
310f5bd4
PE
4912012-02-20 Paul Eggert <eggert@cs.ucla.edu>
492
cb3a28cc
PE
493 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
494 when computing $valmask.
495
310f5bd4
PE
496 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
497 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
498 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
499 It's useless in that case, and it can cause problems on hosts
500 that allocate halves of EMACS_INT values separately.
501 Reported by Dan Horák. Diagnosed by Andreas Schwab in
502 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
503 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
504 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
505 it avoids undefined behavior on hosts where shifting right by more
506 than the word width has undefined behavior.
507
2375c96a
CY
5082012-02-19 Chong Yidong <cyd@gnu.org>
509
510 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
511 (Funhandled_file_name_directory, Ffile_name_as_directory)
512 (Fdirectory_file_name, Fexpand_file_name)
513 (Fsubstitute_in_file_name): Protect against invalid file handler
514 return values (Bug#10845).
515
3eb49e71
EZ
5162012-02-18 Eli Zaretskii <eliz@gnu.org>
517
518 * .gdbinit (pitx): Fix incorrect references to fields of the
519 iterator stack.
520
7b926f3f
CY
5212012-02-17 Chong Yidong <cyd@gnu.org>
522
523 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
524
11273115
PE
5252012-02-15 Paul Eggert <eggert@cs.ucla.edu>
526
527 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
528 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
529
c3a70e2b
CY
5302012-02-15 Chong Yidong <cyd@gnu.org>
531
532 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
533 marked as special. Also, starting docstrings with * is obsolete.
534
0ca43699
AS
5352012-02-13 Andreas Schwab <schwab@linux-m68k.org>
536
537 * gnutls.c (emacs_gnutls_write): Fix last change.
538
2e8f3c56
LI
5392012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
540
541 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
542 send_process.
543
af70074f
SM
5442012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
545
546 * keymap.c (Fsingle_key_description): Handle char ranges.
547
95986d52
CY
5482012-02-12 Chong Yidong <cyd@gnu.org>
549
afd83bd1
CY
550 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
551 as that creates a dangerous corner case.
552
95986d52
CY
553 * window.c (Fdelete_window_internal): Invalidate the mouse
554 highlight (Bug#9904).
555
bd7da63e
GM
5562012-02-12 Glenn Morris <rgm@gnu.org>
557
558 * xselect.c (Fx_own_selection_internal)
559 (Fx_get_selection_internal, Fx_disown_selection_internal)
560 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
561 * nsselect.m (Fx_own_selection_internal)
562 (Fx_disown_selection_internal, Fx_selection_exists_p)
563 (Fx_selection_owner_p, Fx_get_selection_internal):
564 Sync docs and argument specs with the xselect.c versions.
565
77abcbc2
LI
5662012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
567
568 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
569
90b671e2
EZ
5702012-02-11 Eli Zaretskii <eliz@gnu.org>
571
1c0ca0b7
EZ
572 * w32select.c (Fx_selection_exists_p): Sync doc string and
573 argument list with xselect.c. (Bug#10783)
574
575 * w16select.c (Fx_selection_exists_p): Sync doc string and
576 argument list with xselect.c. (Bug#10783)
90b671e2 577
49241268
GM
5782012-02-10 Glenn Morris <rgm@gnu.org>
579
580 * fns.c (Fsecure_hash): Doc fix.
581
f998bbe7 5822012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
583
584 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
585
0992bd9c
CY
5862012-02-07 Chong Yidong <cyd@gnu.org>
587
588 * buffer.c (Fbuffer_local_variables)
589 (buffer_lisp_local_variables): Handle unbound vars correctly;
590 don't let Qunbound leak into Lisp.
591
af008560
GM
5922012-02-07 Glenn Morris <rgm@gnu.org>
593
dd605cc4
GM
594 * image.c (Fimagemagick_types): Doc fix.
595
af008560
GM
596 * image.c (imagemagick-render-type): Change it from a lisp object
597 to an integer. Move the doc here from the lisp manual.
598 Treat all values not equal to 0 the same.
599
1449fa1d
CY
6002012-02-06 Chong Yidong <cyd@gnu.org>
601
602 * doc.c (store_function_docstring): Avoid applying docstring of
603 alias to base function (Bug#2603).
604
3723ec07
AS
6052012-02-04 Andreas Schwab <schwab@linux-m68k.org>
606
607 * .gdbinit (pp1, pv1): Remove redundant defines.
608 (pr): Use pp.
609
79c1cc1e
CY
6102012-02-04 Chong Yidong <cyd@gnu.org>
611
612 * nsterm.m: Declare a global (Bug#10694).
613
d7f29f8e
EZ
6142012-02-04 Eli Zaretskii <eliz@gnu.org>
615
cae07000
SM
616 * w32.c (get_emacs_configuration_options):
617 Include --enable-checking, if specified, in the return value.
d7f29f8e 618
3b95a6f9
MR
6192012-02-04 Martin Rudalics <rudalics@gmx.at>
620
621 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
622 after rounding frame sizes. (Bug#9723)
623
d6fa96a6
EZ
6242012-02-04 Eli Zaretskii <eliz@gnu.org>
625
626 * keyboard.c (adjust_point_for_property): Don't position point
627 before BEGV. (Bug#10696)
628
df0b2940
PE
6292012-02-03 Paul Eggert <eggert@cs.ucla.edu>
630
631 Handle overflow when computing char display width (Bug#9496).
632 * character.c (char_width): Return EMACS_INT, not int.
633 (char_width, c_string_width): Check for overflow when
634 computing the width; this is possible now that individual
635 characters can have unbounded width. Problem introduced
636 by merge from Emacs 23 on 2012-01-19.
637
6bee44d6
MA
6382012-02-02 Michael Albinus <michael.albinus@gmx.de>
639
640 * dbusbind.c (Fdbus_register_method): Mention the return value
641 :ignore in the docstring.
642
44f92739
GM
6432012-02-02 Glenn Morris <rgm@gnu.org>
644
1b9f60cc
GM
645 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
646
44f92739
GM
647 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
648 Unconditionally set to t. (Bug#10673)
649 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
650 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
651 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
652
c5d3843c
KH
6532012-02-02 Kenichi Handa <handa@m17n.org>
654
655 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
656 0, do not call append_composite_glyph.
657
159462d4 6582012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
659
660 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
661 NULL (Bug#6988).
662 (x_produce_glyphs): If the component of a composition is a null
663 string, set it->pixel_width to 1 to avoid zero-width glyph.
664
78cef877
EZ
6652012-02-01 Eli Zaretskii <eliz@gnu.org>
666
667 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
668 first 2 arguments are identical. This makes inserting large
669 output from a subprocess an order of magnitude faster on
670 MS-Windows, where all sbrk'ed memory is always contiguous.
671
97897668
GM
6722012-01-31 Glenn Morris <rgm@gnu.org>
673
674 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 675 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
676 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
677
31fd3586
GM
6782012-01-29 Glenn Morris <rgm@gnu.org>
679
680 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
681
0e24a8b2
CY
6822012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
683
684 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
685
cc0adcb0
CY
6862012-01-28 Chong Yidong <cyd@gnu.org>
687
688 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
689
acc28cb9
CY
6902012-01-26 Chong Yidong <cyd@gnu.org>
691
9c69cfb7
CY
692 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
693
acc28cb9
CY
694 * search.c (Fsearch_forward, Fsearch_backward): Document negative
695 repeat counts (Bug#10507).
696
48da7392
GM
6972012-01-26 Glenn Morris <rgm@gnu.org>
698
699 * lread.c (syms_of_lread): Doc fix.
700
14af5f7f
CY
7012012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
702
703 * coding.c (encode_designation_at_bol): Change return value to
704 EMACS_INT.
705
0b21c100
CY
7062012-01-25 Chong Yidong <cyd@gnu.org>
707
708 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
709
3c2907f7
CY
7102012-01-21 Chong Yidong <cyd@gnu.org>
711
712 * floatfns.c (Fcopysign): Make the second argument non-optional,
713 since nil is not allowed anyway.
714
959ad23f
AS
7152012-01-21 Andreas Schwab <schwab@linux-m68k.org>
716
717 * process.c (read_process_output): Use p instead of XPROCESS (proc).
718 (send_process): Likewise.
719
34a02f46
MR
7202012-01-19 Martin Rudalics <rudalics@gmx.at>
721
722 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
723 (Vwindow_persistent_parameters): Do not use Qstate.
724 Rewrite doc-strings.
34a02f46 725
1259009a 7262012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
727
728 * character.c (char_width): New function.
70d4fdf6
GM
729 (Fchar_width, c_string_width, lisp_string_width):
730 Use char_width (Bug#9496).
25ed9e61 731
6a6ee00d
MR
7322012-01-16 Martin Rudalics <rudalics@gmx.at>
733
734 * window.c (Vwindow_persistent_parameters): New variable.
735 (Fset_window_configuration, save_window_save): Handle persistent
736 window parameters.
737
c85efaf7
EZ
7382012-01-14 Eli Zaretskii <eliz@gnu.org>
739
740 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
741 thrashing the stack of the thread. (Bug#9087)
742
5944709e
PE
7432012-01-12 Paul Eggert <eggert@cs.ucla.edu>
744
745 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
746
e71f5d99
EZ
7472012-01-11 Eli Zaretskii <eliz@gnu.org>
748
749 * xdisp.c (rows_from_pos_range): Handle the case where the
750 highlight ends on a newline. (Bug#10464)
751 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
752 he end column for display of highlight that ends on a newline
753 before a R2L line.
754
ce316182
GM
7552012-01-11 Glenn Morris <rgm@gnu.org>
756
757 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
758 from load-path also when installation-directory is nil. (Bug#10208)
759
5b43da69
GM
7602012-01-10 Glenn Morris <rgm@gnu.org>
761
74cc8ff9
GM
762 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
763
7d8d6e4e
GM
764 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
765 Update template values to be closer to their typical values these days.
5b43da69 766
a0db8d43
EZ
7672012-01-09 Eli Zaretskii <eliz@gnu.org>
768
769 * xdisp.c (rows_from_pos_range): Accept additional argument
770 DISP_STRING, and accept any glyph in a row whose object is that
771 string as eligible for mouse highlight. Fixes mouse highlight of
772 display strings from overlays. (Bug#10464)
773
9a0115ab 7742012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 775
b9110d6a 776 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
777 * fileio.c (auto_saving_dir_umask): New static var.
778 (Fmake_directory_internal): Use it.
779 (do_auto_save_make_dir): Set it, instead of invoking chmod after
780 creating the directory. The old code temporarily assigns
781 too-generous permissions to the directory.
782 (do_auto_save_eh): Clear it.
b9110d6a 783 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
784 that the var is always cleared.
785
6c1bd3f3
EZ
7862012-01-07 Eli Zaretskii <eliz@gnu.org>
787
788 * search.c (scan_buffer): Pass character positions to
789 know_region_cache, not byte positions. (Bug#6540)
790
069d2b50
L
7912012-01-07 LynX <_LynX@bk.ru> (tiny change)
792
793 * w32.c (sys_rename): Report EXDEV when rename of a directory
794 fails because the target is on another logical disk. (Bug#10284)
795
75bf0d33
DB
7962012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
797
798 * xterm.c (x_embed_request_focus): New function.
799
800 * xterm.h: Add prototype.
801
802 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
803
1c6e5a32
GM
8042012-01-05 Glenn Morris <rgm@gnu.org>
805
806 * emacs.c (emacs_copyright): Update short copyright year to 2012.
807
651e947e
EZ
8082012-01-01 Eli Zaretskii <eliz@gnu.org>
809
810 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
811 Load gnutls_transport_set_lowat only if GnuTLS version is below
812 2.11.1.
813 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
814 GnuTLS versions below 2.11.1.
815
3778cdd8
AL
8162011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
817
818 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
819 to the doc string advising against its use for altering the way
820 windows are scrolled.
821
0e5317f7
KH
8222011-12-28 Kenichi Handa <handa@m17n.org>
823
824 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
825 coding-system ASCII compatible only when it does not produce BOM
826 on encoding (Bug#10383).
827
93d5ca1f
JD
8282011-12-26 Jan Djärv <jan.h.d@swipnet.se>
829
830 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
831 can scroll.
832 (create_and_show_popup_menu): Always use menu_position_func for
833 Gtk3 (Bug#10361).
834
ca22b785
AS
8352011-12-24 Andreas Schwab <schwab@linux-m68k.org>
836
837 * callint.c (Fcall_interactively): Don't truncate prompt string.
838
d048e1e6
EZ
8392011-12-23 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
842 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 843 resumed from there (after widening). (Bug#10360)
d048e1e6 844
5ccaba1f
JD
8452011-12-22 Jan Djärv <jan.h.d@swipnet.se>
846
847 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
848
204ee57f
JD
8492011-12-21 Jan Djärv <jan.h.d@swipnet.se>
850
b81d40f0
JB
851 * nsterm.m (x_free_frame_resources):
852 Release f->output_data.ns->miniimage.
204ee57f
JD
853 (ns_index_color): Fix indentation. Do not retain
854 color_table->colors[i].
855
856 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
857 before returning.
858
859 * nsfns.m (x_set_background_color): Assign return value from
860 ns_index_color to face-background instead of NSColor*.
861 (ns_implicitly_set_icon_type): Fix indentation.
862 Change assignment in for loop to comparison.
863
864 * emacs.c (ns_pool): New variable.
865 (main): Assign ns_pool.
866 (Fkill_emacs): Call ns_release_autorelease_pool.
867
868 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
869 autorelease fdesc, release fdAttrs and tdict.
870 (ns_get_covering_families): Release charset.
871 (ns_findfonts): Release NSFontDescriptor created with new.
872 (ns_uni_to_glyphs): Fix indentation.
873 (setString): Release attrStr before assigning new value.
874
c803b2b7
JD
8752011-12-18 Jan Djärv <jan.h.d@swipnet.se>
876
678f4426
JD
877 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
878 and NS_IMPL_COCOA.
879 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
880 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
881
cd394be1 8822011-12-18 David Reitter <reitter@cmu.edu>
678f4426 883
5fecd5fc
JD
884 * nsterm.m (ns_term_init): Subscribe for notifications
885 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
886 to method trackingNotification in EmacsMenu.
887
888 * nsmenu.m (trackingMenu): New variable.
3771cb17 889 (trackingNotification): New method (from Aquamacs).
5fecd5fc 890 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 891 from Aquamacs (Bug#7030).
678f4426
JD
892
8932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 894
c803b2b7
JD
895 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
896 (symbol_to_nsstring): Fix indentation.
897 (ns_symbol_to_pb): New function.
cae07000
SM
898 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
899 (Fns_rotate_cut_buffers_internal): Remove.
900 (Fns_store_selection_internal): Rename from
c803b2b7
JD
901 Fns_store_cut_buffer_internal.
902 (ns_get_foreign_selection, Fx_own_selection_internal)
903 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
904 (Fns_get_selection_internal, Fns_store_selection_internal):
905 Use ns_symbol_to_pb and check if return value is nil.
906 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
907 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
908 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
909 renamed to Sns_store_selection_internal.
910 (ns_handle_selection_request): Move code to Fx_own_selection_internal
911 and remove this function.
912 (ns_handle_selection_clear): Remove, never used.
913 (Fx_own_selection_internal): Move code from ns_handle_selection_request
914 here.
915
e1b01a3a
KB
9162011-12-17 Ken Brown <kbrown@cornell.edu>
917
918 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
919 GID is unknown (Bug#10257).
920
2adb6e85
PE
9212011-12-17 Paul Eggert <eggert@cs.ucla.edu>
922
923 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
924 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
925 which caused a build failure on GNU/Linux IA-64. This problem was
926 introduced by my 2011-10-07 patch.
927
d1d7b339
JL
9282011-12-15 Juri Linkov <juri@jurta.org>
929
930 * image.c (imagemagick_error): New function. (Bug#10112)
931 (imagemagick_load_image): Comment out `MagickSetResolution' call.
932 Use `imagemagick_error' where ImageMagick functions return
933 `MagickFalse'.
934 (Fimagemagick_types): Add `Fnreverse' to return the list in the
935 proper order.
936
100d5755
KH
9372011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
938
939 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
940 fill background (Bug#8992).
941
454592a6
MR
9422011-12-13 Martin Rudalics <rudalics@gmx.at>
943
944 * window.c (Vwindow_combination_resize)
945 (Vwindow_combination_limit): Use t instead of non-nil in
946 doc-strings.
61d4b438
MR
947 (Vrecenter_redisplay): Add first sentence of doc-string on
948 separate line.
53524d93 949 (Frecenter): Fix doc-string typo.
454592a6 950
3633e3aa
KH
9512011-12-11 Kenichi Handa <handa@m17n.org>
952
953 * coding.c (Funencodable_char_position): Pay attention to the
954 buffer text relocation (Bug#9389).
955
7b9d523a
JD
9562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
957
958 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
959 gtk_init (Bug#10100).
960
b73189c6
EZ
9612011-12-10 Eli Zaretskii <eliz@gnu.org>
962
963 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
964 IT->string is nil. (Bug#10263)
965
f7dfe5d6
JD
9662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
967
83faebb4
JD
968 * nsterm.h (x_free_frame_resources): Declare.
969
f7dfe5d6
JD
970 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
971 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
972
973 * nsterm.h (ns_get_defaults_value): Declare.
974
975 * nsterm.m (ns_default): Call ns_get_defaults_value.
976
7cd4e72c
EZ
9772011-12-09 Eli Zaretskii <eliz@gnu.org>
978
979 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
980 (Bug#10170)
981
b34d7317
YM
9822011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
983
984 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
985 that where the value of an _OBJC_* symbol points to is in the .bss
986 section (Bug#10240).
987
76470ad1
KH
9882011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
989
990 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 991 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 992
745fff94
KH
9932011-12-08 Kenichi Handa <handa@m17n.org>
994
995 * ftfont.c (get_adstyle_property): Fix previous change
996 (Bug#10233).
997
6e44397c
JB
9982011-12-07 Juanma Barranquero <lekktu@gmail.com>
999
1000 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1001 dirs from the default value of EMACSLOADPATH (bug#10208).
1002
7efa6272
GM
10032011-12-07 Glenn Morris <rgm@gnu.org>
1004
1005 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1006 installation and source directories as well. (Bug#10208)
1007
f6fc4d87
CY
10082011-12-06 Chong Yidong <cyd@gnu.org>
1009
1010 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1011
2bf26180
GM
10122011-12-06 Glenn Morris <rgm@gnu.org>
1013
1014 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1015 as an error, not just -1. (Bug#10217)
1016
3a6ad4f0
CY
10172011-12-05 Chong Yidong <cyd@gnu.org>
1018
1019 * keyboard.c (process_special_events): New function.
1020 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1021
75a3b399
PE
10222011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * coding.c (encode_designation_at_bol): Don't use uninitialized
1025 local variable (Bug#9318).
1026
c3c9e25e
KH
10272011-12-05 Kenichi Handa <handa@m17n.org>
1028
1029 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1030 return Qnil (Bug#8046, Bug#10193).
1031
5eb05ea3
KH
10322011-12-05 Kenichi Handa <handa@m17n.org>
1033
1034 * coding.c (encode_designation_at_bol): New args charbuf_end and
1035 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1036 (coding_set_source): Return how many bytes coding->source was
1037 relocated.
1038 (coding_set_destination): Return how many bytes
1039 coding->destination was relocated.
1040 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1041 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1042
10432011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1044
1045 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1046 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1047 macro (Bug#9318).
1048
10492011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1050
1051 The following changes are to fix Bug#9318.
1052
a79703f5 1053 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1054 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1055 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1056 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1057
7dbda6df
JB
10582011-12-05 Juanma Barranquero <lekktu@gmail.com>
1059
1060 * lisp.h (process_quit_flag): Fix external declaration.
1061
6d5eb5b0
SM
10622011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1063
1064 Don't macro-inline non-performance-critical code.
1065 * eval.c (process_quit_flag): New function.
1066 * lisp.h (QUIT): Use it.
1067
a0c3fad0
JD
10682011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1069
1070 * nsfns.m (get_geometry_from_preferences): New function.
1071 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1072
6c07aac2
AS
10732011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1074
1075 * emacs.c (Qkill_emacs): Define.
1076 (syms_of_emacs): Initialize it.
1077 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1078 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1079 (quit_throw_to_read_char): Add parameter `from_signal'.
1080 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1081 * lisp.h (QUIT): Call Fkill_emacs if requested.
1082
c052ead4
JD
10832011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1084
1085 * widget.c (update_wm_hints): Return if wmshell is null.
1086 (widget_update_wm_size_hints): New function.
1087
1088 * widget.h (widget_update_wm_size_hints): Declare.
1089
1090 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1091 widget_update_wm_size_hints (Bug#10104).
1092
9e49252b
EZ
10932011-12-03 Eli Zaretskii <eliz@gnu.org>
1094
1095 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1096 before a newline, prepare the bidi iterator for consuming the
1097 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1098 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1099
02b16839
JL
11002011-12-02 Juri Linkov <juri@jurta.org>
1101
1102 * search.c (Fword_search_regexp): New Lisp function created from
1103 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1104 (Fword_search_backward, Fword_search_forward)
1105 (Fword_search_backward_lax, Fword_search_forward_lax):
1106 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1107 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1108
0068070e
SM
11092011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1110
1111 * fileio.c (Finsert_file_contents): Move after-change-function call
1112 to before the "handled:" label, since all "goto handled" appear in
1113 cases where the *-change-functions have already been properly called
1114 (bug#10117).
1115
3360a3fc
AS
11162011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1117
1118 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1119 waiting for input. (Bug#10169)
1120
73d6c093
EZ
11212011-11-30 Eli Zaretskii <eliz@gnu.org>
1122
1123 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1124 verifies glyph row's hash code--we have just reallocated the
1125 glyphs, so their contents can be complete garbage. (Bug#10164)
1126
febe6bea
JB
11272011-11-30 Juanma Barranquero <lekktu@gmail.com>
1128
1129 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1130
801a4313
EZ
11312011-11-30 Eli Zaretskii <eliz@gnu.org>
1132
1133 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1134 attributes are tested _before_ calling verify_row_hash, to protect
1135 against GCC re-ordering of the tests. (Bug#10164)
1136
2b56b87e
JD
11372011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1138
1139 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1140
1141 * xterm.c (handle_one_xevent): Only set async_visible and friends
1142 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1143 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1144 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1145
dbf31225
PE
11462011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1149 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1150 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1151 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1152 All uses changed to use GCPRO1 etc.
1153 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1154 Revert to old implementation (i.e., before 2011-03-11).
1155
1305621b
YM
11562011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1157
1158 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1159 of scroll runs so as to avoid assigning disabled bogus rows and
1160 unnecessary graphics copy operations.
1161
8c9afb46
EZ
11622011-11-27 Eli Zaretskii <eliz@gnu.org>
1163
1164 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1165 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1166 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1167 (malloc, free, realloc, calloc): Redirect to e_* only when
1168 compiling Emacs.
1169
1170 * lisp.h (GCTYPEBITS): Move before first use.
1171 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1172 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1173 this macro definition.
1174
1175 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1176 _MSC_VER.
1177
54e9e3bf
JD
11782011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1179
6d5eb5b0
SM
1180 * gtkutil.c (xg_create_frame_widgets):
1181 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1182 present with Gtk+ 2.0.
1183
83aca1cb
PE
11842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 * fileio.c (Finsert_file_contents): Undo previous change; see
1187 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1188
5b76caa4
PE
11892011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 Rename locals to avoid shadowing.
1192 * fileio.c (Finsert_file_contents):
1193 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1194 * process.c (wait_reading_process_output):
1195 Rename inner 'proc' to 'p' to avoid shadowing.
1196 Indent for consistency with usual Emacs style.
1197
8c535114
EZ
11982011-11-25 Eli Zaretskii <eliz@gnu.org>
1199
1200 * xdisp.c (redisplay_window): If cursor row is not fully visible
1201 after recentering, and scroll-conservatively is set to a large
1202 number, scroll window by a few more lines to make the cursor fully
1203 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1204 (start_display): Don't move to the next line if the display should
1205 start at a newline that is part of a display vector or an overlay
1206 string. (Bug#10119)
8c535114 1207
fa4fdb5c
JL
12082011-11-24 Juri Linkov <juri@jurta.org>
1209
1210 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1211 after the `MagickPingImage' call. (Bug#10112)
1212
90ec88df
CY
12132011-11-23 Chong Yidong <cyd@gnu.org>
1214
1215 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1216
56e2e794
MR
12172011-11-23 Martin Rudalics <rudalics@gmx.at>
1218
1219 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1220 making another buffer current. (Bug#10114)
1221
b6e64c41
GM
12222011-11-23 Glenn Morris <rgm@gnu.org>
1223
1224 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1225
6b21de18
CY
12262011-11-23 Chong Yidong <cyd@gnu.org>
1227
1228 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1229 using it (Bug#5984).
1230
b12cd789
EZ
12312011-11-22 Eli Zaretskii <eliz@gnu.org>
1232
1233 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1234 and header-lines, as they don't have one computed for them.
1235 (Bug#10098)
1236
1237 * .gdbinit (prow): Make displayed values more self-explaining.
1238 Add row's hash code.
1239
261b6fd4
LMI
12402011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1241
1242 * process.c (wait_reading_process_output): Fix asynchrounous
1243 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1244 (wait_reading_process_output): Add comment and URL.
261b6fd4 1245
e7cfd277
JD
12462011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1247
1248 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1249
a9b9b7f5
CY
12502011-11-21 Chong Yidong <cyd@gnu.org>
1251
1252 * window.c (Fnext_window, Fprevious_window): Doc fix.
1253
b0d15b4f
SM
12542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1255
1256 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1257
fe7a3057
JB
12582011-11-20 Juanma Barranquero <lekktu@gmail.com>
1259
1260 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1261
d2999b1a
MR
12622011-11-20 Martin Rudalics <rudalics@gmx.at>
1263
1264 * window.c (Fset_window_combination_limit): Rename argument
1265 STATUS to LIMIT.
1266 (Vwindow_combination_limit): Remove "status" from doc-string.
1267
d5ff9cd0
AS
12682011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1269
1270 * m/ibms390.h: Remove.
1271 * m/ibms390x.h: Don't include "ibms390.h".
1272
a5bb9bd3
SM
12732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1274
1275 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1276 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1277
cd1181db
JB
12782011-11-20 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * casetab.c (Fset_case_table):
1281 * charset.c (Fcharset_after): Fix typos.
1282
615a3b8d 12832011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1284
17e845af
PE
1285 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1286 Otherwise, valgrind does not work on some platforms.
1287 Problem reported by Andreas Schwab in
6a0bf43d
PE
1288 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1289 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1290 is set, removing the need for VIRT_ADDRESS_VARIES.
1291 (PURE_P): Use a more-efficient implementation that needs just one
1292 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1293 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1294 to 4 (xorl, subq, cmpq, setbe).
1295 * alloc.c (pure): Always extern now, since that's the
1296 VIRT_ADDR_VARIES behavior.
1297 (PURE_POINTER_P): Use a single comparison, not two, for
1298 consistency with the new puresize.h.
1299 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1300 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1301 Remove VIRT_ADDR_VARIES no longer needed.
1302
f8fe6f96
EZ
13032011-11-19 Eli Zaretskii <eliz@gnu.org>
1304
1305 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1306 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1307 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1308 behave as if the cursor position were at the window margin.
1309
1310 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1311 and the cursor position is out of bounds, behave as if the cursor
1312 position were at the window margin. (Bug#10075)
1313
df05a53c
CY
13142011-11-18 Chong Yidong <cyd@gnu.org>
1315
1316 * window.c (Fwindow_combination_limit): Make first argument
1317 non-optional, since it is meaningless for live windows like the
1318 selected window.
1319
2071918e
DA
13202011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1321
1322 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1323
b50a28de
SM
13242011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1325
1326 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1327 (graft_intervals_into_buffer): Simplify.
1328
015137db
EZ
13292011-11-18 Eli Zaretskii <eliz@gnu.org>
1330
1331 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1332 hash values of the two rows.
1333 (copy_row_except_pointers): Preserve the used[] arrays and the
1334 hash values of the two rows. (Bug#10035)
68c95424 1335 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1336
1337 * xdisp.c (row_hash): New function, body extracted from
1338 compute_line_metrics.
1339 (compute_line_metrics): Call row_hash, instead of computing the
1340 hash code inline.
1341
1342 * dispnew.c (verify_row_hash): Call row_hash for computing the
1343 hash code of a row, instead of duplicating code from xdisp.c.
1344
1345 * dispextern.h (row_hash): Add prototype.
1346
a2addb04
TH
13472011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1348
1349 * frame.c (delete_frame): Don't delete the terminal when the last
1350 X frame is closed if emacs is built with GTK toolkit.
1351
df85d315
JB
13522011-11-17 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1355
a0c2d0ae
MR
13562011-11-17 Martin Rudalics <rudalics@gmx.at>
1357
1358 * window.c (Vwindow_splits): Rename to
1359 Vwindow_combination_resize. Suggested by Juri Linkov.
1360 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1361 of Vwindow_splits.
1362
58179cce
JB
13632011-11-16 Juanma Barranquero <lekktu@gmail.com>
1364
7877f373
JB
1365 * nsfns.m (Fns_font_name):
1366 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1367
b6f67890
MR
13682011-11-16 Martin Rudalics <rudalics@gmx.at>
1369
1370 * window.h (window): Rename slot "nest" to "combination_limit".
1371 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1372 (Fset_window_nest): Rename to Fset_window_combination_limit.
1373 (Vwindow_nest): Rename to Vwindow_combination_limit.
1374 (recombine_windows, make_parent_window, make_window)
1375 (Fsplit_window_internal, saved_window)
1376 (Fset_window_configuration, save_window_save): Rename all
1377 occurrences of window_nest to window_combination_limit.
1378
c7015153
JB
13792011-11-15 Juanma Barranquero <lekktu@gmail.com>
1380
1381 * image.c (imagemagick_load_image): Fix typo.
1382
322ad6ec
EZ
13832011-11-14 Eli Zaretskii <eliz@gnu.org>
1384
1385 * xdisp.c (display_line): Move the call to
1386 highlight_trailing_whitespace before the call to
1387 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1388 faces of all the glyphs to compute ROW's hash value.
1389 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1390
f067b8ec
JB
13912011-11-14 Juanma Barranquero <lekktu@gmail.com>
1392
1393 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1394 just return (bug#10044).
1395
1e5b2111
EZ
13962011-11-12 Eli Zaretskii <eliz@gnu.org>
1397
7ef3cbd5
EZ
1398 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1399 with user-defined heap size. Bump the default size of the temacs
1400 heap to 27MB, to avoid memory warning when running temacs.
1401 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1402
1e5b2111
EZ
1403 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1404 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1405 (verify_row_hash) [XASSERTS]: New function.
1406 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1407 that the hash value of glyph rows is correct.
1e5b2111 1408
89d61221
MR
14092011-11-12 Martin Rudalics <rudalics@gmx.at>
1410
1411 * window.h (window): Remove splits slot.
1412 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1413 (Fdelete_other_windows_internal, make_parent_window)
1414 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1415 (Fset_window_configuration, save_window_save): Don't deal with
1416 split status of windows.
1417 (saved_window): Remove splits slot.
1418 (Vwindow_splits): Rewrite doc-string.
1419
97f18cc8
JD
14202011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1421
1422 * xfns.c (unwind_create_frame):
1423 * nsfns.m (unwind_create_frame):
1424 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1425 Vframe_list (Bug#9999).
1426
22a648b4
DA
14272011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1428
0b381c7e 1429 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1430
659afede
KH
14312011-11-11 Kenichi Handa <handa@m17n.org>
1432
1433 * callproc.c (Fcall_process): Set the member dst_multibyte of
1434 process_coding.
1435
9ac0394b
KH
14362011-11-11 Johan Bockgård <bojohan@gnu.org>
1437
1438 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1439 avoid a crash (bug#9496).
1440
2fbdc249
CY
14412011-11-09 Chong Yidong <cyd@gnu.org>
1442
1443 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1444 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1445
ac6b1f81
PE
14462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1449
09db192c
PE
14502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 Avoid some portability problems by eschewing 'extern inline' functions.
1453 The trivial performance wins aren't worth the portability hassles; see
1454 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1455 et seq.
1456 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1457 (window_box_width, window_box_left, window_box_left_offset)
1458 (window_box_right, window_box_right_offset): Undo previous change,
1459 by removing the "extern"s.
1460 * intervals.c (adjust_intervals_for_insertion)
1461 (adjust_intervals_for_deletion): Undo previous change,
1462 making these static again.
1463 (offset_intervals, temp_set_point_both, temp_set_point)
1464 (copy_intervals_to_string): No longer inline.
1465 * xdisp.c (window_text_bottom_y, window_box_width)
1466 (window_box_height, window_box_left_offset)
1467 (window_box_right_offset, window_box_left, window_box_right)
1468 (window_box): No longer inline.
1469
105216ed
CY
14702011-11-08 Chong Yidong <cyd@gnu.org>
1471
1472 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1473 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1474 Signal an error if not a live window.
105216ed
CY
1475 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1476 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1477
ae9e237f
JB
14782011-11-07 Juanma Barranquero <lekktu@gmail.com>
1479
1480 * lisp.h (syms_of_abbrev): Remove declaration.
1481 Reported by CHENG Gao <chenggao@royau.me>.
1482
c7aa8333
EZ
14832011-11-07 Eli Zaretskii <eliz@gnu.org>
1484
1485 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1486 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1487 of temacs in GUI mode.
1488
be7f5545
MR
14892011-11-07 Martin Rudalics <rudalics@gmx.at>
1490
1491 * window.h: Declare delete_all_child_windows instead of
1492 delete_all_subwindows.
1493 * window.c (Fwindow_nest, Fset_window_nest)
1494 (Fset_window_new_total, Fset_window_new_normal)
1495 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1496 (delete_all_subwindows): Rename to delete_all_child_windows.
1497 (Fdelete_other_windows_internal, Fset_window_configuration):
1498 Call delete_all_child_windows instead of delete_all_subwindows.
1499 * frame.c (delete_frame): Call delete_all_child_windows instead
1500 of delete_all_subwindows.
1501
ca78dc43
PE
15022011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1505 This is also needed for porting to any host where GC_MARK_STACK is
1506 not GC_MAKE_GCPROS_NOOPS.
1507 (which_symbols): Use it.
1508
a0241d01
KH
15092011-11-07 Kenichi Handa <handa@m17n.org>
1510
1511 * coding.c (coding_set_destination): Check coding->src_pos only
1512 when coding->src_object is a buffer (bug#9910).
1513
1514 * process.c (send_process): Set the member src_multibyte of coding
1515 to 0 (bug#9911) when sending a unibyte text.
1516
1517 * callproc.c (Fcall_process): Set the member src_multibyte of
1518 process_coding to 0 (bug#9912).
1519
a64bfdfa 15202011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1521
1522 * xmenu.c (cleanup_widget_value_tree): New function.
1523 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1524 calling free_menubar_widget_value_tree directly (Bug#9830).
1525
cb41b32a
PE
15262011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 Fix some portability problems with 'inline'.
1529 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1530 (window_box_width, window_box_left, window_box_left_offset)
1531 (window_box_right, window_box_right_offset): Declare extern.
1532 Otherwise, these inline functions do not conform to C99 and
1533 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1534 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1535 * intervals.c (adjust_intervals_for_insertion)
1536 (adjust_intervals_for_deletion): Now extern, because otherwise the
1537 extern inline functions 'offset_intervals' couldn't refer to it.
1538 (static_offset_intervals): Remove.
1539 (offset_intervals): Rewrite using the old contents of
1540 static_offset_intervals. The old version didn't conform to C99
1541 because an extern inline function contained a reference to an
1542 identifier with static linkage.
1543
b7041366
AS
15442011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1545
1546 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1547 GC.
1548
88a37c4d
EZ
15492011-11-06 Eli Zaretskii <eliz@gnu.org>
1550
1551 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1552 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1553 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1554 return Qleft_to_right.
1555
49745b39
CY
15562011-11-06 Chong Yidong <cyd@gnu.org>
1557
1558 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1559 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1560 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1561 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1562 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1563 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1564 (Fwindow_vscroll): Doc fix.
1565 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1566 argument, since it makes no sense to pass a live window and for
1567 consistency with window-child.
1568
1f05cd82
CS
15692011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1570
1571 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1572 support MSVC.
1573
22610910
JR
15742011-11-05 Jason Rumney <jasonr@gnu.org>
1575
1576 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1577 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1578 fonts (Bug#6029).
1579 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1580 bitwise arithmetic preventing use of unicode-sip and non-truetype
1581 opentype fonts.
1582
a06776b2
EZ
15832011-11-05 Eli Zaretskii <eliz@gnu.org>
1584
3ad924ba
EZ
1585 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1586 "emacs"-only part.
1587
a06776b2
EZ
1588 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1589 initialization code to keep similarity to xfns.c after changes
1590 from 2011-11-05.
1591
c9e7db78
JD
15922011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1593
a97f8f3f
JD
1594 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1595 (unwind_create_frame): New function (Bug#9943).
1596 (Fx_create_frame): Restructure code to be more similar to the one in
1597 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1598 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1599 Move terminal->reference_count++ just before making the frame official
1600 (Bug#9943).
1601
1602 * nsterm.m (x_free_frame_resources): New function.
1603 (x_destroy_window): Move code to x_free_frame_resources.
1604
c9e7db78 1605 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1606 (Fx_create_frame, x_create_tip_frame):
1607 Move terminal->reference_count++ just before making the frame
75f1671a 1608 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1609 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1610
a6fc3b5c
EZ
16112011-11-05 Eli Zaretskii <eliz@gnu.org>
1612
1613 Support MSVC build with newer versions of Visual Studio.
1614 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1615 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1616 nt/gmake.defs.
1617
1618 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1619 which are not supported by MSVC.
1620 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1621 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1622 bitfields.
1623 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1624 types in bitfields.
1625 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1626
1627 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1628
58179cce 16292011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1630
1631 Support MSVC build with newer versions of Visual Studio.
1632 * w32.c: Don't include w32api.h for MSVC.
1633 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1634
1635 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1636 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1637 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1638 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1639 e_* cousins.
1640 (alloca) [_MSC_VER]: Define to _alloca.
1641
1642 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1643
1644 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1645
a58c13ed
EZ
16462011-11-04 Eli Zaretskii <eliz@gnu.org>
1647
1648 * xdisp.c (note_mouse_highlight): If either of
1649 previous/next-single-property-change returns nil, treat that as
1650 the beginning or the end of the buffer. (Bug#9955)
1651
fe0b6370
JD
16522011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1653
a58c13ed 1654 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1655 label is not null (Bug#9951).
1656 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1657 may be NULL.
1658
89bd5ee1
EZ
16592011-11-04 Eli Zaretskii <eliz@gnu.org>
1660
1661 * window.c (Fwindow_body_size): Mention in the doc string that the
1662 return value is in frame's canonical units. (Bug#9949)
1663
84c3edb9
EZ
16642011-11-03 Eli Zaretskii <eliz@gnu.org>
1665
4e2fb5c7
EZ
1666 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1667
84c3edb9 1668 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1669 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1670 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1671
bc17a887
EZ
16722011-11-01 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1675 Don't stop backward scan on the continuation glyph, even though
1676 its CHARPOS is positive.
6d5eb5b0
SM
1677 (mouse_face_from_buffer_pos, note_mouse_highlight):
1678 Rename cover_string to disp_string.
bc17a887 1679
4ee88440
MR
16802011-11-01 Martin Rudalics <rudalics@gmx.at>
1681
1682 * window.c (temp_output_buffer_show): Don't use
1683 Vtemp_buffer_show_specifiers.
1684 (Vtemp_buffer_show_specifiers): Remove unused variable.
1685
c2ff3c02
EZ
16862011-10-30 Eli Zaretskii <eliz@gnu.org>
1687
1688 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1689 past the beginning of the current glyph matrix.
1690
58179cce 16912011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1692
1693 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1694 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1695 HAVE_GTK3 (Bug#9869).
b77a6a7f 1696
3b574623
JD
1697 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1698 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1699
b77a6a7f
JD
1700 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1701
1702 * xterm.c: Declare x_handle_net_wm_state to return int.
1703 (handle_one_xevent): Check if we are iconified but don't have
1704 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1705 (get_current_wm_state): Return non-zero if not hidden,
1706 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1707 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1708 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1709 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1710
196e41e4
PE
17112011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1714 so that this new function doesn't get optimized away by a
1715 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1716
021f2e1a
AS
17172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1718
1719 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1720
8b058d44
EZ
17212011-10-29 Eli Zaretskii <eliz@gnu.org>
1722
1723 Fix the `xbytecode' command.
1724 * .gdbinit (xprintbytestr): New command.
b50a28de 1725 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1726 (xbytecode): Print the byte-code string as well.
1727
4452fb80
EZ
17282011-10-29 Kim Storm <storm@cua.dk>
1729
8b058d44
EZ
1730 * alloc.c (which_symbols): New function.
1731
21b72067
AS
17322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1733
1734 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1735 line. (Bug#9903)
1736
83ed7b5c
GM
17372011-10-29 Glenn Morris <rgm@gnu.org>
1738
1739 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1740 Not clear what it was for, and it causes various bugs. (Bug#9839)
1741
5a7a728b
EZ
17422011-10-28 Eli Zaretskii <eliz@gnu.org>
1743
1744 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1745 possible random value that matches one of those tested as
1746 condition to clear the mouse face.
1747
d3d0842f
CY
17482011-10-28 Chong Yidong <cyd@gnu.org>
1749
1750 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1751
31b39d13
DN
17522011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1753
1754 * window.c (make_window): Initialize phys_cursor_on_p.
1755
9aba6043
SM
17562011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1757
1758 * lisp.h (struct Lisp_Symbol): Update comments.
1759
c20992f4
JB
17602011-10-28 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1763
db4f02f2
EZ
17642011-10-28 Eli Zaretskii <eliz@gnu.org>
1765
1766 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1767 <oslsachem@gmail.com> for helping to debug this.
1768
1769 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1770 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1771 (g_b_init_get_glyph_outline_w): New static variables.
1772 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1773 (GetGlyphOutlineW_Proc): New typedefs.
1774 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1775 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1776 New functions.
1777 (w32font_open_internal, compute_metrics):
1778 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1779 instead of calling the "wide" APIs directly.
1780
1781 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1782
1783 * w32.h (syms_of_w32font): Add prototype.
1784
87e68db4
JB
17852011-10-27 Juanma Barranquero <lekktu@gmail.com>
1786
1787 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1788 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1789 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1790 (Fmove_to_window_line): Doc fix.
1791
435c1d67
CY
17922011-10-27 Chong Yidong <cyd@gnu.org>
1793
1794 * process.c (make_process): Set gnutls_state to NULL.
1795
1796 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1797 non-NULL, regardless of GNUTLS_INITSTAGE.
1798 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1799 an error. Set process slots as soon as we allocate them.
1800
1801 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1802
9c6c6f49
CY
18032011-10-27 Chong Yidong <cyd@gnu.org>
1804
9aba6043
SM
1805 * gnutls.c (emacs_gnutls_deinit): New function.
1806 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1807 (Fgnutls_deinit, Fgnutls_boot): Use it.
1808
1809 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1810 (deactivate_process): Call emacs_gnutls_deinit.
1811
657d08d3
JB
18122011-10-27 Juanma Barranquero <lekktu@gmail.com>
1813
1814 * image.c (x_create_x_image_and_pixmap):
1815 * w32.c (sys_rename, w32_delayed_load):
1816 * w32font.c (fill_in_logfont):
1817 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1818
5430d399
JB
18192011-10-26 Juanma Barranquero <lekktu@gmail.com>
1820
1821 * w32fns.c (w32_default_color_map): New function,
1822 extracted from Fw32_default_color_map.
a7ef684b 1823 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1824
fe0055fa
PE
18252011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1826
1827 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1828
e6346438
SM
18292011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1830
1831 * keyboard.c (test_undefined): New function (bug#9751).
1832 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1833
e112cc37
ET
18342011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1835
1836 * sysdep.c (init_sys_modes): Fix the check for the controlling
1837 terminal (Bug#6649).
1838
7b5d6677
EZ
18392011-10-20 Eli Zaretskii <eliz@gnu.org>
1840
1841 * dispextern.h (struct bidi_it): New member next_en_type.
1842
1843 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1844 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1845 current character, check also for next_en_type being WEAK_EN.
1846 (bidi_resolve_weak): Don't enter the expensive loop if the current
1847 position is before next_en_pos. Record the bidi type of the first
1848 non-ET, non-BN character we find, in addition to its position.
1849 (bidi_level_of_next_char): Invalidate next_en_type when
1850 next_en_pos is over-stepped.
1851
7da0b018
PE
18522011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1855 * editfns.c: Rewrite current-time-zone so that it invokes
1856 the equivalent of (format-time-string "%Z") to get the time zone name.
1857 This fixes a bug when the time zone name contains characters that
1858 need converting from the system time locale to Emacs internal format.
1859 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1860 that patch fixed format-time-string to do the conversion, but
1861 I forgot to fix current-time-zone.
1862 (format_time_string): New function, containing most of
1863 what Fformat_time_string used to contain.
1864 (Fformat_time_string): Rewrite in terms of format_time_string.
1865 This doesn't change this function's behavior.
1866 (current-time-zone): Rewrite to use format_time_string.
1867 This fixes the bug reported by Michael Schierl in
1868 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1869 Jason Rumney's 2007-06-07 change worked around this bug, but
1870 didn't fix it.
1871 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1872
8547b010
EZ
18732011-10-19 Eli Zaretskii <eliz@gnu.org>
1874
1875 * xdisp.c (start_display): If the character at POS is displayed
1876 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1877 (try_window_reusing_current_matrix): If a line ends in a display
1878 vector or the next line starts in a display vector, continue
1879 redrawing the window even though the character position of
1880 start_row was reached.
8547b010
EZ
1881 (Bug#9771, part 2)
1882
4e948d15
CY
18832011-10-18 Chong Yidong <cyd@gnu.org>
1884
1885 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1886 with nobreak-char-display too.
1887
4787455f
EZ
18882011-10-18 Eli Zaretskii <eliz@gnu.org>
1889
1890 Fix part 3 of bug#9771.
1891 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1892 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1893 non-neutral characters if the current character is a paragraph
1894 separator (a.k.a. Newline). This avoids running the same
1895 expensive loop twice, once when we consume the preceding newline
1896 and the other time when the line actually needs to be displayed.
1897 Avoid the loop when we see neutrals on the base embedding level
1898 following a character whose directionality is the same as the
1899 paragraph's. This avoids running the expensive loop when a line
1900 ends in a long sequence of neutrals, like control characters.
1901 Add assertion against STRONG_AL type. Slightly rearrange code
1902 that determines the type of a neutral given the first non-neutral
1903 that follows it.
1904 (bidi_level_of_next_char): Set next_en_pos to zero when
1905 invalidating its info.
1906
2c91f553
EZ
19072011-10-17 Eli Zaretskii <eliz@gnu.org>
1908
1909 * xdisp.c (push_display_prop): Determine whether to record string
1910 or buffer position by IT->string, not by IT->method. Allow
1911 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1912 (move_it_vertically_backward): Don't look for character position
1913 immediately after the newline when in a continuation line.
1914 (Bug#9771, part 1)
2c91f553 1915
c7b08b0d
MR
19162011-10-15 Martin Rudalics <rudalics@gmx.at>
1917
1918 * window.c (coordinates_in_window): Rewrite and delabelize
1919 vertical border check. (Bug#5357) (Bug#9618)
1920
6b02f655
SM
19212011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1922
1923 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1924 errors in XSetWindowBorder (bug#9310).
1925
81d40c92
DA
19262011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1929 avoid crash when xmalloc overrun checking is enabled.
1930
d4172c3b
EZ
19312011-10-13 Eli Zaretskii <eliz@gnu.org>
1932
1933 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1934 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1935 cursor motion with <left> and <right> arrow keys.
1936
1937 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1938 some callers set that themselves.
1939
b00eea75
EZ
19402011-10-12 Eli Zaretskii <eliz@gnu.org>
1941
1942 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1943 display string and the previous row comes from the same string and
1944 is empty. (Bug#9739) (Bug#9738)
1945
8fe012c4
SM
19462011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1947
1948 * doc.c (get_doc_string): Encode file name (bug#9735).
1949
0074aef2
EZ
19502011-10-12 Eli Zaretskii <eliz@gnu.org>
1951
79beb178
EZ
1952 * bidi.c (bidi_level_of_next_char):
1953 * xdisp.c (get_visually_first_element): Remove old incorrect
1954 comments regarding the Unicode Line Separator character.
1955
0074aef2
EZ
1956 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1957
6e4b3fbe
DA
19582011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1959
1960 * alloc.c (Fgc_status): Do not access beyond zombies array
1961 boundary if nzombies > MAX_ZOMBIES.
1962 * alloc.c (dump_zombies): Add missing format specifier.
1963
0324f3af
PE
19642011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1965
b5525cac
PE
1966 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1967 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1968
0324f3af
PE
1969 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1970 Some packages use them to denote characters with modifiers.
1971
e9b5f888
AS
19722011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1973
1974 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1975 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1976 matching a pp-number. Rename parameter var to var1.
1977
127827c0
SM
19782011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1979
1980 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1981
c8fd3bd0
GM
19822011-10-08 Glenn Morris <rgm@gnu.org>
1983
1984 * callint.c (Fcall_interactively): Give a more explicit error for the
1985 'c' case with a non-character input. (Bug#8479)
1986
352ec8ff
EZ
19872011-10-08 Eli Zaretskii <eliz@gnu.org>
1988
03669ccb
EZ
1989 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1990 lines.
7061c986
EZ
1991 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1992 lines that are hscrolled on the left.
03669ccb 1993
352ec8ff
EZ
1994 * dispnew.c (buffer_posn_from_coords): Account for a possible
1995 presence of header-line. (Bug#4426)
1996
a66cfb1c
SM
19972011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1998
6b02f655
SM
1999 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2000 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2001
7c5ee88e
PE
20022011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2005 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2006 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2007 this makes Emacs dump core during garbage collection on rare
2008 occasions. sizeof is obviously inferior to offsetof here, so
2009 stick with offsetof.
2010 (GC_POINTER_ALIGNMENT): New macro.
2011 (mark_memory): Omit 3rd (offset) arg; caller changed.
2012 Don't assume EMACS_INT alignment is the same as pointer alignment.
2013
df1bbe5b
SM
20142011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2015
2016 * keyboard.c (read_key_sequence_remapped): New var.
2017 (read_key_sequence): Compute remapping in the right buffer.
2018 (command_loop_1): Use read_key_sequence's remapping directly.
2019
51553db6
SM
20202011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2021
32c1fffd
SM
2022 * dired.c (file_name_completion): Don't expand file name.
2023 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2024 before checking file name handler.
2025
51553db6
SM
2026 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2027 they've been requested explicitly (bug#9591).
2028
b6bd1599 20292011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2030
2031 * keymap.c (Fsingle_key_description): Use make_specified_string
2032 instead of build_string to build string from push_key_description.
2033 (Bug#5193)
2034
f701dc2a
PE
20352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2036
4222c55d
PE
2037 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2038 This fixes a Y2038 bug on 64-bit hosts.
2039 * buffer.c (reset_buffer):
2040 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2041 (Fclear_buffer_auto_save_failure):
2042 Use 0, not -1, to represent an unset failure time, since time_t
2043 might not be signed.
2044
f701dc2a
PE
2045 Remove dependency on glibc malloc internals.
2046 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2047 Move back here from lisp.h, but with their new implementations.
2048 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2049 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2050 * charset.c (charset_table_init): New static var.
2051 (syms_of_charset): Use it instead of xmalloc. This removes a
2052 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2053 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2054 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2055 Move back to alloc.c.
2056 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2057 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2058
9ceebf39
JD
20592011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2060
2061 * nsterm.m (windowDidResize): Call x_set_window_size only when
2062 ns_in_resize is true. Otherwise set pixelwidth/height and
2063 call change_frame_size (Bug#9628).
2064
cb993c58
PE
20652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2066
3930c88b
PE
2067 Port --enable-checking=all to Fedora 14 x86-64.
2068 * charset.c (syms_of_charset): Also account for glibc malloc's
2069 internal overhead when calculating the initial malloc maximum.
2070
cb993c58
PE
2071 Port --enable-checking=all to Fedora 14 x86.
2072 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2073 Move to lisp.h.
2074 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2075 (overrun_check_realloc, overrun_check_free):
2076 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2077 That way, xmalloc returns a properly-aligned pointer even if
2078 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2079 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2080 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2081 into account when calculating the initial malloc maximum.
2082 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2083 Move here from alloc.c, so that charset.c can use it too.
2084 Properly align; the old code wasn't right for common 32-bit hosts
2085 when configured with --enable-checking=all.
2086 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2087 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2088
31bed486
EZ
20892011-09-29 Eli Zaretskii <eliz@gnu.org>
2090
04c70788 2091 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2092 use EDOM.
2093
fbcaa2f3
EZ
20942011-09-28 Eli Zaretskii <eliz@gnu.org>
2095
2096 * xdisp.c (compute_display_string_end): If there's no display
2097 string at CHARPOS, return -1.
2098
2099 * bidi.c (bidi_fetch_char): When compute_display_string_end
2100 returns a negative value, treat the character as a normal
2101 character not covered by a display string. (Bug#9624)
2102
a239d4e9
JB
21032011-09-28 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * lread.c (Fread_from_string): Fix typo in docstring.
2106
88652fd5
EZ
21072011-09-27 Eli Zaretskii <eliz@gnu.org>
2108
2109 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2110 newline, reseat the iterator instead of bidi-iterating there one
2111 character at a time. (Bug#9610)
32c1fffd
SM
2112 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2113 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2114
ed497dd4
AS
21152011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2116
2117 * lread.c (readevalloop): Use correct code for NBSP.
2118 (read1): Likewise. (Bug#9608)
2119
b2bf61aa
MA
21202011-09-25 Michael Albinus <michael.albinus@gmx.de>
2121
2122 * dbusbind.c (Fdbus_register_signal): When service is not
2123 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2124
32bbb17c
GM
21252011-09-25 Glenn Morris <rgm@gnu.org>
2126
2127 * buffer.c (truncate-lines): Doc fix.
2128
94e0933e
CY
21292011-09-24 Chong Yidong <cyd@stupidchicken.com>
2130
2131 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2132 (Fset_window_next_buffers): Doc fix.
2133
cddde921
GM
21342011-09-24 Glenn Morris <rgm@gnu.org>
2135
2136 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2137
1260aef1
PE
21382011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2139
25b4bfa0
PE
2140 Fix minor problems found by static checking.
2141 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2142 * indent.c (Fvertical_motion): Fix == vs = typo.
2143
e3cbd34b
EZ
21442011-09-24 Eli Zaretskii <eliz@gnu.org>
2145
a66cfb1c
SM
2146 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2147 Default value is now t. Doc fix.
6bf7006f 2148
e3cbd34b 2149 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2150 logic when moving up, not only when moving down. Fix the
e3cbd34b 2151 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2152 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2153
2154 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2155 CHARPOS is covered by a display string which includes newlines.
2156 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2157 is covered by a display string with embedded newlines.
2158
a3de0cbd
MA
21592011-09-24 Michael Albinus <michael.albinus@gmx.de>
2160
2161 * dbusbind.c (Fdbus_register_signal): Add match rule to
2162 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2163 (Fdbus_register_method, Vdbus_registered_objects_table):
2164 Fix docstring.
a3de0cbd 2165
b260039d
JM
21662011-09-24 Jim Meyering <meyering@redhat.com>
2167
32c1fffd 2168 do not ignore write error for any output size
b260039d
JM
2169 The previous change was incomplete.
2170 While it makes emacs --batch detect the vast majority of stdout
2171 write failures, errors were still ignored whenever the output size is
2172 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2173 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2174 && echo FAIL: ignored write error
2175 FAIL: ignored write error
2176 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2177 && echo FAIL: ignored write error
2178 FAIL: ignored write error
2179 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2180
8eca8a7c
AS
21812011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2182
2183 * emacs.c (Fkill_emacs): In noninteractive mode exit
2184 non-successfully if a write error occurred on stdout. (Bug#9574)
2185
3341db62
EZ
21862011-09-21 Eli Zaretskii <eliz@gnu.org>
2187
2188 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2189 the xassert test.
2190
2191 * dispextern.h (struct it): Update the comment documenting what
2192 can it->OBJECT be.
2193
8c203dbf
EZ
21942011-09-20 Eli Zaretskii <eliz@gnu.org>
2195
2196 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2197 a display string, extend search for cursor position to end of row.
2198 (find_row_edges): If the row ends in a newline from a display
2199 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2200 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2201 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2202 non-empty line. Fixes confusing cursor motion with arrow keys at
2203 the beginning of a line that starts with whitespace.
8c203dbf 2204
a4824228
LMI
22052011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2206
2207 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2208 (bug#9493).
2209
33ed493b
CY
22102011-09-18 Chong Yidong <cyd@stupidchicken.com>
2211
2212 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2213 boolean (Bug#9154).
2214
56cd55c8
EZ
22152011-09-18 Eli Zaretskii <eliz@gnu.org>
2216
2217 * xdisp.c (display_line): Record maximum and minimum buffer
2218 positions even if no glyphs were produced (e.g., by a zero-width
2219 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2220 buffer positions that will be removed from the glyph row because
2221 they don't fit.
c02dcedf
EZ
2222 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2223 column is beyond frame width: don't subtract 1 "pixel" when
2224 computing width of the stretch.
3e62b7e0
EZ
2225 (reseat_at_next_visible_line_start): Undo the change made on
2226 2011-09-17 that saved paragraph information and restored it after
2227 the call to `reseat'. (Bug#9545)
56cd55c8 2228
5ed99d36 22292011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2230
2231 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2232 and turn window cursor on if cleared (Bug#9415).
2233
5ed99d36 22342011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2235
2236 * search.c (boyer_moore): Take unibyte characters from pattern
2237 literally. (Bug#9458)
2238
9bade7b2
EZ
22392011-09-18 Eli Zaretskii <eliz@gnu.org>
2240
2241 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2242
e5e9d610
PE
22432011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2244
87e4427a
PE
2245 Fix minor problem found by static checking.
2246 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2247 initialized, to pacify gcc -Wuninitialized.
2248
e5e9d610
PE
2249 * fileio.c: Report proper errno when syscall falls.
2250 (Finsert_file_contents): Save and restore errno,
2251 so that report_file_error outputs the correct diagnostic.
2252 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2253
a1674f0b
EZ
22542011-09-18 Eli Zaretskii <eliz@gnu.org>
2255
2256 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2257
fbfb6dd4
EZ
22582011-09-17 Eli Zaretskii <eliz@gnu.org>
2259
2260 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2261 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2262
bb187662
EZ
22632011-09-17 Eli Zaretskii <eliz@gnu.org>
2264
1137e8b8 2265 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2266 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2267
2268 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2269 (bidi_find_paragraph_start): Search back for paragraph beginning
2270 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2271 (bidi_move_to_visually_next): Only trigger paragraph-related
2272 computations when the last character is a newline or at EOB, not
2273 just any NEUTRAL_B. (Bug#9470)
2274
bb187662
EZ
2275 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2276 truncated lines if point is covered by a display string. (Bug#9524)
2277
2e621251
PE
22782011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2281 (cons_to_x_long): New function.
2282 (lisp_data_to_selection_data): Use it. Correct the test for
2283 short-versus-long data; it was negated. Break out of vector
2284 loop, for efficiency, when a long datum is discovered.
2285
91a15bc6
SM
22862011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2287
2288 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2289
b41c3a35
EZ
22902011-09-16 Eli Zaretskii <eliz@gnu.org>
2291
2292 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2293 GCC PR/17406) by declaring this function with external scope.
2294
7812ba2d
PE
22952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2296
2297 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2298 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2299
cf7edc2a
AS
23002011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2301
2302 * editfns.c (Fformat): Correctly handle text properties on "%%".
2303
bd01620e
EZ
23042011-09-15 Eli Zaretskii <eliz@gnu.org>
2305
2306 * xterm.c (x_draw_composite_glyph_string_foreground):
2307 * w32term.c (x_draw_composite_glyph_string_foreground):
2308 * term.c (encode_terminal_code):
2309 * composite.c (composition_update_it, get_composition_id):
2310 * xdisp.c (get_next_display_element)
2311 (fill_composite_glyph_string): Add comments about special meaning
2312 of TAB characters in a composition.
2313
a02719a3
PE
23142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2317 This occurs when processing a multibyte format.
2318 Problem reported by Wolfgang Jenker.
a02719a3 2319
72589a3c
JB
23202011-09-15 Johan Bockgård <bojohan@gnu.org>
2321
2322 * xdisp.c (try_cursor_movement): Only check for exact match if
2323 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2324
1c14176c
PE
23252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2326
2327 Remove unused external symbols.
2328 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2329 * xdisp.c (calc_pixel_width_or_height): Now static.
2330 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2331 * indent.c (check_display_width):
2332 * w32term.c: Fix comment to match code.
2333 * xterm.c, xterm.h (x_catching_errors): Remove.
2334
d2eea5b5
PE
23352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 * xselect.c: Use signed conversions more consistently (Bug#9498).
2338 (selection_data_to_lisp_data): Assume incoming selection data are
2339 signed integers, not unsigned. This is to be consistent with
2340 outgoing selection data, which was modified to use signed integers
2341 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2342 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2343 expects long, not unsigned long.
2344
46888499
EZ
23452011-09-14 Eli Zaretskii <eliz@gnu.org>
2346
2347 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2348 computation of loop end. Reported by Johan Bockgård
2349 <bojohan@gnu.org>.
2350
ef8ef9fb
CY
23512011-09-13 Chong Yidong <cyd@stupidchicken.com>
2352
2353 * frame.c (Fother_visible_frames_p): Function deleted.
2354
fa819fed
EZ
23552011-09-12 Eli Zaretskii <eliz@gnu.org>
2356
2357 * indent.c (compute_motion): Process display vector front to back
2358 rather than the other way around. (Bug#2496)
2359
2ba8e008
SM
23602011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2361
2362 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2363
20f53c69
CY
23642011-09-11 Chong Yidong <cyd@stupidchicken.com>
2365
2366 * minibuf.c (Fread_from_minibuffer): Doc fix.
2367
d562d7a4
EZ
23682011-09-11 Eli Zaretskii <eliz@gnu.org>
2369
2370 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2371 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2372
1c4d7f3d
LMI
23732011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2374
2375 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2376 value for non-existent files.
2377
b885bf36
EZ
23782011-09-11 Eli Zaretskii <eliz@gnu.org>
2379
2380 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2381 set its "size" to -1. This will set the modtime_size field of
2382 the corresponding buffer to -1, which is what
2383 verify-visited-file-modtime expects for files that do not exist.
2384 (Bug#9139)
2385
6612f0bf
PE
23862011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2389 here ...
2390 * lisp.h: ... from here. push_key_description is no longer
2391 defined in keyboard.c, so its declaration should not be in
2392 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2393 logically belongs with push_key_description.
2394
dfb3f755
PE
23952011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * buffer.h: Include <sys/types.h> instead of <time.h>.
2398 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2399 Problem reported by Herbert J. Skuhra.
2400
3134906c
LMI
24012011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2402
2403 * xml.c (parse_region): Make the parsing work for
2404 non-comment-starting XML files again (bug#9144).
2405
8d903f4e
AS
24062011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2407
2408 * image.c (gif_load): Fix calculation of bottom and right corner.
2409 (Bug#9468)
2410
80ad64f4
EZ
24112011-09-10 Eli Zaretskii <eliz@gnu.org>
2412
2413 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2414 redisplay in small windows.
2415
208a048d
EZ
24162011-09-09 Eli Zaretskii <eliz@gnu.org>
2417
2418 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2419
9b1c252e
MR
24202011-09-08 Martin Rudalics <rudalics@gmx.at>
2421
2422 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2423 Operate on live windows only.
2424
2949f33b
JB
24252011-09-08 Juanma Barranquero <lekktu@gmail.com>
2426
2427 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2428
e08dcafd
EZ
24292011-09-07 Eli Zaretskii <eliz@gnu.org>
2430
2431 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2432 only under bidi iteration.
2433
115b96bd
JD
24342011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2435
2436 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2437
c8199d0f
PE
24382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2441 Without this fix, the command to link temacs failed due to an
2442 undefined symbol __builtin_isnan. This is because
2443 /usr/include/iso/math_c99.h #defines isnan(x) to
2444 __builtin_isnan(x), but the bundled gcc, which identifies itself
2445 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2446 a __builtin_isnan.
2447 * floatfns.c (isnan): #undef, and then #define to a clone of
2448 what's in data.c.
2449 (Fisnan): Always define, since it's always available now.
2450 (syms_of_floatfns): Always define isnan at the Lisp level.
2451
e39b275c 24522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2453
2454 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2455
b2db44d9 24562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2457
f4af5137 2458 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2459 The previous code assumed that file offsets (off_t values) fit in
2460 EMACS_INT variables, which is not true on typical 32-bit hosts.
2461 The code messed up by falsely reporting buffer overflow in cases
2462 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2463 when "big" contains more than 2**29 bytes, even though this
2464 inserts just one byte and does not overflow the buffer.
2465 (Finsert_file_contents): Store file offsets as off_t
2466 values, not as EMACS_INT values. Check for overflow when
2467 converting between EMACS_INT and off_t. When checking for
2468 buffer overflow or for overlap, take the offsets into account.
2469 Don't use EMACS_INT for small values where int suffices.
2470 When checking for overlap, fix a typo: ZV was used where
2471 ZV_BYTE was intended.
2472 (Fwrite_region): Don't assume off_t fits into 'long'.
2473 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2474
ecfc0a49
MA
24752011-09-05 Michael Albinus <michael.albinus@gmx.de>
2476
2477 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2478
6511acf2 24792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2480
0999621a 2481 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2482
2483 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2484 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2485 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2486 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2487 (modify_event_symbol): Do not assume that the length of
2488 name_alist_or_stem is safe to alloca and fits in int.
2489 (Fexecute_extended_command): Likewise for function name and binding.
2490 (Frecursion_depth): Wrap around reliably on integer overflow.
2491 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2492 since some callers pass EMACS_INT values.
2493 (Fsingle_key_description): Don't crash if symbol name contains more
2494 than MAX_ALLOCA bytes.
2495 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2496 (get_minibuffer): Arg is now EMACS_INT, not int.
2497 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2498 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2499 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2500
2be7d702
PE
2501 * dbusbind.c (signature_cat): New function.
2502 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2503 Do not overrun buffer; instead, report string overflow.
2504
9d1df220
PE
2505 * dispnew.c (add_window_display_history): Don't overrun buffer.
2506 Truncate instead; this is OK since it's just a log.
2507
33ef5c64
PE
2508 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2509 even if the time zone offset is outlandishly large.
2510 Don't mishandle offset == INT_MIN.
2511
66c6fdd5
PE
2512 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2513 when creating daemon; the previous buffer-overflow check was incorrect.
2514
d749b01b
PE
2515 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2516 which has the guts of the old verror function.
2517
b5cd1905
PE
2518 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2519 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2520
6e1a67fb
PE
2521 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2522 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2523 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2524 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2525 length of string rather than counting it via multiple sprintfs;
2526 that's simpler and more reliable.
c21721cc
PE
2527 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2528 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2529 sprintf, in case result does not fit in int.
2530
c57b67fc
PE
2531 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2532 (fontset_from_font): Print it.
2533
8a401434
PE
2534 * frame.c (tty_frame_count): Now printmax_t, not int.
2535 (make_terminal_frame, set_term_frame_name): Print it.
2536 (x_report_frame_params): In X, window IDs are unsigned long,
2537 not signed long, so print them as unsigned.
2538 (validate_x_resource_name): Check for implausibly long names,
2539 and don't assume name length fits in 'int'.
2540 (x_get_resource_string): Don't blindly alloca invocation name;
2541 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2542 not fit in int.
2543
6e1a67fb
PE
2544 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2545 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2546 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2547
0df02bf3
PE
2548 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2549 Use esprintf, not sprintf, in case result does not fit in int.
2550
48e30793
PE
2551 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2552 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2553 it as a large positive number.
2554 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2555 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2556
a66ff6d8
PE
2557 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2558 in case result does not fit in int.
2559
aca216ff
PE
2560 * print.c (float_to_string): Detect width overflow more reliably.
2561 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2562 buffer overrun. Don't assume list length fits in 'int'. Treat
2563 print length of 0 as 0, not as infinity; to be consistent with other
2564 uses of print length in this function. Don't overflow print length
2565 index. Don't assume hash table size fits in 'long', or that
2566 vectorlike size fits in 'unsigned long'.
2567
31c286f7
PE
2568 * process.c (make_process): Use printmax_t, not int, to format
2569 process-name gensyms.
2570
55e5faa1
PE
2571 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2572
80f2e268
PE
2573 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2574 to avoid potential buffer overrun.
2575
670741ab
PE
2576 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2577 if X resource line is longer than 512 bytes.
2578
b7163a50
PE
2579 * xfns.c (x_window): Make sprintf buffer a bit bigger
2580 to avoid potential buffer overrun.
2581
ae58ff1f
PE
2582 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2583
c43c8a6a
PE
2584 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2585
3f8236f4
PE
25862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2587
53e9fe90 2588 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2589 Without these, Emacs silently mishandles large integers sometimes.
2590 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2591 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2592
6511acf2
PE
2593 * xdisp.c (try_window_id): Check Emacs fixnum range before
2594 converting to 'int'.
806add1d 2595
6511acf2 2596 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2597 Check that an Emacs fixnum is in range before assigning it to 'int'.
2598 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2599 values converted from Emacs fixnums.
2600 (Frecenter): Don't wrap around a line count if it is out of 'int'
2601 range; instead, treat it as an extreme value.
2602 (Fset_window_configuration, compare_window_configurations):
2603 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2604
6511acf2
PE
2605 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2606 that can exceed INT_MAX. Check that EMACS_INT value is in range
2607 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2608 (match_limit): Don't assume that a fixnum can fit in 'int'.
2609
6511acf2 2610 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2611 exceed INT_MAX.
2612
6511acf2 2613 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2614 (Fvertical_motion): Don't wrap around LINES values that don't fit
2615 in 'int'. Instead, treat them as extreme values. This is good
2616 enough for windows, which can't have more than INT_MAX lines anyway.
2617
fcb901a7
LMI
26182011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2619
0f2f6b6d
LMI
2620 * Require libxml/parser.h to avoid compilation warning.
2621
fcb901a7
LMI
2622 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2623
2624 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2625 since this reportedly can destroy thread storage.
2626
6e20a0d4
CY
26272011-08-30 Chong Yidong <cyd@stupidchicken.com>
2628
2629 * syntax.c (find_defun_start): Update all cache variables if
2630 exiting early (Bug#9401).
2631
148ae00e
EZ
26322011-08-30 Eli Zaretskii <eliz@gnu.org>
2633
f6cfbd8f
EZ
2634 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2635
148ae00e
EZ
2636 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2637 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2638 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2639
2640 * term.c (tty_append_glyph): New function.
2641 (produce_stretch_glyph): Static function and its prototype deleted.
2642
a66cfb1c
SM
2643 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2644 Add prototypes.
148ae00e 2645
c4a07a4c
PE
26462011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2647
2648 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2649 when checking :margin (Bug#9390).
2650 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2651 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2652 so that the name doesn't mislead. All uses changed.
2653
6bc8cd65
JB
26542011-08-28 Johan Bockgård <bojohan@gnu.org>
2655
2656 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2657 set_tty_hooks.
2658
dca4927e
EZ
26592011-08-27 Eli Zaretskii <eliz@gnu.org>
2660
2661 * xdisp.c (move_it_to): Don't bail out early when reaching
2662 position beyond to_charpos, if we are scanning backwards.
2663 (move_it_vertically_backward): When DY == 0, make sure we get to
2664 the first character in the line after the newline.
2665
f2cad773
PE
26662011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2669 (ccl_driver): Do not generate an out-of-range pointer.
2670 (Fccl_execute_on_string): Remove unnecessary check for
2671 integer overflow, noted by Stefan Monnier in
2672 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2673 Remove a FIXME that didn't need fixing.
2674 Simplify the newly-introduced buffer reallocation code.
2675
0cae2cdb
JB
26762011-08-27 Juanma Barranquero <lekktu@gmail.com>
2677
2678 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2679
5fc295a4 26802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2681
70c60eb2 2682 Integer and memory overflow issues (Bug#9196).
726e0ab1 2683
d31850da
PE
2684 * doc.c (get_doc_string): Rework so that
2685 get_doc_string_buffer_size is the actual buffer size, rather than
2686 being 1 less than the actual buffer size; this makes xpalloc more
2687 convenient.
2688
a69fbedb
PE
2689 * image.c (x_allocate_bitmap_record, cache_image):
2690 * xselect.c (Fx_register_dnd_atom):
2691 Simplify previous changes by using xpalloc.
2692
fe5c5d37
PE
2693 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2694 since either will do and ptrdiff_t is convenient with xpalloc.
2695
0065d054
PE
2696 * charset.c (charset_table_size)
2697 (struct charset_sort_data.priority): Now ptrdiff_t.
2698 (charset_compare): Don't overflow if priorities differ greatly.
2699 (Fsort_charsets): Don't assume list length fits in int.
2700 Check for size-calculation overflow when allocating sort data.
2701 (syms_of_charset): Allocate an initial charset table that is
2702 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2703
2704 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2705
2706 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2707 The actual value is always <= INT_MAX, and leaving it unsigned made
2708 overflow checking harder.
2709
2710 * dispextern.h (struct glyph_matrix.rows_allocated)
2711 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2712 with xpalloc. The values are still always <= INT_MAX.
2713
2714 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2715
2716 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2717 (SAFE_NALLOCA): New macro.
2718
2719 * region-cache.c (struct boundary.pos, find_cache_boundary)
2720 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2721 (set_cache_region, invalidate_region_cache)
2722 (revalidate_region_cache, know_region_cache, region_cache_forward)
2723 (region_cache_backward, pp_cache):
2724 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2725 so that ptrdiff_t * can be passed to xpalloc.
2726 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2727 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2728 (pp_cache): Don't assume cache_len fits in int.
2729 * region-cache.h: Adjust extern decls to match.
2730
2731 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2732 EMACS_INT, since either will do, for xpalloc.
2733
2734 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2735 (xnmalloc, xnrealloc, xpalloc): New functions.
2736
726e0ab1
PE
2737 * bidi.c (bidi_shelve_header_size): New constant.
2738 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2739 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2740
51f30bc5 2741 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2742 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2743 (overlay_strings):
2744 Don't update size of array until after memory allocation succeeds,
2745 because xmalloc/xrealloc may not return.
0065d054
PE
2746 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2747 now that we have proper integer overflow checking.
2748 (record_overlay_string, overlay_strings): Catch overflows when
2749 calculating size of overlay_str_buf.
726e0ab1 2750
0065d054
PE
2751 * callproc.c (Fcall_process): Check for size overflow when
2752 calculating size of args2.
2753 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2754 Normally we prefer signed values, but sticking with ptrdiff_t would
2755 require adding more-complicated checks.
726e0ab1
PE
2756
2757 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2758 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2759 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2760 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2761
2762 * character.c (Fstring): Check for size-calculation overflow.
2763
2764 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2765 unnecessary integer overflow. Check for size overflow.
2766 (encode_coding_object): Don't update size until xmalloc succeeds.
2767
2768 * composite.c (get_composition_id): Check for overflow in glyph
2769 length calculations.
2770
2771 Integer and memory overflow fixes for display code.
2772 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2773 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2774 (scrolling_window): Check for overflow in size calculations.
2775 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2776 Don't assume glyph table len fits in int.
2777 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2778 (row_table_size): Now ptrdiff_t, not int.
2779 (scrolling_window): Avoid overflow in size calculations.
2780 Don't update size until allocation succeeds.
2781 * fns.c (concat): Check for overflow in size calculations.
2782 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2783 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2784 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2785
2786 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2787 (get_doc_string): Check for size calculation overflow.
2788 Don't update size until allocation succeeds.
2789 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2790 EMACS_INT, where ptrdiff_t will do.
2791 (Fsubstitute_command_keys): Check for string overflow.
2792
2793 * editfns.c (set_time_zone_rule): Don't assume environment length
2794 fits in int.
2795 (message_length): Now ptrdiff_t, not int.
2796 (Fmessage_box): Don't update size until allocation succeeds.
2797 Don't assume message length fits in int.
2798 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2799
0065d054
PE
2800 * emacs.c (main): Do not reallocate argv, since there is a null at
2801 the end that can be overwritten, and this way there's no need to
2802 worry about size-calculation overflow.
2803 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2804
2805 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2806 alloc succeeds.
2807 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2808
2809 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2810 (x_set_scroll_bar_width, x_figure_window_size):
2811 Check for integer overflow.
2812 (x_set_alpha): Do not assume XINT fits in int.
2813
2814 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2815 This is for the members text_lines, text_cols, total_lines, total_cols,
2816 where the system imposes an 'int' limit.
2817
2818 * fringe.c (Fdefine_fringe_bitmap):
2819 Don't update size until alloc works.
2820
2821 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2822 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2823
2824 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2825 Check for size-calculation overflow.
2826 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2827 do, as we prefer signed integers.
2828 (id_to_widget.max_size, id_to_widget.used)
2829 (xg_store_widget_in_map, xg_remove_widget_from_map)
2830 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2831 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2832 Use and return ptrdiff_t, not int.
2833 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2834 * gtkutil.h: Change prototypes to match the above.
2835
2836 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2837 are duplicate now that they've been promoted to lisp.h.
2838 (x_allocate_bitmap_record, x_alloc_image_color)
2839 (make_image_cache, cache_image, xpm_load):
2840 Don't update size until alloc is done.
2841 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2842 (x_detect_edges):
3256efce 2843 Check for size calculation overflow.
726e0ab1
PE
2844 (ct_colors_allocated_max): New constant.
2845 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2846 overflow.
3256efce 2847
726e0ab1
PE
2848 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2849 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2850 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2851 Use ptrdiff_t, not int, to count maps.
2852 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2853 calculations. Don't update size until allocation succeeds.
2854 Redo calculations to avoid overflow.
726e0ab1
PE
2855 * keyboard.h: Change prototypes to match the above.
2856
2857 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2858 to count maps.
2859 (current_minor_maps): Check for size calculation overflow.
2860 * keymap.h: Change prototypes to match the above.
2861
2862 * lread.c (read1, init_obarray): Don't update size until alloc done.
2863
2864 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2865 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2866
726e0ab1
PE
2867 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2868 Now ptrdiff_t, not int.
2869 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2870 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2871
2872 * process.c (Fnetwork_interface_list): Check for overflow
2873 in size calculation.
2874
2875 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2876
2877 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2878 overflow. Don't bother calling xmalloc when xrealloc will do.
2879
2880 * search.c (Freplace_match): Check for size calculation overflow.
2881 (Fset_match_data): Don't assume list lengths fit in 'int'.
2882
2883 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2884 for command line length. Do not attempt to address one before the
2885 beginning of an array, as that's not portable.
2886
2887 * term.c (max_frame_lines): Remove; unused.
2888 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2889 not int.
2890 (encode_terminal_code, calculate_costs): Check for size
2891 calculation overflow.
2892 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2893 table lengths and related sizes. Don't update size until alloc
2894 done. Redo calculations to avoid overflow.
2895 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2896
2897 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2898 subtracting pointers.
2899 (gobble_line): Check for overflow more carefully. Don't update size
2900 until alloc done.
2901
2902 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2903 Don't update size until alloc done.
2904 Redo size calculations to avoid overflow.
2905 Check for size calculation overflow.
0065d054 2906 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2907
2908 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2909 Use ptrdiff_t, not int, for sizes.
2910 (store_mode_line_noprop_char): Don't update size until alloc done.
2911
0065d054
PE
2912 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2913 Use ptrdiff_t, not int, for sizes.
2914 (Finternal_make_lisp_face, cache_face):
2915 Check for size calculation overflow.
2916 (cache_face): Treat size calculation overflows as if they were
2917 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2918
2919 * xfns.c (x_encode_text, x_set_name_internal)
2920 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2921 sizes, since they can exceed INT_MAX in size. Check for size
2922 calculation overflow.
2923
0065d054
PE
2924 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2925 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2926 Don't update size until alloc done.
2927
0065d054 2928 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2929 as sprintf is limited to int lengths.
1d526e2f 2930
252c5ee1
PE
2931 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2932 (X_LONG_MIN): New macros.
864d7ce7
PE
2933 Use them to make the following changes clearer.
2934 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2935 This change doesn't affect the value now, but it may help remind
2936 future maintainers not to raise the value too much later.
2937 (SELECTION_QUANTUM): Remove, replacing with ...
2938 (selection_quantum): ... new function, which avoids overflow.
2939 All uses changed.
2940 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2941 assumption that selection length fits in 'int'.
2942 (x_reply_selection_request, x_handle_selection_request)
2943 (x_get_window_property, receive_incremental_selection)
2944 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2945 (lisp_data_to_selection_data, clean_local_selection_data):
2946 Use ptrdiff_t, not int, to record length of selection.
2947 (x_reply_selection_request, x_get_window_property)
2948 (receive_incremental_selection, x_property_data_to_lisp):
2949 Redo calculations to avoid overflow.
2950 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2951 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2952 something.
2953 (x_get_window_property, receive_incremental_selection)
2954 (lisp_data_to_selection_data, x_property_data_to_lisp):
2955 Check for size-calculation overflow.
2956 (x_get_window_property, receive_incremental_selection)
2957 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2958 Don't store size until memory allocation succeeds.
2959 (x_get_window_property): Plug memory leak on memory exhaustion.
2960 Don't double-block input; malloc is safe here. Don't assume 2**34
2961 - 4 fits in unsigned long. Add an xassert to check
2962 XGetWindowProperty overflow. Be more careful about overflow
2963 calculations, and distinguish size from memory overflow better.
2964 (receive_incremental_selection): When tracing, don't assume
2965 unsigned int is less than INT_MAX.
2966 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2967 harmful) conversions of unsigned short to int.
2968 (lisp_data_to_selection_data): Don't assume that integers
2969 in the range -65535 through -1 fit in an X unsigned short.
2970 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2971 result parameters unless successful. Rely on cons_to_unsigned
2972 to report problems with elements; the old code wasn't right anyway.
2973 (x_check_property_data): Check for int overflow; we cannot use
2974 a wider type due to X limits.
2975 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2976
726e0ab1 2977 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2978
0065d054
PE
2979 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2980 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2981 (x_color_cells): Don't store size until memory allocation succeeds.
2982 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2983 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2984 (x_term_init): Don't assume length fits in int (sprintf is limited
2985 to int size).
bc18e09d 2986
ebfa62c0
PE
2987 Use ptrdiff_t for composition IDs.
2988 * character.c (lisp_string_width):
2989 * composite.c (composition_table_size, n_compositions)
2990 (get_composition_id, composition_gstring_from_id):
2991 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2992 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2993 * window.c (Frecenter):
2994 Use ptrdiff_t, not int, for composition IDs.
2995 * composite.c (get_composition_id): Check for integer overflow.
2996 * composite.h: Adjust prototypes to match the above changes.
2997
d3411f89
PE
2998 Use ptrdiff_t for hash table indexes.
2999 * category.c (hash_get_category_set):
3000 * ccl.c (ccl_driver):
3001 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3002 * coding.c (coding_system_charset_list, detect_coding_system):
3003 * coding.h (struct coding_system.id):
3004 * composite.c (get_composition_id, gstring_lookup_cache):
3005 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3006 * image.c (xpm_get_color_table_h):
3007 * lisp.h (hash_lookup, hash_put):
3008 * minibuf.c (Ftest_completion):
3009 Use ptrdiff_t for hash table indexes, not int (which is too
3010 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3011 32-bit --with-wide-int hosts).
3012
e097a6fa
PE
3013 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3014 Add a FIXME comment about memory leaks.
3015 (syms_of_charset): Don't assume xmalloc returns.
3016
5637687f
PE
3017 Don't assume that stated character widths fit in int.
3018 * character.c (Fchar_width, c_string_width, lisp_string_width):
3019 * character.h (CHAR_WIDTH):
3020 * indent.c (MULTIBYTE_BYTES_WIDTH):
3021 Use sanitize_char_width to avoid undefined and/or bad behavior
3022 with outlandish widths.
a66cfb1c 3023 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3024 now that we have two such functions. All uses changed.
3025 (sanitize_char_width): New inline function.
3026
a2271ba2
PE
3027 Don't assume that tab-width fits in int.
3028 * character.h (sanitize_width): New inline function.
3029 (SANE_TAB_WIDTH): New macro.
3030 (ASCII_CHAR_WIDTH): Use it.
3031 * indent.c (sane_tab_width): Remove. All uses replaced by
3032 SANE_TAB_WIDTH (current_buffer).
3033 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3034
18c52557
PE
3035 * fileio.c: Integer overflow issues with file modes.
3036 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3037
caeeedc1
PE
3038 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3039 Remove unreachable code.
3040 (read_hex, load_charset_map_from_file): Check for integer overflow.
3041
6df6ae42 3042 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3043 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3044 (x_send_scroll_bar_event): Likewise. Check that the size does not
3045 exceed limits imposed by XClientMessageEvent, as well as the usual
3046 ptrdiff_t and size_t limits.
3047
b13995db
PE
3048 * keyboard.c: Overflow, signedness and related fixes.
3049 (make_lispy_movement): Use same integer type in forward decl
3050 that is used in the definition.
3051 (read_key_sequence, keyremap_step):
3052 Change bufsize argument back to int, undoing my 2011-03-30 change.
3053 We prefer signed types, and int is wide enough here.
3054 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3055 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3056 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3057 length, not size_t. Use ptrdiff_t for index, not int.
3058 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3059 possibility of integer overflow.
3060
13464394
PE
3061 Overflow, signedness and related fixes for images.
3062
3063 * dispextern.h (struct it.stack[0].u.image.image_id)
3064 (struct_it.image_id, struct image.id, struct image_cache.size)
3065 (struct image_cache.used, struct image_cache.ref_count):
3066 * gtkutil.c (update_frame_tool_bar):
3067 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3068 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3069 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3070 * nsmenu.m (update_frame_tool_bar):
3071 * xdisp.c (calc_pixel_width_or_height):
3072 * xfns.c (image_cache_refcount):
3073 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3074 on typical 64-bit hosts.
3075
3076 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3077 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3078 Omit unnecessary casts to int.
3079 (parse_image_spec): Check that integers fall into 'int' range
3080 when the callers expect that.
3081 (image_ascent): Redo ascent calculation to avoid int overflow.
3082 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3083 (lookup_image): Remove unnecessary tests.
3084 (xbm_image_p): Locals are now of int, not EMACS_INT,
3085 since parse_image_check makes sure they fit into int.
3086 (png_load, gif_load, svg_load_image):
3087 Prefer int to unsigned where either will do.
3088 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3089 old tiff_error_handler and tiff_warning_handler.
3090 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3091 stack buffer overflows. It uses only the features of vsnprintf
3092 that are common to both POSIX and native Microsoft.
3093 (tiff_error_handler, tiff_warning_handler): Use it.
3094 (tiff_load, gif_load, imagemagick_load_image):
3095 Don't assume :index value fits in 'int'.
3096 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3097 (imagemagick_load_image): Check that crop parameters fit into
3098 the integer types that MagickCropImage accepts. Don't assume
3099 Vimagemagick_render_type has a nonnegative value. Don't assume
3100 size_t fits in 'long'.
3101 (gs_load): Use printmax_t to print the widest integers possible.
3102 Check for integer overflow when computing image height and width.
3103
c11821d4
EZ
31042011-08-26 Eli Zaretskii <eliz@gnu.org>
3105
3106 * xdisp.c (redisplay_window): Don't force window start if point
3107 will be invisible in the resulting window. (Bug#9324)
3108
0c95fcf7
EZ
31092011-08-25 Eli Zaretskii <eliz@gnu.org>
3110
3111 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3112 the display spec is of the form `(space ...)'.
3113 (handle_display_spec): Return the value returned by
3114 handle_single_display_spec, not just 1 or zero.
3115 (handle_single_display_spec): If the display spec is of the form
3116 `(space ...)', and specifies display in the text area, return 2
3117 rather than 1.
fee65a97 3118 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3119 accurately, and prefer exact match for point under bidi.
3120 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3121
3122 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3123 into disp_prop; all users changed.
3124
3125 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3126 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3127 for the text covered by the display property.
3128
e4ed06f1
CY
31292011-08-25 Chong Yidong <cyd@stupidchicken.com>
3130
3131 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3132 Change return value to nil.
3133 (Frecord_buffer): Delete unused function.
3134
f67cdd7f
EZ
31352011-08-24 Eli Zaretskii <eliz@gnu.org>
3136
5980d4c6
EZ
3137 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3138 buffers, return left-to-right.
8610fe8b
EZ
3139 (set_cursor_from_row): Consider candidate row a win if its glyph
3140 represents a newline and point is on that newline. Fixes cursor
3141 positioning on the newline at EOL of R2L text within L2R
3142 paragraph, and vice versa.
3143 (try_cursor_movement): Check continued rows, in addition to
3144 continuation rows. Fixes unwarranted scroll when point enters a
3145 continued line of R2L text within an L2R paragraph, or vice versa.
3146 (cursor_row_p): Consider the case of point being equal to
3147 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3148 from the end of a short line to the beginning of a continued line
3149 of R2L text within L2R paragraph.
3150 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3151 composed characters.
5980d4c6 3152
f67cdd7f
EZ
3153 * bidi.c (bidi_check_type): Use xassert.
3154 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3155 members.
3156
bca633fb
EZ
31572011-08-23 Eli Zaretskii <eliz@gnu.org>
3158
3159 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3160 a character.
3161
4a5885a7
CY
31622011-08-23 Chong Yidong <cyd@stupidchicken.com>
3163
3164 * nsfont.m (ns_otf_to_script): Fix typo.
3165
0902a04e
KH
31662011-08-22 Kenichi Handa <handa@m17n.org>
3167
3168 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3169 extra slot even if the purpose is char-code-property-table.
3170
1a2e6670
EZ
31712011-08-23 Eli Zaretskii <eliz@gnu.org>
3172
8ddde651
EZ
3173 * xdisp.c (redisplay_window): When computing centering_position,
3174 account for the height of the header line. (Bug#8874)
3175
425cc014
EZ
3176 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3177 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3178 candidate is selected by the mouse, and that candidate has a
3179 composed character under the mouse.
3180
1a2e6670
EZ
3181 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3182 coordinates reported by pos-visible-in-window-p for a composed
3183 character in column zero.
3184
8b76d6f8
SM
31852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3186
3187 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3188
dac347dd
EZ
31892011-08-22 Eli Zaretskii <eliz@gnu.org>
3190
3191 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3192 consider it a hit if to_charpos is anywhere in the range of the
3193 composed buffer positions.
3194
e013fb34
CY
31952011-08-22 Chong Yidong <cyd@stupidchicken.com>
3196
3197 * image.c (gif_load): Don't assume that each subimage has the same
3198 dimensions as the base image. Handle disposal method that is
3199 "undefined" by the gif spec (Bug#9335).
3200
bd1ba3e8
CY
32012011-08-20 Chong Yidong <cyd@stupidchicken.com>
3202
3203 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3204 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3205
54a1215b
EZ
32062011-08-19 Eli Zaretskii <eliz@gnu.org>
3207
823564e5
EZ
3208 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3209 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3210 from an Org mode buffer to a Speedbar frame.
3211
54a1215b
EZ
3212 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3213 a composition, take its buffer position from IT->cmp_it.charpos.
3214 Fixes cursor positioning at the beginning of a line that begins
3215 with a composed character.
3216
9778ebcc
EZ
32172011-08-18 Eli Zaretskii <eliz@gnu.org>
3218
0be6ee06
EZ
3219 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3220 character bidirectional type, use STRONG_L instead. Fixes crashes
3221 in a buffer produced by `describe-categories'.
3222
9778ebcc
EZ
3223 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3224 members before the level stack, so they would be saved and
3225 restored when copying iterator state. Fixes incorrect reordering
3226 around TABs covered by display properties.
3227
156bffbe
AS
32282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3229
6b02f655 3230 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3231
72ad093b
CY
32322011-08-17 Chong Yidong <cyd@stupidchicken.com>
3233
3234 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3235 (internal_condition_case_2, internal_condition_case_n):
3236 Remove unnecessary aborts (Bug#9081).
72ad093b 3237
35774242
EZ
32382011-08-17 Eli Zaretskii <eliz@gnu.org>
3239
3240 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3241 has no `load' handler, try opening the file locally. (Bug#9311)
3242
db76dd85
KB
32432011-08-16 Ken Brown <kbrown@cornell.edu>
3244
3245 * gmalloc.c: Expand comment.
3246
b215eee5
EZ
32472011-08-16 Eli Zaretskii <eliz@gnu.org>
3248
3249 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3250 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3251
a4579d33
KB
32522011-08-16 Ken Brown <kbrown@cornell.edu>
3253
3254 Fix memory allocation problems in Cygwin build (Bug#9273).
3255
3256 * unexcw.c ( __malloc_initialized): Declare external variable.
3257 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3258
8b76d6f8
SM
3259 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3260 New variables.
a4579d33
KB
3261 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3262 dumped emacs.
3263 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3264 in the static heap.
3265 [CYGWIN] (special_realloc): New function.
3266 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3267 requests to realloc storage in the static heap.
3268
3ebec551
PE
32692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3270
3271 * bidi.c (bidi_initialize): Remove unused local.
3272
9fd8be00
EZ
32732011-08-15 Eli Zaretskii <eliz@gnu.org>
3274
6b02f655
SM
3275 * bidimirror.h:
3276 * biditype.h: Remove file.
3277 * makefile.w32-in ($(BLD)/bidi.$(O)):
3278 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3279
3280 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3281
3282 * chartab.c: Improve commentary for the uniprop_table API.
3283
32413314
EZ
3284 * bidi.c (bidi_paragraph_init): Support zero value of
3285 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3286 (bidi_initialize): Use uniprop_table instead of including
3287 biditype.h and bidimirror.h.
32413314 3288
9fd8be00
EZ
3289 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3290 coordinates of the iterator when restoring from ppos_it.
3291 (Bug#9296)
3292
5cf2b69b
KH
32932011-08-14 Kenichi Handa <handa@m17n.org>
3294
3295 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3296 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3297
daf17d00
EZ
32982011-08-14 Eli Zaretskii <eliz@gnu.org>
3299
3300 * xdisp.c (move_it_in_display_line_to): Don't invoke
3301 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3302 ppos_it. Fixes vertical cursor motion when line beginning is
3303 covered by an image. (Bug#9296)
3304
08e3161a
JD
33052011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3306
3307 * nsterm.h (ns_run_ascript): Declare.
3308 (NSAPP_DATA2_RUNASSCRIPT): Define.
3309
3310 * nsfns.m (as_script, as_result, as_status): New static variables.
3311 (ns_run_ascript): New function.
5e617bc2 3312 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3313 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3314 the event loop. Get status from as_status (Bug#7276).
3315
3316 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3317 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3318 the event loop (Bug#7276).
3319
a3720aa2
AS
33202011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3321
3322 * gnutls.c (QCgnutls_bootprop_priority)
3323 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3324 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3325 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3326 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3327 (QCgnutls_bootprop_verify_hostname_error)
3328 (QCgnutls_bootprop_callbacks_verify): Rename from
3329 Qgnutls_bootprop_..., all uses changed.
3330
3331 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3332 uses changed.
3333
0a0d27fb
PE
33342011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3335
19d5c50c
PE
3336 * xfaces.c (Qframe_set_background_mode): Now static.
3337 * dispextern.h (Qframe_set_background_mode): Remove decl.
3338
0a0d27fb
PE
3339 * process.c (Fnetwork_interface_info): Declare local only if needed.
3340
377538cb
JD
33412011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3342
3343 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3344 (Fnetwork_interface_list): Allocate in increments of bytes instead
3345 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3346 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3347 sockaddr.
3348 (struct ifflag_def): notrailers is smart on OSX.
3349 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3350 Get hardware address with getifaddrs if available.
3351
08fff70c
EZ
33522011-08-12 Eli Zaretskii <eliz@gnu.org>
3353
3354 * xdisp.c (iterate_out_of_display_property): xassert that
3355 IT->position is set to within IT->object's boundaries. Break from
3356 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3357 when IT->position is set up wrongly due to some bug.
3358 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3359 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3360 entry. Force push_it to save on the stack the current
3361 buffer/string position, to be restored by pop_it. Fix flags in
3362 the iterator structure wrt the object coming from a display
3363 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3364 properties. (Bug#9284)
3365
7be1c708 33662011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3367
7be1c708
CY
3368 * fontset.c (fontset_get_font_group): Add proper type checks.
3369 (Bug#9172)
aac0c6e3 3370
7be1c708 33712011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3372
7be1c708
CY
3373 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3374 and LC_VERSION_MIN_MACOSX.
3375 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3376 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3377
97bb72a6
EZ
33782011-08-08 Eli Zaretskii <eliz@gnu.org>
3379
3380 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3381 no-display-properties-and-no-overlays under bidi display.
3382 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3383 properties and overlays.
97bb72a6 3384
d5617611
CY
33852011-08-08 Chong Yidong <cyd@stupidchicken.com>
3386
37e11a63
CY
3387 * editfns.c (Fset_time_zone_rule): Document relationship with the
3388 setenv function.
3389
d5617611
CY
3390 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3391 the font entity extracted from the cache (Bug#8109).
3392
58872834
CY
33932011-08-07 Chong Yidong <cyd@stupidchicken.com>
3394
3395 * composite.c (autocmp_chars): Don't reset point. That is done by
3396 restore_point_unwind (Bug#5984).
3397
75bfc667
JL
33982011-08-07 Juri Linkov <juri@jurta.org>
3399
3400 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3401 to show the arg `TIME' instead of `TIMEVAL'.
3402
d1410150
EZ
34032011-08-06 Eli Zaretskii <eliz@gnu.org>
3404
3405 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3406 display property strides EOL and includes a newline, as in
3407 longlines-mode. (Bug#9254)
75b771e4
EZ
3408 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3409 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3410
3411 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3412 is non-zero, even if the data buffer is NULL. Fixes a crash in
3413 vertical-motion with longlines-mode. (Bug#9254)
3414
35928349
EZ
34152011-08-05 Eli Zaretskii <eliz@gnu.org>
3416
ec7cc85b
EZ
3417 * bidi.c <bidi_cache_total_alloc>: Now static.
3418 (bidi_initialize): Initialize bidi_cache_total_alloc.
3419
8b76d6f8 3420 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3421 cache. (Bug#9221)
3422
3423 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3424 amount allocated this far in `bidi_cache_total_alloc'.
3425 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3426 non-zero, only free the data buffer without restoring the cache
3427 contents. All callers changed.
3428
3429 * dispextern.h (bidi_unshelve_cache): Update prototype.
3430
3431 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3432 (move_it_in_display_line, move_it_to)
3433 (move_it_vertically_backward, move_it_by_lines): Replace the call
3434 to xfree to an equivalent call to bidi_unshelve_cache.
3435 (move_it_in_display_line_to): Fix logic of returning
412b6358 3436 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3437
e2e2423b
EZ
34382011-08-05 Eli Zaretskii <eliz@gnu.org>
3439
3440 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3441 came from a string character with a `cursor' property. (Bug#9229)
3442
ae9e757a
JD
34432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3444
3445 * Makefile.in (LIB_PTHREAD): New variable.
3446 (LIBES): Add LIB_PTHREAD (Bug#9216).
3447
3448 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3449 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3450
213bd7f2
AS
34512011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3452
6b02f655 3453 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3454
99aaf75f
JD
34552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3456
3457 * xterm.c (x_find_topmost_parent): New function.
3458 (x_set_frame_alpha): Find topmost parent window with
3459 x_find_topmost_parent and set the property there also (bug#9181).
3460 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3461
c74e9d86
PE
34622011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3463
3464 * callproc.c (Fcall_process): Avoid vfork clobbering
3465 the local vars buffer, coding_systems, current_dir.
3466
640c8776
SM
34672011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3468
3469 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3470
f26d0e4c
PE
34712011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3472
8a10d76c
PE
3473 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3474 so that it is not optimized away.
3475
f26d0e4c
PE
3476 * xdisp.c (compute_display_string_pos): Remove unused local.
3477
55439c61
EZ
34782011-08-02 Eli Zaretskii <eliz@gnu.org>
3479
3480 Fix slow cursor motion and scrolling in large buffers with
3481 selective display, like Org Mode buffers. (Bug#9218)
3482
3483 * dispextern.h (struct bidi_it): New member disp_prop_p.
3484
3485 * xdisp.c: Remove one-slot cache of display string positions.
3486 (compute_display_string_pos): Accept an additional argument
5e617bc2 3487 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3488 for a display string or property. If found, set DISP_PROP_P
3489 non-zero.
3490
3491 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3492 DISP_PROP_P, and pass it to compute_display_string_pos.
3493 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3494 non-zero. All callers of bidi_fetch_char changed.
3495
fb33fa43
SM
34962011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3497
3498 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3499
b099e063
DM
35002010-12-03 Don March <don@ohspite.net>
3501
3502 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3503 last character M-[char] is translated to ESC [char] (bug#7541).
3504
5cc7f7af
KH
35052011-08-02 Kenichi Handa <handa@m17n.org>
3506
d0fffa3f 3507 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3508
3509 * chartab.c (uniprop_table): Make it non-static.
3510
525d5e6e
EZ
35112011-08-01 Eli Zaretskii <eliz@gnu.org>
3512
3513 * xdisp.c (forward_to_next_line_start): Accept additional argument
3514 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3515 on the newline.
3516 (reseat_at_next_visible_line_start): Use the bidi iterator state
3517 returned by forward_to_next_line_start to restore the state of
3518 it->bidi_it after backing up to previous newline. (Bug#9212)
3519
31011111
AS
35202011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3521
3522 * regex.c (re_comp): Protoize.
3523 (re_exec): Fix return type.
3524 (regexec): Fix type of `ret'. (Bug#9203)
3525
476371c4
PE
35262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3527
e5d76069
PE
3528 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3529 This is needed if max-image-size is a floating-point number.
3530
9a79b20c
AS
35312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3532
3533 * print.c (print_object): Print empty symbol as ##.
3534
3535 * lread.c (read1): Read ## as empty symbol.
3536
d8c2fa78
AA
35372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3538
3539 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3540 setting frame foreground color (Bug#9175).
3541 (x_set_background_color): Likewise.
3542
ffe57a7a
AA
3543 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3544 contents (Bug#9176).
3545 (EmacsTooltip -init): Remove bezels and add shadows to
3546 tooltip windows.
3547
bf3492a5
AA
3548 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3549 or scroll bar (Bug#8470).
3550
d55e9c53
AA
3551 * nsfont.m (nsfont_open): Remove assignment to voffset and
3552 unnecessary vars hshink, expand, hd, full_height, min_height.
3553 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3554
3555 * nsterm.h (nsfont_info): Remove voffset field.
3556
d8c2fa78 35572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3558
3559 Implement strike-through and overline on NextStep (Bug#8863).
3560
3561 * nsfont.m (nsfont_open): Use underline position provided by font,
3562 instead of hard-coded value of 2.
3563 (nsfont_draw): Call ns_draw_text_decoration instead.
3564
3565 * nsterm.h: Add declaration for ns_draw_text_decoration.
3566
3567 * nsterm.m (ns_draw_text_decoration): New function for drawing
3568 underline, overline, and strike-through.
3569 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3570 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3571 accommodate underlining, etc.
4843aac3 3572
4cc60b9b
EZ
35732011-07-28 Eli Zaretskii <eliz@gnu.org>
3574
bc7ece87
EZ
3575 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3576 default.
4cc60b9b 3577
476371c4
PE
35782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3579
66606eea
PE
3580 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3581 Without this fix, if a signal arrives just after memory fills up,
3582 'malloc' might be invoked reentrantly.
3583
476371c4
PE
3584 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3585 In other words, assume that every image size is allowed, on non-X
3586 hosts. This assumption is probably wrong, but it lets Emacs compile.
3587
f3fcc40d
AS
35882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3589
3590 * regex.c (re_iswctype): Convert return values to boolean.
3591
350c992f
EZ
35922011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3593
3594 * xdisp.c (compute_display_string_pos): Don't use cached display
3595 string position if the buffer had its restriction changed.
3596 (Bug#9184)
3597
5266b4bb
PE
35982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3601
2573a837 36022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3603
41f55ccd 3604 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3605
39e378da
PE
3606 * bidi.c: Integer size and overflow fixes.
3607 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3608 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3609 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3610 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3611 (bidi_find_other_level_edge):
3612 Use ptrdiff_t instead of EMACS_INT where either will do.
3613 This works better on 32-bit hosts configured --with-wide-int.
3614 (bidi_cache_ensure_space): Check for size-calculation overflow.
3615 Use % rather than repeated addition, for better worst-case speed.
3616 Don't set bidi_cache_size until after xrealloc returns, because it
3617 might not return.
3618 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3619 (bidi_cache_ensure_space): Also check that the bidi cache size
3620 does not exceed that of the largest Lisp string or buffer. See Eli
3621 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3622
5e927815
PE
3623 * alloc.c (__malloc_size_t): Remove.
3624 All uses replaced by size_t. See Andreas Schwab's note
3625 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3626
ca4aa935
PE
3627 * image.c: Improve checking for integer overflow.
3628 (check_image_size): Assume that f is nonnull, since
3629 it is always nonnull in practice. This is one less thing to
3630 worry about when checking for integer overflow later.
3631 (x_check_image_size): New function, which checks for integer
3632 overflow issues inside X.
3633 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3634 This removes the need for a memory_full check.
3635 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3636 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3637 (xbm_read_bitmap_data): Change locals back to 'int', since
3638 their values must fit in 'int'.
3639 (xpm_load_image, png_load, tiff_load):
3640 Invoke x_create_x_image_and_pixmap earlier,
3641 to avoid much needless work if the image is too large.
3642 (tiff_load): Treat overly large images as if
3643 x_create_x_image_and_pixmap failed, not as malloc failures.
3644 (gs_load): Use x_check_image_size.
3645
5f8f9cc2
PE
3646 * gtkutil.c: Omit integer casts.
3647 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3648 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3649
5adf60bc
PE
3650 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3651
c8907a93
PE
3652 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3653 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3654 would wrongly return t on a 64-bit host.
3655
e3c25c68
PE
3656 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3657 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3658 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3659 and therefore cause GCC to emit a bogus diagnostic in some cases.
3660
3f791afe
PE
3661 * image.c: Integer signedness and overflow and related fixes.
3662 This is not an exhaustive set of fixes, but it's time to
3663 record what I've got.
3664 (lookup_pixel_color, check_image_size): Remove redundant decls.
3665 (check_image_size): Don't assume that arbitrary EMACS_INT values
3666 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3667 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3668 (tiff_load, imagemagick_load_image):
3669 Check for overflow in size calculations.
3670 (x_create_x_image_and_pixmap): Remove unnecessary test for
3671 xmalloc returning NULL; that can't happen.
3672 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3673 (xpm_color_bucket): Use better integer hashing function.
3674 (xpm_cache_color): Don't possibly over-allocate memory.
3675 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3676 (gif_memory_source):
3677 Use ptrdiff_t, not int or size_t, to record sizes.
3678 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3679 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3680 either works, as we prefer signed integers.
3681 (tiff_read_from_memory, tiff_write_from_memory):
3682 Return tsize_t, not size_t, since that's what the TIFF API wants.
3683 (tiff_read_from_memory): Don't fail simply because the read would
3684 go past EOF; instead, return a short read.
3685 (tiff_load): Omit no-longer-needed casts.
3686 (Fimagemagick_types): Don't assume size fits into 'int'.
3687
3cc5a532
PE
3688 Improve hashing quality when configured --with-wide-int.
3689 * fns.c (hash_string): New function, taken from sxhash_string.
3690 Do not discard information about ASCII character case; this
3691 discarding is no longer needed.
3692 (sxhash-string): Use it. Change sig to match it. Caller changed.
3693 * lisp.h: Declare it.
3694 * lread.c (hash_string): Remove, since we now use fns.c's version.
3695 The fns.c version returns a wider integer if --with-wide-int is
3696 specified, so this should help the quality of the hashing a bit.
3697
b312a492
PE
3698 * emacs.c: Integer overflow minor fix.
3699 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3700 Define only if GNU_LINUX.
3701 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3702
dfd153ae
PE
3703 * dispnew.c: Integer signedness and overflow fixes.
3704 Remove unnecessary forward decls, that were a maintenance hassle.
3705 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3706 All uses changed.
3707 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3708 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3709 (prepare_desired_row, line_draw_cost):
3710 Use int, not unsigned, where either works.
3711 (save_current_matrix, restore_current_matrix):
3712 Use ptrdiff_t, not size_t, where either works.
3713 (init_display): Check for overflow more accurately, and without
3714 relying on undefined behavior.
3715
a81d11a3
PE
3716 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3717 Remove, replacing with the new symbols in lisp.h. All uses changed.
3718 * fileio.c (make_temp_name):
3719 * filelock.c (lock_file_1, lock_file):
3720 * xdisp.c (message_dolog):
3721 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3722 Use pMd etc. instead.
3723 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3724 replacing the pWIDE etc. symbols removed from editfns.c.
3725
3300e6fd
PE
3726 * keyboard.h (num_input_events): Now uintmax_t.
3727 This is (very slightly) less likely to mess up due to wraparound.
3728 All uses changed.
3729
fd05c7e9
PE
3730 * buffer.c: Integer signedness fixes.
3731 (alloc_buffer_text, enlarge_buffer_text):
3732 Use ptrdiff_t rather than size_t when either will do, as we prefer
3733 signed integers.
3734
903fe15d
PE
3735 * alloc.c: Integer signedness and overflow fixes.
3736 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3737 (__malloc_size_t): Default to size_t, not to int.
3738 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3739 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3740 Prefer ptrdiff_t to size_t when either would do, as we prefer
3741 signed integers.
3742 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3743 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3744 Now const. Initialize with values that are in range even if char
3745 is signed.
3746 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3747 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3748 These functions do the right thing with sizes > 2**32.
3749 (check_depth): Now ptrdiff_t, not int.
3750 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3751 Adjust to new way of storing sizes. Check for size overflow bugs
3752 in rest of code.
3753 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3754 slightly wrong anyway, as it missed one instance of
3755 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3756 (refill_memory_reserve): Omit needless cast to size_t.
3757 (mark_object_loop_halt): Mark as externally visible.
3758
ac82cc6a
PE
3759 * xselect.c: Integer signedness and overflow fixes.
3760 (Fx_register_dnd_atom, x_handle_dnd_message):
3761 Use ptrdiff_t, not size_t, since we prefer signed.
3762 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3763 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3764 x_dnd_atoms_size and x_dnd_atoms_length.
3765
c2d1e36d
PE
3766 * doprnt.c: Prefer signed to unsigned when either works.
3767 * eval.c (verror):
3768 * doprnt.c (doprnt):
3769 * lisp.h (doprnt):
3770 * xdisp.c (vmessage):
3771 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3772 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3773 prefer signed arithmetic to avoid comparison confusion.
3774 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3775 but is a bit tricky.
3776
0e926e56
PE
3777 Assume freestanding C89 headers, string.h, stdlib.h.
3778 * data.c, doprnt.c, floatfns.c, print.c:
3779 Include float.h unconditionally.
3780 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3781 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3782 * regex.c: Likewise for stddef.h, string.h.
3783 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3784 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3785 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3786 (STDC_HEADERS): Remove obsolete defines.
3787 * sysdep.c: Include limits.h unconditionally.
3788
9cfdb3ec
PE
3789 Assume support for memcmp, memcpy, memmove, memset.
3790 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3791 * regex.c (memcmp, memcpy):
3792 Remove; we assume C89 now.
3793
3794 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3795 (__malloc_safe_bcopy): Remove; no longer needed.
3796
cf950e6b 3797 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3798 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3799 well either way, and we prefer signed to unsigned.
3800
dbf38e02
LMI
38012011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3802
3803 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3804 closes the connection while we're reading (bug#9182).
3805
d6f0886c 38062011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3807
d6f0886c
JD
3808 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3809 are specified (Bug#9168).
24e0f6b1 3810
2eb1f9e6
PE
38112011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3814 Found by GCC static checking and --with-wide-int on a 32-bit host.
3815
22381272 38162011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3817
3818 * xdisp.c (compute_display_string_pos): Fix logic of caching
3819 previous display string position. Initialize cached_prev_pos to
3820 -1. Fixes slow-down at the beginning of a buffer.
3821
f25e39b4
EZ
38222011-07-24 Eli Zaretskii <eliz@gnu.org>
3823
3824 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3825 for attrs[LFACE_FONTSET_INDEX].
3826
04c4b52e
PE
38272011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3828
3829 * xml.c (parse_region): Remove unused local
3830 that was recently introduced.
3831
c1734fbd
EZ
38322011-07-23 Eli Zaretskii <eliz@gnu.org>
3833
be18c5a5
EZ
3834 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3835 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3836
c1734fbd
EZ
3837 * xdisp.c (move_it_in_display_line_to): Record the best matching
3838 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3839 exit if none of the characters scanned was an exact match.
3840 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3841 when exact match is impossible due to invisible text, and the
3842 lines are truncated.
3843
a258d627
JD
38442011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3845
3846 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3847 for OSX >= 10.7.
3848
b6d5a689
EZ
38492011-07-22 Eli Zaretskii <eliz@gnu.org>
3850
0f74f785
EZ
3851 Fix a significant slow-down of cursor motion with C-n, C-p,
3852 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3853 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3854 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3855 (next_element_from_buffer): Call compute_stop_pos_backwards to
3856 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3857 base_level_stop.
3858 (reseat): Don't look for prev_stop, as that could mean a very long
3859 run.
3860 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3861 <cached_disp_overlay_modiff>: Cache for last found display string
3862 position.
551918c1 3863 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3864 about the same buffer in the same area of character positions, and
3865 the buffer wasn't changed since the time the display string
3866 position was cached.
551918c1 3867
b2d0c91a
EZ
38682011-07-22 Eli Zaretskii <eliz@gnu.org>
3869
3870 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3871 is an integer, which is important for empty lines. (Bug#9149)
3872
043604ee
CY
38732011-07-22 Chong Yidong <cyd@stupidchicken.com>
3874
3875 * frame.c (Fmodify_frame_parameters): In tty case, update the
3876 default face if necessary (Bug#4238).
3877
da4adb04
CY
38782011-07-21 Chong Yidong <cyd@stupidchicken.com>
3879
3880 * editfns.c (Fstring_to_char): No need to explain what a character
3881 is in the docstring (Bug#6576).
3882
9abd0532
LMI
38832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3884
3885 * xml.c (parse_region): Make sure we always return a tree.
3886
36881d16
HK
38872011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3888
3889 * xml.c (parse_region): If a document contains only comments,
3890 return that, too.
3891
1e98674d
LMI
38922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3893
3894 * xml.c (make_dom): Return comments, too.
3895
590bd467
PE
38962011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3897
3898 Port to OpenBSD.
3899 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3900 and the surrounding thread.
3901 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3902 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3903 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3904 timer goes off.
3905 * s/openbsd.h (BROKEN_SIGIO): Define.
3906 * unexelf.c (unexec) [__OpenBSD__]:
3907 Don't update the .mdebug section of the Alpha COFF symbol table.
3908
f41628b2
LMI
39092011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3910
3911 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3912 (bug#8460).
3913
b59b67c5
PE
39142011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3915
15e3a074
PE
3916 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3917 This fixes some race conditions on the permissions of any newly
3918 created file.
3919
41bed37d
PE
3920 * alloc.c (valid_pointer_p): Use pipe, not open.
3921 This fixes some permissions issues when debugging.
3922
b59b67c5
PE
3923 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3924 If fchown fails to set both uid and gid, try to set just gid,
3925 as that is sometimes allowed. Adjust the file's mode to eliminate
3926 setuid or setgid bits that are inappropriate if fchown fails.
3927
925a6be7
SM
39282011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3929
3930 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3931 to compare Lisp_Objects.
3932 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3933 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3934 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3935
52968808
AS
39362011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3937
0a6a104b
AS
3938 * lread.c (read_integer): Unread even EOF character.
3939 (read1): Likewise. Properly record start position of symbol.
3940
52968808
AS
3941 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3942 symbol character follows.
3943
9e381cdd
PE
39442011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3947 This works around a problem with the previous change to Fcopy_file.
3948 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3949 and without this change, GCC might complain about discarding
3950 fchown's return value.
3951
b5641435
JB
39522011-07-16 Juanma Barranquero <lekktu@gmail.com>
3953
3954 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3955
a8031457
PE
39562011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3959
dd889327
LMI
39602011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961
750c33f7
LMI
3962 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3963 it's used from the C level.
3964
dd889327
LMI
3965 * process.c: Use the same condition for POLL_FOR_INPUT in both
3966 keyboard.c and process.c (bug#1858).
3967
87e86684
LM
39682011-07-09 Lawrence Mitchell <wence@gmx.li>
3969
3970 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3971 (Fgnutls_boot): Use it.
3972
64348f40
AS
39732011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3974
3975 * doc.c (Fsubstitute_command_keys): Revert last change.
3976
1d698799
LMI
39772011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3978
f863868c
LMI
3979 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3980 quotes the next character, and doesn't affect other longer
3981 sequences (bug#8935).
3982
1d698799
LMI
3983 * lread.c (syms_of_lread): Clarify that is isn't only
3984 `eval-buffer' and `eval-defun' that's affected by
3985 `lexical-binding' (bug#8460).
3986
aa4b6df6
EZ
39872011-07-15 Eli Zaretskii <eliz@gnu.org>
3988
3989 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3990 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3991
5d856da6
PE
39922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3993
ad6042bb
PE
3994 Fix minor problems found by static checking.
3995 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3996 (elsz): Now a signed constant, not a size_t var. We prefer signed
3997 types to unsigned, to avoid integer comparison confusion. Without
3998 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3999 "cannot optimize loop, the loop counter may overflow", a symptom
4000 of the confusion.
f00bbb22 4001 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4002 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4003
6468f31c
LMI
40042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4005
49080b10
LMI
4006 * search.c (Fre_search_backward): Mention `case-fold-search' in
4007 all the re_search_* functions (bug#8138).
4008
6468f31c
LMI
4009 * keyboard.c (Fopen_dribble_file): Document when the file is
4010 closed (bug#8056).
4011
c965adc5
EZ
40122011-07-14 Eli Zaretskii <eliz@gnu.org>
4013
df9733bf
EZ
4014 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4015 bidi_cache_idx.
4016
0bb23927
EZ
4017 Support bidi reordering of display and overlay strings.
4018 * xdisp.c (compute_display_string_pos)
4019 (compute_display_string_end): Accept additional argument STRING.
4020 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4021 (reseat_to_string): Initialize bidi_it->string.s and
4022 bidi_it->string.schars.
4023 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4024 NULL (avoids a crash in bidi_paragraph_init).
4025 Initialize itb.string.lstring.
0bb23927
EZ
4026 (init_iterator): Call bidi_init_it only of a valid
4027 buffer position was specified. Initialize paragraph_embedding to
4028 L2R.
4029 (reseat_to_string): Initialize the bidi iterator.
4030 (display_string): If we need to ignore text properties of
4031 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4032 original value of -1 will not work with bidi.)
4033 (compute_display_string_pos): First arg is now struct
4034 `text_pos *'; all callers changed. Support display properties on
4035 Lisp strings.
4036 (compute_display_string_end): Support display properties on Lisp
4037 strings.
4038 (init_iterator, reseat_1, reseat_to_string): Initialize the
4039 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4040 when iterating on a string not from display properties).
640c8776
SM
4041 (compute_display_string_pos, compute_display_string_end):
4042 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4043 arrow keys.
4044 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4045 base_level_stop; instead, set base_level_stop to BEGV.
4046 Fixes crashes in vertical-motion.
0bb23927
EZ
4047 (next_element_from_buffer): Improve commentary for when
4048 the iterator is before prev_stop.
4049 (init_iterator): Initialize bidi_p from the default value of
4050 bidi-display-reordering, not from buffer-local value. Use the
4051 buffer-local value only if initializing for buffer iteration.
4052 (handle_invisible_prop): Support invisible properties on strings
4053 that are being bidi-reordered.
4054 (set_iterator_to_next): Support bidi reordering of C strings and
4055 Lisp strings.
4056 (next_element_from_string): Support bidi reordering of Lisp
4057 strings.
4058 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4059 (display_string): Support display of R2L glyph rows.
4060 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4061 (init_iterator): Don't initialize it->bidi_p for strings
4062 here.
4063 (reseat_to_string): Initialize it->bidi_p for strings here.
4064 (next_element_from_string, next_element_from_c_string)
4065 (next_element_from_buffer): Add xassert's for correspondence
4066 between IT's object being iterated and it->bidi_it.string
4067 structure.
4068 (face_before_or_after_it_pos): Support bidi iteration.
4069 (next_element_from_c_string): Handle the case of the first string
4070 character that is not the first one in the visual order.
4071 (get_visually_first_element): New function, refactored from common
4072 parts of next_element_from_buffer, next_element_from_string, and
4073 next_element_from_c_string.
4074 (tool_bar_lines_needed, redisplay_tool_bar)
4075 (display_menu_bar): Force left-to-right direction. Add a FIXME
4076 comment for making that be controlled by a user option.
4077 (push_it, pop_it): Save and restore the state of the
4078 bidi iterator. Save and restore the bidi_p flag.
4079 (pop_it): Iterate out of display property for string iteration as
4080 well.
4081 (iterate_out_of_display_property): Support iteration over strings.
4082 (handle_single_display_spec): Set up it->bidi_it for iteration
4083 over a display string, and call bidi_init_it.
4084 (handle_single_display_spec, next_overlay_string)
4085 (get_overlay_strings_1, push_display_prop): Set up the bidi
4086 iterator for displaying display or overlay strings.
4087 (forward_to_next_line_start): Don't use the shortcut if
4088 bidi-iterating.
4089 (back_to_previous_visible_line_start): If handle_display_prop
4090 pushed the iterator stack, restore the internal state of the bidi
4091 iterator by calling bidi_pop_it same number of times.
4092 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4093 and we are bidi-iterating, don't decrement the iterator position;
4094 instead, set the first_elt flag in the bidi iterator, to produce
4095 the same effect.
4096 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4097 (push_display_prop): xassert that we are iterating a buffer.
4098 (push_it, pop_it): Save and restore paragraph_embedding member.
4099 (handle_single_display_spec, next_overlay_string)
4100 (get_overlay_strings_1, reseat_1, reseat_to_string)
4101 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4102 correctly. Don't assume unibyte strings are not bidi-reordered.
4103 (compute_display_string_pos)
4104 (compute_display_string_end): Fix handling the case of C string.
4105 (push_it, pop_it): Save and restore from_disp_prop_p.
4106 (handle_single_display_spec, push_display_prop): Set the
4107 from_disp_prop_p flag.
4108 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4109 (pop_it): Call iterate_out_of_display_property only if we are
4110 popping after iteration over a string that came from a display
4111 property. Fix a typo in popping stretch info. Add an assertion
4112 for verifying that the iterator position is in sync with the bidi
4113 iterator.
4114 (handle_single_display_spec, get_overlay_strings_1)
4115 (push_display_prop): Fix initialization of paragraph direction for
4116 string when that of the parent object is not yet determined.
4117 (reseat_1): Call bidi_init_it to resync the bidi
4118 iterator with IT's position. (Bug#7616)
4119 (find_row_edges): If ROW->start.pos gives position
4120 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4121 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4122 Reset the from_disp_prop_p flag.
4123 (SAVE_IT, RESTORE_IT): New macros.
4124 (pos_visible_p, face_before_or_after_it_pos)
4125 (back_to_previous_visible_line_start)
4126 (move_it_in_display_line_to, move_it_in_display_line)
4127 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4128 (try_scrolling, redisplay_window, display_line): Use them when
4129 saving a temporary copy of the iterator and restoring it back.
4130 (back_to_previous_visible_line_start, reseat_1)
4131 (init_iterator): Empty the bidi cache "stack".
4132 (move_it_in_display_line_to): If iterator ended up at
4133 EOL, but we never saw any buffer positions smaller than
4134 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4135 motion in bidi-reordered lines.
4136 (move_it_in_display_line_to): Record prev_method and prev_pos
4137 immediately before the call to set_iterator_to_next. Fixes cursor
4138 motion in bidi-reordered lines with stretch glyphs and strings
4139 displayed in margins. (Bug#8133) (Bug#8867)
4140 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4141 TO_CHARPOS.
640c8776
SM
4142 (pos_visible_p): Support positions in bidi-reordered lines.
4143 Save and restore bidi cache.
0bb23927
EZ
4144
4145 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4146 (bidi_paragraph_info): Delete unused struct.
4147 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4148 (bidi_cache_start): New variable.
4149 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4150 to zero.
4151 (bidi_cache_fetch_state, bidi_cache_search)
4152 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4153 (bidi_cache_find, bidi_peek_at_next_level)
4154 (bidi_level_of_next_char, bidi_find_other_level_edge)
4155 (bidi_move_to_visually_next): Compare cache index with
4156 bidi_cache_start rather than with zero.
4157 (bidi_fetch_char): Accept new argument STRING; all callers
4158 changed. Support iteration over a string. Support strings with
4159 display properties. Support unibyte strings. Fix the type of
4160 `len' according to what STRING_CHAR_AND_LENGTH expects.
4161 (bidi_paragraph_init, bidi_resolve_explicit_1)
4162 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4163 (bidi_level_of_next_char, bidi_move_to_visually_next):
4164 Support iteration over a string.
0bb23927
EZ
4165 (bidi_set_sor_type, bidi_resolve_explicit_1)
4166 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4167 can now be zero (for strings); special values 0 and -1 were
4168 changed to -1 and -2, respectively.
4169 (bidi_char_at_pos): New function.
4170 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4171 Call it instead of FETCH_MULTIBYTE_CHAR.
4172 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4173 initialized to valid values.
4174 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4175 values.
4176 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4177 the test for valid cached positions. Fix the logic for looking up
4178 the sentinel state in the cache. GCPRO the Lisp string we are
4179 iterating.
4180 (bidi_push_it, bidi_pop_it): New functions.
4181 (bidi_initialize): Initialize the bidi cache start stack pointer.
4182 (bidi_cache_ensure_space): New function, refactored from part of
4183 bidi_cache_iterator_state. Don't assume the required size is just
4184 one BIDI_CACHE_CHUNK away.
4185 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4186 (bidi_count_bytes, bidi_char_at_pos): New functions.
4187 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4188 always valid if bidi_cache_idx is valid.
4189 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4190 is valid if it's going to be used.
4191 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4192 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4193 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4194 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4195 (bidi_find_other_level_edge, bidi_cache_start_stack):
4196 All variables related to cache indices are now EMACS_INT.
c965adc5 4197
0bb23927
EZ
4198 * dispextern.h (struct bidi_string_data): New structure.
4199 (struct bidi_it): New member `string'. Make flag members be 1-bit
4200 fields, and put them last in the struct.
640c8776
SM
4201 (compute_display_string_pos, compute_display_string_end):
4202 Update prototypes.
0bb23927
EZ
4203 (bidi_push_it, bidi_pop_it): Add prototypes.
4204 (struct iterator_stack_entry): New members bidi_p,
4205 paragraph_embedding, and from_disp_prop_p.
4206 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4207 (bidi_shelve_cache, bidi_unshelve_cache):
4208 Declare prototypes.
0bb23927
EZ
4209
4210 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4211 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4212 and vector-like objects.
4213
4214 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4215 cache around display iteration.
4216
4217 * window.c (Fwindow_end, window_scroll_pixel_based)
4218 (displayed_window_lines, Frecenter): Save and restore the bidi
4219 cache around display iteration.
4220
3bbd2265
LMI
42212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4222
4223 * editfns.c (Fdelete_region): Clarify the use of the named
4224 parameters (bug#6788).
4225
adc47434
MR
42262011-07-14 Martin Rudalics <rudalics@gmx.at>
4227
4228 * indent.c (Fvertical_motion): Set and restore w->pointm when
4229 saving and restoring the window's buffer (Bug#9006).
4230
837c31f8
LMI
42312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4232
4233 * editfns.c (Fstring_to_char): Clarify just what is returned
4234 (bug#6576). Text by Eli Zaretskii.
4235
ac389d0c
JB
42362011-07-13 Juanma Barranquero <lekktu@gmail.com>
4237
4238 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4239
0be0ce47
EZ
42402011-07-13 Eli Zaretskii <eliz@gnu.org>
4241
4242 * buffer.c (mmap_find): Fix a typo.
4243
cd18e7e3
JB
42442011-07-13 Johan Bockgård <bojohan@gnu.org>
4245
4246 Fix execution of x selection hooks.
4247 * xselect.c (Qx_lost_selection_functions)
4248 (Qx_sent_selection_functions): New vars.
4249 (syms_of_xselect): DEFSYM them.
4250 (x_handle_selection_request): Pass Qx_sent_selection_functions
4251 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4252 (x_handle_selection_clear,x_clear_frame_selections):
4253 Pass Qx_lost_selection_functions rather than
4254 Vx_lost_selection_functions to Frun_hook_with_args.
4255
47ea7f44
PE
42562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4257
ac389d0c 4258 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4259 The old code sometimes used this field without initializing it.
4260
47ea7f44
PE
4261 * alloc.c (gc_sweep): Don't read past end of array.
4262 In theory, the old code could also have corrupted Emacs internals,
4263 though it'd be very unlikely.
4264
bc985c87
AS
42652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4266
4267 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4268 argument. (Bug#4026)
bc985c87 4269
0cf34688
LMI
42702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4271
b3dadd76
LMI
4272 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4273 key" (bug#4257).
4274
0cf34688
LMI
4275 * window.c (Fset_window_start): Doc fix (bug#4199).
4276 (Fset_window_hscroll): Ditto.
4277
270768cd
PE
42782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4279
077e3dda 4280 Fix minor new problems caught by GCC 4.6.1.
270768cd 4281 * term.c (init_tty): Remove unused local.
490011a6 4282 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4283 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4284 not used otherwise.
270768cd 4285
b1f58454
CY
42862011-07-12 Chong Yidong <cyd@stupidchicken.com>
4287
4288 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4289
22b9578d
LMI
42902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4291
6e70ab07
LMI
4292 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4293 are the mini-buffer and the echo area (bug#3320).
4294
22b9578d
LMI
4295 * term.c (init_tty): Remove support for supdup, c10 and perq
4296 terminals, which are no longer supported (bug#1482).
4297
8974cc9f
JB
42982011-07-10 Johan Bockgård <bojohan@gnu.org>
4299
4300 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4301
a560d974
JD
43022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4303
4304 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4305 for non-popups (Bug#3642).
4306
1dae0f0a
AS
43072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4308
268c2c36 4309 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4310 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4311 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4312 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4313 * data.c (fmod): Likewise.
4314 * dispnew.c (swap_glyphs_in_rows): Likewise.
4315 * emacs.c (memory_warning_signal): Likewise.
4316 * floatfns.c (float_error): Likewise.
4317 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4318 (otf_open, font_otf_capability, generate_otf_features)
4319 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4320 Likewise.
4321 * image.c (pbm_read_file): Likewise.
4322 * indent.c (string_display_width): Likewise.
4323 * intervals.c (check_for_interval, search_for_interval)
4324 (inc_interval_count, count_intervals, root_interval)
4325 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4326 * lread.c (defalias): Likewise.
268c2c36 4327 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4328 * regex.c (set_image_of_range_1, set_image_of_range)
4329 (regex_grow_registers): Likewise.
4330 * sysdep.c (strerror): Likewise.
4331 * termcap.c (valid_filename_p, tprint, main): Likewise.
4332 * tparam.c (main): Likewise.
4333 * unexhp9k800.c (run_time_remap, save_data_space)
4334 (update_file_ptrs, read_header, write_header, calculate_checksum)
4335 (copy_file, copy_rest, display_header): Likewise.
4336 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4337 Likewise.
4338 * xdisp.c (check_it): Likewise.
4339 * xfaces.c (register_color, unregister_color, unregister_colors):
4340 Likewise.
4341 * xfns.c (print_fontset_result): Likewise.
4342 * xrdb.c (member, fatal, main): Likewise.
4343
99033785
PE
43442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 Fix minor problems found by static checking (Bug#9031).
4347 * chartab.c (char_table_set_range, map_sub_char_table):
4348 Remove unused locals.
4349 (uniprop_table): Now static.
4350 * composite.c (_work_char): Remove unused static var.
4351
9cb2ac56
JB
43522011-07-09 Juanma Barranquero <lekktu@gmail.com>
4353
4354 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4355
f25661f0
JD
43562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4357
4358 * gtkutil.c (qttip_cb): Remove code without function.
4359
8278c4fe
EZ
43602011-07-09 Eli Zaretskii <eliz@gnu.org>
4361
4362 * w32.c (pthread_sigmask): New stub.
4363
1692ae2d 43642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4365
8a6ebd58 4366 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4367 sigprocmask is portable only for single-threaded applications, and
4368 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4369 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4370 (LIBES): Use it.
4371 * callproc.c (Fcall_process):
4372 * process.c (create_process):
4373 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4374 Use pthread_sigmask, not sigprocmask.
123403e4 4375
1b854618
JD
43762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4377
4378 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4379 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4380 wrong (Bug#8591).
4381
3fe4b549
JD
43822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4383
0ce7e563
JD
4384 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4385 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4386 (xg_hide_tooltip): Fix comment.
4387
3fe4b549
JD
4388 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4389 in registerServicesMenuSendTypes.
4390 (validRequestorForSendType): Don't check ns_return_types.
4391
4392 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4393 ns_return_type.
4394
5df75e47
JR
43952011-07-08 Jason Rumney <jasonr@gnu.org>
4396
22610910
JR
4397 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4398 SH_SHOW for hidden windows (Bug#5482).
4399
5df75e47
JR
4400 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4401 frame struct members of non-existent frames (Bug#6284).
4402
699c10bd
JD
44032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4404
4393663b
JD
4405 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4406 variable firstTime not needed on OSX >= 10.6.
4407 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4408 >= 10.5. Use setKnobProportion, setDoubleValue.
4409
4410 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4411 (MAC_OS_X_VERSION_10_5): Define if not defined.
4412 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4413 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4414 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4415
4416 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4417 cString and lossyCString on OSX >= 10.4
4418
58179cce 4419 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4420 sizeToFit on OSX >= 10.2.
4421
4422 * nsimage.m (allocInitFromFile): Don't use deprecated method
4423 bestRepresentationForDevice on OSX >= 10.6.
4424
4425 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4426 to avoid warning.
4427
4428 * emacs.c: Declare unexec_init_emacs_zone.
4429
a63e0781
JD
4430 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4431
699c10bd
JD
4432 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4433
4434 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4435 on svcsMenu (Bug#8842).
4436
4437 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4438 ns_return_types.
4439 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4440
4441 * nsterm.m (QUTF8_STRING): Declare.
4442 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4443 (validRequestorForSendType): Return type is (id).
4444 Change indexOfObjectIdenticalTo to indexOfObject.
4445 Check if we have local selection before returning self (Bug#8842).
4446 (writeSelectionToPasteboard): Put local selection into paste board
4447 if we have a local selection (Bug#8842).
4448 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4449
4450 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4451 (ns_get_local_selection): Declare.
4452
54e10184
LMI
44532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4454
9888ff71
LMI
4455 * keymap.c (describe_map_tree): Don't insert a double newline at
4456 the end of the buffer (bug#1169) and return whether we inserted
4457 something.
4458
54e10184
LMI
4459 * callint.c (Fcall_interactively): Change "reading args" to
4460 "providing args" to try to clarify what it does (bug#1010).
4461
15fa4783
KH
44622011-07-07 Kenichi Handa <handa@m17n.org>
4463
4464 * composite.c (composition_compute_stop_pos): Ignore a static
4465 composition starting before CHARPOS (Bug#8915).
4466
4467 * xdisp.c (handle_composition_prop): Likewise.
4468
a8815b00
EZ
44692011-07-07 Eli Zaretskii <eliz@gnu.org>
4470
4471 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4472 (Bug#9015)
4473
ef7b981d 44742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4475
4476 * character.h (unicode_category_t): New enum type.
4477
4478 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4479 (Qchar_code_property_table): New variable.
4480 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4481 (UNIPROP_COMPRESSED_FORM_P): New macros.
4482 (char_table_ascii): Uncompress the compressed values.
4483 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4484 Uncompress the compressed values.
ac389d0c 4485 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4486 (char_table_ref_and_range): Uncompress the compressed values.
4487 (sub_char_table_set): New arg is_uniprop. Callers changed.
4488 Uncompress the compressed values.
4489 (sub_char_table_set_range): Args changed. Callers changed.
4490 (char_table_set_range): Adjuted for the above change.
4491 (map_sub_char_table): Delete args default_val and parent. Add arg
4492 top. Give decoded values to a Lisp function.
640c8776 4493 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4494 values to a Lisp function. Gcpro more variables.
4495 (uniprop_table_uncompress)
4496 (uniprop_decode_value_run_length): New functions.
4497 (uniprop_decoder, uniprop_decoder_count): New variables.
4498 (uniprop_get_decoder, uniprop_encode_value_character)
4499 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4500 New functions.
4501 (uniprop_encoder, uniprop_encoder_count): New variables.
4502 (uniprop_get_encoder, uniprop_table)
4503 (Funicode_property_table_internal, Fget_unicode_property_internal)
4504 (Fput_unicode_property_internal): New functions.
4505 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4506 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4507 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4508 char-code-property-alist.
4509
640c8776 4510 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4511 Vunicode_category_table.
4512
640c8776 4513 * font.c (font_range): Adjust for the change of
c805dec0
KH
4514 Vunicode_category_table.
4515
76b397fb
DN
45162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4517
4518 * m/iris4d.h: Remove file, move contents ...
4519 * s/irix6-5.h: ... here.
4520
22b4128e
PE
45212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4522
4523 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4524 * alloc.c (mark_buffer):
4525 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4526 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4527 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4528 This isn't true in general, and it's particularly not true
4529 if Emacs is configured with --with-wide-int.
4530 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4531 New macros, used in the buffer.c change.
4532
869795d6
JD
45332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4534
4535 * xsettings.c: Use both GConf and GSettings if both are available.
4536 (store_config_changed_event): Add comment.
4537 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4538 (store_tool_bar_style_changed): New functions.
5e617bc2 4539 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4540 (struct xsettings): Move font inside HAVE_XFT.
4541 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4542 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4543 Move inside HAVE_XFT.
640c8776 4544 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4545 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4546 also.
4547 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4548 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4549 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4550 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4551 (parse_settings): Move check for font inside HAVE_XFT.
4552 (read_settings, apply_xft_settings): Add comment.
4553 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4554 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4555 call store_font_name_changed.
4556 (xft_settings_event): Add comment.
4557 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4558 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4559 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4560 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4561 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4562 (xsettings_get_system_font, xsettings_get_system_normal_font):
4563 Add comment.
869795d6 4564
d8ed26bd
PE
45652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4566
4567 Random fixes. E.g., (random) never returned negative values.
4568 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4569 subseconds part to the entropy, as that's a bit more random.
4570 Prefer signed to unsigned, since the signedness doesn't matter and
4571 in general we prefer signed. When given a limit, use a
4572 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4573 latter isn't right if USE_2_TAGS_FOR_INTS.
4574 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4575 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4576
cabf1cac
SM
45772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4578
4579 * textprop.c (text_property_stickiness):
4580 Obey Vtext_property_default_nonsticky.
4581 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4582 * w32fns.c (syms_of_w32fns):
4583 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4584
6e9b2be9
PE
45852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4588 This is more efficient than Ffile_directory_p and avoids a minor race.
4589
90186c68
LMI
45902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4591
7c301272
LMI
4592 * buffer.c (Foverlay_put): Say what the return value is
4593 (bug#7835).
4594
c4f2d8d4
LMI
4595 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4596 is a directory before asking whether to use the file name
4597 (bug#7564).
ad637907
LMI
4598 (barf_or_query_if_file_exists): Make the "File is a directory"
4599 error be more correct.
c4f2d8d4 4600
90186c68
LMI
4601 * fns.c (Frequire): Remove the mention of the .gz files, since
4602 that's installation-specific, but keep the mention of
4603 `get-load-suffixes'.
4604
da64016e
PE
46052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4606
4607 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4608 Report string overflow if the output is too long.
4609
7d47b580
JB
46102011-07-04 Juanma Barranquero <lekktu@gmail.com>
4611
a555cb87
JB
4612 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4613 (syms_of_gnutls): Remove duplicate DEFSYM for
4614 Qgnutls_bootprop_verify_hostname_error, an error for
4615 Qgnutls_bootprop_verify_error (which is no longer used).
4616
7d47b580
JB
4617 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4618 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4619 Also (re)move comments that are misplaced or no longer relevant.
4620
1e49bfab
LMI
46212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4622
4623 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4624
1485f4c0
CY
46252011-07-03 Chong Yidong <cyd@stupidchicken.com>
4626
4627 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4628 and background color parameters if they have been changed.
4629
a9ab721e
LMI
46302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4631
4632 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4633
cf7cff57
PE
46342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4635
2e13213d
PE
4636 * xsettings.c (SYSTEM_FONT): Define only when used.
4637 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4638
cf7cff57
PE
4639 * keymap.c (access_keymap_1): Now static.
4640
7a8e04f7
CY
46412011-07-02 Chong Yidong <cyd@stupidchicken.com>
4642
4643 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4644 leave any prefix arg for the up event (Bug#1586).
4645
61352f62
LMI
46462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4647
69bb1ef7
LMI
4648 * lread.c (syms_of_lread): Mention single symbols defined by
4649 `defvar' or `defconst' (bug#7154).
4650
61352f62 4651 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4652 (Frequire): Mention get-load-suffixes.
61352f62 4653
28545e04
MR
46542011-07-02 Martin Rudalics <rudalics@gmx.at>
4655
4656 * window.h (window): Remove clone_number slot.
4657 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4658 Remove.
4659 (make_parent_window, make_window, saved_window)
4660 (Fset_window_configuration, save_window_save): Don't deal with
4661 clone numbers.
4662 * buffer.c (Qclone_number): Remove declaration.
4663 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4664
3349e122
SM
46652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4666
4667 Add multiple inheritance to keymaps.
4668 * keymap.c (Fmake_composed_keymap): New function.
4669 (Fset_keymap_parent): Simplify.
4670 (fix_submap_inheritance): Remove.
4671 (access_keymap_1): New function extracted from access_keymap to handle
4672 embedded parents and handle lists of maps.
4673 (access_keymap): Use it.
4674 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4675 (Fcopy_keymap): Handle embedded parents.
4676 (Fcommand_remapping, define_as_prefix): Simplify.
4677 (Fkey_binding): Simplify.
4678 (syms_of_keymap): Move minibuffer-local-completion-map,
4679 minibuffer-local-filename-completion-map,
4680 minibuffer-local-must-match-map, and
4681 minibuffer-local-filename-must-match-map to Elisp.
4682 (syms_of_keymap): Defsubr make-composed-keymap.
4683 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4684 (parse_menu_item): Trivial simplification.
4685
3279eb87
GM
46862011-07-01 Glenn Morris <rgm@gnu.org>
4687
4688 * Makefile.in (SETTINGS_LIBS): Fix typo.
4689
4550efdf
KI
46902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4691
4692 * coding.c (Fencode_coding_string): Record the last coding system
4693 used, as the function doc string says (bug#8738).
4694
0949d2b6
JD
46952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4696
4697 * xsettings.c (store_monospaced_changed): Take new font as arg and
4698 check for change against current_mono_font.
4699 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4700 (emacs_settings_constructor, emacs_settings_get_property)
4701 (emacs_settings_set_property, emacs_settings_class_init)
4702 (emacs_settings_init, gsettings_obj): Remove.
4703 (something_changedCB): New function for HAVE_GSETTINGS.
4704 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4705 with value as argument.
4706 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4707 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4708 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4709 "changed".
4710
4711 * xgselect.c: Add defined (HAVE_GSETTINGS).
4712 (xgselect_initialize): Ditto.
4713
4714 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4715 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4716 xg_select.
4717
bbc6b304
PE
47182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4719
4720 * eval.c (struct backtrace): Simplify and port the data structure.
4721 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4722 signed bit field, as this assumption is not portable and it makes
4723 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4724 "char debug_on_exit : 1" as this is not portable either; instead,
4725 use the portable "unsigned int debug_on_exit : 1". Remove unused
4726 member evalargs. Remove obsolete comments about cc bombing out.
4727
9851bfc5
JD
47282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4729
51bb811f 4730 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4731 Let HAVE_GSETTINGS override HAVE_GCONF.
4732 (store_monospaced_changed): New function.
4733 (EMACS_SETTINGS): A new type derived from GObject to handle
4734 GSettings notifications.
4735 (emacs_settings_constructor, emacs_settings_get_property)
4736 (emacs_settings_set_property, emacs_settings_class_init):
4737 New functions.
4738 (gsettings_client, gsettings_obj): New variables.
4739 (GSETTINGS_SCHEMA): New define.
4740 (something_changedCB): Call store_monospaced_changed.
4741 (init_gsettings): New function.
4742 (xsettings_initialize): Call init_gsettings.
4743 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4744 to NULL.
4745
640c8776 4746 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4747 GCONF_CFLAGS/LIBS.
4748
5386012d
MR
47492011-06-29 Martin Rudalics <rudalics@gmx.at>
4750
4751 * window.c (resize_root_window, grow_mini_window)
4752 (shrink_mini_window): Rename Qresize_root_window to
4753 Qwindow_resize_root_window and Qresize_root_window_vertically to
4754 Qwindow_resize_root_window_vertically.
4755
f13e0b08
PE
47562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4757
4758 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4759
94515237
JB
47602011-06-27 Juanma Barranquero <lekktu@gmail.com>
4761
4762 * makefile.w32-in: Redesign dependencies so they reflect more
4763 clearly which files are directly included by each source file,
4764 and not through other includes.
4765
e43b6e43
MR
47662011-06-27 Martin Rudalics <rudalics@gmx.at>
4767
4768 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4769 (sort_overlays, overlay_strings): When an overlay's clone number
4770 matches the window's clone number process the overlay even if
4771 the overlay's window property doesn't match the current window.
4772
d68443dc
MR
4773 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4774 (Fwindow_hchild): Rename to Fwindow_left_child.
4775 (Fwindow_next): Rename to Fwindow_next_sibling.
4776 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4777 (resize_window_check): Rename to window_resize_check.
4778 (resize_window_apply): Rename to window_resize_apply.
4779 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4780 (Fdelete_other_windows_internal, resize_frame_windows)
4781 (Fsplit_window_internal, Fdelete_window_internal)
4782 (grow_mini_window, shrink_mini_window)
4783 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4784
c7e73be5
JD
47852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4786
4787 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4788 (emacs_fixed_set_min_size): Remove.
4789 (emacs_fixed_new): Take frame as argument.
4790
4791 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4792 (_EmacsFixedPrivate): Remove minwidth/height.
4793 Add struct frame *f.
4794 (emacs_fixed_init): Initialize priv->f.
4795 (get_parent_class, emacs_fixed_set_min_size): Remove.
4796 (emacs_fixed_new): Set priv->f to argument.
4797 (emacs_fixed_get_preferred_width)
4798 (emacs_fixed_get_preferred_height): Use min_width/height from
4799 frames size_hint to set minimum and natural (Bug#8919).
4800 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4801 and use min_width/height from frames size_hint to set
4802 min_width/height (Bug#8919).
4803
4804 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4805 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4806 Fix indentation.
c7e73be5 4807
cf99dcf8
EZ
48082011-06-26 Eli Zaretskii <eliz@gnu.org>
4809
4810 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4811 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4812 called at ZV.
4813
029529ac
CY
48142011-06-26 Chong Yidong <cyd@stupidchicken.com>
4815
4816 * process.c (wait_reading_process_output): Bypass select if
4817 waiting for a cell while ignoring keyboard input, and input is
4818 pending. Suggested by Jan Djärv (Bug#8869).
4819
7a7ef429
PE
48202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4821
4822 Use gnulib's dup2 module instead of rolling our own.
4823 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4824
11fdef7d 48252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4826
4827 * dispnew.c (scrolling_window): Before scrolling, turn off a
4828 mouse-highlight in the window being scrolled.
4829
cd3520a4
JB
48302011-06-24 Juanma Barranquero <lekktu@gmail.com>
4831
4832 Move DEFSYM to lisp.h and use everywhere.
4833
4834 * character.h (DEFSYM): Move declaration...
4835 * lisp.h (DEFSYM): ...here.
4836
4837 * gnutls.c:
4838 * minibuf.c:
4839 * w32menu.c:
4840 * w32proc.c:
4841 * w32select.c: Don't include character.h.
4842
4843 * alloc.c (syms_of_alloc):
4844 * buffer.c (syms_of_buffer):
4845 * bytecode.c (syms_of_bytecode):
4846 * callint.c (syms_of_callint):
4847 * casefiddle.c (syms_of_casefiddle):
4848 * casetab.c (init_casetab_once):
4849 * category.c (init_category_once, syms_of_category):
4850 * ccl.c (syms_of_ccl):
4851 * cmds.c (syms_of_cmds):
4852 * composite.c (syms_of_composite):
4853 * dbusbind.c (syms_of_dbusbind):
4854 * dired.c (syms_of_dired):
4855 * dispnew.c (syms_of_display):
4856 * doc.c (syms_of_doc):
4857 * editfns.c (syms_of_editfns):
4858 * emacs.c (syms_of_emacs):
4859 * eval.c (syms_of_eval):
4860 * fileio.c (syms_of_fileio):
4861 * fns.c (syms_of_fns):
4862 * frame.c (syms_of_frame):
4863 * fringe.c (syms_of_fringe):
4864 * insdel.c (syms_of_insdel):
4865 * keymap.c (syms_of_keymap):
4866 * lread.c (init_obarray, syms_of_lread):
4867 * macros.c (syms_of_macros):
4868 * msdos.c (syms_of_msdos):
4869 * print.c (syms_of_print):
4870 * process.c (syms_of_process):
4871 * search.c (syms_of_search):
4872 * sound.c (syms_of_sound):
4873 * syntax.c (init_syntax_once, syms_of_syntax):
4874 * terminal.c (syms_of_terminal):
4875 * textprop.c (syms_of_textprop):
4876 * undo.c (syms_of_undo):
4877 * w32.c (globals_of_w32):
4878 * window.c (syms_of_window):
4879 * xdisp.c (syms_of_xdisp):
4880 * xfaces.c (syms_of_xfaces):
4881 * xfns.c (syms_of_xfns):
4882 * xmenu.c (syms_of_xmenu):
4883 * xsettings.c (syms_of_xsettings):
4884 * xterm.c (syms_of_xterm): Use DEFSYM.
4885
4228cf16
TZ
48862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4887
cd3520a4 4888 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4889
7fcccf1e
PE
48902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4891
7efb4e0e
PE
4892 Integer and buffer overflow fixes (Bug#8873).
4893
ff5844ad
PE
4894 * print.c (printchar, strout): Check for string overflow.
4895 (PRINTPREPARE, printchar, strout):
4896 Don't set size unless allocation succeeds.
4897
90532f02
PE
4898 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4899 for sizes. Check for string overflow more accurately.
4900 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4901
6d84508d
PE
4902 * macros.c: Integer and buffer overflow fixes.
4903 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4904 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4905 Use ptrdiff_t, not int, for sizes.
4906 Don't increment bufsize until after realloc succeeds.
4907 Check for size-calculation overflow.
4908 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4909
437b2cb4
PE
4910 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4911
8b9ac8b4
PE
4912 * lread.c: Integer overflow fixes.
4913 (read_integer): Radix is now EMACS_INT, not int,
4914 to improve quality of diagnostics for out-of-range radices.
4915 Calculate buffer size correctly for out-of-range radices.
4916 (read1): Check for integer overflow in radices, and in
4917 read-circle numbers.
82cb60d3
PE
4918 (read_escape): Avoid int overflow.
4919 (Fload, openp, read_buffer_size, read1)
4920 (substitute_object_recurse, read_vector, read_list, map_obarray):
4921 Use ptrdiff_t, not int, for sizes.
4922 (read1): Use EMACS_INT, not int, for sizes.
20270765 4923 Check for size overflow.
8b9ac8b4 4924
7fcccf1e
PE
4925 * image.c (cache_image): Check for size arithmetic overflow.
4926
bfbbd7e7
PE
4927 * lread.c: Integer overflow issues.
4928 (saved_doc_string_size, saved_doc_string_length)
4929 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4930 Now ptrdiff_t, not int.
4931 (read1): Don't assume doc string length fits in int. Check for
4932 out-of-range doc string lengths.
4933 (read_list): Don't assume file position fits in int.
39019e54 4934 (read_escape): Check for hex character overflow.
bfbbd7e7 4935
4e323265
LL
49362011-06-22 Leo Liu <sdl.web@gmail.com>
4937
4938 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4939 Move to minibuffer.el.
4940
85fece3e
PE
49412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4942
20b84ce9 4943 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4944 The following patches are for when GLYPH_DEBUG && !XASSERT.
4945 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4946 * dispnew.c (flush_stdout):
4947 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4948 Mark as externally visible.
4949 * dispnew.c (check_window_matrix_pointers): Now static.
4950 * dispnew.c (window_to_frame_vpos):
4951 * xfns.c (unwind_create_frame):
4952 * xterm.c (x_check_font): Remove unused local.
4953 * scroll.c (CHECK_BOUNDS):
4954 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4955 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4956 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4957 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4958 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4959 Now static.
4960 (debug_method_add): Use va_list and vsprintf rather than relying
4961 on undefined behavior with wrong number of arguments.
4962 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4963 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4964 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4965 since we're not interested in debugging glyphs with old libraries.
4966 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4967 GCC 4.6.0's static checking.
4968
0766b489
PE
49692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4970
31fd4b32
PE
4971 Integer overflow and signedness fixes (Bug#8873).
4972 A few related buffer overrun fixes, too.
4973
b79e8648
PE
4974 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4975
0766b489
PE
4976 * dispextern.h (struct face.stipple):
4977 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4978 (x_bitmap_mask, x_allocate_bitmap_record)
4979 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4980 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4981 (x_create_bitmap_from_xpm_data):
4982 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4983 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4984 (.bitmaps_last):
4985 * xfaces.c (load_pixmap):
4986 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4987 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4988 (.bitmaps_last, struct x_output.icon_bitmap):
4989 Use ptrdiff_t, not int, for bitmap indexes.
4990 (x_allocate_bitmap_record): Check for size overflow.
4991 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4992
b081724f
PE
4993 Use ptrdiff_t, not int, for overlay counts.
4994 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4995 * editfns.c (overlays_around, get_pos_property):
4996 * textprop.c (get_char_property_and_overlay):
4997 * xdisp.c (next_overlay_change, note_mouse_highlight):
4998 * xfaces.c (face_at_buffer_position):
21514da7
PE
4999 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5000 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5001 (Fnext_overlay_change, Fprevious_overlay_change)
5002 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5003 Use ptrdiff_t, not int, for sizes.
21514da7 5004 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5005
3de73e5e
PE
5006 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5007
2606c57b
PE
5008 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5009 (x_session_initialize): Do not assume string length fits in int.
5010
aaafe47a
PE
5011 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5012 This is unlikely, but can occur if DPI is outlandish.
5013
2674ddc8 5014 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5015 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5016
28154962
PE
5017 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5018 * xrdb.c (magic_file_p, search_magic_path):
5019 Omit last arg SUFFIX; it was always 0. All callers changed.
5020 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5021
7de51af5
PE
5022 * xfont.c (xfont_match): Avoid need for strlen.
5023
25ed6cc3
PE
5024 * xfns.c: Don't assume strlen fits in int.
5025 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5026
4eab31dd
PE
5027 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5028 not unsigned long, as we prefer signed integers. All callers changed.
5029 Detect integer overflow in repeat count.
5030 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5031 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5032
171e2a58
PE
5033 * termcap.c: Don't assume sizes fit in int and never overflow.
5034 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5035 (gobble_line): Check for size-calculation overflow.
5036
ad39faca 5037 * minibuf.c (Fread_buffer):
6e5bb2dc 5038 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5039 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5040 Don't assume string length fits in int.
5041
52c61c22 5042 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5043 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5044
b5b8c9e5
PE
5045 * font.c: Don't assume string length fits in int.
5046 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5047 Use ptrdiff_t, not int.
ccd6111c
PE
5048 (font_intern_prop): Don't assume string length fits in int.
5049 Don't assume integer property fits in fixnum.
5050 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5051
882f0d81 5052 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5053 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5054 Reformulate so as not to need the command string.
5055 Invoke gzip -cd rather than gunzip, as it's more portable.
5056 (lock_info_type, lock_file_1, lock_file):
5057 Don't assume pid_t and time_t fit in unsigned long.
5058 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5059 (current_lock_owner): Prefer signed type for sizes.
5060 Use memcpy, not strncpy, where memcpy is what is really wanted.
5061 Don't assume (via atoi) that time_t and pid_t fit in int.
5062 Check for time_t and/or pid_t out of range, e.g., via a network share.
5063 Don't alloca where an auto var works fine.
5064
93f4cf88
PE
5065 * fileio.c: Fix some integer overflow issues.
5066 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5067 Don't assume string length fits in int.
5068 (directory_file_name): Don't assume string length fits in long.
5069 (make_temp_name): Don't assume pid fits in int, or that its print
5070 length is less than 20.
5071
f3e92b69
PE
5072 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5073
1bfdaf10
PE
5074 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5075
35016e9a
PE
5076 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5077
3d1e65a1
PE
5078 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5079 We prefer signed integers, even for size calculations.
5080
0b963a93
PE
5081 * emacs.c: Don't assume string length fits in 'int'.
5082 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5083 (main): Don't invoke strlen when not needed.
5084
573f4b54
PE
5085 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5086 (XD_DEBUG_MESSAGE): Don't waste a byte.
5087
989f33ba
PE
5088 * callproc.c (getenv_internal_1, getenv_internal)
5089 (Fgetenv_internal):
965d34eb
PE
5090 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5091
e4d29b33
PE
5092 * lread.c (invalid_syntax): Omit length argument.
5093 All uses changed. This doesn't fix a bug, but it simplifies the
5094 code away from its former Hollerith-constant appearance, and it's
5095 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5096 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5097
eb49b136
PE
5098 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5099 This didn't break anything, but it didn't help either.
5100 It's confusing to put a bogus integer in a place where the actual
5101 value does not matter.
9f62aeb1 5102 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5103 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5104
15375a22
PE
5105 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5106 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5107 implementation.
b61cc01c
PE
5108 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5109 We prefer signed types, and the value cannot exceed the EMACS_INT
5110 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5111 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5112 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5113 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5114
53b2623d
PE
5115 * indent.c (sane_tab_width): New function.
5116 (current_column, scan_for_column, Findent_to, position_indentation)
5117 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5118 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5119
51cab52b 5120 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5121
f2ed8a70
PE
5122 * lisp.h (lint_assume): New macro.
5123 * composite.c (composition_gstring_put_cache):
5124 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5125
abe80cc6
PE
5126 * editfns.c, insdel.c:
5127 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5128
b02c740e
PE
5129 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5130
ebc96716
PE
5131 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5132
b4e50fa0 5133 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5134 Use much-faster test for byte-length change.
311d5d7c 5135 Don't assume string byte-length fits in 'int'.
a4cf38e4 5136 Check that character arg fits in 'int'.
85461888 5137 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5138
c0c1ee9f
PE
5139 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5140
a498d7f4
PE
5141 * fns.c (concat): Catch string overflow earlier.
5142 Do not rely on integer wraparound.
5143
51cab52b
PE
5144 * dispextern.h (struct it.overlay_strings_charpos)
5145 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5146 * xdisp.c (forward_to_next_line_start)
5147 (back_to_previous_visible_line_start)
5148 (reseat_at_next_visible_line_start, next_element_from_buffer):
5149 Don't arbitrarily truncate the value of 'selective' to int.
5150
76031fad
PE
5151 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5152
5eb55db9
PE
5153 * composite.c: Don't truncate sizes to 'int'.
5154 (composition_gstring_p, composition_reseat_it)
5155 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5156 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5157 not EMACS_UINT, for indexes.
5eb55db9 5158
0703a717
PE
5159 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5160
d6202519
PE
5161 * buffer.c: Include <verify.h>.
5162 (struct sortvec.priority, struct sortstr.priority):
8961a454 5163 Now EMACS_INT, not int.
c20998a7 5164 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5165 (struct sortstr.size, record_overlay_string)
5166 (struct sortstrlist.size, struct sortlist.used):
5167 Don't truncate size to int.
5168 (record_overlay_string): Check for size-calculation overflow.
d6202519 5169 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5170
d5a19415
JM
51712011-06-22 Jim Meyering <meyering@redhat.com>
5172
029529ac 5173 Don't leak an XBM-image-sized buffer
d5a19415
JM
5174 * image.c (xbm_load): Free the image buffer after using it.
5175
a9041e6c
PE
51762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5177
5178 Port to Sun C.
5179 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5180 that Sun C diagnosed.
5181 * fns.c (secure_hash): Fix pointer signedness issue.
5182 * intervals.c (static_offset_intervals): New function.
5183 (offset_intervals): Use it.
5184
7f3f739f
LL
51852011-06-21 Leo Liu <sdl.web@gmail.com>
5186
5187 * deps.mk (fns.o):
5188 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5189 sha512.h.
5190
5191 * fns.c (secure_hash): Rename from crypto_hash_function and change
5192 the first arg to accept symbols.
5b66d427 5193 (Fsecure_hash): New primitive.
7f3f739f
LL
5194 (syms_of_fns): New symbols.
5195
76147d94
DD
51962011-06-20 Deniz Dogan <deniz@dogan.se>
5197
5198 * process.c (Fset_process_buffer): Clarify return value in
5199 docstring.
5200
7d7d0045
CY
52012011-06-18 Chong Yidong <cyd@stupidchicken.com>
5202
5203 * dispnew.c (add_window_display_history): Use BVAR.
5204
5205 * xdisp.c (debug_method_add): Use BVAR.
5206 (check_window_end, dump_glyph_matrix, dump_glyph)
5207 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5208
5209 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5210 Likewise.
5211
5212 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5213 check till after the cache is created in init_frame_faces.
5214
ff2bc410
SM
52152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5216
5217 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5218
28177add
PE
52192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5220
dd3482fe
PE
5221 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5222 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5223 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5224
393d71f3 5225 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5226 * fileio.c (Finsert_file_contents):
5227 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5228 Remove the old (too-loose) buffer overflow checks.
5229 They weren't needed, since make_gap checks for buffer overflow.
5230 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5231 The old code merely checked for Emacs fixnum overflow, and relied
5232 on undefined (wraparound) behavior. The new code avoids undefined
5233 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5234
2e6813b0 5235 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5236 Tune. Don't use wider integers than needed. Don't use alloca.
5237 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5238
599a9e4f
PE
5239 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5240
99561444
PE
5241 * insdel.c, lisp.h (buffer_overflow): New function.
5242 (insert_from_buffer_1, replace_range, replace_range_2):
5243 * insdel.c (make_gap_larger):
5244 * editfns.c (Finsert_char):
5245 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5246
28177add
PE
5247 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5248
e69dafad
PE
52492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5250
4baa020d 5251 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5252
b1c46f02
PE
5253 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5254 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5255
e69dafad
PE
5256 * fileio.c: Don't assume EMACS_INT fits in off_t.
5257 (emacs_lseek): New static function.
5258 (Finsert_file_contents, Fwrite_region): Use it.
5259 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5260
566684ea
PE
5261 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5262
e6966cd6
PE
5263 * fns.c: Don't overflow int when computing a list length.
5264 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5265 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5266 truncation on 64-bit hosts. Check for QUIT every
5267 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5268 faster and is responsive enough.
5269 (Flength): Report an error instead of overflowing an integer.
5270 (Fsafe_length): Return a float if the value is not representable
5271 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5272 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5273 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5274
dd0b0efb
PE
5275 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5276 (header_size, word_size): New constants.
5277 (allocate_vectorlike): Don't check size overflow here.
5278 (allocate_vector): Check it here instead, since this is the only
5279 caller of allocate_vectorlike that could cause overflow.
5280 Check that the new vector's length is representable as a fixnum.
5281
86fe5cfe
PE
5282 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5283 The previous code was bogus. For example, next_almost_prime (32)
5284 returned 39, which is undesirable as it is a multiple of 3; and
5285 next_almost_prime (24) returned 25, which is a multiple of 5 so
5286 why was the code bothering to check for multiples of 7?
5287
80e88859
PE
5288 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5289
4a2f0ad6
PE
5290 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5291
f66c7cf8
PE
5292 Variadic C functions now count arguments with ptrdiff_t.
5293 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5294 Back then I didn't know that the Emacs coding style prefers signed int.
5295 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5296 were being counted with int, which may truncate counts on 64-bit
5297 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5298 * lisp.h (struct Lisp_Subr.function.aMANY)
5299 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5300 Arg counts are now ptrdiff_t, not size_t.
5301 All variadic functions and their callers changed accordingly.
5302 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5303 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5304 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5305 * callint.c (Fcall_interactively): Check arg count for overflow,
5306 to avoid potential buffer overrun. Use signed char, not 'int',
5307 for 'varies' array, so that we needn't bother to check its size
5308 calculation for overflow.
5309 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5310 * eval.c (apply_lambda):
5311 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5312 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5313 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5314
a1759b76
PE
5315 * callint.c (Fcall_interactively): Don't use index var as event count.
5316
d96be9fc
PE
5317 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5318 * mem-limits.h (SIZE): Remove; no longer used.
5319
a690a978 5320 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5321
578c21e6
PE
5322 Remove unnecessary casts.
5323 * xterm.c (x_term_init):
5324 * xfns.c (x_set_border_pixel):
5325 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5326 These aren't needed now that we assume ANSI C.
5327
96f53c6c
PE
5328 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5329 It's more likely to cause problems (due to unsigned overflow)
5330 than to cure them.
5331
83c77d31
PE
5332 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5333
ee2079f1
PE
5334 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5335
6da65536
PE
5336 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5337
7147c4a4
PE
5338 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5339
193e32d9
PE
5340 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5341
e5533da6
PE
5342 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5343
9910e595
PE
5344 GLYPH_CODE_FACE returns EMACS_INT, not int.
5345 * dispextern.h (merge_faces):
5346 * xfaces.c (merge_faces):
01103c44
PE
5347 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5348 Don't assume EMACS_INT fits in int.
9910e595 5349
2638320e
PE
5350 * character.h (CHAR_VALID_P): Remove unused parameter.
5351 * fontset.c, lisp.h, xdisp.c: All uses changed.
5352
045eb8d9
PE
5353 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5354
c1f134b5
PE
5355 * fns.c (concat): Minor tuning based on overflow analysis.
5356 This doesn't fix any bugs. Use int to hold character, instead
5357 of constantly refetching from Emacs object. Use XFASTINT, not
5358 XINT, for value known to be a character. Don't bother comparing
5359 a single byte to 0400, as it's always less.
5360
395fcb93 5361 * floatfns.c (Fexpt):
327eeec8
PE
5362 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5363
abbd3d23
PE
5364 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5365 for characters.
5366
684a03ef
PE
5367 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5368
0fed43f3
PE
5369 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5370 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5371 incorrectly succeed when S was a string, because 4294967386 was
5372 truncated before it was used.
5373
8fd02eb7
PE
5374 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5375 Otherwise, an out-of-range integer could cause undefined behavior
5376 on a 64-bit host.
5377
f8c86b69
PE
5378 * composite.c: Use int, not EMACS_INT, for characters.
5379 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5380 EMACS_INT, for values that are known to be in character range.
5381 This doesn't fix any bugs but is the usual style inside Emacs and
5382 may generate better code on 32-bit machines.
5383
34206dd2
PE
5384 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5385 This is for reasons similar to the recent CHAR_STRING fix.
5386 * charset.c (Fencode_char): Check that character arg is actually
5387 a character. Pass an int to ENCODE_CHAR.
5388 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5389 wider than 'int', as a compile-time check to prevent future regressions
5390 in this area.
5391
c5958d4c 5392 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5393
5394 Make sure a 64-bit char is never passed to CHAR_STRING.
5395 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5396 by silently ignoring the top 32 bits, allowing some values
5397 that were far too large to be valid characters.
5398 * character.h: Include <verify.h>.
5399 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5400 arguments are no wider than unsigned, as a compile-time check
5401 to prevent future regressions in this area.
5402 * data.c (Faset):
01103c44 5403 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5404 (Fsubst_char_in_region):
5405 * fns.c (concat):
5406 * xdisp.c (decode_mode_spec_coding):
5407 Adjust to CHAR_STRING's new requirement.
5408 * editfns.c (Finsert_char, Fsubst_char_in_region):
5409 * fns.c (concat): Check that character args are actually
5410 characters. Without this test, these functions did the wrong
5411 thing with wildly out-of-range values on 64-bit hosts.
5412
d37ca623
PE
5413 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5414 These casts should not be needed on 32-bit hosts, either.
5415 * keyboard.c (read_char):
5416 * lread.c (Fload): Remove casts to unsigned.
5417
ea204efb
PE
5418 * lisp.h (UNSIGNED_CMP): New macro.
5419 This fixes comparison bugs on 64-bit hosts.
5420 (ASCII_CHAR_P): Use it.
5421 * casefiddle.c (casify_object):
01103c44 5422 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5423 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5424 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5425 * dispextern.h (FACE_FROM_ID):
5426 * keyboard.c (read_char): Use UNSIGNED_CMP.
5427
41cb286c
PE
5428 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5429 not to EMACS_INT, to avoid GCC warning.
5430
4a1b9832
PE
5431 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5432
55daad71
PE
5433 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5434 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5435 isn't needed on 32-bit machines.
8f95c75c 5436
01103c44
PE
5437 * buffer.c (Fgenerate_new_buffer_name):
5438 Use EMACS_INT for count, not int.
0ceccced 5439 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5440
5441 * data.c (Qcompiled_function): Now static.
5442
c6f072e7
PE
5443 * window.c (window_body_lines): Now static.
5444
20ce5912
PE
5445 * image.c (gif_load): Rename local to avoid shadowing.
5446
9c4c5f81
PE
5447 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5448 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5449 * alloc.c (make_save_value): Integer argument is now of type
5450 ptrdiff_t, not int.
5451 (mark_object): Use ptrdiff_t, not int.
5452 * lisp.h (pD): New macro.
5453 * print.c (print_object): Use it.
5454
c0c5c8ae
PE
5455 * alloc.c: Use EMACS_INT, not int, to count objects.
5456 (total_conses, total_markers, total_symbols, total_vector_size)
5457 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5458 (total_free_floats, total_floats, total_free_intervals)
5459 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5460 Now EMACS_INT, not int. All uses changed.
5461 (Fgarbage_collect): Compute overall total using a double, so that
5462 integer overflow is less likely to be a problem. Check for overflow
5463 when converting back to an integer.
5a25e253
PE
5464 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5465 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5466 These were 'int' variables that could overflow on 64-bit hosts;
5467 they were never used, so remove them instead of repairing them.
211a0b2a 5468 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5469 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5470 Previously, this ceilinged at INT_MAX, but that doesn't work on
5471 64-bit machines.
e46bb31a 5472 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5473
c78baabf 5474 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5475 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5476 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5477 when a (possibly-narrower) signed value would do just as well.
5478 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5479
c9d624c6
PE
5480 * alloc.c: Catch some string size overflows that we were missing.
5481 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5482 for convenience in STRING_BYTES_MAX.
5483 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5484 The definition here is exact; the one in lisp.h was approximate.
5485 (allocate_string_data): Check for string overflow. This catches
5486 some instances we weren't catching before. Also, it catches
5487 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5488 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5489 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5490
c9d624c6
PE
5491 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5492 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5493 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5494
353032ce
PE
5495 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5496
2bccce07
PE
5497 * alloc.c (Fmake_string): Check for out-of-range init.
5498
0ac30604
SM
54992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5500
5501 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5502
c195f2de
JD
55032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5504
5505 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5506 xg_get_default_scrollbar_width.
5507
5508 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5509 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5510 (style_changed_cb): Call update_theme_scrollbar_width and call
5511 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5512 all frames (Bug#8505).
5513 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5514 Call gtk_window_set_resizable if HAVE_GTK3.
5515 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5516 and height if HAVE_GTK3 (Bug#8505).
5517 (scroll_bar_width_for_theme): New variable.
5518 (update_theme_scrollbar_width): New function.
5519 (xg_get_default_scrollbar_width): Move code to
5520 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5521 (xg_initialize): Call update_theme_scrollbar_width.
5522
5523 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5524
5525 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5526
e10ac9f1
MR
55272011-06-12 Martin Rudalics <rudalics@gmx.at>
5528
5529 * frame.c (make_frame): Call other_buffer_safely instead of
5530 other_buffer.
5531
5532 * window.c (temp_output_buffer_show): Call display_buffer with
5533 second argument Vtemp_buffer_show_specifiers and reset latter
5534 immediately after the call.
5535 (Vtemp_buffer_show_specifiers): New variable.
5536 (auto_window_vscroll_p, next_screen_context_lines)
5537 (Vscroll_preserve_screen_position): Remove leading asterisks from
5538 doc-strings.
5539
2d3c217e 55402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5541
7b7f97e8 5542 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5543 * buffer.c (Qclone_number): Remove for now, as it's unused.
5544 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5545 (record_buffer): Remove unused local.
5546 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5547 (set_frame_buffer_list): Remove; unused.
5548 * frame.h (other_visible_frames): Remove decl.
5549 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5550 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5551 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5552 if HAVE_GPM.
5553 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5554 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5555 Define only if HAVE_GPM.
5556 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5557 (update_hints_inhibit): Remove; never set. All uses removed.
5558 * widgetprv.h (emacsFrameClassRec): Remove decl.
5559 * window.c (delete_deletable_window): Now returns void, since it
5560 wasn't returning anything.
5561 (compare_window_configurations): Remove unused locals.
5562 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5563 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5564 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5565 the same widths as pointers. This follows up on the 2011-05-06 patch.
5566 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5567 * xterm.h: Likewise.
5568 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5569
1384b89e
JB
55702011-06-12 Juanma Barranquero <lekktu@gmail.com>
5571
5572 * makefile.w32-in: Update dependencies.
5573 (LISP_H): Add lib/intprops.h.
5574
1100a63c
CY
55752011-06-11 Chong Yidong <cyd@stupidchicken.com>
5576
5577 * image.c (gif_load): Add animation frame delay to the metadata.
5578 (syms_of_image): Use DEFSYM. New symbol `delay'.
5579
6198ccd0
MR
55802011-06-11 Martin Rudalics <rudalics@gmx.at>
5581
5582 * window.c (delete_deletable_window): Re-add.
5583 (Fset_window_configuration): Rewrite to handle dead buffers and
5584 consequently deletable windows.
5585 (window_tree, Fwindow_tree): Remove. Supply functionality in
5586 window.el.
5587 (compare_window_configurations): Simplify code.
5588
b6e3633c
AS
55892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5590
1ab0dee5
AS
5591 * image.c (imagemagick_load_image): Fix type mismatch.
5592 (Fimagemagick_types): Likewise.
5593
b6e3633c
AS
5594 * window.h (replace_buffer_in_windows): Declare.
5595
9397e56f
MR
55962011-06-11 Martin Rudalics <rudalics@gmx.at>
5597
5598 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5599 Qclone_number. Remove external declaration of Qdelete_window.
5600 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5601 code.
640c8776
SM
5602 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5603 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5604 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5605 buffer list implementation.
5606 (other_buffer_safely): New function.
5607 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5608 calls to replace_buffer_in_windows and
5609 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5610 if allowed.
5611 (record_buffer): Inhibit quitting and rewrite using quittable
5612 functions. Run Qbuffer_list_update_hook if allowed.
5613 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5614 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5615 Move switch-to-buffer to window.el.
9397e56f
MR
5616 (bury-buffer): Move to window.el.
5617 (Vbuffer_list_update_hook): New variable.
5618
5619 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5620 section.
5621
5622 * window.h (resize_frame_windows): Move up in code.
5623 (Fwindow_frame): Remove EXFUN.
5624 (replace_buffer_in_all_windows): Remove prototype.
5625 (replace_buffer_in_windows_safely): Add prototype.
5626
5627 * window.c: Declare Qdelete_window static again. Move down
5628 declaration of select_count.
5629 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5630 (Fother_window): Move to window.el.
5631 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5632 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5633 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5634 window.el.
5635 (replace_buffer_in_windows): Implement by calling
5636 Qreplace_buffer_in_windows.
5637 (replace_buffer_in_all_windows): Remove with some functionality
5638 moved into replace_buffer_in_windows_safely.
5639 (replace_buffer_in_windows_safely): New function.
5640 (select_window_norecord, select_frame_norecord): Move in front
5641 of run_window_configuration_change_hook. Remove now obsolete
5642 declarations.
640c8776
SM
5643 (Fset_window_buffer): Rewrite doc-string.
5644 Call Qrecord_window_buffer.
9397e56f
MR
5645 (keys_of_window): Move binding for other-window to window.el.
5646
b50691aa
CY
56472011-06-11 Chong Yidong <cyd@stupidchicken.com>
5648
5649 * dispextern.h (struct image): Replace data member, whose int_val
5650 and ptr_val fields were not used by anything, with a single
5651 lisp_val object.
5652
5653 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5654 (gif_clear_image, gif_load, imagemagick_load_image)
5655 (gs_clear_image, gs_load): Callers changed.
5656
3f754b86
PE
56572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5658
cca69397
PE
5659 * buffer.h: Include <time.h>, for time_t.
5660 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5661
109e28d0
PE
5662 Fix minor problems found by static checking.
5663
60737f02
PE
5664 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5665
4b66faf3
PE
5666 Make identifiers static if they are not used in other modules.
5667 * data.c (Qcompiled_function, Qframe, Qvector):
5668 * image.c (QimageMagick, Qsvg):
5669 * minibuf.c (Qmetadata):
5670 * window.c (resize_window_check, resize_root_window): Now static.
5671 * window.h (resize_window_check, resize_root_window): Remove decls.
5672
109e28d0
PE
5673 * window.c (window_deletion_count, delete_deletable_window):
5674 Remove; unused.
46a4ce9e
PE
5675 (window_body_lines): Now static.
5676 (Fdelete_other_windows_internal): Mark vars as initialized.
5677 Make sure 'resize_failed' is initialized.
5678 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5679 (resize_window_apply): Remove unused local.
5680 * window.h (delete_deletable_window): Remove decl.
5681
109e28d0 5682 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5683 (imagemagick_load_image): Fix pointer signedness problem by changing
5684 last arg from unsigned char * to char *. All uses changed.
5685 Also, fix a local for similar reasons.
5686 Remove unused locals. Remove locals to avoid shadowing.
5687 (fn_rsvg_handle_free): Remove; unused.
5688 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5689 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5690
3f754b86
PE
5691 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5692
2547adb1
CY
56932011-06-10 Chong Yidong <cyd@stupidchicken.com>
5694
5695 * image.c (gif_load): Fix omitted cast error introduced by
5696 2011-06-06 change.
5697
2c8e37d4
MR
56982011-06-10 Martin Rudalics <rudalics@gmx.at>
5699
5700 * window.h (resize_proportionally, orig_total_lines)
5701 (orig_top_line): Remove from window structure.
5702 (set_window_height, set_window_width, change_window_heights)
5703 (Fdelete_window): Remove prototypes.
5704 (resize_frame_windows): Remove duplicate declaration.
5705
440a42e3
EZ
57062011-06-10 Eli Zaretskii <eliz@gnu.org>
5707
5708 * window.h (resize_frame_windows, resize_window_check)
5709 (delete_deletable_window, resize_root_window)
5710 (resize_frame_windows): Declare prototypes.
5711
5712 * window.c (resize_window_apply): Make definition be "static" to
5713 match the prototype.
5714
562dd5e9
MR
57152011-06-10 Martin Rudalics <rudalics@gmx.at>
5716
5717 * window.c: Remove declarations of Qwindow_size_fixed,
5718 window_min_size_1, window_min_size_2, window_min_size,
5719 size_window, window_fixed_size_p, enlarge_window, delete_window.
5720 Remove static from declaration of Qdelete_window, it's
5721 temporarily needed by Fbury_buffer.
5722 (replace_window): Don't assign orig_top_line and
5723 orig_total_lines.
5724 (Fdelete_window, delete_window): Remove. Window deletion is
5725 handled by window.el.
640c8776
SM
5726 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5727 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5728 (Fdelete_other_windows): Remove. Deleting other windows is
5729 handled by window.el.
5730 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5731 handled in window.el.
5732 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5733 Window minimum sizes are handled in window.el.
5734 (shrink_windows, size_window, set_window_height)
5735 (set_window_width, change_window_heights, window_height)
5736 (window_width, CURBEG, CURSIZE, enlarge_window)
5737 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5738 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5739 handled in window.el.
5740 (make_dummy_parent): Rename to make_parent_window and give it a
5741 second argument horflag.
5742 (make_window): Don't set resize_proportionally any more.
5743 (Fsplit_window): Remove. Windows are split in window.el.
5744 (save_restore_action, save_restore_orig_size)
5745 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5746 Resize mini windows in window.el.
5747 (grow_mini_window, shrink_mini_window): Implement by calling
5748 Qresize_root_window_vertically, resize_window_check and
5749 resize_window_apply.
640c8776
SM
5750 (saved_window, Fset_window_configuration, save_window_save):
5751 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5752 resize_proportionally.
5753 (window_min_height, window_min_width): Move to window.el.
5754 (keys_of_window): Move bindings for delete-other-windows,
5755 split-window, delete-window and enlarge-window to window.el.
5756
5757 * buffer.c: Temporarily extern Qdelete_window.
5758 (Fbury_buffer): Temporarily call Qdelete_window instead of
5759 Fdelete_window (Fbury_buffer will move to window.el soon).
5760
5761 * frame.c (set_menu_bar_lines_1): Remove code handling
5762 orig_top_line and orig_total_lines.
5763
5764 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5765 set_window_height but set heights directly.
5766 (change_frame_size_1): Use resize_frame_windows.
5767
5768 * xdisp.c (init_xdisp): Don't use set_window_height but set
5769 heights directly.
5770
640c8776
SM
5771 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5772 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5773 run_window_configuration_change_hook.
5774
5775 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5776 instead of change_window_heights and run
5777 run_window_configuration_change_hook.
5778
1a13852e
MR
57792011-06-09 Martin Rudalics <rudalics@gmx.at>
5780
5781 * window.c (replace_window): Rename second argument REPLACEMENT to
5782 NEW. New third argument SETFLAG. Rewrite.
5783 (delete_window, make_dummy_parent): Call replace_window with
5784 third argument 1.
5785 (window_list_1): Move down in code.
5786 (run_window_configuration_change_hook): Move set_buffer part
5787 before select_frame_norecord part in order to unwind correctly.
5788 Rename count1 to count.
5789 (recombine_windows, delete_deletable_window, resize_root_window)
5790 (Fdelete_other_windows_internal)
5791 (Frun_window_configuration_change_hook, make_parent_window)
5792 (resize_window_check, resize_window_apply, Fresize_window_apply)
5793 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5794 (Fdelete_window_internal, Fresize_mini_window_internal):
5795 New functions.
1a13852e
MR
5796 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5797
f3d1777e
MR
57982011-06-08 Martin Rudalics <rudalics@gmx.at>
5799
496e208e
MR
5800 * window.h (window): Add some new members to window structure -
5801 normal_lines, normal_cols, new_total, new_normal, clone_number,
5802 splits, nest, prev_buffers, next_buffers.
5803 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5804 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5805
f3d1777e
MR
5806 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5807 Remove.
496e208e
MR
5808 (make_dummy_parent): Set new members of windows structure.
5809 (make_window): Move down in code. Handle new members of window
5810 structure.
5811 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5812 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5813 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5814 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5815 (Fset_window_next_buffers, Fset_window_clone_number):
5816 New functions.
496e208e
MR
5817 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5818 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5819 Doc-string fixes.
5820 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5821 Argument WINDOW can be now internal window too.
5822 (Fwindow_use_time): Move up in code.
5823 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5824 Rewrite doc-string.
5825 (Fset_window_configuration, saved_window)
5826 (Fcurrent_window_configuration, save_window_save): Handle new
5827 members of window structure.
b9e809c2
MR
5828 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5829 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5830 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5831 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5832 Qget_mru_window, Qresize_root_window,
5833 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5834 Qauto_buffer_name; staticpro them.
f3d1777e 5835
abde8f8c
MR
58362011-06-07 Martin Rudalics <rudalics@gmx.at>
5837
5838 * window.c (Fwindow_total_size, Fwindow_left_column)
5839 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5840 (Fwindow_list_1): New functions.
5841 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5842 (Fwindow_width, Fscroll_left, Fscroll_right):
5843 Use window_body_cols instead of window_box_text_cols.
5844 (delete_window, Fset_window_configuration):
5845 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5846 (delete_all_subwindows): Take a window as argument and not a
5847 structure. Rewrite.
190b47e6
MR
5848 (window_loop): Remove handling of GET_LRU_WINDOW and
5849 GET_LARGEST_WINDOW.
5850 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5851
5852 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5853 window_box_text_cols. delete_all_subwindows now takes a
5854 Lisp_Object as argument.
abde8f8c 5855
640c8776
SM
5856 * indent.c (compute_motion, Fcompute_motion):
5857 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5858
fa8a67e6
MR
5859 * frame.c (delete_frame): Call delete_all_subwindows with root
5860 window as argument.
5861
a54e3482
DC
58622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5863
5864 * fns.c (Fputhash): Document return value.
5865
60002bf5
CY
58662011-06-06 Chong Yidong <cyd@stupidchicken.com>
5867
5868 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5869
0c671da6 58702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5871
b862a52a 5872 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5873
be44ca6c
PE
5874 Check for overflow when converting integer to cons and back.
5875 * charset.c (Fdefine_charset_internal, Fdecode_char):
5876 Use cons_to_unsigned to catch overflow.
5877 (Fencode_char): Use INTEGER_TO_CONS.
5878 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5879 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5880 * data.c (long_to_cons, cons_to_long): Remove.
5881 (cons_to_unsigned, cons_to_signed): New functions.
5882 These signal an error for invalid or out-of-range values.
5883 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5884 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5885 * font.c (Ffont_variation_glyphs):
5886 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5887 * lisp.h: Include <intprops.h>.
5888 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5889 (cons_to_signed, cons_to_unsigned): New decls.
5890 (long_to_cons, cons_to_long): Remove decls.
5891 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5892 (Fprimitive_undo): Use CONS_TO_INTEGER.
5893 * xfns.c (Fx_window_property): Likewise.
5894 * xselect.c: Include <limits.h>.
5895 (x_own_selection, selection_data_to_lisp_data):
5896 Use INTEGER_TO_CONS.
5897 (x_handle_selection_request, x_handle_selection_clear)
5898 (x_get_foreign_selection, Fx_disown_selection_internal)
5899 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5900 (lisp_data_to_selection_data): Use cons_to_unsigned.
5901 (x_fill_property_data): Use cons_to_signed.
5902 Report values out of range.
5903
d1f3d2af
PE
5904 Check for buffer and string overflow more precisely.
5905 * buffer.h (BUF_BYTES_MAX): New macro.
5906 * lisp.h (STRING_BYTES_MAX): New macro.
5907 * alloc.c (Fmake_string):
5908 * character.c (string_escape_byte8):
5909 * coding.c (coding_alloc_by_realloc):
5910 * doprnt.c (doprnt):
5911 * editfns.c (Fformat):
5912 * eval.c (verror):
5913 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5914 since they may not be the same number.
5915 * editfns.c (Finsert_char):
5916 * fileio.c (Finsert_file_contents):
5917 Likewise for BUF_BYTES_MAX.
5918
dd52fcea
PE
5919 * image.c: Use ptrdiff_t, not int, for sizes.
5920 (slurp_file): Switch from int to ptrdiff_t.
5921 All uses changed.
5922 (slurp_file): Check that file size fits in both size_t (for
5923 malloc) and ptrdiff_t (for sanity and safety).
5924
7f9bbdbb
PE
5925 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5926 if b->modtime has its maximal value.
5927
dfe18f82
PE
5928 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5929
84acfcf0
PE
5930 Don't assume time_t can fit into int.
5931 * buffer.h (struct buffer.modtime): Now time_t, not int.
5932 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5933 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5934
ccd9a01a
PE
5935 Minor fixes for signed vs unsigned integers.
5936 * character.h (MAYBE_UNIFY_CHAR):
5937 * charset.c (maybe_unify_char):
5938 * keyboard.c (read_char, reorder_modifiers):
5939 XINT -> XFASTINT, since the integer must be nonnegative.
5940 * ftfont.c (ftfont_spec_pattern):
5941 * keymap.c (access_keymap, silly_event_symbol_error):
5942 XUINT -> XFASTINT, since the integer must be nonnegative.
5943 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5944 since it makes no difference and we prefer signed.
5945 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5946 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5947 nonnegative.
5948
d6d100dd
SM
59492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5950
5951 * window.h (Fwindow_frame): Declare.
5952
2b6148e4
PE
59532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5954
5955 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5956 (SPARE_MEMORY): Always define.
5957 (LARGE_REQUEST): Remove.
5958 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5959
f230ecc9
MR
59602011-06-06 Martin Rudalics <rudalics@gmx.at>
5961
727e958e
MR
5962 * lisp.h: Move EXFUNS for Fframe_root_window,
5963 Fframe_first_window and Fset_frame_selected_window to window.h.
5964
5965 * window.h: Move EXFUNS for Fframe_root_window,
5966 Fframe_first_window and Fset_frame_selected_window here from
5967 lisp.h.
5968
5969 * frame.c (Fwindow_frame, Fframe_first_window)
5970 (Fframe_root_window, Fframe_selected_window)
5971 (Fset_frame_selected_window): Move to window.c.
5972 (Factive_minibuffer_window): Move to minibuf.c.
5973 (Fother_visible_frames_p): New function.
5974
5975 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5976
f230ecc9
MR
5977 * window.c (decode_window, decode_any_window): Move up in code.
5978 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5979 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5980 (Fwindow_buffer): Move up and rewrite doc-string.
5981 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5982 (Fwindow_prev): New functions.
727e958e
MR
5983 (Fwindow_frame): Move here from frame.c. Accept any window as
5984 argument.
5985 (Fframe_root_window, Fframe_first_window)
5986 (Fframe_selected_window): Move here from frame.c. Accept frame
5987 or arbitrary window as argument. Update doc-strings.
5988 (Fminibuffer_window): Move up in code.
5989 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5990 (Fset_frame_selected_window): Move here from frame.c.
5991 Marginal rewrite.
727e958e
MR
5992 (Fselected_window, select_window, Fselect_window): Move up in
5993 code. Minor doc-string fixes.
f230ecc9 5994
4d09bcf6
PE
59952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5996
5997 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5998 Do not assume that spare memory exists; that assumption is valid
5999 only if SYSTEM_MALLOC.
6000 (LARGE_REQUEST): New macro, so that the issue of large requests
6001 is separated from the issue of spare memory.
6002
810928a2
AS
60032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6004
172418ad
AS
6005 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6006 format. (Bug#8806)
6007
43f862f7
AS
6008 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6009
810928a2
AS
6010 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6011 before statements.
6012
a059fe24
JD
60132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6014
6015 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6016
6017 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6018
6019 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6020 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6021
989bf368
JB
60222011-06-05 Juanma Barranquero <lekktu@gmail.com>
6023
6024 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6025
4b80f674
CY
60262011-06-04 Chong Yidong <cyd@stupidchicken.com>
6027
6028 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6029 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6030 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6031 New error handlers.
4b80f674
CY
6032 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6033 Obey Vx_select_enable_clipboard_manager. Catch errors in
6034 x_clipboard_manager_save (Bug#8779).
6035 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6036 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6037
99a33b77 60382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6039
6040 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6041
99a33b77 60422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6043
6044 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6045 in the current matrix if keep_current_p is non-zero.
6046
8264569d
EZ
60472011-06-04 Eli Zaretskii <eliz@gnu.org>
6048
6049 * bidi.c (bidi_level_of_next_char): Fix last change.
6050
57f97249
EZ
60512011-06-03 Eli Zaretskii <eliz@gnu.org>
6052
fec2107c 6053 Support bidi reordering of text covered by display properties.
57f97249 6054
fec2107c
EZ
6055 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6056 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6057 (bidi_cache_search, bidi_cache_iterator_state)
6058 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6059 (bidi_level_of_next_char, bidi_move_to_visually_next):
6060 Support character positions inside a run of characters covered by a
fec2107c
EZ
6061 display string.
6062 (bidi_paragraph_init, bidi_resolve_explicit_1)
6063 (bidi_level_of_next_char): Call bidi_fetch_char and
6064 bidi_fetch_char_advance instead of FETCH_CHAR and
6065 FETCH_CHAR_ADVANCE.
6066 (bidi_init_it): Initialize new members.
6067 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6068 definitions.
6069 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6070 instead of using explicit *_CHAR codes.
d6d100dd
SM
6071 (bidi_resolve_explicit, bidi_resolve_weak):
6072 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6073 bidirectional text is supported only in multibyte buffers.
6074 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6075 it to initialize the frame_window_p member of struct bidi_it.
6076 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6077 (bidi_resolve_explicit, bidi_resolve_weak)
6078 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6079 bidi_it->nchars is non-positive.
6080 (bidi_level_of_next_char): Don't try to lookup the cache for the
6081 next/previous character if nothing is cached there yet, or if we
6082 were just reseat()'ed to a new position.
c40e2fb2 6083
0e14fe90
EZ
6084 * xdisp.c (set_cursor_from_row): Set start and stop points
6085 according to the row's direction when priming the loop that looks
6086 for the glyph on which to display cursor.
6087 (single_display_spec_intangible_p): Function deleted.
6088 (display_prop_intangible_p): Reimplement to call
6089 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6090 Accept 3 additional arguments needed by handle_display_spec.
6091 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6092 values: lists, `(when COND...)' forms, etc.
6093 (single_display_spec_string_p): Support property values that are
6094 lists with the argument STRING its top-level element.
6095 (display_prop_string_p): Fix the condition for processing a
6096 property that is a list to be consistent with handle_display_spec.
fec2107c 6097 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6098 last portion of handle_display_prop.
6099 (compute_display_string_pos): Accept additional argument
6100 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6101 value of a `display' property is a "replacing spec".
6102 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6103 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6104 the display property, but just return a value indicating whether
6105 the display property will replace the characters it covers.
6106 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6107 frame_window_p members of struct bidi_it.
d6d100dd
SM
6108 (compute_display_string_pos, compute_display_string_end):
6109 New functions.
fec2107c
EZ
6110 (push_it): Accept second argument POSITION, where pop_it should
6111 jump to continue iteration.
6112 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6113
fec2107c
EZ
6114 * keyboard.c (adjust_point_for_property): Adjust the call to
6115 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6116
6117 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6118 (bidi_init_it): Update prototypes.
6119 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6120 (compute_display_string_pos, compute_display_string_end):
6121 Declare prototypes.
fec2107c
EZ
6122 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6123 EMACS_INT.
fc6f18ce 6124
40087514 61252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6126
57f53182
PE
6127 Malloc failure behavior now depends on size of allocation.
6128 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6129 * lisp.h: Change signatures accordingly.
6130 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6131 All callers changed. (Bug#8762)
6132
6133 * gnutls.c: Use Emacs's memory allocators.
6134 Without this change, the gnutls library would invoke malloc etc.
6135 directly, which causes problems on non-SYNC_INPUT hosts, and which
6136 runs afoul of improving memory_full behavior. (Bug#8761)
6137 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6138 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6139 xfree instead of the default malloc, realloc, free.
6140 (Fgnutls_boot): No need to check for memory allocation failure,
6141 since xmalloc does that for us.
6142
ac32cd99 6143 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6144 * category.c (hash_get_category_set):
6145 * ccl.c (ccl_driver):
6146 * charset.c (Fdefine_charset_internal):
6147 * charset.h (struct charset.hash_index):
6148 * composite.c (get_composition_id, gstring_lookup_cache)
6149 (composition_gstring_put_cache):
6150 * composite.h (struct composition.hash_index):
6151 * dispextern.h (struct image.hash):
6152 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6153 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6154 (hashfn_equal, hashfn_user_defined, make_hash_table)
6155 (maybe_resize_hash_table, hash_lookup, hash_put)
6156 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6157 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6158 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6159 * image.c (make_image, search_image_cache, lookup_image)
6160 (xpm_put_color_table_h):
6161 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6162 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6163 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6164 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6165 * alloc.c (allocate_vectorlike):
6166 Check for overflow in vector size calculations.
6167 * ccl.c (ccl_driver):
6168 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6169 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6170 need to be updated by these changes.
40087514
PE
6171 * fns.c (make_hash_table, maybe_resize_hash_table):
6172 Check for integer overflow with large hash tables.
0de4bb68
PE
6173 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6174 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6175 (SXHASH_REDUCE): New macro.
6176 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6177 Use it instead of discarding useful hash info with large hash values.
6178 (sxhash_float): New function.
6179 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6180 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6181 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6182 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6183 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6184 Adjust signatures to match updated version of code.
6185 (consing_since_gc): Now EMACS_INT, since a single hash table can
6186 use more than INT_MAX bytes.
6187
698d32e2
DN
61882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6189
6190 Make it possible to build with GCC-4.6+ -O2 -flto.
6191
6192 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6193
fd6fa53f
SM
61942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6195
6196 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6197 Call minibuffer-inactive-mode.
6198
864db017
JB
61992011-05-31 Juanma Barranquero <lekktu@gmail.com>
6200
6201 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6202 Update dependencies.
6203
2ad0baf4
DN
62042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6205
6206 * data.c (init_data): Remove code for UTS, this system is not
6207 supported anymore.
6208
4fcc2638
DN
62092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6210
6211 Don't force ./temacs to start in terminal mode.
6212
6213 * frame.c (make_initial_frame): Initialize faces in all cases, not
6214 only when CANNOT_DUMP is defined.
6215 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6216
c56e0fd5
DN
62172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6218
6219 * dispnew.c (add_window_display_history): Use const for the string
6220 pointer. Remove declaration, not needed.
6221
333d54da 62222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6223
55d4c1b2 6224 Use 'inline', not 'INLINE'.
333d54da 6225 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6226 * alloc.c, fontset.c (INLINE): Remove.
6227 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6228 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6229 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6230 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6231 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6232
738db178
DN
62332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6234
6235 Make it possible to run ./temacs.
6236
6237 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6238 syms_of_callproc does the same thing. Remove test for
6239 "initialized", do it in the caller.
6240 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6241
620c53a6
SM
62422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6243
6244 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6245 (read_minibuf): Use get_minibuffer.
6246 (syms_of_minibuf): Use DEFSYM.
6247 (Qmetadata): New var.
6248 * data.c (Qbuffer): Don't make it static.
6249 (syms_of_data): Use DEFSYM.
6250
e003a292
PE
62512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6252
6253 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6254 (CCL_CODE_MIN): New macro.
6255
ed008a6d
PE
62562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6257
3687c2ef
PE
6258 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6259
ed008a6d
PE
6260 * eval.c (Qdebug): Now static.
6261 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6262 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6263 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6264
d66c4c7c
CY
62652011-05-29 Chong Yidong <cyd@stupidchicken.com>
6266
6267 * image.c: Various fixes to ImageMagick code comments.
6268 (Fimagemagick_types): Doc fix.
6269
5fbc2025
PE
62702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6271
0196f88a
PE
6272 Minor fixes prompted by GCC 4.6.0 warnings.
6273
6274 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6275
5fbc2025
PE
6276 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6277 (x_clipboard_manager_save_all): Move extern decl to ...
6278 * xterm.h: ... here, so that it can be checked for consistency.
6279
1dd3c2d9
CY
62802011-05-29 Chong Yidong <cyd@stupidchicken.com>
6281
6282 * xselect.c (x_clipboard_manager_save_frame)
6283 (x_clipboard_manager_save_all): New functions.
6284 (Fx_clipboard_manager_save): Lisp function deleted.
6285
6286 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6287 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6288
6289 * xterm.h: Update prototype.
6290
5ba6571d
WX
62912011-05-28 William Xu <william.xwl@gmail.com>
6292
6293 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6294 exiting (Bug#8239).
6295
3eaff834
JM
62962011-05-28 Jim Meyering <meyering@redhat.com>
6297
e1900994 6298 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6299 * fns.c (to_uchar): Define.
6300 (crypto_hash_function): Use it to convert some newly-signed
6301 variables to unsigned, to avoid sign-extension bugs. For example,
6302 without this change, (md5 "truc") would evaluate to
6303 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6304 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6305 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6306
0f6990a7
PE
63072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6308
6309 Integer overflow fixes.
c8a9ca5a 6310
08686060
PE
6311 * dbusbind.c: Serial number integer overflow fixes.
6312 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6313 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6314 to hold a serial number that is too large for a fixnum.
6315 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6316 Check for serial numbers out of range. Decode any serial number
59568bf0 6317 that was so large that it became a float. (Bug#8722)
08686060 6318
2d1fc3c7
PE
6319 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6320 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6321 Use XFASTINT rather than XUINT when numbers are nonnegative.
6322 (xd_append_arg, Fdbus_method_return_internal):
6323 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6324 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6325 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6326 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6327 (Bug#8722)
2d1fc3c7 6328
c8a9ca5a
PE
6329 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6330
519e1d69
PE
6331 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6332
6df6ae42 6333 ccl: Add integer overflow checks.
30569699
PE
6334 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6335 (IN_INT_RANGE): New macros.
6336 (ccl_driver): Use them to check for integer overflow when
6337 decoding a CCL program. Many of the new checks are whether XINT (x)
6338 fits in int; it doesn't always, on 64-bit hosts. The new version
6339 doesn't catch all possible integer overflows, but it's an
847044ea 6340 improvement. (Bug#8719)
30569699 6341
c11285dc
PE
6342 * alloc.c (make_event_array): Use XINT, not XUINT.
6343 There's no need for unsigned here.
6344
fdccd48e
PE
6345 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6346 This follows up to the 2011-05-06 change that substituted uintptr_t
6347 for EMACS_INT. This case wasn't caught back then.
6348
37910ab2
PE
6349 Rework Fformat to avoid integer overflow issues.
6350 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6351 now (part of C89). Include <verify.h>.
6352 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6353 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6354 (Fformat): Avoid the prepass trying to compute sizes; it was only
6355 approximate and thus did not catch overflow reliably. Instead, walk
6356 through the format just once, formatting and computing sizes as we go,
6357 checking for integer overflow at every step, and allocating a larger
6358 buffer as needed. Keep track separately whether the format is
6359 multibyte. Keep only the most-recently calculated precision, rather
6360 than them all. Record whether each argument has been converted to
6361 string. Use EMACS_INT, not int, for byte and char and arg counts.
6362 Support field widths and precisions larger than INT_MAX. Avoid
6363 sprintf's undefined behavior with conversion specifications such as %#d
6364 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6365 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6366 formatting out-of-range floating point numbers with int
9173deec 6367 formats. (Bug#8668)
37910ab2 6368
2e6578fb
PE
6369 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6370
0ae6bdee
PE
6371 * data.c: Avoid integer truncation in expressions involving floats.
6372 * data.c: Include <intprops.h>.
6373 (arith_driver): When there's an integer overflow in an expression
6374 involving floating point, convert the integers to floating point
6375 so that the resulting value does not suffer from catastrophic
6376 integer truncation. For example, on a 64-bit host (* 4
6377 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6378 Do not rely on undefined behavior after integer overflow.
6379
de883a70
PE
6380 merge count_size_as_multibyte, parse_str_to_multibyte
6381 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6382 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6383 Check for integer overflow.
6384 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6385 since it's now a duplicate of the other. This is more of
6386 a character than a buffer op, so better that it's in character.c.
6387 * fns.c, print.c: Adjust to above changes.
6388
2ff916cb
PE
63892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6390
6391 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6392
f1b54466
PE
63932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6394
fb1ac845
PE
6395 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6396 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6397 (x_clipboard_manager_save): Now static.
6398 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6399
f1b54466
PE
6400 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6401 (crypto_hash_function): Now static.
6402 Fix pointer signedness problems. Avoid unnecessary initializations.
6403
a9f737ee
CY
64042011-05-27 Chong Yidong <cyd@stupidchicken.com>
6405
6406 * termhooks.h (Vselection_alist): Make it terminal-local.
6407
6408 * terminal.c (create_terminal): Initialize it.
6409
6410 * xselect.c: Support for clipboard managers.
6411 (Vselection_alist): Move to termhooks.h as terminal-local var.
6412 (LOCAL_SELECTION): New macro.
6413 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6414 (symbol_to_x_atom): Remove gratuitous arg.
6415 (x_handle_selection_request, lisp_data_to_selection_data)
6416 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6417 (x_own_selection, x_get_local_selection, x_convert_selection):
6418 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6419 (some_frame_on_display): Delete unused function.
6420 (Fx_own_selection_internal, Fx_get_selection_internal)
6421 (Fx_disown_selection_internal, Fx_selection_owner_p)
6422 (Fx_selection_exists_p): New optional frame arg.
6423 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6424 (x_handle_selection_clear): Don't treat other terminals with the
6425 same keyboard specially. Use the terminal-local Vselection_alist.
6426 (x_clear_frame_selections): Use Frun_hook_with_args.
6427
6428 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6429
6430 * xterm.h: Add support for those atoms.
6431
e067f0c1
CY
64322011-05-26 Chong Yidong <cyd@stupidchicken.com>
6433
6434 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6435 (converted_selections, conversion_fail_tag): New global variables.
6436 (x_selection_request_lisp_error): Free the above.
6437 (x_get_local_selection): Remove unnecessary code.
6438 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6439 of converted selections stored in converted_selections.
6440 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6441 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6442 (x_convert_selection): New function.
6443 (x_handle_selection_event): Simplify.
6444 (x_get_foreign_selection): Don't ignore incoming requests while
6445 waiting for an answer; this will fail when we implement
6446 SAVE_TARGETS, and seems unnecessary anyway.
6447 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6448 (Vx_sent_selection_functions): Doc fix.
6449
0f4aebc0
LL
64502011-05-26 Leo Liu <sdl.web@gmail.com>
6451
6452 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6453
e61124cd
YM
64542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6455
6456 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6457
6458 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6459 for fringe update if it has periodic bitmap.
ac389d0c 6460 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6461 and fringe_bitmap_periodic_p.
6462
6463 * fringe.c (get_fringe_bitmap_data): New function.
6464 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6465 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6466 row. Mark glyph row for fringe update if periodicity changed.
6467
6468 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6469 for fringe update unless it has periodic bitmap.
6470
f16d9837
KH
64712011-05-25 Kenichi Handa <handa@m17n.org>
6472
6473 * xdisp.c (get_next_display_element): Set correct it->face_id for
6474 a static composition.
6475
e1b90ef6
LL
64762011-05-24 Leo Liu <sdl.web@gmail.com>
6477
6478 * deps.mk (fns.o):
6479 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6480
6481 * fns.c (crypto_hash_function, Fsha1): New function.
6482 (Fmd5): Use crypto_hash_function.
6483 (syms_of_fns): Add Ssha1.
6484
7400048f
PE
64852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6486
6487 * gnutls.c: Remove unused macros.
6488 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6489 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6490 Remove macros that are defined and never used.
6491 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6492
abb71cf4
CY
64932011-05-22 Chong Yidong <cyd@stupidchicken.com>
6494
6495 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6496 (Fx_get_selection_internal): Minor cleanup.
6497 (Fx_own_selection_internal): Rename arguments for consistency with
6498 select.el.
6499
6307db39
PE
65002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6501
6502 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6503
f3d4e0a4
CY
65042011-05-22 Chong Yidong <cyd@stupidchicken.com>
6505
6506 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6507
4d8ade89
YM
65082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6509
6510 * dispnew.c (scrolling_window): Don't exclude the case that the
6511 last enabled row in the desired matrix touches the bottom boundary.
6512
32078c8d
GM
65132011-05-21 Glenn Morris <rgm@gnu.org>
6514
6515 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6516 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6517 and add some more files.
32078c8d 6518
7285dc67
EZ
65192011-05-20 Eli Zaretskii <eliz@gnu.org>
6520
6521 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6522 report_file_error introduced by the change from 2011-05-07.
6523
89d1bd22
PE
65242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6525
6526 * systime.h (Time): Define only if emacs is defined.
6527 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6528 where the include path doesn't have X11/X.h by default. See
6529 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6530
cd394be1 65312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6532
6533 * composite.c (find_automatic_composition): Fix previous change.
6534
b9704ad9
GM
65352011-05-20 Glenn Morris <rgm@gnu.org>
6536
6537 * lisp.mk: New file, split from Makefile.in.
6538 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6539 (shortlisp): Remove.
6540 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6541
4a720484
GM
65422011-05-19 Glenn Morris <rgm@gnu.org>
6543
6544 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6545 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6546 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6547 (lisp): Set the order to that of loadup.el.
6548 (shortlisp): Make it a copy of $lisp.
6549 (SOME_MACHINE_LISP): Remove.
6550 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6551 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6552
a28d4396
KH
65532011-05-18 Kenichi Handa <handa@m17n.org>
6554
6555 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6556 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6557 (find_automatic_composition): Mostly rewrite for efficiency.
6558
a2b1fa8e
JB
65592011-05-18 Juanma Barranquero <lekktu@gmail.com>
6560
6561 * makefile.w32-in: Update dependencies.
6562
8e1f5610
CS
65632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6564
6565 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6566 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6567
7025ee00 65682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6569
cdfa6eab
PE
6570 Fix some integer overflow issues, such as string length overflow.
6571
06d6db33
PE
6572 * insdel.c (count_size_as_multibyte): Check for string overflow.
6573
2b4560a8
PE
6574 * character.c (lisp_string_width): Check for string overflow.
6575 Use EMACS_INT, not int, for string indexes and lengths; in
6576 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6577 the resulting string length overflows an EMACS_INT; instead,
6578 report a string overflow if no precision given. When checking for
6579 precision exhaustion, use a check that cannot possibly have
6580 integer overflow. (Bug#8675)
6581 * character.h (lisp_string_width): Adjust to new signature.
6582
cb93f9be
PE
6583 * alloc.c (string_overflow): New function.
6584 (Fmake_string): Use it. This doesn't change behavior, but saves
6585 a few bytes and will simplify future changes.
6586 * character.c (string_escape_byte8): Likewise.
6587 * lisp.h (string_overflow): New decl.
6588
1a1f3366
PE
6589 Fixups, following up to the user-interface timestamp change.
6590 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6591 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6592 * msdos.c (mouse_get_pos): Likewise.
6593 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6594 * w32gui.h (Time): Define by including "systime.h" rather than by
6595 declaring it ourselves. (Bug#8664)
6596
d4e3e4d3
PE
6597 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6598 * image.c (clear_image_cache): Likewise.
6599
f6a24d19
PE
6600 * term.c (term_mouse_position): Don't assume time_t wraparound.
6601
08dc5ae6
PE
6602 Be more systematic about user-interface timestamps.
6603 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6604 and sometimes 'EMACS_UINT', to represent these timestamps.
6605 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6606 This makes the code easier to follow, and makes it easier to catch
6607 integer overflow bugs such as Bug#8664.
6608 * frame.c (Fmouse_position, Fmouse_pixel_position):
6609 Use Time, not unsigned long, for user-interface timestamps.
6610 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6611 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6612 * keyboard.h (last_event_timestamp): Likewise.
6613 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6614 * menu.h (xmenu_show): Likewise.
6615 * term.c (term_mouse_position): Likewise.
6616 * termhooks.h (struct input_event.timestamp): Likewise.
6617 (struct terminal.mouse_position_hook): Likewise.
6618 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6619 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6620 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6621 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6622 what it was before.
6623 * menu.h, termhooks.h: Include "systime.h", for Time.
6624
8e55734a
PE
6625 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6626 Don't assume that the difference between two unsigned long values
6627 can fit into an integer. At this point, we know button_down_time
6628 <= event->timestamp, so the difference must be nonnegative, so
6629 there's no need to cast the result if double-click-time is
6630 nonnegative, as it should be; check that it's nonnegative, just in
6631 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6632 apart (about 25 days). (Bug#8664)
8e55734a 6633
841f1b75 6634 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6635 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6636
3e26f69c
PE
6637 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6638 that always fit in int. Use a sentinel instead of a counter, to
6639 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6640 * frame.h (struct frame): Use int for menu_bar_items_used
6641 instead of EMACS_INT, since it always fits in int.
3e26f69c 6642
5cc152c0
PE
6643 * menu.c (grow_menu_items): Check for int overflow.
6644
d89eb65e
PE
6645 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6646
5235bd3e
PE
6647 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6648 Before, the code was not consistent. These values cannot exceed
6649 2**31 - 1 so there's no need to make them unsigned.
6650 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6651 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6652 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6653 as modifiers.
6654 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6655
bc827e23
PE
6656 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6657 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6658 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6659 presumably because the widths might not match.
6660
78eb494e
PE
6661 * window.c (size_window): Avoid needless test at loop start.
6662
04f2d78b
CB
66632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6664
6665 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6666
d2fc7e3d 66672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6668
6669 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6670
d2fc7e3d 66712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6672
6673 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6674 `width' to `bar_area_x' and `bar_area_width', respectively.
6675 (x_scroll_run): Take account of fringe background extension.
6676
04f2d78b
CB
6677 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6678 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6679 `bar_area_width', respectively.
6680 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6681 background extension.
6682
79b70037
GM
66832011-05-10 Jim Meyering <meyering@redhat.com>
6684
6685 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6686
2f142cc5
JB
66872011-05-10 Juanma Barranquero <lekktu@gmail.com>
6688
6689 * image.c (Finit_image_library): Return t for built-in image types,
6690 like pbm and xbm. (Bug#8640)
6691
57679c86
AS
66922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6693
6694 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6695
888c9e86
EZ
66962011-05-07 Eli Zaretskii <eliz@gnu.org>
6697
b0512a1d
EZ
6698 * w32console.c (Fset_screen_color): Doc fix.
6699 (Fget_screen_color): New function.
6700 (syms_of_ntterm): Defsubr it.
6701
7285dc67
EZ
6702 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6703 unlink the temporary file if Fcall_process didn't create it in the
6704 first place.
6705 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6706 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6707 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6708 cue to call_process_cleanup not to close that handle.
6709
4d3fcc8e
BK
67102011-05-07 Ben Key <bkey76@gmail.com>
6711
6712 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6713 one of two shell specific rules, either bootstrap-temacs-CMD or
6714 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6715 to the previous implementation of the bootstrap-temacs rule.
6716 The bootstrap-temacs-CMD rule is similar to the previous
6717 implementation of the bootstrap-temacs rule except that it
6718 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6719 variable.
6720
6721 These changes, along with some changes to nt/configure.bat,
6722 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6723 earlier fix to add support for --cflags and --ldflags options
6724 that include quotes so that it works whether make uses cmd or
6725 sh as the shell.
6726
b4289b64
MA
67272011-05-06 Michael Albinus <michael.albinus@gmx.de>
6728
6729 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6730 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6731 is a constant.
6732 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6733 a string. Handle both cases.
6734 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6735 (Fdbus_register_method): Use Qinvalid_function.
6736
af4c0e28
JB
67372011-05-06 Juanma Barranquero <lekktu@gmail.com>
6738
6739 * makefile.w32-in: Update dependencies.
6740 (LISP_H): Add inttypes.h and stdin.h.
6741 (PROCESS_H): Add unistd.h.
6742
c51453d9
EZ
67432011-05-06 Eli Zaretskii <eliz@gnu.org>
6744
6745 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6746 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6747
8ff0ac3c 67482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6749
4c4b566b
PE
6750 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6751
aab2b9b5
PE
6752 * term.c (vfatal): Remove stray call to va_end.
6753 It's not needed and the C Standard doesn't allow it here anyway.
6754
c378da0b
PE
6755 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6756 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6757
288b08c7
PE
6758 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6759 bytes.
6760
e3601888
PE
6761 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6762
db6c0e74
PE
6763 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6764
dd5963ea
PE
6765 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6766
88c9450f
PE
6767 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6768
2f9442b8
PE
6769 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6770
c032b5f8
PE
6771 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6772 * charset.c (Fdefine_charset_internal): Don't initialize
6773 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6774 32-bit int (Bug#8600).
a108c10b
PE
6775
6776 * lread.c (read_integer): Be more consistent with string-to-number.
6777 Use string_to_number to do the actual conversion; this avoids
6778 rounding errors and fixes some other screwups. Without this fix,
6779 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6780 (digit_to_number): Move earlier, for benefit of read_integer.
6781 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6782 not a digit in any supported base. (Bug#8602)
a108c10b 6783
ad5f9eea
PE
6784 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6785
aec1708a
PE
6786 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6787 to match comment at start of function. This also removes a
6788 GCC warning about overflow in a 32+64-bit port.
6789
47be4ab5
PE
6790 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6791
371cac43
PE
6792 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6793 Reported by Stefan Monnier in
6794 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6795 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6796 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6797
d01a7826
PE
6798 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6799 (EMACS_UINTPTR): Likewise, with uintptr_t.
6800
7fd47d5c
PE
6801 * lisp.h: Prefer 64-bit EMACS_INT if available.
6802 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6803 on 32-bit hosts that have 64-bit int, so that they can access
6804 large files.
122b0c86
PE
6805 However, temporarily disable this change unless the temporary
6806 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6807
8727937b
PE
6808 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6809
8ac068ac
PE
6810 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6811 This removes an assumption that EMACS_INT and long are the same
6812 width as pointers. The assumption is true for Emacs porting targets
6813 now, but we want to make other targets possible.
6814 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6815 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6816 In the rest of the code, change types of integers that hold casted
6817 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6818 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6819 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6820 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6821 No need to cast type when ORing.
6822 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6823 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6824 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6825 assume EMACS_INT is the same width as char *.
6826 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6827 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6828 Remove no-longer-needed casts.
6829 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6830 (xg_tool_bar_help_callback, xg_make_tool_item):
6831 Use EMACS_INTPTR to hold an integer
6832 that will be cast to void *; this can avoid a GCC warning
6833 if EMACS_INT is not the same width as void *.
6834 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6835 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6836 (current_message_1, set_message_1):
6837 Use a local to convert to proper width without a cast.
6838 * xmenu.c (dialog_selection_callback): Likewise.
6839
ede49d71
PE
6840 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6841 Also, don't assume VALBITS / RAND_BITS is less than 5,
6842 and don't rely on undefined behavior when shifting a 1 left into
6843 the sign bit.
6844 * lisp.h (get_random): Change signature to match.
6845
2f30ecd0
PE
6846 * lread.c (hash_string): Use size_t, not int, for hash computation.
6847 Normally we prefer signed values; but hashing is special, because
6848 it's better to use unsigned division on hash table sizes so that
6849 the remainder is nonnegative. Also, size_t is the natural width
6850 for hashing into memory. The previous code used 'int', which doesn't
6851 retain enough info to hash well into very large tables.
6852 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6853
2a866e7b
PE
6854 * dbusbind.c: Don't possibly lose pointer info when converting.
6855 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6856 Use XPNTR rather than XHASH, so that the high-order bits of
6857 the pointer aren't lost when converting through void *.
6858
51639eac
PE
6859 * eval.c (Fautoload): Don't double-shift a pointer.
6860
92394119
PE
6861 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6862
dbdb9a7c
JB
68632011-05-06 Juanma Barranquero <lekktu@gmail.com>
6864
6865 * gnutls.c (DEF_GNUTLS_FN):
6866 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6867
db7a0b4f
AS
68682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6869
6870 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6871 marker. (Bug#8610)
6872
cd394be1 68732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6874
6875 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6876 New version that can reserve upto 2GB of heap space.
6877
f7ff1b0f 68782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6879
6880 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6881
639c109b
TZ
68822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6883
6884 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6885 `gnutls_certificate_set_x509_key_file'.
6886
d2127135
JB
68872011-05-05 Juanma Barranquero <lekktu@gmail.com>
6888
6889 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6890 Update dependencies.
6891
e968f4f3
JB
68922011-05-04 Juanma Barranquero <lekktu@gmail.com>
6893
6894 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6895 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6896 Remove unused parameter `fildes'.
6897 * process.c (read_process_output, send_process): Don't pass it.
6898
84d358f0
JB
68992011-05-04 Juanma Barranquero <lekktu@gmail.com>
6900
6901 Fix previous change: the library cache is defined in w32.c.
6902 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6903 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6904
0898ca10
JB
69052011-05-04 Juanma Barranquero <lekktu@gmail.com>
6906
6907 Implement dynamic loading of GnuTLS on Windows.
6908
6909 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6910 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6911 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6912 Declare.
6913
6914 * gnutls.c (Qgnutls_dll): Define.
6915 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6916 (gnutls_*): Declare function pointers.
6917 (init_gnutls_functions): New function to initialize function pointers.
6918 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6919 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6920 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6921 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6922 (emacs_gnutls_write, emacs_gnutls_read)
6923 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6924 (Fgnutls_available_p): New function.
6925 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6926 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6927 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6928
6929 * image.c: Include w32.h.
6930 (Vimage_type_cache): Delete.
6931 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6932 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6933 (w32_delayed_load): Move to w32.c.
6934
6935 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6936
6937 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6938 (w32_delayed_load): Move from image.c. When loading a library, record
6939 its filename in the :loaded-from property of the library id.
6940 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6941 Initialize and staticpro them.
6942 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6943
6944 * process.c: Include lisp.h before w32.h, not after.
6945 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6946 instead of gnutls_record_check_pending.
6947
6948 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6949
ff4de4aa
TZ
69502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6951
6952 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6953 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6954 as passed in.
6955
abe95abb
JD
69562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6957
6958 * xterm.c (x_set_frame_alpha): Do not set property on anything
6959 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6960
e16e55d4
JB
69612011-05-02 Juanma Barranquero <lekktu@gmail.com>
6962
6963 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6964
bafcf6a5
JB
69652011-05-02 Juanma Barranquero <lekktu@gmail.com>
6966
6967 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6968 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6969 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6970 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6971 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6972 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6973 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6974 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6975 (Qgnutls_bootprop_callbacks_verify): Make static.
6976
e7a6747f
AS
69772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6978
19ed11ba
AS
6979 * callproc.c: Indentation fixup.
6980
e7a6747f 6981 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6982 (wait_for_termination, interruptible_wait_for_termination):
6983 Move after wait_for_termination_1.
e7a6747f 6984
1ef14cb4
LMI
69852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6986
6987 * sysdep.c (interruptible_wait_for_termination): New function
6988 which is like wait_for_termination, but allows keyboard
6989 interruptions.
6990
6991 * callproc.c (Fcall_process): Add (:file "file") as an option for
6992 the STDOUT buffer.
6993 (Fcall_process_region): Ditto.
6994
330d880c
EZ
69952011-04-30 Eli Zaretskii <eliz@gnu.org>
6996
8db90b73
EZ
6997 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6998 rather than `XVECTOR (FOO)->size'.
6999
330d880c
EZ
7000 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7001 inttypes.h, as a gnulib replacement is used if it not available in
7002 system headers.
7003
15cbd324
EZ
70042011-04-21 Eli Zaretskii <eliz@gnu.org>
7005
7006 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7007 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7008 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7009
7010 * coding.c (coding_alloc_by_realloc): Error out if destination
7011 will grow beyond MOST_POSITIVE_FIXNUM.
7012 (decode_coding_emacs_mule): Abort if there isn't enough place in
7013 charbuf for the composition carryover bytes. Reserve an extra
7014 space for up to 2 characters produced in a loop.
7015 (decode_coding_iso_2022): Abort if there isn't enough place in
7016 charbuf for the composition carryover bytes.
7017
70182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7019
ae940cca
EZ
7020 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7021 aborting when %lld or %lll format is passed.
7022 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7023 %llo or %llx format is passed. (Bug#8545)
7024
03ab8921
EZ
7025 * window.c (window_scroll_line_based): Use a marker instead of
7026 simple variables to record original value of point. (Bug#7952)
7027
afda1437
EZ
7028 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7029 produced by %s or %c overflows available buffer space. (Bug#8545)
7030
f76dee0c
PE
70312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7032
7033 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7034 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7035
fdc5744d
JB
70362011-04-28 Juanma Barranquero <lekktu@gmail.com>
7037
7038 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7039
638f053a
JB
70402011-04-28 Juanma Barranquero <lekktu@gmail.com>
7041
7042 * keyboard.c (Qdelayed_warnings_hook): Define.
7043 (command_loop_1): Run `delayed-warnings-hook'
7044 if Vdelayed_warnings_list is non-nil.
7045 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7046 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7047
d178f871
EZ
70482011-04-28 Eli Zaretskii <eliz@gnu.org>
7049
7050 * doprnt.c (doprnt): Don't return value smaller than the buffer
7051 size if the message was truncated. (Bug#8545).
7052
b124fd93
JB
70532011-04-28 Juanma Barranquero <lekktu@gmail.com>
7054
7055 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7056 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7057
e810457d
PE
70582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7059
7060 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7061
ea51cceb
JB
70622011-04-27 Juanma Barranquero <lekktu@gmail.com>
7063
7064 * makefile.w32-in: Update dependencies.
7065
94dcfacf
EZ
70662011-04-27 Eli Zaretskii <eliz@gnu.org>
7067
7068 Improve `doprnt' and its usage. (Bug#8545)
7069 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7070 `format_end'. Remove support for %l as a conversion specifier.
7071 Don't use xrealloc. Improve diagnostics when the %l size modifier
7072 is used. Update the commentary.
7073
7074 * eval.c (verror): Simplify calculation of size_t.
7075
7076 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7077 messages.
7078
f61f41d7
PE
70792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7080
7081 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7082 change.
7083
96fb4434
PE
70842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7085
7086 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7087 This makes this file independent of the recent pseudovector change.
7088
671875da 70892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7090
69e9b5a3
PE
7091 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7092
b5f869a7 7093 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7094 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7095 Remove unused local.
c8926152 7096 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7097
841a1577 7098 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7099 GCC 4.6.0 optimizes based on type-based alias analysis.
7100 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7101 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7102 != &v->size, and therefore "v->size = 1; b->size = 2; return
7103 v->size;" must therefore return 1. This assumption is incorrect
7104 for Emacs, since it type-puns struct Lisp_Vector * with many other
7105 types. To fix this problem, this patch adds a new type struct
f904488f 7106 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7107 and pseudovectors, and helps optimizing compilers not get fooled
7108 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7109 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7110 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7111 the size member.
eab3844f
PE
7112 (XSETPVECTYPE): Rewrite in terms of new macro.
7113 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7114 This is a bit clearer, and further avoids the possibility of
7115 undesirable aliasing.
7116 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7117 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7118 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7119 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7120 (ASIZE): Now uses header.size rather than size.
7121 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7122 to avoid the hassle of writing XVECTOR (foo)->header.size.
7123 (struct vectorlike_header): New type.
eab3844f
PE
7124 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7125 object, to help avoid aliasing.
7126 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7127 (SUBRP): Likewise, since Lisp_Subr is a special case.
7128 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7129 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7130 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7131 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7132 changed to be "header.size" and "header.next".
7133 * buffer.h (struct buffer): Likewise.
7134 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7135 * frame.h (struct frame): Likewise.
7136 * process.h (struct Lisp_Process): Likewise.
7137 * termhooks.h (struct terminal): Likewise.
7138 * window.c (struct save_window_data, struct saved_window): Likewise.
7139 * window.h (struct window): Likewise.
7140 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7141 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7142 * buffer.c (init_buffer_once): Likewise.
7143 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7144 special case.
7145 * process.c (Fformat_network_address): Use local var for size,
7146 for brevity.
7147
0df1eac5
PE
7148 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7149
847ab9d1 7150 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7151 * data.c (atof): Remove decl; no longer used or needed.
7152 (digit_to_number): Move to lread.c.
7153 (Fstring_to_number): Use new string_to_number function, to be
7154 consistent with how the Lisp reader treats infinities and NaNs.
7155 Do not assume that floating-point numbers represent EMACS_INT
7156 without losing information; this is not true on most 64-bit hosts.
7157 Avoid double-rounding errors, by insisting on integers when
7158 parsing non-base-10 numbers, as the documentation specifies.
7159 * lisp.h (string_to_number): New decl, replacing ...
7160 (isfloat_string): Remove.
bc0a5c13 7161 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7162 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7163 appears to have been a coding error. Similarly, do not accept
7164 strings like +-1e0 as floating point numbers. Do not report
7165 overflow for integer overflows unless the base is not 10 which
7166 means we have no simple and reliable way to continue.
7167 Break out the floating-point parsing into a new
7168 function string_to_number, so that Fstring_to_number parses
7169 floating point numbers consistently with the Lisp reader.
04f2d78b 7170 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7171 (E_CHAR, EXP_INT): Remove, replacing with ...
7172 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7173 (string_to_number): New function, replacing isfloat_string.
7174 This function checks for valid syntax and produces the resulting
7175 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7176 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7177 so that overflow for non-base-10 numbers is reported only when
7178 there's no portable and simple way to convert to floating point.
452f4150 7179
67769ffc
PE
7180 * textprop.c (set_text_properties_1): Rewrite for clarity,
7181 and to avoid GCC warning about integer overflow.
7182
c20db43f
PE
7183 * intervals.h (struct interval): Use EMACS_INT for members
7184 where EMACS_UINT might cause problems. See
7185 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7186 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7187 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7188 All uses changed.
37aa2f85
PE
7189 (offset_intervals): Tell GCC not to worry about length overflow
7190 when negating a negative length.
c20db43f 7191
2538aa2f
PE
7192 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7193 (overrun_check_free): Likewise.
7194
f2d3008d
PE
7195 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7196 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7197 word size.
7198
ec8df744
PE
7199 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7200 (gnutls_make_error): Rename local to avoid shadowing.
7201 (gnutls_emacs_global_deinit): ifdef out; not used.
7202 (Fgnutls_boot): Use const for pointer to readonly storage.
7203 Comment out unused local. Fix pointer signedness problems.
7204
640ee02d
PE
7205 * lread.c (openp): Don't stuff size_t into an 'int'.
7206 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7207 about possible signed overflow.
7208
6048fb2a
PE
7209 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7210 (GDK_KEY_g): Don't define if already defined.
7211 (xg_prepare_tooltip): Avoid pointer signedness problem.
7212 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7213
fa3c87e1
PE
7214 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7215 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7216
2172544b
PE
7217 * xfns.c (Fx_window_property): Simplify a bit,
7218 to make a bit faster and to avoid GCC 4.6.0 warning.
7219 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7220
9b821a21
PE
7221 * fns.c (internal_equal): Don't assume size_t fits in int.
7222
3c616cfa
PE
7223 * alloc.c (compact_small_strings): Tighten assertion a little.
7224
c2982e87
PE
7225 Replace pEd with more-general pI, and fix some printf arg casts.
7226 * lisp.h (pI): New macro, generalizing old pEd macro to other
7227 conversion specifiers. For example, use "...%"pI"d..." rather
7228 than "...%"pEd"...".
7229 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7230 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7231 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7232 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7233 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7234 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7235 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7236 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7237 64-bit hosts.
7238 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7239 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7240 * print.c (safe_debug_print, print_object): Likewise.
7241 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7242 to int.
6f04d126
PE
7243 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7244 avoiding the 0 flag, which is not portable.
c2982e87
PE
7245 * process.c (Fmake_network_process): Use pI to avoid cast.
7246 * region-cache.c (pp_cache): Likewise.
7247 * xdisp.c (decode_mode_spec): Likewise.
7248 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7249 behavior on 64-bit hosts with printf arg.
6f04d126 7250 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7251 (x_stop_queuing_selection_requests): Likewise.
7252 (x_get_window_property): Don't truncate byte count to an 'int'
7253 when tracing.
0b432f21 7254
5e073ec7
PE
7255 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7256 here, since it parses constructs like leading '-' and spaces,
7257 which are not wanted; and it overflows with large numbers.
7258 Instead, simply match F[0-9]+, which is what is wanted anyway.
7259
36372bf9
PE
7260 * alloc.c: Remove unportable assumptions about struct layout.
7261 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7262 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7263 (allocate_vectorlike, make_pure_vector): Use the new macros,
7264 plus offsetof, to remove unportable assumptions about struct layout.
7265 These assumptions hold on all porting targets that I know of, but
7266 they are not guaranteed, they're easy to remove, and removing them
7267 makes further changes easier.
7268
0b432f21
PE
7269 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7270 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7271 (string_overrun_cookie): Now const. Use initializers that
7272 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7273 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7274 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7275 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7276 multiple of sizeof (EMACS_INT); it need not be, if
7277 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7278 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7279
895009e1
JB
72802011-04-26 Juanma Barranquero <lekktu@gmail.com>
7281
7282 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7283
6a7a1b0b
TZ
72842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7285
7286 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7287 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7288 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7289
841a1577 72902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7291
7292 * lisp.h (Qdebug): List symbol.
895009e1 7293 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7294 * keyboard.c (debug-on-event): New variable.
7295 (handle_user_signal): Break into debugger when debug-on-event
7296 matches the current signal symbol.
7297
f2d3ba6f
DN
72982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7299
7300 * alloc.c (check_sblock, check_string_bytes)
7301 (check_string_free_list): Convert to standard C.
7302
42ce4c63
TZ
73032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7304
7305 * w32.c (emacs_gnutls_push): Fix typo.
7306
825cd63c
EZ
73072011-04-25 Eli Zaretskii <eliz@gnu.org>
7308
fb11d64d
EZ
7309 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7310 "cast to pointer from integer of different size".
7311
825cd63c
EZ
7312 Improve doprnt and its use in verror. (Bug#8545)
7313 * doprnt.c (doprnt): Document the set of format control sequences
7314 supported by the function. Use SAFE_ALLOCA instead of always
7315 using `alloca'.
7316
7317 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7318 is one byte too soon. Don't use xrealloc; instead xfree and
7319 xmalloc anew.
7320
e061a11b
TZ
73212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7322
7323 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7324 callbacks stage.
7325
7326 * gnutls.c: Renamed global_initialized to
7327 gnutls_global_initialized. Added internals for the
7328 :verify-hostname-error, :verify-error, and :verify-flags
7329 parameters of `gnutls-boot' and documented those parameters in the
7330 docstring. Start callback support.
9173deec
JB
7331 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7332 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7333 on error. Return error code.
e061a11b
TZ
7334 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7335 (emacs_gnutls_read): Likewise.
7336 (Fgnutls_boot): Return handshake error code.
7337 (emacs_gnutls_handle_error): New function.
7338 (wsaerror_to_errno): Likewise.
7339
7340 * w32.h (emacs_gnutls_pull): Add prototype.
7341 (emacs_gnutls_push): Likewise.
7342
7343 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7344 (emacs_gnutls_push): Likewise.
7345
73462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7347
7348 * process.c (wait_reading_process_output): Check if GnuTLS
7349 buffered some data internally if no FDs are set for TLS
7350 connections.
7351
7352 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7353 (LIBS): Link to USER_LIBS.
7354 ($(BLD)/gnutls.$(0)): New target.
7355
fa6996bc
EZ
73562011-04-24 Eli Zaretskii <eliz@gnu.org>
7357
eb35682e
EZ
7358 * xdisp.c (handle_single_display_spec): Rename the
7359 display_replaced_before_p argument into display_replaced_p, to
7360 make it consistent with the commentary. Fix typos in the
7361 commentary.
7362
e2ad650c
EZ
7363 * textprop.c (syms_of_textprop): Remove dead code.
7364 (copy_text_properties): Delete obsolete commentary about an
7365 interface that was deleted long ago. Fix typos in the description
7366 of arguments.
7367
1b2de274
EZ
7368 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7369 to changes in oldXMenu/XMenu.h from 2011-04-16.
7370 <menu_help_message, prev_menu_help_message>: Constify.
7371 (IT_menu_make_room): menu->help_text is now `const char **';
7372 adjust.
7373
7374 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7375 to changes in oldXMenu/XMenu.h from 2011-04-16.
7376 (struct XMenu): Declare `help_text' `const char **'.
7377
7378 * xfaces.c <Qunspecified>: Make extern again.
7379
7380 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7381 required by POSIX.
1b2de274 7382
762b15be
EZ
7383 * doc.c (get_doc_string): Improve the format passed to `error'.
7384
7385 * doprnt.c (doprnt): Improve commentary.
7386
7387 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7388
7389 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7390 them with etags.
7391
f1052e5d
EZ
7392 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7393 changes in globals.h immediately force recompilation.
762b15be
EZ
7394 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7395 $(CURDIR)/s/ms-w32.h.
7396 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7397
fa6996bc
EZ
7398 * character.c (Fchar_direction): Function deleted.
7399 (syms_of_character): Don't defsubr it.
7400 <char-direction-table>: Deleted.
7401
e6c3da20
EZ
74022011-04-23 Eli Zaretskii <eliz@gnu.org>
7403
7404 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7405 * doprnt.c: Include limits.h.
7406 (SIZE_MAX): New macro.
04f2d78b
CB
7407 (doprnt): Return a size_t value. 2nd arg is now size_t.
7408 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7409 Improve overflow protection. Support `l' modifier for integer
7410 conversions. Support %l conversion. Don't assume an EMACS_INT
7411 argument for integer conversions and for %c.
7412
7413 * lisp.h (doprnt): Restore prototype.
7414
7415 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7416 $(SRC)/character.h.
7417
7418 * Makefile.in (base_obj): Add back doprnt.o.
7419
7420 * deps.mk (doprnt.o): Add back prerequisites.
7421 (callint.o): Depend on character.h.
7422
7423 * eval.c (internal_lisp_condition_case): Include the handler
7424 representation in the error message.
7425 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7426 when breaking from the loop.
7427
7428 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7429
7430 * callint.c (Fcall_interactively): When displaying error message
7431 about invalid control letter, pass the character's codepoint, not
7432 a pointer to its multibyte form. Improve display of the character
7433 in octal and display also its hex code.
7434
7435 * character.c (char_string): Use %x to display the (unsigned)
7436 codepoint of an invalid character, to avoid displaying a bogus
7437 negative value.
7438
7439 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7440 `error', not SYMBOL_NAME itself.
7441
7442 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7443 character arguments to `error'.
7444
7445 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7446 to `error' in error message about FINAL_CHAR argument. Make sure
7447 FINAL_CHAR is a character, and use %c when it is passed as
7448 argument to `error'.
7449
4ffd0d6b 74502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7451
7452 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7453
7454 * w32.c: Include <time.h>.
7455 (sys_localtime): New function.
7456
4ffd0d6b 74572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7458
7459 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7460
4ffd0d6b 7461 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7462
4ffd0d6b 74632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7464
4ffd0d6b
GM
7465 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7466 zombies (Bug#8467).
aac0c6e3 7467
04c56954
EZ
74682011-04-19 Eli Zaretskii <eliz@gnu.org>
7469
7470 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7471 gl_state.e_property when gl_state.object is Qt.
7472
7473 * insdel.c (make_gap_larger): Remove limitation of buffer size
7474 to <= INT_MAX.
7475
16a43933
CY
74762011-04-18 Chong Yidong <cyd@stupidchicken.com>
7477
7478 * xdisp.c (lookup_glyphless_char_display)
7479 (produce_glyphless_glyph): Handle cons cell entry in
7480 glyphless-char-display.
7481 (Vglyphless_char_display): Document it.
7482
7483 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7484 glyphless-char-display.
7485
4581706e
CY
74862011-04-17 Chong Yidong <cyd@stupidchicken.com>
7487
7488 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7489
7490 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7491
7492 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7493 definition for no-X builds.
7494
4887c6e2 74952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7496
fd35b6f9
PE
7497 Static checks with GCC 4.6.0 and non-default toolkits.
7498
5c1ccb01
PE
7499 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7500
006c5daa
PE
7501 * process.c (keyboard_bit_set): Define only if SIGIO.
7502 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7503 (send_process): Repair possible setjmp clobbering.
7504
efc736d3
PE
7505 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7506
4e2fe2e6
PE
7507 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7508
f97334a2
PE
7509 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7510
4e75f29d
PE
7511 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7512 Define only if needed.
7513
90efadd1
PE
7514 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7515 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7516 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7517
3c647824
PE
7518 * dispextern.h (struct redisplay_interface): Rename param
7519 to avoid shadowing.
e264f262 7520 * termhooks.h (struct terminal): Likewise.
761383f4 7521 * xterm.c (xembed_send_message): Likewise.
3c647824 7522
b58c5c4a
PE
7523 * insdel.c (make_gap_smaller): Define only if
7524 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7525
cad59032
PE
7526 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7527 it.
7528
c339dc2e
PE
7529 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7530 so that we aren't warned about unused symbols.
7531
91a3e27b
PE
7532 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7533
399c71d3 7534 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7535
8ffc96f5
PE
7536 * xfns.c (x_real_positions): Mark locals as initialized.
7537
eef9bc79
PE
7538 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7539
098db9dd
PE
7540 * xterm.c: Fix problems found by static analysis with other toolkits.
7541 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7542 (x_dispatch_event): Declare static if USE_GTK, and
7543 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7544 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7545 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7546 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7547 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7548
eb18f6cc
PE
7549 * xmenu.c (menu_help_callback): Pointer type fixes.
7550 Use const pointers when pointing at readonly data. Avoid pointer
7551 signedness clashes.
7552 (FALSE): Remove unused macro.
7553 (update_frame_menubar): Remove unused decl.
7554
1fe72bf8
PE
7555 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7556
60d9e1db
PE
7557 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7558 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7559 (single_menu_item): Rename local to avoid shadowing.
7560
39261c26
PE
7561 * keyboard.c (make_lispy_event): Remove unused local var.
7562
018c5e19
PE
7563 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7564 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7565
63d2b86e
PE
7566 * bitmaps: Change bitmaps from unsigned char back to the X11
7567 compatible char. Avoid the old compiler warnings about
7568 out-of-range initializers by using, for example, '\xab' rather
7569 than 0xab.
7570
aefd87e1
PE
7571 * xgselect.c (xgselect_initialize): Check vs interface
7572 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7573
bf501fb9
PE
7574 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7575
e9829fdf
PE
7576 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7577 to read-only memory.
7578
1086c095
PE
7579 * fns.c (vector): Remove; this old hack is no longer needed.
7580
2baccd04 7581 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7582 Remove unused var.
dde42981 7583 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7584
72391843 7585 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7586
436c16df 7587 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7588 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7589 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7590
92bb796d 7591 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7592 (x_term_init): Remove local to avoid shadowing.
92bb796d 7593
764430a3 7594 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7595
7596 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7597 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7598
d1dfb56c
EZ
75992011-04-16 Eli Zaretskii <eliz@gnu.org>
7600
c4354cb4
EZ
7601 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7602
d1dfb56c
EZ
7603 Fix regex.c, syntax.c and friends for buffers > 2GB.
7604 * syntax.h (struct gl_state_s): Declare character position members
7605 EMACS_INT.
7606
7607 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7608
04f2d78b
CB
7609 * textprop.c (verify_interval_modification, interval_of):
7610 Declare arguments EMACS_INT.
d1dfb56c
EZ
7611
7612 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7613 EMACS_INT.
7614
7615 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7616
7617 * indent.c (Fvertical_motion): Local variable it_start is now
7618 EMACS_INT.
7619
7620 * regex.c (re_match, re_match_2, re_match_2_internal)
7621 (bcmp_translate, regcomp, regexec, print_double_string)
7622 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7623 (re_compile_pattern, re_exec): Declare arguments and local
7624 variables `size_t' and `ssize_t' and return values `regoff_t', as
7625 appropriate.
7626 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7627 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7628 <compile_stack_type>: `size' and `avail' are now `size_t'.
7629
7630 * regex.h <regoff_t>: Use ssize_t, not int.
7631 (re_search, re_search_2, re_match, re_match_2): Arguments that
7632 specify buffer/string position and length are now ssize_t and
7633 size_t. Return type is regoff_t.
7634
613052cd
BK
76352011-04-16 Ben Key <bkey76@gmail.com>
7636
7637 * nsfont.m: Fixed bugs in ns_get_family and
7638 ns_descriptor_to_entity that were caused by using free to
7639 deallocate memory blocks that were allocated by xmalloc (via
7640 xstrdup). This caused Emacs to crash when compiled with
7641 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7642 --enable-checking=xmallocoverrun). xfree is now used to
7643 deallocate these memory blocks.
7644
4170f62f 76452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7646
71b41406
PE
7647 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7648
9587a89d
PE
7649 emacs_write: Accept and return EMACS_INT for sizes.
7650 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7651 et seq.
7652 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7653 Accept and return EMACS_INT.
7654 (emacs_gnutls_write): Return the number of bytes written on
7655 partial writes.
7656 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7657 (emacs_read, emacs_write): Remove check for negative size, as the
7658 Emacs source code has been audited now.
9587a89d
PE
7659 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7660 (emacs_read, emacs_write): Use it.
273a5f82
PE
7661 * process.c (send_process): Adjust to the new signatures of
7662 emacs_write and emacs_gnutls_write. Do not attempt to store
7663 a byte offset into an 'int'; it might overflow.
9587a89d 7664 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7665
3e047f51
PE
7666 * sound.c: Don't assume sizes fit in 'int'.
7667 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7668 Return EMACS_INT, not int.
3e047f51 7669 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7670 Accept EMACS_INT, not int.
7671 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7672 record read return values.
7673
cc39a9db
BK
76742011-04-15 Ben Key <bkey76@gmail.com>
7675
c9d0ec6d
JB
7676 * keyboard.c (Qundefined): Don't declare static since it is used
7677 in nsfns.m.
7678 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7679 static since they are used in nsfont.m.
cc39a9db 7680
6c60eb9f
SM
76812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7682
7683 * process.c (Qprocessp): Don't declare static.
7684 * lisp.h (Qprocessp): Declare again.
7685
7990b61a
JB
76862011-04-15 Juanma Barranquero <lekktu@gmail.com>
7687
7688 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7689
5d4cb038
PE
76902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7691
8bd7b830 7692 Improve C-level modularity by making more things 'static'.
cd64ea1d 7693
e3b27b31
PE
7694 Don't publish debugger-only interfaces to other modules.
7695 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7696 (verify_bytepos, count_markers): Move decls to the only modules
7697 that need them.
7698 * region-cache.h (pp_cache): Likewise.
7699 * window.h (check_all_windows): Likewise.
7700 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7701
5d4cb038
PE
7702 * sysdep.c (croak): Now static, if
7703 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7704 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7705
7706 * alloc.c (refill_memory_reserve): Now static if
7707 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7708 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7709
e87b6180
PE
7710 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7711 Define only if USE_LUCID.
7712
ac64929e
PE
7713 * xrdb.c (x_customization_string, x_rm_string): Now static.
7714
6f37259d
PE
7715 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7716 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7717
1683e3ab
PE
7718 * xdisp.c (draw_row_with_mouse_face): Now static.
7719 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7720
de9c2632
PE
7721 * window.h (check_all_windows): Mark externally visible.
7722
2b96acb7
PE
7723 * window.c (window_deletion_count): Now static.
7724
7725 * undo.c: Make symbols static if they're not exported.
7726 (last_undo_buffer, last_boundary_position, pending_boundary):
7727 Now static.
7728
50436f33
PE
7729 * textprop.c (interval_insert_behind_hooks): Now static.
7730 (interval_insert_in_front_hooks): Likewise.
7731
64520e5c
PE
7732 * term.c: Make symbols static if they're not exported.
7733 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7734 (max_frame_lines, tty_set_terminal_modes):
7735 (tty_reset_terminal_modes, tty_turn_off_highlight):
7736 (get_tty_terminal): Now static.
7737 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7738 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7739 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7740 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7741 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7742
1fa53021
PE
7743 * sysdep.c: Make symbols static if they're not exported.
7744 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7745 Now static.
7746 (sigprocmask_set, full_mask): Remove; unused.
7747 (wait_debugging): Mark as visible.
7748 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7749 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7750
d4b43b22
PE
7751 * syntax.c (syntax_temp): Define only if !__GNUC__.
7752
b7c513d0
PE
7753 * sound.c (current_sound_device, current_sound): Now static.
7754
989b29ad
PE
7755 * search.c (searchbufs, searchbuf_head): Now static.
7756
13a55a78
PE
7757 * scroll.c (scroll_cost): Remove; unused.
7758 * dispextern.h (scroll_cost): Remove decl.
7759
de68a1fc
PE
7760 * region-cache.h (pp_cache): Mark as externally visible.
7761
40ccffa6
PE
7762 * process.c: Make symbols static if they're not exported.
7763 (process_tick, update_tick, create_process, chan_process):
7764 (Vprocess_alist, proc_buffered_char, datagram_access):
7765 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7766 (deactivate_process): Mark defn as static, as well as decl.
7767 * lisp.h (create_process): Remove decl.
7768 * process.h (chan_process, Vprocess_alist): Remove decls.
7769
ad64fc97
PE
7770 * print.c: Make symbols static if they're not exported.
7771 (print_depth, new_backquote_output, being_printed, print_buffer):
7772 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7773 (print_interval, print_number_index, initial_stderr_stream):
7774 Now static.
7775 * lisp.h (Fprinc): Remove decl.
7776 (debug_output_compilation_hack): Mark as externally visible.
7777
adddb265
PE
7778 * sysdep.c (croak): Move decl from here to syssignal.h.
7779 * syssignal.h (croak): Put it here, so the API can be checked when
7780 'croak' is called from dissociate_if_controlling_tty.
7781
1717ede2
PE
7782 * minibuf.c: Make symbols static if they're not exported.
7783 (minibuf_save_list, choose_minibuf_frame): Now static.
7784 * lisp.h (choose_minibuf_frame): Remove decl.
7785
fa5fb2bc
PE
7786 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7787
1e3890d1
PE
7788 * lread.c: Make symbols static if they're not exported.
7789 (read_objects, initial_obarray, oblookup_last_bucket_number):
7790 Now static.
7791 (make_symbol): Remove; unused.
7792 * lisp.h (initial_obarray, make_symbol): Remove decls.
7793
8a1414fa
PE
7794 * keyboard.c: Make symbols static if they're not exported.
7795 (single_kboard, recent_keys_index, total_keys, recent_keys):
7796 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7797 (this_single_command_key_start, echoing, last_auto_save):
7798 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7799 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7800 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7801 (Vlispy_mouse_stem, double_click_count):
7802 Now static.
7803 (force_auto_save_soon): Define only if SIGDANGER.
7804 (ignore_mouse_drag_p): Now static if
7805 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7806 (print_help): Remove; unused.
7807 (stop_character, last_timer_event): Mark as externally visible.
7808 * keyboard.h (ignore_mouse_drag_p): Declare only if
7809 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7810 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7811 * lisp.h (echoing): Remove decl.
7812 (force_auto_save_soon): Declare only if SIGDANGER.
7813 * xdisp.c (redisplay_window): Simplify code, to make it more
7814 obvious that ignore_mouse_drag_p is not accessed if !defined
7815 USE_GTK && !defined HAVE_NS.
7816
93ea6e8f
PE
7817 * intervals.c: Make symbols static if they're not exported.
7818 (merge_properties_sticky, merge_interval_right, delete_interval):
7819 Now static.
7820 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7821
77382fcc
PE
7822 * insdel.c: Make symbols static if they're not exported.
7823 However, leave prepare_to_modify_buffer alone. It's never
7824 called from outside this function, but that appears to be a bug.
7825 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7826 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7827 (adjust_after_replace_noundo): Remove; unused.
7828 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7829 (signal_before_change): Remove decls.
77382fcc 7830
9306c32e
PE
7831 * indent.c (val_compute_motion, val_vmotion): Now static.
7832
cd44d2eb
PE
7833 * image.c: Make symbols static if they're not exported.
7834 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7835 if USE_GTK.
7836 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7837 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7838
ad9a7a06
PE
7839 * fringe.c (standard_bitmaps): Now static.
7840 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7841
81626931
PE
7842 * frame.c: Make symbols static if they're not exported.
7843 (x_report_frame_params, make_terminal_frame): Now static.
7844 (get_frame_param): Now static, unless HAVE_NS.
7845 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7846 (x_get_resource_string): Remove; not used.
7847 * frame.h (make_terminal_frame, x_report_frame_params):
7848 (x_get_resource_string); Remove decls.
7849 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7850 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7851
239f9db9
PE
7852 * font.c, fontset.c: Make symbols static if they're not exported.
7853 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7854 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7855 * font.c (font_close_object): Now static.
7856 * font.h (font_close_object): Remove.
7857 * fontset.c (FONTSET_OBJLIST): Remove.
7858 (free_realized_fontset) #if-0 the body, which does nothing.
7859 (face_suitable_for_char_p): #if-0, as it's never called.
7860 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7861 * xfaces.c (face_at_string_position):
7862 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7863 since 0 is always ASCII.
7864
dfcf3579
PE
7865 * fns.c (weak_hash_tables): Now static.
7866
5045092b
PE
7867 * fileio.c: Make symbols static if they're not exported.
7868 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7869 (Vwrite_region_annotation_buffers): Now static.
7870
57a96f5c
PE
7871 * eval.c: Make symbols static if they're not exported.
7872 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7873 * lisp.h (backtrace_list): Remove decl.
7874
35f08c38
PE
7875 * emacs.c: Make symbols static if they're not exported.
7876 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7877 (fatal_error_code, fatal_error_signal_hook, standard_args):
7878 Now static.
7879 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7880 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7881 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7882 * lisp.h (fatal_error_signal_hook): Remove decl.
7883 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7884
f44bd759
PE
7885 * editfns.c: Move a (normally-unused) function to its only use.
7886 * editfns.c, lisp.h (get_operating_system_release): Remove.
7887 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7888 worth the hassle of breaking this out.
7889
b532497d
PE
7890 * xterm.c: Make symbols static if they're not exported.
7891 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7892 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7893 (x_destroy_window, x_delete_display):
7894 Now static.
7895 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7896 (x_mouse_leave): Remove; unused.
7897 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7898 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7899 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7900 Remove decls.
7901 (x_mouse_leave): Declare only if WINDOWSNT.
7902 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7903 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7904 USE_X_TOOLKIT.
7905
1675728f
PE
7906 * ftxfont.c: Make symbols static if they're not exported.
7907 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7908 HAVE_FREETYPE.
7909 * font.h (ftxfont_driver): Likewise.
7910
e4cebfca
PE
7911 * xfns.c: Make symbols static if they're not exported.
7912 (x_last_font_name, x_display_info_for_name):
7913 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7914 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7915 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7916 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7917 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7918 (last_show_tip_args): Now static.
7919 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7920 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7921 (x_screen_planes): Remove; unused.
7922 * dispextern.h (x_screen_planes): Remove decl.
7923
5bf46f05
PE
7924 * dispnew.c: Make symbols static if they're not exported.
7925 * dispextern.h (redraw_garbaged_frames, scrolling):
7926 (increment_row_positions): Remove.
7927 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7928 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7929 Now static.
7930 (redraw_garbaged_frames): Remove; unused.
7931
435f4c28
PE
7932 * xfaces.c: Make symbols static if they're not exported.
7933 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7934 Remove decls.
7935 * xterm.h (defined_color): Remove decls.
7936 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7937 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7938 (menu_face_changed_default, defined_color, free_realized_face):
7939 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7940 (ascii_face_of_lisp_face): Remove; unused.
7941
8524aef3
PE
7942 * xdisp.c: Make symbols static if they're not exported.
7943 * dispextern.h (scratch_glyph_row, window_box_edges):
7944 (glyph_to_pixel_coords, set_cursor_from_row):
7945 (get_next_display_element, set_iterator_to_next):
7946 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7947 (show_mouse_face): Remove decls
7948 * frame.h (message_buf_print): Likewise.
7949 * lisp.h (pop_message, set_message, check_point_in_composition):
7950 Likewise.
7951 * xterm.h (set_vertical_scroll_bar): Likewise.
7952 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7953 (message_buf_print, scratch_glyph_row, displayed_buffer):
7954 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7955 (get_next_display_element, show_mouse_face, window_box_edges):
7956 (frame_to_window_pixel_xy, check_point_in_composition):
7957 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7958 (glyph_to_pixel_coords): Remove; unused.
7959
16390cd2
PE
7960 * dired.c (file_name_completion): Now static.
7961
7962 * dbusbind.c (xd_in_read_queued_messages): Now static.
7963
a25f4dfa
PE
7964 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7965 * data.c (circular_list_error): Remove.
7966
14a9c8df
PE
7967 * commands.h (last_point_position, last_point_position_buffer):
7968 (last_point_position_window): Remove decls.
7969 * keyboard.c: Make these variables static.
7970
04f2d78b
CB
7971 * coding.h (coding, code_convert_region, encode_coding_gap):
7972 Remove decls.
74ab6df5
PE
7973 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7974 (iso_code_class, detect_coding, code_convert_region): Now static.
7975 (encode_coding_gap): Remove; unused.
7976
38dfbee1
PE
7977 * chartab.c (chartab_chars, chartab_bits): Now static.
7978
a2cb4e63
PE
7979 * charset.h (charset_iso_8859_1): Remove decl.
7980 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7981 Now static.
7982
127198fd
PE
7983 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7984 * ccl.c (Vccl_program_table): Now static.
7985 (check_ccl_update): Remove; unused.
7986
d85b608f
PE
7987 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7988 * category.h: ... from here.
7989 * category.c (check_category_table, set_category_set): Now static.
7990
31cd66f3
PE
7991 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7992 * lisp.h: Remove these decls.
7993
c358e587
PE
7994 * buffer.c (buffer_count): Remove unused var.
7995
e78aecca
PE
7996 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7997 so that it's not optimized away.
7998 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7999 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8000 exported only to the debugger.
8001
e192d7d3 8002 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8003 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8004
92470028
PE
8005 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8006 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8007 was inaccessible from Lisp.
8008 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8009 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8010
244ed907
PE
8011 alloc.c: Import and export fewer symbols, and remove unused items.
8012 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8013 is defined.
8014 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8015 it's not optimized away by whole-program optimization.
8016 (message_enable_multibyte, free_misc): Remove.
8017 (catchlist, handlerlist, mark_backtrace):
8018 Declare only if BYTE_MARK_STACK.
8019 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8020 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8021 (message_enable_multibyte): Remove decl.
8022 (free_misc, interval_free_list, float_block, float_block_index):
8023 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8024 (cons_free_list, last_marked_index):
8025 Now static.
8026 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8027 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8028 (mark_backtrace): Define only if BYTE_MARK_STACK.
8029 * xdisp.c (message_enable_multibyte): Now static.
8030
61c2b50e 8031 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8032 This makes it easier for human readers (and static analyzers)
8033 to see whether these variables are used from other modules.
8034 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8035 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8036 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8037 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8038 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8039 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8040 * xmenu.c, xselect.c:
8041 Declare Q* vars static if they are not used in other modules.
8042 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8043 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8044 Remove decls of unexported vars.
8045 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8046
95c82688
PE
8047 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8048
16a97296
PE
8049 Make Emacs functions such as Fatom 'static' by default.
8050 This makes it easier for human readers (and static analyzers)
8051 to see whether these functions can be called from other modules.
8052 DEFUN now defines a static function. To make the function external
8053 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8054 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8055 (Finit_image_library):
16a97296
PE
8056 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8057 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8058 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8059 Remove decls, since these functions are now static.
8060 (Funintern, Fget_internal_run_time): New decls, since these functions
8061 were already external.
95c82688 8062
16a97296
PE
8063 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8064 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8065 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8066 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8067 * keyboard.c, keymap.c, lread.c:
8068 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8069 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8070 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8071 Mark functions with DEFUE instead of DEFUN,
8072 if they are used in other modules.
8073 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8074 decls for now-static functions.
8075 * buffer.h (Fdelete_overlay): Remove decl.
8076 * callproc.c (Fgetenv_internal): Mark as internal.
8077 * composite.c (Fremove_list_of_text_properties): Remove decl.
8078 (Fcomposition_get_gstring): New forward static decl.
8079 * composite.h (Fcomposite_get_gstring): Remove decl.
8080 * dired.c (Ffile_attributes): New forward static decl.
8081 * doc.c (Fdocumntation_property): New forward static decl.
8082 * eval.c (Ffetch_bytecode): New forward static decl.
8083 (Funintern): Remove extern decl; now in .h file where it belongs.
8084 * fileio.c (Fmake_symbolic_link): New forward static decl.
8085 * image.c (Finit_image_library): New forward static decl.
8086 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8087 * intervals.h (Fprevious_property_change):
8088 (Fremove_list_of_text_properties): Remove decls.
8089 * keyboard.c (Fthis_command_keys): Remove decl.
8090 (Fcommand_execute): New forward static decl.
8091 * keymap.c (Flookup_key): New forward static decl.
8092 (Fcopy_keymap): Now static.
8093 * keymap.h (Flookup_key): Remove decl.
8094 * process.c (Fget_process): New forward static decl.
8095 (Fprocess_datagram_address): Mark as internal.
8096 * syntax.c (Fsyntax_table_p): New forward static decl.
8097 (skip_chars): Remove duplicate decl.
8098 * textprop.c (Fprevious_property_change): New forward static decl.
8099 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8100 Now internal.
8101 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8102 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8103
785bbd42
PE
8104 * editfns.c (Fformat): Remove unreachable code.
8105
8b913b57
AS
81062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8107
8108 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8109 change. (Bug#8496)
8110
a6744a35
EZ
81112011-04-13 Eli Zaretskii <eliz@gnu.org>
8112
8113 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8114 when at ZV. (Bug#8487)
8115
e7974947
AS
81162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8117
baad03f0
AS
8118 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8119 (Bug#8437)
8120 * keyboard.c (parse_tool_bar_item): Likewise.
8121 * sound.c (sound_cleanup, alsa_close): Likewise.
8122 * termcap.c (tgetent): Likewise.
8123 * xfns.c (x_default_font_parameter): Likewise.
8124 * xsettings.c (read_and_apply_settings): Likewise.
8125
e7974947
AS
8126 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8127 (overrun_check_free): Protoize.
8128
28272684
PE
81292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8130
8131 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8132 since callers should never pass a negative size.
8133 Change the signature to match that of plain 'read' and 'write'; see
8134 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8135 * lisp.h: Update prototypes of emacs_write and emacs_read.
8136
11997c76
EZ
81372011-04-11 Eli Zaretskii <eliz@gnu.org>
8138
8139 * xdisp.c (redisplay_window): Don't try to determine the character
8140 position of the scroll margin if the window start point w->startp
e896f03c 8141 is outside the buffer's accessible region. (Bug#8468)
11997c76 8142
8a2cbd72
EZ
81432011-04-10 Eli Zaretskii <eliz@gnu.org>
8144
8145 Fix write-region and its subroutines for buffers > 2GB.
8146 * fileio.c (a_write, e_write): Modify declaration of arguments and
8147 local variables to support buffers larger than 2GB.
8148 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8149
8150 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8151 argument, local variables, and return value.
8152
8153 * lisp.h: Update prototypes of emacs_write and emacs_read.
8154
8155 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8156
4073e537 81572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8158
1ebfdcb6
PE
8159 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8160
b2ded58d
PE
8161 Fix more problems found by GCC 4.6.0's static checks.
8162
7d66342c
PE
8163 * xdisp.c (vmessage): Use a better test for character truncation.
8164
bbf47d44
PE
8165 * charset.c (load_charset_map): <, not <=, for optimization,
8166 and to avoid potential problems with integer overflow.
9248994d 8167 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8168 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8169 * editfns.c (Fformat): Likewise.
1e69125e 8170 * syntax.c (skip_chars): Likewise.
3befa583 8171
e3019616
PE
8172 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8173 This also lets GCC 4.6.0 generate slightly better loop code.
8174
becfa255
PE
8175 * callint.c (Fcall_interactively): <, not <=, for optimization.
8176 (Fcall_interactively): Count the number of arguments produced,
8177 not the number of arguments given. This is simpler and lets GCC
8178 4.6.0 generate slightly better code.
8179
dae0cd48
PE
8180 * ftfont.c: Distingish more carefully between FcChar8 and char.
8181 The previous code passed unsigned char * to a functions like
8182 strlen and xstrcasecmp that expect char *, which does not
8183 conform to the C standard.
8184 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8185 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8186 char * when the C standard requires it.
8187
76032d70
PE
8188 * keyboard.c (read_char): Remove unused var.
8189
eb3f1cc8
PE
8190 * eval.c: Port to Windows vsnprintf (Bug#8435).
8191 Include <limits.h>.
8192 (SIZE_MAX): Define if the headers do not.
8193 (verror): Do not give up if vsnprintf returns a negative count.
8194 Instead, grow the buffer. This ports to Windows vsnprintf, which
8195 does not conform to C99. Problem reported by Eli Zaretskii.
8196 Also, simplify the allocation scheme, by avoiding the need for
8197 calling realloc, and removing the ALLOCATED variable.
8198
70476b54
PE
8199 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8200
12020a9e
PE
8201 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8202 But keep the doprint source code for now, as we might revamp it
8203 and use it again (Bug#8435).
ea6c7ae6
PE
8204 * lisp.h (doprnt): Remove.
8205 * Makefile.in (base_obj): Remove doprnt.o.
8206 * deps.mk (doprnt.o): Remove.
8207
5fdb398c
PE
8208 error: Print 32- and 64-bit integers portably (Bug#8435).
8209 Without this change, on typical 64-bit hosts error ("...%d...", N)
8210 was used to print both 32- and 64-bit integers N, which relied on
8211 undefined behavior.
61bdb816 8212 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8213 * lisp.h (error, verror): Mark as printf-like functions.
8214 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8215 Report overflow in size calculations when allocating printf buffer.
8216 Do not truncate output string at its first null byte.
8217 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8218 Truncate the output at a character boundary, since vsnprintf does not
8219 do that.
8220 * charset.c (check_iso_charset_parameter): Convert internal
8221 character to string before calling 'error', since %c now has the
8222 printf meaning.
8223 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8224 overflow when computing char to be passed to 'error'. Do not
8225 pass Lisp_Object to 'error'; pass the integer instead.
8226 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8227 formatted with plain %d.
8228
b189fa66
PE
8229 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8230
bff87ef0
PE
8231 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8232
7e2cac20
PE
8233 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8234
ce4d90b5
PE
8235 * xterm.c (x_catch_errors): Remove duplicate declaration.
8236
266c9547
PE
8237 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8238
79c49ad2
PE
8239 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8240
368f4090
JM
82412011-04-10 Jim Meyering <meyering@redhat.com>
8242
8243 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8244 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8245 return ssize_t not "int", and use size_t as the buffer length.
8246 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8247 * gnutls.h: Update declarations.
8248 * process.c (read_process_output): Use ssize_t, to match.
8249 (send_process): Likewise.
8250
a32d4040
CY
82512011-04-09 Chong Yidong <cyd@stupidchicken.com>
8252
8253 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8254
8546720e 82552011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8256
04f2d78b
CB
8257 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8258 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8259
8546720e
GM
8260 * xterm.c (handle_one_xevent):
8261 * xmenu.c (create_and_show_popup_menu):
8262 * xselect.c (x_decline_selection_request)
8263 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8264
0a2f5c1a 82652011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8266
8267 Fix some uses of `int' instead of EMACS_INT.
8268 * search.c (string_match_1, fast_string_match)
8269 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8270 (scan_buffer, find_next_newline_no_quit)
8271 (find_before_next_newline, search_command, Freplace_match)
8272 (Fmatch_data): Make some `int' variables be EMACS_INT.
8273
8274 * xdisp.c (display_count_lines): 3rd argument and return value now
8275 EMACS_INT. All callers changed.
8276 (pint2hrstr): Last argument is now EMACS_INT.
8277
8278 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8279 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8280 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8281 (decode_coding_utf_16, decode_coding_emacs_mule)
8282 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8283 (decode_coding_ccl, decode_coding_charset)
8284 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8285 (decode_coding_iso_2022, decode_coding_emacs_mule)
8286 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8287 <char_offset, last_offset>: Declare EMACS_INT.
8288 (encode_coding_utf_8, encode_coding_utf_16)
8289 (encode_coding_emacs_mule, encode_invocation_designation)
8290 (encode_designation_at_bol, encode_coding_iso_2022)
8291 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8292 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8293 Declare EMACS_INT.
8294 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8295 (encode_invocation_designation): Last argument P_NCHARS is now
8296 EMACS_INT.
8297 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8298 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8299
8300 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8301 All users changed.
8302
8303 * ccl.c (Fccl_execute_on_string): Declare some variables
8304 EMACS_INT.
8305
8546720e 83062011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8307
8308 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8309
4e19a977
CS
83102011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8311
8312 * process.c (Fformat_network_address): Doc fix.
8313
87302331
R
83142011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8315
ee7683eb 8316 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8317
cbb59342
CY
83182011-04-08 Chong Yidong <cyd@stupidchicken.com>
8319
8320 * keyboard.c (read_char): Call Lisp function help-form-show,
8321 instead of using internal_with_output_to_temp_buffer.
8322 (Qhelp_form_show): New var.
e0d38eeb 8323 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8324
8325 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8326
8327 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8328
e67a13ab
CY
83292011-04-06 Chong Yidong <cyd@stupidchicken.com>
8330
04f2d78b
CB
8331 * process.c (Flist_processes): Remove to Lisp.
8332 (list_processes_1): Delete.
e67a13ab 8333
973f782d
EZ
83342011-04-06 Eli Zaretskii <eliz@gnu.org>
8335
7c106b1e
EZ
8336 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8337
973f782d
EZ
8338 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8339
41cf7d1a 83402011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8341
ca23cc88
PE
8342 Fix more problems found by GCC 4.6.0's static checks.
8343
f390e2d5
PE
8344 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8345
42eea0d0
PE
8346 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8347
b69769da 8348 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8349
f9541e84
PE
8350 * xdisp.c (vmessage): Mark as a printf-like function.
8351
13841b55
PE
8352 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8353
c136c10f
PE
8354 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8355
5e2d4a30
PE
8356 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8357 printf-like functions.
8358 (tiff_load): Add casts to remove these marks before passing them
8359 to system-supplied API.
8360
583f48b9
PE
8361 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8362
b25d760e
PE
8363 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8364 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8365 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8366 directly, rather than having caller test rule sign. This avoids
8367 some unnecessary tests.
8368 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8369 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8370 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8371
bc7b6697 8372 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8373 (xfont_open): Avoid unnecessary tests.
bc7b6697 8374
27ccc379
PE
8375 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8376
dcd5c89a
PE
8377 * composite.h, composite.c (composition_gstring_put_cache):
8378 Use EMACS_INT, not int, for length.
8379
b13a45c6
PE
8380 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8381 breaking out part of COMPOSITION_DECODE_RULE.
8382 (COMPOSITION_DECODE_RULE): Use it.
8383 * composite.c (get_composition_id): Remove unused local vars,
8384 by using the new macro.
8385
1e792e4d
PE
8386 * textprop.c (set_text_properties_1): Change while to do-while,
8387 since the condition is always true at first.
8388
dc6c6455 8389 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8390 (interval_deletion_adjustment): Return unsigned value.
8391 All uses changed.
dc6c6455 8392
aba7731a
PE
8393 * process.c (list_processes_1, create_pty, read_process_output):
8394 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8395 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8396 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8397 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8398 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8399
fdfc4bf3
PE
8400 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8401
fca8fe46 8402 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8403 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8404
06a0259a 8405 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8406 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8407 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8408
e7b9e80f
PE
8409 * print.c (print_error_message): Avoid int overflow.
8410
56201685
PE
8411 * font.c (font_list_entities): Redo for clarity,
8412 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8413
78834453 8414 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8415 (font_score): Avoid potential overflow in diff calculation.
78834453 8416
0bc0b309 8417 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8418 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8419
e610eaca
PE
8420 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8421
b895abce
PE
8422 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8423 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8424 can always succeed if overflow has undefined behavior.
8425
1f1d9321 8426 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8427 (wordify): Omit three unnecessary tests.
1f1d9321 8428
c59478bc
PE
8429 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8430 All callers changed. This avoids the need for an unused var.
8431
79b73827
PE
8432 * casefiddle.c (casify_region): Remove var that is set but not used.
8433
a4db5dfe
PE
8434 * dired.c (file_name_completion): Remove var that is set but not used.
8435
43aae36e
PE
8436 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8437
2a47c44d 8438 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8439 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8440
a37c69bf
PE
8441 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8442 Check for integer overflow on size calculations.
8443
328ab8e7
PE
8444 * buffer.c (Fprevious_overlay_change): Remove var that is set
8445 but not used.
8446
e5a2a5cb
PE
8447 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8448 Remove vars that are set but not used.
8d84a6eb 8449 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8450 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8451
a60e5f68
PE
8452 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8453
f661cb61 8454 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8455 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8456
f0397f5a
PE
8457 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8458 that are set but not used.
8459
8664db06 8460 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8461 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8462
6abdaa4a
PE
8463 * xselect.c (x_get_local_selection, x_handle_property_notify):
8464 Remove vars that are set but not used.
8465
0ce7538d 8466 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8467 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8468
9ae848fc
PE
8469 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8470 Remove var that is set but not used.
0b918413
PE
8471 (scroll_bar_windows_size): Now size_t, not int.
8472 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8473 Check for overflow.
9ae848fc 8474
a5a62657
PE
8475 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8476 (map_tty_color) [!defined MSDOS]: Likewise.
8477
5c5cdd39
PE
8478 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8479
66ebf983
PE
8480 * coding.c: Remove vars that are set but not used.
8481 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8482 All callers changed.
8483 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8484 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8485 (decode_coding_charset): Remove vars that are set but not used.
8486
1be4d761
PE
8487 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8488 that is set but not used.
8489
47553fa8
PE
8490 * print.c (print_object): Remove var that is set but not used.
8491
1f7196bf 8492 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8493 The gnulib version avoids calling malloc in the usual case,
8494 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8495 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8496 * filelock.c (current_lock_owner): Likewise.
8497 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8498 * sysdep.c: Include allocator.h, careadlinkat.h.
8499 (emacs_no_realloc_allocator): New static constant.
8500 (emacs_readlink): New function.
fdb61804
PE
8501 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8502 ../lib/careadlinkat.h.
d1fdcab7 8503
f84c17c7
SM
85042011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8505
8506 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8507 first non-nil return value).
8508
ef3862ad
JD
85092011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8510
8511 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8512 if not defined (Bug#8403).
8513
376a7006
JB
85142011-04-02 Juanma Barranquero <lekktu@gmail.com>
8515
8516 * xdisp.c (display_count_lines): Remove parameter `start',
8517 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8518 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8519 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8520 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8521 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8522 and thereabouts. All callers changed.
8523 (get_per_char_metric): Remove parameter `f', unused since
8524 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8525
6ca3801d
JM
85262011-04-02 Jim Meyering <meyering@redhat.com>
8527
8528 do not dereference NULL upon failed strdup
8529 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8530 (ns_get_family): Likewise.
8531
d8e2b5ba
JB
85322011-04-02 Juanma Barranquero <lekktu@gmail.com>
8533
8534 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8535
8c74fcbd
JD
85362011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8537
8538 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8539 later (Bug#8403).
8540
7200d79c
SM
85412011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8542
03408648 8543 Add lexical binding.
7200d79c 8544
03408648
SM
8545 * window.c (Ftemp_output_buffer_show): New fun.
8546 (Fsave_window_excursion):
8547 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8548
8549 * lread.c (lisp_file_lexically_bound_p): New function.
8550 (Fload): Bind Qlexical_binding.
8551 (readevalloop): Remove `evalfun' arg.
8552 Bind Qinternal_interpreter_environment.
8553 (Feval_buffer): Bind Qlexical_binding.
8554 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8555 Mark as dynamic.
8556 (syms_of_lread): Declare `lexical-binding'.
8557
8558 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8559
8560 * keyboard.c (eval_dyn): New fun.
8561 (menu_item_eval_property): Use it.
ca105506
SM
8562
8563 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8564
03408648
SM
8565 * fns.c (concat, mapcar1): Accept byte-code-functions.
8566
8567 * eval.c (Fsetq): Handle lexical vars.
8568 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8569 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8570 (FletX, Flet): Obey lexical binding.
8571 (Fcommandp): Handle closures.
8572 (Feval): New `lexical' arg.
8573 (eval_sub): New function extracted from Feval. Use it almost
8574 everywhere where Feval was used. Look up vars in lexical env.
8575 Handle closures.
8576 (Ffunctionp): Move from subr.el.
8577 (Ffuncall): Handle closures.
8578 (apply_lambda): Remove `eval_flags'.
8579 (funcall_lambda): Handle closures and new byte-code-functions.
8580 (Fspecial_variable_p): New function.
8581 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8582 but without exporting it to Lisp.
23aba0ea 8583
23aba0ea 8584 * doc.c (Fdocumentation, store_function_docstring):
03408648 8585 * data.c (Finteractive_form): Handle closures.
23aba0ea 8586
03408648
SM
8587 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8588 interactive spec.
ba83908c 8589
04f2d78b
CB
8590 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8591 New byte-codes.
03408648
SM
8592 (exec_byte_code): New function extracted from Fbyte_code to handle new
8593 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8594
03408648 8595 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8596
03408648 8597 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8598
e2abce01
JB
85992011-03-31 Juanma Barranquero <lekktu@gmail.com>
8600
8601 * xdisp.c (redisplay_internal): Fix prototype.
8602
63696a73 86032011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8604
63696a73 8605 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8606 (try_scrolling): Use it when setting scroll_limit.
8607 Limit scrolling to 100 screen lines.
63696a73
EZ
8608 (redisplay_window): Even when falling back on "recentering",
8609 position point in the window according to scroll-conservatively,
8610 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8611
8612 (try_scrolling): When point is above the window, allow searching
8613 as far as scroll_max, or one screenful, to compute vertical
8614 distance from PT to the scroll margin position. This prevents
8615 try_scrolling from unnecessarily failing when
8616 scroll-conservatively is set to a value slightly larger than the
8617 window height. Clean up the case of PT below the margin at bottom
8618 of window: scroll_max can no longer be INT_MAX. When aggressive
8619 scrolling is in use, don't let point enter the opposite scroll
8620 margin as result of the scroll.
8621 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8622 threshold of 100 lines for never-recentering scrolling.
8623
e4cc2dfc
JB
86242011-03-31 Juanma Barranquero <lekktu@gmail.com>
8625
8626 * dispextern.h (move_it_by_lines):
8627 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8628 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8629 (message_log_check_duplicate): Remove parameters `prev_bol' and
8630 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8631 (redisplay_internal): Remove parameter `preserve_echo_area',
8632 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8633
8634 * indent.c (Fvertical_motion):
8635 * window.c (window_scroll_pixel_based, Frecenter):
8636 Don't pass `need_y_p' to `move_it_by_lines'.
8637
1c470562
SM
86382011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8639
44f230aa
SM
8640 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8641 steal a few bits to be more compact.
8642 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8643 Remove unneeded casts.
8644
1c470562
SM
8645 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8646
888adce9
ZK
86472011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8648
8649 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8650 binding" message (bug#7967).
8651
f838ed7b
PE
86522011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8653
77861b95
PE
8654 Fix more problems found by GCC 4.6.0's static checks.
8655
de6dbc14
PE
8656 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8657 Remove unused local var.
8658
f838ed7b
PE
8659 * editfns.c (Fmessage_box): Remove unused local var.
8660
792c7b2b
PE
8661 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8662 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8663 Omit unused local vars.
c499e557 8664 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8665 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8666 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8667 Omit unused local var.
8668
ba0165e1
PE
8669 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8670 Don't assume string length fits in int.
32ad8845 8671 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8672 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8673
3c59b4c9
PE
8674 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8675 instead of alloca (Bug#8344).
8676
a3eed478 8677 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8678 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8679
eb4d412d
PE
8680 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8681
1658b401
PE
8682 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8683 concerns.
8684
8685 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8686
8687 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8688
9a2c6e05
PE
8689 * keyboard.c (syms_of_keyboard): Use the same style as later
8690 in this function when indexing through an array. This also
8691 works around GCC bug 48267.
8692
03d0a109
PE
8693 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8694
44f730c8
PE
8695 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8696
fe75f926
PE
8697 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8698 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8699
ffa8c828
PE
8700 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8701 This avoids undefined behavior on integer overflow, and is a bit
8702 more convenient anyway since it is compared to a size_t variable.
8703
c5101a77
PE
8704 Variadic C functions now count arguments with size_t, not int.
8705 This avoids an unnecessary limitation on 64-bit machines, which
8706 caused (substring ...) to crash on large vectors (Bug#8344).
8707 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8708 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8709 All variadic functions and their callers changed accordingly.
c5101a77
PE
8710 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8711 * data.c (arith_driver, float_arith_driver): Likewise.
8712 * editfns.c (general_insert_function): Likewise.
8713 * eval.c (struct backtrace.nargs, interactive_p)
8714 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8715 (funcall_lambda, mark_backtrace): Likewise.
8716 * fns.c (concat): Likewise.
8717 * frame.c (x_set_frame_parameters): Likewise.
8718 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8719 0 if not found, not -1. All callers changed.
8720
dd3f25f7
PE
8721 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8722 (stack_copy_size): Now size_t, not int.
8723 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8724
461c2ab9
JB
87252011-03-28 Juanma Barranquero <lekktu@gmail.com>
8726
8727 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8728 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8729 All callers changed.
8730
8731 * lisp.h (multibyte_char_to_unibyte):
8732 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8733 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8734 * character.h (CHAR_TO_BYTE8):
8735 * cmds.c (internal_self_insert):
8736 * editfns.c (general_insert_function):
8737 * keymap.c (push_key_description):
8738 * search.c (Freplace_match):
8739 * xdisp.c (message_dolog, set_message_1): All callers changed.
8740
f6d62986
SM
87412011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8742
8743 * keyboard.c (safe_run_hook_funcall): New function.
8744 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8745 don't set the hook to nil, but remove the offending function instead.
8746 (Qcommand_hook_internal): Remove, unused.
8747 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8748 Vcommand_hook_internal.
8749
8750 * eval.c (enum run_hooks_condition): Remove.
8751 (funcall_nil, funcall_not): New functions.
8752 (run_hook_with_args): Call each function through a `funcall' argument.
8753 Remove `cond' argument, now redundant.
8754 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8755 (Frun_hook_with_args_until_failure): Adjust accordingly.
8756 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8757
1db5b1ad
JB
87582011-03-28 Juanma Barranquero <lekktu@gmail.com>
8759
8760 * dispextern.h (string_buffer_position): Remove declaration.
8761
8762 * print.c (strout): Remove parameter `multibyte', unused since
8763 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8764
8765 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8766 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8767 All callers changed.
8768
8769 * w32.c (_wsa_errlist): Use braces for struct initializers.
8770
8771 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8772 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8773 All callers changed.
8774 (string_buffer_position): Likewise. Also, make static (it's never
8775 used outside xdisp.c).
8776 (cursor_row_p): Remove parameter `w', unused since
8777 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8778 (decode_mode_spec): Remove parameter `precision', introduced during
8779 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8780 All callers changed.
8781
5ffb62aa
JD
87822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8783
8784 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8785
461c2ab9 87862011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8787
8788 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8789 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8790 (ns_update_auto_hide_menu_bar): New functions.
8791 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8792 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8793 ns_constrain_all_frames.
8794 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8795 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8796
5c380ffb
JD
87972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8798
8799 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8800
9af30bdf
GM
88012011-03-27 Glenn Morris <rgm@gnu.org>
8802
8803 * syssignal.h: Replace RETSIGTYPE with void.
8804 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8805 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8806 Replace SIGTYPE with void everywhere.
8807 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8808 * s/template.h (SIGTYPE): Remove commented out definition.
8809
e2abce01
JB
88102011-03-26 Eli Zaretskii <eliz@gnu.org>
8811
8812 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8813 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8814
f868cd8a
JB
88152011-03-26 Juanma Barranquero <lekktu@gmail.com>
8816
59eb0929
JB
8817 * w32.c (read_unc_volume): Use parameter `henum', instead of
8818 global variable `wget_enum_handle'.
8819
8820 * keymap.c (describe_vector): Remove parameters `indices' and
8821 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8822 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8823
f868cd8a
JB
8824 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8825
8826 * keyboard.c (timer_check): Remove parameter `do_it_now',
8827 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8828 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8829 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8830
8831 * keyboard.c (read_char):
8832 * w32menu.c (w32_menu_display_help):
8833 * xmenu.c (show_help_event, menu_help_callback):
8834 Adjust calls to `show_help_echo'.
8835
8836 * gtkutil.c (xg_maybe_add_timer):
8837 * keyboard.c (readable_events):
8838 * process.c (wait_reading_process_output):
8839 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8840
8841 * insdel.c (adjust_markers_gap_motion):
8842 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8843 (gap_left, gap_right): Don't call it.
8844
2ecf6fdb
CY
88452011-03-25 Chong Yidong <cyd@stupidchicken.com>
8846
8847 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8848 incurred during fontification.
8849
6b1f9ba4
JB
88502011-03-25 Juanma Barranquero <lekktu@gmail.com>
8851
8852 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8853 (DEFVAR_PER_BUFFER): Don't pass it.
8854
8855 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8856 (scrolling_window): Don't pass it.
8857
0f4a96b5
JB
88582011-03-25 Juanma Barranquero <lekktu@gmail.com>
8859
8860 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8861
8862 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8863 and `suffix'.
8864 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8865 of variables specific to SELinux and computation of `encoded_absname'.
8866
8867 * image.c (XPutPixel): Remove unused variable `height'.
8868
8869 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8870
8871 * unexw32.c (get_section_info): Remove unused variable `section'.
8872
8873 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8874 (system_process_attributes): Remove unused variable `sess'.
8875 (sys_read): Remove unused variable `err'.
8876
8877 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8878 (w32_wnd_proc): Remove unused variable `isdead'.
8879 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8880 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8881 (x_create_tip_frame): Remove unused variable `tem'.
8882
8883 * w32inevt.c (w32_console_read_socket):
8884 Remove unused variable `no_events'.
8885
8886 * w32term.c (x_draw_composite_glyph_string_foreground):
8887 Remove unused variable `width'.
8888
1149507c
JB
88892011-03-24 Juanma Barranquero <lekktu@gmail.com>
8890
8891 * w32term.c (x_set_glyph_string_clipping):
8892 Don't pass uninitialized region to CombineRgn.
8893
9c88f339
JB
88942011-03-23 Juanma Barranquero <lekktu@gmail.com>
8895
8896 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8897 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8898 (Fx_close_connection): Remove unused variable `i'.
8899
8900 * w32font.c (w32font_draw): Return number of glyphs.
8901 (w32font_open_internal): Remove unused variable `i'.
8902 (w32font_driver): Add missing initializer.
8903
8904 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8905 (fill_in_menu): Remove unused variable `items_added'.
8906
8907 * w32term.c (last_mouse_press_frame): Remove static global variable.
8908 (w32_clip_to_row): Remove unused variable `f'.
8909 (x_delete_terminal): Remove unused variable `i'.
8910
8911 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8912 (NOTHING): Remove unused static global variable.
8913 (uniscribe_check_otf): Remove unused variable `table'.
8914 (uniscribe_font_driver): Add missing initializers.
8915
dee091a3
JD
89162011-03-23 Julien Danjou <julien@danjou.info>
8917
8918 * term.c (Fsuspend_tty, Fresume_tty):
8919 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8920 * window.c (temp_output_buffer_show):
8921 * insdel.c (signal_before_change):
8922 * frame.c (Fhandle_switch_frame):
8923 * fileio.c (Fdo_auto_save):
8924 * emacs.c (Fkill_emacs):
8925 * editfns.c (save_excursion_restore):
8926 * cmds.c (internal_self_insert):
8927 * callint.c (Fcall_interactively):
8928 * buffer.c (Fkill_all_local_variables):
8929 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8930 Use Frun_hooks.
0f4a96b5 8931 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8932 unconditionally since it does the check itself.
dee091a3 8933
2c520ab5 89342011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8935
c9c49752
PE
8936 Fix more problems found by GCC 4.5.2's static checks.
8937
8abc3f12
PE
8938 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8939 the first time through the loop, since we know p0 < p1 then.
8940 This also avoids a gcc -Wstrict-overflow warning.
8941
a2d26660
PE
8942 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8943 leading to a memory leak, possible in functions like
8944 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8945 of objects (Bug#8318).
a2d26660 8946
916c72e9
PE
8947 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8948 that could (at least in theory) be that large.
8949
19ab8a18
PE
8950 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8951 This is less likely to overflow, and avoids undefined behavior if
8952 overflow does occur. All callers changed. Use strtoul to scan
8953 for the unsigned long integer.
b7cbbd6f
PE
8954 (pint2hrstr): Simplify and tune code slightly.
8955 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8956
f0641eff
PE
8957 * scroll.c (do_scrolling): Work around GCC bug 48228.
8958 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8959
7f650bb9
PE
8960 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8961 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8962 (validate_x_resource_name): Simplify count usage.
8963 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8964
37dd57d1
PE
8965 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8966 fail (Bug#8306).
81e56e61 8967
699979fc 8968 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8969
401bf9b4
PE
8970 * process.c (Fmake_network_process): Use socklen_t, not int,
8971 where POSIX says socklen_t is required in portable programs.
8972 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8973 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8974 (Fmake_network_process, server_accept_connection):
8975 (wait_reading_process_output, read_process_output):
8976 Likewise.
8977
b93aacde
PE
8978 * process.c: Rename or move locals to avoid shadowing.
8979 (list_processes_1, Fmake_network_process):
8980 (read_process_output_error_handler, exec_sentinel_error_handler):
8981 Rename or move locals.
4dc343ee 8982 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8983 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8984 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8985 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8986 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8987
af8a867c 8988 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8989 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8990 Include tparam.h instead, since it declares them.
af8a867c
PE
8991 * cm.h (PC): Remove extern decl; tparam.h now does this.
8992 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8993 * terminfo.c: Include tparam.h, to check interfaces.
8994 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8995 (tparam): Adjust signature to match interface in tparam.h;
8996 this removes some undefined behavior. Check that outstring and len
8997 are zero, which they always are with Emacs.
8998 * tparam.h (PC, BC, UP): New extern decls.
8999
0248044d 9000 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9001 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9002
8ff096c1 9003 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9004 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9005 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9006 (ftfont_list): Remove unused local.
49eaafba
PE
9007 (get_adstyle_property, ftfont_pattern_entity):
9008 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9009 Rename locals to avoid shadowing.
8ff096c1 9010
e2be39f6
PE
9011 * xfont.c (xfont_list_family): Mark var as initialized.
9012
c9735e30
PE
9013 * xml.c (make_dom): Now static.
9014
8f5201ae
PE
9015 * composite.c (composition_compute_stop_pos): Rename local to
9016 avoid shadowing.
b246f932
PE
9017 (composition_reseat_it): Remove unused locals.
9018 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9019 (composition_update_it): Mark var as initialized.
11b61122
PE
9020 (find_automatic_composition): Mark vars as initialized,
9021 with a FIXME (Bug#8290).
8f5201ae 9022
760fbc2c
PE
9023 character.h: Rename locals to avoid shadowing.
9024 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9025 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9026 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9027 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9028 to avoid shadowing.
9029
ff08eb85
PE
9030 * textprop.c (property_change_between_p): Remove; unused.
9031
fc7bf025
PE
9032 * intervals.c (interval_start_pos): Now static.
9033
235d7abc
PE
9034 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9035
44f230aa
SM
9036 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9037 Rename locals to avoid shadowing.
3e7d6594 9038
50060332
PE
9039 * sound.c (wav_play, au_play, Fplay_sound_internal):
9040 Fix pointer signedness.
d01f234b 9041 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9042 (wav_play): Initialize a variable to 0, to prevent undefined
9043 behavior (Bug#8278).
50060332 9044
c4fc4e30
PE
9045 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9046
918436ed
PE
9047 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9048
c939f91b
PE
9049 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9050 clobbering (Bug#8298).
b9c7f648
PE
9051 * sysdep.c (sys_subshell): Likewise.
9052 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9053
6bd8c144
PE
9054 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9055 This should get cleaned up, so that child_setup has the
9056 same signature on all platforms.
9057
7710357c 9058 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9059 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9060
c59da222
CY
90612011-03-22 Chong Yidong <cyd@stupidchicken.com>
9062
9063 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9064 not to be necessary, and produces flickering.
9065
66b87493
GM
90662011-03-20 Glenn Morris <rgm@gnu.org>
9067
9068 * config.in: Remove file.
9069
45b6f6d5
JB
90702011-03-20 Juanma Barranquero <lekktu@gmail.com>
9071
9072 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9073 are now in src/globals.h.
9074 (syms_of_minibuf): Remove spurious & from previous change.
9075
cd394be1 90762011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9077
9078 * minibuf.c (completing-read-function): New variable.
9079 (completing-read-default): Rename from completing-read.
9080 (completing-read): Call completing-read-function.
9081
b14e3e21
CY
90822011-03-19 Juanma Barranquero <lekktu@gmail.com>
9083
9084 * xfaces.c (Fx_load_color_file):
9085 Read color file from absolute filename (bug#8250).
9086
f2b726e6
JB
90872011-03-19 Juanma Barranquero <lekktu@gmail.com>
9088
9089 * makefile.w32-in: Update dependencies.
9090
09f6ff02
EZ
90912011-03-17 Eli Zaretskii <eliz@gnu.org>
9092
9093 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9094
29a6015a
PE
90952011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9096
a3a6c54e
PE
9097 Fix more problems found by GCC 4.5.2's static checks.
9098
b766f867
PE
9099 * process.c (make_serial_process_unwind, send_process_trap):
9100 (sigchld_handler): Now static.
9101
be02381c
PE
9102 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9103 That way, the code declares only the vars that it needs.
9104 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9105 * s/cygwin.h (PTY_ITERATION): Likewise.
9106 * s/darwin.h (PTY_ITERATION): Likewise.
9107 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9108
57048744
PE
9109 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9110 * process.c (allocate_pty): Don't declare stb unless it's needed.
9111
7914961c 9112 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9113 (CONSTANTLIM): Remove; unused.
9114 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9115 Define only if needed.
7914961c 9116
b3967b18
PE
9117 * unexelf.c (unexec): Name an expression,
9118 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9119 Use a different way to cause a compilation error if anyone uses
9120 n rather than nn, a way that does not involve shadowing.
73366a00 9121 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9122
29a6015a
PE
9123 * deps.mk (unexalpha.o): Remove; unused.
9124
43cfc33e 9125 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9126 * unexec.h: New file.
ce701a33
PE
9127 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9128 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9129 Depend on unexec.h.
9130 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9131 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9132 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9133 Change as necessary to match prototype in unexec.h.
ce701a33 9134
01f44d5a
PE
9135 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9136 shadowing.
4f63c6bb 9137 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9138
a6670b0b
PE
9139 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9140 Rename locals to avoid shadowing.
9141
cef2010d 9142 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9143 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9144
d4d7173a
PE
9145 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9146
f08b802a
PE
9147 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9148 warning when compiling print.c.
9149
3ddb0639
PE
9150 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9151 instead of using an uninitialized var.
5ad03b97 9152 (font_sort_entities): Mark var as initialized.
3ddb0639 9153
170a2692
PE
9154 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9155
e663c700
PE
9156 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9157 pointers to constants.
89bc529a 9158 (font_parse_fcname): Remove unused vars.
7b81e2d0 9159 (font_delete_unmatched): Now static.
ea838e10 9160 (font_get_spec): Remove; unused.
13a547c6
PE
9161 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9162 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9163 Rename or move locals to avoid shadowing.
e663c700 9164
2a80c887 9165 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9166 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9167
1384fa33 9168 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9169 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9170
8b2c52e9
PE
9171 * alloc.c (mark_backtrace): Move decl from here ...
9172 * lisp.h: ... to here, so that it can be checked.
9173
475545b5 9174 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9175 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9176 (lisp_indirect_variable): Name an expression,
9177 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9178 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9179
b1349114 9180 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9181 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9182 Use const pointer when appropriate.
b1349114 9183
a2928364
PE
9184 * lisp.h (get_system_name, get_operating_system_release):
9185 Move decls here, to check interfaces.
9186 * process.c (get_operating_system_release): Move decl to lisp.h.
9187 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9188 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9189 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9190 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9191 (Fformat_time_string, Fencode_time, Finsert_char):
9192 (Ftranslate_region_internal, Fformat):
9193 Rename or remove local vars to avoid shadowing.
9710023e 9194 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9195
a415e694
PE
9196 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9197 avoid shadowing.
9198
8ef4622d
PE
9199 * lisp.h (eassert): Check that the argument compiles, even if
9200 ENABLE_CHECKING is not defined.
9201
946f9a5b
PE
9202 * data.c (Findirect_variable): Name an expression, to avoid
9203 gcc -Wbad-function-cast warning.
112396d6 9204 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9205 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9206 (Fmake_variable_buffer_local, Fmake_local_variable):
9207 Mark variables as initialized.
52746918 9208 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9209
e5aab7e7 9210 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9211 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9212 Rename locals to avoid shadowing.
dff45157
PE
9213 (mark_stack): Move local variables into the #ifdef region where
9214 they're used.
7bc26fdb
PE
9215 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9216 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9217 needed otherwise.
9218 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9219 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9220 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9221
e5aab7e7
PE
9222 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9223 avoids undefined behavior in theory.
9224
4da60324
PE
9225 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9226
88043301
PE
9227 Use functions, not macros, for up- and down-casing (Bug#8254).
9228 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9229 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9230 to use the following functions instead of these macros.
9231 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9232 EMACS_INT, since callers assume the returned value fits in int.
9233 (upcase1): Likewise, for UPCASE_TABLE.
9234 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9235 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9236 the race-condition problem in the old DOWNCASE.
88043301 9237
19ed5445
PE
9238 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9239 Rename locals to avoid shadowing.
9240 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9241 (regex_compile, re_search_2, re_match_2_internal):
9242 Remove unused local vars.
952db0d7
PE
9243 (FREE_VAR): Rewrite so as not to use empty "else",
9244 which gcc can warn about.
da053e48 9245 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9246 (RETALLOC_IF): Define only if needed.
9247 (WORDCHAR_P): Likewise. This one is never needed, but is used
9248 only in a comment talking about a compiler bug, so put inside
9249 the #if 0 of that comment.
9250 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9251 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9252 Remove; unused.
19ed5445 9253
1f3561e4 9254 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9255 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9256 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9257
ded6f8f7
PE
9258 * search.c (simple_search): Remove unused var.
9259
dbd37a95
PE
9260 * dired.c (compile_pattern): Move decl from here ...
9261 * lisp.h: ... to here, so that it can be checked.
9262 (struct re_registers): New forward decl.
9263
7e47afad
PE
9264 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9265
85f24f61
PE
9266 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9267 All uses changed.
9268 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9269 Rename locals to avoid shadowing.
5671df8f 9270 (Fvertical_motion): Mark locals as initialized.
85f24f61 9271
181aa2be 9272 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9273 (casify_region): Mark local as initialized.
181aa2be 9274
930d429c
PE
9275 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9276
7082eac6
PE
9277 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9278 New macros, so that the caller can use some names other than
9279 gcpro1, gcpro2, etc.
9280 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9281 of the new macros.
9282 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9283 argument, for consistency with GCPRO2_VAR, etc: it is now the
9284 prefix of the variable, not the variable itself. All uses
9285 changed.
38b2c076
PE
9286 * dired.c (directory_files_internal, file_name_completion):
9287 Rename locals to avoid shadowing.
9288
15206ed9
PE
9289 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9290 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9291 dired.c's scmp function, had undefined behavior.
9292 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9293 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9294 * buffer.h: ... to here, because these macros use current_buffer,
9295 and the new implementation with inline functions needs to have
9296 current_buffer in scope now, rather than later when the macros
9297 are used.
9298 (downcase, upcase1): New static inline functions.
9299 (DOWNCASE, UPCASE1): Reimplement using these functions.
9300 This avoids undefined behavior in expressions like
9301 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9302 from race conditions in accessing the global variables
9303 case_temp1 and case_temp2.
9304 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9305 * lisp.h (case_temp1, case_temp2): Remove their decls.
9306 * character.h (ASCII_CHAR_P): Move from here ...
9307 * lisp.h: ... to here, so that the inline functions mentioned
9308 above can use them.
9309
4a6bea26
PE
9310 * dired.c (directory_files_internal_unwind): Now static.
9311
f14b7e14
PE
9312 * fileio.c (file_name_as_directory, directory_file_name):
9313 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9314 Now static.
2893f146
PE
9315 (file_name_as_directory): Use const pointers when appropriate.
9316 (Fexpand_file_name): Likewise. In particular, newdir might
9317 point at constant storage, so make it a const pointer.
fd4ead52 9318 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9319 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9320 signedness issues.
f839df0c
PE
9321 (Fset_file_times, Finsert_file_contents, auto_save_error):
9322 Rename locals to avoid shadowing.
f14b7e14 9323
5716756e 9324 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9325 (Ftry_completion, Fall_completions): Rename or remove locals
9326 to avoid shadowing.
5716756e 9327
b4c3046a
PE
9328 * marker.c (bytepos_to_charpos): Remove; unused.
9329
b45db522
PE
9330 * lisp.h (verify_bytepos, count_markers): New decls,
9331 so that gcc does not warn that these functions aren't declared.
9332
85876d07
PE
9333 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9334 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9335 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9336 (copy_text): Remove unused local var.
85876d07 9337
03d78a21 9338 * filelock.c (within_one_second): Now static.
b3dd38ab 9339 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9340
5df8f01b
PE
9341 * buffer.c (fix_overlays_before): Mark locals as initialized.
9342 (fix_start_end_in_overlays): Likewise. This function should be
9343 simplified by using pointers-to-pointers, but that's a different
9344 matter.
b1d876f1 9345 (switch_to_buffer_1): Now static.
8f54f30a
PE
9346 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9347 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9348
a70072c9 9349 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9350 Fix pointer signedness issue.
edced198
PE
9351 (sys_subshell): Mark local as volatile if checking for lint,
9352 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9353 (MAXPATHLEN): Define only if needed.
a70072c9 9354
a0977c44
PE
9355 * process.c (serial_open, serial_configure): Move decls from here ...
9356 * systty.h: ... to here, so that they can be checked.
9357
a884fdcc
PE
9358 * fns.c (get_random, seed_random): Move extern decls from here ...
9359 * lisp.h: ... to here, so that they can be checked.
9360
604efe86 9361 * sysdep.c (reset_io): Now static.
b8950c94 9362 (wait_for_termination_signal): Remove; unused.
604efe86 9363
38fc62d9
PE
9364 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9365 (copy_keymap_item, append_key, push_text_char_description):
9366 Now static.
1004a21a 9367 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9368 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9369 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9370 (describe_map_tree):
9371 Rename locals to avoid shadowing.
38fc62d9 9372
2f2650da
PE
9373 * keyboard.c: Declare functions static if they are not used elsewhere.
9374 (echo_char, echo_dash, cmd_error, top_level_2):
9375 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9376 (read_char, kbd_buffer_get_event, make_lispy_position):
9377 (make_lispy_event, make_lispy_movement, apply_modifiers):
9378 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9379 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9380 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9381 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9382 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9383
a053e86c 9384 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9385 (mark_kboards): Move decl here ...
9386 * alloc.c (mark_kboards): ... from here.
a053e86c 9387
4752793e
PE
9388 * lisp.h (force_auto_save_soon): New decl.
9389
74f10ca7 9390 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9391 (DEFINE_DUMMY_FUNCTION): New macro.
9392 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9393 Use it.
c03cd23f
PE
9394 (main): Add casts to avoid warnings
9395 if GCC considers string literals to be constants.
74f10ca7 9396
022e70d4
PE
9397 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9398
59d6fe83
PE
9399 * dbusbind.c: Pointer signedness fixes.
9400 (xd_signature, xd_append_arg, xd_initialize):
9401 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9402 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9403 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9404 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9405
78320123
PE
9406 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9407 if GCC considers string literals to be constants.
49cebcca 9408 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9409
35ac2a97
SM
94102011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9411
fb103ca9
SM
9412 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9413 (print_preprocess, print_object): New macro to fix last change.
9414
35ac2a97
SM
9415 * print.c (print_preprocess): Don't forget font objects.
9416
62973b41
JB
94172011-03-16 Juanma Barranquero <lekktu@gmail.com>
9418
9419 * emacs.c (USAGE3): Doc fixes.
9420
0e48bb22
AS
94212011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9422
9423 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9424 structure.
9425
7684e57b
JB
94262011-03-14 Juanma Barranquero <lekktu@gmail.com>
9427
9428 * lisp.h (VWindow_system, Qfile_name_history):
9429 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9430 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9431 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9432
9433 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9434 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9435
9436 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9437 * w32console.c (detect_input_pending, read_input_pending)
9438 (encode_terminal_code):
9439 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9440 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9441 (w32_system_caret_y, Qfile_name_history):
9442 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9443 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9444 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9445 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9446 * w32proc.c (Qlocal, report_file_error):
9447 * w32term.c (Vwindow_system, updating_frame):
9448 * w32uniscribe.c (initialized, uniscribe_font_driver):
9449 Remove unneeded extern declarations.
9450
2aa46d6c
CY
94512011-03-14 Chong Yidong <cyd@stupidchicken.com>
9452
c96bbc66 9453 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9454
cffc6f3b
CY
94552011-03-13 Chong Yidong <cyd@stupidchicken.com>
9456
9457 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9458 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9459 These macros can no longer be used for assignment.
9460
44f230aa
SM
9461 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9462 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9463 (record_buffer_markers, fetch_buffer_markers): New functions for
9464 recording and fetching special buffer markers.
9465 (set_buffer_internal_1, set_buffer_temp): Use them.
9466
9467 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9468
9469 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9470
9471 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9472 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9473
9474 * xdisp.c (hscroll_window_tree):
9475 (reconsider_clip_changes): Use PT instead of BUF_PT.
9476
d251f04b
EZ
94772011-03-13 Eli Zaretskii <eliz@gnu.org>
9478
9479 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9480 $(EMACS_ROOT)/lib/intprops.h.
9481
f0c77cd1
PE
94822011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9483
3eca4629
PE
9484 Fix more problems found by GCC 4.5.2's static checks.
9485
7c86ee98
PE
9486 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9487 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9488 (xg_free_frame_widgets): Make it clear that a local variable is
9489 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9490 (gdk_window_get_screen): Make it clear that this macro is needed
9491 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9492 (int_gtk_range_get_value): New function, which avoids a diagnostic
9493 from gcc -Wbad-function-cast.
9494 (xg_set_toolkit_scroll_bar_thumb): Use it.
9495 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9496 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9497 (get_utf8_string, xg_get_file_with_chooser):
9498 Rename locals to avoid shadowing.
9499 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9500
41729b81
PE
9501 * xgselect.c (xg_select): Remove unused var.
9502
f0c77cd1
PE
9503 * image.c (four_corners_best): Mark locals as initialized.
9504 (gif_load): Initialize transparent_p to zero (Bug#8238).
9505 Mark another local as initialized.
ec6cf4c6 9506 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9507
ce0ad53d 9508 * image.c (clear_image_cache): Now static.
d5d5a617 9509 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9510 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9511 (x_edge_detection): Remove unnecessary cast that
9512 gcc -Wbad-function-cast diagnoses.
2037898d 9513 (gif_load): Fix pointer signedness.
6ae141d6
PE
9514 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9515 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9516
33383987 95172011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9518
d32df629
PE
9519 Improve quality of tests for time stamp overflow.
9520 For example, without this patch (encode-time 0 0 0 1 1
9521 1152921504606846976) returns the obviously-bogus value (-948597
9522 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9523 reports time overflow. See
9524 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9525 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9526 * editfns.c: Include limits.h and intprops.h.
9527 (TIME_T_MIN, TIME_T_MAX): New macros.
9528 (time_overflow): Move earlier, to before first use.
9529 (hi_time, lo_time): New functions, for an accurate test for
9530 out-of-range times.
9531 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9532 (Fget_internal_run_time): Don't assume time_t fits in int.
9533 (make_time): Use list2 instead of Fcons twice.
9534 (Fdecode_time): More accurate test for out-of-range times.
9535 (check_tm_member): New function.
9536 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9537 (lisp_time_argument): Don't rely on undefined left-shift and
9538 right-shift behavior when checking for time stamp overflow.
8be6f318 9539
fe31d94c
PE
9540 * editfns.c (time_overflow): New function, refactoring common code.
9541 (Fformat_time_string, Fdecode_time, Fencode_time):
9542 (Fcurrent_time_string): Use it.
9543
8be6f318
PE
9544 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9545 * dired.c (make_time): Move to ...
9546 * editfns.c (make_time): ... here.
9547 * systime.h: Note the move.
9548
09d9db2c 95492011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9550
126bc0dc
YM
9551 * fringe.c (update_window_fringes): Remove unused variables.
9552
c47cbdfd
YM
9553 * unexmacosx.c (copy_data_segment): Also copy __got section.
9554 (Bug#8223)
9555
7ac80be9
EZ
95562011-03-12 Eli Zaretskii <eliz@gnu.org>
9557
c96bbc66 9558 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9559 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9560 Constify `char *' arguments and their references according to
9561 prototypes in tparam.h.
9562
ecb0f94d 9563 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9564
7ac80be9
EZ
9565 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9566 Adapt all references accordingly.
9567
9568 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9569
ef1fd07e
TT
95702011-03-11 Tom Tromey <tromey@redhat.com>
9571
9572 * buffer.c (syms_of_buffer): Remove obsolete comment.
9573
7ef4b50c
EZ
95742011-03-11 Eli Zaretskii <eliz@gnu.org>
9575
9576 * termhooks.h (encode_terminal_code): Declare prototype.
9577
9578 * msdos.c (encode_terminal_code): Don't declare prototype.
9579
9580 * term.c (encode_terminal_code): Now external again, used by
9581 w32console.c and msdos.c.
9582
44f230aa
SM
9583 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9584 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9585
4b1ec863 95862011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9587
1714f52b 9588 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9589
4b1ec863
PE
9590 * fringe.c (update_window_fringes): Mark locals as initialized
9591 (Bug#8227).
9592 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9593
524c7aa6
PE
9594 * alloc.c (mark_fringe_data): Move decl from here ...
9595 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9596 to check its interface.
9597 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9598
a5c0af81 9599 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9600 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9601 (fontset_font): Mark local as initialized.
a9a06e0b 9602 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9603
b4716021
PE
9604 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9605
811e9bac 9606 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9607 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9608 (x_own_selection, Fx_disown_selection_internal): Rename locals
9609 to avoid shadowing.
9610 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9611
7e3ab302
PE
9612 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9613 so that the caller can use some name other than gcpro1.
9614 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9615 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9616 (Fx_backspace_delete_keys_p):
9617 Use them to avoid shadowing, and rename vars to avoid shadowing.
9618 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9619 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9620 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9621 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9622 Remove unused locals.
7e3ab302
PE
9623 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9624 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9625 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9626 macros.
f78faa98 9627
e2b13473
PE
9628 * xterm.h (x_mouse_leave): New decl.
9629
77f23912
PE
9630 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9631 Remove unused functions.
cdf4ba58
PE
9632 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9633 (x_calc_absolute_position): Now static.
7411c686 9634 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9635 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9636 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9637 unless they are used.
38d0b34a
PE
9638 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9639 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9640 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9641 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9642 (x_error_catcher, x_connection_closed, x_error_handler):
9643 (x_error_quitter, xembed_send_message, x_iconify_frame):
9644 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9645 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9646 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9647
44f230aa
SM
9648 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9649 Rename or move locals to avoid shadowing.
6b463e58 9650 (tty_defined_color, merge_face_heights): Now static.
5967d051 9651 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9652 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9653 does not deduce is never used uninitialized.
73719eba
PE
9654 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9655 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9656
426994c3 9657 * terminal.c (store_terminal_param): Now static.
5489860b 9658
032f1620 9659 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9660 (set_frame_menubar): Remove unused local.
d4323972 9661 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9662 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9663 since they might point to immutable storage.
281585b0
PE
9664 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9665 since it's unused otherwise.
032f1620 9666
367c19e5 9667 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9668 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9669 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9670 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9671 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9672 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9673 does not deduce are never used uninitialized.
70739cbe 9674
07b48fa9
PE
9675 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9676
8868a238 9677 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9678 * window.c (window_loop, size_window):
9679 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9680
7e5cf297 9681 * window.c (display_buffer): Now static.
d6550a9f
PE
9682 (size_window): Mark variables that gcc -Wuninitialized
9683 does not deduce are never used uninitialized.
a586633d
PE
9684 * window.h (check_all_windows): New decl, to forestall
9685 gcc -Wmissing-prototypes diagnostic.
5b555da1 9686 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9687
f6095868
PE
9688 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9689 shadowing.
9690 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9691 Include <limits.h>.
9692 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9693 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9694 (load_charset_map): Mark variables that gcc -Wuninitialized
9695 does not deduce are never used uninitialized.
53df7c11 9696 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9697
f38b440c
PE
9698 * coding.c (coding_set_source, coding_set_destination):
9699 Use "else { /* comment */ }" rather than "else /* comment */;"
9700 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9701 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9702 a block, when the outer 'i' will do.
9703 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9704 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9705 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9706 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9707 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9708 Rename locals to avoid shadowing.
9709 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9710 * coding.c (emacs_mule_char, encode_invocation_designation):
9711 Now static, since they're not used elsewhere.
413bb2db 9712 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9713 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9714 (decode_coding_emacs_mule): Mark variables that gcc
9715 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9716 (detect_coding_iso_2022): Initialize a local variable that might
9717 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9718 this initialization is needed. (Bug#8211)
5f58e762
PE
9719 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9720 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9721 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9722 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9723 Remove unused macros.
f38b440c 9724
232b38b9 9725 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9726 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9727 * character.c (string_count_byte8): Likewise.
232b38b9 9728
fb90da1b
PE
9729 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9730 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9731
fb93dbc2
PE
9732 * chartab.c (copy_sub_char_table): Now static, since it's not used
9733 elsewhere.
5c156ace
PE
9734 (sub_char_table_ref_and_range, char_table_ref_and_range):
9735 Rename locals to avoid shadowing.
bbcd0949 9736 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9737
7d3b3862 9738 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9739 (BIDI_BOB): Remove unused macro.
7d3b3862 9740
6be7d3da
PE
9741 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9742 deduce are never used uninitialized.
c2ed9c8b 9743 * term.c (encode_terminal_code): Likewise.
6be7d3da 9744
75f8807f 9745 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9746
50938595
PE
9747 * tparam.h: New file.
9748 * term.c, tparam.h: Include it.
9749 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9750 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9751 Move these decls to tparam.h, and make them agree with what
9752 is actually in tparam.c. The previous trick of using incompatible
9753 decls in different modules does not conform to the C standard.
9754 All callers of tparam changed to use tparam's actual API.
9755 * tparam.c (tparam1, tparam, tgoto):
9756 Use const pointers where appropriate.
9757
fbceeba2
PE
9758 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9759 * cm.h (struct cm): Likewise.
9760 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9761 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9762 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9763 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9764 (turn_on_face, init_tty): Likewise.
9765 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9766
7f3f1250
PE
9767 * term.c (term_mouse_position): Rename local to avoid shadowing.
9768
e6ca6543
PE
9769 * alloc.c (mark_ttys): Move decl from here ...
9770 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9771
c40f8d15
AS
97722011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9773
9774 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9775
cfe0661d
JB
97762011-03-09 Juanma Barranquero <lekktu@gmail.com>
9777
9778 * search.c (compile_pattern_1): Remove argument regp, unused since
9779 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9780 (compile_pattern): Don't pass it.
9781
0afb4571
J
97822011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9783
9784 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9785 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9786 for ! HAVE_GTK3.
9787 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9788
9789 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9790
9791 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9792 gdk_window_get_screen, gdk_window_get_geometry,
9793 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9794 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9795 (xg_get_pixbuf_from_pixmap): New function.
9796 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9797 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9798 Call xg_get_pixbuf_from_pixmap instead of
9799 gdk_pixbuf_get_from_drawable.
9800 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9801 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9802 (xg_check_special_colors): Use GtkStyleContext and its functions
9803 for HAVE_GTK3.
9804 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9805 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9806 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9807 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9808 Call gtk_widget_get_preferred_size.
0afb4571
J
9809 (xg_frame_resized): gdk_window_get_geometry only takes 5
9810 parameters.
44f230aa
SM
9811 (xg_win_to_widget, xg_event_is_for_menubar):
9812 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9813 (xg_set_widget_bg): New function.
9814 (delete_cb): New function.
895009e1 9815 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9816 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9817 (xg_set_background_color): Call xg_set_widget_bg.
9818 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9819 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9820 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9821 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9822 if ! HAVE_GTK3.
9823 (update_frame_tool_bar): Call gtk_widget_hide.
9824 (xg_initialize): Use GDK_KEY_g.
9825
9826 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9827 if ! HAVE_GTK3
9828 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9829
9830 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9831 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9832 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9833
1c2cc4ef
JB
98342011-03-08 Juanma Barranquero <lekktu@gmail.com>
9835
9836 * w32xfns.c (select_palette): Check success of RealizePalette against
9837 GDI_ERROR, not zero.
9838
33383987 9839See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9840
9841;; Local Variables:
9842;; coding: utf-8
aac0c6e3
MR
9843;; End:
9844
2f097256 9845 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9846
9847 This file is part of GNU Emacs.
9848
9849 GNU Emacs is free software: you can redistribute it and/or modify
9850 it under the terms of the GNU General Public License as published by
9851 the Free Software Foundation, either version 3 of the License, or
9852 (at your option) any later version.
9853
9854 GNU Emacs is distributed in the hope that it will be useful,
9855 but WITHOUT ANY WARRANTY; without even the implied warranty of
9856 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9857 GNU General Public License for more details.
9858
9859 You should have received a copy of the GNU General Public License
9860 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.