byte-compile-setq-default fix for bug#12195
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f5d9e83a
PE
12012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 Use bool, not int, for Lisp booleans.
4 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
5 makes Emacs a bit smaller and presumably a bit faster.
6 * lisp.h: Include <stdbool.h>.
7 (struct Lisp_Boolfwd, defvar_bool):
8 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
9 * regex.c [!emacs]: Include <stdbool.h>.
10 (false, true): Remove; <stdbool.h> does this for us now.
11
55802e4a
CY
122012-08-14 Chong Yidong <cyd@gnu.org>
13
4abcdac8
CY
14 * character.c (Fcharacterp): Doc fix (Bug#12076).
15
16 * data.c (Findirect_variable): Doc fix (Bug#11040).
17
55802e4a
CY
18 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
19
20 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 21 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 22
8e99d072
BR
232012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
24
25 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
26 (bug#12022).
27
08908aca
MR
282012-08-14 Martin Rudalics <rudalics@gmx.at>
29
30 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
31 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
32 * minibuf.c (choose_minibuf_frame, read_minibuf):
33 * w32fns.c (x_create_tip_frame):
34 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
35 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
36
56120d6f
PE
372012-08-14 Paul Eggert <eggert@cs.ucla.edu>
38
39 * intervals.c (offset_intervals): Remove obsolete comment.
40
67b77c0b
AS
412012-08-14 Andreas Schwab <schwab@linux-m68k.org>
42
43 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
44
f48b82fd
GR
452012-08-14 Gergely Risko <gergely@risko.hu>
46
47 * coding.c (decode_coding): Record buffer modification before
48 disabling undo_list (Bug#11773).
49
fd318b54
DA
502012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
51
52 Revert and cleanup some recent overlay changes.
53 * buffer.h (enum overlay_type): Remove.
54 (buffer_get_overlays, buffer_set_overlays): Likewise.
55 (buffer_set_overlays_before, buffer_set_overlays_after):
56 New function. Adjust users.
57 (unchain_both): Add eassert.
58
41a62dd9
DA
592012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
60
61 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
62
5884c324
PE
632012-08-14 Paul Eggert <eggert@cs.ucla.edu>
64
65 * gtkutil.c (xg_mark_data): Don't assume C99.
66
ca06f160
JD
672012-08-13 Jan Djärv <jan.h.d@swipnet.se>
68
69 * gtkutil.c (xg_frame_tb_info): New struct.
70 (TB_INFO_KEY): New define.
71 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
72 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
73 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
74 if not present.
75 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
76 is up to date. Otherwise store new data.
77 (free_frame_tool_bar): Free xg_frame_tb_info if present.
78
7864a3f7
DA
792012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
80
81 Use KSET for write access to Lisp_Object members of struct kboard.
82 * keyboard.h (KSET): New macro.
83 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
84 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
85 * xterm.c: Adjust users.
86
4c31be61
DA
872012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
88
89 Use BSET for write access to Lisp_Object members of struct buffer.
90 * buffer.h (BSET): New macro.
91 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
92 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
93 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
94 * window.c, xdisp.c, xfns.c: Adjust users.
95
14ae4239
BT
962012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
97
98 * lread.c (syms_of_lread): Initialize Vlexical_binding.
99
32bcadb4
JD
1002012-08-11 Jan Djärv <jan.h.d@swipnet.se>
101
3d29b2ce
JD
102 * nsterm.m (not_in_argv): New function.
103 (application:openFile, application:openTempFile:):
104 (application:openFileWithoutUI:, application:openFiles:): Open file
105 if not_in_argv returns non-zero (bug#12171).
106
32bcadb4 107 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
108 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
109 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
110 (xg_get_font_name): Use those functions/macros here.
111 Reported by Frans Oilinki <moilinki@gmail.com>.
112
9ff9402d 1132012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
114
115 * unexmacosx.c (copy_data_segment): Copy initialized data in
116 statically linked libraries from input file rather than memory.
117
db74a5fc
YM
118 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
119 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
120 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
121
25e65510
GM
1222012-08-10 Glenn Morris <rgm@gnu.org>
123
124 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
125 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
126
7961135c
DA
1272012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
128
129 Fix last change to allow compilation with low optimization levels.
130 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
131 Reported by Jan Djärv <jan.h.d@swipnet.se>.
132
42b3a444
DA
1332012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
134
135 Use common inline syntax in intervals.h.
136 * intervals.h (INTERVALS_INLINE): New macro.
137 Change all users from LISP_INLINE.
138
9fb0c957
DA
1392012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
140
141 Define Qnone once for all platforms.
142 * frame.c (Qnone): Define here.
143 (syms_of_frame): DEFSYM it.
144 * lisp.h (Qnone): New declaration.
145 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
146 * xfns.c: Remove duplication. Adjust users.
147
65e8ee52
DA
1482012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
149
150 Remove unused macros from intervals.h.
151 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
152 * intervals.c: Adjust comment.
153
9b855fd6
EZ
1542012-08-10 Eli Zaretskii <eliz@gnu.org>
155
156 * w32fns.c <w32_unicode_gui>: New static variable.
157 (globals_of_w32fns): Initialize it according to os_subtype.
158 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
159 testing os_subtype.
160
39cb9e56 1612012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
162 Eli Zaretskii <eliz@gnu.org>
163
164 Fix bug #10299 with Unicode characters sent by customized
165 keyboards created by MSKLC.
166 * w32fns.c (INIT_WINDOW_CLASS): New macro.
167 (w32_init_class): Use it to initialize the Emacs class with either
168 ANSI or Unicode API calls.
169 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
170 later.
171 (w32_wnd_proc): If the character code sent by WM_CHAR or
172 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
173 original message. Call DefWindowProcW on NT and later.
174
9374581a
GM
1752012-08-10 Glenn Morris <rgm@gnu.org>
176
4b94e8cf
GM
177 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
178
9374581a
GM
179 * lisp.h (DIRECTORY_SEP): Let configure set it.
180
a2752828
DA
1812012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
182
183 Use TSET for write access to Lisp_Object slots of struct terminal.
184 * termhooks.h (TSET): New macro.
185 * coding.c, terminal.c, xselect.c: Adjust users.
186
cc92c454
SM
1872012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
190 the failing expression, include them in the error message.
191 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
192 * lisp.h (internal_condition_case_n): Update declaration.
193
4cb3e6b3
DA
1942012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
195
196 Inline functions to examine and change buffer overlays.
197 * buffer.c (unchain_both): New function.
198 * buffer.h (buffer_get_overlays, buffer_set_overlays):
199 (buffer_has_overlays): New function.
200 (enum overlay_type): New enum.
201 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
202 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
203
8707c1e5
DA
2042012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
205
206 Inline functions to examine and change buffer intervals.
207 * alloc.c (mark_interval_tree): Remove.
208 (MARK_INTERVAL_TREE): Simplify.
209 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
210 * intervals.c (buffer_balance_intervals): New function.
211 (graft_intervals_into_buffer): Adjust indentation.
212 (set_intervals_multibyte): Simplify.
213 * buffer.h (BUF_INTERVALS): Remove.
214 (buffer_get_intervals, buffer_set_intervals): New function.
215 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
216 * intervals.c, textprop.c: Adjust users.
217
ad8c997f
DA
2182012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
219
220 Inline functions to examine and change string intervals.
221 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
222 (string_get_intervals, string_set_intervals): New function.
223 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
224 * lread.c, print.c, textprop.c: Adjust users.
225
32ac3a6b
GM
2262012-08-08 Glenn Morris <rgm@gnu.org>
227
228 * lisp.mk (lisp): Remove language/persian.elc.
229
77c7bcb1
DA
2302012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
231
232 Cleanup intervals.
233 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
234 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
235 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
236 Adjust comment. Move under #if 0.
77c7bcb1
DA
237 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
238 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
239
9c08a8d4
DA
2402012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
241
242 Check total length of intervals with eassert.
243 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
244 * intervals.c: Change all users to eassert.
245
26d16b35
EZ
2462012-08-07 Eli Zaretskii <eliz@gnu.org>
247
14ae4239
BT
248 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
249 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
250 INTERNAL_FIELD in Lisp_Cons.
251
c644523b
DA
2522012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
253
254 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
255 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
256 name since all xname users are fixed long time ago. Do not
257 use INTERNAL_FIELD.
258 (set_symbol_name, set_symbol_function, set_symbol_plist):
259 (set_symbol_next, set_overlay_plist): New function.
260 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
261 (struct Lisp_Overlay): Likewise.
262 (CVAR, MVAR, SVAR): Remove.
263 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
264 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
265 * xterm.c: Adjust users.
266 * .gdbinit: Change to use name field of struct Lisp_Symbol
267 where appropriate.
268
6a3d20cc
DA
2692012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Basic functions to set Lisp_Object and pointer slots of intervals.
272 * intervals.h (interval_set_parent, interval_set_object):
273 (interval_set_left, interval_set_right, interval_set_plist):
274 (interval_copy_parent): New function.
275 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
276 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
277 Adjust indentation.
6a3d20cc
DA
278 (INTERVAL_SIZE): Remove. Adjust users.
279 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
280
4d2b044c
DA
2812012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
282
283 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
284 * process.h (PGET): Remove.
285 (struct Lisp_Process): Do not use INTERNAL_FIELD.
286 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
287
d3d50620
DA
2882012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
289
290 Drop WGET and revert read access to Lisp_Objects slots of struct window.
291 * window.h (WGET): Remove.
292 (struct window): Do not use INTERNAL_FIELD.
293 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
294 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
295 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
296 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
297 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
298 Adjust users.
299
d10a51dc
CY
3002012-08-07 Chong Yidong <cyd@gnu.org>
301
302 * window.c (Fwindow_edges, Fwindow_pixel_edges)
303 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
304 (Fdelete_window_internal): Signal an error if the window is not on
305 a live frame (Bug#12025).
306
e69b0960
DA
3072012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
308
309 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
310 * frame.h (FGET): Remove.
311 (struct frame): Do not use INTERNAL_FIELD.
312 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
313 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
314 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
315 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
316
25a20a3a
JB
3172012-08-06 Juanma Barranquero <lekktu@gmail.com>
318
319 * w32.c: Silence compiler warnings.
320 (map_w32_filename): Remove unused variable `is_fat'.
321 (chase_symlinks): Add parentheses around expression.
322
1c6f11f4
GM
3232012-08-06 Glenn Morris <rgm@gnu.org>
324
1db4583a
GM
325 * sysdep.c: Respect BROKEN_GETWD.
326
1c6f11f4
GM
327 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
328 Let configure handle it.
329 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
330
2b90362b
DA
3312012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
332
333 Use GCALIGNMENT where appropriate.
334 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
335 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
336 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
337
5f50daf2
EZ
3382012-08-06 Eli Zaretskii <eliz@gnu.org>
339
14ae4239
BT
340 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
341 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 342
cbcc7007
SM
3432012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
344
345 * buffer.h (struct buffer): Revert `indirections' to a simple int;
346 that should be sufficient for everyone.
347
4d365fa4
JD
3482012-08-06 Jan Djärv <jan.h.d@swipnet.se>
349
350 * keyboard.c (timer_check_2): Add break so timer_check returns next
351 timeout.
352
dd86bd82
DA
3532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
354
355 Fix Windows build errors introduced after converting to WGET and WSET.
356 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
357 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
358
054e1668
JD
3592012-08-06 Jan Djärv <jan.h.d@swipnet.se>
360
361 * nsterm.m (ns_frame_rehighlight): Use FSET.
362
363 * nsmenu.m (ns_update_menubar): Use FSET.
364
21238f11
DA
3652012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
366
367 Separate read and write access to Lisp_Object slots of Lisp_Process.
368 * process.h (PGET, PSET): New macros similar to AREF and ASET.
369 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
370
077288cf
DA
3712012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
372
373 Separate read and write access to Lisp_Object slots of struct window.
374 * window.h (WGET, WSET): New macros similar to AREF and ASET.
375 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
376 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
377 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
378 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
379 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
380 Adjust users.
381
71688bd7
DA
3822012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
383
384 Fix Windows build errors introduced after converting to FGET and FSET.
385 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
386 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
387 (w32_judge_scroll_bars): Change to use FSET.
388 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
389
f99bac93
DA
3902012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
391
392 Fix replacement typo.
393 * window.c (replace_window): Set root_window instead of
394 selected_window. This fixes a total window subsystem
395 malfunction reported by Bastien Guerry <bzg@gnu.org>.
396
8c2a0f2d
GM
3972012-08-06 Glenn Morris <rgm@gnu.org>
398
399 * lisp.mk (lisp): Add language/persian.elc.
400
edd74c35
DA
4012012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
402
403 Separate read and write access to Lisp_Object slots of struct frame.
404 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
405 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
406 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
407 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
408 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
409
8671676c
AS
4102012-08-05 Andreas Schwab <schwab@linux-m68k.org>
411
412 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
413
663e2b3f
DA
4142012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
415
416 Generalize common compile-time constants.
417 * lisp.h (header_size, bool_header_size, word_size): Now here.
418 (struct Lisp_Vector): Add comment.
419 (struct Lisp_Bool_Vector): Move up to define handy constants.
420 (VECSIZE, PSEUDOVECSIZE): Simplify.
421 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
422 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
423 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
424 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
425 * xfont.c, xmenu.c: Use word_size where appropriate.
426
d32e47af
LM
4272012-08-05 Lawrence Mitchell <wence@gmx.li>
428
429 * search.c (Freplace_match): Treat \? in the replacement text
430 literally (Bug#8161).
431
e5d9c0d1
CY
4322012-08-05 Chong Yidong <cyd@gnu.org>
433
434 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
435 * frame.c (Vdelete_frame_functions):
436 * emacs.c (Vkill_emacs_hook): Doc fix.
437
8da0576b
EZ
4382012-08-04 Eli Zaretskii <eliz@gnu.org>
439
440 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
441 --with-x-toolkit=no builds.
442 Reported by Carsten Mattner <carstenmattner@gmail.com>.
443
02676e5d
CY
4442012-08-04 Chong Yidong <cyd@gnu.org>
445
446 * syntax.c (Fmodify_syntax_entry): Doc fix.
447
97147da9
EZ
4482012-08-04 Eli Zaretskii <eliz@gnu.org>
449
76151e2c
EZ
450 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
451 * w32.c (init_environment): Change the default values of many
452 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
453 them into environment when they were not already defined.
454 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 455 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
456 (check_windows_init_file): Now external, not static.
457 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
458 called when Vload_path is already set up.
459
460 * w32.h (check_windows_init_file): Add prototype.
461
462 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
463 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
464 compatibility with Posix platforms.
465 (main): Move the call to check_windows_init_file to here from
466 w32.c.
467 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
468 any, in the DEFALT argument into the root of the Emacs build or
469 installation tree, as appropriate.
470
471 * callproc.c (init_callproc_1): Call decode_env_path instead of
472 doing its equivalent by hand.
473 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
474 the code that sets Vexec_path run on MS-Windows.
475
476 * lread.c (init_lread): Add comments to #ifdef's.
477
97147da9
EZ
478 * msdos.c (dos_set_window_size, IT_update_begin)
479 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
480 instead of direct references.
481
185ee146
PE
4822012-08-04 Paul Eggert <eggert@cs.ucla.edu>
483
484 Export DEFAULT_REHASH_* to GDB.
485 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
486 Now constants, not macros.
487
8834c57a
PE
4882012-08-03 Paul Eggert <eggert@cs.ucla.edu>
489
98c6f1e3
PE
490 Remove unnecessary casts involving pointers.
491 These casts are no longer needed now that we assume C89 or later,
492 since they involve casting to or from void *.
493 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
494 (make_pure_float, make_pure_vector):
495 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
496 * macros.c (Fstart_kbd_macro):
497 * menu.c (find_and_return_menu_selection):
498 * minibuf.c (read_minibuf_noninteractive):
499 * sysdep.c (closedir):
500 * xdisp.c (x_produce_glyphs):
501 * xfaces.c (compare_fonts_by_sort_order):
502 * xfns.c (x_real_positions, select_visual):
503 * xselect.c (x_stop_queuing_selection_requests)
504 (x_get_window_property, x_get_window_property_as_lisp_data):
505 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
506 Remove unnecessary pointer casts.
507 * alloc.c (record_xmalloc): New function.
508 * lisp.h (record_xmalloc): New decl.
509 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
510 more like a function. This is because the pointer cast is not
511 needed. All uses changed.
512 * print.c (print_string, print_error_message): Avoid length recalc.
513
8834c57a
PE
514 Improve fix for macroexp crash with debugging (Bug#12118).
515 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
516 ARRAY_MARK_FLAG when checking subscripts, because ASET is
517 not supposed to be invoked from the garbage collector.
518 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
519 (gc_aset): New function, which is like ASET but can be
520 used in the garbage collector.
521 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
522 (set_hash_index): Use it instead of ASET.
523
6dad7178
EZ
5242012-08-03 Eli Zaretskii <eliz@gnu.org>
525
526 Support symlinks on latest versions of MS-Windows.
527 * w32.c: Include winioctl.h and aclapi.h.
528 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
529 (revert_to_self): Forward declarations of static functions.
530 <static BOOL g_b_init_get_security_info>:
531 <g_b_init_create_symbolic_link>: New static flags.
532 (globals_of_w32): Initialize them to zero.
533 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
534 (map_w32_filename): Improve commentary. Simplify switch.
535 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
536 headers (most versions of MinGW w32api don't).
537 (get_security_info, create_symbolic_link)
538 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
539 New functions.
540 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
541 in the argument file name.
542 (sys_access): Call unc_volume_file_attributes only if
543 GetFileAttributes fails with network-related error codes.
544 (sys_rename): Diagnose renaming of a symlink when the user doesn't
545 have the required privileges.
14ae4239 546 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
547 get_file_security_desc.
548 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
549 with addition of handling of symlinks and support for 'lstat'.
550 If possible, get file's attributes and security information by
6dad7178
EZ
551 handle, not by name. Produce S_IFLNK bit for symlinks, when
552 called from 'lstat'.
553 (stat, lstat): New functions, call 'stat_worker'.
554 (symlink, readlink, careadlinkat): Rewritten to create and resolve
555 symlinks when the underlying filesystem supports them.
556
f162bcc3
PE
5572012-08-02 Paul Eggert <eggert@cs.ucla.edu>
558
79ea6c20
PE
559 Fix macroexp crash on Windows with debugging (Bug#12118).
560 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
561 checking subscripts; problem introduced with the recent
562 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
563 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
564 since it's used in non-static inline functions now.
565
c0ce93fd
PE
566 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
567 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 568
f162bcc3
PE
569 Use C99-style 'extern inline' if available.
570 * buffer.h (BUFFER_INLINE):
571 * category.h (CATEGORY_INLINE):
572 * character.h (CHARACTER_INLINE):
573 * charset.h (CHARSET_INLINE):
574 * composite.h (COMPOSITE_INLINE):
575 * dispextern.h (DISPEXTERN_INLINE):
576 * lisp.h (LISP_INLINE):
577 * systime.h (SYSTIME_INLINE):
578 New macro, replacing 'static inline' in this header.
579 * buffer.h, category.h, character.h, charset.h, composite.h:
580 * dispextern.h, lisp.h, systime.h:
581 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
582 * alloc.c (LISP_INLINE):
583 * buffer.c (BUFFER_INLINE):
584 * category.c (CATEGORY_INLINE):
585 * character.c (CHARACTER_INLINE):
586 * charset.c (CHARSET_INLINE):
587 * composite.c (COMPOSITE_INLINE):
588 * dispnew.c (DISPEXTERN_INLINE):
589 * sysdep.c (SYSTIME_INLINE):
590 Define to EXTERN_INLINE, so that the corresponding functions
591 are compiled into code.
592 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
593 (INLINE_HEADER_END): New macros.
594 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
595 since it's used in non-static inline functions now.
a8333d03 596 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 597
837b365b
GM
5982012-08-02 Glenn Morris <rgm@gnu.org>
599
d66b744d
GM
600 * s/: Remove empty directory.
601
837b365b
GM
602 * s/ms-w32.h: Move to ../nt/inc.
603 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
604 Update for new ms-w32.h location.
605
13294f95
PE
6062012-08-02 Paul Eggert <eggert@cs.ucla.edu>
607
608 Port to Solaris 8.
609 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
610
90df0db3
GM
6112012-08-02 Glenn Morris <rgm@gnu.org>
612
613 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
614 hard-coding the path separator.
615
4939150c
PE
6162012-08-01 Paul Eggert <eggert@cs.ucla.edu>
617
618 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
619 This how ASET and AREF are supposed to work, and makes
620 it easier to think about future improvements. See
621 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
622 * charset.h (set_charset_attr): New function.
623 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
624 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
625 (aref_addr): New function. All uses of &AREF(...) changed.
626 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
627 (set_hash_index): New functions. All lvalue-style uses of
628 HASH_KEY etc. changed.
629 * keyboard.c (set_prop): New function. All lvalue-style uses
630 of PROP changed.
631
947b2afd
AA
6322012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
633
634 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
635 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
636 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
637 * nsfns.m (ns_set_name_as_filename): Likewise.
638 * nsmenu.m (ns_update_menubar): Likewise.
639 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
640
4f5d0325
EZ
6412012-08-01 Eli Zaretskii <eliz@gnu.org>
642
2008beae
EZ
643 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
644 Adapt to latest changes in field names of the corresponding Lisp
288479f6 645 objects.
2008beae 646
4f5d0325
EZ
647 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
648
fe3cc771
GM
6492012-08-01 Glenn Morris <rgm@gnu.org>
650
651 * s/msdos.h: Remove file.
652 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
653 * Makefile.in (S_FILE): Remove.
654 (config_h): Remove S_FILE.
655
c90acc54
JB
6562012-08-01 Juanma Barranquero <lekktu@gmail.com>
657
658 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
659 Remove; moved to nt/config.nt.
660
d8a05828
DA
6612012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
662
663 Use INTERNAL_FIELD for conses and overlays.
664 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
665 Remove obsolete comment.
666 (MVAR): New macro.
667 (struct Lisp_Overlay): Use INTERNAL_FIELD.
668 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
669
8271d590
DA
6702012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
671
672 Use INTERNAL_FIELD for symbols.
673 * lisp.h (SVAR): New macro. Adjust users.
674 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
675 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
676
3193acd2
DA
6772012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Use INTERNAL_FIELD for processes.
680 * process.h (PVAR): New macro. Adjust style.
681 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
682 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
683
3a45383a
DA
6842012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Use INTERNAL_FIELD for windows.
687 * window.h (WVAR): New macro.
688 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
689 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
690 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
691 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
692 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
693 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
694
c1dbc63c
PE
6952012-08-01 Paul Eggert <eggert@cs.ucla.edu>
696
697 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
698
5c0c0e8a
GM
6992012-08-01 Glenn Morris <rgm@gnu.org>
700
701 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
702 Move to configure.ac.
703
552a99b4
JB
7042012-08-01 Juanma Barranquero <lekktu@gmail.com>
705
706 * makefile.w32-in (CONFIG_H): Update dependencies.
707 (CONF_POST_H): New macro.
708
709 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
710
8d8e2dfe
GM
7112012-07-31 Glenn Morris <rgm@gnu.org>
712
bc96620a
GM
713 * Makefile.in (S_FILE): No longer set by configure.
714
476b1b2d
GM
715 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
716 is available.
717 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
718
b2c7a106
GM
719 * process.h (NULL_DEVICE):
720 * emacs.c (SEPCHAR):
721 * editfns.c (USER_FULL_NAME): Let configure set them.
722
d53d062a
GM
723 * s/README, s/template.h: Remove files.
724
4515017f
GM
725 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
726
8d8e2dfe
GM
727 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
728 Move to configure.ac.
729
5b20b3cc
EZ
7302012-07-31 Eli Zaretskii <eliz@gnu.org>
731
1e0afd9a
EZ
732 * .gdbinit (xframe): Adapt to introduction of FVAR and the
733 resulting renaming of 'struct frame' members.
734
5b20b3cc
EZ
735 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
736
737 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
738 after introduction of FVAR.
739
f1310128
JD
7402012-07-31 Jan Djärv <jan.h.d@swipnet.se>
741
79e721e0
JD
742 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
743
744 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
745 instead of compositeToPoint.
746 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
747
8d7c7eed 748 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 749
e34f7f79
DA
7502012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
751
752 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
753 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 754 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
755 (BVAR): Change to use INTERNAL_FIELD.
756 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
757 (KVAR): Change to use INTERNAL_FIELD.
758 * frame.h (FVAR): New macro.
759 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
760 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
761 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
762 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
763 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
764
c09bfb2f
DA
7652012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
766
767 Miscellaneous fixes for non-default X toolkits.
768 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
769 * xterm.c (x_frame_of_widget): Remove redundant prototype.
770 Move under #ifdef USE_LUCID.
771 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
772 definition and usage to avoid warnings.
773
14c114ae
JD
7742012-07-31 Jan Djärv <jan.h.d@swipnet.se>
775
776 * nsterm.m (openFiles): Fix previous checkin.
777
3bd21e82
PE
7782012-07-31 Paul Eggert <eggert@cs.ucla.edu>
779
780 * indent.c (compute_motion): Remove unused local.
781
c1529ded
GM
7822012-07-31 Glenn Morris <rgm@gnu.org>
783
400d5621
GM
784 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
785
268e2432
GM
786 * conf_post.h [USG5_4]:
787 Move remaining contents of s/usg5-4-common.h here.
788 * s/usg5-4-common.h: Remove file.
789
7552f3ee
GM
790 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
791 * s/irix6-5.h: Remove file.
792
6a381852
GM
793 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
794 * s/darwin.h: Remove file.
795
c1529ded
GM
796 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
797 * s/hpux10-20.h: Remove file, which is now empty.
798
b429a4ee
GM
7992012-07-30 Glenn Morris <rgm@gnu.org>
800
801 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
802 * Makefile.in (config_h): Add conf_post.h.
803 * makefile.w32-in (CONFIG_H): Add conf_post.h.
804
adff3182
JD
8052012-07-30 Jan Djärv <jan.h.d@swipnet.se>
806
807 * nsterm.m (ns_do_open_file): New variable.
b9031d69 808 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
809 (openFile, openTempFile, openFileWithoutUI, openFiles):
810 Open files only if ns_do_open_file.
adff3182 811
c32af1e4
PE
8122012-07-30 Paul Eggert <eggert@cs.ucla.edu>
813
7393bcbb
PE
814 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
815 This no-op macro hasn't been needed for many years.
816 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
817
c32af1e4
PE
818 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
819 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
820 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
821 gdb_make_enums_visible.
822 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
823 (DIRECTORY_SEP): Now a constant, not a macro.
824
302fc036
EZ
8252012-07-30 Eli Zaretskii <eliz@gnu.org>
826
827 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
828 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
829
830 * w32term.c <w32_keyboard_codepage>: Renamed from
831 keyboard_codepage and now external. All users changed.
832
833 * w32term.h: Add declaration of w32_keyboard_codepage.
834
835 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
836 the codepage to translate keys to Unicode. If this argument is
837 -1, use the value returned by GetConsoleCP. All callers changed.
838
88fb40b4
PE
8392012-07-30 Paul Eggert <eggert@cs.ucla.edu>
840
0aee6912
PE
841 Update .PHONY listings in makefiles.
842 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
843 bootstrap-clean, distclean, maintainer-clean, versioclean,
844 extraclean, frc.
845
88fb40b4
PE
846 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
847 This is a bit clearer. Fix some commentary typos.
848
0a763bd1
GM
8492012-07-30 Glenn Morris <rgm@gnu.org>
850
32bac6d6
GM
851 * s/netbsd.h: Let configure include signal.h if needed.
852 Remove file, which is now empty.
853
b65e7c46
GM
854 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
855 Let configure set them.
856 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
857 No more need to undefine.
0a763bd1 858
169304bd
AS
8592012-07-30 Andreas Schwab <schwab@linux-m68k.org>
860
861 * keymap.c (Fkey_description): Don't remove 0x80 bit from
862 non-single-byte char when adding meta modifier. (Bug#12090)
863
6cd7a139
DA
8642012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
865
866 Convert safe_call to use variable number of arguments.
867 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
868 (safe_call2): Fix comment.
869 * lisp.h (safe_call): Adjust prototype.
870 * coding.c (encode_coding_object): Change to use safe_call2.
871 * xfaces.c (merge_face_heights): Change to use safe_call1.
872
d34d6ffc
GM
8732012-07-30 Glenn Morris <rgm@gnu.org>
874
7b8a48e4 875 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 876 does that unconditionally. Remove file, which is now empty.
7b8a48e4 877
d34d6ffc
GM
878 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
879 Remove empty files.
880
03a660a6
PE
8812012-07-30 Paul Eggert <eggert@cs.ucla.edu>
882
883 Export to GDB most of lisp.h's remaining object-like macros.
884 * lisp.h (min, max): Move earlier, because they're used earlier now.
885 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
886 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
887 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
888 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
889 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
890 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
891 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
892 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
893 Now constants, for GDB. They need not be macros.
894 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
895 Now constants, for GDB, as well as macros, for static initializers.
896 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
897 Move to after the definition of struct Lisp_Char_Table,
898 since the former now needs that type defined.
899 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
900 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
901 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
902 New enums, for gdb_make_enums_visible.
903 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 904 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
905 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
906 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
907 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
908 enum maxargs, enum MAX_ALLOCA.
909 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
910 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
911 no longer needed, now that they are done in lisp.h.
912
e499d0ee
DA
9132012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
914
915 Cleanup string bytes checking.
916 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
917 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
918 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
919 (check_sblock, compact_small_strings): Simplify.
920
d5040d2d
PE
9212012-07-29 Paul Eggert <eggert@cs.ucla.edu>
922
923 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
924 These macros are confusing and no longer need to be defined, as
925 the enum values now suffice. All uses replaced with definiens.
926 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
927
7f259ae6
JB
9282012-07-29 Juanma Barranquero <lekktu@gmail.com>
929
930 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
931 ($(BLD)/w32console.$(O)): Update dependencies.
932
7e63e0c3
DA
9332012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
934
935 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
936 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
937 time. Adjust users.
938 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
939
ffd817eb
JD
9402012-07-29 Jan Djärv <jan.h.d@swipnet.se>
941
942 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
943 setting sitelisp (Bug#12010).
944
417a7a0e
EZ
9452012-07-29 Eli Zaretskii <eliz@gnu.org>
946
14ae4239 947 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
948
949 * w32heap.c (cache_system_info):
950 * w32.c (sys_rename):
951 * w32proc.c (find_child_console, sys_kill): All users changed.
952
387d4d92
PE
9532012-07-29 Paul Eggert <eggert@cs.ucla.edu>
954
955 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
956
55a6cca6
EZ
9572012-07-29 Eli Zaretskii <eliz@gnu.org>
958
959 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
960
dbcf001c
DA
9612012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
962
963 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
964 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
965 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 966
e2688e4a
DA
9672012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
968
969 Generalize marker debugging code under MARKER_DEBUG and use eassert.
970 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
971 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
972 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
973 (replace_range, replace_range_2, del_range_2): Change to eassert.
974 * marker.c (byte_char_debug_check): Adjust style.
975
b46a6a83
PE
9762012-07-29 Paul Eggert <eggert@cs.ucla.edu>
977
978 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
979 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
980 long-ago-commented-out code that talks about "WIN32".
981 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
982 All uses changed.
983
e32a5799
PE
9842012-07-28 Paul Eggert <eggert@cs.ucla.edu>
985
986 Use Gnulib stdalign module (Bug#9772, Bug#9960).
987 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
988 Simplify by using alignof.
989 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
990 * lisp.h: Include <stdalign.h>.
991 (GCALIGNMENT): New macro and constant.
992 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
993 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
994 (stdalign): New macro, if not already defined.
995
df81cd29
EZ
9962012-07-28 Eli Zaretskii <eliz@gnu.org>
997
01bd1b0d
EZ
998 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
999 * w32inevt.c: Include w32inevt.h.
1000 (w32_read_console_input): New inline function, calls either
1001 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1002 w32_console_unicode_input.
1003 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1004 (w32_kbd_patch_key, key_event): Use the codepage returned by
1005 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1006 (key_event): use uChar.UnicodeChar only if
1007 w32_console_unicode_input is non-zero.
1008
1009 * w32console.c: Include w32heap.h.
1010 <w32_console_unicode_input>: New global variable.
1011 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1012 family of Windows, zero otherwise.
1013
1014 * w32inevt.h: Declare w32_console_unicode_input.
1015
df81cd29
EZ
1016 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1017 --without-x. (Bug#11742)
1018
c20fdd9e
PE
10192012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 Adjust GDB to reflect pvec_type changes (Bug#12036).
1022 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1023 2012-07-04 changes to pseudovector representation.
1024 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1025
32770973 10262012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1027
1028 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1029 bus address.
1030 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1031
3438fe21
EZ
10322012-07-27 Eli Zaretskii <eliz@gnu.org>
1033
bcfbc9de
EZ
1034 * alloc.c (listn): Fix the order the arguments are consed onto the
1035 list.
1036
3438fe21
EZ
1037 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1038 enumeration constants, as PURE and HEAP are too general, and clash
1039 with other headers and sources, such as gmalloc.c and the
1040 MS-Windows system headers. All users changed.
1041
eeaea515
DA
10422012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1043
1044 Revert last save_excursion_save and save_excursion_restore changes.
1045 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1046 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1047
073c88c2
DA
10482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1049
1050 Fix recently-introduced typos in Windows port.
1051 Reported by Martin Rudalics <rudalics@gmx.at>.
1052 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1053 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1054
4706125e
PE
10552012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1056
1057 Improve GDB symbol export (Bug#12036).
1058 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1059 arms of an 'if', not using conditional expressions; otherwise GDB
1060 complains about the types in the unevaluated arm when the argument
1061 is an integer literal.
1062 (xgetint): Simplify expression.
1063 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1064 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1065 Zaretskii in <http://bugs.gnu.org/12036#13>.
1066 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1067 needed now that we have gdb_make_enums_visible.
1068 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1069 (enum enum_USE_LSB_TAG):
1070 New enum types, packaging up enums that need to be exported to GDB.
1071
694b6c97
DA
10722012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1073
1074 Utility function to make a list from specified amount of objects.
1075 * lisp.h (enum constype): New datatype.
1076 (listn): New prototype.
1077 * alloc.c (listn): New function.
1078 (Fmemory_use_count, syms_of_alloc): Use it.
1079 * buffer.c (syms_of_buffer): Likewise.
1080 * callint.c (syms_of_callint): Likewise.
1081 * charset.c (define_charset_internal): Likewise.
1082 * coding.c (syms_of_coding): Likewise.
1083 * keymap.c (syms_of_keymap): Likewise.
1084 * search.c (syms_of_search): Likewise.
1085 * syntax.c (syms_of_syntax): Likewise.
1086 * w32.c (init_environment): Likewise.
1087 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1088 * xdisp.c (syms_of_xdisp): Likewise.
1089 * xfns.c (syms_of_xfns): Likewise.
1090
6195f384
DA
10912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1092
1093 Fast save_excursion_save and save_excursion_restore.
1094 * lisp.h (struct Lisp_Excursion): New data type.
1095 (PVEC_EXCURSION): New pseudovector type.
1096 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1097 to deal with it. Adjust comments.
1098 (init_marker, attach_marker): New prototype.
1099 (unchain_marker): Adjust prototype.
1100 * marker.c (attach_marker): Change to global.
1101 (init_marker): New function.
1102 * alloc.c (Fmake_marker, build_marker): Use it.
1103 (build_marker): More easserts.
1104 (mark_object): Handle struct Lisp_Excursion.
1105 * editfns.c (save_excursion_save, save_excursion_restore):
1106 Reimplement to use struct Lisp_Excursion. Add comments.
1107
5eceb8fb
PE
11082012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 Fix export of symbols to GDB (Bug#12036).
1111 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1112 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1113 emacs.c, as this is a more-suitable home. Had this been done earlier
1114 the fix for 12036 would have avoided some of the problems noted in
1115 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1116 would have been more obvious.
562157c8
PE
1117 * emacs.c: Do not include <verify.h>; no longer needed.
1118 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1119 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1120 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1121 Remove; now done in lisp.h.
1122 * lisp.h (PUBLISH_TO_GDB): New macro.
1123 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1124 (DATA_SEG_BITS): Use it.
1125 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1126 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1127 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1128 not be usable in #if. This simplifies things.
1129
d6749401
JB
11302012-07-26 Juanma Barranquero <lekktu@gmail.com>
1131
1132 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1133
1781b9e9
PE
11342012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1135
d89518db 1136 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1137 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1138 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1139 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1140 Adjust to changes in lisp.h and emacs.c, by using
1141 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1142 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1143 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1144 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1145 instead of gdb_valbits.
1146 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1147 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1148 instead of gdb_array_mark_flag.
1149 (xboolvector): Get size from $->size, not $->header.size.
1150 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1151 (xreload, hook-run, hookpost-run): Remove.
1152 * emacs.c: Include <verify.h>.
1153 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1154 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1155 Remove.
1156 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1157 (gdb_USE_LSB_TAG): New enum constants.
1158 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1159 Also define these as enum constants, so they're visible to GDB.
1160 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1161 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1162 as constants, so they're visible to GDB.
1163 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1164 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1165 Now enum constants, not macros, so they're visible to GDB.
1166 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1167 more convenient now. All uses changed.
1168 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1169 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1170
3628596a
DA
11712012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1172
1173 Explicitly free restriction data that are not needed anymore.
1174 * editfns.c (save_restriction_restore): Free restriction data.
1175
7abaf5cc
SM
11762012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1177
1178 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1179 add argument, tune behavior, and adjust all callers.
1180
71f88e00
PE
11812012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1182
1183 Use typedef for EMACS_INT, EMACS_UINT.
1184 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1185 than macros. This simplifies debugging in the usual case, since
1186 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1187 and it allows expressions involving EMACS_INT casts.
1188 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1189
57ec3034
JD
11902012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * nsterm.m (ns_read_socket): Return early if there is a modal
1193 window (Bug#12043).
1194
8137e7b3
MR
11952012-07-25 Martin Rudalics <rudalics@gmx.at>
1196
1197 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1198 that FOCUS-FRAME can be omitted.
1199
04e9897c
DA
12002012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1201
1202 Adjust buffer text indirection counters at the end of Fkill_buffer.
1203 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1204 buffer is definitely dead. This should really fix an issue reported
1205 by Christoph Scholtes again. (Bug#12007).
1206 (init_buffer_once): Initialize indirection counters of
1207 buffer_defaults and buffer_local_symbols (for sanity and safety).
1208
8a0484e1
EZ
12092012-07-24 Eli Zaretskii <eliz@gnu.org>
1210
1211 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1212 and continuation glyphs on tooltip frames, leave them at zero.
1213 Avoids continued lines in tooltips. (Bug#11832)
1214
fa691a83
DA
12152012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1216
1217 Simplify copy_overlay.
04e9897c 1218 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1219 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1220
436bc8e0
EZ
12212012-07-23 Eli Zaretskii <eliz@gnu.org>
1222
1223 * print.c (print_object): Don't crash when a frame's name is nil
1224 or invalid. (Bug#12025)
1225
1226 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1227 it signals an error when a tooltip frame is being created.
1228
d7a7fda3
DA
12292012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1230
1231 Cleanup miscellaneous objects allocation and initialization.
1232 * alloc.c (allocate_misc): Change to static. Add argument to
1233 specify the subtype. Adjust comment and users.
1234 (build_overlay): New function.
1235 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1236 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1237 (allocate_misc): Remove prototype.
1238 (build_overlay): Add prototype.
1239
12402012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1241
1242 Swap buffer text indirection counters in Fbuffer_swap_text.
1243 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1244 This avoids crash reported by Christoph Scholtes at
1245 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1246
9d7fa573
JD
12472012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1248
1249 * nsmenu.m (Popdown_data): New struct.
1250 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1251 free Popdown_data.
1252 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1253 (initWithContentRect): Make imgView and contentView non-static
1254 and autorelease them. Also autorelease img and matrix (Bug#12005).
1255 (dealloc): Remove (Bug#12005).
1256
0dd6d66d
DA
12572012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1258
1259 Adjust consing_since_gc when objects are explicitly freed.
1260 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1261 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1262 (free_cons, free_misc): Subtract object size from consing_since_gc.
1263
d36d71df
DA
12642012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1265
1266 Simplify and cleanup markers positioning code.
1267 * marker.c (attach_marker): More useful eassert.
1268 (live_buffer, set_marker_internal): New function.
1269 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1270 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1271
fb9ea40f
PE
12722012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1275 as it's limited by the amount of memory, not by INT_MAX.
1276
2d5c5f7d
EZ
12772012-07-21 Eli Zaretskii <eliz@gnu.org>
1278
07fb592e
EZ
1279 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1280 in special-event-map. See the discussion at
1281 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1282 for the reasons.
1283
37a9eac8 1284 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1285 info.dwItemData. Fixes crashes on 64-bit Windows.
1286 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1287
c4328746
JD
12882012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1289
1290 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1291 (conversationIdentifier): Return value is NSInteger.
784051c4 1292 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1293
6e5d1c12
CY
12942012-07-21 Chong Yidong <cyd@gnu.org>
1295
1296 * window.c (decode_any_window): Signal an error if the window is
1297 on a dead frame (Bug#11984).
1298
9928463d
DA
12992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 Add indirection counting to speed up Fkill_buffer.
1302 * buffer.h (struct buffer): New member.
1303 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1304 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1305 base buffer indirection counter.
1306 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1307 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1308 through buffer list if indirection counter is 0.
1309
f8643a6b
DA
13102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Extend the value returned by Fgarbage_collect with heap statistics.
1313 * alloc.c (Qheap): New symbol.
1314 (syms_of_alloc): DEFSYM it.
1315 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1316 (Fmemory_free): Remove.
1317 (syms_of_alloc): Don't defsubr it.
1318 * buffer.c (Fcompact_buffer): Remove.
1319 (syms_of_buffer): Don't defsubr it.
1320
dac616ff
DA
13212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1322
1323 Make maybe_gc inline.
1324 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1325 * lisp.h (consing_since_gc, gc_relative_threshold)
1326 (memory_full_cons_threshold): Revert declaration.
1327 (maybe_gc): Remove prototype, define as inline.
1328 * alloc.c: Remove old commented-out code.
1329 (consing_since_gc, gc_relative_threshold)
1330 (memory_full_cons_threshold): Revert to global.
1331 (maybe_gc): Remove.
1332
d7ea76b4
DA
13332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1334
1335 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1336 * lisp.h (build_unibyte_string): New function.
1337 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1338 * sysdep.c, w32fns.c, xfns.c: Use it.
1339 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1340 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1341 Adjust users accordingly.
1342 * font.h (font_open_by_name): Adjust prototype.
1343
765e61e3
DA
13442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1345
1346 Cleanup calls to Fgarbage_collect.
1347 * lisp.h (maybe_gc): New prototype.
1348 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1349 Remove declarations.
1350 * alloc.c (maybe_gc): New function.
1351 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1352 Make them static.
1353 * bytecode.c (MAYBE_GC): Use maybe_gc.
1354 * eval.c (eval_sub, Ffuncall): Likewise.
1355 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1356 to avoid dependency from auto-save feature.
1357
52b852c7
PE
13582012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1361 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1362 'for_each_per_buffer_object_at'.
1363 All uses changed. It's better to use upper-case for macros that
1364 cannot be implemented as functions, to give the reader a clue
1365 that they're special.
1366
5db81e33
SM
13672012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1368
1369 * alloc.c (Fgarbage_collect): Tweak docstring.
1370
5b835e1d
DA
13712012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1372
1373 Tweak the value returned from Fgarbage_collect again.
1374 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1375 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1376 Adjust documentation.
1377 (total_vector_bytes): Rename to total_vector_slots, adjust
1378 accounting.
1379 (total_free_vector_bytes): Rename to total_free_vector_slots,
1380 adjust accounting.
1381 (Qstring_bytes, Qvector_slots): New symbols.
1382 (syms_of_alloc): DEFSYM them.
1383
9cd47b72
DA
13842012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1385
1386 Buffer compaction primitive which may be used from Lisp.
1387 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1388 (syms_of_buffer): Register Fcompact_buffer.
1389 * alloc.c (Fgarbage_collect): Use compact_buffer.
1390 * buffer.h (compact_buffer): New prototype.
1391 (struct buffer_text): New member.
1392
d17337e5
DA
13932012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1394
1395 New macro to iterate over all buffers, miscellaneous cleanups.
1396 * lisp.h (all_buffers): Remove declaration.
1397 * buffer.h (all_buffers): Add declaration, with comment.
1398 (for_each_buffer): New macro.
1399 * alloc.c (Fgarbage_collect, mark_object): Use it.
1400 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1401 (init_buffer): Likewise.
1402 * data.c (Fset_default): Likewise.
1403 * coding.c (code_conversion_restore): Remove redundant check
1404 for dead buffer.
1405 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1406
60cfd278
AS
14072012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1408
1409 Fix bug that created negative-length intervals.
1410 * intervals.c (merge_interval_right, merge_interval_left):
1411 Do not zero out this interval if it is absorbed by its children,
1412 as this interval's total length doesn't change in that case. See
1413 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1414
d06714cb
PE
14152012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1416
83713154
PE
1417 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1418 when invoking (make-bool-vector N t) and N is a positive
1419 multiple of 8 -- the last 8 bits were mistakenly cleared.
1420
d06714cb
PE
1421 Remove some struct layout assumptions in bool vectors.
1422 * alloc.c (bool_header_size): New constant.
1423 (header_size, word_size): Move earlier, as they're now used earlier.
1424 Use 'word_size' in a few more places, where it's appropriate.
1425 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1426 padding before the data member of a bool vector.
1427 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1428 than doing the check by hand with an abort ().
1429
464d5a5e
SM
14302012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1431
5fbc0409
SM
1432 * eval.c (Fdefvar): Don't check constants since we only set the var if
1433 it's not yet defined anyway (bug#11904).
1434
464d5a5e
SM
1435 * lisp.h (last_undo_boundary): Declare new var.
1436 * keyboard.c (command_loop_1): Set it.
1437 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1438 were auto-added by the command loop (bug#11774).
1439
8dc2e44a
AS
14402012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1441
1442 * w32font.c (Qsymbol): Remove local definition.
1443 (syms_of_w32font): Don't DEFSYM it.
1444
169925ec
DA
14452012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1446
1447 Fix sweep_vectors to handle large bool vectors correctly.
1448 * alloc.c (sweep_vectors): Account total_vector_bytes for
1449 bool vectors larger than VBLOCK_BYTES_MAX.
1450
5fbfb018
CY
14512012-07-18 Chong Yidong <cyd@gnu.org>
1452
1453 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1454 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1455
3ab6e069
DA
14562012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1457
1458 Return more descriptive data from Fgarbage_collect.
1459 Suggested by Stefan Monnier in
1460 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1461 * alloc.c (bounded_number): New function.
1462 (total_buffers, total_vectors): New variable.
1463 (total_string_size): Rename to total_string_bytes, adjust users.
1464 (total_vector_size): Rename to total_vector_bytes, adjust users.
1465 (sweep_vectors): Account total_vectors and total_vector_bytes.
1466 (Fgarbage_collect): New return value. Adjust documentation.
1467 (gc_sweep): Account total_buffers.
1468 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1469 (VECTOR_SIZE): Remove.
1470 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1471 (Qinterval, Qmisc): New symbols.
1472 (syms_of_data): Initialize them.
1473 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1474 (Qcons, Qbuffer): New declarations.
1475
6d02fe5b
PE
14762012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1477
1478 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1479 Round up, not down. Improve doc.
1480
b7ffe040
DA
14812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 Restore old code in allocate_string_data to avoid Faset breakage.
1484 Reported by Julien Danjou <julien@danjou.info> in
1485 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1486 * alloc.c (allocate_string_data): Restore old code with minor
1487 adjustments, fix comment to explain this subtle issue.
1488
4dc7c8d5
SM
14892012-07-17 Eli Zaretskii <eliz@gnu.org>
1490
1491 Remove FILE_SYSTEM_CASE.
1492 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1493
1494 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1495 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1496 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1497 call-process-region passes it through expand-file-name.
1498
1499 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1500
15012012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1502
1503 Fix crash when creating indirect buffer (Bug#11917)
1504 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1505 Don't handle unbound variables specially if non-zero.
1506 (Fbuffer_local_variables): Pass zero.
1507 (clone_per_buffer_values): Pass non-zero.
1508
15092012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1510
1511 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1512 to make the loop interruptible.
1513
15142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1515
1516 * gnutls.c (emacs_gnutls_handshake): Only retry if
1517 GNUTLS_E_INTERRUPTED.
1518
cce7fefc
DA
15192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1520
1521 Cleanup and convert miscellaneous checks to eassert.
1522 * alloc.c (mark_interval): Fix comment, partially rephrase
1523 old comment from intervals.h (see below).
1524 * intervals.c (find_interval, adjust_intervals_for_insertion)
1525 (delete_interval, adjust_intervals_for_deletion)
1526 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1527 Convert to eassert.
1528 (adjust_intervals_for_insertion, make_new_interval):
1529 Remove obsolete and unused code.
1530 * intervals.h (struct interval): Remove obsolete comment.
1531 * textprotp.c (erase_properties): Remove unused code.
1532 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1533 (Fremove_list_of_text_properties): Convert to eassert.
1534
9ea10cc3
CY
15352012-07-17 Chong Yidong <cyd@gnu.org>
1536
1537 * editfns.c (Finsert_char): Doc fix.
1538
3900d5de
DA
15392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1540
1541 Fix previous change to make Fmemory_free always accurate.
1542 * alloc.c (make_interval): Update total_free_intervals.
1543 (make_float): Likewise for total_free_floats.
1544 (free_cons, Fcons): Likewise for total_free_conses.
1545 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1546 Likewise for total_free_vector_bytes.
1547 (Fmake_symbol): Likewise for total_free_symbols.
1548 (bytes_free): Remove.
1549
7098646f
DA
15502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 Simple free memory accounting feature.
1553 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1554 (sweep_vectors): Accumulate size of free vectors.
1555 (Fgarbage_collect): Setup bytes_free.
1556 (Fmemory_free): New function.
1557 (syms_of_alloc): Register it.
1558
22657b40
DA
15592012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1560
1561 Cleanup overlays checking.
1562 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1563 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1564 eassert and OVERLAYP.
1565 (sort_overlays): Change to use OVERLAYP.
1566
ddfc8813
RK
15672012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1568
1569 * editfns.c (Finsert_char): Make it interactive, and make the
1570 second arg optional. Copy interactive spec and docstring from
1571 ucs-insert.
1572
7c26cf3c
PE
15732012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1576 Unlike the other wrapped functions, fabs has an unspecified
1577 effect on errno.
1578
5d127af9
JD
15792012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1580
1581 * nsterm.m (keyDown): Interpret flags without left/right bits
1582 as the left key (Bug#11670).
1583
6a0dd1d7
DA
15842012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1585
1586 Remove empty and useless init functions.
1587 * lisp.h (init_character_once, init_fns, init_image)
1588 (init_filelock, init_sound): Remove prototype.
1589 * character.c (init_character_once): Remove.
1590 * filelock.c (init_filelock): Likewise.
1591 * fns.c (init_fns): Likewise.
1592 * image.c (init_image): Likewise.
1593 * sound.c (init_sound): Likewise.
1594 * emacs.c (main): Adjust accordingly.
1595
7a6136fd
DA
15962012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1597
1598 * gtkutil.h: Tiny cleanups.
1599 (use_old_gtk_file_dialog): Remove useless declaration.
1600 (xg_uses_old_file_dialog): Add suggested const attribute.
1601
ce811ad9
EZ
16022012-07-15 Eli Zaretskii <eliz@gnu.org>
1603
1604 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1605 (bidi_paragraph_init): Use it to limit search forward for a strong
1606 directional character in abnormally large paragraphs full of
1607 neutral or weak characters. (Bug#11943)
1608
c9adfeaa
SF
16092012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1610
1611 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1612 the toolbar (Bug#9451).
1613 (xg_make_tool_item): Give the widget event box a transparent
1614 background.
1615
fff62aa9
DA
16162012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1617
1618 Cleanup basic allocation variables and functions.
1619 * alloc.c (ignore_warnings, init_intervals, init_float)
1620 (init_cons, init_symbol, init_marker): Remove.
1621 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1622 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1623 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1624 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1625 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1626 (staticidx, init_alloc_once, init_strings, free_ablock):
1627 Remove redundant initialization.
1628 * fns.c (init_weak_hash_tables): Remove.
1629 * lisp.h (init_weak_hash_tables): Remove prototype.
1630
9730daca
DA
16312012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1632
1633 Use zero_vector where appropriate.
1634 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1635 accordingly.
1636 * lisp.h (zero_vector): New declaration.
1637 * font.c (null_vector): Remove.
1638 (syms_of_font): Remove initialization and staticpro.
1639 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1640 * keymap.c (Faccessible_keymaps): Likewise.
1641
2e2d2a13
LL
16422012-07-15 Leo Liu <sdl.web@gmail.com>
1643
1644 * fringe.c: Fix typo in comments.
1645
cd276f6e
LL
16462012-07-14 Leo Liu <sdl.web@gmail.com>
1647
1648 * fringe.c: Add a new bitmap exclamation-mark.
1649
5a1131d9
EZ
16502012-07-14 Eli Zaretskii <eliz@gnu.org>
1651
1652 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1653
1654 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1655 (HAVE_MENUS): Don't define, defined by editing config.in with
1656 msdos/sed2v2.inp.
1657 (GMALLOC_INHIBIT_VALLOC): Don't define.
1658 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1659
22e983b7
JB
16602012-07-14 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1663
5b3f250f
GM
16642012-07-14 Glenn Morris <rgm@gnu.org>
1665
1666 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1667 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1668 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1669
33d63ff4
GM
16702012-07-13 Glenn Morris <rgm@gnu.org>
1671
5b633342
GM
1672 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1673
33d63ff4
GM
1674 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1675 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1676
b55b9f85
JD
16772012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1678
0dc8cf50
JD
1679 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1680 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1681 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1682 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1683 where appropriate.
1684 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1685 as boolean expression.
1686 (x_set_window_size): Remove unused variable toolbar.
1687 (ns_get_color_default, ns_mod_to_lisp): Remove.
1688 (ns_mouse_position): Remove unused variables xchar and ychar.
1689 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1690 (ns_set_vertical_scroll_bar): Remove unused variable count.
1691 (ns_delete_terminal): Remove unused variable i.
1692 (ns_term_init): Remove unused variables r, g and b.
1693 (mouseDown): Remove unused variable window.
1694 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1695 (initFrameFromEmacs): Remove unused variable vbextra.
1696 (mouseEntered): Remove unused variables p and dpyinfo.
1697 (mouseExited): Remove unused variables p and r.
1698 (ns_define_frame_cursor, ns_clear_frame_area)
1699 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1700 (menuDown): Assign [sender tag] to variable and cast the variable.
1701
1702 * nsterm.h (menuDown): Add id as type to argument sender.
1703 (ns_display_info_for_name): Add Lisp_Object argument.
1704 (ns_term_init): Add Lisp_Object argument.
1705 (ns_map_event_to_object): Add void argument.
1706 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1707 prototype with arguments and only declare if __OBJC__.
1708 (nxatoms_of_nsselect): Add void argument.
1709 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1710 (ns_alloc_autorelease_pool): Add void argument.
1711 (ns_release_autorelease_pool): Add void* argument.
1712 (ns_get_defaults_value): Add const char* argument.
1713
1714 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1715 (initFromContents): Use SSDATA where appropriate.
1716 (ns_update_menubar): Add braces to ambigous if-else.
1717 (initWithTitle): Put () around assignment in if statement.
1718 (ns_menu_show): Remove unused variables window and keymap.
1719 (update_frame_tool_bar): Remove unused variable selected_p.
1720 (initWithContentRect): Remove unused variable this_cmd_name.
1721
1722 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1723 appropriate.
1724 (setXBMColor): Remove unused variable len.
1725 (setPixmapData): Put () around assignment in loop statement.
1726
1727 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1728 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1729 where appropriate.
1730 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1731 around assignment in loop statement.
1732 (nsfont_open): Remove unused variable i.
1733 (nsfont_open): Remove unused variable len.
1734 (nsfont_draw): Remove unused variable cs.
1735
1736 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1737 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1738 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1739 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1740 (Fns_font_name, Fns_perform_service)
1741 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1742 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1743 (ns_set_name): Remove unused variable view.
1744 (x_set_menu_bar_lines): Remove unused variable olines.
1745 (x_set_tool_bar_lines): Remove unused variable root_window.
1746 (Fns_list_colors): Put () around assignment in while statement.
1747 (Fns_perform_service): Remove unused variable len.
1748 (Fns_display_usable_bounds): Remove unused variable top.
1749 (syms_of_nsfns): Remove unused variable i.
1750
b55b9f85
JD
1751 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1752 memcpy (Bug#11907).
1753
ed9265fc 17542012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1755
1756 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1757 and free it with DestroyExceptionInfo (Bug#11558).
1758
ef099b57
JB
17592012-07-13 Juanma Barranquero <lekktu@gmail.com>
1760
1761 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1762 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1763 Set here, not in nt/config.nt.
1764
ea814a5d
EZ
17652012-07-13 Eli Zaretskii <eliz@gnu.org>
1766
1767 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1768 cursor overflow into the last glyph on display line when the right
1769 fringe is off. (Bug#11832)
1770
1a952767
PE
17712012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 * xdisp.c (produce_special_glyphs): Now static.
1774 * dispextern.h (produce_special_glyphs): Remove decl.
1775
983188fd
GM
17762012-07-13 Glenn Morris <rgm@gnu.org>
1777
8d7c7eed 1778 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1779 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1780
983188fd
GM
1781 * s/usg5-4-common.h (USG, USG5):
1782 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1783 * s/sol2-6.h (SOLARIS2):
1784 * s/irix6-5.h (IRIX6_5):
1785 * s/hpux10-20.h (USG, USG5, HPUX):
1786 * s/gnu-linux.h (USG, GNU_LINUX):
1787 * s/freebsd.h (BSD_SYSTEM):
1788 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1789 * s/cygwin.h (CYGWIN):
1790 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1791 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1792
d1e68667 17932012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1794
1795 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1796
6de0e799
GM
17972012-07-13 Glenn Morris <rgm@gnu.org>
1798
739ae010
GM
1799 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1800
dbee5793
GM
1801 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1802
6de0e799
GM
1803 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1804 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1805
b82da769
GM
18062012-07-12 Glenn Morris <rgm@gnu.org>
1807
4fae5a7a 1808 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1809
1810 * process.c (init_process_emacs): Rename from init_process.
1811 The old name is also the name of a Mach system call.
1812 * lisp.h, emacs.c: Update for this name change.
1813 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1814 longer needed.
1815
5a979817
EZ
18162012-07-12 Eli Zaretskii <eliz@gnu.org>
1817
1818 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1819 memmove call that removes glyphs covered by the left truncation
1820 glyph. Improve commentary.
1821 (display_line): Fix display of continuation glyphs on GUI frames
1822 when the right fringe is turned off and variable-size fonts are
1823 used in the window. Move the code that appends a stretch glyph to
1824 produce_special_glyphs, so that it could be used for truncation
1825 and continuation glyphs alike.
1826 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1827 glyph of a suitably computed width, to align the special glyphs at
1828 the window margin. Code moved from display_line. (Bug#11832)
1829
3e91a053
GM
18302012-07-12 Glenn Morris <rgm@gnu.org>
1831
ba9e4b84
GM
1832 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1833
1834 * s/gnu-linux.h, s/hpux10-20.h:
1835 Do not unconditionally define HAVE_XRMSETDATABASE.
1836
3e91a053
GM
1837 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1838
b300b1f4
PE
18392012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 Fix typos that broke OS X build.
1842 Reported by Randal L. Schwartz in
1843 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1844 * nsterm.m (ns_timeout): Add missing local decl.
1845 (ns_get_color): snprintf -> sprintf, to fix typo.
1846
6e777848
GM
18472012-07-12 Glenn Morris <rgm@gnu.org>
1848
3f922c37
GM
1849 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1850 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1851 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1852 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1853
0ab7b23a
GM
1854 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1855 Move PTY_OPEN to configure.
1856
6e777848
GM
1857 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1858 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1859 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1860
4a7edc24
DA
18612012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1862
1863 Use empty_unibyte_string where applicable.
1864 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1865 * lread.c (read1): Likewise.
1866 * xsettings.c (syms_of_xsettings): Likewise.
1867
308aab79
GM
18682012-07-12 Glenn Morris <rgm@gnu.org>
1869
42bd1719
GM
1870 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1871 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1872 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1873 * s/hpux10-20.h (RUN_TIME_REMAP):
1874 * s/bsd-common.h (TABDLY): Move to configure.
1875
1876 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1877
1878 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1879
ea0bbd17 1880 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1881 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1882
1883 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1884
308aab79
GM
1885 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1886 * s/template.h: Move NARROWPROTO to configure.
1887
ee1cf5cf
GM
18882012-07-11 Glenn Morris <rgm@gnu.org>
1889
30fe9bf4
GM
1890 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1891 unused since 2011-01-17 change to systty.h.
1892
ee1cf5cf
GM
1893 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1894 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1895 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1896
63e47e07
PE
18972012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1898
1899 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1900
c43fb4c3
GM
19012012-07-11 Glenn Morris <rgm@gnu.org>
1902
1903 * s/darwin.h, s/gnu-linux.h, s/template.h:
1904 Move INTERRUPT_INPUT to configure.
1905
e8df9267
DA
19062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 Minor adjustments to interning code.
1909 * lisp.h (intern, intern_c_string): Redefine as static inline
1910 wrappers for intern_1 and intern_c_string_1, respectively.
1911 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1912 * lread.c (intern_1, intern_c_string_1, oblookup):
1913 Simplify Vobarray checking.
e8df9267
DA
1914 * font.c (font_intern_prop): Likewise. Adjust comment.
1915 * w32font.c (intern_font_name): Likewise.
1916
34348bd4
AS
19172012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1918
d96a1e0c
AS
1919 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1920
34348bd4
AS
1921 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1922 of Fcar/Fcdr if possible.
1923 * font.c (check_otf_features): Likewise.
1924 * fontset.c (Fnew_fontset): Likewise.
1925 * gnutls.c (Fgnutls_boot): Likewise.
1926 * minibuf.c (read_minibuf): Likewise.
1927 * msdos.c (IT_set_frame_parameters): Likewise.
1928 * xmenu.c (Fx_popup_dialog): Likewise.
1929 * w32menu.c (Fx_popup_dialog): Likewise.
1930
c8add24e
GM
19312012-07-11 Glenn Morris <rgm@gnu.org>
1932
4b575b3c
GM
1933 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1934 since nothing has defined it on these platforms.
1935
09f4e3b0
GM
1936 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1937 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1938
172bedef
GM
1939 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1940 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1941 Move CLASH_DETECTION to configure.
1942
249685df
GM
1943 * s/gnu.h: Remove file, which is now empty.
1944
c8add24e
GM
1945 * s/gnu.h, s/gnu-linux.h:
1946 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1947
b41253a3
JW
19482012-07-11 John Wiegley <johnw@newartisans.com>
1949
1950 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1951 function attribute, so we only use it if it exists in the
1952 compiler.
1953
d923b542
DA
19542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1955
1956 Avoid call to strlen in fast_c_string_match_ignore_case.
1957 * search.c (fast_c_string_match_ignore_case): Change to use
1958 length argument. Adjust users accordingly.
1959 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1960
5ebbef1d
PE
19612012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1962
bb352260
PE
1963 Assume mkdir, rmdir.
1964 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1965 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1966
57054ddd
PE
1967 Assume rename.
1968 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1969
b747d3f7
PE
1970 Assume perror.
1971 * s/hpux10-20.h (HAVE_PERROR): Remove.
1972 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1973 Remove dummy definition, as this problem was obsolete long ago.
1974
5ebbef1d
PE
1975 Assume strerror.
1976 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1977
984e7f30
DA
19782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1979
1980 Avoid calls to strlen in font processing functions.
1981 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1982 (font_open_by_name): Change to use length argument.
1983 Adjust users accordingly.
d923b542
DA
1984 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1985 Adjust prototypes.
1986 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1987 Change to return ptrdiff_t.
984e7f30
DA
1988 (xfont_list_pattern, xfont_match): Use length returned by
1989 xfont_decode_coding_xlfd.
1990 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1991
20e94fdd
GM
19922012-07-11 Glenn Morris <rgm@gnu.org>
1993
9d596af3
GM
1994 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1995 Move DONT_REOPEN_PTY to configure.
1996
20e94fdd
GM
1997 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1998 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1999
e99a530f
PE
20002012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2001
22ffb973
PE
2002 Remove "#define unix" that is no longer needed (Bug#11905).
2003 * s/aix4-2.h (unix): Remove; no longer needed.
2004
e9a9ae03
PE
2005 EMACS_TIME simplification (Bug#11875).
2006 This replaces macros (which typically do not work in GDB)
2007 with functions, typedefs and enums, making the code easier to debug.
2008 The functional style also makes code easier to read and maintain.
2009 * systime.h: Include <sys/time.h> on all hosts, not just if
2010 WINDOWSNT, since 'struct timeval' is needed in general.
2011 (EMACS_TIME): Now a typedef, not a macro.
2012 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2013 not macros.
2014 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2015 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2016 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2017 (EMACS_TIME_LE): Now functions, not macros.
2018 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2019 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2020 which are not functions. All uses rewritten to use:
2021 (make_emacs_time): New function.
2022 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2023 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2024 not functions. All uses rewritten to use the following, respectively:
2025 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2026 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2027 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2028 * fileio.c (Fcopy_file):
2029 * xterm.c (XTflash): Get the current time closer to when it's used.
2030 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2031
ffacb126
PE
2032 * bytecode.c (targets): Suppress -Woverride-init warnings.
2033
e99a530f
PE
2034 Simplify by avoiding confusing use of strncpy etc.
2035 * doc.c (Fsnarf_documentation):
2036 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2037 * frame.c (Fmake_terminal_frame):
2038 * gtkutil.c (get_utf8_string):
2039 * lread.c (openp):
2040 * nsmenu.m (ns_update_menubar):
2041 * regex.c (regerror):
2042 Prefer memcpy to strncpy and strncat when either will do.
2043 * fileio.c (Fsubstitute_in_file_name):
2044 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2045 (menu_separator_name_p):
2046 * nsmenu.m (ns_update_menubar):
2047 Prefer memcmp to strncmp when either will do.
2048 * nsterm.m: Include <ftoastr.h>.
2049 (ns_get_color):
2050 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2051 Prefer snprintf to strncpy.
2052 * nsterm.m (ns_term_init):
2053 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2054 * nsterm.m (ns_term_init):
2055 Avoid the need for strncpy, by using build_string or
2056 make_unibyte_string directly. Use dtoastr, not snprintf.
2057 * process.c (Fmake_network_process): Diagnose service names that
2058 are too long, rather than silently truncating them or creating
2059 non-null-terminated names.
2060 (Fnetwork_interface_info): Likewise, for interface names.
2061 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2062 Prefer sprintf to strncat.
2063 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2064 Prefer vsnprintf to vsprintf + strncpy.
2065
c59592b3
GM
20662012-07-10 Glenn Morris <rgm@gnu.org>
2067
2068 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2069 Clarify fallback case.
2070
7d7bbefd
DA
20712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2072
2073 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2074 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2075 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2076 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2077 where argument type is known to be a Lisp_Cons.
2078
3a4c8000
TT
20792012-07-10 Tom Tromey <tromey@redhat.com>
2080
2081 * bytecode.c (BYTE_CODE_THREADED): New macro.
2082 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2083 (enum byte_code_op): New type.
2084 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2085 (exec_byte_code): Use them. Use token threading when applicable.
2086
2a0213a6
DA
20872012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 Optimize pure C strings initialization.
2090 * lisp.h (make_pure_string): Fix prototype.
2091 (build_pure_c_string): New function, defined as static inline. This
2092 provides a better opportunity to optimize away calls to strlen when
2093 the function is called with compile-time constant argument.
2094 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2095 argument, adjust users accordingly. Use build_pure_c_string where
2096 appropriate.
2097 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2098 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2099 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2100
cb1caeaf
DA
21012012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2102
2103 Avoid calls to strlen in miscellaneous functions.
2104 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2105 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2106 * lread.c (openp): Likewise.
2107
c293e30c
DA
21082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 Avoid calls to strlen in path processing functions.
2111 * fileio.c (file_name_as_directory): Add comment. Change to add
2112 srclen argument and return the length of result. Adjust users
2113 accordingly.
2114 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2115 swap 1st and 2nd arguments to obey the common convention.
2116 Adjust users accordingly.
c293e30c
DA
2117 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2118
9e059e3f
GM
21192012-07-10 Glenn Morris <rgm@gnu.org>
2120
d02eb359
GM
2121 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2122 Move PENDING_OUTPUT_COUNT definition to configure.
2123
882cf227
GM
2124 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2125 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2126 * s/gnu.h (DATA_START): Move definitions to configure.
2127
af6e839f
GM
2128 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2129 We include usg5-4-common.h, which defines them both.
2130
40289a12
GM
2131 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2132 O_RDONLY already includes it).
2133
9e059e3f
GM
2134 Stop ns builds setting the EMACSLOADPATH environment variable.
2135 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2136 Now it does not set EMACSLOADPATH, just returns the load-path string.
2137 * nsterm.h: Update accordingly.
2138 * lread.c [HAVE_NS]: Include nsterm.h.
2139 (init_lread) [HAVE_NS]: Use ns_load_path.
2140 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2141
7c4e8ec0
GM
21422012-07-09 Glenn Morris <rgm@gnu.org>
2143
d4f600ff
GM
2144 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2145 since the included bsd-common.h does so.
2146
cbb31951
GM
2147 Stop ns builds setting the EMACSPATH environment variable.
2148 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2149 (ns_init_paths): Do not set EMACSPATH.
2150 * nsterm.h (ns_exec_path): Add it.
2151 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2152 Use ns_exec_path.
2153
7c4e8ec0
GM
2154 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2155
26bccfae
PE
21562012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2157
a0bee46f
PE
2158 * process.c (wait_reading_process_output): 'waitchannels' was unset
2159 when read_kbd || !NILP (wait_for_cell); fix this.
2160
5994c183
PE
2161 Add GCC-style 'const' attribute to functions that can use it.
2162 * character.h (char_resolve_modifier_mask):
2163 * keyboard.h (make_ctrl_char):
2164 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2165 (init_character_once, next_almost_prime, init_fns, init_image)
2166 (flush_pending_output, init_sound):
2167 * mem-limits.h (start_of_data):
2168 * menu.h (finish_menu_items):
2169 Add ATTRIBUTE_CONST.
2170 * emacs.c (DEFINE_DUMMY_FUNCTION):
2171 Declare the dummy function with ATTRIBUTE_CONST.
2172 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2173 Add decls with ATTRIBUTE_CONST.
2174
26bccfae
PE
2175 Minor improvements to make_formatted_string.
2176 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2177 where int is good enough, as vsprintf returns an int.
2178 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2179
a8290ec3
DA
21802012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2181
2182 Use make_formatted_string to avoid double length calculation.
2183 * lisp.h (make_formatted_string): New prototype.
2184 * alloc.c (make_formatted_string): New function.
2185 * buffer.c (Fgenerate_new_buffer_name): Use it.
2186 * dbus.c (syms_of_dbusbind): Likewise.
2187 * editfns.c (Fcurrent_time_zone): Likewise.
2188 * filelock.c (get_boot_time): Likewise.
2189 * frame.c (make_terminal_frame, set_term_frame_name)
2190 (x_report_frame_params): Likewise.
2191 * image.c (gs_load): Likewise.
2192 * minibuf.c (get_minibuffer): Likewise.
2193 * msdos.c (dos_set_window_size): Likewise.
2194 * process.c (make_process): Likewise.
2195 * xdisp.c (ensure_echo_area_buffers): Likewise.
2196 * xsettings.c (apply_xft_settings): Likewise.
2197
d01ba2f1
GM
21982012-07-09 Glenn Morris <rgm@gnu.org>
2199
2200 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2201 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2202 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2203 * nsterm.h (ns_etc_directory): Add it.
2204 * callproc.c [HAVE_NS]: Include nsterm.h.
2205 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2206
f1f924b6
DA
22072012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2208
2209 Move marker debugging code under MARKER_DEBUG.
2210 * marker.c (MARKER_DEBUG): Move marker debugging code under
2211 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2212 for bootstrap with --enable-checking (~3x slowdown reported
2213 by Juanma Barranquero <lekktu@gmail.com>).
2214 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2215
ab531b66
PE
22162012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2219 See <http://bugs.gnu.org/11825#29>.
2220
c4b3bc8a
EZ
22212012-07-08 Eli Zaretskii <eliz@gnu.org>
2222
2223 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2224 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2225 (display_line): Add commentary about displaying truncation glyphs
2226 on GUI frames.
2227 (produce_special_glyphs): Move here from term.c.
2228
2229 * term.c (produce_special_glyphs): Move to xdisp.c.
2230
2231 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2232 section.
c4b3bc8a 2233
b676b881
AS
22342012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2235
f17c5273
AS
2236 * xdisp.c (display_line): Avoid warning about implicit declaration
2237 of FRAME_FONT.
2238
298819b9
AS
2239 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2240
b676b881
AS
2241 * lisp.h: Remove empty conditional.
2242
6045c4fd
PE
22432012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2244
b3350bf9
PE
2245 * lread.c (load_path_check): Now static.
2246
6045c4fd
PE
2247 Fix some minor --with-ns problems found by static checking.
2248 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2249 (x_set_font) [!HAVE_X_WINDOWS]:
2250 * image.c (xpm_load_image) [HAVE_NS]:
2251 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2252 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2253 Remove unused local.
2254 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2255 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2256 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2257 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2258 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2259 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2260 Fix pointer signedness problem.
2261 * xfaces.c (FRAME_X_FONT_TABLE):
2262 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2263
929e7845
GM
22642012-07-07 Glenn Morris <rgm@gnu.org>
2265
2266 * lread.c (load_path_check): New function, split from init_lread.
2267 (init_lread): Reorganize. Motivation:
2268 If EMACSLOADPATH is set, check/warn about that rather than the
2269 defaults, which we are not going to use. Hence we can remove
2270 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2271 Don't warn if site-lisp directories are missing.
2272 If not installed, start from a blank load-path, since
2273 PATH_LOADSEARCH refers to the eventual installation directories.
2274
58dd0aa4
EZ
22752012-07-07 Eli Zaretskii <eliz@gnu.org>
2276
2277 Support truncation and continuation glyphs on GUI frames, when
2278 fringes are disabled. (Bug#11832)
2279 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2280 continuation glyphs even if on GUI frames.
2281 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2282 or both, are absent.
2283 (start_display, move_it_in_display_line_to): Handle the case of a
2284 GUI frame without a fringe to display continuation or truncation
2285 glyphs.
2286 (insert_left_trunc_glyphs): Support GUI frames: make sure
2287 truncation glyphs overwrite enough glyphs from the current line to
2288 have sufficient space in pixels.
2289 (display_line): Support truncation and continuation glyphs on GUI
2290 frames. If some spare pixels are left on the line after inserting
2291 the truncation glyphs, fill that space with a stretch glyph of a
2292 suitably computed width.
2293
2294 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2295 produce_glyphs, to support GUI sessions.
2296
31571fd7
PE
22972012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2298
5a16b9bc
PE
2299 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2300
f3047c75
PE
2301 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2302
31571fd7
PE
2303 Do not require float-time's arg to fit in time_t (Bug#11825).
2304 This works better on hosts where time_t is unsigned, and where
2305 float-time is applied to the (negative) difference between two times.
2306 * editfns.c (decode_time_components): Last arg is now double *,
2307 not int *, and means to store all the result as a double, without
2308 worrying about whether the seconds part fits in time_t.
2309 All callers changed.
2310 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2311 All callers changed.
2312 (Ffloat_time): Do not fail merely because the specified time falls
2313 outside of time_t range.
2314
4516fbef
GM
23152012-07-07 Glenn Morris <rgm@gnu.org>
2316
2317 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2318 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2319 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2320
07adc2c6
JB
23212012-07-07 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2324 Update dependencies.
2325
2326 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2327
fd573f31
PE
23282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2329
fee5959d
PE
2330 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2331 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2332 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2333 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2334 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2335 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2336
fd573f31
PE
2337 * xfont.c (compare_font_names): Redo to omit the need for casts.
2338
ddadbc0e
AS
23392012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2340
fca8d6b6
AS
2341 * xfns.c (Fx_change_window_property): Doc fix.
2342 * w32fns.c (Fx_change_window_property): Doc fix.
2343
ddadbc0e
AS
2344 * w32fns.c (Fx_window_property): Accept the same arguments as the
2345 X Windows version. Doc fix.
2346 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2347
ed9265fc 23482012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2349 Eli Zaretskii <eliz@gnu.org>
2350
2351 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2352 Windows-specific code from nt/config.nt moved here.
2353 Obsolete settings removed.
2354
216ee680
PE
23552012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2356
2357 * process.c: Avoid unnecessary calls to gettime.
2358 (wait_reading_process_output): Don't get the time of day
2359 when gobbling data immediately and not waiting, as there's no need
2360 for it in that case. This removes a FIXME.
2361
bdd091e4
JD
23622012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2363
2364 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2365 is defined (Bug#11768).
2366
9d44f8ce
DA
23672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2368
2369 Fix marker debugging code.
2370 * marker.c (byte_char_debug_check): Do not perform the check
2371 if buffer is not multibyte.
090bd7cb
JB
2372 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2373 Call byte_char_debug_check with correct arguments.
9d44f8ce 2374
90fc4786
DA
23752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2376
2377 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2378 * marker.c (byte_char_debug_check, count_markers):
2379 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2380 (byte_debug_flag): Remove.
2381 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2382 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2383
7b7ae965
DA
23842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2385
4e57b342
DA
2386 Avoid code repetition in marker-related functions.
2387 * marker.c (attach_marker): New function.
2388 (Fset_marker, set_marker_restricted, set_marker_both)
2389 (set_marker_restricted_both): Use it.
2390 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2391 Consistently rename charno to charpos.
2392 (marker_position): Add eassert.
2393 (marker_byte_position): Convert to eassert.
2394
23952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2396
2397 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2398 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2399 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2400
657924ff
DA
24012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2402
2403 Introduce fast path for the widely used marker operation.
2404 * alloc.c (build_marker): New function.
2405 * lisp.h (build_marker): New prototype.
2406 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2407 * composite.c (autocmp_chars): Likewise.
2408 * editfns.c (buildmark): Remove.
2409 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2410 (save_restriction_save): Use build_marker.
2411 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2412 * window.c (save_window_save): Likewise.
2413
041a49a6
DA
24142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2415
2416 Do not use Fdelete_overlay in delete_all_overlays
2417 to avoid redundant calls to unchain_overlay.
2418 * buffer.c (drop_overlay): New function.
2419 (delete_all_overlays, Fdelete_overlay): Use it.
2420 * minibuf.c (get_minibuffer): Fix comment.
2421
7dca65a4
PE
24222012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 Port to OpenBSD 5.1 amd64.
2425 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2426 This is needed for OpenBSD, and should be harmless on all BSD systems.
2427 Also, include <sys/sysctl.h>, as it should be available on all
2428 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2429 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2430 use p_pid member, not kp_proc.pid.
2431
8eb876e2
GM
24322012-07-06 Glenn Morris <rgm@gnu.org>
2433
2434 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2435
38182d90
PE
24362012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 More xmalloc and related cleanup.
2439 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2440 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2441 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2442 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2443 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2444 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2445 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2446 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2447 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2448 * xterm.c:
2449 Omit needless casts involving void * pointers and allocation.
2450 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2451 as the former is more robust if P's type is changed.
2452 Prefer xzalloc to xmalloc + memset 0.
2453 Simplify malloc-or-realloc to realloc.
2454 Don't worry about xmalloc returning a null pointer.
2455 Prefer xstrdup to xmalloc + strcpy.
2456 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2457 growing it.
2458 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2459 alloca of a constant.
2460
6dd5a677
EZ
24612012-07-05 Eli Zaretskii <eliz@gnu.org>
2462
2463 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2464 hscroll is larger than the line width. Fixes long and futile
2465 looping inside extend_face_to_end_of_line (on a TTY) producing
2466 glyphs that are not needed and thrown away.
2467
6b312f0f
DA
24682012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2469
2470 * marker.c (set_marker_restricted_both): Simplify by using
2471 clip_to_bounds.
2472
f520ef9b
PE
24732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2476
383b7c95
JD
24772012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2478
2479 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2480 not defined (Bug#11768).
2481 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2482 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2483 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2484 followed by gtk_box_set_homogeneous (Bug#11768).
2485 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2486 (update_theme_scrollbar_width, xg_create_scroll_bar):
2487 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2488 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2489 (is_box_type): New function (Bug#11768).
2490 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2491 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2492 with default display (Bug#11768).
2493
d6e7bf45
EZ
24942012-07-05 Eli Zaretskii <eliz@gnu.org>
2495
2496 * xdisp.c (window_hscroll_limited): New function.
2497 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2498 coordinates when window's hscroll is set to insanely large
2499 values. (Bug#11857)
2500
431391ec
JB
25012012-07-05 Juanma Barranquero <lekktu@gmail.com>
2502
2503 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2504 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2505
23f86fce
DA
25062012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2507
2508 Cleanup xmalloc.
2509 * lisp.h (xzalloc): New prototype. Omit needless casts.
2510 * alloc.c (xzalloc): New function. Omit needless casts.
2511 * charset.c: Omit needless casts. Convert all calls to
2512 xmalloc with following memset to xzalloc.
2513 * dispnew.c: Likewise.
2514 * fringe.c: Likewise.
2515 * image.c: Likewise.
2516 * sound.c: Likewise.
2517 * term.c: Likewise.
2518 * w32fns.c: Likewise.
2519 * w32font.c: Likewise.
2520 * w32term.c: Likewise.
2521 * xfaces.c: Likewise.
2522 * xfns.c: Likewise.
2523 * xterm.c: Likewise.
2524 * atimer.c: Omit needless casts.
2525 * buffer.c: Likewise.
2526 * callproc.c: Likewise.
2527 * ccl.c: Likewise.
2528 * coding.c: Likewise.
2529 * composite.c: Likewise.
2530 * doc.c: Likewise.
2531 * doprnt.c: Likewise.
2532 * editfns.c: Likewise.
2533 * emacs.c: Likewise.
2534 * eval.c: Likewise.
2535 * filelock.c: Likewise.
2536 * fns.c: Likewise.
2537 * gtkutil.c: Likewise.
2538 * keyboard.c: Likewise.
2539 * lisp.h: Likewise.
2540 * lread.c: Likewise.
2541 * minibuf.c: Likewise.
2542 * msdos.c: Likewise.
2543 * print.c: Likewise.
2544 * process.c: Likewise.
2545 * region-cache.c: Likewise.
2546 * search.c: Likewise.
2547 * sysdep.c: Likewise.
2548 * termcap.c: Likewise.
2549 * terminal.c: Likewise.
2550 * tparam.c: Likewise.
2551 * w16select.c: Likewise.
2552 * w32.c: Likewise.
2553 * w32reg.c: Likewise.
2554 * w32select.c: Likewise.
2555 * w32uniscribe.c: Likewise.
2556 * widget.c: Likewise.
2557 * xdisp.c: Likewise.
2558 * xmenu.c: Likewise.
2559 * xrdb.c: Likewise.
2560 * xselect.c: Likewise.
2561
0497dc44
PE
25622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * fileio.c (time_error_value): Check the right error number.
2565 Problem reported by Troels Nielsen in
2566 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2567
356e7178
PE
25682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2569
4e71fd89
PE
2570 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2571 This should be fixed in a better way; see Eli Zaretskii in
2572 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2573 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2574
f0941253
PE
2575 * fileio.c (time_error_value): Rename from special_mtime.
2576 The old name's problems were noted by Eli Zaretskii in
2577 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2578
065c9eb4
PE
2579 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2580 This variable's comment says Emacs needs at least one GDB-visible
2581 symbol of type enum pvec_type, to work around GDB problems.
2582 The symbol's value doesn't matter.
2583
356e7178
PE
2584 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2585 that causes compilation to fail on pre-C99 compilers.
2586
ed9265fc 25872012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2588
2589 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2590 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2591
3884d954
DA
25922012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2593
d209e2fb 2594 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2595 headers for buffer_defaults and buffer_local_symbols.
2596 Reported by Juanma Barranquero <lekktu@gmail.com>.
2597
ee28be33
SM
25982012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2599
2600 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2601 * lisp.h (enum pvec_type): Use fewer bits.
2602 (PSEUDOVECTOR_SIZE_BITS): New constant.
2603 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2604 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2605 change in pvec_type.
2606 (PSEUDOVECTOR_TYPEP): New macro.
2607 (TYPED_PSEUDOVECTORP): Use it.
2608 * fns.c (internal_equal): Adapt code to extract pvectype.
2609 * emacs.c (gdb_pvec_type): Update type.
2610 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2611 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2612 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2613 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2614 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2615 abusing vector->header.next.nbytes.
2616 (live_vector_p): Use PVEC_TYPE.
2617 (mark_object): Adapt code to extract pvectype. Use switch.
2618
c7f2cd7f
PE
26192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2622 Tighten new eassert a bit.
2623
8ce70ed2
DA
26242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2625
2626 Fix compilation with --enable-gcc-warnings and -O1
2627 optimization level.
2628 * doprnt.c (doprnt): Change type of tem to int, initialize
2629 to avoid compiler warning. Add eassert.
2630 * search.c (simple_search): Initialize match_byte to avoid
2631 compiler warning. Add eassert.
2632
dea7f1e5
PE
26332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2634
24a212eb
PE
2635 Avoid weird behavior with large horizontal scrolls.
2636 Without this change, for example, large hscroll values would
2637 mess up Emacs's display on Fedora 15 x86, presumably due to
2638 overflows in int calculations in the display code.
2639 Also, if buffers had long lines, Emacs would freeze.
2640 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2641 (set_window_hscroll): New function, containing the old guts of
2642 Fset_window_hscroll. Return the clipped value.
2643 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2644 This avoids the need to check against PTRDIFF_MAX.
2645
dea7f1e5
PE
2646 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2647
76046526
DA
26482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2649
2650 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2651
39adff0d
PE
26522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2653
63807d47
PE
2654 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2655 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2656 since GCC 4.4.6 issues a bogus warning for them.
2657
39adff0d
PE
2658 Fix bugs in file timestamp newness comparisons.
2659 * fileio.c (Ffile_newer_than_file_p):
2660 * lread.c (Fload): Use full timestamp resolution of files,
2661 not just the 1-second resolution, so that files that are only
2662 slightly newer still count as newer.
2663 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2664 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2665
dbeed9a6
PE
26662012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 * fileio.c: Improve handling of file time marker. (Bug#11852)
2669 (special_mtime): New function.
2670 (Finsert_file_contents, Fverify_visited_file_modtime):
2671 Use it to set special mtime values consistently.
2672
636334d6
AS
26732012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2674
2675 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2676 marker for non-existing file. (Bug#11852)
2677
e2017fe2
GM
26782012-07-03 Glenn Morris <rgm@gnu.org>
2679
2680 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2681 and did not make it into globals.h).
2682
404dbd37
TT
26832012-07-03 Tom Tromey <tromey@redhat.com>
2684
2685 * window.c (Fset_window_margins, Fset_window_fringes)
2686 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2687 * textprop.c (Fprevious_property_change): No longer static.
2688 * syntax.c (Fsyntax_table_p): No longer static.
2689 * process.c (Fget_process, Fprocess_datagram_address): No longer
2690 static.
2691 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2692 * keyboard.c (Fcommand_execute): No longer static.
2693 Remove EXFUN.
2694 * insdel.c (Fcombine_after_change_execute): No longer static.
2695 * image.c (Finit_image_library): No longer static.
2696 * fileio.c (Fmake_symbolic_link): No longer static.
2697 * eval.c (Ffetch_bytecode): No longer static.
2698 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2699 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2700 No longer static.
404dbd37
TT
2701 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2702 static.
2703 * dired.c (Ffile_attributes): No longer static.
2704 * composite.c (Fcomposition_get_gstring): No longer static.
2705 * callproc.c (Fgetenv_internal): No longer static.
2706
2707 * ccl.h: Remove EXFUNs.
2708 * buffer.h: Remove EXFUNs.
2709 * dispextern.h: Remove EXFUNs.
2710 * intervals.h: Remove EXFUNs.
2711 * fontset.h: Remove EXFUN.
2712 * font.h: Remove EXFUNs.
2713 * dosfns.c (system_process_attributes): Remove EXFUN.
2714 * keymap.h: Remove EXFUNs.
2715 * lisp.h: Remove EXFUNs.
2716 * w32term.h: Remove EXFUNs.
2717 * window.h: Remove EXFUNs.
2718 * xsettings.h: Remove EXFUN.
2719 * xterm.h: Remove EXFUN.
2720
8e4fd1e1
GM
27212012-07-03 Glenn Morris <rgm@gnu.org>
2722
2723 * lisp.h (Frandom): Make it visible to C.
2724 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2725 buffer for invisible buffers. (Bug#1229)
2726
ca95b3eb
DA
27272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2728
2729 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2730 values which aren't power of 2.
14ae4239
BT
2731 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2732 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2733 accordingly.
2734
7555c33f
SM
27352012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2736
2737 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2738
2739 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2740
d12e8f5a
DA
27412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2742
2743 * alloc.c (allocate_vector_block): Remove redundant
2744 calls to mallopt if DOUG_LEA_MALLOC is defined.
2745 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2746 avoid calls to mallopt if zero_vector is returned.
2747
296094c3
DA
27482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2749
2750 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2751 is enabled, avoid dereferencing NULL current_sblock if
2752 running undumped.
2753
36429c89
DA
27542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2755
2756 Cleanup basic buffer management.
2757 * buffer.h (struct buffer): Change layout to use generic vector
2758 marking code. Fix some comments. Change type of 'clip_changed'
2759 to bitfield. Remove unused #ifndef old.
2760 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2761 (GET_OVERLAYS_AT): Fix indentation.
2762 (for_each_per_buffer_object_at): New macro.
2763 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2764 (Fbuffer_local_variables): Use it.
2765 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2766 * alloc.c (allocate_buffer): Adjust to match new layout of
2767 struct buffer. Fix comment.
2768 (mark_overlay): New function.
2769 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2770 Lisp area of struct buffer.
2771 (mark_object): Use it. Adjust marking of misc objects
2772 and related comments.
2773
3b3e4cac
PE
27742012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2775
2776 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2777 wrapper that is not needed because the wrapped code is a no-op (zero
2778 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2779 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2780
cf5c0175
DA
27812012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2782
2783 * alloc.c (mark_buffer): Simplify. Remove prototype.
2784 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2785 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2786 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2787 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2788
ca26824c
GM
27892012-06-30 Glenn Morris <rgm@gnu.org>
2790
2e4c5312
GM
2791 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2792
ca26824c
GM
2793 * epaths.in (PATH_SITELOADSEARCH): New.
2794 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2795 This is rather than relying on --enable-locallisppath elements
2796 having "site-lisp" in their names. (Bug#10208#25, 11658)
2797
0d23c240
EZ
27982012-06-30 Eli Zaretskii <eliz@gnu.org>
2799
c9240d7a
EZ
2800 * w32proc.c (sys_select): Accept and ignore one more argument.
2801
2802 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2803
0d23c240 2804 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2805 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2806
2807 * sysdep.c: Don't include dos.h and dosfns.h.
2808
2809 * process.c (sys_select):
2810 * msdos.c (sys_select): Accept one more argument and ignore it.
2811
2812 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2813 adapt data types and code to that.
2814
2815 * dosfns.c:
2816 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2817 which clashes with the gnulib function of the same name.
2818
af5a5a98
AS
28192012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2820
c5e4379c
AS
2821 * font.c (font_style_to_value, font_style_symbolic)
2822 (font_prop_validate_style): Add type checks for values in
2823 font_style_table.
2824
af5a5a98
AS
2825 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2826 argument.
2827 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2828 uses.
2829
8d38f461
EZ
28302012-06-29 Eli Zaretskii <eliz@gnu.org>
2831
2e5a6631
EZ
2832 * xdisp.c (try_window_id): Undo last change.
2833
8d38f461
EZ
2834 * w32.c (getwd): Adjust commentary about startup_dir.
2835 (init_environment): Always call sys_access, even in non-MSVC
2836 builds. Don't chdir to the directory of the Emacs executable.
2837 This undoes code from 1997 which was justified by the need to
2838 "avoid conflicts when removing and renaming directories". But its
2839 downside was that every relative file name was being interpreted
2840 relative to the directory of the Emacs executable, which can never
2841 be TRT. In particular, it broke sys_access when called with
2842 relative file names.
2843 (sys_access): Map GetLastError to errno.
2844
2af3565e
DA
28452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2846
2847 * window.h (struct window): Change type of 'fringes_outside_margins'
2848 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2849 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2850 Adjust comment.
2851 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2852 to ptrdiff_t.
2853
c8d3a25c 28542012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2855
c8d3a25c
GM
2856 * gnutls.c (emacs_gnutls_handshake):
2857 Add QUIT to make the loop interruptible.
57570cd3 2858
c8d3a25c 28592012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2860
c8d3a25c
GM
2861 * charset.c (init_charset): Make lack of etc/charsets fatal.
2862
3e984ee8
DA
28632012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2864
2865 * editfns.c (region_limit): Fix type mismatch.
2866
ef884f23
DA
28672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2868
2869 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2870 undefined. Convert from xassert to eassert.
2871 * nsmenu.m: Convert from xassert to eassert.
2872 * nsterm.m: Likewise.
2873
7d7e0027
SM
28742012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2875
2876 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2877
aa754e6a
PE
28782012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2879
2880 Avoid integer overflow on scroll-left and scroll-right.
2881 * window.c (HSCROLL_MAX): New macro.
2882 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2883 overflow when requested scroll falls outside ptrdiff_t range.
2884
80b00b08
DA
28852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2886
2887 * window.h (struct window): Change type of 'hscroll',
2888 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2889 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2890 Adjust users accordingly.
2891 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2892 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2893 from EMACS_INT to ptrdiff_t.
2894 (make_window): Omit redundant initialization.
2895
62b2bcf6
JB
28962012-06-28 Juanma Barranquero <lekktu@gmail.com>
2897
2898 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2899
45942c7d
DA
29002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2901
2902 * window.h (struct window): Change type of 'use_time' and
2903 'sequence_number' from Lisp_Object to int.
2904 * frame.c (make_frame): Adjust users accordingly.
2905 * print.c (print_object): Likewise.
2906 * window.c (select_window, Fwindow_use_time, make_parent_window)
2907 (make_window): Likewise.
2908
e509cfa6
DA
29092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2910
2911 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2912 enabled with --enable-checking=[all,glyphs] configure option.
2913 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2914 adjust comments accordingly.
2915 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2916 undefined, adjust comments accordingly.
2917 * image.c: Likewise.
2918 * scroll.c: Likewise.
2919 * w32fns.c: Likewise.
2920 * w32term.c: Likewise.
2921 * xdisp.c: Likewise.
2922 * xfaces.c: Likewise.
2923 * xfns.c: Likewise.
2924 * xterm.c: Likewise.
2925
a54e2c05
DA
29262012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2927
2928 Generalize run-time debugging checks.
2929 * dispextern.h (XASSERTS): Remove.
2930 * fontset.c (xassert): Remove.
2931 Convert from xassert to eassert.
2932 * alloc.c: Convert from xassert to eassert.
2933 * bidi.c: Likewise.
2934 * dispnew.c: Likewise.
2935 * fns.c: Likewise.
2936 * fringe.c: Likewise.
2937 * ftfont.c: Likewise.
2938 * gtkutil.c: Likewise.
2939 * image.c: Likewise.
2940 * keyboard.c: Likewise.
2941 * menu.c: Likewise.
2942 * process.c: Likewise.
2943 * scroll.c: Likewise.
2944 * sound.c: Likewise.
2945 * term.c: Likewise.
2946 * w32console.c: Likewise.
2947 * w32fns.c: Likewise.
2948 * w32term.c: Likewise.
2949 * window.c: Likewise.
2950 * xdisp.c: Likewise.
2951 * xfaces.c: Likewise.
2952 * xfns.c: Likewise.
2953 * xselect.c: Likewise.
2954 * xterm.c: Likewise.
2955
1ec4b7b2
SM
29562012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2957
2958 * fns.c (maybe_resize_hash_table): Output message when growing the
2959 purify-hashtable.
2960
2014308a
DA
29612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2962
2963 * alloc.c (allocate_string_data): Remove dead code.
2964 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2965 avoid GCC warning about unused macro.
2966
246155eb
DA
29672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2968
2969 * alloc.c (allocate_string): Omit intervals initialization.
2970 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2971 as in make_pure_string and make_pure_c_string.
2972
43184b7b
DA
29732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2974
d209e2fb 2975 * alloc.c (allocate_string): Fix last change.
43184b7b 2976
3fe6dd74
DA
29772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2978
d209e2fb 2979 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2980 to memset, add explicit initialization where appropriate.
2981
1ba6038a
GM
29822012-06-27 Glenn Morris <rgm@gnu.org>
2983
2984 * lisp.mk (lisp): Remove paths.elc.
2985
c89926a5
CY
29862012-06-27 Chong Yidong <cyd@gnu.org>
2987
2988 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2989
ed6b3510
JW
29902012-06-26 John Wiegley <johnw@newartisans.com>
2991
1ec4b7b2 2992 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2993 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2994
ed6b3510
JW
2995 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2996 when building with Clang.
2997
8edd4a2b
SM
29982012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2999
3000 * eval.c (Fapply): Allow calling it with a single argument.
3001
f6f62d1b
EZ
30022012-06-26 Eli Zaretskii <eliz@gnu.org>
3003
3004 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3005 _stricmp and _strnicmp.
3006 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3007
62efea5e
DA
30082012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3009
3010 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3011 allocated window.
3012 (allocate_process): Likewise for new process.
8edd4a2b 3013 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3014 (allocate_frame): Likewise.
3015 * frame.c (make_frame): Omit redundant initialization.
3016 * window.c (make_parent_window): Use memset.
3017 (make_window): Omit redundant initialization.
3018 * process.c (make_process): Omit redundant initialization.
3019 * terminal.c (create_terminal): Likewise.
3020
42997f4d
DA
30212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3022
3023 * term.c (delete_tty): Remove redundant call to memset.
3024
1130ecfc
DA
30252012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3026
3027 * alloc.c: Remove build_string.
3028 * lisp.h: Define build_string as static inline. This provides
3029 a better opportunity to optimize away calls to strlen when the
3030 function is called with compile-time constant argument.
3031 * image.c (imagemagick_error): Convert to build_string.
3032 * w32proc.c (sys_spawnve): Likewise.
3033 * xterm.c (x_term_init): Likewise.
3034
cf38a720
PE
30352012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3036
99027bdd
PE
3037 Use sprintf return value instead of invoking strlen on result.
3038 In the old days this wasn't portable, since some sprintf
3039 implementations returned char *. But they died out years ago and
3040 Emacs already assumes sprintf returns int.
3041 Similarly for float_to_string.
3042 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3043 * ccl.c (ccl_driver):
3044 * character.c (string_escape_byte8):
3045 * data.c (Fnumber_to_string):
3046 * doprnt.c (doprnt):
3047 * print.c (print_object):
3048 * xdisp.c (message_dolog):
3049 * xfns.c (syms_of_xfns):
3050 Use sprintf or float_to_string result to avoid need to call strlen.
3051 * data.c (Fnumber_to_string):
3052 Use make_unibyte_string, since the string must be ASCII.
3053 * lisp.h, print.c (float_to_string): Now returns int length.
3054 * term.c (produce_glyphless_glyph):
3055 Use sprintf result rather than recomputing it.
3056
cf38a720
PE
3057 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3058 * Makefile.in (ALL_CFLAGS):
3059 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3060 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3061
3511c784
DA
30622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3063
0a08eb21 3064 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3065 strcasecmp if available.
3066 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3067
fb7da12e
AS
30682012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3069
3070 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3071 Avoid comma operator.
3072 * menu.c (push_submenu_start, push_submenu_end)
3073 (push_left_right_boundary, push_menu_pane): Likewise.
3074 * msdos.c (dos_rawgetc): Likewise.
3075
afa2ffd8
DA
30762012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3077
3078 * xfns.c (xic_create_fontsetname): Remove redundant calls
3079 to memset.
3080
b3b4476b
PE
30812012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3082
4495ff38
PE
3083 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3084 sprintf already null-terminates its output.
3085
b3b4476b
PE
3086 * xfns.c (x_window): Remove redundant cast.
3087
b00876c9
DA
30882012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3089
3090 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3091 `const char *' to `char *' to avoid compiler warning.
3092
d188e26b
PE
30932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3094
885d1d74
PE
3095 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3096 instead of truncating it to 63 (admittedly a generous limit).
3097
d188e26b
PE
3098 * process.c: Fix spelling and caps in comments.
3099
e2f560b1
DN
31002012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3101
e86db54b 3102 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3103 * sysdep.c (setpgrp): Remove definition, not used in this file.
3104
7583a3a1
JB
31052012-06-24 Juanma Barranquero <lekktu@gmail.com>
3106
3107 * makefile.w32-in: Update dependencies.
3108
696056c2
EZ
31092012-06-24 Eli Zaretskii <eliz@gnu.org>
3110
3111 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3112 (SYSTIME_H): Add nt/inc/sys/time.h.
3113
3114 * systime.h [WINDOWSNT]: Include sys/time.h.
3115
3116 * s/ms-w32.h (struct timespec): Definition moved from
3117 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3118
845ca893
PE
31192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3122 * buffer.h (buffer_slot_type_mismatch):
3123 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3124 * eval.c (unwind_to_catch):
3125 * image.c (my_png_error, my_error_exit):
3126 * keyboard.c (quit_throw_to_read_char, user_error)
3127 (Fexit_recursive_edit, Fabort_recursive_edit):
3128 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3129 (wrong_type_argument, buffer_overflow, __executable_start)
3130 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3131 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3132 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3133 (fatal):
3134 (child_setup) [!DOS_NT]:
3135 * lread.c (end_of_file_error, invalid_syntax):
3136 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3137 * puresize.h (pure_write_error):
3138 * search.c (matcher_overflow):
3139 * sound.c (sound_perror, alsa_sound_perror):
3140 * sysdep.c, syssignal.h (croak):
3141 * term.c (maybe_fatal, vfatal):
3142 * textprop.c (text_read_only):
3143 * undo.c (user_error):
3144 * unexmacosx.c (unexec_error):
3145 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3146 Use _Noreturn rather than NO_RETURN.
3147 No need for separate decl merely because of _Noreturn.
3148 * sound.c (sound_warning, parse_sound):
3149 Remove unnecessary forward decls.
3150
f1dd8073
PE
31512012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3154 * lisp.h (WAIT_READING_MAX): New macro.
3155 * dispnew.c (Fsleep_for, sit_for):
3156 * keyboard.c (kbd_buffer_get_event):
3157 * process.c (Faccept_process_output):
3158 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3159 This improves on the previous patch, which introduced a bug
3160 when time_t is unsigned and as wide as intmax_t.
3161 See <http://bugs.gnu.org/9000#51>.
3162
b82c1755
EZ
31632012-06-23 Eli Zaretskii <eliz@gnu.org>
3164
3165 * dispnew.c (sit_for, Fsleep_for):
3166 * keyboard.c (kbd_buffer_get_event):
3167 * process.c (Faccept_process_output): Avoid compiler warnings when
3168 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3169
ca300656
JB
31702012-06-23 Juanma Barranquero <lekktu@gmail.com>
3171
049ec95b
JB
3172 * makefile.w32-in: Update dependencies.
3173
ca300656
JB
3174 * w32.c (ltime): Add return type and declare static.
3175 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3176
db7b8d06
PE
31772012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3178
3179 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3180 Privately reported by Herbert J. Skuhra.
3181 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3182 All uses changed.
3183 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3184 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3185
0bd8297f
EZ
31862012-06-23 Eli Zaretskii <eliz@gnu.org>
3187
96512555
EZ
3188 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3189 last argument of make_unibyte_string.
3190
0bd8297f
EZ
3191 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3192 language ID in the event parameters.
3193
3194 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3195 event.code, not the obscure "character set ID".
3196
63def6b6
CY
31972012-06-23 Chong Yidong <cyd@gnu.org>
3198
3199 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3200
e8a02204
EZ
32012012-06-23 Eli Zaretskii <eliz@gnu.org>
3202
388cdec0
EZ
3203 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3204 * w32.c (fdutimens): New function.
3205
3206 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3207
3208 * s/ms-w32.h (pselect): Redirect to sys_select.
3209
3210 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3211
e8a02204
EZ
3212 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3213 in the logic of incrementing and decrementing the value of
3214 use_relocatable_buffers.
3215
d054f3fb
PE
32162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3217
3218 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3219 Privately reported by Herbert J. Skuhra.
3220 [__FreeBSD__]: Remove "*/" typo after "#include".
3221 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3222 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3223 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3224 Don't assume EMACS_TIME and struct timeval are the same type.
3225
d35af63c
PE
32262012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 Support higher-resolution time stamps (Bug#9000).
3229 The time stamps are only nanosecond-resolution at the C level,
3230 since that's the best that any real-world system supports now.
3231 But they are picosecond-resolution at the Lisp level, as that's
3232 easy, and leaves room for future OS improvements.
3233
3234 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3235 (LIBES): Use it.
3236
3237 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3238 Don't get current time unless it's needed.
3239
3240 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3241 now provides it if it's absent.
3242 (start_atimer): Port to higher-res time stamps.
3243 Check for time stamp overflow. Don't get current time more
3244 often than is needed.
3245
3246 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3247 Include systime.h, not time.h.
3248 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3249
3250 * dired.c: Include stat-time.h.
3251 (Ffile-attributes): File times now have higher resolution.
3252
3253 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3254 (struct image): Timestamp now has higher resolution.
3255
3256 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3257 has at least microseconds now. All uses removed.
3258 (update_frame, update_single_window, update_window, update_frame_1)
3259 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3260
3261 * editfns.c (time_overflow): Now extern.
3262 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3263 (float-time, Fformat_time_string, Fcurrent_time_string)
3264 (Fcurrent_time_zone): Accept and generate higher-resolution
3265 time stamps.
3266 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3267 (decode_time_components, lisp_seconds_argument): New functions.
3268 (make_time): Now static.
3269 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3270 Report an error if the time is invalid, rather than having the caller
3271 do that.
3272
3273 * fileio.c: Include <stat-time.h>
3274 (Fcopy_file): Copy higher-resolution time stamps.
3275 Prefer to set the time stamp via a file descriptor if that works.
3276 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3277 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3278 (Fvisited_file_modtime, Fset_visited_file_modtime):
3279 Support higher-resolution time stamps.
3280
3281 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3282
3283 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3284
3285 * image.c (prepare_image_for_display, clear_image_cache)
3286 (lookup_image): Port to higer-resolution time stamps.
3287
3288 * keyboard.c (start_polling, bind_polling_period):
3289 Check for time stamp overflow.
3290 (read_char, kbd_buffer_get_event, timer_start_idle)
3291 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3292 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3293 Port to higher-resolution time stamps. Do not assume time_t is signed.
3294 (decode_timer): New function. Timers are now vectors of length 9,
3295 not 8, to accommodate the picosecond component.
3296 (timer_check_2): Use it.
3297
3298 * nsterm.m (select_timeout, timeval_subtract): Remove.
3299 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3300 as they're a bit more accurate and handle overflow better.
3301 (ns_select): Change prototype to be compatible with pselect.
3302 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3303 * nsterm.h (ns_select): Adjust prototype.
3304
3305 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3306 us-resolution time stamps.
3307 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3308
3309 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3310
3311 * lisp.h (time_overflow): New decl.
3312 (wait_reading_process_output): First arg is now intmax_t, not int,
3313 to accommodate larger waits.
3314
3315 * process.h (struct Lisp_Process.read_output_delay):
3316 Now counts nanoseconds, not microseconds.
3317 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3318 EMACS_HAS_USECS.
3319 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3320 (wait_reading_process_output):
3321 Port to ns-resolution time stamps.
3322 (Faccept_process_output, wait_reading_process_output):
3323 Check for time stamp overflow. Do not assume time_t is signed.
3324 (select_wrapper): Remove; we now use pselect.
3325 (Fprocess_attributes): Now generates ns-resolution time stamps.
3326
3327 * sysdep.c: Include utimens.h. Don't include utime.h
3328 or worry about struct utimbuf; gnulib does that for us now.
3329 (gettimeofday): Remove; gnulib provides a substitute.
3330 (make_timeval): New function.
3331 (set_file_times): Now sets ns-resolution time stamps.
3332 New arg FD; all uses changed.
3333 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3334 (system_process_attributes):
3335 Now returns ns-resolution time stamp. All uses changed.
3336 Check for time stamp overflow.
3337
3338 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3339 provides a substitute now.
3340
3341 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3342 since it guarantees struct timespec.
3343 (EMACS_TIME): Now struct timespec, so that we can support
3344 ns-resolution time stamps.
3345 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3346 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3347 (EMACS_USECS): Remove.
3348 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3349 so multiply the arg by 1000 before storing it.
3350 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3351 New macros.
3352 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3353 Port to ns-resolution time stamps.
3354 (EMACS_TIME_NEG_P): Remove; replaced by....
3355 (EMACS_TIME_SIGN): New macro.
3356 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3357 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3358 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3359 (make_timeval, make_lisp_time, decode_time_components): New decls.
3360 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3361 that it mishandled time_t overflow. You can't compare by subtracting!
3362 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3363 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3364
3365 * term.c: Include <sys/time.h>.
3366 (timeval_to_Time): New function, for proper overflow wraparound.
3367 (term_mouse_position, term_mouse_click): Use it.
3368
3369 * undo.c (record_first_change): Support higher-resolution time stamps
3370 in the undo buffer.
3371 (Fprimitive_undo): Use them when restoring time stamps.
3372
3373 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3374 (w32_get_internal_run_time):
3375 Port to higher-resolution Emacs time stamps.
3376 (ltime): Now accepts single 64-bit integer, as that's more convenient
3377 for callers.
3378
3379 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3380
3381 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3382 for compatibility with pselect. Support ns-resolution time stamps.
3383
3384 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3385
3386 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3387 Check for time stamp overflow, and support ns-resolution time stamps.
3388
3389 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3390 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3391 (timeval_subtract): Remove; no longer needed.
3392 (XTflash, XTring_bell, x_wait_for_event):
3393 Port to ns-resolution time stamps. Don't assume time_t is signed.
3394
b6a92dfe
CY
33952012-06-22 Chong Yidong <cyd@gnu.org>
3396
3397 * xdisp.c (x_consider_frame_title): Revert last change.
3398
d251c37c
EZ
33992012-06-22 Eli Zaretskii <eliz@gnu.org>
3400
3401 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3402 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3403 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3404 staticidx goes up to 1597 out of 1600 = 0x640.)
3405
f10deafb
PE
34062012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3407
3408 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3409 Otherwise, the umask might be mistakenly 0 while handling input signals.
3410
ec6de1e2
SM
34112012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3412
3413 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3414
28be1ada
DA
34152012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3416
3417 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3418 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3419 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3420 access to `contents' member of Lisp_Vector objects with AREF and ASET
3421 where appropriate.
3422
c6bf3022
CY
34232012-06-19 Chong Yidong <cyd@gnu.org>
3424
3425 * frame.c (delete_frame): When selecting a frame on a different
3426 text terminal, do not alter the terminal's top-frame.
3427
3428 * xdisp.c (format_mode_line_unwind_data): Record the target
3429 frame's selected window and its terminal's top-frame.
3430 (unwind_format_mode_line): Restore them.
3431 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3432 Callers changed.
3433 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3434 since tty frames can be explicitly named.
3435 (prepare_menu_bars): Likewise.
3436
3437 * term.c (Ftty_top_frame): New function.
3438
defd4196
PE
34392012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 Port byte-code-meter to modern targets.
3442 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3443 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3444 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3445 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3446 (METER_1, METER_2): Simplify.
3447
1053a871
SM
34482012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3449
3450 * data.c (Fdefalias): Return `symbol' (bug#11686).
3451
b7e8d081
MR
34522012-06-18 Martin Rudalics <rudalics@gmx.at>
3453
3454 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3455 gets killed during executing of this function (Bug#11665).
3456 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3457 (Vkill_buffer_query_functions): In doc-string say that functions
3458 run by this hook should not change the current buffer.
3459
7ea2b339
PE
34602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3461
3462 Fix recently-introduced process.c problems found by static checking.
3463 * process.c (write_queue_push, write_queue_pop, send_process):
3464 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3465 (write_queue_pop): Fix pointer signedness problem.
3466 (send_process): Remove unused local.
3467
96a313a1
CY
34682012-06-17 Chong Yidong <cyd@gnu.org>
3469
3470 * xdisp.c (redisplay_internal): No need to redisplay terminal
3471 frames that are not on top.
3472
20ca2e94
TN
34732012-06-17 Troels Nielsen <bn.troels@gmail.com>
3474
3475 * process.c (make_process): Initialize write_queue.
3476 (write_queue_push, write_queue_pop): New functions.
3477 (send_process): Use them to maintain correct ordering of process
3478 writes (Bug#10815).
3479
9a900ca9
PE
34802012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3481
310fbfa8
PE
3482 * lisp.h (eassert): Assume C89 or later.
3483 This removes the need for CHECK.
3484 (CHECK): Remove. Its comments about always evaluating its
3485 argument were confusing, as 'eassert' typically does not evaluate
3486 its argument.
3487
27bb1ca4
PE
3488 * coding.c (produce_chars): Use ptrdiff_t, not int.
3489
9a900ca9
PE
3490 * xterm.c (x_draw_underwave): Check for integer overflow.
3491 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3492
41b7f8bc 34932012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3494
3495 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3496 referenced (Bug#11583).
3497
9b0e3eba
AA
34982012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3499
3500 Implement wave-style variant of underlining.
3501 * dispextern.h (face_underline_type): New enum.
3502 (face): Add field for underline type.
3503 * nsterm.m (ns_draw_underwave): New function.
3504 (ns_draw_text_decoration): Use it.
3505 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3506 New functions.
3507 (x_draw_glyph_string): Use them.
3508 * xfaces.c (Qline, Qwave): New Lisp objects.
3509 (check_lface_attrs, merge_face_ref)
1053a871
SM
3510 (Finternal_set_lisp_face_attribute, realize_x_face):
3511 Handle wave-style underline face attributes.
9b0e3eba
AA
3512 * xterm.c (x_draw_underwave): New function.
3513 (x_draw_glyph_string): Use it.
3514
0fb52f11
JB
35152012-06-16 Juanma Barranquero <lekktu@gmail.com>
3516
3517 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3518 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3519 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3520 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3521 ($(BLD)/w32select.$(O)): Update dependencies.
3522
e5560ff7
AS
35232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3524
3525 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3526 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3527 * character.c (_fetch_multibyte_char_p): Remove.
3528 * alloc.c: Include "character.h" before "buffer.h".
3529 * bidi.c: Likewise.
3530 * buffer.c: Likewise.
3531 * bytecode.c: Likewise.
3532 * callint.c: Likewise.
3533 * callproc.c: Likewise.
3534 * casefiddle.c: Likewise.
3535 * casetab.c: Likewise.
3536 * category.c: Likewise.
3537 * cmds.c: Likewise.
3538 * coding.c: Likewise.
3539 * composite.c: Likewise.
3540 * dired.c: Likewise.
3541 * dispnew.c: Likewise.
3542 * doc.c: Likewise.
3543 * dosfns.c: Likewise.
3544 * editfns.c: Likewise.
3545 * emacs.c: Likewise.
3546 * fileio.c: Likewise.
3547 * filelock.c: Likewise.
3548 * font.c: Likewise.
3549 * fontset.c: Likewise.
3550 * fringe.c: Likewise.
3551 * indent.c: Likewise.
3552 * insdel.c: Likewise.
3553 * intervals.c: Likewise.
3554 * keyboard.c: Likewise.
3555 * keymap.c: Likewise.
3556 * lread.c: Likewise.
3557 * macros.c: Likewise.
3558 * marker.c: Likewise.
3559 * minibuf.c: Likewise.
3560 * nsfns.m: Likewise.
3561 * nsmenu.m: Likewise.
3562 * print.c: Likewise.
3563 * process.c: Likewise.
3564 * regex.c: Likewise.
3565 * region-cache.c: Likewise.
3566 * search.c: Likewise.
3567 * syntax.c: Likewise.
3568 * term.c: Likewise.
3569 * textprop.c: Likewise.
3570 * undo.c: Likewise.
3571 * unexsol.c: Likewise.
3572 * w16select.c: Likewise.
3573 * w32fns.c: Likewise.
3574 * w32menu.c: Likewise.
3575 * window.c: Likewise.
3576 * xdisp.c: Likewise.
3577 * xfns.c: Likewise.
3578 * xmenu.c: Likewise.
3579 * xml.c: Likewise.
3580 * xselect.c: Likewise.
3581
2f07e6af
EZ
35822012-06-16 Eli Zaretskii <eliz@gnu.org>
3583
1053a871
SM
3584 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3585 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3586 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3587 row.
3588 (handle_face_prop): Use chunk-relative overlay string index when
3589 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3590 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3591 the rightmost. (Bug#11720)
2f07e6af 3592
29b83cec
AS
35932012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3594
3595 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3596 (CATEGORY_MEMBER): Enforce 1/0 value.
3597 * category.c (_temp_category_set): Remove.
3598
4c5501e9
EZ
35992012-06-16 Eli Zaretskii <eliz@gnu.org>
3600
3601 * window.c (Fdelete_other_windows_internal)
3602 (Fdelete_window_internal): Don't access frame's mouse highlight
3603 info of the initial frame. (Bug#11677)
3604
2b570124
PE
36052012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3606
e93864f9
PE
3607 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3608 Assume USE_2_TAGS_FOR_INTS.
3609 (xreload): Adjust $tagmask width to match recent lisp.h change.
3610
2b570124
PE
3611 Simplify lisp.h in minor ways that should not affect code.
3612 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3613 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3614 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3615 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3616 (INTTYPEBITS): New macro, for clarity.
3617 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3618 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3619 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3620 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3621 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3622
81755f69
JB
36232012-06-13 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3626
16192a57
GM
36272012-06-13 Glenn Morris <rgm@gnu.org>
3628
3629 * s/bsd-common.h (BSD4_3):
3630 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3631
646b5f55
AS
36322012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3633
3634 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3635 instead of union.
3636 (XLI, XIL): Define.
1053a871
SM
3637 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3638 Use them.
3639 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3640 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3641 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3642 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3643 * frame.c (delete_frame): Remove outdated comment.
3644 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3645 USE_LISP_UNION_TYPE.
3646 (Fw32_unregister_hot_key): Likewise.
3647 (Fw32_toggle_lock_key): Likewise.
3648 * w32menu.c (add_menu_item): Likewise.
3649 (w32_menu_display_help): Use XIL instead of checking
3650 USE_LISP_UNION_TYPE.
3651 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3652 (init_heap): Likewise.
3653 * w32term.c (w32_read_socket): Update comment.
3654
1d3823c9
GM
36552012-06-13 Glenn Morris <rgm@gnu.org>
3656
c62ff706
GM
3657 * s/usg5-4-common.h, src/s/unixware.h:
3658 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3659
1d3823c9
GM
3660 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3661
bfe3e0a2
PE
36622012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3663
3664 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3665 * alloc.c (make_number) [!defined make_number]:
3666 Remove, as lisp.h always defines this now.
3667 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3668 (roundup_size): Verify that it is a power of 2.
3669 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3670 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3671 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3672 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3673 USE_LSB_TAG now is always defined to be either 0 or 1.
3674 All uses changed.
3675 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3676 code works fine either way, and efficiency is not a concern here,
3677 as the union type is for debugging, not for production.
3678 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3679 Use an inline function on all platforms when using the union type,
3680 since this is simpler and 'static inline' can be used portably
3681 within Emacs now.
3682 (LISP_INITIALLY_ZERO): New macro.
3683 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3684 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3685
45fa9c0f
GM
36862012-06-12 Glenn Morris <rgm@gnu.org>
3687
b4492cba
GM
3688 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3689
3690 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3691
45fa9c0f
GM
3692 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3693 Move BROKEN_SIGIO to configure.
3694
3695 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3696 Move NO_TERMIO to configure.
3697
0e25d334
CY
36982012-06-12 Chong Yidong <cyd@gnu.org>
3699
3700 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3701 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3702 MagickExportImagePixels is undefined.
3703
43682bb6
PE
37042012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3705
3706 * image.c (imagemagick_load_image): Remove unused label.
3707
a9be7d2b
GM
37082012-06-11 Glenn Morris <rgm@gnu.org>
3709
3710 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3711 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3712 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3713 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3714
3017f87f
SM
37152012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3716
3717 * alloc.c (make_byte_code): New function.
3718 (Fmake_byte_code): Use it. Don't purify here.
3719 * lread.c (read1): Use it as well to avoid extra allocation.
3720
1b9b4cf4
CY
37212012-06-11 Chong Yidong <cyd@gnu.org>
3722
3723 * image.c (imagemagick_load_image): Implement transparency.
3724
95988fcf
AS
37252012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3726
3727 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3728 account for preceding backslashes. (Bug#11663)
3729
cd4eb164
CY
37302012-06-09 Chong Yidong <cyd@gnu.org>
3731
3732 * term.c: Support italics in capable terminals (Bug#9652).
3733 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3734 (turn_on_face): Output using TS_enter_italic_mode if available.
3735 Don't handle unused blinking and alt-charset cases.
3736 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3737 and tty_alt_charset_p cases.
3738 (tty_capable_p, init_tty): Support italics.
3739
3740 * termchar.h (struct tty_display_info): Add field for italics.
3741 Remove unused blink field.
3742
3743 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3744 Handle slant.
3745
3746 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3747 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3748 tty_alt_charset_p. Add tty_italic_p.
3749
ff88beb8
MA
37502012-06-09 Michael Albinus <michael.albinus@gmx.de>
3751
3752 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3753 dbus_type_is_basic if available.
3754 (xd_extract_signed, xd_extract_unsigned): Rename from
3755 extract_signed and extract_unsigned, respectively. Adapt callers.
3756
44286096
CY
37572012-06-09 Chong Yidong <cyd@gnu.org>
3758
1682701f
CY
3759 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3760
44286096
CY
3761 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3762 case (Bug#9752).
3763
d86feb17
PE
37642012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3765
3766 * xdisp.c (vmessage): Treat frame message as multibyte.
3767 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3768 would generate the diagnostic "Making \302\247 buffer-local while
3769 let-bound!".
3770
d5c20fe8
EZ
37712012-06-08 Eli Zaretskii <eliz@gnu.org>
3772
3773 * dispnew.c (showing_window_margins_p): Undo last change, which
3774 was done due to an inadvertent commit.
3775 (adjust_frame_glyphs_for_frame_redisplay): Do call
3776 showing_window_margins_p.
3777
513749ee
SM
37782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3779
3780 * eval.c (Fmake_var_non_special): New primitive.
3781 (syms_of_eval): Defsubr it.
3782 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3783
d4a8f5c1
JB
37842012-06-08 Juanma Barranquero <lekktu@gmail.com>
3785
3786 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3787 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3788
8bbbc977
EZ
37892012-06-08 Eli Zaretskii <eliz@gnu.org>
3790
3791 * alloc.c (allocate_vectorlike): Fix last change.
3792
f3372c87
DA
37932012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3794
3795 Block-based vector allocation of small vectors.
3796 * lisp.h (struct vectorlike_header): New field `nbytes',
3797 adjust comment accordingly.
3798 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3799 to denote vector blocks. Adjust users (live_vector_p,
3800 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3801 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3802 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3803 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3804 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3805 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3806 (roundup_size): New constant.
3807 (struct vector_block): New data type.
3808 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3809 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3810 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3811 (sweep_vectors): New functions.
3812 (allocate_vectorlike): Return `zero_vector' as the only vector of
3813 0 items. Allocate new vector from block if vector size is less than
3814 or equal to VBLOCK_BYTES_MAX.
3815 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3816 (init_alloc_once): Add call to init_vectors.
3817
4f18a4ed
SM
38182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3819
3820 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3821
86f158bc
PE
38222012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 * doprnt.c (doprnt): Truncate multibyte char correctly.
3825 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3826 would mishandle a string argument "Xc" if X was a multibyte
3827 character of length 2: it would truncate after X's first byte
3828 rather than including all of X.
3829
c5cfcbe0
CY
38302012-06-06 Chong Yidong <cyd@gnu.org>
3831
3832 * buffer.c (word_wrap): Doc fix.
3833
c05cf390
PE
38342012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3837
0c3461de
GM
38382012-06-03 Glenn Morris <rgm@gnu.org>
3839
3840 * xdisp.c (tool-bar-style): Doc fix.
3841
c71232db
UM
38422012-06-03 Ulrich Müller <ulm@gentoo.org>
3843
3844 * Makefile.in (PAXCTL): Define.
3845 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3846 binary via PaX flags if the paxctl utility is available.
3847 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3848 Restore PaX flags to their default. (Bug#11398)
3849
383f7350
CY
38502012-06-03 Chong Yidong <cyd@gnu.org>
3851
3852 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3853 buffer (Bug#11226).
3854
5f2c76c6
CY
38552012-06-03 Chong Yidong <cyd@gnu.org>
3856
3857 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3858 (note_mode_line_or_margin_highlight): If there is no help echo,
3859 use mode-line-default-help-echo. Handle the case where the mouse
3860 position is past the end of the mode line string.
3861
3862 * buffer.c (buffer_local_value_1): New function, split from
3863 Fbuffer_local_value; can return Qunbound.
3864 (Fbuffer_local_value): Use it.
3865 (Vmode_line_format): Docstring tweaks.
3866
773d47f6
PE
38672012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 * sysdep.c (system_process_attributes): Improve comment.
3870
f2d6a3df
SM
38712012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3872
3873 * keyboard.c: Export real-this-command to Elisp.
3874 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3875 and DEFVAR it. Update all users.
3876
63810350
PE
38772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3878
7bd5c1f4
PE
3879 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3880
63810350
PE
3881 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3882 Convert pctcpu and pctmem to Lisp float properly.
3883 Let the compiler fold better, as 100.0/0x8000 is exact.
3884
a2821611
AS
38852012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3886
3887 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3888 cons_block.
3889
5fceba1d
PE
38902012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3893
c98ff5dd
DA
38942012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3895
3896 For a 'struct window', replace some Lisp_Object fields to
3897 bitfields where appropriate, remove unused fields.
3898 * window.h (struct window): Remove unused 'last_mark_x' and
3899 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3900 change it's type from Lisp_Object to bitfield.
3901 Change type of 'force_start', 'optional_new_start',
3902 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3903 fields from Lisp_Object to bitfield. Adjust users accordingly.
3904
ca34e0be
PE
39052012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3906
3907 Pacify gcc -Wdouble-precision when using Xaw.
3908 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3909 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3910 Use 'float' consistently, rather than 'float' in most places
3911 and 'double' in a couple of places.
3912
efc00ab1 39132012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3914
3915 * xdisp.c (handle_stop): Detect whether we have overlay strings
3916 loaded by testing it->current.overlay_string_index to be
3917 non-negative, instead of checking whether n_overlay_strings is
3918 positive. (Bug#11587)
3919
efc00ab1 39202012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3921
3922 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3923
3924 * doc.c (Fsubstitute_command_keys): Doc fix.
3925
efc00ab1 39262012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3927
3928 * search.c (search_buffer): Remove calls to
3929 r_alloc_inhibit_buffer_relocation, as it is now called by
3930 maybe_unify_char, which was the cause of relocation of buffer text
3931 in bug#11519.
3932
efc00ab1 39332012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3934
3935 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3936 for the duration of call to load_charset, to avoid problems with
3937 callers of maybe_unify_char that access buffer text through C
3938 pointers.
3939
3940 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3941 decrement the inhibition flag, instead of just setting or
3942 resetting it.
3943
ba93a187
PE
39442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 Remove obsolete '#define static' cruft.
3947 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3948 This #undef was "temporary" in 2000; it is no longer needed
3949 now that '#define static' has gone away.
3950 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3951 (gray_bitmap_bits): Remove; no longer needed.
3952 All uses replaced with definiens.
3953 * xterm.c: Include "bitmaps/gray.xbm".
3954
9e4bf381
PE
39552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3956
3957 Clean up __executable_start, monstartup when --enable-profiling.
3958 The following changes affect the code only when profiling.
3959 * dispnew.c (__executable_start): Rename from safe_bcopy.
3960 Define only on platforms that need it.
3961 * emacs.c: Include <sys/gmon.h> when profiling.
3962 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3963 (__executable_start): Remove decl, since lisp.h does it now.
3964 (safe_bcopy): Remove decl; no longer has that name.
3965 (main): Coalesce #if into single bit of code, for simplicity.
3966 Cast pointers to uintptr_t, since standard libraries want integers
3967 and not pointers.
3968 * lisp.h (__executable_start): New decl.
3969
32d72c2f
GM
39702012-05-31 Glenn Morris <rgm@gnu.org>
3971
3972 * image.c (Fimagemagick_types): Doc fix.
3973
baac5bc7
JM
39742012-05-30 Jim Meyering <meyering@redhat.com>
3975
3976 * callproc.c (Fcall_process_region): Include directory component
3977 in mkstemp error message (Bug#11586).
3978
72cb32cf
PE
39792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3980
3981 * alloc.c, lisp.h (make_pure_vector): Now static.
3982
61b108cc
SM
39832012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3984
3985 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3986 Move to byte-run.el.
3987 (Fautoload): Do the hash-doc more carefully.
3988 * data.c (Fdefalias): Purify definition, except for keymaps.
3989 (Qdefun): Move from eval.c.
3990 * lisp.h (Qdefun): Remove.
3991 * lread.c (read1): Tiny simplification.
3992
471fe23d
TN
39932012-05-29 Troels Nielsen <bn.troels@gmail.com>
3994
934f3f58 3995 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3996 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3997 Bug#9642, but explicitly check that the buffer the overlay would
3998 be moved to is live and rearrange lines to make sure that errors
3999 will not put the overlay in an inconsistent state.
4000 (Fdelete_overlay): Cosmetics.
4001
85d0efd1
EZ
40022012-05-28 Eli Zaretskii <eliz@gnu.org>
4003
4004 * w32term.c (my_bring_window_to_top): New function.
4005 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4006 could be different from the original one.
4007 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4008 (Bug#11513)
4009
4010 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4011 by calling BringWindowToTop.
4012
4013 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4014 (WM_EMACS_END): Increase by one.
4015
da92a98c
PE
40162012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4017
4018 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4019 This avoids undefined behavior that might cause the eassert
4020 to not catch an out-of-range value.
4021
74d1f848
JB
40222012-05-28 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4025 Update dependencies.
4026
9e1a06fc
EZ
40272012-05-27 Eli Zaretskii <eliz@gnu.org>
4028
4029 * bidi.c (bidi_mirror_char): Fix last change.
4030
f3dd7312
AS
40312012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4032
4033 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4034 when referring to sectname field in printf format.
4035
81899c91
PE
40362012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4037
57b81a9f
PE
4038 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4039 Only r_alloc_inhibit_buffer_relocation needed to be added;
4040 the others were already declared.
4041
81899c91
PE
4042 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4043 before checking whether it's out of range. Put the check inside
4044 eassert. See
4045 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4046
33017faf 40472012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4048
4049 * callproc.c (Fcall_process): Restore a line that was accidentally
4050 commented out in the 2011-02-13 change (bug#11547).
4051
33017faf 40522012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4053
4054 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4055 defined on ralloc.c.
4056
4057 * buffer.c [REL_ALLOC]: Remove prototypes of
4058 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4059 they are now on lisp.h.
4060
4061 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4062
4063 * search.c (search_buffer): Use it to inhibit relocation of buffer
4064 text while re_search_2 is doing its job, because re_search_2 is
4065 passed C pointers to buffer text. (Bug#11519)
4066
23415acf
EZ
4067 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4068 Update value to 24.
4069
44e27368
EZ
4070 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4071 state after an additional call to move_it_in_display_line_to, keep
4072 the values of it->max_ascent and it->max_descent found for the
4073 entire line.
4074 (pos_visible_p): Revert the comparison against bottom_y to what it
4075 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4076 (Bug#11464)
4077
c1892f11
PE
40782012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 Fix coding-related core dumps with gcc -ftrapv.
4081 The code was computing A - B, where A and B are pointers, and B is
4082 random garbage. This can lead to core dumps on platforms that
4083 have special pointer registers, and it also leads to core dumps on
4084 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4085 A - B only when B is initialized properly.
4086 * coding.c (coding_set_source, coding_set_destination): Return void.
4087 (coding_change_source, coding_change_destinations): New functions,
4088 with the old behaviors of coding_set_source and coding_set_destination.
4089 All callers that need an offset changed to use these new functions.
4090
eb7afdad
GM
40912012-05-26 Glenn Morris <rgm@gnu.org>
4092
4093 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4094
f12fdf02
EZ
40952012-05-26 Eli Zaretskii <eliz@gnu.org>
4096
53a63be6 4097 Extend mouse support on W32 text-mode console.
61b108cc
SM
4098 * xdisp.c (draw_row_with_mouse_face):
4099 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4100
eb3f6f01 4101 * w32console.c: Include window.h.
61b108cc
SM
4102 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4103 New functions.
eb3f6f01
EZ
4104 (initialize_w32_display): Initialize mouse-highlight data.
4105
53a63be6
EZ
4106 * w32inevt.c: Include termchar.h and window.h.
4107 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4108 moves, call note_mouse_highlight. If help_echo changed, call
4109 gen_help_event to produce help-echo message in the echo area.
4110 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4111 highlight info.
4112
4cfd81f6
PE
41132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4114
4115 * lread.c (read1): Simplify slightly to avoid an overflow warning
4116 with GCC 4.7.0 on x86-64.
4117
4446092a
EZ
41182012-05-26 Eli Zaretskii <eliz@gnu.org>
4119
4120 * bidi.c (bidi_mirror_char): Revert last change: an int is
4121 definitely wide enough here.
4122
42b2a986 41232012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4124
42b2a986 4125 Fix integer width and related bugs (Bug#9874).
eb106a49 4126 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4127 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4128 (string_bytes, check_sblock, allocate_string_data):
4129 (compact_small_strings, Fmake_bool_vector, make_string)
4130 (make_unibyte_string, make_multibyte_string)
4131 (make_string_from_bytes, make_specified_string)
4132 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4133 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4134 (mark_vectorlike):
4135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4136 (allocate_pseudovector):
4137 Use int, not EMACS_INT, where int is wide enough.
4138 (inhibit_garbage_collection, Fgarbage_collect):
4139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4140 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4141 int might not be wide enough.
4142 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4143 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4144 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4145 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4146 (bidi_level_of_next_char, bidi_move_to_visually_next):
4147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4148 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4149 (Fkill_buffer, Fset_buffer_major_mode)
4150 (advance_to_char_boundary, Fbuffer_swap_text)
4151 (Fset_buffer_multibyte, overlays_at, overlays_in)
4152 (overlay_touches_p, struct sortvec, record_overlay_string)
4153 (overlay_strings, recenter_overlay_lists)
4154 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4155 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4156 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4157 (Foverlay_recenter, last_overlay_modification_hooks_used)
4158 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4160 (validate_region): Omit unnecessary test for b <= e,
4161 since that's guaranteed by the previous test.
d311d28c
PE
4162 (adjust_overlays_for_delete): Avoid pos + length overflow.
4163 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4164 (report_overlay_modification):
4165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4166 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4167 Omit pointer cast, which isn't needed anyway, and doesn't work
4168 after the EMACS_INT -> ptrdiff_t change.
02481186 4169 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4170 * buffer.h: Adjust decls to match defn changes elsewhere.
4171 (struct buffer_text, struct buffer):
4172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4173 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4174 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4175 not int, to avoid needless 32-bit limit on 64-bit hosts.
4176 (exec_byte_code): Use tighter memory-full test, one that checks
4177 for alloca overflow. Don't compute the address of the object just
4178 before an array, as that's not portable. Use EMACS_INT, not
4179 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4180 * callint.c (Fcall_interactively):
4181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4182 * callproc.c (call_process_kill, Fcall_process):
4183 Don't assume pid_t fits into an Emacs fixnum.
4184 (call_process_cleanup, Fcall_process, child_setup):
4185 Don't assume pid_t fits into int.
4186 (call_process_cleanup, Fcall_process, delete_temp_file)
4187 (Fcall_process_region):
4188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4189 (Fcall_process): Simplify handling of volatile integers.
4190 Use int, not EMACS_INT, where int will do.
4191 * casefiddle.c (casify_object, casify_region, operate_on_word)
4192 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4194 (casify_object): Avoid integer overflow when overallocating buffer.
4195 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4196 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4197 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4198 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4199 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4200 integers are now checked earlier. All uses replaced with XINT.
4201 (ccl_driver):
4202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4203 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4204 (ccl_driver, Fregister_code_conversion_map):
4205 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4206 (resolve_symbol_ccl_program): Check that vector header is in range.
4207 Always copy the vector, so that we can check its contents reliably
4208 now rather than having to recheck each instruction as it's being
4209 executed. Check that vector words fit in 'int'.
4210 (ccl_get_compiled_code, Fregister_ccl_program)
4211 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4212 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4213 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4214 contents are in range.
4215 (Fccl_execute_on_string): Check that status is in range.
4216 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4217 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4218 Accept and return EMACS_INT, not int, because callers can pass values
4219 out of 'int' range.
4220 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4221 (multibyte_chars_in_text, parse_str_as_multibyte)
4222 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4223 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4224 (string_escape_byte8, Fget_byte):
4225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4226 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4227 avoid mishandling large integers.
4228 * character.h: Adjust decls to match defn changes elsewhere.
4229 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4230 (Ffind_charset_region):
4231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4232 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4233 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4234 Don't assume fixnum fits in int.
d311d28c
PE
4235 (load_charset_map_from_vector, Fmap_charset_chars):
4236 Remove now-unnecessary CHECK_NATNUMs.
4237 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4238 Don't rely on undefined behavior with signed left shift overflow.
4239 Don't assume unsigned int fits into fixnum, or that fixnum fits
4240 into unsigned int. Don't require max_code to be a valid fixnum;
4241 that's not true for gb10830 4-byte on a 32-bit host. Allow
4242 invalid_code to be a cons, for the same reason. Require code_offset
4243 to be a character. Avoid int overflow if max_char is close
4244 to INT_MAX.
4245 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4246 this is intended anyway and avoids some undefined behavior.
4247 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4248 INDEX_TO_CODE_POINT, as that's what it expects.
4249 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4250 * charset.h (DECODE_CHAR): Return int, not unsigned;
4251 this is what was intended anyway, and it avoids undefined behavior.
4252 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4253 integer-overflow issues.
4254 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4255 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4256 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4257 * chartab.c (Fmake_char_table, Fset_char_table_range)
4258 (uniprop_get_decoder, uniprop_get_encoder):
4259 Don't assume fixnum fits in int.
4260 * cmds.c (move_point): New function, that does the gist of
4261 Fforward_char and Fbackward_char, but does so while checking
4262 for integer overflow more accurately.
c96e5d6a 4263 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4264 (Fforward_line, Fend_of_line, internal_self_insert)
4265 (internal_self_insert):
4266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4267 Fix a FIXME, by checking for integer overflow when calculating
4268 target_clm and actual_clm.
4269 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4270 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4271 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4272 (coding_alloc_by_making_gap, alloc_destination)
4273 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4274 (encode_coding_utf_16, detect_coding_emacs_mule)
4275 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4276 (detect_coding_iso_2022, decode_coding_iso_2022)
4277 (encode_invocation_designation, encode_designation_at_bol)
4278 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4279 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4280 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4281 (encode_coding_ccl, encode_coding_raw_text)
4282 (detect_coding_charset, decode_coding_charset)
4283 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4284 (produce_composition, produce_charset, produce_annotation)
4285 (decode_coding, handle_composition_annotation)
4286 (handle_charset_annotation, consume_chars, decode_coding_gap)
4287 (decode_coding_object, encode_coding_object, detect_coding_system)
4288 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4289 (code_convert_region, code_convert_string)
8f50130c
PE
4290 (Fdefine_coding_system_internal)
4291 (coding_set_source, coding_set_destination):
d311d28c
PE
4292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4293 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4294 (Fdefine_coding_system_internal):
4295 Don't assume fixnums fit in int.
4296 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4297 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4298 (Funencodable_char_position, Fcheck_coding_systems_region)
4299 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4301 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4302 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4303 Don't access memory outside of the args array.
d311d28c 4304 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4305 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4306 result of ENCODE_CHAR.
d311d28c
PE
4307 * coding.h: Adjust decls to match defn changes elsewhere.
4308 (struct coding_system):
4309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4310 * composite.c (get_composition_id, find_composition)
4311 (run_composition_function, update_compositions)
4312 (compose_text, composition_gstring_put_cache)
4313 (composition_gstring_p, composition_gstring_width)
4314 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4315 (composition_compute_stop_pos, composition_reseat_it)
4316 (composition_update_it, struct position_record)
4317 (find_automatic_composition, composition_adjust_point)
4318 (Fcomposition_get_gstring, Ffind_composition_internal):
4319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4320 (update_compositions):
4321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4322 * composite.h: Adjust decls to match defn changes elsewhere.
4323 (struct composition):
4324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4325 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4326 Do not attempt to compute the address of the object just before a
4327 buffer; this is not portable.
4328 (Faref, Faset):
4329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4330 (Faset): Use int, not EMACS_INT, where int is wide enough.
4331 (Fstring_to_number): Don't assume fixnums fit in int.
4332 (Frem): Don't assume arg is nonnegative.
4333 * dbusbind.c (xd_append_arg): Check for integers out of range.
4334 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4335 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4336 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4337 (xd_get_connection_references): Return ptrdiff_t, not int.
4338 All uses changed.
4339 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4340 (xd_read_message_1):
4341 Use int, not unsigned, where the dbus API uses int.
4342 (Fdbus_message_internal): Don't overflow mtype.
4343 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4344 * dired.c (directory_files_internal, file_name_completion, scmp)
4345 (file_name_completion_stat):
4346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4347 (file_name_completion): Don't overflow matchcount.
4348 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4349 * dispextern.h: Adjust decls to match defn changes elsewhere.
4350 (struct text_pos, struct glyph, struct bidi_saved_info)
4351 (struct bidi_string_data, struct bidi_it, struct composition_it)
4352 (struct it):
4353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4354 (struct display_pos, struct composition_it, struct it):
4355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4356 * dispnew.c (increment_matrix_positions)
4357 (increment_row_positions, mode_line_string)
4358 (marginal_area_string):
4359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4360 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4362 (duration_to_sec_usec): New function, to check for overflow better.
4363 (Fsleep_for, sit_for): Use it.
4364 * doc.c (get_doc_string, store_function_docstring):
4365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4366 (get_doc_string, Fsnarf_documentation):
4367 Use int, not EMACS_INT, where int is wide enough.
4368 (get_doc_string):
4369 Use SAFE_ALLOCA, not alloca.
4370 Check for overflow when converting EMACS_INT to off_t.
4371 * doprnt.c (doprnt):
4372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4373 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4374 Don't assume uid_t fits into fixnum.
4375 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4376 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4377 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4378 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4379 (general_insert_function)
4380 (Finsert_char, make_buffer_string, make_buffer_string_both)
4381 (update_buffer_properties, Fbuffer_substring)
4382 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4383 (Fsubst_char_in_region, check_translation)
4384 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4385 (transpose_markers, Ftranspose_regions):
4386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4387 (clip_to_bounds): Move to lisp.h as an inline function).
4388 (Fconstrain_to_field): Don't assume integers are nonnegative.
4389 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4390 (Fsubst_char_in_region, Fsave_restriction):
4391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4392 (Femacs_pid): Don't assume pid_t fits into fixnum.
4393 (lo_time): Use int, not EMACS_INT, when int suffices.
4394 (lisp_time_argument): Check for usec out of range.
4395 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4396 (Fuser_login_name, Fuser_full_name): Signal an error
4397 if a uid argument is out of range, rather than relying on
4398 undefined behavior.
c8d5c857
PE
4399 (Fformat_time_string): Remove now-unnecessary check.
4400 lisp_time_argument checks for out-of-range usec now.
243e0530 4401 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4402 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4403 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4404 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4405 (init_cmdargs, Fdump_emacs):
4406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4407 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4408 the bottom (typically) 32 bits of the fixnum.
4409 * eval.c (specpdl_size, call_debugger):
4410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4411 (when_entered_debugger, Fbacktrace_debug):
4412 Don't assume fixnum can fit in int.
4413 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4414 the object just before a buffer; this is not portable.
4415 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4416 (grow_specpdl, unbind_to):
4417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4418 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4419 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4420 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4421 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4422 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4424 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4425 (a_write, e_write):
4426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4427 (Fcopy_file, non_regular_nbytes, read_non_regular)
4428 (Finsert_file_contents):
4429 Use int, not EMACS_INT, where int is wide enough.
4430 (READ_BUF_SIZE): Verify that it fits in int.
4431 (Finsert_file_contents): Check that counts are in proper range,
4432 rather than assuming fixnums fit into ptrdiff_t etc.
4433 Don't assume fixnums fit into int.
125b3835 4434 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4435 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4436 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4437 (string_char_to_byte, string_byte_to_char)
4438 (string_make_multibyte, string_to_multibyte)
4439 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4440 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4441 (substring_both, Fdelete, internal_equal, Ffillarray)
4442 (Fclear_string, mapcar1)
4443 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4444 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4445 (larger_vector, make_hash_table, maybe_resize_hash_table)
4446 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4447 (Fmaphash, secure_hash):
4448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4449 (concat): Check for string index and length overflow.
4450 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4451 (Frequire):
4452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4453 (larger_vector): New API (vec, incr_min, size_max) replaces old
4454 one (vec, new_size, init). This catches size overflow.
4455 INIT was removed because it was always Qnil.
4456 All callers changed.
4457 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4458 the upper bound on a hash table index size.
4459 (make_hash_table, maybe_resize_hash_table): Use it.
4460 (secure_hash): Computer start_byte and end_byte only after
4461 they're known to be in ptrdiff_t range.
4462 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4463 (Ffont_get_glyphs, Ffont_at):
4464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4465 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4466 (Flist_fonts, Fopen_font):
4467 Don't assume fixnum can fit in int.
4468 (check_gstring): Don't assume index can fit in int.
4469 (font_match_p): Check that fixnum is a character, not a nonnegative
4470 fixnum, since the later code needs to stuff it into an int.
4471 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4472 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4473 conversion overflow issues.
4474 (Fopen_font): Check for integer out of range.
4475 (Ffont_get_glyphs): Don't assume index can fit in int.
4476 * font.h: Adjust decls to match defn changes elsewhere.
4477 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4478 integer overflow.
4479 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4480 printmax_t, where ptrdiff_t is wide enough.
4481 (Finternal_char_font):
4482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4483 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4484 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4485 (Fset_frame_position, x_set_frame_parameters)
4486 (x_set_line_spacing, x_set_border_width)
4487 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4488 Check that fixnums are in proper range for system types.
4489 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4491 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4492 Use SAFE_ALLOCA_LISP, not alloca.
4493 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4494 intptr_t is wide enough.
4495 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4496 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4497 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4498 Check for fixnum out of range.
4499 * ftfont.c (ftfont_list): Don't assume index fits in int.
4500 Check that fixnums are in proper range for system types.
4501 (ftfont_shape_by_flt):
4502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4503 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4505 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4506 Check that fixnums are in proper range for system types.
4507 * gnutls.h: Adjust decls to match defn changes elsewhere.
4508 * gtkutil.c (xg_dialog_run):
4509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4510 (update_frame_tool_bar):
4511 Check that fixnums are in proper range for system types.
4512 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4513 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4514 * indent.c (last_known_column, last_known_column_point):
4515 (current_column_bol_cache):
4516 (skip_invisible, current_column, check_display_width):
4517 (check_display_width, scan_for_column, current_column_1)
4518 (Findent_to, Fcurrent_indentation, position_indentation)
4519 (indented_beyond_p, Fmove_to_column, compute_motion):
4520 (Fcompute_motion, Fvertical_motion):
4521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4522 (last_known_column_modified): Use EMACS_INT, not int.
4523 (check_display_width):
4524 (Fcompute_motion):
4525 Check that fixnums and floats are in proper range for system types.
4526 (compute_motion): Don't assume index or fixnum fits in int.
4527 (compute_motion, Fcompute_motion):
4528 Use int, not EMACS_INT, when it is wide enough.
4529 (vmotion): Omit local var start_hpos that is always 0; that way
4530 we don't need to worry about overflow in expressions involving it.
4531 * indent.h: Adjust decls to match defn changes elsewhere.
4532 (struct position):
4533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4534 Use int, not EMACS_INT, where int is wide enough.
4535 Remove unused members ovstring_chars_done and tab_offset;
4536 all uses removed.
4537 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4538 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4539 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4540 (make_gap, copy_text, insert, insert_and_inherit)
4541 (insert_before_markers, insert_before_markers_and_inherit)
4542 (insert_1, count_combining_before, count_combining_after)
4543 (insert_1_both, insert_from_string)
4544 (insert_from_string_before_markers, insert_from_string_1)
4545 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4546 (adjust_after_replace, adjust_after_insert, replace_range)
4547 (replace_range_2, del_range, del_range_1, del_range_byte)
4548 (del_range_both, del_range_2, modify_region)
4549 (prepare_to_modify_buffer, signal_before_change)
4550 (signal_after_change, Fcombine_after_change_execute):
4551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4552 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4553 (balance_an_interval, split_interval_right, split_interval_left)
4554 (find_interval, next_interval, update_interval)
4555 (adjust_intervals_for_insertion, delete_node, delete_interval)
4556 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4557 (static_offset_intervals, offset_intervals)
4558 (merge_interval_right, merge_interval_left, make_new_interval)
4559 (graft_intervals_into_buffer, temp_set_point_both)
4560 (temp_set_point, set_point, adjust_for_invis_intang)
4561 (set_point_both, move_if_not_intangible, get_property_and_range)
4562 (get_local_map, copy_intervals, copy_intervals_to_string)
4563 (compare_string_intervals, set_intervals_multibyte_1):
4564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4565 * intervals.h: Adjust decls to match defn changes elsewhere.
4566 (struct interval):
4567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4568 * keyboard.c (this_command_key_count, this_single_command_key_start)
4569 (before_command_key_count, before_command_echo_length, echo_now)
4570 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4571 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4572 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4573 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4575 (last_non_minibuf_size, last_point_position, echo_truncate)
4576 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4577 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4578 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4579 (stuff_buffered_input):
4580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4581 (last_auto_save, command_loop_1, read_char):
4582 Use EMACS_INT, not int, to avoid integer overflow.
4583 (record_char): Avoid overflow in total_keys computation.
4584 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4585 * keyboard.h: Adjust decls to match defn changes elsewhere.
4586 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4587 (Fkey_description, Fdescribe_vector, Flookup_key):
4588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4589 (click_position): New function, to check that positions are in range.
4590 (Fcurrent_active_maps):
4591 (describe_command):
4592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4593 (Faccessible_keymaps, Fkey_description):
4594 (preferred_sequence_p):
4595 Don't assume fixnum can fit into int.
4596 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4597 Check for integer overflow in size calculations.
4598 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4599 avoid mishandling large integers.
4600 * lisp.h: Adjust decls to match defn changes elsewhere.
4601 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4602 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4603 (struct Lisp_Marker):
4604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4605 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4606 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4607 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4608 All callers changed.
4609 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4610 Assume the arg has valid form, since it always does.
4611 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4612 unsigned integer system type.
4613 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4614 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4616 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4617 (duration_to_sec_usec): New decl.
4618 * lread.c (read_from_string_index, read_from_string_index_byte)
4619 (read_from_string_limit, readchar, unreadchar, openp)
4620 (read_internal_start, read1, oblookup):
4621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4622 (Fload, readevalloop, Feval_buffer, Feval_region):
4623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4624 (openp): Check for out-of-range argument to 'access'.
4625 (read1): Use int, not EMACS_INT, where int is wide enough.
4626 Don't assume fixnum fits into int.
6efdadfd 4627 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4628 (read_filtered_event): Use duration_to_sec_usec
4629 to do proper overflow checking on durations.
d311d28c
PE
4630 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4631 in size calculation.
4632 (Fexecute_kbd_macro):
4633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4634 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4635 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4636 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4637 (set_marker_both, set_marker_restricted_both, marker_position)
4638 (marker_byte_position, Fbuffer_has_markers_at):
4639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4640 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4641 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4642 It now merely ensures that the menu is large enough, without
4643 necessarily growing it, as this avoids some integer overflow issues.
4644 All callers changed.
4645 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4647 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4648 Use SAFE_ALLOCA_LISP, not alloca.
4649 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4650 to EMACS_INT. Check that fixnums are in proper range for system types.
4651 * minibuf.c (minibuf_prompt_width, string_to_object)
4652 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4653 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4655 (get_minibuffer, read_minibuf_unwind):
4656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4657 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4658 this simplifies overflow checking. All callers changed.
4659 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4660 (Ftest_completion):
4661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4662 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4663 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4664 Check that fixnums are in proper range for system types.
4665 (Fx_create_frame, Fx_show_tip):
4666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4667 * nsfont.m (ns_findfonts, nsfont_list_family):
4668 Don't assume fixnum fits in long.
4669 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4671 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4672 wide enough.
17fdb222 4673 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4675 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4676 (PRINTDECLARE, PRINTPREPARE):
4677 (strout, print_string):
4678 (print, print_preprocess, print_check_string_charset_prop)
4679 (print_object):
4680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4681 (PRINTDECLARE):
4682 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4684 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4685 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4686 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4687 (print_error_message): Use SAFE_ALLOCA, not alloca.
4688 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4689 (print_depth, new_backquote_output, print_number_index):
4690 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4691 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4692 (Fset_process_window_size, Fformat_network_address)
4693 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4694 (sigchld_handler):
d311d28c 4695 Check that fixnums are in proper range for system types.
d44287d4 4696 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4697 Check for process-ids out of pid_t range rather than relying on
4698 undefined behavior.
e4d81efc 4699 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4700 (Fformat_network_address, read_process_output, send_process)
4701 (Fprocess_send_region, status_notify):
4702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4703 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4704 (wait_reading_process_output, read_process_output, exec_sentinel):
4705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4706 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4707 (Faccept_process_output): Use duration_to_sec_usec to do proper
4708 overflow checking on durations.
dde14581
PE
4709 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4710 Don't assume pid_t fits in int.
02481186
PE
4711 * process.h (struct Lisp_Process): Members tick and update_tick
4712 are now of type EMACS_INT, not int.
b62b53e8
PE
4713 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4714 configured --with-wide-int.
d311d28c
PE
4715 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4716 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4717 * search.c (looking_at_1, string_match_1):
4718 (fast_string_match, fast_c_string_match_ignore_case)
4719 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4720 (scan_newline, find_before_next_newline, search_command)
4721 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4722 (set_search_regs, wordify):
4723 (Freplace_match):
4724 (Fmatch_data):
4725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4726 (string_match_1, search_buffer, set_search_regs):
4727 (Fmatch_data):
4728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4729 (wordify): Check for overflow in size calculation.
4730 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4731 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4732 Check that fixnums are in proper range for system types.
4733 * sound.c (struct sound_device)
4734 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4736 (Fplay_sound_internal):
4737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4738 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4739 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4740 (Fparse_partial_sexp):
4741 Don't assume fixnums can fit in int.
4742 (struct lisp_parse_state, find_start_pos, find_start_value)
4743 (find_start_value_byte, find_start_begv)
4744 (update_syntax_table, char_quoted, dec_bytepos)
4745 (find_defun_start, prev_char_comend_first, back_comment):
4746 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4747 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4749 (Finternal_describe_syntax_value): Check that match_lisp is a
4750 character, not an integer, since the code stuffs it into int.
4751 (scan_words, scan_sexps_forward):
4752 Check that fixnums are in proper range for system types.
4753 (Fforward_word):
4754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4755 (scan_sexps_forward):
4756 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4757 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4758 * syntax.h: Adjust decls to match defn changes elsewhere.
4759 (struct gl_state_s):
4760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4761 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4762 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4763 * sysdep.c (wait_for_termination_1, wait_for_termination)
4764 (interruptible_wait_for_termination, mkdir):
4765 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4766 (emacs_read, emacs_write):
4767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4768 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4769 and double all fit in int.
d311d28c
PE
4770 * term.c (set_tty_color_mode):
4771 Check that fixnums are in proper range for system types.
4772 * termhooks.h (struct input_event):
4773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4774 * textprop.c (validate_interval_range, interval_of)
4775 (Fadd_text_properties, set_text_properties_1)
4776 (Fremove_text_properties, Fremove_list_of_text_properties)
4777 (Ftext_property_any, Ftext_property_not_all)
4778 (copy_text_properties, text_property_list, extend_property_ranges)
4779 (verify_interval_modification):
4780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4781 (Fnext_single_char_property_change)
4782 (Fprevious_single_char_property_change):
4783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4784 (copy_text_properties):
4785 Check for integer overflow in index calculation.
d311d28c
PE
4786 * undo.c (last_boundary_position, record_point, record_insert)
4787 (record_delete, record_marker_adjustment, record_change)
4788 (record_property_change):
4789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4790 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4792 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4793 (Fx_hide_tip, Fx_file_dialog):
4794 * w32menu.c (set_frame_menubar):
4795 Use ptrdiff_t, not int, for consistency with rest of code.
4796 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4797 (select_window, Fdelete_other_windows_internal)
4798 (window_scroll_pixel_based, window_scroll_line_based)
4799 (Frecenter, Fset_window_configuration):
4800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4801 (Fset_window_hscroll, run_window_configuration_change_hook)
4802 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4803 (Fscroll_other_window, Frecenter):
d311d28c
PE
4804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4805 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4806 Don't assume fixnum fits in int.
4807 (Fset_window_scroll_bars):
4808 Check that fixnums are in proper range for system types.
4809 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4810 (string_pos, c_string_pos, number_of_chars, init_iterator)
4811 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4812 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4813 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4814 (face_before_or_after_it_pos, handle_invisible_prop)
4815 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4816 (display_prop_intangible_p, string_buffer_position_lim)
4817 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4818 (get_overlay_strings_1, get_overlay_strings)
4819 (iterate_out_of_display_property, forward_to_next_line_start)
4820 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4821 (get_next_display_element, set_iterator_to_next)
4822 (get_visually_first_element, compute_stop_pos_backwards)
4823 (handle_stop_backwards, next_element_from_buffer)
4824 (move_it_in_display_line_to, move_it_in_display_line)
4825 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4826 (add_to_log, message_dolog, message_log_check_duplicate)
4827 (message2, message2_nolog, message3, message3_nolog
4828 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4829 (current_message_1, truncate_echo_area, truncate_message_1)
4830 (set_message, set_message_1, store_mode_line_noprop)
4831 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4832 (text_outside_line_unchanged_p, check_point_in_composition)
4833 (reconsider_clip_changes)
4834 (redisplay_internal, set_cursor_from_row, try_scrolling)
4835 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4836 (redisplay_window, find_last_unchanged_at_beg_row)
4837 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4838 (trailing_whitespace_p, find_row_edges, display_line)
4839 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4840 (display_mode_element, store_mode_line_string)
4841 (pint2str, pint2hrstr, decode_mode_spec)
4842 (display_count_lines, display_string, draw_glyphs)
4843 (x_produce_glyphs, x_insert_glyphs)
4844 (rows_from_pos_range, mouse_face_from_buffer_pos)
4845 (fast_find_string_pos, mouse_face_from_string_pos)
4846 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4848 (safe_call, init_from_display_pos, handle_fontified_prop)
4849 (handle_single_display_spec, load_overlay_strings)
4850 (with_echo_area_buffer, setup_echo_area_for_printing)
4851 (display_echo_area, echo_area_display)
4852 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4853 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4854 (redisplay_window, dump_glyph_row, display_mode_line)
4855 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4856 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4858 (handle_single_display_spec, build_desired_tool_bar_string)
4859 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4860 (get_specified_cursor_type):
4861 Check that fixnums are in proper range for system types.
4862 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4863 (Flookup_image_map):
4864 Don't assume fixnums fit in int.
4865 (compare_overlay_entries):
4866 Avoid mishandling comparisons due to subtraction overflow.
4867 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4868 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4869 (handle_tool_bar_click):
4870 Use int, not unsigned, since we prefer signed and the signedness
4871 doesn't matter here.
4872 (get_next_display_element, next_element_from_display_vector):
4873 Use int, not EMACS_INT, when int is wide enough.
4874 (start_hourglass): Use duration_to_sec_usec to do proper
4875 overflow checking on durations.
4876 * xfaces.c (Fbitmap_spec_p):
4877 Check that fixnums are in proper range for system types.
4878 (compare_fonts_by_sort_order):
4879 Avoid mishandling comparisons due to subtraction overflow.
4880 (Fx_family_fonts, realize_basic_faces):
4881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4882 (Fx_family_fonts):
4883 Don't assume fixnum fits in int.
4884 Use SAFE_ALLOCA_LISP, not alloca.
4885 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4886 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4887 (face_at_buffer_position, face_for_overlay_string)
4888 (face_at_string_position):
4889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4890 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4891 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4892 (Fx_show_tip):
4893 Check that fixnums are in proper range for system types.
4894 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4895 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4897 (Fx_change_window_property): Don't assume fixnums fit in int.
4898 * xfont.c (xfont_chars_supported):
4899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4900 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4901 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4903 * xml.c (parse_region):
4904 * xrdb.c (magic_file_p):
4905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4906 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4907 (x_get_local_selection, x_reply_selection_request)
4908 (x_handle_selection_request, wait_for_property_change):
4909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4910 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4911 short is wide enough.
4912 (x_send_client_event): Don't assume fixnum fits in int.
4913 * xterm.c (x_x_to_emacs_modifiers):
4914 Don't assume EMACS_INT overflows nicely into int.
4915 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4916 may come from Lisp.
4917 (handle_one_xevent): NATNUMP can eval its arg twice.
4918 (x_connection_closed):
4919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4920 * xterm.h: Adjust decls to match defn changes elsewhere.
4921 (struct scroll_bar): Use struct vectorlike_header
4922 rather than rolling our own approximation.
4923 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4924
c6574eb5
GM
49252012-05-25 Glenn Morris <rgm@gnu.org>
4926
4927 * lisp.mk (lisp): Update for more files being compiled now.
4928
e8d32c7e
SM
49292012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4930
48def666
SM
4931 * lread.c: Remove `read_pure' which makes no difference.
4932 (read_pure): Remove var.
4933 (unreadpure): Remove function.
4934 (readevalloop): Don't call read_list with -1 flag.
4935 (read1, read_vector): Don't test read_pure any more.
4936 (read_list): Simplify.
4937
e8d32c7e
SM
4938 * fileio.c, character.h: Minor style tweaks.
4939
4b2addb7
DA
49402012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4941
4942 * window.h (clip_changed): Remove useless declaration.
4943
584461b2
JB
49442012-05-22 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4947 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4948
34374650
PE
49492012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4950
4951 Remove src/m/*.
4952 This directory predates autoconf and is no longer needed nowadays.
4953 Move its few remaining bits of functionality to where they're needed.
4954 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4955 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4956 * m/template.h: Remove.
4957 * Makefile.in (M_FILE): Remove. All uses removed.
4958 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4959 * lisp.h (USE_LSB_TAG):
4960 * mem-limits.h (EXCEEDS_LISP_PTR):
4961 Use VAL_MAX, not VALBITS, in #if.
4962 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4963 (EMACS_UINT): Define unconditionally now.
4964 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4965 (BITS_PER_EMACS_INT): New constants, replacing
4966 what used to be in config.h, but not useful in #if.
4967 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4968 define them any more.
4969 (VAL_MAX): New macro.
4970 (VALMASK): Use it.
4971 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4972 BITS_PER_EMACS_INT, in #if.
4973 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4974 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4975 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4976 * s/ms-w32.h (DATA_START):
4977 Move here from removed file m/intel386.h.
4978 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4979 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4980
261cb4bb
PE
49812012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4982
4983 Assume C89 or later.
4984 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4985 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4986 (xrealloc):
4987 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4988 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4989 * textprop.c, tparam.c (NULL): Remove.
4990 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4991 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4992 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4993 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4994 * xterm.c (input_signal_count): Assume volatile works.
4995
ff23cd9f
KB
49962012-05-21 Ken Brown <kbrown@cornell.edu>
4997
4998 * xgselect.c (xg_select): Fix first argument in call to 'select'
4999 (bug#11508).
5000
1b170bc6
KB
50012012-05-20 Ken Brown <kbrown@cornell.edu>
5002
5003 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5004 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5005
b2f4d39f
KB
50062012-05-19 Ken Brown <kbrown@cornell.edu>
5007
5008 * xfns.c (x_in_use): Remove `static' qualifier.
5009 * xterm.h (x_in_use): Declare.
5010 * xgselect.c: Include xterm.h.
5011 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5012 and `display_arg' (bug#9754).
5013
003fdae2
PE
50142012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5015
9232a6d9
PE
5016 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5017
003fdae2
PE
5018 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5019 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5020
784b56e2
EZ
50212012-05-18 Eli Zaretskii <eliz@gnu.org>
5022
5023 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5024
5025 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5026 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5027
5028 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5029 reference to image_cache->refcount.
5030 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5031
a0a79cde
JL
50322012-05-17 Juri Linkov <juri@jurta.org>
5033
5034 * search.c (Fword_search_regexp, Fword_search_backward)
5035 (Fword_search_forward, Fword_search_backward_lax)
5036 (Fword_search_forward_lax): Move functions to isearch.el
5037 (bug#10145, bug#11381).
5038
b0572523
PE
50392012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5040
5041 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5042
9660f5fc
SM
50432012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5044
5045 * lread.c (init_obarray): Declare Qt and Qnil as special.
5046
4374de83
GM
50472012-05-14 Glenn Morris <rgm@gnu.org>
5048
5049 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5050 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5051
dc44c39a
PE
50522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5053
078c97cb
PE
5054 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5055
dc44c39a
PE
5056 * unexaix.c: Port to more-recent AIX compilers.
5057 (report_error, report_error_1, make_hdr, copy_sym)
5058 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5059 Make arguments const char *, not char *, to avoid violations of C
5060 standard and to fix some AIX warnings reported by Gilles Pion.
5061
e18afed7 50622012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5063
5064 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5065 already have overlays loaded.
5066 (handle_single_display_spec): Before returning without displaying
5067 fringe bitmap, synchronize the bidi iterator with the main display
5068 iterator, by calling iterate_out_of_display_property.
5069 (iterate_out_of_display_property): Detect buffer iteration by
5070 testing that it->string is a Lisp string.
5071 (get_next_display_element): When the current object is exhausted,
5072 and there's something on it->stack, call set_iterator_to_next to
5073 proceed with what's on the stack, instead of returning zero.
5074 (set_iterator_to_next): If called at the end of a Lisp string,
5075 proceed to consider_string_end without incrementing string
5076 position. Don't increment display vector index past the end of
5077 the display vector. (Bug#11417)
c8fb9dc6
EZ
5078 (pos_visible_p): Don't report a position visible when move_it_to
5079 stopped at the last line of window, which happens to be scanned
5080 backwards by the bidi iteration. (Bug#11464)
ac268e67 5081
e18afed7 50822012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5083
5084 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5085 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5086 are on a TTY, and thus unable to display on the fringes.
5087 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5088 so we need to signal to the caller that this is a "replacing"
5089 display spec. This fixes display when the spec is invalid or we
5090 are on a TTY.
5091
e18afed7 50922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5093
5094 * unexaix.c (make_hdr): Fix typo in prototype.
5095 This bug broke the build on AIX. Problem reported by Gilles Pion.
5096
9d0a235a
MA
50972012-05-14 Michael Albinus <michael.albinus@gmx.de>
5098
5099 * keyboard.c (kbd_buffer_get_event): Read special events also in
5100 batch mode. (Bug#11415)
5101
9e6b06ed
GM
51022012-05-12 Glenn Morris <rgm@gnu.org>
5103
5104 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5105
c1a1d7a3
EZ
51062012-05-12 Eli Zaretskii <eliz@gnu.org>
5107
5108 * lisp.mk (lisp): Add newcomment.elc.
5109
3fe7cdc8
GM
51102012-05-12 Glenn Morris <rgm@gnu.org>
5111
5112 * Makefile.in (MKDIR_P): New, set by configure.
5113 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5114
53f7d2c0
PE
51152012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 Remove unused function hourglass_started.
5118 * dispextern.h (hourglass_started):
5119 * w32fns.c (hourglass_started):
5120 * xdisp.c (hourglass_started): Remove.
5121
75aafb17
JB
51222012-05-10 Juanma Barranquero <lekktu@gmail.com>
5123
5124 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5125 Update dependencies.
5126
12959e8e
PE
51272012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5128
97107e2e
PE
5129 * xgselect.c (xg_select): Put maxfds+1 into a var.
5130 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5131
12959e8e
PE
5132 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5133
836d29b3
DA
51342012-05-10 Dave Abrahams <dave@boostpro.com>
5135
5136 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5137 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5138
5cb67954
MA
51392012-05-09 Michael Albinus <michael.albinus@gmx.de>
5140
5141 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5142 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5143 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5144 Initialize xd_registered_buses.
5145
3478ec45
PE
51462012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5147
b263a6b0
PE
5148 Untag more efficiently if USE_LSB_TAG.
5149 This is based on a proposal by YAMAMOTO Mitsuharu in
5150 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5151 For an admittedly artificial (nth 8000 longlist) benchmark on
5152 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5153 Emacs's overall text size by 1%.
5154 * lisp.h (XUNTAG): New macro.
5155 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5156 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5157 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5158 * eval.c (Fautoload):
5159 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5160 * frame.h (XFRAME): Use XUNTAG.
5161
3478ec45
PE
5162 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5163 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5164 Remove unportable assumptions about print widths of types like
5165 dbus_uint32_t.
5166 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5167 intptr_t when converting between pointer and integer, to avoid GCC
5168 warnings about wrong width.
5169
666b903b 51702012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5171
5172 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5173 stack for each reader_thread, instead of defaulting to 8MB
5174 determined by the linker. This avoids failures in creating
5175 subprocesses on Windows 7, see the discussion in this thread:
5176 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5177
b120cc17
JC
51782012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5179
5180 Fix up display of the *Minibuf-0* buffer in the mini window.
5181 * keyboard.c (read_char): Don't clear the echo area if there's no
5182 message to clear.
5183 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5184 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5185
9a4b36f8
MA
51862012-05-07 Michael Albinus <michael.albinus@gmx.de>
5187
5188 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5189 batch mode.
5190
e5f9458f
CY
51912012-05-06 Chong Yidong <cyd@gnu.org>
5192
5193 * lisp.mk (lisp): Update.
5194
eceeb5fc 51952012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5196
5197 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5198
71873e2b
SM
51992012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5200
5201 * data.c (PUT_ERROR): New macro.
5202 (syms_of_data): Use it. Add new error type `user-error'.
5203 * undo.c (user_error): New function.
5204 (Fprimitive_undo): Use it.
5205 * print.c (print_error_message): Adjust print style for `user-error'.
5206 * keyboard.c (user_error): New function.
5207 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5208
ab0fa4e4
PE
52092012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5210
5211 Do not limit current-time-string to years 1000..9999.
5212 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5213 (Fcurrent_time_string): Support any year that is supported by the
5214 underlying localtime representation. Don't use asctime, as it
5215 has undefined behavior for years outside the range -999..9999.
5216
7ed806a7
PE
52172012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5218
5219 Fix race conditions involving setenv, gmtime, localtime, asctime.
5220 Without this fix, interrupts could mess up code that uses these
5221 nonreentrant functions, since setting TZ invalidates existing
5222 tm_zone or tzname values, and since most of these functions return
5223 pointers to static storage.
5224 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5225 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5226 Grow the critical sections to include not just invoking
5227 localtime/gmtime, but also accessing these functions' results
5228 including their tm_zone values if any, and any related TZ setting.
5229 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5230 so that the struct tm is saved in the critical section.
5231 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5232 motivated by the fact that memory allocation needs to be outside
5233 the critical section.
5234
0c16dfed
DA
52352012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5236
5237 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5238 with RESET_INTERVAL.
5239
5240 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5241 Remove duplicated buffer name initialization.
5242
3f83ace8
JM
52432012-05-02 Jim Meyering <jim@meyering.net>
5244
5245 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5246
c7b8541e
JM
5247 * xfns.c (x_window): Use xstrdup (Bug#11375).
5248
90207a15 52492012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5250
5251 * xdisp.c (pos_visible_p): If already at a newline from the
5252 display string before the 'while' loop, don't walk back the glyphs
5253 from it3.glyph_row. Solves assertion violation when the display
5254 string begins with a newline (egg.el). (Bug#11367)
5255
b593d6a9
AH
52562012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5257
5258 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5259 Move to simple.el.
5260
4737362e
GM
52612012-05-01 Glenn Morris <rgm@gnu.org>
5262
99cf43f9
GM
5263 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5264 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5265 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5266 All were removed before 23.1.
5267
9311dcff
GM
5268 * dispnew.c: Remove HAVE_LIBNCURSES test;
5269 it is always true on relevant platforms.
5270
4d5c6349
GM
5271 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5272 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5273
4737362e
GM
5274 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5275
74dd3a6b
AS
52762012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5277
5278 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5279 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5280 Remove.
5281
13c379ee
PE
52822012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5283
5284 Do not avoid creating empty evaporating overlays (Bug#9642).
5285 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5286 That is, do not delete an evaporating overlay if it becomes
5287 empty after its bounds are adjusted to fit within its buffer.
5288 This fix caused other problems, and I'm reverting it until we get
5289 to the bottom of them.
5290
a8e7d6d7 52912012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5292
5293 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5294
a8e7d6d7 52952012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5296
5297 * xdisp.c (pos_visible_p): If the window start position is beyond
5298 ZV, start the display from buffer beginning. Prevents assertion
5299 violation in init_iterator when the minibuffer window is scrolled
5300 via the scroll bar.
5301
5302 * window.c (window_scroll_pixel_based): Likewise.
5303
a8e7d6d7 53042012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5305
5306 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5307
a8e7d6d7 53082012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5309
5310 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5311 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5312
a8e7d6d7 53132012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5314
b593d6a9
AH
5315 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5316 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5317
1c6900d9
EZ
53182012-04-26 Eli Zaretskii <eliz@gnu.org>
5319
4c3fa1d9
EZ
5320 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5321 display element, check also the underlying string or buffer
5322 character. (Bug#11341)
5323
1c6900d9
EZ
5324 * w32menu.c: Include w32heap.h.
5325 (add_menu_item): If the call to AppendMenuW (via
5326 unicode_append_menu) fails, disable Unicode menus only if we are
5327 running on Windows 9X/Me.
5328
42bf8205
AS
53292012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5330
5331 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5332 (xgetint): Add missing shift for LSB tags.
5333
b1bac16e
MR
53342012-04-24 Martin Rudalics <rudalics@gmx.at>
5335
5336 * keyboard.c (read_char): Don't wipe echo area for select window
5337 events: These might get delayed via `mouse-autoselect-window'
5338 (Bug#11304).
5339
d69621cc
JB
53402012-04-24 Juanma Barranquero <lekktu@gmail.com>
5341
5342 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5343 manipulation of :loaded-from data.
5344
02fd101b
JB
53452012-04-23 Juanma Barranquero <lekktu@gmail.com>
5346
5347 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5348 now a cons (bug#11311).
5349
888bec30
PE
53502012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5351
89a438bd
PE
5352 Do not create empty overlays with the evaporate property (Bug#9642).
5353 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5354 if it becomes empty after its bounds are adjusted to fit within
5355 its buffer. Without this fix, in a nonempty buffer (let ((o
5356 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5357 yields an empty overlay that has the evaporate property, which is
5358 not supposed to happen.
5359
1068fe4d
PE
5360 Fix minor GTK3 problems found by static checking.
5361 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5362 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5363 (struct _EmacsFixedClass, emacs_fixed_get_type):
5364 Move decls here from emacsgtkfixed.h, since they needn't be public.
5365 (emacs_fixed_get_type): Now static.
5366 (emacs_fixed_class_init): Omit unused local.
5367 (emacs_fixed_child_type): Remove; unused.
5368 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5369 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5370 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5371 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5372 (EMACS_FIXED_GET_CLASS): Remove; unused.
5373 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5374
888bec30
PE
5375 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5376 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5377
de85e130
PE
53782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5379
d0baac98 5380 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5381 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5382 (__malloc_size_t, __malloc_ptrdiff_t):
5383 Remove. All uses removed, replaced by the definiens if needed,
5384 since we can assume C89 or better now.
5385 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5386 (protect_malloc_state, align, get_contiguous_space)
5387 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5388 (malloc_atfork_handler_child, malloc_enable_thread)
5389 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5390 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5391 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5392 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5393 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5394 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5395 Define using prototypes, not old style.
5396 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5397 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5398 (align): Don't assume that signed integer overflow wraps around.
5399 Omit unused local var.
5400 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5401 (_free_internal_nolock, memalign, mallochook, reallochook):
5402 Omit no-longer-needed casts.
5403 (valloc): Use getpagesize, not __getpagesize.
5404 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5405 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5406
de85e130
PE
5407 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5408
dcbf5805
MA
54092012-04-22 Michael Albinus <michael.albinus@gmx.de>
5410
5411 Move functions from C to Lisp. Make non-blocking method calls
5412 the default. Implement further D-Bus standard interfaces.
5413
5414 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5415 (QCdbus_request_name_allow_replacement)
5416 (QCdbus_request_name_replace_existing)
5417 (QCdbus_request_name_do_not_queue)
5418 (QCdbus_request_name_reply_primary_owner)
5419 (QCdbus_request_name_reply_in_queue)
5420 (QCdbus_request_name_reply_exists)
5421 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5422 (QCdbus_registered_serial, QCdbus_registered_method)
5423 (QCdbus_registered_signal): New Lisp objects.
5424 (XD_DEBUG_MESSAGE): Use sizeof.
5425 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5426 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5427 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5428 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5429 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5430 (xd_signature, xd_append_arg): Allow float for integer types.
5431 (xd_get_connection_references): New function.
b593d6a9
AH
5432 (xd_get_connection_address): Rename from xd_initialize.
5433 Return cached address.
dcbf5805
MA
5434 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5435 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5436 level.
5437 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5438 Return number of refcounts.
dcbf5805
MA
5439 (Fdbus_get_unique_name): Make stronger parameter check.
5440 (Fdbus_message_internal): New defun.
5441 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5442 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5443 (Fdbus_send_signal, Fdbus_register_service)
5444 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5445 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5446 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5447 (Vdbus_compiled_version, Vdbus_runtime_version)
5448 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5449 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5450 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5451 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5452 Adapt docstring.
dcbf5805 5453
52828e02
PE
54542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5455
da05bc4c
PE
5456 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5457 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5458 Do not assume ptrdiff_t is the same width as 'int'.
5459
52828e02
PE
5460 * alloc.c: Handle unusual debugging option combinations.
5461 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5462 since the two debugging options are incompatible.
5463 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5464 is defined.
5465 (mem_init, mem_insert, mem_insert_fixup):
5466 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5467 (NEED_MEM_INSERT): Remove; no longer needed.
5468
f01769f9
LL
54692012-04-22 Leo Liu <sdl.web@gmail.com>
5470
5471 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5472
5790543d
PE
54732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 * sysdep.c [__FreeBSD__]: Minor cleanups.
5476 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5477 Use Emacs indenting style more consistently. Avoid some casts.
5478 Use 'double' consistently rather than mixing 'float' and 'double'.
5479
b91b7e4d
EW
54802012-04-21 Eduard Wiebe <usenet@pusto.de>
5481
b593d6a9
AH
5482 * sysdep.c (list_system_processes, system_process_attributes):
5483 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5484
6114eb15
AS
54852012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5486
5487 * lisp.mk (lisp): Update.
5488
2f38dff7
PE
54892012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5490
5491 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5492 It is never used otherwise.
5493
4ae29f89
SM
54942012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5495
5496 * print.c (print_preprocess): Only check print_depth if print-circle
5497 is nil.
5498 (print_object): Check for cycles even when print-circle is nil and
5499 print-gensym is t, but only check print_depth if print-circle is nil.
5500
f30d612a
CY
55012012-04-20 Chong Yidong <cyd@gnu.org>
5502
5503 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5504 set the status to "failed" and ensure that sentinel is run.
5505
c07a4c0b 55062012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5507
5508 * process.c (Fset_process_inherit_coding_system_flag)
5509 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5510 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5511
c07a4c0b 55122012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5513
5514 * xdisp.c (string_buffer_position_lim): Limit starting position to
5515 BEGV.
5516 (set_cursor_from_row): If called for a mode-line or header-line
5517 row, return zero immediately.
5518 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5519 farther than the first row after the header line, if any.
5520 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5521 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5522
c07a4c0b 55232012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5524
4ae29f89
SM
5525 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5526 (bug#11238).
ad3a2b41 5527
c07a4c0b 55282012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 55292012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5530
5531 configure: new option --enable-gcc-warnings (Bug#11207)
5532 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5533 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5534 (ALL_CFLAGS): Use new macros rather than old.
5535 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5536 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5537 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5538 -Wunused-result, -Wunused-variable. This should go away once
5539 the Emacs and Gnulib regex code is merged.
5540 (xmalloc, xrealloc): Now static.
5541
aba027e8
PE
55422012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5543
5544 * dired.c (Fsystem_groups): Remove unused local.
5545
e5a36063
GM
55462012-04-17 Glenn Morris <rgm@gnu.org>
5547
5548 * dired.c (Fsystem_users): Doc fix.
5549
316411f0
DA
55502012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5551
5552 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5553 (syms_of_dired): Add them.
5554
9426aba4
PE
55552012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5556
b62a57be
PE
5557 Fix minor alloc.c problems found by static checking.
5558 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5559 New extern decls, to avoid calling undeclared functions.
5560 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5561 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5562 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5563 (NEED_MEM_INSERT): New macro.
5564 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5565 Remove one incorrect comment and fix another.
b62a57be 5566
3539f31f
PE
5567 Fix minor ralloc.c problems found by static checking.
5568 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5569 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5570 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5571 (r_alloc_sbrk): Now static.
5572
a041960a
PE
5573 Improve ralloc.c interface checking.
5574 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5575 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5576 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5577 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5578 [REL_ALLOC]: ... to here, to check interface.
5579 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5580 Remove decls. This fixes an "It stinks!".
5581
9426aba4
PE
5582 * alloc.c (which_symbols): Fix alignment issue / type clash.
5583
d55c12ed
AS
55842012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5585
5586 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5587 (struct Lisp_Misc_Any): Likewise.
5588 (struct Lisp_Free): Likewise.
5589 * alloc.c (union aligned_Lisp_Symbol): Define.
5590 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5591 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5592 (union aligned_Lisp_Misc): Define.
5593 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5594 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5595 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5596
b948ce8b
PE
55972012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5598
5599 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5600 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5601 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5602 * s/netbsd.h, s/sol2-6.h:
5603 Remove definition of GC_MARK_STACK, since the default now works.
5604 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5605 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5606 no longer the default.
5607 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5608
35dc09a1 56092012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5610
35dc09a1
GM
5611 * lread.c (lisp_file_lexically_bound_p):
5612 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5613
35dc09a1
GM
56142012-04-14 Eli Zaretskii <eliz@gnu.org>
5615
5616 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5617 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5618
56192012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5620
5621 * nsterm.m (constrainFrameRect): Always constrain when there is only
5622 one screen (Bug#10962).
5623
bcd86815
KB
56242012-04-13 Ken Brown <kbrown@cornell.edu>
5625
5626 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5627
c25df26e
RT
56282012-04-13 Reuben Thomas <rrt@sc3d.org>
5629
5630 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5631
0fc59f1e
DC
56322012-04-11 Daniel Colascione <dancol@dancol.org>
5633
5634 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5635 against is gone. It's better to use vfork now so that when Cygwin
5636 gains a new, working vfork, we use it automatically (bug#10398).
5637
de8c03dc
SM
56382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5639
5640 * window.c (save_window_save): Obey window-point-insertion-type.
5641
2f097256
GM
56422012-04-11 Glenn Morris <rgm@gnu.org>
5643
5644 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5645
453b951e
SM
56462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5647
5648 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5649
75f1671a 56502012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5651
5652 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5653 (force_quit_count): New var.
5654 (handle_interrupt): Use it.
5655
2a8ce227
JB
56562012-04-10 Juanma Barranquero <lekktu@gmail.com>
5657
5658 * w32.c (w32_delayed_load): Record the full path of the library
5659 being loaded (bug#10424).
5660
935396c0
GM
56612012-04-09 Glenn Morris <rgm@gnu.org>
5662
05920a43
GM
5663 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5664 not just in the obarray, before snarfing them. (Bug#11036)
5665
935396c0
GM
5666 * Makefile.in ($(leimdir)/leim-list.el):
5667 Pass EMACS rather than BUILT_EMACS.
5668
a18ecafa
TZ
56692012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5670
5671 * process.c (make_process):
5672 * process.h: Add integer `gnutls_handshakes_tried' member to
5673 process struct.
5674
6bbef4e5
JC
5675 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5676 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5677
5678 * gnutls.c (gnutls_log_function2i): Convenience log function.
5679 (emacs_gnutls_read): Use new log functions,
5680 `gnutls_handshakes_tried' process member, and
5681 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5682 attempts per process (connection).
5683
b4d3bc10
CY
56842012-04-09 Chong Yidong <cyd@gnu.org>
5685
5686 * eval.c (Fuser_variable_p, user_variable_p_eh)
5687 (lisp_indirect_variable): Functions deleted.
5688 (Fdefvar): Caller changed.
5689
5690 * callint.c (Finteractive, Fcall_interactively):
5691 * minibuf.c (Fread_variable): Callers changed.
5692
70f4d973
EZ
56932012-04-09 Eli Zaretskii <eliz@gnu.org>
5694
5695 * xdisp.c (set_cursor_from_row): If the display string appears in
5696 the buffer at position that is closer to point than the position
5697 after the display string, display the cursor on the first glyph of
5698 the display string. Fixes cursor display when a 'display' text
5699 property immediately follows invisible text. (Bug#11094)
5700
cb3c2e3e
PE
57012012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5702
5703 composite.c: use 'double' consistently
5704 * composite.c (get_composition_id): Use 'double' consistently
5705 instead of converting 'float' to 'double' and vice versa; this is
5706 easier to understand and avoids a GCC warning.
5707
fd06db5d
GM
57082012-04-09 Glenn Morris <rgm@gnu.org>
5709
50fe702a
GM
5710 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5711 preparation for dumping it with emacs. (Bug#4789)
5712 (leimdir): New variable.
5713 ($(leimdir)/leim-list.el): New rule.
5714 (emacs$(EXEEXT)): Depend on leim-list.el.
5715
fd06db5d
GM
5716 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5717 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5718 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5719
55c131ee
AS
57202012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5721
5722 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5723 proper alignment.
5724
9209588f
JB
57252012-04-07 Juanma Barranquero <lekktu@gmail.com>
5726
5727 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5728 Remove unused local variable.
5729
e3fb2efb
PE
57302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5731
5732 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5733 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5734 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5735 objects, as mark_maybe_pointer will catch them otherwise.
5736 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5737 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5738
b5385551
PE
57392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 Fix typo that broke non-Windows builds.
5742 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5743
9078ead6
EZ
57442012-04-07 Eli Zaretskii <eliz@gnu.org>
5745
5746 Support building on MS-Windows with libxml2.
5747
5748 * makefile.w32-in (OBJ2): Add xml.$(O).
5749 (GLOBAL_SOURCES): Add xml.c.
5750 ($(BLD)/xml.$(O)): New dependency list.
5751
5752 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5753 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5754 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5755 [!WINDOWSNT]: New macros.
5756 (init_libxml2_functions, libxml2_loaded_p): New functions.
5757 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5758 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5759 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5760 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5761 linked in).
6bbef4e5
JC
5762 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5763 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5764 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5765
5766 * emacs.c: Don't include libxml/parser.h.
5767 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5768 xmlCleanupParser directly.
5769
5770 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5771
3811fdf3
EZ
57722012-04-07 Eli Zaretskii <eliz@gnu.org>
5773
5774 * indent.c (Fvertical_motion): If there is a display string at
5775 point, use it.vpos to compute how many lines to backtrack after
5776 move_it_to point. (Bug#11133)
5777
2f8e16b2
EZ
57782012-04-06 Eli Zaretskii <eliz@gnu.org>
5779
5780 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5781 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5782 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5783 macros related to unification of CJK characters. For the details,
5784 see the discussion following the message here:
5785 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5786
3d439cd1
CY
57872012-04-04 Chong Yidong <cyd@gnu.org>
5788
5789 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5790
8bc53d00
EZ
57912012-04-01 Eli Zaretskii <eliz@gnu.org>
5792
5793 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5794 instead of alloca. (Bug#11138)
5795
3b0512a3
AS
57962012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5797
5798 * w32menu.c (is_simple_dialog): Properly check lisp types.
5799 (Bug#11141)
5800
8427ddd2
EZ
58012012-03-31 Eli Zaretskii <eliz@gnu.org>
5802
979022ef
EZ
5803 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5804 position we get to after a call to move_it_to fails the
5805 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5806 only if we wind up in a string from display property. (Bug#11063)
5807
a6b1c7cc
EZ
5808 * window.c (Fdelete_other_windows_internal): Invalidate the row
5809 and column information about mouse highlight, so that redisplay
5810 restores it after reallocating the glyph matrices. (Bug#7464)
5811
8427ddd2
EZ
5812 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5813 string comes from a `display' text property, use the buffer
5814 position of that property as if we actually saw that position in
5815 the row's glyphs.
697ba24b
EZ
5816 (move_it_by_lines): Remove the assertion that
5817 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5818 violated when there's a before-string at the beginning of a line.
5819 (Bug#11063)
8427ddd2 5820
65a0a738
EZ
58212012-03-30 Eli Zaretskii <eliz@gnu.org>
5822
5823 * xdisp.c (append_space_for_newline): If the default face was
5824 remapped, use the remapped face for the appended newline.
5825 (extend_face_to_end_of_line): Use the remapped default face for
5826 extending the face to the end of the line.
5827 (display_line): Call extend_face_to_end_of_line when the default
5828 face was remapped. (Bug#11068)
5829
581355cc
EZ
58302012-03-29 Eli Zaretskii <eliz@gnu.org>
5831
5832 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5833
e8fc049f
SM
58342012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5835
5836 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5837
4fb9a543
GM
58382012-03-27 Glenn Morris <rgm@gnu.org>
5839
5840 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5841 Doc fixes.
5842
679910f1
KH
58432012-03-26 Kenichi Handa <handa@m17n.org>
5844
5845 * dispextern.h (struct glyph): Fix previous change. Change the
5846 bit length of glyphless.ch to 25 (Bug#11082).
5847
90d49b7f
CY
58482012-03-26 Chong Yidong <cyd@gnu.org>
5849
5850 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5851 (command_loop_1): Use it; inhibit selection update for
5852 handle-select-window too (Bug#8996).
5853
f514f6f0
FP
58542012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5855
e8fc049f 5856 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5857
bf43fa51
KH
58582012-03-25 Kenichi Handa <handa@m17n.org>
5859
5860 * dispextern.h (struct glyph): Change the bit length of
5861 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5862
8a0c01dd
EZ
58632012-03-24 Eli Zaretskii <eliz@gnu.org>
5864
5865 * s/ms-w32.h (tzname): Include time.h before redirecting to
5866 _tzname. Fixes the MSVC build. (Bug#9960)
5867
7d1c3a76
AS
58682012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5869
8ed79523
AS
5870 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5871 characters.
5872
7d1c3a76
AS
5873 * xterm.c (XTread_socket): Only modify handling_signal if
5874 !SYNC_INPUT. (Bug#11080)
5875
e99a9b8b
EZ
58762012-03-23 Eli Zaretskii <eliz@gnu.org>
5877
5878 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5879 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5880 when fetching a multibyte character consumes more bytes than
5881 CHAR_BYTES returns, due to unification of CJK characters in
5882 string_char. (Bug#11073)
5883
5063c0e1
TN
58842012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5885
5886 * process.c (wait_reading_process_output): Handle pty disconnect
5887 by refraining from sending oneself a SIGCHLD (bug#10933).
5888
9f851fbd
CY
58892012-03-22 Chong Yidong <cyd@gnu.org>
5890
5891 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5892
5063c0e1 5893 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5894 Mark string as coming from a prefix property.
5895 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5896 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5897
fb5b8aca
CY
58982012-03-21 Chong Yidong <cyd@gnu.org>
5899
5900 * xfaces.c (Vface_remapping_alist): Doc fix.
5901
62356a1b
EZ
59022012-03-20 Eli Zaretskii <eliz@gnu.org>
5903
5904 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5905 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5906 Doc fixes.
62356a1b 5907
025de85b
CY
59082012-03-20 Chong Yidong <cyd@gnu.org>
5909
5910 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5911 to reflect default non-nil value of redisplay-dont-pause.
5912
4827f94e
KH
59132012-03-19 Kenichi Handa <handa@m17n.org>
5914
5915 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5916 it fit in a valid range (Bug#11003).
5917
e50a24a2
EZ
59182012-03-18 Eli Zaretskii <eliz@gnu.org>
5919
5920 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5921 that is not from display property, accept the row as a "cursor
5922 row" if one of the string's character has a non-nil `cursor'
5923 property. Fixes cursor positioning when there are newlines in
5924 overlay strings, e.g. in icomplete.el. (Bug#11035)
5925
9af5ed87
PE
59262012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5929
d1f55f16
CY
59302012-03-12 Chong Yidong <cyd@gnu.org>
5931
5932 * eval.c (inhibit_lisp_code): Rename from
5933 inhibit_window_configuration_change_hook; move from window.c.
5934
5935 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5936 * window.c (run_window_configuration_change_hook)
5937 (syms_of_window): Callers changed.
5938
66c5eebd
CY
59392012-03-11 Chong Yidong <cyd@gnu.org>
5940
413df973
CY
5941 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5942
66c5eebd
CY
5943 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5944
1de11f56
CY
59452012-03-10 Chong Yidong <cyd@gnu.org>
5946
5947 * frame.c (other_visible_frames): Don't assume the selected frame
5948 is visible (Bug#10955).
5949
cae07000
SM
59502012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5951
5952 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5953
89c94350
JD
59542012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5955
5956 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5957 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5958 zero (Bug#10954).
5959
999dd333
GM
59602012-03-03 Glenn Morris <rgm@gnu.org>
5961
01a6dcc8 5962 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5963
de0100f2
EZ
59642012-03-02 Eli Zaretskii <eliz@gnu.org>
5965
5966 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5967 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5968 (redisplay_window, next_element_from_string): Fix typos in
5969 comments.
3e441275
EZ
5970 (redisplay_window): Pass to move_it_vertically the margin in
5971 pixels, not in screen lines.
de0100f2 5972
96a72ee9
GM
59732012-03-02 Glenn Morris <rgm@gnu.org>
5974
5975 * buffer.c (buffer-list-update-hook): Doc fix.
5976
312508d7
EZ
59772012-02-29 Eli Zaretskii <eliz@gnu.org>
5978
5979 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5980 push_it before setting up the iterator for the first overlay
5981 string, even if we have an empty string loaded.
5982 (next_overlay_string): If there's an empty string on the iterator
5983 stack, pop the stack. (Bug#10903)
5984
27f3c637
PE
59852012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5986
5987 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5988 Suggested by Stefan Monnier in
5989 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5990 * alloc.c (widen_to_Lisp_Object): New static function.
5991 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5992 and widening them to Lisp_Objects. This would work even if
5993 USE_LSB_TAG is defined and wide integers are used, which might
5994 happen in a future version of Emacs.
5995
3c9dfce6
CY
59962012-02-25 Chong Yidong <cyd@gnu.org>
5997
fa74b241
CY
5998 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5999 Doc fix.
6000
3c9dfce6
CY
6001 * xselect.c (Fx_selection_exists_p): Doc fix.
6002 (x_clipboard_manager_save_all): Print an informative message
6003 before saving to clipboard manager.
6004
9486df08
CY
60052012-02-24 Chong Yidong <cyd@gnu.org>
6006
6007 * keyboard.c (process_special_events): Handle all X selection
6008 requests in kbd_buffer, not just the next one (Bug#8869).
6009
f01d3321
CY
60102012-02-23 Chong Yidong <cyd@gnu.org>
6011
6012 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6013 call when setting menu-bar-lines and tool-bar-lines parameters.
6014 (unwind_create_frame_1): New helper function.
6015
6016 * window.c (inhibit_window_configuration_change_hook): New var.
6017 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6018 (syms_of_window): Initialize it.
f01d3321 6019
86b847b6
CY
60202012-02-22 Chong Yidong <cyd@gnu.org>
6021
6022 * xterm.c (x_draw_image_relief): Add missing type check for
6023 Vtool_bar_button_margin (Bug#10743).
6024
a59225b1
CY
60252012-02-21 Chong Yidong <cyd@gnu.org>
6026
6027 * fileio.c (Vfile_name_handler_alist): Doc fix.
6028
6029 * buffer.c (Fget_file_buffer): Protect against invalid file
6030 handler return value.
6031
310f5bd4
PE
60322012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6033
cb3a28cc
PE
6034 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6035 when computing $valmask.
6036
310f5bd4
PE
6037 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6038 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6039 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6040 It's useless in that case, and it can cause problems on hosts
6041 that allocate halves of EMACS_INT values separately.
6042 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6043 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6044 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6045 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6046 it avoids undefined behavior on hosts where shifting right by more
6047 than the word width has undefined behavior.
6048
2375c96a
CY
60492012-02-19 Chong Yidong <cyd@gnu.org>
6050
6051 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6052 (Funhandled_file_name_directory, Ffile_name_as_directory)
6053 (Fdirectory_file_name, Fexpand_file_name)
6054 (Fsubstitute_in_file_name): Protect against invalid file handler
6055 return values (Bug#10845).
6056
3eb49e71
EZ
60572012-02-18 Eli Zaretskii <eliz@gnu.org>
6058
6059 * .gdbinit (pitx): Fix incorrect references to fields of the
6060 iterator stack.
6061
7b926f3f
CY
60622012-02-17 Chong Yidong <cyd@gnu.org>
6063
6064 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6065
11273115
PE
60662012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6067
6068 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6069 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6070
c3a70e2b
CY
60712012-02-15 Chong Yidong <cyd@gnu.org>
6072
6073 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6074 marked as special. Also, starting docstrings with * is obsolete.
6075
0ca43699
AS
60762012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6077
6078 * gnutls.c (emacs_gnutls_write): Fix last change.
6079
2e8f3c56
LI
60802012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6081
6082 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6083 send_process.
6084
af70074f
SM
60852012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6086
6087 * keymap.c (Fsingle_key_description): Handle char ranges.
6088
95986d52
CY
60892012-02-12 Chong Yidong <cyd@gnu.org>
6090
afd83bd1
CY
6091 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6092 as that creates a dangerous corner case.
6093
95986d52
CY
6094 * window.c (Fdelete_window_internal): Invalidate the mouse
6095 highlight (Bug#9904).
6096
bd7da63e
GM
60972012-02-12 Glenn Morris <rgm@gnu.org>
6098
6099 * xselect.c (Fx_own_selection_internal)
6100 (Fx_get_selection_internal, Fx_disown_selection_internal)
6101 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6102 * nsselect.m (Fx_own_selection_internal)
6103 (Fx_disown_selection_internal, Fx_selection_exists_p)
6104 (Fx_selection_owner_p, Fx_get_selection_internal):
6105 Sync docs and argument specs with the xselect.c versions.
6106
77abcbc2
LI
61072012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6108
6109 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6110
90b671e2
EZ
61112012-02-11 Eli Zaretskii <eliz@gnu.org>
6112
1c0ca0b7
EZ
6113 * w32select.c (Fx_selection_exists_p): Sync doc string and
6114 argument list with xselect.c. (Bug#10783)
6115
6116 * w16select.c (Fx_selection_exists_p): Sync doc string and
6117 argument list with xselect.c. (Bug#10783)
90b671e2 6118
49241268
GM
61192012-02-10 Glenn Morris <rgm@gnu.org>
6120
6121 * fns.c (Fsecure_hash): Doc fix.
6122
f998bbe7 61232012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6124
6125 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6126
0992bd9c
CY
61272012-02-07 Chong Yidong <cyd@gnu.org>
6128
6129 * buffer.c (Fbuffer_local_variables)
6130 (buffer_lisp_local_variables): Handle unbound vars correctly;
6131 don't let Qunbound leak into Lisp.
6132
af008560
GM
61332012-02-07 Glenn Morris <rgm@gnu.org>
6134
dd605cc4
GM
6135 * image.c (Fimagemagick_types): Doc fix.
6136
af008560
GM
6137 * image.c (imagemagick-render-type): Change it from a lisp object
6138 to an integer. Move the doc here from the lisp manual.
6139 Treat all values not equal to 0 the same.
6140
1449fa1d
CY
61412012-02-06 Chong Yidong <cyd@gnu.org>
6142
6143 * doc.c (store_function_docstring): Avoid applying docstring of
6144 alias to base function (Bug#2603).
6145
3723ec07
AS
61462012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6147
6148 * .gdbinit (pp1, pv1): Remove redundant defines.
6149 (pr): Use pp.
6150
79c1cc1e
CY
61512012-02-04 Chong Yidong <cyd@gnu.org>
6152
6153 * nsterm.m: Declare a global (Bug#10694).
6154
d7f29f8e
EZ
61552012-02-04 Eli Zaretskii <eliz@gnu.org>
6156
cae07000
SM
6157 * w32.c (get_emacs_configuration_options):
6158 Include --enable-checking, if specified, in the return value.
d7f29f8e 6159
3b95a6f9
MR
61602012-02-04 Martin Rudalics <rudalics@gmx.at>
6161
6162 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6163 after rounding frame sizes. (Bug#9723)
6164
d6fa96a6
EZ
61652012-02-04 Eli Zaretskii <eliz@gnu.org>
6166
6167 * keyboard.c (adjust_point_for_property): Don't position point
6168 before BEGV. (Bug#10696)
6169
df0b2940
PE
61702012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6171
6172 Handle overflow when computing char display width (Bug#9496).
6173 * character.c (char_width): Return EMACS_INT, not int.
6174 (char_width, c_string_width): Check for overflow when
6175 computing the width; this is possible now that individual
6176 characters can have unbounded width. Problem introduced
6177 by merge from Emacs 23 on 2012-01-19.
6178
6bee44d6
MA
61792012-02-02 Michael Albinus <michael.albinus@gmx.de>
6180
6181 * dbusbind.c (Fdbus_register_method): Mention the return value
6182 :ignore in the docstring.
6183
44f92739
GM
61842012-02-02 Glenn Morris <rgm@gnu.org>
6185
1b9f60cc
GM
6186 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6187
44f92739
GM
6188 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6189 Unconditionally set to t. (Bug#10673)
6190 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6191 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6192 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6193
c5d3843c
KH
61942012-02-02 Kenichi Handa <handa@m17n.org>
6195
6196 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6197 0, do not call append_composite_glyph.
6198
159462d4 61992012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6200
6201 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6202 NULL (Bug#6988).
6203 (x_produce_glyphs): If the component of a composition is a null
6204 string, set it->pixel_width to 1 to avoid zero-width glyph.
6205
78cef877
EZ
62062012-02-01 Eli Zaretskii <eliz@gnu.org>
6207
6208 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6209 first 2 arguments are identical. This makes inserting large
6210 output from a subprocess an order of magnitude faster on
6211 MS-Windows, where all sbrk'ed memory is always contiguous.
6212
97897668
GM
62132012-01-31 Glenn Morris <rgm@gnu.org>
6214
6215 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6216 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6217 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6218
31fd3586
GM
62192012-01-29 Glenn Morris <rgm@gnu.org>
6220
6221 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6222
0e24a8b2
CY
62232012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6224
6225 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6226
cc0adcb0
CY
62272012-01-28 Chong Yidong <cyd@gnu.org>
6228
6229 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6230
acc28cb9
CY
62312012-01-26 Chong Yidong <cyd@gnu.org>
6232
9c69cfb7
CY
6233 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6234
acc28cb9
CY
6235 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6236 repeat counts (Bug#10507).
6237
48da7392
GM
62382012-01-26 Glenn Morris <rgm@gnu.org>
6239
6240 * lread.c (syms_of_lread): Doc fix.
6241
14af5f7f
CY
62422012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6243
6244 * coding.c (encode_designation_at_bol): Change return value to
6245 EMACS_INT.
6246
0b21c100
CY
62472012-01-25 Chong Yidong <cyd@gnu.org>
6248
6249 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6250
3c2907f7
CY
62512012-01-21 Chong Yidong <cyd@gnu.org>
6252
6253 * floatfns.c (Fcopysign): Make the second argument non-optional,
6254 since nil is not allowed anyway.
6255
959ad23f
AS
62562012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6257
6258 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6259 (send_process): Likewise.
6260
34a02f46
MR
62612012-01-19 Martin Rudalics <rudalics@gmx.at>
6262
6263 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6264 (Vwindow_persistent_parameters): Do not use Qstate.
6265 Rewrite doc-strings.
34a02f46 6266
1259009a 62672012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6268
6269 * character.c (char_width): New function.
70d4fdf6
GM
6270 (Fchar_width, c_string_width, lisp_string_width):
6271 Use char_width (Bug#9496).
25ed9e61 6272
6a6ee00d
MR
62732012-01-16 Martin Rudalics <rudalics@gmx.at>
6274
6275 * window.c (Vwindow_persistent_parameters): New variable.
6276 (Fset_window_configuration, save_window_save): Handle persistent
6277 window parameters.
6278
c85efaf7
EZ
62792012-01-14 Eli Zaretskii <eliz@gnu.org>
6280
6281 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6282 thrashing the stack of the thread. (Bug#9087)
6283
5944709e
PE
62842012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6285
6286 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6287
e71f5d99
EZ
62882012-01-11 Eli Zaretskii <eliz@gnu.org>
6289
6290 * xdisp.c (rows_from_pos_range): Handle the case where the
6291 highlight ends on a newline. (Bug#10464)
6292 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6293 he end column for display of highlight that ends on a newline
6294 before a R2L line.
6295
ce316182
GM
62962012-01-11 Glenn Morris <rgm@gnu.org>
6297
6298 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6299 from load-path also when installation-directory is nil. (Bug#10208)
6300
5b43da69
GM
63012012-01-10 Glenn Morris <rgm@gnu.org>
6302
74cc8ff9
GM
6303 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6304
7d8d6e4e
GM
6305 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6306 Update template values to be closer to their typical values these days.
5b43da69 6307
a0db8d43
EZ
63082012-01-09 Eli Zaretskii <eliz@gnu.org>
6309
6310 * xdisp.c (rows_from_pos_range): Accept additional argument
6311 DISP_STRING, and accept any glyph in a row whose object is that
6312 string as eligible for mouse highlight. Fixes mouse highlight of
6313 display strings from overlays. (Bug#10464)
6314
9a0115ab 63152012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6316
b9110d6a 6317 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6318 * fileio.c (auto_saving_dir_umask): New static var.
6319 (Fmake_directory_internal): Use it.
6320 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6321 creating the directory. The old code temporarily assigns
6322 too-generous permissions to the directory.
6323 (do_auto_save_eh): Clear it.
b9110d6a 6324 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6325 that the var is always cleared.
6326
6c1bd3f3
EZ
63272012-01-07 Eli Zaretskii <eliz@gnu.org>
6328
6329 * search.c (scan_buffer): Pass character positions to
6330 know_region_cache, not byte positions. (Bug#6540)
6331
069d2b50
L
63322012-01-07 LynX <_LynX@bk.ru> (tiny change)
6333
6334 * w32.c (sys_rename): Report EXDEV when rename of a directory
6335 fails because the target is on another logical disk. (Bug#10284)
6336
75bf0d33
DB
63372012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6338
6339 * xterm.c (x_embed_request_focus): New function.
6340
6341 * xterm.h: Add prototype.
6342
6343 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6344
1c6e5a32
GM
63452012-01-05 Glenn Morris <rgm@gnu.org>
6346
6347 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6348
651e947e
EZ
63492012-01-01 Eli Zaretskii <eliz@gnu.org>
6350
6351 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6352 Load gnutls_transport_set_lowat only if GnuTLS version is below
6353 2.11.1.
6354 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6355 GnuTLS versions below 2.11.1.
6356
3778cdd8
AL
63572011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6358
6359 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6360 to the doc string advising against its use for altering the way
6361 windows are scrolled.
6362
0e5317f7
KH
63632011-12-28 Kenichi Handa <handa@m17n.org>
6364
6365 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6366 coding-system ASCII compatible only when it does not produce BOM
6367 on encoding (Bug#10383).
6368
93d5ca1f
JD
63692011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6370
6371 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6372 can scroll.
6373 (create_and_show_popup_menu): Always use menu_position_func for
6374 Gtk3 (Bug#10361).
6375
ca22b785
AS
63762011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6377
6378 * callint.c (Fcall_interactively): Don't truncate prompt string.
6379
d048e1e6
EZ
63802011-12-23 Eli Zaretskii <eliz@gnu.org>
6381
6382 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6383 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6384 resumed from there (after widening). (Bug#10360)
d048e1e6 6385
5ccaba1f
JD
63862011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6387
6388 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6389
204ee57f
JD
63902011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6391
b81d40f0
JB
6392 * nsterm.m (x_free_frame_resources):
6393 Release f->output_data.ns->miniimage.
204ee57f
JD
6394 (ns_index_color): Fix indentation. Do not retain
6395 color_table->colors[i].
6396
6397 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6398 before returning.
6399
6400 * nsfns.m (x_set_background_color): Assign return value from
6401 ns_index_color to face-background instead of NSColor*.
6402 (ns_implicitly_set_icon_type): Fix indentation.
6403 Change assignment in for loop to comparison.
6404
6405 * emacs.c (ns_pool): New variable.
6406 (main): Assign ns_pool.
6407 (Fkill_emacs): Call ns_release_autorelease_pool.
6408
6409 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6410 autorelease fdesc, release fdAttrs and tdict.
6411 (ns_get_covering_families): Release charset.
6412 (ns_findfonts): Release NSFontDescriptor created with new.
6413 (ns_uni_to_glyphs): Fix indentation.
6414 (setString): Release attrStr before assigning new value.
6415
c803b2b7
JD
64162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6417
678f4426
JD
6418 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6419 and NS_IMPL_COCOA.
6420 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6421 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6422
cd394be1 64232011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6424
5fecd5fc
JD
6425 * nsterm.m (ns_term_init): Subscribe for notifications
6426 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6427 to method trackingNotification in EmacsMenu.
6428
6429 * nsmenu.m (trackingMenu): New variable.
3771cb17 6430 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6431 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6432 from Aquamacs (Bug#7030).
678f4426
JD
6433
64342011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6435
c803b2b7
JD
6436 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6437 (symbol_to_nsstring): Fix indentation.
6438 (ns_symbol_to_pb): New function.
cae07000
SM
6439 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6440 (Fns_rotate_cut_buffers_internal): Remove.
6441 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6442 Fns_store_cut_buffer_internal.
6443 (ns_get_foreign_selection, Fx_own_selection_internal)
6444 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6445 (Fns_get_selection_internal, Fns_store_selection_internal):
6446 Use ns_symbol_to_pb and check if return value is nil.
6447 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6448 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6449 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6450 renamed to Sns_store_selection_internal.
6451 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6452 and remove this function.
6453 (ns_handle_selection_clear): Remove, never used.
6454 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6455 here.
6456
e1b01a3a
KB
64572011-12-17 Ken Brown <kbrown@cornell.edu>
6458
6459 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6460 GID is unknown (Bug#10257).
6461
2adb6e85
PE
64622011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6463
6464 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6465 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6466 which caused a build failure on GNU/Linux IA-64. This problem was
6467 introduced by my 2011-10-07 patch.
6468
d1d7b339
JL
64692011-12-15 Juri Linkov <juri@jurta.org>
6470
6471 * image.c (imagemagick_error): New function. (Bug#10112)
6472 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6473 Use `imagemagick_error' where ImageMagick functions return
6474 `MagickFalse'.
6475 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6476 proper order.
6477
100d5755
KH
64782011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6479
6480 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6481 fill background (Bug#8992).
6482
454592a6
MR
64832011-12-13 Martin Rudalics <rudalics@gmx.at>
6484
6485 * window.c (Vwindow_combination_resize)
6486 (Vwindow_combination_limit): Use t instead of non-nil in
6487 doc-strings.
61d4b438
MR
6488 (Vrecenter_redisplay): Add first sentence of doc-string on
6489 separate line.
53524d93 6490 (Frecenter): Fix doc-string typo.
454592a6 6491
3633e3aa
KH
64922011-12-11 Kenichi Handa <handa@m17n.org>
6493
6494 * coding.c (Funencodable_char_position): Pay attention to the
6495 buffer text relocation (Bug#9389).
6496
7b9d523a 64972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6498
7b9d523a
JD
6499 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6500 gtk_init (Bug#10100).
6501
b73189c6
EZ
65022011-12-10 Eli Zaretskii <eliz@gnu.org>
6503
6504 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6505 IT->string is nil. (Bug#10263)
6506
f7dfe5d6
JD
65072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6508
83faebb4
JD
6509 * nsterm.h (x_free_frame_resources): Declare.
6510
f7dfe5d6
JD
6511 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6512 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6513
6514 * nsterm.h (ns_get_defaults_value): Declare.
6515
6516 * nsterm.m (ns_default): Call ns_get_defaults_value.
6517
7cd4e72c
EZ
65182011-12-09 Eli Zaretskii <eliz@gnu.org>
6519
6520 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6521 (Bug#10170)
6522
b34d7317
YM
65232011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6524
6525 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6526 that where the value of an _OBJC_* symbol points to is in the .bss
6527 section (Bug#10240).
6528
76470ad1
KH
65292011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6530
6531 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6532 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6533
745fff94
KH
65342011-12-08 Kenichi Handa <handa@m17n.org>
6535
6536 * ftfont.c (get_adstyle_property): Fix previous change
6537 (Bug#10233).
6538
6e44397c
JB
65392011-12-07 Juanma Barranquero <lekktu@gmail.com>
6540
6541 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6542 dirs from the default value of EMACSLOADPATH (bug#10208).
6543
7efa6272
GM
65442011-12-07 Glenn Morris <rgm@gnu.org>
6545
6546 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6547 installation and source directories as well. (Bug#10208)
6548
f6fc4d87
CY
65492011-12-06 Chong Yidong <cyd@gnu.org>
6550
6551 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6552
2bf26180
GM
65532011-12-06 Glenn Morris <rgm@gnu.org>
6554
6555 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6556 as an error, not just -1. (Bug#10217)
6557
3a6ad4f0
CY
65582011-12-05 Chong Yidong <cyd@gnu.org>
6559
6560 * keyboard.c (process_special_events): New function.
6561 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6562
75a3b399
PE
65632011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6564
6565 * coding.c (encode_designation_at_bol): Don't use uninitialized
6566 local variable (Bug#9318).
6567
c3c9e25e
KH
65682011-12-05 Kenichi Handa <handa@m17n.org>
6569
6570 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6571 return Qnil (Bug#8046, Bug#10193).
6572
5eb05ea3
KH
65732011-12-05 Kenichi Handa <handa@m17n.org>
6574
6575 * coding.c (encode_designation_at_bol): New args charbuf_end and
6576 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6577 (coding_set_source): Return how many bytes coding->source was
6578 relocated.
6579 (coding_set_destination): Return how many bytes
6580 coding->destination was relocated.
6581 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6582 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6583
65842011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6585
6586 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6587 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6588 macro (Bug#9318).
6589
65902011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6591
6592 The following changes are to fix Bug#9318.
6593
a79703f5 6594 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6595 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6596 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6597 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6598
7dbda6df
JB
65992011-12-05 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * lisp.h (process_quit_flag): Fix external declaration.
6602
6d5eb5b0
SM
66032011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6604
6605 Don't macro-inline non-performance-critical code.
6606 * eval.c (process_quit_flag): New function.
6607 * lisp.h (QUIT): Use it.
6608
a0c3fad0
JD
66092011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6610
6611 * nsfns.m (get_geometry_from_preferences): New function.
6612 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6613
6c07aac2
AS
66142011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6615
6616 * emacs.c (Qkill_emacs): Define.
6617 (syms_of_emacs): Initialize it.
6618 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6619 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6620 (quit_throw_to_read_char): Add parameter `from_signal'.
6621 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6622 * lisp.h (QUIT): Call Fkill_emacs if requested.
6623
c052ead4
JD
66242011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6625
6626 * widget.c (update_wm_hints): Return if wmshell is null.
6627 (widget_update_wm_size_hints): New function.
6628
6629 * widget.h (widget_update_wm_size_hints): Declare.
6630
6631 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6632 widget_update_wm_size_hints (Bug#10104).
6633
9e49252b
EZ
66342011-12-03 Eli Zaretskii <eliz@gnu.org>
6635
6636 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6637 before a newline, prepare the bidi iterator for consuming the
6638 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6639 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6640
02b16839
JL
66412011-12-02 Juri Linkov <juri@jurta.org>
6642
6643 * search.c (Fword_search_regexp): New Lisp function created from
6644 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6645 (Fword_search_backward, Fword_search_forward)
6646 (Fword_search_backward_lax, Fword_search_forward_lax):
6647 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6648 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6649
0068070e
SM
66502011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6651
6652 * fileio.c (Finsert_file_contents): Move after-change-function call
6653 to before the "handled:" label, since all "goto handled" appear in
6654 cases where the *-change-functions have already been properly called
6655 (bug#10117).
6656
3360a3fc
AS
66572011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6658
6659 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6660 waiting for input. (Bug#10169)
6661
73d6c093
EZ
66622011-11-30 Eli Zaretskii <eliz@gnu.org>
6663
6664 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6665 verifies glyph row's hash code--we have just reallocated the
6666 glyphs, so their contents can be complete garbage. (Bug#10164)
6667
febe6bea
JB
66682011-11-30 Juanma Barranquero <lekktu@gmail.com>
6669
6670 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6671
801a4313
EZ
66722011-11-30 Eli Zaretskii <eliz@gnu.org>
6673
6674 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6675 attributes are tested _before_ calling verify_row_hash, to protect
6676 against GCC re-ordering of the tests. (Bug#10164)
6677
2b56b87e
JD
66782011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6679
6680 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6681
6682 * xterm.c (handle_one_xevent): Only set async_visible and friends
6683 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6684 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6685 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6686
dbf31225
PE
66872011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6688
6689 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6690 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6691 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6692 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6693 All uses changed to use GCPRO1 etc.
6694 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6695 Revert to old implementation (i.e., before 2011-03-11).
6696
1305621b
YM
66972011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6698
6699 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6700 of scroll runs so as to avoid assigning disabled bogus rows and
6701 unnecessary graphics copy operations.
6702
8c9afb46
EZ
67032011-11-27 Eli Zaretskii <eliz@gnu.org>
6704
6705 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6706 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6707 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6708 (malloc, free, realloc, calloc): Redirect to e_* only when
6709 compiling Emacs.
6710
6711 * lisp.h (GCTYPEBITS): Move before first use.
6712 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6713 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6714 this macro definition.
6715
6716 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6717 _MSC_VER.
6718
54e9e3bf
JD
67192011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6720
6d5eb5b0
SM
6721 * gtkutil.c (xg_create_frame_widgets):
6722 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6723 present with Gtk+ 2.0.
6724
83aca1cb
PE
67252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6726
6727 * fileio.c (Finsert_file_contents): Undo previous change; see
6728 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6729
5b76caa4
PE
67302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6731
6732 Rename locals to avoid shadowing.
6733 * fileio.c (Finsert_file_contents):
6734 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6735 * process.c (wait_reading_process_output):
6736 Rename inner 'proc' to 'p' to avoid shadowing.
6737 Indent for consistency with usual Emacs style.
6738
8c535114
EZ
67392011-11-25 Eli Zaretskii <eliz@gnu.org>
6740
6741 * xdisp.c (redisplay_window): If cursor row is not fully visible
6742 after recentering, and scroll-conservatively is set to a large
6743 number, scroll window by a few more lines to make the cursor fully
6744 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6745 (start_display): Don't move to the next line if the display should
6746 start at a newline that is part of a display vector or an overlay
6747 string. (Bug#10119)
8c535114 6748
fa4fdb5c
JL
67492011-11-24 Juri Linkov <juri@jurta.org>
6750
6751 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6752 after the `MagickPingImage' call. (Bug#10112)
6753
90ec88df
CY
67542011-11-23 Chong Yidong <cyd@gnu.org>
6755
6756 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6757
56e2e794
MR
67582011-11-23 Martin Rudalics <rudalics@gmx.at>
6759
6760 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6761 making another buffer current. (Bug#10114)
6762
b6e64c41
GM
67632011-11-23 Glenn Morris <rgm@gnu.org>
6764
6765 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6766
6b21de18
CY
67672011-11-23 Chong Yidong <cyd@gnu.org>
6768
6769 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6770 using it (Bug#5984).
6771
b12cd789
EZ
67722011-11-22 Eli Zaretskii <eliz@gnu.org>
6773
6774 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6775 and header-lines, as they don't have one computed for them.
6776 (Bug#10098)
6777
6778 * .gdbinit (prow): Make displayed values more self-explaining.
6779 Add row's hash code.
6780
261b6fd4
LMI
67812011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6782
6783 * process.c (wait_reading_process_output): Fix asynchrounous
6784 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6785 (wait_reading_process_output): Add comment and URL.
261b6fd4 6786
e7cfd277
JD
67872011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6788
6789 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6790
a9b9b7f5
CY
67912011-11-21 Chong Yidong <cyd@gnu.org>
6792
6793 * window.c (Fnext_window, Fprevious_window): Doc fix.
6794
b0d15b4f
SM
67952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6796
6797 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6798
fe7a3057
JB
67992011-11-20 Juanma Barranquero <lekktu@gmail.com>
6800
6801 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6802
d2999b1a
MR
68032011-11-20 Martin Rudalics <rudalics@gmx.at>
6804
6805 * window.c (Fset_window_combination_limit): Rename argument
6806 STATUS to LIMIT.
6807 (Vwindow_combination_limit): Remove "status" from doc-string.
6808
d5ff9cd0
AS
68092011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6810
6811 * m/ibms390.h: Remove.
6812 * m/ibms390x.h: Don't include "ibms390.h".
6813
a5bb9bd3
SM
68142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6815
6816 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6817 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6818
cd1181db
JB
68192011-11-20 Juanma Barranquero <lekktu@gmail.com>
6820
6821 * casetab.c (Fset_case_table):
6822 * charset.c (Fcharset_after): Fix typos.
6823
615a3b8d 68242011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6825
17e845af
PE
6826 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6827 Otherwise, valgrind does not work on some platforms.
6828 Problem reported by Andreas Schwab in
6a0bf43d
PE
6829 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6830 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6831 is set, removing the need for VIRT_ADDRESS_VARIES.
6832 (PURE_P): Use a more-efficient implementation that needs just one
6833 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6834 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6835 to 4 (xorl, subq, cmpq, setbe).
6836 * alloc.c (pure): Always extern now, since that's the
6837 VIRT_ADDR_VARIES behavior.
6838 (PURE_POINTER_P): Use a single comparison, not two, for
6839 consistency with the new puresize.h.
6840 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6841 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6842 Remove VIRT_ADDR_VARIES no longer needed.
6843
f8fe6f96
EZ
68442011-11-19 Eli Zaretskii <eliz@gnu.org>
6845
6846 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6847 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6848 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6849 behave as if the cursor position were at the window margin.
6850
6851 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6852 and the cursor position is out of bounds, behave as if the cursor
6853 position were at the window margin. (Bug#10075)
6854
df05a53c
CY
68552011-11-18 Chong Yidong <cyd@gnu.org>
6856
6857 * window.c (Fwindow_combination_limit): Make first argument
6858 non-optional, since it is meaningless for live windows like the
6859 selected window.
61ccba97 6860
2071918e
DA
68612011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6862
6863 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6864
b50a28de
SM
68652011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6866
6867 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6868 (graft_intervals_into_buffer): Simplify.
6869
015137db
EZ
68702011-11-18 Eli Zaretskii <eliz@gnu.org>
6871
6872 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6873 hash values of the two rows.
6874 (copy_row_except_pointers): Preserve the used[] arrays and the
6875 hash values of the two rows. (Bug#10035)
68c95424 6876 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6877
6878 * xdisp.c (row_hash): New function, body extracted from
6879 compute_line_metrics.
6880 (compute_line_metrics): Call row_hash, instead of computing the
6881 hash code inline.
6882
6883 * dispnew.c (verify_row_hash): Call row_hash for computing the
6884 hash code of a row, instead of duplicating code from xdisp.c.
6885
6886 * dispextern.h (row_hash): Add prototype.
6887
a2addb04
TH
68882011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6889
6890 * frame.c (delete_frame): Don't delete the terminal when the last
6891 X frame is closed if emacs is built with GTK toolkit.
6892
df85d315
JB
68932011-11-17 Juanma Barranquero <lekktu@gmail.com>
6894
6895 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6896
a0c2d0ae
MR
68972011-11-17 Martin Rudalics <rudalics@gmx.at>
6898
6899 * window.c (Vwindow_splits): Rename to
6900 Vwindow_combination_resize. Suggested by Juri Linkov.
6901 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6902 of Vwindow_splits.
6903
58179cce
JB
69042011-11-16 Juanma Barranquero <lekktu@gmail.com>
6905
7877f373
JB
6906 * nsfns.m (Fns_font_name):
6907 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6908
b6f67890
MR
69092011-11-16 Martin Rudalics <rudalics@gmx.at>
6910
6911 * window.h (window): Rename slot "nest" to "combination_limit".
6912 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6913 (Fset_window_nest): Rename to Fset_window_combination_limit.
6914 (Vwindow_nest): Rename to Vwindow_combination_limit.
6915 (recombine_windows, make_parent_window, make_window)
6916 (Fsplit_window_internal, saved_window)
6917 (Fset_window_configuration, save_window_save): Rename all
6918 occurrences of window_nest to window_combination_limit.
6919
c7015153
JB
69202011-11-15 Juanma Barranquero <lekktu@gmail.com>
6921
6922 * image.c (imagemagick_load_image): Fix typo.
6923
322ad6ec
EZ
69242011-11-14 Eli Zaretskii <eliz@gnu.org>
6925
6926 * xdisp.c (display_line): Move the call to
6927 highlight_trailing_whitespace before the call to
6928 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6929 faces of all the glyphs to compute ROW's hash value.
6930 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6931
f067b8ec
JB
69322011-11-14 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6935 just return (bug#10044).
6936
1e5b2111
EZ
69372011-11-12 Eli Zaretskii <eliz@gnu.org>
6938
7ef3cbd5
EZ
6939 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6940 with user-defined heap size. Bump the default size of the temacs
6941 heap to 27MB, to avoid memory warning when running temacs.
6942 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6943
1e5b2111
EZ
6944 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6945 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6946 (verify_row_hash) [XASSERTS]: New function.
6947 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6948 that the hash value of glyph rows is correct.
1e5b2111 6949
89d61221
MR
69502011-11-12 Martin Rudalics <rudalics@gmx.at>
6951
6952 * window.h (window): Remove splits slot.
6953 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6954 (Fdelete_other_windows_internal, make_parent_window)
6955 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6956 (Fset_window_configuration, save_window_save): Don't deal with
6957 split status of windows.
6958 (saved_window): Remove splits slot.
6959 (Vwindow_splits): Rewrite doc-string.
6960
97f18cc8
JD
69612011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6962
6963 * xfns.c (unwind_create_frame):
6964 * nsfns.m (unwind_create_frame):
6965 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6966 Vframe_list (Bug#9999).
6967
22a648b4
DA
69682011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6969
0b381c7e 6970 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6971
659afede
KH
69722011-11-11 Kenichi Handa <handa@m17n.org>
6973
6974 * callproc.c (Fcall_process): Set the member dst_multibyte of
6975 process_coding.
6976
9ac0394b
KH
69772011-11-11 Johan Bockgård <bojohan@gnu.org>
6978
6979 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6980 avoid a crash (bug#9496).
6981
2fbdc249
CY
69822011-11-09 Chong Yidong <cyd@gnu.org>
6983
6984 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6985 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6986
ac6b1f81
PE
69872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6988
6989 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6990
09db192c
PE
69912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6992
6993 Avoid some portability problems by eschewing 'extern inline' functions.
6994 The trivial performance wins aren't worth the portability hassles; see
6995 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6996 et seq.
6997 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6998 (window_box_width, window_box_left, window_box_left_offset)
6999 (window_box_right, window_box_right_offset): Undo previous change,
7000 by removing the "extern"s.
7001 * intervals.c (adjust_intervals_for_insertion)
7002 (adjust_intervals_for_deletion): Undo previous change,
7003 making these static again.
7004 (offset_intervals, temp_set_point_both, temp_set_point)
7005 (copy_intervals_to_string): No longer inline.
7006 * xdisp.c (window_text_bottom_y, window_box_width)
7007 (window_box_height, window_box_left_offset)
7008 (window_box_right_offset, window_box_left, window_box_right)
7009 (window_box): No longer inline.
7010
105216ed
CY
70112011-11-08 Chong Yidong <cyd@gnu.org>
7012
7013 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7014 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7015 Signal an error if not a live window.
105216ed
CY
7016 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7017 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7018
ae9e237f
JB
70192011-11-07 Juanma Barranquero <lekktu@gmail.com>
7020
7021 * lisp.h (syms_of_abbrev): Remove declaration.
7022 Reported by CHENG Gao <chenggao@royau.me>.
7023
c7aa8333
EZ
70242011-11-07 Eli Zaretskii <eliz@gnu.org>
7025
7026 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7027 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7028 of temacs in GUI mode.
7029
be7f5545
MR
70302011-11-07 Martin Rudalics <rudalics@gmx.at>
7031
7032 * window.h: Declare delete_all_child_windows instead of
7033 delete_all_subwindows.
7034 * window.c (Fwindow_nest, Fset_window_nest)
7035 (Fset_window_new_total, Fset_window_new_normal)
7036 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7037 (delete_all_subwindows): Rename to delete_all_child_windows.
7038 (Fdelete_other_windows_internal, Fset_window_configuration):
7039 Call delete_all_child_windows instead of delete_all_subwindows.
7040 * frame.c (delete_frame): Call delete_all_child_windows instead
7041 of delete_all_subwindows.
7042
ca78dc43
PE
70432011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7044
7045 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7046 This is also needed for porting to any host where GC_MARK_STACK is
7047 not GC_MAKE_GCPROS_NOOPS.
7048 (which_symbols): Use it.
7049
a0241d01
KH
70502011-11-07 Kenichi Handa <handa@m17n.org>
7051
7052 * coding.c (coding_set_destination): Check coding->src_pos only
7053 when coding->src_object is a buffer (bug#9910).
7054
7055 * process.c (send_process): Set the member src_multibyte of coding
7056 to 0 (bug#9911) when sending a unibyte text.
7057
7058 * callproc.c (Fcall_process): Set the member src_multibyte of
7059 process_coding to 0 (bug#9912).
7060
a64bfdfa 70612011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7062
7063 * xmenu.c (cleanup_widget_value_tree): New function.
7064 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7065 calling free_menubar_widget_value_tree directly (Bug#9830).
7066
cb41b32a
PE
70672011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7068
7069 Fix some portability problems with 'inline'.
7070 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7071 (window_box_width, window_box_left, window_box_left_offset)
7072 (window_box_right, window_box_right_offset): Declare extern.
7073 Otherwise, these inline functions do not conform to C99 and
7074 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7075 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7076 * intervals.c (adjust_intervals_for_insertion)
7077 (adjust_intervals_for_deletion): Now extern, because otherwise the
7078 extern inline functions 'offset_intervals' couldn't refer to it.
7079 (static_offset_intervals): Remove.
7080 (offset_intervals): Rewrite using the old contents of
7081 static_offset_intervals. The old version didn't conform to C99
7082 because an extern inline function contained a reference to an
7083 identifier with static linkage.
7084
b7041366
AS
70852011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7086
7087 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7088 GC.
7089
88a37c4d
EZ
70902011-11-06 Eli Zaretskii <eliz@gnu.org>
7091
7092 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7093 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7094 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7095 return Qleft_to_right.
7096
49745b39
CY
70972011-11-06 Chong Yidong <cyd@gnu.org>
7098
7099 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7100 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7101 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7102 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7103 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7104 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7105 (Fwindow_vscroll): Doc fix.
7106 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7107 argument, since it makes no sense to pass a live window and for
7108 consistency with window-child.
7109
1f05cd82
CS
71102011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7111
7112 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7113 support MSVC.
7114
22610910
JR
71152011-11-05 Jason Rumney <jasonr@gnu.org>
7116
7117 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7118 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7119 fonts (Bug#6029).
7120 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7121 bitwise arithmetic preventing use of unicode-sip and non-truetype
7122 opentype fonts.
7123
a06776b2
EZ
71242011-11-05 Eli Zaretskii <eliz@gnu.org>
7125
3ad924ba
EZ
7126 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7127 "emacs"-only part.
7128
a06776b2
EZ
7129 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7130 initialization code to keep similarity to xfns.c after changes
7131 from 2011-11-05.
7132
c9e7db78
JD
71332011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7134
a97f8f3f
JD
7135 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7136 (unwind_create_frame): New function (Bug#9943).
7137 (Fx_create_frame): Restructure code to be more similar to the one in
7138 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7139 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7140 Move terminal->reference_count++ just before making the frame official
7141 (Bug#9943).
7142
7143 * nsterm.m (x_free_frame_resources): New function.
7144 (x_destroy_window): Move code to x_free_frame_resources.
7145
c9e7db78 7146 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7147 (Fx_create_frame, x_create_tip_frame):
7148 Move terminal->reference_count++ just before making the frame
75f1671a 7149 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7150 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7151
a6fc3b5c
EZ
71522011-11-05 Eli Zaretskii <eliz@gnu.org>
7153
7154 Support MSVC build with newer versions of Visual Studio.
7155 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7156 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7157 nt/gmake.defs.
7158
7159 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7160 which are not supported by MSVC.
7161 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7162 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7163 bitfields.
7164 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7165 types in bitfields.
7166 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7167
7168 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7169
58179cce 71702011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7171
7172 Support MSVC build with newer versions of Visual Studio.
7173 * w32.c: Don't include w32api.h for MSVC.
7174 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7175
7176 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7177 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7178 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7179 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7180 e_* cousins.
7181 (alloca) [_MSC_VER]: Define to _alloca.
7182
7183 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7184
7185 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7186
a58c13ed
EZ
71872011-11-04 Eli Zaretskii <eliz@gnu.org>
7188
7189 * xdisp.c (note_mouse_highlight): If either of
7190 previous/next-single-property-change returns nil, treat that as
7191 the beginning or the end of the buffer. (Bug#9955)
7192
fe0b6370
JD
71932011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7194
a58c13ed 7195 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7196 label is not null (Bug#9951).
7197 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7198 may be NULL.
7199
89bd5ee1
EZ
72002011-11-04 Eli Zaretskii <eliz@gnu.org>
7201
7202 * window.c (Fwindow_body_size): Mention in the doc string that the
7203 return value is in frame's canonical units. (Bug#9949)
7204
84c3edb9
EZ
72052011-11-03 Eli Zaretskii <eliz@gnu.org>
7206
4e2fb5c7
EZ
7207 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7208
84c3edb9 7209 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7210 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7211 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7212
bc17a887
EZ
72132011-11-01 Eli Zaretskii <eliz@gnu.org>
7214
7215 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7216 Don't stop backward scan on the continuation glyph, even though
7217 its CHARPOS is positive.
6d5eb5b0
SM
7218 (mouse_face_from_buffer_pos, note_mouse_highlight):
7219 Rename cover_string to disp_string.
bc17a887 7220
4ee88440
MR
72212011-11-01 Martin Rudalics <rudalics@gmx.at>
7222
7223 * window.c (temp_output_buffer_show): Don't use
7224 Vtemp_buffer_show_specifiers.
7225 (Vtemp_buffer_show_specifiers): Remove unused variable.
7226
c2ff3c02
EZ
72272011-10-30 Eli Zaretskii <eliz@gnu.org>
7228
7229 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7230 past the beginning of the current glyph matrix.
7231
58179cce 72322011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7233
7234 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7235 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7236 HAVE_GTK3 (Bug#9869).
b77a6a7f 7237
3b574623
JD
7238 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7239 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7240
b77a6a7f
JD
7241 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7242
7243 * xterm.c: Declare x_handle_net_wm_state to return int.
7244 (handle_one_xevent): Check if we are iconified but don't have
7245 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7246 (get_current_wm_state): Return non-zero if not hidden,
7247 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7248 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7249 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7250 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7251
196e41e4
PE
72522011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7253
7254 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7255 so that this new function doesn't get optimized away by a
7256 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7257
021f2e1a
AS
72582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7259
7260 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7261
8b058d44
EZ
72622011-10-29 Eli Zaretskii <eliz@gnu.org>
7263
7264 Fix the `xbytecode' command.
7265 * .gdbinit (xprintbytestr): New command.
b50a28de 7266 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7267 (xbytecode): Print the byte-code string as well.
7268
4452fb80
EZ
72692011-10-29 Kim Storm <storm@cua.dk>
7270
8b058d44
EZ
7271 * alloc.c (which_symbols): New function.
7272
21b72067
AS
72732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7274
7275 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7276 line. (Bug#9903)
7277
83ed7b5c
GM
72782011-10-29 Glenn Morris <rgm@gnu.org>
7279
7280 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7281 Not clear what it was for, and it causes various bugs. (Bug#9839)
7282
5a7a728b
EZ
72832011-10-28 Eli Zaretskii <eliz@gnu.org>
7284
7285 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7286 possible random value that matches one of those tested as
7287 condition to clear the mouse face.
7288
d3d0842f
CY
72892011-10-28 Chong Yidong <cyd@gnu.org>
7290
7291 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7292
31b39d13
DN
72932011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7294
7295 * window.c (make_window): Initialize phys_cursor_on_p.
7296
9aba6043
SM
72972011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7298
7299 * lisp.h (struct Lisp_Symbol): Update comments.
7300
c20992f4
JB
73012011-10-28 Juanma Barranquero <lekktu@gmail.com>
7302
7303 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7304
db4f02f2
EZ
73052011-10-28 Eli Zaretskii <eliz@gnu.org>
7306
7307 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7308 <oslsachem@gmail.com> for helping to debug this.
7309
7310 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7311 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7312 (g_b_init_get_glyph_outline_w): New static variables.
7313 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7314 (GetGlyphOutlineW_Proc): New typedefs.
7315 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7316 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7317 New functions.
7318 (w32font_open_internal, compute_metrics):
7319 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7320 instead of calling the "wide" APIs directly.
7321
7322 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7323
7324 * w32.h (syms_of_w32font): Add prototype.
7325
87e68db4
JB
73262011-10-27 Juanma Barranquero <lekktu@gmail.com>
7327
7328 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7329 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7330 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7331 (Fmove_to_window_line): Doc fix.
7332
435c1d67
CY
73332011-10-27 Chong Yidong <cyd@gnu.org>
7334
7335 * process.c (make_process): Set gnutls_state to NULL.
7336
7337 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7338 non-NULL, regardless of GNUTLS_INITSTAGE.
7339 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7340 an error. Set process slots as soon as we allocate them.
7341
7342 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7343
9c6c6f49
CY
73442011-10-27 Chong Yidong <cyd@gnu.org>
7345
9aba6043
SM
7346 * gnutls.c (emacs_gnutls_deinit): New function.
7347 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7348 (Fgnutls_deinit, Fgnutls_boot): Use it.
7349
7350 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7351 (deactivate_process): Call emacs_gnutls_deinit.
7352
657d08d3
JB
73532011-10-27 Juanma Barranquero <lekktu@gmail.com>
7354
7355 * image.c (x_create_x_image_and_pixmap):
7356 * w32.c (sys_rename, w32_delayed_load):
7357 * w32font.c (fill_in_logfont):
7358 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7359
5430d399
JB
73602011-10-26 Juanma Barranquero <lekktu@gmail.com>
7361
7362 * w32fns.c (w32_default_color_map): New function,
7363 extracted from Fw32_default_color_map.
a7ef684b 7364 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7365
fe0055fa
PE
73662011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7367
7368 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7369
e6346438
SM
73702011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7371
7372 * keyboard.c (test_undefined): New function (bug#9751).
7373 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7374
e112cc37
ET
73752011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7376
7377 * sysdep.c (init_sys_modes): Fix the check for the controlling
7378 terminal (Bug#6649).
7379
7b5d6677
EZ
73802011-10-20 Eli Zaretskii <eliz@gnu.org>
7381
7382 * dispextern.h (struct bidi_it): New member next_en_type.
7383
7384 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7385 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7386 current character, check also for next_en_type being WEAK_EN.
7387 (bidi_resolve_weak): Don't enter the expensive loop if the current
7388 position is before next_en_pos. Record the bidi type of the first
7389 non-ET, non-BN character we find, in addition to its position.
7390 (bidi_level_of_next_char): Invalidate next_en_type when
7391 next_en_pos is over-stepped.
7392
7da0b018
PE
73932011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7394
7395 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7396 * editfns.c: Rewrite current-time-zone so that it invokes
7397 the equivalent of (format-time-string "%Z") to get the time zone name.
7398 This fixes a bug when the time zone name contains characters that
7399 need converting from the system time locale to Emacs internal format.
7400 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7401 that patch fixed format-time-string to do the conversion, but
7402 I forgot to fix current-time-zone.
7403 (format_time_string): New function, containing most of
7404 what Fformat_time_string used to contain.
7405 (Fformat_time_string): Rewrite in terms of format_time_string.
7406 This doesn't change this function's behavior.
7407 (current-time-zone): Rewrite to use format_time_string.
7408 This fixes the bug reported by Michael Schierl in
7409 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7410 Jason Rumney's 2007-06-07 change worked around this bug, but
7411 didn't fix it.
7412 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7413
8547b010
EZ
74142011-10-19 Eli Zaretskii <eliz@gnu.org>
7415
7416 * xdisp.c (start_display): If the character at POS is displayed
7417 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7418 (try_window_reusing_current_matrix): If a line ends in a display
7419 vector or the next line starts in a display vector, continue
7420 redrawing the window even though the character position of
7421 start_row was reached.
8547b010
EZ
7422 (Bug#9771, part 2)
7423
4e948d15
CY
74242011-10-18 Chong Yidong <cyd@gnu.org>
7425
7426 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7427 with nobreak-char-display too.
7428
4787455f
EZ
74292011-10-18 Eli Zaretskii <eliz@gnu.org>
7430
7431 Fix part 3 of bug#9771.
7432 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7433 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7434 non-neutral characters if the current character is a paragraph
7435 separator (a.k.a. Newline). This avoids running the same
7436 expensive loop twice, once when we consume the preceding newline
7437 and the other time when the line actually needs to be displayed.
7438 Avoid the loop when we see neutrals on the base embedding level
7439 following a character whose directionality is the same as the
7440 paragraph's. This avoids running the expensive loop when a line
7441 ends in a long sequence of neutrals, like control characters.
7442 Add assertion against STRONG_AL type. Slightly rearrange code
7443 that determines the type of a neutral given the first non-neutral
7444 that follows it.
7445 (bidi_level_of_next_char): Set next_en_pos to zero when
7446 invalidating its info.
7447
2c91f553
EZ
74482011-10-17 Eli Zaretskii <eliz@gnu.org>
7449
7450 * xdisp.c (push_display_prop): Determine whether to record string
7451 or buffer position by IT->string, not by IT->method. Allow
7452 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7453 (move_it_vertically_backward): Don't look for character position
7454 immediately after the newline when in a continuation line.
7455 (Bug#9771, part 1)
2c91f553 7456
c7b08b0d
MR
74572011-10-15 Martin Rudalics <rudalics@gmx.at>
7458
7459 * window.c (coordinates_in_window): Rewrite and delabelize
7460 vertical border check. (Bug#5357) (Bug#9618)
7461
6b02f655
SM
74622011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7463
7464 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7465 errors in XSetWindowBorder (bug#9310).
7466
81d40c92
DA
74672011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7468
7469 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7470 avoid crash when xmalloc overrun checking is enabled.
7471
d4172c3b
EZ
74722011-10-13 Eli Zaretskii <eliz@gnu.org>
7473
7474 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7475 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7476 cursor motion with <left> and <right> arrow keys.
7477
7478 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7479 some callers set that themselves.
7480
b00eea75
EZ
74812011-10-12 Eli Zaretskii <eliz@gnu.org>
7482
7483 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7484 display string and the previous row comes from the same string and
7485 is empty. (Bug#9739) (Bug#9738)
7486
8fe012c4
SM
74872011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7488
7489 * doc.c (get_doc_string): Encode file name (bug#9735).
7490
0074aef2
EZ
74912011-10-12 Eli Zaretskii <eliz@gnu.org>
7492
79beb178
EZ
7493 * bidi.c (bidi_level_of_next_char):
7494 * xdisp.c (get_visually_first_element): Remove old incorrect
7495 comments regarding the Unicode Line Separator character.
7496
0074aef2
EZ
7497 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7498
6e4b3fbe
DA
74992011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7500
7501 * alloc.c (Fgc_status): Do not access beyond zombies array
7502 boundary if nzombies > MAX_ZOMBIES.
7503 * alloc.c (dump_zombies): Add missing format specifier.
7504
0324f3af
PE
75052011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7506
b5525cac
PE
7507 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7508 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7509
0324f3af
PE
7510 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7511 Some packages use them to denote characters with modifiers.
7512
e9b5f888
AS
75132011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7514
7515 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7516 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7517 matching a pp-number. Rename parameter var to var1.
7518
127827c0
SM
75192011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7520
7521 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7522
c8fd3bd0
GM
75232011-10-08 Glenn Morris <rgm@gnu.org>
7524
7525 * callint.c (Fcall_interactively): Give a more explicit error for the
7526 'c' case with a non-character input. (Bug#8479)
7527
352ec8ff
EZ
75282011-10-08 Eli Zaretskii <eliz@gnu.org>
7529
03669ccb
EZ
7530 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7531 lines.
7061c986
EZ
7532 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7533 lines that are hscrolled on the left.
03669ccb 7534
352ec8ff
EZ
7535 * dispnew.c (buffer_posn_from_coords): Account for a possible
7536 presence of header-line. (Bug#4426)
7537
a66cfb1c
SM
75382011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7539
6b02f655
SM
7540 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7541 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7542
7c5ee88e
PE
75432011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7544
7545 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7546 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7547 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7548 this makes Emacs dump core during garbage collection on rare
7549 occasions. sizeof is obviously inferior to offsetof here, so
7550 stick with offsetof.
7551 (GC_POINTER_ALIGNMENT): New macro.
7552 (mark_memory): Omit 3rd (offset) arg; caller changed.
7553 Don't assume EMACS_INT alignment is the same as pointer alignment.
7554
df1bbe5b
SM
75552011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7556
7557 * keyboard.c (read_key_sequence_remapped): New var.
7558 (read_key_sequence): Compute remapping in the right buffer.
7559 (command_loop_1): Use read_key_sequence's remapping directly.
7560
51553db6
SM
75612011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7562
32c1fffd
SM
7563 * dired.c (file_name_completion): Don't expand file name.
7564 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7565 before checking file name handler.
7566
51553db6
SM
7567 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7568 they've been requested explicitly (bug#9591).
7569
b6bd1599 75702011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7571
7572 * keymap.c (Fsingle_key_description): Use make_specified_string
7573 instead of build_string to build string from push_key_description.
7574 (Bug#5193)
7575
f701dc2a
PE
75762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7577
4222c55d
PE
7578 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7579 This fixes a Y2038 bug on 64-bit hosts.
7580 * buffer.c (reset_buffer):
7581 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7582 (Fclear_buffer_auto_save_failure):
7583 Use 0, not -1, to represent an unset failure time, since time_t
7584 might not be signed.
7585
f701dc2a
PE
7586 Remove dependency on glibc malloc internals.
7587 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7588 Move back here from lisp.h, but with their new implementations.
7589 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7590 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7591 * charset.c (charset_table_init): New static var.
7592 (syms_of_charset): Use it instead of xmalloc. This removes a
7593 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7594 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7595 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7596 Move back to alloc.c.
7597 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7598 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7599
9ceebf39
JD
76002011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7601
7602 * nsterm.m (windowDidResize): Call x_set_window_size only when
7603 ns_in_resize is true. Otherwise set pixelwidth/height and
7604 call change_frame_size (Bug#9628).
7605
cb993c58
PE
76062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7607
3930c88b
PE
7608 Port --enable-checking=all to Fedora 14 x86-64.
7609 * charset.c (syms_of_charset): Also account for glibc malloc's
7610 internal overhead when calculating the initial malloc maximum.
7611
cb993c58
PE
7612 Port --enable-checking=all to Fedora 14 x86.
7613 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7614 Move to lisp.h.
7615 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7616 (overrun_check_realloc, overrun_check_free):
7617 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7618 That way, xmalloc returns a properly-aligned pointer even if
7619 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7620 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7621 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7622 into account when calculating the initial malloc maximum.
7623 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7624 Move here from alloc.c, so that charset.c can use it too.
7625 Properly align; the old code wasn't right for common 32-bit hosts
7626 when configured with --enable-checking=all.
7627 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7628 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7629
31bed486
EZ
76302011-09-29 Eli Zaretskii <eliz@gnu.org>
7631
04c70788 7632 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7633 use EDOM.
7634
fbcaa2f3
EZ
76352011-09-28 Eli Zaretskii <eliz@gnu.org>
7636
7637 * xdisp.c (compute_display_string_end): If there's no display
7638 string at CHARPOS, return -1.
7639
7640 * bidi.c (bidi_fetch_char): When compute_display_string_end
7641 returns a negative value, treat the character as a normal
7642 character not covered by a display string. (Bug#9624)
7643
a239d4e9
JB
76442011-09-28 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * lread.c (Fread_from_string): Fix typo in docstring.
7647
88652fd5
EZ
76482011-09-27 Eli Zaretskii <eliz@gnu.org>
7649
7650 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7651 newline, reseat the iterator instead of bidi-iterating there one
7652 character at a time. (Bug#9610)
32c1fffd
SM
7653 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7654 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7655
ed497dd4
AS
76562011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7657
7658 * lread.c (readevalloop): Use correct code for NBSP.
7659 (read1): Likewise. (Bug#9608)
7660
b2bf61aa
MA
76612011-09-25 Michael Albinus <michael.albinus@gmx.de>
7662
7663 * dbusbind.c (Fdbus_register_signal): When service is not
7664 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7665
32bbb17c
GM
76662011-09-25 Glenn Morris <rgm@gnu.org>
7667
7668 * buffer.c (truncate-lines): Doc fix.
7669
94e0933e
CY
76702011-09-24 Chong Yidong <cyd@stupidchicken.com>
7671
7672 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7673 (Fset_window_next_buffers): Doc fix.
7674
cddde921
GM
76752011-09-24 Glenn Morris <rgm@gnu.org>
7676
7677 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7678
1260aef1
PE
76792011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7680
25b4bfa0
PE
7681 Fix minor problems found by static checking.
7682 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7683 * indent.c (Fvertical_motion): Fix == vs = typo.
7684
e3cbd34b
EZ
76852011-09-24 Eli Zaretskii <eliz@gnu.org>
7686
a66cfb1c
SM
7687 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7688 Default value is now t. Doc fix.
6bf7006f 7689
e3cbd34b 7690 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7691 logic when moving up, not only when moving down. Fix the
e3cbd34b 7692 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7693 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7694
7695 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7696 CHARPOS is covered by a display string which includes newlines.
7697 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7698 is covered by a display string with embedded newlines.
7699
a3de0cbd
MA
77002011-09-24 Michael Albinus <michael.albinus@gmx.de>
7701
7702 * dbusbind.c (Fdbus_register_signal): Add match rule to
7703 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7704 (Fdbus_register_method, Vdbus_registered_objects_table):
7705 Fix docstring.
a3de0cbd 7706
b260039d
JM
77072011-09-24 Jim Meyering <meyering@redhat.com>
7708
32c1fffd 7709 do not ignore write error for any output size
b260039d
JM
7710 The previous change was incomplete.
7711 While it makes emacs --batch detect the vast majority of stdout
7712 write failures, errors were still ignored whenever the output size is
7713 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7714 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7715 && echo FAIL: ignored write error
7716 FAIL: ignored write error
7717 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7718 && echo FAIL: ignored write error
7719 FAIL: ignored write error
7720 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7721
8eca8a7c
AS
77222011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7723
7724 * emacs.c (Fkill_emacs): In noninteractive mode exit
7725 non-successfully if a write error occurred on stdout. (Bug#9574)
7726
3341db62
EZ
77272011-09-21 Eli Zaretskii <eliz@gnu.org>
7728
7729 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7730 the xassert test.
7731
7732 * dispextern.h (struct it): Update the comment documenting what
7733 can it->OBJECT be.
7734
8c203dbf
EZ
77352011-09-20 Eli Zaretskii <eliz@gnu.org>
7736
7737 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7738 a display string, extend search for cursor position to end of row.
7739 (find_row_edges): If the row ends in a newline from a display
7740 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7741 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7742 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7743 non-empty line. Fixes confusing cursor motion with arrow keys at
7744 the beginning of a line that starts with whitespace.
8c203dbf 7745
a4824228
LMI
77462011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7747
7748 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7749 (bug#9493).
7750
33ed493b
CY
77512011-09-18 Chong Yidong <cyd@stupidchicken.com>
7752
7753 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7754 boolean (Bug#9154).
7755
56cd55c8
EZ
77562011-09-18 Eli Zaretskii <eliz@gnu.org>
7757
7758 * xdisp.c (display_line): Record maximum and minimum buffer
7759 positions even if no glyphs were produced (e.g., by a zero-width
7760 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7761 buffer positions that will be removed from the glyph row because
7762 they don't fit.
c02dcedf
EZ
7763 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7764 column is beyond frame width: don't subtract 1 "pixel" when
7765 computing width of the stretch.
3e62b7e0
EZ
7766 (reseat_at_next_visible_line_start): Undo the change made on
7767 2011-09-17 that saved paragraph information and restored it after
7768 the call to `reseat'. (Bug#9545)
56cd55c8 7769
5ed99d36 77702011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7771
7772 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7773 and turn window cursor on if cleared (Bug#9415).
7774
5ed99d36 77752011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7776
7777 * search.c (boyer_moore): Take unibyte characters from pattern
7778 literally. (Bug#9458)
7779
9bade7b2
EZ
77802011-09-18 Eli Zaretskii <eliz@gnu.org>
7781
7782 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7783
e5e9d610
PE
77842011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7785
87e4427a
PE
7786 Fix minor problem found by static checking.
7787 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7788 initialized, to pacify gcc -Wuninitialized.
7789
e5e9d610
PE
7790 * fileio.c: Report proper errno when syscall falls.
7791 (Finsert_file_contents): Save and restore errno,
7792 so that report_file_error outputs the correct diagnostic.
7793 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7794
a1674f0b
EZ
77952011-09-18 Eli Zaretskii <eliz@gnu.org>
7796
7797 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7798
fbfb6dd4
EZ
77992011-09-17 Eli Zaretskii <eliz@gnu.org>
7800
7801 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7802 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7803
bb187662
EZ
78042011-09-17 Eli Zaretskii <eliz@gnu.org>
7805
1137e8b8 7806 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7807 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7808
7809 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7810 (bidi_find_paragraph_start): Search back for paragraph beginning
7811 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7812 (bidi_move_to_visually_next): Only trigger paragraph-related
7813 computations when the last character is a newline or at EOB, not
7814 just any NEUTRAL_B. (Bug#9470)
7815
bb187662
EZ
7816 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7817 truncated lines if point is covered by a display string. (Bug#9524)
7818
2e621251
PE
78192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7820
7821 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7822 (cons_to_x_long): New function.
7823 (lisp_data_to_selection_data): Use it. Correct the test for
7824 short-versus-long data; it was negated. Break out of vector
7825 loop, for efficiency, when a long datum is discovered.
7826
91a15bc6
SM
78272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7828
7829 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7830
b41c3a35
EZ
78312011-09-16 Eli Zaretskii <eliz@gnu.org>
7832
7833 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7834 GCC PR/17406) by declaring this function with external scope.
7835
7812ba2d
PE
78362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7837
7838 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7839 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7840
cf7edc2a
AS
78412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7842
7843 * editfns.c (Fformat): Correctly handle text properties on "%%".
7844
bd01620e
EZ
78452011-09-15 Eli Zaretskii <eliz@gnu.org>
7846
7847 * xterm.c (x_draw_composite_glyph_string_foreground):
7848 * w32term.c (x_draw_composite_glyph_string_foreground):
7849 * term.c (encode_terminal_code):
7850 * composite.c (composition_update_it, get_composition_id):
7851 * xdisp.c (get_next_display_element)
7852 (fill_composite_glyph_string): Add comments about special meaning
7853 of TAB characters in a composition.
7854
a02719a3
PE
78552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7856
7857 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7858 This occurs when processing a multibyte format.
7859 Problem reported by Wolfgang Jenker.
a02719a3 7860
72589a3c
JB
78612011-09-15 Johan Bockgård <bojohan@gnu.org>
7862
7863 * xdisp.c (try_cursor_movement): Only check for exact match if
7864 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7865
1c14176c
PE
78662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7867
7868 Remove unused external symbols.
7869 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7870 * xdisp.c (calc_pixel_width_or_height): Now static.
7871 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7872 * indent.c (check_display_width):
7873 * w32term.c: Fix comment to match code.
7874 * xterm.c, xterm.h (x_catching_errors): Remove.
7875
d2eea5b5
PE
78762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7877
7878 * xselect.c: Use signed conversions more consistently (Bug#9498).
7879 (selection_data_to_lisp_data): Assume incoming selection data are
7880 signed integers, not unsigned. This is to be consistent with
7881 outgoing selection data, which was modified to use signed integers
7882 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7883 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7884 expects long, not unsigned long.
7885
46888499
EZ
78862011-09-14 Eli Zaretskii <eliz@gnu.org>
7887
7888 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7889 computation of loop end. Reported by Johan Bockgård
7890 <bojohan@gnu.org>.
7891
ef8ef9fb
CY
78922011-09-13 Chong Yidong <cyd@stupidchicken.com>
7893
7894 * frame.c (Fother_visible_frames_p): Function deleted.
7895
fa819fed
EZ
78962011-09-12 Eli Zaretskii <eliz@gnu.org>
7897
7898 * indent.c (compute_motion): Process display vector front to back
7899 rather than the other way around. (Bug#2496)
7900
2ba8e008
SM
79012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7902
7903 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7904
20f53c69
CY
79052011-09-11 Chong Yidong <cyd@stupidchicken.com>
7906
7907 * minibuf.c (Fread_from_minibuffer): Doc fix.
7908
d562d7a4
EZ
79092011-09-11 Eli Zaretskii <eliz@gnu.org>
7910
7911 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7912 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7913
1c4d7f3d
LMI
79142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7915
7916 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7917 value for non-existent files.
7918
b885bf36
EZ
79192011-09-11 Eli Zaretskii <eliz@gnu.org>
7920
7921 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7922 set its "size" to -1. This will set the modtime_size field of
7923 the corresponding buffer to -1, which is what
7924 verify-visited-file-modtime expects for files that do not exist.
7925 (Bug#9139)
7926
6612f0bf
PE
79272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7928
7929 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7930 here ...
7931 * lisp.h: ... from here. push_key_description is no longer
7932 defined in keyboard.c, so its declaration should not be in
7933 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7934 logically belongs with push_key_description.
7935
dfb3f755
PE
79362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7937
7938 * buffer.h: Include <sys/types.h> instead of <time.h>.
7939 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7940 Problem reported by Herbert J. Skuhra.
7941
3134906c
LMI
79422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7943
7944 * xml.c (parse_region): Make the parsing work for
7945 non-comment-starting XML files again (bug#9144).
7946
8d903f4e
AS
79472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7948
7949 * image.c (gif_load): Fix calculation of bottom and right corner.
7950 (Bug#9468)
7951
80ad64f4
EZ
79522011-09-10 Eli Zaretskii <eliz@gnu.org>
7953
7954 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7955 redisplay in small windows.
7956
208a048d
EZ
79572011-09-09 Eli Zaretskii <eliz@gnu.org>
7958
7959 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7960
9b1c252e
MR
79612011-09-08 Martin Rudalics <rudalics@gmx.at>
7962
7963 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7964 Operate on live windows only.
7965
2949f33b
JB
79662011-09-08 Juanma Barranquero <lekktu@gmail.com>
7967
7968 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7969
e08dcafd
EZ
79702011-09-07 Eli Zaretskii <eliz@gnu.org>
7971
7972 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7973 only under bidi iteration.
7974
115b96bd
JD
79752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7976
7977 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7978
c8199d0f
PE
79792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7980
7981 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7982 Without this fix, the command to link temacs failed due to an
7983 undefined symbol __builtin_isnan. This is because
7984 /usr/include/iso/math_c99.h #defines isnan(x) to
7985 __builtin_isnan(x), but the bundled gcc, which identifies itself
7986 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7987 a __builtin_isnan.
7988 * floatfns.c (isnan): #undef, and then #define to a clone of
7989 what's in data.c.
7990 (Fisnan): Always define, since it's always available now.
7991 (syms_of_floatfns): Always define isnan at the Lisp level.
7992
e39b275c 79932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7994
7995 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7996
b2db44d9 79972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7998
f4af5137 7999 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8000 The previous code assumed that file offsets (off_t values) fit in
8001 EMACS_INT variables, which is not true on typical 32-bit hosts.
8002 The code messed up by falsely reporting buffer overflow in cases
8003 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8004 when "big" contains more than 2**29 bytes, even though this
8005 inserts just one byte and does not overflow the buffer.
8006 (Finsert_file_contents): Store file offsets as off_t
8007 values, not as EMACS_INT values. Check for overflow when
8008 converting between EMACS_INT and off_t. When checking for
8009 buffer overflow or for overlap, take the offsets into account.
8010 Don't use EMACS_INT for small values where int suffices.
8011 When checking for overlap, fix a typo: ZV was used where
8012 ZV_BYTE was intended.
8013 (Fwrite_region): Don't assume off_t fits into 'long'.
8014 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8015
ecfc0a49
MA
80162011-09-05 Michael Albinus <michael.albinus@gmx.de>
8017
8018 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8019
6511acf2 80202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8021
0999621a 8022 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8023
8024 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8025 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8026 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8027 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8028 (modify_event_symbol): Do not assume that the length of
8029 name_alist_or_stem is safe to alloca and fits in int.
8030 (Fexecute_extended_command): Likewise for function name and binding.
8031 (Frecursion_depth): Wrap around reliably on integer overflow.
8032 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8033 since some callers pass EMACS_INT values.
8034 (Fsingle_key_description): Don't crash if symbol name contains more
8035 than MAX_ALLOCA bytes.
8036 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8037 (get_minibuffer): Arg is now EMACS_INT, not int.
8038 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8039 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8040 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8041
2be7d702
PE
8042 * dbusbind.c (signature_cat): New function.
8043 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8044 Do not overrun buffer; instead, report string overflow.
8045
9d1df220
PE
8046 * dispnew.c (add_window_display_history): Don't overrun buffer.
8047 Truncate instead; this is OK since it's just a log.
8048
33ef5c64
PE
8049 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8050 even if the time zone offset is outlandishly large.
8051 Don't mishandle offset == INT_MIN.
8052
66c6fdd5
PE
8053 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8054 when creating daemon; the previous buffer-overflow check was incorrect.
8055
d749b01b
PE
8056 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8057 which has the guts of the old verror function.
8058
b5cd1905
PE
8059 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8060 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8061
6e1a67fb
PE
8062 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8063 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8064 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8065 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8066 length of string rather than counting it via multiple sprintfs;
8067 that's simpler and more reliable.
c21721cc
PE
8068 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8069 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8070 sprintf, in case result does not fit in int.
8071
c57b67fc
PE
8072 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8073 (fontset_from_font): Print it.
8074
8a401434
PE
8075 * frame.c (tty_frame_count): Now printmax_t, not int.
8076 (make_terminal_frame, set_term_frame_name): Print it.
8077 (x_report_frame_params): In X, window IDs are unsigned long,
8078 not signed long, so print them as unsigned.
8079 (validate_x_resource_name): Check for implausibly long names,
8080 and don't assume name length fits in 'int'.
8081 (x_get_resource_string): Don't blindly alloca invocation name;
8082 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8083 not fit in int.
8084
6e1a67fb
PE
8085 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8086 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8087 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8088
0df02bf3
PE
8089 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8090 Use esprintf, not sprintf, in case result does not fit in int.
8091
48e30793
PE
8092 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8093 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8094 it as a large positive number.
8095 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8096 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8097
a66ff6d8
PE
8098 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8099 in case result does not fit in int.
8100
aca216ff
PE
8101 * print.c (float_to_string): Detect width overflow more reliably.
8102 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8103 buffer overrun. Don't assume list length fits in 'int'. Treat
8104 print length of 0 as 0, not as infinity; to be consistent with other
8105 uses of print length in this function. Don't overflow print length
8106 index. Don't assume hash table size fits in 'long', or that
8107 vectorlike size fits in 'unsigned long'.
8108
31c286f7
PE
8109 * process.c (make_process): Use printmax_t, not int, to format
8110 process-name gensyms.
8111
55e5faa1
PE
8112 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8113
80f2e268
PE
8114 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8115 to avoid potential buffer overrun.
8116
670741ab
PE
8117 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8118 if X resource line is longer than 512 bytes.
8119
b7163a50
PE
8120 * xfns.c (x_window): Make sprintf buffer a bit bigger
8121 to avoid potential buffer overrun.
8122
ae58ff1f
PE
8123 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8124
c43c8a6a
PE
8125 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8126
3f8236f4
PE
81272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8128
53e9fe90 8129 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8130 Without these, Emacs silently mishandles large integers sometimes.
8131 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8132 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8133
6511acf2
PE
8134 * xdisp.c (try_window_id): Check Emacs fixnum range before
8135 converting to 'int'.
806add1d 8136
6511acf2 8137 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8138 Check that an Emacs fixnum is in range before assigning it to 'int'.
8139 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8140 values converted from Emacs fixnums.
8141 (Frecenter): Don't wrap around a line count if it is out of 'int'
8142 range; instead, treat it as an extreme value.
8143 (Fset_window_configuration, compare_window_configurations):
8144 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8145
6511acf2
PE
8146 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8147 that can exceed INT_MAX. Check that EMACS_INT value is in range
8148 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8149 (match_limit): Don't assume that a fixnum can fit in 'int'.
8150
6511acf2 8151 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8152 exceed INT_MAX.
8153
6511acf2 8154 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8155 (Fvertical_motion): Don't wrap around LINES values that don't fit
8156 in 'int'. Instead, treat them as extreme values. This is good
8157 enough for windows, which can't have more than INT_MAX lines anyway.
8158
fcb901a7
LMI
81592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8160
0f2f6b6d
LMI
8161 * Require libxml/parser.h to avoid compilation warning.
8162
fcb901a7
LMI
8163 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8164
8165 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8166 since this reportedly can destroy thread storage.
8167
6e20a0d4
CY
81682011-08-30 Chong Yidong <cyd@stupidchicken.com>
8169
8170 * syntax.c (find_defun_start): Update all cache variables if
8171 exiting early (Bug#9401).
8172
148ae00e
EZ
81732011-08-30 Eli Zaretskii <eliz@gnu.org>
8174
f6cfbd8f
EZ
8175 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8176
148ae00e
EZ
8177 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8178 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8179 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8180
8181 * term.c (tty_append_glyph): New function.
8182 (produce_stretch_glyph): Static function and its prototype deleted.
8183
a66cfb1c
SM
8184 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8185 Add prototypes.
148ae00e 8186
c4a07a4c
PE
81872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8188
8189 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8190 when checking :margin (Bug#9390).
8191 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8192 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8193 so that the name doesn't mislead. All uses changed.
8194
6bc8cd65
JB
81952011-08-28 Johan Bockgård <bojohan@gnu.org>
8196
8197 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8198 set_tty_hooks.
8199
dca4927e
EZ
82002011-08-27 Eli Zaretskii <eliz@gnu.org>
8201
8202 * xdisp.c (move_it_to): Don't bail out early when reaching
8203 position beyond to_charpos, if we are scanning backwards.
8204 (move_it_vertically_backward): When DY == 0, make sure we get to
8205 the first character in the line after the newline.
8206
f2cad773
PE
82072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8208
8209 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8210 (ccl_driver): Do not generate an out-of-range pointer.
8211 (Fccl_execute_on_string): Remove unnecessary check for
8212 integer overflow, noted by Stefan Monnier in
8213 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8214 Remove a FIXME that didn't need fixing.
8215 Simplify the newly-introduced buffer reallocation code.
8216
0cae2cdb
JB
82172011-08-27 Juanma Barranquero <lekktu@gmail.com>
8218
8219 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8220
5fc295a4 82212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8222
70c60eb2 8223 Integer and memory overflow issues (Bug#9196).
726e0ab1 8224
d31850da
PE
8225 * doc.c (get_doc_string): Rework so that
8226 get_doc_string_buffer_size is the actual buffer size, rather than
8227 being 1 less than the actual buffer size; this makes xpalloc more
8228 convenient.
8229
a69fbedb
PE
8230 * image.c (x_allocate_bitmap_record, cache_image):
8231 * xselect.c (Fx_register_dnd_atom):
8232 Simplify previous changes by using xpalloc.
8233
fe5c5d37
PE
8234 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8235 since either will do and ptrdiff_t is convenient with xpalloc.
8236
0065d054
PE
8237 * charset.c (charset_table_size)
8238 (struct charset_sort_data.priority): Now ptrdiff_t.
8239 (charset_compare): Don't overflow if priorities differ greatly.
8240 (Fsort_charsets): Don't assume list length fits in int.
8241 Check for size-calculation overflow when allocating sort data.
8242 (syms_of_charset): Allocate an initial charset table that is
8243 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8244
8245 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8246
8247 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8248 The actual value is always <= INT_MAX, and leaving it unsigned made
8249 overflow checking harder.
8250
8251 * dispextern.h (struct glyph_matrix.rows_allocated)
8252 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8253 with xpalloc. The values are still always <= INT_MAX.
8254
8255 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8256
8257 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8258 (SAFE_NALLOCA): New macro.
8259
8260 * region-cache.c (struct boundary.pos, find_cache_boundary)
8261 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8262 (set_cache_region, invalidate_region_cache)
8263 (revalidate_region_cache, know_region_cache, region_cache_forward)
8264 (region_cache_backward, pp_cache):
8265 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8266 so that ptrdiff_t * can be passed to xpalloc.
8267 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8268 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8269 (pp_cache): Don't assume cache_len fits in int.
8270 * region-cache.h: Adjust extern decls to match.
8271
8272 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8273 EMACS_INT, since either will do, for xpalloc.
8274
8275 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8276 (xnmalloc, xnrealloc, xpalloc): New functions.
8277
726e0ab1
PE
8278 * bidi.c (bidi_shelve_header_size): New constant.
8279 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8280 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8281
51f30bc5 8282 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8283 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8284 (overlay_strings):
8285 Don't update size of array until after memory allocation succeeds,
8286 because xmalloc/xrealloc may not return.
0065d054
PE
8287 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8288 now that we have proper integer overflow checking.
8289 (record_overlay_string, overlay_strings): Catch overflows when
8290 calculating size of overlay_str_buf.
726e0ab1 8291
0065d054
PE
8292 * callproc.c (Fcall_process): Check for size overflow when
8293 calculating size of args2.
8294 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8295 Normally we prefer signed values, but sticking with ptrdiff_t would
8296 require adding more-complicated checks.
726e0ab1
PE
8297
8298 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8299 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8300 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8301 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8302
8303 * character.c (Fstring): Check for size-calculation overflow.
8304
8305 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8306 unnecessary integer overflow. Check for size overflow.
8307 (encode_coding_object): Don't update size until xmalloc succeeds.
8308
8309 * composite.c (get_composition_id): Check for overflow in glyph
8310 length calculations.
8311
8312 Integer and memory overflow fixes for display code.
8313 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8314 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8315 (scrolling_window): Check for overflow in size calculations.
8316 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8317 Don't assume glyph table len fits in int.
8318 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8319 (row_table_size): Now ptrdiff_t, not int.
8320 (scrolling_window): Avoid overflow in size calculations.
8321 Don't update size until allocation succeeds.
8322 * fns.c (concat): Check for overflow in size calculations.
8323 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8324 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8325 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8326
8327 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8328 (get_doc_string): Check for size calculation overflow.
8329 Don't update size until allocation succeeds.
8330 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8331 EMACS_INT, where ptrdiff_t will do.
8332 (Fsubstitute_command_keys): Check for string overflow.
8333
8334 * editfns.c (set_time_zone_rule): Don't assume environment length
8335 fits in int.
8336 (message_length): Now ptrdiff_t, not int.
8337 (Fmessage_box): Don't update size until allocation succeeds.
8338 Don't assume message length fits in int.
8339 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8340
0065d054
PE
8341 * emacs.c (main): Do not reallocate argv, since there is a null at
8342 the end that can be overwritten, and this way there's no need to
8343 worry about size-calculation overflow.
8344 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8345
8346 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8347 alloc succeeds.
8348 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8349
8350 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8351 (x_set_scroll_bar_width, x_figure_window_size):
8352 Check for integer overflow.
8353 (x_set_alpha): Do not assume XINT fits in int.
8354
8355 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8356 This is for the members text_lines, text_cols, total_lines, total_cols,
8357 where the system imposes an 'int' limit.
8358
8359 * fringe.c (Fdefine_fringe_bitmap):
8360 Don't update size until alloc works.
8361
8362 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8363 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8364
8365 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8366 Check for size-calculation overflow.
8367 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8368 do, as we prefer signed integers.
8369 (id_to_widget.max_size, id_to_widget.used)
8370 (xg_store_widget_in_map, xg_remove_widget_from_map)
8371 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8372 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8373 Use and return ptrdiff_t, not int.
8374 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8375 * gtkutil.h: Change prototypes to match the above.
8376
8377 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8378 are duplicate now that they've been promoted to lisp.h.
8379 (x_allocate_bitmap_record, x_alloc_image_color)
8380 (make_image_cache, cache_image, xpm_load):
8381 Don't update size until alloc is done.
8382 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8383 (x_detect_edges):
3256efce 8384 Check for size calculation overflow.
726e0ab1
PE
8385 (ct_colors_allocated_max): New constant.
8386 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8387 overflow.
3256efce 8388
726e0ab1
PE
8389 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8390 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8391 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8392 Use ptrdiff_t, not int, to count maps.
8393 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8394 calculations. Don't update size until allocation succeeds.
8395 Redo calculations to avoid overflow.
726e0ab1
PE
8396 * keyboard.h: Change prototypes to match the above.
8397
8398 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8399 to count maps.
8400 (current_minor_maps): Check for size calculation overflow.
8401 * keymap.h: Change prototypes to match the above.
8402
8403 * lread.c (read1, init_obarray): Don't update size until alloc done.
8404
8405 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8406 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8407
726e0ab1
PE
8408 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8409 Now ptrdiff_t, not int.
8410 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8411 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8412
8413 * process.c (Fnetwork_interface_list): Check for overflow
8414 in size calculation.
8415
8416 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8417
8418 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8419 overflow. Don't bother calling xmalloc when xrealloc will do.
8420
8421 * search.c (Freplace_match): Check for size calculation overflow.
8422 (Fset_match_data): Don't assume list lengths fit in 'int'.
8423
8424 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8425 for command line length. Do not attempt to address one before the
8426 beginning of an array, as that's not portable.
8427
8428 * term.c (max_frame_lines): Remove; unused.
8429 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8430 not int.
8431 (encode_terminal_code, calculate_costs): Check for size
8432 calculation overflow.
8433 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8434 table lengths and related sizes. Don't update size until alloc
8435 done. Redo calculations to avoid overflow.
8436 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8437
8438 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8439 subtracting pointers.
8440 (gobble_line): Check for overflow more carefully. Don't update size
8441 until alloc done.
8442
8443 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8444 Don't update size until alloc done.
8445 Redo size calculations to avoid overflow.
8446 Check for size calculation overflow.
0065d054 8447 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8448
8449 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8450 Use ptrdiff_t, not int, for sizes.
8451 (store_mode_line_noprop_char): Don't update size until alloc done.
8452
0065d054
PE
8453 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8454 Use ptrdiff_t, not int, for sizes.
8455 (Finternal_make_lisp_face, cache_face):
8456 Check for size calculation overflow.
8457 (cache_face): Treat size calculation overflows as if they were
8458 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8459
8460 * xfns.c (x_encode_text, x_set_name_internal)
8461 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8462 sizes, since they can exceed INT_MAX in size. Check for size
8463 calculation overflow.
8464
0065d054
PE
8465 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8466 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8467 Don't update size until alloc done.
8468
0065d054 8469 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8470 as sprintf is limited to int lengths.
1d526e2f 8471
252c5ee1
PE
8472 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8473 (X_LONG_MIN): New macros.
864d7ce7
PE
8474 Use them to make the following changes clearer.
8475 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8476 This change doesn't affect the value now, but it may help remind
8477 future maintainers not to raise the value too much later.
8478 (SELECTION_QUANTUM): Remove, replacing with ...
8479 (selection_quantum): ... new function, which avoids overflow.
8480 All uses changed.
8481 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8482 assumption that selection length fits in 'int'.
8483 (x_reply_selection_request, x_handle_selection_request)
8484 (x_get_window_property, receive_incremental_selection)
8485 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8486 (lisp_data_to_selection_data, clean_local_selection_data):
8487 Use ptrdiff_t, not int, to record length of selection.
8488 (x_reply_selection_request, x_get_window_property)
8489 (receive_incremental_selection, x_property_data_to_lisp):
8490 Redo calculations to avoid overflow.
8491 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8492 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8493 something.
8494 (x_get_window_property, receive_incremental_selection)
8495 (lisp_data_to_selection_data, x_property_data_to_lisp):
8496 Check for size-calculation overflow.
8497 (x_get_window_property, receive_incremental_selection)
8498 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8499 Don't store size until memory allocation succeeds.
8500 (x_get_window_property): Plug memory leak on memory exhaustion.
8501 Don't double-block input; malloc is safe here. Don't assume 2**34
8502 - 4 fits in unsigned long. Add an xassert to check
8503 XGetWindowProperty overflow. Be more careful about overflow
8504 calculations, and distinguish size from memory overflow better.
8505 (receive_incremental_selection): When tracing, don't assume
8506 unsigned int is less than INT_MAX.
8507 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8508 harmful) conversions of unsigned short to int.
8509 (lisp_data_to_selection_data): Don't assume that integers
8510 in the range -65535 through -1 fit in an X unsigned short.
8511 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8512 result parameters unless successful. Rely on cons_to_unsigned
8513 to report problems with elements; the old code wasn't right anyway.
8514 (x_check_property_data): Check for int overflow; we cannot use
8515 a wider type due to X limits.
8516 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8517
726e0ab1 8518 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8519
0065d054
PE
8520 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8521 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8522 (x_color_cells): Don't store size until memory allocation succeeds.
8523 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8524 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8525 (x_term_init): Don't assume length fits in int (sprintf is limited
8526 to int size).
bc18e09d 8527
ebfa62c0
PE
8528 Use ptrdiff_t for composition IDs.
8529 * character.c (lisp_string_width):
8530 * composite.c (composition_table_size, n_compositions)
8531 (get_composition_id, composition_gstring_from_id):
8532 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8533 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8534 * window.c (Frecenter):
8535 Use ptrdiff_t, not int, for composition IDs.
8536 * composite.c (get_composition_id): Check for integer overflow.
8537 * composite.h: Adjust prototypes to match the above changes.
8538
d3411f89
PE
8539 Use ptrdiff_t for hash table indexes.
8540 * category.c (hash_get_category_set):
8541 * ccl.c (ccl_driver):
8542 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8543 * coding.c (coding_system_charset_list, detect_coding_system):
8544 * coding.h (struct coding_system.id):
8545 * composite.c (get_composition_id, gstring_lookup_cache):
8546 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8547 * image.c (xpm_get_color_table_h):
8548 * lisp.h (hash_lookup, hash_put):
8549 * minibuf.c (Ftest_completion):
8550 Use ptrdiff_t for hash table indexes, not int (which is too
8551 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8552 32-bit --with-wide-int hosts).
8553
e097a6fa
PE
8554 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8555 Add a FIXME comment about memory leaks.
8556 (syms_of_charset): Don't assume xmalloc returns.
8557
5637687f
PE
8558 Don't assume that stated character widths fit in int.
8559 * character.c (Fchar_width, c_string_width, lisp_string_width):
8560 * character.h (CHAR_WIDTH):
8561 * indent.c (MULTIBYTE_BYTES_WIDTH):
8562 Use sanitize_char_width to avoid undefined and/or bad behavior
8563 with outlandish widths.
a66cfb1c 8564 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8565 now that we have two such functions. All uses changed.
8566 (sanitize_char_width): New inline function.
8567
a2271ba2
PE
8568 Don't assume that tab-width fits in int.
8569 * character.h (sanitize_width): New inline function.
8570 (SANE_TAB_WIDTH): New macro.
8571 (ASCII_CHAR_WIDTH): Use it.
8572 * indent.c (sane_tab_width): Remove. All uses replaced by
8573 SANE_TAB_WIDTH (current_buffer).
8574 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8575
18c52557
PE
8576 * fileio.c: Integer overflow issues with file modes.
8577 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8578
caeeedc1
PE
8579 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8580 Remove unreachable code.
8581 (read_hex, load_charset_map_from_file): Check for integer overflow.
8582
6df6ae42 8583 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8584 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8585 (x_send_scroll_bar_event): Likewise. Check that the size does not
8586 exceed limits imposed by XClientMessageEvent, as well as the usual
8587 ptrdiff_t and size_t limits.
8588
b13995db
PE
8589 * keyboard.c: Overflow, signedness and related fixes.
8590 (make_lispy_movement): Use same integer type in forward decl
8591 that is used in the definition.
8592 (read_key_sequence, keyremap_step):
8593 Change bufsize argument back to int, undoing my 2011-03-30 change.
8594 We prefer signed types, and int is wide enough here.
8595 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8596 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8597 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8598 length, not size_t. Use ptrdiff_t for index, not int.
8599 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8600 possibility of integer overflow.
8601
13464394
PE
8602 Overflow, signedness and related fixes for images.
8603
8604 * dispextern.h (struct it.stack[0].u.image.image_id)
8605 (struct_it.image_id, struct image.id, struct image_cache.size)
8606 (struct image_cache.used, struct image_cache.ref_count):
8607 * gtkutil.c (update_frame_tool_bar):
8608 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8609 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8610 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8611 * nsmenu.m (update_frame_tool_bar):
8612 * xdisp.c (calc_pixel_width_or_height):
8613 * xfns.c (image_cache_refcount):
8614 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8615 on typical 64-bit hosts.
8616
8617 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8618 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8619 Omit unnecessary casts to int.
8620 (parse_image_spec): Check that integers fall into 'int' range
8621 when the callers expect that.
8622 (image_ascent): Redo ascent calculation to avoid int overflow.
8623 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8624 (lookup_image): Remove unnecessary tests.
8625 (xbm_image_p): Locals are now of int, not EMACS_INT,
8626 since parse_image_check makes sure they fit into int.
8627 (png_load, gif_load, svg_load_image):
8628 Prefer int to unsigned where either will do.
8629 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8630 old tiff_error_handler and tiff_warning_handler.
8631 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8632 stack buffer overflows. It uses only the features of vsnprintf
8633 that are common to both POSIX and native Microsoft.
8634 (tiff_error_handler, tiff_warning_handler): Use it.
8635 (tiff_load, gif_load, imagemagick_load_image):
8636 Don't assume :index value fits in 'int'.
8637 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8638 (imagemagick_load_image): Check that crop parameters fit into
8639 the integer types that MagickCropImage accepts. Don't assume
8640 Vimagemagick_render_type has a nonnegative value. Don't assume
8641 size_t fits in 'long'.
8642 (gs_load): Use printmax_t to print the widest integers possible.
8643 Check for integer overflow when computing image height and width.
8644
c11821d4
EZ
86452011-08-26 Eli Zaretskii <eliz@gnu.org>
8646
8647 * xdisp.c (redisplay_window): Don't force window start if point
8648 will be invisible in the resulting window. (Bug#9324)
8649
0c95fcf7
EZ
86502011-08-25 Eli Zaretskii <eliz@gnu.org>
8651
8652 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8653 the display spec is of the form `(space ...)'.
8654 (handle_display_spec): Return the value returned by
8655 handle_single_display_spec, not just 1 or zero.
8656 (handle_single_display_spec): If the display spec is of the form
8657 `(space ...)', and specifies display in the text area, return 2
8658 rather than 1.
fee65a97 8659 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8660 accurately, and prefer exact match for point under bidi.
8661 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8662
8663 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8664 into disp_prop; all users changed.
8665
8666 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8667 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8668 for the text covered by the display property.
8669
e4ed06f1
CY
86702011-08-25 Chong Yidong <cyd@stupidchicken.com>
8671
8672 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8673 Change return value to nil.
8674 (Frecord_buffer): Delete unused function.
8675
f67cdd7f
EZ
86762011-08-24 Eli Zaretskii <eliz@gnu.org>
8677
5980d4c6
EZ
8678 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8679 buffers, return left-to-right.
8610fe8b
EZ
8680 (set_cursor_from_row): Consider candidate row a win if its glyph
8681 represents a newline and point is on that newline. Fixes cursor
8682 positioning on the newline at EOL of R2L text within L2R
8683 paragraph, and vice versa.
8684 (try_cursor_movement): Check continued rows, in addition to
8685 continuation rows. Fixes unwarranted scroll when point enters a
8686 continued line of R2L text within an L2R paragraph, or vice versa.
8687 (cursor_row_p): Consider the case of point being equal to
8688 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8689 from the end of a short line to the beginning of a continued line
8690 of R2L text within L2R paragraph.
8691 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8692 composed characters.
5980d4c6 8693
f67cdd7f
EZ
8694 * bidi.c (bidi_check_type): Use xassert.
8695 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8696 members.
8697
bca633fb
EZ
86982011-08-23 Eli Zaretskii <eliz@gnu.org>
8699
8700 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8701 a character.
8702
4a5885a7
CY
87032011-08-23 Chong Yidong <cyd@stupidchicken.com>
8704
8705 * nsfont.m (ns_otf_to_script): Fix typo.
8706
0902a04e
KH
87072011-08-22 Kenichi Handa <handa@m17n.org>
8708
8709 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8710 extra slot even if the purpose is char-code-property-table.
8711
1a2e6670
EZ
87122011-08-23 Eli Zaretskii <eliz@gnu.org>
8713
8ddde651
EZ
8714 * xdisp.c (redisplay_window): When computing centering_position,
8715 account for the height of the header line. (Bug#8874)
8716
425cc014
EZ
8717 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8718 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8719 candidate is selected by the mouse, and that candidate has a
8720 composed character under the mouse.
8721
1a2e6670
EZ
8722 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8723 coordinates reported by pos-visible-in-window-p for a composed
8724 character in column zero.
8725
8b76d6f8
SM
87262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8727
8728 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8729
dac347dd
EZ
87302011-08-22 Eli Zaretskii <eliz@gnu.org>
8731
8732 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8733 consider it a hit if to_charpos is anywhere in the range of the
8734 composed buffer positions.
8735
e013fb34
CY
87362011-08-22 Chong Yidong <cyd@stupidchicken.com>
8737
8738 * image.c (gif_load): Don't assume that each subimage has the same
8739 dimensions as the base image. Handle disposal method that is
8740 "undefined" by the gif spec (Bug#9335).
8741
bd1ba3e8
CY
87422011-08-20 Chong Yidong <cyd@stupidchicken.com>
8743
8744 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8745 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8746
54a1215b
EZ
87472011-08-19 Eli Zaretskii <eliz@gnu.org>
8748
823564e5
EZ
8749 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8750 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8751 from an Org mode buffer to a Speedbar frame.
8752
54a1215b
EZ
8753 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8754 a composition, take its buffer position from IT->cmp_it.charpos.
8755 Fixes cursor positioning at the beginning of a line that begins
8756 with a composed character.
8757
9778ebcc
EZ
87582011-08-18 Eli Zaretskii <eliz@gnu.org>
8759
0be6ee06
EZ
8760 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8761 character bidirectional type, use STRONG_L instead. Fixes crashes
8762 in a buffer produced by `describe-categories'.
8763
9778ebcc
EZ
8764 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8765 members before the level stack, so they would be saved and
8766 restored when copying iterator state. Fixes incorrect reordering
8767 around TABs covered by display properties.
8768
156bffbe
AS
87692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8770
6b02f655 8771 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8772
72ad093b
CY
87732011-08-17 Chong Yidong <cyd@stupidchicken.com>
8774
8775 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8776 (internal_condition_case_2, internal_condition_case_n):
8777 Remove unnecessary aborts (Bug#9081).
72ad093b 8778
35774242
EZ
87792011-08-17 Eli Zaretskii <eliz@gnu.org>
8780
8781 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8782 has no `load' handler, try opening the file locally. (Bug#9311)
8783
db76dd85
KB
87842011-08-16 Ken Brown <kbrown@cornell.edu>
8785
8786 * gmalloc.c: Expand comment.
8787
b215eee5
EZ
87882011-08-16 Eli Zaretskii <eliz@gnu.org>
8789
8790 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8791 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8792
a4579d33
KB
87932011-08-16 Ken Brown <kbrown@cornell.edu>
8794
8795 Fix memory allocation problems in Cygwin build (Bug#9273).
8796
8797 * unexcw.c ( __malloc_initialized): Declare external variable.
8798 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8799
8b76d6f8
SM
8800 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8801 New variables.
a4579d33
KB
8802 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8803 dumped emacs.
8804 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8805 in the static heap.
8806 [CYGWIN] (special_realloc): New function.
8807 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8808 requests to realloc storage in the static heap.
8809
3ebec551
PE
88102011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8811
8812 * bidi.c (bidi_initialize): Remove unused local.
8813
9fd8be00
EZ
88142011-08-15 Eli Zaretskii <eliz@gnu.org>
8815
6b02f655
SM
8816 * bidimirror.h:
8817 * biditype.h: Remove file.
8818 * makefile.w32-in ($(BLD)/bidi.$(O)):
8819 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8820
8821 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8822
8823 * chartab.c: Improve commentary for the uniprop_table API.
8824
32413314
EZ
8825 * bidi.c (bidi_paragraph_init): Support zero value of
8826 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8827 (bidi_initialize): Use uniprop_table instead of including
8828 biditype.h and bidimirror.h.
32413314 8829
9fd8be00
EZ
8830 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8831 coordinates of the iterator when restoring from ppos_it.
8832 (Bug#9296)
8833
5cf2b69b
KH
88342011-08-14 Kenichi Handa <handa@m17n.org>
8835
8836 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8837 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8838
daf17d00
EZ
88392011-08-14 Eli Zaretskii <eliz@gnu.org>
8840
8841 * xdisp.c (move_it_in_display_line_to): Don't invoke
8842 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8843 ppos_it. Fixes vertical cursor motion when line beginning is
8844 covered by an image. (Bug#9296)
8845
08e3161a
JD
88462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8847
8848 * nsterm.h (ns_run_ascript): Declare.
8849 (NSAPP_DATA2_RUNASSCRIPT): Define.
8850
8851 * nsfns.m (as_script, as_result, as_status): New static variables.
8852 (ns_run_ascript): New function.
5e617bc2 8853 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8854 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8855 the event loop. Get status from as_status (Bug#7276).
8856
8857 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8858 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8859 the event loop (Bug#7276).
8860
a3720aa2
AS
88612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8862
8863 * gnutls.c (QCgnutls_bootprop_priority)
8864 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8865 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8866 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8867 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8868 (QCgnutls_bootprop_verify_hostname_error)
8869 (QCgnutls_bootprop_callbacks_verify): Rename from
8870 Qgnutls_bootprop_..., all uses changed.
8871
8872 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8873 uses changed.
8874
0a0d27fb
PE
88752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8876
19d5c50c
PE
8877 * xfaces.c (Qframe_set_background_mode): Now static.
8878 * dispextern.h (Qframe_set_background_mode): Remove decl.
8879
0a0d27fb
PE
8880 * process.c (Fnetwork_interface_info): Declare local only if needed.
8881
377538cb
JD
88822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8883
8884 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8885 (Fnetwork_interface_list): Allocate in increments of bytes instead
8886 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8887 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8888 sockaddr.
8889 (struct ifflag_def): notrailers is smart on OSX.
8890 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8891 Get hardware address with getifaddrs if available.
8892
08fff70c
EZ
88932011-08-12 Eli Zaretskii <eliz@gnu.org>
8894
8895 * xdisp.c (iterate_out_of_display_property): xassert that
8896 IT->position is set to within IT->object's boundaries. Break from
8897 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8898 when IT->position is set up wrongly due to some bug.
8899 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8900 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8901 entry. Force push_it to save on the stack the current
8902 buffer/string position, to be restored by pop_it. Fix flags in
8903 the iterator structure wrt the object coming from a display
8904 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8905 properties. (Bug#9284)
8906
7be1c708 89072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8908
7be1c708
CY
8909 * fontset.c (fontset_get_font_group): Add proper type checks.
8910 (Bug#9172)
aac0c6e3 8911
7be1c708 89122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8913
7be1c708
CY
8914 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8915 and LC_VERSION_MIN_MACOSX.
8916 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8917 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8918
97bb72a6
EZ
89192011-08-08 Eli Zaretskii <eliz@gnu.org>
8920
8921 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8922 no-display-properties-and-no-overlays under bidi display.
8923 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8924 properties and overlays.
97bb72a6 8925
d5617611
CY
89262011-08-08 Chong Yidong <cyd@stupidchicken.com>
8927
37e11a63
CY
8928 * editfns.c (Fset_time_zone_rule): Document relationship with the
8929 setenv function.
8930
d5617611
CY
8931 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8932 the font entity extracted from the cache (Bug#8109).
8933
58872834
CY
89342011-08-07 Chong Yidong <cyd@stupidchicken.com>
8935
8936 * composite.c (autocmp_chars): Don't reset point. That is done by
8937 restore_point_unwind (Bug#5984).
8938
75bfc667
JL
89392011-08-07 Juri Linkov <juri@jurta.org>
8940
8941 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8942 to show the arg `TIME' instead of `TIMEVAL'.
8943
d1410150
EZ
89442011-08-06 Eli Zaretskii <eliz@gnu.org>
8945
8946 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8947 display property strides EOL and includes a newline, as in
8948 longlines-mode. (Bug#9254)
75b771e4
EZ
8949 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8950 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8951
8952 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8953 is non-zero, even if the data buffer is NULL. Fixes a crash in
8954 vertical-motion with longlines-mode. (Bug#9254)
8955
35928349
EZ
89562011-08-05 Eli Zaretskii <eliz@gnu.org>
8957
ec7cc85b
EZ
8958 * bidi.c <bidi_cache_total_alloc>: Now static.
8959 (bidi_initialize): Initialize bidi_cache_total_alloc.
8960
8b76d6f8 8961 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8962 cache. (Bug#9221)
8963
8964 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8965 amount allocated this far in `bidi_cache_total_alloc'.
8966 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8967 non-zero, only free the data buffer without restoring the cache
8968 contents. All callers changed.
8969
8970 * dispextern.h (bidi_unshelve_cache): Update prototype.
8971
8972 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8973 (move_it_in_display_line, move_it_to)
8974 (move_it_vertically_backward, move_it_by_lines): Replace the call
8975 to xfree to an equivalent call to bidi_unshelve_cache.
8976 (move_it_in_display_line_to): Fix logic of returning
412b6358 8977 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8978
e2e2423b
EZ
89792011-08-05 Eli Zaretskii <eliz@gnu.org>
8980
8981 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8982 came from a string character with a `cursor' property. (Bug#9229)
8983
ae9e757a
JD
89842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8985
8986 * Makefile.in (LIB_PTHREAD): New variable.
8987 (LIBES): Add LIB_PTHREAD (Bug#9216).
8988
8989 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8990 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8991
213bd7f2
AS
89922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8993
6b02f655 8994 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8995
99aaf75f
JD
89962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8997
8998 * xterm.c (x_find_topmost_parent): New function.
8999 (x_set_frame_alpha): Find topmost parent window with
9000 x_find_topmost_parent and set the property there also (bug#9181).
9001 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9002
c74e9d86
PE
90032011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9004
9005 * callproc.c (Fcall_process): Avoid vfork clobbering
9006 the local vars buffer, coding_systems, current_dir.
9007
640c8776
SM
90082011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9009
9010 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9011
f26d0e4c
PE
90122011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9013
8a10d76c
PE
9014 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9015 so that it is not optimized away.
9016
f26d0e4c
PE
9017 * xdisp.c (compute_display_string_pos): Remove unused local.
9018
55439c61
EZ
90192011-08-02 Eli Zaretskii <eliz@gnu.org>
9020
9021 Fix slow cursor motion and scrolling in large buffers with
9022 selective display, like Org Mode buffers. (Bug#9218)
9023
9024 * dispextern.h (struct bidi_it): New member disp_prop_p.
9025
9026 * xdisp.c: Remove one-slot cache of display string positions.
9027 (compute_display_string_pos): Accept an additional argument
5e617bc2 9028 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9029 for a display string or property. If found, set DISP_PROP_P
9030 non-zero.
9031
9032 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9033 DISP_PROP_P, and pass it to compute_display_string_pos.
9034 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9035 non-zero. All callers of bidi_fetch_char changed.
9036
fb33fa43
SM
90372011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9038
9039 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9040
b099e063
DM
90412010-12-03 Don March <don@ohspite.net>
9042
9043 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9044 last character M-[char] is translated to ESC [char] (bug#7541).
9045
5cc7f7af
KH
90462011-08-02 Kenichi Handa <handa@m17n.org>
9047
d0fffa3f 9048 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9049
9050 * chartab.c (uniprop_table): Make it non-static.
9051
525d5e6e
EZ
90522011-08-01 Eli Zaretskii <eliz@gnu.org>
9053
9054 * xdisp.c (forward_to_next_line_start): Accept additional argument
9055 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9056 on the newline.
9057 (reseat_at_next_visible_line_start): Use the bidi iterator state
9058 returned by forward_to_next_line_start to restore the state of
9059 it->bidi_it after backing up to previous newline. (Bug#9212)
9060
31011111
AS
90612011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9062
9063 * regex.c (re_comp): Protoize.
9064 (re_exec): Fix return type.
9065 (regexec): Fix type of `ret'. (Bug#9203)
9066
476371c4
PE
90672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9068
e5d76069
PE
9069 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9070 This is needed if max-image-size is a floating-point number.
9071
9a79b20c
AS
90722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9073
9074 * print.c (print_object): Print empty symbol as ##.
9075
9076 * lread.c (read1): Read ## as empty symbol.
9077
d8c2fa78
AA
90782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9079
9080 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9081 setting frame foreground color (Bug#9175).
9082 (x_set_background_color): Likewise.
9083
ffe57a7a
AA
9084 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9085 contents (Bug#9176).
9086 (EmacsTooltip -init): Remove bezels and add shadows to
9087 tooltip windows.
9088
bf3492a5
AA
9089 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9090 or scroll bar (Bug#8470).
9091
d55e9c53
AA
9092 * nsfont.m (nsfont_open): Remove assignment to voffset and
9093 unnecessary vars hshink, expand, hd, full_height, min_height.
9094 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9095
9096 * nsterm.h (nsfont_info): Remove voffset field.
9097
d8c2fa78 90982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9099
9100 Implement strike-through and overline on NextStep (Bug#8863).
9101
9102 * nsfont.m (nsfont_open): Use underline position provided by font,
9103 instead of hard-coded value of 2.
9104 (nsfont_draw): Call ns_draw_text_decoration instead.
9105
9106 * nsterm.h: Add declaration for ns_draw_text_decoration.
9107
9108 * nsterm.m (ns_draw_text_decoration): New function for drawing
9109 underline, overline, and strike-through.
9110 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9111 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9112 accommodate underlining, etc.
4843aac3 9113
4cc60b9b
EZ
91142011-07-28 Eli Zaretskii <eliz@gnu.org>
9115
bc7ece87
EZ
9116 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9117 default.
4cc60b9b 9118
476371c4
PE
91192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9120
66606eea
PE
9121 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9122 Without this fix, if a signal arrives just after memory fills up,
9123 'malloc' might be invoked reentrantly.
9124
476371c4
PE
9125 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9126 In other words, assume that every image size is allowed, on non-X
9127 hosts. This assumption is probably wrong, but it lets Emacs compile.
9128
f3fcc40d
AS
91292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9130
9131 * regex.c (re_iswctype): Convert return values to boolean.
9132
350c992f
EZ
91332011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9134
9135 * xdisp.c (compute_display_string_pos): Don't use cached display
9136 string position if the buffer had its restriction changed.
9137 (Bug#9184)
9138
5266b4bb
PE
91392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9140
9141 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9142
2573a837 91432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9144
41f55ccd 9145 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9146
39e378da
PE
9147 * bidi.c: Integer size and overflow fixes.
9148 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9149 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9150 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9151 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9152 (bidi_find_other_level_edge):
9153 Use ptrdiff_t instead of EMACS_INT where either will do.
9154 This works better on 32-bit hosts configured --with-wide-int.
9155 (bidi_cache_ensure_space): Check for size-calculation overflow.
9156 Use % rather than repeated addition, for better worst-case speed.
9157 Don't set bidi_cache_size until after xrealloc returns, because it
9158 might not return.
9159 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9160 (bidi_cache_ensure_space): Also check that the bidi cache size
9161 does not exceed that of the largest Lisp string or buffer. See Eli
9162 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9163
5e927815
PE
9164 * alloc.c (__malloc_size_t): Remove.
9165 All uses replaced by size_t. See Andreas Schwab's note
9166 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9167
ca4aa935
PE
9168 * image.c: Improve checking for integer overflow.
9169 (check_image_size): Assume that f is nonnull, since
9170 it is always nonnull in practice. This is one less thing to
9171 worry about when checking for integer overflow later.
9172 (x_check_image_size): New function, which checks for integer
9173 overflow issues inside X.
9174 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9175 This removes the need for a memory_full check.
9176 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9177 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9178 (xbm_read_bitmap_data): Change locals back to 'int', since
9179 their values must fit in 'int'.
9180 (xpm_load_image, png_load, tiff_load):
9181 Invoke x_create_x_image_and_pixmap earlier,
9182 to avoid much needless work if the image is too large.
9183 (tiff_load): Treat overly large images as if
9184 x_create_x_image_and_pixmap failed, not as malloc failures.
9185 (gs_load): Use x_check_image_size.
9186
5f8f9cc2
PE
9187 * gtkutil.c: Omit integer casts.
9188 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9189 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9190
5adf60bc
PE
9191 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9192
c8907a93
PE
9193 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9194 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9195 would wrongly return t on a 64-bit host.
9196
e3c25c68
PE
9197 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9198 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9199 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9200 and therefore cause GCC to emit a bogus diagnostic in some cases.
9201
3f791afe
PE
9202 * image.c: Integer signedness and overflow and related fixes.
9203 This is not an exhaustive set of fixes, but it's time to
9204 record what I've got.
9205 (lookup_pixel_color, check_image_size): Remove redundant decls.
9206 (check_image_size): Don't assume that arbitrary EMACS_INT values
9207 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9208 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9209 (tiff_load, imagemagick_load_image):
9210 Check for overflow in size calculations.
9211 (x_create_x_image_and_pixmap): Remove unnecessary test for
9212 xmalloc returning NULL; that can't happen.
9213 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9214 (xpm_color_bucket): Use better integer hashing function.
9215 (xpm_cache_color): Don't possibly over-allocate memory.
9216 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9217 (gif_memory_source):
9218 Use ptrdiff_t, not int or size_t, to record sizes.
9219 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9220 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9221 either works, as we prefer signed integers.
9222 (tiff_read_from_memory, tiff_write_from_memory):
9223 Return tsize_t, not size_t, since that's what the TIFF API wants.
9224 (tiff_read_from_memory): Don't fail simply because the read would
9225 go past EOF; instead, return a short read.
9226 (tiff_load): Omit no-longer-needed casts.
9227 (Fimagemagick_types): Don't assume size fits into 'int'.
9228
3cc5a532
PE
9229 Improve hashing quality when configured --with-wide-int.
9230 * fns.c (hash_string): New function, taken from sxhash_string.
9231 Do not discard information about ASCII character case; this
9232 discarding is no longer needed.
9233 (sxhash-string): Use it. Change sig to match it. Caller changed.
9234 * lisp.h: Declare it.
9235 * lread.c (hash_string): Remove, since we now use fns.c's version.
9236 The fns.c version returns a wider integer if --with-wide-int is
9237 specified, so this should help the quality of the hashing a bit.
9238
b312a492
PE
9239 * emacs.c: Integer overflow minor fix.
9240 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9241 Define only if GNU_LINUX.
9242 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9243
dfd153ae
PE
9244 * dispnew.c: Integer signedness and overflow fixes.
9245 Remove unnecessary forward decls, that were a maintenance hassle.
9246 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9247 All uses changed.
9248 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9249 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9250 (prepare_desired_row, line_draw_cost):
9251 Use int, not unsigned, where either works.
9252 (save_current_matrix, restore_current_matrix):
9253 Use ptrdiff_t, not size_t, where either works.
9254 (init_display): Check for overflow more accurately, and without
9255 relying on undefined behavior.
9256
a81d11a3
PE
9257 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9258 Remove, replacing with the new symbols in lisp.h. All uses changed.
9259 * fileio.c (make_temp_name):
9260 * filelock.c (lock_file_1, lock_file):
9261 * xdisp.c (message_dolog):
9262 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9263 Use pMd etc. instead.
9264 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9265 replacing the pWIDE etc. symbols removed from editfns.c.
9266
3300e6fd
PE
9267 * keyboard.h (num_input_events): Now uintmax_t.
9268 This is (very slightly) less likely to mess up due to wraparound.
9269 All uses changed.
9270
fd05c7e9
PE
9271 * buffer.c: Integer signedness fixes.
9272 (alloc_buffer_text, enlarge_buffer_text):
9273 Use ptrdiff_t rather than size_t when either will do, as we prefer
9274 signed integers.
9275
903fe15d
PE
9276 * alloc.c: Integer signedness and overflow fixes.
9277 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9278 (__malloc_size_t): Default to size_t, not to int.
9279 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9280 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9281 Prefer ptrdiff_t to size_t when either would do, as we prefer
9282 signed integers.
9283 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9284 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9285 Now const. Initialize with values that are in range even if char
9286 is signed.
9287 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9288 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9289 These functions do the right thing with sizes > 2**32.
9290 (check_depth): Now ptrdiff_t, not int.
9291 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9292 Adjust to new way of storing sizes. Check for size overflow bugs
9293 in rest of code.
9294 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9295 slightly wrong anyway, as it missed one instance of
9296 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9297 (refill_memory_reserve): Omit needless cast to size_t.
9298 (mark_object_loop_halt): Mark as externally visible.
9299
ac82cc6a
PE
9300 * xselect.c: Integer signedness and overflow fixes.
9301 (Fx_register_dnd_atom, x_handle_dnd_message):
9302 Use ptrdiff_t, not size_t, since we prefer signed.
9303 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9304 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9305 x_dnd_atoms_size and x_dnd_atoms_length.
9306
c2d1e36d
PE
9307 * doprnt.c: Prefer signed to unsigned when either works.
9308 * eval.c (verror):
9309 * doprnt.c (doprnt):
9310 * lisp.h (doprnt):
9311 * xdisp.c (vmessage):
9312 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9313 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9314 prefer signed arithmetic to avoid comparison confusion.
9315 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9316 but is a bit tricky.
9317
0e926e56
PE
9318 Assume freestanding C89 headers, string.h, stdlib.h.
9319 * data.c, doprnt.c, floatfns.c, print.c:
9320 Include float.h unconditionally.
9321 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9322 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9323 * regex.c: Likewise for stddef.h, string.h.
9324 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9325 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9326 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9327 (STDC_HEADERS): Remove obsolete defines.
9328 * sysdep.c: Include limits.h unconditionally.
9329
9cfdb3ec
PE
9330 Assume support for memcmp, memcpy, memmove, memset.
9331 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9332 * regex.c (memcmp, memcpy):
9333 Remove; we assume C89 now.
9334
9335 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9336 (__malloc_safe_bcopy): Remove; no longer needed.
9337
cf950e6b 9338 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9339 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9340 well either way, and we prefer signed to unsigned.
9341
dbf38e02
LMI
93422011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9343
9344 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9345 closes the connection while we're reading (bug#9182).
9346
d6f0886c 93472011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9348
d6f0886c
JD
9349 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9350 are specified (Bug#9168).
24e0f6b1 9351
2eb1f9e6
PE
93522011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9353
9354 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9355 Found by GCC static checking and --with-wide-int on a 32-bit host.
9356
22381272 93572011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9358
9359 * xdisp.c (compute_display_string_pos): Fix logic of caching
9360 previous display string position. Initialize cached_prev_pos to
9361 -1. Fixes slow-down at the beginning of a buffer.
9362
f25e39b4
EZ
93632011-07-24 Eli Zaretskii <eliz@gnu.org>
9364
9365 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9366 for attrs[LFACE_FONTSET_INDEX].
9367
04c4b52e
PE
93682011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9369
9370 * xml.c (parse_region): Remove unused local
9371 that was recently introduced.
9372
c1734fbd
EZ
93732011-07-23 Eli Zaretskii <eliz@gnu.org>
9374
be18c5a5
EZ
9375 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9376 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9377
c1734fbd
EZ
9378 * xdisp.c (move_it_in_display_line_to): Record the best matching
9379 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9380 exit if none of the characters scanned was an exact match.
9381 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9382 when exact match is impossible due to invisible text, and the
9383 lines are truncated.
9384
a258d627
JD
93852011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9386
9387 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9388 for OSX >= 10.7.
9389
b6d5a689
EZ
93902011-07-22 Eli Zaretskii <eliz@gnu.org>
9391
0f74f785
EZ
9392 Fix a significant slow-down of cursor motion with C-n, C-p,
9393 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9394 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9395 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9396 (next_element_from_buffer): Call compute_stop_pos_backwards to
9397 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9398 base_level_stop.
9399 (reseat): Don't look for prev_stop, as that could mean a very long
9400 run.
9401 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9402 <cached_disp_overlay_modiff>: Cache for last found display string
9403 position.
551918c1 9404 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9405 about the same buffer in the same area of character positions, and
9406 the buffer wasn't changed since the time the display string
9407 position was cached.
551918c1 9408
b2d0c91a
EZ
94092011-07-22 Eli Zaretskii <eliz@gnu.org>
9410
9411 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9412 is an integer, which is important for empty lines. (Bug#9149)
9413
043604ee
CY
94142011-07-22 Chong Yidong <cyd@stupidchicken.com>
9415
9416 * frame.c (Fmodify_frame_parameters): In tty case, update the
9417 default face if necessary (Bug#4238).
9418
da4adb04
CY
94192011-07-21 Chong Yidong <cyd@stupidchicken.com>
9420
9421 * editfns.c (Fstring_to_char): No need to explain what a character
9422 is in the docstring (Bug#6576).
9423
9abd0532
LMI
94242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9425
9426 * xml.c (parse_region): Make sure we always return a tree.
9427
36881d16
HK
94282011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9429
9430 * xml.c (parse_region): If a document contains only comments,
9431 return that, too.
9432
1e98674d
LMI
94332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9434
9435 * xml.c (make_dom): Return comments, too.
9436
590bd467
PE
94372011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9438
9439 Port to OpenBSD.
9440 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9441 and the surrounding thread.
9442 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9443 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9444 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9445 timer goes off.
9446 * s/openbsd.h (BROKEN_SIGIO): Define.
9447 * unexelf.c (unexec) [__OpenBSD__]:
9448 Don't update the .mdebug section of the Alpha COFF symbol table.
9449
f41628b2
LMI
94502011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9451
9452 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9453 (bug#8460).
9454
b59b67c5
PE
94552011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9456
15e3a074
PE
9457 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9458 This fixes some race conditions on the permissions of any newly
9459 created file.
9460
41bed37d
PE
9461 * alloc.c (valid_pointer_p): Use pipe, not open.
9462 This fixes some permissions issues when debugging.
9463
b59b67c5
PE
9464 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9465 If fchown fails to set both uid and gid, try to set just gid,
9466 as that is sometimes allowed. Adjust the file's mode to eliminate
9467 setuid or setgid bits that are inappropriate if fchown fails.
9468
925a6be7
SM
94692011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9470
9471 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9472 to compare Lisp_Objects.
9473 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9474 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9475 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9476
52968808
AS
94772011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9478
0a6a104b
AS
9479 * lread.c (read_integer): Unread even EOF character.
9480 (read1): Likewise. Properly record start position of symbol.
9481
52968808
AS
9482 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9483 symbol character follows.
9484
9e381cdd
PE
94852011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9486
9487 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9488 This works around a problem with the previous change to Fcopy_file.
9489 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9490 and without this change, GCC might complain about discarding
9491 fchown's return value.
9492
b5641435
JB
94932011-07-16 Juanma Barranquero <lekktu@gmail.com>
9494
9495 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9496
a8031457
PE
94972011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9498
9499 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9500
dd889327
LMI
95012011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9502
750c33f7
LMI
9503 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9504 it's used from the C level.
9505
dd889327
LMI
9506 * process.c: Use the same condition for POLL_FOR_INPUT in both
9507 keyboard.c and process.c (bug#1858).
9508
87e86684
LM
95092011-07-09 Lawrence Mitchell <wence@gmx.li>
9510
9511 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9512 (Fgnutls_boot): Use it.
9513
64348f40
AS
95142011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9515
9516 * doc.c (Fsubstitute_command_keys): Revert last change.
9517
1d698799
LMI
95182011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9519
f863868c
LMI
9520 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9521 quotes the next character, and doesn't affect other longer
9522 sequences (bug#8935).
9523
1d698799
LMI
9524 * lread.c (syms_of_lread): Clarify that is isn't only
9525 `eval-buffer' and `eval-defun' that's affected by
9526 `lexical-binding' (bug#8460).
9527
aa4b6df6
EZ
95282011-07-15 Eli Zaretskii <eliz@gnu.org>
9529
9530 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9531 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9532
5d856da6
PE
95332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9534
ad6042bb
PE
9535 Fix minor problems found by static checking.
9536 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9537 (elsz): Now a signed constant, not a size_t var. We prefer signed
9538 types to unsigned, to avoid integer comparison confusion. Without
9539 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9540 "cannot optimize loop, the loop counter may overflow", a symptom
9541 of the confusion.
f00bbb22 9542 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9543 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9544
6468f31c
LMI
95452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9546
49080b10
LMI
9547 * search.c (Fre_search_backward): Mention `case-fold-search' in
9548 all the re_search_* functions (bug#8138).
9549
6468f31c
LMI
9550 * keyboard.c (Fopen_dribble_file): Document when the file is
9551 closed (bug#8056).
9552
c965adc5
EZ
95532011-07-14 Eli Zaretskii <eliz@gnu.org>
9554
df9733bf
EZ
9555 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9556 bidi_cache_idx.
9557
0bb23927
EZ
9558 Support bidi reordering of display and overlay strings.
9559 * xdisp.c (compute_display_string_pos)
9560 (compute_display_string_end): Accept additional argument STRING.
9561 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9562 (reseat_to_string): Initialize bidi_it->string.s and
9563 bidi_it->string.schars.
9564 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9565 NULL (avoids a crash in bidi_paragraph_init).
9566 Initialize itb.string.lstring.
0bb23927
EZ
9567 (init_iterator): Call bidi_init_it only of a valid
9568 buffer position was specified. Initialize paragraph_embedding to
9569 L2R.
9570 (reseat_to_string): Initialize the bidi iterator.
9571 (display_string): If we need to ignore text properties of
9572 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9573 original value of -1 will not work with bidi.)
9574 (compute_display_string_pos): First arg is now struct
9575 `text_pos *'; all callers changed. Support display properties on
9576 Lisp strings.
9577 (compute_display_string_end): Support display properties on Lisp
9578 strings.
9579 (init_iterator, reseat_1, reseat_to_string): Initialize the
9580 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9581 when iterating on a string not from display properties).
640c8776
SM
9582 (compute_display_string_pos, compute_display_string_end):
9583 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9584 arrow keys.
9585 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9586 base_level_stop; instead, set base_level_stop to BEGV.
9587 Fixes crashes in vertical-motion.
0bb23927
EZ
9588 (next_element_from_buffer): Improve commentary for when
9589 the iterator is before prev_stop.
9590 (init_iterator): Initialize bidi_p from the default value of
9591 bidi-display-reordering, not from buffer-local value. Use the
9592 buffer-local value only if initializing for buffer iteration.
9593 (handle_invisible_prop): Support invisible properties on strings
9594 that are being bidi-reordered.
9595 (set_iterator_to_next): Support bidi reordering of C strings and
9596 Lisp strings.
9597 (next_element_from_string): Support bidi reordering of Lisp
9598 strings.
9599 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9600 (display_string): Support display of R2L glyph rows.
9601 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9602 (init_iterator): Don't initialize it->bidi_p for strings
9603 here.
9604 (reseat_to_string): Initialize it->bidi_p for strings here.
9605 (next_element_from_string, next_element_from_c_string)
9606 (next_element_from_buffer): Add xassert's for correspondence
9607 between IT's object being iterated and it->bidi_it.string
9608 structure.
9609 (face_before_or_after_it_pos): Support bidi iteration.
9610 (next_element_from_c_string): Handle the case of the first string
9611 character that is not the first one in the visual order.
9612 (get_visually_first_element): New function, refactored from common
9613 parts of next_element_from_buffer, next_element_from_string, and
9614 next_element_from_c_string.
9615 (tool_bar_lines_needed, redisplay_tool_bar)
9616 (display_menu_bar): Force left-to-right direction. Add a FIXME
9617 comment for making that be controlled by a user option.
9618 (push_it, pop_it): Save and restore the state of the
9619 bidi iterator. Save and restore the bidi_p flag.
9620 (pop_it): Iterate out of display property for string iteration as
9621 well.
9622 (iterate_out_of_display_property): Support iteration over strings.
9623 (handle_single_display_spec): Set up it->bidi_it for iteration
9624 over a display string, and call bidi_init_it.
9625 (handle_single_display_spec, next_overlay_string)
9626 (get_overlay_strings_1, push_display_prop): Set up the bidi
9627 iterator for displaying display or overlay strings.
9628 (forward_to_next_line_start): Don't use the shortcut if
9629 bidi-iterating.
9630 (back_to_previous_visible_line_start): If handle_display_prop
9631 pushed the iterator stack, restore the internal state of the bidi
9632 iterator by calling bidi_pop_it same number of times.
9633 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9634 and we are bidi-iterating, don't decrement the iterator position;
9635 instead, set the first_elt flag in the bidi iterator, to produce
9636 the same effect.
9637 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9638 (push_display_prop): xassert that we are iterating a buffer.
9639 (push_it, pop_it): Save and restore paragraph_embedding member.
9640 (handle_single_display_spec, next_overlay_string)
9641 (get_overlay_strings_1, reseat_1, reseat_to_string)
9642 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9643 correctly. Don't assume unibyte strings are not bidi-reordered.
9644 (compute_display_string_pos)
9645 (compute_display_string_end): Fix handling the case of C string.
9646 (push_it, pop_it): Save and restore from_disp_prop_p.
9647 (handle_single_display_spec, push_display_prop): Set the
9648 from_disp_prop_p flag.
9649 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9650 (pop_it): Call iterate_out_of_display_property only if we are
9651 popping after iteration over a string that came from a display
9652 property. Fix a typo in popping stretch info. Add an assertion
9653 for verifying that the iterator position is in sync with the bidi
9654 iterator.
9655 (handle_single_display_spec, get_overlay_strings_1)
9656 (push_display_prop): Fix initialization of paragraph direction for
9657 string when that of the parent object is not yet determined.
9658 (reseat_1): Call bidi_init_it to resync the bidi
9659 iterator with IT's position. (Bug#7616)
9660 (find_row_edges): If ROW->start.pos gives position
9661 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9662 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9663 Reset the from_disp_prop_p flag.
9664 (SAVE_IT, RESTORE_IT): New macros.
9665 (pos_visible_p, face_before_or_after_it_pos)
9666 (back_to_previous_visible_line_start)
9667 (move_it_in_display_line_to, move_it_in_display_line)
9668 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9669 (try_scrolling, redisplay_window, display_line): Use them when
9670 saving a temporary copy of the iterator and restoring it back.
9671 (back_to_previous_visible_line_start, reseat_1)
9672 (init_iterator): Empty the bidi cache "stack".
9673 (move_it_in_display_line_to): If iterator ended up at
9674 EOL, but we never saw any buffer positions smaller than
9675 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9676 motion in bidi-reordered lines.
9677 (move_it_in_display_line_to): Record prev_method and prev_pos
9678 immediately before the call to set_iterator_to_next. Fixes cursor
9679 motion in bidi-reordered lines with stretch glyphs and strings
9680 displayed in margins. (Bug#8133) (Bug#8867)
9681 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9682 TO_CHARPOS.
640c8776
SM
9683 (pos_visible_p): Support positions in bidi-reordered lines.
9684 Save and restore bidi cache.
0bb23927
EZ
9685
9686 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9687 (bidi_paragraph_info): Delete unused struct.
9688 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9689 (bidi_cache_start): New variable.
9690 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9691 to zero.
9692 (bidi_cache_fetch_state, bidi_cache_search)
9693 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9694 (bidi_cache_find, bidi_peek_at_next_level)
9695 (bidi_level_of_next_char, bidi_find_other_level_edge)
9696 (bidi_move_to_visually_next): Compare cache index with
9697 bidi_cache_start rather than with zero.
9698 (bidi_fetch_char): Accept new argument STRING; all callers
9699 changed. Support iteration over a string. Support strings with
9700 display properties. Support unibyte strings. Fix the type of
9701 `len' according to what STRING_CHAR_AND_LENGTH expects.
9702 (bidi_paragraph_init, bidi_resolve_explicit_1)
9703 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9704 (bidi_level_of_next_char, bidi_move_to_visually_next):
9705 Support iteration over a string.
0bb23927
EZ
9706 (bidi_set_sor_type, bidi_resolve_explicit_1)
9707 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9708 can now be zero (for strings); special values 0 and -1 were
9709 changed to -1 and -2, respectively.
9710 (bidi_char_at_pos): New function.
9711 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9712 Call it instead of FETCH_MULTIBYTE_CHAR.
9713 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9714 initialized to valid values.
9715 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9716 values.
9717 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9718 the test for valid cached positions. Fix the logic for looking up
9719 the sentinel state in the cache. GCPRO the Lisp string we are
9720 iterating.
9721 (bidi_push_it, bidi_pop_it): New functions.
9722 (bidi_initialize): Initialize the bidi cache start stack pointer.
9723 (bidi_cache_ensure_space): New function, refactored from part of
9724 bidi_cache_iterator_state. Don't assume the required size is just
9725 one BIDI_CACHE_CHUNK away.
9726 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9727 (bidi_count_bytes, bidi_char_at_pos): New functions.
9728 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9729 always valid if bidi_cache_idx is valid.
9730 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9731 is valid if it's going to be used.
9732 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9733 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9734 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9735 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9736 (bidi_find_other_level_edge, bidi_cache_start_stack):
9737 All variables related to cache indices are now EMACS_INT.
c965adc5 9738
0bb23927
EZ
9739 * dispextern.h (struct bidi_string_data): New structure.
9740 (struct bidi_it): New member `string'. Make flag members be 1-bit
9741 fields, and put them last in the struct.
640c8776
SM
9742 (compute_display_string_pos, compute_display_string_end):
9743 Update prototypes.
0bb23927
EZ
9744 (bidi_push_it, bidi_pop_it): Add prototypes.
9745 (struct iterator_stack_entry): New members bidi_p,
9746 paragraph_embedding, and from_disp_prop_p.
9747 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9748 (bidi_shelve_cache, bidi_unshelve_cache):
9749 Declare prototypes.
0bb23927
EZ
9750
9751 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9752 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9753 and vector-like objects.
9754
9755 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9756 cache around display iteration.
9757
9758 * window.c (Fwindow_end, window_scroll_pixel_based)
9759 (displayed_window_lines, Frecenter): Save and restore the bidi
9760 cache around display iteration.
9761
3bbd2265
LMI
97622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9763
9764 * editfns.c (Fdelete_region): Clarify the use of the named
9765 parameters (bug#6788).
9766
adc47434
MR
97672011-07-14 Martin Rudalics <rudalics@gmx.at>
9768
9769 * indent.c (Fvertical_motion): Set and restore w->pointm when
9770 saving and restoring the window's buffer (Bug#9006).
9771
837c31f8
LMI
97722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9773
9774 * editfns.c (Fstring_to_char): Clarify just what is returned
9775 (bug#6576). Text by Eli Zaretskii.
9776
ac389d0c
JB
97772011-07-13 Juanma Barranquero <lekktu@gmail.com>
9778
9779 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9780
0be0ce47
EZ
97812011-07-13 Eli Zaretskii <eliz@gnu.org>
9782
9783 * buffer.c (mmap_find): Fix a typo.
9784
cd18e7e3
JB
97852011-07-13 Johan Bockgård <bojohan@gnu.org>
9786
9787 Fix execution of x selection hooks.
9788 * xselect.c (Qx_lost_selection_functions)
9789 (Qx_sent_selection_functions): New vars.
9790 (syms_of_xselect): DEFSYM them.
9791 (x_handle_selection_request): Pass Qx_sent_selection_functions
9792 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9793 (x_handle_selection_clear,x_clear_frame_selections):
9794 Pass Qx_lost_selection_functions rather than
9795 Vx_lost_selection_functions to Frun_hook_with_args.
9796
47ea7f44
PE
97972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9798
ac389d0c 9799 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9800 The old code sometimes used this field without initializing it.
9801
47ea7f44
PE
9802 * alloc.c (gc_sweep): Don't read past end of array.
9803 In theory, the old code could also have corrupted Emacs internals,
9804 though it'd be very unlikely.
9805
bc985c87
AS
98062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9807
9808 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9809 argument. (Bug#4026)
bc985c87 9810
0cf34688
LMI
98112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9812
b3dadd76
LMI
9813 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9814 key" (bug#4257).
9815
0cf34688
LMI
9816 * window.c (Fset_window_start): Doc fix (bug#4199).
9817 (Fset_window_hscroll): Ditto.
9818
270768cd
PE
98192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9820
077e3dda 9821 Fix minor new problems caught by GCC 4.6.1.
270768cd 9822 * term.c (init_tty): Remove unused local.
490011a6 9823 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9824 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9825 not used otherwise.
270768cd 9826
b1f58454
CY
98272011-07-12 Chong Yidong <cyd@stupidchicken.com>
9828
9829 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9830
22b9578d
LMI
98312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9832
6e70ab07
LMI
9833 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9834 are the mini-buffer and the echo area (bug#3320).
9835
22b9578d
LMI
9836 * term.c (init_tty): Remove support for supdup, c10 and perq
9837 terminals, which are no longer supported (bug#1482).
9838
8974cc9f
JB
98392011-07-10 Johan Bockgård <bojohan@gnu.org>
9840
9841 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9842
a560d974
JD
98432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9844
9845 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9846 for non-popups (Bug#3642).
9847
1dae0f0a
AS
98482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9849
268c2c36 9850 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9851 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9852 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9853 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9854 * data.c (fmod): Likewise.
9855 * dispnew.c (swap_glyphs_in_rows): Likewise.
9856 * emacs.c (memory_warning_signal): Likewise.
9857 * floatfns.c (float_error): Likewise.
9858 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9859 (otf_open, font_otf_capability, generate_otf_features)
9860 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9861 Likewise.
9862 * image.c (pbm_read_file): Likewise.
9863 * indent.c (string_display_width): Likewise.
9864 * intervals.c (check_for_interval, search_for_interval)
9865 (inc_interval_count, count_intervals, root_interval)
9866 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9867 * lread.c (defalias): Likewise.
268c2c36 9868 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9869 * regex.c (set_image_of_range_1, set_image_of_range)
9870 (regex_grow_registers): Likewise.
9871 * sysdep.c (strerror): Likewise.
9872 * termcap.c (valid_filename_p, tprint, main): Likewise.
9873 * tparam.c (main): Likewise.
9874 * unexhp9k800.c (run_time_remap, save_data_space)
9875 (update_file_ptrs, read_header, write_header, calculate_checksum)
9876 (copy_file, copy_rest, display_header): Likewise.
9877 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9878 Likewise.
9879 * xdisp.c (check_it): Likewise.
9880 * xfaces.c (register_color, unregister_color, unregister_colors):
9881 Likewise.
9882 * xfns.c (print_fontset_result): Likewise.
9883 * xrdb.c (member, fatal, main): Likewise.
9884
99033785
PE
98852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9886
9887 Fix minor problems found by static checking (Bug#9031).
9888 * chartab.c (char_table_set_range, map_sub_char_table):
9889 Remove unused locals.
9890 (uniprop_table): Now static.
9891 * composite.c (_work_char): Remove unused static var.
9892
9cb2ac56
JB
98932011-07-09 Juanma Barranquero <lekktu@gmail.com>
9894
9895 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9896
f25661f0
JD
98972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9898
9899 * gtkutil.c (qttip_cb): Remove code without function.
9900
8278c4fe
EZ
99012011-07-09 Eli Zaretskii <eliz@gnu.org>
9902
9903 * w32.c (pthread_sigmask): New stub.
9904
1692ae2d 99052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9906
8a6ebd58 9907 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9908 sigprocmask is portable only for single-threaded applications, and
9909 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9910 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9911 (LIBES): Use it.
9912 * callproc.c (Fcall_process):
9913 * process.c (create_process):
9914 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9915 Use pthread_sigmask, not sigprocmask.
123403e4 9916
1b854618
JD
99172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9918
9919 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9920 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9921 wrong (Bug#8591).
9922
3fe4b549
JD
99232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9924
0ce7e563
JD
9925 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9926 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9927 (xg_hide_tooltip): Fix comment.
9928
3fe4b549
JD
9929 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9930 in registerServicesMenuSendTypes.
9931 (validRequestorForSendType): Don't check ns_return_types.
9932
9933 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9934 ns_return_type.
9935
5df75e47
JR
99362011-07-08 Jason Rumney <jasonr@gnu.org>
9937
22610910
JR
9938 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9939 SH_SHOW for hidden windows (Bug#5482).
9940
5df75e47
JR
9941 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9942 frame struct members of non-existent frames (Bug#6284).
9943
699c10bd
JD
99442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9945
4393663b
JD
9946 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9947 variable firstTime not needed on OSX >= 10.6.
9948 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9949 >= 10.5. Use setKnobProportion, setDoubleValue.
9950
9951 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9952 (MAC_OS_X_VERSION_10_5): Define if not defined.
9953 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9954 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9955 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9956
9957 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9958 cString and lossyCString on OSX >= 10.4.
4393663b 9959
58179cce 9960 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9961 sizeToFit on OSX >= 10.2.
9962
9963 * nsimage.m (allocInitFromFile): Don't use deprecated method
9964 bestRepresentationForDevice on OSX >= 10.6.
9965
9966 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9967 to avoid warning.
9968
9969 * emacs.c: Declare unexec_init_emacs_zone.
9970
a63e0781
JD
9971 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9972
699c10bd
JD
9973 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9974
9975 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9976 on svcsMenu (Bug#8842).
9977
9978 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9979 ns_return_types.
9980 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9981
9982 * nsterm.m (QUTF8_STRING): Declare.
9983 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9984 (validRequestorForSendType): Return type is (id).
9985 Change indexOfObjectIdenticalTo to indexOfObject.
9986 Check if we have local selection before returning self (Bug#8842).
9987 (writeSelectionToPasteboard): Put local selection into paste board
9988 if we have a local selection (Bug#8842).
9989 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9990
9991 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9992 (ns_get_local_selection): Declare.
9993
54e10184
LMI
99942011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9995
9888ff71
LMI
9996 * keymap.c (describe_map_tree): Don't insert a double newline at
9997 the end of the buffer (bug#1169) and return whether we inserted
9998 something.
9999
54e10184
LMI
10000 * callint.c (Fcall_interactively): Change "reading args" to
10001 "providing args" to try to clarify what it does (bug#1010).
10002
15fa4783
KH
100032011-07-07 Kenichi Handa <handa@m17n.org>
10004
10005 * composite.c (composition_compute_stop_pos): Ignore a static
10006 composition starting before CHARPOS (Bug#8915).
10007
10008 * xdisp.c (handle_composition_prop): Likewise.
10009
a8815b00
EZ
100102011-07-07 Eli Zaretskii <eliz@gnu.org>
10011
10012 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10013 (Bug#9015)
10014
ef7b981d 100152011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10016
10017 * character.h (unicode_category_t): New enum type.
10018
10019 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10020 (Qchar_code_property_table): New variable.
10021 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10022 (UNIPROP_COMPRESSED_FORM_P): New macros.
10023 (char_table_ascii): Uncompress the compressed values.
10024 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10025 Uncompress the compressed values.
ac389d0c 10026 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10027 (char_table_ref_and_range): Uncompress the compressed values.
10028 (sub_char_table_set): New arg is_uniprop. Callers changed.
10029 Uncompress the compressed values.
10030 (sub_char_table_set_range): Args changed. Callers changed.
10031 (char_table_set_range): Adjuted for the above change.
10032 (map_sub_char_table): Delete args default_val and parent. Add arg
10033 top. Give decoded values to a Lisp function.
640c8776 10034 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10035 values to a Lisp function. Gcpro more variables.
10036 (uniprop_table_uncompress)
10037 (uniprop_decode_value_run_length): New functions.
10038 (uniprop_decoder, uniprop_decoder_count): New variables.
10039 (uniprop_get_decoder, uniprop_encode_value_character)
10040 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10041 New functions.
10042 (uniprop_encoder, uniprop_encoder_count): New variables.
10043 (uniprop_get_encoder, uniprop_table)
10044 (Funicode_property_table_internal, Fget_unicode_property_internal)
10045 (Fput_unicode_property_internal): New functions.
10046 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10047 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10048 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10049 char-code-property-alist.
10050
640c8776 10051 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10052 Vunicode_category_table.
10053
640c8776 10054 * font.c (font_range): Adjust for the change of
c805dec0
KH
10055 Vunicode_category_table.
10056
76b397fb
DN
100572011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10058
10059 * m/iris4d.h: Remove file, move contents ...
10060 * s/irix6-5.h: ... here.
10061
22b4128e
PE
100622011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10063
10064 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10065 * alloc.c (mark_buffer):
10066 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10067 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10068 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10069 This isn't true in general, and it's particularly not true
10070 if Emacs is configured with --with-wide-int.
10071 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10072 New macros, used in the buffer.c change.
10073
869795d6
JD
100742011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10075
10076 * xsettings.c: Use both GConf and GSettings if both are available.
10077 (store_config_changed_event): Add comment.
10078 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10079 (store_tool_bar_style_changed): New functions.
5e617bc2 10080 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10081 (struct xsettings): Move font inside HAVE_XFT.
10082 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10083 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10084 Move inside HAVE_XFT.
640c8776 10085 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10086 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10087 also.
10088 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10089 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10090 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10091 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10092 (parse_settings): Move check for font inside HAVE_XFT.
10093 (read_settings, apply_xft_settings): Add comment.
10094 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10095 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10096 call store_font_name_changed.
10097 (xft_settings_event): Add comment.
10098 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10099 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10100 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10101 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10102 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10103 (xsettings_get_system_font, xsettings_get_system_normal_font):
10104 Add comment.
869795d6 10105
d8ed26bd
PE
101062011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10107
10108 Random fixes. E.g., (random) never returned negative values.
10109 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10110 subseconds part to the entropy, as that's a bit more random.
10111 Prefer signed to unsigned, since the signedness doesn't matter and
10112 in general we prefer signed. When given a limit, use a
10113 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10114 latter isn't right if USE_2_TAGS_FOR_INTS.
10115 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10116 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10117
cabf1cac
SM
101182011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10119
10120 * textprop.c (text_property_stickiness):
10121 Obey Vtext_property_default_nonsticky.
10122 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10123 * w32fns.c (syms_of_w32fns):
10124 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10125
6e9b2be9
PE
101262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10127
10128 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10129 This is more efficient than Ffile_directory_p and avoids a minor race.
10130
90186c68
LMI
101312011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10132
7c301272
LMI
10133 * buffer.c (Foverlay_put): Say what the return value is
10134 (bug#7835).
10135
c4f2d8d4
LMI
10136 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10137 is a directory before asking whether to use the file name
10138 (bug#7564).
ad637907
LMI
10139 (barf_or_query_if_file_exists): Make the "File is a directory"
10140 error be more correct.
c4f2d8d4 10141
90186c68
LMI
10142 * fns.c (Frequire): Remove the mention of the .gz files, since
10143 that's installation-specific, but keep the mention of
10144 `get-load-suffixes'.
10145
da64016e
PE
101462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10147
10148 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10149 Report string overflow if the output is too long.
10150
7d47b580
JB
101512011-07-04 Juanma Barranquero <lekktu@gmail.com>
10152
a555cb87
JB
10153 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10154 (syms_of_gnutls): Remove duplicate DEFSYM for
10155 Qgnutls_bootprop_verify_hostname_error, an error for
10156 Qgnutls_bootprop_verify_error (which is no longer used).
10157
7d47b580
JB
10158 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10159 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10160 Also (re)move comments that are misplaced or no longer relevant.
10161
1e49bfab
LMI
101622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10163
10164 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10165
1485f4c0
CY
101662011-07-03 Chong Yidong <cyd@stupidchicken.com>
10167
10168 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10169 and background color parameters if they have been changed.
10170
a9ab721e
LMI
101712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10172
10173 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10174
cf7cff57
PE
101752011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10176
2e13213d
PE
10177 * xsettings.c (SYSTEM_FONT): Define only when used.
10178 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10179
cf7cff57
PE
10180 * keymap.c (access_keymap_1): Now static.
10181
7a8e04f7
CY
101822011-07-02 Chong Yidong <cyd@stupidchicken.com>
10183
10184 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10185 leave any prefix arg for the up event (Bug#1586).
10186
61352f62
LMI
101872011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10188
69bb1ef7
LMI
10189 * lread.c (syms_of_lread): Mention single symbols defined by
10190 `defvar' or `defconst' (bug#7154).
10191
61352f62 10192 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10193 (Frequire): Mention get-load-suffixes.
61352f62 10194
28545e04
MR
101952011-07-02 Martin Rudalics <rudalics@gmx.at>
10196
10197 * window.h (window): Remove clone_number slot.
10198 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10199 Remove.
10200 (make_parent_window, make_window, saved_window)
10201 (Fset_window_configuration, save_window_save): Don't deal with
10202 clone numbers.
10203 * buffer.c (Qclone_number): Remove declaration.
10204 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10205
3349e122
SM
102062011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10207
10208 Add multiple inheritance to keymaps.
10209 * keymap.c (Fmake_composed_keymap): New function.
10210 (Fset_keymap_parent): Simplify.
10211 (fix_submap_inheritance): Remove.
10212 (access_keymap_1): New function extracted from access_keymap to handle
10213 embedded parents and handle lists of maps.
10214 (access_keymap): Use it.
10215 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10216 (Fcopy_keymap): Handle embedded parents.
10217 (Fcommand_remapping, define_as_prefix): Simplify.
10218 (Fkey_binding): Simplify.
10219 (syms_of_keymap): Move minibuffer-local-completion-map,
10220 minibuffer-local-filename-completion-map,
10221 minibuffer-local-must-match-map, and
10222 minibuffer-local-filename-must-match-map to Elisp.
10223 (syms_of_keymap): Defsubr make-composed-keymap.
10224 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10225 (parse_menu_item): Trivial simplification.
10226
3279eb87
GM
102272011-07-01 Glenn Morris <rgm@gnu.org>
10228
10229 * Makefile.in (SETTINGS_LIBS): Fix typo.
10230
39cb9e56 102312011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10232
10233 * coding.c (Fencode_coding_string): Record the last coding system
10234 used, as the function doc string says (bug#8738).
10235
0949d2b6
JD
102362011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10237
10238 * xsettings.c (store_monospaced_changed): Take new font as arg and
10239 check for change against current_mono_font.
10240 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10241 (emacs_settings_constructor, emacs_settings_get_property)
10242 (emacs_settings_set_property, emacs_settings_class_init)
10243 (emacs_settings_init, gsettings_obj): Remove.
10244 (something_changedCB): New function for HAVE_GSETTINGS.
10245 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10246 with value as argument.
10247 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10248 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10249 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10250 "changed".
10251
10252 * xgselect.c: Add defined (HAVE_GSETTINGS).
10253 (xgselect_initialize): Ditto.
10254
10255 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10256 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10257 xg_select.
10258
bbc6b304
PE
102592011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10260
10261 * eval.c (struct backtrace): Simplify and port the data structure.
10262 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10263 signed bit field, as this assumption is not portable and it makes
10264 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10265 "char debug_on_exit : 1" as this is not portable either; instead,
10266 use the portable "unsigned int debug_on_exit : 1". Remove unused
10267 member evalargs. Remove obsolete comments about cc bombing out.
10268
9851bfc5
JD
102692011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10270
51bb811f 10271 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10272 Let HAVE_GSETTINGS override HAVE_GCONF.
10273 (store_monospaced_changed): New function.
10274 (EMACS_SETTINGS): A new type derived from GObject to handle
10275 GSettings notifications.
10276 (emacs_settings_constructor, emacs_settings_get_property)
10277 (emacs_settings_set_property, emacs_settings_class_init):
10278 New functions.
10279 (gsettings_client, gsettings_obj): New variables.
10280 (GSETTINGS_SCHEMA): New define.
10281 (something_changedCB): Call store_monospaced_changed.
10282 (init_gsettings): New function.
10283 (xsettings_initialize): Call init_gsettings.
10284 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10285 to NULL.
10286
640c8776 10287 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10288 GCONF_CFLAGS/LIBS.
10289
5386012d
MR
102902011-06-29 Martin Rudalics <rudalics@gmx.at>
10291
10292 * window.c (resize_root_window, grow_mini_window)
10293 (shrink_mini_window): Rename Qresize_root_window to
10294 Qwindow_resize_root_window and Qresize_root_window_vertically to
10295 Qwindow_resize_root_window_vertically.
10296
f13e0b08
PE
102972011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10298
10299 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10300
94515237
JB
103012011-06-27 Juanma Barranquero <lekktu@gmail.com>
10302
10303 * makefile.w32-in: Redesign dependencies so they reflect more
10304 clearly which files are directly included by each source file,
10305 and not through other includes.
10306
e43b6e43
MR
103072011-06-27 Martin Rudalics <rudalics@gmx.at>
10308
10309 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10310 (sort_overlays, overlay_strings): When an overlay's clone number
10311 matches the window's clone number process the overlay even if
10312 the overlay's window property doesn't match the current window.
10313
d68443dc
MR
10314 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10315 (Fwindow_hchild): Rename to Fwindow_left_child.
10316 (Fwindow_next): Rename to Fwindow_next_sibling.
10317 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10318 (resize_window_check): Rename to window_resize_check.
10319 (resize_window_apply): Rename to window_resize_apply.
10320 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10321 (Fdelete_other_windows_internal, resize_frame_windows)
10322 (Fsplit_window_internal, Fdelete_window_internal)
10323 (grow_mini_window, shrink_mini_window)
10324 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10325
c7e73be5
JD
103262011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10327
10328 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10329 (emacs_fixed_set_min_size): Remove.
10330 (emacs_fixed_new): Take frame as argument.
10331
10332 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10333 (_EmacsFixedPrivate): Remove minwidth/height.
10334 Add struct frame *f.
10335 (emacs_fixed_init): Initialize priv->f.
10336 (get_parent_class, emacs_fixed_set_min_size): Remove.
10337 (emacs_fixed_new): Set priv->f to argument.
10338 (emacs_fixed_get_preferred_width)
10339 (emacs_fixed_get_preferred_height): Use min_width/height from
10340 frames size_hint to set minimum and natural (Bug#8919).
10341 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10342 and use min_width/height from frames size_hint to set
10343 min_width/height (Bug#8919).
10344
10345 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10346 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10347 Fix indentation.
c7e73be5 10348
cf99dcf8
EZ
103492011-06-26 Eli Zaretskii <eliz@gnu.org>
10350
10351 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10352 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10353 called at ZV.
10354
029529ac
CY
103552011-06-26 Chong Yidong <cyd@stupidchicken.com>
10356
10357 * process.c (wait_reading_process_output): Bypass select if
10358 waiting for a cell while ignoring keyboard input, and input is
10359 pending. Suggested by Jan Djärv (Bug#8869).
10360
7a7ef429
PE
103612011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10362
10363 Use gnulib's dup2 module instead of rolling our own.
10364 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10365
11fdef7d 103662011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10367
10368 * dispnew.c (scrolling_window): Before scrolling, turn off a
10369 mouse-highlight in the window being scrolled.
10370
cd3520a4
JB
103712011-06-24 Juanma Barranquero <lekktu@gmail.com>
10372
10373 Move DEFSYM to lisp.h and use everywhere.
10374
10375 * character.h (DEFSYM): Move declaration...
10376 * lisp.h (DEFSYM): ...here.
10377
10378 * gnutls.c:
10379 * minibuf.c:
10380 * w32menu.c:
10381 * w32proc.c:
10382 * w32select.c: Don't include character.h.
10383
10384 * alloc.c (syms_of_alloc):
10385 * buffer.c (syms_of_buffer):
10386 * bytecode.c (syms_of_bytecode):
10387 * callint.c (syms_of_callint):
10388 * casefiddle.c (syms_of_casefiddle):
10389 * casetab.c (init_casetab_once):
10390 * category.c (init_category_once, syms_of_category):
10391 * ccl.c (syms_of_ccl):
10392 * cmds.c (syms_of_cmds):
10393 * composite.c (syms_of_composite):
10394 * dbusbind.c (syms_of_dbusbind):
10395 * dired.c (syms_of_dired):
10396 * dispnew.c (syms_of_display):
10397 * doc.c (syms_of_doc):
10398 * editfns.c (syms_of_editfns):
10399 * emacs.c (syms_of_emacs):
10400 * eval.c (syms_of_eval):
10401 * fileio.c (syms_of_fileio):
10402 * fns.c (syms_of_fns):
10403 * frame.c (syms_of_frame):
10404 * fringe.c (syms_of_fringe):
10405 * insdel.c (syms_of_insdel):
10406 * keymap.c (syms_of_keymap):
10407 * lread.c (init_obarray, syms_of_lread):
10408 * macros.c (syms_of_macros):
10409 * msdos.c (syms_of_msdos):
10410 * print.c (syms_of_print):
10411 * process.c (syms_of_process):
10412 * search.c (syms_of_search):
10413 * sound.c (syms_of_sound):
10414 * syntax.c (init_syntax_once, syms_of_syntax):
10415 * terminal.c (syms_of_terminal):
10416 * textprop.c (syms_of_textprop):
10417 * undo.c (syms_of_undo):
10418 * w32.c (globals_of_w32):
10419 * window.c (syms_of_window):
10420 * xdisp.c (syms_of_xdisp):
10421 * xfaces.c (syms_of_xfaces):
10422 * xfns.c (syms_of_xfns):
10423 * xmenu.c (syms_of_xmenu):
10424 * xsettings.c (syms_of_xsettings):
10425 * xterm.c (syms_of_xterm): Use DEFSYM.
10426
4228cf16
TZ
104272011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10428
cd3520a4 10429 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10430
7fcccf1e
PE
104312011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10432
7efb4e0e
PE
10433 Integer and buffer overflow fixes (Bug#8873).
10434
ff5844ad
PE
10435 * print.c (printchar, strout): Check for string overflow.
10436 (PRINTPREPARE, printchar, strout):
10437 Don't set size unless allocation succeeds.
10438
90532f02
PE
10439 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10440 for sizes. Check for string overflow more accurately.
10441 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10442
6d84508d
PE
10443 * macros.c: Integer and buffer overflow fixes.
10444 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10445 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10446 Use ptrdiff_t, not int, for sizes.
10447 Don't increment bufsize until after realloc succeeds.
10448 Check for size-calculation overflow.
10449 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10450
437b2cb4
PE
10451 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10452
8b9ac8b4
PE
10453 * lread.c: Integer overflow fixes.
10454 (read_integer): Radix is now EMACS_INT, not int,
10455 to improve quality of diagnostics for out-of-range radices.
10456 Calculate buffer size correctly for out-of-range radices.
10457 (read1): Check for integer overflow in radices, and in
10458 read-circle numbers.
82cb60d3
PE
10459 (read_escape): Avoid int overflow.
10460 (Fload, openp, read_buffer_size, read1)
10461 (substitute_object_recurse, read_vector, read_list, map_obarray):
10462 Use ptrdiff_t, not int, for sizes.
10463 (read1): Use EMACS_INT, not int, for sizes.
20270765 10464 Check for size overflow.
8b9ac8b4 10465
7fcccf1e
PE
10466 * image.c (cache_image): Check for size arithmetic overflow.
10467
bfbbd7e7
PE
10468 * lread.c: Integer overflow issues.
10469 (saved_doc_string_size, saved_doc_string_length)
10470 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10471 Now ptrdiff_t, not int.
10472 (read1): Don't assume doc string length fits in int. Check for
10473 out-of-range doc string lengths.
10474 (read_list): Don't assume file position fits in int.
39019e54 10475 (read_escape): Check for hex character overflow.
bfbbd7e7 10476
4e323265
LL
104772011-06-22 Leo Liu <sdl.web@gmail.com>
10478
10479 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10480 Move to minibuffer.el.
10481
85fece3e
PE
104822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10483
20b84ce9 10484 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10485 The following patches are for when GLYPH_DEBUG && !XASSERT.
10486 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10487 * dispnew.c (flush_stdout):
10488 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10489 Mark as externally visible.
10490 * dispnew.c (check_window_matrix_pointers): Now static.
10491 * dispnew.c (window_to_frame_vpos):
10492 * xfns.c (unwind_create_frame):
10493 * xterm.c (x_check_font): Remove unused local.
10494 * scroll.c (CHECK_BOUNDS):
10495 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10496 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10497 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10498 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10499 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10500 Now static.
10501 (debug_method_add): Use va_list and vsprintf rather than relying
10502 on undefined behavior with wrong number of arguments.
10503 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10504 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10505 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10506 since we're not interested in debugging glyphs with old libraries.
10507 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10508 GCC 4.6.0's static checking.
10509
0766b489
PE
105102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10511
31fd4b32
PE
10512 Integer overflow and signedness fixes (Bug#8873).
10513 A few related buffer overrun fixes, too.
10514
b79e8648
PE
10515 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10516
0766b489
PE
10517 * dispextern.h (struct face.stipple):
10518 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10519 (x_bitmap_mask, x_allocate_bitmap_record)
10520 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10521 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10522 (x_create_bitmap_from_xpm_data):
10523 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10524 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10525 (.bitmaps_last):
10526 * xfaces.c (load_pixmap):
10527 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10528 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10529 (.bitmaps_last, struct x_output.icon_bitmap):
10530 Use ptrdiff_t, not int, for bitmap indexes.
10531 (x_allocate_bitmap_record): Check for size overflow.
10532 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10533
b081724f
PE
10534 Use ptrdiff_t, not int, for overlay counts.
10535 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10536 * editfns.c (overlays_around, get_pos_property):
10537 * textprop.c (get_char_property_and_overlay):
10538 * xdisp.c (next_overlay_change, note_mouse_highlight):
10539 * xfaces.c (face_at_buffer_position):
21514da7
PE
10540 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10541 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10542 (Fnext_overlay_change, Fprevious_overlay_change)
10543 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10544 Use ptrdiff_t, not int, for sizes.
21514da7 10545 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10546
3de73e5e
PE
10547 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10548
2606c57b
PE
10549 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10550 (x_session_initialize): Do not assume string length fits in int.
10551
aaafe47a
PE
10552 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10553 This is unlikely, but can occur if DPI is outlandish.
10554
2674ddc8 10555 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10556 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10557
28154962
PE
10558 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10559 * xrdb.c (magic_file_p, search_magic_path):
10560 Omit last arg SUFFIX; it was always 0. All callers changed.
10561 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10562
7de51af5
PE
10563 * xfont.c (xfont_match): Avoid need for strlen.
10564
25ed6cc3
PE
10565 * xfns.c: Don't assume strlen fits in int.
10566 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10567
4eab31dd
PE
10568 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10569 not unsigned long, as we prefer signed integers. All callers changed.
10570 Detect integer overflow in repeat count.
10571 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10572 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10573
171e2a58
PE
10574 * termcap.c: Don't assume sizes fit in int and never overflow.
10575 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10576 (gobble_line): Check for size-calculation overflow.
10577
ad39faca 10578 * minibuf.c (Fread_buffer):
6e5bb2dc 10579 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10580 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10581 Don't assume string length fits in int.
10582
52c61c22 10583 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10584 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10585
b5b8c9e5
PE
10586 * font.c: Don't assume string length fits in int.
10587 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10588 Use ptrdiff_t, not int.
ccd6111c
PE
10589 (font_intern_prop): Don't assume string length fits in int.
10590 Don't assume integer property fits in fixnum.
10591 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10592
882f0d81 10593 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10594 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10595 Reformulate so as not to need the command string.
10596 Invoke gzip -cd rather than gunzip, as it's more portable.
10597 (lock_info_type, lock_file_1, lock_file):
10598 Don't assume pid_t and time_t fit in unsigned long.
10599 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10600 (current_lock_owner): Prefer signed type for sizes.
10601 Use memcpy, not strncpy, where memcpy is what is really wanted.
10602 Don't assume (via atoi) that time_t and pid_t fit in int.
10603 Check for time_t and/or pid_t out of range, e.g., via a network share.
10604 Don't alloca where an auto var works fine.
10605
93f4cf88
PE
10606 * fileio.c: Fix some integer overflow issues.
10607 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10608 Don't assume string length fits in int.
10609 (directory_file_name): Don't assume string length fits in long.
10610 (make_temp_name): Don't assume pid fits in int, or that its print
10611 length is less than 20.
10612
f3e92b69
PE
10613 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10614
1bfdaf10
PE
10615 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10616
35016e9a
PE
10617 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10618
3d1e65a1
PE
10619 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10620 We prefer signed integers, even for size calculations.
10621
0b963a93
PE
10622 * emacs.c: Don't assume string length fits in 'int'.
10623 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10624 (main): Don't invoke strlen when not needed.
10625
573f4b54
PE
10626 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10627 (XD_DEBUG_MESSAGE): Don't waste a byte.
10628
989f33ba
PE
10629 * callproc.c (getenv_internal_1, getenv_internal)
10630 (Fgetenv_internal):
965d34eb
PE
10631 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10632
e4d29b33
PE
10633 * lread.c (invalid_syntax): Omit length argument.
10634 All uses changed. This doesn't fix a bug, but it simplifies the
10635 code away from its former Hollerith-constant appearance, and it's
10636 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10637 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10638
eb49b136
PE
10639 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10640 This didn't break anything, but it didn't help either.
10641 It's confusing to put a bogus integer in a place where the actual
10642 value does not matter.
9f62aeb1 10643 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10644 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10645
15375a22
PE
10646 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10647 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10648 implementation.
b61cc01c
PE
10649 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10650 We prefer signed types, and the value cannot exceed the EMACS_INT
10651 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10652 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10653 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10654 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10655
53b2623d
PE
10656 * indent.c (sane_tab_width): New function.
10657 (current_column, scan_for_column, Findent_to, position_indentation)
10658 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10659 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10660
51cab52b 10661 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10662
f2ed8a70
PE
10663 * lisp.h (lint_assume): New macro.
10664 * composite.c (composition_gstring_put_cache):
10665 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10666
abe80cc6
PE
10667 * editfns.c, insdel.c:
10668 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10669
b02c740e
PE
10670 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10671
ebc96716
PE
10672 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10673
b4e50fa0 10674 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10675 Use much-faster test for byte-length change.
311d5d7c 10676 Don't assume string byte-length fits in 'int'.
a4cf38e4 10677 Check that character arg fits in 'int'.
85461888 10678 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10679
c0c1ee9f
PE
10680 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10681
a498d7f4
PE
10682 * fns.c (concat): Catch string overflow earlier.
10683 Do not rely on integer wraparound.
10684
51cab52b
PE
10685 * dispextern.h (struct it.overlay_strings_charpos)
10686 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10687 * xdisp.c (forward_to_next_line_start)
10688 (back_to_previous_visible_line_start)
10689 (reseat_at_next_visible_line_start, next_element_from_buffer):
10690 Don't arbitrarily truncate the value of 'selective' to int.
10691
76031fad
PE
10692 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10693
5eb55db9
PE
10694 * composite.c: Don't truncate sizes to 'int'.
10695 (composition_gstring_p, composition_reseat_it)
10696 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10697 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10698 not EMACS_UINT, for indexes.
5eb55db9 10699
0703a717
PE
10700 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10701
d6202519
PE
10702 * buffer.c: Include <verify.h>.
10703 (struct sortvec.priority, struct sortstr.priority):
8961a454 10704 Now EMACS_INT, not int.
c20998a7 10705 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10706 (struct sortstr.size, record_overlay_string)
10707 (struct sortstrlist.size, struct sortlist.used):
10708 Don't truncate size to int.
10709 (record_overlay_string): Check for size-calculation overflow.
d6202519 10710 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10711
d5a19415
JM
107122011-06-22 Jim Meyering <meyering@redhat.com>
10713
029529ac 10714 Don't leak an XBM-image-sized buffer
d5a19415
JM
10715 * image.c (xbm_load): Free the image buffer after using it.
10716
a9041e6c
PE
107172011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10718
10719 Port to Sun C.
10720 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10721 that Sun C diagnosed.
10722 * fns.c (secure_hash): Fix pointer signedness issue.
10723 * intervals.c (static_offset_intervals): New function.
10724 (offset_intervals): Use it.
10725
7f3f739f
LL
107262011-06-21 Leo Liu <sdl.web@gmail.com>
10727
10728 * deps.mk (fns.o):
10729 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10730 sha512.h.
10731
10732 * fns.c (secure_hash): Rename from crypto_hash_function and change
10733 the first arg to accept symbols.
5b66d427 10734 (Fsecure_hash): New primitive.
7f3f739f
LL
10735 (syms_of_fns): New symbols.
10736
76147d94
DD
107372011-06-20 Deniz Dogan <deniz@dogan.se>
10738
10739 * process.c (Fset_process_buffer): Clarify return value in
10740 docstring.
10741
7d7d0045
CY
107422011-06-18 Chong Yidong <cyd@stupidchicken.com>
10743
10744 * dispnew.c (add_window_display_history): Use BVAR.
10745
10746 * xdisp.c (debug_method_add): Use BVAR.
10747 (check_window_end, dump_glyph_matrix, dump_glyph)
10748 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10749
10750 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10751 Likewise.
10752
10753 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10754 check till after the cache is created in init_frame_faces.
10755
ff2bc410
SM
107562011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10757
10758 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10759
28177add
PE
107602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10761
dd3482fe
PE
10762 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10763 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10764 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10765
393d71f3 10766 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10767 * fileio.c (Finsert_file_contents):
10768 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10769 Remove the old (too-loose) buffer overflow checks.
10770 They weren't needed, since make_gap checks for buffer overflow.
10771 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10772 The old code merely checked for Emacs fixnum overflow, and relied
10773 on undefined (wraparound) behavior. The new code avoids undefined
10774 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10775
2e6813b0 10776 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10777 Tune. Don't use wider integers than needed. Don't use alloca.
10778 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10779
599a9e4f
PE
10780 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10781
99561444
PE
10782 * insdel.c, lisp.h (buffer_overflow): New function.
10783 (insert_from_buffer_1, replace_range, replace_range_2):
10784 * insdel.c (make_gap_larger):
10785 * editfns.c (Finsert_char):
10786 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10787
28177add
PE
10788 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10789
e69dafad
PE
107902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10791
4baa020d 10792 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10793
b1c46f02
PE
10794 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10795 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10796
e69dafad
PE
10797 * fileio.c: Don't assume EMACS_INT fits in off_t.
10798 (emacs_lseek): New static function.
10799 (Finsert_file_contents, Fwrite_region): Use it.
10800 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10801
566684ea
PE
10802 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10803
e6966cd6
PE
10804 * fns.c: Don't overflow int when computing a list length.
10805 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10806 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10807 truncation on 64-bit hosts. Check for QUIT every
10808 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10809 faster and is responsive enough.
10810 (Flength): Report an error instead of overflowing an integer.
10811 (Fsafe_length): Return a float if the value is not representable
10812 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10813 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10814 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10815
dd0b0efb
PE
10816 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10817 (header_size, word_size): New constants.
10818 (allocate_vectorlike): Don't check size overflow here.
10819 (allocate_vector): Check it here instead, since this is the only
10820 caller of allocate_vectorlike that could cause overflow.
10821 Check that the new vector's length is representable as a fixnum.
10822
86fe5cfe
PE
10823 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10824 The previous code was bogus. For example, next_almost_prime (32)
10825 returned 39, which is undesirable as it is a multiple of 3; and
10826 next_almost_prime (24) returned 25, which is a multiple of 5 so
10827 why was the code bothering to check for multiples of 7?
10828
80e88859
PE
10829 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10830
4a2f0ad6
PE
10831 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10832
f66c7cf8
PE
10833 Variadic C functions now count arguments with ptrdiff_t.
10834 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10835 Back then I didn't know that the Emacs coding style prefers signed int.
10836 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10837 were being counted with int, which may truncate counts on 64-bit
10838 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10839 * lisp.h (struct Lisp_Subr.function.aMANY)
10840 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10841 Arg counts are now ptrdiff_t, not size_t.
10842 All variadic functions and their callers changed accordingly.
10843 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10844 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10845 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10846 * callint.c (Fcall_interactively): Check arg count for overflow,
10847 to avoid potential buffer overrun. Use signed char, not 'int',
10848 for 'varies' array, so that we needn't bother to check its size
10849 calculation for overflow.
10850 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10851 * eval.c (apply_lambda):
10852 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10853 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10854 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10855
a1759b76
PE
10856 * callint.c (Fcall_interactively): Don't use index var as event count.
10857
d96be9fc
PE
10858 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10859 * mem-limits.h (SIZE): Remove; no longer used.
10860
a690a978 10861 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10862
578c21e6
PE
10863 Remove unnecessary casts.
10864 * xterm.c (x_term_init):
10865 * xfns.c (x_set_border_pixel):
10866 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10867 These aren't needed now that we assume ANSI C.
10868
96f53c6c
PE
10869 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10870 It's more likely to cause problems (due to unsigned overflow)
10871 than to cure them.
10872
83c77d31
PE
10873 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10874
ee2079f1
PE
10875 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10876
6da65536
PE
10877 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10878
7147c4a4
PE
10879 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10880
193e32d9
PE
10881 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10882
e5533da6
PE
10883 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10884
9910e595
PE
10885 GLYPH_CODE_FACE returns EMACS_INT, not int.
10886 * dispextern.h (merge_faces):
10887 * xfaces.c (merge_faces):
01103c44
PE
10888 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10889 Don't assume EMACS_INT fits in int.
9910e595 10890
2638320e
PE
10891 * character.h (CHAR_VALID_P): Remove unused parameter.
10892 * fontset.c, lisp.h, xdisp.c: All uses changed.
10893
045eb8d9
PE
10894 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10895
c1f134b5
PE
10896 * fns.c (concat): Minor tuning based on overflow analysis.
10897 This doesn't fix any bugs. Use int to hold character, instead
10898 of constantly refetching from Emacs object. Use XFASTINT, not
10899 XINT, for value known to be a character. Don't bother comparing
10900 a single byte to 0400, as it's always less.
10901
395fcb93 10902 * floatfns.c (Fexpt):
327eeec8
PE
10903 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10904
abbd3d23
PE
10905 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10906 for characters.
10907
684a03ef
PE
10908 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10909
0fed43f3
PE
10910 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10911 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10912 incorrectly succeed when S was a string, because 4294967386 was
10913 truncated before it was used.
10914
8fd02eb7
PE
10915 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10916 Otherwise, an out-of-range integer could cause undefined behavior
10917 on a 64-bit host.
10918
f8c86b69
PE
10919 * composite.c: Use int, not EMACS_INT, for characters.
10920 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10921 EMACS_INT, for values that are known to be in character range.
10922 This doesn't fix any bugs but is the usual style inside Emacs and
10923 may generate better code on 32-bit machines.
10924
34206dd2
PE
10925 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10926 This is for reasons similar to the recent CHAR_STRING fix.
10927 * charset.c (Fencode_char): Check that character arg is actually
10928 a character. Pass an int to ENCODE_CHAR.
10929 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10930 wider than 'int', as a compile-time check to prevent future regressions
10931 in this area.
10932
c5958d4c 10933 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10934
10935 Make sure a 64-bit char is never passed to CHAR_STRING.
10936 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10937 by silently ignoring the top 32 bits, allowing some values
10938 that were far too large to be valid characters.
10939 * character.h: Include <verify.h>.
10940 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10941 arguments are no wider than unsigned, as a compile-time check
10942 to prevent future regressions in this area.
10943 * data.c (Faset):
01103c44 10944 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10945 (Fsubst_char_in_region):
10946 * fns.c (concat):
10947 * xdisp.c (decode_mode_spec_coding):
10948 Adjust to CHAR_STRING's new requirement.
10949 * editfns.c (Finsert_char, Fsubst_char_in_region):
10950 * fns.c (concat): Check that character args are actually
10951 characters. Without this test, these functions did the wrong
10952 thing with wildly out-of-range values on 64-bit hosts.
10953
d37ca623
PE
10954 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10955 These casts should not be needed on 32-bit hosts, either.
10956 * keyboard.c (read_char):
10957 * lread.c (Fload): Remove casts to unsigned.
10958
ea204efb
PE
10959 * lisp.h (UNSIGNED_CMP): New macro.
10960 This fixes comparison bugs on 64-bit hosts.
10961 (ASCII_CHAR_P): Use it.
10962 * casefiddle.c (casify_object):
01103c44 10963 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10964 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10965 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10966 * dispextern.h (FACE_FROM_ID):
10967 * keyboard.c (read_char): Use UNSIGNED_CMP.
10968
41cb286c
PE
10969 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10970 not to EMACS_INT, to avoid GCC warning.
10971
4a1b9832
PE
10972 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10973
55daad71
PE
10974 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10975 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10976 isn't needed on 32-bit machines.
8f95c75c 10977
01103c44
PE
10978 * buffer.c (Fgenerate_new_buffer_name):
10979 Use EMACS_INT for count, not int.
0ceccced 10980 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10981
10982 * data.c (Qcompiled_function): Now static.
10983
c6f072e7
PE
10984 * window.c (window_body_lines): Now static.
10985
20ce5912
PE
10986 * image.c (gif_load): Rename local to avoid shadowing.
10987
9c4c5f81
PE
10988 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10989 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10990 * alloc.c (make_save_value): Integer argument is now of type
10991 ptrdiff_t, not int.
10992 (mark_object): Use ptrdiff_t, not int.
10993 * lisp.h (pD): New macro.
10994 * print.c (print_object): Use it.
10995
c0c5c8ae
PE
10996 * alloc.c: Use EMACS_INT, not int, to count objects.
10997 (total_conses, total_markers, total_symbols, total_vector_size)
10998 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10999 (total_free_floats, total_floats, total_free_intervals)
11000 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11001 Now EMACS_INT, not int. All uses changed.
11002 (Fgarbage_collect): Compute overall total using a double, so that
11003 integer overflow is less likely to be a problem. Check for overflow
11004 when converting back to an integer.
5a25e253
PE
11005 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11006 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11007 These were 'int' variables that could overflow on 64-bit hosts;
11008 they were never used, so remove them instead of repairing them.
211a0b2a 11009 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11010 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11011 Previously, this ceilinged at INT_MAX, but that doesn't work on
11012 64-bit machines.
e46bb31a 11013 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11014
c78baabf 11015 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11016 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11017 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11018 when a (possibly-narrower) signed value would do just as well.
11019 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11020
c9d624c6
PE
11021 * alloc.c: Catch some string size overflows that we were missing.
11022 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11023 for convenience in STRING_BYTES_MAX.
11024 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11025 The definition here is exact; the one in lisp.h was approximate.
11026 (allocate_string_data): Check for string overflow. This catches
11027 some instances we weren't catching before. Also, it catches
11028 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11029 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11030 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11031
c9d624c6
PE
11032 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11033 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11034 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11035
353032ce
PE
11036 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11037
2bccce07
PE
11038 * alloc.c (Fmake_string): Check for out-of-range init.
11039
0ac30604
SM
110402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11041
11042 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11043
c195f2de
JD
110442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11045
11046 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11047 xg_get_default_scrollbar_width.
11048
11049 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11050 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11051 (style_changed_cb): Call update_theme_scrollbar_width and call
11052 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11053 all frames (Bug#8505).
11054 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11055 Call gtk_window_set_resizable if HAVE_GTK3.
11056 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11057 and height if HAVE_GTK3 (Bug#8505).
11058 (scroll_bar_width_for_theme): New variable.
11059 (update_theme_scrollbar_width): New function.
11060 (xg_get_default_scrollbar_width): Move code to
11061 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11062 (xg_initialize): Call update_theme_scrollbar_width.
11063
11064 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11065
11066 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11067
e10ac9f1
MR
110682011-06-12 Martin Rudalics <rudalics@gmx.at>
11069
11070 * frame.c (make_frame): Call other_buffer_safely instead of
11071 other_buffer.
11072
11073 * window.c (temp_output_buffer_show): Call display_buffer with
11074 second argument Vtemp_buffer_show_specifiers and reset latter
11075 immediately after the call.
11076 (Vtemp_buffer_show_specifiers): New variable.
11077 (auto_window_vscroll_p, next_screen_context_lines)
11078 (Vscroll_preserve_screen_position): Remove leading asterisks from
11079 doc-strings.
11080
2d3c217e 110812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11082
7b7f97e8 11083 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11084 * buffer.c (Qclone_number): Remove for now, as it's unused.
11085 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11086 (record_buffer): Remove unused local.
11087 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11088 (set_frame_buffer_list): Remove; unused.
11089 * frame.h (other_visible_frames): Remove decl.
11090 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11091 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11092 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11093 if HAVE_GPM.
11094 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11095 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11096 Define only if HAVE_GPM.
11097 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11098 (update_hints_inhibit): Remove; never set. All uses removed.
11099 * widgetprv.h (emacsFrameClassRec): Remove decl.
11100 * window.c (delete_deletable_window): Now returns void, since it
11101 wasn't returning anything.
11102 (compare_window_configurations): Remove unused locals.
11103 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11104 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11105 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11106 the same widths as pointers. This follows up on the 2011-05-06 patch.
11107 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11108 * xterm.h: Likewise.
11109 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11110
1384b89e
JB
111112011-06-12 Juanma Barranquero <lekktu@gmail.com>
11112
11113 * makefile.w32-in: Update dependencies.
11114 (LISP_H): Add lib/intprops.h.
11115
1100a63c
CY
111162011-06-11 Chong Yidong <cyd@stupidchicken.com>
11117
11118 * image.c (gif_load): Add animation frame delay to the metadata.
11119 (syms_of_image): Use DEFSYM. New symbol `delay'.
11120
6198ccd0
MR
111212011-06-11 Martin Rudalics <rudalics@gmx.at>
11122
11123 * window.c (delete_deletable_window): Re-add.
11124 (Fset_window_configuration): Rewrite to handle dead buffers and
11125 consequently deletable windows.
11126 (window_tree, Fwindow_tree): Remove. Supply functionality in
11127 window.el.
11128 (compare_window_configurations): Simplify code.
11129
b6e3633c
AS
111302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11131
1ab0dee5
AS
11132 * image.c (imagemagick_load_image): Fix type mismatch.
11133 (Fimagemagick_types): Likewise.
11134
b6e3633c
AS
11135 * window.h (replace_buffer_in_windows): Declare.
11136
9397e56f
MR
111372011-06-11 Martin Rudalics <rudalics@gmx.at>
11138
11139 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11140 Qclone_number. Remove external declaration of Qdelete_window.
11141 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11142 code.
640c8776
SM
11143 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11144 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11145 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11146 buffer list implementation.
11147 (other_buffer_safely): New function.
11148 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11149 calls to replace_buffer_in_windows and
11150 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11151 if allowed.
11152 (record_buffer): Inhibit quitting and rewrite using quittable
11153 functions. Run Qbuffer_list_update_hook if allowed.
11154 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11155 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11156 Move switch-to-buffer to window.el.
9397e56f
MR
11157 (bury-buffer): Move to window.el.
11158 (Vbuffer_list_update_hook): New variable.
11159
11160 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11161 section.
11162
11163 * window.h (resize_frame_windows): Move up in code.
11164 (Fwindow_frame): Remove EXFUN.
11165 (replace_buffer_in_all_windows): Remove prototype.
11166 (replace_buffer_in_windows_safely): Add prototype.
11167
11168 * window.c: Declare Qdelete_window static again. Move down
11169 declaration of select_count.
11170 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11171 (Fother_window): Move to window.el.
11172 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11173 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11174 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11175 window.el.
11176 (replace_buffer_in_windows): Implement by calling
11177 Qreplace_buffer_in_windows.
11178 (replace_buffer_in_all_windows): Remove with some functionality
11179 moved into replace_buffer_in_windows_safely.
11180 (replace_buffer_in_windows_safely): New function.
11181 (select_window_norecord, select_frame_norecord): Move in front
11182 of run_window_configuration_change_hook. Remove now obsolete
11183 declarations.
640c8776
SM
11184 (Fset_window_buffer): Rewrite doc-string.
11185 Call Qrecord_window_buffer.
9397e56f
MR
11186 (keys_of_window): Move binding for other-window to window.el.
11187
b50691aa
CY
111882011-06-11 Chong Yidong <cyd@stupidchicken.com>
11189
11190 * dispextern.h (struct image): Replace data member, whose int_val
11191 and ptr_val fields were not used by anything, with a single
11192 lisp_val object.
11193
11194 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11195 (gif_clear_image, gif_load, imagemagick_load_image)
11196 (gs_clear_image, gs_load): Callers changed.
11197
3f754b86
PE
111982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11199
cca69397
PE
11200 * buffer.h: Include <time.h>, for time_t.
11201 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11202
109e28d0
PE
11203 Fix minor problems found by static checking.
11204
60737f02
PE
11205 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11206
4b66faf3
PE
11207 Make identifiers static if they are not used in other modules.
11208 * data.c (Qcompiled_function, Qframe, Qvector):
11209 * image.c (QimageMagick, Qsvg):
11210 * minibuf.c (Qmetadata):
11211 * window.c (resize_window_check, resize_root_window): Now static.
11212 * window.h (resize_window_check, resize_root_window): Remove decls.
11213
109e28d0
PE
11214 * window.c (window_deletion_count, delete_deletable_window):
11215 Remove; unused.
46a4ce9e
PE
11216 (window_body_lines): Now static.
11217 (Fdelete_other_windows_internal): Mark vars as initialized.
11218 Make sure 'resize_failed' is initialized.
11219 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11220 (resize_window_apply): Remove unused local.
11221 * window.h (delete_deletable_window): Remove decl.
11222
109e28d0 11223 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11224 (imagemagick_load_image): Fix pointer signedness problem by changing
11225 last arg from unsigned char * to char *. All uses changed.
11226 Also, fix a local for similar reasons.
11227 Remove unused locals. Remove locals to avoid shadowing.
11228 (fn_rsvg_handle_free): Remove; unused.
11229 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11230 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11231
3f754b86
PE
11232 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11233
2547adb1
CY
112342011-06-10 Chong Yidong <cyd@stupidchicken.com>
11235
11236 * image.c (gif_load): Fix omitted cast error introduced by
11237 2011-06-06 change.
11238
2c8e37d4
MR
112392011-06-10 Martin Rudalics <rudalics@gmx.at>
11240
11241 * window.h (resize_proportionally, orig_total_lines)
11242 (orig_top_line): Remove from window structure.
11243 (set_window_height, set_window_width, change_window_heights)
11244 (Fdelete_window): Remove prototypes.
11245 (resize_frame_windows): Remove duplicate declaration.
11246
440a42e3
EZ
112472011-06-10 Eli Zaretskii <eliz@gnu.org>
11248
11249 * window.h (resize_frame_windows, resize_window_check)
11250 (delete_deletable_window, resize_root_window)
11251 (resize_frame_windows): Declare prototypes.
11252
11253 * window.c (resize_window_apply): Make definition be "static" to
11254 match the prototype.
11255
562dd5e9
MR
112562011-06-10 Martin Rudalics <rudalics@gmx.at>
11257
11258 * window.c: Remove declarations of Qwindow_size_fixed,
11259 window_min_size_1, window_min_size_2, window_min_size,
11260 size_window, window_fixed_size_p, enlarge_window, delete_window.
11261 Remove static from declaration of Qdelete_window, it's
11262 temporarily needed by Fbury_buffer.
11263 (replace_window): Don't assign orig_top_line and
11264 orig_total_lines.
11265 (Fdelete_window, delete_window): Remove. Window deletion is
11266 handled by window.el.
640c8776
SM
11267 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11268 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11269 (Fdelete_other_windows): Remove. Deleting other windows is
11270 handled by window.el.
11271 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11272 handled in window.el.
11273 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11274 Window minimum sizes are handled in window.el.
11275 (shrink_windows, size_window, set_window_height)
11276 (set_window_width, change_window_heights, window_height)
11277 (window_width, CURBEG, CURSIZE, enlarge_window)
11278 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11279 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11280 handled in window.el.
11281 (make_dummy_parent): Rename to make_parent_window and give it a
11282 second argument horflag.
11283 (make_window): Don't set resize_proportionally any more.
11284 (Fsplit_window): Remove. Windows are split in window.el.
11285 (save_restore_action, save_restore_orig_size)
11286 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11287 Resize mini windows in window.el.
11288 (grow_mini_window, shrink_mini_window): Implement by calling
11289 Qresize_root_window_vertically, resize_window_check and
11290 resize_window_apply.
640c8776
SM
11291 (saved_window, Fset_window_configuration, save_window_save):
11292 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11293 resize_proportionally.
11294 (window_min_height, window_min_width): Move to window.el.
11295 (keys_of_window): Move bindings for delete-other-windows,
11296 split-window, delete-window and enlarge-window to window.el.
11297
11298 * buffer.c: Temporarily extern Qdelete_window.
11299 (Fbury_buffer): Temporarily call Qdelete_window instead of
11300 Fdelete_window (Fbury_buffer will move to window.el soon).
11301
11302 * frame.c (set_menu_bar_lines_1): Remove code handling
11303 orig_top_line and orig_total_lines.
11304
11305 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11306 set_window_height but set heights directly.
11307 (change_frame_size_1): Use resize_frame_windows.
11308
11309 * xdisp.c (init_xdisp): Don't use set_window_height but set
11310 heights directly.
11311
640c8776
SM
11312 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11313 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11314 run_window_configuration_change_hook.
11315
11316 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11317 instead of change_window_heights and run
11318 run_window_configuration_change_hook.
11319
1a13852e
MR
113202011-06-09 Martin Rudalics <rudalics@gmx.at>
11321
11322 * window.c (replace_window): Rename second argument REPLACEMENT to
11323 NEW. New third argument SETFLAG. Rewrite.
11324 (delete_window, make_dummy_parent): Call replace_window with
11325 third argument 1.
11326 (window_list_1): Move down in code.
11327 (run_window_configuration_change_hook): Move set_buffer part
11328 before select_frame_norecord part in order to unwind correctly.
11329 Rename count1 to count.
11330 (recombine_windows, delete_deletable_window, resize_root_window)
11331 (Fdelete_other_windows_internal)
11332 (Frun_window_configuration_change_hook, make_parent_window)
11333 (resize_window_check, resize_window_apply, Fresize_window_apply)
11334 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11335 (Fdelete_window_internal, Fresize_mini_window_internal):
11336 New functions.
1a13852e
MR
11337 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11338
f3d1777e
MR
113392011-06-08 Martin Rudalics <rudalics@gmx.at>
11340
496e208e
MR
11341 * window.h (window): Add some new members to window structure -
11342 normal_lines, normal_cols, new_total, new_normal, clone_number,
11343 splits, nest, prev_buffers, next_buffers.
11344 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11345 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11346
f3d1777e
MR
11347 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11348 Remove.
496e208e
MR
11349 (make_dummy_parent): Set new members of windows structure.
11350 (make_window): Move down in code. Handle new members of window
11351 structure.
11352 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11353 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11354 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11355 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11356 (Fset_window_next_buffers, Fset_window_clone_number):
11357 New functions.
496e208e
MR
11358 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11359 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11360 Doc-string fixes.
11361 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11362 Argument WINDOW can be now internal window too.
11363 (Fwindow_use_time): Move up in code.
11364 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11365 Rewrite doc-string.
11366 (Fset_window_configuration, saved_window)
11367 (Fcurrent_window_configuration, save_window_save): Handle new
11368 members of window structure.
b9e809c2
MR
11369 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11370 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11371 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11372 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11373 Qget_mru_window, Qresize_root_window,
11374 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11375 Qauto_buffer_name; staticpro them.
f3d1777e 11376
abde8f8c
MR
113772011-06-07 Martin Rudalics <rudalics@gmx.at>
11378
11379 * window.c (Fwindow_total_size, Fwindow_left_column)
11380 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11381 (Fwindow_list_1): New functions.
11382 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11383 (Fwindow_width, Fscroll_left, Fscroll_right):
11384 Use window_body_cols instead of window_box_text_cols.
11385 (delete_window, Fset_window_configuration):
11386 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11387 (delete_all_subwindows): Take a window as argument and not a
11388 structure. Rewrite.
190b47e6
MR
11389 (window_loop): Remove handling of GET_LRU_WINDOW and
11390 GET_LARGEST_WINDOW.
11391 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11392
11393 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11394 window_box_text_cols. delete_all_subwindows now takes a
11395 Lisp_Object as argument.
abde8f8c 11396
640c8776
SM
11397 * indent.c (compute_motion, Fcompute_motion):
11398 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11399
fa8a67e6
MR
11400 * frame.c (delete_frame): Call delete_all_subwindows with root
11401 window as argument.
11402
a54e3482
DC
114032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11404
11405 * fns.c (Fputhash): Document return value.
11406
60002bf5
CY
114072011-06-06 Chong Yidong <cyd@stupidchicken.com>
11408
11409 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11410
0c671da6 114112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11412
b862a52a 11413 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11414
be44ca6c
PE
11415 Check for overflow when converting integer to cons and back.
11416 * charset.c (Fdefine_charset_internal, Fdecode_char):
11417 Use cons_to_unsigned to catch overflow.
11418 (Fencode_char): Use INTEGER_TO_CONS.
11419 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11420 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11421 * data.c (long_to_cons, cons_to_long): Remove.
11422 (cons_to_unsigned, cons_to_signed): New functions.
11423 These signal an error for invalid or out-of-range values.
11424 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11425 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11426 * font.c (Ffont_variation_glyphs):
11427 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11428 * lisp.h: Include <intprops.h>.
11429 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11430 (cons_to_signed, cons_to_unsigned): New decls.
11431 (long_to_cons, cons_to_long): Remove decls.
11432 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11433 (Fprimitive_undo): Use CONS_TO_INTEGER.
11434 * xfns.c (Fx_window_property): Likewise.
11435 * xselect.c: Include <limits.h>.
11436 (x_own_selection, selection_data_to_lisp_data):
11437 Use INTEGER_TO_CONS.
11438 (x_handle_selection_request, x_handle_selection_clear)
11439 (x_get_foreign_selection, Fx_disown_selection_internal)
11440 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11441 (lisp_data_to_selection_data): Use cons_to_unsigned.
11442 (x_fill_property_data): Use cons_to_signed.
11443 Report values out of range.
11444
d1f3d2af
PE
11445 Check for buffer and string overflow more precisely.
11446 * buffer.h (BUF_BYTES_MAX): New macro.
11447 * lisp.h (STRING_BYTES_MAX): New macro.
11448 * alloc.c (Fmake_string):
11449 * character.c (string_escape_byte8):
11450 * coding.c (coding_alloc_by_realloc):
11451 * doprnt.c (doprnt):
11452 * editfns.c (Fformat):
11453 * eval.c (verror):
11454 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11455 since they may not be the same number.
11456 * editfns.c (Finsert_char):
11457 * fileio.c (Finsert_file_contents):
11458 Likewise for BUF_BYTES_MAX.
11459
dd52fcea
PE
11460 * image.c: Use ptrdiff_t, not int, for sizes.
11461 (slurp_file): Switch from int to ptrdiff_t.
11462 All uses changed.
11463 (slurp_file): Check that file size fits in both size_t (for
11464 malloc) and ptrdiff_t (for sanity and safety).
11465
7f9bbdbb
PE
11466 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11467 if b->modtime has its maximal value.
11468
dfe18f82
PE
11469 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11470
84acfcf0
PE
11471 Don't assume time_t can fit into int.
11472 * buffer.h (struct buffer.modtime): Now time_t, not int.
11473 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11474 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11475
ccd9a01a
PE
11476 Minor fixes for signed vs unsigned integers.
11477 * character.h (MAYBE_UNIFY_CHAR):
11478 * charset.c (maybe_unify_char):
11479 * keyboard.c (read_char, reorder_modifiers):
11480 XINT -> XFASTINT, since the integer must be nonnegative.
11481 * ftfont.c (ftfont_spec_pattern):
11482 * keymap.c (access_keymap, silly_event_symbol_error):
11483 XUINT -> XFASTINT, since the integer must be nonnegative.
11484 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11485 since it makes no difference and we prefer signed.
11486 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11487 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11488 nonnegative.
11489
d6d100dd
SM
114902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11491
11492 * window.h (Fwindow_frame): Declare.
11493
2b6148e4
PE
114942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11495
11496 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11497 (SPARE_MEMORY): Always define.
11498 (LARGE_REQUEST): Remove.
11499 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11500
f230ecc9
MR
115012011-06-06 Martin Rudalics <rudalics@gmx.at>
11502
727e958e
MR
11503 * lisp.h: Move EXFUNS for Fframe_root_window,
11504 Fframe_first_window and Fset_frame_selected_window to window.h.
11505
11506 * window.h: Move EXFUNS for Fframe_root_window,
11507 Fframe_first_window and Fset_frame_selected_window here from
11508 lisp.h.
11509
11510 * frame.c (Fwindow_frame, Fframe_first_window)
11511 (Fframe_root_window, Fframe_selected_window)
11512 (Fset_frame_selected_window): Move to window.c.
11513 (Factive_minibuffer_window): Move to minibuf.c.
11514 (Fother_visible_frames_p): New function.
11515
11516 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11517
f230ecc9
MR
11518 * window.c (decode_window, decode_any_window): Move up in code.
11519 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11520 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11521 (Fwindow_buffer): Move up and rewrite doc-string.
11522 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11523 (Fwindow_prev): New functions.
727e958e
MR
11524 (Fwindow_frame): Move here from frame.c. Accept any window as
11525 argument.
11526 (Fframe_root_window, Fframe_first_window)
11527 (Fframe_selected_window): Move here from frame.c. Accept frame
11528 or arbitrary window as argument. Update doc-strings.
11529 (Fminibuffer_window): Move up in code.
11530 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11531 (Fset_frame_selected_window): Move here from frame.c.
11532 Marginal rewrite.
727e958e
MR
11533 (Fselected_window, select_window, Fselect_window): Move up in
11534 code. Minor doc-string fixes.
f230ecc9 11535
4d09bcf6
PE
115362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11537
11538 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11539 Do not assume that spare memory exists; that assumption is valid
11540 only if SYSTEM_MALLOC.
11541 (LARGE_REQUEST): New macro, so that the issue of large requests
11542 is separated from the issue of spare memory.
11543
810928a2
AS
115442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11545
172418ad
AS
11546 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11547 format. (Bug#8806)
11548
43f862f7
AS
11549 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11550
810928a2
AS
11551 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11552 before statements.
11553
a059fe24
JD
115542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11555
11556 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11557
11558 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11559
11560 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11561 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11562
989bf368
JB
115632011-06-05 Juanma Barranquero <lekktu@gmail.com>
11564
11565 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11566
4b80f674
CY
115672011-06-04 Chong Yidong <cyd@stupidchicken.com>
11568
11569 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11570 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11571 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11572 New error handlers.
4b80f674
CY
11573 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11574 Obey Vx_select_enable_clipboard_manager. Catch errors in
11575 x_clipboard_manager_save (Bug#8779).
11576 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11577 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11578
99a33b77 115792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11580
11581 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11582
99a33b77 115832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11584
11585 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11586 in the current matrix if keep_current_p is non-zero.
11587
8264569d
EZ
115882011-06-04 Eli Zaretskii <eliz@gnu.org>
11589
11590 * bidi.c (bidi_level_of_next_char): Fix last change.
11591
57f97249
EZ
115922011-06-03 Eli Zaretskii <eliz@gnu.org>
11593
fec2107c 11594 Support bidi reordering of text covered by display properties.
57f97249 11595
fec2107c
EZ
11596 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11597 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11598 (bidi_cache_search, bidi_cache_iterator_state)
11599 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11600 (bidi_level_of_next_char, bidi_move_to_visually_next):
11601 Support character positions inside a run of characters covered by a
fec2107c
EZ
11602 display string.
11603 (bidi_paragraph_init, bidi_resolve_explicit_1)
11604 (bidi_level_of_next_char): Call bidi_fetch_char and
11605 bidi_fetch_char_advance instead of FETCH_CHAR and
11606 FETCH_CHAR_ADVANCE.
11607 (bidi_init_it): Initialize new members.
11608 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11609 definitions.
11610 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11611 instead of using explicit *_CHAR codes.
d6d100dd
SM
11612 (bidi_resolve_explicit, bidi_resolve_weak):
11613 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11614 bidirectional text is supported only in multibyte buffers.
11615 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11616 it to initialize the frame_window_p member of struct bidi_it.
11617 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11618 (bidi_resolve_explicit, bidi_resolve_weak)
11619 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11620 bidi_it->nchars is non-positive.
11621 (bidi_level_of_next_char): Don't try to lookup the cache for the
11622 next/previous character if nothing is cached there yet, or if we
11623 were just reseat()'ed to a new position.
c40e2fb2 11624
0e14fe90
EZ
11625 * xdisp.c (set_cursor_from_row): Set start and stop points
11626 according to the row's direction when priming the loop that looks
11627 for the glyph on which to display cursor.
11628 (single_display_spec_intangible_p): Function deleted.
11629 (display_prop_intangible_p): Reimplement to call
11630 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11631 Accept 3 additional arguments needed by handle_display_spec.
11632 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11633 values: lists, `(when COND...)' forms, etc.
11634 (single_display_spec_string_p): Support property values that are
11635 lists with the argument STRING its top-level element.
11636 (display_prop_string_p): Fix the condition for processing a
11637 property that is a list to be consistent with handle_display_spec.
fec2107c 11638 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11639 last portion of handle_display_prop.
11640 (compute_display_string_pos): Accept additional argument
11641 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11642 value of a `display' property is a "replacing spec".
11643 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11644 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11645 the display property, but just return a value indicating whether
11646 the display property will replace the characters it covers.
11647 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11648 frame_window_p members of struct bidi_it.
d6d100dd
SM
11649 (compute_display_string_pos, compute_display_string_end):
11650 New functions.
fec2107c
EZ
11651 (push_it): Accept second argument POSITION, where pop_it should
11652 jump to continue iteration.
11653 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11654
fec2107c
EZ
11655 * keyboard.c (adjust_point_for_property): Adjust the call to
11656 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11657
11658 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11659 (bidi_init_it): Update prototypes.
11660 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11661 (compute_display_string_pos, compute_display_string_end):
11662 Declare prototypes.
fec2107c
EZ
11663 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11664 EMACS_INT.
fc6f18ce 11665
40087514 116662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11667
57f53182
PE
11668 Malloc failure behavior now depends on size of allocation.
11669 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11670 * lisp.h: Change signatures accordingly.
11671 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11672 All callers changed. (Bug#8762)
11673
11674 * gnutls.c: Use Emacs's memory allocators.
11675 Without this change, the gnutls library would invoke malloc etc.
11676 directly, which causes problems on non-SYNC_INPUT hosts, and which
11677 runs afoul of improving memory_full behavior. (Bug#8761)
11678 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11679 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11680 xfree instead of the default malloc, realloc, free.
11681 (Fgnutls_boot): No need to check for memory allocation failure,
11682 since xmalloc does that for us.
11683
ac32cd99 11684 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11685 * category.c (hash_get_category_set):
11686 * ccl.c (ccl_driver):
11687 * charset.c (Fdefine_charset_internal):
11688 * charset.h (struct charset.hash_index):
11689 * composite.c (get_composition_id, gstring_lookup_cache)
11690 (composition_gstring_put_cache):
11691 * composite.h (struct composition.hash_index):
11692 * dispextern.h (struct image.hash):
11693 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11694 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11695 (hashfn_equal, hashfn_user_defined, make_hash_table)
11696 (maybe_resize_hash_table, hash_lookup, hash_put)
11697 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11698 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11699 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11700 * image.c (make_image, search_image_cache, lookup_image)
11701 (xpm_put_color_table_h):
11702 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11703 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11704 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11705 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11706 * alloc.c (allocate_vectorlike):
11707 Check for overflow in vector size calculations.
11708 * ccl.c (ccl_driver):
11709 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11710 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11711 need to be updated by these changes.
40087514
PE
11712 * fns.c (make_hash_table, maybe_resize_hash_table):
11713 Check for integer overflow with large hash tables.
0de4bb68
PE
11714 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11715 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11716 (SXHASH_REDUCE): New macro.
11717 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11718 Use it instead of discarding useful hash info with large hash values.
11719 (sxhash_float): New function.
11720 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11721 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11722 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11723 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11724 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11725 Adjust signatures to match updated version of code.
11726 (consing_since_gc): Now EMACS_INT, since a single hash table can
11727 use more than INT_MAX bytes.
11728
698d32e2
DN
117292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11730
11731 Make it possible to build with GCC-4.6+ -O2 -flto.
11732
11733 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11734
fd6fa53f
SM
117352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11736
11737 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11738 Call minibuffer-inactive-mode.
11739
864db017
JB
117402011-05-31 Juanma Barranquero <lekktu@gmail.com>
11741
11742 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11743 Update dependencies.
11744
2ad0baf4
DN
117452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11746
11747 * data.c (init_data): Remove code for UTS, this system is not
11748 supported anymore.
11749
4fcc2638
DN
117502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11751
11752 Don't force ./temacs to start in terminal mode.
11753
11754 * frame.c (make_initial_frame): Initialize faces in all cases, not
11755 only when CANNOT_DUMP is defined.
11756 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11757
c56e0fd5
DN
117582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11759
11760 * dispnew.c (add_window_display_history): Use const for the string
11761 pointer. Remove declaration, not needed.
11762
333d54da 117632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11764
55d4c1b2 11765 Use 'inline', not 'INLINE'.
333d54da 11766 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11767 * alloc.c, fontset.c (INLINE): Remove.
11768 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11769 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11770 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11771 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11772 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11773
738db178
DN
117742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11775
11776 Make it possible to run ./temacs.
11777
11778 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11779 syms_of_callproc does the same thing. Remove test for
11780 "initialized", do it in the caller.
11781 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11782
620c53a6
SM
117832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11784
11785 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11786 (read_minibuf): Use get_minibuffer.
11787 (syms_of_minibuf): Use DEFSYM.
11788 (Qmetadata): New var.
11789 * data.c (Qbuffer): Don't make it static.
11790 (syms_of_data): Use DEFSYM.
11791
e003a292
PE
117922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11793
11794 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11795 (CCL_CODE_MIN): New macro.
11796
ed008a6d
PE
117972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11798
3687c2ef
PE
11799 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11800
ed008a6d
PE
11801 * eval.c (Qdebug): Now static.
11802 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11803 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11804 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11805
d66c4c7c
CY
118062011-05-29 Chong Yidong <cyd@stupidchicken.com>
11807
11808 * image.c: Various fixes to ImageMagick code comments.
11809 (Fimagemagick_types): Doc fix.
11810
5fbc2025
PE
118112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11812
0196f88a
PE
11813 Minor fixes prompted by GCC 4.6.0 warnings.
11814
11815 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11816
5fbc2025
PE
11817 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11818 (x_clipboard_manager_save_all): Move extern decl to ...
11819 * xterm.h: ... here, so that it can be checked for consistency.
11820
1dd3c2d9
CY
118212011-05-29 Chong Yidong <cyd@stupidchicken.com>
11822
11823 * xselect.c (x_clipboard_manager_save_frame)
11824 (x_clipboard_manager_save_all): New functions.
11825 (Fx_clipboard_manager_save): Lisp function deleted.
11826
11827 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11828 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11829
11830 * xterm.h: Update prototype.
11831
5ba6571d
WX
118322011-05-28 William Xu <william.xwl@gmail.com>
11833
11834 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11835 exiting (Bug#8239).
11836
3eaff834
JM
118372011-05-28 Jim Meyering <meyering@redhat.com>
11838
e1900994 11839 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11840 * fns.c (to_uchar): Define.
11841 (crypto_hash_function): Use it to convert some newly-signed
11842 variables to unsigned, to avoid sign-extension bugs. For example,
11843 without this change, (md5 "truc") would evaluate to
11844 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11845 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11846 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11847
0f6990a7
PE
118482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11849
11850 Integer overflow fixes.
c8a9ca5a 11851
08686060
PE
11852 * dbusbind.c: Serial number integer overflow fixes.
11853 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11854 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11855 to hold a serial number that is too large for a fixnum.
11856 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11857 Check for serial numbers out of range. Decode any serial number
59568bf0 11858 that was so large that it became a float. (Bug#8722)
08686060 11859
2d1fc3c7
PE
11860 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11861 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11862 Use XFASTINT rather than XUINT when numbers are nonnegative.
11863 (xd_append_arg, Fdbus_method_return_internal):
11864 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11865 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11866 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11867 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11868 (Bug#8722)
2d1fc3c7 11869
c8a9ca5a
PE
11870 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11871
519e1d69
PE
11872 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11873
6df6ae42 11874 ccl: Add integer overflow checks.
30569699
PE
11875 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11876 (IN_INT_RANGE): New macros.
11877 (ccl_driver): Use them to check for integer overflow when
11878 decoding a CCL program. Many of the new checks are whether XINT (x)
11879 fits in int; it doesn't always, on 64-bit hosts. The new version
11880 doesn't catch all possible integer overflows, but it's an
847044ea 11881 improvement. (Bug#8719)
30569699 11882
c11285dc
PE
11883 * alloc.c (make_event_array): Use XINT, not XUINT.
11884 There's no need for unsigned here.
11885
fdccd48e
PE
11886 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11887 This follows up to the 2011-05-06 change that substituted uintptr_t
11888 for EMACS_INT. This case wasn't caught back then.
11889
37910ab2
PE
11890 Rework Fformat to avoid integer overflow issues.
11891 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11892 now (part of C89). Include <verify.h>.
11893 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11894 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11895 (Fformat): Avoid the prepass trying to compute sizes; it was only
11896 approximate and thus did not catch overflow reliably. Instead, walk
11897 through the format just once, formatting and computing sizes as we go,
11898 checking for integer overflow at every step, and allocating a larger
11899 buffer as needed. Keep track separately whether the format is
11900 multibyte. Keep only the most-recently calculated precision, rather
11901 than them all. Record whether each argument has been converted to
11902 string. Use EMACS_INT, not int, for byte and char and arg counts.
11903 Support field widths and precisions larger than INT_MAX. Avoid
11904 sprintf's undefined behavior with conversion specifications such as %#d
11905 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11906 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11907 formatting out-of-range floating point numbers with int
9173deec 11908 formats. (Bug#8668)
37910ab2 11909
2e6578fb
PE
11910 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11911
0ae6bdee
PE
11912 * data.c: Avoid integer truncation in expressions involving floats.
11913 * data.c: Include <intprops.h>.
11914 (arith_driver): When there's an integer overflow in an expression
11915 involving floating point, convert the integers to floating point
11916 so that the resulting value does not suffer from catastrophic
11917 integer truncation. For example, on a 64-bit host (* 4
11918 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11919 Do not rely on undefined behavior after integer overflow.
11920
de883a70
PE
11921 merge count_size_as_multibyte, parse_str_to_multibyte
11922 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11923 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11924 Check for integer overflow.
11925 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11926 since it's now a duplicate of the other. This is more of
11927 a character than a buffer op, so better that it's in character.c.
11928 * fns.c, print.c: Adjust to above changes.
11929
2ff916cb
PE
119302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11931
11932 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11933
f1b54466
PE
119342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11935
fb1ac845
PE
11936 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11937 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11938 (x_clipboard_manager_save): Now static.
11939 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11940
f1b54466
PE
11941 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11942 (crypto_hash_function): Now static.
11943 Fix pointer signedness problems. Avoid unnecessary initializations.
11944
a9f737ee
CY
119452011-05-27 Chong Yidong <cyd@stupidchicken.com>
11946
11947 * termhooks.h (Vselection_alist): Make it terminal-local.
11948
11949 * terminal.c (create_terminal): Initialize it.
11950
11951 * xselect.c: Support for clipboard managers.
11952 (Vselection_alist): Move to termhooks.h as terminal-local var.
11953 (LOCAL_SELECTION): New macro.
11954 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11955 (symbol_to_x_atom): Remove gratuitous arg.
11956 (x_handle_selection_request, lisp_data_to_selection_data)
11957 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11958 (x_own_selection, x_get_local_selection, x_convert_selection):
11959 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11960 (some_frame_on_display): Delete unused function.
11961 (Fx_own_selection_internal, Fx_get_selection_internal)
11962 (Fx_disown_selection_internal, Fx_selection_owner_p)
11963 (Fx_selection_exists_p): New optional frame arg.
11964 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11965 (x_handle_selection_clear): Don't treat other terminals with the
11966 same keyboard specially. Use the terminal-local Vselection_alist.
11967 (x_clear_frame_selections): Use Frun_hook_with_args.
11968
11969 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11970
11971 * xterm.h: Add support for those atoms.
11972
e067f0c1
CY
119732011-05-26 Chong Yidong <cyd@stupidchicken.com>
11974
11975 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11976 (converted_selections, conversion_fail_tag): New global variables.
11977 (x_selection_request_lisp_error): Free the above.
11978 (x_get_local_selection): Remove unnecessary code.
11979 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11980 of converted selections stored in converted_selections.
11981 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11982 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11983 (x_convert_selection): New function.
11984 (x_handle_selection_event): Simplify.
11985 (x_get_foreign_selection): Don't ignore incoming requests while
11986 waiting for an answer; this will fail when we implement
11987 SAVE_TARGETS, and seems unnecessary anyway.
11988 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11989 (Vx_sent_selection_functions): Doc fix.
11990
0f4aebc0
LL
119912011-05-26 Leo Liu <sdl.web@gmail.com>
11992
11993 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11994
e61124cd
YM
119952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11996
11997 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11998
11999 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12000 for fringe update if it has periodic bitmap.
ac389d0c 12001 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12002 and fringe_bitmap_periodic_p.
12003
12004 * fringe.c (get_fringe_bitmap_data): New function.
12005 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12006 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12007 row. Mark glyph row for fringe update if periodicity changed.
12008
12009 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12010 for fringe update unless it has periodic bitmap.
12011
f16d9837
KH
120122011-05-25 Kenichi Handa <handa@m17n.org>
12013
12014 * xdisp.c (get_next_display_element): Set correct it->face_id for
12015 a static composition.
12016
e1b90ef6
LL
120172011-05-24 Leo Liu <sdl.web@gmail.com>
12018
12019 * deps.mk (fns.o):
12020 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12021
12022 * fns.c (crypto_hash_function, Fsha1): New function.
12023 (Fmd5): Use crypto_hash_function.
12024 (syms_of_fns): Add Ssha1.
12025
7400048f
PE
120262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12027
12028 * gnutls.c: Remove unused macros.
12029 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12030 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12031 Remove macros that are defined and never used.
12032 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12033
abb71cf4
CY
120342011-05-22 Chong Yidong <cyd@stupidchicken.com>
12035
12036 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12037 (Fx_get_selection_internal): Minor cleanup.
12038 (Fx_own_selection_internal): Rename arguments for consistency with
12039 select.el.
12040
6307db39
PE
120412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12042
12043 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12044
f3d4e0a4
CY
120452011-05-22 Chong Yidong <cyd@stupidchicken.com>
12046
12047 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12048
4d8ade89
YM
120492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12050
12051 * dispnew.c (scrolling_window): Don't exclude the case that the
12052 last enabled row in the desired matrix touches the bottom boundary.
12053
32078c8d
GM
120542011-05-21 Glenn Morris <rgm@gnu.org>
12055
12056 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12057 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12058 and add some more files.
32078c8d 12059
7285dc67
EZ
120602011-05-20 Eli Zaretskii <eliz@gnu.org>
12061
12062 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12063 report_file_error introduced by the change from 2011-05-07.
12064
89d1bd22
PE
120652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12066
12067 * systime.h (Time): Define only if emacs is defined.
12068 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12069 where the include path doesn't have X11/X.h by default. See
12070 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12071
cd394be1 120722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12073
12074 * composite.c (find_automatic_composition): Fix previous change.
12075
b9704ad9
GM
120762011-05-20 Glenn Morris <rgm@gnu.org>
12077
12078 * lisp.mk: New file, split from Makefile.in.
12079 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12080 (shortlisp): Remove.
12081 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12082
4a720484
GM
120832011-05-19 Glenn Morris <rgm@gnu.org>
12084
12085 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12086 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12087 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12088 (lisp): Set the order to that of loadup.el.
12089 (shortlisp): Make it a copy of $lisp.
12090 (SOME_MACHINE_LISP): Remove.
12091 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12092 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12093
a28d4396
KH
120942011-05-18 Kenichi Handa <handa@m17n.org>
12095
12096 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12097 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12098 (find_automatic_composition): Mostly rewrite for efficiency.
12099
a2b1fa8e
JB
121002011-05-18 Juanma Barranquero <lekktu@gmail.com>
12101
12102 * makefile.w32-in: Update dependencies.
12103
8e1f5610
CS
121042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12105
12106 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12107 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12108
7025ee00 121092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12110
cdfa6eab
PE
12111 Fix some integer overflow issues, such as string length overflow.
12112
06d6db33
PE
12113 * insdel.c (count_size_as_multibyte): Check for string overflow.
12114
2b4560a8
PE
12115 * character.c (lisp_string_width): Check for string overflow.
12116 Use EMACS_INT, not int, for string indexes and lengths; in
12117 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12118 the resulting string length overflows an EMACS_INT; instead,
12119 report a string overflow if no precision given. When checking for
12120 precision exhaustion, use a check that cannot possibly have
12121 integer overflow. (Bug#8675)
12122 * character.h (lisp_string_width): Adjust to new signature.
12123
cb93f9be
PE
12124 * alloc.c (string_overflow): New function.
12125 (Fmake_string): Use it. This doesn't change behavior, but saves
12126 a few bytes and will simplify future changes.
12127 * character.c (string_escape_byte8): Likewise.
12128 * lisp.h (string_overflow): New decl.
12129
1a1f3366
PE
12130 Fixups, following up to the user-interface timestamp change.
12131 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12132 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12133 * msdos.c (mouse_get_pos): Likewise.
12134 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12135 * w32gui.h (Time): Define by including "systime.h" rather than by
12136 declaring it ourselves. (Bug#8664)
12137
d4e3e4d3
PE
12138 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12139 * image.c (clear_image_cache): Likewise.
12140
f6a24d19
PE
12141 * term.c (term_mouse_position): Don't assume time_t wraparound.
12142
08dc5ae6
PE
12143 Be more systematic about user-interface timestamps.
12144 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12145 and sometimes 'EMACS_UINT', to represent these timestamps.
12146 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12147 This makes the code easier to follow, and makes it easier to catch
12148 integer overflow bugs such as Bug#8664.
12149 * frame.c (Fmouse_position, Fmouse_pixel_position):
12150 Use Time, not unsigned long, for user-interface timestamps.
12151 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12152 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12153 * keyboard.h (last_event_timestamp): Likewise.
12154 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12155 * menu.h (xmenu_show): Likewise.
12156 * term.c (term_mouse_position): Likewise.
12157 * termhooks.h (struct input_event.timestamp): Likewise.
12158 (struct terminal.mouse_position_hook): Likewise.
12159 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12160 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12161 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12162 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12163 what it was before.
12164 * menu.h, termhooks.h: Include "systime.h", for Time.
12165
8e55734a
PE
12166 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12167 Don't assume that the difference between two unsigned long values
12168 can fit into an integer. At this point, we know button_down_time
12169 <= event->timestamp, so the difference must be nonnegative, so
12170 there's no need to cast the result if double-click-time is
12171 nonnegative, as it should be; check that it's nonnegative, just in
12172 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12173 apart (about 25 days). (Bug#8664)
8e55734a 12174
841f1b75 12175 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12176 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12177
3e26f69c
PE
12178 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12179 that always fit in int. Use a sentinel instead of a counter, to
12180 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12181 * frame.h (struct frame): Use int for menu_bar_items_used
12182 instead of EMACS_INT, since it always fits in int.
3e26f69c 12183
5cc152c0
PE
12184 * menu.c (grow_menu_items): Check for int overflow.
12185
d89eb65e
PE
12186 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12187
5235bd3e
PE
12188 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12189 Before, the code was not consistent. These values cannot exceed
12190 2**31 - 1 so there's no need to make them unsigned.
12191 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12192 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12193 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12194 as modifiers.
12195 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12196
bc827e23
PE
12197 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12198 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12199 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12200 presumably because the widths might not match.
12201
78eb494e
PE
12202 * window.c (size_window): Avoid needless test at loop start.
12203
04f2d78b
CB
122042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12205
12206 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12207
d2fc7e3d 122082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12209
12210 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12211
d2fc7e3d 122122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12213
12214 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12215 `width' to `bar_area_x' and `bar_area_width', respectively.
12216 (x_scroll_run): Take account of fringe background extension.
12217
04f2d78b
CB
12218 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12219 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12220 `bar_area_width', respectively.
12221 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12222 background extension.
12223
79b70037
GM
122242011-05-10 Jim Meyering <meyering@redhat.com>
12225
12226 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12227
2f142cc5
JB
122282011-05-10 Juanma Barranquero <lekktu@gmail.com>
12229
12230 * image.c (Finit_image_library): Return t for built-in image types,
12231 like pbm and xbm. (Bug#8640)
12232
57679c86
AS
122332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12234
12235 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12236
888c9e86
EZ
122372011-05-07 Eli Zaretskii <eliz@gnu.org>
12238
b0512a1d
EZ
12239 * w32console.c (Fset_screen_color): Doc fix.
12240 (Fget_screen_color): New function.
12241 (syms_of_ntterm): Defsubr it.
12242
7285dc67
EZ
12243 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12244 unlink the temporary file if Fcall_process didn't create it in the
12245 first place.
12246 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12247 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12248 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12249 cue to call_process_cleanup not to close that handle.
12250
4d3fcc8e
BK
122512011-05-07 Ben Key <bkey76@gmail.com>
12252
12253 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12254 one of two shell specific rules, either bootstrap-temacs-CMD or
12255 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12256 to the previous implementation of the bootstrap-temacs rule.
12257 The bootstrap-temacs-CMD rule is similar to the previous
12258 implementation of the bootstrap-temacs rule except that it
12259 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12260 variable.
12261
12262 These changes, along with some changes to nt/configure.bat,
12263 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12264 earlier fix to add support for --cflags and --ldflags options
12265 that include quotes so that it works whether make uses cmd or
12266 sh as the shell.
12267
b4289b64
MA
122682011-05-06 Michael Albinus <michael.albinus@gmx.de>
12269
12270 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12271 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12272 is a constant.
12273 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12274 a string. Handle both cases.
12275 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12276 (Fdbus_register_method): Use Qinvalid_function.
12277
af4c0e28
JB
122782011-05-06 Juanma Barranquero <lekktu@gmail.com>
12279
12280 * makefile.w32-in: Update dependencies.
12281 (LISP_H): Add inttypes.h and stdin.h.
12282 (PROCESS_H): Add unistd.h.
12283
c51453d9
EZ
122842011-05-06 Eli Zaretskii <eliz@gnu.org>
12285
12286 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12287 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12288
8ff0ac3c 122892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12290
4c4b566b
PE
12291 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12292
aab2b9b5
PE
12293 * term.c (vfatal): Remove stray call to va_end.
12294 It's not needed and the C Standard doesn't allow it here anyway.
12295
c378da0b
PE
12296 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12297 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12298
288b08c7
PE
12299 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12300 bytes.
12301
e3601888
PE
12302 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12303
db6c0e74
PE
12304 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12305
dd5963ea
PE
12306 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12307
88c9450f
PE
12308 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12309
2f9442b8
PE
12310 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12311
c032b5f8
PE
12312 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12313 * charset.c (Fdefine_charset_internal): Don't initialize
12314 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12315 32-bit int (Bug#8600).
a108c10b
PE
12316
12317 * lread.c (read_integer): Be more consistent with string-to-number.
12318 Use string_to_number to do the actual conversion; this avoids
12319 rounding errors and fixes some other screwups. Without this fix,
12320 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12321 (digit_to_number): Move earlier, for benefit of read_integer.
12322 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12323 not a digit in any supported base. (Bug#8602)
a108c10b 12324
ad5f9eea
PE
12325 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12326
aec1708a
PE
12327 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12328 to match comment at start of function. This also removes a
12329 GCC warning about overflow in a 32+64-bit port.
12330
47be4ab5
PE
12331 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12332
371cac43
PE
12333 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12334 Reported by Stefan Monnier in
12335 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12336 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12337 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12338
d01a7826
PE
12339 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12340 (EMACS_UINTPTR): Likewise, with uintptr_t.
12341
7fd47d5c
PE
12342 * lisp.h: Prefer 64-bit EMACS_INT if available.
12343 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12344 on 32-bit hosts that have 64-bit int, so that they can access
12345 large files.
122b0c86
PE
12346 However, temporarily disable this change unless the temporary
12347 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12348
8727937b
PE
12349 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12350
8ac068ac
PE
12351 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12352 This removes an assumption that EMACS_INT and long are the same
12353 width as pointers. The assumption is true for Emacs porting targets
12354 now, but we want to make other targets possible.
12355 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12356 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12357 In the rest of the code, change types of integers that hold casted
12358 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12359 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12360 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12361 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12362 No need to cast type when ORing.
12363 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12364 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12365 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12366 assume EMACS_INT is the same width as char *.
12367 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12368 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12369 Remove no-longer-needed casts.
12370 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12371 (xg_tool_bar_help_callback, xg_make_tool_item):
12372 Use EMACS_INTPTR to hold an integer
12373 that will be cast to void *; this can avoid a GCC warning
12374 if EMACS_INT is not the same width as void *.
12375 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12376 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12377 (current_message_1, set_message_1):
12378 Use a local to convert to proper width without a cast.
12379 * xmenu.c (dialog_selection_callback): Likewise.
12380
ede49d71
PE
12381 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12382 Also, don't assume VALBITS / RAND_BITS is less than 5,
12383 and don't rely on undefined behavior when shifting a 1 left into
12384 the sign bit.
12385 * lisp.h (get_random): Change signature to match.
12386
2f30ecd0
PE
12387 * lread.c (hash_string): Use size_t, not int, for hash computation.
12388 Normally we prefer signed values; but hashing is special, because
12389 it's better to use unsigned division on hash table sizes so that
12390 the remainder is nonnegative. Also, size_t is the natural width
12391 for hashing into memory. The previous code used 'int', which doesn't
12392 retain enough info to hash well into very large tables.
12393 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12394
2a866e7b
PE
12395 * dbusbind.c: Don't possibly lose pointer info when converting.
12396 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12397 Use XPNTR rather than XHASH, so that the high-order bits of
12398 the pointer aren't lost when converting through void *.
12399
51639eac
PE
12400 * eval.c (Fautoload): Don't double-shift a pointer.
12401
92394119
PE
12402 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12403
dbdb9a7c
JB
124042011-05-06 Juanma Barranquero <lekktu@gmail.com>
12405
12406 * gnutls.c (DEF_GNUTLS_FN):
12407 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12408
db7a0b4f
AS
124092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12410
12411 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12412 marker. (Bug#8610)
12413
cd394be1 124142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12415
12416 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12417 New version that can reserve upto 2GB of heap space.
12418
f7ff1b0f 124192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12420
12421 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12422
639c109b
TZ
124232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12424
12425 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12426 `gnutls_certificate_set_x509_key_file'.
12427
d2127135
JB
124282011-05-05 Juanma Barranquero <lekktu@gmail.com>
12429
12430 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12431 Update dependencies.
12432
e968f4f3
JB
124332011-05-04 Juanma Barranquero <lekktu@gmail.com>
12434
12435 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12436 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12437 Remove unused parameter `fildes'.
12438 * process.c (read_process_output, send_process): Don't pass it.
12439
84d358f0
JB
124402011-05-04 Juanma Barranquero <lekktu@gmail.com>
12441
12442 Fix previous change: the library cache is defined in w32.c.
12443 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12444 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12445
0898ca10
JB
124462011-05-04 Juanma Barranquero <lekktu@gmail.com>
12447
12448 Implement dynamic loading of GnuTLS on Windows.
12449
12450 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12451 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12452 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12453 Declare.
12454
12455 * gnutls.c (Qgnutls_dll): Define.
12456 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12457 (gnutls_*): Declare function pointers.
12458 (init_gnutls_functions): New function to initialize function pointers.
12459 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12460 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12461 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12462 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12463 (emacs_gnutls_write, emacs_gnutls_read)
12464 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12465 (Fgnutls_available_p): New function.
12466 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12467 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12468 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12469
12470 * image.c: Include w32.h.
12471 (Vimage_type_cache): Delete.
12472 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12473 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12474 (w32_delayed_load): Move to w32.c.
12475
12476 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12477
12478 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12479 (w32_delayed_load): Move from image.c. When loading a library, record
12480 its filename in the :loaded-from property of the library id.
12481 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12482 Initialize and staticpro them.
12483 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12484
12485 * process.c: Include lisp.h before w32.h, not after.
12486 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12487 instead of gnutls_record_check_pending.
12488
12489 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12490
ff4de4aa
TZ
124912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12492
12493 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12494 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12495 as passed in.
12496
abe95abb
JD
124972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12498
12499 * xterm.c (x_set_frame_alpha): Do not set property on anything
12500 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12501
e16e55d4
JB
125022011-05-02 Juanma Barranquero <lekktu@gmail.com>
12503
12504 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12505
bafcf6a5
JB
125062011-05-02 Juanma Barranquero <lekktu@gmail.com>
12507
12508 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12509 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12510 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12511 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12512 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12513 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12514 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12515 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12516 (Qgnutls_bootprop_callbacks_verify): Make static.
12517
e7a6747f
AS
125182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12519
19ed11ba
AS
12520 * callproc.c: Indentation fixup.
12521
e7a6747f 12522 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12523 (wait_for_termination, interruptible_wait_for_termination):
12524 Move after wait_for_termination_1.
e7a6747f 12525
1ef14cb4
LMI
125262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12527
12528 * sysdep.c (interruptible_wait_for_termination): New function
12529 which is like wait_for_termination, but allows keyboard
12530 interruptions.
12531
12532 * callproc.c (Fcall_process): Add (:file "file") as an option for
12533 the STDOUT buffer.
12534 (Fcall_process_region): Ditto.
12535
330d880c
EZ
125362011-04-30 Eli Zaretskii <eliz@gnu.org>
12537
8db90b73
EZ
12538 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12539 rather than `XVECTOR (FOO)->size'.
12540
330d880c
EZ
12541 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12542 inttypes.h, as a gnulib replacement is used if it not available in
12543 system headers.
12544
15cbd324
EZ
125452011-04-21 Eli Zaretskii <eliz@gnu.org>
12546
12547 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12548 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12549 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12550
12551 * coding.c (coding_alloc_by_realloc): Error out if destination
12552 will grow beyond MOST_POSITIVE_FIXNUM.
12553 (decode_coding_emacs_mule): Abort if there isn't enough place in
12554 charbuf for the composition carryover bytes. Reserve an extra
12555 space for up to 2 characters produced in a loop.
12556 (decode_coding_iso_2022): Abort if there isn't enough place in
12557 charbuf for the composition carryover bytes.
12558
125592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12560
ae940cca
EZ
12561 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12562 aborting when %lld or %lll format is passed.
12563 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12564 %llo or %llx format is passed. (Bug#8545)
12565
03ab8921
EZ
12566 * window.c (window_scroll_line_based): Use a marker instead of
12567 simple variables to record original value of point. (Bug#7952)
12568
afda1437
EZ
12569 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12570 produced by %s or %c overflows available buffer space. (Bug#8545)
12571
f76dee0c
PE
125722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12573
12574 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12575 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12576
fdc5744d
JB
125772011-04-28 Juanma Barranquero <lekktu@gmail.com>
12578
12579 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12580
638f053a
JB
125812011-04-28 Juanma Barranquero <lekktu@gmail.com>
12582
12583 * keyboard.c (Qdelayed_warnings_hook): Define.
12584 (command_loop_1): Run `delayed-warnings-hook'
12585 if Vdelayed_warnings_list is non-nil.
12586 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12587 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12588
d178f871
EZ
125892011-04-28 Eli Zaretskii <eliz@gnu.org>
12590
12591 * doprnt.c (doprnt): Don't return value smaller than the buffer
12592 size if the message was truncated. (Bug#8545).
12593
b124fd93
JB
125942011-04-28 Juanma Barranquero <lekktu@gmail.com>
12595
12596 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12597 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12598
e810457d
PE
125992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12600
12601 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12602
ea51cceb
JB
126032011-04-27 Juanma Barranquero <lekktu@gmail.com>
12604
12605 * makefile.w32-in: Update dependencies.
12606
94dcfacf
EZ
126072011-04-27 Eli Zaretskii <eliz@gnu.org>
12608
12609 Improve `doprnt' and its usage. (Bug#8545)
12610 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12611 `format_end'. Remove support for %l as a conversion specifier.
12612 Don't use xrealloc. Improve diagnostics when the %l size modifier
12613 is used. Update the commentary.
12614
12615 * eval.c (verror): Simplify calculation of size_t.
12616
12617 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12618 messages.
12619
f61f41d7
PE
126202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12621
12622 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12623 change.
12624
96fb4434
PE
126252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12626
12627 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12628 This makes this file independent of the recent pseudovector change.
12629
671875da 126302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12631
69e9b5a3
PE
12632 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12633
b5f869a7 12634 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12635 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12636 Remove unused local.
c8926152 12637 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12638
841a1577 12639 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12640 GCC 4.6.0 optimizes based on type-based alias analysis.
12641 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12642 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12643 != &v->size, and therefore "v->size = 1; b->size = 2; return
12644 v->size;" must therefore return 1. This assumption is incorrect
12645 for Emacs, since it type-puns struct Lisp_Vector * with many other
12646 types. To fix this problem, this patch adds a new type struct
f904488f 12647 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12648 and pseudovectors, and helps optimizing compilers not get fooled
12649 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12650 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12651 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12652 the size member.
eab3844f
PE
12653 (XSETPVECTYPE): Rewrite in terms of new macro.
12654 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12655 This is a bit clearer, and further avoids the possibility of
12656 undesirable aliasing.
12657 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12658 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12659 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12660 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12661 (ASIZE): Now uses header.size rather than size.
12662 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12663 to avoid the hassle of writing XVECTOR (foo)->header.size.
12664 (struct vectorlike_header): New type.
eab3844f
PE
12665 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12666 object, to help avoid aliasing.
12667 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12668 (SUBRP): Likewise, since Lisp_Subr is a special case.
12669 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12670 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12671 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12672 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12673 changed to be "header.size" and "header.next".
12674 * buffer.h (struct buffer): Likewise.
12675 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12676 * frame.h (struct frame): Likewise.
12677 * process.h (struct Lisp_Process): Likewise.
12678 * termhooks.h (struct terminal): Likewise.
12679 * window.c (struct save_window_data, struct saved_window): Likewise.
12680 * window.h (struct window): Likewise.
12681 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12682 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12683 * buffer.c (init_buffer_once): Likewise.
12684 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12685 special case.
12686 * process.c (Fformat_network_address): Use local var for size,
12687 for brevity.
12688
0df1eac5
PE
12689 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12690
847ab9d1 12691 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12692 * data.c (atof): Remove decl; no longer used or needed.
12693 (digit_to_number): Move to lread.c.
12694 (Fstring_to_number): Use new string_to_number function, to be
12695 consistent with how the Lisp reader treats infinities and NaNs.
12696 Do not assume that floating-point numbers represent EMACS_INT
12697 without losing information; this is not true on most 64-bit hosts.
12698 Avoid double-rounding errors, by insisting on integers when
12699 parsing non-base-10 numbers, as the documentation specifies.
12700 * lisp.h (string_to_number): New decl, replacing ...
12701 (isfloat_string): Remove.
bc0a5c13 12702 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12703 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12704 appears to have been a coding error. Similarly, do not accept
12705 strings like +-1e0 as floating point numbers. Do not report
12706 overflow for integer overflows unless the base is not 10 which
12707 means we have no simple and reliable way to continue.
12708 Break out the floating-point parsing into a new
12709 function string_to_number, so that Fstring_to_number parses
12710 floating point numbers consistently with the Lisp reader.
04f2d78b 12711 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12712 (E_CHAR, EXP_INT): Remove, replacing with ...
12713 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12714 (string_to_number): New function, replacing isfloat_string.
12715 This function checks for valid syntax and produces the resulting
12716 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12717 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12718 so that overflow for non-base-10 numbers is reported only when
12719 there's no portable and simple way to convert to floating point.
452f4150 12720
67769ffc
PE
12721 * textprop.c (set_text_properties_1): Rewrite for clarity,
12722 and to avoid GCC warning about integer overflow.
12723
c20db43f
PE
12724 * intervals.h (struct interval): Use EMACS_INT for members
12725 where EMACS_UINT might cause problems. See
12726 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12727 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12728 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12729 All uses changed.
37aa2f85
PE
12730 (offset_intervals): Tell GCC not to worry about length overflow
12731 when negating a negative length.
c20db43f 12732
2538aa2f
PE
12733 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12734 (overrun_check_free): Likewise.
12735
f2d3008d
PE
12736 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12737 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12738 word size.
12739
ec8df744
PE
12740 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12741 (gnutls_make_error): Rename local to avoid shadowing.
12742 (gnutls_emacs_global_deinit): ifdef out; not used.
12743 (Fgnutls_boot): Use const for pointer to readonly storage.
12744 Comment out unused local. Fix pointer signedness problems.
12745
640ee02d
PE
12746 * lread.c (openp): Don't stuff size_t into an 'int'.
12747 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12748 about possible signed overflow.
12749
6048fb2a
PE
12750 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12751 (GDK_KEY_g): Don't define if already defined.
12752 (xg_prepare_tooltip): Avoid pointer signedness problem.
12753 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12754
fa3c87e1
PE
12755 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12756 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12757
2172544b
PE
12758 * xfns.c (Fx_window_property): Simplify a bit,
12759 to make a bit faster and to avoid GCC 4.6.0 warning.
12760 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12761
9b821a21
PE
12762 * fns.c (internal_equal): Don't assume size_t fits in int.
12763
3c616cfa
PE
12764 * alloc.c (compact_small_strings): Tighten assertion a little.
12765
c2982e87
PE
12766 Replace pEd with more-general pI, and fix some printf arg casts.
12767 * lisp.h (pI): New macro, generalizing old pEd macro to other
12768 conversion specifiers. For example, use "...%"pI"d..." rather
12769 than "...%"pEd"...".
12770 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12771 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12772 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12773 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12774 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12775 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12776 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12777 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12778 64-bit hosts.
12779 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12780 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12781 * print.c (safe_debug_print, print_object): Likewise.
12782 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12783 to int.
6f04d126
PE
12784 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12785 avoiding the 0 flag, which is not portable.
c2982e87
PE
12786 * process.c (Fmake_network_process): Use pI to avoid cast.
12787 * region-cache.c (pp_cache): Likewise.
12788 * xdisp.c (decode_mode_spec): Likewise.
12789 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12790 behavior on 64-bit hosts with printf arg.
6f04d126 12791 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12792 (x_stop_queuing_selection_requests): Likewise.
12793 (x_get_window_property): Don't truncate byte count to an 'int'
12794 when tracing.
0b432f21 12795
5e073ec7
PE
12796 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12797 here, since it parses constructs like leading '-' and spaces,
12798 which are not wanted; and it overflows with large numbers.
12799 Instead, simply match F[0-9]+, which is what is wanted anyway.
12800
36372bf9
PE
12801 * alloc.c: Remove unportable assumptions about struct layout.
12802 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12803 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12804 (allocate_vectorlike, make_pure_vector): Use the new macros,
12805 plus offsetof, to remove unportable assumptions about struct layout.
12806 These assumptions hold on all porting targets that I know of, but
12807 they are not guaranteed, they're easy to remove, and removing them
12808 makes further changes easier.
12809
0b432f21
PE
12810 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12811 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12812 (string_overrun_cookie): Now const. Use initializers that
12813 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12814 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12815 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12816 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12817 multiple of sizeof (EMACS_INT); it need not be, if
12818 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12819 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12820
895009e1
JB
128212011-04-26 Juanma Barranquero <lekktu@gmail.com>
12822
12823 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12824
6a7a1b0b
TZ
128252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12826
12827 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12828 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12829 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12830
841a1577 128312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12832
12833 * lisp.h (Qdebug): List symbol.
895009e1 12834 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12835 * keyboard.c (debug-on-event): New variable.
12836 (handle_user_signal): Break into debugger when debug-on-event
12837 matches the current signal symbol.
12838
f2d3ba6f
DN
128392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12840
12841 * alloc.c (check_sblock, check_string_bytes)
12842 (check_string_free_list): Convert to standard C.
12843
42ce4c63
TZ
128442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12845
12846 * w32.c (emacs_gnutls_push): Fix typo.
12847
825cd63c
EZ
128482011-04-25 Eli Zaretskii <eliz@gnu.org>
12849
fb11d64d
EZ
12850 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12851 "cast to pointer from integer of different size".
12852
825cd63c
EZ
12853 Improve doprnt and its use in verror. (Bug#8545)
12854 * doprnt.c (doprnt): Document the set of format control sequences
12855 supported by the function. Use SAFE_ALLOCA instead of always
12856 using `alloca'.
12857
12858 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12859 is one byte too soon. Don't use xrealloc; instead xfree and
12860 xmalloc anew.
12861
e061a11b
TZ
128622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12863
12864 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12865 callbacks stage.
12866
12867 * gnutls.c: Renamed global_initialized to
12868 gnutls_global_initialized. Added internals for the
12869 :verify-hostname-error, :verify-error, and :verify-flags
12870 parameters of `gnutls-boot' and documented those parameters in the
12871 docstring. Start callback support.
9173deec
JB
12872 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12873 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12874 on error. Return error code.
e061a11b
TZ
12875 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12876 (emacs_gnutls_read): Likewise.
12877 (Fgnutls_boot): Return handshake error code.
12878 (emacs_gnutls_handle_error): New function.
12879 (wsaerror_to_errno): Likewise.
12880
12881 * w32.h (emacs_gnutls_pull): Add prototype.
12882 (emacs_gnutls_push): Likewise.
12883
12884 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12885 (emacs_gnutls_push): Likewise.
12886
128872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12888
12889 * process.c (wait_reading_process_output): Check if GnuTLS
12890 buffered some data internally if no FDs are set for TLS
12891 connections.
12892
12893 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12894 (LIBS): Link to USER_LIBS.
12895 ($(BLD)/gnutls.$(0)): New target.
12896
fa6996bc
EZ
128972011-04-24 Eli Zaretskii <eliz@gnu.org>
12898
eb35682e
EZ
12899 * xdisp.c (handle_single_display_spec): Rename the
12900 display_replaced_before_p argument into display_replaced_p, to
12901 make it consistent with the commentary. Fix typos in the
12902 commentary.
12903
e2ad650c
EZ
12904 * textprop.c (syms_of_textprop): Remove dead code.
12905 (copy_text_properties): Delete obsolete commentary about an
12906 interface that was deleted long ago. Fix typos in the description
12907 of arguments.
12908
1b2de274
EZ
12909 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12910 to changes in oldXMenu/XMenu.h from 2011-04-16.
12911 <menu_help_message, prev_menu_help_message>: Constify.
12912 (IT_menu_make_room): menu->help_text is now `const char **';
12913 adjust.
12914
12915 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12916 to changes in oldXMenu/XMenu.h from 2011-04-16.
12917 (struct XMenu): Declare `help_text' `const char **'.
12918
12919 * xfaces.c <Qunspecified>: Make extern again.
12920
12921 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12922 required by POSIX.
1b2de274 12923
762b15be
EZ
12924 * doc.c (get_doc_string): Improve the format passed to `error'.
12925
12926 * doprnt.c (doprnt): Improve commentary.
12927
12928 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12929
12930 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12931 them with etags.
12932
f1052e5d
EZ
12933 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12934 changes in globals.h immediately force recompilation.
762b15be
EZ
12935 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12936 $(CURDIR)/s/ms-w32.h.
12937 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12938
fa6996bc
EZ
12939 * character.c (Fchar_direction): Function deleted.
12940 (syms_of_character): Don't defsubr it.
12941 <char-direction-table>: Deleted.
12942
e6c3da20
EZ
129432011-04-23 Eli Zaretskii <eliz@gnu.org>
12944
12945 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12946 * doprnt.c: Include limits.h.
12947 (SIZE_MAX): New macro.
04f2d78b
CB
12948 (doprnt): Return a size_t value. 2nd arg is now size_t.
12949 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12950 Improve overflow protection. Support `l' modifier for integer
12951 conversions. Support %l conversion. Don't assume an EMACS_INT
12952 argument for integer conversions and for %c.
12953
12954 * lisp.h (doprnt): Restore prototype.
12955
12956 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12957 $(SRC)/character.h.
12958
12959 * Makefile.in (base_obj): Add back doprnt.o.
12960
12961 * deps.mk (doprnt.o): Add back prerequisites.
12962 (callint.o): Depend on character.h.
12963
12964 * eval.c (internal_lisp_condition_case): Include the handler
12965 representation in the error message.
12966 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12967 when breaking from the loop.
12968
12969 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12970
12971 * callint.c (Fcall_interactively): When displaying error message
12972 about invalid control letter, pass the character's codepoint, not
12973 a pointer to its multibyte form. Improve display of the character
12974 in octal and display also its hex code.
12975
12976 * character.c (char_string): Use %x to display the (unsigned)
12977 codepoint of an invalid character, to avoid displaying a bogus
12978 negative value.
12979
12980 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12981 `error', not SYMBOL_NAME itself.
12982
12983 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12984 character arguments to `error'.
12985
12986 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12987 to `error' in error message about FINAL_CHAR argument. Make sure
12988 FINAL_CHAR is a character, and use %c when it is passed as
12989 argument to `error'.
12990
4ffd0d6b 129912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12992
12993 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12994
12995 * w32.c: Include <time.h>.
12996 (sys_localtime): New function.
12997
4ffd0d6b 129982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12999
13000 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13001
4ffd0d6b 13002 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13003
4ffd0d6b 130042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13005
4ffd0d6b
GM
13006 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13007 zombies (Bug#8467).
aac0c6e3 13008
04c56954
EZ
130092011-04-19 Eli Zaretskii <eliz@gnu.org>
13010
13011 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13012 gl_state.e_property when gl_state.object is Qt.
13013
13014 * insdel.c (make_gap_larger): Remove limitation of buffer size
13015 to <= INT_MAX.
13016
16a43933
CY
130172011-04-18 Chong Yidong <cyd@stupidchicken.com>
13018
13019 * xdisp.c (lookup_glyphless_char_display)
13020 (produce_glyphless_glyph): Handle cons cell entry in
13021 glyphless-char-display.
13022 (Vglyphless_char_display): Document it.
13023
13024 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13025 glyphless-char-display.
13026
4581706e
CY
130272011-04-17 Chong Yidong <cyd@stupidchicken.com>
13028
13029 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13030
13031 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13032
13033 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13034 definition for no-X builds.
13035
4887c6e2 130362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13037
fd35b6f9
PE
13038 Static checks with GCC 4.6.0 and non-default toolkits.
13039
5c1ccb01
PE
13040 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13041
006c5daa
PE
13042 * process.c (keyboard_bit_set): Define only if SIGIO.
13043 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13044 (send_process): Repair possible setjmp clobbering.
13045
efc736d3
PE
13046 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13047
4e2fe2e6
PE
13048 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13049
f97334a2
PE
13050 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13051
4e75f29d
PE
13052 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13053 Define only if needed.
13054
90efadd1
PE
13055 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13056 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13057 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13058
3c647824
PE
13059 * dispextern.h (struct redisplay_interface): Rename param
13060 to avoid shadowing.
e264f262 13061 * termhooks.h (struct terminal): Likewise.
761383f4 13062 * xterm.c (xembed_send_message): Likewise.
3c647824 13063
b58c5c4a
PE
13064 * insdel.c (make_gap_smaller): Define only if
13065 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13066
cad59032
PE
13067 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13068 it.
13069
c339dc2e
PE
13070 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13071 so that we aren't warned about unused symbols.
13072
91a3e27b
PE
13073 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13074
399c71d3 13075 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13076
8ffc96f5
PE
13077 * xfns.c (x_real_positions): Mark locals as initialized.
13078
eef9bc79
PE
13079 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13080
098db9dd
PE
13081 * xterm.c: Fix problems found by static analysis with other toolkits.
13082 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13083 (x_dispatch_event): Declare static if USE_GTK, and
13084 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13085 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13086 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13087 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13088 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13089
eb18f6cc
PE
13090 * xmenu.c (menu_help_callback): Pointer type fixes.
13091 Use const pointers when pointing at readonly data. Avoid pointer
13092 signedness clashes.
13093 (FALSE): Remove unused macro.
13094 (update_frame_menubar): Remove unused decl.
13095
1fe72bf8
PE
13096 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13097
60d9e1db
PE
13098 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13099 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13100 (single_menu_item): Rename local to avoid shadowing.
13101
39261c26
PE
13102 * keyboard.c (make_lispy_event): Remove unused local var.
13103
018c5e19
PE
13104 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13105 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13106
63d2b86e
PE
13107 * bitmaps: Change bitmaps from unsigned char back to the X11
13108 compatible char. Avoid the old compiler warnings about
13109 out-of-range initializers by using, for example, '\xab' rather
13110 than 0xab.
13111
aefd87e1
PE
13112 * xgselect.c (xgselect_initialize): Check vs interface
13113 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13114
bf501fb9
PE
13115 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13116
e9829fdf
PE
13117 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13118 to read-only memory.
13119
1086c095
PE
13120 * fns.c (vector): Remove; this old hack is no longer needed.
13121
2baccd04 13122 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13123 Remove unused var.
dde42981 13124 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13125
72391843 13126 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13127
436c16df 13128 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13129 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13130 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13131
92bb796d 13132 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13133 (x_term_init): Remove local to avoid shadowing.
92bb796d 13134
764430a3 13135 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13136
13137 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13138 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13139
d1dfb56c
EZ
131402011-04-16 Eli Zaretskii <eliz@gnu.org>
13141
c4354cb4
EZ
13142 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13143
d1dfb56c
EZ
13144 Fix regex.c, syntax.c and friends for buffers > 2GB.
13145 * syntax.h (struct gl_state_s): Declare character position members
13146 EMACS_INT.
13147
13148 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13149
04f2d78b
CB
13150 * textprop.c (verify_interval_modification, interval_of):
13151 Declare arguments EMACS_INT.
d1dfb56c
EZ
13152
13153 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13154 EMACS_INT.
13155
13156 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13157
13158 * indent.c (Fvertical_motion): Local variable it_start is now
13159 EMACS_INT.
13160
13161 * regex.c (re_match, re_match_2, re_match_2_internal)
13162 (bcmp_translate, regcomp, regexec, print_double_string)
13163 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13164 (re_compile_pattern, re_exec): Declare arguments and local
13165 variables `size_t' and `ssize_t' and return values `regoff_t', as
13166 appropriate.
13167 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13168 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13169 <compile_stack_type>: `size' and `avail' are now `size_t'.
13170
13171 * regex.h <regoff_t>: Use ssize_t, not int.
13172 (re_search, re_search_2, re_match, re_match_2): Arguments that
13173 specify buffer/string position and length are now ssize_t and
13174 size_t. Return type is regoff_t.
13175
613052cd
BK
131762011-04-16 Ben Key <bkey76@gmail.com>
13177
13178 * nsfont.m: Fixed bugs in ns_get_family and
13179 ns_descriptor_to_entity that were caused by using free to
13180 deallocate memory blocks that were allocated by xmalloc (via
13181 xstrdup). This caused Emacs to crash when compiled with
13182 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13183 --enable-checking=xmallocoverrun). xfree is now used to
13184 deallocate these memory blocks.
13185
4170f62f 131862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13187
71b41406
PE
13188 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13189
9587a89d
PE
13190 emacs_write: Accept and return EMACS_INT for sizes.
13191 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13192 et seq.
13193 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13194 Accept and return EMACS_INT.
13195 (emacs_gnutls_write): Return the number of bytes written on
13196 partial writes.
13197 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13198 (emacs_read, emacs_write): Remove check for negative size, as the
13199 Emacs source code has been audited now.
9587a89d
PE
13200 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13201 (emacs_read, emacs_write): Use it.
273a5f82
PE
13202 * process.c (send_process): Adjust to the new signatures of
13203 emacs_write and emacs_gnutls_write. Do not attempt to store
13204 a byte offset into an 'int'; it might overflow.
9587a89d 13205 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13206
3e047f51
PE
13207 * sound.c: Don't assume sizes fit in 'int'.
13208 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13209 Return EMACS_INT, not int.
3e047f51 13210 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13211 Accept EMACS_INT, not int.
13212 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13213 record read return values.
13214
cc39a9db
BK
132152011-04-15 Ben Key <bkey76@gmail.com>
13216
c9d0ec6d
JB
13217 * keyboard.c (Qundefined): Don't declare static since it is used
13218 in nsfns.m.
13219 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13220 static since they are used in nsfont.m.
cc39a9db 13221
6c60eb9f
SM
132222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13223
13224 * process.c (Qprocessp): Don't declare static.
13225 * lisp.h (Qprocessp): Declare again.
13226
7990b61a
JB
132272011-04-15 Juanma Barranquero <lekktu@gmail.com>
13228
13229 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13230
5d4cb038
PE
132312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13232
8bd7b830 13233 Improve C-level modularity by making more things 'static'.
cd64ea1d 13234
e3b27b31
PE
13235 Don't publish debugger-only interfaces to other modules.
13236 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13237 (verify_bytepos, count_markers): Move decls to the only modules
13238 that need them.
13239 * region-cache.h (pp_cache): Likewise.
13240 * window.h (check_all_windows): Likewise.
13241 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13242
5d4cb038
PE
13243 * sysdep.c (croak): Now static, if
13244 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13245 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13246
13247 * alloc.c (refill_memory_reserve): Now static if
13248 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13249 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13250
e87b6180
PE
13251 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13252 Define only if USE_LUCID.
13253
ac64929e
PE
13254 * xrdb.c (x_customization_string, x_rm_string): Now static.
13255
6f37259d
PE
13256 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13257 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13258
1683e3ab
PE
13259 * xdisp.c (draw_row_with_mouse_face): Now static.
13260 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13261
de9c2632
PE
13262 * window.h (check_all_windows): Mark externally visible.
13263
2b96acb7
PE
13264 * window.c (window_deletion_count): Now static.
13265
13266 * undo.c: Make symbols static if they're not exported.
13267 (last_undo_buffer, last_boundary_position, pending_boundary):
13268 Now static.
13269
50436f33
PE
13270 * textprop.c (interval_insert_behind_hooks): Now static.
13271 (interval_insert_in_front_hooks): Likewise.
13272
64520e5c
PE
13273 * term.c: Make symbols static if they're not exported.
13274 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13275 (max_frame_lines, tty_set_terminal_modes):
13276 (tty_reset_terminal_modes, tty_turn_off_highlight):
13277 (get_tty_terminal): Now static.
13278 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13279 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13280 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13281 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13282 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13283
1fa53021
PE
13284 * sysdep.c: Make symbols static if they're not exported.
13285 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13286 Now static.
13287 (sigprocmask_set, full_mask): Remove; unused.
13288 (wait_debugging): Mark as visible.
13289 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13290 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13291
d4b43b22
PE
13292 * syntax.c (syntax_temp): Define only if !__GNUC__.
13293
b7c513d0
PE
13294 * sound.c (current_sound_device, current_sound): Now static.
13295
989b29ad
PE
13296 * search.c (searchbufs, searchbuf_head): Now static.
13297
13a55a78
PE
13298 * scroll.c (scroll_cost): Remove; unused.
13299 * dispextern.h (scroll_cost): Remove decl.
13300
de68a1fc
PE
13301 * region-cache.h (pp_cache): Mark as externally visible.
13302
40ccffa6
PE
13303 * process.c: Make symbols static if they're not exported.
13304 (process_tick, update_tick, create_process, chan_process):
13305 (Vprocess_alist, proc_buffered_char, datagram_access):
13306 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13307 (deactivate_process): Mark defn as static, as well as decl.
13308 * lisp.h (create_process): Remove decl.
13309 * process.h (chan_process, Vprocess_alist): Remove decls.
13310
ad64fc97
PE
13311 * print.c: Make symbols static if they're not exported.
13312 (print_depth, new_backquote_output, being_printed, print_buffer):
13313 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13314 (print_interval, print_number_index, initial_stderr_stream):
13315 Now static.
13316 * lisp.h (Fprinc): Remove decl.
13317 (debug_output_compilation_hack): Mark as externally visible.
13318
adddb265
PE
13319 * sysdep.c (croak): Move decl from here to syssignal.h.
13320 * syssignal.h (croak): Put it here, so the API can be checked when
13321 'croak' is called from dissociate_if_controlling_tty.
13322
1717ede2
PE
13323 * minibuf.c: Make symbols static if they're not exported.
13324 (minibuf_save_list, choose_minibuf_frame): Now static.
13325 * lisp.h (choose_minibuf_frame): Remove decl.
13326
fa5fb2bc
PE
13327 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13328
1e3890d1
PE
13329 * lread.c: Make symbols static if they're not exported.
13330 (read_objects, initial_obarray, oblookup_last_bucket_number):
13331 Now static.
13332 (make_symbol): Remove; unused.
13333 * lisp.h (initial_obarray, make_symbol): Remove decls.
13334
8a1414fa
PE
13335 * keyboard.c: Make symbols static if they're not exported.
13336 (single_kboard, recent_keys_index, total_keys, recent_keys):
13337 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13338 (this_single_command_key_start, echoing, last_auto_save):
13339 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13340 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13341 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13342 (Vlispy_mouse_stem, double_click_count):
13343 Now static.
13344 (force_auto_save_soon): Define only if SIGDANGER.
13345 (ignore_mouse_drag_p): Now static if
13346 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13347 (print_help): Remove; unused.
13348 (stop_character, last_timer_event): Mark as externally visible.
13349 * keyboard.h (ignore_mouse_drag_p): Declare only if
13350 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13351 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13352 * lisp.h (echoing): Remove decl.
13353 (force_auto_save_soon): Declare only if SIGDANGER.
13354 * xdisp.c (redisplay_window): Simplify code, to make it more
13355 obvious that ignore_mouse_drag_p is not accessed if !defined
13356 USE_GTK && !defined HAVE_NS.
13357
93ea6e8f
PE
13358 * intervals.c: Make symbols static if they're not exported.
13359 (merge_properties_sticky, merge_interval_right, delete_interval):
13360 Now static.
13361 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13362
77382fcc
PE
13363 * insdel.c: Make symbols static if they're not exported.
13364 However, leave prepare_to_modify_buffer alone. It's never
13365 called from outside this function, but that appears to be a bug.
13366 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13367 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13368 (adjust_after_replace_noundo): Remove; unused.
13369 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13370 (signal_before_change): Remove decls.
77382fcc 13371
9306c32e
PE
13372 * indent.c (val_compute_motion, val_vmotion): Now static.
13373
cd44d2eb
PE
13374 * image.c: Make symbols static if they're not exported.
13375 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13376 if USE_GTK.
13377 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13378 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13379
ad9a7a06
PE
13380 * fringe.c (standard_bitmaps): Now static.
13381 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13382
81626931
PE
13383 * frame.c: Make symbols static if they're not exported.
13384 (x_report_frame_params, make_terminal_frame): Now static.
13385 (get_frame_param): Now static, unless HAVE_NS.
13386 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13387 (x_get_resource_string): Remove; not used.
13388 * frame.h (make_terminal_frame, x_report_frame_params):
13389 (x_get_resource_string); Remove decls.
13390 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13391 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13392
239f9db9
PE
13393 * font.c, fontset.c: Make symbols static if they're not exported.
13394 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13395 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13396 * font.c (font_close_object): Now static.
13397 * font.h (font_close_object): Remove.
13398 * fontset.c (FONTSET_OBJLIST): Remove.
13399 (free_realized_fontset) #if-0 the body, which does nothing.
13400 (face_suitable_for_char_p): #if-0, as it's never called.
13401 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13402 * xfaces.c (face_at_string_position):
13403 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13404 since 0 is always ASCII.
13405
dfcf3579
PE
13406 * fns.c (weak_hash_tables): Now static.
13407
5045092b
PE
13408 * fileio.c: Make symbols static if they're not exported.
13409 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13410 (Vwrite_region_annotation_buffers): Now static.
13411
57a96f5c
PE
13412 * eval.c: Make symbols static if they're not exported.
13413 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13414 * lisp.h (backtrace_list): Remove decl.
13415
35f08c38
PE
13416 * emacs.c: Make symbols static if they're not exported.
13417 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13418 (fatal_error_code, fatal_error_signal_hook, standard_args):
13419 Now static.
13420 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13421 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13422 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13423 * lisp.h (fatal_error_signal_hook): Remove decl.
13424 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13425
f44bd759
PE
13426 * editfns.c: Move a (normally-unused) function to its only use.
13427 * editfns.c, lisp.h (get_operating_system_release): Remove.
13428 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13429 worth the hassle of breaking this out.
13430
b532497d
PE
13431 * xterm.c: Make symbols static if they're not exported.
13432 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13433 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13434 (x_destroy_window, x_delete_display):
13435 Now static.
13436 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13437 (x_mouse_leave): Remove; unused.
13438 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13439 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13440 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13441 Remove decls.
13442 (x_mouse_leave): Declare only if WINDOWSNT.
13443 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13444 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13445 USE_X_TOOLKIT.
13446
1675728f
PE
13447 * ftxfont.c: Make symbols static if they're not exported.
13448 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13449 HAVE_FREETYPE.
13450 * font.h (ftxfont_driver): Likewise.
13451
e4cebfca
PE
13452 * xfns.c: Make symbols static if they're not exported.
13453 (x_last_font_name, x_display_info_for_name):
13454 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13455 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13456 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13457 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13458 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13459 (last_show_tip_args): Now static.
13460 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13461 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13462 (x_screen_planes): Remove; unused.
13463 * dispextern.h (x_screen_planes): Remove decl.
13464
5bf46f05
PE
13465 * dispnew.c: Make symbols static if they're not exported.
13466 * dispextern.h (redraw_garbaged_frames, scrolling):
13467 (increment_row_positions): Remove.
13468 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13469 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13470 Now static.
13471 (redraw_garbaged_frames): Remove; unused.
13472
435f4c28
PE
13473 * xfaces.c: Make symbols static if they're not exported.
13474 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13475 Remove decls.
13476 * xterm.h (defined_color): Remove decls.
13477 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13478 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13479 (menu_face_changed_default, defined_color, free_realized_face):
13480 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13481 (ascii_face_of_lisp_face): Remove; unused.
13482
8524aef3
PE
13483 * xdisp.c: Make symbols static if they're not exported.
13484 * dispextern.h (scratch_glyph_row, window_box_edges):
13485 (glyph_to_pixel_coords, set_cursor_from_row):
13486 (get_next_display_element, set_iterator_to_next):
13487 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13488 (show_mouse_face): Remove decls
13489 * frame.h (message_buf_print): Likewise.
13490 * lisp.h (pop_message, set_message, check_point_in_composition):
13491 Likewise.
13492 * xterm.h (set_vertical_scroll_bar): Likewise.
13493 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13494 (message_buf_print, scratch_glyph_row, displayed_buffer):
13495 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13496 (get_next_display_element, show_mouse_face, window_box_edges):
13497 (frame_to_window_pixel_xy, check_point_in_composition):
13498 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13499 (glyph_to_pixel_coords): Remove; unused.
13500
16390cd2
PE
13501 * dired.c (file_name_completion): Now static.
13502
13503 * dbusbind.c (xd_in_read_queued_messages): Now static.
13504
a25f4dfa
PE
13505 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13506 * data.c (circular_list_error): Remove.
13507
14a9c8df
PE
13508 * commands.h (last_point_position, last_point_position_buffer):
13509 (last_point_position_window): Remove decls.
13510 * keyboard.c: Make these variables static.
13511
04f2d78b
CB
13512 * coding.h (coding, code_convert_region, encode_coding_gap):
13513 Remove decls.
74ab6df5
PE
13514 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13515 (iso_code_class, detect_coding, code_convert_region): Now static.
13516 (encode_coding_gap): Remove; unused.
13517
38dfbee1
PE
13518 * chartab.c (chartab_chars, chartab_bits): Now static.
13519
a2cb4e63
PE
13520 * charset.h (charset_iso_8859_1): Remove decl.
13521 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13522 Now static.
13523
127198fd
PE
13524 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13525 * ccl.c (Vccl_program_table): Now static.
13526 (check_ccl_update): Remove; unused.
13527
d85b608f
PE
13528 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13529 * category.h: ... from here.
13530 * category.c (check_category_table, set_category_set): Now static.
13531
31cd66f3
PE
13532 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13533 * lisp.h: Remove these decls.
13534
c358e587
PE
13535 * buffer.c (buffer_count): Remove unused var.
13536
e78aecca
PE
13537 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13538 so that it's not optimized away.
13539 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13540 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13541 exported only to the debugger.
13542
e192d7d3 13543 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13544 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13545
92470028
PE
13546 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13547 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13548 was inaccessible from Lisp.
13549 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13550 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13551
244ed907
PE
13552 alloc.c: Import and export fewer symbols, and remove unused items.
13553 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13554 is defined.
13555 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13556 it's not optimized away by whole-program optimization.
13557 (message_enable_multibyte, free_misc): Remove.
13558 (catchlist, handlerlist, mark_backtrace):
13559 Declare only if BYTE_MARK_STACK.
13560 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13561 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13562 (message_enable_multibyte): Remove decl.
13563 (free_misc, interval_free_list, float_block, float_block_index):
13564 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13565 (cons_free_list, last_marked_index):
13566 Now static.
13567 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13568 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13569 (mark_backtrace): Define only if BYTE_MARK_STACK.
13570 * xdisp.c (message_enable_multibyte): Now static.
13571
61c2b50e 13572 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13573 This makes it easier for human readers (and static analyzers)
13574 to see whether these variables are used from other modules.
13575 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13576 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13577 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13578 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13579 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13580 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13581 * xmenu.c, xselect.c:
13582 Declare Q* vars static if they are not used in other modules.
13583 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13584 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13585 Remove decls of unexported vars.
13586 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13587
95c82688
PE
13588 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13589
16a97296
PE
13590 Make Emacs functions such as Fatom 'static' by default.
13591 This makes it easier for human readers (and static analyzers)
13592 to see whether these functions can be called from other modules.
13593 DEFUN now defines a static function. To make the function external
13594 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13595 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13596 (Finit_image_library):
16a97296
PE
13597 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13598 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13599 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13600 Remove decls, since these functions are now static.
13601 (Funintern, Fget_internal_run_time): New decls, since these functions
13602 were already external.
95c82688 13603
16a97296
PE
13604 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13605 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13606 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13607 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13608 * keyboard.c, keymap.c, lread.c:
13609 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13610 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13611 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13612 Mark functions with DEFUE instead of DEFUN,
13613 if they are used in other modules.
13614 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13615 decls for now-static functions.
13616 * buffer.h (Fdelete_overlay): Remove decl.
13617 * callproc.c (Fgetenv_internal): Mark as internal.
13618 * composite.c (Fremove_list_of_text_properties): Remove decl.
13619 (Fcomposition_get_gstring): New forward static decl.
13620 * composite.h (Fcomposite_get_gstring): Remove decl.
13621 * dired.c (Ffile_attributes): New forward static decl.
13622 * doc.c (Fdocumntation_property): New forward static decl.
13623 * eval.c (Ffetch_bytecode): New forward static decl.
13624 (Funintern): Remove extern decl; now in .h file where it belongs.
13625 * fileio.c (Fmake_symbolic_link): New forward static decl.
13626 * image.c (Finit_image_library): New forward static decl.
13627 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13628 * intervals.h (Fprevious_property_change):
13629 (Fremove_list_of_text_properties): Remove decls.
13630 * keyboard.c (Fthis_command_keys): Remove decl.
13631 (Fcommand_execute): New forward static decl.
13632 * keymap.c (Flookup_key): New forward static decl.
13633 (Fcopy_keymap): Now static.
13634 * keymap.h (Flookup_key): Remove decl.
13635 * process.c (Fget_process): New forward static decl.
13636 (Fprocess_datagram_address): Mark as internal.
13637 * syntax.c (Fsyntax_table_p): New forward static decl.
13638 (skip_chars): Remove duplicate decl.
13639 * textprop.c (Fprevious_property_change): New forward static decl.
13640 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13641 Now internal.
13642 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13643 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13644
785bbd42
PE
13645 * editfns.c (Fformat): Remove unreachable code.
13646
8b913b57
AS
136472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13648
13649 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13650 change. (Bug#8496)
13651
a6744a35
EZ
136522011-04-13 Eli Zaretskii <eliz@gnu.org>
13653
13654 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13655 when at ZV. (Bug#8487)
13656
e7974947
AS
136572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13658
baad03f0
AS
13659 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13660 (Bug#8437)
13661 * keyboard.c (parse_tool_bar_item): Likewise.
13662 * sound.c (sound_cleanup, alsa_close): Likewise.
13663 * termcap.c (tgetent): Likewise.
13664 * xfns.c (x_default_font_parameter): Likewise.
13665 * xsettings.c (read_and_apply_settings): Likewise.
13666
e7974947
AS
13667 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13668 (overrun_check_free): Protoize.
13669
28272684
PE
136702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13671
13672 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13673 since callers should never pass a negative size.
13674 Change the signature to match that of plain 'read' and 'write'; see
13675 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13676 * lisp.h: Update prototypes of emacs_write and emacs_read.
13677
11997c76
EZ
136782011-04-11 Eli Zaretskii <eliz@gnu.org>
13679
13680 * xdisp.c (redisplay_window): Don't try to determine the character
13681 position of the scroll margin if the window start point w->startp
e896f03c 13682 is outside the buffer's accessible region. (Bug#8468)
11997c76 13683
8a2cbd72
EZ
136842011-04-10 Eli Zaretskii <eliz@gnu.org>
13685
13686 Fix write-region and its subroutines for buffers > 2GB.
13687 * fileio.c (a_write, e_write): Modify declaration of arguments and
13688 local variables to support buffers larger than 2GB.
13689 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13690
13691 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13692 argument, local variables, and return value.
13693
13694 * lisp.h: Update prototypes of emacs_write and emacs_read.
13695
13696 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13697
4073e537 136982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13699
1ebfdcb6
PE
13700 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13701
b2ded58d
PE
13702 Fix more problems found by GCC 4.6.0's static checks.
13703
7d66342c
PE
13704 * xdisp.c (vmessage): Use a better test for character truncation.
13705
bbf47d44
PE
13706 * charset.c (load_charset_map): <, not <=, for optimization,
13707 and to avoid potential problems with integer overflow.
9248994d 13708 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13709 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13710 * editfns.c (Fformat): Likewise.
1e69125e 13711 * syntax.c (skip_chars): Likewise.
3befa583 13712
e3019616
PE
13713 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13714 This also lets GCC 4.6.0 generate slightly better loop code.
13715
becfa255
PE
13716 * callint.c (Fcall_interactively): <, not <=, for optimization.
13717 (Fcall_interactively): Count the number of arguments produced,
13718 not the number of arguments given. This is simpler and lets GCC
13719 4.6.0 generate slightly better code.
13720
dae0cd48
PE
13721 * ftfont.c: Distingish more carefully between FcChar8 and char.
13722 The previous code passed unsigned char * to a functions like
13723 strlen and xstrcasecmp that expect char *, which does not
13724 conform to the C standard.
13725 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13726 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13727 char * when the C standard requires it.
13728
76032d70
PE
13729 * keyboard.c (read_char): Remove unused var.
13730
eb3f1cc8
PE
13731 * eval.c: Port to Windows vsnprintf (Bug#8435).
13732 Include <limits.h>.
13733 (SIZE_MAX): Define if the headers do not.
13734 (verror): Do not give up if vsnprintf returns a negative count.
13735 Instead, grow the buffer. This ports to Windows vsnprintf, which
13736 does not conform to C99. Problem reported by Eli Zaretskii.
13737 Also, simplify the allocation scheme, by avoiding the need for
13738 calling realloc, and removing the ALLOCATED variable.
13739
70476b54
PE
13740 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13741
12020a9e
PE
13742 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13743 But keep the doprint source code for now, as we might revamp it
13744 and use it again (Bug#8435).
ea6c7ae6
PE
13745 * lisp.h (doprnt): Remove.
13746 * Makefile.in (base_obj): Remove doprnt.o.
13747 * deps.mk (doprnt.o): Remove.
13748
5fdb398c
PE
13749 error: Print 32- and 64-bit integers portably (Bug#8435).
13750 Without this change, on typical 64-bit hosts error ("...%d...", N)
13751 was used to print both 32- and 64-bit integers N, which relied on
13752 undefined behavior.
61bdb816 13753 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13754 * lisp.h (error, verror): Mark as printf-like functions.
13755 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13756 Report overflow in size calculations when allocating printf buffer.
13757 Do not truncate output string at its first null byte.
13758 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13759 Truncate the output at a character boundary, since vsnprintf does not
13760 do that.
13761 * charset.c (check_iso_charset_parameter): Convert internal
13762 character to string before calling 'error', since %c now has the
13763 printf meaning.
13764 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13765 overflow when computing char to be passed to 'error'. Do not
13766 pass Lisp_Object to 'error'; pass the integer instead.
13767 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13768 formatted with plain %d.
13769
b189fa66
PE
13770 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13771
bff87ef0
PE
13772 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13773
7e2cac20
PE
13774 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13775
ce4d90b5
PE
13776 * xterm.c (x_catch_errors): Remove duplicate declaration.
13777
266c9547
PE
13778 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13779
79c49ad2
PE
13780 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13781
368f4090
JM
137822011-04-10 Jim Meyering <meyering@redhat.com>
13783
13784 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13785 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13786 return ssize_t not "int", and use size_t as the buffer length.
13787 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13788 * gnutls.h: Update declarations.
13789 * process.c (read_process_output): Use ssize_t, to match.
13790 (send_process): Likewise.
13791
a32d4040
CY
137922011-04-09 Chong Yidong <cyd@stupidchicken.com>
13793
13794 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13795
8546720e 137962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13797
04f2d78b
CB
13798 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13799 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13800
8546720e
GM
13801 * xterm.c (handle_one_xevent):
13802 * xmenu.c (create_and_show_popup_menu):
13803 * xselect.c (x_decline_selection_request)
13804 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13805
0a2f5c1a 138062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13807
13808 Fix some uses of `int' instead of EMACS_INT.
13809 * search.c (string_match_1, fast_string_match)
13810 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13811 (scan_buffer, find_next_newline_no_quit)
13812 (find_before_next_newline, search_command, Freplace_match)
13813 (Fmatch_data): Make some `int' variables be EMACS_INT.
13814
13815 * xdisp.c (display_count_lines): 3rd argument and return value now
13816 EMACS_INT. All callers changed.
13817 (pint2hrstr): Last argument is now EMACS_INT.
13818
13819 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13820 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13821 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13822 (decode_coding_utf_16, decode_coding_emacs_mule)
13823 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13824 (decode_coding_ccl, decode_coding_charset)
13825 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13826 (decode_coding_iso_2022, decode_coding_emacs_mule)
13827 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13828 <char_offset, last_offset>: Declare EMACS_INT.
13829 (encode_coding_utf_8, encode_coding_utf_16)
13830 (encode_coding_emacs_mule, encode_invocation_designation)
13831 (encode_designation_at_bol, encode_coding_iso_2022)
13832 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13833 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13834 Declare EMACS_INT.
13835 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13836 (encode_invocation_designation): Last argument P_NCHARS is now
13837 EMACS_INT.
13838 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13839 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13840
13841 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13842 All users changed.
13843
13844 * ccl.c (Fccl_execute_on_string): Declare some variables
13845 EMACS_INT.
13846
8546720e 138472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13848
13849 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13850
4e19a977
CS
138512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13852
13853 * process.c (Fformat_network_address): Doc fix.
13854
87302331
R
138552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13856
ee7683eb 13857 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13858
cbb59342
CY
138592011-04-08 Chong Yidong <cyd@stupidchicken.com>
13860
13861 * keyboard.c (read_char): Call Lisp function help-form-show,
13862 instead of using internal_with_output_to_temp_buffer.
13863 (Qhelp_form_show): New var.
e0d38eeb 13864 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13865
13866 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13867
13868 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13869
e67a13ab
CY
138702011-04-06 Chong Yidong <cyd@stupidchicken.com>
13871
04f2d78b
CB
13872 * process.c (Flist_processes): Remove to Lisp.
13873 (list_processes_1): Delete.
e67a13ab 13874
973f782d
EZ
138752011-04-06 Eli Zaretskii <eliz@gnu.org>
13876
7c106b1e
EZ
13877 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13878
973f782d
EZ
13879 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13880
41cf7d1a 138812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13882
ca23cc88
PE
13883 Fix more problems found by GCC 4.6.0's static checks.
13884
f390e2d5
PE
13885 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13886
42eea0d0
PE
13887 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13888
b69769da 13889 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13890
f9541e84
PE
13891 * xdisp.c (vmessage): Mark as a printf-like function.
13892
13841b55
PE
13893 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13894
c136c10f
PE
13895 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13896
5e2d4a30
PE
13897 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13898 printf-like functions.
13899 (tiff_load): Add casts to remove these marks before passing them
13900 to system-supplied API.
13901
583f48b9
PE
13902 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13903
b25d760e
PE
13904 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13905 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13906 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13907 directly, rather than having caller test rule sign. This avoids
13908 some unnecessary tests.
13909 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13910 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13911 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13912
bc7b6697 13913 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13914 (xfont_open): Avoid unnecessary tests.
bc7b6697 13915
27ccc379
PE
13916 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13917
dcd5c89a
PE
13918 * composite.h, composite.c (composition_gstring_put_cache):
13919 Use EMACS_INT, not int, for length.
13920
b13a45c6
PE
13921 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13922 breaking out part of COMPOSITION_DECODE_RULE.
13923 (COMPOSITION_DECODE_RULE): Use it.
13924 * composite.c (get_composition_id): Remove unused local vars,
13925 by using the new macro.
13926
1e792e4d
PE
13927 * textprop.c (set_text_properties_1): Change while to do-while,
13928 since the condition is always true at first.
13929
dc6c6455 13930 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13931 (interval_deletion_adjustment): Return unsigned value.
13932 All uses changed.
dc6c6455 13933
aba7731a
PE
13934 * process.c (list_processes_1, create_pty, read_process_output):
13935 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13936 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13937 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13938 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13939 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13940
fdfc4bf3
PE
13941 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13942
fca8fe46 13943 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13944 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13945
06a0259a 13946 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13947 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13948 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13949
e7b9e80f
PE
13950 * print.c (print_error_message): Avoid int overflow.
13951
56201685
PE
13952 * font.c (font_list_entities): Redo for clarity,
13953 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13954
78834453 13955 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13956 (font_score): Avoid potential overflow in diff calculation.
78834453 13957
0bc0b309 13958 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13959 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13960
e610eaca
PE
13961 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13962
b895abce
PE
13963 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13964 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13965 can always succeed if overflow has undefined behavior.
13966
1f1d9321 13967 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13968 (wordify): Omit three unnecessary tests.
1f1d9321 13969
c59478bc
PE
13970 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13971 All callers changed. This avoids the need for an unused var.
13972
79b73827
PE
13973 * casefiddle.c (casify_region): Remove var that is set but not used.
13974
a4db5dfe
PE
13975 * dired.c (file_name_completion): Remove var that is set but not used.
13976
43aae36e
PE
13977 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13978
2a47c44d 13979 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13980 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13981
a37c69bf
PE
13982 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13983 Check for integer overflow on size calculations.
13984
328ab8e7
PE
13985 * buffer.c (Fprevious_overlay_change): Remove var that is set
13986 but not used.
13987
e5a2a5cb
PE
13988 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13989 Remove vars that are set but not used.
8d84a6eb 13990 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13991 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13992
a60e5f68
PE
13993 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13994
f661cb61 13995 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13996 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13997
f0397f5a
PE
13998 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13999 that are set but not used.
14000
8664db06 14001 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14002 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14003
6abdaa4a
PE
14004 * xselect.c (x_get_local_selection, x_handle_property_notify):
14005 Remove vars that are set but not used.
14006
0ce7538d 14007 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14008 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14009
9ae848fc
PE
14010 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14011 Remove var that is set but not used.
0b918413
PE
14012 (scroll_bar_windows_size): Now size_t, not int.
14013 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14014 Check for overflow.
9ae848fc 14015
a5a62657
PE
14016 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14017 (map_tty_color) [!defined MSDOS]: Likewise.
14018
5c5cdd39
PE
14019 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14020
66ebf983
PE
14021 * coding.c: Remove vars that are set but not used.
14022 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14023 All callers changed.
14024 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14025 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14026 (decode_coding_charset): Remove vars that are set but not used.
14027
1be4d761
PE
14028 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14029 that is set but not used.
14030
47553fa8
PE
14031 * print.c (print_object): Remove var that is set but not used.
14032
1f7196bf 14033 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14034 The gnulib version avoids calling malloc in the usual case,
14035 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14036 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14037 * filelock.c (current_lock_owner): Likewise.
14038 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14039 * sysdep.c: Include allocator.h, careadlinkat.h.
14040 (emacs_no_realloc_allocator): New static constant.
14041 (emacs_readlink): New function.
fdb61804
PE
14042 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14043 ../lib/careadlinkat.h.
d1fdcab7 14044
f84c17c7
SM
140452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14046
14047 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14048 first non-nil return value).
14049
ef3862ad
JD
140502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14051
14052 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14053 if not defined (Bug#8403).
14054
376a7006
JB
140552011-04-02 Juanma Barranquero <lekktu@gmail.com>
14056
14057 * xdisp.c (display_count_lines): Remove parameter `start',
14058 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14059 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14060 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14061 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14062 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14063 and thereabouts. All callers changed.
14064 (get_per_char_metric): Remove parameter `f', unused since
14065 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14066
6ca3801d
JM
140672011-04-02 Jim Meyering <meyering@redhat.com>
14068
14069 do not dereference NULL upon failed strdup
14070 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14071 (ns_get_family): Likewise.
14072
d8e2b5ba
JB
140732011-04-02 Juanma Barranquero <lekktu@gmail.com>
14074
14075 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14076
8c74fcbd
JD
140772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14078
14079 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14080 later (Bug#8403).
14081
7200d79c
SM
140822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14083
03408648 14084 Add lexical binding.
7200d79c 14085
03408648
SM
14086 * window.c (Ftemp_output_buffer_show): New fun.
14087 (Fsave_window_excursion):
14088 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14089
14090 * lread.c (lisp_file_lexically_bound_p): New function.
14091 (Fload): Bind Qlexical_binding.
14092 (readevalloop): Remove `evalfun' arg.
14093 Bind Qinternal_interpreter_environment.
14094 (Feval_buffer): Bind Qlexical_binding.
14095 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14096 Mark as dynamic.
14097 (syms_of_lread): Declare `lexical-binding'.
14098
14099 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14100
14101 * keyboard.c (eval_dyn): New fun.
14102 (menu_item_eval_property): Use it.
ca105506
SM
14103
14104 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14105
03408648
SM
14106 * fns.c (concat, mapcar1): Accept byte-code-functions.
14107
14108 * eval.c (Fsetq): Handle lexical vars.
14109 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14110 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14111 (FletX, Flet): Obey lexical binding.
14112 (Fcommandp): Handle closures.
14113 (Feval): New `lexical' arg.
14114 (eval_sub): New function extracted from Feval. Use it almost
14115 everywhere where Feval was used. Look up vars in lexical env.
14116 Handle closures.
14117 (Ffunctionp): Move from subr.el.
14118 (Ffuncall): Handle closures.
14119 (apply_lambda): Remove `eval_flags'.
14120 (funcall_lambda): Handle closures and new byte-code-functions.
14121 (Fspecial_variable_p): New function.
14122 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14123 but without exporting it to Lisp.
23aba0ea 14124
23aba0ea 14125 * doc.c (Fdocumentation, store_function_docstring):
03408648 14126 * data.c (Finteractive_form): Handle closures.
23aba0ea 14127
03408648
SM
14128 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14129 interactive spec.
ba83908c 14130
04f2d78b
CB
14131 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14132 New byte-codes.
03408648
SM
14133 (exec_byte_code): New function extracted from Fbyte_code to handle new
14134 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14135
03408648 14136 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14137
03408648 14138 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14139
e2abce01
JB
141402011-03-31 Juanma Barranquero <lekktu@gmail.com>
14141
14142 * xdisp.c (redisplay_internal): Fix prototype.
14143
63696a73 141442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14145
63696a73 14146 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14147 (try_scrolling): Use it when setting scroll_limit.
14148 Limit scrolling to 100 screen lines.
63696a73
EZ
14149 (redisplay_window): Even when falling back on "recentering",
14150 position point in the window according to scroll-conservatively,
14151 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14152
14153 (try_scrolling): When point is above the window, allow searching
14154 as far as scroll_max, or one screenful, to compute vertical
14155 distance from PT to the scroll margin position. This prevents
14156 try_scrolling from unnecessarily failing when
14157 scroll-conservatively is set to a value slightly larger than the
14158 window height. Clean up the case of PT below the margin at bottom
14159 of window: scroll_max can no longer be INT_MAX. When aggressive
14160 scrolling is in use, don't let point enter the opposite scroll
14161 margin as result of the scroll.
14162 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14163 threshold of 100 lines for never-recentering scrolling.
14164
e4cc2dfc
JB
141652011-03-31 Juanma Barranquero <lekktu@gmail.com>
14166
14167 * dispextern.h (move_it_by_lines):
14168 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14169 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14170 (message_log_check_duplicate): Remove parameters `prev_bol' and
14171 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14172 (redisplay_internal): Remove parameter `preserve_echo_area',
14173 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14174
14175 * indent.c (Fvertical_motion):
14176 * window.c (window_scroll_pixel_based, Frecenter):
14177 Don't pass `need_y_p' to `move_it_by_lines'.
14178
1c470562
SM
141792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14180
44f230aa
SM
14181 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14182 steal a few bits to be more compact.
14183 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14184 Remove unneeded casts.
14185
1c470562
SM
14186 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14187
888adce9
ZK
141882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14189
14190 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14191 binding" message (bug#7967).
14192
f838ed7b
PE
141932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14194
77861b95
PE
14195 Fix more problems found by GCC 4.6.0's static checks.
14196
de6dbc14
PE
14197 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14198 Remove unused local var.
14199
f838ed7b
PE
14200 * editfns.c (Fmessage_box): Remove unused local var.
14201
792c7b2b
PE
14202 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14203 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14204 Omit unused local vars.
c499e557 14205 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14206 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14207 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14208 Omit unused local var.
14209
ba0165e1
PE
14210 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14211 Don't assume string length fits in int.
32ad8845 14212 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14213 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14214
3c59b4c9
PE
14215 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14216 instead of alloca (Bug#8344).
14217
a3eed478 14218 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14219 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14220
eb4d412d
PE
14221 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14222
1658b401
PE
14223 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14224 concerns.
14225
14226 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14227
14228 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14229
9a2c6e05
PE
14230 * keyboard.c (syms_of_keyboard): Use the same style as later
14231 in this function when indexing through an array. This also
14232 works around GCC bug 48267.
14233
03d0a109
PE
14234 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14235
44f730c8
PE
14236 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14237
fe75f926
PE
14238 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14239 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14240
ffa8c828
PE
14241 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14242 This avoids undefined behavior on integer overflow, and is a bit
14243 more convenient anyway since it is compared to a size_t variable.
14244
c5101a77
PE
14245 Variadic C functions now count arguments with size_t, not int.
14246 This avoids an unnecessary limitation on 64-bit machines, which
14247 caused (substring ...) to crash on large vectors (Bug#8344).
14248 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14249 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14250 All variadic functions and their callers changed accordingly.
c5101a77
PE
14251 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14252 * data.c (arith_driver, float_arith_driver): Likewise.
14253 * editfns.c (general_insert_function): Likewise.
14254 * eval.c (struct backtrace.nargs, interactive_p)
14255 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14256 (funcall_lambda, mark_backtrace): Likewise.
14257 * fns.c (concat): Likewise.
14258 * frame.c (x_set_frame_parameters): Likewise.
14259 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14260 0 if not found, not -1. All callers changed.
14261
dd3f25f7
PE
14262 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14263 (stack_copy_size): Now size_t, not int.
14264 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14265
461c2ab9
JB
142662011-03-28 Juanma Barranquero <lekktu@gmail.com>
14267
14268 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14269 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14270 All callers changed.
14271
14272 * lisp.h (multibyte_char_to_unibyte):
14273 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14274 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14275 * character.h (CHAR_TO_BYTE8):
14276 * cmds.c (internal_self_insert):
14277 * editfns.c (general_insert_function):
14278 * keymap.c (push_key_description):
14279 * search.c (Freplace_match):
14280 * xdisp.c (message_dolog, set_message_1): All callers changed.
14281
f6d62986
SM
142822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14283
14284 * keyboard.c (safe_run_hook_funcall): New function.
14285 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14286 don't set the hook to nil, but remove the offending function instead.
14287 (Qcommand_hook_internal): Remove, unused.
14288 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14289 Vcommand_hook_internal.
14290
14291 * eval.c (enum run_hooks_condition): Remove.
14292 (funcall_nil, funcall_not): New functions.
14293 (run_hook_with_args): Call each function through a `funcall' argument.
14294 Remove `cond' argument, now redundant.
14295 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14296 (Frun_hook_with_args_until_failure): Adjust accordingly.
14297 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14298
1db5b1ad
JB
142992011-03-28 Juanma Barranquero <lekktu@gmail.com>
14300
14301 * dispextern.h (string_buffer_position): Remove declaration.
14302
14303 * print.c (strout): Remove parameter `multibyte', unused since
14304 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14305
14306 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14307 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14308 All callers changed.
14309
14310 * w32.c (_wsa_errlist): Use braces for struct initializers.
14311
14312 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14313 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14314 All callers changed.
14315 (string_buffer_position): Likewise. Also, make static (it's never
14316 used outside xdisp.c).
14317 (cursor_row_p): Remove parameter `w', unused since
14318 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14319 (decode_mode_spec): Remove parameter `precision', introduced during
14320 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14321 All callers changed.
14322
5ffb62aa
JD
143232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14324
14325 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14326
461c2ab9 143272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14328
14329 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14330 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14331 (ns_update_auto_hide_menu_bar): New functions.
14332 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14333 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14334 ns_constrain_all_frames.
14335 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14336 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14337
5c380ffb
JD
143382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14339
14340 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14341
9af30bdf
GM
143422011-03-27 Glenn Morris <rgm@gnu.org>
14343
14344 * syssignal.h: Replace RETSIGTYPE with void.
14345 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14346 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14347 Replace SIGTYPE with void everywhere.
14348 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14349 * s/template.h (SIGTYPE): Remove commented out definition.
14350
e2abce01
JB
143512011-03-26 Eli Zaretskii <eliz@gnu.org>
14352
14353 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14354 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14355
f868cd8a
JB
143562011-03-26 Juanma Barranquero <lekktu@gmail.com>
14357
59eb0929
JB
14358 * w32.c (read_unc_volume): Use parameter `henum', instead of
14359 global variable `wget_enum_handle'.
14360
14361 * keymap.c (describe_vector): Remove parameters `indices' and
14362 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14363 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14364
f868cd8a
JB
14365 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14366
14367 * keyboard.c (timer_check): Remove parameter `do_it_now',
14368 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14369 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14370 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14371
14372 * keyboard.c (read_char):
14373 * w32menu.c (w32_menu_display_help):
14374 * xmenu.c (show_help_event, menu_help_callback):
14375 Adjust calls to `show_help_echo'.
14376
14377 * gtkutil.c (xg_maybe_add_timer):
14378 * keyboard.c (readable_events):
14379 * process.c (wait_reading_process_output):
14380 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14381
14382 * insdel.c (adjust_markers_gap_motion):
14383 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14384 (gap_left, gap_right): Don't call it.
14385
2ecf6fdb
CY
143862011-03-25 Chong Yidong <cyd@stupidchicken.com>
14387
14388 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14389 incurred during fontification.
14390
6b1f9ba4
JB
143912011-03-25 Juanma Barranquero <lekktu@gmail.com>
14392
14393 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14394 (DEFVAR_PER_BUFFER): Don't pass it.
14395
14396 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14397 (scrolling_window): Don't pass it.
14398
0f4a96b5
JB
143992011-03-25 Juanma Barranquero <lekktu@gmail.com>
14400
14401 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14402
14403 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14404 and `suffix'.
14405 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14406 of variables specific to SELinux and computation of `encoded_absname'.
14407
14408 * image.c (XPutPixel): Remove unused variable `height'.
14409
14410 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14411
14412 * unexw32.c (get_section_info): Remove unused variable `section'.
14413
14414 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14415 (system_process_attributes): Remove unused variable `sess'.
14416 (sys_read): Remove unused variable `err'.
14417
14418 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14419 (w32_wnd_proc): Remove unused variable `isdead'.
14420 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14421 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14422 (x_create_tip_frame): Remove unused variable `tem'.
14423
14424 * w32inevt.c (w32_console_read_socket):
14425 Remove unused variable `no_events'.
14426
14427 * w32term.c (x_draw_composite_glyph_string_foreground):
14428 Remove unused variable `width'.
14429
1149507c
JB
144302011-03-24 Juanma Barranquero <lekktu@gmail.com>
14431
14432 * w32term.c (x_set_glyph_string_clipping):
14433 Don't pass uninitialized region to CombineRgn.
14434
9c88f339
JB
144352011-03-23 Juanma Barranquero <lekktu@gmail.com>
14436
14437 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14438 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14439 (Fx_close_connection): Remove unused variable `i'.
14440
14441 * w32font.c (w32font_draw): Return number of glyphs.
14442 (w32font_open_internal): Remove unused variable `i'.
14443 (w32font_driver): Add missing initializer.
14444
14445 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14446 (fill_in_menu): Remove unused variable `items_added'.
14447
14448 * w32term.c (last_mouse_press_frame): Remove static global variable.
14449 (w32_clip_to_row): Remove unused variable `f'.
14450 (x_delete_terminal): Remove unused variable `i'.
14451
14452 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14453 (NOTHING): Remove unused static global variable.
14454 (uniscribe_check_otf): Remove unused variable `table'.
14455 (uniscribe_font_driver): Add missing initializers.
14456
dee091a3
JD
144572011-03-23 Julien Danjou <julien@danjou.info>
14458
14459 * term.c (Fsuspend_tty, Fresume_tty):
14460 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14461 * window.c (temp_output_buffer_show):
14462 * insdel.c (signal_before_change):
14463 * frame.c (Fhandle_switch_frame):
14464 * fileio.c (Fdo_auto_save):
14465 * emacs.c (Fkill_emacs):
14466 * editfns.c (save_excursion_restore):
14467 * cmds.c (internal_self_insert):
14468 * callint.c (Fcall_interactively):
14469 * buffer.c (Fkill_all_local_variables):
14470 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14471 Use Frun_hooks.
0f4a96b5 14472 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14473 unconditionally since it does the check itself.
dee091a3 14474
2c520ab5 144752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14476
c9c49752
PE
14477 Fix more problems found by GCC 4.5.2's static checks.
14478
8abc3f12
PE
14479 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14480 the first time through the loop, since we know p0 < p1 then.
14481 This also avoids a gcc -Wstrict-overflow warning.
14482
a2d26660
PE
14483 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14484 leading to a memory leak, possible in functions like
14485 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14486 of objects (Bug#8318).
a2d26660 14487
916c72e9
PE
14488 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14489 that could (at least in theory) be that large.
14490
19ab8a18
PE
14491 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14492 This is less likely to overflow, and avoids undefined behavior if
14493 overflow does occur. All callers changed. Use strtoul to scan
14494 for the unsigned long integer.
b7cbbd6f
PE
14495 (pint2hrstr): Simplify and tune code slightly.
14496 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14497
f0641eff
PE
14498 * scroll.c (do_scrolling): Work around GCC bug 48228.
14499 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14500
7f650bb9
PE
14501 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14502 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14503 (validate_x_resource_name): Simplify count usage.
14504 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14505
37dd57d1
PE
14506 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14507 fail (Bug#8306).
81e56e61 14508
699979fc 14509 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14510
401bf9b4
PE
14511 * process.c (Fmake_network_process): Use socklen_t, not int,
14512 where POSIX says socklen_t is required in portable programs.
14513 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14514 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14515 (Fmake_network_process, server_accept_connection):
14516 (wait_reading_process_output, read_process_output):
14517 Likewise.
14518
b93aacde
PE
14519 * process.c: Rename or move locals to avoid shadowing.
14520 (list_processes_1, Fmake_network_process):
14521 (read_process_output_error_handler, exec_sentinel_error_handler):
14522 Rename or move locals.
4dc343ee 14523 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14524 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14525 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14526 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14527 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14528
af8a867c 14529 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14530 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14531 Include tparam.h instead, since it declares them.
af8a867c
PE
14532 * cm.h (PC): Remove extern decl; tparam.h now does this.
14533 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14534 * terminfo.c: Include tparam.h, to check interfaces.
14535 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14536 (tparam): Adjust signature to match interface in tparam.h;
14537 this removes some undefined behavior. Check that outstring and len
14538 are zero, which they always are with Emacs.
14539 * tparam.h (PC, BC, UP): New extern decls.
14540
0248044d 14541 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14542 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14543
8ff096c1 14544 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14545 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14546 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14547 (ftfont_list): Remove unused local.
49eaafba
PE
14548 (get_adstyle_property, ftfont_pattern_entity):
14549 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14550 Rename locals to avoid shadowing.
8ff096c1 14551
e2be39f6
PE
14552 * xfont.c (xfont_list_family): Mark var as initialized.
14553
c9735e30
PE
14554 * xml.c (make_dom): Now static.
14555
8f5201ae
PE
14556 * composite.c (composition_compute_stop_pos): Rename local to
14557 avoid shadowing.
b246f932
PE
14558 (composition_reseat_it): Remove unused locals.
14559 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14560 (composition_update_it): Mark var as initialized.
11b61122
PE
14561 (find_automatic_composition): Mark vars as initialized,
14562 with a FIXME (Bug#8290).
8f5201ae 14563
760fbc2c
PE
14564 character.h: Rename locals to avoid shadowing.
14565 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14566 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14567 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14568 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14569 to avoid shadowing.
14570
ff08eb85
PE
14571 * textprop.c (property_change_between_p): Remove; unused.
14572
fc7bf025
PE
14573 * intervals.c (interval_start_pos): Now static.
14574
235d7abc
PE
14575 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14576
44f230aa
SM
14577 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14578 Rename locals to avoid shadowing.
3e7d6594 14579
50060332
PE
14580 * sound.c (wav_play, au_play, Fplay_sound_internal):
14581 Fix pointer signedness.
d01f234b 14582 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14583 (wav_play): Initialize a variable to 0, to prevent undefined
14584 behavior (Bug#8278).
50060332 14585
c4fc4e30
PE
14586 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14587
918436ed
PE
14588 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14589
c939f91b
PE
14590 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14591 clobbering (Bug#8298).
b9c7f648
PE
14592 * sysdep.c (sys_subshell): Likewise.
14593 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14594
6bd8c144
PE
14595 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14596 This should get cleaned up, so that child_setup has the
14597 same signature on all platforms.
14598
7710357c 14599 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14600 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14601
c59da222
CY
146022011-03-22 Chong Yidong <cyd@stupidchicken.com>
14603
14604 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14605 not to be necessary, and produces flickering.
14606
66b87493
GM
146072011-03-20 Glenn Morris <rgm@gnu.org>
14608
14609 * config.in: Remove file.
14610
45b6f6d5
JB
146112011-03-20 Juanma Barranquero <lekktu@gmail.com>
14612
14613 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14614 are now in src/globals.h.
14615 (syms_of_minibuf): Remove spurious & from previous change.
14616
cd394be1 146172011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14618
14619 * minibuf.c (completing-read-function): New variable.
14620 (completing-read-default): Rename from completing-read.
14621 (completing-read): Call completing-read-function.
14622
b14e3e21
CY
146232011-03-19 Juanma Barranquero <lekktu@gmail.com>
14624
14625 * xfaces.c (Fx_load_color_file):
14626 Read color file from absolute filename (bug#8250).
14627
f2b726e6
JB
146282011-03-19 Juanma Barranquero <lekktu@gmail.com>
14629
14630 * makefile.w32-in: Update dependencies.
14631
09f6ff02
EZ
146322011-03-17 Eli Zaretskii <eliz@gnu.org>
14633
14634 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14635
29a6015a
PE
146362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14637
a3a6c54e
PE
14638 Fix more problems found by GCC 4.5.2's static checks.
14639
b766f867
PE
14640 * process.c (make_serial_process_unwind, send_process_trap):
14641 (sigchld_handler): Now static.
14642
be02381c
PE
14643 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14644 That way, the code declares only the vars that it needs.
14645 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14646 * s/cygwin.h (PTY_ITERATION): Likewise.
14647 * s/darwin.h (PTY_ITERATION): Likewise.
14648 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14649
57048744
PE
14650 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14651 * process.c (allocate_pty): Don't declare stb unless it's needed.
14652
7914961c 14653 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14654 (CONSTANTLIM): Remove; unused.
14655 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14656 Define only if needed.
7914961c 14657
b3967b18
PE
14658 * unexelf.c (unexec): Name an expression,
14659 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14660 Use a different way to cause a compilation error if anyone uses
14661 n rather than nn, a way that does not involve shadowing.
73366a00 14662 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14663
29a6015a
PE
14664 * deps.mk (unexalpha.o): Remove; unused.
14665
43cfc33e 14666 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14667 * unexec.h: New file.
ce701a33
PE
14668 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14669 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14670 Depend on unexec.h.
14671 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14672 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14673 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14674 Change as necessary to match prototype in unexec.h.
ce701a33 14675
01f44d5a
PE
14676 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14677 shadowing.
4f63c6bb 14678 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14679
a6670b0b
PE
14680 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14681 Rename locals to avoid shadowing.
14682
cef2010d 14683 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14684 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14685
d4d7173a
PE
14686 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14687
f08b802a
PE
14688 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14689 warning when compiling print.c.
14690
3ddb0639
PE
14691 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14692 instead of using an uninitialized var.
5ad03b97 14693 (font_sort_entities): Mark var as initialized.
3ddb0639 14694
170a2692
PE
14695 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14696
e663c700
PE
14697 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14698 pointers to constants.
89bc529a 14699 (font_parse_fcname): Remove unused vars.
7b81e2d0 14700 (font_delete_unmatched): Now static.
ea838e10 14701 (font_get_spec): Remove; unused.
13a547c6
PE
14702 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14703 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14704 Rename or move locals to avoid shadowing.
e663c700 14705
2a80c887 14706 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14707 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14708
1384fa33 14709 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14710 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14711
8b2c52e9
PE
14712 * alloc.c (mark_backtrace): Move decl from here ...
14713 * lisp.h: ... to here, so that it can be checked.
14714
475545b5 14715 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14716 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14717 (lisp_indirect_variable): Name an expression,
14718 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14719 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14720
b1349114 14721 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14722 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14723 Use const pointer when appropriate.
b1349114 14724
a2928364
PE
14725 * lisp.h (get_system_name, get_operating_system_release):
14726 Move decls here, to check interfaces.
14727 * process.c (get_operating_system_release): Move decl to lisp.h.
14728 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14729 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14730 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14731 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14732 (Fformat_time_string, Fencode_time, Finsert_char):
14733 (Ftranslate_region_internal, Fformat):
14734 Rename or remove local vars to avoid shadowing.
9710023e 14735 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14736
a415e694
PE
14737 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14738 avoid shadowing.
14739
8ef4622d
PE
14740 * lisp.h (eassert): Check that the argument compiles, even if
14741 ENABLE_CHECKING is not defined.
14742
946f9a5b
PE
14743 * data.c (Findirect_variable): Name an expression, to avoid
14744 gcc -Wbad-function-cast warning.
112396d6 14745 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14746 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14747 (Fmake_variable_buffer_local, Fmake_local_variable):
14748 Mark variables as initialized.
52746918 14749 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14750
e5aab7e7 14751 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14752 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14753 Rename locals to avoid shadowing.
dff45157
PE
14754 (mark_stack): Move local variables into the #ifdef region where
14755 they're used.
7bc26fdb
PE
14756 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14757 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14758 needed otherwise.
14759 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14760 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14761 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14762
e5aab7e7
PE
14763 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14764 avoids undefined behavior in theory.
14765
4da60324
PE
14766 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14767
88043301
PE
14768 Use functions, not macros, for up- and down-casing (Bug#8254).
14769 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14770 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14771 to use the following functions instead of these macros.
14772 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14773 EMACS_INT, since callers assume the returned value fits in int.
14774 (upcase1): Likewise, for UPCASE_TABLE.
14775 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14776 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14777 the race-condition problem in the old DOWNCASE.
88043301 14778
19ed5445
PE
14779 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14780 Rename locals to avoid shadowing.
14781 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14782 (regex_compile, re_search_2, re_match_2_internal):
14783 Remove unused local vars.
952db0d7
PE
14784 (FREE_VAR): Rewrite so as not to use empty "else",
14785 which gcc can warn about.
da053e48 14786 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14787 (RETALLOC_IF): Define only if needed.
14788 (WORDCHAR_P): Likewise. This one is never needed, but is used
14789 only in a comment talking about a compiler bug, so put inside
14790 the #if 0 of that comment.
14791 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14792 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14793 Remove; unused.
19ed5445 14794
1f3561e4 14795 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14796 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14797 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14798
ded6f8f7
PE
14799 * search.c (simple_search): Remove unused var.
14800
dbd37a95
PE
14801 * dired.c (compile_pattern): Move decl from here ...
14802 * lisp.h: ... to here, so that it can be checked.
14803 (struct re_registers): New forward decl.
14804
7e47afad
PE
14805 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14806
85f24f61
PE
14807 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14808 All uses changed.
14809 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14810 Rename locals to avoid shadowing.
5671df8f 14811 (Fvertical_motion): Mark locals as initialized.
85f24f61 14812
181aa2be 14813 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14814 (casify_region): Mark local as initialized.
181aa2be 14815
930d429c
PE
14816 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14817
7082eac6
PE
14818 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14819 New macros, so that the caller can use some names other than
14820 gcpro1, gcpro2, etc.
14821 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14822 of the new macros.
14823 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14824 argument, for consistency with GCPRO2_VAR, etc: it is now the
14825 prefix of the variable, not the variable itself. All uses
14826 changed.
38b2c076
PE
14827 * dired.c (directory_files_internal, file_name_completion):
14828 Rename locals to avoid shadowing.
14829
15206ed9
PE
14830 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14831 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14832 dired.c's scmp function, had undefined behavior.
14833 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14834 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14835 * buffer.h: ... to here, because these macros use current_buffer,
14836 and the new implementation with inline functions needs to have
14837 current_buffer in scope now, rather than later when the macros
14838 are used.
14839 (downcase, upcase1): New static inline functions.
14840 (DOWNCASE, UPCASE1): Reimplement using these functions.
14841 This avoids undefined behavior in expressions like
14842 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14843 from race conditions in accessing the global variables
14844 case_temp1 and case_temp2.
14845 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14846 * lisp.h (case_temp1, case_temp2): Remove their decls.
14847 * character.h (ASCII_CHAR_P): Move from here ...
14848 * lisp.h: ... to here, so that the inline functions mentioned
14849 above can use them.
14850
4a6bea26
PE
14851 * dired.c (directory_files_internal_unwind): Now static.
14852
f14b7e14
PE
14853 * fileio.c (file_name_as_directory, directory_file_name):
14854 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14855 Now static.
2893f146
PE
14856 (file_name_as_directory): Use const pointers when appropriate.
14857 (Fexpand_file_name): Likewise. In particular, newdir might
14858 point at constant storage, so make it a const pointer.
fd4ead52 14859 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14860 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14861 signedness issues.
f839df0c
PE
14862 (Fset_file_times, Finsert_file_contents, auto_save_error):
14863 Rename locals to avoid shadowing.
f14b7e14 14864
5716756e 14865 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14866 (Ftry_completion, Fall_completions): Rename or remove locals
14867 to avoid shadowing.
5716756e 14868
b4c3046a
PE
14869 * marker.c (bytepos_to_charpos): Remove; unused.
14870
b45db522
PE
14871 * lisp.h (verify_bytepos, count_markers): New decls,
14872 so that gcc does not warn that these functions aren't declared.
14873
85876d07
PE
14874 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14875 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14876 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14877 (copy_text): Remove unused local var.
85876d07 14878
03d78a21 14879 * filelock.c (within_one_second): Now static.
b3dd38ab 14880 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14881
5df8f01b
PE
14882 * buffer.c (fix_overlays_before): Mark locals as initialized.
14883 (fix_start_end_in_overlays): Likewise. This function should be
14884 simplified by using pointers-to-pointers, but that's a different
14885 matter.
b1d876f1 14886 (switch_to_buffer_1): Now static.
8f54f30a
PE
14887 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14888 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14889
a70072c9 14890 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14891 Fix pointer signedness issue.
edced198
PE
14892 (sys_subshell): Mark local as volatile if checking for lint,
14893 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14894 (MAXPATHLEN): Define only if needed.
a70072c9 14895
a0977c44
PE
14896 * process.c (serial_open, serial_configure): Move decls from here ...
14897 * systty.h: ... to here, so that they can be checked.
14898
a884fdcc
PE
14899 * fns.c (get_random, seed_random): Move extern decls from here ...
14900 * lisp.h: ... to here, so that they can be checked.
14901
604efe86 14902 * sysdep.c (reset_io): Now static.
b8950c94 14903 (wait_for_termination_signal): Remove; unused.
604efe86 14904
38fc62d9
PE
14905 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14906 (copy_keymap_item, append_key, push_text_char_description):
14907 Now static.
1004a21a 14908 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14909 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14910 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14911 (describe_map_tree):
14912 Rename locals to avoid shadowing.
38fc62d9 14913
2f2650da
PE
14914 * keyboard.c: Declare functions static if they are not used elsewhere.
14915 (echo_char, echo_dash, cmd_error, top_level_2):
14916 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14917 (read_char, kbd_buffer_get_event, make_lispy_position):
14918 (make_lispy_event, make_lispy_movement, apply_modifiers):
14919 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14920 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14921 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14922 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14923 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14924
a053e86c 14925 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14926 (mark_kboards): Move decl here ...
14927 * alloc.c (mark_kboards): ... from here.
a053e86c 14928
4752793e
PE
14929 * lisp.h (force_auto_save_soon): New decl.
14930
74f10ca7 14931 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14932 (DEFINE_DUMMY_FUNCTION): New macro.
14933 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14934 Use it.
c03cd23f
PE
14935 (main): Add casts to avoid warnings
14936 if GCC considers string literals to be constants.
74f10ca7 14937
022e70d4
PE
14938 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14939
59d6fe83
PE
14940 * dbusbind.c: Pointer signedness fixes.
14941 (xd_signature, xd_append_arg, xd_initialize):
14942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14943 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14944 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14945 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14946
78320123
PE
14947 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14948 if GCC considers string literals to be constants.
49cebcca 14949 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14950
35ac2a97
SM
149512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14952
fb103ca9
SM
14953 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14954 (print_preprocess, print_object): New macro to fix last change.
14955
35ac2a97
SM
14956 * print.c (print_preprocess): Don't forget font objects.
14957
62973b41
JB
149582011-03-16 Juanma Barranquero <lekktu@gmail.com>
14959
14960 * emacs.c (USAGE3): Doc fixes.
14961
0e48bb22
AS
149622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14963
14964 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14965 structure.
14966
7684e57b
JB
149672011-03-14 Juanma Barranquero <lekktu@gmail.com>
14968
14969 * lisp.h (VWindow_system, Qfile_name_history):
14970 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14971 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14972 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14973
14974 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14975 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14976
14977 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14978 * w32console.c (detect_input_pending, read_input_pending)
14979 (encode_terminal_code):
14980 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14981 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14982 (w32_system_caret_y, Qfile_name_history):
14983 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14984 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14985 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14986 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14987 * w32proc.c (Qlocal, report_file_error):
14988 * w32term.c (Vwindow_system, updating_frame):
14989 * w32uniscribe.c (initialized, uniscribe_font_driver):
14990 Remove unneeded extern declarations.
14991
2aa46d6c
CY
149922011-03-14 Chong Yidong <cyd@stupidchicken.com>
14993
c96bbc66 14994 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14995
cffc6f3b
CY
149962011-03-13 Chong Yidong <cyd@stupidchicken.com>
14997
14998 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14999 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15000 These macros can no longer be used for assignment.
15001
44f230aa
SM
15002 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15003 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15004 (record_buffer_markers, fetch_buffer_markers): New functions for
15005 recording and fetching special buffer markers.
15006 (set_buffer_internal_1, set_buffer_temp): Use them.
15007
15008 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15009
15010 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15011
15012 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15013 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15014
15015 * xdisp.c (hscroll_window_tree):
15016 (reconsider_clip_changes): Use PT instead of BUF_PT.
15017
d251f04b
EZ
150182011-03-13 Eli Zaretskii <eliz@gnu.org>
15019
15020 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15021 $(EMACS_ROOT)/lib/intprops.h.
15022
f0c77cd1
PE
150232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15024
3eca4629
PE
15025 Fix more problems found by GCC 4.5.2's static checks.
15026
7c86ee98
PE
15027 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15028 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15029 (xg_free_frame_widgets): Make it clear that a local variable is
15030 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15031 (gdk_window_get_screen): Make it clear that this macro is needed
15032 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15033 (int_gtk_range_get_value): New function, which avoids a diagnostic
15034 from gcc -Wbad-function-cast.
15035 (xg_set_toolkit_scroll_bar_thumb): Use it.
15036 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15037 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15038 (get_utf8_string, xg_get_file_with_chooser):
15039 Rename locals to avoid shadowing.
15040 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15041
41729b81
PE
15042 * xgselect.c (xg_select): Remove unused var.
15043
f0c77cd1
PE
15044 * image.c (four_corners_best): Mark locals as initialized.
15045 (gif_load): Initialize transparent_p to zero (Bug#8238).
15046 Mark another local as initialized.
ec6cf4c6 15047 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15048
ce0ad53d 15049 * image.c (clear_image_cache): Now static.
d5d5a617 15050 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15051 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15052 (x_edge_detection): Remove unnecessary cast that
15053 gcc -Wbad-function-cast diagnoses.
2037898d 15054 (gif_load): Fix pointer signedness.
6ae141d6
PE
15055 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15056 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15057
33383987 150582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15059
d32df629
PE
15060 Improve quality of tests for time stamp overflow.
15061 For example, without this patch (encode-time 0 0 0 1 1
15062 1152921504606846976) returns the obviously-bogus value (-948597
15063 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15064 reports time overflow. See
15065 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15066 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15067 * editfns.c: Include limits.h and intprops.h.
15068 (TIME_T_MIN, TIME_T_MAX): New macros.
15069 (time_overflow): Move earlier, to before first use.
15070 (hi_time, lo_time): New functions, for an accurate test for
15071 out-of-range times.
15072 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15073 (Fget_internal_run_time): Don't assume time_t fits in int.
15074 (make_time): Use list2 instead of Fcons twice.
15075 (Fdecode_time): More accurate test for out-of-range times.
15076 (check_tm_member): New function.
15077 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15078 (lisp_time_argument): Don't rely on undefined left-shift and
15079 right-shift behavior when checking for time stamp overflow.
8be6f318 15080
fe31d94c
PE
15081 * editfns.c (time_overflow): New function, refactoring common code.
15082 (Fformat_time_string, Fdecode_time, Fencode_time):
15083 (Fcurrent_time_string): Use it.
15084
8be6f318
PE
15085 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15086 * dired.c (make_time): Move to ...
15087 * editfns.c (make_time): ... here.
15088 * systime.h: Note the move.
15089
09d9db2c 150902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15091
126bc0dc
YM
15092 * fringe.c (update_window_fringes): Remove unused variables.
15093
c47cbdfd
YM
15094 * unexmacosx.c (copy_data_segment): Also copy __got section.
15095 (Bug#8223)
15096
7ac80be9
EZ
150972011-03-12 Eli Zaretskii <eliz@gnu.org>
15098
c96bbc66 15099 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15100 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15101 Constify `char *' arguments and their references according to
15102 prototypes in tparam.h.
15103
ecb0f94d 15104 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15105
7ac80be9
EZ
15106 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15107 Adapt all references accordingly.
15108
15109 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15110
ef1fd07e
TT
151112011-03-11 Tom Tromey <tromey@redhat.com>
15112
15113 * buffer.c (syms_of_buffer): Remove obsolete comment.
15114
7ef4b50c
EZ
151152011-03-11 Eli Zaretskii <eliz@gnu.org>
15116
15117 * termhooks.h (encode_terminal_code): Declare prototype.
15118
15119 * msdos.c (encode_terminal_code): Don't declare prototype.
15120
15121 * term.c (encode_terminal_code): Now external again, used by
15122 w32console.c and msdos.c.
15123
44f230aa
SM
15124 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15125 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15126
4b1ec863 151272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15128
1714f52b 15129 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15130
4b1ec863
PE
15131 * fringe.c (update_window_fringes): Mark locals as initialized
15132 (Bug#8227).
15133 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15134
524c7aa6
PE
15135 * alloc.c (mark_fringe_data): Move decl from here ...
15136 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15137 to check its interface.
15138 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15139
a5c0af81 15140 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15141 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15142 (fontset_font): Mark local as initialized.
a9a06e0b 15143 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15144
b4716021
PE
15145 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15146
811e9bac 15147 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15148 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15149 (x_own_selection, Fx_disown_selection_internal): Rename locals
15150 to avoid shadowing.
15151 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15152
7e3ab302
PE
15153 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15154 so that the caller can use some name other than gcpro1.
15155 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15156 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15157 (Fx_backspace_delete_keys_p):
15158 Use them to avoid shadowing, and rename vars to avoid shadowing.
15159 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15160 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15161 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15162 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15163 Remove unused locals.
7e3ab302
PE
15164 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15165 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15166 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15167 macros.
f78faa98 15168
e2b13473
PE
15169 * xterm.h (x_mouse_leave): New decl.
15170
77f23912
PE
15171 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15172 Remove unused functions.
cdf4ba58
PE
15173 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15174 (x_calc_absolute_position): Now static.
7411c686 15175 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15176 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15177 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15178 unless they are used.
38d0b34a
PE
15179 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15180 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15181 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15182 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15183 (x_error_catcher, x_connection_closed, x_error_handler):
15184 (x_error_quitter, xembed_send_message, x_iconify_frame):
15185 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15186 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15187 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15188
44f230aa
SM
15189 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15190 Rename or move locals to avoid shadowing.
6b463e58 15191 (tty_defined_color, merge_face_heights): Now static.
5967d051 15192 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15193 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15194 does not deduce is never used uninitialized.
73719eba
PE
15195 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15196 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15197
426994c3 15198 * terminal.c (store_terminal_param): Now static.
5489860b 15199
032f1620 15200 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15201 (set_frame_menubar): Remove unused local.
d4323972 15202 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15203 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15204 since they might point to immutable storage.
281585b0
PE
15205 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15206 since it's unused otherwise.
032f1620 15207
367c19e5 15208 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15209 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15210 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15211 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15212 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15213 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15214 does not deduce are never used uninitialized.
70739cbe 15215
07b48fa9
PE
15216 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15217
8868a238 15218 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15219 * window.c (window_loop, size_window):
15220 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15221
7e5cf297 15222 * window.c (display_buffer): Now static.
d6550a9f
PE
15223 (size_window): Mark variables that gcc -Wuninitialized
15224 does not deduce are never used uninitialized.
a586633d
PE
15225 * window.h (check_all_windows): New decl, to forestall
15226 gcc -Wmissing-prototypes diagnostic.
5b555da1 15227 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15228
f6095868
PE
15229 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15230 shadowing.
15231 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15232 Include <limits.h>.
15233 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15234 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15235 (load_charset_map): Mark variables that gcc -Wuninitialized
15236 does not deduce are never used uninitialized.
53df7c11 15237 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15238
f38b440c
PE
15239 * coding.c (coding_set_source, coding_set_destination):
15240 Use "else { /* comment */ }" rather than "else /* comment */;"
15241 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15242 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15243 a block, when the outer 'i' will do.
15244 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15245 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15246 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15247 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15248 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15249 Rename locals to avoid shadowing.
15250 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15251 * coding.c (emacs_mule_char, encode_invocation_designation):
15252 Now static, since they're not used elsewhere.
413bb2db 15253 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15254 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15255 (decode_coding_emacs_mule): Mark variables that gcc
15256 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15257 (detect_coding_iso_2022): Initialize a local variable that might
15258 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15259 this initialization is needed. (Bug#8211)
5f58e762
PE
15260 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15261 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15262 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15263 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15264 Remove unused macros.
f38b440c 15265
232b38b9 15266 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15267 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15268 * character.c (string_count_byte8): Likewise.
232b38b9 15269
fb90da1b
PE
15270 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15271 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15272
fb93dbc2
PE
15273 * chartab.c (copy_sub_char_table): Now static, since it's not used
15274 elsewhere.
5c156ace
PE
15275 (sub_char_table_ref_and_range, char_table_ref_and_range):
15276 Rename locals to avoid shadowing.
bbcd0949 15277 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15278
7d3b3862 15279 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15280 (BIDI_BOB): Remove unused macro.
7d3b3862 15281
6be7d3da
PE
15282 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15283 deduce are never used uninitialized.
c2ed9c8b 15284 * term.c (encode_terminal_code): Likewise.
6be7d3da 15285
75f8807f 15286 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15287
50938595
PE
15288 * tparam.h: New file.
15289 * term.c, tparam.h: Include it.
15290 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15291 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15292 Move these decls to tparam.h, and make them agree with what
15293 is actually in tparam.c. The previous trick of using incompatible
15294 decls in different modules does not conform to the C standard.
15295 All callers of tparam changed to use tparam's actual API.
15296 * tparam.c (tparam1, tparam, tgoto):
15297 Use const pointers where appropriate.
15298
fbceeba2
PE
15299 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15300 * cm.h (struct cm): Likewise.
15301 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15302 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15303 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15304 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15305 (turn_on_face, init_tty): Likewise.
15306 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15307
7f3f1250
PE
15308 * term.c (term_mouse_position): Rename local to avoid shadowing.
15309
e6ca6543
PE
15310 * alloc.c (mark_ttys): Move decl from here ...
15311 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15312
c40f8d15
AS
153132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15314
15315 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15316
cfe0661d
JB
153172011-03-09 Juanma Barranquero <lekktu@gmail.com>
15318
15319 * search.c (compile_pattern_1): Remove argument regp, unused since
15320 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15321 (compile_pattern): Don't pass it.
15322
0afb4571
J
153232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15324
15325 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15326 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15327 for ! HAVE_GTK3.
15328 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15329
15330 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15331
15332 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15333 gdk_window_get_screen, gdk_window_get_geometry,
15334 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15335 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15336 (xg_get_pixbuf_from_pixmap): New function.
15337 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15338 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15339 Call xg_get_pixbuf_from_pixmap instead of
15340 gdk_pixbuf_get_from_drawable.
15341 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15342 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15343 (xg_check_special_colors): Use GtkStyleContext and its functions
15344 for HAVE_GTK3.
15345 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15346 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15347 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15348 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15349 Call gtk_widget_get_preferred_size.
0afb4571
J
15350 (xg_frame_resized): gdk_window_get_geometry only takes 5
15351 parameters.
44f230aa
SM
15352 (xg_win_to_widget, xg_event_is_for_menubar):
15353 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15354 (xg_set_widget_bg): New function.
15355 (delete_cb): New function.
895009e1 15356 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15357 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15358 (xg_set_background_color): Call xg_set_widget_bg.
15359 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15360 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15361 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15362 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15363 if ! HAVE_GTK3.
15364 (update_frame_tool_bar): Call gtk_widget_hide.
15365 (xg_initialize): Use GDK_KEY_g.
15366
15367 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15368 if ! HAVE_GTK3
15369 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15370
15371 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15372 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15373 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15374
1c2cc4ef
JB
153752011-03-08 Juanma Barranquero <lekktu@gmail.com>
15376
15377 * w32xfns.c (select_palette): Check success of RealizePalette against
15378 GDI_ERROR, not zero.
15379
33383987 15380See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15381
15382;; Local Variables:
15383;; coding: utf-8
aac0c6e3
MR
15384;; End:
15385
2f097256 15386 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15387
15388 This file is part of GNU Emacs.
15389
15390 GNU Emacs is free software: you can redistribute it and/or modify
15391 it under the terms of the GNU General Public License as published by
15392 the Free Software Foundation, either version 3 of the License, or
15393 (at your option) any later version.
15394
15395 GNU Emacs is distributed in the hope that it will be useful,
15396 but WITHOUT ANY WARRANTY; without even the implied warranty of
15397 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15398 GNU General Public License for more details.
15399
15400 You should have received a copy of the GNU General Public License
15401 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.