admin/MAINTAINERS: Added Bastien Guerry as current maintainer of Org
[bpt/emacs.git] / src / ChangeLog
CommitLineData
476371c4
PE
12011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4 In other words, assume that every image size is allowed, on non-X
5 hosts. This assumption is probably wrong, but it lets Emacs compile.
6
f3fcc40d
AS
72011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8
9 * regex.c (re_iswctype): Convert return values to boolean.
10
350c992f
EZ
112011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
12
13 * xdisp.c (compute_display_string_pos): Don't use cached display
14 string position if the buffer had its restriction changed.
15 (Bug#9184)
16
5266b4bb
PE
172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
18
19 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
20
2573a837 212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 22
41f55ccd 23 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 24
39e378da
PE
25 * bidi.c: Integer size and overflow fixes.
26 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
27 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
28 (bidi_cache_find_level_change, bidi_cache_ensure_space)
29 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
30 (bidi_find_other_level_edge):
31 Use ptrdiff_t instead of EMACS_INT where either will do.
32 This works better on 32-bit hosts configured --with-wide-int.
33 (bidi_cache_ensure_space): Check for size-calculation overflow.
34 Use % rather than repeated addition, for better worst-case speed.
35 Don't set bidi_cache_size until after xrealloc returns, because it
36 might not return.
37 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
38 (bidi_cache_ensure_space): Also check that the bidi cache size
39 does not exceed that of the largest Lisp string or buffer. See Eli
40 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 41
5e927815
PE
42 * alloc.c (__malloc_size_t): Remove.
43 All uses replaced by size_t. See Andreas Schwab's note
44 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
45
ca4aa935
PE
46 * image.c: Improve checking for integer overflow.
47 (check_image_size): Assume that f is nonnull, since
48 it is always nonnull in practice. This is one less thing to
49 worry about when checking for integer overflow later.
50 (x_check_image_size): New function, which checks for integer
51 overflow issues inside X.
52 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
53 This removes the need for a memory_full check.
54 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
55 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
56 (xbm_read_bitmap_data): Change locals back to 'int', since
57 their values must fit in 'int'.
58 (xpm_load_image, png_load, tiff_load):
59 Invoke x_create_x_image_and_pixmap earlier,
60 to avoid much needless work if the image is too large.
61 (tiff_load): Treat overly large images as if
62 x_create_x_image_and_pixmap failed, not as malloc failures.
63 (gs_load): Use x_check_image_size.
64
5f8f9cc2
PE
65 * gtkutil.c: Omit integer casts.
66 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
67 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
68
5adf60bc
PE
69 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
70
c8907a93
PE
71 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
72 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
73 would wrongly return t on a 64-bit host.
74
e3c25c68
PE
75 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
76 The plain *_OVERFLOW macros run afoul of GCC bug 49705
77 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
78 and therefore cause GCC to emit a bogus diagnostic in some cases.
79
3f791afe
PE
80 * image.c: Integer signedness and overflow and related fixes.
81 This is not an exhaustive set of fixes, but it's time to
82 record what I've got.
83 (lookup_pixel_color, check_image_size): Remove redundant decls.
84 (check_image_size): Don't assume that arbitrary EMACS_INT values
85 fit in 'int', or that arbitrary 'double' values fit in 'int'.
86 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
87 (tiff_load, imagemagick_load_image):
88 Check for overflow in size calculations.
89 (x_create_x_image_and_pixmap): Remove unnecessary test for
90 xmalloc returning NULL; that can't happen.
91 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
92 (xpm_color_bucket): Use better integer hashing function.
93 (xpm_cache_color): Don't possibly over-allocate memory.
94 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
95 (gif_memory_source):
96 Use ptrdiff_t, not int or size_t, to record sizes.
97 (png_load): Don't assume values greater than 2**31 fit in 'int'.
98 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
99 either works, as we prefer signed integers.
100 (tiff_read_from_memory, tiff_write_from_memory):
101 Return tsize_t, not size_t, since that's what the TIFF API wants.
102 (tiff_read_from_memory): Don't fail simply because the read would
103 go past EOF; instead, return a short read.
104 (tiff_load): Omit no-longer-needed casts.
105 (Fimagemagick_types): Don't assume size fits into 'int'.
106
3cc5a532
PE
107 Improve hashing quality when configured --with-wide-int.
108 * fns.c (hash_string): New function, taken from sxhash_string.
109 Do not discard information about ASCII character case; this
110 discarding is no longer needed.
111 (sxhash-string): Use it. Change sig to match it. Caller changed.
112 * lisp.h: Declare it.
113 * lread.c (hash_string): Remove, since we now use fns.c's version.
114 The fns.c version returns a wider integer if --with-wide-int is
115 specified, so this should help the quality of the hashing a bit.
116
b312a492
PE
117 * emacs.c: Integer overflow minor fix.
118 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
119 Define only if GNU_LINUX.
120 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
121
dfd153ae
PE
122 * dispnew.c: Integer signedness and overflow fixes.
123 Remove unnecessary forward decls, that were a maintenance hassle.
124 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
125 All uses changed.
126 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
127 (scrolling_window): Use ptrdiff_t, not int, for byte count.
128 (prepare_desired_row, line_draw_cost):
129 Use int, not unsigned, where either works.
130 (save_current_matrix, restore_current_matrix):
131 Use ptrdiff_t, not size_t, where either works.
132 (init_display): Check for overflow more accurately, and without
133 relying on undefined behavior.
134
a81d11a3
PE
135 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
136 Remove, replacing with the new symbols in lisp.h. All uses changed.
137 * fileio.c (make_temp_name):
138 * filelock.c (lock_file_1, lock_file):
139 * xdisp.c (message_dolog):
140 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
141 Use pMd etc. instead.
142 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
143 replacing the pWIDE etc. symbols removed from editfns.c.
144
3300e6fd
PE
145 * keyboard.h (num_input_events): Now uintmax_t.
146 This is (very slightly) less likely to mess up due to wraparound.
147 All uses changed.
148
fd05c7e9
PE
149 * buffer.c: Integer signedness fixes.
150 (alloc_buffer_text, enlarge_buffer_text):
151 Use ptrdiff_t rather than size_t when either will do, as we prefer
152 signed integers.
153
903fe15d
PE
154 * alloc.c: Integer signedness and overflow fixes.
155 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
156 (__malloc_size_t): Default to size_t, not to int.
157 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
158 (Fgarbage_collect, mark_object_loop_halt, mark_object):
159 Prefer ptrdiff_t to size_t when either would do, as we prefer
160 signed integers.
161 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
162 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
163 Now const. Initialize with values that are in range even if char
164 is signed.
165 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
166 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
167 These functions do the right thing with sizes > 2**32.
168 (check_depth): Now ptrdiff_t, not int.
169 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
170 Adjust to new way of storing sizes. Check for size overflow bugs
171 in rest of code.
172 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
173 slightly wrong anyway, as it missed one instance of
174 XMALLOC_OVERRUN_CHECK_OVERHEAD.
175 (refill_memory_reserve): Omit needless cast to size_t.
176 (mark_object_loop_halt): Mark as externally visible.
177
ac82cc6a
PE
178 * xselect.c: Integer signedness and overflow fixes.
179 (Fx_register_dnd_atom, x_handle_dnd_message):
180 Use ptrdiff_t, not size_t, since we prefer signed.
181 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
182 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
183 x_dnd_atoms_size and x_dnd_atoms_length.
184
c2d1e36d
PE
185 * doprnt.c: Prefer signed to unsigned when either works.
186 * eval.c (verror):
187 * doprnt.c (doprnt):
188 * lisp.h (doprnt):
189 * xdisp.c (vmessage):
190 Use ptrdiff_t, not size_t, when using or implementing doprnt,
191 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
192 prefer signed arithmetic to avoid comparison confusion.
193 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
194 but is a bit tricky.
195
0e926e56
PE
196 Assume freestanding C89 headers, string.h, stdlib.h.
197 * data.c, doprnt.c, floatfns.c, print.c:
198 Include float.h unconditionally.
199 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
200 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
201 * regex.c: Likewise for stddef.h, string.h.
202 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
203 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
204 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
205 (STDC_HEADERS): Remove obsolete defines.
206 * sysdep.c: Include limits.h unconditionally.
207
9cfdb3ec
PE
208 Assume support for memcmp, memcpy, memmove, memset.
209 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
210 * regex.c (memcmp, memcpy):
211 Remove; we assume C89 now.
212
213 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
214 (__malloc_safe_bcopy): Remove; no longer needed.
215
cf950e6b 216 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
217 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
218 well either way, and we prefer signed to unsigned.
219
dbf38e02
LMI
2202011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
221
222 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
223 closes the connection while we're reading (bug#9182).
224
d6f0886c
JD
2252011-07-25 Jan Djärv <jan.h.d@swipnet.se>
226
227 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
228 are specified (Bug#9168).
229
2eb1f9e6
PE
2302011-07-25 Paul Eggert <eggert@cs.ucla.edu>
231
232 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
233 Found by GCC static checking and --with-wide-int on a 32-bit host.
234
22381272 2352011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
236
237 * xdisp.c (compute_display_string_pos): Fix logic of caching
238 previous display string position. Initialize cached_prev_pos to
239 -1. Fixes slow-down at the beginning of a buffer.
240
f25e39b4
EZ
2412011-07-24 Eli Zaretskii <eliz@gnu.org>
242
243 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
244 for attrs[LFACE_FONTSET_INDEX].
245
04c4b52e
PE
2462011-07-23 Paul Eggert <eggert@cs.ucla.edu>
247
248 * xml.c (parse_region): Remove unused local
249 that was recently introduced.
250
c1734fbd
EZ
2512011-07-23 Eli Zaretskii <eliz@gnu.org>
252
be18c5a5
EZ
253 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
254 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
255
c1734fbd
EZ
256 * xdisp.c (move_it_in_display_line_to): Record the best matching
257 position for TO_CHARPOS while scanning the line, and restore it on
258 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
259 vertical-motion and pos-visible-in-window-p under bidi redisplay
260 when exact match is impossible due to invisible text, and the
261 lines are truncated.
262
a258d627
JD
2632011-07-23 Jan Djärv <jan.h.d@swipnet.se>
264
265 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
266 for OSX >= 10.7.
267
b6d5a689
EZ
2682011-07-22 Eli Zaretskii <eliz@gnu.org>
269
0f74f785
EZ
270 Fix a significant slow-down of cursor motion with C-n, C-p,
271 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
272 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 273 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
274 (next_element_from_buffer): Call compute_stop_pos_backwards to
275 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
276 base_level_stop.
277 (reseat): Don't look for prev_stop, as that could mean a very long
278 run.
279 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
280 <cached_disp_overlay_modiff>: Cache for last found display string
281 position.
551918c1 282 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
283 about the same buffer in the same area of character positions, and
284 the buffer wasn't changed since the time the display string
285 position was cached.
551918c1 286
b2d0c91a
EZ
2872011-07-22 Eli Zaretskii <eliz@gnu.org>
288
289 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
290 is an integer, which is important for empty lines. (Bug#9149)
291
043604ee
CY
2922011-07-22 Chong Yidong <cyd@stupidchicken.com>
293
294 * frame.c (Fmodify_frame_parameters): In tty case, update the
295 default face if necessary (Bug#4238).
296
da4adb04
CY
2972011-07-21 Chong Yidong <cyd@stupidchicken.com>
298
299 * editfns.c (Fstring_to_char): No need to explain what a character
300 is in the docstring (Bug#6576).
301
9abd0532
LMI
3022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
303
304 * xml.c (parse_region): Make sure we always return a tree.
305
36881d16
HK
3062011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
307
308 * xml.c (parse_region): If a document contains only comments,
309 return that, too.
310
1e98674d
LMI
3112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
312
313 * xml.c (make_dom): Return comments, too.
314
590bd467
PE
3152011-07-19 Paul Eggert <eggert@cs.ucla.edu>
316
317 Port to OpenBSD.
318 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
319 and the surrounding thread.
320 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
321 rather than fgets, and retry after EINTR. Otherwise, 'emacs
322 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
323 timer goes off.
324 * s/openbsd.h (BROKEN_SIGIO): Define.
325 * unexelf.c (unexec) [__OpenBSD__]:
326 Don't update the .mdebug section of the Alpha COFF symbol table.
327
f41628b2
LMI
3282011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
329
330 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
331 (bug#8460).
332
b59b67c5
PE
3332011-07-18 Paul Eggert <eggert@cs.ucla.edu>
334
15e3a074
PE
335 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
336 This fixes some race conditions on the permissions of any newly
337 created file.
338
41bed37d
PE
339 * alloc.c (valid_pointer_p): Use pipe, not open.
340 This fixes some permissions issues when debugging.
341
b59b67c5
PE
342 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
343 If fchown fails to set both uid and gid, try to set just gid,
344 as that is sometimes allowed. Adjust the file's mode to eliminate
345 setuid or setgid bits that are inappropriate if fchown fails.
346
925a6be7
SM
3472011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
348
349 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
350 to compare Lisp_Objects.
351 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
352 global_gnutls_log_level, don't mistake it for a Lisp_Object.
353 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
354
52968808
AS
3552011-07-17 Andreas Schwab <schwab@linux-m68k.org>
356
0a6a104b
AS
357 * lread.c (read_integer): Unread even EOF character.
358 (read1): Likewise. Properly record start position of symbol.
359
52968808
AS
360 * lread.c (read1): Read `#:' as empty uninterned symbol if no
361 symbol character follows.
362
9e381cdd
PE
3632011-07-17 Paul Eggert <eggert@cs.ucla.edu>
364
365 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
366 This works around a problem with the previous change to Fcopy_file.
367 Recent glibc declares fchown with __attribute__((warn_unused_result)),
368 and without this change, GCC might complain about discarding
369 fchown's return value.
370
b5641435
JB
3712011-07-16 Juanma Barranquero <lekktu@gmail.com>
372
373 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
374
a8031457
PE
3752011-07-16 Paul Eggert <eggert@cs.ucla.edu>
376
377 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
378
dd889327
LMI
3792011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
380
750c33f7
LMI
381 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
382 it's used from the C level.
383
dd889327
LMI
384 * process.c: Use the same condition for POLL_FOR_INPUT in both
385 keyboard.c and process.c (bug#1858).
386
87e86684
LM
3872011-07-09 Lawrence Mitchell <wence@gmx.li>
388
389 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
390 (Fgnutls_boot): Use it.
391
64348f40
AS
3922011-07-15 Andreas Schwab <schwab@linux-m68k.org>
393
394 * doc.c (Fsubstitute_command_keys): Revert last change.
395
1d698799
LMI
3962011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
397
f863868c
LMI
398 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
399 quotes the next character, and doesn't affect other longer
400 sequences (bug#8935).
401
1d698799
LMI
402 * lread.c (syms_of_lread): Clarify that is isn't only
403 `eval-buffer' and `eval-defun' that's affected by
404 `lexical-binding' (bug#8460).
405
aa4b6df6
EZ
4062011-07-15 Eli Zaretskii <eliz@gnu.org>
407
408 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
409 bidi redisplay when a line includes both an image and is
410 truncated.
411
5d856da6
PE
4122011-07-14 Paul Eggert <eggert@cs.ucla.edu>
413
ad6042bb
PE
414 Fix minor problems found by static checking.
415 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
416 (elsz): Now a signed constant, not a size_t var. We prefer signed
417 types to unsigned, to avoid integer comparison confusion. Without
418 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
419 "cannot optimize loop, the loop counter may overflow", a symptom
420 of the confusion.
f00bbb22 421 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
422 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
423
6468f31c
LMI
4242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
425
49080b10
LMI
426 * search.c (Fre_search_backward): Mention `case-fold-search' in
427 all the re_search_* functions (bug#8138).
428
6468f31c
LMI
429 * keyboard.c (Fopen_dribble_file): Document when the file is
430 closed (bug#8056).
431
c965adc5
EZ
4322011-07-14 Eli Zaretskii <eliz@gnu.org>
433
df9733bf
EZ
434 * bidi.c (bidi_dump_cached_states): Fix format of displaying
435 bidi_cache_idx.
436
0bb23927
EZ
437 Support bidi reordering of display and overlay strings.
438 * xdisp.c (compute_display_string_pos)
439 (compute_display_string_end): Accept additional argument STRING.
440 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
441 (reseat_to_string): Initialize bidi_it->string.s and
442 bidi_it->string.schars.
443 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
444 NULL (avoids a crash in bidi_paragraph_init). Initialize
445 itb.string.lstring.
446 (init_iterator): Call bidi_init_it only of a valid
447 buffer position was specified. Initialize paragraph_embedding to
448 L2R.
449 (reseat_to_string): Initialize the bidi iterator.
450 (display_string): If we need to ignore text properties of
451 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
452 original value of -1 will not work with bidi.)
453 (compute_display_string_pos): First arg is now struct
454 `text_pos *'; all callers changed. Support display properties on
455 Lisp strings.
456 (compute_display_string_end): Support display properties on Lisp
457 strings.
458 (init_iterator, reseat_1, reseat_to_string): Initialize the
459 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
460 when iterating on a string not from display properties).
461 (compute_display_string_pos, compute_display_string_end): Fix
462 calculation of the object to scan. Fixes an error when using
463 arrow keys.
464 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
465 base_level_stop; instead, set base_level_stop to BEGV. Fixes
466 crashes in vertical-motion.
467 (next_element_from_buffer): Improve commentary for when
468 the iterator is before prev_stop.
469 (init_iterator): Initialize bidi_p from the default value of
470 bidi-display-reordering, not from buffer-local value. Use the
471 buffer-local value only if initializing for buffer iteration.
472 (handle_invisible_prop): Support invisible properties on strings
473 that are being bidi-reordered.
474 (set_iterator_to_next): Support bidi reordering of C strings and
475 Lisp strings.
476 (next_element_from_string): Support bidi reordering of Lisp
477 strings.
478 (handle_stop_backwards): Support Lisp strings as well.
479 (display_string): Support display of R2L glyph rows. Use
480 IT_STRING_CHARPOS when displaying from a Lisp string.
481 (init_iterator): Don't initialize it->bidi_p for strings
482 here.
483 (reseat_to_string): Initialize it->bidi_p for strings here.
484 (next_element_from_string, next_element_from_c_string)
485 (next_element_from_buffer): Add xassert's for correspondence
486 between IT's object being iterated and it->bidi_it.string
487 structure.
488 (face_before_or_after_it_pos): Support bidi iteration.
489 (next_element_from_c_string): Handle the case of the first string
490 character that is not the first one in the visual order.
491 (get_visually_first_element): New function, refactored from common
492 parts of next_element_from_buffer, next_element_from_string, and
493 next_element_from_c_string.
494 (tool_bar_lines_needed, redisplay_tool_bar)
495 (display_menu_bar): Force left-to-right direction. Add a FIXME
496 comment for making that be controlled by a user option.
497 (push_it, pop_it): Save and restore the state of the
498 bidi iterator. Save and restore the bidi_p flag.
499 (pop_it): Iterate out of display property for string iteration as
500 well.
501 (iterate_out_of_display_property): Support iteration over strings.
502 (handle_single_display_spec): Set up it->bidi_it for iteration
503 over a display string, and call bidi_init_it.
504 (handle_single_display_spec, next_overlay_string)
505 (get_overlay_strings_1, push_display_prop): Set up the bidi
506 iterator for displaying display or overlay strings.
507 (forward_to_next_line_start): Don't use the shortcut if
508 bidi-iterating.
509 (back_to_previous_visible_line_start): If handle_display_prop
510 pushed the iterator stack, restore the internal state of the bidi
511 iterator by calling bidi_pop_it same number of times.
512 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
513 and we are bidi-iterating, don't decrement the iterator position;
514 instead, set the first_elt flag in the bidi iterator, to produce
515 the same effect.
516 (reseat_1): Remove redundant setting of string_from_display_prop_p.
517 (push_display_prop): xassert that we are iterating a buffer.
518 (push_it, pop_it): Save and restore paragraph_embedding member.
519 (handle_single_display_spec, next_overlay_string)
520 (get_overlay_strings_1, reseat_1, reseat_to_string)
521 (push_display_prop): Set up the `unibyte' member of bidi_it.string
522 correctly. Don't assume unibyte strings are not bidi-reordered.
523 (compute_display_string_pos)
524 (compute_display_string_end): Fix handling the case of C string.
525 (push_it, pop_it): Save and restore from_disp_prop_p.
526 (handle_single_display_spec, push_display_prop): Set the
527 from_disp_prop_p flag.
528 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
529 (pop_it): Call iterate_out_of_display_property only if we are
530 popping after iteration over a string that came from a display
531 property. Fix a typo in popping stretch info. Add an assertion
532 for verifying that the iterator position is in sync with the bidi
533 iterator.
534 (handle_single_display_spec, get_overlay_strings_1)
535 (push_display_prop): Fix initialization of paragraph direction for
536 string when that of the parent object is not yet determined.
537 (reseat_1): Call bidi_init_it to resync the bidi
538 iterator with IT's position. (Bug#7616)
539 (find_row_edges): If ROW->start.pos gives position
540 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
541 (handle_stop, back_to_previous_visible_line_start, reseat_1):
542 Reset the from_disp_prop_p flag.
543 (SAVE_IT, RESTORE_IT): New macros.
544 (pos_visible_p, face_before_or_after_it_pos)
545 (back_to_previous_visible_line_start)
546 (move_it_in_display_line_to, move_it_in_display_line)
547 (move_it_to, move_it_vertically_backward, move_it_by_lines)
548 (try_scrolling, redisplay_window, display_line): Use them when
549 saving a temporary copy of the iterator and restoring it back.
550 (back_to_previous_visible_line_start, reseat_1)
551 (init_iterator): Empty the bidi cache "stack".
552 (move_it_in_display_line_to): If iterator ended up at
553 EOL, but we never saw any buffer positions smaller than
554 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
555 motion in bidi-reordered lines.
556 (move_it_in_display_line_to): Record prev_method and prev_pos
557 immediately before the call to set_iterator_to_next. Fixes cursor
558 motion in bidi-reordered lines with stretch glyphs and strings
559 displayed in margins. (Bug#8133) (Bug#8867)
560 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
561 TO_CHARPOS.
562 (pos_visible_p): Support positions in bidi-reordered lines. Save
563 and restore bidi cache.
564
565 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
566 (bidi_paragraph_info): Delete unused struct.
567 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
568 (bidi_cache_start): New variable.
569 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
570 to zero.
571 (bidi_cache_fetch_state, bidi_cache_search)
572 (bidi_cache_find_level_change, bidi_cache_iterator_state)
573 (bidi_cache_find, bidi_peek_at_next_level)
574 (bidi_level_of_next_char, bidi_find_other_level_edge)
575 (bidi_move_to_visually_next): Compare cache index with
576 bidi_cache_start rather than with zero.
577 (bidi_fetch_char): Accept new argument STRING; all callers
578 changed. Support iteration over a string. Support strings with
579 display properties. Support unibyte strings. Fix the type of
580 `len' according to what STRING_CHAR_AND_LENGTH expects.
581 (bidi_paragraph_init, bidi_resolve_explicit_1)
582 (bidi_resolve_explicit, bidi_resolve_weak)
583 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
584 iteration over a string.
585 (bidi_set_sor_type, bidi_resolve_explicit_1)
586 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
587 can now be zero (for strings); special values 0 and -1 were
588 changed to -1 and -2, respectively.
589 (bidi_char_at_pos): New function.
590 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
591 Call it instead of FETCH_MULTIBYTE_CHAR.
592 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
593 initialized to valid values.
594 (bidi_init_it): Don't initialize charpos and bytepos with invalid
595 values.
596 (bidi_level_of_next_char): Allow the sentinel "position" to pass
597 the test for valid cached positions. Fix the logic for looking up
598 the sentinel state in the cache. GCPRO the Lisp string we are
599 iterating.
600 (bidi_push_it, bidi_pop_it): New functions.
601 (bidi_initialize): Initialize the bidi cache start stack pointer.
602 (bidi_cache_ensure_space): New function, refactored from part of
603 bidi_cache_iterator_state. Don't assume the required size is just
604 one BIDI_CACHE_CHUNK away.
605 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
606 (bidi_count_bytes, bidi_char_at_pos): New functions.
607 (bidi_cache_search): Don't assume bidi_cache_last_idx is
608 always valid if bidi_cache_idx is valid.
609 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
610 is valid if it's going to be used.
611 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
612 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
613 (bidi_cache_find_level_change, bidi_cache_ensure_space)
614 (bidi_cache_iterator_state, bidi_cache_find)
615 (bidi_find_other_level_edge, bidi_cache_start_stack): All
616 variables related to cache indices are now EMACS_INT.
617
0bb23927
EZ
618 * dispextern.h (struct bidi_string_data): New structure.
619 (struct bidi_it): New member `string'. Make flag members be 1-bit
620 fields, and put them last in the struct.
621 (compute_display_string_pos, compute_display_string_end): Update
622 prototypes.
623 (bidi_push_it, bidi_pop_it): Add prototypes.
624 (struct iterator_stack_entry): New members bidi_p,
625 paragraph_embedding, and from_disp_prop_p.
626 (struct it): Member bidi_p is now a bit field 1 bit wide.
627 (bidi_shelve_cache, bidi_unshelve_cache): Declare
628 prototypes.
629
630 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
631 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
632 and vector-like objects.
633
634 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
635 cache around display iteration.
636
637 * window.c (Fwindow_end, window_scroll_pixel_based)
638 (displayed_window_lines, Frecenter): Save and restore the bidi
639 cache around display iteration.
640
3bbd2265
LMI
6412011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
642
643 * editfns.c (Fdelete_region): Clarify the use of the named
644 parameters (bug#6788).
645
adc47434
MR
6462011-07-14 Martin Rudalics <rudalics@gmx.at>
647
648 * indent.c (Fvertical_motion): Set and restore w->pointm when
649 saving and restoring the window's buffer (Bug#9006).
650
837c31f8
LMI
6512011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
652
653 * editfns.c (Fstring_to_char): Clarify just what is returned
654 (bug#6576). Text by Eli Zaretskii.
655
ac389d0c
JB
6562011-07-13 Juanma Barranquero <lekktu@gmail.com>
657
658 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
659
0be0ce47
EZ
6602011-07-13 Eli Zaretskii <eliz@gnu.org>
661
662 * buffer.c (mmap_find): Fix a typo.
663
cd18e7e3
JB
6642011-07-13 Johan Bockgård <bojohan@gnu.org>
665
666 Fix execution of x selection hooks.
667 * xselect.c (Qx_lost_selection_functions)
668 (Qx_sent_selection_functions): New vars.
669 (syms_of_xselect): DEFSYM them.
670 (x_handle_selection_request): Pass Qx_sent_selection_functions
671 rather than Vx_sent_selection_functions to Frun_hook_with_args.
672 (x_handle_selection_clear,x_clear_frame_selections):
673 Pass Qx_lost_selection_functions rather than
674 Vx_lost_selection_functions to Frun_hook_with_args.
675
47ea7f44
PE
6762011-07-13 Paul Eggert <eggert@cs.ucla.edu>
677
ac389d0c 678 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
679 The old code sometimes used this field without initializing it.
680
47ea7f44
PE
681 * alloc.c (gc_sweep): Don't read past end of array.
682 In theory, the old code could also have corrupted Emacs internals,
683 though it'd be very unlikely.
684
bc985c87
AS
6852011-07-12 Andreas Schwab <schwab@linux-m68k.org>
686
687 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 688 argument. (Bug#4026)
bc985c87 689
0cf34688
LMI
6902011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
691
b3dadd76
LMI
692 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
693 key" (bug#4257).
694
0cf34688
LMI
695 * window.c (Fset_window_start): Doc fix (bug#4199).
696 (Fset_window_hscroll): Ditto.
697
270768cd
PE
6982011-07-12 Paul Eggert <eggert@cs.ucla.edu>
699
077e3dda 700 Fix minor new problems caught by GCC 4.6.1.
270768cd 701 * term.c (init_tty): Remove unused local.
490011a6 702 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 703 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 704 not used otherwise.
270768cd 705
b1f58454
CY
7062011-07-12 Chong Yidong <cyd@stupidchicken.com>
707
708 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
709
22b9578d
LMI
7102011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
711
6e70ab07
LMI
712 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
713 are the mini-buffer and the echo area (bug#3320).
714
22b9578d
LMI
715 * term.c (init_tty): Remove support for supdup, c10 and perq
716 terminals, which are no longer supported (bug#1482).
717
8974cc9f
JB
7182011-07-10 Johan Bockgård <bojohan@gnu.org>
719
720 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
721
a560d974
JD
7222011-07-10 Jan Djärv <jan.h.d@swipnet.se>
723
724 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
725 for non-popups (Bug#3642).
726
1dae0f0a
AS
7272011-07-10 Andreas Schwab <schwab@linux-m68k.org>
728
268c2c36 729 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 730 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
731 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
732 * cm.c (losecursor): Likewise.
1dae0f0a
AS
733 * data.c (fmod): Likewise.
734 * dispnew.c (swap_glyphs_in_rows): Likewise.
735 * emacs.c (memory_warning_signal): Likewise.
736 * floatfns.c (float_error): Likewise.
737 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
738 (otf_open, font_otf_capability, generate_otf_features)
739 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
740 Likewise.
741 * image.c (pbm_read_file): Likewise.
742 * indent.c (string_display_width): Likewise.
743 * intervals.c (check_for_interval, search_for_interval)
744 (inc_interval_count, count_intervals, root_interval)
745 (adjust_intervals_for_insertion, make_new_interval): Likewise.
746 * lread.c (defalias): Likewise.
268c2c36 747 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
748 * regex.c (set_image_of_range_1, set_image_of_range)
749 (regex_grow_registers): Likewise.
750 * sysdep.c (strerror): Likewise.
751 * termcap.c (valid_filename_p, tprint, main): Likewise.
752 * tparam.c (main): Likewise.
753 * unexhp9k800.c (run_time_remap, save_data_space)
754 (update_file_ptrs, read_header, write_header, calculate_checksum)
755 (copy_file, copy_rest, display_header): Likewise.
756 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
757 Likewise.
758 * xdisp.c (check_it): Likewise.
759 * xfaces.c (register_color, unregister_color, unregister_colors):
760 Likewise.
761 * xfns.c (print_fontset_result): Likewise.
762 * xrdb.c (member, fatal, main): Likewise.
763
99033785
PE
7642011-07-10 Paul Eggert <eggert@cs.ucla.edu>
765
766 Fix minor problems found by static checking (Bug#9031).
767 * chartab.c (char_table_set_range, map_sub_char_table):
768 Remove unused locals.
769 (uniprop_table): Now static.
770 * composite.c (_work_char): Remove unused static var.
771
9cb2ac56
JB
7722011-07-09 Juanma Barranquero <lekktu@gmail.com>
773
774 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
775
f25661f0
JD
7762011-07-09 Jan Djärv <jan.h.d@swipnet.se>
777
778 * gtkutil.c (qttip_cb): Remove code without function.
779
8278c4fe
EZ
7802011-07-09 Eli Zaretskii <eliz@gnu.org>
781
782 * w32.c (pthread_sigmask): New stub.
783
1692ae2d 7842011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 785
8a6ebd58 786 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
787 sigprocmask is portable only for single-threaded applications, and
788 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
789 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
790 (LIBES): Use it.
791 * callproc.c (Fcall_process):
792 * process.c (create_process):
793 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
794 Use pthread_sigmask, not sigprocmask.
123403e4 795
1b854618
JD
7962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
797
798 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
799 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
800 wrong (Bug#8591).
801
3fe4b549
JD
8022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
803
0ce7e563
JD
804 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
805 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
806 (xg_hide_tooltip): Fix comment.
807
3fe4b549
JD
808 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
809 in registerServicesMenuSendTypes.
810 (validRequestorForSendType): Don't check ns_return_types.
811
812 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
813 ns_return_type.
814
5df75e47
JR
8152011-07-08 Jason Rumney <jasonr@gnu.org>
816
817 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
818 frame struct members of non-existent frames (Bug#6284).
819
699c10bd
JD
8202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
821
4393663b
JD
822 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
823 variable firstTime not needed on OSX >= 10.6.
824 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
825 >= 10.5. Use setKnobProportion, setDoubleValue.
826
827 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
828 (MAC_OS_X_VERSION_10_5): Define if not defined.
829 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
830 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
831 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
832
833 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
834 cString and lossyCString on OSX >= 10.4
835
836 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
837 sizeToFit on OSX >= 10.2.
838
839 * nsimage.m (allocInitFromFile): Don't use deprecated method
840 bestRepresentationForDevice on OSX >= 10.6.
841
842 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
843 to avoid warning.
844
845 * emacs.c: Declare unexec_init_emacs_zone.
846
a63e0781
JD
847 * nsgui.h: Fix compiler warning about gnulib redefining verify.
848
699c10bd
JD
849 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
850
851 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
852 on svcsMenu (Bug#8842).
853
854 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
855 ns_return_types.
856 (Fns_list_services): Just return Qnil on 10.6, code not working there.
857
858 * nsterm.m (QUTF8_STRING): Declare.
859 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
860 (validRequestorForSendType): Return type is (id).
861 Change indexOfObjectIdenticalTo to indexOfObject.
862 Check if we have local selection before returning self (Bug#8842).
863 (writeSelectionToPasteboard): Put local selection into paste board
864 if we have a local selection (Bug#8842).
865 (syms_of_nsterm): DEFSYM QUTF8_STRING.
866
867 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
868 (ns_get_local_selection): Declare.
869
54e10184
LMI
8702011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
871
9888ff71
LMI
872 * keymap.c (describe_map_tree): Don't insert a double newline at
873 the end of the buffer (bug#1169) and return whether we inserted
874 something.
875
54e10184
LMI
876 * callint.c (Fcall_interactively): Change "reading args" to
877 "providing args" to try to clarify what it does (bug#1010).
878
15fa4783
KH
8792011-07-07 Kenichi Handa <handa@m17n.org>
880
881 * composite.c (composition_compute_stop_pos): Ignore a static
882 composition starting before CHARPOS (Bug#8915).
883
884 * xdisp.c (handle_composition_prop): Likewise.
885
a8815b00
EZ
8862011-07-07 Eli Zaretskii <eliz@gnu.org>
887
888 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
889 (Bug#9015)
890
ef7b981d 8912011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
892
893 * character.h (unicode_category_t): New enum type.
894
895 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
896 (Qchar_code_property_table): New variable.
897 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
898 (UNIPROP_COMPRESSED_FORM_P): New macros.
899 (char_table_ascii): Uncompress the compressed values.
900 (sub_char_table_ref): New arg is_uniprop. Callers changed.
901 Uncompress the compressed values.
ac389d0c 902 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
903 (char_table_ref_and_range): Uncompress the compressed values.
904 (sub_char_table_set): New arg is_uniprop. Callers changed.
905 Uncompress the compressed values.
906 (sub_char_table_set_range): Args changed. Callers changed.
907 (char_table_set_range): Adjuted for the above change.
908 (map_sub_char_table): Delete args default_val and parent. Add arg
909 top. Give decoded values to a Lisp function.
910 (map_char_table): Adjusted for the above change. Give decoded
911 values to a Lisp function. Gcpro more variables.
912 (uniprop_table_uncompress)
913 (uniprop_decode_value_run_length): New functions.
914 (uniprop_decoder, uniprop_decoder_count): New variables.
915 (uniprop_get_decoder, uniprop_encode_value_character)
916 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
917 New functions.
918 (uniprop_encoder, uniprop_encoder_count): New variables.
919 (uniprop_get_encoder, uniprop_table)
920 (Funicode_property_table_internal, Fget_unicode_property_internal)
921 (Fput_unicode_property_internal): New functions.
922 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
923 Sunicode_property_table_internal, Sget_unicode_property_internal,
924 and Sput_unicode_property_internal. Defvar_lisp
925 char-code-property-alist.
926
927 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
928 Vunicode_category_table.
929
930 * font.c (font_range): Adjusted for the change of
931 Vunicode_category_table.
932
76b397fb
DN
9332011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
934
935 * m/iris4d.h: Remove file, move contents ...
936 * s/irix6-5.h: ... here.
937
22b4128e
PE
9382011-07-06 Paul Eggert <eggert@cs.ucla.edu>
939
940 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
941 * alloc.c (mark_buffer):
942 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
943 (clone_per_buffer_values): Don't assume that
22b4128e
PE
944 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
945 This isn't true in general, and it's particularly not true
946 if Emacs is configured with --with-wide-int.
947 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
948 New macros, used in the buffer.c change.
949
869795d6
JD
9502011-07-05 Jan Djärv <jan.h.d@swipnet.se>
951
952 * xsettings.c: Use both GConf and GSettings if both are available.
953 (store_config_changed_event): Add comment.
954 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
955 (store_tool_bar_style_changed): New functions.
956 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
957 (struct xsettings): Move font inside HAVE_XFT.
958 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
959 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
960 Move inside HAVE_XFT.
961 (something_changed_gsettingsCB): Renamed from something_changedCB.
962 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
963 also.
964 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
965 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
966 (something_changed_gconfCB): Renamed from something_changedCB.
967 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
968 (parse_settings): Move check for font inside HAVE_XFT.
969 (read_settings, apply_xft_settings): Add comment.
970 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
971 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
972 call store_font_name_changed.
973 (xft_settings_event): Add comment.
974 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
975 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
976 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
977 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
978 (xsettings_initialize): Call init_gsettings last.
979 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
980 comment.
981
d8ed26bd
PE
9822011-07-05 Paul Eggert <eggert@cs.ucla.edu>
983
984 Random fixes. E.g., (random) never returned negative values.
985 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
986 subseconds part to the entropy, as that's a bit more random.
987 Prefer signed to unsigned, since the signedness doesn't matter and
988 in general we prefer signed. When given a limit, use a
989 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
990 latter isn't right if USE_2_TAGS_FOR_INTS.
991 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
992 not 0..VALMASK. Don't discard "excess" bits that random () returns.
993
cabf1cac
SM
9942011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
995
996 * textprop.c (text_property_stickiness):
997 Obey Vtext_property_default_nonsticky.
998 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
999 * w32fns.c (syms_of_w32fns):
1000 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1001
6e9b2be9
PE
10022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1003
1004 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1005 This is more efficient than Ffile_directory_p and avoids a minor race.
1006
90186c68
LMI
10072011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1008
7c301272
LMI
1009 * buffer.c (Foverlay_put): Say what the return value is
1010 (bug#7835).
1011
c4f2d8d4
LMI
1012 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1013 is a directory before asking whether to use the file name
1014 (bug#7564).
ad637907
LMI
1015 (barf_or_query_if_file_exists): Make the "File is a directory"
1016 error be more correct.
c4f2d8d4 1017
90186c68
LMI
1018 * fns.c (Frequire): Remove the mention of the .gz files, since
1019 that's installation-specific, but keep the mention of
1020 `get-load-suffixes'.
1021
da64016e
PE
10222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1025 Report string overflow if the output is too long.
1026
7d47b580
JB
10272011-07-04 Juanma Barranquero <lekktu@gmail.com>
1028
a555cb87
JB
1029 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1030 (syms_of_gnutls): Remove duplicate DEFSYM for
1031 Qgnutls_bootprop_verify_hostname_error, an error for
1032 Qgnutls_bootprop_verify_error (which is no longer used).
1033
7d47b580
JB
1034 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1035 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1036 Also (re)move comments that are misplaced or no longer relevant.
1037
1e49bfab
LMI
10382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1039
1040 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1041
1485f4c0
CY
10422011-07-03 Chong Yidong <cyd@stupidchicken.com>
1043
1044 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1045 and background color parameters if they have been changed.
1046
a9ab721e
LMI
10472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1048
1049 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1050
cf7cff57
PE
10512011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1052
2e13213d
PE
1053 * xsettings.c (SYSTEM_FONT): Define only when used.
1054 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1055
cf7cff57
PE
1056 * keymap.c (access_keymap_1): Now static.
1057
7a8e04f7
CY
10582011-07-02 Chong Yidong <cyd@stupidchicken.com>
1059
1060 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1061 leave any prefix arg for the up event (Bug#1586).
1062
61352f62
LMI
10632011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1064
69bb1ef7
LMI
1065 * lread.c (syms_of_lread): Mention single symbols defined by
1066 `defvar' or `defconst' (bug#7154).
1067
61352f62 1068 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1069 (Frequire): Mention get-load-suffixes.
61352f62 1070
28545e04
MR
10712011-07-02 Martin Rudalics <rudalics@gmx.at>
1072
1073 * window.h (window): Remove clone_number slot.
1074 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1075 Remove.
1076 (make_parent_window, make_window, saved_window)
1077 (Fset_window_configuration, save_window_save): Don't deal with
1078 clone numbers.
1079 * buffer.c (Qclone_number): Remove declaration.
1080 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1081
3349e122
SM
10822011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1083
1084 Add multiple inheritance to keymaps.
1085 * keymap.c (Fmake_composed_keymap): New function.
1086 (Fset_keymap_parent): Simplify.
1087 (fix_submap_inheritance): Remove.
1088 (access_keymap_1): New function extracted from access_keymap to handle
1089 embedded parents and handle lists of maps.
1090 (access_keymap): Use it.
1091 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1092 (Fcopy_keymap): Handle embedded parents.
1093 (Fcommand_remapping, define_as_prefix): Simplify.
1094 (Fkey_binding): Simplify.
1095 (syms_of_keymap): Move minibuffer-local-completion-map,
1096 minibuffer-local-filename-completion-map,
1097 minibuffer-local-must-match-map, and
1098 minibuffer-local-filename-must-match-map to Elisp.
1099 (syms_of_keymap): Defsubr make-composed-keymap.
1100 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1101 (parse_menu_item): Trivial simplification.
1102
3279eb87
GM
11032011-07-01 Glenn Morris <rgm@gnu.org>
1104
1105 * Makefile.in (SETTINGS_LIBS): Fix typo.
1106
4550efdf
KI
11072011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1108
1109 * coding.c (Fencode_coding_string): Record the last coding system
1110 used, as the function doc string says (bug#8738).
1111
0949d2b6
JD
11122011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1113
1114 * xsettings.c (store_monospaced_changed): Take new font as arg and
1115 check for change against current_mono_font.
1116 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1117 (emacs_settings_constructor, emacs_settings_get_property)
1118 (emacs_settings_set_property, emacs_settings_class_init)
1119 (emacs_settings_init, gsettings_obj): Remove.
1120 (something_changedCB): New function for HAVE_GSETTINGS.
1121 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1122 with value as argument.
1123 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1124 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1125 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1126 "changed".
1127
1128 * xgselect.c: Add defined (HAVE_GSETTINGS).
1129 (xgselect_initialize): Ditto.
1130
1131 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1132 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1133 xg_select.
1134
bbc6b304
PE
11352011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 * eval.c (struct backtrace): Simplify and port the data structure.
1138 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1139 signed bit field, as this assumption is not portable and it makes
1140 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1141 "char debug_on_exit : 1" as this is not portable either; instead,
1142 use the portable "unsigned int debug_on_exit : 1". Remove unused
1143 member evalargs. Remove obsolete comments about cc bombing out.
1144
9851bfc5
JD
11452011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1146
51bb811f 1147 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1148 Let HAVE_GSETTINGS override HAVE_GCONF.
1149 (store_monospaced_changed): New function.
1150 (EMACS_SETTINGS): A new type derived from GObject to handle
1151 GSettings notifications.
1152 (emacs_settings_constructor, emacs_settings_get_property)
1153 (emacs_settings_set_property, emacs_settings_class_init):
1154 New functions.
1155 (gsettings_client, gsettings_obj): New variables.
1156 (GSETTINGS_SCHEMA): New define.
1157 (something_changedCB): Call store_monospaced_changed.
1158 (init_gsettings): New function.
1159 (xsettings_initialize): Call init_gsettings.
1160 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1161 to NULL.
1162
1163 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1164 GCONF_CFLAGS/LIBS.
1165
5386012d
MR
11662011-06-29 Martin Rudalics <rudalics@gmx.at>
1167
1168 * window.c (resize_root_window, grow_mini_window)
1169 (shrink_mini_window): Rename Qresize_root_window to
1170 Qwindow_resize_root_window and Qresize_root_window_vertically to
1171 Qwindow_resize_root_window_vertically.
1172
f13e0b08
PE
11732011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1176
94515237
JB
11772011-06-27 Juanma Barranquero <lekktu@gmail.com>
1178
1179 * makefile.w32-in: Redesign dependencies so they reflect more
1180 clearly which files are directly included by each source file,
1181 and not through other includes.
1182
e43b6e43
MR
11832011-06-27 Martin Rudalics <rudalics@gmx.at>
1184
1185 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1186 (sort_overlays, overlay_strings): When an overlay's clone number
1187 matches the window's clone number process the overlay even if
1188 the overlay's window property doesn't match the current window.
1189
d68443dc
MR
1190 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1191 (Fwindow_hchild): Rename to Fwindow_left_child.
1192 (Fwindow_next): Rename to Fwindow_next_sibling.
1193 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1194 (resize_window_check): Rename to window_resize_check.
1195 (resize_window_apply): Rename to window_resize_apply.
1196 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1197 (Fdelete_other_windows_internal, resize_frame_windows)
1198 (Fsplit_window_internal, Fdelete_window_internal)
1199 (grow_mini_window, shrink_mini_window)
1200 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1201
c7e73be5
JD
12022011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1203
1204 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1205 (emacs_fixed_set_min_size): Remove.
1206 (emacs_fixed_new): Take frame as argument.
1207
1208 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1209 (_EmacsFixedPrivate): Remove minwidth/height.
1210 Add struct frame *f.
1211 (emacs_fixed_init): Initialize priv->f.
1212 (get_parent_class, emacs_fixed_set_min_size): Remove.
1213 (emacs_fixed_new): Set priv->f to argument.
1214 (emacs_fixed_get_preferred_width)
1215 (emacs_fixed_get_preferred_height): Use min_width/height from
1216 frames size_hint to set minimum and natural (Bug#8919).
1217 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1218 and use min_width/height from frames size_hint to set
1219 min_width/height (Bug#8919).
1220
1221 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1222 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1223 Fix indentation.
c7e73be5 1224
cf99dcf8
EZ
12252011-06-26 Eli Zaretskii <eliz@gnu.org>
1226
1227 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1228 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1229 called at ZV.
1230
029529ac
CY
12312011-06-26 Chong Yidong <cyd@stupidchicken.com>
1232
1233 * process.c (wait_reading_process_output): Bypass select if
1234 waiting for a cell while ignoring keyboard input, and input is
1235 pending. Suggested by Jan Djärv (Bug#8869).
1236
7a7ef429
PE
12372011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 Use gnulib's dup2 module instead of rolling our own.
1240 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1241
11fdef7d 12422011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1243
1244 * dispnew.c (scrolling_window): Before scrolling, turn off a
1245 mouse-highlight in the window being scrolled.
1246
cd3520a4
JB
12472011-06-24 Juanma Barranquero <lekktu@gmail.com>
1248
1249 Move DEFSYM to lisp.h and use everywhere.
1250
1251 * character.h (DEFSYM): Move declaration...
1252 * lisp.h (DEFSYM): ...here.
1253
1254 * gnutls.c:
1255 * minibuf.c:
1256 * w32menu.c:
1257 * w32proc.c:
1258 * w32select.c: Don't include character.h.
1259
1260 * alloc.c (syms_of_alloc):
1261 * buffer.c (syms_of_buffer):
1262 * bytecode.c (syms_of_bytecode):
1263 * callint.c (syms_of_callint):
1264 * casefiddle.c (syms_of_casefiddle):
1265 * casetab.c (init_casetab_once):
1266 * category.c (init_category_once, syms_of_category):
1267 * ccl.c (syms_of_ccl):
1268 * cmds.c (syms_of_cmds):
1269 * composite.c (syms_of_composite):
1270 * dbusbind.c (syms_of_dbusbind):
1271 * dired.c (syms_of_dired):
1272 * dispnew.c (syms_of_display):
1273 * doc.c (syms_of_doc):
1274 * editfns.c (syms_of_editfns):
1275 * emacs.c (syms_of_emacs):
1276 * eval.c (syms_of_eval):
1277 * fileio.c (syms_of_fileio):
1278 * fns.c (syms_of_fns):
1279 * frame.c (syms_of_frame):
1280 * fringe.c (syms_of_fringe):
1281 * insdel.c (syms_of_insdel):
1282 * keymap.c (syms_of_keymap):
1283 * lread.c (init_obarray, syms_of_lread):
1284 * macros.c (syms_of_macros):
1285 * msdos.c (syms_of_msdos):
1286 * print.c (syms_of_print):
1287 * process.c (syms_of_process):
1288 * search.c (syms_of_search):
1289 * sound.c (syms_of_sound):
1290 * syntax.c (init_syntax_once, syms_of_syntax):
1291 * terminal.c (syms_of_terminal):
1292 * textprop.c (syms_of_textprop):
1293 * undo.c (syms_of_undo):
1294 * w32.c (globals_of_w32):
1295 * window.c (syms_of_window):
1296 * xdisp.c (syms_of_xdisp):
1297 * xfaces.c (syms_of_xfaces):
1298 * xfns.c (syms_of_xfns):
1299 * xmenu.c (syms_of_xmenu):
1300 * xsettings.c (syms_of_xsettings):
1301 * xterm.c (syms_of_xterm): Use DEFSYM.
1302
4228cf16
TZ
13032011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1304
cd3520a4 1305 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1306
7fcccf1e
PE
13072011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1308
7efb4e0e
PE
1309 Integer and buffer overflow fixes (Bug#8873).
1310
ff5844ad
PE
1311 * print.c (printchar, strout): Check for string overflow.
1312 (PRINTPREPARE, printchar, strout):
1313 Don't set size unless allocation succeeds.
1314
90532f02
PE
1315 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1316 for sizes. Check for string overflow more accurately.
1317 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1318
6d84508d
PE
1319 * macros.c: Integer and buffer overflow fixes.
1320 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1321 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1322 Use ptrdiff_t, not int, for sizes.
1323 Don't increment bufsize until after realloc succeeds.
1324 Check for size-calculation overflow.
1325 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1326
437b2cb4
PE
1327 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1328
8b9ac8b4
PE
1329 * lread.c: Integer overflow fixes.
1330 (read_integer): Radix is now EMACS_INT, not int,
1331 to improve quality of diagnostics for out-of-range radices.
1332 Calculate buffer size correctly for out-of-range radices.
1333 (read1): Check for integer overflow in radices, and in
1334 read-circle numbers.
82cb60d3
PE
1335 (read_escape): Avoid int overflow.
1336 (Fload, openp, read_buffer_size, read1)
1337 (substitute_object_recurse, read_vector, read_list, map_obarray):
1338 Use ptrdiff_t, not int, for sizes.
1339 (read1): Use EMACS_INT, not int, for sizes.
20270765 1340 Check for size overflow.
8b9ac8b4 1341
7fcccf1e
PE
1342 * image.c (cache_image): Check for size arithmetic overflow.
1343
bfbbd7e7
PE
1344 * lread.c: Integer overflow issues.
1345 (saved_doc_string_size, saved_doc_string_length)
1346 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1347 Now ptrdiff_t, not int.
1348 (read1): Don't assume doc string length fits in int. Check for
1349 out-of-range doc string lengths.
1350 (read_list): Don't assume file position fits in int.
39019e54 1351 (read_escape): Check for hex character overflow.
bfbbd7e7 1352
4e323265
LL
13532011-06-22 Leo Liu <sdl.web@gmail.com>
1354
1355 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1356 Move to minibuffer.el.
1357
85fece3e
PE
13582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1359
20b84ce9 1360 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1361 The following patches are for when GLYPH_DEBUG && !XASSERT.
1362 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1363 * dispnew.c (flush_stdout):
1364 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1365 Mark as externally visible.
1366 * dispnew.c (check_window_matrix_pointers): Now static.
1367 * dispnew.c (window_to_frame_vpos):
1368 * xfns.c (unwind_create_frame):
1369 * xterm.c (x_check_font): Remove unused local.
1370 * scroll.c (CHECK_BOUNDS):
1371 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1372 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1373 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1374 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1375 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1376 Now static.
1377 (debug_method_add): Use va_list and vsprintf rather than relying
1378 on undefined behavior with wrong number of arguments.
1379 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1380 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1381 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1382 since we're not interested in debugging glyphs with old libraries.
1383 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1384 GCC 4.6.0's static checking.
1385
0766b489
PE
13862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1387
31fd4b32
PE
1388 Integer overflow and signedness fixes (Bug#8873).
1389 A few related buffer overrun fixes, too.
1390
b79e8648
PE
1391 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1392
0766b489
PE
1393 * dispextern.h (struct face.stipple):
1394 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1395 (x_bitmap_mask, x_allocate_bitmap_record)
1396 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1397 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1398 (x_create_bitmap_from_xpm_data):
1399 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1400 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1401 (.bitmaps_last):
1402 * xfaces.c (load_pixmap):
1403 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1404 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1405 (.bitmaps_last, struct x_output.icon_bitmap):
1406 Use ptrdiff_t, not int, for bitmap indexes.
1407 (x_allocate_bitmap_record): Check for size overflow.
1408 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1409
b081724f
PE
1410 Use ptrdiff_t, not int, for overlay counts.
1411 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1412 * editfns.c (overlays_around, get_pos_property):
1413 * textprop.c (get_char_property_and_overlay):
1414 * xdisp.c (next_overlay_change, note_mouse_highlight):
1415 * xfaces.c (face_at_buffer_position):
21514da7
PE
1416 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1417 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1418 (Fnext_overlay_change, Fprevious_overlay_change)
1419 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1420 Use ptrdiff_t, not int, for sizes.
21514da7 1421 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1422
3de73e5e
PE
1423 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1424
2606c57b
PE
1425 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1426 (x_session_initialize): Do not assume string length fits in int.
1427
aaafe47a
PE
1428 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1429 This is unlikely, but can occur if DPI is outlandish.
1430
2674ddc8 1431 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1432 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1433
28154962
PE
1434 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1435 * xrdb.c (magic_file_p, search_magic_path):
1436 Omit last arg SUFFIX; it was always 0. All callers changed.
1437 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1438
7de51af5
PE
1439 * xfont.c (xfont_match): Avoid need for strlen.
1440
25ed6cc3
PE
1441 * xfns.c: Don't assume strlen fits in int.
1442 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1443
4eab31dd
PE
1444 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1445 not unsigned long, as we prefer signed integers. All callers changed.
1446 Detect integer overflow in repeat count.
1447 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1448 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1449
171e2a58
PE
1450 * termcap.c: Don't assume sizes fit in int and never overflow.
1451 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1452 (gobble_line): Check for size-calculation overflow.
1453
ad39faca 1454 * minibuf.c (Fread_buffer):
6e5bb2dc 1455 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1456 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1457 Don't assume string length fits in int.
1458
52c61c22 1459 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1460 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1461
b5b8c9e5
PE
1462 * font.c: Don't assume string length fits in int.
1463 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1464 Use ptrdiff_t, not int.
ccd6111c
PE
1465 (font_intern_prop): Don't assume string length fits in int.
1466 Don't assume integer property fits in fixnum.
1467 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1468
882f0d81 1469 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1470 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1471 Reformulate so as not to need the command string.
1472 Invoke gzip -cd rather than gunzip, as it's more portable.
1473 (lock_info_type, lock_file_1, lock_file):
1474 Don't assume pid_t and time_t fit in unsigned long.
1475 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1476 (current_lock_owner): Prefer signed type for sizes.
1477 Use memcpy, not strncpy, where memcpy is what is really wanted.
1478 Don't assume (via atoi) that time_t and pid_t fit in int.
1479 Check for time_t and/or pid_t out of range, e.g., via a network share.
1480 Don't alloca where an auto var works fine.
1481
93f4cf88
PE
1482 * fileio.c: Fix some integer overflow issues.
1483 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1484 Don't assume string length fits in int.
1485 (directory_file_name): Don't assume string length fits in long.
1486 (make_temp_name): Don't assume pid fits in int, or that its print
1487 length is less than 20.
1488
f3e92b69
PE
1489 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1490
1bfdaf10
PE
1491 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1492
35016e9a
PE
1493 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1494
3d1e65a1
PE
1495 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1496 We prefer signed integers, even for size calculations.
1497
0b963a93
PE
1498 * emacs.c: Don't assume string length fits in 'int'.
1499 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1500 (main): Don't invoke strlen when not needed.
1501
573f4b54
PE
1502 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1503 (XD_DEBUG_MESSAGE): Don't waste a byte.
1504
989f33ba
PE
1505 * callproc.c (getenv_internal_1, getenv_internal)
1506 (Fgetenv_internal):
965d34eb
PE
1507 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1508
e4d29b33
PE
1509 * lread.c (invalid_syntax): Omit length argument.
1510 All uses changed. This doesn't fix a bug, but it simplifies the
1511 code away from its former Hollerith-constant appearance, and it's
1512 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1513 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1514
eb49b136
PE
1515 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1516 This didn't break anything, but it didn't help either.
1517 It's confusing to put a bogus integer in a place where the actual
1518 value does not matter.
9f62aeb1 1519 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1520 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1521
15375a22
PE
1522 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1523 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1524 implementation.
b61cc01c
PE
1525 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1526 We prefer signed types, and the value cannot exceed the EMACS_INT
1527 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1528 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1529 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1530 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1531
53b2623d
PE
1532 * indent.c (sane_tab_width): New function.
1533 (current_column, scan_for_column, Findent_to, position_indentation)
1534 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1535 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1536
51cab52b 1537 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1538
f2ed8a70
PE
1539 * lisp.h (lint_assume): New macro.
1540 * composite.c (composition_gstring_put_cache):
1541 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1542
abe80cc6
PE
1543 * editfns.c, insdel.c:
1544 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1545
b02c740e
PE
1546 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1547
ebc96716
PE
1548 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1549
b4e50fa0 1550 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1551 Use much-faster test for byte-length change.
311d5d7c 1552 Don't assume string byte-length fits in 'int'.
a4cf38e4 1553 Check that character arg fits in 'int'.
85461888 1554 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1555
c0c1ee9f
PE
1556 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1557
a498d7f4
PE
1558 * fns.c (concat): Catch string overflow earlier.
1559 Do not rely on integer wraparound.
1560
51cab52b
PE
1561 * dispextern.h (struct it.overlay_strings_charpos)
1562 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1563 * xdisp.c (forward_to_next_line_start)
1564 (back_to_previous_visible_line_start)
1565 (reseat_at_next_visible_line_start, next_element_from_buffer):
1566 Don't arbitrarily truncate the value of 'selective' to int.
1567
76031fad
PE
1568 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1569
5eb55db9
PE
1570 * composite.c: Don't truncate sizes to 'int'.
1571 (composition_gstring_p, composition_reseat_it)
1572 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1573 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1574 not EMACS_UINT, for indexes.
5eb55db9 1575
0703a717
PE
1576 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1577
d6202519
PE
1578 * buffer.c: Include <verify.h>.
1579 (struct sortvec.priority, struct sortstr.priority):
8961a454 1580 Now EMACS_INT, not int.
c20998a7 1581 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1582 (struct sortstr.size, record_overlay_string)
1583 (struct sortstrlist.size, struct sortlist.used):
1584 Don't truncate size to int.
1585 (record_overlay_string): Check for size-calculation overflow.
d6202519 1586 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1587
d5a19415
JM
15882011-06-22 Jim Meyering <meyering@redhat.com>
1589
029529ac 1590 Don't leak an XBM-image-sized buffer
d5a19415
JM
1591 * image.c (xbm_load): Free the image buffer after using it.
1592
a9041e6c
PE
15932011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1594
1595 Port to Sun C.
1596 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1597 that Sun C diagnosed.
1598 * fns.c (secure_hash): Fix pointer signedness issue.
1599 * intervals.c (static_offset_intervals): New function.
1600 (offset_intervals): Use it.
1601
7f3f739f
LL
16022011-06-21 Leo Liu <sdl.web@gmail.com>
1603
1604 * deps.mk (fns.o):
1605 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1606 sha512.h.
1607
1608 * fns.c (secure_hash): Rename from crypto_hash_function and change
1609 the first arg to accept symbols.
5b66d427 1610 (Fsecure_hash): New primitive.
7f3f739f
LL
1611 (syms_of_fns): New symbols.
1612
76147d94
DD
16132011-06-20 Deniz Dogan <deniz@dogan.se>
1614
1615 * process.c (Fset_process_buffer): Clarify return value in
1616 docstring.
1617
7d7d0045
CY
16182011-06-18 Chong Yidong <cyd@stupidchicken.com>
1619
1620 * dispnew.c (add_window_display_history): Use BVAR.
1621
1622 * xdisp.c (debug_method_add): Use BVAR.
1623 (check_window_end, dump_glyph_matrix, dump_glyph)
1624 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1625
1626 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1627 Likewise.
1628
1629 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1630 check till after the cache is created in init_frame_faces.
1631
ff2bc410
SM
16322011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1633
1634 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1635
28177add
PE
16362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1637
dd3482fe
PE
1638 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1639 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1640 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1641
393d71f3 1642 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1643 * fileio.c (Finsert_file_contents):
1644 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1645 Remove the old (too-loose) buffer overflow checks.
1646 They weren't needed, since make_gap checks for buffer overflow.
1647 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1648 The old code merely checked for Emacs fixnum overflow, and relied
1649 on undefined (wraparound) behavior. The new code avoids undefined
1650 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1651
2e6813b0 1652 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1653 Tune. Don't use wider integers than needed. Don't use alloca.
1654 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1655
599a9e4f
PE
1656 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1657
99561444
PE
1658 * insdel.c, lisp.h (buffer_overflow): New function.
1659 (insert_from_buffer_1, replace_range, replace_range_2):
1660 * insdel.c (make_gap_larger):
1661 * editfns.c (Finsert_char):
1662 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1663
28177add
PE
1664 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1665
e69dafad
PE
16662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1667
a7af7fde 1668 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1669
b1c46f02
PE
1670 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1671 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1672
e69dafad
PE
1673 * fileio.c: Don't assume EMACS_INT fits in off_t.
1674 (emacs_lseek): New static function.
1675 (Finsert_file_contents, Fwrite_region): Use it.
1676 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1677
566684ea
PE
1678 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1679
e6966cd6
PE
1680 * fns.c: Don't overflow int when computing a list length.
1681 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1682 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1683 truncation on 64-bit hosts. Check for QUIT every
1684 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1685 faster and is responsive enough.
1686 (Flength): Report an error instead of overflowing an integer.
1687 (Fsafe_length): Return a float if the value is not representable
1688 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1689 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1690 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1691
dd0b0efb
PE
1692 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1693 (header_size, word_size): New constants.
1694 (allocate_vectorlike): Don't check size overflow here.
1695 (allocate_vector): Check it here instead, since this is the only
1696 caller of allocate_vectorlike that could cause overflow.
1697 Check that the new vector's length is representable as a fixnum.
1698
86fe5cfe
PE
1699 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1700 The previous code was bogus. For example, next_almost_prime (32)
1701 returned 39, which is undesirable as it is a multiple of 3; and
1702 next_almost_prime (24) returned 25, which is a multiple of 5 so
1703 why was the code bothering to check for multiples of 7?
1704
80e88859
PE
1705 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1706
4a2f0ad6
PE
1707 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1708
f66c7cf8
PE
1709 Variadic C functions now count arguments with ptrdiff_t.
1710 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1711 Back then I didn't know that the Emacs coding style prefers signed int.
1712 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1713 were being counted with int, which may truncate counts on 64-bit
1714 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1715 * lisp.h (struct Lisp_Subr.function.aMANY)
1716 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1717 Arg counts are now ptrdiff_t, not size_t.
1718 All variadic functions and their callers changed accordingly.
1719 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1720 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1721 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1722 * callint.c (Fcall_interactively): Check arg count for overflow,
1723 to avoid potential buffer overrun. Use signed char, not 'int',
1724 for 'varies' array, so that we needn't bother to check its size
1725 calculation for overflow.
1726 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1727 * eval.c (apply_lambda):
1728 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1729 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1730 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1731
a1759b76
PE
1732 * callint.c (Fcall_interactively): Don't use index var as event count.
1733
d96be9fc
PE
1734 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1735 * mem-limits.h (SIZE): Remove; no longer used.
1736
a690a978 1737 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1738
578c21e6
PE
1739 Remove unnecessary casts.
1740 * xterm.c (x_term_init):
1741 * xfns.c (x_set_border_pixel):
1742 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1743 These aren't needed now that we assume ANSI C.
1744
96f53c6c
PE
1745 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1746 It's more likely to cause problems (due to unsigned overflow)
1747 than to cure them.
1748
83c77d31
PE
1749 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1750
ee2079f1
PE
1751 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1752
6da65536
PE
1753 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1754
7147c4a4
PE
1755 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1756
193e32d9
PE
1757 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1758
e5533da6
PE
1759 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1760
9910e595
PE
1761 GLYPH_CODE_FACE returns EMACS_INT, not int.
1762 * dispextern.h (merge_faces):
1763 * xfaces.c (merge_faces):
01103c44
PE
1764 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1765 Don't assume EMACS_INT fits in int.
9910e595 1766
2638320e
PE
1767 * character.h (CHAR_VALID_P): Remove unused parameter.
1768 * fontset.c, lisp.h, xdisp.c: All uses changed.
1769
045eb8d9
PE
1770 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1771
c1f134b5
PE
1772 * fns.c (concat): Minor tuning based on overflow analysis.
1773 This doesn't fix any bugs. Use int to hold character, instead
1774 of constantly refetching from Emacs object. Use XFASTINT, not
1775 XINT, for value known to be a character. Don't bother comparing
1776 a single byte to 0400, as it's always less.
1777
395fcb93 1778 * floatfns.c (Fexpt):
327eeec8
PE
1779 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1780
abbd3d23
PE
1781 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1782 for characters.
1783
684a03ef
PE
1784 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1785
0fed43f3
PE
1786 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1787 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1788 incorrectly succeed when S was a string, because 4294967386 was
1789 truncated before it was used.
1790
8fd02eb7
PE
1791 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1792 Otherwise, an out-of-range integer could cause undefined behavior
1793 on a 64-bit host.
1794
f8c86b69
PE
1795 * composite.c: Use int, not EMACS_INT, for characters.
1796 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1797 EMACS_INT, for values that are known to be in character range.
1798 This doesn't fix any bugs but is the usual style inside Emacs and
1799 may generate better code on 32-bit machines.
1800
34206dd2
PE
1801 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1802 This is for reasons similar to the recent CHAR_STRING fix.
1803 * charset.c (Fencode_char): Check that character arg is actually
1804 a character. Pass an int to ENCODE_CHAR.
1805 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1806 wider than 'int', as a compile-time check to prevent future regressions
1807 in this area.
1808
c5958d4c 1809 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1810
1811 Make sure a 64-bit char is never passed to CHAR_STRING.
1812 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1813 by silently ignoring the top 32 bits, allowing some values
1814 that were far too large to be valid characters.
1815 * character.h: Include <verify.h>.
1816 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1817 arguments are no wider than unsigned, as a compile-time check
1818 to prevent future regressions in this area.
1819 * data.c (Faset):
01103c44 1820 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1821 (Fsubst_char_in_region):
1822 * fns.c (concat):
1823 * xdisp.c (decode_mode_spec_coding):
1824 Adjust to CHAR_STRING's new requirement.
1825 * editfns.c (Finsert_char, Fsubst_char_in_region):
1826 * fns.c (concat): Check that character args are actually
1827 characters. Without this test, these functions did the wrong
1828 thing with wildly out-of-range values on 64-bit hosts.
1829
d37ca623
PE
1830 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1831 These casts should not be needed on 32-bit hosts, either.
1832 * keyboard.c (read_char):
1833 * lread.c (Fload): Remove casts to unsigned.
1834
ea204efb
PE
1835 * lisp.h (UNSIGNED_CMP): New macro.
1836 This fixes comparison bugs on 64-bit hosts.
1837 (ASCII_CHAR_P): Use it.
1838 * casefiddle.c (casify_object):
01103c44 1839 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1840 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1841 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1842 * dispextern.h (FACE_FROM_ID):
1843 * keyboard.c (read_char): Use UNSIGNED_CMP.
1844
41cb286c
PE
1845 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1846 not to EMACS_INT, to avoid GCC warning.
1847
4a1b9832
PE
1848 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1849
55daad71
PE
1850 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1851 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1852 isn't needed on 32-bit machines.
8f95c75c 1853
01103c44
PE
1854 * buffer.c (Fgenerate_new_buffer_name):
1855 Use EMACS_INT for count, not int.
0ceccced 1856 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1857
1858 * data.c (Qcompiled_function): Now static.
1859
c6f072e7
PE
1860 * window.c (window_body_lines): Now static.
1861
20ce5912
PE
1862 * image.c (gif_load): Rename local to avoid shadowing.
1863
9c4c5f81
PE
1864 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1865 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1866 * alloc.c (make_save_value): Integer argument is now of type
1867 ptrdiff_t, not int.
1868 (mark_object): Use ptrdiff_t, not int.
1869 * lisp.h (pD): New macro.
1870 * print.c (print_object): Use it.
1871
c0c5c8ae
PE
1872 * alloc.c: Use EMACS_INT, not int, to count objects.
1873 (total_conses, total_markers, total_symbols, total_vector_size)
1874 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1875 (total_free_floats, total_floats, total_free_intervals)
1876 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1877 Now EMACS_INT, not int. All uses changed.
1878 (Fgarbage_collect): Compute overall total using a double, so that
1879 integer overflow is less likely to be a problem. Check for overflow
1880 when converting back to an integer.
5a25e253
PE
1881 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1882 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1883 These were 'int' variables that could overflow on 64-bit hosts;
1884 they were never used, so remove them instead of repairing them.
211a0b2a 1885 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1886 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1887 Previously, this ceilinged at INT_MAX, but that doesn't work on
1888 64-bit machines.
e46bb31a 1889 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1890
c78baabf 1891 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1892 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1893 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1894 when a (possibly-narrower) signed value would do just as well.
1895 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1896
c9d624c6
PE
1897 * alloc.c: Catch some string size overflows that we were missing.
1898 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1899 for convenience in STRING_BYTES_MAX.
1900 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1901 The definition here is exact; the one in lisp.h was approximate.
1902 (allocate_string_data): Check for string overflow. This catches
1903 some instances we weren't catching before. Also, it catches
1904 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1905 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1906 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1907
c9d624c6
PE
1908 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1909 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1910 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1911
353032ce
PE
1912 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1913
2bccce07
PE
1914 * alloc.c (Fmake_string): Check for out-of-range init.
1915
0ac30604
SM
19162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1917
1918 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1919
c195f2de
JD
19202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1921
1922 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1923 xg_get_default_scrollbar_width.
1924
1925 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1926 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1927 (style_changed_cb): Call update_theme_scrollbar_width and call
1928 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1929 all frames (Bug#8505).
1930 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1931 Call gtk_window_set_resizable if HAVE_GTK3.
1932 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1933 and height if HAVE_GTK3 (Bug#8505).
1934 (scroll_bar_width_for_theme): New variable.
1935 (update_theme_scrollbar_width): New function.
1936 (xg_get_default_scrollbar_width): Move code to
1937 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1938 (xg_initialize): Call update_theme_scrollbar_width.
1939
1940 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1941
1942 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1943
e10ac9f1
MR
19442011-06-12 Martin Rudalics <rudalics@gmx.at>
1945
1946 * frame.c (make_frame): Call other_buffer_safely instead of
1947 other_buffer.
1948
1949 * window.c (temp_output_buffer_show): Call display_buffer with
1950 second argument Vtemp_buffer_show_specifiers and reset latter
1951 immediately after the call.
1952 (Vtemp_buffer_show_specifiers): New variable.
1953 (auto_window_vscroll_p, next_screen_context_lines)
1954 (Vscroll_preserve_screen_position): Remove leading asterisks from
1955 doc-strings.
1956
2d3c217e 19572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1958
7b7f97e8 1959 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1960 * buffer.c (Qclone_number): Remove for now, as it's unused.
1961 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1962 (record_buffer): Remove unused local.
1963 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1964 (set_frame_buffer_list): Remove; unused.
1965 * frame.h (other_visible_frames): Remove decl.
1966 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1967 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1968 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1969 if HAVE_GPM.
1970 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1971 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1972 Define only if HAVE_GPM.
1973 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1974 (update_hints_inhibit): Remove; never set. All uses removed.
1975 * widgetprv.h (emacsFrameClassRec): Remove decl.
1976 * window.c (delete_deletable_window): Now returns void, since it
1977 wasn't returning anything.
1978 (compare_window_configurations): Remove unused locals.
1979 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1980 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1981 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1982 the same widths as pointers. This follows up on the 2011-05-06 patch.
1983 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1984 * xterm.h: Likewise.
1985 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1986
1384b89e
JB
19872011-06-12 Juanma Barranquero <lekktu@gmail.com>
1988
1989 * makefile.w32-in: Update dependencies.
1990 (LISP_H): Add lib/intprops.h.
1991
1100a63c
CY
19922011-06-11 Chong Yidong <cyd@stupidchicken.com>
1993
1994 * image.c (gif_load): Add animation frame delay to the metadata.
1995 (syms_of_image): Use DEFSYM. New symbol `delay'.
1996
6198ccd0
MR
19972011-06-11 Martin Rudalics <rudalics@gmx.at>
1998
1999 * window.c (delete_deletable_window): Re-add.
2000 (Fset_window_configuration): Rewrite to handle dead buffers and
2001 consequently deletable windows.
2002 (window_tree, Fwindow_tree): Remove. Supply functionality in
2003 window.el.
2004 (compare_window_configurations): Simplify code.
2005
b6e3633c
AS
20062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2007
1ab0dee5
AS
2008 * image.c (imagemagick_load_image): Fix type mismatch.
2009 (Fimagemagick_types): Likewise.
2010
b6e3633c
AS
2011 * window.h (replace_buffer_in_windows): Declare.
2012
9397e56f
MR
20132011-06-11 Martin Rudalics <rudalics@gmx.at>
2014
2015 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2016 Qclone_number. Remove external declaration of Qdelete_window.
2017 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2018 code.
2019 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2020 Qbuffer_list_update_hook if allowed.
2021 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2022 buffer list implementation.
2023 (other_buffer_safely): New function.
2024 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2025 calls to replace_buffer_in_windows and
2026 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2027 if allowed.
2028 (record_buffer): Inhibit quitting and rewrite using quittable
2029 functions. Run Qbuffer_list_update_hook if allowed.
2030 (Frecord_buffer, Funrecord_buffer): New functions.
2031 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2032 switch-to-buffer to window.el.
2033 (bury-buffer): Move to window.el.
2034 (Vbuffer_list_update_hook): New variable.
2035
2036 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2037 section.
2038
2039 * window.h (resize_frame_windows): Move up in code.
2040 (Fwindow_frame): Remove EXFUN.
2041 (replace_buffer_in_all_windows): Remove prototype.
2042 (replace_buffer_in_windows_safely): Add prototype.
2043
2044 * window.c: Declare Qdelete_window static again. Move down
2045 declaration of select_count.
2046 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2047 (Fother_window): Move to window.el.
2048 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2049 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2050 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2051 window.el.
2052 (replace_buffer_in_windows): Implement by calling
2053 Qreplace_buffer_in_windows.
2054 (replace_buffer_in_all_windows): Remove with some functionality
2055 moved into replace_buffer_in_windows_safely.
2056 (replace_buffer_in_windows_safely): New function.
2057 (select_window_norecord, select_frame_norecord): Move in front
2058 of run_window_configuration_change_hook. Remove now obsolete
2059 declarations.
2060 (Fset_window_buffer): Rewrite doc-string. Call
2061 Qrecord_window_buffer.
2062 (keys_of_window): Move binding for other-window to window.el.
2063
b50691aa
CY
20642011-06-11 Chong Yidong <cyd@stupidchicken.com>
2065
2066 * dispextern.h (struct image): Replace data member, whose int_val
2067 and ptr_val fields were not used by anything, with a single
2068 lisp_val object.
2069
2070 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2071 (gif_clear_image, gif_load, imagemagick_load_image)
2072 (gs_clear_image, gs_load): Callers changed.
2073
3f754b86
PE
20742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2075
cca69397
PE
2076 * buffer.h: Include <time.h>, for time_t.
2077 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2078
109e28d0
PE
2079 Fix minor problems found by static checking.
2080
60737f02
PE
2081 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2082
4b66faf3
PE
2083 Make identifiers static if they are not used in other modules.
2084 * data.c (Qcompiled_function, Qframe, Qvector):
2085 * image.c (QimageMagick, Qsvg):
2086 * minibuf.c (Qmetadata):
2087 * window.c (resize_window_check, resize_root_window): Now static.
2088 * window.h (resize_window_check, resize_root_window): Remove decls.
2089
109e28d0
PE
2090 * window.c (window_deletion_count, delete_deletable_window):
2091 Remove; unused.
46a4ce9e
PE
2092 (window_body_lines): Now static.
2093 (Fdelete_other_windows_internal): Mark vars as initialized.
2094 Make sure 'resize_failed' is initialized.
2095 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2096 (resize_window_apply): Remove unused local.
2097 * window.h (delete_deletable_window): Remove decl.
2098
109e28d0 2099 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2100 (imagemagick_load_image): Fix pointer signedness problem by changing
2101 last arg from unsigned char * to char *. All uses changed.
2102 Also, fix a local for similar reasons.
2103 Remove unused locals. Remove locals to avoid shadowing.
2104 (fn_rsvg_handle_free): Remove; unused.
2105 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2106 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2107
3f754b86
PE
2108 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2109
2547adb1
CY
21102011-06-10 Chong Yidong <cyd@stupidchicken.com>
2111
2112 * image.c (gif_load): Fix omitted cast error introduced by
2113 2011-06-06 change.
2114
2c8e37d4
MR
21152011-06-10 Martin Rudalics <rudalics@gmx.at>
2116
2117 * window.h (resize_proportionally, orig_total_lines)
2118 (orig_top_line): Remove from window structure.
2119 (set_window_height, set_window_width, change_window_heights)
2120 (Fdelete_window): Remove prototypes.
2121 (resize_frame_windows): Remove duplicate declaration.
2122
440a42e3
EZ
21232011-06-10 Eli Zaretskii <eliz@gnu.org>
2124
2125 * window.h (resize_frame_windows, resize_window_check)
2126 (delete_deletable_window, resize_root_window)
2127 (resize_frame_windows): Declare prototypes.
2128
2129 * window.c (resize_window_apply): Make definition be "static" to
2130 match the prototype.
2131
562dd5e9
MR
21322011-06-10 Martin Rudalics <rudalics@gmx.at>
2133
2134 * window.c: Remove declarations of Qwindow_size_fixed,
2135 window_min_size_1, window_min_size_2, window_min_size,
2136 size_window, window_fixed_size_p, enlarge_window, delete_window.
2137 Remove static from declaration of Qdelete_window, it's
2138 temporarily needed by Fbury_buffer.
2139 (replace_window): Don't assign orig_top_line and
2140 orig_total_lines.
2141 (Fdelete_window, delete_window): Remove. Window deletion is
2142 handled by window.el.
2143 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2144 Fdelete_window calls with calls to Qdelete_window.
2145 (Fdelete_other_windows): Remove. Deleting other windows is
2146 handled by window.el.
2147 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2148 handled in window.el.
2149 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2150 Window minimum sizes are handled in window.el.
2151 (shrink_windows, size_window, set_window_height)
2152 (set_window_width, change_window_heights, window_height)
2153 (window_width, CURBEG, CURSIZE, enlarge_window)
2154 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2155 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2156 handled in window.el.
2157 (make_dummy_parent): Rename to make_parent_window and give it a
2158 second argument horflag.
2159 (make_window): Don't set resize_proportionally any more.
2160 (Fsplit_window): Remove. Windows are split in window.el.
2161 (save_restore_action, save_restore_orig_size)
2162 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2163 Resize mini windows in window.el.
2164 (grow_mini_window, shrink_mini_window): Implement by calling
2165 Qresize_root_window_vertically, resize_window_check and
2166 resize_window_apply.
2167 (saved_window, Fset_window_configuration, save_window_save): Do
2168 not handle orig_top_line, orig_total_lines, and
2169 resize_proportionally.
2170 (window_min_height, window_min_width): Move to window.el.
2171 (keys_of_window): Move bindings for delete-other-windows,
2172 split-window, delete-window and enlarge-window to window.el.
2173
2174 * buffer.c: Temporarily extern Qdelete_window.
2175 (Fbury_buffer): Temporarily call Qdelete_window instead of
2176 Fdelete_window (Fbury_buffer will move to window.el soon).
2177
2178 * frame.c (set_menu_bar_lines_1): Remove code handling
2179 orig_top_line and orig_total_lines.
2180
2181 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2182 set_window_height but set heights directly.
2183 (change_frame_size_1): Use resize_frame_windows.
2184
2185 * xdisp.c (init_xdisp): Don't use set_window_height but set
2186 heights directly.
2187
2188 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2189 resize_frame_windows instead of change_window_heights and run
2190 run_window_configuration_change_hook.
2191
2192 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2193 instead of change_window_heights and run
2194 run_window_configuration_change_hook.
2195
1a13852e
MR
21962011-06-09 Martin Rudalics <rudalics@gmx.at>
2197
2198 * window.c (replace_window): Rename second argument REPLACEMENT to
2199 NEW. New third argument SETFLAG. Rewrite.
2200 (delete_window, make_dummy_parent): Call replace_window with
2201 third argument 1.
2202 (window_list_1): Move down in code.
2203 (run_window_configuration_change_hook): Move set_buffer part
2204 before select_frame_norecord part in order to unwind correctly.
2205 Rename count1 to count.
2206 (recombine_windows, delete_deletable_window, resize_root_window)
2207 (Fdelete_other_windows_internal)
2208 (Frun_window_configuration_change_hook, make_parent_window)
2209 (resize_window_check, resize_window_apply, Fresize_window_apply)
2210 (resize_frame_windows, Fsplit_window_internal)
2211 (Fdelete_window_internal, Fresize_mini_window_internal): New
2212 functions.
2213 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2214
f3d1777e
MR
22152011-06-08 Martin Rudalics <rudalics@gmx.at>
2216
496e208e
MR
2217 * window.h (window): Add some new members to window structure -
2218 normal_lines, normal_cols, new_total, new_normal, clone_number,
2219 splits, nest, prev_buffers, next_buffers.
2220 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2221 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2222
f3d1777e
MR
2223 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2224 Remove.
496e208e
MR
2225 (make_dummy_parent): Set new members of windows structure.
2226 (make_window): Move down in code. Handle new members of window
2227 structure.
2228 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2229 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2230 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2231 (Fset_window_prev_buffers, Fwindow_next_buffers)
2232 (Fset_window_next_buffers, Fset_window_clone_number): New
2233 functions.
2234 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2235 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2236 Doc-string fixes.
2237 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2238 Argument WINDOW can be now internal window too.
2239 (Fwindow_use_time): Move up in code.
2240 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2241 Rewrite doc-string.
2242 (Fset_window_configuration, saved_window)
2243 (Fcurrent_window_configuration, save_window_save): Handle new
2244 members of window structure.
b9e809c2
MR
2245 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2246 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2247 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2248 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2249 Qget_mru_window, Qresize_root_window,
2250 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2251 Qauto_buffer_name; staticpro them.
f3d1777e 2252
abde8f8c
MR
22532011-06-07 Martin Rudalics <rudalics@gmx.at>
2254
2255 * window.c (Fwindow_total_size, Fwindow_left_column)
2256 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2257 (Fwindow_list_1): New functions.
2258 (window_box_text_cols): Replace with window_body_cols.
2259 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2260 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2261 (delete_window, Fset_window_configuration): Call
2262 delete_all_subwindows with window as argument.
2263 (delete_all_subwindows): Take a window as argument and not a
2264 structure. Rewrite.
190b47e6
MR
2265 (window_loop): Remove handling of GET_LRU_WINDOW and
2266 GET_LARGEST_WINDOW.
2267 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2268
2269 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2270 window_box_text_cols. delete_all_subwindows now takes a
2271 Lisp_Object as argument.
abde8f8c
MR
2272
2273 * indent.c (compute_motion, Fcompute_motion): Use
2274 window_body_cols instead of window_box_text_cols.
2275
fa8a67e6
MR
2276 * frame.c (delete_frame): Call delete_all_subwindows with root
2277 window as argument.
2278
a54e3482
DC
22792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2280
2281 * fns.c (Fputhash): Document return value.
2282
60002bf5
CY
22832011-06-06 Chong Yidong <cyd@stupidchicken.com>
2284
2285 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2286
0c671da6 22872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2288
b862a52a 2289 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2290
be44ca6c
PE
2291 Check for overflow when converting integer to cons and back.
2292 * charset.c (Fdefine_charset_internal, Fdecode_char):
2293 Use cons_to_unsigned to catch overflow.
2294 (Fencode_char): Use INTEGER_TO_CONS.
2295 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2296 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2297 * data.c (long_to_cons, cons_to_long): Remove.
2298 (cons_to_unsigned, cons_to_signed): New functions.
2299 These signal an error for invalid or out-of-range values.
2300 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2301 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2302 * font.c (Ffont_variation_glyphs):
2303 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2304 * lisp.h: Include <intprops.h>.
2305 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2306 (cons_to_signed, cons_to_unsigned): New decls.
2307 (long_to_cons, cons_to_long): Remove decls.
2308 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2309 (Fprimitive_undo): Use CONS_TO_INTEGER.
2310 * xfns.c (Fx_window_property): Likewise.
2311 * xselect.c: Include <limits.h>.
2312 (x_own_selection, selection_data_to_lisp_data):
2313 Use INTEGER_TO_CONS.
2314 (x_handle_selection_request, x_handle_selection_clear)
2315 (x_get_foreign_selection, Fx_disown_selection_internal)
2316 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2317 (lisp_data_to_selection_data): Use cons_to_unsigned.
2318 (x_fill_property_data): Use cons_to_signed.
2319 Report values out of range.
2320
d1f3d2af
PE
2321 Check for buffer and string overflow more precisely.
2322 * buffer.h (BUF_BYTES_MAX): New macro.
2323 * lisp.h (STRING_BYTES_MAX): New macro.
2324 * alloc.c (Fmake_string):
2325 * character.c (string_escape_byte8):
2326 * coding.c (coding_alloc_by_realloc):
2327 * doprnt.c (doprnt):
2328 * editfns.c (Fformat):
2329 * eval.c (verror):
2330 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2331 since they may not be the same number.
2332 * editfns.c (Finsert_char):
2333 * fileio.c (Finsert_file_contents):
2334 Likewise for BUF_BYTES_MAX.
2335
dd52fcea
PE
2336 * image.c: Use ptrdiff_t, not int, for sizes.
2337 (slurp_file): Switch from int to ptrdiff_t.
2338 All uses changed.
2339 (slurp_file): Check that file size fits in both size_t (for
2340 malloc) and ptrdiff_t (for sanity and safety).
2341
7f9bbdbb
PE
2342 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2343 if b->modtime has its maximal value.
2344
dfe18f82
PE
2345 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2346
84acfcf0
PE
2347 Don't assume time_t can fit into int.
2348 * buffer.h (struct buffer.modtime): Now time_t, not int.
2349 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2350 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2351
ccd9a01a
PE
2352 Minor fixes for signed vs unsigned integers.
2353 * character.h (MAYBE_UNIFY_CHAR):
2354 * charset.c (maybe_unify_char):
2355 * keyboard.c (read_char, reorder_modifiers):
2356 XINT -> XFASTINT, since the integer must be nonnegative.
2357 * ftfont.c (ftfont_spec_pattern):
2358 * keymap.c (access_keymap, silly_event_symbol_error):
2359 XUINT -> XFASTINT, since the integer must be nonnegative.
2360 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2361 since it makes no difference and we prefer signed.
2362 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2363 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2364 nonnegative.
2365
d6d100dd
SM
23662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2367
2368 * window.h (Fwindow_frame): Declare.
2369
2b6148e4
PE
23702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2373 (SPARE_MEMORY): Always define.
2374 (LARGE_REQUEST): Remove.
2375 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2376
f230ecc9
MR
23772011-06-06 Martin Rudalics <rudalics@gmx.at>
2378
727e958e
MR
2379 * lisp.h: Move EXFUNS for Fframe_root_window,
2380 Fframe_first_window and Fset_frame_selected_window to window.h.
2381
2382 * window.h: Move EXFUNS for Fframe_root_window,
2383 Fframe_first_window and Fset_frame_selected_window here from
2384 lisp.h.
2385
2386 * frame.c (Fwindow_frame, Fframe_first_window)
2387 (Fframe_root_window, Fframe_selected_window)
2388 (Fset_frame_selected_window): Move to window.c.
2389 (Factive_minibuffer_window): Move to minibuf.c.
2390 (Fother_visible_frames_p): New function.
2391
2392 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2393
f230ecc9
MR
2394 * window.c (decode_window, decode_any_window): Move up in code.
2395 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2396 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2397 (Fwindow_buffer): Move up and rewrite doc-string.
2398 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2399 (Fwindow_prev): New functions.
727e958e
MR
2400 (Fwindow_frame): Move here from frame.c. Accept any window as
2401 argument.
2402 (Fframe_root_window, Fframe_first_window)
2403 (Fframe_selected_window): Move here from frame.c. Accept frame
2404 or arbitrary window as argument. Update doc-strings.
2405 (Fminibuffer_window): Move up in code.
2406 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2407 (Fset_frame_selected_window): Move here from frame.c.
2408 Marginal rewrite.
727e958e
MR
2409 (Fselected_window, select_window, Fselect_window): Move up in
2410 code. Minor doc-string fixes.
f230ecc9 2411
4d09bcf6
PE
24122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2415 Do not assume that spare memory exists; that assumption is valid
2416 only if SYSTEM_MALLOC.
2417 (LARGE_REQUEST): New macro, so that the issue of large requests
2418 is separated from the issue of spare memory.
2419
810928a2
AS
24202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2421
172418ad
AS
2422 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2423 format. (Bug#8806)
2424
43f862f7
AS
2425 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2426
810928a2
AS
2427 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2428 before statements.
2429
a059fe24
JD
24302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2431
2432 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2433
2434 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2435
2436 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2437 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2438
989bf368
JB
24392011-06-05 Juanma Barranquero <lekktu@gmail.com>
2440
2441 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2442
4b80f674
CY
24432011-06-04 Chong Yidong <cyd@stupidchicken.com>
2444
2445 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2446 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2447 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2448 New error handlers.
4b80f674
CY
2449 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2450 Obey Vx_select_enable_clipboard_manager. Catch errors in
2451 x_clipboard_manager_save (Bug#8779).
2452 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2453 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2454
99a33b77 24552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2456
2457 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2458
99a33b77 24592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2460
2461 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2462 in the current matrix if keep_current_p is non-zero.
2463
8264569d
EZ
24642011-06-04 Eli Zaretskii <eliz@gnu.org>
2465
2466 * bidi.c (bidi_level_of_next_char): Fix last change.
2467
57f97249
EZ
24682011-06-03 Eli Zaretskii <eliz@gnu.org>
2469
fec2107c 2470 Support bidi reordering of text covered by display properties.
57f97249 2471
fec2107c
EZ
2472 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2473 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2474 (bidi_cache_search, bidi_cache_iterator_state)
2475 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2476 (bidi_level_of_next_char, bidi_move_to_visually_next):
2477 Support character positions inside a run of characters covered by a
fec2107c
EZ
2478 display string.
2479 (bidi_paragraph_init, bidi_resolve_explicit_1)
2480 (bidi_level_of_next_char): Call bidi_fetch_char and
2481 bidi_fetch_char_advance instead of FETCH_CHAR and
2482 FETCH_CHAR_ADVANCE.
2483 (bidi_init_it): Initialize new members.
2484 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2485 definitions.
2486 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2487 instead of using explicit *_CHAR codes.
d6d100dd
SM
2488 (bidi_resolve_explicit, bidi_resolve_weak):
2489 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2490 bidirectional text is supported only in multibyte buffers.
2491 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2492 it to initialize the frame_window_p member of struct bidi_it.
2493 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2494 (bidi_resolve_explicit, bidi_resolve_weak)
2495 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2496 bidi_it->nchars is non-positive.
2497 (bidi_level_of_next_char): Don't try to lookup the cache for the
2498 next/previous character if nothing is cached there yet, or if we
2499 were just reseat()'ed to a new position.
c40e2fb2 2500
0e14fe90
EZ
2501 * xdisp.c (set_cursor_from_row): Set start and stop points
2502 according to the row's direction when priming the loop that looks
2503 for the glyph on which to display cursor.
2504 (single_display_spec_intangible_p): Function deleted.
2505 (display_prop_intangible_p): Reimplement to call
2506 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2507 Accept 3 additional arguments needed by handle_display_spec.
2508 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2509 values: lists, `(when COND...)' forms, etc.
2510 (single_display_spec_string_p): Support property values that are
2511 lists with the argument STRING its top-level element.
2512 (display_prop_string_p): Fix the condition for processing a
2513 property that is a list to be consistent with handle_display_spec.
fec2107c 2514 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2515 last portion of handle_display_prop.
2516 (compute_display_string_pos): Accept additional argument
2517 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2518 value of a `display' property is a "replacing spec".
2519 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2520 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2521 the display property, but just return a value indicating whether
2522 the display property will replace the characters it covers.
2523 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2524 frame_window_p members of struct bidi_it.
d6d100dd
SM
2525 (compute_display_string_pos, compute_display_string_end):
2526 New functions.
fec2107c
EZ
2527 (push_it): Accept second argument POSITION, where pop_it should
2528 jump to continue iteration.
2529 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2530
fec2107c
EZ
2531 * keyboard.c (adjust_point_for_property): Adjust the call to
2532 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2533
2534 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2535 (bidi_init_it): Update prototypes.
2536 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2537 (compute_display_string_pos, compute_display_string_end):
2538 Declare prototypes.
fec2107c
EZ
2539 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2540 EMACS_INT.
fc6f18ce 2541
40087514 25422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2543
57f53182
PE
2544 Malloc failure behavior now depends on size of allocation.
2545 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2546 * lisp.h: Change signatures accordingly.
2547 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2548 All callers changed. (Bug#8762)
2549
2550 * gnutls.c: Use Emacs's memory allocators.
2551 Without this change, the gnutls library would invoke malloc etc.
2552 directly, which causes problems on non-SYNC_INPUT hosts, and which
2553 runs afoul of improving memory_full behavior. (Bug#8761)
2554 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2555 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2556 xfree instead of the default malloc, realloc, free.
2557 (Fgnutls_boot): No need to check for memory allocation failure,
2558 since xmalloc does that for us.
2559
ac32cd99 2560 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2561 * category.c (hash_get_category_set):
2562 * ccl.c (ccl_driver):
2563 * charset.c (Fdefine_charset_internal):
2564 * charset.h (struct charset.hash_index):
2565 * composite.c (get_composition_id, gstring_lookup_cache)
2566 (composition_gstring_put_cache):
2567 * composite.h (struct composition.hash_index):
2568 * dispextern.h (struct image.hash):
2569 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2570 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2571 (hashfn_equal, hashfn_user_defined, make_hash_table)
2572 (maybe_resize_hash_table, hash_lookup, hash_put)
2573 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2574 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2575 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2576 * image.c (make_image, search_image_cache, lookup_image)
2577 (xpm_put_color_table_h):
2578 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2579 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2580 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2581 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2582 * alloc.c (allocate_vectorlike):
2583 Check for overflow in vector size calculations.
2584 * ccl.c (ccl_driver):
2585 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2586 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2587 need to be updated by these changes.
40087514
PE
2588 * fns.c (make_hash_table, maybe_resize_hash_table):
2589 Check for integer overflow with large hash tables.
0de4bb68
PE
2590 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2591 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2592 (SXHASH_REDUCE): New macro.
2593 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2594 Use it instead of discarding useful hash info with large hash values.
2595 (sxhash_float): New function.
2596 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2597 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2598 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2599 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2600 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2601 Adjust signatures to match updated version of code.
2602 (consing_since_gc): Now EMACS_INT, since a single hash table can
2603 use more than INT_MAX bytes.
2604
698d32e2
DN
26052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2606
2607 Make it possible to build with GCC-4.6+ -O2 -flto.
2608
2609 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2610
fd6fa53f
SM
26112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2612
2613 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2614 Call minibuffer-inactive-mode.
2615
864db017
JB
26162011-05-31 Juanma Barranquero <lekktu@gmail.com>
2617
2618 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2619 Update dependencies.
2620
2ad0baf4
DN
26212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2622
2623 * data.c (init_data): Remove code for UTS, this system is not
2624 supported anymore.
2625
4fcc2638
DN
26262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2627
2628 Don't force ./temacs to start in terminal mode.
2629
2630 * frame.c (make_initial_frame): Initialize faces in all cases, not
2631 only when CANNOT_DUMP is defined.
2632 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2633
c56e0fd5
DN
26342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2635
2636 * dispnew.c (add_window_display_history): Use const for the string
2637 pointer. Remove declaration, not needed.
2638
333d54da 26392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2640
55d4c1b2 2641 Use 'inline', not 'INLINE'.
333d54da 2642 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2643 * alloc.c, fontset.c (INLINE): Remove.
2644 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2645 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2646 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2647 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2648 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2649
738db178
DN
26502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2651
2652 Make it possible to run ./temacs.
2653
2654 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2655 syms_of_callproc does the same thing. Remove test for
2656 "initialized", do it in the caller.
2657 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2658
620c53a6
SM
26592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2660
2661 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2662 (read_minibuf): Use get_minibuffer.
2663 (syms_of_minibuf): Use DEFSYM.
2664 (Qmetadata): New var.
2665 * data.c (Qbuffer): Don't make it static.
2666 (syms_of_data): Use DEFSYM.
2667
e003a292
PE
26682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2671 (CCL_CODE_MIN): New macro.
2672
ed008a6d
PE
26732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2674
3687c2ef
PE
2675 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2676
ed008a6d
PE
2677 * eval.c (Qdebug): Now static.
2678 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2679 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2680 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2681
d66c4c7c
CY
26822011-05-29 Chong Yidong <cyd@stupidchicken.com>
2683
2684 * image.c: Various fixes to ImageMagick code comments.
2685 (Fimagemagick_types): Doc fix.
2686
5fbc2025
PE
26872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2688
0196f88a
PE
2689 Minor fixes prompted by GCC 4.6.0 warnings.
2690
2691 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2692
5fbc2025
PE
2693 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2694 (x_clipboard_manager_save_all): Move extern decl to ...
2695 * xterm.h: ... here, so that it can be checked for consistency.
2696
1dd3c2d9
CY
26972011-05-29 Chong Yidong <cyd@stupidchicken.com>
2698
2699 * xselect.c (x_clipboard_manager_save_frame)
2700 (x_clipboard_manager_save_all): New functions.
2701 (Fx_clipboard_manager_save): Lisp function deleted.
2702
2703 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2704 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2705
2706 * xterm.h: Update prototype.
2707
5ba6571d
WX
27082011-05-28 William Xu <william.xwl@gmail.com>
2709
2710 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2711 exiting (Bug#8239).
2712
3eaff834
JM
27132011-05-28 Jim Meyering <meyering@redhat.com>
2714
e1900994 2715 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2716 * fns.c (to_uchar): Define.
2717 (crypto_hash_function): Use it to convert some newly-signed
2718 variables to unsigned, to avoid sign-extension bugs. For example,
2719 without this change, (md5 "truc") would evaluate to
2720 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2721 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2722 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2723
0f6990a7
PE
27242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 Integer overflow fixes.
c8a9ca5a 2727
08686060
PE
2728 * dbusbind.c: Serial number integer overflow fixes.
2729 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2730 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2731 to hold a serial number that is too large for a fixnum.
2732 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2733 Check for serial numbers out of range. Decode any serial number
59568bf0 2734 that was so large that it became a float. (Bug#8722)
08686060 2735
2d1fc3c7
PE
2736 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2737 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2738 Use XFASTINT rather than XUINT when numbers are nonnegative.
2739 (xd_append_arg, Fdbus_method_return_internal):
2740 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2741 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2742 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2743 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2744 (Bug#8722)
2d1fc3c7 2745
c8a9ca5a
PE
2746 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2747
519e1d69
PE
2748 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2749
30569699
PE
2750 ccl: add integer overflow checks
2751 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2752 (IN_INT_RANGE): New macros.
2753 (ccl_driver): Use them to check for integer overflow when
2754 decoding a CCL program. Many of the new checks are whether XINT (x)
2755 fits in int; it doesn't always, on 64-bit hosts. The new version
2756 doesn't catch all possible integer overflows, but it's an
847044ea 2757 improvement. (Bug#8719)
30569699 2758
c11285dc
PE
2759 * alloc.c (make_event_array): Use XINT, not XUINT.
2760 There's no need for unsigned here.
2761
fdccd48e
PE
2762 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2763 This follows up to the 2011-05-06 change that substituted uintptr_t
2764 for EMACS_INT. This case wasn't caught back then.
2765
37910ab2
PE
2766 Rework Fformat to avoid integer overflow issues.
2767 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2768 now (part of C89). Include <verify.h>.
2769 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2770 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2771 (Fformat): Avoid the prepass trying to compute sizes; it was only
2772 approximate and thus did not catch overflow reliably. Instead, walk
2773 through the format just once, formatting and computing sizes as we go,
2774 checking for integer overflow at every step, and allocating a larger
2775 buffer as needed. Keep track separately whether the format is
2776 multibyte. Keep only the most-recently calculated precision, rather
2777 than them all. Record whether each argument has been converted to
2778 string. Use EMACS_INT, not int, for byte and char and arg counts.
2779 Support field widths and precisions larger than INT_MAX. Avoid
2780 sprintf's undefined behavior with conversion specifications such as %#d
2781 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2782 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2783 formatting out-of-range floating point numbers with int
9173deec 2784 formats. (Bug#8668)
37910ab2 2785
2e6578fb
PE
2786 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2787
0ae6bdee
PE
2788 * data.c: Avoid integer truncation in expressions involving floats.
2789 * data.c: Include <intprops.h>.
2790 (arith_driver): When there's an integer overflow in an expression
2791 involving floating point, convert the integers to floating point
2792 so that the resulting value does not suffer from catastrophic
2793 integer truncation. For example, on a 64-bit host (* 4
2794 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2795 Do not rely on undefined behavior after integer overflow.
2796
de883a70
PE
2797 merge count_size_as_multibyte, parse_str_to_multibyte
2798 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2799 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2800 Check for integer overflow.
2801 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2802 since it's now a duplicate of the other. This is more of
2803 a character than a buffer op, so better that it's in character.c.
2804 * fns.c, print.c: Adjust to above changes.
2805
2ff916cb
PE
28062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2807
2808 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2809
f1b54466
PE
28102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2811
fb1ac845
PE
2812 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2813 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2814 (x_clipboard_manager_save): Now static.
2815 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2816
f1b54466
PE
2817 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2818 (crypto_hash_function): Now static.
2819 Fix pointer signedness problems. Avoid unnecessary initializations.
2820
a9f737ee
CY
28212011-05-27 Chong Yidong <cyd@stupidchicken.com>
2822
2823 * termhooks.h (Vselection_alist): Make it terminal-local.
2824
2825 * terminal.c (create_terminal): Initialize it.
2826
2827 * xselect.c: Support for clipboard managers.
2828 (Vselection_alist): Move to termhooks.h as terminal-local var.
2829 (LOCAL_SELECTION): New macro.
2830 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2831 (symbol_to_x_atom): Remove gratuitous arg.
2832 (x_handle_selection_request, lisp_data_to_selection_data)
2833 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2834 (x_own_selection, x_get_local_selection, x_convert_selection):
2835 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2836 (some_frame_on_display): Delete unused function.
2837 (Fx_own_selection_internal, Fx_get_selection_internal)
2838 (Fx_disown_selection_internal, Fx_selection_owner_p)
2839 (Fx_selection_exists_p): New optional frame arg.
2840 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2841 (x_handle_selection_clear): Don't treat other terminals with the
2842 same keyboard specially. Use the terminal-local Vselection_alist.
2843 (x_clear_frame_selections): Use Frun_hook_with_args.
2844
2845 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2846
2847 * xterm.h: Add support for those atoms.
2848
e067f0c1
CY
28492011-05-26 Chong Yidong <cyd@stupidchicken.com>
2850
2851 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2852 (converted_selections, conversion_fail_tag): New global variables.
2853 (x_selection_request_lisp_error): Free the above.
2854 (x_get_local_selection): Remove unnecessary code.
2855 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2856 of converted selections stored in converted_selections.
2857 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2858 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2859 (x_convert_selection): New function.
2860 (x_handle_selection_event): Simplify.
2861 (x_get_foreign_selection): Don't ignore incoming requests while
2862 waiting for an answer; this will fail when we implement
2863 SAVE_TARGETS, and seems unnecessary anyway.
2864 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2865 (Vx_sent_selection_functions): Doc fix.
2866
0f4aebc0
LL
28672011-05-26 Leo Liu <sdl.web@gmail.com>
2868
2869 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2870
e61124cd
YM
28712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2872
2873 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2874
2875 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2876 for fringe update if it has periodic bitmap.
ac389d0c 2877 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2878 and fringe_bitmap_periodic_p.
2879
2880 * fringe.c (get_fringe_bitmap_data): New function.
2881 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2882 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2883 row. Mark glyph row for fringe update if periodicity changed.
2884
2885 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2886 for fringe update unless it has periodic bitmap.
2887
f16d9837
KH
28882011-05-25 Kenichi Handa <handa@m17n.org>
2889
2890 * xdisp.c (get_next_display_element): Set correct it->face_id for
2891 a static composition.
2892
e1b90ef6
LL
28932011-05-24 Leo Liu <sdl.web@gmail.com>
2894
2895 * deps.mk (fns.o):
2896 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2897
2898 * fns.c (crypto_hash_function, Fsha1): New function.
2899 (Fmd5): Use crypto_hash_function.
2900 (syms_of_fns): Add Ssha1.
2901
7400048f
PE
29022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2903
2904 * gnutls.c: Remove unused macros.
2905 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2906 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2907 Remove macros that are defined and never used.
2908 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2909
abb71cf4
CY
29102011-05-22 Chong Yidong <cyd@stupidchicken.com>
2911
2912 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2913 (Fx_get_selection_internal): Minor cleanup.
2914 (Fx_own_selection_internal): Rename arguments for consistency with
2915 select.el.
2916
6307db39
PE
29172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2918
2919 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2920
f3d4e0a4
CY
29212011-05-22 Chong Yidong <cyd@stupidchicken.com>
2922
2923 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2924
4d8ade89
YM
29252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2926
2927 * dispnew.c (scrolling_window): Don't exclude the case that the
2928 last enabled row in the desired matrix touches the bottom boundary.
2929
32078c8d
GM
29302011-05-21 Glenn Morris <rgm@gnu.org>
2931
2932 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2933 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2934 and add some more files.
32078c8d 2935
7285dc67
EZ
29362011-05-20 Eli Zaretskii <eliz@gnu.org>
2937
2938 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2939 report_file_error introduced by the change from 2011-05-07.
2940
89d1bd22
PE
29412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * systime.h (Time): Define only if emacs is defined.
2944 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2945 where the include path doesn't have X11/X.h by default. See
2946 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2947
e23640bb 29482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2949
2950 * composite.c (find_automatic_composition): Fix previous change.
2951
b9704ad9
GM
29522011-05-20 Glenn Morris <rgm@gnu.org>
2953
2954 * lisp.mk: New file, split from Makefile.in.
2955 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2956 (shortlisp): Remove.
2957 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2958
4a720484
GM
29592011-05-19 Glenn Morris <rgm@gnu.org>
2960
2961 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2962 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2963 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2964 (lisp): Set the order to that of loadup.el.
2965 (shortlisp): Make it a copy of $lisp.
2966 (SOME_MACHINE_LISP): Remove.
2967 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2968 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2969
a28d4396
KH
29702011-05-18 Kenichi Handa <handa@m17n.org>
2971
2972 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2973 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2974 (find_automatic_composition): Mostly rewrite for efficiency.
2975
a2b1fa8e
JB
29762011-05-18 Juanma Barranquero <lekktu@gmail.com>
2977
2978 * makefile.w32-in: Update dependencies.
2979
8e1f5610
CS
29802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2981
2982 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2983 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2984
7025ee00 29852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2986
cdfa6eab
PE
2987 Fix some integer overflow issues, such as string length overflow.
2988
06d6db33
PE
2989 * insdel.c (count_size_as_multibyte): Check for string overflow.
2990
2b4560a8
PE
2991 * character.c (lisp_string_width): Check for string overflow.
2992 Use EMACS_INT, not int, for string indexes and lengths; in
2993 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2994 the resulting string length overflows an EMACS_INT; instead,
2995 report a string overflow if no precision given. When checking for
2996 precision exhaustion, use a check that cannot possibly have
2997 integer overflow. (Bug#8675)
2998 * character.h (lisp_string_width): Adjust to new signature.
2999
cb93f9be
PE
3000 * alloc.c (string_overflow): New function.
3001 (Fmake_string): Use it. This doesn't change behavior, but saves
3002 a few bytes and will simplify future changes.
3003 * character.c (string_escape_byte8): Likewise.
3004 * lisp.h (string_overflow): New decl.
3005
1a1f3366
PE
3006 Fixups, following up to the user-interface timestamp change.
3007 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3008 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3009 * msdos.c (mouse_get_pos): Likewise.
3010 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3011 * w32gui.h (Time): Define by including "systime.h" rather than by
3012 declaring it ourselves. (Bug#8664)
3013
d4e3e4d3
PE
3014 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3015 * image.c (clear_image_cache): Likewise.
3016
f6a24d19
PE
3017 * term.c (term_mouse_position): Don't assume time_t wraparound.
3018
08dc5ae6
PE
3019 Be more systematic about user-interface timestamps.
3020 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3021 and sometimes 'EMACS_UINT', to represent these timestamps.
3022 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3023 This makes the code easier to follow, and makes it easier to catch
3024 integer overflow bugs such as Bug#8664.
3025 * frame.c (Fmouse_position, Fmouse_pixel_position):
3026 Use Time, not unsigned long, for user-interface timestamps.
3027 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3028 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3029 * keyboard.h (last_event_timestamp): Likewise.
3030 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3031 * menu.h (xmenu_show): Likewise.
3032 * term.c (term_mouse_position): Likewise.
3033 * termhooks.h (struct input_event.timestamp): Likewise.
3034 (struct terminal.mouse_position_hook): Likewise.
3035 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3036 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3037 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3038 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3039 what it was before.
3040 * menu.h, termhooks.h: Include "systime.h", for Time.
3041
8e55734a
PE
3042 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3043 Don't assume that the difference between two unsigned long values
3044 can fit into an integer. At this point, we know button_down_time
3045 <= event->timestamp, so the difference must be nonnegative, so
3046 there's no need to cast the result if double-click-time is
3047 nonnegative, as it should be; check that it's nonnegative, just in
3048 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3049 apart (about 25 days). (Bug#8664)
8e55734a 3050
841f1b75 3051 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3052 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3053
3e26f69c
PE
3054 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3055 that always fit in int. Use a sentinel instead of a counter, to
3056 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3057 * frame.h (struct frame): Use int for menu_bar_items_used
3058 instead of EMACS_INT, since it always fits in int.
3e26f69c 3059
5cc152c0
PE
3060 * menu.c (grow_menu_items): Check for int overflow.
3061
d89eb65e
PE
3062 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3063
5235bd3e
PE
3064 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3065 Before, the code was not consistent. These values cannot exceed
3066 2**31 - 1 so there's no need to make them unsigned.
3067 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3068 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3069 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3070 as modifiers.
3071 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3072
bc827e23
PE
3073 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3074 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3075 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3076 presumably because the widths might not match.
3077
78eb494e
PE
3078 * window.c (size_window): Avoid needless test at loop start.
3079
04f2d78b
CB
30802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3081
3082 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3083
d2fc7e3d 30842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3085
3086 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3087
d2fc7e3d 30882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3089
3090 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3091 `width' to `bar_area_x' and `bar_area_width', respectively.
3092 (x_scroll_run): Take account of fringe background extension.
3093
04f2d78b
CB
3094 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3095 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3096 `bar_area_width', respectively.
3097 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3098 background extension.
3099
79b70037
GM
31002011-05-10 Jim Meyering <meyering@redhat.com>
3101
3102 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3103
2f142cc5
JB
31042011-05-10 Juanma Barranquero <lekktu@gmail.com>
3105
3106 * image.c (Finit_image_library): Return t for built-in image types,
3107 like pbm and xbm. (Bug#8640)
3108
57679c86
AS
31092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3110
3111 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3112
888c9e86
EZ
31132011-05-07 Eli Zaretskii <eliz@gnu.org>
3114
b0512a1d
EZ
3115 * w32console.c (Fset_screen_color): Doc fix.
3116 (Fget_screen_color): New function.
3117 (syms_of_ntterm): Defsubr it.
3118
7285dc67
EZ
3119 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3120 unlink the temporary file if Fcall_process didn't create it in the
3121 first place.
3122 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3123 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3124 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3125 cue to call_process_cleanup not to close that handle.
3126
4d3fcc8e
BK
31272011-05-07 Ben Key <bkey76@gmail.com>
3128
3129 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3130 one of two shell specific rules, either bootstrap-temacs-CMD or
3131 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3132 to the previous implementation of the bootstrap-temacs rule.
3133 The bootstrap-temacs-CMD rule is similar to the previous
3134 implementation of the bootstrap-temacs rule except that it
3135 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3136 variable.
3137
3138 These changes, along with some changes to nt/configure.bat,
3139 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3140 earlier fix to add support for --cflags and --ldflags options
3141 that include quotes so that it works whether make uses cmd or
3142 sh as the shell.
3143
b4289b64
MA
31442011-05-06 Michael Albinus <michael.albinus@gmx.de>
3145
3146 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3147 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3148 is a constant.
3149 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3150 a string. Handle both cases.
3151 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3152 (Fdbus_register_method): Use Qinvalid_function.
3153
af4c0e28
JB
31542011-05-06 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * makefile.w32-in: Update dependencies.
3157 (LISP_H): Add inttypes.h and stdin.h.
3158 (PROCESS_H): Add unistd.h.
3159
c51453d9
EZ
31602011-05-06 Eli Zaretskii <eliz@gnu.org>
3161
3162 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3163 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3164
8ff0ac3c 31652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3166
4c4b566b
PE
3167 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3168
aab2b9b5
PE
3169 * term.c (vfatal): Remove stray call to va_end.
3170 It's not needed and the C Standard doesn't allow it here anyway.
3171
c378da0b
PE
3172 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3173 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3174
288b08c7
PE
3175 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3176 bytes.
3177
e3601888
PE
3178 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3179
db6c0e74
PE
3180 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3181
dd5963ea
PE
3182 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3183
88c9450f
PE
3184 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3185
2f9442b8
PE
3186 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3187
c032b5f8
PE
3188 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3189 * charset.c (Fdefine_charset_internal): Don't initialize
3190 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3191 32-bit int (Bug#8600).
a108c10b
PE
3192
3193 * lread.c (read_integer): Be more consistent with string-to-number.
3194 Use string_to_number to do the actual conversion; this avoids
3195 rounding errors and fixes some other screwups. Without this fix,
3196 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3197 (digit_to_number): Move earlier, for benefit of read_integer.
3198 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3199 not a digit in any supported base. (Bug#8602)
a108c10b 3200
ad5f9eea
PE
3201 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3202
aec1708a
PE
3203 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3204 to match comment at start of function. This also removes a
3205 GCC warning about overflow in a 32+64-bit port.
3206
47be4ab5
PE
3207 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3208
371cac43
PE
3209 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3210 Reported by Stefan Monnier in
3211 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3212 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3213 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3214
d01a7826
PE
3215 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3216 (EMACS_UINTPTR): Likewise, with uintptr_t.
3217
7fd47d5c
PE
3218 * lisp.h: Prefer 64-bit EMACS_INT if available.
3219 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3220 on 32-bit hosts that have 64-bit int, so that they can access
3221 large files.
122b0c86
PE
3222 However, temporarily disable this change unless the temporary
3223 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3224
8727937b
PE
3225 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3226
8ac068ac
PE
3227 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3228 This removes an assumption that EMACS_INT and long are the same
3229 width as pointers. The assumption is true for Emacs porting targets
3230 now, but we want to make other targets possible.
3231 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3232 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3233 In the rest of the code, change types of integers that hold casted
3234 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3235 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3236 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3237 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3238 No need to cast type when ORing.
3239 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3240 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3241 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3242 assume EMACS_INT is the same width as char *.
3243 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3244 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3245 Remove no-longer-needed casts.
3246 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3247 (xg_tool_bar_help_callback, xg_make_tool_item):
3248 Use EMACS_INTPTR to hold an integer
3249 that will be cast to void *; this can avoid a GCC warning
3250 if EMACS_INT is not the same width as void *.
3251 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3252 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3253 (current_message_1, set_message_1):
3254 Use a local to convert to proper width without a cast.
3255 * xmenu.c (dialog_selection_callback): Likewise.
3256
ede49d71
PE
3257 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3258 Also, don't assume VALBITS / RAND_BITS is less than 5,
3259 and don't rely on undefined behavior when shifting a 1 left into
3260 the sign bit.
3261 * lisp.h (get_random): Change signature to match.
3262
2f30ecd0
PE
3263 * lread.c (hash_string): Use size_t, not int, for hash computation.
3264 Normally we prefer signed values; but hashing is special, because
3265 it's better to use unsigned division on hash table sizes so that
3266 the remainder is nonnegative. Also, size_t is the natural width
3267 for hashing into memory. The previous code used 'int', which doesn't
3268 retain enough info to hash well into very large tables.
3269 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3270
2a866e7b
PE
3271 * dbusbind.c: Don't possibly lose pointer info when converting.
3272 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3273 Use XPNTR rather than XHASH, so that the high-order bits of
3274 the pointer aren't lost when converting through void *.
3275
51639eac
PE
3276 * eval.c (Fautoload): Don't double-shift a pointer.
3277
92394119
PE
3278 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3279
dbdb9a7c
JB
32802011-05-06 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * gnutls.c (DEF_GNUTLS_FN):
3283 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3284
db7a0b4f
AS
32852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3286
3287 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3288 marker. (Bug#8610)
3289
f7ff1b0f 32902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3291
3292 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3293 New version that can reserve upto 2GB of heap space.
3294
f7ff1b0f 32952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3296
3297 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3298
639c109b
TZ
32992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3300
3301 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3302 `gnutls_certificate_set_x509_key_file'.
3303
d2127135
JB
33042011-05-05 Juanma Barranquero <lekktu@gmail.com>
3305
3306 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3307 Update dependencies.
3308
e968f4f3
JB
33092011-05-04 Juanma Barranquero <lekktu@gmail.com>
3310
3311 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3312 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3313 Remove unused parameter `fildes'.
3314 * process.c (read_process_output, send_process): Don't pass it.
3315
84d358f0
JB
33162011-05-04 Juanma Barranquero <lekktu@gmail.com>
3317
3318 Fix previous change: the library cache is defined in w32.c.
3319 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3320 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3321
0898ca10
JB
33222011-05-04 Juanma Barranquero <lekktu@gmail.com>
3323
3324 Implement dynamic loading of GnuTLS on Windows.
3325
3326 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3327 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3328 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3329 Declare.
3330
3331 * gnutls.c (Qgnutls_dll): Define.
3332 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3333 (gnutls_*): Declare function pointers.
3334 (init_gnutls_functions): New function to initialize function pointers.
3335 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3336 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3337 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3338 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3339 (emacs_gnutls_write, emacs_gnutls_read)
3340 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3341 (Fgnutls_available_p): New function.
3342 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3343 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3344 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3345
3346 * image.c: Include w32.h.
3347 (Vimage_type_cache): Delete.
3348 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3349 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3350 (w32_delayed_load): Move to w32.c.
3351
3352 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3353
3354 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3355 (w32_delayed_load): Move from image.c. When loading a library, record
3356 its filename in the :loaded-from property of the library id.
3357 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3358 Initialize and staticpro them.
3359 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3360
3361 * process.c: Include lisp.h before w32.h, not after.
3362 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3363 instead of gnutls_record_check_pending.
3364
3365 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3366
ff4de4aa
TZ
33672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3368
3369 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3370 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3371 as passed in.
3372
abe95abb
JD
33732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3374
3375 * xterm.c (x_set_frame_alpha): Do not set property on anything
3376 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3377
e16e55d4
JB
33782011-05-02 Juanma Barranquero <lekktu@gmail.com>
3379
3380 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3381
bafcf6a5
JB
33822011-05-02 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3385 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3386 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3387 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3388 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3389 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3390 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3391 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3392 (Qgnutls_bootprop_callbacks_verify): Make static.
3393
e7a6747f
AS
33942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3395
19ed11ba
AS
3396 * callproc.c: Indentation fixup.
3397
e7a6747f 3398 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3399 (wait_for_termination, interruptible_wait_for_termination):
3400 Move after wait_for_termination_1.
e7a6747f 3401
1ef14cb4
LMI
34022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3403
3404 * sysdep.c (interruptible_wait_for_termination): New function
3405 which is like wait_for_termination, but allows keyboard
3406 interruptions.
3407
3408 * callproc.c (Fcall_process): Add (:file "file") as an option for
3409 the STDOUT buffer.
3410 (Fcall_process_region): Ditto.
3411
330d880c
EZ
34122011-04-30 Eli Zaretskii <eliz@gnu.org>
3413
8db90b73
EZ
3414 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3415 rather than `XVECTOR (FOO)->size'.
3416
330d880c
EZ
3417 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3418 inttypes.h, as a gnulib replacement is used if it not available in
3419 system headers.
3420
15cbd324
EZ
34212011-04-21 Eli Zaretskii <eliz@gnu.org>
3422
3423 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3424 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3425 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3426
3427 * coding.c (coding_alloc_by_realloc): Error out if destination
3428 will grow beyond MOST_POSITIVE_FIXNUM.
3429 (decode_coding_emacs_mule): Abort if there isn't enough place in
3430 charbuf for the composition carryover bytes. Reserve an extra
3431 space for up to 2 characters produced in a loop.
3432 (decode_coding_iso_2022): Abort if there isn't enough place in
3433 charbuf for the composition carryover bytes.
3434
34352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3436
ae940cca
EZ
3437 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3438 aborting when %lld or %lll format is passed.
3439 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3440 %llo or %llx format is passed. (Bug#8545)
3441
03ab8921
EZ
3442 * window.c (window_scroll_line_based): Use a marker instead of
3443 simple variables to record original value of point. (Bug#7952)
3444
afda1437
EZ
3445 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3446 produced by %s or %c overflows available buffer space. (Bug#8545)
3447
f76dee0c
PE
34482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3449
3450 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3451 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3452
fdc5744d
JB
34532011-04-28 Juanma Barranquero <lekktu@gmail.com>
3454
3455 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3456
638f053a
JB
34572011-04-28 Juanma Barranquero <lekktu@gmail.com>
3458
3459 * keyboard.c (Qdelayed_warnings_hook): Define.
3460 (command_loop_1): Run `delayed-warnings-hook'
3461 if Vdelayed_warnings_list is non-nil.
3462 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3463 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3464
d178f871
EZ
34652011-04-28 Eli Zaretskii <eliz@gnu.org>
3466
3467 * doprnt.c (doprnt): Don't return value smaller than the buffer
3468 size if the message was truncated. (Bug#8545).
3469
b124fd93
JB
34702011-04-28 Juanma Barranquero <lekktu@gmail.com>
3471
3472 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3473 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3474
e810457d
PE
34752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3478
ea51cceb
JB
34792011-04-27 Juanma Barranquero <lekktu@gmail.com>
3480
3481 * makefile.w32-in: Update dependencies.
3482
94dcfacf
EZ
34832011-04-27 Eli Zaretskii <eliz@gnu.org>
3484
3485 Improve `doprnt' and its usage. (Bug#8545)
3486 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3487 `format_end'. Remove support for %l as a conversion specifier.
3488 Don't use xrealloc. Improve diagnostics when the %l size modifier
3489 is used. Update the commentary.
3490
3491 * eval.c (verror): Simplify calculation of size_t.
3492
3493 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3494 messages.
3495
f61f41d7
PE
34962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3497
3498 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3499 change.
3500
96fb4434
PE
35012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3502
3503 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3504 This makes this file independent of the recent pseudovector change.
3505
671875da 35062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3507
69e9b5a3
PE
3508 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3509
b5f869a7 3510 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3511 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3512 Remove unused local.
c8926152 3513 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3514
841a1577 3515 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3516 GCC 4.6.0 optimizes based on type-based alias analysis.
3517 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3518 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3519 != &v->size, and therefore "v->size = 1; b->size = 2; return
3520 v->size;" must therefore return 1. This assumption is incorrect
3521 for Emacs, since it type-puns struct Lisp_Vector * with many other
3522 types. To fix this problem, this patch adds a new type struct
f904488f 3523 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3524 and pseudovectors, and helps optimizing compilers not get fooled
3525 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3526 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3527 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3528 the size member.
eab3844f
PE
3529 (XSETPVECTYPE): Rewrite in terms of new macro.
3530 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3531 This is a bit clearer, and further avoids the possibility of
3532 undesirable aliasing.
3533 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3534 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3535 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3536 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3537 (ASIZE): Now uses header.size rather than size.
3538 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3539 to avoid the hassle of writing XVECTOR (foo)->header.size.
3540 (struct vectorlike_header): New type.
eab3844f
PE
3541 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3542 object, to help avoid aliasing.
3543 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3544 (SUBRP): Likewise, since Lisp_Subr is a special case.
3545 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3546 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3547 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3548 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3549 changed to be "header.size" and "header.next".
3550 * buffer.h (struct buffer): Likewise.
3551 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3552 * frame.h (struct frame): Likewise.
3553 * process.h (struct Lisp_Process): Likewise.
3554 * termhooks.h (struct terminal): Likewise.
3555 * window.c (struct save_window_data, struct saved_window): Likewise.
3556 * window.h (struct window): Likewise.
3557 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3558 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3559 * buffer.c (init_buffer_once): Likewise.
3560 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3561 special case.
3562 * process.c (Fformat_network_address): Use local var for size,
3563 for brevity.
3564
0df1eac5
PE
3565 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3566
847ab9d1 3567 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3568 * data.c (atof): Remove decl; no longer used or needed.
3569 (digit_to_number): Move to lread.c.
3570 (Fstring_to_number): Use new string_to_number function, to be
3571 consistent with how the Lisp reader treats infinities and NaNs.
3572 Do not assume that floating-point numbers represent EMACS_INT
3573 without losing information; this is not true on most 64-bit hosts.
3574 Avoid double-rounding errors, by insisting on integers when
3575 parsing non-base-10 numbers, as the documentation specifies.
3576 * lisp.h (string_to_number): New decl, replacing ...
3577 (isfloat_string): Remove.
bc0a5c13 3578 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3579 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3580 appears to have been a coding error. Similarly, do not accept
3581 strings like +-1e0 as floating point numbers. Do not report
3582 overflow for integer overflows unless the base is not 10 which
3583 means we have no simple and reliable way to continue.
3584 Break out the floating-point parsing into a new
3585 function string_to_number, so that Fstring_to_number parses
3586 floating point numbers consistently with the Lisp reader.
04f2d78b 3587 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3588 (E_CHAR, EXP_INT): Remove, replacing with ...
3589 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3590 (string_to_number): New function, replacing isfloat_string.
3591 This function checks for valid syntax and produces the resulting
3592 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3593 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3594 so that overflow for non-base-10 numbers is reported only when
3595 there's no portable and simple way to convert to floating point.
452f4150 3596
67769ffc
PE
3597 * textprop.c (set_text_properties_1): Rewrite for clarity,
3598 and to avoid GCC warning about integer overflow.
3599
c20db43f
PE
3600 * intervals.h (struct interval): Use EMACS_INT for members
3601 where EMACS_UINT might cause problems. See
3602 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3603 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3604 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3605 All uses changed.
37aa2f85
PE
3606 (offset_intervals): Tell GCC not to worry about length overflow
3607 when negating a negative length.
c20db43f 3608
2538aa2f
PE
3609 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3610 (overrun_check_free): Likewise.
3611
f2d3008d
PE
3612 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3613 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3614 word size.
3615
ec8df744
PE
3616 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3617 (gnutls_make_error): Rename local to avoid shadowing.
3618 (gnutls_emacs_global_deinit): ifdef out; not used.
3619 (Fgnutls_boot): Use const for pointer to readonly storage.
3620 Comment out unused local. Fix pointer signedness problems.
3621
640ee02d
PE
3622 * lread.c (openp): Don't stuff size_t into an 'int'.
3623 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3624 about possible signed overflow.
3625
6048fb2a
PE
3626 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3627 (GDK_KEY_g): Don't define if already defined.
3628 (xg_prepare_tooltip): Avoid pointer signedness problem.
3629 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3630
fa3c87e1
PE
3631 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3632 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3633
2172544b
PE
3634 * xfns.c (Fx_window_property): Simplify a bit,
3635 to make a bit faster and to avoid GCC 4.6.0 warning.
3636 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3637
9b821a21
PE
3638 * fns.c (internal_equal): Don't assume size_t fits in int.
3639
3c616cfa
PE
3640 * alloc.c (compact_small_strings): Tighten assertion a little.
3641
c2982e87
PE
3642 Replace pEd with more-general pI, and fix some printf arg casts.
3643 * lisp.h (pI): New macro, generalizing old pEd macro to other
3644 conversion specifiers. For example, use "...%"pI"d..." rather
3645 than "...%"pEd"...".
3646 (pEd): Remove. All uses replaced with similar uses of pI.
3647 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3648 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3649 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3650 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3651 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3652 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3653 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3654 64-bit hosts.
3655 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3656 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3657 * print.c (safe_debug_print, print_object): Likewise.
3658 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3659 to int.
6f04d126
PE
3660 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3661 avoiding the 0 flag, which is not portable.
c2982e87
PE
3662 * process.c (Fmake_network_process): Use pI to avoid cast.
3663 * region-cache.c (pp_cache): Likewise.
3664 * xdisp.c (decode_mode_spec): Likewise.
3665 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3666 behavior on 64-bit hosts with printf arg.
6f04d126 3667 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3668 (x_stop_queuing_selection_requests): Likewise.
3669 (x_get_window_property): Don't truncate byte count to an 'int'
3670 when tracing.
0b432f21 3671
5e073ec7
PE
3672 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3673 here, since it parses constructs like leading '-' and spaces,
3674 which are not wanted; and it overflows with large numbers.
3675 Instead, simply match F[0-9]+, which is what is wanted anyway.
3676
36372bf9
PE
3677 * alloc.c: Remove unportable assumptions about struct layout.
3678 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3679 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3680 (allocate_vectorlike, make_pure_vector): Use the new macros,
3681 plus offsetof, to remove unportable assumptions about struct layout.
3682 These assumptions hold on all porting targets that I know of, but
3683 they are not guaranteed, they're easy to remove, and removing them
3684 makes further changes easier.
3685
0b432f21
PE
3686 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3687 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3688 (string_overrun_cookie): Now const. Use initializers that
3689 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3690 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3691 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3692 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3693 multiple of sizeof (EMACS_INT); it need not be, if
3694 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3695 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3696
895009e1
JB
36972011-04-26 Juanma Barranquero <lekktu@gmail.com>
3698
3699 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3700
6a7a1b0b
TZ
37012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3702
3703 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3704 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3705 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3706
841a1577 37072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3708
3709 * lisp.h (Qdebug): List symbol.
895009e1 3710 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3711 * keyboard.c (debug-on-event): New variable.
3712 (handle_user_signal): Break into debugger when debug-on-event
3713 matches the current signal symbol.
3714
f2d3ba6f
DN
37152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3716
3717 * alloc.c (check_sblock, check_string_bytes)
3718 (check_string_free_list): Convert to standard C.
3719
42ce4c63
TZ
37202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3721
3722 * w32.c (emacs_gnutls_push): Fix typo.
3723
825cd63c
EZ
37242011-04-25 Eli Zaretskii <eliz@gnu.org>
3725
fb11d64d
EZ
3726 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3727 "cast to pointer from integer of different size".
3728
825cd63c
EZ
3729 Improve doprnt and its use in verror. (Bug#8545)
3730 * doprnt.c (doprnt): Document the set of format control sequences
3731 supported by the function. Use SAFE_ALLOCA instead of always
3732 using `alloca'.
3733
3734 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3735 is one byte too soon. Don't use xrealloc; instead xfree and
3736 xmalloc anew.
3737
e061a11b
TZ
37382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3739
3740 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3741 callbacks stage.
3742
3743 * gnutls.c: Renamed global_initialized to
3744 gnutls_global_initialized. Added internals for the
3745 :verify-hostname-error, :verify-error, and :verify-flags
3746 parameters of `gnutls-boot' and documented those parameters in the
3747 docstring. Start callback support.
9173deec
JB
3748 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3749 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3750 on error. Return error code.
e061a11b
TZ
3751 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3752 (emacs_gnutls_read): Likewise.
3753 (Fgnutls_boot): Return handshake error code.
3754 (emacs_gnutls_handle_error): New function.
3755 (wsaerror_to_errno): Likewise.
3756
3757 * w32.h (emacs_gnutls_pull): Add prototype.
3758 (emacs_gnutls_push): Likewise.
3759
3760 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3761 (emacs_gnutls_push): Likewise.
3762
37632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3764
3765 * process.c (wait_reading_process_output): Check if GnuTLS
3766 buffered some data internally if no FDs are set for TLS
3767 connections.
3768
3769 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3770 (LIBS): Link to USER_LIBS.
3771 ($(BLD)/gnutls.$(0)): New target.
3772
fa6996bc
EZ
37732011-04-24 Eli Zaretskii <eliz@gnu.org>
3774
eb35682e
EZ
3775 * xdisp.c (handle_single_display_spec): Rename the
3776 display_replaced_before_p argument into display_replaced_p, to
3777 make it consistent with the commentary. Fix typos in the
3778 commentary.
3779
e2ad650c
EZ
3780 * textprop.c (syms_of_textprop): Remove dead code.
3781 (copy_text_properties): Delete obsolete commentary about an
3782 interface that was deleted long ago. Fix typos in the description
3783 of arguments.
3784
1b2de274
EZ
3785 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3786 to changes in oldXMenu/XMenu.h from 2011-04-16.
3787 <menu_help_message, prev_menu_help_message>: Constify.
3788 (IT_menu_make_room): menu->help_text is now `const char **';
3789 adjust.
3790
3791 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3792 to changes in oldXMenu/XMenu.h from 2011-04-16.
3793 (struct XMenu): Declare `help_text' `const char **'.
3794
3795 * xfaces.c <Qunspecified>: Make extern again.
3796
3797 * syntax.c: Include sys/types.h before including regex.h, as
3798 required by Posix.
3799
762b15be
EZ
3800 * doc.c (get_doc_string): Improve the format passed to `error'.
3801
3802 * doprnt.c (doprnt): Improve commentary.
3803
3804 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3805
3806 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3807 them with etags.
3808
f1052e5d
EZ
3809 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3810 changes in globals.h immediately force recompilation.
762b15be
EZ
3811 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3812 $(CURDIR)/s/ms-w32.h.
3813 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3814
fa6996bc
EZ
3815 * character.c (Fchar_direction): Function deleted.
3816 (syms_of_character): Don't defsubr it.
3817 <char-direction-table>: Deleted.
3818
e6c3da20
EZ
38192011-04-23 Eli Zaretskii <eliz@gnu.org>
3820
3821 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3822 * doprnt.c: Include limits.h.
3823 (SIZE_MAX): New macro.
04f2d78b
CB
3824 (doprnt): Return a size_t value. 2nd arg is now size_t.
3825 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3826 Improve overflow protection. Support `l' modifier for integer
3827 conversions. Support %l conversion. Don't assume an EMACS_INT
3828 argument for integer conversions and for %c.
3829
3830 * lisp.h (doprnt): Restore prototype.
3831
3832 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3833 $(SRC)/character.h.
3834
3835 * Makefile.in (base_obj): Add back doprnt.o.
3836
3837 * deps.mk (doprnt.o): Add back prerequisites.
3838 (callint.o): Depend on character.h.
3839
3840 * eval.c (internal_lisp_condition_case): Include the handler
3841 representation in the error message.
3842 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3843 when breaking from the loop.
3844
3845 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3846
3847 * callint.c (Fcall_interactively): When displaying error message
3848 about invalid control letter, pass the character's codepoint, not
3849 a pointer to its multibyte form. Improve display of the character
3850 in octal and display also its hex code.
3851
3852 * character.c (char_string): Use %x to display the (unsigned)
3853 codepoint of an invalid character, to avoid displaying a bogus
3854 negative value.
3855
3856 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3857 `error', not SYMBOL_NAME itself.
3858
3859 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3860 character arguments to `error'.
3861
3862 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3863 to `error' in error message about FINAL_CHAR argument. Make sure
3864 FINAL_CHAR is a character, and use %c when it is passed as
3865 argument to `error'.
3866
4ffd0d6b 38672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3868
3869 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3870
3871 * w32.c: Include <time.h>.
3872 (sys_localtime): New function.
3873
4ffd0d6b 38742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3875
3876 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3877
4ffd0d6b 3878 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3879
4ffd0d6b 38802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3881
4ffd0d6b
GM
3882 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3883 zombies (Bug#8467).
aac0c6e3 3884
04c56954
EZ
38852011-04-19 Eli Zaretskii <eliz@gnu.org>
3886
3887 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3888 gl_state.e_property when gl_state.object is Qt.
3889
3890 * insdel.c (make_gap_larger): Remove limitation of buffer size
3891 to <= INT_MAX.
3892
16a43933
CY
38932011-04-18 Chong Yidong <cyd@stupidchicken.com>
3894
3895 * xdisp.c (lookup_glyphless_char_display)
3896 (produce_glyphless_glyph): Handle cons cell entry in
3897 glyphless-char-display.
3898 (Vglyphless_char_display): Document it.
3899
3900 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3901 glyphless-char-display.
3902
4581706e
CY
39032011-04-17 Chong Yidong <cyd@stupidchicken.com>
3904
3905 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3906
3907 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3908
3909 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3910 definition for no-X builds.
3911
4887c6e2 39122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3913
fd35b6f9
PE
3914 Static checks with GCC 4.6.0 and non-default toolkits.
3915
5c1ccb01
PE
3916 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3917
006c5daa
PE
3918 * process.c (keyboard_bit_set): Define only if SIGIO.
3919 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3920 (send_process): Repair possible setjmp clobbering.
3921
efc736d3
PE
3922 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3923
4e2fe2e6
PE
3924 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3925
f97334a2
PE
3926 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3927
4e75f29d
PE
3928 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3929 Define only if needed.
3930
90efadd1
PE
3931 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3932 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3933 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3934
3c647824
PE
3935 * dispextern.h (struct redisplay_interface): Rename param
3936 to avoid shadowing.
e264f262 3937 * termhooks.h (struct terminal): Likewise.
761383f4 3938 * xterm.c (xembed_send_message): Likewise.
3c647824 3939
b58c5c4a
PE
3940 * insdel.c (make_gap_smaller): Define only if
3941 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3942
cad59032
PE
3943 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3944 it.
3945
c339dc2e
PE
3946 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3947 so that we aren't warned about unused symbols.
3948
91a3e27b
PE
3949 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3950
399c71d3 3951 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3952
8ffc96f5
PE
3953 * xfns.c (x_real_positions): Mark locals as initialized.
3954
eef9bc79
PE
3955 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3956
098db9dd
PE
3957 * xterm.c: Fix problems found by static analysis with other toolkits.
3958 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3959 (x_dispatch_event): Declare static if USE_GTK, and
3960 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3961 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3962 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3963 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3964 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3965
eb18f6cc
PE
3966 * xmenu.c (menu_help_callback): Pointer type fixes.
3967 Use const pointers when pointing at readonly data. Avoid pointer
3968 signedness clashes.
3969 (FALSE): Remove unused macro.
3970 (update_frame_menubar): Remove unused decl.
3971
1fe72bf8
PE
3972 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3973
60d9e1db
PE
3974 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3975 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3976 (single_menu_item): Rename local to avoid shadowing.
3977
39261c26
PE
3978 * keyboard.c (make_lispy_event): Remove unused local var.
3979
018c5e19
PE
3980 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3981 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3982
63d2b86e
PE
3983 * bitmaps: Change bitmaps from unsigned char back to the X11
3984 compatible char. Avoid the old compiler warnings about
3985 out-of-range initializers by using, for example, '\xab' rather
3986 than 0xab.
3987
aefd87e1
PE
3988 * xgselect.c (xgselect_initialize): Check vs interface
3989 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3990
bf501fb9
PE
3991 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3992
e9829fdf
PE
3993 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3994 to read-only memory.
3995
1086c095
PE
3996 * fns.c (vector): Remove; this old hack is no longer needed.
3997
2baccd04 3998 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3999 Remove unused var.
dde42981 4000 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4001
72391843 4002 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4003
436c16df 4004 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4005 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4006 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4007
92bb796d 4008 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4009 (x_term_init): Remove local to avoid shadowing.
92bb796d 4010
764430a3 4011 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4012
4013 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4014 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4015
d1dfb56c
EZ
40162011-04-16 Eli Zaretskii <eliz@gnu.org>
4017
c4354cb4
EZ
4018 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4019
d1dfb56c
EZ
4020 Fix regex.c, syntax.c and friends for buffers > 2GB.
4021 * syntax.h (struct gl_state_s): Declare character position members
4022 EMACS_INT.
4023
4024 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4025
04f2d78b
CB
4026 * textprop.c (verify_interval_modification, interval_of):
4027 Declare arguments EMACS_INT.
d1dfb56c
EZ
4028
4029 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4030 EMACS_INT.
4031
4032 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4033
4034 * indent.c (Fvertical_motion): Local variable it_start is now
4035 EMACS_INT.
4036
4037 * regex.c (re_match, re_match_2, re_match_2_internal)
4038 (bcmp_translate, regcomp, regexec, print_double_string)
4039 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4040 (re_compile_pattern, re_exec): Declare arguments and local
4041 variables `size_t' and `ssize_t' and return values `regoff_t', as
4042 appropriate.
4043 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4044 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4045 <compile_stack_type>: `size' and `avail' are now `size_t'.
4046
4047 * regex.h <regoff_t>: Use ssize_t, not int.
4048 (re_search, re_search_2, re_match, re_match_2): Arguments that
4049 specify buffer/string position and length are now ssize_t and
4050 size_t. Return type is regoff_t.
4051
613052cd
BK
40522011-04-16 Ben Key <bkey76@gmail.com>
4053
4054 * nsfont.m: Fixed bugs in ns_get_family and
4055 ns_descriptor_to_entity that were caused by using free to
4056 deallocate memory blocks that were allocated by xmalloc (via
4057 xstrdup). This caused Emacs to crash when compiled with
4058 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4059 --enable-checking=xmallocoverrun). xfree is now used to
4060 deallocate these memory blocks.
4061
4170f62f 40622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4063
71b41406
PE
4064 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4065
9587a89d
PE
4066 emacs_write: Accept and return EMACS_INT for sizes.
4067 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4068 et seq.
4069 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4070 Accept and return EMACS_INT.
4071 (emacs_gnutls_write): Return the number of bytes written on
4072 partial writes.
4073 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4074 (emacs_read, emacs_write): Remove check for negative size, as the
4075 Emacs source code has been audited now.
9587a89d
PE
4076 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4077 (emacs_read, emacs_write): Use it.
273a5f82
PE
4078 * process.c (send_process): Adjust to the new signatures of
4079 emacs_write and emacs_gnutls_write. Do not attempt to store
4080 a byte offset into an 'int'; it might overflow.
9587a89d 4081 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4082
3e047f51
PE
4083 * sound.c: Don't assume sizes fit in 'int'.
4084 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4085 Return EMACS_INT, not int.
3e047f51 4086 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4087 Accept EMACS_INT, not int.
4088 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4089 record read return values.
4090
cc39a9db
BK
40912011-04-15 Ben Key <bkey76@gmail.com>
4092
c9d0ec6d
JB
4093 * keyboard.c (Qundefined): Don't declare static since it is used
4094 in nsfns.m.
4095 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4096 static since they are used in nsfont.m.
cc39a9db 4097
6c60eb9f
SM
40982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4099
4100 * process.c (Qprocessp): Don't declare static.
4101 * lisp.h (Qprocessp): Declare again.
4102
7990b61a
JB
41032011-04-15 Juanma Barranquero <lekktu@gmail.com>
4104
4105 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4106
5d4cb038
PE
41072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4108
8bd7b830 4109 Improve C-level modularity by making more things 'static'.
cd64ea1d 4110
e3b27b31
PE
4111 Don't publish debugger-only interfaces to other modules.
4112 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4113 (verify_bytepos, count_markers): Move decls to the only modules
4114 that need them.
4115 * region-cache.h (pp_cache): Likewise.
4116 * window.h (check_all_windows): Likewise.
4117 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4118
5d4cb038
PE
4119 * sysdep.c (croak): Now static, if
4120 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4121 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4122
4123 * alloc.c (refill_memory_reserve): Now static if
4124 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4125 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4126
e87b6180
PE
4127 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4128 Define only if USE_LUCID.
4129
ac64929e
PE
4130 * xrdb.c (x_customization_string, x_rm_string): Now static.
4131
6f37259d
PE
4132 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4133 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4134
1683e3ab
PE
4135 * xdisp.c (draw_row_with_mouse_face): Now static.
4136 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4137
de9c2632
PE
4138 * window.h (check_all_windows): Mark externally visible.
4139
2b96acb7
PE
4140 * window.c (window_deletion_count): Now static.
4141
4142 * undo.c: Make symbols static if they're not exported.
4143 (last_undo_buffer, last_boundary_position, pending_boundary):
4144 Now static.
4145
50436f33
PE
4146 * textprop.c (interval_insert_behind_hooks): Now static.
4147 (interval_insert_in_front_hooks): Likewise.
4148
64520e5c
PE
4149 * term.c: Make symbols static if they're not exported.
4150 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4151 (max_frame_lines, tty_set_terminal_modes):
4152 (tty_reset_terminal_modes, tty_turn_off_highlight):
4153 (get_tty_terminal): Now static.
4154 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4155 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4156 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4157 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4158 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4159
1fa53021
PE
4160 * sysdep.c: Make symbols static if they're not exported.
4161 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4162 Now static.
4163 (sigprocmask_set, full_mask): Remove; unused.
4164 (wait_debugging): Mark as visible.
4165 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4166 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4167
d4b43b22
PE
4168 * syntax.c (syntax_temp): Define only if !__GNUC__.
4169
b7c513d0
PE
4170 * sound.c (current_sound_device, current_sound): Now static.
4171
989b29ad
PE
4172 * search.c (searchbufs, searchbuf_head): Now static.
4173
13a55a78
PE
4174 * scroll.c (scroll_cost): Remove; unused.
4175 * dispextern.h (scroll_cost): Remove decl.
4176
de68a1fc
PE
4177 * region-cache.h (pp_cache): Mark as externally visible.
4178
40ccffa6
PE
4179 * process.c: Make symbols static if they're not exported.
4180 (process_tick, update_tick, create_process, chan_process):
4181 (Vprocess_alist, proc_buffered_char, datagram_access):
4182 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4183 (deactivate_process): Mark defn as static, as well as decl.
4184 * lisp.h (create_process): Remove decl.
4185 * process.h (chan_process, Vprocess_alist): Remove decls.
4186
ad64fc97
PE
4187 * print.c: Make symbols static if they're not exported.
4188 (print_depth, new_backquote_output, being_printed, print_buffer):
4189 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4190 (print_interval, print_number_index, initial_stderr_stream):
4191 Now static.
4192 * lisp.h (Fprinc): Remove decl.
4193 (debug_output_compilation_hack): Mark as externally visible.
4194
adddb265
PE
4195 * sysdep.c (croak): Move decl from here to syssignal.h.
4196 * syssignal.h (croak): Put it here, so the API can be checked when
4197 'croak' is called from dissociate_if_controlling_tty.
4198
1717ede2
PE
4199 * minibuf.c: Make symbols static if they're not exported.
4200 (minibuf_save_list, choose_minibuf_frame): Now static.
4201 * lisp.h (choose_minibuf_frame): Remove decl.
4202
fa5fb2bc
PE
4203 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4204
1e3890d1
PE
4205 * lread.c: Make symbols static if they're not exported.
4206 (read_objects, initial_obarray, oblookup_last_bucket_number):
4207 Now static.
4208 (make_symbol): Remove; unused.
4209 * lisp.h (initial_obarray, make_symbol): Remove decls.
4210
8a1414fa
PE
4211 * keyboard.c: Make symbols static if they're not exported.
4212 (single_kboard, recent_keys_index, total_keys, recent_keys):
4213 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4214 (this_single_command_key_start, echoing, last_auto_save):
4215 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4216 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4217 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4218 (Vlispy_mouse_stem, double_click_count):
4219 Now static.
4220 (force_auto_save_soon): Define only if SIGDANGER.
4221 (ignore_mouse_drag_p): Now static if
4222 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4223 (print_help): Remove; unused.
4224 (stop_character, last_timer_event): Mark as externally visible.
4225 * keyboard.h (ignore_mouse_drag_p): Declare only if
4226 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4227 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4228 * lisp.h (echoing): Remove decl.
4229 (force_auto_save_soon): Declare only if SIGDANGER.
4230 * xdisp.c (redisplay_window): Simplify code, to make it more
4231 obvious that ignore_mouse_drag_p is not accessed if !defined
4232 USE_GTK && !defined HAVE_NS.
4233
93ea6e8f
PE
4234 * intervals.c: Make symbols static if they're not exported.
4235 (merge_properties_sticky, merge_interval_right, delete_interval):
4236 Now static.
4237 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4238
77382fcc
PE
4239 * insdel.c: Make symbols static if they're not exported.
4240 However, leave prepare_to_modify_buffer alone. It's never
4241 called from outside this function, but that appears to be a bug.
4242 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4243 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4244 (adjust_after_replace_noundo): Remove; unused.
4245 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4246 (signal_before_change): Remove decls.
77382fcc 4247
9306c32e
PE
4248 * indent.c (val_compute_motion, val_vmotion): Now static.
4249
cd44d2eb
PE
4250 * image.c: Make symbols static if they're not exported.
4251 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4252 if USE_GTK.
4253 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4254 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4255
ad9a7a06
PE
4256 * fringe.c (standard_bitmaps): Now static.
4257 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4258
81626931
PE
4259 * frame.c: Make symbols static if they're not exported.
4260 (x_report_frame_params, make_terminal_frame): Now static.
4261 (get_frame_param): Now static, unless HAVE_NS.
4262 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4263 (x_get_resource_string): Remove; not used.
4264 * frame.h (make_terminal_frame, x_report_frame_params):
4265 (x_get_resource_string); Remove decls.
4266 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4267 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4268
239f9db9
PE
4269 * font.c, fontset.c: Make symbols static if they're not exported.
4270 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4271 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4272 * font.c (font_close_object): Now static.
4273 * font.h (font_close_object): Remove.
4274 * fontset.c (FONTSET_OBJLIST): Remove.
4275 (free_realized_fontset) #if-0 the body, which does nothing.
4276 (face_suitable_for_char_p): #if-0, as it's never called.
4277 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4278 * xfaces.c (face_at_string_position):
4279 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4280 since 0 is always ASCII.
4281
dfcf3579
PE
4282 * fns.c (weak_hash_tables): Now static.
4283
5045092b
PE
4284 * fileio.c: Make symbols static if they're not exported.
4285 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4286 (Vwrite_region_annotation_buffers): Now static.
4287
57a96f5c
PE
4288 * eval.c: Make symbols static if they're not exported.
4289 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4290 * lisp.h (backtrace_list): Remove decl.
4291
35f08c38
PE
4292 * emacs.c: Make symbols static if they're not exported.
4293 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4294 (fatal_error_code, fatal_error_signal_hook, standard_args):
4295 Now static.
4296 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4297 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4298 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4299 * lisp.h (fatal_error_signal_hook): Remove decl.
4300 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4301
f44bd759
PE
4302 * editfns.c: Move a (normally-unused) function to its only use.
4303 * editfns.c, lisp.h (get_operating_system_release): Remove.
4304 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4305 worth the hassle of breaking this out.
4306
b532497d
PE
4307 * xterm.c: Make symbols static if they're not exported.
4308 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4309 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4310 (x_destroy_window, x_delete_display):
4311 Now static.
4312 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4313 (x_mouse_leave): Remove; unused.
4314 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4315 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4316 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4317 Remove decls.
4318 (x_mouse_leave): Declare only if WINDOWSNT.
4319 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4320 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4321 USE_X_TOOLKIT.
4322
1675728f
PE
4323 * ftxfont.c: Make symbols static if they're not exported.
4324 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4325 HAVE_FREETYPE.
4326 * font.h (ftxfont_driver): Likewise.
4327
e4cebfca
PE
4328 * xfns.c: Make symbols static if they're not exported.
4329 (x_last_font_name, x_display_info_for_name):
4330 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4331 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4332 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4333 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4334 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4335 (last_show_tip_args): Now static.
4336 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4337 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4338 (x_screen_planes): Remove; unused.
4339 * dispextern.h (x_screen_planes): Remove decl.
4340
5bf46f05
PE
4341 * dispnew.c: Make symbols static if they're not exported.
4342 * dispextern.h (redraw_garbaged_frames, scrolling):
4343 (increment_row_positions): Remove.
4344 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4345 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4346 Now static.
4347 (redraw_garbaged_frames): Remove; unused.
4348
435f4c28
PE
4349 * xfaces.c: Make symbols static if they're not exported.
4350 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4351 Remove decls.
4352 * xterm.h (defined_color): Remove decls.
4353 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4354 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4355 (menu_face_changed_default, defined_color, free_realized_face):
4356 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4357 (ascii_face_of_lisp_face): Remove; unused.
4358
8524aef3
PE
4359 * xdisp.c: Make symbols static if they're not exported.
4360 * dispextern.h (scratch_glyph_row, window_box_edges):
4361 (glyph_to_pixel_coords, set_cursor_from_row):
4362 (get_next_display_element, set_iterator_to_next):
4363 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4364 (show_mouse_face): Remove decls
4365 * frame.h (message_buf_print): Likewise.
4366 * lisp.h (pop_message, set_message, check_point_in_composition):
4367 Likewise.
4368 * xterm.h (set_vertical_scroll_bar): Likewise.
4369 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4370 (message_buf_print, scratch_glyph_row, displayed_buffer):
4371 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4372 (get_next_display_element, show_mouse_face, window_box_edges):
4373 (frame_to_window_pixel_xy, check_point_in_composition):
4374 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4375 (glyph_to_pixel_coords): Remove; unused.
4376
16390cd2
PE
4377 * dired.c (file_name_completion): Now static.
4378
4379 * dbusbind.c (xd_in_read_queued_messages): Now static.
4380
a25f4dfa
PE
4381 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4382 * data.c (circular_list_error): Remove.
4383
14a9c8df
PE
4384 * commands.h (last_point_position, last_point_position_buffer):
4385 (last_point_position_window): Remove decls.
4386 * keyboard.c: Make these variables static.
4387
04f2d78b
CB
4388 * coding.h (coding, code_convert_region, encode_coding_gap):
4389 Remove decls.
74ab6df5
PE
4390 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4391 (iso_code_class, detect_coding, code_convert_region): Now static.
4392 (encode_coding_gap): Remove; unused.
4393
38dfbee1
PE
4394 * chartab.c (chartab_chars, chartab_bits): Now static.
4395
a2cb4e63
PE
4396 * charset.h (charset_iso_8859_1): Remove decl.
4397 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4398 Now static.
4399
127198fd
PE
4400 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4401 * ccl.c (Vccl_program_table): Now static.
4402 (check_ccl_update): Remove; unused.
4403
d85b608f
PE
4404 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4405 * category.h: ... from here.
4406 * category.c (check_category_table, set_category_set): Now static.
4407
31cd66f3
PE
4408 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4409 * lisp.h: Remove these decls.
4410
c358e587
PE
4411 * buffer.c (buffer_count): Remove unused var.
4412
e78aecca
PE
4413 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4414 so that it's not optimized away.
4415 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4416 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4417 exported only to the debugger.
4418
e192d7d3 4419 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4420 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4421
92470028
PE
4422 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4423 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4424 was inaccessible from Lisp.
4425 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4426 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4427
244ed907
PE
4428 alloc.c: Import and export fewer symbols, and remove unused items.
4429 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4430 is defined.
4431 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4432 it's not optimized away by whole-program optimization.
4433 (message_enable_multibyte, free_misc): Remove.
4434 (catchlist, handlerlist, mark_backtrace):
4435 Declare only if BYTE_MARK_STACK.
4436 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4437 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4438 (message_enable_multibyte): Remove decl.
4439 (free_misc, interval_free_list, float_block, float_block_index):
4440 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4441 (cons_free_list, last_marked_index):
4442 Now static.
4443 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4444 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4445 (mark_backtrace): Define only if BYTE_MARK_STACK.
4446 * xdisp.c (message_enable_multibyte): Now static.
4447
61c2b50e 4448 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4449 This makes it easier for human readers (and static analyzers)
4450 to see whether these variables are used from other modules.
4451 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4452 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4453 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4454 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4455 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4456 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4457 * xmenu.c, xselect.c:
4458 Declare Q* vars static if they are not used in other modules.
4459 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4460 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4461 Remove decls of unexported vars.
4462 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4463
95c82688
PE
4464 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4465
16a97296
PE
4466 Make Emacs functions such as Fatom 'static' by default.
4467 This makes it easier for human readers (and static analyzers)
4468 to see whether these functions can be called from other modules.
4469 DEFUN now defines a static function. To make the function external
4470 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4471 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4472 (Finit_image_library):
16a97296
PE
4473 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4474 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4475 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4476 Remove decls, since these functions are now static.
4477 (Funintern, Fget_internal_run_time): New decls, since these functions
4478 were already external.
95c82688 4479
16a97296
PE
4480 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4481 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4482 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4483 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4484 * keyboard.c, keymap.c, lread.c:
4485 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4486 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4487 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4488 Mark functions with DEFUE instead of DEFUN,
4489 if they are used in other modules.
4490 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4491 decls for now-static functions.
4492 * buffer.h (Fdelete_overlay): Remove decl.
4493 * callproc.c (Fgetenv_internal): Mark as internal.
4494 * composite.c (Fremove_list_of_text_properties): Remove decl.
4495 (Fcomposition_get_gstring): New forward static decl.
4496 * composite.h (Fcomposite_get_gstring): Remove decl.
4497 * dired.c (Ffile_attributes): New forward static decl.
4498 * doc.c (Fdocumntation_property): New forward static decl.
4499 * eval.c (Ffetch_bytecode): New forward static decl.
4500 (Funintern): Remove extern decl; now in .h file where it belongs.
4501 * fileio.c (Fmake_symbolic_link): New forward static decl.
4502 * image.c (Finit_image_library): New forward static decl.
4503 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4504 * intervals.h (Fprevious_property_change):
4505 (Fremove_list_of_text_properties): Remove decls.
4506 * keyboard.c (Fthis_command_keys): Remove decl.
4507 (Fcommand_execute): New forward static decl.
4508 * keymap.c (Flookup_key): New forward static decl.
4509 (Fcopy_keymap): Now static.
4510 * keymap.h (Flookup_key): Remove decl.
4511 * process.c (Fget_process): New forward static decl.
4512 (Fprocess_datagram_address): Mark as internal.
4513 * syntax.c (Fsyntax_table_p): New forward static decl.
4514 (skip_chars): Remove duplicate decl.
4515 * textprop.c (Fprevious_property_change): New forward static decl.
4516 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4517 Now internal.
4518 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4519 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4520
785bbd42
PE
4521 * editfns.c (Fformat): Remove unreachable code.
4522
8b913b57
AS
45232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4524
4525 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4526 change. (Bug#8496)
4527
a6744a35
EZ
45282011-04-13 Eli Zaretskii <eliz@gnu.org>
4529
4530 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4531 when at ZV. (Bug#8487)
4532
e7974947
AS
45332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4534
baad03f0
AS
4535 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4536 (Bug#8437)
4537 * keyboard.c (parse_tool_bar_item): Likewise.
4538 * sound.c (sound_cleanup, alsa_close): Likewise.
4539 * termcap.c (tgetent): Likewise.
4540 * xfns.c (x_default_font_parameter): Likewise.
4541 * xsettings.c (read_and_apply_settings): Likewise.
4542
e7974947
AS
4543 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4544 (overrun_check_free): Protoize.
4545
28272684
PE
45462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4549 since callers should never pass a negative size.
4550 Change the signature to match that of plain 'read' and 'write'; see
4551 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4552 * lisp.h: Update prototypes of emacs_write and emacs_read.
4553
11997c76
EZ
45542011-04-11 Eli Zaretskii <eliz@gnu.org>
4555
4556 * xdisp.c (redisplay_window): Don't try to determine the character
4557 position of the scroll margin if the window start point w->startp
e896f03c 4558 is outside the buffer's accessible region. (Bug#8468)
11997c76 4559
8a2cbd72
EZ
45602011-04-10 Eli Zaretskii <eliz@gnu.org>
4561
4562 Fix write-region and its subroutines for buffers > 2GB.
4563 * fileio.c (a_write, e_write): Modify declaration of arguments and
4564 local variables to support buffers larger than 2GB.
4565 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4566
4567 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4568 argument, local variables, and return value.
4569
4570 * lisp.h: Update prototypes of emacs_write and emacs_read.
4571
4572 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4573
4073e537 45742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4575
1ebfdcb6
PE
4576 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4577
b2ded58d
PE
4578 Fix more problems found by GCC 4.6.0's static checks.
4579
7d66342c
PE
4580 * xdisp.c (vmessage): Use a better test for character truncation.
4581
bbf47d44
PE
4582 * charset.c (load_charset_map): <, not <=, for optimization,
4583 and to avoid potential problems with integer overflow.
9248994d 4584 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4585 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4586 * editfns.c (Fformat): Likewise.
1e69125e 4587 * syntax.c (skip_chars): Likewise.
3befa583 4588
e3019616
PE
4589 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4590 This also lets GCC 4.6.0 generate slightly better loop code.
4591
becfa255
PE
4592 * callint.c (Fcall_interactively): <, not <=, for optimization.
4593 (Fcall_interactively): Count the number of arguments produced,
4594 not the number of arguments given. This is simpler and lets GCC
4595 4.6.0 generate slightly better code.
4596
dae0cd48
PE
4597 * ftfont.c: Distingish more carefully between FcChar8 and char.
4598 The previous code passed unsigned char * to a functions like
4599 strlen and xstrcasecmp that expect char *, which does not
4600 conform to the C standard.
4601 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4602 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4603 char * when the C standard requires it.
4604
76032d70
PE
4605 * keyboard.c (read_char): Remove unused var.
4606
eb3f1cc8
PE
4607 * eval.c: Port to Windows vsnprintf (Bug#8435).
4608 Include <limits.h>.
4609 (SIZE_MAX): Define if the headers do not.
4610 (verror): Do not give up if vsnprintf returns a negative count.
4611 Instead, grow the buffer. This ports to Windows vsnprintf, which
4612 does not conform to C99. Problem reported by Eli Zaretskii.
4613 Also, simplify the allocation scheme, by avoiding the need for
4614 calling realloc, and removing the ALLOCATED variable.
4615
70476b54
PE
4616 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4617
12020a9e
PE
4618 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4619 But keep the doprint source code for now, as we might revamp it
4620 and use it again (Bug#8435).
ea6c7ae6
PE
4621 * lisp.h (doprnt): Remove.
4622 * Makefile.in (base_obj): Remove doprnt.o.
4623 * deps.mk (doprnt.o): Remove.
4624
5fdb398c
PE
4625 error: Print 32- and 64-bit integers portably (Bug#8435).
4626 Without this change, on typical 64-bit hosts error ("...%d...", N)
4627 was used to print both 32- and 64-bit integers N, which relied on
4628 undefined behavior.
4629 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4630 New macro.
4631 * lisp.h (error, verror): Mark as printf-like functions.
4632 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4633 Report overflow in size calculations when allocating printf buffer.
4634 Do not truncate output string at its first null byte.
4635 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4636 Truncate the output at a character boundary, since vsnprintf does not
4637 do that.
4638 * charset.c (check_iso_charset_parameter): Convert internal
4639 character to string before calling 'error', since %c now has the
4640 printf meaning.
4641 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4642 overflow when computing char to be passed to 'error'. Do not
4643 pass Lisp_Object to 'error'; pass the integer instead.
4644 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4645 formatted with plain %d.
4646
b189fa66
PE
4647 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4648
bff87ef0
PE
4649 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4650
7e2cac20
PE
4651 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4652
ce4d90b5
PE
4653 * xterm.c (x_catch_errors): Remove duplicate declaration.
4654
266c9547
PE
4655 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4656
79c49ad2
PE
4657 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4658
368f4090
JM
46592011-04-10 Jim Meyering <meyering@redhat.com>
4660
4661 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4662 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4663 return ssize_t not "int", and use size_t as the buffer length.
4664 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4665 * gnutls.h: Update declarations.
4666 * process.c (read_process_output): Use ssize_t, to match.
4667 (send_process): Likewise.
4668
a32d4040
CY
46692011-04-09 Chong Yidong <cyd@stupidchicken.com>
4670
4671 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4672
8546720e 46732011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4674
04f2d78b
CB
4675 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4676 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4677
8546720e
GM
4678 * xterm.c (handle_one_xevent):
4679 * xmenu.c (create_and_show_popup_menu):
4680 * xselect.c (x_decline_selection_request)
4681 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4682
0a2f5c1a 46832011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4684
4685 Fix some uses of `int' instead of EMACS_INT.
4686 * search.c (string_match_1, fast_string_match)
4687 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4688 (scan_buffer, find_next_newline_no_quit)
4689 (find_before_next_newline, search_command, Freplace_match)
4690 (Fmatch_data): Make some `int' variables be EMACS_INT.
4691
4692 * xdisp.c (display_count_lines): 3rd argument and return value now
4693 EMACS_INT. All callers changed.
4694 (pint2hrstr): Last argument is now EMACS_INT.
4695
4696 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4697 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4698 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4699 (decode_coding_utf_16, decode_coding_emacs_mule)
4700 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4701 (decode_coding_ccl, decode_coding_charset)
4702 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4703 (decode_coding_iso_2022, decode_coding_emacs_mule)
4704 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4705 <char_offset, last_offset>: Declare EMACS_INT.
4706 (encode_coding_utf_8, encode_coding_utf_16)
4707 (encode_coding_emacs_mule, encode_invocation_designation)
4708 (encode_designation_at_bol, encode_coding_iso_2022)
4709 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4710 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4711 Declare EMACS_INT.
4712 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4713 (encode_invocation_designation): Last argument P_NCHARS is now
4714 EMACS_INT.
4715 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4716 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4717
4718 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4719 All users changed.
4720
4721 * ccl.c (Fccl_execute_on_string): Declare some variables
4722 EMACS_INT.
4723
8546720e 47242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4725
4726 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4727
4e19a977
CS
47282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4729
4730 * process.c (Fformat_network_address): Doc fix.
4731
87302331
R
47322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4733
4734 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4735
cbb59342
CY
47362011-04-08 Chong Yidong <cyd@stupidchicken.com>
4737
4738 * keyboard.c (read_char): Call Lisp function help-form-show,
4739 instead of using internal_with_output_to_temp_buffer.
4740 (Qhelp_form_show): New var.
e0d38eeb 4741 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4742
4743 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4744
4745 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4746
e67a13ab
CY
47472011-04-06 Chong Yidong <cyd@stupidchicken.com>
4748
04f2d78b
CB
4749 * process.c (Flist_processes): Remove to Lisp.
4750 (list_processes_1): Delete.
e67a13ab 4751
973f782d
EZ
47522011-04-06 Eli Zaretskii <eliz@gnu.org>
4753
7c106b1e
EZ
4754 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4755
973f782d
EZ
4756 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4757
41cf7d1a 47582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4759
ca23cc88
PE
4760 Fix more problems found by GCC 4.6.0's static checks.
4761
f390e2d5
PE
4762 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4763
42eea0d0
PE
4764 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4765
b69769da 4766 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4767
f9541e84
PE
4768 * xdisp.c (vmessage): Mark as a printf-like function.
4769
13841b55
PE
4770 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4771
c136c10f
PE
4772 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4773
5e2d4a30
PE
4774 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4775 printf-like functions.
4776 (tiff_load): Add casts to remove these marks before passing them
4777 to system-supplied API.
4778
583f48b9
PE
4779 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4780
b25d760e
PE
4781 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4782 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4783 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4784 directly, rather than having caller test rule sign. This avoids
4785 some unnecessary tests.
4786 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4787 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4788 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4789
bc7b6697 4790 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4791 (xfont_open): Avoid unnecessary tests.
bc7b6697 4792
27ccc379
PE
4793 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4794
dcd5c89a
PE
4795 * composite.h, composite.c (composition_gstring_put_cache):
4796 Use EMACS_INT, not int, for length.
4797
b13a45c6
PE
4798 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4799 breaking out part of COMPOSITION_DECODE_RULE.
4800 (COMPOSITION_DECODE_RULE): Use it.
4801 * composite.c (get_composition_id): Remove unused local vars,
4802 by using the new macro.
4803
1e792e4d
PE
4804 * textprop.c (set_text_properties_1): Change while to do-while,
4805 since the condition is always true at first.
4806
dc6c6455 4807 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4808 (interval_deletion_adjustment): Return unsigned value.
4809 All uses changed.
dc6c6455 4810
aba7731a
PE
4811 * process.c (list_processes_1, create_pty, read_process_output):
4812 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4813 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4814 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4815 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4816 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4817
fdfc4bf3
PE
4818 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4819
fca8fe46 4820 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4821 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4822
06a0259a 4823 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4824 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4825 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4826
e7b9e80f
PE
4827 * print.c (print_error_message): Avoid int overflow.
4828
56201685
PE
4829 * font.c (font_list_entities): Redo for clarity,
4830 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4831
78834453 4832 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4833 (font_score): Avoid potential overflow in diff calculation.
78834453 4834
0bc0b309 4835 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4836 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4837
e610eaca
PE
4838 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4839
b895abce
PE
4840 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4841 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4842 can always succeed if overflow has undefined behavior.
4843
1f1d9321 4844 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4845 (wordify): Omit three unnecessary tests.
1f1d9321 4846
c59478bc
PE
4847 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4848 All callers changed. This avoids the need for an unused var.
4849
79b73827
PE
4850 * casefiddle.c (casify_region): Remove var that is set but not used.
4851
a4db5dfe
PE
4852 * dired.c (file_name_completion): Remove var that is set but not used.
4853
43aae36e
PE
4854 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4855
2a47c44d 4856 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4857 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4858
a37c69bf
PE
4859 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4860 Check for integer overflow on size calculations.
4861
328ab8e7
PE
4862 * buffer.c (Fprevious_overlay_change): Remove var that is set
4863 but not used.
4864
e5a2a5cb
PE
4865 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4866 Remove vars that are set but not used.
8d84a6eb 4867 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4868 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4869
a60e5f68
PE
4870 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4871
f661cb61 4872 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4873 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4874
f0397f5a
PE
4875 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4876 that are set but not used.
4877
8664db06 4878 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4879 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4880
6abdaa4a
PE
4881 * xselect.c (x_get_local_selection, x_handle_property_notify):
4882 Remove vars that are set but not used.
4883
0ce7538d 4884 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4885 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4886
9ae848fc
PE
4887 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4888 Remove var that is set but not used.
0b918413
PE
4889 (scroll_bar_windows_size): Now size_t, not int.
4890 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4891 Check for overflow.
9ae848fc 4892
a5a62657
PE
4893 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4894 (map_tty_color) [!defined MSDOS]: Likewise.
4895
5c5cdd39
PE
4896 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4897
66ebf983
PE
4898 * coding.c: Remove vars that are set but not used.
4899 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4900 All callers changed.
4901 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4902 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4903 (decode_coding_charset): Remove vars that are set but not used.
4904
1be4d761
PE
4905 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4906 that is set but not used.
4907
47553fa8
PE
4908 * print.c (print_object): Remove var that is set but not used.
4909
1f7196bf 4910 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4911 The gnulib version avoids calling malloc in the usual case,
4912 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4913 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4914 * filelock.c (current_lock_owner): Likewise.
4915 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4916 * sysdep.c: Include allocator.h, careadlinkat.h.
4917 (emacs_no_realloc_allocator): New static constant.
4918 (emacs_readlink): New function.
fdb61804
PE
4919 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4920 ../lib/careadlinkat.h.
d1fdcab7 4921
f84c17c7
SM
49222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4923
4924 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4925 first non-nil return value).
4926
ef3862ad
JD
49272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4928
4929 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4930 if not defined (Bug#8403).
4931
376a7006
JB
49322011-04-02 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * xdisp.c (display_count_lines): Remove parameter `start',
4935 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4936 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4937 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4938 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4939 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4940 and thereabouts. All callers changed.
4941 (get_per_char_metric): Remove parameter `f', unused since
4942 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4943
6ca3801d
JM
49442011-04-02 Jim Meyering <meyering@redhat.com>
4945
4946 do not dereference NULL upon failed strdup
4947 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4948 (ns_get_family): Likewise.
4949
d8e2b5ba
JB
49502011-04-02 Juanma Barranquero <lekktu@gmail.com>
4951
4952 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4953
8c74fcbd
JD
49542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4955
4956 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4957 later (Bug#8403).
4958
7200d79c
SM
49592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4960
03408648 4961 Add lexical binding.
7200d79c 4962
03408648
SM
4963 * window.c (Ftemp_output_buffer_show): New fun.
4964 (Fsave_window_excursion):
4965 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4966
4967 * lread.c (lisp_file_lexically_bound_p): New function.
4968 (Fload): Bind Qlexical_binding.
4969 (readevalloop): Remove `evalfun' arg.
4970 Bind Qinternal_interpreter_environment.
4971 (Feval_buffer): Bind Qlexical_binding.
4972 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4973 Mark as dynamic.
4974 (syms_of_lread): Declare `lexical-binding'.
4975
4976 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4977
4978 * keyboard.c (eval_dyn): New fun.
4979 (menu_item_eval_property): Use it.
ca105506
SM
4980
4981 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4982
03408648
SM
4983 * fns.c (concat, mapcar1): Accept byte-code-functions.
4984
4985 * eval.c (Fsetq): Handle lexical vars.
4986 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4987 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4988 (FletX, Flet): Obey lexical binding.
4989 (Fcommandp): Handle closures.
4990 (Feval): New `lexical' arg.
4991 (eval_sub): New function extracted from Feval. Use it almost
4992 everywhere where Feval was used. Look up vars in lexical env.
4993 Handle closures.
4994 (Ffunctionp): Move from subr.el.
4995 (Ffuncall): Handle closures.
4996 (apply_lambda): Remove `eval_flags'.
4997 (funcall_lambda): Handle closures and new byte-code-functions.
4998 (Fspecial_variable_p): New function.
4999 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5000 but without exporting it to Lisp.
23aba0ea 5001
23aba0ea 5002 * doc.c (Fdocumentation, store_function_docstring):
03408648 5003 * data.c (Finteractive_form): Handle closures.
23aba0ea 5004
03408648
SM
5005 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5006 interactive spec.
ba83908c 5007
04f2d78b
CB
5008 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5009 New byte-codes.
03408648
SM
5010 (exec_byte_code): New function extracted from Fbyte_code to handle new
5011 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5012
03408648 5013 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5014
03408648 5015 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5016
e2abce01
JB
50172011-03-31 Juanma Barranquero <lekktu@gmail.com>
5018
5019 * xdisp.c (redisplay_internal): Fix prototype.
5020
63696a73 50212011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5022
63696a73 5023 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5024 (try_scrolling): Use it when setting scroll_limit.
5025 Limit scrolling to 100 screen lines.
63696a73
EZ
5026 (redisplay_window): Even when falling back on "recentering",
5027 position point in the window according to scroll-conservatively,
5028 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5029
5030 (try_scrolling): When point is above the window, allow searching
5031 as far as scroll_max, or one screenful, to compute vertical
5032 distance from PT to the scroll margin position. This prevents
5033 try_scrolling from unnecessarily failing when
5034 scroll-conservatively is set to a value slightly larger than the
5035 window height. Clean up the case of PT below the margin at bottom
5036 of window: scroll_max can no longer be INT_MAX. When aggressive
5037 scrolling is in use, don't let point enter the opposite scroll
5038 margin as result of the scroll.
5039 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5040 threshold of 100 lines for never-recentering scrolling.
5041
e4cc2dfc
JB
50422011-03-31 Juanma Barranquero <lekktu@gmail.com>
5043
5044 * dispextern.h (move_it_by_lines):
5045 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5046 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5047 (message_log_check_duplicate): Remove parameters `prev_bol' and
5048 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5049 (redisplay_internal): Remove parameter `preserve_echo_area',
5050 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5051
5052 * indent.c (Fvertical_motion):
5053 * window.c (window_scroll_pixel_based, Frecenter):
5054 Don't pass `need_y_p' to `move_it_by_lines'.
5055
1c470562
SM
50562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5057
44f230aa
SM
5058 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5059 steal a few bits to be more compact.
5060 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5061 Remove unneeded casts.
5062
1c470562
SM
5063 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5064
888adce9
ZK
50652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5066
5067 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5068 binding" message (bug#7967).
5069
f838ed7b
PE
50702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5071
77861b95
PE
5072 Fix more problems found by GCC 4.6.0's static checks.
5073
de6dbc14
PE
5074 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5075 Remove unused local var.
5076
f838ed7b
PE
5077 * editfns.c (Fmessage_box): Remove unused local var.
5078
792c7b2b
PE
5079 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5080 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5081 Omit unused local vars.
c499e557 5082 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5083 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5084 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5085 Omit unused local var.
5086
ba0165e1
PE
5087 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5088 Don't assume string length fits in int.
32ad8845 5089 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5090 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5091
3c59b4c9
PE
5092 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5093 instead of alloca (Bug#8344).
5094
a3eed478 5095 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5096 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5097
eb4d412d
PE
5098 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5099
1658b401
PE
5100 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5101 concerns.
5102
5103 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5104
5105 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5106
9a2c6e05
PE
5107 * keyboard.c (syms_of_keyboard): Use the same style as later
5108 in this function when indexing through an array. This also
5109 works around GCC bug 48267.
5110
03d0a109
PE
5111 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5112
44f730c8
PE
5113 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5114
fe75f926
PE
5115 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5116 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5117
ffa8c828
PE
5118 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5119 This avoids undefined behavior on integer overflow, and is a bit
5120 more convenient anyway since it is compared to a size_t variable.
5121
c5101a77
PE
5122 Variadic C functions now count arguments with size_t, not int.
5123 This avoids an unnecessary limitation on 64-bit machines, which
5124 caused (substring ...) to crash on large vectors (Bug#8344).
5125 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5126 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5127 All variadic functions and their callers changed accordingly.
c5101a77
PE
5128 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5129 * data.c (arith_driver, float_arith_driver): Likewise.
5130 * editfns.c (general_insert_function): Likewise.
5131 * eval.c (struct backtrace.nargs, interactive_p)
5132 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5133 (funcall_lambda, mark_backtrace): Likewise.
5134 * fns.c (concat): Likewise.
5135 * frame.c (x_set_frame_parameters): Likewise.
5136 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5137 0 if not found, not -1. All callers changed.
5138
dd3f25f7
PE
5139 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5140 (stack_copy_size): Now size_t, not int.
5141 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5142
461c2ab9
JB
51432011-03-28 Juanma Barranquero <lekktu@gmail.com>
5144
5145 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5146 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5147 All callers changed.
5148
5149 * lisp.h (multibyte_char_to_unibyte):
5150 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5151 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5152 * character.h (CHAR_TO_BYTE8):
5153 * cmds.c (internal_self_insert):
5154 * editfns.c (general_insert_function):
5155 * keymap.c (push_key_description):
5156 * search.c (Freplace_match):
5157 * xdisp.c (message_dolog, set_message_1): All callers changed.
5158
f6d62986
SM
51592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5160
5161 * keyboard.c (safe_run_hook_funcall): New function.
5162 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5163 don't set the hook to nil, but remove the offending function instead.
5164 (Qcommand_hook_internal): Remove, unused.
5165 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5166 Vcommand_hook_internal.
5167
5168 * eval.c (enum run_hooks_condition): Remove.
5169 (funcall_nil, funcall_not): New functions.
5170 (run_hook_with_args): Call each function through a `funcall' argument.
5171 Remove `cond' argument, now redundant.
5172 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5173 (Frun_hook_with_args_until_failure): Adjust accordingly.
5174 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5175
1db5b1ad
JB
51762011-03-28 Juanma Barranquero <lekktu@gmail.com>
5177
5178 * dispextern.h (string_buffer_position): Remove declaration.
5179
5180 * print.c (strout): Remove parameter `multibyte', unused since
5181 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5182
5183 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5184 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5185 All callers changed.
5186
5187 * w32.c (_wsa_errlist): Use braces for struct initializers.
5188
5189 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5190 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5191 All callers changed.
5192 (string_buffer_position): Likewise. Also, make static (it's never
5193 used outside xdisp.c).
5194 (cursor_row_p): Remove parameter `w', unused since
5195 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5196 (decode_mode_spec): Remove parameter `precision', introduced during
5197 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5198 All callers changed.
5199
5ffb62aa
JD
52002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5201
5202 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5203
461c2ab9 52042011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5205
5206 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5207 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5208 (ns_update_auto_hide_menu_bar): New functions.
5209 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5210 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5211 ns_constrain_all_frames.
5212 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5213 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5214
5c380ffb
JD
52152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5216
5217 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5218
9af30bdf
GM
52192011-03-27 Glenn Morris <rgm@gnu.org>
5220
5221 * syssignal.h: Replace RETSIGTYPE with void.
5222 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5223 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5224 Replace SIGTYPE with void everywhere.
5225 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5226 * s/template.h (SIGTYPE): Remove commented out definition.
5227
e2abce01
JB
52282011-03-26 Eli Zaretskii <eliz@gnu.org>
5229
5230 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5231 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5232
f868cd8a
JB
52332011-03-26 Juanma Barranquero <lekktu@gmail.com>
5234
59eb0929
JB
5235 * w32.c (read_unc_volume): Use parameter `henum', instead of
5236 global variable `wget_enum_handle'.
5237
5238 * keymap.c (describe_vector): Remove parameters `indices' and
5239 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5240 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5241
f868cd8a
JB
5242 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5243
5244 * keyboard.c (timer_check): Remove parameter `do_it_now',
5245 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5246 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5247 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5248
5249 * keyboard.c (read_char):
5250 * w32menu.c (w32_menu_display_help):
5251 * xmenu.c (show_help_event, menu_help_callback):
5252 Adjust calls to `show_help_echo'.
5253
5254 * gtkutil.c (xg_maybe_add_timer):
5255 * keyboard.c (readable_events):
5256 * process.c (wait_reading_process_output):
5257 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5258
5259 * insdel.c (adjust_markers_gap_motion):
5260 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5261 (gap_left, gap_right): Don't call it.
5262
2ecf6fdb
CY
52632011-03-25 Chong Yidong <cyd@stupidchicken.com>
5264
5265 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5266 incurred during fontification.
5267
6b1f9ba4
JB
52682011-03-25 Juanma Barranquero <lekktu@gmail.com>
5269
5270 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5271 (DEFVAR_PER_BUFFER): Don't pass it.
5272
5273 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5274 (scrolling_window): Don't pass it.
5275
0f4a96b5
JB
52762011-03-25 Juanma Barranquero <lekktu@gmail.com>
5277
5278 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5279
5280 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5281 and `suffix'.
5282 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5283 of variables specific to SELinux and computation of `encoded_absname'.
5284
5285 * image.c (XPutPixel): Remove unused variable `height'.
5286
5287 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5288
5289 * unexw32.c (get_section_info): Remove unused variable `section'.
5290
5291 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5292 (system_process_attributes): Remove unused variable `sess'.
5293 (sys_read): Remove unused variable `err'.
5294
5295 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5296 (w32_wnd_proc): Remove unused variable `isdead'.
5297 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5298 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5299 (x_create_tip_frame): Remove unused variable `tem'.
5300
5301 * w32inevt.c (w32_console_read_socket):
5302 Remove unused variable `no_events'.
5303
5304 * w32term.c (x_draw_composite_glyph_string_foreground):
5305 Remove unused variable `width'.
5306
1149507c
JB
53072011-03-24 Juanma Barranquero <lekktu@gmail.com>
5308
5309 * w32term.c (x_set_glyph_string_clipping):
5310 Don't pass uninitialized region to CombineRgn.
5311
9c88f339
JB
53122011-03-23 Juanma Barranquero <lekktu@gmail.com>
5313
5314 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5315 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5316 (Fx_close_connection): Remove unused variable `i'.
5317
5318 * w32font.c (w32font_draw): Return number of glyphs.
5319 (w32font_open_internal): Remove unused variable `i'.
5320 (w32font_driver): Add missing initializer.
5321
5322 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5323 (fill_in_menu): Remove unused variable `items_added'.
5324
5325 * w32term.c (last_mouse_press_frame): Remove static global variable.
5326 (w32_clip_to_row): Remove unused variable `f'.
5327 (x_delete_terminal): Remove unused variable `i'.
5328
5329 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5330 (NOTHING): Remove unused static global variable.
5331 (uniscribe_check_otf): Remove unused variable `table'.
5332 (uniscribe_font_driver): Add missing initializers.
5333
dee091a3
JD
53342011-03-23 Julien Danjou <julien@danjou.info>
5335
5336 * term.c (Fsuspend_tty, Fresume_tty):
5337 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5338 * window.c (temp_output_buffer_show):
5339 * insdel.c (signal_before_change):
5340 * frame.c (Fhandle_switch_frame):
5341 * fileio.c (Fdo_auto_save):
5342 * emacs.c (Fkill_emacs):
5343 * editfns.c (save_excursion_restore):
5344 * cmds.c (internal_self_insert):
5345 * callint.c (Fcall_interactively):
5346 * buffer.c (Fkill_all_local_variables):
5347 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5348 Use Frun_hooks.
0f4a96b5 5349 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5350 unconditionnaly since it does the check itself.
5351
2c520ab5 53522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5353
c9c49752
PE
5354 Fix more problems found by GCC 4.5.2's static checks.
5355
8abc3f12
PE
5356 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5357 the first time through the loop, since we know p0 < p1 then.
5358 This also avoids a gcc -Wstrict-overflow warning.
5359
a2d26660
PE
5360 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5361 leading to a memory leak, possible in functions like
5362 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5363 of objects (Bug#8318).
a2d26660 5364
916c72e9
PE
5365 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5366 that could (at least in theory) be that large.
5367
19ab8a18
PE
5368 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5369 This is less likely to overflow, and avoids undefined behavior if
5370 overflow does occur. All callers changed. Use strtoul to scan
5371 for the unsigned long integer.
b7cbbd6f
PE
5372 (pint2hrstr): Simplify and tune code slightly.
5373 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5374
f0641eff
PE
5375 * scroll.c (do_scrolling): Work around GCC bug 48228.
5376 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5377
7f650bb9
PE
5378 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5379 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5380 (validate_x_resource_name): Simplify count usage.
5381 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5382
37dd57d1
PE
5383 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5384 fail (Bug#8306).
81e56e61 5385
699979fc 5386 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5387
401bf9b4
PE
5388 * process.c (Fmake_network_process): Use socklen_t, not int,
5389 where POSIX says socklen_t is required in portable programs.
5390 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5391 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5392 (Fmake_network_process, server_accept_connection):
5393 (wait_reading_process_output, read_process_output):
5394 Likewise.
5395
b93aacde
PE
5396 * process.c: Rename or move locals to avoid shadowing.
5397 (list_processes_1, Fmake_network_process):
5398 (read_process_output_error_handler, exec_sentinel_error_handler):
5399 Rename or move locals.
4dc343ee 5400 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5401 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5402 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5403 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5404 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5405
af8a867c 5406 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5407 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5408 Include tparam.h instead, since it declares them.
af8a867c
PE
5409 * cm.h (PC): Remove extern decl; tparam.h now does this.
5410 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5411 * terminfo.c: Include tparam.h, to check interfaces.
5412 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5413 (tparam): Adjust signature to match interface in tparam.h;
5414 this removes some undefined behavior. Check that outstring and len
5415 are zero, which they always are with Emacs.
5416 * tparam.h (PC, BC, UP): New extern decls.
5417
0248044d 5418 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5419 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5420
8ff096c1 5421 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5422 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5423 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5424 (ftfont_list): Remove unused local.
49eaafba
PE
5425 (get_adstyle_property, ftfont_pattern_entity):
5426 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5427 Rename locals to avoid shadowing.
8ff096c1 5428
e2be39f6
PE
5429 * xfont.c (xfont_list_family): Mark var as initialized.
5430
c9735e30
PE
5431 * xml.c (make_dom): Now static.
5432
8f5201ae
PE
5433 * composite.c (composition_compute_stop_pos): Rename local to
5434 avoid shadowing.
b246f932
PE
5435 (composition_reseat_it): Remove unused locals.
5436 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5437 (composition_update_it): Mark var as initialized.
11b61122
PE
5438 (find_automatic_composition): Mark vars as initialized,
5439 with a FIXME (Bug#8290).
8f5201ae 5440
760fbc2c
PE
5441 character.h: Rename locals to avoid shadowing.
5442 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5443 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5444 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5445 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5446 to avoid shadowing.
5447
ff08eb85
PE
5448 * textprop.c (property_change_between_p): Remove; unused.
5449
fc7bf025
PE
5450 * intervals.c (interval_start_pos): Now static.
5451
235d7abc
PE
5452 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5453
44f230aa
SM
5454 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5455 Rename locals to avoid shadowing.
3e7d6594 5456
50060332
PE
5457 * sound.c (wav_play, au_play, Fplay_sound_internal):
5458 Fix pointer signedness.
d01f234b 5459 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5460 (wav_play): Initialize a variable to 0, to prevent undefined
5461 behavior (Bug#8278).
50060332 5462
c4fc4e30
PE
5463 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5464
918436ed
PE
5465 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5466
c939f91b
PE
5467 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5468 clobbering (Bug#8298).
b9c7f648
PE
5469 * sysdep.c (sys_subshell): Likewise.
5470 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5471
6bd8c144
PE
5472 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5473 This should get cleaned up, so that child_setup has the
5474 same signature on all platforms.
5475
7710357c 5476 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5477 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5478
c59da222
CY
54792011-03-22 Chong Yidong <cyd@stupidchicken.com>
5480
5481 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5482 not to be necessary, and produces flickering.
5483
66b87493
GM
54842011-03-20 Glenn Morris <rgm@gnu.org>
5485
5486 * config.in: Remove file.
5487
45b6f6d5
JB
54882011-03-20 Juanma Barranquero <lekktu@gmail.com>
5489
5490 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5491 are now in src/globals.h.
5492 (syms_of_minibuf): Remove spurious & from previous change.
5493
3ec03f7e
LL
54942011-03-20 Leo <sdl.web@gmail.com>
5495
5496 * minibuf.c (completing-read-function): New variable.
5497 (completing-read-default): Rename from completing-read.
5498 (completing-read): Call completing-read-function.
5499
b14e3e21
CY
55002011-03-19 Juanma Barranquero <lekktu@gmail.com>
5501
5502 * xfaces.c (Fx_load_color_file):
5503 Read color file from absolute filename (bug#8250).
5504
f2b726e6
JB
55052011-03-19 Juanma Barranquero <lekktu@gmail.com>
5506
5507 * makefile.w32-in: Update dependencies.
5508
09f6ff02
EZ
55092011-03-17 Eli Zaretskii <eliz@gnu.org>
5510
5511 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5512
29a6015a
PE
55132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5514
a3a6c54e
PE
5515 Fix more problems found by GCC 4.5.2's static checks.
5516
b766f867
PE
5517 * process.c (make_serial_process_unwind, send_process_trap):
5518 (sigchld_handler): Now static.
5519
be02381c
PE
5520 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5521 That way, the code declares only the vars that it needs.
5522 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5523 * s/cygwin.h (PTY_ITERATION): Likewise.
5524 * s/darwin.h (PTY_ITERATION): Likewise.
5525 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5526
57048744
PE
5527 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5528 * process.c (allocate_pty): Don't declare stb unless it's needed.
5529
7914961c 5530 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5531 (CONSTANTLIM): Remove; unused.
5532 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5533 Define only if needed.
7914961c 5534
b3967b18
PE
5535 * unexelf.c (unexec): Name an expression,
5536 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5537 Use a different way to cause a compilation error if anyone uses
5538 n rather than nn, a way that does not involve shadowing.
73366a00 5539 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5540
29a6015a
PE
5541 * deps.mk (unexalpha.o): Remove; unused.
5542
43cfc33e 5543 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5544 * unexec.h: New file.
ce701a33
PE
5545 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5546 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5547 Depend on unexec.h.
5548 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5549 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5550 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5551 Change as necessary to match prototype in unexec.h.
ce701a33 5552
01f44d5a
PE
5553 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5554 shadowing.
4f63c6bb 5555 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5556
a6670b0b
PE
5557 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5558 Rename locals to avoid shadowing.
5559
cef2010d 5560 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5561 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5562
d4d7173a
PE
5563 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5564
f08b802a
PE
5565 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5566 warning when compiling print.c.
5567
3ddb0639
PE
5568 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5569 instead of using an uninitialized var.
5ad03b97 5570 (font_sort_entities): Mark var as initialized.
3ddb0639 5571
170a2692
PE
5572 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5573
e663c700
PE
5574 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5575 pointers to constants.
89bc529a 5576 (font_parse_fcname): Remove unused vars.
7b81e2d0 5577 (font_delete_unmatched): Now static.
ea838e10 5578 (font_get_spec): Remove; unused.
13a547c6
PE
5579 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5580 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5581 Rename or move locals to avoid shadowing.
e663c700 5582
2a80c887 5583 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5584 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5585
1384fa33 5586 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5587 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5588
8b2c52e9
PE
5589 * alloc.c (mark_backtrace): Move decl from here ...
5590 * lisp.h: ... to here, so that it can be checked.
5591
475545b5 5592 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5593 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5594 (lisp_indirect_variable): Name an expression,
5595 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5596 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5597
b1349114 5598 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5599 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5600 Use const pointer when appropriate.
b1349114 5601
a2928364
PE
5602 * lisp.h (get_system_name, get_operating_system_release):
5603 Move decls here, to check interfaces.
5604 * process.c (get_operating_system_release): Move decl to lisp.h.
5605 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5606 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5607 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5608 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5609 (Fformat_time_string, Fencode_time, Finsert_char):
5610 (Ftranslate_region_internal, Fformat):
5611 Rename or remove local vars to avoid shadowing.
9710023e 5612 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5613
a415e694
PE
5614 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5615 avoid shadowing.
5616
8ef4622d
PE
5617 * lisp.h (eassert): Check that the argument compiles, even if
5618 ENABLE_CHECKING is not defined.
5619
946f9a5b
PE
5620 * data.c (Findirect_variable): Name an expression, to avoid
5621 gcc -Wbad-function-cast warning.
112396d6 5622 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5623 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5624 (Fmake_variable_buffer_local, Fmake_local_variable):
5625 Mark variables as initialized.
52746918 5626 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5627
e5aab7e7 5628 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5629 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5630 Rename locals to avoid shadowing.
dff45157
PE
5631 (mark_stack): Move local variables into the #ifdef region where
5632 they're used.
7bc26fdb
PE
5633 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5634 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5635 needed otherwise.
5636 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5637 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5638 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5639
e5aab7e7
PE
5640 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5641 avoids undefined behavior in theory.
5642
4da60324
PE
5643 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5644
88043301
PE
5645 Use functions, not macros, for up- and down-casing (Bug#8254).
5646 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5647 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5648 to use the following functions instead of these macros.
5649 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5650 EMACS_INT, since callers assume the returned value fits in int.
5651 (upcase1): Likewise, for UPCASE_TABLE.
5652 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5653 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5654 the race-condition problem in the old DOWNCASE.
88043301 5655
19ed5445
PE
5656 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5657 Rename locals to avoid shadowing.
5658 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5659 (regex_compile, re_search_2, re_match_2_internal):
5660 Remove unused local vars.
952db0d7
PE
5661 (FREE_VAR): Rewrite so as not to use empty "else",
5662 which gcc can warn about.
da053e48 5663 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5664 (RETALLOC_IF): Define only if needed.
5665 (WORDCHAR_P): Likewise. This one is never needed, but is used
5666 only in a comment talking about a compiler bug, so put inside
5667 the #if 0 of that comment.
5668 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5669 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5670 Remove; unused.
19ed5445 5671
1f3561e4 5672 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5673 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5674 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5675
ded6f8f7
PE
5676 * search.c (simple_search): Remove unused var.
5677
dbd37a95
PE
5678 * dired.c (compile_pattern): Move decl from here ...
5679 * lisp.h: ... to here, so that it can be checked.
5680 (struct re_registers): New forward decl.
5681
7e47afad
PE
5682 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5683
85f24f61
PE
5684 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5685 All uses changed.
5686 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5687 Rename locals to avoid shadowing.
5671df8f 5688 (Fvertical_motion): Mark locals as initialized.
85f24f61 5689
181aa2be 5690 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5691 (casify_region): Mark local as initialized.
181aa2be 5692
930d429c
PE
5693 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5694
7082eac6
PE
5695 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5696 New macros, so that the caller can use some names other than
5697 gcpro1, gcpro2, etc.
5698 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5699 of the new macros.
5700 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5701 argument, for consistency with GCPRO2_VAR, etc: it is now the
5702 prefix of the variable, not the variable itself. All uses
5703 changed.
38b2c076
PE
5704 * dired.c (directory_files_internal, file_name_completion):
5705 Rename locals to avoid shadowing.
5706
15206ed9
PE
5707 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5708 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5709 dired.c's scmp function, had undefined behavior.
5710 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5711 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5712 * buffer.h: ... to here, because these macros use current_buffer,
5713 and the new implementation with inline functions needs to have
5714 current_buffer in scope now, rather than later when the macros
5715 are used.
5716 (downcase, upcase1): New static inline functions.
5717 (DOWNCASE, UPCASE1): Reimplement using these functions.
5718 This avoids undefined behavior in expressions like
5719 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5720 from race conditions in accessing the global variables
5721 case_temp1 and case_temp2.
5722 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5723 * lisp.h (case_temp1, case_temp2): Remove their decls.
5724 * character.h (ASCII_CHAR_P): Move from here ...
5725 * lisp.h: ... to here, so that the inline functions mentioned
5726 above can use them.
5727
4a6bea26
PE
5728 * dired.c (directory_files_internal_unwind): Now static.
5729
f14b7e14
PE
5730 * fileio.c (file_name_as_directory, directory_file_name):
5731 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5732 Now static.
2893f146
PE
5733 (file_name_as_directory): Use const pointers when appropriate.
5734 (Fexpand_file_name): Likewise. In particular, newdir might
5735 point at constant storage, so make it a const pointer.
fd4ead52 5736 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5737 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5738 signedness issues.
f839df0c
PE
5739 (Fset_file_times, Finsert_file_contents, auto_save_error):
5740 Rename locals to avoid shadowing.
f14b7e14 5741
5716756e 5742 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5743 (Ftry_completion, Fall_completions): Rename or remove locals
5744 to avoid shadowing.
5716756e 5745
b4c3046a
PE
5746 * marker.c (bytepos_to_charpos): Remove; unused.
5747
b45db522
PE
5748 * lisp.h (verify_bytepos, count_markers): New decls,
5749 so that gcc does not warn that these functions aren't declared.
5750
85876d07
PE
5751 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5752 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5753 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5754 (copy_text): Remove unused local var.
85876d07 5755
03d78a21 5756 * filelock.c (within_one_second): Now static.
b3dd38ab 5757 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5758
5df8f01b
PE
5759 * buffer.c (fix_overlays_before): Mark locals as initialized.
5760 (fix_start_end_in_overlays): Likewise. This function should be
5761 simplified by using pointers-to-pointers, but that's a different
5762 matter.
b1d876f1 5763 (switch_to_buffer_1): Now static.
8f54f30a
PE
5764 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5765 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5766
a70072c9 5767 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5768 Fix pointer signedness issue.
edced198
PE
5769 (sys_subshell): Mark local as volatile if checking for lint,
5770 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5771 (MAXPATHLEN): Define only if needed.
a70072c9 5772
a0977c44
PE
5773 * process.c (serial_open, serial_configure): Move decls from here ...
5774 * systty.h: ... to here, so that they can be checked.
5775
a884fdcc
PE
5776 * fns.c (get_random, seed_random): Move extern decls from here ...
5777 * lisp.h: ... to here, so that they can be checked.
5778
604efe86 5779 * sysdep.c (reset_io): Now static.
b8950c94 5780 (wait_for_termination_signal): Remove; unused.
604efe86 5781
38fc62d9
PE
5782 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5783 (copy_keymap_item, append_key, push_text_char_description):
5784 Now static.
1004a21a 5785 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5786 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5787 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5788 (describe_map_tree):
5789 Rename locals to avoid shadowing.
38fc62d9 5790
2f2650da
PE
5791 * keyboard.c: Declare functions static if they are not used elsewhere.
5792 (echo_char, echo_dash, cmd_error, top_level_2):
5793 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5794 (read_char, kbd_buffer_get_event, make_lispy_position):
5795 (make_lispy_event, make_lispy_movement, apply_modifiers):
5796 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5797 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5798 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5799 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5800 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5801
a053e86c 5802 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5803 (mark_kboards): Move decl here ...
5804 * alloc.c (mark_kboards): ... from here.
a053e86c 5805
4752793e
PE
5806 * lisp.h (force_auto_save_soon): New decl.
5807
74f10ca7 5808 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5809 (DEFINE_DUMMY_FUNCTION): New macro.
5810 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5811 Use it.
c03cd23f
PE
5812 (main): Add casts to avoid warnings
5813 if GCC considers string literals to be constants.
74f10ca7 5814
022e70d4
PE
5815 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5816
59d6fe83
PE
5817 * dbusbind.c: Pointer signedness fixes.
5818 (xd_signature, xd_append_arg, xd_initialize):
5819 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5820 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5821 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5822 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5823
78320123
PE
5824 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5825 if GCC considers string literals to be constants.
49cebcca 5826 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5827
35ac2a97
SM
58282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5829
fb103ca9
SM
5830 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5831 (print_preprocess, print_object): New macro to fix last change.
5832
35ac2a97
SM
5833 * print.c (print_preprocess): Don't forget font objects.
5834
62973b41
JB
58352011-03-16 Juanma Barranquero <lekktu@gmail.com>
5836
5837 * emacs.c (USAGE3): Doc fixes.
5838
0e48bb22
AS
58392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5840
5841 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5842 structure.
5843
7684e57b
JB
58442011-03-14 Juanma Barranquero <lekktu@gmail.com>
5845
5846 * lisp.h (VWindow_system, Qfile_name_history):
5847 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5848 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5849 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5850
5851 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5852 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5853
5854 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5855 * w32console.c (detect_input_pending, read_input_pending)
5856 (encode_terminal_code):
5857 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5858 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5859 (w32_system_caret_y, Qfile_name_history):
5860 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5861 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5862 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5863 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5864 * w32proc.c (Qlocal, report_file_error):
5865 * w32term.c (Vwindow_system, updating_frame):
5866 * w32uniscribe.c (initialized, uniscribe_font_driver):
5867 Remove unneeded extern declarations.
5868
2aa46d6c
CY
58692011-03-14 Chong Yidong <cyd@stupidchicken.com>
5870
c96bbc66 5871 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5872
cffc6f3b
CY
58732011-03-13 Chong Yidong <cyd@stupidchicken.com>
5874
5875 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5876 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5877 These macros can no longer be used for assignment.
5878
44f230aa
SM
5879 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5880 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5881 (record_buffer_markers, fetch_buffer_markers): New functions for
5882 recording and fetching special buffer markers.
5883 (set_buffer_internal_1, set_buffer_temp): Use them.
5884
5885 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5886
5887 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5888
5889 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5890 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5891
5892 * xdisp.c (hscroll_window_tree):
5893 (reconsider_clip_changes): Use PT instead of BUF_PT.
5894
d251f04b
EZ
58952011-03-13 Eli Zaretskii <eliz@gnu.org>
5896
5897 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5898 $(EMACS_ROOT)/lib/intprops.h.
5899
f0c77cd1
PE
59002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5901
3eca4629
PE
5902 Fix more problems found by GCC 4.5.2's static checks.
5903
7c86ee98
PE
5904 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5905 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5906 (xg_free_frame_widgets): Make it clear that a local variable is
5907 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5908 (gdk_window_get_screen): Make it clear that this macro is needed
5909 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5910 (int_gtk_range_get_value): New function, which avoids a diagnostic
5911 from gcc -Wbad-function-cast.
5912 (xg_set_toolkit_scroll_bar_thumb): Use it.
5913 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5914 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5915 (get_utf8_string, xg_get_file_with_chooser):
5916 Rename locals to avoid shadowing.
5917 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5918
41729b81
PE
5919 * xgselect.c (xg_select): Remove unused var.
5920
f0c77cd1
PE
5921 * image.c (four_corners_best): Mark locals as initialized.
5922 (gif_load): Initialize transparent_p to zero (Bug#8238).
5923 Mark another local as initialized.
ec6cf4c6 5924 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5925
ce0ad53d 5926 * image.c (clear_image_cache): Now static.
d5d5a617 5927 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5928 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5929 (x_edge_detection): Remove unnecessary cast that
5930 gcc -Wbad-function-cast diagnoses.
2037898d 5931 (gif_load): Fix pointer signedness.
6ae141d6
PE
5932 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5933 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5934
33383987 59352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5936
d32df629
PE
5937 Improve quality of tests for time stamp overflow.
5938 For example, without this patch (encode-time 0 0 0 1 1
5939 1152921504606846976) returns the obviously-bogus value (-948597
5940 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5941 reports time overflow. See
5942 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5943 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5944 * editfns.c: Include limits.h and intprops.h.
5945 (TIME_T_MIN, TIME_T_MAX): New macros.
5946 (time_overflow): Move earlier, to before first use.
5947 (hi_time, lo_time): New functions, for an accurate test for
5948 out-of-range times.
5949 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5950 (Fget_internal_run_time): Don't assume time_t fits in int.
5951 (make_time): Use list2 instead of Fcons twice.
5952 (Fdecode_time): More accurate test for out-of-range times.
5953 (check_tm_member): New function.
5954 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5955 (lisp_time_argument): Don't rely on undefined left-shift and
5956 right-shift behavior when checking for time stamp overflow.
8be6f318 5957
fe31d94c
PE
5958 * editfns.c (time_overflow): New function, refactoring common code.
5959 (Fformat_time_string, Fdecode_time, Fencode_time):
5960 (Fcurrent_time_string): Use it.
5961
8be6f318
PE
5962 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5963 * dired.c (make_time): Move to ...
5964 * editfns.c (make_time): ... here.
5965 * systime.h: Note the move.
5966
09d9db2c 59672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5968
126bc0dc
YM
5969 * fringe.c (update_window_fringes): Remove unused variables.
5970
c47cbdfd
YM
5971 * unexmacosx.c (copy_data_segment): Also copy __got section.
5972 (Bug#8223)
5973
7ac80be9
EZ
59742011-03-12 Eli Zaretskii <eliz@gnu.org>
5975
c96bbc66 5976 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5977 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5978 Constify `char *' arguments and their references according to
5979 prototypes in tparam.h.
5980
ecb0f94d 5981 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5982
7ac80be9
EZ
5983 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5984 Adapt all references accordingly.
5985
5986 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5987
ef1fd07e
TT
59882011-03-11 Tom Tromey <tromey@redhat.com>
5989
5990 * buffer.c (syms_of_buffer): Remove obsolete comment.
5991
7ef4b50c
EZ
59922011-03-11 Eli Zaretskii <eliz@gnu.org>
5993
5994 * termhooks.h (encode_terminal_code): Declare prototype.
5995
5996 * msdos.c (encode_terminal_code): Don't declare prototype.
5997
5998 * term.c (encode_terminal_code): Now external again, used by
5999 w32console.c and msdos.c.
6000
44f230aa
SM
6001 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6002 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6003
4b1ec863 60042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6005
1714f52b 6006 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6007
4b1ec863
PE
6008 * fringe.c (update_window_fringes): Mark locals as initialized
6009 (Bug#8227).
6010 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6011
524c7aa6
PE
6012 * alloc.c (mark_fringe_data): Move decl from here ...
6013 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6014 to check its interface.
6015 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6016
a5c0af81 6017 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6018 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6019 (fontset_font): Mark local as initialized.
a9a06e0b 6020 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6021
b4716021
PE
6022 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6023
811e9bac 6024 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6025 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6026 (x_own_selection, Fx_disown_selection_internal): Rename locals
6027 to avoid shadowing.
6028 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6029
7e3ab302
PE
6030 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6031 so that the caller can use some name other than gcpro1.
6032 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6033 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6034 (Fx_backspace_delete_keys_p):
6035 Use them to avoid shadowing, and rename vars to avoid shadowing.
6036 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6037 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6038 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6039 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6040 Remove unused locals.
7e3ab302
PE
6041 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6042 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6043 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6044 macros.
f78faa98 6045
e2b13473
PE
6046 * xterm.h (x_mouse_leave): New decl.
6047
77f23912
PE
6048 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6049 Remove unused functions.
cdf4ba58
PE
6050 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6051 (x_calc_absolute_position): Now static.
7411c686 6052 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6053 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6054 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6055 unless they are used.
38d0b34a
PE
6056 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6057 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6058 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6059 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6060 (x_error_catcher, x_connection_closed, x_error_handler):
6061 (x_error_quitter, xembed_send_message, x_iconify_frame):
6062 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6063 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6064 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6065
44f230aa
SM
6066 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6067 Rename or move locals to avoid shadowing.
6b463e58 6068 (tty_defined_color, merge_face_heights): Now static.
5967d051 6069 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6070 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6071 does not deduce is never used uninitialized.
73719eba
PE
6072 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6073 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6074
426994c3 6075 * terminal.c (store_terminal_param): Now static.
5489860b 6076
032f1620 6077 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6078 (set_frame_menubar): Remove unused local.
d4323972 6079 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6080 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6081 since they might point to immutable storage.
281585b0
PE
6082 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6083 since it's unused otherwise.
032f1620 6084
367c19e5 6085 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6086 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6087 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6088 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6089 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6090 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6091 does not deduce are never used uninitialized.
70739cbe 6092
07b48fa9
PE
6093 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6094
8868a238 6095 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6096 * window.c (window_loop, size_window):
6097 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6098
7e5cf297 6099 * window.c (display_buffer): Now static.
d6550a9f
PE
6100 (size_window): Mark variables that gcc -Wuninitialized
6101 does not deduce are never used uninitialized.
a586633d
PE
6102 * window.h (check_all_windows): New decl, to forestall
6103 gcc -Wmissing-prototypes diagnostic.
5b555da1 6104 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6105
f6095868
PE
6106 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6107 shadowing.
6108 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6109 Include <limits.h>.
6110 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6111 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6112 (load_charset_map): Mark variables that gcc -Wuninitialized
6113 does not deduce are never used uninitialized.
53df7c11 6114 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6115
f38b440c
PE
6116 * coding.c (coding_set_source, coding_set_destination):
6117 Use "else { /* comment */ }" rather than "else /* comment */;"
6118 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6119 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6120 a block, when the outer 'i' will do.
6121 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6122 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6123 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6124 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6125 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6126 Rename locals to avoid shadowing.
6127 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6128 * coding.c (emacs_mule_char, encode_invocation_designation):
6129 Now static, since they're not used elsewhere.
413bb2db 6130 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6131 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6132 (decode_coding_emacs_mule): Mark variables that gcc
6133 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6134 (detect_coding_iso_2022): Initialize a local variable that might
6135 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6136 this initialization is needed. (Bug#8211)
5f58e762
PE
6137 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6138 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6139 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6140 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6141 Remove unused macros.
f38b440c 6142
232b38b9 6143 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6144 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6145 * character.c (string_count_byte8): Likewise.
232b38b9 6146
fb90da1b
PE
6147 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6148 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6149
fb93dbc2
PE
6150 * chartab.c (copy_sub_char_table): Now static, since it's not used
6151 elsewhere.
5c156ace
PE
6152 (sub_char_table_ref_and_range, char_table_ref_and_range):
6153 Rename locals to avoid shadowing.
bbcd0949 6154 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6155
7d3b3862 6156 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6157 (BIDI_BOB): Remove unused macro.
7d3b3862 6158
6be7d3da
PE
6159 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6160 deduce are never used uninitialized.
c2ed9c8b 6161 * term.c (encode_terminal_code): Likewise.
6be7d3da 6162
75f8807f 6163 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6164
50938595
PE
6165 * tparam.h: New file.
6166 * term.c, tparam.h: Include it.
6167 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6168 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6169 Move these decls to tparam.h, and make them agree with what
6170 is actually in tparam.c. The previous trick of using incompatible
6171 decls in different modules does not conform to the C standard.
6172 All callers of tparam changed to use tparam's actual API.
6173 * tparam.c (tparam1, tparam, tgoto):
6174 Use const pointers where appropriate.
6175
fbceeba2
PE
6176 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6177 * cm.h (struct cm): Likewise.
6178 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6179 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6180 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6181 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6182 (turn_on_face, init_tty): Likewise.
6183 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6184
7f3f1250
PE
6185 * term.c (term_mouse_position): Rename local to avoid shadowing.
6186
e6ca6543
PE
6187 * alloc.c (mark_ttys): Move decl from here ...
6188 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6189
c40f8d15
AS
61902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6191
6192 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6193
cfe0661d
JB
61942011-03-09 Juanma Barranquero <lekktu@gmail.com>
6195
6196 * search.c (compile_pattern_1): Remove argument regp, unused since
6197 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6198 (compile_pattern): Don't pass it.
6199
0afb4571
J
62002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6201
6202 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6203 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6204 for ! HAVE_GTK3.
6205 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6206
6207 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6208
6209 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6210 gdk_window_get_screen, gdk_window_get_geometry,
6211 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6212 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6213 (xg_get_pixbuf_from_pixmap): New function.
6214 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6215 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6216 Call xg_get_pixbuf_from_pixmap instead of
6217 gdk_pixbuf_get_from_drawable.
6218 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6219 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6220 (xg_check_special_colors): Use GtkStyleContext and its functions
6221 for HAVE_GTK3.
6222 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6223 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6224 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6225 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6226 Call gtk_widget_get_preferred_size.
0afb4571
J
6227 (xg_frame_resized): gdk_window_get_geometry only takes 5
6228 parameters.
44f230aa
SM
6229 (xg_win_to_widget, xg_event_is_for_menubar):
6230 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6231 (xg_set_widget_bg): New function.
6232 (delete_cb): New function.
895009e1 6233 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6234 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6235 (xg_set_background_color): Call xg_set_widget_bg.
6236 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6237 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6238 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6239 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6240 if ! HAVE_GTK3.
6241 (update_frame_tool_bar): Call gtk_widget_hide.
6242 (xg_initialize): Use GDK_KEY_g.
6243
6244 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6245 if ! HAVE_GTK3
6246 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6247
6248 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6249 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6250 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6251
1c2cc4ef
JB
62522011-03-08 Juanma Barranquero <lekktu@gmail.com>
6253
6254 * w32xfns.c (select_palette): Check success of RealizePalette against
6255 GDI_ERROR, not zero.
6256
33383987 6257See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6258
6259;; Local Variables:
6260;; coding: utf-8
aac0c6e3
MR
6261;; End:
6262
33383987 6263 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6264
6265 This file is part of GNU Emacs.
6266
6267 GNU Emacs is free software: you can redistribute it and/or modify
6268 it under the terms of the GNU General Public License as published by
6269 the Free Software Foundation, either version 3 of the License, or
6270 (at your option) any later version.
6271
6272 GNU Emacs is distributed in the hope that it will be useful,
6273 but WITHOUT ANY WARRANTY; without even the implied warranty of
6274 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6275 GNU General Public License for more details.
6276
6277 You should have received a copy of the GNU General Public License
6278 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.