Improve fix for macroexp crash with debugging.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8834c57a
PE
12012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 Improve fix for macroexp crash with debugging (Bug#12118).
4 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
5 ARRAY_MARK_FLAG when checking subscripts, because ASET is
6 not supposed to be invoked from the garbage collector.
7 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
8 (gc_aset): New function, which is like ASET but can be
9 used in the garbage collector.
10 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
11 (set_hash_index): Use it instead of ASET.
12
6dad7178
EZ
132012-08-03 Eli Zaretskii <eliz@gnu.org>
14
15 Support symlinks on latest versions of MS-Windows.
16 * w32.c: Include winioctl.h and aclapi.h.
17 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
18 (revert_to_self): Forward declarations of static functions.
19 <static BOOL g_b_init_get_security_info>:
20 <g_b_init_create_symbolic_link>: New static flags.
21 (globals_of_w32): Initialize them to zero.
22 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
23 (map_w32_filename): Improve commentary. Simplify switch.
24 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
25 headers (most versions of MinGW w32api don't).
26 (get_security_info, create_symbolic_link)
27 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
28 New functions.
29 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
30 in the argument file name.
31 (sys_access): Call unc_volume_file_attributes only if
32 GetFileAttributes fails with network-related error codes.
33 (sys_rename): Diagnose renaming of a symlink when the user doesn't
34 have the required privileges.
35 (get_file_security_desc_by_name): Renamed from
36 get_file_security_desc.
37 (stat_worker): New function, with most of the guts of 'stat', and
38 with addition of handling of symlinks and support for 'lstat'. If
39 possible, get file's attributes and security information by
40 handle, not by name. Produce S_IFLNK bit for symlinks, when
41 called from 'lstat'.
42 (stat, lstat): New functions, call 'stat_worker'.
43 (symlink, readlink, careadlinkat): Rewritten to create and resolve
44 symlinks when the underlying filesystem supports them.
45
f162bcc3
PE
462012-08-02 Paul Eggert <eggert@cs.ucla.edu>
47
79ea6c20
PE
48 Fix macroexp crash on Windows with debugging (Bug#12118).
49 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
50 checking subscripts; problem introduced with the recent
51 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
52 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
53 since it's used in non-static inline functions now.
54
c0ce93fd
PE
55 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
56 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 57
f162bcc3
PE
58 Use C99-style 'extern inline' if available.
59 * buffer.h (BUFFER_INLINE):
60 * category.h (CATEGORY_INLINE):
61 * character.h (CHARACTER_INLINE):
62 * charset.h (CHARSET_INLINE):
63 * composite.h (COMPOSITE_INLINE):
64 * dispextern.h (DISPEXTERN_INLINE):
65 * lisp.h (LISP_INLINE):
66 * systime.h (SYSTIME_INLINE):
67 New macro, replacing 'static inline' in this header.
68 * buffer.h, category.h, character.h, charset.h, composite.h:
69 * dispextern.h, lisp.h, systime.h:
70 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
71 * alloc.c (LISP_INLINE):
72 * buffer.c (BUFFER_INLINE):
73 * category.c (CATEGORY_INLINE):
74 * character.c (CHARACTER_INLINE):
75 * charset.c (CHARSET_INLINE):
76 * composite.c (COMPOSITE_INLINE):
77 * dispnew.c (DISPEXTERN_INLINE):
78 * sysdep.c (SYSTIME_INLINE):
79 Define to EXTERN_INLINE, so that the corresponding functions
80 are compiled into code.
81 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
82 (INLINE_HEADER_END): New macros.
83 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
84 since it's used in non-static inline functions now.
a8333d03 85 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 86
837b365b
GM
872012-08-02 Glenn Morris <rgm@gnu.org>
88
d66b744d
GM
89 * s/: Remove empty directory.
90
837b365b
GM
91 * s/ms-w32.h: Move to ../nt/inc.
92 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
93 Update for new ms-w32.h location.
94
13294f95
PE
952012-08-02 Paul Eggert <eggert@cs.ucla.edu>
96
97 Port to Solaris 8.
98 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
99
90df0db3
GM
1002012-08-02 Glenn Morris <rgm@gnu.org>
101
102 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
103 hard-coding the path separator.
104
4939150c
PE
1052012-08-01 Paul Eggert <eggert@cs.ucla.edu>
106
107 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
108 This how ASET and AREF are supposed to work, and makes
109 it easier to think about future improvements. See
110 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
111 * charset.h (set_charset_attr): New function.
112 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
113 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
114 (aref_addr): New function. All uses of &AREF(...) changed.
115 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
116 (set_hash_index): New functions. All lvalue-style uses of
117 HASH_KEY etc. changed.
118 * keyboard.c (set_prop): New function. All lvalue-style uses
119 of PROP changed.
120
947b2afd
AA
1212012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
122
123 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
124 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
125 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
126 * nsfns.m (ns_set_name_as_filename): Likewise.
127 * nsmenu.m (ns_update_menubar): Likewise.
128 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
129
4f5d0325
EZ
1302012-08-01 Eli Zaretskii <eliz@gnu.org>
131
2008beae
EZ
132 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
133 Adapt to latest changes in field names of the corresponding Lisp
288479f6 134 objects.
2008beae 135
4f5d0325
EZ
136 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
137
fe3cc771
GM
1382012-08-01 Glenn Morris <rgm@gnu.org>
139
140 * s/msdos.h: Remove file.
141 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
142 * Makefile.in (S_FILE): Remove.
143 (config_h): Remove S_FILE.
144
c90acc54
JB
1452012-08-01 Juanma Barranquero <lekktu@gmail.com>
146
147 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
148 Remove; moved to nt/config.nt.
149
d8a05828
DA
1502012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
151
152 Use INTERNAL_FIELD for conses and overlays.
153 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
154 Remove obsolete comment.
155 (MVAR): New macro.
156 (struct Lisp_Overlay): Use INTERNAL_FIELD.
157 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
158
8271d590
DA
1592012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
160
161 Use INTERNAL_FIELD for symbols.
162 * lisp.h (SVAR): New macro. Adjust users.
163 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
164 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
165
3193acd2
DA
1662012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
167
168 Use INTERNAL_FIELD for processes.
169 * process.h (PVAR): New macro. Adjust style.
170 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
171 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
172
3a45383a
DA
1732012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
174
175 Use INTERNAL_FIELD for windows.
176 * window.h (WVAR): New macro.
177 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
178 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
179 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
180 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
181 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
182 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
183
c1dbc63c
PE
1842012-08-01 Paul Eggert <eggert@cs.ucla.edu>
185
186 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
187
5c0c0e8a
GM
1882012-08-01 Glenn Morris <rgm@gnu.org>
189
190 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
191 Move to configure.ac.
192
552a99b4
JB
1932012-08-01 Juanma Barranquero <lekktu@gmail.com>
194
195 * makefile.w32-in (CONFIG_H): Update dependencies.
196 (CONF_POST_H): New macro.
197
198 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
199
8d8e2dfe
GM
2002012-07-31 Glenn Morris <rgm@gnu.org>
201
bc96620a
GM
202 * Makefile.in (S_FILE): No longer set by configure.
203
476b1b2d
GM
204 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
205 is available.
206 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
207
b2c7a106
GM
208 * process.h (NULL_DEVICE):
209 * emacs.c (SEPCHAR):
210 * editfns.c (USER_FULL_NAME): Let configure set them.
211
d53d062a
GM
212 * s/README, s/template.h: Remove files.
213
4515017f
GM
214 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
215
8d8e2dfe
GM
216 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
217 Move to configure.ac.
218
5b20b3cc
EZ
2192012-07-31 Eli Zaretskii <eliz@gnu.org>
220
1e0afd9a
EZ
221 * .gdbinit (xframe): Adapt to introduction of FVAR and the
222 resulting renaming of 'struct frame' members.
223
5b20b3cc
EZ
224 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
225
226 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
227 after introduction of FVAR.
228
f1310128
JD
2292012-07-31 Jan Djärv <jan.h.d@swipnet.se>
230
79e721e0
JD
231 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
232
233 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
234 instead of compositeToPoint.
235 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
236
8d7c7eed 237 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 238
e34f7f79
DA
2392012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
240
241 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
242 * lisp.h (INTERNAL_FIELD): New macro.
243 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
244 (BVAR): Change to use INTERNAL_FIELD.
245 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
246 (KVAR): Change to use INTERNAL_FIELD.
247 * frame.h (FVAR): New macro.
248 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
249 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
250 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
251 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
252 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
253
c09bfb2f
DA
2542012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
255
256 Miscellaneous fixes for non-default X toolkits.
257 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
258 * xterm.c (x_frame_of_widget): Remove redundant prototype.
259 Move under #ifdef USE_LUCID.
260 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
261 definition and usage to avoid warnings.
262
14c114ae
JD
2632012-07-31 Jan Djärv <jan.h.d@swipnet.se>
264
265 * nsterm.m (openFiles): Fix previous checkin.
266
3bd21e82
PE
2672012-07-31 Paul Eggert <eggert@cs.ucla.edu>
268
269 * indent.c (compute_motion): Remove unused local.
270
c1529ded
GM
2712012-07-31 Glenn Morris <rgm@gnu.org>
272
400d5621
GM
273 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
274
268e2432
GM
275 * conf_post.h [USG5_4]:
276 Move remaining contents of s/usg5-4-common.h here.
277 * s/usg5-4-common.h: Remove file.
278
7552f3ee
GM
279 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
280 * s/irix6-5.h: Remove file.
281
6a381852
GM
282 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
283 * s/darwin.h: Remove file.
284
c1529ded
GM
285 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
286 * s/hpux10-20.h: Remove file, which is now empty.
287
b429a4ee
GM
2882012-07-30 Glenn Morris <rgm@gnu.org>
289
290 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
291 * Makefile.in (config_h): Add conf_post.h.
292 * makefile.w32-in (CONFIG_H): Add conf_post.h.
293
adff3182
JD
2942012-07-30 Jan Djärv <jan.h.d@swipnet.se>
295
296 * nsterm.m (ns_do_open_file): New variable.
b9031d69 297 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
298 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
299 files only if ns_do_open_file.
300
c32af1e4
PE
3012012-07-30 Paul Eggert <eggert@cs.ucla.edu>
302
7393bcbb
PE
303 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
304 This no-op macro hasn't been needed for many years.
305 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
306
c32af1e4
PE
307 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
308 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
309 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
310 gdb_make_enums_visible.
311 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
312 (DIRECTORY_SEP): Now a constant, not a macro.
313
302fc036
EZ
3142012-07-30 Eli Zaretskii <eliz@gnu.org>
315
316 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
317 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
318
319 * w32term.c <w32_keyboard_codepage>: Renamed from
320 keyboard_codepage and now external. All users changed.
321
322 * w32term.h: Add declaration of w32_keyboard_codepage.
323
324 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
325 the codepage to translate keys to Unicode. If this argument is
326 -1, use the value returned by GetConsoleCP. All callers changed.
327
88fb40b4
PE
3282012-07-30 Paul Eggert <eggert@cs.ucla.edu>
329
0aee6912
PE
330 Update .PHONY listings in makefiles.
331 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
332 bootstrap-clean, distclean, maintainer-clean, versioclean,
333 extraclean, frc.
334
88fb40b4
PE
335 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
336 This is a bit clearer. Fix some commentary typos.
337
0a763bd1
GM
3382012-07-30 Glenn Morris <rgm@gnu.org>
339
32bac6d6
GM
340 * s/netbsd.h: Let configure include signal.h if needed.
341 Remove file, which is now empty.
342
b65e7c46
GM
343 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
344 Let configure set them.
345 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
346 No more need to undefine.
0a763bd1 347
169304bd
AS
3482012-07-30 Andreas Schwab <schwab@linux-m68k.org>
349
350 * keymap.c (Fkey_description): Don't remove 0x80 bit from
351 non-single-byte char when adding meta modifier. (Bug#12090)
352
6cd7a139
DA
3532012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
354
355 Convert safe_call to use variable number of arguments.
356 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
357 (safe_call2): Fix comment.
358 * lisp.h (safe_call): Adjust prototype.
359 * coding.c (encode_coding_object): Change to use safe_call2.
360 * xfaces.c (merge_face_heights): Change to use safe_call1.
361
d34d6ffc
GM
3622012-07-30 Glenn Morris <rgm@gnu.org>
363
7b8a48e4 364 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 365 does that unconditionally. Remove file, which is now empty.
7b8a48e4 366
d34d6ffc
GM
367 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
368 Remove empty files.
369
03a660a6
PE
3702012-07-30 Paul Eggert <eggert@cs.ucla.edu>
371
372 Export to GDB most of lisp.h's remaining object-like macros.
373 * lisp.h (min, max): Move earlier, because they're used earlier now.
374 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
375 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
376 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
377 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
378 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
379 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
380 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
381 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
382 Now constants, for GDB. They need not be macros.
383 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
384 Now constants, for GDB, as well as macros, for static initializers.
385 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
386 Move to after the definition of struct Lisp_Char_Table,
387 since the former now needs that type defined.
388 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
389 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
390 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
391 New enums, for gdb_make_enums_visible.
392 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 393 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
394 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
395 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
396 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
397 enum maxargs, enum MAX_ALLOCA.
398 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
399 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
400 no longer needed, now that they are done in lisp.h.
401
e499d0ee
DA
4022012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
403
404 Cleanup string bytes checking.
405 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
406 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
407 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
408 (check_sblock, compact_small_strings): Simplify.
409
d5040d2d
PE
4102012-07-29 Paul Eggert <eggert@cs.ucla.edu>
411
412 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
413 These macros are confusing and no longer need to be defined, as
414 the enum values now suffice. All uses replaced with definiens.
415 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
416
7f259ae6
JB
4172012-07-29 Juanma Barranquero <lekktu@gmail.com>
418
419 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
420 ($(BLD)/w32console.$(O)): Update dependencies.
421
7e63e0c3
DA
4222012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
423
424 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
425 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
426 time. Adjust users.
427 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
428
ffd817eb
JD
4292012-07-29 Jan Djärv <jan.h.d@swipnet.se>
430
431 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
432 setting sitelisp (Bug#12010).
433
417a7a0e
EZ
4342012-07-29 Eli Zaretskii <eliz@gnu.org>
435
436 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
437
438 * w32heap.c (cache_system_info):
439 * w32.c (sys_rename):
440 * w32proc.c (find_child_console, sys_kill): All users changed.
441
387d4d92
PE
4422012-07-29 Paul Eggert <eggert@cs.ucla.edu>
443
444 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
445
55a6cca6
EZ
4462012-07-29 Eli Zaretskii <eliz@gnu.org>
447
448 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
449
dbcf001c
DA
4502012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
451
452 Cleanup statistics calculation in Fgarbage_collect.
453 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
454 zombies percentage calculation. Simplify elapsed time calculation.
455
e2688e4a
DA
4562012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
457
458 Generalize marker debugging code under MARKER_DEBUG and use eassert.
459 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
460 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
461 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
462 (replace_range, replace_range_2, del_range_2): Change to eassert.
463 * marker.c (byte_char_debug_check): Adjust style.
464
b46a6a83
PE
4652012-07-29 Paul Eggert <eggert@cs.ucla.edu>
466
467 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
468 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
469 long-ago-commented-out code that talks about "WIN32".
470 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
471 All uses changed.
472
e32a5799
PE
4732012-07-28 Paul Eggert <eggert@cs.ucla.edu>
474
475 Use Gnulib stdalign module (Bug#9772, Bug#9960).
476 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
477 Simplify by using alignof.
478 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
479 * lisp.h: Include <stdalign.h>.
480 (GCALIGNMENT): New macro and constant.
481 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
482 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
483 (stdalign): New macro, if not already defined.
484
df81cd29
EZ
4852012-07-28 Eli Zaretskii <eliz@gnu.org>
486
01bd1b0d
EZ
487 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
488 * w32inevt.c: Include w32inevt.h.
489 (w32_read_console_input): New inline function, calls either
490 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
491 w32_console_unicode_input.
492 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
493 (w32_kbd_patch_key, key_event): Use the codepage returned by
494 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
495 (key_event): use uChar.UnicodeChar only if
496 w32_console_unicode_input is non-zero.
497
498 * w32console.c: Include w32heap.h.
499 <w32_console_unicode_input>: New global variable.
500 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
501 family of Windows, zero otherwise.
502
503 * w32inevt.h: Declare w32_console_unicode_input.
504
df81cd29
EZ
505 * xdisp.c (init_iterator): Don't reference tip_frame in a build
506 --without-x. (Bug#11742)
507
c20fdd9e
PE
5082012-07-27 Paul Eggert <eggert@cs.ucla.edu>
509
510 Adjust GDB to reflect pvec_type changes (Bug#12036).
511 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
512 2012-07-04 changes to pseudovector representation. Problem
513 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
514
32770973 5152012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
516
517 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
518 bus address.
519 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
520
3438fe21
EZ
5212012-07-27 Eli Zaretskii <eliz@gnu.org>
522
bcfbc9de
EZ
523 * alloc.c (listn): Fix the order the arguments are consed onto the
524 list.
525
3438fe21
EZ
526 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
527 enumeration constants, as PURE and HEAP are too general, and clash
528 with other headers and sources, such as gmalloc.c and the
529 MS-Windows system headers. All users changed.
530
eeaea515
DA
5312012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
532
533 Revert last save_excursion_save and save_excursion_restore changes.
534 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
535 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
536
073c88c2
DA
5372012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
538
539 Fix recently-introduced typos in Windows port.
540 Reported by Martin Rudalics <rudalics@gmx.at>.
541 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 542 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 543
4706125e
PE
5442012-07-27 Paul Eggert <eggert@cs.ucla.edu>
545
546 Improve GDB symbol export (Bug#12036).
547 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
548 arms of an 'if', not using conditional expressions; otherwise GDB
549 complains about the types in the unevaluated arm when the argument
550 is an integer literal.
551 (xgetint): Simplify expression.
552 * alloc.c (gdb_make_enums_visible): New constant. This ports to
553 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
554 Zaretskii in <http://bugs.gnu.org/12036#13>.
555 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
556 needed now that we have gdb_make_enums_visible.
557 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
558 (enum enum_USE_LSB_TAG):
559 New enum types, packaging up enums that need to be exported to GDB.
560
694b6c97
DA
5612012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
562
563 Utility function to make a list from specified amount of objects.
564 * lisp.h (enum constype): New datatype.
565 (listn): New prototype.
566 * alloc.c (listn): New function.
567 (Fmemory_use_count, syms_of_alloc): Use it.
568 * buffer.c (syms_of_buffer): Likewise.
569 * callint.c (syms_of_callint): Likewise.
570 * charset.c (define_charset_internal): Likewise.
571 * coding.c (syms_of_coding): Likewise.
572 * keymap.c (syms_of_keymap): Likewise.
573 * search.c (syms_of_search): Likewise.
574 * syntax.c (syms_of_syntax): Likewise.
575 * w32.c (init_environment): Likewise.
576 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
577 * xdisp.c (syms_of_xdisp): Likewise.
578 * xfns.c (syms_of_xfns): Likewise.
579
6195f384
DA
5802012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
581
582 Fast save_excursion_save and save_excursion_restore.
583 * lisp.h (struct Lisp_Excursion): New data type.
584 (PVEC_EXCURSION): New pseudovector type.
585 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
586 to deal with it. Adjust comments.
587 (init_marker, attach_marker): New prototype.
588 (unchain_marker): Adjust prototype.
589 * marker.c (attach_marker): Change to global.
590 (init_marker): New function.
591 * alloc.c (Fmake_marker, build_marker): Use it.
592 (build_marker): More easserts.
593 (mark_object): Handle struct Lisp_Excursion.
594 * editfns.c (save_excursion_save, save_excursion_restore):
595 Reimplement to use struct Lisp_Excursion. Add comments.
596
5eceb8fb
PE
5972012-07-26 Paul Eggert <eggert@cs.ucla.edu>
598
599 Fix export of symbols to GDB (Bug#12036).
600 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
601 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
602 emacs.c, as this is a more-suitable home. Had this been done earlier
603 the fix for 12036 would have avoided some of the problems noted in
604 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
605 would have been more obvious.
562157c8
PE
606 * emacs.c: Do not include <verify.h>; no longer needed.
607 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
608 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
609 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
610 Remove; now done in lisp.h.
611 * lisp.h (PUBLISH_TO_GDB): New macro.
612 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
613 (DATA_SEG_BITS): Use it.
614 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
615 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
616 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
617 not be usable in #if. This simplifies things.
618
d6749401
JB
6192012-07-26 Juanma Barranquero <lekktu@gmail.com>
620
621 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
622
1781b9e9
PE
6232012-07-26 Paul Eggert <eggert@cs.ucla.edu>
624
d89518db 625 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
626 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
627 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
628 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
629 Adjust to changes in lisp.h and emacs.c, by using
630 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
631 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
632 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
633 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
634 instead of gdb_valbits.
635 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
636 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
637 instead of gdb_array_mark_flag.
638 (xboolvector): Get size from $->size, not $->header.size.
639 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
640 (xreload, hook-run, hookpost-run): Remove.
641 * emacs.c: Include <verify.h>.
642 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
643 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
644 Remove.
645 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
646 (gdb_USE_LSB_TAG): New enum constants.
647 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
648 Also define these as enum constants, so they're visible to GDB.
649 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
650 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
651 as constants, so they're visible to GDB.
652 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
653 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
654 Now enum constants, not macros, so they're visible to GDB.
655 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
656 more convenient now. All uses changed.
657 (VALMASK) [USE_LSB_TAG]: Also define in this case.
658 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
659
3628596a
DA
6602012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
661
662 Explicitly free restriction data that are not needed anymore.
663 * editfns.c (save_restriction_restore): Free restriction data.
664
7abaf5cc
SM
6652012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
666
667 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
668 add argument, tune behavior, and adjust all callers.
669
71f88e00
PE
6702012-07-25 Paul Eggert <eggert@cs.ucla.edu>
671
672 Use typedef for EMACS_INT, EMACS_UINT.
673 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
674 than macros. This simplifies debugging in the usual case, since
675 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
676 and it allows expressions involving EMACS_INT casts.
677 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
678
57ec3034
JD
6792012-07-25 Jan Djärv <jan.h.d@swipnet.se>
680
681 * nsterm.m (ns_read_socket): Return early if there is a modal
682 window (Bug#12043).
683
8137e7b3
MR
6842012-07-25 Martin Rudalics <rudalics@gmx.at>
685
686 * frame.c (Fredirect_frame_focus): In doc-string don't mention
687 that FOCUS-FRAME can be omitted.
688
04e9897c
DA
6892012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
690
691 Adjust buffer text indirection counters at the end of Fkill_buffer.
692 * buffer.c (Fkill_buffer): Adjust indirection counters when the
693 buffer is definitely dead. This should really fix an issue reported
694 by Christoph Scholtes again. (Bug#12007).
695 (init_buffer_once): Initialize indirection counters of
696 buffer_defaults and buffer_local_symbols (for sanity and safety).
697
8a0484e1
EZ
6982012-07-24 Eli Zaretskii <eliz@gnu.org>
699
700 * xdisp.c (init_iterator): Don't compute dimensions of truncation
701 and continuation glyphs on tooltip frames, leave them at zero.
702 Avoids continued lines in tooltips. (Bug#11832)
703
fa691a83
DA
7042012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
705
706 Simplify copy_overlay.
04e9897c 707 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
708 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
709
436bc8e0
EZ
7102012-07-23 Eli Zaretskii <eliz@gnu.org>
711
712 * print.c (print_object): Don't crash when a frame's name is nil
713 or invalid. (Bug#12025)
714
715 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
716 it signals an error when a tooltip frame is being created.
717
d7a7fda3
DA
7182012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
719
720 Cleanup miscellaneous objects allocation and initialization.
721 * alloc.c (allocate_misc): Change to static. Add argument to
722 specify the subtype. Adjust comment and users.
723 (build_overlay): New function.
724 * buffer.c (copy_overlays, Fmake_overlay): Use it.
725 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
726 (allocate_misc): Remove prototype.
727 (build_overlay): Add prototype.
728
7292012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
730
731 Swap buffer text indirection counters in Fbuffer_swap_text.
732 * buffer.c (Fbuffer_swap_text): Swap indirections too.
733 This avoids crash reported by Christoph Scholtes at
734 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
735
9d7fa573
JD
7362012-07-22 Jan Djärv <jan.h.d@swipnet.se>
737
738 * nsmenu.m (Popdown_data): New struct.
739 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
740 free Popdown_data.
741 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
742 (initWithContentRect): Make imgView and contentView non-static
743 and autorelease them. Also autorelease img and matrix (Bug#12005).
744 (dealloc): Remove (Bug#12005).
745
0dd6d66d
DA
7462012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
747
748 Adjust consing_since_gc when objects are explicitly freed.
749 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
750 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
751 (free_cons, free_misc): Subtract object size from consing_since_gc.
752
d36d71df
DA
7532012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Simplify and cleanup markers positioning code.
756 * marker.c (attach_marker): More useful eassert.
757 (live_buffer, set_marker_internal): New function.
758 (Fset_marker, set_marker_restricted): Use set_marker_internal.
759 (set_marker_both, set_marker_restricted_both): Use live_buffer.
760
fb9ea40f
PE
7612012-07-22 Paul Eggert <eggert@cs.ucla.edu>
762
763 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
764 as it's limited by the amount of memory, not by INT_MAX.
765
2d5c5f7d
EZ
7662012-07-21 Eli Zaretskii <eliz@gnu.org>
767
07fb592e
EZ
768 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
769 in special-event-map. See the discussion at
770 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
771 for the reasons.
772
37a9eac8 773 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
774 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
775 Fabrice Popineau <fabrice.popineau@supelec.fr>.
776
c4328746
JD
7772012-07-21 Jan Djärv <jan.h.d@swipnet.se>
778
779 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 780 (conversationIdentifier): Return value is NSInteger.
784051c4 781 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 782
6e5d1c12
CY
7832012-07-21 Chong Yidong <cyd@gnu.org>
784
785 * window.c (decode_any_window): Signal an error if the window is
786 on a dead frame (Bug#11984).
787
9928463d
DA
7882012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
789
790 Add indirection counting to speed up Fkill_buffer.
791 * buffer.h (struct buffer): New member.
792 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
793 (Fmake_indirect_buffer): Set indirection counter to -1, increment
794 base buffer indirection counter.
795 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
796 (Fkill_buffer): Adjust indirection counters as needed, don't walk
797 through buffer list if indirection counter is 0.
798
f8643a6b
DA
7992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
800
801 Extend the value returned by Fgarbage_collect with heap statistics.
802 * alloc.c (Qheap): New symbol.
803 (syms_of_alloc): DEFSYM it.
804 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
805 (Fmemory_free): Remove.
806 (syms_of_alloc): Don't defsubr it.
807 * buffer.c (Fcompact_buffer): Remove.
808 (syms_of_buffer): Don't defsubr it.
809
dac616ff
DA
8102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
811
812 Make maybe_gc inline.
813 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
814 * lisp.h (consing_since_gc, gc_relative_threshold)
815 (memory_full_cons_threshold): Revert declaration.
816 (maybe_gc): Remove prototype, define as inline.
817 * alloc.c: Remove old commented-out code.
818 (consing_since_gc, gc_relative_threshold)
819 (memory_full_cons_threshold): Revert to global.
820 (maybe_gc): Remove.
821
d7ea76b4
DA
8222012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
823
824 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
825 * lisp.h (build_unibyte_string): New function.
826 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
827 * sysdep.c, w32fns.c, xfns.c: Use it.
828 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
829 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
830 Adjust users accordingly.
831 * font.h (font_open_by_name): Adjust prototype.
832
765e61e3
DA
8332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
834
835 Cleanup calls to Fgarbage_collect.
836 * lisp.h (maybe_gc): New prototype.
837 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
838 Remove declarations.
839 * alloc.c (maybe_gc): New function.
840 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
841 Make them static.
842 * bytecode.c (MAYBE_GC): Use maybe_gc.
843 * eval.c (eval_sub, Ffuncall): Likewise.
844 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
845 to avoid dependency from auto-save feature.
846
52b852c7
PE
8472012-07-19 Paul Eggert <eggert@cs.ucla.edu>
848
849 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
850 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
851 'for_each_per_buffer_object_at'.
852 All uses changed. It's better to use upper-case for macros that
853 cannot be implemented as functions, to give the reader a clue
854 that they're special.
855
5db81e33
SM
8562012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
857
858 * alloc.c (Fgarbage_collect): Tweak docstring.
859
5b835e1d
DA
8602012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
861
862 Tweak the value returned from Fgarbage_collect again.
863 * alloc.c (Fgarbage_collect): New return value, as confirmed in
864 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
865 Adjust documentation.
866 (total_vector_bytes): Rename to total_vector_slots, adjust
867 accounting.
868 (total_free_vector_bytes): Rename to total_free_vector_slots,
869 adjust accounting.
870 (Qstring_bytes, Qvector_slots): New symbols.
871 (syms_of_alloc): DEFSYM them.
872
9cd47b72
DA
8732012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
874
875 Buffer compaction primitive which may be used from Lisp.
876 * buffer.c (compact_buffer, Fcompact_buffer): New function.
877 (syms_of_buffer): Register Fcompact_buffer.
878 * alloc.c (Fgarbage_collect): Use compact_buffer.
879 * buffer.h (compact_buffer): New prototype.
880 (struct buffer_text): New member.
881
d17337e5
DA
8822012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
883
884 New macro to iterate over all buffers, miscellaneous cleanups.
885 * lisp.h (all_buffers): Remove declaration.
886 * buffer.h (all_buffers): Add declaration, with comment.
887 (for_each_buffer): New macro.
888 * alloc.c (Fgarbage_collect, mark_object): Use it.
889 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
890 (init_buffer): Likewise.
891 * data.c (Fset_default): Likewise.
892 * coding.c (code_conversion_restore): Remove redundant check
893 for dead buffer.
894 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
895
60cfd278
AS
8962012-07-18 Andreas Schwab <schwab@linux-m68k.org>
897
898 Fix bug that created negative-length intervals.
899 * intervals.c (merge_interval_right, merge_interval_left):
900 Do not zero out this interval if it is absorbed by its children,
901 as this interval's total length doesn't change in that case. See
902 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
903
d06714cb
PE
9042012-07-18 Paul Eggert <eggert@cs.ucla.edu>
905
83713154
PE
906 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
907 when invoking (make-bool-vector N t) and N is a positive
908 multiple of 8 -- the last 8 bits were mistakenly cleared.
909
d06714cb
PE
910 Remove some struct layout assumptions in bool vectors.
911 * alloc.c (bool_header_size): New constant.
912 (header_size, word_size): Move earlier, as they're now used earlier.
913 Use 'word_size' in a few more places, where it's appropriate.
914 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
915 padding before the data member of a bool vector.
916 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
917 than doing the check by hand with an abort ().
918
464d5a5e
SM
9192012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
920
5fbc0409
SM
921 * eval.c (Fdefvar): Don't check constants since we only set the var if
922 it's not yet defined anyway (bug#11904).
923
464d5a5e
SM
924 * lisp.h (last_undo_boundary): Declare new var.
925 * keyboard.c (command_loop_1): Set it.
926 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
927 were auto-added by the command loop (bug#11774).
928
8dc2e44a
AS
9292012-07-18 Andreas Schwab <schwab@linux-m68k.org>
930
931 * w32font.c (Qsymbol): Remove local definition.
932 (syms_of_w32font): Don't DEFSYM it.
933
169925ec
DA
9342012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
935
936 Fix sweep_vectors to handle large bool vectors correctly.
937 * alloc.c (sweep_vectors): Account total_vector_bytes for
938 bool vectors larger than VBLOCK_BYTES_MAX.
939
5fbfb018
CY
9402012-07-18 Chong Yidong <cyd@gnu.org>
941
942 * frame.c (x_set_frame_parameters): Revert bogus change introduced
943 in 2012-05-25 commit by Paul Eggert (Bug#11738).
944
3ab6e069
DA
9452012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
946
947 Return more descriptive data from Fgarbage_collect.
948 Suggested by Stefan Monnier in
949 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
950 * alloc.c (bounded_number): New function.
951 (total_buffers, total_vectors): New variable.
952 (total_string_size): Rename to total_string_bytes, adjust users.
953 (total_vector_size): Rename to total_vector_bytes, adjust users.
954 (sweep_vectors): Account total_vectors and total_vector_bytes.
955 (Fgarbage_collect): New return value. Adjust documentation.
956 (gc_sweep): Account total_buffers.
957 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
958 (VECTOR_SIZE): Remove.
959 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
960 (Qinterval, Qmisc): New symbols.
961 (syms_of_data): Initialize them.
962 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
963 (Qcons, Qbuffer): New declarations.
964
6d02fe5b
PE
9652012-07-17 Paul Eggert <eggert@cs.ucla.edu>
966
967 * alloc.c (Fmemory_free): Account for memory-free's own storage.
968 Round up, not down. Improve doc.
969
b7ffe040
DA
9702012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
971
972 Restore old code in allocate_string_data to avoid Faset breakage.
973 Reported by Julien Danjou <julien@danjou.info> in
974 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
975 * alloc.c (allocate_string_data): Restore old code with minor
976 adjustments, fix comment to explain this subtle issue.
977
4dc7c8d5
SM
9782012-07-17 Eli Zaretskii <eliz@gnu.org>
979
980 Remove FILE_SYSTEM_CASE.
981 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
982
983 * fileio.c (FILE_SYSTEM_CASE): Don't define.
984 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
985 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
986 call-process-region passes it through expand-file-name.
987
988 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
989
9902012-07-17 Andreas Schwab <schwab@linux-m68k.org>
991
992 Fix crash when creating indirect buffer (Bug#11917)
993 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
994 Don't handle unbound variables specially if non-zero.
995 (Fbuffer_local_variables): Pass zero.
996 (clone_per_buffer_values): Pass non-zero.
997
9982012-07-17 Andreas Schwab <schwab@linux-m68k.org>
999
1000 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1001 to make the loop interruptible.
1002
10032012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1004
1005 * gnutls.c (emacs_gnutls_handshake): Only retry if
1006 GNUTLS_E_INTERRUPTED.
1007
cce7fefc
DA
10082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1009
1010 Cleanup and convert miscellaneous checks to eassert.
1011 * alloc.c (mark_interval): Fix comment, partially rephrase
1012 old comment from intervals.h (see below).
1013 * intervals.c (find_interval, adjust_intervals_for_insertion)
1014 (delete_interval, adjust_intervals_for_deletion)
1015 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1016 Convert to eassert.
1017 (adjust_intervals_for_insertion, make_new_interval):
1018 Remove obsolete and unused code.
1019 * intervals.h (struct interval): Remove obsolete comment.
1020 * textprotp.c (erase_properties): Remove unused code.
1021 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1022 (Fremove_list_of_text_properties): Convert to eassert.
1023
9ea10cc3
CY
10242012-07-17 Chong Yidong <cyd@gnu.org>
1025
1026 * editfns.c (Finsert_char): Doc fix.
1027
3900d5de
DA
10282012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 Fix previous change to make Fmemory_free always accurate.
1031 * alloc.c (make_interval): Update total_free_intervals.
1032 (make_float): Likewise for total_free_floats.
1033 (free_cons, Fcons): Likewise for total_free_conses.
1034 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1035 Likewise for total_free_vector_bytes.
1036 (Fmake_symbol): Likewise for total_free_symbols.
1037 (bytes_free): Remove.
1038
7098646f
DA
10392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1040
1041 Simple free memory accounting feature.
1042 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1043 (sweep_vectors): Accumulate size of free vectors.
1044 (Fgarbage_collect): Setup bytes_free.
1045 (Fmemory_free): New function.
1046 (syms_of_alloc): Register it.
1047
22657b40
DA
10482012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1049
1050 Cleanup overlays checking.
1051 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1052 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1053 eassert and OVERLAYP.
1054 (sort_overlays): Change to use OVERLAYP.
1055
ddfc8813
RK
10562012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1057
1058 * editfns.c (Finsert_char): Make it interactive, and make the
1059 second arg optional. Copy interactive spec and docstring from
1060 ucs-insert.
1061
7c26cf3c
PE
10622012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1065 Unlike the other wrapped functions, fabs has an unspecified
1066 effect on errno.
1067
5d127af9
JD
10682012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1069
1070 * nsterm.m (keyDown): Interpret flags without left/right bits
1071 as the left key (Bug#11670).
1072
6a0dd1d7
DA
10732012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1074
1075 Remove empty and useless init functions.
1076 * lisp.h (init_character_once, init_fns, init_image)
1077 (init_filelock, init_sound): Remove prototype.
1078 * character.c (init_character_once): Remove.
1079 * filelock.c (init_filelock): Likewise.
1080 * fns.c (init_fns): Likewise.
1081 * image.c (init_image): Likewise.
1082 * sound.c (init_sound): Likewise.
1083 * emacs.c (main): Adjust accordingly.
1084
7a6136fd
DA
10852012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1086
1087 * gtkutil.h: Tiny cleanups.
1088 (use_old_gtk_file_dialog): Remove useless declaration.
1089 (xg_uses_old_file_dialog): Add suggested const attribute.
1090
ce811ad9
EZ
10912012-07-15 Eli Zaretskii <eliz@gnu.org>
1092
1093 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1094 (bidi_paragraph_init): Use it to limit search forward for a strong
1095 directional character in abnormally large paragraphs full of
1096 neutral or weak characters. (Bug#11943)
1097
c9adfeaa
SF
10982012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1099
1100 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1101 the toolbar (Bug#9451).
1102 (xg_make_tool_item): Give the widget event box a transparent
1103 background.
1104
fff62aa9
DA
11052012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1106
1107 Cleanup basic allocation variables and functions.
1108 * alloc.c (ignore_warnings, init_intervals, init_float)
1109 (init_cons, init_symbol, init_marker): Remove.
1110 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1111 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1112 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1113 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1114 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1115 (staticidx, init_alloc_once, init_strings, free_ablock):
1116 Remove redundant initialization.
1117 * fns.c (init_weak_hash_tables): Remove.
1118 * lisp.h (init_weak_hash_tables): Remove prototype.
1119
9730daca
DA
11202012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1121
1122 Use zero_vector where appropriate.
1123 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1124 accordingly.
1125 * lisp.h (zero_vector): New declaration.
1126 * font.c (null_vector): Remove.
1127 (syms_of_font): Remove initialization and staticpro.
1128 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1129 * keymap.c (Faccessible_keymaps): Likewise.
1130
2e2d2a13
LL
11312012-07-15 Leo Liu <sdl.web@gmail.com>
1132
1133 * fringe.c: Fix typo in comments.
1134
cd276f6e
LL
11352012-07-14 Leo Liu <sdl.web@gmail.com>
1136
1137 * fringe.c: Add a new bitmap exclamation-mark.
1138
5a1131d9
EZ
11392012-07-14 Eli Zaretskii <eliz@gnu.org>
1140
1141 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1142
1143 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1144 (HAVE_MENUS): Don't define, defined by editing config.in with
1145 msdos/sed2v2.inp.
1146 (GMALLOC_INHIBIT_VALLOC): Don't define.
1147 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1148
22e983b7
JB
11492012-07-14 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1152
5b3f250f
GM
11532012-07-14 Glenn Morris <rgm@gnu.org>
1154
1155 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1156 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1157 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1158
33d63ff4
GM
11592012-07-13 Glenn Morris <rgm@gnu.org>
1160
5b633342
GM
1161 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1162
33d63ff4
GM
1163 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1164 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1165
b55b9f85
JD
11662012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1167
0dc8cf50
JD
1168 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1169 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1170 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1171 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1172 where appropriate.
1173 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1174 as boolean expression.
1175 (x_set_window_size): Remove unused variable toolbar.
1176 (ns_get_color_default, ns_mod_to_lisp): Remove.
1177 (ns_mouse_position): Remove unused variables xchar and ychar.
1178 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1179 (ns_set_vertical_scroll_bar): Remove unused variable count.
1180 (ns_delete_terminal): Remove unused variable i.
1181 (ns_term_init): Remove unused variables r, g and b.
1182 (mouseDown): Remove unused variable window.
1183 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1184 (initFrameFromEmacs): Remove unused variable vbextra.
1185 (mouseEntered): Remove unused variables p and dpyinfo.
1186 (mouseExited): Remove unused variables p and r.
1187 (ns_define_frame_cursor, ns_clear_frame_area)
1188 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1189 (menuDown): Assign [sender tag] to variable and cast the variable.
1190
1191 * nsterm.h (menuDown): Add id as type to argument sender.
1192 (ns_display_info_for_name): Add Lisp_Object argument.
1193 (ns_term_init): Add Lisp_Object argument.
1194 (ns_map_event_to_object): Add void argument.
1195 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1196 prototype with arguments and only declare if __OBJC__.
1197 (nxatoms_of_nsselect): Add void argument.
1198 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1199 (ns_alloc_autorelease_pool): Add void argument.
1200 (ns_release_autorelease_pool): Add void* argument.
1201 (ns_get_defaults_value): Add const char* argument.
1202
1203 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1204 (initFromContents): Use SSDATA where appropriate.
1205 (ns_update_menubar): Add braces to ambigous if-else.
1206 (initWithTitle): Put () around assignment in if statement.
1207 (ns_menu_show): Remove unused variables window and keymap.
1208 (update_frame_tool_bar): Remove unused variable selected_p.
1209 (initWithContentRect): Remove unused variable this_cmd_name.
1210
1211 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1212 appropriate.
1213 (setXBMColor): Remove unused variable len.
1214 (setPixmapData): Put () around assignment in loop statement.
1215
1216 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1217 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1218 where appropriate.
1219 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1220 around assignment in loop statement.
1221 (nsfont_open): Remove unused variable i.
1222 (nsfont_open): Remove unused variable len.
1223 (nsfont_draw): Remove unused variable cs.
1224
1225 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1226 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1227 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1228 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1229 (Fns_font_name, Fns_perform_service)
1230 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1231 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1232 (ns_set_name): Remove unused variable view.
1233 (x_set_menu_bar_lines): Remove unused variable olines.
1234 (x_set_tool_bar_lines): Remove unused variable root_window.
1235 (Fns_list_colors): Put () around assignment in while statement.
1236 (Fns_perform_service): Remove unused variable len.
1237 (Fns_display_usable_bounds): Remove unused variable top.
1238 (syms_of_nsfns): Remove unused variable i.
1239
b55b9f85
JD
1240 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1241 memcpy (Bug#11907).
1242
ed9265fc 12432012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1244
1245 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1246 and free it with DestroyExceptionInfo (Bug#11558).
1247
ef099b57
JB
12482012-07-13 Juanma Barranquero <lekktu@gmail.com>
1249
1250 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1251 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1252 Set here, not in nt/config.nt.
1253
ea814a5d
EZ
12542012-07-13 Eli Zaretskii <eliz@gnu.org>
1255
1256 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1257 cursor overflow into the last glyph on display line when the right
1258 fringe is off. (Bug#11832)
1259
1a952767
PE
12602012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 * xdisp.c (produce_special_glyphs): Now static.
1263 * dispextern.h (produce_special_glyphs): Remove decl.
1264
983188fd
GM
12652012-07-13 Glenn Morris <rgm@gnu.org>
1266
8d7c7eed 1267 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1268 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1269
983188fd
GM
1270 * s/usg5-4-common.h (USG, USG5):
1271 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1272 * s/sol2-6.h (SOLARIS2):
1273 * s/irix6-5.h (IRIX6_5):
1274 * s/hpux10-20.h (USG, USG5, HPUX):
1275 * s/gnu-linux.h (USG, GNU_LINUX):
1276 * s/freebsd.h (BSD_SYSTEM):
1277 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1278 * s/cygwin.h (CYGWIN):
1279 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1280 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1281
d1e68667 12822012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1283
1284 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1285
6de0e799
GM
12862012-07-13 Glenn Morris <rgm@gnu.org>
1287
739ae010
GM
1288 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1289
dbee5793
GM
1290 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1291
6de0e799
GM
1292 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1293 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1294
b82da769
GM
12952012-07-12 Glenn Morris <rgm@gnu.org>
1296
4fae5a7a 1297 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1298
1299 * process.c (init_process_emacs): Rename from init_process.
1300 The old name is also the name of a Mach system call.
1301 * lisp.h, emacs.c: Update for this name change.
1302 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1303 longer needed.
1304
5a979817
EZ
13052012-07-12 Eli Zaretskii <eliz@gnu.org>
1306
1307 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1308 memmove call that removes glyphs covered by the left truncation
1309 glyph. Improve commentary.
1310 (display_line): Fix display of continuation glyphs on GUI frames
1311 when the right fringe is turned off and variable-size fonts are
1312 used in the window. Move the code that appends a stretch glyph to
1313 produce_special_glyphs, so that it could be used for truncation
1314 and continuation glyphs alike.
1315 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1316 glyph of a suitably computed width, to align the special glyphs at
1317 the window margin. Code moved from display_line. (Bug#11832)
1318
3e91a053
GM
13192012-07-12 Glenn Morris <rgm@gnu.org>
1320
ba9e4b84
GM
1321 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1322
1323 * s/gnu-linux.h, s/hpux10-20.h:
1324 Do not unconditionally define HAVE_XRMSETDATABASE.
1325
3e91a053
GM
1326 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1327
b300b1f4
PE
13282012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 Fix typos that broke OS X build.
1331 Reported by Randal L. Schwartz in
1332 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1333 * nsterm.m (ns_timeout): Add missing local decl.
1334 (ns_get_color): snprintf -> sprintf, to fix typo.
1335
6e777848
GM
13362012-07-12 Glenn Morris <rgm@gnu.org>
1337
3f922c37
GM
1338 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1339 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1340 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1341 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1342
0ab7b23a
GM
1343 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1344 Move PTY_OPEN to configure.
1345
6e777848
GM
1346 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1347 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1348 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1349
4a7edc24
DA
13502012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1351
1352 Use empty_unibyte_string where applicable.
1353 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1354 * lread.c (read1): Likewise.
1355 * xsettings.c (syms_of_xsettings): Likewise.
1356
308aab79
GM
13572012-07-12 Glenn Morris <rgm@gnu.org>
1358
42bd1719
GM
1359 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1360 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1361 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1362 * s/hpux10-20.h (RUN_TIME_REMAP):
1363 * s/bsd-common.h (TABDLY): Move to configure.
1364
1365 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1366
1367 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1368
ea0bbd17 1369 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1370 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1371
1372 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1373
308aab79
GM
1374 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1375 * s/template.h: Move NARROWPROTO to configure.
1376
ee1cf5cf
GM
13772012-07-11 Glenn Morris <rgm@gnu.org>
1378
30fe9bf4
GM
1379 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1380 unused since 2011-01-17 change to systty.h.
1381
ee1cf5cf
GM
1382 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1383 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1384 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1385
63e47e07
PE
13862012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1389
c43fb4c3
GM
13902012-07-11 Glenn Morris <rgm@gnu.org>
1391
1392 * s/darwin.h, s/gnu-linux.h, s/template.h:
1393 Move INTERRUPT_INPUT to configure.
1394
e8df9267
DA
13952012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1396
1397 Minor adjustments to interning code.
1398 * lisp.h (intern, intern_c_string): Redefine as static inline
1399 wrappers for intern_1 and intern_c_string_1, respectively.
1400 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1401 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1402 Vobarray checking.
e8df9267
DA
1403 * font.c (font_intern_prop): Likewise. Adjust comment.
1404 * w32font.c (intern_font_name): Likewise.
1405
34348bd4
AS
14062012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1407
d96a1e0c
AS
1408 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1409
34348bd4
AS
1410 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1411 of Fcar/Fcdr if possible.
1412 * font.c (check_otf_features): Likewise.
1413 * fontset.c (Fnew_fontset): Likewise.
1414 * gnutls.c (Fgnutls_boot): Likewise.
1415 * minibuf.c (read_minibuf): Likewise.
1416 * msdos.c (IT_set_frame_parameters): Likewise.
1417 * xmenu.c (Fx_popup_dialog): Likewise.
1418 * w32menu.c (Fx_popup_dialog): Likewise.
1419
c8add24e
GM
14202012-07-11 Glenn Morris <rgm@gnu.org>
1421
4b575b3c
GM
1422 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1423 since nothing has defined it on these platforms.
1424
09f4e3b0
GM
1425 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1426 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1427
172bedef
GM
1428 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1429 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1430 Move CLASH_DETECTION to configure.
1431
249685df
GM
1432 * s/gnu.h: Remove file, which is now empty.
1433
c8add24e
GM
1434 * s/gnu.h, s/gnu-linux.h:
1435 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1436
b41253a3
JW
14372012-07-11 John Wiegley <johnw@newartisans.com>
1438
1439 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1440 function attribute, so we only use it if it exists in the
1441 compiler.
1442
d923b542
DA
14432012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1444
1445 Avoid call to strlen in fast_c_string_match_ignore_case.
1446 * search.c (fast_c_string_match_ignore_case): Change to use
1447 length argument. Adjust users accordingly.
1448 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1449
5ebbef1d
PE
14502012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1451
bb352260
PE
1452 Assume mkdir, rmdir.
1453 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1454 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1455
57054ddd
PE
1456 Assume rename.
1457 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1458
b747d3f7
PE
1459 Assume perror.
1460 * s/hpux10-20.h (HAVE_PERROR): Remove.
1461 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1462 Remove dummy definition, as this problem was obsolete long ago.
1463
5ebbef1d
PE
1464 Assume strerror.
1465 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1466
984e7f30
DA
14672012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1468
1469 Avoid calls to strlen in font processing functions.
1470 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1471 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1472 users accordingly.
d923b542
DA
1473 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1474 Adjust prototypes.
1475 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1476 Change to return ptrdiff_t.
984e7f30
DA
1477 (xfont_list_pattern, xfont_match): Use length returned by
1478 xfont_decode_coding_xlfd.
1479 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1480
20e94fdd
GM
14812012-07-11 Glenn Morris <rgm@gnu.org>
1482
9d596af3
GM
1483 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1484 Move DONT_REOPEN_PTY to configure.
1485
20e94fdd
GM
1486 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1487 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1488
e99a530f
PE
14892012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1490
22ffb973
PE
1491 Remove "#define unix" that is no longer needed (Bug#11905).
1492 * s/aix4-2.h (unix): Remove; no longer needed.
1493
e9a9ae03
PE
1494 EMACS_TIME simplification (Bug#11875).
1495 This replaces macros (which typically do not work in GDB)
1496 with functions, typedefs and enums, making the code easier to debug.
1497 The functional style also makes code easier to read and maintain.
1498 * systime.h: Include <sys/time.h> on all hosts, not just if
1499 WINDOWSNT, since 'struct timeval' is needed in general.
1500 (EMACS_TIME): Now a typedef, not a macro.
1501 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1502 not macros.
1503 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1504 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1505 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1506 (EMACS_TIME_LE): Now functions, not macros.
1507 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1508 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1509 which are not functions. All uses rewritten to use:
1510 (make_emacs_time): New function.
1511 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1512 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1513 not functions. All uses rewritten to use the following, respectively:
1514 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1515 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1516 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1517 * fileio.c (Fcopy_file):
1518 * xterm.c (XTflash): Get the current time closer to when it's used.
1519 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1520
ffacb126
PE
1521 * bytecode.c (targets): Suppress -Woverride-init warnings.
1522
e99a530f
PE
1523 Simplify by avoiding confusing use of strncpy etc.
1524 * doc.c (Fsnarf_documentation):
1525 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1526 * frame.c (Fmake_terminal_frame):
1527 * gtkutil.c (get_utf8_string):
1528 * lread.c (openp):
1529 * nsmenu.m (ns_update_menubar):
1530 * regex.c (regerror):
1531 Prefer memcpy to strncpy and strncat when either will do.
1532 * fileio.c (Fsubstitute_in_file_name):
1533 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1534 (menu_separator_name_p):
1535 * nsmenu.m (ns_update_menubar):
1536 Prefer memcmp to strncmp when either will do.
1537 * nsterm.m: Include <ftoastr.h>.
1538 (ns_get_color):
1539 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1540 Prefer snprintf to strncpy.
1541 * nsterm.m (ns_term_init):
1542 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1543 * nsterm.m (ns_term_init):
1544 Avoid the need for strncpy, by using build_string or
1545 make_unibyte_string directly. Use dtoastr, not snprintf.
1546 * process.c (Fmake_network_process): Diagnose service names that
1547 are too long, rather than silently truncating them or creating
1548 non-null-terminated names.
1549 (Fnetwork_interface_info): Likewise, for interface names.
1550 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1551 Prefer sprintf to strncat.
1552 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1553 Prefer vsnprintf to vsprintf + strncpy.
1554
c59592b3
GM
15552012-07-10 Glenn Morris <rgm@gnu.org>
1556
1557 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1558 Clarify fallback case.
1559
7d7bbefd
DA
15602012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1561
1562 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1563 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1564 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1565 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1566 where argument type is known to be a Lisp_Cons.
1567
3a4c8000
TT
15682012-07-10 Tom Tromey <tromey@redhat.com>
1569
1570 * bytecode.c (BYTE_CODE_THREADED): New macro.
1571 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1572 (enum byte_code_op): New type.
1573 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1574 (exec_byte_code): Use them. Use token threading when applicable.
1575
2a0213a6
DA
15762012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1577
1578 Optimize pure C strings initialization.
1579 * lisp.h (make_pure_string): Fix prototype.
1580 (build_pure_c_string): New function, defined as static inline. This
1581 provides a better opportunity to optimize away calls to strlen when
1582 the function is called with compile-time constant argument.
1583 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1584 argument, adjust users accordingly. Use build_pure_c_string where
1585 appropriate.
1586 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1587 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1588 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1589
cb1caeaf
DA
15902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 Avoid calls to strlen in miscellaneous functions.
1593 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1594 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1595 * lread.c (openp): Likewise.
1596
c293e30c
DA
15972012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1598
1599 Avoid calls to strlen in path processing functions.
1600 * fileio.c (file_name_as_directory): Add comment. Change to add
1601 srclen argument and return the length of result. Adjust users
1602 accordingly.
1603 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1604 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1605 users accordingly.
1606 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1607
9e059e3f
GM
16082012-07-10 Glenn Morris <rgm@gnu.org>
1609
d02eb359
GM
1610 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1611 Move PENDING_OUTPUT_COUNT definition to configure.
1612
882cf227
GM
1613 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1614 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1615 * s/gnu.h (DATA_START): Move definitions to configure.
1616
af6e839f
GM
1617 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1618 We include usg5-4-common.h, which defines them both.
1619
40289a12
GM
1620 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1621 O_RDONLY already includes it).
1622
9e059e3f
GM
1623 Stop ns builds setting the EMACSLOADPATH environment variable.
1624 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1625 Now it does not set EMACSLOADPATH, just returns the load-path string.
1626 * nsterm.h: Update accordingly.
1627 * lread.c [HAVE_NS]: Include nsterm.h.
1628 (init_lread) [HAVE_NS]: Use ns_load_path.
1629 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1630
7c4e8ec0
GM
16312012-07-09 Glenn Morris <rgm@gnu.org>
1632
d4f600ff
GM
1633 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1634 since the included bsd-common.h does so.
1635
cbb31951
GM
1636 Stop ns builds setting the EMACSPATH environment variable.
1637 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1638 (ns_init_paths): Do not set EMACSPATH.
1639 * nsterm.h (ns_exec_path): Add it.
1640 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1641 Use ns_exec_path.
1642
7c4e8ec0
GM
1643 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1644
26bccfae
PE
16452012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1646
a0bee46f
PE
1647 * process.c (wait_reading_process_output): 'waitchannels' was unset
1648 when read_kbd || !NILP (wait_for_cell); fix this.
1649
5994c183
PE
1650 Add GCC-style 'const' attribute to functions that can use it.
1651 * character.h (char_resolve_modifier_mask):
1652 * keyboard.h (make_ctrl_char):
1653 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1654 (init_character_once, next_almost_prime, init_fns, init_image)
1655 (flush_pending_output, init_sound):
1656 * mem-limits.h (start_of_data):
1657 * menu.h (finish_menu_items):
1658 Add ATTRIBUTE_CONST.
1659 * emacs.c (DEFINE_DUMMY_FUNCTION):
1660 Declare the dummy function with ATTRIBUTE_CONST.
1661 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1662 Add decls with ATTRIBUTE_CONST.
1663
26bccfae
PE
1664 Minor improvements to make_formatted_string.
1665 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1666 where int is good enough, as vsprintf returns an int.
1667 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1668
a8290ec3
DA
16692012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1670
1671 Use make_formatted_string to avoid double length calculation.
1672 * lisp.h (make_formatted_string): New prototype.
1673 * alloc.c (make_formatted_string): New function.
1674 * buffer.c (Fgenerate_new_buffer_name): Use it.
1675 * dbus.c (syms_of_dbusbind): Likewise.
1676 * editfns.c (Fcurrent_time_zone): Likewise.
1677 * filelock.c (get_boot_time): Likewise.
1678 * frame.c (make_terminal_frame, set_term_frame_name)
1679 (x_report_frame_params): Likewise.
1680 * image.c (gs_load): Likewise.
1681 * minibuf.c (get_minibuffer): Likewise.
1682 * msdos.c (dos_set_window_size): Likewise.
1683 * process.c (make_process): Likewise.
1684 * xdisp.c (ensure_echo_area_buffers): Likewise.
1685 * xsettings.c (apply_xft_settings): Likewise.
1686
d01ba2f1
GM
16872012-07-09 Glenn Morris <rgm@gnu.org>
1688
1689 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1690 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1691 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1692 * nsterm.h (ns_etc_directory): Add it.
1693 * callproc.c [HAVE_NS]: Include nsterm.h.
1694 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1695
f1f924b6
DA
16962012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1697
1698 Move marker debugging code under MARKER_DEBUG.
1699 * marker.c (MARKER_DEBUG): Move marker debugging code under
1700 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1701 for bootstrap with --enable-checking (~3x slowdown reported
1702 by Juanma Barranquero <lekktu@gmail.com>).
1703 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1704
ab531b66
PE
17052012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1708 See <http://bugs.gnu.org/11825#29>.
1709
c4b3bc8a
EZ
17102012-07-08 Eli Zaretskii <eliz@gnu.org>
1711
1712 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1713 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1714 (display_line): Add commentary about displaying truncation glyphs
1715 on GUI frames.
1716 (produce_special_glyphs): Move here from term.c.
1717
1718 * term.c (produce_special_glyphs): Move to xdisp.c.
1719
1720 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1721 section.
c4b3bc8a 1722
b676b881
AS
17232012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1724
f17c5273
AS
1725 * xdisp.c (display_line): Avoid warning about implicit declaration
1726 of FRAME_FONT.
1727
298819b9
AS
1728 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1729
b676b881
AS
1730 * lisp.h: Remove empty conditional.
1731
6045c4fd
PE
17322012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1733
b3350bf9
PE
1734 * lread.c (load_path_check): Now static.
1735
6045c4fd
PE
1736 Fix some minor --with-ns problems found by static checking.
1737 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1738 (x_set_font) [!HAVE_X_WINDOWS]:
1739 * image.c (xpm_load_image) [HAVE_NS]:
1740 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1741 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1742 Remove unused local.
1743 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1744 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1745 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1746 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1747 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1748 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1749 Fix pointer signedness problem.
1750 * xfaces.c (FRAME_X_FONT_TABLE):
1751 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1752
929e7845
GM
17532012-07-07 Glenn Morris <rgm@gnu.org>
1754
1755 * lread.c (load_path_check): New function, split from init_lread.
1756 (init_lread): Reorganize. Motivation:
1757 If EMACSLOADPATH is set, check/warn about that rather than the
1758 defaults, which we are not going to use. Hence we can remove
1759 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1760 Don't warn if site-lisp directories are missing.
1761 If not installed, start from a blank load-path, since
1762 PATH_LOADSEARCH refers to the eventual installation directories.
1763
58dd0aa4
EZ
17642012-07-07 Eli Zaretskii <eliz@gnu.org>
1765
1766 Support truncation and continuation glyphs on GUI frames, when
1767 fringes are disabled. (Bug#11832)
1768 * xdisp.c (init_iterator): Get dimensions of truncation and
1769 continuation glyphs even if on GUI frames. Adjust
1770 it->last_visible_x on GUI frames when the left or right fringes,
1771 or both, are absent.
1772 (start_display, move_it_in_display_line_to): Handle the case of a
1773 GUI frame without a fringe to display continuation or truncation
1774 glyphs.
1775 (insert_left_trunc_glyphs): Support GUI frames: make sure
1776 truncation glyphs overwrite enough glyphs from the current line to
1777 have sufficient space in pixels.
1778 (display_line): Support truncation and continuation glyphs on GUI
1779 frames. If some spare pixels are left on the line after inserting
1780 the truncation glyphs, fill that space with a stretch glyph of a
1781 suitably computed width.
1782
1783 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1784 produce_glyphs, to support GUI sessions.
1785
31571fd7
PE
17862012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1787
5a16b9bc
PE
1788 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1789
f3047c75
PE
1790 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1791
31571fd7
PE
1792 Do not require float-time's arg to fit in time_t (Bug#11825).
1793 This works better on hosts where time_t is unsigned, and where
1794 float-time is applied to the (negative) difference between two times.
1795 * editfns.c (decode_time_components): Last arg is now double *,
1796 not int *, and means to store all the result as a double, without
1797 worrying about whether the seconds part fits in time_t.
1798 All callers changed.
1799 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1800 All callers changed.
1801 (Ffloat_time): Do not fail merely because the specified time falls
1802 outside of time_t range.
1803
4516fbef
GM
18042012-07-07 Glenn Morris <rgm@gnu.org>
1805
1806 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1807 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1808 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1809
07adc2c6
JB
18102012-07-07 Juanma Barranquero <lekktu@gmail.com>
1811
1812 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1813 Update dependencies.
1814
1815 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1816
fd573f31
PE
18172012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1818
fee5959d
PE
1819 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1820 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1821 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1822 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1823 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1824 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1825
fd573f31
PE
1826 * xfont.c (compare_font_names): Redo to omit the need for casts.
1827
ddadbc0e
AS
18282012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1829
fca8d6b6
AS
1830 * xfns.c (Fx_change_window_property): Doc fix.
1831 * w32fns.c (Fx_change_window_property): Doc fix.
1832
ddadbc0e
AS
1833 * w32fns.c (Fx_window_property): Accept the same arguments as the
1834 X Windows version. Doc fix.
1835 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1836
ed9265fc 18372012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1838 Eli Zaretskii <eliz@gnu.org>
1839
1840 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1841 Windows-specific code from nt/config.nt moved here.
1842 Obsolete settings removed.
1843
216ee680
PE
18442012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 * process.c: Avoid unnecessary calls to gettime.
1847 (wait_reading_process_output): Don't get the time of day
1848 when gobbling data immediately and not waiting, as there's no need
1849 for it in that case. This removes a FIXME.
1850
bdd091e4
JD
18512012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1852
1853 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1854 is defined (Bug#11768).
1855
9d44f8ce
DA
18562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1857
1858 Fix marker debugging code.
1859 * marker.c (byte_char_debug_check): Do not perform the check
1860 if buffer is not multibyte.
090bd7cb
JB
1861 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1862 Call byte_char_debug_check with correct arguments.
9d44f8ce 1863
90fc4786
DA
18642012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1865
1866 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1867 * marker.c (byte_char_debug_check, count_markers):
1868 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1869 (byte_debug_flag): Remove.
1870 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1871 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1872
7b7ae965
DA
18732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1874
4e57b342
DA
1875 Avoid code repetition in marker-related functions.
1876 * marker.c (attach_marker): New function.
1877 (Fset_marker, set_marker_restricted, set_marker_both)
1878 (set_marker_restricted_both): Use it.
1879 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1880 Consistently rename charno to charpos.
1881 (marker_position): Add eassert.
1882 (marker_byte_position): Convert to eassert.
1883
18842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1885
1886 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1887 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1888 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1889
657924ff
DA
18902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1891
1892 Introduce fast path for the widely used marker operation.
1893 * alloc.c (build_marker): New function.
1894 * lisp.h (build_marker): New prototype.
1895 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1896 * composite.c (autocmp_chars): Likewise.
1897 * editfns.c (buildmark): Remove.
1898 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1899 (save_restriction_save): Use build_marker.
1900 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1901 * window.c (save_window_save): Likewise.
1902
041a49a6
DA
19032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1904
1905 Do not use Fdelete_overlay in delete_all_overlays
1906 to avoid redundant calls to unchain_overlay.
1907 * buffer.c (drop_overlay): New function.
1908 (delete_all_overlays, Fdelete_overlay): Use it.
1909 * minibuf.c (get_minibuffer): Fix comment.
1910
7dca65a4
PE
19112012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 Port to OpenBSD 5.1 amd64.
1914 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1915 This is needed for OpenBSD, and should be harmless on all BSD systems.
1916 Also, include <sys/sysctl.h>, as it should be available on all
1917 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1918 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1919 use p_pid member, not kp_proc.pid.
1920
8eb876e2
GM
19212012-07-06 Glenn Morris <rgm@gnu.org>
1922
1923 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1924
38182d90
PE
19252012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 More xmalloc and related cleanup.
1928 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1929 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1930 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1931 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1932 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1933 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1934 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1935 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1936 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1937 * xterm.c:
1938 Omit needless casts involving void * pointers and allocation.
1939 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1940 as the former is more robust if P's type is changed.
1941 Prefer xzalloc to xmalloc + memset 0.
1942 Simplify malloc-or-realloc to realloc.
1943 Don't worry about xmalloc returning a null pointer.
1944 Prefer xstrdup to xmalloc + strcpy.
1945 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1946 growing it.
1947 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1948 alloca of a constant.
1949
6dd5a677
EZ
19502012-07-05 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1953 hscroll is larger than the line width. Fixes long and futile
1954 looping inside extend_face_to_end_of_line (on a TTY) producing
1955 glyphs that are not needed and thrown away.
1956
6b312f0f
DA
19572012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1958
1959 * marker.c (set_marker_restricted_both): Simplify by using
1960 clip_to_bounds.
1961
f520ef9b
PE
19622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1965
383b7c95
JD
19662012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1969 not defined (Bug#11768).
1970 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1971 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1972 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1973 followed by gtk_box_set_homogeneous (Bug#11768).
1974 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1975 (update_theme_scrollbar_width, xg_create_scroll_bar):
1976 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1977 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1978 (is_box_type): New function (Bug#11768).
1979 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1980 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1981 with default display (Bug#11768).
1982
d6e7bf45
EZ
19832012-07-05 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (window_hscroll_limited): New function.
1986 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1987 coordinates when window's hscroll is set to insanely large
1988 values. (Bug#11857)
1989
431391ec
JB
19902012-07-05 Juanma Barranquero <lekktu@gmail.com>
1991
1992 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1993 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1994
23f86fce
DA
19952012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 Cleanup xmalloc.
1998 * lisp.h (xzalloc): New prototype. Omit needless casts.
1999 * alloc.c (xzalloc): New function. Omit needless casts.
2000 * charset.c: Omit needless casts. Convert all calls to
2001 xmalloc with following memset to xzalloc.
2002 * dispnew.c: Likewise.
2003 * fringe.c: Likewise.
2004 * image.c: Likewise.
2005 * sound.c: Likewise.
2006 * term.c: Likewise.
2007 * w32fns.c: Likewise.
2008 * w32font.c: Likewise.
2009 * w32term.c: Likewise.
2010 * xfaces.c: Likewise.
2011 * xfns.c: Likewise.
2012 * xterm.c: Likewise.
2013 * atimer.c: Omit needless casts.
2014 * buffer.c: Likewise.
2015 * callproc.c: Likewise.
2016 * ccl.c: Likewise.
2017 * coding.c: Likewise.
2018 * composite.c: Likewise.
2019 * doc.c: Likewise.
2020 * doprnt.c: Likewise.
2021 * editfns.c: Likewise.
2022 * emacs.c: Likewise.
2023 * eval.c: Likewise.
2024 * filelock.c: Likewise.
2025 * fns.c: Likewise.
2026 * gtkutil.c: Likewise.
2027 * keyboard.c: Likewise.
2028 * lisp.h: Likewise.
2029 * lread.c: Likewise.
2030 * minibuf.c: Likewise.
2031 * msdos.c: Likewise.
2032 * print.c: Likewise.
2033 * process.c: Likewise.
2034 * region-cache.c: Likewise.
2035 * search.c: Likewise.
2036 * sysdep.c: Likewise.
2037 * termcap.c: Likewise.
2038 * terminal.c: Likewise.
2039 * tparam.c: Likewise.
2040 * w16select.c: Likewise.
2041 * w32.c: Likewise.
2042 * w32reg.c: Likewise.
2043 * w32select.c: Likewise.
2044 * w32uniscribe.c: Likewise.
2045 * widget.c: Likewise.
2046 * xdisp.c: Likewise.
2047 * xmenu.c: Likewise.
2048 * xrdb.c: Likewise.
2049 * xselect.c: Likewise.
2050
0497dc44
PE
20512012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 * fileio.c (time_error_value): Check the right error number.
2054 Problem reported by Troels Nielsen in
2055 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2056
356e7178
PE
20572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2058
4e71fd89
PE
2059 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2060 This should be fixed in a better way; see Eli Zaretskii in
2061 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2062 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2063
f0941253
PE
2064 * fileio.c (time_error_value): Rename from special_mtime.
2065 The old name's problems were noted by Eli Zaretskii in
2066 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2067
065c9eb4
PE
2068 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2069 This variable's comment says Emacs needs at least one GDB-visible
2070 symbol of type enum pvec_type, to work around GDB problems.
2071 The symbol's value doesn't matter.
2072
356e7178
PE
2073 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2074 that causes compilation to fail on pre-C99 compilers.
2075
ed9265fc 20762012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2077
2078 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2079 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2080
3884d954
DA
20812012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2082
d209e2fb 2083 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2084 headers for buffer_defaults and buffer_local_symbols.
2085 Reported by Juanma Barranquero <lekktu@gmail.com>.
2086
ee28be33
SM
20872012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2090 * lisp.h (enum pvec_type): Use fewer bits.
2091 (PSEUDOVECTOR_SIZE_BITS): New constant.
2092 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2093 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2094 change in pvec_type.
2095 (PSEUDOVECTOR_TYPEP): New macro.
2096 (TYPED_PSEUDOVECTORP): Use it.
2097 * fns.c (internal_equal): Adapt code to extract pvectype.
2098 * emacs.c (gdb_pvec_type): Update type.
2099 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2100 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2101 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2102 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2103 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2104 abusing vector->header.next.nbytes.
2105 (live_vector_p): Use PVEC_TYPE.
2106 (mark_object): Adapt code to extract pvectype. Use switch.
2107
c7f2cd7f
PE
21082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2111 Tighten new eassert a bit.
2112
8ce70ed2
DA
21132012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2114
2115 Fix compilation with --enable-gcc-warnings and -O1
2116 optimization level.
2117 * doprnt.c (doprnt): Change type of tem to int, initialize
2118 to avoid compiler warning. Add eassert.
2119 * search.c (simple_search): Initialize match_byte to avoid
2120 compiler warning. Add eassert.
2121
dea7f1e5
PE
21222012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2123
24a212eb
PE
2124 Avoid weird behavior with large horizontal scrolls.
2125 Without this change, for example, large hscroll values would
2126 mess up Emacs's display on Fedora 15 x86, presumably due to
2127 overflows in int calculations in the display code.
2128 Also, if buffers had long lines, Emacs would freeze.
2129 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2130 (set_window_hscroll): New function, containing the old guts of
2131 Fset_window_hscroll. Return the clipped value.
2132 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2133 This avoids the need to check against PTRDIFF_MAX.
2134
dea7f1e5
PE
2135 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2136
76046526
DA
21372012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2138
2139 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2140
39adff0d
PE
21412012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2142
63807d47
PE
2143 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2144 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2145 since GCC 4.4.6 issues a bogus warning for them.
2146
39adff0d
PE
2147 Fix bugs in file timestamp newness comparisons.
2148 * fileio.c (Ffile_newer_than_file_p):
2149 * lread.c (Fload): Use full timestamp resolution of files,
2150 not just the 1-second resolution, so that files that are only
2151 slightly newer still count as newer.
2152 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2153 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2154
dbeed9a6
PE
21552012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 * fileio.c: Improve handling of file time marker. (Bug#11852)
2158 (special_mtime): New function.
2159 (Finsert_file_contents, Fverify_visited_file_modtime):
2160 Use it to set special mtime values consistently.
2161
636334d6
AS
21622012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2163
2164 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2165 marker for non-existing file. (Bug#11852)
2166
e2017fe2
GM
21672012-07-03 Glenn Morris <rgm@gnu.org>
2168
2169 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2170 and did not make it into globals.h).
2171
404dbd37
TT
21722012-07-03 Tom Tromey <tromey@redhat.com>
2173
2174 * window.c (Fset_window_margins, Fset_window_fringes)
2175 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2176 * textprop.c (Fprevious_property_change): No longer static.
2177 * syntax.c (Fsyntax_table_p): No longer static.
2178 * process.c (Fget_process, Fprocess_datagram_address): No longer
2179 static.
2180 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2181 * keyboard.c (Fcommand_execute): No longer static.
2182 Remove EXFUN.
2183 * insdel.c (Fcombine_after_change_execute): No longer static.
2184 * image.c (Finit_image_library): No longer static.
2185 * fileio.c (Fmake_symbolic_link): No longer static.
2186 * eval.c (Ffetch_bytecode): No longer static.
2187 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2188 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2189 No longer static.
404dbd37
TT
2190 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2191 static.
2192 * dired.c (Ffile_attributes): No longer static.
2193 * composite.c (Fcomposition_get_gstring): No longer static.
2194 * callproc.c (Fgetenv_internal): No longer static.
2195
2196 * ccl.h: Remove EXFUNs.
2197 * buffer.h: Remove EXFUNs.
2198 * dispextern.h: Remove EXFUNs.
2199 * intervals.h: Remove EXFUNs.
2200 * fontset.h: Remove EXFUN.
2201 * font.h: Remove EXFUNs.
2202 * dosfns.c (system_process_attributes): Remove EXFUN.
2203 * keymap.h: Remove EXFUNs.
2204 * lisp.h: Remove EXFUNs.
2205 * w32term.h: Remove EXFUNs.
2206 * window.h: Remove EXFUNs.
2207 * xsettings.h: Remove EXFUN.
2208 * xterm.h: Remove EXFUN.
2209
8e4fd1e1
GM
22102012-07-03 Glenn Morris <rgm@gnu.org>
2211
2212 * lisp.h (Frandom): Make it visible to C.
2213 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2214 buffer for invisible buffers. (Bug#1229)
2215
ca95b3eb
DA
22162012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2217
2218 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2219 values which aren't power of 2.
2220 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2221 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2222 accordingly.
2223
7555c33f
SM
22242012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2225
2226 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2227
2228 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2229
d12e8f5a
DA
22302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2231
2232 * alloc.c (allocate_vector_block): Remove redundant
2233 calls to mallopt if DOUG_LEA_MALLOC is defined.
2234 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2235 avoid calls to mallopt if zero_vector is returned.
2236
296094c3
DA
22372012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2238
2239 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2240 is enabled, avoid dereferencing NULL current_sblock if
2241 running undumped.
2242
36429c89
DA
22432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2244
2245 Cleanup basic buffer management.
2246 * buffer.h (struct buffer): Change layout to use generic vector
2247 marking code. Fix some comments. Change type of 'clip_changed'
2248 to bitfield. Remove unused #ifndef old.
2249 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2250 (GET_OVERLAYS_AT): Fix indentation.
2251 (for_each_per_buffer_object_at): New macro.
2252 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2253 (Fbuffer_local_variables): Use it.
2254 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2255 * alloc.c (allocate_buffer): Adjust to match new layout of
2256 struct buffer. Fix comment.
2257 (mark_overlay): New function.
2258 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2259 Lisp area of struct buffer.
2260 (mark_object): Use it. Adjust marking of misc objects
2261 and related comments.
2262
3b3e4cac
PE
22632012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2266 wrapper that is not needed because the wrapped code is a no-op (zero
2267 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2268 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2269
cf5c0175
DA
22702012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2271
2272 * alloc.c (mark_buffer): Simplify. Remove prototype.
2273 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2274 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2275 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2276 redundant calls to mark_vectorlike for bool vectors.
2277
ca26824c
GM
22782012-06-30 Glenn Morris <rgm@gnu.org>
2279
2e4c5312
GM
2280 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2281
ca26824c
GM
2282 * epaths.in (PATH_SITELOADSEARCH): New.
2283 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2284 This is rather than relying on --enable-locallisppath elements
2285 having "site-lisp" in their names. (Bug#10208#25, 11658)
2286
0d23c240
EZ
22872012-06-30 Eli Zaretskii <eliz@gnu.org>
2288
c9240d7a
EZ
2289 * w32proc.c (sys_select): Accept and ignore one more argument.
2290
2291 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2292
0d23c240 2293 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2294 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2295
2296 * sysdep.c: Don't include dos.h and dosfns.h.
2297
2298 * process.c (sys_select):
2299 * msdos.c (sys_select): Accept one more argument and ignore it.
2300
2301 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2302 adapt data types and code to that.
2303
2304 * dosfns.c:
2305 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2306 which clashes with the gnulib function of the same name.
2307
af5a5a98
AS
23082012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2309
c5e4379c
AS
2310 * font.c (font_style_to_value, font_style_symbolic)
2311 (font_prop_validate_style): Add type checks for values in
2312 font_style_table.
2313
af5a5a98
AS
2314 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2315 argument.
2316 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2317 uses.
2318
8d38f461
EZ
23192012-06-29 Eli Zaretskii <eliz@gnu.org>
2320
2e5a6631
EZ
2321 * xdisp.c (try_window_id): Undo last change.
2322
8d38f461
EZ
2323 * w32.c (getwd): Adjust commentary about startup_dir.
2324 (init_environment): Always call sys_access, even in non-MSVC
2325 builds. Don't chdir to the directory of the Emacs executable.
2326 This undoes code from 1997 which was justified by the need to
2327 "avoid conflicts when removing and renaming directories". But its
2328 downside was that every relative file name was being interpreted
2329 relative to the directory of the Emacs executable, which can never
2330 be TRT. In particular, it broke sys_access when called with
2331 relative file names.
2332 (sys_access): Map GetLastError to errno.
2333
2af3565e
DA
23342012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2335
2336 * window.h (struct window): Change type of 'fringes_outside_margins'
2337 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2338 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2339 Adjust comment.
2340 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2341 to ptrdiff_t.
2342
c8d3a25c 23432012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2344
c8d3a25c
GM
2345 * gnutls.c (emacs_gnutls_handshake):
2346 Add QUIT to make the loop interruptible.
57570cd3 2347
c8d3a25c 23482012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2349
c8d3a25c
GM
2350 * charset.c (init_charset): Make lack of etc/charsets fatal.
2351
3e984ee8
DA
23522012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2353
2354 * editfns.c (region_limit): Fix type mismatch.
2355
ef884f23
DA
23562012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2357
2358 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2359 undefined. Convert from xassert to eassert.
2360 * nsmenu.m: Convert from xassert to eassert.
2361 * nsterm.m: Likewise.
2362
7d7e0027
SM
23632012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2364
2365 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2366
aa754e6a
PE
23672012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 Avoid integer overflow on scroll-left and scroll-right.
2370 * window.c (HSCROLL_MAX): New macro.
2371 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2372 overflow when requested scroll falls outside ptrdiff_t range.
2373
80b00b08
DA
23742012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2375
2376 * window.h (struct window): Change type of 'hscroll',
2377 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2378 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2379 Adjust users accordingly.
2380 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2381 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2382 from EMACS_INT to ptrdiff_t.
2383 (make_window): Omit redundant initialization.
2384
62b2bcf6
JB
23852012-06-28 Juanma Barranquero <lekktu@gmail.com>
2386
2387 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2388
45942c7d
DA
23892012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2390
2391 * window.h (struct window): Change type of 'use_time' and
2392 'sequence_number' from Lisp_Object to int.
2393 * frame.c (make_frame): Adjust users accordingly.
2394 * print.c (print_object): Likewise.
2395 * window.c (select_window, Fwindow_use_time, make_parent_window)
2396 (make_window): Likewise.
2397
e509cfa6
DA
23982012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2399
2400 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2401 enabled with --enable-checking=[all,glyphs] configure option.
2402 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2403 adjust comments accordingly.
2404 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2405 undefined, adjust comments accordingly.
2406 * image.c: Likewise.
2407 * scroll.c: Likewise.
2408 * w32fns.c: Likewise.
2409 * w32term.c: Likewise.
2410 * xdisp.c: Likewise.
2411 * xfaces.c: Likewise.
2412 * xfns.c: Likewise.
2413 * xterm.c: Likewise.
2414
a54e2c05
DA
24152012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2416
2417 Generalize run-time debugging checks.
2418 * dispextern.h (XASSERTS): Remove.
2419 * fontset.c (xassert): Remove.
2420 Convert from xassert to eassert.
2421 * alloc.c: Convert from xassert to eassert.
2422 * bidi.c: Likewise.
2423 * dispnew.c: Likewise.
2424 * fns.c: Likewise.
2425 * fringe.c: Likewise.
2426 * ftfont.c: Likewise.
2427 * gtkutil.c: Likewise.
2428 * image.c: Likewise.
2429 * keyboard.c: Likewise.
2430 * menu.c: Likewise.
2431 * process.c: Likewise.
2432 * scroll.c: Likewise.
2433 * sound.c: Likewise.
2434 * term.c: Likewise.
2435 * w32console.c: Likewise.
2436 * w32fns.c: Likewise.
2437 * w32term.c: Likewise.
2438 * window.c: Likewise.
2439 * xdisp.c: Likewise.
2440 * xfaces.c: Likewise.
2441 * xfns.c: Likewise.
2442 * xselect.c: Likewise.
2443 * xterm.c: Likewise.
2444
1ec4b7b2
SM
24452012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2446
2447 * fns.c (maybe_resize_hash_table): Output message when growing the
2448 purify-hashtable.
2449
2014308a
DA
24502012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2451
2452 * alloc.c (allocate_string_data): Remove dead code.
2453 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2454 avoid GCC warning about unused macro.
2455
246155eb
DA
24562012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2457
2458 * alloc.c (allocate_string): Omit intervals initialization.
2459 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2460 as in make_pure_string and make_pure_c_string.
2461
43184b7b
DA
24622012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2463
d209e2fb 2464 * alloc.c (allocate_string): Fix last change.
43184b7b 2465
3fe6dd74
DA
24662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2467
d209e2fb 2468 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2469 to memset, add explicit initialization where appropriate.
2470
1ba6038a
GM
24712012-06-27 Glenn Morris <rgm@gnu.org>
2472
2473 * lisp.mk (lisp): Remove paths.elc.
2474
c89926a5
CY
24752012-06-27 Chong Yidong <cyd@gnu.org>
2476
2477 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2478
ed6b3510
JW
24792012-06-26 John Wiegley <johnw@newartisans.com>
2480
1ec4b7b2 2481 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2482 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2483
ed6b3510
JW
2484 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2485 when building with Clang.
2486
8edd4a2b
SM
24872012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2488
2489 * eval.c (Fapply): Allow calling it with a single argument.
2490
f6f62d1b
EZ
24912012-06-26 Eli Zaretskii <eliz@gnu.org>
2492
2493 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2494 _stricmp and _strnicmp.
2495 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2496
62efea5e
DA
24972012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2498
2499 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2500 allocated window.
2501 (allocate_process): Likewise for new process.
8edd4a2b 2502 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2503 (allocate_frame): Likewise.
2504 * frame.c (make_frame): Omit redundant initialization.
2505 * window.c (make_parent_window): Use memset.
2506 (make_window): Omit redundant initialization.
2507 * process.c (make_process): Omit redundant initialization.
2508 * terminal.c (create_terminal): Likewise.
2509
42997f4d
DA
25102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2511
2512 * term.c (delete_tty): Remove redundant call to memset.
2513
1130ecfc
DA
25142012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2515
2516 * alloc.c: Remove build_string.
2517 * lisp.h: Define build_string as static inline. This provides
2518 a better opportunity to optimize away calls to strlen when the
2519 function is called with compile-time constant argument.
2520 * image.c (imagemagick_error): Convert to build_string.
2521 * w32proc.c (sys_spawnve): Likewise.
2522 * xterm.c (x_term_init): Likewise.
2523
cf38a720
PE
25242012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2525
99027bdd
PE
2526 Use sprintf return value instead of invoking strlen on result.
2527 In the old days this wasn't portable, since some sprintf
2528 implementations returned char *. But they died out years ago and
2529 Emacs already assumes sprintf returns int.
2530 Similarly for float_to_string.
2531 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2532 * ccl.c (ccl_driver):
2533 * character.c (string_escape_byte8):
2534 * data.c (Fnumber_to_string):
2535 * doprnt.c (doprnt):
2536 * print.c (print_object):
2537 * xdisp.c (message_dolog):
2538 * xfns.c (syms_of_xfns):
2539 Use sprintf or float_to_string result to avoid need to call strlen.
2540 * data.c (Fnumber_to_string):
2541 Use make_unibyte_string, since the string must be ASCII.
2542 * lisp.h, print.c (float_to_string): Now returns int length.
2543 * term.c (produce_glyphless_glyph):
2544 Use sprintf result rather than recomputing it.
2545
cf38a720
PE
2546 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2547 * Makefile.in (ALL_CFLAGS):
2548 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2549 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2550
3511c784
DA
25512012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2552
0a08eb21 2553 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2554 strcasecmp if available.
2555 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2556
fb7da12e
AS
25572012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2558
2559 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2560 Avoid comma operator.
2561 * menu.c (push_submenu_start, push_submenu_end)
2562 (push_left_right_boundary, push_menu_pane): Likewise.
2563 * msdos.c (dos_rawgetc): Likewise.
2564
afa2ffd8
DA
25652012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2566
2567 * xfns.c (xic_create_fontsetname): Remove redundant calls
2568 to memset.
2569
b3b4476b
PE
25702012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2571
4495ff38
PE
2572 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2573 sprintf already null-terminates its output.
2574
b3b4476b
PE
2575 * xfns.c (x_window): Remove redundant cast.
2576
b00876c9
DA
25772012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2578
2579 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2580 `const char *' to `char *' to avoid compiler warning.
2581
d188e26b
PE
25822012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2583
885d1d74
PE
2584 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2585 instead of truncating it to 63 (admittedly a generous limit).
2586
d188e26b
PE
2587 * process.c: Fix spelling and caps in comments.
2588
e2f560b1
DN
25892012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2590
e86db54b 2591 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2592 * sysdep.c (setpgrp): Remove definition, not used in this file.
2593
7583a3a1
JB
25942012-06-24 Juanma Barranquero <lekktu@gmail.com>
2595
2596 * makefile.w32-in: Update dependencies.
2597
696056c2
EZ
25982012-06-24 Eli Zaretskii <eliz@gnu.org>
2599
2600 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2601 (SYSTIME_H): Add nt/inc/sys/time.h.
2602
2603 * systime.h [WINDOWSNT]: Include sys/time.h.
2604
2605 * s/ms-w32.h (struct timespec): Definition moved from
2606 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2607
845ca893
PE
26082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2611 * buffer.h (buffer_slot_type_mismatch):
2612 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2613 * eval.c (unwind_to_catch):
2614 * image.c (my_png_error, my_error_exit):
2615 * keyboard.c (quit_throw_to_read_char, user_error)
2616 (Fexit_recursive_edit, Fabort_recursive_edit):
2617 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2618 (wrong_type_argument, buffer_overflow, __executable_start)
2619 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2620 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2621 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2622 (fatal):
2623 (child_setup) [!DOS_NT]:
2624 * lread.c (end_of_file_error, invalid_syntax):
2625 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2626 * puresize.h (pure_write_error):
2627 * search.c (matcher_overflow):
2628 * sound.c (sound_perror, alsa_sound_perror):
2629 * sysdep.c, syssignal.h (croak):
2630 * term.c (maybe_fatal, vfatal):
2631 * textprop.c (text_read_only):
2632 * undo.c (user_error):
2633 * unexmacosx.c (unexec_error):
2634 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2635 Use _Noreturn rather than NO_RETURN.
2636 No need for separate decl merely because of _Noreturn.
2637 * sound.c (sound_warning, parse_sound):
2638 Remove unnecessary forward decls.
2639
f1dd8073
PE
26402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2643 * lisp.h (WAIT_READING_MAX): New macro.
2644 * dispnew.c (Fsleep_for, sit_for):
2645 * keyboard.c (kbd_buffer_get_event):
2646 * process.c (Faccept_process_output):
2647 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2648 This improves on the previous patch, which introduced a bug
2649 when time_t is unsigned and as wide as intmax_t.
2650 See <http://bugs.gnu.org/9000#51>.
2651
b82c1755
EZ
26522012-06-23 Eli Zaretskii <eliz@gnu.org>
2653
2654 * dispnew.c (sit_for, Fsleep_for):
2655 * keyboard.c (kbd_buffer_get_event):
2656 * process.c (Faccept_process_output): Avoid compiler warnings when
2657 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2658
ca300656
JB
26592012-06-23 Juanma Barranquero <lekktu@gmail.com>
2660
049ec95b
JB
2661 * makefile.w32-in: Update dependencies.
2662
ca300656
JB
2663 * w32.c (ltime): Add return type and declare static.
2664 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2665
db7b8d06
PE
26662012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2669 Privately reported by Herbert J. Skuhra.
2670 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2671 All uses changed.
2672 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2673 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2674
0bd8297f
EZ
26752012-06-23 Eli Zaretskii <eliz@gnu.org>
2676
96512555
EZ
2677 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2678 last argument of make_unibyte_string.
2679
0bd8297f
EZ
2680 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2681 language ID in the event parameters.
2682
2683 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2684 event.code, not the obscure "character set ID".
2685
63def6b6
CY
26862012-06-23 Chong Yidong <cyd@gnu.org>
2687
2688 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2689
e8a02204
EZ
26902012-06-23 Eli Zaretskii <eliz@gnu.org>
2691
388cdec0
EZ
2692 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2693 * w32.c (fdutimens): New function.
2694
2695 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2696
2697 * s/ms-w32.h (pselect): Redirect to sys_select.
2698
2699 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2700
e8a02204
EZ
2701 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2702 in the logic of incrementing and decrementing the value of
2703 use_relocatable_buffers.
2704
d054f3fb
PE
27052012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2708 Privately reported by Herbert J. Skuhra.
2709 [__FreeBSD__]: Remove "*/" typo after "#include".
2710 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2711 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2712 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2713 Don't assume EMACS_TIME and struct timeval are the same type.
2714
d35af63c
PE
27152012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 Support higher-resolution time stamps (Bug#9000).
2718 The time stamps are only nanosecond-resolution at the C level,
2719 since that's the best that any real-world system supports now.
2720 But they are picosecond-resolution at the Lisp level, as that's
2721 easy, and leaves room for future OS improvements.
2722
2723 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2724 (LIBES): Use it.
2725
2726 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2727 Don't get current time unless it's needed.
2728
2729 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2730 now provides it if it's absent.
2731 (start_atimer): Port to higher-res time stamps.
2732 Check for time stamp overflow. Don't get current time more
2733 often than is needed.
2734
2735 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2736 Include systime.h, not time.h.
2737 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2738
2739 * dired.c: Include stat-time.h.
2740 (Ffile-attributes): File times now have higher resolution.
2741
2742 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2743 (struct image): Timestamp now has higher resolution.
2744
2745 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2746 has at least microseconds now. All uses removed.
2747 (update_frame, update_single_window, update_window, update_frame_1)
2748 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2749
2750 * editfns.c (time_overflow): Now extern.
2751 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2752 (float-time, Fformat_time_string, Fcurrent_time_string)
2753 (Fcurrent_time_zone): Accept and generate higher-resolution
2754 time stamps.
2755 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2756 (decode_time_components, lisp_seconds_argument): New functions.
2757 (make_time): Now static.
2758 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2759 Report an error if the time is invalid, rather than having the caller
2760 do that.
2761
2762 * fileio.c: Include <stat-time.h>
2763 (Fcopy_file): Copy higher-resolution time stamps.
2764 Prefer to set the time stamp via a file descriptor if that works.
2765 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2766 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2767 (Fvisited_file_modtime, Fset_visited_file_modtime):
2768 Support higher-resolution time stamps.
2769
2770 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2771
2772 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2773
2774 * image.c (prepare_image_for_display, clear_image_cache)
2775 (lookup_image): Port to higer-resolution time stamps.
2776
2777 * keyboard.c (start_polling, bind_polling_period):
2778 Check for time stamp overflow.
2779 (read_char, kbd_buffer_get_event, timer_start_idle)
2780 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2781 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2782 Port to higher-resolution time stamps. Do not assume time_t is signed.
2783 (decode_timer): New function. Timers are now vectors of length 9,
2784 not 8, to accommodate the picosecond component.
2785 (timer_check_2): Use it.
2786
2787 * nsterm.m (select_timeout, timeval_subtract): Remove.
2788 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2789 as they're a bit more accurate and handle overflow better.
2790 (ns_select): Change prototype to be compatible with pselect.
2791 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2792 * nsterm.h (ns_select): Adjust prototype.
2793
2794 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2795 us-resolution time stamps.
2796 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2797
2798 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2799
2800 * lisp.h (time_overflow): New decl.
2801 (wait_reading_process_output): First arg is now intmax_t, not int,
2802 to accommodate larger waits.
2803
2804 * process.h (struct Lisp_Process.read_output_delay):
2805 Now counts nanoseconds, not microseconds.
2806 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2807 EMACS_HAS_USECS.
2808 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2809 (wait_reading_process_output):
2810 Port to ns-resolution time stamps.
2811 (Faccept_process_output, wait_reading_process_output):
2812 Check for time stamp overflow. Do not assume time_t is signed.
2813 (select_wrapper): Remove; we now use pselect.
2814 (Fprocess_attributes): Now generates ns-resolution time stamps.
2815
2816 * sysdep.c: Include utimens.h. Don't include utime.h
2817 or worry about struct utimbuf; gnulib does that for us now.
2818 (gettimeofday): Remove; gnulib provides a substitute.
2819 (make_timeval): New function.
2820 (set_file_times): Now sets ns-resolution time stamps.
2821 New arg FD; all uses changed.
2822 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2823 (system_process_attributes):
2824 Now returns ns-resolution time stamp. All uses changed.
2825 Check for time stamp overflow.
2826
2827 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2828 provides a substitute now.
2829
2830 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2831 since it guarantees struct timespec.
2832 (EMACS_TIME): Now struct timespec, so that we can support
2833 ns-resolution time stamps.
2834 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2835 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2836 (EMACS_USECS): Remove.
2837 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2838 so multiply the arg by 1000 before storing it.
2839 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2840 New macros.
2841 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2842 Port to ns-resolution time stamps.
2843 (EMACS_TIME_NEG_P): Remove; replaced by....
2844 (EMACS_TIME_SIGN): New macro.
2845 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2846 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2847 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2848 (make_timeval, make_lisp_time, decode_time_components): New decls.
2849 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2850 that it mishandled time_t overflow. You can't compare by subtracting!
2851 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2852 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2853
2854 * term.c: Include <sys/time.h>.
2855 (timeval_to_Time): New function, for proper overflow wraparound.
2856 (term_mouse_position, term_mouse_click): Use it.
2857
2858 * undo.c (record_first_change): Support higher-resolution time stamps
2859 in the undo buffer.
2860 (Fprimitive_undo): Use them when restoring time stamps.
2861
2862 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2863 (w32_get_internal_run_time):
2864 Port to higher-resolution Emacs time stamps.
2865 (ltime): Now accepts single 64-bit integer, as that's more convenient
2866 for callers.
2867
2868 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2869
2870 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2871 for compatibility with pselect. Support ns-resolution time stamps.
2872
2873 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2874
2875 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2876 Check for time stamp overflow, and support ns-resolution time stamps.
2877
2878 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2879 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2880 (timeval_subtract): Remove; no longer needed.
2881 (XTflash, XTring_bell, x_wait_for_event):
2882 Port to ns-resolution time stamps. Don't assume time_t is signed.
2883
b6a92dfe
CY
28842012-06-22 Chong Yidong <cyd@gnu.org>
2885
2886 * xdisp.c (x_consider_frame_title): Revert last change.
2887
d251c37c
EZ
28882012-06-22 Eli Zaretskii <eliz@gnu.org>
2889
2890 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2891 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2892 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2893 staticidx goes up to 1597 out of 1600 = 0x640.)
2894
f10deafb
PE
28952012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2898 Otherwise, the umask might be mistakenly 0 while handling input signals.
2899
ec6de1e2
SM
29002012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2901
2902 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2903
28be1ada
DA
29042012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2905
2906 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2907 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2908 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2909 access to `contents' member of Lisp_Vector objects with AREF and ASET
2910 where appropriate.
2911
c6bf3022
CY
29122012-06-19 Chong Yidong <cyd@gnu.org>
2913
2914 * frame.c (delete_frame): When selecting a frame on a different
2915 text terminal, do not alter the terminal's top-frame.
2916
2917 * xdisp.c (format_mode_line_unwind_data): Record the target
2918 frame's selected window and its terminal's top-frame.
2919 (unwind_format_mode_line): Restore them.
2920 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2921 Callers changed.
2922 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2923 since tty frames can be explicitly named.
2924 (prepare_menu_bars): Likewise.
2925
2926 * term.c (Ftty_top_frame): New function.
2927
defd4196
PE
29282012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 Port byte-code-meter to modern targets.
2931 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2932 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2933 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2934 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2935 (METER_1, METER_2): Simplify.
2936
1053a871
SM
29372012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2938
2939 * data.c (Fdefalias): Return `symbol' (bug#11686).
2940
b7e8d081
MR
29412012-06-18 Martin Rudalics <rudalics@gmx.at>
2942
2943 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2944 gets killed during executing of this function (Bug#11665).
2945 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2946 (Vkill_buffer_query_functions): In doc-string say that functions
2947 run by this hook should not change the current buffer.
2948
7ea2b339
PE
29492012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2950
2951 Fix recently-introduced process.c problems found by static checking.
2952 * process.c (write_queue_push, write_queue_pop, send_process):
2953 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2954 (write_queue_pop): Fix pointer signedness problem.
2955 (send_process): Remove unused local.
2956
96a313a1
CY
29572012-06-17 Chong Yidong <cyd@gnu.org>
2958
2959 * xdisp.c (redisplay_internal): No need to redisplay terminal
2960 frames that are not on top.
2961
20ca2e94
TN
29622012-06-17 Troels Nielsen <bn.troels@gmail.com>
2963
2964 * process.c (make_process): Initialize write_queue.
2965 (write_queue_push, write_queue_pop): New functions.
2966 (send_process): Use them to maintain correct ordering of process
2967 writes (Bug#10815).
2968
9a900ca9
PE
29692012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2970
310fbfa8
PE
2971 * lisp.h (eassert): Assume C89 or later.
2972 This removes the need for CHECK.
2973 (CHECK): Remove. Its comments about always evaluating its
2974 argument were confusing, as 'eassert' typically does not evaluate
2975 its argument.
2976
27bb1ca4
PE
2977 * coding.c (produce_chars): Use ptrdiff_t, not int.
2978
9a900ca9
PE
2979 * xterm.c (x_draw_underwave): Check for integer overflow.
2980 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2981
41b7f8bc 29822012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2983
2984 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2985 referenced (Bug#11583).
2986
9b0e3eba
AA
29872012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2988
2989 Implement wave-style variant of underlining.
2990 * dispextern.h (face_underline_type): New enum.
2991 (face): Add field for underline type.
2992 * nsterm.m (ns_draw_underwave): New function.
2993 (ns_draw_text_decoration): Use it.
2994 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2995 New functions.
2996 (x_draw_glyph_string): Use them.
2997 * xfaces.c (Qline, Qwave): New Lisp objects.
2998 (check_lface_attrs, merge_face_ref)
1053a871
SM
2999 (Finternal_set_lisp_face_attribute, realize_x_face):
3000 Handle wave-style underline face attributes.
9b0e3eba
AA
3001 * xterm.c (x_draw_underwave): New function.
3002 (x_draw_glyph_string): Use it.
3003
0fb52f11
JB
30042012-06-16 Juanma Barranquero <lekktu@gmail.com>
3005
3006 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3007 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3008 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3009 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3010 ($(BLD)/w32select.$(O)): Update dependencies.
3011
e5560ff7
AS
30122012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3013
3014 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3015 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3016 * character.c (_fetch_multibyte_char_p): Remove.
3017 * alloc.c: Include "character.h" before "buffer.h".
3018 * bidi.c: Likewise.
3019 * buffer.c: Likewise.
3020 * bytecode.c: Likewise.
3021 * callint.c: Likewise.
3022 * callproc.c: Likewise.
3023 * casefiddle.c: Likewise.
3024 * casetab.c: Likewise.
3025 * category.c: Likewise.
3026 * cmds.c: Likewise.
3027 * coding.c: Likewise.
3028 * composite.c: Likewise.
3029 * dired.c: Likewise.
3030 * dispnew.c: Likewise.
3031 * doc.c: Likewise.
3032 * dosfns.c: Likewise.
3033 * editfns.c: Likewise.
3034 * emacs.c: Likewise.
3035 * fileio.c: Likewise.
3036 * filelock.c: Likewise.
3037 * font.c: Likewise.
3038 * fontset.c: Likewise.
3039 * fringe.c: Likewise.
3040 * indent.c: Likewise.
3041 * insdel.c: Likewise.
3042 * intervals.c: Likewise.
3043 * keyboard.c: Likewise.
3044 * keymap.c: Likewise.
3045 * lread.c: Likewise.
3046 * macros.c: Likewise.
3047 * marker.c: Likewise.
3048 * minibuf.c: Likewise.
3049 * nsfns.m: Likewise.
3050 * nsmenu.m: Likewise.
3051 * print.c: Likewise.
3052 * process.c: Likewise.
3053 * regex.c: Likewise.
3054 * region-cache.c: Likewise.
3055 * search.c: Likewise.
3056 * syntax.c: Likewise.
3057 * term.c: Likewise.
3058 * textprop.c: Likewise.
3059 * undo.c: Likewise.
3060 * unexsol.c: Likewise.
3061 * w16select.c: Likewise.
3062 * w32fns.c: Likewise.
3063 * w32menu.c: Likewise.
3064 * window.c: Likewise.
3065 * xdisp.c: Likewise.
3066 * xfns.c: Likewise.
3067 * xmenu.c: Likewise.
3068 * xml.c: Likewise.
3069 * xselect.c: Likewise.
3070
2f07e6af
EZ
30712012-06-16 Eli Zaretskii <eliz@gnu.org>
3072
1053a871
SM
3073 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3074 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3075 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3076 row.
3077 (handle_face_prop): Use chunk-relative overlay string index when
3078 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3079 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3080 the rightmost. (Bug#11720)
2f07e6af 3081
29b83cec
AS
30822012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3083
3084 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3085 (CATEGORY_MEMBER): Enforce 1/0 value.
3086 * category.c (_temp_category_set): Remove.
3087
4c5501e9
EZ
30882012-06-16 Eli Zaretskii <eliz@gnu.org>
3089
3090 * window.c (Fdelete_other_windows_internal)
3091 (Fdelete_window_internal): Don't access frame's mouse highlight
3092 info of the initial frame. (Bug#11677)
3093
2b570124
PE
30942012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3095
e93864f9
PE
3096 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3097 Assume USE_2_TAGS_FOR_INTS.
3098 (xreload): Adjust $tagmask width to match recent lisp.h change.
3099
2b570124
PE
3100 Simplify lisp.h in minor ways that should not affect code.
3101 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3102 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3103 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3104 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3105 (INTTYPEBITS): New macro, for clarity.
3106 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3107 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3108 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3109 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3110 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3111
81755f69
JB
31122012-06-13 Juanma Barranquero <lekktu@gmail.com>
3113
3114 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3115
16192a57
GM
31162012-06-13 Glenn Morris <rgm@gnu.org>
3117
3118 * s/bsd-common.h (BSD4_3):
3119 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3120
646b5f55
AS
31212012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3122
3123 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3124 instead of union.
3125 (XLI, XIL): Define.
1053a871
SM
3126 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3127 Use them.
3128 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3129 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3130 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3131 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3132 * frame.c (delete_frame): Remove outdated comment.
3133 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3134 USE_LISP_UNION_TYPE.
3135 (Fw32_unregister_hot_key): Likewise.
3136 (Fw32_toggle_lock_key): Likewise.
3137 * w32menu.c (add_menu_item): Likewise.
3138 (w32_menu_display_help): Use XIL instead of checking
3139 USE_LISP_UNION_TYPE.
3140 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3141 (init_heap): Likewise.
3142 * w32term.c (w32_read_socket): Update comment.
3143
1d3823c9
GM
31442012-06-13 Glenn Morris <rgm@gnu.org>
3145
c62ff706
GM
3146 * s/usg5-4-common.h, src/s/unixware.h:
3147 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3148
1d3823c9
GM
3149 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3150
bfe3e0a2
PE
31512012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3154 * alloc.c (make_number) [!defined make_number]:
3155 Remove, as lisp.h always defines this now.
3156 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3157 (roundup_size): Verify that it is a power of 2.
3158 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3159 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3160 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3161 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3162 USE_LSB_TAG now is always defined to be either 0 or 1.
3163 All uses changed.
3164 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3165 code works fine either way, and efficiency is not a concern here,
3166 as the union type is for debugging, not for production.
3167 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3168 Use an inline function on all platforms when using the union type,
3169 since this is simpler and 'static inline' can be used portably
3170 within Emacs now.
3171 (LISP_INITIALLY_ZERO): New macro.
3172 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3173 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3174
45fa9c0f
GM
31752012-06-12 Glenn Morris <rgm@gnu.org>
3176
b4492cba
GM
3177 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3178
3179 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3180
45fa9c0f
GM
3181 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3182 Move BROKEN_SIGIO to configure.
3183
3184 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3185 Move NO_TERMIO to configure.
3186
0e25d334
CY
31872012-06-12 Chong Yidong <cyd@gnu.org>
3188
3189 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3190 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3191 MagickExportImagePixels is undefined.
3192
43682bb6
PE
31932012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3194
3195 * image.c (imagemagick_load_image): Remove unused label.
3196
a9be7d2b
GM
31972012-06-11 Glenn Morris <rgm@gnu.org>
3198
3199 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3200 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3201 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3202 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3203
3017f87f
SM
32042012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3205
3206 * alloc.c (make_byte_code): New function.
3207 (Fmake_byte_code): Use it. Don't purify here.
3208 * lread.c (read1): Use it as well to avoid extra allocation.
3209
1b9b4cf4
CY
32102012-06-11 Chong Yidong <cyd@gnu.org>
3211
3212 * image.c (imagemagick_load_image): Implement transparency.
3213
95988fcf
AS
32142012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3215
3216 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3217 account for preceding backslashes. (Bug#11663)
3218
cd4eb164
CY
32192012-06-09 Chong Yidong <cyd@gnu.org>
3220
3221 * term.c: Support italics in capable terminals (Bug#9652).
3222 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3223 (turn_on_face): Output using TS_enter_italic_mode if available.
3224 Don't handle unused blinking and alt-charset cases.
3225 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3226 and tty_alt_charset_p cases.
3227 (tty_capable_p, init_tty): Support italics.
3228
3229 * termchar.h (struct tty_display_info): Add field for italics.
3230 Remove unused blink field.
3231
3232 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3233 Handle slant.
3234
3235 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3236 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3237 tty_alt_charset_p. Add tty_italic_p.
3238
ff88beb8
MA
32392012-06-09 Michael Albinus <michael.albinus@gmx.de>
3240
3241 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3242 dbus_type_is_basic if available.
3243 (xd_extract_signed, xd_extract_unsigned): Rename from
3244 extract_signed and extract_unsigned, respectively. Adapt callers.
3245
44286096
CY
32462012-06-09 Chong Yidong <cyd@gnu.org>
3247
1682701f
CY
3248 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3249
44286096
CY
3250 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3251 case (Bug#9752).
3252
d86feb17
PE
32532012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3254
3255 * xdisp.c (vmessage): Treat frame message as multibyte.
3256 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3257 would generate the diagnostic "Making \302\247 buffer-local while
3258 let-bound!".
3259
d5c20fe8
EZ
32602012-06-08 Eli Zaretskii <eliz@gnu.org>
3261
3262 * dispnew.c (showing_window_margins_p): Undo last change, which
3263 was done due to an inadvertent commit.
3264 (adjust_frame_glyphs_for_frame_redisplay): Do call
3265 showing_window_margins_p.
3266
513749ee
SM
32672012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3268
3269 * eval.c (Fmake_var_non_special): New primitive.
3270 (syms_of_eval): Defsubr it.
3271 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3272
d4a8f5c1
JB
32732012-06-08 Juanma Barranquero <lekktu@gmail.com>
3274
3275 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3276 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3277
8bbbc977
EZ
32782012-06-08 Eli Zaretskii <eliz@gnu.org>
3279
3280 * alloc.c (allocate_vectorlike): Fix last change.
3281
f3372c87
DA
32822012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3283
3284 Block-based vector allocation of small vectors.
3285 * lisp.h (struct vectorlike_header): New field `nbytes',
3286 adjust comment accordingly.
3287 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3288 to denote vector blocks. Adjust users (live_vector_p,
3289 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3290 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3291 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3292 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3293 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3294 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3295 (roundup_size): New constant.
3296 (struct vector_block): New data type.
3297 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3298 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3299 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3300 (sweep_vectors): New functions.
3301 (allocate_vectorlike): Return `zero_vector' as the only vector of
3302 0 items. Allocate new vector from block if vector size is less than
3303 or equal to VBLOCK_BYTES_MAX.
3304 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3305 (init_alloc_once): Add call to init_vectors.
3306
4f18a4ed
SM
33072012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3308
3309 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3310
86f158bc
PE
33112012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 * doprnt.c (doprnt): Truncate multibyte char correctly.
3314 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3315 would mishandle a string argument "Xc" if X was a multibyte
3316 character of length 2: it would truncate after X's first byte
3317 rather than including all of X.
3318
c5cfcbe0
CY
33192012-06-06 Chong Yidong <cyd@gnu.org>
3320
3321 * buffer.c (word_wrap): Doc fix.
3322
c05cf390
PE
33232012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3326
0c3461de
GM
33272012-06-03 Glenn Morris <rgm@gnu.org>
3328
3329 * xdisp.c (tool-bar-style): Doc fix.
3330
c71232db
UM
33312012-06-03 Ulrich Müller <ulm@gentoo.org>
3332
3333 * Makefile.in (PAXCTL): Define.
3334 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3335 binary via PaX flags if the paxctl utility is available.
3336 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3337 Restore PaX flags to their default. (Bug#11398)
3338
383f7350
CY
33392012-06-03 Chong Yidong <cyd@gnu.org>
3340
3341 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3342 buffer (Bug#11226).
3343
5f2c76c6
CY
33442012-06-03 Chong Yidong <cyd@gnu.org>
3345
3346 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3347 (note_mode_line_or_margin_highlight): If there is no help echo,
3348 use mode-line-default-help-echo. Handle the case where the mouse
3349 position is past the end of the mode line string.
3350
3351 * buffer.c (buffer_local_value_1): New function, split from
3352 Fbuffer_local_value; can return Qunbound.
3353 (Fbuffer_local_value): Use it.
3354 (Vmode_line_format): Docstring tweaks.
3355
773d47f6
PE
33562012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3357
3358 * sysdep.c (system_process_attributes): Improve comment.
3359
f2d6a3df
SM
33602012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3361
3362 * keyboard.c: Export real-this-command to Elisp.
3363 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3364 and DEFVAR it. Update all users.
3365
63810350
PE
33662012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3367
7bd5c1f4
PE
3368 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3369
63810350
PE
3370 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3371 Convert pctcpu and pctmem to Lisp float properly.
3372 Let the compiler fold better, as 100.0/0x8000 is exact.
3373
a2821611
AS
33742012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3375
3376 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3377 cons_block.
3378
5fceba1d
PE
33792012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3380
3381 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3382
c98ff5dd
DA
33832012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3384
3385 For a 'struct window', replace some Lisp_Object fields to
3386 bitfields where appropriate, remove unused fields.
3387 * window.h (struct window): Remove unused 'last_mark_x' and
3388 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3389 change it's type from Lisp_Object to bitfield.
3390 Change type of 'force_start', 'optional_new_start',
3391 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3392 fields from Lisp_Object to bitfield. Adjust users accordingly.
3393
ca34e0be
PE
33942012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3395
3396 Pacify gcc -Wdouble-precision when using Xaw.
3397 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3398 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3399 Use 'float' consistently, rather than 'float' in most places
3400 and 'double' in a couple of places.
3401
efc00ab1 34022012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3403
3404 * xdisp.c (handle_stop): Detect whether we have overlay strings
3405 loaded by testing it->current.overlay_string_index to be
3406 non-negative, instead of checking whether n_overlay_strings is
3407 positive. (Bug#11587)
3408
efc00ab1 34092012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3410
3411 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3412
3413 * doc.c (Fsubstitute_command_keys): Doc fix.
3414
efc00ab1 34152012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3416
3417 * search.c (search_buffer): Remove calls to
3418 r_alloc_inhibit_buffer_relocation, as it is now called by
3419 maybe_unify_char, which was the cause of relocation of buffer text
3420 in bug#11519.
3421
efc00ab1 34222012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3423
3424 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3425 for the duration of call to load_charset, to avoid problems with
3426 callers of maybe_unify_char that access buffer text through C
3427 pointers.
3428
3429 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3430 decrement the inhibition flag, instead of just setting or
3431 resetting it.
3432
ba93a187
PE
34332012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3434
3435 Remove obsolete '#define static' cruft.
3436 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3437 This #undef was "temporary" in 2000; it is no longer needed
3438 now that '#define static' has gone away.
3439 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3440 (gray_bitmap_bits): Remove; no longer needed.
3441 All uses replaced with definiens.
3442 * xterm.c: Include "bitmaps/gray.xbm".
3443
9e4bf381
PE
34442012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3445
3446 Clean up __executable_start, monstartup when --enable-profiling.
3447 The following changes affect the code only when profiling.
3448 * dispnew.c (__executable_start): Rename from safe_bcopy.
3449 Define only on platforms that need it.
3450 * emacs.c: Include <sys/gmon.h> when profiling.
3451 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3452 (__executable_start): Remove decl, since lisp.h does it now.
3453 (safe_bcopy): Remove decl; no longer has that name.
3454 (main): Coalesce #if into single bit of code, for simplicity.
3455 Cast pointers to uintptr_t, since standard libraries want integers
3456 and not pointers.
3457 * lisp.h (__executable_start): New decl.
3458
32d72c2f
GM
34592012-05-31 Glenn Morris <rgm@gnu.org>
3460
3461 * image.c (Fimagemagick_types): Doc fix.
3462
baac5bc7
JM
34632012-05-30 Jim Meyering <meyering@redhat.com>
3464
3465 * callproc.c (Fcall_process_region): Include directory component
3466 in mkstemp error message (Bug#11586).
3467
72cb32cf
PE
34682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3469
3470 * alloc.c, lisp.h (make_pure_vector): Now static.
3471
61b108cc
SM
34722012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3473
3474 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3475 Move to byte-run.el.
3476 (Fautoload): Do the hash-doc more carefully.
3477 * data.c (Fdefalias): Purify definition, except for keymaps.
3478 (Qdefun): Move from eval.c.
3479 * lisp.h (Qdefun): Remove.
3480 * lread.c (read1): Tiny simplification.
3481
471fe23d
TN
34822012-05-29 Troels Nielsen <bn.troels@gmail.com>
3483
934f3f58 3484 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3485 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3486 Bug#9642, but explicitly check that the buffer the overlay would
3487 be moved to is live and rearrange lines to make sure that errors
3488 will not put the overlay in an inconsistent state.
3489 (Fdelete_overlay): Cosmetics.
3490
85d0efd1
EZ
34912012-05-28 Eli Zaretskii <eliz@gnu.org>
3492
3493 * w32term.c (my_bring_window_to_top): New function.
3494 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3495 could be different from the original one.
3496 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3497 (Bug#11513)
3498
3499 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3500 by calling BringWindowToTop.
3501
3502 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3503 (WM_EMACS_END): Increase by one.
3504
da92a98c
PE
35052012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3508 This avoids undefined behavior that might cause the eassert
3509 to not catch an out-of-range value.
3510
74d1f848
JB
35112012-05-28 Juanma Barranquero <lekktu@gmail.com>
3512
3513 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3514 Update dependencies.
3515
9e1a06fc
EZ
35162012-05-27 Eli Zaretskii <eliz@gnu.org>
3517
3518 * bidi.c (bidi_mirror_char): Fix last change.
3519
f3dd7312
AS
35202012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3521
3522 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3523 when referring to sectname field in printf format.
3524
81899c91
PE
35252012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3526
57b81a9f
PE
3527 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3528 Only r_alloc_inhibit_buffer_relocation needed to be added;
3529 the others were already declared.
3530
81899c91
PE
3531 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3532 before checking whether it's out of range. Put the check inside
3533 eassert. See
3534 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3535
33017faf 35362012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3537
3538 * callproc.c (Fcall_process): Restore a line that was accidentally
3539 commented out in the 2011-02-13 change (bug#11547).
3540
33017faf 35412012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3542
3543 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3544 defined on ralloc.c.
3545
3546 * buffer.c [REL_ALLOC]: Remove prototypes of
3547 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3548 they are now on lisp.h.
3549
3550 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3551
3552 * search.c (search_buffer): Use it to inhibit relocation of buffer
3553 text while re_search_2 is doing its job, because re_search_2 is
3554 passed C pointers to buffer text. (Bug#11519)
3555
23415acf
EZ
3556 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3557 Update value to 24.
3558
44e27368
EZ
3559 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3560 state after an additional call to move_it_in_display_line_to, keep
3561 the values of it->max_ascent and it->max_descent found for the
3562 entire line.
3563 (pos_visible_p): Revert the comparison against bottom_y to what it
3564 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3565 (Bug#11464)
3566
c1892f11
PE
35672012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3568
3569 Fix coding-related core dumps with gcc -ftrapv.
3570 The code was computing A - B, where A and B are pointers, and B is
3571 random garbage. This can lead to core dumps on platforms that
3572 have special pointer registers, and it also leads to core dumps on
3573 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3574 A - B only when B is initialized properly.
3575 * coding.c (coding_set_source, coding_set_destination): Return void.
3576 (coding_change_source, coding_change_destinations): New functions,
3577 with the old behaviors of coding_set_source and coding_set_destination.
3578 All callers that need an offset changed to use these new functions.
3579
eb7afdad
GM
35802012-05-26 Glenn Morris <rgm@gnu.org>
3581
3582 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3583
f12fdf02
EZ
35842012-05-26 Eli Zaretskii <eliz@gnu.org>
3585
53a63be6 3586 Extend mouse support on W32 text-mode console.
61b108cc
SM
3587 * xdisp.c (draw_row_with_mouse_face):
3588 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3589
eb3f6f01 3590 * w32console.c: Include window.h.
61b108cc
SM
3591 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3592 New functions.
eb3f6f01
EZ
3593 (initialize_w32_display): Initialize mouse-highlight data.
3594
53a63be6
EZ
3595 * w32inevt.c: Include termchar.h and window.h.
3596 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3597 moves, call note_mouse_highlight. If help_echo changed, call
3598 gen_help_event to produce help-echo message in the echo area.
3599 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3600 highlight info.
3601
4cfd81f6
PE
36022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 * lread.c (read1): Simplify slightly to avoid an overflow warning
3605 with GCC 4.7.0 on x86-64.
3606
4446092a
EZ
36072012-05-26 Eli Zaretskii <eliz@gnu.org>
3608
3609 * bidi.c (bidi_mirror_char): Revert last change: an int is
3610 definitely wide enough here.
3611
42b2a986 36122012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3613
42b2a986 3614 Fix integer width and related bugs (Bug#9874).
eb106a49 3615 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3616 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3617 (string_bytes, check_sblock, allocate_string_data):
3618 (compact_small_strings, Fmake_bool_vector, make_string)
3619 (make_unibyte_string, make_multibyte_string)
3620 (make_string_from_bytes, make_specified_string)
3621 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3622 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3623 (mark_vectorlike):
3624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3625 (allocate_pseudovector):
3626 Use int, not EMACS_INT, where int is wide enough.
3627 (inhibit_garbage_collection, Fgarbage_collect):
3628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3629 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3630 int might not be wide enough.
3631 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3632 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3633 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3634 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3635 (bidi_level_of_next_char, bidi_move_to_visually_next):
3636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3637 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3638 (Fkill_buffer, Fset_buffer_major_mode)
3639 (advance_to_char_boundary, Fbuffer_swap_text)
3640 (Fset_buffer_multibyte, overlays_at, overlays_in)
3641 (overlay_touches_p, struct sortvec, record_overlay_string)
3642 (overlay_strings, recenter_overlay_lists)
3643 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3644 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3645 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3646 (Foverlay_recenter, last_overlay_modification_hooks_used)
3647 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3649 (validate_region): Omit unnecessary test for b <= e,
3650 since that's guaranteed by the previous test.
d311d28c
PE
3651 (adjust_overlays_for_delete): Avoid pos + length overflow.
3652 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3653 (report_overlay_modification):
3654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3655 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3656 Omit pointer cast, which isn't needed anyway, and doesn't work
3657 after the EMACS_INT -> ptrdiff_t change.
02481186 3658 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3659 * buffer.h: Adjust decls to match defn changes elsewhere.
3660 (struct buffer_text, struct buffer):
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3662 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3663 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3664 not int, to avoid needless 32-bit limit on 64-bit hosts.
3665 (exec_byte_code): Use tighter memory-full test, one that checks
3666 for alloca overflow. Don't compute the address of the object just
3667 before an array, as that's not portable. Use EMACS_INT, not
3668 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3669 * callint.c (Fcall_interactively):
3670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3671 * callproc.c (call_process_kill, Fcall_process):
3672 Don't assume pid_t fits into an Emacs fixnum.
3673 (call_process_cleanup, Fcall_process, child_setup):
3674 Don't assume pid_t fits into int.
3675 (call_process_cleanup, Fcall_process, delete_temp_file)
3676 (Fcall_process_region):
3677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3678 (Fcall_process): Simplify handling of volatile integers.
3679 Use int, not EMACS_INT, where int will do.
3680 * casefiddle.c (casify_object, casify_region, operate_on_word)
3681 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3683 (casify_object): Avoid integer overflow when overallocating buffer.
3684 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3685 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3686 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3687 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3688 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3689 integers are now checked earlier. All uses replaced with XINT.
3690 (ccl_driver):
3691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3692 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3693 (ccl_driver, Fregister_code_conversion_map):
3694 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3695 (resolve_symbol_ccl_program): Check that vector header is in range.
3696 Always copy the vector, so that we can check its contents reliably
3697 now rather than having to recheck each instruction as it's being
3698 executed. Check that vector words fit in 'int'.
3699 (ccl_get_compiled_code, Fregister_ccl_program)
3700 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3701 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3702 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3703 contents are in range.
3704 (Fccl_execute_on_string): Check that status is in range.
3705 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3706 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3707 Accept and return EMACS_INT, not int, because callers can pass values
3708 out of 'int' range.
3709 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3710 (multibyte_chars_in_text, parse_str_as_multibyte)
3711 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3712 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3713 (string_escape_byte8, Fget_byte):
3714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3715 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3716 avoid mishandling large integers.
3717 * character.h: Adjust decls to match defn changes elsewhere.
3718 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3719 (Ffind_charset_region):
3720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3721 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3722 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3723 Don't assume fixnum fits in int.
d311d28c
PE
3724 (load_charset_map_from_vector, Fmap_charset_chars):
3725 Remove now-unnecessary CHECK_NATNUMs.
3726 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3727 Don't rely on undefined behavior with signed left shift overflow.
3728 Don't assume unsigned int fits into fixnum, or that fixnum fits
3729 into unsigned int. Don't require max_code to be a valid fixnum;
3730 that's not true for gb10830 4-byte on a 32-bit host. Allow
3731 invalid_code to be a cons, for the same reason. Require code_offset
3732 to be a character. Avoid int overflow if max_char is close
3733 to INT_MAX.
3734 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3735 this is intended anyway and avoids some undefined behavior.
3736 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3737 INDEX_TO_CODE_POINT, as that's what it expects.
3738 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3739 * charset.h (DECODE_CHAR): Return int, not unsigned;
3740 this is what was intended anyway, and it avoids undefined behavior.
3741 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3742 integer-overflow issues.
3743 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3744 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3745 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3746 * chartab.c (Fmake_char_table, Fset_char_table_range)
3747 (uniprop_get_decoder, uniprop_get_encoder):
3748 Don't assume fixnum fits in int.
3749 * cmds.c (move_point): New function, that does the gist of
3750 Fforward_char and Fbackward_char, but does so while checking
3751 for integer overflow more accurately.
c96e5d6a 3752 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3753 (Fforward_line, Fend_of_line, internal_self_insert)
3754 (internal_self_insert):
3755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3756 Fix a FIXME, by checking for integer overflow when calculating
3757 target_clm and actual_clm.
3758 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3759 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3760 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3761 (coding_alloc_by_making_gap, alloc_destination)
3762 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3763 (encode_coding_utf_16, detect_coding_emacs_mule)
3764 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3765 (detect_coding_iso_2022, decode_coding_iso_2022)
3766 (encode_invocation_designation, encode_designation_at_bol)
3767 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3768 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3769 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3770 (encode_coding_ccl, encode_coding_raw_text)
3771 (detect_coding_charset, decode_coding_charset)
3772 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3773 (produce_composition, produce_charset, produce_annotation)
3774 (decode_coding, handle_composition_annotation)
3775 (handle_charset_annotation, consume_chars, decode_coding_gap)
3776 (decode_coding_object, encode_coding_object, detect_coding_system)
3777 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3778 (code_convert_region, code_convert_string)
8f50130c
PE
3779 (Fdefine_coding_system_internal)
3780 (coding_set_source, coding_set_destination):
d311d28c
PE
3781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3782 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3783 (Fdefine_coding_system_internal):
3784 Don't assume fixnums fit in int.
3785 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3786 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3787 (Funencodable_char_position, Fcheck_coding_systems_region)
3788 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3790 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3791 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3792 Don't access memory outside of the args array.
d311d28c 3793 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3794 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3795 result of ENCODE_CHAR.
d311d28c
PE
3796 * coding.h: Adjust decls to match defn changes elsewhere.
3797 (struct coding_system):
3798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3799 * composite.c (get_composition_id, find_composition)
3800 (run_composition_function, update_compositions)
3801 (compose_text, composition_gstring_put_cache)
3802 (composition_gstring_p, composition_gstring_width)
3803 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3804 (composition_compute_stop_pos, composition_reseat_it)
3805 (composition_update_it, struct position_record)
3806 (find_automatic_composition, composition_adjust_point)
3807 (Fcomposition_get_gstring, Ffind_composition_internal):
3808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3809 (update_compositions):
3810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3811 * composite.h: Adjust decls to match defn changes elsewhere.
3812 (struct composition):
3813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3814 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3815 Do not attempt to compute the address of the object just before a
3816 buffer; this is not portable.
3817 (Faref, Faset):
3818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3819 (Faset): Use int, not EMACS_INT, where int is wide enough.
3820 (Fstring_to_number): Don't assume fixnums fit in int.
3821 (Frem): Don't assume arg is nonnegative.
3822 * dbusbind.c (xd_append_arg): Check for integers out of range.
3823 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3824 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3825 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3826 (xd_get_connection_references): Return ptrdiff_t, not int.
3827 All uses changed.
3828 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3829 (xd_read_message_1):
3830 Use int, not unsigned, where the dbus API uses int.
3831 (Fdbus_message_internal): Don't overflow mtype.
3832 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3833 * dired.c (directory_files_internal, file_name_completion, scmp)
3834 (file_name_completion_stat):
3835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3836 (file_name_completion): Don't overflow matchcount.
3837 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3838 * dispextern.h: Adjust decls to match defn changes elsewhere.
3839 (struct text_pos, struct glyph, struct bidi_saved_info)
3840 (struct bidi_string_data, struct bidi_it, struct composition_it)
3841 (struct it):
3842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3843 (struct display_pos, struct composition_it, struct it):
3844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3845 * dispnew.c (increment_matrix_positions)
3846 (increment_row_positions, mode_line_string)
3847 (marginal_area_string):
3848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3849 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3851 (duration_to_sec_usec): New function, to check for overflow better.
3852 (Fsleep_for, sit_for): Use it.
3853 * doc.c (get_doc_string, store_function_docstring):
3854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3855 (get_doc_string, Fsnarf_documentation):
3856 Use int, not EMACS_INT, where int is wide enough.
3857 (get_doc_string):
3858 Use SAFE_ALLOCA, not alloca.
3859 Check for overflow when converting EMACS_INT to off_t.
3860 * doprnt.c (doprnt):
3861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3862 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3863 Don't assume uid_t fits into fixnum.
3864 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3865 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3866 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3867 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3868 (general_insert_function)
3869 (Finsert_char, make_buffer_string, make_buffer_string_both)
3870 (update_buffer_properties, Fbuffer_substring)
3871 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3872 (Fsubst_char_in_region, check_translation)
3873 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3874 (transpose_markers, Ftranspose_regions):
3875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3876 (clip_to_bounds): Move to lisp.h as an inline function).
3877 (Fconstrain_to_field): Don't assume integers are nonnegative.
3878 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3879 (Fsubst_char_in_region, Fsave_restriction):
3880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3881 (Femacs_pid): Don't assume pid_t fits into fixnum.
3882 (lo_time): Use int, not EMACS_INT, when int suffices.
3883 (lisp_time_argument): Check for usec out of range.
3884 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3885 (Fuser_login_name, Fuser_full_name): Signal an error
3886 if a uid argument is out of range, rather than relying on
3887 undefined behavior.
c8d5c857
PE
3888 (Fformat_time_string): Remove now-unnecessary check.
3889 lisp_time_argument checks for out-of-range usec now.
243e0530 3890 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3891 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3892 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3893 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3894 (init_cmdargs, Fdump_emacs):
3895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3896 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3897 the bottom (typically) 32 bits of the fixnum.
3898 * eval.c (specpdl_size, call_debugger):
3899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3900 (when_entered_debugger, Fbacktrace_debug):
3901 Don't assume fixnum can fit in int.
3902 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3903 the object just before a buffer; this is not portable.
3904 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3905 (grow_specpdl, unbind_to):
3906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3907 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3908 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3909 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3910 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3911 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3913 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3914 (a_write, e_write):
3915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3916 (Fcopy_file, non_regular_nbytes, read_non_regular)
3917 (Finsert_file_contents):
3918 Use int, not EMACS_INT, where int is wide enough.
3919 (READ_BUF_SIZE): Verify that it fits in int.
3920 (Finsert_file_contents): Check that counts are in proper range,
3921 rather than assuming fixnums fit into ptrdiff_t etc.
3922 Don't assume fixnums fit into int.
125b3835 3923 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3924 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3925 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3926 (string_char_to_byte, string_byte_to_char)
3927 (string_make_multibyte, string_to_multibyte)
3928 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3929 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3930 (substring_both, Fdelete, internal_equal, Ffillarray)
3931 (Fclear_string, mapcar1)
3932 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3933 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3934 (larger_vector, make_hash_table, maybe_resize_hash_table)
3935 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3936 (Fmaphash, secure_hash):
3937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3938 (concat): Check for string index and length overflow.
3939 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3940 (Frequire):
3941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3942 (larger_vector): New API (vec, incr_min, size_max) replaces old
3943 one (vec, new_size, init). This catches size overflow.
3944 INIT was removed because it was always Qnil.
3945 All callers changed.
3946 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3947 the upper bound on a hash table index size.
3948 (make_hash_table, maybe_resize_hash_table): Use it.
3949 (secure_hash): Computer start_byte and end_byte only after
3950 they're known to be in ptrdiff_t range.
3951 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3952 (Ffont_get_glyphs, Ffont_at):
3953 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3954 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3955 (Flist_fonts, Fopen_font):
3956 Don't assume fixnum can fit in int.
3957 (check_gstring): Don't assume index can fit in int.
3958 (font_match_p): Check that fixnum is a character, not a nonnegative
3959 fixnum, since the later code needs to stuff it into an int.
3960 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3961 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3962 conversion overflow issues.
3963 (Fopen_font): Check for integer out of range.
3964 (Ffont_get_glyphs): Don't assume index can fit in int.
3965 * font.h: Adjust decls to match defn changes elsewhere.
3966 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3967 integer overflow.
3968 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3969 printmax_t, where ptrdiff_t is wide enough.
3970 (Finternal_char_font):
3971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3972 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3973 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3974 (Fset_frame_position, x_set_frame_parameters)
3975 (x_set_line_spacing, x_set_border_width)
3976 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3977 Check that fixnums are in proper range for system types.
3978 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3980 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3981 Use SAFE_ALLOCA_LISP, not alloca.
3982 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3983 intptr_t is wide enough.
3984 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3985 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3986 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3987 Check for fixnum out of range.
3988 * ftfont.c (ftfont_list): Don't assume index fits in int.
3989 Check that fixnums are in proper range for system types.
3990 (ftfont_shape_by_flt):
3991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3992 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3994 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3995 Check that fixnums are in proper range for system types.
3996 * gnutls.h: Adjust decls to match defn changes elsewhere.
3997 * gtkutil.c (xg_dialog_run):
3998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3999 (update_frame_tool_bar):
4000 Check that fixnums are in proper range for system types.
4001 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4002 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4003 * indent.c (last_known_column, last_known_column_point):
4004 (current_column_bol_cache):
4005 (skip_invisible, current_column, check_display_width):
4006 (check_display_width, scan_for_column, current_column_1)
4007 (Findent_to, Fcurrent_indentation, position_indentation)
4008 (indented_beyond_p, Fmove_to_column, compute_motion):
4009 (Fcompute_motion, Fvertical_motion):
4010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4011 (last_known_column_modified): Use EMACS_INT, not int.
4012 (check_display_width):
4013 (Fcompute_motion):
4014 Check that fixnums and floats are in proper range for system types.
4015 (compute_motion): Don't assume index or fixnum fits in int.
4016 (compute_motion, Fcompute_motion):
4017 Use int, not EMACS_INT, when it is wide enough.
4018 (vmotion): Omit local var start_hpos that is always 0; that way
4019 we don't need to worry about overflow in expressions involving it.
4020 * indent.h: Adjust decls to match defn changes elsewhere.
4021 (struct position):
4022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4023 Use int, not EMACS_INT, where int is wide enough.
4024 Remove unused members ovstring_chars_done and tab_offset;
4025 all uses removed.
4026 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4027 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4028 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4029 (make_gap, copy_text, insert, insert_and_inherit)
4030 (insert_before_markers, insert_before_markers_and_inherit)
4031 (insert_1, count_combining_before, count_combining_after)
4032 (insert_1_both, insert_from_string)
4033 (insert_from_string_before_markers, insert_from_string_1)
4034 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4035 (adjust_after_replace, adjust_after_insert, replace_range)
4036 (replace_range_2, del_range, del_range_1, del_range_byte)
4037 (del_range_both, del_range_2, modify_region)
4038 (prepare_to_modify_buffer, signal_before_change)
4039 (signal_after_change, Fcombine_after_change_execute):
4040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4041 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4042 (balance_an_interval, split_interval_right, split_interval_left)
4043 (find_interval, next_interval, update_interval)
4044 (adjust_intervals_for_insertion, delete_node, delete_interval)
4045 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4046 (static_offset_intervals, offset_intervals)
4047 (merge_interval_right, merge_interval_left, make_new_interval)
4048 (graft_intervals_into_buffer, temp_set_point_both)
4049 (temp_set_point, set_point, adjust_for_invis_intang)
4050 (set_point_both, move_if_not_intangible, get_property_and_range)
4051 (get_local_map, copy_intervals, copy_intervals_to_string)
4052 (compare_string_intervals, set_intervals_multibyte_1):
4053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4054 * intervals.h: Adjust decls to match defn changes elsewhere.
4055 (struct interval):
4056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4057 * keyboard.c (this_command_key_count, this_single_command_key_start)
4058 (before_command_key_count, before_command_echo_length, echo_now)
4059 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4060 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4061 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4062 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4064 (last_non_minibuf_size, last_point_position, echo_truncate)
4065 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4066 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4067 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4068 (stuff_buffered_input):
4069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4070 (last_auto_save, command_loop_1, read_char):
4071 Use EMACS_INT, not int, to avoid integer overflow.
4072 (record_char): Avoid overflow in total_keys computation.
4073 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4074 * keyboard.h: Adjust decls to match defn changes elsewhere.
4075 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4076 (Fkey_description, Fdescribe_vector, Flookup_key):
4077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4078 (click_position): New function, to check that positions are in range.
4079 (Fcurrent_active_maps):
4080 (describe_command):
4081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4082 (Faccessible_keymaps, Fkey_description):
4083 (preferred_sequence_p):
4084 Don't assume fixnum can fit into int.
4085 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4086 Check for integer overflow in size calculations.
4087 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4088 avoid mishandling large integers.
4089 * lisp.h: Adjust decls to match defn changes elsewhere.
4090 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4091 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4092 (struct Lisp_Marker):
4093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4094 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4095 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4096 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4097 All callers changed.
4098 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4099 Assume the arg has valid form, since it always does.
4100 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4101 unsigned integer system type.
4102 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4103 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4105 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4106 (duration_to_sec_usec): New decl.
4107 * lread.c (read_from_string_index, read_from_string_index_byte)
4108 (read_from_string_limit, readchar, unreadchar, openp)
4109 (read_internal_start, read1, oblookup):
4110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4111 (Fload, readevalloop, Feval_buffer, Feval_region):
4112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4113 (openp): Check for out-of-range argument to 'access'.
4114 (read1): Use int, not EMACS_INT, where int is wide enough.
4115 Don't assume fixnum fits into int.
6efdadfd 4116 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4117 (read_filtered_event): Use duration_to_sec_usec
4118 to do proper overflow checking on durations.
d311d28c
PE
4119 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4120 in size calculation.
4121 (Fexecute_kbd_macro):
4122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4123 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4124 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4125 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4126 (set_marker_both, set_marker_restricted_both, marker_position)
4127 (marker_byte_position, Fbuffer_has_markers_at):
4128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4129 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4130 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4131 It now merely ensures that the menu is large enough, without
4132 necessarily growing it, as this avoids some integer overflow issues.
4133 All callers changed.
4134 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4136 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4137 Use SAFE_ALLOCA_LISP, not alloca.
4138 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4139 to EMACS_INT. Check that fixnums are in proper range for system types.
4140 * minibuf.c (minibuf_prompt_width, string_to_object)
4141 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4142 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4144 (get_minibuffer, read_minibuf_unwind):
4145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4146 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4147 this simplifies overflow checking. All callers changed.
4148 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4149 (Ftest_completion):
4150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4151 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4152 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4153 Check that fixnums are in proper range for system types.
4154 (Fx_create_frame, Fx_show_tip):
4155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4156 * nsfont.m (ns_findfonts, nsfont_list_family):
4157 Don't assume fixnum fits in long.
4158 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4160 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4161 wide enough.
17fdb222 4162 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4164 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4165 (PRINTDECLARE, PRINTPREPARE):
4166 (strout, print_string):
4167 (print, print_preprocess, print_check_string_charset_prop)
4168 (print_object):
4169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4170 (PRINTDECLARE):
4171 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4174 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4175 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4176 (print_error_message): Use SAFE_ALLOCA, not alloca.
4177 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4178 (print_depth, new_backquote_output, print_number_index):
4179 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4180 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4181 (Fset_process_window_size, Fformat_network_address)
4182 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4183 (sigchld_handler):
d311d28c 4184 Check that fixnums are in proper range for system types.
d44287d4 4185 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4186 Check for process-ids out of pid_t range rather than relying on
4187 undefined behavior.
e4d81efc 4188 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4189 (Fformat_network_address, read_process_output, send_process)
4190 (Fprocess_send_region, status_notify):
4191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4192 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4193 (wait_reading_process_output, read_process_output, exec_sentinel):
4194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4195 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4196 (Faccept_process_output): Use duration_to_sec_usec to do proper
4197 overflow checking on durations.
dde14581
PE
4198 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4199 Don't assume pid_t fits in int.
02481186
PE
4200 * process.h (struct Lisp_Process): Members tick and update_tick
4201 are now of type EMACS_INT, not int.
b62b53e8
PE
4202 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4203 configured --with-wide-int.
d311d28c
PE
4204 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4205 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4206 * search.c (looking_at_1, string_match_1):
4207 (fast_string_match, fast_c_string_match_ignore_case)
4208 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4209 (scan_newline, find_before_next_newline, search_command)
4210 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4211 (set_search_regs, wordify):
4212 (Freplace_match):
4213 (Fmatch_data):
4214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4215 (string_match_1, search_buffer, set_search_regs):
4216 (Fmatch_data):
4217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4218 (wordify): Check for overflow in size calculation.
4219 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4220 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4221 Check that fixnums are in proper range for system types.
4222 * sound.c (struct sound_device)
4223 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4225 (Fplay_sound_internal):
4226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4227 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4228 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4229 (Fparse_partial_sexp):
4230 Don't assume fixnums can fit in int.
4231 (struct lisp_parse_state, find_start_pos, find_start_value)
4232 (find_start_value_byte, find_start_begv)
4233 (update_syntax_table, char_quoted, dec_bytepos)
4234 (find_defun_start, prev_char_comend_first, back_comment):
4235 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4236 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4238 (Finternal_describe_syntax_value): Check that match_lisp is a
4239 character, not an integer, since the code stuffs it into int.
4240 (scan_words, scan_sexps_forward):
4241 Check that fixnums are in proper range for system types.
4242 (Fforward_word):
4243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4244 (scan_sexps_forward):
4245 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4246 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4247 * syntax.h: Adjust decls to match defn changes elsewhere.
4248 (struct gl_state_s):
4249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4250 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4251 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4252 * sysdep.c (wait_for_termination_1, wait_for_termination)
4253 (interruptible_wait_for_termination, mkdir):
4254 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4255 (emacs_read, emacs_write):
4256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4257 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4258 and double all fit in int.
d311d28c
PE
4259 * term.c (set_tty_color_mode):
4260 Check that fixnums are in proper range for system types.
4261 * termhooks.h (struct input_event):
4262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4263 * textprop.c (validate_interval_range, interval_of)
4264 (Fadd_text_properties, set_text_properties_1)
4265 (Fremove_text_properties, Fremove_list_of_text_properties)
4266 (Ftext_property_any, Ftext_property_not_all)
4267 (copy_text_properties, text_property_list, extend_property_ranges)
4268 (verify_interval_modification):
4269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4270 (Fnext_single_char_property_change)
4271 (Fprevious_single_char_property_change):
4272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4273 (copy_text_properties):
4274 Check for integer overflow in index calculation.
d311d28c
PE
4275 * undo.c (last_boundary_position, record_point, record_insert)
4276 (record_delete, record_marker_adjustment, record_change)
4277 (record_property_change):
4278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4279 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4281 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4282 (Fx_hide_tip, Fx_file_dialog):
4283 * w32menu.c (set_frame_menubar):
4284 Use ptrdiff_t, not int, for consistency with rest of code.
4285 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4286 (select_window, Fdelete_other_windows_internal)
4287 (window_scroll_pixel_based, window_scroll_line_based)
4288 (Frecenter, Fset_window_configuration):
4289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4290 (Fset_window_hscroll, run_window_configuration_change_hook)
4291 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4292 (Fscroll_other_window, Frecenter):
d311d28c
PE
4293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4294 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4295 Don't assume fixnum fits in int.
4296 (Fset_window_scroll_bars):
4297 Check that fixnums are in proper range for system types.
4298 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4299 (string_pos, c_string_pos, number_of_chars, init_iterator)
4300 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4301 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4302 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4303 (face_before_or_after_it_pos, handle_invisible_prop)
4304 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4305 (display_prop_intangible_p, string_buffer_position_lim)
4306 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4307 (get_overlay_strings_1, get_overlay_strings)
4308 (iterate_out_of_display_property, forward_to_next_line_start)
4309 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4310 (get_next_display_element, set_iterator_to_next)
4311 (get_visually_first_element, compute_stop_pos_backwards)
4312 (handle_stop_backwards, next_element_from_buffer)
4313 (move_it_in_display_line_to, move_it_in_display_line)
4314 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4315 (add_to_log, message_dolog, message_log_check_duplicate)
4316 (message2, message2_nolog, message3, message3_nolog
4317 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4318 (current_message_1, truncate_echo_area, truncate_message_1)
4319 (set_message, set_message_1, store_mode_line_noprop)
4320 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4321 (text_outside_line_unchanged_p, check_point_in_composition)
4322 (reconsider_clip_changes)
4323 (redisplay_internal, set_cursor_from_row, try_scrolling)
4324 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4325 (redisplay_window, find_last_unchanged_at_beg_row)
4326 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4327 (trailing_whitespace_p, find_row_edges, display_line)
4328 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4329 (display_mode_element, store_mode_line_string)
4330 (pint2str, pint2hrstr, decode_mode_spec)
4331 (display_count_lines, display_string, draw_glyphs)
4332 (x_produce_glyphs, x_insert_glyphs)
4333 (rows_from_pos_range, mouse_face_from_buffer_pos)
4334 (fast_find_string_pos, mouse_face_from_string_pos)
4335 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4337 (safe_call, init_from_display_pos, handle_fontified_prop)
4338 (handle_single_display_spec, load_overlay_strings)
4339 (with_echo_area_buffer, setup_echo_area_for_printing)
4340 (display_echo_area, echo_area_display)
4341 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4342 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4343 (redisplay_window, dump_glyph_row, display_mode_line)
4344 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4345 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4347 (handle_single_display_spec, build_desired_tool_bar_string)
4348 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4349 (get_specified_cursor_type):
4350 Check that fixnums are in proper range for system types.
4351 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4352 (Flookup_image_map):
4353 Don't assume fixnums fit in int.
4354 (compare_overlay_entries):
4355 Avoid mishandling comparisons due to subtraction overflow.
4356 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4357 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4358 (handle_tool_bar_click):
4359 Use int, not unsigned, since we prefer signed and the signedness
4360 doesn't matter here.
4361 (get_next_display_element, next_element_from_display_vector):
4362 Use int, not EMACS_INT, when int is wide enough.
4363 (start_hourglass): Use duration_to_sec_usec to do proper
4364 overflow checking on durations.
4365 * xfaces.c (Fbitmap_spec_p):
4366 Check that fixnums are in proper range for system types.
4367 (compare_fonts_by_sort_order):
4368 Avoid mishandling comparisons due to subtraction overflow.
4369 (Fx_family_fonts, realize_basic_faces):
4370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4371 (Fx_family_fonts):
4372 Don't assume fixnum fits in int.
4373 Use SAFE_ALLOCA_LISP, not alloca.
4374 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4375 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4376 (face_at_buffer_position, face_for_overlay_string)
4377 (face_at_string_position):
4378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4379 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4380 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4381 (Fx_show_tip):
4382 Check that fixnums are in proper range for system types.
4383 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4384 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4386 (Fx_change_window_property): Don't assume fixnums fit in int.
4387 * xfont.c (xfont_chars_supported):
4388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4389 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4390 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4392 * xml.c (parse_region):
4393 * xrdb.c (magic_file_p):
4394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4395 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4396 (x_get_local_selection, x_reply_selection_request)
4397 (x_handle_selection_request, wait_for_property_change):
4398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4399 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4400 short is wide enough.
4401 (x_send_client_event): Don't assume fixnum fits in int.
4402 * xterm.c (x_x_to_emacs_modifiers):
4403 Don't assume EMACS_INT overflows nicely into int.
4404 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4405 may come from Lisp.
4406 (handle_one_xevent): NATNUMP can eval its arg twice.
4407 (x_connection_closed):
4408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4409 * xterm.h: Adjust decls to match defn changes elsewhere.
4410 (struct scroll_bar): Use struct vectorlike_header
4411 rather than rolling our own approximation.
4412 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4413
c6574eb5
GM
44142012-05-25 Glenn Morris <rgm@gnu.org>
4415
4416 * lisp.mk (lisp): Update for more files being compiled now.
4417
e8d32c7e
SM
44182012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4419
48def666
SM
4420 * lread.c: Remove `read_pure' which makes no difference.
4421 (read_pure): Remove var.
4422 (unreadpure): Remove function.
4423 (readevalloop): Don't call read_list with -1 flag.
4424 (read1, read_vector): Don't test read_pure any more.
4425 (read_list): Simplify.
4426
e8d32c7e
SM
4427 * fileio.c, character.h: Minor style tweaks.
4428
4b2addb7
DA
44292012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4430
4431 * window.h (clip_changed): Remove useless declaration.
4432
584461b2
JB
44332012-05-22 Juanma Barranquero <lekktu@gmail.com>
4434
4435 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4436 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4437
34374650
PE
44382012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4439
4440 Remove src/m/*.
4441 This directory predates autoconf and is no longer needed nowadays.
4442 Move its few remaining bits of functionality to where they're needed.
4443 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4444 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4445 * m/template.h: Remove.
4446 * Makefile.in (M_FILE): Remove. All uses removed.
4447 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4448 * lisp.h (USE_LSB_TAG):
4449 * mem-limits.h (EXCEEDS_LISP_PTR):
4450 Use VAL_MAX, not VALBITS, in #if.
4451 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4452 (EMACS_UINT): Define unconditionally now.
4453 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4454 (BITS_PER_EMACS_INT): New constants, replacing
4455 what used to be in config.h, but not useful in #if.
4456 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4457 define them any more.
4458 (VAL_MAX): New macro.
4459 (VALMASK): Use it.
4460 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4461 BITS_PER_EMACS_INT, in #if.
4462 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4463 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4464 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4465 * s/ms-w32.h (DATA_START):
4466 Move here from removed file m/intel386.h.
4467 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4468 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4469
261cb4bb
PE
44702012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4471
4472 Assume C89 or later.
4473 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4474 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4475 (xrealloc):
4476 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4477 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4478 * textprop.c, tparam.c (NULL): Remove.
4479 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4480 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4481 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4482 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4483 * xterm.c (input_signal_count): Assume volatile works.
4484
ff23cd9f
KB
44852012-05-21 Ken Brown <kbrown@cornell.edu>
4486
4487 * xgselect.c (xg_select): Fix first argument in call to 'select'
4488 (bug#11508).
4489
1b170bc6
KB
44902012-05-20 Ken Brown <kbrown@cornell.edu>
4491
4492 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4493 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4494
b2f4d39f
KB
44952012-05-19 Ken Brown <kbrown@cornell.edu>
4496
4497 * xfns.c (x_in_use): Remove `static' qualifier.
4498 * xterm.h (x_in_use): Declare.
4499 * xgselect.c: Include xterm.h.
4500 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4501 and `display_arg' (bug#9754).
4502
003fdae2
PE
45032012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4504
9232a6d9
PE
4505 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4506
003fdae2
PE
4507 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4508 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4509
784b56e2
EZ
45102012-05-18 Eli Zaretskii <eliz@gnu.org>
4511
4512 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4513
4514 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4515 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4516
4517 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4518 reference to image_cache->refcount.
4519 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4520
a0a79cde
JL
45212012-05-17 Juri Linkov <juri@jurta.org>
4522
4523 * search.c (Fword_search_regexp, Fword_search_backward)
4524 (Fword_search_forward, Fword_search_backward_lax)
4525 (Fword_search_forward_lax): Move functions to isearch.el
4526 (bug#10145, bug#11381).
4527
b0572523
PE
45282012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4529
4530 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4531
9660f5fc
SM
45322012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4533
4534 * lread.c (init_obarray): Declare Qt and Qnil as special.
4535
4374de83
GM
45362012-05-14 Glenn Morris <rgm@gnu.org>
4537
4538 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4539 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4540
dc44c39a
PE
45412012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4542
078c97cb
PE
4543 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4544
dc44c39a
PE
4545 * unexaix.c: Port to more-recent AIX compilers.
4546 (report_error, report_error_1, make_hdr, copy_sym)
4547 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4548 Make arguments const char *, not char *, to avoid violations of C
4549 standard and to fix some AIX warnings reported by Gilles Pion.
4550
e18afed7 45512012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4552
4553 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4554 already have overlays loaded.
4555 (handle_single_display_spec): Before returning without displaying
4556 fringe bitmap, synchronize the bidi iterator with the main display
4557 iterator, by calling iterate_out_of_display_property.
4558 (iterate_out_of_display_property): Detect buffer iteration by
4559 testing that it->string is a Lisp string.
4560 (get_next_display_element): When the current object is exhausted,
4561 and there's something on it->stack, call set_iterator_to_next to
4562 proceed with what's on the stack, instead of returning zero.
4563 (set_iterator_to_next): If called at the end of a Lisp string,
4564 proceed to consider_string_end without incrementing string
4565 position. Don't increment display vector index past the end of
4566 the display vector. (Bug#11417)
c8fb9dc6
EZ
4567 (pos_visible_p): Don't report a position visible when move_it_to
4568 stopped at the last line of window, which happens to be scanned
4569 backwards by the bidi iteration. (Bug#11464)
ac268e67 4570
e18afed7 45712012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4572
4573 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4574 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4575 are on a TTY, and thus unable to display on the fringes.
4576 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4577 so we need to signal to the caller that this is a "replacing"
4578 display spec. This fixes display when the spec is invalid or we
4579 are on a TTY.
4580
e18afed7 45812012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4582
4583 * unexaix.c (make_hdr): Fix typo in prototype.
4584 This bug broke the build on AIX. Problem reported by Gilles Pion.
4585
9d0a235a
MA
45862012-05-14 Michael Albinus <michael.albinus@gmx.de>
4587
4588 * keyboard.c (kbd_buffer_get_event): Read special events also in
4589 batch mode. (Bug#11415)
4590
9e6b06ed
GM
45912012-05-12 Glenn Morris <rgm@gnu.org>
4592
4593 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4594
c1a1d7a3
EZ
45952012-05-12 Eli Zaretskii <eliz@gnu.org>
4596
4597 * lisp.mk (lisp): Add newcomment.elc.
4598
3fe7cdc8
GM
45992012-05-12 Glenn Morris <rgm@gnu.org>
4600
4601 * Makefile.in (MKDIR_P): New, set by configure.
4602 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4603
53f7d2c0
PE
46042012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4605
4606 Remove unused function hourglass_started.
4607 * dispextern.h (hourglass_started):
4608 * w32fns.c (hourglass_started):
4609 * xdisp.c (hourglass_started): Remove.
4610
75aafb17
JB
46112012-05-10 Juanma Barranquero <lekktu@gmail.com>
4612
4613 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4614 Update dependencies.
4615
12959e8e
PE
46162012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4617
97107e2e
PE
4618 * xgselect.c (xg_select): Put maxfds+1 into a var.
4619 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4620
12959e8e
PE
4621 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4622
836d29b3
DA
46232012-05-10 Dave Abrahams <dave@boostpro.com>
4624
4625 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4626 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4627
5cb67954
MA
46282012-05-09 Michael Albinus <michael.albinus@gmx.de>
4629
4630 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4631 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4632 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4633 Initialize xd_registered_buses.
4634
3478ec45
PE
46352012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4636
b263a6b0
PE
4637 Untag more efficiently if USE_LSB_TAG.
4638 This is based on a proposal by YAMAMOTO Mitsuharu in
4639 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4640 For an admittedly artificial (nth 8000 longlist) benchmark on
4641 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4642 Emacs's overall text size by 1%.
4643 * lisp.h (XUNTAG): New macro.
4644 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4645 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4646 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4647 * eval.c (Fautoload):
4648 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4649 * frame.h (XFRAME): Use XUNTAG.
4650
3478ec45
PE
4651 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4652 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4653 Remove unportable assumptions about print widths of types like
4654 dbus_uint32_t.
4655 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4656 intptr_t when converting between pointer and integer, to avoid GCC
4657 warnings about wrong width.
4658
666b903b 46592012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4660
4661 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4662 stack for each reader_thread, instead of defaulting to 8MB
4663 determined by the linker. This avoids failures in creating
4664 subprocesses on Windows 7, see the discussion in this thread:
4665 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4666
b120cc17
JC
46672012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4668
4669 Fix up display of the *Minibuf-0* buffer in the mini window.
4670 * keyboard.c (read_char): Don't clear the echo area if there's no
4671 message to clear.
4672 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4673 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4674
9a4b36f8
MA
46752012-05-07 Michael Albinus <michael.albinus@gmx.de>
4676
4677 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4678 batch mode.
4679
e5f9458f
CY
46802012-05-06 Chong Yidong <cyd@gnu.org>
4681
4682 * lisp.mk (lisp): Update.
4683
eceeb5fc 46842012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4685
4686 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4687
71873e2b
SM
46882012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4689
4690 * data.c (PUT_ERROR): New macro.
4691 (syms_of_data): Use it. Add new error type `user-error'.
4692 * undo.c (user_error): New function.
4693 (Fprimitive_undo): Use it.
4694 * print.c (print_error_message): Adjust print style for `user-error'.
4695 * keyboard.c (user_error): New function.
4696 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4697
ab0fa4e4
PE
46982012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4699
4700 Do not limit current-time-string to years 1000..9999.
4701 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4702 (Fcurrent_time_string): Support any year that is supported by the
4703 underlying localtime representation. Don't use asctime, as it
4704 has undefined behavior for years outside the range -999..9999.
4705
7ed806a7
PE
47062012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4707
4708 Fix race conditions involving setenv, gmtime, localtime, asctime.
4709 Without this fix, interrupts could mess up code that uses these
4710 nonreentrant functions, since setting TZ invalidates existing
4711 tm_zone or tzname values, and since most of these functions return
4712 pointers to static storage.
4713 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4714 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4715 Grow the critical sections to include not just invoking
4716 localtime/gmtime, but also accessing these functions' results
4717 including their tm_zone values if any, and any related TZ setting.
4718 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4719 so that the struct tm is saved in the critical section.
4720 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4721 motivated by the fact that memory allocation needs to be outside
4722 the critical section.
4723
0c16dfed
DA
47242012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4725
4726 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4727 with RESET_INTERVAL.
4728
4729 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4730 Remove duplicated buffer name initialization.
4731
3f83ace8
JM
47322012-05-02 Jim Meyering <jim@meyering.net>
4733
4734 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4735
c7b8541e
JM
4736 * xfns.c (x_window): Use xstrdup (Bug#11375).
4737
90207a15 47382012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4739
4740 * xdisp.c (pos_visible_p): If already at a newline from the
4741 display string before the 'while' loop, don't walk back the glyphs
4742 from it3.glyph_row. Solves assertion violation when the display
4743 string begins with a newline (egg.el). (Bug#11367)
4744
b593d6a9
AH
47452012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4746
4747 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4748 Move to simple.el.
4749
4737362e
GM
47502012-05-01 Glenn Morris <rgm@gnu.org>
4751
99cf43f9
GM
4752 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4753 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4754 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4755 All were removed before 23.1.
4756
9311dcff
GM
4757 * dispnew.c: Remove HAVE_LIBNCURSES test;
4758 it is always true on relevant platforms.
4759
4d5c6349
GM
4760 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4761 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4762
4737362e
GM
4763 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4764
74dd3a6b
AS
47652012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4766
4767 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4768 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4769 Remove.
4770
13c379ee
PE
47712012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4772
4773 Do not avoid creating empty evaporating overlays (Bug#9642).
4774 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4775 That is, do not delete an evaporating overlay if it becomes
4776 empty after its bounds are adjusted to fit within its buffer.
4777 This fix caused other problems, and I'm reverting it until we get
4778 to the bottom of them.
4779
a8e7d6d7 47802012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4781
4782 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4783
a8e7d6d7 47842012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4785
4786 * xdisp.c (pos_visible_p): If the window start position is beyond
4787 ZV, start the display from buffer beginning. Prevents assertion
4788 violation in init_iterator when the minibuffer window is scrolled
4789 via the scroll bar.
4790
4791 * window.c (window_scroll_pixel_based): Likewise.
4792
a8e7d6d7 47932012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4794
4795 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4796
a8e7d6d7 47972012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4798
4799 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4800 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4801
a8e7d6d7 48022012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4803
b593d6a9
AH
4804 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4805 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4806
1c6900d9
EZ
48072012-04-26 Eli Zaretskii <eliz@gnu.org>
4808
4c3fa1d9
EZ
4809 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4810 display element, check also the underlying string or buffer
4811 character. (Bug#11341)
4812
1c6900d9
EZ
4813 * w32menu.c: Include w32heap.h.
4814 (add_menu_item): If the call to AppendMenuW (via
4815 unicode_append_menu) fails, disable Unicode menus only if we are
4816 running on Windows 9X/Me.
4817
42bf8205
AS
48182012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4819
4820 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4821 (xgetint): Add missing shift for LSB tags.
4822
b1bac16e
MR
48232012-04-24 Martin Rudalics <rudalics@gmx.at>
4824
4825 * keyboard.c (read_char): Don't wipe echo area for select window
4826 events: These might get delayed via `mouse-autoselect-window'
4827 (Bug#11304).
4828
d69621cc
JB
48292012-04-24 Juanma Barranquero <lekktu@gmail.com>
4830
4831 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4832 manipulation of :loaded-from data.
4833
02fd101b
JB
48342012-04-23 Juanma Barranquero <lekktu@gmail.com>
4835
4836 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4837 now a cons (bug#11311).
4838
888bec30
PE
48392012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4840
89a438bd
PE
4841 Do not create empty overlays with the evaporate property (Bug#9642).
4842 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4843 if it becomes empty after its bounds are adjusted to fit within
4844 its buffer. Without this fix, in a nonempty buffer (let ((o
4845 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4846 yields an empty overlay that has the evaporate property, which is
4847 not supposed to happen.
4848
1068fe4d
PE
4849 Fix minor GTK3 problems found by static checking.
4850 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4851 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4852 (struct _EmacsFixedClass, emacs_fixed_get_type):
4853 Move decls here from emacsgtkfixed.h, since they needn't be public.
4854 (emacs_fixed_get_type): Now static.
4855 (emacs_fixed_class_init): Omit unused local.
4856 (emacs_fixed_child_type): Remove; unused.
4857 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4858 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4859 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4860 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4861 (EMACS_FIXED_GET_CLASS): Remove; unused.
4862 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4863
888bec30
PE
4864 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4865 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4866
de85e130
PE
48672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4868
d0baac98 4869 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4870 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4871 (__malloc_size_t, __malloc_ptrdiff_t):
4872 Remove. All uses removed, replaced by the definiens if needed,
4873 since we can assume C89 or better now.
4874 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4875 (protect_malloc_state, align, get_contiguous_space)
4876 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4877 (malloc_atfork_handler_child, malloc_enable_thread)
4878 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4879 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4880 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4881 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4882 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4883 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4884 Define using prototypes, not old style.
4885 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4886 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4887 (align): Don't assume that signed integer overflow wraps around.
4888 Omit unused local var.
4889 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4890 (_free_internal_nolock, memalign, mallochook, reallochook):
4891 Omit no-longer-needed casts.
4892 (valloc): Use getpagesize, not __getpagesize.
4893 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4894 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4895
de85e130
PE
4896 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4897
dcbf5805
MA
48982012-04-22 Michael Albinus <michael.albinus@gmx.de>
4899
4900 Move functions from C to Lisp. Make non-blocking method calls
4901 the default. Implement further D-Bus standard interfaces.
4902
4903 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4904 (QCdbus_request_name_allow_replacement)
4905 (QCdbus_request_name_replace_existing)
4906 (QCdbus_request_name_do_not_queue)
4907 (QCdbus_request_name_reply_primary_owner)
4908 (QCdbus_request_name_reply_in_queue)
4909 (QCdbus_request_name_reply_exists)
4910 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4911 (QCdbus_registered_serial, QCdbus_registered_method)
4912 (QCdbus_registered_signal): New Lisp objects.
4913 (XD_DEBUG_MESSAGE): Use sizeof.
4914 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4915 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4916 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4917 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4918 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4919 (xd_signature, xd_append_arg): Allow float for integer types.
4920 (xd_get_connection_references): New function.
b593d6a9
AH
4921 (xd_get_connection_address): Rename from xd_initialize.
4922 Return cached address.
dcbf5805
MA
4923 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4924 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4925 level.
4926 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4927 Return number of refcounts.
dcbf5805
MA
4928 (Fdbus_get_unique_name): Make stronger parameter check.
4929 (Fdbus_message_internal): New defun.
4930 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4931 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4932 (Fdbus_send_signal, Fdbus_register_service)
4933 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4934 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4935 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4936 (Vdbus_compiled_version, Vdbus_runtime_version)
4937 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4938 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4939 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4940 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4941 Adapt docstring.
dcbf5805 4942
52828e02
PE
49432012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4944
da05bc4c
PE
4945 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4946 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4947 Do not assume ptrdiff_t is the same width as 'int'.
4948
52828e02
PE
4949 * alloc.c: Handle unusual debugging option combinations.
4950 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4951 since the two debugging options are incompatible.
4952 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4953 is defined.
4954 (mem_init, mem_insert, mem_insert_fixup):
4955 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4956 (NEED_MEM_INSERT): Remove; no longer needed.
4957
f01769f9
LL
49582012-04-22 Leo Liu <sdl.web@gmail.com>
4959
4960 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4961
5790543d
PE
49622012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4963
4964 * sysdep.c [__FreeBSD__]: Minor cleanups.
4965 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4966 Use Emacs indenting style more consistently. Avoid some casts.
4967 Use 'double' consistently rather than mixing 'float' and 'double'.
4968
b91b7e4d
EW
49692012-04-21 Eduard Wiebe <usenet@pusto.de>
4970
b593d6a9
AH
4971 * sysdep.c (list_system_processes, system_process_attributes):
4972 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4973
6114eb15
AS
49742012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4975
4976 * lisp.mk (lisp): Update.
4977
2f38dff7
PE
49782012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4979
4980 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4981 It is never used otherwise.
4982
4ae29f89
SM
49832012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4984
4985 * print.c (print_preprocess): Only check print_depth if print-circle
4986 is nil.
4987 (print_object): Check for cycles even when print-circle is nil and
4988 print-gensym is t, but only check print_depth if print-circle is nil.
4989
f30d612a
CY
49902012-04-20 Chong Yidong <cyd@gnu.org>
4991
4992 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4993 set the status to "failed" and ensure that sentinel is run.
4994
c07a4c0b 49952012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4996
4997 * process.c (Fset_process_inherit_coding_system_flag)
4998 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4999 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5000
c07a4c0b 50012012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5002
5003 * xdisp.c (string_buffer_position_lim): Limit starting position to
5004 BEGV.
5005 (set_cursor_from_row): If called for a mode-line or header-line
5006 row, return zero immediately.
5007 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5008 farther than the first row after the header line, if any.
5009 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5010 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5011
c07a4c0b 50122012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5013
4ae29f89
SM
5014 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5015 (bug#11238).
ad3a2b41 5016
c07a4c0b 50172012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 50182012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5019
5020 configure: new option --enable-gcc-warnings (Bug#11207)
5021 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5022 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5023 (ALL_CFLAGS): Use new macros rather than old.
5024 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5025 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5026 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5027 -Wunused-result, -Wunused-variable. This should go away once
5028 the Emacs and Gnulib regex code is merged.
5029 (xmalloc, xrealloc): Now static.
5030
aba027e8
PE
50312012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5032
5033 * dired.c (Fsystem_groups): Remove unused local.
5034
e5a36063
GM
50352012-04-17 Glenn Morris <rgm@gnu.org>
5036
5037 * dired.c (Fsystem_users): Doc fix.
5038
316411f0
DA
50392012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5040
5041 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5042 (syms_of_dired): Add them.
5043
9426aba4
PE
50442012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5045
b62a57be
PE
5046 Fix minor alloc.c problems found by static checking.
5047 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5048 New extern decls, to avoid calling undeclared functions.
5049 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5050 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5051 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5052 (NEED_MEM_INSERT): New macro.
5053 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5054 Remove one incorrect comment and fix another.
b62a57be 5055
3539f31f
PE
5056 Fix minor ralloc.c problems found by static checking.
5057 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5058 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5059 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5060 (r_alloc_sbrk): Now static.
5061
a041960a
PE
5062 Improve ralloc.c interface checking.
5063 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5064 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5065 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5066 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5067 [REL_ALLOC]: ... to here, to check interface.
5068 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5069 Remove decls. This fixes an "It stinks!".
5070
9426aba4
PE
5071 * alloc.c (which_symbols): Fix alignment issue / type clash.
5072
d55c12ed
AS
50732012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5074
5075 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5076 (struct Lisp_Misc_Any): Likewise.
5077 (struct Lisp_Free): Likewise.
5078 * alloc.c (union aligned_Lisp_Symbol): Define.
5079 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5080 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5081 (union aligned_Lisp_Misc): Define.
5082 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5083 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5084 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5085
b948ce8b
PE
50862012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5087
5088 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5089 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5090 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5091 * s/netbsd.h, s/sol2-6.h:
5092 Remove definition of GC_MARK_STACK, since the default now works.
5093 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5094 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5095 no longer the default.
5096 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5097
35dc09a1 50982012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5099
35dc09a1
GM
5100 * lread.c (lisp_file_lexically_bound_p):
5101 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5102
35dc09a1
GM
51032012-04-14 Eli Zaretskii <eliz@gnu.org>
5104
5105 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5106 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5107
51082012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5109
5110 * nsterm.m (constrainFrameRect): Always constrain when there is only
5111 one screen (Bug#10962).
5112
bcd86815
KB
51132012-04-13 Ken Brown <kbrown@cornell.edu>
5114
5115 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5116
c25df26e
RT
51172012-04-13 Reuben Thomas <rrt@sc3d.org>
5118
5119 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5120
0fc59f1e
DC
51212012-04-11 Daniel Colascione <dancol@dancol.org>
5122
5123 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5124 against is gone. It's better to use vfork now so that when Cygwin
5125 gains a new, working vfork, we use it automatically (bug#10398).
5126
de8c03dc
SM
51272012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5128
5129 * window.c (save_window_save): Obey window-point-insertion-type.
5130
2f097256
GM
51312012-04-11 Glenn Morris <rgm@gnu.org>
5132
5133 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5134
453b951e
SM
51352012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5136
5137 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5138
75f1671a 51392012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5140
5141 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5142 (force_quit_count): New var.
5143 (handle_interrupt): Use it.
5144
2a8ce227
JB
51452012-04-10 Juanma Barranquero <lekktu@gmail.com>
5146
5147 * w32.c (w32_delayed_load): Record the full path of the library
5148 being loaded (bug#10424).
5149
935396c0
GM
51502012-04-09 Glenn Morris <rgm@gnu.org>
5151
05920a43
GM
5152 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5153 not just in the obarray, before snarfing them. (Bug#11036)
5154
935396c0
GM
5155 * Makefile.in ($(leimdir)/leim-list.el):
5156 Pass EMACS rather than BUILT_EMACS.
5157
a18ecafa
TZ
51582012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5159
5160 * process.c (make_process):
5161 * process.h: Add integer `gnutls_handshakes_tried' member to
5162 process struct.
5163
6bbef4e5
JC
5164 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5165 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5166
5167 * gnutls.c (gnutls_log_function2i): Convenience log function.
5168 (emacs_gnutls_read): Use new log functions,
5169 `gnutls_handshakes_tried' process member, and
5170 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5171 attempts per process (connection).
5172
b4d3bc10
CY
51732012-04-09 Chong Yidong <cyd@gnu.org>
5174
5175 * eval.c (Fuser_variable_p, user_variable_p_eh)
5176 (lisp_indirect_variable): Functions deleted.
5177 (Fdefvar): Caller changed.
5178
5179 * callint.c (Finteractive, Fcall_interactively):
5180 * minibuf.c (Fread_variable): Callers changed.
5181
70f4d973
EZ
51822012-04-09 Eli Zaretskii <eliz@gnu.org>
5183
5184 * xdisp.c (set_cursor_from_row): If the display string appears in
5185 the buffer at position that is closer to point than the position
5186 after the display string, display the cursor on the first glyph of
5187 the display string. Fixes cursor display when a 'display' text
5188 property immediately follows invisible text. (Bug#11094)
5189
cb3c2e3e
PE
51902012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5191
5192 composite.c: use 'double' consistently
5193 * composite.c (get_composition_id): Use 'double' consistently
5194 instead of converting 'float' to 'double' and vice versa; this is
5195 easier to understand and avoids a GCC warning.
5196
fd06db5d
GM
51972012-04-09 Glenn Morris <rgm@gnu.org>
5198
50fe702a
GM
5199 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5200 preparation for dumping it with emacs. (Bug#4789)
5201 (leimdir): New variable.
5202 ($(leimdir)/leim-list.el): New rule.
5203 (emacs$(EXEEXT)): Depend on leim-list.el.
5204
fd06db5d
GM
5205 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5206 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5207 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5208
55c131ee
AS
52092012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5210
5211 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5212 proper alignment.
5213
9209588f
JB
52142012-04-07 Juanma Barranquero <lekktu@gmail.com>
5215
5216 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5217 Remove unused local variable.
5218
e3fb2efb
PE
52192012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5220
5221 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5222 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5223 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5224 objects, as mark_maybe_pointer will catch them otherwise.
5225 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5226 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5227
b5385551
PE
52282012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5229
5230 Fix typo that broke non-Windows builds.
5231 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5232
9078ead6
EZ
52332012-04-07 Eli Zaretskii <eliz@gnu.org>
5234
5235 Support building on MS-Windows with libxml2.
5236
5237 * makefile.w32-in (OBJ2): Add xml.$(O).
5238 (GLOBAL_SOURCES): Add xml.c.
5239 ($(BLD)/xml.$(O)): New dependency list.
5240
5241 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5242 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5243 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5244 [!WINDOWSNT]: New macros.
5245 (init_libxml2_functions, libxml2_loaded_p): New functions.
5246 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5247 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5248 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5249 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5250 linked in).
6bbef4e5
JC
5251 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5252 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5253 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5254
5255 * emacs.c: Don't include libxml/parser.h.
5256 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5257 xmlCleanupParser directly.
5258
5259 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5260
3811fdf3
EZ
52612012-04-07 Eli Zaretskii <eliz@gnu.org>
5262
5263 * indent.c (Fvertical_motion): If there is a display string at
5264 point, use it.vpos to compute how many lines to backtrack after
5265 move_it_to point. (Bug#11133)
5266
2f8e16b2
EZ
52672012-04-06 Eli Zaretskii <eliz@gnu.org>
5268
5269 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5270 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5271 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5272 macros related to unification of CJK characters. For the details,
5273 see the discussion following the message here:
5274 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5275
3d439cd1
CY
52762012-04-04 Chong Yidong <cyd@gnu.org>
5277
5278 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5279
8bc53d00
EZ
52802012-04-01 Eli Zaretskii <eliz@gnu.org>
5281
5282 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5283 instead of alloca. (Bug#11138)
5284
3b0512a3
AS
52852012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5286
5287 * w32menu.c (is_simple_dialog): Properly check lisp types.
5288 (Bug#11141)
5289
8427ddd2
EZ
52902012-03-31 Eli Zaretskii <eliz@gnu.org>
5291
979022ef
EZ
5292 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5293 position we get to after a call to move_it_to fails the
5294 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5295 only if we wind up in a string from display property. (Bug#11063)
5296
a6b1c7cc
EZ
5297 * window.c (Fdelete_other_windows_internal): Invalidate the row
5298 and column information about mouse highlight, so that redisplay
5299 restores it after reallocating the glyph matrices. (Bug#7464)
5300
8427ddd2
EZ
5301 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5302 string comes from a `display' text property, use the buffer
5303 position of that property as if we actually saw that position in
5304 the row's glyphs.
697ba24b
EZ
5305 (move_it_by_lines): Remove the assertion that
5306 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5307 violated when there's a before-string at the beginning of a line.
5308 (Bug#11063)
8427ddd2 5309
65a0a738
EZ
53102012-03-30 Eli Zaretskii <eliz@gnu.org>
5311
5312 * xdisp.c (append_space_for_newline): If the default face was
5313 remapped, use the remapped face for the appended newline.
5314 (extend_face_to_end_of_line): Use the remapped default face for
5315 extending the face to the end of the line.
5316 (display_line): Call extend_face_to_end_of_line when the default
5317 face was remapped. (Bug#11068)
5318
581355cc
EZ
53192012-03-29 Eli Zaretskii <eliz@gnu.org>
5320
5321 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5322
e8fc049f
SM
53232012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5324
5325 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5326
4fb9a543
GM
53272012-03-27 Glenn Morris <rgm@gnu.org>
5328
5329 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5330 Doc fixes.
5331
679910f1
KH
53322012-03-26 Kenichi Handa <handa@m17n.org>
5333
5334 * dispextern.h (struct glyph): Fix previous change. Change the
5335 bit length of glyphless.ch to 25 (Bug#11082).
5336
90d49b7f
CY
53372012-03-26 Chong Yidong <cyd@gnu.org>
5338
5339 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5340 (command_loop_1): Use it; inhibit selection update for
5341 handle-select-window too (Bug#8996).
5342
f514f6f0
FP
53432012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5344
e8fc049f 5345 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5346
bf43fa51
KH
53472012-03-25 Kenichi Handa <handa@m17n.org>
5348
5349 * dispextern.h (struct glyph): Change the bit length of
5350 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5351
8a0c01dd
EZ
53522012-03-24 Eli Zaretskii <eliz@gnu.org>
5353
5354 * s/ms-w32.h (tzname): Include time.h before redirecting to
5355 _tzname. Fixes the MSVC build. (Bug#9960)
5356
7d1c3a76
AS
53572012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5358
8ed79523
AS
5359 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5360 characters.
5361
7d1c3a76
AS
5362 * xterm.c (XTread_socket): Only modify handling_signal if
5363 !SYNC_INPUT. (Bug#11080)
5364
e99a9b8b
EZ
53652012-03-23 Eli Zaretskii <eliz@gnu.org>
5366
5367 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5368 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5369 when fetching a multibyte character consumes more bytes than
5370 CHAR_BYTES returns, due to unification of CJK characters in
5371 string_char. (Bug#11073)
5372
5063c0e1
TN
53732012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5374
5375 * process.c (wait_reading_process_output): Handle pty disconnect
5376 by refraining from sending oneself a SIGCHLD (bug#10933).
5377
9f851fbd
CY
53782012-03-22 Chong Yidong <cyd@gnu.org>
5379
5380 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5381
5063c0e1 5382 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5383 Mark string as coming from a prefix property.
5384 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5385 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5386
fb5b8aca
CY
53872012-03-21 Chong Yidong <cyd@gnu.org>
5388
5389 * xfaces.c (Vface_remapping_alist): Doc fix.
5390
62356a1b
EZ
53912012-03-20 Eli Zaretskii <eliz@gnu.org>
5392
5393 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5394 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5395 Doc fixes.
62356a1b 5396
025de85b
CY
53972012-03-20 Chong Yidong <cyd@gnu.org>
5398
5399 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5400 to reflect default non-nil value of redisplay-dont-pause.
5401
4827f94e
KH
54022012-03-19 Kenichi Handa <handa@m17n.org>
5403
5404 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5405 it fit in a valid range (Bug#11003).
5406
e50a24a2
EZ
54072012-03-18 Eli Zaretskii <eliz@gnu.org>
5408
5409 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5410 that is not from display property, accept the row as a "cursor
5411 row" if one of the string's character has a non-nil `cursor'
5412 property. Fixes cursor positioning when there are newlines in
5413 overlay strings, e.g. in icomplete.el. (Bug#11035)
5414
9af5ed87
PE
54152012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5416
5417 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5418
d1f55f16
CY
54192012-03-12 Chong Yidong <cyd@gnu.org>
5420
5421 * eval.c (inhibit_lisp_code): Rename from
5422 inhibit_window_configuration_change_hook; move from window.c.
5423
5424 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5425 * window.c (run_window_configuration_change_hook)
5426 (syms_of_window): Callers changed.
5427
66c5eebd
CY
54282012-03-11 Chong Yidong <cyd@gnu.org>
5429
413df973
CY
5430 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5431
66c5eebd
CY
5432 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5433
1de11f56
CY
54342012-03-10 Chong Yidong <cyd@gnu.org>
5435
5436 * frame.c (other_visible_frames): Don't assume the selected frame
5437 is visible (Bug#10955).
5438
cae07000
SM
54392012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5440
5441 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5442
89c94350
JD
54432012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5444
5445 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5446 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5447 zero (Bug#10954).
5448
999dd333
GM
54492012-03-03 Glenn Morris <rgm@gnu.org>
5450
01a6dcc8 5451 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5452
de0100f2
EZ
54532012-03-02 Eli Zaretskii <eliz@gnu.org>
5454
5455 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5456 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5457 (redisplay_window, next_element_from_string): Fix typos in
5458 comments.
3e441275
EZ
5459 (redisplay_window): Pass to move_it_vertically the margin in
5460 pixels, not in screen lines.
de0100f2 5461
96a72ee9
GM
54622012-03-02 Glenn Morris <rgm@gnu.org>
5463
5464 * buffer.c (buffer-list-update-hook): Doc fix.
5465
312508d7
EZ
54662012-02-29 Eli Zaretskii <eliz@gnu.org>
5467
5468 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5469 push_it before setting up the iterator for the first overlay
5470 string, even if we have an empty string loaded.
5471 (next_overlay_string): If there's an empty string on the iterator
5472 stack, pop the stack. (Bug#10903)
5473
27f3c637
PE
54742012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5475
5476 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5477 Suggested by Stefan Monnier in
5478 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5479 * alloc.c (widen_to_Lisp_Object): New static function.
5480 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5481 and widening them to Lisp_Objects. This would work even if
5482 USE_LSB_TAG is defined and wide integers are used, which might
5483 happen in a future version of Emacs.
5484
3c9dfce6
CY
54852012-02-25 Chong Yidong <cyd@gnu.org>
5486
fa74b241
CY
5487 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5488 Doc fix.
5489
3c9dfce6
CY
5490 * xselect.c (Fx_selection_exists_p): Doc fix.
5491 (x_clipboard_manager_save_all): Print an informative message
5492 before saving to clipboard manager.
5493
9486df08
CY
54942012-02-24 Chong Yidong <cyd@gnu.org>
5495
5496 * keyboard.c (process_special_events): Handle all X selection
5497 requests in kbd_buffer, not just the next one (Bug#8869).
5498
f01d3321
CY
54992012-02-23 Chong Yidong <cyd@gnu.org>
5500
5501 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5502 call when setting menu-bar-lines and tool-bar-lines parameters.
5503 (unwind_create_frame_1): New helper function.
5504
5505 * window.c (inhibit_window_configuration_change_hook): New var.
5506 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5507 (syms_of_window): Initialize it.
f01d3321 5508
86b847b6
CY
55092012-02-22 Chong Yidong <cyd@gnu.org>
5510
5511 * xterm.c (x_draw_image_relief): Add missing type check for
5512 Vtool_bar_button_margin (Bug#10743).
5513
a59225b1
CY
55142012-02-21 Chong Yidong <cyd@gnu.org>
5515
5516 * fileio.c (Vfile_name_handler_alist): Doc fix.
5517
5518 * buffer.c (Fget_file_buffer): Protect against invalid file
5519 handler return value.
5520
310f5bd4
PE
55212012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5522
cb3a28cc
PE
5523 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5524 when computing $valmask.
5525
310f5bd4
PE
5526 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5527 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5528 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5529 It's useless in that case, and it can cause problems on hosts
5530 that allocate halves of EMACS_INT values separately.
5531 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5532 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5533 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5534 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5535 it avoids undefined behavior on hosts where shifting right by more
5536 than the word width has undefined behavior.
5537
2375c96a
CY
55382012-02-19 Chong Yidong <cyd@gnu.org>
5539
5540 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5541 (Funhandled_file_name_directory, Ffile_name_as_directory)
5542 (Fdirectory_file_name, Fexpand_file_name)
5543 (Fsubstitute_in_file_name): Protect against invalid file handler
5544 return values (Bug#10845).
5545
3eb49e71
EZ
55462012-02-18 Eli Zaretskii <eliz@gnu.org>
5547
5548 * .gdbinit (pitx): Fix incorrect references to fields of the
5549 iterator stack.
5550
7b926f3f
CY
55512012-02-17 Chong Yidong <cyd@gnu.org>
5552
5553 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5554
11273115
PE
55552012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5556
5557 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5558 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5559
c3a70e2b
CY
55602012-02-15 Chong Yidong <cyd@gnu.org>
5561
5562 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5563 marked as special. Also, starting docstrings with * is obsolete.
5564
0ca43699
AS
55652012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5566
5567 * gnutls.c (emacs_gnutls_write): Fix last change.
5568
2e8f3c56
LI
55692012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5570
5571 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5572 send_process.
5573
af70074f
SM
55742012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5575
5576 * keymap.c (Fsingle_key_description): Handle char ranges.
5577
95986d52
CY
55782012-02-12 Chong Yidong <cyd@gnu.org>
5579
afd83bd1
CY
5580 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5581 as that creates a dangerous corner case.
5582
95986d52
CY
5583 * window.c (Fdelete_window_internal): Invalidate the mouse
5584 highlight (Bug#9904).
5585
bd7da63e
GM
55862012-02-12 Glenn Morris <rgm@gnu.org>
5587
5588 * xselect.c (Fx_own_selection_internal)
5589 (Fx_get_selection_internal, Fx_disown_selection_internal)
5590 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5591 * nsselect.m (Fx_own_selection_internal)
5592 (Fx_disown_selection_internal, Fx_selection_exists_p)
5593 (Fx_selection_owner_p, Fx_get_selection_internal):
5594 Sync docs and argument specs with the xselect.c versions.
5595
77abcbc2
LI
55962012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5597
5598 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5599
90b671e2
EZ
56002012-02-11 Eli Zaretskii <eliz@gnu.org>
5601
1c0ca0b7
EZ
5602 * w32select.c (Fx_selection_exists_p): Sync doc string and
5603 argument list with xselect.c. (Bug#10783)
5604
5605 * w16select.c (Fx_selection_exists_p): Sync doc string and
5606 argument list with xselect.c. (Bug#10783)
90b671e2 5607
49241268
GM
56082012-02-10 Glenn Morris <rgm@gnu.org>
5609
5610 * fns.c (Fsecure_hash): Doc fix.
5611
f998bbe7 56122012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5613
5614 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5615
0992bd9c
CY
56162012-02-07 Chong Yidong <cyd@gnu.org>
5617
5618 * buffer.c (Fbuffer_local_variables)
5619 (buffer_lisp_local_variables): Handle unbound vars correctly;
5620 don't let Qunbound leak into Lisp.
5621
af008560
GM
56222012-02-07 Glenn Morris <rgm@gnu.org>
5623
dd605cc4
GM
5624 * image.c (Fimagemagick_types): Doc fix.
5625
af008560
GM
5626 * image.c (imagemagick-render-type): Change it from a lisp object
5627 to an integer. Move the doc here from the lisp manual.
5628 Treat all values not equal to 0 the same.
5629
1449fa1d
CY
56302012-02-06 Chong Yidong <cyd@gnu.org>
5631
5632 * doc.c (store_function_docstring): Avoid applying docstring of
5633 alias to base function (Bug#2603).
5634
3723ec07
AS
56352012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5636
5637 * .gdbinit (pp1, pv1): Remove redundant defines.
5638 (pr): Use pp.
5639
79c1cc1e
CY
56402012-02-04 Chong Yidong <cyd@gnu.org>
5641
5642 * nsterm.m: Declare a global (Bug#10694).
5643
d7f29f8e
EZ
56442012-02-04 Eli Zaretskii <eliz@gnu.org>
5645
cae07000
SM
5646 * w32.c (get_emacs_configuration_options):
5647 Include --enable-checking, if specified, in the return value.
d7f29f8e 5648
3b95a6f9
MR
56492012-02-04 Martin Rudalics <rudalics@gmx.at>
5650
5651 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5652 after rounding frame sizes. (Bug#9723)
5653
d6fa96a6
EZ
56542012-02-04 Eli Zaretskii <eliz@gnu.org>
5655
5656 * keyboard.c (adjust_point_for_property): Don't position point
5657 before BEGV. (Bug#10696)
5658
df0b2940
PE
56592012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5660
5661 Handle overflow when computing char display width (Bug#9496).
5662 * character.c (char_width): Return EMACS_INT, not int.
5663 (char_width, c_string_width): Check for overflow when
5664 computing the width; this is possible now that individual
5665 characters can have unbounded width. Problem introduced
5666 by merge from Emacs 23 on 2012-01-19.
5667
6bee44d6
MA
56682012-02-02 Michael Albinus <michael.albinus@gmx.de>
5669
5670 * dbusbind.c (Fdbus_register_method): Mention the return value
5671 :ignore in the docstring.
5672
44f92739
GM
56732012-02-02 Glenn Morris <rgm@gnu.org>
5674
1b9f60cc
GM
5675 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5676
44f92739
GM
5677 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5678 Unconditionally set to t. (Bug#10673)
5679 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5680 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5681 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5682
c5d3843c
KH
56832012-02-02 Kenichi Handa <handa@m17n.org>
5684
5685 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5686 0, do not call append_composite_glyph.
5687
159462d4 56882012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5689
5690 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5691 NULL (Bug#6988).
5692 (x_produce_glyphs): If the component of a composition is a null
5693 string, set it->pixel_width to 1 to avoid zero-width glyph.
5694
78cef877
EZ
56952012-02-01 Eli Zaretskii <eliz@gnu.org>
5696
5697 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5698 first 2 arguments are identical. This makes inserting large
5699 output from a subprocess an order of magnitude faster on
5700 MS-Windows, where all sbrk'ed memory is always contiguous.
5701
97897668
GM
57022012-01-31 Glenn Morris <rgm@gnu.org>
5703
5704 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5705 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5706 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5707
31fd3586
GM
57082012-01-29 Glenn Morris <rgm@gnu.org>
5709
5710 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5711
0e24a8b2
CY
57122012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5713
5714 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5715
cc0adcb0
CY
57162012-01-28 Chong Yidong <cyd@gnu.org>
5717
5718 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5719
acc28cb9
CY
57202012-01-26 Chong Yidong <cyd@gnu.org>
5721
9c69cfb7
CY
5722 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5723
acc28cb9
CY
5724 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5725 repeat counts (Bug#10507).
5726
48da7392
GM
57272012-01-26 Glenn Morris <rgm@gnu.org>
5728
5729 * lread.c (syms_of_lread): Doc fix.
5730
14af5f7f
CY
57312012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5732
5733 * coding.c (encode_designation_at_bol): Change return value to
5734 EMACS_INT.
5735
0b21c100
CY
57362012-01-25 Chong Yidong <cyd@gnu.org>
5737
5738 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5739
3c2907f7
CY
57402012-01-21 Chong Yidong <cyd@gnu.org>
5741
5742 * floatfns.c (Fcopysign): Make the second argument non-optional,
5743 since nil is not allowed anyway.
5744
959ad23f
AS
57452012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5746
5747 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5748 (send_process): Likewise.
5749
34a02f46
MR
57502012-01-19 Martin Rudalics <rudalics@gmx.at>
5751
5752 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5753 (Vwindow_persistent_parameters): Do not use Qstate.
5754 Rewrite doc-strings.
34a02f46 5755
1259009a 57562012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5757
5758 * character.c (char_width): New function.
70d4fdf6
GM
5759 (Fchar_width, c_string_width, lisp_string_width):
5760 Use char_width (Bug#9496).
25ed9e61 5761
6a6ee00d
MR
57622012-01-16 Martin Rudalics <rudalics@gmx.at>
5763
5764 * window.c (Vwindow_persistent_parameters): New variable.
5765 (Fset_window_configuration, save_window_save): Handle persistent
5766 window parameters.
5767
c85efaf7
EZ
57682012-01-14 Eli Zaretskii <eliz@gnu.org>
5769
5770 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5771 thrashing the stack of the thread. (Bug#9087)
5772
5944709e
PE
57732012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5774
5775 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5776
e71f5d99
EZ
57772012-01-11 Eli Zaretskii <eliz@gnu.org>
5778
5779 * xdisp.c (rows_from_pos_range): Handle the case where the
5780 highlight ends on a newline. (Bug#10464)
5781 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5782 he end column for display of highlight that ends on a newline
5783 before a R2L line.
5784
ce316182
GM
57852012-01-11 Glenn Morris <rgm@gnu.org>
5786
5787 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5788 from load-path also when installation-directory is nil. (Bug#10208)
5789
5b43da69
GM
57902012-01-10 Glenn Morris <rgm@gnu.org>
5791
74cc8ff9
GM
5792 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5793
7d8d6e4e
GM
5794 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5795 Update template values to be closer to their typical values these days.
5b43da69 5796
a0db8d43
EZ
57972012-01-09 Eli Zaretskii <eliz@gnu.org>
5798
5799 * xdisp.c (rows_from_pos_range): Accept additional argument
5800 DISP_STRING, and accept any glyph in a row whose object is that
5801 string as eligible for mouse highlight. Fixes mouse highlight of
5802 display strings from overlays. (Bug#10464)
5803
9a0115ab 58042012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5805
b9110d6a 5806 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5807 * fileio.c (auto_saving_dir_umask): New static var.
5808 (Fmake_directory_internal): Use it.
5809 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5810 creating the directory. The old code temporarily assigns
5811 too-generous permissions to the directory.
5812 (do_auto_save_eh): Clear it.
b9110d6a 5813 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5814 that the var is always cleared.
5815
6c1bd3f3
EZ
58162012-01-07 Eli Zaretskii <eliz@gnu.org>
5817
5818 * search.c (scan_buffer): Pass character positions to
5819 know_region_cache, not byte positions. (Bug#6540)
5820
069d2b50
L
58212012-01-07 LynX <_LynX@bk.ru> (tiny change)
5822
5823 * w32.c (sys_rename): Report EXDEV when rename of a directory
5824 fails because the target is on another logical disk. (Bug#10284)
5825
75bf0d33
DB
58262012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5827
5828 * xterm.c (x_embed_request_focus): New function.
5829
5830 * xterm.h: Add prototype.
5831
5832 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5833
1c6e5a32
GM
58342012-01-05 Glenn Morris <rgm@gnu.org>
5835
5836 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5837
651e947e
EZ
58382012-01-01 Eli Zaretskii <eliz@gnu.org>
5839
5840 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5841 Load gnutls_transport_set_lowat only if GnuTLS version is below
5842 2.11.1.
5843 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5844 GnuTLS versions below 2.11.1.
5845
3778cdd8
AL
58462011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5847
5848 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5849 to the doc string advising against its use for altering the way
5850 windows are scrolled.
5851
0e5317f7
KH
58522011-12-28 Kenichi Handa <handa@m17n.org>
5853
5854 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5855 coding-system ASCII compatible only when it does not produce BOM
5856 on encoding (Bug#10383).
5857
93d5ca1f
JD
58582011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5859
5860 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5861 can scroll.
5862 (create_and_show_popup_menu): Always use menu_position_func for
5863 Gtk3 (Bug#10361).
5864
ca22b785
AS
58652011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5866
5867 * callint.c (Fcall_interactively): Don't truncate prompt string.
5868
d048e1e6
EZ
58692011-12-23 Eli Zaretskii <eliz@gnu.org>
5870
5871 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5872 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5873 resumed from there (after widening). (Bug#10360)
d048e1e6 5874
5ccaba1f
JD
58752011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5876
5877 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5878
204ee57f
JD
58792011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5880
b81d40f0
JB
5881 * nsterm.m (x_free_frame_resources):
5882 Release f->output_data.ns->miniimage.
204ee57f
JD
5883 (ns_index_color): Fix indentation. Do not retain
5884 color_table->colors[i].
5885
5886 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5887 before returning.
5888
5889 * nsfns.m (x_set_background_color): Assign return value from
5890 ns_index_color to face-background instead of NSColor*.
5891 (ns_implicitly_set_icon_type): Fix indentation.
5892 Change assignment in for loop to comparison.
5893
5894 * emacs.c (ns_pool): New variable.
5895 (main): Assign ns_pool.
5896 (Fkill_emacs): Call ns_release_autorelease_pool.
5897
5898 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5899 autorelease fdesc, release fdAttrs and tdict.
5900 (ns_get_covering_families): Release charset.
5901 (ns_findfonts): Release NSFontDescriptor created with new.
5902 (ns_uni_to_glyphs): Fix indentation.
5903 (setString): Release attrStr before assigning new value.
5904
c803b2b7
JD
59052011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5906
678f4426
JD
5907 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5908 and NS_IMPL_COCOA.
5909 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5910 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5911
cd394be1 59122011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5913
5fecd5fc
JD
5914 * nsterm.m (ns_term_init): Subscribe for notifications
5915 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5916 to method trackingNotification in EmacsMenu.
5917
5918 * nsmenu.m (trackingMenu): New variable.
3771cb17 5919 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5920 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5921 from Aquamacs (Bug#7030).
678f4426
JD
5922
59232011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5924
c803b2b7
JD
5925 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5926 (symbol_to_nsstring): Fix indentation.
5927 (ns_symbol_to_pb): New function.
cae07000
SM
5928 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5929 (Fns_rotate_cut_buffers_internal): Remove.
5930 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5931 Fns_store_cut_buffer_internal.
5932 (ns_get_foreign_selection, Fx_own_selection_internal)
5933 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5934 (Fns_get_selection_internal, Fns_store_selection_internal):
5935 Use ns_symbol_to_pb and check if return value is nil.
5936 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5937 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5938 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5939 renamed to Sns_store_selection_internal.
5940 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5941 and remove this function.
5942 (ns_handle_selection_clear): Remove, never used.
5943 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5944 here.
5945
e1b01a3a
KB
59462011-12-17 Ken Brown <kbrown@cornell.edu>
5947
5948 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5949 GID is unknown (Bug#10257).
5950
2adb6e85
PE
59512011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5952
5953 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5954 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5955 which caused a build failure on GNU/Linux IA-64. This problem was
5956 introduced by my 2011-10-07 patch.
5957
d1d7b339
JL
59582011-12-15 Juri Linkov <juri@jurta.org>
5959
5960 * image.c (imagemagick_error): New function. (Bug#10112)
5961 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5962 Use `imagemagick_error' where ImageMagick functions return
5963 `MagickFalse'.
5964 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5965 proper order.
5966
100d5755
KH
59672011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5968
5969 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5970 fill background (Bug#8992).
5971
454592a6
MR
59722011-12-13 Martin Rudalics <rudalics@gmx.at>
5973
5974 * window.c (Vwindow_combination_resize)
5975 (Vwindow_combination_limit): Use t instead of non-nil in
5976 doc-strings.
61d4b438
MR
5977 (Vrecenter_redisplay): Add first sentence of doc-string on
5978 separate line.
53524d93 5979 (Frecenter): Fix doc-string typo.
454592a6 5980
3633e3aa
KH
59812011-12-11 Kenichi Handa <handa@m17n.org>
5982
5983 * coding.c (Funencodable_char_position): Pay attention to the
5984 buffer text relocation (Bug#9389).
5985
7b9d523a 59862011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5987
7b9d523a
JD
5988 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5989 gtk_init (Bug#10100).
5990
b73189c6
EZ
59912011-12-10 Eli Zaretskii <eliz@gnu.org>
5992
5993 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5994 IT->string is nil. (Bug#10263)
5995
f7dfe5d6
JD
59962011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5997
83faebb4
JD
5998 * nsterm.h (x_free_frame_resources): Declare.
5999
f7dfe5d6
JD
6000 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6001 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6002
6003 * nsterm.h (ns_get_defaults_value): Declare.
6004
6005 * nsterm.m (ns_default): Call ns_get_defaults_value.
6006
7cd4e72c
EZ
60072011-12-09 Eli Zaretskii <eliz@gnu.org>
6008
6009 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6010 (Bug#10170)
6011
b34d7317
YM
60122011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6013
6014 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6015 that where the value of an _OBJC_* symbol points to is in the .bss
6016 section (Bug#10240).
6017
76470ad1
KH
60182011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6019
6020 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6021 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6022
745fff94
KH
60232011-12-08 Kenichi Handa <handa@m17n.org>
6024
6025 * ftfont.c (get_adstyle_property): Fix previous change
6026 (Bug#10233).
6027
6e44397c
JB
60282011-12-07 Juanma Barranquero <lekktu@gmail.com>
6029
6030 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6031 dirs from the default value of EMACSLOADPATH (bug#10208).
6032
7efa6272
GM
60332011-12-07 Glenn Morris <rgm@gnu.org>
6034
6035 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6036 installation and source directories as well. (Bug#10208)
6037
f6fc4d87
CY
60382011-12-06 Chong Yidong <cyd@gnu.org>
6039
6040 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6041
2bf26180
GM
60422011-12-06 Glenn Morris <rgm@gnu.org>
6043
6044 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6045 as an error, not just -1. (Bug#10217)
6046
3a6ad4f0
CY
60472011-12-05 Chong Yidong <cyd@gnu.org>
6048
6049 * keyboard.c (process_special_events): New function.
6050 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6051
75a3b399
PE
60522011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6053
6054 * coding.c (encode_designation_at_bol): Don't use uninitialized
6055 local variable (Bug#9318).
6056
c3c9e25e
KH
60572011-12-05 Kenichi Handa <handa@m17n.org>
6058
6059 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6060 return Qnil (Bug#8046, Bug#10193).
6061
5eb05ea3
KH
60622011-12-05 Kenichi Handa <handa@m17n.org>
6063
6064 * coding.c (encode_designation_at_bol): New args charbuf_end and
6065 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6066 (coding_set_source): Return how many bytes coding->source was
6067 relocated.
6068 (coding_set_destination): Return how many bytes
6069 coding->destination was relocated.
6070 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6071 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6072
60732011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6074
6075 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6076 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6077 macro (Bug#9318).
6078
60792011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6080
6081 The following changes are to fix Bug#9318.
6082
a79703f5 6083 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6084 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6085 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6086 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6087
7dbda6df
JB
60882011-12-05 Juanma Barranquero <lekktu@gmail.com>
6089
6090 * lisp.h (process_quit_flag): Fix external declaration.
6091
6d5eb5b0
SM
60922011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6093
6094 Don't macro-inline non-performance-critical code.
6095 * eval.c (process_quit_flag): New function.
6096 * lisp.h (QUIT): Use it.
6097
a0c3fad0
JD
60982011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6099
6100 * nsfns.m (get_geometry_from_preferences): New function.
6101 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6102
6c07aac2
AS
61032011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6104
6105 * emacs.c (Qkill_emacs): Define.
6106 (syms_of_emacs): Initialize it.
6107 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6108 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6109 (quit_throw_to_read_char): Add parameter `from_signal'.
6110 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6111 * lisp.h (QUIT): Call Fkill_emacs if requested.
6112
c052ead4
JD
61132011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6114
6115 * widget.c (update_wm_hints): Return if wmshell is null.
6116 (widget_update_wm_size_hints): New function.
6117
6118 * widget.h (widget_update_wm_size_hints): Declare.
6119
6120 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6121 widget_update_wm_size_hints (Bug#10104).
6122
9e49252b
EZ
61232011-12-03 Eli Zaretskii <eliz@gnu.org>
6124
6125 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6126 before a newline, prepare the bidi iterator for consuming the
6127 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6128 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6129
02b16839
JL
61302011-12-02 Juri Linkov <juri@jurta.org>
6131
6132 * search.c (Fword_search_regexp): New Lisp function created from
6133 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6134 (Fword_search_backward, Fword_search_forward)
6135 (Fword_search_backward_lax, Fword_search_forward_lax):
6136 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6137 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6138
0068070e
SM
61392011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6140
6141 * fileio.c (Finsert_file_contents): Move after-change-function call
6142 to before the "handled:" label, since all "goto handled" appear in
6143 cases where the *-change-functions have already been properly called
6144 (bug#10117).
6145
3360a3fc
AS
61462011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6147
6148 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6149 waiting for input. (Bug#10169)
6150
73d6c093
EZ
61512011-11-30 Eli Zaretskii <eliz@gnu.org>
6152
6153 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6154 verifies glyph row's hash code--we have just reallocated the
6155 glyphs, so their contents can be complete garbage. (Bug#10164)
6156
febe6bea
JB
61572011-11-30 Juanma Barranquero <lekktu@gmail.com>
6158
6159 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6160
801a4313
EZ
61612011-11-30 Eli Zaretskii <eliz@gnu.org>
6162
6163 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6164 attributes are tested _before_ calling verify_row_hash, to protect
6165 against GCC re-ordering of the tests. (Bug#10164)
6166
2b56b87e
JD
61672011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6168
6169 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6170
6171 * xterm.c (handle_one_xevent): Only set async_visible and friends
6172 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6173 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6174 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6175
dbf31225
PE
61762011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6177
6178 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6179 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6180 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6181 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6182 All uses changed to use GCPRO1 etc.
6183 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6184 Revert to old implementation (i.e., before 2011-03-11).
6185
1305621b
YM
61862011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6187
6188 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6189 of scroll runs so as to avoid assigning disabled bogus rows and
6190 unnecessary graphics copy operations.
6191
8c9afb46
EZ
61922011-11-27 Eli Zaretskii <eliz@gnu.org>
6193
6194 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6195 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6196 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6197 (malloc, free, realloc, calloc): Redirect to e_* only when
6198 compiling Emacs.
6199
6200 * lisp.h (GCTYPEBITS): Move before first use.
6201 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6202 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6203 this macro definition.
6204
6205 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6206 _MSC_VER.
6207
54e9e3bf
JD
62082011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6209
6d5eb5b0
SM
6210 * gtkutil.c (xg_create_frame_widgets):
6211 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6212 present with Gtk+ 2.0.
6213
83aca1cb
PE
62142011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6215
6216 * fileio.c (Finsert_file_contents): Undo previous change; see
6217 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6218
5b76caa4
PE
62192011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6220
6221 Rename locals to avoid shadowing.
6222 * fileio.c (Finsert_file_contents):
6223 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6224 * process.c (wait_reading_process_output):
6225 Rename inner 'proc' to 'p' to avoid shadowing.
6226 Indent for consistency with usual Emacs style.
6227
8c535114
EZ
62282011-11-25 Eli Zaretskii <eliz@gnu.org>
6229
6230 * xdisp.c (redisplay_window): If cursor row is not fully visible
6231 after recentering, and scroll-conservatively is set to a large
6232 number, scroll window by a few more lines to make the cursor fully
6233 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6234 (start_display): Don't move to the next line if the display should
6235 start at a newline that is part of a display vector or an overlay
6236 string. (Bug#10119)
8c535114 6237
fa4fdb5c
JL
62382011-11-24 Juri Linkov <juri@jurta.org>
6239
6240 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6241 after the `MagickPingImage' call. (Bug#10112)
6242
90ec88df
CY
62432011-11-23 Chong Yidong <cyd@gnu.org>
6244
6245 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6246
56e2e794
MR
62472011-11-23 Martin Rudalics <rudalics@gmx.at>
6248
6249 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6250 making another buffer current. (Bug#10114)
6251
b6e64c41
GM
62522011-11-23 Glenn Morris <rgm@gnu.org>
6253
6254 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6255
6b21de18
CY
62562011-11-23 Chong Yidong <cyd@gnu.org>
6257
6258 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6259 using it (Bug#5984).
6260
b12cd789
EZ
62612011-11-22 Eli Zaretskii <eliz@gnu.org>
6262
6263 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6264 and header-lines, as they don't have one computed for them.
6265 (Bug#10098)
6266
6267 * .gdbinit (prow): Make displayed values more self-explaining.
6268 Add row's hash code.
6269
261b6fd4
LMI
62702011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6271
6272 * process.c (wait_reading_process_output): Fix asynchrounous
6273 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6274 (wait_reading_process_output): Add comment and URL.
261b6fd4 6275
e7cfd277
JD
62762011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6277
6278 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6279
a9b9b7f5
CY
62802011-11-21 Chong Yidong <cyd@gnu.org>
6281
6282 * window.c (Fnext_window, Fprevious_window): Doc fix.
6283
b0d15b4f
SM
62842011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6285
6286 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6287
fe7a3057
JB
62882011-11-20 Juanma Barranquero <lekktu@gmail.com>
6289
6290 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6291
d2999b1a
MR
62922011-11-20 Martin Rudalics <rudalics@gmx.at>
6293
6294 * window.c (Fset_window_combination_limit): Rename argument
6295 STATUS to LIMIT.
6296 (Vwindow_combination_limit): Remove "status" from doc-string.
6297
d5ff9cd0
AS
62982011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6299
6300 * m/ibms390.h: Remove.
6301 * m/ibms390x.h: Don't include "ibms390.h".
6302
a5bb9bd3
SM
63032011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6304
6305 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6306 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6307
cd1181db
JB
63082011-11-20 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * casetab.c (Fset_case_table):
6311 * charset.c (Fcharset_after): Fix typos.
6312
615a3b8d 63132011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6314
17e845af
PE
6315 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6316 Otherwise, valgrind does not work on some platforms.
6317 Problem reported by Andreas Schwab in
6a0bf43d
PE
6318 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6319 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6320 is set, removing the need for VIRT_ADDRESS_VARIES.
6321 (PURE_P): Use a more-efficient implementation that needs just one
6322 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6323 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6324 to 4 (xorl, subq, cmpq, setbe).
6325 * alloc.c (pure): Always extern now, since that's the
6326 VIRT_ADDR_VARIES behavior.
6327 (PURE_POINTER_P): Use a single comparison, not two, for
6328 consistency with the new puresize.h.
6329 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6330 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6331 Remove VIRT_ADDR_VARIES no longer needed.
6332
f8fe6f96
EZ
63332011-11-19 Eli Zaretskii <eliz@gnu.org>
6334
6335 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6336 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6337 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6338 behave as if the cursor position were at the window margin.
6339
6340 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6341 and the cursor position is out of bounds, behave as if the cursor
6342 position were at the window margin. (Bug#10075)
6343
df05a53c
CY
63442011-11-18 Chong Yidong <cyd@gnu.org>
6345
6346 * window.c (Fwindow_combination_limit): Make first argument
6347 non-optional, since it is meaningless for live windows like the
6348 selected window.
61ccba97 6349
2071918e
DA
63502011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6351
6352 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6353
b50a28de
SM
63542011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6355
6356 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6357 (graft_intervals_into_buffer): Simplify.
6358
015137db
EZ
63592011-11-18 Eli Zaretskii <eliz@gnu.org>
6360
6361 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6362 hash values of the two rows.
6363 (copy_row_except_pointers): Preserve the used[] arrays and the
6364 hash values of the two rows. (Bug#10035)
68c95424 6365 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6366
6367 * xdisp.c (row_hash): New function, body extracted from
6368 compute_line_metrics.
6369 (compute_line_metrics): Call row_hash, instead of computing the
6370 hash code inline.
6371
6372 * dispnew.c (verify_row_hash): Call row_hash for computing the
6373 hash code of a row, instead of duplicating code from xdisp.c.
6374
6375 * dispextern.h (row_hash): Add prototype.
6376
a2addb04
TH
63772011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6378
6379 * frame.c (delete_frame): Don't delete the terminal when the last
6380 X frame is closed if emacs is built with GTK toolkit.
6381
df85d315
JB
63822011-11-17 Juanma Barranquero <lekktu@gmail.com>
6383
6384 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6385
a0c2d0ae
MR
63862011-11-17 Martin Rudalics <rudalics@gmx.at>
6387
6388 * window.c (Vwindow_splits): Rename to
6389 Vwindow_combination_resize. Suggested by Juri Linkov.
6390 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6391 of Vwindow_splits.
6392
58179cce
JB
63932011-11-16 Juanma Barranquero <lekktu@gmail.com>
6394
7877f373
JB
6395 * nsfns.m (Fns_font_name):
6396 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6397
b6f67890
MR
63982011-11-16 Martin Rudalics <rudalics@gmx.at>
6399
6400 * window.h (window): Rename slot "nest" to "combination_limit".
6401 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6402 (Fset_window_nest): Rename to Fset_window_combination_limit.
6403 (Vwindow_nest): Rename to Vwindow_combination_limit.
6404 (recombine_windows, make_parent_window, make_window)
6405 (Fsplit_window_internal, saved_window)
6406 (Fset_window_configuration, save_window_save): Rename all
6407 occurrences of window_nest to window_combination_limit.
6408
c7015153
JB
64092011-11-15 Juanma Barranquero <lekktu@gmail.com>
6410
6411 * image.c (imagemagick_load_image): Fix typo.
6412
322ad6ec
EZ
64132011-11-14 Eli Zaretskii <eliz@gnu.org>
6414
6415 * xdisp.c (display_line): Move the call to
6416 highlight_trailing_whitespace before the call to
6417 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6418 faces of all the glyphs to compute ROW's hash value.
6419 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6420
f067b8ec
JB
64212011-11-14 Juanma Barranquero <lekktu@gmail.com>
6422
6423 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6424 just return (bug#10044).
6425
1e5b2111
EZ
64262011-11-12 Eli Zaretskii <eliz@gnu.org>
6427
7ef3cbd5
EZ
6428 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6429 with user-defined heap size. Bump the default size of the temacs
6430 heap to 27MB, to avoid memory warning when running temacs.
6431 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6432
1e5b2111
EZ
6433 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6434 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6435 (verify_row_hash) [XASSERTS]: New function.
6436 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6437 that the hash value of glyph rows is correct.
1e5b2111 6438
89d61221
MR
64392011-11-12 Martin Rudalics <rudalics@gmx.at>
6440
6441 * window.h (window): Remove splits slot.
6442 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6443 (Fdelete_other_windows_internal, make_parent_window)
6444 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6445 (Fset_window_configuration, save_window_save): Don't deal with
6446 split status of windows.
6447 (saved_window): Remove splits slot.
6448 (Vwindow_splits): Rewrite doc-string.
6449
97f18cc8
JD
64502011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6451
6452 * xfns.c (unwind_create_frame):
6453 * nsfns.m (unwind_create_frame):
6454 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6455 Vframe_list (Bug#9999).
6456
22a648b4
DA
64572011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6458
0b381c7e 6459 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6460
659afede
KH
64612011-11-11 Kenichi Handa <handa@m17n.org>
6462
6463 * callproc.c (Fcall_process): Set the member dst_multibyte of
6464 process_coding.
6465
9ac0394b
KH
64662011-11-11 Johan Bockgård <bojohan@gnu.org>
6467
6468 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6469 avoid a crash (bug#9496).
6470
2fbdc249
CY
64712011-11-09 Chong Yidong <cyd@gnu.org>
6472
6473 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6474 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6475
ac6b1f81
PE
64762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6477
6478 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6479
09db192c
PE
64802011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6481
6482 Avoid some portability problems by eschewing 'extern inline' functions.
6483 The trivial performance wins aren't worth the portability hassles; see
6484 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6485 et seq.
6486 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6487 (window_box_width, window_box_left, window_box_left_offset)
6488 (window_box_right, window_box_right_offset): Undo previous change,
6489 by removing the "extern"s.
6490 * intervals.c (adjust_intervals_for_insertion)
6491 (adjust_intervals_for_deletion): Undo previous change,
6492 making these static again.
6493 (offset_intervals, temp_set_point_both, temp_set_point)
6494 (copy_intervals_to_string): No longer inline.
6495 * xdisp.c (window_text_bottom_y, window_box_width)
6496 (window_box_height, window_box_left_offset)
6497 (window_box_right_offset, window_box_left, window_box_right)
6498 (window_box): No longer inline.
6499
105216ed
CY
65002011-11-08 Chong Yidong <cyd@gnu.org>
6501
6502 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6503 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6504 Signal an error if not a live window.
105216ed
CY
6505 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6506 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6507
ae9e237f
JB
65082011-11-07 Juanma Barranquero <lekktu@gmail.com>
6509
6510 * lisp.h (syms_of_abbrev): Remove declaration.
6511 Reported by CHENG Gao <chenggao@royau.me>.
6512
c7aa8333
EZ
65132011-11-07 Eli Zaretskii <eliz@gnu.org>
6514
6515 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6516 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6517 of temacs in GUI mode.
6518
be7f5545
MR
65192011-11-07 Martin Rudalics <rudalics@gmx.at>
6520
6521 * window.h: Declare delete_all_child_windows instead of
6522 delete_all_subwindows.
6523 * window.c (Fwindow_nest, Fset_window_nest)
6524 (Fset_window_new_total, Fset_window_new_normal)
6525 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6526 (delete_all_subwindows): Rename to delete_all_child_windows.
6527 (Fdelete_other_windows_internal, Fset_window_configuration):
6528 Call delete_all_child_windows instead of delete_all_subwindows.
6529 * frame.c (delete_frame): Call delete_all_child_windows instead
6530 of delete_all_subwindows.
6531
ca78dc43
PE
65322011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6533
6534 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6535 This is also needed for porting to any host where GC_MARK_STACK is
6536 not GC_MAKE_GCPROS_NOOPS.
6537 (which_symbols): Use it.
6538
a0241d01
KH
65392011-11-07 Kenichi Handa <handa@m17n.org>
6540
6541 * coding.c (coding_set_destination): Check coding->src_pos only
6542 when coding->src_object is a buffer (bug#9910).
6543
6544 * process.c (send_process): Set the member src_multibyte of coding
6545 to 0 (bug#9911) when sending a unibyte text.
6546
6547 * callproc.c (Fcall_process): Set the member src_multibyte of
6548 process_coding to 0 (bug#9912).
6549
a64bfdfa 65502011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6551
6552 * xmenu.c (cleanup_widget_value_tree): New function.
6553 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6554 calling free_menubar_widget_value_tree directly (Bug#9830).
6555
cb41b32a
PE
65562011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6557
6558 Fix some portability problems with 'inline'.
6559 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6560 (window_box_width, window_box_left, window_box_left_offset)
6561 (window_box_right, window_box_right_offset): Declare extern.
6562 Otherwise, these inline functions do not conform to C99 and
6563 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6564 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6565 * intervals.c (adjust_intervals_for_insertion)
6566 (adjust_intervals_for_deletion): Now extern, because otherwise the
6567 extern inline functions 'offset_intervals' couldn't refer to it.
6568 (static_offset_intervals): Remove.
6569 (offset_intervals): Rewrite using the old contents of
6570 static_offset_intervals. The old version didn't conform to C99
6571 because an extern inline function contained a reference to an
6572 identifier with static linkage.
6573
b7041366
AS
65742011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6575
6576 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6577 GC.
6578
88a37c4d
EZ
65792011-11-06 Eli Zaretskii <eliz@gnu.org>
6580
6581 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6582 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6583 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6584 return Qleft_to_right.
6585
49745b39
CY
65862011-11-06 Chong Yidong <cyd@gnu.org>
6587
6588 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6589 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6590 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6591 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6592 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6593 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6594 (Fwindow_vscroll): Doc fix.
6595 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6596 argument, since it makes no sense to pass a live window and for
6597 consistency with window-child.
6598
1f05cd82
CS
65992011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6600
6601 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6602 support MSVC.
6603
22610910
JR
66042011-11-05 Jason Rumney <jasonr@gnu.org>
6605
6606 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6607 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6608 fonts (Bug#6029).
6609 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6610 bitwise arithmetic preventing use of unicode-sip and non-truetype
6611 opentype fonts.
6612
a06776b2
EZ
66132011-11-05 Eli Zaretskii <eliz@gnu.org>
6614
3ad924ba
EZ
6615 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6616 "emacs"-only part.
6617
a06776b2
EZ
6618 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6619 initialization code to keep similarity to xfns.c after changes
6620 from 2011-11-05.
6621
c9e7db78
JD
66222011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6623
a97f8f3f
JD
6624 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6625 (unwind_create_frame): New function (Bug#9943).
6626 (Fx_create_frame): Restructure code to be more similar to the one in
6627 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6628 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6629 Move terminal->reference_count++ just before making the frame official
6630 (Bug#9943).
6631
6632 * nsterm.m (x_free_frame_resources): New function.
6633 (x_destroy_window): Move code to x_free_frame_resources.
6634
c9e7db78 6635 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6636 (Fx_create_frame, x_create_tip_frame):
6637 Move terminal->reference_count++ just before making the frame
75f1671a 6638 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6639 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6640
a6fc3b5c
EZ
66412011-11-05 Eli Zaretskii <eliz@gnu.org>
6642
6643 Support MSVC build with newer versions of Visual Studio.
6644 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6645 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6646 nt/gmake.defs.
6647
6648 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6649 which are not supported by MSVC.
6650 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6651 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6652 bitfields.
6653 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6654 types in bitfields.
6655 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6656
6657 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6658
58179cce 66592011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6660
6661 Support MSVC build with newer versions of Visual Studio.
6662 * w32.c: Don't include w32api.h for MSVC.
6663 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6664
6665 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6666 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6667 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6668 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6669 e_* cousins.
6670 (alloca) [_MSC_VER]: Define to _alloca.
6671
6672 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6673
6674 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6675
a58c13ed
EZ
66762011-11-04 Eli Zaretskii <eliz@gnu.org>
6677
6678 * xdisp.c (note_mouse_highlight): If either of
6679 previous/next-single-property-change returns nil, treat that as
6680 the beginning or the end of the buffer. (Bug#9955)
6681
fe0b6370
JD
66822011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6683
a58c13ed 6684 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6685 label is not null (Bug#9951).
6686 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6687 may be NULL.
6688
89bd5ee1
EZ
66892011-11-04 Eli Zaretskii <eliz@gnu.org>
6690
6691 * window.c (Fwindow_body_size): Mention in the doc string that the
6692 return value is in frame's canonical units. (Bug#9949)
6693
84c3edb9
EZ
66942011-11-03 Eli Zaretskii <eliz@gnu.org>
6695
4e2fb5c7
EZ
6696 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6697
84c3edb9 6698 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6699 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6700 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6701
bc17a887
EZ
67022011-11-01 Eli Zaretskii <eliz@gnu.org>
6703
6704 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6705 Don't stop backward scan on the continuation glyph, even though
6706 its CHARPOS is positive.
6d5eb5b0
SM
6707 (mouse_face_from_buffer_pos, note_mouse_highlight):
6708 Rename cover_string to disp_string.
bc17a887 6709
4ee88440
MR
67102011-11-01 Martin Rudalics <rudalics@gmx.at>
6711
6712 * window.c (temp_output_buffer_show): Don't use
6713 Vtemp_buffer_show_specifiers.
6714 (Vtemp_buffer_show_specifiers): Remove unused variable.
6715
c2ff3c02
EZ
67162011-10-30 Eli Zaretskii <eliz@gnu.org>
6717
6718 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6719 past the beginning of the current glyph matrix.
6720
58179cce 67212011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6722
6723 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6724 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6725 HAVE_GTK3 (Bug#9869).
b77a6a7f 6726
3b574623
JD
6727 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6728 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6729
b77a6a7f
JD
6730 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6731
6732 * xterm.c: Declare x_handle_net_wm_state to return int.
6733 (handle_one_xevent): Check if we are iconified but don't have
6734 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6735 (get_current_wm_state): Return non-zero if not hidden,
6736 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6737 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6738 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6739 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6740
196e41e4
PE
67412011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6742
6743 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6744 so that this new function doesn't get optimized away by a
6745 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6746
021f2e1a
AS
67472011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6748
6749 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6750
8b058d44
EZ
67512011-10-29 Eli Zaretskii <eliz@gnu.org>
6752
6753 Fix the `xbytecode' command.
6754 * .gdbinit (xprintbytestr): New command.
b50a28de 6755 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6756 (xbytecode): Print the byte-code string as well.
6757
4452fb80
EZ
67582011-10-29 Kim Storm <storm@cua.dk>
6759
8b058d44
EZ
6760 * alloc.c (which_symbols): New function.
6761
21b72067
AS
67622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6763
6764 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6765 line. (Bug#9903)
6766
83ed7b5c
GM
67672011-10-29 Glenn Morris <rgm@gnu.org>
6768
6769 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6770 Not clear what it was for, and it causes various bugs. (Bug#9839)
6771
5a7a728b
EZ
67722011-10-28 Eli Zaretskii <eliz@gnu.org>
6773
6774 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6775 possible random value that matches one of those tested as
6776 condition to clear the mouse face.
6777
d3d0842f
CY
67782011-10-28 Chong Yidong <cyd@gnu.org>
6779
6780 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6781
31b39d13
DN
67822011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6783
6784 * window.c (make_window): Initialize phys_cursor_on_p.
6785
9aba6043
SM
67862011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6787
6788 * lisp.h (struct Lisp_Symbol): Update comments.
6789
c20992f4
JB
67902011-10-28 Juanma Barranquero <lekktu@gmail.com>
6791
6792 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6793
db4f02f2
EZ
67942011-10-28 Eli Zaretskii <eliz@gnu.org>
6795
6796 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6797 <oslsachem@gmail.com> for helping to debug this.
6798
6799 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6800 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6801 (g_b_init_get_glyph_outline_w): New static variables.
6802 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6803 (GetGlyphOutlineW_Proc): New typedefs.
6804 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6805 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6806 New functions.
6807 (w32font_open_internal, compute_metrics):
6808 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6809 instead of calling the "wide" APIs directly.
6810
6811 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6812
6813 * w32.h (syms_of_w32font): Add prototype.
6814
87e68db4
JB
68152011-10-27 Juanma Barranquero <lekktu@gmail.com>
6816
6817 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6818 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6819 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6820 (Fmove_to_window_line): Doc fix.
6821
435c1d67
CY
68222011-10-27 Chong Yidong <cyd@gnu.org>
6823
6824 * process.c (make_process): Set gnutls_state to NULL.
6825
6826 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6827 non-NULL, regardless of GNUTLS_INITSTAGE.
6828 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6829 an error. Set process slots as soon as we allocate them.
6830
6831 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6832
9c6c6f49
CY
68332011-10-27 Chong Yidong <cyd@gnu.org>
6834
9aba6043
SM
6835 * gnutls.c (emacs_gnutls_deinit): New function.
6836 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6837 (Fgnutls_deinit, Fgnutls_boot): Use it.
6838
6839 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6840 (deactivate_process): Call emacs_gnutls_deinit.
6841
657d08d3
JB
68422011-10-27 Juanma Barranquero <lekktu@gmail.com>
6843
6844 * image.c (x_create_x_image_and_pixmap):
6845 * w32.c (sys_rename, w32_delayed_load):
6846 * w32font.c (fill_in_logfont):
6847 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6848
5430d399
JB
68492011-10-26 Juanma Barranquero <lekktu@gmail.com>
6850
6851 * w32fns.c (w32_default_color_map): New function,
6852 extracted from Fw32_default_color_map.
a7ef684b 6853 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6854
fe0055fa
PE
68552011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6856
6857 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6858
e6346438
SM
68592011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6860
6861 * keyboard.c (test_undefined): New function (bug#9751).
6862 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6863
e112cc37
ET
68642011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6865
6866 * sysdep.c (init_sys_modes): Fix the check for the controlling
6867 terminal (Bug#6649).
6868
7b5d6677
EZ
68692011-10-20 Eli Zaretskii <eliz@gnu.org>
6870
6871 * dispextern.h (struct bidi_it): New member next_en_type.
6872
6873 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6874 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6875 current character, check also for next_en_type being WEAK_EN.
6876 (bidi_resolve_weak): Don't enter the expensive loop if the current
6877 position is before next_en_pos. Record the bidi type of the first
6878 non-ET, non-BN character we find, in addition to its position.
6879 (bidi_level_of_next_char): Invalidate next_en_type when
6880 next_en_pos is over-stepped.
6881
7da0b018
PE
68822011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6883
6884 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6885 * editfns.c: Rewrite current-time-zone so that it invokes
6886 the equivalent of (format-time-string "%Z") to get the time zone name.
6887 This fixes a bug when the time zone name contains characters that
6888 need converting from the system time locale to Emacs internal format.
6889 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6890 that patch fixed format-time-string to do the conversion, but
6891 I forgot to fix current-time-zone.
6892 (format_time_string): New function, containing most of
6893 what Fformat_time_string used to contain.
6894 (Fformat_time_string): Rewrite in terms of format_time_string.
6895 This doesn't change this function's behavior.
6896 (current-time-zone): Rewrite to use format_time_string.
6897 This fixes the bug reported by Michael Schierl in
6898 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6899 Jason Rumney's 2007-06-07 change worked around this bug, but
6900 didn't fix it.
6901 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6902
8547b010
EZ
69032011-10-19 Eli Zaretskii <eliz@gnu.org>
6904
6905 * xdisp.c (start_display): If the character at POS is displayed
6906 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6907 (try_window_reusing_current_matrix): If a line ends in a display
6908 vector or the next line starts in a display vector, continue
6909 redrawing the window even though the character position of
6910 start_row was reached.
8547b010
EZ
6911 (Bug#9771, part 2)
6912
4e948d15
CY
69132011-10-18 Chong Yidong <cyd@gnu.org>
6914
6915 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6916 with nobreak-char-display too.
6917
4787455f
EZ
69182011-10-18 Eli Zaretskii <eliz@gnu.org>
6919
6920 Fix part 3 of bug#9771.
6921 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6922 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6923 non-neutral characters if the current character is a paragraph
6924 separator (a.k.a. Newline). This avoids running the same
6925 expensive loop twice, once when we consume the preceding newline
6926 and the other time when the line actually needs to be displayed.
6927 Avoid the loop when we see neutrals on the base embedding level
6928 following a character whose directionality is the same as the
6929 paragraph's. This avoids running the expensive loop when a line
6930 ends in a long sequence of neutrals, like control characters.
6931 Add assertion against STRONG_AL type. Slightly rearrange code
6932 that determines the type of a neutral given the first non-neutral
6933 that follows it.
6934 (bidi_level_of_next_char): Set next_en_pos to zero when
6935 invalidating its info.
6936
2c91f553
EZ
69372011-10-17 Eli Zaretskii <eliz@gnu.org>
6938
6939 * xdisp.c (push_display_prop): Determine whether to record string
6940 or buffer position by IT->string, not by IT->method. Allow
6941 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6942 (move_it_vertically_backward): Don't look for character position
6943 immediately after the newline when in a continuation line.
6944 (Bug#9771, part 1)
2c91f553 6945
c7b08b0d
MR
69462011-10-15 Martin Rudalics <rudalics@gmx.at>
6947
6948 * window.c (coordinates_in_window): Rewrite and delabelize
6949 vertical border check. (Bug#5357) (Bug#9618)
6950
6b02f655
SM
69512011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6952
6953 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6954 errors in XSetWindowBorder (bug#9310).
6955
81d40c92
DA
69562011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6957
6958 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6959 avoid crash when xmalloc overrun checking is enabled.
6960
d4172c3b
EZ
69612011-10-13 Eli Zaretskii <eliz@gnu.org>
6962
6963 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6964 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6965 cursor motion with <left> and <right> arrow keys.
6966
6967 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6968 some callers set that themselves.
6969
b00eea75
EZ
69702011-10-12 Eli Zaretskii <eliz@gnu.org>
6971
6972 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6973 display string and the previous row comes from the same string and
6974 is empty. (Bug#9739) (Bug#9738)
6975
8fe012c4
SM
69762011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6977
6978 * doc.c (get_doc_string): Encode file name (bug#9735).
6979
0074aef2
EZ
69802011-10-12 Eli Zaretskii <eliz@gnu.org>
6981
79beb178
EZ
6982 * bidi.c (bidi_level_of_next_char):
6983 * xdisp.c (get_visually_first_element): Remove old incorrect
6984 comments regarding the Unicode Line Separator character.
6985
0074aef2
EZ
6986 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6987
6e4b3fbe
DA
69882011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6989
6990 * alloc.c (Fgc_status): Do not access beyond zombies array
6991 boundary if nzombies > MAX_ZOMBIES.
6992 * alloc.c (dump_zombies): Add missing format specifier.
6993
0324f3af
PE
69942011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6995
b5525cac
PE
6996 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6997 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6998
0324f3af
PE
6999 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7000 Some packages use them to denote characters with modifiers.
7001
e9b5f888
AS
70022011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7003
7004 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7005 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7006 matching a pp-number. Rename parameter var to var1.
7007
127827c0
SM
70082011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7009
7010 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7011
c8fd3bd0
GM
70122011-10-08 Glenn Morris <rgm@gnu.org>
7013
7014 * callint.c (Fcall_interactively): Give a more explicit error for the
7015 'c' case with a non-character input. (Bug#8479)
7016
352ec8ff
EZ
70172011-10-08 Eli Zaretskii <eliz@gnu.org>
7018
03669ccb
EZ
7019 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7020 lines.
7061c986
EZ
7021 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7022 lines that are hscrolled on the left.
03669ccb 7023
352ec8ff
EZ
7024 * dispnew.c (buffer_posn_from_coords): Account for a possible
7025 presence of header-line. (Bug#4426)
7026
a66cfb1c
SM
70272011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7028
6b02f655
SM
7029 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7030 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7031
7c5ee88e
PE
70322011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7033
7034 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7035 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7036 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7037 this makes Emacs dump core during garbage collection on rare
7038 occasions. sizeof is obviously inferior to offsetof here, so
7039 stick with offsetof.
7040 (GC_POINTER_ALIGNMENT): New macro.
7041 (mark_memory): Omit 3rd (offset) arg; caller changed.
7042 Don't assume EMACS_INT alignment is the same as pointer alignment.
7043
df1bbe5b
SM
70442011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7045
7046 * keyboard.c (read_key_sequence_remapped): New var.
7047 (read_key_sequence): Compute remapping in the right buffer.
7048 (command_loop_1): Use read_key_sequence's remapping directly.
7049
51553db6
SM
70502011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7051
32c1fffd
SM
7052 * dired.c (file_name_completion): Don't expand file name.
7053 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7054 before checking file name handler.
7055
51553db6
SM
7056 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7057 they've been requested explicitly (bug#9591).
7058
b6bd1599 70592011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7060
7061 * keymap.c (Fsingle_key_description): Use make_specified_string
7062 instead of build_string to build string from push_key_description.
7063 (Bug#5193)
7064
f701dc2a
PE
70652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7066
4222c55d
PE
7067 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7068 This fixes a Y2038 bug on 64-bit hosts.
7069 * buffer.c (reset_buffer):
7070 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7071 (Fclear_buffer_auto_save_failure):
7072 Use 0, not -1, to represent an unset failure time, since time_t
7073 might not be signed.
7074
f701dc2a
PE
7075 Remove dependency on glibc malloc internals.
7076 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7077 Move back here from lisp.h, but with their new implementations.
7078 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7079 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7080 * charset.c (charset_table_init): New static var.
7081 (syms_of_charset): Use it instead of xmalloc. This removes a
7082 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7083 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7084 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7085 Move back to alloc.c.
7086 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7087 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7088
9ceebf39
JD
70892011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7090
7091 * nsterm.m (windowDidResize): Call x_set_window_size only when
7092 ns_in_resize is true. Otherwise set pixelwidth/height and
7093 call change_frame_size (Bug#9628).
7094
cb993c58
PE
70952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7096
3930c88b
PE
7097 Port --enable-checking=all to Fedora 14 x86-64.
7098 * charset.c (syms_of_charset): Also account for glibc malloc's
7099 internal overhead when calculating the initial malloc maximum.
7100
cb993c58
PE
7101 Port --enable-checking=all to Fedora 14 x86.
7102 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7103 Move to lisp.h.
7104 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7105 (overrun_check_realloc, overrun_check_free):
7106 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7107 That way, xmalloc returns a properly-aligned pointer even if
7108 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7109 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7110 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7111 into account when calculating the initial malloc maximum.
7112 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7113 Move here from alloc.c, so that charset.c can use it too.
7114 Properly align; the old code wasn't right for common 32-bit hosts
7115 when configured with --enable-checking=all.
7116 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7117 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7118
31bed486
EZ
71192011-09-29 Eli Zaretskii <eliz@gnu.org>
7120
04c70788 7121 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7122 use EDOM.
7123
fbcaa2f3
EZ
71242011-09-28 Eli Zaretskii <eliz@gnu.org>
7125
7126 * xdisp.c (compute_display_string_end): If there's no display
7127 string at CHARPOS, return -1.
7128
7129 * bidi.c (bidi_fetch_char): When compute_display_string_end
7130 returns a negative value, treat the character as a normal
7131 character not covered by a display string. (Bug#9624)
7132
a239d4e9
JB
71332011-09-28 Juanma Barranquero <lekktu@gmail.com>
7134
7135 * lread.c (Fread_from_string): Fix typo in docstring.
7136
88652fd5
EZ
71372011-09-27 Eli Zaretskii <eliz@gnu.org>
7138
7139 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7140 newline, reseat the iterator instead of bidi-iterating there one
7141 character at a time. (Bug#9610)
32c1fffd
SM
7142 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7143 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7144
ed497dd4
AS
71452011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7146
7147 * lread.c (readevalloop): Use correct code for NBSP.
7148 (read1): Likewise. (Bug#9608)
7149
b2bf61aa
MA
71502011-09-25 Michael Albinus <michael.albinus@gmx.de>
7151
7152 * dbusbind.c (Fdbus_register_signal): When service is not
7153 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7154
32bbb17c
GM
71552011-09-25 Glenn Morris <rgm@gnu.org>
7156
7157 * buffer.c (truncate-lines): Doc fix.
7158
94e0933e
CY
71592011-09-24 Chong Yidong <cyd@stupidchicken.com>
7160
7161 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7162 (Fset_window_next_buffers): Doc fix.
7163
cddde921
GM
71642011-09-24 Glenn Morris <rgm@gnu.org>
7165
7166 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7167
1260aef1
PE
71682011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7169
25b4bfa0
PE
7170 Fix minor problems found by static checking.
7171 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7172 * indent.c (Fvertical_motion): Fix == vs = typo.
7173
e3cbd34b
EZ
71742011-09-24 Eli Zaretskii <eliz@gnu.org>
7175
a66cfb1c
SM
7176 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7177 Default value is now t. Doc fix.
6bf7006f 7178
e3cbd34b 7179 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7180 logic when moving up, not only when moving down. Fix the
e3cbd34b 7181 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7182 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7183
7184 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7185 CHARPOS is covered by a display string which includes newlines.
7186 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7187 is covered by a display string with embedded newlines.
7188
a3de0cbd
MA
71892011-09-24 Michael Albinus <michael.albinus@gmx.de>
7190
7191 * dbusbind.c (Fdbus_register_signal): Add match rule to
7192 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7193 (Fdbus_register_method, Vdbus_registered_objects_table):
7194 Fix docstring.
a3de0cbd 7195
b260039d
JM
71962011-09-24 Jim Meyering <meyering@redhat.com>
7197
32c1fffd 7198 do not ignore write error for any output size
b260039d
JM
7199 The previous change was incomplete.
7200 While it makes emacs --batch detect the vast majority of stdout
7201 write failures, errors were still ignored whenever the output size is
7202 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7203 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7204 && echo FAIL: ignored write error
7205 FAIL: ignored write error
7206 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7207 && echo FAIL: ignored write error
7208 FAIL: ignored write error
7209 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7210
8eca8a7c
AS
72112011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7212
7213 * emacs.c (Fkill_emacs): In noninteractive mode exit
7214 non-successfully if a write error occurred on stdout. (Bug#9574)
7215
3341db62
EZ
72162011-09-21 Eli Zaretskii <eliz@gnu.org>
7217
7218 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7219 the xassert test.
7220
7221 * dispextern.h (struct it): Update the comment documenting what
7222 can it->OBJECT be.
7223
8c203dbf
EZ
72242011-09-20 Eli Zaretskii <eliz@gnu.org>
7225
7226 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7227 a display string, extend search for cursor position to end of row.
7228 (find_row_edges): If the row ends in a newline from a display
7229 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7230 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7231 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7232 non-empty line. Fixes confusing cursor motion with arrow keys at
7233 the beginning of a line that starts with whitespace.
8c203dbf 7234
a4824228
LMI
72352011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7236
7237 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7238 (bug#9493).
7239
33ed493b
CY
72402011-09-18 Chong Yidong <cyd@stupidchicken.com>
7241
7242 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7243 boolean (Bug#9154).
7244
56cd55c8
EZ
72452011-09-18 Eli Zaretskii <eliz@gnu.org>
7246
7247 * xdisp.c (display_line): Record maximum and minimum buffer
7248 positions even if no glyphs were produced (e.g., by a zero-width
7249 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7250 buffer positions that will be removed from the glyph row because
7251 they don't fit.
c02dcedf
EZ
7252 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7253 column is beyond frame width: don't subtract 1 "pixel" when
7254 computing width of the stretch.
3e62b7e0
EZ
7255 (reseat_at_next_visible_line_start): Undo the change made on
7256 2011-09-17 that saved paragraph information and restored it after
7257 the call to `reseat'. (Bug#9545)
56cd55c8 7258
5ed99d36 72592011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7260
7261 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7262 and turn window cursor on if cleared (Bug#9415).
7263
5ed99d36 72642011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7265
7266 * search.c (boyer_moore): Take unibyte characters from pattern
7267 literally. (Bug#9458)
7268
9bade7b2
EZ
72692011-09-18 Eli Zaretskii <eliz@gnu.org>
7270
7271 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7272
e5e9d610
PE
72732011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7274
87e4427a
PE
7275 Fix minor problem found by static checking.
7276 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7277 initialized, to pacify gcc -Wuninitialized.
7278
e5e9d610
PE
7279 * fileio.c: Report proper errno when syscall falls.
7280 (Finsert_file_contents): Save and restore errno,
7281 so that report_file_error outputs the correct diagnostic.
7282 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7283
a1674f0b
EZ
72842011-09-18 Eli Zaretskii <eliz@gnu.org>
7285
7286 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7287
fbfb6dd4
EZ
72882011-09-17 Eli Zaretskii <eliz@gnu.org>
7289
7290 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7291 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7292
bb187662
EZ
72932011-09-17 Eli Zaretskii <eliz@gnu.org>
7294
1137e8b8 7295 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7296 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7297
7298 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7299 (bidi_find_paragraph_start): Search back for paragraph beginning
7300 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7301 (bidi_move_to_visually_next): Only trigger paragraph-related
7302 computations when the last character is a newline or at EOB, not
7303 just any NEUTRAL_B. (Bug#9470)
7304
bb187662
EZ
7305 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7306 truncated lines if point is covered by a display string. (Bug#9524)
7307
2e621251
PE
73082011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7309
7310 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7311 (cons_to_x_long): New function.
7312 (lisp_data_to_selection_data): Use it. Correct the test for
7313 short-versus-long data; it was negated. Break out of vector
7314 loop, for efficiency, when a long datum is discovered.
7315
91a15bc6
SM
73162011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7317
7318 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7319
b41c3a35
EZ
73202011-09-16 Eli Zaretskii <eliz@gnu.org>
7321
7322 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7323 GCC PR/17406) by declaring this function with external scope.
7324
7812ba2d
PE
73252011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7326
7327 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7328 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7329
cf7edc2a
AS
73302011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7331
7332 * editfns.c (Fformat): Correctly handle text properties on "%%".
7333
bd01620e
EZ
73342011-09-15 Eli Zaretskii <eliz@gnu.org>
7335
7336 * xterm.c (x_draw_composite_glyph_string_foreground):
7337 * w32term.c (x_draw_composite_glyph_string_foreground):
7338 * term.c (encode_terminal_code):
7339 * composite.c (composition_update_it, get_composition_id):
7340 * xdisp.c (get_next_display_element)
7341 (fill_composite_glyph_string): Add comments about special meaning
7342 of TAB characters in a composition.
7343
a02719a3
PE
73442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7345
7346 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7347 This occurs when processing a multibyte format.
7348 Problem reported by Wolfgang Jenker.
a02719a3 7349
72589a3c
JB
73502011-09-15 Johan Bockgård <bojohan@gnu.org>
7351
7352 * xdisp.c (try_cursor_movement): Only check for exact match if
7353 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7354
1c14176c
PE
73552011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7356
7357 Remove unused external symbols.
7358 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7359 * xdisp.c (calc_pixel_width_or_height): Now static.
7360 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7361 * indent.c (check_display_width):
7362 * w32term.c: Fix comment to match code.
7363 * xterm.c, xterm.h (x_catching_errors): Remove.
7364
d2eea5b5
PE
73652011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7366
7367 * xselect.c: Use signed conversions more consistently (Bug#9498).
7368 (selection_data_to_lisp_data): Assume incoming selection data are
7369 signed integers, not unsigned. This is to be consistent with
7370 outgoing selection data, which was modified to use signed integers
7371 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7372 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7373 expects long, not unsigned long.
7374
46888499
EZ
73752011-09-14 Eli Zaretskii <eliz@gnu.org>
7376
7377 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7378 computation of loop end. Reported by Johan Bockgård
7379 <bojohan@gnu.org>.
7380
ef8ef9fb
CY
73812011-09-13 Chong Yidong <cyd@stupidchicken.com>
7382
7383 * frame.c (Fother_visible_frames_p): Function deleted.
7384
fa819fed
EZ
73852011-09-12 Eli Zaretskii <eliz@gnu.org>
7386
7387 * indent.c (compute_motion): Process display vector front to back
7388 rather than the other way around. (Bug#2496)
7389
2ba8e008
SM
73902011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7391
7392 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7393
20f53c69
CY
73942011-09-11 Chong Yidong <cyd@stupidchicken.com>
7395
7396 * minibuf.c (Fread_from_minibuffer): Doc fix.
7397
d562d7a4
EZ
73982011-09-11 Eli Zaretskii <eliz@gnu.org>
7399
7400 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7401 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7402
1c4d7f3d
LMI
74032011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7404
7405 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7406 value for non-existent files.
7407
b885bf36
EZ
74082011-09-11 Eli Zaretskii <eliz@gnu.org>
7409
7410 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7411 set its "size" to -1. This will set the modtime_size field of
7412 the corresponding buffer to -1, which is what
7413 verify-visited-file-modtime expects for files that do not exist.
7414 (Bug#9139)
7415
6612f0bf
PE
74162011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7417
7418 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7419 here ...
7420 * lisp.h: ... from here. push_key_description is no longer
7421 defined in keyboard.c, so its declaration should not be in
7422 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7423 logically belongs with push_key_description.
7424
dfb3f755
PE
74252011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7426
7427 * buffer.h: Include <sys/types.h> instead of <time.h>.
7428 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7429 Problem reported by Herbert J. Skuhra.
7430
3134906c
LMI
74312011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7432
7433 * xml.c (parse_region): Make the parsing work for
7434 non-comment-starting XML files again (bug#9144).
7435
8d903f4e
AS
74362011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7437
7438 * image.c (gif_load): Fix calculation of bottom and right corner.
7439 (Bug#9468)
7440
80ad64f4
EZ
74412011-09-10 Eli Zaretskii <eliz@gnu.org>
7442
7443 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7444 redisplay in small windows.
7445
208a048d
EZ
74462011-09-09 Eli Zaretskii <eliz@gnu.org>
7447
7448 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7449
9b1c252e
MR
74502011-09-08 Martin Rudalics <rudalics@gmx.at>
7451
7452 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7453 Operate on live windows only.
7454
2949f33b
JB
74552011-09-08 Juanma Barranquero <lekktu@gmail.com>
7456
7457 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7458
e08dcafd
EZ
74592011-09-07 Eli Zaretskii <eliz@gnu.org>
7460
7461 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7462 only under bidi iteration.
7463
115b96bd
JD
74642011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7465
7466 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7467
c8199d0f
PE
74682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7469
7470 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7471 Without this fix, the command to link temacs failed due to an
7472 undefined symbol __builtin_isnan. This is because
7473 /usr/include/iso/math_c99.h #defines isnan(x) to
7474 __builtin_isnan(x), but the bundled gcc, which identifies itself
7475 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7476 a __builtin_isnan.
7477 * floatfns.c (isnan): #undef, and then #define to a clone of
7478 what's in data.c.
7479 (Fisnan): Always define, since it's always available now.
7480 (syms_of_floatfns): Always define isnan at the Lisp level.
7481
e39b275c 74822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7483
7484 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7485
b2db44d9 74862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7487
f4af5137 7488 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7489 The previous code assumed that file offsets (off_t values) fit in
7490 EMACS_INT variables, which is not true on typical 32-bit hosts.
7491 The code messed up by falsely reporting buffer overflow in cases
7492 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7493 when "big" contains more than 2**29 bytes, even though this
7494 inserts just one byte and does not overflow the buffer.
7495 (Finsert_file_contents): Store file offsets as off_t
7496 values, not as EMACS_INT values. Check for overflow when
7497 converting between EMACS_INT and off_t. When checking for
7498 buffer overflow or for overlap, take the offsets into account.
7499 Don't use EMACS_INT for small values where int suffices.
7500 When checking for overlap, fix a typo: ZV was used where
7501 ZV_BYTE was intended.
7502 (Fwrite_region): Don't assume off_t fits into 'long'.
7503 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7504
ecfc0a49
MA
75052011-09-05 Michael Albinus <michael.albinus@gmx.de>
7506
7507 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7508
6511acf2 75092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7510
0999621a 7511 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7512
7513 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7514 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7515 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7516 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7517 (modify_event_symbol): Do not assume that the length of
7518 name_alist_or_stem is safe to alloca and fits in int.
7519 (Fexecute_extended_command): Likewise for function name and binding.
7520 (Frecursion_depth): Wrap around reliably on integer overflow.
7521 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7522 since some callers pass EMACS_INT values.
7523 (Fsingle_key_description): Don't crash if symbol name contains more
7524 than MAX_ALLOCA bytes.
7525 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7526 (get_minibuffer): Arg is now EMACS_INT, not int.
7527 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7528 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7529 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7530
2be7d702
PE
7531 * dbusbind.c (signature_cat): New function.
7532 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7533 Do not overrun buffer; instead, report string overflow.
7534
9d1df220
PE
7535 * dispnew.c (add_window_display_history): Don't overrun buffer.
7536 Truncate instead; this is OK since it's just a log.
7537
33ef5c64
PE
7538 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7539 even if the time zone offset is outlandishly large.
7540 Don't mishandle offset == INT_MIN.
7541
66c6fdd5
PE
7542 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7543 when creating daemon; the previous buffer-overflow check was incorrect.
7544
d749b01b
PE
7545 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7546 which has the guts of the old verror function.
7547
b5cd1905
PE
7548 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7549 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7550
6e1a67fb
PE
7551 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7552 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7553 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7554 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7555 length of string rather than counting it via multiple sprintfs;
7556 that's simpler and more reliable.
c21721cc
PE
7557 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7558 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7559 sprintf, in case result does not fit in int.
7560
c57b67fc
PE
7561 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7562 (fontset_from_font): Print it.
7563
8a401434
PE
7564 * frame.c (tty_frame_count): Now printmax_t, not int.
7565 (make_terminal_frame, set_term_frame_name): Print it.
7566 (x_report_frame_params): In X, window IDs are unsigned long,
7567 not signed long, so print them as unsigned.
7568 (validate_x_resource_name): Check for implausibly long names,
7569 and don't assume name length fits in 'int'.
7570 (x_get_resource_string): Don't blindly alloca invocation name;
7571 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7572 not fit in int.
7573
6e1a67fb
PE
7574 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7575 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7576 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7577
0df02bf3
PE
7578 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7579 Use esprintf, not sprintf, in case result does not fit in int.
7580
48e30793
PE
7581 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7582 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7583 it as a large positive number.
7584 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7585 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7586
a66ff6d8
PE
7587 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7588 in case result does not fit in int.
7589
aca216ff
PE
7590 * print.c (float_to_string): Detect width overflow more reliably.
7591 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7592 buffer overrun. Don't assume list length fits in 'int'. Treat
7593 print length of 0 as 0, not as infinity; to be consistent with other
7594 uses of print length in this function. Don't overflow print length
7595 index. Don't assume hash table size fits in 'long', or that
7596 vectorlike size fits in 'unsigned long'.
7597
31c286f7
PE
7598 * process.c (make_process): Use printmax_t, not int, to format
7599 process-name gensyms.
7600
55e5faa1
PE
7601 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7602
80f2e268
PE
7603 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7604 to avoid potential buffer overrun.
7605
670741ab
PE
7606 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7607 if X resource line is longer than 512 bytes.
7608
b7163a50
PE
7609 * xfns.c (x_window): Make sprintf buffer a bit bigger
7610 to avoid potential buffer overrun.
7611
ae58ff1f
PE
7612 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7613
c43c8a6a
PE
7614 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7615
3f8236f4
PE
76162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7617
53e9fe90 7618 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7619 Without these, Emacs silently mishandles large integers sometimes.
7620 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7621 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7622
6511acf2
PE
7623 * xdisp.c (try_window_id): Check Emacs fixnum range before
7624 converting to 'int'.
806add1d 7625
6511acf2 7626 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7627 Check that an Emacs fixnum is in range before assigning it to 'int'.
7628 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7629 values converted from Emacs fixnums.
7630 (Frecenter): Don't wrap around a line count if it is out of 'int'
7631 range; instead, treat it as an extreme value.
7632 (Fset_window_configuration, compare_window_configurations):
7633 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7634
6511acf2
PE
7635 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7636 that can exceed INT_MAX. Check that EMACS_INT value is in range
7637 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7638 (match_limit): Don't assume that a fixnum can fit in 'int'.
7639
6511acf2 7640 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7641 exceed INT_MAX.
7642
6511acf2 7643 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7644 (Fvertical_motion): Don't wrap around LINES values that don't fit
7645 in 'int'. Instead, treat them as extreme values. This is good
7646 enough for windows, which can't have more than INT_MAX lines anyway.
7647
fcb901a7
LMI
76482011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7649
0f2f6b6d
LMI
7650 * Require libxml/parser.h to avoid compilation warning.
7651
fcb901a7
LMI
7652 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7653
7654 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7655 since this reportedly can destroy thread storage.
7656
6e20a0d4
CY
76572011-08-30 Chong Yidong <cyd@stupidchicken.com>
7658
7659 * syntax.c (find_defun_start): Update all cache variables if
7660 exiting early (Bug#9401).
7661
148ae00e
EZ
76622011-08-30 Eli Zaretskii <eliz@gnu.org>
7663
f6cfbd8f
EZ
7664 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7665
148ae00e
EZ
7666 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7667 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7668 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7669
7670 * term.c (tty_append_glyph): New function.
7671 (produce_stretch_glyph): Static function and its prototype deleted.
7672
a66cfb1c
SM
7673 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7674 Add prototypes.
148ae00e 7675
c4a07a4c
PE
76762011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7677
7678 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7679 when checking :margin (Bug#9390).
7680 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7681 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7682 so that the name doesn't mislead. All uses changed.
7683
6bc8cd65
JB
76842011-08-28 Johan Bockgård <bojohan@gnu.org>
7685
7686 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7687 set_tty_hooks.
7688
dca4927e
EZ
76892011-08-27 Eli Zaretskii <eliz@gnu.org>
7690
7691 * xdisp.c (move_it_to): Don't bail out early when reaching
7692 position beyond to_charpos, if we are scanning backwards.
7693 (move_it_vertically_backward): When DY == 0, make sure we get to
7694 the first character in the line after the newline.
7695
f2cad773
PE
76962011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7697
7698 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7699 (ccl_driver): Do not generate an out-of-range pointer.
7700 (Fccl_execute_on_string): Remove unnecessary check for
7701 integer overflow, noted by Stefan Monnier in
7702 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7703 Remove a FIXME that didn't need fixing.
7704 Simplify the newly-introduced buffer reallocation code.
7705
0cae2cdb
JB
77062011-08-27 Juanma Barranquero <lekktu@gmail.com>
7707
7708 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7709
5fc295a4 77102011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7711
70c60eb2 7712 Integer and memory overflow issues (Bug#9196).
726e0ab1 7713
d31850da
PE
7714 * doc.c (get_doc_string): Rework so that
7715 get_doc_string_buffer_size is the actual buffer size, rather than
7716 being 1 less than the actual buffer size; this makes xpalloc more
7717 convenient.
7718
a69fbedb
PE
7719 * image.c (x_allocate_bitmap_record, cache_image):
7720 * xselect.c (Fx_register_dnd_atom):
7721 Simplify previous changes by using xpalloc.
7722
fe5c5d37
PE
7723 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7724 since either will do and ptrdiff_t is convenient with xpalloc.
7725
0065d054
PE
7726 * charset.c (charset_table_size)
7727 (struct charset_sort_data.priority): Now ptrdiff_t.
7728 (charset_compare): Don't overflow if priorities differ greatly.
7729 (Fsort_charsets): Don't assume list length fits in int.
7730 Check for size-calculation overflow when allocating sort data.
7731 (syms_of_charset): Allocate an initial charset table that is
7732 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7733
7734 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7735
7736 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7737 The actual value is always <= INT_MAX, and leaving it unsigned made
7738 overflow checking harder.
7739
7740 * dispextern.h (struct glyph_matrix.rows_allocated)
7741 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7742 with xpalloc. The values are still always <= INT_MAX.
7743
7744 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7745
7746 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7747 (SAFE_NALLOCA): New macro.
7748
7749 * region-cache.c (struct boundary.pos, find_cache_boundary)
7750 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7751 (set_cache_region, invalidate_region_cache)
7752 (revalidate_region_cache, know_region_cache, region_cache_forward)
7753 (region_cache_backward, pp_cache):
7754 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7755 so that ptrdiff_t * can be passed to xpalloc.
7756 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7757 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7758 (pp_cache): Don't assume cache_len fits in int.
7759 * region-cache.h: Adjust extern decls to match.
7760
7761 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7762 EMACS_INT, since either will do, for xpalloc.
7763
7764 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7765 (xnmalloc, xnrealloc, xpalloc): New functions.
7766
726e0ab1
PE
7767 * bidi.c (bidi_shelve_header_size): New constant.
7768 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7769 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7770
51f30bc5 7771 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7772 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7773 (overlay_strings):
7774 Don't update size of array until after memory allocation succeeds,
7775 because xmalloc/xrealloc may not return.
0065d054
PE
7776 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7777 now that we have proper integer overflow checking.
7778 (record_overlay_string, overlay_strings): Catch overflows when
7779 calculating size of overlay_str_buf.
726e0ab1 7780
0065d054
PE
7781 * callproc.c (Fcall_process): Check for size overflow when
7782 calculating size of args2.
7783 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7784 Normally we prefer signed values, but sticking with ptrdiff_t would
7785 require adding more-complicated checks.
726e0ab1
PE
7786
7787 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7788 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7789 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7790 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7791
7792 * character.c (Fstring): Check for size-calculation overflow.
7793
7794 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7795 unnecessary integer overflow. Check for size overflow.
7796 (encode_coding_object): Don't update size until xmalloc succeeds.
7797
7798 * composite.c (get_composition_id): Check for overflow in glyph
7799 length calculations.
7800
7801 Integer and memory overflow fixes for display code.
7802 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7803 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7804 (scrolling_window): Check for overflow in size calculations.
7805 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7806 Don't assume glyph table len fits in int.
7807 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7808 (row_table_size): Now ptrdiff_t, not int.
7809 (scrolling_window): Avoid overflow in size calculations.
7810 Don't update size until allocation succeeds.
7811 * fns.c (concat): Check for overflow in size calculations.
7812 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7813 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7814 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7815
7816 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7817 (get_doc_string): Check for size calculation overflow.
7818 Don't update size until allocation succeeds.
7819 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7820 EMACS_INT, where ptrdiff_t will do.
7821 (Fsubstitute_command_keys): Check for string overflow.
7822
7823 * editfns.c (set_time_zone_rule): Don't assume environment length
7824 fits in int.
7825 (message_length): Now ptrdiff_t, not int.
7826 (Fmessage_box): Don't update size until allocation succeeds.
7827 Don't assume message length fits in int.
7828 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7829
0065d054
PE
7830 * emacs.c (main): Do not reallocate argv, since there is a null at
7831 the end that can be overwritten, and this way there's no need to
7832 worry about size-calculation overflow.
7833 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7834
7835 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7836 alloc succeeds.
7837 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7838
7839 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7840 (x_set_scroll_bar_width, x_figure_window_size):
7841 Check for integer overflow.
7842 (x_set_alpha): Do not assume XINT fits in int.
7843
7844 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7845 This is for the members text_lines, text_cols, total_lines, total_cols,
7846 where the system imposes an 'int' limit.
7847
7848 * fringe.c (Fdefine_fringe_bitmap):
7849 Don't update size until alloc works.
7850
7851 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7852 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7853
7854 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7855 Check for size-calculation overflow.
7856 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7857 do, as we prefer signed integers.
7858 (id_to_widget.max_size, id_to_widget.used)
7859 (xg_store_widget_in_map, xg_remove_widget_from_map)
7860 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7861 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7862 Use and return ptrdiff_t, not int.
7863 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7864 * gtkutil.h: Change prototypes to match the above.
7865
7866 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7867 are duplicate now that they've been promoted to lisp.h.
7868 (x_allocate_bitmap_record, x_alloc_image_color)
7869 (make_image_cache, cache_image, xpm_load):
7870 Don't update size until alloc is done.
7871 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7872 (x_detect_edges):
3256efce 7873 Check for size calculation overflow.
726e0ab1
PE
7874 (ct_colors_allocated_max): New constant.
7875 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7876 overflow.
3256efce 7877
726e0ab1
PE
7878 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7879 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7880 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7881 Use ptrdiff_t, not int, to count maps.
7882 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7883 calculations. Don't update size until allocation succeeds.
7884 Redo calculations to avoid overflow.
726e0ab1
PE
7885 * keyboard.h: Change prototypes to match the above.
7886
7887 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7888 to count maps.
7889 (current_minor_maps): Check for size calculation overflow.
7890 * keymap.h: Change prototypes to match the above.
7891
7892 * lread.c (read1, init_obarray): Don't update size until alloc done.
7893
7894 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7895 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7896
726e0ab1
PE
7897 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7898 Now ptrdiff_t, not int.
7899 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7900 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7901
7902 * process.c (Fnetwork_interface_list): Check for overflow
7903 in size calculation.
7904
7905 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7906
7907 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7908 overflow. Don't bother calling xmalloc when xrealloc will do.
7909
7910 * search.c (Freplace_match): Check for size calculation overflow.
7911 (Fset_match_data): Don't assume list lengths fit in 'int'.
7912
7913 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7914 for command line length. Do not attempt to address one before the
7915 beginning of an array, as that's not portable.
7916
7917 * term.c (max_frame_lines): Remove; unused.
7918 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7919 not int.
7920 (encode_terminal_code, calculate_costs): Check for size
7921 calculation overflow.
7922 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7923 table lengths and related sizes. Don't update size until alloc
7924 done. Redo calculations to avoid overflow.
7925 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7926
7927 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7928 subtracting pointers.
7929 (gobble_line): Check for overflow more carefully. Don't update size
7930 until alloc done.
7931
7932 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7933 Don't update size until alloc done.
7934 Redo size calculations to avoid overflow.
7935 Check for size calculation overflow.
0065d054 7936 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7937
7938 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7939 Use ptrdiff_t, not int, for sizes.
7940 (store_mode_line_noprop_char): Don't update size until alloc done.
7941
0065d054
PE
7942 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7943 Use ptrdiff_t, not int, for sizes.
7944 (Finternal_make_lisp_face, cache_face):
7945 Check for size calculation overflow.
7946 (cache_face): Treat size calculation overflows as if they were
7947 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7948
7949 * xfns.c (x_encode_text, x_set_name_internal)
7950 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7951 sizes, since they can exceed INT_MAX in size. Check for size
7952 calculation overflow.
7953
0065d054
PE
7954 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7955 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7956 Don't update size until alloc done.
7957
0065d054 7958 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7959 as sprintf is limited to int lengths.
1d526e2f 7960
252c5ee1
PE
7961 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7962 (X_LONG_MIN): New macros.
864d7ce7
PE
7963 Use them to make the following changes clearer.
7964 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7965 This change doesn't affect the value now, but it may help remind
7966 future maintainers not to raise the value too much later.
7967 (SELECTION_QUANTUM): Remove, replacing with ...
7968 (selection_quantum): ... new function, which avoids overflow.
7969 All uses changed.
7970 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7971 assumption that selection length fits in 'int'.
7972 (x_reply_selection_request, x_handle_selection_request)
7973 (x_get_window_property, receive_incremental_selection)
7974 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7975 (lisp_data_to_selection_data, clean_local_selection_data):
7976 Use ptrdiff_t, not int, to record length of selection.
7977 (x_reply_selection_request, x_get_window_property)
7978 (receive_incremental_selection, x_property_data_to_lisp):
7979 Redo calculations to avoid overflow.
7980 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7981 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7982 something.
7983 (x_get_window_property, receive_incremental_selection)
7984 (lisp_data_to_selection_data, x_property_data_to_lisp):
7985 Check for size-calculation overflow.
7986 (x_get_window_property, receive_incremental_selection)
7987 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7988 Don't store size until memory allocation succeeds.
7989 (x_get_window_property): Plug memory leak on memory exhaustion.
7990 Don't double-block input; malloc is safe here. Don't assume 2**34
7991 - 4 fits in unsigned long. Add an xassert to check
7992 XGetWindowProperty overflow. Be more careful about overflow
7993 calculations, and distinguish size from memory overflow better.
7994 (receive_incremental_selection): When tracing, don't assume
7995 unsigned int is less than INT_MAX.
7996 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7997 harmful) conversions of unsigned short to int.
7998 (lisp_data_to_selection_data): Don't assume that integers
7999 in the range -65535 through -1 fit in an X unsigned short.
8000 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8001 result parameters unless successful. Rely on cons_to_unsigned
8002 to report problems with elements; the old code wasn't right anyway.
8003 (x_check_property_data): Check for int overflow; we cannot use
8004 a wider type due to X limits.
8005 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8006
726e0ab1 8007 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8008
0065d054
PE
8009 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8010 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8011 (x_color_cells): Don't store size until memory allocation succeeds.
8012 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8013 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8014 (x_term_init): Don't assume length fits in int (sprintf is limited
8015 to int size).
bc18e09d 8016
ebfa62c0
PE
8017 Use ptrdiff_t for composition IDs.
8018 * character.c (lisp_string_width):
8019 * composite.c (composition_table_size, n_compositions)
8020 (get_composition_id, composition_gstring_from_id):
8021 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8022 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8023 * window.c (Frecenter):
8024 Use ptrdiff_t, not int, for composition IDs.
8025 * composite.c (get_composition_id): Check for integer overflow.
8026 * composite.h: Adjust prototypes to match the above changes.
8027
d3411f89
PE
8028 Use ptrdiff_t for hash table indexes.
8029 * category.c (hash_get_category_set):
8030 * ccl.c (ccl_driver):
8031 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8032 * coding.c (coding_system_charset_list, detect_coding_system):
8033 * coding.h (struct coding_system.id):
8034 * composite.c (get_composition_id, gstring_lookup_cache):
8035 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8036 * image.c (xpm_get_color_table_h):
8037 * lisp.h (hash_lookup, hash_put):
8038 * minibuf.c (Ftest_completion):
8039 Use ptrdiff_t for hash table indexes, not int (which is too
8040 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8041 32-bit --with-wide-int hosts).
8042
e097a6fa
PE
8043 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8044 Add a FIXME comment about memory leaks.
8045 (syms_of_charset): Don't assume xmalloc returns.
8046
5637687f
PE
8047 Don't assume that stated character widths fit in int.
8048 * character.c (Fchar_width, c_string_width, lisp_string_width):
8049 * character.h (CHAR_WIDTH):
8050 * indent.c (MULTIBYTE_BYTES_WIDTH):
8051 Use sanitize_char_width to avoid undefined and/or bad behavior
8052 with outlandish widths.
a66cfb1c 8053 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8054 now that we have two such functions. All uses changed.
8055 (sanitize_char_width): New inline function.
8056
a2271ba2
PE
8057 Don't assume that tab-width fits in int.
8058 * character.h (sanitize_width): New inline function.
8059 (SANE_TAB_WIDTH): New macro.
8060 (ASCII_CHAR_WIDTH): Use it.
8061 * indent.c (sane_tab_width): Remove. All uses replaced by
8062 SANE_TAB_WIDTH (current_buffer).
8063 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8064
18c52557
PE
8065 * fileio.c: Integer overflow issues with file modes.
8066 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8067
caeeedc1
PE
8068 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8069 Remove unreachable code.
8070 (read_hex, load_charset_map_from_file): Check for integer overflow.
8071
6df6ae42 8072 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8073 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8074 (x_send_scroll_bar_event): Likewise. Check that the size does not
8075 exceed limits imposed by XClientMessageEvent, as well as the usual
8076 ptrdiff_t and size_t limits.
8077
b13995db
PE
8078 * keyboard.c: Overflow, signedness and related fixes.
8079 (make_lispy_movement): Use same integer type in forward decl
8080 that is used in the definition.
8081 (read_key_sequence, keyremap_step):
8082 Change bufsize argument back to int, undoing my 2011-03-30 change.
8083 We prefer signed types, and int is wide enough here.
8084 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8085 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8086 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8087 length, not size_t. Use ptrdiff_t for index, not int.
8088 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8089 possibility of integer overflow.
8090
13464394
PE
8091 Overflow, signedness and related fixes for images.
8092
8093 * dispextern.h (struct it.stack[0].u.image.image_id)
8094 (struct_it.image_id, struct image.id, struct image_cache.size)
8095 (struct image_cache.used, struct image_cache.ref_count):
8096 * gtkutil.c (update_frame_tool_bar):
8097 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8098 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8099 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8100 * nsmenu.m (update_frame_tool_bar):
8101 * xdisp.c (calc_pixel_width_or_height):
8102 * xfns.c (image_cache_refcount):
8103 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8104 on typical 64-bit hosts.
8105
8106 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8107 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8108 Omit unnecessary casts to int.
8109 (parse_image_spec): Check that integers fall into 'int' range
8110 when the callers expect that.
8111 (image_ascent): Redo ascent calculation to avoid int overflow.
8112 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8113 (lookup_image): Remove unnecessary tests.
8114 (xbm_image_p): Locals are now of int, not EMACS_INT,
8115 since parse_image_check makes sure they fit into int.
8116 (png_load, gif_load, svg_load_image):
8117 Prefer int to unsigned where either will do.
8118 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8119 old tiff_error_handler and tiff_warning_handler.
8120 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8121 stack buffer overflows. It uses only the features of vsnprintf
8122 that are common to both POSIX and native Microsoft.
8123 (tiff_error_handler, tiff_warning_handler): Use it.
8124 (tiff_load, gif_load, imagemagick_load_image):
8125 Don't assume :index value fits in 'int'.
8126 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8127 (imagemagick_load_image): Check that crop parameters fit into
8128 the integer types that MagickCropImage accepts. Don't assume
8129 Vimagemagick_render_type has a nonnegative value. Don't assume
8130 size_t fits in 'long'.
8131 (gs_load): Use printmax_t to print the widest integers possible.
8132 Check for integer overflow when computing image height and width.
8133
c11821d4
EZ
81342011-08-26 Eli Zaretskii <eliz@gnu.org>
8135
8136 * xdisp.c (redisplay_window): Don't force window start if point
8137 will be invisible in the resulting window. (Bug#9324)
8138
0c95fcf7
EZ
81392011-08-25 Eli Zaretskii <eliz@gnu.org>
8140
8141 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8142 the display spec is of the form `(space ...)'.
8143 (handle_display_spec): Return the value returned by
8144 handle_single_display_spec, not just 1 or zero.
8145 (handle_single_display_spec): If the display spec is of the form
8146 `(space ...)', and specifies display in the text area, return 2
8147 rather than 1.
fee65a97 8148 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8149 accurately, and prefer exact match for point under bidi.
8150 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8151
8152 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8153 into disp_prop; all users changed.
8154
8155 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8156 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8157 for the text covered by the display property.
8158
e4ed06f1
CY
81592011-08-25 Chong Yidong <cyd@stupidchicken.com>
8160
8161 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8162 Change return value to nil.
8163 (Frecord_buffer): Delete unused function.
8164
f67cdd7f
EZ
81652011-08-24 Eli Zaretskii <eliz@gnu.org>
8166
5980d4c6
EZ
8167 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8168 buffers, return left-to-right.
8610fe8b
EZ
8169 (set_cursor_from_row): Consider candidate row a win if its glyph
8170 represents a newline and point is on that newline. Fixes cursor
8171 positioning on the newline at EOL of R2L text within L2R
8172 paragraph, and vice versa.
8173 (try_cursor_movement): Check continued rows, in addition to
8174 continuation rows. Fixes unwarranted scroll when point enters a
8175 continued line of R2L text within an L2R paragraph, or vice versa.
8176 (cursor_row_p): Consider the case of point being equal to
8177 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8178 from the end of a short line to the beginning of a continued line
8179 of R2L text within L2R paragraph.
8180 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8181 composed characters.
5980d4c6 8182
f67cdd7f
EZ
8183 * bidi.c (bidi_check_type): Use xassert.
8184 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8185 members.
8186
bca633fb
EZ
81872011-08-23 Eli Zaretskii <eliz@gnu.org>
8188
8189 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8190 a character.
8191
4a5885a7
CY
81922011-08-23 Chong Yidong <cyd@stupidchicken.com>
8193
8194 * nsfont.m (ns_otf_to_script): Fix typo.
8195
0902a04e
KH
81962011-08-22 Kenichi Handa <handa@m17n.org>
8197
8198 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8199 extra slot even if the purpose is char-code-property-table.
8200
1a2e6670
EZ
82012011-08-23 Eli Zaretskii <eliz@gnu.org>
8202
8ddde651
EZ
8203 * xdisp.c (redisplay_window): When computing centering_position,
8204 account for the height of the header line. (Bug#8874)
8205
425cc014
EZ
8206 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8207 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8208 candidate is selected by the mouse, and that candidate has a
8209 composed character under the mouse.
8210
1a2e6670
EZ
8211 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8212 coordinates reported by pos-visible-in-window-p for a composed
8213 character in column zero.
8214
8b76d6f8
SM
82152011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8216
8217 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8218
dac347dd
EZ
82192011-08-22 Eli Zaretskii <eliz@gnu.org>
8220
8221 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8222 consider it a hit if to_charpos is anywhere in the range of the
8223 composed buffer positions.
8224
e013fb34
CY
82252011-08-22 Chong Yidong <cyd@stupidchicken.com>
8226
8227 * image.c (gif_load): Don't assume that each subimage has the same
8228 dimensions as the base image. Handle disposal method that is
8229 "undefined" by the gif spec (Bug#9335).
8230
bd1ba3e8
CY
82312011-08-20 Chong Yidong <cyd@stupidchicken.com>
8232
8233 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8234 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8235
54a1215b
EZ
82362011-08-19 Eli Zaretskii <eliz@gnu.org>
8237
823564e5
EZ
8238 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8239 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8240 from an Org mode buffer to a Speedbar frame.
8241
54a1215b
EZ
8242 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8243 a composition, take its buffer position from IT->cmp_it.charpos.
8244 Fixes cursor positioning at the beginning of a line that begins
8245 with a composed character.
8246
9778ebcc
EZ
82472011-08-18 Eli Zaretskii <eliz@gnu.org>
8248
0be6ee06
EZ
8249 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8250 character bidirectional type, use STRONG_L instead. Fixes crashes
8251 in a buffer produced by `describe-categories'.
8252
9778ebcc
EZ
8253 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8254 members before the level stack, so they would be saved and
8255 restored when copying iterator state. Fixes incorrect reordering
8256 around TABs covered by display properties.
8257
156bffbe
AS
82582011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8259
6b02f655 8260 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8261
72ad093b
CY
82622011-08-17 Chong Yidong <cyd@stupidchicken.com>
8263
8264 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8265 (internal_condition_case_2, internal_condition_case_n):
8266 Remove unnecessary aborts (Bug#9081).
72ad093b 8267
35774242
EZ
82682011-08-17 Eli Zaretskii <eliz@gnu.org>
8269
8270 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8271 has no `load' handler, try opening the file locally. (Bug#9311)
8272
db76dd85
KB
82732011-08-16 Ken Brown <kbrown@cornell.edu>
8274
8275 * gmalloc.c: Expand comment.
8276
b215eee5
EZ
82772011-08-16 Eli Zaretskii <eliz@gnu.org>
8278
8279 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8280 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8281
a4579d33
KB
82822011-08-16 Ken Brown <kbrown@cornell.edu>
8283
8284 Fix memory allocation problems in Cygwin build (Bug#9273).
8285
8286 * unexcw.c ( __malloc_initialized): Declare external variable.
8287 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8288
8b76d6f8
SM
8289 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8290 New variables.
a4579d33
KB
8291 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8292 dumped emacs.
8293 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8294 in the static heap.
8295 [CYGWIN] (special_realloc): New function.
8296 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8297 requests to realloc storage in the static heap.
8298
3ebec551
PE
82992011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8300
8301 * bidi.c (bidi_initialize): Remove unused local.
8302
9fd8be00
EZ
83032011-08-15 Eli Zaretskii <eliz@gnu.org>
8304
6b02f655
SM
8305 * bidimirror.h:
8306 * biditype.h: Remove file.
8307 * makefile.w32-in ($(BLD)/bidi.$(O)):
8308 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8309
8310 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8311
8312 * chartab.c: Improve commentary for the uniprop_table API.
8313
32413314
EZ
8314 * bidi.c (bidi_paragraph_init): Support zero value of
8315 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8316 (bidi_initialize): Use uniprop_table instead of including
8317 biditype.h and bidimirror.h.
32413314 8318
9fd8be00
EZ
8319 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8320 coordinates of the iterator when restoring from ppos_it.
8321 (Bug#9296)
8322
5cf2b69b
KH
83232011-08-14 Kenichi Handa <handa@m17n.org>
8324
8325 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8326 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8327
daf17d00
EZ
83282011-08-14 Eli Zaretskii <eliz@gnu.org>
8329
8330 * xdisp.c (move_it_in_display_line_to): Don't invoke
8331 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8332 ppos_it. Fixes vertical cursor motion when line beginning is
8333 covered by an image. (Bug#9296)
8334
08e3161a
JD
83352011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8336
8337 * nsterm.h (ns_run_ascript): Declare.
8338 (NSAPP_DATA2_RUNASSCRIPT): Define.
8339
8340 * nsfns.m (as_script, as_result, as_status): New static variables.
8341 (ns_run_ascript): New function.
5e617bc2 8342 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8343 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8344 the event loop. Get status from as_status (Bug#7276).
8345
8346 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8347 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8348 the event loop (Bug#7276).
8349
a3720aa2
AS
83502011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8351
8352 * gnutls.c (QCgnutls_bootprop_priority)
8353 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8354 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8355 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8356 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8357 (QCgnutls_bootprop_verify_hostname_error)
8358 (QCgnutls_bootprop_callbacks_verify): Rename from
8359 Qgnutls_bootprop_..., all uses changed.
8360
8361 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8362 uses changed.
8363
0a0d27fb
PE
83642011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8365
19d5c50c
PE
8366 * xfaces.c (Qframe_set_background_mode): Now static.
8367 * dispextern.h (Qframe_set_background_mode): Remove decl.
8368
0a0d27fb
PE
8369 * process.c (Fnetwork_interface_info): Declare local only if needed.
8370
377538cb
JD
83712011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8372
8373 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8374 (Fnetwork_interface_list): Allocate in increments of bytes instead
8375 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8376 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8377 sockaddr.
8378 (struct ifflag_def): notrailers is smart on OSX.
8379 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8380 Get hardware address with getifaddrs if available.
8381
08fff70c
EZ
83822011-08-12 Eli Zaretskii <eliz@gnu.org>
8383
8384 * xdisp.c (iterate_out_of_display_property): xassert that
8385 IT->position is set to within IT->object's boundaries. Break from
8386 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8387 when IT->position is set up wrongly due to some bug.
8388 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8389 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8390 entry. Force push_it to save on the stack the current
8391 buffer/string position, to be restored by pop_it. Fix flags in
8392 the iterator structure wrt the object coming from a display
8393 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8394 properties. (Bug#9284)
8395
7be1c708 83962011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8397
7be1c708
CY
8398 * fontset.c (fontset_get_font_group): Add proper type checks.
8399 (Bug#9172)
aac0c6e3 8400
7be1c708 84012011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8402
7be1c708
CY
8403 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8404 and LC_VERSION_MIN_MACOSX.
8405 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8406 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8407
97bb72a6
EZ
84082011-08-08 Eli Zaretskii <eliz@gnu.org>
8409
8410 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8411 no-display-properties-and-no-overlays under bidi display.
8412 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8413 properties and overlays.
97bb72a6 8414
d5617611
CY
84152011-08-08 Chong Yidong <cyd@stupidchicken.com>
8416
37e11a63
CY
8417 * editfns.c (Fset_time_zone_rule): Document relationship with the
8418 setenv function.
8419
d5617611
CY
8420 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8421 the font entity extracted from the cache (Bug#8109).
8422
58872834
CY
84232011-08-07 Chong Yidong <cyd@stupidchicken.com>
8424
8425 * composite.c (autocmp_chars): Don't reset point. That is done by
8426 restore_point_unwind (Bug#5984).
8427
75bfc667
JL
84282011-08-07 Juri Linkov <juri@jurta.org>
8429
8430 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8431 to show the arg `TIME' instead of `TIMEVAL'.
8432
d1410150
EZ
84332011-08-06 Eli Zaretskii <eliz@gnu.org>
8434
8435 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8436 display property strides EOL and includes a newline, as in
8437 longlines-mode. (Bug#9254)
75b771e4
EZ
8438 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8439 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8440
8441 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8442 is non-zero, even if the data buffer is NULL. Fixes a crash in
8443 vertical-motion with longlines-mode. (Bug#9254)
8444
35928349
EZ
84452011-08-05 Eli Zaretskii <eliz@gnu.org>
8446
ec7cc85b
EZ
8447 * bidi.c <bidi_cache_total_alloc>: Now static.
8448 (bidi_initialize): Initialize bidi_cache_total_alloc.
8449
8b76d6f8 8450 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8451 cache. (Bug#9221)
8452
8453 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8454 amount allocated this far in `bidi_cache_total_alloc'.
8455 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8456 non-zero, only free the data buffer without restoring the cache
8457 contents. All callers changed.
8458
8459 * dispextern.h (bidi_unshelve_cache): Update prototype.
8460
8461 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8462 (move_it_in_display_line, move_it_to)
8463 (move_it_vertically_backward, move_it_by_lines): Replace the call
8464 to xfree to an equivalent call to bidi_unshelve_cache.
8465 (move_it_in_display_line_to): Fix logic of returning
412b6358 8466 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8467
e2e2423b
EZ
84682011-08-05 Eli Zaretskii <eliz@gnu.org>
8469
8470 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8471 came from a string character with a `cursor' property. (Bug#9229)
8472
ae9e757a
JD
84732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8474
8475 * Makefile.in (LIB_PTHREAD): New variable.
8476 (LIBES): Add LIB_PTHREAD (Bug#9216).
8477
8478 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8479 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8480
213bd7f2
AS
84812011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8482
6b02f655 8483 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8484
99aaf75f
JD
84852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8486
8487 * xterm.c (x_find_topmost_parent): New function.
8488 (x_set_frame_alpha): Find topmost parent window with
8489 x_find_topmost_parent and set the property there also (bug#9181).
8490 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8491
c74e9d86
PE
84922011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8493
8494 * callproc.c (Fcall_process): Avoid vfork clobbering
8495 the local vars buffer, coding_systems, current_dir.
8496
640c8776
SM
84972011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8498
8499 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8500
f26d0e4c
PE
85012011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8502
8a10d76c
PE
8503 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8504 so that it is not optimized away.
8505
f26d0e4c
PE
8506 * xdisp.c (compute_display_string_pos): Remove unused local.
8507
55439c61
EZ
85082011-08-02 Eli Zaretskii <eliz@gnu.org>
8509
8510 Fix slow cursor motion and scrolling in large buffers with
8511 selective display, like Org Mode buffers. (Bug#9218)
8512
8513 * dispextern.h (struct bidi_it): New member disp_prop_p.
8514
8515 * xdisp.c: Remove one-slot cache of display string positions.
8516 (compute_display_string_pos): Accept an additional argument
5e617bc2 8517 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8518 for a display string or property. If found, set DISP_PROP_P
8519 non-zero.
8520
8521 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8522 DISP_PROP_P, and pass it to compute_display_string_pos.
8523 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8524 non-zero. All callers of bidi_fetch_char changed.
8525
fb33fa43
SM
85262011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8527
8528 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8529
b099e063
DM
85302010-12-03 Don March <don@ohspite.net>
8531
8532 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8533 last character M-[char] is translated to ESC [char] (bug#7541).
8534
5cc7f7af
KH
85352011-08-02 Kenichi Handa <handa@m17n.org>
8536
d0fffa3f 8537 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8538
8539 * chartab.c (uniprop_table): Make it non-static.
8540
525d5e6e
EZ
85412011-08-01 Eli Zaretskii <eliz@gnu.org>
8542
8543 * xdisp.c (forward_to_next_line_start): Accept additional argument
8544 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8545 on the newline.
8546 (reseat_at_next_visible_line_start): Use the bidi iterator state
8547 returned by forward_to_next_line_start to restore the state of
8548 it->bidi_it after backing up to previous newline. (Bug#9212)
8549
31011111
AS
85502011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8551
8552 * regex.c (re_comp): Protoize.
8553 (re_exec): Fix return type.
8554 (regexec): Fix type of `ret'. (Bug#9203)
8555
476371c4
PE
85562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8557
e5d76069
PE
8558 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8559 This is needed if max-image-size is a floating-point number.
8560
9a79b20c
AS
85612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8562
8563 * print.c (print_object): Print empty symbol as ##.
8564
8565 * lread.c (read1): Read ## as empty symbol.
8566
d8c2fa78
AA
85672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8568
8569 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8570 setting frame foreground color (Bug#9175).
8571 (x_set_background_color): Likewise.
8572
ffe57a7a
AA
8573 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8574 contents (Bug#9176).
8575 (EmacsTooltip -init): Remove bezels and add shadows to
8576 tooltip windows.
8577
bf3492a5
AA
8578 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8579 or scroll bar (Bug#8470).
8580
d55e9c53
AA
8581 * nsfont.m (nsfont_open): Remove assignment to voffset and
8582 unnecessary vars hshink, expand, hd, full_height, min_height.
8583 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8584
8585 * nsterm.h (nsfont_info): Remove voffset field.
8586
d8c2fa78 85872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8588
8589 Implement strike-through and overline on NextStep (Bug#8863).
8590
8591 * nsfont.m (nsfont_open): Use underline position provided by font,
8592 instead of hard-coded value of 2.
8593 (nsfont_draw): Call ns_draw_text_decoration instead.
8594
8595 * nsterm.h: Add declaration for ns_draw_text_decoration.
8596
8597 * nsterm.m (ns_draw_text_decoration): New function for drawing
8598 underline, overline, and strike-through.
8599 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8600 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8601 accommodate underlining, etc.
4843aac3 8602
4cc60b9b
EZ
86032011-07-28 Eli Zaretskii <eliz@gnu.org>
8604
bc7ece87
EZ
8605 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8606 default.
4cc60b9b 8607
476371c4
PE
86082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8609
66606eea
PE
8610 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8611 Without this fix, if a signal arrives just after memory fills up,
8612 'malloc' might be invoked reentrantly.
8613
476371c4
PE
8614 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8615 In other words, assume that every image size is allowed, on non-X
8616 hosts. This assumption is probably wrong, but it lets Emacs compile.
8617
f3fcc40d
AS
86182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8619
8620 * regex.c (re_iswctype): Convert return values to boolean.
8621
350c992f
EZ
86222011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8623
8624 * xdisp.c (compute_display_string_pos): Don't use cached display
8625 string position if the buffer had its restriction changed.
8626 (Bug#9184)
8627
5266b4bb
PE
86282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8629
8630 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8631
2573a837 86322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8633
41f55ccd 8634 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8635
39e378da
PE
8636 * bidi.c: Integer size and overflow fixes.
8637 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8638 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8639 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8640 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8641 (bidi_find_other_level_edge):
8642 Use ptrdiff_t instead of EMACS_INT where either will do.
8643 This works better on 32-bit hosts configured --with-wide-int.
8644 (bidi_cache_ensure_space): Check for size-calculation overflow.
8645 Use % rather than repeated addition, for better worst-case speed.
8646 Don't set bidi_cache_size until after xrealloc returns, because it
8647 might not return.
8648 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8649 (bidi_cache_ensure_space): Also check that the bidi cache size
8650 does not exceed that of the largest Lisp string or buffer. See Eli
8651 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8652
5e927815
PE
8653 * alloc.c (__malloc_size_t): Remove.
8654 All uses replaced by size_t. See Andreas Schwab's note
8655 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8656
ca4aa935
PE
8657 * image.c: Improve checking for integer overflow.
8658 (check_image_size): Assume that f is nonnull, since
8659 it is always nonnull in practice. This is one less thing to
8660 worry about when checking for integer overflow later.
8661 (x_check_image_size): New function, which checks for integer
8662 overflow issues inside X.
8663 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8664 This removes the need for a memory_full check.
8665 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8666 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8667 (xbm_read_bitmap_data): Change locals back to 'int', since
8668 their values must fit in 'int'.
8669 (xpm_load_image, png_load, tiff_load):
8670 Invoke x_create_x_image_and_pixmap earlier,
8671 to avoid much needless work if the image is too large.
8672 (tiff_load): Treat overly large images as if
8673 x_create_x_image_and_pixmap failed, not as malloc failures.
8674 (gs_load): Use x_check_image_size.
8675
5f8f9cc2
PE
8676 * gtkutil.c: Omit integer casts.
8677 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8678 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8679
5adf60bc
PE
8680 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8681
c8907a93
PE
8682 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8683 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8684 would wrongly return t on a 64-bit host.
8685
e3c25c68
PE
8686 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8687 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8688 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8689 and therefore cause GCC to emit a bogus diagnostic in some cases.
8690
3f791afe
PE
8691 * image.c: Integer signedness and overflow and related fixes.
8692 This is not an exhaustive set of fixes, but it's time to
8693 record what I've got.
8694 (lookup_pixel_color, check_image_size): Remove redundant decls.
8695 (check_image_size): Don't assume that arbitrary EMACS_INT values
8696 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8697 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8698 (tiff_load, imagemagick_load_image):
8699 Check for overflow in size calculations.
8700 (x_create_x_image_and_pixmap): Remove unnecessary test for
8701 xmalloc returning NULL; that can't happen.
8702 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8703 (xpm_color_bucket): Use better integer hashing function.
8704 (xpm_cache_color): Don't possibly over-allocate memory.
8705 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8706 (gif_memory_source):
8707 Use ptrdiff_t, not int or size_t, to record sizes.
8708 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8709 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8710 either works, as we prefer signed integers.
8711 (tiff_read_from_memory, tiff_write_from_memory):
8712 Return tsize_t, not size_t, since that's what the TIFF API wants.
8713 (tiff_read_from_memory): Don't fail simply because the read would
8714 go past EOF; instead, return a short read.
8715 (tiff_load): Omit no-longer-needed casts.
8716 (Fimagemagick_types): Don't assume size fits into 'int'.
8717
3cc5a532
PE
8718 Improve hashing quality when configured --with-wide-int.
8719 * fns.c (hash_string): New function, taken from sxhash_string.
8720 Do not discard information about ASCII character case; this
8721 discarding is no longer needed.
8722 (sxhash-string): Use it. Change sig to match it. Caller changed.
8723 * lisp.h: Declare it.
8724 * lread.c (hash_string): Remove, since we now use fns.c's version.
8725 The fns.c version returns a wider integer if --with-wide-int is
8726 specified, so this should help the quality of the hashing a bit.
8727
b312a492
PE
8728 * emacs.c: Integer overflow minor fix.
8729 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8730 Define only if GNU_LINUX.
8731 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8732
dfd153ae
PE
8733 * dispnew.c: Integer signedness and overflow fixes.
8734 Remove unnecessary forward decls, that were a maintenance hassle.
8735 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8736 All uses changed.
8737 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8738 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8739 (prepare_desired_row, line_draw_cost):
8740 Use int, not unsigned, where either works.
8741 (save_current_matrix, restore_current_matrix):
8742 Use ptrdiff_t, not size_t, where either works.
8743 (init_display): Check for overflow more accurately, and without
8744 relying on undefined behavior.
8745
a81d11a3
PE
8746 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8747 Remove, replacing with the new symbols in lisp.h. All uses changed.
8748 * fileio.c (make_temp_name):
8749 * filelock.c (lock_file_1, lock_file):
8750 * xdisp.c (message_dolog):
8751 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8752 Use pMd etc. instead.
8753 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8754 replacing the pWIDE etc. symbols removed from editfns.c.
8755
3300e6fd
PE
8756 * keyboard.h (num_input_events): Now uintmax_t.
8757 This is (very slightly) less likely to mess up due to wraparound.
8758 All uses changed.
8759
fd05c7e9
PE
8760 * buffer.c: Integer signedness fixes.
8761 (alloc_buffer_text, enlarge_buffer_text):
8762 Use ptrdiff_t rather than size_t when either will do, as we prefer
8763 signed integers.
8764
903fe15d
PE
8765 * alloc.c: Integer signedness and overflow fixes.
8766 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8767 (__malloc_size_t): Default to size_t, not to int.
8768 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8769 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8770 Prefer ptrdiff_t to size_t when either would do, as we prefer
8771 signed integers.
8772 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8773 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8774 Now const. Initialize with values that are in range even if char
8775 is signed.
8776 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8777 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8778 These functions do the right thing with sizes > 2**32.
8779 (check_depth): Now ptrdiff_t, not int.
8780 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8781 Adjust to new way of storing sizes. Check for size overflow bugs
8782 in rest of code.
8783 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8784 slightly wrong anyway, as it missed one instance of
8785 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8786 (refill_memory_reserve): Omit needless cast to size_t.
8787 (mark_object_loop_halt): Mark as externally visible.
8788
ac82cc6a
PE
8789 * xselect.c: Integer signedness and overflow fixes.
8790 (Fx_register_dnd_atom, x_handle_dnd_message):
8791 Use ptrdiff_t, not size_t, since we prefer signed.
8792 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8793 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8794 x_dnd_atoms_size and x_dnd_atoms_length.
8795
c2d1e36d
PE
8796 * doprnt.c: Prefer signed to unsigned when either works.
8797 * eval.c (verror):
8798 * doprnt.c (doprnt):
8799 * lisp.h (doprnt):
8800 * xdisp.c (vmessage):
8801 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8802 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8803 prefer signed arithmetic to avoid comparison confusion.
8804 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8805 but is a bit tricky.
8806
0e926e56
PE
8807 Assume freestanding C89 headers, string.h, stdlib.h.
8808 * data.c, doprnt.c, floatfns.c, print.c:
8809 Include float.h unconditionally.
8810 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8811 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8812 * regex.c: Likewise for stddef.h, string.h.
8813 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8814 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8815 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8816 (STDC_HEADERS): Remove obsolete defines.
8817 * sysdep.c: Include limits.h unconditionally.
8818
9cfdb3ec
PE
8819 Assume support for memcmp, memcpy, memmove, memset.
8820 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8821 * regex.c (memcmp, memcpy):
8822 Remove; we assume C89 now.
8823
8824 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8825 (__malloc_safe_bcopy): Remove; no longer needed.
8826
cf950e6b 8827 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8828 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8829 well either way, and we prefer signed to unsigned.
8830
dbf38e02
LMI
88312011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8832
8833 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8834 closes the connection while we're reading (bug#9182).
8835
d6f0886c 88362011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8837
d6f0886c
JD
8838 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8839 are specified (Bug#9168).
24e0f6b1 8840
2eb1f9e6
PE
88412011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8842
8843 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8844 Found by GCC static checking and --with-wide-int on a 32-bit host.
8845
22381272 88462011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8847
8848 * xdisp.c (compute_display_string_pos): Fix logic of caching
8849 previous display string position. Initialize cached_prev_pos to
8850 -1. Fixes slow-down at the beginning of a buffer.
8851
f25e39b4
EZ
88522011-07-24 Eli Zaretskii <eliz@gnu.org>
8853
8854 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8855 for attrs[LFACE_FONTSET_INDEX].
8856
04c4b52e
PE
88572011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8858
8859 * xml.c (parse_region): Remove unused local
8860 that was recently introduced.
8861
c1734fbd
EZ
88622011-07-23 Eli Zaretskii <eliz@gnu.org>
8863
be18c5a5
EZ
8864 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8865 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8866
c1734fbd
EZ
8867 * xdisp.c (move_it_in_display_line_to): Record the best matching
8868 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8869 exit if none of the characters scanned was an exact match.
8870 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8871 when exact match is impossible due to invisible text, and the
8872 lines are truncated.
8873
a258d627
JD
88742011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8875
8876 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8877 for OSX >= 10.7.
8878
b6d5a689
EZ
88792011-07-22 Eli Zaretskii <eliz@gnu.org>
8880
0f74f785
EZ
8881 Fix a significant slow-down of cursor motion with C-n, C-p,
8882 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8883 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8884 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8885 (next_element_from_buffer): Call compute_stop_pos_backwards to
8886 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8887 base_level_stop.
8888 (reseat): Don't look for prev_stop, as that could mean a very long
8889 run.
8890 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8891 <cached_disp_overlay_modiff>: Cache for last found display string
8892 position.
551918c1 8893 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8894 about the same buffer in the same area of character positions, and
8895 the buffer wasn't changed since the time the display string
8896 position was cached.
551918c1 8897
b2d0c91a
EZ
88982011-07-22 Eli Zaretskii <eliz@gnu.org>
8899
8900 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8901 is an integer, which is important for empty lines. (Bug#9149)
8902
043604ee
CY
89032011-07-22 Chong Yidong <cyd@stupidchicken.com>
8904
8905 * frame.c (Fmodify_frame_parameters): In tty case, update the
8906 default face if necessary (Bug#4238).
8907
da4adb04
CY
89082011-07-21 Chong Yidong <cyd@stupidchicken.com>
8909
8910 * editfns.c (Fstring_to_char): No need to explain what a character
8911 is in the docstring (Bug#6576).
8912
9abd0532
LMI
89132011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8914
8915 * xml.c (parse_region): Make sure we always return a tree.
8916
36881d16
HK
89172011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8918
8919 * xml.c (parse_region): If a document contains only comments,
8920 return that, too.
8921
1e98674d
LMI
89222011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8923
8924 * xml.c (make_dom): Return comments, too.
8925
590bd467
PE
89262011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8927
8928 Port to OpenBSD.
8929 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8930 and the surrounding thread.
8931 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8932 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8933 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8934 timer goes off.
8935 * s/openbsd.h (BROKEN_SIGIO): Define.
8936 * unexelf.c (unexec) [__OpenBSD__]:
8937 Don't update the .mdebug section of the Alpha COFF symbol table.
8938
f41628b2
LMI
89392011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8940
8941 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8942 (bug#8460).
8943
b59b67c5
PE
89442011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8945
15e3a074
PE
8946 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8947 This fixes some race conditions on the permissions of any newly
8948 created file.
8949
41bed37d
PE
8950 * alloc.c (valid_pointer_p): Use pipe, not open.
8951 This fixes some permissions issues when debugging.
8952
b59b67c5
PE
8953 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8954 If fchown fails to set both uid and gid, try to set just gid,
8955 as that is sometimes allowed. Adjust the file's mode to eliminate
8956 setuid or setgid bits that are inappropriate if fchown fails.
8957
925a6be7
SM
89582011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8959
8960 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8961 to compare Lisp_Objects.
8962 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8963 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8964 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8965
52968808
AS
89662011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8967
0a6a104b
AS
8968 * lread.c (read_integer): Unread even EOF character.
8969 (read1): Likewise. Properly record start position of symbol.
8970
52968808
AS
8971 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8972 symbol character follows.
8973
9e381cdd
PE
89742011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8975
8976 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8977 This works around a problem with the previous change to Fcopy_file.
8978 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8979 and without this change, GCC might complain about discarding
8980 fchown's return value.
8981
b5641435
JB
89822011-07-16 Juanma Barranquero <lekktu@gmail.com>
8983
8984 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8985
a8031457
PE
89862011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8987
8988 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8989
dd889327
LMI
89902011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8991
750c33f7
LMI
8992 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8993 it's used from the C level.
8994
dd889327
LMI
8995 * process.c: Use the same condition for POLL_FOR_INPUT in both
8996 keyboard.c and process.c (bug#1858).
8997
87e86684
LM
89982011-07-09 Lawrence Mitchell <wence@gmx.li>
8999
9000 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9001 (Fgnutls_boot): Use it.
9002
64348f40
AS
90032011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9004
9005 * doc.c (Fsubstitute_command_keys): Revert last change.
9006
1d698799
LMI
90072011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9008
f863868c
LMI
9009 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9010 quotes the next character, and doesn't affect other longer
9011 sequences (bug#8935).
9012
1d698799
LMI
9013 * lread.c (syms_of_lread): Clarify that is isn't only
9014 `eval-buffer' and `eval-defun' that's affected by
9015 `lexical-binding' (bug#8460).
9016
aa4b6df6
EZ
90172011-07-15 Eli Zaretskii <eliz@gnu.org>
9018
9019 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9020 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9021
5d856da6
PE
90222011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9023
ad6042bb
PE
9024 Fix minor problems found by static checking.
9025 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9026 (elsz): Now a signed constant, not a size_t var. We prefer signed
9027 types to unsigned, to avoid integer comparison confusion. Without
9028 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9029 "cannot optimize loop, the loop counter may overflow", a symptom
9030 of the confusion.
f00bbb22 9031 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9032 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9033
6468f31c
LMI
90342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9035
49080b10
LMI
9036 * search.c (Fre_search_backward): Mention `case-fold-search' in
9037 all the re_search_* functions (bug#8138).
9038
6468f31c
LMI
9039 * keyboard.c (Fopen_dribble_file): Document when the file is
9040 closed (bug#8056).
9041
c965adc5
EZ
90422011-07-14 Eli Zaretskii <eliz@gnu.org>
9043
df9733bf
EZ
9044 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9045 bidi_cache_idx.
9046
0bb23927
EZ
9047 Support bidi reordering of display and overlay strings.
9048 * xdisp.c (compute_display_string_pos)
9049 (compute_display_string_end): Accept additional argument STRING.
9050 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9051 (reseat_to_string): Initialize bidi_it->string.s and
9052 bidi_it->string.schars.
9053 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9054 NULL (avoids a crash in bidi_paragraph_init).
9055 Initialize itb.string.lstring.
0bb23927
EZ
9056 (init_iterator): Call bidi_init_it only of a valid
9057 buffer position was specified. Initialize paragraph_embedding to
9058 L2R.
9059 (reseat_to_string): Initialize the bidi iterator.
9060 (display_string): If we need to ignore text properties of
9061 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9062 original value of -1 will not work with bidi.)
9063 (compute_display_string_pos): First arg is now struct
9064 `text_pos *'; all callers changed. Support display properties on
9065 Lisp strings.
9066 (compute_display_string_end): Support display properties on Lisp
9067 strings.
9068 (init_iterator, reseat_1, reseat_to_string): Initialize the
9069 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9070 when iterating on a string not from display properties).
640c8776
SM
9071 (compute_display_string_pos, compute_display_string_end):
9072 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9073 arrow keys.
9074 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9075 base_level_stop; instead, set base_level_stop to BEGV.
9076 Fixes crashes in vertical-motion.
0bb23927
EZ
9077 (next_element_from_buffer): Improve commentary for when
9078 the iterator is before prev_stop.
9079 (init_iterator): Initialize bidi_p from the default value of
9080 bidi-display-reordering, not from buffer-local value. Use the
9081 buffer-local value only if initializing for buffer iteration.
9082 (handle_invisible_prop): Support invisible properties on strings
9083 that are being bidi-reordered.
9084 (set_iterator_to_next): Support bidi reordering of C strings and
9085 Lisp strings.
9086 (next_element_from_string): Support bidi reordering of Lisp
9087 strings.
9088 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9089 (display_string): Support display of R2L glyph rows.
9090 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9091 (init_iterator): Don't initialize it->bidi_p for strings
9092 here.
9093 (reseat_to_string): Initialize it->bidi_p for strings here.
9094 (next_element_from_string, next_element_from_c_string)
9095 (next_element_from_buffer): Add xassert's for correspondence
9096 between IT's object being iterated and it->bidi_it.string
9097 structure.
9098 (face_before_or_after_it_pos): Support bidi iteration.
9099 (next_element_from_c_string): Handle the case of the first string
9100 character that is not the first one in the visual order.
9101 (get_visually_first_element): New function, refactored from common
9102 parts of next_element_from_buffer, next_element_from_string, and
9103 next_element_from_c_string.
9104 (tool_bar_lines_needed, redisplay_tool_bar)
9105 (display_menu_bar): Force left-to-right direction. Add a FIXME
9106 comment for making that be controlled by a user option.
9107 (push_it, pop_it): Save and restore the state of the
9108 bidi iterator. Save and restore the bidi_p flag.
9109 (pop_it): Iterate out of display property for string iteration as
9110 well.
9111 (iterate_out_of_display_property): Support iteration over strings.
9112 (handle_single_display_spec): Set up it->bidi_it for iteration
9113 over a display string, and call bidi_init_it.
9114 (handle_single_display_spec, next_overlay_string)
9115 (get_overlay_strings_1, push_display_prop): Set up the bidi
9116 iterator for displaying display or overlay strings.
9117 (forward_to_next_line_start): Don't use the shortcut if
9118 bidi-iterating.
9119 (back_to_previous_visible_line_start): If handle_display_prop
9120 pushed the iterator stack, restore the internal state of the bidi
9121 iterator by calling bidi_pop_it same number of times.
9122 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9123 and we are bidi-iterating, don't decrement the iterator position;
9124 instead, set the first_elt flag in the bidi iterator, to produce
9125 the same effect.
9126 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9127 (push_display_prop): xassert that we are iterating a buffer.
9128 (push_it, pop_it): Save and restore paragraph_embedding member.
9129 (handle_single_display_spec, next_overlay_string)
9130 (get_overlay_strings_1, reseat_1, reseat_to_string)
9131 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9132 correctly. Don't assume unibyte strings are not bidi-reordered.
9133 (compute_display_string_pos)
9134 (compute_display_string_end): Fix handling the case of C string.
9135 (push_it, pop_it): Save and restore from_disp_prop_p.
9136 (handle_single_display_spec, push_display_prop): Set the
9137 from_disp_prop_p flag.
9138 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9139 (pop_it): Call iterate_out_of_display_property only if we are
9140 popping after iteration over a string that came from a display
9141 property. Fix a typo in popping stretch info. Add an assertion
9142 for verifying that the iterator position is in sync with the bidi
9143 iterator.
9144 (handle_single_display_spec, get_overlay_strings_1)
9145 (push_display_prop): Fix initialization of paragraph direction for
9146 string when that of the parent object is not yet determined.
9147 (reseat_1): Call bidi_init_it to resync the bidi
9148 iterator with IT's position. (Bug#7616)
9149 (find_row_edges): If ROW->start.pos gives position
9150 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9151 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9152 Reset the from_disp_prop_p flag.
9153 (SAVE_IT, RESTORE_IT): New macros.
9154 (pos_visible_p, face_before_or_after_it_pos)
9155 (back_to_previous_visible_line_start)
9156 (move_it_in_display_line_to, move_it_in_display_line)
9157 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9158 (try_scrolling, redisplay_window, display_line): Use them when
9159 saving a temporary copy of the iterator and restoring it back.
9160 (back_to_previous_visible_line_start, reseat_1)
9161 (init_iterator): Empty the bidi cache "stack".
9162 (move_it_in_display_line_to): If iterator ended up at
9163 EOL, but we never saw any buffer positions smaller than
9164 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9165 motion in bidi-reordered lines.
9166 (move_it_in_display_line_to): Record prev_method and prev_pos
9167 immediately before the call to set_iterator_to_next. Fixes cursor
9168 motion in bidi-reordered lines with stretch glyphs and strings
9169 displayed in margins. (Bug#8133) (Bug#8867)
9170 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9171 TO_CHARPOS.
640c8776
SM
9172 (pos_visible_p): Support positions in bidi-reordered lines.
9173 Save and restore bidi cache.
0bb23927
EZ
9174
9175 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9176 (bidi_paragraph_info): Delete unused struct.
9177 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9178 (bidi_cache_start): New variable.
9179 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9180 to zero.
9181 (bidi_cache_fetch_state, bidi_cache_search)
9182 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9183 (bidi_cache_find, bidi_peek_at_next_level)
9184 (bidi_level_of_next_char, bidi_find_other_level_edge)
9185 (bidi_move_to_visually_next): Compare cache index with
9186 bidi_cache_start rather than with zero.
9187 (bidi_fetch_char): Accept new argument STRING; all callers
9188 changed. Support iteration over a string. Support strings with
9189 display properties. Support unibyte strings. Fix the type of
9190 `len' according to what STRING_CHAR_AND_LENGTH expects.
9191 (bidi_paragraph_init, bidi_resolve_explicit_1)
9192 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9193 (bidi_level_of_next_char, bidi_move_to_visually_next):
9194 Support iteration over a string.
0bb23927
EZ
9195 (bidi_set_sor_type, bidi_resolve_explicit_1)
9196 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9197 can now be zero (for strings); special values 0 and -1 were
9198 changed to -1 and -2, respectively.
9199 (bidi_char_at_pos): New function.
9200 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9201 Call it instead of FETCH_MULTIBYTE_CHAR.
9202 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9203 initialized to valid values.
9204 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9205 values.
9206 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9207 the test for valid cached positions. Fix the logic for looking up
9208 the sentinel state in the cache. GCPRO the Lisp string we are
9209 iterating.
9210 (bidi_push_it, bidi_pop_it): New functions.
9211 (bidi_initialize): Initialize the bidi cache start stack pointer.
9212 (bidi_cache_ensure_space): New function, refactored from part of
9213 bidi_cache_iterator_state. Don't assume the required size is just
9214 one BIDI_CACHE_CHUNK away.
9215 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9216 (bidi_count_bytes, bidi_char_at_pos): New functions.
9217 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9218 always valid if bidi_cache_idx is valid.
9219 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9220 is valid if it's going to be used.
9221 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9222 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9223 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9224 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9225 (bidi_find_other_level_edge, bidi_cache_start_stack):
9226 All variables related to cache indices are now EMACS_INT.
c965adc5 9227
0bb23927
EZ
9228 * dispextern.h (struct bidi_string_data): New structure.
9229 (struct bidi_it): New member `string'. Make flag members be 1-bit
9230 fields, and put them last in the struct.
640c8776
SM
9231 (compute_display_string_pos, compute_display_string_end):
9232 Update prototypes.
0bb23927
EZ
9233 (bidi_push_it, bidi_pop_it): Add prototypes.
9234 (struct iterator_stack_entry): New members bidi_p,
9235 paragraph_embedding, and from_disp_prop_p.
9236 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9237 (bidi_shelve_cache, bidi_unshelve_cache):
9238 Declare prototypes.
0bb23927
EZ
9239
9240 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9241 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9242 and vector-like objects.
9243
9244 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9245 cache around display iteration.
9246
9247 * window.c (Fwindow_end, window_scroll_pixel_based)
9248 (displayed_window_lines, Frecenter): Save and restore the bidi
9249 cache around display iteration.
9250
3bbd2265
LMI
92512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9252
9253 * editfns.c (Fdelete_region): Clarify the use of the named
9254 parameters (bug#6788).
9255
adc47434
MR
92562011-07-14 Martin Rudalics <rudalics@gmx.at>
9257
9258 * indent.c (Fvertical_motion): Set and restore w->pointm when
9259 saving and restoring the window's buffer (Bug#9006).
9260
837c31f8
LMI
92612011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9262
9263 * editfns.c (Fstring_to_char): Clarify just what is returned
9264 (bug#6576). Text by Eli Zaretskii.
9265
ac389d0c
JB
92662011-07-13 Juanma Barranquero <lekktu@gmail.com>
9267
9268 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9269
0be0ce47
EZ
92702011-07-13 Eli Zaretskii <eliz@gnu.org>
9271
9272 * buffer.c (mmap_find): Fix a typo.
9273
cd18e7e3
JB
92742011-07-13 Johan Bockgård <bojohan@gnu.org>
9275
9276 Fix execution of x selection hooks.
9277 * xselect.c (Qx_lost_selection_functions)
9278 (Qx_sent_selection_functions): New vars.
9279 (syms_of_xselect): DEFSYM them.
9280 (x_handle_selection_request): Pass Qx_sent_selection_functions
9281 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9282 (x_handle_selection_clear,x_clear_frame_selections):
9283 Pass Qx_lost_selection_functions rather than
9284 Vx_lost_selection_functions to Frun_hook_with_args.
9285
47ea7f44
PE
92862011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9287
ac389d0c 9288 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9289 The old code sometimes used this field without initializing it.
9290
47ea7f44
PE
9291 * alloc.c (gc_sweep): Don't read past end of array.
9292 In theory, the old code could also have corrupted Emacs internals,
9293 though it'd be very unlikely.
9294
bc985c87
AS
92952011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9296
9297 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9298 argument. (Bug#4026)
bc985c87 9299
0cf34688
LMI
93002011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9301
b3dadd76
LMI
9302 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9303 key" (bug#4257).
9304
0cf34688
LMI
9305 * window.c (Fset_window_start): Doc fix (bug#4199).
9306 (Fset_window_hscroll): Ditto.
9307
270768cd
PE
93082011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9309
077e3dda 9310 Fix minor new problems caught by GCC 4.6.1.
270768cd 9311 * term.c (init_tty): Remove unused local.
490011a6 9312 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9313 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9314 not used otherwise.
270768cd 9315
b1f58454
CY
93162011-07-12 Chong Yidong <cyd@stupidchicken.com>
9317
9318 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9319
22b9578d
LMI
93202011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9321
6e70ab07
LMI
9322 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9323 are the mini-buffer and the echo area (bug#3320).
9324
22b9578d
LMI
9325 * term.c (init_tty): Remove support for supdup, c10 and perq
9326 terminals, which are no longer supported (bug#1482).
9327
8974cc9f
JB
93282011-07-10 Johan Bockgård <bojohan@gnu.org>
9329
9330 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9331
a560d974
JD
93322011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9333
9334 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9335 for non-popups (Bug#3642).
9336
1dae0f0a
AS
93372011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9338
268c2c36 9339 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9340 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9341 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9342 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9343 * data.c (fmod): Likewise.
9344 * dispnew.c (swap_glyphs_in_rows): Likewise.
9345 * emacs.c (memory_warning_signal): Likewise.
9346 * floatfns.c (float_error): Likewise.
9347 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9348 (otf_open, font_otf_capability, generate_otf_features)
9349 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9350 Likewise.
9351 * image.c (pbm_read_file): Likewise.
9352 * indent.c (string_display_width): Likewise.
9353 * intervals.c (check_for_interval, search_for_interval)
9354 (inc_interval_count, count_intervals, root_interval)
9355 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9356 * lread.c (defalias): Likewise.
268c2c36 9357 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9358 * regex.c (set_image_of_range_1, set_image_of_range)
9359 (regex_grow_registers): Likewise.
9360 * sysdep.c (strerror): Likewise.
9361 * termcap.c (valid_filename_p, tprint, main): Likewise.
9362 * tparam.c (main): Likewise.
9363 * unexhp9k800.c (run_time_remap, save_data_space)
9364 (update_file_ptrs, read_header, write_header, calculate_checksum)
9365 (copy_file, copy_rest, display_header): Likewise.
9366 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9367 Likewise.
9368 * xdisp.c (check_it): Likewise.
9369 * xfaces.c (register_color, unregister_color, unregister_colors):
9370 Likewise.
9371 * xfns.c (print_fontset_result): Likewise.
9372 * xrdb.c (member, fatal, main): Likewise.
9373
99033785
PE
93742011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9375
9376 Fix minor problems found by static checking (Bug#9031).
9377 * chartab.c (char_table_set_range, map_sub_char_table):
9378 Remove unused locals.
9379 (uniprop_table): Now static.
9380 * composite.c (_work_char): Remove unused static var.
9381
9cb2ac56
JB
93822011-07-09 Juanma Barranquero <lekktu@gmail.com>
9383
9384 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9385
f25661f0
JD
93862011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9387
9388 * gtkutil.c (qttip_cb): Remove code without function.
9389
8278c4fe
EZ
93902011-07-09 Eli Zaretskii <eliz@gnu.org>
9391
9392 * w32.c (pthread_sigmask): New stub.
9393
1692ae2d 93942011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9395
8a6ebd58 9396 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9397 sigprocmask is portable only for single-threaded applications, and
9398 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9399 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9400 (LIBES): Use it.
9401 * callproc.c (Fcall_process):
9402 * process.c (create_process):
9403 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9404 Use pthread_sigmask, not sigprocmask.
123403e4 9405
1b854618
JD
94062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9407
9408 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9409 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9410 wrong (Bug#8591).
9411
3fe4b549
JD
94122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9413
0ce7e563
JD
9414 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9415 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9416 (xg_hide_tooltip): Fix comment.
9417
3fe4b549
JD
9418 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9419 in registerServicesMenuSendTypes.
9420 (validRequestorForSendType): Don't check ns_return_types.
9421
9422 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9423 ns_return_type.
9424
5df75e47
JR
94252011-07-08 Jason Rumney <jasonr@gnu.org>
9426
22610910
JR
9427 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9428 SH_SHOW for hidden windows (Bug#5482).
9429
5df75e47
JR
9430 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9431 frame struct members of non-existent frames (Bug#6284).
9432
699c10bd
JD
94332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9434
4393663b
JD
9435 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9436 variable firstTime not needed on OSX >= 10.6.
9437 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9438 >= 10.5. Use setKnobProportion, setDoubleValue.
9439
9440 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9441 (MAC_OS_X_VERSION_10_5): Define if not defined.
9442 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9443 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9444 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9445
9446 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9447 cString and lossyCString on OSX >= 10.4.
4393663b 9448
58179cce 9449 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9450 sizeToFit on OSX >= 10.2.
9451
9452 * nsimage.m (allocInitFromFile): Don't use deprecated method
9453 bestRepresentationForDevice on OSX >= 10.6.
9454
9455 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9456 to avoid warning.
9457
9458 * emacs.c: Declare unexec_init_emacs_zone.
9459
a63e0781
JD
9460 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9461
699c10bd
JD
9462 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9463
9464 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9465 on svcsMenu (Bug#8842).
9466
9467 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9468 ns_return_types.
9469 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9470
9471 * nsterm.m (QUTF8_STRING): Declare.
9472 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9473 (validRequestorForSendType): Return type is (id).
9474 Change indexOfObjectIdenticalTo to indexOfObject.
9475 Check if we have local selection before returning self (Bug#8842).
9476 (writeSelectionToPasteboard): Put local selection into paste board
9477 if we have a local selection (Bug#8842).
9478 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9479
9480 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9481 (ns_get_local_selection): Declare.
9482
54e10184
LMI
94832011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9484
9888ff71
LMI
9485 * keymap.c (describe_map_tree): Don't insert a double newline at
9486 the end of the buffer (bug#1169) and return whether we inserted
9487 something.
9488
54e10184
LMI
9489 * callint.c (Fcall_interactively): Change "reading args" to
9490 "providing args" to try to clarify what it does (bug#1010).
9491
15fa4783
KH
94922011-07-07 Kenichi Handa <handa@m17n.org>
9493
9494 * composite.c (composition_compute_stop_pos): Ignore a static
9495 composition starting before CHARPOS (Bug#8915).
9496
9497 * xdisp.c (handle_composition_prop): Likewise.
9498
a8815b00
EZ
94992011-07-07 Eli Zaretskii <eliz@gnu.org>
9500
9501 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9502 (Bug#9015)
9503
ef7b981d 95042011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9505
9506 * character.h (unicode_category_t): New enum type.
9507
9508 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9509 (Qchar_code_property_table): New variable.
9510 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9511 (UNIPROP_COMPRESSED_FORM_P): New macros.
9512 (char_table_ascii): Uncompress the compressed values.
9513 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9514 Uncompress the compressed values.
ac389d0c 9515 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9516 (char_table_ref_and_range): Uncompress the compressed values.
9517 (sub_char_table_set): New arg is_uniprop. Callers changed.
9518 Uncompress the compressed values.
9519 (sub_char_table_set_range): Args changed. Callers changed.
9520 (char_table_set_range): Adjuted for the above change.
9521 (map_sub_char_table): Delete args default_val and parent. Add arg
9522 top. Give decoded values to a Lisp function.
640c8776 9523 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9524 values to a Lisp function. Gcpro more variables.
9525 (uniprop_table_uncompress)
9526 (uniprop_decode_value_run_length): New functions.
9527 (uniprop_decoder, uniprop_decoder_count): New variables.
9528 (uniprop_get_decoder, uniprop_encode_value_character)
9529 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9530 New functions.
9531 (uniprop_encoder, uniprop_encoder_count): New variables.
9532 (uniprop_get_encoder, uniprop_table)
9533 (Funicode_property_table_internal, Fget_unicode_property_internal)
9534 (Fput_unicode_property_internal): New functions.
9535 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9536 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9537 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9538 char-code-property-alist.
9539
640c8776 9540 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9541 Vunicode_category_table.
9542
640c8776 9543 * font.c (font_range): Adjust for the change of
c805dec0
KH
9544 Vunicode_category_table.
9545
76b397fb
DN
95462011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9547
9548 * m/iris4d.h: Remove file, move contents ...
9549 * s/irix6-5.h: ... here.
9550
22b4128e
PE
95512011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9552
9553 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9554 * alloc.c (mark_buffer):
9555 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9556 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9557 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9558 This isn't true in general, and it's particularly not true
9559 if Emacs is configured with --with-wide-int.
9560 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9561 New macros, used in the buffer.c change.
9562
869795d6
JD
95632011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9564
9565 * xsettings.c: Use both GConf and GSettings if both are available.
9566 (store_config_changed_event): Add comment.
9567 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9568 (store_tool_bar_style_changed): New functions.
5e617bc2 9569 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9570 (struct xsettings): Move font inside HAVE_XFT.
9571 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9572 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9573 Move inside HAVE_XFT.
640c8776 9574 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9575 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9576 also.
9577 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9578 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9579 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9580 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9581 (parse_settings): Move check for font inside HAVE_XFT.
9582 (read_settings, apply_xft_settings): Add comment.
9583 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9584 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9585 call store_font_name_changed.
9586 (xft_settings_event): Add comment.
9587 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9588 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9589 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9590 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9591 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9592 (xsettings_get_system_font, xsettings_get_system_normal_font):
9593 Add comment.
869795d6 9594
d8ed26bd
PE
95952011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9596
9597 Random fixes. E.g., (random) never returned negative values.
9598 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9599 subseconds part to the entropy, as that's a bit more random.
9600 Prefer signed to unsigned, since the signedness doesn't matter and
9601 in general we prefer signed. When given a limit, use a
9602 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9603 latter isn't right if USE_2_TAGS_FOR_INTS.
9604 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9605 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9606
cabf1cac
SM
96072011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9608
9609 * textprop.c (text_property_stickiness):
9610 Obey Vtext_property_default_nonsticky.
9611 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9612 * w32fns.c (syms_of_w32fns):
9613 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9614
6e9b2be9
PE
96152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9616
9617 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9618 This is more efficient than Ffile_directory_p and avoids a minor race.
9619
90186c68
LMI
96202011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9621
7c301272
LMI
9622 * buffer.c (Foverlay_put): Say what the return value is
9623 (bug#7835).
9624
c4f2d8d4
LMI
9625 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9626 is a directory before asking whether to use the file name
9627 (bug#7564).
ad637907
LMI
9628 (barf_or_query_if_file_exists): Make the "File is a directory"
9629 error be more correct.
c4f2d8d4 9630
90186c68
LMI
9631 * fns.c (Frequire): Remove the mention of the .gz files, since
9632 that's installation-specific, but keep the mention of
9633 `get-load-suffixes'.
9634
da64016e
PE
96352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9636
9637 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9638 Report string overflow if the output is too long.
9639
7d47b580
JB
96402011-07-04 Juanma Barranquero <lekktu@gmail.com>
9641
a555cb87
JB
9642 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9643 (syms_of_gnutls): Remove duplicate DEFSYM for
9644 Qgnutls_bootprop_verify_hostname_error, an error for
9645 Qgnutls_bootprop_verify_error (which is no longer used).
9646
7d47b580
JB
9647 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9648 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9649 Also (re)move comments that are misplaced or no longer relevant.
9650
1e49bfab
LMI
96512011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9652
9653 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9654
1485f4c0
CY
96552011-07-03 Chong Yidong <cyd@stupidchicken.com>
9656
9657 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9658 and background color parameters if they have been changed.
9659
a9ab721e
LMI
96602011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9661
9662 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9663
cf7cff57
PE
96642011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9665
2e13213d
PE
9666 * xsettings.c (SYSTEM_FONT): Define only when used.
9667 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9668
cf7cff57
PE
9669 * keymap.c (access_keymap_1): Now static.
9670
7a8e04f7
CY
96712011-07-02 Chong Yidong <cyd@stupidchicken.com>
9672
9673 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9674 leave any prefix arg for the up event (Bug#1586).
9675
61352f62
LMI
96762011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9677
69bb1ef7
LMI
9678 * lread.c (syms_of_lread): Mention single symbols defined by
9679 `defvar' or `defconst' (bug#7154).
9680
61352f62 9681 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9682 (Frequire): Mention get-load-suffixes.
61352f62 9683
28545e04
MR
96842011-07-02 Martin Rudalics <rudalics@gmx.at>
9685
9686 * window.h (window): Remove clone_number slot.
9687 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9688 Remove.
9689 (make_parent_window, make_window, saved_window)
9690 (Fset_window_configuration, save_window_save): Don't deal with
9691 clone numbers.
9692 * buffer.c (Qclone_number): Remove declaration.
9693 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9694
3349e122
SM
96952011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9696
9697 Add multiple inheritance to keymaps.
9698 * keymap.c (Fmake_composed_keymap): New function.
9699 (Fset_keymap_parent): Simplify.
9700 (fix_submap_inheritance): Remove.
9701 (access_keymap_1): New function extracted from access_keymap to handle
9702 embedded parents and handle lists of maps.
9703 (access_keymap): Use it.
9704 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9705 (Fcopy_keymap): Handle embedded parents.
9706 (Fcommand_remapping, define_as_prefix): Simplify.
9707 (Fkey_binding): Simplify.
9708 (syms_of_keymap): Move minibuffer-local-completion-map,
9709 minibuffer-local-filename-completion-map,
9710 minibuffer-local-must-match-map, and
9711 minibuffer-local-filename-must-match-map to Elisp.
9712 (syms_of_keymap): Defsubr make-composed-keymap.
9713 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9714 (parse_menu_item): Trivial simplification.
9715
3279eb87
GM
97162011-07-01 Glenn Morris <rgm@gnu.org>
9717
9718 * Makefile.in (SETTINGS_LIBS): Fix typo.
9719
4550efdf
KI
97202011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9721
9722 * coding.c (Fencode_coding_string): Record the last coding system
9723 used, as the function doc string says (bug#8738).
9724
0949d2b6
JD
97252011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9726
9727 * xsettings.c (store_monospaced_changed): Take new font as arg and
9728 check for change against current_mono_font.
9729 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9730 (emacs_settings_constructor, emacs_settings_get_property)
9731 (emacs_settings_set_property, emacs_settings_class_init)
9732 (emacs_settings_init, gsettings_obj): Remove.
9733 (something_changedCB): New function for HAVE_GSETTINGS.
9734 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9735 with value as argument.
9736 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9737 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9738 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9739 "changed".
9740
9741 * xgselect.c: Add defined (HAVE_GSETTINGS).
9742 (xgselect_initialize): Ditto.
9743
9744 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9745 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9746 xg_select.
9747
bbc6b304
PE
97482011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9749
9750 * eval.c (struct backtrace): Simplify and port the data structure.
9751 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9752 signed bit field, as this assumption is not portable and it makes
9753 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9754 "char debug_on_exit : 1" as this is not portable either; instead,
9755 use the portable "unsigned int debug_on_exit : 1". Remove unused
9756 member evalargs. Remove obsolete comments about cc bombing out.
9757
9851bfc5
JD
97582011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9759
51bb811f 9760 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9761 Let HAVE_GSETTINGS override HAVE_GCONF.
9762 (store_monospaced_changed): New function.
9763 (EMACS_SETTINGS): A new type derived from GObject to handle
9764 GSettings notifications.
9765 (emacs_settings_constructor, emacs_settings_get_property)
9766 (emacs_settings_set_property, emacs_settings_class_init):
9767 New functions.
9768 (gsettings_client, gsettings_obj): New variables.
9769 (GSETTINGS_SCHEMA): New define.
9770 (something_changedCB): Call store_monospaced_changed.
9771 (init_gsettings): New function.
9772 (xsettings_initialize): Call init_gsettings.
9773 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9774 to NULL.
9775
640c8776 9776 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9777 GCONF_CFLAGS/LIBS.
9778
5386012d
MR
97792011-06-29 Martin Rudalics <rudalics@gmx.at>
9780
9781 * window.c (resize_root_window, grow_mini_window)
9782 (shrink_mini_window): Rename Qresize_root_window to
9783 Qwindow_resize_root_window and Qresize_root_window_vertically to
9784 Qwindow_resize_root_window_vertically.
9785
f13e0b08
PE
97862011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9787
9788 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9789
94515237
JB
97902011-06-27 Juanma Barranquero <lekktu@gmail.com>
9791
9792 * makefile.w32-in: Redesign dependencies so they reflect more
9793 clearly which files are directly included by each source file,
9794 and not through other includes.
9795
e43b6e43
MR
97962011-06-27 Martin Rudalics <rudalics@gmx.at>
9797
9798 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9799 (sort_overlays, overlay_strings): When an overlay's clone number
9800 matches the window's clone number process the overlay even if
9801 the overlay's window property doesn't match the current window.
9802
d68443dc
MR
9803 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9804 (Fwindow_hchild): Rename to Fwindow_left_child.
9805 (Fwindow_next): Rename to Fwindow_next_sibling.
9806 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9807 (resize_window_check): Rename to window_resize_check.
9808 (resize_window_apply): Rename to window_resize_apply.
9809 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9810 (Fdelete_other_windows_internal, resize_frame_windows)
9811 (Fsplit_window_internal, Fdelete_window_internal)
9812 (grow_mini_window, shrink_mini_window)
9813 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9814
c7e73be5
JD
98152011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9816
9817 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9818 (emacs_fixed_set_min_size): Remove.
9819 (emacs_fixed_new): Take frame as argument.
9820
9821 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9822 (_EmacsFixedPrivate): Remove minwidth/height.
9823 Add struct frame *f.
9824 (emacs_fixed_init): Initialize priv->f.
9825 (get_parent_class, emacs_fixed_set_min_size): Remove.
9826 (emacs_fixed_new): Set priv->f to argument.
9827 (emacs_fixed_get_preferred_width)
9828 (emacs_fixed_get_preferred_height): Use min_width/height from
9829 frames size_hint to set minimum and natural (Bug#8919).
9830 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9831 and use min_width/height from frames size_hint to set
9832 min_width/height (Bug#8919).
9833
9834 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9835 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9836 Fix indentation.
c7e73be5 9837
cf99dcf8
EZ
98382011-06-26 Eli Zaretskii <eliz@gnu.org>
9839
9840 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9841 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9842 called at ZV.
9843
029529ac
CY
98442011-06-26 Chong Yidong <cyd@stupidchicken.com>
9845
9846 * process.c (wait_reading_process_output): Bypass select if
9847 waiting for a cell while ignoring keyboard input, and input is
9848 pending. Suggested by Jan Djärv (Bug#8869).
9849
7a7ef429
PE
98502011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9851
9852 Use gnulib's dup2 module instead of rolling our own.
9853 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9854
11fdef7d 98552011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9856
9857 * dispnew.c (scrolling_window): Before scrolling, turn off a
9858 mouse-highlight in the window being scrolled.
9859
cd3520a4
JB
98602011-06-24 Juanma Barranquero <lekktu@gmail.com>
9861
9862 Move DEFSYM to lisp.h and use everywhere.
9863
9864 * character.h (DEFSYM): Move declaration...
9865 * lisp.h (DEFSYM): ...here.
9866
9867 * gnutls.c:
9868 * minibuf.c:
9869 * w32menu.c:
9870 * w32proc.c:
9871 * w32select.c: Don't include character.h.
9872
9873 * alloc.c (syms_of_alloc):
9874 * buffer.c (syms_of_buffer):
9875 * bytecode.c (syms_of_bytecode):
9876 * callint.c (syms_of_callint):
9877 * casefiddle.c (syms_of_casefiddle):
9878 * casetab.c (init_casetab_once):
9879 * category.c (init_category_once, syms_of_category):
9880 * ccl.c (syms_of_ccl):
9881 * cmds.c (syms_of_cmds):
9882 * composite.c (syms_of_composite):
9883 * dbusbind.c (syms_of_dbusbind):
9884 * dired.c (syms_of_dired):
9885 * dispnew.c (syms_of_display):
9886 * doc.c (syms_of_doc):
9887 * editfns.c (syms_of_editfns):
9888 * emacs.c (syms_of_emacs):
9889 * eval.c (syms_of_eval):
9890 * fileio.c (syms_of_fileio):
9891 * fns.c (syms_of_fns):
9892 * frame.c (syms_of_frame):
9893 * fringe.c (syms_of_fringe):
9894 * insdel.c (syms_of_insdel):
9895 * keymap.c (syms_of_keymap):
9896 * lread.c (init_obarray, syms_of_lread):
9897 * macros.c (syms_of_macros):
9898 * msdos.c (syms_of_msdos):
9899 * print.c (syms_of_print):
9900 * process.c (syms_of_process):
9901 * search.c (syms_of_search):
9902 * sound.c (syms_of_sound):
9903 * syntax.c (init_syntax_once, syms_of_syntax):
9904 * terminal.c (syms_of_terminal):
9905 * textprop.c (syms_of_textprop):
9906 * undo.c (syms_of_undo):
9907 * w32.c (globals_of_w32):
9908 * window.c (syms_of_window):
9909 * xdisp.c (syms_of_xdisp):
9910 * xfaces.c (syms_of_xfaces):
9911 * xfns.c (syms_of_xfns):
9912 * xmenu.c (syms_of_xmenu):
9913 * xsettings.c (syms_of_xsettings):
9914 * xterm.c (syms_of_xterm): Use DEFSYM.
9915
4228cf16
TZ
99162011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9917
cd3520a4 9918 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9919
7fcccf1e
PE
99202011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9921
7efb4e0e
PE
9922 Integer and buffer overflow fixes (Bug#8873).
9923
ff5844ad
PE
9924 * print.c (printchar, strout): Check for string overflow.
9925 (PRINTPREPARE, printchar, strout):
9926 Don't set size unless allocation succeeds.
9927
90532f02
PE
9928 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9929 for sizes. Check for string overflow more accurately.
9930 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9931
6d84508d
PE
9932 * macros.c: Integer and buffer overflow fixes.
9933 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9934 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9935 Use ptrdiff_t, not int, for sizes.
9936 Don't increment bufsize until after realloc succeeds.
9937 Check for size-calculation overflow.
9938 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9939
437b2cb4
PE
9940 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9941
8b9ac8b4
PE
9942 * lread.c: Integer overflow fixes.
9943 (read_integer): Radix is now EMACS_INT, not int,
9944 to improve quality of diagnostics for out-of-range radices.
9945 Calculate buffer size correctly for out-of-range radices.
9946 (read1): Check for integer overflow in radices, and in
9947 read-circle numbers.
82cb60d3
PE
9948 (read_escape): Avoid int overflow.
9949 (Fload, openp, read_buffer_size, read1)
9950 (substitute_object_recurse, read_vector, read_list, map_obarray):
9951 Use ptrdiff_t, not int, for sizes.
9952 (read1): Use EMACS_INT, not int, for sizes.
20270765 9953 Check for size overflow.
8b9ac8b4 9954
7fcccf1e
PE
9955 * image.c (cache_image): Check for size arithmetic overflow.
9956
bfbbd7e7
PE
9957 * lread.c: Integer overflow issues.
9958 (saved_doc_string_size, saved_doc_string_length)
9959 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9960 Now ptrdiff_t, not int.
9961 (read1): Don't assume doc string length fits in int. Check for
9962 out-of-range doc string lengths.
9963 (read_list): Don't assume file position fits in int.
39019e54 9964 (read_escape): Check for hex character overflow.
bfbbd7e7 9965
4e323265
LL
99662011-06-22 Leo Liu <sdl.web@gmail.com>
9967
9968 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9969 Move to minibuffer.el.
9970
85fece3e
PE
99712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9972
20b84ce9 9973 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9974 The following patches are for when GLYPH_DEBUG && !XASSERT.
9975 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9976 * dispnew.c (flush_stdout):
9977 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9978 Mark as externally visible.
9979 * dispnew.c (check_window_matrix_pointers): Now static.
9980 * dispnew.c (window_to_frame_vpos):
9981 * xfns.c (unwind_create_frame):
9982 * xterm.c (x_check_font): Remove unused local.
9983 * scroll.c (CHECK_BOUNDS):
9984 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9985 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9986 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9987 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9988 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9989 Now static.
9990 (debug_method_add): Use va_list and vsprintf rather than relying
9991 on undefined behavior with wrong number of arguments.
9992 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9993 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9994 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9995 since we're not interested in debugging glyphs with old libraries.
9996 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9997 GCC 4.6.0's static checking.
9998
0766b489
PE
99992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10000
31fd4b32
PE
10001 Integer overflow and signedness fixes (Bug#8873).
10002 A few related buffer overrun fixes, too.
10003
b79e8648
PE
10004 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10005
0766b489
PE
10006 * dispextern.h (struct face.stipple):
10007 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10008 (x_bitmap_mask, x_allocate_bitmap_record)
10009 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10010 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10011 (x_create_bitmap_from_xpm_data):
10012 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10013 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10014 (.bitmaps_last):
10015 * xfaces.c (load_pixmap):
10016 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10017 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10018 (.bitmaps_last, struct x_output.icon_bitmap):
10019 Use ptrdiff_t, not int, for bitmap indexes.
10020 (x_allocate_bitmap_record): Check for size overflow.
10021 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10022
b081724f
PE
10023 Use ptrdiff_t, not int, for overlay counts.
10024 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10025 * editfns.c (overlays_around, get_pos_property):
10026 * textprop.c (get_char_property_and_overlay):
10027 * xdisp.c (next_overlay_change, note_mouse_highlight):
10028 * xfaces.c (face_at_buffer_position):
21514da7
PE
10029 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10030 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10031 (Fnext_overlay_change, Fprevious_overlay_change)
10032 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10033 Use ptrdiff_t, not int, for sizes.
21514da7 10034 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10035
3de73e5e
PE
10036 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10037
2606c57b
PE
10038 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10039 (x_session_initialize): Do not assume string length fits in int.
10040
aaafe47a
PE
10041 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10042 This is unlikely, but can occur if DPI is outlandish.
10043
2674ddc8 10044 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10045 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10046
28154962
PE
10047 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10048 * xrdb.c (magic_file_p, search_magic_path):
10049 Omit last arg SUFFIX; it was always 0. All callers changed.
10050 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10051
7de51af5
PE
10052 * xfont.c (xfont_match): Avoid need for strlen.
10053
25ed6cc3
PE
10054 * xfns.c: Don't assume strlen fits in int.
10055 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10056
4eab31dd
PE
10057 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10058 not unsigned long, as we prefer signed integers. All callers changed.
10059 Detect integer overflow in repeat count.
10060 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10061 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10062
171e2a58
PE
10063 * termcap.c: Don't assume sizes fit in int and never overflow.
10064 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10065 (gobble_line): Check for size-calculation overflow.
10066
ad39faca 10067 * minibuf.c (Fread_buffer):
6e5bb2dc 10068 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10069 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10070 Don't assume string length fits in int.
10071
52c61c22 10072 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10073 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10074
b5b8c9e5
PE
10075 * font.c: Don't assume string length fits in int.
10076 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10077 Use ptrdiff_t, not int.
ccd6111c
PE
10078 (font_intern_prop): Don't assume string length fits in int.
10079 Don't assume integer property fits in fixnum.
10080 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10081
882f0d81 10082 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10083 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10084 Reformulate so as not to need the command string.
10085 Invoke gzip -cd rather than gunzip, as it's more portable.
10086 (lock_info_type, lock_file_1, lock_file):
10087 Don't assume pid_t and time_t fit in unsigned long.
10088 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10089 (current_lock_owner): Prefer signed type for sizes.
10090 Use memcpy, not strncpy, where memcpy is what is really wanted.
10091 Don't assume (via atoi) that time_t and pid_t fit in int.
10092 Check for time_t and/or pid_t out of range, e.g., via a network share.
10093 Don't alloca where an auto var works fine.
10094
93f4cf88
PE
10095 * fileio.c: Fix some integer overflow issues.
10096 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10097 Don't assume string length fits in int.
10098 (directory_file_name): Don't assume string length fits in long.
10099 (make_temp_name): Don't assume pid fits in int, or that its print
10100 length is less than 20.
10101
f3e92b69
PE
10102 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10103
1bfdaf10
PE
10104 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10105
35016e9a
PE
10106 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10107
3d1e65a1
PE
10108 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10109 We prefer signed integers, even for size calculations.
10110
0b963a93
PE
10111 * emacs.c: Don't assume string length fits in 'int'.
10112 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10113 (main): Don't invoke strlen when not needed.
10114
573f4b54
PE
10115 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10116 (XD_DEBUG_MESSAGE): Don't waste a byte.
10117
989f33ba
PE
10118 * callproc.c (getenv_internal_1, getenv_internal)
10119 (Fgetenv_internal):
965d34eb
PE
10120 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10121
e4d29b33
PE
10122 * lread.c (invalid_syntax): Omit length argument.
10123 All uses changed. This doesn't fix a bug, but it simplifies the
10124 code away from its former Hollerith-constant appearance, and it's
10125 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10126 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10127
eb49b136
PE
10128 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10129 This didn't break anything, but it didn't help either.
10130 It's confusing to put a bogus integer in a place where the actual
10131 value does not matter.
9f62aeb1 10132 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10133 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10134
15375a22
PE
10135 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10136 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10137 implementation.
b61cc01c
PE
10138 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10139 We prefer signed types, and the value cannot exceed the EMACS_INT
10140 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10141 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10142 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10143 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10144
53b2623d
PE
10145 * indent.c (sane_tab_width): New function.
10146 (current_column, scan_for_column, Findent_to, position_indentation)
10147 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10148 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10149
51cab52b 10150 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10151
f2ed8a70
PE
10152 * lisp.h (lint_assume): New macro.
10153 * composite.c (composition_gstring_put_cache):
10154 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10155
abe80cc6
PE
10156 * editfns.c, insdel.c:
10157 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10158
b02c740e
PE
10159 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10160
ebc96716
PE
10161 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10162
b4e50fa0 10163 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10164 Use much-faster test for byte-length change.
311d5d7c 10165 Don't assume string byte-length fits in 'int'.
a4cf38e4 10166 Check that character arg fits in 'int'.
85461888 10167 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10168
c0c1ee9f
PE
10169 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10170
a498d7f4
PE
10171 * fns.c (concat): Catch string overflow earlier.
10172 Do not rely on integer wraparound.
10173
51cab52b
PE
10174 * dispextern.h (struct it.overlay_strings_charpos)
10175 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10176 * xdisp.c (forward_to_next_line_start)
10177 (back_to_previous_visible_line_start)
10178 (reseat_at_next_visible_line_start, next_element_from_buffer):
10179 Don't arbitrarily truncate the value of 'selective' to int.
10180
76031fad
PE
10181 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10182
5eb55db9
PE
10183 * composite.c: Don't truncate sizes to 'int'.
10184 (composition_gstring_p, composition_reseat_it)
10185 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10186 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10187 not EMACS_UINT, for indexes.
5eb55db9 10188
0703a717
PE
10189 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10190
d6202519
PE
10191 * buffer.c: Include <verify.h>.
10192 (struct sortvec.priority, struct sortstr.priority):
8961a454 10193 Now EMACS_INT, not int.
c20998a7 10194 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10195 (struct sortstr.size, record_overlay_string)
10196 (struct sortstrlist.size, struct sortlist.used):
10197 Don't truncate size to int.
10198 (record_overlay_string): Check for size-calculation overflow.
d6202519 10199 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10200
d5a19415
JM
102012011-06-22 Jim Meyering <meyering@redhat.com>
10202
029529ac 10203 Don't leak an XBM-image-sized buffer
d5a19415
JM
10204 * image.c (xbm_load): Free the image buffer after using it.
10205
a9041e6c
PE
102062011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10207
10208 Port to Sun C.
10209 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10210 that Sun C diagnosed.
10211 * fns.c (secure_hash): Fix pointer signedness issue.
10212 * intervals.c (static_offset_intervals): New function.
10213 (offset_intervals): Use it.
10214
7f3f739f
LL
102152011-06-21 Leo Liu <sdl.web@gmail.com>
10216
10217 * deps.mk (fns.o):
10218 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10219 sha512.h.
10220
10221 * fns.c (secure_hash): Rename from crypto_hash_function and change
10222 the first arg to accept symbols.
5b66d427 10223 (Fsecure_hash): New primitive.
7f3f739f
LL
10224 (syms_of_fns): New symbols.
10225
76147d94
DD
102262011-06-20 Deniz Dogan <deniz@dogan.se>
10227
10228 * process.c (Fset_process_buffer): Clarify return value in
10229 docstring.
10230
7d7d0045
CY
102312011-06-18 Chong Yidong <cyd@stupidchicken.com>
10232
10233 * dispnew.c (add_window_display_history): Use BVAR.
10234
10235 * xdisp.c (debug_method_add): Use BVAR.
10236 (check_window_end, dump_glyph_matrix, dump_glyph)
10237 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10238
10239 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10240 Likewise.
10241
10242 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10243 check till after the cache is created in init_frame_faces.
10244
ff2bc410
SM
102452011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10246
10247 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10248
28177add
PE
102492011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10250
dd3482fe
PE
10251 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10252 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10253 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10254
393d71f3 10255 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10256 * fileio.c (Finsert_file_contents):
10257 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10258 Remove the old (too-loose) buffer overflow checks.
10259 They weren't needed, since make_gap checks for buffer overflow.
10260 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10261 The old code merely checked for Emacs fixnum overflow, and relied
10262 on undefined (wraparound) behavior. The new code avoids undefined
10263 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10264
2e6813b0 10265 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10266 Tune. Don't use wider integers than needed. Don't use alloca.
10267 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10268
599a9e4f
PE
10269 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10270
99561444
PE
10271 * insdel.c, lisp.h (buffer_overflow): New function.
10272 (insert_from_buffer_1, replace_range, replace_range_2):
10273 * insdel.c (make_gap_larger):
10274 * editfns.c (Finsert_char):
10275 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10276
28177add
PE
10277 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10278
e69dafad
PE
102792011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10280
4baa020d 10281 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10282
b1c46f02
PE
10283 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10284 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10285
e69dafad
PE
10286 * fileio.c: Don't assume EMACS_INT fits in off_t.
10287 (emacs_lseek): New static function.
10288 (Finsert_file_contents, Fwrite_region): Use it.
10289 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10290
566684ea
PE
10291 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10292
e6966cd6
PE
10293 * fns.c: Don't overflow int when computing a list length.
10294 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10295 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10296 truncation on 64-bit hosts. Check for QUIT every
10297 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10298 faster and is responsive enough.
10299 (Flength): Report an error instead of overflowing an integer.
10300 (Fsafe_length): Return a float if the value is not representable
10301 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10302 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10303 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10304
dd0b0efb
PE
10305 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10306 (header_size, word_size): New constants.
10307 (allocate_vectorlike): Don't check size overflow here.
10308 (allocate_vector): Check it here instead, since this is the only
10309 caller of allocate_vectorlike that could cause overflow.
10310 Check that the new vector's length is representable as a fixnum.
10311
86fe5cfe
PE
10312 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10313 The previous code was bogus. For example, next_almost_prime (32)
10314 returned 39, which is undesirable as it is a multiple of 3; and
10315 next_almost_prime (24) returned 25, which is a multiple of 5 so
10316 why was the code bothering to check for multiples of 7?
10317
80e88859
PE
10318 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10319
4a2f0ad6
PE
10320 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10321
f66c7cf8
PE
10322 Variadic C functions now count arguments with ptrdiff_t.
10323 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10324 Back then I didn't know that the Emacs coding style prefers signed int.
10325 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10326 were being counted with int, which may truncate counts on 64-bit
10327 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10328 * lisp.h (struct Lisp_Subr.function.aMANY)
10329 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10330 Arg counts are now ptrdiff_t, not size_t.
10331 All variadic functions and their callers changed accordingly.
10332 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10333 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10334 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10335 * callint.c (Fcall_interactively): Check arg count for overflow,
10336 to avoid potential buffer overrun. Use signed char, not 'int',
10337 for 'varies' array, so that we needn't bother to check its size
10338 calculation for overflow.
10339 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10340 * eval.c (apply_lambda):
10341 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10342 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10343 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10344
a1759b76
PE
10345 * callint.c (Fcall_interactively): Don't use index var as event count.
10346
d96be9fc
PE
10347 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10348 * mem-limits.h (SIZE): Remove; no longer used.
10349
a690a978 10350 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10351
578c21e6
PE
10352 Remove unnecessary casts.
10353 * xterm.c (x_term_init):
10354 * xfns.c (x_set_border_pixel):
10355 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10356 These aren't needed now that we assume ANSI C.
10357
96f53c6c
PE
10358 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10359 It's more likely to cause problems (due to unsigned overflow)
10360 than to cure them.
10361
83c77d31
PE
10362 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10363
ee2079f1
PE
10364 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10365
6da65536
PE
10366 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10367
7147c4a4
PE
10368 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10369
193e32d9
PE
10370 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10371
e5533da6
PE
10372 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10373
9910e595
PE
10374 GLYPH_CODE_FACE returns EMACS_INT, not int.
10375 * dispextern.h (merge_faces):
10376 * xfaces.c (merge_faces):
01103c44
PE
10377 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10378 Don't assume EMACS_INT fits in int.
9910e595 10379
2638320e
PE
10380 * character.h (CHAR_VALID_P): Remove unused parameter.
10381 * fontset.c, lisp.h, xdisp.c: All uses changed.
10382
045eb8d9
PE
10383 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10384
c1f134b5
PE
10385 * fns.c (concat): Minor tuning based on overflow analysis.
10386 This doesn't fix any bugs. Use int to hold character, instead
10387 of constantly refetching from Emacs object. Use XFASTINT, not
10388 XINT, for value known to be a character. Don't bother comparing
10389 a single byte to 0400, as it's always less.
10390
395fcb93 10391 * floatfns.c (Fexpt):
327eeec8
PE
10392 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10393
abbd3d23
PE
10394 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10395 for characters.
10396
684a03ef
PE
10397 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10398
0fed43f3
PE
10399 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10400 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10401 incorrectly succeed when S was a string, because 4294967386 was
10402 truncated before it was used.
10403
8fd02eb7
PE
10404 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10405 Otherwise, an out-of-range integer could cause undefined behavior
10406 on a 64-bit host.
10407
f8c86b69
PE
10408 * composite.c: Use int, not EMACS_INT, for characters.
10409 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10410 EMACS_INT, for values that are known to be in character range.
10411 This doesn't fix any bugs but is the usual style inside Emacs and
10412 may generate better code on 32-bit machines.
10413
34206dd2
PE
10414 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10415 This is for reasons similar to the recent CHAR_STRING fix.
10416 * charset.c (Fencode_char): Check that character arg is actually
10417 a character. Pass an int to ENCODE_CHAR.
10418 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10419 wider than 'int', as a compile-time check to prevent future regressions
10420 in this area.
10421
c5958d4c 10422 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10423
10424 Make sure a 64-bit char is never passed to CHAR_STRING.
10425 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10426 by silently ignoring the top 32 bits, allowing some values
10427 that were far too large to be valid characters.
10428 * character.h: Include <verify.h>.
10429 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10430 arguments are no wider than unsigned, as a compile-time check
10431 to prevent future regressions in this area.
10432 * data.c (Faset):
01103c44 10433 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10434 (Fsubst_char_in_region):
10435 * fns.c (concat):
10436 * xdisp.c (decode_mode_spec_coding):
10437 Adjust to CHAR_STRING's new requirement.
10438 * editfns.c (Finsert_char, Fsubst_char_in_region):
10439 * fns.c (concat): Check that character args are actually
10440 characters. Without this test, these functions did the wrong
10441 thing with wildly out-of-range values on 64-bit hosts.
10442
d37ca623
PE
10443 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10444 These casts should not be needed on 32-bit hosts, either.
10445 * keyboard.c (read_char):
10446 * lread.c (Fload): Remove casts to unsigned.
10447
ea204efb
PE
10448 * lisp.h (UNSIGNED_CMP): New macro.
10449 This fixes comparison bugs on 64-bit hosts.
10450 (ASCII_CHAR_P): Use it.
10451 * casefiddle.c (casify_object):
01103c44 10452 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10453 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10454 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10455 * dispextern.h (FACE_FROM_ID):
10456 * keyboard.c (read_char): Use UNSIGNED_CMP.
10457
41cb286c
PE
10458 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10459 not to EMACS_INT, to avoid GCC warning.
10460
4a1b9832
PE
10461 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10462
55daad71
PE
10463 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10464 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10465 isn't needed on 32-bit machines.
8f95c75c 10466
01103c44
PE
10467 * buffer.c (Fgenerate_new_buffer_name):
10468 Use EMACS_INT for count, not int.
0ceccced 10469 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10470
10471 * data.c (Qcompiled_function): Now static.
10472
c6f072e7
PE
10473 * window.c (window_body_lines): Now static.
10474
20ce5912
PE
10475 * image.c (gif_load): Rename local to avoid shadowing.
10476
9c4c5f81
PE
10477 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10478 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10479 * alloc.c (make_save_value): Integer argument is now of type
10480 ptrdiff_t, not int.
10481 (mark_object): Use ptrdiff_t, not int.
10482 * lisp.h (pD): New macro.
10483 * print.c (print_object): Use it.
10484
c0c5c8ae
PE
10485 * alloc.c: Use EMACS_INT, not int, to count objects.
10486 (total_conses, total_markers, total_symbols, total_vector_size)
10487 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10488 (total_free_floats, total_floats, total_free_intervals)
10489 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10490 Now EMACS_INT, not int. All uses changed.
10491 (Fgarbage_collect): Compute overall total using a double, so that
10492 integer overflow is less likely to be a problem. Check for overflow
10493 when converting back to an integer.
5a25e253
PE
10494 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10495 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10496 These were 'int' variables that could overflow on 64-bit hosts;
10497 they were never used, so remove them instead of repairing them.
211a0b2a 10498 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10499 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10500 Previously, this ceilinged at INT_MAX, but that doesn't work on
10501 64-bit machines.
e46bb31a 10502 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10503
c78baabf 10504 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10505 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10506 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10507 when a (possibly-narrower) signed value would do just as well.
10508 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10509
c9d624c6
PE
10510 * alloc.c: Catch some string size overflows that we were missing.
10511 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10512 for convenience in STRING_BYTES_MAX.
10513 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10514 The definition here is exact; the one in lisp.h was approximate.
10515 (allocate_string_data): Check for string overflow. This catches
10516 some instances we weren't catching before. Also, it catches
10517 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10518 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10519 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10520
c9d624c6
PE
10521 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10522 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10523 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10524
353032ce
PE
10525 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10526
2bccce07
PE
10527 * alloc.c (Fmake_string): Check for out-of-range init.
10528
0ac30604
SM
105292011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10530
10531 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10532
c195f2de
JD
105332011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10534
10535 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10536 xg_get_default_scrollbar_width.
10537
10538 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10539 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10540 (style_changed_cb): Call update_theme_scrollbar_width and call
10541 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10542 all frames (Bug#8505).
10543 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10544 Call gtk_window_set_resizable if HAVE_GTK3.
10545 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10546 and height if HAVE_GTK3 (Bug#8505).
10547 (scroll_bar_width_for_theme): New variable.
10548 (update_theme_scrollbar_width): New function.
10549 (xg_get_default_scrollbar_width): Move code to
10550 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10551 (xg_initialize): Call update_theme_scrollbar_width.
10552
10553 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10554
10555 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10556
e10ac9f1
MR
105572011-06-12 Martin Rudalics <rudalics@gmx.at>
10558
10559 * frame.c (make_frame): Call other_buffer_safely instead of
10560 other_buffer.
10561
10562 * window.c (temp_output_buffer_show): Call display_buffer with
10563 second argument Vtemp_buffer_show_specifiers and reset latter
10564 immediately after the call.
10565 (Vtemp_buffer_show_specifiers): New variable.
10566 (auto_window_vscroll_p, next_screen_context_lines)
10567 (Vscroll_preserve_screen_position): Remove leading asterisks from
10568 doc-strings.
10569
2d3c217e 105702011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10571
7b7f97e8 10572 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10573 * buffer.c (Qclone_number): Remove for now, as it's unused.
10574 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10575 (record_buffer): Remove unused local.
10576 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10577 (set_frame_buffer_list): Remove; unused.
10578 * frame.h (other_visible_frames): Remove decl.
10579 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10580 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10581 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10582 if HAVE_GPM.
10583 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10584 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10585 Define only if HAVE_GPM.
10586 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10587 (update_hints_inhibit): Remove; never set. All uses removed.
10588 * widgetprv.h (emacsFrameClassRec): Remove decl.
10589 * window.c (delete_deletable_window): Now returns void, since it
10590 wasn't returning anything.
10591 (compare_window_configurations): Remove unused locals.
10592 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10593 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10594 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10595 the same widths as pointers. This follows up on the 2011-05-06 patch.
10596 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10597 * xterm.h: Likewise.
10598 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10599
1384b89e
JB
106002011-06-12 Juanma Barranquero <lekktu@gmail.com>
10601
10602 * makefile.w32-in: Update dependencies.
10603 (LISP_H): Add lib/intprops.h.
10604
1100a63c
CY
106052011-06-11 Chong Yidong <cyd@stupidchicken.com>
10606
10607 * image.c (gif_load): Add animation frame delay to the metadata.
10608 (syms_of_image): Use DEFSYM. New symbol `delay'.
10609
6198ccd0
MR
106102011-06-11 Martin Rudalics <rudalics@gmx.at>
10611
10612 * window.c (delete_deletable_window): Re-add.
10613 (Fset_window_configuration): Rewrite to handle dead buffers and
10614 consequently deletable windows.
10615 (window_tree, Fwindow_tree): Remove. Supply functionality in
10616 window.el.
10617 (compare_window_configurations): Simplify code.
10618
b6e3633c
AS
106192011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10620
1ab0dee5
AS
10621 * image.c (imagemagick_load_image): Fix type mismatch.
10622 (Fimagemagick_types): Likewise.
10623
b6e3633c
AS
10624 * window.h (replace_buffer_in_windows): Declare.
10625
9397e56f
MR
106262011-06-11 Martin Rudalics <rudalics@gmx.at>
10627
10628 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10629 Qclone_number. Remove external declaration of Qdelete_window.
10630 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10631 code.
640c8776
SM
10632 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10633 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10634 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10635 buffer list implementation.
10636 (other_buffer_safely): New function.
10637 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10638 calls to replace_buffer_in_windows and
10639 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10640 if allowed.
10641 (record_buffer): Inhibit quitting and rewrite using quittable
10642 functions. Run Qbuffer_list_update_hook if allowed.
10643 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10644 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10645 Move switch-to-buffer to window.el.
9397e56f
MR
10646 (bury-buffer): Move to window.el.
10647 (Vbuffer_list_update_hook): New variable.
10648
10649 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10650 section.
10651
10652 * window.h (resize_frame_windows): Move up in code.
10653 (Fwindow_frame): Remove EXFUN.
10654 (replace_buffer_in_all_windows): Remove prototype.
10655 (replace_buffer_in_windows_safely): Add prototype.
10656
10657 * window.c: Declare Qdelete_window static again. Move down
10658 declaration of select_count.
10659 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10660 (Fother_window): Move to window.el.
10661 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10662 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10663 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10664 window.el.
10665 (replace_buffer_in_windows): Implement by calling
10666 Qreplace_buffer_in_windows.
10667 (replace_buffer_in_all_windows): Remove with some functionality
10668 moved into replace_buffer_in_windows_safely.
10669 (replace_buffer_in_windows_safely): New function.
10670 (select_window_norecord, select_frame_norecord): Move in front
10671 of run_window_configuration_change_hook. Remove now obsolete
10672 declarations.
640c8776
SM
10673 (Fset_window_buffer): Rewrite doc-string.
10674 Call Qrecord_window_buffer.
9397e56f
MR
10675 (keys_of_window): Move binding for other-window to window.el.
10676
b50691aa
CY
106772011-06-11 Chong Yidong <cyd@stupidchicken.com>
10678
10679 * dispextern.h (struct image): Replace data member, whose int_val
10680 and ptr_val fields were not used by anything, with a single
10681 lisp_val object.
10682
10683 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10684 (gif_clear_image, gif_load, imagemagick_load_image)
10685 (gs_clear_image, gs_load): Callers changed.
10686
3f754b86
PE
106872011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10688
cca69397
PE
10689 * buffer.h: Include <time.h>, for time_t.
10690 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10691
109e28d0
PE
10692 Fix minor problems found by static checking.
10693
60737f02
PE
10694 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10695
4b66faf3
PE
10696 Make identifiers static if they are not used in other modules.
10697 * data.c (Qcompiled_function, Qframe, Qvector):
10698 * image.c (QimageMagick, Qsvg):
10699 * minibuf.c (Qmetadata):
10700 * window.c (resize_window_check, resize_root_window): Now static.
10701 * window.h (resize_window_check, resize_root_window): Remove decls.
10702
109e28d0
PE
10703 * window.c (window_deletion_count, delete_deletable_window):
10704 Remove; unused.
46a4ce9e
PE
10705 (window_body_lines): Now static.
10706 (Fdelete_other_windows_internal): Mark vars as initialized.
10707 Make sure 'resize_failed' is initialized.
10708 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10709 (resize_window_apply): Remove unused local.
10710 * window.h (delete_deletable_window): Remove decl.
10711
109e28d0 10712 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10713 (imagemagick_load_image): Fix pointer signedness problem by changing
10714 last arg from unsigned char * to char *. All uses changed.
10715 Also, fix a local for similar reasons.
10716 Remove unused locals. Remove locals to avoid shadowing.
10717 (fn_rsvg_handle_free): Remove; unused.
10718 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10719 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10720
3f754b86
PE
10721 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10722
2547adb1
CY
107232011-06-10 Chong Yidong <cyd@stupidchicken.com>
10724
10725 * image.c (gif_load): Fix omitted cast error introduced by
10726 2011-06-06 change.
10727
2c8e37d4
MR
107282011-06-10 Martin Rudalics <rudalics@gmx.at>
10729
10730 * window.h (resize_proportionally, orig_total_lines)
10731 (orig_top_line): Remove from window structure.
10732 (set_window_height, set_window_width, change_window_heights)
10733 (Fdelete_window): Remove prototypes.
10734 (resize_frame_windows): Remove duplicate declaration.
10735
440a42e3
EZ
107362011-06-10 Eli Zaretskii <eliz@gnu.org>
10737
10738 * window.h (resize_frame_windows, resize_window_check)
10739 (delete_deletable_window, resize_root_window)
10740 (resize_frame_windows): Declare prototypes.
10741
10742 * window.c (resize_window_apply): Make definition be "static" to
10743 match the prototype.
10744
562dd5e9
MR
107452011-06-10 Martin Rudalics <rudalics@gmx.at>
10746
10747 * window.c: Remove declarations of Qwindow_size_fixed,
10748 window_min_size_1, window_min_size_2, window_min_size,
10749 size_window, window_fixed_size_p, enlarge_window, delete_window.
10750 Remove static from declaration of Qdelete_window, it's
10751 temporarily needed by Fbury_buffer.
10752 (replace_window): Don't assign orig_top_line and
10753 orig_total_lines.
10754 (Fdelete_window, delete_window): Remove. Window deletion is
10755 handled by window.el.
640c8776
SM
10756 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10757 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10758 (Fdelete_other_windows): Remove. Deleting other windows is
10759 handled by window.el.
10760 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10761 handled in window.el.
10762 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10763 Window minimum sizes are handled in window.el.
10764 (shrink_windows, size_window, set_window_height)
10765 (set_window_width, change_window_heights, window_height)
10766 (window_width, CURBEG, CURSIZE, enlarge_window)
10767 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10768 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10769 handled in window.el.
10770 (make_dummy_parent): Rename to make_parent_window and give it a
10771 second argument horflag.
10772 (make_window): Don't set resize_proportionally any more.
10773 (Fsplit_window): Remove. Windows are split in window.el.
10774 (save_restore_action, save_restore_orig_size)
10775 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10776 Resize mini windows in window.el.
10777 (grow_mini_window, shrink_mini_window): Implement by calling
10778 Qresize_root_window_vertically, resize_window_check and
10779 resize_window_apply.
640c8776
SM
10780 (saved_window, Fset_window_configuration, save_window_save):
10781 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10782 resize_proportionally.
10783 (window_min_height, window_min_width): Move to window.el.
10784 (keys_of_window): Move bindings for delete-other-windows,
10785 split-window, delete-window and enlarge-window to window.el.
10786
10787 * buffer.c: Temporarily extern Qdelete_window.
10788 (Fbury_buffer): Temporarily call Qdelete_window instead of
10789 Fdelete_window (Fbury_buffer will move to window.el soon).
10790
10791 * frame.c (set_menu_bar_lines_1): Remove code handling
10792 orig_top_line and orig_total_lines.
10793
10794 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10795 set_window_height but set heights directly.
10796 (change_frame_size_1): Use resize_frame_windows.
10797
10798 * xdisp.c (init_xdisp): Don't use set_window_height but set
10799 heights directly.
10800
640c8776
SM
10801 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10802 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10803 run_window_configuration_change_hook.
10804
10805 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10806 instead of change_window_heights and run
10807 run_window_configuration_change_hook.
10808
1a13852e
MR
108092011-06-09 Martin Rudalics <rudalics@gmx.at>
10810
10811 * window.c (replace_window): Rename second argument REPLACEMENT to
10812 NEW. New third argument SETFLAG. Rewrite.
10813 (delete_window, make_dummy_parent): Call replace_window with
10814 third argument 1.
10815 (window_list_1): Move down in code.
10816 (run_window_configuration_change_hook): Move set_buffer part
10817 before select_frame_norecord part in order to unwind correctly.
10818 Rename count1 to count.
10819 (recombine_windows, delete_deletable_window, resize_root_window)
10820 (Fdelete_other_windows_internal)
10821 (Frun_window_configuration_change_hook, make_parent_window)
10822 (resize_window_check, resize_window_apply, Fresize_window_apply)
10823 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10824 (Fdelete_window_internal, Fresize_mini_window_internal):
10825 New functions.
1a13852e
MR
10826 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10827
f3d1777e
MR
108282011-06-08 Martin Rudalics <rudalics@gmx.at>
10829
496e208e
MR
10830 * window.h (window): Add some new members to window structure -
10831 normal_lines, normal_cols, new_total, new_normal, clone_number,
10832 splits, nest, prev_buffers, next_buffers.
10833 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10834 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10835
f3d1777e
MR
10836 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10837 Remove.
496e208e
MR
10838 (make_dummy_parent): Set new members of windows structure.
10839 (make_window): Move down in code. Handle new members of window
10840 structure.
10841 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10842 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10843 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10844 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10845 (Fset_window_next_buffers, Fset_window_clone_number):
10846 New functions.
496e208e
MR
10847 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10848 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10849 Doc-string fixes.
10850 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10851 Argument WINDOW can be now internal window too.
10852 (Fwindow_use_time): Move up in code.
10853 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10854 Rewrite doc-string.
10855 (Fset_window_configuration, saved_window)
10856 (Fcurrent_window_configuration, save_window_save): Handle new
10857 members of window structure.
b9e809c2
MR
10858 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10859 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10860 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10861 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10862 Qget_mru_window, Qresize_root_window,
10863 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10864 Qauto_buffer_name; staticpro them.
f3d1777e 10865
abde8f8c
MR
108662011-06-07 Martin Rudalics <rudalics@gmx.at>
10867
10868 * window.c (Fwindow_total_size, Fwindow_left_column)
10869 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10870 (Fwindow_list_1): New functions.
10871 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10872 (Fwindow_width, Fscroll_left, Fscroll_right):
10873 Use window_body_cols instead of window_box_text_cols.
10874 (delete_window, Fset_window_configuration):
10875 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10876 (delete_all_subwindows): Take a window as argument and not a
10877 structure. Rewrite.
190b47e6
MR
10878 (window_loop): Remove handling of GET_LRU_WINDOW and
10879 GET_LARGEST_WINDOW.
10880 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10881
10882 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10883 window_box_text_cols. delete_all_subwindows now takes a
10884 Lisp_Object as argument.
abde8f8c 10885
640c8776
SM
10886 * indent.c (compute_motion, Fcompute_motion):
10887 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10888
fa8a67e6
MR
10889 * frame.c (delete_frame): Call delete_all_subwindows with root
10890 window as argument.
10891
a54e3482
DC
108922011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10893
10894 * fns.c (Fputhash): Document return value.
10895
60002bf5
CY
108962011-06-06 Chong Yidong <cyd@stupidchicken.com>
10897
10898 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10899
0c671da6 109002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10901
b862a52a 10902 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10903
be44ca6c
PE
10904 Check for overflow when converting integer to cons and back.
10905 * charset.c (Fdefine_charset_internal, Fdecode_char):
10906 Use cons_to_unsigned to catch overflow.
10907 (Fencode_char): Use INTEGER_TO_CONS.
10908 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10909 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10910 * data.c (long_to_cons, cons_to_long): Remove.
10911 (cons_to_unsigned, cons_to_signed): New functions.
10912 These signal an error for invalid or out-of-range values.
10913 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10914 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10915 * font.c (Ffont_variation_glyphs):
10916 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10917 * lisp.h: Include <intprops.h>.
10918 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10919 (cons_to_signed, cons_to_unsigned): New decls.
10920 (long_to_cons, cons_to_long): Remove decls.
10921 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10922 (Fprimitive_undo): Use CONS_TO_INTEGER.
10923 * xfns.c (Fx_window_property): Likewise.
10924 * xselect.c: Include <limits.h>.
10925 (x_own_selection, selection_data_to_lisp_data):
10926 Use INTEGER_TO_CONS.
10927 (x_handle_selection_request, x_handle_selection_clear)
10928 (x_get_foreign_selection, Fx_disown_selection_internal)
10929 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10930 (lisp_data_to_selection_data): Use cons_to_unsigned.
10931 (x_fill_property_data): Use cons_to_signed.
10932 Report values out of range.
10933
d1f3d2af
PE
10934 Check for buffer and string overflow more precisely.
10935 * buffer.h (BUF_BYTES_MAX): New macro.
10936 * lisp.h (STRING_BYTES_MAX): New macro.
10937 * alloc.c (Fmake_string):
10938 * character.c (string_escape_byte8):
10939 * coding.c (coding_alloc_by_realloc):
10940 * doprnt.c (doprnt):
10941 * editfns.c (Fformat):
10942 * eval.c (verror):
10943 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10944 since they may not be the same number.
10945 * editfns.c (Finsert_char):
10946 * fileio.c (Finsert_file_contents):
10947 Likewise for BUF_BYTES_MAX.
10948
dd52fcea
PE
10949 * image.c: Use ptrdiff_t, not int, for sizes.
10950 (slurp_file): Switch from int to ptrdiff_t.
10951 All uses changed.
10952 (slurp_file): Check that file size fits in both size_t (for
10953 malloc) and ptrdiff_t (for sanity and safety).
10954
7f9bbdbb
PE
10955 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10956 if b->modtime has its maximal value.
10957
dfe18f82
PE
10958 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10959
84acfcf0
PE
10960 Don't assume time_t can fit into int.
10961 * buffer.h (struct buffer.modtime): Now time_t, not int.
10962 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10963 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10964
ccd9a01a
PE
10965 Minor fixes for signed vs unsigned integers.
10966 * character.h (MAYBE_UNIFY_CHAR):
10967 * charset.c (maybe_unify_char):
10968 * keyboard.c (read_char, reorder_modifiers):
10969 XINT -> XFASTINT, since the integer must be nonnegative.
10970 * ftfont.c (ftfont_spec_pattern):
10971 * keymap.c (access_keymap, silly_event_symbol_error):
10972 XUINT -> XFASTINT, since the integer must be nonnegative.
10973 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10974 since it makes no difference and we prefer signed.
10975 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10976 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10977 nonnegative.
10978
d6d100dd
SM
109792011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10980
10981 * window.h (Fwindow_frame): Declare.
10982
2b6148e4
PE
109832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10984
10985 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10986 (SPARE_MEMORY): Always define.
10987 (LARGE_REQUEST): Remove.
10988 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10989
f230ecc9
MR
109902011-06-06 Martin Rudalics <rudalics@gmx.at>
10991
727e958e
MR
10992 * lisp.h: Move EXFUNS for Fframe_root_window,
10993 Fframe_first_window and Fset_frame_selected_window to window.h.
10994
10995 * window.h: Move EXFUNS for Fframe_root_window,
10996 Fframe_first_window and Fset_frame_selected_window here from
10997 lisp.h.
10998
10999 * frame.c (Fwindow_frame, Fframe_first_window)
11000 (Fframe_root_window, Fframe_selected_window)
11001 (Fset_frame_selected_window): Move to window.c.
11002 (Factive_minibuffer_window): Move to minibuf.c.
11003 (Fother_visible_frames_p): New function.
11004
11005 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11006
f230ecc9
MR
11007 * window.c (decode_window, decode_any_window): Move up in code.
11008 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11009 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11010 (Fwindow_buffer): Move up and rewrite doc-string.
11011 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11012 (Fwindow_prev): New functions.
727e958e
MR
11013 (Fwindow_frame): Move here from frame.c. Accept any window as
11014 argument.
11015 (Fframe_root_window, Fframe_first_window)
11016 (Fframe_selected_window): Move here from frame.c. Accept frame
11017 or arbitrary window as argument. Update doc-strings.
11018 (Fminibuffer_window): Move up in code.
11019 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11020 (Fset_frame_selected_window): Move here from frame.c.
11021 Marginal rewrite.
727e958e
MR
11022 (Fselected_window, select_window, Fselect_window): Move up in
11023 code. Minor doc-string fixes.
f230ecc9 11024
4d09bcf6
PE
110252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11026
11027 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11028 Do not assume that spare memory exists; that assumption is valid
11029 only if SYSTEM_MALLOC.
11030 (LARGE_REQUEST): New macro, so that the issue of large requests
11031 is separated from the issue of spare memory.
11032
810928a2
AS
110332011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11034
172418ad
AS
11035 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11036 format. (Bug#8806)
11037
43f862f7
AS
11038 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11039
810928a2
AS
11040 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11041 before statements.
11042
a059fe24
JD
110432011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11044
11045 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11046
11047 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11048
11049 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11050 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11051
989bf368
JB
110522011-06-05 Juanma Barranquero <lekktu@gmail.com>
11053
11054 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11055
4b80f674
CY
110562011-06-04 Chong Yidong <cyd@stupidchicken.com>
11057
11058 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11059 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11060 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11061 New error handlers.
4b80f674
CY
11062 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11063 Obey Vx_select_enable_clipboard_manager. Catch errors in
11064 x_clipboard_manager_save (Bug#8779).
11065 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11066 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11067
99a33b77 110682011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11069
11070 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11071
99a33b77 110722011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11073
11074 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11075 in the current matrix if keep_current_p is non-zero.
11076
8264569d
EZ
110772011-06-04 Eli Zaretskii <eliz@gnu.org>
11078
11079 * bidi.c (bidi_level_of_next_char): Fix last change.
11080
57f97249
EZ
110812011-06-03 Eli Zaretskii <eliz@gnu.org>
11082
fec2107c 11083 Support bidi reordering of text covered by display properties.
57f97249 11084
fec2107c
EZ
11085 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11086 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11087 (bidi_cache_search, bidi_cache_iterator_state)
11088 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11089 (bidi_level_of_next_char, bidi_move_to_visually_next):
11090 Support character positions inside a run of characters covered by a
fec2107c
EZ
11091 display string.
11092 (bidi_paragraph_init, bidi_resolve_explicit_1)
11093 (bidi_level_of_next_char): Call bidi_fetch_char and
11094 bidi_fetch_char_advance instead of FETCH_CHAR and
11095 FETCH_CHAR_ADVANCE.
11096 (bidi_init_it): Initialize new members.
11097 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11098 definitions.
11099 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11100 instead of using explicit *_CHAR codes.
d6d100dd
SM
11101 (bidi_resolve_explicit, bidi_resolve_weak):
11102 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11103 bidirectional text is supported only in multibyte buffers.
11104 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11105 it to initialize the frame_window_p member of struct bidi_it.
11106 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11107 (bidi_resolve_explicit, bidi_resolve_weak)
11108 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11109 bidi_it->nchars is non-positive.
11110 (bidi_level_of_next_char): Don't try to lookup the cache for the
11111 next/previous character if nothing is cached there yet, or if we
11112 were just reseat()'ed to a new position.
c40e2fb2 11113
0e14fe90
EZ
11114 * xdisp.c (set_cursor_from_row): Set start and stop points
11115 according to the row's direction when priming the loop that looks
11116 for the glyph on which to display cursor.
11117 (single_display_spec_intangible_p): Function deleted.
11118 (display_prop_intangible_p): Reimplement to call
11119 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11120 Accept 3 additional arguments needed by handle_display_spec.
11121 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11122 values: lists, `(when COND...)' forms, etc.
11123 (single_display_spec_string_p): Support property values that are
11124 lists with the argument STRING its top-level element.
11125 (display_prop_string_p): Fix the condition for processing a
11126 property that is a list to be consistent with handle_display_spec.
fec2107c 11127 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11128 last portion of handle_display_prop.
11129 (compute_display_string_pos): Accept additional argument
11130 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11131 value of a `display' property is a "replacing spec".
11132 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11133 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11134 the display property, but just return a value indicating whether
11135 the display property will replace the characters it covers.
11136 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11137 frame_window_p members of struct bidi_it.
d6d100dd
SM
11138 (compute_display_string_pos, compute_display_string_end):
11139 New functions.
fec2107c
EZ
11140 (push_it): Accept second argument POSITION, where pop_it should
11141 jump to continue iteration.
11142 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11143
fec2107c
EZ
11144 * keyboard.c (adjust_point_for_property): Adjust the call to
11145 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11146
11147 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11148 (bidi_init_it): Update prototypes.
11149 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11150 (compute_display_string_pos, compute_display_string_end):
11151 Declare prototypes.
fec2107c
EZ
11152 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11153 EMACS_INT.
fc6f18ce 11154
40087514 111552011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11156
57f53182
PE
11157 Malloc failure behavior now depends on size of allocation.
11158 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11159 * lisp.h: Change signatures accordingly.
11160 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11161 All callers changed. (Bug#8762)
11162
11163 * gnutls.c: Use Emacs's memory allocators.
11164 Without this change, the gnutls library would invoke malloc etc.
11165 directly, which causes problems on non-SYNC_INPUT hosts, and which
11166 runs afoul of improving memory_full behavior. (Bug#8761)
11167 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11168 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11169 xfree instead of the default malloc, realloc, free.
11170 (Fgnutls_boot): No need to check for memory allocation failure,
11171 since xmalloc does that for us.
11172
ac32cd99 11173 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11174 * category.c (hash_get_category_set):
11175 * ccl.c (ccl_driver):
11176 * charset.c (Fdefine_charset_internal):
11177 * charset.h (struct charset.hash_index):
11178 * composite.c (get_composition_id, gstring_lookup_cache)
11179 (composition_gstring_put_cache):
11180 * composite.h (struct composition.hash_index):
11181 * dispextern.h (struct image.hash):
11182 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11183 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11184 (hashfn_equal, hashfn_user_defined, make_hash_table)
11185 (maybe_resize_hash_table, hash_lookup, hash_put)
11186 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11187 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11188 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11189 * image.c (make_image, search_image_cache, lookup_image)
11190 (xpm_put_color_table_h):
11191 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11192 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11193 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11194 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11195 * alloc.c (allocate_vectorlike):
11196 Check for overflow in vector size calculations.
11197 * ccl.c (ccl_driver):
11198 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11199 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11200 need to be updated by these changes.
40087514
PE
11201 * fns.c (make_hash_table, maybe_resize_hash_table):
11202 Check for integer overflow with large hash tables.
0de4bb68
PE
11203 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11204 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11205 (SXHASH_REDUCE): New macro.
11206 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11207 Use it instead of discarding useful hash info with large hash values.
11208 (sxhash_float): New function.
11209 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11210 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11211 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11212 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11213 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11214 Adjust signatures to match updated version of code.
11215 (consing_since_gc): Now EMACS_INT, since a single hash table can
11216 use more than INT_MAX bytes.
11217
698d32e2
DN
112182011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11219
11220 Make it possible to build with GCC-4.6+ -O2 -flto.
11221
11222 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11223
fd6fa53f
SM
112242011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11225
11226 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11227 Call minibuffer-inactive-mode.
11228
864db017
JB
112292011-05-31 Juanma Barranquero <lekktu@gmail.com>
11230
11231 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11232 Update dependencies.
11233
2ad0baf4
DN
112342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11235
11236 * data.c (init_data): Remove code for UTS, this system is not
11237 supported anymore.
11238
4fcc2638
DN
112392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11240
11241 Don't force ./temacs to start in terminal mode.
11242
11243 * frame.c (make_initial_frame): Initialize faces in all cases, not
11244 only when CANNOT_DUMP is defined.
11245 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11246
c56e0fd5
DN
112472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11248
11249 * dispnew.c (add_window_display_history): Use const for the string
11250 pointer. Remove declaration, not needed.
11251
333d54da 112522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11253
55d4c1b2 11254 Use 'inline', not 'INLINE'.
333d54da 11255 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11256 * alloc.c, fontset.c (INLINE): Remove.
11257 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11258 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11259 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11260 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11261 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11262
738db178
DN
112632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11264
11265 Make it possible to run ./temacs.
11266
11267 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11268 syms_of_callproc does the same thing. Remove test for
11269 "initialized", do it in the caller.
11270 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11271
620c53a6
SM
112722011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11273
11274 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11275 (read_minibuf): Use get_minibuffer.
11276 (syms_of_minibuf): Use DEFSYM.
11277 (Qmetadata): New var.
11278 * data.c (Qbuffer): Don't make it static.
11279 (syms_of_data): Use DEFSYM.
11280
e003a292
PE
112812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11282
11283 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11284 (CCL_CODE_MIN): New macro.
11285
ed008a6d
PE
112862011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11287
3687c2ef
PE
11288 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11289
ed008a6d
PE
11290 * eval.c (Qdebug): Now static.
11291 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11292 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11293 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11294
d66c4c7c
CY
112952011-05-29 Chong Yidong <cyd@stupidchicken.com>
11296
11297 * image.c: Various fixes to ImageMagick code comments.
11298 (Fimagemagick_types): Doc fix.
11299
5fbc2025
PE
113002011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11301
0196f88a
PE
11302 Minor fixes prompted by GCC 4.6.0 warnings.
11303
11304 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11305
5fbc2025
PE
11306 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11307 (x_clipboard_manager_save_all): Move extern decl to ...
11308 * xterm.h: ... here, so that it can be checked for consistency.
11309
1dd3c2d9
CY
113102011-05-29 Chong Yidong <cyd@stupidchicken.com>
11311
11312 * xselect.c (x_clipboard_manager_save_frame)
11313 (x_clipboard_manager_save_all): New functions.
11314 (Fx_clipboard_manager_save): Lisp function deleted.
11315
11316 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11317 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11318
11319 * xterm.h: Update prototype.
11320
5ba6571d
WX
113212011-05-28 William Xu <william.xwl@gmail.com>
11322
11323 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11324 exiting (Bug#8239).
11325
3eaff834
JM
113262011-05-28 Jim Meyering <meyering@redhat.com>
11327
e1900994 11328 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11329 * fns.c (to_uchar): Define.
11330 (crypto_hash_function): Use it to convert some newly-signed
11331 variables to unsigned, to avoid sign-extension bugs. For example,
11332 without this change, (md5 "truc") would evaluate to
11333 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11334 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11335 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11336
0f6990a7
PE
113372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11338
11339 Integer overflow fixes.
c8a9ca5a 11340
08686060
PE
11341 * dbusbind.c: Serial number integer overflow fixes.
11342 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11343 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11344 to hold a serial number that is too large for a fixnum.
11345 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11346 Check for serial numbers out of range. Decode any serial number
59568bf0 11347 that was so large that it became a float. (Bug#8722)
08686060 11348
2d1fc3c7
PE
11349 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11350 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11351 Use XFASTINT rather than XUINT when numbers are nonnegative.
11352 (xd_append_arg, Fdbus_method_return_internal):
11353 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11354 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11355 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11356 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11357 (Bug#8722)
2d1fc3c7 11358
c8a9ca5a
PE
11359 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11360
519e1d69
PE
11361 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11362
6df6ae42 11363 ccl: Add integer overflow checks.
30569699
PE
11364 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11365 (IN_INT_RANGE): New macros.
11366 (ccl_driver): Use them to check for integer overflow when
11367 decoding a CCL program. Many of the new checks are whether XINT (x)
11368 fits in int; it doesn't always, on 64-bit hosts. The new version
11369 doesn't catch all possible integer overflows, but it's an
847044ea 11370 improvement. (Bug#8719)
30569699 11371
c11285dc
PE
11372 * alloc.c (make_event_array): Use XINT, not XUINT.
11373 There's no need for unsigned here.
11374
fdccd48e
PE
11375 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11376 This follows up to the 2011-05-06 change that substituted uintptr_t
11377 for EMACS_INT. This case wasn't caught back then.
11378
37910ab2
PE
11379 Rework Fformat to avoid integer overflow issues.
11380 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11381 now (part of C89). Include <verify.h>.
11382 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11383 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11384 (Fformat): Avoid the prepass trying to compute sizes; it was only
11385 approximate and thus did not catch overflow reliably. Instead, walk
11386 through the format just once, formatting and computing sizes as we go,
11387 checking for integer overflow at every step, and allocating a larger
11388 buffer as needed. Keep track separately whether the format is
11389 multibyte. Keep only the most-recently calculated precision, rather
11390 than them all. Record whether each argument has been converted to
11391 string. Use EMACS_INT, not int, for byte and char and arg counts.
11392 Support field widths and precisions larger than INT_MAX. Avoid
11393 sprintf's undefined behavior with conversion specifications such as %#d
11394 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11395 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11396 formatting out-of-range floating point numbers with int
9173deec 11397 formats. (Bug#8668)
37910ab2 11398
2e6578fb
PE
11399 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11400
0ae6bdee
PE
11401 * data.c: Avoid integer truncation in expressions involving floats.
11402 * data.c: Include <intprops.h>.
11403 (arith_driver): When there's an integer overflow in an expression
11404 involving floating point, convert the integers to floating point
11405 so that the resulting value does not suffer from catastrophic
11406 integer truncation. For example, on a 64-bit host (* 4
11407 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11408 Do not rely on undefined behavior after integer overflow.
11409
de883a70
PE
11410 merge count_size_as_multibyte, parse_str_to_multibyte
11411 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11412 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11413 Check for integer overflow.
11414 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11415 since it's now a duplicate of the other. This is more of
11416 a character than a buffer op, so better that it's in character.c.
11417 * fns.c, print.c: Adjust to above changes.
11418
2ff916cb
PE
114192011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11420
11421 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11422
f1b54466
PE
114232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11424
fb1ac845
PE
11425 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11426 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11427 (x_clipboard_manager_save): Now static.
11428 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11429
f1b54466
PE
11430 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11431 (crypto_hash_function): Now static.
11432 Fix pointer signedness problems. Avoid unnecessary initializations.
11433
a9f737ee
CY
114342011-05-27 Chong Yidong <cyd@stupidchicken.com>
11435
11436 * termhooks.h (Vselection_alist): Make it terminal-local.
11437
11438 * terminal.c (create_terminal): Initialize it.
11439
11440 * xselect.c: Support for clipboard managers.
11441 (Vselection_alist): Move to termhooks.h as terminal-local var.
11442 (LOCAL_SELECTION): New macro.
11443 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11444 (symbol_to_x_atom): Remove gratuitous arg.
11445 (x_handle_selection_request, lisp_data_to_selection_data)
11446 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11447 (x_own_selection, x_get_local_selection, x_convert_selection):
11448 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11449 (some_frame_on_display): Delete unused function.
11450 (Fx_own_selection_internal, Fx_get_selection_internal)
11451 (Fx_disown_selection_internal, Fx_selection_owner_p)
11452 (Fx_selection_exists_p): New optional frame arg.
11453 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11454 (x_handle_selection_clear): Don't treat other terminals with the
11455 same keyboard specially. Use the terminal-local Vselection_alist.
11456 (x_clear_frame_selections): Use Frun_hook_with_args.
11457
11458 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11459
11460 * xterm.h: Add support for those atoms.
11461
e067f0c1
CY
114622011-05-26 Chong Yidong <cyd@stupidchicken.com>
11463
11464 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11465 (converted_selections, conversion_fail_tag): New global variables.
11466 (x_selection_request_lisp_error): Free the above.
11467 (x_get_local_selection): Remove unnecessary code.
11468 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11469 of converted selections stored in converted_selections.
11470 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11471 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11472 (x_convert_selection): New function.
11473 (x_handle_selection_event): Simplify.
11474 (x_get_foreign_selection): Don't ignore incoming requests while
11475 waiting for an answer; this will fail when we implement
11476 SAVE_TARGETS, and seems unnecessary anyway.
11477 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11478 (Vx_sent_selection_functions): Doc fix.
11479
0f4aebc0
LL
114802011-05-26 Leo Liu <sdl.web@gmail.com>
11481
11482 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11483
e61124cd
YM
114842011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11485
11486 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11487
11488 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11489 for fringe update if it has periodic bitmap.
ac389d0c 11490 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11491 and fringe_bitmap_periodic_p.
11492
11493 * fringe.c (get_fringe_bitmap_data): New function.
11494 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11495 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11496 row. Mark glyph row for fringe update if periodicity changed.
11497
11498 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11499 for fringe update unless it has periodic bitmap.
11500
f16d9837
KH
115012011-05-25 Kenichi Handa <handa@m17n.org>
11502
11503 * xdisp.c (get_next_display_element): Set correct it->face_id for
11504 a static composition.
11505
e1b90ef6
LL
115062011-05-24 Leo Liu <sdl.web@gmail.com>
11507
11508 * deps.mk (fns.o):
11509 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11510
11511 * fns.c (crypto_hash_function, Fsha1): New function.
11512 (Fmd5): Use crypto_hash_function.
11513 (syms_of_fns): Add Ssha1.
11514
7400048f
PE
115152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11516
11517 * gnutls.c: Remove unused macros.
11518 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11519 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11520 Remove macros that are defined and never used.
11521 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11522
abb71cf4
CY
115232011-05-22 Chong Yidong <cyd@stupidchicken.com>
11524
11525 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11526 (Fx_get_selection_internal): Minor cleanup.
11527 (Fx_own_selection_internal): Rename arguments for consistency with
11528 select.el.
11529
6307db39
PE
115302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11531
11532 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11533
f3d4e0a4
CY
115342011-05-22 Chong Yidong <cyd@stupidchicken.com>
11535
11536 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11537
4d8ade89
YM
115382011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11539
11540 * dispnew.c (scrolling_window): Don't exclude the case that the
11541 last enabled row in the desired matrix touches the bottom boundary.
11542
32078c8d
GM
115432011-05-21 Glenn Morris <rgm@gnu.org>
11544
11545 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11546 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11547 and add some more files.
32078c8d 11548
7285dc67
EZ
115492011-05-20 Eli Zaretskii <eliz@gnu.org>
11550
11551 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11552 report_file_error introduced by the change from 2011-05-07.
11553
89d1bd22
PE
115542011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11555
11556 * systime.h (Time): Define only if emacs is defined.
11557 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11558 where the include path doesn't have X11/X.h by default. See
11559 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11560
cd394be1 115612011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11562
11563 * composite.c (find_automatic_composition): Fix previous change.
11564
b9704ad9
GM
115652011-05-20 Glenn Morris <rgm@gnu.org>
11566
11567 * lisp.mk: New file, split from Makefile.in.
11568 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11569 (shortlisp): Remove.
11570 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11571
4a720484
GM
115722011-05-19 Glenn Morris <rgm@gnu.org>
11573
11574 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11575 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11576 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11577 (lisp): Set the order to that of loadup.el.
11578 (shortlisp): Make it a copy of $lisp.
11579 (SOME_MACHINE_LISP): Remove.
11580 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11581 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11582
a28d4396
KH
115832011-05-18 Kenichi Handa <handa@m17n.org>
11584
11585 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11586 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11587 (find_automatic_composition): Mostly rewrite for efficiency.
11588
a2b1fa8e
JB
115892011-05-18 Juanma Barranquero <lekktu@gmail.com>
11590
11591 * makefile.w32-in: Update dependencies.
11592
8e1f5610
CS
115932011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11594
11595 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11596 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11597
7025ee00 115982011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11599
cdfa6eab
PE
11600 Fix some integer overflow issues, such as string length overflow.
11601
06d6db33
PE
11602 * insdel.c (count_size_as_multibyte): Check for string overflow.
11603
2b4560a8
PE
11604 * character.c (lisp_string_width): Check for string overflow.
11605 Use EMACS_INT, not int, for string indexes and lengths; in
11606 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11607 the resulting string length overflows an EMACS_INT; instead,
11608 report a string overflow if no precision given. When checking for
11609 precision exhaustion, use a check that cannot possibly have
11610 integer overflow. (Bug#8675)
11611 * character.h (lisp_string_width): Adjust to new signature.
11612
cb93f9be
PE
11613 * alloc.c (string_overflow): New function.
11614 (Fmake_string): Use it. This doesn't change behavior, but saves
11615 a few bytes and will simplify future changes.
11616 * character.c (string_escape_byte8): Likewise.
11617 * lisp.h (string_overflow): New decl.
11618
1a1f3366
PE
11619 Fixups, following up to the user-interface timestamp change.
11620 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11621 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11622 * msdos.c (mouse_get_pos): Likewise.
11623 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11624 * w32gui.h (Time): Define by including "systime.h" rather than by
11625 declaring it ourselves. (Bug#8664)
11626
d4e3e4d3
PE
11627 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11628 * image.c (clear_image_cache): Likewise.
11629
f6a24d19
PE
11630 * term.c (term_mouse_position): Don't assume time_t wraparound.
11631
08dc5ae6
PE
11632 Be more systematic about user-interface timestamps.
11633 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11634 and sometimes 'EMACS_UINT', to represent these timestamps.
11635 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11636 This makes the code easier to follow, and makes it easier to catch
11637 integer overflow bugs such as Bug#8664.
11638 * frame.c (Fmouse_position, Fmouse_pixel_position):
11639 Use Time, not unsigned long, for user-interface timestamps.
11640 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11641 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11642 * keyboard.h (last_event_timestamp): Likewise.
11643 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11644 * menu.h (xmenu_show): Likewise.
11645 * term.c (term_mouse_position): Likewise.
11646 * termhooks.h (struct input_event.timestamp): Likewise.
11647 (struct terminal.mouse_position_hook): Likewise.
11648 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11649 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11650 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11651 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11652 what it was before.
11653 * menu.h, termhooks.h: Include "systime.h", for Time.
11654
8e55734a
PE
11655 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11656 Don't assume that the difference between two unsigned long values
11657 can fit into an integer. At this point, we know button_down_time
11658 <= event->timestamp, so the difference must be nonnegative, so
11659 there's no need to cast the result if double-click-time is
11660 nonnegative, as it should be; check that it's nonnegative, just in
11661 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11662 apart (about 25 days). (Bug#8664)
8e55734a 11663
841f1b75 11664 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11665 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11666
3e26f69c
PE
11667 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11668 that always fit in int. Use a sentinel instead of a counter, to
11669 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11670 * frame.h (struct frame): Use int for menu_bar_items_used
11671 instead of EMACS_INT, since it always fits in int.
3e26f69c 11672
5cc152c0
PE
11673 * menu.c (grow_menu_items): Check for int overflow.
11674
d89eb65e
PE
11675 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11676
5235bd3e
PE
11677 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11678 Before, the code was not consistent. These values cannot exceed
11679 2**31 - 1 so there's no need to make them unsigned.
11680 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11681 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11682 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11683 as modifiers.
11684 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11685
bc827e23
PE
11686 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11687 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11688 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11689 presumably because the widths might not match.
11690
78eb494e
PE
11691 * window.c (size_window): Avoid needless test at loop start.
11692
04f2d78b
CB
116932011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11694
11695 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11696
d2fc7e3d 116972011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11698
11699 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11700
d2fc7e3d 117012011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11702
11703 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11704 `width' to `bar_area_x' and `bar_area_width', respectively.
11705 (x_scroll_run): Take account of fringe background extension.
11706
04f2d78b
CB
11707 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11708 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11709 `bar_area_width', respectively.
11710 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11711 background extension.
11712
79b70037
GM
117132011-05-10 Jim Meyering <meyering@redhat.com>
11714
11715 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11716
2f142cc5
JB
117172011-05-10 Juanma Barranquero <lekktu@gmail.com>
11718
11719 * image.c (Finit_image_library): Return t for built-in image types,
11720 like pbm and xbm. (Bug#8640)
11721
57679c86
AS
117222011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11723
11724 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11725
888c9e86
EZ
117262011-05-07 Eli Zaretskii <eliz@gnu.org>
11727
b0512a1d
EZ
11728 * w32console.c (Fset_screen_color): Doc fix.
11729 (Fget_screen_color): New function.
11730 (syms_of_ntterm): Defsubr it.
11731
7285dc67
EZ
11732 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11733 unlink the temporary file if Fcall_process didn't create it in the
11734 first place.
11735 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11736 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11737 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11738 cue to call_process_cleanup not to close that handle.
11739
4d3fcc8e
BK
117402011-05-07 Ben Key <bkey76@gmail.com>
11741
11742 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11743 one of two shell specific rules, either bootstrap-temacs-CMD or
11744 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11745 to the previous implementation of the bootstrap-temacs rule.
11746 The bootstrap-temacs-CMD rule is similar to the previous
11747 implementation of the bootstrap-temacs rule except that it
11748 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11749 variable.
11750
11751 These changes, along with some changes to nt/configure.bat,
11752 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11753 earlier fix to add support for --cflags and --ldflags options
11754 that include quotes so that it works whether make uses cmd or
11755 sh as the shell.
11756
b4289b64
MA
117572011-05-06 Michael Albinus <michael.albinus@gmx.de>
11758
11759 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11760 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11761 is a constant.
11762 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11763 a string. Handle both cases.
11764 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11765 (Fdbus_register_method): Use Qinvalid_function.
11766
af4c0e28
JB
117672011-05-06 Juanma Barranquero <lekktu@gmail.com>
11768
11769 * makefile.w32-in: Update dependencies.
11770 (LISP_H): Add inttypes.h and stdin.h.
11771 (PROCESS_H): Add unistd.h.
11772
c51453d9
EZ
117732011-05-06 Eli Zaretskii <eliz@gnu.org>
11774
11775 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11776 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11777
8ff0ac3c 117782011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11779
4c4b566b
PE
11780 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11781
aab2b9b5
PE
11782 * term.c (vfatal): Remove stray call to va_end.
11783 It's not needed and the C Standard doesn't allow it here anyway.
11784
c378da0b
PE
11785 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11786 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11787
288b08c7
PE
11788 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11789 bytes.
11790
e3601888
PE
11791 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11792
db6c0e74
PE
11793 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11794
dd5963ea
PE
11795 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11796
88c9450f
PE
11797 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11798
2f9442b8
PE
11799 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11800
c032b5f8
PE
11801 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11802 * charset.c (Fdefine_charset_internal): Don't initialize
11803 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11804 32-bit int (Bug#8600).
a108c10b
PE
11805
11806 * lread.c (read_integer): Be more consistent with string-to-number.
11807 Use string_to_number to do the actual conversion; this avoids
11808 rounding errors and fixes some other screwups. Without this fix,
11809 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11810 (digit_to_number): Move earlier, for benefit of read_integer.
11811 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11812 not a digit in any supported base. (Bug#8602)
a108c10b 11813
ad5f9eea
PE
11814 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11815
aec1708a
PE
11816 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11817 to match comment at start of function. This also removes a
11818 GCC warning about overflow in a 32+64-bit port.
11819
47be4ab5
PE
11820 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11821
371cac43
PE
11822 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11823 Reported by Stefan Monnier in
11824 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11825 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11826 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11827
d01a7826
PE
11828 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11829 (EMACS_UINTPTR): Likewise, with uintptr_t.
11830
7fd47d5c
PE
11831 * lisp.h: Prefer 64-bit EMACS_INT if available.
11832 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11833 on 32-bit hosts that have 64-bit int, so that they can access
11834 large files.
122b0c86
PE
11835 However, temporarily disable this change unless the temporary
11836 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11837
8727937b
PE
11838 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11839
8ac068ac
PE
11840 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11841 This removes an assumption that EMACS_INT and long are the same
11842 width as pointers. The assumption is true for Emacs porting targets
11843 now, but we want to make other targets possible.
11844 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11845 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11846 In the rest of the code, change types of integers that hold casted
11847 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11848 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11849 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11850 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11851 No need to cast type when ORing.
11852 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11853 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11854 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11855 assume EMACS_INT is the same width as char *.
11856 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11857 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11858 Remove no-longer-needed casts.
11859 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11860 (xg_tool_bar_help_callback, xg_make_tool_item):
11861 Use EMACS_INTPTR to hold an integer
11862 that will be cast to void *; this can avoid a GCC warning
11863 if EMACS_INT is not the same width as void *.
11864 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11865 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11866 (current_message_1, set_message_1):
11867 Use a local to convert to proper width without a cast.
11868 * xmenu.c (dialog_selection_callback): Likewise.
11869
ede49d71
PE
11870 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11871 Also, don't assume VALBITS / RAND_BITS is less than 5,
11872 and don't rely on undefined behavior when shifting a 1 left into
11873 the sign bit.
11874 * lisp.h (get_random): Change signature to match.
11875
2f30ecd0
PE
11876 * lread.c (hash_string): Use size_t, not int, for hash computation.
11877 Normally we prefer signed values; but hashing is special, because
11878 it's better to use unsigned division on hash table sizes so that
11879 the remainder is nonnegative. Also, size_t is the natural width
11880 for hashing into memory. The previous code used 'int', which doesn't
11881 retain enough info to hash well into very large tables.
11882 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11883
2a866e7b
PE
11884 * dbusbind.c: Don't possibly lose pointer info when converting.
11885 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11886 Use XPNTR rather than XHASH, so that the high-order bits of
11887 the pointer aren't lost when converting through void *.
11888
51639eac
PE
11889 * eval.c (Fautoload): Don't double-shift a pointer.
11890
92394119
PE
11891 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11892
dbdb9a7c
JB
118932011-05-06 Juanma Barranquero <lekktu@gmail.com>
11894
11895 * gnutls.c (DEF_GNUTLS_FN):
11896 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11897
db7a0b4f
AS
118982011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11899
11900 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11901 marker. (Bug#8610)
11902
cd394be1 119032011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11904
11905 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11906 New version that can reserve upto 2GB of heap space.
11907
f7ff1b0f 119082011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11909
11910 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11911
639c109b
TZ
119122011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11913
11914 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11915 `gnutls_certificate_set_x509_key_file'.
11916
d2127135
JB
119172011-05-05 Juanma Barranquero <lekktu@gmail.com>
11918
11919 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11920 Update dependencies.
11921
e968f4f3
JB
119222011-05-04 Juanma Barranquero <lekktu@gmail.com>
11923
11924 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11925 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11926 Remove unused parameter `fildes'.
11927 * process.c (read_process_output, send_process): Don't pass it.
11928
84d358f0
JB
119292011-05-04 Juanma Barranquero <lekktu@gmail.com>
11930
11931 Fix previous change: the library cache is defined in w32.c.
11932 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11933 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11934
0898ca10
JB
119352011-05-04 Juanma Barranquero <lekktu@gmail.com>
11936
11937 Implement dynamic loading of GnuTLS on Windows.
11938
11939 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11940 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11941 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11942 Declare.
11943
11944 * gnutls.c (Qgnutls_dll): Define.
11945 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11946 (gnutls_*): Declare function pointers.
11947 (init_gnutls_functions): New function to initialize function pointers.
11948 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11949 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11950 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11951 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11952 (emacs_gnutls_write, emacs_gnutls_read)
11953 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11954 (Fgnutls_available_p): New function.
11955 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11956 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11957 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11958
11959 * image.c: Include w32.h.
11960 (Vimage_type_cache): Delete.
11961 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11962 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11963 (w32_delayed_load): Move to w32.c.
11964
11965 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11966
11967 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11968 (w32_delayed_load): Move from image.c. When loading a library, record
11969 its filename in the :loaded-from property of the library id.
11970 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11971 Initialize and staticpro them.
11972 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11973
11974 * process.c: Include lisp.h before w32.h, not after.
11975 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11976 instead of gnutls_record_check_pending.
11977
11978 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11979
ff4de4aa
TZ
119802011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11981
11982 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11983 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11984 as passed in.
11985
abe95abb
JD
119862011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11987
11988 * xterm.c (x_set_frame_alpha): Do not set property on anything
11989 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11990
e16e55d4
JB
119912011-05-02 Juanma Barranquero <lekktu@gmail.com>
11992
11993 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11994
bafcf6a5
JB
119952011-05-02 Juanma Barranquero <lekktu@gmail.com>
11996
11997 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11998 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11999 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12000 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12001 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12002 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12003 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12004 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12005 (Qgnutls_bootprop_callbacks_verify): Make static.
12006
e7a6747f
AS
120072011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12008
19ed11ba
AS
12009 * callproc.c: Indentation fixup.
12010
e7a6747f 12011 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12012 (wait_for_termination, interruptible_wait_for_termination):
12013 Move after wait_for_termination_1.
e7a6747f 12014
1ef14cb4
LMI
120152011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12016
12017 * sysdep.c (interruptible_wait_for_termination): New function
12018 which is like wait_for_termination, but allows keyboard
12019 interruptions.
12020
12021 * callproc.c (Fcall_process): Add (:file "file") as an option for
12022 the STDOUT buffer.
12023 (Fcall_process_region): Ditto.
12024
330d880c
EZ
120252011-04-30 Eli Zaretskii <eliz@gnu.org>
12026
8db90b73
EZ
12027 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12028 rather than `XVECTOR (FOO)->size'.
12029
330d880c
EZ
12030 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12031 inttypes.h, as a gnulib replacement is used if it not available in
12032 system headers.
12033
15cbd324
EZ
120342011-04-21 Eli Zaretskii <eliz@gnu.org>
12035
12036 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12037 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12038 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12039
12040 * coding.c (coding_alloc_by_realloc): Error out if destination
12041 will grow beyond MOST_POSITIVE_FIXNUM.
12042 (decode_coding_emacs_mule): Abort if there isn't enough place in
12043 charbuf for the composition carryover bytes. Reserve an extra
12044 space for up to 2 characters produced in a loop.
12045 (decode_coding_iso_2022): Abort if there isn't enough place in
12046 charbuf for the composition carryover bytes.
12047
120482011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12049
ae940cca
EZ
12050 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12051 aborting when %lld or %lll format is passed.
12052 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12053 %llo or %llx format is passed. (Bug#8545)
12054
03ab8921
EZ
12055 * window.c (window_scroll_line_based): Use a marker instead of
12056 simple variables to record original value of point. (Bug#7952)
12057
afda1437
EZ
12058 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12059 produced by %s or %c overflows available buffer space. (Bug#8545)
12060
f76dee0c
PE
120612011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12062
12063 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12064 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12065
fdc5744d
JB
120662011-04-28 Juanma Barranquero <lekktu@gmail.com>
12067
12068 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12069
638f053a
JB
120702011-04-28 Juanma Barranquero <lekktu@gmail.com>
12071
12072 * keyboard.c (Qdelayed_warnings_hook): Define.
12073 (command_loop_1): Run `delayed-warnings-hook'
12074 if Vdelayed_warnings_list is non-nil.
12075 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12076 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12077
d178f871
EZ
120782011-04-28 Eli Zaretskii <eliz@gnu.org>
12079
12080 * doprnt.c (doprnt): Don't return value smaller than the buffer
12081 size if the message was truncated. (Bug#8545).
12082
b124fd93
JB
120832011-04-28 Juanma Barranquero <lekktu@gmail.com>
12084
12085 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12086 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12087
e810457d
PE
120882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12089
12090 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12091
ea51cceb
JB
120922011-04-27 Juanma Barranquero <lekktu@gmail.com>
12093
12094 * makefile.w32-in: Update dependencies.
12095
94dcfacf
EZ
120962011-04-27 Eli Zaretskii <eliz@gnu.org>
12097
12098 Improve `doprnt' and its usage. (Bug#8545)
12099 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12100 `format_end'. Remove support for %l as a conversion specifier.
12101 Don't use xrealloc. Improve diagnostics when the %l size modifier
12102 is used. Update the commentary.
12103
12104 * eval.c (verror): Simplify calculation of size_t.
12105
12106 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12107 messages.
12108
f61f41d7
PE
121092011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12110
12111 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12112 change.
12113
96fb4434
PE
121142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12115
12116 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12117 This makes this file independent of the recent pseudovector change.
12118
671875da 121192011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12120
69e9b5a3
PE
12121 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12122
b5f869a7 12123 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12124 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12125 Remove unused local.
c8926152 12126 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12127
841a1577 12128 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12129 GCC 4.6.0 optimizes based on type-based alias analysis.
12130 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12131 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12132 != &v->size, and therefore "v->size = 1; b->size = 2; return
12133 v->size;" must therefore return 1. This assumption is incorrect
12134 for Emacs, since it type-puns struct Lisp_Vector * with many other
12135 types. To fix this problem, this patch adds a new type struct
f904488f 12136 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12137 and pseudovectors, and helps optimizing compilers not get fooled
12138 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12139 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12140 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12141 the size member.
eab3844f
PE
12142 (XSETPVECTYPE): Rewrite in terms of new macro.
12143 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12144 This is a bit clearer, and further avoids the possibility of
12145 undesirable aliasing.
12146 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12147 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12148 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12149 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12150 (ASIZE): Now uses header.size rather than size.
12151 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12152 to avoid the hassle of writing XVECTOR (foo)->header.size.
12153 (struct vectorlike_header): New type.
eab3844f
PE
12154 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12155 object, to help avoid aliasing.
12156 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12157 (SUBRP): Likewise, since Lisp_Subr is a special case.
12158 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12159 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12160 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12161 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12162 changed to be "header.size" and "header.next".
12163 * buffer.h (struct buffer): Likewise.
12164 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12165 * frame.h (struct frame): Likewise.
12166 * process.h (struct Lisp_Process): Likewise.
12167 * termhooks.h (struct terminal): Likewise.
12168 * window.c (struct save_window_data, struct saved_window): Likewise.
12169 * window.h (struct window): Likewise.
12170 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12171 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12172 * buffer.c (init_buffer_once): Likewise.
12173 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12174 special case.
12175 * process.c (Fformat_network_address): Use local var for size,
12176 for brevity.
12177
0df1eac5
PE
12178 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12179
847ab9d1 12180 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12181 * data.c (atof): Remove decl; no longer used or needed.
12182 (digit_to_number): Move to lread.c.
12183 (Fstring_to_number): Use new string_to_number function, to be
12184 consistent with how the Lisp reader treats infinities and NaNs.
12185 Do not assume that floating-point numbers represent EMACS_INT
12186 without losing information; this is not true on most 64-bit hosts.
12187 Avoid double-rounding errors, by insisting on integers when
12188 parsing non-base-10 numbers, as the documentation specifies.
12189 * lisp.h (string_to_number): New decl, replacing ...
12190 (isfloat_string): Remove.
bc0a5c13 12191 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12192 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12193 appears to have been a coding error. Similarly, do not accept
12194 strings like +-1e0 as floating point numbers. Do not report
12195 overflow for integer overflows unless the base is not 10 which
12196 means we have no simple and reliable way to continue.
12197 Break out the floating-point parsing into a new
12198 function string_to_number, so that Fstring_to_number parses
12199 floating point numbers consistently with the Lisp reader.
04f2d78b 12200 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12201 (E_CHAR, EXP_INT): Remove, replacing with ...
12202 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12203 (string_to_number): New function, replacing isfloat_string.
12204 This function checks for valid syntax and produces the resulting
12205 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12206 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12207 so that overflow for non-base-10 numbers is reported only when
12208 there's no portable and simple way to convert to floating point.
452f4150 12209
67769ffc
PE
12210 * textprop.c (set_text_properties_1): Rewrite for clarity,
12211 and to avoid GCC warning about integer overflow.
12212
c20db43f
PE
12213 * intervals.h (struct interval): Use EMACS_INT for members
12214 where EMACS_UINT might cause problems. See
12215 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12216 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12217 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12218 All uses changed.
37aa2f85
PE
12219 (offset_intervals): Tell GCC not to worry about length overflow
12220 when negating a negative length.
c20db43f 12221
2538aa2f
PE
12222 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12223 (overrun_check_free): Likewise.
12224
f2d3008d
PE
12225 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12226 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12227 word size.
12228
ec8df744
PE
12229 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12230 (gnutls_make_error): Rename local to avoid shadowing.
12231 (gnutls_emacs_global_deinit): ifdef out; not used.
12232 (Fgnutls_boot): Use const for pointer to readonly storage.
12233 Comment out unused local. Fix pointer signedness problems.
12234
640ee02d
PE
12235 * lread.c (openp): Don't stuff size_t into an 'int'.
12236 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12237 about possible signed overflow.
12238
6048fb2a
PE
12239 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12240 (GDK_KEY_g): Don't define if already defined.
12241 (xg_prepare_tooltip): Avoid pointer signedness problem.
12242 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12243
fa3c87e1
PE
12244 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12245 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12246
2172544b
PE
12247 * xfns.c (Fx_window_property): Simplify a bit,
12248 to make a bit faster and to avoid GCC 4.6.0 warning.
12249 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12250
9b821a21
PE
12251 * fns.c (internal_equal): Don't assume size_t fits in int.
12252
3c616cfa
PE
12253 * alloc.c (compact_small_strings): Tighten assertion a little.
12254
c2982e87
PE
12255 Replace pEd with more-general pI, and fix some printf arg casts.
12256 * lisp.h (pI): New macro, generalizing old pEd macro to other
12257 conversion specifiers. For example, use "...%"pI"d..." rather
12258 than "...%"pEd"...".
12259 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12260 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12261 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12262 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12263 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12264 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12265 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12266 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12267 64-bit hosts.
12268 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12269 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12270 * print.c (safe_debug_print, print_object): Likewise.
12271 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12272 to int.
6f04d126
PE
12273 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12274 avoiding the 0 flag, which is not portable.
c2982e87
PE
12275 * process.c (Fmake_network_process): Use pI to avoid cast.
12276 * region-cache.c (pp_cache): Likewise.
12277 * xdisp.c (decode_mode_spec): Likewise.
12278 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12279 behavior on 64-bit hosts with printf arg.
6f04d126 12280 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12281 (x_stop_queuing_selection_requests): Likewise.
12282 (x_get_window_property): Don't truncate byte count to an 'int'
12283 when tracing.
0b432f21 12284
5e073ec7
PE
12285 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12286 here, since it parses constructs like leading '-' and spaces,
12287 which are not wanted; and it overflows with large numbers.
12288 Instead, simply match F[0-9]+, which is what is wanted anyway.
12289
36372bf9
PE
12290 * alloc.c: Remove unportable assumptions about struct layout.
12291 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12292 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12293 (allocate_vectorlike, make_pure_vector): Use the new macros,
12294 plus offsetof, to remove unportable assumptions about struct layout.
12295 These assumptions hold on all porting targets that I know of, but
12296 they are not guaranteed, they're easy to remove, and removing them
12297 makes further changes easier.
12298
0b432f21
PE
12299 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12300 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12301 (string_overrun_cookie): Now const. Use initializers that
12302 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12303 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12304 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12305 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12306 multiple of sizeof (EMACS_INT); it need not be, if
12307 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12308 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12309
895009e1
JB
123102011-04-26 Juanma Barranquero <lekktu@gmail.com>
12311
12312 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12313
6a7a1b0b
TZ
123142011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12315
12316 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12317 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12318 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12319
841a1577 123202011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12321
12322 * lisp.h (Qdebug): List symbol.
895009e1 12323 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12324 * keyboard.c (debug-on-event): New variable.
12325 (handle_user_signal): Break into debugger when debug-on-event
12326 matches the current signal symbol.
12327
f2d3ba6f
DN
123282011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12329
12330 * alloc.c (check_sblock, check_string_bytes)
12331 (check_string_free_list): Convert to standard C.
12332
42ce4c63
TZ
123332011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12334
12335 * w32.c (emacs_gnutls_push): Fix typo.
12336
825cd63c
EZ
123372011-04-25 Eli Zaretskii <eliz@gnu.org>
12338
fb11d64d
EZ
12339 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12340 "cast to pointer from integer of different size".
12341
825cd63c
EZ
12342 Improve doprnt and its use in verror. (Bug#8545)
12343 * doprnt.c (doprnt): Document the set of format control sequences
12344 supported by the function. Use SAFE_ALLOCA instead of always
12345 using `alloca'.
12346
12347 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12348 is one byte too soon. Don't use xrealloc; instead xfree and
12349 xmalloc anew.
12350
e061a11b
TZ
123512011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12352
12353 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12354 callbacks stage.
12355
12356 * gnutls.c: Renamed global_initialized to
12357 gnutls_global_initialized. Added internals for the
12358 :verify-hostname-error, :verify-error, and :verify-flags
12359 parameters of `gnutls-boot' and documented those parameters in the
12360 docstring. Start callback support.
9173deec
JB
12361 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12362 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12363 on error. Return error code.
e061a11b
TZ
12364 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12365 (emacs_gnutls_read): Likewise.
12366 (Fgnutls_boot): Return handshake error code.
12367 (emacs_gnutls_handle_error): New function.
12368 (wsaerror_to_errno): Likewise.
12369
12370 * w32.h (emacs_gnutls_pull): Add prototype.
12371 (emacs_gnutls_push): Likewise.
12372
12373 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12374 (emacs_gnutls_push): Likewise.
12375
123762011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12377
12378 * process.c (wait_reading_process_output): Check if GnuTLS
12379 buffered some data internally if no FDs are set for TLS
12380 connections.
12381
12382 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12383 (LIBS): Link to USER_LIBS.
12384 ($(BLD)/gnutls.$(0)): New target.
12385
fa6996bc
EZ
123862011-04-24 Eli Zaretskii <eliz@gnu.org>
12387
eb35682e
EZ
12388 * xdisp.c (handle_single_display_spec): Rename the
12389 display_replaced_before_p argument into display_replaced_p, to
12390 make it consistent with the commentary. Fix typos in the
12391 commentary.
12392
e2ad650c
EZ
12393 * textprop.c (syms_of_textprop): Remove dead code.
12394 (copy_text_properties): Delete obsolete commentary about an
12395 interface that was deleted long ago. Fix typos in the description
12396 of arguments.
12397
1b2de274
EZ
12398 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12399 to changes in oldXMenu/XMenu.h from 2011-04-16.
12400 <menu_help_message, prev_menu_help_message>: Constify.
12401 (IT_menu_make_room): menu->help_text is now `const char **';
12402 adjust.
12403
12404 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12405 to changes in oldXMenu/XMenu.h from 2011-04-16.
12406 (struct XMenu): Declare `help_text' `const char **'.
12407
12408 * xfaces.c <Qunspecified>: Make extern again.
12409
12410 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12411 required by POSIX.
1b2de274 12412
762b15be
EZ
12413 * doc.c (get_doc_string): Improve the format passed to `error'.
12414
12415 * doprnt.c (doprnt): Improve commentary.
12416
12417 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12418
12419 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12420 them with etags.
12421
f1052e5d
EZ
12422 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12423 changes in globals.h immediately force recompilation.
762b15be
EZ
12424 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12425 $(CURDIR)/s/ms-w32.h.
12426 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12427
fa6996bc
EZ
12428 * character.c (Fchar_direction): Function deleted.
12429 (syms_of_character): Don't defsubr it.
12430 <char-direction-table>: Deleted.
12431
e6c3da20
EZ
124322011-04-23 Eli Zaretskii <eliz@gnu.org>
12433
12434 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12435 * doprnt.c: Include limits.h.
12436 (SIZE_MAX): New macro.
04f2d78b
CB
12437 (doprnt): Return a size_t value. 2nd arg is now size_t.
12438 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12439 Improve overflow protection. Support `l' modifier for integer
12440 conversions. Support %l conversion. Don't assume an EMACS_INT
12441 argument for integer conversions and for %c.
12442
12443 * lisp.h (doprnt): Restore prototype.
12444
12445 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12446 $(SRC)/character.h.
12447
12448 * Makefile.in (base_obj): Add back doprnt.o.
12449
12450 * deps.mk (doprnt.o): Add back prerequisites.
12451 (callint.o): Depend on character.h.
12452
12453 * eval.c (internal_lisp_condition_case): Include the handler
12454 representation in the error message.
12455 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12456 when breaking from the loop.
12457
12458 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12459
12460 * callint.c (Fcall_interactively): When displaying error message
12461 about invalid control letter, pass the character's codepoint, not
12462 a pointer to its multibyte form. Improve display of the character
12463 in octal and display also its hex code.
12464
12465 * character.c (char_string): Use %x to display the (unsigned)
12466 codepoint of an invalid character, to avoid displaying a bogus
12467 negative value.
12468
12469 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12470 `error', not SYMBOL_NAME itself.
12471
12472 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12473 character arguments to `error'.
12474
12475 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12476 to `error' in error message about FINAL_CHAR argument. Make sure
12477 FINAL_CHAR is a character, and use %c when it is passed as
12478 argument to `error'.
12479
4ffd0d6b 124802011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12481
12482 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12483
12484 * w32.c: Include <time.h>.
12485 (sys_localtime): New function.
12486
4ffd0d6b 124872011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12488
12489 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12490
4ffd0d6b 12491 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12492
4ffd0d6b 124932011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12494
4ffd0d6b
GM
12495 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12496 zombies (Bug#8467).
aac0c6e3 12497
04c56954
EZ
124982011-04-19 Eli Zaretskii <eliz@gnu.org>
12499
12500 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12501 gl_state.e_property when gl_state.object is Qt.
12502
12503 * insdel.c (make_gap_larger): Remove limitation of buffer size
12504 to <= INT_MAX.
12505
16a43933
CY
125062011-04-18 Chong Yidong <cyd@stupidchicken.com>
12507
12508 * xdisp.c (lookup_glyphless_char_display)
12509 (produce_glyphless_glyph): Handle cons cell entry in
12510 glyphless-char-display.
12511 (Vglyphless_char_display): Document it.
12512
12513 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12514 glyphless-char-display.
12515
4581706e
CY
125162011-04-17 Chong Yidong <cyd@stupidchicken.com>
12517
12518 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12519
12520 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12521
12522 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12523 definition for no-X builds.
12524
4887c6e2 125252011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12526
fd35b6f9
PE
12527 Static checks with GCC 4.6.0 and non-default toolkits.
12528
5c1ccb01
PE
12529 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12530
006c5daa
PE
12531 * process.c (keyboard_bit_set): Define only if SIGIO.
12532 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12533 (send_process): Repair possible setjmp clobbering.
12534
efc736d3
PE
12535 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12536
4e2fe2e6
PE
12537 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12538
f97334a2
PE
12539 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12540
4e75f29d
PE
12541 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12542 Define only if needed.
12543
90efadd1
PE
12544 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12545 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12546 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12547
3c647824
PE
12548 * dispextern.h (struct redisplay_interface): Rename param
12549 to avoid shadowing.
e264f262 12550 * termhooks.h (struct terminal): Likewise.
761383f4 12551 * xterm.c (xembed_send_message): Likewise.
3c647824 12552
b58c5c4a
PE
12553 * insdel.c (make_gap_smaller): Define only if
12554 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12555
cad59032
PE
12556 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12557 it.
12558
c339dc2e
PE
12559 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12560 so that we aren't warned about unused symbols.
12561
91a3e27b
PE
12562 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12563
399c71d3 12564 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12565
8ffc96f5
PE
12566 * xfns.c (x_real_positions): Mark locals as initialized.
12567
eef9bc79
PE
12568 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12569
098db9dd
PE
12570 * xterm.c: Fix problems found by static analysis with other toolkits.
12571 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12572 (x_dispatch_event): Declare static if USE_GTK, and
12573 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12574 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12575 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12576 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12577 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12578
eb18f6cc
PE
12579 * xmenu.c (menu_help_callback): Pointer type fixes.
12580 Use const pointers when pointing at readonly data. Avoid pointer
12581 signedness clashes.
12582 (FALSE): Remove unused macro.
12583 (update_frame_menubar): Remove unused decl.
12584
1fe72bf8
PE
12585 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12586
60d9e1db
PE
12587 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12588 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12589 (single_menu_item): Rename local to avoid shadowing.
12590
39261c26
PE
12591 * keyboard.c (make_lispy_event): Remove unused local var.
12592
018c5e19
PE
12593 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12594 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12595
63d2b86e
PE
12596 * bitmaps: Change bitmaps from unsigned char back to the X11
12597 compatible char. Avoid the old compiler warnings about
12598 out-of-range initializers by using, for example, '\xab' rather
12599 than 0xab.
12600
aefd87e1
PE
12601 * xgselect.c (xgselect_initialize): Check vs interface
12602 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12603
bf501fb9
PE
12604 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12605
e9829fdf
PE
12606 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12607 to read-only memory.
12608
1086c095
PE
12609 * fns.c (vector): Remove; this old hack is no longer needed.
12610
2baccd04 12611 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12612 Remove unused var.
dde42981 12613 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12614
72391843 12615 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12616
436c16df 12617 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12618 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12619 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12620
92bb796d 12621 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12622 (x_term_init): Remove local to avoid shadowing.
92bb796d 12623
764430a3 12624 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12625
12626 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12627 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12628
d1dfb56c
EZ
126292011-04-16 Eli Zaretskii <eliz@gnu.org>
12630
c4354cb4
EZ
12631 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12632
d1dfb56c
EZ
12633 Fix regex.c, syntax.c and friends for buffers > 2GB.
12634 * syntax.h (struct gl_state_s): Declare character position members
12635 EMACS_INT.
12636
12637 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12638
04f2d78b
CB
12639 * textprop.c (verify_interval_modification, interval_of):
12640 Declare arguments EMACS_INT.
d1dfb56c
EZ
12641
12642 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12643 EMACS_INT.
12644
12645 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12646
12647 * indent.c (Fvertical_motion): Local variable it_start is now
12648 EMACS_INT.
12649
12650 * regex.c (re_match, re_match_2, re_match_2_internal)
12651 (bcmp_translate, regcomp, regexec, print_double_string)
12652 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12653 (re_compile_pattern, re_exec): Declare arguments and local
12654 variables `size_t' and `ssize_t' and return values `regoff_t', as
12655 appropriate.
12656 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12657 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12658 <compile_stack_type>: `size' and `avail' are now `size_t'.
12659
12660 * regex.h <regoff_t>: Use ssize_t, not int.
12661 (re_search, re_search_2, re_match, re_match_2): Arguments that
12662 specify buffer/string position and length are now ssize_t and
12663 size_t. Return type is regoff_t.
12664
613052cd
BK
126652011-04-16 Ben Key <bkey76@gmail.com>
12666
12667 * nsfont.m: Fixed bugs in ns_get_family and
12668 ns_descriptor_to_entity that were caused by using free to
12669 deallocate memory blocks that were allocated by xmalloc (via
12670 xstrdup). This caused Emacs to crash when compiled with
12671 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12672 --enable-checking=xmallocoverrun). xfree is now used to
12673 deallocate these memory blocks.
12674
4170f62f 126752011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12676
71b41406
PE
12677 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12678
9587a89d
PE
12679 emacs_write: Accept and return EMACS_INT for sizes.
12680 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12681 et seq.
12682 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12683 Accept and return EMACS_INT.
12684 (emacs_gnutls_write): Return the number of bytes written on
12685 partial writes.
12686 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12687 (emacs_read, emacs_write): Remove check for negative size, as the
12688 Emacs source code has been audited now.
9587a89d
PE
12689 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12690 (emacs_read, emacs_write): Use it.
273a5f82
PE
12691 * process.c (send_process): Adjust to the new signatures of
12692 emacs_write and emacs_gnutls_write. Do not attempt to store
12693 a byte offset into an 'int'; it might overflow.
9587a89d 12694 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12695
3e047f51
PE
12696 * sound.c: Don't assume sizes fit in 'int'.
12697 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12698 Return EMACS_INT, not int.
3e047f51 12699 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12700 Accept EMACS_INT, not int.
12701 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12702 record read return values.
12703
cc39a9db
BK
127042011-04-15 Ben Key <bkey76@gmail.com>
12705
c9d0ec6d
JB
12706 * keyboard.c (Qundefined): Don't declare static since it is used
12707 in nsfns.m.
12708 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12709 static since they are used in nsfont.m.
cc39a9db 12710
6c60eb9f
SM
127112011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12712
12713 * process.c (Qprocessp): Don't declare static.
12714 * lisp.h (Qprocessp): Declare again.
12715
7990b61a
JB
127162011-04-15 Juanma Barranquero <lekktu@gmail.com>
12717
12718 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12719
5d4cb038
PE
127202011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12721
8bd7b830 12722 Improve C-level modularity by making more things 'static'.
cd64ea1d 12723
e3b27b31
PE
12724 Don't publish debugger-only interfaces to other modules.
12725 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12726 (verify_bytepos, count_markers): Move decls to the only modules
12727 that need them.
12728 * region-cache.h (pp_cache): Likewise.
12729 * window.h (check_all_windows): Likewise.
12730 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12731
5d4cb038
PE
12732 * sysdep.c (croak): Now static, if
12733 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12734 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12735
12736 * alloc.c (refill_memory_reserve): Now static if
12737 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12738 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12739
e87b6180
PE
12740 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12741 Define only if USE_LUCID.
12742
ac64929e
PE
12743 * xrdb.c (x_customization_string, x_rm_string): Now static.
12744
6f37259d
PE
12745 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12746 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12747
1683e3ab
PE
12748 * xdisp.c (draw_row_with_mouse_face): Now static.
12749 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12750
de9c2632
PE
12751 * window.h (check_all_windows): Mark externally visible.
12752
2b96acb7
PE
12753 * window.c (window_deletion_count): Now static.
12754
12755 * undo.c: Make symbols static if they're not exported.
12756 (last_undo_buffer, last_boundary_position, pending_boundary):
12757 Now static.
12758
50436f33
PE
12759 * textprop.c (interval_insert_behind_hooks): Now static.
12760 (interval_insert_in_front_hooks): Likewise.
12761
64520e5c
PE
12762 * term.c: Make symbols static if they're not exported.
12763 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12764 (max_frame_lines, tty_set_terminal_modes):
12765 (tty_reset_terminal_modes, tty_turn_off_highlight):
12766 (get_tty_terminal): Now static.
12767 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12768 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12769 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12770 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12771 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12772
1fa53021
PE
12773 * sysdep.c: Make symbols static if they're not exported.
12774 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12775 Now static.
12776 (sigprocmask_set, full_mask): Remove; unused.
12777 (wait_debugging): Mark as visible.
12778 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12779 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12780
d4b43b22
PE
12781 * syntax.c (syntax_temp): Define only if !__GNUC__.
12782
b7c513d0
PE
12783 * sound.c (current_sound_device, current_sound): Now static.
12784
989b29ad
PE
12785 * search.c (searchbufs, searchbuf_head): Now static.
12786
13a55a78
PE
12787 * scroll.c (scroll_cost): Remove; unused.
12788 * dispextern.h (scroll_cost): Remove decl.
12789
de68a1fc
PE
12790 * region-cache.h (pp_cache): Mark as externally visible.
12791
40ccffa6
PE
12792 * process.c: Make symbols static if they're not exported.
12793 (process_tick, update_tick, create_process, chan_process):
12794 (Vprocess_alist, proc_buffered_char, datagram_access):
12795 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12796 (deactivate_process): Mark defn as static, as well as decl.
12797 * lisp.h (create_process): Remove decl.
12798 * process.h (chan_process, Vprocess_alist): Remove decls.
12799
ad64fc97
PE
12800 * print.c: Make symbols static if they're not exported.
12801 (print_depth, new_backquote_output, being_printed, print_buffer):
12802 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12803 (print_interval, print_number_index, initial_stderr_stream):
12804 Now static.
12805 * lisp.h (Fprinc): Remove decl.
12806 (debug_output_compilation_hack): Mark as externally visible.
12807
adddb265
PE
12808 * sysdep.c (croak): Move decl from here to syssignal.h.
12809 * syssignal.h (croak): Put it here, so the API can be checked when
12810 'croak' is called from dissociate_if_controlling_tty.
12811
1717ede2
PE
12812 * minibuf.c: Make symbols static if they're not exported.
12813 (minibuf_save_list, choose_minibuf_frame): Now static.
12814 * lisp.h (choose_minibuf_frame): Remove decl.
12815
fa5fb2bc
PE
12816 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12817
1e3890d1
PE
12818 * lread.c: Make symbols static if they're not exported.
12819 (read_objects, initial_obarray, oblookup_last_bucket_number):
12820 Now static.
12821 (make_symbol): Remove; unused.
12822 * lisp.h (initial_obarray, make_symbol): Remove decls.
12823
8a1414fa
PE
12824 * keyboard.c: Make symbols static if they're not exported.
12825 (single_kboard, recent_keys_index, total_keys, recent_keys):
12826 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12827 (this_single_command_key_start, echoing, last_auto_save):
12828 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12829 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12830 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12831 (Vlispy_mouse_stem, double_click_count):
12832 Now static.
12833 (force_auto_save_soon): Define only if SIGDANGER.
12834 (ignore_mouse_drag_p): Now static if
12835 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12836 (print_help): Remove; unused.
12837 (stop_character, last_timer_event): Mark as externally visible.
12838 * keyboard.h (ignore_mouse_drag_p): Declare only if
12839 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12840 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12841 * lisp.h (echoing): Remove decl.
12842 (force_auto_save_soon): Declare only if SIGDANGER.
12843 * xdisp.c (redisplay_window): Simplify code, to make it more
12844 obvious that ignore_mouse_drag_p is not accessed if !defined
12845 USE_GTK && !defined HAVE_NS.
12846
93ea6e8f
PE
12847 * intervals.c: Make symbols static if they're not exported.
12848 (merge_properties_sticky, merge_interval_right, delete_interval):
12849 Now static.
12850 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12851
77382fcc
PE
12852 * insdel.c: Make symbols static if they're not exported.
12853 However, leave prepare_to_modify_buffer alone. It's never
12854 called from outside this function, but that appears to be a bug.
12855 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12856 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12857 (adjust_after_replace_noundo): Remove; unused.
12858 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12859 (signal_before_change): Remove decls.
77382fcc 12860
9306c32e
PE
12861 * indent.c (val_compute_motion, val_vmotion): Now static.
12862
cd44d2eb
PE
12863 * image.c: Make symbols static if they're not exported.
12864 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12865 if USE_GTK.
12866 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12867 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12868
ad9a7a06
PE
12869 * fringe.c (standard_bitmaps): Now static.
12870 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12871
81626931
PE
12872 * frame.c: Make symbols static if they're not exported.
12873 (x_report_frame_params, make_terminal_frame): Now static.
12874 (get_frame_param): Now static, unless HAVE_NS.
12875 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12876 (x_get_resource_string): Remove; not used.
12877 * frame.h (make_terminal_frame, x_report_frame_params):
12878 (x_get_resource_string); Remove decls.
12879 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12880 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12881
239f9db9
PE
12882 * font.c, fontset.c: Make symbols static if they're not exported.
12883 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12884 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12885 * font.c (font_close_object): Now static.
12886 * font.h (font_close_object): Remove.
12887 * fontset.c (FONTSET_OBJLIST): Remove.
12888 (free_realized_fontset) #if-0 the body, which does nothing.
12889 (face_suitable_for_char_p): #if-0, as it's never called.
12890 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12891 * xfaces.c (face_at_string_position):
12892 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12893 since 0 is always ASCII.
12894
dfcf3579
PE
12895 * fns.c (weak_hash_tables): Now static.
12896
5045092b
PE
12897 * fileio.c: Make symbols static if they're not exported.
12898 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12899 (Vwrite_region_annotation_buffers): Now static.
12900
57a96f5c
PE
12901 * eval.c: Make symbols static if they're not exported.
12902 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12903 * lisp.h (backtrace_list): Remove decl.
12904
35f08c38
PE
12905 * emacs.c: Make symbols static if they're not exported.
12906 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12907 (fatal_error_code, fatal_error_signal_hook, standard_args):
12908 Now static.
12909 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12910 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12911 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12912 * lisp.h (fatal_error_signal_hook): Remove decl.
12913 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12914
f44bd759
PE
12915 * editfns.c: Move a (normally-unused) function to its only use.
12916 * editfns.c, lisp.h (get_operating_system_release): Remove.
12917 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12918 worth the hassle of breaking this out.
12919
b532497d
PE
12920 * xterm.c: Make symbols static if they're not exported.
12921 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12922 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12923 (x_destroy_window, x_delete_display):
12924 Now static.
12925 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12926 (x_mouse_leave): Remove; unused.
12927 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12928 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12929 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12930 Remove decls.
12931 (x_mouse_leave): Declare only if WINDOWSNT.
12932 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12933 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12934 USE_X_TOOLKIT.
12935
1675728f
PE
12936 * ftxfont.c: Make symbols static if they're not exported.
12937 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12938 HAVE_FREETYPE.
12939 * font.h (ftxfont_driver): Likewise.
12940
e4cebfca
PE
12941 * xfns.c: Make symbols static if they're not exported.
12942 (x_last_font_name, x_display_info_for_name):
12943 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12944 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12945 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12946 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12947 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12948 (last_show_tip_args): Now static.
12949 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12950 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12951 (x_screen_planes): Remove; unused.
12952 * dispextern.h (x_screen_planes): Remove decl.
12953
5bf46f05
PE
12954 * dispnew.c: Make symbols static if they're not exported.
12955 * dispextern.h (redraw_garbaged_frames, scrolling):
12956 (increment_row_positions): Remove.
12957 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12958 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12959 Now static.
12960 (redraw_garbaged_frames): Remove; unused.
12961
435f4c28
PE
12962 * xfaces.c: Make symbols static if they're not exported.
12963 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12964 Remove decls.
12965 * xterm.h (defined_color): Remove decls.
12966 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12967 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12968 (menu_face_changed_default, defined_color, free_realized_face):
12969 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12970 (ascii_face_of_lisp_face): Remove; unused.
12971
8524aef3
PE
12972 * xdisp.c: Make symbols static if they're not exported.
12973 * dispextern.h (scratch_glyph_row, window_box_edges):
12974 (glyph_to_pixel_coords, set_cursor_from_row):
12975 (get_next_display_element, set_iterator_to_next):
12976 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12977 (show_mouse_face): Remove decls
12978 * frame.h (message_buf_print): Likewise.
12979 * lisp.h (pop_message, set_message, check_point_in_composition):
12980 Likewise.
12981 * xterm.h (set_vertical_scroll_bar): Likewise.
12982 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12983 (message_buf_print, scratch_glyph_row, displayed_buffer):
12984 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12985 (get_next_display_element, show_mouse_face, window_box_edges):
12986 (frame_to_window_pixel_xy, check_point_in_composition):
12987 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12988 (glyph_to_pixel_coords): Remove; unused.
12989
16390cd2
PE
12990 * dired.c (file_name_completion): Now static.
12991
12992 * dbusbind.c (xd_in_read_queued_messages): Now static.
12993
a25f4dfa
PE
12994 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12995 * data.c (circular_list_error): Remove.
12996
14a9c8df
PE
12997 * commands.h (last_point_position, last_point_position_buffer):
12998 (last_point_position_window): Remove decls.
12999 * keyboard.c: Make these variables static.
13000
04f2d78b
CB
13001 * coding.h (coding, code_convert_region, encode_coding_gap):
13002 Remove decls.
74ab6df5
PE
13003 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13004 (iso_code_class, detect_coding, code_convert_region): Now static.
13005 (encode_coding_gap): Remove; unused.
13006
38dfbee1
PE
13007 * chartab.c (chartab_chars, chartab_bits): Now static.
13008
a2cb4e63
PE
13009 * charset.h (charset_iso_8859_1): Remove decl.
13010 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13011 Now static.
13012
127198fd
PE
13013 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13014 * ccl.c (Vccl_program_table): Now static.
13015 (check_ccl_update): Remove; unused.
13016
d85b608f
PE
13017 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13018 * category.h: ... from here.
13019 * category.c (check_category_table, set_category_set): Now static.
13020
31cd66f3
PE
13021 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13022 * lisp.h: Remove these decls.
13023
c358e587
PE
13024 * buffer.c (buffer_count): Remove unused var.
13025
e78aecca
PE
13026 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13027 so that it's not optimized away.
13028 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13029 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13030 exported only to the debugger.
13031
e192d7d3 13032 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13033 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13034
92470028
PE
13035 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13036 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13037 was inaccessible from Lisp.
13038 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13039 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13040
244ed907
PE
13041 alloc.c: Import and export fewer symbols, and remove unused items.
13042 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13043 is defined.
13044 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13045 it's not optimized away by whole-program optimization.
13046 (message_enable_multibyte, free_misc): Remove.
13047 (catchlist, handlerlist, mark_backtrace):
13048 Declare only if BYTE_MARK_STACK.
13049 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13050 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13051 (message_enable_multibyte): Remove decl.
13052 (free_misc, interval_free_list, float_block, float_block_index):
13053 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13054 (cons_free_list, last_marked_index):
13055 Now static.
13056 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13057 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13058 (mark_backtrace): Define only if BYTE_MARK_STACK.
13059 * xdisp.c (message_enable_multibyte): Now static.
13060
61c2b50e 13061 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13062 This makes it easier for human readers (and static analyzers)
13063 to see whether these variables are used from other modules.
13064 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13065 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13066 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13067 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13068 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13069 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13070 * xmenu.c, xselect.c:
13071 Declare Q* vars static if they are not used in other modules.
13072 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13073 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13074 Remove decls of unexported vars.
13075 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13076
95c82688
PE
13077 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13078
16a97296
PE
13079 Make Emacs functions such as Fatom 'static' by default.
13080 This makes it easier for human readers (and static analyzers)
13081 to see whether these functions can be called from other modules.
13082 DEFUN now defines a static function. To make the function external
13083 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13084 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13085 (Finit_image_library):
16a97296
PE
13086 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13087 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13088 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13089 Remove decls, since these functions are now static.
13090 (Funintern, Fget_internal_run_time): New decls, since these functions
13091 were already external.
95c82688 13092
16a97296
PE
13093 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13094 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13095 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13096 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13097 * keyboard.c, keymap.c, lread.c:
13098 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13099 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13100 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13101 Mark functions with DEFUE instead of DEFUN,
13102 if they are used in other modules.
13103 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13104 decls for now-static functions.
13105 * buffer.h (Fdelete_overlay): Remove decl.
13106 * callproc.c (Fgetenv_internal): Mark as internal.
13107 * composite.c (Fremove_list_of_text_properties): Remove decl.
13108 (Fcomposition_get_gstring): New forward static decl.
13109 * composite.h (Fcomposite_get_gstring): Remove decl.
13110 * dired.c (Ffile_attributes): New forward static decl.
13111 * doc.c (Fdocumntation_property): New forward static decl.
13112 * eval.c (Ffetch_bytecode): New forward static decl.
13113 (Funintern): Remove extern decl; now in .h file where it belongs.
13114 * fileio.c (Fmake_symbolic_link): New forward static decl.
13115 * image.c (Finit_image_library): New forward static decl.
13116 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13117 * intervals.h (Fprevious_property_change):
13118 (Fremove_list_of_text_properties): Remove decls.
13119 * keyboard.c (Fthis_command_keys): Remove decl.
13120 (Fcommand_execute): New forward static decl.
13121 * keymap.c (Flookup_key): New forward static decl.
13122 (Fcopy_keymap): Now static.
13123 * keymap.h (Flookup_key): Remove decl.
13124 * process.c (Fget_process): New forward static decl.
13125 (Fprocess_datagram_address): Mark as internal.
13126 * syntax.c (Fsyntax_table_p): New forward static decl.
13127 (skip_chars): Remove duplicate decl.
13128 * textprop.c (Fprevious_property_change): New forward static decl.
13129 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13130 Now internal.
13131 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13132 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13133
785bbd42
PE
13134 * editfns.c (Fformat): Remove unreachable code.
13135
8b913b57
AS
131362011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13137
13138 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13139 change. (Bug#8496)
13140
a6744a35
EZ
131412011-04-13 Eli Zaretskii <eliz@gnu.org>
13142
13143 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13144 when at ZV. (Bug#8487)
13145
e7974947
AS
131462011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13147
baad03f0
AS
13148 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13149 (Bug#8437)
13150 * keyboard.c (parse_tool_bar_item): Likewise.
13151 * sound.c (sound_cleanup, alsa_close): Likewise.
13152 * termcap.c (tgetent): Likewise.
13153 * xfns.c (x_default_font_parameter): Likewise.
13154 * xsettings.c (read_and_apply_settings): Likewise.
13155
e7974947
AS
13156 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13157 (overrun_check_free): Protoize.
13158
28272684
PE
131592011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13160
13161 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13162 since callers should never pass a negative size.
13163 Change the signature to match that of plain 'read' and 'write'; see
13164 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13165 * lisp.h: Update prototypes of emacs_write and emacs_read.
13166
11997c76
EZ
131672011-04-11 Eli Zaretskii <eliz@gnu.org>
13168
13169 * xdisp.c (redisplay_window): Don't try to determine the character
13170 position of the scroll margin if the window start point w->startp
e896f03c 13171 is outside the buffer's accessible region. (Bug#8468)
11997c76 13172
8a2cbd72
EZ
131732011-04-10 Eli Zaretskii <eliz@gnu.org>
13174
13175 Fix write-region and its subroutines for buffers > 2GB.
13176 * fileio.c (a_write, e_write): Modify declaration of arguments and
13177 local variables to support buffers larger than 2GB.
13178 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13179
13180 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13181 argument, local variables, and return value.
13182
13183 * lisp.h: Update prototypes of emacs_write and emacs_read.
13184
13185 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13186
4073e537 131872011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13188
1ebfdcb6
PE
13189 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13190
b2ded58d
PE
13191 Fix more problems found by GCC 4.6.0's static checks.
13192
7d66342c
PE
13193 * xdisp.c (vmessage): Use a better test for character truncation.
13194
bbf47d44
PE
13195 * charset.c (load_charset_map): <, not <=, for optimization,
13196 and to avoid potential problems with integer overflow.
9248994d 13197 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13198 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13199 * editfns.c (Fformat): Likewise.
1e69125e 13200 * syntax.c (skip_chars): Likewise.
3befa583 13201
e3019616
PE
13202 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13203 This also lets GCC 4.6.0 generate slightly better loop code.
13204
becfa255
PE
13205 * callint.c (Fcall_interactively): <, not <=, for optimization.
13206 (Fcall_interactively): Count the number of arguments produced,
13207 not the number of arguments given. This is simpler and lets GCC
13208 4.6.0 generate slightly better code.
13209
dae0cd48
PE
13210 * ftfont.c: Distingish more carefully between FcChar8 and char.
13211 The previous code passed unsigned char * to a functions like
13212 strlen and xstrcasecmp that expect char *, which does not
13213 conform to the C standard.
13214 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13215 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13216 char * when the C standard requires it.
13217
76032d70
PE
13218 * keyboard.c (read_char): Remove unused var.
13219
eb3f1cc8
PE
13220 * eval.c: Port to Windows vsnprintf (Bug#8435).
13221 Include <limits.h>.
13222 (SIZE_MAX): Define if the headers do not.
13223 (verror): Do not give up if vsnprintf returns a negative count.
13224 Instead, grow the buffer. This ports to Windows vsnprintf, which
13225 does not conform to C99. Problem reported by Eli Zaretskii.
13226 Also, simplify the allocation scheme, by avoiding the need for
13227 calling realloc, and removing the ALLOCATED variable.
13228
70476b54
PE
13229 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13230
12020a9e
PE
13231 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13232 But keep the doprint source code for now, as we might revamp it
13233 and use it again (Bug#8435).
ea6c7ae6
PE
13234 * lisp.h (doprnt): Remove.
13235 * Makefile.in (base_obj): Remove doprnt.o.
13236 * deps.mk (doprnt.o): Remove.
13237
5fdb398c
PE
13238 error: Print 32- and 64-bit integers portably (Bug#8435).
13239 Without this change, on typical 64-bit hosts error ("...%d...", N)
13240 was used to print both 32- and 64-bit integers N, which relied on
13241 undefined behavior.
61bdb816 13242 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13243 * lisp.h (error, verror): Mark as printf-like functions.
13244 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13245 Report overflow in size calculations when allocating printf buffer.
13246 Do not truncate output string at its first null byte.
13247 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13248 Truncate the output at a character boundary, since vsnprintf does not
13249 do that.
13250 * charset.c (check_iso_charset_parameter): Convert internal
13251 character to string before calling 'error', since %c now has the
13252 printf meaning.
13253 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13254 overflow when computing char to be passed to 'error'. Do not
13255 pass Lisp_Object to 'error'; pass the integer instead.
13256 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13257 formatted with plain %d.
13258
b189fa66
PE
13259 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13260
bff87ef0
PE
13261 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13262
7e2cac20
PE
13263 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13264
ce4d90b5
PE
13265 * xterm.c (x_catch_errors): Remove duplicate declaration.
13266
266c9547
PE
13267 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13268
79c49ad2
PE
13269 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13270
368f4090
JM
132712011-04-10 Jim Meyering <meyering@redhat.com>
13272
13273 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13274 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13275 return ssize_t not "int", and use size_t as the buffer length.
13276 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13277 * gnutls.h: Update declarations.
13278 * process.c (read_process_output): Use ssize_t, to match.
13279 (send_process): Likewise.
13280
a32d4040
CY
132812011-04-09 Chong Yidong <cyd@stupidchicken.com>
13282
13283 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13284
8546720e 132852011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13286
04f2d78b
CB
13287 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13288 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13289
8546720e
GM
13290 * xterm.c (handle_one_xevent):
13291 * xmenu.c (create_and_show_popup_menu):
13292 * xselect.c (x_decline_selection_request)
13293 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13294
0a2f5c1a 132952011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13296
13297 Fix some uses of `int' instead of EMACS_INT.
13298 * search.c (string_match_1, fast_string_match)
13299 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13300 (scan_buffer, find_next_newline_no_quit)
13301 (find_before_next_newline, search_command, Freplace_match)
13302 (Fmatch_data): Make some `int' variables be EMACS_INT.
13303
13304 * xdisp.c (display_count_lines): 3rd argument and return value now
13305 EMACS_INT. All callers changed.
13306 (pint2hrstr): Last argument is now EMACS_INT.
13307
13308 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13309 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13310 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13311 (decode_coding_utf_16, decode_coding_emacs_mule)
13312 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13313 (decode_coding_ccl, decode_coding_charset)
13314 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13315 (decode_coding_iso_2022, decode_coding_emacs_mule)
13316 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13317 <char_offset, last_offset>: Declare EMACS_INT.
13318 (encode_coding_utf_8, encode_coding_utf_16)
13319 (encode_coding_emacs_mule, encode_invocation_designation)
13320 (encode_designation_at_bol, encode_coding_iso_2022)
13321 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13322 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13323 Declare EMACS_INT.
13324 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13325 (encode_invocation_designation): Last argument P_NCHARS is now
13326 EMACS_INT.
13327 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13328 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13329
13330 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13331 All users changed.
13332
13333 * ccl.c (Fccl_execute_on_string): Declare some variables
13334 EMACS_INT.
13335
8546720e 133362011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13337
13338 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13339
4e19a977
CS
133402011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13341
13342 * process.c (Fformat_network_address): Doc fix.
13343
87302331
R
133442011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13345
ee7683eb 13346 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13347
cbb59342
CY
133482011-04-08 Chong Yidong <cyd@stupidchicken.com>
13349
13350 * keyboard.c (read_char): Call Lisp function help-form-show,
13351 instead of using internal_with_output_to_temp_buffer.
13352 (Qhelp_form_show): New var.
e0d38eeb 13353 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13354
13355 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13356
13357 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13358
e67a13ab
CY
133592011-04-06 Chong Yidong <cyd@stupidchicken.com>
13360
04f2d78b
CB
13361 * process.c (Flist_processes): Remove to Lisp.
13362 (list_processes_1): Delete.
e67a13ab 13363
973f782d
EZ
133642011-04-06 Eli Zaretskii <eliz@gnu.org>
13365
7c106b1e
EZ
13366 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13367
973f782d
EZ
13368 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13369
41cf7d1a 133702011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13371
ca23cc88
PE
13372 Fix more problems found by GCC 4.6.0's static checks.
13373
f390e2d5
PE
13374 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13375
42eea0d0
PE
13376 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13377
b69769da 13378 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13379
f9541e84
PE
13380 * xdisp.c (vmessage): Mark as a printf-like function.
13381
13841b55
PE
13382 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13383
c136c10f
PE
13384 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13385
5e2d4a30
PE
13386 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13387 printf-like functions.
13388 (tiff_load): Add casts to remove these marks before passing them
13389 to system-supplied API.
13390
583f48b9
PE
13391 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13392
b25d760e
PE
13393 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13394 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13395 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13396 directly, rather than having caller test rule sign. This avoids
13397 some unnecessary tests.
13398 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13399 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13400 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13401
bc7b6697 13402 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13403 (xfont_open): Avoid unnecessary tests.
bc7b6697 13404
27ccc379
PE
13405 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13406
dcd5c89a
PE
13407 * composite.h, composite.c (composition_gstring_put_cache):
13408 Use EMACS_INT, not int, for length.
13409
b13a45c6
PE
13410 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13411 breaking out part of COMPOSITION_DECODE_RULE.
13412 (COMPOSITION_DECODE_RULE): Use it.
13413 * composite.c (get_composition_id): Remove unused local vars,
13414 by using the new macro.
13415
1e792e4d
PE
13416 * textprop.c (set_text_properties_1): Change while to do-while,
13417 since the condition is always true at first.
13418
dc6c6455 13419 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13420 (interval_deletion_adjustment): Return unsigned value.
13421 All uses changed.
dc6c6455 13422
aba7731a
PE
13423 * process.c (list_processes_1, create_pty, read_process_output):
13424 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13425 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13426 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13427 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13428 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13429
fdfc4bf3
PE
13430 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13431
fca8fe46 13432 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13433 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13434
06a0259a 13435 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13436 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13437 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13438
e7b9e80f
PE
13439 * print.c (print_error_message): Avoid int overflow.
13440
56201685
PE
13441 * font.c (font_list_entities): Redo for clarity,
13442 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13443
78834453 13444 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13445 (font_score): Avoid potential overflow in diff calculation.
78834453 13446
0bc0b309 13447 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13448 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13449
e610eaca
PE
13450 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13451
b895abce
PE
13452 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13453 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13454 can always succeed if overflow has undefined behavior.
13455
1f1d9321 13456 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13457 (wordify): Omit three unnecessary tests.
1f1d9321 13458
c59478bc
PE
13459 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13460 All callers changed. This avoids the need for an unused var.
13461
79b73827
PE
13462 * casefiddle.c (casify_region): Remove var that is set but not used.
13463
a4db5dfe
PE
13464 * dired.c (file_name_completion): Remove var that is set but not used.
13465
43aae36e
PE
13466 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13467
2a47c44d 13468 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13469 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13470
a37c69bf
PE
13471 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13472 Check for integer overflow on size calculations.
13473
328ab8e7
PE
13474 * buffer.c (Fprevious_overlay_change): Remove var that is set
13475 but not used.
13476
e5a2a5cb
PE
13477 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13478 Remove vars that are set but not used.
8d84a6eb 13479 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13480 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13481
a60e5f68
PE
13482 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13483
f661cb61 13484 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13485 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13486
f0397f5a
PE
13487 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13488 that are set but not used.
13489
8664db06 13490 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13491 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13492
6abdaa4a
PE
13493 * xselect.c (x_get_local_selection, x_handle_property_notify):
13494 Remove vars that are set but not used.
13495
0ce7538d 13496 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13497 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13498
9ae848fc
PE
13499 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13500 Remove var that is set but not used.
0b918413
PE
13501 (scroll_bar_windows_size): Now size_t, not int.
13502 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13503 Check for overflow.
9ae848fc 13504
a5a62657
PE
13505 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13506 (map_tty_color) [!defined MSDOS]: Likewise.
13507
5c5cdd39
PE
13508 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13509
66ebf983
PE
13510 * coding.c: Remove vars that are set but not used.
13511 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13512 All callers changed.
13513 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13514 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13515 (decode_coding_charset): Remove vars that are set but not used.
13516
1be4d761
PE
13517 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13518 that is set but not used.
13519
47553fa8
PE
13520 * print.c (print_object): Remove var that is set but not used.
13521
1f7196bf 13522 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13523 The gnulib version avoids calling malloc in the usual case,
13524 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13525 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13526 * filelock.c (current_lock_owner): Likewise.
13527 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13528 * sysdep.c: Include allocator.h, careadlinkat.h.
13529 (emacs_no_realloc_allocator): New static constant.
13530 (emacs_readlink): New function.
fdb61804
PE
13531 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13532 ../lib/careadlinkat.h.
d1fdcab7 13533
f84c17c7
SM
135342011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13535
13536 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13537 first non-nil return value).
13538
ef3862ad
JD
135392011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13540
13541 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13542 if not defined (Bug#8403).
13543
376a7006
JB
135442011-04-02 Juanma Barranquero <lekktu@gmail.com>
13545
13546 * xdisp.c (display_count_lines): Remove parameter `start',
13547 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13548 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13549 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13550 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13551 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13552 and thereabouts. All callers changed.
13553 (get_per_char_metric): Remove parameter `f', unused since
13554 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13555
6ca3801d
JM
135562011-04-02 Jim Meyering <meyering@redhat.com>
13557
13558 do not dereference NULL upon failed strdup
13559 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13560 (ns_get_family): Likewise.
13561
d8e2b5ba
JB
135622011-04-02 Juanma Barranquero <lekktu@gmail.com>
13563
13564 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13565
8c74fcbd
JD
135662011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13567
13568 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13569 later (Bug#8403).
13570
7200d79c
SM
135712011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13572
03408648 13573 Add lexical binding.
7200d79c 13574
03408648
SM
13575 * window.c (Ftemp_output_buffer_show): New fun.
13576 (Fsave_window_excursion):
13577 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13578
13579 * lread.c (lisp_file_lexically_bound_p): New function.
13580 (Fload): Bind Qlexical_binding.
13581 (readevalloop): Remove `evalfun' arg.
13582 Bind Qinternal_interpreter_environment.
13583 (Feval_buffer): Bind Qlexical_binding.
13584 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13585 Mark as dynamic.
13586 (syms_of_lread): Declare `lexical-binding'.
13587
13588 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13589
13590 * keyboard.c (eval_dyn): New fun.
13591 (menu_item_eval_property): Use it.
ca105506
SM
13592
13593 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13594
03408648
SM
13595 * fns.c (concat, mapcar1): Accept byte-code-functions.
13596
13597 * eval.c (Fsetq): Handle lexical vars.
13598 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13599 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13600 (FletX, Flet): Obey lexical binding.
13601 (Fcommandp): Handle closures.
13602 (Feval): New `lexical' arg.
13603 (eval_sub): New function extracted from Feval. Use it almost
13604 everywhere where Feval was used. Look up vars in lexical env.
13605 Handle closures.
13606 (Ffunctionp): Move from subr.el.
13607 (Ffuncall): Handle closures.
13608 (apply_lambda): Remove `eval_flags'.
13609 (funcall_lambda): Handle closures and new byte-code-functions.
13610 (Fspecial_variable_p): New function.
13611 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13612 but without exporting it to Lisp.
23aba0ea 13613
23aba0ea 13614 * doc.c (Fdocumentation, store_function_docstring):
03408648 13615 * data.c (Finteractive_form): Handle closures.
23aba0ea 13616
03408648
SM
13617 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13618 interactive spec.
ba83908c 13619
04f2d78b
CB
13620 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13621 New byte-codes.
03408648
SM
13622 (exec_byte_code): New function extracted from Fbyte_code to handle new
13623 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13624
03408648 13625 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13626
03408648 13627 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13628
e2abce01
JB
136292011-03-31 Juanma Barranquero <lekktu@gmail.com>
13630
13631 * xdisp.c (redisplay_internal): Fix prototype.
13632
63696a73 136332011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13634
63696a73 13635 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13636 (try_scrolling): Use it when setting scroll_limit.
13637 Limit scrolling to 100 screen lines.
63696a73
EZ
13638 (redisplay_window): Even when falling back on "recentering",
13639 position point in the window according to scroll-conservatively,
13640 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13641
13642 (try_scrolling): When point is above the window, allow searching
13643 as far as scroll_max, or one screenful, to compute vertical
13644 distance from PT to the scroll margin position. This prevents
13645 try_scrolling from unnecessarily failing when
13646 scroll-conservatively is set to a value slightly larger than the
13647 window height. Clean up the case of PT below the margin at bottom
13648 of window: scroll_max can no longer be INT_MAX. When aggressive
13649 scrolling is in use, don't let point enter the opposite scroll
13650 margin as result of the scroll.
13651 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13652 threshold of 100 lines for never-recentering scrolling.
13653
e4cc2dfc
JB
136542011-03-31 Juanma Barranquero <lekktu@gmail.com>
13655
13656 * dispextern.h (move_it_by_lines):
13657 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13658 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13659 (message_log_check_duplicate): Remove parameters `prev_bol' and
13660 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13661 (redisplay_internal): Remove parameter `preserve_echo_area',
13662 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13663
13664 * indent.c (Fvertical_motion):
13665 * window.c (window_scroll_pixel_based, Frecenter):
13666 Don't pass `need_y_p' to `move_it_by_lines'.
13667
1c470562
SM
136682011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13669
44f230aa
SM
13670 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13671 steal a few bits to be more compact.
13672 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13673 Remove unneeded casts.
13674
1c470562
SM
13675 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13676
888adce9
ZK
136772011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13678
13679 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13680 binding" message (bug#7967).
13681
f838ed7b
PE
136822011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13683
77861b95
PE
13684 Fix more problems found by GCC 4.6.0's static checks.
13685
de6dbc14
PE
13686 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13687 Remove unused local var.
13688
f838ed7b
PE
13689 * editfns.c (Fmessage_box): Remove unused local var.
13690
792c7b2b
PE
13691 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13692 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13693 Omit unused local vars.
c499e557 13694 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13695 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13696 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13697 Omit unused local var.
13698
ba0165e1
PE
13699 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13700 Don't assume string length fits in int.
32ad8845 13701 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13702 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13703
3c59b4c9
PE
13704 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13705 instead of alloca (Bug#8344).
13706
a3eed478 13707 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13708 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13709
eb4d412d
PE
13710 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13711
1658b401
PE
13712 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13713 concerns.
13714
13715 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13716
13717 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13718
9a2c6e05
PE
13719 * keyboard.c (syms_of_keyboard): Use the same style as later
13720 in this function when indexing through an array. This also
13721 works around GCC bug 48267.
13722
03d0a109
PE
13723 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13724
44f730c8
PE
13725 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13726
fe75f926
PE
13727 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13728 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13729
ffa8c828
PE
13730 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13731 This avoids undefined behavior on integer overflow, and is a bit
13732 more convenient anyway since it is compared to a size_t variable.
13733
c5101a77
PE
13734 Variadic C functions now count arguments with size_t, not int.
13735 This avoids an unnecessary limitation on 64-bit machines, which
13736 caused (substring ...) to crash on large vectors (Bug#8344).
13737 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13738 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13739 All variadic functions and their callers changed accordingly.
c5101a77
PE
13740 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13741 * data.c (arith_driver, float_arith_driver): Likewise.
13742 * editfns.c (general_insert_function): Likewise.
13743 * eval.c (struct backtrace.nargs, interactive_p)
13744 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13745 (funcall_lambda, mark_backtrace): Likewise.
13746 * fns.c (concat): Likewise.
13747 * frame.c (x_set_frame_parameters): Likewise.
13748 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13749 0 if not found, not -1. All callers changed.
13750
dd3f25f7
PE
13751 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13752 (stack_copy_size): Now size_t, not int.
13753 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13754
461c2ab9
JB
137552011-03-28 Juanma Barranquero <lekktu@gmail.com>
13756
13757 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13758 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13759 All callers changed.
13760
13761 * lisp.h (multibyte_char_to_unibyte):
13762 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13763 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13764 * character.h (CHAR_TO_BYTE8):
13765 * cmds.c (internal_self_insert):
13766 * editfns.c (general_insert_function):
13767 * keymap.c (push_key_description):
13768 * search.c (Freplace_match):
13769 * xdisp.c (message_dolog, set_message_1): All callers changed.
13770
f6d62986
SM
137712011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13772
13773 * keyboard.c (safe_run_hook_funcall): New function.
13774 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13775 don't set the hook to nil, but remove the offending function instead.
13776 (Qcommand_hook_internal): Remove, unused.
13777 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13778 Vcommand_hook_internal.
13779
13780 * eval.c (enum run_hooks_condition): Remove.
13781 (funcall_nil, funcall_not): New functions.
13782 (run_hook_with_args): Call each function through a `funcall' argument.
13783 Remove `cond' argument, now redundant.
13784 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13785 (Frun_hook_with_args_until_failure): Adjust accordingly.
13786 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13787
1db5b1ad
JB
137882011-03-28 Juanma Barranquero <lekktu@gmail.com>
13789
13790 * dispextern.h (string_buffer_position): Remove declaration.
13791
13792 * print.c (strout): Remove parameter `multibyte', unused since
13793 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13794
13795 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13796 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13797 All callers changed.
13798
13799 * w32.c (_wsa_errlist): Use braces for struct initializers.
13800
13801 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13802 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13803 All callers changed.
13804 (string_buffer_position): Likewise. Also, make static (it's never
13805 used outside xdisp.c).
13806 (cursor_row_p): Remove parameter `w', unused since
13807 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13808 (decode_mode_spec): Remove parameter `precision', introduced during
13809 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13810 All callers changed.
13811
5ffb62aa
JD
138122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13813
13814 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13815
461c2ab9 138162011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13817
13818 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13819 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13820 (ns_update_auto_hide_menu_bar): New functions.
13821 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13822 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13823 ns_constrain_all_frames.
13824 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13825 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13826
5c380ffb
JD
138272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13828
13829 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13830
9af30bdf
GM
138312011-03-27 Glenn Morris <rgm@gnu.org>
13832
13833 * syssignal.h: Replace RETSIGTYPE with void.
13834 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13835 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13836 Replace SIGTYPE with void everywhere.
13837 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13838 * s/template.h (SIGTYPE): Remove commented out definition.
13839
e2abce01
JB
138402011-03-26 Eli Zaretskii <eliz@gnu.org>
13841
13842 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13843 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13844
f868cd8a
JB
138452011-03-26 Juanma Barranquero <lekktu@gmail.com>
13846
59eb0929
JB
13847 * w32.c (read_unc_volume): Use parameter `henum', instead of
13848 global variable `wget_enum_handle'.
13849
13850 * keymap.c (describe_vector): Remove parameters `indices' and
13851 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13852 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13853
f868cd8a
JB
13854 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13855
13856 * keyboard.c (timer_check): Remove parameter `do_it_now',
13857 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13858 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13859 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13860
13861 * keyboard.c (read_char):
13862 * w32menu.c (w32_menu_display_help):
13863 * xmenu.c (show_help_event, menu_help_callback):
13864 Adjust calls to `show_help_echo'.
13865
13866 * gtkutil.c (xg_maybe_add_timer):
13867 * keyboard.c (readable_events):
13868 * process.c (wait_reading_process_output):
13869 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13870
13871 * insdel.c (adjust_markers_gap_motion):
13872 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13873 (gap_left, gap_right): Don't call it.
13874
2ecf6fdb
CY
138752011-03-25 Chong Yidong <cyd@stupidchicken.com>
13876
13877 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13878 incurred during fontification.
13879
6b1f9ba4
JB
138802011-03-25 Juanma Barranquero <lekktu@gmail.com>
13881
13882 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13883 (DEFVAR_PER_BUFFER): Don't pass it.
13884
13885 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13886 (scrolling_window): Don't pass it.
13887
0f4a96b5
JB
138882011-03-25 Juanma Barranquero <lekktu@gmail.com>
13889
13890 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13891
13892 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13893 and `suffix'.
13894 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13895 of variables specific to SELinux and computation of `encoded_absname'.
13896
13897 * image.c (XPutPixel): Remove unused variable `height'.
13898
13899 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13900
13901 * unexw32.c (get_section_info): Remove unused variable `section'.
13902
13903 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13904 (system_process_attributes): Remove unused variable `sess'.
13905 (sys_read): Remove unused variable `err'.
13906
13907 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13908 (w32_wnd_proc): Remove unused variable `isdead'.
13909 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13910 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13911 (x_create_tip_frame): Remove unused variable `tem'.
13912
13913 * w32inevt.c (w32_console_read_socket):
13914 Remove unused variable `no_events'.
13915
13916 * w32term.c (x_draw_composite_glyph_string_foreground):
13917 Remove unused variable `width'.
13918
1149507c
JB
139192011-03-24 Juanma Barranquero <lekktu@gmail.com>
13920
13921 * w32term.c (x_set_glyph_string_clipping):
13922 Don't pass uninitialized region to CombineRgn.
13923
9c88f339
JB
139242011-03-23 Juanma Barranquero <lekktu@gmail.com>
13925
13926 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13927 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13928 (Fx_close_connection): Remove unused variable `i'.
13929
13930 * w32font.c (w32font_draw): Return number of glyphs.
13931 (w32font_open_internal): Remove unused variable `i'.
13932 (w32font_driver): Add missing initializer.
13933
13934 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13935 (fill_in_menu): Remove unused variable `items_added'.
13936
13937 * w32term.c (last_mouse_press_frame): Remove static global variable.
13938 (w32_clip_to_row): Remove unused variable `f'.
13939 (x_delete_terminal): Remove unused variable `i'.
13940
13941 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13942 (NOTHING): Remove unused static global variable.
13943 (uniscribe_check_otf): Remove unused variable `table'.
13944 (uniscribe_font_driver): Add missing initializers.
13945
dee091a3
JD
139462011-03-23 Julien Danjou <julien@danjou.info>
13947
13948 * term.c (Fsuspend_tty, Fresume_tty):
13949 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13950 * window.c (temp_output_buffer_show):
13951 * insdel.c (signal_before_change):
13952 * frame.c (Fhandle_switch_frame):
13953 * fileio.c (Fdo_auto_save):
13954 * emacs.c (Fkill_emacs):
13955 * editfns.c (save_excursion_restore):
13956 * cmds.c (internal_self_insert):
13957 * callint.c (Fcall_interactively):
13958 * buffer.c (Fkill_all_local_variables):
13959 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13960 Use Frun_hooks.
0f4a96b5 13961 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13962 unconditionally since it does the check itself.
dee091a3 13963
2c520ab5 139642011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13965
c9c49752
PE
13966 Fix more problems found by GCC 4.5.2's static checks.
13967
8abc3f12
PE
13968 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13969 the first time through the loop, since we know p0 < p1 then.
13970 This also avoids a gcc -Wstrict-overflow warning.
13971
a2d26660
PE
13972 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13973 leading to a memory leak, possible in functions like
13974 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13975 of objects (Bug#8318).
a2d26660 13976
916c72e9
PE
13977 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13978 that could (at least in theory) be that large.
13979
19ab8a18
PE
13980 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13981 This is less likely to overflow, and avoids undefined behavior if
13982 overflow does occur. All callers changed. Use strtoul to scan
13983 for the unsigned long integer.
b7cbbd6f
PE
13984 (pint2hrstr): Simplify and tune code slightly.
13985 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13986
f0641eff
PE
13987 * scroll.c (do_scrolling): Work around GCC bug 48228.
13988 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13989
7f650bb9
PE
13990 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13991 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13992 (validate_x_resource_name): Simplify count usage.
13993 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13994
37dd57d1
PE
13995 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13996 fail (Bug#8306).
81e56e61 13997
699979fc 13998 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13999
401bf9b4
PE
14000 * process.c (Fmake_network_process): Use socklen_t, not int,
14001 where POSIX says socklen_t is required in portable programs.
14002 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14003 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14004 (Fmake_network_process, server_accept_connection):
14005 (wait_reading_process_output, read_process_output):
14006 Likewise.
14007
b93aacde
PE
14008 * process.c: Rename or move locals to avoid shadowing.
14009 (list_processes_1, Fmake_network_process):
14010 (read_process_output_error_handler, exec_sentinel_error_handler):
14011 Rename or move locals.
4dc343ee 14012 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14013 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14014 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14015 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14016 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14017
af8a867c 14018 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14019 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14020 Include tparam.h instead, since it declares them.
af8a867c
PE
14021 * cm.h (PC): Remove extern decl; tparam.h now does this.
14022 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14023 * terminfo.c: Include tparam.h, to check interfaces.
14024 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14025 (tparam): Adjust signature to match interface in tparam.h;
14026 this removes some undefined behavior. Check that outstring and len
14027 are zero, which they always are with Emacs.
14028 * tparam.h (PC, BC, UP): New extern decls.
14029
0248044d 14030 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14031 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14032
8ff096c1 14033 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14034 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14035 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14036 (ftfont_list): Remove unused local.
49eaafba
PE
14037 (get_adstyle_property, ftfont_pattern_entity):
14038 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14039 Rename locals to avoid shadowing.
8ff096c1 14040
e2be39f6
PE
14041 * xfont.c (xfont_list_family): Mark var as initialized.
14042
c9735e30
PE
14043 * xml.c (make_dom): Now static.
14044
8f5201ae
PE
14045 * composite.c (composition_compute_stop_pos): Rename local to
14046 avoid shadowing.
b246f932
PE
14047 (composition_reseat_it): Remove unused locals.
14048 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14049 (composition_update_it): Mark var as initialized.
11b61122
PE
14050 (find_automatic_composition): Mark vars as initialized,
14051 with a FIXME (Bug#8290).
8f5201ae 14052
760fbc2c
PE
14053 character.h: Rename locals to avoid shadowing.
14054 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14055 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14056 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14057 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14058 to avoid shadowing.
14059
ff08eb85
PE
14060 * textprop.c (property_change_between_p): Remove; unused.
14061
fc7bf025
PE
14062 * intervals.c (interval_start_pos): Now static.
14063
235d7abc
PE
14064 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14065
44f230aa
SM
14066 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14067 Rename locals to avoid shadowing.
3e7d6594 14068
50060332
PE
14069 * sound.c (wav_play, au_play, Fplay_sound_internal):
14070 Fix pointer signedness.
d01f234b 14071 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14072 (wav_play): Initialize a variable to 0, to prevent undefined
14073 behavior (Bug#8278).
50060332 14074
c4fc4e30
PE
14075 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14076
918436ed
PE
14077 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14078
c939f91b
PE
14079 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14080 clobbering (Bug#8298).
b9c7f648
PE
14081 * sysdep.c (sys_subshell): Likewise.
14082 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14083
6bd8c144
PE
14084 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14085 This should get cleaned up, so that child_setup has the
14086 same signature on all platforms.
14087
7710357c 14088 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14089 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14090
c59da222
CY
140912011-03-22 Chong Yidong <cyd@stupidchicken.com>
14092
14093 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14094 not to be necessary, and produces flickering.
14095
66b87493
GM
140962011-03-20 Glenn Morris <rgm@gnu.org>
14097
14098 * config.in: Remove file.
14099
45b6f6d5
JB
141002011-03-20 Juanma Barranquero <lekktu@gmail.com>
14101
14102 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14103 are now in src/globals.h.
14104 (syms_of_minibuf): Remove spurious & from previous change.
14105
cd394be1 141062011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14107
14108 * minibuf.c (completing-read-function): New variable.
14109 (completing-read-default): Rename from completing-read.
14110 (completing-read): Call completing-read-function.
14111
b14e3e21
CY
141122011-03-19 Juanma Barranquero <lekktu@gmail.com>
14113
14114 * xfaces.c (Fx_load_color_file):
14115 Read color file from absolute filename (bug#8250).
14116
f2b726e6
JB
141172011-03-19 Juanma Barranquero <lekktu@gmail.com>
14118
14119 * makefile.w32-in: Update dependencies.
14120
09f6ff02
EZ
141212011-03-17 Eli Zaretskii <eliz@gnu.org>
14122
14123 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14124
29a6015a
PE
141252011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14126
a3a6c54e
PE
14127 Fix more problems found by GCC 4.5.2's static checks.
14128
b766f867
PE
14129 * process.c (make_serial_process_unwind, send_process_trap):
14130 (sigchld_handler): Now static.
14131
be02381c
PE
14132 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14133 That way, the code declares only the vars that it needs.
14134 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14135 * s/cygwin.h (PTY_ITERATION): Likewise.
14136 * s/darwin.h (PTY_ITERATION): Likewise.
14137 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14138
57048744
PE
14139 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14140 * process.c (allocate_pty): Don't declare stb unless it's needed.
14141
7914961c 14142 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14143 (CONSTANTLIM): Remove; unused.
14144 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14145 Define only if needed.
7914961c 14146
b3967b18
PE
14147 * unexelf.c (unexec): Name an expression,
14148 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14149 Use a different way to cause a compilation error if anyone uses
14150 n rather than nn, a way that does not involve shadowing.
73366a00 14151 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14152
29a6015a
PE
14153 * deps.mk (unexalpha.o): Remove; unused.
14154
43cfc33e 14155 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14156 * unexec.h: New file.
ce701a33
PE
14157 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14158 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14159 Depend on unexec.h.
14160 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14161 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14162 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14163 Change as necessary to match prototype in unexec.h.
ce701a33 14164
01f44d5a
PE
14165 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14166 shadowing.
4f63c6bb 14167 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14168
a6670b0b
PE
14169 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14170 Rename locals to avoid shadowing.
14171
cef2010d 14172 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14173 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14174
d4d7173a
PE
14175 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14176
f08b802a
PE
14177 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14178 warning when compiling print.c.
14179
3ddb0639
PE
14180 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14181 instead of using an uninitialized var.
5ad03b97 14182 (font_sort_entities): Mark var as initialized.
3ddb0639 14183
170a2692
PE
14184 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14185
e663c700
PE
14186 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14187 pointers to constants.
89bc529a 14188 (font_parse_fcname): Remove unused vars.
7b81e2d0 14189 (font_delete_unmatched): Now static.
ea838e10 14190 (font_get_spec): Remove; unused.
13a547c6
PE
14191 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14192 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14193 Rename or move locals to avoid shadowing.
e663c700 14194
2a80c887 14195 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14196 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14197
1384fa33 14198 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14199 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14200
8b2c52e9
PE
14201 * alloc.c (mark_backtrace): Move decl from here ...
14202 * lisp.h: ... to here, so that it can be checked.
14203
475545b5 14204 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14205 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14206 (lisp_indirect_variable): Name an expression,
14207 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14208 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14209
b1349114 14210 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14211 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14212 Use const pointer when appropriate.
b1349114 14213
a2928364
PE
14214 * lisp.h (get_system_name, get_operating_system_release):
14215 Move decls here, to check interfaces.
14216 * process.c (get_operating_system_release): Move decl to lisp.h.
14217 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14218 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14219 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14220 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14221 (Fformat_time_string, Fencode_time, Finsert_char):
14222 (Ftranslate_region_internal, Fformat):
14223 Rename or remove local vars to avoid shadowing.
9710023e 14224 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14225
a415e694
PE
14226 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14227 avoid shadowing.
14228
8ef4622d
PE
14229 * lisp.h (eassert): Check that the argument compiles, even if
14230 ENABLE_CHECKING is not defined.
14231
946f9a5b
PE
14232 * data.c (Findirect_variable): Name an expression, to avoid
14233 gcc -Wbad-function-cast warning.
112396d6 14234 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14235 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14236 (Fmake_variable_buffer_local, Fmake_local_variable):
14237 Mark variables as initialized.
52746918 14238 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14239
e5aab7e7 14240 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14241 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14242 Rename locals to avoid shadowing.
dff45157
PE
14243 (mark_stack): Move local variables into the #ifdef region where
14244 they're used.
7bc26fdb
PE
14245 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14246 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14247 needed otherwise.
14248 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14249 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14250 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14251
e5aab7e7
PE
14252 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14253 avoids undefined behavior in theory.
14254
4da60324
PE
14255 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14256
88043301
PE
14257 Use functions, not macros, for up- and down-casing (Bug#8254).
14258 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14259 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14260 to use the following functions instead of these macros.
14261 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14262 EMACS_INT, since callers assume the returned value fits in int.
14263 (upcase1): Likewise, for UPCASE_TABLE.
14264 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14265 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14266 the race-condition problem in the old DOWNCASE.
88043301 14267
19ed5445
PE
14268 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14269 Rename locals to avoid shadowing.
14270 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14271 (regex_compile, re_search_2, re_match_2_internal):
14272 Remove unused local vars.
952db0d7
PE
14273 (FREE_VAR): Rewrite so as not to use empty "else",
14274 which gcc can warn about.
da053e48 14275 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14276 (RETALLOC_IF): Define only if needed.
14277 (WORDCHAR_P): Likewise. This one is never needed, but is used
14278 only in a comment talking about a compiler bug, so put inside
14279 the #if 0 of that comment.
14280 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14281 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14282 Remove; unused.
19ed5445 14283
1f3561e4 14284 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14285 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14286 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14287
ded6f8f7
PE
14288 * search.c (simple_search): Remove unused var.
14289
dbd37a95
PE
14290 * dired.c (compile_pattern): Move decl from here ...
14291 * lisp.h: ... to here, so that it can be checked.
14292 (struct re_registers): New forward decl.
14293
7e47afad
PE
14294 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14295
85f24f61
PE
14296 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14297 All uses changed.
14298 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14299 Rename locals to avoid shadowing.
5671df8f 14300 (Fvertical_motion): Mark locals as initialized.
85f24f61 14301
181aa2be 14302 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14303 (casify_region): Mark local as initialized.
181aa2be 14304
930d429c
PE
14305 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14306
7082eac6
PE
14307 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14308 New macros, so that the caller can use some names other than
14309 gcpro1, gcpro2, etc.
14310 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14311 of the new macros.
14312 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14313 argument, for consistency with GCPRO2_VAR, etc: it is now the
14314 prefix of the variable, not the variable itself. All uses
14315 changed.
38b2c076
PE
14316 * dired.c (directory_files_internal, file_name_completion):
14317 Rename locals to avoid shadowing.
14318
15206ed9
PE
14319 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14320 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14321 dired.c's scmp function, had undefined behavior.
14322 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14323 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14324 * buffer.h: ... to here, because these macros use current_buffer,
14325 and the new implementation with inline functions needs to have
14326 current_buffer in scope now, rather than later when the macros
14327 are used.
14328 (downcase, upcase1): New static inline functions.
14329 (DOWNCASE, UPCASE1): Reimplement using these functions.
14330 This avoids undefined behavior in expressions like
14331 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14332 from race conditions in accessing the global variables
14333 case_temp1 and case_temp2.
14334 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14335 * lisp.h (case_temp1, case_temp2): Remove their decls.
14336 * character.h (ASCII_CHAR_P): Move from here ...
14337 * lisp.h: ... to here, so that the inline functions mentioned
14338 above can use them.
14339
4a6bea26
PE
14340 * dired.c (directory_files_internal_unwind): Now static.
14341
f14b7e14
PE
14342 * fileio.c (file_name_as_directory, directory_file_name):
14343 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14344 Now static.
2893f146
PE
14345 (file_name_as_directory): Use const pointers when appropriate.
14346 (Fexpand_file_name): Likewise. In particular, newdir might
14347 point at constant storage, so make it a const pointer.
fd4ead52 14348 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14349 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14350 signedness issues.
f839df0c
PE
14351 (Fset_file_times, Finsert_file_contents, auto_save_error):
14352 Rename locals to avoid shadowing.
f14b7e14 14353
5716756e 14354 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14355 (Ftry_completion, Fall_completions): Rename or remove locals
14356 to avoid shadowing.
5716756e 14357
b4c3046a
PE
14358 * marker.c (bytepos_to_charpos): Remove; unused.
14359
b45db522
PE
14360 * lisp.h (verify_bytepos, count_markers): New decls,
14361 so that gcc does not warn that these functions aren't declared.
14362
85876d07
PE
14363 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14364 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14365 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14366 (copy_text): Remove unused local var.
85876d07 14367
03d78a21 14368 * filelock.c (within_one_second): Now static.
b3dd38ab 14369 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14370
5df8f01b
PE
14371 * buffer.c (fix_overlays_before): Mark locals as initialized.
14372 (fix_start_end_in_overlays): Likewise. This function should be
14373 simplified by using pointers-to-pointers, but that's a different
14374 matter.
b1d876f1 14375 (switch_to_buffer_1): Now static.
8f54f30a
PE
14376 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14377 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14378
a70072c9 14379 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14380 Fix pointer signedness issue.
edced198
PE
14381 (sys_subshell): Mark local as volatile if checking for lint,
14382 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14383 (MAXPATHLEN): Define only if needed.
a70072c9 14384
a0977c44
PE
14385 * process.c (serial_open, serial_configure): Move decls from here ...
14386 * systty.h: ... to here, so that they can be checked.
14387
a884fdcc
PE
14388 * fns.c (get_random, seed_random): Move extern decls from here ...
14389 * lisp.h: ... to here, so that they can be checked.
14390
604efe86 14391 * sysdep.c (reset_io): Now static.
b8950c94 14392 (wait_for_termination_signal): Remove; unused.
604efe86 14393
38fc62d9
PE
14394 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14395 (copy_keymap_item, append_key, push_text_char_description):
14396 Now static.
1004a21a 14397 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14398 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14399 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14400 (describe_map_tree):
14401 Rename locals to avoid shadowing.
38fc62d9 14402
2f2650da
PE
14403 * keyboard.c: Declare functions static if they are not used elsewhere.
14404 (echo_char, echo_dash, cmd_error, top_level_2):
14405 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14406 (read_char, kbd_buffer_get_event, make_lispy_position):
14407 (make_lispy_event, make_lispy_movement, apply_modifiers):
14408 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14409 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14410 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14411 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14412 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14413
a053e86c 14414 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14415 (mark_kboards): Move decl here ...
14416 * alloc.c (mark_kboards): ... from here.
a053e86c 14417
4752793e
PE
14418 * lisp.h (force_auto_save_soon): New decl.
14419
74f10ca7 14420 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14421 (DEFINE_DUMMY_FUNCTION): New macro.
14422 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14423 Use it.
c03cd23f
PE
14424 (main): Add casts to avoid warnings
14425 if GCC considers string literals to be constants.
74f10ca7 14426
022e70d4
PE
14427 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14428
59d6fe83
PE
14429 * dbusbind.c: Pointer signedness fixes.
14430 (xd_signature, xd_append_arg, xd_initialize):
14431 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14432 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14433 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14434 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14435
78320123
PE
14436 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14437 if GCC considers string literals to be constants.
49cebcca 14438 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14439
35ac2a97
SM
144402011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14441
fb103ca9
SM
14442 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14443 (print_preprocess, print_object): New macro to fix last change.
14444
35ac2a97
SM
14445 * print.c (print_preprocess): Don't forget font objects.
14446
62973b41
JB
144472011-03-16 Juanma Barranquero <lekktu@gmail.com>
14448
14449 * emacs.c (USAGE3): Doc fixes.
14450
0e48bb22
AS
144512011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14452
14453 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14454 structure.
14455
7684e57b
JB
144562011-03-14 Juanma Barranquero <lekktu@gmail.com>
14457
14458 * lisp.h (VWindow_system, Qfile_name_history):
14459 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14460 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14461 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14462
14463 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14464 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14465
14466 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14467 * w32console.c (detect_input_pending, read_input_pending)
14468 (encode_terminal_code):
14469 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14470 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14471 (w32_system_caret_y, Qfile_name_history):
14472 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14473 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14474 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14475 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14476 * w32proc.c (Qlocal, report_file_error):
14477 * w32term.c (Vwindow_system, updating_frame):
14478 * w32uniscribe.c (initialized, uniscribe_font_driver):
14479 Remove unneeded extern declarations.
14480
2aa46d6c
CY
144812011-03-14 Chong Yidong <cyd@stupidchicken.com>
14482
c96bbc66 14483 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14484
cffc6f3b
CY
144852011-03-13 Chong Yidong <cyd@stupidchicken.com>
14486
14487 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14488 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14489 These macros can no longer be used for assignment.
14490
44f230aa
SM
14491 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14492 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14493 (record_buffer_markers, fetch_buffer_markers): New functions for
14494 recording and fetching special buffer markers.
14495 (set_buffer_internal_1, set_buffer_temp): Use them.
14496
14497 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14498
14499 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14500
14501 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14502 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14503
14504 * xdisp.c (hscroll_window_tree):
14505 (reconsider_clip_changes): Use PT instead of BUF_PT.
14506
d251f04b
EZ
145072011-03-13 Eli Zaretskii <eliz@gnu.org>
14508
14509 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14510 $(EMACS_ROOT)/lib/intprops.h.
14511
f0c77cd1
PE
145122011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14513
3eca4629
PE
14514 Fix more problems found by GCC 4.5.2's static checks.
14515
7c86ee98
PE
14516 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14517 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14518 (xg_free_frame_widgets): Make it clear that a local variable is
14519 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14520 (gdk_window_get_screen): Make it clear that this macro is needed
14521 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14522 (int_gtk_range_get_value): New function, which avoids a diagnostic
14523 from gcc -Wbad-function-cast.
14524 (xg_set_toolkit_scroll_bar_thumb): Use it.
14525 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14526 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14527 (get_utf8_string, xg_get_file_with_chooser):
14528 Rename locals to avoid shadowing.
14529 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14530
41729b81
PE
14531 * xgselect.c (xg_select): Remove unused var.
14532
f0c77cd1
PE
14533 * image.c (four_corners_best): Mark locals as initialized.
14534 (gif_load): Initialize transparent_p to zero (Bug#8238).
14535 Mark another local as initialized.
ec6cf4c6 14536 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14537
ce0ad53d 14538 * image.c (clear_image_cache): Now static.
d5d5a617 14539 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14540 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14541 (x_edge_detection): Remove unnecessary cast that
14542 gcc -Wbad-function-cast diagnoses.
2037898d 14543 (gif_load): Fix pointer signedness.
6ae141d6
PE
14544 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14545 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14546
33383987 145472011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14548
d32df629
PE
14549 Improve quality of tests for time stamp overflow.
14550 For example, without this patch (encode-time 0 0 0 1 1
14551 1152921504606846976) returns the obviously-bogus value (-948597
14552 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14553 reports time overflow. See
14554 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14555 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14556 * editfns.c: Include limits.h and intprops.h.
14557 (TIME_T_MIN, TIME_T_MAX): New macros.
14558 (time_overflow): Move earlier, to before first use.
14559 (hi_time, lo_time): New functions, for an accurate test for
14560 out-of-range times.
14561 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14562 (Fget_internal_run_time): Don't assume time_t fits in int.
14563 (make_time): Use list2 instead of Fcons twice.
14564 (Fdecode_time): More accurate test for out-of-range times.
14565 (check_tm_member): New function.
14566 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14567 (lisp_time_argument): Don't rely on undefined left-shift and
14568 right-shift behavior when checking for time stamp overflow.
8be6f318 14569
fe31d94c
PE
14570 * editfns.c (time_overflow): New function, refactoring common code.
14571 (Fformat_time_string, Fdecode_time, Fencode_time):
14572 (Fcurrent_time_string): Use it.
14573
8be6f318
PE
14574 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14575 * dired.c (make_time): Move to ...
14576 * editfns.c (make_time): ... here.
14577 * systime.h: Note the move.
14578
09d9db2c 145792011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14580
126bc0dc
YM
14581 * fringe.c (update_window_fringes): Remove unused variables.
14582
c47cbdfd
YM
14583 * unexmacosx.c (copy_data_segment): Also copy __got section.
14584 (Bug#8223)
14585
7ac80be9
EZ
145862011-03-12 Eli Zaretskii <eliz@gnu.org>
14587
c96bbc66 14588 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14589 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14590 Constify `char *' arguments and their references according to
14591 prototypes in tparam.h.
14592
ecb0f94d 14593 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14594
7ac80be9
EZ
14595 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14596 Adapt all references accordingly.
14597
14598 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14599
ef1fd07e
TT
146002011-03-11 Tom Tromey <tromey@redhat.com>
14601
14602 * buffer.c (syms_of_buffer): Remove obsolete comment.
14603
7ef4b50c
EZ
146042011-03-11 Eli Zaretskii <eliz@gnu.org>
14605
14606 * termhooks.h (encode_terminal_code): Declare prototype.
14607
14608 * msdos.c (encode_terminal_code): Don't declare prototype.
14609
14610 * term.c (encode_terminal_code): Now external again, used by
14611 w32console.c and msdos.c.
14612
44f230aa
SM
14613 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14614 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14615
4b1ec863 146162011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14617
1714f52b 14618 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14619
4b1ec863
PE
14620 * fringe.c (update_window_fringes): Mark locals as initialized
14621 (Bug#8227).
14622 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14623
524c7aa6
PE
14624 * alloc.c (mark_fringe_data): Move decl from here ...
14625 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14626 to check its interface.
14627 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14628
a5c0af81 14629 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14630 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14631 (fontset_font): Mark local as initialized.
a9a06e0b 14632 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14633
b4716021
PE
14634 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14635
811e9bac 14636 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14637 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14638 (x_own_selection, Fx_disown_selection_internal): Rename locals
14639 to avoid shadowing.
14640 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14641
7e3ab302
PE
14642 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14643 so that the caller can use some name other than gcpro1.
14644 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14645 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14646 (Fx_backspace_delete_keys_p):
14647 Use them to avoid shadowing, and rename vars to avoid shadowing.
14648 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14649 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14650 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14651 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14652 Remove unused locals.
7e3ab302
PE
14653 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14654 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14655 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14656 macros.
f78faa98 14657
e2b13473
PE
14658 * xterm.h (x_mouse_leave): New decl.
14659
77f23912
PE
14660 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14661 Remove unused functions.
cdf4ba58
PE
14662 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14663 (x_calc_absolute_position): Now static.
7411c686 14664 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14665 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14666 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14667 unless they are used.
38d0b34a
PE
14668 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14669 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14670 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14671 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14672 (x_error_catcher, x_connection_closed, x_error_handler):
14673 (x_error_quitter, xembed_send_message, x_iconify_frame):
14674 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14675 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14676 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14677
44f230aa
SM
14678 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14679 Rename or move locals to avoid shadowing.
6b463e58 14680 (tty_defined_color, merge_face_heights): Now static.
5967d051 14681 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14682 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14683 does not deduce is never used uninitialized.
73719eba
PE
14684 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14685 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14686
426994c3 14687 * terminal.c (store_terminal_param): Now static.
5489860b 14688
032f1620 14689 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14690 (set_frame_menubar): Remove unused local.
d4323972 14691 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14692 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14693 since they might point to immutable storage.
281585b0
PE
14694 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14695 since it's unused otherwise.
032f1620 14696
367c19e5 14697 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14698 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14699 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14700 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14701 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14702 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14703 does not deduce are never used uninitialized.
70739cbe 14704
07b48fa9
PE
14705 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14706
8868a238 14707 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14708 * window.c (window_loop, size_window):
14709 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14710
7e5cf297 14711 * window.c (display_buffer): Now static.
d6550a9f
PE
14712 (size_window): Mark variables that gcc -Wuninitialized
14713 does not deduce are never used uninitialized.
a586633d
PE
14714 * window.h (check_all_windows): New decl, to forestall
14715 gcc -Wmissing-prototypes diagnostic.
5b555da1 14716 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14717
f6095868
PE
14718 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14719 shadowing.
14720 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14721 Include <limits.h>.
14722 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14723 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14724 (load_charset_map): Mark variables that gcc -Wuninitialized
14725 does not deduce are never used uninitialized.
53df7c11 14726 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14727
f38b440c
PE
14728 * coding.c (coding_set_source, coding_set_destination):
14729 Use "else { /* comment */ }" rather than "else /* comment */;"
14730 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14731 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14732 a block, when the outer 'i' will do.
14733 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14734 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14736 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14737 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14738 Rename locals to avoid shadowing.
14739 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14740 * coding.c (emacs_mule_char, encode_invocation_designation):
14741 Now static, since they're not used elsewhere.
413bb2db 14742 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14743 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14744 (decode_coding_emacs_mule): Mark variables that gcc
14745 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14746 (detect_coding_iso_2022): Initialize a local variable that might
14747 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14748 this initialization is needed. (Bug#8211)
5f58e762
PE
14749 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14750 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14751 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14752 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14753 Remove unused macros.
f38b440c 14754
232b38b9 14755 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14756 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14757 * character.c (string_count_byte8): Likewise.
232b38b9 14758
fb90da1b
PE
14759 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14760 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14761
fb93dbc2
PE
14762 * chartab.c (copy_sub_char_table): Now static, since it's not used
14763 elsewhere.
5c156ace
PE
14764 (sub_char_table_ref_and_range, char_table_ref_and_range):
14765 Rename locals to avoid shadowing.
bbcd0949 14766 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14767
7d3b3862 14768 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14769 (BIDI_BOB): Remove unused macro.
7d3b3862 14770
6be7d3da
PE
14771 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14772 deduce are never used uninitialized.
c2ed9c8b 14773 * term.c (encode_terminal_code): Likewise.
6be7d3da 14774
75f8807f 14775 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14776
50938595
PE
14777 * tparam.h: New file.
14778 * term.c, tparam.h: Include it.
14779 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14780 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14781 Move these decls to tparam.h, and make them agree with what
14782 is actually in tparam.c. The previous trick of using incompatible
14783 decls in different modules does not conform to the C standard.
14784 All callers of tparam changed to use tparam's actual API.
14785 * tparam.c (tparam1, tparam, tgoto):
14786 Use const pointers where appropriate.
14787
fbceeba2
PE
14788 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14789 * cm.h (struct cm): Likewise.
14790 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14791 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14792 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14793 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14794 (turn_on_face, init_tty): Likewise.
14795 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14796
7f3f1250
PE
14797 * term.c (term_mouse_position): Rename local to avoid shadowing.
14798
e6ca6543
PE
14799 * alloc.c (mark_ttys): Move decl from here ...
14800 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14801
c40f8d15
AS
148022011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14803
14804 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14805
cfe0661d
JB
148062011-03-09 Juanma Barranquero <lekktu@gmail.com>
14807
14808 * search.c (compile_pattern_1): Remove argument regp, unused since
14809 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14810 (compile_pattern): Don't pass it.
14811
0afb4571
J
148122011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14813
14814 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14815 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14816 for ! HAVE_GTK3.
14817 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14818
14819 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14820
14821 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14822 gdk_window_get_screen, gdk_window_get_geometry,
14823 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14824 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14825 (xg_get_pixbuf_from_pixmap): New function.
14826 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14827 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14828 Call xg_get_pixbuf_from_pixmap instead of
14829 gdk_pixbuf_get_from_drawable.
14830 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14831 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14832 (xg_check_special_colors): Use GtkStyleContext and its functions
14833 for HAVE_GTK3.
14834 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14835 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14836 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14837 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14838 Call gtk_widget_get_preferred_size.
0afb4571
J
14839 (xg_frame_resized): gdk_window_get_geometry only takes 5
14840 parameters.
44f230aa
SM
14841 (xg_win_to_widget, xg_event_is_for_menubar):
14842 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14843 (xg_set_widget_bg): New function.
14844 (delete_cb): New function.
895009e1 14845 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14846 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14847 (xg_set_background_color): Call xg_set_widget_bg.
14848 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14849 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14850 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14851 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14852 if ! HAVE_GTK3.
14853 (update_frame_tool_bar): Call gtk_widget_hide.
14854 (xg_initialize): Use GDK_KEY_g.
14855
14856 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14857 if ! HAVE_GTK3
14858 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14859
14860 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14861 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14862 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14863
1c2cc4ef
JB
148642011-03-08 Juanma Barranquero <lekktu@gmail.com>
14865
14866 * w32xfns.c (select_palette): Check success of RealizePalette against
14867 GDI_ERROR, not zero.
14868
33383987 14869See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14870
14871;; Local Variables:
14872;; coding: utf-8
aac0c6e3
MR
14873;; End:
14874
2f097256 14875 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14876
14877 This file is part of GNU Emacs.
14878
14879 GNU Emacs is free software: you can redistribute it and/or modify
14880 it under the terms of the GNU General Public License as published by
14881 the Free Software Foundation, either version 3 of the License, or
14882 (at your option) any later version.
14883
14884 GNU Emacs is distributed in the hope that it will be useful,
14885 but WITHOUT ANY WARRANTY; without even the implied warranty of
14886 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14887 GNU General Public License for more details.
14888
14889 You should have received a copy of the GNU General Public License
14890 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.