Move url-future.el ERT test to test/automated/url-future-tests.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
af70074f
SM
12012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * keymap.c (Fsingle_key_description): Handle char ranges.
4
95986d52
CY
52012-02-12 Chong Yidong <cyd@gnu.org>
6
afd83bd1
CY
7 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
8 as that creates a dangerous corner case.
9
95986d52
CY
10 * window.c (Fdelete_window_internal): Invalidate the mouse
11 highlight (Bug#9904).
12
bd7da63e
GM
132012-02-12 Glenn Morris <rgm@gnu.org>
14
15 * xselect.c (Fx_own_selection_internal)
16 (Fx_get_selection_internal, Fx_disown_selection_internal)
17 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
18 * nsselect.m (Fx_own_selection_internal)
19 (Fx_disown_selection_internal, Fx_selection_exists_p)
20 (Fx_selection_owner_p, Fx_get_selection_internal):
21 Sync docs and argument specs with the xselect.c versions.
22
77abcbc2
LI
232012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
24
25 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
26
90b671e2
EZ
272012-02-11 Eli Zaretskii <eliz@gnu.org>
28
1c0ca0b7
EZ
29 * w32select.c (Fx_selection_exists_p): Sync doc string and
30 argument list with xselect.c. (Bug#10783)
31
32 * w16select.c (Fx_selection_exists_p): Sync doc string and
33 argument list with xselect.c. (Bug#10783)
90b671e2 34
49241268
GM
352012-02-10 Glenn Morris <rgm@gnu.org>
36
37 * fns.c (Fsecure_hash): Doc fix.
38
f998bbe7 392012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
40
41 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
42
0992bd9c
CY
432012-02-07 Chong Yidong <cyd@gnu.org>
44
45 * buffer.c (Fbuffer_local_variables)
46 (buffer_lisp_local_variables): Handle unbound vars correctly;
47 don't let Qunbound leak into Lisp.
48
af008560
GM
492012-02-07 Glenn Morris <rgm@gnu.org>
50
dd605cc4
GM
51 * image.c (Fimagemagick_types): Doc fix.
52
af008560
GM
53 * image.c (imagemagick-render-type): Change it from a lisp object
54 to an integer. Move the doc here from the lisp manual.
55 Treat all values not equal to 0 the same.
56
1449fa1d
CY
572012-02-06 Chong Yidong <cyd@gnu.org>
58
59 * doc.c (store_function_docstring): Avoid applying docstring of
60 alias to base function (Bug#2603).
61
3723ec07
AS
622012-02-04 Andreas Schwab <schwab@linux-m68k.org>
63
64 * .gdbinit (pp1, pv1): Remove redundant defines.
65 (pr): Use pp.
66
79c1cc1e
CY
672012-02-04 Chong Yidong <cyd@gnu.org>
68
69 * nsterm.m: Declare a global (Bug#10694).
70
d7f29f8e
EZ
712012-02-04 Eli Zaretskii <eliz@gnu.org>
72
73 * w32.c (get_emacs_configuration_options): Include
74 --enable-checking, if specified, in the return value.
75
3b95a6f9
MR
762012-02-04 Martin Rudalics <rudalics@gmx.at>
77
78 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
79 after rounding frame sizes. (Bug#9723)
80
d6fa96a6
EZ
812012-02-04 Eli Zaretskii <eliz@gnu.org>
82
83 * keyboard.c (adjust_point_for_property): Don't position point
84 before BEGV. (Bug#10696)
85
df0b2940
PE
862012-02-03 Paul Eggert <eggert@cs.ucla.edu>
87
88 Handle overflow when computing char display width (Bug#9496).
89 * character.c (char_width): Return EMACS_INT, not int.
90 (char_width, c_string_width): Check for overflow when
91 computing the width; this is possible now that individual
92 characters can have unbounded width. Problem introduced
93 by merge from Emacs 23 on 2012-01-19.
94
6bee44d6
MA
952012-02-02 Michael Albinus <michael.albinus@gmx.de>
96
97 * dbusbind.c (Fdbus_register_method): Mention the return value
98 :ignore in the docstring.
99
44f92739
GM
1002012-02-02 Glenn Morris <rgm@gnu.org>
101
1b9f60cc
GM
102 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
103
44f92739
GM
104 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
105 Unconditionally set to t. (Bug#10673)
106 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
107 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
108 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
109
c5d3843c
KH
1102012-02-02 Kenichi Handa <handa@m17n.org>
111
112 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
113 0, do not call append_composite_glyph.
114
159462d4 1152012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
116
117 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
118 NULL (Bug#6988).
119 (x_produce_glyphs): If the component of a composition is a null
120 string, set it->pixel_width to 1 to avoid zero-width glyph.
121
78cef877
EZ
1222012-02-01 Eli Zaretskii <eliz@gnu.org>
123
124 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
125 first 2 arguments are identical. This makes inserting large
126 output from a subprocess an order of magnitude faster on
127 MS-Windows, where all sbrk'ed memory is always contiguous.
128
97897668
GM
1292012-01-31 Glenn Morris <rgm@gnu.org>
130
131 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 132 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
133 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
134
31fd3586
GM
1352012-01-29 Glenn Morris <rgm@gnu.org>
136
137 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
138
0e24a8b2
CY
1392012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
140
141 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
142
cc0adcb0
CY
1432012-01-28 Chong Yidong <cyd@gnu.org>
144
145 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
146
acc28cb9
CY
1472012-01-26 Chong Yidong <cyd@gnu.org>
148
9c69cfb7
CY
149 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
150
acc28cb9
CY
151 * search.c (Fsearch_forward, Fsearch_backward): Document negative
152 repeat counts (Bug#10507).
153
48da7392
GM
1542012-01-26 Glenn Morris <rgm@gnu.org>
155
156 * lread.c (syms_of_lread): Doc fix.
157
14af5f7f
CY
1582012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
159
160 * coding.c (encode_designation_at_bol): Change return value to
161 EMACS_INT.
162
0b21c100
CY
1632012-01-25 Chong Yidong <cyd@gnu.org>
164
165 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
166
3c2907f7
CY
1672012-01-21 Chong Yidong <cyd@gnu.org>
168
169 * floatfns.c (Fcopysign): Make the second argument non-optional,
170 since nil is not allowed anyway.
171
959ad23f
AS
1722012-01-21 Andreas Schwab <schwab@linux-m68k.org>
173
174 * process.c (read_process_output): Use p instead of XPROCESS (proc).
175 (send_process): Likewise.
176
34a02f46
MR
1772012-01-19 Martin Rudalics <rudalics@gmx.at>
178
179 * window.c (save_window_save, Fcurrent_window_configuration)
180 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
181 doc-strings.
182
1259009a 1832012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
184
185 * character.c (char_width): New function.
70d4fdf6
GM
186 (Fchar_width, c_string_width, lisp_string_width):
187 Use char_width (Bug#9496).
25ed9e61 188
6a6ee00d
MR
1892012-01-16 Martin Rudalics <rudalics@gmx.at>
190
191 * window.c (Vwindow_persistent_parameters): New variable.
192 (Fset_window_configuration, save_window_save): Handle persistent
193 window parameters.
194
c85efaf7
EZ
1952012-01-14 Eli Zaretskii <eliz@gnu.org>
196
197 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
198 thrashing the stack of the thread. (Bug#9087)
199
5944709e
PE
2002012-01-12 Paul Eggert <eggert@cs.ucla.edu>
201
202 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
203
e71f5d99
EZ
2042012-01-11 Eli Zaretskii <eliz@gnu.org>
205
206 * xdisp.c (rows_from_pos_range): Handle the case where the
207 highlight ends on a newline. (Bug#10464)
208 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
209 he end column for display of highlight that ends on a newline
210 before a R2L line.
211
ce316182
GM
2122012-01-11 Glenn Morris <rgm@gnu.org>
213
214 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
215 from load-path also when installation-directory is nil. (Bug#10208)
216
5b43da69
GM
2172012-01-10 Glenn Morris <rgm@gnu.org>
218
74cc8ff9
GM
219 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
220
7d8d6e4e
GM
221 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
222 Update template values to be closer to their typical values these days.
5b43da69 223
a0db8d43
EZ
2242012-01-09 Eli Zaretskii <eliz@gnu.org>
225
226 * xdisp.c (rows_from_pos_range): Accept additional argument
227 DISP_STRING, and accept any glyph in a row whose object is that
228 string as eligible for mouse highlight. Fixes mouse highlight of
229 display strings from overlays. (Bug#10464)
230
9a0115ab 2312012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 232
b9110d6a 233 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
234 * fileio.c (auto_saving_dir_umask): New static var.
235 (Fmake_directory_internal): Use it.
236 (do_auto_save_make_dir): Set it, instead of invoking chmod after
237 creating the directory. The old code temporarily assigns
238 too-generous permissions to the directory.
239 (do_auto_save_eh): Clear it.
b9110d6a 240 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
241 that the var is always cleared.
242
6c1bd3f3
EZ
2432012-01-07 Eli Zaretskii <eliz@gnu.org>
244
245 * search.c (scan_buffer): Pass character positions to
246 know_region_cache, not byte positions. (Bug#6540)
247
069d2b50
L
2482012-01-07 LynX <_LynX@bk.ru> (tiny change)
249
250 * w32.c (sys_rename): Report EXDEV when rename of a directory
251 fails because the target is on another logical disk. (Bug#10284)
252
75bf0d33
DB
2532012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
254
255 * xterm.c (x_embed_request_focus): New function.
256
257 * xterm.h: Add prototype.
258
259 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
260
1c6e5a32
GM
2612012-01-05 Glenn Morris <rgm@gnu.org>
262
263 * emacs.c (emacs_copyright): Update short copyright year to 2012.
264
651e947e
EZ
2652012-01-01 Eli Zaretskii <eliz@gnu.org>
266
267 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
268 Load gnutls_transport_set_lowat only if GnuTLS version is below
269 2.11.1.
270 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
271 GnuTLS versions below 2.11.1.
272
3778cdd8
AL
2732011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
274
275 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
276 to the doc string advising against its use for altering the way
277 windows are scrolled.
278
0e5317f7
KH
2792011-12-28 Kenichi Handa <handa@m17n.org>
280
281 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
282 coding-system ASCII compatible only when it does not produce BOM
283 on encoding (Bug#10383).
284
93d5ca1f
JD
2852011-12-26 Jan Djärv <jan.h.d@swipnet.se>
286
287 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
288 can scroll.
289 (create_and_show_popup_menu): Always use menu_position_func for
290 Gtk3 (Bug#10361).
291
ca22b785
AS
2922011-12-24 Andreas Schwab <schwab@linux-m68k.org>
293
294 * callint.c (Fcall_interactively): Don't truncate prompt string.
295
d048e1e6
EZ
2962011-12-23 Eli Zaretskii <eliz@gnu.org>
297
298 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
299 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 300 resumed from there (after widening). (Bug#10360)
d048e1e6 301
5ccaba1f
JD
3022011-12-22 Jan Djärv <jan.h.d@swipnet.se>
303
304 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
305
204ee57f
JD
3062011-12-21 Jan Djärv <jan.h.d@swipnet.se>
307
b81d40f0
JB
308 * nsterm.m (x_free_frame_resources):
309 Release f->output_data.ns->miniimage.
204ee57f
JD
310 (ns_index_color): Fix indentation. Do not retain
311 color_table->colors[i].
312
313 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
314 before returning.
315
316 * nsfns.m (x_set_background_color): Assign return value from
317 ns_index_color to face-background instead of NSColor*.
318 (ns_implicitly_set_icon_type): Fix indentation.
319 Change assignment in for loop to comparison.
320
321 * emacs.c (ns_pool): New variable.
322 (main): Assign ns_pool.
323 (Fkill_emacs): Call ns_release_autorelease_pool.
324
325 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
326 autorelease fdesc, release fdAttrs and tdict.
327 (ns_get_covering_families): Release charset.
328 (ns_findfonts): Release NSFontDescriptor created with new.
329 (ns_uni_to_glyphs): Fix indentation.
330 (setString): Release attrStr before assigning new value.
331
c803b2b7
JD
3322011-12-18 Jan Djärv <jan.h.d@swipnet.se>
333
678f4426
JD
334 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
335 and NS_IMPL_COCOA.
336 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
337 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
338
cd394be1 3392011-12-18 David Reitter <reitter@cmu.edu>
678f4426 340
5fecd5fc
JD
341 * nsterm.m (ns_term_init): Subscribe for notifications
342 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
343 to method trackingNotification in EmacsMenu.
344
345 * nsmenu.m (trackingMenu): New variable.
3771cb17 346 (trackingNotification): New method (from Aquamacs).
5fecd5fc 347 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 348 from Aquamacs (Bug#7030).
678f4426
JD
349
3502011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 351
c803b2b7
JD
352 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
353 (symbol_to_nsstring): Fix indentation.
354 (ns_symbol_to_pb): New function.
355 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
356 (Fns_rotate_cut_buffers_internal): Removed.
357 (Fns_store_selection_internal): Renamed from
358 Fns_store_cut_buffer_internal.
359 (ns_get_foreign_selection, Fx_own_selection_internal)
360 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
361 (Fns_get_selection_internal, Fns_store_selection_internal):
362 Use ns_symbol_to_pb and check if return value is nil.
363 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
364 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
365 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
366 renamed to Sns_store_selection_internal.
367 (ns_handle_selection_request): Move code to Fx_own_selection_internal
368 and remove this function.
369 (ns_handle_selection_clear): Remove, never used.
370 (Fx_own_selection_internal): Move code from ns_handle_selection_request
371 here.
372
e1b01a3a
KB
3732011-12-17 Ken Brown <kbrown@cornell.edu>
374
375 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
376 GID is unknown (Bug#10257).
377
2adb6e85
PE
3782011-12-17 Paul Eggert <eggert@cs.ucla.edu>
379
380 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
381 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
382 which caused a build failure on GNU/Linux IA-64. This problem was
383 introduced by my 2011-10-07 patch.
384
d1d7b339
JL
3852011-12-15 Juri Linkov <juri@jurta.org>
386
387 * image.c (imagemagick_error): New function. (Bug#10112)
388 (imagemagick_load_image): Comment out `MagickSetResolution' call.
389 Use `imagemagick_error' where ImageMagick functions return
390 `MagickFalse'.
391 (Fimagemagick_types): Add `Fnreverse' to return the list in the
392 proper order.
393
100d5755
KH
3942011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
395
396 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
397 fill background (Bug#8992).
398
454592a6
MR
3992011-12-13 Martin Rudalics <rudalics@gmx.at>
400
401 * window.c (Vwindow_combination_resize)
402 (Vwindow_combination_limit): Use t instead of non-nil in
403 doc-strings.
61d4b438
MR
404 (Vrecenter_redisplay): Add first sentence of doc-string on
405 separate line.
53524d93 406 (Frecenter): Fix doc-string typo.
454592a6 407
3633e3aa
KH
4082011-12-11 Kenichi Handa <handa@m17n.org>
409
410 * coding.c (Funencodable_char_position): Pay attention to the
411 buffer text relocation (Bug#9389).
412
7b9d523a
JD
4132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
414
415 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
416 gtk_init (Bug#10100).
417
b73189c6
EZ
4182011-12-10 Eli Zaretskii <eliz@gnu.org>
419
420 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
421 IT->string is nil. (Bug#10263)
422
f7dfe5d6
JD
4232011-12-10 Jan Djärv <jan.h.d@swipnet.se>
424
83faebb4
JD
425 * nsterm.h (x_free_frame_resources): Declare.
426
f7dfe5d6
JD
427 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
428 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
429
430 * nsterm.h (ns_get_defaults_value): Declare.
431
432 * nsterm.m (ns_default): Call ns_get_defaults_value.
433
7cd4e72c
EZ
4342011-12-09 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
437 (Bug#10170)
438
b34d7317
YM
4392011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
440
441 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
442 that where the value of an _OBJC_* symbol points to is in the .bss
443 section (Bug#10240).
444
76470ad1
KH
4452011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
446
447 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 448 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 449
745fff94
KH
4502011-12-08 Kenichi Handa <handa@m17n.org>
451
452 * ftfont.c (get_adstyle_property): Fix previous change
453 (Bug#10233).
454
6e44397c
JB
4552011-12-07 Juanma Barranquero <lekktu@gmail.com>
456
457 * w32.c (init_environment): If no_site_lisp, remove site-lisp
458 dirs from the default value of EMACSLOADPATH (bug#10208).
459
7efa6272
GM
4602011-12-07 Glenn Morris <rgm@gnu.org>
461
462 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
463 installation and source directories as well. (Bug#10208)
464
f6fc4d87
CY
4652011-12-06 Chong Yidong <cyd@gnu.org>
466
467 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
468
2bf26180
GM
4692011-12-06 Glenn Morris <rgm@gnu.org>
470
471 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
472 as an error, not just -1. (Bug#10217)
473
3a6ad4f0
CY
4742011-12-05 Chong Yidong <cyd@gnu.org>
475
476 * keyboard.c (process_special_events): New function.
477 (swallow_events, Finput_pending_p): Use it (Bug#10195).
478
75a3b399
PE
4792011-12-05 Paul Eggert <eggert@cs.ucla.edu>
480
481 * coding.c (encode_designation_at_bol): Don't use uninitialized
482 local variable (Bug#9318).
483
c3c9e25e
KH
4842011-12-05 Kenichi Handa <handa@m17n.org>
485
486 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
487 return Qnil (Bug#8046, Bug#10193).
488
5eb05ea3
KH
4892011-12-05 Kenichi Handa <handa@m17n.org>
490
491 * coding.c (encode_designation_at_bol): New args charbuf_end and
492 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
493 (coding_set_source): Return how many bytes coding->source was
494 relocated.
495 (coding_set_destination): Return how many bytes
496 coding->destination was relocated.
497 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
498 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
499
5002011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
501
502 * coding.c (CODING_CHAR_CHARSET_P): New macro.
503 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
504 macro (Bug#9318).
505
5062011-12-05 Andreas Schwab <schwab@linux-m68k.org>
507
508 The following changes are to fix Bug#9318.
509
a79703f5 510 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
511 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
512 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 513 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 514
7dbda6df
JB
5152011-12-05 Juanma Barranquero <lekktu@gmail.com>
516
517 * lisp.h (process_quit_flag): Fix external declaration.
518
6d5eb5b0
SM
5192011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
520
521 Don't macro-inline non-performance-critical code.
522 * eval.c (process_quit_flag): New function.
523 * lisp.h (QUIT): Use it.
524
a0c3fad0
JD
5252011-12-04 Jan Djärv <jan.h.d@swipnet.se>
526
527 * nsfns.m (get_geometry_from_preferences): New function.
528 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
529
6c07aac2
AS
5302011-12-04 Andreas Schwab <schwab@linux-m68k.org>
531
532 * emacs.c (Qkill_emacs): Define.
533 (syms_of_emacs): Initialize it.
534 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
535 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
536 (quit_throw_to_read_char): Add parameter `from_signal'.
537 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
538 * lisp.h (QUIT): Call Fkill_emacs if requested.
539
c052ead4
JD
5402011-12-03 Jan Djärv <jan.h.d@swipnet.se>
541
542 * widget.c (update_wm_hints): Return if wmshell is null.
543 (widget_update_wm_size_hints): New function.
544
545 * widget.h (widget_update_wm_size_hints): Declare.
546
547 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
548 widget_update_wm_size_hints (Bug#10104).
549
9e49252b
EZ
5502011-12-03 Eli Zaretskii <eliz@gnu.org>
551
552 * xdisp.c (handle_invisible_prop): If the invisible text ends just
553 before a newline, prepare the bidi iterator for consuming the
554 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 555 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 556
02b16839
JL
5572011-12-02 Juri Linkov <juri@jurta.org>
558
559 * search.c (Fword_search_regexp): New Lisp function created from
560 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
561 (Fword_search_backward, Fword_search_forward)
562 (Fword_search_backward_lax, Fword_search_forward_lax):
563 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
564 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
565
0068070e
SM
5662011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
567
568 * fileio.c (Finsert_file_contents): Move after-change-function call
569 to before the "handled:" label, since all "goto handled" appear in
570 cases where the *-change-functions have already been properly called
571 (bug#10117).
572
3360a3fc
AS
5732011-12-01 Andreas Schwab <schwab@linux-m68k.org>
574
575 * keyboard.c (interrupt_signal): Don't call kill-emacs when
576 waiting for input. (Bug#10169)
577
73d6c093
EZ
5782011-11-30 Eli Zaretskii <eliz@gnu.org>
579
580 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
581 verifies glyph row's hash code--we have just reallocated the
582 glyphs, so their contents can be complete garbage. (Bug#10164)
583
febe6bea
JB
5842011-11-30 Juanma Barranquero <lekktu@gmail.com>
585
586 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
587
801a4313
EZ
5882011-11-30 Eli Zaretskii <eliz@gnu.org>
589
590 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
591 attributes are tested _before_ calling verify_row_hash, to protect
592 against GCC re-ordering of the tests. (Bug#10164)
593
2b56b87e
JD
5942011-11-29 Jan Djärv <jan.h.d@swipnet.se>
595
596 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
597
598 * xterm.c (handle_one_xevent): Only set async_visible and friends
599 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 600 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
601 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
602
dbf31225
PE
6032011-11-28 Paul Eggert <eggert@cs.ucla.edu>
604
605 Remove GCPRO-related macros that exist only to avoid shadowing locals.
606 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
607 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
608 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
609 All uses changed to use GCPRO1 etc.
610 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
611 Revert to old implementation (i.e., before 2011-03-11).
612
1305621b
YM
6132011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
614
615 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
616 of scroll runs so as to avoid assigning disabled bogus rows and
617 unnecessary graphics copy operations.
618
8c9afb46
EZ
6192011-11-27 Eli Zaretskii <eliz@gnu.org>
620
621 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
622 (snprintf) [_MSC_VER]: Redirect to _snprintf.
623 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
624 (malloc, free, realloc, calloc): Redirect to e_* only when
625 compiling Emacs.
626
627 * lisp.h (GCTYPEBITS): Move before first use.
628 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
629 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
630 this macro definition.
631
632 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
633 _MSC_VER.
634
54e9e3bf
JD
6352011-11-27 Jan Djärv <jan.h.d@swipnet.se>
636
6d5eb5b0
SM
637 * gtkutil.c (xg_create_frame_widgets):
638 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
639 present with Gtk+ 2.0.
640
83aca1cb
PE
6412011-11-26 Paul Eggert <eggert@cs.ucla.edu>
642
643 * fileio.c (Finsert_file_contents): Undo previous change; see
644 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
645
5b76caa4
PE
6462011-11-26 Paul Eggert <eggert@cs.ucla.edu>
647
648 Rename locals to avoid shadowing.
649 * fileio.c (Finsert_file_contents):
650 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
651 * process.c (wait_reading_process_output):
652 Rename inner 'proc' to 'p' to avoid shadowing.
653 Indent for consistency with usual Emacs style.
654
8c535114
EZ
6552011-11-25 Eli Zaretskii <eliz@gnu.org>
656
657 * xdisp.c (redisplay_window): If cursor row is not fully visible
658 after recentering, and scroll-conservatively is set to a large
659 number, scroll window by a few more lines to make the cursor fully
660 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
661 (start_display): Don't move to the next line if the display should
662 start at a newline that is part of a display vector or an overlay
663 string. (Bug#10119)
8c535114 664
fa4fdb5c
JL
6652011-11-24 Juri Linkov <juri@jurta.org>
666
667 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
668 after the `MagickPingImage' call. (Bug#10112)
669
90ec88df
CY
6702011-11-23 Chong Yidong <cyd@gnu.org>
671
672 * window.c (Fcoordinates_in_window_p): Accept only live windows.
673
56e2e794
MR
6742011-11-23 Martin Rudalics <rudalics@gmx.at>
675
676 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
677 making another buffer current. (Bug#10114)
678
b6e64c41
GM
6792011-11-23 Glenn Morris <rgm@gnu.org>
680
681 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
682
6b21de18
CY
6832011-11-23 Chong Yidong <cyd@gnu.org>
684
685 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
686 using it (Bug#5984).
687
b12cd789
EZ
6882011-11-22 Eli Zaretskii <eliz@gnu.org>
689
690 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
691 and header-lines, as they don't have one computed for them.
692 (Bug#10098)
693
694 * .gdbinit (prow): Make displayed values more self-explaining.
695 Add row's hash code.
696
261b6fd4
LMI
6972011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
698
699 * process.c (wait_reading_process_output): Fix asynchrounous
700 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 701 (wait_reading_process_output): Add comment and URL.
261b6fd4 702
e7cfd277
JD
7032011-11-21 Jan Djärv <jan.h.d@swipnet.se>
704
705 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
706
a9b9b7f5
CY
7072011-11-21 Chong Yidong <cyd@gnu.org>
708
709 * window.c (Fnext_window, Fprevious_window): Doc fix.
710
b0d15b4f
SM
7112011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
712
713 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
714
fe7a3057
JB
7152011-11-20 Juanma Barranquero <lekktu@gmail.com>
716
717 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
718
d2999b1a
MR
7192011-11-20 Martin Rudalics <rudalics@gmx.at>
720
721 * window.c (Fset_window_combination_limit): Rename argument
722 STATUS to LIMIT.
723 (Vwindow_combination_limit): Remove "status" from doc-string.
724
d5ff9cd0
AS
7252011-11-20 Andreas Schwab <schwab@linux-m68k.org>
726
727 * m/ibms390.h: Remove.
728 * m/ibms390x.h: Don't include "ibms390.h".
729
a5bb9bd3
SM
7302011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
731
732 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
733 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
734
cd1181db
JB
7352011-11-20 Juanma Barranquero <lekktu@gmail.com>
736
737 * casetab.c (Fset_case_table):
738 * charset.c (Fcharset_after): Fix typos.
739
615a3b8d 7402011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 741
17e845af
PE
742 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
743 Otherwise, valgrind does not work on some platforms.
744 Problem reported by Andreas Schwab in
6a0bf43d
PE
745 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
746 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
747 is set, removing the need for VIRT_ADDRESS_VARIES.
748 (PURE_P): Use a more-efficient implementation that needs just one
749 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
750 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
751 to 4 (xorl, subq, cmpq, setbe).
752 * alloc.c (pure): Always extern now, since that's the
753 VIRT_ADDR_VARIES behavior.
754 (PURE_POINTER_P): Use a single comparison, not two, for
755 consistency with the new puresize.h.
756 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
757 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
758 Remove VIRT_ADDR_VARIES no longer needed.
759
f8fe6f96
EZ
7602011-11-19 Eli Zaretskii <eliz@gnu.org>
761
762 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
763 (erase_phys_cursor, update_window_cursor, show_mouse_face)
764 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
765 behave as if the cursor position were at the window margin.
766
767 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
768 and the cursor position is out of bounds, behave as if the cursor
769 position were at the window margin. (Bug#10075)
770
df05a53c
CY
7712011-11-18 Chong Yidong <cyd@gnu.org>
772
773 * window.c (Fwindow_combination_limit): Make first argument
774 non-optional, since it is meaningless for live windows like the
775 selected window.
776
2071918e
DA
7772011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
778
779 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
780
b50a28de
SM
7812011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
782
783 * intervals.c: Fix grafting over the whole buffer (bug#10071).
784 (graft_intervals_into_buffer): Simplify.
785
015137db
EZ
7862011-11-18 Eli Zaretskii <eliz@gnu.org>
787
788 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
789 hash values of the two rows.
790 (copy_row_except_pointers): Preserve the used[] arrays and the
791 hash values of the two rows. (Bug#10035)
68c95424 792 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
793
794 * xdisp.c (row_hash): New function, body extracted from
795 compute_line_metrics.
796 (compute_line_metrics): Call row_hash, instead of computing the
797 hash code inline.
798
799 * dispnew.c (verify_row_hash): Call row_hash for computing the
800 hash code of a row, instead of duplicating code from xdisp.c.
801
802 * dispextern.h (row_hash): Add prototype.
803
a2addb04
TH
8042011-11-18 Tassilo Horn <tassilo@member.fsf.org>
805
806 * frame.c (delete_frame): Don't delete the terminal when the last
807 X frame is closed if emacs is built with GTK toolkit.
808
df85d315
JB
8092011-11-17 Juanma Barranquero <lekktu@gmail.com>
810
811 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
812
a0c2d0ae
MR
8132011-11-17 Martin Rudalics <rudalics@gmx.at>
814
815 * window.c (Vwindow_splits): Rename to
816 Vwindow_combination_resize. Suggested by Juri Linkov.
817 (Fsplit_window_internal): Use Vwindow_combination_resize instead
818 of Vwindow_splits.
819
58179cce
JB
8202011-11-16 Juanma Barranquero <lekktu@gmail.com>
821
7877f373
JB
822 * nsfns.m (Fns_font_name):
823 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 824
b6f67890
MR
8252011-11-16 Martin Rudalics <rudalics@gmx.at>
826
827 * window.h (window): Rename slot "nest" to "combination_limit".
828 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
829 (Fset_window_nest): Rename to Fset_window_combination_limit.
830 (Vwindow_nest): Rename to Vwindow_combination_limit.
831 (recombine_windows, make_parent_window, make_window)
832 (Fsplit_window_internal, saved_window)
833 (Fset_window_configuration, save_window_save): Rename all
834 occurrences of window_nest to window_combination_limit.
835
c7015153
JB
8362011-11-15 Juanma Barranquero <lekktu@gmail.com>
837
838 * image.c (imagemagick_load_image): Fix typo.
839
322ad6ec
EZ
8402011-11-14 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (display_line): Move the call to
843 highlight_trailing_whitespace before the call to
844 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
845 faces of all the glyphs to compute ROW's hash value.
846 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 847
f067b8ec
JB
8482011-11-14 Juanma Barranquero <lekktu@gmail.com>
849
850 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
851 just return (bug#10044).
852
1e5b2111
EZ
8532011-11-12 Eli Zaretskii <eliz@gnu.org>
854
7ef3cbd5
EZ
855 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
856 with user-defined heap size. Bump the default size of the temacs
857 heap to 27MB, to avoid memory warning when running temacs.
858 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
859
1e5b2111
EZ
860 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
861 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
862 (verify_row_hash) [XASSERTS]: New function.
863 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
864 that the hash value of glyph rows is correct.
1e5b2111 865
89d61221
MR
8662011-11-12 Martin Rudalics <rudalics@gmx.at>
867
868 * window.h (window): Remove splits slot.
869 * window.c (Fwindow_splits, Fset_window_splits): Remove.
870 (Fdelete_other_windows_internal, make_parent_window)
871 (make_window, Fsplit_window_internal, Fdelete_window_internal)
872 (Fset_window_configuration, save_window_save): Don't deal with
873 split status of windows.
874 (saved_window): Remove splits slot.
875 (Vwindow_splits): Rewrite doc-string.
876
97f18cc8
JD
8772011-11-11 Jan Djärv <jan.h.d@swipnet.se>
878
879 * xfns.c (unwind_create_frame):
880 * nsfns.m (unwind_create_frame):
881 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
882 Vframe_list (Bug#9999).
883
22a648b4
DA
8842011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
885
0b381c7e 886 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 887
659afede
KH
8882011-11-11 Kenichi Handa <handa@m17n.org>
889
890 * callproc.c (Fcall_process): Set the member dst_multibyte of
891 process_coding.
892
9ac0394b
KH
8932011-11-11 Johan Bockgård <bojohan@gnu.org>
894
895 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
896 avoid a crash (bug#9496).
897
2fbdc249
CY
8982011-11-09 Chong Yidong <cyd@gnu.org>
899
900 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
901 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
902
ac6b1f81
PE
9032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
904
905 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
906
09db192c
PE
9072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
908
909 Avoid some portability problems by eschewing 'extern inline' functions.
910 The trivial performance wins aren't worth the portability hassles; see
911 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
912 et seq.
913 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
914 (window_box_width, window_box_left, window_box_left_offset)
915 (window_box_right, window_box_right_offset): Undo previous change,
916 by removing the "extern"s.
917 * intervals.c (adjust_intervals_for_insertion)
918 (adjust_intervals_for_deletion): Undo previous change,
919 making these static again.
920 (offset_intervals, temp_set_point_both, temp_set_point)
921 (copy_intervals_to_string): No longer inline.
922 * xdisp.c (window_text_bottom_y, window_box_width)
923 (window_box_height, window_box_left_offset)
924 (window_box_right_offset, window_box_left, window_box_right)
925 (window_box): No longer inline.
926
105216ed
CY
9272011-11-08 Chong Yidong <cyd@gnu.org>
928
929 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
930 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
931 Signal an error if not a live window.
105216ed
CY
932 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
933 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
934
ae9e237f
JB
9352011-11-07 Juanma Barranquero <lekktu@gmail.com>
936
937 * lisp.h (syms_of_abbrev): Remove declaration.
938 Reported by CHENG Gao <chenggao@royau.me>.
939
c7aa8333
EZ
9402011-11-07 Eli Zaretskii <eliz@gnu.org>
941
942 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
943 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
944 of temacs in GUI mode.
945
be7f5545
MR
9462011-11-07 Martin Rudalics <rudalics@gmx.at>
947
948 * window.h: Declare delete_all_child_windows instead of
949 delete_all_subwindows.
950 * window.c (Fwindow_nest, Fset_window_nest)
951 (Fset_window_new_total, Fset_window_new_normal)
952 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
953 (delete_all_subwindows): Rename to delete_all_child_windows.
954 (Fdelete_other_windows_internal, Fset_window_configuration):
955 Call delete_all_child_windows instead of delete_all_subwindows.
956 * frame.c (delete_frame): Call delete_all_child_windows instead
957 of delete_all_subwindows.
958
ca78dc43
PE
9592011-11-07 Paul Eggert <eggert@cs.ucla.edu>
960
961 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
962 This is also needed for porting to any host where GC_MARK_STACK is
963 not GC_MAKE_GCPROS_NOOPS.
964 (which_symbols): Use it.
965
a0241d01
KH
9662011-11-07 Kenichi Handa <handa@m17n.org>
967
968 * coding.c (coding_set_destination): Check coding->src_pos only
969 when coding->src_object is a buffer (bug#9910).
970
971 * process.c (send_process): Set the member src_multibyte of coding
972 to 0 (bug#9911) when sending a unibyte text.
973
974 * callproc.c (Fcall_process): Set the member src_multibyte of
975 process_coding to 0 (bug#9912).
976
a64bfdfa 9772011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
978
979 * xmenu.c (cleanup_widget_value_tree): New function.
980 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
981 calling free_menubar_widget_value_tree directly (Bug#9830).
982
cb41b32a
PE
9832011-11-06 Paul Eggert <eggert@cs.ucla.edu>
984
985 Fix some portability problems with 'inline'.
986 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
987 (window_box_width, window_box_left, window_box_left_offset)
988 (window_box_right, window_box_right_offset): Declare extern.
989 Otherwise, these inline functions do not conform to C99 and
990 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
991 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
992 * intervals.c (adjust_intervals_for_insertion)
993 (adjust_intervals_for_deletion): Now extern, because otherwise the
994 extern inline functions 'offset_intervals' couldn't refer to it.
995 (static_offset_intervals): Remove.
996 (offset_intervals): Rewrite using the old contents of
997 static_offset_intervals. The old version didn't conform to C99
998 because an extern inline function contained a reference to an
999 identifier with static linkage.
1000
b7041366
AS
10012011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1002
1003 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1004 GC.
1005
88a37c4d
EZ
10062011-11-06 Eli Zaretskii <eliz@gnu.org>
1007
1008 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1009 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1010 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1011 return Qleft_to_right.
1012
49745b39
CY
10132011-11-06 Chong Yidong <cyd@gnu.org>
1014
1015 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1016 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1017 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1018 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1019 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1020 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1021 (Fwindow_vscroll): Doc fix.
1022 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1023 argument, since it makes no sense to pass a live window and for
1024 consistency with window-child.
1025
1f05cd82
CS
10262011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1027
1028 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1029 support MSVC.
1030
22610910
JR
10312011-11-05 Jason Rumney <jasonr@gnu.org>
1032
1033 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1034 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1035 fonts (Bug#6029).
1036 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1037 bitwise arithmetic preventing use of unicode-sip and non-truetype
1038 opentype fonts.
1039
a06776b2
EZ
10402011-11-05 Eli Zaretskii <eliz@gnu.org>
1041
3ad924ba
EZ
1042 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1043 "emacs"-only part.
1044
a06776b2
EZ
1045 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1046 initialization code to keep similarity to xfns.c after changes
1047 from 2011-11-05.
1048
c9e7db78
JD
10492011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1050
a97f8f3f
JD
1051 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1052 (unwind_create_frame): New function (Bug#9943).
1053 (Fx_create_frame): Restructure code to be more similar to the one in
1054 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1055 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1056 Move terminal->reference_count++ just before making the frame official
1057 (Bug#9943).
1058
1059 * nsterm.m (x_free_frame_resources): New function.
1060 (x_destroy_window): Move code to x_free_frame_resources.
1061
c9e7db78 1062 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1063 (Fx_create_frame, x_create_tip_frame):
1064 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1065 official. Move initialization of image_cache_refcount and
1066 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1067
a6fc3b5c
EZ
10682011-11-05 Eli Zaretskii <eliz@gnu.org>
1069
1070 Support MSVC build with newer versions of Visual Studio.
1071 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1072 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1073 nt/gmake.defs.
1074
1075 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1076 which are not supported by MSVC.
1077 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1078 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1079 bitfields.
1080 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1081 types in bitfields.
1082 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1083
1084 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1085
58179cce 10862011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1087
1088 Support MSVC build with newer versions of Visual Studio.
1089 * w32.c: Don't include w32api.h for MSVC.
1090 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1091
1092 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1093 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1094 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1095 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1096 e_* cousins.
1097 (alloca) [_MSC_VER]: Define to _alloca.
1098
1099 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1100
1101 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1102
a58c13ed
EZ
11032011-11-04 Eli Zaretskii <eliz@gnu.org>
1104
1105 * xdisp.c (note_mouse_highlight): If either of
1106 previous/next-single-property-change returns nil, treat that as
1107 the beginning or the end of the buffer. (Bug#9955)
1108
fe0b6370
JD
11092011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1110
a58c13ed 1111 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1112 label is not null (Bug#9951).
1113 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1114 may be NULL.
1115
89bd5ee1
EZ
11162011-11-04 Eli Zaretskii <eliz@gnu.org>
1117
1118 * window.c (Fwindow_body_size): Mention in the doc string that the
1119 return value is in frame's canonical units. (Bug#9949)
1120
84c3edb9
EZ
11212011-11-03 Eli Zaretskii <eliz@gnu.org>
1122
4e2fb5c7
EZ
1123 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1124
84c3edb9 1125 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1126 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1127 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1128
bc17a887
EZ
11292011-11-01 Eli Zaretskii <eliz@gnu.org>
1130
1131 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1132 Don't stop backward scan on the continuation glyph, even though
1133 its CHARPOS is positive.
6d5eb5b0
SM
1134 (mouse_face_from_buffer_pos, note_mouse_highlight):
1135 Rename cover_string to disp_string.
bc17a887 1136
4ee88440
MR
11372011-11-01 Martin Rudalics <rudalics@gmx.at>
1138
1139 * window.c (temp_output_buffer_show): Don't use
1140 Vtemp_buffer_show_specifiers.
1141 (Vtemp_buffer_show_specifiers): Remove unused variable.
1142
c2ff3c02
EZ
11432011-10-30 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1146 past the beginning of the current glyph matrix.
1147
58179cce 11482011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1149
1150 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1151 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1152 HAVE_GTK3 (Bug#9869).
b77a6a7f 1153
3b574623
JD
1154 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1155 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1156
b77a6a7f
JD
1157 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1158
1159 * xterm.c: Declare x_handle_net_wm_state to return int.
1160 (handle_one_xevent): Check if we are iconified but don't have
1161 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1162 (get_current_wm_state): Return non-zero if not hidden,
1163 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1164 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1165 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1166 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1167
196e41e4
PE
11682011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1171 so that this new function doesn't get optimized away by a
1172 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1173
021f2e1a
AS
11742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1175
1176 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1177
8b058d44
EZ
11782011-10-29 Eli Zaretskii <eliz@gnu.org>
1179
1180 Fix the `xbytecode' command.
1181 * .gdbinit (xprintbytestr): New command.
b50a28de 1182 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1183 (xbytecode): Print the byte-code string as well.
1184
4452fb80
EZ
11852011-10-29 Kim Storm <storm@cua.dk>
1186
8b058d44
EZ
1187 * alloc.c (which_symbols): New function.
1188
21b72067
AS
11892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1190
1191 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1192 line. (Bug#9903)
1193
83ed7b5c
GM
11942011-10-29 Glenn Morris <rgm@gnu.org>
1195
1196 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1197 Not clear what it was for, and it causes various bugs. (Bug#9839)
1198
5a7a728b
EZ
11992011-10-28 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1202 possible random value that matches one of those tested as
1203 condition to clear the mouse face.
1204
d3d0842f
CY
12052011-10-28 Chong Yidong <cyd@gnu.org>
1206
1207 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1208
31b39d13
DN
12092011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1210
1211 * window.c (make_window): Initialize phys_cursor_on_p.
1212
9aba6043
SM
12132011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1214
1215 * lisp.h (struct Lisp_Symbol): Update comments.
1216
c20992f4
JB
12172011-10-28 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1220
db4f02f2
EZ
12212011-10-28 Eli Zaretskii <eliz@gnu.org>
1222
1223 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1224 <oslsachem@gmail.com> for helping to debug this.
1225
1226 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1227 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1228 (g_b_init_get_glyph_outline_w): New static variables.
1229 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1230 (GetGlyphOutlineW_Proc): New typedefs.
1231 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1232 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1233 New functions.
1234 (w32font_open_internal, compute_metrics):
1235 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1236 instead of calling the "wide" APIs directly.
1237
1238 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1239
1240 * w32.h (syms_of_w32font): Add prototype.
1241
87e68db4
JB
12422011-10-27 Juanma Barranquero <lekktu@gmail.com>
1243
1244 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1245 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1246 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1247 (Fmove_to_window_line): Doc fix.
1248
435c1d67
CY
12492011-10-27 Chong Yidong <cyd@gnu.org>
1250
1251 * process.c (make_process): Set gnutls_state to NULL.
1252
1253 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1254 non-NULL, regardless of GNUTLS_INITSTAGE.
1255 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1256 an error. Set process slots as soon as we allocate them.
1257
1258 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1259
9c6c6f49
CY
12602011-10-27 Chong Yidong <cyd@gnu.org>
1261
9aba6043
SM
1262 * gnutls.c (emacs_gnutls_deinit): New function.
1263 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1264 (Fgnutls_deinit, Fgnutls_boot): Use it.
1265
1266 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1267 (deactivate_process): Call emacs_gnutls_deinit.
1268
657d08d3
JB
12692011-10-27 Juanma Barranquero <lekktu@gmail.com>
1270
1271 * image.c (x_create_x_image_and_pixmap):
1272 * w32.c (sys_rename, w32_delayed_load):
1273 * w32font.c (fill_in_logfont):
1274 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1275
5430d399
JB
12762011-10-26 Juanma Barranquero <lekktu@gmail.com>
1277
1278 * w32fns.c (w32_default_color_map): New function,
1279 extracted from Fw32_default_color_map.
a7ef684b 1280 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1281
fe0055fa
PE
12822011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1285
e6346438
SM
12862011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1287
1288 * keyboard.c (test_undefined): New function (bug#9751).
1289 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1290
e112cc37
ET
12912011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1292
1293 * sysdep.c (init_sys_modes): Fix the check for the controlling
1294 terminal (Bug#6649).
1295
7b5d6677
EZ
12962011-10-20 Eli Zaretskii <eliz@gnu.org>
1297
1298 * dispextern.h (struct bidi_it): New member next_en_type.
1299
1300 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1301 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1302 current character, check also for next_en_type being WEAK_EN.
1303 (bidi_resolve_weak): Don't enter the expensive loop if the current
1304 position is before next_en_pos. Record the bidi type of the first
1305 non-ET, non-BN character we find, in addition to its position.
1306 (bidi_level_of_next_char): Invalidate next_en_type when
1307 next_en_pos is over-stepped.
1308
7da0b018
PE
13092011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1310
1311 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1312 * editfns.c: Rewrite current-time-zone so that it invokes
1313 the equivalent of (format-time-string "%Z") to get the time zone name.
1314 This fixes a bug when the time zone name contains characters that
1315 need converting from the system time locale to Emacs internal format.
1316 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1317 that patch fixed format-time-string to do the conversion, but
1318 I forgot to fix current-time-zone.
1319 (format_time_string): New function, containing most of
1320 what Fformat_time_string used to contain.
1321 (Fformat_time_string): Rewrite in terms of format_time_string.
1322 This doesn't change this function's behavior.
1323 (current-time-zone): Rewrite to use format_time_string.
1324 This fixes the bug reported by Michael Schierl in
1325 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1326 Jason Rumney's 2007-06-07 change worked around this bug, but
1327 didn't fix it.
1328 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1329
8547b010
EZ
13302011-10-19 Eli Zaretskii <eliz@gnu.org>
1331
1332 * xdisp.c (start_display): If the character at POS is displayed
1333 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1334 (try_window_reusing_current_matrix): If a line ends in a display
1335 vector or the next line starts in a display vector, continue
1336 redrawing the window even though the character position of
1337 start_row was reached.
8547b010
EZ
1338 (Bug#9771, part 2)
1339
4e948d15
CY
13402011-10-18 Chong Yidong <cyd@gnu.org>
1341
1342 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1343 with nobreak-char-display too.
1344
4787455f
EZ
13452011-10-18 Eli Zaretskii <eliz@gnu.org>
1346
1347 Fix part 3 of bug#9771.
1348 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1349 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1350 non-neutral characters if the current character is a paragraph
1351 separator (a.k.a. Newline). This avoids running the same
1352 expensive loop twice, once when we consume the preceding newline
1353 and the other time when the line actually needs to be displayed.
1354 Avoid the loop when we see neutrals on the base embedding level
1355 following a character whose directionality is the same as the
1356 paragraph's. This avoids running the expensive loop when a line
1357 ends in a long sequence of neutrals, like control characters.
1358 Add assertion against STRONG_AL type. Slightly rearrange code
1359 that determines the type of a neutral given the first non-neutral
1360 that follows it.
1361 (bidi_level_of_next_char): Set next_en_pos to zero when
1362 invalidating its info.
1363
2c91f553
EZ
13642011-10-17 Eli Zaretskii <eliz@gnu.org>
1365
1366 * xdisp.c (push_display_prop): Determine whether to record string
1367 or buffer position by IT->string, not by IT->method. Allow
1368 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1369 (move_it_vertically_backward): Don't look for character position
1370 immediately after the newline when in a continuation line.
1371 (Bug#9771, part 1)
2c91f553 1372
c7b08b0d
MR
13732011-10-15 Martin Rudalics <rudalics@gmx.at>
1374
1375 * window.c (coordinates_in_window): Rewrite and delabelize
1376 vertical border check. (Bug#5357) (Bug#9618)
1377
6b02f655
SM
13782011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1379
1380 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1381 errors in XSetWindowBorder (bug#9310).
1382
81d40c92
DA
13832011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1384
1385 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1386 avoid crash when xmalloc overrun checking is enabled.
1387
d4172c3b
EZ
13882011-10-13 Eli Zaretskii <eliz@gnu.org>
1389
1390 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1391 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1392 cursor motion with <left> and <right> arrow keys.
1393
1394 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1395 some callers set that themselves.
1396
b00eea75
EZ
13972011-10-12 Eli Zaretskii <eliz@gnu.org>
1398
1399 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1400 display string and the previous row comes from the same string and
1401 is empty. (Bug#9739) (Bug#9738)
1402
8fe012c4
SM
14032011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1404
1405 * doc.c (get_doc_string): Encode file name (bug#9735).
1406
0074aef2
EZ
14072011-10-12 Eli Zaretskii <eliz@gnu.org>
1408
79beb178
EZ
1409 * bidi.c (bidi_level_of_next_char):
1410 * xdisp.c (get_visually_first_element): Remove old incorrect
1411 comments regarding the Unicode Line Separator character.
1412
0074aef2
EZ
1413 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1414
6e4b3fbe
DA
14152011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1416
1417 * alloc.c (Fgc_status): Do not access beyond zombies array
1418 boundary if nzombies > MAX_ZOMBIES.
1419 * alloc.c (dump_zombies): Add missing format specifier.
1420
0324f3af
PE
14212011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1422
b5525cac
PE
1423 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1424 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1425
0324f3af
PE
1426 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1427 Some packages use them to denote characters with modifiers.
1428
e9b5f888
AS
14292011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1430
1431 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1432 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1433 matching a pp-number. Rename parameter var to var1.
1434
127827c0
SM
14352011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1436
1437 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1438
c8fd3bd0
GM
14392011-10-08 Glenn Morris <rgm@gnu.org>
1440
1441 * callint.c (Fcall_interactively): Give a more explicit error for the
1442 'c' case with a non-character input. (Bug#8479)
1443
352ec8ff
EZ
14442011-10-08 Eli Zaretskii <eliz@gnu.org>
1445
03669ccb
EZ
1446 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1447 lines.
7061c986
EZ
1448 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1449 lines that are hscrolled on the left.
03669ccb 1450
352ec8ff
EZ
1451 * dispnew.c (buffer_posn_from_coords): Account for a possible
1452 presence of header-line. (Bug#4426)
1453
a66cfb1c
SM
14542011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1455
6b02f655
SM
1456 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1457 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1458
7c5ee88e
PE
14592011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1462 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1463 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1464 this makes Emacs dump core during garbage collection on rare
1465 occasions. sizeof is obviously inferior to offsetof here, so
1466 stick with offsetof.
1467 (GC_POINTER_ALIGNMENT): New macro.
1468 (mark_memory): Omit 3rd (offset) arg; caller changed.
1469 Don't assume EMACS_INT alignment is the same as pointer alignment.
1470
df1bbe5b
SM
14712011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1472
1473 * keyboard.c (read_key_sequence_remapped): New var.
1474 (read_key_sequence): Compute remapping in the right buffer.
1475 (command_loop_1): Use read_key_sequence's remapping directly.
1476
51553db6
SM
14772011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1478
32c1fffd
SM
1479 * dired.c (file_name_completion): Don't expand file name.
1480 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1481 before checking file name handler.
1482
51553db6
SM
1483 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1484 they've been requested explicitly (bug#9591).
1485
b6bd1599 14862011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1487
1488 * keymap.c (Fsingle_key_description): Use make_specified_string
1489 instead of build_string to build string from push_key_description.
1490 (Bug#5193)
1491
f701dc2a
PE
14922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1493
4222c55d
PE
1494 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1495 This fixes a Y2038 bug on 64-bit hosts.
1496 * buffer.c (reset_buffer):
1497 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1498 (Fclear_buffer_auto_save_failure):
1499 Use 0, not -1, to represent an unset failure time, since time_t
1500 might not be signed.
1501
f701dc2a
PE
1502 Remove dependency on glibc malloc internals.
1503 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1504 Move back here from lisp.h, but with their new implementations.
1505 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1506 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1507 * charset.c (charset_table_init): New static var.
1508 (syms_of_charset): Use it instead of xmalloc. This removes a
1509 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1510 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1511 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1512 Move back to alloc.c.
1513 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1514 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1515
9ceebf39
JD
15162011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1517
1518 * nsterm.m (windowDidResize): Call x_set_window_size only when
1519 ns_in_resize is true. Otherwise set pixelwidth/height and
1520 call change_frame_size (Bug#9628).
1521
cb993c58
PE
15222011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1523
3930c88b
PE
1524 Port --enable-checking=all to Fedora 14 x86-64.
1525 * charset.c (syms_of_charset): Also account for glibc malloc's
1526 internal overhead when calculating the initial malloc maximum.
1527
cb993c58
PE
1528 Port --enable-checking=all to Fedora 14 x86.
1529 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1530 Move to lisp.h.
1531 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1532 (overrun_check_realloc, overrun_check_free):
1533 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1534 That way, xmalloc returns a properly-aligned pointer even if
1535 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1536 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1537 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1538 into account when calculating the initial malloc maximum.
1539 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1540 Move here from alloc.c, so that charset.c can use it too.
1541 Properly align; the old code wasn't right for common 32-bit hosts
1542 when configured with --enable-checking=all.
1543 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1544 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1545
31bed486
EZ
15462011-09-29 Eli Zaretskii <eliz@gnu.org>
1547
04c70788 1548 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1549 use EDOM.
1550
fbcaa2f3
EZ
15512011-09-28 Eli Zaretskii <eliz@gnu.org>
1552
1553 * xdisp.c (compute_display_string_end): If there's no display
1554 string at CHARPOS, return -1.
1555
1556 * bidi.c (bidi_fetch_char): When compute_display_string_end
1557 returns a negative value, treat the character as a normal
1558 character not covered by a display string. (Bug#9624)
1559
a239d4e9
JB
15602011-09-28 Juanma Barranquero <lekktu@gmail.com>
1561
1562 * lread.c (Fread_from_string): Fix typo in docstring.
1563
88652fd5
EZ
15642011-09-27 Eli Zaretskii <eliz@gnu.org>
1565
1566 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1567 newline, reseat the iterator instead of bidi-iterating there one
1568 character at a time. (Bug#9610)
32c1fffd
SM
1569 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1570 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1571
ed497dd4
AS
15722011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1573
1574 * lread.c (readevalloop): Use correct code for NBSP.
1575 (read1): Likewise. (Bug#9608)
1576
b2bf61aa
MA
15772011-09-25 Michael Albinus <michael.albinus@gmx.de>
1578
1579 * dbusbind.c (Fdbus_register_signal): When service is not
1580 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1581
32bbb17c
GM
15822011-09-25 Glenn Morris <rgm@gnu.org>
1583
1584 * buffer.c (truncate-lines): Doc fix.
1585
94e0933e
CY
15862011-09-24 Chong Yidong <cyd@stupidchicken.com>
1587
1588 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1589 (Fset_window_next_buffers): Doc fix.
1590
cddde921
GM
15912011-09-24 Glenn Morris <rgm@gnu.org>
1592
1593 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1594
1260aef1
PE
15952011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1596
25b4bfa0
PE
1597 Fix minor problems found by static checking.
1598 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1599 * indent.c (Fvertical_motion): Fix == vs = typo.
1600
e3cbd34b
EZ
16012011-09-24 Eli Zaretskii <eliz@gnu.org>
1602
a66cfb1c
SM
1603 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1604 Default value is now t. Doc fix.
6bf7006f 1605
e3cbd34b 1606 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1607 logic when moving up, not only when moving down. Fix the
e3cbd34b 1608 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1609 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1610
1611 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1612 CHARPOS is covered by a display string which includes newlines.
1613 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1614 is covered by a display string with embedded newlines.
1615
a3de0cbd
MA
16162011-09-24 Michael Albinus <michael.albinus@gmx.de>
1617
1618 * dbusbind.c (Fdbus_register_signal): Add match rule to
1619 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1620 (Fdbus_register_method, Vdbus_registered_objects_table):
1621 Fix docstring.
a3de0cbd 1622
b260039d
JM
16232011-09-24 Jim Meyering <meyering@redhat.com>
1624
32c1fffd 1625 do not ignore write error for any output size
b260039d
JM
1626 The previous change was incomplete.
1627 While it makes emacs --batch detect the vast majority of stdout
1628 write failures, errors were still ignored whenever the output size is
1629 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1630 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1631 && echo FAIL: ignored write error
1632 FAIL: ignored write error
1633 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1634 && echo FAIL: ignored write error
1635 FAIL: ignored write error
1636 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1637
8eca8a7c
AS
16382011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1639
1640 * emacs.c (Fkill_emacs): In noninteractive mode exit
1641 non-successfully if a write error occurred on stdout. (Bug#9574)
1642
3341db62
EZ
16432011-09-21 Eli Zaretskii <eliz@gnu.org>
1644
1645 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1646 the xassert test.
1647
1648 * dispextern.h (struct it): Update the comment documenting what
1649 can it->OBJECT be.
1650
8c203dbf
EZ
16512011-09-20 Eli Zaretskii <eliz@gnu.org>
1652
1653 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1654 a display string, extend search for cursor position to end of row.
1655 (find_row_edges): If the row ends in a newline from a display
1656 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1657 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1658 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1659 non-empty line. Fixes confusing cursor motion with arrow keys at
1660 the beginning of a line that starts with whitespace.
8c203dbf 1661
a4824228
LMI
16622011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1663
1664 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1665 (bug#9493).
1666
33ed493b
CY
16672011-09-18 Chong Yidong <cyd@stupidchicken.com>
1668
1669 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1670 boolean (Bug#9154).
1671
56cd55c8
EZ
16722011-09-18 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (display_line): Record maximum and minimum buffer
1675 positions even if no glyphs were produced (e.g., by a zero-width
1676 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1677 buffer positions that will be removed from the glyph row because
1678 they don't fit.
c02dcedf
EZ
1679 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1680 column is beyond frame width: don't subtract 1 "pixel" when
1681 computing width of the stretch.
3e62b7e0
EZ
1682 (reseat_at_next_visible_line_start): Undo the change made on
1683 2011-09-17 that saved paragraph information and restored it after
1684 the call to `reseat'. (Bug#9545)
56cd55c8 1685
5ed99d36 16862011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1687
1688 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1689 and turn window cursor on if cleared (Bug#9415).
1690
5ed99d36 16912011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1692
1693 * search.c (boyer_moore): Take unibyte characters from pattern
1694 literally. (Bug#9458)
1695
9bade7b2
EZ
16962011-09-18 Eli Zaretskii <eliz@gnu.org>
1697
1698 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1699
e5e9d610
PE
17002011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1701
87e4427a
PE
1702 Fix minor problem found by static checking.
1703 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1704 initialized, to pacify gcc -Wuninitialized.
1705
e5e9d610
PE
1706 * fileio.c: Report proper errno when syscall falls.
1707 (Finsert_file_contents): Save and restore errno,
1708 so that report_file_error outputs the correct diagnostic.
1709 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1710
a1674f0b
EZ
17112011-09-18 Eli Zaretskii <eliz@gnu.org>
1712
1713 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1714
fbfb6dd4
EZ
17152011-09-17 Eli Zaretskii <eliz@gnu.org>
1716
1717 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1718 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1719
bb187662
EZ
17202011-09-17 Eli Zaretskii <eliz@gnu.org>
1721
1137e8b8 1722 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1723 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1724
1725 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1726 (bidi_find_paragraph_start): Search back for paragraph beginning
1727 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1728 (bidi_move_to_visually_next): Only trigger paragraph-related
1729 computations when the last character is a newline or at EOB, not
1730 just any NEUTRAL_B. (Bug#9470)
1731
bb187662
EZ
1732 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1733 truncated lines if point is covered by a display string. (Bug#9524)
1734
2e621251
PE
17352011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1738 (cons_to_x_long): New function.
1739 (lisp_data_to_selection_data): Use it. Correct the test for
1740 short-versus-long data; it was negated. Break out of vector
1741 loop, for efficiency, when a long datum is discovered.
1742
91a15bc6
SM
17432011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1744
1745 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1746
b41c3a35
EZ
17472011-09-16 Eli Zaretskii <eliz@gnu.org>
1748
1749 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1750 GCC PR/17406) by declaring this function with external scope.
1751
7812ba2d
PE
17522011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1755 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1756
cf7edc2a
AS
17572011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1758
1759 * editfns.c (Fformat): Correctly handle text properties on "%%".
1760
bd01620e
EZ
17612011-09-15 Eli Zaretskii <eliz@gnu.org>
1762
1763 * xterm.c (x_draw_composite_glyph_string_foreground):
1764 * w32term.c (x_draw_composite_glyph_string_foreground):
1765 * term.c (encode_terminal_code):
1766 * composite.c (composition_update_it, get_composition_id):
1767 * xdisp.c (get_next_display_element)
1768 (fill_composite_glyph_string): Add comments about special meaning
1769 of TAB characters in a composition.
1770
a02719a3
PE
17712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1774 This occurs when processing a multibyte format.
1775 Problem reported by Wolfgang Jenker.
a02719a3 1776
72589a3c
JB
17772011-09-15 Johan Bockgård <bojohan@gnu.org>
1778
1779 * xdisp.c (try_cursor_movement): Only check for exact match if
1780 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1781
1c14176c
PE
17822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 Remove unused external symbols.
1785 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1786 * xdisp.c (calc_pixel_width_or_height): Now static.
1787 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1788 * indent.c (check_display_width):
1789 * w32term.c: Fix comment to match code.
1790 * xterm.c, xterm.h (x_catching_errors): Remove.
1791
d2eea5b5
PE
17922011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * xselect.c: Use signed conversions more consistently (Bug#9498).
1795 (selection_data_to_lisp_data): Assume incoming selection data are
1796 signed integers, not unsigned. This is to be consistent with
1797 outgoing selection data, which was modified to use signed integers
1798 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1799 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1800 expects long, not unsigned long.
1801
46888499
EZ
18022011-09-14 Eli Zaretskii <eliz@gnu.org>
1803
1804 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1805 computation of loop end. Reported by Johan Bockgård
1806 <bojohan@gnu.org>.
1807
ef8ef9fb
CY
18082011-09-13 Chong Yidong <cyd@stupidchicken.com>
1809
1810 * frame.c (Fother_visible_frames_p): Function deleted.
1811
fa819fed
EZ
18122011-09-12 Eli Zaretskii <eliz@gnu.org>
1813
1814 * indent.c (compute_motion): Process display vector front to back
1815 rather than the other way around. (Bug#2496)
1816
2ba8e008
SM
18172011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1818
1819 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1820
20f53c69
CY
18212011-09-11 Chong Yidong <cyd@stupidchicken.com>
1822
1823 * minibuf.c (Fread_from_minibuffer): Doc fix.
1824
d562d7a4
EZ
18252011-09-11 Eli Zaretskii <eliz@gnu.org>
1826
1827 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1828 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1829
1c4d7f3d
LMI
18302011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1831
1832 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1833 value for non-existent files.
1834
b885bf36
EZ
18352011-09-11 Eli Zaretskii <eliz@gnu.org>
1836
1837 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1838 set its "size" to -1. This will set the modtime_size field of
1839 the corresponding buffer to -1, which is what
1840 verify-visited-file-modtime expects for files that do not exist.
1841 (Bug#9139)
1842
6612f0bf
PE
18432011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1846 here ...
1847 * lisp.h: ... from here. push_key_description is no longer
1848 defined in keyboard.c, so its declaration should not be in
1849 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1850 logically belongs with push_key_description.
1851
dfb3f755
PE
18522011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * buffer.h: Include <sys/types.h> instead of <time.h>.
1855 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1856 Problem reported by Herbert J. Skuhra.
1857
3134906c
LMI
18582011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1859
1860 * xml.c (parse_region): Make the parsing work for
1861 non-comment-starting XML files again (bug#9144).
1862
8d903f4e
AS
18632011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1864
1865 * image.c (gif_load): Fix calculation of bottom and right corner.
1866 (Bug#9468)
1867
80ad64f4
EZ
18682011-09-10 Eli Zaretskii <eliz@gnu.org>
1869
1870 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1871 redisplay in small windows.
1872
208a048d
EZ
18732011-09-09 Eli Zaretskii <eliz@gnu.org>
1874
1875 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1876
9b1c252e
MR
18772011-09-08 Martin Rudalics <rudalics@gmx.at>
1878
1879 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1880 Operate on live windows only.
1881
2949f33b
JB
18822011-09-08 Juanma Barranquero <lekktu@gmail.com>
1883
1884 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1885
e08dcafd
EZ
18862011-09-07 Eli Zaretskii <eliz@gnu.org>
1887
1888 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1889 only under bidi iteration.
1890
115b96bd
JD
18912011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1892
1893 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1894
c8199d0f
PE
18952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1898 Without this fix, the command to link temacs failed due to an
1899 undefined symbol __builtin_isnan. This is because
1900 /usr/include/iso/math_c99.h #defines isnan(x) to
1901 __builtin_isnan(x), but the bundled gcc, which identifies itself
1902 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1903 a __builtin_isnan.
1904 * floatfns.c (isnan): #undef, and then #define to a clone of
1905 what's in data.c.
1906 (Fisnan): Always define, since it's always available now.
1907 (syms_of_floatfns): Always define isnan at the Lisp level.
1908
e39b275c 19092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1910
1911 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1912
b2db44d9 19132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1914
f4af5137 1915 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1916 The previous code assumed that file offsets (off_t values) fit in
1917 EMACS_INT variables, which is not true on typical 32-bit hosts.
1918 The code messed up by falsely reporting buffer overflow in cases
1919 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1920 when "big" contains more than 2**29 bytes, even though this
1921 inserts just one byte and does not overflow the buffer.
1922 (Finsert_file_contents): Store file offsets as off_t
1923 values, not as EMACS_INT values. Check for overflow when
1924 converting between EMACS_INT and off_t. When checking for
1925 buffer overflow or for overlap, take the offsets into account.
1926 Don't use EMACS_INT for small values where int suffices.
1927 When checking for overlap, fix a typo: ZV was used where
1928 ZV_BYTE was intended.
1929 (Fwrite_region): Don't assume off_t fits into 'long'.
1930 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1931
ecfc0a49
MA
19322011-09-05 Michael Albinus <michael.albinus@gmx.de>
1933
1934 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1935
6511acf2 19362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1937
0999621a 1938 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1939
1940 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1941 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1942 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1943 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1944 (modify_event_symbol): Do not assume that the length of
1945 name_alist_or_stem is safe to alloca and fits in int.
1946 (Fexecute_extended_command): Likewise for function name and binding.
1947 (Frecursion_depth): Wrap around reliably on integer overflow.
1948 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1949 since some callers pass EMACS_INT values.
1950 (Fsingle_key_description): Don't crash if symbol name contains more
1951 than MAX_ALLOCA bytes.
1952 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1953 (get_minibuffer): Arg is now EMACS_INT, not int.
1954 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1955 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1956 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1957
2be7d702
PE
1958 * dbusbind.c (signature_cat): New function.
1959 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1960 Do not overrun buffer; instead, report string overflow.
1961
9d1df220
PE
1962 * dispnew.c (add_window_display_history): Don't overrun buffer.
1963 Truncate instead; this is OK since it's just a log.
1964
33ef5c64
PE
1965 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1966 even if the time zone offset is outlandishly large.
1967 Don't mishandle offset == INT_MIN.
1968
66c6fdd5
PE
1969 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1970 when creating daemon; the previous buffer-overflow check was incorrect.
1971
d749b01b
PE
1972 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1973 which has the guts of the old verror function.
1974
b5cd1905
PE
1975 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1976 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1977
6e1a67fb
PE
1978 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1979 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1980 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1981 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1982 length of string rather than counting it via multiple sprintfs;
1983 that's simpler and more reliable.
c21721cc
PE
1984 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1985 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1986 sprintf, in case result does not fit in int.
1987
c57b67fc
PE
1988 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1989 (fontset_from_font): Print it.
1990
8a401434
PE
1991 * frame.c (tty_frame_count): Now printmax_t, not int.
1992 (make_terminal_frame, set_term_frame_name): Print it.
1993 (x_report_frame_params): In X, window IDs are unsigned long,
1994 not signed long, so print them as unsigned.
1995 (validate_x_resource_name): Check for implausibly long names,
1996 and don't assume name length fits in 'int'.
1997 (x_get_resource_string): Don't blindly alloca invocation name;
1998 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1999 not fit in int.
2000
6e1a67fb
PE
2001 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2002 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2003 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2004
0df02bf3
PE
2005 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2006 Use esprintf, not sprintf, in case result does not fit in int.
2007
48e30793
PE
2008 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2009 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2010 it as a large positive number.
2011 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2012 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2013
a66ff6d8
PE
2014 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2015 in case result does not fit in int.
2016
aca216ff
PE
2017 * print.c (float_to_string): Detect width overflow more reliably.
2018 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2019 buffer overrun. Don't assume list length fits in 'int'. Treat
2020 print length of 0 as 0, not as infinity; to be consistent with other
2021 uses of print length in this function. Don't overflow print length
2022 index. Don't assume hash table size fits in 'long', or that
2023 vectorlike size fits in 'unsigned long'.
2024
31c286f7
PE
2025 * process.c (make_process): Use printmax_t, not int, to format
2026 process-name gensyms.
2027
55e5faa1
PE
2028 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2029
80f2e268
PE
2030 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2031 to avoid potential buffer overrun.
2032
670741ab
PE
2033 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2034 if X resource line is longer than 512 bytes.
2035
b7163a50
PE
2036 * xfns.c (x_window): Make sprintf buffer a bit bigger
2037 to avoid potential buffer overrun.
2038
ae58ff1f
PE
2039 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2040
c43c8a6a
PE
2041 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2042
3f8236f4
PE
20432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2044
53e9fe90 2045 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2046 Without these, Emacs silently mishandles large integers sometimes.
2047 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2048 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2049
6511acf2
PE
2050 * xdisp.c (try_window_id): Check Emacs fixnum range before
2051 converting to 'int'.
806add1d 2052
6511acf2 2053 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2054 Check that an Emacs fixnum is in range before assigning it to 'int'.
2055 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2056 values converted from Emacs fixnums.
2057 (Frecenter): Don't wrap around a line count if it is out of 'int'
2058 range; instead, treat it as an extreme value.
2059 (Fset_window_configuration, compare_window_configurations):
2060 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2061
6511acf2
PE
2062 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2063 that can exceed INT_MAX. Check that EMACS_INT value is in range
2064 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2065 (match_limit): Don't assume that a fixnum can fit in 'int'.
2066
6511acf2 2067 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2068 exceed INT_MAX.
2069
6511acf2 2070 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2071 (Fvertical_motion): Don't wrap around LINES values that don't fit
2072 in 'int'. Instead, treat them as extreme values. This is good
2073 enough for windows, which can't have more than INT_MAX lines anyway.
2074
fcb901a7
LMI
20752011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2076
0f2f6b6d
LMI
2077 * Require libxml/parser.h to avoid compilation warning.
2078
fcb901a7
LMI
2079 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2080
2081 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2082 since this reportedly can destroy thread storage.
2083
6e20a0d4
CY
20842011-08-30 Chong Yidong <cyd@stupidchicken.com>
2085
2086 * syntax.c (find_defun_start): Update all cache variables if
2087 exiting early (Bug#9401).
2088
148ae00e
EZ
20892011-08-30 Eli Zaretskii <eliz@gnu.org>
2090
f6cfbd8f
EZ
2091 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2092
148ae00e
EZ
2093 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2094 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2095 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2096
2097 * term.c (tty_append_glyph): New function.
2098 (produce_stretch_glyph): Static function and its prototype deleted.
2099
a66cfb1c
SM
2100 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2101 Add prototypes.
148ae00e 2102
c4a07a4c
PE
21032011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2106 when checking :margin (Bug#9390).
2107 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2108 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2109 so that the name doesn't mislead. All uses changed.
2110
6bc8cd65
JB
21112011-08-28 Johan Bockgård <bojohan@gnu.org>
2112
2113 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2114 set_tty_hooks.
2115
dca4927e
EZ
21162011-08-27 Eli Zaretskii <eliz@gnu.org>
2117
2118 * xdisp.c (move_it_to): Don't bail out early when reaching
2119 position beyond to_charpos, if we are scanning backwards.
2120 (move_it_vertically_backward): When DY == 0, make sure we get to
2121 the first character in the line after the newline.
2122
f2cad773
PE
21232011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2126 (ccl_driver): Do not generate an out-of-range pointer.
2127 (Fccl_execute_on_string): Remove unnecessary check for
2128 integer overflow, noted by Stefan Monnier in
2129 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2130 Remove a FIXME that didn't need fixing.
2131 Simplify the newly-introduced buffer reallocation code.
2132
0cae2cdb
JB
21332011-08-27 Juanma Barranquero <lekktu@gmail.com>
2134
2135 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2136
5fc295a4 21372011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2138
70c60eb2 2139 Integer and memory overflow issues (Bug#9196).
726e0ab1 2140
d31850da
PE
2141 * doc.c (get_doc_string): Rework so that
2142 get_doc_string_buffer_size is the actual buffer size, rather than
2143 being 1 less than the actual buffer size; this makes xpalloc more
2144 convenient.
2145
a69fbedb
PE
2146 * image.c (x_allocate_bitmap_record, cache_image):
2147 * xselect.c (Fx_register_dnd_atom):
2148 Simplify previous changes by using xpalloc.
2149
fe5c5d37
PE
2150 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2151 since either will do and ptrdiff_t is convenient with xpalloc.
2152
0065d054
PE
2153 * charset.c (charset_table_size)
2154 (struct charset_sort_data.priority): Now ptrdiff_t.
2155 (charset_compare): Don't overflow if priorities differ greatly.
2156 (Fsort_charsets): Don't assume list length fits in int.
2157 Check for size-calculation overflow when allocating sort data.
2158 (syms_of_charset): Allocate an initial charset table that is
2159 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2160
2161 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2162
2163 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2164 The actual value is always <= INT_MAX, and leaving it unsigned made
2165 overflow checking harder.
2166
2167 * dispextern.h (struct glyph_matrix.rows_allocated)
2168 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2169 with xpalloc. The values are still always <= INT_MAX.
2170
2171 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2172
2173 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2174 (SAFE_NALLOCA): New macro.
2175
2176 * region-cache.c (struct boundary.pos, find_cache_boundary)
2177 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2178 (set_cache_region, invalidate_region_cache)
2179 (revalidate_region_cache, know_region_cache, region_cache_forward)
2180 (region_cache_backward, pp_cache):
2181 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2182 so that ptrdiff_t * can be passed to xpalloc.
2183 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2184 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2185 (pp_cache): Don't assume cache_len fits in int.
2186 * region-cache.h: Adjust extern decls to match.
2187
2188 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2189 EMACS_INT, since either will do, for xpalloc.
2190
2191 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2192 (xnmalloc, xnrealloc, xpalloc): New functions.
2193
726e0ab1
PE
2194 * bidi.c (bidi_shelve_header_size): New constant.
2195 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2196 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2197
51f30bc5 2198 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2199 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2200 (overlay_strings):
2201 Don't update size of array until after memory allocation succeeds,
2202 because xmalloc/xrealloc may not return.
0065d054
PE
2203 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2204 now that we have proper integer overflow checking.
2205 (record_overlay_string, overlay_strings): Catch overflows when
2206 calculating size of overlay_str_buf.
726e0ab1 2207
0065d054
PE
2208 * callproc.c (Fcall_process): Check for size overflow when
2209 calculating size of args2.
2210 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2211 Normally we prefer signed values, but sticking with ptrdiff_t would
2212 require adding more-complicated checks.
726e0ab1
PE
2213
2214 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2215 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2216 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2217 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2218
2219 * character.c (Fstring): Check for size-calculation overflow.
2220
2221 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2222 unnecessary integer overflow. Check for size overflow.
2223 (encode_coding_object): Don't update size until xmalloc succeeds.
2224
2225 * composite.c (get_composition_id): Check for overflow in glyph
2226 length calculations.
2227
2228 Integer and memory overflow fixes for display code.
2229 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2230 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2231 (scrolling_window): Check for overflow in size calculations.
2232 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2233 Don't assume glyph table len fits in int.
2234 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2235 (row_table_size): Now ptrdiff_t, not int.
2236 (scrolling_window): Avoid overflow in size calculations.
2237 Don't update size until allocation succeeds.
2238 * fns.c (concat): Check for overflow in size calculations.
2239 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2240 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2241 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2242
2243 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2244 (get_doc_string): Check for size calculation overflow.
2245 Don't update size until allocation succeeds.
2246 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2247 EMACS_INT, where ptrdiff_t will do.
2248 (Fsubstitute_command_keys): Check for string overflow.
2249
2250 * editfns.c (set_time_zone_rule): Don't assume environment length
2251 fits in int.
2252 (message_length): Now ptrdiff_t, not int.
2253 (Fmessage_box): Don't update size until allocation succeeds.
2254 Don't assume message length fits in int.
2255 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2256
0065d054
PE
2257 * emacs.c (main): Do not reallocate argv, since there is a null at
2258 the end that can be overwritten, and this way there's no need to
2259 worry about size-calculation overflow.
2260 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2261
2262 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2263 alloc succeeds.
2264 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2265
2266 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2267 (x_set_scroll_bar_width, x_figure_window_size):
2268 Check for integer overflow.
2269 (x_set_alpha): Do not assume XINT fits in int.
2270
2271 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2272 This is for the members text_lines, text_cols, total_lines, total_cols,
2273 where the system imposes an 'int' limit.
2274
2275 * fringe.c (Fdefine_fringe_bitmap):
2276 Don't update size until alloc works.
2277
2278 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2279 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2280
2281 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2282 Check for size-calculation overflow.
2283 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2284 do, as we prefer signed integers.
2285 (id_to_widget.max_size, id_to_widget.used)
2286 (xg_store_widget_in_map, xg_remove_widget_from_map)
2287 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2288 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2289 Use and return ptrdiff_t, not int.
2290 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2291 * gtkutil.h: Change prototypes to match the above.
2292
2293 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2294 are duplicate now that they've been promoted to lisp.h.
2295 (x_allocate_bitmap_record, x_alloc_image_color)
2296 (make_image_cache, cache_image, xpm_load):
2297 Don't update size until alloc is done.
2298 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2299 (x_detect_edges):
3256efce 2300 Check for size calculation overflow.
726e0ab1
PE
2301 (ct_colors_allocated_max): New constant.
2302 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2303 overflow.
3256efce 2304
726e0ab1
PE
2305 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2306 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2307 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2308 Use ptrdiff_t, not int, to count maps.
2309 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2310 calculations. Don't update size until allocation succeeds.
2311 Redo calculations to avoid overflow.
726e0ab1
PE
2312 * keyboard.h: Change prototypes to match the above.
2313
2314 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2315 to count maps.
2316 (current_minor_maps): Check for size calculation overflow.
2317 * keymap.h: Change prototypes to match the above.
2318
2319 * lread.c (read1, init_obarray): Don't update size until alloc done.
2320
2321 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2322 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2323
726e0ab1
PE
2324 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2325 Now ptrdiff_t, not int.
2326 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2327 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2328
2329 * process.c (Fnetwork_interface_list): Check for overflow
2330 in size calculation.
2331
2332 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2333
2334 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2335 overflow. Don't bother calling xmalloc when xrealloc will do.
2336
2337 * search.c (Freplace_match): Check for size calculation overflow.
2338 (Fset_match_data): Don't assume list lengths fit in 'int'.
2339
2340 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2341 for command line length. Do not attempt to address one before the
2342 beginning of an array, as that's not portable.
2343
2344 * term.c (max_frame_lines): Remove; unused.
2345 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2346 not int.
2347 (encode_terminal_code, calculate_costs): Check for size
2348 calculation overflow.
2349 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2350 table lengths and related sizes. Don't update size until alloc
2351 done. Redo calculations to avoid overflow.
2352 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2353
2354 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2355 subtracting pointers.
2356 (gobble_line): Check for overflow more carefully. Don't update size
2357 until alloc done.
2358
2359 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2360 Don't update size until alloc done.
2361 Redo size calculations to avoid overflow.
2362 Check for size calculation overflow.
0065d054 2363 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2364
2365 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2366 Use ptrdiff_t, not int, for sizes.
2367 (store_mode_line_noprop_char): Don't update size until alloc done.
2368
0065d054
PE
2369 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2370 Use ptrdiff_t, not int, for sizes.
2371 (Finternal_make_lisp_face, cache_face):
2372 Check for size calculation overflow.
2373 (cache_face): Treat size calculation overflows as if they were
2374 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2375
2376 * xfns.c (x_encode_text, x_set_name_internal)
2377 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2378 sizes, since they can exceed INT_MAX in size. Check for size
2379 calculation overflow.
2380
0065d054
PE
2381 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2382 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2383 Don't update size until alloc done.
2384
0065d054 2385 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2386 as sprintf is limited to int lengths.
1d526e2f 2387
252c5ee1
PE
2388 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2389 (X_LONG_MIN): New macros.
864d7ce7
PE
2390 Use them to make the following changes clearer.
2391 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2392 This change doesn't affect the value now, but it may help remind
2393 future maintainers not to raise the value too much later.
2394 (SELECTION_QUANTUM): Remove, replacing with ...
2395 (selection_quantum): ... new function, which avoids overflow.
2396 All uses changed.
2397 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2398 assumption that selection length fits in 'int'.
2399 (x_reply_selection_request, x_handle_selection_request)
2400 (x_get_window_property, receive_incremental_selection)
2401 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2402 (lisp_data_to_selection_data, clean_local_selection_data):
2403 Use ptrdiff_t, not int, to record length of selection.
2404 (x_reply_selection_request, x_get_window_property)
2405 (receive_incremental_selection, x_property_data_to_lisp):
2406 Redo calculations to avoid overflow.
2407 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2408 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2409 something.
2410 (x_get_window_property, receive_incremental_selection)
2411 (lisp_data_to_selection_data, x_property_data_to_lisp):
2412 Check for size-calculation overflow.
2413 (x_get_window_property, receive_incremental_selection)
2414 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2415 Don't store size until memory allocation succeeds.
2416 (x_get_window_property): Plug memory leak on memory exhaustion.
2417 Don't double-block input; malloc is safe here. Don't assume 2**34
2418 - 4 fits in unsigned long. Add an xassert to check
2419 XGetWindowProperty overflow. Be more careful about overflow
2420 calculations, and distinguish size from memory overflow better.
2421 (receive_incremental_selection): When tracing, don't assume
2422 unsigned int is less than INT_MAX.
2423 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2424 harmful) conversions of unsigned short to int.
2425 (lisp_data_to_selection_data): Don't assume that integers
2426 in the range -65535 through -1 fit in an X unsigned short.
2427 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2428 result parameters unless successful. Rely on cons_to_unsigned
2429 to report problems with elements; the old code wasn't right anyway.
2430 (x_check_property_data): Check for int overflow; we cannot use
2431 a wider type due to X limits.
2432 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2433
726e0ab1 2434 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2435
0065d054
PE
2436 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2437 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2438 (x_color_cells): Don't store size until memory allocation succeeds.
2439 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2440 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2441 (x_term_init): Don't assume length fits in int (sprintf is limited
2442 to int size).
bc18e09d 2443
ebfa62c0
PE
2444 Use ptrdiff_t for composition IDs.
2445 * character.c (lisp_string_width):
2446 * composite.c (composition_table_size, n_compositions)
2447 (get_composition_id, composition_gstring_from_id):
2448 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2449 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2450 * window.c (Frecenter):
2451 Use ptrdiff_t, not int, for composition IDs.
2452 * composite.c (get_composition_id): Check for integer overflow.
2453 * composite.h: Adjust prototypes to match the above changes.
2454
d3411f89
PE
2455 Use ptrdiff_t for hash table indexes.
2456 * category.c (hash_get_category_set):
2457 * ccl.c (ccl_driver):
2458 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2459 * coding.c (coding_system_charset_list, detect_coding_system):
2460 * coding.h (struct coding_system.id):
2461 * composite.c (get_composition_id, gstring_lookup_cache):
2462 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2463 * image.c (xpm_get_color_table_h):
2464 * lisp.h (hash_lookup, hash_put):
2465 * minibuf.c (Ftest_completion):
2466 Use ptrdiff_t for hash table indexes, not int (which is too
2467 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2468 32-bit --with-wide-int hosts).
2469
e097a6fa
PE
2470 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2471 Add a FIXME comment about memory leaks.
2472 (syms_of_charset): Don't assume xmalloc returns.
2473
5637687f
PE
2474 Don't assume that stated character widths fit in int.
2475 * character.c (Fchar_width, c_string_width, lisp_string_width):
2476 * character.h (CHAR_WIDTH):
2477 * indent.c (MULTIBYTE_BYTES_WIDTH):
2478 Use sanitize_char_width to avoid undefined and/or bad behavior
2479 with outlandish widths.
a66cfb1c 2480 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2481 now that we have two such functions. All uses changed.
2482 (sanitize_char_width): New inline function.
2483
a2271ba2
PE
2484 Don't assume that tab-width fits in int.
2485 * character.h (sanitize_width): New inline function.
2486 (SANE_TAB_WIDTH): New macro.
2487 (ASCII_CHAR_WIDTH): Use it.
2488 * indent.c (sane_tab_width): Remove. All uses replaced by
2489 SANE_TAB_WIDTH (current_buffer).
2490 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2491
18c52557
PE
2492 * fileio.c: Integer overflow issues with file modes.
2493 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2494
caeeedc1
PE
2495 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2496 Remove unreachable code.
2497 (read_hex, load_charset_map_from_file): Check for integer overflow.
2498
6df6ae42 2499 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2500 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2501 (x_send_scroll_bar_event): Likewise. Check that the size does not
2502 exceed limits imposed by XClientMessageEvent, as well as the usual
2503 ptrdiff_t and size_t limits.
2504
b13995db
PE
2505 * keyboard.c: Overflow, signedness and related fixes.
2506 (make_lispy_movement): Use same integer type in forward decl
2507 that is used in the definition.
2508 (read_key_sequence, keyremap_step):
2509 Change bufsize argument back to int, undoing my 2011-03-30 change.
2510 We prefer signed types, and int is wide enough here.
2511 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2512 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2513 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2514 length, not size_t. Use ptrdiff_t for index, not int.
2515 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2516 possibility of integer overflow.
2517
13464394
PE
2518 Overflow, signedness and related fixes for images.
2519
2520 * dispextern.h (struct it.stack[0].u.image.image_id)
2521 (struct_it.image_id, struct image.id, struct image_cache.size)
2522 (struct image_cache.used, struct image_cache.ref_count):
2523 * gtkutil.c (update_frame_tool_bar):
2524 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2525 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2526 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2527 * nsmenu.m (update_frame_tool_bar):
2528 * xdisp.c (calc_pixel_width_or_height):
2529 * xfns.c (image_cache_refcount):
2530 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2531 on typical 64-bit hosts.
2532
2533 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2534 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2535 Omit unnecessary casts to int.
2536 (parse_image_spec): Check that integers fall into 'int' range
2537 when the callers expect that.
2538 (image_ascent): Redo ascent calculation to avoid int overflow.
2539 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2540 (lookup_image): Remove unnecessary tests.
2541 (xbm_image_p): Locals are now of int, not EMACS_INT,
2542 since parse_image_check makes sure they fit into int.
2543 (png_load, gif_load, svg_load_image):
2544 Prefer int to unsigned where either will do.
2545 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2546 old tiff_error_handler and tiff_warning_handler.
2547 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2548 stack buffer overflows. It uses only the features of vsnprintf
2549 that are common to both POSIX and native Microsoft.
2550 (tiff_error_handler, tiff_warning_handler): Use it.
2551 (tiff_load, gif_load, imagemagick_load_image):
2552 Don't assume :index value fits in 'int'.
2553 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2554 (imagemagick_load_image): Check that crop parameters fit into
2555 the integer types that MagickCropImage accepts. Don't assume
2556 Vimagemagick_render_type has a nonnegative value. Don't assume
2557 size_t fits in 'long'.
2558 (gs_load): Use printmax_t to print the widest integers possible.
2559 Check for integer overflow when computing image height and width.
2560
c11821d4
EZ
25612011-08-26 Eli Zaretskii <eliz@gnu.org>
2562
2563 * xdisp.c (redisplay_window): Don't force window start if point
2564 will be invisible in the resulting window. (Bug#9324)
2565
0c95fcf7
EZ
25662011-08-25 Eli Zaretskii <eliz@gnu.org>
2567
2568 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2569 the display spec is of the form `(space ...)'.
2570 (handle_display_spec): Return the value returned by
2571 handle_single_display_spec, not just 1 or zero.
2572 (handle_single_display_spec): If the display spec is of the form
2573 `(space ...)', and specifies display in the text area, return 2
2574 rather than 1.
fee65a97 2575 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2576 accurately, and prefer exact match for point under bidi.
2577 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2578
2579 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2580 into disp_prop; all users changed.
2581
2582 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2583 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2584 for the text covered by the display property.
2585
e4ed06f1
CY
25862011-08-25 Chong Yidong <cyd@stupidchicken.com>
2587
2588 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2589 Change return value to nil.
2590 (Frecord_buffer): Delete unused function.
2591
f67cdd7f
EZ
25922011-08-24 Eli Zaretskii <eliz@gnu.org>
2593
5980d4c6
EZ
2594 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2595 buffers, return left-to-right.
8610fe8b
EZ
2596 (set_cursor_from_row): Consider candidate row a win if its glyph
2597 represents a newline and point is on that newline. Fixes cursor
2598 positioning on the newline at EOL of R2L text within L2R
2599 paragraph, and vice versa.
2600 (try_cursor_movement): Check continued rows, in addition to
2601 continuation rows. Fixes unwarranted scroll when point enters a
2602 continued line of R2L text within an L2R paragraph, or vice versa.
2603 (cursor_row_p): Consider the case of point being equal to
2604 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2605 from the end of a short line to the beginning of a continued line
2606 of R2L text within L2R paragraph.
2607 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2608 composed characters.
5980d4c6 2609
f67cdd7f
EZ
2610 * bidi.c (bidi_check_type): Use xassert.
2611 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2612 members.
2613
bca633fb
EZ
26142011-08-23 Eli Zaretskii <eliz@gnu.org>
2615
2616 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2617 a character.
2618
4a5885a7
CY
26192011-08-23 Chong Yidong <cyd@stupidchicken.com>
2620
2621 * nsfont.m (ns_otf_to_script): Fix typo.
2622
0902a04e
KH
26232011-08-22 Kenichi Handa <handa@m17n.org>
2624
2625 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2626 extra slot even if the purpose is char-code-property-table.
2627
1a2e6670
EZ
26282011-08-23 Eli Zaretskii <eliz@gnu.org>
2629
8ddde651
EZ
2630 * xdisp.c (redisplay_window): When computing centering_position,
2631 account for the height of the header line. (Bug#8874)
2632
425cc014
EZ
2633 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2634 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2635 candidate is selected by the mouse, and that candidate has a
2636 composed character under the mouse.
2637
1a2e6670
EZ
2638 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2639 coordinates reported by pos-visible-in-window-p for a composed
2640 character in column zero.
2641
8b76d6f8
SM
26422011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2643
2644 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2645
dac347dd
EZ
26462011-08-22 Eli Zaretskii <eliz@gnu.org>
2647
2648 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2649 consider it a hit if to_charpos is anywhere in the range of the
2650 composed buffer positions.
2651
e013fb34
CY
26522011-08-22 Chong Yidong <cyd@stupidchicken.com>
2653
2654 * image.c (gif_load): Don't assume that each subimage has the same
2655 dimensions as the base image. Handle disposal method that is
2656 "undefined" by the gif spec (Bug#9335).
2657
bd1ba3e8
CY
26582011-08-20 Chong Yidong <cyd@stupidchicken.com>
2659
2660 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2661 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2662
54a1215b
EZ
26632011-08-19 Eli Zaretskii <eliz@gnu.org>
2664
823564e5
EZ
2665 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2666 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2667 from an Org mode buffer to a Speedbar frame.
2668
54a1215b
EZ
2669 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2670 a composition, take its buffer position from IT->cmp_it.charpos.
2671 Fixes cursor positioning at the beginning of a line that begins
2672 with a composed character.
2673
9778ebcc
EZ
26742011-08-18 Eli Zaretskii <eliz@gnu.org>
2675
0be6ee06
EZ
2676 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2677 character bidirectional type, use STRONG_L instead. Fixes crashes
2678 in a buffer produced by `describe-categories'.
2679
9778ebcc
EZ
2680 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2681 members before the level stack, so they would be saved and
2682 restored when copying iterator state. Fixes incorrect reordering
2683 around TABs covered by display properties.
2684
156bffbe
AS
26852011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2686
6b02f655 2687 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2688
72ad093b
CY
26892011-08-17 Chong Yidong <cyd@stupidchicken.com>
2690
2691 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2692 (internal_condition_case_2, internal_condition_case_n):
2693 Remove unnecessary aborts (Bug#9081).
72ad093b 2694
35774242
EZ
26952011-08-17 Eli Zaretskii <eliz@gnu.org>
2696
2697 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2698 has no `load' handler, try opening the file locally. (Bug#9311)
2699
db76dd85
KB
27002011-08-16 Ken Brown <kbrown@cornell.edu>
2701
2702 * gmalloc.c: Expand comment.
2703
b215eee5
EZ
27042011-08-16 Eli Zaretskii <eliz@gnu.org>
2705
2706 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2707 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2708
a4579d33
KB
27092011-08-16 Ken Brown <kbrown@cornell.edu>
2710
2711 Fix memory allocation problems in Cygwin build (Bug#9273).
2712
2713 * unexcw.c ( __malloc_initialized): Declare external variable.
2714 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2715
8b76d6f8
SM
2716 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2717 New variables.
a4579d33
KB
2718 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2719 dumped emacs.
2720 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2721 in the static heap.
2722 [CYGWIN] (special_realloc): New function.
2723 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2724 requests to realloc storage in the static heap.
2725
3ebec551
PE
27262011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2727
2728 * bidi.c (bidi_initialize): Remove unused local.
2729
9fd8be00
EZ
27302011-08-15 Eli Zaretskii <eliz@gnu.org>
2731
6b02f655
SM
2732 * bidimirror.h:
2733 * biditype.h: Remove file.
2734 * makefile.w32-in ($(BLD)/bidi.$(O)):
2735 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2736
2737 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2738
2739 * chartab.c: Improve commentary for the uniprop_table API.
2740
32413314
EZ
2741 * bidi.c (bidi_paragraph_init): Support zero value of
2742 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2743 (bidi_initialize): Use uniprop_table instead of including
2744 biditype.h and bidimirror.h.
32413314 2745
9fd8be00
EZ
2746 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2747 coordinates of the iterator when restoring from ppos_it.
2748 (Bug#9296)
2749
5cf2b69b
KH
27502011-08-14 Kenichi Handa <handa@m17n.org>
2751
2752 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2753 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2754
daf17d00
EZ
27552011-08-14 Eli Zaretskii <eliz@gnu.org>
2756
2757 * xdisp.c (move_it_in_display_line_to): Don't invoke
2758 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2759 ppos_it. Fixes vertical cursor motion when line beginning is
2760 covered by an image. (Bug#9296)
2761
08e3161a
JD
27622011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2763
2764 * nsterm.h (ns_run_ascript): Declare.
2765 (NSAPP_DATA2_RUNASSCRIPT): Define.
2766
2767 * nsfns.m (as_script, as_result, as_status): New static variables.
2768 (ns_run_ascript): New function.
5e617bc2 2769 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2770 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2771 the event loop. Get status from as_status (Bug#7276).
2772
2773 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2774 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2775 the event loop (Bug#7276).
2776
a3720aa2
AS
27772011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2778
2779 * gnutls.c (QCgnutls_bootprop_priority)
2780 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2781 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2782 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2783 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2784 (QCgnutls_bootprop_verify_hostname_error)
2785 (QCgnutls_bootprop_callbacks_verify): Rename from
2786 Qgnutls_bootprop_..., all uses changed.
2787
2788 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2789 uses changed.
2790
0a0d27fb
PE
27912011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2792
19d5c50c
PE
2793 * xfaces.c (Qframe_set_background_mode): Now static.
2794 * dispextern.h (Qframe_set_background_mode): Remove decl.
2795
0a0d27fb
PE
2796 * process.c (Fnetwork_interface_info): Declare local only if needed.
2797
377538cb
JD
27982011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2799
2800 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2801 (Fnetwork_interface_list): Allocate in increments of bytes instead
2802 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2803 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2804 sockaddr.
2805 (struct ifflag_def): notrailers is smart on OSX.
2806 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2807 Get hardware address with getifaddrs if available.
2808
08fff70c
EZ
28092011-08-12 Eli Zaretskii <eliz@gnu.org>
2810
2811 * xdisp.c (iterate_out_of_display_property): xassert that
2812 IT->position is set to within IT->object's boundaries. Break from
2813 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2814 when IT->position is set up wrongly due to some bug.
2815 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2816 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2817 entry. Force push_it to save on the stack the current
2818 buffer/string position, to be restored by pop_it. Fix flags in
2819 the iterator structure wrt the object coming from a display
2820 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2821 properties. (Bug#9284)
2822
7be1c708 28232011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2824
7be1c708
CY
2825 * fontset.c (fontset_get_font_group): Add proper type checks.
2826 (Bug#9172)
aac0c6e3 2827
7be1c708 28282011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2829
7be1c708
CY
2830 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2831 and LC_VERSION_MIN_MACOSX.
2832 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2833 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2834
97bb72a6
EZ
28352011-08-08 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2838 no-display-properties-and-no-overlays under bidi display.
2839 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2840 properties and overlays.
97bb72a6 2841
d5617611
CY
28422011-08-08 Chong Yidong <cyd@stupidchicken.com>
2843
37e11a63
CY
2844 * editfns.c (Fset_time_zone_rule): Document relationship with the
2845 setenv function.
2846
d5617611
CY
2847 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2848 the font entity extracted from the cache (Bug#8109).
2849
58872834
CY
28502011-08-07 Chong Yidong <cyd@stupidchicken.com>
2851
2852 * composite.c (autocmp_chars): Don't reset point. That is done by
2853 restore_point_unwind (Bug#5984).
2854
75bfc667
JL
28552011-08-07 Juri Linkov <juri@jurta.org>
2856
2857 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2858 to show the arg `TIME' instead of `TIMEVAL'.
2859
d1410150
EZ
28602011-08-06 Eli Zaretskii <eliz@gnu.org>
2861
2862 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2863 display property strides EOL and includes a newline, as in
2864 longlines-mode. (Bug#9254)
75b771e4
EZ
2865 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2866 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2867
2868 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2869 is non-zero, even if the data buffer is NULL. Fixes a crash in
2870 vertical-motion with longlines-mode. (Bug#9254)
2871
35928349
EZ
28722011-08-05 Eli Zaretskii <eliz@gnu.org>
2873
ec7cc85b
EZ
2874 * bidi.c <bidi_cache_total_alloc>: Now static.
2875 (bidi_initialize): Initialize bidi_cache_total_alloc.
2876
8b76d6f8 2877 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2878 cache. (Bug#9221)
2879
2880 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2881 amount allocated this far in `bidi_cache_total_alloc'.
2882 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2883 non-zero, only free the data buffer without restoring the cache
2884 contents. All callers changed.
2885
2886 * dispextern.h (bidi_unshelve_cache): Update prototype.
2887
2888 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2889 (move_it_in_display_line, move_it_to)
2890 (move_it_vertically_backward, move_it_by_lines): Replace the call
2891 to xfree to an equivalent call to bidi_unshelve_cache.
2892 (move_it_in_display_line_to): Fix logic of returning
412b6358 2893 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2894
e2e2423b
EZ
28952011-08-05 Eli Zaretskii <eliz@gnu.org>
2896
2897 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2898 came from a string character with a `cursor' property. (Bug#9229)
2899
ae9e757a
JD
29002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2901
2902 * Makefile.in (LIB_PTHREAD): New variable.
2903 (LIBES): Add LIB_PTHREAD (Bug#9216).
2904
2905 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2906 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2907
213bd7f2
AS
29082011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2909
6b02f655 2910 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2911
99aaf75f
JD
29122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2913
2914 * xterm.c (x_find_topmost_parent): New function.
2915 (x_set_frame_alpha): Find topmost parent window with
2916 x_find_topmost_parent and set the property there also (bug#9181).
2917 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2918
c74e9d86
PE
29192011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 * callproc.c (Fcall_process): Avoid vfork clobbering
2922 the local vars buffer, coding_systems, current_dir.
2923
640c8776
SM
29242011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2925
2926 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2927
f26d0e4c
PE
29282011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2929
8a10d76c
PE
2930 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2931 so that it is not optimized away.
2932
f26d0e4c
PE
2933 * xdisp.c (compute_display_string_pos): Remove unused local.
2934
55439c61
EZ
29352011-08-02 Eli Zaretskii <eliz@gnu.org>
2936
2937 Fix slow cursor motion and scrolling in large buffers with
2938 selective display, like Org Mode buffers. (Bug#9218)
2939
2940 * dispextern.h (struct bidi_it): New member disp_prop_p.
2941
2942 * xdisp.c: Remove one-slot cache of display string positions.
2943 (compute_display_string_pos): Accept an additional argument
5e617bc2 2944 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2945 for a display string or property. If found, set DISP_PROP_P
2946 non-zero.
2947
2948 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2949 DISP_PROP_P, and pass it to compute_display_string_pos.
2950 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2951 non-zero. All callers of bidi_fetch_char changed.
2952
fb33fa43
SM
29532011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2954
2955 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2956
b099e063
DM
29572010-12-03 Don March <don@ohspite.net>
2958
2959 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2960 last character M-[char] is translated to ESC [char] (bug#7541).
2961
5cc7f7af
KH
29622011-08-02 Kenichi Handa <handa@m17n.org>
2963
d0fffa3f 2964 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2965
2966 * chartab.c (uniprop_table): Make it non-static.
2967
525d5e6e
EZ
29682011-08-01 Eli Zaretskii <eliz@gnu.org>
2969
2970 * xdisp.c (forward_to_next_line_start): Accept additional argument
2971 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2972 on the newline.
2973 (reseat_at_next_visible_line_start): Use the bidi iterator state
2974 returned by forward_to_next_line_start to restore the state of
2975 it->bidi_it after backing up to previous newline. (Bug#9212)
2976
31011111
AS
29772011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2978
2979 * regex.c (re_comp): Protoize.
2980 (re_exec): Fix return type.
2981 (regexec): Fix type of `ret'. (Bug#9203)
2982
476371c4
PE
29832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2984
e5d76069
PE
2985 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2986 This is needed if max-image-size is a floating-point number.
2987
9a79b20c
AS
29882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2989
2990 * print.c (print_object): Print empty symbol as ##.
2991
2992 * lread.c (read1): Read ## as empty symbol.
2993
d8c2fa78
AA
29942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2995
2996 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2997 setting frame foreground color (Bug#9175).
2998 (x_set_background_color): Likewise.
2999
ffe57a7a
AA
3000 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3001 contents (Bug#9176).
3002 (EmacsTooltip -init): Remove bezels and add shadows to
3003 tooltip windows.
3004
bf3492a5
AA
3005 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3006 or scroll bar (Bug#8470).
3007
d55e9c53
AA
3008 * nsfont.m (nsfont_open): Remove assignment to voffset and
3009 unnecessary vars hshink, expand, hd, full_height, min_height.
3010 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3011
3012 * nsterm.h (nsfont_info): Remove voffset field.
3013
d8c2fa78 30142011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3015
3016 Implement strike-through and overline on NextStep (Bug#8863).
3017
3018 * nsfont.m (nsfont_open): Use underline position provided by font,
3019 instead of hard-coded value of 2.
3020 (nsfont_draw): Call ns_draw_text_decoration instead.
3021
3022 * nsterm.h: Add declaration for ns_draw_text_decoration.
3023
3024 * nsterm.m (ns_draw_text_decoration): New function for drawing
3025 underline, overline, and strike-through.
3026 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3027 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3028 accommodate underlining, etc.
4843aac3 3029
4cc60b9b
EZ
30302011-07-28 Eli Zaretskii <eliz@gnu.org>
3031
bc7ece87
EZ
3032 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3033 default.
4cc60b9b 3034
476371c4
PE
30352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3036
66606eea
PE
3037 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3038 Without this fix, if a signal arrives just after memory fills up,
3039 'malloc' might be invoked reentrantly.
3040
476371c4
PE
3041 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3042 In other words, assume that every image size is allowed, on non-X
3043 hosts. This assumption is probably wrong, but it lets Emacs compile.
3044
f3fcc40d
AS
30452011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3046
3047 * regex.c (re_iswctype): Convert return values to boolean.
3048
350c992f
EZ
30492011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3050
3051 * xdisp.c (compute_display_string_pos): Don't use cached display
3052 string position if the buffer had its restriction changed.
3053 (Bug#9184)
3054
5266b4bb
PE
30552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3058
2573a837 30592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3060
41f55ccd 3061 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3062
39e378da
PE
3063 * bidi.c: Integer size and overflow fixes.
3064 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3065 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3066 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3067 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3068 (bidi_find_other_level_edge):
3069 Use ptrdiff_t instead of EMACS_INT where either will do.
3070 This works better on 32-bit hosts configured --with-wide-int.
3071 (bidi_cache_ensure_space): Check for size-calculation overflow.
3072 Use % rather than repeated addition, for better worst-case speed.
3073 Don't set bidi_cache_size until after xrealloc returns, because it
3074 might not return.
3075 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3076 (bidi_cache_ensure_space): Also check that the bidi cache size
3077 does not exceed that of the largest Lisp string or buffer. See Eli
3078 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3079
5e927815
PE
3080 * alloc.c (__malloc_size_t): Remove.
3081 All uses replaced by size_t. See Andreas Schwab's note
3082 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3083
ca4aa935
PE
3084 * image.c: Improve checking for integer overflow.
3085 (check_image_size): Assume that f is nonnull, since
3086 it is always nonnull in practice. This is one less thing to
3087 worry about when checking for integer overflow later.
3088 (x_check_image_size): New function, which checks for integer
3089 overflow issues inside X.
3090 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3091 This removes the need for a memory_full check.
3092 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3093 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3094 (xbm_read_bitmap_data): Change locals back to 'int', since
3095 their values must fit in 'int'.
3096 (xpm_load_image, png_load, tiff_load):
3097 Invoke x_create_x_image_and_pixmap earlier,
3098 to avoid much needless work if the image is too large.
3099 (tiff_load): Treat overly large images as if
3100 x_create_x_image_and_pixmap failed, not as malloc failures.
3101 (gs_load): Use x_check_image_size.
3102
5f8f9cc2
PE
3103 * gtkutil.c: Omit integer casts.
3104 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3105 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3106
5adf60bc
PE
3107 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3108
c8907a93
PE
3109 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3110 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3111 would wrongly return t on a 64-bit host.
3112
e3c25c68
PE
3113 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3114 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3115 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3116 and therefore cause GCC to emit a bogus diagnostic in some cases.
3117
3f791afe
PE
3118 * image.c: Integer signedness and overflow and related fixes.
3119 This is not an exhaustive set of fixes, but it's time to
3120 record what I've got.
3121 (lookup_pixel_color, check_image_size): Remove redundant decls.
3122 (check_image_size): Don't assume that arbitrary EMACS_INT values
3123 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3124 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3125 (tiff_load, imagemagick_load_image):
3126 Check for overflow in size calculations.
3127 (x_create_x_image_and_pixmap): Remove unnecessary test for
3128 xmalloc returning NULL; that can't happen.
3129 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3130 (xpm_color_bucket): Use better integer hashing function.
3131 (xpm_cache_color): Don't possibly over-allocate memory.
3132 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3133 (gif_memory_source):
3134 Use ptrdiff_t, not int or size_t, to record sizes.
3135 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3136 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3137 either works, as we prefer signed integers.
3138 (tiff_read_from_memory, tiff_write_from_memory):
3139 Return tsize_t, not size_t, since that's what the TIFF API wants.
3140 (tiff_read_from_memory): Don't fail simply because the read would
3141 go past EOF; instead, return a short read.
3142 (tiff_load): Omit no-longer-needed casts.
3143 (Fimagemagick_types): Don't assume size fits into 'int'.
3144
3cc5a532
PE
3145 Improve hashing quality when configured --with-wide-int.
3146 * fns.c (hash_string): New function, taken from sxhash_string.
3147 Do not discard information about ASCII character case; this
3148 discarding is no longer needed.
3149 (sxhash-string): Use it. Change sig to match it. Caller changed.
3150 * lisp.h: Declare it.
3151 * lread.c (hash_string): Remove, since we now use fns.c's version.
3152 The fns.c version returns a wider integer if --with-wide-int is
3153 specified, so this should help the quality of the hashing a bit.
3154
b312a492
PE
3155 * emacs.c: Integer overflow minor fix.
3156 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3157 Define only if GNU_LINUX.
3158 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3159
dfd153ae
PE
3160 * dispnew.c: Integer signedness and overflow fixes.
3161 Remove unnecessary forward decls, that were a maintenance hassle.
3162 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3163 All uses changed.
3164 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3165 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3166 (prepare_desired_row, line_draw_cost):
3167 Use int, not unsigned, where either works.
3168 (save_current_matrix, restore_current_matrix):
3169 Use ptrdiff_t, not size_t, where either works.
3170 (init_display): Check for overflow more accurately, and without
3171 relying on undefined behavior.
3172
a81d11a3
PE
3173 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3174 Remove, replacing with the new symbols in lisp.h. All uses changed.
3175 * fileio.c (make_temp_name):
3176 * filelock.c (lock_file_1, lock_file):
3177 * xdisp.c (message_dolog):
3178 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3179 Use pMd etc. instead.
3180 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3181 replacing the pWIDE etc. symbols removed from editfns.c.
3182
3300e6fd
PE
3183 * keyboard.h (num_input_events): Now uintmax_t.
3184 This is (very slightly) less likely to mess up due to wraparound.
3185 All uses changed.
3186
fd05c7e9
PE
3187 * buffer.c: Integer signedness fixes.
3188 (alloc_buffer_text, enlarge_buffer_text):
3189 Use ptrdiff_t rather than size_t when either will do, as we prefer
3190 signed integers.
3191
903fe15d
PE
3192 * alloc.c: Integer signedness and overflow fixes.
3193 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3194 (__malloc_size_t): Default to size_t, not to int.
3195 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3196 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3197 Prefer ptrdiff_t to size_t when either would do, as we prefer
3198 signed integers.
3199 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3200 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3201 Now const. Initialize with values that are in range even if char
3202 is signed.
3203 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3204 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3205 These functions do the right thing with sizes > 2**32.
3206 (check_depth): Now ptrdiff_t, not int.
3207 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3208 Adjust to new way of storing sizes. Check for size overflow bugs
3209 in rest of code.
3210 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3211 slightly wrong anyway, as it missed one instance of
3212 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3213 (refill_memory_reserve): Omit needless cast to size_t.
3214 (mark_object_loop_halt): Mark as externally visible.
3215
ac82cc6a
PE
3216 * xselect.c: Integer signedness and overflow fixes.
3217 (Fx_register_dnd_atom, x_handle_dnd_message):
3218 Use ptrdiff_t, not size_t, since we prefer signed.
3219 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3220 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3221 x_dnd_atoms_size and x_dnd_atoms_length.
3222
c2d1e36d
PE
3223 * doprnt.c: Prefer signed to unsigned when either works.
3224 * eval.c (verror):
3225 * doprnt.c (doprnt):
3226 * lisp.h (doprnt):
3227 * xdisp.c (vmessage):
3228 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3229 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3230 prefer signed arithmetic to avoid comparison confusion.
3231 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3232 but is a bit tricky.
3233
0e926e56
PE
3234 Assume freestanding C89 headers, string.h, stdlib.h.
3235 * data.c, doprnt.c, floatfns.c, print.c:
3236 Include float.h unconditionally.
3237 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3238 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3239 * regex.c: Likewise for stddef.h, string.h.
3240 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3241 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3242 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3243 (STDC_HEADERS): Remove obsolete defines.
3244 * sysdep.c: Include limits.h unconditionally.
3245
9cfdb3ec
PE
3246 Assume support for memcmp, memcpy, memmove, memset.
3247 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3248 * regex.c (memcmp, memcpy):
3249 Remove; we assume C89 now.
3250
3251 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3252 (__malloc_safe_bcopy): Remove; no longer needed.
3253
cf950e6b 3254 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3255 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3256 well either way, and we prefer signed to unsigned.
3257
dbf38e02
LMI
32582011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3259
3260 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3261 closes the connection while we're reading (bug#9182).
3262
d6f0886c 32632011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3264
d6f0886c
JD
3265 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3266 are specified (Bug#9168).
24e0f6b1 3267
2eb1f9e6
PE
32682011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3271 Found by GCC static checking and --with-wide-int on a 32-bit host.
3272
22381272 32732011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3274
3275 * xdisp.c (compute_display_string_pos): Fix logic of caching
3276 previous display string position. Initialize cached_prev_pos to
3277 -1. Fixes slow-down at the beginning of a buffer.
3278
f25e39b4
EZ
32792011-07-24 Eli Zaretskii <eliz@gnu.org>
3280
3281 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3282 for attrs[LFACE_FONTSET_INDEX].
3283
04c4b52e
PE
32842011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3285
3286 * xml.c (parse_region): Remove unused local
3287 that was recently introduced.
3288
c1734fbd
EZ
32892011-07-23 Eli Zaretskii <eliz@gnu.org>
3290
be18c5a5
EZ
3291 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3292 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3293
c1734fbd
EZ
3294 * xdisp.c (move_it_in_display_line_to): Record the best matching
3295 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3296 exit if none of the characters scanned was an exact match.
3297 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3298 when exact match is impossible due to invisible text, and the
3299 lines are truncated.
3300
a258d627
JD
33012011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3302
3303 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3304 for OSX >= 10.7.
3305
b6d5a689
EZ
33062011-07-22 Eli Zaretskii <eliz@gnu.org>
3307
0f74f785
EZ
3308 Fix a significant slow-down of cursor motion with C-n, C-p,
3309 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3310 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3311 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3312 (next_element_from_buffer): Call compute_stop_pos_backwards to
3313 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3314 base_level_stop.
3315 (reseat): Don't look for prev_stop, as that could mean a very long
3316 run.
3317 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3318 <cached_disp_overlay_modiff>: Cache for last found display string
3319 position.
551918c1 3320 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3321 about the same buffer in the same area of character positions, and
3322 the buffer wasn't changed since the time the display string
3323 position was cached.
551918c1 3324
b2d0c91a
EZ
33252011-07-22 Eli Zaretskii <eliz@gnu.org>
3326
3327 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3328 is an integer, which is important for empty lines. (Bug#9149)
3329
043604ee
CY
33302011-07-22 Chong Yidong <cyd@stupidchicken.com>
3331
3332 * frame.c (Fmodify_frame_parameters): In tty case, update the
3333 default face if necessary (Bug#4238).
3334
da4adb04
CY
33352011-07-21 Chong Yidong <cyd@stupidchicken.com>
3336
3337 * editfns.c (Fstring_to_char): No need to explain what a character
3338 is in the docstring (Bug#6576).
3339
9abd0532
LMI
33402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3341
3342 * xml.c (parse_region): Make sure we always return a tree.
3343
36881d16
HK
33442011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3345
3346 * xml.c (parse_region): If a document contains only comments,
3347 return that, too.
3348
1e98674d
LMI
33492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3350
3351 * xml.c (make_dom): Return comments, too.
3352
590bd467
PE
33532011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3354
3355 Port to OpenBSD.
3356 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3357 and the surrounding thread.
3358 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3359 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3360 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3361 timer goes off.
3362 * s/openbsd.h (BROKEN_SIGIO): Define.
3363 * unexelf.c (unexec) [__OpenBSD__]:
3364 Don't update the .mdebug section of the Alpha COFF symbol table.
3365
f41628b2
LMI
33662011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3367
3368 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3369 (bug#8460).
3370
b59b67c5
PE
33712011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3372
15e3a074
PE
3373 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3374 This fixes some race conditions on the permissions of any newly
3375 created file.
3376
41bed37d
PE
3377 * alloc.c (valid_pointer_p): Use pipe, not open.
3378 This fixes some permissions issues when debugging.
3379
b59b67c5
PE
3380 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3381 If fchown fails to set both uid and gid, try to set just gid,
3382 as that is sometimes allowed. Adjust the file's mode to eliminate
3383 setuid or setgid bits that are inappropriate if fchown fails.
3384
925a6be7
SM
33852011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3386
3387 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3388 to compare Lisp_Objects.
3389 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3390 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3391 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3392
52968808
AS
33932011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3394
0a6a104b
AS
3395 * lread.c (read_integer): Unread even EOF character.
3396 (read1): Likewise. Properly record start position of symbol.
3397
52968808
AS
3398 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3399 symbol character follows.
3400
9e381cdd
PE
34012011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3404 This works around a problem with the previous change to Fcopy_file.
3405 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3406 and without this change, GCC might complain about discarding
3407 fchown's return value.
3408
b5641435
JB
34092011-07-16 Juanma Barranquero <lekktu@gmail.com>
3410
3411 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3412
a8031457
PE
34132011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3416
dd889327
LMI
34172011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3418
750c33f7
LMI
3419 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3420 it's used from the C level.
3421
dd889327
LMI
3422 * process.c: Use the same condition for POLL_FOR_INPUT in both
3423 keyboard.c and process.c (bug#1858).
3424
87e86684
LM
34252011-07-09 Lawrence Mitchell <wence@gmx.li>
3426
3427 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3428 (Fgnutls_boot): Use it.
3429
64348f40
AS
34302011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3431
3432 * doc.c (Fsubstitute_command_keys): Revert last change.
3433
1d698799
LMI
34342011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3435
f863868c
LMI
3436 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3437 quotes the next character, and doesn't affect other longer
3438 sequences (bug#8935).
3439
1d698799
LMI
3440 * lread.c (syms_of_lread): Clarify that is isn't only
3441 `eval-buffer' and `eval-defun' that's affected by
3442 `lexical-binding' (bug#8460).
3443
aa4b6df6
EZ
34442011-07-15 Eli Zaretskii <eliz@gnu.org>
3445
3446 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3447 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3448
5d856da6
PE
34492011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3450
ad6042bb
PE
3451 Fix minor problems found by static checking.
3452 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3453 (elsz): Now a signed constant, not a size_t var. We prefer signed
3454 types to unsigned, to avoid integer comparison confusion. Without
3455 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3456 "cannot optimize loop, the loop counter may overflow", a symptom
3457 of the confusion.
f00bbb22 3458 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3459 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3460
6468f31c
LMI
34612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3462
49080b10
LMI
3463 * search.c (Fre_search_backward): Mention `case-fold-search' in
3464 all the re_search_* functions (bug#8138).
3465
6468f31c
LMI
3466 * keyboard.c (Fopen_dribble_file): Document when the file is
3467 closed (bug#8056).
3468
c965adc5
EZ
34692011-07-14 Eli Zaretskii <eliz@gnu.org>
3470
df9733bf
EZ
3471 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3472 bidi_cache_idx.
3473
0bb23927
EZ
3474 Support bidi reordering of display and overlay strings.
3475 * xdisp.c (compute_display_string_pos)
3476 (compute_display_string_end): Accept additional argument STRING.
3477 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3478 (reseat_to_string): Initialize bidi_it->string.s and
3479 bidi_it->string.schars.
3480 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3481 NULL (avoids a crash in bidi_paragraph_init).
3482 Initialize itb.string.lstring.
0bb23927
EZ
3483 (init_iterator): Call bidi_init_it only of a valid
3484 buffer position was specified. Initialize paragraph_embedding to
3485 L2R.
3486 (reseat_to_string): Initialize the bidi iterator.
3487 (display_string): If we need to ignore text properties of
3488 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3489 original value of -1 will not work with bidi.)
3490 (compute_display_string_pos): First arg is now struct
3491 `text_pos *'; all callers changed. Support display properties on
3492 Lisp strings.
3493 (compute_display_string_end): Support display properties on Lisp
3494 strings.
3495 (init_iterator, reseat_1, reseat_to_string): Initialize the
3496 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3497 when iterating on a string not from display properties).
640c8776
SM
3498 (compute_display_string_pos, compute_display_string_end):
3499 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3500 arrow keys.
3501 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3502 base_level_stop; instead, set base_level_stop to BEGV.
3503 Fixes crashes in vertical-motion.
0bb23927
EZ
3504 (next_element_from_buffer): Improve commentary for when
3505 the iterator is before prev_stop.
3506 (init_iterator): Initialize bidi_p from the default value of
3507 bidi-display-reordering, not from buffer-local value. Use the
3508 buffer-local value only if initializing for buffer iteration.
3509 (handle_invisible_prop): Support invisible properties on strings
3510 that are being bidi-reordered.
3511 (set_iterator_to_next): Support bidi reordering of C strings and
3512 Lisp strings.
3513 (next_element_from_string): Support bidi reordering of Lisp
3514 strings.
3515 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3516 (display_string): Support display of R2L glyph rows.
3517 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3518 (init_iterator): Don't initialize it->bidi_p for strings
3519 here.
3520 (reseat_to_string): Initialize it->bidi_p for strings here.
3521 (next_element_from_string, next_element_from_c_string)
3522 (next_element_from_buffer): Add xassert's for correspondence
3523 between IT's object being iterated and it->bidi_it.string
3524 structure.
3525 (face_before_or_after_it_pos): Support bidi iteration.
3526 (next_element_from_c_string): Handle the case of the first string
3527 character that is not the first one in the visual order.
3528 (get_visually_first_element): New function, refactored from common
3529 parts of next_element_from_buffer, next_element_from_string, and
3530 next_element_from_c_string.
3531 (tool_bar_lines_needed, redisplay_tool_bar)
3532 (display_menu_bar): Force left-to-right direction. Add a FIXME
3533 comment for making that be controlled by a user option.
3534 (push_it, pop_it): Save and restore the state of the
3535 bidi iterator. Save and restore the bidi_p flag.
3536 (pop_it): Iterate out of display property for string iteration as
3537 well.
3538 (iterate_out_of_display_property): Support iteration over strings.
3539 (handle_single_display_spec): Set up it->bidi_it for iteration
3540 over a display string, and call bidi_init_it.
3541 (handle_single_display_spec, next_overlay_string)
3542 (get_overlay_strings_1, push_display_prop): Set up the bidi
3543 iterator for displaying display or overlay strings.
3544 (forward_to_next_line_start): Don't use the shortcut if
3545 bidi-iterating.
3546 (back_to_previous_visible_line_start): If handle_display_prop
3547 pushed the iterator stack, restore the internal state of the bidi
3548 iterator by calling bidi_pop_it same number of times.
3549 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3550 and we are bidi-iterating, don't decrement the iterator position;
3551 instead, set the first_elt flag in the bidi iterator, to produce
3552 the same effect.
3553 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3554 (push_display_prop): xassert that we are iterating a buffer.
3555 (push_it, pop_it): Save and restore paragraph_embedding member.
3556 (handle_single_display_spec, next_overlay_string)
3557 (get_overlay_strings_1, reseat_1, reseat_to_string)
3558 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3559 correctly. Don't assume unibyte strings are not bidi-reordered.
3560 (compute_display_string_pos)
3561 (compute_display_string_end): Fix handling the case of C string.
3562 (push_it, pop_it): Save and restore from_disp_prop_p.
3563 (handle_single_display_spec, push_display_prop): Set the
3564 from_disp_prop_p flag.
3565 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3566 (pop_it): Call iterate_out_of_display_property only if we are
3567 popping after iteration over a string that came from a display
3568 property. Fix a typo in popping stretch info. Add an assertion
3569 for verifying that the iterator position is in sync with the bidi
3570 iterator.
3571 (handle_single_display_spec, get_overlay_strings_1)
3572 (push_display_prop): Fix initialization of paragraph direction for
3573 string when that of the parent object is not yet determined.
3574 (reseat_1): Call bidi_init_it to resync the bidi
3575 iterator with IT's position. (Bug#7616)
3576 (find_row_edges): If ROW->start.pos gives position
3577 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3578 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3579 Reset the from_disp_prop_p flag.
3580 (SAVE_IT, RESTORE_IT): New macros.
3581 (pos_visible_p, face_before_or_after_it_pos)
3582 (back_to_previous_visible_line_start)
3583 (move_it_in_display_line_to, move_it_in_display_line)
3584 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3585 (try_scrolling, redisplay_window, display_line): Use them when
3586 saving a temporary copy of the iterator and restoring it back.
3587 (back_to_previous_visible_line_start, reseat_1)
3588 (init_iterator): Empty the bidi cache "stack".
3589 (move_it_in_display_line_to): If iterator ended up at
3590 EOL, but we never saw any buffer positions smaller than
3591 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3592 motion in bidi-reordered lines.
3593 (move_it_in_display_line_to): Record prev_method and prev_pos
3594 immediately before the call to set_iterator_to_next. Fixes cursor
3595 motion in bidi-reordered lines with stretch glyphs and strings
3596 displayed in margins. (Bug#8133) (Bug#8867)
3597 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3598 TO_CHARPOS.
640c8776
SM
3599 (pos_visible_p): Support positions in bidi-reordered lines.
3600 Save and restore bidi cache.
0bb23927
EZ
3601
3602 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3603 (bidi_paragraph_info): Delete unused struct.
3604 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3605 (bidi_cache_start): New variable.
3606 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3607 to zero.
3608 (bidi_cache_fetch_state, bidi_cache_search)
3609 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3610 (bidi_cache_find, bidi_peek_at_next_level)
3611 (bidi_level_of_next_char, bidi_find_other_level_edge)
3612 (bidi_move_to_visually_next): Compare cache index with
3613 bidi_cache_start rather than with zero.
3614 (bidi_fetch_char): Accept new argument STRING; all callers
3615 changed. Support iteration over a string. Support strings with
3616 display properties. Support unibyte strings. Fix the type of
3617 `len' according to what STRING_CHAR_AND_LENGTH expects.
3618 (bidi_paragraph_init, bidi_resolve_explicit_1)
3619 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3620 (bidi_level_of_next_char, bidi_move_to_visually_next):
3621 Support iteration over a string.
0bb23927
EZ
3622 (bidi_set_sor_type, bidi_resolve_explicit_1)
3623 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3624 can now be zero (for strings); special values 0 and -1 were
3625 changed to -1 and -2, respectively.
3626 (bidi_char_at_pos): New function.
3627 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3628 Call it instead of FETCH_MULTIBYTE_CHAR.
3629 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3630 initialized to valid values.
3631 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3632 values.
3633 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3634 the test for valid cached positions. Fix the logic for looking up
3635 the sentinel state in the cache. GCPRO the Lisp string we are
3636 iterating.
3637 (bidi_push_it, bidi_pop_it): New functions.
3638 (bidi_initialize): Initialize the bidi cache start stack pointer.
3639 (bidi_cache_ensure_space): New function, refactored from part of
3640 bidi_cache_iterator_state. Don't assume the required size is just
3641 one BIDI_CACHE_CHUNK away.
3642 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3643 (bidi_count_bytes, bidi_char_at_pos): New functions.
3644 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3645 always valid if bidi_cache_idx is valid.
3646 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3647 is valid if it's going to be used.
3648 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3649 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3650 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3651 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3652 (bidi_find_other_level_edge, bidi_cache_start_stack):
3653 All variables related to cache indices are now EMACS_INT.
c965adc5 3654
0bb23927
EZ
3655 * dispextern.h (struct bidi_string_data): New structure.
3656 (struct bidi_it): New member `string'. Make flag members be 1-bit
3657 fields, and put them last in the struct.
640c8776
SM
3658 (compute_display_string_pos, compute_display_string_end):
3659 Update prototypes.
0bb23927
EZ
3660 (bidi_push_it, bidi_pop_it): Add prototypes.
3661 (struct iterator_stack_entry): New members bidi_p,
3662 paragraph_embedding, and from_disp_prop_p.
3663 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3664 (bidi_shelve_cache, bidi_unshelve_cache):
3665 Declare prototypes.
0bb23927
EZ
3666
3667 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3668 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3669 and vector-like objects.
3670
3671 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3672 cache around display iteration.
3673
3674 * window.c (Fwindow_end, window_scroll_pixel_based)
3675 (displayed_window_lines, Frecenter): Save and restore the bidi
3676 cache around display iteration.
3677
3bbd2265
LMI
36782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3679
3680 * editfns.c (Fdelete_region): Clarify the use of the named
3681 parameters (bug#6788).
3682
adc47434
MR
36832011-07-14 Martin Rudalics <rudalics@gmx.at>
3684
3685 * indent.c (Fvertical_motion): Set and restore w->pointm when
3686 saving and restoring the window's buffer (Bug#9006).
3687
837c31f8
LMI
36882011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3689
3690 * editfns.c (Fstring_to_char): Clarify just what is returned
3691 (bug#6576). Text by Eli Zaretskii.
3692
ac389d0c
JB
36932011-07-13 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3696
0be0ce47
EZ
36972011-07-13 Eli Zaretskii <eliz@gnu.org>
3698
3699 * buffer.c (mmap_find): Fix a typo.
3700
cd18e7e3
JB
37012011-07-13 Johan Bockgård <bojohan@gnu.org>
3702
3703 Fix execution of x selection hooks.
3704 * xselect.c (Qx_lost_selection_functions)
3705 (Qx_sent_selection_functions): New vars.
3706 (syms_of_xselect): DEFSYM them.
3707 (x_handle_selection_request): Pass Qx_sent_selection_functions
3708 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3709 (x_handle_selection_clear,x_clear_frame_selections):
3710 Pass Qx_lost_selection_functions rather than
3711 Vx_lost_selection_functions to Frun_hook_with_args.
3712
47ea7f44
PE
37132011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3714
ac389d0c 3715 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3716 The old code sometimes used this field without initializing it.
3717
47ea7f44
PE
3718 * alloc.c (gc_sweep): Don't read past end of array.
3719 In theory, the old code could also have corrupted Emacs internals,
3720 though it'd be very unlikely.
3721
bc985c87
AS
37222011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3723
3724 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3725 argument. (Bug#4026)
bc985c87 3726
0cf34688
LMI
37272011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3728
b3dadd76
LMI
3729 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3730 key" (bug#4257).
3731
0cf34688
LMI
3732 * window.c (Fset_window_start): Doc fix (bug#4199).
3733 (Fset_window_hscroll): Ditto.
3734
270768cd
PE
37352011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3736
077e3dda 3737 Fix minor new problems caught by GCC 4.6.1.
270768cd 3738 * term.c (init_tty): Remove unused local.
490011a6 3739 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3740 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3741 not used otherwise.
270768cd 3742
b1f58454
CY
37432011-07-12 Chong Yidong <cyd@stupidchicken.com>
3744
3745 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3746
22b9578d
LMI
37472011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3748
6e70ab07
LMI
3749 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3750 are the mini-buffer and the echo area (bug#3320).
3751
22b9578d
LMI
3752 * term.c (init_tty): Remove support for supdup, c10 and perq
3753 terminals, which are no longer supported (bug#1482).
3754
8974cc9f
JB
37552011-07-10 Johan Bockgård <bojohan@gnu.org>
3756
3757 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3758
a560d974
JD
37592011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3760
3761 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3762 for non-popups (Bug#3642).
3763
1dae0f0a
AS
37642011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3765
268c2c36 3766 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3767 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3768 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3769 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3770 * data.c (fmod): Likewise.
3771 * dispnew.c (swap_glyphs_in_rows): Likewise.
3772 * emacs.c (memory_warning_signal): Likewise.
3773 * floatfns.c (float_error): Likewise.
3774 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3775 (otf_open, font_otf_capability, generate_otf_features)
3776 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3777 Likewise.
3778 * image.c (pbm_read_file): Likewise.
3779 * indent.c (string_display_width): Likewise.
3780 * intervals.c (check_for_interval, search_for_interval)
3781 (inc_interval_count, count_intervals, root_interval)
3782 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3783 * lread.c (defalias): Likewise.
268c2c36 3784 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3785 * regex.c (set_image_of_range_1, set_image_of_range)
3786 (regex_grow_registers): Likewise.
3787 * sysdep.c (strerror): Likewise.
3788 * termcap.c (valid_filename_p, tprint, main): Likewise.
3789 * tparam.c (main): Likewise.
3790 * unexhp9k800.c (run_time_remap, save_data_space)
3791 (update_file_ptrs, read_header, write_header, calculate_checksum)
3792 (copy_file, copy_rest, display_header): Likewise.
3793 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3794 Likewise.
3795 * xdisp.c (check_it): Likewise.
3796 * xfaces.c (register_color, unregister_color, unregister_colors):
3797 Likewise.
3798 * xfns.c (print_fontset_result): Likewise.
3799 * xrdb.c (member, fatal, main): Likewise.
3800
99033785
PE
38012011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3802
3803 Fix minor problems found by static checking (Bug#9031).
3804 * chartab.c (char_table_set_range, map_sub_char_table):
3805 Remove unused locals.
3806 (uniprop_table): Now static.
3807 * composite.c (_work_char): Remove unused static var.
3808
9cb2ac56
JB
38092011-07-09 Juanma Barranquero <lekktu@gmail.com>
3810
3811 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3812
f25661f0
JD
38132011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3814
3815 * gtkutil.c (qttip_cb): Remove code without function.
3816
8278c4fe
EZ
38172011-07-09 Eli Zaretskii <eliz@gnu.org>
3818
3819 * w32.c (pthread_sigmask): New stub.
3820
1692ae2d 38212011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3822
8a6ebd58 3823 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3824 sigprocmask is portable only for single-threaded applications, and
3825 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3826 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3827 (LIBES): Use it.
3828 * callproc.c (Fcall_process):
3829 * process.c (create_process):
3830 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3831 Use pthread_sigmask, not sigprocmask.
123403e4 3832
1b854618
JD
38332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3834
3835 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3836 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3837 wrong (Bug#8591).
3838
3fe4b549
JD
38392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3840
0ce7e563
JD
3841 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3842 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3843 (xg_hide_tooltip): Fix comment.
3844
3fe4b549
JD
3845 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3846 in registerServicesMenuSendTypes.
3847 (validRequestorForSendType): Don't check ns_return_types.
3848
3849 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3850 ns_return_type.
3851
5df75e47
JR
38522011-07-08 Jason Rumney <jasonr@gnu.org>
3853
22610910
JR
3854 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3855 SH_SHOW for hidden windows (Bug#5482).
3856
5df75e47
JR
3857 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3858 frame struct members of non-existent frames (Bug#6284).
3859
699c10bd
JD
38602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3861
4393663b
JD
3862 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3863 variable firstTime not needed on OSX >= 10.6.
3864 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3865 >= 10.5. Use setKnobProportion, setDoubleValue.
3866
3867 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3868 (MAC_OS_X_VERSION_10_5): Define if not defined.
3869 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3870 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3871 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3872
3873 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3874 cString and lossyCString on OSX >= 10.4
3875
58179cce 3876 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3877 sizeToFit on OSX >= 10.2.
3878
3879 * nsimage.m (allocInitFromFile): Don't use deprecated method
3880 bestRepresentationForDevice on OSX >= 10.6.
3881
3882 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3883 to avoid warning.
3884
3885 * emacs.c: Declare unexec_init_emacs_zone.
3886
a63e0781
JD
3887 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3888
699c10bd
JD
3889 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3890
3891 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3892 on svcsMenu (Bug#8842).
3893
3894 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3895 ns_return_types.
3896 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3897
3898 * nsterm.m (QUTF8_STRING): Declare.
3899 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3900 (validRequestorForSendType): Return type is (id).
3901 Change indexOfObjectIdenticalTo to indexOfObject.
3902 Check if we have local selection before returning self (Bug#8842).
3903 (writeSelectionToPasteboard): Put local selection into paste board
3904 if we have a local selection (Bug#8842).
3905 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3906
3907 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3908 (ns_get_local_selection): Declare.
3909
54e10184
LMI
39102011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3911
9888ff71
LMI
3912 * keymap.c (describe_map_tree): Don't insert a double newline at
3913 the end of the buffer (bug#1169) and return whether we inserted
3914 something.
3915
54e10184
LMI
3916 * callint.c (Fcall_interactively): Change "reading args" to
3917 "providing args" to try to clarify what it does (bug#1010).
3918
15fa4783
KH
39192011-07-07 Kenichi Handa <handa@m17n.org>
3920
3921 * composite.c (composition_compute_stop_pos): Ignore a static
3922 composition starting before CHARPOS (Bug#8915).
3923
3924 * xdisp.c (handle_composition_prop): Likewise.
3925
a8815b00
EZ
39262011-07-07 Eli Zaretskii <eliz@gnu.org>
3927
3928 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3929 (Bug#9015)
3930
ef7b981d 39312011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3932
3933 * character.h (unicode_category_t): New enum type.
3934
3935 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3936 (Qchar_code_property_table): New variable.
3937 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3938 (UNIPROP_COMPRESSED_FORM_P): New macros.
3939 (char_table_ascii): Uncompress the compressed values.
3940 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3941 Uncompress the compressed values.
ac389d0c 3942 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3943 (char_table_ref_and_range): Uncompress the compressed values.
3944 (sub_char_table_set): New arg is_uniprop. Callers changed.
3945 Uncompress the compressed values.
3946 (sub_char_table_set_range): Args changed. Callers changed.
3947 (char_table_set_range): Adjuted for the above change.
3948 (map_sub_char_table): Delete args default_val and parent. Add arg
3949 top. Give decoded values to a Lisp function.
640c8776 3950 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3951 values to a Lisp function. Gcpro more variables.
3952 (uniprop_table_uncompress)
3953 (uniprop_decode_value_run_length): New functions.
3954 (uniprop_decoder, uniprop_decoder_count): New variables.
3955 (uniprop_get_decoder, uniprop_encode_value_character)
3956 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3957 New functions.
3958 (uniprop_encoder, uniprop_encoder_count): New variables.
3959 (uniprop_get_encoder, uniprop_table)
3960 (Funicode_property_table_internal, Fget_unicode_property_internal)
3961 (Fput_unicode_property_internal): New functions.
3962 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3963 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3964 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3965 char-code-property-alist.
3966
640c8776 3967 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3968 Vunicode_category_table.
3969
640c8776 3970 * font.c (font_range): Adjust for the change of
c805dec0
KH
3971 Vunicode_category_table.
3972
76b397fb
DN
39732011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3974
3975 * m/iris4d.h: Remove file, move contents ...
3976 * s/irix6-5.h: ... here.
3977
22b4128e
PE
39782011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3981 * alloc.c (mark_buffer):
3982 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3983 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3984 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3985 This isn't true in general, and it's particularly not true
3986 if Emacs is configured with --with-wide-int.
3987 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3988 New macros, used in the buffer.c change.
3989
869795d6
JD
39902011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3991
3992 * xsettings.c: Use both GConf and GSettings if both are available.
3993 (store_config_changed_event): Add comment.
3994 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3995 (store_tool_bar_style_changed): New functions.
5e617bc2 3996 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3997 (struct xsettings): Move font inside HAVE_XFT.
3998 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3999 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4000 Move inside HAVE_XFT.
640c8776 4001 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4002 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4003 also.
4004 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4005 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4006 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4007 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4008 (parse_settings): Move check for font inside HAVE_XFT.
4009 (read_settings, apply_xft_settings): Add comment.
4010 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4011 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4012 call store_font_name_changed.
4013 (xft_settings_event): Add comment.
4014 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4015 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4016 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4017 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4018 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4019 (xsettings_get_system_font, xsettings_get_system_normal_font):
4020 Add comment.
869795d6 4021
d8ed26bd
PE
40222011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4023
4024 Random fixes. E.g., (random) never returned negative values.
4025 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4026 subseconds part to the entropy, as that's a bit more random.
4027 Prefer signed to unsigned, since the signedness doesn't matter and
4028 in general we prefer signed. When given a limit, use a
4029 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4030 latter isn't right if USE_2_TAGS_FOR_INTS.
4031 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4032 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4033
cabf1cac
SM
40342011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4035
4036 * textprop.c (text_property_stickiness):
4037 Obey Vtext_property_default_nonsticky.
4038 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4039 * w32fns.c (syms_of_w32fns):
4040 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4041
6e9b2be9
PE
40422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4043
4044 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4045 This is more efficient than Ffile_directory_p and avoids a minor race.
4046
90186c68
LMI
40472011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4048
7c301272
LMI
4049 * buffer.c (Foverlay_put): Say what the return value is
4050 (bug#7835).
4051
c4f2d8d4
LMI
4052 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4053 is a directory before asking whether to use the file name
4054 (bug#7564).
ad637907
LMI
4055 (barf_or_query_if_file_exists): Make the "File is a directory"
4056 error be more correct.
c4f2d8d4 4057
90186c68
LMI
4058 * fns.c (Frequire): Remove the mention of the .gz files, since
4059 that's installation-specific, but keep the mention of
4060 `get-load-suffixes'.
4061
da64016e
PE
40622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4065 Report string overflow if the output is too long.
4066
7d47b580
JB
40672011-07-04 Juanma Barranquero <lekktu@gmail.com>
4068
a555cb87
JB
4069 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4070 (syms_of_gnutls): Remove duplicate DEFSYM for
4071 Qgnutls_bootprop_verify_hostname_error, an error for
4072 Qgnutls_bootprop_verify_error (which is no longer used).
4073
7d47b580
JB
4074 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4075 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4076 Also (re)move comments that are misplaced or no longer relevant.
4077
1e49bfab
LMI
40782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4079
4080 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4081
1485f4c0
CY
40822011-07-03 Chong Yidong <cyd@stupidchicken.com>
4083
4084 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4085 and background color parameters if they have been changed.
4086
a9ab721e
LMI
40872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4088
4089 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4090
cf7cff57
PE
40912011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4092
2e13213d
PE
4093 * xsettings.c (SYSTEM_FONT): Define only when used.
4094 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4095
cf7cff57
PE
4096 * keymap.c (access_keymap_1): Now static.
4097
7a8e04f7
CY
40982011-07-02 Chong Yidong <cyd@stupidchicken.com>
4099
4100 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4101 leave any prefix arg for the up event (Bug#1586).
4102
61352f62
LMI
41032011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4104
69bb1ef7
LMI
4105 * lread.c (syms_of_lread): Mention single symbols defined by
4106 `defvar' or `defconst' (bug#7154).
4107
61352f62 4108 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4109 (Frequire): Mention get-load-suffixes.
61352f62 4110
28545e04
MR
41112011-07-02 Martin Rudalics <rudalics@gmx.at>
4112
4113 * window.h (window): Remove clone_number slot.
4114 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4115 Remove.
4116 (make_parent_window, make_window, saved_window)
4117 (Fset_window_configuration, save_window_save): Don't deal with
4118 clone numbers.
4119 * buffer.c (Qclone_number): Remove declaration.
4120 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4121
3349e122
SM
41222011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4123
4124 Add multiple inheritance to keymaps.
4125 * keymap.c (Fmake_composed_keymap): New function.
4126 (Fset_keymap_parent): Simplify.
4127 (fix_submap_inheritance): Remove.
4128 (access_keymap_1): New function extracted from access_keymap to handle
4129 embedded parents and handle lists of maps.
4130 (access_keymap): Use it.
4131 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4132 (Fcopy_keymap): Handle embedded parents.
4133 (Fcommand_remapping, define_as_prefix): Simplify.
4134 (Fkey_binding): Simplify.
4135 (syms_of_keymap): Move minibuffer-local-completion-map,
4136 minibuffer-local-filename-completion-map,
4137 minibuffer-local-must-match-map, and
4138 minibuffer-local-filename-must-match-map to Elisp.
4139 (syms_of_keymap): Defsubr make-composed-keymap.
4140 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4141 (parse_menu_item): Trivial simplification.
4142
3279eb87
GM
41432011-07-01 Glenn Morris <rgm@gnu.org>
4144
4145 * Makefile.in (SETTINGS_LIBS): Fix typo.
4146
4550efdf
KI
41472011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4148
4149 * coding.c (Fencode_coding_string): Record the last coding system
4150 used, as the function doc string says (bug#8738).
4151
0949d2b6
JD
41522011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4153
4154 * xsettings.c (store_monospaced_changed): Take new font as arg and
4155 check for change against current_mono_font.
4156 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4157 (emacs_settings_constructor, emacs_settings_get_property)
4158 (emacs_settings_set_property, emacs_settings_class_init)
4159 (emacs_settings_init, gsettings_obj): Remove.
4160 (something_changedCB): New function for HAVE_GSETTINGS.
4161 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4162 with value as argument.
4163 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4164 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4165 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4166 "changed".
4167
4168 * xgselect.c: Add defined (HAVE_GSETTINGS).
4169 (xgselect_initialize): Ditto.
4170
4171 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4172 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4173 xg_select.
4174
bbc6b304
PE
41752011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4176
4177 * eval.c (struct backtrace): Simplify and port the data structure.
4178 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4179 signed bit field, as this assumption is not portable and it makes
4180 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4181 "char debug_on_exit : 1" as this is not portable either; instead,
4182 use the portable "unsigned int debug_on_exit : 1". Remove unused
4183 member evalargs. Remove obsolete comments about cc bombing out.
4184
9851bfc5
JD
41852011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4186
51bb811f 4187 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4188 Let HAVE_GSETTINGS override HAVE_GCONF.
4189 (store_monospaced_changed): New function.
4190 (EMACS_SETTINGS): A new type derived from GObject to handle
4191 GSettings notifications.
4192 (emacs_settings_constructor, emacs_settings_get_property)
4193 (emacs_settings_set_property, emacs_settings_class_init):
4194 New functions.
4195 (gsettings_client, gsettings_obj): New variables.
4196 (GSETTINGS_SCHEMA): New define.
4197 (something_changedCB): Call store_monospaced_changed.
4198 (init_gsettings): New function.
4199 (xsettings_initialize): Call init_gsettings.
4200 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4201 to NULL.
4202
640c8776 4203 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4204 GCONF_CFLAGS/LIBS.
4205
5386012d
MR
42062011-06-29 Martin Rudalics <rudalics@gmx.at>
4207
4208 * window.c (resize_root_window, grow_mini_window)
4209 (shrink_mini_window): Rename Qresize_root_window to
4210 Qwindow_resize_root_window and Qresize_root_window_vertically to
4211 Qwindow_resize_root_window_vertically.
4212
f13e0b08
PE
42132011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4214
4215 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4216
94515237
JB
42172011-06-27 Juanma Barranquero <lekktu@gmail.com>
4218
4219 * makefile.w32-in: Redesign dependencies so they reflect more
4220 clearly which files are directly included by each source file,
4221 and not through other includes.
4222
e43b6e43
MR
42232011-06-27 Martin Rudalics <rudalics@gmx.at>
4224
4225 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4226 (sort_overlays, overlay_strings): When an overlay's clone number
4227 matches the window's clone number process the overlay even if
4228 the overlay's window property doesn't match the current window.
4229
d68443dc
MR
4230 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4231 (Fwindow_hchild): Rename to Fwindow_left_child.
4232 (Fwindow_next): Rename to Fwindow_next_sibling.
4233 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4234 (resize_window_check): Rename to window_resize_check.
4235 (resize_window_apply): Rename to window_resize_apply.
4236 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4237 (Fdelete_other_windows_internal, resize_frame_windows)
4238 (Fsplit_window_internal, Fdelete_window_internal)
4239 (grow_mini_window, shrink_mini_window)
4240 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4241
c7e73be5
JD
42422011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4243
4244 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4245 (emacs_fixed_set_min_size): Remove.
4246 (emacs_fixed_new): Take frame as argument.
4247
4248 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4249 (_EmacsFixedPrivate): Remove minwidth/height.
4250 Add struct frame *f.
4251 (emacs_fixed_init): Initialize priv->f.
4252 (get_parent_class, emacs_fixed_set_min_size): Remove.
4253 (emacs_fixed_new): Set priv->f to argument.
4254 (emacs_fixed_get_preferred_width)
4255 (emacs_fixed_get_preferred_height): Use min_width/height from
4256 frames size_hint to set minimum and natural (Bug#8919).
4257 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4258 and use min_width/height from frames size_hint to set
4259 min_width/height (Bug#8919).
4260
4261 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4262 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4263 Fix indentation.
c7e73be5 4264
cf99dcf8
EZ
42652011-06-26 Eli Zaretskii <eliz@gnu.org>
4266
4267 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4268 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4269 called at ZV.
4270
029529ac
CY
42712011-06-26 Chong Yidong <cyd@stupidchicken.com>
4272
4273 * process.c (wait_reading_process_output): Bypass select if
4274 waiting for a cell while ignoring keyboard input, and input is
4275 pending. Suggested by Jan Djärv (Bug#8869).
4276
7a7ef429
PE
42772011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 Use gnulib's dup2 module instead of rolling our own.
4280 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4281
11fdef7d 42822011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4283
4284 * dispnew.c (scrolling_window): Before scrolling, turn off a
4285 mouse-highlight in the window being scrolled.
4286
cd3520a4
JB
42872011-06-24 Juanma Barranquero <lekktu@gmail.com>
4288
4289 Move DEFSYM to lisp.h and use everywhere.
4290
4291 * character.h (DEFSYM): Move declaration...
4292 * lisp.h (DEFSYM): ...here.
4293
4294 * gnutls.c:
4295 * minibuf.c:
4296 * w32menu.c:
4297 * w32proc.c:
4298 * w32select.c: Don't include character.h.
4299
4300 * alloc.c (syms_of_alloc):
4301 * buffer.c (syms_of_buffer):
4302 * bytecode.c (syms_of_bytecode):
4303 * callint.c (syms_of_callint):
4304 * casefiddle.c (syms_of_casefiddle):
4305 * casetab.c (init_casetab_once):
4306 * category.c (init_category_once, syms_of_category):
4307 * ccl.c (syms_of_ccl):
4308 * cmds.c (syms_of_cmds):
4309 * composite.c (syms_of_composite):
4310 * dbusbind.c (syms_of_dbusbind):
4311 * dired.c (syms_of_dired):
4312 * dispnew.c (syms_of_display):
4313 * doc.c (syms_of_doc):
4314 * editfns.c (syms_of_editfns):
4315 * emacs.c (syms_of_emacs):
4316 * eval.c (syms_of_eval):
4317 * fileio.c (syms_of_fileio):
4318 * fns.c (syms_of_fns):
4319 * frame.c (syms_of_frame):
4320 * fringe.c (syms_of_fringe):
4321 * insdel.c (syms_of_insdel):
4322 * keymap.c (syms_of_keymap):
4323 * lread.c (init_obarray, syms_of_lread):
4324 * macros.c (syms_of_macros):
4325 * msdos.c (syms_of_msdos):
4326 * print.c (syms_of_print):
4327 * process.c (syms_of_process):
4328 * search.c (syms_of_search):
4329 * sound.c (syms_of_sound):
4330 * syntax.c (init_syntax_once, syms_of_syntax):
4331 * terminal.c (syms_of_terminal):
4332 * textprop.c (syms_of_textprop):
4333 * undo.c (syms_of_undo):
4334 * w32.c (globals_of_w32):
4335 * window.c (syms_of_window):
4336 * xdisp.c (syms_of_xdisp):
4337 * xfaces.c (syms_of_xfaces):
4338 * xfns.c (syms_of_xfns):
4339 * xmenu.c (syms_of_xmenu):
4340 * xsettings.c (syms_of_xsettings):
4341 * xterm.c (syms_of_xterm): Use DEFSYM.
4342
4228cf16
TZ
43432011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4344
cd3520a4 4345 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4346
7fcccf1e
PE
43472011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4348
7efb4e0e
PE
4349 Integer and buffer overflow fixes (Bug#8873).
4350
ff5844ad
PE
4351 * print.c (printchar, strout): Check for string overflow.
4352 (PRINTPREPARE, printchar, strout):
4353 Don't set size unless allocation succeeds.
4354
90532f02
PE
4355 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4356 for sizes. Check for string overflow more accurately.
4357 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4358
6d84508d
PE
4359 * macros.c: Integer and buffer overflow fixes.
4360 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4361 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4362 Use ptrdiff_t, not int, for sizes.
4363 Don't increment bufsize until after realloc succeeds.
4364 Check for size-calculation overflow.
4365 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4366
437b2cb4
PE
4367 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4368
8b9ac8b4
PE
4369 * lread.c: Integer overflow fixes.
4370 (read_integer): Radix is now EMACS_INT, not int,
4371 to improve quality of diagnostics for out-of-range radices.
4372 Calculate buffer size correctly for out-of-range radices.
4373 (read1): Check for integer overflow in radices, and in
4374 read-circle numbers.
82cb60d3
PE
4375 (read_escape): Avoid int overflow.
4376 (Fload, openp, read_buffer_size, read1)
4377 (substitute_object_recurse, read_vector, read_list, map_obarray):
4378 Use ptrdiff_t, not int, for sizes.
4379 (read1): Use EMACS_INT, not int, for sizes.
20270765 4380 Check for size overflow.
8b9ac8b4 4381
7fcccf1e
PE
4382 * image.c (cache_image): Check for size arithmetic overflow.
4383
bfbbd7e7
PE
4384 * lread.c: Integer overflow issues.
4385 (saved_doc_string_size, saved_doc_string_length)
4386 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4387 Now ptrdiff_t, not int.
4388 (read1): Don't assume doc string length fits in int. Check for
4389 out-of-range doc string lengths.
4390 (read_list): Don't assume file position fits in int.
39019e54 4391 (read_escape): Check for hex character overflow.
bfbbd7e7 4392
4e323265
LL
43932011-06-22 Leo Liu <sdl.web@gmail.com>
4394
4395 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4396 Move to minibuffer.el.
4397
85fece3e
PE
43982011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4399
20b84ce9 4400 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4401 The following patches are for when GLYPH_DEBUG && !XASSERT.
4402 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4403 * dispnew.c (flush_stdout):
4404 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4405 Mark as externally visible.
4406 * dispnew.c (check_window_matrix_pointers): Now static.
4407 * dispnew.c (window_to_frame_vpos):
4408 * xfns.c (unwind_create_frame):
4409 * xterm.c (x_check_font): Remove unused local.
4410 * scroll.c (CHECK_BOUNDS):
4411 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4412 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4413 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4414 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4415 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4416 Now static.
4417 (debug_method_add): Use va_list and vsprintf rather than relying
4418 on undefined behavior with wrong number of arguments.
4419 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4420 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4421 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4422 since we're not interested in debugging glyphs with old libraries.
4423 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4424 GCC 4.6.0's static checking.
4425
0766b489
PE
44262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4427
31fd4b32
PE
4428 Integer overflow and signedness fixes (Bug#8873).
4429 A few related buffer overrun fixes, too.
4430
b79e8648
PE
4431 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4432
0766b489
PE
4433 * dispextern.h (struct face.stipple):
4434 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4435 (x_bitmap_mask, x_allocate_bitmap_record)
4436 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4437 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4438 (x_create_bitmap_from_xpm_data):
4439 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4440 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4441 (.bitmaps_last):
4442 * xfaces.c (load_pixmap):
4443 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4444 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4445 (.bitmaps_last, struct x_output.icon_bitmap):
4446 Use ptrdiff_t, not int, for bitmap indexes.
4447 (x_allocate_bitmap_record): Check for size overflow.
4448 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4449
b081724f
PE
4450 Use ptrdiff_t, not int, for overlay counts.
4451 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4452 * editfns.c (overlays_around, get_pos_property):
4453 * textprop.c (get_char_property_and_overlay):
4454 * xdisp.c (next_overlay_change, note_mouse_highlight):
4455 * xfaces.c (face_at_buffer_position):
21514da7
PE
4456 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4457 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4458 (Fnext_overlay_change, Fprevious_overlay_change)
4459 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4460 Use ptrdiff_t, not int, for sizes.
21514da7 4461 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4462
3de73e5e
PE
4463 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4464
2606c57b
PE
4465 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4466 (x_session_initialize): Do not assume string length fits in int.
4467
aaafe47a
PE
4468 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4469 This is unlikely, but can occur if DPI is outlandish.
4470
2674ddc8 4471 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4472 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4473
28154962
PE
4474 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4475 * xrdb.c (magic_file_p, search_magic_path):
4476 Omit last arg SUFFIX; it was always 0. All callers changed.
4477 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4478
7de51af5
PE
4479 * xfont.c (xfont_match): Avoid need for strlen.
4480
25ed6cc3
PE
4481 * xfns.c: Don't assume strlen fits in int.
4482 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4483
4eab31dd
PE
4484 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4485 not unsigned long, as we prefer signed integers. All callers changed.
4486 Detect integer overflow in repeat count.
4487 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4488 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4489
171e2a58
PE
4490 * termcap.c: Don't assume sizes fit in int and never overflow.
4491 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4492 (gobble_line): Check for size-calculation overflow.
4493
ad39faca 4494 * minibuf.c (Fread_buffer):
6e5bb2dc 4495 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4496 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4497 Don't assume string length fits in int.
4498
52c61c22 4499 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4500 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4501
b5b8c9e5
PE
4502 * font.c: Don't assume string length fits in int.
4503 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4504 Use ptrdiff_t, not int.
ccd6111c
PE
4505 (font_intern_prop): Don't assume string length fits in int.
4506 Don't assume integer property fits in fixnum.
4507 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4508
882f0d81 4509 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4510 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4511 Reformulate so as not to need the command string.
4512 Invoke gzip -cd rather than gunzip, as it's more portable.
4513 (lock_info_type, lock_file_1, lock_file):
4514 Don't assume pid_t and time_t fit in unsigned long.
4515 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4516 (current_lock_owner): Prefer signed type for sizes.
4517 Use memcpy, not strncpy, where memcpy is what is really wanted.
4518 Don't assume (via atoi) that time_t and pid_t fit in int.
4519 Check for time_t and/or pid_t out of range, e.g., via a network share.
4520 Don't alloca where an auto var works fine.
4521
93f4cf88
PE
4522 * fileio.c: Fix some integer overflow issues.
4523 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4524 Don't assume string length fits in int.
4525 (directory_file_name): Don't assume string length fits in long.
4526 (make_temp_name): Don't assume pid fits in int, or that its print
4527 length is less than 20.
4528
f3e92b69
PE
4529 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4530
1bfdaf10
PE
4531 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4532
35016e9a
PE
4533 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4534
3d1e65a1
PE
4535 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4536 We prefer signed integers, even for size calculations.
4537
0b963a93
PE
4538 * emacs.c: Don't assume string length fits in 'int'.
4539 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4540 (main): Don't invoke strlen when not needed.
4541
573f4b54
PE
4542 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4543 (XD_DEBUG_MESSAGE): Don't waste a byte.
4544
989f33ba
PE
4545 * callproc.c (getenv_internal_1, getenv_internal)
4546 (Fgetenv_internal):
965d34eb
PE
4547 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4548
e4d29b33
PE
4549 * lread.c (invalid_syntax): Omit length argument.
4550 All uses changed. This doesn't fix a bug, but it simplifies the
4551 code away from its former Hollerith-constant appearance, and it's
4552 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4553 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4554
eb49b136
PE
4555 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4556 This didn't break anything, but it didn't help either.
4557 It's confusing to put a bogus integer in a place where the actual
4558 value does not matter.
9f62aeb1 4559 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4560 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4561
15375a22
PE
4562 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4563 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4564 implementation.
b61cc01c
PE
4565 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4566 We prefer signed types, and the value cannot exceed the EMACS_INT
4567 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4568 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4569 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4570 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4571
53b2623d
PE
4572 * indent.c (sane_tab_width): New function.
4573 (current_column, scan_for_column, Findent_to, position_indentation)
4574 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4575 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4576
51cab52b 4577 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4578
f2ed8a70
PE
4579 * lisp.h (lint_assume): New macro.
4580 * composite.c (composition_gstring_put_cache):
4581 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4582
abe80cc6
PE
4583 * editfns.c, insdel.c:
4584 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4585
b02c740e
PE
4586 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4587
ebc96716
PE
4588 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4589
b4e50fa0 4590 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4591 Use much-faster test for byte-length change.
311d5d7c 4592 Don't assume string byte-length fits in 'int'.
a4cf38e4 4593 Check that character arg fits in 'int'.
85461888 4594 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4595
c0c1ee9f
PE
4596 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4597
a498d7f4
PE
4598 * fns.c (concat): Catch string overflow earlier.
4599 Do not rely on integer wraparound.
4600
51cab52b
PE
4601 * dispextern.h (struct it.overlay_strings_charpos)
4602 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4603 * xdisp.c (forward_to_next_line_start)
4604 (back_to_previous_visible_line_start)
4605 (reseat_at_next_visible_line_start, next_element_from_buffer):
4606 Don't arbitrarily truncate the value of 'selective' to int.
4607
76031fad
PE
4608 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4609
5eb55db9
PE
4610 * composite.c: Don't truncate sizes to 'int'.
4611 (composition_gstring_p, composition_reseat_it)
4612 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4613 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4614 not EMACS_UINT, for indexes.
5eb55db9 4615
0703a717
PE
4616 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4617
d6202519
PE
4618 * buffer.c: Include <verify.h>.
4619 (struct sortvec.priority, struct sortstr.priority):
8961a454 4620 Now EMACS_INT, not int.
c20998a7 4621 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4622 (struct sortstr.size, record_overlay_string)
4623 (struct sortstrlist.size, struct sortlist.used):
4624 Don't truncate size to int.
4625 (record_overlay_string): Check for size-calculation overflow.
d6202519 4626 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4627
d5a19415
JM
46282011-06-22 Jim Meyering <meyering@redhat.com>
4629
029529ac 4630 Don't leak an XBM-image-sized buffer
d5a19415
JM
4631 * image.c (xbm_load): Free the image buffer after using it.
4632
a9041e6c
PE
46332011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 Port to Sun C.
4636 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4637 that Sun C diagnosed.
4638 * fns.c (secure_hash): Fix pointer signedness issue.
4639 * intervals.c (static_offset_intervals): New function.
4640 (offset_intervals): Use it.
4641
7f3f739f
LL
46422011-06-21 Leo Liu <sdl.web@gmail.com>
4643
4644 * deps.mk (fns.o):
4645 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4646 sha512.h.
4647
4648 * fns.c (secure_hash): Rename from crypto_hash_function and change
4649 the first arg to accept symbols.
5b66d427 4650 (Fsecure_hash): New primitive.
7f3f739f
LL
4651 (syms_of_fns): New symbols.
4652
76147d94
DD
46532011-06-20 Deniz Dogan <deniz@dogan.se>
4654
4655 * process.c (Fset_process_buffer): Clarify return value in
4656 docstring.
4657
7d7d0045
CY
46582011-06-18 Chong Yidong <cyd@stupidchicken.com>
4659
4660 * dispnew.c (add_window_display_history): Use BVAR.
4661
4662 * xdisp.c (debug_method_add): Use BVAR.
4663 (check_window_end, dump_glyph_matrix, dump_glyph)
4664 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4665
4666 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4667 Likewise.
4668
4669 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4670 check till after the cache is created in init_frame_faces.
4671
ff2bc410
SM
46722011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4673
4674 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4675
28177add
PE
46762011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4677
dd3482fe
PE
4678 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4679 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4680 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4681
393d71f3 4682 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4683 * fileio.c (Finsert_file_contents):
4684 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4685 Remove the old (too-loose) buffer overflow checks.
4686 They weren't needed, since make_gap checks for buffer overflow.
4687 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4688 The old code merely checked for Emacs fixnum overflow, and relied
4689 on undefined (wraparound) behavior. The new code avoids undefined
4690 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4691
2e6813b0 4692 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4693 Tune. Don't use wider integers than needed. Don't use alloca.
4694 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4695
599a9e4f
PE
4696 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4697
99561444
PE
4698 * insdel.c, lisp.h (buffer_overflow): New function.
4699 (insert_from_buffer_1, replace_range, replace_range_2):
4700 * insdel.c (make_gap_larger):
4701 * editfns.c (Finsert_char):
4702 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4703
28177add
PE
4704 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4705
e69dafad
PE
47062011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4707
4baa020d 4708 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4709
b1c46f02
PE
4710 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4711 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4712
e69dafad
PE
4713 * fileio.c: Don't assume EMACS_INT fits in off_t.
4714 (emacs_lseek): New static function.
4715 (Finsert_file_contents, Fwrite_region): Use it.
4716 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4717
566684ea
PE
4718 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4719
e6966cd6
PE
4720 * fns.c: Don't overflow int when computing a list length.
4721 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4722 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4723 truncation on 64-bit hosts. Check for QUIT every
4724 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4725 faster and is responsive enough.
4726 (Flength): Report an error instead of overflowing an integer.
4727 (Fsafe_length): Return a float if the value is not representable
4728 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4729 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4730 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4731
dd0b0efb
PE
4732 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4733 (header_size, word_size): New constants.
4734 (allocate_vectorlike): Don't check size overflow here.
4735 (allocate_vector): Check it here instead, since this is the only
4736 caller of allocate_vectorlike that could cause overflow.
4737 Check that the new vector's length is representable as a fixnum.
4738
86fe5cfe
PE
4739 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4740 The previous code was bogus. For example, next_almost_prime (32)
4741 returned 39, which is undesirable as it is a multiple of 3; and
4742 next_almost_prime (24) returned 25, which is a multiple of 5 so
4743 why was the code bothering to check for multiples of 7?
4744
80e88859
PE
4745 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4746
4a2f0ad6
PE
4747 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4748
f66c7cf8
PE
4749 Variadic C functions now count arguments with ptrdiff_t.
4750 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4751 Back then I didn't know that the Emacs coding style prefers signed int.
4752 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4753 were being counted with int, which may truncate counts on 64-bit
4754 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4755 * lisp.h (struct Lisp_Subr.function.aMANY)
4756 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4757 Arg counts are now ptrdiff_t, not size_t.
4758 All variadic functions and their callers changed accordingly.
4759 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4760 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4761 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4762 * callint.c (Fcall_interactively): Check arg count for overflow,
4763 to avoid potential buffer overrun. Use signed char, not 'int',
4764 for 'varies' array, so that we needn't bother to check its size
4765 calculation for overflow.
4766 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4767 * eval.c (apply_lambda):
4768 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4769 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4770 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4771
a1759b76
PE
4772 * callint.c (Fcall_interactively): Don't use index var as event count.
4773
d96be9fc
PE
4774 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4775 * mem-limits.h (SIZE): Remove; no longer used.
4776
a690a978 4777 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4778
578c21e6
PE
4779 Remove unnecessary casts.
4780 * xterm.c (x_term_init):
4781 * xfns.c (x_set_border_pixel):
4782 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4783 These aren't needed now that we assume ANSI C.
4784
96f53c6c
PE
4785 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4786 It's more likely to cause problems (due to unsigned overflow)
4787 than to cure them.
4788
83c77d31
PE
4789 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4790
ee2079f1
PE
4791 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4792
6da65536
PE
4793 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4794
7147c4a4
PE
4795 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4796
193e32d9
PE
4797 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4798
e5533da6
PE
4799 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4800
9910e595
PE
4801 GLYPH_CODE_FACE returns EMACS_INT, not int.
4802 * dispextern.h (merge_faces):
4803 * xfaces.c (merge_faces):
01103c44
PE
4804 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4805 Don't assume EMACS_INT fits in int.
9910e595 4806
2638320e
PE
4807 * character.h (CHAR_VALID_P): Remove unused parameter.
4808 * fontset.c, lisp.h, xdisp.c: All uses changed.
4809
045eb8d9
PE
4810 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4811
c1f134b5
PE
4812 * fns.c (concat): Minor tuning based on overflow analysis.
4813 This doesn't fix any bugs. Use int to hold character, instead
4814 of constantly refetching from Emacs object. Use XFASTINT, not
4815 XINT, for value known to be a character. Don't bother comparing
4816 a single byte to 0400, as it's always less.
4817
395fcb93 4818 * floatfns.c (Fexpt):
327eeec8
PE
4819 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4820
abbd3d23
PE
4821 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4822 for characters.
4823
684a03ef
PE
4824 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4825
0fed43f3
PE
4826 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4827 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4828 incorrectly succeed when S was a string, because 4294967386 was
4829 truncated before it was used.
4830
8fd02eb7
PE
4831 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4832 Otherwise, an out-of-range integer could cause undefined behavior
4833 on a 64-bit host.
4834
f8c86b69
PE
4835 * composite.c: Use int, not EMACS_INT, for characters.
4836 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4837 EMACS_INT, for values that are known to be in character range.
4838 This doesn't fix any bugs but is the usual style inside Emacs and
4839 may generate better code on 32-bit machines.
4840
34206dd2
PE
4841 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4842 This is for reasons similar to the recent CHAR_STRING fix.
4843 * charset.c (Fencode_char): Check that character arg is actually
4844 a character. Pass an int to ENCODE_CHAR.
4845 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4846 wider than 'int', as a compile-time check to prevent future regressions
4847 in this area.
4848
c5958d4c 4849 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4850
4851 Make sure a 64-bit char is never passed to CHAR_STRING.
4852 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4853 by silently ignoring the top 32 bits, allowing some values
4854 that were far too large to be valid characters.
4855 * character.h: Include <verify.h>.
4856 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4857 arguments are no wider than unsigned, as a compile-time check
4858 to prevent future regressions in this area.
4859 * data.c (Faset):
01103c44 4860 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4861 (Fsubst_char_in_region):
4862 * fns.c (concat):
4863 * xdisp.c (decode_mode_spec_coding):
4864 Adjust to CHAR_STRING's new requirement.
4865 * editfns.c (Finsert_char, Fsubst_char_in_region):
4866 * fns.c (concat): Check that character args are actually
4867 characters. Without this test, these functions did the wrong
4868 thing with wildly out-of-range values on 64-bit hosts.
4869
d37ca623
PE
4870 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4871 These casts should not be needed on 32-bit hosts, either.
4872 * keyboard.c (read_char):
4873 * lread.c (Fload): Remove casts to unsigned.
4874
ea204efb
PE
4875 * lisp.h (UNSIGNED_CMP): New macro.
4876 This fixes comparison bugs on 64-bit hosts.
4877 (ASCII_CHAR_P): Use it.
4878 * casefiddle.c (casify_object):
01103c44 4879 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4880 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4881 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4882 * dispextern.h (FACE_FROM_ID):
4883 * keyboard.c (read_char): Use UNSIGNED_CMP.
4884
41cb286c
PE
4885 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4886 not to EMACS_INT, to avoid GCC warning.
4887
4a1b9832
PE
4888 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4889
55daad71
PE
4890 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4891 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4892 isn't needed on 32-bit machines.
8f95c75c 4893
01103c44
PE
4894 * buffer.c (Fgenerate_new_buffer_name):
4895 Use EMACS_INT for count, not int.
0ceccced 4896 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4897
4898 * data.c (Qcompiled_function): Now static.
4899
c6f072e7
PE
4900 * window.c (window_body_lines): Now static.
4901
20ce5912
PE
4902 * image.c (gif_load): Rename local to avoid shadowing.
4903
9c4c5f81
PE
4904 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4905 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4906 * alloc.c (make_save_value): Integer argument is now of type
4907 ptrdiff_t, not int.
4908 (mark_object): Use ptrdiff_t, not int.
4909 * lisp.h (pD): New macro.
4910 * print.c (print_object): Use it.
4911
c0c5c8ae
PE
4912 * alloc.c: Use EMACS_INT, not int, to count objects.
4913 (total_conses, total_markers, total_symbols, total_vector_size)
4914 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4915 (total_free_floats, total_floats, total_free_intervals)
4916 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4917 Now EMACS_INT, not int. All uses changed.
4918 (Fgarbage_collect): Compute overall total using a double, so that
4919 integer overflow is less likely to be a problem. Check for overflow
4920 when converting back to an integer.
5a25e253
PE
4921 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4922 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4923 These were 'int' variables that could overflow on 64-bit hosts;
4924 they were never used, so remove them instead of repairing them.
211a0b2a 4925 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4926 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4927 Previously, this ceilinged at INT_MAX, but that doesn't work on
4928 64-bit machines.
e46bb31a 4929 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4930
c78baabf 4931 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4932 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4933 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4934 when a (possibly-narrower) signed value would do just as well.
4935 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4936
c9d624c6
PE
4937 * alloc.c: Catch some string size overflows that we were missing.
4938 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4939 for convenience in STRING_BYTES_MAX.
4940 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4941 The definition here is exact; the one in lisp.h was approximate.
4942 (allocate_string_data): Check for string overflow. This catches
4943 some instances we weren't catching before. Also, it catches
4944 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4945 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4946 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4947
c9d624c6
PE
4948 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4949 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4950 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4951
353032ce
PE
4952 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4953
2bccce07
PE
4954 * alloc.c (Fmake_string): Check for out-of-range init.
4955
0ac30604
SM
49562011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4957
4958 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4959
c195f2de
JD
49602011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4961
4962 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4963 xg_get_default_scrollbar_width.
4964
4965 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4966 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4967 (style_changed_cb): Call update_theme_scrollbar_width and call
4968 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4969 all frames (Bug#8505).
4970 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4971 Call gtk_window_set_resizable if HAVE_GTK3.
4972 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4973 and height if HAVE_GTK3 (Bug#8505).
4974 (scroll_bar_width_for_theme): New variable.
4975 (update_theme_scrollbar_width): New function.
4976 (xg_get_default_scrollbar_width): Move code to
4977 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4978 (xg_initialize): Call update_theme_scrollbar_width.
4979
4980 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4981
4982 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4983
e10ac9f1
MR
49842011-06-12 Martin Rudalics <rudalics@gmx.at>
4985
4986 * frame.c (make_frame): Call other_buffer_safely instead of
4987 other_buffer.
4988
4989 * window.c (temp_output_buffer_show): Call display_buffer with
4990 second argument Vtemp_buffer_show_specifiers and reset latter
4991 immediately after the call.
4992 (Vtemp_buffer_show_specifiers): New variable.
4993 (auto_window_vscroll_p, next_screen_context_lines)
4994 (Vscroll_preserve_screen_position): Remove leading asterisks from
4995 doc-strings.
4996
2d3c217e 49972011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4998
7b7f97e8 4999 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5000 * buffer.c (Qclone_number): Remove for now, as it's unused.
5001 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5002 (record_buffer): Remove unused local.
5003 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5004 (set_frame_buffer_list): Remove; unused.
5005 * frame.h (other_visible_frames): Remove decl.
5006 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5007 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5008 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5009 if HAVE_GPM.
5010 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5011 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5012 Define only if HAVE_GPM.
5013 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5014 (update_hints_inhibit): Remove; never set. All uses removed.
5015 * widgetprv.h (emacsFrameClassRec): Remove decl.
5016 * window.c (delete_deletable_window): Now returns void, since it
5017 wasn't returning anything.
5018 (compare_window_configurations): Remove unused locals.
5019 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5020 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5021 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5022 the same widths as pointers. This follows up on the 2011-05-06 patch.
5023 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5024 * xterm.h: Likewise.
5025 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5026
1384b89e
JB
50272011-06-12 Juanma Barranquero <lekktu@gmail.com>
5028
5029 * makefile.w32-in: Update dependencies.
5030 (LISP_H): Add lib/intprops.h.
5031
1100a63c
CY
50322011-06-11 Chong Yidong <cyd@stupidchicken.com>
5033
5034 * image.c (gif_load): Add animation frame delay to the metadata.
5035 (syms_of_image): Use DEFSYM. New symbol `delay'.
5036
6198ccd0
MR
50372011-06-11 Martin Rudalics <rudalics@gmx.at>
5038
5039 * window.c (delete_deletable_window): Re-add.
5040 (Fset_window_configuration): Rewrite to handle dead buffers and
5041 consequently deletable windows.
5042 (window_tree, Fwindow_tree): Remove. Supply functionality in
5043 window.el.
5044 (compare_window_configurations): Simplify code.
5045
b6e3633c
AS
50462011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5047
1ab0dee5
AS
5048 * image.c (imagemagick_load_image): Fix type mismatch.
5049 (Fimagemagick_types): Likewise.
5050
b6e3633c
AS
5051 * window.h (replace_buffer_in_windows): Declare.
5052
9397e56f
MR
50532011-06-11 Martin Rudalics <rudalics@gmx.at>
5054
5055 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5056 Qclone_number. Remove external declaration of Qdelete_window.
5057 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5058 code.
640c8776
SM
5059 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5060 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5061 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5062 buffer list implementation.
5063 (other_buffer_safely): New function.
5064 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5065 calls to replace_buffer_in_windows and
5066 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5067 if allowed.
5068 (record_buffer): Inhibit quitting and rewrite using quittable
5069 functions. Run Qbuffer_list_update_hook if allowed.
5070 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5071 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5072 Move switch-to-buffer to window.el.
9397e56f
MR
5073 (bury-buffer): Move to window.el.
5074 (Vbuffer_list_update_hook): New variable.
5075
5076 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5077 section.
5078
5079 * window.h (resize_frame_windows): Move up in code.
5080 (Fwindow_frame): Remove EXFUN.
5081 (replace_buffer_in_all_windows): Remove prototype.
5082 (replace_buffer_in_windows_safely): Add prototype.
5083
5084 * window.c: Declare Qdelete_window static again. Move down
5085 declaration of select_count.
5086 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5087 (Fother_window): Move to window.el.
5088 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5089 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5090 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5091 window.el.
5092 (replace_buffer_in_windows): Implement by calling
5093 Qreplace_buffer_in_windows.
5094 (replace_buffer_in_all_windows): Remove with some functionality
5095 moved into replace_buffer_in_windows_safely.
5096 (replace_buffer_in_windows_safely): New function.
5097 (select_window_norecord, select_frame_norecord): Move in front
5098 of run_window_configuration_change_hook. Remove now obsolete
5099 declarations.
640c8776
SM
5100 (Fset_window_buffer): Rewrite doc-string.
5101 Call Qrecord_window_buffer.
9397e56f
MR
5102 (keys_of_window): Move binding for other-window to window.el.
5103
b50691aa
CY
51042011-06-11 Chong Yidong <cyd@stupidchicken.com>
5105
5106 * dispextern.h (struct image): Replace data member, whose int_val
5107 and ptr_val fields were not used by anything, with a single
5108 lisp_val object.
5109
5110 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5111 (gif_clear_image, gif_load, imagemagick_load_image)
5112 (gs_clear_image, gs_load): Callers changed.
5113
3f754b86
PE
51142011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5115
cca69397
PE
5116 * buffer.h: Include <time.h>, for time_t.
5117 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5118
109e28d0
PE
5119 Fix minor problems found by static checking.
5120
60737f02
PE
5121 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5122
4b66faf3
PE
5123 Make identifiers static if they are not used in other modules.
5124 * data.c (Qcompiled_function, Qframe, Qvector):
5125 * image.c (QimageMagick, Qsvg):
5126 * minibuf.c (Qmetadata):
5127 * window.c (resize_window_check, resize_root_window): Now static.
5128 * window.h (resize_window_check, resize_root_window): Remove decls.
5129
109e28d0
PE
5130 * window.c (window_deletion_count, delete_deletable_window):
5131 Remove; unused.
46a4ce9e
PE
5132 (window_body_lines): Now static.
5133 (Fdelete_other_windows_internal): Mark vars as initialized.
5134 Make sure 'resize_failed' is initialized.
5135 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5136 (resize_window_apply): Remove unused local.
5137 * window.h (delete_deletable_window): Remove decl.
5138
109e28d0 5139 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5140 (imagemagick_load_image): Fix pointer signedness problem by changing
5141 last arg from unsigned char * to char *. All uses changed.
5142 Also, fix a local for similar reasons.
5143 Remove unused locals. Remove locals to avoid shadowing.
5144 (fn_rsvg_handle_free): Remove; unused.
5145 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5146 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5147
3f754b86
PE
5148 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5149
2547adb1
CY
51502011-06-10 Chong Yidong <cyd@stupidchicken.com>
5151
5152 * image.c (gif_load): Fix omitted cast error introduced by
5153 2011-06-06 change.
5154
2c8e37d4
MR
51552011-06-10 Martin Rudalics <rudalics@gmx.at>
5156
5157 * window.h (resize_proportionally, orig_total_lines)
5158 (orig_top_line): Remove from window structure.
5159 (set_window_height, set_window_width, change_window_heights)
5160 (Fdelete_window): Remove prototypes.
5161 (resize_frame_windows): Remove duplicate declaration.
5162
440a42e3
EZ
51632011-06-10 Eli Zaretskii <eliz@gnu.org>
5164
5165 * window.h (resize_frame_windows, resize_window_check)
5166 (delete_deletable_window, resize_root_window)
5167 (resize_frame_windows): Declare prototypes.
5168
5169 * window.c (resize_window_apply): Make definition be "static" to
5170 match the prototype.
5171
562dd5e9
MR
51722011-06-10 Martin Rudalics <rudalics@gmx.at>
5173
5174 * window.c: Remove declarations of Qwindow_size_fixed,
5175 window_min_size_1, window_min_size_2, window_min_size,
5176 size_window, window_fixed_size_p, enlarge_window, delete_window.
5177 Remove static from declaration of Qdelete_window, it's
5178 temporarily needed by Fbury_buffer.
5179 (replace_window): Don't assign orig_top_line and
5180 orig_total_lines.
5181 (Fdelete_window, delete_window): Remove. Window deletion is
5182 handled by window.el.
640c8776
SM
5183 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5184 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5185 (Fdelete_other_windows): Remove. Deleting other windows is
5186 handled by window.el.
5187 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5188 handled in window.el.
5189 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5190 Window minimum sizes are handled in window.el.
5191 (shrink_windows, size_window, set_window_height)
5192 (set_window_width, change_window_heights, window_height)
5193 (window_width, CURBEG, CURSIZE, enlarge_window)
5194 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5195 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5196 handled in window.el.
5197 (make_dummy_parent): Rename to make_parent_window and give it a
5198 second argument horflag.
5199 (make_window): Don't set resize_proportionally any more.
5200 (Fsplit_window): Remove. Windows are split in window.el.
5201 (save_restore_action, save_restore_orig_size)
5202 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5203 Resize mini windows in window.el.
5204 (grow_mini_window, shrink_mini_window): Implement by calling
5205 Qresize_root_window_vertically, resize_window_check and
5206 resize_window_apply.
640c8776
SM
5207 (saved_window, Fset_window_configuration, save_window_save):
5208 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5209 resize_proportionally.
5210 (window_min_height, window_min_width): Move to window.el.
5211 (keys_of_window): Move bindings for delete-other-windows,
5212 split-window, delete-window and enlarge-window to window.el.
5213
5214 * buffer.c: Temporarily extern Qdelete_window.
5215 (Fbury_buffer): Temporarily call Qdelete_window instead of
5216 Fdelete_window (Fbury_buffer will move to window.el soon).
5217
5218 * frame.c (set_menu_bar_lines_1): Remove code handling
5219 orig_top_line and orig_total_lines.
5220
5221 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5222 set_window_height but set heights directly.
5223 (change_frame_size_1): Use resize_frame_windows.
5224
5225 * xdisp.c (init_xdisp): Don't use set_window_height but set
5226 heights directly.
5227
640c8776
SM
5228 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5229 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5230 run_window_configuration_change_hook.
5231
5232 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5233 instead of change_window_heights and run
5234 run_window_configuration_change_hook.
5235
1a13852e
MR
52362011-06-09 Martin Rudalics <rudalics@gmx.at>
5237
5238 * window.c (replace_window): Rename second argument REPLACEMENT to
5239 NEW. New third argument SETFLAG. Rewrite.
5240 (delete_window, make_dummy_parent): Call replace_window with
5241 third argument 1.
5242 (window_list_1): Move down in code.
5243 (run_window_configuration_change_hook): Move set_buffer part
5244 before select_frame_norecord part in order to unwind correctly.
5245 Rename count1 to count.
5246 (recombine_windows, delete_deletable_window, resize_root_window)
5247 (Fdelete_other_windows_internal)
5248 (Frun_window_configuration_change_hook, make_parent_window)
5249 (resize_window_check, resize_window_apply, Fresize_window_apply)
5250 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5251 (Fdelete_window_internal, Fresize_mini_window_internal):
5252 New functions.
1a13852e
MR
5253 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5254
f3d1777e
MR
52552011-06-08 Martin Rudalics <rudalics@gmx.at>
5256
496e208e
MR
5257 * window.h (window): Add some new members to window structure -
5258 normal_lines, normal_cols, new_total, new_normal, clone_number,
5259 splits, nest, prev_buffers, next_buffers.
5260 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5261 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5262
f3d1777e
MR
5263 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5264 Remove.
496e208e
MR
5265 (make_dummy_parent): Set new members of windows structure.
5266 (make_window): Move down in code. Handle new members of window
5267 structure.
5268 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5269 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5270 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5271 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5272 (Fset_window_next_buffers, Fset_window_clone_number):
5273 New functions.
496e208e
MR
5274 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5275 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5276 Doc-string fixes.
5277 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5278 Argument WINDOW can be now internal window too.
5279 (Fwindow_use_time): Move up in code.
5280 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5281 Rewrite doc-string.
5282 (Fset_window_configuration, saved_window)
5283 (Fcurrent_window_configuration, save_window_save): Handle new
5284 members of window structure.
b9e809c2
MR
5285 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5286 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5287 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5288 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5289 Qget_mru_window, Qresize_root_window,
5290 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5291 Qauto_buffer_name; staticpro them.
f3d1777e 5292
abde8f8c
MR
52932011-06-07 Martin Rudalics <rudalics@gmx.at>
5294
5295 * window.c (Fwindow_total_size, Fwindow_left_column)
5296 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5297 (Fwindow_list_1): New functions.
5298 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5299 (Fwindow_width, Fscroll_left, Fscroll_right):
5300 Use window_body_cols instead of window_box_text_cols.
5301 (delete_window, Fset_window_configuration):
5302 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5303 (delete_all_subwindows): Take a window as argument and not a
5304 structure. Rewrite.
190b47e6
MR
5305 (window_loop): Remove handling of GET_LRU_WINDOW and
5306 GET_LARGEST_WINDOW.
5307 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5308
5309 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5310 window_box_text_cols. delete_all_subwindows now takes a
5311 Lisp_Object as argument.
abde8f8c 5312
640c8776
SM
5313 * indent.c (compute_motion, Fcompute_motion):
5314 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5315
fa8a67e6
MR
5316 * frame.c (delete_frame): Call delete_all_subwindows with root
5317 window as argument.
5318
a54e3482
DC
53192011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5320
5321 * fns.c (Fputhash): Document return value.
5322
60002bf5
CY
53232011-06-06 Chong Yidong <cyd@stupidchicken.com>
5324
5325 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5326
0c671da6 53272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5328
b862a52a 5329 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5330
be44ca6c
PE
5331 Check for overflow when converting integer to cons and back.
5332 * charset.c (Fdefine_charset_internal, Fdecode_char):
5333 Use cons_to_unsigned to catch overflow.
5334 (Fencode_char): Use INTEGER_TO_CONS.
5335 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5336 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5337 * data.c (long_to_cons, cons_to_long): Remove.
5338 (cons_to_unsigned, cons_to_signed): New functions.
5339 These signal an error for invalid or out-of-range values.
5340 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5341 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5342 * font.c (Ffont_variation_glyphs):
5343 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5344 * lisp.h: Include <intprops.h>.
5345 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5346 (cons_to_signed, cons_to_unsigned): New decls.
5347 (long_to_cons, cons_to_long): Remove decls.
5348 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5349 (Fprimitive_undo): Use CONS_TO_INTEGER.
5350 * xfns.c (Fx_window_property): Likewise.
5351 * xselect.c: Include <limits.h>.
5352 (x_own_selection, selection_data_to_lisp_data):
5353 Use INTEGER_TO_CONS.
5354 (x_handle_selection_request, x_handle_selection_clear)
5355 (x_get_foreign_selection, Fx_disown_selection_internal)
5356 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5357 (lisp_data_to_selection_data): Use cons_to_unsigned.
5358 (x_fill_property_data): Use cons_to_signed.
5359 Report values out of range.
5360
d1f3d2af
PE
5361 Check for buffer and string overflow more precisely.
5362 * buffer.h (BUF_BYTES_MAX): New macro.
5363 * lisp.h (STRING_BYTES_MAX): New macro.
5364 * alloc.c (Fmake_string):
5365 * character.c (string_escape_byte8):
5366 * coding.c (coding_alloc_by_realloc):
5367 * doprnt.c (doprnt):
5368 * editfns.c (Fformat):
5369 * eval.c (verror):
5370 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5371 since they may not be the same number.
5372 * editfns.c (Finsert_char):
5373 * fileio.c (Finsert_file_contents):
5374 Likewise for BUF_BYTES_MAX.
5375
dd52fcea
PE
5376 * image.c: Use ptrdiff_t, not int, for sizes.
5377 (slurp_file): Switch from int to ptrdiff_t.
5378 All uses changed.
5379 (slurp_file): Check that file size fits in both size_t (for
5380 malloc) and ptrdiff_t (for sanity and safety).
5381
7f9bbdbb
PE
5382 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5383 if b->modtime has its maximal value.
5384
dfe18f82
PE
5385 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5386
84acfcf0
PE
5387 Don't assume time_t can fit into int.
5388 * buffer.h (struct buffer.modtime): Now time_t, not int.
5389 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5390 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5391
ccd9a01a
PE
5392 Minor fixes for signed vs unsigned integers.
5393 * character.h (MAYBE_UNIFY_CHAR):
5394 * charset.c (maybe_unify_char):
5395 * keyboard.c (read_char, reorder_modifiers):
5396 XINT -> XFASTINT, since the integer must be nonnegative.
5397 * ftfont.c (ftfont_spec_pattern):
5398 * keymap.c (access_keymap, silly_event_symbol_error):
5399 XUINT -> XFASTINT, since the integer must be nonnegative.
5400 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5401 since it makes no difference and we prefer signed.
5402 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5403 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5404 nonnegative.
5405
d6d100dd
SM
54062011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5407
5408 * window.h (Fwindow_frame): Declare.
5409
2b6148e4
PE
54102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5411
5412 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5413 (SPARE_MEMORY): Always define.
5414 (LARGE_REQUEST): Remove.
5415 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5416
f230ecc9
MR
54172011-06-06 Martin Rudalics <rudalics@gmx.at>
5418
727e958e
MR
5419 * lisp.h: Move EXFUNS for Fframe_root_window,
5420 Fframe_first_window and Fset_frame_selected_window to window.h.
5421
5422 * window.h: Move EXFUNS for Fframe_root_window,
5423 Fframe_first_window and Fset_frame_selected_window here from
5424 lisp.h.
5425
5426 * frame.c (Fwindow_frame, Fframe_first_window)
5427 (Fframe_root_window, Fframe_selected_window)
5428 (Fset_frame_selected_window): Move to window.c.
5429 (Factive_minibuffer_window): Move to minibuf.c.
5430 (Fother_visible_frames_p): New function.
5431
5432 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5433
f230ecc9
MR
5434 * window.c (decode_window, decode_any_window): Move up in code.
5435 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5436 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5437 (Fwindow_buffer): Move up and rewrite doc-string.
5438 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5439 (Fwindow_prev): New functions.
727e958e
MR
5440 (Fwindow_frame): Move here from frame.c. Accept any window as
5441 argument.
5442 (Fframe_root_window, Fframe_first_window)
5443 (Fframe_selected_window): Move here from frame.c. Accept frame
5444 or arbitrary window as argument. Update doc-strings.
5445 (Fminibuffer_window): Move up in code.
5446 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5447 (Fset_frame_selected_window): Move here from frame.c.
5448 Marginal rewrite.
727e958e
MR
5449 (Fselected_window, select_window, Fselect_window): Move up in
5450 code. Minor doc-string fixes.
f230ecc9 5451
4d09bcf6
PE
54522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5453
5454 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5455 Do not assume that spare memory exists; that assumption is valid
5456 only if SYSTEM_MALLOC.
5457 (LARGE_REQUEST): New macro, so that the issue of large requests
5458 is separated from the issue of spare memory.
5459
810928a2
AS
54602011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5461
172418ad
AS
5462 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5463 format. (Bug#8806)
5464
43f862f7
AS
5465 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5466
810928a2
AS
5467 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5468 before statements.
5469
a059fe24
JD
54702011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5471
5472 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5473
5474 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5475
5476 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5477 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5478
989bf368
JB
54792011-06-05 Juanma Barranquero <lekktu@gmail.com>
5480
5481 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5482
4b80f674
CY
54832011-06-04 Chong Yidong <cyd@stupidchicken.com>
5484
5485 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5486 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5487 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5488 New error handlers.
4b80f674
CY
5489 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5490 Obey Vx_select_enable_clipboard_manager. Catch errors in
5491 x_clipboard_manager_save (Bug#8779).
5492 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5493 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5494
99a33b77 54952011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5496
5497 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5498
99a33b77 54992011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5500
5501 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5502 in the current matrix if keep_current_p is non-zero.
5503
8264569d
EZ
55042011-06-04 Eli Zaretskii <eliz@gnu.org>
5505
5506 * bidi.c (bidi_level_of_next_char): Fix last change.
5507
57f97249
EZ
55082011-06-03 Eli Zaretskii <eliz@gnu.org>
5509
fec2107c 5510 Support bidi reordering of text covered by display properties.
57f97249 5511
fec2107c
EZ
5512 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5513 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5514 (bidi_cache_search, bidi_cache_iterator_state)
5515 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5516 (bidi_level_of_next_char, bidi_move_to_visually_next):
5517 Support character positions inside a run of characters covered by a
fec2107c
EZ
5518 display string.
5519 (bidi_paragraph_init, bidi_resolve_explicit_1)
5520 (bidi_level_of_next_char): Call bidi_fetch_char and
5521 bidi_fetch_char_advance instead of FETCH_CHAR and
5522 FETCH_CHAR_ADVANCE.
5523 (bidi_init_it): Initialize new members.
5524 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5525 definitions.
5526 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5527 instead of using explicit *_CHAR codes.
d6d100dd
SM
5528 (bidi_resolve_explicit, bidi_resolve_weak):
5529 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5530 bidirectional text is supported only in multibyte buffers.
5531 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5532 it to initialize the frame_window_p member of struct bidi_it.
5533 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5534 (bidi_resolve_explicit, bidi_resolve_weak)
5535 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5536 bidi_it->nchars is non-positive.
5537 (bidi_level_of_next_char): Don't try to lookup the cache for the
5538 next/previous character if nothing is cached there yet, or if we
5539 were just reseat()'ed to a new position.
c40e2fb2 5540
0e14fe90
EZ
5541 * xdisp.c (set_cursor_from_row): Set start and stop points
5542 according to the row's direction when priming the loop that looks
5543 for the glyph on which to display cursor.
5544 (single_display_spec_intangible_p): Function deleted.
5545 (display_prop_intangible_p): Reimplement to call
5546 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5547 Accept 3 additional arguments needed by handle_display_spec.
5548 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5549 values: lists, `(when COND...)' forms, etc.
5550 (single_display_spec_string_p): Support property values that are
5551 lists with the argument STRING its top-level element.
5552 (display_prop_string_p): Fix the condition for processing a
5553 property that is a list to be consistent with handle_display_spec.
fec2107c 5554 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5555 last portion of handle_display_prop.
5556 (compute_display_string_pos): Accept additional argument
5557 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5558 value of a `display' property is a "replacing spec".
5559 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5560 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5561 the display property, but just return a value indicating whether
5562 the display property will replace the characters it covers.
5563 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5564 frame_window_p members of struct bidi_it.
d6d100dd
SM
5565 (compute_display_string_pos, compute_display_string_end):
5566 New functions.
fec2107c
EZ
5567 (push_it): Accept second argument POSITION, where pop_it should
5568 jump to continue iteration.
5569 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5570
fec2107c
EZ
5571 * keyboard.c (adjust_point_for_property): Adjust the call to
5572 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5573
5574 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5575 (bidi_init_it): Update prototypes.
5576 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5577 (compute_display_string_pos, compute_display_string_end):
5578 Declare prototypes.
fec2107c
EZ
5579 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5580 EMACS_INT.
fc6f18ce 5581
40087514 55822011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5583
57f53182
PE
5584 Malloc failure behavior now depends on size of allocation.
5585 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5586 * lisp.h: Change signatures accordingly.
5587 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5588 All callers changed. (Bug#8762)
5589
5590 * gnutls.c: Use Emacs's memory allocators.
5591 Without this change, the gnutls library would invoke malloc etc.
5592 directly, which causes problems on non-SYNC_INPUT hosts, and which
5593 runs afoul of improving memory_full behavior. (Bug#8761)
5594 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5595 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5596 xfree instead of the default malloc, realloc, free.
5597 (Fgnutls_boot): No need to check for memory allocation failure,
5598 since xmalloc does that for us.
5599
ac32cd99 5600 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5601 * category.c (hash_get_category_set):
5602 * ccl.c (ccl_driver):
5603 * charset.c (Fdefine_charset_internal):
5604 * charset.h (struct charset.hash_index):
5605 * composite.c (get_composition_id, gstring_lookup_cache)
5606 (composition_gstring_put_cache):
5607 * composite.h (struct composition.hash_index):
5608 * dispextern.h (struct image.hash):
5609 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5610 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5611 (hashfn_equal, hashfn_user_defined, make_hash_table)
5612 (maybe_resize_hash_table, hash_lookup, hash_put)
5613 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5614 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5615 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5616 * image.c (make_image, search_image_cache, lookup_image)
5617 (xpm_put_color_table_h):
5618 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5619 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5620 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5621 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5622 * alloc.c (allocate_vectorlike):
5623 Check for overflow in vector size calculations.
5624 * ccl.c (ccl_driver):
5625 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5626 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5627 need to be updated by these changes.
40087514
PE
5628 * fns.c (make_hash_table, maybe_resize_hash_table):
5629 Check for integer overflow with large hash tables.
0de4bb68
PE
5630 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5631 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5632 (SXHASH_REDUCE): New macro.
5633 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5634 Use it instead of discarding useful hash info with large hash values.
5635 (sxhash_float): New function.
5636 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5637 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5638 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5639 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5640 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5641 Adjust signatures to match updated version of code.
5642 (consing_since_gc): Now EMACS_INT, since a single hash table can
5643 use more than INT_MAX bytes.
5644
698d32e2
DN
56452011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5646
5647 Make it possible to build with GCC-4.6+ -O2 -flto.
5648
5649 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5650
fd6fa53f
SM
56512011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5652
5653 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5654 Call minibuffer-inactive-mode.
5655
864db017
JB
56562011-05-31 Juanma Barranquero <lekktu@gmail.com>
5657
5658 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5659 Update dependencies.
5660
2ad0baf4
DN
56612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5662
5663 * data.c (init_data): Remove code for UTS, this system is not
5664 supported anymore.
5665
4fcc2638
DN
56662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5667
5668 Don't force ./temacs to start in terminal mode.
5669
5670 * frame.c (make_initial_frame): Initialize faces in all cases, not
5671 only when CANNOT_DUMP is defined.
5672 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5673
c56e0fd5
DN
56742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5675
5676 * dispnew.c (add_window_display_history): Use const for the string
5677 pointer. Remove declaration, not needed.
5678
333d54da 56792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5680
55d4c1b2 5681 Use 'inline', not 'INLINE'.
333d54da 5682 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5683 * alloc.c, fontset.c (INLINE): Remove.
5684 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5685 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5686 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5687 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5688 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5689
738db178
DN
56902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5691
5692 Make it possible to run ./temacs.
5693
5694 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5695 syms_of_callproc does the same thing. Remove test for
5696 "initialized", do it in the caller.
5697 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5698
620c53a6
SM
56992011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5700
5701 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5702 (read_minibuf): Use get_minibuffer.
5703 (syms_of_minibuf): Use DEFSYM.
5704 (Qmetadata): New var.
5705 * data.c (Qbuffer): Don't make it static.
5706 (syms_of_data): Use DEFSYM.
5707
e003a292
PE
57082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5709
5710 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5711 (CCL_CODE_MIN): New macro.
5712
ed008a6d
PE
57132011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5714
3687c2ef
PE
5715 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5716
ed008a6d
PE
5717 * eval.c (Qdebug): Now static.
5718 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5719 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5720 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5721
d66c4c7c
CY
57222011-05-29 Chong Yidong <cyd@stupidchicken.com>
5723
5724 * image.c: Various fixes to ImageMagick code comments.
5725 (Fimagemagick_types): Doc fix.
5726
5fbc2025
PE
57272011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5728
0196f88a
PE
5729 Minor fixes prompted by GCC 4.6.0 warnings.
5730
5731 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5732
5fbc2025
PE
5733 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5734 (x_clipboard_manager_save_all): Move extern decl to ...
5735 * xterm.h: ... here, so that it can be checked for consistency.
5736
1dd3c2d9
CY
57372011-05-29 Chong Yidong <cyd@stupidchicken.com>
5738
5739 * xselect.c (x_clipboard_manager_save_frame)
5740 (x_clipboard_manager_save_all): New functions.
5741 (Fx_clipboard_manager_save): Lisp function deleted.
5742
5743 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5744 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5745
5746 * xterm.h: Update prototype.
5747
5ba6571d
WX
57482011-05-28 William Xu <william.xwl@gmail.com>
5749
5750 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5751 exiting (Bug#8239).
5752
3eaff834
JM
57532011-05-28 Jim Meyering <meyering@redhat.com>
5754
e1900994 5755 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5756 * fns.c (to_uchar): Define.
5757 (crypto_hash_function): Use it to convert some newly-signed
5758 variables to unsigned, to avoid sign-extension bugs. For example,
5759 without this change, (md5 "truc") would evaluate to
5760 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5761 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5762 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5763
0f6990a7
PE
57642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 Integer overflow fixes.
c8a9ca5a 5767
08686060
PE
5768 * dbusbind.c: Serial number integer overflow fixes.
5769 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5770 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5771 to hold a serial number that is too large for a fixnum.
5772 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5773 Check for serial numbers out of range. Decode any serial number
59568bf0 5774 that was so large that it became a float. (Bug#8722)
08686060 5775
2d1fc3c7
PE
5776 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5777 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5778 Use XFASTINT rather than XUINT when numbers are nonnegative.
5779 (xd_append_arg, Fdbus_method_return_internal):
5780 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5781 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5782 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5783 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5784 (Bug#8722)
2d1fc3c7 5785
c8a9ca5a
PE
5786 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5787
519e1d69
PE
5788 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5789
6df6ae42 5790 ccl: Add integer overflow checks.
30569699
PE
5791 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5792 (IN_INT_RANGE): New macros.
5793 (ccl_driver): Use them to check for integer overflow when
5794 decoding a CCL program. Many of the new checks are whether XINT (x)
5795 fits in int; it doesn't always, on 64-bit hosts. The new version
5796 doesn't catch all possible integer overflows, but it's an
847044ea 5797 improvement. (Bug#8719)
30569699 5798
c11285dc
PE
5799 * alloc.c (make_event_array): Use XINT, not XUINT.
5800 There's no need for unsigned here.
5801
fdccd48e
PE
5802 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5803 This follows up to the 2011-05-06 change that substituted uintptr_t
5804 for EMACS_INT. This case wasn't caught back then.
5805
37910ab2
PE
5806 Rework Fformat to avoid integer overflow issues.
5807 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5808 now (part of C89). Include <verify.h>.
5809 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5810 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5811 (Fformat): Avoid the prepass trying to compute sizes; it was only
5812 approximate and thus did not catch overflow reliably. Instead, walk
5813 through the format just once, formatting and computing sizes as we go,
5814 checking for integer overflow at every step, and allocating a larger
5815 buffer as needed. Keep track separately whether the format is
5816 multibyte. Keep only the most-recently calculated precision, rather
5817 than them all. Record whether each argument has been converted to
5818 string. Use EMACS_INT, not int, for byte and char and arg counts.
5819 Support field widths and precisions larger than INT_MAX. Avoid
5820 sprintf's undefined behavior with conversion specifications such as %#d
5821 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5822 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5823 formatting out-of-range floating point numbers with int
9173deec 5824 formats. (Bug#8668)
37910ab2 5825
2e6578fb
PE
5826 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5827
0ae6bdee
PE
5828 * data.c: Avoid integer truncation in expressions involving floats.
5829 * data.c: Include <intprops.h>.
5830 (arith_driver): When there's an integer overflow in an expression
5831 involving floating point, convert the integers to floating point
5832 so that the resulting value does not suffer from catastrophic
5833 integer truncation. For example, on a 64-bit host (* 4
5834 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5835 Do not rely on undefined behavior after integer overflow.
5836
de883a70
PE
5837 merge count_size_as_multibyte, parse_str_to_multibyte
5838 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5839 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5840 Check for integer overflow.
5841 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5842 since it's now a duplicate of the other. This is more of
5843 a character than a buffer op, so better that it's in character.c.
5844 * fns.c, print.c: Adjust to above changes.
5845
2ff916cb
PE
58462011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5847
5848 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5849
f1b54466
PE
58502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5851
fb1ac845
PE
5852 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5853 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5854 (x_clipboard_manager_save): Now static.
5855 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5856
f1b54466
PE
5857 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5858 (crypto_hash_function): Now static.
5859 Fix pointer signedness problems. Avoid unnecessary initializations.
5860
a9f737ee
CY
58612011-05-27 Chong Yidong <cyd@stupidchicken.com>
5862
5863 * termhooks.h (Vselection_alist): Make it terminal-local.
5864
5865 * terminal.c (create_terminal): Initialize it.
5866
5867 * xselect.c: Support for clipboard managers.
5868 (Vselection_alist): Move to termhooks.h as terminal-local var.
5869 (LOCAL_SELECTION): New macro.
5870 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5871 (symbol_to_x_atom): Remove gratuitous arg.
5872 (x_handle_selection_request, lisp_data_to_selection_data)
5873 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5874 (x_own_selection, x_get_local_selection, x_convert_selection):
5875 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5876 (some_frame_on_display): Delete unused function.
5877 (Fx_own_selection_internal, Fx_get_selection_internal)
5878 (Fx_disown_selection_internal, Fx_selection_owner_p)
5879 (Fx_selection_exists_p): New optional frame arg.
5880 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5881 (x_handle_selection_clear): Don't treat other terminals with the
5882 same keyboard specially. Use the terminal-local Vselection_alist.
5883 (x_clear_frame_selections): Use Frun_hook_with_args.
5884
5885 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5886
5887 * xterm.h: Add support for those atoms.
5888
e067f0c1
CY
58892011-05-26 Chong Yidong <cyd@stupidchicken.com>
5890
5891 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5892 (converted_selections, conversion_fail_tag): New global variables.
5893 (x_selection_request_lisp_error): Free the above.
5894 (x_get_local_selection): Remove unnecessary code.
5895 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5896 of converted selections stored in converted_selections.
5897 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5898 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5899 (x_convert_selection): New function.
5900 (x_handle_selection_event): Simplify.
5901 (x_get_foreign_selection): Don't ignore incoming requests while
5902 waiting for an answer; this will fail when we implement
5903 SAVE_TARGETS, and seems unnecessary anyway.
5904 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5905 (Vx_sent_selection_functions): Doc fix.
5906
0f4aebc0
LL
59072011-05-26 Leo Liu <sdl.web@gmail.com>
5908
5909 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5910
e61124cd
YM
59112011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5912
5913 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5914
5915 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5916 for fringe update if it has periodic bitmap.
ac389d0c 5917 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5918 and fringe_bitmap_periodic_p.
5919
5920 * fringe.c (get_fringe_bitmap_data): New function.
5921 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5922 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5923 row. Mark glyph row for fringe update if periodicity changed.
5924
5925 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5926 for fringe update unless it has periodic bitmap.
5927
f16d9837
KH
59282011-05-25 Kenichi Handa <handa@m17n.org>
5929
5930 * xdisp.c (get_next_display_element): Set correct it->face_id for
5931 a static composition.
5932
e1b90ef6
LL
59332011-05-24 Leo Liu <sdl.web@gmail.com>
5934
5935 * deps.mk (fns.o):
5936 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5937
5938 * fns.c (crypto_hash_function, Fsha1): New function.
5939 (Fmd5): Use crypto_hash_function.
5940 (syms_of_fns): Add Ssha1.
5941
7400048f
PE
59422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5943
5944 * gnutls.c: Remove unused macros.
5945 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5946 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5947 Remove macros that are defined and never used.
5948 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5949
abb71cf4
CY
59502011-05-22 Chong Yidong <cyd@stupidchicken.com>
5951
5952 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5953 (Fx_get_selection_internal): Minor cleanup.
5954 (Fx_own_selection_internal): Rename arguments for consistency with
5955 select.el.
5956
6307db39
PE
59572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5958
5959 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5960
f3d4e0a4
CY
59612011-05-22 Chong Yidong <cyd@stupidchicken.com>
5962
5963 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5964
4d8ade89
YM
59652011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5966
5967 * dispnew.c (scrolling_window): Don't exclude the case that the
5968 last enabled row in the desired matrix touches the bottom boundary.
5969
32078c8d
GM
59702011-05-21 Glenn Morris <rgm@gnu.org>
5971
5972 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5973 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5974 and add some more files.
32078c8d 5975
7285dc67
EZ
59762011-05-20 Eli Zaretskii <eliz@gnu.org>
5977
5978 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5979 report_file_error introduced by the change from 2011-05-07.
5980
89d1bd22
PE
59812011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5982
5983 * systime.h (Time): Define only if emacs is defined.
5984 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5985 where the include path doesn't have X11/X.h by default. See
5986 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5987
cd394be1 59882011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5989
5990 * composite.c (find_automatic_composition): Fix previous change.
5991
b9704ad9
GM
59922011-05-20 Glenn Morris <rgm@gnu.org>
5993
5994 * lisp.mk: New file, split from Makefile.in.
5995 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5996 (shortlisp): Remove.
5997 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5998
4a720484
GM
59992011-05-19 Glenn Morris <rgm@gnu.org>
6000
6001 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6002 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6003 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6004 (lisp): Set the order to that of loadup.el.
6005 (shortlisp): Make it a copy of $lisp.
6006 (SOME_MACHINE_LISP): Remove.
6007 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6008 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6009
a28d4396
KH
60102011-05-18 Kenichi Handa <handa@m17n.org>
6011
6012 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6013 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6014 (find_automatic_composition): Mostly rewrite for efficiency.
6015
a2b1fa8e
JB
60162011-05-18 Juanma Barranquero <lekktu@gmail.com>
6017
6018 * makefile.w32-in: Update dependencies.
6019
8e1f5610
CS
60202011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6021
6022 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6023 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6024
7025ee00 60252011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6026
cdfa6eab
PE
6027 Fix some integer overflow issues, such as string length overflow.
6028
06d6db33
PE
6029 * insdel.c (count_size_as_multibyte): Check for string overflow.
6030
2b4560a8
PE
6031 * character.c (lisp_string_width): Check for string overflow.
6032 Use EMACS_INT, not int, for string indexes and lengths; in
6033 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6034 the resulting string length overflows an EMACS_INT; instead,
6035 report a string overflow if no precision given. When checking for
6036 precision exhaustion, use a check that cannot possibly have
6037 integer overflow. (Bug#8675)
6038 * character.h (lisp_string_width): Adjust to new signature.
6039
cb93f9be
PE
6040 * alloc.c (string_overflow): New function.
6041 (Fmake_string): Use it. This doesn't change behavior, but saves
6042 a few bytes and will simplify future changes.
6043 * character.c (string_escape_byte8): Likewise.
6044 * lisp.h (string_overflow): New decl.
6045
1a1f3366
PE
6046 Fixups, following up to the user-interface timestamp change.
6047 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6048 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6049 * msdos.c (mouse_get_pos): Likewise.
6050 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6051 * w32gui.h (Time): Define by including "systime.h" rather than by
6052 declaring it ourselves. (Bug#8664)
6053
d4e3e4d3
PE
6054 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6055 * image.c (clear_image_cache): Likewise.
6056
f6a24d19
PE
6057 * term.c (term_mouse_position): Don't assume time_t wraparound.
6058
08dc5ae6
PE
6059 Be more systematic about user-interface timestamps.
6060 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6061 and sometimes 'EMACS_UINT', to represent these timestamps.
6062 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6063 This makes the code easier to follow, and makes it easier to catch
6064 integer overflow bugs such as Bug#8664.
6065 * frame.c (Fmouse_position, Fmouse_pixel_position):
6066 Use Time, not unsigned long, for user-interface timestamps.
6067 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6068 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6069 * keyboard.h (last_event_timestamp): Likewise.
6070 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6071 * menu.h (xmenu_show): Likewise.
6072 * term.c (term_mouse_position): Likewise.
6073 * termhooks.h (struct input_event.timestamp): Likewise.
6074 (struct terminal.mouse_position_hook): Likewise.
6075 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6076 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6077 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6078 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6079 what it was before.
6080 * menu.h, termhooks.h: Include "systime.h", for Time.
6081
8e55734a
PE
6082 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6083 Don't assume that the difference between two unsigned long values
6084 can fit into an integer. At this point, we know button_down_time
6085 <= event->timestamp, so the difference must be nonnegative, so
6086 there's no need to cast the result if double-click-time is
6087 nonnegative, as it should be; check that it's nonnegative, just in
6088 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6089 apart (about 25 days). (Bug#8664)
8e55734a 6090
841f1b75 6091 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6092 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6093
3e26f69c
PE
6094 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6095 that always fit in int. Use a sentinel instead of a counter, to
6096 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6097 * frame.h (struct frame): Use int for menu_bar_items_used
6098 instead of EMACS_INT, since it always fits in int.
3e26f69c 6099
5cc152c0
PE
6100 * menu.c (grow_menu_items): Check for int overflow.
6101
d89eb65e
PE
6102 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6103
5235bd3e
PE
6104 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6105 Before, the code was not consistent. These values cannot exceed
6106 2**31 - 1 so there's no need to make them unsigned.
6107 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6108 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6109 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6110 as modifiers.
6111 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6112
bc827e23
PE
6113 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6114 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6115 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6116 presumably because the widths might not match.
6117
78eb494e
PE
6118 * window.c (size_window): Avoid needless test at loop start.
6119
04f2d78b
CB
61202011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6121
6122 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6123
d2fc7e3d 61242011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6125
6126 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6127
d2fc7e3d 61282011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6129
6130 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6131 `width' to `bar_area_x' and `bar_area_width', respectively.
6132 (x_scroll_run): Take account of fringe background extension.
6133
04f2d78b
CB
6134 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6135 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6136 `bar_area_width', respectively.
6137 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6138 background extension.
6139
79b70037
GM
61402011-05-10 Jim Meyering <meyering@redhat.com>
6141
6142 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6143
2f142cc5
JB
61442011-05-10 Juanma Barranquero <lekktu@gmail.com>
6145
6146 * image.c (Finit_image_library): Return t for built-in image types,
6147 like pbm and xbm. (Bug#8640)
6148
57679c86
AS
61492011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6150
6151 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6152
888c9e86
EZ
61532011-05-07 Eli Zaretskii <eliz@gnu.org>
6154
b0512a1d
EZ
6155 * w32console.c (Fset_screen_color): Doc fix.
6156 (Fget_screen_color): New function.
6157 (syms_of_ntterm): Defsubr it.
6158
7285dc67
EZ
6159 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6160 unlink the temporary file if Fcall_process didn't create it in the
6161 first place.
6162 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6163 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6164 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6165 cue to call_process_cleanup not to close that handle.
6166
4d3fcc8e
BK
61672011-05-07 Ben Key <bkey76@gmail.com>
6168
6169 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6170 one of two shell specific rules, either bootstrap-temacs-CMD or
6171 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6172 to the previous implementation of the bootstrap-temacs rule.
6173 The bootstrap-temacs-CMD rule is similar to the previous
6174 implementation of the bootstrap-temacs rule except that it
6175 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6176 variable.
6177
6178 These changes, along with some changes to nt/configure.bat,
6179 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6180 earlier fix to add support for --cflags and --ldflags options
6181 that include quotes so that it works whether make uses cmd or
6182 sh as the shell.
6183
b4289b64
MA
61842011-05-06 Michael Albinus <michael.albinus@gmx.de>
6185
6186 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6187 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6188 is a constant.
6189 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6190 a string. Handle both cases.
6191 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6192 (Fdbus_register_method): Use Qinvalid_function.
6193
af4c0e28
JB
61942011-05-06 Juanma Barranquero <lekktu@gmail.com>
6195
6196 * makefile.w32-in: Update dependencies.
6197 (LISP_H): Add inttypes.h and stdin.h.
6198 (PROCESS_H): Add unistd.h.
6199
c51453d9
EZ
62002011-05-06 Eli Zaretskii <eliz@gnu.org>
6201
6202 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6203 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6204
8ff0ac3c 62052011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6206
4c4b566b
PE
6207 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6208
aab2b9b5
PE
6209 * term.c (vfatal): Remove stray call to va_end.
6210 It's not needed and the C Standard doesn't allow it here anyway.
6211
c378da0b
PE
6212 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6213 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6214
288b08c7
PE
6215 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6216 bytes.
6217
e3601888
PE
6218 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6219
db6c0e74
PE
6220 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6221
dd5963ea
PE
6222 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6223
88c9450f
PE
6224 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6225
2f9442b8
PE
6226 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6227
c032b5f8
PE
6228 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6229 * charset.c (Fdefine_charset_internal): Don't initialize
6230 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6231 32-bit int (Bug#8600).
a108c10b
PE
6232
6233 * lread.c (read_integer): Be more consistent with string-to-number.
6234 Use string_to_number to do the actual conversion; this avoids
6235 rounding errors and fixes some other screwups. Without this fix,
6236 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6237 (digit_to_number): Move earlier, for benefit of read_integer.
6238 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6239 not a digit in any supported base. (Bug#8602)
a108c10b 6240
ad5f9eea
PE
6241 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6242
aec1708a
PE
6243 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6244 to match comment at start of function. This also removes a
6245 GCC warning about overflow in a 32+64-bit port.
6246
47be4ab5
PE
6247 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6248
371cac43
PE
6249 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6250 Reported by Stefan Monnier in
6251 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6252 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6253 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6254
d01a7826
PE
6255 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6256 (EMACS_UINTPTR): Likewise, with uintptr_t.
6257
7fd47d5c
PE
6258 * lisp.h: Prefer 64-bit EMACS_INT if available.
6259 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6260 on 32-bit hosts that have 64-bit int, so that they can access
6261 large files.
122b0c86
PE
6262 However, temporarily disable this change unless the temporary
6263 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6264
8727937b
PE
6265 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6266
8ac068ac
PE
6267 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6268 This removes an assumption that EMACS_INT and long are the same
6269 width as pointers. The assumption is true for Emacs porting targets
6270 now, but we want to make other targets possible.
6271 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6272 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6273 In the rest of the code, change types of integers that hold casted
6274 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6275 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6276 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6277 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6278 No need to cast type when ORing.
6279 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6280 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6281 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6282 assume EMACS_INT is the same width as char *.
6283 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6284 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6285 Remove no-longer-needed casts.
6286 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6287 (xg_tool_bar_help_callback, xg_make_tool_item):
6288 Use EMACS_INTPTR to hold an integer
6289 that will be cast to void *; this can avoid a GCC warning
6290 if EMACS_INT is not the same width as void *.
6291 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6292 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6293 (current_message_1, set_message_1):
6294 Use a local to convert to proper width without a cast.
6295 * xmenu.c (dialog_selection_callback): Likewise.
6296
ede49d71
PE
6297 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6298 Also, don't assume VALBITS / RAND_BITS is less than 5,
6299 and don't rely on undefined behavior when shifting a 1 left into
6300 the sign bit.
6301 * lisp.h (get_random): Change signature to match.
6302
2f30ecd0
PE
6303 * lread.c (hash_string): Use size_t, not int, for hash computation.
6304 Normally we prefer signed values; but hashing is special, because
6305 it's better to use unsigned division on hash table sizes so that
6306 the remainder is nonnegative. Also, size_t is the natural width
6307 for hashing into memory. The previous code used 'int', which doesn't
6308 retain enough info to hash well into very large tables.
6309 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6310
2a866e7b
PE
6311 * dbusbind.c: Don't possibly lose pointer info when converting.
6312 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6313 Use XPNTR rather than XHASH, so that the high-order bits of
6314 the pointer aren't lost when converting through void *.
6315
51639eac
PE
6316 * eval.c (Fautoload): Don't double-shift a pointer.
6317
92394119
PE
6318 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6319
dbdb9a7c
JB
63202011-05-06 Juanma Barranquero <lekktu@gmail.com>
6321
6322 * gnutls.c (DEF_GNUTLS_FN):
6323 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6324
db7a0b4f
AS
63252011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6326
6327 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6328 marker. (Bug#8610)
6329
cd394be1 63302011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6331
6332 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6333 New version that can reserve upto 2GB of heap space.
6334
f7ff1b0f 63352011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6336
6337 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6338
639c109b
TZ
63392011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6340
6341 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6342 `gnutls_certificate_set_x509_key_file'.
6343
d2127135
JB
63442011-05-05 Juanma Barranquero <lekktu@gmail.com>
6345
6346 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6347 Update dependencies.
6348
e968f4f3
JB
63492011-05-04 Juanma Barranquero <lekktu@gmail.com>
6350
6351 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6352 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6353 Remove unused parameter `fildes'.
6354 * process.c (read_process_output, send_process): Don't pass it.
6355
84d358f0
JB
63562011-05-04 Juanma Barranquero <lekktu@gmail.com>
6357
6358 Fix previous change: the library cache is defined in w32.c.
6359 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6360 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6361
0898ca10
JB
63622011-05-04 Juanma Barranquero <lekktu@gmail.com>
6363
6364 Implement dynamic loading of GnuTLS on Windows.
6365
6366 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6367 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6368 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6369 Declare.
6370
6371 * gnutls.c (Qgnutls_dll): Define.
6372 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6373 (gnutls_*): Declare function pointers.
6374 (init_gnutls_functions): New function to initialize function pointers.
6375 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6376 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6377 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6378 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6379 (emacs_gnutls_write, emacs_gnutls_read)
6380 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6381 (Fgnutls_available_p): New function.
6382 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6383 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6384 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6385
6386 * image.c: Include w32.h.
6387 (Vimage_type_cache): Delete.
6388 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6389 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6390 (w32_delayed_load): Move to w32.c.
6391
6392 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6393
6394 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6395 (w32_delayed_load): Move from image.c. When loading a library, record
6396 its filename in the :loaded-from property of the library id.
6397 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6398 Initialize and staticpro them.
6399 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6400
6401 * process.c: Include lisp.h before w32.h, not after.
6402 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6403 instead of gnutls_record_check_pending.
6404
6405 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6406
ff4de4aa
TZ
64072011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6408
6409 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6410 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6411 as passed in.
6412
abe95abb
JD
64132011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6414
6415 * xterm.c (x_set_frame_alpha): Do not set property on anything
6416 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6417
e16e55d4
JB
64182011-05-02 Juanma Barranquero <lekktu@gmail.com>
6419
6420 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6421
bafcf6a5
JB
64222011-05-02 Juanma Barranquero <lekktu@gmail.com>
6423
6424 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6425 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6426 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6427 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6428 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6429 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6430 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6431 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6432 (Qgnutls_bootprop_callbacks_verify): Make static.
6433
e7a6747f
AS
64342011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6435
19ed11ba
AS
6436 * callproc.c: Indentation fixup.
6437
e7a6747f 6438 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6439 (wait_for_termination, interruptible_wait_for_termination):
6440 Move after wait_for_termination_1.
e7a6747f 6441
1ef14cb4
LMI
64422011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6443
6444 * sysdep.c (interruptible_wait_for_termination): New function
6445 which is like wait_for_termination, but allows keyboard
6446 interruptions.
6447
6448 * callproc.c (Fcall_process): Add (:file "file") as an option for
6449 the STDOUT buffer.
6450 (Fcall_process_region): Ditto.
6451
330d880c
EZ
64522011-04-30 Eli Zaretskii <eliz@gnu.org>
6453
8db90b73
EZ
6454 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6455 rather than `XVECTOR (FOO)->size'.
6456
330d880c
EZ
6457 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6458 inttypes.h, as a gnulib replacement is used if it not available in
6459 system headers.
6460
15cbd324
EZ
64612011-04-21 Eli Zaretskii <eliz@gnu.org>
6462
6463 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6464 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6465 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6466
6467 * coding.c (coding_alloc_by_realloc): Error out if destination
6468 will grow beyond MOST_POSITIVE_FIXNUM.
6469 (decode_coding_emacs_mule): Abort if there isn't enough place in
6470 charbuf for the composition carryover bytes. Reserve an extra
6471 space for up to 2 characters produced in a loop.
6472 (decode_coding_iso_2022): Abort if there isn't enough place in
6473 charbuf for the composition carryover bytes.
6474
64752011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6476
ae940cca
EZ
6477 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6478 aborting when %lld or %lll format is passed.
6479 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6480 %llo or %llx format is passed. (Bug#8545)
6481
03ab8921
EZ
6482 * window.c (window_scroll_line_based): Use a marker instead of
6483 simple variables to record original value of point. (Bug#7952)
6484
afda1437
EZ
6485 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6486 produced by %s or %c overflows available buffer space. (Bug#8545)
6487
f76dee0c
PE
64882011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6489
6490 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6491 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6492
fdc5744d
JB
64932011-04-28 Juanma Barranquero <lekktu@gmail.com>
6494
6495 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6496
638f053a
JB
64972011-04-28 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * keyboard.c (Qdelayed_warnings_hook): Define.
6500 (command_loop_1): Run `delayed-warnings-hook'
6501 if Vdelayed_warnings_list is non-nil.
6502 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6503 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6504
d178f871
EZ
65052011-04-28 Eli Zaretskii <eliz@gnu.org>
6506
6507 * doprnt.c (doprnt): Don't return value smaller than the buffer
6508 size if the message was truncated. (Bug#8545).
6509
b124fd93
JB
65102011-04-28 Juanma Barranquero <lekktu@gmail.com>
6511
6512 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6513 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6514
e810457d
PE
65152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6516
6517 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6518
ea51cceb
JB
65192011-04-27 Juanma Barranquero <lekktu@gmail.com>
6520
6521 * makefile.w32-in: Update dependencies.
6522
94dcfacf
EZ
65232011-04-27 Eli Zaretskii <eliz@gnu.org>
6524
6525 Improve `doprnt' and its usage. (Bug#8545)
6526 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6527 `format_end'. Remove support for %l as a conversion specifier.
6528 Don't use xrealloc. Improve diagnostics when the %l size modifier
6529 is used. Update the commentary.
6530
6531 * eval.c (verror): Simplify calculation of size_t.
6532
6533 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6534 messages.
6535
f61f41d7
PE
65362011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6537
6538 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6539 change.
6540
96fb4434
PE
65412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6544 This makes this file independent of the recent pseudovector change.
6545
671875da 65462011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6547
69e9b5a3
PE
6548 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6549
b5f869a7 6550 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6551 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6552 Remove unused local.
c8926152 6553 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6554
841a1577 6555 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6556 GCC 4.6.0 optimizes based on type-based alias analysis.
6557 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6558 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6559 != &v->size, and therefore "v->size = 1; b->size = 2; return
6560 v->size;" must therefore return 1. This assumption is incorrect
6561 for Emacs, since it type-puns struct Lisp_Vector * with many other
6562 types. To fix this problem, this patch adds a new type struct
f904488f 6563 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6564 and pseudovectors, and helps optimizing compilers not get fooled
6565 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6566 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6567 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6568 the size member.
eab3844f
PE
6569 (XSETPVECTYPE): Rewrite in terms of new macro.
6570 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6571 This is a bit clearer, and further avoids the possibility of
6572 undesirable aliasing.
6573 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6574 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6575 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6576 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6577 (ASIZE): Now uses header.size rather than size.
6578 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6579 to avoid the hassle of writing XVECTOR (foo)->header.size.
6580 (struct vectorlike_header): New type.
eab3844f
PE
6581 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6582 object, to help avoid aliasing.
6583 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6584 (SUBRP): Likewise, since Lisp_Subr is a special case.
6585 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6586 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6587 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6588 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6589 changed to be "header.size" and "header.next".
6590 * buffer.h (struct buffer): Likewise.
6591 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6592 * frame.h (struct frame): Likewise.
6593 * process.h (struct Lisp_Process): Likewise.
6594 * termhooks.h (struct terminal): Likewise.
6595 * window.c (struct save_window_data, struct saved_window): Likewise.
6596 * window.h (struct window): Likewise.
6597 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6598 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6599 * buffer.c (init_buffer_once): Likewise.
6600 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6601 special case.
6602 * process.c (Fformat_network_address): Use local var for size,
6603 for brevity.
6604
0df1eac5
PE
6605 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6606
847ab9d1 6607 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6608 * data.c (atof): Remove decl; no longer used or needed.
6609 (digit_to_number): Move to lread.c.
6610 (Fstring_to_number): Use new string_to_number function, to be
6611 consistent with how the Lisp reader treats infinities and NaNs.
6612 Do not assume that floating-point numbers represent EMACS_INT
6613 without losing information; this is not true on most 64-bit hosts.
6614 Avoid double-rounding errors, by insisting on integers when
6615 parsing non-base-10 numbers, as the documentation specifies.
6616 * lisp.h (string_to_number): New decl, replacing ...
6617 (isfloat_string): Remove.
bc0a5c13 6618 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6619 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6620 appears to have been a coding error. Similarly, do not accept
6621 strings like +-1e0 as floating point numbers. Do not report
6622 overflow for integer overflows unless the base is not 10 which
6623 means we have no simple and reliable way to continue.
6624 Break out the floating-point parsing into a new
6625 function string_to_number, so that Fstring_to_number parses
6626 floating point numbers consistently with the Lisp reader.
04f2d78b 6627 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6628 (E_CHAR, EXP_INT): Remove, replacing with ...
6629 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6630 (string_to_number): New function, replacing isfloat_string.
6631 This function checks for valid syntax and produces the resulting
6632 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6633 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6634 so that overflow for non-base-10 numbers is reported only when
6635 there's no portable and simple way to convert to floating point.
452f4150 6636
67769ffc
PE
6637 * textprop.c (set_text_properties_1): Rewrite for clarity,
6638 and to avoid GCC warning about integer overflow.
6639
c20db43f
PE
6640 * intervals.h (struct interval): Use EMACS_INT for members
6641 where EMACS_UINT might cause problems. See
6642 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6643 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6644 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6645 All uses changed.
37aa2f85
PE
6646 (offset_intervals): Tell GCC not to worry about length overflow
6647 when negating a negative length.
c20db43f 6648
2538aa2f
PE
6649 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6650 (overrun_check_free): Likewise.
6651
f2d3008d
PE
6652 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6653 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6654 word size.
6655
ec8df744
PE
6656 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6657 (gnutls_make_error): Rename local to avoid shadowing.
6658 (gnutls_emacs_global_deinit): ifdef out; not used.
6659 (Fgnutls_boot): Use const for pointer to readonly storage.
6660 Comment out unused local. Fix pointer signedness problems.
6661
640ee02d
PE
6662 * lread.c (openp): Don't stuff size_t into an 'int'.
6663 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6664 about possible signed overflow.
6665
6048fb2a
PE
6666 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6667 (GDK_KEY_g): Don't define if already defined.
6668 (xg_prepare_tooltip): Avoid pointer signedness problem.
6669 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6670
fa3c87e1
PE
6671 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6672 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6673
2172544b
PE
6674 * xfns.c (Fx_window_property): Simplify a bit,
6675 to make a bit faster and to avoid GCC 4.6.0 warning.
6676 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6677
9b821a21
PE
6678 * fns.c (internal_equal): Don't assume size_t fits in int.
6679
3c616cfa
PE
6680 * alloc.c (compact_small_strings): Tighten assertion a little.
6681
c2982e87
PE
6682 Replace pEd with more-general pI, and fix some printf arg casts.
6683 * lisp.h (pI): New macro, generalizing old pEd macro to other
6684 conversion specifiers. For example, use "...%"pI"d..." rather
6685 than "...%"pEd"...".
6686 (pEd): Remove. All uses replaced with similar uses of pI.
6687 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6688 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6689 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6690 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6691 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6692 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6693 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6694 64-bit hosts.
6695 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6696 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6697 * print.c (safe_debug_print, print_object): Likewise.
6698 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6699 to int.
6f04d126
PE
6700 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6701 avoiding the 0 flag, which is not portable.
c2982e87
PE
6702 * process.c (Fmake_network_process): Use pI to avoid cast.
6703 * region-cache.c (pp_cache): Likewise.
6704 * xdisp.c (decode_mode_spec): Likewise.
6705 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6706 behavior on 64-bit hosts with printf arg.
6f04d126 6707 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6708 (x_stop_queuing_selection_requests): Likewise.
6709 (x_get_window_property): Don't truncate byte count to an 'int'
6710 when tracing.
0b432f21 6711
5e073ec7
PE
6712 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6713 here, since it parses constructs like leading '-' and spaces,
6714 which are not wanted; and it overflows with large numbers.
6715 Instead, simply match F[0-9]+, which is what is wanted anyway.
6716
36372bf9
PE
6717 * alloc.c: Remove unportable assumptions about struct layout.
6718 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6719 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6720 (allocate_vectorlike, make_pure_vector): Use the new macros,
6721 plus offsetof, to remove unportable assumptions about struct layout.
6722 These assumptions hold on all porting targets that I know of, but
6723 they are not guaranteed, they're easy to remove, and removing them
6724 makes further changes easier.
6725
0b432f21
PE
6726 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6727 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6728 (string_overrun_cookie): Now const. Use initializers that
6729 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6730 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6731 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6732 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6733 multiple of sizeof (EMACS_INT); it need not be, if
6734 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6735 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6736
895009e1
JB
67372011-04-26 Juanma Barranquero <lekktu@gmail.com>
6738
6739 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6740
6a7a1b0b
TZ
67412011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6742
6743 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6744 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6745 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6746
841a1577 67472011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6748
6749 * lisp.h (Qdebug): List symbol.
895009e1 6750 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6751 * keyboard.c (debug-on-event): New variable.
6752 (handle_user_signal): Break into debugger when debug-on-event
6753 matches the current signal symbol.
6754
f2d3ba6f
DN
67552011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6756
6757 * alloc.c (check_sblock, check_string_bytes)
6758 (check_string_free_list): Convert to standard C.
6759
42ce4c63
TZ
67602011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6761
6762 * w32.c (emacs_gnutls_push): Fix typo.
6763
825cd63c
EZ
67642011-04-25 Eli Zaretskii <eliz@gnu.org>
6765
fb11d64d
EZ
6766 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6767 "cast to pointer from integer of different size".
6768
825cd63c
EZ
6769 Improve doprnt and its use in verror. (Bug#8545)
6770 * doprnt.c (doprnt): Document the set of format control sequences
6771 supported by the function. Use SAFE_ALLOCA instead of always
6772 using `alloca'.
6773
6774 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6775 is one byte too soon. Don't use xrealloc; instead xfree and
6776 xmalloc anew.
6777
e061a11b
TZ
67782011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6779
6780 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6781 callbacks stage.
6782
6783 * gnutls.c: Renamed global_initialized to
6784 gnutls_global_initialized. Added internals for the
6785 :verify-hostname-error, :verify-error, and :verify-flags
6786 parameters of `gnutls-boot' and documented those parameters in the
6787 docstring. Start callback support.
9173deec
JB
6788 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6789 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6790 on error. Return error code.
e061a11b
TZ
6791 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6792 (emacs_gnutls_read): Likewise.
6793 (Fgnutls_boot): Return handshake error code.
6794 (emacs_gnutls_handle_error): New function.
6795 (wsaerror_to_errno): Likewise.
6796
6797 * w32.h (emacs_gnutls_pull): Add prototype.
6798 (emacs_gnutls_push): Likewise.
6799
6800 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6801 (emacs_gnutls_push): Likewise.
6802
68032011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6804
6805 * process.c (wait_reading_process_output): Check if GnuTLS
6806 buffered some data internally if no FDs are set for TLS
6807 connections.
6808
6809 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6810 (LIBS): Link to USER_LIBS.
6811 ($(BLD)/gnutls.$(0)): New target.
6812
fa6996bc
EZ
68132011-04-24 Eli Zaretskii <eliz@gnu.org>
6814
eb35682e
EZ
6815 * xdisp.c (handle_single_display_spec): Rename the
6816 display_replaced_before_p argument into display_replaced_p, to
6817 make it consistent with the commentary. Fix typos in the
6818 commentary.
6819
e2ad650c
EZ
6820 * textprop.c (syms_of_textprop): Remove dead code.
6821 (copy_text_properties): Delete obsolete commentary about an
6822 interface that was deleted long ago. Fix typos in the description
6823 of arguments.
6824
1b2de274
EZ
6825 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6826 to changes in oldXMenu/XMenu.h from 2011-04-16.
6827 <menu_help_message, prev_menu_help_message>: Constify.
6828 (IT_menu_make_room): menu->help_text is now `const char **';
6829 adjust.
6830
6831 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6832 to changes in oldXMenu/XMenu.h from 2011-04-16.
6833 (struct XMenu): Declare `help_text' `const char **'.
6834
6835 * xfaces.c <Qunspecified>: Make extern again.
6836
6837 * syntax.c: Include sys/types.h before including regex.h, as
6838 required by Posix.
6839
762b15be
EZ
6840 * doc.c (get_doc_string): Improve the format passed to `error'.
6841
6842 * doprnt.c (doprnt): Improve commentary.
6843
6844 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6845
6846 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6847 them with etags.
6848
f1052e5d
EZ
6849 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6850 changes in globals.h immediately force recompilation.
762b15be
EZ
6851 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6852 $(CURDIR)/s/ms-w32.h.
6853 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6854
fa6996bc
EZ
6855 * character.c (Fchar_direction): Function deleted.
6856 (syms_of_character): Don't defsubr it.
6857 <char-direction-table>: Deleted.
6858
e6c3da20
EZ
68592011-04-23 Eli Zaretskii <eliz@gnu.org>
6860
6861 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6862 * doprnt.c: Include limits.h.
6863 (SIZE_MAX): New macro.
04f2d78b
CB
6864 (doprnt): Return a size_t value. 2nd arg is now size_t.
6865 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6866 Improve overflow protection. Support `l' modifier for integer
6867 conversions. Support %l conversion. Don't assume an EMACS_INT
6868 argument for integer conversions and for %c.
6869
6870 * lisp.h (doprnt): Restore prototype.
6871
6872 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6873 $(SRC)/character.h.
6874
6875 * Makefile.in (base_obj): Add back doprnt.o.
6876
6877 * deps.mk (doprnt.o): Add back prerequisites.
6878 (callint.o): Depend on character.h.
6879
6880 * eval.c (internal_lisp_condition_case): Include the handler
6881 representation in the error message.
6882 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6883 when breaking from the loop.
6884
6885 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6886
6887 * callint.c (Fcall_interactively): When displaying error message
6888 about invalid control letter, pass the character's codepoint, not
6889 a pointer to its multibyte form. Improve display of the character
6890 in octal and display also its hex code.
6891
6892 * character.c (char_string): Use %x to display the (unsigned)
6893 codepoint of an invalid character, to avoid displaying a bogus
6894 negative value.
6895
6896 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6897 `error', not SYMBOL_NAME itself.
6898
6899 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6900 character arguments to `error'.
6901
6902 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6903 to `error' in error message about FINAL_CHAR argument. Make sure
6904 FINAL_CHAR is a character, and use %c when it is passed as
6905 argument to `error'.
6906
4ffd0d6b 69072011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6908
6909 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6910
6911 * w32.c: Include <time.h>.
6912 (sys_localtime): New function.
6913
4ffd0d6b 69142011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6915
6916 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6917
4ffd0d6b 6918 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6919
4ffd0d6b 69202011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6921
4ffd0d6b
GM
6922 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6923 zombies (Bug#8467).
aac0c6e3 6924
04c56954
EZ
69252011-04-19 Eli Zaretskii <eliz@gnu.org>
6926
6927 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6928 gl_state.e_property when gl_state.object is Qt.
6929
6930 * insdel.c (make_gap_larger): Remove limitation of buffer size
6931 to <= INT_MAX.
6932
16a43933
CY
69332011-04-18 Chong Yidong <cyd@stupidchicken.com>
6934
6935 * xdisp.c (lookup_glyphless_char_display)
6936 (produce_glyphless_glyph): Handle cons cell entry in
6937 glyphless-char-display.
6938 (Vglyphless_char_display): Document it.
6939
6940 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6941 glyphless-char-display.
6942
4581706e
CY
69432011-04-17 Chong Yidong <cyd@stupidchicken.com>
6944
6945 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6946
6947 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6948
6949 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6950 definition for no-X builds.
6951
4887c6e2 69522011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6953
fd35b6f9
PE
6954 Static checks with GCC 4.6.0 and non-default toolkits.
6955
5c1ccb01
PE
6956 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6957
006c5daa
PE
6958 * process.c (keyboard_bit_set): Define only if SIGIO.
6959 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6960 (send_process): Repair possible setjmp clobbering.
6961
efc736d3
PE
6962 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6963
4e2fe2e6
PE
6964 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6965
f97334a2
PE
6966 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6967
4e75f29d
PE
6968 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6969 Define only if needed.
6970
90efadd1
PE
6971 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6972 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6973 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6974
3c647824
PE
6975 * dispextern.h (struct redisplay_interface): Rename param
6976 to avoid shadowing.
e264f262 6977 * termhooks.h (struct terminal): Likewise.
761383f4 6978 * xterm.c (xembed_send_message): Likewise.
3c647824 6979
b58c5c4a
PE
6980 * insdel.c (make_gap_smaller): Define only if
6981 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6982
cad59032
PE
6983 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6984 it.
6985
c339dc2e
PE
6986 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6987 so that we aren't warned about unused symbols.
6988
91a3e27b
PE
6989 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6990
399c71d3 6991 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6992
8ffc96f5
PE
6993 * xfns.c (x_real_positions): Mark locals as initialized.
6994
eef9bc79
PE
6995 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6996
098db9dd
PE
6997 * xterm.c: Fix problems found by static analysis with other toolkits.
6998 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6999 (x_dispatch_event): Declare static if USE_GTK, and
7000 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7001 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7002 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7003 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7004 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7005
eb18f6cc
PE
7006 * xmenu.c (menu_help_callback): Pointer type fixes.
7007 Use const pointers when pointing at readonly data. Avoid pointer
7008 signedness clashes.
7009 (FALSE): Remove unused macro.
7010 (update_frame_menubar): Remove unused decl.
7011
1fe72bf8
PE
7012 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7013
60d9e1db
PE
7014 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7015 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7016 (single_menu_item): Rename local to avoid shadowing.
7017
39261c26
PE
7018 * keyboard.c (make_lispy_event): Remove unused local var.
7019
018c5e19
PE
7020 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7021 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7022
63d2b86e
PE
7023 * bitmaps: Change bitmaps from unsigned char back to the X11
7024 compatible char. Avoid the old compiler warnings about
7025 out-of-range initializers by using, for example, '\xab' rather
7026 than 0xab.
7027
aefd87e1
PE
7028 * xgselect.c (xgselect_initialize): Check vs interface
7029 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7030
bf501fb9
PE
7031 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7032
e9829fdf
PE
7033 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7034 to read-only memory.
7035
1086c095
PE
7036 * fns.c (vector): Remove; this old hack is no longer needed.
7037
2baccd04 7038 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7039 Remove unused var.
dde42981 7040 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7041
72391843 7042 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7043
436c16df 7044 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7045 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7046 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7047
92bb796d 7048 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7049 (x_term_init): Remove local to avoid shadowing.
92bb796d 7050
764430a3 7051 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7052
7053 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7054 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7055
d1dfb56c
EZ
70562011-04-16 Eli Zaretskii <eliz@gnu.org>
7057
c4354cb4
EZ
7058 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7059
d1dfb56c
EZ
7060 Fix regex.c, syntax.c and friends for buffers > 2GB.
7061 * syntax.h (struct gl_state_s): Declare character position members
7062 EMACS_INT.
7063
7064 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7065
04f2d78b
CB
7066 * textprop.c (verify_interval_modification, interval_of):
7067 Declare arguments EMACS_INT.
d1dfb56c
EZ
7068
7069 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7070 EMACS_INT.
7071
7072 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7073
7074 * indent.c (Fvertical_motion): Local variable it_start is now
7075 EMACS_INT.
7076
7077 * regex.c (re_match, re_match_2, re_match_2_internal)
7078 (bcmp_translate, regcomp, regexec, print_double_string)
7079 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7080 (re_compile_pattern, re_exec): Declare arguments and local
7081 variables `size_t' and `ssize_t' and return values `regoff_t', as
7082 appropriate.
7083 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7084 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7085 <compile_stack_type>: `size' and `avail' are now `size_t'.
7086
7087 * regex.h <regoff_t>: Use ssize_t, not int.
7088 (re_search, re_search_2, re_match, re_match_2): Arguments that
7089 specify buffer/string position and length are now ssize_t and
7090 size_t. Return type is regoff_t.
7091
613052cd
BK
70922011-04-16 Ben Key <bkey76@gmail.com>
7093
7094 * nsfont.m: Fixed bugs in ns_get_family and
7095 ns_descriptor_to_entity that were caused by using free to
7096 deallocate memory blocks that were allocated by xmalloc (via
7097 xstrdup). This caused Emacs to crash when compiled with
7098 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7099 --enable-checking=xmallocoverrun). xfree is now used to
7100 deallocate these memory blocks.
7101
4170f62f 71022011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7103
71b41406
PE
7104 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7105
9587a89d
PE
7106 emacs_write: Accept and return EMACS_INT for sizes.
7107 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7108 et seq.
7109 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7110 Accept and return EMACS_INT.
7111 (emacs_gnutls_write): Return the number of bytes written on
7112 partial writes.
7113 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7114 (emacs_read, emacs_write): Remove check for negative size, as the
7115 Emacs source code has been audited now.
9587a89d
PE
7116 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7117 (emacs_read, emacs_write): Use it.
273a5f82
PE
7118 * process.c (send_process): Adjust to the new signatures of
7119 emacs_write and emacs_gnutls_write. Do not attempt to store
7120 a byte offset into an 'int'; it might overflow.
9587a89d 7121 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7122
3e047f51
PE
7123 * sound.c: Don't assume sizes fit in 'int'.
7124 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7125 Return EMACS_INT, not int.
3e047f51 7126 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7127 Accept EMACS_INT, not int.
7128 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7129 record read return values.
7130
cc39a9db
BK
71312011-04-15 Ben Key <bkey76@gmail.com>
7132
c9d0ec6d
JB
7133 * keyboard.c (Qundefined): Don't declare static since it is used
7134 in nsfns.m.
7135 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7136 static since they are used in nsfont.m.
cc39a9db 7137
6c60eb9f
SM
71382011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7139
7140 * process.c (Qprocessp): Don't declare static.
7141 * lisp.h (Qprocessp): Declare again.
7142
7990b61a
JB
71432011-04-15 Juanma Barranquero <lekktu@gmail.com>
7144
7145 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7146
5d4cb038
PE
71472011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7148
8bd7b830 7149 Improve C-level modularity by making more things 'static'.
cd64ea1d 7150
e3b27b31
PE
7151 Don't publish debugger-only interfaces to other modules.
7152 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7153 (verify_bytepos, count_markers): Move decls to the only modules
7154 that need them.
7155 * region-cache.h (pp_cache): Likewise.
7156 * window.h (check_all_windows): Likewise.
7157 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7158
5d4cb038
PE
7159 * sysdep.c (croak): Now static, if
7160 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7161 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7162
7163 * alloc.c (refill_memory_reserve): Now static if
7164 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7165 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7166
e87b6180
PE
7167 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7168 Define only if USE_LUCID.
7169
ac64929e
PE
7170 * xrdb.c (x_customization_string, x_rm_string): Now static.
7171
6f37259d
PE
7172 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7173 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7174
1683e3ab
PE
7175 * xdisp.c (draw_row_with_mouse_face): Now static.
7176 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7177
de9c2632
PE
7178 * window.h (check_all_windows): Mark externally visible.
7179
2b96acb7
PE
7180 * window.c (window_deletion_count): Now static.
7181
7182 * undo.c: Make symbols static if they're not exported.
7183 (last_undo_buffer, last_boundary_position, pending_boundary):
7184 Now static.
7185
50436f33
PE
7186 * textprop.c (interval_insert_behind_hooks): Now static.
7187 (interval_insert_in_front_hooks): Likewise.
7188
64520e5c
PE
7189 * term.c: Make symbols static if they're not exported.
7190 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7191 (max_frame_lines, tty_set_terminal_modes):
7192 (tty_reset_terminal_modes, tty_turn_off_highlight):
7193 (get_tty_terminal): Now static.
7194 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7195 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7196 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7197 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7198 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7199
1fa53021
PE
7200 * sysdep.c: Make symbols static if they're not exported.
7201 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7202 Now static.
7203 (sigprocmask_set, full_mask): Remove; unused.
7204 (wait_debugging): Mark as visible.
7205 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7206 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7207
d4b43b22
PE
7208 * syntax.c (syntax_temp): Define only if !__GNUC__.
7209
b7c513d0
PE
7210 * sound.c (current_sound_device, current_sound): Now static.
7211
989b29ad
PE
7212 * search.c (searchbufs, searchbuf_head): Now static.
7213
13a55a78
PE
7214 * scroll.c (scroll_cost): Remove; unused.
7215 * dispextern.h (scroll_cost): Remove decl.
7216
de68a1fc
PE
7217 * region-cache.h (pp_cache): Mark as externally visible.
7218
40ccffa6
PE
7219 * process.c: Make symbols static if they're not exported.
7220 (process_tick, update_tick, create_process, chan_process):
7221 (Vprocess_alist, proc_buffered_char, datagram_access):
7222 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7223 (deactivate_process): Mark defn as static, as well as decl.
7224 * lisp.h (create_process): Remove decl.
7225 * process.h (chan_process, Vprocess_alist): Remove decls.
7226
ad64fc97
PE
7227 * print.c: Make symbols static if they're not exported.
7228 (print_depth, new_backquote_output, being_printed, print_buffer):
7229 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7230 (print_interval, print_number_index, initial_stderr_stream):
7231 Now static.
7232 * lisp.h (Fprinc): Remove decl.
7233 (debug_output_compilation_hack): Mark as externally visible.
7234
adddb265
PE
7235 * sysdep.c (croak): Move decl from here to syssignal.h.
7236 * syssignal.h (croak): Put it here, so the API can be checked when
7237 'croak' is called from dissociate_if_controlling_tty.
7238
1717ede2
PE
7239 * minibuf.c: Make symbols static if they're not exported.
7240 (minibuf_save_list, choose_minibuf_frame): Now static.
7241 * lisp.h (choose_minibuf_frame): Remove decl.
7242
fa5fb2bc
PE
7243 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7244
1e3890d1
PE
7245 * lread.c: Make symbols static if they're not exported.
7246 (read_objects, initial_obarray, oblookup_last_bucket_number):
7247 Now static.
7248 (make_symbol): Remove; unused.
7249 * lisp.h (initial_obarray, make_symbol): Remove decls.
7250
8a1414fa
PE
7251 * keyboard.c: Make symbols static if they're not exported.
7252 (single_kboard, recent_keys_index, total_keys, recent_keys):
7253 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7254 (this_single_command_key_start, echoing, last_auto_save):
7255 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7256 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7257 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7258 (Vlispy_mouse_stem, double_click_count):
7259 Now static.
7260 (force_auto_save_soon): Define only if SIGDANGER.
7261 (ignore_mouse_drag_p): Now static if
7262 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7263 (print_help): Remove; unused.
7264 (stop_character, last_timer_event): Mark as externally visible.
7265 * keyboard.h (ignore_mouse_drag_p): Declare only if
7266 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7267 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7268 * lisp.h (echoing): Remove decl.
7269 (force_auto_save_soon): Declare only if SIGDANGER.
7270 * xdisp.c (redisplay_window): Simplify code, to make it more
7271 obvious that ignore_mouse_drag_p is not accessed if !defined
7272 USE_GTK && !defined HAVE_NS.
7273
93ea6e8f
PE
7274 * intervals.c: Make symbols static if they're not exported.
7275 (merge_properties_sticky, merge_interval_right, delete_interval):
7276 Now static.
7277 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7278
77382fcc
PE
7279 * insdel.c: Make symbols static if they're not exported.
7280 However, leave prepare_to_modify_buffer alone. It's never
7281 called from outside this function, but that appears to be a bug.
7282 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7283 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7284 (adjust_after_replace_noundo): Remove; unused.
7285 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7286 (signal_before_change): Remove decls.
77382fcc 7287
9306c32e
PE
7288 * indent.c (val_compute_motion, val_vmotion): Now static.
7289
cd44d2eb
PE
7290 * image.c: Make symbols static if they're not exported.
7291 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7292 if USE_GTK.
7293 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7294 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7295
ad9a7a06
PE
7296 * fringe.c (standard_bitmaps): Now static.
7297 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7298
81626931
PE
7299 * frame.c: Make symbols static if they're not exported.
7300 (x_report_frame_params, make_terminal_frame): Now static.
7301 (get_frame_param): Now static, unless HAVE_NS.
7302 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7303 (x_get_resource_string): Remove; not used.
7304 * frame.h (make_terminal_frame, x_report_frame_params):
7305 (x_get_resource_string); Remove decls.
7306 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7307 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7308
239f9db9
PE
7309 * font.c, fontset.c: Make symbols static if they're not exported.
7310 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7311 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7312 * font.c (font_close_object): Now static.
7313 * font.h (font_close_object): Remove.
7314 * fontset.c (FONTSET_OBJLIST): Remove.
7315 (free_realized_fontset) #if-0 the body, which does nothing.
7316 (face_suitable_for_char_p): #if-0, as it's never called.
7317 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7318 * xfaces.c (face_at_string_position):
7319 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7320 since 0 is always ASCII.
7321
dfcf3579
PE
7322 * fns.c (weak_hash_tables): Now static.
7323
5045092b
PE
7324 * fileio.c: Make symbols static if they're not exported.
7325 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7326 (Vwrite_region_annotation_buffers): Now static.
7327
57a96f5c
PE
7328 * eval.c: Make symbols static if they're not exported.
7329 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7330 * lisp.h (backtrace_list): Remove decl.
7331
35f08c38
PE
7332 * emacs.c: Make symbols static if they're not exported.
7333 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7334 (fatal_error_code, fatal_error_signal_hook, standard_args):
7335 Now static.
7336 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7337 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7338 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7339 * lisp.h (fatal_error_signal_hook): Remove decl.
7340 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7341
f44bd759
PE
7342 * editfns.c: Move a (normally-unused) function to its only use.
7343 * editfns.c, lisp.h (get_operating_system_release): Remove.
7344 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7345 worth the hassle of breaking this out.
7346
b532497d
PE
7347 * xterm.c: Make symbols static if they're not exported.
7348 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7349 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7350 (x_destroy_window, x_delete_display):
7351 Now static.
7352 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7353 (x_mouse_leave): Remove; unused.
7354 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7355 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7356 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7357 Remove decls.
7358 (x_mouse_leave): Declare only if WINDOWSNT.
7359 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7360 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7361 USE_X_TOOLKIT.
7362
1675728f
PE
7363 * ftxfont.c: Make symbols static if they're not exported.
7364 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7365 HAVE_FREETYPE.
7366 * font.h (ftxfont_driver): Likewise.
7367
e4cebfca
PE
7368 * xfns.c: Make symbols static if they're not exported.
7369 (x_last_font_name, x_display_info_for_name):
7370 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7371 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7372 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7373 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7374 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7375 (last_show_tip_args): Now static.
7376 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7377 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7378 (x_screen_planes): Remove; unused.
7379 * dispextern.h (x_screen_planes): Remove decl.
7380
5bf46f05
PE
7381 * dispnew.c: Make symbols static if they're not exported.
7382 * dispextern.h (redraw_garbaged_frames, scrolling):
7383 (increment_row_positions): Remove.
7384 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7385 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7386 Now static.
7387 (redraw_garbaged_frames): Remove; unused.
7388
435f4c28
PE
7389 * xfaces.c: Make symbols static if they're not exported.
7390 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7391 Remove decls.
7392 * xterm.h (defined_color): Remove decls.
7393 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7394 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7395 (menu_face_changed_default, defined_color, free_realized_face):
7396 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7397 (ascii_face_of_lisp_face): Remove; unused.
7398
8524aef3
PE
7399 * xdisp.c: Make symbols static if they're not exported.
7400 * dispextern.h (scratch_glyph_row, window_box_edges):
7401 (glyph_to_pixel_coords, set_cursor_from_row):
7402 (get_next_display_element, set_iterator_to_next):
7403 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7404 (show_mouse_face): Remove decls
7405 * frame.h (message_buf_print): Likewise.
7406 * lisp.h (pop_message, set_message, check_point_in_composition):
7407 Likewise.
7408 * xterm.h (set_vertical_scroll_bar): Likewise.
7409 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7410 (message_buf_print, scratch_glyph_row, displayed_buffer):
7411 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7412 (get_next_display_element, show_mouse_face, window_box_edges):
7413 (frame_to_window_pixel_xy, check_point_in_composition):
7414 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7415 (glyph_to_pixel_coords): Remove; unused.
7416
16390cd2
PE
7417 * dired.c (file_name_completion): Now static.
7418
7419 * dbusbind.c (xd_in_read_queued_messages): Now static.
7420
a25f4dfa
PE
7421 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7422 * data.c (circular_list_error): Remove.
7423
14a9c8df
PE
7424 * commands.h (last_point_position, last_point_position_buffer):
7425 (last_point_position_window): Remove decls.
7426 * keyboard.c: Make these variables static.
7427
04f2d78b
CB
7428 * coding.h (coding, code_convert_region, encode_coding_gap):
7429 Remove decls.
74ab6df5
PE
7430 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7431 (iso_code_class, detect_coding, code_convert_region): Now static.
7432 (encode_coding_gap): Remove; unused.
7433
38dfbee1
PE
7434 * chartab.c (chartab_chars, chartab_bits): Now static.
7435
a2cb4e63
PE
7436 * charset.h (charset_iso_8859_1): Remove decl.
7437 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7438 Now static.
7439
127198fd
PE
7440 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7441 * ccl.c (Vccl_program_table): Now static.
7442 (check_ccl_update): Remove; unused.
7443
d85b608f
PE
7444 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7445 * category.h: ... from here.
7446 * category.c (check_category_table, set_category_set): Now static.
7447
31cd66f3
PE
7448 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7449 * lisp.h: Remove these decls.
7450
c358e587
PE
7451 * buffer.c (buffer_count): Remove unused var.
7452
e78aecca
PE
7453 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7454 so that it's not optimized away.
7455 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7456 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7457 exported only to the debugger.
7458
e192d7d3 7459 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7460 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7461
92470028
PE
7462 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7463 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7464 was inaccessible from Lisp.
7465 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7466 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7467
244ed907
PE
7468 alloc.c: Import and export fewer symbols, and remove unused items.
7469 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7470 is defined.
7471 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7472 it's not optimized away by whole-program optimization.
7473 (message_enable_multibyte, free_misc): Remove.
7474 (catchlist, handlerlist, mark_backtrace):
7475 Declare only if BYTE_MARK_STACK.
7476 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7477 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7478 (message_enable_multibyte): Remove decl.
7479 (free_misc, interval_free_list, float_block, float_block_index):
7480 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7481 (cons_free_list, last_marked_index):
7482 Now static.
7483 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7484 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7485 (mark_backtrace): Define only if BYTE_MARK_STACK.
7486 * xdisp.c (message_enable_multibyte): Now static.
7487
61c2b50e 7488 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7489 This makes it easier for human readers (and static analyzers)
7490 to see whether these variables are used from other modules.
7491 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7492 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7493 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7494 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7495 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7496 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7497 * xmenu.c, xselect.c:
7498 Declare Q* vars static if they are not used in other modules.
7499 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7500 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7501 Remove decls of unexported vars.
7502 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7503
95c82688
PE
7504 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7505
16a97296
PE
7506 Make Emacs functions such as Fatom 'static' by default.
7507 This makes it easier for human readers (and static analyzers)
7508 to see whether these functions can be called from other modules.
7509 DEFUN now defines a static function. To make the function external
7510 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7511 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7512 (Finit_image_library):
16a97296
PE
7513 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7514 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7515 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7516 Remove decls, since these functions are now static.
7517 (Funintern, Fget_internal_run_time): New decls, since these functions
7518 were already external.
95c82688 7519
16a97296
PE
7520 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7521 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7522 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7523 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7524 * keyboard.c, keymap.c, lread.c:
7525 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7526 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7527 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7528 Mark functions with DEFUE instead of DEFUN,
7529 if they are used in other modules.
7530 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7531 decls for now-static functions.
7532 * buffer.h (Fdelete_overlay): Remove decl.
7533 * callproc.c (Fgetenv_internal): Mark as internal.
7534 * composite.c (Fremove_list_of_text_properties): Remove decl.
7535 (Fcomposition_get_gstring): New forward static decl.
7536 * composite.h (Fcomposite_get_gstring): Remove decl.
7537 * dired.c (Ffile_attributes): New forward static decl.
7538 * doc.c (Fdocumntation_property): New forward static decl.
7539 * eval.c (Ffetch_bytecode): New forward static decl.
7540 (Funintern): Remove extern decl; now in .h file where it belongs.
7541 * fileio.c (Fmake_symbolic_link): New forward static decl.
7542 * image.c (Finit_image_library): New forward static decl.
7543 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7544 * intervals.h (Fprevious_property_change):
7545 (Fremove_list_of_text_properties): Remove decls.
7546 * keyboard.c (Fthis_command_keys): Remove decl.
7547 (Fcommand_execute): New forward static decl.
7548 * keymap.c (Flookup_key): New forward static decl.
7549 (Fcopy_keymap): Now static.
7550 * keymap.h (Flookup_key): Remove decl.
7551 * process.c (Fget_process): New forward static decl.
7552 (Fprocess_datagram_address): Mark as internal.
7553 * syntax.c (Fsyntax_table_p): New forward static decl.
7554 (skip_chars): Remove duplicate decl.
7555 * textprop.c (Fprevious_property_change): New forward static decl.
7556 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7557 Now internal.
7558 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7559 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7560
785bbd42
PE
7561 * editfns.c (Fformat): Remove unreachable code.
7562
8b913b57
AS
75632011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7564
7565 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7566 change. (Bug#8496)
7567
a6744a35
EZ
75682011-04-13 Eli Zaretskii <eliz@gnu.org>
7569
7570 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7571 when at ZV. (Bug#8487)
7572
e7974947
AS
75732011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7574
baad03f0
AS
7575 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7576 (Bug#8437)
7577 * keyboard.c (parse_tool_bar_item): Likewise.
7578 * sound.c (sound_cleanup, alsa_close): Likewise.
7579 * termcap.c (tgetent): Likewise.
7580 * xfns.c (x_default_font_parameter): Likewise.
7581 * xsettings.c (read_and_apply_settings): Likewise.
7582
e7974947
AS
7583 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7584 (overrun_check_free): Protoize.
7585
28272684
PE
75862011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7587
7588 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7589 since callers should never pass a negative size.
7590 Change the signature to match that of plain 'read' and 'write'; see
7591 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7592 * lisp.h: Update prototypes of emacs_write and emacs_read.
7593
11997c76
EZ
75942011-04-11 Eli Zaretskii <eliz@gnu.org>
7595
7596 * xdisp.c (redisplay_window): Don't try to determine the character
7597 position of the scroll margin if the window start point w->startp
e896f03c 7598 is outside the buffer's accessible region. (Bug#8468)
11997c76 7599
8a2cbd72
EZ
76002011-04-10 Eli Zaretskii <eliz@gnu.org>
7601
7602 Fix write-region and its subroutines for buffers > 2GB.
7603 * fileio.c (a_write, e_write): Modify declaration of arguments and
7604 local variables to support buffers larger than 2GB.
7605 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7606
7607 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7608 argument, local variables, and return value.
7609
7610 * lisp.h: Update prototypes of emacs_write and emacs_read.
7611
7612 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7613
4073e537 76142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7615
1ebfdcb6
PE
7616 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7617
b2ded58d
PE
7618 Fix more problems found by GCC 4.6.0's static checks.
7619
7d66342c
PE
7620 * xdisp.c (vmessage): Use a better test for character truncation.
7621
bbf47d44
PE
7622 * charset.c (load_charset_map): <, not <=, for optimization,
7623 and to avoid potential problems with integer overflow.
9248994d 7624 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7625 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7626 * editfns.c (Fformat): Likewise.
1e69125e 7627 * syntax.c (skip_chars): Likewise.
3befa583 7628
e3019616
PE
7629 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7630 This also lets GCC 4.6.0 generate slightly better loop code.
7631
becfa255
PE
7632 * callint.c (Fcall_interactively): <, not <=, for optimization.
7633 (Fcall_interactively): Count the number of arguments produced,
7634 not the number of arguments given. This is simpler and lets GCC
7635 4.6.0 generate slightly better code.
7636
dae0cd48
PE
7637 * ftfont.c: Distingish more carefully between FcChar8 and char.
7638 The previous code passed unsigned char * to a functions like
7639 strlen and xstrcasecmp that expect char *, which does not
7640 conform to the C standard.
7641 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7642 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7643 char * when the C standard requires it.
7644
76032d70
PE
7645 * keyboard.c (read_char): Remove unused var.
7646
eb3f1cc8
PE
7647 * eval.c: Port to Windows vsnprintf (Bug#8435).
7648 Include <limits.h>.
7649 (SIZE_MAX): Define if the headers do not.
7650 (verror): Do not give up if vsnprintf returns a negative count.
7651 Instead, grow the buffer. This ports to Windows vsnprintf, which
7652 does not conform to C99. Problem reported by Eli Zaretskii.
7653 Also, simplify the allocation scheme, by avoiding the need for
7654 calling realloc, and removing the ALLOCATED variable.
7655
70476b54
PE
7656 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7657
12020a9e
PE
7658 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7659 But keep the doprint source code for now, as we might revamp it
7660 and use it again (Bug#8435).
ea6c7ae6
PE
7661 * lisp.h (doprnt): Remove.
7662 * Makefile.in (base_obj): Remove doprnt.o.
7663 * deps.mk (doprnt.o): Remove.
7664
5fdb398c
PE
7665 error: Print 32- and 64-bit integers portably (Bug#8435).
7666 Without this change, on typical 64-bit hosts error ("...%d...", N)
7667 was used to print both 32- and 64-bit integers N, which relied on
7668 undefined behavior.
7669 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7670 New macro.
7671 * lisp.h (error, verror): Mark as printf-like functions.
7672 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7673 Report overflow in size calculations when allocating printf buffer.
7674 Do not truncate output string at its first null byte.
7675 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7676 Truncate the output at a character boundary, since vsnprintf does not
7677 do that.
7678 * charset.c (check_iso_charset_parameter): Convert internal
7679 character to string before calling 'error', since %c now has the
7680 printf meaning.
7681 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7682 overflow when computing char to be passed to 'error'. Do not
7683 pass Lisp_Object to 'error'; pass the integer instead.
7684 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7685 formatted with plain %d.
7686
b189fa66
PE
7687 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7688
bff87ef0
PE
7689 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7690
7e2cac20
PE
7691 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7692
ce4d90b5
PE
7693 * xterm.c (x_catch_errors): Remove duplicate declaration.
7694
266c9547
PE
7695 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7696
79c49ad2
PE
7697 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7698
368f4090
JM
76992011-04-10 Jim Meyering <meyering@redhat.com>
7700
7701 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7702 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7703 return ssize_t not "int", and use size_t as the buffer length.
7704 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7705 * gnutls.h: Update declarations.
7706 * process.c (read_process_output): Use ssize_t, to match.
7707 (send_process): Likewise.
7708
a32d4040
CY
77092011-04-09 Chong Yidong <cyd@stupidchicken.com>
7710
7711 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7712
8546720e 77132011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7714
04f2d78b
CB
7715 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7716 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7717
8546720e
GM
7718 * xterm.c (handle_one_xevent):
7719 * xmenu.c (create_and_show_popup_menu):
7720 * xselect.c (x_decline_selection_request)
7721 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7722
0a2f5c1a 77232011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7724
7725 Fix some uses of `int' instead of EMACS_INT.
7726 * search.c (string_match_1, fast_string_match)
7727 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7728 (scan_buffer, find_next_newline_no_quit)
7729 (find_before_next_newline, search_command, Freplace_match)
7730 (Fmatch_data): Make some `int' variables be EMACS_INT.
7731
7732 * xdisp.c (display_count_lines): 3rd argument and return value now
7733 EMACS_INT. All callers changed.
7734 (pint2hrstr): Last argument is now EMACS_INT.
7735
7736 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7737 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7738 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7739 (decode_coding_utf_16, decode_coding_emacs_mule)
7740 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7741 (decode_coding_ccl, decode_coding_charset)
7742 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7743 (decode_coding_iso_2022, decode_coding_emacs_mule)
7744 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7745 <char_offset, last_offset>: Declare EMACS_INT.
7746 (encode_coding_utf_8, encode_coding_utf_16)
7747 (encode_coding_emacs_mule, encode_invocation_designation)
7748 (encode_designation_at_bol, encode_coding_iso_2022)
7749 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7750 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7751 Declare EMACS_INT.
7752 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7753 (encode_invocation_designation): Last argument P_NCHARS is now
7754 EMACS_INT.
7755 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7756 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7757
7758 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7759 All users changed.
7760
7761 * ccl.c (Fccl_execute_on_string): Declare some variables
7762 EMACS_INT.
7763
8546720e 77642011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7765
7766 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7767
4e19a977
CS
77682011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7769
7770 * process.c (Fformat_network_address): Doc fix.
7771
87302331
R
77722011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7773
ee7683eb 7774 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7775
cbb59342
CY
77762011-04-08 Chong Yidong <cyd@stupidchicken.com>
7777
7778 * keyboard.c (read_char): Call Lisp function help-form-show,
7779 instead of using internal_with_output_to_temp_buffer.
7780 (Qhelp_form_show): New var.
e0d38eeb 7781 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7782
7783 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7784
7785 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7786
e67a13ab
CY
77872011-04-06 Chong Yidong <cyd@stupidchicken.com>
7788
04f2d78b
CB
7789 * process.c (Flist_processes): Remove to Lisp.
7790 (list_processes_1): Delete.
e67a13ab 7791
973f782d
EZ
77922011-04-06 Eli Zaretskii <eliz@gnu.org>
7793
7c106b1e
EZ
7794 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7795
973f782d
EZ
7796 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7797
41cf7d1a 77982011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7799
ca23cc88
PE
7800 Fix more problems found by GCC 4.6.0's static checks.
7801
f390e2d5
PE
7802 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7803
42eea0d0
PE
7804 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7805
b69769da 7806 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7807
f9541e84
PE
7808 * xdisp.c (vmessage): Mark as a printf-like function.
7809
13841b55
PE
7810 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7811
c136c10f
PE
7812 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7813
5e2d4a30
PE
7814 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7815 printf-like functions.
7816 (tiff_load): Add casts to remove these marks before passing them
7817 to system-supplied API.
7818
583f48b9
PE
7819 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7820
b25d760e
PE
7821 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7822 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7823 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7824 directly, rather than having caller test rule sign. This avoids
7825 some unnecessary tests.
7826 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7827 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7828 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7829
bc7b6697 7830 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7831 (xfont_open): Avoid unnecessary tests.
bc7b6697 7832
27ccc379
PE
7833 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7834
dcd5c89a
PE
7835 * composite.h, composite.c (composition_gstring_put_cache):
7836 Use EMACS_INT, not int, for length.
7837
b13a45c6
PE
7838 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7839 breaking out part of COMPOSITION_DECODE_RULE.
7840 (COMPOSITION_DECODE_RULE): Use it.
7841 * composite.c (get_composition_id): Remove unused local vars,
7842 by using the new macro.
7843
1e792e4d
PE
7844 * textprop.c (set_text_properties_1): Change while to do-while,
7845 since the condition is always true at first.
7846
dc6c6455 7847 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7848 (interval_deletion_adjustment): Return unsigned value.
7849 All uses changed.
dc6c6455 7850
aba7731a
PE
7851 * process.c (list_processes_1, create_pty, read_process_output):
7852 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7853 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7854 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7855 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7856 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7857
fdfc4bf3
PE
7858 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7859
fca8fe46 7860 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7861 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7862
06a0259a 7863 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7864 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7865 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7866
e7b9e80f
PE
7867 * print.c (print_error_message): Avoid int overflow.
7868
56201685
PE
7869 * font.c (font_list_entities): Redo for clarity,
7870 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7871
78834453 7872 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7873 (font_score): Avoid potential overflow in diff calculation.
78834453 7874
0bc0b309 7875 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7876 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7877
e610eaca
PE
7878 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7879
b895abce
PE
7880 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7881 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7882 can always succeed if overflow has undefined behavior.
7883
1f1d9321 7884 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7885 (wordify): Omit three unnecessary tests.
1f1d9321 7886
c59478bc
PE
7887 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7888 All callers changed. This avoids the need for an unused var.
7889
79b73827
PE
7890 * casefiddle.c (casify_region): Remove var that is set but not used.
7891
a4db5dfe
PE
7892 * dired.c (file_name_completion): Remove var that is set but not used.
7893
43aae36e
PE
7894 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7895
2a47c44d 7896 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7897 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7898
a37c69bf
PE
7899 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7900 Check for integer overflow on size calculations.
7901
328ab8e7
PE
7902 * buffer.c (Fprevious_overlay_change): Remove var that is set
7903 but not used.
7904
e5a2a5cb
PE
7905 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7906 Remove vars that are set but not used.
8d84a6eb 7907 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7908 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7909
a60e5f68
PE
7910 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7911
f661cb61 7912 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7913 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7914
f0397f5a
PE
7915 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7916 that are set but not used.
7917
8664db06 7918 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7919 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7920
6abdaa4a
PE
7921 * xselect.c (x_get_local_selection, x_handle_property_notify):
7922 Remove vars that are set but not used.
7923
0ce7538d 7924 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7925 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7926
9ae848fc
PE
7927 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7928 Remove var that is set but not used.
0b918413
PE
7929 (scroll_bar_windows_size): Now size_t, not int.
7930 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7931 Check for overflow.
9ae848fc 7932
a5a62657
PE
7933 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7934 (map_tty_color) [!defined MSDOS]: Likewise.
7935
5c5cdd39
PE
7936 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7937
66ebf983
PE
7938 * coding.c: Remove vars that are set but not used.
7939 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7940 All callers changed.
7941 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7942 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7943 (decode_coding_charset): Remove vars that are set but not used.
7944
1be4d761
PE
7945 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7946 that is set but not used.
7947
47553fa8
PE
7948 * print.c (print_object): Remove var that is set but not used.
7949
1f7196bf 7950 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7951 The gnulib version avoids calling malloc in the usual case,
7952 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7953 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7954 * filelock.c (current_lock_owner): Likewise.
7955 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7956 * sysdep.c: Include allocator.h, careadlinkat.h.
7957 (emacs_no_realloc_allocator): New static constant.
7958 (emacs_readlink): New function.
fdb61804
PE
7959 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7960 ../lib/careadlinkat.h.
d1fdcab7 7961
f84c17c7
SM
79622011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7963
7964 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7965 first non-nil return value).
7966
ef3862ad
JD
79672011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7968
7969 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7970 if not defined (Bug#8403).
7971
376a7006
JB
79722011-04-02 Juanma Barranquero <lekktu@gmail.com>
7973
7974 * xdisp.c (display_count_lines): Remove parameter `start',
7975 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7976 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7977 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7978 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7979 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7980 and thereabouts. All callers changed.
7981 (get_per_char_metric): Remove parameter `f', unused since
7982 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7983
6ca3801d
JM
79842011-04-02 Jim Meyering <meyering@redhat.com>
7985
7986 do not dereference NULL upon failed strdup
7987 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7988 (ns_get_family): Likewise.
7989
d8e2b5ba
JB
79902011-04-02 Juanma Barranquero <lekktu@gmail.com>
7991
7992 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7993
8c74fcbd
JD
79942011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7995
7996 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7997 later (Bug#8403).
7998
7200d79c
SM
79992011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8000
03408648 8001 Add lexical binding.
7200d79c 8002
03408648
SM
8003 * window.c (Ftemp_output_buffer_show): New fun.
8004 (Fsave_window_excursion):
8005 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8006
8007 * lread.c (lisp_file_lexically_bound_p): New function.
8008 (Fload): Bind Qlexical_binding.
8009 (readevalloop): Remove `evalfun' arg.
8010 Bind Qinternal_interpreter_environment.
8011 (Feval_buffer): Bind Qlexical_binding.
8012 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8013 Mark as dynamic.
8014 (syms_of_lread): Declare `lexical-binding'.
8015
8016 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8017
8018 * keyboard.c (eval_dyn): New fun.
8019 (menu_item_eval_property): Use it.
ca105506
SM
8020
8021 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8022
03408648
SM
8023 * fns.c (concat, mapcar1): Accept byte-code-functions.
8024
8025 * eval.c (Fsetq): Handle lexical vars.
8026 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8027 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8028 (FletX, Flet): Obey lexical binding.
8029 (Fcommandp): Handle closures.
8030 (Feval): New `lexical' arg.
8031 (eval_sub): New function extracted from Feval. Use it almost
8032 everywhere where Feval was used. Look up vars in lexical env.
8033 Handle closures.
8034 (Ffunctionp): Move from subr.el.
8035 (Ffuncall): Handle closures.
8036 (apply_lambda): Remove `eval_flags'.
8037 (funcall_lambda): Handle closures and new byte-code-functions.
8038 (Fspecial_variable_p): New function.
8039 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8040 but without exporting it to Lisp.
23aba0ea 8041
23aba0ea 8042 * doc.c (Fdocumentation, store_function_docstring):
03408648 8043 * data.c (Finteractive_form): Handle closures.
23aba0ea 8044
03408648
SM
8045 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8046 interactive spec.
ba83908c 8047
04f2d78b
CB
8048 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8049 New byte-codes.
03408648
SM
8050 (exec_byte_code): New function extracted from Fbyte_code to handle new
8051 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8052
03408648 8053 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8054
03408648 8055 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8056
e2abce01
JB
80572011-03-31 Juanma Barranquero <lekktu@gmail.com>
8058
8059 * xdisp.c (redisplay_internal): Fix prototype.
8060
63696a73 80612011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8062
63696a73 8063 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8064 (try_scrolling): Use it when setting scroll_limit.
8065 Limit scrolling to 100 screen lines.
63696a73
EZ
8066 (redisplay_window): Even when falling back on "recentering",
8067 position point in the window according to scroll-conservatively,
8068 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8069
8070 (try_scrolling): When point is above the window, allow searching
8071 as far as scroll_max, or one screenful, to compute vertical
8072 distance from PT to the scroll margin position. This prevents
8073 try_scrolling from unnecessarily failing when
8074 scroll-conservatively is set to a value slightly larger than the
8075 window height. Clean up the case of PT below the margin at bottom
8076 of window: scroll_max can no longer be INT_MAX. When aggressive
8077 scrolling is in use, don't let point enter the opposite scroll
8078 margin as result of the scroll.
8079 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8080 threshold of 100 lines for never-recentering scrolling.
8081
e4cc2dfc
JB
80822011-03-31 Juanma Barranquero <lekktu@gmail.com>
8083
8084 * dispextern.h (move_it_by_lines):
8085 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8086 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8087 (message_log_check_duplicate): Remove parameters `prev_bol' and
8088 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8089 (redisplay_internal): Remove parameter `preserve_echo_area',
8090 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8091
8092 * indent.c (Fvertical_motion):
8093 * window.c (window_scroll_pixel_based, Frecenter):
8094 Don't pass `need_y_p' to `move_it_by_lines'.
8095
1c470562
SM
80962011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8097
44f230aa
SM
8098 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8099 steal a few bits to be more compact.
8100 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8101 Remove unneeded casts.
8102
1c470562
SM
8103 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8104
888adce9
ZK
81052011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8106
8107 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8108 binding" message (bug#7967).
8109
f838ed7b
PE
81102011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8111
77861b95
PE
8112 Fix more problems found by GCC 4.6.0's static checks.
8113
de6dbc14
PE
8114 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8115 Remove unused local var.
8116
f838ed7b
PE
8117 * editfns.c (Fmessage_box): Remove unused local var.
8118
792c7b2b
PE
8119 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8120 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8121 Omit unused local vars.
c499e557 8122 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8123 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8124 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8125 Omit unused local var.
8126
ba0165e1
PE
8127 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8128 Don't assume string length fits in int.
32ad8845 8129 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8130 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8131
3c59b4c9
PE
8132 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8133 instead of alloca (Bug#8344).
8134
a3eed478 8135 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8136 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8137
eb4d412d
PE
8138 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8139
1658b401
PE
8140 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8141 concerns.
8142
8143 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8144
8145 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8146
9a2c6e05
PE
8147 * keyboard.c (syms_of_keyboard): Use the same style as later
8148 in this function when indexing through an array. This also
8149 works around GCC bug 48267.
8150
03d0a109
PE
8151 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8152
44f730c8
PE
8153 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8154
fe75f926
PE
8155 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8156 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8157
ffa8c828
PE
8158 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8159 This avoids undefined behavior on integer overflow, and is a bit
8160 more convenient anyway since it is compared to a size_t variable.
8161
c5101a77
PE
8162 Variadic C functions now count arguments with size_t, not int.
8163 This avoids an unnecessary limitation on 64-bit machines, which
8164 caused (substring ...) to crash on large vectors (Bug#8344).
8165 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8166 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8167 All variadic functions and their callers changed accordingly.
c5101a77
PE
8168 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8169 * data.c (arith_driver, float_arith_driver): Likewise.
8170 * editfns.c (general_insert_function): Likewise.
8171 * eval.c (struct backtrace.nargs, interactive_p)
8172 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8173 (funcall_lambda, mark_backtrace): Likewise.
8174 * fns.c (concat): Likewise.
8175 * frame.c (x_set_frame_parameters): Likewise.
8176 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8177 0 if not found, not -1. All callers changed.
8178
dd3f25f7
PE
8179 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8180 (stack_copy_size): Now size_t, not int.
8181 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8182
461c2ab9
JB
81832011-03-28 Juanma Barranquero <lekktu@gmail.com>
8184
8185 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8186 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8187 All callers changed.
8188
8189 * lisp.h (multibyte_char_to_unibyte):
8190 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8191 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8192 * character.h (CHAR_TO_BYTE8):
8193 * cmds.c (internal_self_insert):
8194 * editfns.c (general_insert_function):
8195 * keymap.c (push_key_description):
8196 * search.c (Freplace_match):
8197 * xdisp.c (message_dolog, set_message_1): All callers changed.
8198
f6d62986
SM
81992011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8200
8201 * keyboard.c (safe_run_hook_funcall): New function.
8202 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8203 don't set the hook to nil, but remove the offending function instead.
8204 (Qcommand_hook_internal): Remove, unused.
8205 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8206 Vcommand_hook_internal.
8207
8208 * eval.c (enum run_hooks_condition): Remove.
8209 (funcall_nil, funcall_not): New functions.
8210 (run_hook_with_args): Call each function through a `funcall' argument.
8211 Remove `cond' argument, now redundant.
8212 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8213 (Frun_hook_with_args_until_failure): Adjust accordingly.
8214 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8215
1db5b1ad
JB
82162011-03-28 Juanma Barranquero <lekktu@gmail.com>
8217
8218 * dispextern.h (string_buffer_position): Remove declaration.
8219
8220 * print.c (strout): Remove parameter `multibyte', unused since
8221 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8222
8223 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8224 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8225 All callers changed.
8226
8227 * w32.c (_wsa_errlist): Use braces for struct initializers.
8228
8229 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8230 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8231 All callers changed.
8232 (string_buffer_position): Likewise. Also, make static (it's never
8233 used outside xdisp.c).
8234 (cursor_row_p): Remove parameter `w', unused since
8235 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8236 (decode_mode_spec): Remove parameter `precision', introduced during
8237 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8238 All callers changed.
8239
5ffb62aa
JD
82402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8241
8242 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8243
461c2ab9 82442011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8245
8246 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8247 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8248 (ns_update_auto_hide_menu_bar): New functions.
8249 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8250 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8251 ns_constrain_all_frames.
8252 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8253 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8254
5c380ffb
JD
82552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8256
8257 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8258
9af30bdf
GM
82592011-03-27 Glenn Morris <rgm@gnu.org>
8260
8261 * syssignal.h: Replace RETSIGTYPE with void.
8262 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8263 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8264 Replace SIGTYPE with void everywhere.
8265 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8266 * s/template.h (SIGTYPE): Remove commented out definition.
8267
e2abce01
JB
82682011-03-26 Eli Zaretskii <eliz@gnu.org>
8269
8270 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8271 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8272
f868cd8a
JB
82732011-03-26 Juanma Barranquero <lekktu@gmail.com>
8274
59eb0929
JB
8275 * w32.c (read_unc_volume): Use parameter `henum', instead of
8276 global variable `wget_enum_handle'.
8277
8278 * keymap.c (describe_vector): Remove parameters `indices' and
8279 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8280 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8281
f868cd8a
JB
8282 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8283
8284 * keyboard.c (timer_check): Remove parameter `do_it_now',
8285 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8286 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8287 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8288
8289 * keyboard.c (read_char):
8290 * w32menu.c (w32_menu_display_help):
8291 * xmenu.c (show_help_event, menu_help_callback):
8292 Adjust calls to `show_help_echo'.
8293
8294 * gtkutil.c (xg_maybe_add_timer):
8295 * keyboard.c (readable_events):
8296 * process.c (wait_reading_process_output):
8297 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8298
8299 * insdel.c (adjust_markers_gap_motion):
8300 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8301 (gap_left, gap_right): Don't call it.
8302
2ecf6fdb
CY
83032011-03-25 Chong Yidong <cyd@stupidchicken.com>
8304
8305 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8306 incurred during fontification.
8307
6b1f9ba4
JB
83082011-03-25 Juanma Barranquero <lekktu@gmail.com>
8309
8310 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8311 (DEFVAR_PER_BUFFER): Don't pass it.
8312
8313 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8314 (scrolling_window): Don't pass it.
8315
0f4a96b5
JB
83162011-03-25 Juanma Barranquero <lekktu@gmail.com>
8317
8318 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8319
8320 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8321 and `suffix'.
8322 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8323 of variables specific to SELinux and computation of `encoded_absname'.
8324
8325 * image.c (XPutPixel): Remove unused variable `height'.
8326
8327 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8328
8329 * unexw32.c (get_section_info): Remove unused variable `section'.
8330
8331 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8332 (system_process_attributes): Remove unused variable `sess'.
8333 (sys_read): Remove unused variable `err'.
8334
8335 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8336 (w32_wnd_proc): Remove unused variable `isdead'.
8337 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8338 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8339 (x_create_tip_frame): Remove unused variable `tem'.
8340
8341 * w32inevt.c (w32_console_read_socket):
8342 Remove unused variable `no_events'.
8343
8344 * w32term.c (x_draw_composite_glyph_string_foreground):
8345 Remove unused variable `width'.
8346
1149507c
JB
83472011-03-24 Juanma Barranquero <lekktu@gmail.com>
8348
8349 * w32term.c (x_set_glyph_string_clipping):
8350 Don't pass uninitialized region to CombineRgn.
8351
9c88f339
JB
83522011-03-23 Juanma Barranquero <lekktu@gmail.com>
8353
8354 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8355 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8356 (Fx_close_connection): Remove unused variable `i'.
8357
8358 * w32font.c (w32font_draw): Return number of glyphs.
8359 (w32font_open_internal): Remove unused variable `i'.
8360 (w32font_driver): Add missing initializer.
8361
8362 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8363 (fill_in_menu): Remove unused variable `items_added'.
8364
8365 * w32term.c (last_mouse_press_frame): Remove static global variable.
8366 (w32_clip_to_row): Remove unused variable `f'.
8367 (x_delete_terminal): Remove unused variable `i'.
8368
8369 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8370 (NOTHING): Remove unused static global variable.
8371 (uniscribe_check_otf): Remove unused variable `table'.
8372 (uniscribe_font_driver): Add missing initializers.
8373
dee091a3
JD
83742011-03-23 Julien Danjou <julien@danjou.info>
8375
8376 * term.c (Fsuspend_tty, Fresume_tty):
8377 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8378 * window.c (temp_output_buffer_show):
8379 * insdel.c (signal_before_change):
8380 * frame.c (Fhandle_switch_frame):
8381 * fileio.c (Fdo_auto_save):
8382 * emacs.c (Fkill_emacs):
8383 * editfns.c (save_excursion_restore):
8384 * cmds.c (internal_self_insert):
8385 * callint.c (Fcall_interactively):
8386 * buffer.c (Fkill_all_local_variables):
8387 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8388 Use Frun_hooks.
0f4a96b5 8389 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8390 unconditionally since it does the check itself.
dee091a3 8391
2c520ab5 83922011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8393
c9c49752
PE
8394 Fix more problems found by GCC 4.5.2's static checks.
8395
8abc3f12
PE
8396 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8397 the first time through the loop, since we know p0 < p1 then.
8398 This also avoids a gcc -Wstrict-overflow warning.
8399
a2d26660
PE
8400 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8401 leading to a memory leak, possible in functions like
8402 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8403 of objects (Bug#8318).
a2d26660 8404
916c72e9
PE
8405 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8406 that could (at least in theory) be that large.
8407
19ab8a18
PE
8408 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8409 This is less likely to overflow, and avoids undefined behavior if
8410 overflow does occur. All callers changed. Use strtoul to scan
8411 for the unsigned long integer.
b7cbbd6f
PE
8412 (pint2hrstr): Simplify and tune code slightly.
8413 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8414
f0641eff
PE
8415 * scroll.c (do_scrolling): Work around GCC bug 48228.
8416 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8417
7f650bb9
PE
8418 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8419 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8420 (validate_x_resource_name): Simplify count usage.
8421 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8422
37dd57d1
PE
8423 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8424 fail (Bug#8306).
81e56e61 8425
699979fc 8426 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8427
401bf9b4
PE
8428 * process.c (Fmake_network_process): Use socklen_t, not int,
8429 where POSIX says socklen_t is required in portable programs.
8430 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8431 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8432 (Fmake_network_process, server_accept_connection):
8433 (wait_reading_process_output, read_process_output):
8434 Likewise.
8435
b93aacde
PE
8436 * process.c: Rename or move locals to avoid shadowing.
8437 (list_processes_1, Fmake_network_process):
8438 (read_process_output_error_handler, exec_sentinel_error_handler):
8439 Rename or move locals.
4dc343ee 8440 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8441 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8442 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8443 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8444 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8445
af8a867c 8446 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8447 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8448 Include tparam.h instead, since it declares them.
af8a867c
PE
8449 * cm.h (PC): Remove extern decl; tparam.h now does this.
8450 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8451 * terminfo.c: Include tparam.h, to check interfaces.
8452 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8453 (tparam): Adjust signature to match interface in tparam.h;
8454 this removes some undefined behavior. Check that outstring and len
8455 are zero, which they always are with Emacs.
8456 * tparam.h (PC, BC, UP): New extern decls.
8457
0248044d 8458 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8459 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8460
8ff096c1 8461 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8462 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8463 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8464 (ftfont_list): Remove unused local.
49eaafba
PE
8465 (get_adstyle_property, ftfont_pattern_entity):
8466 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8467 Rename locals to avoid shadowing.
8ff096c1 8468
e2be39f6
PE
8469 * xfont.c (xfont_list_family): Mark var as initialized.
8470
c9735e30
PE
8471 * xml.c (make_dom): Now static.
8472
8f5201ae
PE
8473 * composite.c (composition_compute_stop_pos): Rename local to
8474 avoid shadowing.
b246f932
PE
8475 (composition_reseat_it): Remove unused locals.
8476 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8477 (composition_update_it): Mark var as initialized.
11b61122
PE
8478 (find_automatic_composition): Mark vars as initialized,
8479 with a FIXME (Bug#8290).
8f5201ae 8480
760fbc2c
PE
8481 character.h: Rename locals to avoid shadowing.
8482 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8483 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8484 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8485 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8486 to avoid shadowing.
8487
ff08eb85
PE
8488 * textprop.c (property_change_between_p): Remove; unused.
8489
fc7bf025
PE
8490 * intervals.c (interval_start_pos): Now static.
8491
235d7abc
PE
8492 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8493
44f230aa
SM
8494 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8495 Rename locals to avoid shadowing.
3e7d6594 8496
50060332
PE
8497 * sound.c (wav_play, au_play, Fplay_sound_internal):
8498 Fix pointer signedness.
d01f234b 8499 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8500 (wav_play): Initialize a variable to 0, to prevent undefined
8501 behavior (Bug#8278).
50060332 8502
c4fc4e30
PE
8503 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8504
918436ed
PE
8505 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8506
c939f91b
PE
8507 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8508 clobbering (Bug#8298).
b9c7f648
PE
8509 * sysdep.c (sys_subshell): Likewise.
8510 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8511
6bd8c144
PE
8512 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8513 This should get cleaned up, so that child_setup has the
8514 same signature on all platforms.
8515
7710357c 8516 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8517 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8518
c59da222
CY
85192011-03-22 Chong Yidong <cyd@stupidchicken.com>
8520
8521 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8522 not to be necessary, and produces flickering.
8523
66b87493
GM
85242011-03-20 Glenn Morris <rgm@gnu.org>
8525
8526 * config.in: Remove file.
8527
45b6f6d5
JB
85282011-03-20 Juanma Barranquero <lekktu@gmail.com>
8529
8530 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8531 are now in src/globals.h.
8532 (syms_of_minibuf): Remove spurious & from previous change.
8533
cd394be1 85342011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8535
8536 * minibuf.c (completing-read-function): New variable.
8537 (completing-read-default): Rename from completing-read.
8538 (completing-read): Call completing-read-function.
8539
b14e3e21
CY
85402011-03-19 Juanma Barranquero <lekktu@gmail.com>
8541
8542 * xfaces.c (Fx_load_color_file):
8543 Read color file from absolute filename (bug#8250).
8544
f2b726e6
JB
85452011-03-19 Juanma Barranquero <lekktu@gmail.com>
8546
8547 * makefile.w32-in: Update dependencies.
8548
09f6ff02
EZ
85492011-03-17 Eli Zaretskii <eliz@gnu.org>
8550
8551 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8552
29a6015a
PE
85532011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8554
a3a6c54e
PE
8555 Fix more problems found by GCC 4.5.2's static checks.
8556
b766f867
PE
8557 * process.c (make_serial_process_unwind, send_process_trap):
8558 (sigchld_handler): Now static.
8559
be02381c
PE
8560 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8561 That way, the code declares only the vars that it needs.
8562 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8563 * s/cygwin.h (PTY_ITERATION): Likewise.
8564 * s/darwin.h (PTY_ITERATION): Likewise.
8565 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8566
57048744
PE
8567 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8568 * process.c (allocate_pty): Don't declare stb unless it's needed.
8569
7914961c 8570 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8571 (CONSTANTLIM): Remove; unused.
8572 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8573 Define only if needed.
7914961c 8574
b3967b18
PE
8575 * unexelf.c (unexec): Name an expression,
8576 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8577 Use a different way to cause a compilation error if anyone uses
8578 n rather than nn, a way that does not involve shadowing.
73366a00 8579 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8580
29a6015a
PE
8581 * deps.mk (unexalpha.o): Remove; unused.
8582
43cfc33e 8583 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8584 * unexec.h: New file.
ce701a33
PE
8585 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8586 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8587 Depend on unexec.h.
8588 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8589 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8590 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8591 Change as necessary to match prototype in unexec.h.
ce701a33 8592
01f44d5a
PE
8593 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8594 shadowing.
4f63c6bb 8595 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8596
a6670b0b
PE
8597 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8598 Rename locals to avoid shadowing.
8599
cef2010d 8600 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8601 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8602
d4d7173a
PE
8603 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8604
f08b802a
PE
8605 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8606 warning when compiling print.c.
8607
3ddb0639
PE
8608 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8609 instead of using an uninitialized var.
5ad03b97 8610 (font_sort_entities): Mark var as initialized.
3ddb0639 8611
170a2692
PE
8612 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8613
e663c700
PE
8614 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8615 pointers to constants.
89bc529a 8616 (font_parse_fcname): Remove unused vars.
7b81e2d0 8617 (font_delete_unmatched): Now static.
ea838e10 8618 (font_get_spec): Remove; unused.
13a547c6
PE
8619 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8620 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8621 Rename or move locals to avoid shadowing.
e663c700 8622
2a80c887 8623 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8624 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8625
1384fa33 8626 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8627 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8628
8b2c52e9
PE
8629 * alloc.c (mark_backtrace): Move decl from here ...
8630 * lisp.h: ... to here, so that it can be checked.
8631
475545b5 8632 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8633 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8634 (lisp_indirect_variable): Name an expression,
8635 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8636 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8637
b1349114 8638 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8639 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8640 Use const pointer when appropriate.
b1349114 8641
a2928364
PE
8642 * lisp.h (get_system_name, get_operating_system_release):
8643 Move decls here, to check interfaces.
8644 * process.c (get_operating_system_release): Move decl to lisp.h.
8645 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8646 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8647 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8648 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8649 (Fformat_time_string, Fencode_time, Finsert_char):
8650 (Ftranslate_region_internal, Fformat):
8651 Rename or remove local vars to avoid shadowing.
9710023e 8652 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8653
a415e694
PE
8654 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8655 avoid shadowing.
8656
8ef4622d
PE
8657 * lisp.h (eassert): Check that the argument compiles, even if
8658 ENABLE_CHECKING is not defined.
8659
946f9a5b
PE
8660 * data.c (Findirect_variable): Name an expression, to avoid
8661 gcc -Wbad-function-cast warning.
112396d6 8662 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8663 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8664 (Fmake_variable_buffer_local, Fmake_local_variable):
8665 Mark variables as initialized.
52746918 8666 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8667
e5aab7e7 8668 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8669 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8670 Rename locals to avoid shadowing.
dff45157
PE
8671 (mark_stack): Move local variables into the #ifdef region where
8672 they're used.
7bc26fdb
PE
8673 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8674 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8675 needed otherwise.
8676 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8677 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8678 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8679
e5aab7e7
PE
8680 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8681 avoids undefined behavior in theory.
8682
4da60324
PE
8683 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8684
88043301
PE
8685 Use functions, not macros, for up- and down-casing (Bug#8254).
8686 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8687 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8688 to use the following functions instead of these macros.
8689 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8690 EMACS_INT, since callers assume the returned value fits in int.
8691 (upcase1): Likewise, for UPCASE_TABLE.
8692 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8693 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8694 the race-condition problem in the old DOWNCASE.
88043301 8695
19ed5445
PE
8696 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8697 Rename locals to avoid shadowing.
8698 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8699 (regex_compile, re_search_2, re_match_2_internal):
8700 Remove unused local vars.
952db0d7
PE
8701 (FREE_VAR): Rewrite so as not to use empty "else",
8702 which gcc can warn about.
da053e48 8703 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8704 (RETALLOC_IF): Define only if needed.
8705 (WORDCHAR_P): Likewise. This one is never needed, but is used
8706 only in a comment talking about a compiler bug, so put inside
8707 the #if 0 of that comment.
8708 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8709 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8710 Remove; unused.
19ed5445 8711
1f3561e4 8712 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8713 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8714 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8715
ded6f8f7
PE
8716 * search.c (simple_search): Remove unused var.
8717
dbd37a95
PE
8718 * dired.c (compile_pattern): Move decl from here ...
8719 * lisp.h: ... to here, so that it can be checked.
8720 (struct re_registers): New forward decl.
8721
7e47afad
PE
8722 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8723
85f24f61
PE
8724 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8725 All uses changed.
8726 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8727 Rename locals to avoid shadowing.
5671df8f 8728 (Fvertical_motion): Mark locals as initialized.
85f24f61 8729
181aa2be 8730 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8731 (casify_region): Mark local as initialized.
181aa2be 8732
930d429c
PE
8733 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8734
7082eac6
PE
8735 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8736 New macros, so that the caller can use some names other than
8737 gcpro1, gcpro2, etc.
8738 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8739 of the new macros.
8740 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8741 argument, for consistency with GCPRO2_VAR, etc: it is now the
8742 prefix of the variable, not the variable itself. All uses
8743 changed.
38b2c076
PE
8744 * dired.c (directory_files_internal, file_name_completion):
8745 Rename locals to avoid shadowing.
8746
15206ed9
PE
8747 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8748 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8749 dired.c's scmp function, had undefined behavior.
8750 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8751 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8752 * buffer.h: ... to here, because these macros use current_buffer,
8753 and the new implementation with inline functions needs to have
8754 current_buffer in scope now, rather than later when the macros
8755 are used.
8756 (downcase, upcase1): New static inline functions.
8757 (DOWNCASE, UPCASE1): Reimplement using these functions.
8758 This avoids undefined behavior in expressions like
8759 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8760 from race conditions in accessing the global variables
8761 case_temp1 and case_temp2.
8762 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8763 * lisp.h (case_temp1, case_temp2): Remove their decls.
8764 * character.h (ASCII_CHAR_P): Move from here ...
8765 * lisp.h: ... to here, so that the inline functions mentioned
8766 above can use them.
8767
4a6bea26
PE
8768 * dired.c (directory_files_internal_unwind): Now static.
8769
f14b7e14
PE
8770 * fileio.c (file_name_as_directory, directory_file_name):
8771 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8772 Now static.
2893f146
PE
8773 (file_name_as_directory): Use const pointers when appropriate.
8774 (Fexpand_file_name): Likewise. In particular, newdir might
8775 point at constant storage, so make it a const pointer.
fd4ead52 8776 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8777 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8778 signedness issues.
f839df0c
PE
8779 (Fset_file_times, Finsert_file_contents, auto_save_error):
8780 Rename locals to avoid shadowing.
f14b7e14 8781
5716756e 8782 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8783 (Ftry_completion, Fall_completions): Rename or remove locals
8784 to avoid shadowing.
5716756e 8785
b4c3046a
PE
8786 * marker.c (bytepos_to_charpos): Remove; unused.
8787
b45db522
PE
8788 * lisp.h (verify_bytepos, count_markers): New decls,
8789 so that gcc does not warn that these functions aren't declared.
8790
85876d07
PE
8791 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8792 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8793 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8794 (copy_text): Remove unused local var.
85876d07 8795
03d78a21 8796 * filelock.c (within_one_second): Now static.
b3dd38ab 8797 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8798
5df8f01b
PE
8799 * buffer.c (fix_overlays_before): Mark locals as initialized.
8800 (fix_start_end_in_overlays): Likewise. This function should be
8801 simplified by using pointers-to-pointers, but that's a different
8802 matter.
b1d876f1 8803 (switch_to_buffer_1): Now static.
8f54f30a
PE
8804 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8805 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8806
a70072c9 8807 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8808 Fix pointer signedness issue.
edced198
PE
8809 (sys_subshell): Mark local as volatile if checking for lint,
8810 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8811 (MAXPATHLEN): Define only if needed.
a70072c9 8812
a0977c44
PE
8813 * process.c (serial_open, serial_configure): Move decls from here ...
8814 * systty.h: ... to here, so that they can be checked.
8815
a884fdcc
PE
8816 * fns.c (get_random, seed_random): Move extern decls from here ...
8817 * lisp.h: ... to here, so that they can be checked.
8818
604efe86 8819 * sysdep.c (reset_io): Now static.
b8950c94 8820 (wait_for_termination_signal): Remove; unused.
604efe86 8821
38fc62d9
PE
8822 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8823 (copy_keymap_item, append_key, push_text_char_description):
8824 Now static.
1004a21a 8825 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8826 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8827 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8828 (describe_map_tree):
8829 Rename locals to avoid shadowing.
38fc62d9 8830
2f2650da
PE
8831 * keyboard.c: Declare functions static if they are not used elsewhere.
8832 (echo_char, echo_dash, cmd_error, top_level_2):
8833 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8834 (read_char, kbd_buffer_get_event, make_lispy_position):
8835 (make_lispy_event, make_lispy_movement, apply_modifiers):
8836 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8837 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8838 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8839 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8840 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8841
a053e86c 8842 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8843 (mark_kboards): Move decl here ...
8844 * alloc.c (mark_kboards): ... from here.
a053e86c 8845
4752793e
PE
8846 * lisp.h (force_auto_save_soon): New decl.
8847
74f10ca7 8848 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8849 (DEFINE_DUMMY_FUNCTION): New macro.
8850 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8851 Use it.
c03cd23f
PE
8852 (main): Add casts to avoid warnings
8853 if GCC considers string literals to be constants.
74f10ca7 8854
022e70d4
PE
8855 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8856
59d6fe83
PE
8857 * dbusbind.c: Pointer signedness fixes.
8858 (xd_signature, xd_append_arg, xd_initialize):
8859 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8860 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8861 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8862 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8863
78320123
PE
8864 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8865 if GCC considers string literals to be constants.
49cebcca 8866 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8867
35ac2a97
SM
88682011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8869
fb103ca9
SM
8870 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8871 (print_preprocess, print_object): New macro to fix last change.
8872
35ac2a97
SM
8873 * print.c (print_preprocess): Don't forget font objects.
8874
62973b41
JB
88752011-03-16 Juanma Barranquero <lekktu@gmail.com>
8876
8877 * emacs.c (USAGE3): Doc fixes.
8878
0e48bb22
AS
88792011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8880
8881 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8882 structure.
8883
7684e57b
JB
88842011-03-14 Juanma Barranquero <lekktu@gmail.com>
8885
8886 * lisp.h (VWindow_system, Qfile_name_history):
8887 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8888 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8889 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8890
8891 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8892 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8893
8894 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8895 * w32console.c (detect_input_pending, read_input_pending)
8896 (encode_terminal_code):
8897 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8898 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8899 (w32_system_caret_y, Qfile_name_history):
8900 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8901 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8902 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8903 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8904 * w32proc.c (Qlocal, report_file_error):
8905 * w32term.c (Vwindow_system, updating_frame):
8906 * w32uniscribe.c (initialized, uniscribe_font_driver):
8907 Remove unneeded extern declarations.
8908
2aa46d6c
CY
89092011-03-14 Chong Yidong <cyd@stupidchicken.com>
8910
c96bbc66 8911 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8912
cffc6f3b
CY
89132011-03-13 Chong Yidong <cyd@stupidchicken.com>
8914
8915 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8916 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8917 These macros can no longer be used for assignment.
8918
44f230aa
SM
8919 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8920 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8921 (record_buffer_markers, fetch_buffer_markers): New functions for
8922 recording and fetching special buffer markers.
8923 (set_buffer_internal_1, set_buffer_temp): Use them.
8924
8925 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8926
8927 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8928
8929 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8930 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8931
8932 * xdisp.c (hscroll_window_tree):
8933 (reconsider_clip_changes): Use PT instead of BUF_PT.
8934
d251f04b
EZ
89352011-03-13 Eli Zaretskii <eliz@gnu.org>
8936
8937 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8938 $(EMACS_ROOT)/lib/intprops.h.
8939
f0c77cd1
PE
89402011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8941
3eca4629
PE
8942 Fix more problems found by GCC 4.5.2's static checks.
8943
7c86ee98
PE
8944 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8945 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8946 (xg_free_frame_widgets): Make it clear that a local variable is
8947 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8948 (gdk_window_get_screen): Make it clear that this macro is needed
8949 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8950 (int_gtk_range_get_value): New function, which avoids a diagnostic
8951 from gcc -Wbad-function-cast.
8952 (xg_set_toolkit_scroll_bar_thumb): Use it.
8953 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8954 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8955 (get_utf8_string, xg_get_file_with_chooser):
8956 Rename locals to avoid shadowing.
8957 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8958
41729b81
PE
8959 * xgselect.c (xg_select): Remove unused var.
8960
f0c77cd1
PE
8961 * image.c (four_corners_best): Mark locals as initialized.
8962 (gif_load): Initialize transparent_p to zero (Bug#8238).
8963 Mark another local as initialized.
ec6cf4c6 8964 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8965
ce0ad53d 8966 * image.c (clear_image_cache): Now static.
d5d5a617 8967 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8968 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8969 (x_edge_detection): Remove unnecessary cast that
8970 gcc -Wbad-function-cast diagnoses.
2037898d 8971 (gif_load): Fix pointer signedness.
6ae141d6
PE
8972 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8973 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8974
33383987 89752011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8976
d32df629
PE
8977 Improve quality of tests for time stamp overflow.
8978 For example, without this patch (encode-time 0 0 0 1 1
8979 1152921504606846976) returns the obviously-bogus value (-948597
8980 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8981 reports time overflow. See
8982 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8983 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8984 * editfns.c: Include limits.h and intprops.h.
8985 (TIME_T_MIN, TIME_T_MAX): New macros.
8986 (time_overflow): Move earlier, to before first use.
8987 (hi_time, lo_time): New functions, for an accurate test for
8988 out-of-range times.
8989 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8990 (Fget_internal_run_time): Don't assume time_t fits in int.
8991 (make_time): Use list2 instead of Fcons twice.
8992 (Fdecode_time): More accurate test for out-of-range times.
8993 (check_tm_member): New function.
8994 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8995 (lisp_time_argument): Don't rely on undefined left-shift and
8996 right-shift behavior when checking for time stamp overflow.
8be6f318 8997
fe31d94c
PE
8998 * editfns.c (time_overflow): New function, refactoring common code.
8999 (Fformat_time_string, Fdecode_time, Fencode_time):
9000 (Fcurrent_time_string): Use it.
9001
8be6f318
PE
9002 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9003 * dired.c (make_time): Move to ...
9004 * editfns.c (make_time): ... here.
9005 * systime.h: Note the move.
9006
09d9db2c 90072011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9008
126bc0dc
YM
9009 * fringe.c (update_window_fringes): Remove unused variables.
9010
c47cbdfd
YM
9011 * unexmacosx.c (copy_data_segment): Also copy __got section.
9012 (Bug#8223)
9013
7ac80be9
EZ
90142011-03-12 Eli Zaretskii <eliz@gnu.org>
9015
c96bbc66 9016 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9017 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9018 Constify `char *' arguments and their references according to
9019 prototypes in tparam.h.
9020
ecb0f94d 9021 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9022
7ac80be9
EZ
9023 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9024 Adapt all references accordingly.
9025
9026 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9027
ef1fd07e
TT
90282011-03-11 Tom Tromey <tromey@redhat.com>
9029
9030 * buffer.c (syms_of_buffer): Remove obsolete comment.
9031
7ef4b50c
EZ
90322011-03-11 Eli Zaretskii <eliz@gnu.org>
9033
9034 * termhooks.h (encode_terminal_code): Declare prototype.
9035
9036 * msdos.c (encode_terminal_code): Don't declare prototype.
9037
9038 * term.c (encode_terminal_code): Now external again, used by
9039 w32console.c and msdos.c.
9040
44f230aa
SM
9041 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9042 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9043
4b1ec863 90442011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9045
1714f52b 9046 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9047
4b1ec863
PE
9048 * fringe.c (update_window_fringes): Mark locals as initialized
9049 (Bug#8227).
9050 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9051
524c7aa6
PE
9052 * alloc.c (mark_fringe_data): Move decl from here ...
9053 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9054 to check its interface.
9055 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9056
a5c0af81 9057 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9058 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9059 (fontset_font): Mark local as initialized.
a9a06e0b 9060 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9061
b4716021
PE
9062 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9063
811e9bac 9064 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9065 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9066 (x_own_selection, Fx_disown_selection_internal): Rename locals
9067 to avoid shadowing.
9068 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9069
7e3ab302
PE
9070 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9071 so that the caller can use some name other than gcpro1.
9072 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9073 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9074 (Fx_backspace_delete_keys_p):
9075 Use them to avoid shadowing, and rename vars to avoid shadowing.
9076 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9077 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9078 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9079 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9080 Remove unused locals.
7e3ab302
PE
9081 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9082 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9083 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9084 macros.
f78faa98 9085
e2b13473
PE
9086 * xterm.h (x_mouse_leave): New decl.
9087
77f23912
PE
9088 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9089 Remove unused functions.
cdf4ba58
PE
9090 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9091 (x_calc_absolute_position): Now static.
7411c686 9092 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9093 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9094 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9095 unless they are used.
38d0b34a
PE
9096 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9097 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9098 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9099 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9100 (x_error_catcher, x_connection_closed, x_error_handler):
9101 (x_error_quitter, xembed_send_message, x_iconify_frame):
9102 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9103 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9104 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9105
44f230aa
SM
9106 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9107 Rename or move locals to avoid shadowing.
6b463e58 9108 (tty_defined_color, merge_face_heights): Now static.
5967d051 9109 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9110 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9111 does not deduce is never used uninitialized.
73719eba
PE
9112 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9113 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9114
426994c3 9115 * terminal.c (store_terminal_param): Now static.
5489860b 9116
032f1620 9117 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9118 (set_frame_menubar): Remove unused local.
d4323972 9119 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9120 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9121 since they might point to immutable storage.
281585b0
PE
9122 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9123 since it's unused otherwise.
032f1620 9124
367c19e5 9125 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9126 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9127 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9128 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9129 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9130 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9131 does not deduce are never used uninitialized.
70739cbe 9132
07b48fa9
PE
9133 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9134
8868a238 9135 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9136 * window.c (window_loop, size_window):
9137 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9138
7e5cf297 9139 * window.c (display_buffer): Now static.
d6550a9f
PE
9140 (size_window): Mark variables that gcc -Wuninitialized
9141 does not deduce are never used uninitialized.
a586633d
PE
9142 * window.h (check_all_windows): New decl, to forestall
9143 gcc -Wmissing-prototypes diagnostic.
5b555da1 9144 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9145
f6095868
PE
9146 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9147 shadowing.
9148 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9149 Include <limits.h>.
9150 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9151 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9152 (load_charset_map): Mark variables that gcc -Wuninitialized
9153 does not deduce are never used uninitialized.
53df7c11 9154 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9155
f38b440c
PE
9156 * coding.c (coding_set_source, coding_set_destination):
9157 Use "else { /* comment */ }" rather than "else /* comment */;"
9158 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9159 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9160 a block, when the outer 'i' will do.
9161 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9162 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9163 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9164 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9165 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9166 Rename locals to avoid shadowing.
9167 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9168 * coding.c (emacs_mule_char, encode_invocation_designation):
9169 Now static, since they're not used elsewhere.
413bb2db 9170 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9171 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9172 (decode_coding_emacs_mule): Mark variables that gcc
9173 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9174 (detect_coding_iso_2022): Initialize a local variable that might
9175 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9176 this initialization is needed. (Bug#8211)
5f58e762
PE
9177 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9178 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9179 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9180 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9181 Remove unused macros.
f38b440c 9182
232b38b9 9183 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9184 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9185 * character.c (string_count_byte8): Likewise.
232b38b9 9186
fb90da1b
PE
9187 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9188 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9189
fb93dbc2
PE
9190 * chartab.c (copy_sub_char_table): Now static, since it's not used
9191 elsewhere.
5c156ace
PE
9192 (sub_char_table_ref_and_range, char_table_ref_and_range):
9193 Rename locals to avoid shadowing.
bbcd0949 9194 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9195
7d3b3862 9196 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9197 (BIDI_BOB): Remove unused macro.
7d3b3862 9198
6be7d3da
PE
9199 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9200 deduce are never used uninitialized.
c2ed9c8b 9201 * term.c (encode_terminal_code): Likewise.
6be7d3da 9202
75f8807f 9203 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9204
50938595
PE
9205 * tparam.h: New file.
9206 * term.c, tparam.h: Include it.
9207 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9208 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9209 Move these decls to tparam.h, and make them agree with what
9210 is actually in tparam.c. The previous trick of using incompatible
9211 decls in different modules does not conform to the C standard.
9212 All callers of tparam changed to use tparam's actual API.
9213 * tparam.c (tparam1, tparam, tgoto):
9214 Use const pointers where appropriate.
9215
fbceeba2
PE
9216 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9217 * cm.h (struct cm): Likewise.
9218 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9219 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9220 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9221 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9222 (turn_on_face, init_tty): Likewise.
9223 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9224
7f3f1250
PE
9225 * term.c (term_mouse_position): Rename local to avoid shadowing.
9226
e6ca6543
PE
9227 * alloc.c (mark_ttys): Move decl from here ...
9228 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9229
c40f8d15
AS
92302011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9231
9232 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9233
cfe0661d
JB
92342011-03-09 Juanma Barranquero <lekktu@gmail.com>
9235
9236 * search.c (compile_pattern_1): Remove argument regp, unused since
9237 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9238 (compile_pattern): Don't pass it.
9239
0afb4571
J
92402011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9241
9242 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9243 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9244 for ! HAVE_GTK3.
9245 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9246
9247 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9248
9249 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9250 gdk_window_get_screen, gdk_window_get_geometry,
9251 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9252 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9253 (xg_get_pixbuf_from_pixmap): New function.
9254 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9255 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9256 Call xg_get_pixbuf_from_pixmap instead of
9257 gdk_pixbuf_get_from_drawable.
9258 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9259 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9260 (xg_check_special_colors): Use GtkStyleContext and its functions
9261 for HAVE_GTK3.
9262 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9263 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9264 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9265 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9266 Call gtk_widget_get_preferred_size.
0afb4571
J
9267 (xg_frame_resized): gdk_window_get_geometry only takes 5
9268 parameters.
44f230aa
SM
9269 (xg_win_to_widget, xg_event_is_for_menubar):
9270 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9271 (xg_set_widget_bg): New function.
9272 (delete_cb): New function.
895009e1 9273 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9274 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9275 (xg_set_background_color): Call xg_set_widget_bg.
9276 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9277 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9278 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9279 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9280 if ! HAVE_GTK3.
9281 (update_frame_tool_bar): Call gtk_widget_hide.
9282 (xg_initialize): Use GDK_KEY_g.
9283
9284 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9285 if ! HAVE_GTK3
9286 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9287
9288 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9289 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9290 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9291
1c2cc4ef
JB
92922011-03-08 Juanma Barranquero <lekktu@gmail.com>
9293
9294 * w32xfns.c (select_palette): Check success of RealizePalette against
9295 GDI_ERROR, not zero.
9296
33383987 9297See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9298
9299;; Local Variables:
9300;; coding: utf-8
aac0c6e3
MR
9301;; End:
9302
acaf905b 9303 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9304
9305 This file is part of GNU Emacs.
9306
9307 GNU Emacs is free software: you can redistribute it and/or modify
9308 it under the terms of the GNU General Public License as published by
9309 the Free Software Foundation, either version 3 of the License, or
9310 (at your option) any later version.
9311
9312 GNU Emacs is distributed in the hope that it will be useful,
9313 but WITHOUT ANY WARRANTY; without even the implied warranty of
9314 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9315 GNU General Public License for more details.
9316
9317 You should have received a copy of the GNU General Public License
9318 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.