* lisp/url/url-future.el (url-future-test): Fix scope of `saver'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
57f97249
EZ
12011-06-03 Eli Zaretskii <eliz@gnu.org>
2
fec2107c 3 Support bidi reordering of text covered by display properties.
57f97249 4
fec2107c
EZ
5 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7 (bidi_cache_search, bidi_cache_iterator_state)
8 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
10 character positions inside a run of characters covered by a
11 display string.
12 (bidi_paragraph_init, bidi_resolve_explicit_1)
13 (bidi_level_of_next_char): Call bidi_fetch_char and
14 bidi_fetch_char_advance instead of FETCH_CHAR and
15 FETCH_CHAR_ADVANCE.
16 (bidi_init_it): Initialize new members.
17 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
18 definitions.
19 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
20 instead of using explicit *_CHAR codes.
21 (bidi_resolve_explicit, bidi_resolve_weak): Use
22 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
23 bidirectional text is supported only in multibyte buffers.
24 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
25 it to initialize the frame_window_p member of struct bidi_it.
26 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
27 (bidi_resolve_explicit, bidi_resolve_weak)
28 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
29 bidi_it->nchars is non-positive.
30 (bidi_level_of_next_char): Don't try to lookup the cache for the
31 next/previous character if nothing is cached there yet, or if we
32 were just reseat()'ed to a new position.
c40e2fb2 33
0e14fe90
EZ
34 * xdisp.c (set_cursor_from_row): Set start and stop points
35 according to the row's direction when priming the loop that looks
36 for the glyph on which to display cursor.
37 (single_display_spec_intangible_p): Function deleted.
38 (display_prop_intangible_p): Reimplement to call
39 handle_display_spec instead of single_display_spec_intangible_p.
40 Accept 3 additional arguments needed by handle_display_spec. This
41 fixes incorrect cursor motion across display property with complex
42 values: lists, `(when COND...)' forms, etc.
43 (single_display_spec_string_p): Support property values that are
44 lists with the argument STRING its top-level element.
45 (display_prop_string_p): Fix the condition for processing a
46 property that is a list to be consistent with handle_display_spec.
fec2107c 47 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
48 last portion of handle_display_prop.
49 (compute_display_string_pos): Accept additional argument
50 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
51 value of a `display' property is a "replacing spec".
52 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
53 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
54 the display property, but just return a value indicating whether
55 the display property will replace the characters it covers.
56 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
57 frame_window_p members of struct bidi_it.
fec2107c
EZ
58 (compute_display_string_pos, compute_display_string_end): New
59 functions.
60 (push_it): Accept second argument POSITION, where pop_it should
61 jump to continue iteration.
62 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 63
fec2107c
EZ
64 * keyboard.c (adjust_point_for_property): Adjust the call to
65 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
66
67 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
68 (bidi_init_it): Update prototypes.
69 (display_prop_intangible_p): Update prototype.
70 (compute_display_string_pos, compute_display_string_end): Declare
71 prototypes.
72 (struct bidi_it): New members nchars and disp_pos. ch_len is now
73 EMACS_INT.
fc6f18ce 74
40087514 752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 76
57f53182
PE
77 Malloc failure behavior now depends on size of allocation.
78 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
79 * lisp.h: Change signatures accordingly.
80 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
81 All callers changed. (Bug#8762)
82
83 * gnutls.c: Use Emacs's memory allocators.
84 Without this change, the gnutls library would invoke malloc etc.
85 directly, which causes problems on non-SYNC_INPUT hosts, and which
86 runs afoul of improving memory_full behavior. (Bug#8761)
87 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
88 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
89 xfree instead of the default malloc, realloc, free.
90 (Fgnutls_boot): No need to check for memory allocation failure,
91 since xmalloc does that for us.
92
ac32cd99 93 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
94 * category.c (hash_get_category_set):
95 * ccl.c (ccl_driver):
96 * charset.c (Fdefine_charset_internal):
97 * charset.h (struct charset.hash_index):
98 * composite.c (get_composition_id, gstring_lookup_cache)
99 (composition_gstring_put_cache):
100 * composite.h (struct composition.hash_index):
101 * dispextern.h (struct image.hash):
102 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
103 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
104 (hashfn_equal, hashfn_user_defined, make_hash_table)
105 (maybe_resize_hash_table, hash_lookup, hash_put)
106 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
107 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
108 (Fsxhash, Fgethash, Fputhash, Fmaphash):
109 * image.c (make_image, search_image_cache, lookup_image)
110 (xpm_put_color_table_h):
111 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 112 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
113 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
114 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
115 * alloc.c (allocate_vectorlike):
116 Check for overflow in vector size calculations.
117 * ccl.c (ccl_driver):
118 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
119 * fns.c, image.c: Remove unnecessary static decls that would otherwise
120 need to be updated by these changes.
40087514
PE
121 * fns.c (make_hash_table, maybe_resize_hash_table):
122 Check for integer overflow with large hash tables.
0de4bb68
PE
123 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
124 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
125 (SXHASH_REDUCE): New macro.
126 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
127 Use it instead of discarding useful hash info with large hash values.
128 (sxhash_float): New function.
129 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
130 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
131 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
132 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
133 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
134 Adjust signatures to match updated version of code.
135 (consing_since_gc): Now EMACS_INT, since a single hash table can
136 use more than INT_MAX bytes.
137
698d32e2
DN
1382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
139
140 Make it possible to build with GCC-4.6+ -O2 -flto.
141
142 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
143
fd6fa53f
SM
1442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
145
146 * minibuf.c (get_minibuffer, read_minibuf_unwind):
147 Call minibuffer-inactive-mode.
148
864db017
JB
1492011-05-31 Juanma Barranquero <lekktu@gmail.com>
150
151 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
152 Update dependencies.
153
2ad0baf4
DN
1542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
155
156 * data.c (init_data): Remove code for UTS, this system is not
157 supported anymore.
158
4fcc2638
DN
1592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
160
161 Don't force ./temacs to start in terminal mode.
162
163 * frame.c (make_initial_frame): Initialize faces in all cases, not
164 only when CANNOT_DUMP is defined.
165 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
166
c56e0fd5
DN
1672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
168
169 * dispnew.c (add_window_display_history): Use const for the string
170 pointer. Remove declaration, not needed.
171
333d54da 1722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 173
55d4c1b2 174 Use 'inline', not 'INLINE'.
333d54da 175 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
176 * alloc.c, fontset.c (INLINE): Remove.
177 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
178 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
179 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
180 * gmalloc.c (register_heapinfo): Use inline unconditionally.
181 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
182
738db178
DN
1832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
184
185 Make it possible to run ./temacs.
186
187 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
188 syms_of_callproc does the same thing. Remove test for
189 "initialized", do it in the caller.
190 * emacs.c (main): Avoid calling set_initial_environment when dumping.
191
620c53a6
SM
1922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
193
194 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
195 (read_minibuf): Use get_minibuffer.
196 (syms_of_minibuf): Use DEFSYM.
197 (Qmetadata): New var.
198 * data.c (Qbuffer): Don't make it static.
199 (syms_of_data): Use DEFSYM.
200
e003a292
PE
2012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
202
203 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
204 (CCL_CODE_MIN): New macro.
205
ed008a6d
PE
2062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
207
3687c2ef
PE
208 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
209
ed008a6d
PE
210 * eval.c (Qdebug): Now static.
211 * lisp.h (Qdebug): Remove decl. This reverts a part of the
212 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
213 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
214
d66c4c7c
CY
2152011-05-29 Chong Yidong <cyd@stupidchicken.com>
216
217 * image.c: Various fixes to ImageMagick code comments.
218 (Fimagemagick_types): Doc fix.
219
5fbc2025
PE
2202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
221
0196f88a
PE
222 Minor fixes prompted by GCC 4.6.0 warnings.
223
224 * xselect.c (converted_selections, conversion_fail_tag): Now static.
225
5fbc2025
PE
226 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
227 (x_clipboard_manager_save_all): Move extern decl to ...
228 * xterm.h: ... here, so that it can be checked for consistency.
229
1dd3c2d9
CY
2302011-05-29 Chong Yidong <cyd@stupidchicken.com>
231
232 * xselect.c (x_clipboard_manager_save_frame)
233 (x_clipboard_manager_save_all): New functions.
234 (Fx_clipboard_manager_save): Lisp function deleted.
235
236 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
237 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
238
239 * xterm.h: Update prototype.
240
5ba6571d
WX
2412011-05-28 William Xu <william.xwl@gmail.com>
242
243 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
244 exiting (Bug#8239).
245
3eaff834
JM
2462011-05-28 Jim Meyering <meyering@redhat.com>
247
e1900994 248 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
249 * fns.c (to_uchar): Define.
250 (crypto_hash_function): Use it to convert some newly-signed
251 variables to unsigned, to avoid sign-extension bugs. For example,
252 without this change, (md5 "truc") would evaluate to
253 45723a2aff78ff4fff7fff1114760e62 rather than the expected
254 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 255 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 256
0f6990a7
PE
2572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
258
259 Integer overflow fixes.
c8a9ca5a 260
08686060
PE
261 * dbusbind.c: Serial number integer overflow fixes.
262 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
263 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
264 to hold a serial number that is too large for a fixnum.
265 (Fdbus_method_return_internal, Fdbus_method_error_internal):
266 Check for serial numbers out of range. Decode any serial number
59568bf0 267 that was so large that it became a float. (Bug#8722)
08686060 268
2d1fc3c7
PE
269 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
270 (Fdbus_call_method, Fdbus_call_method_asynchronously):
271 Use XFASTINT rather than XUINT when numbers are nonnegative.
272 (xd_append_arg, Fdbus_method_return_internal):
273 (Fdbus_method_error_internal): Likewise. Also, for unsigned
274 arguments, check that Lisp number is nonnegative, rather than
59568bf0 275 silently wrapping negative numbers around. (Bug#8722)
30217ff0 276 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 277 (Bug#8722)
2d1fc3c7 278
c8a9ca5a
PE
279 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
280
519e1d69
PE
281 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
282
30569699
PE
283 ccl: add integer overflow checks
284 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
285 (IN_INT_RANGE): New macros.
286 (ccl_driver): Use them to check for integer overflow when
287 decoding a CCL program. Many of the new checks are whether XINT (x)
288 fits in int; it doesn't always, on 64-bit hosts. The new version
289 doesn't catch all possible integer overflows, but it's an
847044ea 290 improvement. (Bug#8719)
30569699 291
c11285dc
PE
292 * alloc.c (make_event_array): Use XINT, not XUINT.
293 There's no need for unsigned here.
294
fdccd48e
PE
295 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
296 This follows up to the 2011-05-06 change that substituted uintptr_t
297 for EMACS_INT. This case wasn't caught back then.
298
37910ab2
PE
299 Rework Fformat to avoid integer overflow issues.
300 * editfns.c: Include <float.h> unconditionally, as it's everywhere
301 now (part of C89). Include <verify.h>.
302 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
303 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
304 (Fformat): Avoid the prepass trying to compute sizes; it was only
305 approximate and thus did not catch overflow reliably. Instead, walk
306 through the format just once, formatting and computing sizes as we go,
307 checking for integer overflow at every step, and allocating a larger
308 buffer as needed. Keep track separately whether the format is
309 multibyte. Keep only the most-recently calculated precision, rather
310 than them all. Record whether each argument has been converted to
311 string. Use EMACS_INT, not int, for byte and char and arg counts.
312 Support field widths and precisions larger than INT_MAX. Avoid
313 sprintf's undefined behavior with conversion specifications such as %#d
314 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
315 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
316 formatting out-of-range floating point numbers with int
317 formats. (Bug#8668)
318
2e6578fb
PE
319 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
320
0ae6bdee
PE
321 * data.c: Avoid integer truncation in expressions involving floats.
322 * data.c: Include <intprops.h>.
323 (arith_driver): When there's an integer overflow in an expression
324 involving floating point, convert the integers to floating point
325 so that the resulting value does not suffer from catastrophic
326 integer truncation. For example, on a 64-bit host (* 4
327 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
328 Do not rely on undefined behavior after integer overflow.
329
de883a70
PE
330 merge count_size_as_multibyte, parse_str_to_multibyte
331 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 332 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
333 Check for integer overflow.
334 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
335 since it's now a duplicate of the other. This is more of
336 a character than a buffer op, so better that it's in character.c.
337 * fns.c, print.c: Adjust to above changes.
338
2ff916cb
PE
3392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
340
341 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
342
f1b54466
PE
3432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
344
fb1ac845
PE
345 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
346 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
347 (x_clipboard_manager_save): Now static.
348 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
349
f1b54466
PE
350 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
351 (crypto_hash_function): Now static.
352 Fix pointer signedness problems. Avoid unnecessary initializations.
353
a9f737ee
CY
3542011-05-27 Chong Yidong <cyd@stupidchicken.com>
355
356 * termhooks.h (Vselection_alist): Make it terminal-local.
357
358 * terminal.c (create_terminal): Initialize it.
359
360 * xselect.c: Support for clipboard managers.
361 (Vselection_alist): Move to termhooks.h as terminal-local var.
362 (LOCAL_SELECTION): New macro.
363 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
364 (symbol_to_x_atom): Remove gratuitous arg.
365 (x_handle_selection_request, lisp_data_to_selection_data)
366 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
367 (x_own_selection, x_get_local_selection, x_convert_selection):
368 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
369 (some_frame_on_display): Delete unused function.
370 (Fx_own_selection_internal, Fx_get_selection_internal)
371 (Fx_disown_selection_internal, Fx_selection_owner_p)
372 (Fx_selection_exists_p): New optional frame arg.
373 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
374 (x_handle_selection_clear): Don't treat other terminals with the
375 same keyboard specially. Use the terminal-local Vselection_alist.
376 (x_clear_frame_selections): Use Frun_hook_with_args.
377
378 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
379
380 * xterm.h: Add support for those atoms.
381
e067f0c1
CY
3822011-05-26 Chong Yidong <cyd@stupidchicken.com>
383
384 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
385 (converted_selections, conversion_fail_tag): New global variables.
386 (x_selection_request_lisp_error): Free the above.
387 (x_get_local_selection): Remove unnecessary code.
388 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
389 of converted selections stored in converted_selections.
390 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
391 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
392 (x_convert_selection): New function.
393 (x_handle_selection_event): Simplify.
394 (x_get_foreign_selection): Don't ignore incoming requests while
395 waiting for an answer; this will fail when we implement
396 SAVE_TARGETS, and seems unnecessary anyway.
397 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
398 (Vx_sent_selection_functions): Doc fix.
399
0f4aebc0
LL
4002011-05-26 Leo Liu <sdl.web@gmail.com>
401
402 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
403
e61124cd
YM
4042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
405
406 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
407
408 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
409 for fringe update if it has periodic bitmap.
410 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
411 and fringe_bitmap_periodic_p.
412
413 * fringe.c (get_fringe_bitmap_data): New function.
414 (draw_fringe_bitmap_1, update_window_fringes): Use it.
415 (update_window_fringes): Record periodicity of fringe bitmap in glyph
416 row. Mark glyph row for fringe update if periodicity changed.
417
418 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
419 for fringe update unless it has periodic bitmap.
420
f16d9837
KH
4212011-05-25 Kenichi Handa <handa@m17n.org>
422
423 * xdisp.c (get_next_display_element): Set correct it->face_id for
424 a static composition.
425
e1b90ef6
LL
4262011-05-24 Leo Liu <sdl.web@gmail.com>
427
428 * deps.mk (fns.o):
429 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
430
431 * fns.c (crypto_hash_function, Fsha1): New function.
432 (Fmd5): Use crypto_hash_function.
433 (syms_of_fns): Add Ssha1.
434
7400048f
PE
4352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
436
437 * gnutls.c: Remove unused macros.
438 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
439 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
440 Remove macros that are defined and never used.
441 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
442
abb71cf4
CY
4432011-05-22 Chong Yidong <cyd@stupidchicken.com>
444
445 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
446 (Fx_get_selection_internal): Minor cleanup.
447 (Fx_own_selection_internal): Rename arguments for consistency with
448 select.el.
449
6307db39
PE
4502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
451
452 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
453
f3d4e0a4
CY
4542011-05-22 Chong Yidong <cyd@stupidchicken.com>
455
456 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
457
4d8ade89
YM
4582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
459
460 * dispnew.c (scrolling_window): Don't exclude the case that the
461 last enabled row in the desired matrix touches the bottom boundary.
462
32078c8d
GM
4632011-05-21 Glenn Morris <rgm@gnu.org>
464
465 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
466 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
467 and add some more files.
32078c8d 468
7285dc67
EZ
4692011-05-20 Eli Zaretskii <eliz@gnu.org>
470
471 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
472 report_file_error introduced by the change from 2011-05-07.
473
89d1bd22
PE
4742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
475
476 * systime.h (Time): Define only if emacs is defined.
477 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
478 where the include path doesn't have X11/X.h by default. See
479 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
480
e23640bb 4812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
482
483 * composite.c (find_automatic_composition): Fix previous change.
484
b9704ad9
GM
4852011-05-20 Glenn Morris <rgm@gnu.org>
486
487 * lisp.mk: New file, split from Makefile.in.
488 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
489 (shortlisp): Remove.
490 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
491
4a720484
GM
4922011-05-19 Glenn Morris <rgm@gnu.org>
493
494 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
495 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
496 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
497 (lisp): Set the order to that of loadup.el.
498 (shortlisp): Make it a copy of $lisp.
499 (SOME_MACHINE_LISP): Remove.
500 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
501 Use just $shortlisp, not $SOME_MACHINE_LISP too.
502
a28d4396
KH
5032011-05-18 Kenichi Handa <handa@m17n.org>
504
505 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
506 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
507 (find_automatic_composition): Mostly rewrite for efficiency.
508
a2b1fa8e
JB
5092011-05-18 Juanma Barranquero <lekktu@gmail.com>
510
511 * makefile.w32-in: Update dependencies.
512
8e1f5610
CS
5132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
514
515 * menu.c: Include limits.h (fixes the MS-Windows build broken by
516 revision 104625).
517
7025ee00 5182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 519
cdfa6eab
PE
520 Fix some integer overflow issues, such as string length overflow.
521
06d6db33
PE
522 * insdel.c (count_size_as_multibyte): Check for string overflow.
523
2b4560a8
PE
524 * character.c (lisp_string_width): Check for string overflow.
525 Use EMACS_INT, not int, for string indexes and lengths; in
526 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
527 the resulting string length overflows an EMACS_INT; instead,
528 report a string overflow if no precision given. When checking for
529 precision exhaustion, use a check that cannot possibly have
530 integer overflow. (Bug#8675)
531 * character.h (lisp_string_width): Adjust to new signature.
532
cb93f9be
PE
533 * alloc.c (string_overflow): New function.
534 (Fmake_string): Use it. This doesn't change behavior, but saves
535 a few bytes and will simplify future changes.
536 * character.c (string_escape_byte8): Likewise.
537 * lisp.h (string_overflow): New decl.
538
1a1f3366
PE
539 Fixups, following up to the user-interface timestamp change.
540 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
541 for UI timestamps, instead of unsigned long.
9fbd6841
PE
542 * msdos.c (mouse_get_pos): Likewise.
543 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
544 * w32gui.h (Time): Define by including "systime.h" rather than by
545 declaring it ourselves. (Bug#8664)
546
d4e3e4d3
PE
547 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
548 * image.c (clear_image_cache): Likewise.
549
f6a24d19
PE
550 * term.c (term_mouse_position): Don't assume time_t wraparound.
551
08dc5ae6
PE
552 Be more systematic about user-interface timestamps.
553 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
554 and sometimes 'EMACS_UINT', to represent these timestamps.
555 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
556 This makes the code easier to follow, and makes it easier to catch
557 integer overflow bugs such as Bug#8664.
558 * frame.c (Fmouse_position, Fmouse_pixel_position):
559 Use Time, not unsigned long, for user-interface timestamps.
560 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
561 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
562 * keyboard.h (last_event_timestamp): Likewise.
563 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
564 * menu.h (xmenu_show): Likewise.
565 * term.c (term_mouse_position): Likewise.
566 * termhooks.h (struct input_event.timestamp): Likewise.
567 (struct terminal.mouse_position_hook): Likewise.
568 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
569 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
570 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
571 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
572 what it was before.
573 * menu.h, termhooks.h: Include "systime.h", for Time.
574
8e55734a
PE
575 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
576 Don't assume that the difference between two unsigned long values
577 can fit into an integer. At this point, we know button_down_time
578 <= event->timestamp, so the difference must be nonnegative, so
579 there's no need to cast the result if double-click-time is
580 nonnegative, as it should be; check that it's nonnegative, just in
581 case. This bug is triggered when events are more than 2**31 ms
86db42d2 582 apart (about 25 days). (Bug#8664)
8e55734a 583
841f1b75 584 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 585 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 586
3e26f69c
PE
587 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
588 that always fit in int. Use a sentinel instead of a counter, to
589 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
590 * frame.h (struct frame): Use int for menu_bar_items_used
591 instead of EMACS_INT, since it always fits in int.
3e26f69c 592
5cc152c0
PE
593 * menu.c (grow_menu_items): Check for int overflow.
594
d89eb65e
PE
595 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
596
5235bd3e
PE
597 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
598 Before, the code was not consistent. These values cannot exceed
599 2**31 - 1 so there's no need to make them unsigned.
600 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
601 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
602 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
603 as modifiers.
604 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
605
bc827e23
PE
606 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
607 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
608 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
609 presumably because the widths might not match.
610
78eb494e
PE
611 * window.c (size_window): Avoid needless test at loop start.
612
04f2d78b
CB
6132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
614
615 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
616
d2fc7e3d 6172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
618
619 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
620
d2fc7e3d 6212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
622
623 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
624 `width' to `bar_area_x' and `bar_area_width', respectively.
625 (x_scroll_run): Take account of fringe background extension.
626
04f2d78b
CB
627 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
628 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
629 `bar_area_width', respectively.
630 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
631 background extension.
632
79b70037
GM
6332011-05-10 Jim Meyering <meyering@redhat.com>
634
635 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
636
2f142cc5
JB
6372011-05-10 Juanma Barranquero <lekktu@gmail.com>
638
639 * image.c (Finit_image_library): Return t for built-in image types,
640 like pbm and xbm. (Bug#8640)
641
57679c86
AS
6422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
643
644 * w32menu.c (set_frame_menubar): Fix submenu allocation.
645
888c9e86
EZ
6462011-05-07 Eli Zaretskii <eliz@gnu.org>
647
b0512a1d
EZ
648 * w32console.c (Fset_screen_color): Doc fix.
649 (Fget_screen_color): New function.
650 (syms_of_ntterm): Defsubr it.
651
7285dc67
EZ
652 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
653 unlink the temporary file if Fcall_process didn't create it in the
654 first place.
655 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
656 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
657 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
658 cue to call_process_cleanup not to close that handle.
659
4d3fcc8e
BK
6602011-05-07 Ben Key <bkey76@gmail.com>
661
662 * makefile.w32-in: The bootstrap-temacs rule now makes use of
663 one of two shell specific rules, either bootstrap-temacs-CMD or
664 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
665 to the previous implementation of the bootstrap-temacs rule.
666 The bootstrap-temacs-CMD rule is similar to the previous
667 implementation of the bootstrap-temacs rule except that it
668 makes use of the ESC_CFLAGS variable instead of the CFLAGS
669 variable.
670
671 These changes, along with some changes to nt/configure.bat,
672 nt/gmake.defs, and nt/nmake.defs, are required to extend my
673 earlier fix to add support for --cflags and --ldflags options
674 that include quotes so that it works whether make uses cmd or
675 sh as the shell.
676
b4289b64
MA
6772011-05-06 Michael Albinus <michael.albinus@gmx.de>
678
679 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
680 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
681 is a constant.
682 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
683 a string. Handle both cases.
684 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
685 (Fdbus_register_method): Use Qinvalid_function.
686
af4c0e28
JB
6872011-05-06 Juanma Barranquero <lekktu@gmail.com>
688
689 * makefile.w32-in: Update dependencies.
690 (LISP_H): Add inttypes.h and stdin.h.
691 (PROCESS_H): Add unistd.h.
692
c51453d9
EZ
6932011-05-06 Eli Zaretskii <eliz@gnu.org>
694
695 * lread.c: Include limits.h (fixes the MS-Windows build broken by
696 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
697
8ff0ac3c 6982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 699
4c4b566b
PE
700 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
701
aab2b9b5
PE
702 * term.c (vfatal): Remove stray call to va_end.
703 It's not needed and the C Standard doesn't allow it here anyway.
704
c378da0b
PE
705 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
706 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
707
288b08c7
PE
708 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
709 bytes.
710
e3601888
PE
711 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
712
db6c0e74
PE
713 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
714
dd5963ea
PE
715 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
716
88c9450f
PE
717 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
718
2f9442b8
PE
719 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
720
c032b5f8
PE
721 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
722 * charset.c (Fdefine_charset_internal): Don't initialize
723 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 724 32-bit int (Bug#8600).
a108c10b
PE
725
726 * lread.c (read_integer): Be more consistent with string-to-number.
727 Use string_to_number to do the actual conversion; this avoids
728 rounding errors and fixes some other screwups. Without this fix,
729 for example, #x1fffffffffffffff was misread as -2305843009213693952.
730 (digit_to_number): Move earlier, for benefit of read_integer.
731 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 732 not a digit in any supported base. (Bug#8602)
a108c10b 733
ad5f9eea
PE
734 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
735
aec1708a
PE
736 * dispnew.c (scrolling_window): Return 1 if we scrolled,
737 to match comment at start of function. This also removes a
738 GCC warning about overflow in a 32+64-bit port.
739
47be4ab5
PE
740 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
741
371cac43
PE
742 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
743 Reported by Stefan Monnier in
744 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
745 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
746 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 747
d01a7826
PE
748 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
749 (EMACS_UINTPTR): Likewise, with uintptr_t.
750
7fd47d5c
PE
751 * lisp.h: Prefer 64-bit EMACS_INT if available.
752 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
753 on 32-bit hosts that have 64-bit int, so that they can access
754 large files.
122b0c86
PE
755 However, temporarily disable this change unless the temporary
756 symbol WIDE_EMACS_INT is defined.
7fd47d5c 757
8727937b
PE
758 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
759
8ac068ac
PE
760 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
761 This removes an assumption that EMACS_INT and long are the same
762 width as pointers. The assumption is true for Emacs porting targets
763 now, but we want to make other targets possible.
764 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
765 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
766 In the rest of the code, change types of integers that hold casted
767 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
768 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
769 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
770 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
771 No need to cast type when ORing.
772 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
773 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
774 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
775 assume EMACS_INT is the same width as char *.
776 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
777 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
778 Remove no-longer-needed casts.
779 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
780 (xg_tool_bar_help_callback, xg_make_tool_item):
781 Use EMACS_INTPTR to hold an integer
782 that will be cast to void *; this can avoid a GCC warning
783 if EMACS_INT is not the same width as void *.
784 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
785 * xdisp.c (display_echo_area_1, resize_mini_window_1):
786 (current_message_1, set_message_1):
787 Use a local to convert to proper width without a cast.
788 * xmenu.c (dialog_selection_callback): Likewise.
789
ede49d71
PE
790 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
791 Also, don't assume VALBITS / RAND_BITS is less than 5,
792 and don't rely on undefined behavior when shifting a 1 left into
793 the sign bit.
794 * lisp.h (get_random): Change signature to match.
795
2f30ecd0
PE
796 * lread.c (hash_string): Use size_t, not int, for hash computation.
797 Normally we prefer signed values; but hashing is special, because
798 it's better to use unsigned division on hash table sizes so that
799 the remainder is nonnegative. Also, size_t is the natural width
800 for hashing into memory. The previous code used 'int', which doesn't
801 retain enough info to hash well into very large tables.
802 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
803
2a866e7b
PE
804 * dbusbind.c: Don't possibly lose pointer info when converting.
805 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
806 Use XPNTR rather than XHASH, so that the high-order bits of
807 the pointer aren't lost when converting through void *.
808
51639eac
PE
809 * eval.c (Fautoload): Don't double-shift a pointer.
810
92394119
PE
811 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
812
dbdb9a7c
JB
8132011-05-06 Juanma Barranquero <lekktu@gmail.com>
814
815 * gnutls.c (DEF_GNUTLS_FN):
816 * image.c (DEF_IMGLIB_FN): Make function pointers static.
817
db7a0b4f
AS
8182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
819
820 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
821 marker. (Bug#8610)
822
f7ff1b0f 8232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
824
825 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
826 New version that can reserve upto 2GB of heap space.
827
f7ff1b0f 8282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
829
830 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
831
639c109b
TZ
8322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
833
834 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
835 `gnutls_certificate_set_x509_key_file'.
836
d2127135
JB
8372011-05-05 Juanma Barranquero <lekktu@gmail.com>
838
839 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
840 Update dependencies.
841
e968f4f3
JB
8422011-05-04 Juanma Barranquero <lekktu@gmail.com>
843
844 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
845 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
846 Remove unused parameter `fildes'.
847 * process.c (read_process_output, send_process): Don't pass it.
848
84d358f0
JB
8492011-05-04 Juanma Barranquero <lekktu@gmail.com>
850
851 Fix previous change: the library cache is defined in w32.c.
852 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
853 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
854
0898ca10
JB
8552011-05-04 Juanma Barranquero <lekktu@gmail.com>
856
857 Implement dynamic loading of GnuTLS on Windows.
858
859 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
860 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
861 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
862 Declare.
863
864 * gnutls.c (Qgnutls_dll): Define.
865 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
866 (gnutls_*): Declare function pointers.
867 (init_gnutls_functions): New function to initialize function pointers.
868 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
869 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
870 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
871 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
872 (emacs_gnutls_write, emacs_gnutls_read)
873 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
874 (Fgnutls_available_p): New function.
875 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
876 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
877 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
878
879 * image.c: Include w32.h.
880 (Vimage_type_cache): Delete.
881 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
882 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
883 (w32_delayed_load): Move to w32.c.
884
885 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
886
887 * w32.c (QCloaded_from, Vlibrary_cache): Define.
888 (w32_delayed_load): Move from image.c. When loading a library, record
889 its filename in the :loaded-from property of the library id.
890 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
891 Initialize and staticpro them.
892 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
893
894 * process.c: Include lisp.h before w32.h, not after.
895 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
896 instead of gnutls_record_check_pending.
897
898 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
899
ff4de4aa
TZ
9002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
901
902 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
903 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
904 as passed in.
905
abe95abb
JD
9062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
907
908 * xterm.c (x_set_frame_alpha): Do not set property on anything
909 else than FRAME_X_OUTER_WINDOW (Bug#8608).
910
e16e55d4
JB
9112011-05-02 Juanma Barranquero <lekktu@gmail.com>
912
913 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
914
bafcf6a5
JB
9152011-05-02 Juanma Barranquero <lekktu@gmail.com>
916
917 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
918 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
919 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
920 (gnutls_global_initialized, Qgnutls_bootprop_priority)
921 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
922 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
923 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
924 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
925 (Qgnutls_bootprop_callbacks_verify): Make static.
926
e7a6747f
AS
9272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
928
19ed11ba
AS
929 * callproc.c: Indentation fixup.
930
e7a6747f 931 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
932 (wait_for_termination, interruptible_wait_for_termination):
933 Move after wait_for_termination_1.
e7a6747f 934
1ef14cb4
LMI
9352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
936
937 * sysdep.c (interruptible_wait_for_termination): New function
938 which is like wait_for_termination, but allows keyboard
939 interruptions.
940
941 * callproc.c (Fcall_process): Add (:file "file") as an option for
942 the STDOUT buffer.
943 (Fcall_process_region): Ditto.
944
330d880c
EZ
9452011-04-30 Eli Zaretskii <eliz@gnu.org>
946
8db90b73
EZ
947 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
948 rather than `XVECTOR (FOO)->size'.
949
330d880c
EZ
950 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
951 inttypes.h, as a gnulib replacement is used if it not available in
952 system headers.
953
15cbd324
EZ
9542011-04-21 Eli Zaretskii <eliz@gnu.org>
955
956 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
957 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
958 of MOST_POSITIVE_FIXNUM. (Bug#8528)
959
960 * coding.c (coding_alloc_by_realloc): Error out if destination
961 will grow beyond MOST_POSITIVE_FIXNUM.
962 (decode_coding_emacs_mule): Abort if there isn't enough place in
963 charbuf for the composition carryover bytes. Reserve an extra
964 space for up to 2 characters produced in a loop.
965 (decode_coding_iso_2022): Abort if there isn't enough place in
966 charbuf for the composition carryover bytes.
967
9682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 969
ae940cca
EZ
970 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
971 aborting when %lld or %lll format is passed.
972 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
973 %llo or %llx format is passed. (Bug#8545)
974
03ab8921
EZ
975 * window.c (window_scroll_line_based): Use a marker instead of
976 simple variables to record original value of point. (Bug#7952)
977
afda1437
EZ
978 * doprnt.c (doprnt): Fix the case where a multibyte sequence
979 produced by %s or %c overflows available buffer space. (Bug#8545)
980
f76dee0c
PE
9812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
982
983 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 984 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 985
fdc5744d
JB
9862011-04-28 Juanma Barranquero <lekktu@gmail.com>
987
988 * w32.c (init_environment): Warn about defaulting HOME to C:\.
989
638f053a
JB
9902011-04-28 Juanma Barranquero <lekktu@gmail.com>
991
992 * keyboard.c (Qdelayed_warnings_hook): Define.
993 (command_loop_1): Run `delayed-warnings-hook'
994 if Vdelayed_warnings_list is non-nil.
995 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
996 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
997
d178f871
EZ
9982011-04-28 Eli Zaretskii <eliz@gnu.org>
999
1000 * doprnt.c (doprnt): Don't return value smaller than the buffer
1001 size if the message was truncated. (Bug#8545).
1002
b124fd93
JB
10032011-04-28 Juanma Barranquero <lekktu@gmail.com>
1004
1005 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1006 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1007
e810457d
PE
10082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1011
ea51cceb
JB
10122011-04-27 Juanma Barranquero <lekktu@gmail.com>
1013
1014 * makefile.w32-in: Update dependencies.
1015
94dcfacf
EZ
10162011-04-27 Eli Zaretskii <eliz@gnu.org>
1017
1018 Improve `doprnt' and its usage. (Bug#8545)
1019 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1020 `format_end'. Remove support for %l as a conversion specifier.
1021 Don't use xrealloc. Improve diagnostics when the %l size modifier
1022 is used. Update the commentary.
1023
1024 * eval.c (verror): Simplify calculation of size_t.
1025
1026 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1027 messages.
1028
f61f41d7
PE
10292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1030
1031 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1032 change.
1033
96fb4434
PE
10342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1037 This makes this file independent of the recent pseudovector change.
1038
671875da 10392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1040
69e9b5a3
PE
1041 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1042
b5f869a7 1043 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1044 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1045 Remove unused local.
c8926152 1046 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1047
841a1577 1048 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1049 GCC 4.6.0 optimizes based on type-based alias analysis.
1050 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1051 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1052 != &v->size, and therefore "v->size = 1; b->size = 2; return
1053 v->size;" must therefore return 1. This assumption is incorrect
1054 for Emacs, since it type-puns struct Lisp_Vector * with many other
1055 types. To fix this problem, this patch adds a new type struct
f904488f 1056 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1057 and pseudovectors, and helps optimizing compilers not get fooled
1058 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1059 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1060 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1061 the size member.
eab3844f
PE
1062 (XSETPVECTYPE): Rewrite in terms of new macro.
1063 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1064 This is a bit clearer, and further avoids the possibility of
1065 undesirable aliasing.
1066 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1067 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1068 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1069 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1070 (ASIZE): Now uses header.size rather than size.
1071 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1072 to avoid the hassle of writing XVECTOR (foo)->header.size.
1073 (struct vectorlike_header): New type.
eab3844f
PE
1074 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1075 object, to help avoid aliasing.
1076 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1077 (SUBRP): Likewise, since Lisp_Subr is a special case.
1078 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1079 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1080 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1081 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1082 changed to be "header.size" and "header.next".
1083 * buffer.h (struct buffer): Likewise.
1084 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1085 * frame.h (struct frame): Likewise.
1086 * process.h (struct Lisp_Process): Likewise.
1087 * termhooks.h (struct terminal): Likewise.
1088 * window.c (struct save_window_data, struct saved_window): Likewise.
1089 * window.h (struct window): Likewise.
1090 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1091 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1092 * buffer.c (init_buffer_once): Likewise.
1093 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1094 special case.
1095 * process.c (Fformat_network_address): Use local var for size,
1096 for brevity.
1097
0df1eac5
PE
1098 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1099
847ab9d1 1100 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1101 * data.c (atof): Remove decl; no longer used or needed.
1102 (digit_to_number): Move to lread.c.
1103 (Fstring_to_number): Use new string_to_number function, to be
1104 consistent with how the Lisp reader treats infinities and NaNs.
1105 Do not assume that floating-point numbers represent EMACS_INT
1106 without losing information; this is not true on most 64-bit hosts.
1107 Avoid double-rounding errors, by insisting on integers when
1108 parsing non-base-10 numbers, as the documentation specifies.
1109 * lisp.h (string_to_number): New decl, replacing ...
1110 (isfloat_string): Remove.
bc0a5c13 1111 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1112 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1113 appears to have been a coding error. Similarly, do not accept
1114 strings like +-1e0 as floating point numbers. Do not report
1115 overflow for integer overflows unless the base is not 10 which
1116 means we have no simple and reliable way to continue.
1117 Break out the floating-point parsing into a new
1118 function string_to_number, so that Fstring_to_number parses
1119 floating point numbers consistently with the Lisp reader.
04f2d78b 1120 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1121 (E_CHAR, EXP_INT): Remove, replacing with ...
1122 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1123 (string_to_number): New function, replacing isfloat_string.
1124 This function checks for valid syntax and produces the resulting
1125 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1126 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1127 so that overflow for non-base-10 numbers is reported only when
1128 there's no portable and simple way to convert to floating point.
452f4150 1129
67769ffc
PE
1130 * textprop.c (set_text_properties_1): Rewrite for clarity,
1131 and to avoid GCC warning about integer overflow.
1132
c20db43f
PE
1133 * intervals.h (struct interval): Use EMACS_INT for members
1134 where EMACS_UINT might cause problems. See
1135 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1136 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1137 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1138 All uses changed.
37aa2f85
PE
1139 (offset_intervals): Tell GCC not to worry about length overflow
1140 when negating a negative length.
c20db43f 1141
2538aa2f
PE
1142 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1143 (overrun_check_free): Likewise.
1144
f2d3008d
PE
1145 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1146 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1147 word size.
1148
ec8df744
PE
1149 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1150 (gnutls_make_error): Rename local to avoid shadowing.
1151 (gnutls_emacs_global_deinit): ifdef out; not used.
1152 (Fgnutls_boot): Use const for pointer to readonly storage.
1153 Comment out unused local. Fix pointer signedness problems.
1154
640ee02d
PE
1155 * lread.c (openp): Don't stuff size_t into an 'int'.
1156 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1157 about possible signed overflow.
1158
6048fb2a
PE
1159 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1160 (GDK_KEY_g): Don't define if already defined.
1161 (xg_prepare_tooltip): Avoid pointer signedness problem.
1162 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1163
fa3c87e1
PE
1164 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1165 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1166
2172544b
PE
1167 * xfns.c (Fx_window_property): Simplify a bit,
1168 to make a bit faster and to avoid GCC 4.6.0 warning.
1169 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1170
9b821a21
PE
1171 * fns.c (internal_equal): Don't assume size_t fits in int.
1172
3c616cfa
PE
1173 * alloc.c (compact_small_strings): Tighten assertion a little.
1174
c2982e87
PE
1175 Replace pEd with more-general pI, and fix some printf arg casts.
1176 * lisp.h (pI): New macro, generalizing old pEd macro to other
1177 conversion specifiers. For example, use "...%"pI"d..." rather
1178 than "...%"pEd"...".
1179 (pEd): Remove. All uses replaced with similar uses of pI.
1180 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1181 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1182 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1183 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1184 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1185 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1186 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1187 64-bit hosts.
1188 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1189 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1190 * print.c (safe_debug_print, print_object): Likewise.
1191 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1192 to int.
6f04d126
PE
1193 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1194 avoiding the 0 flag, which is not portable.
c2982e87
PE
1195 * process.c (Fmake_network_process): Use pI to avoid cast.
1196 * region-cache.c (pp_cache): Likewise.
1197 * xdisp.c (decode_mode_spec): Likewise.
1198 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1199 behavior on 64-bit hosts with printf arg.
6f04d126 1200 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1201 (x_stop_queuing_selection_requests): Likewise.
1202 (x_get_window_property): Don't truncate byte count to an 'int'
1203 when tracing.
0b432f21 1204
5e073ec7
PE
1205 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1206 here, since it parses constructs like leading '-' and spaces,
1207 which are not wanted; and it overflows with large numbers.
1208 Instead, simply match F[0-9]+, which is what is wanted anyway.
1209
36372bf9
PE
1210 * alloc.c: Remove unportable assumptions about struct layout.
1211 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1212 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1213 (allocate_vectorlike, make_pure_vector): Use the new macros,
1214 plus offsetof, to remove unportable assumptions about struct layout.
1215 These assumptions hold on all porting targets that I know of, but
1216 they are not guaranteed, they're easy to remove, and removing them
1217 makes further changes easier.
1218
0b432f21
PE
1219 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1220 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1221 (string_overrun_cookie): Now const. Use initializers that
1222 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1223 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1224 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1225 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1226 multiple of sizeof (EMACS_INT); it need not be, if
1227 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1228 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1229
895009e1
JB
12302011-04-26 Juanma Barranquero <lekktu@gmail.com>
1231
1232 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1233
6a7a1b0b
TZ
12342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1235
1236 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1237 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1238 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1239
841a1577 12402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1241
1242 * lisp.h (Qdebug): List symbol.
895009e1 1243 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1244 * keyboard.c (debug-on-event): New variable.
1245 (handle_user_signal): Break into debugger when debug-on-event
1246 matches the current signal symbol.
1247
f2d3ba6f
DN
12482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1249
1250 * alloc.c (check_sblock, check_string_bytes)
1251 (check_string_free_list): Convert to standard C.
1252
42ce4c63
TZ
12532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1254
1255 * w32.c (emacs_gnutls_push): Fix typo.
1256
825cd63c
EZ
12572011-04-25 Eli Zaretskii <eliz@gnu.org>
1258
fb11d64d
EZ
1259 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1260 "cast to pointer from integer of different size".
1261
825cd63c
EZ
1262 Improve doprnt and its use in verror. (Bug#8545)
1263 * doprnt.c (doprnt): Document the set of format control sequences
1264 supported by the function. Use SAFE_ALLOCA instead of always
1265 using `alloca'.
1266
1267 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1268 is one byte too soon. Don't use xrealloc; instead xfree and
1269 xmalloc anew.
1270
e061a11b
TZ
12712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1272
1273 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1274 callbacks stage.
1275
1276 * gnutls.c: Renamed global_initialized to
1277 gnutls_global_initialized. Added internals for the
1278 :verify-hostname-error, :verify-error, and :verify-flags
1279 parameters of `gnutls-boot' and documented those parameters in the
1280 docstring. Start callback support.
1281 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1282 unless a fatal error occured. Call gnutls_alert_send_appropriate
1283 on error. Return error code.
1284 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1285 (emacs_gnutls_read): Likewise.
1286 (Fgnutls_boot): Return handshake error code.
1287 (emacs_gnutls_handle_error): New function.
1288 (wsaerror_to_errno): Likewise.
1289
1290 * w32.h (emacs_gnutls_pull): Add prototype.
1291 (emacs_gnutls_push): Likewise.
1292
1293 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1294 (emacs_gnutls_push): Likewise.
1295
12962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1297
1298 * process.c (wait_reading_process_output): Check if GnuTLS
1299 buffered some data internally if no FDs are set for TLS
1300 connections.
1301
1302 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1303 (LIBS): Link to USER_LIBS.
1304 ($(BLD)/gnutls.$(0)): New target.
1305
fa6996bc
EZ
13062011-04-24 Eli Zaretskii <eliz@gnu.org>
1307
eb35682e
EZ
1308 * xdisp.c (handle_single_display_spec): Rename the
1309 display_replaced_before_p argument into display_replaced_p, to
1310 make it consistent with the commentary. Fix typos in the
1311 commentary.
1312
e2ad650c
EZ
1313 * textprop.c (syms_of_textprop): Remove dead code.
1314 (copy_text_properties): Delete obsolete commentary about an
1315 interface that was deleted long ago. Fix typos in the description
1316 of arguments.
1317
1b2de274
EZ
1318 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1319 to changes in oldXMenu/XMenu.h from 2011-04-16.
1320 <menu_help_message, prev_menu_help_message>: Constify.
1321 (IT_menu_make_room): menu->help_text is now `const char **';
1322 adjust.
1323
1324 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1325 to changes in oldXMenu/XMenu.h from 2011-04-16.
1326 (struct XMenu): Declare `help_text' `const char **'.
1327
1328 * xfaces.c <Qunspecified>: Make extern again.
1329
1330 * syntax.c: Include sys/types.h before including regex.h, as
1331 required by Posix.
1332
762b15be
EZ
1333 * doc.c (get_doc_string): Improve the format passed to `error'.
1334
1335 * doprnt.c (doprnt): Improve commentary.
1336
1337 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1338
1339 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1340 them with etags.
1341
f1052e5d
EZ
1342 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1343 changes in globals.h immediately force recompilation.
762b15be
EZ
1344 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1345 $(CURDIR)/s/ms-w32.h.
1346 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1347
fa6996bc
EZ
1348 * character.c (Fchar_direction): Function deleted.
1349 (syms_of_character): Don't defsubr it.
1350 <char-direction-table>: Deleted.
1351
e6c3da20
EZ
13522011-04-23 Eli Zaretskii <eliz@gnu.org>
1353
1354 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1355 * doprnt.c: Include limits.h.
1356 (SIZE_MAX): New macro.
04f2d78b
CB
1357 (doprnt): Return a size_t value. 2nd arg is now size_t.
1358 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1359 Improve overflow protection. Support `l' modifier for integer
1360 conversions. Support %l conversion. Don't assume an EMACS_INT
1361 argument for integer conversions and for %c.
1362
1363 * lisp.h (doprnt): Restore prototype.
1364
1365 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1366 $(SRC)/character.h.
1367
1368 * Makefile.in (base_obj): Add back doprnt.o.
1369
1370 * deps.mk (doprnt.o): Add back prerequisites.
1371 (callint.o): Depend on character.h.
1372
1373 * eval.c (internal_lisp_condition_case): Include the handler
1374 representation in the error message.
1375 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1376 when breaking from the loop.
1377
1378 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1379
1380 * callint.c (Fcall_interactively): When displaying error message
1381 about invalid control letter, pass the character's codepoint, not
1382 a pointer to its multibyte form. Improve display of the character
1383 in octal and display also its hex code.
1384
1385 * character.c (char_string): Use %x to display the (unsigned)
1386 codepoint of an invalid character, to avoid displaying a bogus
1387 negative value.
1388
1389 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1390 `error', not SYMBOL_NAME itself.
1391
1392 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1393 character arguments to `error'.
1394
1395 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1396 to `error' in error message about FINAL_CHAR argument. Make sure
1397 FINAL_CHAR is a character, and use %c when it is passed as
1398 argument to `error'.
1399
4ffd0d6b 14002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1401
1402 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1403
1404 * w32.c: Include <time.h>.
1405 (sys_localtime): New function.
1406
4ffd0d6b 14072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1408
1409 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1410
4ffd0d6b 1411 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1412
4ffd0d6b 14132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1414
4ffd0d6b
GM
1415 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1416 zombies (Bug#8467).
aac0c6e3 1417
04c56954
EZ
14182011-04-19 Eli Zaretskii <eliz@gnu.org>
1419
1420 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1421 gl_state.e_property when gl_state.object is Qt.
1422
1423 * insdel.c (make_gap_larger): Remove limitation of buffer size
1424 to <= INT_MAX.
1425
16a43933
CY
14262011-04-18 Chong Yidong <cyd@stupidchicken.com>
1427
1428 * xdisp.c (lookup_glyphless_char_display)
1429 (produce_glyphless_glyph): Handle cons cell entry in
1430 glyphless-char-display.
1431 (Vglyphless_char_display): Document it.
1432
1433 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1434 glyphless-char-display.
1435
4581706e
CY
14362011-04-17 Chong Yidong <cyd@stupidchicken.com>
1437
1438 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1439
1440 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1441
1442 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1443 definition for no-X builds.
1444
4887c6e2 14452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1446
fd35b6f9
PE
1447 Static checks with GCC 4.6.0 and non-default toolkits.
1448
5c1ccb01
PE
1449 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1450
006c5daa
PE
1451 * process.c (keyboard_bit_set): Define only if SIGIO.
1452 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1453 (send_process): Repair possible setjmp clobbering.
1454
efc736d3
PE
1455 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1456
4e2fe2e6
PE
1457 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1458
f97334a2
PE
1459 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1460
4e75f29d
PE
1461 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1462 Define only if needed.
1463
90efadd1
PE
1464 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1465 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1466 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1467
3c647824
PE
1468 * dispextern.h (struct redisplay_interface): Rename param
1469 to avoid shadowing.
e264f262 1470 * termhooks.h (struct terminal): Likewise.
761383f4 1471 * xterm.c (xembed_send_message): Likewise.
3c647824 1472
b58c5c4a
PE
1473 * insdel.c (make_gap_smaller): Define only if
1474 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1475
cad59032
PE
1476 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1477 it.
1478
c339dc2e
PE
1479 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1480 so that we aren't warned about unused symbols.
1481
91a3e27b
PE
1482 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1483
399c71d3 1484 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1485
8ffc96f5
PE
1486 * xfns.c (x_real_positions): Mark locals as initialized.
1487
eef9bc79
PE
1488 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1489
098db9dd
PE
1490 * xterm.c: Fix problems found by static analysis with other toolkits.
1491 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1492 (x_dispatch_event): Declare static if USE_GTK, and
1493 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1494 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1495 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1496 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1497 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1498
eb18f6cc
PE
1499 * xmenu.c (menu_help_callback): Pointer type fixes.
1500 Use const pointers when pointing at readonly data. Avoid pointer
1501 signedness clashes.
1502 (FALSE): Remove unused macro.
1503 (update_frame_menubar): Remove unused decl.
1504
1fe72bf8
PE
1505 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1506
60d9e1db
PE
1507 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1508 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1509 (single_menu_item): Rename local to avoid shadowing.
1510
39261c26
PE
1511 * keyboard.c (make_lispy_event): Remove unused local var.
1512
018c5e19
PE
1513 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1514 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1515
63d2b86e
PE
1516 * bitmaps: Change bitmaps from unsigned char back to the X11
1517 compatible char. Avoid the old compiler warnings about
1518 out-of-range initializers by using, for example, '\xab' rather
1519 than 0xab.
1520
aefd87e1
PE
1521 * xgselect.c (xgselect_initialize): Check vs interface
1522 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1523
bf501fb9
PE
1524 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1525
e9829fdf
PE
1526 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1527 to read-only memory.
1528
1086c095
PE
1529 * fns.c (vector): Remove; this old hack is no longer needed.
1530
2baccd04 1531 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1532 Remove unused var.
dde42981 1533 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1534
72391843 1535 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1536
436c16df 1537 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1538 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1539 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1540
92bb796d 1541 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1542 (x_term_init): Remove local to avoid shadowing.
92bb796d 1543
764430a3 1544 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1545
1546 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1547 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1548
d1dfb56c
EZ
15492011-04-16 Eli Zaretskii <eliz@gnu.org>
1550
c4354cb4
EZ
1551 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1552
d1dfb56c
EZ
1553 Fix regex.c, syntax.c and friends for buffers > 2GB.
1554 * syntax.h (struct gl_state_s): Declare character position members
1555 EMACS_INT.
1556
1557 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1558
04f2d78b
CB
1559 * textprop.c (verify_interval_modification, interval_of):
1560 Declare arguments EMACS_INT.
d1dfb56c
EZ
1561
1562 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1563 EMACS_INT.
1564
1565 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1566
1567 * indent.c (Fvertical_motion): Local variable it_start is now
1568 EMACS_INT.
1569
1570 * regex.c (re_match, re_match_2, re_match_2_internal)
1571 (bcmp_translate, regcomp, regexec, print_double_string)
1572 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1573 (re_compile_pattern, re_exec): Declare arguments and local
1574 variables `size_t' and `ssize_t' and return values `regoff_t', as
1575 appropriate.
1576 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1577 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1578 <compile_stack_type>: `size' and `avail' are now `size_t'.
1579
1580 * regex.h <regoff_t>: Use ssize_t, not int.
1581 (re_search, re_search_2, re_match, re_match_2): Arguments that
1582 specify buffer/string position and length are now ssize_t and
1583 size_t. Return type is regoff_t.
1584
613052cd
BK
15852011-04-16 Ben Key <bkey76@gmail.com>
1586
1587 * nsfont.m: Fixed bugs in ns_get_family and
1588 ns_descriptor_to_entity that were caused by using free to
1589 deallocate memory blocks that were allocated by xmalloc (via
1590 xstrdup). This caused Emacs to crash when compiled with
1591 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1592 --enable-checking=xmallocoverrun). xfree is now used to
1593 deallocate these memory blocks.
1594
4170f62f 15952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1596
71b41406
PE
1597 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1598
9587a89d
PE
1599 emacs_write: Accept and return EMACS_INT for sizes.
1600 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1601 et seq.
1602 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1603 Accept and return EMACS_INT.
1604 (emacs_gnutls_write): Return the number of bytes written on
1605 partial writes.
1606 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1607 (emacs_read, emacs_write): Remove check for negative size, as the
1608 Emacs source code has been audited now.
9587a89d
PE
1609 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1610 (emacs_read, emacs_write): Use it.
273a5f82
PE
1611 * process.c (send_process): Adjust to the new signatures of
1612 emacs_write and emacs_gnutls_write. Do not attempt to store
1613 a byte offset into an 'int'; it might overflow.
9587a89d 1614 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1615
3e047f51
PE
1616 * sound.c: Don't assume sizes fit in 'int'.
1617 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1618 Return EMACS_INT, not int.
3e047f51 1619 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1620 Accept EMACS_INT, not int.
1621 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1622 record read return values.
1623
cc39a9db
BK
16242011-04-15 Ben Key <bkey76@gmail.com>
1625
c9d0ec6d
JB
1626 * keyboard.c (Qundefined): Don't declare static since it is used
1627 in nsfns.m.
1628 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1629 static since they are used in nsfont.m.
cc39a9db 1630
6c60eb9f
SM
16312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1632
1633 * process.c (Qprocessp): Don't declare static.
1634 * lisp.h (Qprocessp): Declare again.
1635
7990b61a
JB
16362011-04-15 Juanma Barranquero <lekktu@gmail.com>
1637
1638 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1639
5d4cb038
PE
16402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1641
8bd7b830 1642 Improve C-level modularity by making more things 'static'.
cd64ea1d 1643
e3b27b31
PE
1644 Don't publish debugger-only interfaces to other modules.
1645 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1646 (verify_bytepos, count_markers): Move decls to the only modules
1647 that need them.
1648 * region-cache.h (pp_cache): Likewise.
1649 * window.h (check_all_windows): Likewise.
1650 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1651
5d4cb038
PE
1652 * sysdep.c (croak): Now static, if
1653 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1654 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1655
1656 * alloc.c (refill_memory_reserve): Now static if
1657 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1658 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1659
e87b6180
PE
1660 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1661 Define only if USE_LUCID.
1662
ac64929e
PE
1663 * xrdb.c (x_customization_string, x_rm_string): Now static.
1664
6f37259d
PE
1665 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1666 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1667
1683e3ab
PE
1668 * xdisp.c (draw_row_with_mouse_face): Now static.
1669 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1670
de9c2632
PE
1671 * window.h (check_all_windows): Mark externally visible.
1672
2b96acb7
PE
1673 * window.c (window_deletion_count): Now static.
1674
1675 * undo.c: Make symbols static if they're not exported.
1676 (last_undo_buffer, last_boundary_position, pending_boundary):
1677 Now static.
1678
50436f33
PE
1679 * textprop.c (interval_insert_behind_hooks): Now static.
1680 (interval_insert_in_front_hooks): Likewise.
1681
64520e5c
PE
1682 * term.c: Make symbols static if they're not exported.
1683 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1684 (max_frame_lines, tty_set_terminal_modes):
1685 (tty_reset_terminal_modes, tty_turn_off_highlight):
1686 (get_tty_terminal): Now static.
1687 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1688 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1689 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1690 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1691 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1692
1fa53021
PE
1693 * sysdep.c: Make symbols static if they're not exported.
1694 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1695 Now static.
1696 (sigprocmask_set, full_mask): Remove; unused.
1697 (wait_debugging): Mark as visible.
1698 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1699 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1700
d4b43b22
PE
1701 * syntax.c (syntax_temp): Define only if !__GNUC__.
1702
b7c513d0
PE
1703 * sound.c (current_sound_device, current_sound): Now static.
1704
989b29ad
PE
1705 * search.c (searchbufs, searchbuf_head): Now static.
1706
13a55a78
PE
1707 * scroll.c (scroll_cost): Remove; unused.
1708 * dispextern.h (scroll_cost): Remove decl.
1709
de68a1fc
PE
1710 * region-cache.h (pp_cache): Mark as externally visible.
1711
40ccffa6
PE
1712 * process.c: Make symbols static if they're not exported.
1713 (process_tick, update_tick, create_process, chan_process):
1714 (Vprocess_alist, proc_buffered_char, datagram_access):
1715 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1716 (deactivate_process): Mark defn as static, as well as decl.
1717 * lisp.h (create_process): Remove decl.
1718 * process.h (chan_process, Vprocess_alist): Remove decls.
1719
ad64fc97
PE
1720 * print.c: Make symbols static if they're not exported.
1721 (print_depth, new_backquote_output, being_printed, print_buffer):
1722 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1723 (print_interval, print_number_index, initial_stderr_stream):
1724 Now static.
1725 * lisp.h (Fprinc): Remove decl.
1726 (debug_output_compilation_hack): Mark as externally visible.
1727
adddb265
PE
1728 * sysdep.c (croak): Move decl from here to syssignal.h.
1729 * syssignal.h (croak): Put it here, so the API can be checked when
1730 'croak' is called from dissociate_if_controlling_tty.
1731
1717ede2
PE
1732 * minibuf.c: Make symbols static if they're not exported.
1733 (minibuf_save_list, choose_minibuf_frame): Now static.
1734 * lisp.h (choose_minibuf_frame): Remove decl.
1735
fa5fb2bc
PE
1736 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1737
1e3890d1
PE
1738 * lread.c: Make symbols static if they're not exported.
1739 (read_objects, initial_obarray, oblookup_last_bucket_number):
1740 Now static.
1741 (make_symbol): Remove; unused.
1742 * lisp.h (initial_obarray, make_symbol): Remove decls.
1743
8a1414fa
PE
1744 * keyboard.c: Make symbols static if they're not exported.
1745 (single_kboard, recent_keys_index, total_keys, recent_keys):
1746 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1747 (this_single_command_key_start, echoing, last_auto_save):
1748 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1749 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1750 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1751 (Vlispy_mouse_stem, double_click_count):
1752 Now static.
1753 (force_auto_save_soon): Define only if SIGDANGER.
1754 (ignore_mouse_drag_p): Now static if
1755 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1756 (print_help): Remove; unused.
1757 (stop_character, last_timer_event): Mark as externally visible.
1758 * keyboard.h (ignore_mouse_drag_p): Declare only if
1759 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1760 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1761 * lisp.h (echoing): Remove decl.
1762 (force_auto_save_soon): Declare only if SIGDANGER.
1763 * xdisp.c (redisplay_window): Simplify code, to make it more
1764 obvious that ignore_mouse_drag_p is not accessed if !defined
1765 USE_GTK && !defined HAVE_NS.
1766
93ea6e8f
PE
1767 * intervals.c: Make symbols static if they're not exported.
1768 (merge_properties_sticky, merge_interval_right, delete_interval):
1769 Now static.
1770 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1771
77382fcc
PE
1772 * insdel.c: Make symbols static if they're not exported.
1773 However, leave prepare_to_modify_buffer alone. It's never
1774 called from outside this function, but that appears to be a bug.
1775 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1776 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1777 (adjust_after_replace_noundo): Remove; unused.
1778 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1779 (signal_before_change): Remove decls.
77382fcc 1780
9306c32e
PE
1781 * indent.c (val_compute_motion, val_vmotion): Now static.
1782
cd44d2eb
PE
1783 * image.c: Make symbols static if they're not exported.
1784 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1785 if USE_GTK.
1786 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1787 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1788
ad9a7a06
PE
1789 * fringe.c (standard_bitmaps): Now static.
1790 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1791
81626931
PE
1792 * frame.c: Make symbols static if they're not exported.
1793 (x_report_frame_params, make_terminal_frame): Now static.
1794 (get_frame_param): Now static, unless HAVE_NS.
1795 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1796 (x_get_resource_string): Remove; not used.
1797 * frame.h (make_terminal_frame, x_report_frame_params):
1798 (x_get_resource_string); Remove decls.
1799 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1800 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1801
239f9db9
PE
1802 * font.c, fontset.c: Make symbols static if they're not exported.
1803 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1804 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1805 * font.c (font_close_object): Now static.
1806 * font.h (font_close_object): Remove.
1807 * fontset.c (FONTSET_OBJLIST): Remove.
1808 (free_realized_fontset) #if-0 the body, which does nothing.
1809 (face_suitable_for_char_p): #if-0, as it's never called.
1810 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1811 * xfaces.c (face_at_string_position):
1812 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1813 since 0 is always ASCII.
1814
dfcf3579
PE
1815 * fns.c (weak_hash_tables): Now static.
1816
5045092b
PE
1817 * fileio.c: Make symbols static if they're not exported.
1818 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1819 (Vwrite_region_annotation_buffers): Now static.
1820
57a96f5c
PE
1821 * eval.c: Make symbols static if they're not exported.
1822 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1823 * lisp.h (backtrace_list): Remove decl.
1824
35f08c38
PE
1825 * emacs.c: Make symbols static if they're not exported.
1826 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1827 (fatal_error_code, fatal_error_signal_hook, standard_args):
1828 Now static.
1829 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1830 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1831 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1832 * lisp.h (fatal_error_signal_hook): Remove decl.
1833 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1834
f44bd759
PE
1835 * editfns.c: Move a (normally-unused) function to its only use.
1836 * editfns.c, lisp.h (get_operating_system_release): Remove.
1837 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1838 worth the hassle of breaking this out.
1839
b532497d
PE
1840 * xterm.c: Make symbols static if they're not exported.
1841 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1842 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1843 (x_destroy_window, x_delete_display):
1844 Now static.
1845 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1846 (x_mouse_leave): Remove; unused.
1847 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1848 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1849 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1850 Remove decls.
1851 (x_mouse_leave): Declare only if WINDOWSNT.
1852 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1853 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1854 USE_X_TOOLKIT.
1855
1675728f
PE
1856 * ftxfont.c: Make symbols static if they're not exported.
1857 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1858 HAVE_FREETYPE.
1859 * font.h (ftxfont_driver): Likewise.
1860
e4cebfca
PE
1861 * xfns.c: Make symbols static if they're not exported.
1862 (x_last_font_name, x_display_info_for_name):
1863 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1864 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1865 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1866 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1867 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1868 (last_show_tip_args): Now static.
1869 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1870 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1871 (x_screen_planes): Remove; unused.
1872 * dispextern.h (x_screen_planes): Remove decl.
1873
5bf46f05
PE
1874 * dispnew.c: Make symbols static if they're not exported.
1875 * dispextern.h (redraw_garbaged_frames, scrolling):
1876 (increment_row_positions): Remove.
1877 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1878 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1879 Now static.
1880 (redraw_garbaged_frames): Remove; unused.
1881
435f4c28
PE
1882 * xfaces.c: Make symbols static if they're not exported.
1883 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1884 Remove decls.
1885 * xterm.h (defined_color): Remove decls.
1886 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1887 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1888 (menu_face_changed_default, defined_color, free_realized_face):
1889 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1890 (ascii_face_of_lisp_face): Remove; unused.
1891
8524aef3
PE
1892 * xdisp.c: Make symbols static if they're not exported.
1893 * dispextern.h (scratch_glyph_row, window_box_edges):
1894 (glyph_to_pixel_coords, set_cursor_from_row):
1895 (get_next_display_element, set_iterator_to_next):
1896 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1897 (show_mouse_face): Remove decls
1898 * frame.h (message_buf_print): Likewise.
1899 * lisp.h (pop_message, set_message, check_point_in_composition):
1900 Likewise.
1901 * xterm.h (set_vertical_scroll_bar): Likewise.
1902 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1903 (message_buf_print, scratch_glyph_row, displayed_buffer):
1904 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1905 (get_next_display_element, show_mouse_face, window_box_edges):
1906 (frame_to_window_pixel_xy, check_point_in_composition):
1907 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1908 (glyph_to_pixel_coords): Remove; unused.
1909
16390cd2
PE
1910 * dired.c (file_name_completion): Now static.
1911
1912 * dbusbind.c (xd_in_read_queued_messages): Now static.
1913
a25f4dfa
PE
1914 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1915 * data.c (circular_list_error): Remove.
1916
14a9c8df
PE
1917 * commands.h (last_point_position, last_point_position_buffer):
1918 (last_point_position_window): Remove decls.
1919 * keyboard.c: Make these variables static.
1920
04f2d78b
CB
1921 * coding.h (coding, code_convert_region, encode_coding_gap):
1922 Remove decls.
74ab6df5
PE
1923 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1924 (iso_code_class, detect_coding, code_convert_region): Now static.
1925 (encode_coding_gap): Remove; unused.
1926
38dfbee1
PE
1927 * chartab.c (chartab_chars, chartab_bits): Now static.
1928
a2cb4e63
PE
1929 * charset.h (charset_iso_8859_1): Remove decl.
1930 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1931 Now static.
1932
127198fd
PE
1933 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1934 * ccl.c (Vccl_program_table): Now static.
1935 (check_ccl_update): Remove; unused.
1936
d85b608f
PE
1937 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1938 * category.h: ... from here.
1939 * category.c (check_category_table, set_category_set): Now static.
1940
31cd66f3
PE
1941 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1942 * lisp.h: Remove these decls.
1943
c358e587
PE
1944 * buffer.c (buffer_count): Remove unused var.
1945
e78aecca
PE
1946 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1947 so that it's not optimized away.
1948 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1949 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1950 exported only to the debugger.
1951
e192d7d3 1952 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1953 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1954
92470028
PE
1955 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1956 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1957 was inaccessible from Lisp.
1958 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1959 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1960
244ed907
PE
1961 alloc.c: Import and export fewer symbols, and remove unused items.
1962 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1963 is defined.
1964 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1965 it's not optimized away by whole-program optimization.
1966 (message_enable_multibyte, free_misc): Remove.
1967 (catchlist, handlerlist, mark_backtrace):
1968 Declare only if BYTE_MARK_STACK.
1969 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1970 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1971 (message_enable_multibyte): Remove decl.
1972 (free_misc, interval_free_list, float_block, float_block_index):
1973 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1974 (cons_free_list, last_marked_index):
1975 Now static.
1976 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1977 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1978 (mark_backtrace): Define only if BYTE_MARK_STACK.
1979 * xdisp.c (message_enable_multibyte): Now static.
1980
61c2b50e 1981 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1982 This makes it easier for human readers (and static analyzers)
1983 to see whether these variables are used from other modules.
1984 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1985 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1986 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1987 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1988 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1989 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1990 * xmenu.c, xselect.c:
1991 Declare Q* vars static if they are not used in other modules.
1992 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1993 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1994 Remove decls of unexported vars.
1995 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1996
95c82688
PE
1997 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1998
16a97296
PE
1999 Make Emacs functions such as Fatom 'static' by default.
2000 This makes it easier for human readers (and static analyzers)
2001 to see whether these functions can be called from other modules.
2002 DEFUN now defines a static function. To make the function external
2003 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2004 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2005 (Finit_image_library):
16a97296
PE
2006 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2007 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2008 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2009 Remove decls, since these functions are now static.
2010 (Funintern, Fget_internal_run_time): New decls, since these functions
2011 were already external.
95c82688 2012
16a97296
PE
2013 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2014 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2015 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2016 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2017 * keyboard.c, keymap.c, lread.c:
2018 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2019 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2020 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2021 Mark functions with DEFUE instead of DEFUN,
2022 if they are used in other modules.
2023 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2024 decls for now-static functions.
2025 * buffer.h (Fdelete_overlay): Remove decl.
2026 * callproc.c (Fgetenv_internal): Mark as internal.
2027 * composite.c (Fremove_list_of_text_properties): Remove decl.
2028 (Fcomposition_get_gstring): New forward static decl.
2029 * composite.h (Fcomposite_get_gstring): Remove decl.
2030 * dired.c (Ffile_attributes): New forward static decl.
2031 * doc.c (Fdocumntation_property): New forward static decl.
2032 * eval.c (Ffetch_bytecode): New forward static decl.
2033 (Funintern): Remove extern decl; now in .h file where it belongs.
2034 * fileio.c (Fmake_symbolic_link): New forward static decl.
2035 * image.c (Finit_image_library): New forward static decl.
2036 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2037 * intervals.h (Fprevious_property_change):
2038 (Fremove_list_of_text_properties): Remove decls.
2039 * keyboard.c (Fthis_command_keys): Remove decl.
2040 (Fcommand_execute): New forward static decl.
2041 * keymap.c (Flookup_key): New forward static decl.
2042 (Fcopy_keymap): Now static.
2043 * keymap.h (Flookup_key): Remove decl.
2044 * process.c (Fget_process): New forward static decl.
2045 (Fprocess_datagram_address): Mark as internal.
2046 * syntax.c (Fsyntax_table_p): New forward static decl.
2047 (skip_chars): Remove duplicate decl.
2048 * textprop.c (Fprevious_property_change): New forward static decl.
2049 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2050 Now internal.
2051 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2052 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2053
785bbd42
PE
2054 * editfns.c (Fformat): Remove unreachable code.
2055
8b913b57
AS
20562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2057
2058 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2059 change. (Bug#8496)
2060
a6744a35
EZ
20612011-04-13 Eli Zaretskii <eliz@gnu.org>
2062
2063 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2064 when at ZV. (Bug#8487)
2065
e7974947
AS
20662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2067
baad03f0
AS
2068 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2069 (Bug#8437)
2070 * keyboard.c (parse_tool_bar_item): Likewise.
2071 * sound.c (sound_cleanup, alsa_close): Likewise.
2072 * termcap.c (tgetent): Likewise.
2073 * xfns.c (x_default_font_parameter): Likewise.
2074 * xsettings.c (read_and_apply_settings): Likewise.
2075
e7974947
AS
2076 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2077 (overrun_check_free): Protoize.
2078
28272684
PE
20792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2082 since callers should never pass a negative size.
2083 Change the signature to match that of plain 'read' and 'write'; see
2084 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2085 * lisp.h: Update prototypes of emacs_write and emacs_read.
2086
11997c76
EZ
20872011-04-11 Eli Zaretskii <eliz@gnu.org>
2088
2089 * xdisp.c (redisplay_window): Don't try to determine the character
2090 position of the scroll margin if the window start point w->startp
e896f03c 2091 is outside the buffer's accessible region. (Bug#8468)
11997c76 2092
8a2cbd72
EZ
20932011-04-10 Eli Zaretskii <eliz@gnu.org>
2094
2095 Fix write-region and its subroutines for buffers > 2GB.
2096 * fileio.c (a_write, e_write): Modify declaration of arguments and
2097 local variables to support buffers larger than 2GB.
2098 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2099
2100 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2101 argument, local variables, and return value.
2102
2103 * lisp.h: Update prototypes of emacs_write and emacs_read.
2104
2105 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2106
4073e537 21072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2108
1ebfdcb6
PE
2109 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2110
b2ded58d
PE
2111 Fix more problems found by GCC 4.6.0's static checks.
2112
7d66342c
PE
2113 * xdisp.c (vmessage): Use a better test for character truncation.
2114
bbf47d44
PE
2115 * charset.c (load_charset_map): <, not <=, for optimization,
2116 and to avoid potential problems with integer overflow.
9248994d 2117 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2118 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2119 * editfns.c (Fformat): Likewise.
1e69125e 2120 * syntax.c (skip_chars): Likewise.
3befa583 2121
e3019616
PE
2122 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2123 This also lets GCC 4.6.0 generate slightly better loop code.
2124
becfa255
PE
2125 * callint.c (Fcall_interactively): <, not <=, for optimization.
2126 (Fcall_interactively): Count the number of arguments produced,
2127 not the number of arguments given. This is simpler and lets GCC
2128 4.6.0 generate slightly better code.
2129
dae0cd48
PE
2130 * ftfont.c: Distingish more carefully between FcChar8 and char.
2131 The previous code passed unsigned char * to a functions like
2132 strlen and xstrcasecmp that expect char *, which does not
2133 conform to the C standard.
2134 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2135 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2136 char * when the C standard requires it.
2137
76032d70
PE
2138 * keyboard.c (read_char): Remove unused var.
2139
eb3f1cc8
PE
2140 * eval.c: Port to Windows vsnprintf (Bug#8435).
2141 Include <limits.h>.
2142 (SIZE_MAX): Define if the headers do not.
2143 (verror): Do not give up if vsnprintf returns a negative count.
2144 Instead, grow the buffer. This ports to Windows vsnprintf, which
2145 does not conform to C99. Problem reported by Eli Zaretskii.
2146 Also, simplify the allocation scheme, by avoiding the need for
2147 calling realloc, and removing the ALLOCATED variable.
2148
70476b54
PE
2149 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2150
12020a9e
PE
2151 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2152 But keep the doprint source code for now, as we might revamp it
2153 and use it again (Bug#8435).
ea6c7ae6
PE
2154 * lisp.h (doprnt): Remove.
2155 * Makefile.in (base_obj): Remove doprnt.o.
2156 * deps.mk (doprnt.o): Remove.
2157
5fdb398c
PE
2158 error: Print 32- and 64-bit integers portably (Bug#8435).
2159 Without this change, on typical 64-bit hosts error ("...%d...", N)
2160 was used to print both 32- and 64-bit integers N, which relied on
2161 undefined behavior.
2162 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2163 New macro.
2164 * lisp.h (error, verror): Mark as printf-like functions.
2165 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2166 Report overflow in size calculations when allocating printf buffer.
2167 Do not truncate output string at its first null byte.
2168 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2169 Truncate the output at a character boundary, since vsnprintf does not
2170 do that.
2171 * charset.c (check_iso_charset_parameter): Convert internal
2172 character to string before calling 'error', since %c now has the
2173 printf meaning.
2174 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2175 overflow when computing char to be passed to 'error'. Do not
2176 pass Lisp_Object to 'error'; pass the integer instead.
2177 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2178 formatted with plain %d.
2179
b189fa66
PE
2180 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2181
bff87ef0
PE
2182 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2183
7e2cac20
PE
2184 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2185
ce4d90b5
PE
2186 * xterm.c (x_catch_errors): Remove duplicate declaration.
2187
266c9547
PE
2188 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2189
79c49ad2
PE
2190 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2191
368f4090
JM
21922011-04-10 Jim Meyering <meyering@redhat.com>
2193
2194 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2195 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2196 return ssize_t not "int", and use size_t as the buffer length.
2197 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2198 * gnutls.h: Update declarations.
2199 * process.c (read_process_output): Use ssize_t, to match.
2200 (send_process): Likewise.
2201
a32d4040
CY
22022011-04-09 Chong Yidong <cyd@stupidchicken.com>
2203
2204 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2205
8546720e 22062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2207
04f2d78b
CB
2208 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2209 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2210
8546720e
GM
2211 * xterm.c (handle_one_xevent):
2212 * xmenu.c (create_and_show_popup_menu):
2213 * xselect.c (x_decline_selection_request)
2214 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2215
0a2f5c1a 22162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2217
2218 Fix some uses of `int' instead of EMACS_INT.
2219 * search.c (string_match_1, fast_string_match)
2220 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2221 (scan_buffer, find_next_newline_no_quit)
2222 (find_before_next_newline, search_command, Freplace_match)
2223 (Fmatch_data): Make some `int' variables be EMACS_INT.
2224
2225 * xdisp.c (display_count_lines): 3rd argument and return value now
2226 EMACS_INT. All callers changed.
2227 (pint2hrstr): Last argument is now EMACS_INT.
2228
2229 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2230 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2231 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2232 (decode_coding_utf_16, decode_coding_emacs_mule)
2233 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2234 (decode_coding_ccl, decode_coding_charset)
2235 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2236 (decode_coding_iso_2022, decode_coding_emacs_mule)
2237 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2238 <char_offset, last_offset>: Declare EMACS_INT.
2239 (encode_coding_utf_8, encode_coding_utf_16)
2240 (encode_coding_emacs_mule, encode_invocation_designation)
2241 (encode_designation_at_bol, encode_coding_iso_2022)
2242 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2243 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2244 Declare EMACS_INT.
2245 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2246 (encode_invocation_designation): Last argument P_NCHARS is now
2247 EMACS_INT.
2248 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2249 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2250
2251 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2252 All users changed.
2253
2254 * ccl.c (Fccl_execute_on_string): Declare some variables
2255 EMACS_INT.
2256
8546720e 22572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2258
2259 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2260
4e19a977
CS
22612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2262
2263 * process.c (Fformat_network_address): Doc fix.
2264
87302331
R
22652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2266
2267 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2268
cbb59342
CY
22692011-04-08 Chong Yidong <cyd@stupidchicken.com>
2270
2271 * keyboard.c (read_char): Call Lisp function help-form-show,
2272 instead of using internal_with_output_to_temp_buffer.
2273 (Qhelp_form_show): New var.
e0d38eeb 2274 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2275
2276 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2277
2278 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2279
e67a13ab
CY
22802011-04-06 Chong Yidong <cyd@stupidchicken.com>
2281
04f2d78b
CB
2282 * process.c (Flist_processes): Remove to Lisp.
2283 (list_processes_1): Delete.
e67a13ab 2284
973f782d
EZ
22852011-04-06 Eli Zaretskii <eliz@gnu.org>
2286
7c106b1e
EZ
2287 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2288
973f782d
EZ
2289 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2290
41cf7d1a 22912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2292
ca23cc88
PE
2293 Fix more problems found by GCC 4.6.0's static checks.
2294
f390e2d5
PE
2295 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2296
42eea0d0
PE
2297 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2298
b69769da 2299 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2300
f9541e84
PE
2301 * xdisp.c (vmessage): Mark as a printf-like function.
2302
13841b55
PE
2303 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2304
c136c10f
PE
2305 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2306
5e2d4a30
PE
2307 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2308 printf-like functions.
2309 (tiff_load): Add casts to remove these marks before passing them
2310 to system-supplied API.
2311
583f48b9
PE
2312 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2313
b25d760e
PE
2314 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2315 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2316 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2317 directly, rather than having caller test rule sign. This avoids
2318 some unnecessary tests.
2319 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2320 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2321 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2322
bc7b6697 2323 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2324 (xfont_open): Avoid unnecessary tests.
bc7b6697 2325
27ccc379
PE
2326 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2327
dcd5c89a
PE
2328 * composite.h, composite.c (composition_gstring_put_cache):
2329 Use EMACS_INT, not int, for length.
2330
b13a45c6
PE
2331 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2332 breaking out part of COMPOSITION_DECODE_RULE.
2333 (COMPOSITION_DECODE_RULE): Use it.
2334 * composite.c (get_composition_id): Remove unused local vars,
2335 by using the new macro.
2336
1e792e4d
PE
2337 * textprop.c (set_text_properties_1): Change while to do-while,
2338 since the condition is always true at first.
2339
dc6c6455 2340 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2341 (interval_deletion_adjustment): Return unsigned value.
2342 All uses changed.
dc6c6455 2343
aba7731a
PE
2344 * process.c (list_processes_1, create_pty, read_process_output):
2345 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2346 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2347 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2348 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2349 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2350
fdfc4bf3
PE
2351 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2352
fca8fe46 2353 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2354 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2355
06a0259a 2356 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2357 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2358 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2359
e7b9e80f
PE
2360 * print.c (print_error_message): Avoid int overflow.
2361
56201685
PE
2362 * font.c (font_list_entities): Redo for clarity,
2363 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2364
78834453 2365 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2366 (font_score): Avoid potential overflow in diff calculation.
78834453 2367
0bc0b309 2368 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2369 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2370
e610eaca
PE
2371 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2372
b895abce
PE
2373 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2374 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2375 can always succeed if overflow has undefined behavior.
2376
1f1d9321 2377 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2378 (wordify): Omit three unnecessary tests.
1f1d9321 2379
c59478bc
PE
2380 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2381 All callers changed. This avoids the need for an unused var.
2382
79b73827
PE
2383 * casefiddle.c (casify_region): Remove var that is set but not used.
2384
a4db5dfe
PE
2385 * dired.c (file_name_completion): Remove var that is set but not used.
2386
43aae36e
PE
2387 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2388
2a47c44d 2389 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2390 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2391
a37c69bf
PE
2392 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2393 Check for integer overflow on size calculations.
2394
328ab8e7
PE
2395 * buffer.c (Fprevious_overlay_change): Remove var that is set
2396 but not used.
2397
e5a2a5cb
PE
2398 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2399 Remove vars that are set but not used.
8d84a6eb 2400 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2401 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2402
a60e5f68
PE
2403 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2404
f661cb61 2405 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2406 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2407
f0397f5a
PE
2408 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2409 that are set but not used.
2410
8664db06 2411 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2412 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2413
6abdaa4a
PE
2414 * xselect.c (x_get_local_selection, x_handle_property_notify):
2415 Remove vars that are set but not used.
2416
0ce7538d 2417 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2418 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2419
9ae848fc
PE
2420 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2421 Remove var that is set but not used.
0b918413
PE
2422 (scroll_bar_windows_size): Now size_t, not int.
2423 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2424 Check for overflow.
9ae848fc 2425
a5a62657
PE
2426 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2427 (map_tty_color) [!defined MSDOS]: Likewise.
2428
5c5cdd39
PE
2429 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2430
66ebf983
PE
2431 * coding.c: Remove vars that are set but not used.
2432 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2433 All callers changed.
2434 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2435 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2436 (decode_coding_charset): Remove vars that are set but not used.
2437
1be4d761
PE
2438 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2439 that is set but not used.
2440
47553fa8
PE
2441 * print.c (print_object): Remove var that is set but not used.
2442
1f7196bf 2443 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2444 The gnulib version avoids calling malloc in the usual case,
2445 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2446 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2447 * filelock.c (current_lock_owner): Likewise.
2448 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2449 * sysdep.c: Include allocator.h, careadlinkat.h.
2450 (emacs_no_realloc_allocator): New static constant.
2451 (emacs_readlink): New function.
fdb61804
PE
2452 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2453 ../lib/careadlinkat.h.
d1fdcab7 2454
f84c17c7
SM
24552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2456
2457 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2458 first non-nil return value).
2459
ef3862ad
JD
24602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2461
2462 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2463 if not defined (Bug#8403).
2464
376a7006
JB
24652011-04-02 Juanma Barranquero <lekktu@gmail.com>
2466
2467 * xdisp.c (display_count_lines): Remove parameter `start',
2468 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2469 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2470 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2471 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2472 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2473 and thereabouts. All callers changed.
2474 (get_per_char_metric): Remove parameter `f', unused since
2475 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2476
6ca3801d
JM
24772011-04-02 Jim Meyering <meyering@redhat.com>
2478
2479 do not dereference NULL upon failed strdup
2480 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2481 (ns_get_family): Likewise.
2482
d8e2b5ba
JB
24832011-04-02 Juanma Barranquero <lekktu@gmail.com>
2484
2485 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2486
8c74fcbd
JD
24872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2488
2489 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2490 later (Bug#8403).
2491
7200d79c
SM
24922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2493
03408648 2494 Add lexical binding.
7200d79c 2495
03408648
SM
2496 * window.c (Ftemp_output_buffer_show): New fun.
2497 (Fsave_window_excursion):
2498 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2499
2500 * lread.c (lisp_file_lexically_bound_p): New function.
2501 (Fload): Bind Qlexical_binding.
2502 (readevalloop): Remove `evalfun' arg.
2503 Bind Qinternal_interpreter_environment.
2504 (Feval_buffer): Bind Qlexical_binding.
2505 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2506 Mark as dynamic.
2507 (syms_of_lread): Declare `lexical-binding'.
2508
2509 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2510
2511 * keyboard.c (eval_dyn): New fun.
2512 (menu_item_eval_property): Use it.
ca105506
SM
2513
2514 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2515
03408648
SM
2516 * fns.c (concat, mapcar1): Accept byte-code-functions.
2517
2518 * eval.c (Fsetq): Handle lexical vars.
2519 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2520 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2521 (FletX, Flet): Obey lexical binding.
2522 (Fcommandp): Handle closures.
2523 (Feval): New `lexical' arg.
2524 (eval_sub): New function extracted from Feval. Use it almost
2525 everywhere where Feval was used. Look up vars in lexical env.
2526 Handle closures.
2527 (Ffunctionp): Move from subr.el.
2528 (Ffuncall): Handle closures.
2529 (apply_lambda): Remove `eval_flags'.
2530 (funcall_lambda): Handle closures and new byte-code-functions.
2531 (Fspecial_variable_p): New function.
2532 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2533 but without exporting it to Lisp.
23aba0ea 2534
23aba0ea 2535 * doc.c (Fdocumentation, store_function_docstring):
03408648 2536 * data.c (Finteractive_form): Handle closures.
23aba0ea 2537
03408648
SM
2538 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2539 interactive spec.
ba83908c 2540
04f2d78b
CB
2541 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2542 New byte-codes.
03408648
SM
2543 (exec_byte_code): New function extracted from Fbyte_code to handle new
2544 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2545
03408648 2546 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2547
03408648 2548 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2549
e2abce01
JB
25502011-03-31 Juanma Barranquero <lekktu@gmail.com>
2551
2552 * xdisp.c (redisplay_internal): Fix prototype.
2553
63696a73 25542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2555
63696a73 2556 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2557 (try_scrolling): Use it when setting scroll_limit.
2558 Limit scrolling to 100 screen lines.
63696a73
EZ
2559 (redisplay_window): Even when falling back on "recentering",
2560 position point in the window according to scroll-conservatively,
2561 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2562
2563 (try_scrolling): When point is above the window, allow searching
2564 as far as scroll_max, or one screenful, to compute vertical
2565 distance from PT to the scroll margin position. This prevents
2566 try_scrolling from unnecessarily failing when
2567 scroll-conservatively is set to a value slightly larger than the
2568 window height. Clean up the case of PT below the margin at bottom
2569 of window: scroll_max can no longer be INT_MAX. When aggressive
2570 scrolling is in use, don't let point enter the opposite scroll
2571 margin as result of the scroll.
2572 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2573 threshold of 100 lines for never-recentering scrolling.
2574
e4cc2dfc
JB
25752011-03-31 Juanma Barranquero <lekktu@gmail.com>
2576
2577 * dispextern.h (move_it_by_lines):
2578 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2579 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2580 (message_log_check_duplicate): Remove parameters `prev_bol' and
2581 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2582 (redisplay_internal): Remove parameter `preserve_echo_area',
2583 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2584
2585 * indent.c (Fvertical_motion):
2586 * window.c (window_scroll_pixel_based, Frecenter):
2587 Don't pass `need_y_p' to `move_it_by_lines'.
2588
1c470562
SM
25892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2590
44f230aa
SM
2591 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2592 steal a few bits to be more compact.
2593 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2594 Remove unneeded casts.
2595
1c470562
SM
2596 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2597
888adce9
ZK
25982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2599
2600 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2601 binding" message (bug#7967).
2602
f838ed7b
PE
26032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2604
77861b95
PE
2605 Fix more problems found by GCC 4.6.0's static checks.
2606
de6dbc14
PE
2607 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2608 Remove unused local var.
2609
f838ed7b
PE
2610 * editfns.c (Fmessage_box): Remove unused local var.
2611
792c7b2b
PE
2612 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2613 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2614 Omit unused local vars.
c499e557 2615 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2616 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2617 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2618 Omit unused local var.
2619
ba0165e1
PE
2620 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2621 Don't assume string length fits in int.
32ad8845 2622 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2623 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2624
3c59b4c9
PE
2625 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2626 instead of alloca (Bug#8344).
2627
a3eed478 2628 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2629 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2630
eb4d412d
PE
2631 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2632
1658b401
PE
2633 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2634 concerns.
2635
2636 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2637
2638 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2639
9a2c6e05
PE
2640 * keyboard.c (syms_of_keyboard): Use the same style as later
2641 in this function when indexing through an array. This also
2642 works around GCC bug 48267.
2643
03d0a109
PE
2644 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2645
44f730c8
PE
2646 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2647
fe75f926
PE
2648 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2649 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2650
ffa8c828
PE
2651 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2652 This avoids undefined behavior on integer overflow, and is a bit
2653 more convenient anyway since it is compared to a size_t variable.
2654
c5101a77
PE
2655 Variadic C functions now count arguments with size_t, not int.
2656 This avoids an unnecessary limitation on 64-bit machines, which
2657 caused (substring ...) to crash on large vectors (Bug#8344).
2658 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2659 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2660 All variadic functions and their callers changed accordingly.
c5101a77
PE
2661 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2662 * data.c (arith_driver, float_arith_driver): Likewise.
2663 * editfns.c (general_insert_function): Likewise.
2664 * eval.c (struct backtrace.nargs, interactive_p)
2665 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2666 (funcall_lambda, mark_backtrace): Likewise.
2667 * fns.c (concat): Likewise.
2668 * frame.c (x_set_frame_parameters): Likewise.
2669 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2670 0 if not found, not -1. All callers changed.
2671
dd3f25f7
PE
2672 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2673 (stack_copy_size): Now size_t, not int.
2674 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2675
461c2ab9
JB
26762011-03-28 Juanma Barranquero <lekktu@gmail.com>
2677
2678 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2679 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2680 All callers changed.
2681
2682 * lisp.h (multibyte_char_to_unibyte):
2683 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2684 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2685 * character.h (CHAR_TO_BYTE8):
2686 * cmds.c (internal_self_insert):
2687 * editfns.c (general_insert_function):
2688 * keymap.c (push_key_description):
2689 * search.c (Freplace_match):
2690 * xdisp.c (message_dolog, set_message_1): All callers changed.
2691
f6d62986
SM
26922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2693
2694 * keyboard.c (safe_run_hook_funcall): New function.
2695 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2696 don't set the hook to nil, but remove the offending function instead.
2697 (Qcommand_hook_internal): Remove, unused.
2698 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2699 Vcommand_hook_internal.
2700
2701 * eval.c (enum run_hooks_condition): Remove.
2702 (funcall_nil, funcall_not): New functions.
2703 (run_hook_with_args): Call each function through a `funcall' argument.
2704 Remove `cond' argument, now redundant.
2705 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2706 (Frun_hook_with_args_until_failure): Adjust accordingly.
2707 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2708
1db5b1ad
JB
27092011-03-28 Juanma Barranquero <lekktu@gmail.com>
2710
2711 * dispextern.h (string_buffer_position): Remove declaration.
2712
2713 * print.c (strout): Remove parameter `multibyte', unused since
2714 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2715
2716 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2717 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2718 All callers changed.
2719
2720 * w32.c (_wsa_errlist): Use braces for struct initializers.
2721
2722 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2723 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2724 All callers changed.
2725 (string_buffer_position): Likewise. Also, make static (it's never
2726 used outside xdisp.c).
2727 (cursor_row_p): Remove parameter `w', unused since
2728 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2729 (decode_mode_spec): Remove parameter `precision', introduced during
2730 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2731 All callers changed.
2732
5ffb62aa
JD
27332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2734
2735 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2736
461c2ab9 27372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2738
2739 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2740 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2741 (ns_update_auto_hide_menu_bar): New functions.
2742 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2743 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2744 ns_constrain_all_frames.
2745 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2746 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2747
5c380ffb
JD
27482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2749
2750 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2751
9af30bdf
GM
27522011-03-27 Glenn Morris <rgm@gnu.org>
2753
2754 * syssignal.h: Replace RETSIGTYPE with void.
2755 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2756 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2757 Replace SIGTYPE with void everywhere.
2758 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2759 * s/template.h (SIGTYPE): Remove commented out definition.
2760
e2abce01
JB
27612011-03-26 Eli Zaretskii <eliz@gnu.org>
2762
2763 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2764 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2765
f868cd8a
JB
27662011-03-26 Juanma Barranquero <lekktu@gmail.com>
2767
59eb0929
JB
2768 * w32.c (read_unc_volume): Use parameter `henum', instead of
2769 global variable `wget_enum_handle'.
2770
2771 * keymap.c (describe_vector): Remove parameters `indices' and
2772 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2773 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2774
f868cd8a
JB
2775 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2776
2777 * keyboard.c (timer_check): Remove parameter `do_it_now',
2778 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2779 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2780 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2781
2782 * keyboard.c (read_char):
2783 * w32menu.c (w32_menu_display_help):
2784 * xmenu.c (show_help_event, menu_help_callback):
2785 Adjust calls to `show_help_echo'.
2786
2787 * gtkutil.c (xg_maybe_add_timer):
2788 * keyboard.c (readable_events):
2789 * process.c (wait_reading_process_output):
2790 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2791
2792 * insdel.c (adjust_markers_gap_motion):
2793 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2794 (gap_left, gap_right): Don't call it.
2795
2ecf6fdb
CY
27962011-03-25 Chong Yidong <cyd@stupidchicken.com>
2797
2798 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2799 incurred during fontification.
2800
6b1f9ba4
JB
28012011-03-25 Juanma Barranquero <lekktu@gmail.com>
2802
2803 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2804 (DEFVAR_PER_BUFFER): Don't pass it.
2805
2806 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2807 (scrolling_window): Don't pass it.
2808
0f4a96b5
JB
28092011-03-25 Juanma Barranquero <lekktu@gmail.com>
2810
2811 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2812
2813 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2814 and `suffix'.
2815 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2816 of variables specific to SELinux and computation of `encoded_absname'.
2817
2818 * image.c (XPutPixel): Remove unused variable `height'.
2819
2820 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2821
2822 * unexw32.c (get_section_info): Remove unused variable `section'.
2823
2824 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2825 (system_process_attributes): Remove unused variable `sess'.
2826 (sys_read): Remove unused variable `err'.
2827
2828 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2829 (w32_wnd_proc): Remove unused variable `isdead'.
2830 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2831 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2832 (x_create_tip_frame): Remove unused variable `tem'.
2833
2834 * w32inevt.c (w32_console_read_socket):
2835 Remove unused variable `no_events'.
2836
2837 * w32term.c (x_draw_composite_glyph_string_foreground):
2838 Remove unused variable `width'.
2839
1149507c
JB
28402011-03-24 Juanma Barranquero <lekktu@gmail.com>
2841
2842 * w32term.c (x_set_glyph_string_clipping):
2843 Don't pass uninitialized region to CombineRgn.
2844
9c88f339
JB
28452011-03-23 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2848 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2849 (Fx_close_connection): Remove unused variable `i'.
2850
2851 * w32font.c (w32font_draw): Return number of glyphs.
2852 (w32font_open_internal): Remove unused variable `i'.
2853 (w32font_driver): Add missing initializer.
2854
2855 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2856 (fill_in_menu): Remove unused variable `items_added'.
2857
2858 * w32term.c (last_mouse_press_frame): Remove static global variable.
2859 (w32_clip_to_row): Remove unused variable `f'.
2860 (x_delete_terminal): Remove unused variable `i'.
2861
2862 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2863 (NOTHING): Remove unused static global variable.
2864 (uniscribe_check_otf): Remove unused variable `table'.
2865 (uniscribe_font_driver): Add missing initializers.
2866
dee091a3
JD
28672011-03-23 Julien Danjou <julien@danjou.info>
2868
2869 * term.c (Fsuspend_tty, Fresume_tty):
2870 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2871 * window.c (temp_output_buffer_show):
2872 * insdel.c (signal_before_change):
2873 * frame.c (Fhandle_switch_frame):
2874 * fileio.c (Fdo_auto_save):
2875 * emacs.c (Fkill_emacs):
2876 * editfns.c (save_excursion_restore):
2877 * cmds.c (internal_self_insert):
2878 * callint.c (Fcall_interactively):
2879 * buffer.c (Fkill_all_local_variables):
2880 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2881 Use Frun_hooks.
0f4a96b5 2882 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2883 unconditionnaly since it does the check itself.
2884
2c520ab5 28852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2886
c9c49752
PE
2887 Fix more problems found by GCC 4.5.2's static checks.
2888
8abc3f12
PE
2889 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2890 the first time through the loop, since we know p0 < p1 then.
2891 This also avoids a gcc -Wstrict-overflow warning.
2892
a2d26660
PE
2893 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2894 leading to a memory leak, possible in functions like
2895 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2896 of objects (Bug#8318).
a2d26660 2897
916c72e9
PE
2898 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2899 that could (at least in theory) be that large.
2900
19ab8a18
PE
2901 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2902 This is less likely to overflow, and avoids undefined behavior if
2903 overflow does occur. All callers changed. Use strtoul to scan
2904 for the unsigned long integer.
b7cbbd6f
PE
2905 (pint2hrstr): Simplify and tune code slightly.
2906 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2907
f0641eff
PE
2908 * scroll.c (do_scrolling): Work around GCC bug 48228.
2909 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2910
7f650bb9
PE
2911 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2912 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2913 (validate_x_resource_name): Simplify count usage.
2914 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2915
37dd57d1
PE
2916 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2917 fail (Bug#8306).
81e56e61 2918
699979fc 2919 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2920
401bf9b4
PE
2921 * process.c (Fmake_network_process): Use socklen_t, not int,
2922 where POSIX says socklen_t is required in portable programs.
2923 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2924 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2925 (Fmake_network_process, server_accept_connection):
2926 (wait_reading_process_output, read_process_output):
2927 Likewise.
2928
b93aacde
PE
2929 * process.c: Rename or move locals to avoid shadowing.
2930 (list_processes_1, Fmake_network_process):
2931 (read_process_output_error_handler, exec_sentinel_error_handler):
2932 Rename or move locals.
4dc343ee 2933 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2934 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2935 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2936 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2937 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2938
af8a867c 2939 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2940 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2941 Include tparam.h instead, since it declares them.
af8a867c
PE
2942 * cm.h (PC): Remove extern decl; tparam.h now does this.
2943 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2944 * terminfo.c: Include tparam.h, to check interfaces.
2945 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2946 (tparam): Adjust signature to match interface in tparam.h;
2947 this removes some undefined behavior. Check that outstring and len
2948 are zero, which they always are with Emacs.
2949 * tparam.h (PC, BC, UP): New extern decls.
2950
0248044d 2951 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2952 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2953
8ff096c1 2954 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2955 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2956 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2957 (ftfont_list): Remove unused local.
49eaafba
PE
2958 (get_adstyle_property, ftfont_pattern_entity):
2959 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2960 Rename locals to avoid shadowing.
8ff096c1 2961
e2be39f6
PE
2962 * xfont.c (xfont_list_family): Mark var as initialized.
2963
c9735e30
PE
2964 * xml.c (make_dom): Now static.
2965
8f5201ae
PE
2966 * composite.c (composition_compute_stop_pos): Rename local to
2967 avoid shadowing.
b246f932
PE
2968 (composition_reseat_it): Remove unused locals.
2969 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2970 (composition_update_it): Mark var as initialized.
11b61122
PE
2971 (find_automatic_composition): Mark vars as initialized,
2972 with a FIXME (Bug#8290).
8f5201ae 2973
760fbc2c
PE
2974 character.h: Rename locals to avoid shadowing.
2975 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2976 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2977 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2978 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2979 to avoid shadowing.
2980
ff08eb85
PE
2981 * textprop.c (property_change_between_p): Remove; unused.
2982
fc7bf025
PE
2983 * intervals.c (interval_start_pos): Now static.
2984
235d7abc
PE
2985 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2986
44f230aa
SM
2987 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2988 Rename locals to avoid shadowing.
3e7d6594 2989
50060332
PE
2990 * sound.c (wav_play, au_play, Fplay_sound_internal):
2991 Fix pointer signedness.
d01f234b 2992 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2993 (wav_play): Initialize a variable to 0, to prevent undefined
2994 behavior (Bug#8278).
50060332 2995
c4fc4e30
PE
2996 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2997
918436ed
PE
2998 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2999
c939f91b
PE
3000 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3001 clobbering (Bug#8298).
b9c7f648
PE
3002 * sysdep.c (sys_subshell): Likewise.
3003 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3004
6bd8c144
PE
3005 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3006 This should get cleaned up, so that child_setup has the
3007 same signature on all platforms.
3008
7710357c 3009 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3010 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3011
c59da222
CY
30122011-03-22 Chong Yidong <cyd@stupidchicken.com>
3013
3014 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3015 not to be necessary, and produces flickering.
3016
66b87493
GM
30172011-03-20 Glenn Morris <rgm@gnu.org>
3018
3019 * config.in: Remove file.
3020
45b6f6d5
JB
30212011-03-20 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3024 are now in src/globals.h.
3025 (syms_of_minibuf): Remove spurious & from previous change.
3026
3ec03f7e
LL
30272011-03-20 Leo <sdl.web@gmail.com>
3028
3029 * minibuf.c (completing-read-function): New variable.
3030 (completing-read-default): Rename from completing-read.
3031 (completing-read): Call completing-read-function.
3032
b14e3e21
CY
30332011-03-19 Juanma Barranquero <lekktu@gmail.com>
3034
3035 * xfaces.c (Fx_load_color_file):
3036 Read color file from absolute filename (bug#8250).
3037
f2b726e6
JB
30382011-03-19 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * makefile.w32-in: Update dependencies.
3041
09f6ff02
EZ
30422011-03-17 Eli Zaretskii <eliz@gnu.org>
3043
3044 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3045
29a6015a
PE
30462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3047
a3a6c54e
PE
3048 Fix more problems found by GCC 4.5.2's static checks.
3049
b766f867
PE
3050 * process.c (make_serial_process_unwind, send_process_trap):
3051 (sigchld_handler): Now static.
3052
be02381c
PE
3053 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3054 That way, the code declares only the vars that it needs.
3055 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3056 * s/cygwin.h (PTY_ITERATION): Likewise.
3057 * s/darwin.h (PTY_ITERATION): Likewise.
3058 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3059
57048744
PE
3060 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3061 * process.c (allocate_pty): Don't declare stb unless it's needed.
3062
7914961c 3063 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3064 (CONSTANTLIM): Remove; unused.
3065 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3066 Define only if needed.
7914961c 3067
b3967b18
PE
3068 * unexelf.c (unexec): Name an expression,
3069 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3070 Use a different way to cause a compilation error if anyone uses
3071 n rather than nn, a way that does not involve shadowing.
73366a00 3072 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3073
29a6015a
PE
3074 * deps.mk (unexalpha.o): Remove; unused.
3075
43cfc33e 3076 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3077 * unexec.h: New file.
ce701a33
PE
3078 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3079 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3080 Depend on unexec.h.
3081 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3082 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3083 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3084 Change as necessary to match prototype in unexec.h.
ce701a33 3085
01f44d5a
PE
3086 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3087 shadowing.
4f63c6bb 3088 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3089
a6670b0b
PE
3090 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3091 Rename locals to avoid shadowing.
3092
cef2010d 3093 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3094 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3095
d4d7173a
PE
3096 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3097
f08b802a
PE
3098 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3099 warning when compiling print.c.
3100
3ddb0639
PE
3101 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3102 instead of using an uninitialized var.
5ad03b97 3103 (font_sort_entities): Mark var as initialized.
3ddb0639 3104
170a2692
PE
3105 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3106
e663c700
PE
3107 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3108 pointers to constants.
89bc529a 3109 (font_parse_fcname): Remove unused vars.
7b81e2d0 3110 (font_delete_unmatched): Now static.
ea838e10 3111 (font_get_spec): Remove; unused.
13a547c6
PE
3112 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3113 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3114 Rename or move locals to avoid shadowing.
e663c700 3115
2a80c887 3116 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3117 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3118
1384fa33 3119 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3120 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3121
8b2c52e9
PE
3122 * alloc.c (mark_backtrace): Move decl from here ...
3123 * lisp.h: ... to here, so that it can be checked.
3124
475545b5 3125 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3126 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3127 (lisp_indirect_variable): Name an expression,
3128 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3129 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3130
b1349114 3131 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3132 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3133 Use const pointer when appropriate.
b1349114 3134
a2928364
PE
3135 * lisp.h (get_system_name, get_operating_system_release):
3136 Move decls here, to check interfaces.
3137 * process.c (get_operating_system_release): Move decl to lisp.h.
3138 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3139 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3140 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3141 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3142 (Fformat_time_string, Fencode_time, Finsert_char):
3143 (Ftranslate_region_internal, Fformat):
3144 Rename or remove local vars to avoid shadowing.
9710023e 3145 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3146
a415e694
PE
3147 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3148 avoid shadowing.
3149
8ef4622d
PE
3150 * lisp.h (eassert): Check that the argument compiles, even if
3151 ENABLE_CHECKING is not defined.
3152
946f9a5b
PE
3153 * data.c (Findirect_variable): Name an expression, to avoid
3154 gcc -Wbad-function-cast warning.
112396d6 3155 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3156 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3157 (Fmake_variable_buffer_local, Fmake_local_variable):
3158 Mark variables as initialized.
52746918 3159 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3160
e5aab7e7 3161 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3162 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3163 Rename locals to avoid shadowing.
dff45157
PE
3164 (mark_stack): Move local variables into the #ifdef region where
3165 they're used.
7bc26fdb
PE
3166 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3167 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3168 needed otherwise.
3169 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3170 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3171 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3172
e5aab7e7
PE
3173 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3174 avoids undefined behavior in theory.
3175
4da60324
PE
3176 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3177
88043301
PE
3178 Use functions, not macros, for up- and down-casing (Bug#8254).
3179 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3180 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3181 to use the following functions instead of these macros.
3182 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3183 EMACS_INT, since callers assume the returned value fits in int.
3184 (upcase1): Likewise, for UPCASE_TABLE.
3185 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3186 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3187 the race-condition problem in the old DOWNCASE.
88043301 3188
19ed5445
PE
3189 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3190 Rename locals to avoid shadowing.
3191 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3192 (regex_compile, re_search_2, re_match_2_internal):
3193 Remove unused local vars.
952db0d7
PE
3194 (FREE_VAR): Rewrite so as not to use empty "else",
3195 which gcc can warn about.
da053e48 3196 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3197 (RETALLOC_IF): Define only if needed.
3198 (WORDCHAR_P): Likewise. This one is never needed, but is used
3199 only in a comment talking about a compiler bug, so put inside
3200 the #if 0 of that comment.
3201 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3202 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3203 Remove; unused.
19ed5445 3204
1f3561e4 3205 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3206 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3207 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3208
ded6f8f7
PE
3209 * search.c (simple_search): Remove unused var.
3210
dbd37a95
PE
3211 * dired.c (compile_pattern): Move decl from here ...
3212 * lisp.h: ... to here, so that it can be checked.
3213 (struct re_registers): New forward decl.
3214
7e47afad
PE
3215 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3216
85f24f61
PE
3217 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3218 All uses changed.
3219 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3220 Rename locals to avoid shadowing.
5671df8f 3221 (Fvertical_motion): Mark locals as initialized.
85f24f61 3222
181aa2be 3223 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3224 (casify_region): Mark local as initialized.
181aa2be 3225
930d429c
PE
3226 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3227
7082eac6
PE
3228 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3229 New macros, so that the caller can use some names other than
3230 gcpro1, gcpro2, etc.
3231 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3232 of the new macros.
3233 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3234 argument, for consistency with GCPRO2_VAR, etc: it is now the
3235 prefix of the variable, not the variable itself. All uses
3236 changed.
38b2c076
PE
3237 * dired.c (directory_files_internal, file_name_completion):
3238 Rename locals to avoid shadowing.
3239
15206ed9
PE
3240 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3241 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3242 dired.c's scmp function, had undefined behavior.
3243 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3244 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3245 * buffer.h: ... to here, because these macros use current_buffer,
3246 and the new implementation with inline functions needs to have
3247 current_buffer in scope now, rather than later when the macros
3248 are used.
3249 (downcase, upcase1): New static inline functions.
3250 (DOWNCASE, UPCASE1): Reimplement using these functions.
3251 This avoids undefined behavior in expressions like
3252 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3253 from race conditions in accessing the global variables
3254 case_temp1 and case_temp2.
3255 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3256 * lisp.h (case_temp1, case_temp2): Remove their decls.
3257 * character.h (ASCII_CHAR_P): Move from here ...
3258 * lisp.h: ... to here, so that the inline functions mentioned
3259 above can use them.
3260
4a6bea26
PE
3261 * dired.c (directory_files_internal_unwind): Now static.
3262
f14b7e14
PE
3263 * fileio.c (file_name_as_directory, directory_file_name):
3264 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3265 Now static.
2893f146
PE
3266 (file_name_as_directory): Use const pointers when appropriate.
3267 (Fexpand_file_name): Likewise. In particular, newdir might
3268 point at constant storage, so make it a const pointer.
fd4ead52 3269 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3270 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3271 signedness issues.
f839df0c
PE
3272 (Fset_file_times, Finsert_file_contents, auto_save_error):
3273 Rename locals to avoid shadowing.
f14b7e14 3274
5716756e 3275 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3276 (Ftry_completion, Fall_completions): Rename or remove locals
3277 to avoid shadowing.
5716756e 3278
b4c3046a
PE
3279 * marker.c (bytepos_to_charpos): Remove; unused.
3280
b45db522
PE
3281 * lisp.h (verify_bytepos, count_markers): New decls,
3282 so that gcc does not warn that these functions aren't declared.
3283
85876d07
PE
3284 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3285 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3286 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3287 (copy_text): Remove unused local var.
85876d07 3288
03d78a21 3289 * filelock.c (within_one_second): Now static.
b3dd38ab 3290 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3291
5df8f01b
PE
3292 * buffer.c (fix_overlays_before): Mark locals as initialized.
3293 (fix_start_end_in_overlays): Likewise. This function should be
3294 simplified by using pointers-to-pointers, but that's a different
3295 matter.
b1d876f1 3296 (switch_to_buffer_1): Now static.
8f54f30a
PE
3297 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3298 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3299
a70072c9 3300 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3301 Fix pointer signedness issue.
edced198
PE
3302 (sys_subshell): Mark local as volatile if checking for lint,
3303 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3304 (MAXPATHLEN): Define only if needed.
a70072c9 3305
a0977c44
PE
3306 * process.c (serial_open, serial_configure): Move decls from here ...
3307 * systty.h: ... to here, so that they can be checked.
3308
a884fdcc
PE
3309 * fns.c (get_random, seed_random): Move extern decls from here ...
3310 * lisp.h: ... to here, so that they can be checked.
3311
604efe86 3312 * sysdep.c (reset_io): Now static.
b8950c94 3313 (wait_for_termination_signal): Remove; unused.
604efe86 3314
38fc62d9
PE
3315 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3316 (copy_keymap_item, append_key, push_text_char_description):
3317 Now static.
1004a21a 3318 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3319 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3320 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3321 (describe_map_tree):
3322 Rename locals to avoid shadowing.
38fc62d9 3323
2f2650da
PE
3324 * keyboard.c: Declare functions static if they are not used elsewhere.
3325 (echo_char, echo_dash, cmd_error, top_level_2):
3326 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3327 (read_char, kbd_buffer_get_event, make_lispy_position):
3328 (make_lispy_event, make_lispy_movement, apply_modifiers):
3329 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3330 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3331 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3332 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3333 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3334
a053e86c 3335 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3336 (mark_kboards): Move decl here ...
3337 * alloc.c (mark_kboards): ... from here.
a053e86c 3338
4752793e
PE
3339 * lisp.h (force_auto_save_soon): New decl.
3340
74f10ca7 3341 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3342 (DEFINE_DUMMY_FUNCTION): New macro.
3343 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3344 Use it.
c03cd23f
PE
3345 (main): Add casts to avoid warnings
3346 if GCC considers string literals to be constants.
74f10ca7 3347
022e70d4
PE
3348 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3349
59d6fe83
PE
3350 * dbusbind.c: Pointer signedness fixes.
3351 (xd_signature, xd_append_arg, xd_initialize):
3352 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3353 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3354 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3355 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3356
78320123
PE
3357 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3358 if GCC considers string literals to be constants.
49cebcca 3359 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3360
35ac2a97
SM
33612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3362
fb103ca9
SM
3363 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3364 (print_preprocess, print_object): New macro to fix last change.
3365
35ac2a97
SM
3366 * print.c (print_preprocess): Don't forget font objects.
3367
62973b41
JB
33682011-03-16 Juanma Barranquero <lekktu@gmail.com>
3369
3370 * emacs.c (USAGE3): Doc fixes.
3371
0e48bb22
AS
33722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3373
3374 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3375 structure.
3376
7684e57b
JB
33772011-03-14 Juanma Barranquero <lekktu@gmail.com>
3378
3379 * lisp.h (VWindow_system, Qfile_name_history):
3380 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3381 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3382 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3383
3384 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3385 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3386
3387 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3388 * w32console.c (detect_input_pending, read_input_pending)
3389 (encode_terminal_code):
3390 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3391 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3392 (w32_system_caret_y, Qfile_name_history):
3393 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3394 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3395 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3396 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3397 * w32proc.c (Qlocal, report_file_error):
3398 * w32term.c (Vwindow_system, updating_frame):
3399 * w32uniscribe.c (initialized, uniscribe_font_driver):
3400 Remove unneeded extern declarations.
3401
2aa46d6c
CY
34022011-03-14 Chong Yidong <cyd@stupidchicken.com>
3403
c96bbc66 3404 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3405
cffc6f3b
CY
34062011-03-13 Chong Yidong <cyd@stupidchicken.com>
3407
3408 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3409 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3410 These macros can no longer be used for assignment.
3411
44f230aa
SM
3412 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3413 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3414 (record_buffer_markers, fetch_buffer_markers): New functions for
3415 recording and fetching special buffer markers.
3416 (set_buffer_internal_1, set_buffer_temp): Use them.
3417
3418 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3419
3420 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3421
3422 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3423 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3424
3425 * xdisp.c (hscroll_window_tree):
3426 (reconsider_clip_changes): Use PT instead of BUF_PT.
3427
d251f04b
EZ
34282011-03-13 Eli Zaretskii <eliz@gnu.org>
3429
3430 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3431 $(EMACS_ROOT)/lib/intprops.h.
3432
f0c77cd1
PE
34332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3434
3eca4629
PE
3435 Fix more problems found by GCC 4.5.2's static checks.
3436
7c86ee98
PE
3437 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3438 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3439 (xg_free_frame_widgets): Make it clear that a local variable is
3440 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3441 (gdk_window_get_screen): Make it clear that this macro is needed
3442 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3443 (int_gtk_range_get_value): New function, which avoids a diagnostic
3444 from gcc -Wbad-function-cast.
3445 (xg_set_toolkit_scroll_bar_thumb): Use it.
3446 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3447 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3448 (get_utf8_string, xg_get_file_with_chooser):
3449 Rename locals to avoid shadowing.
3450 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3451
41729b81
PE
3452 * xgselect.c (xg_select): Remove unused var.
3453
f0c77cd1
PE
3454 * image.c (four_corners_best): Mark locals as initialized.
3455 (gif_load): Initialize transparent_p to zero (Bug#8238).
3456 Mark another local as initialized.
ec6cf4c6 3457 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3458
ce0ad53d 3459 * image.c (clear_image_cache): Now static.
d5d5a617 3460 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3461 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3462 (x_edge_detection): Remove unnecessary cast that
3463 gcc -Wbad-function-cast diagnoses.
2037898d 3464 (gif_load): Fix pointer signedness.
6ae141d6
PE
3465 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3466 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3467
33383987 34682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3469
d32df629
PE
3470 Improve quality of tests for time stamp overflow.
3471 For example, without this patch (encode-time 0 0 0 1 1
3472 1152921504606846976) returns the obviously-bogus value (-948597
3473 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3474 reports time overflow. See
3475 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3476 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3477 * editfns.c: Include limits.h and intprops.h.
3478 (TIME_T_MIN, TIME_T_MAX): New macros.
3479 (time_overflow): Move earlier, to before first use.
3480 (hi_time, lo_time): New functions, for an accurate test for
3481 out-of-range times.
3482 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3483 (Fget_internal_run_time): Don't assume time_t fits in int.
3484 (make_time): Use list2 instead of Fcons twice.
3485 (Fdecode_time): More accurate test for out-of-range times.
3486 (check_tm_member): New function.
3487 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3488 (lisp_time_argument): Don't rely on undefined left-shift and
3489 right-shift behavior when checking for time stamp overflow.
8be6f318 3490
fe31d94c
PE
3491 * editfns.c (time_overflow): New function, refactoring common code.
3492 (Fformat_time_string, Fdecode_time, Fencode_time):
3493 (Fcurrent_time_string): Use it.
3494
8be6f318
PE
3495 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3496 * dired.c (make_time): Move to ...
3497 * editfns.c (make_time): ... here.
3498 * systime.h: Note the move.
3499
09d9db2c 35002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3501
126bc0dc
YM
3502 * fringe.c (update_window_fringes): Remove unused variables.
3503
c47cbdfd
YM
3504 * unexmacosx.c (copy_data_segment): Also copy __got section.
3505 (Bug#8223)
3506
7ac80be9
EZ
35072011-03-12 Eli Zaretskii <eliz@gnu.org>
3508
c96bbc66 3509 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3510 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3511 Constify `char *' arguments and their references according to
3512 prototypes in tparam.h.
3513
ecb0f94d 3514 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3515
7ac80be9
EZ
3516 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3517 Adapt all references accordingly.
3518
3519 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3520
ef1fd07e
TT
35212011-03-11 Tom Tromey <tromey@redhat.com>
3522
3523 * buffer.c (syms_of_buffer): Remove obsolete comment.
3524
7ef4b50c
EZ
35252011-03-11 Eli Zaretskii <eliz@gnu.org>
3526
3527 * termhooks.h (encode_terminal_code): Declare prototype.
3528
3529 * msdos.c (encode_terminal_code): Don't declare prototype.
3530
3531 * term.c (encode_terminal_code): Now external again, used by
3532 w32console.c and msdos.c.
3533
44f230aa
SM
3534 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3535 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3536
4b1ec863 35372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3538
1714f52b 3539 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3540
4b1ec863
PE
3541 * fringe.c (update_window_fringes): Mark locals as initialized
3542 (Bug#8227).
3543 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3544
524c7aa6
PE
3545 * alloc.c (mark_fringe_data): Move decl from here ...
3546 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3547 to check its interface.
3548 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3549
a5c0af81 3550 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3551 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3552 (fontset_font): Mark local as initialized.
a9a06e0b 3553 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3554
b4716021
PE
3555 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3556
811e9bac 3557 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3558 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3559 (x_own_selection, Fx_disown_selection_internal): Rename locals
3560 to avoid shadowing.
3561 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3562
7e3ab302
PE
3563 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3564 so that the caller can use some name other than gcpro1.
3565 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3566 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3567 (Fx_backspace_delete_keys_p):
3568 Use them to avoid shadowing, and rename vars to avoid shadowing.
3569 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3570 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3571 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3572 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3573 Remove unused locals.
7e3ab302
PE
3574 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3575 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3576 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3577 macros.
f78faa98 3578
e2b13473
PE
3579 * xterm.h (x_mouse_leave): New decl.
3580
77f23912
PE
3581 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3582 Remove unused functions.
cdf4ba58
PE
3583 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3584 (x_calc_absolute_position): Now static.
7411c686 3585 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3586 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3587 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3588 unless they are used.
38d0b34a
PE
3589 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3590 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3591 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3592 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3593 (x_error_catcher, x_connection_closed, x_error_handler):
3594 (x_error_quitter, xembed_send_message, x_iconify_frame):
3595 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3596 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3597 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3598
44f230aa
SM
3599 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3600 Rename or move locals to avoid shadowing.
6b463e58 3601 (tty_defined_color, merge_face_heights): Now static.
5967d051 3602 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3603 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3604 does not deduce is never used uninitialized.
73719eba
PE
3605 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3606 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3607
426994c3 3608 * terminal.c (store_terminal_param): Now static.
5489860b 3609
032f1620 3610 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3611 (set_frame_menubar): Remove unused local.
d4323972 3612 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3613 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3614 since they might point to immutable storage.
281585b0
PE
3615 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3616 since it's unused otherwise.
032f1620 3617
367c19e5 3618 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3619 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3620 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3621 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3622 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3623 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3624 does not deduce are never used uninitialized.
70739cbe 3625
07b48fa9
PE
3626 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3627
8868a238 3628 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3629 * window.c (window_loop, size_window):
3630 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3631
7e5cf297 3632 * window.c (display_buffer): Now static.
d6550a9f
PE
3633 (size_window): Mark variables that gcc -Wuninitialized
3634 does not deduce are never used uninitialized.
a586633d
PE
3635 * window.h (check_all_windows): New decl, to forestall
3636 gcc -Wmissing-prototypes diagnostic.
5b555da1 3637 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3638
f6095868
PE
3639 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3640 shadowing.
3641 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3642 Include <limits.h>.
3643 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3644 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3645 (load_charset_map): Mark variables that gcc -Wuninitialized
3646 does not deduce are never used uninitialized.
53df7c11 3647 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3648
f38b440c
PE
3649 * coding.c (coding_set_source, coding_set_destination):
3650 Use "else { /* comment */ }" rather than "else /* comment */;"
3651 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3652 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3653 a block, when the outer 'i' will do.
3654 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3655 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3656 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3657 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3658 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3659 Rename locals to avoid shadowing.
3660 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3661 * coding.c (emacs_mule_char, encode_invocation_designation):
3662 Now static, since they're not used elsewhere.
413bb2db 3663 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3664 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3665 (decode_coding_emacs_mule): Mark variables that gcc
3666 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3667 (detect_coding_iso_2022): Initialize a local variable that might
3668 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3669 this initialization is needed. (Bug#8211)
5f58e762
PE
3670 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3671 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3672 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3673 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3674 Remove unused macros.
f38b440c 3675
232b38b9 3676 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3677 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3678 * character.c (string_count_byte8): Likewise.
232b38b9 3679
fb90da1b
PE
3680 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3681 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3682
fb93dbc2
PE
3683 * chartab.c (copy_sub_char_table): Now static, since it's not used
3684 elsewhere.
5c156ace
PE
3685 (sub_char_table_ref_and_range, char_table_ref_and_range):
3686 Rename locals to avoid shadowing.
bbcd0949 3687 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3688
7d3b3862 3689 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3690 (BIDI_BOB): Remove unused macro.
7d3b3862 3691
6be7d3da
PE
3692 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3693 deduce are never used uninitialized.
c2ed9c8b 3694 * term.c (encode_terminal_code): Likewise.
6be7d3da 3695
75f8807f 3696 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3697
50938595
PE
3698 * tparam.h: New file.
3699 * term.c, tparam.h: Include it.
3700 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3701 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3702 Move these decls to tparam.h, and make them agree with what
3703 is actually in tparam.c. The previous trick of using incompatible
3704 decls in different modules does not conform to the C standard.
3705 All callers of tparam changed to use tparam's actual API.
3706 * tparam.c (tparam1, tparam, tgoto):
3707 Use const pointers where appropriate.
3708
fbceeba2
PE
3709 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3710 * cm.h (struct cm): Likewise.
3711 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3712 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3713 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3714 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3715 (turn_on_face, init_tty): Likewise.
3716 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3717
7f3f1250
PE
3718 * term.c (term_mouse_position): Rename local to avoid shadowing.
3719
e6ca6543
PE
3720 * alloc.c (mark_ttys): Move decl from here ...
3721 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3722
c40f8d15
AS
37232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3724
3725 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3726
cfe0661d
JB
37272011-03-09 Juanma Barranquero <lekktu@gmail.com>
3728
3729 * search.c (compile_pattern_1): Remove argument regp, unused since
3730 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3731 (compile_pattern): Don't pass it.
3732
0afb4571
J
37332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3736 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3737 for ! HAVE_GTK3.
3738 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3739
3740 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3741
3742 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3743 gdk_window_get_screen, gdk_window_get_geometry,
3744 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3745 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3746 (xg_get_pixbuf_from_pixmap): New function.
3747 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3748 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3749 Call xg_get_pixbuf_from_pixmap instead of
3750 gdk_pixbuf_get_from_drawable.
3751 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3752 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3753 (xg_check_special_colors): Use GtkStyleContext and its functions
3754 for HAVE_GTK3.
3755 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3756 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3757 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3758 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3759 Call gtk_widget_get_preferred_size.
0afb4571
J
3760 (xg_frame_resized): gdk_window_get_geometry only takes 5
3761 parameters.
44f230aa
SM
3762 (xg_win_to_widget, xg_event_is_for_menubar):
3763 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3764 (xg_set_widget_bg): New function.
3765 (delete_cb): New function.
895009e1 3766 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3767 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3768 (xg_set_background_color): Call xg_set_widget_bg.
3769 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3770 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3771 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3772 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3773 if ! HAVE_GTK3.
3774 (update_frame_tool_bar): Call gtk_widget_hide.
3775 (xg_initialize): Use GDK_KEY_g.
3776
3777 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3778 if ! HAVE_GTK3
3779 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3780
3781 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3782 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3783 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3784
1c2cc4ef
JB
37852011-03-08 Juanma Barranquero <lekktu@gmail.com>
3786
3787 * w32xfns.c (select_palette): Check success of RealizePalette against
3788 GDI_ERROR, not zero.
3789
33383987 3790See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3791
3792;; Local Variables:
3793;; coding: utf-8
aac0c6e3
MR
3794;; End:
3795
33383987 3796 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3797
3798 This file is part of GNU Emacs.
3799
3800 GNU Emacs is free software: you can redistribute it and/or modify
3801 it under the terms of the GNU General Public License as published by
3802 the Free Software Foundation, either version 3 of the License, or
3803 (at your option) any later version.
3804
3805 GNU Emacs is distributed in the hope that it will be useful,
3806 but WITHOUT ANY WARRANTY; without even the implied warranty of
3807 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3808 GNU General Public License for more details.
3809
3810 You should have received a copy of the GNU General Public License
3811 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.