* xfns.c (USG): Use the kludged USG macro, to pacify gcc.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
436c16df 3 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6
92bb796d 7 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8 (x_term_init): Remove local to avoid shadowing.
92bb796d 9
764430a3 10 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11
12 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14
4170f62f 152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 16
71b41406
PE
17 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
18
9587a89d
PE
19 emacs_write: Accept and return EMACS_INT for sizes.
20 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
21 et seq.
22 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
23 Accept and return EMACS_INT.
24 (emacs_gnutls_write): Return the number of bytes written on
25 partial writes.
26 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
27 (emacs_read, emacs_write): Remove check for negative size, as the
28 Emacs source code has been audited now.
9587a89d
PE
29 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
30 (emacs_read, emacs_write): Use it.
273a5f82
PE
31 * process.c (send_process): Adjust to the new signatures of
32 emacs_write and emacs_gnutls_write. Do not attempt to store
33 a byte offset into an 'int'; it might overflow.
9587a89d 34 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 35
3e047f51
PE
36 * sound.c: Don't assume sizes fit in 'int'.
37 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 38 Return EMACS_INT, not int.
3e047f51 39 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
40 Accept EMACS_INT, not int.
41 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
42 record read return values.
43
cc39a9db
BK
442011-04-15 Ben Key <bkey76@gmail.com>
45
46 * keyboard.c (Qundefined): Don't declare static since it is
47 used in nsfns.m.
48 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
49 declare static since they are used in nsfont.m.
50
6c60eb9f
SM
512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
52
53 * process.c (Qprocessp): Don't declare static.
54 * lisp.h (Qprocessp): Declare again.
55
7990b61a
JB
562011-04-15 Juanma Barranquero <lekktu@gmail.com>
57
58 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
59
5d4cb038
PE
602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
61
8bd7b830 62 Improve C-level modularity by making more things 'static'.
cd64ea1d 63
e3b27b31
PE
64 Don't publish debugger-only interfaces to other modules.
65 * lisp.h (safe_debug_print, debug_output_compilation_hack):
66 (verify_bytepos, count_markers): Move decls to the only modules
67 that need them.
68 * region-cache.h (pp_cache): Likewise.
69 * window.h (check_all_windows): Likewise.
70 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
71
5d4cb038
PE
72 * sysdep.c (croak): Now static, if
73 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
74 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
75
76 * alloc.c (refill_memory_reserve): Now static if
77 !defined REL_ALLOC || defined SYSTEM_MALLOC.
78 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 79
e87b6180
PE
80 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
81 Define only if USE_LUCID.
82
ac64929e
PE
83 * xrdb.c (x_customization_string, x_rm_string): Now static.
84
6f37259d
PE
85 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
86 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
87
1683e3ab
PE
88 * xdisp.c (draw_row_with_mouse_face): Now static.
89 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
90
de9c2632
PE
91 * window.h (check_all_windows): Mark externally visible.
92
2b96acb7
PE
93 * window.c (window_deletion_count): Now static.
94
95 * undo.c: Make symbols static if they're not exported.
96 (last_undo_buffer, last_boundary_position, pending_boundary):
97 Now static.
98
50436f33
PE
99 * textprop.c (interval_insert_behind_hooks): Now static.
100 (interval_insert_in_front_hooks): Likewise.
101
64520e5c
PE
102 * term.c: Make symbols static if they're not exported.
103 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
104 (max_frame_lines, tty_set_terminal_modes):
105 (tty_reset_terminal_modes, tty_turn_off_highlight):
106 (get_tty_terminal): Now static.
107 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
108 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 109 HAVE_WINDOW_SYSTEM.
64520e5c
PE
110 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
111 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
112
1fa53021
PE
113 * sysdep.c: Make symbols static if they're not exported.
114 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
115 Now static.
116 (sigprocmask_set, full_mask): Remove; unused.
117 (wait_debugging): Mark as visible.
118 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
119 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
120
d4b43b22
PE
121 * syntax.c (syntax_temp): Define only if !__GNUC__.
122
b7c513d0
PE
123 * sound.c (current_sound_device, current_sound): Now static.
124
989b29ad
PE
125 * search.c (searchbufs, searchbuf_head): Now static.
126
13a55a78
PE
127 * scroll.c (scroll_cost): Remove; unused.
128 * dispextern.h (scroll_cost): Remove decl.
129
de68a1fc
PE
130 * region-cache.h (pp_cache): Mark as externally visible.
131
40ccffa6
PE
132 * process.c: Make symbols static if they're not exported.
133 (process_tick, update_tick, create_process, chan_process):
134 (Vprocess_alist, proc_buffered_char, datagram_access):
135 (fd_callback_data, send_process_frame, process_sent_to): Now static.
136 (deactivate_process): Mark defn as static, as well as decl.
137 * lisp.h (create_process): Remove decl.
138 * process.h (chan_process, Vprocess_alist): Remove decls.
139
ad64fc97
PE
140 * print.c: Make symbols static if they're not exported.
141 (print_depth, new_backquote_output, being_printed, print_buffer):
142 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
143 (print_interval, print_number_index, initial_stderr_stream):
144 Now static.
145 * lisp.h (Fprinc): Remove decl.
146 (debug_output_compilation_hack): Mark as externally visible.
147
adddb265
PE
148 * sysdep.c (croak): Move decl from here to syssignal.h.
149 * syssignal.h (croak): Put it here, so the API can be checked when
150 'croak' is called from dissociate_if_controlling_tty.
151
1717ede2
PE
152 * minibuf.c: Make symbols static if they're not exported.
153 (minibuf_save_list, choose_minibuf_frame): Now static.
154 * lisp.h (choose_minibuf_frame): Remove decl.
155
fa5fb2bc
PE
156 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
157
1e3890d1
PE
158 * lread.c: Make symbols static if they're not exported.
159 (read_objects, initial_obarray, oblookup_last_bucket_number):
160 Now static.
161 (make_symbol): Remove; unused.
162 * lisp.h (initial_obarray, make_symbol): Remove decls.
163
8a1414fa
PE
164 * keyboard.c: Make symbols static if they're not exported.
165 (single_kboard, recent_keys_index, total_keys, recent_keys):
166 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
167 (this_single_command_key_start, echoing, last_auto_save):
168 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
169 (command_loop, echo_now, keyboard_init_hook, help_char_p):
170 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
171 (Vlispy_mouse_stem, double_click_count):
172 Now static.
173 (force_auto_save_soon): Define only if SIGDANGER.
174 (ignore_mouse_drag_p): Now static if
175 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
176 (print_help): Remove; unused.
177 (stop_character, last_timer_event): Mark as externally visible.
178 * keyboard.h (ignore_mouse_drag_p): Declare only if
179 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
180 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
181 * lisp.h (echoing): Remove decl.
182 (force_auto_save_soon): Declare only if SIGDANGER.
183 * xdisp.c (redisplay_window): Simplify code, to make it more
184 obvious that ignore_mouse_drag_p is not accessed if !defined
185 USE_GTK && !defined HAVE_NS.
186
93ea6e8f
PE
187 * intervals.c: Make symbols static if they're not exported.
188 (merge_properties_sticky, merge_interval_right, delete_interval):
189 Now static.
190 * intervals.h (merge_interval_right, delete_interval): Remove decls.
191
77382fcc
PE
192 * insdel.c: Make symbols static if they're not exported.
193 However, leave prepare_to_modify_buffer alone. It's never
194 called from outside this function, but that appears to be a bug.
195 (combine_after_change_list, combine_after_change_buffer):
4889fc82 196 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
197 (adjust_after_replace_noundo): Remove; unused.
198 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 199 (signal_before_change): Remove decls.
77382fcc 200
9306c32e
PE
201 * indent.c (val_compute_motion, val_vmotion): Now static.
202
cd44d2eb
PE
203 * image.c: Make symbols static if they're not exported.
204 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
205 if USE_GTK.
206 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
207 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
208
ad9a7a06
PE
209 * fringe.c (standard_bitmaps): Now static.
210 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
211
81626931
PE
212 * frame.c: Make symbols static if they're not exported.
213 (x_report_frame_params, make_terminal_frame): Now static.
214 (get_frame_param): Now static, unless HAVE_NS.
215 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
216 (x_get_resource_string): Remove; not used.
217 * frame.h (make_terminal_frame, x_report_frame_params):
218 (x_get_resource_string); Remove decls.
219 (x_fullscreen_adjust): Declare only if WINDOWSNT.
220 * lisp.h (get_frame_param): Declare only if HAVE_NS.
221
239f9db9
PE
222 * font.c, fontset.c: Make symbols static if they're not exported.
223 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
224 (FACE_SUITABLE_FOR_CHAR_P): Use it.
225 * font.c (font_close_object): Now static.
226 * font.h (font_close_object): Remove.
227 * fontset.c (FONTSET_OBJLIST): Remove.
228 (free_realized_fontset) #if-0 the body, which does nothing.
229 (face_suitable_for_char_p): #if-0, as it's never called.
230 * fontset.h (face_suitable_for_char_p): Remove decl.
231 * xfaces.c (face_at_string_position): Use
232 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
233 since 0 is always ASCII.
234
dfcf3579
PE
235 * fns.c (weak_hash_tables): Now static.
236
5045092b
PE
237 * fileio.c: Make symbols static if they're not exported.
238 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
239 (Vwrite_region_annotation_buffers): Now static.
240
57a96f5c
PE
241 * eval.c: Make symbols static if they're not exported.
242 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
243 * lisp.h (backtrace_list): Remove decl.
244
35f08c38
PE
245 * emacs.c: Make symbols static if they're not exported.
246 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
247 (fatal_error_code, fatal_error_signal_hook, standard_args):
248 Now static.
249 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
250 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
251 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
252 * lisp.h (fatal_error_signal_hook): Remove decl.
253 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
254
f44bd759
PE
255 * editfns.c: Move a (normally-unused) function to its only use.
256 * editfns.c, lisp.h (get_operating_system_release): Remove.
257 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
258 worth the hassle of breaking this out.
259
b532497d
PE
260 * xterm.c: Make symbols static if they're not exported.
261 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
262 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
263 (x_destroy_window, x_delete_display):
264 Now static.
265 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
266 (x_mouse_leave): Remove; unused.
267 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
268 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
269 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
270 Remove decls.
271 (x_mouse_leave): Declare only if WINDOWSNT.
272 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
273 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
274 USE_X_TOOLKIT.
275
1675728f
PE
276 * ftxfont.c: Make symbols static if they're not exported.
277 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
278 HAVE_FREETYPE.
279 * font.h (ftxfont_driver): Likewise.
280
e4cebfca
PE
281 * xfns.c: Make symbols static if they're not exported.
282 (x_last_font_name, x_display_info_for_name):
283 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
284 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
285 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
286 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
287 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
288 (last_show_tip_args): Now static.
289 (xic_defaut_fontset, xic_create_fontsetname): Define only if
290 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
291 (x_screen_planes): Remove; unused.
292 * dispextern.h (x_screen_planes): Remove decl.
293
5bf46f05
PE
294 * dispnew.c: Make symbols static if they're not exported.
295 * dispextern.h (redraw_garbaged_frames, scrolling):
296 (increment_row_positions): Remove.
297 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
298 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
299 Now static.
300 (redraw_garbaged_frames): Remove; unused.
301
435f4c28
PE
302 * xfaces.c: Make symbols static if they're not exported.
303 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
304 Remove decls.
305 * xterm.h (defined_color): Remove decls.
306 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
307 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
308 (menu_face_changed_default, defined_color, free_realized_face):
309 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
310 (ascii_face_of_lisp_face): Remove; unused.
311
8524aef3
PE
312 * xdisp.c: Make symbols static if they're not exported.
313 * dispextern.h (scratch_glyph_row, window_box_edges):
314 (glyph_to_pixel_coords, set_cursor_from_row):
315 (get_next_display_element, set_iterator_to_next):
316 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
317 (show_mouse_face): Remove decls
318 * frame.h (message_buf_print): Likewise.
319 * lisp.h (pop_message, set_message, check_point_in_composition):
320 Likewise.
321 * xterm.h (set_vertical_scroll_bar): Likewise.
322 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
323 (message_buf_print, scratch_glyph_row, displayed_buffer):
324 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
325 (get_next_display_element, show_mouse_face, window_box_edges):
326 (frame_to_window_pixel_xy, check_point_in_composition):
327 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
328 (glyph_to_pixel_coords): Remove; unused.
329
16390cd2
PE
330 * dired.c (file_name_completion): Now static.
331
332 * dbusbind.c (xd_in_read_queued_messages): Now static.
333
a25f4dfa
PE
334 * lisp.h (circular_list_error, FOREACH): Remove; unused.
335 * data.c (circular_list_error): Remove.
336
14a9c8df
PE
337 * commands.h (last_point_position, last_point_position_buffer):
338 (last_point_position_window): Remove decls.
339 * keyboard.c: Make these variables static.
340
74ab6df5
PE
341 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
342 decls.
343 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
344 (iso_code_class, detect_coding, code_convert_region): Now static.
345 (encode_coding_gap): Remove; unused.
346
38dfbee1
PE
347 * chartab.c (chartab_chars, chartab_bits): Now static.
348
a2cb4e63
PE
349 * charset.h (charset_iso_8859_1): Remove decl.
350 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
351 Now static.
352
127198fd
PE
353 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
354 * ccl.c (Vccl_program_table): Now static.
355 (check_ccl_update): Remove; unused.
356
d85b608f
PE
357 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
358 * category.h: ... from here.
359 * category.c (check_category_table, set_category_set): Now static.
360
31cd66f3
PE
361 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
362 * lisp.h: Remove these decls.
363
c358e587
PE
364 * buffer.c (buffer_count): Remove unused var.
365
e78aecca
PE
366 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
367 so that it's not optimized away.
368 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
369 * dispextern.h (bidi_dump_cached_states): Remove, since it's
370 exported only to the debugger.
371
e192d7d3
PE
372 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
373 * atimer.h (run_all_atimers): Removed; not exported.
374
92470028
PE
375 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
376 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
377 was inaccessible from Lisp.
378 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
379 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
380
244ed907
PE
381 alloc.c: Import and export fewer symbols, and remove unused items.
382 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
383 is defined.
384 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
385 it's not optimized away by whole-program optimization.
386 (message_enable_multibyte, free_misc): Remove.
387 (catchlist, handlerlist, mark_backtrace):
388 Declare only if BYTE_MARK_STACK.
389 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
390 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
391 (message_enable_multibyte): Remove decl.
392 (free_misc, interval_free_list, float_block, float_block_index):
393 (n_float_blocks, float_free_list, cons_block, cons_block_index):
394 (cons_free_list, last_marked_index):
395 Now static.
396 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
397 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
398 (mark_backtrace): Define only if BYTE_MARK_STACK.
399 * xdisp.c (message_enable_multibyte): Now static.
400
955cbe7b
PE
401 Declare Lisp_Object Q* variables to be 'static' if not exproted.
402 This makes it easier for human readers (and static analyzers)
403 to see whether these variables are used from other modules.
404 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
405 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
406 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
407 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
408 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
409 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
410 * xmenu.c, xselect.c:
411 Declare Q* vars static if they are not used in other modules.
412 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
413 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
414 Remove decls of unexported vars.
415 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
416
95c82688
PE
417 * lisp.h (DEFINE_FUNC): Make sname 'static'.
418
16a97296
PE
419 Make Emacs functions such as Fatom 'static' by default.
420 This makes it easier for human readers (and static analyzers)
421 to see whether these functions can be called from other modules.
422 DEFUN now defines a static function. To make the function external
423 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
424 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
425 (Finit_image_library):
16a97296
PE
426 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
427 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
428 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
429 Remove decls, since these functions are now static.
430 (Funintern, Fget_internal_run_time): New decls, since these functions
431 were already external.
95c82688 432
16a97296
PE
433 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
434 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
435 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
436 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
437 * keyboard.c, keymap.c, lread.c:
438 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
439 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
440 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
441 Mark functions with DEFUE instead of DEFUN,
442 if they are used in other modules.
443 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
444 decls for now-static functions.
445 * buffer.h (Fdelete_overlay): Remove decl.
446 * callproc.c (Fgetenv_internal): Mark as internal.
447 * composite.c (Fremove_list_of_text_properties): Remove decl.
448 (Fcomposition_get_gstring): New forward static decl.
449 * composite.h (Fcomposite_get_gstring): Remove decl.
450 * dired.c (Ffile_attributes): New forward static decl.
451 * doc.c (Fdocumntation_property): New forward static decl.
452 * eval.c (Ffetch_bytecode): New forward static decl.
453 (Funintern): Remove extern decl; now in .h file where it belongs.
454 * fileio.c (Fmake_symbolic_link): New forward static decl.
455 * image.c (Finit_image_library): New forward static decl.
456 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
457 * intervals.h (Fprevious_property_change):
458 (Fremove_list_of_text_properties): Remove decls.
459 * keyboard.c (Fthis_command_keys): Remove decl.
460 (Fcommand_execute): New forward static decl.
461 * keymap.c (Flookup_key): New forward static decl.
462 (Fcopy_keymap): Now static.
463 * keymap.h (Flookup_key): Remove decl.
464 * process.c (Fget_process): New forward static decl.
465 (Fprocess_datagram_address): Mark as internal.
466 * syntax.c (Fsyntax_table_p): New forward static decl.
467 (skip_chars): Remove duplicate decl.
468 * textprop.c (Fprevious_property_change): New forward static decl.
469 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
470 Now internal.
471 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
472 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
473
785bbd42
PE
474 * editfns.c (Fformat): Remove unreachable code.
475
8b913b57
AS
4762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
477
478 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
479 change. (Bug#8496)
480
a6744a35
EZ
4812011-04-13 Eli Zaretskii <eliz@gnu.org>
482
483 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
484 when at ZV. (Bug#8487)
485
e7974947
AS
4862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
487
baad03f0
AS
488 * charset.c (Fclear_charset_maps): Use xfree instead of free.
489 (Bug#8437)
490 * keyboard.c (parse_tool_bar_item): Likewise.
491 * sound.c (sound_cleanup, alsa_close): Likewise.
492 * termcap.c (tgetent): Likewise.
493 * xfns.c (x_default_font_parameter): Likewise.
494 * xsettings.c (read_and_apply_settings): Likewise.
495
e7974947
AS
496 * alloc.c (overrun_check_malloc, overrun_check_realloc)
497 (overrun_check_free): Protoize.
498
28272684
PE
4992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
500
501 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
502 since callers should never pass a negative size.
503 Change the signature to match that of plain 'read' and 'write'; see
504 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
505 * lisp.h: Update prototypes of emacs_write and emacs_read.
506
11997c76
EZ
5072011-04-11 Eli Zaretskii <eliz@gnu.org>
508
509 * xdisp.c (redisplay_window): Don't try to determine the character
510 position of the scroll margin if the window start point w->startp
e896f03c 511 is outside the buffer's accessible region. (Bug#8468)
11997c76 512
8a2cbd72
EZ
5132011-04-10 Eli Zaretskii <eliz@gnu.org>
514
515 Fix write-region and its subroutines for buffers > 2GB.
516 * fileio.c (a_write, e_write): Modify declaration of arguments and
517 local variables to support buffers larger than 2GB.
518 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
519
520 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
521 argument, local variables, and return value.
522
523 * lisp.h: Update prototypes of emacs_write and emacs_read.
524
525 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
526
4073e537 5272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 528
1ebfdcb6
PE
529 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
530
b2ded58d
PE
531 Fix more problems found by GCC 4.6.0's static checks.
532
7d66342c
PE
533 * xdisp.c (vmessage): Use a better test for character truncation.
534
bbf47d44
PE
535 * charset.c (load_charset_map): <, not <=, for optimization,
536 and to avoid potential problems with integer overflow.
9248994d 537 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 538 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 539 * editfns.c (Fformat): Likewise.
1e69125e 540 * syntax.c (skip_chars): Likewise.
3befa583 541
e3019616
PE
542 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
543 This also lets GCC 4.6.0 generate slightly better loop code.
544
becfa255
PE
545 * callint.c (Fcall_interactively): <, not <=, for optimization.
546 (Fcall_interactively): Count the number of arguments produced,
547 not the number of arguments given. This is simpler and lets GCC
548 4.6.0 generate slightly better code.
549
dae0cd48
PE
550 * ftfont.c: Distingish more carefully between FcChar8 and char.
551 The previous code passed unsigned char * to a functions like
552 strlen and xstrcasecmp that expect char *, which does not
553 conform to the C standard.
554 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
555 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
556 char * when the C standard requires it.
557
76032d70
PE
558 * keyboard.c (read_char): Remove unused var.
559
eb3f1cc8
PE
560 * eval.c: Port to Windows vsnprintf (Bug#8435).
561 Include <limits.h>.
562 (SIZE_MAX): Define if the headers do not.
563 (verror): Do not give up if vsnprintf returns a negative count.
564 Instead, grow the buffer. This ports to Windows vsnprintf, which
565 does not conform to C99. Problem reported by Eli Zaretskii.
566 Also, simplify the allocation scheme, by avoiding the need for
567 calling realloc, and removing the ALLOCATED variable.
568
70476b54
PE
569 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
570
12020a9e
PE
571 Remove invocations of doprnt, as Emacs now uses vsnprintf.
572 But keep the doprint source code for now, as we might revamp it
573 and use it again (Bug#8435).
ea6c7ae6
PE
574 * lisp.h (doprnt): Remove.
575 * Makefile.in (base_obj): Remove doprnt.o.
576 * deps.mk (doprnt.o): Remove.
577
5fdb398c
PE
578 error: Print 32- and 64-bit integers portably (Bug#8435).
579 Without this change, on typical 64-bit hosts error ("...%d...", N)
580 was used to print both 32- and 64-bit integers N, which relied on
581 undefined behavior.
582 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
583 New macro.
584 * lisp.h (error, verror): Mark as printf-like functions.
585 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
586 Report overflow in size calculations when allocating printf buffer.
587 Do not truncate output string at its first null byte.
588 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
589 Truncate the output at a character boundary, since vsnprintf does not
590 do that.
591 * charset.c (check_iso_charset_parameter): Convert internal
592 character to string before calling 'error', since %c now has the
593 printf meaning.
594 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
595 overflow when computing char to be passed to 'error'. Do not
596 pass Lisp_Object to 'error'; pass the integer instead.
597 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
598 formatted with plain %d.
599
b189fa66
PE
600 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
601
bff87ef0
PE
602 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
603
7e2cac20
PE
604 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
605
ce4d90b5
PE
606 * xterm.c (x_catch_errors): Remove duplicate declaration.
607
266c9547
PE
608 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
609
79c49ad2
PE
610 * xdisp.c, lisp.h (message_nolog): Remove; unused.
611
368f4090
JM
6122011-04-10 Jim Meyering <meyering@redhat.com>
613
614 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
615 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
616 return ssize_t not "int", and use size_t as the buffer length.
617 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
618 * gnutls.h: Update declarations.
619 * process.c (read_process_output): Use ssize_t, to match.
620 (send_process): Likewise.
621
a32d4040
CY
6222011-04-09 Chong Yidong <cyd@stupidchicken.com>
623
624 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
625
8546720e 6262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 627
8546720e
GM
628 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
629 unsigned char, to match FcChar8 type definition.
aac0c6e3 630
8546720e
GM
631 * xterm.c (handle_one_xevent):
632 * xmenu.c (create_and_show_popup_menu):
633 * xselect.c (x_decline_selection_request)
634 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 635
0a2f5c1a 6362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
637
638 Fix some uses of `int' instead of EMACS_INT.
639 * search.c (string_match_1, fast_string_match)
640 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
641 (scan_buffer, find_next_newline_no_quit)
642 (find_before_next_newline, search_command, Freplace_match)
643 (Fmatch_data): Make some `int' variables be EMACS_INT.
644
645 * xdisp.c (display_count_lines): 3rd argument and return value now
646 EMACS_INT. All callers changed.
647 (pint2hrstr): Last argument is now EMACS_INT.
648
649 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
650 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
651 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
652 (decode_coding_utf_16, decode_coding_emacs_mule)
653 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
654 (decode_coding_ccl, decode_coding_charset)
655 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
656 (decode_coding_iso_2022, decode_coding_emacs_mule)
657 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
658 <char_offset, last_offset>: Declare EMACS_INT.
659 (encode_coding_utf_8, encode_coding_utf_16)
660 (encode_coding_emacs_mule, encode_invocation_designation)
661 (encode_designation_at_bol, encode_coding_iso_2022)
662 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
663 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
664 Declare EMACS_INT.
665 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
666 (encode_invocation_designation): Last argument P_NCHARS is now
667 EMACS_INT.
668 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
669 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
670
671 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
672 All users changed.
673
674 * ccl.c (Fccl_execute_on_string): Declare some variables
675 EMACS_INT.
676
8546720e 6772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
678
679 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
680
4e19a977
CS
6812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
682
683 * process.c (Fformat_network_address): Doc fix.
684
87302331
R
6852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
686
687 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
688
cbb59342
CY
6892011-04-08 Chong Yidong <cyd@stupidchicken.com>
690
691 * keyboard.c (read_char): Call Lisp function help-form-show,
692 instead of using internal_with_output_to_temp_buffer.
693 (Qhelp_form_show): New var.
e0d38eeb 694 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
695
696 * print.c (internal_with_output_to_temp_buffer): Function deleted.
697
698 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
699
e67a13ab
CY
7002011-04-06 Chong Yidong <cyd@stupidchicken.com>
701
702 * process.c (Flist_processes): Removed to Lisp.
703 (list_processes_1): Deleted.
704
973f782d
EZ
7052011-04-06 Eli Zaretskii <eliz@gnu.org>
706
7c106b1e
EZ
707 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
708
973f782d
EZ
709 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
710
41cf7d1a 7112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 712
ca23cc88
PE
713 Fix more problems found by GCC 4.6.0's static checks.
714
f390e2d5
PE
715 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
716
42eea0d0
PE
717 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
718
b69769da 719 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 720
f9541e84
PE
721 * xdisp.c (vmessage): Mark as a printf-like function.
722
13841b55
PE
723 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
724
c136c10f
PE
725 * sound.c (sound_warning): Don't crash if arg contains a printf format.
726
5e2d4a30
PE
727 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
728 printf-like functions.
729 (tiff_load): Add casts to remove these marks before passing them
730 to system-supplied API.
731
583f48b9
PE
732 * eval.c (Fsignal): Remove excess argument to 'fatal'.
733
b25d760e
PE
734 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
735 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
736 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
737 directly, rather than having caller test rule sign. This avoids
738 some unnecessary tests.
739 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
740 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
741 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 742
bc7b6697 743 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 744 (xfont_open): Avoid unnecessary tests.
bc7b6697 745
27ccc379
PE
746 * composite.c (composition_gstring_put_cache): Use unsigned integer.
747
dcd5c89a
PE
748 * composite.h, composite.c (composition_gstring_put_cache):
749 Use EMACS_INT, not int, for length.
750
b13a45c6
PE
751 * composite.h (COMPOSITION_DECODE_REFS): New macro,
752 breaking out part of COMPOSITION_DECODE_RULE.
753 (COMPOSITION_DECODE_RULE): Use it.
754 * composite.c (get_composition_id): Remove unused local vars,
755 by using the new macro.
756
1e792e4d
PE
757 * textprop.c (set_text_properties_1): Change while to do-while,
758 since the condition is always true at first.
759
dc6c6455 760 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
761 (interval_deletion_adjustment): Return unsigned value.
762 All uses changed.
dc6c6455 763
aba7731a
PE
764 * process.c (list_processes_1, create_pty, read_process_output):
765 (exec_sentinel): Remove vars that were set but not used.
afd4052b 766 (create_pty): Remove unnecessary "volatile"s.
bc57d757 767 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 768 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 769 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 770
fdfc4bf3
PE
771 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
772
fca8fe46 773 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 774 (update_syntax_table): Use unsigned instead of int.
fca8fe46 775
06a0259a 776 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 777 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 778 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 779
e7b9e80f
PE
780 * print.c (print_error_message): Avoid int overflow.
781
56201685
PE
782 * font.c (font_list_entities): Redo for clarity,
783 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
784
78834453 785 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 786 (font_score): Avoid potential overflow in diff calculation.
78834453 787
0bc0b309 788 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 789 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 790
e610eaca
PE
791 * eval.c (funcall_lambda): Rename local to avoid shadowing.
792
b895abce
PE
793 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
794 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
795 can always succeed if overflow has undefined behavior.
796
1f1d9321 797 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 798 (wordify): Omit three unnecessary tests.
1f1d9321 799
c59478bc
PE
800 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
801 All callers changed. This avoids the need for an unused var.
802
79b73827
PE
803 * casefiddle.c (casify_region): Remove var that is set but not used.
804
a4db5dfe
PE
805 * dired.c (file_name_completion): Remove var that is set but not used.
806
43aae36e
PE
807 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
808
2a47c44d 809 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 810 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 811
a37c69bf
PE
812 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
813 Check for integer overflow on size calculations.
814
328ab8e7
PE
815 * buffer.c (Fprevious_overlay_change): Remove var that is set
816 but not used.
817
e5a2a5cb
PE
818 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
819 Remove vars that are set but not used.
8d84a6eb 820 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 821 (timer_check_2): Mark vars as initialized.
e5a2a5cb 822
a60e5f68
PE
823 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
824
f661cb61 825 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 826 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 827
f0397f5a
PE
828 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
829 that are set but not used.
830
8664db06 831 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 832 if XCreateBitmapFromData fails (Bug#8410).
8664db06 833
6abdaa4a
PE
834 * xselect.c (x_get_local_selection, x_handle_property_notify):
835 Remove vars that are set but not used.
836
0ce7538d 837 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 838 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 839
9ae848fc
PE
840 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
841 Remove var that is set but not used.
0b918413
PE
842 (scroll_bar_windows_size): Now size_t, not int.
843 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
844 Check for overflow.
9ae848fc 845
a5a62657
PE
846 * xfaces.c (realize_named_face): Remove vars that are set but not used.
847 (map_tty_color) [!defined MSDOS]: Likewise.
848
5c5cdd39
PE
849 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
850
66ebf983
PE
851 * coding.c: Remove vars that are set but not used.
852 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
853 All callers changed.
854 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
855 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
856 (decode_coding_charset): Remove vars that are set but not used.
857
1be4d761
PE
858 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
859 that is set but not used.
860
47553fa8
PE
861 * print.c (print_object): Remove var that is set but not used.
862
1f7196bf 863 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
864 The gnulib version avoids calling malloc in the usual case,
865 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
866 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
867 * filelock.c (current_lock_owner): Likewise.
868 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
869 * sysdep.c: Include allocator.h, careadlinkat.h.
870 (emacs_no_realloc_allocator): New static constant.
871 (emacs_readlink): New function.
fdb61804
PE
872 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
873 ../lib/careadlinkat.h.
d1fdcab7 874
f84c17c7
SM
8752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
876
877 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
878 first non-nil return value).
879
ef3862ad
JD
8802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
881
882 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
883 if not defined (Bug#8403).
884
376a7006
JB
8852011-04-02 Juanma Barranquero <lekktu@gmail.com>
886
887 * xdisp.c (display_count_lines): Remove parameter `start',
888 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
889 (get_char_face_and_encoding): Remove parameter `multibyte_p',
890 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
891 (fill_stretch_glyph_string): Remove parameters `row' and `area',
892 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
893 and thereabouts. All callers changed.
894 (get_per_char_metric): Remove parameter `f', unused since
895 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
896
6ca3801d
JM
8972011-04-02 Jim Meyering <meyering@redhat.com>
898
899 do not dereference NULL upon failed strdup
900 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
901 (ns_get_family): Likewise.
902
d8e2b5ba
JB
9032011-04-02 Juanma Barranquero <lekktu@gmail.com>
904
905 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
906
8c74fcbd
JD
9072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
908
909 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
910 later (Bug#8403).
911
7200d79c
SM
9122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
913
03408648 914 Add lexical binding.
7200d79c 915
03408648
SM
916 * window.c (Ftemp_output_buffer_show): New fun.
917 (Fsave_window_excursion):
918 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
919
920 * lread.c (lisp_file_lexically_bound_p): New function.
921 (Fload): Bind Qlexical_binding.
922 (readevalloop): Remove `evalfun' arg.
923 Bind Qinternal_interpreter_environment.
924 (Feval_buffer): Bind Qlexical_binding.
925 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
926 Mark as dynamic.
927 (syms_of_lread): Declare `lexical-binding'.
928
929 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
930
931 * keyboard.c (eval_dyn): New fun.
932 (menu_item_eval_property): Use it.
ca105506
SM
933
934 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 935
03408648
SM
936 * fns.c (concat, mapcar1): Accept byte-code-functions.
937
938 * eval.c (Fsetq): Handle lexical vars.
939 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
940 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
941 (FletX, Flet): Obey lexical binding.
942 (Fcommandp): Handle closures.
943 (Feval): New `lexical' arg.
944 (eval_sub): New function extracted from Feval. Use it almost
945 everywhere where Feval was used. Look up vars in lexical env.
946 Handle closures.
947 (Ffunctionp): Move from subr.el.
948 (Ffuncall): Handle closures.
949 (apply_lambda): Remove `eval_flags'.
950 (funcall_lambda): Handle closures and new byte-code-functions.
951 (Fspecial_variable_p): New function.
952 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
953 but without exporting it to Lisp.
23aba0ea 954
23aba0ea 955 * doc.c (Fdocumentation, store_function_docstring):
03408648 956 * data.c (Finteractive_form): Handle closures.
23aba0ea 957
03408648
SM
958 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
959 interactive spec.
ba83908c 960
03408648
SM
961 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
962 byte-codes.
963 (exec_byte_code): New function extracted from Fbyte_code to handle new
964 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 965
03408648 966 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 967
03408648 968 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 969
e2abce01
JB
9702011-03-31 Juanma Barranquero <lekktu@gmail.com>
971
972 * xdisp.c (redisplay_internal): Fix prototype.
973
63696a73 9742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 975
63696a73
EZ
976 * xdisp.c (SCROLL_LIMIT): New macro.
977 (try_scrolling): Use it when setting scroll_limit. Limit
978 scrolling to 100 screen lines.
979 (redisplay_window): Even when falling back on "recentering",
980 position point in the window according to scroll-conservatively,
981 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
982
983 (try_scrolling): When point is above the window, allow searching
984 as far as scroll_max, or one screenful, to compute vertical
985 distance from PT to the scroll margin position. This prevents
986 try_scrolling from unnecessarily failing when
987 scroll-conservatively is set to a value slightly larger than the
988 window height. Clean up the case of PT below the margin at bottom
989 of window: scroll_max can no longer be INT_MAX. When aggressive
990 scrolling is in use, don't let point enter the opposite scroll
991 margin as result of the scroll.
992 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
993 threshold of 100 lines for never-recentering scrolling.
994
e4cc2dfc
JB
9952011-03-31 Juanma Barranquero <lekktu@gmail.com>
996
997 * dispextern.h (move_it_by_lines):
998 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
999 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1000 (message_log_check_duplicate): Remove parameters `prev_bol' and
1001 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1002 (redisplay_internal): Remove parameter `preserve_echo_area',
1003 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1004
1005 * indent.c (Fvertical_motion):
1006 * window.c (window_scroll_pixel_based, Frecenter):
1007 Don't pass `need_y_p' to `move_it_by_lines'.
1008
1c470562
SM
10092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1010
44f230aa
SM
1011 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1012 steal a few bits to be more compact.
1013 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1014 Remove unneeded casts.
1015
1c470562
SM
1016 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1017
888adce9
ZK
10182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1019
1020 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1021 binding" message (bug#7967).
1022
f838ed7b
PE
10232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1024
77861b95
PE
1025 Fix more problems found by GCC 4.6.0's static checks.
1026
de6dbc14
PE
1027 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1028 Remove unused local var.
1029
f838ed7b
PE
1030 * editfns.c (Fmessage_box): Remove unused local var.
1031
792c7b2b
PE
1032 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1033 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1034 Omit unused local vars.
c499e557 1035 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1036 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1037 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1038 Omit unused local var.
1039
ba0165e1
PE
1040 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1041 Don't assume string length fits in int.
32ad8845 1042 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1043 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1044
3c59b4c9
PE
1045 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1046 instead of alloca (Bug#8344).
1047
a3eed478 1048 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1049 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1050
eb4d412d
PE
1051 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1052
1658b401
PE
1053 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1054 concerns.
1055
1056 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1057
1058 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1059
9a2c6e05
PE
1060 * keyboard.c (syms_of_keyboard): Use the same style as later
1061 in this function when indexing through an array. This also
1062 works around GCC bug 48267.
1063
03d0a109
PE
1064 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1065
44f730c8
PE
1066 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1067
fe75f926
PE
1068 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1069 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1070
ffa8c828
PE
1071 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1072 This avoids undefined behavior on integer overflow, and is a bit
1073 more convenient anyway since it is compared to a size_t variable.
1074
c5101a77
PE
1075 Variadic C functions now count arguments with size_t, not int.
1076 This avoids an unnecessary limitation on 64-bit machines, which
1077 caused (substring ...) to crash on large vectors (Bug#8344).
1078 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1079 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1080 All variadic functions and their callers changed accordingly.
c5101a77
PE
1081 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1082 * data.c (arith_driver, float_arith_driver): Likewise.
1083 * editfns.c (general_insert_function): Likewise.
1084 * eval.c (struct backtrace.nargs, interactive_p)
1085 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1086 (funcall_lambda, mark_backtrace): Likewise.
1087 * fns.c (concat): Likewise.
1088 * frame.c (x_set_frame_parameters): Likewise.
1089 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1090 0 if not found, not -1. All callers changed.
1091
dd3f25f7
PE
1092 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1093 (stack_copy_size): Now size_t, not int.
1094 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1095
461c2ab9
JB
10962011-03-28 Juanma Barranquero <lekktu@gmail.com>
1097
1098 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1099 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1100 All callers changed.
1101
1102 * lisp.h (multibyte_char_to_unibyte):
1103 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1104 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1105 * character.h (CHAR_TO_BYTE8):
1106 * cmds.c (internal_self_insert):
1107 * editfns.c (general_insert_function):
1108 * keymap.c (push_key_description):
1109 * search.c (Freplace_match):
1110 * xdisp.c (message_dolog, set_message_1): All callers changed.
1111
f6d62986
SM
11122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1113
1114 * keyboard.c (safe_run_hook_funcall): New function.
1115 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1116 don't set the hook to nil, but remove the offending function instead.
1117 (Qcommand_hook_internal): Remove, unused.
1118 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1119 Vcommand_hook_internal.
1120
1121 * eval.c (enum run_hooks_condition): Remove.
1122 (funcall_nil, funcall_not): New functions.
1123 (run_hook_with_args): Call each function through a `funcall' argument.
1124 Remove `cond' argument, now redundant.
1125 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1126 (Frun_hook_with_args_until_failure): Adjust accordingly.
1127 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1128
1db5b1ad
JB
11292011-03-28 Juanma Barranquero <lekktu@gmail.com>
1130
1131 * dispextern.h (string_buffer_position): Remove declaration.
1132
1133 * print.c (strout): Remove parameter `multibyte', unused since
1134 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1135
1136 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1137 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1138 All callers changed.
1139
1140 * w32.c (_wsa_errlist): Use braces for struct initializers.
1141
1142 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1143 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1144 All callers changed.
1145 (string_buffer_position): Likewise. Also, make static (it's never
1146 used outside xdisp.c).
1147 (cursor_row_p): Remove parameter `w', unused since
1148 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1149 (decode_mode_spec): Remove parameter `precision', introduced during
1150 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1151 All callers changed.
1152
5ffb62aa
JD
11532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1154
1155 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1156
461c2ab9 11572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1158
1159 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1160 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1161 (ns_update_auto_hide_menu_bar): New functions.
1162 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1163 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1164 ns_constrain_all_frames.
1165 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1166 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1167
5c380ffb
JD
11682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1169
1170 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1171
9af30bdf
GM
11722011-03-27 Glenn Morris <rgm@gnu.org>
1173
1174 * syssignal.h: Replace RETSIGTYPE with void.
1175 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1176 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1177 Replace SIGTYPE with void everywhere.
1178 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1179 * s/template.h (SIGTYPE): Remove commented out definition.
1180
e2abce01
JB
11812011-03-26 Eli Zaretskii <eliz@gnu.org>
1182
1183 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1184 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1185
f868cd8a
JB
11862011-03-26 Juanma Barranquero <lekktu@gmail.com>
1187
59eb0929
JB
1188 * w32.c (read_unc_volume): Use parameter `henum', instead of
1189 global variable `wget_enum_handle'.
1190
1191 * keymap.c (describe_vector): Remove parameters `indices' and
1192 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1193 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1194
f868cd8a
JB
1195 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1196
1197 * keyboard.c (timer_check): Remove parameter `do_it_now',
1198 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1199 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1200 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1201
1202 * keyboard.c (read_char):
1203 * w32menu.c (w32_menu_display_help):
1204 * xmenu.c (show_help_event, menu_help_callback):
1205 Adjust calls to `show_help_echo'.
1206
1207 * gtkutil.c (xg_maybe_add_timer):
1208 * keyboard.c (readable_events):
1209 * process.c (wait_reading_process_output):
1210 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1211
1212 * insdel.c (adjust_markers_gap_motion):
1213 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1214 (gap_left, gap_right): Don't call it.
1215
2ecf6fdb
CY
12162011-03-25 Chong Yidong <cyd@stupidchicken.com>
1217
1218 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1219 incurred during fontification.
1220
6b1f9ba4
JB
12212011-03-25 Juanma Barranquero <lekktu@gmail.com>
1222
1223 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1224 (DEFVAR_PER_BUFFER): Don't pass it.
1225
1226 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1227 (scrolling_window): Don't pass it.
1228
0f4a96b5
JB
12292011-03-25 Juanma Barranquero <lekktu@gmail.com>
1230
1231 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1232
1233 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1234 and `suffix'.
1235 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1236 of variables specific to SELinux and computation of `encoded_absname'.
1237
1238 * image.c (XPutPixel): Remove unused variable `height'.
1239
1240 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1241
1242 * unexw32.c (get_section_info): Remove unused variable `section'.
1243
1244 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1245 (system_process_attributes): Remove unused variable `sess'.
1246 (sys_read): Remove unused variable `err'.
1247
1248 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1249 (w32_wnd_proc): Remove unused variable `isdead'.
1250 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1251 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1252 (x_create_tip_frame): Remove unused variable `tem'.
1253
1254 * w32inevt.c (w32_console_read_socket):
1255 Remove unused variable `no_events'.
1256
1257 * w32term.c (x_draw_composite_glyph_string_foreground):
1258 Remove unused variable `width'.
1259
1149507c
JB
12602011-03-24 Juanma Barranquero <lekktu@gmail.com>
1261
1262 * w32term.c (x_set_glyph_string_clipping):
1263 Don't pass uninitialized region to CombineRgn.
1264
9c88f339
JB
12652011-03-23 Juanma Barranquero <lekktu@gmail.com>
1266
1267 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1268 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1269 (Fx_close_connection): Remove unused variable `i'.
1270
1271 * w32font.c (w32font_draw): Return number of glyphs.
1272 (w32font_open_internal): Remove unused variable `i'.
1273 (w32font_driver): Add missing initializer.
1274
1275 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1276 (fill_in_menu): Remove unused variable `items_added'.
1277
1278 * w32term.c (last_mouse_press_frame): Remove static global variable.
1279 (w32_clip_to_row): Remove unused variable `f'.
1280 (x_delete_terminal): Remove unused variable `i'.
1281
1282 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1283 (NOTHING): Remove unused static global variable.
1284 (uniscribe_check_otf): Remove unused variable `table'.
1285 (uniscribe_font_driver): Add missing initializers.
1286
dee091a3
JD
12872011-03-23 Julien Danjou <julien@danjou.info>
1288
1289 * term.c (Fsuspend_tty, Fresume_tty):
1290 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1291 * window.c (temp_output_buffer_show):
1292 * insdel.c (signal_before_change):
1293 * frame.c (Fhandle_switch_frame):
1294 * fileio.c (Fdo_auto_save):
1295 * emacs.c (Fkill_emacs):
1296 * editfns.c (save_excursion_restore):
1297 * cmds.c (internal_self_insert):
1298 * callint.c (Fcall_interactively):
1299 * buffer.c (Fkill_all_local_variables):
1300 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1301 Use Frun_hooks.
0f4a96b5 1302 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1303 unconditionnaly since it does the check itself.
1304
2c520ab5 13052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1306
c9c49752
PE
1307 Fix more problems found by GCC 4.5.2's static checks.
1308
8abc3f12
PE
1309 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1310 the first time through the loop, since we know p0 < p1 then.
1311 This also avoids a gcc -Wstrict-overflow warning.
1312
a2d26660
PE
1313 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1314 leading to a memory leak, possible in functions like
1315 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1316 of objects (Bug#8318).
a2d26660 1317
916c72e9
PE
1318 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1319 that could (at least in theory) be that large.
1320
19ab8a18
PE
1321 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1322 This is less likely to overflow, and avoids undefined behavior if
1323 overflow does occur. All callers changed. Use strtoul to scan
1324 for the unsigned long integer.
b7cbbd6f
PE
1325 (pint2hrstr): Simplify and tune code slightly.
1326 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1327
f0641eff
PE
1328 * scroll.c (do_scrolling): Work around GCC bug 48228.
1329 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1330
7f650bb9
PE
1331 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1332 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1333 (validate_x_resource_name): Simplify count usage.
1334 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1335
37dd57d1
PE
1336 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1337 fail (Bug#8306).
81e56e61 1338
699979fc 1339 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1340
401bf9b4
PE
1341 * process.c (Fmake_network_process): Use socklen_t, not int,
1342 where POSIX says socklen_t is required in portable programs.
1343 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1344 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1345 (Fmake_network_process, server_accept_connection):
1346 (wait_reading_process_output, read_process_output):
1347 Likewise.
1348
b93aacde
PE
1349 * process.c: Rename or move locals to avoid shadowing.
1350 (list_processes_1, Fmake_network_process):
1351 (read_process_output_error_handler, exec_sentinel_error_handler):
1352 Rename or move locals.
4dc343ee 1353 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1354 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1355 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1356 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1357 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1358
af8a867c 1359 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1360 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1361 Include tparam.h instead, since it declares them.
af8a867c
PE
1362 * cm.h (PC): Remove extern decl; tparam.h now does this.
1363 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1364 * terminfo.c: Include tparam.h, to check interfaces.
1365 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1366 (tparam): Adjust signature to match interface in tparam.h;
1367 this removes some undefined behavior. Check that outstring and len
1368 are zero, which they always are with Emacs.
1369 * tparam.h (PC, BC, UP): New extern decls.
1370
0248044d 1371 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1372 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1373
8ff096c1 1374 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1375 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1376 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1377 (ftfont_list): Remove unused local.
49eaafba
PE
1378 (get_adstyle_property, ftfont_pattern_entity):
1379 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1380 Rename locals to avoid shadowing.
8ff096c1 1381
e2be39f6
PE
1382 * xfont.c (xfont_list_family): Mark var as initialized.
1383
c9735e30
PE
1384 * xml.c (make_dom): Now static.
1385
8f5201ae
PE
1386 * composite.c (composition_compute_stop_pos): Rename local to
1387 avoid shadowing.
b246f932
PE
1388 (composition_reseat_it): Remove unused locals.
1389 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1390 (composition_update_it): Mark var as initialized.
11b61122
PE
1391 (find_automatic_composition): Mark vars as initialized,
1392 with a FIXME (Bug#8290).
8f5201ae 1393
760fbc2c
PE
1394 character.h: Rename locals to avoid shadowing.
1395 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1396 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1397 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1398 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1399 to avoid shadowing.
1400
ff08eb85
PE
1401 * textprop.c (property_change_between_p): Remove; unused.
1402
fc7bf025
PE
1403 * intervals.c (interval_start_pos): Now static.
1404
235d7abc
PE
1405 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1406
44f230aa
SM
1407 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1408 Rename locals to avoid shadowing.
3e7d6594 1409
50060332
PE
1410 * sound.c (wav_play, au_play, Fplay_sound_internal):
1411 Fix pointer signedness.
d01f234b 1412 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1413 (wav_play): Initialize a variable to 0, to prevent undefined
1414 behavior (Bug#8278).
50060332 1415
c4fc4e30
PE
1416 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1417
918436ed
PE
1418 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1419
c939f91b
PE
1420 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1421 clobbering (Bug#8298).
b9c7f648
PE
1422 * sysdep.c (sys_subshell): Likewise.
1423 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1424
6bd8c144
PE
1425 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1426 This should get cleaned up, so that child_setup has the
1427 same signature on all platforms.
1428
7710357c 1429 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1430 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1431
c59da222
CY
14322011-03-22 Chong Yidong <cyd@stupidchicken.com>
1433
1434 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1435 not to be necessary, and produces flickering.
1436
66b87493
GM
14372011-03-20 Glenn Morris <rgm@gnu.org>
1438
1439 * config.in: Remove file.
1440
45b6f6d5
JB
14412011-03-20 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1444 are now in src/globals.h.
1445 (syms_of_minibuf): Remove spurious & from previous change.
1446
3ec03f7e
LL
14472011-03-20 Leo <sdl.web@gmail.com>
1448
1449 * minibuf.c (completing-read-function): New variable.
1450 (completing-read-default): Rename from completing-read.
1451 (completing-read): Call completing-read-function.
1452
b14e3e21
CY
14532011-03-19 Juanma Barranquero <lekktu@gmail.com>
1454
1455 * xfaces.c (Fx_load_color_file):
1456 Read color file from absolute filename (bug#8250).
1457
f2b726e6
JB
14582011-03-19 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * makefile.w32-in: Update dependencies.
1461
09f6ff02
EZ
14622011-03-17 Eli Zaretskii <eliz@gnu.org>
1463
1464 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1465
29a6015a
PE
14662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1467
a3a6c54e
PE
1468 Fix more problems found by GCC 4.5.2's static checks.
1469
b766f867
PE
1470 * process.c (make_serial_process_unwind, send_process_trap):
1471 (sigchld_handler): Now static.
1472
be02381c
PE
1473 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1474 That way, the code declares only the vars that it needs.
1475 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1476 * s/cygwin.h (PTY_ITERATION): Likewise.
1477 * s/darwin.h (PTY_ITERATION): Likewise.
1478 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1479
57048744
PE
1480 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1481 * process.c (allocate_pty): Don't declare stb unless it's needed.
1482
7914961c 1483 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1484 (CONSTANTLIM): Remove; unused.
1485 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1486 Define only if needed.
7914961c 1487
b3967b18
PE
1488 * unexelf.c (unexec): Name an expression,
1489 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1490 Use a different way to cause a compilation error if anyone uses
1491 n rather than nn, a way that does not involve shadowing.
73366a00 1492 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1493
29a6015a
PE
1494 * deps.mk (unexalpha.o): Remove; unused.
1495
43cfc33e 1496 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1497 * unexec.h: New file.
ce701a33
PE
1498 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1499 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1500 Depend on unexec.h.
1501 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1502 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1503 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1504 Change as necessary to match prototype in unexec.h.
ce701a33 1505
01f44d5a
PE
1506 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1507 shadowing.
4f63c6bb 1508 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1509
a6670b0b
PE
1510 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1511 Rename locals to avoid shadowing.
1512
cef2010d 1513 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1514 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1515
d4d7173a
PE
1516 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1517
f08b802a
PE
1518 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1519 warning when compiling print.c.
1520
3ddb0639
PE
1521 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1522 instead of using an uninitialized var.
5ad03b97 1523 (font_sort_entities): Mark var as initialized.
3ddb0639 1524
170a2692
PE
1525 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1526
e663c700
PE
1527 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1528 pointers to constants.
89bc529a 1529 (font_parse_fcname): Remove unused vars.
7b81e2d0 1530 (font_delete_unmatched): Now static.
ea838e10 1531 (font_get_spec): Remove; unused.
13a547c6
PE
1532 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1533 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1534 Rename or move locals to avoid shadowing.
e663c700 1535
2a80c887 1536 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1537 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1538
1384fa33 1539 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1540 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1541
8b2c52e9
PE
1542 * alloc.c (mark_backtrace): Move decl from here ...
1543 * lisp.h: ... to here, so that it can be checked.
1544
475545b5 1545 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1546 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1547 (lisp_indirect_variable): Name an expression,
1548 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1549 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1550
b1349114 1551 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1552 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1553 Use const pointer when appropriate.
b1349114 1554
a2928364
PE
1555 * lisp.h (get_system_name, get_operating_system_release):
1556 Move decls here, to check interfaces.
1557 * process.c (get_operating_system_release): Move decl to lisp.h.
1558 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1559 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1560 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1561 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1562 (Fformat_time_string, Fencode_time, Finsert_char):
1563 (Ftranslate_region_internal, Fformat):
1564 Rename or remove local vars to avoid shadowing.
9710023e 1565 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1566
a415e694
PE
1567 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1568 avoid shadowing.
1569
8ef4622d
PE
1570 * lisp.h (eassert): Check that the argument compiles, even if
1571 ENABLE_CHECKING is not defined.
1572
946f9a5b
PE
1573 * data.c (Findirect_variable): Name an expression, to avoid
1574 gcc -Wbad-function-cast warning.
112396d6 1575 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1576 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1577 (Fmake_variable_buffer_local, Fmake_local_variable):
1578 Mark variables as initialized.
52746918 1579 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1580
e5aab7e7 1581 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1582 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1583 Rename locals to avoid shadowing.
dff45157
PE
1584 (mark_stack): Move local variables into the #ifdef region where
1585 they're used.
7bc26fdb
PE
1586 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1587 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1588 needed otherwise.
1589 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1590 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1591 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1592
e5aab7e7
PE
1593 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1594 avoids undefined behavior in theory.
1595
4da60324
PE
1596 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1597
88043301
PE
1598 Use functions, not macros, for up- and down-casing (Bug#8254).
1599 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1600 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1601 to use the following functions instead of these macros.
1602 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1603 EMACS_INT, since callers assume the returned value fits in int.
1604 (upcase1): Likewise, for UPCASE_TABLE.
1605 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1606 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1607 the race-condition problem in the old DOWNCASE.
88043301 1608
19ed5445
PE
1609 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1610 Rename locals to avoid shadowing.
1611 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1612 (regex_compile, re_search_2, re_match_2_internal):
1613 Remove unused local vars.
952db0d7
PE
1614 (FREE_VAR): Rewrite so as not to use empty "else",
1615 which gcc can warn about.
da053e48 1616 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1617 (RETALLOC_IF): Define only if needed.
1618 (WORDCHAR_P): Likewise. This one is never needed, but is used
1619 only in a comment talking about a compiler bug, so put inside
1620 the #if 0 of that comment.
1621 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1622 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1623 Remove; unused.
19ed5445 1624
1f3561e4 1625 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1626 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1627 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1628
ded6f8f7
PE
1629 * search.c (simple_search): Remove unused var.
1630
dbd37a95
PE
1631 * dired.c (compile_pattern): Move decl from here ...
1632 * lisp.h: ... to here, so that it can be checked.
1633 (struct re_registers): New forward decl.
1634
7e47afad
PE
1635 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1636
85f24f61
PE
1637 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1638 All uses changed.
1639 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1640 Rename locals to avoid shadowing.
5671df8f 1641 (Fvertical_motion): Mark locals as initialized.
85f24f61 1642
181aa2be 1643 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1644 (casify_region): Mark local as initialized.
181aa2be 1645
930d429c
PE
1646 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1647
7082eac6
PE
1648 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1649 New macros, so that the caller can use some names other than
1650 gcpro1, gcpro2, etc.
1651 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1652 of the new macros.
1653 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1654 argument, for consistency with GCPRO2_VAR, etc: it is now the
1655 prefix of the variable, not the variable itself. All uses
1656 changed.
38b2c076
PE
1657 * dired.c (directory_files_internal, file_name_completion):
1658 Rename locals to avoid shadowing.
1659
15206ed9
PE
1660 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1661 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1662 dired.c's scmp function, had undefined behavior.
1663 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1664 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1665 * buffer.h: ... to here, because these macros use current_buffer,
1666 and the new implementation with inline functions needs to have
1667 current_buffer in scope now, rather than later when the macros
1668 are used.
1669 (downcase, upcase1): New static inline functions.
1670 (DOWNCASE, UPCASE1): Reimplement using these functions.
1671 This avoids undefined behavior in expressions like
1672 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1673 from race conditions in accessing the global variables
1674 case_temp1 and case_temp2.
1675 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1676 * lisp.h (case_temp1, case_temp2): Remove their decls.
1677 * character.h (ASCII_CHAR_P): Move from here ...
1678 * lisp.h: ... to here, so that the inline functions mentioned
1679 above can use them.
1680
4a6bea26
PE
1681 * dired.c (directory_files_internal_unwind): Now static.
1682
f14b7e14
PE
1683 * fileio.c (file_name_as_directory, directory_file_name):
1684 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1685 Now static.
2893f146
PE
1686 (file_name_as_directory): Use const pointers when appropriate.
1687 (Fexpand_file_name): Likewise. In particular, newdir might
1688 point at constant storage, so make it a const pointer.
fd4ead52 1689 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1690 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1691 signedness issues.
f839df0c
PE
1692 (Fset_file_times, Finsert_file_contents, auto_save_error):
1693 Rename locals to avoid shadowing.
f14b7e14 1694
5716756e 1695 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1696 (Ftry_completion, Fall_completions): Rename or remove locals
1697 to avoid shadowing.
5716756e 1698
b4c3046a
PE
1699 * marker.c (bytepos_to_charpos): Remove; unused.
1700
b45db522
PE
1701 * lisp.h (verify_bytepos, count_markers): New decls,
1702 so that gcc does not warn that these functions aren't declared.
1703
85876d07
PE
1704 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1705 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1706 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1707 (copy_text): Remove unused local var.
85876d07 1708
03d78a21 1709 * filelock.c (within_one_second): Now static.
b3dd38ab 1710 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1711
5df8f01b
PE
1712 * buffer.c (fix_overlays_before): Mark locals as initialized.
1713 (fix_start_end_in_overlays): Likewise. This function should be
1714 simplified by using pointers-to-pointers, but that's a different
1715 matter.
b1d876f1 1716 (switch_to_buffer_1): Now static.
8f54f30a
PE
1717 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1718 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1719
a70072c9 1720 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1721 Fix pointer signedness issue.
edced198
PE
1722 (sys_subshell): Mark local as volatile if checking for lint,
1723 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1724 (MAXPATHLEN): Define only if needed.
a70072c9 1725
a0977c44
PE
1726 * process.c (serial_open, serial_configure): Move decls from here ...
1727 * systty.h: ... to here, so that they can be checked.
1728
a884fdcc
PE
1729 * fns.c (get_random, seed_random): Move extern decls from here ...
1730 * lisp.h: ... to here, so that they can be checked.
1731
604efe86 1732 * sysdep.c (reset_io): Now static.
b8950c94 1733 (wait_for_termination_signal): Remove; unused.
604efe86 1734
38fc62d9
PE
1735 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1736 (copy_keymap_item, append_key, push_text_char_description):
1737 Now static.
1004a21a 1738 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1739 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1740 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1741 (describe_map_tree):
1742 Rename locals to avoid shadowing.
38fc62d9 1743
2f2650da
PE
1744 * keyboard.c: Declare functions static if they are not used elsewhere.
1745 (echo_char, echo_dash, cmd_error, top_level_2):
1746 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1747 (read_char, kbd_buffer_get_event, make_lispy_position):
1748 (make_lispy_event, make_lispy_movement, apply_modifiers):
1749 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1750 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1751 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1752 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1753 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1754
a053e86c 1755 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1756 (mark_kboards): Move decl here ...
1757 * alloc.c (mark_kboards): ... from here.
a053e86c 1758
4752793e
PE
1759 * lisp.h (force_auto_save_soon): New decl.
1760
74f10ca7 1761 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1762 (DEFINE_DUMMY_FUNCTION): New macro.
1763 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1764 Use it.
c03cd23f
PE
1765 (main): Add casts to avoid warnings
1766 if GCC considers string literals to be constants.
74f10ca7 1767
022e70d4
PE
1768 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1769
59d6fe83
PE
1770 * dbusbind.c: Pointer signedness fixes.
1771 (xd_signature, xd_append_arg, xd_initialize):
1772 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1773 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1774 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1775 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1776
78320123
PE
1777 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1778 if GCC considers string literals to be constants.
49cebcca 1779 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1780
35ac2a97
SM
17812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1782
fb103ca9
SM
1783 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1784 (print_preprocess, print_object): New macro to fix last change.
1785
35ac2a97
SM
1786 * print.c (print_preprocess): Don't forget font objects.
1787
62973b41
JB
17882011-03-16 Juanma Barranquero <lekktu@gmail.com>
1789
1790 * emacs.c (USAGE3): Doc fixes.
1791
0e48bb22
AS
17922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1793
1794 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1795 structure.
1796
7684e57b
JB
17972011-03-14 Juanma Barranquero <lekktu@gmail.com>
1798
1799 * lisp.h (VWindow_system, Qfile_name_history):
1800 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1801 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1802 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1803
1804 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1805 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1806
1807 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1808 * w32console.c (detect_input_pending, read_input_pending)
1809 (encode_terminal_code):
1810 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1811 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1812 (w32_system_caret_y, Qfile_name_history):
1813 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1814 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1815 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1816 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1817 * w32proc.c (Qlocal, report_file_error):
1818 * w32term.c (Vwindow_system, updating_frame):
1819 * w32uniscribe.c (initialized, uniscribe_font_driver):
1820 Remove unneeded extern declarations.
1821
2aa46d6c
CY
18222011-03-14 Chong Yidong <cyd@stupidchicken.com>
1823
c96bbc66 1824 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1825
cffc6f3b
CY
18262011-03-13 Chong Yidong <cyd@stupidchicken.com>
1827
1828 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1829 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1830 These macros can no longer be used for assignment.
1831
44f230aa
SM
1832 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1833 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1834 (record_buffer_markers, fetch_buffer_markers): New functions for
1835 recording and fetching special buffer markers.
1836 (set_buffer_internal_1, set_buffer_temp): Use them.
1837
1838 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1839
1840 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1841
1842 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1843 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1844
1845 * xdisp.c (hscroll_window_tree):
1846 (reconsider_clip_changes): Use PT instead of BUF_PT.
1847
d251f04b
EZ
18482011-03-13 Eli Zaretskii <eliz@gnu.org>
1849
1850 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1851 $(EMACS_ROOT)/lib/intprops.h.
1852
f0c77cd1
PE
18532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1854
3eca4629
PE
1855 Fix more problems found by GCC 4.5.2's static checks.
1856
7c86ee98
PE
1857 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1858 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1859 (xg_free_frame_widgets): Make it clear that a local variable is
1860 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1861 (gdk_window_get_screen): Make it clear that this macro is needed
1862 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1863 (int_gtk_range_get_value): New function, which avoids a diagnostic
1864 from gcc -Wbad-function-cast.
1865 (xg_set_toolkit_scroll_bar_thumb): Use it.
1866 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1867 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1868 (get_utf8_string, xg_get_file_with_chooser):
1869 Rename locals to avoid shadowing.
1870 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1871
41729b81
PE
1872 * xgselect.c (xg_select): Remove unused var.
1873
f0c77cd1
PE
1874 * image.c (four_corners_best): Mark locals as initialized.
1875 (gif_load): Initialize transparent_p to zero (Bug#8238).
1876 Mark another local as initialized.
ec6cf4c6 1877 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1878
ce0ad53d 1879 * image.c (clear_image_cache): Now static.
d5d5a617 1880 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1881 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1882 (x_edge_detection): Remove unnecessary cast that
1883 gcc -Wbad-function-cast diagnoses.
2037898d 1884 (gif_load): Fix pointer signedness.
6ae141d6
PE
1885 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1886 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1887
33383987 18882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1889
d32df629
PE
1890 Improve quality of tests for time stamp overflow.
1891 For example, without this patch (encode-time 0 0 0 1 1
1892 1152921504606846976) returns the obviously-bogus value (-948597
1893 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1894 reports time overflow. See
1895 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1896 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1897 * editfns.c: Include limits.h and intprops.h.
1898 (TIME_T_MIN, TIME_T_MAX): New macros.
1899 (time_overflow): Move earlier, to before first use.
1900 (hi_time, lo_time): New functions, for an accurate test for
1901 out-of-range times.
1902 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1903 (Fget_internal_run_time): Don't assume time_t fits in int.
1904 (make_time): Use list2 instead of Fcons twice.
1905 (Fdecode_time): More accurate test for out-of-range times.
1906 (check_tm_member): New function.
1907 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1908 (lisp_time_argument): Don't rely on undefined left-shift and
1909 right-shift behavior when checking for time stamp overflow.
8be6f318 1910
fe31d94c
PE
1911 * editfns.c (time_overflow): New function, refactoring common code.
1912 (Fformat_time_string, Fdecode_time, Fencode_time):
1913 (Fcurrent_time_string): Use it.
1914
8be6f318
PE
1915 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1916 * dired.c (make_time): Move to ...
1917 * editfns.c (make_time): ... here.
1918 * systime.h: Note the move.
1919
09d9db2c 19202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1921
126bc0dc
YM
1922 * fringe.c (update_window_fringes): Remove unused variables.
1923
c47cbdfd
YM
1924 * unexmacosx.c (copy_data_segment): Also copy __got section.
1925 (Bug#8223)
1926
7ac80be9
EZ
19272011-03-12 Eli Zaretskii <eliz@gnu.org>
1928
c96bbc66 1929 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1930 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1931 Constify `char *' arguments and their references according to
1932 prototypes in tparam.h.
1933
ecb0f94d 1934 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1935
7ac80be9
EZ
1936 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1937 Adapt all references accordingly.
1938
1939 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1940
ef1fd07e
TT
19412011-03-11 Tom Tromey <tromey@redhat.com>
1942
1943 * buffer.c (syms_of_buffer): Remove obsolete comment.
1944
7ef4b50c
EZ
19452011-03-11 Eli Zaretskii <eliz@gnu.org>
1946
1947 * termhooks.h (encode_terminal_code): Declare prototype.
1948
1949 * msdos.c (encode_terminal_code): Don't declare prototype.
1950
1951 * term.c (encode_terminal_code): Now external again, used by
1952 w32console.c and msdos.c.
1953
44f230aa
SM
1954 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1955 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1956
4b1ec863 19572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1958
1714f52b 1959 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1960
4b1ec863
PE
1961 * fringe.c (update_window_fringes): Mark locals as initialized
1962 (Bug#8227).
1963 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1964
524c7aa6
PE
1965 * alloc.c (mark_fringe_data): Move decl from here ...
1966 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1967 to check its interface.
1968 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1969
a5c0af81 1970 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1971 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1972 (fontset_font): Mark local as initialized.
a9a06e0b 1973 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1974
b4716021
PE
1975 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1976
811e9bac 1977 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1978 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1979 (x_own_selection, Fx_disown_selection_internal): Rename locals
1980 to avoid shadowing.
1981 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1982
7e3ab302
PE
1983 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1984 so that the caller can use some name other than gcpro1.
1985 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1986 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1987 (Fx_backspace_delete_keys_p):
1988 Use them to avoid shadowing, and rename vars to avoid shadowing.
1989 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1990 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1991 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1992 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1993 Remove unused locals.
7e3ab302
PE
1994 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1995 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1996 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1997 macros.
f78faa98 1998
e2b13473
PE
1999 * xterm.h (x_mouse_leave): New decl.
2000
77f23912
PE
2001 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2002 Remove unused functions.
cdf4ba58
PE
2003 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2004 (x_calc_absolute_position): Now static.
7411c686 2005 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2006 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2007 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2008 unless they are used.
38d0b34a
PE
2009 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2010 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2011 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2012 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2013 (x_error_catcher, x_connection_closed, x_error_handler):
2014 (x_error_quitter, xembed_send_message, x_iconify_frame):
2015 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2016 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2017 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2018
44f230aa
SM
2019 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2020 Rename or move locals to avoid shadowing.
6b463e58 2021 (tty_defined_color, merge_face_heights): Now static.
5967d051 2022 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2023 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2024 does not deduce is never used uninitialized.
73719eba
PE
2025 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2026 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2027
426994c3 2028 * terminal.c (store_terminal_param): Now static.
5489860b 2029
032f1620 2030 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2031 (set_frame_menubar): Remove unused local.
d4323972 2032 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2033 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2034 since they might point to immutable storage.
281585b0
PE
2035 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2036 since it's unused otherwise.
032f1620 2037
367c19e5 2038 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2039 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2040 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2041 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2042 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2043 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2044 does not deduce are never used uninitialized.
70739cbe 2045
07b48fa9
PE
2046 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2047
8868a238 2048 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2049 * window.c (window_loop, size_window):
2050 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2051
7e5cf297 2052 * window.c (display_buffer): Now static.
d6550a9f
PE
2053 (size_window): Mark variables that gcc -Wuninitialized
2054 does not deduce are never used uninitialized.
a586633d
PE
2055 * window.h (check_all_windows): New decl, to forestall
2056 gcc -Wmissing-prototypes diagnostic.
5b555da1 2057 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2058
f6095868
PE
2059 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2060 shadowing.
2061 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2062 Include <limits.h>.
2063 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2064 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2065 (load_charset_map): Mark variables that gcc -Wuninitialized
2066 does not deduce are never used uninitialized.
53df7c11 2067 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2068
f38b440c
PE
2069 * coding.c (coding_set_source, coding_set_destination):
2070 Use "else { /* comment */ }" rather than "else /* comment */;"
2071 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2072 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2073 a block, when the outer 'i' will do.
2074 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2075 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2076 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2077 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2078 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2079 Rename locals to avoid shadowing.
2080 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2081 * coding.c (emacs_mule_char, encode_invocation_designation):
2082 Now static, since they're not used elsewhere.
413bb2db 2083 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2084 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2085 (decode_coding_emacs_mule): Mark variables that gcc
2086 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2087 (detect_coding_iso_2022): Initialize a local variable that might
2088 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2089 this initialization is needed. (Bug#8211)
5f58e762
PE
2090 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2091 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2092 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2093 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2094 Remove unused macros.
f38b440c 2095
232b38b9 2096 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2097 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2098 * character.c (string_count_byte8): Likewise.
232b38b9 2099
fb90da1b
PE
2100 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2101 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2102
fb93dbc2
PE
2103 * chartab.c (copy_sub_char_table): Now static, since it's not used
2104 elsewhere.
5c156ace
PE
2105 (sub_char_table_ref_and_range, char_table_ref_and_range):
2106 Rename locals to avoid shadowing.
bbcd0949 2107 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2108
7d3b3862 2109 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2110 (BIDI_BOB): Remove unused macro.
7d3b3862 2111
6be7d3da
PE
2112 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2113 deduce are never used uninitialized.
c2ed9c8b 2114 * term.c (encode_terminal_code): Likewise.
6be7d3da 2115
75f8807f 2116 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2117
50938595
PE
2118 * tparam.h: New file.
2119 * term.c, tparam.h: Include it.
2120 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2121 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2122 Move these decls to tparam.h, and make them agree with what
2123 is actually in tparam.c. The previous trick of using incompatible
2124 decls in different modules does not conform to the C standard.
2125 All callers of tparam changed to use tparam's actual API.
2126 * tparam.c (tparam1, tparam, tgoto):
2127 Use const pointers where appropriate.
2128
fbceeba2
PE
2129 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2130 * cm.h (struct cm): Likewise.
2131 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2132 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2133 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2134 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2135 (turn_on_face, init_tty): Likewise.
2136 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2137
7f3f1250
PE
2138 * term.c (term_mouse_position): Rename local to avoid shadowing.
2139
e6ca6543
PE
2140 * alloc.c (mark_ttys): Move decl from here ...
2141 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2142
c40f8d15
AS
21432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2144
2145 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2146
cfe0661d
JB
21472011-03-09 Juanma Barranquero <lekktu@gmail.com>
2148
2149 * search.c (compile_pattern_1): Remove argument regp, unused since
2150 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2151 (compile_pattern): Don't pass it.
2152
0afb4571
J
21532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2154
2155 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2156 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2157 for ! HAVE_GTK3.
2158 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2159
2160 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2161
2162 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2163 gdk_window_get_screen, gdk_window_get_geometry,
2164 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2165 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2166 (xg_get_pixbuf_from_pixmap): New function.
2167 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2168 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2169 Call xg_get_pixbuf_from_pixmap instead of
2170 gdk_pixbuf_get_from_drawable.
2171 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2172 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2173 (xg_check_special_colors): Use GtkStyleContext and its functions
2174 for HAVE_GTK3.
2175 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2176 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2177 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2178 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2179 Call gtk_widget_get_preferred_size.
0afb4571
J
2180 (xg_frame_resized): gdk_window_get_geometry only takes 5
2181 parameters.
44f230aa
SM
2182 (xg_win_to_widget, xg_event_is_for_menubar):
2183 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2184 (xg_set_widget_bg): New function.
2185 (delete_cb): New function.
2186 (xg_create_frame_widgets): connect delete-event to delete_cb.
2187 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2188 (xg_set_background_color): Call xg_set_widget_bg.
2189 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2190 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2191 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2192 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2193 if ! HAVE_GTK3.
2194 (update_frame_tool_bar): Call gtk_widget_hide.
2195 (xg_initialize): Use GDK_KEY_g.
2196
2197 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2198 if ! HAVE_GTK3
2199 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2200
2201 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2202 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2203 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2204
1c2cc4ef
JB
22052011-03-08 Juanma Barranquero <lekktu@gmail.com>
2206
2207 * w32xfns.c (select_palette): Check success of RealizePalette against
2208 GDI_ERROR, not zero.
2209
33383987 2210See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2211
2212;; Local Variables:
2213;; coding: utf-8
aac0c6e3
MR
2214;; End:
2215
33383987 2216 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2217
2218 This file is part of GNU Emacs.
2219
2220 GNU Emacs is free software: you can redistribute it and/or modify
2221 it under the terms of the GNU General Public License as published by
2222 the Free Software Foundation, either version 3 of the License, or
2223 (at your option) any later version.
2224
2225 GNU Emacs is distributed in the hope that it will be useful,
2226 but WITHOUT ANY WARRANTY; without even the implied warranty of
2227 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2228 GNU General Public License for more details.
2229
2230 You should have received a copy of the GNU General Public License
2231 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.