* net/rlogin.el (rlogin-mode-map): Fix last change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
297834cd
PE
12012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 * unexaix.c (make_hdr): Fix typo in prototype.
4 This bug broke the build on AIX. Problem reported by Gilles Pion.
5
0d887c7d
EZ
62012-05-05 Eli Zaretskii <eliz@gnu.org>
7
8 * w32proc.c (new_child): Force Windows to reserve only 64KB of
9 stack for each reader_thread, instead of defaulting to 8MB
10 determined by the linker. This avoids failures in creating
11 subprocesses on Windows 7, see the discussion in this thread:
12 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
13
bf98199c
JM
142012-05-02 Jim Meyering <meyering@redhat.com>
15
16 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
17
2fa85638
EZ
182012-04-29 Eli Zaretskii <eliz@gnu.org>
19
20 * xdisp.c (pos_visible_p): If already at a newline from the
21 display string before the 'while' loop, don't walk back the glyphs
22 from it3.glyph_row. Solves assertion violation when the display
23 string begins with a newline (egg.el). (Bug#11367)
24
9be2fd9b
CY
252012-04-24 Chong Yidong <cyd@gnu.org>
26
27 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
28
f0ee99a0
EZ
292012-04-23 Eli Zaretskii <eliz@gnu.org>
30
31 * xdisp.c (pos_visible_p): If the window start position is beyond
32 ZV, start the display from buffer beginning. Prevents assertion
33 violation in init_iterator when the minibuffer window is scrolled
34 via the scroll bar.
35
36 * window.c (window_scroll_pixel_based): Likewise.
37
9ec7751f
CY
382012-04-23 Chong Yidong <cyd@gnu.org>
39
40 * keymap.c (where_is_internal): Doc fix (Bug#10872).
41
24c51a09
GM
422012-04-20 Glenn Morris <rgm@gnu.org>
43
44 * fileio.c (Fcopy_file, Fset_file_selinux_context):
45 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
46
73055685
EZ
472012-04-20 Eli Zaretskii <eliz@gnu.org>
48
49 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
50 overrun array limits of glyph row's used[] array. (Bug#11288)
51
f30d612a
CY
522012-04-20 Chong Yidong <cyd@gnu.org>
53
54 * process.c (wait_reading_process_output): If EIO occurs on a pty,
55 set the status to "failed" and ensure that sentinel is run.
56
016a35df
GM
572012-04-18 Glenn Morris <rgm@gnu.org>
58
59 * process.c (Fset_process_inherit_coding_system_flag)
60 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 61 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 62
20a68157
EZ
632012-04-17 Eli Zaretskii <eliz@gnu.org>
64
65 * xdisp.c (string_buffer_position_lim): Limit starting position to
66 BEGV.
67 (set_cursor_from_row): If called for a mode-line or header-line
68 row, return zero immediately.
69 (try_cursor_movement): If inside continuation line, don't back up
70 farther than the first row after the header line, if any. Don't
71 consider the header-line row as "partially visible", even if
72 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
73
ad3a2b41
AO
742012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
75
76 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
77
e63c261b
CY
782012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
79
80 * process.c (make_process):
81 * process.h: Add integer `gnutls_handshakes_tried' member to
82 process struct.
83
ad3a2b41
AO
84 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
85 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
86
87 * gnutls.c (gnutls_log_function2i): Convenience log function.
88 (emacs_gnutls_read): Use new log functions,
89 `gnutls_handshakes_tried' process member, and
90 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
91 attempts per process (connection).
92
e53357c4
EZ
932012-04-09 Eli Zaretskii <eliz@gnu.org>
94
95 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
96 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
97
aff67c82
JD
982012-04-09 Jan Djärv <jan.h.d@swipnet.se>
99
100 * nsterm.m (constrainFrameRect): Always constrain when there is only
101 one screen (Bug#10962).
102
2f8e16b2
EZ
1032012-04-06 Eli Zaretskii <eliz@gnu.org>
104
105 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
106 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
107 about subtle differences between FETCH_CHAR* and STRING_CHAR*
108 macros related to unification of CJK characters. For the details,
109 see the discussion following the message here:
110 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
111
3d439cd1
CY
1122012-04-04 Chong Yidong <cyd@gnu.org>
113
114 * keyboard.c (Vdelayed_warnings_list): Doc fix.
115
8bc53d00
EZ
1162012-04-01 Eli Zaretskii <eliz@gnu.org>
117
118 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
119 instead of alloca. (Bug#11138)
120
3b0512a3
AS
1212012-04-01 Andreas Schwab <schwab@linux-m68k.org>
122
123 * w32menu.c (is_simple_dialog): Properly check lisp types.
124 (Bug#11141)
125
8427ddd2
EZ
1262012-03-31 Eli Zaretskii <eliz@gnu.org>
127
979022ef
EZ
128 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
129 position we get to after a call to move_it_to fails the
130 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
131 only if we wind up in a string from display property. (Bug#11063)
132
a6b1c7cc
EZ
133 * window.c (Fdelete_other_windows_internal): Invalidate the row
134 and column information about mouse highlight, so that redisplay
135 restores it after reallocating the glyph matrices. (Bug#7464)
136
8427ddd2
EZ
137 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
138 string comes from a `display' text property, use the buffer
139 position of that property as if we actually saw that position in
140 the row's glyphs.
697ba24b
EZ
141 (move_it_by_lines): Remove the assertion that
142 "it->current_x == 0 && it->hpos == 0" which can be legitimately
143 violated when there's a before-string at the beginning of a line.
144 (Bug#11063)
8427ddd2 145
65a0a738
EZ
1462012-03-30 Eli Zaretskii <eliz@gnu.org>
147
148 * xdisp.c (append_space_for_newline): If the default face was
149 remapped, use the remapped face for the appended newline.
150 (extend_face_to_end_of_line): Use the remapped default face for
151 extending the face to the end of the line.
152 (display_line): Call extend_face_to_end_of_line when the default
153 face was remapped. (Bug#11068)
154
581355cc
EZ
1552012-03-29 Eli Zaretskii <eliz@gnu.org>
156
157 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
158
e8fc049f
SM
1592012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
160
161 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
162
4fb9a543
GM
1632012-03-27 Glenn Morris <rgm@gnu.org>
164
165 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
166 Doc fixes.
167
679910f1
KH
1682012-03-26 Kenichi Handa <handa@m17n.org>
169
170 * dispextern.h (struct glyph): Fix previous change. Change the
171 bit length of glyphless.ch to 25 (Bug#11082).
172
90d49b7f
CY
1732012-03-26 Chong Yidong <cyd@gnu.org>
174
175 * keyboard.c (Vselection_inhibit_update_commands): New variable.
176 (command_loop_1): Use it; inhibit selection update for
177 handle-select-window too (Bug#8996).
178
f514f6f0
FP
1792012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
180
e8fc049f 181 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 182
bf43fa51
KH
1832012-03-25 Kenichi Handa <handa@m17n.org>
184
185 * dispextern.h (struct glyph): Change the bit length of
186 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
187
8a0c01dd
EZ
1882012-03-24 Eli Zaretskii <eliz@gnu.org>
189
190 * s/ms-w32.h (tzname): Include time.h before redirecting to
191 _tzname. Fixes the MSVC build. (Bug#9960)
192
7d1c3a76
AS
1932012-03-24 Andreas Schwab <schwab@linux-m68k.org>
194
8ed79523
AS
195 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
196 characters.
197
7d1c3a76
AS
198 * xterm.c (XTread_socket): Only modify handling_signal if
199 !SYNC_INPUT. (Bug#11080)
200
e99a9b8b
EZ
2012012-03-23 Eli Zaretskii <eliz@gnu.org>
202
203 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
204 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
205 when fetching a multibyte character consumes more bytes than
206 CHAR_BYTES returns, due to unification of CJK characters in
207 string_char. (Bug#11073)
208
5063c0e1
TN
2092012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
210
211 * process.c (wait_reading_process_output): Handle pty disconnect
212 by refraining from sending oneself a SIGCHLD (bug#10933).
213
9f851fbd
CY
2142012-03-22 Chong Yidong <cyd@gnu.org>
215
216 * dispextern.h (struct it): New member string_from_prefix_prop_p.
217
5063c0e1 218 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
219 Mark string as coming from a prefix property.
220 (handle_face_prop): Use default face for prefix strings (Bug#4281).
221 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
222
fb5b8aca
CY
2232012-03-21 Chong Yidong <cyd@gnu.org>
224
225 * xfaces.c (Vface_remapping_alist): Doc fix.
226
62356a1b
EZ
2272012-03-20 Eli Zaretskii <eliz@gnu.org>
228
229 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
230 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
231 Doc fixes.
62356a1b 232
025de85b
CY
2332012-03-20 Chong Yidong <cyd@gnu.org>
234
235 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
236 to reflect default non-nil value of redisplay-dont-pause.
237
4827f94e
KH
2382012-03-19 Kenichi Handa <handa@m17n.org>
239
240 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
241 it fit in a valid range (Bug#11003).
242
e50a24a2
EZ
2432012-03-18 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
246 that is not from display property, accept the row as a "cursor
247 row" if one of the string's character has a non-nil `cursor'
248 property. Fixes cursor positioning when there are newlines in
249 overlay strings, e.g. in icomplete.el. (Bug#11035)
250
9af5ed87
PE
2512012-03-12 Paul Eggert <eggert@cs.ucla.edu>
252
253 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
254
d1f55f16
CY
2552012-03-12 Chong Yidong <cyd@gnu.org>
256
257 * eval.c (inhibit_lisp_code): Rename from
258 inhibit_window_configuration_change_hook; move from window.c.
259
260 * xfns.c (unwind_create_frame_1, Fx_create_frame):
261 * window.c (run_window_configuration_change_hook)
262 (syms_of_window): Callers changed.
263
66c5eebd
CY
2642012-03-11 Chong Yidong <cyd@gnu.org>
265
413df973
CY
266 * keymap.c (Fkey_description): Doc fix (Bug#9700).
267
66c5eebd
CY
268 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
269
1de11f56
CY
2702012-03-10 Chong Yidong <cyd@gnu.org>
271
272 * frame.c (other_visible_frames): Don't assume the selected frame
273 is visible (Bug#10955).
274
cae07000
SM
2752012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
276
277 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
278
89c94350
JD
2792012-03-08 Jan Djärv <jan.h.d@swipnet.se>
280
281 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
282 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
283 zero (Bug#10954).
284
999dd333
GM
2852012-03-03 Glenn Morris <rgm@gnu.org>
286
01a6dcc8 287 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 288
de0100f2
EZ
2892012-03-02 Eli Zaretskii <eliz@gnu.org>
290
291 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
292 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
293 (redisplay_window, next_element_from_string): Fix typos in
294 comments.
3e441275
EZ
295 (redisplay_window): Pass to move_it_vertically the margin in
296 pixels, not in screen lines.
de0100f2 297
96a72ee9
GM
2982012-03-02 Glenn Morris <rgm@gnu.org>
299
300 * buffer.c (buffer-list-update-hook): Doc fix.
301
312508d7
EZ
3022012-02-29 Eli Zaretskii <eliz@gnu.org>
303
304 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
305 push_it before setting up the iterator for the first overlay
306 string, even if we have an empty string loaded.
307 (next_overlay_string): If there's an empty string on the iterator
308 stack, pop the stack. (Bug#10903)
309
27f3c637
PE
3102012-02-25 Paul Eggert <eggert@cs.ucla.edu>
311
312 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
313 Suggested by Stefan Monnier in
314 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
315 * alloc.c (widen_to_Lisp_Object): New static function.
316 (mark_memory): Also mark Lisp_Objects by fetching pointer words
317 and widening them to Lisp_Objects. This would work even if
318 USE_LSB_TAG is defined and wide integers are used, which might
319 happen in a future version of Emacs.
320
3c9dfce6
CY
3212012-02-25 Chong Yidong <cyd@gnu.org>
322
fa74b241
CY
323 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
324 Doc fix.
325
3c9dfce6
CY
326 * xselect.c (Fx_selection_exists_p): Doc fix.
327 (x_clipboard_manager_save_all): Print an informative message
328 before saving to clipboard manager.
329
9486df08
CY
3302012-02-24 Chong Yidong <cyd@gnu.org>
331
332 * keyboard.c (process_special_events): Handle all X selection
333 requests in kbd_buffer, not just the next one (Bug#8869).
334
f01d3321
CY
3352012-02-23 Chong Yidong <cyd@gnu.org>
336
337 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
338 call when setting menu-bar-lines and tool-bar-lines parameters.
339 (unwind_create_frame_1): New helper function.
340
341 * window.c (inhibit_window_configuration_change_hook): New var.
342 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 343 (syms_of_window): Initialize it.
f01d3321 344
86b847b6
CY
3452012-02-22 Chong Yidong <cyd@gnu.org>
346
347 * xterm.c (x_draw_image_relief): Add missing type check for
348 Vtool_bar_button_margin (Bug#10743).
349
a59225b1
CY
3502012-02-21 Chong Yidong <cyd@gnu.org>
351
352 * fileio.c (Vfile_name_handler_alist): Doc fix.
353
354 * buffer.c (Fget_file_buffer): Protect against invalid file
355 handler return value.
356
310f5bd4
PE
3572012-02-20 Paul Eggert <eggert@cs.ucla.edu>
358
cb3a28cc
PE
359 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
360 when computing $valmask.
361
310f5bd4
PE
362 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
363 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
364 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
365 It's useless in that case, and it can cause problems on hosts
366 that allocate halves of EMACS_INT values separately.
367 Reported by Dan Horák. Diagnosed by Andreas Schwab in
368 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
369 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
370 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
371 it avoids undefined behavior on hosts where shifting right by more
372 than the word width has undefined behavior.
373
2375c96a
CY
3742012-02-19 Chong Yidong <cyd@gnu.org>
375
376 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
377 (Funhandled_file_name_directory, Ffile_name_as_directory)
378 (Fdirectory_file_name, Fexpand_file_name)
379 (Fsubstitute_in_file_name): Protect against invalid file handler
380 return values (Bug#10845).
381
3eb49e71
EZ
3822012-02-18 Eli Zaretskii <eliz@gnu.org>
383
384 * .gdbinit (pitx): Fix incorrect references to fields of the
385 iterator stack.
386
7b926f3f
CY
3872012-02-17 Chong Yidong <cyd@gnu.org>
388
389 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
390
11273115
PE
3912012-02-15 Paul Eggert <eggert@cs.ucla.edu>
392
393 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
394 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
395
c3a70e2b
CY
3962012-02-15 Chong Yidong <cyd@gnu.org>
397
398 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
399 marked as special. Also, starting docstrings with * is obsolete.
400
0ca43699
AS
4012012-02-13 Andreas Schwab <schwab@linux-m68k.org>
402
403 * gnutls.c (emacs_gnutls_write): Fix last change.
404
2e8f3c56
LI
4052012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
406
407 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
408 send_process.
409
af70074f
SM
4102012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 * keymap.c (Fsingle_key_description): Handle char ranges.
413
95986d52
CY
4142012-02-12 Chong Yidong <cyd@gnu.org>
415
afd83bd1
CY
416 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
417 as that creates a dangerous corner case.
418
95986d52
CY
419 * window.c (Fdelete_window_internal): Invalidate the mouse
420 highlight (Bug#9904).
421
bd7da63e
GM
4222012-02-12 Glenn Morris <rgm@gnu.org>
423
424 * xselect.c (Fx_own_selection_internal)
425 (Fx_get_selection_internal, Fx_disown_selection_internal)
426 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
427 * nsselect.m (Fx_own_selection_internal)
428 (Fx_disown_selection_internal, Fx_selection_exists_p)
429 (Fx_selection_owner_p, Fx_get_selection_internal):
430 Sync docs and argument specs with the xselect.c versions.
431
77abcbc2
LI
4322012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
433
434 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
435
90b671e2
EZ
4362012-02-11 Eli Zaretskii <eliz@gnu.org>
437
1c0ca0b7
EZ
438 * w32select.c (Fx_selection_exists_p): Sync doc string and
439 argument list with xselect.c. (Bug#10783)
440
441 * w16select.c (Fx_selection_exists_p): Sync doc string and
442 argument list with xselect.c. (Bug#10783)
90b671e2 443
49241268
GM
4442012-02-10 Glenn Morris <rgm@gnu.org>
445
446 * fns.c (Fsecure_hash): Doc fix.
447
f998bbe7 4482012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
449
450 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
451
0992bd9c
CY
4522012-02-07 Chong Yidong <cyd@gnu.org>
453
454 * buffer.c (Fbuffer_local_variables)
455 (buffer_lisp_local_variables): Handle unbound vars correctly;
456 don't let Qunbound leak into Lisp.
457
af008560
GM
4582012-02-07 Glenn Morris <rgm@gnu.org>
459
dd605cc4
GM
460 * image.c (Fimagemagick_types): Doc fix.
461
af008560
GM
462 * image.c (imagemagick-render-type): Change it from a lisp object
463 to an integer. Move the doc here from the lisp manual.
464 Treat all values not equal to 0 the same.
465
1449fa1d
CY
4662012-02-06 Chong Yidong <cyd@gnu.org>
467
468 * doc.c (store_function_docstring): Avoid applying docstring of
469 alias to base function (Bug#2603).
470
3723ec07
AS
4712012-02-04 Andreas Schwab <schwab@linux-m68k.org>
472
473 * .gdbinit (pp1, pv1): Remove redundant defines.
474 (pr): Use pp.
475
79c1cc1e
CY
4762012-02-04 Chong Yidong <cyd@gnu.org>
477
478 * nsterm.m: Declare a global (Bug#10694).
479
d7f29f8e
EZ
4802012-02-04 Eli Zaretskii <eliz@gnu.org>
481
cae07000
SM
482 * w32.c (get_emacs_configuration_options):
483 Include --enable-checking, if specified, in the return value.
d7f29f8e 484
3b95a6f9
MR
4852012-02-04 Martin Rudalics <rudalics@gmx.at>
486
487 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
488 after rounding frame sizes. (Bug#9723)
489
d6fa96a6
EZ
4902012-02-04 Eli Zaretskii <eliz@gnu.org>
491
492 * keyboard.c (adjust_point_for_property): Don't position point
493 before BEGV. (Bug#10696)
494
df0b2940
PE
4952012-02-03 Paul Eggert <eggert@cs.ucla.edu>
496
497 Handle overflow when computing char display width (Bug#9496).
498 * character.c (char_width): Return EMACS_INT, not int.
499 (char_width, c_string_width): Check for overflow when
500 computing the width; this is possible now that individual
501 characters can have unbounded width. Problem introduced
502 by merge from Emacs 23 on 2012-01-19.
503
6bee44d6
MA
5042012-02-02 Michael Albinus <michael.albinus@gmx.de>
505
506 * dbusbind.c (Fdbus_register_method): Mention the return value
507 :ignore in the docstring.
508
44f92739
GM
5092012-02-02 Glenn Morris <rgm@gnu.org>
510
1b9f60cc
GM
511 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
512
44f92739
GM
513 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
514 Unconditionally set to t. (Bug#10673)
515 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
516 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
517 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
518
c5d3843c
KH
5192012-02-02 Kenichi Handa <handa@m17n.org>
520
521 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
522 0, do not call append_composite_glyph.
523
159462d4 5242012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
525
526 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
527 NULL (Bug#6988).
528 (x_produce_glyphs): If the component of a composition is a null
529 string, set it->pixel_width to 1 to avoid zero-width glyph.
530
78cef877
EZ
5312012-02-01 Eli Zaretskii <eliz@gnu.org>
532
533 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
534 first 2 arguments are identical. This makes inserting large
535 output from a subprocess an order of magnitude faster on
536 MS-Windows, where all sbrk'ed memory is always contiguous.
537
97897668
GM
5382012-01-31 Glenn Morris <rgm@gnu.org>
539
540 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 541 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
542 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
543
31fd3586
GM
5442012-01-29 Glenn Morris <rgm@gnu.org>
545
546 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
547
0e24a8b2
CY
5482012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
549
550 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
551
cc0adcb0
CY
5522012-01-28 Chong Yidong <cyd@gnu.org>
553
554 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
555
acc28cb9
CY
5562012-01-26 Chong Yidong <cyd@gnu.org>
557
9c69cfb7
CY
558 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
559
acc28cb9
CY
560 * search.c (Fsearch_forward, Fsearch_backward): Document negative
561 repeat counts (Bug#10507).
562
48da7392
GM
5632012-01-26 Glenn Morris <rgm@gnu.org>
564
565 * lread.c (syms_of_lread): Doc fix.
566
14af5f7f
CY
5672012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
568
569 * coding.c (encode_designation_at_bol): Change return value to
570 EMACS_INT.
571
0b21c100
CY
5722012-01-25 Chong Yidong <cyd@gnu.org>
573
574 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
575
3c2907f7
CY
5762012-01-21 Chong Yidong <cyd@gnu.org>
577
578 * floatfns.c (Fcopysign): Make the second argument non-optional,
579 since nil is not allowed anyway.
580
959ad23f
AS
5812012-01-21 Andreas Schwab <schwab@linux-m68k.org>
582
583 * process.c (read_process_output): Use p instead of XPROCESS (proc).
584 (send_process): Likewise.
585
34a02f46
MR
5862012-01-19 Martin Rudalics <rudalics@gmx.at>
587
588 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
589 (Vwindow_persistent_parameters): Do not use Qstate.
590 Rewrite doc-strings.
34a02f46 591
1259009a 5922012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
593
594 * character.c (char_width): New function.
70d4fdf6
GM
595 (Fchar_width, c_string_width, lisp_string_width):
596 Use char_width (Bug#9496).
25ed9e61 597
6a6ee00d
MR
5982012-01-16 Martin Rudalics <rudalics@gmx.at>
599
600 * window.c (Vwindow_persistent_parameters): New variable.
601 (Fset_window_configuration, save_window_save): Handle persistent
602 window parameters.
603
c85efaf7
EZ
6042012-01-14 Eli Zaretskii <eliz@gnu.org>
605
606 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
607 thrashing the stack of the thread. (Bug#9087)
608
5944709e
PE
6092012-01-12 Paul Eggert <eggert@cs.ucla.edu>
610
611 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
612
e71f5d99
EZ
6132012-01-11 Eli Zaretskii <eliz@gnu.org>
614
615 * xdisp.c (rows_from_pos_range): Handle the case where the
616 highlight ends on a newline. (Bug#10464)
617 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
618 he end column for display of highlight that ends on a newline
619 before a R2L line.
620
ce316182
GM
6212012-01-11 Glenn Morris <rgm@gnu.org>
622
623 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
624 from load-path also when installation-directory is nil. (Bug#10208)
625
5b43da69
GM
6262012-01-10 Glenn Morris <rgm@gnu.org>
627
74cc8ff9
GM
628 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
629
7d8d6e4e
GM
630 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
631 Update template values to be closer to their typical values these days.
5b43da69 632
a0db8d43
EZ
6332012-01-09 Eli Zaretskii <eliz@gnu.org>
634
635 * xdisp.c (rows_from_pos_range): Accept additional argument
636 DISP_STRING, and accept any glyph in a row whose object is that
637 string as eligible for mouse highlight. Fixes mouse highlight of
638 display strings from overlays. (Bug#10464)
639
9a0115ab 6402012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 641
b9110d6a 642 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
643 * fileio.c (auto_saving_dir_umask): New static var.
644 (Fmake_directory_internal): Use it.
645 (do_auto_save_make_dir): Set it, instead of invoking chmod after
646 creating the directory. The old code temporarily assigns
647 too-generous permissions to the directory.
648 (do_auto_save_eh): Clear it.
b9110d6a 649 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
650 that the var is always cleared.
651
6c1bd3f3
EZ
6522012-01-07 Eli Zaretskii <eliz@gnu.org>
653
654 * search.c (scan_buffer): Pass character positions to
655 know_region_cache, not byte positions. (Bug#6540)
656
069d2b50
L
6572012-01-07 LynX <_LynX@bk.ru> (tiny change)
658
659 * w32.c (sys_rename): Report EXDEV when rename of a directory
660 fails because the target is on another logical disk. (Bug#10284)
661
75bf0d33
DB
6622012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
663
664 * xterm.c (x_embed_request_focus): New function.
665
666 * xterm.h: Add prototype.
667
668 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
669
1c6e5a32
GM
6702012-01-05 Glenn Morris <rgm@gnu.org>
671
672 * emacs.c (emacs_copyright): Update short copyright year to 2012.
673
651e947e
EZ
6742012-01-01 Eli Zaretskii <eliz@gnu.org>
675
676 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
677 Load gnutls_transport_set_lowat only if GnuTLS version is below
678 2.11.1.
679 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
680 GnuTLS versions below 2.11.1.
681
3778cdd8
AL
6822011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
683
684 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
685 to the doc string advising against its use for altering the way
686 windows are scrolled.
687
0e5317f7
KH
6882011-12-28 Kenichi Handa <handa@m17n.org>
689
690 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
691 coding-system ASCII compatible only when it does not produce BOM
692 on encoding (Bug#10383).
693
93d5ca1f
JD
6942011-12-26 Jan Djärv <jan.h.d@swipnet.se>
695
696 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
697 can scroll.
698 (create_and_show_popup_menu): Always use menu_position_func for
699 Gtk3 (Bug#10361).
700
ca22b785
AS
7012011-12-24 Andreas Schwab <schwab@linux-m68k.org>
702
703 * callint.c (Fcall_interactively): Don't truncate prompt string.
704
d048e1e6
EZ
7052011-12-23 Eli Zaretskii <eliz@gnu.org>
706
707 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
708 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 709 resumed from there (after widening). (Bug#10360)
d048e1e6 710
5ccaba1f
JD
7112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
712
713 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
714
204ee57f
JD
7152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
716
b81d40f0
JB
717 * nsterm.m (x_free_frame_resources):
718 Release f->output_data.ns->miniimage.
204ee57f
JD
719 (ns_index_color): Fix indentation. Do not retain
720 color_table->colors[i].
721
722 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
723 before returning.
724
725 * nsfns.m (x_set_background_color): Assign return value from
726 ns_index_color to face-background instead of NSColor*.
727 (ns_implicitly_set_icon_type): Fix indentation.
728 Change assignment in for loop to comparison.
729
730 * emacs.c (ns_pool): New variable.
731 (main): Assign ns_pool.
732 (Fkill_emacs): Call ns_release_autorelease_pool.
733
734 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
735 autorelease fdesc, release fdAttrs and tdict.
736 (ns_get_covering_families): Release charset.
737 (ns_findfonts): Release NSFontDescriptor created with new.
738 (ns_uni_to_glyphs): Fix indentation.
739 (setString): Release attrStr before assigning new value.
740
c803b2b7
JD
7412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
742
678f4426
JD
743 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
744 and NS_IMPL_COCOA.
745 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
746 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
747
cd394be1 7482011-12-18 David Reitter <reitter@cmu.edu>
678f4426 749
5fecd5fc
JD
750 * nsterm.m (ns_term_init): Subscribe for notifications
751 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
752 to method trackingNotification in EmacsMenu.
753
754 * nsmenu.m (trackingMenu): New variable.
3771cb17 755 (trackingNotification): New method (from Aquamacs).
5fecd5fc 756 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 757 from Aquamacs (Bug#7030).
678f4426
JD
758
7592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 760
c803b2b7
JD
761 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
762 (symbol_to_nsstring): Fix indentation.
763 (ns_symbol_to_pb): New function.
cae07000
SM
764 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
765 (Fns_rotate_cut_buffers_internal): Remove.
766 (Fns_store_selection_internal): Rename from
c803b2b7
JD
767 Fns_store_cut_buffer_internal.
768 (ns_get_foreign_selection, Fx_own_selection_internal)
769 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
770 (Fns_get_selection_internal, Fns_store_selection_internal):
771 Use ns_symbol_to_pb and check if return value is nil.
772 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
773 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
774 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
775 renamed to Sns_store_selection_internal.
776 (ns_handle_selection_request): Move code to Fx_own_selection_internal
777 and remove this function.
778 (ns_handle_selection_clear): Remove, never used.
779 (Fx_own_selection_internal): Move code from ns_handle_selection_request
780 here.
781
e1b01a3a
KB
7822011-12-17 Ken Brown <kbrown@cornell.edu>
783
784 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
785 GID is unknown (Bug#10257).
786
2adb6e85
PE
7872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
788
789 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
790 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
791 which caused a build failure on GNU/Linux IA-64. This problem was
792 introduced by my 2011-10-07 patch.
793
d1d7b339
JL
7942011-12-15 Juri Linkov <juri@jurta.org>
795
796 * image.c (imagemagick_error): New function. (Bug#10112)
797 (imagemagick_load_image): Comment out `MagickSetResolution' call.
798 Use `imagemagick_error' where ImageMagick functions return
799 `MagickFalse'.
800 (Fimagemagick_types): Add `Fnreverse' to return the list in the
801 proper order.
802
100d5755
KH
8032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
804
805 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
806 fill background (Bug#8992).
807
454592a6
MR
8082011-12-13 Martin Rudalics <rudalics@gmx.at>
809
810 * window.c (Vwindow_combination_resize)
811 (Vwindow_combination_limit): Use t instead of non-nil in
812 doc-strings.
61d4b438
MR
813 (Vrecenter_redisplay): Add first sentence of doc-string on
814 separate line.
53524d93 815 (Frecenter): Fix doc-string typo.
454592a6 816
3633e3aa
KH
8172011-12-11 Kenichi Handa <handa@m17n.org>
818
819 * coding.c (Funencodable_char_position): Pay attention to the
820 buffer text relocation (Bug#9389).
821
7b9d523a
JD
8222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
823
824 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
825 gtk_init (Bug#10100).
826
b73189c6
EZ
8272011-12-10 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
830 IT->string is nil. (Bug#10263)
831
f7dfe5d6
JD
8322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
833
83faebb4
JD
834 * nsterm.h (x_free_frame_resources): Declare.
835
f7dfe5d6
JD
836 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
837 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
838
839 * nsterm.h (ns_get_defaults_value): Declare.
840
841 * nsterm.m (ns_default): Call ns_get_defaults_value.
842
7cd4e72c
EZ
8432011-12-09 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
846 (Bug#10170)
847
b34d7317
YM
8482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
849
850 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
851 that where the value of an _OBJC_* symbol points to is in the .bss
852 section (Bug#10240).
853
76470ad1
KH
8542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
855
856 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 857 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 858
745fff94
KH
8592011-12-08 Kenichi Handa <handa@m17n.org>
860
861 * ftfont.c (get_adstyle_property): Fix previous change
862 (Bug#10233).
863
6e44397c
JB
8642011-12-07 Juanma Barranquero <lekktu@gmail.com>
865
866 * w32.c (init_environment): If no_site_lisp, remove site-lisp
867 dirs from the default value of EMACSLOADPATH (bug#10208).
868
7efa6272
GM
8692011-12-07 Glenn Morris <rgm@gnu.org>
870
871 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
872 installation and source directories as well. (Bug#10208)
873
f6fc4d87
CY
8742011-12-06 Chong Yidong <cyd@gnu.org>
875
876 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
877
2bf26180
GM
8782011-12-06 Glenn Morris <rgm@gnu.org>
879
880 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
881 as an error, not just -1. (Bug#10217)
882
3a6ad4f0
CY
8832011-12-05 Chong Yidong <cyd@gnu.org>
884
885 * keyboard.c (process_special_events): New function.
886 (swallow_events, Finput_pending_p): Use it (Bug#10195).
887
75a3b399
PE
8882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
889
890 * coding.c (encode_designation_at_bol): Don't use uninitialized
891 local variable (Bug#9318).
892
c3c9e25e
KH
8932011-12-05 Kenichi Handa <handa@m17n.org>
894
895 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
896 return Qnil (Bug#8046, Bug#10193).
897
5eb05ea3
KH
8982011-12-05 Kenichi Handa <handa@m17n.org>
899
900 * coding.c (encode_designation_at_bol): New args charbuf_end and
901 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
902 (coding_set_source): Return how many bytes coding->source was
903 relocated.
904 (coding_set_destination): Return how many bytes
905 coding->destination was relocated.
906 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 907 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
908
9092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
910
911 * coding.c (CODING_CHAR_CHARSET_P): New macro.
912 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
913 macro (Bug#9318).
914
9152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
916
917 The following changes are to fix Bug#9318.
918
a79703f5 919 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
920 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
921 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 922 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 923
7dbda6df
JB
9242011-12-05 Juanma Barranquero <lekktu@gmail.com>
925
926 * lisp.h (process_quit_flag): Fix external declaration.
927
6d5eb5b0
SM
9282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
929
930 Don't macro-inline non-performance-critical code.
931 * eval.c (process_quit_flag): New function.
932 * lisp.h (QUIT): Use it.
933
a0c3fad0
JD
9342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
935
936 * nsfns.m (get_geometry_from_preferences): New function.
937 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
938
6c07aac2
AS
9392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
940
941 * emacs.c (Qkill_emacs): Define.
942 (syms_of_emacs): Initialize it.
943 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
944 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
945 (quit_throw_to_read_char): Add parameter `from_signal'.
946 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
947 * lisp.h (QUIT): Call Fkill_emacs if requested.
948
c052ead4
JD
9492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
950
951 * widget.c (update_wm_hints): Return if wmshell is null.
952 (widget_update_wm_size_hints): New function.
953
954 * widget.h (widget_update_wm_size_hints): Declare.
955
956 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
957 widget_update_wm_size_hints (Bug#10104).
958
9e49252b
EZ
9592011-12-03 Eli Zaretskii <eliz@gnu.org>
960
961 * xdisp.c (handle_invisible_prop): If the invisible text ends just
962 before a newline, prepare the bidi iterator for consuming the
963 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 964 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 965
02b16839
JL
9662011-12-02 Juri Linkov <juri@jurta.org>
967
968 * search.c (Fword_search_regexp): New Lisp function created from
969 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
970 (Fword_search_backward, Fword_search_forward)
971 (Fword_search_backward_lax, Fword_search_forward_lax):
972 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
973 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
974
0068070e
SM
9752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
976
977 * fileio.c (Finsert_file_contents): Move after-change-function call
978 to before the "handled:" label, since all "goto handled" appear in
979 cases where the *-change-functions have already been properly called
980 (bug#10117).
981
3360a3fc
AS
9822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
983
984 * keyboard.c (interrupt_signal): Don't call kill-emacs when
985 waiting for input. (Bug#10169)
986
73d6c093
EZ
9872011-11-30 Eli Zaretskii <eliz@gnu.org>
988
989 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
990 verifies glyph row's hash code--we have just reallocated the
991 glyphs, so their contents can be complete garbage. (Bug#10164)
992
febe6bea
JB
9932011-11-30 Juanma Barranquero <lekktu@gmail.com>
994
995 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
996
801a4313
EZ
9972011-11-30 Eli Zaretskii <eliz@gnu.org>
998
999 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1000 attributes are tested _before_ calling verify_row_hash, to protect
1001 against GCC re-ordering of the tests. (Bug#10164)
1002
2b56b87e
JD
10032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1004
1005 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1006
1007 * xterm.c (handle_one_xevent): Only set async_visible and friends
1008 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1009 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1010 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1011
dbf31225
PE
10122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1013
1014 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1015 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1016 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1017 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1018 All uses changed to use GCPRO1 etc.
1019 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1020 Revert to old implementation (i.e., before 2011-03-11).
1021
1305621b
YM
10222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1023
1024 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1025 of scroll runs so as to avoid assigning disabled bogus rows and
1026 unnecessary graphics copy operations.
1027
8c9afb46
EZ
10282011-11-27 Eli Zaretskii <eliz@gnu.org>
1029
1030 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1031 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1032 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1033 (malloc, free, realloc, calloc): Redirect to e_* only when
1034 compiling Emacs.
1035
1036 * lisp.h (GCTYPEBITS): Move before first use.
1037 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1038 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1039 this macro definition.
1040
1041 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1042 _MSC_VER.
1043
54e9e3bf
JD
10442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1045
6d5eb5b0
SM
1046 * gtkutil.c (xg_create_frame_widgets):
1047 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1048 present with Gtk+ 2.0.
1049
83aca1cb
PE
10502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 * fileio.c (Finsert_file_contents): Undo previous change; see
1053 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1054
5b76caa4
PE
10552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1056
1057 Rename locals to avoid shadowing.
1058 * fileio.c (Finsert_file_contents):
1059 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1060 * process.c (wait_reading_process_output):
1061 Rename inner 'proc' to 'p' to avoid shadowing.
1062 Indent for consistency with usual Emacs style.
1063
8c535114
EZ
10642011-11-25 Eli Zaretskii <eliz@gnu.org>
1065
1066 * xdisp.c (redisplay_window): If cursor row is not fully visible
1067 after recentering, and scroll-conservatively is set to a large
1068 number, scroll window by a few more lines to make the cursor fully
1069 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1070 (start_display): Don't move to the next line if the display should
1071 start at a newline that is part of a display vector or an overlay
1072 string. (Bug#10119)
8c535114 1073
fa4fdb5c
JL
10742011-11-24 Juri Linkov <juri@jurta.org>
1075
1076 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1077 after the `MagickPingImage' call. (Bug#10112)
1078
90ec88df
CY
10792011-11-23 Chong Yidong <cyd@gnu.org>
1080
1081 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1082
56e2e794
MR
10832011-11-23 Martin Rudalics <rudalics@gmx.at>
1084
1085 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1086 making another buffer current. (Bug#10114)
1087
b6e64c41
GM
10882011-11-23 Glenn Morris <rgm@gnu.org>
1089
1090 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1091
6b21de18
CY
10922011-11-23 Chong Yidong <cyd@gnu.org>
1093
1094 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1095 using it (Bug#5984).
1096
b12cd789
EZ
10972011-11-22 Eli Zaretskii <eliz@gnu.org>
1098
1099 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1100 and header-lines, as they don't have one computed for them.
1101 (Bug#10098)
1102
1103 * .gdbinit (prow): Make displayed values more self-explaining.
1104 Add row's hash code.
1105
261b6fd4
LMI
11062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1107
1108 * process.c (wait_reading_process_output): Fix asynchrounous
1109 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1110 (wait_reading_process_output): Add comment and URL.
261b6fd4 1111
e7cfd277
JD
11122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1113
1114 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1115
a9b9b7f5
CY
11162011-11-21 Chong Yidong <cyd@gnu.org>
1117
1118 * window.c (Fnext_window, Fprevious_window): Doc fix.
1119
b0d15b4f
SM
11202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1121
1122 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1123
fe7a3057
JB
11242011-11-20 Juanma Barranquero <lekktu@gmail.com>
1125
1126 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1127
d2999b1a
MR
11282011-11-20 Martin Rudalics <rudalics@gmx.at>
1129
1130 * window.c (Fset_window_combination_limit): Rename argument
1131 STATUS to LIMIT.
1132 (Vwindow_combination_limit): Remove "status" from doc-string.
1133
d5ff9cd0
AS
11342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1135
1136 * m/ibms390.h: Remove.
1137 * m/ibms390x.h: Don't include "ibms390.h".
1138
a5bb9bd3
SM
11392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1140
1141 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1142 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1143
cd1181db
JB
11442011-11-20 Juanma Barranquero <lekktu@gmail.com>
1145
1146 * casetab.c (Fset_case_table):
1147 * charset.c (Fcharset_after): Fix typos.
1148
615a3b8d 11492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1150
17e845af
PE
1151 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1152 Otherwise, valgrind does not work on some platforms.
1153 Problem reported by Andreas Schwab in
6a0bf43d
PE
1154 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1155 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1156 is set, removing the need for VIRT_ADDRESS_VARIES.
1157 (PURE_P): Use a more-efficient implementation that needs just one
1158 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1159 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1160 to 4 (xorl, subq, cmpq, setbe).
1161 * alloc.c (pure): Always extern now, since that's the
1162 VIRT_ADDR_VARIES behavior.
1163 (PURE_POINTER_P): Use a single comparison, not two, for
1164 consistency with the new puresize.h.
1165 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1166 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1167 Remove VIRT_ADDR_VARIES no longer needed.
1168
f8fe6f96
EZ
11692011-11-19 Eli Zaretskii <eliz@gnu.org>
1170
1171 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1172 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1173 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1174 behave as if the cursor position were at the window margin.
1175
1176 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1177 and the cursor position is out of bounds, behave as if the cursor
1178 position were at the window margin. (Bug#10075)
1179
df05a53c
CY
11802011-11-18 Chong Yidong <cyd@gnu.org>
1181
1182 * window.c (Fwindow_combination_limit): Make first argument
1183 non-optional, since it is meaningless for live windows like the
1184 selected window.
1185
2071918e
DA
11862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1189
b50a28de
SM
11902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1191
1192 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1193 (graft_intervals_into_buffer): Simplify.
1194
015137db
EZ
11952011-11-18 Eli Zaretskii <eliz@gnu.org>
1196
1197 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1198 hash values of the two rows.
1199 (copy_row_except_pointers): Preserve the used[] arrays and the
1200 hash values of the two rows. (Bug#10035)
68c95424 1201 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1202
1203 * xdisp.c (row_hash): New function, body extracted from
1204 compute_line_metrics.
1205 (compute_line_metrics): Call row_hash, instead of computing the
1206 hash code inline.
1207
1208 * dispnew.c (verify_row_hash): Call row_hash for computing the
1209 hash code of a row, instead of duplicating code from xdisp.c.
1210
1211 * dispextern.h (row_hash): Add prototype.
1212
a2addb04
TH
12132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1214
1215 * frame.c (delete_frame): Don't delete the terminal when the last
1216 X frame is closed if emacs is built with GTK toolkit.
1217
df85d315
JB
12182011-11-17 Juanma Barranquero <lekktu@gmail.com>
1219
1220 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1221
a0c2d0ae
MR
12222011-11-17 Martin Rudalics <rudalics@gmx.at>
1223
1224 * window.c (Vwindow_splits): Rename to
1225 Vwindow_combination_resize. Suggested by Juri Linkov.
1226 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1227 of Vwindow_splits.
1228
58179cce
JB
12292011-11-16 Juanma Barranquero <lekktu@gmail.com>
1230
7877f373
JB
1231 * nsfns.m (Fns_font_name):
1232 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1233
b6f67890
MR
12342011-11-16 Martin Rudalics <rudalics@gmx.at>
1235
1236 * window.h (window): Rename slot "nest" to "combination_limit".
1237 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1238 (Fset_window_nest): Rename to Fset_window_combination_limit.
1239 (Vwindow_nest): Rename to Vwindow_combination_limit.
1240 (recombine_windows, make_parent_window, make_window)
1241 (Fsplit_window_internal, saved_window)
1242 (Fset_window_configuration, save_window_save): Rename all
1243 occurrences of window_nest to window_combination_limit.
1244
c7015153
JB
12452011-11-15 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * image.c (imagemagick_load_image): Fix typo.
1248
322ad6ec
EZ
12492011-11-14 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (display_line): Move the call to
1252 highlight_trailing_whitespace before the call to
1253 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1254 faces of all the glyphs to compute ROW's hash value.
1255 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1256
f067b8ec
JB
12572011-11-14 Juanma Barranquero <lekktu@gmail.com>
1258
1259 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1260 just return (bug#10044).
1261
1e5b2111
EZ
12622011-11-12 Eli Zaretskii <eliz@gnu.org>
1263
7ef3cbd5
EZ
1264 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1265 with user-defined heap size. Bump the default size of the temacs
1266 heap to 27MB, to avoid memory warning when running temacs.
1267 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1268
1e5b2111
EZ
1269 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1270 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1271 (verify_row_hash) [XASSERTS]: New function.
1272 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1273 that the hash value of glyph rows is correct.
1e5b2111 1274
89d61221
MR
12752011-11-12 Martin Rudalics <rudalics@gmx.at>
1276
1277 * window.h (window): Remove splits slot.
1278 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1279 (Fdelete_other_windows_internal, make_parent_window)
1280 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1281 (Fset_window_configuration, save_window_save): Don't deal with
1282 split status of windows.
1283 (saved_window): Remove splits slot.
1284 (Vwindow_splits): Rewrite doc-string.
1285
97f18cc8
JD
12862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1287
1288 * xfns.c (unwind_create_frame):
1289 * nsfns.m (unwind_create_frame):
1290 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1291 Vframe_list (Bug#9999).
1292
22a648b4
DA
12932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1294
0b381c7e 1295 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1296
659afede
KH
12972011-11-11 Kenichi Handa <handa@m17n.org>
1298
1299 * callproc.c (Fcall_process): Set the member dst_multibyte of
1300 process_coding.
1301
9ac0394b
KH
13022011-11-11 Johan Bockgård <bojohan@gnu.org>
1303
1304 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1305 avoid a crash (bug#9496).
1306
2fbdc249
CY
13072011-11-09 Chong Yidong <cyd@gnu.org>
1308
1309 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1310 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1311
ac6b1f81
PE
13122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1315
09db192c
PE
13162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 Avoid some portability problems by eschewing 'extern inline' functions.
1319 The trivial performance wins aren't worth the portability hassles; see
1320 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1321 et seq.
1322 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1323 (window_box_width, window_box_left, window_box_left_offset)
1324 (window_box_right, window_box_right_offset): Undo previous change,
1325 by removing the "extern"s.
1326 * intervals.c (adjust_intervals_for_insertion)
1327 (adjust_intervals_for_deletion): Undo previous change,
1328 making these static again.
1329 (offset_intervals, temp_set_point_both, temp_set_point)
1330 (copy_intervals_to_string): No longer inline.
1331 * xdisp.c (window_text_bottom_y, window_box_width)
1332 (window_box_height, window_box_left_offset)
1333 (window_box_right_offset, window_box_left, window_box_right)
1334 (window_box): No longer inline.
1335
105216ed
CY
13362011-11-08 Chong Yidong <cyd@gnu.org>
1337
1338 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1339 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1340 Signal an error if not a live window.
105216ed
CY
1341 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1342 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1343
ae9e237f
JB
13442011-11-07 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * lisp.h (syms_of_abbrev): Remove declaration.
1347 Reported by CHENG Gao <chenggao@royau.me>.
1348
c7aa8333
EZ
13492011-11-07 Eli Zaretskii <eliz@gnu.org>
1350
1351 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1352 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1353 of temacs in GUI mode.
1354
be7f5545
MR
13552011-11-07 Martin Rudalics <rudalics@gmx.at>
1356
1357 * window.h: Declare delete_all_child_windows instead of
1358 delete_all_subwindows.
1359 * window.c (Fwindow_nest, Fset_window_nest)
1360 (Fset_window_new_total, Fset_window_new_normal)
1361 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1362 (delete_all_subwindows): Rename to delete_all_child_windows.
1363 (Fdelete_other_windows_internal, Fset_window_configuration):
1364 Call delete_all_child_windows instead of delete_all_subwindows.
1365 * frame.c (delete_frame): Call delete_all_child_windows instead
1366 of delete_all_subwindows.
1367
ca78dc43
PE
13682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1371 This is also needed for porting to any host where GC_MARK_STACK is
1372 not GC_MAKE_GCPROS_NOOPS.
1373 (which_symbols): Use it.
1374
a0241d01
KH
13752011-11-07 Kenichi Handa <handa@m17n.org>
1376
1377 * coding.c (coding_set_destination): Check coding->src_pos only
1378 when coding->src_object is a buffer (bug#9910).
1379
1380 * process.c (send_process): Set the member src_multibyte of coding
1381 to 0 (bug#9911) when sending a unibyte text.
1382
1383 * callproc.c (Fcall_process): Set the member src_multibyte of
1384 process_coding to 0 (bug#9912).
1385
a64bfdfa 13862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1387
1388 * xmenu.c (cleanup_widget_value_tree): New function.
1389 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1390 calling free_menubar_widget_value_tree directly (Bug#9830).
1391
cb41b32a
PE
13922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 Fix some portability problems with 'inline'.
1395 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1396 (window_box_width, window_box_left, window_box_left_offset)
1397 (window_box_right, window_box_right_offset): Declare extern.
1398 Otherwise, these inline functions do not conform to C99 and
1399 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1400 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1401 * intervals.c (adjust_intervals_for_insertion)
1402 (adjust_intervals_for_deletion): Now extern, because otherwise the
1403 extern inline functions 'offset_intervals' couldn't refer to it.
1404 (static_offset_intervals): Remove.
1405 (offset_intervals): Rewrite using the old contents of
1406 static_offset_intervals. The old version didn't conform to C99
1407 because an extern inline function contained a reference to an
1408 identifier with static linkage.
1409
b7041366
AS
14102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1411
1412 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1413 GC.
1414
88a37c4d
EZ
14152011-11-06 Eli Zaretskii <eliz@gnu.org>
1416
1417 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1418 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1419 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1420 return Qleft_to_right.
1421
49745b39
CY
14222011-11-06 Chong Yidong <cyd@gnu.org>
1423
1424 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1425 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1426 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1427 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1428 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1429 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1430 (Fwindow_vscroll): Doc fix.
1431 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1432 argument, since it makes no sense to pass a live window and for
1433 consistency with window-child.
1434
1f05cd82
CS
14352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1436
1437 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1438 support MSVC.
1439
22610910
JR
14402011-11-05 Jason Rumney <jasonr@gnu.org>
1441
1442 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1443 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1444 fonts (Bug#6029).
1445 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1446 bitwise arithmetic preventing use of unicode-sip and non-truetype
1447 opentype fonts.
1448
a06776b2
EZ
14492011-11-05 Eli Zaretskii <eliz@gnu.org>
1450
3ad924ba
EZ
1451 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1452 "emacs"-only part.
1453
a06776b2
EZ
1454 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1455 initialization code to keep similarity to xfns.c after changes
1456 from 2011-11-05.
1457
c9e7db78
JD
14582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1459
a97f8f3f
JD
1460 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1461 (unwind_create_frame): New function (Bug#9943).
1462 (Fx_create_frame): Restructure code to be more similar to the one in
1463 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1464 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1465 Move terminal->reference_count++ just before making the frame official
1466 (Bug#9943).
1467
1468 * nsterm.m (x_free_frame_resources): New function.
1469 (x_destroy_window): Move code to x_free_frame_resources.
1470
c9e7db78 1471 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1472 (Fx_create_frame, x_create_tip_frame):
1473 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1474 official. Move initialization of image_cache_refcount and
1475 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1476
a6fc3b5c
EZ
14772011-11-05 Eli Zaretskii <eliz@gnu.org>
1478
1479 Support MSVC build with newer versions of Visual Studio.
1480 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1481 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1482 nt/gmake.defs.
1483
1484 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1485 which are not supported by MSVC.
1486 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1487 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1488 bitfields.
1489 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1490 types in bitfields.
1491 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1492
1493 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1494
58179cce 14952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1496
1497 Support MSVC build with newer versions of Visual Studio.
1498 * w32.c: Don't include w32api.h for MSVC.
1499 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1500
1501 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1502 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1503 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1504 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1505 e_* cousins.
1506 (alloca) [_MSC_VER]: Define to _alloca.
1507
1508 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1509
1510 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1511
a58c13ed
EZ
15122011-11-04 Eli Zaretskii <eliz@gnu.org>
1513
1514 * xdisp.c (note_mouse_highlight): If either of
1515 previous/next-single-property-change returns nil, treat that as
1516 the beginning or the end of the buffer. (Bug#9955)
1517
fe0b6370
JD
15182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1519
a58c13ed 1520 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1521 label is not null (Bug#9951).
1522 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1523 may be NULL.
1524
89bd5ee1
EZ
15252011-11-04 Eli Zaretskii <eliz@gnu.org>
1526
1527 * window.c (Fwindow_body_size): Mention in the doc string that the
1528 return value is in frame's canonical units. (Bug#9949)
1529
84c3edb9
EZ
15302011-11-03 Eli Zaretskii <eliz@gnu.org>
1531
4e2fb5c7
EZ
1532 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1533
84c3edb9 1534 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1535 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1536 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1537
bc17a887
EZ
15382011-11-01 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1541 Don't stop backward scan on the continuation glyph, even though
1542 its CHARPOS is positive.
6d5eb5b0
SM
1543 (mouse_face_from_buffer_pos, note_mouse_highlight):
1544 Rename cover_string to disp_string.
bc17a887 1545
4ee88440
MR
15462011-11-01 Martin Rudalics <rudalics@gmx.at>
1547
1548 * window.c (temp_output_buffer_show): Don't use
1549 Vtemp_buffer_show_specifiers.
1550 (Vtemp_buffer_show_specifiers): Remove unused variable.
1551
c2ff3c02
EZ
15522011-10-30 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1555 past the beginning of the current glyph matrix.
1556
58179cce 15572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1558
1559 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1560 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1561 HAVE_GTK3 (Bug#9869).
b77a6a7f 1562
3b574623
JD
1563 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1564 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1565
b77a6a7f
JD
1566 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1567
1568 * xterm.c: Declare x_handle_net_wm_state to return int.
1569 (handle_one_xevent): Check if we are iconified but don't have
1570 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1571 (get_current_wm_state): Return non-zero if not hidden,
1572 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1573 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1574 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1575 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1576
196e41e4
PE
15772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1578
1579 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1580 so that this new function doesn't get optimized away by a
1581 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1582
021f2e1a
AS
15832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1584
1585 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1586
8b058d44
EZ
15872011-10-29 Eli Zaretskii <eliz@gnu.org>
1588
1589 Fix the `xbytecode' command.
1590 * .gdbinit (xprintbytestr): New command.
b50a28de 1591 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1592 (xbytecode): Print the byte-code string as well.
1593
4452fb80
EZ
15942011-10-29 Kim Storm <storm@cua.dk>
1595
8b058d44
EZ
1596 * alloc.c (which_symbols): New function.
1597
21b72067
AS
15982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1599
1600 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1601 line. (Bug#9903)
1602
83ed7b5c
GM
16032011-10-29 Glenn Morris <rgm@gnu.org>
1604
1605 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1606 Not clear what it was for, and it causes various bugs. (Bug#9839)
1607
5a7a728b
EZ
16082011-10-28 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1611 possible random value that matches one of those tested as
1612 condition to clear the mouse face.
1613
d3d0842f
CY
16142011-10-28 Chong Yidong <cyd@gnu.org>
1615
1616 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1617
31b39d13
DN
16182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1619
1620 * window.c (make_window): Initialize phys_cursor_on_p.
1621
9aba6043
SM
16222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1623
1624 * lisp.h (struct Lisp_Symbol): Update comments.
1625
c20992f4
JB
16262011-10-28 Juanma Barranquero <lekktu@gmail.com>
1627
1628 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1629
db4f02f2
EZ
16302011-10-28 Eli Zaretskii <eliz@gnu.org>
1631
1632 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1633 <oslsachem@gmail.com> for helping to debug this.
1634
1635 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1636 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1637 (g_b_init_get_glyph_outline_w): New static variables.
1638 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1639 (GetGlyphOutlineW_Proc): New typedefs.
1640 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1641 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1642 New functions.
1643 (w32font_open_internal, compute_metrics):
1644 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1645 instead of calling the "wide" APIs directly.
1646
1647 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1648
1649 * w32.h (syms_of_w32font): Add prototype.
1650
87e68db4
JB
16512011-10-27 Juanma Barranquero <lekktu@gmail.com>
1652
1653 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1654 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1655 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1656 (Fmove_to_window_line): Doc fix.
1657
435c1d67
CY
16582011-10-27 Chong Yidong <cyd@gnu.org>
1659
1660 * process.c (make_process): Set gnutls_state to NULL.
1661
1662 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1663 non-NULL, regardless of GNUTLS_INITSTAGE.
1664 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1665 an error. Set process slots as soon as we allocate them.
1666
1667 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1668
9c6c6f49
CY
16692011-10-27 Chong Yidong <cyd@gnu.org>
1670
9aba6043
SM
1671 * gnutls.c (emacs_gnutls_deinit): New function.
1672 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1673 (Fgnutls_deinit, Fgnutls_boot): Use it.
1674
1675 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1676 (deactivate_process): Call emacs_gnutls_deinit.
1677
657d08d3
JB
16782011-10-27 Juanma Barranquero <lekktu@gmail.com>
1679
1680 * image.c (x_create_x_image_and_pixmap):
1681 * w32.c (sys_rename, w32_delayed_load):
1682 * w32font.c (fill_in_logfont):
1683 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1684
5430d399
JB
16852011-10-26 Juanma Barranquero <lekktu@gmail.com>
1686
1687 * w32fns.c (w32_default_color_map): New function,
1688 extracted from Fw32_default_color_map.
a7ef684b 1689 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1690
fe0055fa
PE
16912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1694
e6346438
SM
16952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1696
1697 * keyboard.c (test_undefined): New function (bug#9751).
1698 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1699
e112cc37
ET
17002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1701
1702 * sysdep.c (init_sys_modes): Fix the check for the controlling
1703 terminal (Bug#6649).
1704
7b5d6677
EZ
17052011-10-20 Eli Zaretskii <eliz@gnu.org>
1706
1707 * dispextern.h (struct bidi_it): New member next_en_type.
1708
1709 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1710 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1711 current character, check also for next_en_type being WEAK_EN.
1712 (bidi_resolve_weak): Don't enter the expensive loop if the current
1713 position is before next_en_pos. Record the bidi type of the first
1714 non-ET, non-BN character we find, in addition to its position.
1715 (bidi_level_of_next_char): Invalidate next_en_type when
1716 next_en_pos is over-stepped.
1717
7da0b018
PE
17182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1719
1720 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1721 * editfns.c: Rewrite current-time-zone so that it invokes
1722 the equivalent of (format-time-string "%Z") to get the time zone name.
1723 This fixes a bug when the time zone name contains characters that
1724 need converting from the system time locale to Emacs internal format.
1725 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1726 that patch fixed format-time-string to do the conversion, but
1727 I forgot to fix current-time-zone.
1728 (format_time_string): New function, containing most of
1729 what Fformat_time_string used to contain.
1730 (Fformat_time_string): Rewrite in terms of format_time_string.
1731 This doesn't change this function's behavior.
1732 (current-time-zone): Rewrite to use format_time_string.
1733 This fixes the bug reported by Michael Schierl in
1734 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1735 Jason Rumney's 2007-06-07 change worked around this bug, but
1736 didn't fix it.
1737 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1738
8547b010
EZ
17392011-10-19 Eli Zaretskii <eliz@gnu.org>
1740
1741 * xdisp.c (start_display): If the character at POS is displayed
1742 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1743 (try_window_reusing_current_matrix): If a line ends in a display
1744 vector or the next line starts in a display vector, continue
1745 redrawing the window even though the character position of
1746 start_row was reached.
8547b010
EZ
1747 (Bug#9771, part 2)
1748
4e948d15
CY
17492011-10-18 Chong Yidong <cyd@gnu.org>
1750
1751 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1752 with nobreak-char-display too.
1753
4787455f
EZ
17542011-10-18 Eli Zaretskii <eliz@gnu.org>
1755
1756 Fix part 3 of bug#9771.
1757 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1758 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1759 non-neutral characters if the current character is a paragraph
1760 separator (a.k.a. Newline). This avoids running the same
1761 expensive loop twice, once when we consume the preceding newline
1762 and the other time when the line actually needs to be displayed.
1763 Avoid the loop when we see neutrals on the base embedding level
1764 following a character whose directionality is the same as the
1765 paragraph's. This avoids running the expensive loop when a line
1766 ends in a long sequence of neutrals, like control characters.
1767 Add assertion against STRONG_AL type. Slightly rearrange code
1768 that determines the type of a neutral given the first non-neutral
1769 that follows it.
1770 (bidi_level_of_next_char): Set next_en_pos to zero when
1771 invalidating its info.
1772
2c91f553
EZ
17732011-10-17 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (push_display_prop): Determine whether to record string
1776 or buffer position by IT->string, not by IT->method. Allow
1777 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1778 (move_it_vertically_backward): Don't look for character position
1779 immediately after the newline when in a continuation line.
1780 (Bug#9771, part 1)
2c91f553 1781
c7b08b0d
MR
17822011-10-15 Martin Rudalics <rudalics@gmx.at>
1783
1784 * window.c (coordinates_in_window): Rewrite and delabelize
1785 vertical border check. (Bug#5357) (Bug#9618)
1786
6b02f655
SM
17872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1788
1789 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1790 errors in XSetWindowBorder (bug#9310).
1791
81d40c92
DA
17922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1795 avoid crash when xmalloc overrun checking is enabled.
1796
d4172c3b
EZ
17972011-10-13 Eli Zaretskii <eliz@gnu.org>
1798
1799 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1800 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1801 cursor motion with <left> and <right> arrow keys.
1802
1803 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1804 some callers set that themselves.
1805
b00eea75
EZ
18062011-10-12 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1809 display string and the previous row comes from the same string and
1810 is empty. (Bug#9739) (Bug#9738)
1811
8fe012c4
SM
18122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * doc.c (get_doc_string): Encode file name (bug#9735).
1815
0074aef2
EZ
18162011-10-12 Eli Zaretskii <eliz@gnu.org>
1817
79beb178
EZ
1818 * bidi.c (bidi_level_of_next_char):
1819 * xdisp.c (get_visually_first_element): Remove old incorrect
1820 comments regarding the Unicode Line Separator character.
1821
0074aef2
EZ
1822 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1823
6e4b3fbe
DA
18242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1825
1826 * alloc.c (Fgc_status): Do not access beyond zombies array
1827 boundary if nzombies > MAX_ZOMBIES.
1828 * alloc.c (dump_zombies): Add missing format specifier.
1829
0324f3af
PE
18302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1831
b5525cac
PE
1832 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1833 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1834
0324f3af
PE
1835 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1836 Some packages use them to denote characters with modifiers.
1837
e9b5f888
AS
18382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1839
1840 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1841 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1842 matching a pp-number. Rename parameter var to var1.
1843
127827c0
SM
18442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1845
1846 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1847
c8fd3bd0
GM
18482011-10-08 Glenn Morris <rgm@gnu.org>
1849
1850 * callint.c (Fcall_interactively): Give a more explicit error for the
1851 'c' case with a non-character input. (Bug#8479)
1852
352ec8ff
EZ
18532011-10-08 Eli Zaretskii <eliz@gnu.org>
1854
03669ccb
EZ
1855 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1856 lines.
7061c986
EZ
1857 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1858 lines that are hscrolled on the left.
03669ccb 1859
352ec8ff
EZ
1860 * dispnew.c (buffer_posn_from_coords): Account for a possible
1861 presence of header-line. (Bug#4426)
1862
a66cfb1c
SM
18632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1864
6b02f655
SM
1865 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1866 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1867
7c5ee88e
PE
18682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1871 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1872 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1873 this makes Emacs dump core during garbage collection on rare
1874 occasions. sizeof is obviously inferior to offsetof here, so
1875 stick with offsetof.
1876 (GC_POINTER_ALIGNMENT): New macro.
1877 (mark_memory): Omit 3rd (offset) arg; caller changed.
1878 Don't assume EMACS_INT alignment is the same as pointer alignment.
1879
df1bbe5b
SM
18802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1881
1882 * keyboard.c (read_key_sequence_remapped): New var.
1883 (read_key_sequence): Compute remapping in the right buffer.
1884 (command_loop_1): Use read_key_sequence's remapping directly.
1885
51553db6
SM
18862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1887
32c1fffd
SM
1888 * dired.c (file_name_completion): Don't expand file name.
1889 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1890 before checking file name handler.
1891
51553db6
SM
1892 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1893 they've been requested explicitly (bug#9591).
1894
b6bd1599 18952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1896
1897 * keymap.c (Fsingle_key_description): Use make_specified_string
1898 instead of build_string to build string from push_key_description.
1899 (Bug#5193)
1900
f701dc2a
PE
19012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1902
4222c55d
PE
1903 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1904 This fixes a Y2038 bug on 64-bit hosts.
1905 * buffer.c (reset_buffer):
1906 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1907 (Fclear_buffer_auto_save_failure):
1908 Use 0, not -1, to represent an unset failure time, since time_t
1909 might not be signed.
1910
f701dc2a
PE
1911 Remove dependency on glibc malloc internals.
1912 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1913 Move back here from lisp.h, but with their new implementations.
1914 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1915 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1916 * charset.c (charset_table_init): New static var.
1917 (syms_of_charset): Use it instead of xmalloc. This removes a
1918 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1919 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1920 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1921 Move back to alloc.c.
1922 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1923 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1924
9ceebf39
JD
19252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1926
1927 * nsterm.m (windowDidResize): Call x_set_window_size only when
1928 ns_in_resize is true. Otherwise set pixelwidth/height and
1929 call change_frame_size (Bug#9628).
1930
cb993c58
PE
19312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1932
3930c88b
PE
1933 Port --enable-checking=all to Fedora 14 x86-64.
1934 * charset.c (syms_of_charset): Also account for glibc malloc's
1935 internal overhead when calculating the initial malloc maximum.
1936
cb993c58
PE
1937 Port --enable-checking=all to Fedora 14 x86.
1938 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1939 Move to lisp.h.
1940 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1941 (overrun_check_realloc, overrun_check_free):
1942 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1943 That way, xmalloc returns a properly-aligned pointer even if
1944 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1945 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1946 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1947 into account when calculating the initial malloc maximum.
1948 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1949 Move here from alloc.c, so that charset.c can use it too.
1950 Properly align; the old code wasn't right for common 32-bit hosts
1951 when configured with --enable-checking=all.
1952 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1953 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1954
31bed486
EZ
19552011-09-29 Eli Zaretskii <eliz@gnu.org>
1956
04c70788 1957 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1958 use EDOM.
1959
fbcaa2f3
EZ
19602011-09-28 Eli Zaretskii <eliz@gnu.org>
1961
1962 * xdisp.c (compute_display_string_end): If there's no display
1963 string at CHARPOS, return -1.
1964
1965 * bidi.c (bidi_fetch_char): When compute_display_string_end
1966 returns a negative value, treat the character as a normal
1967 character not covered by a display string. (Bug#9624)
1968
a239d4e9
JB
19692011-09-28 Juanma Barranquero <lekktu@gmail.com>
1970
1971 * lread.c (Fread_from_string): Fix typo in docstring.
1972
88652fd5
EZ
19732011-09-27 Eli Zaretskii <eliz@gnu.org>
1974
1975 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1976 newline, reseat the iterator instead of bidi-iterating there one
1977 character at a time. (Bug#9610)
32c1fffd
SM
1978 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1979 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1980
ed497dd4
AS
19812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1982
1983 * lread.c (readevalloop): Use correct code for NBSP.
1984 (read1): Likewise. (Bug#9608)
1985
b2bf61aa
MA
19862011-09-25 Michael Albinus <michael.albinus@gmx.de>
1987
1988 * dbusbind.c (Fdbus_register_signal): When service is not
1989 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1990
32bbb17c
GM
19912011-09-25 Glenn Morris <rgm@gnu.org>
1992
1993 * buffer.c (truncate-lines): Doc fix.
1994
94e0933e
CY
19952011-09-24 Chong Yidong <cyd@stupidchicken.com>
1996
1997 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1998 (Fset_window_next_buffers): Doc fix.
1999
cddde921
GM
20002011-09-24 Glenn Morris <rgm@gnu.org>
2001
2002 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2003
1260aef1
PE
20042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2005
25b4bfa0
PE
2006 Fix minor problems found by static checking.
2007 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2008 * indent.c (Fvertical_motion): Fix == vs = typo.
2009
e3cbd34b
EZ
20102011-09-24 Eli Zaretskii <eliz@gnu.org>
2011
a66cfb1c
SM
2012 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2013 Default value is now t. Doc fix.
6bf7006f 2014
e3cbd34b 2015 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2016 logic when moving up, not only when moving down. Fix the
e3cbd34b 2017 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2018 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2019
2020 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2021 CHARPOS is covered by a display string which includes newlines.
2022 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2023 is covered by a display string with embedded newlines.
2024
a3de0cbd
MA
20252011-09-24 Michael Albinus <michael.albinus@gmx.de>
2026
2027 * dbusbind.c (Fdbus_register_signal): Add match rule to
2028 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2029 (Fdbus_register_method, Vdbus_registered_objects_table):
2030 Fix docstring.
a3de0cbd 2031
b260039d
JM
20322011-09-24 Jim Meyering <meyering@redhat.com>
2033
32c1fffd 2034 do not ignore write error for any output size
b260039d
JM
2035 The previous change was incomplete.
2036 While it makes emacs --batch detect the vast majority of stdout
2037 write failures, errors were still ignored whenever the output size is
2038 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2039 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2040 && echo FAIL: ignored write error
2041 FAIL: ignored write error
2042 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2043 && echo FAIL: ignored write error
2044 FAIL: ignored write error
2045 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2046
8eca8a7c
AS
20472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2048
2049 * emacs.c (Fkill_emacs): In noninteractive mode exit
2050 non-successfully if a write error occurred on stdout. (Bug#9574)
2051
3341db62
EZ
20522011-09-21 Eli Zaretskii <eliz@gnu.org>
2053
2054 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2055 the xassert test.
2056
2057 * dispextern.h (struct it): Update the comment documenting what
2058 can it->OBJECT be.
2059
8c203dbf
EZ
20602011-09-20 Eli Zaretskii <eliz@gnu.org>
2061
2062 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2063 a display string, extend search for cursor position to end of row.
2064 (find_row_edges): If the row ends in a newline from a display
2065 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2066 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2067 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2068 non-empty line. Fixes confusing cursor motion with arrow keys at
2069 the beginning of a line that starts with whitespace.
8c203dbf 2070
a4824228
LMI
20712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2072
2073 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2074 (bug#9493).
2075
33ed493b
CY
20762011-09-18 Chong Yidong <cyd@stupidchicken.com>
2077
2078 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2079 boolean (Bug#9154).
2080
56cd55c8
EZ
20812011-09-18 Eli Zaretskii <eliz@gnu.org>
2082
2083 * xdisp.c (display_line): Record maximum and minimum buffer
2084 positions even if no glyphs were produced (e.g., by a zero-width
2085 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2086 buffer positions that will be removed from the glyph row because
2087 they don't fit.
c02dcedf
EZ
2088 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2089 column is beyond frame width: don't subtract 1 "pixel" when
2090 computing width of the stretch.
3e62b7e0
EZ
2091 (reseat_at_next_visible_line_start): Undo the change made on
2092 2011-09-17 that saved paragraph information and restored it after
2093 the call to `reseat'. (Bug#9545)
56cd55c8 2094
5ed99d36 20952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2096
2097 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2098 and turn window cursor on if cleared (Bug#9415).
2099
5ed99d36 21002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2101
2102 * search.c (boyer_moore): Take unibyte characters from pattern
2103 literally. (Bug#9458)
2104
9bade7b2
EZ
21052011-09-18 Eli Zaretskii <eliz@gnu.org>
2106
2107 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2108
e5e9d610
PE
21092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2110
87e4427a
PE
2111 Fix minor problem found by static checking.
2112 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2113 initialized, to pacify gcc -Wuninitialized.
2114
e5e9d610
PE
2115 * fileio.c: Report proper errno when syscall falls.
2116 (Finsert_file_contents): Save and restore errno,
2117 so that report_file_error outputs the correct diagnostic.
2118 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2119
a1674f0b
EZ
21202011-09-18 Eli Zaretskii <eliz@gnu.org>
2121
2122 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2123
fbfb6dd4
EZ
21242011-09-17 Eli Zaretskii <eliz@gnu.org>
2125
2126 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2127 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2128
bb187662
EZ
21292011-09-17 Eli Zaretskii <eliz@gnu.org>
2130
1137e8b8 2131 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2132 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2133
2134 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2135 (bidi_find_paragraph_start): Search back for paragraph beginning
2136 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2137 (bidi_move_to_visually_next): Only trigger paragraph-related
2138 computations when the last character is a newline or at EOB, not
2139 just any NEUTRAL_B. (Bug#9470)
2140
bb187662
EZ
2141 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2142 truncated lines if point is covered by a display string. (Bug#9524)
2143
2e621251
PE
21442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2147 (cons_to_x_long): New function.
2148 (lisp_data_to_selection_data): Use it. Correct the test for
2149 short-versus-long data; it was negated. Break out of vector
2150 loop, for efficiency, when a long datum is discovered.
2151
91a15bc6
SM
21522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2153
2154 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2155
b41c3a35
EZ
21562011-09-16 Eli Zaretskii <eliz@gnu.org>
2157
2158 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2159 GCC PR/17406) by declaring this function with external scope.
2160
7812ba2d
PE
21612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2164 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2165
cf7edc2a
AS
21662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2167
2168 * editfns.c (Fformat): Correctly handle text properties on "%%".
2169
bd01620e
EZ
21702011-09-15 Eli Zaretskii <eliz@gnu.org>
2171
2172 * xterm.c (x_draw_composite_glyph_string_foreground):
2173 * w32term.c (x_draw_composite_glyph_string_foreground):
2174 * term.c (encode_terminal_code):
2175 * composite.c (composition_update_it, get_composition_id):
2176 * xdisp.c (get_next_display_element)
2177 (fill_composite_glyph_string): Add comments about special meaning
2178 of TAB characters in a composition.
2179
a02719a3
PE
21802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2183 This occurs when processing a multibyte format.
2184 Problem reported by Wolfgang Jenker.
a02719a3 2185
72589a3c
JB
21862011-09-15 Johan Bockgård <bojohan@gnu.org>
2187
2188 * xdisp.c (try_cursor_movement): Only check for exact match if
2189 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2190
1c14176c
PE
21912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 Remove unused external symbols.
2194 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2195 * xdisp.c (calc_pixel_width_or_height): Now static.
2196 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2197 * indent.c (check_display_width):
2198 * w32term.c: Fix comment to match code.
2199 * xterm.c, xterm.h (x_catching_errors): Remove.
2200
d2eea5b5
PE
22012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2202
2203 * xselect.c: Use signed conversions more consistently (Bug#9498).
2204 (selection_data_to_lisp_data): Assume incoming selection data are
2205 signed integers, not unsigned. This is to be consistent with
2206 outgoing selection data, which was modified to use signed integers
2207 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2208 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2209 expects long, not unsigned long.
2210
46888499
EZ
22112011-09-14 Eli Zaretskii <eliz@gnu.org>
2212
2213 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2214 computation of loop end. Reported by Johan Bockgård
2215 <bojohan@gnu.org>.
2216
ef8ef9fb
CY
22172011-09-13 Chong Yidong <cyd@stupidchicken.com>
2218
2219 * frame.c (Fother_visible_frames_p): Function deleted.
2220
fa819fed
EZ
22212011-09-12 Eli Zaretskii <eliz@gnu.org>
2222
2223 * indent.c (compute_motion): Process display vector front to back
2224 rather than the other way around. (Bug#2496)
2225
2ba8e008
SM
22262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2227
2228 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2229
20f53c69
CY
22302011-09-11 Chong Yidong <cyd@stupidchicken.com>
2231
2232 * minibuf.c (Fread_from_minibuffer): Doc fix.
2233
d562d7a4
EZ
22342011-09-11 Eli Zaretskii <eliz@gnu.org>
2235
2236 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2237 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2238
1c4d7f3d
LMI
22392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2240
2241 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2242 value for non-existent files.
2243
b885bf36
EZ
22442011-09-11 Eli Zaretskii <eliz@gnu.org>
2245
2246 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2247 set its "size" to -1. This will set the modtime_size field of
2248 the corresponding buffer to -1, which is what
2249 verify-visited-file-modtime expects for files that do not exist.
2250 (Bug#9139)
2251
6612f0bf
PE
22522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2253
2254 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2255 here ...
2256 * lisp.h: ... from here. push_key_description is no longer
2257 defined in keyboard.c, so its declaration should not be in
2258 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2259 logically belongs with push_key_description.
2260
dfb3f755
PE
22612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2262
2263 * buffer.h: Include <sys/types.h> instead of <time.h>.
2264 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2265 Problem reported by Herbert J. Skuhra.
2266
3134906c
LMI
22672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2268
2269 * xml.c (parse_region): Make the parsing work for
2270 non-comment-starting XML files again (bug#9144).
2271
8d903f4e
AS
22722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2273
2274 * image.c (gif_load): Fix calculation of bottom and right corner.
2275 (Bug#9468)
2276
80ad64f4
EZ
22772011-09-10 Eli Zaretskii <eliz@gnu.org>
2278
2279 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2280 redisplay in small windows.
2281
208a048d
EZ
22822011-09-09 Eli Zaretskii <eliz@gnu.org>
2283
2284 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2285
9b1c252e
MR
22862011-09-08 Martin Rudalics <rudalics@gmx.at>
2287
2288 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2289 Operate on live windows only.
2290
2949f33b
JB
22912011-09-08 Juanma Barranquero <lekktu@gmail.com>
2292
2293 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2294
e08dcafd
EZ
22952011-09-07 Eli Zaretskii <eliz@gnu.org>
2296
2297 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2298 only under bidi iteration.
2299
115b96bd
JD
23002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2301
2302 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2303
c8199d0f
PE
23042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2307 Without this fix, the command to link temacs failed due to an
2308 undefined symbol __builtin_isnan. This is because
2309 /usr/include/iso/math_c99.h #defines isnan(x) to
2310 __builtin_isnan(x), but the bundled gcc, which identifies itself
2311 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2312 a __builtin_isnan.
2313 * floatfns.c (isnan): #undef, and then #define to a clone of
2314 what's in data.c.
2315 (Fisnan): Always define, since it's always available now.
2316 (syms_of_floatfns): Always define isnan at the Lisp level.
2317
e39b275c 23182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2319
2320 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2321
b2db44d9 23222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2323
f4af5137 2324 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2325 The previous code assumed that file offsets (off_t values) fit in
2326 EMACS_INT variables, which is not true on typical 32-bit hosts.
2327 The code messed up by falsely reporting buffer overflow in cases
2328 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2329 when "big" contains more than 2**29 bytes, even though this
2330 inserts just one byte and does not overflow the buffer.
2331 (Finsert_file_contents): Store file offsets as off_t
2332 values, not as EMACS_INT values. Check for overflow when
2333 converting between EMACS_INT and off_t. When checking for
2334 buffer overflow or for overlap, take the offsets into account.
2335 Don't use EMACS_INT for small values where int suffices.
2336 When checking for overlap, fix a typo: ZV was used where
2337 ZV_BYTE was intended.
2338 (Fwrite_region): Don't assume off_t fits into 'long'.
2339 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2340
ecfc0a49
MA
23412011-09-05 Michael Albinus <michael.albinus@gmx.de>
2342
2343 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2344
6511acf2 23452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2346
0999621a 2347 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2348
2349 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2350 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2351 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2352 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2353 (modify_event_symbol): Do not assume that the length of
2354 name_alist_or_stem is safe to alloca and fits in int.
2355 (Fexecute_extended_command): Likewise for function name and binding.
2356 (Frecursion_depth): Wrap around reliably on integer overflow.
2357 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2358 since some callers pass EMACS_INT values.
2359 (Fsingle_key_description): Don't crash if symbol name contains more
2360 than MAX_ALLOCA bytes.
2361 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2362 (get_minibuffer): Arg is now EMACS_INT, not int.
2363 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2364 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2365 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2366
2be7d702
PE
2367 * dbusbind.c (signature_cat): New function.
2368 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2369 Do not overrun buffer; instead, report string overflow.
2370
9d1df220
PE
2371 * dispnew.c (add_window_display_history): Don't overrun buffer.
2372 Truncate instead; this is OK since it's just a log.
2373
33ef5c64
PE
2374 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2375 even if the time zone offset is outlandishly large.
2376 Don't mishandle offset == INT_MIN.
2377
66c6fdd5
PE
2378 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2379 when creating daemon; the previous buffer-overflow check was incorrect.
2380
d749b01b
PE
2381 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2382 which has the guts of the old verror function.
2383
b5cd1905
PE
2384 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2385 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2386
6e1a67fb
PE
2387 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2388 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2389 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2390 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2391 length of string rather than counting it via multiple sprintfs;
2392 that's simpler and more reliable.
c21721cc
PE
2393 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2394 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2395 sprintf, in case result does not fit in int.
2396
c57b67fc
PE
2397 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2398 (fontset_from_font): Print it.
2399
8a401434
PE
2400 * frame.c (tty_frame_count): Now printmax_t, not int.
2401 (make_terminal_frame, set_term_frame_name): Print it.
2402 (x_report_frame_params): In X, window IDs are unsigned long,
2403 not signed long, so print them as unsigned.
2404 (validate_x_resource_name): Check for implausibly long names,
2405 and don't assume name length fits in 'int'.
2406 (x_get_resource_string): Don't blindly alloca invocation name;
2407 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2408 not fit in int.
2409
6e1a67fb
PE
2410 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2411 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2412 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2413
0df02bf3
PE
2414 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2415 Use esprintf, not sprintf, in case result does not fit in int.
2416
48e30793
PE
2417 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2418 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2419 it as a large positive number.
2420 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2421 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2422
a66ff6d8
PE
2423 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2424 in case result does not fit in int.
2425
aca216ff
PE
2426 * print.c (float_to_string): Detect width overflow more reliably.
2427 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2428 buffer overrun. Don't assume list length fits in 'int'. Treat
2429 print length of 0 as 0, not as infinity; to be consistent with other
2430 uses of print length in this function. Don't overflow print length
2431 index. Don't assume hash table size fits in 'long', or that
2432 vectorlike size fits in 'unsigned long'.
2433
31c286f7
PE
2434 * process.c (make_process): Use printmax_t, not int, to format
2435 process-name gensyms.
2436
55e5faa1
PE
2437 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2438
80f2e268
PE
2439 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2440 to avoid potential buffer overrun.
2441
670741ab
PE
2442 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2443 if X resource line is longer than 512 bytes.
2444
b7163a50
PE
2445 * xfns.c (x_window): Make sprintf buffer a bit bigger
2446 to avoid potential buffer overrun.
2447
ae58ff1f
PE
2448 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2449
c43c8a6a
PE
2450 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2451
3f8236f4
PE
24522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2453
53e9fe90 2454 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2455 Without these, Emacs silently mishandles large integers sometimes.
2456 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2457 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2458
6511acf2
PE
2459 * xdisp.c (try_window_id): Check Emacs fixnum range before
2460 converting to 'int'.
806add1d 2461
6511acf2 2462 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2463 Check that an Emacs fixnum is in range before assigning it to 'int'.
2464 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2465 values converted from Emacs fixnums.
2466 (Frecenter): Don't wrap around a line count if it is out of 'int'
2467 range; instead, treat it as an extreme value.
2468 (Fset_window_configuration, compare_window_configurations):
2469 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2470
6511acf2
PE
2471 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2472 that can exceed INT_MAX. Check that EMACS_INT value is in range
2473 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2474 (match_limit): Don't assume that a fixnum can fit in 'int'.
2475
6511acf2 2476 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2477 exceed INT_MAX.
2478
6511acf2 2479 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2480 (Fvertical_motion): Don't wrap around LINES values that don't fit
2481 in 'int'. Instead, treat them as extreme values. This is good
2482 enough for windows, which can't have more than INT_MAX lines anyway.
2483
fcb901a7
LMI
24842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2485
0f2f6b6d
LMI
2486 * Require libxml/parser.h to avoid compilation warning.
2487
fcb901a7
LMI
2488 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2489
2490 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2491 since this reportedly can destroy thread storage.
2492
6e20a0d4
CY
24932011-08-30 Chong Yidong <cyd@stupidchicken.com>
2494
2495 * syntax.c (find_defun_start): Update all cache variables if
2496 exiting early (Bug#9401).
2497
148ae00e
EZ
24982011-08-30 Eli Zaretskii <eliz@gnu.org>
2499
f6cfbd8f
EZ
2500 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2501
148ae00e
EZ
2502 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2503 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2504 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2505
2506 * term.c (tty_append_glyph): New function.
2507 (produce_stretch_glyph): Static function and its prototype deleted.
2508
a66cfb1c
SM
2509 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2510 Add prototypes.
148ae00e 2511
c4a07a4c
PE
25122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2513
2514 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2515 when checking :margin (Bug#9390).
2516 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2517 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2518 so that the name doesn't mislead. All uses changed.
2519
6bc8cd65
JB
25202011-08-28 Johan Bockgård <bojohan@gnu.org>
2521
2522 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2523 set_tty_hooks.
2524
dca4927e
EZ
25252011-08-27 Eli Zaretskii <eliz@gnu.org>
2526
2527 * xdisp.c (move_it_to): Don't bail out early when reaching
2528 position beyond to_charpos, if we are scanning backwards.
2529 (move_it_vertically_backward): When DY == 0, make sure we get to
2530 the first character in the line after the newline.
2531
f2cad773
PE
25322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2535 (ccl_driver): Do not generate an out-of-range pointer.
2536 (Fccl_execute_on_string): Remove unnecessary check for
2537 integer overflow, noted by Stefan Monnier in
2538 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2539 Remove a FIXME that didn't need fixing.
2540 Simplify the newly-introduced buffer reallocation code.
2541
0cae2cdb
JB
25422011-08-27 Juanma Barranquero <lekktu@gmail.com>
2543
2544 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2545
5fc295a4 25462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2547
70c60eb2 2548 Integer and memory overflow issues (Bug#9196).
726e0ab1 2549
d31850da
PE
2550 * doc.c (get_doc_string): Rework so that
2551 get_doc_string_buffer_size is the actual buffer size, rather than
2552 being 1 less than the actual buffer size; this makes xpalloc more
2553 convenient.
2554
a69fbedb
PE
2555 * image.c (x_allocate_bitmap_record, cache_image):
2556 * xselect.c (Fx_register_dnd_atom):
2557 Simplify previous changes by using xpalloc.
2558
fe5c5d37
PE
2559 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2560 since either will do and ptrdiff_t is convenient with xpalloc.
2561
0065d054
PE
2562 * charset.c (charset_table_size)
2563 (struct charset_sort_data.priority): Now ptrdiff_t.
2564 (charset_compare): Don't overflow if priorities differ greatly.
2565 (Fsort_charsets): Don't assume list length fits in int.
2566 Check for size-calculation overflow when allocating sort data.
2567 (syms_of_charset): Allocate an initial charset table that is
2568 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2569
2570 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2571
2572 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2573 The actual value is always <= INT_MAX, and leaving it unsigned made
2574 overflow checking harder.
2575
2576 * dispextern.h (struct glyph_matrix.rows_allocated)
2577 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2578 with xpalloc. The values are still always <= INT_MAX.
2579
2580 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2581
2582 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2583 (SAFE_NALLOCA): New macro.
2584
2585 * region-cache.c (struct boundary.pos, find_cache_boundary)
2586 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2587 (set_cache_region, invalidate_region_cache)
2588 (revalidate_region_cache, know_region_cache, region_cache_forward)
2589 (region_cache_backward, pp_cache):
2590 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2591 so that ptrdiff_t * can be passed to xpalloc.
2592 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2593 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2594 (pp_cache): Don't assume cache_len fits in int.
2595 * region-cache.h: Adjust extern decls to match.
2596
2597 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2598 EMACS_INT, since either will do, for xpalloc.
2599
2600 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2601 (xnmalloc, xnrealloc, xpalloc): New functions.
2602
726e0ab1
PE
2603 * bidi.c (bidi_shelve_header_size): New constant.
2604 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2605 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2606
51f30bc5 2607 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2608 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2609 (overlay_strings):
2610 Don't update size of array until after memory allocation succeeds,
2611 because xmalloc/xrealloc may not return.
0065d054
PE
2612 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2613 now that we have proper integer overflow checking.
2614 (record_overlay_string, overlay_strings): Catch overflows when
2615 calculating size of overlay_str_buf.
726e0ab1 2616
0065d054
PE
2617 * callproc.c (Fcall_process): Check for size overflow when
2618 calculating size of args2.
2619 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2620 Normally we prefer signed values, but sticking with ptrdiff_t would
2621 require adding more-complicated checks.
726e0ab1
PE
2622
2623 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2624 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2625 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2626 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2627
2628 * character.c (Fstring): Check for size-calculation overflow.
2629
2630 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2631 unnecessary integer overflow. Check for size overflow.
2632 (encode_coding_object): Don't update size until xmalloc succeeds.
2633
2634 * composite.c (get_composition_id): Check for overflow in glyph
2635 length calculations.
2636
2637 Integer and memory overflow fixes for display code.
2638 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2639 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2640 (scrolling_window): Check for overflow in size calculations.
2641 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2642 Don't assume glyph table len fits in int.
2643 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2644 (row_table_size): Now ptrdiff_t, not int.
2645 (scrolling_window): Avoid overflow in size calculations.
2646 Don't update size until allocation succeeds.
2647 * fns.c (concat): Check for overflow in size calculations.
2648 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2649 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2650 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2651
2652 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2653 (get_doc_string): Check for size calculation overflow.
2654 Don't update size until allocation succeeds.
2655 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2656 EMACS_INT, where ptrdiff_t will do.
2657 (Fsubstitute_command_keys): Check for string overflow.
2658
2659 * editfns.c (set_time_zone_rule): Don't assume environment length
2660 fits in int.
2661 (message_length): Now ptrdiff_t, not int.
2662 (Fmessage_box): Don't update size until allocation succeeds.
2663 Don't assume message length fits in int.
2664 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2665
0065d054
PE
2666 * emacs.c (main): Do not reallocate argv, since there is a null at
2667 the end that can be overwritten, and this way there's no need to
2668 worry about size-calculation overflow.
2669 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2670
2671 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2672 alloc succeeds.
2673 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2674
2675 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2676 (x_set_scroll_bar_width, x_figure_window_size):
2677 Check for integer overflow.
2678 (x_set_alpha): Do not assume XINT fits in int.
2679
2680 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2681 This is for the members text_lines, text_cols, total_lines, total_cols,
2682 where the system imposes an 'int' limit.
2683
2684 * fringe.c (Fdefine_fringe_bitmap):
2685 Don't update size until alloc works.
2686
2687 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2688 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2689
2690 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2691 Check for size-calculation overflow.
2692 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2693 do, as we prefer signed integers.
2694 (id_to_widget.max_size, id_to_widget.used)
2695 (xg_store_widget_in_map, xg_remove_widget_from_map)
2696 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2697 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2698 Use and return ptrdiff_t, not int.
2699 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2700 * gtkutil.h: Change prototypes to match the above.
2701
2702 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2703 are duplicate now that they've been promoted to lisp.h.
2704 (x_allocate_bitmap_record, x_alloc_image_color)
2705 (make_image_cache, cache_image, xpm_load):
2706 Don't update size until alloc is done.
2707 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2708 (x_detect_edges):
3256efce 2709 Check for size calculation overflow.
726e0ab1
PE
2710 (ct_colors_allocated_max): New constant.
2711 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2712 overflow.
3256efce 2713
726e0ab1
PE
2714 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2715 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2716 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2717 Use ptrdiff_t, not int, to count maps.
2718 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2719 calculations. Don't update size until allocation succeeds.
2720 Redo calculations to avoid overflow.
726e0ab1
PE
2721 * keyboard.h: Change prototypes to match the above.
2722
2723 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2724 to count maps.
2725 (current_minor_maps): Check for size calculation overflow.
2726 * keymap.h: Change prototypes to match the above.
2727
2728 * lread.c (read1, init_obarray): Don't update size until alloc done.
2729
2730 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2731 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2732
726e0ab1
PE
2733 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2734 Now ptrdiff_t, not int.
2735 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2736 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2737
2738 * process.c (Fnetwork_interface_list): Check for overflow
2739 in size calculation.
2740
2741 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2742
2743 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2744 overflow. Don't bother calling xmalloc when xrealloc will do.
2745
2746 * search.c (Freplace_match): Check for size calculation overflow.
2747 (Fset_match_data): Don't assume list lengths fit in 'int'.
2748
2749 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2750 for command line length. Do not attempt to address one before the
2751 beginning of an array, as that's not portable.
2752
2753 * term.c (max_frame_lines): Remove; unused.
2754 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2755 not int.
2756 (encode_terminal_code, calculate_costs): Check for size
2757 calculation overflow.
2758 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2759 table lengths and related sizes. Don't update size until alloc
2760 done. Redo calculations to avoid overflow.
2761 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2762
2763 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2764 subtracting pointers.
2765 (gobble_line): Check for overflow more carefully. Don't update size
2766 until alloc done.
2767
2768 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2769 Don't update size until alloc done.
2770 Redo size calculations to avoid overflow.
2771 Check for size calculation overflow.
0065d054 2772 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2773
2774 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2775 Use ptrdiff_t, not int, for sizes.
2776 (store_mode_line_noprop_char): Don't update size until alloc done.
2777
0065d054
PE
2778 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2779 Use ptrdiff_t, not int, for sizes.
2780 (Finternal_make_lisp_face, cache_face):
2781 Check for size calculation overflow.
2782 (cache_face): Treat size calculation overflows as if they were
2783 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2784
2785 * xfns.c (x_encode_text, x_set_name_internal)
2786 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2787 sizes, since they can exceed INT_MAX in size. Check for size
2788 calculation overflow.
2789
0065d054
PE
2790 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2791 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2792 Don't update size until alloc done.
2793
0065d054 2794 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2795 as sprintf is limited to int lengths.
1d526e2f 2796
252c5ee1
PE
2797 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2798 (X_LONG_MIN): New macros.
864d7ce7
PE
2799 Use them to make the following changes clearer.
2800 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2801 This change doesn't affect the value now, but it may help remind
2802 future maintainers not to raise the value too much later.
2803 (SELECTION_QUANTUM): Remove, replacing with ...
2804 (selection_quantum): ... new function, which avoids overflow.
2805 All uses changed.
2806 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2807 assumption that selection length fits in 'int'.
2808 (x_reply_selection_request, x_handle_selection_request)
2809 (x_get_window_property, receive_incremental_selection)
2810 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2811 (lisp_data_to_selection_data, clean_local_selection_data):
2812 Use ptrdiff_t, not int, to record length of selection.
2813 (x_reply_selection_request, x_get_window_property)
2814 (receive_incremental_selection, x_property_data_to_lisp):
2815 Redo calculations to avoid overflow.
2816 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2817 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2818 something.
2819 (x_get_window_property, receive_incremental_selection)
2820 (lisp_data_to_selection_data, x_property_data_to_lisp):
2821 Check for size-calculation overflow.
2822 (x_get_window_property, receive_incremental_selection)
2823 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2824 Don't store size until memory allocation succeeds.
2825 (x_get_window_property): Plug memory leak on memory exhaustion.
2826 Don't double-block input; malloc is safe here. Don't assume 2**34
2827 - 4 fits in unsigned long. Add an xassert to check
2828 XGetWindowProperty overflow. Be more careful about overflow
2829 calculations, and distinguish size from memory overflow better.
2830 (receive_incremental_selection): When tracing, don't assume
2831 unsigned int is less than INT_MAX.
2832 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2833 harmful) conversions of unsigned short to int.
2834 (lisp_data_to_selection_data): Don't assume that integers
2835 in the range -65535 through -1 fit in an X unsigned short.
2836 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2837 result parameters unless successful. Rely on cons_to_unsigned
2838 to report problems with elements; the old code wasn't right anyway.
2839 (x_check_property_data): Check for int overflow; we cannot use
2840 a wider type due to X limits.
2841 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2842
726e0ab1 2843 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2844
0065d054
PE
2845 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2846 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2847 (x_color_cells): Don't store size until memory allocation succeeds.
2848 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2849 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2850 (x_term_init): Don't assume length fits in int (sprintf is limited
2851 to int size).
bc18e09d 2852
ebfa62c0
PE
2853 Use ptrdiff_t for composition IDs.
2854 * character.c (lisp_string_width):
2855 * composite.c (composition_table_size, n_compositions)
2856 (get_composition_id, composition_gstring_from_id):
2857 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2858 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2859 * window.c (Frecenter):
2860 Use ptrdiff_t, not int, for composition IDs.
2861 * composite.c (get_composition_id): Check for integer overflow.
2862 * composite.h: Adjust prototypes to match the above changes.
2863
d3411f89
PE
2864 Use ptrdiff_t for hash table indexes.
2865 * category.c (hash_get_category_set):
2866 * ccl.c (ccl_driver):
2867 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2868 * coding.c (coding_system_charset_list, detect_coding_system):
2869 * coding.h (struct coding_system.id):
2870 * composite.c (get_composition_id, gstring_lookup_cache):
2871 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2872 * image.c (xpm_get_color_table_h):
2873 * lisp.h (hash_lookup, hash_put):
2874 * minibuf.c (Ftest_completion):
2875 Use ptrdiff_t for hash table indexes, not int (which is too
2876 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2877 32-bit --with-wide-int hosts).
2878
e097a6fa
PE
2879 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2880 Add a FIXME comment about memory leaks.
2881 (syms_of_charset): Don't assume xmalloc returns.
2882
5637687f
PE
2883 Don't assume that stated character widths fit in int.
2884 * character.c (Fchar_width, c_string_width, lisp_string_width):
2885 * character.h (CHAR_WIDTH):
2886 * indent.c (MULTIBYTE_BYTES_WIDTH):
2887 Use sanitize_char_width to avoid undefined and/or bad behavior
2888 with outlandish widths.
a66cfb1c 2889 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2890 now that we have two such functions. All uses changed.
2891 (sanitize_char_width): New inline function.
2892
a2271ba2
PE
2893 Don't assume that tab-width fits in int.
2894 * character.h (sanitize_width): New inline function.
2895 (SANE_TAB_WIDTH): New macro.
2896 (ASCII_CHAR_WIDTH): Use it.
2897 * indent.c (sane_tab_width): Remove. All uses replaced by
2898 SANE_TAB_WIDTH (current_buffer).
2899 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2900
18c52557
PE
2901 * fileio.c: Integer overflow issues with file modes.
2902 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2903
caeeedc1
PE
2904 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2905 Remove unreachable code.
2906 (read_hex, load_charset_map_from_file): Check for integer overflow.
2907
6df6ae42 2908 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2909 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2910 (x_send_scroll_bar_event): Likewise. Check that the size does not
2911 exceed limits imposed by XClientMessageEvent, as well as the usual
2912 ptrdiff_t and size_t limits.
2913
b13995db
PE
2914 * keyboard.c: Overflow, signedness and related fixes.
2915 (make_lispy_movement): Use same integer type in forward decl
2916 that is used in the definition.
2917 (read_key_sequence, keyremap_step):
2918 Change bufsize argument back to int, undoing my 2011-03-30 change.
2919 We prefer signed types, and int is wide enough here.
2920 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2921 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2922 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2923 length, not size_t. Use ptrdiff_t for index, not int.
2924 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2925 possibility of integer overflow.
2926
13464394
PE
2927 Overflow, signedness and related fixes for images.
2928
2929 * dispextern.h (struct it.stack[0].u.image.image_id)
2930 (struct_it.image_id, struct image.id, struct image_cache.size)
2931 (struct image_cache.used, struct image_cache.ref_count):
2932 * gtkutil.c (update_frame_tool_bar):
2933 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2934 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2935 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2936 * nsmenu.m (update_frame_tool_bar):
2937 * xdisp.c (calc_pixel_width_or_height):
2938 * xfns.c (image_cache_refcount):
2939 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2940 on typical 64-bit hosts.
2941
2942 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2943 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2944 Omit unnecessary casts to int.
2945 (parse_image_spec): Check that integers fall into 'int' range
2946 when the callers expect that.
2947 (image_ascent): Redo ascent calculation to avoid int overflow.
2948 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2949 (lookup_image): Remove unnecessary tests.
2950 (xbm_image_p): Locals are now of int, not EMACS_INT,
2951 since parse_image_check makes sure they fit into int.
2952 (png_load, gif_load, svg_load_image):
2953 Prefer int to unsigned where either will do.
2954 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2955 old tiff_error_handler and tiff_warning_handler.
2956 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2957 stack buffer overflows. It uses only the features of vsnprintf
2958 that are common to both POSIX and native Microsoft.
2959 (tiff_error_handler, tiff_warning_handler): Use it.
2960 (tiff_load, gif_load, imagemagick_load_image):
2961 Don't assume :index value fits in 'int'.
2962 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2963 (imagemagick_load_image): Check that crop parameters fit into
2964 the integer types that MagickCropImage accepts. Don't assume
2965 Vimagemagick_render_type has a nonnegative value. Don't assume
2966 size_t fits in 'long'.
2967 (gs_load): Use printmax_t to print the widest integers possible.
2968 Check for integer overflow when computing image height and width.
2969
c11821d4
EZ
29702011-08-26 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (redisplay_window): Don't force window start if point
2973 will be invisible in the resulting window. (Bug#9324)
2974
0c95fcf7
EZ
29752011-08-25 Eli Zaretskii <eliz@gnu.org>
2976
2977 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2978 the display spec is of the form `(space ...)'.
2979 (handle_display_spec): Return the value returned by
2980 handle_single_display_spec, not just 1 or zero.
2981 (handle_single_display_spec): If the display spec is of the form
2982 `(space ...)', and specifies display in the text area, return 2
2983 rather than 1.
fee65a97 2984 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2985 accurately, and prefer exact match for point under bidi.
2986 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2987
2988 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2989 into disp_prop; all users changed.
2990
2991 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2992 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2993 for the text covered by the display property.
2994
e4ed06f1
CY
29952011-08-25 Chong Yidong <cyd@stupidchicken.com>
2996
2997 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2998 Change return value to nil.
2999 (Frecord_buffer): Delete unused function.
3000
f67cdd7f
EZ
30012011-08-24 Eli Zaretskii <eliz@gnu.org>
3002
5980d4c6
EZ
3003 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3004 buffers, return left-to-right.
8610fe8b
EZ
3005 (set_cursor_from_row): Consider candidate row a win if its glyph
3006 represents a newline and point is on that newline. Fixes cursor
3007 positioning on the newline at EOL of R2L text within L2R
3008 paragraph, and vice versa.
3009 (try_cursor_movement): Check continued rows, in addition to
3010 continuation rows. Fixes unwarranted scroll when point enters a
3011 continued line of R2L text within an L2R paragraph, or vice versa.
3012 (cursor_row_p): Consider the case of point being equal to
3013 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3014 from the end of a short line to the beginning of a continued line
3015 of R2L text within L2R paragraph.
3016 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3017 composed characters.
5980d4c6 3018
f67cdd7f
EZ
3019 * bidi.c (bidi_check_type): Use xassert.
3020 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3021 members.
3022
bca633fb
EZ
30232011-08-23 Eli Zaretskii <eliz@gnu.org>
3024
3025 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3026 a character.
3027
4a5885a7
CY
30282011-08-23 Chong Yidong <cyd@stupidchicken.com>
3029
3030 * nsfont.m (ns_otf_to_script): Fix typo.
3031
0902a04e
KH
30322011-08-22 Kenichi Handa <handa@m17n.org>
3033
3034 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3035 extra slot even if the purpose is char-code-property-table.
3036
1a2e6670
EZ
30372011-08-23 Eli Zaretskii <eliz@gnu.org>
3038
8ddde651
EZ
3039 * xdisp.c (redisplay_window): When computing centering_position,
3040 account for the height of the header line. (Bug#8874)
3041
425cc014
EZ
3042 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3043 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3044 candidate is selected by the mouse, and that candidate has a
3045 composed character under the mouse.
3046
1a2e6670
EZ
3047 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3048 coordinates reported by pos-visible-in-window-p for a composed
3049 character in column zero.
3050
8b76d6f8
SM
30512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3052
3053 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3054
dac347dd
EZ
30552011-08-22 Eli Zaretskii <eliz@gnu.org>
3056
3057 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3058 consider it a hit if to_charpos is anywhere in the range of the
3059 composed buffer positions.
3060
e013fb34
CY
30612011-08-22 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * image.c (gif_load): Don't assume that each subimage has the same
3064 dimensions as the base image. Handle disposal method that is
3065 "undefined" by the gif spec (Bug#9335).
3066
bd1ba3e8
CY
30672011-08-20 Chong Yidong <cyd@stupidchicken.com>
3068
3069 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3070 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3071
54a1215b
EZ
30722011-08-19 Eli Zaretskii <eliz@gnu.org>
3073
823564e5
EZ
3074 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3075 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3076 from an Org mode buffer to a Speedbar frame.
3077
54a1215b
EZ
3078 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3079 a composition, take its buffer position from IT->cmp_it.charpos.
3080 Fixes cursor positioning at the beginning of a line that begins
3081 with a composed character.
3082
9778ebcc
EZ
30832011-08-18 Eli Zaretskii <eliz@gnu.org>
3084
0be6ee06
EZ
3085 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3086 character bidirectional type, use STRONG_L instead. Fixes crashes
3087 in a buffer produced by `describe-categories'.
3088
9778ebcc
EZ
3089 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3090 members before the level stack, so they would be saved and
3091 restored when copying iterator state. Fixes incorrect reordering
3092 around TABs covered by display properties.
3093
156bffbe
AS
30942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3095
6b02f655 3096 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3097
72ad093b
CY
30982011-08-17 Chong Yidong <cyd@stupidchicken.com>
3099
3100 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3101 (internal_condition_case_2, internal_condition_case_n):
3102 Remove unnecessary aborts (Bug#9081).
72ad093b 3103
35774242
EZ
31042011-08-17 Eli Zaretskii <eliz@gnu.org>
3105
3106 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3107 has no `load' handler, try opening the file locally. (Bug#9311)
3108
db76dd85
KB
31092011-08-16 Ken Brown <kbrown@cornell.edu>
3110
3111 * gmalloc.c: Expand comment.
3112
b215eee5
EZ
31132011-08-16 Eli Zaretskii <eliz@gnu.org>
3114
3115 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3116 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3117
a4579d33
KB
31182011-08-16 Ken Brown <kbrown@cornell.edu>
3119
3120 Fix memory allocation problems in Cygwin build (Bug#9273).
3121
3122 * unexcw.c ( __malloc_initialized): Declare external variable.
3123 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3124
8b76d6f8
SM
3125 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3126 New variables.
a4579d33
KB
3127 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3128 dumped emacs.
3129 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3130 in the static heap.
3131 [CYGWIN] (special_realloc): New function.
3132 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3133 requests to realloc storage in the static heap.
3134
3ebec551
PE
31352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 * bidi.c (bidi_initialize): Remove unused local.
3138
9fd8be00
EZ
31392011-08-15 Eli Zaretskii <eliz@gnu.org>
3140
6b02f655
SM
3141 * bidimirror.h:
3142 * biditype.h: Remove file.
3143 * makefile.w32-in ($(BLD)/bidi.$(O)):
3144 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3145
3146 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3147
3148 * chartab.c: Improve commentary for the uniprop_table API.
3149
32413314
EZ
3150 * bidi.c (bidi_paragraph_init): Support zero value of
3151 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3152 (bidi_initialize): Use uniprop_table instead of including
3153 biditype.h and bidimirror.h.
32413314 3154
9fd8be00
EZ
3155 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3156 coordinates of the iterator when restoring from ppos_it.
3157 (Bug#9296)
3158
5cf2b69b
KH
31592011-08-14 Kenichi Handa <handa@m17n.org>
3160
3161 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3162 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3163
daf17d00
EZ
31642011-08-14 Eli Zaretskii <eliz@gnu.org>
3165
3166 * xdisp.c (move_it_in_display_line_to): Don't invoke
3167 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3168 ppos_it. Fixes vertical cursor motion when line beginning is
3169 covered by an image. (Bug#9296)
3170
08e3161a
JD
31712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3172
3173 * nsterm.h (ns_run_ascript): Declare.
3174 (NSAPP_DATA2_RUNASSCRIPT): Define.
3175
3176 * nsfns.m (as_script, as_result, as_status): New static variables.
3177 (ns_run_ascript): New function.
5e617bc2 3178 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3179 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3180 the event loop. Get status from as_status (Bug#7276).
3181
3182 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3183 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3184 the event loop (Bug#7276).
3185
a3720aa2
AS
31862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3187
3188 * gnutls.c (QCgnutls_bootprop_priority)
3189 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3190 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3191 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3192 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3193 (QCgnutls_bootprop_verify_hostname_error)
3194 (QCgnutls_bootprop_callbacks_verify): Rename from
3195 Qgnutls_bootprop_..., all uses changed.
3196
3197 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3198 uses changed.
3199
0a0d27fb
PE
32002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3201
19d5c50c
PE
3202 * xfaces.c (Qframe_set_background_mode): Now static.
3203 * dispextern.h (Qframe_set_background_mode): Remove decl.
3204
0a0d27fb
PE
3205 * process.c (Fnetwork_interface_info): Declare local only if needed.
3206
377538cb
JD
32072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3208
3209 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3210 (Fnetwork_interface_list): Allocate in increments of bytes instead
3211 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3212 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3213 sockaddr.
3214 (struct ifflag_def): notrailers is smart on OSX.
3215 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3216 Get hardware address with getifaddrs if available.
3217
08fff70c
EZ
32182011-08-12 Eli Zaretskii <eliz@gnu.org>
3219
3220 * xdisp.c (iterate_out_of_display_property): xassert that
3221 IT->position is set to within IT->object's boundaries. Break from
3222 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3223 when IT->position is set up wrongly due to some bug.
3224 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3225 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3226 entry. Force push_it to save on the stack the current
3227 buffer/string position, to be restored by pop_it. Fix flags in
3228 the iterator structure wrt the object coming from a display
3229 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3230 properties. (Bug#9284)
3231
7be1c708 32322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3233
7be1c708
CY
3234 * fontset.c (fontset_get_font_group): Add proper type checks.
3235 (Bug#9172)
aac0c6e3 3236
7be1c708 32372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3238
7be1c708
CY
3239 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3240 and LC_VERSION_MIN_MACOSX.
3241 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3242 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3243
97bb72a6
EZ
32442011-08-08 Eli Zaretskii <eliz@gnu.org>
3245
3246 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3247 no-display-properties-and-no-overlays under bidi display.
3248 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3249 properties and overlays.
97bb72a6 3250
d5617611
CY
32512011-08-08 Chong Yidong <cyd@stupidchicken.com>
3252
37e11a63
CY
3253 * editfns.c (Fset_time_zone_rule): Document relationship with the
3254 setenv function.
3255
d5617611
CY
3256 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3257 the font entity extracted from the cache (Bug#8109).
3258
58872834
CY
32592011-08-07 Chong Yidong <cyd@stupidchicken.com>
3260
3261 * composite.c (autocmp_chars): Don't reset point. That is done by
3262 restore_point_unwind (Bug#5984).
3263
75bfc667
JL
32642011-08-07 Juri Linkov <juri@jurta.org>
3265
3266 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3267 to show the arg `TIME' instead of `TIMEVAL'.
3268
d1410150
EZ
32692011-08-06 Eli Zaretskii <eliz@gnu.org>
3270
3271 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3272 display property strides EOL and includes a newline, as in
3273 longlines-mode. (Bug#9254)
75b771e4
EZ
3274 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3275 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3276
3277 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3278 is non-zero, even if the data buffer is NULL. Fixes a crash in
3279 vertical-motion with longlines-mode. (Bug#9254)
3280
35928349
EZ
32812011-08-05 Eli Zaretskii <eliz@gnu.org>
3282
ec7cc85b
EZ
3283 * bidi.c <bidi_cache_total_alloc>: Now static.
3284 (bidi_initialize): Initialize bidi_cache_total_alloc.
3285
8b76d6f8 3286 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3287 cache. (Bug#9221)
3288
3289 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3290 amount allocated this far in `bidi_cache_total_alloc'.
3291 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3292 non-zero, only free the data buffer without restoring the cache
3293 contents. All callers changed.
3294
3295 * dispextern.h (bidi_unshelve_cache): Update prototype.
3296
3297 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3298 (move_it_in_display_line, move_it_to)
3299 (move_it_vertically_backward, move_it_by_lines): Replace the call
3300 to xfree to an equivalent call to bidi_unshelve_cache.
3301 (move_it_in_display_line_to): Fix logic of returning
412b6358 3302 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3303
e2e2423b
EZ
33042011-08-05 Eli Zaretskii <eliz@gnu.org>
3305
3306 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3307 came from a string character with a `cursor' property. (Bug#9229)
3308
ae9e757a
JD
33092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3310
3311 * Makefile.in (LIB_PTHREAD): New variable.
3312 (LIBES): Add LIB_PTHREAD (Bug#9216).
3313
3314 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3315 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3316
213bd7f2
AS
33172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3318
6b02f655 3319 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3320
99aaf75f
JD
33212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3322
3323 * xterm.c (x_find_topmost_parent): New function.
3324 (x_set_frame_alpha): Find topmost parent window with
3325 x_find_topmost_parent and set the property there also (bug#9181).
3326 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3327
c74e9d86
PE
33282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 * callproc.c (Fcall_process): Avoid vfork clobbering
3331 the local vars buffer, coding_systems, current_dir.
3332
640c8776
SM
33332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3334
3335 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3336
f26d0e4c
PE
33372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3338
8a10d76c
PE
3339 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3340 so that it is not optimized away.
3341
f26d0e4c
PE
3342 * xdisp.c (compute_display_string_pos): Remove unused local.
3343
55439c61
EZ
33442011-08-02 Eli Zaretskii <eliz@gnu.org>
3345
3346 Fix slow cursor motion and scrolling in large buffers with
3347 selective display, like Org Mode buffers. (Bug#9218)
3348
3349 * dispextern.h (struct bidi_it): New member disp_prop_p.
3350
3351 * xdisp.c: Remove one-slot cache of display string positions.
3352 (compute_display_string_pos): Accept an additional argument
5e617bc2 3353 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3354 for a display string or property. If found, set DISP_PROP_P
3355 non-zero.
3356
3357 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3358 DISP_PROP_P, and pass it to compute_display_string_pos.
3359 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3360 non-zero. All callers of bidi_fetch_char changed.
3361
fb33fa43
SM
33622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3363
3364 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3365
b099e063
DM
33662010-12-03 Don March <don@ohspite.net>
3367
3368 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3369 last character M-[char] is translated to ESC [char] (bug#7541).
3370
5cc7f7af
KH
33712011-08-02 Kenichi Handa <handa@m17n.org>
3372
d0fffa3f 3373 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3374
3375 * chartab.c (uniprop_table): Make it non-static.
3376
525d5e6e
EZ
33772011-08-01 Eli Zaretskii <eliz@gnu.org>
3378
3379 * xdisp.c (forward_to_next_line_start): Accept additional argument
3380 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3381 on the newline.
3382 (reseat_at_next_visible_line_start): Use the bidi iterator state
3383 returned by forward_to_next_line_start to restore the state of
3384 it->bidi_it after backing up to previous newline. (Bug#9212)
3385
31011111
AS
33862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3387
3388 * regex.c (re_comp): Protoize.
3389 (re_exec): Fix return type.
3390 (regexec): Fix type of `ret'. (Bug#9203)
3391
476371c4
PE
33922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3393
e5d76069
PE
3394 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3395 This is needed if max-image-size is a floating-point number.
3396
9a79b20c
AS
33972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3398
3399 * print.c (print_object): Print empty symbol as ##.
3400
3401 * lread.c (read1): Read ## as empty symbol.
3402
d8c2fa78
AA
34032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3404
3405 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3406 setting frame foreground color (Bug#9175).
3407 (x_set_background_color): Likewise.
3408
ffe57a7a
AA
3409 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3410 contents (Bug#9176).
3411 (EmacsTooltip -init): Remove bezels and add shadows to
3412 tooltip windows.
3413
bf3492a5
AA
3414 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3415 or scroll bar (Bug#8470).
3416
d55e9c53
AA
3417 * nsfont.m (nsfont_open): Remove assignment to voffset and
3418 unnecessary vars hshink, expand, hd, full_height, min_height.
3419 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3420
3421 * nsterm.h (nsfont_info): Remove voffset field.
3422
d8c2fa78 34232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3424
3425 Implement strike-through and overline on NextStep (Bug#8863).
3426
3427 * nsfont.m (nsfont_open): Use underline position provided by font,
3428 instead of hard-coded value of 2.
3429 (nsfont_draw): Call ns_draw_text_decoration instead.
3430
3431 * nsterm.h: Add declaration for ns_draw_text_decoration.
3432
3433 * nsterm.m (ns_draw_text_decoration): New function for drawing
3434 underline, overline, and strike-through.
3435 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3436 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3437 accommodate underlining, etc.
4843aac3 3438
4cc60b9b
EZ
34392011-07-28 Eli Zaretskii <eliz@gnu.org>
3440
bc7ece87
EZ
3441 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3442 default.
4cc60b9b 3443
476371c4
PE
34442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3445
66606eea
PE
3446 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3447 Without this fix, if a signal arrives just after memory fills up,
3448 'malloc' might be invoked reentrantly.
3449
476371c4
PE
3450 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3451 In other words, assume that every image size is allowed, on non-X
3452 hosts. This assumption is probably wrong, but it lets Emacs compile.
3453
f3fcc40d
AS
34542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3455
3456 * regex.c (re_iswctype): Convert return values to boolean.
3457
350c992f
EZ
34582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3459
3460 * xdisp.c (compute_display_string_pos): Don't use cached display
3461 string position if the buffer had its restriction changed.
3462 (Bug#9184)
3463
5266b4bb
PE
34642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3465
3466 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3467
2573a837 34682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3469
41f55ccd 3470 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3471
39e378da
PE
3472 * bidi.c: Integer size and overflow fixes.
3473 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3474 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3475 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3476 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3477 (bidi_find_other_level_edge):
3478 Use ptrdiff_t instead of EMACS_INT where either will do.
3479 This works better on 32-bit hosts configured --with-wide-int.
3480 (bidi_cache_ensure_space): Check for size-calculation overflow.
3481 Use % rather than repeated addition, for better worst-case speed.
3482 Don't set bidi_cache_size until after xrealloc returns, because it
3483 might not return.
3484 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3485 (bidi_cache_ensure_space): Also check that the bidi cache size
3486 does not exceed that of the largest Lisp string or buffer. See Eli
3487 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3488
5e927815
PE
3489 * alloc.c (__malloc_size_t): Remove.
3490 All uses replaced by size_t. See Andreas Schwab's note
3491 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3492
ca4aa935
PE
3493 * image.c: Improve checking for integer overflow.
3494 (check_image_size): Assume that f is nonnull, since
3495 it is always nonnull in practice. This is one less thing to
3496 worry about when checking for integer overflow later.
3497 (x_check_image_size): New function, which checks for integer
3498 overflow issues inside X.
3499 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3500 This removes the need for a memory_full check.
3501 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3502 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3503 (xbm_read_bitmap_data): Change locals back to 'int', since
3504 their values must fit in 'int'.
3505 (xpm_load_image, png_load, tiff_load):
3506 Invoke x_create_x_image_and_pixmap earlier,
3507 to avoid much needless work if the image is too large.
3508 (tiff_load): Treat overly large images as if
3509 x_create_x_image_and_pixmap failed, not as malloc failures.
3510 (gs_load): Use x_check_image_size.
3511
5f8f9cc2
PE
3512 * gtkutil.c: Omit integer casts.
3513 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3514 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3515
5adf60bc
PE
3516 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3517
c8907a93
PE
3518 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3519 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3520 would wrongly return t on a 64-bit host.
3521
e3c25c68
PE
3522 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3523 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3524 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3525 and therefore cause GCC to emit a bogus diagnostic in some cases.
3526
3f791afe
PE
3527 * image.c: Integer signedness and overflow and related fixes.
3528 This is not an exhaustive set of fixes, but it's time to
3529 record what I've got.
3530 (lookup_pixel_color, check_image_size): Remove redundant decls.
3531 (check_image_size): Don't assume that arbitrary EMACS_INT values
3532 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3533 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3534 (tiff_load, imagemagick_load_image):
3535 Check for overflow in size calculations.
3536 (x_create_x_image_and_pixmap): Remove unnecessary test for
3537 xmalloc returning NULL; that can't happen.
3538 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3539 (xpm_color_bucket): Use better integer hashing function.
3540 (xpm_cache_color): Don't possibly over-allocate memory.
3541 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3542 (gif_memory_source):
3543 Use ptrdiff_t, not int or size_t, to record sizes.
3544 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3545 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3546 either works, as we prefer signed integers.
3547 (tiff_read_from_memory, tiff_write_from_memory):
3548 Return tsize_t, not size_t, since that's what the TIFF API wants.
3549 (tiff_read_from_memory): Don't fail simply because the read would
3550 go past EOF; instead, return a short read.
3551 (tiff_load): Omit no-longer-needed casts.
3552 (Fimagemagick_types): Don't assume size fits into 'int'.
3553
3cc5a532
PE
3554 Improve hashing quality when configured --with-wide-int.
3555 * fns.c (hash_string): New function, taken from sxhash_string.
3556 Do not discard information about ASCII character case; this
3557 discarding is no longer needed.
3558 (sxhash-string): Use it. Change sig to match it. Caller changed.
3559 * lisp.h: Declare it.
3560 * lread.c (hash_string): Remove, since we now use fns.c's version.
3561 The fns.c version returns a wider integer if --with-wide-int is
3562 specified, so this should help the quality of the hashing a bit.
3563
b312a492
PE
3564 * emacs.c: Integer overflow minor fix.
3565 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3566 Define only if GNU_LINUX.
3567 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3568
dfd153ae
PE
3569 * dispnew.c: Integer signedness and overflow fixes.
3570 Remove unnecessary forward decls, that were a maintenance hassle.
3571 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3572 All uses changed.
3573 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3574 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3575 (prepare_desired_row, line_draw_cost):
3576 Use int, not unsigned, where either works.
3577 (save_current_matrix, restore_current_matrix):
3578 Use ptrdiff_t, not size_t, where either works.
3579 (init_display): Check for overflow more accurately, and without
3580 relying on undefined behavior.
3581
a81d11a3
PE
3582 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3583 Remove, replacing with the new symbols in lisp.h. All uses changed.
3584 * fileio.c (make_temp_name):
3585 * filelock.c (lock_file_1, lock_file):
3586 * xdisp.c (message_dolog):
3587 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3588 Use pMd etc. instead.
3589 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3590 replacing the pWIDE etc. symbols removed from editfns.c.
3591
3300e6fd
PE
3592 * keyboard.h (num_input_events): Now uintmax_t.
3593 This is (very slightly) less likely to mess up due to wraparound.
3594 All uses changed.
3595
fd05c7e9
PE
3596 * buffer.c: Integer signedness fixes.
3597 (alloc_buffer_text, enlarge_buffer_text):
3598 Use ptrdiff_t rather than size_t when either will do, as we prefer
3599 signed integers.
3600
903fe15d
PE
3601 * alloc.c: Integer signedness and overflow fixes.
3602 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3603 (__malloc_size_t): Default to size_t, not to int.
3604 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3605 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3606 Prefer ptrdiff_t to size_t when either would do, as we prefer
3607 signed integers.
3608 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3609 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3610 Now const. Initialize with values that are in range even if char
3611 is signed.
3612 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3613 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3614 These functions do the right thing with sizes > 2**32.
3615 (check_depth): Now ptrdiff_t, not int.
3616 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3617 Adjust to new way of storing sizes. Check for size overflow bugs
3618 in rest of code.
3619 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3620 slightly wrong anyway, as it missed one instance of
3621 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3622 (refill_memory_reserve): Omit needless cast to size_t.
3623 (mark_object_loop_halt): Mark as externally visible.
3624
ac82cc6a
PE
3625 * xselect.c: Integer signedness and overflow fixes.
3626 (Fx_register_dnd_atom, x_handle_dnd_message):
3627 Use ptrdiff_t, not size_t, since we prefer signed.
3628 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3629 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3630 x_dnd_atoms_size and x_dnd_atoms_length.
3631
c2d1e36d
PE
3632 * doprnt.c: Prefer signed to unsigned when either works.
3633 * eval.c (verror):
3634 * doprnt.c (doprnt):
3635 * lisp.h (doprnt):
3636 * xdisp.c (vmessage):
3637 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3638 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3639 prefer signed arithmetic to avoid comparison confusion.
3640 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3641 but is a bit tricky.
3642
0e926e56
PE
3643 Assume freestanding C89 headers, string.h, stdlib.h.
3644 * data.c, doprnt.c, floatfns.c, print.c:
3645 Include float.h unconditionally.
3646 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3647 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3648 * regex.c: Likewise for stddef.h, string.h.
3649 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3650 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3651 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3652 (STDC_HEADERS): Remove obsolete defines.
3653 * sysdep.c: Include limits.h unconditionally.
3654
9cfdb3ec
PE
3655 Assume support for memcmp, memcpy, memmove, memset.
3656 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3657 * regex.c (memcmp, memcpy):
3658 Remove; we assume C89 now.
3659
3660 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3661 (__malloc_safe_bcopy): Remove; no longer needed.
3662
cf950e6b 3663 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3664 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3665 well either way, and we prefer signed to unsigned.
3666
dbf38e02
LMI
36672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3668
3669 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3670 closes the connection while we're reading (bug#9182).
3671
d6f0886c 36722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3673
d6f0886c
JD
3674 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3675 are specified (Bug#9168).
24e0f6b1 3676
2eb1f9e6
PE
36772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3678
3679 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3680 Found by GCC static checking and --with-wide-int on a 32-bit host.
3681
22381272 36822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3683
3684 * xdisp.c (compute_display_string_pos): Fix logic of caching
3685 previous display string position. Initialize cached_prev_pos to
3686 -1. Fixes slow-down at the beginning of a buffer.
3687
f25e39b4
EZ
36882011-07-24 Eli Zaretskii <eliz@gnu.org>
3689
3690 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3691 for attrs[LFACE_FONTSET_INDEX].
3692
04c4b52e
PE
36932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 * xml.c (parse_region): Remove unused local
3696 that was recently introduced.
3697
c1734fbd
EZ
36982011-07-23 Eli Zaretskii <eliz@gnu.org>
3699
be18c5a5
EZ
3700 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3701 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3702
c1734fbd
EZ
3703 * xdisp.c (move_it_in_display_line_to): Record the best matching
3704 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3705 exit if none of the characters scanned was an exact match.
3706 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3707 when exact match is impossible due to invisible text, and the
3708 lines are truncated.
3709
a258d627
JD
37102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3711
3712 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3713 for OSX >= 10.7.
3714
b6d5a689
EZ
37152011-07-22 Eli Zaretskii <eliz@gnu.org>
3716
0f74f785
EZ
3717 Fix a significant slow-down of cursor motion with C-n, C-p,
3718 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3719 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3720 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3721 (next_element_from_buffer): Call compute_stop_pos_backwards to
3722 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3723 base_level_stop.
3724 (reseat): Don't look for prev_stop, as that could mean a very long
3725 run.
3726 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3727 <cached_disp_overlay_modiff>: Cache for last found display string
3728 position.
551918c1 3729 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3730 about the same buffer in the same area of character positions, and
3731 the buffer wasn't changed since the time the display string
3732 position was cached.
551918c1 3733
b2d0c91a
EZ
37342011-07-22 Eli Zaretskii <eliz@gnu.org>
3735
3736 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3737 is an integer, which is important for empty lines. (Bug#9149)
3738
043604ee
CY
37392011-07-22 Chong Yidong <cyd@stupidchicken.com>
3740
3741 * frame.c (Fmodify_frame_parameters): In tty case, update the
3742 default face if necessary (Bug#4238).
3743
da4adb04
CY
37442011-07-21 Chong Yidong <cyd@stupidchicken.com>
3745
3746 * editfns.c (Fstring_to_char): No need to explain what a character
3747 is in the docstring (Bug#6576).
3748
9abd0532
LMI
37492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3750
3751 * xml.c (parse_region): Make sure we always return a tree.
3752
36881d16
HK
37532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3754
3755 * xml.c (parse_region): If a document contains only comments,
3756 return that, too.
3757
1e98674d
LMI
37582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3759
3760 * xml.c (make_dom): Return comments, too.
3761
590bd467
PE
37622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 Port to OpenBSD.
3765 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3766 and the surrounding thread.
3767 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3768 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3769 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3770 timer goes off.
3771 * s/openbsd.h (BROKEN_SIGIO): Define.
3772 * unexelf.c (unexec) [__OpenBSD__]:
3773 Don't update the .mdebug section of the Alpha COFF symbol table.
3774
f41628b2
LMI
37752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3776
3777 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3778 (bug#8460).
3779
b59b67c5
PE
37802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3781
15e3a074
PE
3782 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3783 This fixes some race conditions on the permissions of any newly
3784 created file.
3785
41bed37d
PE
3786 * alloc.c (valid_pointer_p): Use pipe, not open.
3787 This fixes some permissions issues when debugging.
3788
b59b67c5
PE
3789 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3790 If fchown fails to set both uid and gid, try to set just gid,
3791 as that is sometimes allowed. Adjust the file's mode to eliminate
3792 setuid or setgid bits that are inappropriate if fchown fails.
3793
925a6be7
SM
37942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3795
3796 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3797 to compare Lisp_Objects.
3798 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3799 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3800 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3801
52968808
AS
38022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3803
0a6a104b
AS
3804 * lread.c (read_integer): Unread even EOF character.
3805 (read1): Likewise. Properly record start position of symbol.
3806
52968808
AS
3807 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3808 symbol character follows.
3809
9e381cdd
PE
38102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3813 This works around a problem with the previous change to Fcopy_file.
3814 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3815 and without this change, GCC might complain about discarding
3816 fchown's return value.
3817
b5641435
JB
38182011-07-16 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3821
a8031457
PE
38222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3825
dd889327
LMI
38262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3827
750c33f7
LMI
3828 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3829 it's used from the C level.
3830
dd889327
LMI
3831 * process.c: Use the same condition for POLL_FOR_INPUT in both
3832 keyboard.c and process.c (bug#1858).
3833
87e86684
LM
38342011-07-09 Lawrence Mitchell <wence@gmx.li>
3835
3836 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3837 (Fgnutls_boot): Use it.
3838
64348f40
AS
38392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3840
3841 * doc.c (Fsubstitute_command_keys): Revert last change.
3842
1d698799
LMI
38432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3844
f863868c
LMI
3845 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3846 quotes the next character, and doesn't affect other longer
3847 sequences (bug#8935).
3848
1d698799
LMI
3849 * lread.c (syms_of_lread): Clarify that is isn't only
3850 `eval-buffer' and `eval-defun' that's affected by
3851 `lexical-binding' (bug#8460).
3852
aa4b6df6
EZ
38532011-07-15 Eli Zaretskii <eliz@gnu.org>
3854
3855 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3856 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3857
5d856da6
PE
38582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3859
ad6042bb
PE
3860 Fix minor problems found by static checking.
3861 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3862 (elsz): Now a signed constant, not a size_t var. We prefer signed
3863 types to unsigned, to avoid integer comparison confusion. Without
3864 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3865 "cannot optimize loop, the loop counter may overflow", a symptom
3866 of the confusion.
f00bbb22 3867 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3868 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3869
6468f31c
LMI
38702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3871
49080b10
LMI
3872 * search.c (Fre_search_backward): Mention `case-fold-search' in
3873 all the re_search_* functions (bug#8138).
3874
6468f31c
LMI
3875 * keyboard.c (Fopen_dribble_file): Document when the file is
3876 closed (bug#8056).
3877
c965adc5
EZ
38782011-07-14 Eli Zaretskii <eliz@gnu.org>
3879
df9733bf
EZ
3880 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3881 bidi_cache_idx.
3882
0bb23927
EZ
3883 Support bidi reordering of display and overlay strings.
3884 * xdisp.c (compute_display_string_pos)
3885 (compute_display_string_end): Accept additional argument STRING.
3886 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3887 (reseat_to_string): Initialize bidi_it->string.s and
3888 bidi_it->string.schars.
3889 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3890 NULL (avoids a crash in bidi_paragraph_init).
3891 Initialize itb.string.lstring.
0bb23927
EZ
3892 (init_iterator): Call bidi_init_it only of a valid
3893 buffer position was specified. Initialize paragraph_embedding to
3894 L2R.
3895 (reseat_to_string): Initialize the bidi iterator.
3896 (display_string): If we need to ignore text properties of
3897 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3898 original value of -1 will not work with bidi.)
3899 (compute_display_string_pos): First arg is now struct
3900 `text_pos *'; all callers changed. Support display properties on
3901 Lisp strings.
3902 (compute_display_string_end): Support display properties on Lisp
3903 strings.
3904 (init_iterator, reseat_1, reseat_to_string): Initialize the
3905 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3906 when iterating on a string not from display properties).
640c8776
SM
3907 (compute_display_string_pos, compute_display_string_end):
3908 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3909 arrow keys.
3910 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3911 base_level_stop; instead, set base_level_stop to BEGV.
3912 Fixes crashes in vertical-motion.
0bb23927
EZ
3913 (next_element_from_buffer): Improve commentary for when
3914 the iterator is before prev_stop.
3915 (init_iterator): Initialize bidi_p from the default value of
3916 bidi-display-reordering, not from buffer-local value. Use the
3917 buffer-local value only if initializing for buffer iteration.
3918 (handle_invisible_prop): Support invisible properties on strings
3919 that are being bidi-reordered.
3920 (set_iterator_to_next): Support bidi reordering of C strings and
3921 Lisp strings.
3922 (next_element_from_string): Support bidi reordering of Lisp
3923 strings.
3924 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3925 (display_string): Support display of R2L glyph rows.
3926 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3927 (init_iterator): Don't initialize it->bidi_p for strings
3928 here.
3929 (reseat_to_string): Initialize it->bidi_p for strings here.
3930 (next_element_from_string, next_element_from_c_string)
3931 (next_element_from_buffer): Add xassert's for correspondence
3932 between IT's object being iterated and it->bidi_it.string
3933 structure.
3934 (face_before_or_after_it_pos): Support bidi iteration.
3935 (next_element_from_c_string): Handle the case of the first string
3936 character that is not the first one in the visual order.
3937 (get_visually_first_element): New function, refactored from common
3938 parts of next_element_from_buffer, next_element_from_string, and
3939 next_element_from_c_string.
3940 (tool_bar_lines_needed, redisplay_tool_bar)
3941 (display_menu_bar): Force left-to-right direction. Add a FIXME
3942 comment for making that be controlled by a user option.
3943 (push_it, pop_it): Save and restore the state of the
3944 bidi iterator. Save and restore the bidi_p flag.
3945 (pop_it): Iterate out of display property for string iteration as
3946 well.
3947 (iterate_out_of_display_property): Support iteration over strings.
3948 (handle_single_display_spec): Set up it->bidi_it for iteration
3949 over a display string, and call bidi_init_it.
3950 (handle_single_display_spec, next_overlay_string)
3951 (get_overlay_strings_1, push_display_prop): Set up the bidi
3952 iterator for displaying display or overlay strings.
3953 (forward_to_next_line_start): Don't use the shortcut if
3954 bidi-iterating.
3955 (back_to_previous_visible_line_start): If handle_display_prop
3956 pushed the iterator stack, restore the internal state of the bidi
3957 iterator by calling bidi_pop_it same number of times.
3958 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3959 and we are bidi-iterating, don't decrement the iterator position;
3960 instead, set the first_elt flag in the bidi iterator, to produce
3961 the same effect.
3962 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3963 (push_display_prop): xassert that we are iterating a buffer.
3964 (push_it, pop_it): Save and restore paragraph_embedding member.
3965 (handle_single_display_spec, next_overlay_string)
3966 (get_overlay_strings_1, reseat_1, reseat_to_string)
3967 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3968 correctly. Don't assume unibyte strings are not bidi-reordered.
3969 (compute_display_string_pos)
3970 (compute_display_string_end): Fix handling the case of C string.
3971 (push_it, pop_it): Save and restore from_disp_prop_p.
3972 (handle_single_display_spec, push_display_prop): Set the
3973 from_disp_prop_p flag.
3974 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3975 (pop_it): Call iterate_out_of_display_property only if we are
3976 popping after iteration over a string that came from a display
3977 property. Fix a typo in popping stretch info. Add an assertion
3978 for verifying that the iterator position is in sync with the bidi
3979 iterator.
3980 (handle_single_display_spec, get_overlay_strings_1)
3981 (push_display_prop): Fix initialization of paragraph direction for
3982 string when that of the parent object is not yet determined.
3983 (reseat_1): Call bidi_init_it to resync the bidi
3984 iterator with IT's position. (Bug#7616)
3985 (find_row_edges): If ROW->start.pos gives position
3986 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3987 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3988 Reset the from_disp_prop_p flag.
3989 (SAVE_IT, RESTORE_IT): New macros.
3990 (pos_visible_p, face_before_or_after_it_pos)
3991 (back_to_previous_visible_line_start)
3992 (move_it_in_display_line_to, move_it_in_display_line)
3993 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3994 (try_scrolling, redisplay_window, display_line): Use them when
3995 saving a temporary copy of the iterator and restoring it back.
3996 (back_to_previous_visible_line_start, reseat_1)
3997 (init_iterator): Empty the bidi cache "stack".
3998 (move_it_in_display_line_to): If iterator ended up at
3999 EOL, but we never saw any buffer positions smaller than
4000 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4001 motion in bidi-reordered lines.
4002 (move_it_in_display_line_to): Record prev_method and prev_pos
4003 immediately before the call to set_iterator_to_next. Fixes cursor
4004 motion in bidi-reordered lines with stretch glyphs and strings
4005 displayed in margins. (Bug#8133) (Bug#8867)
4006 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4007 TO_CHARPOS.
640c8776
SM
4008 (pos_visible_p): Support positions in bidi-reordered lines.
4009 Save and restore bidi cache.
0bb23927
EZ
4010
4011 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4012 (bidi_paragraph_info): Delete unused struct.
4013 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4014 (bidi_cache_start): New variable.
4015 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4016 to zero.
4017 (bidi_cache_fetch_state, bidi_cache_search)
4018 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4019 (bidi_cache_find, bidi_peek_at_next_level)
4020 (bidi_level_of_next_char, bidi_find_other_level_edge)
4021 (bidi_move_to_visually_next): Compare cache index with
4022 bidi_cache_start rather than with zero.
4023 (bidi_fetch_char): Accept new argument STRING; all callers
4024 changed. Support iteration over a string. Support strings with
4025 display properties. Support unibyte strings. Fix the type of
4026 `len' according to what STRING_CHAR_AND_LENGTH expects.
4027 (bidi_paragraph_init, bidi_resolve_explicit_1)
4028 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4029 (bidi_level_of_next_char, bidi_move_to_visually_next):
4030 Support iteration over a string.
0bb23927
EZ
4031 (bidi_set_sor_type, bidi_resolve_explicit_1)
4032 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4033 can now be zero (for strings); special values 0 and -1 were
4034 changed to -1 and -2, respectively.
4035 (bidi_char_at_pos): New function.
4036 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4037 Call it instead of FETCH_MULTIBYTE_CHAR.
4038 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4039 initialized to valid values.
4040 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4041 values.
4042 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4043 the test for valid cached positions. Fix the logic for looking up
4044 the sentinel state in the cache. GCPRO the Lisp string we are
4045 iterating.
4046 (bidi_push_it, bidi_pop_it): New functions.
4047 (bidi_initialize): Initialize the bidi cache start stack pointer.
4048 (bidi_cache_ensure_space): New function, refactored from part of
4049 bidi_cache_iterator_state. Don't assume the required size is just
4050 one BIDI_CACHE_CHUNK away.
4051 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4052 (bidi_count_bytes, bidi_char_at_pos): New functions.
4053 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4054 always valid if bidi_cache_idx is valid.
4055 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4056 is valid if it's going to be used.
4057 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4058 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4059 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4060 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4061 (bidi_find_other_level_edge, bidi_cache_start_stack):
4062 All variables related to cache indices are now EMACS_INT.
c965adc5 4063
0bb23927
EZ
4064 * dispextern.h (struct bidi_string_data): New structure.
4065 (struct bidi_it): New member `string'. Make flag members be 1-bit
4066 fields, and put them last in the struct.
640c8776
SM
4067 (compute_display_string_pos, compute_display_string_end):
4068 Update prototypes.
0bb23927
EZ
4069 (bidi_push_it, bidi_pop_it): Add prototypes.
4070 (struct iterator_stack_entry): New members bidi_p,
4071 paragraph_embedding, and from_disp_prop_p.
4072 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4073 (bidi_shelve_cache, bidi_unshelve_cache):
4074 Declare prototypes.
0bb23927
EZ
4075
4076 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4077 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4078 and vector-like objects.
4079
4080 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4081 cache around display iteration.
4082
4083 * window.c (Fwindow_end, window_scroll_pixel_based)
4084 (displayed_window_lines, Frecenter): Save and restore the bidi
4085 cache around display iteration.
4086
3bbd2265
LMI
40872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4088
4089 * editfns.c (Fdelete_region): Clarify the use of the named
4090 parameters (bug#6788).
4091
adc47434
MR
40922011-07-14 Martin Rudalics <rudalics@gmx.at>
4093
4094 * indent.c (Fvertical_motion): Set and restore w->pointm when
4095 saving and restoring the window's buffer (Bug#9006).
4096
837c31f8
LMI
40972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4098
4099 * editfns.c (Fstring_to_char): Clarify just what is returned
4100 (bug#6576). Text by Eli Zaretskii.
4101
ac389d0c
JB
41022011-07-13 Juanma Barranquero <lekktu@gmail.com>
4103
4104 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4105
0be0ce47
EZ
41062011-07-13 Eli Zaretskii <eliz@gnu.org>
4107
4108 * buffer.c (mmap_find): Fix a typo.
4109
cd18e7e3
JB
41102011-07-13 Johan Bockgård <bojohan@gnu.org>
4111
4112 Fix execution of x selection hooks.
4113 * xselect.c (Qx_lost_selection_functions)
4114 (Qx_sent_selection_functions): New vars.
4115 (syms_of_xselect): DEFSYM them.
4116 (x_handle_selection_request): Pass Qx_sent_selection_functions
4117 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4118 (x_handle_selection_clear,x_clear_frame_selections):
4119 Pass Qx_lost_selection_functions rather than
4120 Vx_lost_selection_functions to Frun_hook_with_args.
4121
47ea7f44
PE
41222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4123
ac389d0c 4124 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4125 The old code sometimes used this field without initializing it.
4126
47ea7f44
PE
4127 * alloc.c (gc_sweep): Don't read past end of array.
4128 In theory, the old code could also have corrupted Emacs internals,
4129 though it'd be very unlikely.
4130
bc985c87
AS
41312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4132
4133 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4134 argument. (Bug#4026)
bc985c87 4135
0cf34688
LMI
41362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4137
b3dadd76
LMI
4138 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4139 key" (bug#4257).
4140
0cf34688
LMI
4141 * window.c (Fset_window_start): Doc fix (bug#4199).
4142 (Fset_window_hscroll): Ditto.
4143
270768cd
PE
41442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4145
077e3dda 4146 Fix minor new problems caught by GCC 4.6.1.
270768cd 4147 * term.c (init_tty): Remove unused local.
490011a6 4148 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4149 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4150 not used otherwise.
270768cd 4151
b1f58454
CY
41522011-07-12 Chong Yidong <cyd@stupidchicken.com>
4153
4154 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4155
22b9578d
LMI
41562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157
6e70ab07
LMI
4158 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4159 are the mini-buffer and the echo area (bug#3320).
4160
22b9578d
LMI
4161 * term.c (init_tty): Remove support for supdup, c10 and perq
4162 terminals, which are no longer supported (bug#1482).
4163
8974cc9f
JB
41642011-07-10 Johan Bockgård <bojohan@gnu.org>
4165
4166 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4167
a560d974
JD
41682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4169
4170 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4171 for non-popups (Bug#3642).
4172
1dae0f0a
AS
41732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4174
268c2c36 4175 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4176 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4177 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4178 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4179 * data.c (fmod): Likewise.
4180 * dispnew.c (swap_glyphs_in_rows): Likewise.
4181 * emacs.c (memory_warning_signal): Likewise.
4182 * floatfns.c (float_error): Likewise.
4183 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4184 (otf_open, font_otf_capability, generate_otf_features)
4185 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4186 Likewise.
4187 * image.c (pbm_read_file): Likewise.
4188 * indent.c (string_display_width): Likewise.
4189 * intervals.c (check_for_interval, search_for_interval)
4190 (inc_interval_count, count_intervals, root_interval)
4191 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4192 * lread.c (defalias): Likewise.
268c2c36 4193 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4194 * regex.c (set_image_of_range_1, set_image_of_range)
4195 (regex_grow_registers): Likewise.
4196 * sysdep.c (strerror): Likewise.
4197 * termcap.c (valid_filename_p, tprint, main): Likewise.
4198 * tparam.c (main): Likewise.
4199 * unexhp9k800.c (run_time_remap, save_data_space)
4200 (update_file_ptrs, read_header, write_header, calculate_checksum)
4201 (copy_file, copy_rest, display_header): Likewise.
4202 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4203 Likewise.
4204 * xdisp.c (check_it): Likewise.
4205 * xfaces.c (register_color, unregister_color, unregister_colors):
4206 Likewise.
4207 * xfns.c (print_fontset_result): Likewise.
4208 * xrdb.c (member, fatal, main): Likewise.
4209
99033785
PE
42102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4211
4212 Fix minor problems found by static checking (Bug#9031).
4213 * chartab.c (char_table_set_range, map_sub_char_table):
4214 Remove unused locals.
4215 (uniprop_table): Now static.
4216 * composite.c (_work_char): Remove unused static var.
4217
9cb2ac56
JB
42182011-07-09 Juanma Barranquero <lekktu@gmail.com>
4219
4220 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4221
f25661f0
JD
42222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4223
4224 * gtkutil.c (qttip_cb): Remove code without function.
4225
8278c4fe
EZ
42262011-07-09 Eli Zaretskii <eliz@gnu.org>
4227
4228 * w32.c (pthread_sigmask): New stub.
4229
1692ae2d 42302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4231
8a6ebd58 4232 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4233 sigprocmask is portable only for single-threaded applications, and
4234 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4235 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4236 (LIBES): Use it.
4237 * callproc.c (Fcall_process):
4238 * process.c (create_process):
4239 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4240 Use pthread_sigmask, not sigprocmask.
123403e4 4241
1b854618
JD
42422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4243
4244 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4245 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4246 wrong (Bug#8591).
4247
3fe4b549
JD
42482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4249
0ce7e563
JD
4250 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4251 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4252 (xg_hide_tooltip): Fix comment.
4253
3fe4b549
JD
4254 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4255 in registerServicesMenuSendTypes.
4256 (validRequestorForSendType): Don't check ns_return_types.
4257
4258 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4259 ns_return_type.
4260
5df75e47
JR
42612011-07-08 Jason Rumney <jasonr@gnu.org>
4262
22610910
JR
4263 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4264 SH_SHOW for hidden windows (Bug#5482).
4265
5df75e47
JR
4266 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4267 frame struct members of non-existent frames (Bug#6284).
4268
699c10bd
JD
42692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4270
4393663b
JD
4271 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4272 variable firstTime not needed on OSX >= 10.6.
4273 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4274 >= 10.5. Use setKnobProportion, setDoubleValue.
4275
4276 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4277 (MAC_OS_X_VERSION_10_5): Define if not defined.
4278 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4279 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4280 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4281
4282 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4283 cString and lossyCString on OSX >= 10.4
4284
58179cce 4285 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4286 sizeToFit on OSX >= 10.2.
4287
4288 * nsimage.m (allocInitFromFile): Don't use deprecated method
4289 bestRepresentationForDevice on OSX >= 10.6.
4290
4291 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4292 to avoid warning.
4293
4294 * emacs.c: Declare unexec_init_emacs_zone.
4295
a63e0781
JD
4296 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4297
699c10bd
JD
4298 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4299
4300 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4301 on svcsMenu (Bug#8842).
4302
4303 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4304 ns_return_types.
4305 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4306
4307 * nsterm.m (QUTF8_STRING): Declare.
4308 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4309 (validRequestorForSendType): Return type is (id).
4310 Change indexOfObjectIdenticalTo to indexOfObject.
4311 Check if we have local selection before returning self (Bug#8842).
4312 (writeSelectionToPasteboard): Put local selection into paste board
4313 if we have a local selection (Bug#8842).
4314 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4315
4316 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4317 (ns_get_local_selection): Declare.
4318
54e10184
LMI
43192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4320
9888ff71
LMI
4321 * keymap.c (describe_map_tree): Don't insert a double newline at
4322 the end of the buffer (bug#1169) and return whether we inserted
4323 something.
4324
54e10184
LMI
4325 * callint.c (Fcall_interactively): Change "reading args" to
4326 "providing args" to try to clarify what it does (bug#1010).
4327
15fa4783
KH
43282011-07-07 Kenichi Handa <handa@m17n.org>
4329
4330 * composite.c (composition_compute_stop_pos): Ignore a static
4331 composition starting before CHARPOS (Bug#8915).
4332
4333 * xdisp.c (handle_composition_prop): Likewise.
4334
a8815b00
EZ
43352011-07-07 Eli Zaretskii <eliz@gnu.org>
4336
4337 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4338 (Bug#9015)
4339
ef7b981d 43402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4341
4342 * character.h (unicode_category_t): New enum type.
4343
4344 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4345 (Qchar_code_property_table): New variable.
4346 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4347 (UNIPROP_COMPRESSED_FORM_P): New macros.
4348 (char_table_ascii): Uncompress the compressed values.
4349 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4350 Uncompress the compressed values.
ac389d0c 4351 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4352 (char_table_ref_and_range): Uncompress the compressed values.
4353 (sub_char_table_set): New arg is_uniprop. Callers changed.
4354 Uncompress the compressed values.
4355 (sub_char_table_set_range): Args changed. Callers changed.
4356 (char_table_set_range): Adjuted for the above change.
4357 (map_sub_char_table): Delete args default_val and parent. Add arg
4358 top. Give decoded values to a Lisp function.
640c8776 4359 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4360 values to a Lisp function. Gcpro more variables.
4361 (uniprop_table_uncompress)
4362 (uniprop_decode_value_run_length): New functions.
4363 (uniprop_decoder, uniprop_decoder_count): New variables.
4364 (uniprop_get_decoder, uniprop_encode_value_character)
4365 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4366 New functions.
4367 (uniprop_encoder, uniprop_encoder_count): New variables.
4368 (uniprop_get_encoder, uniprop_table)
4369 (Funicode_property_table_internal, Fget_unicode_property_internal)
4370 (Fput_unicode_property_internal): New functions.
4371 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4372 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4373 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4374 char-code-property-alist.
4375
640c8776 4376 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4377 Vunicode_category_table.
4378
640c8776 4379 * font.c (font_range): Adjust for the change of
c805dec0
KH
4380 Vunicode_category_table.
4381
76b397fb
DN
43822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4383
4384 * m/iris4d.h: Remove file, move contents ...
4385 * s/irix6-5.h: ... here.
4386
22b4128e
PE
43872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4388
4389 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4390 * alloc.c (mark_buffer):
4391 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4392 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4393 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4394 This isn't true in general, and it's particularly not true
4395 if Emacs is configured with --with-wide-int.
4396 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4397 New macros, used in the buffer.c change.
4398
869795d6
JD
43992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4400
4401 * xsettings.c: Use both GConf and GSettings if both are available.
4402 (store_config_changed_event): Add comment.
4403 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4404 (store_tool_bar_style_changed): New functions.
5e617bc2 4405 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4406 (struct xsettings): Move font inside HAVE_XFT.
4407 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4408 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4409 Move inside HAVE_XFT.
640c8776 4410 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4411 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4412 also.
4413 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4414 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4415 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4416 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4417 (parse_settings): Move check for font inside HAVE_XFT.
4418 (read_settings, apply_xft_settings): Add comment.
4419 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4420 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4421 call store_font_name_changed.
4422 (xft_settings_event): Add comment.
4423 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4424 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4425 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4426 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4427 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4428 (xsettings_get_system_font, xsettings_get_system_normal_font):
4429 Add comment.
869795d6 4430
d8ed26bd
PE
44312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4432
4433 Random fixes. E.g., (random) never returned negative values.
4434 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4435 subseconds part to the entropy, as that's a bit more random.
4436 Prefer signed to unsigned, since the signedness doesn't matter and
4437 in general we prefer signed. When given a limit, use a
4438 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4439 latter isn't right if USE_2_TAGS_FOR_INTS.
4440 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4441 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4442
cabf1cac
SM
44432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4444
4445 * textprop.c (text_property_stickiness):
4446 Obey Vtext_property_default_nonsticky.
4447 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4448 * w32fns.c (syms_of_w32fns):
4449 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4450
6e9b2be9
PE
44512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4454 This is more efficient than Ffile_directory_p and avoids a minor race.
4455
90186c68
LMI
44562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4457
7c301272
LMI
4458 * buffer.c (Foverlay_put): Say what the return value is
4459 (bug#7835).
4460
c4f2d8d4
LMI
4461 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4462 is a directory before asking whether to use the file name
4463 (bug#7564).
ad637907
LMI
4464 (barf_or_query_if_file_exists): Make the "File is a directory"
4465 error be more correct.
c4f2d8d4 4466
90186c68
LMI
4467 * fns.c (Frequire): Remove the mention of the .gz files, since
4468 that's installation-specific, but keep the mention of
4469 `get-load-suffixes'.
4470
da64016e
PE
44712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4472
4473 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4474 Report string overflow if the output is too long.
4475
7d47b580
JB
44762011-07-04 Juanma Barranquero <lekktu@gmail.com>
4477
a555cb87
JB
4478 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4479 (syms_of_gnutls): Remove duplicate DEFSYM for
4480 Qgnutls_bootprop_verify_hostname_error, an error for
4481 Qgnutls_bootprop_verify_error (which is no longer used).
4482
7d47b580
JB
4483 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4484 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4485 Also (re)move comments that are misplaced or no longer relevant.
4486
1e49bfab
LMI
44872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4488
4489 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4490
1485f4c0
CY
44912011-07-03 Chong Yidong <cyd@stupidchicken.com>
4492
4493 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4494 and background color parameters if they have been changed.
4495
a9ab721e
LMI
44962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4497
4498 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4499
cf7cff57
PE
45002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4501
2e13213d
PE
4502 * xsettings.c (SYSTEM_FONT): Define only when used.
4503 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4504
cf7cff57
PE
4505 * keymap.c (access_keymap_1): Now static.
4506
7a8e04f7
CY
45072011-07-02 Chong Yidong <cyd@stupidchicken.com>
4508
4509 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4510 leave any prefix arg for the up event (Bug#1586).
4511
61352f62
LMI
45122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4513
69bb1ef7
LMI
4514 * lread.c (syms_of_lread): Mention single symbols defined by
4515 `defvar' or `defconst' (bug#7154).
4516
61352f62 4517 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4518 (Frequire): Mention get-load-suffixes.
61352f62 4519
28545e04
MR
45202011-07-02 Martin Rudalics <rudalics@gmx.at>
4521
4522 * window.h (window): Remove clone_number slot.
4523 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4524 Remove.
4525 (make_parent_window, make_window, saved_window)
4526 (Fset_window_configuration, save_window_save): Don't deal with
4527 clone numbers.
4528 * buffer.c (Qclone_number): Remove declaration.
4529 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4530
3349e122
SM
45312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4532
4533 Add multiple inheritance to keymaps.
4534 * keymap.c (Fmake_composed_keymap): New function.
4535 (Fset_keymap_parent): Simplify.
4536 (fix_submap_inheritance): Remove.
4537 (access_keymap_1): New function extracted from access_keymap to handle
4538 embedded parents and handle lists of maps.
4539 (access_keymap): Use it.
4540 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4541 (Fcopy_keymap): Handle embedded parents.
4542 (Fcommand_remapping, define_as_prefix): Simplify.
4543 (Fkey_binding): Simplify.
4544 (syms_of_keymap): Move minibuffer-local-completion-map,
4545 minibuffer-local-filename-completion-map,
4546 minibuffer-local-must-match-map, and
4547 minibuffer-local-filename-must-match-map to Elisp.
4548 (syms_of_keymap): Defsubr make-composed-keymap.
4549 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4550 (parse_menu_item): Trivial simplification.
4551
3279eb87
GM
45522011-07-01 Glenn Morris <rgm@gnu.org>
4553
4554 * Makefile.in (SETTINGS_LIBS): Fix typo.
4555
4550efdf
KI
45562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4557
4558 * coding.c (Fencode_coding_string): Record the last coding system
4559 used, as the function doc string says (bug#8738).
4560
0949d2b6
JD
45612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4562
4563 * xsettings.c (store_monospaced_changed): Take new font as arg and
4564 check for change against current_mono_font.
4565 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4566 (emacs_settings_constructor, emacs_settings_get_property)
4567 (emacs_settings_set_property, emacs_settings_class_init)
4568 (emacs_settings_init, gsettings_obj): Remove.
4569 (something_changedCB): New function for HAVE_GSETTINGS.
4570 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4571 with value as argument.
4572 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4573 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4574 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4575 "changed".
4576
4577 * xgselect.c: Add defined (HAVE_GSETTINGS).
4578 (xgselect_initialize): Ditto.
4579
4580 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4581 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4582 xg_select.
4583
bbc6b304
PE
45842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 * eval.c (struct backtrace): Simplify and port the data structure.
4587 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4588 signed bit field, as this assumption is not portable and it makes
4589 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4590 "char debug_on_exit : 1" as this is not portable either; instead,
4591 use the portable "unsigned int debug_on_exit : 1". Remove unused
4592 member evalargs. Remove obsolete comments about cc bombing out.
4593
9851bfc5
JD
45942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4595
51bb811f 4596 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4597 Let HAVE_GSETTINGS override HAVE_GCONF.
4598 (store_monospaced_changed): New function.
4599 (EMACS_SETTINGS): A new type derived from GObject to handle
4600 GSettings notifications.
4601 (emacs_settings_constructor, emacs_settings_get_property)
4602 (emacs_settings_set_property, emacs_settings_class_init):
4603 New functions.
4604 (gsettings_client, gsettings_obj): New variables.
4605 (GSETTINGS_SCHEMA): New define.
4606 (something_changedCB): Call store_monospaced_changed.
4607 (init_gsettings): New function.
4608 (xsettings_initialize): Call init_gsettings.
4609 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4610 to NULL.
4611
640c8776 4612 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4613 GCONF_CFLAGS/LIBS.
4614
5386012d
MR
46152011-06-29 Martin Rudalics <rudalics@gmx.at>
4616
4617 * window.c (resize_root_window, grow_mini_window)
4618 (shrink_mini_window): Rename Qresize_root_window to
4619 Qwindow_resize_root_window and Qresize_root_window_vertically to
4620 Qwindow_resize_root_window_vertically.
4621
f13e0b08
PE
46222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4625
94515237
JB
46262011-06-27 Juanma Barranquero <lekktu@gmail.com>
4627
4628 * makefile.w32-in: Redesign dependencies so they reflect more
4629 clearly which files are directly included by each source file,
4630 and not through other includes.
4631
e43b6e43
MR
46322011-06-27 Martin Rudalics <rudalics@gmx.at>
4633
4634 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4635 (sort_overlays, overlay_strings): When an overlay's clone number
4636 matches the window's clone number process the overlay even if
4637 the overlay's window property doesn't match the current window.
4638
d68443dc
MR
4639 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4640 (Fwindow_hchild): Rename to Fwindow_left_child.
4641 (Fwindow_next): Rename to Fwindow_next_sibling.
4642 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4643 (resize_window_check): Rename to window_resize_check.
4644 (resize_window_apply): Rename to window_resize_apply.
4645 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4646 (Fdelete_other_windows_internal, resize_frame_windows)
4647 (Fsplit_window_internal, Fdelete_window_internal)
4648 (grow_mini_window, shrink_mini_window)
4649 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4650
c7e73be5
JD
46512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4652
4653 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4654 (emacs_fixed_set_min_size): Remove.
4655 (emacs_fixed_new): Take frame as argument.
4656
4657 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4658 (_EmacsFixedPrivate): Remove minwidth/height.
4659 Add struct frame *f.
4660 (emacs_fixed_init): Initialize priv->f.
4661 (get_parent_class, emacs_fixed_set_min_size): Remove.
4662 (emacs_fixed_new): Set priv->f to argument.
4663 (emacs_fixed_get_preferred_width)
4664 (emacs_fixed_get_preferred_height): Use min_width/height from
4665 frames size_hint to set minimum and natural (Bug#8919).
4666 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4667 and use min_width/height from frames size_hint to set
4668 min_width/height (Bug#8919).
4669
4670 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4671 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4672 Fix indentation.
c7e73be5 4673
cf99dcf8
EZ
46742011-06-26 Eli Zaretskii <eliz@gnu.org>
4675
4676 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4677 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4678 called at ZV.
4679
029529ac
CY
46802011-06-26 Chong Yidong <cyd@stupidchicken.com>
4681
4682 * process.c (wait_reading_process_output): Bypass select if
4683 waiting for a cell while ignoring keyboard input, and input is
4684 pending. Suggested by Jan Djärv (Bug#8869).
4685
7a7ef429
PE
46862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4687
4688 Use gnulib's dup2 module instead of rolling our own.
4689 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4690
11fdef7d 46912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4692
4693 * dispnew.c (scrolling_window): Before scrolling, turn off a
4694 mouse-highlight in the window being scrolled.
4695
cd3520a4
JB
46962011-06-24 Juanma Barranquero <lekktu@gmail.com>
4697
4698 Move DEFSYM to lisp.h and use everywhere.
4699
4700 * character.h (DEFSYM): Move declaration...
4701 * lisp.h (DEFSYM): ...here.
4702
4703 * gnutls.c:
4704 * minibuf.c:
4705 * w32menu.c:
4706 * w32proc.c:
4707 * w32select.c: Don't include character.h.
4708
4709 * alloc.c (syms_of_alloc):
4710 * buffer.c (syms_of_buffer):
4711 * bytecode.c (syms_of_bytecode):
4712 * callint.c (syms_of_callint):
4713 * casefiddle.c (syms_of_casefiddle):
4714 * casetab.c (init_casetab_once):
4715 * category.c (init_category_once, syms_of_category):
4716 * ccl.c (syms_of_ccl):
4717 * cmds.c (syms_of_cmds):
4718 * composite.c (syms_of_composite):
4719 * dbusbind.c (syms_of_dbusbind):
4720 * dired.c (syms_of_dired):
4721 * dispnew.c (syms_of_display):
4722 * doc.c (syms_of_doc):
4723 * editfns.c (syms_of_editfns):
4724 * emacs.c (syms_of_emacs):
4725 * eval.c (syms_of_eval):
4726 * fileio.c (syms_of_fileio):
4727 * fns.c (syms_of_fns):
4728 * frame.c (syms_of_frame):
4729 * fringe.c (syms_of_fringe):
4730 * insdel.c (syms_of_insdel):
4731 * keymap.c (syms_of_keymap):
4732 * lread.c (init_obarray, syms_of_lread):
4733 * macros.c (syms_of_macros):
4734 * msdos.c (syms_of_msdos):
4735 * print.c (syms_of_print):
4736 * process.c (syms_of_process):
4737 * search.c (syms_of_search):
4738 * sound.c (syms_of_sound):
4739 * syntax.c (init_syntax_once, syms_of_syntax):
4740 * terminal.c (syms_of_terminal):
4741 * textprop.c (syms_of_textprop):
4742 * undo.c (syms_of_undo):
4743 * w32.c (globals_of_w32):
4744 * window.c (syms_of_window):
4745 * xdisp.c (syms_of_xdisp):
4746 * xfaces.c (syms_of_xfaces):
4747 * xfns.c (syms_of_xfns):
4748 * xmenu.c (syms_of_xmenu):
4749 * xsettings.c (syms_of_xsettings):
4750 * xterm.c (syms_of_xterm): Use DEFSYM.
4751
4228cf16
TZ
47522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4753
cd3520a4 4754 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4755
7fcccf1e
PE
47562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4757
7efb4e0e
PE
4758 Integer and buffer overflow fixes (Bug#8873).
4759
ff5844ad
PE
4760 * print.c (printchar, strout): Check for string overflow.
4761 (PRINTPREPARE, printchar, strout):
4762 Don't set size unless allocation succeeds.
4763
90532f02
PE
4764 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4765 for sizes. Check for string overflow more accurately.
4766 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4767
6d84508d
PE
4768 * macros.c: Integer and buffer overflow fixes.
4769 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4770 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4771 Use ptrdiff_t, not int, for sizes.
4772 Don't increment bufsize until after realloc succeeds.
4773 Check for size-calculation overflow.
4774 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4775
437b2cb4
PE
4776 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4777
8b9ac8b4
PE
4778 * lread.c: Integer overflow fixes.
4779 (read_integer): Radix is now EMACS_INT, not int,
4780 to improve quality of diagnostics for out-of-range radices.
4781 Calculate buffer size correctly for out-of-range radices.
4782 (read1): Check for integer overflow in radices, and in
4783 read-circle numbers.
82cb60d3
PE
4784 (read_escape): Avoid int overflow.
4785 (Fload, openp, read_buffer_size, read1)
4786 (substitute_object_recurse, read_vector, read_list, map_obarray):
4787 Use ptrdiff_t, not int, for sizes.
4788 (read1): Use EMACS_INT, not int, for sizes.
20270765 4789 Check for size overflow.
8b9ac8b4 4790
7fcccf1e
PE
4791 * image.c (cache_image): Check for size arithmetic overflow.
4792
bfbbd7e7
PE
4793 * lread.c: Integer overflow issues.
4794 (saved_doc_string_size, saved_doc_string_length)
4795 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4796 Now ptrdiff_t, not int.
4797 (read1): Don't assume doc string length fits in int. Check for
4798 out-of-range doc string lengths.
4799 (read_list): Don't assume file position fits in int.
39019e54 4800 (read_escape): Check for hex character overflow.
bfbbd7e7 4801
4e323265
LL
48022011-06-22 Leo Liu <sdl.web@gmail.com>
4803
4804 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4805 Move to minibuffer.el.
4806
85fece3e
PE
48072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4808
20b84ce9 4809 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4810 The following patches are for when GLYPH_DEBUG && !XASSERT.
4811 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4812 * dispnew.c (flush_stdout):
4813 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4814 Mark as externally visible.
4815 * dispnew.c (check_window_matrix_pointers): Now static.
4816 * dispnew.c (window_to_frame_vpos):
4817 * xfns.c (unwind_create_frame):
4818 * xterm.c (x_check_font): Remove unused local.
4819 * scroll.c (CHECK_BOUNDS):
4820 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4821 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4822 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4823 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4824 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4825 Now static.
4826 (debug_method_add): Use va_list and vsprintf rather than relying
4827 on undefined behavior with wrong number of arguments.
4828 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4829 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4830 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4831 since we're not interested in debugging glyphs with old libraries.
4832 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4833 GCC 4.6.0's static checking.
4834
0766b489
PE
48352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4836
31fd4b32
PE
4837 Integer overflow and signedness fixes (Bug#8873).
4838 A few related buffer overrun fixes, too.
4839
b79e8648
PE
4840 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4841
0766b489
PE
4842 * dispextern.h (struct face.stipple):
4843 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4844 (x_bitmap_mask, x_allocate_bitmap_record)
4845 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4846 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4847 (x_create_bitmap_from_xpm_data):
4848 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4849 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4850 (.bitmaps_last):
4851 * xfaces.c (load_pixmap):
4852 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4853 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4854 (.bitmaps_last, struct x_output.icon_bitmap):
4855 Use ptrdiff_t, not int, for bitmap indexes.
4856 (x_allocate_bitmap_record): Check for size overflow.
4857 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4858
b081724f
PE
4859 Use ptrdiff_t, not int, for overlay counts.
4860 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4861 * editfns.c (overlays_around, get_pos_property):
4862 * textprop.c (get_char_property_and_overlay):
4863 * xdisp.c (next_overlay_change, note_mouse_highlight):
4864 * xfaces.c (face_at_buffer_position):
21514da7
PE
4865 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4866 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4867 (Fnext_overlay_change, Fprevious_overlay_change)
4868 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4869 Use ptrdiff_t, not int, for sizes.
21514da7 4870 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4871
3de73e5e
PE
4872 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4873
2606c57b
PE
4874 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4875 (x_session_initialize): Do not assume string length fits in int.
4876
aaafe47a
PE
4877 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4878 This is unlikely, but can occur if DPI is outlandish.
4879
2674ddc8 4880 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4881 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4882
28154962
PE
4883 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4884 * xrdb.c (magic_file_p, search_magic_path):
4885 Omit last arg SUFFIX; it was always 0. All callers changed.
4886 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4887
7de51af5
PE
4888 * xfont.c (xfont_match): Avoid need for strlen.
4889
25ed6cc3
PE
4890 * xfns.c: Don't assume strlen fits in int.
4891 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4892
4eab31dd
PE
4893 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4894 not unsigned long, as we prefer signed integers. All callers changed.
4895 Detect integer overflow in repeat count.
4896 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4897 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4898
171e2a58
PE
4899 * termcap.c: Don't assume sizes fit in int and never overflow.
4900 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4901 (gobble_line): Check for size-calculation overflow.
4902
ad39faca 4903 * minibuf.c (Fread_buffer):
6e5bb2dc 4904 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4905 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4906 Don't assume string length fits in int.
4907
52c61c22 4908 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4909 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4910
b5b8c9e5
PE
4911 * font.c: Don't assume string length fits in int.
4912 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4913 Use ptrdiff_t, not int.
ccd6111c
PE
4914 (font_intern_prop): Don't assume string length fits in int.
4915 Don't assume integer property fits in fixnum.
4916 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4917
882f0d81 4918 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4919 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4920 Reformulate so as not to need the command string.
4921 Invoke gzip -cd rather than gunzip, as it's more portable.
4922 (lock_info_type, lock_file_1, lock_file):
4923 Don't assume pid_t and time_t fit in unsigned long.
4924 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4925 (current_lock_owner): Prefer signed type for sizes.
4926 Use memcpy, not strncpy, where memcpy is what is really wanted.
4927 Don't assume (via atoi) that time_t and pid_t fit in int.
4928 Check for time_t and/or pid_t out of range, e.g., via a network share.
4929 Don't alloca where an auto var works fine.
4930
93f4cf88
PE
4931 * fileio.c: Fix some integer overflow issues.
4932 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4933 Don't assume string length fits in int.
4934 (directory_file_name): Don't assume string length fits in long.
4935 (make_temp_name): Don't assume pid fits in int, or that its print
4936 length is less than 20.
4937
f3e92b69
PE
4938 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4939
1bfdaf10
PE
4940 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4941
35016e9a
PE
4942 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4943
3d1e65a1
PE
4944 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4945 We prefer signed integers, even for size calculations.
4946
0b963a93
PE
4947 * emacs.c: Don't assume string length fits in 'int'.
4948 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4949 (main): Don't invoke strlen when not needed.
4950
573f4b54
PE
4951 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4952 (XD_DEBUG_MESSAGE): Don't waste a byte.
4953
989f33ba
PE
4954 * callproc.c (getenv_internal_1, getenv_internal)
4955 (Fgetenv_internal):
965d34eb
PE
4956 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4957
e4d29b33
PE
4958 * lread.c (invalid_syntax): Omit length argument.
4959 All uses changed. This doesn't fix a bug, but it simplifies the
4960 code away from its former Hollerith-constant appearance, and it's
4961 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4962 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4963
eb49b136
PE
4964 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4965 This didn't break anything, but it didn't help either.
4966 It's confusing to put a bogus integer in a place where the actual
4967 value does not matter.
9f62aeb1 4968 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4969 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4970
15375a22
PE
4971 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4972 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4973 implementation.
b61cc01c
PE
4974 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4975 We prefer signed types, and the value cannot exceed the EMACS_INT
4976 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4977 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4978 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4979 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4980
53b2623d
PE
4981 * indent.c (sane_tab_width): New function.
4982 (current_column, scan_for_column, Findent_to, position_indentation)
4983 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4984 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4985
51cab52b 4986 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4987
f2ed8a70
PE
4988 * lisp.h (lint_assume): New macro.
4989 * composite.c (composition_gstring_put_cache):
4990 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4991
abe80cc6
PE
4992 * editfns.c, insdel.c:
4993 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4994
b02c740e
PE
4995 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4996
ebc96716
PE
4997 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4998
b4e50fa0 4999 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5000 Use much-faster test for byte-length change.
311d5d7c 5001 Don't assume string byte-length fits in 'int'.
a4cf38e4 5002 Check that character arg fits in 'int'.
85461888 5003 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5004
c0c1ee9f
PE
5005 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5006
a498d7f4
PE
5007 * fns.c (concat): Catch string overflow earlier.
5008 Do not rely on integer wraparound.
5009
51cab52b
PE
5010 * dispextern.h (struct it.overlay_strings_charpos)
5011 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5012 * xdisp.c (forward_to_next_line_start)
5013 (back_to_previous_visible_line_start)
5014 (reseat_at_next_visible_line_start, next_element_from_buffer):
5015 Don't arbitrarily truncate the value of 'selective' to int.
5016
76031fad
PE
5017 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5018
5eb55db9
PE
5019 * composite.c: Don't truncate sizes to 'int'.
5020 (composition_gstring_p, composition_reseat_it)
5021 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5022 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5023 not EMACS_UINT, for indexes.
5eb55db9 5024
0703a717
PE
5025 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5026
d6202519
PE
5027 * buffer.c: Include <verify.h>.
5028 (struct sortvec.priority, struct sortstr.priority):
8961a454 5029 Now EMACS_INT, not int.
c20998a7 5030 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5031 (struct sortstr.size, record_overlay_string)
5032 (struct sortstrlist.size, struct sortlist.used):
5033 Don't truncate size to int.
5034 (record_overlay_string): Check for size-calculation overflow.
d6202519 5035 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5036
d5a19415
JM
50372011-06-22 Jim Meyering <meyering@redhat.com>
5038
029529ac 5039 Don't leak an XBM-image-sized buffer
d5a19415
JM
5040 * image.c (xbm_load): Free the image buffer after using it.
5041
a9041e6c
PE
50422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5043
5044 Port to Sun C.
5045 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5046 that Sun C diagnosed.
5047 * fns.c (secure_hash): Fix pointer signedness issue.
5048 * intervals.c (static_offset_intervals): New function.
5049 (offset_intervals): Use it.
5050
7f3f739f
LL
50512011-06-21 Leo Liu <sdl.web@gmail.com>
5052
5053 * deps.mk (fns.o):
5054 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5055 sha512.h.
5056
5057 * fns.c (secure_hash): Rename from crypto_hash_function and change
5058 the first arg to accept symbols.
5b66d427 5059 (Fsecure_hash): New primitive.
7f3f739f
LL
5060 (syms_of_fns): New symbols.
5061
76147d94
DD
50622011-06-20 Deniz Dogan <deniz@dogan.se>
5063
5064 * process.c (Fset_process_buffer): Clarify return value in
5065 docstring.
5066
7d7d0045
CY
50672011-06-18 Chong Yidong <cyd@stupidchicken.com>
5068
5069 * dispnew.c (add_window_display_history): Use BVAR.
5070
5071 * xdisp.c (debug_method_add): Use BVAR.
5072 (check_window_end, dump_glyph_matrix, dump_glyph)
5073 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5074
5075 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5076 Likewise.
5077
5078 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5079 check till after the cache is created in init_frame_faces.
5080
ff2bc410
SM
50812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5082
5083 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5084
28177add
PE
50852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5086
dd3482fe
PE
5087 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5088 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5089 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5090
393d71f3 5091 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5092 * fileio.c (Finsert_file_contents):
5093 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5094 Remove the old (too-loose) buffer overflow checks.
5095 They weren't needed, since make_gap checks for buffer overflow.
5096 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5097 The old code merely checked for Emacs fixnum overflow, and relied
5098 on undefined (wraparound) behavior. The new code avoids undefined
5099 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5100
2e6813b0 5101 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5102 Tune. Don't use wider integers than needed. Don't use alloca.
5103 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5104
599a9e4f
PE
5105 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5106
99561444
PE
5107 * insdel.c, lisp.h (buffer_overflow): New function.
5108 (insert_from_buffer_1, replace_range, replace_range_2):
5109 * insdel.c (make_gap_larger):
5110 * editfns.c (Finsert_char):
5111 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5112
28177add
PE
5113 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5114
e69dafad
PE
51152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5116
4baa020d 5117 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5118
b1c46f02
PE
5119 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5120 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5121
e69dafad
PE
5122 * fileio.c: Don't assume EMACS_INT fits in off_t.
5123 (emacs_lseek): New static function.
5124 (Finsert_file_contents, Fwrite_region): Use it.
5125 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5126
566684ea
PE
5127 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5128
e6966cd6
PE
5129 * fns.c: Don't overflow int when computing a list length.
5130 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5131 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5132 truncation on 64-bit hosts. Check for QUIT every
5133 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5134 faster and is responsive enough.
5135 (Flength): Report an error instead of overflowing an integer.
5136 (Fsafe_length): Return a float if the value is not representable
5137 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5138 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5139 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5140
dd0b0efb
PE
5141 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5142 (header_size, word_size): New constants.
5143 (allocate_vectorlike): Don't check size overflow here.
5144 (allocate_vector): Check it here instead, since this is the only
5145 caller of allocate_vectorlike that could cause overflow.
5146 Check that the new vector's length is representable as a fixnum.
5147
86fe5cfe
PE
5148 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5149 The previous code was bogus. For example, next_almost_prime (32)
5150 returned 39, which is undesirable as it is a multiple of 3; and
5151 next_almost_prime (24) returned 25, which is a multiple of 5 so
5152 why was the code bothering to check for multiples of 7?
5153
80e88859
PE
5154 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5155
4a2f0ad6
PE
5156 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5157
f66c7cf8
PE
5158 Variadic C functions now count arguments with ptrdiff_t.
5159 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5160 Back then I didn't know that the Emacs coding style prefers signed int.
5161 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5162 were being counted with int, which may truncate counts on 64-bit
5163 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5164 * lisp.h (struct Lisp_Subr.function.aMANY)
5165 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5166 Arg counts are now ptrdiff_t, not size_t.
5167 All variadic functions and their callers changed accordingly.
5168 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5169 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5170 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5171 * callint.c (Fcall_interactively): Check arg count for overflow,
5172 to avoid potential buffer overrun. Use signed char, not 'int',
5173 for 'varies' array, so that we needn't bother to check its size
5174 calculation for overflow.
5175 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5176 * eval.c (apply_lambda):
5177 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5178 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5179 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5180
a1759b76
PE
5181 * callint.c (Fcall_interactively): Don't use index var as event count.
5182
d96be9fc
PE
5183 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5184 * mem-limits.h (SIZE): Remove; no longer used.
5185
a690a978 5186 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5187
578c21e6
PE
5188 Remove unnecessary casts.
5189 * xterm.c (x_term_init):
5190 * xfns.c (x_set_border_pixel):
5191 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5192 These aren't needed now that we assume ANSI C.
5193
96f53c6c
PE
5194 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5195 It's more likely to cause problems (due to unsigned overflow)
5196 than to cure them.
5197
83c77d31
PE
5198 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5199
ee2079f1
PE
5200 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5201
6da65536
PE
5202 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5203
7147c4a4
PE
5204 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5205
193e32d9
PE
5206 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5207
e5533da6
PE
5208 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5209
9910e595
PE
5210 GLYPH_CODE_FACE returns EMACS_INT, not int.
5211 * dispextern.h (merge_faces):
5212 * xfaces.c (merge_faces):
01103c44
PE
5213 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5214 Don't assume EMACS_INT fits in int.
9910e595 5215
2638320e
PE
5216 * character.h (CHAR_VALID_P): Remove unused parameter.
5217 * fontset.c, lisp.h, xdisp.c: All uses changed.
5218
045eb8d9
PE
5219 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5220
c1f134b5
PE
5221 * fns.c (concat): Minor tuning based on overflow analysis.
5222 This doesn't fix any bugs. Use int to hold character, instead
5223 of constantly refetching from Emacs object. Use XFASTINT, not
5224 XINT, for value known to be a character. Don't bother comparing
5225 a single byte to 0400, as it's always less.
5226
395fcb93 5227 * floatfns.c (Fexpt):
327eeec8
PE
5228 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5229
abbd3d23
PE
5230 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5231 for characters.
5232
684a03ef
PE
5233 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5234
0fed43f3
PE
5235 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5236 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5237 incorrectly succeed when S was a string, because 4294967386 was
5238 truncated before it was used.
5239
8fd02eb7
PE
5240 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5241 Otherwise, an out-of-range integer could cause undefined behavior
5242 on a 64-bit host.
5243
f8c86b69
PE
5244 * composite.c: Use int, not EMACS_INT, for characters.
5245 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5246 EMACS_INT, for values that are known to be in character range.
5247 This doesn't fix any bugs but is the usual style inside Emacs and
5248 may generate better code on 32-bit machines.
5249
34206dd2
PE
5250 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5251 This is for reasons similar to the recent CHAR_STRING fix.
5252 * charset.c (Fencode_char): Check that character arg is actually
5253 a character. Pass an int to ENCODE_CHAR.
5254 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5255 wider than 'int', as a compile-time check to prevent future regressions
5256 in this area.
5257
c5958d4c 5258 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5259
5260 Make sure a 64-bit char is never passed to CHAR_STRING.
5261 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5262 by silently ignoring the top 32 bits, allowing some values
5263 that were far too large to be valid characters.
5264 * character.h: Include <verify.h>.
5265 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5266 arguments are no wider than unsigned, as a compile-time check
5267 to prevent future regressions in this area.
5268 * data.c (Faset):
01103c44 5269 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5270 (Fsubst_char_in_region):
5271 * fns.c (concat):
5272 * xdisp.c (decode_mode_spec_coding):
5273 Adjust to CHAR_STRING's new requirement.
5274 * editfns.c (Finsert_char, Fsubst_char_in_region):
5275 * fns.c (concat): Check that character args are actually
5276 characters. Without this test, these functions did the wrong
5277 thing with wildly out-of-range values on 64-bit hosts.
5278
d37ca623
PE
5279 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5280 These casts should not be needed on 32-bit hosts, either.
5281 * keyboard.c (read_char):
5282 * lread.c (Fload): Remove casts to unsigned.
5283
ea204efb
PE
5284 * lisp.h (UNSIGNED_CMP): New macro.
5285 This fixes comparison bugs on 64-bit hosts.
5286 (ASCII_CHAR_P): Use it.
5287 * casefiddle.c (casify_object):
01103c44 5288 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5289 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5290 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5291 * dispextern.h (FACE_FROM_ID):
5292 * keyboard.c (read_char): Use UNSIGNED_CMP.
5293
41cb286c
PE
5294 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5295 not to EMACS_INT, to avoid GCC warning.
5296
4a1b9832
PE
5297 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5298
55daad71
PE
5299 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5300 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5301 isn't needed on 32-bit machines.
8f95c75c 5302
01103c44
PE
5303 * buffer.c (Fgenerate_new_buffer_name):
5304 Use EMACS_INT for count, not int.
0ceccced 5305 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5306
5307 * data.c (Qcompiled_function): Now static.
5308
c6f072e7
PE
5309 * window.c (window_body_lines): Now static.
5310
20ce5912
PE
5311 * image.c (gif_load): Rename local to avoid shadowing.
5312
9c4c5f81
PE
5313 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5314 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5315 * alloc.c (make_save_value): Integer argument is now of type
5316 ptrdiff_t, not int.
5317 (mark_object): Use ptrdiff_t, not int.
5318 * lisp.h (pD): New macro.
5319 * print.c (print_object): Use it.
5320
c0c5c8ae
PE
5321 * alloc.c: Use EMACS_INT, not int, to count objects.
5322 (total_conses, total_markers, total_symbols, total_vector_size)
5323 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5324 (total_free_floats, total_floats, total_free_intervals)
5325 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5326 Now EMACS_INT, not int. All uses changed.
5327 (Fgarbage_collect): Compute overall total using a double, so that
5328 integer overflow is less likely to be a problem. Check for overflow
5329 when converting back to an integer.
5a25e253
PE
5330 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5331 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5332 These were 'int' variables that could overflow on 64-bit hosts;
5333 they were never used, so remove them instead of repairing them.
211a0b2a 5334 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5335 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5336 Previously, this ceilinged at INT_MAX, but that doesn't work on
5337 64-bit machines.
e46bb31a 5338 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5339
c78baabf 5340 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5341 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5342 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5343 when a (possibly-narrower) signed value would do just as well.
5344 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5345
c9d624c6
PE
5346 * alloc.c: Catch some string size overflows that we were missing.
5347 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5348 for convenience in STRING_BYTES_MAX.
5349 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5350 The definition here is exact; the one in lisp.h was approximate.
5351 (allocate_string_data): Check for string overflow. This catches
5352 some instances we weren't catching before. Also, it catches
5353 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5354 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5355 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5356
c9d624c6
PE
5357 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5358 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5359 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5360
353032ce
PE
5361 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5362
2bccce07
PE
5363 * alloc.c (Fmake_string): Check for out-of-range init.
5364
0ac30604
SM
53652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5366
5367 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5368
c195f2de
JD
53692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5370
5371 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5372 xg_get_default_scrollbar_width.
5373
5374 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5375 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5376 (style_changed_cb): Call update_theme_scrollbar_width and call
5377 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5378 all frames (Bug#8505).
5379 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5380 Call gtk_window_set_resizable if HAVE_GTK3.
5381 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5382 and height if HAVE_GTK3 (Bug#8505).
5383 (scroll_bar_width_for_theme): New variable.
5384 (update_theme_scrollbar_width): New function.
5385 (xg_get_default_scrollbar_width): Move code to
5386 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5387 (xg_initialize): Call update_theme_scrollbar_width.
5388
5389 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5390
5391 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5392
e10ac9f1
MR
53932011-06-12 Martin Rudalics <rudalics@gmx.at>
5394
5395 * frame.c (make_frame): Call other_buffer_safely instead of
5396 other_buffer.
5397
5398 * window.c (temp_output_buffer_show): Call display_buffer with
5399 second argument Vtemp_buffer_show_specifiers and reset latter
5400 immediately after the call.
5401 (Vtemp_buffer_show_specifiers): New variable.
5402 (auto_window_vscroll_p, next_screen_context_lines)
5403 (Vscroll_preserve_screen_position): Remove leading asterisks from
5404 doc-strings.
5405
2d3c217e 54062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5407
7b7f97e8 5408 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5409 * buffer.c (Qclone_number): Remove for now, as it's unused.
5410 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5411 (record_buffer): Remove unused local.
5412 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5413 (set_frame_buffer_list): Remove; unused.
5414 * frame.h (other_visible_frames): Remove decl.
5415 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5416 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5417 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5418 if HAVE_GPM.
5419 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5420 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5421 Define only if HAVE_GPM.
5422 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5423 (update_hints_inhibit): Remove; never set. All uses removed.
5424 * widgetprv.h (emacsFrameClassRec): Remove decl.
5425 * window.c (delete_deletable_window): Now returns void, since it
5426 wasn't returning anything.
5427 (compare_window_configurations): Remove unused locals.
5428 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5429 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5430 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5431 the same widths as pointers. This follows up on the 2011-05-06 patch.
5432 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5433 * xterm.h: Likewise.
5434 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5435
1384b89e
JB
54362011-06-12 Juanma Barranquero <lekktu@gmail.com>
5437
5438 * makefile.w32-in: Update dependencies.
5439 (LISP_H): Add lib/intprops.h.
5440
1100a63c
CY
54412011-06-11 Chong Yidong <cyd@stupidchicken.com>
5442
5443 * image.c (gif_load): Add animation frame delay to the metadata.
5444 (syms_of_image): Use DEFSYM. New symbol `delay'.
5445
6198ccd0
MR
54462011-06-11 Martin Rudalics <rudalics@gmx.at>
5447
5448 * window.c (delete_deletable_window): Re-add.
5449 (Fset_window_configuration): Rewrite to handle dead buffers and
5450 consequently deletable windows.
5451 (window_tree, Fwindow_tree): Remove. Supply functionality in
5452 window.el.
5453 (compare_window_configurations): Simplify code.
5454
b6e3633c
AS
54552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5456
1ab0dee5
AS
5457 * image.c (imagemagick_load_image): Fix type mismatch.
5458 (Fimagemagick_types): Likewise.
5459
b6e3633c
AS
5460 * window.h (replace_buffer_in_windows): Declare.
5461
9397e56f
MR
54622011-06-11 Martin Rudalics <rudalics@gmx.at>
5463
5464 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5465 Qclone_number. Remove external declaration of Qdelete_window.
5466 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5467 code.
640c8776
SM
5468 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5469 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5470 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5471 buffer list implementation.
5472 (other_buffer_safely): New function.
5473 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5474 calls to replace_buffer_in_windows and
5475 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5476 if allowed.
5477 (record_buffer): Inhibit quitting and rewrite using quittable
5478 functions. Run Qbuffer_list_update_hook if allowed.
5479 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5480 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5481 Move switch-to-buffer to window.el.
9397e56f
MR
5482 (bury-buffer): Move to window.el.
5483 (Vbuffer_list_update_hook): New variable.
5484
5485 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5486 section.
5487
5488 * window.h (resize_frame_windows): Move up in code.
5489 (Fwindow_frame): Remove EXFUN.
5490 (replace_buffer_in_all_windows): Remove prototype.
5491 (replace_buffer_in_windows_safely): Add prototype.
5492
5493 * window.c: Declare Qdelete_window static again. Move down
5494 declaration of select_count.
5495 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5496 (Fother_window): Move to window.el.
5497 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5498 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5499 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5500 window.el.
5501 (replace_buffer_in_windows): Implement by calling
5502 Qreplace_buffer_in_windows.
5503 (replace_buffer_in_all_windows): Remove with some functionality
5504 moved into replace_buffer_in_windows_safely.
5505 (replace_buffer_in_windows_safely): New function.
5506 (select_window_norecord, select_frame_norecord): Move in front
5507 of run_window_configuration_change_hook. Remove now obsolete
5508 declarations.
640c8776
SM
5509 (Fset_window_buffer): Rewrite doc-string.
5510 Call Qrecord_window_buffer.
9397e56f
MR
5511 (keys_of_window): Move binding for other-window to window.el.
5512
b50691aa
CY
55132011-06-11 Chong Yidong <cyd@stupidchicken.com>
5514
5515 * dispextern.h (struct image): Replace data member, whose int_val
5516 and ptr_val fields were not used by anything, with a single
5517 lisp_val object.
5518
5519 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5520 (gif_clear_image, gif_load, imagemagick_load_image)
5521 (gs_clear_image, gs_load): Callers changed.
5522
3f754b86
PE
55232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5524
cca69397
PE
5525 * buffer.h: Include <time.h>, for time_t.
5526 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5527
109e28d0
PE
5528 Fix minor problems found by static checking.
5529
60737f02
PE
5530 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5531
4b66faf3
PE
5532 Make identifiers static if they are not used in other modules.
5533 * data.c (Qcompiled_function, Qframe, Qvector):
5534 * image.c (QimageMagick, Qsvg):
5535 * minibuf.c (Qmetadata):
5536 * window.c (resize_window_check, resize_root_window): Now static.
5537 * window.h (resize_window_check, resize_root_window): Remove decls.
5538
109e28d0
PE
5539 * window.c (window_deletion_count, delete_deletable_window):
5540 Remove; unused.
46a4ce9e
PE
5541 (window_body_lines): Now static.
5542 (Fdelete_other_windows_internal): Mark vars as initialized.
5543 Make sure 'resize_failed' is initialized.
5544 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5545 (resize_window_apply): Remove unused local.
5546 * window.h (delete_deletable_window): Remove decl.
5547
109e28d0 5548 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5549 (imagemagick_load_image): Fix pointer signedness problem by changing
5550 last arg from unsigned char * to char *. All uses changed.
5551 Also, fix a local for similar reasons.
5552 Remove unused locals. Remove locals to avoid shadowing.
5553 (fn_rsvg_handle_free): Remove; unused.
5554 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5555 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5556
3f754b86
PE
5557 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5558
2547adb1
CY
55592011-06-10 Chong Yidong <cyd@stupidchicken.com>
5560
5561 * image.c (gif_load): Fix omitted cast error introduced by
5562 2011-06-06 change.
5563
2c8e37d4
MR
55642011-06-10 Martin Rudalics <rudalics@gmx.at>
5565
5566 * window.h (resize_proportionally, orig_total_lines)
5567 (orig_top_line): Remove from window structure.
5568 (set_window_height, set_window_width, change_window_heights)
5569 (Fdelete_window): Remove prototypes.
5570 (resize_frame_windows): Remove duplicate declaration.
5571
440a42e3
EZ
55722011-06-10 Eli Zaretskii <eliz@gnu.org>
5573
5574 * window.h (resize_frame_windows, resize_window_check)
5575 (delete_deletable_window, resize_root_window)
5576 (resize_frame_windows): Declare prototypes.
5577
5578 * window.c (resize_window_apply): Make definition be "static" to
5579 match the prototype.
5580
562dd5e9
MR
55812011-06-10 Martin Rudalics <rudalics@gmx.at>
5582
5583 * window.c: Remove declarations of Qwindow_size_fixed,
5584 window_min_size_1, window_min_size_2, window_min_size,
5585 size_window, window_fixed_size_p, enlarge_window, delete_window.
5586 Remove static from declaration of Qdelete_window, it's
5587 temporarily needed by Fbury_buffer.
5588 (replace_window): Don't assign orig_top_line and
5589 orig_total_lines.
5590 (Fdelete_window, delete_window): Remove. Window deletion is
5591 handled by window.el.
640c8776
SM
5592 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5593 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5594 (Fdelete_other_windows): Remove. Deleting other windows is
5595 handled by window.el.
5596 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5597 handled in window.el.
5598 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5599 Window minimum sizes are handled in window.el.
5600 (shrink_windows, size_window, set_window_height)
5601 (set_window_width, change_window_heights, window_height)
5602 (window_width, CURBEG, CURSIZE, enlarge_window)
5603 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5604 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5605 handled in window.el.
5606 (make_dummy_parent): Rename to make_parent_window and give it a
5607 second argument horflag.
5608 (make_window): Don't set resize_proportionally any more.
5609 (Fsplit_window): Remove. Windows are split in window.el.
5610 (save_restore_action, save_restore_orig_size)
5611 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5612 Resize mini windows in window.el.
5613 (grow_mini_window, shrink_mini_window): Implement by calling
5614 Qresize_root_window_vertically, resize_window_check and
5615 resize_window_apply.
640c8776
SM
5616 (saved_window, Fset_window_configuration, save_window_save):
5617 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5618 resize_proportionally.
5619 (window_min_height, window_min_width): Move to window.el.
5620 (keys_of_window): Move bindings for delete-other-windows,
5621 split-window, delete-window and enlarge-window to window.el.
5622
5623 * buffer.c: Temporarily extern Qdelete_window.
5624 (Fbury_buffer): Temporarily call Qdelete_window instead of
5625 Fdelete_window (Fbury_buffer will move to window.el soon).
5626
5627 * frame.c (set_menu_bar_lines_1): Remove code handling
5628 orig_top_line and orig_total_lines.
5629
5630 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5631 set_window_height but set heights directly.
5632 (change_frame_size_1): Use resize_frame_windows.
5633
5634 * xdisp.c (init_xdisp): Don't use set_window_height but set
5635 heights directly.
5636
640c8776
SM
5637 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5638 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5639 run_window_configuration_change_hook.
5640
5641 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5642 instead of change_window_heights and run
5643 run_window_configuration_change_hook.
5644
1a13852e
MR
56452011-06-09 Martin Rudalics <rudalics@gmx.at>
5646
5647 * window.c (replace_window): Rename second argument REPLACEMENT to
5648 NEW. New third argument SETFLAG. Rewrite.
5649 (delete_window, make_dummy_parent): Call replace_window with
5650 third argument 1.
5651 (window_list_1): Move down in code.
5652 (run_window_configuration_change_hook): Move set_buffer part
5653 before select_frame_norecord part in order to unwind correctly.
5654 Rename count1 to count.
5655 (recombine_windows, delete_deletable_window, resize_root_window)
5656 (Fdelete_other_windows_internal)
5657 (Frun_window_configuration_change_hook, make_parent_window)
5658 (resize_window_check, resize_window_apply, Fresize_window_apply)
5659 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5660 (Fdelete_window_internal, Fresize_mini_window_internal):
5661 New functions.
1a13852e
MR
5662 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5663
f3d1777e
MR
56642011-06-08 Martin Rudalics <rudalics@gmx.at>
5665
496e208e
MR
5666 * window.h (window): Add some new members to window structure -
5667 normal_lines, normal_cols, new_total, new_normal, clone_number,
5668 splits, nest, prev_buffers, next_buffers.
5669 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5670 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5671
f3d1777e
MR
5672 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5673 Remove.
496e208e
MR
5674 (make_dummy_parent): Set new members of windows structure.
5675 (make_window): Move down in code. Handle new members of window
5676 structure.
5677 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5678 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5679 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5680 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5681 (Fset_window_next_buffers, Fset_window_clone_number):
5682 New functions.
496e208e
MR
5683 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5684 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5685 Doc-string fixes.
5686 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5687 Argument WINDOW can be now internal window too.
5688 (Fwindow_use_time): Move up in code.
5689 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5690 Rewrite doc-string.
5691 (Fset_window_configuration, saved_window)
5692 (Fcurrent_window_configuration, save_window_save): Handle new
5693 members of window structure.
b9e809c2
MR
5694 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5695 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5696 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5697 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5698 Qget_mru_window, Qresize_root_window,
5699 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5700 Qauto_buffer_name; staticpro them.
f3d1777e 5701
abde8f8c
MR
57022011-06-07 Martin Rudalics <rudalics@gmx.at>
5703
5704 * window.c (Fwindow_total_size, Fwindow_left_column)
5705 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5706 (Fwindow_list_1): New functions.
5707 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5708 (Fwindow_width, Fscroll_left, Fscroll_right):
5709 Use window_body_cols instead of window_box_text_cols.
5710 (delete_window, Fset_window_configuration):
5711 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5712 (delete_all_subwindows): Take a window as argument and not a
5713 structure. Rewrite.
190b47e6
MR
5714 (window_loop): Remove handling of GET_LRU_WINDOW and
5715 GET_LARGEST_WINDOW.
5716 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5717
5718 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5719 window_box_text_cols. delete_all_subwindows now takes a
5720 Lisp_Object as argument.
abde8f8c 5721
640c8776
SM
5722 * indent.c (compute_motion, Fcompute_motion):
5723 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5724
fa8a67e6
MR
5725 * frame.c (delete_frame): Call delete_all_subwindows with root
5726 window as argument.
5727
a54e3482
DC
57282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5729
5730 * fns.c (Fputhash): Document return value.
5731
60002bf5
CY
57322011-06-06 Chong Yidong <cyd@stupidchicken.com>
5733
5734 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5735
0c671da6 57362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5737
b862a52a 5738 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5739
be44ca6c
PE
5740 Check for overflow when converting integer to cons and back.
5741 * charset.c (Fdefine_charset_internal, Fdecode_char):
5742 Use cons_to_unsigned to catch overflow.
5743 (Fencode_char): Use INTEGER_TO_CONS.
5744 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5745 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5746 * data.c (long_to_cons, cons_to_long): Remove.
5747 (cons_to_unsigned, cons_to_signed): New functions.
5748 These signal an error for invalid or out-of-range values.
5749 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5750 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5751 * font.c (Ffont_variation_glyphs):
5752 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5753 * lisp.h: Include <intprops.h>.
5754 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5755 (cons_to_signed, cons_to_unsigned): New decls.
5756 (long_to_cons, cons_to_long): Remove decls.
5757 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5758 (Fprimitive_undo): Use CONS_TO_INTEGER.
5759 * xfns.c (Fx_window_property): Likewise.
5760 * xselect.c: Include <limits.h>.
5761 (x_own_selection, selection_data_to_lisp_data):
5762 Use INTEGER_TO_CONS.
5763 (x_handle_selection_request, x_handle_selection_clear)
5764 (x_get_foreign_selection, Fx_disown_selection_internal)
5765 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5766 (lisp_data_to_selection_data): Use cons_to_unsigned.
5767 (x_fill_property_data): Use cons_to_signed.
5768 Report values out of range.
5769
d1f3d2af
PE
5770 Check for buffer and string overflow more precisely.
5771 * buffer.h (BUF_BYTES_MAX): New macro.
5772 * lisp.h (STRING_BYTES_MAX): New macro.
5773 * alloc.c (Fmake_string):
5774 * character.c (string_escape_byte8):
5775 * coding.c (coding_alloc_by_realloc):
5776 * doprnt.c (doprnt):
5777 * editfns.c (Fformat):
5778 * eval.c (verror):
5779 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5780 since they may not be the same number.
5781 * editfns.c (Finsert_char):
5782 * fileio.c (Finsert_file_contents):
5783 Likewise for BUF_BYTES_MAX.
5784
dd52fcea
PE
5785 * image.c: Use ptrdiff_t, not int, for sizes.
5786 (slurp_file): Switch from int to ptrdiff_t.
5787 All uses changed.
5788 (slurp_file): Check that file size fits in both size_t (for
5789 malloc) and ptrdiff_t (for sanity and safety).
5790
7f9bbdbb
PE
5791 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5792 if b->modtime has its maximal value.
5793
dfe18f82
PE
5794 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5795
84acfcf0
PE
5796 Don't assume time_t can fit into int.
5797 * buffer.h (struct buffer.modtime): Now time_t, not int.
5798 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5799 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5800
ccd9a01a
PE
5801 Minor fixes for signed vs unsigned integers.
5802 * character.h (MAYBE_UNIFY_CHAR):
5803 * charset.c (maybe_unify_char):
5804 * keyboard.c (read_char, reorder_modifiers):
5805 XINT -> XFASTINT, since the integer must be nonnegative.
5806 * ftfont.c (ftfont_spec_pattern):
5807 * keymap.c (access_keymap, silly_event_symbol_error):
5808 XUINT -> XFASTINT, since the integer must be nonnegative.
5809 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5810 since it makes no difference and we prefer signed.
5811 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5812 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5813 nonnegative.
5814
d6d100dd
SM
58152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5816
5817 * window.h (Fwindow_frame): Declare.
5818
2b6148e4
PE
58192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5820
5821 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5822 (SPARE_MEMORY): Always define.
5823 (LARGE_REQUEST): Remove.
5824 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5825
f230ecc9
MR
58262011-06-06 Martin Rudalics <rudalics@gmx.at>
5827
727e958e
MR
5828 * lisp.h: Move EXFUNS for Fframe_root_window,
5829 Fframe_first_window and Fset_frame_selected_window to window.h.
5830
5831 * window.h: Move EXFUNS for Fframe_root_window,
5832 Fframe_first_window and Fset_frame_selected_window here from
5833 lisp.h.
5834
5835 * frame.c (Fwindow_frame, Fframe_first_window)
5836 (Fframe_root_window, Fframe_selected_window)
5837 (Fset_frame_selected_window): Move to window.c.
5838 (Factive_minibuffer_window): Move to minibuf.c.
5839 (Fother_visible_frames_p): New function.
5840
5841 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5842
f230ecc9
MR
5843 * window.c (decode_window, decode_any_window): Move up in code.
5844 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5845 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5846 (Fwindow_buffer): Move up and rewrite doc-string.
5847 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5848 (Fwindow_prev): New functions.
727e958e
MR
5849 (Fwindow_frame): Move here from frame.c. Accept any window as
5850 argument.
5851 (Fframe_root_window, Fframe_first_window)
5852 (Fframe_selected_window): Move here from frame.c. Accept frame
5853 or arbitrary window as argument. Update doc-strings.
5854 (Fminibuffer_window): Move up in code.
5855 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5856 (Fset_frame_selected_window): Move here from frame.c.
5857 Marginal rewrite.
727e958e
MR
5858 (Fselected_window, select_window, Fselect_window): Move up in
5859 code. Minor doc-string fixes.
f230ecc9 5860
4d09bcf6
PE
58612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5862
5863 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5864 Do not assume that spare memory exists; that assumption is valid
5865 only if SYSTEM_MALLOC.
5866 (LARGE_REQUEST): New macro, so that the issue of large requests
5867 is separated from the issue of spare memory.
5868
810928a2
AS
58692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5870
172418ad
AS
5871 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5872 format. (Bug#8806)
5873
43f862f7
AS
5874 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5875
810928a2
AS
5876 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5877 before statements.
5878
a059fe24
JD
58792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5880
5881 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5882
5883 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5884
5885 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5886 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5887
989bf368
JB
58882011-06-05 Juanma Barranquero <lekktu@gmail.com>
5889
5890 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5891
4b80f674
CY
58922011-06-04 Chong Yidong <cyd@stupidchicken.com>
5893
5894 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5895 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5896 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5897 New error handlers.
4b80f674
CY
5898 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5899 Obey Vx_select_enable_clipboard_manager. Catch errors in
5900 x_clipboard_manager_save (Bug#8779).
5901 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5902 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5903
99a33b77 59042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5905
5906 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5907
99a33b77 59082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5909
5910 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5911 in the current matrix if keep_current_p is non-zero.
5912
8264569d
EZ
59132011-06-04 Eli Zaretskii <eliz@gnu.org>
5914
5915 * bidi.c (bidi_level_of_next_char): Fix last change.
5916
57f97249
EZ
59172011-06-03 Eli Zaretskii <eliz@gnu.org>
5918
fec2107c 5919 Support bidi reordering of text covered by display properties.
57f97249 5920
fec2107c
EZ
5921 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5922 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5923 (bidi_cache_search, bidi_cache_iterator_state)
5924 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5925 (bidi_level_of_next_char, bidi_move_to_visually_next):
5926 Support character positions inside a run of characters covered by a
fec2107c
EZ
5927 display string.
5928 (bidi_paragraph_init, bidi_resolve_explicit_1)
5929 (bidi_level_of_next_char): Call bidi_fetch_char and
5930 bidi_fetch_char_advance instead of FETCH_CHAR and
5931 FETCH_CHAR_ADVANCE.
5932 (bidi_init_it): Initialize new members.
5933 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5934 definitions.
5935 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5936 instead of using explicit *_CHAR codes.
d6d100dd
SM
5937 (bidi_resolve_explicit, bidi_resolve_weak):
5938 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5939 bidirectional text is supported only in multibyte buffers.
5940 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5941 it to initialize the frame_window_p member of struct bidi_it.
5942 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5943 (bidi_resolve_explicit, bidi_resolve_weak)
5944 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5945 bidi_it->nchars is non-positive.
5946 (bidi_level_of_next_char): Don't try to lookup the cache for the
5947 next/previous character if nothing is cached there yet, or if we
5948 were just reseat()'ed to a new position.
c40e2fb2 5949
0e14fe90
EZ
5950 * xdisp.c (set_cursor_from_row): Set start and stop points
5951 according to the row's direction when priming the loop that looks
5952 for the glyph on which to display cursor.
5953 (single_display_spec_intangible_p): Function deleted.
5954 (display_prop_intangible_p): Reimplement to call
5955 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5956 Accept 3 additional arguments needed by handle_display_spec.
5957 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5958 values: lists, `(when COND...)' forms, etc.
5959 (single_display_spec_string_p): Support property values that are
5960 lists with the argument STRING its top-level element.
5961 (display_prop_string_p): Fix the condition for processing a
5962 property that is a list to be consistent with handle_display_spec.
fec2107c 5963 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5964 last portion of handle_display_prop.
5965 (compute_display_string_pos): Accept additional argument
5966 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5967 value of a `display' property is a "replacing spec".
5968 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5969 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5970 the display property, but just return a value indicating whether
5971 the display property will replace the characters it covers.
5972 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5973 frame_window_p members of struct bidi_it.
d6d100dd
SM
5974 (compute_display_string_pos, compute_display_string_end):
5975 New functions.
fec2107c
EZ
5976 (push_it): Accept second argument POSITION, where pop_it should
5977 jump to continue iteration.
5978 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5979
fec2107c
EZ
5980 * keyboard.c (adjust_point_for_property): Adjust the call to
5981 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5982
5983 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5984 (bidi_init_it): Update prototypes.
5985 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5986 (compute_display_string_pos, compute_display_string_end):
5987 Declare prototypes.
fec2107c
EZ
5988 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5989 EMACS_INT.
fc6f18ce 5990
40087514 59912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5992
57f53182
PE
5993 Malloc failure behavior now depends on size of allocation.
5994 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5995 * lisp.h: Change signatures accordingly.
5996 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5997 All callers changed. (Bug#8762)
5998
5999 * gnutls.c: Use Emacs's memory allocators.
6000 Without this change, the gnutls library would invoke malloc etc.
6001 directly, which causes problems on non-SYNC_INPUT hosts, and which
6002 runs afoul of improving memory_full behavior. (Bug#8761)
6003 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6004 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6005 xfree instead of the default malloc, realloc, free.
6006 (Fgnutls_boot): No need to check for memory allocation failure,
6007 since xmalloc does that for us.
6008
ac32cd99 6009 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6010 * category.c (hash_get_category_set):
6011 * ccl.c (ccl_driver):
6012 * charset.c (Fdefine_charset_internal):
6013 * charset.h (struct charset.hash_index):
6014 * composite.c (get_composition_id, gstring_lookup_cache)
6015 (composition_gstring_put_cache):
6016 * composite.h (struct composition.hash_index):
6017 * dispextern.h (struct image.hash):
6018 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6019 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6020 (hashfn_equal, hashfn_user_defined, make_hash_table)
6021 (maybe_resize_hash_table, hash_lookup, hash_put)
6022 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6023 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6024 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6025 * image.c (make_image, search_image_cache, lookup_image)
6026 (xpm_put_color_table_h):
6027 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6028 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6029 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6030 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6031 * alloc.c (allocate_vectorlike):
6032 Check for overflow in vector size calculations.
6033 * ccl.c (ccl_driver):
6034 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6035 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6036 need to be updated by these changes.
40087514
PE
6037 * fns.c (make_hash_table, maybe_resize_hash_table):
6038 Check for integer overflow with large hash tables.
0de4bb68
PE
6039 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6040 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6041 (SXHASH_REDUCE): New macro.
6042 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6043 Use it instead of discarding useful hash info with large hash values.
6044 (sxhash_float): New function.
6045 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6046 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6047 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6048 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6049 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6050 Adjust signatures to match updated version of code.
6051 (consing_since_gc): Now EMACS_INT, since a single hash table can
6052 use more than INT_MAX bytes.
6053
698d32e2
DN
60542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6055
6056 Make it possible to build with GCC-4.6+ -O2 -flto.
6057
6058 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6059
fd6fa53f
SM
60602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6061
6062 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6063 Call minibuffer-inactive-mode.
6064
864db017
JB
60652011-05-31 Juanma Barranquero <lekktu@gmail.com>
6066
6067 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6068 Update dependencies.
6069
2ad0baf4
DN
60702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6071
6072 * data.c (init_data): Remove code for UTS, this system is not
6073 supported anymore.
6074
4fcc2638
DN
60752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6076
6077 Don't force ./temacs to start in terminal mode.
6078
6079 * frame.c (make_initial_frame): Initialize faces in all cases, not
6080 only when CANNOT_DUMP is defined.
6081 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6082
c56e0fd5
DN
60832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6084
6085 * dispnew.c (add_window_display_history): Use const for the string
6086 pointer. Remove declaration, not needed.
6087
333d54da 60882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6089
55d4c1b2 6090 Use 'inline', not 'INLINE'.
333d54da 6091 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6092 * alloc.c, fontset.c (INLINE): Remove.
6093 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6094 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6095 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6096 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6097 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6098
738db178
DN
60992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6100
6101 Make it possible to run ./temacs.
6102
6103 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6104 syms_of_callproc does the same thing. Remove test for
6105 "initialized", do it in the caller.
6106 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6107
620c53a6
SM
61082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6109
6110 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6111 (read_minibuf): Use get_minibuffer.
6112 (syms_of_minibuf): Use DEFSYM.
6113 (Qmetadata): New var.
6114 * data.c (Qbuffer): Don't make it static.
6115 (syms_of_data): Use DEFSYM.
6116
e003a292
PE
61172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6118
6119 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6120 (CCL_CODE_MIN): New macro.
6121
ed008a6d
PE
61222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6123
3687c2ef
PE
6124 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6125
ed008a6d
PE
6126 * eval.c (Qdebug): Now static.
6127 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6128 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6129 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6130
d66c4c7c
CY
61312011-05-29 Chong Yidong <cyd@stupidchicken.com>
6132
6133 * image.c: Various fixes to ImageMagick code comments.
6134 (Fimagemagick_types): Doc fix.
6135
5fbc2025
PE
61362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6137
0196f88a
PE
6138 Minor fixes prompted by GCC 4.6.0 warnings.
6139
6140 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6141
5fbc2025
PE
6142 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6143 (x_clipboard_manager_save_all): Move extern decl to ...
6144 * xterm.h: ... here, so that it can be checked for consistency.
6145
1dd3c2d9
CY
61462011-05-29 Chong Yidong <cyd@stupidchicken.com>
6147
6148 * xselect.c (x_clipboard_manager_save_frame)
6149 (x_clipboard_manager_save_all): New functions.
6150 (Fx_clipboard_manager_save): Lisp function deleted.
6151
6152 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6153 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6154
6155 * xterm.h: Update prototype.
6156
5ba6571d
WX
61572011-05-28 William Xu <william.xwl@gmail.com>
6158
6159 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6160 exiting (Bug#8239).
6161
3eaff834
JM
61622011-05-28 Jim Meyering <meyering@redhat.com>
6163
e1900994 6164 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6165 * fns.c (to_uchar): Define.
6166 (crypto_hash_function): Use it to convert some newly-signed
6167 variables to unsigned, to avoid sign-extension bugs. For example,
6168 without this change, (md5 "truc") would evaluate to
6169 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6170 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6171 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6172
0f6990a7
PE
61732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6174
6175 Integer overflow fixes.
c8a9ca5a 6176
08686060
PE
6177 * dbusbind.c: Serial number integer overflow fixes.
6178 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6179 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6180 to hold a serial number that is too large for a fixnum.
6181 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6182 Check for serial numbers out of range. Decode any serial number
59568bf0 6183 that was so large that it became a float. (Bug#8722)
08686060 6184
2d1fc3c7
PE
6185 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6186 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6187 Use XFASTINT rather than XUINT when numbers are nonnegative.
6188 (xd_append_arg, Fdbus_method_return_internal):
6189 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6190 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6191 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6192 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6193 (Bug#8722)
2d1fc3c7 6194
c8a9ca5a
PE
6195 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6196
519e1d69
PE
6197 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6198
6df6ae42 6199 ccl: Add integer overflow checks.
30569699
PE
6200 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6201 (IN_INT_RANGE): New macros.
6202 (ccl_driver): Use them to check for integer overflow when
6203 decoding a CCL program. Many of the new checks are whether XINT (x)
6204 fits in int; it doesn't always, on 64-bit hosts. The new version
6205 doesn't catch all possible integer overflows, but it's an
847044ea 6206 improvement. (Bug#8719)
30569699 6207
c11285dc
PE
6208 * alloc.c (make_event_array): Use XINT, not XUINT.
6209 There's no need for unsigned here.
6210
fdccd48e
PE
6211 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6212 This follows up to the 2011-05-06 change that substituted uintptr_t
6213 for EMACS_INT. This case wasn't caught back then.
6214
37910ab2
PE
6215 Rework Fformat to avoid integer overflow issues.
6216 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6217 now (part of C89). Include <verify.h>.
6218 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6219 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6220 (Fformat): Avoid the prepass trying to compute sizes; it was only
6221 approximate and thus did not catch overflow reliably. Instead, walk
6222 through the format just once, formatting and computing sizes as we go,
6223 checking for integer overflow at every step, and allocating a larger
6224 buffer as needed. Keep track separately whether the format is
6225 multibyte. Keep only the most-recently calculated precision, rather
6226 than them all. Record whether each argument has been converted to
6227 string. Use EMACS_INT, not int, for byte and char and arg counts.
6228 Support field widths and precisions larger than INT_MAX. Avoid
6229 sprintf's undefined behavior with conversion specifications such as %#d
6230 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6231 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6232 formatting out-of-range floating point numbers with int
9173deec 6233 formats. (Bug#8668)
37910ab2 6234
2e6578fb
PE
6235 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6236
0ae6bdee
PE
6237 * data.c: Avoid integer truncation in expressions involving floats.
6238 * data.c: Include <intprops.h>.
6239 (arith_driver): When there's an integer overflow in an expression
6240 involving floating point, convert the integers to floating point
6241 so that the resulting value does not suffer from catastrophic
6242 integer truncation. For example, on a 64-bit host (* 4
6243 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6244 Do not rely on undefined behavior after integer overflow.
6245
de883a70
PE
6246 merge count_size_as_multibyte, parse_str_to_multibyte
6247 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6248 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6249 Check for integer overflow.
6250 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6251 since it's now a duplicate of the other. This is more of
6252 a character than a buffer op, so better that it's in character.c.
6253 * fns.c, print.c: Adjust to above changes.
6254
2ff916cb
PE
62552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6256
6257 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6258
f1b54466
PE
62592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6260
fb1ac845
PE
6261 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6262 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6263 (x_clipboard_manager_save): Now static.
6264 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6265
f1b54466
PE
6266 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6267 (crypto_hash_function): Now static.
6268 Fix pointer signedness problems. Avoid unnecessary initializations.
6269
a9f737ee
CY
62702011-05-27 Chong Yidong <cyd@stupidchicken.com>
6271
6272 * termhooks.h (Vselection_alist): Make it terminal-local.
6273
6274 * terminal.c (create_terminal): Initialize it.
6275
6276 * xselect.c: Support for clipboard managers.
6277 (Vselection_alist): Move to termhooks.h as terminal-local var.
6278 (LOCAL_SELECTION): New macro.
6279 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6280 (symbol_to_x_atom): Remove gratuitous arg.
6281 (x_handle_selection_request, lisp_data_to_selection_data)
6282 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6283 (x_own_selection, x_get_local_selection, x_convert_selection):
6284 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6285 (some_frame_on_display): Delete unused function.
6286 (Fx_own_selection_internal, Fx_get_selection_internal)
6287 (Fx_disown_selection_internal, Fx_selection_owner_p)
6288 (Fx_selection_exists_p): New optional frame arg.
6289 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6290 (x_handle_selection_clear): Don't treat other terminals with the
6291 same keyboard specially. Use the terminal-local Vselection_alist.
6292 (x_clear_frame_selections): Use Frun_hook_with_args.
6293
6294 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6295
6296 * xterm.h: Add support for those atoms.
6297
e067f0c1
CY
62982011-05-26 Chong Yidong <cyd@stupidchicken.com>
6299
6300 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6301 (converted_selections, conversion_fail_tag): New global variables.
6302 (x_selection_request_lisp_error): Free the above.
6303 (x_get_local_selection): Remove unnecessary code.
6304 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6305 of converted selections stored in converted_selections.
6306 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6307 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6308 (x_convert_selection): New function.
6309 (x_handle_selection_event): Simplify.
6310 (x_get_foreign_selection): Don't ignore incoming requests while
6311 waiting for an answer; this will fail when we implement
6312 SAVE_TARGETS, and seems unnecessary anyway.
6313 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6314 (Vx_sent_selection_functions): Doc fix.
6315
0f4aebc0
LL
63162011-05-26 Leo Liu <sdl.web@gmail.com>
6317
6318 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6319
e61124cd
YM
63202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6321
6322 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6323
6324 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6325 for fringe update if it has periodic bitmap.
ac389d0c 6326 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6327 and fringe_bitmap_periodic_p.
6328
6329 * fringe.c (get_fringe_bitmap_data): New function.
6330 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6331 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6332 row. Mark glyph row for fringe update if periodicity changed.
6333
6334 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6335 for fringe update unless it has periodic bitmap.
6336
f16d9837
KH
63372011-05-25 Kenichi Handa <handa@m17n.org>
6338
6339 * xdisp.c (get_next_display_element): Set correct it->face_id for
6340 a static composition.
6341
e1b90ef6
LL
63422011-05-24 Leo Liu <sdl.web@gmail.com>
6343
6344 * deps.mk (fns.o):
6345 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6346
6347 * fns.c (crypto_hash_function, Fsha1): New function.
6348 (Fmd5): Use crypto_hash_function.
6349 (syms_of_fns): Add Ssha1.
6350
7400048f
PE
63512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6352
6353 * gnutls.c: Remove unused macros.
6354 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6355 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6356 Remove macros that are defined and never used.
6357 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6358
abb71cf4
CY
63592011-05-22 Chong Yidong <cyd@stupidchicken.com>
6360
6361 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6362 (Fx_get_selection_internal): Minor cleanup.
6363 (Fx_own_selection_internal): Rename arguments for consistency with
6364 select.el.
6365
6307db39
PE
63662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6367
6368 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6369
f3d4e0a4
CY
63702011-05-22 Chong Yidong <cyd@stupidchicken.com>
6371
6372 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6373
4d8ade89
YM
63742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6375
6376 * dispnew.c (scrolling_window): Don't exclude the case that the
6377 last enabled row in the desired matrix touches the bottom boundary.
6378
32078c8d
GM
63792011-05-21 Glenn Morris <rgm@gnu.org>
6380
6381 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6382 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6383 and add some more files.
32078c8d 6384
7285dc67
EZ
63852011-05-20 Eli Zaretskii <eliz@gnu.org>
6386
6387 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6388 report_file_error introduced by the change from 2011-05-07.
6389
89d1bd22
PE
63902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6391
6392 * systime.h (Time): Define only if emacs is defined.
6393 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6394 where the include path doesn't have X11/X.h by default. See
6395 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6396
cd394be1 63972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6398
6399 * composite.c (find_automatic_composition): Fix previous change.
6400
b9704ad9
GM
64012011-05-20 Glenn Morris <rgm@gnu.org>
6402
6403 * lisp.mk: New file, split from Makefile.in.
6404 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6405 (shortlisp): Remove.
6406 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6407
4a720484
GM
64082011-05-19 Glenn Morris <rgm@gnu.org>
6409
6410 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6411 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6412 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6413 (lisp): Set the order to that of loadup.el.
6414 (shortlisp): Make it a copy of $lisp.
6415 (SOME_MACHINE_LISP): Remove.
6416 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6417 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6418
a28d4396
KH
64192011-05-18 Kenichi Handa <handa@m17n.org>
6420
6421 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6422 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6423 (find_automatic_composition): Mostly rewrite for efficiency.
6424
a2b1fa8e
JB
64252011-05-18 Juanma Barranquero <lekktu@gmail.com>
6426
6427 * makefile.w32-in: Update dependencies.
6428
8e1f5610
CS
64292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6430
6431 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6432 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6433
7025ee00 64342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6435
cdfa6eab
PE
6436 Fix some integer overflow issues, such as string length overflow.
6437
06d6db33
PE
6438 * insdel.c (count_size_as_multibyte): Check for string overflow.
6439
2b4560a8
PE
6440 * character.c (lisp_string_width): Check for string overflow.
6441 Use EMACS_INT, not int, for string indexes and lengths; in
6442 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6443 the resulting string length overflows an EMACS_INT; instead,
6444 report a string overflow if no precision given. When checking for
6445 precision exhaustion, use a check that cannot possibly have
6446 integer overflow. (Bug#8675)
6447 * character.h (lisp_string_width): Adjust to new signature.
6448
cb93f9be
PE
6449 * alloc.c (string_overflow): New function.
6450 (Fmake_string): Use it. This doesn't change behavior, but saves
6451 a few bytes and will simplify future changes.
6452 * character.c (string_escape_byte8): Likewise.
6453 * lisp.h (string_overflow): New decl.
6454
1a1f3366
PE
6455 Fixups, following up to the user-interface timestamp change.
6456 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6457 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6458 * msdos.c (mouse_get_pos): Likewise.
6459 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6460 * w32gui.h (Time): Define by including "systime.h" rather than by
6461 declaring it ourselves. (Bug#8664)
6462
d4e3e4d3
PE
6463 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6464 * image.c (clear_image_cache): Likewise.
6465
f6a24d19
PE
6466 * term.c (term_mouse_position): Don't assume time_t wraparound.
6467
08dc5ae6
PE
6468 Be more systematic about user-interface timestamps.
6469 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6470 and sometimes 'EMACS_UINT', to represent these timestamps.
6471 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6472 This makes the code easier to follow, and makes it easier to catch
6473 integer overflow bugs such as Bug#8664.
6474 * frame.c (Fmouse_position, Fmouse_pixel_position):
6475 Use Time, not unsigned long, for user-interface timestamps.
6476 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6477 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6478 * keyboard.h (last_event_timestamp): Likewise.
6479 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6480 * menu.h (xmenu_show): Likewise.
6481 * term.c (term_mouse_position): Likewise.
6482 * termhooks.h (struct input_event.timestamp): Likewise.
6483 (struct terminal.mouse_position_hook): Likewise.
6484 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6485 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6486 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6487 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6488 what it was before.
6489 * menu.h, termhooks.h: Include "systime.h", for Time.
6490
8e55734a
PE
6491 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6492 Don't assume that the difference between two unsigned long values
6493 can fit into an integer. At this point, we know button_down_time
6494 <= event->timestamp, so the difference must be nonnegative, so
6495 there's no need to cast the result if double-click-time is
6496 nonnegative, as it should be; check that it's nonnegative, just in
6497 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6498 apart (about 25 days). (Bug#8664)
8e55734a 6499
841f1b75 6500 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6501 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6502
3e26f69c
PE
6503 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6504 that always fit in int. Use a sentinel instead of a counter, to
6505 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6506 * frame.h (struct frame): Use int for menu_bar_items_used
6507 instead of EMACS_INT, since it always fits in int.
3e26f69c 6508
5cc152c0
PE
6509 * menu.c (grow_menu_items): Check for int overflow.
6510
d89eb65e
PE
6511 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6512
5235bd3e
PE
6513 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6514 Before, the code was not consistent. These values cannot exceed
6515 2**31 - 1 so there's no need to make them unsigned.
6516 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6517 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6518 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6519 as modifiers.
6520 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6521
bc827e23
PE
6522 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6523 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6524 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6525 presumably because the widths might not match.
6526
78eb494e
PE
6527 * window.c (size_window): Avoid needless test at loop start.
6528
04f2d78b
CB
65292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6530
6531 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6532
d2fc7e3d 65332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6534
6535 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6536
d2fc7e3d 65372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6538
6539 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6540 `width' to `bar_area_x' and `bar_area_width', respectively.
6541 (x_scroll_run): Take account of fringe background extension.
6542
04f2d78b
CB
6543 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6544 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6545 `bar_area_width', respectively.
6546 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6547 background extension.
6548
79b70037
GM
65492011-05-10 Jim Meyering <meyering@redhat.com>
6550
6551 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6552
2f142cc5
JB
65532011-05-10 Juanma Barranquero <lekktu@gmail.com>
6554
6555 * image.c (Finit_image_library): Return t for built-in image types,
6556 like pbm and xbm. (Bug#8640)
6557
57679c86
AS
65582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6559
6560 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6561
888c9e86
EZ
65622011-05-07 Eli Zaretskii <eliz@gnu.org>
6563
b0512a1d
EZ
6564 * w32console.c (Fset_screen_color): Doc fix.
6565 (Fget_screen_color): New function.
6566 (syms_of_ntterm): Defsubr it.
6567
7285dc67
EZ
6568 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6569 unlink the temporary file if Fcall_process didn't create it in the
6570 first place.
6571 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6572 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6573 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6574 cue to call_process_cleanup not to close that handle.
6575
4d3fcc8e
BK
65762011-05-07 Ben Key <bkey76@gmail.com>
6577
6578 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6579 one of two shell specific rules, either bootstrap-temacs-CMD or
6580 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6581 to the previous implementation of the bootstrap-temacs rule.
6582 The bootstrap-temacs-CMD rule is similar to the previous
6583 implementation of the bootstrap-temacs rule except that it
6584 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6585 variable.
6586
6587 These changes, along with some changes to nt/configure.bat,
6588 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6589 earlier fix to add support for --cflags and --ldflags options
6590 that include quotes so that it works whether make uses cmd or
6591 sh as the shell.
6592
b4289b64
MA
65932011-05-06 Michael Albinus <michael.albinus@gmx.de>
6594
6595 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6596 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6597 is a constant.
6598 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6599 a string. Handle both cases.
6600 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6601 (Fdbus_register_method): Use Qinvalid_function.
6602
af4c0e28
JB
66032011-05-06 Juanma Barranquero <lekktu@gmail.com>
6604
6605 * makefile.w32-in: Update dependencies.
6606 (LISP_H): Add inttypes.h and stdin.h.
6607 (PROCESS_H): Add unistd.h.
6608
c51453d9
EZ
66092011-05-06 Eli Zaretskii <eliz@gnu.org>
6610
6611 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6612 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6613
8ff0ac3c 66142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6615
4c4b566b
PE
6616 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6617
aab2b9b5
PE
6618 * term.c (vfatal): Remove stray call to va_end.
6619 It's not needed and the C Standard doesn't allow it here anyway.
6620
c378da0b
PE
6621 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6622 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6623
288b08c7
PE
6624 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6625 bytes.
6626
e3601888
PE
6627 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6628
db6c0e74
PE
6629 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6630
dd5963ea
PE
6631 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6632
88c9450f
PE
6633 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6634
2f9442b8
PE
6635 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6636
c032b5f8
PE
6637 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6638 * charset.c (Fdefine_charset_internal): Don't initialize
6639 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6640 32-bit int (Bug#8600).
a108c10b
PE
6641
6642 * lread.c (read_integer): Be more consistent with string-to-number.
6643 Use string_to_number to do the actual conversion; this avoids
6644 rounding errors and fixes some other screwups. Without this fix,
6645 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6646 (digit_to_number): Move earlier, for benefit of read_integer.
6647 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6648 not a digit in any supported base. (Bug#8602)
a108c10b 6649
ad5f9eea
PE
6650 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6651
aec1708a
PE
6652 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6653 to match comment at start of function. This also removes a
6654 GCC warning about overflow in a 32+64-bit port.
6655
47be4ab5
PE
6656 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6657
371cac43
PE
6658 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6659 Reported by Stefan Monnier in
6660 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6661 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6662 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6663
d01a7826
PE
6664 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6665 (EMACS_UINTPTR): Likewise, with uintptr_t.
6666
7fd47d5c
PE
6667 * lisp.h: Prefer 64-bit EMACS_INT if available.
6668 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6669 on 32-bit hosts that have 64-bit int, so that they can access
6670 large files.
122b0c86
PE
6671 However, temporarily disable this change unless the temporary
6672 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6673
8727937b
PE
6674 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6675
8ac068ac
PE
6676 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6677 This removes an assumption that EMACS_INT and long are the same
6678 width as pointers. The assumption is true for Emacs porting targets
6679 now, but we want to make other targets possible.
6680 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6681 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6682 In the rest of the code, change types of integers that hold casted
6683 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6684 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6685 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6686 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6687 No need to cast type when ORing.
6688 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6689 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6690 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6691 assume EMACS_INT is the same width as char *.
6692 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6693 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6694 Remove no-longer-needed casts.
6695 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6696 (xg_tool_bar_help_callback, xg_make_tool_item):
6697 Use EMACS_INTPTR to hold an integer
6698 that will be cast to void *; this can avoid a GCC warning
6699 if EMACS_INT is not the same width as void *.
6700 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6701 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6702 (current_message_1, set_message_1):
6703 Use a local to convert to proper width without a cast.
6704 * xmenu.c (dialog_selection_callback): Likewise.
6705
ede49d71
PE
6706 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6707 Also, don't assume VALBITS / RAND_BITS is less than 5,
6708 and don't rely on undefined behavior when shifting a 1 left into
6709 the sign bit.
6710 * lisp.h (get_random): Change signature to match.
6711
2f30ecd0
PE
6712 * lread.c (hash_string): Use size_t, not int, for hash computation.
6713 Normally we prefer signed values; but hashing is special, because
6714 it's better to use unsigned division on hash table sizes so that
6715 the remainder is nonnegative. Also, size_t is the natural width
6716 for hashing into memory. The previous code used 'int', which doesn't
6717 retain enough info to hash well into very large tables.
6718 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6719
2a866e7b
PE
6720 * dbusbind.c: Don't possibly lose pointer info when converting.
6721 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6722 Use XPNTR rather than XHASH, so that the high-order bits of
6723 the pointer aren't lost when converting through void *.
6724
51639eac
PE
6725 * eval.c (Fautoload): Don't double-shift a pointer.
6726
92394119
PE
6727 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6728
dbdb9a7c
JB
67292011-05-06 Juanma Barranquero <lekktu@gmail.com>
6730
6731 * gnutls.c (DEF_GNUTLS_FN):
6732 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6733
db7a0b4f
AS
67342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6735
6736 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6737 marker. (Bug#8610)
6738
cd394be1 67392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6740
6741 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6742 New version that can reserve upto 2GB of heap space.
6743
f7ff1b0f 67442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6745
6746 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6747
639c109b
TZ
67482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6749
6750 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6751 `gnutls_certificate_set_x509_key_file'.
6752
d2127135
JB
67532011-05-05 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6756 Update dependencies.
6757
e968f4f3
JB
67582011-05-04 Juanma Barranquero <lekktu@gmail.com>
6759
6760 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6761 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6762 Remove unused parameter `fildes'.
6763 * process.c (read_process_output, send_process): Don't pass it.
6764
84d358f0
JB
67652011-05-04 Juanma Barranquero <lekktu@gmail.com>
6766
6767 Fix previous change: the library cache is defined in w32.c.
6768 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6769 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6770
0898ca10
JB
67712011-05-04 Juanma Barranquero <lekktu@gmail.com>
6772
6773 Implement dynamic loading of GnuTLS on Windows.
6774
6775 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6776 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6777 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6778 Declare.
6779
6780 * gnutls.c (Qgnutls_dll): Define.
6781 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6782 (gnutls_*): Declare function pointers.
6783 (init_gnutls_functions): New function to initialize function pointers.
6784 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6785 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6786 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6787 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6788 (emacs_gnutls_write, emacs_gnutls_read)
6789 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6790 (Fgnutls_available_p): New function.
6791 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6792 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6793 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6794
6795 * image.c: Include w32.h.
6796 (Vimage_type_cache): Delete.
6797 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6798 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6799 (w32_delayed_load): Move to w32.c.
6800
6801 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6802
6803 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6804 (w32_delayed_load): Move from image.c. When loading a library, record
6805 its filename in the :loaded-from property of the library id.
6806 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6807 Initialize and staticpro them.
6808 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6809
6810 * process.c: Include lisp.h before w32.h, not after.
6811 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6812 instead of gnutls_record_check_pending.
6813
6814 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6815
ff4de4aa
TZ
68162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6817
6818 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6819 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6820 as passed in.
6821
abe95abb
JD
68222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6823
6824 * xterm.c (x_set_frame_alpha): Do not set property on anything
6825 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6826
e16e55d4
JB
68272011-05-02 Juanma Barranquero <lekktu@gmail.com>
6828
6829 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6830
bafcf6a5
JB
68312011-05-02 Juanma Barranquero <lekktu@gmail.com>
6832
6833 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6834 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6835 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6836 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6837 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6838 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6839 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6840 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6841 (Qgnutls_bootprop_callbacks_verify): Make static.
6842
e7a6747f
AS
68432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6844
19ed11ba
AS
6845 * callproc.c: Indentation fixup.
6846
e7a6747f 6847 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6848 (wait_for_termination, interruptible_wait_for_termination):
6849 Move after wait_for_termination_1.
e7a6747f 6850
1ef14cb4
LMI
68512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6852
6853 * sysdep.c (interruptible_wait_for_termination): New function
6854 which is like wait_for_termination, but allows keyboard
6855 interruptions.
6856
6857 * callproc.c (Fcall_process): Add (:file "file") as an option for
6858 the STDOUT buffer.
6859 (Fcall_process_region): Ditto.
6860
330d880c
EZ
68612011-04-30 Eli Zaretskii <eliz@gnu.org>
6862
8db90b73
EZ
6863 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6864 rather than `XVECTOR (FOO)->size'.
6865
330d880c
EZ
6866 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6867 inttypes.h, as a gnulib replacement is used if it not available in
6868 system headers.
6869
15cbd324
EZ
68702011-04-21 Eli Zaretskii <eliz@gnu.org>
6871
6872 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6873 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6874 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6875
6876 * coding.c (coding_alloc_by_realloc): Error out if destination
6877 will grow beyond MOST_POSITIVE_FIXNUM.
6878 (decode_coding_emacs_mule): Abort if there isn't enough place in
6879 charbuf for the composition carryover bytes. Reserve an extra
6880 space for up to 2 characters produced in a loop.
6881 (decode_coding_iso_2022): Abort if there isn't enough place in
6882 charbuf for the composition carryover bytes.
6883
68842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6885
ae940cca
EZ
6886 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6887 aborting when %lld or %lll format is passed.
6888 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6889 %llo or %llx format is passed. (Bug#8545)
6890
03ab8921
EZ
6891 * window.c (window_scroll_line_based): Use a marker instead of
6892 simple variables to record original value of point. (Bug#7952)
6893
afda1437
EZ
6894 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6895 produced by %s or %c overflows available buffer space. (Bug#8545)
6896
f76dee0c
PE
68972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6898
6899 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6900 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6901
fdc5744d
JB
69022011-04-28 Juanma Barranquero <lekktu@gmail.com>
6903
6904 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6905
638f053a
JB
69062011-04-28 Juanma Barranquero <lekktu@gmail.com>
6907
6908 * keyboard.c (Qdelayed_warnings_hook): Define.
6909 (command_loop_1): Run `delayed-warnings-hook'
6910 if Vdelayed_warnings_list is non-nil.
6911 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6912 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6913
d178f871
EZ
69142011-04-28 Eli Zaretskii <eliz@gnu.org>
6915
6916 * doprnt.c (doprnt): Don't return value smaller than the buffer
6917 size if the message was truncated. (Bug#8545).
6918
b124fd93
JB
69192011-04-28 Juanma Barranquero <lekktu@gmail.com>
6920
6921 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6922 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6923
e810457d
PE
69242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6925
6926 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6927
ea51cceb
JB
69282011-04-27 Juanma Barranquero <lekktu@gmail.com>
6929
6930 * makefile.w32-in: Update dependencies.
6931
94dcfacf
EZ
69322011-04-27 Eli Zaretskii <eliz@gnu.org>
6933
6934 Improve `doprnt' and its usage. (Bug#8545)
6935 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6936 `format_end'. Remove support for %l as a conversion specifier.
6937 Don't use xrealloc. Improve diagnostics when the %l size modifier
6938 is used. Update the commentary.
6939
6940 * eval.c (verror): Simplify calculation of size_t.
6941
6942 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6943 messages.
6944
f61f41d7
PE
69452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6946
6947 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6948 change.
6949
96fb4434
PE
69502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6951
6952 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6953 This makes this file independent of the recent pseudovector change.
6954
671875da 69552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6956
69e9b5a3
PE
6957 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6958
b5f869a7 6959 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6960 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6961 Remove unused local.
c8926152 6962 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6963
841a1577 6964 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6965 GCC 4.6.0 optimizes based on type-based alias analysis.
6966 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6967 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6968 != &v->size, and therefore "v->size = 1; b->size = 2; return
6969 v->size;" must therefore return 1. This assumption is incorrect
6970 for Emacs, since it type-puns struct Lisp_Vector * with many other
6971 types. To fix this problem, this patch adds a new type struct
f904488f 6972 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6973 and pseudovectors, and helps optimizing compilers not get fooled
6974 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6975 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6976 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6977 the size member.
eab3844f
PE
6978 (XSETPVECTYPE): Rewrite in terms of new macro.
6979 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6980 This is a bit clearer, and further avoids the possibility of
6981 undesirable aliasing.
6982 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6983 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6984 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6985 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6986 (ASIZE): Now uses header.size rather than size.
6987 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6988 to avoid the hassle of writing XVECTOR (foo)->header.size.
6989 (struct vectorlike_header): New type.
eab3844f
PE
6990 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6991 object, to help avoid aliasing.
6992 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6993 (SUBRP): Likewise, since Lisp_Subr is a special case.
6994 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6995 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6996 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6997 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6998 changed to be "header.size" and "header.next".
6999 * buffer.h (struct buffer): Likewise.
7000 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7001 * frame.h (struct frame): Likewise.
7002 * process.h (struct Lisp_Process): Likewise.
7003 * termhooks.h (struct terminal): Likewise.
7004 * window.c (struct save_window_data, struct saved_window): Likewise.
7005 * window.h (struct window): Likewise.
7006 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7007 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7008 * buffer.c (init_buffer_once): Likewise.
7009 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7010 special case.
7011 * process.c (Fformat_network_address): Use local var for size,
7012 for brevity.
7013
0df1eac5
PE
7014 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7015
847ab9d1 7016 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7017 * data.c (atof): Remove decl; no longer used or needed.
7018 (digit_to_number): Move to lread.c.
7019 (Fstring_to_number): Use new string_to_number function, to be
7020 consistent with how the Lisp reader treats infinities and NaNs.
7021 Do not assume that floating-point numbers represent EMACS_INT
7022 without losing information; this is not true on most 64-bit hosts.
7023 Avoid double-rounding errors, by insisting on integers when
7024 parsing non-base-10 numbers, as the documentation specifies.
7025 * lisp.h (string_to_number): New decl, replacing ...
7026 (isfloat_string): Remove.
bc0a5c13 7027 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7028 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7029 appears to have been a coding error. Similarly, do not accept
7030 strings like +-1e0 as floating point numbers. Do not report
7031 overflow for integer overflows unless the base is not 10 which
7032 means we have no simple and reliable way to continue.
7033 Break out the floating-point parsing into a new
7034 function string_to_number, so that Fstring_to_number parses
7035 floating point numbers consistently with the Lisp reader.
04f2d78b 7036 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7037 (E_CHAR, EXP_INT): Remove, replacing with ...
7038 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7039 (string_to_number): New function, replacing isfloat_string.
7040 This function checks for valid syntax and produces the resulting
7041 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7042 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7043 so that overflow for non-base-10 numbers is reported only when
7044 there's no portable and simple way to convert to floating point.
452f4150 7045
67769ffc
PE
7046 * textprop.c (set_text_properties_1): Rewrite for clarity,
7047 and to avoid GCC warning about integer overflow.
7048
c20db43f
PE
7049 * intervals.h (struct interval): Use EMACS_INT for members
7050 where EMACS_UINT might cause problems. See
7051 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7052 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7053 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7054 All uses changed.
37aa2f85
PE
7055 (offset_intervals): Tell GCC not to worry about length overflow
7056 when negating a negative length.
c20db43f 7057
2538aa2f
PE
7058 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7059 (overrun_check_free): Likewise.
7060
f2d3008d
PE
7061 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7062 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7063 word size.
7064
ec8df744
PE
7065 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7066 (gnutls_make_error): Rename local to avoid shadowing.
7067 (gnutls_emacs_global_deinit): ifdef out; not used.
7068 (Fgnutls_boot): Use const for pointer to readonly storage.
7069 Comment out unused local. Fix pointer signedness problems.
7070
640ee02d
PE
7071 * lread.c (openp): Don't stuff size_t into an 'int'.
7072 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7073 about possible signed overflow.
7074
6048fb2a
PE
7075 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7076 (GDK_KEY_g): Don't define if already defined.
7077 (xg_prepare_tooltip): Avoid pointer signedness problem.
7078 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7079
fa3c87e1
PE
7080 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7081 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7082
2172544b
PE
7083 * xfns.c (Fx_window_property): Simplify a bit,
7084 to make a bit faster and to avoid GCC 4.6.0 warning.
7085 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7086
9b821a21
PE
7087 * fns.c (internal_equal): Don't assume size_t fits in int.
7088
3c616cfa
PE
7089 * alloc.c (compact_small_strings): Tighten assertion a little.
7090
c2982e87
PE
7091 Replace pEd with more-general pI, and fix some printf arg casts.
7092 * lisp.h (pI): New macro, generalizing old pEd macro to other
7093 conversion specifiers. For example, use "...%"pI"d..." rather
7094 than "...%"pEd"...".
7095 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7096 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7097 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7098 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7099 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7100 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7101 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7102 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7103 64-bit hosts.
7104 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7105 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7106 * print.c (safe_debug_print, print_object): Likewise.
7107 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7108 to int.
6f04d126
PE
7109 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7110 avoiding the 0 flag, which is not portable.
c2982e87
PE
7111 * process.c (Fmake_network_process): Use pI to avoid cast.
7112 * region-cache.c (pp_cache): Likewise.
7113 * xdisp.c (decode_mode_spec): Likewise.
7114 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7115 behavior on 64-bit hosts with printf arg.
6f04d126 7116 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7117 (x_stop_queuing_selection_requests): Likewise.
7118 (x_get_window_property): Don't truncate byte count to an 'int'
7119 when tracing.
0b432f21 7120
5e073ec7
PE
7121 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7122 here, since it parses constructs like leading '-' and spaces,
7123 which are not wanted; and it overflows with large numbers.
7124 Instead, simply match F[0-9]+, which is what is wanted anyway.
7125
36372bf9
PE
7126 * alloc.c: Remove unportable assumptions about struct layout.
7127 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7128 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7129 (allocate_vectorlike, make_pure_vector): Use the new macros,
7130 plus offsetof, to remove unportable assumptions about struct layout.
7131 These assumptions hold on all porting targets that I know of, but
7132 they are not guaranteed, they're easy to remove, and removing them
7133 makes further changes easier.
7134
0b432f21
PE
7135 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7136 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7137 (string_overrun_cookie): Now const. Use initializers that
7138 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7139 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7140 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7141 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7142 multiple of sizeof (EMACS_INT); it need not be, if
7143 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7144 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7145
895009e1
JB
71462011-04-26 Juanma Barranquero <lekktu@gmail.com>
7147
7148 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7149
6a7a1b0b
TZ
71502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7151
7152 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7153 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7154 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7155
841a1577 71562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7157
7158 * lisp.h (Qdebug): List symbol.
895009e1 7159 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7160 * keyboard.c (debug-on-event): New variable.
7161 (handle_user_signal): Break into debugger when debug-on-event
7162 matches the current signal symbol.
7163
f2d3ba6f
DN
71642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7165
7166 * alloc.c (check_sblock, check_string_bytes)
7167 (check_string_free_list): Convert to standard C.
7168
42ce4c63
TZ
71692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7170
7171 * w32.c (emacs_gnutls_push): Fix typo.
7172
825cd63c
EZ
71732011-04-25 Eli Zaretskii <eliz@gnu.org>
7174
fb11d64d
EZ
7175 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7176 "cast to pointer from integer of different size".
7177
825cd63c
EZ
7178 Improve doprnt and its use in verror. (Bug#8545)
7179 * doprnt.c (doprnt): Document the set of format control sequences
7180 supported by the function. Use SAFE_ALLOCA instead of always
7181 using `alloca'.
7182
7183 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7184 is one byte too soon. Don't use xrealloc; instead xfree and
7185 xmalloc anew.
7186
e061a11b
TZ
71872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7188
7189 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7190 callbacks stage.
7191
7192 * gnutls.c: Renamed global_initialized to
7193 gnutls_global_initialized. Added internals for the
7194 :verify-hostname-error, :verify-error, and :verify-flags
7195 parameters of `gnutls-boot' and documented those parameters in the
7196 docstring. Start callback support.
9173deec
JB
7197 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7198 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7199 on error. Return error code.
e061a11b
TZ
7200 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7201 (emacs_gnutls_read): Likewise.
7202 (Fgnutls_boot): Return handshake error code.
7203 (emacs_gnutls_handle_error): New function.
7204 (wsaerror_to_errno): Likewise.
7205
7206 * w32.h (emacs_gnutls_pull): Add prototype.
7207 (emacs_gnutls_push): Likewise.
7208
7209 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7210 (emacs_gnutls_push): Likewise.
7211
72122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7213
7214 * process.c (wait_reading_process_output): Check if GnuTLS
7215 buffered some data internally if no FDs are set for TLS
7216 connections.
7217
7218 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7219 (LIBS): Link to USER_LIBS.
7220 ($(BLD)/gnutls.$(0)): New target.
7221
fa6996bc
EZ
72222011-04-24 Eli Zaretskii <eliz@gnu.org>
7223
eb35682e
EZ
7224 * xdisp.c (handle_single_display_spec): Rename the
7225 display_replaced_before_p argument into display_replaced_p, to
7226 make it consistent with the commentary. Fix typos in the
7227 commentary.
7228
e2ad650c
EZ
7229 * textprop.c (syms_of_textprop): Remove dead code.
7230 (copy_text_properties): Delete obsolete commentary about an
7231 interface that was deleted long ago. Fix typos in the description
7232 of arguments.
7233
1b2de274
EZ
7234 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7235 to changes in oldXMenu/XMenu.h from 2011-04-16.
7236 <menu_help_message, prev_menu_help_message>: Constify.
7237 (IT_menu_make_room): menu->help_text is now `const char **';
7238 adjust.
7239
7240 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7241 to changes in oldXMenu/XMenu.h from 2011-04-16.
7242 (struct XMenu): Declare `help_text' `const char **'.
7243
7244 * xfaces.c <Qunspecified>: Make extern again.
7245
7246 * syntax.c: Include sys/types.h before including regex.h, as
7247 required by Posix.
7248
762b15be
EZ
7249 * doc.c (get_doc_string): Improve the format passed to `error'.
7250
7251 * doprnt.c (doprnt): Improve commentary.
7252
7253 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7254
7255 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7256 them with etags.
7257
f1052e5d
EZ
7258 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7259 changes in globals.h immediately force recompilation.
762b15be
EZ
7260 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7261 $(CURDIR)/s/ms-w32.h.
7262 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7263
fa6996bc
EZ
7264 * character.c (Fchar_direction): Function deleted.
7265 (syms_of_character): Don't defsubr it.
7266 <char-direction-table>: Deleted.
7267
e6c3da20
EZ
72682011-04-23 Eli Zaretskii <eliz@gnu.org>
7269
7270 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7271 * doprnt.c: Include limits.h.
7272 (SIZE_MAX): New macro.
04f2d78b
CB
7273 (doprnt): Return a size_t value. 2nd arg is now size_t.
7274 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7275 Improve overflow protection. Support `l' modifier for integer
7276 conversions. Support %l conversion. Don't assume an EMACS_INT
7277 argument for integer conversions and for %c.
7278
7279 * lisp.h (doprnt): Restore prototype.
7280
7281 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7282 $(SRC)/character.h.
7283
7284 * Makefile.in (base_obj): Add back doprnt.o.
7285
7286 * deps.mk (doprnt.o): Add back prerequisites.
7287 (callint.o): Depend on character.h.
7288
7289 * eval.c (internal_lisp_condition_case): Include the handler
7290 representation in the error message.
7291 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7292 when breaking from the loop.
7293
7294 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7295
7296 * callint.c (Fcall_interactively): When displaying error message
7297 about invalid control letter, pass the character's codepoint, not
7298 a pointer to its multibyte form. Improve display of the character
7299 in octal and display also its hex code.
7300
7301 * character.c (char_string): Use %x to display the (unsigned)
7302 codepoint of an invalid character, to avoid displaying a bogus
7303 negative value.
7304
7305 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7306 `error', not SYMBOL_NAME itself.
7307
7308 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7309 character arguments to `error'.
7310
7311 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7312 to `error' in error message about FINAL_CHAR argument. Make sure
7313 FINAL_CHAR is a character, and use %c when it is passed as
7314 argument to `error'.
7315
4ffd0d6b 73162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7317
7318 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7319
7320 * w32.c: Include <time.h>.
7321 (sys_localtime): New function.
7322
4ffd0d6b 73232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7324
7325 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7326
4ffd0d6b 7327 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7328
4ffd0d6b 73292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7330
4ffd0d6b
GM
7331 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7332 zombies (Bug#8467).
aac0c6e3 7333
04c56954
EZ
73342011-04-19 Eli Zaretskii <eliz@gnu.org>
7335
7336 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7337 gl_state.e_property when gl_state.object is Qt.
7338
7339 * insdel.c (make_gap_larger): Remove limitation of buffer size
7340 to <= INT_MAX.
7341
16a43933
CY
73422011-04-18 Chong Yidong <cyd@stupidchicken.com>
7343
7344 * xdisp.c (lookup_glyphless_char_display)
7345 (produce_glyphless_glyph): Handle cons cell entry in
7346 glyphless-char-display.
7347 (Vglyphless_char_display): Document it.
7348
7349 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7350 glyphless-char-display.
7351
4581706e
CY
73522011-04-17 Chong Yidong <cyd@stupidchicken.com>
7353
7354 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7355
7356 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7357
7358 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7359 definition for no-X builds.
7360
4887c6e2 73612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7362
fd35b6f9
PE
7363 Static checks with GCC 4.6.0 and non-default toolkits.
7364
5c1ccb01
PE
7365 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7366
006c5daa
PE
7367 * process.c (keyboard_bit_set): Define only if SIGIO.
7368 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7369 (send_process): Repair possible setjmp clobbering.
7370
efc736d3
PE
7371 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7372
4e2fe2e6
PE
7373 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7374
f97334a2
PE
7375 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7376
4e75f29d
PE
7377 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7378 Define only if needed.
7379
90efadd1
PE
7380 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7381 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7382 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7383
3c647824
PE
7384 * dispextern.h (struct redisplay_interface): Rename param
7385 to avoid shadowing.
e264f262 7386 * termhooks.h (struct terminal): Likewise.
761383f4 7387 * xterm.c (xembed_send_message): Likewise.
3c647824 7388
b58c5c4a
PE
7389 * insdel.c (make_gap_smaller): Define only if
7390 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7391
cad59032
PE
7392 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7393 it.
7394
c339dc2e
PE
7395 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7396 so that we aren't warned about unused symbols.
7397
91a3e27b
PE
7398 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7399
399c71d3 7400 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7401
8ffc96f5
PE
7402 * xfns.c (x_real_positions): Mark locals as initialized.
7403
eef9bc79
PE
7404 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7405
098db9dd
PE
7406 * xterm.c: Fix problems found by static analysis with other toolkits.
7407 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7408 (x_dispatch_event): Declare static if USE_GTK, and
7409 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7410 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7411 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7412 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7413 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7414
eb18f6cc
PE
7415 * xmenu.c (menu_help_callback): Pointer type fixes.
7416 Use const pointers when pointing at readonly data. Avoid pointer
7417 signedness clashes.
7418 (FALSE): Remove unused macro.
7419 (update_frame_menubar): Remove unused decl.
7420
1fe72bf8
PE
7421 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7422
60d9e1db
PE
7423 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7424 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7425 (single_menu_item): Rename local to avoid shadowing.
7426
39261c26
PE
7427 * keyboard.c (make_lispy_event): Remove unused local var.
7428
018c5e19
PE
7429 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7430 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7431
63d2b86e
PE
7432 * bitmaps: Change bitmaps from unsigned char back to the X11
7433 compatible char. Avoid the old compiler warnings about
7434 out-of-range initializers by using, for example, '\xab' rather
7435 than 0xab.
7436
aefd87e1
PE
7437 * xgselect.c (xgselect_initialize): Check vs interface
7438 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7439
bf501fb9
PE
7440 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7441
e9829fdf
PE
7442 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7443 to read-only memory.
7444
1086c095
PE
7445 * fns.c (vector): Remove; this old hack is no longer needed.
7446
2baccd04 7447 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7448 Remove unused var.
dde42981 7449 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7450
72391843 7451 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7452
436c16df 7453 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7454 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7455 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7456
92bb796d 7457 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7458 (x_term_init): Remove local to avoid shadowing.
92bb796d 7459
764430a3 7460 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7461
7462 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7463 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7464
d1dfb56c
EZ
74652011-04-16 Eli Zaretskii <eliz@gnu.org>
7466
c4354cb4
EZ
7467 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7468
d1dfb56c
EZ
7469 Fix regex.c, syntax.c and friends for buffers > 2GB.
7470 * syntax.h (struct gl_state_s): Declare character position members
7471 EMACS_INT.
7472
7473 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7474
04f2d78b
CB
7475 * textprop.c (verify_interval_modification, interval_of):
7476 Declare arguments EMACS_INT.
d1dfb56c
EZ
7477
7478 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7479 EMACS_INT.
7480
7481 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7482
7483 * indent.c (Fvertical_motion): Local variable it_start is now
7484 EMACS_INT.
7485
7486 * regex.c (re_match, re_match_2, re_match_2_internal)
7487 (bcmp_translate, regcomp, regexec, print_double_string)
7488 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7489 (re_compile_pattern, re_exec): Declare arguments and local
7490 variables `size_t' and `ssize_t' and return values `regoff_t', as
7491 appropriate.
7492 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7493 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7494 <compile_stack_type>: `size' and `avail' are now `size_t'.
7495
7496 * regex.h <regoff_t>: Use ssize_t, not int.
7497 (re_search, re_search_2, re_match, re_match_2): Arguments that
7498 specify buffer/string position and length are now ssize_t and
7499 size_t. Return type is regoff_t.
7500
613052cd
BK
75012011-04-16 Ben Key <bkey76@gmail.com>
7502
7503 * nsfont.m: Fixed bugs in ns_get_family and
7504 ns_descriptor_to_entity that were caused by using free to
7505 deallocate memory blocks that were allocated by xmalloc (via
7506 xstrdup). This caused Emacs to crash when compiled with
7507 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7508 --enable-checking=xmallocoverrun). xfree is now used to
7509 deallocate these memory blocks.
7510
4170f62f 75112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7512
71b41406
PE
7513 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7514
9587a89d
PE
7515 emacs_write: Accept and return EMACS_INT for sizes.
7516 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7517 et seq.
7518 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7519 Accept and return EMACS_INT.
7520 (emacs_gnutls_write): Return the number of bytes written on
7521 partial writes.
7522 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7523 (emacs_read, emacs_write): Remove check for negative size, as the
7524 Emacs source code has been audited now.
9587a89d
PE
7525 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7526 (emacs_read, emacs_write): Use it.
273a5f82
PE
7527 * process.c (send_process): Adjust to the new signatures of
7528 emacs_write and emacs_gnutls_write. Do not attempt to store
7529 a byte offset into an 'int'; it might overflow.
9587a89d 7530 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7531
3e047f51
PE
7532 * sound.c: Don't assume sizes fit in 'int'.
7533 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7534 Return EMACS_INT, not int.
3e047f51 7535 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7536 Accept EMACS_INT, not int.
7537 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7538 record read return values.
7539
cc39a9db
BK
75402011-04-15 Ben Key <bkey76@gmail.com>
7541
c9d0ec6d
JB
7542 * keyboard.c (Qundefined): Don't declare static since it is used
7543 in nsfns.m.
7544 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7545 static since they are used in nsfont.m.
cc39a9db 7546
6c60eb9f
SM
75472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7548
7549 * process.c (Qprocessp): Don't declare static.
7550 * lisp.h (Qprocessp): Declare again.
7551
7990b61a
JB
75522011-04-15 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7555
5d4cb038
PE
75562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7557
8bd7b830 7558 Improve C-level modularity by making more things 'static'.
cd64ea1d 7559
e3b27b31
PE
7560 Don't publish debugger-only interfaces to other modules.
7561 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7562 (verify_bytepos, count_markers): Move decls to the only modules
7563 that need them.
7564 * region-cache.h (pp_cache): Likewise.
7565 * window.h (check_all_windows): Likewise.
7566 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7567
5d4cb038
PE
7568 * sysdep.c (croak): Now static, if
7569 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7570 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7571
7572 * alloc.c (refill_memory_reserve): Now static if
7573 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7574 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7575
e87b6180
PE
7576 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7577 Define only if USE_LUCID.
7578
ac64929e
PE
7579 * xrdb.c (x_customization_string, x_rm_string): Now static.
7580
6f37259d
PE
7581 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7582 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7583
1683e3ab
PE
7584 * xdisp.c (draw_row_with_mouse_face): Now static.
7585 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7586
de9c2632
PE
7587 * window.h (check_all_windows): Mark externally visible.
7588
2b96acb7
PE
7589 * window.c (window_deletion_count): Now static.
7590
7591 * undo.c: Make symbols static if they're not exported.
7592 (last_undo_buffer, last_boundary_position, pending_boundary):
7593 Now static.
7594
50436f33
PE
7595 * textprop.c (interval_insert_behind_hooks): Now static.
7596 (interval_insert_in_front_hooks): Likewise.
7597
64520e5c
PE
7598 * term.c: Make symbols static if they're not exported.
7599 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7600 (max_frame_lines, tty_set_terminal_modes):
7601 (tty_reset_terminal_modes, tty_turn_off_highlight):
7602 (get_tty_terminal): Now static.
7603 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7604 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7605 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7606 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7607 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7608
1fa53021
PE
7609 * sysdep.c: Make symbols static if they're not exported.
7610 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7611 Now static.
7612 (sigprocmask_set, full_mask): Remove; unused.
7613 (wait_debugging): Mark as visible.
7614 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7615 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7616
d4b43b22
PE
7617 * syntax.c (syntax_temp): Define only if !__GNUC__.
7618
b7c513d0
PE
7619 * sound.c (current_sound_device, current_sound): Now static.
7620
989b29ad
PE
7621 * search.c (searchbufs, searchbuf_head): Now static.
7622
13a55a78
PE
7623 * scroll.c (scroll_cost): Remove; unused.
7624 * dispextern.h (scroll_cost): Remove decl.
7625
de68a1fc
PE
7626 * region-cache.h (pp_cache): Mark as externally visible.
7627
40ccffa6
PE
7628 * process.c: Make symbols static if they're not exported.
7629 (process_tick, update_tick, create_process, chan_process):
7630 (Vprocess_alist, proc_buffered_char, datagram_access):
7631 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7632 (deactivate_process): Mark defn as static, as well as decl.
7633 * lisp.h (create_process): Remove decl.
7634 * process.h (chan_process, Vprocess_alist): Remove decls.
7635
ad64fc97
PE
7636 * print.c: Make symbols static if they're not exported.
7637 (print_depth, new_backquote_output, being_printed, print_buffer):
7638 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7639 (print_interval, print_number_index, initial_stderr_stream):
7640 Now static.
7641 * lisp.h (Fprinc): Remove decl.
7642 (debug_output_compilation_hack): Mark as externally visible.
7643
adddb265
PE
7644 * sysdep.c (croak): Move decl from here to syssignal.h.
7645 * syssignal.h (croak): Put it here, so the API can be checked when
7646 'croak' is called from dissociate_if_controlling_tty.
7647
1717ede2
PE
7648 * minibuf.c: Make symbols static if they're not exported.
7649 (minibuf_save_list, choose_minibuf_frame): Now static.
7650 * lisp.h (choose_minibuf_frame): Remove decl.
7651
fa5fb2bc
PE
7652 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7653
1e3890d1
PE
7654 * lread.c: Make symbols static if they're not exported.
7655 (read_objects, initial_obarray, oblookup_last_bucket_number):
7656 Now static.
7657 (make_symbol): Remove; unused.
7658 * lisp.h (initial_obarray, make_symbol): Remove decls.
7659
8a1414fa
PE
7660 * keyboard.c: Make symbols static if they're not exported.
7661 (single_kboard, recent_keys_index, total_keys, recent_keys):
7662 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7663 (this_single_command_key_start, echoing, last_auto_save):
7664 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7665 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7666 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7667 (Vlispy_mouse_stem, double_click_count):
7668 Now static.
7669 (force_auto_save_soon): Define only if SIGDANGER.
7670 (ignore_mouse_drag_p): Now static if
7671 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7672 (print_help): Remove; unused.
7673 (stop_character, last_timer_event): Mark as externally visible.
7674 * keyboard.h (ignore_mouse_drag_p): Declare only if
7675 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7676 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7677 * lisp.h (echoing): Remove decl.
7678 (force_auto_save_soon): Declare only if SIGDANGER.
7679 * xdisp.c (redisplay_window): Simplify code, to make it more
7680 obvious that ignore_mouse_drag_p is not accessed if !defined
7681 USE_GTK && !defined HAVE_NS.
7682
93ea6e8f
PE
7683 * intervals.c: Make symbols static if they're not exported.
7684 (merge_properties_sticky, merge_interval_right, delete_interval):
7685 Now static.
7686 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7687
77382fcc
PE
7688 * insdel.c: Make symbols static if they're not exported.
7689 However, leave prepare_to_modify_buffer alone. It's never
7690 called from outside this function, but that appears to be a bug.
7691 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7692 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7693 (adjust_after_replace_noundo): Remove; unused.
7694 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7695 (signal_before_change): Remove decls.
77382fcc 7696
9306c32e
PE
7697 * indent.c (val_compute_motion, val_vmotion): Now static.
7698
cd44d2eb
PE
7699 * image.c: Make symbols static if they're not exported.
7700 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7701 if USE_GTK.
7702 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7703 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7704
ad9a7a06
PE
7705 * fringe.c (standard_bitmaps): Now static.
7706 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7707
81626931
PE
7708 * frame.c: Make symbols static if they're not exported.
7709 (x_report_frame_params, make_terminal_frame): Now static.
7710 (get_frame_param): Now static, unless HAVE_NS.
7711 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7712 (x_get_resource_string): Remove; not used.
7713 * frame.h (make_terminal_frame, x_report_frame_params):
7714 (x_get_resource_string); Remove decls.
7715 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7716 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7717
239f9db9
PE
7718 * font.c, fontset.c: Make symbols static if they're not exported.
7719 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7720 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7721 * font.c (font_close_object): Now static.
7722 * font.h (font_close_object): Remove.
7723 * fontset.c (FONTSET_OBJLIST): Remove.
7724 (free_realized_fontset) #if-0 the body, which does nothing.
7725 (face_suitable_for_char_p): #if-0, as it's never called.
7726 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7727 * xfaces.c (face_at_string_position):
7728 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7729 since 0 is always ASCII.
7730
dfcf3579
PE
7731 * fns.c (weak_hash_tables): Now static.
7732
5045092b
PE
7733 * fileio.c: Make symbols static if they're not exported.
7734 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7735 (Vwrite_region_annotation_buffers): Now static.
7736
57a96f5c
PE
7737 * eval.c: Make symbols static if they're not exported.
7738 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7739 * lisp.h (backtrace_list): Remove decl.
7740
35f08c38
PE
7741 * emacs.c: Make symbols static if they're not exported.
7742 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7743 (fatal_error_code, fatal_error_signal_hook, standard_args):
7744 Now static.
7745 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7746 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7747 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7748 * lisp.h (fatal_error_signal_hook): Remove decl.
7749 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7750
f44bd759
PE
7751 * editfns.c: Move a (normally-unused) function to its only use.
7752 * editfns.c, lisp.h (get_operating_system_release): Remove.
7753 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7754 worth the hassle of breaking this out.
7755
b532497d
PE
7756 * xterm.c: Make symbols static if they're not exported.
7757 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7758 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7759 (x_destroy_window, x_delete_display):
7760 Now static.
7761 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7762 (x_mouse_leave): Remove; unused.
7763 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7764 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7765 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7766 Remove decls.
7767 (x_mouse_leave): Declare only if WINDOWSNT.
7768 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7769 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7770 USE_X_TOOLKIT.
7771
1675728f
PE
7772 * ftxfont.c: Make symbols static if they're not exported.
7773 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7774 HAVE_FREETYPE.
7775 * font.h (ftxfont_driver): Likewise.
7776
e4cebfca
PE
7777 * xfns.c: Make symbols static if they're not exported.
7778 (x_last_font_name, x_display_info_for_name):
7779 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7780 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7781 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7782 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7783 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7784 (last_show_tip_args): Now static.
7785 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7786 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7787 (x_screen_planes): Remove; unused.
7788 * dispextern.h (x_screen_planes): Remove decl.
7789
5bf46f05
PE
7790 * dispnew.c: Make symbols static if they're not exported.
7791 * dispextern.h (redraw_garbaged_frames, scrolling):
7792 (increment_row_positions): Remove.
7793 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7794 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7795 Now static.
7796 (redraw_garbaged_frames): Remove; unused.
7797
435f4c28
PE
7798 * xfaces.c: Make symbols static if they're not exported.
7799 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7800 Remove decls.
7801 * xterm.h (defined_color): Remove decls.
7802 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7803 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7804 (menu_face_changed_default, defined_color, free_realized_face):
7805 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7806 (ascii_face_of_lisp_face): Remove; unused.
7807
8524aef3
PE
7808 * xdisp.c: Make symbols static if they're not exported.
7809 * dispextern.h (scratch_glyph_row, window_box_edges):
7810 (glyph_to_pixel_coords, set_cursor_from_row):
7811 (get_next_display_element, set_iterator_to_next):
7812 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7813 (show_mouse_face): Remove decls
7814 * frame.h (message_buf_print): Likewise.
7815 * lisp.h (pop_message, set_message, check_point_in_composition):
7816 Likewise.
7817 * xterm.h (set_vertical_scroll_bar): Likewise.
7818 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7819 (message_buf_print, scratch_glyph_row, displayed_buffer):
7820 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7821 (get_next_display_element, show_mouse_face, window_box_edges):
7822 (frame_to_window_pixel_xy, check_point_in_composition):
7823 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7824 (glyph_to_pixel_coords): Remove; unused.
7825
16390cd2
PE
7826 * dired.c (file_name_completion): Now static.
7827
7828 * dbusbind.c (xd_in_read_queued_messages): Now static.
7829
a25f4dfa
PE
7830 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7831 * data.c (circular_list_error): Remove.
7832
14a9c8df
PE
7833 * commands.h (last_point_position, last_point_position_buffer):
7834 (last_point_position_window): Remove decls.
7835 * keyboard.c: Make these variables static.
7836
04f2d78b
CB
7837 * coding.h (coding, code_convert_region, encode_coding_gap):
7838 Remove decls.
74ab6df5
PE
7839 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7840 (iso_code_class, detect_coding, code_convert_region): Now static.
7841 (encode_coding_gap): Remove; unused.
7842
38dfbee1
PE
7843 * chartab.c (chartab_chars, chartab_bits): Now static.
7844
a2cb4e63
PE
7845 * charset.h (charset_iso_8859_1): Remove decl.
7846 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7847 Now static.
7848
127198fd
PE
7849 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7850 * ccl.c (Vccl_program_table): Now static.
7851 (check_ccl_update): Remove; unused.
7852
d85b608f
PE
7853 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7854 * category.h: ... from here.
7855 * category.c (check_category_table, set_category_set): Now static.
7856
31cd66f3
PE
7857 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7858 * lisp.h: Remove these decls.
7859
c358e587
PE
7860 * buffer.c (buffer_count): Remove unused var.
7861
e78aecca
PE
7862 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7863 so that it's not optimized away.
7864 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7865 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7866 exported only to the debugger.
7867
e192d7d3 7868 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7869 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7870
92470028
PE
7871 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7872 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7873 was inaccessible from Lisp.
7874 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7875 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7876
244ed907
PE
7877 alloc.c: Import and export fewer symbols, and remove unused items.
7878 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7879 is defined.
7880 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7881 it's not optimized away by whole-program optimization.
7882 (message_enable_multibyte, free_misc): Remove.
7883 (catchlist, handlerlist, mark_backtrace):
7884 Declare only if BYTE_MARK_STACK.
7885 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7886 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7887 (message_enable_multibyte): Remove decl.
7888 (free_misc, interval_free_list, float_block, float_block_index):
7889 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7890 (cons_free_list, last_marked_index):
7891 Now static.
7892 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7893 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7894 (mark_backtrace): Define only if BYTE_MARK_STACK.
7895 * xdisp.c (message_enable_multibyte): Now static.
7896
61c2b50e 7897 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7898 This makes it easier for human readers (and static analyzers)
7899 to see whether these variables are used from other modules.
7900 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7901 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7902 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7903 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7904 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7905 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7906 * xmenu.c, xselect.c:
7907 Declare Q* vars static if they are not used in other modules.
7908 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7909 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7910 Remove decls of unexported vars.
7911 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7912
95c82688
PE
7913 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7914
16a97296
PE
7915 Make Emacs functions such as Fatom 'static' by default.
7916 This makes it easier for human readers (and static analyzers)
7917 to see whether these functions can be called from other modules.
7918 DEFUN now defines a static function. To make the function external
7919 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7920 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7921 (Finit_image_library):
16a97296
PE
7922 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7923 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7924 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7925 Remove decls, since these functions are now static.
7926 (Funintern, Fget_internal_run_time): New decls, since these functions
7927 were already external.
95c82688 7928
16a97296
PE
7929 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7930 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7931 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7932 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7933 * keyboard.c, keymap.c, lread.c:
7934 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7935 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7936 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7937 Mark functions with DEFUE instead of DEFUN,
7938 if they are used in other modules.
7939 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7940 decls for now-static functions.
7941 * buffer.h (Fdelete_overlay): Remove decl.
7942 * callproc.c (Fgetenv_internal): Mark as internal.
7943 * composite.c (Fremove_list_of_text_properties): Remove decl.
7944 (Fcomposition_get_gstring): New forward static decl.
7945 * composite.h (Fcomposite_get_gstring): Remove decl.
7946 * dired.c (Ffile_attributes): New forward static decl.
7947 * doc.c (Fdocumntation_property): New forward static decl.
7948 * eval.c (Ffetch_bytecode): New forward static decl.
7949 (Funintern): Remove extern decl; now in .h file where it belongs.
7950 * fileio.c (Fmake_symbolic_link): New forward static decl.
7951 * image.c (Finit_image_library): New forward static decl.
7952 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7953 * intervals.h (Fprevious_property_change):
7954 (Fremove_list_of_text_properties): Remove decls.
7955 * keyboard.c (Fthis_command_keys): Remove decl.
7956 (Fcommand_execute): New forward static decl.
7957 * keymap.c (Flookup_key): New forward static decl.
7958 (Fcopy_keymap): Now static.
7959 * keymap.h (Flookup_key): Remove decl.
7960 * process.c (Fget_process): New forward static decl.
7961 (Fprocess_datagram_address): Mark as internal.
7962 * syntax.c (Fsyntax_table_p): New forward static decl.
7963 (skip_chars): Remove duplicate decl.
7964 * textprop.c (Fprevious_property_change): New forward static decl.
7965 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7966 Now internal.
7967 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7968 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7969
785bbd42
PE
7970 * editfns.c (Fformat): Remove unreachable code.
7971
8b913b57
AS
79722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7973
7974 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7975 change. (Bug#8496)
7976
a6744a35
EZ
79772011-04-13 Eli Zaretskii <eliz@gnu.org>
7978
7979 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7980 when at ZV. (Bug#8487)
7981
e7974947
AS
79822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7983
baad03f0
AS
7984 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7985 (Bug#8437)
7986 * keyboard.c (parse_tool_bar_item): Likewise.
7987 * sound.c (sound_cleanup, alsa_close): Likewise.
7988 * termcap.c (tgetent): Likewise.
7989 * xfns.c (x_default_font_parameter): Likewise.
7990 * xsettings.c (read_and_apply_settings): Likewise.
7991
e7974947
AS
7992 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7993 (overrun_check_free): Protoize.
7994
28272684
PE
79952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7996
7997 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7998 since callers should never pass a negative size.
7999 Change the signature to match that of plain 'read' and 'write'; see
8000 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8001 * lisp.h: Update prototypes of emacs_write and emacs_read.
8002
11997c76
EZ
80032011-04-11 Eli Zaretskii <eliz@gnu.org>
8004
8005 * xdisp.c (redisplay_window): Don't try to determine the character
8006 position of the scroll margin if the window start point w->startp
e896f03c 8007 is outside the buffer's accessible region. (Bug#8468)
11997c76 8008
8a2cbd72
EZ
80092011-04-10 Eli Zaretskii <eliz@gnu.org>
8010
8011 Fix write-region and its subroutines for buffers > 2GB.
8012 * fileio.c (a_write, e_write): Modify declaration of arguments and
8013 local variables to support buffers larger than 2GB.
8014 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8015
8016 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8017 argument, local variables, and return value.
8018
8019 * lisp.h: Update prototypes of emacs_write and emacs_read.
8020
8021 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8022
4073e537 80232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8024
1ebfdcb6
PE
8025 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8026
b2ded58d
PE
8027 Fix more problems found by GCC 4.6.0's static checks.
8028
7d66342c
PE
8029 * xdisp.c (vmessage): Use a better test for character truncation.
8030
bbf47d44
PE
8031 * charset.c (load_charset_map): <, not <=, for optimization,
8032 and to avoid potential problems with integer overflow.
9248994d 8033 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8034 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8035 * editfns.c (Fformat): Likewise.
1e69125e 8036 * syntax.c (skip_chars): Likewise.
3befa583 8037
e3019616
PE
8038 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8039 This also lets GCC 4.6.0 generate slightly better loop code.
8040
becfa255
PE
8041 * callint.c (Fcall_interactively): <, not <=, for optimization.
8042 (Fcall_interactively): Count the number of arguments produced,
8043 not the number of arguments given. This is simpler and lets GCC
8044 4.6.0 generate slightly better code.
8045
dae0cd48
PE
8046 * ftfont.c: Distingish more carefully between FcChar8 and char.
8047 The previous code passed unsigned char * to a functions like
8048 strlen and xstrcasecmp that expect char *, which does not
8049 conform to the C standard.
8050 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8051 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8052 char * when the C standard requires it.
8053
76032d70
PE
8054 * keyboard.c (read_char): Remove unused var.
8055
eb3f1cc8
PE
8056 * eval.c: Port to Windows vsnprintf (Bug#8435).
8057 Include <limits.h>.
8058 (SIZE_MAX): Define if the headers do not.
8059 (verror): Do not give up if vsnprintf returns a negative count.
8060 Instead, grow the buffer. This ports to Windows vsnprintf, which
8061 does not conform to C99. Problem reported by Eli Zaretskii.
8062 Also, simplify the allocation scheme, by avoiding the need for
8063 calling realloc, and removing the ALLOCATED variable.
8064
70476b54
PE
8065 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8066
12020a9e
PE
8067 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8068 But keep the doprint source code for now, as we might revamp it
8069 and use it again (Bug#8435).
ea6c7ae6
PE
8070 * lisp.h (doprnt): Remove.
8071 * Makefile.in (base_obj): Remove doprnt.o.
8072 * deps.mk (doprnt.o): Remove.
8073
5fdb398c
PE
8074 error: Print 32- and 64-bit integers portably (Bug#8435).
8075 Without this change, on typical 64-bit hosts error ("...%d...", N)
8076 was used to print both 32- and 64-bit integers N, which relied on
8077 undefined behavior.
61bdb816 8078 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8079 * lisp.h (error, verror): Mark as printf-like functions.
8080 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8081 Report overflow in size calculations when allocating printf buffer.
8082 Do not truncate output string at its first null byte.
8083 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8084 Truncate the output at a character boundary, since vsnprintf does not
8085 do that.
8086 * charset.c (check_iso_charset_parameter): Convert internal
8087 character to string before calling 'error', since %c now has the
8088 printf meaning.
8089 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8090 overflow when computing char to be passed to 'error'. Do not
8091 pass Lisp_Object to 'error'; pass the integer instead.
8092 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8093 formatted with plain %d.
8094
b189fa66
PE
8095 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8096
bff87ef0
PE
8097 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8098
7e2cac20
PE
8099 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8100
ce4d90b5
PE
8101 * xterm.c (x_catch_errors): Remove duplicate declaration.
8102
266c9547
PE
8103 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8104
79c49ad2
PE
8105 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8106
368f4090
JM
81072011-04-10 Jim Meyering <meyering@redhat.com>
8108
8109 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8110 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8111 return ssize_t not "int", and use size_t as the buffer length.
8112 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8113 * gnutls.h: Update declarations.
8114 * process.c (read_process_output): Use ssize_t, to match.
8115 (send_process): Likewise.
8116
a32d4040
CY
81172011-04-09 Chong Yidong <cyd@stupidchicken.com>
8118
8119 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8120
8546720e 81212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8122
04f2d78b
CB
8123 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8124 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8125
8546720e
GM
8126 * xterm.c (handle_one_xevent):
8127 * xmenu.c (create_and_show_popup_menu):
8128 * xselect.c (x_decline_selection_request)
8129 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8130
0a2f5c1a 81312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8132
8133 Fix some uses of `int' instead of EMACS_INT.
8134 * search.c (string_match_1, fast_string_match)
8135 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8136 (scan_buffer, find_next_newline_no_quit)
8137 (find_before_next_newline, search_command, Freplace_match)
8138 (Fmatch_data): Make some `int' variables be EMACS_INT.
8139
8140 * xdisp.c (display_count_lines): 3rd argument and return value now
8141 EMACS_INT. All callers changed.
8142 (pint2hrstr): Last argument is now EMACS_INT.
8143
8144 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8145 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8146 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8147 (decode_coding_utf_16, decode_coding_emacs_mule)
8148 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8149 (decode_coding_ccl, decode_coding_charset)
8150 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8151 (decode_coding_iso_2022, decode_coding_emacs_mule)
8152 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8153 <char_offset, last_offset>: Declare EMACS_INT.
8154 (encode_coding_utf_8, encode_coding_utf_16)
8155 (encode_coding_emacs_mule, encode_invocation_designation)
8156 (encode_designation_at_bol, encode_coding_iso_2022)
8157 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8158 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8159 Declare EMACS_INT.
8160 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8161 (encode_invocation_designation): Last argument P_NCHARS is now
8162 EMACS_INT.
8163 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8164 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8165
8166 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8167 All users changed.
8168
8169 * ccl.c (Fccl_execute_on_string): Declare some variables
8170 EMACS_INT.
8171
8546720e 81722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8173
8174 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8175
4e19a977
CS
81762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8177
8178 * process.c (Fformat_network_address): Doc fix.
8179
87302331
R
81802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8181
ee7683eb 8182 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8183
cbb59342
CY
81842011-04-08 Chong Yidong <cyd@stupidchicken.com>
8185
8186 * keyboard.c (read_char): Call Lisp function help-form-show,
8187 instead of using internal_with_output_to_temp_buffer.
8188 (Qhelp_form_show): New var.
e0d38eeb 8189 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8190
8191 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8192
8193 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8194
e67a13ab
CY
81952011-04-06 Chong Yidong <cyd@stupidchicken.com>
8196
04f2d78b
CB
8197 * process.c (Flist_processes): Remove to Lisp.
8198 (list_processes_1): Delete.
e67a13ab 8199
973f782d
EZ
82002011-04-06 Eli Zaretskii <eliz@gnu.org>
8201
7c106b1e
EZ
8202 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8203
973f782d
EZ
8204 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8205
41cf7d1a 82062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8207
ca23cc88
PE
8208 Fix more problems found by GCC 4.6.0's static checks.
8209
f390e2d5
PE
8210 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8211
42eea0d0
PE
8212 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8213
b69769da 8214 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8215
f9541e84
PE
8216 * xdisp.c (vmessage): Mark as a printf-like function.
8217
13841b55
PE
8218 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8219
c136c10f
PE
8220 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8221
5e2d4a30
PE
8222 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8223 printf-like functions.
8224 (tiff_load): Add casts to remove these marks before passing them
8225 to system-supplied API.
8226
583f48b9
PE
8227 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8228
b25d760e
PE
8229 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8230 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8231 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8232 directly, rather than having caller test rule sign. This avoids
8233 some unnecessary tests.
8234 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8235 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8236 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8237
bc7b6697 8238 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8239 (xfont_open): Avoid unnecessary tests.
bc7b6697 8240
27ccc379
PE
8241 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8242
dcd5c89a
PE
8243 * composite.h, composite.c (composition_gstring_put_cache):
8244 Use EMACS_INT, not int, for length.
8245
b13a45c6
PE
8246 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8247 breaking out part of COMPOSITION_DECODE_RULE.
8248 (COMPOSITION_DECODE_RULE): Use it.
8249 * composite.c (get_composition_id): Remove unused local vars,
8250 by using the new macro.
8251
1e792e4d
PE
8252 * textprop.c (set_text_properties_1): Change while to do-while,
8253 since the condition is always true at first.
8254
dc6c6455 8255 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8256 (interval_deletion_adjustment): Return unsigned value.
8257 All uses changed.
dc6c6455 8258
aba7731a
PE
8259 * process.c (list_processes_1, create_pty, read_process_output):
8260 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8261 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8262 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8263 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8264 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8265
fdfc4bf3
PE
8266 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8267
fca8fe46 8268 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8269 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8270
06a0259a 8271 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8272 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8273 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8274
e7b9e80f
PE
8275 * print.c (print_error_message): Avoid int overflow.
8276
56201685
PE
8277 * font.c (font_list_entities): Redo for clarity,
8278 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8279
78834453 8280 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8281 (font_score): Avoid potential overflow in diff calculation.
78834453 8282
0bc0b309 8283 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8284 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8285
e610eaca
PE
8286 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8287
b895abce
PE
8288 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8289 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8290 can always succeed if overflow has undefined behavior.
8291
1f1d9321 8292 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8293 (wordify): Omit three unnecessary tests.
1f1d9321 8294
c59478bc
PE
8295 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8296 All callers changed. This avoids the need for an unused var.
8297
79b73827
PE
8298 * casefiddle.c (casify_region): Remove var that is set but not used.
8299
a4db5dfe
PE
8300 * dired.c (file_name_completion): Remove var that is set but not used.
8301
43aae36e
PE
8302 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8303
2a47c44d 8304 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8305 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8306
a37c69bf
PE
8307 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8308 Check for integer overflow on size calculations.
8309
328ab8e7
PE
8310 * buffer.c (Fprevious_overlay_change): Remove var that is set
8311 but not used.
8312
e5a2a5cb
PE
8313 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8314 Remove vars that are set but not used.
8d84a6eb 8315 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8316 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8317
a60e5f68
PE
8318 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8319
f661cb61 8320 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8321 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8322
f0397f5a
PE
8323 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8324 that are set but not used.
8325
8664db06 8326 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8327 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8328
6abdaa4a
PE
8329 * xselect.c (x_get_local_selection, x_handle_property_notify):
8330 Remove vars that are set but not used.
8331
0ce7538d 8332 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8333 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8334
9ae848fc
PE
8335 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8336 Remove var that is set but not used.
0b918413
PE
8337 (scroll_bar_windows_size): Now size_t, not int.
8338 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8339 Check for overflow.
9ae848fc 8340
a5a62657
PE
8341 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8342 (map_tty_color) [!defined MSDOS]: Likewise.
8343
5c5cdd39
PE
8344 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8345
66ebf983
PE
8346 * coding.c: Remove vars that are set but not used.
8347 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8348 All callers changed.
8349 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8350 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8351 (decode_coding_charset): Remove vars that are set but not used.
8352
1be4d761
PE
8353 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8354 that is set but not used.
8355
47553fa8
PE
8356 * print.c (print_object): Remove var that is set but not used.
8357
1f7196bf 8358 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8359 The gnulib version avoids calling malloc in the usual case,
8360 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8361 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8362 * filelock.c (current_lock_owner): Likewise.
8363 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8364 * sysdep.c: Include allocator.h, careadlinkat.h.
8365 (emacs_no_realloc_allocator): New static constant.
8366 (emacs_readlink): New function.
fdb61804
PE
8367 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8368 ../lib/careadlinkat.h.
d1fdcab7 8369
f84c17c7
SM
83702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8371
8372 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8373 first non-nil return value).
8374
ef3862ad
JD
83752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8376
8377 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8378 if not defined (Bug#8403).
8379
376a7006
JB
83802011-04-02 Juanma Barranquero <lekktu@gmail.com>
8381
8382 * xdisp.c (display_count_lines): Remove parameter `start',
8383 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8384 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8385 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8386 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8387 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8388 and thereabouts. All callers changed.
8389 (get_per_char_metric): Remove parameter `f', unused since
8390 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8391
6ca3801d
JM
83922011-04-02 Jim Meyering <meyering@redhat.com>
8393
8394 do not dereference NULL upon failed strdup
8395 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8396 (ns_get_family): Likewise.
8397
d8e2b5ba
JB
83982011-04-02 Juanma Barranquero <lekktu@gmail.com>
8399
8400 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8401
8c74fcbd
JD
84022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8403
8404 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8405 later (Bug#8403).
8406
7200d79c
SM
84072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8408
03408648 8409 Add lexical binding.
7200d79c 8410
03408648
SM
8411 * window.c (Ftemp_output_buffer_show): New fun.
8412 (Fsave_window_excursion):
8413 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8414
8415 * lread.c (lisp_file_lexically_bound_p): New function.
8416 (Fload): Bind Qlexical_binding.
8417 (readevalloop): Remove `evalfun' arg.
8418 Bind Qinternal_interpreter_environment.
8419 (Feval_buffer): Bind Qlexical_binding.
8420 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8421 Mark as dynamic.
8422 (syms_of_lread): Declare `lexical-binding'.
8423
8424 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8425
8426 * keyboard.c (eval_dyn): New fun.
8427 (menu_item_eval_property): Use it.
ca105506
SM
8428
8429 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8430
03408648
SM
8431 * fns.c (concat, mapcar1): Accept byte-code-functions.
8432
8433 * eval.c (Fsetq): Handle lexical vars.
8434 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8435 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8436 (FletX, Flet): Obey lexical binding.
8437 (Fcommandp): Handle closures.
8438 (Feval): New `lexical' arg.
8439 (eval_sub): New function extracted from Feval. Use it almost
8440 everywhere where Feval was used. Look up vars in lexical env.
8441 Handle closures.
8442 (Ffunctionp): Move from subr.el.
8443 (Ffuncall): Handle closures.
8444 (apply_lambda): Remove `eval_flags'.
8445 (funcall_lambda): Handle closures and new byte-code-functions.
8446 (Fspecial_variable_p): New function.
8447 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8448 but without exporting it to Lisp.
23aba0ea 8449
23aba0ea 8450 * doc.c (Fdocumentation, store_function_docstring):
03408648 8451 * data.c (Finteractive_form): Handle closures.
23aba0ea 8452
03408648
SM
8453 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8454 interactive spec.
ba83908c 8455
04f2d78b
CB
8456 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8457 New byte-codes.
03408648
SM
8458 (exec_byte_code): New function extracted from Fbyte_code to handle new
8459 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8460
03408648 8461 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8462
03408648 8463 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8464
e2abce01
JB
84652011-03-31 Juanma Barranquero <lekktu@gmail.com>
8466
8467 * xdisp.c (redisplay_internal): Fix prototype.
8468
63696a73 84692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8470
63696a73 8471 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8472 (try_scrolling): Use it when setting scroll_limit.
8473 Limit scrolling to 100 screen lines.
63696a73
EZ
8474 (redisplay_window): Even when falling back on "recentering",
8475 position point in the window according to scroll-conservatively,
8476 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8477
8478 (try_scrolling): When point is above the window, allow searching
8479 as far as scroll_max, or one screenful, to compute vertical
8480 distance from PT to the scroll margin position. This prevents
8481 try_scrolling from unnecessarily failing when
8482 scroll-conservatively is set to a value slightly larger than the
8483 window height. Clean up the case of PT below the margin at bottom
8484 of window: scroll_max can no longer be INT_MAX. When aggressive
8485 scrolling is in use, don't let point enter the opposite scroll
8486 margin as result of the scroll.
8487 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8488 threshold of 100 lines for never-recentering scrolling.
8489
e4cc2dfc
JB
84902011-03-31 Juanma Barranquero <lekktu@gmail.com>
8491
8492 * dispextern.h (move_it_by_lines):
8493 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8494 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8495 (message_log_check_duplicate): Remove parameters `prev_bol' and
8496 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8497 (redisplay_internal): Remove parameter `preserve_echo_area',
8498 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8499
8500 * indent.c (Fvertical_motion):
8501 * window.c (window_scroll_pixel_based, Frecenter):
8502 Don't pass `need_y_p' to `move_it_by_lines'.
8503
1c470562
SM
85042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8505
44f230aa
SM
8506 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8507 steal a few bits to be more compact.
8508 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8509 Remove unneeded casts.
8510
1c470562
SM
8511 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8512
888adce9
ZK
85132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8514
8515 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8516 binding" message (bug#7967).
8517
f838ed7b
PE
85182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8519
77861b95
PE
8520 Fix more problems found by GCC 4.6.0's static checks.
8521
de6dbc14
PE
8522 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8523 Remove unused local var.
8524
f838ed7b
PE
8525 * editfns.c (Fmessage_box): Remove unused local var.
8526
792c7b2b
PE
8527 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8528 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8529 Omit unused local vars.
c499e557 8530 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8531 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8532 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8533 Omit unused local var.
8534
ba0165e1
PE
8535 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8536 Don't assume string length fits in int.
32ad8845 8537 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8538 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8539
3c59b4c9
PE
8540 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8541 instead of alloca (Bug#8344).
8542
a3eed478 8543 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8544 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8545
eb4d412d
PE
8546 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8547
1658b401
PE
8548 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8549 concerns.
8550
8551 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8552
8553 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8554
9a2c6e05
PE
8555 * keyboard.c (syms_of_keyboard): Use the same style as later
8556 in this function when indexing through an array. This also
8557 works around GCC bug 48267.
8558
03d0a109
PE
8559 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8560
44f730c8
PE
8561 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8562
fe75f926
PE
8563 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8564 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8565
ffa8c828
PE
8566 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8567 This avoids undefined behavior on integer overflow, and is a bit
8568 more convenient anyway since it is compared to a size_t variable.
8569
c5101a77
PE
8570 Variadic C functions now count arguments with size_t, not int.
8571 This avoids an unnecessary limitation on 64-bit machines, which
8572 caused (substring ...) to crash on large vectors (Bug#8344).
8573 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8574 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8575 All variadic functions and their callers changed accordingly.
c5101a77
PE
8576 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8577 * data.c (arith_driver, float_arith_driver): Likewise.
8578 * editfns.c (general_insert_function): Likewise.
8579 * eval.c (struct backtrace.nargs, interactive_p)
8580 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8581 (funcall_lambda, mark_backtrace): Likewise.
8582 * fns.c (concat): Likewise.
8583 * frame.c (x_set_frame_parameters): Likewise.
8584 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8585 0 if not found, not -1. All callers changed.
8586
dd3f25f7
PE
8587 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8588 (stack_copy_size): Now size_t, not int.
8589 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8590
461c2ab9
JB
85912011-03-28 Juanma Barranquero <lekktu@gmail.com>
8592
8593 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8594 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8595 All callers changed.
8596
8597 * lisp.h (multibyte_char_to_unibyte):
8598 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8599 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8600 * character.h (CHAR_TO_BYTE8):
8601 * cmds.c (internal_self_insert):
8602 * editfns.c (general_insert_function):
8603 * keymap.c (push_key_description):
8604 * search.c (Freplace_match):
8605 * xdisp.c (message_dolog, set_message_1): All callers changed.
8606
f6d62986
SM
86072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8608
8609 * keyboard.c (safe_run_hook_funcall): New function.
8610 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8611 don't set the hook to nil, but remove the offending function instead.
8612 (Qcommand_hook_internal): Remove, unused.
8613 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8614 Vcommand_hook_internal.
8615
8616 * eval.c (enum run_hooks_condition): Remove.
8617 (funcall_nil, funcall_not): New functions.
8618 (run_hook_with_args): Call each function through a `funcall' argument.
8619 Remove `cond' argument, now redundant.
8620 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8621 (Frun_hook_with_args_until_failure): Adjust accordingly.
8622 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8623
1db5b1ad
JB
86242011-03-28 Juanma Barranquero <lekktu@gmail.com>
8625
8626 * dispextern.h (string_buffer_position): Remove declaration.
8627
8628 * print.c (strout): Remove parameter `multibyte', unused since
8629 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8630
8631 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8632 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8633 All callers changed.
8634
8635 * w32.c (_wsa_errlist): Use braces for struct initializers.
8636
8637 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8638 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8639 All callers changed.
8640 (string_buffer_position): Likewise. Also, make static (it's never
8641 used outside xdisp.c).
8642 (cursor_row_p): Remove parameter `w', unused since
8643 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8644 (decode_mode_spec): Remove parameter `precision', introduced during
8645 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8646 All callers changed.
8647
5ffb62aa
JD
86482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8649
8650 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8651
461c2ab9 86522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8653
8654 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8655 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8656 (ns_update_auto_hide_menu_bar): New functions.
8657 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8658 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8659 ns_constrain_all_frames.
8660 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8661 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8662
5c380ffb
JD
86632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8664
8665 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8666
9af30bdf
GM
86672011-03-27 Glenn Morris <rgm@gnu.org>
8668
8669 * syssignal.h: Replace RETSIGTYPE with void.
8670 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8671 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8672 Replace SIGTYPE with void everywhere.
8673 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8674 * s/template.h (SIGTYPE): Remove commented out definition.
8675
e2abce01
JB
86762011-03-26 Eli Zaretskii <eliz@gnu.org>
8677
8678 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8679 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8680
f868cd8a
JB
86812011-03-26 Juanma Barranquero <lekktu@gmail.com>
8682
59eb0929
JB
8683 * w32.c (read_unc_volume): Use parameter `henum', instead of
8684 global variable `wget_enum_handle'.
8685
8686 * keymap.c (describe_vector): Remove parameters `indices' and
8687 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8688 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8689
f868cd8a
JB
8690 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8691
8692 * keyboard.c (timer_check): Remove parameter `do_it_now',
8693 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8694 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8695 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8696
8697 * keyboard.c (read_char):
8698 * w32menu.c (w32_menu_display_help):
8699 * xmenu.c (show_help_event, menu_help_callback):
8700 Adjust calls to `show_help_echo'.
8701
8702 * gtkutil.c (xg_maybe_add_timer):
8703 * keyboard.c (readable_events):
8704 * process.c (wait_reading_process_output):
8705 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8706
8707 * insdel.c (adjust_markers_gap_motion):
8708 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8709 (gap_left, gap_right): Don't call it.
8710
2ecf6fdb
CY
87112011-03-25 Chong Yidong <cyd@stupidchicken.com>
8712
8713 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8714 incurred during fontification.
8715
6b1f9ba4
JB
87162011-03-25 Juanma Barranquero <lekktu@gmail.com>
8717
8718 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8719 (DEFVAR_PER_BUFFER): Don't pass it.
8720
8721 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8722 (scrolling_window): Don't pass it.
8723
0f4a96b5
JB
87242011-03-25 Juanma Barranquero <lekktu@gmail.com>
8725
8726 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8727
8728 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8729 and `suffix'.
8730 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8731 of variables specific to SELinux and computation of `encoded_absname'.
8732
8733 * image.c (XPutPixel): Remove unused variable `height'.
8734
8735 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8736
8737 * unexw32.c (get_section_info): Remove unused variable `section'.
8738
8739 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8740 (system_process_attributes): Remove unused variable `sess'.
8741 (sys_read): Remove unused variable `err'.
8742
8743 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8744 (w32_wnd_proc): Remove unused variable `isdead'.
8745 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8746 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8747 (x_create_tip_frame): Remove unused variable `tem'.
8748
8749 * w32inevt.c (w32_console_read_socket):
8750 Remove unused variable `no_events'.
8751
8752 * w32term.c (x_draw_composite_glyph_string_foreground):
8753 Remove unused variable `width'.
8754
1149507c
JB
87552011-03-24 Juanma Barranquero <lekktu@gmail.com>
8756
8757 * w32term.c (x_set_glyph_string_clipping):
8758 Don't pass uninitialized region to CombineRgn.
8759
9c88f339
JB
87602011-03-23 Juanma Barranquero <lekktu@gmail.com>
8761
8762 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8763 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8764 (Fx_close_connection): Remove unused variable `i'.
8765
8766 * w32font.c (w32font_draw): Return number of glyphs.
8767 (w32font_open_internal): Remove unused variable `i'.
8768 (w32font_driver): Add missing initializer.
8769
8770 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8771 (fill_in_menu): Remove unused variable `items_added'.
8772
8773 * w32term.c (last_mouse_press_frame): Remove static global variable.
8774 (w32_clip_to_row): Remove unused variable `f'.
8775 (x_delete_terminal): Remove unused variable `i'.
8776
8777 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8778 (NOTHING): Remove unused static global variable.
8779 (uniscribe_check_otf): Remove unused variable `table'.
8780 (uniscribe_font_driver): Add missing initializers.
8781
dee091a3
JD
87822011-03-23 Julien Danjou <julien@danjou.info>
8783
8784 * term.c (Fsuspend_tty, Fresume_tty):
8785 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8786 * window.c (temp_output_buffer_show):
8787 * insdel.c (signal_before_change):
8788 * frame.c (Fhandle_switch_frame):
8789 * fileio.c (Fdo_auto_save):
8790 * emacs.c (Fkill_emacs):
8791 * editfns.c (save_excursion_restore):
8792 * cmds.c (internal_self_insert):
8793 * callint.c (Fcall_interactively):
8794 * buffer.c (Fkill_all_local_variables):
8795 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8796 Use Frun_hooks.
0f4a96b5 8797 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8798 unconditionally since it does the check itself.
dee091a3 8799
2c520ab5 88002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8801
c9c49752
PE
8802 Fix more problems found by GCC 4.5.2's static checks.
8803
8abc3f12
PE
8804 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8805 the first time through the loop, since we know p0 < p1 then.
8806 This also avoids a gcc -Wstrict-overflow warning.
8807
a2d26660
PE
8808 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8809 leading to a memory leak, possible in functions like
8810 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8811 of objects (Bug#8318).
a2d26660 8812
916c72e9
PE
8813 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8814 that could (at least in theory) be that large.
8815
19ab8a18
PE
8816 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8817 This is less likely to overflow, and avoids undefined behavior if
8818 overflow does occur. All callers changed. Use strtoul to scan
8819 for the unsigned long integer.
b7cbbd6f
PE
8820 (pint2hrstr): Simplify and tune code slightly.
8821 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8822
f0641eff
PE
8823 * scroll.c (do_scrolling): Work around GCC bug 48228.
8824 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8825
7f650bb9
PE
8826 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8827 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8828 (validate_x_resource_name): Simplify count usage.
8829 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8830
37dd57d1
PE
8831 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8832 fail (Bug#8306).
81e56e61 8833
699979fc 8834 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8835
401bf9b4
PE
8836 * process.c (Fmake_network_process): Use socklen_t, not int,
8837 where POSIX says socklen_t is required in portable programs.
8838 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8839 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8840 (Fmake_network_process, server_accept_connection):
8841 (wait_reading_process_output, read_process_output):
8842 Likewise.
8843
b93aacde
PE
8844 * process.c: Rename or move locals to avoid shadowing.
8845 (list_processes_1, Fmake_network_process):
8846 (read_process_output_error_handler, exec_sentinel_error_handler):
8847 Rename or move locals.
4dc343ee 8848 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8849 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8850 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8851 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8852 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8853
af8a867c 8854 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8855 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8856 Include tparam.h instead, since it declares them.
af8a867c
PE
8857 * cm.h (PC): Remove extern decl; tparam.h now does this.
8858 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8859 * terminfo.c: Include tparam.h, to check interfaces.
8860 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8861 (tparam): Adjust signature to match interface in tparam.h;
8862 this removes some undefined behavior. Check that outstring and len
8863 are zero, which they always are with Emacs.
8864 * tparam.h (PC, BC, UP): New extern decls.
8865
0248044d 8866 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8867 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8868
8ff096c1 8869 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8870 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8871 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8872 (ftfont_list): Remove unused local.
49eaafba
PE
8873 (get_adstyle_property, ftfont_pattern_entity):
8874 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8875 Rename locals to avoid shadowing.
8ff096c1 8876
e2be39f6
PE
8877 * xfont.c (xfont_list_family): Mark var as initialized.
8878
c9735e30
PE
8879 * xml.c (make_dom): Now static.
8880
8f5201ae
PE
8881 * composite.c (composition_compute_stop_pos): Rename local to
8882 avoid shadowing.
b246f932
PE
8883 (composition_reseat_it): Remove unused locals.
8884 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8885 (composition_update_it): Mark var as initialized.
11b61122
PE
8886 (find_automatic_composition): Mark vars as initialized,
8887 with a FIXME (Bug#8290).
8f5201ae 8888
760fbc2c
PE
8889 character.h: Rename locals to avoid shadowing.
8890 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8891 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8892 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8893 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8894 to avoid shadowing.
8895
ff08eb85
PE
8896 * textprop.c (property_change_between_p): Remove; unused.
8897
fc7bf025
PE
8898 * intervals.c (interval_start_pos): Now static.
8899
235d7abc
PE
8900 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8901
44f230aa
SM
8902 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8903 Rename locals to avoid shadowing.
3e7d6594 8904
50060332
PE
8905 * sound.c (wav_play, au_play, Fplay_sound_internal):
8906 Fix pointer signedness.
d01f234b 8907 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8908 (wav_play): Initialize a variable to 0, to prevent undefined
8909 behavior (Bug#8278).
50060332 8910
c4fc4e30
PE
8911 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8912
918436ed
PE
8913 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8914
c939f91b
PE
8915 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8916 clobbering (Bug#8298).
b9c7f648
PE
8917 * sysdep.c (sys_subshell): Likewise.
8918 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8919
6bd8c144
PE
8920 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8921 This should get cleaned up, so that child_setup has the
8922 same signature on all platforms.
8923
7710357c 8924 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8925 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8926
c59da222
CY
89272011-03-22 Chong Yidong <cyd@stupidchicken.com>
8928
8929 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8930 not to be necessary, and produces flickering.
8931
66b87493
GM
89322011-03-20 Glenn Morris <rgm@gnu.org>
8933
8934 * config.in: Remove file.
8935
45b6f6d5
JB
89362011-03-20 Juanma Barranquero <lekktu@gmail.com>
8937
8938 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8939 are now in src/globals.h.
8940 (syms_of_minibuf): Remove spurious & from previous change.
8941
cd394be1 89422011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8943
8944 * minibuf.c (completing-read-function): New variable.
8945 (completing-read-default): Rename from completing-read.
8946 (completing-read): Call completing-read-function.
8947
b14e3e21
CY
89482011-03-19 Juanma Barranquero <lekktu@gmail.com>
8949
8950 * xfaces.c (Fx_load_color_file):
8951 Read color file from absolute filename (bug#8250).
8952
f2b726e6
JB
89532011-03-19 Juanma Barranquero <lekktu@gmail.com>
8954
8955 * makefile.w32-in: Update dependencies.
8956
09f6ff02
EZ
89572011-03-17 Eli Zaretskii <eliz@gnu.org>
8958
8959 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8960
29a6015a
PE
89612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8962
a3a6c54e
PE
8963 Fix more problems found by GCC 4.5.2's static checks.
8964
b766f867
PE
8965 * process.c (make_serial_process_unwind, send_process_trap):
8966 (sigchld_handler): Now static.
8967
be02381c
PE
8968 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8969 That way, the code declares only the vars that it needs.
8970 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8971 * s/cygwin.h (PTY_ITERATION): Likewise.
8972 * s/darwin.h (PTY_ITERATION): Likewise.
8973 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8974
57048744
PE
8975 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8976 * process.c (allocate_pty): Don't declare stb unless it's needed.
8977
7914961c 8978 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8979 (CONSTANTLIM): Remove; unused.
8980 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8981 Define only if needed.
7914961c 8982
b3967b18
PE
8983 * unexelf.c (unexec): Name an expression,
8984 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8985 Use a different way to cause a compilation error if anyone uses
8986 n rather than nn, a way that does not involve shadowing.
73366a00 8987 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8988
29a6015a
PE
8989 * deps.mk (unexalpha.o): Remove; unused.
8990
43cfc33e 8991 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8992 * unexec.h: New file.
ce701a33
PE
8993 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8994 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8995 Depend on unexec.h.
8996 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8997 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8998 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8999 Change as necessary to match prototype in unexec.h.
ce701a33 9000
01f44d5a
PE
9001 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9002 shadowing.
4f63c6bb 9003 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9004
a6670b0b
PE
9005 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9006 Rename locals to avoid shadowing.
9007
cef2010d 9008 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9009 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9010
d4d7173a
PE
9011 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9012
f08b802a
PE
9013 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9014 warning when compiling print.c.
9015
3ddb0639
PE
9016 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9017 instead of using an uninitialized var.
5ad03b97 9018 (font_sort_entities): Mark var as initialized.
3ddb0639 9019
170a2692
PE
9020 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9021
e663c700
PE
9022 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9023 pointers to constants.
89bc529a 9024 (font_parse_fcname): Remove unused vars.
7b81e2d0 9025 (font_delete_unmatched): Now static.
ea838e10 9026 (font_get_spec): Remove; unused.
13a547c6
PE
9027 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9028 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9029 Rename or move locals to avoid shadowing.
e663c700 9030
2a80c887 9031 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9032 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9033
1384fa33 9034 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9035 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9036
8b2c52e9
PE
9037 * alloc.c (mark_backtrace): Move decl from here ...
9038 * lisp.h: ... to here, so that it can be checked.
9039
475545b5 9040 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9041 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9042 (lisp_indirect_variable): Name an expression,
9043 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9044 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9045
b1349114 9046 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9047 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9048 Use const pointer when appropriate.
b1349114 9049
a2928364
PE
9050 * lisp.h (get_system_name, get_operating_system_release):
9051 Move decls here, to check interfaces.
9052 * process.c (get_operating_system_release): Move decl to lisp.h.
9053 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9054 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9055 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9056 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9057 (Fformat_time_string, Fencode_time, Finsert_char):
9058 (Ftranslate_region_internal, Fformat):
9059 Rename or remove local vars to avoid shadowing.
9710023e 9060 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9061
a415e694
PE
9062 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9063 avoid shadowing.
9064
8ef4622d
PE
9065 * lisp.h (eassert): Check that the argument compiles, even if
9066 ENABLE_CHECKING is not defined.
9067
946f9a5b
PE
9068 * data.c (Findirect_variable): Name an expression, to avoid
9069 gcc -Wbad-function-cast warning.
112396d6 9070 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9071 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9072 (Fmake_variable_buffer_local, Fmake_local_variable):
9073 Mark variables as initialized.
52746918 9074 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9075
e5aab7e7 9076 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9077 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9078 Rename locals to avoid shadowing.
dff45157
PE
9079 (mark_stack): Move local variables into the #ifdef region where
9080 they're used.
7bc26fdb
PE
9081 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9082 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9083 needed otherwise.
9084 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9085 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9086 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9087
e5aab7e7
PE
9088 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9089 avoids undefined behavior in theory.
9090
4da60324
PE
9091 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9092
88043301
PE
9093 Use functions, not macros, for up- and down-casing (Bug#8254).
9094 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9095 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9096 to use the following functions instead of these macros.
9097 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9098 EMACS_INT, since callers assume the returned value fits in int.
9099 (upcase1): Likewise, for UPCASE_TABLE.
9100 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9101 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9102 the race-condition problem in the old DOWNCASE.
88043301 9103
19ed5445
PE
9104 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9105 Rename locals to avoid shadowing.
9106 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9107 (regex_compile, re_search_2, re_match_2_internal):
9108 Remove unused local vars.
952db0d7
PE
9109 (FREE_VAR): Rewrite so as not to use empty "else",
9110 which gcc can warn about.
da053e48 9111 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9112 (RETALLOC_IF): Define only if needed.
9113 (WORDCHAR_P): Likewise. This one is never needed, but is used
9114 only in a comment talking about a compiler bug, so put inside
9115 the #if 0 of that comment.
9116 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9117 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9118 Remove; unused.
19ed5445 9119
1f3561e4 9120 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9121 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9122 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9123
ded6f8f7
PE
9124 * search.c (simple_search): Remove unused var.
9125
dbd37a95
PE
9126 * dired.c (compile_pattern): Move decl from here ...
9127 * lisp.h: ... to here, so that it can be checked.
9128 (struct re_registers): New forward decl.
9129
7e47afad
PE
9130 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9131
85f24f61
PE
9132 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9133 All uses changed.
9134 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9135 Rename locals to avoid shadowing.
5671df8f 9136 (Fvertical_motion): Mark locals as initialized.
85f24f61 9137
181aa2be 9138 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9139 (casify_region): Mark local as initialized.
181aa2be 9140
930d429c
PE
9141 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9142
7082eac6
PE
9143 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9144 New macros, so that the caller can use some names other than
9145 gcpro1, gcpro2, etc.
9146 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9147 of the new macros.
9148 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9149 argument, for consistency with GCPRO2_VAR, etc: it is now the
9150 prefix of the variable, not the variable itself. All uses
9151 changed.
38b2c076
PE
9152 * dired.c (directory_files_internal, file_name_completion):
9153 Rename locals to avoid shadowing.
9154
15206ed9
PE
9155 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9156 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9157 dired.c's scmp function, had undefined behavior.
9158 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9159 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9160 * buffer.h: ... to here, because these macros use current_buffer,
9161 and the new implementation with inline functions needs to have
9162 current_buffer in scope now, rather than later when the macros
9163 are used.
9164 (downcase, upcase1): New static inline functions.
9165 (DOWNCASE, UPCASE1): Reimplement using these functions.
9166 This avoids undefined behavior in expressions like
9167 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9168 from race conditions in accessing the global variables
9169 case_temp1 and case_temp2.
9170 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9171 * lisp.h (case_temp1, case_temp2): Remove their decls.
9172 * character.h (ASCII_CHAR_P): Move from here ...
9173 * lisp.h: ... to here, so that the inline functions mentioned
9174 above can use them.
9175
4a6bea26
PE
9176 * dired.c (directory_files_internal_unwind): Now static.
9177
f14b7e14
PE
9178 * fileio.c (file_name_as_directory, directory_file_name):
9179 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9180 Now static.
2893f146
PE
9181 (file_name_as_directory): Use const pointers when appropriate.
9182 (Fexpand_file_name): Likewise. In particular, newdir might
9183 point at constant storage, so make it a const pointer.
fd4ead52 9184 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9185 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9186 signedness issues.
f839df0c
PE
9187 (Fset_file_times, Finsert_file_contents, auto_save_error):
9188 Rename locals to avoid shadowing.
f14b7e14 9189
5716756e 9190 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9191 (Ftry_completion, Fall_completions): Rename or remove locals
9192 to avoid shadowing.
5716756e 9193
b4c3046a
PE
9194 * marker.c (bytepos_to_charpos): Remove; unused.
9195
b45db522
PE
9196 * lisp.h (verify_bytepos, count_markers): New decls,
9197 so that gcc does not warn that these functions aren't declared.
9198
85876d07
PE
9199 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9200 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9201 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9202 (copy_text): Remove unused local var.
85876d07 9203
03d78a21 9204 * filelock.c (within_one_second): Now static.
b3dd38ab 9205 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9206
5df8f01b
PE
9207 * buffer.c (fix_overlays_before): Mark locals as initialized.
9208 (fix_start_end_in_overlays): Likewise. This function should be
9209 simplified by using pointers-to-pointers, but that's a different
9210 matter.
b1d876f1 9211 (switch_to_buffer_1): Now static.
8f54f30a
PE
9212 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9213 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9214
a70072c9 9215 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9216 Fix pointer signedness issue.
edced198
PE
9217 (sys_subshell): Mark local as volatile if checking for lint,
9218 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9219 (MAXPATHLEN): Define only if needed.
a70072c9 9220
a0977c44
PE
9221 * process.c (serial_open, serial_configure): Move decls from here ...
9222 * systty.h: ... to here, so that they can be checked.
9223
a884fdcc
PE
9224 * fns.c (get_random, seed_random): Move extern decls from here ...
9225 * lisp.h: ... to here, so that they can be checked.
9226
604efe86 9227 * sysdep.c (reset_io): Now static.
b8950c94 9228 (wait_for_termination_signal): Remove; unused.
604efe86 9229
38fc62d9
PE
9230 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9231 (copy_keymap_item, append_key, push_text_char_description):
9232 Now static.
1004a21a 9233 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9234 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9235 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9236 (describe_map_tree):
9237 Rename locals to avoid shadowing.
38fc62d9 9238
2f2650da
PE
9239 * keyboard.c: Declare functions static if they are not used elsewhere.
9240 (echo_char, echo_dash, cmd_error, top_level_2):
9241 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9242 (read_char, kbd_buffer_get_event, make_lispy_position):
9243 (make_lispy_event, make_lispy_movement, apply_modifiers):
9244 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9245 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9246 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9247 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9248 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9249
a053e86c 9250 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9251 (mark_kboards): Move decl here ...
9252 * alloc.c (mark_kboards): ... from here.
a053e86c 9253
4752793e
PE
9254 * lisp.h (force_auto_save_soon): New decl.
9255
74f10ca7 9256 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9257 (DEFINE_DUMMY_FUNCTION): New macro.
9258 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9259 Use it.
c03cd23f
PE
9260 (main): Add casts to avoid warnings
9261 if GCC considers string literals to be constants.
74f10ca7 9262
022e70d4
PE
9263 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9264
59d6fe83
PE
9265 * dbusbind.c: Pointer signedness fixes.
9266 (xd_signature, xd_append_arg, xd_initialize):
9267 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9268 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9269 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9270 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9271
78320123
PE
9272 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9273 if GCC considers string literals to be constants.
49cebcca 9274 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9275
35ac2a97
SM
92762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9277
fb103ca9
SM
9278 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9279 (print_preprocess, print_object): New macro to fix last change.
9280
35ac2a97
SM
9281 * print.c (print_preprocess): Don't forget font objects.
9282
62973b41
JB
92832011-03-16 Juanma Barranquero <lekktu@gmail.com>
9284
9285 * emacs.c (USAGE3): Doc fixes.
9286
0e48bb22
AS
92872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9288
9289 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9290 structure.
9291
7684e57b
JB
92922011-03-14 Juanma Barranquero <lekktu@gmail.com>
9293
9294 * lisp.h (VWindow_system, Qfile_name_history):
9295 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9296 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9297 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9298
9299 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9300 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9301
9302 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9303 * w32console.c (detect_input_pending, read_input_pending)
9304 (encode_terminal_code):
9305 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9306 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9307 (w32_system_caret_y, Qfile_name_history):
9308 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9309 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9310 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9311 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9312 * w32proc.c (Qlocal, report_file_error):
9313 * w32term.c (Vwindow_system, updating_frame):
9314 * w32uniscribe.c (initialized, uniscribe_font_driver):
9315 Remove unneeded extern declarations.
9316
2aa46d6c
CY
93172011-03-14 Chong Yidong <cyd@stupidchicken.com>
9318
c96bbc66 9319 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9320
cffc6f3b
CY
93212011-03-13 Chong Yidong <cyd@stupidchicken.com>
9322
9323 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9324 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9325 These macros can no longer be used for assignment.
9326
44f230aa
SM
9327 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9328 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9329 (record_buffer_markers, fetch_buffer_markers): New functions for
9330 recording and fetching special buffer markers.
9331 (set_buffer_internal_1, set_buffer_temp): Use them.
9332
9333 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9334
9335 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9336
9337 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9338 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9339
9340 * xdisp.c (hscroll_window_tree):
9341 (reconsider_clip_changes): Use PT instead of BUF_PT.
9342
d251f04b
EZ
93432011-03-13 Eli Zaretskii <eliz@gnu.org>
9344
9345 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9346 $(EMACS_ROOT)/lib/intprops.h.
9347
f0c77cd1
PE
93482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9349
3eca4629
PE
9350 Fix more problems found by GCC 4.5.2's static checks.
9351
7c86ee98
PE
9352 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9353 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9354 (xg_free_frame_widgets): Make it clear that a local variable is
9355 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9356 (gdk_window_get_screen): Make it clear that this macro is needed
9357 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9358 (int_gtk_range_get_value): New function, which avoids a diagnostic
9359 from gcc -Wbad-function-cast.
9360 (xg_set_toolkit_scroll_bar_thumb): Use it.
9361 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9362 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9363 (get_utf8_string, xg_get_file_with_chooser):
9364 Rename locals to avoid shadowing.
9365 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9366
41729b81
PE
9367 * xgselect.c (xg_select): Remove unused var.
9368
f0c77cd1
PE
9369 * image.c (four_corners_best): Mark locals as initialized.
9370 (gif_load): Initialize transparent_p to zero (Bug#8238).
9371 Mark another local as initialized.
ec6cf4c6 9372 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9373
ce0ad53d 9374 * image.c (clear_image_cache): Now static.
d5d5a617 9375 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9376 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9377 (x_edge_detection): Remove unnecessary cast that
9378 gcc -Wbad-function-cast diagnoses.
2037898d 9379 (gif_load): Fix pointer signedness.
6ae141d6
PE
9380 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9381 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9382
33383987 93832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9384
d32df629
PE
9385 Improve quality of tests for time stamp overflow.
9386 For example, without this patch (encode-time 0 0 0 1 1
9387 1152921504606846976) returns the obviously-bogus value (-948597
9388 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9389 reports time overflow. See
9390 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9391 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9392 * editfns.c: Include limits.h and intprops.h.
9393 (TIME_T_MIN, TIME_T_MAX): New macros.
9394 (time_overflow): Move earlier, to before first use.
9395 (hi_time, lo_time): New functions, for an accurate test for
9396 out-of-range times.
9397 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9398 (Fget_internal_run_time): Don't assume time_t fits in int.
9399 (make_time): Use list2 instead of Fcons twice.
9400 (Fdecode_time): More accurate test for out-of-range times.
9401 (check_tm_member): New function.
9402 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9403 (lisp_time_argument): Don't rely on undefined left-shift and
9404 right-shift behavior when checking for time stamp overflow.
8be6f318 9405
fe31d94c
PE
9406 * editfns.c (time_overflow): New function, refactoring common code.
9407 (Fformat_time_string, Fdecode_time, Fencode_time):
9408 (Fcurrent_time_string): Use it.
9409
8be6f318
PE
9410 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9411 * dired.c (make_time): Move to ...
9412 * editfns.c (make_time): ... here.
9413 * systime.h: Note the move.
9414
09d9db2c 94152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9416
126bc0dc
YM
9417 * fringe.c (update_window_fringes): Remove unused variables.
9418
c47cbdfd
YM
9419 * unexmacosx.c (copy_data_segment): Also copy __got section.
9420 (Bug#8223)
9421
7ac80be9
EZ
94222011-03-12 Eli Zaretskii <eliz@gnu.org>
9423
c96bbc66 9424 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9425 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9426 Constify `char *' arguments and their references according to
9427 prototypes in tparam.h.
9428
ecb0f94d 9429 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9430
7ac80be9
EZ
9431 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9432 Adapt all references accordingly.
9433
9434 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9435
ef1fd07e
TT
94362011-03-11 Tom Tromey <tromey@redhat.com>
9437
9438 * buffer.c (syms_of_buffer): Remove obsolete comment.
9439
7ef4b50c
EZ
94402011-03-11 Eli Zaretskii <eliz@gnu.org>
9441
9442 * termhooks.h (encode_terminal_code): Declare prototype.
9443
9444 * msdos.c (encode_terminal_code): Don't declare prototype.
9445
9446 * term.c (encode_terminal_code): Now external again, used by
9447 w32console.c and msdos.c.
9448
44f230aa
SM
9449 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9450 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9451
4b1ec863 94522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9453
1714f52b 9454 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9455
4b1ec863
PE
9456 * fringe.c (update_window_fringes): Mark locals as initialized
9457 (Bug#8227).
9458 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9459
524c7aa6
PE
9460 * alloc.c (mark_fringe_data): Move decl from here ...
9461 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9462 to check its interface.
9463 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9464
a5c0af81 9465 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9466 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9467 (fontset_font): Mark local as initialized.
a9a06e0b 9468 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9469
b4716021
PE
9470 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9471
811e9bac 9472 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9473 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9474 (x_own_selection, Fx_disown_selection_internal): Rename locals
9475 to avoid shadowing.
9476 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9477
7e3ab302
PE
9478 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9479 so that the caller can use some name other than gcpro1.
9480 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9481 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9482 (Fx_backspace_delete_keys_p):
9483 Use them to avoid shadowing, and rename vars to avoid shadowing.
9484 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9485 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9486 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9487 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9488 Remove unused locals.
7e3ab302
PE
9489 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9490 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9491 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9492 macros.
f78faa98 9493
e2b13473
PE
9494 * xterm.h (x_mouse_leave): New decl.
9495
77f23912
PE
9496 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9497 Remove unused functions.
cdf4ba58
PE
9498 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9499 (x_calc_absolute_position): Now static.
7411c686 9500 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9501 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9502 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9503 unless they are used.
38d0b34a
PE
9504 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9505 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9506 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9507 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9508 (x_error_catcher, x_connection_closed, x_error_handler):
9509 (x_error_quitter, xembed_send_message, x_iconify_frame):
9510 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9511 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9512 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9513
44f230aa
SM
9514 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9515 Rename or move locals to avoid shadowing.
6b463e58 9516 (tty_defined_color, merge_face_heights): Now static.
5967d051 9517 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9518 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9519 does not deduce is never used uninitialized.
73719eba
PE
9520 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9521 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9522
426994c3 9523 * terminal.c (store_terminal_param): Now static.
5489860b 9524
032f1620 9525 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9526 (set_frame_menubar): Remove unused local.
d4323972 9527 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9528 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9529 since they might point to immutable storage.
281585b0
PE
9530 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9531 since it's unused otherwise.
032f1620 9532
367c19e5 9533 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9534 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9535 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9536 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9537 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9538 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9539 does not deduce are never used uninitialized.
70739cbe 9540
07b48fa9
PE
9541 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9542
8868a238 9543 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9544 * window.c (window_loop, size_window):
9545 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9546
7e5cf297 9547 * window.c (display_buffer): Now static.
d6550a9f
PE
9548 (size_window): Mark variables that gcc -Wuninitialized
9549 does not deduce are never used uninitialized.
a586633d
PE
9550 * window.h (check_all_windows): New decl, to forestall
9551 gcc -Wmissing-prototypes diagnostic.
5b555da1 9552 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9553
f6095868
PE
9554 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9555 shadowing.
9556 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9557 Include <limits.h>.
9558 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9559 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9560 (load_charset_map): Mark variables that gcc -Wuninitialized
9561 does not deduce are never used uninitialized.
53df7c11 9562 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9563
f38b440c
PE
9564 * coding.c (coding_set_source, coding_set_destination):
9565 Use "else { /* comment */ }" rather than "else /* comment */;"
9566 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9567 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9568 a block, when the outer 'i' will do.
9569 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9570 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9571 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9572 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9573 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9574 Rename locals to avoid shadowing.
9575 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9576 * coding.c (emacs_mule_char, encode_invocation_designation):
9577 Now static, since they're not used elsewhere.
413bb2db 9578 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9579 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9580 (decode_coding_emacs_mule): Mark variables that gcc
9581 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9582 (detect_coding_iso_2022): Initialize a local variable that might
9583 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9584 this initialization is needed. (Bug#8211)
5f58e762
PE
9585 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9586 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9587 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9588 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9589 Remove unused macros.
f38b440c 9590
232b38b9 9591 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9592 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9593 * character.c (string_count_byte8): Likewise.
232b38b9 9594
fb90da1b
PE
9595 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9596 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9597
fb93dbc2
PE
9598 * chartab.c (copy_sub_char_table): Now static, since it's not used
9599 elsewhere.
5c156ace
PE
9600 (sub_char_table_ref_and_range, char_table_ref_and_range):
9601 Rename locals to avoid shadowing.
bbcd0949 9602 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9603
7d3b3862 9604 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9605 (BIDI_BOB): Remove unused macro.
7d3b3862 9606
6be7d3da
PE
9607 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9608 deduce are never used uninitialized.
c2ed9c8b 9609 * term.c (encode_terminal_code): Likewise.
6be7d3da 9610
75f8807f 9611 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9612
50938595
PE
9613 * tparam.h: New file.
9614 * term.c, tparam.h: Include it.
9615 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9616 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9617 Move these decls to tparam.h, and make them agree with what
9618 is actually in tparam.c. The previous trick of using incompatible
9619 decls in different modules does not conform to the C standard.
9620 All callers of tparam changed to use tparam's actual API.
9621 * tparam.c (tparam1, tparam, tgoto):
9622 Use const pointers where appropriate.
9623
fbceeba2
PE
9624 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9625 * cm.h (struct cm): Likewise.
9626 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9627 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9628 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9629 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9630 (turn_on_face, init_tty): Likewise.
9631 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9632
7f3f1250
PE
9633 * term.c (term_mouse_position): Rename local to avoid shadowing.
9634
e6ca6543
PE
9635 * alloc.c (mark_ttys): Move decl from here ...
9636 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9637
c40f8d15
AS
96382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9639
9640 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9641
cfe0661d
JB
96422011-03-09 Juanma Barranquero <lekktu@gmail.com>
9643
9644 * search.c (compile_pattern_1): Remove argument regp, unused since
9645 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9646 (compile_pattern): Don't pass it.
9647
0afb4571
J
96482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9649
9650 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9651 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9652 for ! HAVE_GTK3.
9653 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9654
9655 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9656
9657 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9658 gdk_window_get_screen, gdk_window_get_geometry,
9659 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9660 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9661 (xg_get_pixbuf_from_pixmap): New function.
9662 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9663 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9664 Call xg_get_pixbuf_from_pixmap instead of
9665 gdk_pixbuf_get_from_drawable.
9666 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9667 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9668 (xg_check_special_colors): Use GtkStyleContext and its functions
9669 for HAVE_GTK3.
9670 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9671 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9672 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9673 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9674 Call gtk_widget_get_preferred_size.
0afb4571
J
9675 (xg_frame_resized): gdk_window_get_geometry only takes 5
9676 parameters.
44f230aa
SM
9677 (xg_win_to_widget, xg_event_is_for_menubar):
9678 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9679 (xg_set_widget_bg): New function.
9680 (delete_cb): New function.
895009e1 9681 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9682 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9683 (xg_set_background_color): Call xg_set_widget_bg.
9684 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9685 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9686 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9687 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9688 if ! HAVE_GTK3.
9689 (update_frame_tool_bar): Call gtk_widget_hide.
9690 (xg_initialize): Use GDK_KEY_g.
9691
9692 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9693 if ! HAVE_GTK3
9694 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9695
9696 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9697 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9698 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9699
1c2cc4ef
JB
97002011-03-08 Juanma Barranquero <lekktu@gmail.com>
9701
9702 * w32xfns.c (select_palette): Check success of RealizePalette against
9703 GDI_ERROR, not zero.
9704
33383987 9705See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9706
9707;; Local Variables:
9708;; coding: utf-8
aac0c6e3
MR
9709;; End:
9710
acaf905b 9711 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9712
9713 This file is part of GNU Emacs.
9714
9715 GNU Emacs is free software: you can redistribute it and/or modify
9716 it under the terms of the GNU General Public License as published by
9717 the Free Software Foundation, either version 3 of the License, or
9718 (at your option) any later version.
9719
9720 GNU Emacs is distributed in the hope that it will be useful,
9721 but WITHOUT ANY WARRANTY; without even the implied warranty of
9722 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9723 GNU General Public License for more details.
9724
9725 You should have received a copy of the GNU General Public License
9726 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.