Standardize some lispref menu entries.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
312508d7
EZ
12012-02-29 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4 push_it before setting up the iterator for the first overlay
5 string, even if we have an empty string loaded.
6 (next_overlay_string): If there's an empty string on the iterator
7 stack, pop the stack. (Bug#10903)
8
27f3c637
PE
92012-02-25 Paul Eggert <eggert@cs.ucla.edu>
10
11 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
12 Suggested by Stefan Monnier in
13 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
14 * alloc.c (widen_to_Lisp_Object): New static function.
15 (mark_memory): Also mark Lisp_Objects by fetching pointer words
16 and widening them to Lisp_Objects. This would work even if
17 USE_LSB_TAG is defined and wide integers are used, which might
18 happen in a future version of Emacs.
19
3c9dfce6
CY
202012-02-25 Chong Yidong <cyd@gnu.org>
21
fa74b241
CY
22 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
23 Doc fix.
24
3c9dfce6
CY
25 * xselect.c (Fx_selection_exists_p): Doc fix.
26 (x_clipboard_manager_save_all): Print an informative message
27 before saving to clipboard manager.
28
9486df08
CY
292012-02-24 Chong Yidong <cyd@gnu.org>
30
31 * keyboard.c (process_special_events): Handle all X selection
32 requests in kbd_buffer, not just the next one (Bug#8869).
33
f01d3321
CY
342012-02-23 Chong Yidong <cyd@gnu.org>
35
36 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
37 call when setting menu-bar-lines and tool-bar-lines parameters.
38 (unwind_create_frame_1): New helper function.
39
40 * window.c (inhibit_window_configuration_change_hook): New var.
41 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 42 (syms_of_window): Initialize it.
f01d3321 43
86b847b6
CY
442012-02-22 Chong Yidong <cyd@gnu.org>
45
46 * xterm.c (x_draw_image_relief): Add missing type check for
47 Vtool_bar_button_margin (Bug#10743).
48
a59225b1
CY
492012-02-21 Chong Yidong <cyd@gnu.org>
50
51 * fileio.c (Vfile_name_handler_alist): Doc fix.
52
53 * buffer.c (Fget_file_buffer): Protect against invalid file
54 handler return value.
55
310f5bd4
PE
562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
57
cb3a28cc
PE
58 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
59 when computing $valmask.
60
310f5bd4
PE
61 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
62 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
63 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
64 It's useless in that case, and it can cause problems on hosts
65 that allocate halves of EMACS_INT values separately.
66 Reported by Dan Horák. Diagnosed by Andreas Schwab in
67 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
68 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
69 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
70 it avoids undefined behavior on hosts where shifting right by more
71 than the word width has undefined behavior.
72
2375c96a
CY
732012-02-19 Chong Yidong <cyd@gnu.org>
74
75 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
76 (Funhandled_file_name_directory, Ffile_name_as_directory)
77 (Fdirectory_file_name, Fexpand_file_name)
78 (Fsubstitute_in_file_name): Protect against invalid file handler
79 return values (Bug#10845).
80
3eb49e71
EZ
812012-02-18 Eli Zaretskii <eliz@gnu.org>
82
83 * .gdbinit (pitx): Fix incorrect references to fields of the
84 iterator stack.
85
7b926f3f
CY
862012-02-17 Chong Yidong <cyd@gnu.org>
87
88 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
89
11273115
PE
902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
91
92 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
93 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
94
c3a70e2b
CY
952012-02-15 Chong Yidong <cyd@gnu.org>
96
97 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
98 marked as special. Also, starting docstrings with * is obsolete.
99
0ca43699
AS
1002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
101
102 * gnutls.c (emacs_gnutls_write): Fix last change.
103
2e8f3c56
LI
1042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
105
106 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
107 send_process.
108
af70074f
SM
1092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
110
111 * keymap.c (Fsingle_key_description): Handle char ranges.
112
95986d52
CY
1132012-02-12 Chong Yidong <cyd@gnu.org>
114
afd83bd1
CY
115 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
116 as that creates a dangerous corner case.
117
95986d52
CY
118 * window.c (Fdelete_window_internal): Invalidate the mouse
119 highlight (Bug#9904).
120
bd7da63e
GM
1212012-02-12 Glenn Morris <rgm@gnu.org>
122
123 * xselect.c (Fx_own_selection_internal)
124 (Fx_get_selection_internal, Fx_disown_selection_internal)
125 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
126 * nsselect.m (Fx_own_selection_internal)
127 (Fx_disown_selection_internal, Fx_selection_exists_p)
128 (Fx_selection_owner_p, Fx_get_selection_internal):
129 Sync docs and argument specs with the xselect.c versions.
130
77abcbc2
LI
1312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
132
133 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
134
90b671e2
EZ
1352012-02-11 Eli Zaretskii <eliz@gnu.org>
136
1c0ca0b7
EZ
137 * w32select.c (Fx_selection_exists_p): Sync doc string and
138 argument list with xselect.c. (Bug#10783)
139
140 * w16select.c (Fx_selection_exists_p): Sync doc string and
141 argument list with xselect.c. (Bug#10783)
90b671e2 142
49241268
GM
1432012-02-10 Glenn Morris <rgm@gnu.org>
144
145 * fns.c (Fsecure_hash): Doc fix.
146
f998bbe7 1472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
148
149 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
150
0992bd9c
CY
1512012-02-07 Chong Yidong <cyd@gnu.org>
152
153 * buffer.c (Fbuffer_local_variables)
154 (buffer_lisp_local_variables): Handle unbound vars correctly;
155 don't let Qunbound leak into Lisp.
156
af008560
GM
1572012-02-07 Glenn Morris <rgm@gnu.org>
158
dd605cc4
GM
159 * image.c (Fimagemagick_types): Doc fix.
160
af008560
GM
161 * image.c (imagemagick-render-type): Change it from a lisp object
162 to an integer. Move the doc here from the lisp manual.
163 Treat all values not equal to 0 the same.
164
1449fa1d
CY
1652012-02-06 Chong Yidong <cyd@gnu.org>
166
167 * doc.c (store_function_docstring): Avoid applying docstring of
168 alias to base function (Bug#2603).
169
3723ec07
AS
1702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
171
172 * .gdbinit (pp1, pv1): Remove redundant defines.
173 (pr): Use pp.
174
79c1cc1e
CY
1752012-02-04 Chong Yidong <cyd@gnu.org>
176
177 * nsterm.m: Declare a global (Bug#10694).
178
d7f29f8e
EZ
1792012-02-04 Eli Zaretskii <eliz@gnu.org>
180
181 * w32.c (get_emacs_configuration_options): Include
182 --enable-checking, if specified, in the return value.
183
3b95a6f9
MR
1842012-02-04 Martin Rudalics <rudalics@gmx.at>
185
186 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
187 after rounding frame sizes. (Bug#9723)
188
d6fa96a6
EZ
1892012-02-04 Eli Zaretskii <eliz@gnu.org>
190
191 * keyboard.c (adjust_point_for_property): Don't position point
192 before BEGV. (Bug#10696)
193
df0b2940
PE
1942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
195
196 Handle overflow when computing char display width (Bug#9496).
197 * character.c (char_width): Return EMACS_INT, not int.
198 (char_width, c_string_width): Check for overflow when
199 computing the width; this is possible now that individual
200 characters can have unbounded width. Problem introduced
201 by merge from Emacs 23 on 2012-01-19.
202
6bee44d6
MA
2032012-02-02 Michael Albinus <michael.albinus@gmx.de>
204
205 * dbusbind.c (Fdbus_register_method): Mention the return value
206 :ignore in the docstring.
207
44f92739
GM
2082012-02-02 Glenn Morris <rgm@gnu.org>
209
1b9f60cc
GM
210 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
211
44f92739
GM
212 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
213 Unconditionally set to t. (Bug#10673)
214 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
215 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
216 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
217
c5d3843c
KH
2182012-02-02 Kenichi Handa <handa@m17n.org>
219
220 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
221 0, do not call append_composite_glyph.
222
159462d4 2232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
224
225 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
226 NULL (Bug#6988).
227 (x_produce_glyphs): If the component of a composition is a null
228 string, set it->pixel_width to 1 to avoid zero-width glyph.
229
78cef877
EZ
2302012-02-01 Eli Zaretskii <eliz@gnu.org>
231
232 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
233 first 2 arguments are identical. This makes inserting large
234 output from a subprocess an order of magnitude faster on
235 MS-Windows, where all sbrk'ed memory is always contiguous.
236
97897668
GM
2372012-01-31 Glenn Morris <rgm@gnu.org>
238
239 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 240 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
241 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
242
31fd3586
GM
2432012-01-29 Glenn Morris <rgm@gnu.org>
244
245 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
246
0e24a8b2
CY
2472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
248
249 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
250
cc0adcb0
CY
2512012-01-28 Chong Yidong <cyd@gnu.org>
252
253 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
254
acc28cb9
CY
2552012-01-26 Chong Yidong <cyd@gnu.org>
256
9c69cfb7
CY
257 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
258
acc28cb9
CY
259 * search.c (Fsearch_forward, Fsearch_backward): Document negative
260 repeat counts (Bug#10507).
261
48da7392
GM
2622012-01-26 Glenn Morris <rgm@gnu.org>
263
264 * lread.c (syms_of_lread): Doc fix.
265
14af5f7f
CY
2662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
267
268 * coding.c (encode_designation_at_bol): Change return value to
269 EMACS_INT.
270
0b21c100
CY
2712012-01-25 Chong Yidong <cyd@gnu.org>
272
273 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
274
3c2907f7
CY
2752012-01-21 Chong Yidong <cyd@gnu.org>
276
277 * floatfns.c (Fcopysign): Make the second argument non-optional,
278 since nil is not allowed anyway.
279
959ad23f
AS
2802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
281
282 * process.c (read_process_output): Use p instead of XPROCESS (proc).
283 (send_process): Likewise.
284
34a02f46
MR
2852012-01-19 Martin Rudalics <rudalics@gmx.at>
286
287 * window.c (save_window_save, Fcurrent_window_configuration)
288 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
289 doc-strings.
290
1259009a 2912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
292
293 * character.c (char_width): New function.
70d4fdf6
GM
294 (Fchar_width, c_string_width, lisp_string_width):
295 Use char_width (Bug#9496).
25ed9e61 296
6a6ee00d
MR
2972012-01-16 Martin Rudalics <rudalics@gmx.at>
298
299 * window.c (Vwindow_persistent_parameters): New variable.
300 (Fset_window_configuration, save_window_save): Handle persistent
301 window parameters.
302
c85efaf7
EZ
3032012-01-14 Eli Zaretskii <eliz@gnu.org>
304
305 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
306 thrashing the stack of the thread. (Bug#9087)
307
5944709e
PE
3082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
309
310 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
311
e71f5d99
EZ
3122012-01-11 Eli Zaretskii <eliz@gnu.org>
313
314 * xdisp.c (rows_from_pos_range): Handle the case where the
315 highlight ends on a newline. (Bug#10464)
316 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
317 he end column for display of highlight that ends on a newline
318 before a R2L line.
319
ce316182
GM
3202012-01-11 Glenn Morris <rgm@gnu.org>
321
322 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
323 from load-path also when installation-directory is nil. (Bug#10208)
324
5b43da69
GM
3252012-01-10 Glenn Morris <rgm@gnu.org>
326
74cc8ff9
GM
327 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
328
7d8d6e4e
GM
329 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
330 Update template values to be closer to their typical values these days.
5b43da69 331
a0db8d43
EZ
3322012-01-09 Eli Zaretskii <eliz@gnu.org>
333
334 * xdisp.c (rows_from_pos_range): Accept additional argument
335 DISP_STRING, and accept any glyph in a row whose object is that
336 string as eligible for mouse highlight. Fixes mouse highlight of
337 display strings from overlays. (Bug#10464)
338
9a0115ab 3392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 340
b9110d6a 341 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
342 * fileio.c (auto_saving_dir_umask): New static var.
343 (Fmake_directory_internal): Use it.
344 (do_auto_save_make_dir): Set it, instead of invoking chmod after
345 creating the directory. The old code temporarily assigns
346 too-generous permissions to the directory.
347 (do_auto_save_eh): Clear it.
b9110d6a 348 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
349 that the var is always cleared.
350
6c1bd3f3
EZ
3512012-01-07 Eli Zaretskii <eliz@gnu.org>
352
353 * search.c (scan_buffer): Pass character positions to
354 know_region_cache, not byte positions. (Bug#6540)
355
069d2b50
L
3562012-01-07 LynX <_LynX@bk.ru> (tiny change)
357
358 * w32.c (sys_rename): Report EXDEV when rename of a directory
359 fails because the target is on another logical disk. (Bug#10284)
360
75bf0d33
DB
3612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
362
363 * xterm.c (x_embed_request_focus): New function.
364
365 * xterm.h: Add prototype.
366
367 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
368
1c6e5a32
GM
3692012-01-05 Glenn Morris <rgm@gnu.org>
370
371 * emacs.c (emacs_copyright): Update short copyright year to 2012.
372
651e947e
EZ
3732012-01-01 Eli Zaretskii <eliz@gnu.org>
374
375 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
376 Load gnutls_transport_set_lowat only if GnuTLS version is below
377 2.11.1.
378 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
379 GnuTLS versions below 2.11.1.
380
3778cdd8
AL
3812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
382
383 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
384 to the doc string advising against its use for altering the way
385 windows are scrolled.
386
0e5317f7
KH
3872011-12-28 Kenichi Handa <handa@m17n.org>
388
389 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
390 coding-system ASCII compatible only when it does not produce BOM
391 on encoding (Bug#10383).
392
93d5ca1f
JD
3932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
394
395 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
396 can scroll.
397 (create_and_show_popup_menu): Always use menu_position_func for
398 Gtk3 (Bug#10361).
399
ca22b785
AS
4002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
401
402 * callint.c (Fcall_interactively): Don't truncate prompt string.
403
d048e1e6
EZ
4042011-12-23 Eli Zaretskii <eliz@gnu.org>
405
406 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
407 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 408 resumed from there (after widening). (Bug#10360)
d048e1e6 409
5ccaba1f
JD
4102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
411
412 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
413
204ee57f
JD
4142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
415
b81d40f0
JB
416 * nsterm.m (x_free_frame_resources):
417 Release f->output_data.ns->miniimage.
204ee57f
JD
418 (ns_index_color): Fix indentation. Do not retain
419 color_table->colors[i].
420
421 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
422 before returning.
423
424 * nsfns.m (x_set_background_color): Assign return value from
425 ns_index_color to face-background instead of NSColor*.
426 (ns_implicitly_set_icon_type): Fix indentation.
427 Change assignment in for loop to comparison.
428
429 * emacs.c (ns_pool): New variable.
430 (main): Assign ns_pool.
431 (Fkill_emacs): Call ns_release_autorelease_pool.
432
433 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
434 autorelease fdesc, release fdAttrs and tdict.
435 (ns_get_covering_families): Release charset.
436 (ns_findfonts): Release NSFontDescriptor created with new.
437 (ns_uni_to_glyphs): Fix indentation.
438 (setString): Release attrStr before assigning new value.
439
c803b2b7
JD
4402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
441
678f4426
JD
442 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
443 and NS_IMPL_COCOA.
444 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
445 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
446
cd394be1 4472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 448
5fecd5fc
JD
449 * nsterm.m (ns_term_init): Subscribe for notifications
450 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
451 to method trackingNotification in EmacsMenu.
452
453 * nsmenu.m (trackingMenu): New variable.
3771cb17 454 (trackingNotification): New method (from Aquamacs).
5fecd5fc 455 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 456 from Aquamacs (Bug#7030).
678f4426
JD
457
4582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 459
c803b2b7
JD
460 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
461 (symbol_to_nsstring): Fix indentation.
462 (ns_symbol_to_pb): New function.
463 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
464 (Fns_rotate_cut_buffers_internal): Removed.
465 (Fns_store_selection_internal): Renamed from
466 Fns_store_cut_buffer_internal.
467 (ns_get_foreign_selection, Fx_own_selection_internal)
468 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
469 (Fns_get_selection_internal, Fns_store_selection_internal):
470 Use ns_symbol_to_pb and check if return value is nil.
471 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
472 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
473 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
474 renamed to Sns_store_selection_internal.
475 (ns_handle_selection_request): Move code to Fx_own_selection_internal
476 and remove this function.
477 (ns_handle_selection_clear): Remove, never used.
478 (Fx_own_selection_internal): Move code from ns_handle_selection_request
479 here.
480
e1b01a3a
KB
4812011-12-17 Ken Brown <kbrown@cornell.edu>
482
483 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
484 GID is unknown (Bug#10257).
485
2adb6e85
PE
4862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
487
488 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
489 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
490 which caused a build failure on GNU/Linux IA-64. This problem was
491 introduced by my 2011-10-07 patch.
492
d1d7b339
JL
4932011-12-15 Juri Linkov <juri@jurta.org>
494
495 * image.c (imagemagick_error): New function. (Bug#10112)
496 (imagemagick_load_image): Comment out `MagickSetResolution' call.
497 Use `imagemagick_error' where ImageMagick functions return
498 `MagickFalse'.
499 (Fimagemagick_types): Add `Fnreverse' to return the list in the
500 proper order.
501
100d5755
KH
5022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
503
504 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
505 fill background (Bug#8992).
506
454592a6
MR
5072011-12-13 Martin Rudalics <rudalics@gmx.at>
508
509 * window.c (Vwindow_combination_resize)
510 (Vwindow_combination_limit): Use t instead of non-nil in
511 doc-strings.
61d4b438
MR
512 (Vrecenter_redisplay): Add first sentence of doc-string on
513 separate line.
53524d93 514 (Frecenter): Fix doc-string typo.
454592a6 515
3633e3aa
KH
5162011-12-11 Kenichi Handa <handa@m17n.org>
517
518 * coding.c (Funencodable_char_position): Pay attention to the
519 buffer text relocation (Bug#9389).
520
7b9d523a
JD
5212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
522
523 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
524 gtk_init (Bug#10100).
525
b73189c6
EZ
5262011-12-10 Eli Zaretskii <eliz@gnu.org>
527
528 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
529 IT->string is nil. (Bug#10263)
530
f7dfe5d6
JD
5312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
532
83faebb4
JD
533 * nsterm.h (x_free_frame_resources): Declare.
534
f7dfe5d6
JD
535 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
536 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
537
538 * nsterm.h (ns_get_defaults_value): Declare.
539
540 * nsterm.m (ns_default): Call ns_get_defaults_value.
541
7cd4e72c
EZ
5422011-12-09 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
545 (Bug#10170)
546
b34d7317
YM
5472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
548
549 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
550 that where the value of an _OBJC_* symbol points to is in the .bss
551 section (Bug#10240).
552
76470ad1
KH
5532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
554
555 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 556 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 557
745fff94
KH
5582011-12-08 Kenichi Handa <handa@m17n.org>
559
560 * ftfont.c (get_adstyle_property): Fix previous change
561 (Bug#10233).
562
6e44397c
JB
5632011-12-07 Juanma Barranquero <lekktu@gmail.com>
564
565 * w32.c (init_environment): If no_site_lisp, remove site-lisp
566 dirs from the default value of EMACSLOADPATH (bug#10208).
567
7efa6272
GM
5682011-12-07 Glenn Morris <rgm@gnu.org>
569
570 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
571 installation and source directories as well. (Bug#10208)
572
f6fc4d87
CY
5732011-12-06 Chong Yidong <cyd@gnu.org>
574
575 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
576
2bf26180
GM
5772011-12-06 Glenn Morris <rgm@gnu.org>
578
579 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
580 as an error, not just -1. (Bug#10217)
581
3a6ad4f0
CY
5822011-12-05 Chong Yidong <cyd@gnu.org>
583
584 * keyboard.c (process_special_events): New function.
585 (swallow_events, Finput_pending_p): Use it (Bug#10195).
586
75a3b399
PE
5872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
588
589 * coding.c (encode_designation_at_bol): Don't use uninitialized
590 local variable (Bug#9318).
591
c3c9e25e
KH
5922011-12-05 Kenichi Handa <handa@m17n.org>
593
594 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
595 return Qnil (Bug#8046, Bug#10193).
596
5eb05ea3
KH
5972011-12-05 Kenichi Handa <handa@m17n.org>
598
599 * coding.c (encode_designation_at_bol): New args charbuf_end and
600 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
601 (coding_set_source): Return how many bytes coding->source was
602 relocated.
603 (coding_set_destination): Return how many bytes
604 coding->destination was relocated.
605 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
606 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
607
6082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
609
610 * coding.c (CODING_CHAR_CHARSET_P): New macro.
611 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
612 macro (Bug#9318).
613
6142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
615
616 The following changes are to fix Bug#9318.
617
a79703f5 618 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
619 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
620 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 621 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 622
7dbda6df
JB
6232011-12-05 Juanma Barranquero <lekktu@gmail.com>
624
625 * lisp.h (process_quit_flag): Fix external declaration.
626
6d5eb5b0
SM
6272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
628
629 Don't macro-inline non-performance-critical code.
630 * eval.c (process_quit_flag): New function.
631 * lisp.h (QUIT): Use it.
632
a0c3fad0
JD
6332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
634
635 * nsfns.m (get_geometry_from_preferences): New function.
636 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
637
6c07aac2
AS
6382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
639
640 * emacs.c (Qkill_emacs): Define.
641 (syms_of_emacs): Initialize it.
642 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
643 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
644 (quit_throw_to_read_char): Add parameter `from_signal'.
645 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
646 * lisp.h (QUIT): Call Fkill_emacs if requested.
647
c052ead4
JD
6482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
649
650 * widget.c (update_wm_hints): Return if wmshell is null.
651 (widget_update_wm_size_hints): New function.
652
653 * widget.h (widget_update_wm_size_hints): Declare.
654
655 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
656 widget_update_wm_size_hints (Bug#10104).
657
9e49252b
EZ
6582011-12-03 Eli Zaretskii <eliz@gnu.org>
659
660 * xdisp.c (handle_invisible_prop): If the invisible text ends just
661 before a newline, prepare the bidi iterator for consuming the
662 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 663 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 664
02b16839
JL
6652011-12-02 Juri Linkov <juri@jurta.org>
666
667 * search.c (Fword_search_regexp): New Lisp function created from
668 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
669 (Fword_search_backward, Fword_search_forward)
670 (Fword_search_backward_lax, Fword_search_forward_lax):
671 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
672 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
673
0068070e
SM
6742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 * fileio.c (Finsert_file_contents): Move after-change-function call
677 to before the "handled:" label, since all "goto handled" appear in
678 cases where the *-change-functions have already been properly called
679 (bug#10117).
680
3360a3fc
AS
6812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
682
683 * keyboard.c (interrupt_signal): Don't call kill-emacs when
684 waiting for input. (Bug#10169)
685
73d6c093
EZ
6862011-11-30 Eli Zaretskii <eliz@gnu.org>
687
688 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
689 verifies glyph row's hash code--we have just reallocated the
690 glyphs, so their contents can be complete garbage. (Bug#10164)
691
febe6bea
JB
6922011-11-30 Juanma Barranquero <lekktu@gmail.com>
693
694 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
695
801a4313
EZ
6962011-11-30 Eli Zaretskii <eliz@gnu.org>
697
698 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
699 attributes are tested _before_ calling verify_row_hash, to protect
700 against GCC re-ordering of the tests. (Bug#10164)
701
2b56b87e
JD
7022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
703
704 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
705
706 * xterm.c (handle_one_xevent): Only set async_visible and friends
707 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 708 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
709 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
710
dbf31225
PE
7112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
712
713 Remove GCPRO-related macros that exist only to avoid shadowing locals.
714 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
715 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
716 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
717 All uses changed to use GCPRO1 etc.
718 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
719 Revert to old implementation (i.e., before 2011-03-11).
720
1305621b
YM
7212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
722
723 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
724 of scroll runs so as to avoid assigning disabled bogus rows and
725 unnecessary graphics copy operations.
726
8c9afb46
EZ
7272011-11-27 Eli Zaretskii <eliz@gnu.org>
728
729 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
730 (snprintf) [_MSC_VER]: Redirect to _snprintf.
731 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
732 (malloc, free, realloc, calloc): Redirect to e_* only when
733 compiling Emacs.
734
735 * lisp.h (GCTYPEBITS): Move before first use.
736 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
737 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
738 this macro definition.
739
740 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
741 _MSC_VER.
742
54e9e3bf
JD
7432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
744
6d5eb5b0
SM
745 * gtkutil.c (xg_create_frame_widgets):
746 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
747 present with Gtk+ 2.0.
748
83aca1cb
PE
7492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
750
751 * fileio.c (Finsert_file_contents): Undo previous change; see
752 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
753
5b76caa4
PE
7542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
755
756 Rename locals to avoid shadowing.
757 * fileio.c (Finsert_file_contents):
758 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
759 * process.c (wait_reading_process_output):
760 Rename inner 'proc' to 'p' to avoid shadowing.
761 Indent for consistency with usual Emacs style.
762
8c535114
EZ
7632011-11-25 Eli Zaretskii <eliz@gnu.org>
764
765 * xdisp.c (redisplay_window): If cursor row is not fully visible
766 after recentering, and scroll-conservatively is set to a large
767 number, scroll window by a few more lines to make the cursor fully
768 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
769 (start_display): Don't move to the next line if the display should
770 start at a newline that is part of a display vector or an overlay
771 string. (Bug#10119)
8c535114 772
fa4fdb5c
JL
7732011-11-24 Juri Linkov <juri@jurta.org>
774
775 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
776 after the `MagickPingImage' call. (Bug#10112)
777
90ec88df
CY
7782011-11-23 Chong Yidong <cyd@gnu.org>
779
780 * window.c (Fcoordinates_in_window_p): Accept only live windows.
781
56e2e794
MR
7822011-11-23 Martin Rudalics <rudalics@gmx.at>
783
784 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
785 making another buffer current. (Bug#10114)
786
b6e64c41
GM
7872011-11-23 Glenn Morris <rgm@gnu.org>
788
789 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
790
6b21de18
CY
7912011-11-23 Chong Yidong <cyd@gnu.org>
792
793 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
794 using it (Bug#5984).
795
b12cd789
EZ
7962011-11-22 Eli Zaretskii <eliz@gnu.org>
797
798 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
799 and header-lines, as they don't have one computed for them.
800 (Bug#10098)
801
802 * .gdbinit (prow): Make displayed values more self-explaining.
803 Add row's hash code.
804
261b6fd4
LMI
8052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
806
807 * process.c (wait_reading_process_output): Fix asynchrounous
808 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 809 (wait_reading_process_output): Add comment and URL.
261b6fd4 810
e7cfd277
JD
8112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
812
813 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
814
a9b9b7f5
CY
8152011-11-21 Chong Yidong <cyd@gnu.org>
816
817 * window.c (Fnext_window, Fprevious_window): Doc fix.
818
b0d15b4f
SM
8192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
820
821 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
822
fe7a3057
JB
8232011-11-20 Juanma Barranquero <lekktu@gmail.com>
824
825 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
826
d2999b1a
MR
8272011-11-20 Martin Rudalics <rudalics@gmx.at>
828
829 * window.c (Fset_window_combination_limit): Rename argument
830 STATUS to LIMIT.
831 (Vwindow_combination_limit): Remove "status" from doc-string.
832
d5ff9cd0
AS
8332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
834
835 * m/ibms390.h: Remove.
836 * m/ibms390x.h: Don't include "ibms390.h".
837
a5bb9bd3
SM
8382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
839
840 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
841 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
842
cd1181db
JB
8432011-11-20 Juanma Barranquero <lekktu@gmail.com>
844
845 * casetab.c (Fset_case_table):
846 * charset.c (Fcharset_after): Fix typos.
847
615a3b8d 8482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 849
17e845af
PE
850 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
851 Otherwise, valgrind does not work on some platforms.
852 Problem reported by Andreas Schwab in
6a0bf43d
PE
853 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
854 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
855 is set, removing the need for VIRT_ADDRESS_VARIES.
856 (PURE_P): Use a more-efficient implementation that needs just one
857 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
858 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
859 to 4 (xorl, subq, cmpq, setbe).
860 * alloc.c (pure): Always extern now, since that's the
861 VIRT_ADDR_VARIES behavior.
862 (PURE_POINTER_P): Use a single comparison, not two, for
863 consistency with the new puresize.h.
864 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
865 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
866 Remove VIRT_ADDR_VARIES no longer needed.
867
f8fe6f96
EZ
8682011-11-19 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
871 (erase_phys_cursor, update_window_cursor, show_mouse_face)
872 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
873 behave as if the cursor position were at the window margin.
874
875 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
876 and the cursor position is out of bounds, behave as if the cursor
877 position were at the window margin. (Bug#10075)
878
df05a53c
CY
8792011-11-18 Chong Yidong <cyd@gnu.org>
880
881 * window.c (Fwindow_combination_limit): Make first argument
882 non-optional, since it is meaningless for live windows like the
883 selected window.
884
2071918e
DA
8852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
886
887 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
888
b50a28de
SM
8892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
890
891 * intervals.c: Fix grafting over the whole buffer (bug#10071).
892 (graft_intervals_into_buffer): Simplify.
893
015137db
EZ
8942011-11-18 Eli Zaretskii <eliz@gnu.org>
895
896 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
897 hash values of the two rows.
898 (copy_row_except_pointers): Preserve the used[] arrays and the
899 hash values of the two rows. (Bug#10035)
68c95424 900 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
901
902 * xdisp.c (row_hash): New function, body extracted from
903 compute_line_metrics.
904 (compute_line_metrics): Call row_hash, instead of computing the
905 hash code inline.
906
907 * dispnew.c (verify_row_hash): Call row_hash for computing the
908 hash code of a row, instead of duplicating code from xdisp.c.
909
910 * dispextern.h (row_hash): Add prototype.
911
a2addb04
TH
9122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
913
914 * frame.c (delete_frame): Don't delete the terminal when the last
915 X frame is closed if emacs is built with GTK toolkit.
916
df85d315
JB
9172011-11-17 Juanma Barranquero <lekktu@gmail.com>
918
919 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
920
a0c2d0ae
MR
9212011-11-17 Martin Rudalics <rudalics@gmx.at>
922
923 * window.c (Vwindow_splits): Rename to
924 Vwindow_combination_resize. Suggested by Juri Linkov.
925 (Fsplit_window_internal): Use Vwindow_combination_resize instead
926 of Vwindow_splits.
927
58179cce
JB
9282011-11-16 Juanma Barranquero <lekktu@gmail.com>
929
7877f373
JB
930 * nsfns.m (Fns_font_name):
931 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 932
b6f67890
MR
9332011-11-16 Martin Rudalics <rudalics@gmx.at>
934
935 * window.h (window): Rename slot "nest" to "combination_limit".
936 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
937 (Fset_window_nest): Rename to Fset_window_combination_limit.
938 (Vwindow_nest): Rename to Vwindow_combination_limit.
939 (recombine_windows, make_parent_window, make_window)
940 (Fsplit_window_internal, saved_window)
941 (Fset_window_configuration, save_window_save): Rename all
942 occurrences of window_nest to window_combination_limit.
943
c7015153
JB
9442011-11-15 Juanma Barranquero <lekktu@gmail.com>
945
946 * image.c (imagemagick_load_image): Fix typo.
947
322ad6ec
EZ
9482011-11-14 Eli Zaretskii <eliz@gnu.org>
949
950 * xdisp.c (display_line): Move the call to
951 highlight_trailing_whitespace before the call to
952 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
953 faces of all the glyphs to compute ROW's hash value.
954 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 955
f067b8ec
JB
9562011-11-14 Juanma Barranquero <lekktu@gmail.com>
957
958 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
959 just return (bug#10044).
960
1e5b2111
EZ
9612011-11-12 Eli Zaretskii <eliz@gnu.org>
962
7ef3cbd5
EZ
963 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
964 with user-defined heap size. Bump the default size of the temacs
965 heap to 27MB, to avoid memory warning when running temacs.
966 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
967
1e5b2111
EZ
968 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
969 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
970 (verify_row_hash) [XASSERTS]: New function.
971 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
972 that the hash value of glyph rows is correct.
1e5b2111 973
89d61221
MR
9742011-11-12 Martin Rudalics <rudalics@gmx.at>
975
976 * window.h (window): Remove splits slot.
977 * window.c (Fwindow_splits, Fset_window_splits): Remove.
978 (Fdelete_other_windows_internal, make_parent_window)
979 (make_window, Fsplit_window_internal, Fdelete_window_internal)
980 (Fset_window_configuration, save_window_save): Don't deal with
981 split status of windows.
982 (saved_window): Remove splits slot.
983 (Vwindow_splits): Rewrite doc-string.
984
97f18cc8
JD
9852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
986
987 * xfns.c (unwind_create_frame):
988 * nsfns.m (unwind_create_frame):
989 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
990 Vframe_list (Bug#9999).
991
22a648b4
DA
9922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
993
0b381c7e 994 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 995
659afede
KH
9962011-11-11 Kenichi Handa <handa@m17n.org>
997
998 * callproc.c (Fcall_process): Set the member dst_multibyte of
999 process_coding.
1000
9ac0394b
KH
10012011-11-11 Johan Bockgård <bojohan@gnu.org>
1002
1003 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1004 avoid a crash (bug#9496).
1005
2fbdc249
CY
10062011-11-09 Chong Yidong <cyd@gnu.org>
1007
1008 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1009 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1010
ac6b1f81
PE
10112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1014
09db192c
PE
10152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 Avoid some portability problems by eschewing 'extern inline' functions.
1018 The trivial performance wins aren't worth the portability hassles; see
1019 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1020 et seq.
1021 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1022 (window_box_width, window_box_left, window_box_left_offset)
1023 (window_box_right, window_box_right_offset): Undo previous change,
1024 by removing the "extern"s.
1025 * intervals.c (adjust_intervals_for_insertion)
1026 (adjust_intervals_for_deletion): Undo previous change,
1027 making these static again.
1028 (offset_intervals, temp_set_point_both, temp_set_point)
1029 (copy_intervals_to_string): No longer inline.
1030 * xdisp.c (window_text_bottom_y, window_box_width)
1031 (window_box_height, window_box_left_offset)
1032 (window_box_right_offset, window_box_left, window_box_right)
1033 (window_box): No longer inline.
1034
105216ed
CY
10352011-11-08 Chong Yidong <cyd@gnu.org>
1036
1037 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1038 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1039 Signal an error if not a live window.
105216ed
CY
1040 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1041 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1042
ae9e237f
JB
10432011-11-07 Juanma Barranquero <lekktu@gmail.com>
1044
1045 * lisp.h (syms_of_abbrev): Remove declaration.
1046 Reported by CHENG Gao <chenggao@royau.me>.
1047
c7aa8333
EZ
10482011-11-07 Eli Zaretskii <eliz@gnu.org>
1049
1050 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1051 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1052 of temacs in GUI mode.
1053
be7f5545
MR
10542011-11-07 Martin Rudalics <rudalics@gmx.at>
1055
1056 * window.h: Declare delete_all_child_windows instead of
1057 delete_all_subwindows.
1058 * window.c (Fwindow_nest, Fset_window_nest)
1059 (Fset_window_new_total, Fset_window_new_normal)
1060 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1061 (delete_all_subwindows): Rename to delete_all_child_windows.
1062 (Fdelete_other_windows_internal, Fset_window_configuration):
1063 Call delete_all_child_windows instead of delete_all_subwindows.
1064 * frame.c (delete_frame): Call delete_all_child_windows instead
1065 of delete_all_subwindows.
1066
ca78dc43
PE
10672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1070 This is also needed for porting to any host where GC_MARK_STACK is
1071 not GC_MAKE_GCPROS_NOOPS.
1072 (which_symbols): Use it.
1073
a0241d01
KH
10742011-11-07 Kenichi Handa <handa@m17n.org>
1075
1076 * coding.c (coding_set_destination): Check coding->src_pos only
1077 when coding->src_object is a buffer (bug#9910).
1078
1079 * process.c (send_process): Set the member src_multibyte of coding
1080 to 0 (bug#9911) when sending a unibyte text.
1081
1082 * callproc.c (Fcall_process): Set the member src_multibyte of
1083 process_coding to 0 (bug#9912).
1084
a64bfdfa 10852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1086
1087 * xmenu.c (cleanup_widget_value_tree): New function.
1088 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1089 calling free_menubar_widget_value_tree directly (Bug#9830).
1090
cb41b32a
PE
10912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 Fix some portability problems with 'inline'.
1094 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1095 (window_box_width, window_box_left, window_box_left_offset)
1096 (window_box_right, window_box_right_offset): Declare extern.
1097 Otherwise, these inline functions do not conform to C99 and
1098 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1099 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1100 * intervals.c (adjust_intervals_for_insertion)
1101 (adjust_intervals_for_deletion): Now extern, because otherwise the
1102 extern inline functions 'offset_intervals' couldn't refer to it.
1103 (static_offset_intervals): Remove.
1104 (offset_intervals): Rewrite using the old contents of
1105 static_offset_intervals. The old version didn't conform to C99
1106 because an extern inline function contained a reference to an
1107 identifier with static linkage.
1108
b7041366
AS
11092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1110
1111 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1112 GC.
1113
88a37c4d
EZ
11142011-11-06 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1117 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1118 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1119 return Qleft_to_right.
1120
49745b39
CY
11212011-11-06 Chong Yidong <cyd@gnu.org>
1122
1123 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1124 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1125 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1126 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1127 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1128 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1129 (Fwindow_vscroll): Doc fix.
1130 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1131 argument, since it makes no sense to pass a live window and for
1132 consistency with window-child.
1133
1f05cd82
CS
11342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1135
1136 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1137 support MSVC.
1138
22610910
JR
11392011-11-05 Jason Rumney <jasonr@gnu.org>
1140
1141 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1142 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1143 fonts (Bug#6029).
1144 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1145 bitwise arithmetic preventing use of unicode-sip and non-truetype
1146 opentype fonts.
1147
a06776b2
EZ
11482011-11-05 Eli Zaretskii <eliz@gnu.org>
1149
3ad924ba
EZ
1150 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1151 "emacs"-only part.
1152
a06776b2
EZ
1153 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1154 initialization code to keep similarity to xfns.c after changes
1155 from 2011-11-05.
1156
c9e7db78
JD
11572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1158
a97f8f3f
JD
1159 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1160 (unwind_create_frame): New function (Bug#9943).
1161 (Fx_create_frame): Restructure code to be more similar to the one in
1162 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1163 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1164 Move terminal->reference_count++ just before making the frame official
1165 (Bug#9943).
1166
1167 * nsterm.m (x_free_frame_resources): New function.
1168 (x_destroy_window): Move code to x_free_frame_resources.
1169
c9e7db78 1170 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1171 (Fx_create_frame, x_create_tip_frame):
1172 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1173 official. Move initialization of image_cache_refcount and
1174 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1175
a6fc3b5c
EZ
11762011-11-05 Eli Zaretskii <eliz@gnu.org>
1177
1178 Support MSVC build with newer versions of Visual Studio.
1179 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1180 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1181 nt/gmake.defs.
1182
1183 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1184 which are not supported by MSVC.
1185 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1186 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1187 bitfields.
1188 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1189 types in bitfields.
1190 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1191
1192 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1193
58179cce 11942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1195
1196 Support MSVC build with newer versions of Visual Studio.
1197 * w32.c: Don't include w32api.h for MSVC.
1198 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1199
1200 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1201 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1202 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1203 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1204 e_* cousins.
1205 (alloca) [_MSC_VER]: Define to _alloca.
1206
1207 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1208
1209 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1210
a58c13ed
EZ
12112011-11-04 Eli Zaretskii <eliz@gnu.org>
1212
1213 * xdisp.c (note_mouse_highlight): If either of
1214 previous/next-single-property-change returns nil, treat that as
1215 the beginning or the end of the buffer. (Bug#9955)
1216
fe0b6370
JD
12172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1218
a58c13ed 1219 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1220 label is not null (Bug#9951).
1221 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1222 may be NULL.
1223
89bd5ee1
EZ
12242011-11-04 Eli Zaretskii <eliz@gnu.org>
1225
1226 * window.c (Fwindow_body_size): Mention in the doc string that the
1227 return value is in frame's canonical units. (Bug#9949)
1228
84c3edb9
EZ
12292011-11-03 Eli Zaretskii <eliz@gnu.org>
1230
4e2fb5c7
EZ
1231 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1232
84c3edb9 1233 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1234 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1235 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1236
bc17a887
EZ
12372011-11-01 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1240 Don't stop backward scan on the continuation glyph, even though
1241 its CHARPOS is positive.
6d5eb5b0
SM
1242 (mouse_face_from_buffer_pos, note_mouse_highlight):
1243 Rename cover_string to disp_string.
bc17a887 1244
4ee88440
MR
12452011-11-01 Martin Rudalics <rudalics@gmx.at>
1246
1247 * window.c (temp_output_buffer_show): Don't use
1248 Vtemp_buffer_show_specifiers.
1249 (Vtemp_buffer_show_specifiers): Remove unused variable.
1250
c2ff3c02
EZ
12512011-10-30 Eli Zaretskii <eliz@gnu.org>
1252
1253 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1254 past the beginning of the current glyph matrix.
1255
58179cce 12562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1257
1258 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1259 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1260 HAVE_GTK3 (Bug#9869).
b77a6a7f 1261
3b574623
JD
1262 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1263 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1264
b77a6a7f
JD
1265 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1266
1267 * xterm.c: Declare x_handle_net_wm_state to return int.
1268 (handle_one_xevent): Check if we are iconified but don't have
1269 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1270 (get_current_wm_state): Return non-zero if not hidden,
1271 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1272 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1273 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1274 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1275
196e41e4
PE
12762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1279 so that this new function doesn't get optimized away by a
1280 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1281
021f2e1a
AS
12822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1283
1284 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1285
8b058d44
EZ
12862011-10-29 Eli Zaretskii <eliz@gnu.org>
1287
1288 Fix the `xbytecode' command.
1289 * .gdbinit (xprintbytestr): New command.
b50a28de 1290 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1291 (xbytecode): Print the byte-code string as well.
1292
4452fb80
EZ
12932011-10-29 Kim Storm <storm@cua.dk>
1294
8b058d44
EZ
1295 * alloc.c (which_symbols): New function.
1296
21b72067
AS
12972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1298
1299 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1300 line. (Bug#9903)
1301
83ed7b5c
GM
13022011-10-29 Glenn Morris <rgm@gnu.org>
1303
1304 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1305 Not clear what it was for, and it causes various bugs. (Bug#9839)
1306
5a7a728b
EZ
13072011-10-28 Eli Zaretskii <eliz@gnu.org>
1308
1309 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1310 possible random value that matches one of those tested as
1311 condition to clear the mouse face.
1312
d3d0842f
CY
13132011-10-28 Chong Yidong <cyd@gnu.org>
1314
1315 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1316
31b39d13
DN
13172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1318
1319 * window.c (make_window): Initialize phys_cursor_on_p.
1320
9aba6043
SM
13212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1322
1323 * lisp.h (struct Lisp_Symbol): Update comments.
1324
c20992f4
JB
13252011-10-28 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1328
db4f02f2
EZ
13292011-10-28 Eli Zaretskii <eliz@gnu.org>
1330
1331 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1332 <oslsachem@gmail.com> for helping to debug this.
1333
1334 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1335 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1336 (g_b_init_get_glyph_outline_w): New static variables.
1337 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1338 (GetGlyphOutlineW_Proc): New typedefs.
1339 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1340 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1341 New functions.
1342 (w32font_open_internal, compute_metrics):
1343 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1344 instead of calling the "wide" APIs directly.
1345
1346 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1347
1348 * w32.h (syms_of_w32font): Add prototype.
1349
87e68db4
JB
13502011-10-27 Juanma Barranquero <lekktu@gmail.com>
1351
1352 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1353 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1354 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1355 (Fmove_to_window_line): Doc fix.
1356
435c1d67
CY
13572011-10-27 Chong Yidong <cyd@gnu.org>
1358
1359 * process.c (make_process): Set gnutls_state to NULL.
1360
1361 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1362 non-NULL, regardless of GNUTLS_INITSTAGE.
1363 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1364 an error. Set process slots as soon as we allocate them.
1365
1366 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1367
9c6c6f49
CY
13682011-10-27 Chong Yidong <cyd@gnu.org>
1369
9aba6043
SM
1370 * gnutls.c (emacs_gnutls_deinit): New function.
1371 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1372 (Fgnutls_deinit, Fgnutls_boot): Use it.
1373
1374 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1375 (deactivate_process): Call emacs_gnutls_deinit.
1376
657d08d3
JB
13772011-10-27 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * image.c (x_create_x_image_and_pixmap):
1380 * w32.c (sys_rename, w32_delayed_load):
1381 * w32font.c (fill_in_logfont):
1382 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1383
5430d399
JB
13842011-10-26 Juanma Barranquero <lekktu@gmail.com>
1385
1386 * w32fns.c (w32_default_color_map): New function,
1387 extracted from Fw32_default_color_map.
a7ef684b 1388 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1389
fe0055fa
PE
13902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1393
e6346438
SM
13942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1395
1396 * keyboard.c (test_undefined): New function (bug#9751).
1397 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1398
e112cc37
ET
13992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1400
1401 * sysdep.c (init_sys_modes): Fix the check for the controlling
1402 terminal (Bug#6649).
1403
7b5d6677
EZ
14042011-10-20 Eli Zaretskii <eliz@gnu.org>
1405
1406 * dispextern.h (struct bidi_it): New member next_en_type.
1407
1408 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1409 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1410 current character, check also for next_en_type being WEAK_EN.
1411 (bidi_resolve_weak): Don't enter the expensive loop if the current
1412 position is before next_en_pos. Record the bidi type of the first
1413 non-ET, non-BN character we find, in addition to its position.
1414 (bidi_level_of_next_char): Invalidate next_en_type when
1415 next_en_pos is over-stepped.
1416
7da0b018
PE
14172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1420 * editfns.c: Rewrite current-time-zone so that it invokes
1421 the equivalent of (format-time-string "%Z") to get the time zone name.
1422 This fixes a bug when the time zone name contains characters that
1423 need converting from the system time locale to Emacs internal format.
1424 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1425 that patch fixed format-time-string to do the conversion, but
1426 I forgot to fix current-time-zone.
1427 (format_time_string): New function, containing most of
1428 what Fformat_time_string used to contain.
1429 (Fformat_time_string): Rewrite in terms of format_time_string.
1430 This doesn't change this function's behavior.
1431 (current-time-zone): Rewrite to use format_time_string.
1432 This fixes the bug reported by Michael Schierl in
1433 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1434 Jason Rumney's 2007-06-07 change worked around this bug, but
1435 didn't fix it.
1436 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1437
8547b010
EZ
14382011-10-19 Eli Zaretskii <eliz@gnu.org>
1439
1440 * xdisp.c (start_display): If the character at POS is displayed
1441 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1442 (try_window_reusing_current_matrix): If a line ends in a display
1443 vector or the next line starts in a display vector, continue
1444 redrawing the window even though the character position of
1445 start_row was reached.
8547b010
EZ
1446 (Bug#9771, part 2)
1447
4e948d15
CY
14482011-10-18 Chong Yidong <cyd@gnu.org>
1449
1450 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1451 with nobreak-char-display too.
1452
4787455f
EZ
14532011-10-18 Eli Zaretskii <eliz@gnu.org>
1454
1455 Fix part 3 of bug#9771.
1456 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1457 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1458 non-neutral characters if the current character is a paragraph
1459 separator (a.k.a. Newline). This avoids running the same
1460 expensive loop twice, once when we consume the preceding newline
1461 and the other time when the line actually needs to be displayed.
1462 Avoid the loop when we see neutrals on the base embedding level
1463 following a character whose directionality is the same as the
1464 paragraph's. This avoids running the expensive loop when a line
1465 ends in a long sequence of neutrals, like control characters.
1466 Add assertion against STRONG_AL type. Slightly rearrange code
1467 that determines the type of a neutral given the first non-neutral
1468 that follows it.
1469 (bidi_level_of_next_char): Set next_en_pos to zero when
1470 invalidating its info.
1471
2c91f553
EZ
14722011-10-17 Eli Zaretskii <eliz@gnu.org>
1473
1474 * xdisp.c (push_display_prop): Determine whether to record string
1475 or buffer position by IT->string, not by IT->method. Allow
1476 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1477 (move_it_vertically_backward): Don't look for character position
1478 immediately after the newline when in a continuation line.
1479 (Bug#9771, part 1)
2c91f553 1480
c7b08b0d
MR
14812011-10-15 Martin Rudalics <rudalics@gmx.at>
1482
1483 * window.c (coordinates_in_window): Rewrite and delabelize
1484 vertical border check. (Bug#5357) (Bug#9618)
1485
6b02f655
SM
14862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1487
1488 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1489 errors in XSetWindowBorder (bug#9310).
1490
81d40c92
DA
14912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1492
1493 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1494 avoid crash when xmalloc overrun checking is enabled.
1495
d4172c3b
EZ
14962011-10-13 Eli Zaretskii <eliz@gnu.org>
1497
1498 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1499 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1500 cursor motion with <left> and <right> arrow keys.
1501
1502 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1503 some callers set that themselves.
1504
b00eea75
EZ
15052011-10-12 Eli Zaretskii <eliz@gnu.org>
1506
1507 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1508 display string and the previous row comes from the same string and
1509 is empty. (Bug#9739) (Bug#9738)
1510
8fe012c4
SM
15112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1512
1513 * doc.c (get_doc_string): Encode file name (bug#9735).
1514
0074aef2
EZ
15152011-10-12 Eli Zaretskii <eliz@gnu.org>
1516
79beb178
EZ
1517 * bidi.c (bidi_level_of_next_char):
1518 * xdisp.c (get_visually_first_element): Remove old incorrect
1519 comments regarding the Unicode Line Separator character.
1520
0074aef2
EZ
1521 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1522
6e4b3fbe
DA
15232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1524
1525 * alloc.c (Fgc_status): Do not access beyond zombies array
1526 boundary if nzombies > MAX_ZOMBIES.
1527 * alloc.c (dump_zombies): Add missing format specifier.
1528
0324f3af
PE
15292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1530
b5525cac
PE
1531 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1532 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1533
0324f3af
PE
1534 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1535 Some packages use them to denote characters with modifiers.
1536
e9b5f888
AS
15372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1538
1539 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1540 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1541 matching a pp-number. Rename parameter var to var1.
1542
127827c0
SM
15432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1544
1545 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1546
c8fd3bd0
GM
15472011-10-08 Glenn Morris <rgm@gnu.org>
1548
1549 * callint.c (Fcall_interactively): Give a more explicit error for the
1550 'c' case with a non-character input. (Bug#8479)
1551
352ec8ff
EZ
15522011-10-08 Eli Zaretskii <eliz@gnu.org>
1553
03669ccb
EZ
1554 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1555 lines.
7061c986
EZ
1556 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1557 lines that are hscrolled on the left.
03669ccb 1558
352ec8ff
EZ
1559 * dispnew.c (buffer_posn_from_coords): Account for a possible
1560 presence of header-line. (Bug#4426)
1561
a66cfb1c
SM
15622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1563
6b02f655
SM
1564 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1565 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1566
7c5ee88e
PE
15672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1570 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1571 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1572 this makes Emacs dump core during garbage collection on rare
1573 occasions. sizeof is obviously inferior to offsetof here, so
1574 stick with offsetof.
1575 (GC_POINTER_ALIGNMENT): New macro.
1576 (mark_memory): Omit 3rd (offset) arg; caller changed.
1577 Don't assume EMACS_INT alignment is the same as pointer alignment.
1578
df1bbe5b
SM
15792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1580
1581 * keyboard.c (read_key_sequence_remapped): New var.
1582 (read_key_sequence): Compute remapping in the right buffer.
1583 (command_loop_1): Use read_key_sequence's remapping directly.
1584
51553db6
SM
15852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1586
32c1fffd
SM
1587 * dired.c (file_name_completion): Don't expand file name.
1588 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1589 before checking file name handler.
1590
51553db6
SM
1591 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1592 they've been requested explicitly (bug#9591).
1593
b6bd1599 15942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1595
1596 * keymap.c (Fsingle_key_description): Use make_specified_string
1597 instead of build_string to build string from push_key_description.
1598 (Bug#5193)
1599
f701dc2a
PE
16002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1601
4222c55d
PE
1602 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1603 This fixes a Y2038 bug on 64-bit hosts.
1604 * buffer.c (reset_buffer):
1605 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1606 (Fclear_buffer_auto_save_failure):
1607 Use 0, not -1, to represent an unset failure time, since time_t
1608 might not be signed.
1609
f701dc2a
PE
1610 Remove dependency on glibc malloc internals.
1611 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1612 Move back here from lisp.h, but with their new implementations.
1613 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1614 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1615 * charset.c (charset_table_init): New static var.
1616 (syms_of_charset): Use it instead of xmalloc. This removes a
1617 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1618 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1619 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1620 Move back to alloc.c.
1621 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1622 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1623
9ceebf39
JD
16242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1625
1626 * nsterm.m (windowDidResize): Call x_set_window_size only when
1627 ns_in_resize is true. Otherwise set pixelwidth/height and
1628 call change_frame_size (Bug#9628).
1629
cb993c58
PE
16302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1631
3930c88b
PE
1632 Port --enable-checking=all to Fedora 14 x86-64.
1633 * charset.c (syms_of_charset): Also account for glibc malloc's
1634 internal overhead when calculating the initial malloc maximum.
1635
cb993c58
PE
1636 Port --enable-checking=all to Fedora 14 x86.
1637 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1638 Move to lisp.h.
1639 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1640 (overrun_check_realloc, overrun_check_free):
1641 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1642 That way, xmalloc returns a properly-aligned pointer even if
1643 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1644 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1645 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1646 into account when calculating the initial malloc maximum.
1647 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1648 Move here from alloc.c, so that charset.c can use it too.
1649 Properly align; the old code wasn't right for common 32-bit hosts
1650 when configured with --enable-checking=all.
1651 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1652 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1653
31bed486
EZ
16542011-09-29 Eli Zaretskii <eliz@gnu.org>
1655
04c70788 1656 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1657 use EDOM.
1658
fbcaa2f3
EZ
16592011-09-28 Eli Zaretskii <eliz@gnu.org>
1660
1661 * xdisp.c (compute_display_string_end): If there's no display
1662 string at CHARPOS, return -1.
1663
1664 * bidi.c (bidi_fetch_char): When compute_display_string_end
1665 returns a negative value, treat the character as a normal
1666 character not covered by a display string. (Bug#9624)
1667
a239d4e9
JB
16682011-09-28 Juanma Barranquero <lekktu@gmail.com>
1669
1670 * lread.c (Fread_from_string): Fix typo in docstring.
1671
88652fd5
EZ
16722011-09-27 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1675 newline, reseat the iterator instead of bidi-iterating there one
1676 character at a time. (Bug#9610)
32c1fffd
SM
1677 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1678 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1679
ed497dd4
AS
16802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1681
1682 * lread.c (readevalloop): Use correct code for NBSP.
1683 (read1): Likewise. (Bug#9608)
1684
b2bf61aa
MA
16852011-09-25 Michael Albinus <michael.albinus@gmx.de>
1686
1687 * dbusbind.c (Fdbus_register_signal): When service is not
1688 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1689
32bbb17c
GM
16902011-09-25 Glenn Morris <rgm@gnu.org>
1691
1692 * buffer.c (truncate-lines): Doc fix.
1693
94e0933e
CY
16942011-09-24 Chong Yidong <cyd@stupidchicken.com>
1695
1696 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1697 (Fset_window_next_buffers): Doc fix.
1698
cddde921
GM
16992011-09-24 Glenn Morris <rgm@gnu.org>
1700
1701 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1702
1260aef1
PE
17032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1704
25b4bfa0
PE
1705 Fix minor problems found by static checking.
1706 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1707 * indent.c (Fvertical_motion): Fix == vs = typo.
1708
e3cbd34b
EZ
17092011-09-24 Eli Zaretskii <eliz@gnu.org>
1710
a66cfb1c
SM
1711 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1712 Default value is now t. Doc fix.
6bf7006f 1713
e3cbd34b 1714 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1715 logic when moving up, not only when moving down. Fix the
e3cbd34b 1716 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1717 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1718
1719 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1720 CHARPOS is covered by a display string which includes newlines.
1721 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1722 is covered by a display string with embedded newlines.
1723
a3de0cbd
MA
17242011-09-24 Michael Albinus <michael.albinus@gmx.de>
1725
1726 * dbusbind.c (Fdbus_register_signal): Add match rule to
1727 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1728 (Fdbus_register_method, Vdbus_registered_objects_table):
1729 Fix docstring.
a3de0cbd 1730
b260039d
JM
17312011-09-24 Jim Meyering <meyering@redhat.com>
1732
32c1fffd 1733 do not ignore write error for any output size
b260039d
JM
1734 The previous change was incomplete.
1735 While it makes emacs --batch detect the vast majority of stdout
1736 write failures, errors were still ignored whenever the output size is
1737 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1738 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1739 && echo FAIL: ignored write error
1740 FAIL: ignored write error
1741 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1742 && echo FAIL: ignored write error
1743 FAIL: ignored write error
1744 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1745
8eca8a7c
AS
17462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1747
1748 * emacs.c (Fkill_emacs): In noninteractive mode exit
1749 non-successfully if a write error occurred on stdout. (Bug#9574)
1750
3341db62
EZ
17512011-09-21 Eli Zaretskii <eliz@gnu.org>
1752
1753 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1754 the xassert test.
1755
1756 * dispextern.h (struct it): Update the comment documenting what
1757 can it->OBJECT be.
1758
8c203dbf
EZ
17592011-09-20 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1762 a display string, extend search for cursor position to end of row.
1763 (find_row_edges): If the row ends in a newline from a display
1764 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1765 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1766 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1767 non-empty line. Fixes confusing cursor motion with arrow keys at
1768 the beginning of a line that starts with whitespace.
8c203dbf 1769
a4824228
LMI
17702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1771
1772 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1773 (bug#9493).
1774
33ed493b
CY
17752011-09-18 Chong Yidong <cyd@stupidchicken.com>
1776
1777 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1778 boolean (Bug#9154).
1779
56cd55c8
EZ
17802011-09-18 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (display_line): Record maximum and minimum buffer
1783 positions even if no glyphs were produced (e.g., by a zero-width
1784 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1785 buffer positions that will be removed from the glyph row because
1786 they don't fit.
c02dcedf
EZ
1787 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1788 column is beyond frame width: don't subtract 1 "pixel" when
1789 computing width of the stretch.
3e62b7e0
EZ
1790 (reseat_at_next_visible_line_start): Undo the change made on
1791 2011-09-17 that saved paragraph information and restored it after
1792 the call to `reseat'. (Bug#9545)
56cd55c8 1793
5ed99d36 17942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1795
1796 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1797 and turn window cursor on if cleared (Bug#9415).
1798
5ed99d36 17992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1800
1801 * search.c (boyer_moore): Take unibyte characters from pattern
1802 literally. (Bug#9458)
1803
9bade7b2
EZ
18042011-09-18 Eli Zaretskii <eliz@gnu.org>
1805
1806 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1807
e5e9d610
PE
18082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1809
87e4427a
PE
1810 Fix minor problem found by static checking.
1811 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1812 initialized, to pacify gcc -Wuninitialized.
1813
e5e9d610
PE
1814 * fileio.c: Report proper errno when syscall falls.
1815 (Finsert_file_contents): Save and restore errno,
1816 so that report_file_error outputs the correct diagnostic.
1817 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1818
a1674f0b
EZ
18192011-09-18 Eli Zaretskii <eliz@gnu.org>
1820
1821 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1822
fbfb6dd4
EZ
18232011-09-17 Eli Zaretskii <eliz@gnu.org>
1824
1825 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1826 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1827
bb187662
EZ
18282011-09-17 Eli Zaretskii <eliz@gnu.org>
1829
1137e8b8 1830 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1831 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1832
1833 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1834 (bidi_find_paragraph_start): Search back for paragraph beginning
1835 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1836 (bidi_move_to_visually_next): Only trigger paragraph-related
1837 computations when the last character is a newline or at EOB, not
1838 just any NEUTRAL_B. (Bug#9470)
1839
bb187662
EZ
1840 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1841 truncated lines if point is covered by a display string. (Bug#9524)
1842
2e621251
PE
18432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1846 (cons_to_x_long): New function.
1847 (lisp_data_to_selection_data): Use it. Correct the test for
1848 short-versus-long data; it was negated. Break out of vector
1849 loop, for efficiency, when a long datum is discovered.
1850
91a15bc6
SM
18512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1852
1853 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1854
b41c3a35
EZ
18552011-09-16 Eli Zaretskii <eliz@gnu.org>
1856
1857 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1858 GCC PR/17406) by declaring this function with external scope.
1859
7812ba2d
PE
18602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1861
1862 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1863 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1864
cf7edc2a
AS
18652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1866
1867 * editfns.c (Fformat): Correctly handle text properties on "%%".
1868
bd01620e
EZ
18692011-09-15 Eli Zaretskii <eliz@gnu.org>
1870
1871 * xterm.c (x_draw_composite_glyph_string_foreground):
1872 * w32term.c (x_draw_composite_glyph_string_foreground):
1873 * term.c (encode_terminal_code):
1874 * composite.c (composition_update_it, get_composition_id):
1875 * xdisp.c (get_next_display_element)
1876 (fill_composite_glyph_string): Add comments about special meaning
1877 of TAB characters in a composition.
1878
a02719a3
PE
18792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1882 This occurs when processing a multibyte format.
1883 Problem reported by Wolfgang Jenker.
a02719a3 1884
72589a3c
JB
18852011-09-15 Johan Bockgård <bojohan@gnu.org>
1886
1887 * xdisp.c (try_cursor_movement): Only check for exact match if
1888 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1889
1c14176c
PE
18902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 Remove unused external symbols.
1893 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1894 * xdisp.c (calc_pixel_width_or_height): Now static.
1895 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1896 * indent.c (check_display_width):
1897 * w32term.c: Fix comment to match code.
1898 * xterm.c, xterm.h (x_catching_errors): Remove.
1899
d2eea5b5
PE
19002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 * xselect.c: Use signed conversions more consistently (Bug#9498).
1903 (selection_data_to_lisp_data): Assume incoming selection data are
1904 signed integers, not unsigned. This is to be consistent with
1905 outgoing selection data, which was modified to use signed integers
1906 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1907 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1908 expects long, not unsigned long.
1909
46888499
EZ
19102011-09-14 Eli Zaretskii <eliz@gnu.org>
1911
1912 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1913 computation of loop end. Reported by Johan Bockgård
1914 <bojohan@gnu.org>.
1915
ef8ef9fb
CY
19162011-09-13 Chong Yidong <cyd@stupidchicken.com>
1917
1918 * frame.c (Fother_visible_frames_p): Function deleted.
1919
fa819fed
EZ
19202011-09-12 Eli Zaretskii <eliz@gnu.org>
1921
1922 * indent.c (compute_motion): Process display vector front to back
1923 rather than the other way around. (Bug#2496)
1924
2ba8e008
SM
19252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1926
1927 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1928
20f53c69
CY
19292011-09-11 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * minibuf.c (Fread_from_minibuffer): Doc fix.
1932
d562d7a4
EZ
19332011-09-11 Eli Zaretskii <eliz@gnu.org>
1934
1935 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1936 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1937
1c4d7f3d
LMI
19382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1939
1940 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1941 value for non-existent files.
1942
b885bf36
EZ
19432011-09-11 Eli Zaretskii <eliz@gnu.org>
1944
1945 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1946 set its "size" to -1. This will set the modtime_size field of
1947 the corresponding buffer to -1, which is what
1948 verify-visited-file-modtime expects for files that do not exist.
1949 (Bug#9139)
1950
6612f0bf
PE
19512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1954 here ...
1955 * lisp.h: ... from here. push_key_description is no longer
1956 defined in keyboard.c, so its declaration should not be in
1957 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1958 logically belongs with push_key_description.
1959
dfb3f755
PE
19602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 * buffer.h: Include <sys/types.h> instead of <time.h>.
1963 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1964 Problem reported by Herbert J. Skuhra.
1965
3134906c
LMI
19662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1967
1968 * xml.c (parse_region): Make the parsing work for
1969 non-comment-starting XML files again (bug#9144).
1970
8d903f4e
AS
19712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1972
1973 * image.c (gif_load): Fix calculation of bottom and right corner.
1974 (Bug#9468)
1975
80ad64f4
EZ
19762011-09-10 Eli Zaretskii <eliz@gnu.org>
1977
1978 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1979 redisplay in small windows.
1980
208a048d
EZ
19812011-09-09 Eli Zaretskii <eliz@gnu.org>
1982
1983 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1984
9b1c252e
MR
19852011-09-08 Martin Rudalics <rudalics@gmx.at>
1986
1987 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1988 Operate on live windows only.
1989
2949f33b
JB
19902011-09-08 Juanma Barranquero <lekktu@gmail.com>
1991
1992 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1993
e08dcafd
EZ
19942011-09-07 Eli Zaretskii <eliz@gnu.org>
1995
1996 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1997 only under bidi iteration.
1998
115b96bd
JD
19992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2000
2001 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2002
c8199d0f
PE
20032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2006 Without this fix, the command to link temacs failed due to an
2007 undefined symbol __builtin_isnan. This is because
2008 /usr/include/iso/math_c99.h #defines isnan(x) to
2009 __builtin_isnan(x), but the bundled gcc, which identifies itself
2010 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2011 a __builtin_isnan.
2012 * floatfns.c (isnan): #undef, and then #define to a clone of
2013 what's in data.c.
2014 (Fisnan): Always define, since it's always available now.
2015 (syms_of_floatfns): Always define isnan at the Lisp level.
2016
e39b275c 20172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2018
2019 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2020
b2db44d9 20212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2022
f4af5137 2023 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2024 The previous code assumed that file offsets (off_t values) fit in
2025 EMACS_INT variables, which is not true on typical 32-bit hosts.
2026 The code messed up by falsely reporting buffer overflow in cases
2027 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2028 when "big" contains more than 2**29 bytes, even though this
2029 inserts just one byte and does not overflow the buffer.
2030 (Finsert_file_contents): Store file offsets as off_t
2031 values, not as EMACS_INT values. Check for overflow when
2032 converting between EMACS_INT and off_t. When checking for
2033 buffer overflow or for overlap, take the offsets into account.
2034 Don't use EMACS_INT for small values where int suffices.
2035 When checking for overlap, fix a typo: ZV was used where
2036 ZV_BYTE was intended.
2037 (Fwrite_region): Don't assume off_t fits into 'long'.
2038 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2039
ecfc0a49
MA
20402011-09-05 Michael Albinus <michael.albinus@gmx.de>
2041
2042 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2043
6511acf2 20442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2045
0999621a 2046 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2047
2048 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2049 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2050 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2051 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2052 (modify_event_symbol): Do not assume that the length of
2053 name_alist_or_stem is safe to alloca and fits in int.
2054 (Fexecute_extended_command): Likewise for function name and binding.
2055 (Frecursion_depth): Wrap around reliably on integer overflow.
2056 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2057 since some callers pass EMACS_INT values.
2058 (Fsingle_key_description): Don't crash if symbol name contains more
2059 than MAX_ALLOCA bytes.
2060 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2061 (get_minibuffer): Arg is now EMACS_INT, not int.
2062 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2063 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2064 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2065
2be7d702
PE
2066 * dbusbind.c (signature_cat): New function.
2067 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2068 Do not overrun buffer; instead, report string overflow.
2069
9d1df220
PE
2070 * dispnew.c (add_window_display_history): Don't overrun buffer.
2071 Truncate instead; this is OK since it's just a log.
2072
33ef5c64
PE
2073 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2074 even if the time zone offset is outlandishly large.
2075 Don't mishandle offset == INT_MIN.
2076
66c6fdd5
PE
2077 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2078 when creating daemon; the previous buffer-overflow check was incorrect.
2079
d749b01b
PE
2080 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2081 which has the guts of the old verror function.
2082
b5cd1905
PE
2083 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2084 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2085
6e1a67fb
PE
2086 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2087 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2088 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2089 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2090 length of string rather than counting it via multiple sprintfs;
2091 that's simpler and more reliable.
c21721cc
PE
2092 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2093 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2094 sprintf, in case result does not fit in int.
2095
c57b67fc
PE
2096 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2097 (fontset_from_font): Print it.
2098
8a401434
PE
2099 * frame.c (tty_frame_count): Now printmax_t, not int.
2100 (make_terminal_frame, set_term_frame_name): Print it.
2101 (x_report_frame_params): In X, window IDs are unsigned long,
2102 not signed long, so print them as unsigned.
2103 (validate_x_resource_name): Check for implausibly long names,
2104 and don't assume name length fits in 'int'.
2105 (x_get_resource_string): Don't blindly alloca invocation name;
2106 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2107 not fit in int.
2108
6e1a67fb
PE
2109 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2110 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2111 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2112
0df02bf3
PE
2113 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2114 Use esprintf, not sprintf, in case result does not fit in int.
2115
48e30793
PE
2116 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2117 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2118 it as a large positive number.
2119 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2120 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2121
a66ff6d8
PE
2122 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2123 in case result does not fit in int.
2124
aca216ff
PE
2125 * print.c (float_to_string): Detect width overflow more reliably.
2126 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2127 buffer overrun. Don't assume list length fits in 'int'. Treat
2128 print length of 0 as 0, not as infinity; to be consistent with other
2129 uses of print length in this function. Don't overflow print length
2130 index. Don't assume hash table size fits in 'long', or that
2131 vectorlike size fits in 'unsigned long'.
2132
31c286f7
PE
2133 * process.c (make_process): Use printmax_t, not int, to format
2134 process-name gensyms.
2135
55e5faa1
PE
2136 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2137
80f2e268
PE
2138 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2139 to avoid potential buffer overrun.
2140
670741ab
PE
2141 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2142 if X resource line is longer than 512 bytes.
2143
b7163a50
PE
2144 * xfns.c (x_window): Make sprintf buffer a bit bigger
2145 to avoid potential buffer overrun.
2146
ae58ff1f
PE
2147 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2148
c43c8a6a
PE
2149 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2150
3f8236f4
PE
21512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2152
53e9fe90 2153 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2154 Without these, Emacs silently mishandles large integers sometimes.
2155 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2156 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2157
6511acf2
PE
2158 * xdisp.c (try_window_id): Check Emacs fixnum range before
2159 converting to 'int'.
806add1d 2160
6511acf2 2161 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2162 Check that an Emacs fixnum is in range before assigning it to 'int'.
2163 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2164 values converted from Emacs fixnums.
2165 (Frecenter): Don't wrap around a line count if it is out of 'int'
2166 range; instead, treat it as an extreme value.
2167 (Fset_window_configuration, compare_window_configurations):
2168 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2169
6511acf2
PE
2170 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2171 that can exceed INT_MAX. Check that EMACS_INT value is in range
2172 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2173 (match_limit): Don't assume that a fixnum can fit in 'int'.
2174
6511acf2 2175 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2176 exceed INT_MAX.
2177
6511acf2 2178 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2179 (Fvertical_motion): Don't wrap around LINES values that don't fit
2180 in 'int'. Instead, treat them as extreme values. This is good
2181 enough for windows, which can't have more than INT_MAX lines anyway.
2182
fcb901a7
LMI
21832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2184
0f2f6b6d
LMI
2185 * Require libxml/parser.h to avoid compilation warning.
2186
fcb901a7
LMI
2187 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2188
2189 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2190 since this reportedly can destroy thread storage.
2191
6e20a0d4
CY
21922011-08-30 Chong Yidong <cyd@stupidchicken.com>
2193
2194 * syntax.c (find_defun_start): Update all cache variables if
2195 exiting early (Bug#9401).
2196
148ae00e
EZ
21972011-08-30 Eli Zaretskii <eliz@gnu.org>
2198
f6cfbd8f
EZ
2199 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2200
148ae00e
EZ
2201 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2202 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2203 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2204
2205 * term.c (tty_append_glyph): New function.
2206 (produce_stretch_glyph): Static function and its prototype deleted.
2207
a66cfb1c
SM
2208 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2209 Add prototypes.
148ae00e 2210
c4a07a4c
PE
22112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2214 when checking :margin (Bug#9390).
2215 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2216 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2217 so that the name doesn't mislead. All uses changed.
2218
6bc8cd65
JB
22192011-08-28 Johan Bockgård <bojohan@gnu.org>
2220
2221 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2222 set_tty_hooks.
2223
dca4927e
EZ
22242011-08-27 Eli Zaretskii <eliz@gnu.org>
2225
2226 * xdisp.c (move_it_to): Don't bail out early when reaching
2227 position beyond to_charpos, if we are scanning backwards.
2228 (move_it_vertically_backward): When DY == 0, make sure we get to
2229 the first character in the line after the newline.
2230
f2cad773
PE
22312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2234 (ccl_driver): Do not generate an out-of-range pointer.
2235 (Fccl_execute_on_string): Remove unnecessary check for
2236 integer overflow, noted by Stefan Monnier in
2237 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2238 Remove a FIXME that didn't need fixing.
2239 Simplify the newly-introduced buffer reallocation code.
2240
0cae2cdb
JB
22412011-08-27 Juanma Barranquero <lekktu@gmail.com>
2242
2243 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2244
5fc295a4 22452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2246
70c60eb2 2247 Integer and memory overflow issues (Bug#9196).
726e0ab1 2248
d31850da
PE
2249 * doc.c (get_doc_string): Rework so that
2250 get_doc_string_buffer_size is the actual buffer size, rather than
2251 being 1 less than the actual buffer size; this makes xpalloc more
2252 convenient.
2253
a69fbedb
PE
2254 * image.c (x_allocate_bitmap_record, cache_image):
2255 * xselect.c (Fx_register_dnd_atom):
2256 Simplify previous changes by using xpalloc.
2257
fe5c5d37
PE
2258 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2259 since either will do and ptrdiff_t is convenient with xpalloc.
2260
0065d054
PE
2261 * charset.c (charset_table_size)
2262 (struct charset_sort_data.priority): Now ptrdiff_t.
2263 (charset_compare): Don't overflow if priorities differ greatly.
2264 (Fsort_charsets): Don't assume list length fits in int.
2265 Check for size-calculation overflow when allocating sort data.
2266 (syms_of_charset): Allocate an initial charset table that is
2267 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2268
2269 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2270
2271 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2272 The actual value is always <= INT_MAX, and leaving it unsigned made
2273 overflow checking harder.
2274
2275 * dispextern.h (struct glyph_matrix.rows_allocated)
2276 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2277 with xpalloc. The values are still always <= INT_MAX.
2278
2279 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2280
2281 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2282 (SAFE_NALLOCA): New macro.
2283
2284 * region-cache.c (struct boundary.pos, find_cache_boundary)
2285 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2286 (set_cache_region, invalidate_region_cache)
2287 (revalidate_region_cache, know_region_cache, region_cache_forward)
2288 (region_cache_backward, pp_cache):
2289 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2290 so that ptrdiff_t * can be passed to xpalloc.
2291 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2292 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2293 (pp_cache): Don't assume cache_len fits in int.
2294 * region-cache.h: Adjust extern decls to match.
2295
2296 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2297 EMACS_INT, since either will do, for xpalloc.
2298
2299 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2300 (xnmalloc, xnrealloc, xpalloc): New functions.
2301
726e0ab1
PE
2302 * bidi.c (bidi_shelve_header_size): New constant.
2303 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2304 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2305
51f30bc5 2306 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2307 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2308 (overlay_strings):
2309 Don't update size of array until after memory allocation succeeds,
2310 because xmalloc/xrealloc may not return.
0065d054
PE
2311 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2312 now that we have proper integer overflow checking.
2313 (record_overlay_string, overlay_strings): Catch overflows when
2314 calculating size of overlay_str_buf.
726e0ab1 2315
0065d054
PE
2316 * callproc.c (Fcall_process): Check for size overflow when
2317 calculating size of args2.
2318 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2319 Normally we prefer signed values, but sticking with ptrdiff_t would
2320 require adding more-complicated checks.
726e0ab1
PE
2321
2322 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2323 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2324 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2325 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2326
2327 * character.c (Fstring): Check for size-calculation overflow.
2328
2329 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2330 unnecessary integer overflow. Check for size overflow.
2331 (encode_coding_object): Don't update size until xmalloc succeeds.
2332
2333 * composite.c (get_composition_id): Check for overflow in glyph
2334 length calculations.
2335
2336 Integer and memory overflow fixes for display code.
2337 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2338 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2339 (scrolling_window): Check for overflow in size calculations.
2340 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2341 Don't assume glyph table len fits in int.
2342 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2343 (row_table_size): Now ptrdiff_t, not int.
2344 (scrolling_window): Avoid overflow in size calculations.
2345 Don't update size until allocation succeeds.
2346 * fns.c (concat): Check for overflow in size calculations.
2347 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2348 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2349 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2350
2351 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2352 (get_doc_string): Check for size calculation overflow.
2353 Don't update size until allocation succeeds.
2354 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2355 EMACS_INT, where ptrdiff_t will do.
2356 (Fsubstitute_command_keys): Check for string overflow.
2357
2358 * editfns.c (set_time_zone_rule): Don't assume environment length
2359 fits in int.
2360 (message_length): Now ptrdiff_t, not int.
2361 (Fmessage_box): Don't update size until allocation succeeds.
2362 Don't assume message length fits in int.
2363 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2364
0065d054
PE
2365 * emacs.c (main): Do not reallocate argv, since there is a null at
2366 the end that can be overwritten, and this way there's no need to
2367 worry about size-calculation overflow.
2368 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2369
2370 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2371 alloc succeeds.
2372 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2373
2374 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2375 (x_set_scroll_bar_width, x_figure_window_size):
2376 Check for integer overflow.
2377 (x_set_alpha): Do not assume XINT fits in int.
2378
2379 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2380 This is for the members text_lines, text_cols, total_lines, total_cols,
2381 where the system imposes an 'int' limit.
2382
2383 * fringe.c (Fdefine_fringe_bitmap):
2384 Don't update size until alloc works.
2385
2386 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2387 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2388
2389 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2390 Check for size-calculation overflow.
2391 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2392 do, as we prefer signed integers.
2393 (id_to_widget.max_size, id_to_widget.used)
2394 (xg_store_widget_in_map, xg_remove_widget_from_map)
2395 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2396 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2397 Use and return ptrdiff_t, not int.
2398 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2399 * gtkutil.h: Change prototypes to match the above.
2400
2401 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2402 are duplicate now that they've been promoted to lisp.h.
2403 (x_allocate_bitmap_record, x_alloc_image_color)
2404 (make_image_cache, cache_image, xpm_load):
2405 Don't update size until alloc is done.
2406 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2407 (x_detect_edges):
3256efce 2408 Check for size calculation overflow.
726e0ab1
PE
2409 (ct_colors_allocated_max): New constant.
2410 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2411 overflow.
3256efce 2412
726e0ab1
PE
2413 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2414 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2415 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2416 Use ptrdiff_t, not int, to count maps.
2417 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2418 calculations. Don't update size until allocation succeeds.
2419 Redo calculations to avoid overflow.
726e0ab1
PE
2420 * keyboard.h: Change prototypes to match the above.
2421
2422 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2423 to count maps.
2424 (current_minor_maps): Check for size calculation overflow.
2425 * keymap.h: Change prototypes to match the above.
2426
2427 * lread.c (read1, init_obarray): Don't update size until alloc done.
2428
2429 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2430 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2431
726e0ab1
PE
2432 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2433 Now ptrdiff_t, not int.
2434 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2435 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2436
2437 * process.c (Fnetwork_interface_list): Check for overflow
2438 in size calculation.
2439
2440 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2441
2442 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2443 overflow. Don't bother calling xmalloc when xrealloc will do.
2444
2445 * search.c (Freplace_match): Check for size calculation overflow.
2446 (Fset_match_data): Don't assume list lengths fit in 'int'.
2447
2448 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2449 for command line length. Do not attempt to address one before the
2450 beginning of an array, as that's not portable.
2451
2452 * term.c (max_frame_lines): Remove; unused.
2453 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2454 not int.
2455 (encode_terminal_code, calculate_costs): Check for size
2456 calculation overflow.
2457 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2458 table lengths and related sizes. Don't update size until alloc
2459 done. Redo calculations to avoid overflow.
2460 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2461
2462 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2463 subtracting pointers.
2464 (gobble_line): Check for overflow more carefully. Don't update size
2465 until alloc done.
2466
2467 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2468 Don't update size until alloc done.
2469 Redo size calculations to avoid overflow.
2470 Check for size calculation overflow.
0065d054 2471 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2472
2473 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2474 Use ptrdiff_t, not int, for sizes.
2475 (store_mode_line_noprop_char): Don't update size until alloc done.
2476
0065d054
PE
2477 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2478 Use ptrdiff_t, not int, for sizes.
2479 (Finternal_make_lisp_face, cache_face):
2480 Check for size calculation overflow.
2481 (cache_face): Treat size calculation overflows as if they were
2482 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2483
2484 * xfns.c (x_encode_text, x_set_name_internal)
2485 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2486 sizes, since they can exceed INT_MAX in size. Check for size
2487 calculation overflow.
2488
0065d054
PE
2489 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2490 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2491 Don't update size until alloc done.
2492
0065d054 2493 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2494 as sprintf is limited to int lengths.
1d526e2f 2495
252c5ee1
PE
2496 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2497 (X_LONG_MIN): New macros.
864d7ce7
PE
2498 Use them to make the following changes clearer.
2499 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2500 This change doesn't affect the value now, but it may help remind
2501 future maintainers not to raise the value too much later.
2502 (SELECTION_QUANTUM): Remove, replacing with ...
2503 (selection_quantum): ... new function, which avoids overflow.
2504 All uses changed.
2505 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2506 assumption that selection length fits in 'int'.
2507 (x_reply_selection_request, x_handle_selection_request)
2508 (x_get_window_property, receive_incremental_selection)
2509 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2510 (lisp_data_to_selection_data, clean_local_selection_data):
2511 Use ptrdiff_t, not int, to record length of selection.
2512 (x_reply_selection_request, x_get_window_property)
2513 (receive_incremental_selection, x_property_data_to_lisp):
2514 Redo calculations to avoid overflow.
2515 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2516 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2517 something.
2518 (x_get_window_property, receive_incremental_selection)
2519 (lisp_data_to_selection_data, x_property_data_to_lisp):
2520 Check for size-calculation overflow.
2521 (x_get_window_property, receive_incremental_selection)
2522 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2523 Don't store size until memory allocation succeeds.
2524 (x_get_window_property): Plug memory leak on memory exhaustion.
2525 Don't double-block input; malloc is safe here. Don't assume 2**34
2526 - 4 fits in unsigned long. Add an xassert to check
2527 XGetWindowProperty overflow. Be more careful about overflow
2528 calculations, and distinguish size from memory overflow better.
2529 (receive_incremental_selection): When tracing, don't assume
2530 unsigned int is less than INT_MAX.
2531 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2532 harmful) conversions of unsigned short to int.
2533 (lisp_data_to_selection_data): Don't assume that integers
2534 in the range -65535 through -1 fit in an X unsigned short.
2535 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2536 result parameters unless successful. Rely on cons_to_unsigned
2537 to report problems with elements; the old code wasn't right anyway.
2538 (x_check_property_data): Check for int overflow; we cannot use
2539 a wider type due to X limits.
2540 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2541
726e0ab1 2542 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2543
0065d054
PE
2544 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2545 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2546 (x_color_cells): Don't store size until memory allocation succeeds.
2547 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2548 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2549 (x_term_init): Don't assume length fits in int (sprintf is limited
2550 to int size).
bc18e09d 2551
ebfa62c0
PE
2552 Use ptrdiff_t for composition IDs.
2553 * character.c (lisp_string_width):
2554 * composite.c (composition_table_size, n_compositions)
2555 (get_composition_id, composition_gstring_from_id):
2556 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2557 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2558 * window.c (Frecenter):
2559 Use ptrdiff_t, not int, for composition IDs.
2560 * composite.c (get_composition_id): Check for integer overflow.
2561 * composite.h: Adjust prototypes to match the above changes.
2562
d3411f89
PE
2563 Use ptrdiff_t for hash table indexes.
2564 * category.c (hash_get_category_set):
2565 * ccl.c (ccl_driver):
2566 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2567 * coding.c (coding_system_charset_list, detect_coding_system):
2568 * coding.h (struct coding_system.id):
2569 * composite.c (get_composition_id, gstring_lookup_cache):
2570 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2571 * image.c (xpm_get_color_table_h):
2572 * lisp.h (hash_lookup, hash_put):
2573 * minibuf.c (Ftest_completion):
2574 Use ptrdiff_t for hash table indexes, not int (which is too
2575 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2576 32-bit --with-wide-int hosts).
2577
e097a6fa
PE
2578 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2579 Add a FIXME comment about memory leaks.
2580 (syms_of_charset): Don't assume xmalloc returns.
2581
5637687f
PE
2582 Don't assume that stated character widths fit in int.
2583 * character.c (Fchar_width, c_string_width, lisp_string_width):
2584 * character.h (CHAR_WIDTH):
2585 * indent.c (MULTIBYTE_BYTES_WIDTH):
2586 Use sanitize_char_width to avoid undefined and/or bad behavior
2587 with outlandish widths.
a66cfb1c 2588 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2589 now that we have two such functions. All uses changed.
2590 (sanitize_char_width): New inline function.
2591
a2271ba2
PE
2592 Don't assume that tab-width fits in int.
2593 * character.h (sanitize_width): New inline function.
2594 (SANE_TAB_WIDTH): New macro.
2595 (ASCII_CHAR_WIDTH): Use it.
2596 * indent.c (sane_tab_width): Remove. All uses replaced by
2597 SANE_TAB_WIDTH (current_buffer).
2598 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2599
18c52557
PE
2600 * fileio.c: Integer overflow issues with file modes.
2601 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2602
caeeedc1
PE
2603 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2604 Remove unreachable code.
2605 (read_hex, load_charset_map_from_file): Check for integer overflow.
2606
6df6ae42 2607 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2608 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2609 (x_send_scroll_bar_event): Likewise. Check that the size does not
2610 exceed limits imposed by XClientMessageEvent, as well as the usual
2611 ptrdiff_t and size_t limits.
2612
b13995db
PE
2613 * keyboard.c: Overflow, signedness and related fixes.
2614 (make_lispy_movement): Use same integer type in forward decl
2615 that is used in the definition.
2616 (read_key_sequence, keyremap_step):
2617 Change bufsize argument back to int, undoing my 2011-03-30 change.
2618 We prefer signed types, and int is wide enough here.
2619 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2620 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2621 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2622 length, not size_t. Use ptrdiff_t for index, not int.
2623 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2624 possibility of integer overflow.
2625
13464394
PE
2626 Overflow, signedness and related fixes for images.
2627
2628 * dispextern.h (struct it.stack[0].u.image.image_id)
2629 (struct_it.image_id, struct image.id, struct image_cache.size)
2630 (struct image_cache.used, struct image_cache.ref_count):
2631 * gtkutil.c (update_frame_tool_bar):
2632 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2633 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2634 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2635 * nsmenu.m (update_frame_tool_bar):
2636 * xdisp.c (calc_pixel_width_or_height):
2637 * xfns.c (image_cache_refcount):
2638 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2639 on typical 64-bit hosts.
2640
2641 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2642 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2643 Omit unnecessary casts to int.
2644 (parse_image_spec): Check that integers fall into 'int' range
2645 when the callers expect that.
2646 (image_ascent): Redo ascent calculation to avoid int overflow.
2647 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2648 (lookup_image): Remove unnecessary tests.
2649 (xbm_image_p): Locals are now of int, not EMACS_INT,
2650 since parse_image_check makes sure they fit into int.
2651 (png_load, gif_load, svg_load_image):
2652 Prefer int to unsigned where either will do.
2653 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2654 old tiff_error_handler and tiff_warning_handler.
2655 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2656 stack buffer overflows. It uses only the features of vsnprintf
2657 that are common to both POSIX and native Microsoft.
2658 (tiff_error_handler, tiff_warning_handler): Use it.
2659 (tiff_load, gif_load, imagemagick_load_image):
2660 Don't assume :index value fits in 'int'.
2661 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2662 (imagemagick_load_image): Check that crop parameters fit into
2663 the integer types that MagickCropImage accepts. Don't assume
2664 Vimagemagick_render_type has a nonnegative value. Don't assume
2665 size_t fits in 'long'.
2666 (gs_load): Use printmax_t to print the widest integers possible.
2667 Check for integer overflow when computing image height and width.
2668
c11821d4
EZ
26692011-08-26 Eli Zaretskii <eliz@gnu.org>
2670
2671 * xdisp.c (redisplay_window): Don't force window start if point
2672 will be invisible in the resulting window. (Bug#9324)
2673
0c95fcf7
EZ
26742011-08-25 Eli Zaretskii <eliz@gnu.org>
2675
2676 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2677 the display spec is of the form `(space ...)'.
2678 (handle_display_spec): Return the value returned by
2679 handle_single_display_spec, not just 1 or zero.
2680 (handle_single_display_spec): If the display spec is of the form
2681 `(space ...)', and specifies display in the text area, return 2
2682 rather than 1.
fee65a97 2683 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2684 accurately, and prefer exact match for point under bidi.
2685 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2686
2687 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2688 into disp_prop; all users changed.
2689
2690 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2691 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2692 for the text covered by the display property.
2693
e4ed06f1
CY
26942011-08-25 Chong Yidong <cyd@stupidchicken.com>
2695
2696 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2697 Change return value to nil.
2698 (Frecord_buffer): Delete unused function.
2699
f67cdd7f
EZ
27002011-08-24 Eli Zaretskii <eliz@gnu.org>
2701
5980d4c6
EZ
2702 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2703 buffers, return left-to-right.
8610fe8b
EZ
2704 (set_cursor_from_row): Consider candidate row a win if its glyph
2705 represents a newline and point is on that newline. Fixes cursor
2706 positioning on the newline at EOL of R2L text within L2R
2707 paragraph, and vice versa.
2708 (try_cursor_movement): Check continued rows, in addition to
2709 continuation rows. Fixes unwarranted scroll when point enters a
2710 continued line of R2L text within an L2R paragraph, or vice versa.
2711 (cursor_row_p): Consider the case of point being equal to
2712 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2713 from the end of a short line to the beginning of a continued line
2714 of R2L text within L2R paragraph.
2715 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2716 composed characters.
5980d4c6 2717
f67cdd7f
EZ
2718 * bidi.c (bidi_check_type): Use xassert.
2719 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2720 members.
2721
bca633fb
EZ
27222011-08-23 Eli Zaretskii <eliz@gnu.org>
2723
2724 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2725 a character.
2726
4a5885a7
CY
27272011-08-23 Chong Yidong <cyd@stupidchicken.com>
2728
2729 * nsfont.m (ns_otf_to_script): Fix typo.
2730
0902a04e
KH
27312011-08-22 Kenichi Handa <handa@m17n.org>
2732
2733 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2734 extra slot even if the purpose is char-code-property-table.
2735
1a2e6670
EZ
27362011-08-23 Eli Zaretskii <eliz@gnu.org>
2737
8ddde651
EZ
2738 * xdisp.c (redisplay_window): When computing centering_position,
2739 account for the height of the header line. (Bug#8874)
2740
425cc014
EZ
2741 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2742 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2743 candidate is selected by the mouse, and that candidate has a
2744 composed character under the mouse.
2745
1a2e6670
EZ
2746 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2747 coordinates reported by pos-visible-in-window-p for a composed
2748 character in column zero.
2749
8b76d6f8
SM
27502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2751
2752 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2753
dac347dd
EZ
27542011-08-22 Eli Zaretskii <eliz@gnu.org>
2755
2756 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2757 consider it a hit if to_charpos is anywhere in the range of the
2758 composed buffer positions.
2759
e013fb34
CY
27602011-08-22 Chong Yidong <cyd@stupidchicken.com>
2761
2762 * image.c (gif_load): Don't assume that each subimage has the same
2763 dimensions as the base image. Handle disposal method that is
2764 "undefined" by the gif spec (Bug#9335).
2765
bd1ba3e8
CY
27662011-08-20 Chong Yidong <cyd@stupidchicken.com>
2767
2768 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2769 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2770
54a1215b
EZ
27712011-08-19 Eli Zaretskii <eliz@gnu.org>
2772
823564e5
EZ
2773 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2774 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2775 from an Org mode buffer to a Speedbar frame.
2776
54a1215b
EZ
2777 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2778 a composition, take its buffer position from IT->cmp_it.charpos.
2779 Fixes cursor positioning at the beginning of a line that begins
2780 with a composed character.
2781
9778ebcc
EZ
27822011-08-18 Eli Zaretskii <eliz@gnu.org>
2783
0be6ee06
EZ
2784 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2785 character bidirectional type, use STRONG_L instead. Fixes crashes
2786 in a buffer produced by `describe-categories'.
2787
9778ebcc
EZ
2788 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2789 members before the level stack, so they would be saved and
2790 restored when copying iterator state. Fixes incorrect reordering
2791 around TABs covered by display properties.
2792
156bffbe
AS
27932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2794
6b02f655 2795 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2796
72ad093b
CY
27972011-08-17 Chong Yidong <cyd@stupidchicken.com>
2798
2799 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2800 (internal_condition_case_2, internal_condition_case_n):
2801 Remove unnecessary aborts (Bug#9081).
72ad093b 2802
35774242
EZ
28032011-08-17 Eli Zaretskii <eliz@gnu.org>
2804
2805 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2806 has no `load' handler, try opening the file locally. (Bug#9311)
2807
db76dd85
KB
28082011-08-16 Ken Brown <kbrown@cornell.edu>
2809
2810 * gmalloc.c: Expand comment.
2811
b215eee5
EZ
28122011-08-16 Eli Zaretskii <eliz@gnu.org>
2813
2814 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2815 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2816
a4579d33
KB
28172011-08-16 Ken Brown <kbrown@cornell.edu>
2818
2819 Fix memory allocation problems in Cygwin build (Bug#9273).
2820
2821 * unexcw.c ( __malloc_initialized): Declare external variable.
2822 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2823
8b76d6f8
SM
2824 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2825 New variables.
a4579d33
KB
2826 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2827 dumped emacs.
2828 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2829 in the static heap.
2830 [CYGWIN] (special_realloc): New function.
2831 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2832 requests to realloc storage in the static heap.
2833
3ebec551
PE
28342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 * bidi.c (bidi_initialize): Remove unused local.
2837
9fd8be00
EZ
28382011-08-15 Eli Zaretskii <eliz@gnu.org>
2839
6b02f655
SM
2840 * bidimirror.h:
2841 * biditype.h: Remove file.
2842 * makefile.w32-in ($(BLD)/bidi.$(O)):
2843 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2844
2845 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2846
2847 * chartab.c: Improve commentary for the uniprop_table API.
2848
32413314
EZ
2849 * bidi.c (bidi_paragraph_init): Support zero value of
2850 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2851 (bidi_initialize): Use uniprop_table instead of including
2852 biditype.h and bidimirror.h.
32413314 2853
9fd8be00
EZ
2854 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2855 coordinates of the iterator when restoring from ppos_it.
2856 (Bug#9296)
2857
5cf2b69b
KH
28582011-08-14 Kenichi Handa <handa@m17n.org>
2859
2860 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2861 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2862
daf17d00
EZ
28632011-08-14 Eli Zaretskii <eliz@gnu.org>
2864
2865 * xdisp.c (move_it_in_display_line_to): Don't invoke
2866 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2867 ppos_it. Fixes vertical cursor motion when line beginning is
2868 covered by an image. (Bug#9296)
2869
08e3161a
JD
28702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2871
2872 * nsterm.h (ns_run_ascript): Declare.
2873 (NSAPP_DATA2_RUNASSCRIPT): Define.
2874
2875 * nsfns.m (as_script, as_result, as_status): New static variables.
2876 (ns_run_ascript): New function.
5e617bc2 2877 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2878 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2879 the event loop. Get status from as_status (Bug#7276).
2880
2881 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2882 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2883 the event loop (Bug#7276).
2884
a3720aa2
AS
28852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2886
2887 * gnutls.c (QCgnutls_bootprop_priority)
2888 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2889 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2890 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2891 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2892 (QCgnutls_bootprop_verify_hostname_error)
2893 (QCgnutls_bootprop_callbacks_verify): Rename from
2894 Qgnutls_bootprop_..., all uses changed.
2895
2896 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2897 uses changed.
2898
0a0d27fb
PE
28992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2900
19d5c50c
PE
2901 * xfaces.c (Qframe_set_background_mode): Now static.
2902 * dispextern.h (Qframe_set_background_mode): Remove decl.
2903
0a0d27fb
PE
2904 * process.c (Fnetwork_interface_info): Declare local only if needed.
2905
377538cb
JD
29062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2907
2908 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2909 (Fnetwork_interface_list): Allocate in increments of bytes instead
2910 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2911 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2912 sockaddr.
2913 (struct ifflag_def): notrailers is smart on OSX.
2914 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2915 Get hardware address with getifaddrs if available.
2916
08fff70c
EZ
29172011-08-12 Eli Zaretskii <eliz@gnu.org>
2918
2919 * xdisp.c (iterate_out_of_display_property): xassert that
2920 IT->position is set to within IT->object's boundaries. Break from
2921 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2922 when IT->position is set up wrongly due to some bug.
2923 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2924 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2925 entry. Force push_it to save on the stack the current
2926 buffer/string position, to be restored by pop_it. Fix flags in
2927 the iterator structure wrt the object coming from a display
2928 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2929 properties. (Bug#9284)
2930
7be1c708 29312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2932
7be1c708
CY
2933 * fontset.c (fontset_get_font_group): Add proper type checks.
2934 (Bug#9172)
aac0c6e3 2935
7be1c708 29362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2937
7be1c708
CY
2938 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2939 and LC_VERSION_MIN_MACOSX.
2940 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2941 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2942
97bb72a6
EZ
29432011-08-08 Eli Zaretskii <eliz@gnu.org>
2944
2945 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2946 no-display-properties-and-no-overlays under bidi display.
2947 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2948 properties and overlays.
97bb72a6 2949
d5617611
CY
29502011-08-08 Chong Yidong <cyd@stupidchicken.com>
2951
37e11a63
CY
2952 * editfns.c (Fset_time_zone_rule): Document relationship with the
2953 setenv function.
2954
d5617611
CY
2955 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2956 the font entity extracted from the cache (Bug#8109).
2957
58872834
CY
29582011-08-07 Chong Yidong <cyd@stupidchicken.com>
2959
2960 * composite.c (autocmp_chars): Don't reset point. That is done by
2961 restore_point_unwind (Bug#5984).
2962
75bfc667
JL
29632011-08-07 Juri Linkov <juri@jurta.org>
2964
2965 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2966 to show the arg `TIME' instead of `TIMEVAL'.
2967
d1410150
EZ
29682011-08-06 Eli Zaretskii <eliz@gnu.org>
2969
2970 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2971 display property strides EOL and includes a newline, as in
2972 longlines-mode. (Bug#9254)
75b771e4
EZ
2973 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2974 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2975
2976 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2977 is non-zero, even if the data buffer is NULL. Fixes a crash in
2978 vertical-motion with longlines-mode. (Bug#9254)
2979
35928349
EZ
29802011-08-05 Eli Zaretskii <eliz@gnu.org>
2981
ec7cc85b
EZ
2982 * bidi.c <bidi_cache_total_alloc>: Now static.
2983 (bidi_initialize): Initialize bidi_cache_total_alloc.
2984
8b76d6f8 2985 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2986 cache. (Bug#9221)
2987
2988 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2989 amount allocated this far in `bidi_cache_total_alloc'.
2990 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2991 non-zero, only free the data buffer without restoring the cache
2992 contents. All callers changed.
2993
2994 * dispextern.h (bidi_unshelve_cache): Update prototype.
2995
2996 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2997 (move_it_in_display_line, move_it_to)
2998 (move_it_vertically_backward, move_it_by_lines): Replace the call
2999 to xfree to an equivalent call to bidi_unshelve_cache.
3000 (move_it_in_display_line_to): Fix logic of returning
412b6358 3001 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3002
e2e2423b
EZ
30032011-08-05 Eli Zaretskii <eliz@gnu.org>
3004
3005 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3006 came from a string character with a `cursor' property. (Bug#9229)
3007
ae9e757a
JD
30082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3009
3010 * Makefile.in (LIB_PTHREAD): New variable.
3011 (LIBES): Add LIB_PTHREAD (Bug#9216).
3012
3013 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3014 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3015
213bd7f2
AS
30162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3017
6b02f655 3018 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3019
99aaf75f
JD
30202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3021
3022 * xterm.c (x_find_topmost_parent): New function.
3023 (x_set_frame_alpha): Find topmost parent window with
3024 x_find_topmost_parent and set the property there also (bug#9181).
3025 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3026
c74e9d86
PE
30272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3028
3029 * callproc.c (Fcall_process): Avoid vfork clobbering
3030 the local vars buffer, coding_systems, current_dir.
3031
640c8776
SM
30322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3033
3034 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3035
f26d0e4c
PE
30362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3037
8a10d76c
PE
3038 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3039 so that it is not optimized away.
3040
f26d0e4c
PE
3041 * xdisp.c (compute_display_string_pos): Remove unused local.
3042
55439c61
EZ
30432011-08-02 Eli Zaretskii <eliz@gnu.org>
3044
3045 Fix slow cursor motion and scrolling in large buffers with
3046 selective display, like Org Mode buffers. (Bug#9218)
3047
3048 * dispextern.h (struct bidi_it): New member disp_prop_p.
3049
3050 * xdisp.c: Remove one-slot cache of display string positions.
3051 (compute_display_string_pos): Accept an additional argument
5e617bc2 3052 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3053 for a display string or property. If found, set DISP_PROP_P
3054 non-zero.
3055
3056 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3057 DISP_PROP_P, and pass it to compute_display_string_pos.
3058 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3059 non-zero. All callers of bidi_fetch_char changed.
3060
fb33fa43
SM
30612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3062
3063 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3064
b099e063
DM
30652010-12-03 Don March <don@ohspite.net>
3066
3067 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3068 last character M-[char] is translated to ESC [char] (bug#7541).
3069
5cc7f7af
KH
30702011-08-02 Kenichi Handa <handa@m17n.org>
3071
d0fffa3f 3072 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3073
3074 * chartab.c (uniprop_table): Make it non-static.
3075
525d5e6e
EZ
30762011-08-01 Eli Zaretskii <eliz@gnu.org>
3077
3078 * xdisp.c (forward_to_next_line_start): Accept additional argument
3079 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3080 on the newline.
3081 (reseat_at_next_visible_line_start): Use the bidi iterator state
3082 returned by forward_to_next_line_start to restore the state of
3083 it->bidi_it after backing up to previous newline. (Bug#9212)
3084
31011111
AS
30852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3086
3087 * regex.c (re_comp): Protoize.
3088 (re_exec): Fix return type.
3089 (regexec): Fix type of `ret'. (Bug#9203)
3090
476371c4
PE
30912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3092
e5d76069
PE
3093 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3094 This is needed if max-image-size is a floating-point number.
3095
9a79b20c
AS
30962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3097
3098 * print.c (print_object): Print empty symbol as ##.
3099
3100 * lread.c (read1): Read ## as empty symbol.
3101
d8c2fa78
AA
31022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3103
3104 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3105 setting frame foreground color (Bug#9175).
3106 (x_set_background_color): Likewise.
3107
ffe57a7a
AA
3108 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3109 contents (Bug#9176).
3110 (EmacsTooltip -init): Remove bezels and add shadows to
3111 tooltip windows.
3112
bf3492a5
AA
3113 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3114 or scroll bar (Bug#8470).
3115
d55e9c53
AA
3116 * nsfont.m (nsfont_open): Remove assignment to voffset and
3117 unnecessary vars hshink, expand, hd, full_height, min_height.
3118 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3119
3120 * nsterm.h (nsfont_info): Remove voffset field.
3121
d8c2fa78 31222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3123
3124 Implement strike-through and overline on NextStep (Bug#8863).
3125
3126 * nsfont.m (nsfont_open): Use underline position provided by font,
3127 instead of hard-coded value of 2.
3128 (nsfont_draw): Call ns_draw_text_decoration instead.
3129
3130 * nsterm.h: Add declaration for ns_draw_text_decoration.
3131
3132 * nsterm.m (ns_draw_text_decoration): New function for drawing
3133 underline, overline, and strike-through.
3134 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3135 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3136 accommodate underlining, etc.
4843aac3 3137
4cc60b9b
EZ
31382011-07-28 Eli Zaretskii <eliz@gnu.org>
3139
bc7ece87
EZ
3140 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3141 default.
4cc60b9b 3142
476371c4
PE
31432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3144
66606eea
PE
3145 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3146 Without this fix, if a signal arrives just after memory fills up,
3147 'malloc' might be invoked reentrantly.
3148
476371c4
PE
3149 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3150 In other words, assume that every image size is allowed, on non-X
3151 hosts. This assumption is probably wrong, but it lets Emacs compile.
3152
f3fcc40d
AS
31532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3154
3155 * regex.c (re_iswctype): Convert return values to boolean.
3156
350c992f
EZ
31572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3158
3159 * xdisp.c (compute_display_string_pos): Don't use cached display
3160 string position if the buffer had its restriction changed.
3161 (Bug#9184)
3162
5266b4bb
PE
31632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3166
2573a837 31672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3168
41f55ccd 3169 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3170
39e378da
PE
3171 * bidi.c: Integer size and overflow fixes.
3172 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3173 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3174 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3175 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3176 (bidi_find_other_level_edge):
3177 Use ptrdiff_t instead of EMACS_INT where either will do.
3178 This works better on 32-bit hosts configured --with-wide-int.
3179 (bidi_cache_ensure_space): Check for size-calculation overflow.
3180 Use % rather than repeated addition, for better worst-case speed.
3181 Don't set bidi_cache_size until after xrealloc returns, because it
3182 might not return.
3183 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3184 (bidi_cache_ensure_space): Also check that the bidi cache size
3185 does not exceed that of the largest Lisp string or buffer. See Eli
3186 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3187
5e927815
PE
3188 * alloc.c (__malloc_size_t): Remove.
3189 All uses replaced by size_t. See Andreas Schwab's note
3190 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3191
ca4aa935
PE
3192 * image.c: Improve checking for integer overflow.
3193 (check_image_size): Assume that f is nonnull, since
3194 it is always nonnull in practice. This is one less thing to
3195 worry about when checking for integer overflow later.
3196 (x_check_image_size): New function, which checks for integer
3197 overflow issues inside X.
3198 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3199 This removes the need for a memory_full check.
3200 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3201 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3202 (xbm_read_bitmap_data): Change locals back to 'int', since
3203 their values must fit in 'int'.
3204 (xpm_load_image, png_load, tiff_load):
3205 Invoke x_create_x_image_and_pixmap earlier,
3206 to avoid much needless work if the image is too large.
3207 (tiff_load): Treat overly large images as if
3208 x_create_x_image_and_pixmap failed, not as malloc failures.
3209 (gs_load): Use x_check_image_size.
3210
5f8f9cc2
PE
3211 * gtkutil.c: Omit integer casts.
3212 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3213 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3214
5adf60bc
PE
3215 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3216
c8907a93
PE
3217 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3218 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3219 would wrongly return t on a 64-bit host.
3220
e3c25c68
PE
3221 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3222 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3223 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3224 and therefore cause GCC to emit a bogus diagnostic in some cases.
3225
3f791afe
PE
3226 * image.c: Integer signedness and overflow and related fixes.
3227 This is not an exhaustive set of fixes, but it's time to
3228 record what I've got.
3229 (lookup_pixel_color, check_image_size): Remove redundant decls.
3230 (check_image_size): Don't assume that arbitrary EMACS_INT values
3231 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3232 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3233 (tiff_load, imagemagick_load_image):
3234 Check for overflow in size calculations.
3235 (x_create_x_image_and_pixmap): Remove unnecessary test for
3236 xmalloc returning NULL; that can't happen.
3237 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3238 (xpm_color_bucket): Use better integer hashing function.
3239 (xpm_cache_color): Don't possibly over-allocate memory.
3240 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3241 (gif_memory_source):
3242 Use ptrdiff_t, not int or size_t, to record sizes.
3243 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3244 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3245 either works, as we prefer signed integers.
3246 (tiff_read_from_memory, tiff_write_from_memory):
3247 Return tsize_t, not size_t, since that's what the TIFF API wants.
3248 (tiff_read_from_memory): Don't fail simply because the read would
3249 go past EOF; instead, return a short read.
3250 (tiff_load): Omit no-longer-needed casts.
3251 (Fimagemagick_types): Don't assume size fits into 'int'.
3252
3cc5a532
PE
3253 Improve hashing quality when configured --with-wide-int.
3254 * fns.c (hash_string): New function, taken from sxhash_string.
3255 Do not discard information about ASCII character case; this
3256 discarding is no longer needed.
3257 (sxhash-string): Use it. Change sig to match it. Caller changed.
3258 * lisp.h: Declare it.
3259 * lread.c (hash_string): Remove, since we now use fns.c's version.
3260 The fns.c version returns a wider integer if --with-wide-int is
3261 specified, so this should help the quality of the hashing a bit.
3262
b312a492
PE
3263 * emacs.c: Integer overflow minor fix.
3264 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3265 Define only if GNU_LINUX.
3266 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3267
dfd153ae
PE
3268 * dispnew.c: Integer signedness and overflow fixes.
3269 Remove unnecessary forward decls, that were a maintenance hassle.
3270 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3271 All uses changed.
3272 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3273 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3274 (prepare_desired_row, line_draw_cost):
3275 Use int, not unsigned, where either works.
3276 (save_current_matrix, restore_current_matrix):
3277 Use ptrdiff_t, not size_t, where either works.
3278 (init_display): Check for overflow more accurately, and without
3279 relying on undefined behavior.
3280
a81d11a3
PE
3281 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3282 Remove, replacing with the new symbols in lisp.h. All uses changed.
3283 * fileio.c (make_temp_name):
3284 * filelock.c (lock_file_1, lock_file):
3285 * xdisp.c (message_dolog):
3286 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3287 Use pMd etc. instead.
3288 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3289 replacing the pWIDE etc. symbols removed from editfns.c.
3290
3300e6fd
PE
3291 * keyboard.h (num_input_events): Now uintmax_t.
3292 This is (very slightly) less likely to mess up due to wraparound.
3293 All uses changed.
3294
fd05c7e9
PE
3295 * buffer.c: Integer signedness fixes.
3296 (alloc_buffer_text, enlarge_buffer_text):
3297 Use ptrdiff_t rather than size_t when either will do, as we prefer
3298 signed integers.
3299
903fe15d
PE
3300 * alloc.c: Integer signedness and overflow fixes.
3301 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3302 (__malloc_size_t): Default to size_t, not to int.
3303 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3304 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3305 Prefer ptrdiff_t to size_t when either would do, as we prefer
3306 signed integers.
3307 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3308 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3309 Now const. Initialize with values that are in range even if char
3310 is signed.
3311 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3312 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3313 These functions do the right thing with sizes > 2**32.
3314 (check_depth): Now ptrdiff_t, not int.
3315 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3316 Adjust to new way of storing sizes. Check for size overflow bugs
3317 in rest of code.
3318 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3319 slightly wrong anyway, as it missed one instance of
3320 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3321 (refill_memory_reserve): Omit needless cast to size_t.
3322 (mark_object_loop_halt): Mark as externally visible.
3323
ac82cc6a
PE
3324 * xselect.c: Integer signedness and overflow fixes.
3325 (Fx_register_dnd_atom, x_handle_dnd_message):
3326 Use ptrdiff_t, not size_t, since we prefer signed.
3327 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3328 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3329 x_dnd_atoms_size and x_dnd_atoms_length.
3330
c2d1e36d
PE
3331 * doprnt.c: Prefer signed to unsigned when either works.
3332 * eval.c (verror):
3333 * doprnt.c (doprnt):
3334 * lisp.h (doprnt):
3335 * xdisp.c (vmessage):
3336 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3337 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3338 prefer signed arithmetic to avoid comparison confusion.
3339 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3340 but is a bit tricky.
3341
0e926e56
PE
3342 Assume freestanding C89 headers, string.h, stdlib.h.
3343 * data.c, doprnt.c, floatfns.c, print.c:
3344 Include float.h unconditionally.
3345 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3346 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3347 * regex.c: Likewise for stddef.h, string.h.
3348 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3349 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3350 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3351 (STDC_HEADERS): Remove obsolete defines.
3352 * sysdep.c: Include limits.h unconditionally.
3353
9cfdb3ec
PE
3354 Assume support for memcmp, memcpy, memmove, memset.
3355 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3356 * regex.c (memcmp, memcpy):
3357 Remove; we assume C89 now.
3358
3359 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3360 (__malloc_safe_bcopy): Remove; no longer needed.
3361
cf950e6b 3362 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3363 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3364 well either way, and we prefer signed to unsigned.
3365
dbf38e02
LMI
33662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3367
3368 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3369 closes the connection while we're reading (bug#9182).
3370
d6f0886c 33712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3372
d6f0886c
JD
3373 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3374 are specified (Bug#9168).
24e0f6b1 3375
2eb1f9e6
PE
33762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3379 Found by GCC static checking and --with-wide-int on a 32-bit host.
3380
22381272 33812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3382
3383 * xdisp.c (compute_display_string_pos): Fix logic of caching
3384 previous display string position. Initialize cached_prev_pos to
3385 -1. Fixes slow-down at the beginning of a buffer.
3386
f25e39b4
EZ
33872011-07-24 Eli Zaretskii <eliz@gnu.org>
3388
3389 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3390 for attrs[LFACE_FONTSET_INDEX].
3391
04c4b52e
PE
33922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3393
3394 * xml.c (parse_region): Remove unused local
3395 that was recently introduced.
3396
c1734fbd
EZ
33972011-07-23 Eli Zaretskii <eliz@gnu.org>
3398
be18c5a5
EZ
3399 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3400 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3401
c1734fbd
EZ
3402 * xdisp.c (move_it_in_display_line_to): Record the best matching
3403 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3404 exit if none of the characters scanned was an exact match.
3405 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3406 when exact match is impossible due to invisible text, and the
3407 lines are truncated.
3408
a258d627
JD
34092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3410
3411 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3412 for OSX >= 10.7.
3413
b6d5a689
EZ
34142011-07-22 Eli Zaretskii <eliz@gnu.org>
3415
0f74f785
EZ
3416 Fix a significant slow-down of cursor motion with C-n, C-p,
3417 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3418 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3419 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3420 (next_element_from_buffer): Call compute_stop_pos_backwards to
3421 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3422 base_level_stop.
3423 (reseat): Don't look for prev_stop, as that could mean a very long
3424 run.
3425 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3426 <cached_disp_overlay_modiff>: Cache for last found display string
3427 position.
551918c1 3428 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3429 about the same buffer in the same area of character positions, and
3430 the buffer wasn't changed since the time the display string
3431 position was cached.
551918c1 3432
b2d0c91a
EZ
34332011-07-22 Eli Zaretskii <eliz@gnu.org>
3434
3435 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3436 is an integer, which is important for empty lines. (Bug#9149)
3437
043604ee
CY
34382011-07-22 Chong Yidong <cyd@stupidchicken.com>
3439
3440 * frame.c (Fmodify_frame_parameters): In tty case, update the
3441 default face if necessary (Bug#4238).
3442
da4adb04
CY
34432011-07-21 Chong Yidong <cyd@stupidchicken.com>
3444
3445 * editfns.c (Fstring_to_char): No need to explain what a character
3446 is in the docstring (Bug#6576).
3447
9abd0532
LMI
34482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3449
3450 * xml.c (parse_region): Make sure we always return a tree.
3451
36881d16
HK
34522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3453
3454 * xml.c (parse_region): If a document contains only comments,
3455 return that, too.
3456
1e98674d
LMI
34572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3458
3459 * xml.c (make_dom): Return comments, too.
3460
590bd467
PE
34612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 Port to OpenBSD.
3464 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3465 and the surrounding thread.
3466 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3467 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3468 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3469 timer goes off.
3470 * s/openbsd.h (BROKEN_SIGIO): Define.
3471 * unexelf.c (unexec) [__OpenBSD__]:
3472 Don't update the .mdebug section of the Alpha COFF symbol table.
3473
f41628b2
LMI
34742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3475
3476 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3477 (bug#8460).
3478
b59b67c5
PE
34792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3480
15e3a074
PE
3481 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3482 This fixes some race conditions on the permissions of any newly
3483 created file.
3484
41bed37d
PE
3485 * alloc.c (valid_pointer_p): Use pipe, not open.
3486 This fixes some permissions issues when debugging.
3487
b59b67c5
PE
3488 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3489 If fchown fails to set both uid and gid, try to set just gid,
3490 as that is sometimes allowed. Adjust the file's mode to eliminate
3491 setuid or setgid bits that are inappropriate if fchown fails.
3492
925a6be7
SM
34932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3494
3495 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3496 to compare Lisp_Objects.
3497 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3498 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3499 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3500
52968808
AS
35012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3502
0a6a104b
AS
3503 * lread.c (read_integer): Unread even EOF character.
3504 (read1): Likewise. Properly record start position of symbol.
3505
52968808
AS
3506 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3507 symbol character follows.
3508
9e381cdd
PE
35092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3510
3511 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3512 This works around a problem with the previous change to Fcopy_file.
3513 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3514 and without this change, GCC might complain about discarding
3515 fchown's return value.
3516
b5641435
JB
35172011-07-16 Juanma Barranquero <lekktu@gmail.com>
3518
3519 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3520
a8031457
PE
35212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3524
dd889327
LMI
35252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3526
750c33f7
LMI
3527 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3528 it's used from the C level.
3529
dd889327
LMI
3530 * process.c: Use the same condition for POLL_FOR_INPUT in both
3531 keyboard.c and process.c (bug#1858).
3532
87e86684
LM
35332011-07-09 Lawrence Mitchell <wence@gmx.li>
3534
3535 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3536 (Fgnutls_boot): Use it.
3537
64348f40
AS
35382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3539
3540 * doc.c (Fsubstitute_command_keys): Revert last change.
3541
1d698799
LMI
35422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3543
f863868c
LMI
3544 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3545 quotes the next character, and doesn't affect other longer
3546 sequences (bug#8935).
3547
1d698799
LMI
3548 * lread.c (syms_of_lread): Clarify that is isn't only
3549 `eval-buffer' and `eval-defun' that's affected by
3550 `lexical-binding' (bug#8460).
3551
aa4b6df6
EZ
35522011-07-15 Eli Zaretskii <eliz@gnu.org>
3553
3554 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3555 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3556
5d856da6
PE
35572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3558
ad6042bb
PE
3559 Fix minor problems found by static checking.
3560 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3561 (elsz): Now a signed constant, not a size_t var. We prefer signed
3562 types to unsigned, to avoid integer comparison confusion. Without
3563 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3564 "cannot optimize loop, the loop counter may overflow", a symptom
3565 of the confusion.
f00bbb22 3566 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3567 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3568
6468f31c
LMI
35692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3570
49080b10
LMI
3571 * search.c (Fre_search_backward): Mention `case-fold-search' in
3572 all the re_search_* functions (bug#8138).
3573
6468f31c
LMI
3574 * keyboard.c (Fopen_dribble_file): Document when the file is
3575 closed (bug#8056).
3576
c965adc5
EZ
35772011-07-14 Eli Zaretskii <eliz@gnu.org>
3578
df9733bf
EZ
3579 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3580 bidi_cache_idx.
3581
0bb23927
EZ
3582 Support bidi reordering of display and overlay strings.
3583 * xdisp.c (compute_display_string_pos)
3584 (compute_display_string_end): Accept additional argument STRING.
3585 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3586 (reseat_to_string): Initialize bidi_it->string.s and
3587 bidi_it->string.schars.
3588 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3589 NULL (avoids a crash in bidi_paragraph_init).
3590 Initialize itb.string.lstring.
0bb23927
EZ
3591 (init_iterator): Call bidi_init_it only of a valid
3592 buffer position was specified. Initialize paragraph_embedding to
3593 L2R.
3594 (reseat_to_string): Initialize the bidi iterator.
3595 (display_string): If we need to ignore text properties of
3596 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3597 original value of -1 will not work with bidi.)
3598 (compute_display_string_pos): First arg is now struct
3599 `text_pos *'; all callers changed. Support display properties on
3600 Lisp strings.
3601 (compute_display_string_end): Support display properties on Lisp
3602 strings.
3603 (init_iterator, reseat_1, reseat_to_string): Initialize the
3604 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3605 when iterating on a string not from display properties).
640c8776
SM
3606 (compute_display_string_pos, compute_display_string_end):
3607 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3608 arrow keys.
3609 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3610 base_level_stop; instead, set base_level_stop to BEGV.
3611 Fixes crashes in vertical-motion.
0bb23927
EZ
3612 (next_element_from_buffer): Improve commentary for when
3613 the iterator is before prev_stop.
3614 (init_iterator): Initialize bidi_p from the default value of
3615 bidi-display-reordering, not from buffer-local value. Use the
3616 buffer-local value only if initializing for buffer iteration.
3617 (handle_invisible_prop): Support invisible properties on strings
3618 that are being bidi-reordered.
3619 (set_iterator_to_next): Support bidi reordering of C strings and
3620 Lisp strings.
3621 (next_element_from_string): Support bidi reordering of Lisp
3622 strings.
3623 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3624 (display_string): Support display of R2L glyph rows.
3625 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3626 (init_iterator): Don't initialize it->bidi_p for strings
3627 here.
3628 (reseat_to_string): Initialize it->bidi_p for strings here.
3629 (next_element_from_string, next_element_from_c_string)
3630 (next_element_from_buffer): Add xassert's for correspondence
3631 between IT's object being iterated and it->bidi_it.string
3632 structure.
3633 (face_before_or_after_it_pos): Support bidi iteration.
3634 (next_element_from_c_string): Handle the case of the first string
3635 character that is not the first one in the visual order.
3636 (get_visually_first_element): New function, refactored from common
3637 parts of next_element_from_buffer, next_element_from_string, and
3638 next_element_from_c_string.
3639 (tool_bar_lines_needed, redisplay_tool_bar)
3640 (display_menu_bar): Force left-to-right direction. Add a FIXME
3641 comment for making that be controlled by a user option.
3642 (push_it, pop_it): Save and restore the state of the
3643 bidi iterator. Save and restore the bidi_p flag.
3644 (pop_it): Iterate out of display property for string iteration as
3645 well.
3646 (iterate_out_of_display_property): Support iteration over strings.
3647 (handle_single_display_spec): Set up it->bidi_it for iteration
3648 over a display string, and call bidi_init_it.
3649 (handle_single_display_spec, next_overlay_string)
3650 (get_overlay_strings_1, push_display_prop): Set up the bidi
3651 iterator for displaying display or overlay strings.
3652 (forward_to_next_line_start): Don't use the shortcut if
3653 bidi-iterating.
3654 (back_to_previous_visible_line_start): If handle_display_prop
3655 pushed the iterator stack, restore the internal state of the bidi
3656 iterator by calling bidi_pop_it same number of times.
3657 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3658 and we are bidi-iterating, don't decrement the iterator position;
3659 instead, set the first_elt flag in the bidi iterator, to produce
3660 the same effect.
3661 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3662 (push_display_prop): xassert that we are iterating a buffer.
3663 (push_it, pop_it): Save and restore paragraph_embedding member.
3664 (handle_single_display_spec, next_overlay_string)
3665 (get_overlay_strings_1, reseat_1, reseat_to_string)
3666 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3667 correctly. Don't assume unibyte strings are not bidi-reordered.
3668 (compute_display_string_pos)
3669 (compute_display_string_end): Fix handling the case of C string.
3670 (push_it, pop_it): Save and restore from_disp_prop_p.
3671 (handle_single_display_spec, push_display_prop): Set the
3672 from_disp_prop_p flag.
3673 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3674 (pop_it): Call iterate_out_of_display_property only if we are
3675 popping after iteration over a string that came from a display
3676 property. Fix a typo in popping stretch info. Add an assertion
3677 for verifying that the iterator position is in sync with the bidi
3678 iterator.
3679 (handle_single_display_spec, get_overlay_strings_1)
3680 (push_display_prop): Fix initialization of paragraph direction for
3681 string when that of the parent object is not yet determined.
3682 (reseat_1): Call bidi_init_it to resync the bidi
3683 iterator with IT's position. (Bug#7616)
3684 (find_row_edges): If ROW->start.pos gives position
3685 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3686 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3687 Reset the from_disp_prop_p flag.
3688 (SAVE_IT, RESTORE_IT): New macros.
3689 (pos_visible_p, face_before_or_after_it_pos)
3690 (back_to_previous_visible_line_start)
3691 (move_it_in_display_line_to, move_it_in_display_line)
3692 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3693 (try_scrolling, redisplay_window, display_line): Use them when
3694 saving a temporary copy of the iterator and restoring it back.
3695 (back_to_previous_visible_line_start, reseat_1)
3696 (init_iterator): Empty the bidi cache "stack".
3697 (move_it_in_display_line_to): If iterator ended up at
3698 EOL, but we never saw any buffer positions smaller than
3699 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3700 motion in bidi-reordered lines.
3701 (move_it_in_display_line_to): Record prev_method and prev_pos
3702 immediately before the call to set_iterator_to_next. Fixes cursor
3703 motion in bidi-reordered lines with stretch glyphs and strings
3704 displayed in margins. (Bug#8133) (Bug#8867)
3705 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3706 TO_CHARPOS.
640c8776
SM
3707 (pos_visible_p): Support positions in bidi-reordered lines.
3708 Save and restore bidi cache.
0bb23927
EZ
3709
3710 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3711 (bidi_paragraph_info): Delete unused struct.
3712 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3713 (bidi_cache_start): New variable.
3714 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3715 to zero.
3716 (bidi_cache_fetch_state, bidi_cache_search)
3717 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3718 (bidi_cache_find, bidi_peek_at_next_level)
3719 (bidi_level_of_next_char, bidi_find_other_level_edge)
3720 (bidi_move_to_visually_next): Compare cache index with
3721 bidi_cache_start rather than with zero.
3722 (bidi_fetch_char): Accept new argument STRING; all callers
3723 changed. Support iteration over a string. Support strings with
3724 display properties. Support unibyte strings. Fix the type of
3725 `len' according to what STRING_CHAR_AND_LENGTH expects.
3726 (bidi_paragraph_init, bidi_resolve_explicit_1)
3727 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3728 (bidi_level_of_next_char, bidi_move_to_visually_next):
3729 Support iteration over a string.
0bb23927
EZ
3730 (bidi_set_sor_type, bidi_resolve_explicit_1)
3731 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3732 can now be zero (for strings); special values 0 and -1 were
3733 changed to -1 and -2, respectively.
3734 (bidi_char_at_pos): New function.
3735 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3736 Call it instead of FETCH_MULTIBYTE_CHAR.
3737 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3738 initialized to valid values.
3739 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3740 values.
3741 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3742 the test for valid cached positions. Fix the logic for looking up
3743 the sentinel state in the cache. GCPRO the Lisp string we are
3744 iterating.
3745 (bidi_push_it, bidi_pop_it): New functions.
3746 (bidi_initialize): Initialize the bidi cache start stack pointer.
3747 (bidi_cache_ensure_space): New function, refactored from part of
3748 bidi_cache_iterator_state. Don't assume the required size is just
3749 one BIDI_CACHE_CHUNK away.
3750 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3751 (bidi_count_bytes, bidi_char_at_pos): New functions.
3752 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3753 always valid if bidi_cache_idx is valid.
3754 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3755 is valid if it's going to be used.
3756 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3757 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3758 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3759 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3760 (bidi_find_other_level_edge, bidi_cache_start_stack):
3761 All variables related to cache indices are now EMACS_INT.
c965adc5 3762
0bb23927
EZ
3763 * dispextern.h (struct bidi_string_data): New structure.
3764 (struct bidi_it): New member `string'. Make flag members be 1-bit
3765 fields, and put them last in the struct.
640c8776
SM
3766 (compute_display_string_pos, compute_display_string_end):
3767 Update prototypes.
0bb23927
EZ
3768 (bidi_push_it, bidi_pop_it): Add prototypes.
3769 (struct iterator_stack_entry): New members bidi_p,
3770 paragraph_embedding, and from_disp_prop_p.
3771 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3772 (bidi_shelve_cache, bidi_unshelve_cache):
3773 Declare prototypes.
0bb23927
EZ
3774
3775 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3776 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3777 and vector-like objects.
3778
3779 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3780 cache around display iteration.
3781
3782 * window.c (Fwindow_end, window_scroll_pixel_based)
3783 (displayed_window_lines, Frecenter): Save and restore the bidi
3784 cache around display iteration.
3785
3bbd2265
LMI
37862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3787
3788 * editfns.c (Fdelete_region): Clarify the use of the named
3789 parameters (bug#6788).
3790
adc47434
MR
37912011-07-14 Martin Rudalics <rudalics@gmx.at>
3792
3793 * indent.c (Fvertical_motion): Set and restore w->pointm when
3794 saving and restoring the window's buffer (Bug#9006).
3795
837c31f8
LMI
37962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3797
3798 * editfns.c (Fstring_to_char): Clarify just what is returned
3799 (bug#6576). Text by Eli Zaretskii.
3800
ac389d0c
JB
38012011-07-13 Juanma Barranquero <lekktu@gmail.com>
3802
3803 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3804
0be0ce47
EZ
38052011-07-13 Eli Zaretskii <eliz@gnu.org>
3806
3807 * buffer.c (mmap_find): Fix a typo.
3808
cd18e7e3
JB
38092011-07-13 Johan Bockgård <bojohan@gnu.org>
3810
3811 Fix execution of x selection hooks.
3812 * xselect.c (Qx_lost_selection_functions)
3813 (Qx_sent_selection_functions): New vars.
3814 (syms_of_xselect): DEFSYM them.
3815 (x_handle_selection_request): Pass Qx_sent_selection_functions
3816 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3817 (x_handle_selection_clear,x_clear_frame_selections):
3818 Pass Qx_lost_selection_functions rather than
3819 Vx_lost_selection_functions to Frun_hook_with_args.
3820
47ea7f44
PE
38212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3822
ac389d0c 3823 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3824 The old code sometimes used this field without initializing it.
3825
47ea7f44
PE
3826 * alloc.c (gc_sweep): Don't read past end of array.
3827 In theory, the old code could also have corrupted Emacs internals,
3828 though it'd be very unlikely.
3829
bc985c87
AS
38302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3831
3832 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3833 argument. (Bug#4026)
bc985c87 3834
0cf34688
LMI
38352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3836
b3dadd76
LMI
3837 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3838 key" (bug#4257).
3839
0cf34688
LMI
3840 * window.c (Fset_window_start): Doc fix (bug#4199).
3841 (Fset_window_hscroll): Ditto.
3842
270768cd
PE
38432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3844
077e3dda 3845 Fix minor new problems caught by GCC 4.6.1.
270768cd 3846 * term.c (init_tty): Remove unused local.
490011a6 3847 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3848 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3849 not used otherwise.
270768cd 3850
b1f58454
CY
38512011-07-12 Chong Yidong <cyd@stupidchicken.com>
3852
3853 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3854
22b9578d
LMI
38552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3856
6e70ab07
LMI
3857 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3858 are the mini-buffer and the echo area (bug#3320).
3859
22b9578d
LMI
3860 * term.c (init_tty): Remove support for supdup, c10 and perq
3861 terminals, which are no longer supported (bug#1482).
3862
8974cc9f
JB
38632011-07-10 Johan Bockgård <bojohan@gnu.org>
3864
3865 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3866
a560d974
JD
38672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3868
3869 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3870 for non-popups (Bug#3642).
3871
1dae0f0a
AS
38722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3873
268c2c36 3874 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3875 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3876 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3877 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3878 * data.c (fmod): Likewise.
3879 * dispnew.c (swap_glyphs_in_rows): Likewise.
3880 * emacs.c (memory_warning_signal): Likewise.
3881 * floatfns.c (float_error): Likewise.
3882 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3883 (otf_open, font_otf_capability, generate_otf_features)
3884 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3885 Likewise.
3886 * image.c (pbm_read_file): Likewise.
3887 * indent.c (string_display_width): Likewise.
3888 * intervals.c (check_for_interval, search_for_interval)
3889 (inc_interval_count, count_intervals, root_interval)
3890 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3891 * lread.c (defalias): Likewise.
268c2c36 3892 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3893 * regex.c (set_image_of_range_1, set_image_of_range)
3894 (regex_grow_registers): Likewise.
3895 * sysdep.c (strerror): Likewise.
3896 * termcap.c (valid_filename_p, tprint, main): Likewise.
3897 * tparam.c (main): Likewise.
3898 * unexhp9k800.c (run_time_remap, save_data_space)
3899 (update_file_ptrs, read_header, write_header, calculate_checksum)
3900 (copy_file, copy_rest, display_header): Likewise.
3901 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3902 Likewise.
3903 * xdisp.c (check_it): Likewise.
3904 * xfaces.c (register_color, unregister_color, unregister_colors):
3905 Likewise.
3906 * xfns.c (print_fontset_result): Likewise.
3907 * xrdb.c (member, fatal, main): Likewise.
3908
99033785
PE
39092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 Fix minor problems found by static checking (Bug#9031).
3912 * chartab.c (char_table_set_range, map_sub_char_table):
3913 Remove unused locals.
3914 (uniprop_table): Now static.
3915 * composite.c (_work_char): Remove unused static var.
3916
9cb2ac56
JB
39172011-07-09 Juanma Barranquero <lekktu@gmail.com>
3918
3919 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3920
f25661f0
JD
39212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3922
3923 * gtkutil.c (qttip_cb): Remove code without function.
3924
8278c4fe
EZ
39252011-07-09 Eli Zaretskii <eliz@gnu.org>
3926
3927 * w32.c (pthread_sigmask): New stub.
3928
1692ae2d 39292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3930
8a6ebd58 3931 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3932 sigprocmask is portable only for single-threaded applications, and
3933 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3934 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3935 (LIBES): Use it.
3936 * callproc.c (Fcall_process):
3937 * process.c (create_process):
3938 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3939 Use pthread_sigmask, not sigprocmask.
123403e4 3940
1b854618
JD
39412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3942
3943 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3944 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3945 wrong (Bug#8591).
3946
3fe4b549
JD
39472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3948
0ce7e563
JD
3949 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3950 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3951 (xg_hide_tooltip): Fix comment.
3952
3fe4b549
JD
3953 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3954 in registerServicesMenuSendTypes.
3955 (validRequestorForSendType): Don't check ns_return_types.
3956
3957 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3958 ns_return_type.
3959
5df75e47
JR
39602011-07-08 Jason Rumney <jasonr@gnu.org>
3961
22610910
JR
3962 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3963 SH_SHOW for hidden windows (Bug#5482).
3964
5df75e47
JR
3965 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3966 frame struct members of non-existent frames (Bug#6284).
3967
699c10bd
JD
39682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3969
4393663b
JD
3970 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3971 variable firstTime not needed on OSX >= 10.6.
3972 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3973 >= 10.5. Use setKnobProportion, setDoubleValue.
3974
3975 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3976 (MAC_OS_X_VERSION_10_5): Define if not defined.
3977 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3978 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3979 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3980
3981 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3982 cString and lossyCString on OSX >= 10.4
3983
58179cce 3984 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3985 sizeToFit on OSX >= 10.2.
3986
3987 * nsimage.m (allocInitFromFile): Don't use deprecated method
3988 bestRepresentationForDevice on OSX >= 10.6.
3989
3990 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3991 to avoid warning.
3992
3993 * emacs.c: Declare unexec_init_emacs_zone.
3994
a63e0781
JD
3995 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3996
699c10bd
JD
3997 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3998
3999 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4000 on svcsMenu (Bug#8842).
4001
4002 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4003 ns_return_types.
4004 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4005
4006 * nsterm.m (QUTF8_STRING): Declare.
4007 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4008 (validRequestorForSendType): Return type is (id).
4009 Change indexOfObjectIdenticalTo to indexOfObject.
4010 Check if we have local selection before returning self (Bug#8842).
4011 (writeSelectionToPasteboard): Put local selection into paste board
4012 if we have a local selection (Bug#8842).
4013 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4014
4015 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4016 (ns_get_local_selection): Declare.
4017
54e10184
LMI
40182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4019
9888ff71
LMI
4020 * keymap.c (describe_map_tree): Don't insert a double newline at
4021 the end of the buffer (bug#1169) and return whether we inserted
4022 something.
4023
54e10184
LMI
4024 * callint.c (Fcall_interactively): Change "reading args" to
4025 "providing args" to try to clarify what it does (bug#1010).
4026
15fa4783
KH
40272011-07-07 Kenichi Handa <handa@m17n.org>
4028
4029 * composite.c (composition_compute_stop_pos): Ignore a static
4030 composition starting before CHARPOS (Bug#8915).
4031
4032 * xdisp.c (handle_composition_prop): Likewise.
4033
a8815b00
EZ
40342011-07-07 Eli Zaretskii <eliz@gnu.org>
4035
4036 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4037 (Bug#9015)
4038
ef7b981d 40392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4040
4041 * character.h (unicode_category_t): New enum type.
4042
4043 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4044 (Qchar_code_property_table): New variable.
4045 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4046 (UNIPROP_COMPRESSED_FORM_P): New macros.
4047 (char_table_ascii): Uncompress the compressed values.
4048 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4049 Uncompress the compressed values.
ac389d0c 4050 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4051 (char_table_ref_and_range): Uncompress the compressed values.
4052 (sub_char_table_set): New arg is_uniprop. Callers changed.
4053 Uncompress the compressed values.
4054 (sub_char_table_set_range): Args changed. Callers changed.
4055 (char_table_set_range): Adjuted for the above change.
4056 (map_sub_char_table): Delete args default_val and parent. Add arg
4057 top. Give decoded values to a Lisp function.
640c8776 4058 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4059 values to a Lisp function. Gcpro more variables.
4060 (uniprop_table_uncompress)
4061 (uniprop_decode_value_run_length): New functions.
4062 (uniprop_decoder, uniprop_decoder_count): New variables.
4063 (uniprop_get_decoder, uniprop_encode_value_character)
4064 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4065 New functions.
4066 (uniprop_encoder, uniprop_encoder_count): New variables.
4067 (uniprop_get_encoder, uniprop_table)
4068 (Funicode_property_table_internal, Fget_unicode_property_internal)
4069 (Fput_unicode_property_internal): New functions.
4070 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4071 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4072 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4073 char-code-property-alist.
4074
640c8776 4075 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4076 Vunicode_category_table.
4077
640c8776 4078 * font.c (font_range): Adjust for the change of
c805dec0
KH
4079 Vunicode_category_table.
4080
76b397fb
DN
40812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4082
4083 * m/iris4d.h: Remove file, move contents ...
4084 * s/irix6-5.h: ... here.
4085
22b4128e
PE
40862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4087
4088 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4089 * alloc.c (mark_buffer):
4090 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4091 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4092 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4093 This isn't true in general, and it's particularly not true
4094 if Emacs is configured with --with-wide-int.
4095 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4096 New macros, used in the buffer.c change.
4097
869795d6
JD
40982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4099
4100 * xsettings.c: Use both GConf and GSettings if both are available.
4101 (store_config_changed_event): Add comment.
4102 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4103 (store_tool_bar_style_changed): New functions.
5e617bc2 4104 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4105 (struct xsettings): Move font inside HAVE_XFT.
4106 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4107 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4108 Move inside HAVE_XFT.
640c8776 4109 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4110 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4111 also.
4112 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4113 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4114 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4115 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4116 (parse_settings): Move check for font inside HAVE_XFT.
4117 (read_settings, apply_xft_settings): Add comment.
4118 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4119 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4120 call store_font_name_changed.
4121 (xft_settings_event): Add comment.
4122 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4123 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4124 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4125 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4126 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4127 (xsettings_get_system_font, xsettings_get_system_normal_font):
4128 Add comment.
869795d6 4129
d8ed26bd
PE
41302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4131
4132 Random fixes. E.g., (random) never returned negative values.
4133 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4134 subseconds part to the entropy, as that's a bit more random.
4135 Prefer signed to unsigned, since the signedness doesn't matter and
4136 in general we prefer signed. When given a limit, use a
4137 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4138 latter isn't right if USE_2_TAGS_FOR_INTS.
4139 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4140 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4141
cabf1cac
SM
41422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4143
4144 * textprop.c (text_property_stickiness):
4145 Obey Vtext_property_default_nonsticky.
4146 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4147 * w32fns.c (syms_of_w32fns):
4148 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4149
6e9b2be9
PE
41502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4153 This is more efficient than Ffile_directory_p and avoids a minor race.
4154
90186c68
LMI
41552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4156
7c301272
LMI
4157 * buffer.c (Foverlay_put): Say what the return value is
4158 (bug#7835).
4159
c4f2d8d4
LMI
4160 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4161 is a directory before asking whether to use the file name
4162 (bug#7564).
ad637907
LMI
4163 (barf_or_query_if_file_exists): Make the "File is a directory"
4164 error be more correct.
c4f2d8d4 4165
90186c68
LMI
4166 * fns.c (Frequire): Remove the mention of the .gz files, since
4167 that's installation-specific, but keep the mention of
4168 `get-load-suffixes'.
4169
da64016e
PE
41702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4173 Report string overflow if the output is too long.
4174
7d47b580
JB
41752011-07-04 Juanma Barranquero <lekktu@gmail.com>
4176
a555cb87
JB
4177 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4178 (syms_of_gnutls): Remove duplicate DEFSYM for
4179 Qgnutls_bootprop_verify_hostname_error, an error for
4180 Qgnutls_bootprop_verify_error (which is no longer used).
4181
7d47b580
JB
4182 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4183 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4184 Also (re)move comments that are misplaced or no longer relevant.
4185
1e49bfab
LMI
41862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4187
4188 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4189
1485f4c0
CY
41902011-07-03 Chong Yidong <cyd@stupidchicken.com>
4191
4192 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4193 and background color parameters if they have been changed.
4194
a9ab721e
LMI
41952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4196
4197 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4198
cf7cff57
PE
41992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4200
2e13213d
PE
4201 * xsettings.c (SYSTEM_FONT): Define only when used.
4202 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4203
cf7cff57
PE
4204 * keymap.c (access_keymap_1): Now static.
4205
7a8e04f7
CY
42062011-07-02 Chong Yidong <cyd@stupidchicken.com>
4207
4208 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4209 leave any prefix arg for the up event (Bug#1586).
4210
61352f62
LMI
42112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4212
69bb1ef7
LMI
4213 * lread.c (syms_of_lread): Mention single symbols defined by
4214 `defvar' or `defconst' (bug#7154).
4215
61352f62 4216 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4217 (Frequire): Mention get-load-suffixes.
61352f62 4218
28545e04
MR
42192011-07-02 Martin Rudalics <rudalics@gmx.at>
4220
4221 * window.h (window): Remove clone_number slot.
4222 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4223 Remove.
4224 (make_parent_window, make_window, saved_window)
4225 (Fset_window_configuration, save_window_save): Don't deal with
4226 clone numbers.
4227 * buffer.c (Qclone_number): Remove declaration.
4228 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4229
3349e122
SM
42302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4231
4232 Add multiple inheritance to keymaps.
4233 * keymap.c (Fmake_composed_keymap): New function.
4234 (Fset_keymap_parent): Simplify.
4235 (fix_submap_inheritance): Remove.
4236 (access_keymap_1): New function extracted from access_keymap to handle
4237 embedded parents and handle lists of maps.
4238 (access_keymap): Use it.
4239 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4240 (Fcopy_keymap): Handle embedded parents.
4241 (Fcommand_remapping, define_as_prefix): Simplify.
4242 (Fkey_binding): Simplify.
4243 (syms_of_keymap): Move minibuffer-local-completion-map,
4244 minibuffer-local-filename-completion-map,
4245 minibuffer-local-must-match-map, and
4246 minibuffer-local-filename-must-match-map to Elisp.
4247 (syms_of_keymap): Defsubr make-composed-keymap.
4248 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4249 (parse_menu_item): Trivial simplification.
4250
3279eb87
GM
42512011-07-01 Glenn Morris <rgm@gnu.org>
4252
4253 * Makefile.in (SETTINGS_LIBS): Fix typo.
4254
4550efdf
KI
42552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4256
4257 * coding.c (Fencode_coding_string): Record the last coding system
4258 used, as the function doc string says (bug#8738).
4259
0949d2b6
JD
42602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4261
4262 * xsettings.c (store_monospaced_changed): Take new font as arg and
4263 check for change against current_mono_font.
4264 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4265 (emacs_settings_constructor, emacs_settings_get_property)
4266 (emacs_settings_set_property, emacs_settings_class_init)
4267 (emacs_settings_init, gsettings_obj): Remove.
4268 (something_changedCB): New function for HAVE_GSETTINGS.
4269 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4270 with value as argument.
4271 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4272 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4273 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4274 "changed".
4275
4276 * xgselect.c: Add defined (HAVE_GSETTINGS).
4277 (xgselect_initialize): Ditto.
4278
4279 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4280 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4281 xg_select.
4282
bbc6b304
PE
42832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4284
4285 * eval.c (struct backtrace): Simplify and port the data structure.
4286 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4287 signed bit field, as this assumption is not portable and it makes
4288 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4289 "char debug_on_exit : 1" as this is not portable either; instead,
4290 use the portable "unsigned int debug_on_exit : 1". Remove unused
4291 member evalargs. Remove obsolete comments about cc bombing out.
4292
9851bfc5
JD
42932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4294
51bb811f 4295 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4296 Let HAVE_GSETTINGS override HAVE_GCONF.
4297 (store_monospaced_changed): New function.
4298 (EMACS_SETTINGS): A new type derived from GObject to handle
4299 GSettings notifications.
4300 (emacs_settings_constructor, emacs_settings_get_property)
4301 (emacs_settings_set_property, emacs_settings_class_init):
4302 New functions.
4303 (gsettings_client, gsettings_obj): New variables.
4304 (GSETTINGS_SCHEMA): New define.
4305 (something_changedCB): Call store_monospaced_changed.
4306 (init_gsettings): New function.
4307 (xsettings_initialize): Call init_gsettings.
4308 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4309 to NULL.
4310
640c8776 4311 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4312 GCONF_CFLAGS/LIBS.
4313
5386012d
MR
43142011-06-29 Martin Rudalics <rudalics@gmx.at>
4315
4316 * window.c (resize_root_window, grow_mini_window)
4317 (shrink_mini_window): Rename Qresize_root_window to
4318 Qwindow_resize_root_window and Qresize_root_window_vertically to
4319 Qwindow_resize_root_window_vertically.
4320
f13e0b08
PE
43212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4324
94515237
JB
43252011-06-27 Juanma Barranquero <lekktu@gmail.com>
4326
4327 * makefile.w32-in: Redesign dependencies so they reflect more
4328 clearly which files are directly included by each source file,
4329 and not through other includes.
4330
e43b6e43
MR
43312011-06-27 Martin Rudalics <rudalics@gmx.at>
4332
4333 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4334 (sort_overlays, overlay_strings): When an overlay's clone number
4335 matches the window's clone number process the overlay even if
4336 the overlay's window property doesn't match the current window.
4337
d68443dc
MR
4338 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4339 (Fwindow_hchild): Rename to Fwindow_left_child.
4340 (Fwindow_next): Rename to Fwindow_next_sibling.
4341 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4342 (resize_window_check): Rename to window_resize_check.
4343 (resize_window_apply): Rename to window_resize_apply.
4344 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4345 (Fdelete_other_windows_internal, resize_frame_windows)
4346 (Fsplit_window_internal, Fdelete_window_internal)
4347 (grow_mini_window, shrink_mini_window)
4348 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4349
c7e73be5
JD
43502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4351
4352 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4353 (emacs_fixed_set_min_size): Remove.
4354 (emacs_fixed_new): Take frame as argument.
4355
4356 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4357 (_EmacsFixedPrivate): Remove minwidth/height.
4358 Add struct frame *f.
4359 (emacs_fixed_init): Initialize priv->f.
4360 (get_parent_class, emacs_fixed_set_min_size): Remove.
4361 (emacs_fixed_new): Set priv->f to argument.
4362 (emacs_fixed_get_preferred_width)
4363 (emacs_fixed_get_preferred_height): Use min_width/height from
4364 frames size_hint to set minimum and natural (Bug#8919).
4365 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4366 and use min_width/height from frames size_hint to set
4367 min_width/height (Bug#8919).
4368
4369 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4370 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4371 Fix indentation.
c7e73be5 4372
cf99dcf8
EZ
43732011-06-26 Eli Zaretskii <eliz@gnu.org>
4374
4375 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4376 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4377 called at ZV.
4378
029529ac
CY
43792011-06-26 Chong Yidong <cyd@stupidchicken.com>
4380
4381 * process.c (wait_reading_process_output): Bypass select if
4382 waiting for a cell while ignoring keyboard input, and input is
4383 pending. Suggested by Jan Djärv (Bug#8869).
4384
7a7ef429
PE
43852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Use gnulib's dup2 module instead of rolling our own.
4388 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4389
11fdef7d 43902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4391
4392 * dispnew.c (scrolling_window): Before scrolling, turn off a
4393 mouse-highlight in the window being scrolled.
4394
cd3520a4
JB
43952011-06-24 Juanma Barranquero <lekktu@gmail.com>
4396
4397 Move DEFSYM to lisp.h and use everywhere.
4398
4399 * character.h (DEFSYM): Move declaration...
4400 * lisp.h (DEFSYM): ...here.
4401
4402 * gnutls.c:
4403 * minibuf.c:
4404 * w32menu.c:
4405 * w32proc.c:
4406 * w32select.c: Don't include character.h.
4407
4408 * alloc.c (syms_of_alloc):
4409 * buffer.c (syms_of_buffer):
4410 * bytecode.c (syms_of_bytecode):
4411 * callint.c (syms_of_callint):
4412 * casefiddle.c (syms_of_casefiddle):
4413 * casetab.c (init_casetab_once):
4414 * category.c (init_category_once, syms_of_category):
4415 * ccl.c (syms_of_ccl):
4416 * cmds.c (syms_of_cmds):
4417 * composite.c (syms_of_composite):
4418 * dbusbind.c (syms_of_dbusbind):
4419 * dired.c (syms_of_dired):
4420 * dispnew.c (syms_of_display):
4421 * doc.c (syms_of_doc):
4422 * editfns.c (syms_of_editfns):
4423 * emacs.c (syms_of_emacs):
4424 * eval.c (syms_of_eval):
4425 * fileio.c (syms_of_fileio):
4426 * fns.c (syms_of_fns):
4427 * frame.c (syms_of_frame):
4428 * fringe.c (syms_of_fringe):
4429 * insdel.c (syms_of_insdel):
4430 * keymap.c (syms_of_keymap):
4431 * lread.c (init_obarray, syms_of_lread):
4432 * macros.c (syms_of_macros):
4433 * msdos.c (syms_of_msdos):
4434 * print.c (syms_of_print):
4435 * process.c (syms_of_process):
4436 * search.c (syms_of_search):
4437 * sound.c (syms_of_sound):
4438 * syntax.c (init_syntax_once, syms_of_syntax):
4439 * terminal.c (syms_of_terminal):
4440 * textprop.c (syms_of_textprop):
4441 * undo.c (syms_of_undo):
4442 * w32.c (globals_of_w32):
4443 * window.c (syms_of_window):
4444 * xdisp.c (syms_of_xdisp):
4445 * xfaces.c (syms_of_xfaces):
4446 * xfns.c (syms_of_xfns):
4447 * xmenu.c (syms_of_xmenu):
4448 * xsettings.c (syms_of_xsettings):
4449 * xterm.c (syms_of_xterm): Use DEFSYM.
4450
4228cf16
TZ
44512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4452
cd3520a4 4453 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4454
7fcccf1e
PE
44552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4456
7efb4e0e
PE
4457 Integer and buffer overflow fixes (Bug#8873).
4458
ff5844ad
PE
4459 * print.c (printchar, strout): Check for string overflow.
4460 (PRINTPREPARE, printchar, strout):
4461 Don't set size unless allocation succeeds.
4462
90532f02
PE
4463 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4464 for sizes. Check for string overflow more accurately.
4465 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4466
6d84508d
PE
4467 * macros.c: Integer and buffer overflow fixes.
4468 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4469 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4470 Use ptrdiff_t, not int, for sizes.
4471 Don't increment bufsize until after realloc succeeds.
4472 Check for size-calculation overflow.
4473 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4474
437b2cb4
PE
4475 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4476
8b9ac8b4
PE
4477 * lread.c: Integer overflow fixes.
4478 (read_integer): Radix is now EMACS_INT, not int,
4479 to improve quality of diagnostics for out-of-range radices.
4480 Calculate buffer size correctly for out-of-range radices.
4481 (read1): Check for integer overflow in radices, and in
4482 read-circle numbers.
82cb60d3
PE
4483 (read_escape): Avoid int overflow.
4484 (Fload, openp, read_buffer_size, read1)
4485 (substitute_object_recurse, read_vector, read_list, map_obarray):
4486 Use ptrdiff_t, not int, for sizes.
4487 (read1): Use EMACS_INT, not int, for sizes.
20270765 4488 Check for size overflow.
8b9ac8b4 4489
7fcccf1e
PE
4490 * image.c (cache_image): Check for size arithmetic overflow.
4491
bfbbd7e7
PE
4492 * lread.c: Integer overflow issues.
4493 (saved_doc_string_size, saved_doc_string_length)
4494 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4495 Now ptrdiff_t, not int.
4496 (read1): Don't assume doc string length fits in int. Check for
4497 out-of-range doc string lengths.
4498 (read_list): Don't assume file position fits in int.
39019e54 4499 (read_escape): Check for hex character overflow.
bfbbd7e7 4500
4e323265
LL
45012011-06-22 Leo Liu <sdl.web@gmail.com>
4502
4503 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4504 Move to minibuffer.el.
4505
85fece3e
PE
45062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4507
20b84ce9 4508 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4509 The following patches are for when GLYPH_DEBUG && !XASSERT.
4510 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4511 * dispnew.c (flush_stdout):
4512 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4513 Mark as externally visible.
4514 * dispnew.c (check_window_matrix_pointers): Now static.
4515 * dispnew.c (window_to_frame_vpos):
4516 * xfns.c (unwind_create_frame):
4517 * xterm.c (x_check_font): Remove unused local.
4518 * scroll.c (CHECK_BOUNDS):
4519 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4520 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4521 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4522 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4523 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4524 Now static.
4525 (debug_method_add): Use va_list and vsprintf rather than relying
4526 on undefined behavior with wrong number of arguments.
4527 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4528 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4529 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4530 since we're not interested in debugging glyphs with old libraries.
4531 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4532 GCC 4.6.0's static checking.
4533
0766b489
PE
45342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4535
31fd4b32
PE
4536 Integer overflow and signedness fixes (Bug#8873).
4537 A few related buffer overrun fixes, too.
4538
b79e8648
PE
4539 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4540
0766b489
PE
4541 * dispextern.h (struct face.stipple):
4542 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4543 (x_bitmap_mask, x_allocate_bitmap_record)
4544 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4545 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4546 (x_create_bitmap_from_xpm_data):
4547 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4548 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4549 (.bitmaps_last):
4550 * xfaces.c (load_pixmap):
4551 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4552 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4553 (.bitmaps_last, struct x_output.icon_bitmap):
4554 Use ptrdiff_t, not int, for bitmap indexes.
4555 (x_allocate_bitmap_record): Check for size overflow.
4556 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4557
b081724f
PE
4558 Use ptrdiff_t, not int, for overlay counts.
4559 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4560 * editfns.c (overlays_around, get_pos_property):
4561 * textprop.c (get_char_property_and_overlay):
4562 * xdisp.c (next_overlay_change, note_mouse_highlight):
4563 * xfaces.c (face_at_buffer_position):
21514da7
PE
4564 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4565 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4566 (Fnext_overlay_change, Fprevious_overlay_change)
4567 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4568 Use ptrdiff_t, not int, for sizes.
21514da7 4569 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4570
3de73e5e
PE
4571 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4572
2606c57b
PE
4573 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4574 (x_session_initialize): Do not assume string length fits in int.
4575
aaafe47a
PE
4576 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4577 This is unlikely, but can occur if DPI is outlandish.
4578
2674ddc8 4579 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4580 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4581
28154962
PE
4582 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4583 * xrdb.c (magic_file_p, search_magic_path):
4584 Omit last arg SUFFIX; it was always 0. All callers changed.
4585 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4586
7de51af5
PE
4587 * xfont.c (xfont_match): Avoid need for strlen.
4588
25ed6cc3
PE
4589 * xfns.c: Don't assume strlen fits in int.
4590 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4591
4eab31dd
PE
4592 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4593 not unsigned long, as we prefer signed integers. All callers changed.
4594 Detect integer overflow in repeat count.
4595 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4596 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4597
171e2a58
PE
4598 * termcap.c: Don't assume sizes fit in int and never overflow.
4599 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4600 (gobble_line): Check for size-calculation overflow.
4601
ad39faca 4602 * minibuf.c (Fread_buffer):
6e5bb2dc 4603 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4604 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4605 Don't assume string length fits in int.
4606
52c61c22 4607 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4608 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4609
b5b8c9e5
PE
4610 * font.c: Don't assume string length fits in int.
4611 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4612 Use ptrdiff_t, not int.
ccd6111c
PE
4613 (font_intern_prop): Don't assume string length fits in int.
4614 Don't assume integer property fits in fixnum.
4615 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4616
882f0d81 4617 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4618 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4619 Reformulate so as not to need the command string.
4620 Invoke gzip -cd rather than gunzip, as it's more portable.
4621 (lock_info_type, lock_file_1, lock_file):
4622 Don't assume pid_t and time_t fit in unsigned long.
4623 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4624 (current_lock_owner): Prefer signed type for sizes.
4625 Use memcpy, not strncpy, where memcpy is what is really wanted.
4626 Don't assume (via atoi) that time_t and pid_t fit in int.
4627 Check for time_t and/or pid_t out of range, e.g., via a network share.
4628 Don't alloca where an auto var works fine.
4629
93f4cf88
PE
4630 * fileio.c: Fix some integer overflow issues.
4631 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4632 Don't assume string length fits in int.
4633 (directory_file_name): Don't assume string length fits in long.
4634 (make_temp_name): Don't assume pid fits in int, or that its print
4635 length is less than 20.
4636
f3e92b69
PE
4637 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4638
1bfdaf10
PE
4639 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4640
35016e9a
PE
4641 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4642
3d1e65a1
PE
4643 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4644 We prefer signed integers, even for size calculations.
4645
0b963a93
PE
4646 * emacs.c: Don't assume string length fits in 'int'.
4647 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4648 (main): Don't invoke strlen when not needed.
4649
573f4b54
PE
4650 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4651 (XD_DEBUG_MESSAGE): Don't waste a byte.
4652
989f33ba
PE
4653 * callproc.c (getenv_internal_1, getenv_internal)
4654 (Fgetenv_internal):
965d34eb
PE
4655 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4656
e4d29b33
PE
4657 * lread.c (invalid_syntax): Omit length argument.
4658 All uses changed. This doesn't fix a bug, but it simplifies the
4659 code away from its former Hollerith-constant appearance, and it's
4660 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4661 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4662
eb49b136
PE
4663 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4664 This didn't break anything, but it didn't help either.
4665 It's confusing to put a bogus integer in a place where the actual
4666 value does not matter.
9f62aeb1 4667 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4668 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4669
15375a22
PE
4670 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4671 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4672 implementation.
b61cc01c
PE
4673 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4674 We prefer signed types, and the value cannot exceed the EMACS_INT
4675 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4676 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4677 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4678 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4679
53b2623d
PE
4680 * indent.c (sane_tab_width): New function.
4681 (current_column, scan_for_column, Findent_to, position_indentation)
4682 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4683 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4684
51cab52b 4685 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4686
f2ed8a70
PE
4687 * lisp.h (lint_assume): New macro.
4688 * composite.c (composition_gstring_put_cache):
4689 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4690
abe80cc6
PE
4691 * editfns.c, insdel.c:
4692 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4693
b02c740e
PE
4694 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4695
ebc96716
PE
4696 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4697
b4e50fa0 4698 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4699 Use much-faster test for byte-length change.
311d5d7c 4700 Don't assume string byte-length fits in 'int'.
a4cf38e4 4701 Check that character arg fits in 'int'.
85461888 4702 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4703
c0c1ee9f
PE
4704 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4705
a498d7f4
PE
4706 * fns.c (concat): Catch string overflow earlier.
4707 Do not rely on integer wraparound.
4708
51cab52b
PE
4709 * dispextern.h (struct it.overlay_strings_charpos)
4710 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4711 * xdisp.c (forward_to_next_line_start)
4712 (back_to_previous_visible_line_start)
4713 (reseat_at_next_visible_line_start, next_element_from_buffer):
4714 Don't arbitrarily truncate the value of 'selective' to int.
4715
76031fad
PE
4716 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4717
5eb55db9
PE
4718 * composite.c: Don't truncate sizes to 'int'.
4719 (composition_gstring_p, composition_reseat_it)
4720 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4721 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4722 not EMACS_UINT, for indexes.
5eb55db9 4723
0703a717
PE
4724 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4725
d6202519
PE
4726 * buffer.c: Include <verify.h>.
4727 (struct sortvec.priority, struct sortstr.priority):
8961a454 4728 Now EMACS_INT, not int.
c20998a7 4729 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4730 (struct sortstr.size, record_overlay_string)
4731 (struct sortstrlist.size, struct sortlist.used):
4732 Don't truncate size to int.
4733 (record_overlay_string): Check for size-calculation overflow.
d6202519 4734 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4735
d5a19415
JM
47362011-06-22 Jim Meyering <meyering@redhat.com>
4737
029529ac 4738 Don't leak an XBM-image-sized buffer
d5a19415
JM
4739 * image.c (xbm_load): Free the image buffer after using it.
4740
a9041e6c
PE
47412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4742
4743 Port to Sun C.
4744 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4745 that Sun C diagnosed.
4746 * fns.c (secure_hash): Fix pointer signedness issue.
4747 * intervals.c (static_offset_intervals): New function.
4748 (offset_intervals): Use it.
4749
7f3f739f
LL
47502011-06-21 Leo Liu <sdl.web@gmail.com>
4751
4752 * deps.mk (fns.o):
4753 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4754 sha512.h.
4755
4756 * fns.c (secure_hash): Rename from crypto_hash_function and change
4757 the first arg to accept symbols.
5b66d427 4758 (Fsecure_hash): New primitive.
7f3f739f
LL
4759 (syms_of_fns): New symbols.
4760
76147d94
DD
47612011-06-20 Deniz Dogan <deniz@dogan.se>
4762
4763 * process.c (Fset_process_buffer): Clarify return value in
4764 docstring.
4765
7d7d0045
CY
47662011-06-18 Chong Yidong <cyd@stupidchicken.com>
4767
4768 * dispnew.c (add_window_display_history): Use BVAR.
4769
4770 * xdisp.c (debug_method_add): Use BVAR.
4771 (check_window_end, dump_glyph_matrix, dump_glyph)
4772 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4773
4774 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4775 Likewise.
4776
4777 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4778 check till after the cache is created in init_frame_faces.
4779
ff2bc410
SM
47802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4781
4782 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4783
28177add
PE
47842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4785
dd3482fe
PE
4786 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4787 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4788 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4789
393d71f3 4790 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4791 * fileio.c (Finsert_file_contents):
4792 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4793 Remove the old (too-loose) buffer overflow checks.
4794 They weren't needed, since make_gap checks for buffer overflow.
4795 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4796 The old code merely checked for Emacs fixnum overflow, and relied
4797 on undefined (wraparound) behavior. The new code avoids undefined
4798 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4799
2e6813b0 4800 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4801 Tune. Don't use wider integers than needed. Don't use alloca.
4802 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4803
599a9e4f
PE
4804 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4805
99561444
PE
4806 * insdel.c, lisp.h (buffer_overflow): New function.
4807 (insert_from_buffer_1, replace_range, replace_range_2):
4808 * insdel.c (make_gap_larger):
4809 * editfns.c (Finsert_char):
4810 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4811
28177add
PE
4812 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4813
e69dafad
PE
48142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4815
4baa020d 4816 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4817
b1c46f02
PE
4818 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4819 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4820
e69dafad
PE
4821 * fileio.c: Don't assume EMACS_INT fits in off_t.
4822 (emacs_lseek): New static function.
4823 (Finsert_file_contents, Fwrite_region): Use it.
4824 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4825
566684ea
PE
4826 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4827
e6966cd6
PE
4828 * fns.c: Don't overflow int when computing a list length.
4829 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4830 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4831 truncation on 64-bit hosts. Check for QUIT every
4832 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4833 faster and is responsive enough.
4834 (Flength): Report an error instead of overflowing an integer.
4835 (Fsafe_length): Return a float if the value is not representable
4836 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4837 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4838 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4839
dd0b0efb
PE
4840 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4841 (header_size, word_size): New constants.
4842 (allocate_vectorlike): Don't check size overflow here.
4843 (allocate_vector): Check it here instead, since this is the only
4844 caller of allocate_vectorlike that could cause overflow.
4845 Check that the new vector's length is representable as a fixnum.
4846
86fe5cfe
PE
4847 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4848 The previous code was bogus. For example, next_almost_prime (32)
4849 returned 39, which is undesirable as it is a multiple of 3; and
4850 next_almost_prime (24) returned 25, which is a multiple of 5 so
4851 why was the code bothering to check for multiples of 7?
4852
80e88859
PE
4853 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4854
4a2f0ad6
PE
4855 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4856
f66c7cf8
PE
4857 Variadic C functions now count arguments with ptrdiff_t.
4858 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4859 Back then I didn't know that the Emacs coding style prefers signed int.
4860 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4861 were being counted with int, which may truncate counts on 64-bit
4862 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4863 * lisp.h (struct Lisp_Subr.function.aMANY)
4864 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4865 Arg counts are now ptrdiff_t, not size_t.
4866 All variadic functions and their callers changed accordingly.
4867 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4868 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4869 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4870 * callint.c (Fcall_interactively): Check arg count for overflow,
4871 to avoid potential buffer overrun. Use signed char, not 'int',
4872 for 'varies' array, so that we needn't bother to check its size
4873 calculation for overflow.
4874 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4875 * eval.c (apply_lambda):
4876 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4877 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4878 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4879
a1759b76
PE
4880 * callint.c (Fcall_interactively): Don't use index var as event count.
4881
d96be9fc
PE
4882 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4883 * mem-limits.h (SIZE): Remove; no longer used.
4884
a690a978 4885 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4886
578c21e6
PE
4887 Remove unnecessary casts.
4888 * xterm.c (x_term_init):
4889 * xfns.c (x_set_border_pixel):
4890 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4891 These aren't needed now that we assume ANSI C.
4892
96f53c6c
PE
4893 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4894 It's more likely to cause problems (due to unsigned overflow)
4895 than to cure them.
4896
83c77d31
PE
4897 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4898
ee2079f1
PE
4899 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4900
6da65536
PE
4901 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4902
7147c4a4
PE
4903 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4904
193e32d9
PE
4905 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4906
e5533da6
PE
4907 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4908
9910e595
PE
4909 GLYPH_CODE_FACE returns EMACS_INT, not int.
4910 * dispextern.h (merge_faces):
4911 * xfaces.c (merge_faces):
01103c44
PE
4912 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4913 Don't assume EMACS_INT fits in int.
9910e595 4914
2638320e
PE
4915 * character.h (CHAR_VALID_P): Remove unused parameter.
4916 * fontset.c, lisp.h, xdisp.c: All uses changed.
4917
045eb8d9
PE
4918 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4919
c1f134b5
PE
4920 * fns.c (concat): Minor tuning based on overflow analysis.
4921 This doesn't fix any bugs. Use int to hold character, instead
4922 of constantly refetching from Emacs object. Use XFASTINT, not
4923 XINT, for value known to be a character. Don't bother comparing
4924 a single byte to 0400, as it's always less.
4925
395fcb93 4926 * floatfns.c (Fexpt):
327eeec8
PE
4927 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4928
abbd3d23
PE
4929 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4930 for characters.
4931
684a03ef
PE
4932 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4933
0fed43f3
PE
4934 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4935 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4936 incorrectly succeed when S was a string, because 4294967386 was
4937 truncated before it was used.
4938
8fd02eb7
PE
4939 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4940 Otherwise, an out-of-range integer could cause undefined behavior
4941 on a 64-bit host.
4942
f8c86b69
PE
4943 * composite.c: Use int, not EMACS_INT, for characters.
4944 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4945 EMACS_INT, for values that are known to be in character range.
4946 This doesn't fix any bugs but is the usual style inside Emacs and
4947 may generate better code on 32-bit machines.
4948
34206dd2
PE
4949 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4950 This is for reasons similar to the recent CHAR_STRING fix.
4951 * charset.c (Fencode_char): Check that character arg is actually
4952 a character. Pass an int to ENCODE_CHAR.
4953 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4954 wider than 'int', as a compile-time check to prevent future regressions
4955 in this area.
4956
c5958d4c 4957 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4958
4959 Make sure a 64-bit char is never passed to CHAR_STRING.
4960 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4961 by silently ignoring the top 32 bits, allowing some values
4962 that were far too large to be valid characters.
4963 * character.h: Include <verify.h>.
4964 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4965 arguments are no wider than unsigned, as a compile-time check
4966 to prevent future regressions in this area.
4967 * data.c (Faset):
01103c44 4968 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4969 (Fsubst_char_in_region):
4970 * fns.c (concat):
4971 * xdisp.c (decode_mode_spec_coding):
4972 Adjust to CHAR_STRING's new requirement.
4973 * editfns.c (Finsert_char, Fsubst_char_in_region):
4974 * fns.c (concat): Check that character args are actually
4975 characters. Without this test, these functions did the wrong
4976 thing with wildly out-of-range values on 64-bit hosts.
4977
d37ca623
PE
4978 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4979 These casts should not be needed on 32-bit hosts, either.
4980 * keyboard.c (read_char):
4981 * lread.c (Fload): Remove casts to unsigned.
4982
ea204efb
PE
4983 * lisp.h (UNSIGNED_CMP): New macro.
4984 This fixes comparison bugs on 64-bit hosts.
4985 (ASCII_CHAR_P): Use it.
4986 * casefiddle.c (casify_object):
01103c44 4987 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4988 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4989 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4990 * dispextern.h (FACE_FROM_ID):
4991 * keyboard.c (read_char): Use UNSIGNED_CMP.
4992
41cb286c
PE
4993 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4994 not to EMACS_INT, to avoid GCC warning.
4995
4a1b9832
PE
4996 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4997
55daad71
PE
4998 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4999 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5000 isn't needed on 32-bit machines.
8f95c75c 5001
01103c44
PE
5002 * buffer.c (Fgenerate_new_buffer_name):
5003 Use EMACS_INT for count, not int.
0ceccced 5004 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5005
5006 * data.c (Qcompiled_function): Now static.
5007
c6f072e7
PE
5008 * window.c (window_body_lines): Now static.
5009
20ce5912
PE
5010 * image.c (gif_load): Rename local to avoid shadowing.
5011
9c4c5f81
PE
5012 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5013 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5014 * alloc.c (make_save_value): Integer argument is now of type
5015 ptrdiff_t, not int.
5016 (mark_object): Use ptrdiff_t, not int.
5017 * lisp.h (pD): New macro.
5018 * print.c (print_object): Use it.
5019
c0c5c8ae
PE
5020 * alloc.c: Use EMACS_INT, not int, to count objects.
5021 (total_conses, total_markers, total_symbols, total_vector_size)
5022 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5023 (total_free_floats, total_floats, total_free_intervals)
5024 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5025 Now EMACS_INT, not int. All uses changed.
5026 (Fgarbage_collect): Compute overall total using a double, so that
5027 integer overflow is less likely to be a problem. Check for overflow
5028 when converting back to an integer.
5a25e253
PE
5029 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5030 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5031 These were 'int' variables that could overflow on 64-bit hosts;
5032 they were never used, so remove them instead of repairing them.
211a0b2a 5033 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5034 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5035 Previously, this ceilinged at INT_MAX, but that doesn't work on
5036 64-bit machines.
e46bb31a 5037 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5038
c78baabf 5039 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5040 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5041 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5042 when a (possibly-narrower) signed value would do just as well.
5043 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5044
c9d624c6
PE
5045 * alloc.c: Catch some string size overflows that we were missing.
5046 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5047 for convenience in STRING_BYTES_MAX.
5048 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5049 The definition here is exact; the one in lisp.h was approximate.
5050 (allocate_string_data): Check for string overflow. This catches
5051 some instances we weren't catching before. Also, it catches
5052 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5053 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5054 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5055
c9d624c6
PE
5056 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5057 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5058 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5059
353032ce
PE
5060 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5061
2bccce07
PE
5062 * alloc.c (Fmake_string): Check for out-of-range init.
5063
0ac30604
SM
50642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5065
5066 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5067
c195f2de
JD
50682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5069
5070 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5071 xg_get_default_scrollbar_width.
5072
5073 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5074 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5075 (style_changed_cb): Call update_theme_scrollbar_width and call
5076 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5077 all frames (Bug#8505).
5078 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5079 Call gtk_window_set_resizable if HAVE_GTK3.
5080 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5081 and height if HAVE_GTK3 (Bug#8505).
5082 (scroll_bar_width_for_theme): New variable.
5083 (update_theme_scrollbar_width): New function.
5084 (xg_get_default_scrollbar_width): Move code to
5085 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5086 (xg_initialize): Call update_theme_scrollbar_width.
5087
5088 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5089
5090 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5091
e10ac9f1
MR
50922011-06-12 Martin Rudalics <rudalics@gmx.at>
5093
5094 * frame.c (make_frame): Call other_buffer_safely instead of
5095 other_buffer.
5096
5097 * window.c (temp_output_buffer_show): Call display_buffer with
5098 second argument Vtemp_buffer_show_specifiers and reset latter
5099 immediately after the call.
5100 (Vtemp_buffer_show_specifiers): New variable.
5101 (auto_window_vscroll_p, next_screen_context_lines)
5102 (Vscroll_preserve_screen_position): Remove leading asterisks from
5103 doc-strings.
5104
2d3c217e 51052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5106
7b7f97e8 5107 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5108 * buffer.c (Qclone_number): Remove for now, as it's unused.
5109 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5110 (record_buffer): Remove unused local.
5111 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5112 (set_frame_buffer_list): Remove; unused.
5113 * frame.h (other_visible_frames): Remove decl.
5114 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5115 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5116 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5117 if HAVE_GPM.
5118 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5119 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5120 Define only if HAVE_GPM.
5121 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5122 (update_hints_inhibit): Remove; never set. All uses removed.
5123 * widgetprv.h (emacsFrameClassRec): Remove decl.
5124 * window.c (delete_deletable_window): Now returns void, since it
5125 wasn't returning anything.
5126 (compare_window_configurations): Remove unused locals.
5127 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5128 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5129 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5130 the same widths as pointers. This follows up on the 2011-05-06 patch.
5131 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5132 * xterm.h: Likewise.
5133 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5134
1384b89e
JB
51352011-06-12 Juanma Barranquero <lekktu@gmail.com>
5136
5137 * makefile.w32-in: Update dependencies.
5138 (LISP_H): Add lib/intprops.h.
5139
1100a63c
CY
51402011-06-11 Chong Yidong <cyd@stupidchicken.com>
5141
5142 * image.c (gif_load): Add animation frame delay to the metadata.
5143 (syms_of_image): Use DEFSYM. New symbol `delay'.
5144
6198ccd0
MR
51452011-06-11 Martin Rudalics <rudalics@gmx.at>
5146
5147 * window.c (delete_deletable_window): Re-add.
5148 (Fset_window_configuration): Rewrite to handle dead buffers and
5149 consequently deletable windows.
5150 (window_tree, Fwindow_tree): Remove. Supply functionality in
5151 window.el.
5152 (compare_window_configurations): Simplify code.
5153
b6e3633c
AS
51542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5155
1ab0dee5
AS
5156 * image.c (imagemagick_load_image): Fix type mismatch.
5157 (Fimagemagick_types): Likewise.
5158
b6e3633c
AS
5159 * window.h (replace_buffer_in_windows): Declare.
5160
9397e56f
MR
51612011-06-11 Martin Rudalics <rudalics@gmx.at>
5162
5163 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5164 Qclone_number. Remove external declaration of Qdelete_window.
5165 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5166 code.
640c8776
SM
5167 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5168 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5169 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5170 buffer list implementation.
5171 (other_buffer_safely): New function.
5172 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5173 calls to replace_buffer_in_windows and
5174 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5175 if allowed.
5176 (record_buffer): Inhibit quitting and rewrite using quittable
5177 functions. Run Qbuffer_list_update_hook if allowed.
5178 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5179 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5180 Move switch-to-buffer to window.el.
9397e56f
MR
5181 (bury-buffer): Move to window.el.
5182 (Vbuffer_list_update_hook): New variable.
5183
5184 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5185 section.
5186
5187 * window.h (resize_frame_windows): Move up in code.
5188 (Fwindow_frame): Remove EXFUN.
5189 (replace_buffer_in_all_windows): Remove prototype.
5190 (replace_buffer_in_windows_safely): Add prototype.
5191
5192 * window.c: Declare Qdelete_window static again. Move down
5193 declaration of select_count.
5194 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5195 (Fother_window): Move to window.el.
5196 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5197 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5198 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5199 window.el.
5200 (replace_buffer_in_windows): Implement by calling
5201 Qreplace_buffer_in_windows.
5202 (replace_buffer_in_all_windows): Remove with some functionality
5203 moved into replace_buffer_in_windows_safely.
5204 (replace_buffer_in_windows_safely): New function.
5205 (select_window_norecord, select_frame_norecord): Move in front
5206 of run_window_configuration_change_hook. Remove now obsolete
5207 declarations.
640c8776
SM
5208 (Fset_window_buffer): Rewrite doc-string.
5209 Call Qrecord_window_buffer.
9397e56f
MR
5210 (keys_of_window): Move binding for other-window to window.el.
5211
b50691aa
CY
52122011-06-11 Chong Yidong <cyd@stupidchicken.com>
5213
5214 * dispextern.h (struct image): Replace data member, whose int_val
5215 and ptr_val fields were not used by anything, with a single
5216 lisp_val object.
5217
5218 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5219 (gif_clear_image, gif_load, imagemagick_load_image)
5220 (gs_clear_image, gs_load): Callers changed.
5221
3f754b86
PE
52222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5223
cca69397
PE
5224 * buffer.h: Include <time.h>, for time_t.
5225 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5226
109e28d0
PE
5227 Fix minor problems found by static checking.
5228
60737f02
PE
5229 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5230
4b66faf3
PE
5231 Make identifiers static if they are not used in other modules.
5232 * data.c (Qcompiled_function, Qframe, Qvector):
5233 * image.c (QimageMagick, Qsvg):
5234 * minibuf.c (Qmetadata):
5235 * window.c (resize_window_check, resize_root_window): Now static.
5236 * window.h (resize_window_check, resize_root_window): Remove decls.
5237
109e28d0
PE
5238 * window.c (window_deletion_count, delete_deletable_window):
5239 Remove; unused.
46a4ce9e
PE
5240 (window_body_lines): Now static.
5241 (Fdelete_other_windows_internal): Mark vars as initialized.
5242 Make sure 'resize_failed' is initialized.
5243 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5244 (resize_window_apply): Remove unused local.
5245 * window.h (delete_deletable_window): Remove decl.
5246
109e28d0 5247 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5248 (imagemagick_load_image): Fix pointer signedness problem by changing
5249 last arg from unsigned char * to char *. All uses changed.
5250 Also, fix a local for similar reasons.
5251 Remove unused locals. Remove locals to avoid shadowing.
5252 (fn_rsvg_handle_free): Remove; unused.
5253 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5254 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5255
3f754b86
PE
5256 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5257
2547adb1
CY
52582011-06-10 Chong Yidong <cyd@stupidchicken.com>
5259
5260 * image.c (gif_load): Fix omitted cast error introduced by
5261 2011-06-06 change.
5262
2c8e37d4
MR
52632011-06-10 Martin Rudalics <rudalics@gmx.at>
5264
5265 * window.h (resize_proportionally, orig_total_lines)
5266 (orig_top_line): Remove from window structure.
5267 (set_window_height, set_window_width, change_window_heights)
5268 (Fdelete_window): Remove prototypes.
5269 (resize_frame_windows): Remove duplicate declaration.
5270
440a42e3
EZ
52712011-06-10 Eli Zaretskii <eliz@gnu.org>
5272
5273 * window.h (resize_frame_windows, resize_window_check)
5274 (delete_deletable_window, resize_root_window)
5275 (resize_frame_windows): Declare prototypes.
5276
5277 * window.c (resize_window_apply): Make definition be "static" to
5278 match the prototype.
5279
562dd5e9
MR
52802011-06-10 Martin Rudalics <rudalics@gmx.at>
5281
5282 * window.c: Remove declarations of Qwindow_size_fixed,
5283 window_min_size_1, window_min_size_2, window_min_size,
5284 size_window, window_fixed_size_p, enlarge_window, delete_window.
5285 Remove static from declaration of Qdelete_window, it's
5286 temporarily needed by Fbury_buffer.
5287 (replace_window): Don't assign orig_top_line and
5288 orig_total_lines.
5289 (Fdelete_window, delete_window): Remove. Window deletion is
5290 handled by window.el.
640c8776
SM
5291 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5292 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5293 (Fdelete_other_windows): Remove. Deleting other windows is
5294 handled by window.el.
5295 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5296 handled in window.el.
5297 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5298 Window minimum sizes are handled in window.el.
5299 (shrink_windows, size_window, set_window_height)
5300 (set_window_width, change_window_heights, window_height)
5301 (window_width, CURBEG, CURSIZE, enlarge_window)
5302 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5303 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5304 handled in window.el.
5305 (make_dummy_parent): Rename to make_parent_window and give it a
5306 second argument horflag.
5307 (make_window): Don't set resize_proportionally any more.
5308 (Fsplit_window): Remove. Windows are split in window.el.
5309 (save_restore_action, save_restore_orig_size)
5310 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5311 Resize mini windows in window.el.
5312 (grow_mini_window, shrink_mini_window): Implement by calling
5313 Qresize_root_window_vertically, resize_window_check and
5314 resize_window_apply.
640c8776
SM
5315 (saved_window, Fset_window_configuration, save_window_save):
5316 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5317 resize_proportionally.
5318 (window_min_height, window_min_width): Move to window.el.
5319 (keys_of_window): Move bindings for delete-other-windows,
5320 split-window, delete-window and enlarge-window to window.el.
5321
5322 * buffer.c: Temporarily extern Qdelete_window.
5323 (Fbury_buffer): Temporarily call Qdelete_window instead of
5324 Fdelete_window (Fbury_buffer will move to window.el soon).
5325
5326 * frame.c (set_menu_bar_lines_1): Remove code handling
5327 orig_top_line and orig_total_lines.
5328
5329 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5330 set_window_height but set heights directly.
5331 (change_frame_size_1): Use resize_frame_windows.
5332
5333 * xdisp.c (init_xdisp): Don't use set_window_height but set
5334 heights directly.
5335
640c8776
SM
5336 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5337 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5338 run_window_configuration_change_hook.
5339
5340 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5341 instead of change_window_heights and run
5342 run_window_configuration_change_hook.
5343
1a13852e
MR
53442011-06-09 Martin Rudalics <rudalics@gmx.at>
5345
5346 * window.c (replace_window): Rename second argument REPLACEMENT to
5347 NEW. New third argument SETFLAG. Rewrite.
5348 (delete_window, make_dummy_parent): Call replace_window with
5349 third argument 1.
5350 (window_list_1): Move down in code.
5351 (run_window_configuration_change_hook): Move set_buffer part
5352 before select_frame_norecord part in order to unwind correctly.
5353 Rename count1 to count.
5354 (recombine_windows, delete_deletable_window, resize_root_window)
5355 (Fdelete_other_windows_internal)
5356 (Frun_window_configuration_change_hook, make_parent_window)
5357 (resize_window_check, resize_window_apply, Fresize_window_apply)
5358 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5359 (Fdelete_window_internal, Fresize_mini_window_internal):
5360 New functions.
1a13852e
MR
5361 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5362
f3d1777e
MR
53632011-06-08 Martin Rudalics <rudalics@gmx.at>
5364
496e208e
MR
5365 * window.h (window): Add some new members to window structure -
5366 normal_lines, normal_cols, new_total, new_normal, clone_number,
5367 splits, nest, prev_buffers, next_buffers.
5368 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5369 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5370
f3d1777e
MR
5371 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5372 Remove.
496e208e
MR
5373 (make_dummy_parent): Set new members of windows structure.
5374 (make_window): Move down in code. Handle new members of window
5375 structure.
5376 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5377 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5378 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5379 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5380 (Fset_window_next_buffers, Fset_window_clone_number):
5381 New functions.
496e208e
MR
5382 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5383 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5384 Doc-string fixes.
5385 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5386 Argument WINDOW can be now internal window too.
5387 (Fwindow_use_time): Move up in code.
5388 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5389 Rewrite doc-string.
5390 (Fset_window_configuration, saved_window)
5391 (Fcurrent_window_configuration, save_window_save): Handle new
5392 members of window structure.
b9e809c2
MR
5393 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5394 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5395 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5396 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5397 Qget_mru_window, Qresize_root_window,
5398 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5399 Qauto_buffer_name; staticpro them.
f3d1777e 5400
abde8f8c
MR
54012011-06-07 Martin Rudalics <rudalics@gmx.at>
5402
5403 * window.c (Fwindow_total_size, Fwindow_left_column)
5404 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5405 (Fwindow_list_1): New functions.
5406 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5407 (Fwindow_width, Fscroll_left, Fscroll_right):
5408 Use window_body_cols instead of window_box_text_cols.
5409 (delete_window, Fset_window_configuration):
5410 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5411 (delete_all_subwindows): Take a window as argument and not a
5412 structure. Rewrite.
190b47e6
MR
5413 (window_loop): Remove handling of GET_LRU_WINDOW and
5414 GET_LARGEST_WINDOW.
5415 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5416
5417 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5418 window_box_text_cols. delete_all_subwindows now takes a
5419 Lisp_Object as argument.
abde8f8c 5420
640c8776
SM
5421 * indent.c (compute_motion, Fcompute_motion):
5422 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5423
fa8a67e6
MR
5424 * frame.c (delete_frame): Call delete_all_subwindows with root
5425 window as argument.
5426
a54e3482
DC
54272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5428
5429 * fns.c (Fputhash): Document return value.
5430
60002bf5
CY
54312011-06-06 Chong Yidong <cyd@stupidchicken.com>
5432
5433 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5434
0c671da6 54352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5436
b862a52a 5437 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5438
be44ca6c
PE
5439 Check for overflow when converting integer to cons and back.
5440 * charset.c (Fdefine_charset_internal, Fdecode_char):
5441 Use cons_to_unsigned to catch overflow.
5442 (Fencode_char): Use INTEGER_TO_CONS.
5443 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5444 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5445 * data.c (long_to_cons, cons_to_long): Remove.
5446 (cons_to_unsigned, cons_to_signed): New functions.
5447 These signal an error for invalid or out-of-range values.
5448 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5449 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5450 * font.c (Ffont_variation_glyphs):
5451 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5452 * lisp.h: Include <intprops.h>.
5453 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5454 (cons_to_signed, cons_to_unsigned): New decls.
5455 (long_to_cons, cons_to_long): Remove decls.
5456 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5457 (Fprimitive_undo): Use CONS_TO_INTEGER.
5458 * xfns.c (Fx_window_property): Likewise.
5459 * xselect.c: Include <limits.h>.
5460 (x_own_selection, selection_data_to_lisp_data):
5461 Use INTEGER_TO_CONS.
5462 (x_handle_selection_request, x_handle_selection_clear)
5463 (x_get_foreign_selection, Fx_disown_selection_internal)
5464 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5465 (lisp_data_to_selection_data): Use cons_to_unsigned.
5466 (x_fill_property_data): Use cons_to_signed.
5467 Report values out of range.
5468
d1f3d2af
PE
5469 Check for buffer and string overflow more precisely.
5470 * buffer.h (BUF_BYTES_MAX): New macro.
5471 * lisp.h (STRING_BYTES_MAX): New macro.
5472 * alloc.c (Fmake_string):
5473 * character.c (string_escape_byte8):
5474 * coding.c (coding_alloc_by_realloc):
5475 * doprnt.c (doprnt):
5476 * editfns.c (Fformat):
5477 * eval.c (verror):
5478 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5479 since they may not be the same number.
5480 * editfns.c (Finsert_char):
5481 * fileio.c (Finsert_file_contents):
5482 Likewise for BUF_BYTES_MAX.
5483
dd52fcea
PE
5484 * image.c: Use ptrdiff_t, not int, for sizes.
5485 (slurp_file): Switch from int to ptrdiff_t.
5486 All uses changed.
5487 (slurp_file): Check that file size fits in both size_t (for
5488 malloc) and ptrdiff_t (for sanity and safety).
5489
7f9bbdbb
PE
5490 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5491 if b->modtime has its maximal value.
5492
dfe18f82
PE
5493 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5494
84acfcf0
PE
5495 Don't assume time_t can fit into int.
5496 * buffer.h (struct buffer.modtime): Now time_t, not int.
5497 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5498 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5499
ccd9a01a
PE
5500 Minor fixes for signed vs unsigned integers.
5501 * character.h (MAYBE_UNIFY_CHAR):
5502 * charset.c (maybe_unify_char):
5503 * keyboard.c (read_char, reorder_modifiers):
5504 XINT -> XFASTINT, since the integer must be nonnegative.
5505 * ftfont.c (ftfont_spec_pattern):
5506 * keymap.c (access_keymap, silly_event_symbol_error):
5507 XUINT -> XFASTINT, since the integer must be nonnegative.
5508 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5509 since it makes no difference and we prefer signed.
5510 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5511 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5512 nonnegative.
5513
d6d100dd
SM
55142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5515
5516 * window.h (Fwindow_frame): Declare.
5517
2b6148e4
PE
55182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5519
5520 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5521 (SPARE_MEMORY): Always define.
5522 (LARGE_REQUEST): Remove.
5523 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5524
f230ecc9
MR
55252011-06-06 Martin Rudalics <rudalics@gmx.at>
5526
727e958e
MR
5527 * lisp.h: Move EXFUNS for Fframe_root_window,
5528 Fframe_first_window and Fset_frame_selected_window to window.h.
5529
5530 * window.h: Move EXFUNS for Fframe_root_window,
5531 Fframe_first_window and Fset_frame_selected_window here from
5532 lisp.h.
5533
5534 * frame.c (Fwindow_frame, Fframe_first_window)
5535 (Fframe_root_window, Fframe_selected_window)
5536 (Fset_frame_selected_window): Move to window.c.
5537 (Factive_minibuffer_window): Move to minibuf.c.
5538 (Fother_visible_frames_p): New function.
5539
5540 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5541
f230ecc9
MR
5542 * window.c (decode_window, decode_any_window): Move up in code.
5543 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5544 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5545 (Fwindow_buffer): Move up and rewrite doc-string.
5546 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5547 (Fwindow_prev): New functions.
727e958e
MR
5548 (Fwindow_frame): Move here from frame.c. Accept any window as
5549 argument.
5550 (Fframe_root_window, Fframe_first_window)
5551 (Fframe_selected_window): Move here from frame.c. Accept frame
5552 or arbitrary window as argument. Update doc-strings.
5553 (Fminibuffer_window): Move up in code.
5554 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5555 (Fset_frame_selected_window): Move here from frame.c.
5556 Marginal rewrite.
727e958e
MR
5557 (Fselected_window, select_window, Fselect_window): Move up in
5558 code. Minor doc-string fixes.
f230ecc9 5559
4d09bcf6
PE
55602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5561
5562 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5563 Do not assume that spare memory exists; that assumption is valid
5564 only if SYSTEM_MALLOC.
5565 (LARGE_REQUEST): New macro, so that the issue of large requests
5566 is separated from the issue of spare memory.
5567
810928a2
AS
55682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5569
172418ad
AS
5570 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5571 format. (Bug#8806)
5572
43f862f7
AS
5573 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5574
810928a2
AS
5575 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5576 before statements.
5577
a059fe24
JD
55782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5579
5580 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5581
5582 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5583
5584 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5585 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5586
989bf368
JB
55872011-06-05 Juanma Barranquero <lekktu@gmail.com>
5588
5589 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5590
4b80f674
CY
55912011-06-04 Chong Yidong <cyd@stupidchicken.com>
5592
5593 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5594 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5595 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5596 New error handlers.
4b80f674
CY
5597 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5598 Obey Vx_select_enable_clipboard_manager. Catch errors in
5599 x_clipboard_manager_save (Bug#8779).
5600 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5601 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5602
99a33b77 56032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5604
5605 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5606
99a33b77 56072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5608
5609 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5610 in the current matrix if keep_current_p is non-zero.
5611
8264569d
EZ
56122011-06-04 Eli Zaretskii <eliz@gnu.org>
5613
5614 * bidi.c (bidi_level_of_next_char): Fix last change.
5615
57f97249
EZ
56162011-06-03 Eli Zaretskii <eliz@gnu.org>
5617
fec2107c 5618 Support bidi reordering of text covered by display properties.
57f97249 5619
fec2107c
EZ
5620 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5621 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5622 (bidi_cache_search, bidi_cache_iterator_state)
5623 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5624 (bidi_level_of_next_char, bidi_move_to_visually_next):
5625 Support character positions inside a run of characters covered by a
fec2107c
EZ
5626 display string.
5627 (bidi_paragraph_init, bidi_resolve_explicit_1)
5628 (bidi_level_of_next_char): Call bidi_fetch_char and
5629 bidi_fetch_char_advance instead of FETCH_CHAR and
5630 FETCH_CHAR_ADVANCE.
5631 (bidi_init_it): Initialize new members.
5632 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5633 definitions.
5634 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5635 instead of using explicit *_CHAR codes.
d6d100dd
SM
5636 (bidi_resolve_explicit, bidi_resolve_weak):
5637 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5638 bidirectional text is supported only in multibyte buffers.
5639 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5640 it to initialize the frame_window_p member of struct bidi_it.
5641 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5642 (bidi_resolve_explicit, bidi_resolve_weak)
5643 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5644 bidi_it->nchars is non-positive.
5645 (bidi_level_of_next_char): Don't try to lookup the cache for the
5646 next/previous character if nothing is cached there yet, or if we
5647 were just reseat()'ed to a new position.
c40e2fb2 5648
0e14fe90
EZ
5649 * xdisp.c (set_cursor_from_row): Set start and stop points
5650 according to the row's direction when priming the loop that looks
5651 for the glyph on which to display cursor.
5652 (single_display_spec_intangible_p): Function deleted.
5653 (display_prop_intangible_p): Reimplement to call
5654 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5655 Accept 3 additional arguments needed by handle_display_spec.
5656 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5657 values: lists, `(when COND...)' forms, etc.
5658 (single_display_spec_string_p): Support property values that are
5659 lists with the argument STRING its top-level element.
5660 (display_prop_string_p): Fix the condition for processing a
5661 property that is a list to be consistent with handle_display_spec.
fec2107c 5662 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5663 last portion of handle_display_prop.
5664 (compute_display_string_pos): Accept additional argument
5665 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5666 value of a `display' property is a "replacing spec".
5667 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5668 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5669 the display property, but just return a value indicating whether
5670 the display property will replace the characters it covers.
5671 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5672 frame_window_p members of struct bidi_it.
d6d100dd
SM
5673 (compute_display_string_pos, compute_display_string_end):
5674 New functions.
fec2107c
EZ
5675 (push_it): Accept second argument POSITION, where pop_it should
5676 jump to continue iteration.
5677 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5678
fec2107c
EZ
5679 * keyboard.c (adjust_point_for_property): Adjust the call to
5680 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5681
5682 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5683 (bidi_init_it): Update prototypes.
5684 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5685 (compute_display_string_pos, compute_display_string_end):
5686 Declare prototypes.
fec2107c
EZ
5687 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5688 EMACS_INT.
fc6f18ce 5689
40087514 56902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5691
57f53182
PE
5692 Malloc failure behavior now depends on size of allocation.
5693 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5694 * lisp.h: Change signatures accordingly.
5695 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5696 All callers changed. (Bug#8762)
5697
5698 * gnutls.c: Use Emacs's memory allocators.
5699 Without this change, the gnutls library would invoke malloc etc.
5700 directly, which causes problems on non-SYNC_INPUT hosts, and which
5701 runs afoul of improving memory_full behavior. (Bug#8761)
5702 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5703 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5704 xfree instead of the default malloc, realloc, free.
5705 (Fgnutls_boot): No need to check for memory allocation failure,
5706 since xmalloc does that for us.
5707
ac32cd99 5708 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5709 * category.c (hash_get_category_set):
5710 * ccl.c (ccl_driver):
5711 * charset.c (Fdefine_charset_internal):
5712 * charset.h (struct charset.hash_index):
5713 * composite.c (get_composition_id, gstring_lookup_cache)
5714 (composition_gstring_put_cache):
5715 * composite.h (struct composition.hash_index):
5716 * dispextern.h (struct image.hash):
5717 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5718 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5719 (hashfn_equal, hashfn_user_defined, make_hash_table)
5720 (maybe_resize_hash_table, hash_lookup, hash_put)
5721 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5723 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5724 * image.c (make_image, search_image_cache, lookup_image)
5725 (xpm_put_color_table_h):
5726 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5727 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5728 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5729 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5730 * alloc.c (allocate_vectorlike):
5731 Check for overflow in vector size calculations.
5732 * ccl.c (ccl_driver):
5733 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5734 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5735 need to be updated by these changes.
40087514
PE
5736 * fns.c (make_hash_table, maybe_resize_hash_table):
5737 Check for integer overflow with large hash tables.
0de4bb68
PE
5738 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5739 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5740 (SXHASH_REDUCE): New macro.
5741 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5742 Use it instead of discarding useful hash info with large hash values.
5743 (sxhash_float): New function.
5744 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5745 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5746 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5747 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5748 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5749 Adjust signatures to match updated version of code.
5750 (consing_since_gc): Now EMACS_INT, since a single hash table can
5751 use more than INT_MAX bytes.
5752
698d32e2
DN
57532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5754
5755 Make it possible to build with GCC-4.6+ -O2 -flto.
5756
5757 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5758
fd6fa53f
SM
57592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5760
5761 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5762 Call minibuffer-inactive-mode.
5763
864db017
JB
57642011-05-31 Juanma Barranquero <lekktu@gmail.com>
5765
5766 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5767 Update dependencies.
5768
2ad0baf4
DN
57692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5770
5771 * data.c (init_data): Remove code for UTS, this system is not
5772 supported anymore.
5773
4fcc2638
DN
57742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5775
5776 Don't force ./temacs to start in terminal mode.
5777
5778 * frame.c (make_initial_frame): Initialize faces in all cases, not
5779 only when CANNOT_DUMP is defined.
5780 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5781
c56e0fd5
DN
57822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5783
5784 * dispnew.c (add_window_display_history): Use const for the string
5785 pointer. Remove declaration, not needed.
5786
333d54da 57872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5788
55d4c1b2 5789 Use 'inline', not 'INLINE'.
333d54da 5790 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5791 * alloc.c, fontset.c (INLINE): Remove.
5792 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5793 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5794 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5795 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5796 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5797
738db178
DN
57982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5799
5800 Make it possible to run ./temacs.
5801
5802 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5803 syms_of_callproc does the same thing. Remove test for
5804 "initialized", do it in the caller.
5805 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5806
620c53a6
SM
58072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5808
5809 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5810 (read_minibuf): Use get_minibuffer.
5811 (syms_of_minibuf): Use DEFSYM.
5812 (Qmetadata): New var.
5813 * data.c (Qbuffer): Don't make it static.
5814 (syms_of_data): Use DEFSYM.
5815
e003a292
PE
58162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5817
5818 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5819 (CCL_CODE_MIN): New macro.
5820
ed008a6d
PE
58212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5822
3687c2ef
PE
5823 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5824
ed008a6d
PE
5825 * eval.c (Qdebug): Now static.
5826 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5827 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5828 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5829
d66c4c7c
CY
58302011-05-29 Chong Yidong <cyd@stupidchicken.com>
5831
5832 * image.c: Various fixes to ImageMagick code comments.
5833 (Fimagemagick_types): Doc fix.
5834
5fbc2025
PE
58352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5836
0196f88a
PE
5837 Minor fixes prompted by GCC 4.6.0 warnings.
5838
5839 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5840
5fbc2025
PE
5841 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5842 (x_clipboard_manager_save_all): Move extern decl to ...
5843 * xterm.h: ... here, so that it can be checked for consistency.
5844
1dd3c2d9
CY
58452011-05-29 Chong Yidong <cyd@stupidchicken.com>
5846
5847 * xselect.c (x_clipboard_manager_save_frame)
5848 (x_clipboard_manager_save_all): New functions.
5849 (Fx_clipboard_manager_save): Lisp function deleted.
5850
5851 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5852 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5853
5854 * xterm.h: Update prototype.
5855
5ba6571d
WX
58562011-05-28 William Xu <william.xwl@gmail.com>
5857
5858 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5859 exiting (Bug#8239).
5860
3eaff834
JM
58612011-05-28 Jim Meyering <meyering@redhat.com>
5862
e1900994 5863 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5864 * fns.c (to_uchar): Define.
5865 (crypto_hash_function): Use it to convert some newly-signed
5866 variables to unsigned, to avoid sign-extension bugs. For example,
5867 without this change, (md5 "truc") would evaluate to
5868 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5869 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5870 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5871
0f6990a7
PE
58722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 Integer overflow fixes.
c8a9ca5a 5875
08686060
PE
5876 * dbusbind.c: Serial number integer overflow fixes.
5877 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5878 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5879 to hold a serial number that is too large for a fixnum.
5880 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5881 Check for serial numbers out of range. Decode any serial number
59568bf0 5882 that was so large that it became a float. (Bug#8722)
08686060 5883
2d1fc3c7
PE
5884 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5885 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5886 Use XFASTINT rather than XUINT when numbers are nonnegative.
5887 (xd_append_arg, Fdbus_method_return_internal):
5888 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5889 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5890 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5891 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5892 (Bug#8722)
2d1fc3c7 5893
c8a9ca5a
PE
5894 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5895
519e1d69
PE
5896 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5897
6df6ae42 5898 ccl: Add integer overflow checks.
30569699
PE
5899 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5900 (IN_INT_RANGE): New macros.
5901 (ccl_driver): Use them to check for integer overflow when
5902 decoding a CCL program. Many of the new checks are whether XINT (x)
5903 fits in int; it doesn't always, on 64-bit hosts. The new version
5904 doesn't catch all possible integer overflows, but it's an
847044ea 5905 improvement. (Bug#8719)
30569699 5906
c11285dc
PE
5907 * alloc.c (make_event_array): Use XINT, not XUINT.
5908 There's no need for unsigned here.
5909
fdccd48e
PE
5910 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5911 This follows up to the 2011-05-06 change that substituted uintptr_t
5912 for EMACS_INT. This case wasn't caught back then.
5913
37910ab2
PE
5914 Rework Fformat to avoid integer overflow issues.
5915 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5916 now (part of C89). Include <verify.h>.
5917 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5918 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5919 (Fformat): Avoid the prepass trying to compute sizes; it was only
5920 approximate and thus did not catch overflow reliably. Instead, walk
5921 through the format just once, formatting and computing sizes as we go,
5922 checking for integer overflow at every step, and allocating a larger
5923 buffer as needed. Keep track separately whether the format is
5924 multibyte. Keep only the most-recently calculated precision, rather
5925 than them all. Record whether each argument has been converted to
5926 string. Use EMACS_INT, not int, for byte and char and arg counts.
5927 Support field widths and precisions larger than INT_MAX. Avoid
5928 sprintf's undefined behavior with conversion specifications such as %#d
5929 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5930 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5931 formatting out-of-range floating point numbers with int
9173deec 5932 formats. (Bug#8668)
37910ab2 5933
2e6578fb
PE
5934 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5935
0ae6bdee
PE
5936 * data.c: Avoid integer truncation in expressions involving floats.
5937 * data.c: Include <intprops.h>.
5938 (arith_driver): When there's an integer overflow in an expression
5939 involving floating point, convert the integers to floating point
5940 so that the resulting value does not suffer from catastrophic
5941 integer truncation. For example, on a 64-bit host (* 4
5942 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5943 Do not rely on undefined behavior after integer overflow.
5944
de883a70
PE
5945 merge count_size_as_multibyte, parse_str_to_multibyte
5946 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5947 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5948 Check for integer overflow.
5949 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5950 since it's now a duplicate of the other. This is more of
5951 a character than a buffer op, so better that it's in character.c.
5952 * fns.c, print.c: Adjust to above changes.
5953
2ff916cb
PE
59542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5955
5956 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5957
f1b54466
PE
59582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5959
fb1ac845
PE
5960 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5961 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5962 (x_clipboard_manager_save): Now static.
5963 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5964
f1b54466
PE
5965 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5966 (crypto_hash_function): Now static.
5967 Fix pointer signedness problems. Avoid unnecessary initializations.
5968
a9f737ee
CY
59692011-05-27 Chong Yidong <cyd@stupidchicken.com>
5970
5971 * termhooks.h (Vselection_alist): Make it terminal-local.
5972
5973 * terminal.c (create_terminal): Initialize it.
5974
5975 * xselect.c: Support for clipboard managers.
5976 (Vselection_alist): Move to termhooks.h as terminal-local var.
5977 (LOCAL_SELECTION): New macro.
5978 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5979 (symbol_to_x_atom): Remove gratuitous arg.
5980 (x_handle_selection_request, lisp_data_to_selection_data)
5981 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5982 (x_own_selection, x_get_local_selection, x_convert_selection):
5983 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5984 (some_frame_on_display): Delete unused function.
5985 (Fx_own_selection_internal, Fx_get_selection_internal)
5986 (Fx_disown_selection_internal, Fx_selection_owner_p)
5987 (Fx_selection_exists_p): New optional frame arg.
5988 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5989 (x_handle_selection_clear): Don't treat other terminals with the
5990 same keyboard specially. Use the terminal-local Vselection_alist.
5991 (x_clear_frame_selections): Use Frun_hook_with_args.
5992
5993 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5994
5995 * xterm.h: Add support for those atoms.
5996
e067f0c1
CY
59972011-05-26 Chong Yidong <cyd@stupidchicken.com>
5998
5999 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6000 (converted_selections, conversion_fail_tag): New global variables.
6001 (x_selection_request_lisp_error): Free the above.
6002 (x_get_local_selection): Remove unnecessary code.
6003 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6004 of converted selections stored in converted_selections.
6005 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6006 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6007 (x_convert_selection): New function.
6008 (x_handle_selection_event): Simplify.
6009 (x_get_foreign_selection): Don't ignore incoming requests while
6010 waiting for an answer; this will fail when we implement
6011 SAVE_TARGETS, and seems unnecessary anyway.
6012 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6013 (Vx_sent_selection_functions): Doc fix.
6014
0f4aebc0
LL
60152011-05-26 Leo Liu <sdl.web@gmail.com>
6016
6017 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6018
e61124cd
YM
60192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6020
6021 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6022
6023 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6024 for fringe update if it has periodic bitmap.
ac389d0c 6025 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6026 and fringe_bitmap_periodic_p.
6027
6028 * fringe.c (get_fringe_bitmap_data): New function.
6029 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6030 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6031 row. Mark glyph row for fringe update if periodicity changed.
6032
6033 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6034 for fringe update unless it has periodic bitmap.
6035
f16d9837
KH
60362011-05-25 Kenichi Handa <handa@m17n.org>
6037
6038 * xdisp.c (get_next_display_element): Set correct it->face_id for
6039 a static composition.
6040
e1b90ef6
LL
60412011-05-24 Leo Liu <sdl.web@gmail.com>
6042
6043 * deps.mk (fns.o):
6044 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6045
6046 * fns.c (crypto_hash_function, Fsha1): New function.
6047 (Fmd5): Use crypto_hash_function.
6048 (syms_of_fns): Add Ssha1.
6049
7400048f
PE
60502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6051
6052 * gnutls.c: Remove unused macros.
6053 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6054 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6055 Remove macros that are defined and never used.
6056 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6057
abb71cf4
CY
60582011-05-22 Chong Yidong <cyd@stupidchicken.com>
6059
6060 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6061 (Fx_get_selection_internal): Minor cleanup.
6062 (Fx_own_selection_internal): Rename arguments for consistency with
6063 select.el.
6064
6307db39
PE
60652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6066
6067 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6068
f3d4e0a4
CY
60692011-05-22 Chong Yidong <cyd@stupidchicken.com>
6070
6071 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6072
4d8ade89
YM
60732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6074
6075 * dispnew.c (scrolling_window): Don't exclude the case that the
6076 last enabled row in the desired matrix touches the bottom boundary.
6077
32078c8d
GM
60782011-05-21 Glenn Morris <rgm@gnu.org>
6079
6080 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6081 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6082 and add some more files.
32078c8d 6083
7285dc67
EZ
60842011-05-20 Eli Zaretskii <eliz@gnu.org>
6085
6086 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6087 report_file_error introduced by the change from 2011-05-07.
6088
89d1bd22
PE
60892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6090
6091 * systime.h (Time): Define only if emacs is defined.
6092 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6093 where the include path doesn't have X11/X.h by default. See
6094 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6095
cd394be1 60962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6097
6098 * composite.c (find_automatic_composition): Fix previous change.
6099
b9704ad9
GM
61002011-05-20 Glenn Morris <rgm@gnu.org>
6101
6102 * lisp.mk: New file, split from Makefile.in.
6103 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6104 (shortlisp): Remove.
6105 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6106
4a720484
GM
61072011-05-19 Glenn Morris <rgm@gnu.org>
6108
6109 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6110 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6111 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6112 (lisp): Set the order to that of loadup.el.
6113 (shortlisp): Make it a copy of $lisp.
6114 (SOME_MACHINE_LISP): Remove.
6115 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6116 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6117
a28d4396
KH
61182011-05-18 Kenichi Handa <handa@m17n.org>
6119
6120 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6121 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6122 (find_automatic_composition): Mostly rewrite for efficiency.
6123
a2b1fa8e
JB
61242011-05-18 Juanma Barranquero <lekktu@gmail.com>
6125
6126 * makefile.w32-in: Update dependencies.
6127
8e1f5610
CS
61282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6129
6130 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6131 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6132
7025ee00 61332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6134
cdfa6eab
PE
6135 Fix some integer overflow issues, such as string length overflow.
6136
06d6db33
PE
6137 * insdel.c (count_size_as_multibyte): Check for string overflow.
6138
2b4560a8
PE
6139 * character.c (lisp_string_width): Check for string overflow.
6140 Use EMACS_INT, not int, for string indexes and lengths; in
6141 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6142 the resulting string length overflows an EMACS_INT; instead,
6143 report a string overflow if no precision given. When checking for
6144 precision exhaustion, use a check that cannot possibly have
6145 integer overflow. (Bug#8675)
6146 * character.h (lisp_string_width): Adjust to new signature.
6147
cb93f9be
PE
6148 * alloc.c (string_overflow): New function.
6149 (Fmake_string): Use it. This doesn't change behavior, but saves
6150 a few bytes and will simplify future changes.
6151 * character.c (string_escape_byte8): Likewise.
6152 * lisp.h (string_overflow): New decl.
6153
1a1f3366
PE
6154 Fixups, following up to the user-interface timestamp change.
6155 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6156 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6157 * msdos.c (mouse_get_pos): Likewise.
6158 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6159 * w32gui.h (Time): Define by including "systime.h" rather than by
6160 declaring it ourselves. (Bug#8664)
6161
d4e3e4d3
PE
6162 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6163 * image.c (clear_image_cache): Likewise.
6164
f6a24d19
PE
6165 * term.c (term_mouse_position): Don't assume time_t wraparound.
6166
08dc5ae6
PE
6167 Be more systematic about user-interface timestamps.
6168 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6169 and sometimes 'EMACS_UINT', to represent these timestamps.
6170 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6171 This makes the code easier to follow, and makes it easier to catch
6172 integer overflow bugs such as Bug#8664.
6173 * frame.c (Fmouse_position, Fmouse_pixel_position):
6174 Use Time, not unsigned long, for user-interface timestamps.
6175 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6176 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6177 * keyboard.h (last_event_timestamp): Likewise.
6178 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6179 * menu.h (xmenu_show): Likewise.
6180 * term.c (term_mouse_position): Likewise.
6181 * termhooks.h (struct input_event.timestamp): Likewise.
6182 (struct terminal.mouse_position_hook): Likewise.
6183 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6184 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6185 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6186 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6187 what it was before.
6188 * menu.h, termhooks.h: Include "systime.h", for Time.
6189
8e55734a
PE
6190 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6191 Don't assume that the difference between two unsigned long values
6192 can fit into an integer. At this point, we know button_down_time
6193 <= event->timestamp, so the difference must be nonnegative, so
6194 there's no need to cast the result if double-click-time is
6195 nonnegative, as it should be; check that it's nonnegative, just in
6196 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6197 apart (about 25 days). (Bug#8664)
8e55734a 6198
841f1b75 6199 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6200 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6201
3e26f69c
PE
6202 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6203 that always fit in int. Use a sentinel instead of a counter, to
6204 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6205 * frame.h (struct frame): Use int for menu_bar_items_used
6206 instead of EMACS_INT, since it always fits in int.
3e26f69c 6207
5cc152c0
PE
6208 * menu.c (grow_menu_items): Check for int overflow.
6209
d89eb65e
PE
6210 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6211
5235bd3e
PE
6212 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6213 Before, the code was not consistent. These values cannot exceed
6214 2**31 - 1 so there's no need to make them unsigned.
6215 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6216 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6217 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6218 as modifiers.
6219 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6220
bc827e23
PE
6221 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6222 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6223 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6224 presumably because the widths might not match.
6225
78eb494e
PE
6226 * window.c (size_window): Avoid needless test at loop start.
6227
04f2d78b
CB
62282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6229
6230 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6231
d2fc7e3d 62322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6233
6234 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6235
d2fc7e3d 62362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6237
6238 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6239 `width' to `bar_area_x' and `bar_area_width', respectively.
6240 (x_scroll_run): Take account of fringe background extension.
6241
04f2d78b
CB
6242 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6243 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6244 `bar_area_width', respectively.
6245 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6246 background extension.
6247
79b70037
GM
62482011-05-10 Jim Meyering <meyering@redhat.com>
6249
6250 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6251
2f142cc5
JB
62522011-05-10 Juanma Barranquero <lekktu@gmail.com>
6253
6254 * image.c (Finit_image_library): Return t for built-in image types,
6255 like pbm and xbm. (Bug#8640)
6256
57679c86
AS
62572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6258
6259 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6260
888c9e86
EZ
62612011-05-07 Eli Zaretskii <eliz@gnu.org>
6262
b0512a1d
EZ
6263 * w32console.c (Fset_screen_color): Doc fix.
6264 (Fget_screen_color): New function.
6265 (syms_of_ntterm): Defsubr it.
6266
7285dc67
EZ
6267 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6268 unlink the temporary file if Fcall_process didn't create it in the
6269 first place.
6270 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6271 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6272 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6273 cue to call_process_cleanup not to close that handle.
6274
4d3fcc8e
BK
62752011-05-07 Ben Key <bkey76@gmail.com>
6276
6277 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6278 one of two shell specific rules, either bootstrap-temacs-CMD or
6279 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6280 to the previous implementation of the bootstrap-temacs rule.
6281 The bootstrap-temacs-CMD rule is similar to the previous
6282 implementation of the bootstrap-temacs rule except that it
6283 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6284 variable.
6285
6286 These changes, along with some changes to nt/configure.bat,
6287 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6288 earlier fix to add support for --cflags and --ldflags options
6289 that include quotes so that it works whether make uses cmd or
6290 sh as the shell.
6291
b4289b64
MA
62922011-05-06 Michael Albinus <michael.albinus@gmx.de>
6293
6294 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6295 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6296 is a constant.
6297 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6298 a string. Handle both cases.
6299 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6300 (Fdbus_register_method): Use Qinvalid_function.
6301
af4c0e28
JB
63022011-05-06 Juanma Barranquero <lekktu@gmail.com>
6303
6304 * makefile.w32-in: Update dependencies.
6305 (LISP_H): Add inttypes.h and stdin.h.
6306 (PROCESS_H): Add unistd.h.
6307
c51453d9
EZ
63082011-05-06 Eli Zaretskii <eliz@gnu.org>
6309
6310 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6311 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6312
8ff0ac3c 63132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6314
4c4b566b
PE
6315 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6316
aab2b9b5
PE
6317 * term.c (vfatal): Remove stray call to va_end.
6318 It's not needed and the C Standard doesn't allow it here anyway.
6319
c378da0b
PE
6320 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6321 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6322
288b08c7
PE
6323 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6324 bytes.
6325
e3601888
PE
6326 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6327
db6c0e74
PE
6328 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6329
dd5963ea
PE
6330 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6331
88c9450f
PE
6332 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6333
2f9442b8
PE
6334 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6335
c032b5f8
PE
6336 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6337 * charset.c (Fdefine_charset_internal): Don't initialize
6338 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6339 32-bit int (Bug#8600).
a108c10b
PE
6340
6341 * lread.c (read_integer): Be more consistent with string-to-number.
6342 Use string_to_number to do the actual conversion; this avoids
6343 rounding errors and fixes some other screwups. Without this fix,
6344 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6345 (digit_to_number): Move earlier, for benefit of read_integer.
6346 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6347 not a digit in any supported base. (Bug#8602)
a108c10b 6348
ad5f9eea
PE
6349 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6350
aec1708a
PE
6351 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6352 to match comment at start of function. This also removes a
6353 GCC warning about overflow in a 32+64-bit port.
6354
47be4ab5
PE
6355 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6356
371cac43
PE
6357 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6358 Reported by Stefan Monnier in
6359 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6360 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6361 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6362
d01a7826
PE
6363 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6364 (EMACS_UINTPTR): Likewise, with uintptr_t.
6365
7fd47d5c
PE
6366 * lisp.h: Prefer 64-bit EMACS_INT if available.
6367 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6368 on 32-bit hosts that have 64-bit int, so that they can access
6369 large files.
122b0c86
PE
6370 However, temporarily disable this change unless the temporary
6371 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6372
8727937b
PE
6373 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6374
8ac068ac
PE
6375 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6376 This removes an assumption that EMACS_INT and long are the same
6377 width as pointers. The assumption is true for Emacs porting targets
6378 now, but we want to make other targets possible.
6379 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6380 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6381 In the rest of the code, change types of integers that hold casted
6382 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6383 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6384 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6385 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6386 No need to cast type when ORing.
6387 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6388 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6389 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6390 assume EMACS_INT is the same width as char *.
6391 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6392 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6393 Remove no-longer-needed casts.
6394 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6395 (xg_tool_bar_help_callback, xg_make_tool_item):
6396 Use EMACS_INTPTR to hold an integer
6397 that will be cast to void *; this can avoid a GCC warning
6398 if EMACS_INT is not the same width as void *.
6399 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6400 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6401 (current_message_1, set_message_1):
6402 Use a local to convert to proper width without a cast.
6403 * xmenu.c (dialog_selection_callback): Likewise.
6404
ede49d71
PE
6405 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6406 Also, don't assume VALBITS / RAND_BITS is less than 5,
6407 and don't rely on undefined behavior when shifting a 1 left into
6408 the sign bit.
6409 * lisp.h (get_random): Change signature to match.
6410
2f30ecd0
PE
6411 * lread.c (hash_string): Use size_t, not int, for hash computation.
6412 Normally we prefer signed values; but hashing is special, because
6413 it's better to use unsigned division on hash table sizes so that
6414 the remainder is nonnegative. Also, size_t is the natural width
6415 for hashing into memory. The previous code used 'int', which doesn't
6416 retain enough info to hash well into very large tables.
6417 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6418
2a866e7b
PE
6419 * dbusbind.c: Don't possibly lose pointer info when converting.
6420 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6421 Use XPNTR rather than XHASH, so that the high-order bits of
6422 the pointer aren't lost when converting through void *.
6423
51639eac
PE
6424 * eval.c (Fautoload): Don't double-shift a pointer.
6425
92394119
PE
6426 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6427
dbdb9a7c
JB
64282011-05-06 Juanma Barranquero <lekktu@gmail.com>
6429
6430 * gnutls.c (DEF_GNUTLS_FN):
6431 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6432
db7a0b4f
AS
64332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6434
6435 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6436 marker. (Bug#8610)
6437
cd394be1 64382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6439
6440 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6441 New version that can reserve upto 2GB of heap space.
6442
f7ff1b0f 64432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6444
6445 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6446
639c109b
TZ
64472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6448
6449 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6450 `gnutls_certificate_set_x509_key_file'.
6451
d2127135
JB
64522011-05-05 Juanma Barranquero <lekktu@gmail.com>
6453
6454 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6455 Update dependencies.
6456
e968f4f3
JB
64572011-05-04 Juanma Barranquero <lekktu@gmail.com>
6458
6459 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6460 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6461 Remove unused parameter `fildes'.
6462 * process.c (read_process_output, send_process): Don't pass it.
6463
84d358f0
JB
64642011-05-04 Juanma Barranquero <lekktu@gmail.com>
6465
6466 Fix previous change: the library cache is defined in w32.c.
6467 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6468 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6469
0898ca10
JB
64702011-05-04 Juanma Barranquero <lekktu@gmail.com>
6471
6472 Implement dynamic loading of GnuTLS on Windows.
6473
6474 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6475 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6476 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6477 Declare.
6478
6479 * gnutls.c (Qgnutls_dll): Define.
6480 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6481 (gnutls_*): Declare function pointers.
6482 (init_gnutls_functions): New function to initialize function pointers.
6483 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6484 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6485 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6486 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6487 (emacs_gnutls_write, emacs_gnutls_read)
6488 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6489 (Fgnutls_available_p): New function.
6490 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6491 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6492 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6493
6494 * image.c: Include w32.h.
6495 (Vimage_type_cache): Delete.
6496 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6497 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6498 (w32_delayed_load): Move to w32.c.
6499
6500 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6501
6502 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6503 (w32_delayed_load): Move from image.c. When loading a library, record
6504 its filename in the :loaded-from property of the library id.
6505 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6506 Initialize and staticpro them.
6507 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6508
6509 * process.c: Include lisp.h before w32.h, not after.
6510 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6511 instead of gnutls_record_check_pending.
6512
6513 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6514
ff4de4aa
TZ
65152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6516
6517 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6518 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6519 as passed in.
6520
abe95abb
JD
65212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6522
6523 * xterm.c (x_set_frame_alpha): Do not set property on anything
6524 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6525
e16e55d4
JB
65262011-05-02 Juanma Barranquero <lekktu@gmail.com>
6527
6528 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6529
bafcf6a5
JB
65302011-05-02 Juanma Barranquero <lekktu@gmail.com>
6531
6532 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6533 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6534 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6535 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6536 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6537 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6538 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6539 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6540 (Qgnutls_bootprop_callbacks_verify): Make static.
6541
e7a6747f
AS
65422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6543
19ed11ba
AS
6544 * callproc.c: Indentation fixup.
6545
e7a6747f 6546 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6547 (wait_for_termination, interruptible_wait_for_termination):
6548 Move after wait_for_termination_1.
e7a6747f 6549
1ef14cb4
LMI
65502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6551
6552 * sysdep.c (interruptible_wait_for_termination): New function
6553 which is like wait_for_termination, but allows keyboard
6554 interruptions.
6555
6556 * callproc.c (Fcall_process): Add (:file "file") as an option for
6557 the STDOUT buffer.
6558 (Fcall_process_region): Ditto.
6559
330d880c
EZ
65602011-04-30 Eli Zaretskii <eliz@gnu.org>
6561
8db90b73
EZ
6562 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6563 rather than `XVECTOR (FOO)->size'.
6564
330d880c
EZ
6565 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6566 inttypes.h, as a gnulib replacement is used if it not available in
6567 system headers.
6568
15cbd324
EZ
65692011-04-21 Eli Zaretskii <eliz@gnu.org>
6570
6571 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6572 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6573 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6574
6575 * coding.c (coding_alloc_by_realloc): Error out if destination
6576 will grow beyond MOST_POSITIVE_FIXNUM.
6577 (decode_coding_emacs_mule): Abort if there isn't enough place in
6578 charbuf for the composition carryover bytes. Reserve an extra
6579 space for up to 2 characters produced in a loop.
6580 (decode_coding_iso_2022): Abort if there isn't enough place in
6581 charbuf for the composition carryover bytes.
6582
65832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6584
ae940cca
EZ
6585 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6586 aborting when %lld or %lll format is passed.
6587 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6588 %llo or %llx format is passed. (Bug#8545)
6589
03ab8921
EZ
6590 * window.c (window_scroll_line_based): Use a marker instead of
6591 simple variables to record original value of point. (Bug#7952)
6592
afda1437
EZ
6593 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6594 produced by %s or %c overflows available buffer space. (Bug#8545)
6595
f76dee0c
PE
65962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6597
6598 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6599 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6600
fdc5744d
JB
66012011-04-28 Juanma Barranquero <lekktu@gmail.com>
6602
6603 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6604
638f053a
JB
66052011-04-28 Juanma Barranquero <lekktu@gmail.com>
6606
6607 * keyboard.c (Qdelayed_warnings_hook): Define.
6608 (command_loop_1): Run `delayed-warnings-hook'
6609 if Vdelayed_warnings_list is non-nil.
6610 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6611 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6612
d178f871
EZ
66132011-04-28 Eli Zaretskii <eliz@gnu.org>
6614
6615 * doprnt.c (doprnt): Don't return value smaller than the buffer
6616 size if the message was truncated. (Bug#8545).
6617
b124fd93
JB
66182011-04-28 Juanma Barranquero <lekktu@gmail.com>
6619
6620 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6621 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6622
e810457d
PE
66232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6624
6625 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6626
ea51cceb
JB
66272011-04-27 Juanma Barranquero <lekktu@gmail.com>
6628
6629 * makefile.w32-in: Update dependencies.
6630
94dcfacf
EZ
66312011-04-27 Eli Zaretskii <eliz@gnu.org>
6632
6633 Improve `doprnt' and its usage. (Bug#8545)
6634 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6635 `format_end'. Remove support for %l as a conversion specifier.
6636 Don't use xrealloc. Improve diagnostics when the %l size modifier
6637 is used. Update the commentary.
6638
6639 * eval.c (verror): Simplify calculation of size_t.
6640
6641 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6642 messages.
6643
f61f41d7
PE
66442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6645
6646 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6647 change.
6648
96fb4434
PE
66492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6650
6651 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6652 This makes this file independent of the recent pseudovector change.
6653
671875da 66542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6655
69e9b5a3
PE
6656 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6657
b5f869a7 6658 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6659 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6660 Remove unused local.
c8926152 6661 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6662
841a1577 6663 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6664 GCC 4.6.0 optimizes based on type-based alias analysis.
6665 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6666 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6667 != &v->size, and therefore "v->size = 1; b->size = 2; return
6668 v->size;" must therefore return 1. This assumption is incorrect
6669 for Emacs, since it type-puns struct Lisp_Vector * with many other
6670 types. To fix this problem, this patch adds a new type struct
f904488f 6671 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6672 and pseudovectors, and helps optimizing compilers not get fooled
6673 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6674 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6675 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6676 the size member.
eab3844f
PE
6677 (XSETPVECTYPE): Rewrite in terms of new macro.
6678 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6679 This is a bit clearer, and further avoids the possibility of
6680 undesirable aliasing.
6681 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6682 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6683 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6684 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6685 (ASIZE): Now uses header.size rather than size.
6686 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6687 to avoid the hassle of writing XVECTOR (foo)->header.size.
6688 (struct vectorlike_header): New type.
eab3844f
PE
6689 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6690 object, to help avoid aliasing.
6691 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6692 (SUBRP): Likewise, since Lisp_Subr is a special case.
6693 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6694 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6695 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6696 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6697 changed to be "header.size" and "header.next".
6698 * buffer.h (struct buffer): Likewise.
6699 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6700 * frame.h (struct frame): Likewise.
6701 * process.h (struct Lisp_Process): Likewise.
6702 * termhooks.h (struct terminal): Likewise.
6703 * window.c (struct save_window_data, struct saved_window): Likewise.
6704 * window.h (struct window): Likewise.
6705 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6706 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6707 * buffer.c (init_buffer_once): Likewise.
6708 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6709 special case.
6710 * process.c (Fformat_network_address): Use local var for size,
6711 for brevity.
6712
0df1eac5
PE
6713 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6714
847ab9d1 6715 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6716 * data.c (atof): Remove decl; no longer used or needed.
6717 (digit_to_number): Move to lread.c.
6718 (Fstring_to_number): Use new string_to_number function, to be
6719 consistent with how the Lisp reader treats infinities and NaNs.
6720 Do not assume that floating-point numbers represent EMACS_INT
6721 without losing information; this is not true on most 64-bit hosts.
6722 Avoid double-rounding errors, by insisting on integers when
6723 parsing non-base-10 numbers, as the documentation specifies.
6724 * lisp.h (string_to_number): New decl, replacing ...
6725 (isfloat_string): Remove.
bc0a5c13 6726 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6727 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6728 appears to have been a coding error. Similarly, do not accept
6729 strings like +-1e0 as floating point numbers. Do not report
6730 overflow for integer overflows unless the base is not 10 which
6731 means we have no simple and reliable way to continue.
6732 Break out the floating-point parsing into a new
6733 function string_to_number, so that Fstring_to_number parses
6734 floating point numbers consistently with the Lisp reader.
04f2d78b 6735 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6736 (E_CHAR, EXP_INT): Remove, replacing with ...
6737 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6738 (string_to_number): New function, replacing isfloat_string.
6739 This function checks for valid syntax and produces the resulting
6740 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6741 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6742 so that overflow for non-base-10 numbers is reported only when
6743 there's no portable and simple way to convert to floating point.
452f4150 6744
67769ffc
PE
6745 * textprop.c (set_text_properties_1): Rewrite for clarity,
6746 and to avoid GCC warning about integer overflow.
6747
c20db43f
PE
6748 * intervals.h (struct interval): Use EMACS_INT for members
6749 where EMACS_UINT might cause problems. See
6750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6751 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6752 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6753 All uses changed.
37aa2f85
PE
6754 (offset_intervals): Tell GCC not to worry about length overflow
6755 when negating a negative length.
c20db43f 6756
2538aa2f
PE
6757 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6758 (overrun_check_free): Likewise.
6759
f2d3008d
PE
6760 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6761 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6762 word size.
6763
ec8df744
PE
6764 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6765 (gnutls_make_error): Rename local to avoid shadowing.
6766 (gnutls_emacs_global_deinit): ifdef out; not used.
6767 (Fgnutls_boot): Use const for pointer to readonly storage.
6768 Comment out unused local. Fix pointer signedness problems.
6769
640ee02d
PE
6770 * lread.c (openp): Don't stuff size_t into an 'int'.
6771 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6772 about possible signed overflow.
6773
6048fb2a
PE
6774 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6775 (GDK_KEY_g): Don't define if already defined.
6776 (xg_prepare_tooltip): Avoid pointer signedness problem.
6777 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6778
fa3c87e1
PE
6779 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6780 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6781
2172544b
PE
6782 * xfns.c (Fx_window_property): Simplify a bit,
6783 to make a bit faster and to avoid GCC 4.6.0 warning.
6784 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6785
9b821a21
PE
6786 * fns.c (internal_equal): Don't assume size_t fits in int.
6787
3c616cfa
PE
6788 * alloc.c (compact_small_strings): Tighten assertion a little.
6789
c2982e87
PE
6790 Replace pEd with more-general pI, and fix some printf arg casts.
6791 * lisp.h (pI): New macro, generalizing old pEd macro to other
6792 conversion specifiers. For example, use "...%"pI"d..." rather
6793 than "...%"pEd"...".
6794 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6795 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6796 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6797 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6798 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6799 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6800 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6801 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6802 64-bit hosts.
6803 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6804 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6805 * print.c (safe_debug_print, print_object): Likewise.
6806 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6807 to int.
6f04d126
PE
6808 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6809 avoiding the 0 flag, which is not portable.
c2982e87
PE
6810 * process.c (Fmake_network_process): Use pI to avoid cast.
6811 * region-cache.c (pp_cache): Likewise.
6812 * xdisp.c (decode_mode_spec): Likewise.
6813 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6814 behavior on 64-bit hosts with printf arg.
6f04d126 6815 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6816 (x_stop_queuing_selection_requests): Likewise.
6817 (x_get_window_property): Don't truncate byte count to an 'int'
6818 when tracing.
0b432f21 6819
5e073ec7
PE
6820 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6821 here, since it parses constructs like leading '-' and spaces,
6822 which are not wanted; and it overflows with large numbers.
6823 Instead, simply match F[0-9]+, which is what is wanted anyway.
6824
36372bf9
PE
6825 * alloc.c: Remove unportable assumptions about struct layout.
6826 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6827 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6828 (allocate_vectorlike, make_pure_vector): Use the new macros,
6829 plus offsetof, to remove unportable assumptions about struct layout.
6830 These assumptions hold on all porting targets that I know of, but
6831 they are not guaranteed, they're easy to remove, and removing them
6832 makes further changes easier.
6833
0b432f21
PE
6834 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6835 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6836 (string_overrun_cookie): Now const. Use initializers that
6837 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6838 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6839 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6840 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6841 multiple of sizeof (EMACS_INT); it need not be, if
6842 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6843 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6844
895009e1
JB
68452011-04-26 Juanma Barranquero <lekktu@gmail.com>
6846
6847 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6848
6a7a1b0b
TZ
68492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6850
6851 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6852 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6853 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6854
841a1577 68552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6856
6857 * lisp.h (Qdebug): List symbol.
895009e1 6858 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6859 * keyboard.c (debug-on-event): New variable.
6860 (handle_user_signal): Break into debugger when debug-on-event
6861 matches the current signal symbol.
6862
f2d3ba6f
DN
68632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6864
6865 * alloc.c (check_sblock, check_string_bytes)
6866 (check_string_free_list): Convert to standard C.
6867
42ce4c63
TZ
68682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6869
6870 * w32.c (emacs_gnutls_push): Fix typo.
6871
825cd63c
EZ
68722011-04-25 Eli Zaretskii <eliz@gnu.org>
6873
fb11d64d
EZ
6874 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6875 "cast to pointer from integer of different size".
6876
825cd63c
EZ
6877 Improve doprnt and its use in verror. (Bug#8545)
6878 * doprnt.c (doprnt): Document the set of format control sequences
6879 supported by the function. Use SAFE_ALLOCA instead of always
6880 using `alloca'.
6881
6882 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6883 is one byte too soon. Don't use xrealloc; instead xfree and
6884 xmalloc anew.
6885
e061a11b
TZ
68862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6887
6888 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6889 callbacks stage.
6890
6891 * gnutls.c: Renamed global_initialized to
6892 gnutls_global_initialized. Added internals for the
6893 :verify-hostname-error, :verify-error, and :verify-flags
6894 parameters of `gnutls-boot' and documented those parameters in the
6895 docstring. Start callback support.
9173deec
JB
6896 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6897 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6898 on error. Return error code.
e061a11b
TZ
6899 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6900 (emacs_gnutls_read): Likewise.
6901 (Fgnutls_boot): Return handshake error code.
6902 (emacs_gnutls_handle_error): New function.
6903 (wsaerror_to_errno): Likewise.
6904
6905 * w32.h (emacs_gnutls_pull): Add prototype.
6906 (emacs_gnutls_push): Likewise.
6907
6908 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6909 (emacs_gnutls_push): Likewise.
6910
69112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6912
6913 * process.c (wait_reading_process_output): Check if GnuTLS
6914 buffered some data internally if no FDs are set for TLS
6915 connections.
6916
6917 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6918 (LIBS): Link to USER_LIBS.
6919 ($(BLD)/gnutls.$(0)): New target.
6920
fa6996bc
EZ
69212011-04-24 Eli Zaretskii <eliz@gnu.org>
6922
eb35682e
EZ
6923 * xdisp.c (handle_single_display_spec): Rename the
6924 display_replaced_before_p argument into display_replaced_p, to
6925 make it consistent with the commentary. Fix typos in the
6926 commentary.
6927
e2ad650c
EZ
6928 * textprop.c (syms_of_textprop): Remove dead code.
6929 (copy_text_properties): Delete obsolete commentary about an
6930 interface that was deleted long ago. Fix typos in the description
6931 of arguments.
6932
1b2de274
EZ
6933 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6934 to changes in oldXMenu/XMenu.h from 2011-04-16.
6935 <menu_help_message, prev_menu_help_message>: Constify.
6936 (IT_menu_make_room): menu->help_text is now `const char **';
6937 adjust.
6938
6939 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6940 to changes in oldXMenu/XMenu.h from 2011-04-16.
6941 (struct XMenu): Declare `help_text' `const char **'.
6942
6943 * xfaces.c <Qunspecified>: Make extern again.
6944
6945 * syntax.c: Include sys/types.h before including regex.h, as
6946 required by Posix.
6947
762b15be
EZ
6948 * doc.c (get_doc_string): Improve the format passed to `error'.
6949
6950 * doprnt.c (doprnt): Improve commentary.
6951
6952 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6953
6954 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6955 them with etags.
6956
f1052e5d
EZ
6957 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6958 changes in globals.h immediately force recompilation.
762b15be
EZ
6959 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6960 $(CURDIR)/s/ms-w32.h.
6961 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6962
fa6996bc
EZ
6963 * character.c (Fchar_direction): Function deleted.
6964 (syms_of_character): Don't defsubr it.
6965 <char-direction-table>: Deleted.
6966
e6c3da20
EZ
69672011-04-23 Eli Zaretskii <eliz@gnu.org>
6968
6969 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6970 * doprnt.c: Include limits.h.
6971 (SIZE_MAX): New macro.
04f2d78b
CB
6972 (doprnt): Return a size_t value. 2nd arg is now size_t.
6973 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6974 Improve overflow protection. Support `l' modifier for integer
6975 conversions. Support %l conversion. Don't assume an EMACS_INT
6976 argument for integer conversions and for %c.
6977
6978 * lisp.h (doprnt): Restore prototype.
6979
6980 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6981 $(SRC)/character.h.
6982
6983 * Makefile.in (base_obj): Add back doprnt.o.
6984
6985 * deps.mk (doprnt.o): Add back prerequisites.
6986 (callint.o): Depend on character.h.
6987
6988 * eval.c (internal_lisp_condition_case): Include the handler
6989 representation in the error message.
6990 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6991 when breaking from the loop.
6992
6993 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6994
6995 * callint.c (Fcall_interactively): When displaying error message
6996 about invalid control letter, pass the character's codepoint, not
6997 a pointer to its multibyte form. Improve display of the character
6998 in octal and display also its hex code.
6999
7000 * character.c (char_string): Use %x to display the (unsigned)
7001 codepoint of an invalid character, to avoid displaying a bogus
7002 negative value.
7003
7004 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7005 `error', not SYMBOL_NAME itself.
7006
7007 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7008 character arguments to `error'.
7009
7010 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7011 to `error' in error message about FINAL_CHAR argument. Make sure
7012 FINAL_CHAR is a character, and use %c when it is passed as
7013 argument to `error'.
7014
4ffd0d6b 70152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7016
7017 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7018
7019 * w32.c: Include <time.h>.
7020 (sys_localtime): New function.
7021
4ffd0d6b 70222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7023
7024 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7025
4ffd0d6b 7026 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7027
4ffd0d6b 70282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7029
4ffd0d6b
GM
7030 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7031 zombies (Bug#8467).
aac0c6e3 7032
04c56954
EZ
70332011-04-19 Eli Zaretskii <eliz@gnu.org>
7034
7035 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7036 gl_state.e_property when gl_state.object is Qt.
7037
7038 * insdel.c (make_gap_larger): Remove limitation of buffer size
7039 to <= INT_MAX.
7040
16a43933
CY
70412011-04-18 Chong Yidong <cyd@stupidchicken.com>
7042
7043 * xdisp.c (lookup_glyphless_char_display)
7044 (produce_glyphless_glyph): Handle cons cell entry in
7045 glyphless-char-display.
7046 (Vglyphless_char_display): Document it.
7047
7048 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7049 glyphless-char-display.
7050
4581706e
CY
70512011-04-17 Chong Yidong <cyd@stupidchicken.com>
7052
7053 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7054
7055 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7056
7057 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7058 definition for no-X builds.
7059
4887c6e2 70602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7061
fd35b6f9
PE
7062 Static checks with GCC 4.6.0 and non-default toolkits.
7063
5c1ccb01
PE
7064 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7065
006c5daa
PE
7066 * process.c (keyboard_bit_set): Define only if SIGIO.
7067 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7068 (send_process): Repair possible setjmp clobbering.
7069
efc736d3
PE
7070 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7071
4e2fe2e6
PE
7072 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7073
f97334a2
PE
7074 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7075
4e75f29d
PE
7076 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7077 Define only if needed.
7078
90efadd1
PE
7079 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7080 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7081 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7082
3c647824
PE
7083 * dispextern.h (struct redisplay_interface): Rename param
7084 to avoid shadowing.
e264f262 7085 * termhooks.h (struct terminal): Likewise.
761383f4 7086 * xterm.c (xembed_send_message): Likewise.
3c647824 7087
b58c5c4a
PE
7088 * insdel.c (make_gap_smaller): Define only if
7089 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7090
cad59032
PE
7091 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7092 it.
7093
c339dc2e
PE
7094 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7095 so that we aren't warned about unused symbols.
7096
91a3e27b
PE
7097 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7098
399c71d3 7099 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7100
8ffc96f5
PE
7101 * xfns.c (x_real_positions): Mark locals as initialized.
7102
eef9bc79
PE
7103 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7104
098db9dd
PE
7105 * xterm.c: Fix problems found by static analysis with other toolkits.
7106 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7107 (x_dispatch_event): Declare static if USE_GTK, and
7108 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7109 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7110 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7111 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7112 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7113
eb18f6cc
PE
7114 * xmenu.c (menu_help_callback): Pointer type fixes.
7115 Use const pointers when pointing at readonly data. Avoid pointer
7116 signedness clashes.
7117 (FALSE): Remove unused macro.
7118 (update_frame_menubar): Remove unused decl.
7119
1fe72bf8
PE
7120 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7121
60d9e1db
PE
7122 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7123 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7124 (single_menu_item): Rename local to avoid shadowing.
7125
39261c26
PE
7126 * keyboard.c (make_lispy_event): Remove unused local var.
7127
018c5e19
PE
7128 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7129 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7130
63d2b86e
PE
7131 * bitmaps: Change bitmaps from unsigned char back to the X11
7132 compatible char. Avoid the old compiler warnings about
7133 out-of-range initializers by using, for example, '\xab' rather
7134 than 0xab.
7135
aefd87e1
PE
7136 * xgselect.c (xgselect_initialize): Check vs interface
7137 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7138
bf501fb9
PE
7139 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7140
e9829fdf
PE
7141 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7142 to read-only memory.
7143
1086c095
PE
7144 * fns.c (vector): Remove; this old hack is no longer needed.
7145
2baccd04 7146 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7147 Remove unused var.
dde42981 7148 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7149
72391843 7150 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7151
436c16df 7152 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7153 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7154 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7155
92bb796d 7156 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7157 (x_term_init): Remove local to avoid shadowing.
92bb796d 7158
764430a3 7159 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7160
7161 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7162 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7163
d1dfb56c
EZ
71642011-04-16 Eli Zaretskii <eliz@gnu.org>
7165
c4354cb4
EZ
7166 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7167
d1dfb56c
EZ
7168 Fix regex.c, syntax.c and friends for buffers > 2GB.
7169 * syntax.h (struct gl_state_s): Declare character position members
7170 EMACS_INT.
7171
7172 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7173
04f2d78b
CB
7174 * textprop.c (verify_interval_modification, interval_of):
7175 Declare arguments EMACS_INT.
d1dfb56c
EZ
7176
7177 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7178 EMACS_INT.
7179
7180 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7181
7182 * indent.c (Fvertical_motion): Local variable it_start is now
7183 EMACS_INT.
7184
7185 * regex.c (re_match, re_match_2, re_match_2_internal)
7186 (bcmp_translate, regcomp, regexec, print_double_string)
7187 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7188 (re_compile_pattern, re_exec): Declare arguments and local
7189 variables `size_t' and `ssize_t' and return values `regoff_t', as
7190 appropriate.
7191 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7192 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7193 <compile_stack_type>: `size' and `avail' are now `size_t'.
7194
7195 * regex.h <regoff_t>: Use ssize_t, not int.
7196 (re_search, re_search_2, re_match, re_match_2): Arguments that
7197 specify buffer/string position and length are now ssize_t and
7198 size_t. Return type is regoff_t.
7199
613052cd
BK
72002011-04-16 Ben Key <bkey76@gmail.com>
7201
7202 * nsfont.m: Fixed bugs in ns_get_family and
7203 ns_descriptor_to_entity that were caused by using free to
7204 deallocate memory blocks that were allocated by xmalloc (via
7205 xstrdup). This caused Emacs to crash when compiled with
7206 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7207 --enable-checking=xmallocoverrun). xfree is now used to
7208 deallocate these memory blocks.
7209
4170f62f 72102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7211
71b41406
PE
7212 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7213
9587a89d
PE
7214 emacs_write: Accept and return EMACS_INT for sizes.
7215 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7216 et seq.
7217 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7218 Accept and return EMACS_INT.
7219 (emacs_gnutls_write): Return the number of bytes written on
7220 partial writes.
7221 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7222 (emacs_read, emacs_write): Remove check for negative size, as the
7223 Emacs source code has been audited now.
9587a89d
PE
7224 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7225 (emacs_read, emacs_write): Use it.
273a5f82
PE
7226 * process.c (send_process): Adjust to the new signatures of
7227 emacs_write and emacs_gnutls_write. Do not attempt to store
7228 a byte offset into an 'int'; it might overflow.
9587a89d 7229 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7230
3e047f51
PE
7231 * sound.c: Don't assume sizes fit in 'int'.
7232 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7233 Return EMACS_INT, not int.
3e047f51 7234 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7235 Accept EMACS_INT, not int.
7236 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7237 record read return values.
7238
cc39a9db
BK
72392011-04-15 Ben Key <bkey76@gmail.com>
7240
c9d0ec6d
JB
7241 * keyboard.c (Qundefined): Don't declare static since it is used
7242 in nsfns.m.
7243 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7244 static since they are used in nsfont.m.
cc39a9db 7245
6c60eb9f
SM
72462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7247
7248 * process.c (Qprocessp): Don't declare static.
7249 * lisp.h (Qprocessp): Declare again.
7250
7990b61a
JB
72512011-04-15 Juanma Barranquero <lekktu@gmail.com>
7252
7253 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7254
5d4cb038
PE
72552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7256
8bd7b830 7257 Improve C-level modularity by making more things 'static'.
cd64ea1d 7258
e3b27b31
PE
7259 Don't publish debugger-only interfaces to other modules.
7260 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7261 (verify_bytepos, count_markers): Move decls to the only modules
7262 that need them.
7263 * region-cache.h (pp_cache): Likewise.
7264 * window.h (check_all_windows): Likewise.
7265 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7266
5d4cb038
PE
7267 * sysdep.c (croak): Now static, if
7268 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7269 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7270
7271 * alloc.c (refill_memory_reserve): Now static if
7272 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7273 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7274
e87b6180
PE
7275 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7276 Define only if USE_LUCID.
7277
ac64929e
PE
7278 * xrdb.c (x_customization_string, x_rm_string): Now static.
7279
6f37259d
PE
7280 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7281 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7282
1683e3ab
PE
7283 * xdisp.c (draw_row_with_mouse_face): Now static.
7284 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7285
de9c2632
PE
7286 * window.h (check_all_windows): Mark externally visible.
7287
2b96acb7
PE
7288 * window.c (window_deletion_count): Now static.
7289
7290 * undo.c: Make symbols static if they're not exported.
7291 (last_undo_buffer, last_boundary_position, pending_boundary):
7292 Now static.
7293
50436f33
PE
7294 * textprop.c (interval_insert_behind_hooks): Now static.
7295 (interval_insert_in_front_hooks): Likewise.
7296
64520e5c
PE
7297 * term.c: Make symbols static if they're not exported.
7298 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7299 (max_frame_lines, tty_set_terminal_modes):
7300 (tty_reset_terminal_modes, tty_turn_off_highlight):
7301 (get_tty_terminal): Now static.
7302 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7303 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7304 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7305 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7306 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7307
1fa53021
PE
7308 * sysdep.c: Make symbols static if they're not exported.
7309 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7310 Now static.
7311 (sigprocmask_set, full_mask): Remove; unused.
7312 (wait_debugging): Mark as visible.
7313 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7314 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7315
d4b43b22
PE
7316 * syntax.c (syntax_temp): Define only if !__GNUC__.
7317
b7c513d0
PE
7318 * sound.c (current_sound_device, current_sound): Now static.
7319
989b29ad
PE
7320 * search.c (searchbufs, searchbuf_head): Now static.
7321
13a55a78
PE
7322 * scroll.c (scroll_cost): Remove; unused.
7323 * dispextern.h (scroll_cost): Remove decl.
7324
de68a1fc
PE
7325 * region-cache.h (pp_cache): Mark as externally visible.
7326
40ccffa6
PE
7327 * process.c: Make symbols static if they're not exported.
7328 (process_tick, update_tick, create_process, chan_process):
7329 (Vprocess_alist, proc_buffered_char, datagram_access):
7330 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7331 (deactivate_process): Mark defn as static, as well as decl.
7332 * lisp.h (create_process): Remove decl.
7333 * process.h (chan_process, Vprocess_alist): Remove decls.
7334
ad64fc97
PE
7335 * print.c: Make symbols static if they're not exported.
7336 (print_depth, new_backquote_output, being_printed, print_buffer):
7337 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7338 (print_interval, print_number_index, initial_stderr_stream):
7339 Now static.
7340 * lisp.h (Fprinc): Remove decl.
7341 (debug_output_compilation_hack): Mark as externally visible.
7342
adddb265
PE
7343 * sysdep.c (croak): Move decl from here to syssignal.h.
7344 * syssignal.h (croak): Put it here, so the API can be checked when
7345 'croak' is called from dissociate_if_controlling_tty.
7346
1717ede2
PE
7347 * minibuf.c: Make symbols static if they're not exported.
7348 (minibuf_save_list, choose_minibuf_frame): Now static.
7349 * lisp.h (choose_minibuf_frame): Remove decl.
7350
fa5fb2bc
PE
7351 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7352
1e3890d1
PE
7353 * lread.c: Make symbols static if they're not exported.
7354 (read_objects, initial_obarray, oblookup_last_bucket_number):
7355 Now static.
7356 (make_symbol): Remove; unused.
7357 * lisp.h (initial_obarray, make_symbol): Remove decls.
7358
8a1414fa
PE
7359 * keyboard.c: Make symbols static if they're not exported.
7360 (single_kboard, recent_keys_index, total_keys, recent_keys):
7361 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7362 (this_single_command_key_start, echoing, last_auto_save):
7363 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7364 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7365 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7366 (Vlispy_mouse_stem, double_click_count):
7367 Now static.
7368 (force_auto_save_soon): Define only if SIGDANGER.
7369 (ignore_mouse_drag_p): Now static if
7370 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7371 (print_help): Remove; unused.
7372 (stop_character, last_timer_event): Mark as externally visible.
7373 * keyboard.h (ignore_mouse_drag_p): Declare only if
7374 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7375 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7376 * lisp.h (echoing): Remove decl.
7377 (force_auto_save_soon): Declare only if SIGDANGER.
7378 * xdisp.c (redisplay_window): Simplify code, to make it more
7379 obvious that ignore_mouse_drag_p is not accessed if !defined
7380 USE_GTK && !defined HAVE_NS.
7381
93ea6e8f
PE
7382 * intervals.c: Make symbols static if they're not exported.
7383 (merge_properties_sticky, merge_interval_right, delete_interval):
7384 Now static.
7385 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7386
77382fcc
PE
7387 * insdel.c: Make symbols static if they're not exported.
7388 However, leave prepare_to_modify_buffer alone. It's never
7389 called from outside this function, but that appears to be a bug.
7390 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7391 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7392 (adjust_after_replace_noundo): Remove; unused.
7393 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7394 (signal_before_change): Remove decls.
77382fcc 7395
9306c32e
PE
7396 * indent.c (val_compute_motion, val_vmotion): Now static.
7397
cd44d2eb
PE
7398 * image.c: Make symbols static if they're not exported.
7399 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7400 if USE_GTK.
7401 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7402 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7403
ad9a7a06
PE
7404 * fringe.c (standard_bitmaps): Now static.
7405 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7406
81626931
PE
7407 * frame.c: Make symbols static if they're not exported.
7408 (x_report_frame_params, make_terminal_frame): Now static.
7409 (get_frame_param): Now static, unless HAVE_NS.
7410 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7411 (x_get_resource_string): Remove; not used.
7412 * frame.h (make_terminal_frame, x_report_frame_params):
7413 (x_get_resource_string); Remove decls.
7414 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7415 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7416
239f9db9
PE
7417 * font.c, fontset.c: Make symbols static if they're not exported.
7418 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7419 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7420 * font.c (font_close_object): Now static.
7421 * font.h (font_close_object): Remove.
7422 * fontset.c (FONTSET_OBJLIST): Remove.
7423 (free_realized_fontset) #if-0 the body, which does nothing.
7424 (face_suitable_for_char_p): #if-0, as it's never called.
7425 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7426 * xfaces.c (face_at_string_position):
7427 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7428 since 0 is always ASCII.
7429
dfcf3579
PE
7430 * fns.c (weak_hash_tables): Now static.
7431
5045092b
PE
7432 * fileio.c: Make symbols static if they're not exported.
7433 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7434 (Vwrite_region_annotation_buffers): Now static.
7435
57a96f5c
PE
7436 * eval.c: Make symbols static if they're not exported.
7437 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7438 * lisp.h (backtrace_list): Remove decl.
7439
35f08c38
PE
7440 * emacs.c: Make symbols static if they're not exported.
7441 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7442 (fatal_error_code, fatal_error_signal_hook, standard_args):
7443 Now static.
7444 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7445 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7446 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7447 * lisp.h (fatal_error_signal_hook): Remove decl.
7448 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7449
f44bd759
PE
7450 * editfns.c: Move a (normally-unused) function to its only use.
7451 * editfns.c, lisp.h (get_operating_system_release): Remove.
7452 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7453 worth the hassle of breaking this out.
7454
b532497d
PE
7455 * xterm.c: Make symbols static if they're not exported.
7456 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7457 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7458 (x_destroy_window, x_delete_display):
7459 Now static.
7460 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7461 (x_mouse_leave): Remove; unused.
7462 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7463 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7464 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7465 Remove decls.
7466 (x_mouse_leave): Declare only if WINDOWSNT.
7467 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7468 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7469 USE_X_TOOLKIT.
7470
1675728f
PE
7471 * ftxfont.c: Make symbols static if they're not exported.
7472 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7473 HAVE_FREETYPE.
7474 * font.h (ftxfont_driver): Likewise.
7475
e4cebfca
PE
7476 * xfns.c: Make symbols static if they're not exported.
7477 (x_last_font_name, x_display_info_for_name):
7478 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7479 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7480 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7481 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7482 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7483 (last_show_tip_args): Now static.
7484 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7485 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7486 (x_screen_planes): Remove; unused.
7487 * dispextern.h (x_screen_planes): Remove decl.
7488
5bf46f05
PE
7489 * dispnew.c: Make symbols static if they're not exported.
7490 * dispextern.h (redraw_garbaged_frames, scrolling):
7491 (increment_row_positions): Remove.
7492 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7493 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7494 Now static.
7495 (redraw_garbaged_frames): Remove; unused.
7496
435f4c28
PE
7497 * xfaces.c: Make symbols static if they're not exported.
7498 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7499 Remove decls.
7500 * xterm.h (defined_color): Remove decls.
7501 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7502 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7503 (menu_face_changed_default, defined_color, free_realized_face):
7504 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7505 (ascii_face_of_lisp_face): Remove; unused.
7506
8524aef3
PE
7507 * xdisp.c: Make symbols static if they're not exported.
7508 * dispextern.h (scratch_glyph_row, window_box_edges):
7509 (glyph_to_pixel_coords, set_cursor_from_row):
7510 (get_next_display_element, set_iterator_to_next):
7511 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7512 (show_mouse_face): Remove decls
7513 * frame.h (message_buf_print): Likewise.
7514 * lisp.h (pop_message, set_message, check_point_in_composition):
7515 Likewise.
7516 * xterm.h (set_vertical_scroll_bar): Likewise.
7517 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7518 (message_buf_print, scratch_glyph_row, displayed_buffer):
7519 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7520 (get_next_display_element, show_mouse_face, window_box_edges):
7521 (frame_to_window_pixel_xy, check_point_in_composition):
7522 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7523 (glyph_to_pixel_coords): Remove; unused.
7524
16390cd2
PE
7525 * dired.c (file_name_completion): Now static.
7526
7527 * dbusbind.c (xd_in_read_queued_messages): Now static.
7528
a25f4dfa
PE
7529 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7530 * data.c (circular_list_error): Remove.
7531
14a9c8df
PE
7532 * commands.h (last_point_position, last_point_position_buffer):
7533 (last_point_position_window): Remove decls.
7534 * keyboard.c: Make these variables static.
7535
04f2d78b
CB
7536 * coding.h (coding, code_convert_region, encode_coding_gap):
7537 Remove decls.
74ab6df5
PE
7538 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7539 (iso_code_class, detect_coding, code_convert_region): Now static.
7540 (encode_coding_gap): Remove; unused.
7541
38dfbee1
PE
7542 * chartab.c (chartab_chars, chartab_bits): Now static.
7543
a2cb4e63
PE
7544 * charset.h (charset_iso_8859_1): Remove decl.
7545 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7546 Now static.
7547
127198fd
PE
7548 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7549 * ccl.c (Vccl_program_table): Now static.
7550 (check_ccl_update): Remove; unused.
7551
d85b608f
PE
7552 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7553 * category.h: ... from here.
7554 * category.c (check_category_table, set_category_set): Now static.
7555
31cd66f3
PE
7556 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7557 * lisp.h: Remove these decls.
7558
c358e587
PE
7559 * buffer.c (buffer_count): Remove unused var.
7560
e78aecca
PE
7561 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7562 so that it's not optimized away.
7563 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7564 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7565 exported only to the debugger.
7566
e192d7d3 7567 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7568 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7569
92470028
PE
7570 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7571 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7572 was inaccessible from Lisp.
7573 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7574 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7575
244ed907
PE
7576 alloc.c: Import and export fewer symbols, and remove unused items.
7577 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7578 is defined.
7579 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7580 it's not optimized away by whole-program optimization.
7581 (message_enable_multibyte, free_misc): Remove.
7582 (catchlist, handlerlist, mark_backtrace):
7583 Declare only if BYTE_MARK_STACK.
7584 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7585 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7586 (message_enable_multibyte): Remove decl.
7587 (free_misc, interval_free_list, float_block, float_block_index):
7588 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7589 (cons_free_list, last_marked_index):
7590 Now static.
7591 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7592 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7593 (mark_backtrace): Define only if BYTE_MARK_STACK.
7594 * xdisp.c (message_enable_multibyte): Now static.
7595
61c2b50e 7596 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7597 This makes it easier for human readers (and static analyzers)
7598 to see whether these variables are used from other modules.
7599 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7600 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7601 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7602 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7603 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7604 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7605 * xmenu.c, xselect.c:
7606 Declare Q* vars static if they are not used in other modules.
7607 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7608 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7609 Remove decls of unexported vars.
7610 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7611
95c82688
PE
7612 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7613
16a97296
PE
7614 Make Emacs functions such as Fatom 'static' by default.
7615 This makes it easier for human readers (and static analyzers)
7616 to see whether these functions can be called from other modules.
7617 DEFUN now defines a static function. To make the function external
7618 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7619 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7620 (Finit_image_library):
16a97296
PE
7621 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7622 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7623 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7624 Remove decls, since these functions are now static.
7625 (Funintern, Fget_internal_run_time): New decls, since these functions
7626 were already external.
95c82688 7627
16a97296
PE
7628 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7629 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7630 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7631 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7632 * keyboard.c, keymap.c, lread.c:
7633 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7634 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7635 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7636 Mark functions with DEFUE instead of DEFUN,
7637 if they are used in other modules.
7638 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7639 decls for now-static functions.
7640 * buffer.h (Fdelete_overlay): Remove decl.
7641 * callproc.c (Fgetenv_internal): Mark as internal.
7642 * composite.c (Fremove_list_of_text_properties): Remove decl.
7643 (Fcomposition_get_gstring): New forward static decl.
7644 * composite.h (Fcomposite_get_gstring): Remove decl.
7645 * dired.c (Ffile_attributes): New forward static decl.
7646 * doc.c (Fdocumntation_property): New forward static decl.
7647 * eval.c (Ffetch_bytecode): New forward static decl.
7648 (Funintern): Remove extern decl; now in .h file where it belongs.
7649 * fileio.c (Fmake_symbolic_link): New forward static decl.
7650 * image.c (Finit_image_library): New forward static decl.
7651 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7652 * intervals.h (Fprevious_property_change):
7653 (Fremove_list_of_text_properties): Remove decls.
7654 * keyboard.c (Fthis_command_keys): Remove decl.
7655 (Fcommand_execute): New forward static decl.
7656 * keymap.c (Flookup_key): New forward static decl.
7657 (Fcopy_keymap): Now static.
7658 * keymap.h (Flookup_key): Remove decl.
7659 * process.c (Fget_process): New forward static decl.
7660 (Fprocess_datagram_address): Mark as internal.
7661 * syntax.c (Fsyntax_table_p): New forward static decl.
7662 (skip_chars): Remove duplicate decl.
7663 * textprop.c (Fprevious_property_change): New forward static decl.
7664 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7665 Now internal.
7666 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7667 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7668
785bbd42
PE
7669 * editfns.c (Fformat): Remove unreachable code.
7670
8b913b57
AS
76712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7672
7673 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7674 change. (Bug#8496)
7675
a6744a35
EZ
76762011-04-13 Eli Zaretskii <eliz@gnu.org>
7677
7678 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7679 when at ZV. (Bug#8487)
7680
e7974947
AS
76812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7682
baad03f0
AS
7683 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7684 (Bug#8437)
7685 * keyboard.c (parse_tool_bar_item): Likewise.
7686 * sound.c (sound_cleanup, alsa_close): Likewise.
7687 * termcap.c (tgetent): Likewise.
7688 * xfns.c (x_default_font_parameter): Likewise.
7689 * xsettings.c (read_and_apply_settings): Likewise.
7690
e7974947
AS
7691 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7692 (overrun_check_free): Protoize.
7693
28272684
PE
76942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7695
7696 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7697 since callers should never pass a negative size.
7698 Change the signature to match that of plain 'read' and 'write'; see
7699 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7700 * lisp.h: Update prototypes of emacs_write and emacs_read.
7701
11997c76
EZ
77022011-04-11 Eli Zaretskii <eliz@gnu.org>
7703
7704 * xdisp.c (redisplay_window): Don't try to determine the character
7705 position of the scroll margin if the window start point w->startp
e896f03c 7706 is outside the buffer's accessible region. (Bug#8468)
11997c76 7707
8a2cbd72
EZ
77082011-04-10 Eli Zaretskii <eliz@gnu.org>
7709
7710 Fix write-region and its subroutines for buffers > 2GB.
7711 * fileio.c (a_write, e_write): Modify declaration of arguments and
7712 local variables to support buffers larger than 2GB.
7713 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7714
7715 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7716 argument, local variables, and return value.
7717
7718 * lisp.h: Update prototypes of emacs_write and emacs_read.
7719
7720 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7721
4073e537 77222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7723
1ebfdcb6
PE
7724 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7725
b2ded58d
PE
7726 Fix more problems found by GCC 4.6.0's static checks.
7727
7d66342c
PE
7728 * xdisp.c (vmessage): Use a better test for character truncation.
7729
bbf47d44
PE
7730 * charset.c (load_charset_map): <, not <=, for optimization,
7731 and to avoid potential problems with integer overflow.
9248994d 7732 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7733 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7734 * editfns.c (Fformat): Likewise.
1e69125e 7735 * syntax.c (skip_chars): Likewise.
3befa583 7736
e3019616
PE
7737 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7738 This also lets GCC 4.6.0 generate slightly better loop code.
7739
becfa255
PE
7740 * callint.c (Fcall_interactively): <, not <=, for optimization.
7741 (Fcall_interactively): Count the number of arguments produced,
7742 not the number of arguments given. This is simpler and lets GCC
7743 4.6.0 generate slightly better code.
7744
dae0cd48
PE
7745 * ftfont.c: Distingish more carefully between FcChar8 and char.
7746 The previous code passed unsigned char * to a functions like
7747 strlen and xstrcasecmp that expect char *, which does not
7748 conform to the C standard.
7749 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7750 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7751 char * when the C standard requires it.
7752
76032d70
PE
7753 * keyboard.c (read_char): Remove unused var.
7754
eb3f1cc8
PE
7755 * eval.c: Port to Windows vsnprintf (Bug#8435).
7756 Include <limits.h>.
7757 (SIZE_MAX): Define if the headers do not.
7758 (verror): Do not give up if vsnprintf returns a negative count.
7759 Instead, grow the buffer. This ports to Windows vsnprintf, which
7760 does not conform to C99. Problem reported by Eli Zaretskii.
7761 Also, simplify the allocation scheme, by avoiding the need for
7762 calling realloc, and removing the ALLOCATED variable.
7763
70476b54
PE
7764 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7765
12020a9e
PE
7766 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7767 But keep the doprint source code for now, as we might revamp it
7768 and use it again (Bug#8435).
ea6c7ae6
PE
7769 * lisp.h (doprnt): Remove.
7770 * Makefile.in (base_obj): Remove doprnt.o.
7771 * deps.mk (doprnt.o): Remove.
7772
5fdb398c
PE
7773 error: Print 32- and 64-bit integers portably (Bug#8435).
7774 Without this change, on typical 64-bit hosts error ("...%d...", N)
7775 was used to print both 32- and 64-bit integers N, which relied on
7776 undefined behavior.
61bdb816 7777 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7778 * lisp.h (error, verror): Mark as printf-like functions.
7779 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7780 Report overflow in size calculations when allocating printf buffer.
7781 Do not truncate output string at its first null byte.
7782 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7783 Truncate the output at a character boundary, since vsnprintf does not
7784 do that.
7785 * charset.c (check_iso_charset_parameter): Convert internal
7786 character to string before calling 'error', since %c now has the
7787 printf meaning.
7788 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7789 overflow when computing char to be passed to 'error'. Do not
7790 pass Lisp_Object to 'error'; pass the integer instead.
7791 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7792 formatted with plain %d.
7793
b189fa66
PE
7794 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7795
bff87ef0
PE
7796 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7797
7e2cac20
PE
7798 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7799
ce4d90b5
PE
7800 * xterm.c (x_catch_errors): Remove duplicate declaration.
7801
266c9547
PE
7802 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7803
79c49ad2
PE
7804 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7805
368f4090
JM
78062011-04-10 Jim Meyering <meyering@redhat.com>
7807
7808 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7809 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7810 return ssize_t not "int", and use size_t as the buffer length.
7811 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7812 * gnutls.h: Update declarations.
7813 * process.c (read_process_output): Use ssize_t, to match.
7814 (send_process): Likewise.
7815
a32d4040
CY
78162011-04-09 Chong Yidong <cyd@stupidchicken.com>
7817
7818 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7819
8546720e 78202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7821
04f2d78b
CB
7822 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7823 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7824
8546720e
GM
7825 * xterm.c (handle_one_xevent):
7826 * xmenu.c (create_and_show_popup_menu):
7827 * xselect.c (x_decline_selection_request)
7828 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7829
0a2f5c1a 78302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7831
7832 Fix some uses of `int' instead of EMACS_INT.
7833 * search.c (string_match_1, fast_string_match)
7834 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7835 (scan_buffer, find_next_newline_no_quit)
7836 (find_before_next_newline, search_command, Freplace_match)
7837 (Fmatch_data): Make some `int' variables be EMACS_INT.
7838
7839 * xdisp.c (display_count_lines): 3rd argument and return value now
7840 EMACS_INT. All callers changed.
7841 (pint2hrstr): Last argument is now EMACS_INT.
7842
7843 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7844 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7845 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7846 (decode_coding_utf_16, decode_coding_emacs_mule)
7847 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7848 (decode_coding_ccl, decode_coding_charset)
7849 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7850 (decode_coding_iso_2022, decode_coding_emacs_mule)
7851 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7852 <char_offset, last_offset>: Declare EMACS_INT.
7853 (encode_coding_utf_8, encode_coding_utf_16)
7854 (encode_coding_emacs_mule, encode_invocation_designation)
7855 (encode_designation_at_bol, encode_coding_iso_2022)
7856 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7857 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7858 Declare EMACS_INT.
7859 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7860 (encode_invocation_designation): Last argument P_NCHARS is now
7861 EMACS_INT.
7862 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7863 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7864
7865 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7866 All users changed.
7867
7868 * ccl.c (Fccl_execute_on_string): Declare some variables
7869 EMACS_INT.
7870
8546720e 78712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7872
7873 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7874
4e19a977
CS
78752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7876
7877 * process.c (Fformat_network_address): Doc fix.
7878
87302331
R
78792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7880
ee7683eb 7881 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7882
cbb59342
CY
78832011-04-08 Chong Yidong <cyd@stupidchicken.com>
7884
7885 * keyboard.c (read_char): Call Lisp function help-form-show,
7886 instead of using internal_with_output_to_temp_buffer.
7887 (Qhelp_form_show): New var.
e0d38eeb 7888 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7889
7890 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7891
7892 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7893
e67a13ab
CY
78942011-04-06 Chong Yidong <cyd@stupidchicken.com>
7895
04f2d78b
CB
7896 * process.c (Flist_processes): Remove to Lisp.
7897 (list_processes_1): Delete.
e67a13ab 7898
973f782d
EZ
78992011-04-06 Eli Zaretskii <eliz@gnu.org>
7900
7c106b1e
EZ
7901 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7902
973f782d
EZ
7903 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7904
41cf7d1a 79052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7906
ca23cc88
PE
7907 Fix more problems found by GCC 4.6.0's static checks.
7908
f390e2d5
PE
7909 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7910
42eea0d0
PE
7911 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7912
b69769da 7913 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7914
f9541e84
PE
7915 * xdisp.c (vmessage): Mark as a printf-like function.
7916
13841b55
PE
7917 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7918
c136c10f
PE
7919 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7920
5e2d4a30
PE
7921 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7922 printf-like functions.
7923 (tiff_load): Add casts to remove these marks before passing them
7924 to system-supplied API.
7925
583f48b9
PE
7926 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7927
b25d760e
PE
7928 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7929 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7930 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7931 directly, rather than having caller test rule sign. This avoids
7932 some unnecessary tests.
7933 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7934 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7935 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7936
bc7b6697 7937 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7938 (xfont_open): Avoid unnecessary tests.
bc7b6697 7939
27ccc379
PE
7940 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7941
dcd5c89a
PE
7942 * composite.h, composite.c (composition_gstring_put_cache):
7943 Use EMACS_INT, not int, for length.
7944
b13a45c6
PE
7945 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7946 breaking out part of COMPOSITION_DECODE_RULE.
7947 (COMPOSITION_DECODE_RULE): Use it.
7948 * composite.c (get_composition_id): Remove unused local vars,
7949 by using the new macro.
7950
1e792e4d
PE
7951 * textprop.c (set_text_properties_1): Change while to do-while,
7952 since the condition is always true at first.
7953
dc6c6455 7954 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7955 (interval_deletion_adjustment): Return unsigned value.
7956 All uses changed.
dc6c6455 7957
aba7731a
PE
7958 * process.c (list_processes_1, create_pty, read_process_output):
7959 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7960 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7961 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7962 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7963 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7964
fdfc4bf3
PE
7965 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7966
fca8fe46 7967 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7968 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7969
06a0259a 7970 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7971 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7972 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7973
e7b9e80f
PE
7974 * print.c (print_error_message): Avoid int overflow.
7975
56201685
PE
7976 * font.c (font_list_entities): Redo for clarity,
7977 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7978
78834453 7979 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7980 (font_score): Avoid potential overflow in diff calculation.
78834453 7981
0bc0b309 7982 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7983 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7984
e610eaca
PE
7985 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7986
b895abce
PE
7987 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7988 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7989 can always succeed if overflow has undefined behavior.
7990
1f1d9321 7991 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7992 (wordify): Omit three unnecessary tests.
1f1d9321 7993
c59478bc
PE
7994 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7995 All callers changed. This avoids the need for an unused var.
7996
79b73827
PE
7997 * casefiddle.c (casify_region): Remove var that is set but not used.
7998
a4db5dfe
PE
7999 * dired.c (file_name_completion): Remove var that is set but not used.
8000
43aae36e
PE
8001 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8002
2a47c44d 8003 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8004 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8005
a37c69bf
PE
8006 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8007 Check for integer overflow on size calculations.
8008
328ab8e7
PE
8009 * buffer.c (Fprevious_overlay_change): Remove var that is set
8010 but not used.
8011
e5a2a5cb
PE
8012 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8013 Remove vars that are set but not used.
8d84a6eb 8014 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8015 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8016
a60e5f68
PE
8017 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8018
f661cb61 8019 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8020 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8021
f0397f5a
PE
8022 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8023 that are set but not used.
8024
8664db06 8025 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8026 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8027
6abdaa4a
PE
8028 * xselect.c (x_get_local_selection, x_handle_property_notify):
8029 Remove vars that are set but not used.
8030
0ce7538d 8031 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8032 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8033
9ae848fc
PE
8034 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8035 Remove var that is set but not used.
0b918413
PE
8036 (scroll_bar_windows_size): Now size_t, not int.
8037 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8038 Check for overflow.
9ae848fc 8039
a5a62657
PE
8040 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8041 (map_tty_color) [!defined MSDOS]: Likewise.
8042
5c5cdd39
PE
8043 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8044
66ebf983
PE
8045 * coding.c: Remove vars that are set but not used.
8046 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8047 All callers changed.
8048 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8049 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8050 (decode_coding_charset): Remove vars that are set but not used.
8051
1be4d761
PE
8052 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8053 that is set but not used.
8054
47553fa8
PE
8055 * print.c (print_object): Remove var that is set but not used.
8056
1f7196bf 8057 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8058 The gnulib version avoids calling malloc in the usual case,
8059 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8060 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8061 * filelock.c (current_lock_owner): Likewise.
8062 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8063 * sysdep.c: Include allocator.h, careadlinkat.h.
8064 (emacs_no_realloc_allocator): New static constant.
8065 (emacs_readlink): New function.
fdb61804
PE
8066 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8067 ../lib/careadlinkat.h.
d1fdcab7 8068
f84c17c7
SM
80692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8070
8071 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8072 first non-nil return value).
8073
ef3862ad
JD
80742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8075
8076 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8077 if not defined (Bug#8403).
8078
376a7006
JB
80792011-04-02 Juanma Barranquero <lekktu@gmail.com>
8080
8081 * xdisp.c (display_count_lines): Remove parameter `start',
8082 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8083 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8084 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8085 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8086 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8087 and thereabouts. All callers changed.
8088 (get_per_char_metric): Remove parameter `f', unused since
8089 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8090
6ca3801d
JM
80912011-04-02 Jim Meyering <meyering@redhat.com>
8092
8093 do not dereference NULL upon failed strdup
8094 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8095 (ns_get_family): Likewise.
8096
d8e2b5ba
JB
80972011-04-02 Juanma Barranquero <lekktu@gmail.com>
8098
8099 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8100
8c74fcbd
JD
81012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8102
8103 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8104 later (Bug#8403).
8105
7200d79c
SM
81062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8107
03408648 8108 Add lexical binding.
7200d79c 8109
03408648
SM
8110 * window.c (Ftemp_output_buffer_show): New fun.
8111 (Fsave_window_excursion):
8112 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8113
8114 * lread.c (lisp_file_lexically_bound_p): New function.
8115 (Fload): Bind Qlexical_binding.
8116 (readevalloop): Remove `evalfun' arg.
8117 Bind Qinternal_interpreter_environment.
8118 (Feval_buffer): Bind Qlexical_binding.
8119 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8120 Mark as dynamic.
8121 (syms_of_lread): Declare `lexical-binding'.
8122
8123 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8124
8125 * keyboard.c (eval_dyn): New fun.
8126 (menu_item_eval_property): Use it.
ca105506
SM
8127
8128 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8129
03408648
SM
8130 * fns.c (concat, mapcar1): Accept byte-code-functions.
8131
8132 * eval.c (Fsetq): Handle lexical vars.
8133 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8134 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8135 (FletX, Flet): Obey lexical binding.
8136 (Fcommandp): Handle closures.
8137 (Feval): New `lexical' arg.
8138 (eval_sub): New function extracted from Feval. Use it almost
8139 everywhere where Feval was used. Look up vars in lexical env.
8140 Handle closures.
8141 (Ffunctionp): Move from subr.el.
8142 (Ffuncall): Handle closures.
8143 (apply_lambda): Remove `eval_flags'.
8144 (funcall_lambda): Handle closures and new byte-code-functions.
8145 (Fspecial_variable_p): New function.
8146 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8147 but without exporting it to Lisp.
23aba0ea 8148
23aba0ea 8149 * doc.c (Fdocumentation, store_function_docstring):
03408648 8150 * data.c (Finteractive_form): Handle closures.
23aba0ea 8151
03408648
SM
8152 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8153 interactive spec.
ba83908c 8154
04f2d78b
CB
8155 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8156 New byte-codes.
03408648
SM
8157 (exec_byte_code): New function extracted from Fbyte_code to handle new
8158 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8159
03408648 8160 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8161
03408648 8162 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8163
e2abce01
JB
81642011-03-31 Juanma Barranquero <lekktu@gmail.com>
8165
8166 * xdisp.c (redisplay_internal): Fix prototype.
8167
63696a73 81682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8169
63696a73 8170 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8171 (try_scrolling): Use it when setting scroll_limit.
8172 Limit scrolling to 100 screen lines.
63696a73
EZ
8173 (redisplay_window): Even when falling back on "recentering",
8174 position point in the window according to scroll-conservatively,
8175 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8176
8177 (try_scrolling): When point is above the window, allow searching
8178 as far as scroll_max, or one screenful, to compute vertical
8179 distance from PT to the scroll margin position. This prevents
8180 try_scrolling from unnecessarily failing when
8181 scroll-conservatively is set to a value slightly larger than the
8182 window height. Clean up the case of PT below the margin at bottom
8183 of window: scroll_max can no longer be INT_MAX. When aggressive
8184 scrolling is in use, don't let point enter the opposite scroll
8185 margin as result of the scroll.
8186 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8187 threshold of 100 lines for never-recentering scrolling.
8188
e4cc2dfc
JB
81892011-03-31 Juanma Barranquero <lekktu@gmail.com>
8190
8191 * dispextern.h (move_it_by_lines):
8192 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8193 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8194 (message_log_check_duplicate): Remove parameters `prev_bol' and
8195 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8196 (redisplay_internal): Remove parameter `preserve_echo_area',
8197 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8198
8199 * indent.c (Fvertical_motion):
8200 * window.c (window_scroll_pixel_based, Frecenter):
8201 Don't pass `need_y_p' to `move_it_by_lines'.
8202
1c470562
SM
82032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8204
44f230aa
SM
8205 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8206 steal a few bits to be more compact.
8207 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8208 Remove unneeded casts.
8209
1c470562
SM
8210 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8211
888adce9
ZK
82122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8213
8214 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8215 binding" message (bug#7967).
8216
f838ed7b
PE
82172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8218
77861b95
PE
8219 Fix more problems found by GCC 4.6.0's static checks.
8220
de6dbc14
PE
8221 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8222 Remove unused local var.
8223
f838ed7b
PE
8224 * editfns.c (Fmessage_box): Remove unused local var.
8225
792c7b2b
PE
8226 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8227 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8228 Omit unused local vars.
c499e557 8229 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8230 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8231 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8232 Omit unused local var.
8233
ba0165e1
PE
8234 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8235 Don't assume string length fits in int.
32ad8845 8236 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8237 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8238
3c59b4c9
PE
8239 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8240 instead of alloca (Bug#8344).
8241
a3eed478 8242 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8243 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8244
eb4d412d
PE
8245 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8246
1658b401
PE
8247 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8248 concerns.
8249
8250 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8251
8252 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8253
9a2c6e05
PE
8254 * keyboard.c (syms_of_keyboard): Use the same style as later
8255 in this function when indexing through an array. This also
8256 works around GCC bug 48267.
8257
03d0a109
PE
8258 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8259
44f730c8
PE
8260 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8261
fe75f926
PE
8262 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8263 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8264
ffa8c828
PE
8265 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8266 This avoids undefined behavior on integer overflow, and is a bit
8267 more convenient anyway since it is compared to a size_t variable.
8268
c5101a77
PE
8269 Variadic C functions now count arguments with size_t, not int.
8270 This avoids an unnecessary limitation on 64-bit machines, which
8271 caused (substring ...) to crash on large vectors (Bug#8344).
8272 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8273 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8274 All variadic functions and their callers changed accordingly.
c5101a77
PE
8275 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8276 * data.c (arith_driver, float_arith_driver): Likewise.
8277 * editfns.c (general_insert_function): Likewise.
8278 * eval.c (struct backtrace.nargs, interactive_p)
8279 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8280 (funcall_lambda, mark_backtrace): Likewise.
8281 * fns.c (concat): Likewise.
8282 * frame.c (x_set_frame_parameters): Likewise.
8283 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8284 0 if not found, not -1. All callers changed.
8285
dd3f25f7
PE
8286 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8287 (stack_copy_size): Now size_t, not int.
8288 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8289
461c2ab9
JB
82902011-03-28 Juanma Barranquero <lekktu@gmail.com>
8291
8292 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8293 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8294 All callers changed.
8295
8296 * lisp.h (multibyte_char_to_unibyte):
8297 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8298 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8299 * character.h (CHAR_TO_BYTE8):
8300 * cmds.c (internal_self_insert):
8301 * editfns.c (general_insert_function):
8302 * keymap.c (push_key_description):
8303 * search.c (Freplace_match):
8304 * xdisp.c (message_dolog, set_message_1): All callers changed.
8305
f6d62986
SM
83062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8307
8308 * keyboard.c (safe_run_hook_funcall): New function.
8309 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8310 don't set the hook to nil, but remove the offending function instead.
8311 (Qcommand_hook_internal): Remove, unused.
8312 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8313 Vcommand_hook_internal.
8314
8315 * eval.c (enum run_hooks_condition): Remove.
8316 (funcall_nil, funcall_not): New functions.
8317 (run_hook_with_args): Call each function through a `funcall' argument.
8318 Remove `cond' argument, now redundant.
8319 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8320 (Frun_hook_with_args_until_failure): Adjust accordingly.
8321 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8322
1db5b1ad
JB
83232011-03-28 Juanma Barranquero <lekktu@gmail.com>
8324
8325 * dispextern.h (string_buffer_position): Remove declaration.
8326
8327 * print.c (strout): Remove parameter `multibyte', unused since
8328 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8329
8330 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8331 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8332 All callers changed.
8333
8334 * w32.c (_wsa_errlist): Use braces for struct initializers.
8335
8336 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8337 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8338 All callers changed.
8339 (string_buffer_position): Likewise. Also, make static (it's never
8340 used outside xdisp.c).
8341 (cursor_row_p): Remove parameter `w', unused since
8342 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8343 (decode_mode_spec): Remove parameter `precision', introduced during
8344 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8345 All callers changed.
8346
5ffb62aa
JD
83472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8348
8349 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8350
461c2ab9 83512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8352
8353 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8354 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8355 (ns_update_auto_hide_menu_bar): New functions.
8356 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8357 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8358 ns_constrain_all_frames.
8359 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8360 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8361
5c380ffb
JD
83622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8363
8364 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8365
9af30bdf
GM
83662011-03-27 Glenn Morris <rgm@gnu.org>
8367
8368 * syssignal.h: Replace RETSIGTYPE with void.
8369 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8370 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8371 Replace SIGTYPE with void everywhere.
8372 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8373 * s/template.h (SIGTYPE): Remove commented out definition.
8374
e2abce01
JB
83752011-03-26 Eli Zaretskii <eliz@gnu.org>
8376
8377 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8378 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8379
f868cd8a
JB
83802011-03-26 Juanma Barranquero <lekktu@gmail.com>
8381
59eb0929
JB
8382 * w32.c (read_unc_volume): Use parameter `henum', instead of
8383 global variable `wget_enum_handle'.
8384
8385 * keymap.c (describe_vector): Remove parameters `indices' and
8386 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8387 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8388
f868cd8a
JB
8389 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8390
8391 * keyboard.c (timer_check): Remove parameter `do_it_now',
8392 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8393 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8394 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8395
8396 * keyboard.c (read_char):
8397 * w32menu.c (w32_menu_display_help):
8398 * xmenu.c (show_help_event, menu_help_callback):
8399 Adjust calls to `show_help_echo'.
8400
8401 * gtkutil.c (xg_maybe_add_timer):
8402 * keyboard.c (readable_events):
8403 * process.c (wait_reading_process_output):
8404 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8405
8406 * insdel.c (adjust_markers_gap_motion):
8407 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8408 (gap_left, gap_right): Don't call it.
8409
2ecf6fdb
CY
84102011-03-25 Chong Yidong <cyd@stupidchicken.com>
8411
8412 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8413 incurred during fontification.
8414
6b1f9ba4
JB
84152011-03-25 Juanma Barranquero <lekktu@gmail.com>
8416
8417 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8418 (DEFVAR_PER_BUFFER): Don't pass it.
8419
8420 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8421 (scrolling_window): Don't pass it.
8422
0f4a96b5
JB
84232011-03-25 Juanma Barranquero <lekktu@gmail.com>
8424
8425 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8426
8427 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8428 and `suffix'.
8429 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8430 of variables specific to SELinux and computation of `encoded_absname'.
8431
8432 * image.c (XPutPixel): Remove unused variable `height'.
8433
8434 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8435
8436 * unexw32.c (get_section_info): Remove unused variable `section'.
8437
8438 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8439 (system_process_attributes): Remove unused variable `sess'.
8440 (sys_read): Remove unused variable `err'.
8441
8442 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8443 (w32_wnd_proc): Remove unused variable `isdead'.
8444 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8445 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8446 (x_create_tip_frame): Remove unused variable `tem'.
8447
8448 * w32inevt.c (w32_console_read_socket):
8449 Remove unused variable `no_events'.
8450
8451 * w32term.c (x_draw_composite_glyph_string_foreground):
8452 Remove unused variable `width'.
8453
1149507c
JB
84542011-03-24 Juanma Barranquero <lekktu@gmail.com>
8455
8456 * w32term.c (x_set_glyph_string_clipping):
8457 Don't pass uninitialized region to CombineRgn.
8458
9c88f339
JB
84592011-03-23 Juanma Barranquero <lekktu@gmail.com>
8460
8461 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8462 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8463 (Fx_close_connection): Remove unused variable `i'.
8464
8465 * w32font.c (w32font_draw): Return number of glyphs.
8466 (w32font_open_internal): Remove unused variable `i'.
8467 (w32font_driver): Add missing initializer.
8468
8469 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8470 (fill_in_menu): Remove unused variable `items_added'.
8471
8472 * w32term.c (last_mouse_press_frame): Remove static global variable.
8473 (w32_clip_to_row): Remove unused variable `f'.
8474 (x_delete_terminal): Remove unused variable `i'.
8475
8476 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8477 (NOTHING): Remove unused static global variable.
8478 (uniscribe_check_otf): Remove unused variable `table'.
8479 (uniscribe_font_driver): Add missing initializers.
8480
dee091a3
JD
84812011-03-23 Julien Danjou <julien@danjou.info>
8482
8483 * term.c (Fsuspend_tty, Fresume_tty):
8484 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8485 * window.c (temp_output_buffer_show):
8486 * insdel.c (signal_before_change):
8487 * frame.c (Fhandle_switch_frame):
8488 * fileio.c (Fdo_auto_save):
8489 * emacs.c (Fkill_emacs):
8490 * editfns.c (save_excursion_restore):
8491 * cmds.c (internal_self_insert):
8492 * callint.c (Fcall_interactively):
8493 * buffer.c (Fkill_all_local_variables):
8494 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8495 Use Frun_hooks.
0f4a96b5 8496 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8497 unconditionally since it does the check itself.
dee091a3 8498
2c520ab5 84992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8500
c9c49752
PE
8501 Fix more problems found by GCC 4.5.2's static checks.
8502
8abc3f12
PE
8503 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8504 the first time through the loop, since we know p0 < p1 then.
8505 This also avoids a gcc -Wstrict-overflow warning.
8506
a2d26660
PE
8507 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8508 leading to a memory leak, possible in functions like
8509 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8510 of objects (Bug#8318).
a2d26660 8511
916c72e9
PE
8512 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8513 that could (at least in theory) be that large.
8514
19ab8a18
PE
8515 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8516 This is less likely to overflow, and avoids undefined behavior if
8517 overflow does occur. All callers changed. Use strtoul to scan
8518 for the unsigned long integer.
b7cbbd6f
PE
8519 (pint2hrstr): Simplify and tune code slightly.
8520 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8521
f0641eff
PE
8522 * scroll.c (do_scrolling): Work around GCC bug 48228.
8523 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8524
7f650bb9
PE
8525 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8526 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8527 (validate_x_resource_name): Simplify count usage.
8528 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8529
37dd57d1
PE
8530 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8531 fail (Bug#8306).
81e56e61 8532
699979fc 8533 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8534
401bf9b4
PE
8535 * process.c (Fmake_network_process): Use socklen_t, not int,
8536 where POSIX says socklen_t is required in portable programs.
8537 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8538 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8539 (Fmake_network_process, server_accept_connection):
8540 (wait_reading_process_output, read_process_output):
8541 Likewise.
8542
b93aacde
PE
8543 * process.c: Rename or move locals to avoid shadowing.
8544 (list_processes_1, Fmake_network_process):
8545 (read_process_output_error_handler, exec_sentinel_error_handler):
8546 Rename or move locals.
4dc343ee 8547 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8548 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8549 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8550 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8551 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8552
af8a867c 8553 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8554 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8555 Include tparam.h instead, since it declares them.
af8a867c
PE
8556 * cm.h (PC): Remove extern decl; tparam.h now does this.
8557 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8558 * terminfo.c: Include tparam.h, to check interfaces.
8559 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8560 (tparam): Adjust signature to match interface in tparam.h;
8561 this removes some undefined behavior. Check that outstring and len
8562 are zero, which they always are with Emacs.
8563 * tparam.h (PC, BC, UP): New extern decls.
8564
0248044d 8565 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8566 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8567
8ff096c1 8568 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8569 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8570 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8571 (ftfont_list): Remove unused local.
49eaafba
PE
8572 (get_adstyle_property, ftfont_pattern_entity):
8573 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8574 Rename locals to avoid shadowing.
8ff096c1 8575
e2be39f6
PE
8576 * xfont.c (xfont_list_family): Mark var as initialized.
8577
c9735e30
PE
8578 * xml.c (make_dom): Now static.
8579
8f5201ae
PE
8580 * composite.c (composition_compute_stop_pos): Rename local to
8581 avoid shadowing.
b246f932
PE
8582 (composition_reseat_it): Remove unused locals.
8583 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8584 (composition_update_it): Mark var as initialized.
11b61122
PE
8585 (find_automatic_composition): Mark vars as initialized,
8586 with a FIXME (Bug#8290).
8f5201ae 8587
760fbc2c
PE
8588 character.h: Rename locals to avoid shadowing.
8589 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8590 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8591 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8592 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8593 to avoid shadowing.
8594
ff08eb85
PE
8595 * textprop.c (property_change_between_p): Remove; unused.
8596
fc7bf025
PE
8597 * intervals.c (interval_start_pos): Now static.
8598
235d7abc
PE
8599 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8600
44f230aa
SM
8601 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8602 Rename locals to avoid shadowing.
3e7d6594 8603
50060332
PE
8604 * sound.c (wav_play, au_play, Fplay_sound_internal):
8605 Fix pointer signedness.
d01f234b 8606 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8607 (wav_play): Initialize a variable to 0, to prevent undefined
8608 behavior (Bug#8278).
50060332 8609
c4fc4e30
PE
8610 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8611
918436ed
PE
8612 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8613
c939f91b
PE
8614 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8615 clobbering (Bug#8298).
b9c7f648
PE
8616 * sysdep.c (sys_subshell): Likewise.
8617 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8618
6bd8c144
PE
8619 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8620 This should get cleaned up, so that child_setup has the
8621 same signature on all platforms.
8622
7710357c 8623 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8624 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8625
c59da222
CY
86262011-03-22 Chong Yidong <cyd@stupidchicken.com>
8627
8628 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8629 not to be necessary, and produces flickering.
8630
66b87493
GM
86312011-03-20 Glenn Morris <rgm@gnu.org>
8632
8633 * config.in: Remove file.
8634
45b6f6d5
JB
86352011-03-20 Juanma Barranquero <lekktu@gmail.com>
8636
8637 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8638 are now in src/globals.h.
8639 (syms_of_minibuf): Remove spurious & from previous change.
8640
cd394be1 86412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8642
8643 * minibuf.c (completing-read-function): New variable.
8644 (completing-read-default): Rename from completing-read.
8645 (completing-read): Call completing-read-function.
8646
b14e3e21
CY
86472011-03-19 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * xfaces.c (Fx_load_color_file):
8650 Read color file from absolute filename (bug#8250).
8651
f2b726e6
JB
86522011-03-19 Juanma Barranquero <lekktu@gmail.com>
8653
8654 * makefile.w32-in: Update dependencies.
8655
09f6ff02
EZ
86562011-03-17 Eli Zaretskii <eliz@gnu.org>
8657
8658 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8659
29a6015a
PE
86602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8661
a3a6c54e
PE
8662 Fix more problems found by GCC 4.5.2's static checks.
8663
b766f867
PE
8664 * process.c (make_serial_process_unwind, send_process_trap):
8665 (sigchld_handler): Now static.
8666
be02381c
PE
8667 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8668 That way, the code declares only the vars that it needs.
8669 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8670 * s/cygwin.h (PTY_ITERATION): Likewise.
8671 * s/darwin.h (PTY_ITERATION): Likewise.
8672 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8673
57048744
PE
8674 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8675 * process.c (allocate_pty): Don't declare stb unless it's needed.
8676
7914961c 8677 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8678 (CONSTANTLIM): Remove; unused.
8679 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8680 Define only if needed.
7914961c 8681
b3967b18
PE
8682 * unexelf.c (unexec): Name an expression,
8683 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8684 Use a different way to cause a compilation error if anyone uses
8685 n rather than nn, a way that does not involve shadowing.
73366a00 8686 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8687
29a6015a
PE
8688 * deps.mk (unexalpha.o): Remove; unused.
8689
43cfc33e 8690 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8691 * unexec.h: New file.
ce701a33
PE
8692 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8693 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8694 Depend on unexec.h.
8695 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8696 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8697 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8698 Change as necessary to match prototype in unexec.h.
ce701a33 8699
01f44d5a
PE
8700 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8701 shadowing.
4f63c6bb 8702 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8703
a6670b0b
PE
8704 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8705 Rename locals to avoid shadowing.
8706
cef2010d 8707 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8708 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8709
d4d7173a
PE
8710 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8711
f08b802a
PE
8712 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8713 warning when compiling print.c.
8714
3ddb0639
PE
8715 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8716 instead of using an uninitialized var.
5ad03b97 8717 (font_sort_entities): Mark var as initialized.
3ddb0639 8718
170a2692
PE
8719 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8720
e663c700
PE
8721 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8722 pointers to constants.
89bc529a 8723 (font_parse_fcname): Remove unused vars.
7b81e2d0 8724 (font_delete_unmatched): Now static.
ea838e10 8725 (font_get_spec): Remove; unused.
13a547c6
PE
8726 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8727 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8728 Rename or move locals to avoid shadowing.
e663c700 8729
2a80c887 8730 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8731 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8732
1384fa33 8733 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8734 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8735
8b2c52e9
PE
8736 * alloc.c (mark_backtrace): Move decl from here ...
8737 * lisp.h: ... to here, so that it can be checked.
8738
475545b5 8739 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8740 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8741 (lisp_indirect_variable): Name an expression,
8742 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8743 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8744
b1349114 8745 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8746 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8747 Use const pointer when appropriate.
b1349114 8748
a2928364
PE
8749 * lisp.h (get_system_name, get_operating_system_release):
8750 Move decls here, to check interfaces.
8751 * process.c (get_operating_system_release): Move decl to lisp.h.
8752 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8753 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8754 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8755 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8756 (Fformat_time_string, Fencode_time, Finsert_char):
8757 (Ftranslate_region_internal, Fformat):
8758 Rename or remove local vars to avoid shadowing.
9710023e 8759 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8760
a415e694
PE
8761 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8762 avoid shadowing.
8763
8ef4622d
PE
8764 * lisp.h (eassert): Check that the argument compiles, even if
8765 ENABLE_CHECKING is not defined.
8766
946f9a5b
PE
8767 * data.c (Findirect_variable): Name an expression, to avoid
8768 gcc -Wbad-function-cast warning.
112396d6 8769 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8770 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8771 (Fmake_variable_buffer_local, Fmake_local_variable):
8772 Mark variables as initialized.
52746918 8773 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8774
e5aab7e7 8775 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8776 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8777 Rename locals to avoid shadowing.
dff45157
PE
8778 (mark_stack): Move local variables into the #ifdef region where
8779 they're used.
7bc26fdb
PE
8780 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8781 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8782 needed otherwise.
8783 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8784 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8785 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8786
e5aab7e7
PE
8787 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8788 avoids undefined behavior in theory.
8789
4da60324
PE
8790 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8791
88043301
PE
8792 Use functions, not macros, for up- and down-casing (Bug#8254).
8793 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8794 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8795 to use the following functions instead of these macros.
8796 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8797 EMACS_INT, since callers assume the returned value fits in int.
8798 (upcase1): Likewise, for UPCASE_TABLE.
8799 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8800 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8801 the race-condition problem in the old DOWNCASE.
88043301 8802
19ed5445
PE
8803 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8804 Rename locals to avoid shadowing.
8805 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8806 (regex_compile, re_search_2, re_match_2_internal):
8807 Remove unused local vars.
952db0d7
PE
8808 (FREE_VAR): Rewrite so as not to use empty "else",
8809 which gcc can warn about.
da053e48 8810 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8811 (RETALLOC_IF): Define only if needed.
8812 (WORDCHAR_P): Likewise. This one is never needed, but is used
8813 only in a comment talking about a compiler bug, so put inside
8814 the #if 0 of that comment.
8815 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8816 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8817 Remove; unused.
19ed5445 8818
1f3561e4 8819 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8820 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8821 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8822
ded6f8f7
PE
8823 * search.c (simple_search): Remove unused var.
8824
dbd37a95
PE
8825 * dired.c (compile_pattern): Move decl from here ...
8826 * lisp.h: ... to here, so that it can be checked.
8827 (struct re_registers): New forward decl.
8828
7e47afad
PE
8829 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8830
85f24f61
PE
8831 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8832 All uses changed.
8833 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8834 Rename locals to avoid shadowing.
5671df8f 8835 (Fvertical_motion): Mark locals as initialized.
85f24f61 8836
181aa2be 8837 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8838 (casify_region): Mark local as initialized.
181aa2be 8839
930d429c
PE
8840 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8841
7082eac6
PE
8842 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8843 New macros, so that the caller can use some names other than
8844 gcpro1, gcpro2, etc.
8845 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8846 of the new macros.
8847 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8848 argument, for consistency with GCPRO2_VAR, etc: it is now the
8849 prefix of the variable, not the variable itself. All uses
8850 changed.
38b2c076
PE
8851 * dired.c (directory_files_internal, file_name_completion):
8852 Rename locals to avoid shadowing.
8853
15206ed9
PE
8854 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8855 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8856 dired.c's scmp function, had undefined behavior.
8857 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8858 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8859 * buffer.h: ... to here, because these macros use current_buffer,
8860 and the new implementation with inline functions needs to have
8861 current_buffer in scope now, rather than later when the macros
8862 are used.
8863 (downcase, upcase1): New static inline functions.
8864 (DOWNCASE, UPCASE1): Reimplement using these functions.
8865 This avoids undefined behavior in expressions like
8866 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8867 from race conditions in accessing the global variables
8868 case_temp1 and case_temp2.
8869 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8870 * lisp.h (case_temp1, case_temp2): Remove their decls.
8871 * character.h (ASCII_CHAR_P): Move from here ...
8872 * lisp.h: ... to here, so that the inline functions mentioned
8873 above can use them.
8874
4a6bea26
PE
8875 * dired.c (directory_files_internal_unwind): Now static.
8876
f14b7e14
PE
8877 * fileio.c (file_name_as_directory, directory_file_name):
8878 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8879 Now static.
2893f146
PE
8880 (file_name_as_directory): Use const pointers when appropriate.
8881 (Fexpand_file_name): Likewise. In particular, newdir might
8882 point at constant storage, so make it a const pointer.
fd4ead52 8883 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8884 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8885 signedness issues.
f839df0c
PE
8886 (Fset_file_times, Finsert_file_contents, auto_save_error):
8887 Rename locals to avoid shadowing.
f14b7e14 8888
5716756e 8889 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8890 (Ftry_completion, Fall_completions): Rename or remove locals
8891 to avoid shadowing.
5716756e 8892
b4c3046a
PE
8893 * marker.c (bytepos_to_charpos): Remove; unused.
8894
b45db522
PE
8895 * lisp.h (verify_bytepos, count_markers): New decls,
8896 so that gcc does not warn that these functions aren't declared.
8897
85876d07
PE
8898 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8899 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8900 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8901 (copy_text): Remove unused local var.
85876d07 8902
03d78a21 8903 * filelock.c (within_one_second): Now static.
b3dd38ab 8904 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8905
5df8f01b
PE
8906 * buffer.c (fix_overlays_before): Mark locals as initialized.
8907 (fix_start_end_in_overlays): Likewise. This function should be
8908 simplified by using pointers-to-pointers, but that's a different
8909 matter.
b1d876f1 8910 (switch_to_buffer_1): Now static.
8f54f30a
PE
8911 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8912 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8913
a70072c9 8914 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8915 Fix pointer signedness issue.
edced198
PE
8916 (sys_subshell): Mark local as volatile if checking for lint,
8917 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8918 (MAXPATHLEN): Define only if needed.
a70072c9 8919
a0977c44
PE
8920 * process.c (serial_open, serial_configure): Move decls from here ...
8921 * systty.h: ... to here, so that they can be checked.
8922
a884fdcc
PE
8923 * fns.c (get_random, seed_random): Move extern decls from here ...
8924 * lisp.h: ... to here, so that they can be checked.
8925
604efe86 8926 * sysdep.c (reset_io): Now static.
b8950c94 8927 (wait_for_termination_signal): Remove; unused.
604efe86 8928
38fc62d9
PE
8929 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8930 (copy_keymap_item, append_key, push_text_char_description):
8931 Now static.
1004a21a 8932 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8933 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8934 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8935 (describe_map_tree):
8936 Rename locals to avoid shadowing.
38fc62d9 8937
2f2650da
PE
8938 * keyboard.c: Declare functions static if they are not used elsewhere.
8939 (echo_char, echo_dash, cmd_error, top_level_2):
8940 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8941 (read_char, kbd_buffer_get_event, make_lispy_position):
8942 (make_lispy_event, make_lispy_movement, apply_modifiers):
8943 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8944 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8945 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8946 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8947 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8948
a053e86c 8949 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8950 (mark_kboards): Move decl here ...
8951 * alloc.c (mark_kboards): ... from here.
a053e86c 8952
4752793e
PE
8953 * lisp.h (force_auto_save_soon): New decl.
8954
74f10ca7 8955 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8956 (DEFINE_DUMMY_FUNCTION): New macro.
8957 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8958 Use it.
c03cd23f
PE
8959 (main): Add casts to avoid warnings
8960 if GCC considers string literals to be constants.
74f10ca7 8961
022e70d4
PE
8962 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8963
59d6fe83
PE
8964 * dbusbind.c: Pointer signedness fixes.
8965 (xd_signature, xd_append_arg, xd_initialize):
8966 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8967 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8968 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8969 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8970
78320123
PE
8971 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8972 if GCC considers string literals to be constants.
49cebcca 8973 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8974
35ac2a97
SM
89752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8976
fb103ca9
SM
8977 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8978 (print_preprocess, print_object): New macro to fix last change.
8979
35ac2a97
SM
8980 * print.c (print_preprocess): Don't forget font objects.
8981
62973b41
JB
89822011-03-16 Juanma Barranquero <lekktu@gmail.com>
8983
8984 * emacs.c (USAGE3): Doc fixes.
8985
0e48bb22
AS
89862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8987
8988 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8989 structure.
8990
7684e57b
JB
89912011-03-14 Juanma Barranquero <lekktu@gmail.com>
8992
8993 * lisp.h (VWindow_system, Qfile_name_history):
8994 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8995 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8996 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8997
8998 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8999 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9000
9001 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9002 * w32console.c (detect_input_pending, read_input_pending)
9003 (encode_terminal_code):
9004 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9005 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9006 (w32_system_caret_y, Qfile_name_history):
9007 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9008 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9009 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9010 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9011 * w32proc.c (Qlocal, report_file_error):
9012 * w32term.c (Vwindow_system, updating_frame):
9013 * w32uniscribe.c (initialized, uniscribe_font_driver):
9014 Remove unneeded extern declarations.
9015
2aa46d6c
CY
90162011-03-14 Chong Yidong <cyd@stupidchicken.com>
9017
c96bbc66 9018 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9019
cffc6f3b
CY
90202011-03-13 Chong Yidong <cyd@stupidchicken.com>
9021
9022 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9023 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9024 These macros can no longer be used for assignment.
9025
44f230aa
SM
9026 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9027 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9028 (record_buffer_markers, fetch_buffer_markers): New functions for
9029 recording and fetching special buffer markers.
9030 (set_buffer_internal_1, set_buffer_temp): Use them.
9031
9032 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9033
9034 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9035
9036 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9037 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9038
9039 * xdisp.c (hscroll_window_tree):
9040 (reconsider_clip_changes): Use PT instead of BUF_PT.
9041
d251f04b
EZ
90422011-03-13 Eli Zaretskii <eliz@gnu.org>
9043
9044 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9045 $(EMACS_ROOT)/lib/intprops.h.
9046
f0c77cd1
PE
90472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9048
3eca4629
PE
9049 Fix more problems found by GCC 4.5.2's static checks.
9050
7c86ee98
PE
9051 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9052 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9053 (xg_free_frame_widgets): Make it clear that a local variable is
9054 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9055 (gdk_window_get_screen): Make it clear that this macro is needed
9056 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9057 (int_gtk_range_get_value): New function, which avoids a diagnostic
9058 from gcc -Wbad-function-cast.
9059 (xg_set_toolkit_scroll_bar_thumb): Use it.
9060 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9061 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9062 (get_utf8_string, xg_get_file_with_chooser):
9063 Rename locals to avoid shadowing.
9064 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9065
41729b81
PE
9066 * xgselect.c (xg_select): Remove unused var.
9067
f0c77cd1
PE
9068 * image.c (four_corners_best): Mark locals as initialized.
9069 (gif_load): Initialize transparent_p to zero (Bug#8238).
9070 Mark another local as initialized.
ec6cf4c6 9071 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9072
ce0ad53d 9073 * image.c (clear_image_cache): Now static.
d5d5a617 9074 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9075 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9076 (x_edge_detection): Remove unnecessary cast that
9077 gcc -Wbad-function-cast diagnoses.
2037898d 9078 (gif_load): Fix pointer signedness.
6ae141d6
PE
9079 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9080 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9081
33383987 90822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9083
d32df629
PE
9084 Improve quality of tests for time stamp overflow.
9085 For example, without this patch (encode-time 0 0 0 1 1
9086 1152921504606846976) returns the obviously-bogus value (-948597
9087 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9088 reports time overflow. See
9089 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9090 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9091 * editfns.c: Include limits.h and intprops.h.
9092 (TIME_T_MIN, TIME_T_MAX): New macros.
9093 (time_overflow): Move earlier, to before first use.
9094 (hi_time, lo_time): New functions, for an accurate test for
9095 out-of-range times.
9096 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9097 (Fget_internal_run_time): Don't assume time_t fits in int.
9098 (make_time): Use list2 instead of Fcons twice.
9099 (Fdecode_time): More accurate test for out-of-range times.
9100 (check_tm_member): New function.
9101 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9102 (lisp_time_argument): Don't rely on undefined left-shift and
9103 right-shift behavior when checking for time stamp overflow.
8be6f318 9104
fe31d94c
PE
9105 * editfns.c (time_overflow): New function, refactoring common code.
9106 (Fformat_time_string, Fdecode_time, Fencode_time):
9107 (Fcurrent_time_string): Use it.
9108
8be6f318
PE
9109 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9110 * dired.c (make_time): Move to ...
9111 * editfns.c (make_time): ... here.
9112 * systime.h: Note the move.
9113
09d9db2c 91142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9115
126bc0dc
YM
9116 * fringe.c (update_window_fringes): Remove unused variables.
9117
c47cbdfd
YM
9118 * unexmacosx.c (copy_data_segment): Also copy __got section.
9119 (Bug#8223)
9120
7ac80be9
EZ
91212011-03-12 Eli Zaretskii <eliz@gnu.org>
9122
c96bbc66 9123 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9124 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9125 Constify `char *' arguments and their references according to
9126 prototypes in tparam.h.
9127
ecb0f94d 9128 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9129
7ac80be9
EZ
9130 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9131 Adapt all references accordingly.
9132
9133 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9134
ef1fd07e
TT
91352011-03-11 Tom Tromey <tromey@redhat.com>
9136
9137 * buffer.c (syms_of_buffer): Remove obsolete comment.
9138
7ef4b50c
EZ
91392011-03-11 Eli Zaretskii <eliz@gnu.org>
9140
9141 * termhooks.h (encode_terminal_code): Declare prototype.
9142
9143 * msdos.c (encode_terminal_code): Don't declare prototype.
9144
9145 * term.c (encode_terminal_code): Now external again, used by
9146 w32console.c and msdos.c.
9147
44f230aa
SM
9148 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9149 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9150
4b1ec863 91512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9152
1714f52b 9153 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9154
4b1ec863
PE
9155 * fringe.c (update_window_fringes): Mark locals as initialized
9156 (Bug#8227).
9157 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9158
524c7aa6
PE
9159 * alloc.c (mark_fringe_data): Move decl from here ...
9160 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9161 to check its interface.
9162 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9163
a5c0af81 9164 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9165 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9166 (fontset_font): Mark local as initialized.
a9a06e0b 9167 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9168
b4716021
PE
9169 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9170
811e9bac 9171 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9172 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9173 (x_own_selection, Fx_disown_selection_internal): Rename locals
9174 to avoid shadowing.
9175 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9176
7e3ab302
PE
9177 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9178 so that the caller can use some name other than gcpro1.
9179 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9180 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9181 (Fx_backspace_delete_keys_p):
9182 Use them to avoid shadowing, and rename vars to avoid shadowing.
9183 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9184 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9185 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9186 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9187 Remove unused locals.
7e3ab302
PE
9188 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9189 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9190 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9191 macros.
f78faa98 9192
e2b13473
PE
9193 * xterm.h (x_mouse_leave): New decl.
9194
77f23912
PE
9195 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9196 Remove unused functions.
cdf4ba58
PE
9197 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9198 (x_calc_absolute_position): Now static.
7411c686 9199 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9200 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9201 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9202 unless they are used.
38d0b34a
PE
9203 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9204 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9205 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9206 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9207 (x_error_catcher, x_connection_closed, x_error_handler):
9208 (x_error_quitter, xembed_send_message, x_iconify_frame):
9209 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9210 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9211 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9212
44f230aa
SM
9213 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9214 Rename or move locals to avoid shadowing.
6b463e58 9215 (tty_defined_color, merge_face_heights): Now static.
5967d051 9216 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9217 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9218 does not deduce is never used uninitialized.
73719eba
PE
9219 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9220 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9221
426994c3 9222 * terminal.c (store_terminal_param): Now static.
5489860b 9223
032f1620 9224 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9225 (set_frame_menubar): Remove unused local.
d4323972 9226 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9227 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9228 since they might point to immutable storage.
281585b0
PE
9229 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9230 since it's unused otherwise.
032f1620 9231
367c19e5 9232 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9233 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9234 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9235 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9236 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9237 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9238 does not deduce are never used uninitialized.
70739cbe 9239
07b48fa9
PE
9240 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9241
8868a238 9242 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9243 * window.c (window_loop, size_window):
9244 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9245
7e5cf297 9246 * window.c (display_buffer): Now static.
d6550a9f
PE
9247 (size_window): Mark variables that gcc -Wuninitialized
9248 does not deduce are never used uninitialized.
a586633d
PE
9249 * window.h (check_all_windows): New decl, to forestall
9250 gcc -Wmissing-prototypes diagnostic.
5b555da1 9251 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9252
f6095868
PE
9253 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9254 shadowing.
9255 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9256 Include <limits.h>.
9257 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9258 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9259 (load_charset_map): Mark variables that gcc -Wuninitialized
9260 does not deduce are never used uninitialized.
53df7c11 9261 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9262
f38b440c
PE
9263 * coding.c (coding_set_source, coding_set_destination):
9264 Use "else { /* comment */ }" rather than "else /* comment */;"
9265 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9266 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9267 a block, when the outer 'i' will do.
9268 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9269 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9270 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9271 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9272 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9273 Rename locals to avoid shadowing.
9274 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9275 * coding.c (emacs_mule_char, encode_invocation_designation):
9276 Now static, since they're not used elsewhere.
413bb2db 9277 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9278 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9279 (decode_coding_emacs_mule): Mark variables that gcc
9280 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9281 (detect_coding_iso_2022): Initialize a local variable that might
9282 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9283 this initialization is needed. (Bug#8211)
5f58e762
PE
9284 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9285 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9286 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9287 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9288 Remove unused macros.
f38b440c 9289
232b38b9 9290 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9291 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9292 * character.c (string_count_byte8): Likewise.
232b38b9 9293
fb90da1b
PE
9294 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9295 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9296
fb93dbc2
PE
9297 * chartab.c (copy_sub_char_table): Now static, since it's not used
9298 elsewhere.
5c156ace
PE
9299 (sub_char_table_ref_and_range, char_table_ref_and_range):
9300 Rename locals to avoid shadowing.
bbcd0949 9301 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9302
7d3b3862 9303 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9304 (BIDI_BOB): Remove unused macro.
7d3b3862 9305
6be7d3da
PE
9306 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9307 deduce are never used uninitialized.
c2ed9c8b 9308 * term.c (encode_terminal_code): Likewise.
6be7d3da 9309
75f8807f 9310 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9311
50938595
PE
9312 * tparam.h: New file.
9313 * term.c, tparam.h: Include it.
9314 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9315 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9316 Move these decls to tparam.h, and make them agree with what
9317 is actually in tparam.c. The previous trick of using incompatible
9318 decls in different modules does not conform to the C standard.
9319 All callers of tparam changed to use tparam's actual API.
9320 * tparam.c (tparam1, tparam, tgoto):
9321 Use const pointers where appropriate.
9322
fbceeba2
PE
9323 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9324 * cm.h (struct cm): Likewise.
9325 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9326 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9327 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9328 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9329 (turn_on_face, init_tty): Likewise.
9330 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9331
7f3f1250
PE
9332 * term.c (term_mouse_position): Rename local to avoid shadowing.
9333
e6ca6543
PE
9334 * alloc.c (mark_ttys): Move decl from here ...
9335 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9336
c40f8d15
AS
93372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9338
9339 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9340
cfe0661d
JB
93412011-03-09 Juanma Barranquero <lekktu@gmail.com>
9342
9343 * search.c (compile_pattern_1): Remove argument regp, unused since
9344 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9345 (compile_pattern): Don't pass it.
9346
0afb4571
J
93472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9348
9349 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9350 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9351 for ! HAVE_GTK3.
9352 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9353
9354 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9355
9356 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9357 gdk_window_get_screen, gdk_window_get_geometry,
9358 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9359 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9360 (xg_get_pixbuf_from_pixmap): New function.
9361 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9362 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9363 Call xg_get_pixbuf_from_pixmap instead of
9364 gdk_pixbuf_get_from_drawable.
9365 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9366 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9367 (xg_check_special_colors): Use GtkStyleContext and its functions
9368 for HAVE_GTK3.
9369 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9370 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9371 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9372 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9373 Call gtk_widget_get_preferred_size.
0afb4571
J
9374 (xg_frame_resized): gdk_window_get_geometry only takes 5
9375 parameters.
44f230aa
SM
9376 (xg_win_to_widget, xg_event_is_for_menubar):
9377 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9378 (xg_set_widget_bg): New function.
9379 (delete_cb): New function.
895009e1 9380 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9381 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9382 (xg_set_background_color): Call xg_set_widget_bg.
9383 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9384 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9385 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9386 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9387 if ! HAVE_GTK3.
9388 (update_frame_tool_bar): Call gtk_widget_hide.
9389 (xg_initialize): Use GDK_KEY_g.
9390
9391 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9392 if ! HAVE_GTK3
9393 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9394
9395 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9396 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9397 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9398
1c2cc4ef
JB
93992011-03-08 Juanma Barranquero <lekktu@gmail.com>
9400
9401 * w32xfns.c (select_palette): Check success of RealizePalette against
9402 GDI_ERROR, not zero.
9403
33383987 9404See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9405
9406;; Local Variables:
9407;; coding: utf-8
aac0c6e3
MR
9408;; End:
9409
acaf905b 9410 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9411
9412 This file is part of GNU Emacs.
9413
9414 GNU Emacs is free software: you can redistribute it and/or modify
9415 it under the terms of the GNU General Public License as published by
9416 the Free Software Foundation, either version 3 of the License, or
9417 (at your option) any later version.
9418
9419 GNU Emacs is distributed in the hope that it will be useful,
9420 but WITHOUT ANY WARRANTY; without even the implied warranty of
9421 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9422 GNU General Public License for more details.
9423
9424 You should have received a copy of the GNU General Public License
9425 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.