Move SYSTEM_TYPE from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a9be7d2b
GM
12012-06-11 Glenn Morris <rgm@gnu.org>
2
3 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
5 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
7
3017f87f
SM
82012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
9
10 * alloc.c (make_byte_code): New function.
11 (Fmake_byte_code): Use it. Don't purify here.
12 * lread.c (read1): Use it as well to avoid extra allocation.
13
1b9b4cf4
CY
142012-06-11 Chong Yidong <cyd@gnu.org>
15
16 * image.c (imagemagick_load_image): Implement transparency.
17
95988fcf
AS
182012-06-10 Andreas Schwab <schwab@linux-m68k.org>
19
20 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
21 account for preceding backslashes. (Bug#11663)
22
cd4eb164
CY
232012-06-09 Chong Yidong <cyd@gnu.org>
24
25 * term.c: Support italics in capable terminals (Bug#9652).
26 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
27 (turn_on_face): Output using TS_enter_italic_mode if available.
28 Don't handle unused blinking and alt-charset cases.
29 (turn_off_face): Handle italic case; discard unused tty_blinking_p
30 and tty_alt_charset_p cases.
31 (tty_capable_p, init_tty): Support italics.
32
33 * termchar.h (struct tty_display_info): Add field for italics.
34 Remove unused blink field.
35
36 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
37 Handle slant.
38
39 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
40 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
41 tty_alt_charset_p. Add tty_italic_p.
42
ff88beb8
MA
432012-06-09 Michael Albinus <michael.albinus@gmx.de>
44
45 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
46 dbus_type_is_basic if available.
47 (xd_extract_signed, xd_extract_unsigned): Rename from
48 extract_signed and extract_unsigned, respectively. Adapt callers.
49
44286096
CY
502012-06-09 Chong Yidong <cyd@gnu.org>
51
1682701f
CY
52 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
53
44286096
CY
54 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
55 case (Bug#9752).
56
d86feb17
PE
572012-06-08 Paul Eggert <eggert@cs.ucla.edu>
58
59 * xdisp.c (vmessage): Treat frame message as multibyte.
60 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
61 would generate the diagnostic "Making \302\247 buffer-local while
62 let-bound!".
63
d5c20fe8
EZ
642012-06-08 Eli Zaretskii <eliz@gnu.org>
65
66 * dispnew.c (showing_window_margins_p): Undo last change, which
67 was done due to an inadvertent commit.
68 (adjust_frame_glyphs_for_frame_redisplay): Do call
69 showing_window_margins_p.
70
513749ee
SM
712012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
72
73 * eval.c (Fmake_var_non_special): New primitive.
74 (syms_of_eval): Defsubr it.
75 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
76
d4a8f5c1
JB
772012-06-08 Juanma Barranquero <lekktu@gmail.com>
78
79 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
80 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
81
8bbbc977
EZ
822012-06-08 Eli Zaretskii <eliz@gnu.org>
83
84 * alloc.c (allocate_vectorlike): Fix last change.
85
f3372c87
DA
862012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
87
88 Block-based vector allocation of small vectors.
89 * lisp.h (struct vectorlike_header): New field `nbytes',
90 adjust comment accordingly.
91 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
92 to denote vector blocks. Adjust users (live_vector_p,
93 mark_maybe_pointer, valid_lisp_object_p) accordingly.
94 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
95 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
96 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
97 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
98 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
99 (roundup_size): New constant.
100 (struct vector_block): New data type.
101 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 102 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
103 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
104 (sweep_vectors): New functions.
105 (allocate_vectorlike): Return `zero_vector' as the only vector of
106 0 items. Allocate new vector from block if vector size is less than
107 or equal to VBLOCK_BYTES_MAX.
108 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
109 (init_alloc_once): Add call to init_vectors.
110
4f18a4ed
SM
1112012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
112
113 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
114
86f158bc
PE
1152012-06-07 Paul Eggert <eggert@cs.ucla.edu>
116
117 * doprnt.c (doprnt): Truncate multibyte char correctly.
118 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
119 would mishandle a string argument "Xc" if X was a multibyte
120 character of length 2: it would truncate after X's first byte
121 rather than including all of X.
122
c5cfcbe0
CY
1232012-06-06 Chong Yidong <cyd@gnu.org>
124
125 * buffer.c (word_wrap): Doc fix.
126
c05cf390
PE
1272012-06-04 Paul Eggert <eggert@cs.ucla.edu>
128
129 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
130
0c3461de
GM
1312012-06-03 Glenn Morris <rgm@gnu.org>
132
133 * xdisp.c (tool-bar-style): Doc fix.
134
c71232db
UM
1352012-06-03 Ulrich Müller <ulm@gentoo.org>
136
137 * Makefile.in (PAXCTL): Define.
138 (temacs$(EXEEXT)): Disable memory randomization for the temacs
139 binary via PaX flags if the paxctl utility is available.
140 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
141 Restore PaX flags to their default. (Bug#11398)
142
383f7350
CY
1432012-06-03 Chong Yidong <cyd@gnu.org>
144
145 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
146 buffer (Bug#11226).
147
5f2c76c6
CY
1482012-06-03 Chong Yidong <cyd@gnu.org>
149
150 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
151 (note_mode_line_or_margin_highlight): If there is no help echo,
152 use mode-line-default-help-echo. Handle the case where the mouse
153 position is past the end of the mode line string.
154
155 * buffer.c (buffer_local_value_1): New function, split from
156 Fbuffer_local_value; can return Qunbound.
157 (Fbuffer_local_value): Use it.
158 (Vmode_line_format): Docstring tweaks.
159
773d47f6
PE
1602012-06-02 Paul Eggert <eggert@cs.ucla.edu>
161
162 * sysdep.c (system_process_attributes): Improve comment.
163
f2d6a3df
SM
1642012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
165
166 * keyboard.c: Export real-this-command to Elisp.
167 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
168 and DEFVAR it. Update all users.
169
63810350
PE
1702012-06-02 Paul Eggert <eggert@cs.ucla.edu>
171
7bd5c1f4
PE
172 * minibuf.c (Fassoc_string): Remove duplicate declaration.
173
63810350
PE
174 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
175 Convert pctcpu and pctmem to Lisp float properly.
176 Let the compiler fold better, as 100.0/0x8000 is exact.
177
a2821611
AS
1782012-06-02 Andreas Schwab <schwab@linux-m68k.org>
179
180 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
181 cons_block.
182
5fceba1d
PE
1832012-06-01 Paul Eggert <eggert@cs.ucla.edu>
184
185 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
186
c98ff5dd
DA
1872012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
188
189 For a 'struct window', replace some Lisp_Object fields to
190 bitfields where appropriate, remove unused fields.
191 * window.h (struct window): Remove unused 'last_mark_x' and
192 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
193 change it's type from Lisp_Object to bitfield.
194 Change type of 'force_start', 'optional_new_start',
195 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
196 fields from Lisp_Object to bitfield. Adjust users accordingly.
197
ca34e0be
PE
1982012-05-31 Paul Eggert <eggert@cs.ucla.edu>
199
200 Pacify gcc -Wdouble-precision when using Xaw.
201 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
202 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
203 Use 'float' consistently, rather than 'float' in most places
204 and 'double' in a couple of places.
205
efc00ab1 2062012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
207
208 * xdisp.c (handle_stop): Detect whether we have overlay strings
209 loaded by testing it->current.overlay_string_index to be
210 non-negative, instead of checking whether n_overlay_strings is
211 positive. (Bug#11587)
212
efc00ab1 2132012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
214
215 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
216
217 * doc.c (Fsubstitute_command_keys): Doc fix.
218
efc00ab1 2192012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
220
221 * search.c (search_buffer): Remove calls to
222 r_alloc_inhibit_buffer_relocation, as it is now called by
223 maybe_unify_char, which was the cause of relocation of buffer text
224 in bug#11519.
225
efc00ab1 2262012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
227
228 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
229 for the duration of call to load_charset, to avoid problems with
230 callers of maybe_unify_char that access buffer text through C
231 pointers.
232
233 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
234 decrement the inhibition flag, instead of just setting or
235 resetting it.
236
ba93a187
PE
2372012-05-31 Paul Eggert <eggert@cs.ucla.edu>
238
239 Remove obsolete '#define static' cruft.
240 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
241 This #undef was "temporary" in 2000; it is no longer needed
242 now that '#define static' has gone away.
243 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
244 (gray_bitmap_bits): Remove; no longer needed.
245 All uses replaced with definiens.
246 * xterm.c: Include "bitmaps/gray.xbm".
247
9e4bf381
PE
2482012-05-30 Paul Eggert <eggert@cs.ucla.edu>
249
250 Clean up __executable_start, monstartup when --enable-profiling.
251 The following changes affect the code only when profiling.
252 * dispnew.c (__executable_start): Rename from safe_bcopy.
253 Define only on platforms that need it.
254 * emacs.c: Include <sys/gmon.h> when profiling.
255 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
256 (__executable_start): Remove decl, since lisp.h does it now.
257 (safe_bcopy): Remove decl; no longer has that name.
258 (main): Coalesce #if into single bit of code, for simplicity.
259 Cast pointers to uintptr_t, since standard libraries want integers
260 and not pointers.
261 * lisp.h (__executable_start): New decl.
262
32d72c2f
GM
2632012-05-31 Glenn Morris <rgm@gnu.org>
264
265 * image.c (Fimagemagick_types): Doc fix.
266
baac5bc7
JM
2672012-05-30 Jim Meyering <meyering@redhat.com>
268
269 * callproc.c (Fcall_process_region): Include directory component
270 in mkstemp error message (Bug#11586).
271
72cb32cf
PE
2722012-05-30 Paul Eggert <eggert@cs.ucla.edu>
273
274 * alloc.c, lisp.h (make_pure_vector): Now static.
275
61b108cc
SM
2762012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
277
278 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
279 Move to byte-run.el.
280 (Fautoload): Do the hash-doc more carefully.
281 * data.c (Fdefalias): Purify definition, except for keymaps.
282 (Qdefun): Move from eval.c.
283 * lisp.h (Qdefun): Remove.
284 * lread.c (read1): Tiny simplification.
285
471fe23d
TN
2862012-05-29 Troels Nielsen <bn.troels@gmail.com>
287
934f3f58 288 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
289 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
290 Bug#9642, but explicitly check that the buffer the overlay would
291 be moved to is live and rearrange lines to make sure that errors
292 will not put the overlay in an inconsistent state.
293 (Fdelete_overlay): Cosmetics.
294
85d0efd1
EZ
2952012-05-28 Eli Zaretskii <eliz@gnu.org>
296
297 * w32term.c (my_bring_window_to_top): New function.
298 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
299 could be different from the original one.
300 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
301 (Bug#11513)
302
303 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
304 by calling BringWindowToTop.
305
306 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
307 (WM_EMACS_END): Increase by one.
308
da92a98c
PE
3092012-05-28 Paul Eggert <eggert@cs.ucla.edu>
310
311 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
312 This avoids undefined behavior that might cause the eassert
313 to not catch an out-of-range value.
314
74d1f848
JB
3152012-05-28 Juanma Barranquero <lekktu@gmail.com>
316
317 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
318 Update dependencies.
319
9e1a06fc
EZ
3202012-05-27 Eli Zaretskii <eliz@gnu.org>
321
322 * bidi.c (bidi_mirror_char): Fix last change.
323
f3dd7312
AS
3242012-05-27 Andreas Schwab <schwab@linux-m68k.org>
325
326 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
327 when referring to sectname field in printf format.
328
81899c91
PE
3292012-05-27 Paul Eggert <eggert@cs.ucla.edu>
330
57b81a9f
PE
331 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
332 Only r_alloc_inhibit_buffer_relocation needed to be added;
333 the others were already declared.
334
81899c91
PE
335 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
336 before checking whether it's out of range. Put the check inside
337 eassert. See
338 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
339
33017faf 3402012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
341
342 * callproc.c (Fcall_process): Restore a line that was accidentally
343 commented out in the 2011-02-13 change (bug#11547).
344
33017faf 3452012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
346
347 * lisp.h [REL_ALLOC]: Add prototypes for external functions
348 defined on ralloc.c.
349
350 * buffer.c [REL_ALLOC]: Remove prototypes of
351 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
352 they are now on lisp.h.
353
354 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
355
356 * search.c (search_buffer): Use it to inhibit relocation of buffer
357 text while re_search_2 is doing its job, because re_search_2 is
358 passed C pointers to buffer text. (Bug#11519)
359
23415acf
EZ
360 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
361 Update value to 24.
362
44e27368
EZ
363 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
364 state after an additional call to move_it_in_display_line_to, keep
365 the values of it->max_ascent and it->max_descent found for the
366 entire line.
367 (pos_visible_p): Revert the comparison against bottom_y to what it
368 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
369 (Bug#11464)
370
c1892f11
PE
3712012-05-26 Paul Eggert <eggert@cs.ucla.edu>
372
373 Fix coding-related core dumps with gcc -ftrapv.
374 The code was computing A - B, where A and B are pointers, and B is
375 random garbage. This can lead to core dumps on platforms that
376 have special pointer registers, and it also leads to core dumps on
377 x86-64 when compiled with gcc -ftrapv. The fix is to compute
378 A - B only when B is initialized properly.
379 * coding.c (coding_set_source, coding_set_destination): Return void.
380 (coding_change_source, coding_change_destinations): New functions,
381 with the old behaviors of coding_set_source and coding_set_destination.
382 All callers that need an offset changed to use these new functions.
383
eb7afdad
GM
3842012-05-26 Glenn Morris <rgm@gnu.org>
385
386 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
387
f12fdf02
EZ
3882012-05-26 Eli Zaretskii <eliz@gnu.org>
389
53a63be6 390 Extend mouse support on W32 text-mode console.
61b108cc
SM
391 * xdisp.c (draw_row_with_mouse_face):
392 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 393
eb3f6f01 394 * w32console.c: Include window.h.
61b108cc
SM
395 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
396 New functions.
eb3f6f01
EZ
397 (initialize_w32_display): Initialize mouse-highlight data.
398
53a63be6
EZ
399 * w32inevt.c: Include termchar.h and window.h.
400 (do_mouse_event): Support mouse-autoselect-window. When the mouse
401 moves, call note_mouse_highlight. If help_echo changed, call
402 gen_help_event to produce help-echo message in the echo area.
403 Call clear_mouse_face if mouse_face_hidden is set in the mouse
404 highlight info.
405
4cfd81f6
PE
4062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
407
408 * lread.c (read1): Simplify slightly to avoid an overflow warning
409 with GCC 4.7.0 on x86-64.
410
4446092a
EZ
4112012-05-26 Eli Zaretskii <eliz@gnu.org>
412
413 * bidi.c (bidi_mirror_char): Revert last change: an int is
414 definitely wide enough here.
415
42b2a986 4162012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 417
42b2a986 418 Fix integer width and related bugs (Bug#9874).
eb106a49 419 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
420 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
421 (string_bytes, check_sblock, allocate_string_data):
422 (compact_small_strings, Fmake_bool_vector, make_string)
423 (make_unibyte_string, make_multibyte_string)
424 (make_string_from_bytes, make_specified_string)
425 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
426 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
427 (mark_vectorlike):
428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
429 (allocate_pseudovector):
430 Use int, not EMACS_INT, where int is wide enough.
431 (inhibit_garbage_collection, Fgarbage_collect):
432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
433 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
434 int might not be wide enough.
435 (bidi_cache_search, bidi_cache_find, bidi_init_it)
436 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
437 (bidi_at_paragraph_end, bidi_find_paragraph_start)
438 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
439 (bidi_level_of_next_char, bidi_move_to_visually_next):
440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
441 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
442 (Fkill_buffer, Fset_buffer_major_mode)
443 (advance_to_char_boundary, Fbuffer_swap_text)
444 (Fset_buffer_multibyte, overlays_at, overlays_in)
445 (overlay_touches_p, struct sortvec, record_overlay_string)
446 (overlay_strings, recenter_overlay_lists)
447 (adjust_overlays_for_insert, adjust_overlays_for_delete)
448 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
449 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
450 (Foverlay_recenter, last_overlay_modification_hooks_used)
451 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
453 (validate_region): Omit unnecessary test for b <= e,
454 since that's guaranteed by the previous test.
d311d28c
PE
455 (adjust_overlays_for_delete): Avoid pos + length overflow.
456 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
457 (report_overlay_modification):
458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
459 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
460 Omit pointer cast, which isn't needed anyway, and doesn't work
461 after the EMACS_INT -> ptrdiff_t change.
02481186 462 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
463 * buffer.h: Adjust decls to match defn changes elsewhere.
464 (struct buffer_text, struct buffer):
465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
466 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
467 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
468 not int, to avoid needless 32-bit limit on 64-bit hosts.
469 (exec_byte_code): Use tighter memory-full test, one that checks
470 for alloca overflow. Don't compute the address of the object just
471 before an array, as that's not portable. Use EMACS_INT, not
472 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
473 * callint.c (Fcall_interactively):
474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
475 * callproc.c (call_process_kill, Fcall_process):
476 Don't assume pid_t fits into an Emacs fixnum.
477 (call_process_cleanup, Fcall_process, child_setup):
478 Don't assume pid_t fits into int.
479 (call_process_cleanup, Fcall_process, delete_temp_file)
480 (Fcall_process_region):
481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
482 (Fcall_process): Simplify handling of volatile integers.
483 Use int, not EMACS_INT, where int will do.
484 * casefiddle.c (casify_object, casify_region, operate_on_word)
485 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
487 (casify_object): Avoid integer overflow when overallocating buffer.
488 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 489 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
490 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
491 * category.h (CATEGORYP): Don't assume arg is nonnegative.
492 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
493 integers are now checked earlier. All uses replaced with XINT.
494 (ccl_driver):
495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
496 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
497 (ccl_driver, Fregister_code_conversion_map):
498 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
499 (resolve_symbol_ccl_program): Check that vector header is in range.
500 Always copy the vector, so that we can check its contents reliably
501 now rather than having to recheck each instruction as it's being
502 executed. Check that vector words fit in 'int'.
503 (ccl_get_compiled_code, Fregister_ccl_program)
504 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
505 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
506 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
507 contents are in range.
508 (Fccl_execute_on_string): Check that status is in range.
509 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
510 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
511 Accept and return EMACS_INT, not int, because callers can pass values
512 out of 'int' range.
513 (c_string_width, strwidth, lisp_string_width, chars_in_text)
514 (multibyte_chars_in_text, parse_str_as_multibyte)
515 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
516 (str_as_unibyte, str_to_unibyte, string_count_byte8)
517 (string_escape_byte8, Fget_byte):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 519 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
520 avoid mishandling large integers.
521 * character.h: Adjust decls to match defn changes elsewhere.
522 * charset.c (load_charset_map_from_file, find_charsets_in_text)
523 (Ffind_charset_region):
524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
525 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
526 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 527 Don't assume fixnum fits in int.
d311d28c
PE
528 (load_charset_map_from_vector, Fmap_charset_chars):
529 Remove now-unnecessary CHECK_NATNUMs.
530 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
531 Don't rely on undefined behavior with signed left shift overflow.
532 Don't assume unsigned int fits into fixnum, or that fixnum fits
533 into unsigned int. Don't require max_code to be a valid fixnum;
534 that's not true for gb10830 4-byte on a 32-bit host. Allow
535 invalid_code to be a cons, for the same reason. Require code_offset
536 to be a character. Avoid int overflow if max_char is close
537 to INT_MAX.
538 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
539 this is intended anyway and avoids some undefined behavior.
540 (load_charset_map): Pass unsigned, not int, as 2nd arg of
541 INDEX_TO_CODE_POINT, as that's what it expects.
542 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
543 * charset.h (DECODE_CHAR): Return int, not unsigned;
544 this is what was intended anyway, and it avoids undefined behavior.
545 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
546 integer-overflow issues.
547 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
548 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
549 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
550 * chartab.c (Fmake_char_table, Fset_char_table_range)
551 (uniprop_get_decoder, uniprop_get_encoder):
552 Don't assume fixnum fits in int.
553 * cmds.c (move_point): New function, that does the gist of
554 Fforward_char and Fbackward_char, but does so while checking
555 for integer overflow more accurately.
c96e5d6a 556 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
557 (Fforward_line, Fend_of_line, internal_self_insert)
558 (internal_self_insert):
559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
560 Fix a FIXME, by checking for integer overflow when calculating
561 target_clm and actual_clm.
562 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 563 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
564 (ASSURE_DESTINATION, coding_alloc_by_realloc)
565 (coding_alloc_by_making_gap, alloc_destination)
566 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
567 (encode_coding_utf_16, detect_coding_emacs_mule)
568 (decode_coding_emacs_mule, encode_coding_emacs_mule)
569 (detect_coding_iso_2022, decode_coding_iso_2022)
570 (encode_invocation_designation, encode_designation_at_bol)
571 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
572 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
573 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
574 (encode_coding_ccl, encode_coding_raw_text)
575 (detect_coding_charset, decode_coding_charset)
576 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
577 (produce_composition, produce_charset, produce_annotation)
578 (decode_coding, handle_composition_annotation)
579 (handle_charset_annotation, consume_chars, decode_coding_gap)
580 (decode_coding_object, encode_coding_object, detect_coding_system)
581 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
582 (code_convert_region, code_convert_string)
8f50130c
PE
583 (Fdefine_coding_system_internal)
584 (coding_set_source, coding_set_destination):
d311d28c
PE
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
587 (Fdefine_coding_system_internal):
588 Don't assume fixnums fit in int.
589 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 590 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
591 (Funencodable_char_position, Fcheck_coding_systems_region)
592 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 594 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 595 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 596 Don't access memory outside of the args array.
d311d28c 597 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
598 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
599 result of ENCODE_CHAR.
d311d28c
PE
600 * coding.h: Adjust decls to match defn changes elsewhere.
601 (struct coding_system):
602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
603 * composite.c (get_composition_id, find_composition)
604 (run_composition_function, update_compositions)
605 (compose_text, composition_gstring_put_cache)
606 (composition_gstring_p, composition_gstring_width)
607 (fill_gstring_header, fill_gstring_body, autocmp_chars)
608 (composition_compute_stop_pos, composition_reseat_it)
609 (composition_update_it, struct position_record)
610 (find_automatic_composition, composition_adjust_point)
611 (Fcomposition_get_gstring, Ffind_composition_internal):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 (update_compositions):
614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
615 * composite.h: Adjust decls to match defn changes elsewhere.
616 (struct composition):
617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
618 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
619 Do not attempt to compute the address of the object just before a
620 buffer; this is not portable.
621 (Faref, Faset):
622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
623 (Faset): Use int, not EMACS_INT, where int is wide enough.
624 (Fstring_to_number): Don't assume fixnums fit in int.
625 (Frem): Don't assume arg is nonnegative.
626 * dbusbind.c (xd_append_arg): Check for integers out of range.
627 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 628 (extract_signed, extract_unsigned): New functions.
243e0530
PE
629 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
630 (xd_get_connection_references): Return ptrdiff_t, not int.
631 All uses changed.
632 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
633 (xd_read_message_1):
634 Use int, not unsigned, where the dbus API uses int.
635 (Fdbus_message_internal): Don't overflow mtype.
636 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
637 * dired.c (directory_files_internal, file_name_completion, scmp)
638 (file_name_completion_stat):
639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
640 (file_name_completion): Don't overflow matchcount.
641 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
642 * dispextern.h: Adjust decls to match defn changes elsewhere.
643 (struct text_pos, struct glyph, struct bidi_saved_info)
644 (struct bidi_string_data, struct bidi_it, struct composition_it)
645 (struct it):
646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
647 (struct display_pos, struct composition_it, struct it):
648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
649 * dispnew.c (increment_matrix_positions)
650 (increment_row_positions, mode_line_string)
651 (marginal_area_string):
652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 653 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
655 (duration_to_sec_usec): New function, to check for overflow better.
656 (Fsleep_for, sit_for): Use it.
657 * doc.c (get_doc_string, store_function_docstring):
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 (get_doc_string, Fsnarf_documentation):
660 Use int, not EMACS_INT, where int is wide enough.
661 (get_doc_string):
662 Use SAFE_ALLOCA, not alloca.
663 Check for overflow when converting EMACS_INT to off_t.
664 * doprnt.c (doprnt):
665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
666 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
667 Don't assume uid_t fits into fixnum.
668 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
669 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
670 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
671 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
672 (general_insert_function)
673 (Finsert_char, make_buffer_string, make_buffer_string_both)
674 (update_buffer_properties, Fbuffer_substring)
675 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
676 (Fsubst_char_in_region, check_translation)
677 (Ftranslate_region_internal, save_restriction_restore, Fformat)
678 (transpose_markers, Ftranspose_regions):
679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
680 (clip_to_bounds): Move to lisp.h as an inline function).
681 (Fconstrain_to_field): Don't assume integers are nonnegative.
682 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
683 (Fsubst_char_in_region, Fsave_restriction):
684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
685 (Femacs_pid): Don't assume pid_t fits into fixnum.
686 (lo_time): Use int, not EMACS_INT, when int suffices.
687 (lisp_time_argument): Check for usec out of range.
688 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
689 (Fuser_login_name, Fuser_full_name): Signal an error
690 if a uid argument is out of range, rather than relying on
691 undefined behavior.
c8d5c857
PE
692 (Fformat_time_string): Remove now-unnecessary check.
693 lisp_time_argument checks for out-of-range usec now.
243e0530 694 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
695 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
696 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
697 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
698 (init_cmdargs, Fdump_emacs):
699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
700 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
701 the bottom (typically) 32 bits of the fixnum.
702 * eval.c (specpdl_size, call_debugger):
703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
704 (when_entered_debugger, Fbacktrace_debug):
705 Don't assume fixnum can fit in int.
706 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
707 the object just before a buffer; this is not portable.
708 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
709 (grow_specpdl, unbind_to):
710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
711 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
712 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 713 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
714 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
715 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
717 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
718 (a_write, e_write):
719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
720 (Fcopy_file, non_regular_nbytes, read_non_regular)
721 (Finsert_file_contents):
722 Use int, not EMACS_INT, where int is wide enough.
723 (READ_BUF_SIZE): Verify that it fits in int.
724 (Finsert_file_contents): Check that counts are in proper range,
725 rather than assuming fixnums fit into ptrdiff_t etc.
726 Don't assume fixnums fit into int.
125b3835 727 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
728 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
729 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
730 (string_char_to_byte, string_byte_to_char)
731 (string_make_multibyte, string_to_multibyte)
732 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
733 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
734 (substring_both, Fdelete, internal_equal, Ffillarray)
735 (Fclear_string, mapcar1)
736 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
737 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
738 (larger_vector, make_hash_table, maybe_resize_hash_table)
739 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
740 (Fmaphash, secure_hash):
741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
742 (concat): Check for string index and length overflow.
743 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
744 (Frequire):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (larger_vector): New API (vec, incr_min, size_max) replaces old
747 one (vec, new_size, init). This catches size overflow.
748 INIT was removed because it was always Qnil.
749 All callers changed.
750 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
751 the upper bound on a hash table index size.
752 (make_hash_table, maybe_resize_hash_table): Use it.
753 (secure_hash): Computer start_byte and end_byte only after
754 they're known to be in ptrdiff_t range.
755 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
756 (Ffont_get_glyphs, Ffont_at):
757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
758 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
759 (Flist_fonts, Fopen_font):
760 Don't assume fixnum can fit in int.
761 (check_gstring): Don't assume index can fit in int.
762 (font_match_p): Check that fixnum is a character, not a nonnegative
763 fixnum, since the later code needs to stuff it into an int.
764 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
765 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
766 conversion overflow issues.
767 (Fopen_font): Check for integer out of range.
768 (Ffont_get_glyphs): Don't assume index can fit in int.
769 * font.h: Adjust decls to match defn changes elsewhere.
770 * fontset.c (reorder_font_vector): Redo score calculation to avoid
771 integer overflow.
772 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
773 printmax_t, where ptrdiff_t is wide enough.
774 (Finternal_char_font):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
777 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
778 (Fset_frame_position, x_set_frame_parameters)
779 (x_set_line_spacing, x_set_border_width)
780 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
781 Check that fixnums are in proper range for system types.
782 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
784 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
785 Use SAFE_ALLOCA_LISP, not alloca.
786 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
787 intptr_t is wide enough.
788 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
789 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
790 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
791 Check for fixnum out of range.
792 * ftfont.c (ftfont_list): Don't assume index fits in int.
793 Check that fixnums are in proper range for system types.
794 (ftfont_shape_by_flt):
795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
796 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
798 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
799 Check that fixnums are in proper range for system types.
800 * gnutls.h: Adjust decls to match defn changes elsewhere.
801 * gtkutil.c (xg_dialog_run):
802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
803 (update_frame_tool_bar):
804 Check that fixnums are in proper range for system types.
805 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 806 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
807 * indent.c (last_known_column, last_known_column_point):
808 (current_column_bol_cache):
809 (skip_invisible, current_column, check_display_width):
810 (check_display_width, scan_for_column, current_column_1)
811 (Findent_to, Fcurrent_indentation, position_indentation)
812 (indented_beyond_p, Fmove_to_column, compute_motion):
813 (Fcompute_motion, Fvertical_motion):
814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
815 (last_known_column_modified): Use EMACS_INT, not int.
816 (check_display_width):
817 (Fcompute_motion):
818 Check that fixnums and floats are in proper range for system types.
819 (compute_motion): Don't assume index or fixnum fits in int.
820 (compute_motion, Fcompute_motion):
821 Use int, not EMACS_INT, when it is wide enough.
822 (vmotion): Omit local var start_hpos that is always 0; that way
823 we don't need to worry about overflow in expressions involving it.
824 * indent.h: Adjust decls to match defn changes elsewhere.
825 (struct position):
826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
827 Use int, not EMACS_INT, where int is wide enough.
828 Remove unused members ovstring_chars_done and tab_offset;
829 all uses removed.
830 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
831 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
832 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
833 (make_gap, copy_text, insert, insert_and_inherit)
834 (insert_before_markers, insert_before_markers_and_inherit)
835 (insert_1, count_combining_before, count_combining_after)
836 (insert_1_both, insert_from_string)
837 (insert_from_string_before_markers, insert_from_string_1)
838 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
839 (adjust_after_replace, adjust_after_insert, replace_range)
840 (replace_range_2, del_range, del_range_1, del_range_byte)
841 (del_range_both, del_range_2, modify_region)
842 (prepare_to_modify_buffer, signal_before_change)
843 (signal_after_change, Fcombine_after_change_execute):
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
845 * intervals.c (traverse_intervals, rotate_right, rotate_left)
846 (balance_an_interval, split_interval_right, split_interval_left)
847 (find_interval, next_interval, update_interval)
848 (adjust_intervals_for_insertion, delete_node, delete_interval)
849 (interval_deletion_adjustment, adjust_intervals_for_deletion)
850 (static_offset_intervals, offset_intervals)
851 (merge_interval_right, merge_interval_left, make_new_interval)
852 (graft_intervals_into_buffer, temp_set_point_both)
853 (temp_set_point, set_point, adjust_for_invis_intang)
854 (set_point_both, move_if_not_intangible, get_property_and_range)
855 (get_local_map, copy_intervals, copy_intervals_to_string)
856 (compare_string_intervals, set_intervals_multibyte_1):
857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
858 * intervals.h: Adjust decls to match defn changes elsewhere.
859 (struct interval):
860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
861 * keyboard.c (this_command_key_count, this_single_command_key_start)
862 (before_command_key_count, before_command_echo_length, echo_now)
863 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
864 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
865 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
866 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
868 (last_non_minibuf_size, last_point_position, echo_truncate)
869 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
870 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
871 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
872 (stuff_buffered_input):
873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
874 (last_auto_save, command_loop_1, read_char):
875 Use EMACS_INT, not int, to avoid integer overflow.
876 (record_char): Avoid overflow in total_keys computation.
877 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
878 * keyboard.h: Adjust decls to match defn changes elsewhere.
879 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
880 (Fkey_description, Fdescribe_vector, Flookup_key):
881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
882 (click_position): New function, to check that positions are in range.
883 (Fcurrent_active_maps):
884 (describe_command):
885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
886 (Faccessible_keymaps, Fkey_description):
887 (preferred_sequence_p):
888 Don't assume fixnum can fit into int.
889 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
890 Check for integer overflow in size calculations.
891 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
892 avoid mishandling large integers.
893 * lisp.h: Adjust decls to match defn changes elsewhere.
894 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
895 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
896 (struct Lisp_Marker):
897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
898 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
899 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
900 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
901 All callers changed.
902 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
903 Assume the arg has valid form, since it always does.
904 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
905 unsigned integer system type.
906 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
907 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
909 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
910 (duration_to_sec_usec): New decl.
911 * lread.c (read_from_string_index, read_from_string_index_byte)
912 (read_from_string_limit, readchar, unreadchar, openp)
913 (read_internal_start, read1, oblookup):
914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
915 (Fload, readevalloop, Feval_buffer, Feval_region):
916 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
917 (openp): Check for out-of-range argument to 'access'.
918 (read1): Use int, not EMACS_INT, where int is wide enough.
919 Don't assume fixnum fits into int.
6efdadfd 920 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
921 (read_filtered_event): Use duration_to_sec_usec
922 to do proper overflow checking on durations.
d311d28c
PE
923 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
924 in size calculation.
925 (Fexecute_kbd_macro):
926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
927 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
928 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
929 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
930 (set_marker_both, set_marker_restricted_both, marker_position)
931 (marker_byte_position, Fbuffer_has_markers_at):
932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
933 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 934 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
935 It now merely ensures that the menu is large enough, without
936 necessarily growing it, as this avoids some integer overflow issues.
937 All callers changed.
938 (keymap_panes, parse_single_submenu, Fx_popup_menu):
939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
940 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
941 Use SAFE_ALLOCA_LISP, not alloca.
942 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
943 to EMACS_INT. Check that fixnums are in proper range for system types.
944 * minibuf.c (minibuf_prompt_width, string_to_object)
945 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
946 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 (get_minibuffer, read_minibuf_unwind):
949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
950 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
951 this simplifies overflow checking. All callers changed.
952 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
953 (Ftest_completion):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
956 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
957 Check that fixnums are in proper range for system types.
958 (Fx_create_frame, Fx_show_tip):
959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
960 * nsfont.m (ns_findfonts, nsfont_list_family):
961 Don't assume fixnum fits in long.
962 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
964 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
965 wide enough.
17fdb222 966 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
968 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
969 (PRINTDECLARE, PRINTPREPARE):
970 (strout, print_string):
971 (print, print_preprocess, print_check_string_charset_prop)
972 (print_object):
973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
974 (PRINTDECLARE):
975 (temp_output_buffer_setup, Fprin1_to_string, print_object):
976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 978 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 979 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
980 (print_error_message): Use SAFE_ALLOCA, not alloca.
981 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
982 (print_depth, new_backquote_output, print_number_index):
983 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
984 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
985 (Fset_process_window_size, Fformat_network_address)
986 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 987 (sigchld_handler):
d311d28c 988 Check that fixnums are in proper range for system types.
d44287d4 989 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
990 Check for process-ids out of pid_t range rather than relying on
991 undefined behavior.
e4d81efc 992 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
993 (Fformat_network_address, read_process_output, send_process)
994 (Fprocess_send_region, status_notify):
995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
996 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
997 (wait_reading_process_output, read_process_output, exec_sentinel):
998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
999 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1000 (Faccept_process_output): Use duration_to_sec_usec to do proper
1001 overflow checking on durations.
dde14581
PE
1002 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1003 Don't assume pid_t fits in int.
02481186
PE
1004 * process.h (struct Lisp_Process): Members tick and update_tick
1005 are now of type EMACS_INT, not int.
b62b53e8
PE
1006 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1007 configured --with-wide-int.
d311d28c
PE
1008 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1009 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1010 * search.c (looking_at_1, string_match_1):
1011 (fast_string_match, fast_c_string_match_ignore_case)
1012 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1013 (scan_newline, find_before_next_newline, search_command)
1014 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1015 (set_search_regs, wordify):
1016 (Freplace_match):
1017 (Fmatch_data):
1018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1019 (string_match_1, search_buffer, set_search_regs):
1020 (Fmatch_data):
1021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1022 (wordify): Check for overflow in size calculation.
1023 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1024 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1025 Check that fixnums are in proper range for system types.
1026 * sound.c (struct sound_device)
1027 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1029 (Fplay_sound_internal):
1030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1031 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1032 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1033 (Fparse_partial_sexp):
1034 Don't assume fixnums can fit in int.
1035 (struct lisp_parse_state, find_start_pos, find_start_value)
1036 (find_start_value_byte, find_start_begv)
1037 (update_syntax_table, char_quoted, dec_bytepos)
1038 (find_defun_start, prev_char_comend_first, back_comment):
1039 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1040 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1042 (Finternal_describe_syntax_value): Check that match_lisp is a
1043 character, not an integer, since the code stuffs it into int.
1044 (scan_words, scan_sexps_forward):
1045 Check that fixnums are in proper range for system types.
1046 (Fforward_word):
1047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1048 (scan_sexps_forward):
1049 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1050 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1051 * syntax.h: Adjust decls to match defn changes elsewhere.
1052 (struct gl_state_s):
1053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1054 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1055 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1056 * sysdep.c (wait_for_termination_1, wait_for_termination)
1057 (interruptible_wait_for_termination, mkdir):
1058 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1059 (emacs_read, emacs_write):
1060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1061 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1062 and double all fit in int.
d311d28c
PE
1063 * term.c (set_tty_color_mode):
1064 Check that fixnums are in proper range for system types.
1065 * termhooks.h (struct input_event):
1066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1067 * textprop.c (validate_interval_range, interval_of)
1068 (Fadd_text_properties, set_text_properties_1)
1069 (Fremove_text_properties, Fremove_list_of_text_properties)
1070 (Ftext_property_any, Ftext_property_not_all)
1071 (copy_text_properties, text_property_list, extend_property_ranges)
1072 (verify_interval_modification):
1073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1074 (Fnext_single_char_property_change)
1075 (Fprevious_single_char_property_change):
1076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1077 (copy_text_properties):
1078 Check for integer overflow in index calculation.
d311d28c
PE
1079 * undo.c (last_boundary_position, record_point, record_insert)
1080 (record_delete, record_marker_adjustment, record_change)
1081 (record_property_change):
1082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1083 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1085 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1086 (Fx_hide_tip, Fx_file_dialog):
1087 * w32menu.c (set_frame_menubar):
1088 Use ptrdiff_t, not int, for consistency with rest of code.
1089 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1090 (select_window, Fdelete_other_windows_internal)
1091 (window_scroll_pixel_based, window_scroll_line_based)
1092 (Frecenter, Fset_window_configuration):
1093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1094 (Fset_window_hscroll, run_window_configuration_change_hook)
1095 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1096 (Fscroll_other_window, Frecenter):
d311d28c
PE
1097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1098 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1099 Don't assume fixnum fits in int.
1100 (Fset_window_scroll_bars):
1101 Check that fixnums are in proper range for system types.
1102 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1103 (string_pos, c_string_pos, number_of_chars, init_iterator)
1104 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1105 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1106 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1107 (face_before_or_after_it_pos, handle_invisible_prop)
1108 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1109 (display_prop_intangible_p, string_buffer_position_lim)
1110 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1111 (get_overlay_strings_1, get_overlay_strings)
1112 (iterate_out_of_display_property, forward_to_next_line_start)
1113 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1114 (get_next_display_element, set_iterator_to_next)
1115 (get_visually_first_element, compute_stop_pos_backwards)
1116 (handle_stop_backwards, next_element_from_buffer)
1117 (move_it_in_display_line_to, move_it_in_display_line)
1118 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1119 (add_to_log, message_dolog, message_log_check_duplicate)
1120 (message2, message2_nolog, message3, message3_nolog
1121 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1122 (current_message_1, truncate_echo_area, truncate_message_1)
1123 (set_message, set_message_1, store_mode_line_noprop)
1124 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1125 (text_outside_line_unchanged_p, check_point_in_composition)
1126 (reconsider_clip_changes)
1127 (redisplay_internal, set_cursor_from_row, try_scrolling)
1128 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1129 (redisplay_window, find_last_unchanged_at_beg_row)
1130 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1131 (trailing_whitespace_p, find_row_edges, display_line)
1132 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1133 (display_mode_element, store_mode_line_string)
1134 (pint2str, pint2hrstr, decode_mode_spec)
1135 (display_count_lines, display_string, draw_glyphs)
1136 (x_produce_glyphs, x_insert_glyphs)
1137 (rows_from_pos_range, mouse_face_from_buffer_pos)
1138 (fast_find_string_pos, mouse_face_from_string_pos)
1139 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 (safe_call, init_from_display_pos, handle_fontified_prop)
1142 (handle_single_display_spec, load_overlay_strings)
1143 (with_echo_area_buffer, setup_echo_area_for_printing)
1144 (display_echo_area, echo_area_display)
1145 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1146 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1147 (redisplay_window, dump_glyph_row, display_mode_line)
1148 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1149 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1151 (handle_single_display_spec, build_desired_tool_bar_string)
1152 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1153 (get_specified_cursor_type):
1154 Check that fixnums are in proper range for system types.
1155 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1156 (Flookup_image_map):
1157 Don't assume fixnums fit in int.
1158 (compare_overlay_entries):
1159 Avoid mishandling comparisons due to subtraction overflow.
1160 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1161 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1162 (handle_tool_bar_click):
1163 Use int, not unsigned, since we prefer signed and the signedness
1164 doesn't matter here.
1165 (get_next_display_element, next_element_from_display_vector):
1166 Use int, not EMACS_INT, when int is wide enough.
1167 (start_hourglass): Use duration_to_sec_usec to do proper
1168 overflow checking on durations.
1169 * xfaces.c (Fbitmap_spec_p):
1170 Check that fixnums are in proper range for system types.
1171 (compare_fonts_by_sort_order):
1172 Avoid mishandling comparisons due to subtraction overflow.
1173 (Fx_family_fonts, realize_basic_faces):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 (Fx_family_fonts):
1176 Don't assume fixnum fits in int.
1177 Use SAFE_ALLOCA_LISP, not alloca.
1178 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1179 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1180 (face_at_buffer_position, face_for_overlay_string)
1181 (face_at_string_position):
1182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1183 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1184 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1185 (Fx_show_tip):
1186 Check that fixnums are in proper range for system types.
1187 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1188 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1190 (Fx_change_window_property): Don't assume fixnums fit in int.
1191 * xfont.c (xfont_chars_supported):
1192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1193 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1194 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1196 * xml.c (parse_region):
1197 * xrdb.c (magic_file_p):
1198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1199 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1200 (x_get_local_selection, x_reply_selection_request)
1201 (x_handle_selection_request, wait_for_property_change):
1202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1203 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1204 short is wide enough.
1205 (x_send_client_event): Don't assume fixnum fits in int.
1206 * xterm.c (x_x_to_emacs_modifiers):
1207 Don't assume EMACS_INT overflows nicely into int.
1208 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1209 may come from Lisp.
1210 (handle_one_xevent): NATNUMP can eval its arg twice.
1211 (x_connection_closed):
1212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1213 * xterm.h: Adjust decls to match defn changes elsewhere.
1214 (struct scroll_bar): Use struct vectorlike_header
1215 rather than rolling our own approximation.
1216 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1217
c6574eb5
GM
12182012-05-25 Glenn Morris <rgm@gnu.org>
1219
1220 * lisp.mk (lisp): Update for more files being compiled now.
1221
e8d32c7e
SM
12222012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1223
48def666
SM
1224 * lread.c: Remove `read_pure' which makes no difference.
1225 (read_pure): Remove var.
1226 (unreadpure): Remove function.
1227 (readevalloop): Don't call read_list with -1 flag.
1228 (read1, read_vector): Don't test read_pure any more.
1229 (read_list): Simplify.
1230
e8d32c7e
SM
1231 * fileio.c, character.h: Minor style tweaks.
1232
4b2addb7
DA
12332012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1234
1235 * window.h (clip_changed): Remove useless declaration.
1236
584461b2
JB
12372012-05-22 Juanma Barranquero <lekktu@gmail.com>
1238
1239 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1240 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1241
34374650
PE
12422012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 Remove src/m/*.
1245 This directory predates autoconf and is no longer needed nowadays.
1246 Move its few remaining bits of functionality to where they're needed.
1247 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1248 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1249 * m/template.h: Remove.
1250 * Makefile.in (M_FILE): Remove. All uses removed.
1251 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1252 * lisp.h (USE_LSB_TAG):
1253 * mem-limits.h (EXCEEDS_LISP_PTR):
1254 Use VAL_MAX, not VALBITS, in #if.
1255 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1256 (EMACS_UINT): Define unconditionally now.
1257 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1258 (BITS_PER_EMACS_INT): New constants, replacing
1259 what used to be in config.h, but not useful in #if.
1260 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1261 define them any more.
1262 (VAL_MAX): New macro.
1263 (VALMASK): Use it.
1264 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1265 BITS_PER_EMACS_INT, in #if.
1266 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1267 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1268 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1269 * s/ms-w32.h (DATA_START):
1270 Move here from removed file m/intel386.h.
1271 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1272 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1273
261cb4bb
PE
12742012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1275
1276 Assume C89 or later.
1277 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1278 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1279 (xrealloc):
1280 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1281 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1282 * textprop.c, tparam.c (NULL): Remove.
1283 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1284 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1285 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1286 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1287 * xterm.c (input_signal_count): Assume volatile works.
1288
ff23cd9f
KB
12892012-05-21 Ken Brown <kbrown@cornell.edu>
1290
1291 * xgselect.c (xg_select): Fix first argument in call to 'select'
1292 (bug#11508).
1293
1b170bc6
KB
12942012-05-20 Ken Brown <kbrown@cornell.edu>
1295
1296 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1297 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1298
b2f4d39f
KB
12992012-05-19 Ken Brown <kbrown@cornell.edu>
1300
1301 * xfns.c (x_in_use): Remove `static' qualifier.
1302 * xterm.h (x_in_use): Declare.
1303 * xgselect.c: Include xterm.h.
1304 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1305 and `display_arg' (bug#9754).
1306
003fdae2
PE
13072012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1308
9232a6d9
PE
1309 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1310
003fdae2
PE
1311 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1312 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1313
784b56e2
EZ
13142012-05-18 Eli Zaretskii <eliz@gnu.org>
1315
1316 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1317
1318 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1319 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1320
1321 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1322 reference to image_cache->refcount.
1323 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1324
a0a79cde
JL
13252012-05-17 Juri Linkov <juri@jurta.org>
1326
1327 * search.c (Fword_search_regexp, Fword_search_backward)
1328 (Fword_search_forward, Fword_search_backward_lax)
1329 (Fword_search_forward_lax): Move functions to isearch.el
1330 (bug#10145, bug#11381).
1331
b0572523
PE
13322012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1335
9660f5fc
SM
13362012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1337
1338 * lread.c (init_obarray): Declare Qt and Qnil as special.
1339
4374de83
GM
13402012-05-14 Glenn Morris <rgm@gnu.org>
1341
1342 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1343 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1344
dc44c39a
PE
13452012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1346
078c97cb
PE
1347 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1348
dc44c39a
PE
1349 * unexaix.c: Port to more-recent AIX compilers.
1350 (report_error, report_error_1, make_hdr, copy_sym)
1351 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1352 Make arguments const char *, not char *, to avoid violations of C
1353 standard and to fix some AIX warnings reported by Gilles Pion.
1354
e18afed7 13552012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1356
1357 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1358 already have overlays loaded.
1359 (handle_single_display_spec): Before returning without displaying
1360 fringe bitmap, synchronize the bidi iterator with the main display
1361 iterator, by calling iterate_out_of_display_property.
1362 (iterate_out_of_display_property): Detect buffer iteration by
1363 testing that it->string is a Lisp string.
1364 (get_next_display_element): When the current object is exhausted,
1365 and there's something on it->stack, call set_iterator_to_next to
1366 proceed with what's on the stack, instead of returning zero.
1367 (set_iterator_to_next): If called at the end of a Lisp string,
1368 proceed to consider_string_end without incrementing string
1369 position. Don't increment display vector index past the end of
1370 the display vector. (Bug#11417)
c8fb9dc6
EZ
1371 (pos_visible_p): Don't report a position visible when move_it_to
1372 stopped at the last line of window, which happens to be scanned
1373 backwards by the bidi iteration. (Bug#11464)
ac268e67 1374
e18afed7 13752012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1376
1377 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1378 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1379 are on a TTY, and thus unable to display on the fringes.
1380 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1381 so we need to signal to the caller that this is a "replacing"
1382 display spec. This fixes display when the spec is invalid or we
1383 are on a TTY.
1384
e18afed7 13852012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1386
1387 * unexaix.c (make_hdr): Fix typo in prototype.
1388 This bug broke the build on AIX. Problem reported by Gilles Pion.
1389
9d0a235a
MA
13902012-05-14 Michael Albinus <michael.albinus@gmx.de>
1391
1392 * keyboard.c (kbd_buffer_get_event): Read special events also in
1393 batch mode. (Bug#11415)
1394
9e6b06ed
GM
13952012-05-12 Glenn Morris <rgm@gnu.org>
1396
1397 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1398
c1a1d7a3
EZ
13992012-05-12 Eli Zaretskii <eliz@gnu.org>
1400
1401 * lisp.mk (lisp): Add newcomment.elc.
1402
3fe7cdc8
GM
14032012-05-12 Glenn Morris <rgm@gnu.org>
1404
1405 * Makefile.in (MKDIR_P): New, set by configure.
1406 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1407
53f7d2c0
PE
14082012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 Remove unused function hourglass_started.
1411 * dispextern.h (hourglass_started):
1412 * w32fns.c (hourglass_started):
1413 * xdisp.c (hourglass_started): Remove.
1414
75aafb17
JB
14152012-05-10 Juanma Barranquero <lekktu@gmail.com>
1416
1417 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1418 Update dependencies.
1419
12959e8e
PE
14202012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1421
97107e2e
PE
1422 * xgselect.c (xg_select): Put maxfds+1 into a var.
1423 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1424
12959e8e
PE
1425 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1426
836d29b3
DA
14272012-05-10 Dave Abrahams <dave@boostpro.com>
1428
1429 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1430 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1431
5cb67954
MA
14322012-05-09 Michael Albinus <michael.albinus@gmx.de>
1433
1434 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1435 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1436 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1437 Initialize xd_registered_buses.
1438
3478ec45
PE
14392012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1440
b263a6b0
PE
1441 Untag more efficiently if USE_LSB_TAG.
1442 This is based on a proposal by YAMAMOTO Mitsuharu in
1443 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1444 For an admittedly artificial (nth 8000 longlist) benchmark on
1445 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1446 Emacs's overall text size by 1%.
1447 * lisp.h (XUNTAG): New macro.
1448 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1449 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1450 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1451 * eval.c (Fautoload):
1452 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1453 * frame.h (XFRAME): Use XUNTAG.
1454
3478ec45
PE
1455 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1456 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1457 Remove unportable assumptions about print widths of types like
1458 dbus_uint32_t.
1459 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1460 intptr_t when converting between pointer and integer, to avoid GCC
1461 warnings about wrong width.
1462
666b903b 14632012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1464
1465 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1466 stack for each reader_thread, instead of defaulting to 8MB
1467 determined by the linker. This avoids failures in creating
1468 subprocesses on Windows 7, see the discussion in this thread:
1469 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1470
b120cc17
JC
14712012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1472
1473 Fix up display of the *Minibuf-0* buffer in the mini window.
1474 * keyboard.c (read_char): Don't clear the echo area if there's no
1475 message to clear.
1476 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1477 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1478
9a4b36f8
MA
14792012-05-07 Michael Albinus <michael.albinus@gmx.de>
1480
1481 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1482 batch mode.
1483
e5f9458f
CY
14842012-05-06 Chong Yidong <cyd@gnu.org>
1485
1486 * lisp.mk (lisp): Update.
1487
eceeb5fc 14882012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1489
1490 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1491
71873e2b
SM
14922012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1493
1494 * data.c (PUT_ERROR): New macro.
1495 (syms_of_data): Use it. Add new error type `user-error'.
1496 * undo.c (user_error): New function.
1497 (Fprimitive_undo): Use it.
1498 * print.c (print_error_message): Adjust print style for `user-error'.
1499 * keyboard.c (user_error): New function.
1500 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1501
ab0fa4e4
PE
15022012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 Do not limit current-time-string to years 1000..9999.
1505 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1506 (Fcurrent_time_string): Support any year that is supported by the
1507 underlying localtime representation. Don't use asctime, as it
1508 has undefined behavior for years outside the range -999..9999.
1509
7ed806a7
PE
15102012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 Fix race conditions involving setenv, gmtime, localtime, asctime.
1513 Without this fix, interrupts could mess up code that uses these
1514 nonreentrant functions, since setting TZ invalidates existing
1515 tm_zone or tzname values, and since most of these functions return
1516 pointers to static storage.
1517 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1518 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1519 Grow the critical sections to include not just invoking
1520 localtime/gmtime, but also accessing these functions' results
1521 including their tm_zone values if any, and any related TZ setting.
1522 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1523 so that the struct tm is saved in the critical section.
1524 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1525 motivated by the fact that memory allocation needs to be outside
1526 the critical section.
1527
0c16dfed
DA
15282012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1529
1530 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1531 with RESET_INTERVAL.
1532
1533 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1534 Remove duplicated buffer name initialization.
1535
3f83ace8
JM
15362012-05-02 Jim Meyering <jim@meyering.net>
1537
1538 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1539
c7b8541e
JM
1540 * xfns.c (x_window): Use xstrdup (Bug#11375).
1541
90207a15 15422012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1543
1544 * xdisp.c (pos_visible_p): If already at a newline from the
1545 display string before the 'while' loop, don't walk back the glyphs
1546 from it3.glyph_row. Solves assertion violation when the display
1547 string begins with a newline (egg.el). (Bug#11367)
1548
b593d6a9
AH
15492012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1550
1551 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1552 Move to simple.el.
1553
4737362e
GM
15542012-05-01 Glenn Morris <rgm@gnu.org>
1555
99cf43f9
GM
1556 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1557 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1558 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1559 All were removed before 23.1.
1560
9311dcff
GM
1561 * dispnew.c: Remove HAVE_LIBNCURSES test;
1562 it is always true on relevant platforms.
1563
4d5c6349
GM
1564 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1565 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1566
4737362e
GM
1567 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1568
74dd3a6b
AS
15692012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1570
1571 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1572 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1573 Remove.
1574
13c379ee
PE
15752012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 Do not avoid creating empty evaporating overlays (Bug#9642).
1578 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1579 That is, do not delete an evaporating overlay if it becomes
1580 empty after its bounds are adjusted to fit within its buffer.
1581 This fix caused other problems, and I'm reverting it until we get
1582 to the bottom of them.
1583
a8e7d6d7 15842012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1585
1586 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1587
a8e7d6d7 15882012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1589
1590 * xdisp.c (pos_visible_p): If the window start position is beyond
1591 ZV, start the display from buffer beginning. Prevents assertion
1592 violation in init_iterator when the minibuffer window is scrolled
1593 via the scroll bar.
1594
1595 * window.c (window_scroll_pixel_based): Likewise.
1596
a8e7d6d7 15972012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1598
1599 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1600
a8e7d6d7 16012012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1602
1603 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1604 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1605
a8e7d6d7 16062012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1607
b593d6a9
AH
1608 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1609 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1610
1c6900d9
EZ
16112012-04-26 Eli Zaretskii <eliz@gnu.org>
1612
4c3fa1d9
EZ
1613 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1614 display element, check also the underlying string or buffer
1615 character. (Bug#11341)
1616
1c6900d9
EZ
1617 * w32menu.c: Include w32heap.h.
1618 (add_menu_item): If the call to AppendMenuW (via
1619 unicode_append_menu) fails, disable Unicode menus only if we are
1620 running on Windows 9X/Me.
1621
42bf8205
AS
16222012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1623
1624 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1625 (xgetint): Add missing shift for LSB tags.
1626
b1bac16e
MR
16272012-04-24 Martin Rudalics <rudalics@gmx.at>
1628
1629 * keyboard.c (read_char): Don't wipe echo area for select window
1630 events: These might get delayed via `mouse-autoselect-window'
1631 (Bug#11304).
1632
d69621cc
JB
16332012-04-24 Juanma Barranquero <lekktu@gmail.com>
1634
1635 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1636 manipulation of :loaded-from data.
1637
02fd101b
JB
16382012-04-23 Juanma Barranquero <lekktu@gmail.com>
1639
1640 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1641 now a cons (bug#11311).
1642
888bec30
PE
16432012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1644
89a438bd
PE
1645 Do not create empty overlays with the evaporate property (Bug#9642).
1646 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1647 if it becomes empty after its bounds are adjusted to fit within
1648 its buffer. Without this fix, in a nonempty buffer (let ((o
1649 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1650 yields an empty overlay that has the evaporate property, which is
1651 not supposed to happen.
1652
1068fe4d
PE
1653 Fix minor GTK3 problems found by static checking.
1654 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1655 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1656 (struct _EmacsFixedClass, emacs_fixed_get_type):
1657 Move decls here from emacsgtkfixed.h, since they needn't be public.
1658 (emacs_fixed_get_type): Now static.
1659 (emacs_fixed_class_init): Omit unused local.
1660 (emacs_fixed_child_type): Remove; unused.
1661 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1662 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1663 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1664 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1665 (EMACS_FIXED_GET_CLASS): Remove; unused.
1666 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1667
888bec30
PE
1668 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1669 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1670
de85e130
PE
16712012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1672
d0baac98 1673 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1674 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1675 (__malloc_size_t, __malloc_ptrdiff_t):
1676 Remove. All uses removed, replaced by the definiens if needed,
1677 since we can assume C89 or better now.
1678 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1679 (protect_malloc_state, align, get_contiguous_space)
1680 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1681 (malloc_atfork_handler_child, malloc_enable_thread)
1682 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1683 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1684 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1685 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1686 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1687 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1688 Define using prototypes, not old style.
1689 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1690 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1691 (align): Don't assume that signed integer overflow wraps around.
1692 Omit unused local var.
1693 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1694 (_free_internal_nolock, memalign, mallochook, reallochook):
1695 Omit no-longer-needed casts.
1696 (valloc): Use getpagesize, not __getpagesize.
1697 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1698 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1699
de85e130
PE
1700 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1701
dcbf5805
MA
17022012-04-22 Michael Albinus <michael.albinus@gmx.de>
1703
1704 Move functions from C to Lisp. Make non-blocking method calls
1705 the default. Implement further D-Bus standard interfaces.
1706
1707 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1708 (QCdbus_request_name_allow_replacement)
1709 (QCdbus_request_name_replace_existing)
1710 (QCdbus_request_name_do_not_queue)
1711 (QCdbus_request_name_reply_primary_owner)
1712 (QCdbus_request_name_reply_in_queue)
1713 (QCdbus_request_name_reply_exists)
1714 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1715 (QCdbus_registered_serial, QCdbus_registered_method)
1716 (QCdbus_registered_signal): New Lisp objects.
1717 (XD_DEBUG_MESSAGE): Use sizeof.
1718 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1719 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1720 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1721 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1722 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1723 (xd_signature, xd_append_arg): Allow float for integer types.
1724 (xd_get_connection_references): New function.
b593d6a9
AH
1725 (xd_get_connection_address): Rename from xd_initialize.
1726 Return cached address.
dcbf5805
MA
1727 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1728 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1729 level.
1730 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1731 Return number of refcounts.
dcbf5805
MA
1732 (Fdbus_get_unique_name): Make stronger parameter check.
1733 (Fdbus_message_internal): New defun.
1734 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1735 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1736 (Fdbus_send_signal, Fdbus_register_service)
1737 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1738 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1739 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1740 (Vdbus_compiled_version, Vdbus_runtime_version)
1741 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1742 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1743 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1744 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1745 Adapt docstring.
dcbf5805 1746
52828e02
PE
17472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1748
da05bc4c
PE
1749 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1750 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1751 Do not assume ptrdiff_t is the same width as 'int'.
1752
52828e02
PE
1753 * alloc.c: Handle unusual debugging option combinations.
1754 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1755 since the two debugging options are incompatible.
1756 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1757 is defined.
1758 (mem_init, mem_insert, mem_insert_fixup):
1759 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1760 (NEED_MEM_INSERT): Remove; no longer needed.
1761
f01769f9
LL
17622012-04-22 Leo Liu <sdl.web@gmail.com>
1763
1764 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1765
5790543d
PE
17662012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 * sysdep.c [__FreeBSD__]: Minor cleanups.
1769 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1770 Use Emacs indenting style more consistently. Avoid some casts.
1771 Use 'double' consistently rather than mixing 'float' and 'double'.
1772
b91b7e4d
EW
17732012-04-21 Eduard Wiebe <usenet@pusto.de>
1774
b593d6a9
AH
1775 * sysdep.c (list_system_processes, system_process_attributes):
1776 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1777
6114eb15
AS
17782012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1779
1780 * lisp.mk (lisp): Update.
1781
2f38dff7
PE
17822012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1785 It is never used otherwise.
1786
4ae29f89
SM
17872012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1788
1789 * print.c (print_preprocess): Only check print_depth if print-circle
1790 is nil.
1791 (print_object): Check for cycles even when print-circle is nil and
1792 print-gensym is t, but only check print_depth if print-circle is nil.
1793
f30d612a
CY
17942012-04-20 Chong Yidong <cyd@gnu.org>
1795
1796 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1797 set the status to "failed" and ensure that sentinel is run.
1798
c07a4c0b 17992012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1800
1801 * process.c (Fset_process_inherit_coding_system_flag)
1802 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1803 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1804
c07a4c0b 18052012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1806
1807 * xdisp.c (string_buffer_position_lim): Limit starting position to
1808 BEGV.
1809 (set_cursor_from_row): If called for a mode-line or header-line
1810 row, return zero immediately.
1811 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1812 farther than the first row after the header line, if any.
1813 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1814 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1815
c07a4c0b 18162012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1817
4ae29f89
SM
1818 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1819 (bug#11238).
ad3a2b41 1820
c07a4c0b 18212012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 18222012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1823
1824 configure: new option --enable-gcc-warnings (Bug#11207)
1825 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1826 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1827 (ALL_CFLAGS): Use new macros rather than old.
1828 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1829 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1830 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1831 -Wunused-result, -Wunused-variable. This should go away once
1832 the Emacs and Gnulib regex code is merged.
1833 (xmalloc, xrealloc): Now static.
1834
aba027e8
PE
18352012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * dired.c (Fsystem_groups): Remove unused local.
1838
e5a36063
GM
18392012-04-17 Glenn Morris <rgm@gnu.org>
1840
1841 * dired.c (Fsystem_users): Doc fix.
1842
316411f0
DA
18432012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1844
1845 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1846 (syms_of_dired): Add them.
1847
9426aba4
PE
18482012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1849
b62a57be
PE
1850 Fix minor alloc.c problems found by static checking.
1851 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1852 New extern decls, to avoid calling undeclared functions.
1853 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1854 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1855 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1856 (NEED_MEM_INSERT): New macro.
1857 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1858 Remove one incorrect comment and fix another.
b62a57be 1859
3539f31f
PE
1860 Fix minor ralloc.c problems found by static checking.
1861 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1862 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1863 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1864 (r_alloc_sbrk): Now static.
1865
a041960a
PE
1866 Improve ralloc.c interface checking.
1867 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1868 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1869 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1870 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1871 [REL_ALLOC]: ... to here, to check interface.
1872 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1873 Remove decls. This fixes an "It stinks!".
1874
9426aba4
PE
1875 * alloc.c (which_symbols): Fix alignment issue / type clash.
1876
d55c12ed
AS
18772012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1878
1879 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1880 (struct Lisp_Misc_Any): Likewise.
1881 (struct Lisp_Free): Likewise.
1882 * alloc.c (union aligned_Lisp_Symbol): Define.
1883 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1884 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1885 (union aligned_Lisp_Misc): Define.
1886 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1887 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1888 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1889
b948ce8b
PE
18902012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1893 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1894 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1895 * s/netbsd.h, s/sol2-6.h:
1896 Remove definition of GC_MARK_STACK, since the default now works.
1897 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1898 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1899 no longer the default.
1900 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1901
35dc09a1 19022012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1903
35dc09a1
GM
1904 * lread.c (lisp_file_lexically_bound_p):
1905 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1906
35dc09a1
GM
19072012-04-14 Eli Zaretskii <eliz@gnu.org>
1908
1909 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1910 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1911
19122012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1913
1914 * nsterm.m (constrainFrameRect): Always constrain when there is only
1915 one screen (Bug#10962).
1916
bcd86815
KB
19172012-04-13 Ken Brown <kbrown@cornell.edu>
1918
1919 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1920
c25df26e
RT
19212012-04-13 Reuben Thomas <rrt@sc3d.org>
1922
1923 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1924
0fc59f1e
DC
19252012-04-11 Daniel Colascione <dancol@dancol.org>
1926
1927 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1928 against is gone. It's better to use vfork now so that when Cygwin
1929 gains a new, working vfork, we use it automatically (bug#10398).
1930
de8c03dc
SM
19312012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1932
1933 * window.c (save_window_save): Obey window-point-insertion-type.
1934
2f097256
GM
19352012-04-11 Glenn Morris <rgm@gnu.org>
1936
1937 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1938
453b951e
SM
19392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1940
1941 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1942
75f1671a 19432012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1944
1945 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1946 (force_quit_count): New var.
1947 (handle_interrupt): Use it.
1948
2a8ce227
JB
19492012-04-10 Juanma Barranquero <lekktu@gmail.com>
1950
1951 * w32.c (w32_delayed_load): Record the full path of the library
1952 being loaded (bug#10424).
1953
935396c0
GM
19542012-04-09 Glenn Morris <rgm@gnu.org>
1955
05920a43
GM
1956 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1957 not just in the obarray, before snarfing them. (Bug#11036)
1958
935396c0
GM
1959 * Makefile.in ($(leimdir)/leim-list.el):
1960 Pass EMACS rather than BUILT_EMACS.
1961
a18ecafa
TZ
19622012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1963
1964 * process.c (make_process):
1965 * process.h: Add integer `gnutls_handshakes_tried' member to
1966 process struct.
1967
6bbef4e5
JC
1968 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1969 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1970
1971 * gnutls.c (gnutls_log_function2i): Convenience log function.
1972 (emacs_gnutls_read): Use new log functions,
1973 `gnutls_handshakes_tried' process member, and
1974 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1975 attempts per process (connection).
1976
b4d3bc10
CY
19772012-04-09 Chong Yidong <cyd@gnu.org>
1978
1979 * eval.c (Fuser_variable_p, user_variable_p_eh)
1980 (lisp_indirect_variable): Functions deleted.
1981 (Fdefvar): Caller changed.
1982
1983 * callint.c (Finteractive, Fcall_interactively):
1984 * minibuf.c (Fread_variable): Callers changed.
1985
70f4d973
EZ
19862012-04-09 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (set_cursor_from_row): If the display string appears in
1989 the buffer at position that is closer to point than the position
1990 after the display string, display the cursor on the first glyph of
1991 the display string. Fixes cursor display when a 'display' text
1992 property immediately follows invisible text. (Bug#11094)
1993
cb3c2e3e
PE
19942012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1995
1996 composite.c: use 'double' consistently
1997 * composite.c (get_composition_id): Use 'double' consistently
1998 instead of converting 'float' to 'double' and vice versa; this is
1999 easier to understand and avoids a GCC warning.
2000
fd06db5d
GM
20012012-04-09 Glenn Morris <rgm@gnu.org>
2002
50fe702a
GM
2003 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2004 preparation for dumping it with emacs. (Bug#4789)
2005 (leimdir): New variable.
2006 ($(leimdir)/leim-list.el): New rule.
2007 (emacs$(EXEEXT)): Depend on leim-list.el.
2008
fd06db5d
GM
2009 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2010 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2011 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2012
55c131ee
AS
20132012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2014
2015 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2016 proper alignment.
2017
9209588f
JB
20182012-04-07 Juanma Barranquero <lekktu@gmail.com>
2019
2020 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2021 Remove unused local variable.
2022
e3fb2efb
PE
20232012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2024
2025 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2026 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2027 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2028 objects, as mark_maybe_pointer will catch them otherwise.
2029 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2030 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2031
b5385551
PE
20322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 Fix typo that broke non-Windows builds.
2035 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2036
9078ead6
EZ
20372012-04-07 Eli Zaretskii <eliz@gnu.org>
2038
2039 Support building on MS-Windows with libxml2.
2040
2041 * makefile.w32-in (OBJ2): Add xml.$(O).
2042 (GLOBAL_SOURCES): Add xml.c.
2043 ($(BLD)/xml.$(O)): New dependency list.
2044
2045 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2046 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2047 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2048 [!WINDOWSNT]: New macros.
2049 (init_libxml2_functions, libxml2_loaded_p): New functions.
2050 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2051 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2052 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2053 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2054 linked in).
6bbef4e5
JC
2055 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2056 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2057 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2058
2059 * emacs.c: Don't include libxml/parser.h.
2060 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2061 xmlCleanupParser directly.
2062
2063 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2064
3811fdf3
EZ
20652012-04-07 Eli Zaretskii <eliz@gnu.org>
2066
2067 * indent.c (Fvertical_motion): If there is a display string at
2068 point, use it.vpos to compute how many lines to backtrack after
2069 move_it_to point. (Bug#11133)
2070
2f8e16b2
EZ
20712012-04-06 Eli Zaretskii <eliz@gnu.org>
2072
2073 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2074 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2075 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2076 macros related to unification of CJK characters. For the details,
2077 see the discussion following the message here:
2078 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2079
3d439cd1
CY
20802012-04-04 Chong Yidong <cyd@gnu.org>
2081
2082 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2083
8bc53d00
EZ
20842012-04-01 Eli Zaretskii <eliz@gnu.org>
2085
2086 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2087 instead of alloca. (Bug#11138)
2088
3b0512a3
AS
20892012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2090
2091 * w32menu.c (is_simple_dialog): Properly check lisp types.
2092 (Bug#11141)
2093
8427ddd2
EZ
20942012-03-31 Eli Zaretskii <eliz@gnu.org>
2095
979022ef
EZ
2096 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2097 position we get to after a call to move_it_to fails the
2098 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2099 only if we wind up in a string from display property. (Bug#11063)
2100
a6b1c7cc
EZ
2101 * window.c (Fdelete_other_windows_internal): Invalidate the row
2102 and column information about mouse highlight, so that redisplay
2103 restores it after reallocating the glyph matrices. (Bug#7464)
2104
8427ddd2
EZ
2105 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2106 string comes from a `display' text property, use the buffer
2107 position of that property as if we actually saw that position in
2108 the row's glyphs.
697ba24b
EZ
2109 (move_it_by_lines): Remove the assertion that
2110 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2111 violated when there's a before-string at the beginning of a line.
2112 (Bug#11063)
8427ddd2 2113
65a0a738
EZ
21142012-03-30 Eli Zaretskii <eliz@gnu.org>
2115
2116 * xdisp.c (append_space_for_newline): If the default face was
2117 remapped, use the remapped face for the appended newline.
2118 (extend_face_to_end_of_line): Use the remapped default face for
2119 extending the face to the end of the line.
2120 (display_line): Call extend_face_to_end_of_line when the default
2121 face was remapped. (Bug#11068)
2122
581355cc
EZ
21232012-03-29 Eli Zaretskii <eliz@gnu.org>
2124
2125 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2126
e8fc049f
SM
21272012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2128
2129 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2130
4fb9a543
GM
21312012-03-27 Glenn Morris <rgm@gnu.org>
2132
2133 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2134 Doc fixes.
2135
679910f1
KH
21362012-03-26 Kenichi Handa <handa@m17n.org>
2137
2138 * dispextern.h (struct glyph): Fix previous change. Change the
2139 bit length of glyphless.ch to 25 (Bug#11082).
2140
90d49b7f
CY
21412012-03-26 Chong Yidong <cyd@gnu.org>
2142
2143 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2144 (command_loop_1): Use it; inhibit selection update for
2145 handle-select-window too (Bug#8996).
2146
f514f6f0
FP
21472012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2148
e8fc049f 2149 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2150
bf43fa51
KH
21512012-03-25 Kenichi Handa <handa@m17n.org>
2152
2153 * dispextern.h (struct glyph): Change the bit length of
2154 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2155
8a0c01dd
EZ
21562012-03-24 Eli Zaretskii <eliz@gnu.org>
2157
2158 * s/ms-w32.h (tzname): Include time.h before redirecting to
2159 _tzname. Fixes the MSVC build. (Bug#9960)
2160
7d1c3a76
AS
21612012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2162
8ed79523
AS
2163 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2164 characters.
2165
7d1c3a76
AS
2166 * xterm.c (XTread_socket): Only modify handling_signal if
2167 !SYNC_INPUT. (Bug#11080)
2168
e99a9b8b
EZ
21692012-03-23 Eli Zaretskii <eliz@gnu.org>
2170
2171 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2172 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2173 when fetching a multibyte character consumes more bytes than
2174 CHAR_BYTES returns, due to unification of CJK characters in
2175 string_char. (Bug#11073)
2176
5063c0e1
TN
21772012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2178
2179 * process.c (wait_reading_process_output): Handle pty disconnect
2180 by refraining from sending oneself a SIGCHLD (bug#10933).
2181
9f851fbd
CY
21822012-03-22 Chong Yidong <cyd@gnu.org>
2183
2184 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2185
5063c0e1 2186 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2187 Mark string as coming from a prefix property.
2188 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2189 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2190
fb5b8aca
CY
21912012-03-21 Chong Yidong <cyd@gnu.org>
2192
2193 * xfaces.c (Vface_remapping_alist): Doc fix.
2194
62356a1b
EZ
21952012-03-20 Eli Zaretskii <eliz@gnu.org>
2196
2197 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2198 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2199 Doc fixes.
62356a1b 2200
025de85b
CY
22012012-03-20 Chong Yidong <cyd@gnu.org>
2202
2203 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2204 to reflect default non-nil value of redisplay-dont-pause.
2205
4827f94e
KH
22062012-03-19 Kenichi Handa <handa@m17n.org>
2207
2208 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2209 it fit in a valid range (Bug#11003).
2210
e50a24a2
EZ
22112012-03-18 Eli Zaretskii <eliz@gnu.org>
2212
2213 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2214 that is not from display property, accept the row as a "cursor
2215 row" if one of the string's character has a non-nil `cursor'
2216 property. Fixes cursor positioning when there are newlines in
2217 overlay strings, e.g. in icomplete.el. (Bug#11035)
2218
9af5ed87
PE
22192012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2222
d1f55f16
CY
22232012-03-12 Chong Yidong <cyd@gnu.org>
2224
2225 * eval.c (inhibit_lisp_code): Rename from
2226 inhibit_window_configuration_change_hook; move from window.c.
2227
2228 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2229 * window.c (run_window_configuration_change_hook)
2230 (syms_of_window): Callers changed.
2231
66c5eebd
CY
22322012-03-11 Chong Yidong <cyd@gnu.org>
2233
413df973
CY
2234 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2235
66c5eebd
CY
2236 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2237
1de11f56
CY
22382012-03-10 Chong Yidong <cyd@gnu.org>
2239
2240 * frame.c (other_visible_frames): Don't assume the selected frame
2241 is visible (Bug#10955).
2242
cae07000
SM
22432012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2244
2245 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2246
89c94350
JD
22472012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2248
2249 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2250 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2251 zero (Bug#10954).
2252
999dd333
GM
22532012-03-03 Glenn Morris <rgm@gnu.org>
2254
01a6dcc8 2255 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2256
de0100f2
EZ
22572012-03-02 Eli Zaretskii <eliz@gnu.org>
2258
2259 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2260 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2261 (redisplay_window, next_element_from_string): Fix typos in
2262 comments.
3e441275
EZ
2263 (redisplay_window): Pass to move_it_vertically the margin in
2264 pixels, not in screen lines.
de0100f2 2265
96a72ee9
GM
22662012-03-02 Glenn Morris <rgm@gnu.org>
2267
2268 * buffer.c (buffer-list-update-hook): Doc fix.
2269
312508d7
EZ
22702012-02-29 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2273 push_it before setting up the iterator for the first overlay
2274 string, even if we have an empty string loaded.
2275 (next_overlay_string): If there's an empty string on the iterator
2276 stack, pop the stack. (Bug#10903)
2277
27f3c637
PE
22782012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2281 Suggested by Stefan Monnier in
2282 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2283 * alloc.c (widen_to_Lisp_Object): New static function.
2284 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2285 and widening them to Lisp_Objects. This would work even if
2286 USE_LSB_TAG is defined and wide integers are used, which might
2287 happen in a future version of Emacs.
2288
3c9dfce6
CY
22892012-02-25 Chong Yidong <cyd@gnu.org>
2290
fa74b241
CY
2291 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2292 Doc fix.
2293
3c9dfce6
CY
2294 * xselect.c (Fx_selection_exists_p): Doc fix.
2295 (x_clipboard_manager_save_all): Print an informative message
2296 before saving to clipboard manager.
2297
9486df08
CY
22982012-02-24 Chong Yidong <cyd@gnu.org>
2299
2300 * keyboard.c (process_special_events): Handle all X selection
2301 requests in kbd_buffer, not just the next one (Bug#8869).
2302
f01d3321
CY
23032012-02-23 Chong Yidong <cyd@gnu.org>
2304
2305 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2306 call when setting menu-bar-lines and tool-bar-lines parameters.
2307 (unwind_create_frame_1): New helper function.
2308
2309 * window.c (inhibit_window_configuration_change_hook): New var.
2310 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2311 (syms_of_window): Initialize it.
f01d3321 2312
86b847b6
CY
23132012-02-22 Chong Yidong <cyd@gnu.org>
2314
2315 * xterm.c (x_draw_image_relief): Add missing type check for
2316 Vtool_bar_button_margin (Bug#10743).
2317
a59225b1
CY
23182012-02-21 Chong Yidong <cyd@gnu.org>
2319
2320 * fileio.c (Vfile_name_handler_alist): Doc fix.
2321
2322 * buffer.c (Fget_file_buffer): Protect against invalid file
2323 handler return value.
2324
310f5bd4
PE
23252012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2326
cb3a28cc
PE
2327 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2328 when computing $valmask.
2329
310f5bd4
PE
2330 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2331 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2332 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2333 It's useless in that case, and it can cause problems on hosts
2334 that allocate halves of EMACS_INT values separately.
2335 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2336 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2337 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2338 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2339 it avoids undefined behavior on hosts where shifting right by more
2340 than the word width has undefined behavior.
2341
2375c96a
CY
23422012-02-19 Chong Yidong <cyd@gnu.org>
2343
2344 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2345 (Funhandled_file_name_directory, Ffile_name_as_directory)
2346 (Fdirectory_file_name, Fexpand_file_name)
2347 (Fsubstitute_in_file_name): Protect against invalid file handler
2348 return values (Bug#10845).
2349
3eb49e71
EZ
23502012-02-18 Eli Zaretskii <eliz@gnu.org>
2351
2352 * .gdbinit (pitx): Fix incorrect references to fields of the
2353 iterator stack.
2354
7b926f3f
CY
23552012-02-17 Chong Yidong <cyd@gnu.org>
2356
2357 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2358
11273115
PE
23592012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2360
2361 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2362 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2363
c3a70e2b
CY
23642012-02-15 Chong Yidong <cyd@gnu.org>
2365
2366 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2367 marked as special. Also, starting docstrings with * is obsolete.
2368
0ca43699
AS
23692012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2370
2371 * gnutls.c (emacs_gnutls_write): Fix last change.
2372
2e8f3c56
LI
23732012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2374
2375 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2376 send_process.
2377
af70074f
SM
23782012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2379
2380 * keymap.c (Fsingle_key_description): Handle char ranges.
2381
95986d52
CY
23822012-02-12 Chong Yidong <cyd@gnu.org>
2383
afd83bd1
CY
2384 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2385 as that creates a dangerous corner case.
2386
95986d52
CY
2387 * window.c (Fdelete_window_internal): Invalidate the mouse
2388 highlight (Bug#9904).
2389
bd7da63e
GM
23902012-02-12 Glenn Morris <rgm@gnu.org>
2391
2392 * xselect.c (Fx_own_selection_internal)
2393 (Fx_get_selection_internal, Fx_disown_selection_internal)
2394 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2395 * nsselect.m (Fx_own_selection_internal)
2396 (Fx_disown_selection_internal, Fx_selection_exists_p)
2397 (Fx_selection_owner_p, Fx_get_selection_internal):
2398 Sync docs and argument specs with the xselect.c versions.
2399
77abcbc2
LI
24002012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2401
2402 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2403
90b671e2
EZ
24042012-02-11 Eli Zaretskii <eliz@gnu.org>
2405
1c0ca0b7
EZ
2406 * w32select.c (Fx_selection_exists_p): Sync doc string and
2407 argument list with xselect.c. (Bug#10783)
2408
2409 * w16select.c (Fx_selection_exists_p): Sync doc string and
2410 argument list with xselect.c. (Bug#10783)
90b671e2 2411
49241268
GM
24122012-02-10 Glenn Morris <rgm@gnu.org>
2413
2414 * fns.c (Fsecure_hash): Doc fix.
2415
f998bbe7 24162012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2417
2418 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2419
0992bd9c
CY
24202012-02-07 Chong Yidong <cyd@gnu.org>
2421
2422 * buffer.c (Fbuffer_local_variables)
2423 (buffer_lisp_local_variables): Handle unbound vars correctly;
2424 don't let Qunbound leak into Lisp.
2425
af008560
GM
24262012-02-07 Glenn Morris <rgm@gnu.org>
2427
dd605cc4
GM
2428 * image.c (Fimagemagick_types): Doc fix.
2429
af008560
GM
2430 * image.c (imagemagick-render-type): Change it from a lisp object
2431 to an integer. Move the doc here from the lisp manual.
2432 Treat all values not equal to 0 the same.
2433
1449fa1d
CY
24342012-02-06 Chong Yidong <cyd@gnu.org>
2435
2436 * doc.c (store_function_docstring): Avoid applying docstring of
2437 alias to base function (Bug#2603).
2438
3723ec07
AS
24392012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2440
2441 * .gdbinit (pp1, pv1): Remove redundant defines.
2442 (pr): Use pp.
2443
79c1cc1e
CY
24442012-02-04 Chong Yidong <cyd@gnu.org>
2445
2446 * nsterm.m: Declare a global (Bug#10694).
2447
d7f29f8e
EZ
24482012-02-04 Eli Zaretskii <eliz@gnu.org>
2449
cae07000
SM
2450 * w32.c (get_emacs_configuration_options):
2451 Include --enable-checking, if specified, in the return value.
d7f29f8e 2452
3b95a6f9
MR
24532012-02-04 Martin Rudalics <rudalics@gmx.at>
2454
2455 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2456 after rounding frame sizes. (Bug#9723)
2457
d6fa96a6
EZ
24582012-02-04 Eli Zaretskii <eliz@gnu.org>
2459
2460 * keyboard.c (adjust_point_for_property): Don't position point
2461 before BEGV. (Bug#10696)
2462
df0b2940
PE
24632012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 Handle overflow when computing char display width (Bug#9496).
2466 * character.c (char_width): Return EMACS_INT, not int.
2467 (char_width, c_string_width): Check for overflow when
2468 computing the width; this is possible now that individual
2469 characters can have unbounded width. Problem introduced
2470 by merge from Emacs 23 on 2012-01-19.
2471
6bee44d6
MA
24722012-02-02 Michael Albinus <michael.albinus@gmx.de>
2473
2474 * dbusbind.c (Fdbus_register_method): Mention the return value
2475 :ignore in the docstring.
2476
44f92739
GM
24772012-02-02 Glenn Morris <rgm@gnu.org>
2478
1b9f60cc
GM
2479 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2480
44f92739
GM
2481 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2482 Unconditionally set to t. (Bug#10673)
2483 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2484 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2485 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2486
c5d3843c
KH
24872012-02-02 Kenichi Handa <handa@m17n.org>
2488
2489 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2490 0, do not call append_composite_glyph.
2491
159462d4 24922012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2493
2494 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2495 NULL (Bug#6988).
2496 (x_produce_glyphs): If the component of a composition is a null
2497 string, set it->pixel_width to 1 to avoid zero-width glyph.
2498
78cef877
EZ
24992012-02-01 Eli Zaretskii <eliz@gnu.org>
2500
2501 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2502 first 2 arguments are identical. This makes inserting large
2503 output from a subprocess an order of magnitude faster on
2504 MS-Windows, where all sbrk'ed memory is always contiguous.
2505
97897668
GM
25062012-01-31 Glenn Morris <rgm@gnu.org>
2507
2508 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2509 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2510 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2511
31fd3586
GM
25122012-01-29 Glenn Morris <rgm@gnu.org>
2513
2514 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2515
0e24a8b2
CY
25162012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2517
2518 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2519
cc0adcb0
CY
25202012-01-28 Chong Yidong <cyd@gnu.org>
2521
2522 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2523
acc28cb9
CY
25242012-01-26 Chong Yidong <cyd@gnu.org>
2525
9c69cfb7
CY
2526 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2527
acc28cb9
CY
2528 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2529 repeat counts (Bug#10507).
2530
48da7392
GM
25312012-01-26 Glenn Morris <rgm@gnu.org>
2532
2533 * lread.c (syms_of_lread): Doc fix.
2534
14af5f7f
CY
25352012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2536
2537 * coding.c (encode_designation_at_bol): Change return value to
2538 EMACS_INT.
2539
0b21c100
CY
25402012-01-25 Chong Yidong <cyd@gnu.org>
2541
2542 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2543
3c2907f7
CY
25442012-01-21 Chong Yidong <cyd@gnu.org>
2545
2546 * floatfns.c (Fcopysign): Make the second argument non-optional,
2547 since nil is not allowed anyway.
2548
959ad23f
AS
25492012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2550
2551 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2552 (send_process): Likewise.
2553
34a02f46
MR
25542012-01-19 Martin Rudalics <rudalics@gmx.at>
2555
2556 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2557 (Vwindow_persistent_parameters): Do not use Qstate.
2558 Rewrite doc-strings.
34a02f46 2559
1259009a 25602012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2561
2562 * character.c (char_width): New function.
70d4fdf6
GM
2563 (Fchar_width, c_string_width, lisp_string_width):
2564 Use char_width (Bug#9496).
25ed9e61 2565
6a6ee00d
MR
25662012-01-16 Martin Rudalics <rudalics@gmx.at>
2567
2568 * window.c (Vwindow_persistent_parameters): New variable.
2569 (Fset_window_configuration, save_window_save): Handle persistent
2570 window parameters.
2571
c85efaf7
EZ
25722012-01-14 Eli Zaretskii <eliz@gnu.org>
2573
2574 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2575 thrashing the stack of the thread. (Bug#9087)
2576
5944709e
PE
25772012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2580
e71f5d99
EZ
25812012-01-11 Eli Zaretskii <eliz@gnu.org>
2582
2583 * xdisp.c (rows_from_pos_range): Handle the case where the
2584 highlight ends on a newline. (Bug#10464)
2585 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2586 he end column for display of highlight that ends on a newline
2587 before a R2L line.
2588
ce316182
GM
25892012-01-11 Glenn Morris <rgm@gnu.org>
2590
2591 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2592 from load-path also when installation-directory is nil. (Bug#10208)
2593
5b43da69
GM
25942012-01-10 Glenn Morris <rgm@gnu.org>
2595
74cc8ff9
GM
2596 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2597
7d8d6e4e
GM
2598 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2599 Update template values to be closer to their typical values these days.
5b43da69 2600
a0db8d43
EZ
26012012-01-09 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (rows_from_pos_range): Accept additional argument
2604 DISP_STRING, and accept any glyph in a row whose object is that
2605 string as eligible for mouse highlight. Fixes mouse highlight of
2606 display strings from overlays. (Bug#10464)
2607
9a0115ab 26082012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2609
b9110d6a 2610 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2611 * fileio.c (auto_saving_dir_umask): New static var.
2612 (Fmake_directory_internal): Use it.
2613 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2614 creating the directory. The old code temporarily assigns
2615 too-generous permissions to the directory.
2616 (do_auto_save_eh): Clear it.
b9110d6a 2617 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2618 that the var is always cleared.
2619
6c1bd3f3
EZ
26202012-01-07 Eli Zaretskii <eliz@gnu.org>
2621
2622 * search.c (scan_buffer): Pass character positions to
2623 know_region_cache, not byte positions. (Bug#6540)
2624
069d2b50
L
26252012-01-07 LynX <_LynX@bk.ru> (tiny change)
2626
2627 * w32.c (sys_rename): Report EXDEV when rename of a directory
2628 fails because the target is on another logical disk. (Bug#10284)
2629
75bf0d33
DB
26302012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2631
2632 * xterm.c (x_embed_request_focus): New function.
2633
2634 * xterm.h: Add prototype.
2635
2636 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2637
1c6e5a32
GM
26382012-01-05 Glenn Morris <rgm@gnu.org>
2639
2640 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2641
651e947e
EZ
26422012-01-01 Eli Zaretskii <eliz@gnu.org>
2643
2644 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2645 Load gnutls_transport_set_lowat only if GnuTLS version is below
2646 2.11.1.
2647 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2648 GnuTLS versions below 2.11.1.
2649
3778cdd8
AL
26502011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2651
2652 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2653 to the doc string advising against its use for altering the way
2654 windows are scrolled.
2655
0e5317f7
KH
26562011-12-28 Kenichi Handa <handa@m17n.org>
2657
2658 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2659 coding-system ASCII compatible only when it does not produce BOM
2660 on encoding (Bug#10383).
2661
93d5ca1f
JD
26622011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2663
2664 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2665 can scroll.
2666 (create_and_show_popup_menu): Always use menu_position_func for
2667 Gtk3 (Bug#10361).
2668
ca22b785
AS
26692011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2670
2671 * callint.c (Fcall_interactively): Don't truncate prompt string.
2672
d048e1e6
EZ
26732011-12-23 Eli Zaretskii <eliz@gnu.org>
2674
2675 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2676 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2677 resumed from there (after widening). (Bug#10360)
d048e1e6 2678
5ccaba1f
JD
26792011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2680
2681 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2682
204ee57f
JD
26832011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2684
b81d40f0
JB
2685 * nsterm.m (x_free_frame_resources):
2686 Release f->output_data.ns->miniimage.
204ee57f
JD
2687 (ns_index_color): Fix indentation. Do not retain
2688 color_table->colors[i].
2689
2690 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2691 before returning.
2692
2693 * nsfns.m (x_set_background_color): Assign return value from
2694 ns_index_color to face-background instead of NSColor*.
2695 (ns_implicitly_set_icon_type): Fix indentation.
2696 Change assignment in for loop to comparison.
2697
2698 * emacs.c (ns_pool): New variable.
2699 (main): Assign ns_pool.
2700 (Fkill_emacs): Call ns_release_autorelease_pool.
2701
2702 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2703 autorelease fdesc, release fdAttrs and tdict.
2704 (ns_get_covering_families): Release charset.
2705 (ns_findfonts): Release NSFontDescriptor created with new.
2706 (ns_uni_to_glyphs): Fix indentation.
2707 (setString): Release attrStr before assigning new value.
2708
c803b2b7
JD
27092011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2710
678f4426
JD
2711 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2712 and NS_IMPL_COCOA.
2713 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2714 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2715
cd394be1 27162011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2717
5fecd5fc
JD
2718 * nsterm.m (ns_term_init): Subscribe for notifications
2719 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2720 to method trackingNotification in EmacsMenu.
2721
2722 * nsmenu.m (trackingMenu): New variable.
3771cb17 2723 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2724 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2725 from Aquamacs (Bug#7030).
678f4426
JD
2726
27272011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2728
c803b2b7
JD
2729 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2730 (symbol_to_nsstring): Fix indentation.
2731 (ns_symbol_to_pb): New function.
cae07000
SM
2732 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2733 (Fns_rotate_cut_buffers_internal): Remove.
2734 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2735 Fns_store_cut_buffer_internal.
2736 (ns_get_foreign_selection, Fx_own_selection_internal)
2737 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2738 (Fns_get_selection_internal, Fns_store_selection_internal):
2739 Use ns_symbol_to_pb and check if return value is nil.
2740 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2741 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2742 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2743 renamed to Sns_store_selection_internal.
2744 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2745 and remove this function.
2746 (ns_handle_selection_clear): Remove, never used.
2747 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2748 here.
2749
e1b01a3a
KB
27502011-12-17 Ken Brown <kbrown@cornell.edu>
2751
2752 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2753 GID is unknown (Bug#10257).
2754
2adb6e85
PE
27552011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2758 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2759 which caused a build failure on GNU/Linux IA-64. This problem was
2760 introduced by my 2011-10-07 patch.
2761
d1d7b339
JL
27622011-12-15 Juri Linkov <juri@jurta.org>
2763
2764 * image.c (imagemagick_error): New function. (Bug#10112)
2765 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2766 Use `imagemagick_error' where ImageMagick functions return
2767 `MagickFalse'.
2768 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2769 proper order.
2770
100d5755
KH
27712011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2772
2773 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2774 fill background (Bug#8992).
2775
454592a6
MR
27762011-12-13 Martin Rudalics <rudalics@gmx.at>
2777
2778 * window.c (Vwindow_combination_resize)
2779 (Vwindow_combination_limit): Use t instead of non-nil in
2780 doc-strings.
61d4b438
MR
2781 (Vrecenter_redisplay): Add first sentence of doc-string on
2782 separate line.
53524d93 2783 (Frecenter): Fix doc-string typo.
454592a6 2784
3633e3aa
KH
27852011-12-11 Kenichi Handa <handa@m17n.org>
2786
2787 * coding.c (Funencodable_char_position): Pay attention to the
2788 buffer text relocation (Bug#9389).
2789
7b9d523a 27902011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2791
7b9d523a
JD
2792 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2793 gtk_init (Bug#10100).
2794
b73189c6
EZ
27952011-12-10 Eli Zaretskii <eliz@gnu.org>
2796
2797 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2798 IT->string is nil. (Bug#10263)
2799
f7dfe5d6
JD
28002011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2801
83faebb4
JD
2802 * nsterm.h (x_free_frame_resources): Declare.
2803
f7dfe5d6
JD
2804 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2805 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2806
2807 * nsterm.h (ns_get_defaults_value): Declare.
2808
2809 * nsterm.m (ns_default): Call ns_get_defaults_value.
2810
7cd4e72c
EZ
28112011-12-09 Eli Zaretskii <eliz@gnu.org>
2812
2813 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2814 (Bug#10170)
2815
b34d7317
YM
28162011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2817
2818 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2819 that where the value of an _OBJC_* symbol points to is in the .bss
2820 section (Bug#10240).
2821
76470ad1
KH
28222011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2823
2824 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2825 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2826
745fff94
KH
28272011-12-08 Kenichi Handa <handa@m17n.org>
2828
2829 * ftfont.c (get_adstyle_property): Fix previous change
2830 (Bug#10233).
2831
6e44397c
JB
28322011-12-07 Juanma Barranquero <lekktu@gmail.com>
2833
2834 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2835 dirs from the default value of EMACSLOADPATH (bug#10208).
2836
7efa6272
GM
28372011-12-07 Glenn Morris <rgm@gnu.org>
2838
2839 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2840 installation and source directories as well. (Bug#10208)
2841
f6fc4d87
CY
28422011-12-06 Chong Yidong <cyd@gnu.org>
2843
2844 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2845
2bf26180
GM
28462011-12-06 Glenn Morris <rgm@gnu.org>
2847
2848 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2849 as an error, not just -1. (Bug#10217)
2850
3a6ad4f0
CY
28512011-12-05 Chong Yidong <cyd@gnu.org>
2852
2853 * keyboard.c (process_special_events): New function.
2854 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2855
75a3b399
PE
28562011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 * coding.c (encode_designation_at_bol): Don't use uninitialized
2859 local variable (Bug#9318).
2860
c3c9e25e
KH
28612011-12-05 Kenichi Handa <handa@m17n.org>
2862
2863 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2864 return Qnil (Bug#8046, Bug#10193).
2865
5eb05ea3
KH
28662011-12-05 Kenichi Handa <handa@m17n.org>
2867
2868 * coding.c (encode_designation_at_bol): New args charbuf_end and
2869 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2870 (coding_set_source): Return how many bytes coding->source was
2871 relocated.
2872 (coding_set_destination): Return how many bytes
2873 coding->destination was relocated.
2874 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2875 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2876
28772011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2878
2879 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2880 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2881 macro (Bug#9318).
2882
28832011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2884
2885 The following changes are to fix Bug#9318.
2886
a79703f5 2887 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2888 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2889 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2890 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2891
7dbda6df
JB
28922011-12-05 Juanma Barranquero <lekktu@gmail.com>
2893
2894 * lisp.h (process_quit_flag): Fix external declaration.
2895
6d5eb5b0
SM
28962011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2897
2898 Don't macro-inline non-performance-critical code.
2899 * eval.c (process_quit_flag): New function.
2900 * lisp.h (QUIT): Use it.
2901
a0c3fad0
JD
29022011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2903
2904 * nsfns.m (get_geometry_from_preferences): New function.
2905 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2906
6c07aac2
AS
29072011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2908
2909 * emacs.c (Qkill_emacs): Define.
2910 (syms_of_emacs): Initialize it.
2911 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2912 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2913 (quit_throw_to_read_char): Add parameter `from_signal'.
2914 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2915 * lisp.h (QUIT): Call Fkill_emacs if requested.
2916
c052ead4
JD
29172011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2918
2919 * widget.c (update_wm_hints): Return if wmshell is null.
2920 (widget_update_wm_size_hints): New function.
2921
2922 * widget.h (widget_update_wm_size_hints): Declare.
2923
2924 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2925 widget_update_wm_size_hints (Bug#10104).
2926
9e49252b
EZ
29272011-12-03 Eli Zaretskii <eliz@gnu.org>
2928
2929 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2930 before a newline, prepare the bidi iterator for consuming the
2931 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2932 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2933
02b16839
JL
29342011-12-02 Juri Linkov <juri@jurta.org>
2935
2936 * search.c (Fword_search_regexp): New Lisp function created from
2937 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2938 (Fword_search_backward, Fword_search_forward)
2939 (Fword_search_backward_lax, Fword_search_forward_lax):
2940 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2941 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2942
0068070e
SM
29432011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2944
2945 * fileio.c (Finsert_file_contents): Move after-change-function call
2946 to before the "handled:" label, since all "goto handled" appear in
2947 cases where the *-change-functions have already been properly called
2948 (bug#10117).
2949
3360a3fc
AS
29502011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2951
2952 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2953 waiting for input. (Bug#10169)
2954
73d6c093
EZ
29552011-11-30 Eli Zaretskii <eliz@gnu.org>
2956
2957 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2958 verifies glyph row's hash code--we have just reallocated the
2959 glyphs, so their contents can be complete garbage. (Bug#10164)
2960
febe6bea
JB
29612011-11-30 Juanma Barranquero <lekktu@gmail.com>
2962
2963 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2964
801a4313
EZ
29652011-11-30 Eli Zaretskii <eliz@gnu.org>
2966
2967 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2968 attributes are tested _before_ calling verify_row_hash, to protect
2969 against GCC re-ordering of the tests. (Bug#10164)
2970
2b56b87e
JD
29712011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2972
2973 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2974
2975 * xterm.c (handle_one_xevent): Only set async_visible and friends
2976 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2977 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2978 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2979
dbf31225
PE
29802011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2983 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2984 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2985 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2986 All uses changed to use GCPRO1 etc.
2987 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2988 Revert to old implementation (i.e., before 2011-03-11).
2989
1305621b
YM
29902011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2991
2992 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2993 of scroll runs so as to avoid assigning disabled bogus rows and
2994 unnecessary graphics copy operations.
2995
8c9afb46
EZ
29962011-11-27 Eli Zaretskii <eliz@gnu.org>
2997
2998 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2999 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3000 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3001 (malloc, free, realloc, calloc): Redirect to e_* only when
3002 compiling Emacs.
3003
3004 * lisp.h (GCTYPEBITS): Move before first use.
3005 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3006 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3007 this macro definition.
3008
3009 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3010 _MSC_VER.
3011
54e9e3bf
JD
30122011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3013
6d5eb5b0
SM
3014 * gtkutil.c (xg_create_frame_widgets):
3015 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3016 present with Gtk+ 2.0.
3017
83aca1cb
PE
30182011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * fileio.c (Finsert_file_contents): Undo previous change; see
3021 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3022
5b76caa4
PE
30232011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 Rename locals to avoid shadowing.
3026 * fileio.c (Finsert_file_contents):
3027 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3028 * process.c (wait_reading_process_output):
3029 Rename inner 'proc' to 'p' to avoid shadowing.
3030 Indent for consistency with usual Emacs style.
3031
8c535114
EZ
30322011-11-25 Eli Zaretskii <eliz@gnu.org>
3033
3034 * xdisp.c (redisplay_window): If cursor row is not fully visible
3035 after recentering, and scroll-conservatively is set to a large
3036 number, scroll window by a few more lines to make the cursor fully
3037 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3038 (start_display): Don't move to the next line if the display should
3039 start at a newline that is part of a display vector or an overlay
3040 string. (Bug#10119)
8c535114 3041
fa4fdb5c
JL
30422011-11-24 Juri Linkov <juri@jurta.org>
3043
3044 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3045 after the `MagickPingImage' call. (Bug#10112)
3046
90ec88df
CY
30472011-11-23 Chong Yidong <cyd@gnu.org>
3048
3049 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3050
56e2e794
MR
30512011-11-23 Martin Rudalics <rudalics@gmx.at>
3052
3053 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3054 making another buffer current. (Bug#10114)
3055
b6e64c41
GM
30562011-11-23 Glenn Morris <rgm@gnu.org>
3057
3058 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3059
6b21de18
CY
30602011-11-23 Chong Yidong <cyd@gnu.org>
3061
3062 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3063 using it (Bug#5984).
3064
b12cd789
EZ
30652011-11-22 Eli Zaretskii <eliz@gnu.org>
3066
3067 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3068 and header-lines, as they don't have one computed for them.
3069 (Bug#10098)
3070
3071 * .gdbinit (prow): Make displayed values more self-explaining.
3072 Add row's hash code.
3073
261b6fd4
LMI
30742011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3075
3076 * process.c (wait_reading_process_output): Fix asynchrounous
3077 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3078 (wait_reading_process_output): Add comment and URL.
261b6fd4 3079
e7cfd277
JD
30802011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3081
3082 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3083
a9b9b7f5
CY
30842011-11-21 Chong Yidong <cyd@gnu.org>
3085
3086 * window.c (Fnext_window, Fprevious_window): Doc fix.
3087
b0d15b4f
SM
30882011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3089
3090 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3091
fe7a3057
JB
30922011-11-20 Juanma Barranquero <lekktu@gmail.com>
3093
3094 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3095
d2999b1a
MR
30962011-11-20 Martin Rudalics <rudalics@gmx.at>
3097
3098 * window.c (Fset_window_combination_limit): Rename argument
3099 STATUS to LIMIT.
3100 (Vwindow_combination_limit): Remove "status" from doc-string.
3101
d5ff9cd0
AS
31022011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3103
3104 * m/ibms390.h: Remove.
3105 * m/ibms390x.h: Don't include "ibms390.h".
3106
a5bb9bd3
SM
31072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3108
3109 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3110 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3111
cd1181db
JB
31122011-11-20 Juanma Barranquero <lekktu@gmail.com>
3113
3114 * casetab.c (Fset_case_table):
3115 * charset.c (Fcharset_after): Fix typos.
3116
615a3b8d 31172011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3118
17e845af
PE
3119 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3120 Otherwise, valgrind does not work on some platforms.
3121 Problem reported by Andreas Schwab in
6a0bf43d
PE
3122 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3123 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3124 is set, removing the need for VIRT_ADDRESS_VARIES.
3125 (PURE_P): Use a more-efficient implementation that needs just one
3126 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3127 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3128 to 4 (xorl, subq, cmpq, setbe).
3129 * alloc.c (pure): Always extern now, since that's the
3130 VIRT_ADDR_VARIES behavior.
3131 (PURE_POINTER_P): Use a single comparison, not two, for
3132 consistency with the new puresize.h.
3133 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3134 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3135 Remove VIRT_ADDR_VARIES no longer needed.
3136
f8fe6f96
EZ
31372011-11-19 Eli Zaretskii <eliz@gnu.org>
3138
3139 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3140 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3141 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3142 behave as if the cursor position were at the window margin.
3143
3144 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3145 and the cursor position is out of bounds, behave as if the cursor
3146 position were at the window margin. (Bug#10075)
3147
df05a53c
CY
31482011-11-18 Chong Yidong <cyd@gnu.org>
3149
3150 * window.c (Fwindow_combination_limit): Make first argument
3151 non-optional, since it is meaningless for live windows like the
3152 selected window.
61ccba97 3153
2071918e
DA
31542011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3155
3156 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3157
b50a28de
SM
31582011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3159
3160 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3161 (graft_intervals_into_buffer): Simplify.
3162
015137db
EZ
31632011-11-18 Eli Zaretskii <eliz@gnu.org>
3164
3165 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3166 hash values of the two rows.
3167 (copy_row_except_pointers): Preserve the used[] arrays and the
3168 hash values of the two rows. (Bug#10035)
68c95424 3169 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3170
3171 * xdisp.c (row_hash): New function, body extracted from
3172 compute_line_metrics.
3173 (compute_line_metrics): Call row_hash, instead of computing the
3174 hash code inline.
3175
3176 * dispnew.c (verify_row_hash): Call row_hash for computing the
3177 hash code of a row, instead of duplicating code from xdisp.c.
3178
3179 * dispextern.h (row_hash): Add prototype.
3180
a2addb04
TH
31812011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3182
3183 * frame.c (delete_frame): Don't delete the terminal when the last
3184 X frame is closed if emacs is built with GTK toolkit.
3185
df85d315
JB
31862011-11-17 Juanma Barranquero <lekktu@gmail.com>
3187
3188 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3189
a0c2d0ae
MR
31902011-11-17 Martin Rudalics <rudalics@gmx.at>
3191
3192 * window.c (Vwindow_splits): Rename to
3193 Vwindow_combination_resize. Suggested by Juri Linkov.
3194 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3195 of Vwindow_splits.
3196
58179cce
JB
31972011-11-16 Juanma Barranquero <lekktu@gmail.com>
3198
7877f373
JB
3199 * nsfns.m (Fns_font_name):
3200 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3201
b6f67890
MR
32022011-11-16 Martin Rudalics <rudalics@gmx.at>
3203
3204 * window.h (window): Rename slot "nest" to "combination_limit".
3205 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3206 (Fset_window_nest): Rename to Fset_window_combination_limit.
3207 (Vwindow_nest): Rename to Vwindow_combination_limit.
3208 (recombine_windows, make_parent_window, make_window)
3209 (Fsplit_window_internal, saved_window)
3210 (Fset_window_configuration, save_window_save): Rename all
3211 occurrences of window_nest to window_combination_limit.
3212
c7015153
JB
32132011-11-15 Juanma Barranquero <lekktu@gmail.com>
3214
3215 * image.c (imagemagick_load_image): Fix typo.
3216
322ad6ec
EZ
32172011-11-14 Eli Zaretskii <eliz@gnu.org>
3218
3219 * xdisp.c (display_line): Move the call to
3220 highlight_trailing_whitespace before the call to
3221 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3222 faces of all the glyphs to compute ROW's hash value.
3223 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3224
f067b8ec
JB
32252011-11-14 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3228 just return (bug#10044).
3229
1e5b2111
EZ
32302011-11-12 Eli Zaretskii <eliz@gnu.org>
3231
7ef3cbd5
EZ
3232 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3233 with user-defined heap size. Bump the default size of the temacs
3234 heap to 27MB, to avoid memory warning when running temacs.
3235 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3236
1e5b2111
EZ
3237 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3238 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3239 (verify_row_hash) [XASSERTS]: New function.
3240 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3241 that the hash value of glyph rows is correct.
1e5b2111 3242
89d61221
MR
32432011-11-12 Martin Rudalics <rudalics@gmx.at>
3244
3245 * window.h (window): Remove splits slot.
3246 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3247 (Fdelete_other_windows_internal, make_parent_window)
3248 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3249 (Fset_window_configuration, save_window_save): Don't deal with
3250 split status of windows.
3251 (saved_window): Remove splits slot.
3252 (Vwindow_splits): Rewrite doc-string.
3253
97f18cc8
JD
32542011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3255
3256 * xfns.c (unwind_create_frame):
3257 * nsfns.m (unwind_create_frame):
3258 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3259 Vframe_list (Bug#9999).
3260
22a648b4
DA
32612011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3262
0b381c7e 3263 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3264
659afede
KH
32652011-11-11 Kenichi Handa <handa@m17n.org>
3266
3267 * callproc.c (Fcall_process): Set the member dst_multibyte of
3268 process_coding.
3269
9ac0394b
KH
32702011-11-11 Johan Bockgård <bojohan@gnu.org>
3271
3272 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3273 avoid a crash (bug#9496).
3274
2fbdc249
CY
32752011-11-09 Chong Yidong <cyd@gnu.org>
3276
3277 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3278 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3279
ac6b1f81
PE
32802011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3281
3282 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3283
09db192c
PE
32842011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3285
3286 Avoid some portability problems by eschewing 'extern inline' functions.
3287 The trivial performance wins aren't worth the portability hassles; see
3288 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3289 et seq.
3290 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3291 (window_box_width, window_box_left, window_box_left_offset)
3292 (window_box_right, window_box_right_offset): Undo previous change,
3293 by removing the "extern"s.
3294 * intervals.c (adjust_intervals_for_insertion)
3295 (adjust_intervals_for_deletion): Undo previous change,
3296 making these static again.
3297 (offset_intervals, temp_set_point_both, temp_set_point)
3298 (copy_intervals_to_string): No longer inline.
3299 * xdisp.c (window_text_bottom_y, window_box_width)
3300 (window_box_height, window_box_left_offset)
3301 (window_box_right_offset, window_box_left, window_box_right)
3302 (window_box): No longer inline.
3303
105216ed
CY
33042011-11-08 Chong Yidong <cyd@gnu.org>
3305
3306 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3307 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3308 Signal an error if not a live window.
105216ed
CY
3309 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3310 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3311
ae9e237f
JB
33122011-11-07 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * lisp.h (syms_of_abbrev): Remove declaration.
3315 Reported by CHENG Gao <chenggao@royau.me>.
3316
c7aa8333
EZ
33172011-11-07 Eli Zaretskii <eliz@gnu.org>
3318
3319 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3320 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3321 of temacs in GUI mode.
3322
be7f5545
MR
33232011-11-07 Martin Rudalics <rudalics@gmx.at>
3324
3325 * window.h: Declare delete_all_child_windows instead of
3326 delete_all_subwindows.
3327 * window.c (Fwindow_nest, Fset_window_nest)
3328 (Fset_window_new_total, Fset_window_new_normal)
3329 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3330 (delete_all_subwindows): Rename to delete_all_child_windows.
3331 (Fdelete_other_windows_internal, Fset_window_configuration):
3332 Call delete_all_child_windows instead of delete_all_subwindows.
3333 * frame.c (delete_frame): Call delete_all_child_windows instead
3334 of delete_all_subwindows.
3335
ca78dc43
PE
33362011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3337
3338 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3339 This is also needed for porting to any host where GC_MARK_STACK is
3340 not GC_MAKE_GCPROS_NOOPS.
3341 (which_symbols): Use it.
3342
a0241d01
KH
33432011-11-07 Kenichi Handa <handa@m17n.org>
3344
3345 * coding.c (coding_set_destination): Check coding->src_pos only
3346 when coding->src_object is a buffer (bug#9910).
3347
3348 * process.c (send_process): Set the member src_multibyte of coding
3349 to 0 (bug#9911) when sending a unibyte text.
3350
3351 * callproc.c (Fcall_process): Set the member src_multibyte of
3352 process_coding to 0 (bug#9912).
3353
a64bfdfa 33542011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3355
3356 * xmenu.c (cleanup_widget_value_tree): New function.
3357 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3358 calling free_menubar_widget_value_tree directly (Bug#9830).
3359
cb41b32a
PE
33602011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 Fix some portability problems with 'inline'.
3363 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3364 (window_box_width, window_box_left, window_box_left_offset)
3365 (window_box_right, window_box_right_offset): Declare extern.
3366 Otherwise, these inline functions do not conform to C99 and
3367 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3368 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3369 * intervals.c (adjust_intervals_for_insertion)
3370 (adjust_intervals_for_deletion): Now extern, because otherwise the
3371 extern inline functions 'offset_intervals' couldn't refer to it.
3372 (static_offset_intervals): Remove.
3373 (offset_intervals): Rewrite using the old contents of
3374 static_offset_intervals. The old version didn't conform to C99
3375 because an extern inline function contained a reference to an
3376 identifier with static linkage.
3377
b7041366
AS
33782011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3379
3380 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3381 GC.
3382
88a37c4d
EZ
33832011-11-06 Eli Zaretskii <eliz@gnu.org>
3384
3385 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3386 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3387 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3388 return Qleft_to_right.
3389
49745b39
CY
33902011-11-06 Chong Yidong <cyd@gnu.org>
3391
3392 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3393 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3394 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3395 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3396 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3397 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3398 (Fwindow_vscroll): Doc fix.
3399 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3400 argument, since it makes no sense to pass a live window and for
3401 consistency with window-child.
3402
1f05cd82
CS
34032011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3404
3405 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3406 support MSVC.
3407
22610910
JR
34082011-11-05 Jason Rumney <jasonr@gnu.org>
3409
3410 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3411 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3412 fonts (Bug#6029).
3413 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3414 bitwise arithmetic preventing use of unicode-sip and non-truetype
3415 opentype fonts.
3416
a06776b2
EZ
34172011-11-05 Eli Zaretskii <eliz@gnu.org>
3418
3ad924ba
EZ
3419 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3420 "emacs"-only part.
3421
a06776b2
EZ
3422 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3423 initialization code to keep similarity to xfns.c after changes
3424 from 2011-11-05.
3425
c9e7db78
JD
34262011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3427
a97f8f3f
JD
3428 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3429 (unwind_create_frame): New function (Bug#9943).
3430 (Fx_create_frame): Restructure code to be more similar to the one in
3431 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3432 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3433 Move terminal->reference_count++ just before making the frame official
3434 (Bug#9943).
3435
3436 * nsterm.m (x_free_frame_resources): New function.
3437 (x_destroy_window): Move code to x_free_frame_resources.
3438
c9e7db78 3439 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3440 (Fx_create_frame, x_create_tip_frame):
3441 Move terminal->reference_count++ just before making the frame
75f1671a 3442 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3443 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3444
a6fc3b5c
EZ
34452011-11-05 Eli Zaretskii <eliz@gnu.org>
3446
3447 Support MSVC build with newer versions of Visual Studio.
3448 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3449 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3450 nt/gmake.defs.
3451
3452 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3453 which are not supported by MSVC.
3454 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3455 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3456 bitfields.
3457 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3458 types in bitfields.
3459 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3460
3461 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3462
58179cce 34632011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3464
3465 Support MSVC build with newer versions of Visual Studio.
3466 * w32.c: Don't include w32api.h for MSVC.
3467 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3468
3469 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3470 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3471 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3472 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3473 e_* cousins.
3474 (alloca) [_MSC_VER]: Define to _alloca.
3475
3476 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3477
3478 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3479
a58c13ed
EZ
34802011-11-04 Eli Zaretskii <eliz@gnu.org>
3481
3482 * xdisp.c (note_mouse_highlight): If either of
3483 previous/next-single-property-change returns nil, treat that as
3484 the beginning or the end of the buffer. (Bug#9955)
3485
fe0b6370
JD
34862011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3487
a58c13ed 3488 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3489 label is not null (Bug#9951).
3490 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3491 may be NULL.
3492
89bd5ee1
EZ
34932011-11-04 Eli Zaretskii <eliz@gnu.org>
3494
3495 * window.c (Fwindow_body_size): Mention in the doc string that the
3496 return value is in frame's canonical units. (Bug#9949)
3497
84c3edb9
EZ
34982011-11-03 Eli Zaretskii <eliz@gnu.org>
3499
4e2fb5c7
EZ
3500 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3501
84c3edb9 3502 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3503 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3504 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3505
bc17a887
EZ
35062011-11-01 Eli Zaretskii <eliz@gnu.org>
3507
3508 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3509 Don't stop backward scan on the continuation glyph, even though
3510 its CHARPOS is positive.
6d5eb5b0
SM
3511 (mouse_face_from_buffer_pos, note_mouse_highlight):
3512 Rename cover_string to disp_string.
bc17a887 3513
4ee88440
MR
35142011-11-01 Martin Rudalics <rudalics@gmx.at>
3515
3516 * window.c (temp_output_buffer_show): Don't use
3517 Vtemp_buffer_show_specifiers.
3518 (Vtemp_buffer_show_specifiers): Remove unused variable.
3519
c2ff3c02
EZ
35202011-10-30 Eli Zaretskii <eliz@gnu.org>
3521
3522 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3523 past the beginning of the current glyph matrix.
3524
58179cce 35252011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3526
3527 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3528 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3529 HAVE_GTK3 (Bug#9869).
b77a6a7f 3530
3b574623
JD
3531 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3532 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3533
b77a6a7f
JD
3534 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3535
3536 * xterm.c: Declare x_handle_net_wm_state to return int.
3537 (handle_one_xevent): Check if we are iconified but don't have
3538 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3539 (get_current_wm_state): Return non-zero if not hidden,
3540 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3541 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3542 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3543 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3544
196e41e4
PE
35452011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3548 so that this new function doesn't get optimized away by a
3549 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3550
021f2e1a
AS
35512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3552
3553 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3554
8b058d44
EZ
35552011-10-29 Eli Zaretskii <eliz@gnu.org>
3556
3557 Fix the `xbytecode' command.
3558 * .gdbinit (xprintbytestr): New command.
b50a28de 3559 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3560 (xbytecode): Print the byte-code string as well.
3561
4452fb80
EZ
35622011-10-29 Kim Storm <storm@cua.dk>
3563
8b058d44
EZ
3564 * alloc.c (which_symbols): New function.
3565
21b72067
AS
35662011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3567
3568 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3569 line. (Bug#9903)
3570
83ed7b5c
GM
35712011-10-29 Glenn Morris <rgm@gnu.org>
3572
3573 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3574 Not clear what it was for, and it causes various bugs. (Bug#9839)
3575
5a7a728b
EZ
35762011-10-28 Eli Zaretskii <eliz@gnu.org>
3577
3578 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3579 possible random value that matches one of those tested as
3580 condition to clear the mouse face.
3581
d3d0842f
CY
35822011-10-28 Chong Yidong <cyd@gnu.org>
3583
3584 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3585
31b39d13
DN
35862011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3587
3588 * window.c (make_window): Initialize phys_cursor_on_p.
3589
9aba6043
SM
35902011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3591
3592 * lisp.h (struct Lisp_Symbol): Update comments.
3593
c20992f4
JB
35942011-10-28 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3597
db4f02f2
EZ
35982011-10-28 Eli Zaretskii <eliz@gnu.org>
3599
3600 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3601 <oslsachem@gmail.com> for helping to debug this.
3602
3603 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3604 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3605 (g_b_init_get_glyph_outline_w): New static variables.
3606 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3607 (GetGlyphOutlineW_Proc): New typedefs.
3608 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3609 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3610 New functions.
3611 (w32font_open_internal, compute_metrics):
3612 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3613 instead of calling the "wide" APIs directly.
3614
3615 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3616
3617 * w32.h (syms_of_w32font): Add prototype.
3618
87e68db4
JB
36192011-10-27 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3622 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3623 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3624 (Fmove_to_window_line): Doc fix.
3625
435c1d67
CY
36262011-10-27 Chong Yidong <cyd@gnu.org>
3627
3628 * process.c (make_process): Set gnutls_state to NULL.
3629
3630 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3631 non-NULL, regardless of GNUTLS_INITSTAGE.
3632 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3633 an error. Set process slots as soon as we allocate them.
3634
3635 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3636
9c6c6f49
CY
36372011-10-27 Chong Yidong <cyd@gnu.org>
3638
9aba6043
SM
3639 * gnutls.c (emacs_gnutls_deinit): New function.
3640 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3641 (Fgnutls_deinit, Fgnutls_boot): Use it.
3642
3643 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3644 (deactivate_process): Call emacs_gnutls_deinit.
3645
657d08d3
JB
36462011-10-27 Juanma Barranquero <lekktu@gmail.com>
3647
3648 * image.c (x_create_x_image_and_pixmap):
3649 * w32.c (sys_rename, w32_delayed_load):
3650 * w32font.c (fill_in_logfont):
3651 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3652
5430d399
JB
36532011-10-26 Juanma Barranquero <lekktu@gmail.com>
3654
3655 * w32fns.c (w32_default_color_map): New function,
3656 extracted from Fw32_default_color_map.
a7ef684b 3657 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3658
fe0055fa
PE
36592011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3660
3661 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3662
e6346438
SM
36632011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3664
3665 * keyboard.c (test_undefined): New function (bug#9751).
3666 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3667
e112cc37
ET
36682011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3669
3670 * sysdep.c (init_sys_modes): Fix the check for the controlling
3671 terminal (Bug#6649).
3672
7b5d6677
EZ
36732011-10-20 Eli Zaretskii <eliz@gnu.org>
3674
3675 * dispextern.h (struct bidi_it): New member next_en_type.
3676
3677 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3678 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3679 current character, check also for next_en_type being WEAK_EN.
3680 (bidi_resolve_weak): Don't enter the expensive loop if the current
3681 position is before next_en_pos. Record the bidi type of the first
3682 non-ET, non-BN character we find, in addition to its position.
3683 (bidi_level_of_next_char): Invalidate next_en_type when
3684 next_en_pos is over-stepped.
3685
7da0b018
PE
36862011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3687
3688 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3689 * editfns.c: Rewrite current-time-zone so that it invokes
3690 the equivalent of (format-time-string "%Z") to get the time zone name.
3691 This fixes a bug when the time zone name contains characters that
3692 need converting from the system time locale to Emacs internal format.
3693 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3694 that patch fixed format-time-string to do the conversion, but
3695 I forgot to fix current-time-zone.
3696 (format_time_string): New function, containing most of
3697 what Fformat_time_string used to contain.
3698 (Fformat_time_string): Rewrite in terms of format_time_string.
3699 This doesn't change this function's behavior.
3700 (current-time-zone): Rewrite to use format_time_string.
3701 This fixes the bug reported by Michael Schierl in
3702 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3703 Jason Rumney's 2007-06-07 change worked around this bug, but
3704 didn't fix it.
3705 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3706
8547b010
EZ
37072011-10-19 Eli Zaretskii <eliz@gnu.org>
3708
3709 * xdisp.c (start_display): If the character at POS is displayed
3710 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3711 (try_window_reusing_current_matrix): If a line ends in a display
3712 vector or the next line starts in a display vector, continue
3713 redrawing the window even though the character position of
3714 start_row was reached.
8547b010
EZ
3715 (Bug#9771, part 2)
3716
4e948d15
CY
37172011-10-18 Chong Yidong <cyd@gnu.org>
3718
3719 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3720 with nobreak-char-display too.
3721
4787455f
EZ
37222011-10-18 Eli Zaretskii <eliz@gnu.org>
3723
3724 Fix part 3 of bug#9771.
3725 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3726 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3727 non-neutral characters if the current character is a paragraph
3728 separator (a.k.a. Newline). This avoids running the same
3729 expensive loop twice, once when we consume the preceding newline
3730 and the other time when the line actually needs to be displayed.
3731 Avoid the loop when we see neutrals on the base embedding level
3732 following a character whose directionality is the same as the
3733 paragraph's. This avoids running the expensive loop when a line
3734 ends in a long sequence of neutrals, like control characters.
3735 Add assertion against STRONG_AL type. Slightly rearrange code
3736 that determines the type of a neutral given the first non-neutral
3737 that follows it.
3738 (bidi_level_of_next_char): Set next_en_pos to zero when
3739 invalidating its info.
3740
2c91f553
EZ
37412011-10-17 Eli Zaretskii <eliz@gnu.org>
3742
3743 * xdisp.c (push_display_prop): Determine whether to record string
3744 or buffer position by IT->string, not by IT->method. Allow
3745 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3746 (move_it_vertically_backward): Don't look for character position
3747 immediately after the newline when in a continuation line.
3748 (Bug#9771, part 1)
2c91f553 3749
c7b08b0d
MR
37502011-10-15 Martin Rudalics <rudalics@gmx.at>
3751
3752 * window.c (coordinates_in_window): Rewrite and delabelize
3753 vertical border check. (Bug#5357) (Bug#9618)
3754
6b02f655
SM
37552011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3756
3757 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3758 errors in XSetWindowBorder (bug#9310).
3759
81d40c92
DA
37602011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3761
3762 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3763 avoid crash when xmalloc overrun checking is enabled.
3764
d4172c3b
EZ
37652011-10-13 Eli Zaretskii <eliz@gnu.org>
3766
3767 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3768 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3769 cursor motion with <left> and <right> arrow keys.
3770
3771 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3772 some callers set that themselves.
3773
b00eea75
EZ
37742011-10-12 Eli Zaretskii <eliz@gnu.org>
3775
3776 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3777 display string and the previous row comes from the same string and
3778 is empty. (Bug#9739) (Bug#9738)
3779
8fe012c4
SM
37802011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3781
3782 * doc.c (get_doc_string): Encode file name (bug#9735).
3783
0074aef2
EZ
37842011-10-12 Eli Zaretskii <eliz@gnu.org>
3785
79beb178
EZ
3786 * bidi.c (bidi_level_of_next_char):
3787 * xdisp.c (get_visually_first_element): Remove old incorrect
3788 comments regarding the Unicode Line Separator character.
3789
0074aef2
EZ
3790 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3791
6e4b3fbe
DA
37922011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3793
3794 * alloc.c (Fgc_status): Do not access beyond zombies array
3795 boundary if nzombies > MAX_ZOMBIES.
3796 * alloc.c (dump_zombies): Add missing format specifier.
3797
0324f3af
PE
37982011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3799
b5525cac
PE
3800 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3801 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3802
0324f3af
PE
3803 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3804 Some packages use them to denote characters with modifiers.
3805
e9b5f888
AS
38062011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3807
3808 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3809 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3810 matching a pp-number. Rename parameter var to var1.
3811
127827c0
SM
38122011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3813
3814 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3815
c8fd3bd0
GM
38162011-10-08 Glenn Morris <rgm@gnu.org>
3817
3818 * callint.c (Fcall_interactively): Give a more explicit error for the
3819 'c' case with a non-character input. (Bug#8479)
3820
352ec8ff
EZ
38212011-10-08 Eli Zaretskii <eliz@gnu.org>
3822
03669ccb
EZ
3823 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3824 lines.
7061c986
EZ
3825 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3826 lines that are hscrolled on the left.
03669ccb 3827
352ec8ff
EZ
3828 * dispnew.c (buffer_posn_from_coords): Account for a possible
3829 presence of header-line. (Bug#4426)
3830
a66cfb1c
SM
38312011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3832
6b02f655
SM
3833 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3834 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3835
7c5ee88e
PE
38362011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3837
3838 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3839 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3840 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3841 this makes Emacs dump core during garbage collection on rare
3842 occasions. sizeof is obviously inferior to offsetof here, so
3843 stick with offsetof.
3844 (GC_POINTER_ALIGNMENT): New macro.
3845 (mark_memory): Omit 3rd (offset) arg; caller changed.
3846 Don't assume EMACS_INT alignment is the same as pointer alignment.
3847
df1bbe5b
SM
38482011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3849
3850 * keyboard.c (read_key_sequence_remapped): New var.
3851 (read_key_sequence): Compute remapping in the right buffer.
3852 (command_loop_1): Use read_key_sequence's remapping directly.
3853
51553db6
SM
38542011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3855
32c1fffd
SM
3856 * dired.c (file_name_completion): Don't expand file name.
3857 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3858 before checking file name handler.
3859
51553db6
SM
3860 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3861 they've been requested explicitly (bug#9591).
3862
b6bd1599 38632011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3864
3865 * keymap.c (Fsingle_key_description): Use make_specified_string
3866 instead of build_string to build string from push_key_description.
3867 (Bug#5193)
3868
f701dc2a
PE
38692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3870
4222c55d
PE
3871 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3872 This fixes a Y2038 bug on 64-bit hosts.
3873 * buffer.c (reset_buffer):
3874 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3875 (Fclear_buffer_auto_save_failure):
3876 Use 0, not -1, to represent an unset failure time, since time_t
3877 might not be signed.
3878
f701dc2a
PE
3879 Remove dependency on glibc malloc internals.
3880 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3881 Move back here from lisp.h, but with their new implementations.
3882 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3883 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3884 * charset.c (charset_table_init): New static var.
3885 (syms_of_charset): Use it instead of xmalloc. This removes a
3886 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3887 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3888 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3889 Move back to alloc.c.
3890 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3891 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3892
9ceebf39
JD
38932011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3894
3895 * nsterm.m (windowDidResize): Call x_set_window_size only when
3896 ns_in_resize is true. Otherwise set pixelwidth/height and
3897 call change_frame_size (Bug#9628).
3898
cb993c58
PE
38992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3900
3930c88b
PE
3901 Port --enable-checking=all to Fedora 14 x86-64.
3902 * charset.c (syms_of_charset): Also account for glibc malloc's
3903 internal overhead when calculating the initial malloc maximum.
3904
cb993c58
PE
3905 Port --enable-checking=all to Fedora 14 x86.
3906 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3907 Move to lisp.h.
3908 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3909 (overrun_check_realloc, overrun_check_free):
3910 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3911 That way, xmalloc returns a properly-aligned pointer even if
3912 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3913 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3914 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3915 into account when calculating the initial malloc maximum.
3916 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3917 Move here from alloc.c, so that charset.c can use it too.
3918 Properly align; the old code wasn't right for common 32-bit hosts
3919 when configured with --enable-checking=all.
3920 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3921 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3922
31bed486
EZ
39232011-09-29 Eli Zaretskii <eliz@gnu.org>
3924
04c70788 3925 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3926 use EDOM.
3927
fbcaa2f3
EZ
39282011-09-28 Eli Zaretskii <eliz@gnu.org>
3929
3930 * xdisp.c (compute_display_string_end): If there's no display
3931 string at CHARPOS, return -1.
3932
3933 * bidi.c (bidi_fetch_char): When compute_display_string_end
3934 returns a negative value, treat the character as a normal
3935 character not covered by a display string. (Bug#9624)
3936
a239d4e9
JB
39372011-09-28 Juanma Barranquero <lekktu@gmail.com>
3938
3939 * lread.c (Fread_from_string): Fix typo in docstring.
3940
88652fd5
EZ
39412011-09-27 Eli Zaretskii <eliz@gnu.org>
3942
3943 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3944 newline, reseat the iterator instead of bidi-iterating there one
3945 character at a time. (Bug#9610)
32c1fffd
SM
3946 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3947 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3948
ed497dd4
AS
39492011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3950
3951 * lread.c (readevalloop): Use correct code for NBSP.
3952 (read1): Likewise. (Bug#9608)
3953
b2bf61aa
MA
39542011-09-25 Michael Albinus <michael.albinus@gmx.de>
3955
3956 * dbusbind.c (Fdbus_register_signal): When service is not
3957 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3958
32bbb17c
GM
39592011-09-25 Glenn Morris <rgm@gnu.org>
3960
3961 * buffer.c (truncate-lines): Doc fix.
3962
94e0933e
CY
39632011-09-24 Chong Yidong <cyd@stupidchicken.com>
3964
3965 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3966 (Fset_window_next_buffers): Doc fix.
3967
cddde921
GM
39682011-09-24 Glenn Morris <rgm@gnu.org>
3969
3970 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3971
1260aef1
PE
39722011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3973
25b4bfa0
PE
3974 Fix minor problems found by static checking.
3975 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3976 * indent.c (Fvertical_motion): Fix == vs = typo.
3977
e3cbd34b
EZ
39782011-09-24 Eli Zaretskii <eliz@gnu.org>
3979
a66cfb1c
SM
3980 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3981 Default value is now t. Doc fix.
6bf7006f 3982
e3cbd34b 3983 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3984 logic when moving up, not only when moving down. Fix the
e3cbd34b 3985 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3986 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3987
3988 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3989 CHARPOS is covered by a display string which includes newlines.
3990 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3991 is covered by a display string with embedded newlines.
3992
a3de0cbd
MA
39932011-09-24 Michael Albinus <michael.albinus@gmx.de>
3994
3995 * dbusbind.c (Fdbus_register_signal): Add match rule to
3996 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3997 (Fdbus_register_method, Vdbus_registered_objects_table):
3998 Fix docstring.
a3de0cbd 3999
b260039d
JM
40002011-09-24 Jim Meyering <meyering@redhat.com>
4001
32c1fffd 4002 do not ignore write error for any output size
b260039d
JM
4003 The previous change was incomplete.
4004 While it makes emacs --batch detect the vast majority of stdout
4005 write failures, errors were still ignored whenever the output size is
4006 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4007 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4008 && echo FAIL: ignored write error
4009 FAIL: ignored write error
4010 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4011 && echo FAIL: ignored write error
4012 FAIL: ignored write error
4013 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4014
8eca8a7c
AS
40152011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4016
4017 * emacs.c (Fkill_emacs): In noninteractive mode exit
4018 non-successfully if a write error occurred on stdout. (Bug#9574)
4019
3341db62
EZ
40202011-09-21 Eli Zaretskii <eliz@gnu.org>
4021
4022 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4023 the xassert test.
4024
4025 * dispextern.h (struct it): Update the comment documenting what
4026 can it->OBJECT be.
4027
8c203dbf
EZ
40282011-09-20 Eli Zaretskii <eliz@gnu.org>
4029
4030 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4031 a display string, extend search for cursor position to end of row.
4032 (find_row_edges): If the row ends in a newline from a display
4033 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4034 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4035 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4036 non-empty line. Fixes confusing cursor motion with arrow keys at
4037 the beginning of a line that starts with whitespace.
8c203dbf 4038
a4824228
LMI
40392011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4040
4041 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4042 (bug#9493).
4043
33ed493b
CY
40442011-09-18 Chong Yidong <cyd@stupidchicken.com>
4045
4046 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4047 boolean (Bug#9154).
4048
56cd55c8
EZ
40492011-09-18 Eli Zaretskii <eliz@gnu.org>
4050
4051 * xdisp.c (display_line): Record maximum and minimum buffer
4052 positions even if no glyphs were produced (e.g., by a zero-width
4053 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4054 buffer positions that will be removed from the glyph row because
4055 they don't fit.
c02dcedf
EZ
4056 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4057 column is beyond frame width: don't subtract 1 "pixel" when
4058 computing width of the stretch.
3e62b7e0
EZ
4059 (reseat_at_next_visible_line_start): Undo the change made on
4060 2011-09-17 that saved paragraph information and restored it after
4061 the call to `reseat'. (Bug#9545)
56cd55c8 4062
5ed99d36 40632011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4064
4065 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4066 and turn window cursor on if cleared (Bug#9415).
4067
5ed99d36 40682011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4069
4070 * search.c (boyer_moore): Take unibyte characters from pattern
4071 literally. (Bug#9458)
4072
9bade7b2
EZ
40732011-09-18 Eli Zaretskii <eliz@gnu.org>
4074
4075 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4076
e5e9d610
PE
40772011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4078
87e4427a
PE
4079 Fix minor problem found by static checking.
4080 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4081 initialized, to pacify gcc -Wuninitialized.
4082
e5e9d610
PE
4083 * fileio.c: Report proper errno when syscall falls.
4084 (Finsert_file_contents): Save and restore errno,
4085 so that report_file_error outputs the correct diagnostic.
4086 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4087
a1674f0b
EZ
40882011-09-18 Eli Zaretskii <eliz@gnu.org>
4089
4090 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4091
fbfb6dd4
EZ
40922011-09-17 Eli Zaretskii <eliz@gnu.org>
4093
4094 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4095 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4096
bb187662
EZ
40972011-09-17 Eli Zaretskii <eliz@gnu.org>
4098
1137e8b8 4099 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4100 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4101
4102 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4103 (bidi_find_paragraph_start): Search back for paragraph beginning
4104 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4105 (bidi_move_to_visually_next): Only trigger paragraph-related
4106 computations when the last character is a newline or at EOB, not
4107 just any NEUTRAL_B. (Bug#9470)
4108
bb187662
EZ
4109 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4110 truncated lines if point is covered by a display string. (Bug#9524)
4111
2e621251
PE
41122011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4115 (cons_to_x_long): New function.
4116 (lisp_data_to_selection_data): Use it. Correct the test for
4117 short-versus-long data; it was negated. Break out of vector
4118 loop, for efficiency, when a long datum is discovered.
4119
91a15bc6
SM
41202011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4121
4122 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4123
b41c3a35
EZ
41242011-09-16 Eli Zaretskii <eliz@gnu.org>
4125
4126 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4127 GCC PR/17406) by declaring this function with external scope.
4128
7812ba2d
PE
41292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4132 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4133
cf7edc2a
AS
41342011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4135
4136 * editfns.c (Fformat): Correctly handle text properties on "%%".
4137
bd01620e
EZ
41382011-09-15 Eli Zaretskii <eliz@gnu.org>
4139
4140 * xterm.c (x_draw_composite_glyph_string_foreground):
4141 * w32term.c (x_draw_composite_glyph_string_foreground):
4142 * term.c (encode_terminal_code):
4143 * composite.c (composition_update_it, get_composition_id):
4144 * xdisp.c (get_next_display_element)
4145 (fill_composite_glyph_string): Add comments about special meaning
4146 of TAB characters in a composition.
4147
a02719a3
PE
41482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4151 This occurs when processing a multibyte format.
4152 Problem reported by Wolfgang Jenker.
a02719a3 4153
72589a3c
JB
41542011-09-15 Johan Bockgård <bojohan@gnu.org>
4155
4156 * xdisp.c (try_cursor_movement): Only check for exact match if
4157 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4158
1c14176c
PE
41592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4160
4161 Remove unused external symbols.
4162 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4163 * xdisp.c (calc_pixel_width_or_height): Now static.
4164 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4165 * indent.c (check_display_width):
4166 * w32term.c: Fix comment to match code.
4167 * xterm.c, xterm.h (x_catching_errors): Remove.
4168
d2eea5b5
PE
41692011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4170
4171 * xselect.c: Use signed conversions more consistently (Bug#9498).
4172 (selection_data_to_lisp_data): Assume incoming selection data are
4173 signed integers, not unsigned. This is to be consistent with
4174 outgoing selection data, which was modified to use signed integers
4175 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4176 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4177 expects long, not unsigned long.
4178
46888499
EZ
41792011-09-14 Eli Zaretskii <eliz@gnu.org>
4180
4181 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4182 computation of loop end. Reported by Johan Bockgård
4183 <bojohan@gnu.org>.
4184
ef8ef9fb
CY
41852011-09-13 Chong Yidong <cyd@stupidchicken.com>
4186
4187 * frame.c (Fother_visible_frames_p): Function deleted.
4188
fa819fed
EZ
41892011-09-12 Eli Zaretskii <eliz@gnu.org>
4190
4191 * indent.c (compute_motion): Process display vector front to back
4192 rather than the other way around. (Bug#2496)
4193
2ba8e008
SM
41942011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4195
4196 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4197
20f53c69
CY
41982011-09-11 Chong Yidong <cyd@stupidchicken.com>
4199
4200 * minibuf.c (Fread_from_minibuffer): Doc fix.
4201
d562d7a4
EZ
42022011-09-11 Eli Zaretskii <eliz@gnu.org>
4203
4204 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4205 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4206
1c4d7f3d
LMI
42072011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4208
4209 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4210 value for non-existent files.
4211
b885bf36
EZ
42122011-09-11 Eli Zaretskii <eliz@gnu.org>
4213
4214 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4215 set its "size" to -1. This will set the modtime_size field of
4216 the corresponding buffer to -1, which is what
4217 verify-visited-file-modtime expects for files that do not exist.
4218 (Bug#9139)
4219
6612f0bf
PE
42202011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4221
4222 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4223 here ...
4224 * lisp.h: ... from here. push_key_description is no longer
4225 defined in keyboard.c, so its declaration should not be in
4226 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4227 logically belongs with push_key_description.
4228
dfb3f755
PE
42292011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 * buffer.h: Include <sys/types.h> instead of <time.h>.
4232 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4233 Problem reported by Herbert J. Skuhra.
4234
3134906c
LMI
42352011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4236
4237 * xml.c (parse_region): Make the parsing work for
4238 non-comment-starting XML files again (bug#9144).
4239
8d903f4e
AS
42402011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4241
4242 * image.c (gif_load): Fix calculation of bottom and right corner.
4243 (Bug#9468)
4244
80ad64f4
EZ
42452011-09-10 Eli Zaretskii <eliz@gnu.org>
4246
4247 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4248 redisplay in small windows.
4249
208a048d
EZ
42502011-09-09 Eli Zaretskii <eliz@gnu.org>
4251
4252 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4253
9b1c252e
MR
42542011-09-08 Martin Rudalics <rudalics@gmx.at>
4255
4256 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4257 Operate on live windows only.
4258
2949f33b
JB
42592011-09-08 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4262
e08dcafd
EZ
42632011-09-07 Eli Zaretskii <eliz@gnu.org>
4264
4265 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4266 only under bidi iteration.
4267
115b96bd
JD
42682011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4269
4270 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4271
c8199d0f
PE
42722011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4273
4274 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4275 Without this fix, the command to link temacs failed due to an
4276 undefined symbol __builtin_isnan. This is because
4277 /usr/include/iso/math_c99.h #defines isnan(x) to
4278 __builtin_isnan(x), but the bundled gcc, which identifies itself
4279 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4280 a __builtin_isnan.
4281 * floatfns.c (isnan): #undef, and then #define to a clone of
4282 what's in data.c.
4283 (Fisnan): Always define, since it's always available now.
4284 (syms_of_floatfns): Always define isnan at the Lisp level.
4285
e39b275c 42862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4287
4288 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4289
b2db44d9 42902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4291
f4af5137 4292 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4293 The previous code assumed that file offsets (off_t values) fit in
4294 EMACS_INT variables, which is not true on typical 32-bit hosts.
4295 The code messed up by falsely reporting buffer overflow in cases
4296 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4297 when "big" contains more than 2**29 bytes, even though this
4298 inserts just one byte and does not overflow the buffer.
4299 (Finsert_file_contents): Store file offsets as off_t
4300 values, not as EMACS_INT values. Check for overflow when
4301 converting between EMACS_INT and off_t. When checking for
4302 buffer overflow or for overlap, take the offsets into account.
4303 Don't use EMACS_INT for small values where int suffices.
4304 When checking for overlap, fix a typo: ZV was used where
4305 ZV_BYTE was intended.
4306 (Fwrite_region): Don't assume off_t fits into 'long'.
4307 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4308
ecfc0a49
MA
43092011-09-05 Michael Albinus <michael.albinus@gmx.de>
4310
4311 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4312
6511acf2 43132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4314
0999621a 4315 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4316
4317 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4318 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4319 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4320 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4321 (modify_event_symbol): Do not assume that the length of
4322 name_alist_or_stem is safe to alloca and fits in int.
4323 (Fexecute_extended_command): Likewise for function name and binding.
4324 (Frecursion_depth): Wrap around reliably on integer overflow.
4325 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4326 since some callers pass EMACS_INT values.
4327 (Fsingle_key_description): Don't crash if symbol name contains more
4328 than MAX_ALLOCA bytes.
4329 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4330 (get_minibuffer): Arg is now EMACS_INT, not int.
4331 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4332 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4333 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4334
2be7d702
PE
4335 * dbusbind.c (signature_cat): New function.
4336 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4337 Do not overrun buffer; instead, report string overflow.
4338
9d1df220
PE
4339 * dispnew.c (add_window_display_history): Don't overrun buffer.
4340 Truncate instead; this is OK since it's just a log.
4341
33ef5c64
PE
4342 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4343 even if the time zone offset is outlandishly large.
4344 Don't mishandle offset == INT_MIN.
4345
66c6fdd5
PE
4346 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4347 when creating daemon; the previous buffer-overflow check was incorrect.
4348
d749b01b
PE
4349 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4350 which has the guts of the old verror function.
4351
b5cd1905
PE
4352 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4353 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4354
6e1a67fb
PE
4355 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4356 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4357 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4358 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4359 length of string rather than counting it via multiple sprintfs;
4360 that's simpler and more reliable.
c21721cc
PE
4361 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4362 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4363 sprintf, in case result does not fit in int.
4364
c57b67fc
PE
4365 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4366 (fontset_from_font): Print it.
4367
8a401434
PE
4368 * frame.c (tty_frame_count): Now printmax_t, not int.
4369 (make_terminal_frame, set_term_frame_name): Print it.
4370 (x_report_frame_params): In X, window IDs are unsigned long,
4371 not signed long, so print them as unsigned.
4372 (validate_x_resource_name): Check for implausibly long names,
4373 and don't assume name length fits in 'int'.
4374 (x_get_resource_string): Don't blindly alloca invocation name;
4375 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4376 not fit in int.
4377
6e1a67fb
PE
4378 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4379 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4380 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4381
0df02bf3
PE
4382 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4383 Use esprintf, not sprintf, in case result does not fit in int.
4384
48e30793
PE
4385 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4386 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4387 it as a large positive number.
4388 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4389 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4390
a66ff6d8
PE
4391 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4392 in case result does not fit in int.
4393
aca216ff
PE
4394 * print.c (float_to_string): Detect width overflow more reliably.
4395 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4396 buffer overrun. Don't assume list length fits in 'int'. Treat
4397 print length of 0 as 0, not as infinity; to be consistent with other
4398 uses of print length in this function. Don't overflow print length
4399 index. Don't assume hash table size fits in 'long', or that
4400 vectorlike size fits in 'unsigned long'.
4401
31c286f7
PE
4402 * process.c (make_process): Use printmax_t, not int, to format
4403 process-name gensyms.
4404
55e5faa1
PE
4405 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4406
80f2e268
PE
4407 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4408 to avoid potential buffer overrun.
4409
670741ab
PE
4410 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4411 if X resource line is longer than 512 bytes.
4412
b7163a50
PE
4413 * xfns.c (x_window): Make sprintf buffer a bit bigger
4414 to avoid potential buffer overrun.
4415
ae58ff1f
PE
4416 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4417
c43c8a6a
PE
4418 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4419
3f8236f4
PE
44202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4421
53e9fe90 4422 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4423 Without these, Emacs silently mishandles large integers sometimes.
4424 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4425 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4426
6511acf2
PE
4427 * xdisp.c (try_window_id): Check Emacs fixnum range before
4428 converting to 'int'.
806add1d 4429
6511acf2 4430 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4431 Check that an Emacs fixnum is in range before assigning it to 'int'.
4432 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4433 values converted from Emacs fixnums.
4434 (Frecenter): Don't wrap around a line count if it is out of 'int'
4435 range; instead, treat it as an extreme value.
4436 (Fset_window_configuration, compare_window_configurations):
4437 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4438
6511acf2
PE
4439 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4440 that can exceed INT_MAX. Check that EMACS_INT value is in range
4441 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4442 (match_limit): Don't assume that a fixnum can fit in 'int'.
4443
6511acf2 4444 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4445 exceed INT_MAX.
4446
6511acf2 4447 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4448 (Fvertical_motion): Don't wrap around LINES values that don't fit
4449 in 'int'. Instead, treat them as extreme values. This is good
4450 enough for windows, which can't have more than INT_MAX lines anyway.
4451
fcb901a7
LMI
44522011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4453
0f2f6b6d
LMI
4454 * Require libxml/parser.h to avoid compilation warning.
4455
fcb901a7
LMI
4456 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4457
4458 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4459 since this reportedly can destroy thread storage.
4460
6e20a0d4
CY
44612011-08-30 Chong Yidong <cyd@stupidchicken.com>
4462
4463 * syntax.c (find_defun_start): Update all cache variables if
4464 exiting early (Bug#9401).
4465
148ae00e
EZ
44662011-08-30 Eli Zaretskii <eliz@gnu.org>
4467
f6cfbd8f
EZ
4468 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4469
148ae00e
EZ
4470 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4471 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4472 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4473
4474 * term.c (tty_append_glyph): New function.
4475 (produce_stretch_glyph): Static function and its prototype deleted.
4476
a66cfb1c
SM
4477 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4478 Add prototypes.
148ae00e 4479
c4a07a4c
PE
44802011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4481
4482 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4483 when checking :margin (Bug#9390).
4484 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4485 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4486 so that the name doesn't mislead. All uses changed.
4487
6bc8cd65
JB
44882011-08-28 Johan Bockgård <bojohan@gnu.org>
4489
4490 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4491 set_tty_hooks.
4492
dca4927e
EZ
44932011-08-27 Eli Zaretskii <eliz@gnu.org>
4494
4495 * xdisp.c (move_it_to): Don't bail out early when reaching
4496 position beyond to_charpos, if we are scanning backwards.
4497 (move_it_vertically_backward): When DY == 0, make sure we get to
4498 the first character in the line after the newline.
4499
f2cad773
PE
45002011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4503 (ccl_driver): Do not generate an out-of-range pointer.
4504 (Fccl_execute_on_string): Remove unnecessary check for
4505 integer overflow, noted by Stefan Monnier in
4506 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4507 Remove a FIXME that didn't need fixing.
4508 Simplify the newly-introduced buffer reallocation code.
4509
0cae2cdb
JB
45102011-08-27 Juanma Barranquero <lekktu@gmail.com>
4511
4512 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4513
5fc295a4 45142011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4515
70c60eb2 4516 Integer and memory overflow issues (Bug#9196).
726e0ab1 4517
d31850da
PE
4518 * doc.c (get_doc_string): Rework so that
4519 get_doc_string_buffer_size is the actual buffer size, rather than
4520 being 1 less than the actual buffer size; this makes xpalloc more
4521 convenient.
4522
a69fbedb
PE
4523 * image.c (x_allocate_bitmap_record, cache_image):
4524 * xselect.c (Fx_register_dnd_atom):
4525 Simplify previous changes by using xpalloc.
4526
fe5c5d37
PE
4527 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4528 since either will do and ptrdiff_t is convenient with xpalloc.
4529
0065d054
PE
4530 * charset.c (charset_table_size)
4531 (struct charset_sort_data.priority): Now ptrdiff_t.
4532 (charset_compare): Don't overflow if priorities differ greatly.
4533 (Fsort_charsets): Don't assume list length fits in int.
4534 Check for size-calculation overflow when allocating sort data.
4535 (syms_of_charset): Allocate an initial charset table that is
4536 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4537
4538 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4539
4540 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4541 The actual value is always <= INT_MAX, and leaving it unsigned made
4542 overflow checking harder.
4543
4544 * dispextern.h (struct glyph_matrix.rows_allocated)
4545 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4546 with xpalloc. The values are still always <= INT_MAX.
4547
4548 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4549
4550 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4551 (SAFE_NALLOCA): New macro.
4552
4553 * region-cache.c (struct boundary.pos, find_cache_boundary)
4554 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4555 (set_cache_region, invalidate_region_cache)
4556 (revalidate_region_cache, know_region_cache, region_cache_forward)
4557 (region_cache_backward, pp_cache):
4558 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4559 so that ptrdiff_t * can be passed to xpalloc.
4560 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4561 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4562 (pp_cache): Don't assume cache_len fits in int.
4563 * region-cache.h: Adjust extern decls to match.
4564
4565 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4566 EMACS_INT, since either will do, for xpalloc.
4567
4568 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4569 (xnmalloc, xnrealloc, xpalloc): New functions.
4570
726e0ab1
PE
4571 * bidi.c (bidi_shelve_header_size): New constant.
4572 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4573 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4574
51f30bc5 4575 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4576 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4577 (overlay_strings):
4578 Don't update size of array until after memory allocation succeeds,
4579 because xmalloc/xrealloc may not return.
0065d054
PE
4580 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4581 now that we have proper integer overflow checking.
4582 (record_overlay_string, overlay_strings): Catch overflows when
4583 calculating size of overlay_str_buf.
726e0ab1 4584
0065d054
PE
4585 * callproc.c (Fcall_process): Check for size overflow when
4586 calculating size of args2.
4587 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4588 Normally we prefer signed values, but sticking with ptrdiff_t would
4589 require adding more-complicated checks.
726e0ab1
PE
4590
4591 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4592 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4593 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4594 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4595
4596 * character.c (Fstring): Check for size-calculation overflow.
4597
4598 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4599 unnecessary integer overflow. Check for size overflow.
4600 (encode_coding_object): Don't update size until xmalloc succeeds.
4601
4602 * composite.c (get_composition_id): Check for overflow in glyph
4603 length calculations.
4604
4605 Integer and memory overflow fixes for display code.
4606 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4607 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4608 (scrolling_window): Check for overflow in size calculations.
4609 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4610 Don't assume glyph table len fits in int.
4611 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4612 (row_table_size): Now ptrdiff_t, not int.
4613 (scrolling_window): Avoid overflow in size calculations.
4614 Don't update size until allocation succeeds.
4615 * fns.c (concat): Check for overflow in size calculations.
4616 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4617 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4618 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4619
4620 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4621 (get_doc_string): Check for size calculation overflow.
4622 Don't update size until allocation succeeds.
4623 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4624 EMACS_INT, where ptrdiff_t will do.
4625 (Fsubstitute_command_keys): Check for string overflow.
4626
4627 * editfns.c (set_time_zone_rule): Don't assume environment length
4628 fits in int.
4629 (message_length): Now ptrdiff_t, not int.
4630 (Fmessage_box): Don't update size until allocation succeeds.
4631 Don't assume message length fits in int.
4632 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4633
0065d054
PE
4634 * emacs.c (main): Do not reallocate argv, since there is a null at
4635 the end that can be overwritten, and this way there's no need to
4636 worry about size-calculation overflow.
4637 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4638
4639 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4640 alloc succeeds.
4641 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4642
4643 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4644 (x_set_scroll_bar_width, x_figure_window_size):
4645 Check for integer overflow.
4646 (x_set_alpha): Do not assume XINT fits in int.
4647
4648 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4649 This is for the members text_lines, text_cols, total_lines, total_cols,
4650 where the system imposes an 'int' limit.
4651
4652 * fringe.c (Fdefine_fringe_bitmap):
4653 Don't update size until alloc works.
4654
4655 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4656 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4657
4658 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4659 Check for size-calculation overflow.
4660 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4661 do, as we prefer signed integers.
4662 (id_to_widget.max_size, id_to_widget.used)
4663 (xg_store_widget_in_map, xg_remove_widget_from_map)
4664 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4665 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4666 Use and return ptrdiff_t, not int.
4667 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4668 * gtkutil.h: Change prototypes to match the above.
4669
4670 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4671 are duplicate now that they've been promoted to lisp.h.
4672 (x_allocate_bitmap_record, x_alloc_image_color)
4673 (make_image_cache, cache_image, xpm_load):
4674 Don't update size until alloc is done.
4675 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4676 (x_detect_edges):
3256efce 4677 Check for size calculation overflow.
726e0ab1
PE
4678 (ct_colors_allocated_max): New constant.
4679 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4680 overflow.
3256efce 4681
726e0ab1
PE
4682 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4683 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4684 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4685 Use ptrdiff_t, not int, to count maps.
4686 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4687 calculations. Don't update size until allocation succeeds.
4688 Redo calculations to avoid overflow.
726e0ab1
PE
4689 * keyboard.h: Change prototypes to match the above.
4690
4691 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4692 to count maps.
4693 (current_minor_maps): Check for size calculation overflow.
4694 * keymap.h: Change prototypes to match the above.
4695
4696 * lread.c (read1, init_obarray): Don't update size until alloc done.
4697
4698 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4699 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4700
726e0ab1
PE
4701 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4702 Now ptrdiff_t, not int.
4703 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4704 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4705
4706 * process.c (Fnetwork_interface_list): Check for overflow
4707 in size calculation.
4708
4709 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4710
4711 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4712 overflow. Don't bother calling xmalloc when xrealloc will do.
4713
4714 * search.c (Freplace_match): Check for size calculation overflow.
4715 (Fset_match_data): Don't assume list lengths fit in 'int'.
4716
4717 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4718 for command line length. Do not attempt to address one before the
4719 beginning of an array, as that's not portable.
4720
4721 * term.c (max_frame_lines): Remove; unused.
4722 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4723 not int.
4724 (encode_terminal_code, calculate_costs): Check for size
4725 calculation overflow.
4726 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4727 table lengths and related sizes. Don't update size until alloc
4728 done. Redo calculations to avoid overflow.
4729 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4730
4731 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4732 subtracting pointers.
4733 (gobble_line): Check for overflow more carefully. Don't update size
4734 until alloc done.
4735
4736 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4737 Don't update size until alloc done.
4738 Redo size calculations to avoid overflow.
4739 Check for size calculation overflow.
0065d054 4740 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4741
4742 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4743 Use ptrdiff_t, not int, for sizes.
4744 (store_mode_line_noprop_char): Don't update size until alloc done.
4745
0065d054
PE
4746 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4747 Use ptrdiff_t, not int, for sizes.
4748 (Finternal_make_lisp_face, cache_face):
4749 Check for size calculation overflow.
4750 (cache_face): Treat size calculation overflows as if they were
4751 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4752
4753 * xfns.c (x_encode_text, x_set_name_internal)
4754 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4755 sizes, since they can exceed INT_MAX in size. Check for size
4756 calculation overflow.
4757
0065d054
PE
4758 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4759 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4760 Don't update size until alloc done.
4761
0065d054 4762 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4763 as sprintf is limited to int lengths.
1d526e2f 4764
252c5ee1
PE
4765 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4766 (X_LONG_MIN): New macros.
864d7ce7
PE
4767 Use them to make the following changes clearer.
4768 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4769 This change doesn't affect the value now, but it may help remind
4770 future maintainers not to raise the value too much later.
4771 (SELECTION_QUANTUM): Remove, replacing with ...
4772 (selection_quantum): ... new function, which avoids overflow.
4773 All uses changed.
4774 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4775 assumption that selection length fits in 'int'.
4776 (x_reply_selection_request, x_handle_selection_request)
4777 (x_get_window_property, receive_incremental_selection)
4778 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4779 (lisp_data_to_selection_data, clean_local_selection_data):
4780 Use ptrdiff_t, not int, to record length of selection.
4781 (x_reply_selection_request, x_get_window_property)
4782 (receive_incremental_selection, x_property_data_to_lisp):
4783 Redo calculations to avoid overflow.
4784 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4785 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4786 something.
4787 (x_get_window_property, receive_incremental_selection)
4788 (lisp_data_to_selection_data, x_property_data_to_lisp):
4789 Check for size-calculation overflow.
4790 (x_get_window_property, receive_incremental_selection)
4791 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4792 Don't store size until memory allocation succeeds.
4793 (x_get_window_property): Plug memory leak on memory exhaustion.
4794 Don't double-block input; malloc is safe here. Don't assume 2**34
4795 - 4 fits in unsigned long. Add an xassert to check
4796 XGetWindowProperty overflow. Be more careful about overflow
4797 calculations, and distinguish size from memory overflow better.
4798 (receive_incremental_selection): When tracing, don't assume
4799 unsigned int is less than INT_MAX.
4800 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4801 harmful) conversions of unsigned short to int.
4802 (lisp_data_to_selection_data): Don't assume that integers
4803 in the range -65535 through -1 fit in an X unsigned short.
4804 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4805 result parameters unless successful. Rely on cons_to_unsigned
4806 to report problems with elements; the old code wasn't right anyway.
4807 (x_check_property_data): Check for int overflow; we cannot use
4808 a wider type due to X limits.
4809 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4810
726e0ab1 4811 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4812
0065d054
PE
4813 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4814 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4815 (x_color_cells): Don't store size until memory allocation succeeds.
4816 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4817 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4818 (x_term_init): Don't assume length fits in int (sprintf is limited
4819 to int size).
bc18e09d 4820
ebfa62c0
PE
4821 Use ptrdiff_t for composition IDs.
4822 * character.c (lisp_string_width):
4823 * composite.c (composition_table_size, n_compositions)
4824 (get_composition_id, composition_gstring_from_id):
4825 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4826 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4827 * window.c (Frecenter):
4828 Use ptrdiff_t, not int, for composition IDs.
4829 * composite.c (get_composition_id): Check for integer overflow.
4830 * composite.h: Adjust prototypes to match the above changes.
4831
d3411f89
PE
4832 Use ptrdiff_t for hash table indexes.
4833 * category.c (hash_get_category_set):
4834 * ccl.c (ccl_driver):
4835 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4836 * coding.c (coding_system_charset_list, detect_coding_system):
4837 * coding.h (struct coding_system.id):
4838 * composite.c (get_composition_id, gstring_lookup_cache):
4839 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4840 * image.c (xpm_get_color_table_h):
4841 * lisp.h (hash_lookup, hash_put):
4842 * minibuf.c (Ftest_completion):
4843 Use ptrdiff_t for hash table indexes, not int (which is too
4844 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4845 32-bit --with-wide-int hosts).
4846
e097a6fa
PE
4847 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4848 Add a FIXME comment about memory leaks.
4849 (syms_of_charset): Don't assume xmalloc returns.
4850
5637687f
PE
4851 Don't assume that stated character widths fit in int.
4852 * character.c (Fchar_width, c_string_width, lisp_string_width):
4853 * character.h (CHAR_WIDTH):
4854 * indent.c (MULTIBYTE_BYTES_WIDTH):
4855 Use sanitize_char_width to avoid undefined and/or bad behavior
4856 with outlandish widths.
a66cfb1c 4857 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4858 now that we have two such functions. All uses changed.
4859 (sanitize_char_width): New inline function.
4860
a2271ba2
PE
4861 Don't assume that tab-width fits in int.
4862 * character.h (sanitize_width): New inline function.
4863 (SANE_TAB_WIDTH): New macro.
4864 (ASCII_CHAR_WIDTH): Use it.
4865 * indent.c (sane_tab_width): Remove. All uses replaced by
4866 SANE_TAB_WIDTH (current_buffer).
4867 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4868
18c52557
PE
4869 * fileio.c: Integer overflow issues with file modes.
4870 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4871
caeeedc1
PE
4872 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4873 Remove unreachable code.
4874 (read_hex, load_charset_map_from_file): Check for integer overflow.
4875
6df6ae42 4876 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4877 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4878 (x_send_scroll_bar_event): Likewise. Check that the size does not
4879 exceed limits imposed by XClientMessageEvent, as well as the usual
4880 ptrdiff_t and size_t limits.
4881
b13995db
PE
4882 * keyboard.c: Overflow, signedness and related fixes.
4883 (make_lispy_movement): Use same integer type in forward decl
4884 that is used in the definition.
4885 (read_key_sequence, keyremap_step):
4886 Change bufsize argument back to int, undoing my 2011-03-30 change.
4887 We prefer signed types, and int is wide enough here.
4888 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4889 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4890 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4891 length, not size_t. Use ptrdiff_t for index, not int.
4892 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4893 possibility of integer overflow.
4894
13464394
PE
4895 Overflow, signedness and related fixes for images.
4896
4897 * dispextern.h (struct it.stack[0].u.image.image_id)
4898 (struct_it.image_id, struct image.id, struct image_cache.size)
4899 (struct image_cache.used, struct image_cache.ref_count):
4900 * gtkutil.c (update_frame_tool_bar):
4901 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4902 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4903 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4904 * nsmenu.m (update_frame_tool_bar):
4905 * xdisp.c (calc_pixel_width_or_height):
4906 * xfns.c (image_cache_refcount):
4907 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4908 on typical 64-bit hosts.
4909
4910 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4911 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4912 Omit unnecessary casts to int.
4913 (parse_image_spec): Check that integers fall into 'int' range
4914 when the callers expect that.
4915 (image_ascent): Redo ascent calculation to avoid int overflow.
4916 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4917 (lookup_image): Remove unnecessary tests.
4918 (xbm_image_p): Locals are now of int, not EMACS_INT,
4919 since parse_image_check makes sure they fit into int.
4920 (png_load, gif_load, svg_load_image):
4921 Prefer int to unsigned where either will do.
4922 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4923 old tiff_error_handler and tiff_warning_handler.
4924 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4925 stack buffer overflows. It uses only the features of vsnprintf
4926 that are common to both POSIX and native Microsoft.
4927 (tiff_error_handler, tiff_warning_handler): Use it.
4928 (tiff_load, gif_load, imagemagick_load_image):
4929 Don't assume :index value fits in 'int'.
4930 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4931 (imagemagick_load_image): Check that crop parameters fit into
4932 the integer types that MagickCropImage accepts. Don't assume
4933 Vimagemagick_render_type has a nonnegative value. Don't assume
4934 size_t fits in 'long'.
4935 (gs_load): Use printmax_t to print the widest integers possible.
4936 Check for integer overflow when computing image height and width.
4937
c11821d4
EZ
49382011-08-26 Eli Zaretskii <eliz@gnu.org>
4939
4940 * xdisp.c (redisplay_window): Don't force window start if point
4941 will be invisible in the resulting window. (Bug#9324)
4942
0c95fcf7
EZ
49432011-08-25 Eli Zaretskii <eliz@gnu.org>
4944
4945 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4946 the display spec is of the form `(space ...)'.
4947 (handle_display_spec): Return the value returned by
4948 handle_single_display_spec, not just 1 or zero.
4949 (handle_single_display_spec): If the display spec is of the form
4950 `(space ...)', and specifies display in the text area, return 2
4951 rather than 1.
fee65a97 4952 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4953 accurately, and prefer exact match for point under bidi.
4954 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4955
4956 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4957 into disp_prop; all users changed.
4958
4959 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4960 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4961 for the text covered by the display property.
4962
e4ed06f1
CY
49632011-08-25 Chong Yidong <cyd@stupidchicken.com>
4964
4965 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4966 Change return value to nil.
4967 (Frecord_buffer): Delete unused function.
4968
f67cdd7f
EZ
49692011-08-24 Eli Zaretskii <eliz@gnu.org>
4970
5980d4c6
EZ
4971 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4972 buffers, return left-to-right.
8610fe8b
EZ
4973 (set_cursor_from_row): Consider candidate row a win if its glyph
4974 represents a newline and point is on that newline. Fixes cursor
4975 positioning on the newline at EOL of R2L text within L2R
4976 paragraph, and vice versa.
4977 (try_cursor_movement): Check continued rows, in addition to
4978 continuation rows. Fixes unwarranted scroll when point enters a
4979 continued line of R2L text within an L2R paragraph, or vice versa.
4980 (cursor_row_p): Consider the case of point being equal to
4981 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4982 from the end of a short line to the beginning of a continued line
4983 of R2L text within L2R paragraph.
4984 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4985 composed characters.
5980d4c6 4986
f67cdd7f
EZ
4987 * bidi.c (bidi_check_type): Use xassert.
4988 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4989 members.
4990
bca633fb
EZ
49912011-08-23 Eli Zaretskii <eliz@gnu.org>
4992
4993 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4994 a character.
4995
4a5885a7
CY
49962011-08-23 Chong Yidong <cyd@stupidchicken.com>
4997
4998 * nsfont.m (ns_otf_to_script): Fix typo.
4999
0902a04e
KH
50002011-08-22 Kenichi Handa <handa@m17n.org>
5001
5002 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5003 extra slot even if the purpose is char-code-property-table.
5004
1a2e6670
EZ
50052011-08-23 Eli Zaretskii <eliz@gnu.org>
5006
8ddde651
EZ
5007 * xdisp.c (redisplay_window): When computing centering_position,
5008 account for the height of the header line. (Bug#8874)
5009
425cc014
EZ
5010 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5011 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5012 candidate is selected by the mouse, and that candidate has a
5013 composed character under the mouse.
5014
1a2e6670
EZ
5015 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5016 coordinates reported by pos-visible-in-window-p for a composed
5017 character in column zero.
5018
8b76d6f8
SM
50192011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5020
5021 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5022
dac347dd
EZ
50232011-08-22 Eli Zaretskii <eliz@gnu.org>
5024
5025 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5026 consider it a hit if to_charpos is anywhere in the range of the
5027 composed buffer positions.
5028
e013fb34
CY
50292011-08-22 Chong Yidong <cyd@stupidchicken.com>
5030
5031 * image.c (gif_load): Don't assume that each subimage has the same
5032 dimensions as the base image. Handle disposal method that is
5033 "undefined" by the gif spec (Bug#9335).
5034
bd1ba3e8
CY
50352011-08-20 Chong Yidong <cyd@stupidchicken.com>
5036
5037 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5038 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5039
54a1215b
EZ
50402011-08-19 Eli Zaretskii <eliz@gnu.org>
5041
823564e5
EZ
5042 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5043 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5044 from an Org mode buffer to a Speedbar frame.
5045
54a1215b
EZ
5046 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5047 a composition, take its buffer position from IT->cmp_it.charpos.
5048 Fixes cursor positioning at the beginning of a line that begins
5049 with a composed character.
5050
9778ebcc
EZ
50512011-08-18 Eli Zaretskii <eliz@gnu.org>
5052
0be6ee06
EZ
5053 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5054 character bidirectional type, use STRONG_L instead. Fixes crashes
5055 in a buffer produced by `describe-categories'.
5056
9778ebcc
EZ
5057 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5058 members before the level stack, so they would be saved and
5059 restored when copying iterator state. Fixes incorrect reordering
5060 around TABs covered by display properties.
5061
156bffbe
AS
50622011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5063
6b02f655 5064 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5065
72ad093b
CY
50662011-08-17 Chong Yidong <cyd@stupidchicken.com>
5067
5068 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5069 (internal_condition_case_2, internal_condition_case_n):
5070 Remove unnecessary aborts (Bug#9081).
72ad093b 5071
35774242
EZ
50722011-08-17 Eli Zaretskii <eliz@gnu.org>
5073
5074 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5075 has no `load' handler, try opening the file locally. (Bug#9311)
5076
db76dd85
KB
50772011-08-16 Ken Brown <kbrown@cornell.edu>
5078
5079 * gmalloc.c: Expand comment.
5080
b215eee5
EZ
50812011-08-16 Eli Zaretskii <eliz@gnu.org>
5082
5083 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5084 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5085
a4579d33
KB
50862011-08-16 Ken Brown <kbrown@cornell.edu>
5087
5088 Fix memory allocation problems in Cygwin build (Bug#9273).
5089
5090 * unexcw.c ( __malloc_initialized): Declare external variable.
5091 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5092
8b76d6f8
SM
5093 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5094 New variables.
a4579d33
KB
5095 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5096 dumped emacs.
5097 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5098 in the static heap.
5099 [CYGWIN] (special_realloc): New function.
5100 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5101 requests to realloc storage in the static heap.
5102
3ebec551
PE
51032011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5104
5105 * bidi.c (bidi_initialize): Remove unused local.
5106
9fd8be00
EZ
51072011-08-15 Eli Zaretskii <eliz@gnu.org>
5108
6b02f655
SM
5109 * bidimirror.h:
5110 * biditype.h: Remove file.
5111 * makefile.w32-in ($(BLD)/bidi.$(O)):
5112 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5113
5114 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5115
5116 * chartab.c: Improve commentary for the uniprop_table API.
5117
32413314
EZ
5118 * bidi.c (bidi_paragraph_init): Support zero value of
5119 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5120 (bidi_initialize): Use uniprop_table instead of including
5121 biditype.h and bidimirror.h.
32413314 5122
9fd8be00
EZ
5123 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5124 coordinates of the iterator when restoring from ppos_it.
5125 (Bug#9296)
5126
5cf2b69b
KH
51272011-08-14 Kenichi Handa <handa@m17n.org>
5128
5129 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5130 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5131
daf17d00
EZ
51322011-08-14 Eli Zaretskii <eliz@gnu.org>
5133
5134 * xdisp.c (move_it_in_display_line_to): Don't invoke
5135 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5136 ppos_it. Fixes vertical cursor motion when line beginning is
5137 covered by an image. (Bug#9296)
5138
08e3161a
JD
51392011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5140
5141 * nsterm.h (ns_run_ascript): Declare.
5142 (NSAPP_DATA2_RUNASSCRIPT): Define.
5143
5144 * nsfns.m (as_script, as_result, as_status): New static variables.
5145 (ns_run_ascript): New function.
5e617bc2 5146 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5147 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5148 the event loop. Get status from as_status (Bug#7276).
5149
5150 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5151 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5152 the event loop (Bug#7276).
5153
a3720aa2
AS
51542011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5155
5156 * gnutls.c (QCgnutls_bootprop_priority)
5157 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5158 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5159 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5160 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5161 (QCgnutls_bootprop_verify_hostname_error)
5162 (QCgnutls_bootprop_callbacks_verify): Rename from
5163 Qgnutls_bootprop_..., all uses changed.
5164
5165 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5166 uses changed.
5167
0a0d27fb
PE
51682011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5169
19d5c50c
PE
5170 * xfaces.c (Qframe_set_background_mode): Now static.
5171 * dispextern.h (Qframe_set_background_mode): Remove decl.
5172
0a0d27fb
PE
5173 * process.c (Fnetwork_interface_info): Declare local only if needed.
5174
377538cb
JD
51752011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5176
5177 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5178 (Fnetwork_interface_list): Allocate in increments of bytes instead
5179 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5180 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5181 sockaddr.
5182 (struct ifflag_def): notrailers is smart on OSX.
5183 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5184 Get hardware address with getifaddrs if available.
5185
08fff70c
EZ
51862011-08-12 Eli Zaretskii <eliz@gnu.org>
5187
5188 * xdisp.c (iterate_out_of_display_property): xassert that
5189 IT->position is set to within IT->object's boundaries. Break from
5190 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5191 when IT->position is set up wrongly due to some bug.
5192 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5193 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5194 entry. Force push_it to save on the stack the current
5195 buffer/string position, to be restored by pop_it. Fix flags in
5196 the iterator structure wrt the object coming from a display
5197 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5198 properties. (Bug#9284)
5199
7be1c708 52002011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5201
7be1c708
CY
5202 * fontset.c (fontset_get_font_group): Add proper type checks.
5203 (Bug#9172)
aac0c6e3 5204
7be1c708 52052011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5206
7be1c708
CY
5207 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5208 and LC_VERSION_MIN_MACOSX.
5209 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5210 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5211
97bb72a6
EZ
52122011-08-08 Eli Zaretskii <eliz@gnu.org>
5213
5214 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5215 no-display-properties-and-no-overlays under bidi display.
5216 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5217 properties and overlays.
97bb72a6 5218
d5617611
CY
52192011-08-08 Chong Yidong <cyd@stupidchicken.com>
5220
37e11a63
CY
5221 * editfns.c (Fset_time_zone_rule): Document relationship with the
5222 setenv function.
5223
d5617611
CY
5224 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5225 the font entity extracted from the cache (Bug#8109).
5226
58872834
CY
52272011-08-07 Chong Yidong <cyd@stupidchicken.com>
5228
5229 * composite.c (autocmp_chars): Don't reset point. That is done by
5230 restore_point_unwind (Bug#5984).
5231
75bfc667
JL
52322011-08-07 Juri Linkov <juri@jurta.org>
5233
5234 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5235 to show the arg `TIME' instead of `TIMEVAL'.
5236
d1410150
EZ
52372011-08-06 Eli Zaretskii <eliz@gnu.org>
5238
5239 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5240 display property strides EOL and includes a newline, as in
5241 longlines-mode. (Bug#9254)
75b771e4
EZ
5242 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5243 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5244
5245 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5246 is non-zero, even if the data buffer is NULL. Fixes a crash in
5247 vertical-motion with longlines-mode. (Bug#9254)
5248
35928349
EZ
52492011-08-05 Eli Zaretskii <eliz@gnu.org>
5250
ec7cc85b
EZ
5251 * bidi.c <bidi_cache_total_alloc>: Now static.
5252 (bidi_initialize): Initialize bidi_cache_total_alloc.
5253
8b76d6f8 5254 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5255 cache. (Bug#9221)
5256
5257 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5258 amount allocated this far in `bidi_cache_total_alloc'.
5259 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5260 non-zero, only free the data buffer without restoring the cache
5261 contents. All callers changed.
5262
5263 * dispextern.h (bidi_unshelve_cache): Update prototype.
5264
5265 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5266 (move_it_in_display_line, move_it_to)
5267 (move_it_vertically_backward, move_it_by_lines): Replace the call
5268 to xfree to an equivalent call to bidi_unshelve_cache.
5269 (move_it_in_display_line_to): Fix logic of returning
412b6358 5270 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5271
e2e2423b
EZ
52722011-08-05 Eli Zaretskii <eliz@gnu.org>
5273
5274 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5275 came from a string character with a `cursor' property. (Bug#9229)
5276
ae9e757a
JD
52772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5278
5279 * Makefile.in (LIB_PTHREAD): New variable.
5280 (LIBES): Add LIB_PTHREAD (Bug#9216).
5281
5282 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5283 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5284
213bd7f2
AS
52852011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5286
6b02f655 5287 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5288
99aaf75f
JD
52892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5290
5291 * xterm.c (x_find_topmost_parent): New function.
5292 (x_set_frame_alpha): Find topmost parent window with
5293 x_find_topmost_parent and set the property there also (bug#9181).
5294 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5295
c74e9d86
PE
52962011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 * callproc.c (Fcall_process): Avoid vfork clobbering
5299 the local vars buffer, coding_systems, current_dir.
5300
640c8776
SM
53012011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5302
5303 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5304
f26d0e4c
PE
53052011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5306
8a10d76c
PE
5307 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5308 so that it is not optimized away.
5309
f26d0e4c
PE
5310 * xdisp.c (compute_display_string_pos): Remove unused local.
5311
55439c61
EZ
53122011-08-02 Eli Zaretskii <eliz@gnu.org>
5313
5314 Fix slow cursor motion and scrolling in large buffers with
5315 selective display, like Org Mode buffers. (Bug#9218)
5316
5317 * dispextern.h (struct bidi_it): New member disp_prop_p.
5318
5319 * xdisp.c: Remove one-slot cache of display string positions.
5320 (compute_display_string_pos): Accept an additional argument
5e617bc2 5321 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5322 for a display string or property. If found, set DISP_PROP_P
5323 non-zero.
5324
5325 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5326 DISP_PROP_P, and pass it to compute_display_string_pos.
5327 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5328 non-zero. All callers of bidi_fetch_char changed.
5329
fb33fa43
SM
53302011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5331
5332 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5333
b099e063
DM
53342010-12-03 Don March <don@ohspite.net>
5335
5336 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5337 last character M-[char] is translated to ESC [char] (bug#7541).
5338
5cc7f7af
KH
53392011-08-02 Kenichi Handa <handa@m17n.org>
5340
d0fffa3f 5341 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5342
5343 * chartab.c (uniprop_table): Make it non-static.
5344
525d5e6e
EZ
53452011-08-01 Eli Zaretskii <eliz@gnu.org>
5346
5347 * xdisp.c (forward_to_next_line_start): Accept additional argument
5348 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5349 on the newline.
5350 (reseat_at_next_visible_line_start): Use the bidi iterator state
5351 returned by forward_to_next_line_start to restore the state of
5352 it->bidi_it after backing up to previous newline. (Bug#9212)
5353
31011111
AS
53542011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5355
5356 * regex.c (re_comp): Protoize.
5357 (re_exec): Fix return type.
5358 (regexec): Fix type of `ret'. (Bug#9203)
5359
476371c4
PE
53602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5361
e5d76069
PE
5362 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5363 This is needed if max-image-size is a floating-point number.
5364
9a79b20c
AS
53652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5366
5367 * print.c (print_object): Print empty symbol as ##.
5368
5369 * lread.c (read1): Read ## as empty symbol.
5370
d8c2fa78
AA
53712011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5372
5373 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5374 setting frame foreground color (Bug#9175).
5375 (x_set_background_color): Likewise.
5376
ffe57a7a
AA
5377 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5378 contents (Bug#9176).
5379 (EmacsTooltip -init): Remove bezels and add shadows to
5380 tooltip windows.
5381
bf3492a5
AA
5382 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5383 or scroll bar (Bug#8470).
5384
d55e9c53
AA
5385 * nsfont.m (nsfont_open): Remove assignment to voffset and
5386 unnecessary vars hshink, expand, hd, full_height, min_height.
5387 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5388
5389 * nsterm.h (nsfont_info): Remove voffset field.
5390
d8c2fa78 53912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5392
5393 Implement strike-through and overline on NextStep (Bug#8863).
5394
5395 * nsfont.m (nsfont_open): Use underline position provided by font,
5396 instead of hard-coded value of 2.
5397 (nsfont_draw): Call ns_draw_text_decoration instead.
5398
5399 * nsterm.h: Add declaration for ns_draw_text_decoration.
5400
5401 * nsterm.m (ns_draw_text_decoration): New function for drawing
5402 underline, overline, and strike-through.
5403 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5404 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5405 accommodate underlining, etc.
4843aac3 5406
4cc60b9b
EZ
54072011-07-28 Eli Zaretskii <eliz@gnu.org>
5408
bc7ece87
EZ
5409 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5410 default.
4cc60b9b 5411
476371c4
PE
54122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5413
66606eea
PE
5414 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5415 Without this fix, if a signal arrives just after memory fills up,
5416 'malloc' might be invoked reentrantly.
5417
476371c4
PE
5418 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5419 In other words, assume that every image size is allowed, on non-X
5420 hosts. This assumption is probably wrong, but it lets Emacs compile.
5421
f3fcc40d
AS
54222011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5423
5424 * regex.c (re_iswctype): Convert return values to boolean.
5425
350c992f
EZ
54262011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5427
5428 * xdisp.c (compute_display_string_pos): Don't use cached display
5429 string position if the buffer had its restriction changed.
5430 (Bug#9184)
5431
5266b4bb
PE
54322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5433
5434 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5435
2573a837 54362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5437
41f55ccd 5438 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5439
39e378da
PE
5440 * bidi.c: Integer size and overflow fixes.
5441 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5442 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5443 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5444 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5445 (bidi_find_other_level_edge):
5446 Use ptrdiff_t instead of EMACS_INT where either will do.
5447 This works better on 32-bit hosts configured --with-wide-int.
5448 (bidi_cache_ensure_space): Check for size-calculation overflow.
5449 Use % rather than repeated addition, for better worst-case speed.
5450 Don't set bidi_cache_size until after xrealloc returns, because it
5451 might not return.
5452 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5453 (bidi_cache_ensure_space): Also check that the bidi cache size
5454 does not exceed that of the largest Lisp string or buffer. See Eli
5455 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5456
5e927815
PE
5457 * alloc.c (__malloc_size_t): Remove.
5458 All uses replaced by size_t. See Andreas Schwab's note
5459 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5460
ca4aa935
PE
5461 * image.c: Improve checking for integer overflow.
5462 (check_image_size): Assume that f is nonnull, since
5463 it is always nonnull in practice. This is one less thing to
5464 worry about when checking for integer overflow later.
5465 (x_check_image_size): New function, which checks for integer
5466 overflow issues inside X.
5467 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5468 This removes the need for a memory_full check.
5469 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5470 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5471 (xbm_read_bitmap_data): Change locals back to 'int', since
5472 their values must fit in 'int'.
5473 (xpm_load_image, png_load, tiff_load):
5474 Invoke x_create_x_image_and_pixmap earlier,
5475 to avoid much needless work if the image is too large.
5476 (tiff_load): Treat overly large images as if
5477 x_create_x_image_and_pixmap failed, not as malloc failures.
5478 (gs_load): Use x_check_image_size.
5479
5f8f9cc2
PE
5480 * gtkutil.c: Omit integer casts.
5481 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5482 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5483
5adf60bc
PE
5484 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5485
c8907a93
PE
5486 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5487 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5488 would wrongly return t on a 64-bit host.
5489
e3c25c68
PE
5490 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5491 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5492 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5493 and therefore cause GCC to emit a bogus diagnostic in some cases.
5494
3f791afe
PE
5495 * image.c: Integer signedness and overflow and related fixes.
5496 This is not an exhaustive set of fixes, but it's time to
5497 record what I've got.
5498 (lookup_pixel_color, check_image_size): Remove redundant decls.
5499 (check_image_size): Don't assume that arbitrary EMACS_INT values
5500 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5501 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5502 (tiff_load, imagemagick_load_image):
5503 Check for overflow in size calculations.
5504 (x_create_x_image_and_pixmap): Remove unnecessary test for
5505 xmalloc returning NULL; that can't happen.
5506 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5507 (xpm_color_bucket): Use better integer hashing function.
5508 (xpm_cache_color): Don't possibly over-allocate memory.
5509 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5510 (gif_memory_source):
5511 Use ptrdiff_t, not int or size_t, to record sizes.
5512 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5513 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5514 either works, as we prefer signed integers.
5515 (tiff_read_from_memory, tiff_write_from_memory):
5516 Return tsize_t, not size_t, since that's what the TIFF API wants.
5517 (tiff_read_from_memory): Don't fail simply because the read would
5518 go past EOF; instead, return a short read.
5519 (tiff_load): Omit no-longer-needed casts.
5520 (Fimagemagick_types): Don't assume size fits into 'int'.
5521
3cc5a532
PE
5522 Improve hashing quality when configured --with-wide-int.
5523 * fns.c (hash_string): New function, taken from sxhash_string.
5524 Do not discard information about ASCII character case; this
5525 discarding is no longer needed.
5526 (sxhash-string): Use it. Change sig to match it. Caller changed.
5527 * lisp.h: Declare it.
5528 * lread.c (hash_string): Remove, since we now use fns.c's version.
5529 The fns.c version returns a wider integer if --with-wide-int is
5530 specified, so this should help the quality of the hashing a bit.
5531
b312a492
PE
5532 * emacs.c: Integer overflow minor fix.
5533 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5534 Define only if GNU_LINUX.
5535 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5536
dfd153ae
PE
5537 * dispnew.c: Integer signedness and overflow fixes.
5538 Remove unnecessary forward decls, that were a maintenance hassle.
5539 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5540 All uses changed.
5541 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5542 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5543 (prepare_desired_row, line_draw_cost):
5544 Use int, not unsigned, where either works.
5545 (save_current_matrix, restore_current_matrix):
5546 Use ptrdiff_t, not size_t, where either works.
5547 (init_display): Check for overflow more accurately, and without
5548 relying on undefined behavior.
5549
a81d11a3
PE
5550 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5551 Remove, replacing with the new symbols in lisp.h. All uses changed.
5552 * fileio.c (make_temp_name):
5553 * filelock.c (lock_file_1, lock_file):
5554 * xdisp.c (message_dolog):
5555 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5556 Use pMd etc. instead.
5557 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5558 replacing the pWIDE etc. symbols removed from editfns.c.
5559
3300e6fd
PE
5560 * keyboard.h (num_input_events): Now uintmax_t.
5561 This is (very slightly) less likely to mess up due to wraparound.
5562 All uses changed.
5563
fd05c7e9
PE
5564 * buffer.c: Integer signedness fixes.
5565 (alloc_buffer_text, enlarge_buffer_text):
5566 Use ptrdiff_t rather than size_t when either will do, as we prefer
5567 signed integers.
5568
903fe15d
PE
5569 * alloc.c: Integer signedness and overflow fixes.
5570 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5571 (__malloc_size_t): Default to size_t, not to int.
5572 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5573 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5574 Prefer ptrdiff_t to size_t when either would do, as we prefer
5575 signed integers.
5576 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5577 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5578 Now const. Initialize with values that are in range even if char
5579 is signed.
5580 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5581 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5582 These functions do the right thing with sizes > 2**32.
5583 (check_depth): Now ptrdiff_t, not int.
5584 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5585 Adjust to new way of storing sizes. Check for size overflow bugs
5586 in rest of code.
5587 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5588 slightly wrong anyway, as it missed one instance of
5589 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5590 (refill_memory_reserve): Omit needless cast to size_t.
5591 (mark_object_loop_halt): Mark as externally visible.
5592
ac82cc6a
PE
5593 * xselect.c: Integer signedness and overflow fixes.
5594 (Fx_register_dnd_atom, x_handle_dnd_message):
5595 Use ptrdiff_t, not size_t, since we prefer signed.
5596 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5597 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5598 x_dnd_atoms_size and x_dnd_atoms_length.
5599
c2d1e36d
PE
5600 * doprnt.c: Prefer signed to unsigned when either works.
5601 * eval.c (verror):
5602 * doprnt.c (doprnt):
5603 * lisp.h (doprnt):
5604 * xdisp.c (vmessage):
5605 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5606 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5607 prefer signed arithmetic to avoid comparison confusion.
5608 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5609 but is a bit tricky.
5610
0e926e56
PE
5611 Assume freestanding C89 headers, string.h, stdlib.h.
5612 * data.c, doprnt.c, floatfns.c, print.c:
5613 Include float.h unconditionally.
5614 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5615 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5616 * regex.c: Likewise for stddef.h, string.h.
5617 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5618 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5619 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5620 (STDC_HEADERS): Remove obsolete defines.
5621 * sysdep.c: Include limits.h unconditionally.
5622
9cfdb3ec
PE
5623 Assume support for memcmp, memcpy, memmove, memset.
5624 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5625 * regex.c (memcmp, memcpy):
5626 Remove; we assume C89 now.
5627
5628 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5629 (__malloc_safe_bcopy): Remove; no longer needed.
5630
cf950e6b 5631 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5632 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5633 well either way, and we prefer signed to unsigned.
5634
dbf38e02
LMI
56352011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5636
5637 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5638 closes the connection while we're reading (bug#9182).
5639
d6f0886c 56402011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5641
d6f0886c
JD
5642 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5643 are specified (Bug#9168).
24e0f6b1 5644
2eb1f9e6
PE
56452011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5646
5647 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5648 Found by GCC static checking and --with-wide-int on a 32-bit host.
5649
22381272 56502011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5651
5652 * xdisp.c (compute_display_string_pos): Fix logic of caching
5653 previous display string position. Initialize cached_prev_pos to
5654 -1. Fixes slow-down at the beginning of a buffer.
5655
f25e39b4
EZ
56562011-07-24 Eli Zaretskii <eliz@gnu.org>
5657
5658 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5659 for attrs[LFACE_FONTSET_INDEX].
5660
04c4b52e
PE
56612011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5662
5663 * xml.c (parse_region): Remove unused local
5664 that was recently introduced.
5665
c1734fbd
EZ
56662011-07-23 Eli Zaretskii <eliz@gnu.org>
5667
be18c5a5
EZ
5668 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5669 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5670
c1734fbd
EZ
5671 * xdisp.c (move_it_in_display_line_to): Record the best matching
5672 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5673 exit if none of the characters scanned was an exact match.
5674 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5675 when exact match is impossible due to invisible text, and the
5676 lines are truncated.
5677
a258d627
JD
56782011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5679
5680 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5681 for OSX >= 10.7.
5682
b6d5a689
EZ
56832011-07-22 Eli Zaretskii <eliz@gnu.org>
5684
0f74f785
EZ
5685 Fix a significant slow-down of cursor motion with C-n, C-p,
5686 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5687 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5688 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5689 (next_element_from_buffer): Call compute_stop_pos_backwards to
5690 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5691 base_level_stop.
5692 (reseat): Don't look for prev_stop, as that could mean a very long
5693 run.
5694 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5695 <cached_disp_overlay_modiff>: Cache for last found display string
5696 position.
551918c1 5697 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5698 about the same buffer in the same area of character positions, and
5699 the buffer wasn't changed since the time the display string
5700 position was cached.
551918c1 5701
b2d0c91a
EZ
57022011-07-22 Eli Zaretskii <eliz@gnu.org>
5703
5704 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5705 is an integer, which is important for empty lines. (Bug#9149)
5706
043604ee
CY
57072011-07-22 Chong Yidong <cyd@stupidchicken.com>
5708
5709 * frame.c (Fmodify_frame_parameters): In tty case, update the
5710 default face if necessary (Bug#4238).
5711
da4adb04
CY
57122011-07-21 Chong Yidong <cyd@stupidchicken.com>
5713
5714 * editfns.c (Fstring_to_char): No need to explain what a character
5715 is in the docstring (Bug#6576).
5716
9abd0532
LMI
57172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5718
5719 * xml.c (parse_region): Make sure we always return a tree.
5720
36881d16
HK
57212011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5722
5723 * xml.c (parse_region): If a document contains only comments,
5724 return that, too.
5725
1e98674d
LMI
57262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5727
5728 * xml.c (make_dom): Return comments, too.
5729
590bd467
PE
57302011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5731
5732 Port to OpenBSD.
5733 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5734 and the surrounding thread.
5735 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5736 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5737 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5738 timer goes off.
5739 * s/openbsd.h (BROKEN_SIGIO): Define.
5740 * unexelf.c (unexec) [__OpenBSD__]:
5741 Don't update the .mdebug section of the Alpha COFF symbol table.
5742
f41628b2
LMI
57432011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5744
5745 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5746 (bug#8460).
5747
b59b67c5
PE
57482011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5749
15e3a074
PE
5750 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5751 This fixes some race conditions on the permissions of any newly
5752 created file.
5753
41bed37d
PE
5754 * alloc.c (valid_pointer_p): Use pipe, not open.
5755 This fixes some permissions issues when debugging.
5756
b59b67c5
PE
5757 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5758 If fchown fails to set both uid and gid, try to set just gid,
5759 as that is sometimes allowed. Adjust the file's mode to eliminate
5760 setuid or setgid bits that are inappropriate if fchown fails.
5761
925a6be7
SM
57622011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5763
5764 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5765 to compare Lisp_Objects.
5766 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5767 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5768 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5769
52968808
AS
57702011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5771
0a6a104b
AS
5772 * lread.c (read_integer): Unread even EOF character.
5773 (read1): Likewise. Properly record start position of symbol.
5774
52968808
AS
5775 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5776 symbol character follows.
5777
9e381cdd
PE
57782011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5779
5780 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5781 This works around a problem with the previous change to Fcopy_file.
5782 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5783 and without this change, GCC might complain about discarding
5784 fchown's return value.
5785
b5641435
JB
57862011-07-16 Juanma Barranquero <lekktu@gmail.com>
5787
5788 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5789
a8031457
PE
57902011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5791
5792 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5793
dd889327
LMI
57942011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5795
750c33f7
LMI
5796 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5797 it's used from the C level.
5798
dd889327
LMI
5799 * process.c: Use the same condition for POLL_FOR_INPUT in both
5800 keyboard.c and process.c (bug#1858).
5801
87e86684
LM
58022011-07-09 Lawrence Mitchell <wence@gmx.li>
5803
5804 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5805 (Fgnutls_boot): Use it.
5806
64348f40
AS
58072011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5808
5809 * doc.c (Fsubstitute_command_keys): Revert last change.
5810
1d698799
LMI
58112011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5812
f863868c
LMI
5813 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5814 quotes the next character, and doesn't affect other longer
5815 sequences (bug#8935).
5816
1d698799
LMI
5817 * lread.c (syms_of_lread): Clarify that is isn't only
5818 `eval-buffer' and `eval-defun' that's affected by
5819 `lexical-binding' (bug#8460).
5820
aa4b6df6
EZ
58212011-07-15 Eli Zaretskii <eliz@gnu.org>
5822
5823 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5824 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5825
5d856da6
PE
58262011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5827
ad6042bb
PE
5828 Fix minor problems found by static checking.
5829 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5830 (elsz): Now a signed constant, not a size_t var. We prefer signed
5831 types to unsigned, to avoid integer comparison confusion. Without
5832 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5833 "cannot optimize loop, the loop counter may overflow", a symptom
5834 of the confusion.
f00bbb22 5835 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5836 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5837
6468f31c
LMI
58382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5839
49080b10
LMI
5840 * search.c (Fre_search_backward): Mention `case-fold-search' in
5841 all the re_search_* functions (bug#8138).
5842
6468f31c
LMI
5843 * keyboard.c (Fopen_dribble_file): Document when the file is
5844 closed (bug#8056).
5845
c965adc5
EZ
58462011-07-14 Eli Zaretskii <eliz@gnu.org>
5847
df9733bf
EZ
5848 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5849 bidi_cache_idx.
5850
0bb23927
EZ
5851 Support bidi reordering of display and overlay strings.
5852 * xdisp.c (compute_display_string_pos)
5853 (compute_display_string_end): Accept additional argument STRING.
5854 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5855 (reseat_to_string): Initialize bidi_it->string.s and
5856 bidi_it->string.schars.
5857 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5858 NULL (avoids a crash in bidi_paragraph_init).
5859 Initialize itb.string.lstring.
0bb23927
EZ
5860 (init_iterator): Call bidi_init_it only of a valid
5861 buffer position was specified. Initialize paragraph_embedding to
5862 L2R.
5863 (reseat_to_string): Initialize the bidi iterator.
5864 (display_string): If we need to ignore text properties of
5865 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5866 original value of -1 will not work with bidi.)
5867 (compute_display_string_pos): First arg is now struct
5868 `text_pos *'; all callers changed. Support display properties on
5869 Lisp strings.
5870 (compute_display_string_end): Support display properties on Lisp
5871 strings.
5872 (init_iterator, reseat_1, reseat_to_string): Initialize the
5873 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5874 when iterating on a string not from display properties).
640c8776
SM
5875 (compute_display_string_pos, compute_display_string_end):
5876 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5877 arrow keys.
5878 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5879 base_level_stop; instead, set base_level_stop to BEGV.
5880 Fixes crashes in vertical-motion.
0bb23927
EZ
5881 (next_element_from_buffer): Improve commentary for when
5882 the iterator is before prev_stop.
5883 (init_iterator): Initialize bidi_p from the default value of
5884 bidi-display-reordering, not from buffer-local value. Use the
5885 buffer-local value only if initializing for buffer iteration.
5886 (handle_invisible_prop): Support invisible properties on strings
5887 that are being bidi-reordered.
5888 (set_iterator_to_next): Support bidi reordering of C strings and
5889 Lisp strings.
5890 (next_element_from_string): Support bidi reordering of Lisp
5891 strings.
5892 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5893 (display_string): Support display of R2L glyph rows.
5894 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5895 (init_iterator): Don't initialize it->bidi_p for strings
5896 here.
5897 (reseat_to_string): Initialize it->bidi_p for strings here.
5898 (next_element_from_string, next_element_from_c_string)
5899 (next_element_from_buffer): Add xassert's for correspondence
5900 between IT's object being iterated and it->bidi_it.string
5901 structure.
5902 (face_before_or_after_it_pos): Support bidi iteration.
5903 (next_element_from_c_string): Handle the case of the first string
5904 character that is not the first one in the visual order.
5905 (get_visually_first_element): New function, refactored from common
5906 parts of next_element_from_buffer, next_element_from_string, and
5907 next_element_from_c_string.
5908 (tool_bar_lines_needed, redisplay_tool_bar)
5909 (display_menu_bar): Force left-to-right direction. Add a FIXME
5910 comment for making that be controlled by a user option.
5911 (push_it, pop_it): Save and restore the state of the
5912 bidi iterator. Save and restore the bidi_p flag.
5913 (pop_it): Iterate out of display property for string iteration as
5914 well.
5915 (iterate_out_of_display_property): Support iteration over strings.
5916 (handle_single_display_spec): Set up it->bidi_it for iteration
5917 over a display string, and call bidi_init_it.
5918 (handle_single_display_spec, next_overlay_string)
5919 (get_overlay_strings_1, push_display_prop): Set up the bidi
5920 iterator for displaying display or overlay strings.
5921 (forward_to_next_line_start): Don't use the shortcut if
5922 bidi-iterating.
5923 (back_to_previous_visible_line_start): If handle_display_prop
5924 pushed the iterator stack, restore the internal state of the bidi
5925 iterator by calling bidi_pop_it same number of times.
5926 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5927 and we are bidi-iterating, don't decrement the iterator position;
5928 instead, set the first_elt flag in the bidi iterator, to produce
5929 the same effect.
5930 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5931 (push_display_prop): xassert that we are iterating a buffer.
5932 (push_it, pop_it): Save and restore paragraph_embedding member.
5933 (handle_single_display_spec, next_overlay_string)
5934 (get_overlay_strings_1, reseat_1, reseat_to_string)
5935 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5936 correctly. Don't assume unibyte strings are not bidi-reordered.
5937 (compute_display_string_pos)
5938 (compute_display_string_end): Fix handling the case of C string.
5939 (push_it, pop_it): Save and restore from_disp_prop_p.
5940 (handle_single_display_spec, push_display_prop): Set the
5941 from_disp_prop_p flag.
5942 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5943 (pop_it): Call iterate_out_of_display_property only if we are
5944 popping after iteration over a string that came from a display
5945 property. Fix a typo in popping stretch info. Add an assertion
5946 for verifying that the iterator position is in sync with the bidi
5947 iterator.
5948 (handle_single_display_spec, get_overlay_strings_1)
5949 (push_display_prop): Fix initialization of paragraph direction for
5950 string when that of the parent object is not yet determined.
5951 (reseat_1): Call bidi_init_it to resync the bidi
5952 iterator with IT's position. (Bug#7616)
5953 (find_row_edges): If ROW->start.pos gives position
5954 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5955 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5956 Reset the from_disp_prop_p flag.
5957 (SAVE_IT, RESTORE_IT): New macros.
5958 (pos_visible_p, face_before_or_after_it_pos)
5959 (back_to_previous_visible_line_start)
5960 (move_it_in_display_line_to, move_it_in_display_line)
5961 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5962 (try_scrolling, redisplay_window, display_line): Use them when
5963 saving a temporary copy of the iterator and restoring it back.
5964 (back_to_previous_visible_line_start, reseat_1)
5965 (init_iterator): Empty the bidi cache "stack".
5966 (move_it_in_display_line_to): If iterator ended up at
5967 EOL, but we never saw any buffer positions smaller than
5968 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5969 motion in bidi-reordered lines.
5970 (move_it_in_display_line_to): Record prev_method and prev_pos
5971 immediately before the call to set_iterator_to_next. Fixes cursor
5972 motion in bidi-reordered lines with stretch glyphs and strings
5973 displayed in margins. (Bug#8133) (Bug#8867)
5974 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5975 TO_CHARPOS.
640c8776
SM
5976 (pos_visible_p): Support positions in bidi-reordered lines.
5977 Save and restore bidi cache.
0bb23927
EZ
5978
5979 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5980 (bidi_paragraph_info): Delete unused struct.
5981 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5982 (bidi_cache_start): New variable.
5983 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5984 to zero.
5985 (bidi_cache_fetch_state, bidi_cache_search)
5986 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5987 (bidi_cache_find, bidi_peek_at_next_level)
5988 (bidi_level_of_next_char, bidi_find_other_level_edge)
5989 (bidi_move_to_visually_next): Compare cache index with
5990 bidi_cache_start rather than with zero.
5991 (bidi_fetch_char): Accept new argument STRING; all callers
5992 changed. Support iteration over a string. Support strings with
5993 display properties. Support unibyte strings. Fix the type of
5994 `len' according to what STRING_CHAR_AND_LENGTH expects.
5995 (bidi_paragraph_init, bidi_resolve_explicit_1)
5996 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5997 (bidi_level_of_next_char, bidi_move_to_visually_next):
5998 Support iteration over a string.
0bb23927
EZ
5999 (bidi_set_sor_type, bidi_resolve_explicit_1)
6000 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6001 can now be zero (for strings); special values 0 and -1 were
6002 changed to -1 and -2, respectively.
6003 (bidi_char_at_pos): New function.
6004 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6005 Call it instead of FETCH_MULTIBYTE_CHAR.
6006 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6007 initialized to valid values.
6008 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6009 values.
6010 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6011 the test for valid cached positions. Fix the logic for looking up
6012 the sentinel state in the cache. GCPRO the Lisp string we are
6013 iterating.
6014 (bidi_push_it, bidi_pop_it): New functions.
6015 (bidi_initialize): Initialize the bidi cache start stack pointer.
6016 (bidi_cache_ensure_space): New function, refactored from part of
6017 bidi_cache_iterator_state. Don't assume the required size is just
6018 one BIDI_CACHE_CHUNK away.
6019 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6020 (bidi_count_bytes, bidi_char_at_pos): New functions.
6021 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6022 always valid if bidi_cache_idx is valid.
6023 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6024 is valid if it's going to be used.
6025 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6026 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6027 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6028 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6029 (bidi_find_other_level_edge, bidi_cache_start_stack):
6030 All variables related to cache indices are now EMACS_INT.
c965adc5 6031
0bb23927
EZ
6032 * dispextern.h (struct bidi_string_data): New structure.
6033 (struct bidi_it): New member `string'. Make flag members be 1-bit
6034 fields, and put them last in the struct.
640c8776
SM
6035 (compute_display_string_pos, compute_display_string_end):
6036 Update prototypes.
0bb23927
EZ
6037 (bidi_push_it, bidi_pop_it): Add prototypes.
6038 (struct iterator_stack_entry): New members bidi_p,
6039 paragraph_embedding, and from_disp_prop_p.
6040 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6041 (bidi_shelve_cache, bidi_unshelve_cache):
6042 Declare prototypes.
0bb23927
EZ
6043
6044 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6045 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6046 and vector-like objects.
6047
6048 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6049 cache around display iteration.
6050
6051 * window.c (Fwindow_end, window_scroll_pixel_based)
6052 (displayed_window_lines, Frecenter): Save and restore the bidi
6053 cache around display iteration.
6054
3bbd2265
LMI
60552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6056
6057 * editfns.c (Fdelete_region): Clarify the use of the named
6058 parameters (bug#6788).
6059
adc47434
MR
60602011-07-14 Martin Rudalics <rudalics@gmx.at>
6061
6062 * indent.c (Fvertical_motion): Set and restore w->pointm when
6063 saving and restoring the window's buffer (Bug#9006).
6064
837c31f8
LMI
60652011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6066
6067 * editfns.c (Fstring_to_char): Clarify just what is returned
6068 (bug#6576). Text by Eli Zaretskii.
6069
ac389d0c
JB
60702011-07-13 Juanma Barranquero <lekktu@gmail.com>
6071
6072 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6073
0be0ce47
EZ
60742011-07-13 Eli Zaretskii <eliz@gnu.org>
6075
6076 * buffer.c (mmap_find): Fix a typo.
6077
cd18e7e3
JB
60782011-07-13 Johan Bockgård <bojohan@gnu.org>
6079
6080 Fix execution of x selection hooks.
6081 * xselect.c (Qx_lost_selection_functions)
6082 (Qx_sent_selection_functions): New vars.
6083 (syms_of_xselect): DEFSYM them.
6084 (x_handle_selection_request): Pass Qx_sent_selection_functions
6085 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6086 (x_handle_selection_clear,x_clear_frame_selections):
6087 Pass Qx_lost_selection_functions rather than
6088 Vx_lost_selection_functions to Frun_hook_with_args.
6089
47ea7f44
PE
60902011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6091
ac389d0c 6092 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6093 The old code sometimes used this field without initializing it.
6094
47ea7f44
PE
6095 * alloc.c (gc_sweep): Don't read past end of array.
6096 In theory, the old code could also have corrupted Emacs internals,
6097 though it'd be very unlikely.
6098
bc985c87
AS
60992011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6100
6101 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6102 argument. (Bug#4026)
bc985c87 6103
0cf34688
LMI
61042011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6105
b3dadd76
LMI
6106 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6107 key" (bug#4257).
6108
0cf34688
LMI
6109 * window.c (Fset_window_start): Doc fix (bug#4199).
6110 (Fset_window_hscroll): Ditto.
6111
270768cd
PE
61122011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6113
077e3dda 6114 Fix minor new problems caught by GCC 4.6.1.
270768cd 6115 * term.c (init_tty): Remove unused local.
490011a6 6116 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6117 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6118 not used otherwise.
270768cd 6119
b1f58454
CY
61202011-07-12 Chong Yidong <cyd@stupidchicken.com>
6121
6122 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6123
22b9578d
LMI
61242011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6125
6e70ab07
LMI
6126 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6127 are the mini-buffer and the echo area (bug#3320).
6128
22b9578d
LMI
6129 * term.c (init_tty): Remove support for supdup, c10 and perq
6130 terminals, which are no longer supported (bug#1482).
6131
8974cc9f
JB
61322011-07-10 Johan Bockgård <bojohan@gnu.org>
6133
6134 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6135
a560d974
JD
61362011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6137
6138 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6139 for non-popups (Bug#3642).
6140
1dae0f0a
AS
61412011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6142
268c2c36 6143 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6144 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6145 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6146 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6147 * data.c (fmod): Likewise.
6148 * dispnew.c (swap_glyphs_in_rows): Likewise.
6149 * emacs.c (memory_warning_signal): Likewise.
6150 * floatfns.c (float_error): Likewise.
6151 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6152 (otf_open, font_otf_capability, generate_otf_features)
6153 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6154 Likewise.
6155 * image.c (pbm_read_file): Likewise.
6156 * indent.c (string_display_width): Likewise.
6157 * intervals.c (check_for_interval, search_for_interval)
6158 (inc_interval_count, count_intervals, root_interval)
6159 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6160 * lread.c (defalias): Likewise.
268c2c36 6161 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6162 * regex.c (set_image_of_range_1, set_image_of_range)
6163 (regex_grow_registers): Likewise.
6164 * sysdep.c (strerror): Likewise.
6165 * termcap.c (valid_filename_p, tprint, main): Likewise.
6166 * tparam.c (main): Likewise.
6167 * unexhp9k800.c (run_time_remap, save_data_space)
6168 (update_file_ptrs, read_header, write_header, calculate_checksum)
6169 (copy_file, copy_rest, display_header): Likewise.
6170 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6171 Likewise.
6172 * xdisp.c (check_it): Likewise.
6173 * xfaces.c (register_color, unregister_color, unregister_colors):
6174 Likewise.
6175 * xfns.c (print_fontset_result): Likewise.
6176 * xrdb.c (member, fatal, main): Likewise.
6177
99033785
PE
61782011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6179
6180 Fix minor problems found by static checking (Bug#9031).
6181 * chartab.c (char_table_set_range, map_sub_char_table):
6182 Remove unused locals.
6183 (uniprop_table): Now static.
6184 * composite.c (_work_char): Remove unused static var.
6185
9cb2ac56
JB
61862011-07-09 Juanma Barranquero <lekktu@gmail.com>
6187
6188 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6189
f25661f0
JD
61902011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6191
6192 * gtkutil.c (qttip_cb): Remove code without function.
6193
8278c4fe
EZ
61942011-07-09 Eli Zaretskii <eliz@gnu.org>
6195
6196 * w32.c (pthread_sigmask): New stub.
6197
1692ae2d 61982011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6199
8a6ebd58 6200 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6201 sigprocmask is portable only for single-threaded applications, and
6202 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6203 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6204 (LIBES): Use it.
6205 * callproc.c (Fcall_process):
6206 * process.c (create_process):
6207 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6208 Use pthread_sigmask, not sigprocmask.
123403e4 6209
1b854618
JD
62102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6211
6212 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6213 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6214 wrong (Bug#8591).
6215
3fe4b549
JD
62162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6217
0ce7e563
JD
6218 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6219 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6220 (xg_hide_tooltip): Fix comment.
6221
3fe4b549
JD
6222 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6223 in registerServicesMenuSendTypes.
6224 (validRequestorForSendType): Don't check ns_return_types.
6225
6226 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6227 ns_return_type.
6228
5df75e47
JR
62292011-07-08 Jason Rumney <jasonr@gnu.org>
6230
22610910
JR
6231 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6232 SH_SHOW for hidden windows (Bug#5482).
6233
5df75e47
JR
6234 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6235 frame struct members of non-existent frames (Bug#6284).
6236
699c10bd
JD
62372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6238
4393663b
JD
6239 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6240 variable firstTime not needed on OSX >= 10.6.
6241 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6242 >= 10.5. Use setKnobProportion, setDoubleValue.
6243
6244 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6245 (MAC_OS_X_VERSION_10_5): Define if not defined.
6246 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6247 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6248 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6249
6250 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6251 cString and lossyCString on OSX >= 10.4
6252
58179cce 6253 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6254 sizeToFit on OSX >= 10.2.
6255
6256 * nsimage.m (allocInitFromFile): Don't use deprecated method
6257 bestRepresentationForDevice on OSX >= 10.6.
6258
6259 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6260 to avoid warning.
6261
6262 * emacs.c: Declare unexec_init_emacs_zone.
6263
a63e0781
JD
6264 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6265
699c10bd
JD
6266 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6267
6268 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6269 on svcsMenu (Bug#8842).
6270
6271 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6272 ns_return_types.
6273 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6274
6275 * nsterm.m (QUTF8_STRING): Declare.
6276 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6277 (validRequestorForSendType): Return type is (id).
6278 Change indexOfObjectIdenticalTo to indexOfObject.
6279 Check if we have local selection before returning self (Bug#8842).
6280 (writeSelectionToPasteboard): Put local selection into paste board
6281 if we have a local selection (Bug#8842).
6282 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6283
6284 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6285 (ns_get_local_selection): Declare.
6286
54e10184
LMI
62872011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6288
9888ff71
LMI
6289 * keymap.c (describe_map_tree): Don't insert a double newline at
6290 the end of the buffer (bug#1169) and return whether we inserted
6291 something.
6292
54e10184
LMI
6293 * callint.c (Fcall_interactively): Change "reading args" to
6294 "providing args" to try to clarify what it does (bug#1010).
6295
15fa4783
KH
62962011-07-07 Kenichi Handa <handa@m17n.org>
6297
6298 * composite.c (composition_compute_stop_pos): Ignore a static
6299 composition starting before CHARPOS (Bug#8915).
6300
6301 * xdisp.c (handle_composition_prop): Likewise.
6302
a8815b00
EZ
63032011-07-07 Eli Zaretskii <eliz@gnu.org>
6304
6305 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6306 (Bug#9015)
6307
ef7b981d 63082011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6309
6310 * character.h (unicode_category_t): New enum type.
6311
6312 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6313 (Qchar_code_property_table): New variable.
6314 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6315 (UNIPROP_COMPRESSED_FORM_P): New macros.
6316 (char_table_ascii): Uncompress the compressed values.
6317 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6318 Uncompress the compressed values.
ac389d0c 6319 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6320 (char_table_ref_and_range): Uncompress the compressed values.
6321 (sub_char_table_set): New arg is_uniprop. Callers changed.
6322 Uncompress the compressed values.
6323 (sub_char_table_set_range): Args changed. Callers changed.
6324 (char_table_set_range): Adjuted for the above change.
6325 (map_sub_char_table): Delete args default_val and parent. Add arg
6326 top. Give decoded values to a Lisp function.
640c8776 6327 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6328 values to a Lisp function. Gcpro more variables.
6329 (uniprop_table_uncompress)
6330 (uniprop_decode_value_run_length): New functions.
6331 (uniprop_decoder, uniprop_decoder_count): New variables.
6332 (uniprop_get_decoder, uniprop_encode_value_character)
6333 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6334 New functions.
6335 (uniprop_encoder, uniprop_encoder_count): New variables.
6336 (uniprop_get_encoder, uniprop_table)
6337 (Funicode_property_table_internal, Fget_unicode_property_internal)
6338 (Fput_unicode_property_internal): New functions.
6339 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6340 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6341 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6342 char-code-property-alist.
6343
640c8776 6344 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6345 Vunicode_category_table.
6346
640c8776 6347 * font.c (font_range): Adjust for the change of
c805dec0
KH
6348 Vunicode_category_table.
6349
76b397fb
DN
63502011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6351
6352 * m/iris4d.h: Remove file, move contents ...
6353 * s/irix6-5.h: ... here.
6354
22b4128e
PE
63552011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6356
6357 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6358 * alloc.c (mark_buffer):
6359 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6360 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6361 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6362 This isn't true in general, and it's particularly not true
6363 if Emacs is configured with --with-wide-int.
6364 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6365 New macros, used in the buffer.c change.
6366
869795d6
JD
63672011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6368
6369 * xsettings.c: Use both GConf and GSettings if both are available.
6370 (store_config_changed_event): Add comment.
6371 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6372 (store_tool_bar_style_changed): New functions.
5e617bc2 6373 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6374 (struct xsettings): Move font inside HAVE_XFT.
6375 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6376 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6377 Move inside HAVE_XFT.
640c8776 6378 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6379 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6380 also.
6381 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6382 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6383 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6384 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6385 (parse_settings): Move check for font inside HAVE_XFT.
6386 (read_settings, apply_xft_settings): Add comment.
6387 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6388 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6389 call store_font_name_changed.
6390 (xft_settings_event): Add comment.
6391 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6392 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6393 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6394 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6395 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6396 (xsettings_get_system_font, xsettings_get_system_normal_font):
6397 Add comment.
869795d6 6398
d8ed26bd
PE
63992011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6400
6401 Random fixes. E.g., (random) never returned negative values.
6402 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6403 subseconds part to the entropy, as that's a bit more random.
6404 Prefer signed to unsigned, since the signedness doesn't matter and
6405 in general we prefer signed. When given a limit, use a
6406 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6407 latter isn't right if USE_2_TAGS_FOR_INTS.
6408 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6409 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6410
cabf1cac
SM
64112011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6412
6413 * textprop.c (text_property_stickiness):
6414 Obey Vtext_property_default_nonsticky.
6415 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6416 * w32fns.c (syms_of_w32fns):
6417 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6418
6e9b2be9
PE
64192011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6420
6421 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6422 This is more efficient than Ffile_directory_p and avoids a minor race.
6423
90186c68
LMI
64242011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6425
7c301272
LMI
6426 * buffer.c (Foverlay_put): Say what the return value is
6427 (bug#7835).
6428
c4f2d8d4
LMI
6429 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6430 is a directory before asking whether to use the file name
6431 (bug#7564).
ad637907
LMI
6432 (barf_or_query_if_file_exists): Make the "File is a directory"
6433 error be more correct.
c4f2d8d4 6434
90186c68
LMI
6435 * fns.c (Frequire): Remove the mention of the .gz files, since
6436 that's installation-specific, but keep the mention of
6437 `get-load-suffixes'.
6438
da64016e
PE
64392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6440
6441 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6442 Report string overflow if the output is too long.
6443
7d47b580
JB
64442011-07-04 Juanma Barranquero <lekktu@gmail.com>
6445
a555cb87
JB
6446 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6447 (syms_of_gnutls): Remove duplicate DEFSYM for
6448 Qgnutls_bootprop_verify_hostname_error, an error for
6449 Qgnutls_bootprop_verify_error (which is no longer used).
6450
7d47b580
JB
6451 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6452 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6453 Also (re)move comments that are misplaced or no longer relevant.
6454
1e49bfab
LMI
64552011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6456
6457 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6458
1485f4c0
CY
64592011-07-03 Chong Yidong <cyd@stupidchicken.com>
6460
6461 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6462 and background color parameters if they have been changed.
6463
a9ab721e
LMI
64642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6465
6466 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6467
cf7cff57
PE
64682011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6469
2e13213d
PE
6470 * xsettings.c (SYSTEM_FONT): Define only when used.
6471 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6472
cf7cff57
PE
6473 * keymap.c (access_keymap_1): Now static.
6474
7a8e04f7
CY
64752011-07-02 Chong Yidong <cyd@stupidchicken.com>
6476
6477 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6478 leave any prefix arg for the up event (Bug#1586).
6479
61352f62
LMI
64802011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6481
69bb1ef7
LMI
6482 * lread.c (syms_of_lread): Mention single symbols defined by
6483 `defvar' or `defconst' (bug#7154).
6484
61352f62 6485 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6486 (Frequire): Mention get-load-suffixes.
61352f62 6487
28545e04
MR
64882011-07-02 Martin Rudalics <rudalics@gmx.at>
6489
6490 * window.h (window): Remove clone_number slot.
6491 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6492 Remove.
6493 (make_parent_window, make_window, saved_window)
6494 (Fset_window_configuration, save_window_save): Don't deal with
6495 clone numbers.
6496 * buffer.c (Qclone_number): Remove declaration.
6497 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6498
3349e122
SM
64992011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6500
6501 Add multiple inheritance to keymaps.
6502 * keymap.c (Fmake_composed_keymap): New function.
6503 (Fset_keymap_parent): Simplify.
6504 (fix_submap_inheritance): Remove.
6505 (access_keymap_1): New function extracted from access_keymap to handle
6506 embedded parents and handle lists of maps.
6507 (access_keymap): Use it.
6508 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6509 (Fcopy_keymap): Handle embedded parents.
6510 (Fcommand_remapping, define_as_prefix): Simplify.
6511 (Fkey_binding): Simplify.
6512 (syms_of_keymap): Move minibuffer-local-completion-map,
6513 minibuffer-local-filename-completion-map,
6514 minibuffer-local-must-match-map, and
6515 minibuffer-local-filename-must-match-map to Elisp.
6516 (syms_of_keymap): Defsubr make-composed-keymap.
6517 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6518 (parse_menu_item): Trivial simplification.
6519
3279eb87
GM
65202011-07-01 Glenn Morris <rgm@gnu.org>
6521
6522 * Makefile.in (SETTINGS_LIBS): Fix typo.
6523
4550efdf
KI
65242011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6525
6526 * coding.c (Fencode_coding_string): Record the last coding system
6527 used, as the function doc string says (bug#8738).
6528
0949d2b6
JD
65292011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6530
6531 * xsettings.c (store_monospaced_changed): Take new font as arg and
6532 check for change against current_mono_font.
6533 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6534 (emacs_settings_constructor, emacs_settings_get_property)
6535 (emacs_settings_set_property, emacs_settings_class_init)
6536 (emacs_settings_init, gsettings_obj): Remove.
6537 (something_changedCB): New function for HAVE_GSETTINGS.
6538 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6539 with value as argument.
6540 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6541 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6542 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6543 "changed".
6544
6545 * xgselect.c: Add defined (HAVE_GSETTINGS).
6546 (xgselect_initialize): Ditto.
6547
6548 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6549 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6550 xg_select.
6551
bbc6b304
PE
65522011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6553
6554 * eval.c (struct backtrace): Simplify and port the data structure.
6555 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6556 signed bit field, as this assumption is not portable and it makes
6557 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6558 "char debug_on_exit : 1" as this is not portable either; instead,
6559 use the portable "unsigned int debug_on_exit : 1". Remove unused
6560 member evalargs. Remove obsolete comments about cc bombing out.
6561
9851bfc5
JD
65622011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6563
51bb811f 6564 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6565 Let HAVE_GSETTINGS override HAVE_GCONF.
6566 (store_monospaced_changed): New function.
6567 (EMACS_SETTINGS): A new type derived from GObject to handle
6568 GSettings notifications.
6569 (emacs_settings_constructor, emacs_settings_get_property)
6570 (emacs_settings_set_property, emacs_settings_class_init):
6571 New functions.
6572 (gsettings_client, gsettings_obj): New variables.
6573 (GSETTINGS_SCHEMA): New define.
6574 (something_changedCB): Call store_monospaced_changed.
6575 (init_gsettings): New function.
6576 (xsettings_initialize): Call init_gsettings.
6577 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6578 to NULL.
6579
640c8776 6580 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6581 GCONF_CFLAGS/LIBS.
6582
5386012d
MR
65832011-06-29 Martin Rudalics <rudalics@gmx.at>
6584
6585 * window.c (resize_root_window, grow_mini_window)
6586 (shrink_mini_window): Rename Qresize_root_window to
6587 Qwindow_resize_root_window and Qresize_root_window_vertically to
6588 Qwindow_resize_root_window_vertically.
6589
f13e0b08
PE
65902011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6591
6592 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6593
94515237
JB
65942011-06-27 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * makefile.w32-in: Redesign dependencies so they reflect more
6597 clearly which files are directly included by each source file,
6598 and not through other includes.
6599
e43b6e43
MR
66002011-06-27 Martin Rudalics <rudalics@gmx.at>
6601
6602 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6603 (sort_overlays, overlay_strings): When an overlay's clone number
6604 matches the window's clone number process the overlay even if
6605 the overlay's window property doesn't match the current window.
6606
d68443dc
MR
6607 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6608 (Fwindow_hchild): Rename to Fwindow_left_child.
6609 (Fwindow_next): Rename to Fwindow_next_sibling.
6610 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6611 (resize_window_check): Rename to window_resize_check.
6612 (resize_window_apply): Rename to window_resize_apply.
6613 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6614 (Fdelete_other_windows_internal, resize_frame_windows)
6615 (Fsplit_window_internal, Fdelete_window_internal)
6616 (grow_mini_window, shrink_mini_window)
6617 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6618
c7e73be5
JD
66192011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6620
6621 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6622 (emacs_fixed_set_min_size): Remove.
6623 (emacs_fixed_new): Take frame as argument.
6624
6625 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6626 (_EmacsFixedPrivate): Remove minwidth/height.
6627 Add struct frame *f.
6628 (emacs_fixed_init): Initialize priv->f.
6629 (get_parent_class, emacs_fixed_set_min_size): Remove.
6630 (emacs_fixed_new): Set priv->f to argument.
6631 (emacs_fixed_get_preferred_width)
6632 (emacs_fixed_get_preferred_height): Use min_width/height from
6633 frames size_hint to set minimum and natural (Bug#8919).
6634 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6635 and use min_width/height from frames size_hint to set
6636 min_width/height (Bug#8919).
6637
6638 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6639 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6640 Fix indentation.
c7e73be5 6641
cf99dcf8
EZ
66422011-06-26 Eli Zaretskii <eliz@gnu.org>
6643
6644 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6645 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6646 called at ZV.
6647
029529ac
CY
66482011-06-26 Chong Yidong <cyd@stupidchicken.com>
6649
6650 * process.c (wait_reading_process_output): Bypass select if
6651 waiting for a cell while ignoring keyboard input, and input is
6652 pending. Suggested by Jan Djärv (Bug#8869).
6653
7a7ef429
PE
66542011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 Use gnulib's dup2 module instead of rolling our own.
6657 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6658
11fdef7d 66592011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6660
6661 * dispnew.c (scrolling_window): Before scrolling, turn off a
6662 mouse-highlight in the window being scrolled.
6663
cd3520a4
JB
66642011-06-24 Juanma Barranquero <lekktu@gmail.com>
6665
6666 Move DEFSYM to lisp.h and use everywhere.
6667
6668 * character.h (DEFSYM): Move declaration...
6669 * lisp.h (DEFSYM): ...here.
6670
6671 * gnutls.c:
6672 * minibuf.c:
6673 * w32menu.c:
6674 * w32proc.c:
6675 * w32select.c: Don't include character.h.
6676
6677 * alloc.c (syms_of_alloc):
6678 * buffer.c (syms_of_buffer):
6679 * bytecode.c (syms_of_bytecode):
6680 * callint.c (syms_of_callint):
6681 * casefiddle.c (syms_of_casefiddle):
6682 * casetab.c (init_casetab_once):
6683 * category.c (init_category_once, syms_of_category):
6684 * ccl.c (syms_of_ccl):
6685 * cmds.c (syms_of_cmds):
6686 * composite.c (syms_of_composite):
6687 * dbusbind.c (syms_of_dbusbind):
6688 * dired.c (syms_of_dired):
6689 * dispnew.c (syms_of_display):
6690 * doc.c (syms_of_doc):
6691 * editfns.c (syms_of_editfns):
6692 * emacs.c (syms_of_emacs):
6693 * eval.c (syms_of_eval):
6694 * fileio.c (syms_of_fileio):
6695 * fns.c (syms_of_fns):
6696 * frame.c (syms_of_frame):
6697 * fringe.c (syms_of_fringe):
6698 * insdel.c (syms_of_insdel):
6699 * keymap.c (syms_of_keymap):
6700 * lread.c (init_obarray, syms_of_lread):
6701 * macros.c (syms_of_macros):
6702 * msdos.c (syms_of_msdos):
6703 * print.c (syms_of_print):
6704 * process.c (syms_of_process):
6705 * search.c (syms_of_search):
6706 * sound.c (syms_of_sound):
6707 * syntax.c (init_syntax_once, syms_of_syntax):
6708 * terminal.c (syms_of_terminal):
6709 * textprop.c (syms_of_textprop):
6710 * undo.c (syms_of_undo):
6711 * w32.c (globals_of_w32):
6712 * window.c (syms_of_window):
6713 * xdisp.c (syms_of_xdisp):
6714 * xfaces.c (syms_of_xfaces):
6715 * xfns.c (syms_of_xfns):
6716 * xmenu.c (syms_of_xmenu):
6717 * xsettings.c (syms_of_xsettings):
6718 * xterm.c (syms_of_xterm): Use DEFSYM.
6719
4228cf16
TZ
67202011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6721
cd3520a4 6722 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6723
7fcccf1e
PE
67242011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6725
7efb4e0e
PE
6726 Integer and buffer overflow fixes (Bug#8873).
6727
ff5844ad
PE
6728 * print.c (printchar, strout): Check for string overflow.
6729 (PRINTPREPARE, printchar, strout):
6730 Don't set size unless allocation succeeds.
6731
90532f02
PE
6732 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6733 for sizes. Check for string overflow more accurately.
6734 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6735
6d84508d
PE
6736 * macros.c: Integer and buffer overflow fixes.
6737 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6738 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6739 Use ptrdiff_t, not int, for sizes.
6740 Don't increment bufsize until after realloc succeeds.
6741 Check for size-calculation overflow.
6742 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6743
437b2cb4
PE
6744 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6745
8b9ac8b4
PE
6746 * lread.c: Integer overflow fixes.
6747 (read_integer): Radix is now EMACS_INT, not int,
6748 to improve quality of diagnostics for out-of-range radices.
6749 Calculate buffer size correctly for out-of-range radices.
6750 (read1): Check for integer overflow in radices, and in
6751 read-circle numbers.
82cb60d3
PE
6752 (read_escape): Avoid int overflow.
6753 (Fload, openp, read_buffer_size, read1)
6754 (substitute_object_recurse, read_vector, read_list, map_obarray):
6755 Use ptrdiff_t, not int, for sizes.
6756 (read1): Use EMACS_INT, not int, for sizes.
20270765 6757 Check for size overflow.
8b9ac8b4 6758
7fcccf1e
PE
6759 * image.c (cache_image): Check for size arithmetic overflow.
6760
bfbbd7e7
PE
6761 * lread.c: Integer overflow issues.
6762 (saved_doc_string_size, saved_doc_string_length)
6763 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6764 Now ptrdiff_t, not int.
6765 (read1): Don't assume doc string length fits in int. Check for
6766 out-of-range doc string lengths.
6767 (read_list): Don't assume file position fits in int.
39019e54 6768 (read_escape): Check for hex character overflow.
bfbbd7e7 6769
4e323265
LL
67702011-06-22 Leo Liu <sdl.web@gmail.com>
6771
6772 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6773 Move to minibuffer.el.
6774
85fece3e
PE
67752011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6776
20b84ce9 6777 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6778 The following patches are for when GLYPH_DEBUG && !XASSERT.
6779 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6780 * dispnew.c (flush_stdout):
6781 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6782 Mark as externally visible.
6783 * dispnew.c (check_window_matrix_pointers): Now static.
6784 * dispnew.c (window_to_frame_vpos):
6785 * xfns.c (unwind_create_frame):
6786 * xterm.c (x_check_font): Remove unused local.
6787 * scroll.c (CHECK_BOUNDS):
6788 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6789 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6790 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6791 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6792 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6793 Now static.
6794 (debug_method_add): Use va_list and vsprintf rather than relying
6795 on undefined behavior with wrong number of arguments.
6796 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6797 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6798 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6799 since we're not interested in debugging glyphs with old libraries.
6800 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6801 GCC 4.6.0's static checking.
6802
0766b489
PE
68032011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6804
31fd4b32
PE
6805 Integer overflow and signedness fixes (Bug#8873).
6806 A few related buffer overrun fixes, too.
6807
b79e8648
PE
6808 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6809
0766b489
PE
6810 * dispextern.h (struct face.stipple):
6811 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6812 (x_bitmap_mask, x_allocate_bitmap_record)
6813 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6814 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6815 (x_create_bitmap_from_xpm_data):
6816 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6817 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6818 (.bitmaps_last):
6819 * xfaces.c (load_pixmap):
6820 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6821 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6822 (.bitmaps_last, struct x_output.icon_bitmap):
6823 Use ptrdiff_t, not int, for bitmap indexes.
6824 (x_allocate_bitmap_record): Check for size overflow.
6825 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6826
b081724f
PE
6827 Use ptrdiff_t, not int, for overlay counts.
6828 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6829 * editfns.c (overlays_around, get_pos_property):
6830 * textprop.c (get_char_property_and_overlay):
6831 * xdisp.c (next_overlay_change, note_mouse_highlight):
6832 * xfaces.c (face_at_buffer_position):
21514da7
PE
6833 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6834 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6835 (Fnext_overlay_change, Fprevious_overlay_change)
6836 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6837 Use ptrdiff_t, not int, for sizes.
21514da7 6838 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6839
3de73e5e
PE
6840 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6841
2606c57b
PE
6842 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6843 (x_session_initialize): Do not assume string length fits in int.
6844
aaafe47a
PE
6845 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6846 This is unlikely, but can occur if DPI is outlandish.
6847
2674ddc8 6848 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6849 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6850
28154962
PE
6851 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6852 * xrdb.c (magic_file_p, search_magic_path):
6853 Omit last arg SUFFIX; it was always 0. All callers changed.
6854 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6855
7de51af5
PE
6856 * xfont.c (xfont_match): Avoid need for strlen.
6857
25ed6cc3
PE
6858 * xfns.c: Don't assume strlen fits in int.
6859 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6860
4eab31dd
PE
6861 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6862 not unsigned long, as we prefer signed integers. All callers changed.
6863 Detect integer overflow in repeat count.
6864 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6865 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6866
171e2a58
PE
6867 * termcap.c: Don't assume sizes fit in int and never overflow.
6868 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6869 (gobble_line): Check for size-calculation overflow.
6870
ad39faca 6871 * minibuf.c (Fread_buffer):
6e5bb2dc 6872 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6873 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6874 Don't assume string length fits in int.
6875
52c61c22 6876 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6877 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6878
b5b8c9e5
PE
6879 * font.c: Don't assume string length fits in int.
6880 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6881 Use ptrdiff_t, not int.
ccd6111c
PE
6882 (font_intern_prop): Don't assume string length fits in int.
6883 Don't assume integer property fits in fixnum.
6884 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6885
882f0d81 6886 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6887 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6888 Reformulate so as not to need the command string.
6889 Invoke gzip -cd rather than gunzip, as it's more portable.
6890 (lock_info_type, lock_file_1, lock_file):
6891 Don't assume pid_t and time_t fit in unsigned long.
6892 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6893 (current_lock_owner): Prefer signed type for sizes.
6894 Use memcpy, not strncpy, where memcpy is what is really wanted.
6895 Don't assume (via atoi) that time_t and pid_t fit in int.
6896 Check for time_t and/or pid_t out of range, e.g., via a network share.
6897 Don't alloca where an auto var works fine.
6898
93f4cf88
PE
6899 * fileio.c: Fix some integer overflow issues.
6900 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6901 Don't assume string length fits in int.
6902 (directory_file_name): Don't assume string length fits in long.
6903 (make_temp_name): Don't assume pid fits in int, or that its print
6904 length is less than 20.
6905
f3e92b69
PE
6906 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6907
1bfdaf10
PE
6908 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6909
35016e9a
PE
6910 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6911
3d1e65a1
PE
6912 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6913 We prefer signed integers, even for size calculations.
6914
0b963a93
PE
6915 * emacs.c: Don't assume string length fits in 'int'.
6916 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6917 (main): Don't invoke strlen when not needed.
6918
573f4b54
PE
6919 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6920 (XD_DEBUG_MESSAGE): Don't waste a byte.
6921
989f33ba
PE
6922 * callproc.c (getenv_internal_1, getenv_internal)
6923 (Fgetenv_internal):
965d34eb
PE
6924 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6925
e4d29b33
PE
6926 * lread.c (invalid_syntax): Omit length argument.
6927 All uses changed. This doesn't fix a bug, but it simplifies the
6928 code away from its former Hollerith-constant appearance, and it's
6929 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6930 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6931
eb49b136
PE
6932 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6933 This didn't break anything, but it didn't help either.
6934 It's confusing to put a bogus integer in a place where the actual
6935 value does not matter.
9f62aeb1 6936 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6937 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6938
15375a22
PE
6939 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6940 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6941 implementation.
b61cc01c
PE
6942 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6943 We prefer signed types, and the value cannot exceed the EMACS_INT
6944 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6945 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6946 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6947 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6948
53b2623d
PE
6949 * indent.c (sane_tab_width): New function.
6950 (current_column, scan_for_column, Findent_to, position_indentation)
6951 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6952 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6953
51cab52b 6954 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6955
f2ed8a70
PE
6956 * lisp.h (lint_assume): New macro.
6957 * composite.c (composition_gstring_put_cache):
6958 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6959
abe80cc6
PE
6960 * editfns.c, insdel.c:
6961 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6962
b02c740e
PE
6963 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6964
ebc96716
PE
6965 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6966
b4e50fa0 6967 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6968 Use much-faster test for byte-length change.
311d5d7c 6969 Don't assume string byte-length fits in 'int'.
a4cf38e4 6970 Check that character arg fits in 'int'.
85461888 6971 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6972
c0c1ee9f
PE
6973 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6974
a498d7f4
PE
6975 * fns.c (concat): Catch string overflow earlier.
6976 Do not rely on integer wraparound.
6977
51cab52b
PE
6978 * dispextern.h (struct it.overlay_strings_charpos)
6979 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6980 * xdisp.c (forward_to_next_line_start)
6981 (back_to_previous_visible_line_start)
6982 (reseat_at_next_visible_line_start, next_element_from_buffer):
6983 Don't arbitrarily truncate the value of 'selective' to int.
6984
76031fad
PE
6985 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6986
5eb55db9
PE
6987 * composite.c: Don't truncate sizes to 'int'.
6988 (composition_gstring_p, composition_reseat_it)
6989 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6990 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6991 not EMACS_UINT, for indexes.
5eb55db9 6992
0703a717
PE
6993 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6994
d6202519
PE
6995 * buffer.c: Include <verify.h>.
6996 (struct sortvec.priority, struct sortstr.priority):
8961a454 6997 Now EMACS_INT, not int.
c20998a7 6998 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6999 (struct sortstr.size, record_overlay_string)
7000 (struct sortstrlist.size, struct sortlist.used):
7001 Don't truncate size to int.
7002 (record_overlay_string): Check for size-calculation overflow.
d6202519 7003 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7004
d5a19415
JM
70052011-06-22 Jim Meyering <meyering@redhat.com>
7006
029529ac 7007 Don't leak an XBM-image-sized buffer
d5a19415
JM
7008 * image.c (xbm_load): Free the image buffer after using it.
7009
a9041e6c
PE
70102011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7011
7012 Port to Sun C.
7013 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7014 that Sun C diagnosed.
7015 * fns.c (secure_hash): Fix pointer signedness issue.
7016 * intervals.c (static_offset_intervals): New function.
7017 (offset_intervals): Use it.
7018
7f3f739f
LL
70192011-06-21 Leo Liu <sdl.web@gmail.com>
7020
7021 * deps.mk (fns.o):
7022 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7023 sha512.h.
7024
7025 * fns.c (secure_hash): Rename from crypto_hash_function and change
7026 the first arg to accept symbols.
5b66d427 7027 (Fsecure_hash): New primitive.
7f3f739f
LL
7028 (syms_of_fns): New symbols.
7029
76147d94
DD
70302011-06-20 Deniz Dogan <deniz@dogan.se>
7031
7032 * process.c (Fset_process_buffer): Clarify return value in
7033 docstring.
7034
7d7d0045
CY
70352011-06-18 Chong Yidong <cyd@stupidchicken.com>
7036
7037 * dispnew.c (add_window_display_history): Use BVAR.
7038
7039 * xdisp.c (debug_method_add): Use BVAR.
7040 (check_window_end, dump_glyph_matrix, dump_glyph)
7041 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7042
7043 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7044 Likewise.
7045
7046 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7047 check till after the cache is created in init_frame_faces.
7048
ff2bc410
SM
70492011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7050
7051 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7052
28177add
PE
70532011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7054
dd3482fe
PE
7055 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7056 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7057 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7058
393d71f3 7059 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7060 * fileio.c (Finsert_file_contents):
7061 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7062 Remove the old (too-loose) buffer overflow checks.
7063 They weren't needed, since make_gap checks for buffer overflow.
7064 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7065 The old code merely checked for Emacs fixnum overflow, and relied
7066 on undefined (wraparound) behavior. The new code avoids undefined
7067 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7068
2e6813b0 7069 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7070 Tune. Don't use wider integers than needed. Don't use alloca.
7071 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7072
599a9e4f
PE
7073 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7074
99561444
PE
7075 * insdel.c, lisp.h (buffer_overflow): New function.
7076 (insert_from_buffer_1, replace_range, replace_range_2):
7077 * insdel.c (make_gap_larger):
7078 * editfns.c (Finsert_char):
7079 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7080
28177add
PE
7081 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7082
e69dafad
PE
70832011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7084
4baa020d 7085 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7086
b1c46f02
PE
7087 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7088 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7089
e69dafad
PE
7090 * fileio.c: Don't assume EMACS_INT fits in off_t.
7091 (emacs_lseek): New static function.
7092 (Finsert_file_contents, Fwrite_region): Use it.
7093 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7094
566684ea
PE
7095 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7096
e6966cd6
PE
7097 * fns.c: Don't overflow int when computing a list length.
7098 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7099 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7100 truncation on 64-bit hosts. Check for QUIT every
7101 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7102 faster and is responsive enough.
7103 (Flength): Report an error instead of overflowing an integer.
7104 (Fsafe_length): Return a float if the value is not representable
7105 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7106 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7107 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7108
dd0b0efb
PE
7109 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7110 (header_size, word_size): New constants.
7111 (allocate_vectorlike): Don't check size overflow here.
7112 (allocate_vector): Check it here instead, since this is the only
7113 caller of allocate_vectorlike that could cause overflow.
7114 Check that the new vector's length is representable as a fixnum.
7115
86fe5cfe
PE
7116 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7117 The previous code was bogus. For example, next_almost_prime (32)
7118 returned 39, which is undesirable as it is a multiple of 3; and
7119 next_almost_prime (24) returned 25, which is a multiple of 5 so
7120 why was the code bothering to check for multiples of 7?
7121
80e88859
PE
7122 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7123
4a2f0ad6
PE
7124 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7125
f66c7cf8
PE
7126 Variadic C functions now count arguments with ptrdiff_t.
7127 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7128 Back then I didn't know that the Emacs coding style prefers signed int.
7129 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7130 were being counted with int, which may truncate counts on 64-bit
7131 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7132 * lisp.h (struct Lisp_Subr.function.aMANY)
7133 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7134 Arg counts are now ptrdiff_t, not size_t.
7135 All variadic functions and their callers changed accordingly.
7136 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7137 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7138 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7139 * callint.c (Fcall_interactively): Check arg count for overflow,
7140 to avoid potential buffer overrun. Use signed char, not 'int',
7141 for 'varies' array, so that we needn't bother to check its size
7142 calculation for overflow.
7143 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7144 * eval.c (apply_lambda):
7145 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7146 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7147 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7148
a1759b76
PE
7149 * callint.c (Fcall_interactively): Don't use index var as event count.
7150
d96be9fc
PE
7151 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7152 * mem-limits.h (SIZE): Remove; no longer used.
7153
a690a978 7154 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7155
578c21e6
PE
7156 Remove unnecessary casts.
7157 * xterm.c (x_term_init):
7158 * xfns.c (x_set_border_pixel):
7159 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7160 These aren't needed now that we assume ANSI C.
7161
96f53c6c
PE
7162 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7163 It's more likely to cause problems (due to unsigned overflow)
7164 than to cure them.
7165
83c77d31
PE
7166 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7167
ee2079f1
PE
7168 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7169
6da65536
PE
7170 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7171
7147c4a4
PE
7172 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7173
193e32d9
PE
7174 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7175
e5533da6
PE
7176 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7177
9910e595
PE
7178 GLYPH_CODE_FACE returns EMACS_INT, not int.
7179 * dispextern.h (merge_faces):
7180 * xfaces.c (merge_faces):
01103c44
PE
7181 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7182 Don't assume EMACS_INT fits in int.
9910e595 7183
2638320e
PE
7184 * character.h (CHAR_VALID_P): Remove unused parameter.
7185 * fontset.c, lisp.h, xdisp.c: All uses changed.
7186
045eb8d9
PE
7187 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7188
c1f134b5
PE
7189 * fns.c (concat): Minor tuning based on overflow analysis.
7190 This doesn't fix any bugs. Use int to hold character, instead
7191 of constantly refetching from Emacs object. Use XFASTINT, not
7192 XINT, for value known to be a character. Don't bother comparing
7193 a single byte to 0400, as it's always less.
7194
395fcb93 7195 * floatfns.c (Fexpt):
327eeec8
PE
7196 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7197
abbd3d23
PE
7198 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7199 for characters.
7200
684a03ef
PE
7201 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7202
0fed43f3
PE
7203 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7204 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7205 incorrectly succeed when S was a string, because 4294967386 was
7206 truncated before it was used.
7207
8fd02eb7
PE
7208 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7209 Otherwise, an out-of-range integer could cause undefined behavior
7210 on a 64-bit host.
7211
f8c86b69
PE
7212 * composite.c: Use int, not EMACS_INT, for characters.
7213 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7214 EMACS_INT, for values that are known to be in character range.
7215 This doesn't fix any bugs but is the usual style inside Emacs and
7216 may generate better code on 32-bit machines.
7217
34206dd2
PE
7218 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7219 This is for reasons similar to the recent CHAR_STRING fix.
7220 * charset.c (Fencode_char): Check that character arg is actually
7221 a character. Pass an int to ENCODE_CHAR.
7222 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7223 wider than 'int', as a compile-time check to prevent future regressions
7224 in this area.
7225
c5958d4c 7226 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7227
7228 Make sure a 64-bit char is never passed to CHAR_STRING.
7229 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7230 by silently ignoring the top 32 bits, allowing some values
7231 that were far too large to be valid characters.
7232 * character.h: Include <verify.h>.
7233 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7234 arguments are no wider than unsigned, as a compile-time check
7235 to prevent future regressions in this area.
7236 * data.c (Faset):
01103c44 7237 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7238 (Fsubst_char_in_region):
7239 * fns.c (concat):
7240 * xdisp.c (decode_mode_spec_coding):
7241 Adjust to CHAR_STRING's new requirement.
7242 * editfns.c (Finsert_char, Fsubst_char_in_region):
7243 * fns.c (concat): Check that character args are actually
7244 characters. Without this test, these functions did the wrong
7245 thing with wildly out-of-range values on 64-bit hosts.
7246
d37ca623
PE
7247 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7248 These casts should not be needed on 32-bit hosts, either.
7249 * keyboard.c (read_char):
7250 * lread.c (Fload): Remove casts to unsigned.
7251
ea204efb
PE
7252 * lisp.h (UNSIGNED_CMP): New macro.
7253 This fixes comparison bugs on 64-bit hosts.
7254 (ASCII_CHAR_P): Use it.
7255 * casefiddle.c (casify_object):
01103c44 7256 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7257 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7258 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7259 * dispextern.h (FACE_FROM_ID):
7260 * keyboard.c (read_char): Use UNSIGNED_CMP.
7261
41cb286c
PE
7262 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7263 not to EMACS_INT, to avoid GCC warning.
7264
4a1b9832
PE
7265 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7266
55daad71
PE
7267 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7268 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7269 isn't needed on 32-bit machines.
8f95c75c 7270
01103c44
PE
7271 * buffer.c (Fgenerate_new_buffer_name):
7272 Use EMACS_INT for count, not int.
0ceccced 7273 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7274
7275 * data.c (Qcompiled_function): Now static.
7276
c6f072e7
PE
7277 * window.c (window_body_lines): Now static.
7278
20ce5912
PE
7279 * image.c (gif_load): Rename local to avoid shadowing.
7280
9c4c5f81
PE
7281 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7282 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7283 * alloc.c (make_save_value): Integer argument is now of type
7284 ptrdiff_t, not int.
7285 (mark_object): Use ptrdiff_t, not int.
7286 * lisp.h (pD): New macro.
7287 * print.c (print_object): Use it.
7288
c0c5c8ae
PE
7289 * alloc.c: Use EMACS_INT, not int, to count objects.
7290 (total_conses, total_markers, total_symbols, total_vector_size)
7291 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7292 (total_free_floats, total_floats, total_free_intervals)
7293 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7294 Now EMACS_INT, not int. All uses changed.
7295 (Fgarbage_collect): Compute overall total using a double, so that
7296 integer overflow is less likely to be a problem. Check for overflow
7297 when converting back to an integer.
5a25e253
PE
7298 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7299 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7300 These were 'int' variables that could overflow on 64-bit hosts;
7301 they were never used, so remove them instead of repairing them.
211a0b2a 7302 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7303 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7304 Previously, this ceilinged at INT_MAX, but that doesn't work on
7305 64-bit machines.
e46bb31a 7306 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7307
c78baabf 7308 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7309 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7310 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7311 when a (possibly-narrower) signed value would do just as well.
7312 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7313
c9d624c6
PE
7314 * alloc.c: Catch some string size overflows that we were missing.
7315 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7316 for convenience in STRING_BYTES_MAX.
7317 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7318 The definition here is exact; the one in lisp.h was approximate.
7319 (allocate_string_data): Check for string overflow. This catches
7320 some instances we weren't catching before. Also, it catches
7321 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7322 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7323 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7324
c9d624c6
PE
7325 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7326 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7327 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7328
353032ce
PE
7329 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7330
2bccce07
PE
7331 * alloc.c (Fmake_string): Check for out-of-range init.
7332
0ac30604
SM
73332011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7334
7335 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7336
c195f2de
JD
73372011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7338
7339 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7340 xg_get_default_scrollbar_width.
7341
7342 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7343 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7344 (style_changed_cb): Call update_theme_scrollbar_width and call
7345 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7346 all frames (Bug#8505).
7347 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7348 Call gtk_window_set_resizable if HAVE_GTK3.
7349 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7350 and height if HAVE_GTK3 (Bug#8505).
7351 (scroll_bar_width_for_theme): New variable.
7352 (update_theme_scrollbar_width): New function.
7353 (xg_get_default_scrollbar_width): Move code to
7354 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7355 (xg_initialize): Call update_theme_scrollbar_width.
7356
7357 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7358
7359 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7360
e10ac9f1
MR
73612011-06-12 Martin Rudalics <rudalics@gmx.at>
7362
7363 * frame.c (make_frame): Call other_buffer_safely instead of
7364 other_buffer.
7365
7366 * window.c (temp_output_buffer_show): Call display_buffer with
7367 second argument Vtemp_buffer_show_specifiers and reset latter
7368 immediately after the call.
7369 (Vtemp_buffer_show_specifiers): New variable.
7370 (auto_window_vscroll_p, next_screen_context_lines)
7371 (Vscroll_preserve_screen_position): Remove leading asterisks from
7372 doc-strings.
7373
2d3c217e 73742011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7375
7b7f97e8 7376 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7377 * buffer.c (Qclone_number): Remove for now, as it's unused.
7378 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7379 (record_buffer): Remove unused local.
7380 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7381 (set_frame_buffer_list): Remove; unused.
7382 * frame.h (other_visible_frames): Remove decl.
7383 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7384 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7385 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7386 if HAVE_GPM.
7387 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7388 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7389 Define only if HAVE_GPM.
7390 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7391 (update_hints_inhibit): Remove; never set. All uses removed.
7392 * widgetprv.h (emacsFrameClassRec): Remove decl.
7393 * window.c (delete_deletable_window): Now returns void, since it
7394 wasn't returning anything.
7395 (compare_window_configurations): Remove unused locals.
7396 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7397 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7398 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7399 the same widths as pointers. This follows up on the 2011-05-06 patch.
7400 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7401 * xterm.h: Likewise.
7402 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7403
1384b89e
JB
74042011-06-12 Juanma Barranquero <lekktu@gmail.com>
7405
7406 * makefile.w32-in: Update dependencies.
7407 (LISP_H): Add lib/intprops.h.
7408
1100a63c
CY
74092011-06-11 Chong Yidong <cyd@stupidchicken.com>
7410
7411 * image.c (gif_load): Add animation frame delay to the metadata.
7412 (syms_of_image): Use DEFSYM. New symbol `delay'.
7413
6198ccd0
MR
74142011-06-11 Martin Rudalics <rudalics@gmx.at>
7415
7416 * window.c (delete_deletable_window): Re-add.
7417 (Fset_window_configuration): Rewrite to handle dead buffers and
7418 consequently deletable windows.
7419 (window_tree, Fwindow_tree): Remove. Supply functionality in
7420 window.el.
7421 (compare_window_configurations): Simplify code.
7422
b6e3633c
AS
74232011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7424
1ab0dee5
AS
7425 * image.c (imagemagick_load_image): Fix type mismatch.
7426 (Fimagemagick_types): Likewise.
7427
b6e3633c
AS
7428 * window.h (replace_buffer_in_windows): Declare.
7429
9397e56f
MR
74302011-06-11 Martin Rudalics <rudalics@gmx.at>
7431
7432 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7433 Qclone_number. Remove external declaration of Qdelete_window.
7434 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7435 code.
640c8776
SM
7436 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7437 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7438 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7439 buffer list implementation.
7440 (other_buffer_safely): New function.
7441 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7442 calls to replace_buffer_in_windows and
7443 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7444 if allowed.
7445 (record_buffer): Inhibit quitting and rewrite using quittable
7446 functions. Run Qbuffer_list_update_hook if allowed.
7447 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7448 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7449 Move switch-to-buffer to window.el.
9397e56f
MR
7450 (bury-buffer): Move to window.el.
7451 (Vbuffer_list_update_hook): New variable.
7452
7453 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7454 section.
7455
7456 * window.h (resize_frame_windows): Move up in code.
7457 (Fwindow_frame): Remove EXFUN.
7458 (replace_buffer_in_all_windows): Remove prototype.
7459 (replace_buffer_in_windows_safely): Add prototype.
7460
7461 * window.c: Declare Qdelete_window static again. Move down
7462 declaration of select_count.
7463 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7464 (Fother_window): Move to window.el.
7465 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7466 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7467 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7468 window.el.
7469 (replace_buffer_in_windows): Implement by calling
7470 Qreplace_buffer_in_windows.
7471 (replace_buffer_in_all_windows): Remove with some functionality
7472 moved into replace_buffer_in_windows_safely.
7473 (replace_buffer_in_windows_safely): New function.
7474 (select_window_norecord, select_frame_norecord): Move in front
7475 of run_window_configuration_change_hook. Remove now obsolete
7476 declarations.
640c8776
SM
7477 (Fset_window_buffer): Rewrite doc-string.
7478 Call Qrecord_window_buffer.
9397e56f
MR
7479 (keys_of_window): Move binding for other-window to window.el.
7480
b50691aa
CY
74812011-06-11 Chong Yidong <cyd@stupidchicken.com>
7482
7483 * dispextern.h (struct image): Replace data member, whose int_val
7484 and ptr_val fields were not used by anything, with a single
7485 lisp_val object.
7486
7487 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7488 (gif_clear_image, gif_load, imagemagick_load_image)
7489 (gs_clear_image, gs_load): Callers changed.
7490
3f754b86
PE
74912011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7492
cca69397
PE
7493 * buffer.h: Include <time.h>, for time_t.
7494 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7495
109e28d0
PE
7496 Fix minor problems found by static checking.
7497
60737f02
PE
7498 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7499
4b66faf3
PE
7500 Make identifiers static if they are not used in other modules.
7501 * data.c (Qcompiled_function, Qframe, Qvector):
7502 * image.c (QimageMagick, Qsvg):
7503 * minibuf.c (Qmetadata):
7504 * window.c (resize_window_check, resize_root_window): Now static.
7505 * window.h (resize_window_check, resize_root_window): Remove decls.
7506
109e28d0
PE
7507 * window.c (window_deletion_count, delete_deletable_window):
7508 Remove; unused.
46a4ce9e
PE
7509 (window_body_lines): Now static.
7510 (Fdelete_other_windows_internal): Mark vars as initialized.
7511 Make sure 'resize_failed' is initialized.
7512 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7513 (resize_window_apply): Remove unused local.
7514 * window.h (delete_deletable_window): Remove decl.
7515
109e28d0 7516 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7517 (imagemagick_load_image): Fix pointer signedness problem by changing
7518 last arg from unsigned char * to char *. All uses changed.
7519 Also, fix a local for similar reasons.
7520 Remove unused locals. Remove locals to avoid shadowing.
7521 (fn_rsvg_handle_free): Remove; unused.
7522 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7523 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7524
3f754b86
PE
7525 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7526
2547adb1
CY
75272011-06-10 Chong Yidong <cyd@stupidchicken.com>
7528
7529 * image.c (gif_load): Fix omitted cast error introduced by
7530 2011-06-06 change.
7531
2c8e37d4
MR
75322011-06-10 Martin Rudalics <rudalics@gmx.at>
7533
7534 * window.h (resize_proportionally, orig_total_lines)
7535 (orig_top_line): Remove from window structure.
7536 (set_window_height, set_window_width, change_window_heights)
7537 (Fdelete_window): Remove prototypes.
7538 (resize_frame_windows): Remove duplicate declaration.
7539
440a42e3
EZ
75402011-06-10 Eli Zaretskii <eliz@gnu.org>
7541
7542 * window.h (resize_frame_windows, resize_window_check)
7543 (delete_deletable_window, resize_root_window)
7544 (resize_frame_windows): Declare prototypes.
7545
7546 * window.c (resize_window_apply): Make definition be "static" to
7547 match the prototype.
7548
562dd5e9
MR
75492011-06-10 Martin Rudalics <rudalics@gmx.at>
7550
7551 * window.c: Remove declarations of Qwindow_size_fixed,
7552 window_min_size_1, window_min_size_2, window_min_size,
7553 size_window, window_fixed_size_p, enlarge_window, delete_window.
7554 Remove static from declaration of Qdelete_window, it's
7555 temporarily needed by Fbury_buffer.
7556 (replace_window): Don't assign orig_top_line and
7557 orig_total_lines.
7558 (Fdelete_window, delete_window): Remove. Window deletion is
7559 handled by window.el.
640c8776
SM
7560 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7561 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7562 (Fdelete_other_windows): Remove. Deleting other windows is
7563 handled by window.el.
7564 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7565 handled in window.el.
7566 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7567 Window minimum sizes are handled in window.el.
7568 (shrink_windows, size_window, set_window_height)
7569 (set_window_width, change_window_heights, window_height)
7570 (window_width, CURBEG, CURSIZE, enlarge_window)
7571 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7572 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7573 handled in window.el.
7574 (make_dummy_parent): Rename to make_parent_window and give it a
7575 second argument horflag.
7576 (make_window): Don't set resize_proportionally any more.
7577 (Fsplit_window): Remove. Windows are split in window.el.
7578 (save_restore_action, save_restore_orig_size)
7579 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7580 Resize mini windows in window.el.
7581 (grow_mini_window, shrink_mini_window): Implement by calling
7582 Qresize_root_window_vertically, resize_window_check and
7583 resize_window_apply.
640c8776
SM
7584 (saved_window, Fset_window_configuration, save_window_save):
7585 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7586 resize_proportionally.
7587 (window_min_height, window_min_width): Move to window.el.
7588 (keys_of_window): Move bindings for delete-other-windows,
7589 split-window, delete-window and enlarge-window to window.el.
7590
7591 * buffer.c: Temporarily extern Qdelete_window.
7592 (Fbury_buffer): Temporarily call Qdelete_window instead of
7593 Fdelete_window (Fbury_buffer will move to window.el soon).
7594
7595 * frame.c (set_menu_bar_lines_1): Remove code handling
7596 orig_top_line and orig_total_lines.
7597
7598 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7599 set_window_height but set heights directly.
7600 (change_frame_size_1): Use resize_frame_windows.
7601
7602 * xdisp.c (init_xdisp): Don't use set_window_height but set
7603 heights directly.
7604
640c8776
SM
7605 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7606 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7607 run_window_configuration_change_hook.
7608
7609 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7610 instead of change_window_heights and run
7611 run_window_configuration_change_hook.
7612
1a13852e
MR
76132011-06-09 Martin Rudalics <rudalics@gmx.at>
7614
7615 * window.c (replace_window): Rename second argument REPLACEMENT to
7616 NEW. New third argument SETFLAG. Rewrite.
7617 (delete_window, make_dummy_parent): Call replace_window with
7618 third argument 1.
7619 (window_list_1): Move down in code.
7620 (run_window_configuration_change_hook): Move set_buffer part
7621 before select_frame_norecord part in order to unwind correctly.
7622 Rename count1 to count.
7623 (recombine_windows, delete_deletable_window, resize_root_window)
7624 (Fdelete_other_windows_internal)
7625 (Frun_window_configuration_change_hook, make_parent_window)
7626 (resize_window_check, resize_window_apply, Fresize_window_apply)
7627 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7628 (Fdelete_window_internal, Fresize_mini_window_internal):
7629 New functions.
1a13852e
MR
7630 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7631
f3d1777e
MR
76322011-06-08 Martin Rudalics <rudalics@gmx.at>
7633
496e208e
MR
7634 * window.h (window): Add some new members to window structure -
7635 normal_lines, normal_cols, new_total, new_normal, clone_number,
7636 splits, nest, prev_buffers, next_buffers.
7637 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7638 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7639
f3d1777e
MR
7640 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7641 Remove.
496e208e
MR
7642 (make_dummy_parent): Set new members of windows structure.
7643 (make_window): Move down in code. Handle new members of window
7644 structure.
7645 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7646 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7647 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7648 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7649 (Fset_window_next_buffers, Fset_window_clone_number):
7650 New functions.
496e208e
MR
7651 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7652 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7653 Doc-string fixes.
7654 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7655 Argument WINDOW can be now internal window too.
7656 (Fwindow_use_time): Move up in code.
7657 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7658 Rewrite doc-string.
7659 (Fset_window_configuration, saved_window)
7660 (Fcurrent_window_configuration, save_window_save): Handle new
7661 members of window structure.
b9e809c2
MR
7662 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7663 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7664 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7665 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7666 Qget_mru_window, Qresize_root_window,
7667 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7668 Qauto_buffer_name; staticpro them.
f3d1777e 7669
abde8f8c
MR
76702011-06-07 Martin Rudalics <rudalics@gmx.at>
7671
7672 * window.c (Fwindow_total_size, Fwindow_left_column)
7673 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7674 (Fwindow_list_1): New functions.
7675 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7676 (Fwindow_width, Fscroll_left, Fscroll_right):
7677 Use window_body_cols instead of window_box_text_cols.
7678 (delete_window, Fset_window_configuration):
7679 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7680 (delete_all_subwindows): Take a window as argument and not a
7681 structure. Rewrite.
190b47e6
MR
7682 (window_loop): Remove handling of GET_LRU_WINDOW and
7683 GET_LARGEST_WINDOW.
7684 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7685
7686 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7687 window_box_text_cols. delete_all_subwindows now takes a
7688 Lisp_Object as argument.
abde8f8c 7689
640c8776
SM
7690 * indent.c (compute_motion, Fcompute_motion):
7691 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7692
fa8a67e6
MR
7693 * frame.c (delete_frame): Call delete_all_subwindows with root
7694 window as argument.
7695
a54e3482
DC
76962011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7697
7698 * fns.c (Fputhash): Document return value.
7699
60002bf5
CY
77002011-06-06 Chong Yidong <cyd@stupidchicken.com>
7701
7702 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7703
0c671da6 77042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7705
b862a52a 7706 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7707
be44ca6c
PE
7708 Check for overflow when converting integer to cons and back.
7709 * charset.c (Fdefine_charset_internal, Fdecode_char):
7710 Use cons_to_unsigned to catch overflow.
7711 (Fencode_char): Use INTEGER_TO_CONS.
7712 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7713 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7714 * data.c (long_to_cons, cons_to_long): Remove.
7715 (cons_to_unsigned, cons_to_signed): New functions.
7716 These signal an error for invalid or out-of-range values.
7717 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7718 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7719 * font.c (Ffont_variation_glyphs):
7720 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7721 * lisp.h: Include <intprops.h>.
7722 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7723 (cons_to_signed, cons_to_unsigned): New decls.
7724 (long_to_cons, cons_to_long): Remove decls.
7725 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7726 (Fprimitive_undo): Use CONS_TO_INTEGER.
7727 * xfns.c (Fx_window_property): Likewise.
7728 * xselect.c: Include <limits.h>.
7729 (x_own_selection, selection_data_to_lisp_data):
7730 Use INTEGER_TO_CONS.
7731 (x_handle_selection_request, x_handle_selection_clear)
7732 (x_get_foreign_selection, Fx_disown_selection_internal)
7733 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7734 (lisp_data_to_selection_data): Use cons_to_unsigned.
7735 (x_fill_property_data): Use cons_to_signed.
7736 Report values out of range.
7737
d1f3d2af
PE
7738 Check for buffer and string overflow more precisely.
7739 * buffer.h (BUF_BYTES_MAX): New macro.
7740 * lisp.h (STRING_BYTES_MAX): New macro.
7741 * alloc.c (Fmake_string):
7742 * character.c (string_escape_byte8):
7743 * coding.c (coding_alloc_by_realloc):
7744 * doprnt.c (doprnt):
7745 * editfns.c (Fformat):
7746 * eval.c (verror):
7747 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7748 since they may not be the same number.
7749 * editfns.c (Finsert_char):
7750 * fileio.c (Finsert_file_contents):
7751 Likewise for BUF_BYTES_MAX.
7752
dd52fcea
PE
7753 * image.c: Use ptrdiff_t, not int, for sizes.
7754 (slurp_file): Switch from int to ptrdiff_t.
7755 All uses changed.
7756 (slurp_file): Check that file size fits in both size_t (for
7757 malloc) and ptrdiff_t (for sanity and safety).
7758
7f9bbdbb
PE
7759 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7760 if b->modtime has its maximal value.
7761
dfe18f82
PE
7762 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7763
84acfcf0
PE
7764 Don't assume time_t can fit into int.
7765 * buffer.h (struct buffer.modtime): Now time_t, not int.
7766 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7767 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7768
ccd9a01a
PE
7769 Minor fixes for signed vs unsigned integers.
7770 * character.h (MAYBE_UNIFY_CHAR):
7771 * charset.c (maybe_unify_char):
7772 * keyboard.c (read_char, reorder_modifiers):
7773 XINT -> XFASTINT, since the integer must be nonnegative.
7774 * ftfont.c (ftfont_spec_pattern):
7775 * keymap.c (access_keymap, silly_event_symbol_error):
7776 XUINT -> XFASTINT, since the integer must be nonnegative.
7777 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7778 since it makes no difference and we prefer signed.
7779 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7780 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7781 nonnegative.
7782
d6d100dd
SM
77832011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7784
7785 * window.h (Fwindow_frame): Declare.
7786
2b6148e4
PE
77872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7788
7789 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7790 (SPARE_MEMORY): Always define.
7791 (LARGE_REQUEST): Remove.
7792 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7793
f230ecc9
MR
77942011-06-06 Martin Rudalics <rudalics@gmx.at>
7795
727e958e
MR
7796 * lisp.h: Move EXFUNS for Fframe_root_window,
7797 Fframe_first_window and Fset_frame_selected_window to window.h.
7798
7799 * window.h: Move EXFUNS for Fframe_root_window,
7800 Fframe_first_window and Fset_frame_selected_window here from
7801 lisp.h.
7802
7803 * frame.c (Fwindow_frame, Fframe_first_window)
7804 (Fframe_root_window, Fframe_selected_window)
7805 (Fset_frame_selected_window): Move to window.c.
7806 (Factive_minibuffer_window): Move to minibuf.c.
7807 (Fother_visible_frames_p): New function.
7808
7809 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7810
f230ecc9
MR
7811 * window.c (decode_window, decode_any_window): Move up in code.
7812 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7813 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7814 (Fwindow_buffer): Move up and rewrite doc-string.
7815 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7816 (Fwindow_prev): New functions.
727e958e
MR
7817 (Fwindow_frame): Move here from frame.c. Accept any window as
7818 argument.
7819 (Fframe_root_window, Fframe_first_window)
7820 (Fframe_selected_window): Move here from frame.c. Accept frame
7821 or arbitrary window as argument. Update doc-strings.
7822 (Fminibuffer_window): Move up in code.
7823 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7824 (Fset_frame_selected_window): Move here from frame.c.
7825 Marginal rewrite.
727e958e
MR
7826 (Fselected_window, select_window, Fselect_window): Move up in
7827 code. Minor doc-string fixes.
f230ecc9 7828
4d09bcf6
PE
78292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7830
7831 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7832 Do not assume that spare memory exists; that assumption is valid
7833 only if SYSTEM_MALLOC.
7834 (LARGE_REQUEST): New macro, so that the issue of large requests
7835 is separated from the issue of spare memory.
7836
810928a2
AS
78372011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7838
172418ad
AS
7839 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7840 format. (Bug#8806)
7841
43f862f7
AS
7842 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7843
810928a2
AS
7844 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7845 before statements.
7846
a059fe24
JD
78472011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7848
7849 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7850
7851 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7852
7853 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7854 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7855
989bf368
JB
78562011-06-05 Juanma Barranquero <lekktu@gmail.com>
7857
7858 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7859
4b80f674
CY
78602011-06-04 Chong Yidong <cyd@stupidchicken.com>
7861
7862 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7863 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7864 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7865 New error handlers.
4b80f674
CY
7866 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7867 Obey Vx_select_enable_clipboard_manager. Catch errors in
7868 x_clipboard_manager_save (Bug#8779).
7869 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7870 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7871
99a33b77 78722011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7873
7874 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7875
99a33b77 78762011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7877
7878 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7879 in the current matrix if keep_current_p is non-zero.
7880
8264569d
EZ
78812011-06-04 Eli Zaretskii <eliz@gnu.org>
7882
7883 * bidi.c (bidi_level_of_next_char): Fix last change.
7884
57f97249
EZ
78852011-06-03 Eli Zaretskii <eliz@gnu.org>
7886
fec2107c 7887 Support bidi reordering of text covered by display properties.
57f97249 7888
fec2107c
EZ
7889 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7890 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7891 (bidi_cache_search, bidi_cache_iterator_state)
7892 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7893 (bidi_level_of_next_char, bidi_move_to_visually_next):
7894 Support character positions inside a run of characters covered by a
fec2107c
EZ
7895 display string.
7896 (bidi_paragraph_init, bidi_resolve_explicit_1)
7897 (bidi_level_of_next_char): Call bidi_fetch_char and
7898 bidi_fetch_char_advance instead of FETCH_CHAR and
7899 FETCH_CHAR_ADVANCE.
7900 (bidi_init_it): Initialize new members.
7901 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7902 definitions.
7903 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7904 instead of using explicit *_CHAR codes.
d6d100dd
SM
7905 (bidi_resolve_explicit, bidi_resolve_weak):
7906 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7907 bidirectional text is supported only in multibyte buffers.
7908 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7909 it to initialize the frame_window_p member of struct bidi_it.
7910 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7911 (bidi_resolve_explicit, bidi_resolve_weak)
7912 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7913 bidi_it->nchars is non-positive.
7914 (bidi_level_of_next_char): Don't try to lookup the cache for the
7915 next/previous character if nothing is cached there yet, or if we
7916 were just reseat()'ed to a new position.
c40e2fb2 7917
0e14fe90
EZ
7918 * xdisp.c (set_cursor_from_row): Set start and stop points
7919 according to the row's direction when priming the loop that looks
7920 for the glyph on which to display cursor.
7921 (single_display_spec_intangible_p): Function deleted.
7922 (display_prop_intangible_p): Reimplement to call
7923 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7924 Accept 3 additional arguments needed by handle_display_spec.
7925 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7926 values: lists, `(when COND...)' forms, etc.
7927 (single_display_spec_string_p): Support property values that are
7928 lists with the argument STRING its top-level element.
7929 (display_prop_string_p): Fix the condition for processing a
7930 property that is a list to be consistent with handle_display_spec.
fec2107c 7931 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7932 last portion of handle_display_prop.
7933 (compute_display_string_pos): Accept additional argument
7934 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7935 value of a `display' property is a "replacing spec".
7936 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7937 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7938 the display property, but just return a value indicating whether
7939 the display property will replace the characters it covers.
7940 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7941 frame_window_p members of struct bidi_it.
d6d100dd
SM
7942 (compute_display_string_pos, compute_display_string_end):
7943 New functions.
fec2107c
EZ
7944 (push_it): Accept second argument POSITION, where pop_it should
7945 jump to continue iteration.
7946 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7947
fec2107c
EZ
7948 * keyboard.c (adjust_point_for_property): Adjust the call to
7949 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7950
7951 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7952 (bidi_init_it): Update prototypes.
7953 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7954 (compute_display_string_pos, compute_display_string_end):
7955 Declare prototypes.
fec2107c
EZ
7956 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7957 EMACS_INT.
fc6f18ce 7958
40087514 79592011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7960
57f53182
PE
7961 Malloc failure behavior now depends on size of allocation.
7962 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7963 * lisp.h: Change signatures accordingly.
7964 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7965 All callers changed. (Bug#8762)
7966
7967 * gnutls.c: Use Emacs's memory allocators.
7968 Without this change, the gnutls library would invoke malloc etc.
7969 directly, which causes problems on non-SYNC_INPUT hosts, and which
7970 runs afoul of improving memory_full behavior. (Bug#8761)
7971 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7972 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7973 xfree instead of the default malloc, realloc, free.
7974 (Fgnutls_boot): No need to check for memory allocation failure,
7975 since xmalloc does that for us.
7976
ac32cd99 7977 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7978 * category.c (hash_get_category_set):
7979 * ccl.c (ccl_driver):
7980 * charset.c (Fdefine_charset_internal):
7981 * charset.h (struct charset.hash_index):
7982 * composite.c (get_composition_id, gstring_lookup_cache)
7983 (composition_gstring_put_cache):
7984 * composite.h (struct composition.hash_index):
7985 * dispextern.h (struct image.hash):
7986 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7987 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7988 (hashfn_equal, hashfn_user_defined, make_hash_table)
7989 (maybe_resize_hash_table, hash_lookup, hash_put)
7990 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7991 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7992 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7993 * image.c (make_image, search_image_cache, lookup_image)
7994 (xpm_put_color_table_h):
7995 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7996 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7997 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7998 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7999 * alloc.c (allocate_vectorlike):
8000 Check for overflow in vector size calculations.
8001 * ccl.c (ccl_driver):
8002 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8003 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8004 need to be updated by these changes.
40087514
PE
8005 * fns.c (make_hash_table, maybe_resize_hash_table):
8006 Check for integer overflow with large hash tables.
0de4bb68
PE
8007 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8008 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8009 (SXHASH_REDUCE): New macro.
8010 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8011 Use it instead of discarding useful hash info with large hash values.
8012 (sxhash_float): New function.
8013 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8014 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8015 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8016 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8017 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8018 Adjust signatures to match updated version of code.
8019 (consing_since_gc): Now EMACS_INT, since a single hash table can
8020 use more than INT_MAX bytes.
8021
698d32e2
DN
80222011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8023
8024 Make it possible to build with GCC-4.6+ -O2 -flto.
8025
8026 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8027
fd6fa53f
SM
80282011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8029
8030 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8031 Call minibuffer-inactive-mode.
8032
864db017
JB
80332011-05-31 Juanma Barranquero <lekktu@gmail.com>
8034
8035 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8036 Update dependencies.
8037
2ad0baf4
DN
80382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8039
8040 * data.c (init_data): Remove code for UTS, this system is not
8041 supported anymore.
8042
4fcc2638
DN
80432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8044
8045 Don't force ./temacs to start in terminal mode.
8046
8047 * frame.c (make_initial_frame): Initialize faces in all cases, not
8048 only when CANNOT_DUMP is defined.
8049 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8050
c56e0fd5
DN
80512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8052
8053 * dispnew.c (add_window_display_history): Use const for the string
8054 pointer. Remove declaration, not needed.
8055
333d54da 80562011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8057
55d4c1b2 8058 Use 'inline', not 'INLINE'.
333d54da 8059 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8060 * alloc.c, fontset.c (INLINE): Remove.
8061 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8062 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8063 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8064 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8065 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8066
738db178
DN
80672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8068
8069 Make it possible to run ./temacs.
8070
8071 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8072 syms_of_callproc does the same thing. Remove test for
8073 "initialized", do it in the caller.
8074 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8075
620c53a6
SM
80762011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8077
8078 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8079 (read_minibuf): Use get_minibuffer.
8080 (syms_of_minibuf): Use DEFSYM.
8081 (Qmetadata): New var.
8082 * data.c (Qbuffer): Don't make it static.
8083 (syms_of_data): Use DEFSYM.
8084
e003a292
PE
80852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8086
8087 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8088 (CCL_CODE_MIN): New macro.
8089
ed008a6d
PE
80902011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8091
3687c2ef
PE
8092 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8093
ed008a6d
PE
8094 * eval.c (Qdebug): Now static.
8095 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8096 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8097 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8098
d66c4c7c
CY
80992011-05-29 Chong Yidong <cyd@stupidchicken.com>
8100
8101 * image.c: Various fixes to ImageMagick code comments.
8102 (Fimagemagick_types): Doc fix.
8103
5fbc2025
PE
81042011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8105
0196f88a
PE
8106 Minor fixes prompted by GCC 4.6.0 warnings.
8107
8108 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8109
5fbc2025
PE
8110 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8111 (x_clipboard_manager_save_all): Move extern decl to ...
8112 * xterm.h: ... here, so that it can be checked for consistency.
8113
1dd3c2d9
CY
81142011-05-29 Chong Yidong <cyd@stupidchicken.com>
8115
8116 * xselect.c (x_clipboard_manager_save_frame)
8117 (x_clipboard_manager_save_all): New functions.
8118 (Fx_clipboard_manager_save): Lisp function deleted.
8119
8120 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8121 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8122
8123 * xterm.h: Update prototype.
8124
5ba6571d
WX
81252011-05-28 William Xu <william.xwl@gmail.com>
8126
8127 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8128 exiting (Bug#8239).
8129
3eaff834
JM
81302011-05-28 Jim Meyering <meyering@redhat.com>
8131
e1900994 8132 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8133 * fns.c (to_uchar): Define.
8134 (crypto_hash_function): Use it to convert some newly-signed
8135 variables to unsigned, to avoid sign-extension bugs. For example,
8136 without this change, (md5 "truc") would evaluate to
8137 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8138 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8139 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8140
0f6990a7
PE
81412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8142
8143 Integer overflow fixes.
c8a9ca5a 8144
08686060
PE
8145 * dbusbind.c: Serial number integer overflow fixes.
8146 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8147 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8148 to hold a serial number that is too large for a fixnum.
8149 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8150 Check for serial numbers out of range. Decode any serial number
59568bf0 8151 that was so large that it became a float. (Bug#8722)
08686060 8152
2d1fc3c7
PE
8153 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8154 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8155 Use XFASTINT rather than XUINT when numbers are nonnegative.
8156 (xd_append_arg, Fdbus_method_return_internal):
8157 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8158 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8159 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8160 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8161 (Bug#8722)
2d1fc3c7 8162
c8a9ca5a
PE
8163 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8164
519e1d69
PE
8165 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8166
6df6ae42 8167 ccl: Add integer overflow checks.
30569699
PE
8168 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8169 (IN_INT_RANGE): New macros.
8170 (ccl_driver): Use them to check for integer overflow when
8171 decoding a CCL program. Many of the new checks are whether XINT (x)
8172 fits in int; it doesn't always, on 64-bit hosts. The new version
8173 doesn't catch all possible integer overflows, but it's an
847044ea 8174 improvement. (Bug#8719)
30569699 8175
c11285dc
PE
8176 * alloc.c (make_event_array): Use XINT, not XUINT.
8177 There's no need for unsigned here.
8178
fdccd48e
PE
8179 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8180 This follows up to the 2011-05-06 change that substituted uintptr_t
8181 for EMACS_INT. This case wasn't caught back then.
8182
37910ab2
PE
8183 Rework Fformat to avoid integer overflow issues.
8184 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8185 now (part of C89). Include <verify.h>.
8186 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8187 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8188 (Fformat): Avoid the prepass trying to compute sizes; it was only
8189 approximate and thus did not catch overflow reliably. Instead, walk
8190 through the format just once, formatting and computing sizes as we go,
8191 checking for integer overflow at every step, and allocating a larger
8192 buffer as needed. Keep track separately whether the format is
8193 multibyte. Keep only the most-recently calculated precision, rather
8194 than them all. Record whether each argument has been converted to
8195 string. Use EMACS_INT, not int, for byte and char and arg counts.
8196 Support field widths and precisions larger than INT_MAX. Avoid
8197 sprintf's undefined behavior with conversion specifications such as %#d
8198 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8199 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8200 formatting out-of-range floating point numbers with int
9173deec 8201 formats. (Bug#8668)
37910ab2 8202
2e6578fb
PE
8203 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8204
0ae6bdee
PE
8205 * data.c: Avoid integer truncation in expressions involving floats.
8206 * data.c: Include <intprops.h>.
8207 (arith_driver): When there's an integer overflow in an expression
8208 involving floating point, convert the integers to floating point
8209 so that the resulting value does not suffer from catastrophic
8210 integer truncation. For example, on a 64-bit host (* 4
8211 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8212 Do not rely on undefined behavior after integer overflow.
8213
de883a70
PE
8214 merge count_size_as_multibyte, parse_str_to_multibyte
8215 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8216 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8217 Check for integer overflow.
8218 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8219 since it's now a duplicate of the other. This is more of
8220 a character than a buffer op, so better that it's in character.c.
8221 * fns.c, print.c: Adjust to above changes.
8222
2ff916cb
PE
82232011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8224
8225 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8226
f1b54466
PE
82272011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8228
fb1ac845
PE
8229 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8230 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8231 (x_clipboard_manager_save): Now static.
8232 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8233
f1b54466
PE
8234 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8235 (crypto_hash_function): Now static.
8236 Fix pointer signedness problems. Avoid unnecessary initializations.
8237
a9f737ee
CY
82382011-05-27 Chong Yidong <cyd@stupidchicken.com>
8239
8240 * termhooks.h (Vselection_alist): Make it terminal-local.
8241
8242 * terminal.c (create_terminal): Initialize it.
8243
8244 * xselect.c: Support for clipboard managers.
8245 (Vselection_alist): Move to termhooks.h as terminal-local var.
8246 (LOCAL_SELECTION): New macro.
8247 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8248 (symbol_to_x_atom): Remove gratuitous arg.
8249 (x_handle_selection_request, lisp_data_to_selection_data)
8250 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8251 (x_own_selection, x_get_local_selection, x_convert_selection):
8252 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8253 (some_frame_on_display): Delete unused function.
8254 (Fx_own_selection_internal, Fx_get_selection_internal)
8255 (Fx_disown_selection_internal, Fx_selection_owner_p)
8256 (Fx_selection_exists_p): New optional frame arg.
8257 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8258 (x_handle_selection_clear): Don't treat other terminals with the
8259 same keyboard specially. Use the terminal-local Vselection_alist.
8260 (x_clear_frame_selections): Use Frun_hook_with_args.
8261
8262 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8263
8264 * xterm.h: Add support for those atoms.
8265
e067f0c1
CY
82662011-05-26 Chong Yidong <cyd@stupidchicken.com>
8267
8268 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8269 (converted_selections, conversion_fail_tag): New global variables.
8270 (x_selection_request_lisp_error): Free the above.
8271 (x_get_local_selection): Remove unnecessary code.
8272 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8273 of converted selections stored in converted_selections.
8274 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8275 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8276 (x_convert_selection): New function.
8277 (x_handle_selection_event): Simplify.
8278 (x_get_foreign_selection): Don't ignore incoming requests while
8279 waiting for an answer; this will fail when we implement
8280 SAVE_TARGETS, and seems unnecessary anyway.
8281 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8282 (Vx_sent_selection_functions): Doc fix.
8283
0f4aebc0
LL
82842011-05-26 Leo Liu <sdl.web@gmail.com>
8285
8286 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8287
e61124cd
YM
82882011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8289
8290 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8291
8292 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8293 for fringe update if it has periodic bitmap.
ac389d0c 8294 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8295 and fringe_bitmap_periodic_p.
8296
8297 * fringe.c (get_fringe_bitmap_data): New function.
8298 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8299 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8300 row. Mark glyph row for fringe update if periodicity changed.
8301
8302 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8303 for fringe update unless it has periodic bitmap.
8304
f16d9837
KH
83052011-05-25 Kenichi Handa <handa@m17n.org>
8306
8307 * xdisp.c (get_next_display_element): Set correct it->face_id for
8308 a static composition.
8309
e1b90ef6
LL
83102011-05-24 Leo Liu <sdl.web@gmail.com>
8311
8312 * deps.mk (fns.o):
8313 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8314
8315 * fns.c (crypto_hash_function, Fsha1): New function.
8316 (Fmd5): Use crypto_hash_function.
8317 (syms_of_fns): Add Ssha1.
8318
7400048f
PE
83192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8320
8321 * gnutls.c: Remove unused macros.
8322 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8323 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8324 Remove macros that are defined and never used.
8325 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8326
abb71cf4
CY
83272011-05-22 Chong Yidong <cyd@stupidchicken.com>
8328
8329 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8330 (Fx_get_selection_internal): Minor cleanup.
8331 (Fx_own_selection_internal): Rename arguments for consistency with
8332 select.el.
8333
6307db39
PE
83342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8335
8336 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8337
f3d4e0a4
CY
83382011-05-22 Chong Yidong <cyd@stupidchicken.com>
8339
8340 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8341
4d8ade89
YM
83422011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8343
8344 * dispnew.c (scrolling_window): Don't exclude the case that the
8345 last enabled row in the desired matrix touches the bottom boundary.
8346
32078c8d
GM
83472011-05-21 Glenn Morris <rgm@gnu.org>
8348
8349 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8350 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8351 and add some more files.
32078c8d 8352
7285dc67
EZ
83532011-05-20 Eli Zaretskii <eliz@gnu.org>
8354
8355 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8356 report_file_error introduced by the change from 2011-05-07.
8357
89d1bd22
PE
83582011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8359
8360 * systime.h (Time): Define only if emacs is defined.
8361 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8362 where the include path doesn't have X11/X.h by default. See
8363 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8364
cd394be1 83652011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8366
8367 * composite.c (find_automatic_composition): Fix previous change.
8368
b9704ad9
GM
83692011-05-20 Glenn Morris <rgm@gnu.org>
8370
8371 * lisp.mk: New file, split from Makefile.in.
8372 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8373 (shortlisp): Remove.
8374 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8375
4a720484
GM
83762011-05-19 Glenn Morris <rgm@gnu.org>
8377
8378 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8379 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8380 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8381 (lisp): Set the order to that of loadup.el.
8382 (shortlisp): Make it a copy of $lisp.
8383 (SOME_MACHINE_LISP): Remove.
8384 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8385 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8386
a28d4396
KH
83872011-05-18 Kenichi Handa <handa@m17n.org>
8388
8389 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8390 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8391 (find_automatic_composition): Mostly rewrite for efficiency.
8392
a2b1fa8e
JB
83932011-05-18 Juanma Barranquero <lekktu@gmail.com>
8394
8395 * makefile.w32-in: Update dependencies.
8396
8e1f5610
CS
83972011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8398
8399 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8400 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8401
7025ee00 84022011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8403
cdfa6eab
PE
8404 Fix some integer overflow issues, such as string length overflow.
8405
06d6db33
PE
8406 * insdel.c (count_size_as_multibyte): Check for string overflow.
8407
2b4560a8
PE
8408 * character.c (lisp_string_width): Check for string overflow.
8409 Use EMACS_INT, not int, for string indexes and lengths; in
8410 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8411 the resulting string length overflows an EMACS_INT; instead,
8412 report a string overflow if no precision given. When checking for
8413 precision exhaustion, use a check that cannot possibly have
8414 integer overflow. (Bug#8675)
8415 * character.h (lisp_string_width): Adjust to new signature.
8416
cb93f9be
PE
8417 * alloc.c (string_overflow): New function.
8418 (Fmake_string): Use it. This doesn't change behavior, but saves
8419 a few bytes and will simplify future changes.
8420 * character.c (string_escape_byte8): Likewise.
8421 * lisp.h (string_overflow): New decl.
8422
1a1f3366
PE
8423 Fixups, following up to the user-interface timestamp change.
8424 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8425 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8426 * msdos.c (mouse_get_pos): Likewise.
8427 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8428 * w32gui.h (Time): Define by including "systime.h" rather than by
8429 declaring it ourselves. (Bug#8664)
8430
d4e3e4d3
PE
8431 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8432 * image.c (clear_image_cache): Likewise.
8433
f6a24d19
PE
8434 * term.c (term_mouse_position): Don't assume time_t wraparound.
8435
08dc5ae6
PE
8436 Be more systematic about user-interface timestamps.
8437 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8438 and sometimes 'EMACS_UINT', to represent these timestamps.
8439 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8440 This makes the code easier to follow, and makes it easier to catch
8441 integer overflow bugs such as Bug#8664.
8442 * frame.c (Fmouse_position, Fmouse_pixel_position):
8443 Use Time, not unsigned long, for user-interface timestamps.
8444 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8445 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8446 * keyboard.h (last_event_timestamp): Likewise.
8447 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8448 * menu.h (xmenu_show): Likewise.
8449 * term.c (term_mouse_position): Likewise.
8450 * termhooks.h (struct input_event.timestamp): Likewise.
8451 (struct terminal.mouse_position_hook): Likewise.
8452 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8453 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8454 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8455 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8456 what it was before.
8457 * menu.h, termhooks.h: Include "systime.h", for Time.
8458
8e55734a
PE
8459 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8460 Don't assume that the difference between two unsigned long values
8461 can fit into an integer. At this point, we know button_down_time
8462 <= event->timestamp, so the difference must be nonnegative, so
8463 there's no need to cast the result if double-click-time is
8464 nonnegative, as it should be; check that it's nonnegative, just in
8465 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8466 apart (about 25 days). (Bug#8664)
8e55734a 8467
841f1b75 8468 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8469 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8470
3e26f69c
PE
8471 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8472 that always fit in int. Use a sentinel instead of a counter, to
8473 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8474 * frame.h (struct frame): Use int for menu_bar_items_used
8475 instead of EMACS_INT, since it always fits in int.
3e26f69c 8476
5cc152c0
PE
8477 * menu.c (grow_menu_items): Check for int overflow.
8478
d89eb65e
PE
8479 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8480
5235bd3e
PE
8481 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8482 Before, the code was not consistent. These values cannot exceed
8483 2**31 - 1 so there's no need to make them unsigned.
8484 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8485 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8486 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8487 as modifiers.
8488 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8489
bc827e23
PE
8490 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8491 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8492 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8493 presumably because the widths might not match.
8494
78eb494e
PE
8495 * window.c (size_window): Avoid needless test at loop start.
8496
04f2d78b
CB
84972011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8498
8499 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8500
d2fc7e3d 85012011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8502
8503 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8504
d2fc7e3d 85052011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8506
8507 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8508 `width' to `bar_area_x' and `bar_area_width', respectively.
8509 (x_scroll_run): Take account of fringe background extension.
8510
04f2d78b
CB
8511 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8512 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8513 `bar_area_width', respectively.
8514 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8515 background extension.
8516
79b70037
GM
85172011-05-10 Jim Meyering <meyering@redhat.com>
8518
8519 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8520
2f142cc5
JB
85212011-05-10 Juanma Barranquero <lekktu@gmail.com>
8522
8523 * image.c (Finit_image_library): Return t for built-in image types,
8524 like pbm and xbm. (Bug#8640)
8525
57679c86
AS
85262011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8527
8528 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8529
888c9e86
EZ
85302011-05-07 Eli Zaretskii <eliz@gnu.org>
8531
b0512a1d
EZ
8532 * w32console.c (Fset_screen_color): Doc fix.
8533 (Fget_screen_color): New function.
8534 (syms_of_ntterm): Defsubr it.
8535
7285dc67
EZ
8536 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8537 unlink the temporary file if Fcall_process didn't create it in the
8538 first place.
8539 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8540 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8541 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8542 cue to call_process_cleanup not to close that handle.
8543
4d3fcc8e
BK
85442011-05-07 Ben Key <bkey76@gmail.com>
8545
8546 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8547 one of two shell specific rules, either bootstrap-temacs-CMD or
8548 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8549 to the previous implementation of the bootstrap-temacs rule.
8550 The bootstrap-temacs-CMD rule is similar to the previous
8551 implementation of the bootstrap-temacs rule except that it
8552 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8553 variable.
8554
8555 These changes, along with some changes to nt/configure.bat,
8556 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8557 earlier fix to add support for --cflags and --ldflags options
8558 that include quotes so that it works whether make uses cmd or
8559 sh as the shell.
8560
b4289b64
MA
85612011-05-06 Michael Albinus <michael.albinus@gmx.de>
8562
8563 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8564 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8565 is a constant.
8566 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8567 a string. Handle both cases.
8568 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8569 (Fdbus_register_method): Use Qinvalid_function.
8570
af4c0e28
JB
85712011-05-06 Juanma Barranquero <lekktu@gmail.com>
8572
8573 * makefile.w32-in: Update dependencies.
8574 (LISP_H): Add inttypes.h and stdin.h.
8575 (PROCESS_H): Add unistd.h.
8576
c51453d9
EZ
85772011-05-06 Eli Zaretskii <eliz@gnu.org>
8578
8579 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8580 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8581
8ff0ac3c 85822011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8583
4c4b566b
PE
8584 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8585
aab2b9b5
PE
8586 * term.c (vfatal): Remove stray call to va_end.
8587 It's not needed and the C Standard doesn't allow it here anyway.
8588
c378da0b
PE
8589 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8590 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8591
288b08c7
PE
8592 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8593 bytes.
8594
e3601888
PE
8595 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8596
db6c0e74
PE
8597 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8598
dd5963ea
PE
8599 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8600
88c9450f
PE
8601 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8602
2f9442b8
PE
8603 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8604
c032b5f8
PE
8605 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8606 * charset.c (Fdefine_charset_internal): Don't initialize
8607 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8608 32-bit int (Bug#8600).
a108c10b
PE
8609
8610 * lread.c (read_integer): Be more consistent with string-to-number.
8611 Use string_to_number to do the actual conversion; this avoids
8612 rounding errors and fixes some other screwups. Without this fix,
8613 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8614 (digit_to_number): Move earlier, for benefit of read_integer.
8615 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8616 not a digit in any supported base. (Bug#8602)
a108c10b 8617
ad5f9eea
PE
8618 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8619
aec1708a
PE
8620 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8621 to match comment at start of function. This also removes a
8622 GCC warning about overflow in a 32+64-bit port.
8623
47be4ab5
PE
8624 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8625
371cac43
PE
8626 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8627 Reported by Stefan Monnier in
8628 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8629 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8630 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8631
d01a7826
PE
8632 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8633 (EMACS_UINTPTR): Likewise, with uintptr_t.
8634
7fd47d5c
PE
8635 * lisp.h: Prefer 64-bit EMACS_INT if available.
8636 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8637 on 32-bit hosts that have 64-bit int, so that they can access
8638 large files.
122b0c86
PE
8639 However, temporarily disable this change unless the temporary
8640 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8641
8727937b
PE
8642 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8643
8ac068ac
PE
8644 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8645 This removes an assumption that EMACS_INT and long are the same
8646 width as pointers. The assumption is true for Emacs porting targets
8647 now, but we want to make other targets possible.
8648 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8649 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8650 In the rest of the code, change types of integers that hold casted
8651 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8652 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8653 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8654 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8655 No need to cast type when ORing.
8656 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8657 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8658 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8659 assume EMACS_INT is the same width as char *.
8660 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8661 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8662 Remove no-longer-needed casts.
8663 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8664 (xg_tool_bar_help_callback, xg_make_tool_item):
8665 Use EMACS_INTPTR to hold an integer
8666 that will be cast to void *; this can avoid a GCC warning
8667 if EMACS_INT is not the same width as void *.
8668 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8669 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8670 (current_message_1, set_message_1):
8671 Use a local to convert to proper width without a cast.
8672 * xmenu.c (dialog_selection_callback): Likewise.
8673
ede49d71
PE
8674 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8675 Also, don't assume VALBITS / RAND_BITS is less than 5,
8676 and don't rely on undefined behavior when shifting a 1 left into
8677 the sign bit.
8678 * lisp.h (get_random): Change signature to match.
8679
2f30ecd0
PE
8680 * lread.c (hash_string): Use size_t, not int, for hash computation.
8681 Normally we prefer signed values; but hashing is special, because
8682 it's better to use unsigned division on hash table sizes so that
8683 the remainder is nonnegative. Also, size_t is the natural width
8684 for hashing into memory. The previous code used 'int', which doesn't
8685 retain enough info to hash well into very large tables.
8686 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8687
2a866e7b
PE
8688 * dbusbind.c: Don't possibly lose pointer info when converting.
8689 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8690 Use XPNTR rather than XHASH, so that the high-order bits of
8691 the pointer aren't lost when converting through void *.
8692
51639eac
PE
8693 * eval.c (Fautoload): Don't double-shift a pointer.
8694
92394119
PE
8695 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8696
dbdb9a7c
JB
86972011-05-06 Juanma Barranquero <lekktu@gmail.com>
8698
8699 * gnutls.c (DEF_GNUTLS_FN):
8700 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8701
db7a0b4f
AS
87022011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8703
8704 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8705 marker. (Bug#8610)
8706
cd394be1 87072011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8708
8709 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8710 New version that can reserve upto 2GB of heap space.
8711
f7ff1b0f 87122011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8713
8714 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8715
639c109b
TZ
87162011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8717
8718 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8719 `gnutls_certificate_set_x509_key_file'.
8720
d2127135
JB
87212011-05-05 Juanma Barranquero <lekktu@gmail.com>
8722
8723 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8724 Update dependencies.
8725
e968f4f3
JB
87262011-05-04 Juanma Barranquero <lekktu@gmail.com>
8727
8728 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8729 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8730 Remove unused parameter `fildes'.
8731 * process.c (read_process_output, send_process): Don't pass it.
8732
84d358f0
JB
87332011-05-04 Juanma Barranquero <lekktu@gmail.com>
8734
8735 Fix previous change: the library cache is defined in w32.c.
8736 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8737 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8738
0898ca10
JB
87392011-05-04 Juanma Barranquero <lekktu@gmail.com>
8740
8741 Implement dynamic loading of GnuTLS on Windows.
8742
8743 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8744 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8745 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8746 Declare.
8747
8748 * gnutls.c (Qgnutls_dll): Define.
8749 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8750 (gnutls_*): Declare function pointers.
8751 (init_gnutls_functions): New function to initialize function pointers.
8752 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8753 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8754 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8755 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8756 (emacs_gnutls_write, emacs_gnutls_read)
8757 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8758 (Fgnutls_available_p): New function.
8759 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8760 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8761 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8762
8763 * image.c: Include w32.h.
8764 (Vimage_type_cache): Delete.
8765 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8766 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8767 (w32_delayed_load): Move to w32.c.
8768
8769 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8770
8771 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8772 (w32_delayed_load): Move from image.c. When loading a library, record
8773 its filename in the :loaded-from property of the library id.
8774 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8775 Initialize and staticpro them.
8776 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8777
8778 * process.c: Include lisp.h before w32.h, not after.
8779 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8780 instead of gnutls_record_check_pending.
8781
8782 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8783
ff4de4aa
TZ
87842011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8785
8786 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8787 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8788 as passed in.
8789
abe95abb
JD
87902011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8791
8792 * xterm.c (x_set_frame_alpha): Do not set property on anything
8793 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8794
e16e55d4
JB
87952011-05-02 Juanma Barranquero <lekktu@gmail.com>
8796
8797 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8798
bafcf6a5
JB
87992011-05-02 Juanma Barranquero <lekktu@gmail.com>
8800
8801 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8802 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8803 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8804 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8805 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8806 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8807 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8808 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8809 (Qgnutls_bootprop_callbacks_verify): Make static.
8810
e7a6747f
AS
88112011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8812
19ed11ba
AS
8813 * callproc.c: Indentation fixup.
8814
e7a6747f 8815 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8816 (wait_for_termination, interruptible_wait_for_termination):
8817 Move after wait_for_termination_1.
e7a6747f 8818
1ef14cb4
LMI
88192011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8820
8821 * sysdep.c (interruptible_wait_for_termination): New function
8822 which is like wait_for_termination, but allows keyboard
8823 interruptions.
8824
8825 * callproc.c (Fcall_process): Add (:file "file") as an option for
8826 the STDOUT buffer.
8827 (Fcall_process_region): Ditto.
8828
330d880c
EZ
88292011-04-30 Eli Zaretskii <eliz@gnu.org>
8830
8db90b73
EZ
8831 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8832 rather than `XVECTOR (FOO)->size'.
8833
330d880c
EZ
8834 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8835 inttypes.h, as a gnulib replacement is used if it not available in
8836 system headers.
8837
15cbd324
EZ
88382011-04-21 Eli Zaretskii <eliz@gnu.org>
8839
8840 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8841 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8842 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8843
8844 * coding.c (coding_alloc_by_realloc): Error out if destination
8845 will grow beyond MOST_POSITIVE_FIXNUM.
8846 (decode_coding_emacs_mule): Abort if there isn't enough place in
8847 charbuf for the composition carryover bytes. Reserve an extra
8848 space for up to 2 characters produced in a loop.
8849 (decode_coding_iso_2022): Abort if there isn't enough place in
8850 charbuf for the composition carryover bytes.
8851
88522011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8853
ae940cca
EZ
8854 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8855 aborting when %lld or %lll format is passed.
8856 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8857 %llo or %llx format is passed. (Bug#8545)
8858
03ab8921
EZ
8859 * window.c (window_scroll_line_based): Use a marker instead of
8860 simple variables to record original value of point. (Bug#7952)
8861
afda1437
EZ
8862 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8863 produced by %s or %c overflows available buffer space. (Bug#8545)
8864
f76dee0c
PE
88652011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8866
8867 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8868 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8869
fdc5744d
JB
88702011-04-28 Juanma Barranquero <lekktu@gmail.com>
8871
8872 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8873
638f053a
JB
88742011-04-28 Juanma Barranquero <lekktu@gmail.com>
8875
8876 * keyboard.c (Qdelayed_warnings_hook): Define.
8877 (command_loop_1): Run `delayed-warnings-hook'
8878 if Vdelayed_warnings_list is non-nil.
8879 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8880 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8881
d178f871
EZ
88822011-04-28 Eli Zaretskii <eliz@gnu.org>
8883
8884 * doprnt.c (doprnt): Don't return value smaller than the buffer
8885 size if the message was truncated. (Bug#8545).
8886
b124fd93
JB
88872011-04-28 Juanma Barranquero <lekktu@gmail.com>
8888
8889 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8890 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8891
e810457d
PE
88922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8893
8894 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8895
ea51cceb
JB
88962011-04-27 Juanma Barranquero <lekktu@gmail.com>
8897
8898 * makefile.w32-in: Update dependencies.
8899
94dcfacf
EZ
89002011-04-27 Eli Zaretskii <eliz@gnu.org>
8901
8902 Improve `doprnt' and its usage. (Bug#8545)
8903 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8904 `format_end'. Remove support for %l as a conversion specifier.
8905 Don't use xrealloc. Improve diagnostics when the %l size modifier
8906 is used. Update the commentary.
8907
8908 * eval.c (verror): Simplify calculation of size_t.
8909
8910 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8911 messages.
8912
f61f41d7
PE
89132011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8914
8915 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8916 change.
8917
96fb4434
PE
89182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8919
8920 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8921 This makes this file independent of the recent pseudovector change.
8922
671875da 89232011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8924
69e9b5a3
PE
8925 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8926
b5f869a7 8927 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8928 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8929 Remove unused local.
c8926152 8930 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8931
841a1577 8932 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8933 GCC 4.6.0 optimizes based on type-based alias analysis.
8934 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8935 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8936 != &v->size, and therefore "v->size = 1; b->size = 2; return
8937 v->size;" must therefore return 1. This assumption is incorrect
8938 for Emacs, since it type-puns struct Lisp_Vector * with many other
8939 types. To fix this problem, this patch adds a new type struct
f904488f 8940 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8941 and pseudovectors, and helps optimizing compilers not get fooled
8942 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8943 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8944 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8945 the size member.
eab3844f
PE
8946 (XSETPVECTYPE): Rewrite in terms of new macro.
8947 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8948 This is a bit clearer, and further avoids the possibility of
8949 undesirable aliasing.
8950 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8951 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8952 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8953 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8954 (ASIZE): Now uses header.size rather than size.
8955 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8956 to avoid the hassle of writing XVECTOR (foo)->header.size.
8957 (struct vectorlike_header): New type.
eab3844f
PE
8958 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8959 object, to help avoid aliasing.
8960 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8961 (SUBRP): Likewise, since Lisp_Subr is a special case.
8962 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8963 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8964 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8965 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8966 changed to be "header.size" and "header.next".
8967 * buffer.h (struct buffer): Likewise.
8968 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8969 * frame.h (struct frame): Likewise.
8970 * process.h (struct Lisp_Process): Likewise.
8971 * termhooks.h (struct terminal): Likewise.
8972 * window.c (struct save_window_data, struct saved_window): Likewise.
8973 * window.h (struct window): Likewise.
8974 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8975 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8976 * buffer.c (init_buffer_once): Likewise.
8977 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8978 special case.
8979 * process.c (Fformat_network_address): Use local var for size,
8980 for brevity.
8981
0df1eac5
PE
8982 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8983
847ab9d1 8984 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8985 * data.c (atof): Remove decl; no longer used or needed.
8986 (digit_to_number): Move to lread.c.
8987 (Fstring_to_number): Use new string_to_number function, to be
8988 consistent with how the Lisp reader treats infinities and NaNs.
8989 Do not assume that floating-point numbers represent EMACS_INT
8990 without losing information; this is not true on most 64-bit hosts.
8991 Avoid double-rounding errors, by insisting on integers when
8992 parsing non-base-10 numbers, as the documentation specifies.
8993 * lisp.h (string_to_number): New decl, replacing ...
8994 (isfloat_string): Remove.
bc0a5c13 8995 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8996 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8997 appears to have been a coding error. Similarly, do not accept
8998 strings like +-1e0 as floating point numbers. Do not report
8999 overflow for integer overflows unless the base is not 10 which
9000 means we have no simple and reliable way to continue.
9001 Break out the floating-point parsing into a new
9002 function string_to_number, so that Fstring_to_number parses
9003 floating point numbers consistently with the Lisp reader.
04f2d78b 9004 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9005 (E_CHAR, EXP_INT): Remove, replacing with ...
9006 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9007 (string_to_number): New function, replacing isfloat_string.
9008 This function checks for valid syntax and produces the resulting
9009 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9010 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9011 so that overflow for non-base-10 numbers is reported only when
9012 there's no portable and simple way to convert to floating point.
452f4150 9013
67769ffc
PE
9014 * textprop.c (set_text_properties_1): Rewrite for clarity,
9015 and to avoid GCC warning about integer overflow.
9016
c20db43f
PE
9017 * intervals.h (struct interval): Use EMACS_INT for members
9018 where EMACS_UINT might cause problems. See
9019 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9020 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9021 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9022 All uses changed.
37aa2f85
PE
9023 (offset_intervals): Tell GCC not to worry about length overflow
9024 when negating a negative length.
c20db43f 9025
2538aa2f
PE
9026 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9027 (overrun_check_free): Likewise.
9028
f2d3008d
PE
9029 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9030 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9031 word size.
9032
ec8df744
PE
9033 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9034 (gnutls_make_error): Rename local to avoid shadowing.
9035 (gnutls_emacs_global_deinit): ifdef out; not used.
9036 (Fgnutls_boot): Use const for pointer to readonly storage.
9037 Comment out unused local. Fix pointer signedness problems.
9038
640ee02d
PE
9039 * lread.c (openp): Don't stuff size_t into an 'int'.
9040 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9041 about possible signed overflow.
9042
6048fb2a
PE
9043 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9044 (GDK_KEY_g): Don't define if already defined.
9045 (xg_prepare_tooltip): Avoid pointer signedness problem.
9046 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9047
fa3c87e1
PE
9048 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9049 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9050
2172544b
PE
9051 * xfns.c (Fx_window_property): Simplify a bit,
9052 to make a bit faster and to avoid GCC 4.6.0 warning.
9053 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9054
9b821a21
PE
9055 * fns.c (internal_equal): Don't assume size_t fits in int.
9056
3c616cfa
PE
9057 * alloc.c (compact_small_strings): Tighten assertion a little.
9058
c2982e87
PE
9059 Replace pEd with more-general pI, and fix some printf arg casts.
9060 * lisp.h (pI): New macro, generalizing old pEd macro to other
9061 conversion specifiers. For example, use "...%"pI"d..." rather
9062 than "...%"pEd"...".
9063 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9064 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9065 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9066 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9067 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9068 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9069 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9070 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9071 64-bit hosts.
9072 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9073 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9074 * print.c (safe_debug_print, print_object): Likewise.
9075 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9076 to int.
6f04d126
PE
9077 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9078 avoiding the 0 flag, which is not portable.
c2982e87
PE
9079 * process.c (Fmake_network_process): Use pI to avoid cast.
9080 * region-cache.c (pp_cache): Likewise.
9081 * xdisp.c (decode_mode_spec): Likewise.
9082 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9083 behavior on 64-bit hosts with printf arg.
6f04d126 9084 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9085 (x_stop_queuing_selection_requests): Likewise.
9086 (x_get_window_property): Don't truncate byte count to an 'int'
9087 when tracing.
0b432f21 9088
5e073ec7
PE
9089 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9090 here, since it parses constructs like leading '-' and spaces,
9091 which are not wanted; and it overflows with large numbers.
9092 Instead, simply match F[0-9]+, which is what is wanted anyway.
9093
36372bf9
PE
9094 * alloc.c: Remove unportable assumptions about struct layout.
9095 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9096 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9097 (allocate_vectorlike, make_pure_vector): Use the new macros,
9098 plus offsetof, to remove unportable assumptions about struct layout.
9099 These assumptions hold on all porting targets that I know of, but
9100 they are not guaranteed, they're easy to remove, and removing them
9101 makes further changes easier.
9102
0b432f21
PE
9103 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9104 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9105 (string_overrun_cookie): Now const. Use initializers that
9106 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9107 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9108 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9109 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9110 multiple of sizeof (EMACS_INT); it need not be, if
9111 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9112 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9113
895009e1
JB
91142011-04-26 Juanma Barranquero <lekktu@gmail.com>
9115
9116 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9117
6a7a1b0b
TZ
91182011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9119
9120 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9121 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9122 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9123
841a1577 91242011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9125
9126 * lisp.h (Qdebug): List symbol.
895009e1 9127 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9128 * keyboard.c (debug-on-event): New variable.
9129 (handle_user_signal): Break into debugger when debug-on-event
9130 matches the current signal symbol.
9131
f2d3ba6f
DN
91322011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9133
9134 * alloc.c (check_sblock, check_string_bytes)
9135 (check_string_free_list): Convert to standard C.
9136
42ce4c63
TZ
91372011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9138
9139 * w32.c (emacs_gnutls_push): Fix typo.
9140
825cd63c
EZ
91412011-04-25 Eli Zaretskii <eliz@gnu.org>
9142
fb11d64d
EZ
9143 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9144 "cast to pointer from integer of different size".
9145
825cd63c
EZ
9146 Improve doprnt and its use in verror. (Bug#8545)
9147 * doprnt.c (doprnt): Document the set of format control sequences
9148 supported by the function. Use SAFE_ALLOCA instead of always
9149 using `alloca'.
9150
9151 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9152 is one byte too soon. Don't use xrealloc; instead xfree and
9153 xmalloc anew.
9154
e061a11b
TZ
91552011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9156
9157 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9158 callbacks stage.
9159
9160 * gnutls.c: Renamed global_initialized to
9161 gnutls_global_initialized. Added internals for the
9162 :verify-hostname-error, :verify-error, and :verify-flags
9163 parameters of `gnutls-boot' and documented those parameters in the
9164 docstring. Start callback support.
9173deec
JB
9165 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9166 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9167 on error. Return error code.
e061a11b
TZ
9168 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9169 (emacs_gnutls_read): Likewise.
9170 (Fgnutls_boot): Return handshake error code.
9171 (emacs_gnutls_handle_error): New function.
9172 (wsaerror_to_errno): Likewise.
9173
9174 * w32.h (emacs_gnutls_pull): Add prototype.
9175 (emacs_gnutls_push): Likewise.
9176
9177 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9178 (emacs_gnutls_push): Likewise.
9179
91802011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9181
9182 * process.c (wait_reading_process_output): Check if GnuTLS
9183 buffered some data internally if no FDs are set for TLS
9184 connections.
9185
9186 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9187 (LIBS): Link to USER_LIBS.
9188 ($(BLD)/gnutls.$(0)): New target.
9189
fa6996bc
EZ
91902011-04-24 Eli Zaretskii <eliz@gnu.org>
9191
eb35682e
EZ
9192 * xdisp.c (handle_single_display_spec): Rename the
9193 display_replaced_before_p argument into display_replaced_p, to
9194 make it consistent with the commentary. Fix typos in the
9195 commentary.
9196
e2ad650c
EZ
9197 * textprop.c (syms_of_textprop): Remove dead code.
9198 (copy_text_properties): Delete obsolete commentary about an
9199 interface that was deleted long ago. Fix typos in the description
9200 of arguments.
9201
1b2de274
EZ
9202 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9203 to changes in oldXMenu/XMenu.h from 2011-04-16.
9204 <menu_help_message, prev_menu_help_message>: Constify.
9205 (IT_menu_make_room): menu->help_text is now `const char **';
9206 adjust.
9207
9208 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9209 to changes in oldXMenu/XMenu.h from 2011-04-16.
9210 (struct XMenu): Declare `help_text' `const char **'.
9211
9212 * xfaces.c <Qunspecified>: Make extern again.
9213
9214 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9215 required by POSIX.
1b2de274 9216
762b15be
EZ
9217 * doc.c (get_doc_string): Improve the format passed to `error'.
9218
9219 * doprnt.c (doprnt): Improve commentary.
9220
9221 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9222
9223 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9224 them with etags.
9225
f1052e5d
EZ
9226 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9227 changes in globals.h immediately force recompilation.
762b15be
EZ
9228 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9229 $(CURDIR)/s/ms-w32.h.
9230 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9231
fa6996bc
EZ
9232 * character.c (Fchar_direction): Function deleted.
9233 (syms_of_character): Don't defsubr it.
9234 <char-direction-table>: Deleted.
9235
e6c3da20
EZ
92362011-04-23 Eli Zaretskii <eliz@gnu.org>
9237
9238 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9239 * doprnt.c: Include limits.h.
9240 (SIZE_MAX): New macro.
04f2d78b
CB
9241 (doprnt): Return a size_t value. 2nd arg is now size_t.
9242 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9243 Improve overflow protection. Support `l' modifier for integer
9244 conversions. Support %l conversion. Don't assume an EMACS_INT
9245 argument for integer conversions and for %c.
9246
9247 * lisp.h (doprnt): Restore prototype.
9248
9249 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9250 $(SRC)/character.h.
9251
9252 * Makefile.in (base_obj): Add back doprnt.o.
9253
9254 * deps.mk (doprnt.o): Add back prerequisites.
9255 (callint.o): Depend on character.h.
9256
9257 * eval.c (internal_lisp_condition_case): Include the handler
9258 representation in the error message.
9259 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9260 when breaking from the loop.
9261
9262 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9263
9264 * callint.c (Fcall_interactively): When displaying error message
9265 about invalid control letter, pass the character's codepoint, not
9266 a pointer to its multibyte form. Improve display of the character
9267 in octal and display also its hex code.
9268
9269 * character.c (char_string): Use %x to display the (unsigned)
9270 codepoint of an invalid character, to avoid displaying a bogus
9271 negative value.
9272
9273 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9274 `error', not SYMBOL_NAME itself.
9275
9276 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9277 character arguments to `error'.
9278
9279 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9280 to `error' in error message about FINAL_CHAR argument. Make sure
9281 FINAL_CHAR is a character, and use %c when it is passed as
9282 argument to `error'.
9283
4ffd0d6b 92842011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9285
9286 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9287
9288 * w32.c: Include <time.h>.
9289 (sys_localtime): New function.
9290
4ffd0d6b 92912011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9292
9293 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9294
4ffd0d6b 9295 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9296
4ffd0d6b 92972011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9298
4ffd0d6b
GM
9299 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9300 zombies (Bug#8467).
aac0c6e3 9301
04c56954
EZ
93022011-04-19 Eli Zaretskii <eliz@gnu.org>
9303
9304 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9305 gl_state.e_property when gl_state.object is Qt.
9306
9307 * insdel.c (make_gap_larger): Remove limitation of buffer size
9308 to <= INT_MAX.
9309
16a43933
CY
93102011-04-18 Chong Yidong <cyd@stupidchicken.com>
9311
9312 * xdisp.c (lookup_glyphless_char_display)
9313 (produce_glyphless_glyph): Handle cons cell entry in
9314 glyphless-char-display.
9315 (Vglyphless_char_display): Document it.
9316
9317 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9318 glyphless-char-display.
9319
4581706e
CY
93202011-04-17 Chong Yidong <cyd@stupidchicken.com>
9321
9322 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9323
9324 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9325
9326 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9327 definition for no-X builds.
9328
4887c6e2 93292011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9330
fd35b6f9
PE
9331 Static checks with GCC 4.6.0 and non-default toolkits.
9332
5c1ccb01
PE
9333 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9334
006c5daa
PE
9335 * process.c (keyboard_bit_set): Define only if SIGIO.
9336 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9337 (send_process): Repair possible setjmp clobbering.
9338
efc736d3
PE
9339 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9340
4e2fe2e6
PE
9341 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9342
f97334a2
PE
9343 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9344
4e75f29d
PE
9345 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9346 Define only if needed.
9347
90efadd1
PE
9348 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9349 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9350 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9351
3c647824
PE
9352 * dispextern.h (struct redisplay_interface): Rename param
9353 to avoid shadowing.
e264f262 9354 * termhooks.h (struct terminal): Likewise.
761383f4 9355 * xterm.c (xembed_send_message): Likewise.
3c647824 9356
b58c5c4a
PE
9357 * insdel.c (make_gap_smaller): Define only if
9358 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9359
cad59032
PE
9360 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9361 it.
9362
c339dc2e
PE
9363 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9364 so that we aren't warned about unused symbols.
9365
91a3e27b
PE
9366 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9367
399c71d3 9368 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9369
8ffc96f5
PE
9370 * xfns.c (x_real_positions): Mark locals as initialized.
9371
eef9bc79
PE
9372 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9373
098db9dd
PE
9374 * xterm.c: Fix problems found by static analysis with other toolkits.
9375 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9376 (x_dispatch_event): Declare static if USE_GTK, and
9377 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9378 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9379 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9380 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9381 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9382
eb18f6cc
PE
9383 * xmenu.c (menu_help_callback): Pointer type fixes.
9384 Use const pointers when pointing at readonly data. Avoid pointer
9385 signedness clashes.
9386 (FALSE): Remove unused macro.
9387 (update_frame_menubar): Remove unused decl.
9388
1fe72bf8
PE
9389 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9390
60d9e1db
PE
9391 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9392 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9393 (single_menu_item): Rename local to avoid shadowing.
9394
39261c26
PE
9395 * keyboard.c (make_lispy_event): Remove unused local var.
9396
018c5e19
PE
9397 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9398 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9399
63d2b86e
PE
9400 * bitmaps: Change bitmaps from unsigned char back to the X11
9401 compatible char. Avoid the old compiler warnings about
9402 out-of-range initializers by using, for example, '\xab' rather
9403 than 0xab.
9404
aefd87e1
PE
9405 * xgselect.c (xgselect_initialize): Check vs interface
9406 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9407
bf501fb9
PE
9408 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9409
e9829fdf
PE
9410 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9411 to read-only memory.
9412
1086c095
PE
9413 * fns.c (vector): Remove; this old hack is no longer needed.
9414
2baccd04 9415 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9416 Remove unused var.
dde42981 9417 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9418
72391843 9419 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9420
436c16df 9421 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9422 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9423 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9424
92bb796d 9425 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9426 (x_term_init): Remove local to avoid shadowing.
92bb796d 9427
764430a3 9428 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9429
9430 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9431 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9432
d1dfb56c
EZ
94332011-04-16 Eli Zaretskii <eliz@gnu.org>
9434
c4354cb4
EZ
9435 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9436
d1dfb56c
EZ
9437 Fix regex.c, syntax.c and friends for buffers > 2GB.
9438 * syntax.h (struct gl_state_s): Declare character position members
9439 EMACS_INT.
9440
9441 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9442
04f2d78b
CB
9443 * textprop.c (verify_interval_modification, interval_of):
9444 Declare arguments EMACS_INT.
d1dfb56c
EZ
9445
9446 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9447 EMACS_INT.
9448
9449 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9450
9451 * indent.c (Fvertical_motion): Local variable it_start is now
9452 EMACS_INT.
9453
9454 * regex.c (re_match, re_match_2, re_match_2_internal)
9455 (bcmp_translate, regcomp, regexec, print_double_string)
9456 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9457 (re_compile_pattern, re_exec): Declare arguments and local
9458 variables `size_t' and `ssize_t' and return values `regoff_t', as
9459 appropriate.
9460 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9461 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9462 <compile_stack_type>: `size' and `avail' are now `size_t'.
9463
9464 * regex.h <regoff_t>: Use ssize_t, not int.
9465 (re_search, re_search_2, re_match, re_match_2): Arguments that
9466 specify buffer/string position and length are now ssize_t and
9467 size_t. Return type is regoff_t.
9468
613052cd
BK
94692011-04-16 Ben Key <bkey76@gmail.com>
9470
9471 * nsfont.m: Fixed bugs in ns_get_family and
9472 ns_descriptor_to_entity that were caused by using free to
9473 deallocate memory blocks that were allocated by xmalloc (via
9474 xstrdup). This caused Emacs to crash when compiled with
9475 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9476 --enable-checking=xmallocoverrun). xfree is now used to
9477 deallocate these memory blocks.
9478
4170f62f 94792011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9480
71b41406
PE
9481 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9482
9587a89d
PE
9483 emacs_write: Accept and return EMACS_INT for sizes.
9484 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9485 et seq.
9486 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9487 Accept and return EMACS_INT.
9488 (emacs_gnutls_write): Return the number of bytes written on
9489 partial writes.
9490 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9491 (emacs_read, emacs_write): Remove check for negative size, as the
9492 Emacs source code has been audited now.
9587a89d
PE
9493 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9494 (emacs_read, emacs_write): Use it.
273a5f82
PE
9495 * process.c (send_process): Adjust to the new signatures of
9496 emacs_write and emacs_gnutls_write. Do not attempt to store
9497 a byte offset into an 'int'; it might overflow.
9587a89d 9498 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9499
3e047f51
PE
9500 * sound.c: Don't assume sizes fit in 'int'.
9501 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9502 Return EMACS_INT, not int.
3e047f51 9503 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9504 Accept EMACS_INT, not int.
9505 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9506 record read return values.
9507
cc39a9db
BK
95082011-04-15 Ben Key <bkey76@gmail.com>
9509
c9d0ec6d
JB
9510 * keyboard.c (Qundefined): Don't declare static since it is used
9511 in nsfns.m.
9512 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9513 static since they are used in nsfont.m.
cc39a9db 9514
6c60eb9f
SM
95152011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9516
9517 * process.c (Qprocessp): Don't declare static.
9518 * lisp.h (Qprocessp): Declare again.
9519
7990b61a
JB
95202011-04-15 Juanma Barranquero <lekktu@gmail.com>
9521
9522 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9523
5d4cb038
PE
95242011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9525
8bd7b830 9526 Improve C-level modularity by making more things 'static'.
cd64ea1d 9527
e3b27b31
PE
9528 Don't publish debugger-only interfaces to other modules.
9529 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9530 (verify_bytepos, count_markers): Move decls to the only modules
9531 that need them.
9532 * region-cache.h (pp_cache): Likewise.
9533 * window.h (check_all_windows): Likewise.
9534 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9535
5d4cb038
PE
9536 * sysdep.c (croak): Now static, if
9537 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9538 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9539
9540 * alloc.c (refill_memory_reserve): Now static if
9541 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9542 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9543
e87b6180
PE
9544 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9545 Define only if USE_LUCID.
9546
ac64929e
PE
9547 * xrdb.c (x_customization_string, x_rm_string): Now static.
9548
6f37259d
PE
9549 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9550 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9551
1683e3ab
PE
9552 * xdisp.c (draw_row_with_mouse_face): Now static.
9553 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9554
de9c2632
PE
9555 * window.h (check_all_windows): Mark externally visible.
9556
2b96acb7
PE
9557 * window.c (window_deletion_count): Now static.
9558
9559 * undo.c: Make symbols static if they're not exported.
9560 (last_undo_buffer, last_boundary_position, pending_boundary):
9561 Now static.
9562
50436f33
PE
9563 * textprop.c (interval_insert_behind_hooks): Now static.
9564 (interval_insert_in_front_hooks): Likewise.
9565
64520e5c
PE
9566 * term.c: Make symbols static if they're not exported.
9567 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9568 (max_frame_lines, tty_set_terminal_modes):
9569 (tty_reset_terminal_modes, tty_turn_off_highlight):
9570 (get_tty_terminal): Now static.
9571 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9572 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9573 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9574 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9575 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9576
1fa53021
PE
9577 * sysdep.c: Make symbols static if they're not exported.
9578 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9579 Now static.
9580 (sigprocmask_set, full_mask): Remove; unused.
9581 (wait_debugging): Mark as visible.
9582 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9583 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9584
d4b43b22
PE
9585 * syntax.c (syntax_temp): Define only if !__GNUC__.
9586
b7c513d0
PE
9587 * sound.c (current_sound_device, current_sound): Now static.
9588
989b29ad
PE
9589 * search.c (searchbufs, searchbuf_head): Now static.
9590
13a55a78
PE
9591 * scroll.c (scroll_cost): Remove; unused.
9592 * dispextern.h (scroll_cost): Remove decl.
9593
de68a1fc
PE
9594 * region-cache.h (pp_cache): Mark as externally visible.
9595
40ccffa6
PE
9596 * process.c: Make symbols static if they're not exported.
9597 (process_tick, update_tick, create_process, chan_process):
9598 (Vprocess_alist, proc_buffered_char, datagram_access):
9599 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9600 (deactivate_process): Mark defn as static, as well as decl.
9601 * lisp.h (create_process): Remove decl.
9602 * process.h (chan_process, Vprocess_alist): Remove decls.
9603
ad64fc97
PE
9604 * print.c: Make symbols static if they're not exported.
9605 (print_depth, new_backquote_output, being_printed, print_buffer):
9606 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9607 (print_interval, print_number_index, initial_stderr_stream):
9608 Now static.
9609 * lisp.h (Fprinc): Remove decl.
9610 (debug_output_compilation_hack): Mark as externally visible.
9611
adddb265
PE
9612 * sysdep.c (croak): Move decl from here to syssignal.h.
9613 * syssignal.h (croak): Put it here, so the API can be checked when
9614 'croak' is called from dissociate_if_controlling_tty.
9615
1717ede2
PE
9616 * minibuf.c: Make symbols static if they're not exported.
9617 (minibuf_save_list, choose_minibuf_frame): Now static.
9618 * lisp.h (choose_minibuf_frame): Remove decl.
9619
fa5fb2bc
PE
9620 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9621
1e3890d1
PE
9622 * lread.c: Make symbols static if they're not exported.
9623 (read_objects, initial_obarray, oblookup_last_bucket_number):
9624 Now static.
9625 (make_symbol): Remove; unused.
9626 * lisp.h (initial_obarray, make_symbol): Remove decls.
9627
8a1414fa
PE
9628 * keyboard.c: Make symbols static if they're not exported.
9629 (single_kboard, recent_keys_index, total_keys, recent_keys):
9630 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9631 (this_single_command_key_start, echoing, last_auto_save):
9632 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9633 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9634 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9635 (Vlispy_mouse_stem, double_click_count):
9636 Now static.
9637 (force_auto_save_soon): Define only if SIGDANGER.
9638 (ignore_mouse_drag_p): Now static if
9639 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9640 (print_help): Remove; unused.
9641 (stop_character, last_timer_event): Mark as externally visible.
9642 * keyboard.h (ignore_mouse_drag_p): Declare only if
9643 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9644 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9645 * lisp.h (echoing): Remove decl.
9646 (force_auto_save_soon): Declare only if SIGDANGER.
9647 * xdisp.c (redisplay_window): Simplify code, to make it more
9648 obvious that ignore_mouse_drag_p is not accessed if !defined
9649 USE_GTK && !defined HAVE_NS.
9650
93ea6e8f
PE
9651 * intervals.c: Make symbols static if they're not exported.
9652 (merge_properties_sticky, merge_interval_right, delete_interval):
9653 Now static.
9654 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9655
77382fcc
PE
9656 * insdel.c: Make symbols static if they're not exported.
9657 However, leave prepare_to_modify_buffer alone. It's never
9658 called from outside this function, but that appears to be a bug.
9659 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9660 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9661 (adjust_after_replace_noundo): Remove; unused.
9662 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9663 (signal_before_change): Remove decls.
77382fcc 9664
9306c32e
PE
9665 * indent.c (val_compute_motion, val_vmotion): Now static.
9666
cd44d2eb
PE
9667 * image.c: Make symbols static if they're not exported.
9668 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9669 if USE_GTK.
9670 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9671 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9672
ad9a7a06
PE
9673 * fringe.c (standard_bitmaps): Now static.
9674 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9675
81626931
PE
9676 * frame.c: Make symbols static if they're not exported.
9677 (x_report_frame_params, make_terminal_frame): Now static.
9678 (get_frame_param): Now static, unless HAVE_NS.
9679 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9680 (x_get_resource_string): Remove; not used.
9681 * frame.h (make_terminal_frame, x_report_frame_params):
9682 (x_get_resource_string); Remove decls.
9683 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9684 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9685
239f9db9
PE
9686 * font.c, fontset.c: Make symbols static if they're not exported.
9687 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9688 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9689 * font.c (font_close_object): Now static.
9690 * font.h (font_close_object): Remove.
9691 * fontset.c (FONTSET_OBJLIST): Remove.
9692 (free_realized_fontset) #if-0 the body, which does nothing.
9693 (face_suitable_for_char_p): #if-0, as it's never called.
9694 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9695 * xfaces.c (face_at_string_position):
9696 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9697 since 0 is always ASCII.
9698
dfcf3579
PE
9699 * fns.c (weak_hash_tables): Now static.
9700
5045092b
PE
9701 * fileio.c: Make symbols static if they're not exported.
9702 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9703 (Vwrite_region_annotation_buffers): Now static.
9704
57a96f5c
PE
9705 * eval.c: Make symbols static if they're not exported.
9706 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9707 * lisp.h (backtrace_list): Remove decl.
9708
35f08c38
PE
9709 * emacs.c: Make symbols static if they're not exported.
9710 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9711 (fatal_error_code, fatal_error_signal_hook, standard_args):
9712 Now static.
9713 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9714 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9715 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9716 * lisp.h (fatal_error_signal_hook): Remove decl.
9717 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9718
f44bd759
PE
9719 * editfns.c: Move a (normally-unused) function to its only use.
9720 * editfns.c, lisp.h (get_operating_system_release): Remove.
9721 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9722 worth the hassle of breaking this out.
9723
b532497d
PE
9724 * xterm.c: Make symbols static if they're not exported.
9725 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9726 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9727 (x_destroy_window, x_delete_display):
9728 Now static.
9729 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9730 (x_mouse_leave): Remove; unused.
9731 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9732 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9733 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9734 Remove decls.
9735 (x_mouse_leave): Declare only if WINDOWSNT.
9736 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9737 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9738 USE_X_TOOLKIT.
9739
1675728f
PE
9740 * ftxfont.c: Make symbols static if they're not exported.
9741 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9742 HAVE_FREETYPE.
9743 * font.h (ftxfont_driver): Likewise.
9744
e4cebfca
PE
9745 * xfns.c: Make symbols static if they're not exported.
9746 (x_last_font_name, x_display_info_for_name):
9747 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9748 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9749 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9750 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9751 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9752 (last_show_tip_args): Now static.
9753 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9754 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9755 (x_screen_planes): Remove; unused.
9756 * dispextern.h (x_screen_planes): Remove decl.
9757
5bf46f05
PE
9758 * dispnew.c: Make symbols static if they're not exported.
9759 * dispextern.h (redraw_garbaged_frames, scrolling):
9760 (increment_row_positions): Remove.
9761 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9762 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9763 Now static.
9764 (redraw_garbaged_frames): Remove; unused.
9765
435f4c28
PE
9766 * xfaces.c: Make symbols static if they're not exported.
9767 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9768 Remove decls.
9769 * xterm.h (defined_color): Remove decls.
9770 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9771 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9772 (menu_face_changed_default, defined_color, free_realized_face):
9773 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9774 (ascii_face_of_lisp_face): Remove; unused.
9775
8524aef3
PE
9776 * xdisp.c: Make symbols static if they're not exported.
9777 * dispextern.h (scratch_glyph_row, window_box_edges):
9778 (glyph_to_pixel_coords, set_cursor_from_row):
9779 (get_next_display_element, set_iterator_to_next):
9780 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9781 (show_mouse_face): Remove decls
9782 * frame.h (message_buf_print): Likewise.
9783 * lisp.h (pop_message, set_message, check_point_in_composition):
9784 Likewise.
9785 * xterm.h (set_vertical_scroll_bar): Likewise.
9786 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9787 (message_buf_print, scratch_glyph_row, displayed_buffer):
9788 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9789 (get_next_display_element, show_mouse_face, window_box_edges):
9790 (frame_to_window_pixel_xy, check_point_in_composition):
9791 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9792 (glyph_to_pixel_coords): Remove; unused.
9793
16390cd2
PE
9794 * dired.c (file_name_completion): Now static.
9795
9796 * dbusbind.c (xd_in_read_queued_messages): Now static.
9797
a25f4dfa
PE
9798 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9799 * data.c (circular_list_error): Remove.
9800
14a9c8df
PE
9801 * commands.h (last_point_position, last_point_position_buffer):
9802 (last_point_position_window): Remove decls.
9803 * keyboard.c: Make these variables static.
9804
04f2d78b
CB
9805 * coding.h (coding, code_convert_region, encode_coding_gap):
9806 Remove decls.
74ab6df5
PE
9807 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9808 (iso_code_class, detect_coding, code_convert_region): Now static.
9809 (encode_coding_gap): Remove; unused.
9810
38dfbee1
PE
9811 * chartab.c (chartab_chars, chartab_bits): Now static.
9812
a2cb4e63
PE
9813 * charset.h (charset_iso_8859_1): Remove decl.
9814 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9815 Now static.
9816
127198fd
PE
9817 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9818 * ccl.c (Vccl_program_table): Now static.
9819 (check_ccl_update): Remove; unused.
9820
d85b608f
PE
9821 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9822 * category.h: ... from here.
9823 * category.c (check_category_table, set_category_set): Now static.
9824
31cd66f3
PE
9825 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9826 * lisp.h: Remove these decls.
9827
c358e587
PE
9828 * buffer.c (buffer_count): Remove unused var.
9829
e78aecca
PE
9830 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9831 so that it's not optimized away.
9832 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9833 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9834 exported only to the debugger.
9835
e192d7d3 9836 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9837 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9838
92470028
PE
9839 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9840 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9841 was inaccessible from Lisp.
9842 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9843 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9844
244ed907
PE
9845 alloc.c: Import and export fewer symbols, and remove unused items.
9846 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9847 is defined.
9848 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9849 it's not optimized away by whole-program optimization.
9850 (message_enable_multibyte, free_misc): Remove.
9851 (catchlist, handlerlist, mark_backtrace):
9852 Declare only if BYTE_MARK_STACK.
9853 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9854 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9855 (message_enable_multibyte): Remove decl.
9856 (free_misc, interval_free_list, float_block, float_block_index):
9857 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9858 (cons_free_list, last_marked_index):
9859 Now static.
9860 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9861 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9862 (mark_backtrace): Define only if BYTE_MARK_STACK.
9863 * xdisp.c (message_enable_multibyte): Now static.
9864
61c2b50e 9865 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9866 This makes it easier for human readers (and static analyzers)
9867 to see whether these variables are used from other modules.
9868 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9869 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9870 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9871 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9872 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9873 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9874 * xmenu.c, xselect.c:
9875 Declare Q* vars static if they are not used in other modules.
9876 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9877 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9878 Remove decls of unexported vars.
9879 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9880
95c82688
PE
9881 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9882
16a97296
PE
9883 Make Emacs functions such as Fatom 'static' by default.
9884 This makes it easier for human readers (and static analyzers)
9885 to see whether these functions can be called from other modules.
9886 DEFUN now defines a static function. To make the function external
9887 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9888 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9889 (Finit_image_library):
16a97296
PE
9890 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9891 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9892 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9893 Remove decls, since these functions are now static.
9894 (Funintern, Fget_internal_run_time): New decls, since these functions
9895 were already external.
95c82688 9896
16a97296
PE
9897 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9898 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9899 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9900 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9901 * keyboard.c, keymap.c, lread.c:
9902 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9903 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9904 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9905 Mark functions with DEFUE instead of DEFUN,
9906 if they are used in other modules.
9907 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9908 decls for now-static functions.
9909 * buffer.h (Fdelete_overlay): Remove decl.
9910 * callproc.c (Fgetenv_internal): Mark as internal.
9911 * composite.c (Fremove_list_of_text_properties): Remove decl.
9912 (Fcomposition_get_gstring): New forward static decl.
9913 * composite.h (Fcomposite_get_gstring): Remove decl.
9914 * dired.c (Ffile_attributes): New forward static decl.
9915 * doc.c (Fdocumntation_property): New forward static decl.
9916 * eval.c (Ffetch_bytecode): New forward static decl.
9917 (Funintern): Remove extern decl; now in .h file where it belongs.
9918 * fileio.c (Fmake_symbolic_link): New forward static decl.
9919 * image.c (Finit_image_library): New forward static decl.
9920 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9921 * intervals.h (Fprevious_property_change):
9922 (Fremove_list_of_text_properties): Remove decls.
9923 * keyboard.c (Fthis_command_keys): Remove decl.
9924 (Fcommand_execute): New forward static decl.
9925 * keymap.c (Flookup_key): New forward static decl.
9926 (Fcopy_keymap): Now static.
9927 * keymap.h (Flookup_key): Remove decl.
9928 * process.c (Fget_process): New forward static decl.
9929 (Fprocess_datagram_address): Mark as internal.
9930 * syntax.c (Fsyntax_table_p): New forward static decl.
9931 (skip_chars): Remove duplicate decl.
9932 * textprop.c (Fprevious_property_change): New forward static decl.
9933 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9934 Now internal.
9935 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9936 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9937
785bbd42
PE
9938 * editfns.c (Fformat): Remove unreachable code.
9939
8b913b57
AS
99402011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9941
9942 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9943 change. (Bug#8496)
9944
a6744a35
EZ
99452011-04-13 Eli Zaretskii <eliz@gnu.org>
9946
9947 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9948 when at ZV. (Bug#8487)
9949
e7974947
AS
99502011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9951
baad03f0
AS
9952 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9953 (Bug#8437)
9954 * keyboard.c (parse_tool_bar_item): Likewise.
9955 * sound.c (sound_cleanup, alsa_close): Likewise.
9956 * termcap.c (tgetent): Likewise.
9957 * xfns.c (x_default_font_parameter): Likewise.
9958 * xsettings.c (read_and_apply_settings): Likewise.
9959
e7974947
AS
9960 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9961 (overrun_check_free): Protoize.
9962
28272684
PE
99632011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9964
9965 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9966 since callers should never pass a negative size.
9967 Change the signature to match that of plain 'read' and 'write'; see
9968 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9969 * lisp.h: Update prototypes of emacs_write and emacs_read.
9970
11997c76
EZ
99712011-04-11 Eli Zaretskii <eliz@gnu.org>
9972
9973 * xdisp.c (redisplay_window): Don't try to determine the character
9974 position of the scroll margin if the window start point w->startp
e896f03c 9975 is outside the buffer's accessible region. (Bug#8468)
11997c76 9976
8a2cbd72
EZ
99772011-04-10 Eli Zaretskii <eliz@gnu.org>
9978
9979 Fix write-region and its subroutines for buffers > 2GB.
9980 * fileio.c (a_write, e_write): Modify declaration of arguments and
9981 local variables to support buffers larger than 2GB.
9982 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9983
9984 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9985 argument, local variables, and return value.
9986
9987 * lisp.h: Update prototypes of emacs_write and emacs_read.
9988
9989 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9990
4073e537 99912011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9992
1ebfdcb6
PE
9993 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9994
b2ded58d
PE
9995 Fix more problems found by GCC 4.6.0's static checks.
9996
7d66342c
PE
9997 * xdisp.c (vmessage): Use a better test for character truncation.
9998
bbf47d44
PE
9999 * charset.c (load_charset_map): <, not <=, for optimization,
10000 and to avoid potential problems with integer overflow.
9248994d 10001 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10002 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10003 * editfns.c (Fformat): Likewise.
1e69125e 10004 * syntax.c (skip_chars): Likewise.
3befa583 10005
e3019616
PE
10006 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10007 This also lets GCC 4.6.0 generate slightly better loop code.
10008
becfa255
PE
10009 * callint.c (Fcall_interactively): <, not <=, for optimization.
10010 (Fcall_interactively): Count the number of arguments produced,
10011 not the number of arguments given. This is simpler and lets GCC
10012 4.6.0 generate slightly better code.
10013
dae0cd48
PE
10014 * ftfont.c: Distingish more carefully between FcChar8 and char.
10015 The previous code passed unsigned char * to a functions like
10016 strlen and xstrcasecmp that expect char *, which does not
10017 conform to the C standard.
10018 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10019 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10020 char * when the C standard requires it.
10021
76032d70
PE
10022 * keyboard.c (read_char): Remove unused var.
10023
eb3f1cc8
PE
10024 * eval.c: Port to Windows vsnprintf (Bug#8435).
10025 Include <limits.h>.
10026 (SIZE_MAX): Define if the headers do not.
10027 (verror): Do not give up if vsnprintf returns a negative count.
10028 Instead, grow the buffer. This ports to Windows vsnprintf, which
10029 does not conform to C99. Problem reported by Eli Zaretskii.
10030 Also, simplify the allocation scheme, by avoiding the need for
10031 calling realloc, and removing the ALLOCATED variable.
10032
70476b54
PE
10033 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10034
12020a9e
PE
10035 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10036 But keep the doprint source code for now, as we might revamp it
10037 and use it again (Bug#8435).
ea6c7ae6
PE
10038 * lisp.h (doprnt): Remove.
10039 * Makefile.in (base_obj): Remove doprnt.o.
10040 * deps.mk (doprnt.o): Remove.
10041
5fdb398c
PE
10042 error: Print 32- and 64-bit integers portably (Bug#8435).
10043 Without this change, on typical 64-bit hosts error ("...%d...", N)
10044 was used to print both 32- and 64-bit integers N, which relied on
10045 undefined behavior.
61bdb816 10046 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10047 * lisp.h (error, verror): Mark as printf-like functions.
10048 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10049 Report overflow in size calculations when allocating printf buffer.
10050 Do not truncate output string at its first null byte.
10051 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10052 Truncate the output at a character boundary, since vsnprintf does not
10053 do that.
10054 * charset.c (check_iso_charset_parameter): Convert internal
10055 character to string before calling 'error', since %c now has the
10056 printf meaning.
10057 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10058 overflow when computing char to be passed to 'error'. Do not
10059 pass Lisp_Object to 'error'; pass the integer instead.
10060 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10061 formatted with plain %d.
10062
b189fa66
PE
10063 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10064
bff87ef0
PE
10065 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10066
7e2cac20
PE
10067 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10068
ce4d90b5
PE
10069 * xterm.c (x_catch_errors): Remove duplicate declaration.
10070
266c9547
PE
10071 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10072
79c49ad2
PE
10073 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10074
368f4090
JM
100752011-04-10 Jim Meyering <meyering@redhat.com>
10076
10077 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10078 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10079 return ssize_t not "int", and use size_t as the buffer length.
10080 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10081 * gnutls.h: Update declarations.
10082 * process.c (read_process_output): Use ssize_t, to match.
10083 (send_process): Likewise.
10084
a32d4040
CY
100852011-04-09 Chong Yidong <cyd@stupidchicken.com>
10086
10087 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10088
8546720e 100892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10090
04f2d78b
CB
10091 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10092 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10093
8546720e
GM
10094 * xterm.c (handle_one_xevent):
10095 * xmenu.c (create_and_show_popup_menu):
10096 * xselect.c (x_decline_selection_request)
10097 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10098
0a2f5c1a 100992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10100
10101 Fix some uses of `int' instead of EMACS_INT.
10102 * search.c (string_match_1, fast_string_match)
10103 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10104 (scan_buffer, find_next_newline_no_quit)
10105 (find_before_next_newline, search_command, Freplace_match)
10106 (Fmatch_data): Make some `int' variables be EMACS_INT.
10107
10108 * xdisp.c (display_count_lines): 3rd argument and return value now
10109 EMACS_INT. All callers changed.
10110 (pint2hrstr): Last argument is now EMACS_INT.
10111
10112 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10113 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10114 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10115 (decode_coding_utf_16, decode_coding_emacs_mule)
10116 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10117 (decode_coding_ccl, decode_coding_charset)
10118 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10119 (decode_coding_iso_2022, decode_coding_emacs_mule)
10120 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10121 <char_offset, last_offset>: Declare EMACS_INT.
10122 (encode_coding_utf_8, encode_coding_utf_16)
10123 (encode_coding_emacs_mule, encode_invocation_designation)
10124 (encode_designation_at_bol, encode_coding_iso_2022)
10125 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10126 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10127 Declare EMACS_INT.
10128 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10129 (encode_invocation_designation): Last argument P_NCHARS is now
10130 EMACS_INT.
10131 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10132 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10133
10134 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10135 All users changed.
10136
10137 * ccl.c (Fccl_execute_on_string): Declare some variables
10138 EMACS_INT.
10139
8546720e 101402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10141
10142 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10143
4e19a977
CS
101442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10145
10146 * process.c (Fformat_network_address): Doc fix.
10147
87302331
R
101482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10149
ee7683eb 10150 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10151
cbb59342
CY
101522011-04-08 Chong Yidong <cyd@stupidchicken.com>
10153
10154 * keyboard.c (read_char): Call Lisp function help-form-show,
10155 instead of using internal_with_output_to_temp_buffer.
10156 (Qhelp_form_show): New var.
e0d38eeb 10157 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10158
10159 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10160
10161 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10162
e67a13ab
CY
101632011-04-06 Chong Yidong <cyd@stupidchicken.com>
10164
04f2d78b
CB
10165 * process.c (Flist_processes): Remove to Lisp.
10166 (list_processes_1): Delete.
e67a13ab 10167
973f782d
EZ
101682011-04-06 Eli Zaretskii <eliz@gnu.org>
10169
7c106b1e
EZ
10170 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10171
973f782d
EZ
10172 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10173
41cf7d1a 101742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10175
ca23cc88
PE
10176 Fix more problems found by GCC 4.6.0's static checks.
10177
f390e2d5
PE
10178 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10179
42eea0d0
PE
10180 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10181
b69769da 10182 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10183
f9541e84
PE
10184 * xdisp.c (vmessage): Mark as a printf-like function.
10185
13841b55
PE
10186 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10187
c136c10f
PE
10188 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10189
5e2d4a30
PE
10190 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10191 printf-like functions.
10192 (tiff_load): Add casts to remove these marks before passing them
10193 to system-supplied API.
10194
583f48b9
PE
10195 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10196
b25d760e
PE
10197 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10198 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10199 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10200 directly, rather than having caller test rule sign. This avoids
10201 some unnecessary tests.
10202 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10203 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10204 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10205
bc7b6697 10206 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10207 (xfont_open): Avoid unnecessary tests.
bc7b6697 10208
27ccc379
PE
10209 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10210
dcd5c89a
PE
10211 * composite.h, composite.c (composition_gstring_put_cache):
10212 Use EMACS_INT, not int, for length.
10213
b13a45c6
PE
10214 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10215 breaking out part of COMPOSITION_DECODE_RULE.
10216 (COMPOSITION_DECODE_RULE): Use it.
10217 * composite.c (get_composition_id): Remove unused local vars,
10218 by using the new macro.
10219
1e792e4d
PE
10220 * textprop.c (set_text_properties_1): Change while to do-while,
10221 since the condition is always true at first.
10222
dc6c6455 10223 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10224 (interval_deletion_adjustment): Return unsigned value.
10225 All uses changed.
dc6c6455 10226
aba7731a
PE
10227 * process.c (list_processes_1, create_pty, read_process_output):
10228 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10229 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10230 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10231 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10232 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10233
fdfc4bf3
PE
10234 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10235
fca8fe46 10236 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10237 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10238
06a0259a 10239 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10240 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10241 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10242
e7b9e80f
PE
10243 * print.c (print_error_message): Avoid int overflow.
10244
56201685
PE
10245 * font.c (font_list_entities): Redo for clarity,
10246 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10247
78834453 10248 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10249 (font_score): Avoid potential overflow in diff calculation.
78834453 10250
0bc0b309 10251 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10252 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10253
e610eaca
PE
10254 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10255
b895abce
PE
10256 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10257 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10258 can always succeed if overflow has undefined behavior.
10259
1f1d9321 10260 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10261 (wordify): Omit three unnecessary tests.
1f1d9321 10262
c59478bc
PE
10263 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10264 All callers changed. This avoids the need for an unused var.
10265
79b73827
PE
10266 * casefiddle.c (casify_region): Remove var that is set but not used.
10267
a4db5dfe
PE
10268 * dired.c (file_name_completion): Remove var that is set but not used.
10269
43aae36e
PE
10270 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10271
2a47c44d 10272 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10273 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10274
a37c69bf
PE
10275 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10276 Check for integer overflow on size calculations.
10277
328ab8e7
PE
10278 * buffer.c (Fprevious_overlay_change): Remove var that is set
10279 but not used.
10280
e5a2a5cb
PE
10281 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10282 Remove vars that are set but not used.
8d84a6eb 10283 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10284 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10285
a60e5f68
PE
10286 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10287
f661cb61 10288 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10289 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10290
f0397f5a
PE
10291 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10292 that are set but not used.
10293
8664db06 10294 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10295 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10296
6abdaa4a
PE
10297 * xselect.c (x_get_local_selection, x_handle_property_notify):
10298 Remove vars that are set but not used.
10299
0ce7538d 10300 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10301 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10302
9ae848fc
PE
10303 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10304 Remove var that is set but not used.
0b918413
PE
10305 (scroll_bar_windows_size): Now size_t, not int.
10306 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10307 Check for overflow.
9ae848fc 10308
a5a62657
PE
10309 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10310 (map_tty_color) [!defined MSDOS]: Likewise.
10311
5c5cdd39
PE
10312 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10313
66ebf983
PE
10314 * coding.c: Remove vars that are set but not used.
10315 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10316 All callers changed.
10317 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10318 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10319 (decode_coding_charset): Remove vars that are set but not used.
10320
1be4d761
PE
10321 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10322 that is set but not used.
10323
47553fa8
PE
10324 * print.c (print_object): Remove var that is set but not used.
10325
1f7196bf 10326 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10327 The gnulib version avoids calling malloc in the usual case,
10328 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10329 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10330 * filelock.c (current_lock_owner): Likewise.
10331 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10332 * sysdep.c: Include allocator.h, careadlinkat.h.
10333 (emacs_no_realloc_allocator): New static constant.
10334 (emacs_readlink): New function.
fdb61804
PE
10335 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10336 ../lib/careadlinkat.h.
d1fdcab7 10337
f84c17c7
SM
103382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10339
10340 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10341 first non-nil return value).
10342
ef3862ad
JD
103432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10344
10345 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10346 if not defined (Bug#8403).
10347
376a7006
JB
103482011-04-02 Juanma Barranquero <lekktu@gmail.com>
10349
10350 * xdisp.c (display_count_lines): Remove parameter `start',
10351 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10352 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10353 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10354 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10355 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10356 and thereabouts. All callers changed.
10357 (get_per_char_metric): Remove parameter `f', unused since
10358 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10359
6ca3801d
JM
103602011-04-02 Jim Meyering <meyering@redhat.com>
10361
10362 do not dereference NULL upon failed strdup
10363 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10364 (ns_get_family): Likewise.
10365
d8e2b5ba
JB
103662011-04-02 Juanma Barranquero <lekktu@gmail.com>
10367
10368 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10369
8c74fcbd
JD
103702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10371
10372 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10373 later (Bug#8403).
10374
7200d79c
SM
103752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10376
03408648 10377 Add lexical binding.
7200d79c 10378
03408648
SM
10379 * window.c (Ftemp_output_buffer_show): New fun.
10380 (Fsave_window_excursion):
10381 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10382
10383 * lread.c (lisp_file_lexically_bound_p): New function.
10384 (Fload): Bind Qlexical_binding.
10385 (readevalloop): Remove `evalfun' arg.
10386 Bind Qinternal_interpreter_environment.
10387 (Feval_buffer): Bind Qlexical_binding.
10388 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10389 Mark as dynamic.
10390 (syms_of_lread): Declare `lexical-binding'.
10391
10392 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10393
10394 * keyboard.c (eval_dyn): New fun.
10395 (menu_item_eval_property): Use it.
ca105506
SM
10396
10397 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10398
03408648
SM
10399 * fns.c (concat, mapcar1): Accept byte-code-functions.
10400
10401 * eval.c (Fsetq): Handle lexical vars.
10402 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10403 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10404 (FletX, Flet): Obey lexical binding.
10405 (Fcommandp): Handle closures.
10406 (Feval): New `lexical' arg.
10407 (eval_sub): New function extracted from Feval. Use it almost
10408 everywhere where Feval was used. Look up vars in lexical env.
10409 Handle closures.
10410 (Ffunctionp): Move from subr.el.
10411 (Ffuncall): Handle closures.
10412 (apply_lambda): Remove `eval_flags'.
10413 (funcall_lambda): Handle closures and new byte-code-functions.
10414 (Fspecial_variable_p): New function.
10415 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10416 but without exporting it to Lisp.
23aba0ea 10417
23aba0ea 10418 * doc.c (Fdocumentation, store_function_docstring):
03408648 10419 * data.c (Finteractive_form): Handle closures.
23aba0ea 10420
03408648
SM
10421 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10422 interactive spec.
ba83908c 10423
04f2d78b
CB
10424 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10425 New byte-codes.
03408648
SM
10426 (exec_byte_code): New function extracted from Fbyte_code to handle new
10427 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10428
03408648 10429 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10430
03408648 10431 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10432
e2abce01
JB
104332011-03-31 Juanma Barranquero <lekktu@gmail.com>
10434
10435 * xdisp.c (redisplay_internal): Fix prototype.
10436
63696a73 104372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10438
63696a73 10439 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10440 (try_scrolling): Use it when setting scroll_limit.
10441 Limit scrolling to 100 screen lines.
63696a73
EZ
10442 (redisplay_window): Even when falling back on "recentering",
10443 position point in the window according to scroll-conservatively,
10444 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10445
10446 (try_scrolling): When point is above the window, allow searching
10447 as far as scroll_max, or one screenful, to compute vertical
10448 distance from PT to the scroll margin position. This prevents
10449 try_scrolling from unnecessarily failing when
10450 scroll-conservatively is set to a value slightly larger than the
10451 window height. Clean up the case of PT below the margin at bottom
10452 of window: scroll_max can no longer be INT_MAX. When aggressive
10453 scrolling is in use, don't let point enter the opposite scroll
10454 margin as result of the scroll.
10455 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10456 threshold of 100 lines for never-recentering scrolling.
10457
e4cc2dfc
JB
104582011-03-31 Juanma Barranquero <lekktu@gmail.com>
10459
10460 * dispextern.h (move_it_by_lines):
10461 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10462 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10463 (message_log_check_duplicate): Remove parameters `prev_bol' and
10464 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10465 (redisplay_internal): Remove parameter `preserve_echo_area',
10466 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10467
10468 * indent.c (Fvertical_motion):
10469 * window.c (window_scroll_pixel_based, Frecenter):
10470 Don't pass `need_y_p' to `move_it_by_lines'.
10471
1c470562
SM
104722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10473
44f230aa
SM
10474 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10475 steal a few bits to be more compact.
10476 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10477 Remove unneeded casts.
10478
1c470562
SM
10479 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10480
888adce9
ZK
104812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10482
10483 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10484 binding" message (bug#7967).
10485
f838ed7b
PE
104862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10487
77861b95
PE
10488 Fix more problems found by GCC 4.6.0's static checks.
10489
de6dbc14
PE
10490 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10491 Remove unused local var.
10492
f838ed7b
PE
10493 * editfns.c (Fmessage_box): Remove unused local var.
10494
792c7b2b
PE
10495 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10496 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10497 Omit unused local vars.
c499e557 10498 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10499 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10500 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10501 Omit unused local var.
10502
ba0165e1
PE
10503 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10504 Don't assume string length fits in int.
32ad8845 10505 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10506 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10507
3c59b4c9
PE
10508 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10509 instead of alloca (Bug#8344).
10510
a3eed478 10511 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10512 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10513
eb4d412d
PE
10514 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10515
1658b401
PE
10516 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10517 concerns.
10518
10519 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10520
10521 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10522
9a2c6e05
PE
10523 * keyboard.c (syms_of_keyboard): Use the same style as later
10524 in this function when indexing through an array. This also
10525 works around GCC bug 48267.
10526
03d0a109
PE
10527 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10528
44f730c8
PE
10529 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10530
fe75f926
PE
10531 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10532 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10533
ffa8c828
PE
10534 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10535 This avoids undefined behavior on integer overflow, and is a bit
10536 more convenient anyway since it is compared to a size_t variable.
10537
c5101a77
PE
10538 Variadic C functions now count arguments with size_t, not int.
10539 This avoids an unnecessary limitation on 64-bit machines, which
10540 caused (substring ...) to crash on large vectors (Bug#8344).
10541 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10542 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10543 All variadic functions and their callers changed accordingly.
c5101a77
PE
10544 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10545 * data.c (arith_driver, float_arith_driver): Likewise.
10546 * editfns.c (general_insert_function): Likewise.
10547 * eval.c (struct backtrace.nargs, interactive_p)
10548 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10549 (funcall_lambda, mark_backtrace): Likewise.
10550 * fns.c (concat): Likewise.
10551 * frame.c (x_set_frame_parameters): Likewise.
10552 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10553 0 if not found, not -1. All callers changed.
10554
dd3f25f7
PE
10555 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10556 (stack_copy_size): Now size_t, not int.
10557 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10558
461c2ab9
JB
105592011-03-28 Juanma Barranquero <lekktu@gmail.com>
10560
10561 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10562 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10563 All callers changed.
10564
10565 * lisp.h (multibyte_char_to_unibyte):
10566 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10567 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10568 * character.h (CHAR_TO_BYTE8):
10569 * cmds.c (internal_self_insert):
10570 * editfns.c (general_insert_function):
10571 * keymap.c (push_key_description):
10572 * search.c (Freplace_match):
10573 * xdisp.c (message_dolog, set_message_1): All callers changed.
10574
f6d62986
SM
105752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10576
10577 * keyboard.c (safe_run_hook_funcall): New function.
10578 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10579 don't set the hook to nil, but remove the offending function instead.
10580 (Qcommand_hook_internal): Remove, unused.
10581 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10582 Vcommand_hook_internal.
10583
10584 * eval.c (enum run_hooks_condition): Remove.
10585 (funcall_nil, funcall_not): New functions.
10586 (run_hook_with_args): Call each function through a `funcall' argument.
10587 Remove `cond' argument, now redundant.
10588 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10589 (Frun_hook_with_args_until_failure): Adjust accordingly.
10590 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10591
1db5b1ad
JB
105922011-03-28 Juanma Barranquero <lekktu@gmail.com>
10593
10594 * dispextern.h (string_buffer_position): Remove declaration.
10595
10596 * print.c (strout): Remove parameter `multibyte', unused since
10597 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10598
10599 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10600 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10601 All callers changed.
10602
10603 * w32.c (_wsa_errlist): Use braces for struct initializers.
10604
10605 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10606 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10607 All callers changed.
10608 (string_buffer_position): Likewise. Also, make static (it's never
10609 used outside xdisp.c).
10610 (cursor_row_p): Remove parameter `w', unused since
10611 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10612 (decode_mode_spec): Remove parameter `precision', introduced during
10613 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10614 All callers changed.
10615
5ffb62aa
JD
106162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10617
10618 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10619
461c2ab9 106202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10621
10622 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10623 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10624 (ns_update_auto_hide_menu_bar): New functions.
10625 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10626 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10627 ns_constrain_all_frames.
10628 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10629 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10630
5c380ffb
JD
106312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10632
10633 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10634
9af30bdf
GM
106352011-03-27 Glenn Morris <rgm@gnu.org>
10636
10637 * syssignal.h: Replace RETSIGTYPE with void.
10638 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10639 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10640 Replace SIGTYPE with void everywhere.
10641 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10642 * s/template.h (SIGTYPE): Remove commented out definition.
10643
e2abce01
JB
106442011-03-26 Eli Zaretskii <eliz@gnu.org>
10645
10646 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10647 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10648
f868cd8a
JB
106492011-03-26 Juanma Barranquero <lekktu@gmail.com>
10650
59eb0929
JB
10651 * w32.c (read_unc_volume): Use parameter `henum', instead of
10652 global variable `wget_enum_handle'.
10653
10654 * keymap.c (describe_vector): Remove parameters `indices' and
10655 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10656 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10657
f868cd8a
JB
10658 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10659
10660 * keyboard.c (timer_check): Remove parameter `do_it_now',
10661 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10662 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10663 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10664
10665 * keyboard.c (read_char):
10666 * w32menu.c (w32_menu_display_help):
10667 * xmenu.c (show_help_event, menu_help_callback):
10668 Adjust calls to `show_help_echo'.
10669
10670 * gtkutil.c (xg_maybe_add_timer):
10671 * keyboard.c (readable_events):
10672 * process.c (wait_reading_process_output):
10673 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10674
10675 * insdel.c (adjust_markers_gap_motion):
10676 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10677 (gap_left, gap_right): Don't call it.
10678
2ecf6fdb
CY
106792011-03-25 Chong Yidong <cyd@stupidchicken.com>
10680
10681 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10682 incurred during fontification.
10683
6b1f9ba4
JB
106842011-03-25 Juanma Barranquero <lekktu@gmail.com>
10685
10686 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10687 (DEFVAR_PER_BUFFER): Don't pass it.
10688
10689 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10690 (scrolling_window): Don't pass it.
10691
0f4a96b5
JB
106922011-03-25 Juanma Barranquero <lekktu@gmail.com>
10693
10694 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10695
10696 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10697 and `suffix'.
10698 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10699 of variables specific to SELinux and computation of `encoded_absname'.
10700
10701 * image.c (XPutPixel): Remove unused variable `height'.
10702
10703 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10704
10705 * unexw32.c (get_section_info): Remove unused variable `section'.
10706
10707 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10708 (system_process_attributes): Remove unused variable `sess'.
10709 (sys_read): Remove unused variable `err'.
10710
10711 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10712 (w32_wnd_proc): Remove unused variable `isdead'.
10713 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10714 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10715 (x_create_tip_frame): Remove unused variable `tem'.
10716
10717 * w32inevt.c (w32_console_read_socket):
10718 Remove unused variable `no_events'.
10719
10720 * w32term.c (x_draw_composite_glyph_string_foreground):
10721 Remove unused variable `width'.
10722
1149507c
JB
107232011-03-24 Juanma Barranquero <lekktu@gmail.com>
10724
10725 * w32term.c (x_set_glyph_string_clipping):
10726 Don't pass uninitialized region to CombineRgn.
10727
9c88f339
JB
107282011-03-23 Juanma Barranquero <lekktu@gmail.com>
10729
10730 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10731 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10732 (Fx_close_connection): Remove unused variable `i'.
10733
10734 * w32font.c (w32font_draw): Return number of glyphs.
10735 (w32font_open_internal): Remove unused variable `i'.
10736 (w32font_driver): Add missing initializer.
10737
10738 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10739 (fill_in_menu): Remove unused variable `items_added'.
10740
10741 * w32term.c (last_mouse_press_frame): Remove static global variable.
10742 (w32_clip_to_row): Remove unused variable `f'.
10743 (x_delete_terminal): Remove unused variable `i'.
10744
10745 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10746 (NOTHING): Remove unused static global variable.
10747 (uniscribe_check_otf): Remove unused variable `table'.
10748 (uniscribe_font_driver): Add missing initializers.
10749
dee091a3
JD
107502011-03-23 Julien Danjou <julien@danjou.info>
10751
10752 * term.c (Fsuspend_tty, Fresume_tty):
10753 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10754 * window.c (temp_output_buffer_show):
10755 * insdel.c (signal_before_change):
10756 * frame.c (Fhandle_switch_frame):
10757 * fileio.c (Fdo_auto_save):
10758 * emacs.c (Fkill_emacs):
10759 * editfns.c (save_excursion_restore):
10760 * cmds.c (internal_self_insert):
10761 * callint.c (Fcall_interactively):
10762 * buffer.c (Fkill_all_local_variables):
10763 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10764 Use Frun_hooks.
0f4a96b5 10765 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10766 unconditionally since it does the check itself.
dee091a3 10767
2c520ab5 107682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10769
c9c49752
PE
10770 Fix more problems found by GCC 4.5.2's static checks.
10771
8abc3f12
PE
10772 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10773 the first time through the loop, since we know p0 < p1 then.
10774 This also avoids a gcc -Wstrict-overflow warning.
10775
a2d26660
PE
10776 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10777 leading to a memory leak, possible in functions like
10778 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10779 of objects (Bug#8318).
a2d26660 10780
916c72e9
PE
10781 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10782 that could (at least in theory) be that large.
10783
19ab8a18
PE
10784 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10785 This is less likely to overflow, and avoids undefined behavior if
10786 overflow does occur. All callers changed. Use strtoul to scan
10787 for the unsigned long integer.
b7cbbd6f
PE
10788 (pint2hrstr): Simplify and tune code slightly.
10789 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10790
f0641eff
PE
10791 * scroll.c (do_scrolling): Work around GCC bug 48228.
10792 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10793
7f650bb9
PE
10794 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10795 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10796 (validate_x_resource_name): Simplify count usage.
10797 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10798
37dd57d1
PE
10799 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10800 fail (Bug#8306).
81e56e61 10801
699979fc 10802 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10803
401bf9b4
PE
10804 * process.c (Fmake_network_process): Use socklen_t, not int,
10805 where POSIX says socklen_t is required in portable programs.
10806 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10807 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10808 (Fmake_network_process, server_accept_connection):
10809 (wait_reading_process_output, read_process_output):
10810 Likewise.
10811
b93aacde
PE
10812 * process.c: Rename or move locals to avoid shadowing.
10813 (list_processes_1, Fmake_network_process):
10814 (read_process_output_error_handler, exec_sentinel_error_handler):
10815 Rename or move locals.
4dc343ee 10816 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10817 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10818 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10819 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10820 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10821
af8a867c 10822 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10823 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10824 Include tparam.h instead, since it declares them.
af8a867c
PE
10825 * cm.h (PC): Remove extern decl; tparam.h now does this.
10826 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10827 * terminfo.c: Include tparam.h, to check interfaces.
10828 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10829 (tparam): Adjust signature to match interface in tparam.h;
10830 this removes some undefined behavior. Check that outstring and len
10831 are zero, which they always are with Emacs.
10832 * tparam.h (PC, BC, UP): New extern decls.
10833
0248044d 10834 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10835 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10836
8ff096c1 10837 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10838 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10839 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10840 (ftfont_list): Remove unused local.
49eaafba
PE
10841 (get_adstyle_property, ftfont_pattern_entity):
10842 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10843 Rename locals to avoid shadowing.
8ff096c1 10844
e2be39f6
PE
10845 * xfont.c (xfont_list_family): Mark var as initialized.
10846
c9735e30
PE
10847 * xml.c (make_dom): Now static.
10848
8f5201ae
PE
10849 * composite.c (composition_compute_stop_pos): Rename local to
10850 avoid shadowing.
b246f932
PE
10851 (composition_reseat_it): Remove unused locals.
10852 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10853 (composition_update_it): Mark var as initialized.
11b61122
PE
10854 (find_automatic_composition): Mark vars as initialized,
10855 with a FIXME (Bug#8290).
8f5201ae 10856
760fbc2c
PE
10857 character.h: Rename locals to avoid shadowing.
10858 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10859 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10860 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10861 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10862 to avoid shadowing.
10863
ff08eb85
PE
10864 * textprop.c (property_change_between_p): Remove; unused.
10865
fc7bf025
PE
10866 * intervals.c (interval_start_pos): Now static.
10867
235d7abc
PE
10868 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10869
44f230aa
SM
10870 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10871 Rename locals to avoid shadowing.
3e7d6594 10872
50060332
PE
10873 * sound.c (wav_play, au_play, Fplay_sound_internal):
10874 Fix pointer signedness.
d01f234b 10875 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10876 (wav_play): Initialize a variable to 0, to prevent undefined
10877 behavior (Bug#8278).
50060332 10878
c4fc4e30
PE
10879 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10880
918436ed
PE
10881 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10882
c939f91b
PE
10883 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10884 clobbering (Bug#8298).
b9c7f648
PE
10885 * sysdep.c (sys_subshell): Likewise.
10886 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10887
6bd8c144
PE
10888 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10889 This should get cleaned up, so that child_setup has the
10890 same signature on all platforms.
10891
7710357c 10892 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10893 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10894
c59da222
CY
108952011-03-22 Chong Yidong <cyd@stupidchicken.com>
10896
10897 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10898 not to be necessary, and produces flickering.
10899
66b87493
GM
109002011-03-20 Glenn Morris <rgm@gnu.org>
10901
10902 * config.in: Remove file.
10903
45b6f6d5
JB
109042011-03-20 Juanma Barranquero <lekktu@gmail.com>
10905
10906 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10907 are now in src/globals.h.
10908 (syms_of_minibuf): Remove spurious & from previous change.
10909
cd394be1 109102011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10911
10912 * minibuf.c (completing-read-function): New variable.
10913 (completing-read-default): Rename from completing-read.
10914 (completing-read): Call completing-read-function.
10915
b14e3e21
CY
109162011-03-19 Juanma Barranquero <lekktu@gmail.com>
10917
10918 * xfaces.c (Fx_load_color_file):
10919 Read color file from absolute filename (bug#8250).
10920
f2b726e6
JB
109212011-03-19 Juanma Barranquero <lekktu@gmail.com>
10922
10923 * makefile.w32-in: Update dependencies.
10924
09f6ff02
EZ
109252011-03-17 Eli Zaretskii <eliz@gnu.org>
10926
10927 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10928
29a6015a
PE
109292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10930
a3a6c54e
PE
10931 Fix more problems found by GCC 4.5.2's static checks.
10932
b766f867
PE
10933 * process.c (make_serial_process_unwind, send_process_trap):
10934 (sigchld_handler): Now static.
10935
be02381c
PE
10936 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10937 That way, the code declares only the vars that it needs.
10938 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10939 * s/cygwin.h (PTY_ITERATION): Likewise.
10940 * s/darwin.h (PTY_ITERATION): Likewise.
10941 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10942
57048744
PE
10943 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10944 * process.c (allocate_pty): Don't declare stb unless it's needed.
10945
7914961c 10946 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10947 (CONSTANTLIM): Remove; unused.
10948 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10949 Define only if needed.
7914961c 10950
b3967b18
PE
10951 * unexelf.c (unexec): Name an expression,
10952 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10953 Use a different way to cause a compilation error if anyone uses
10954 n rather than nn, a way that does not involve shadowing.
73366a00 10955 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10956
29a6015a
PE
10957 * deps.mk (unexalpha.o): Remove; unused.
10958
43cfc33e 10959 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10960 * unexec.h: New file.
ce701a33
PE
10961 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10962 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10963 Depend on unexec.h.
10964 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10965 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10966 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10967 Change as necessary to match prototype in unexec.h.
ce701a33 10968
01f44d5a
PE
10969 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10970 shadowing.
4f63c6bb 10971 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10972
a6670b0b
PE
10973 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10974 Rename locals to avoid shadowing.
10975
cef2010d 10976 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10977 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10978
d4d7173a
PE
10979 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10980
f08b802a
PE
10981 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10982 warning when compiling print.c.
10983
3ddb0639
PE
10984 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10985 instead of using an uninitialized var.
5ad03b97 10986 (font_sort_entities): Mark var as initialized.
3ddb0639 10987
170a2692
PE
10988 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10989
e663c700
PE
10990 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10991 pointers to constants.
89bc529a 10992 (font_parse_fcname): Remove unused vars.
7b81e2d0 10993 (font_delete_unmatched): Now static.
ea838e10 10994 (font_get_spec): Remove; unused.
13a547c6
PE
10995 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10996 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10997 Rename or move locals to avoid shadowing.
e663c700 10998
2a80c887 10999 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11000 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11001
1384fa33 11002 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11003 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11004
8b2c52e9
PE
11005 * alloc.c (mark_backtrace): Move decl from here ...
11006 * lisp.h: ... to here, so that it can be checked.
11007
475545b5 11008 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11009 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11010 (lisp_indirect_variable): Name an expression,
11011 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11012 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11013
b1349114 11014 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11015 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11016 Use const pointer when appropriate.
b1349114 11017
a2928364
PE
11018 * lisp.h (get_system_name, get_operating_system_release):
11019 Move decls here, to check interfaces.
11020 * process.c (get_operating_system_release): Move decl to lisp.h.
11021 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11022 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11023 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11024 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11025 (Fformat_time_string, Fencode_time, Finsert_char):
11026 (Ftranslate_region_internal, Fformat):
11027 Rename or remove local vars to avoid shadowing.
9710023e 11028 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11029
a415e694
PE
11030 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11031 avoid shadowing.
11032
8ef4622d
PE
11033 * lisp.h (eassert): Check that the argument compiles, even if
11034 ENABLE_CHECKING is not defined.
11035
946f9a5b
PE
11036 * data.c (Findirect_variable): Name an expression, to avoid
11037 gcc -Wbad-function-cast warning.
112396d6 11038 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11039 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11040 (Fmake_variable_buffer_local, Fmake_local_variable):
11041 Mark variables as initialized.
52746918 11042 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11043
e5aab7e7 11044 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11045 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11046 Rename locals to avoid shadowing.
dff45157
PE
11047 (mark_stack): Move local variables into the #ifdef region where
11048 they're used.
7bc26fdb
PE
11049 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11050 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11051 needed otherwise.
11052 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11053 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11054 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11055
e5aab7e7
PE
11056 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11057 avoids undefined behavior in theory.
11058
4da60324
PE
11059 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11060
88043301
PE
11061 Use functions, not macros, for up- and down-casing (Bug#8254).
11062 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11063 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11064 to use the following functions instead of these macros.
11065 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11066 EMACS_INT, since callers assume the returned value fits in int.
11067 (upcase1): Likewise, for UPCASE_TABLE.
11068 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11069 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11070 the race-condition problem in the old DOWNCASE.
88043301 11071
19ed5445
PE
11072 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11073 Rename locals to avoid shadowing.
11074 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11075 (regex_compile, re_search_2, re_match_2_internal):
11076 Remove unused local vars.
952db0d7
PE
11077 (FREE_VAR): Rewrite so as not to use empty "else",
11078 which gcc can warn about.
da053e48 11079 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11080 (RETALLOC_IF): Define only if needed.
11081 (WORDCHAR_P): Likewise. This one is never needed, but is used
11082 only in a comment talking about a compiler bug, so put inside
11083 the #if 0 of that comment.
11084 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11085 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11086 Remove; unused.
19ed5445 11087
1f3561e4 11088 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11089 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11090 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11091
ded6f8f7
PE
11092 * search.c (simple_search): Remove unused var.
11093
dbd37a95
PE
11094 * dired.c (compile_pattern): Move decl from here ...
11095 * lisp.h: ... to here, so that it can be checked.
11096 (struct re_registers): New forward decl.
11097
7e47afad
PE
11098 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11099
85f24f61
PE
11100 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11101 All uses changed.
11102 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11103 Rename locals to avoid shadowing.
5671df8f 11104 (Fvertical_motion): Mark locals as initialized.
85f24f61 11105
181aa2be 11106 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11107 (casify_region): Mark local as initialized.
181aa2be 11108
930d429c
PE
11109 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11110
7082eac6
PE
11111 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11112 New macros, so that the caller can use some names other than
11113 gcpro1, gcpro2, etc.
11114 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11115 of the new macros.
11116 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11117 argument, for consistency with GCPRO2_VAR, etc: it is now the
11118 prefix of the variable, not the variable itself. All uses
11119 changed.
38b2c076
PE
11120 * dired.c (directory_files_internal, file_name_completion):
11121 Rename locals to avoid shadowing.
11122
15206ed9
PE
11123 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11124 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11125 dired.c's scmp function, had undefined behavior.
11126 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11127 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11128 * buffer.h: ... to here, because these macros use current_buffer,
11129 and the new implementation with inline functions needs to have
11130 current_buffer in scope now, rather than later when the macros
11131 are used.
11132 (downcase, upcase1): New static inline functions.
11133 (DOWNCASE, UPCASE1): Reimplement using these functions.
11134 This avoids undefined behavior in expressions like
11135 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11136 from race conditions in accessing the global variables
11137 case_temp1 and case_temp2.
11138 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11139 * lisp.h (case_temp1, case_temp2): Remove their decls.
11140 * character.h (ASCII_CHAR_P): Move from here ...
11141 * lisp.h: ... to here, so that the inline functions mentioned
11142 above can use them.
11143
4a6bea26
PE
11144 * dired.c (directory_files_internal_unwind): Now static.
11145
f14b7e14
PE
11146 * fileio.c (file_name_as_directory, directory_file_name):
11147 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11148 Now static.
2893f146
PE
11149 (file_name_as_directory): Use const pointers when appropriate.
11150 (Fexpand_file_name): Likewise. In particular, newdir might
11151 point at constant storage, so make it a const pointer.
fd4ead52 11152 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11153 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11154 signedness issues.
f839df0c
PE
11155 (Fset_file_times, Finsert_file_contents, auto_save_error):
11156 Rename locals to avoid shadowing.
f14b7e14 11157
5716756e 11158 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11159 (Ftry_completion, Fall_completions): Rename or remove locals
11160 to avoid shadowing.
5716756e 11161
b4c3046a
PE
11162 * marker.c (bytepos_to_charpos): Remove; unused.
11163
b45db522
PE
11164 * lisp.h (verify_bytepos, count_markers): New decls,
11165 so that gcc does not warn that these functions aren't declared.
11166
85876d07
PE
11167 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11168 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11169 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11170 (copy_text): Remove unused local var.
85876d07 11171
03d78a21 11172 * filelock.c (within_one_second): Now static.
b3dd38ab 11173 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11174
5df8f01b
PE
11175 * buffer.c (fix_overlays_before): Mark locals as initialized.
11176 (fix_start_end_in_overlays): Likewise. This function should be
11177 simplified by using pointers-to-pointers, but that's a different
11178 matter.
b1d876f1 11179 (switch_to_buffer_1): Now static.
8f54f30a
PE
11180 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11181 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11182
a70072c9 11183 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11184 Fix pointer signedness issue.
edced198
PE
11185 (sys_subshell): Mark local as volatile if checking for lint,
11186 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11187 (MAXPATHLEN): Define only if needed.
a70072c9 11188
a0977c44
PE
11189 * process.c (serial_open, serial_configure): Move decls from here ...
11190 * systty.h: ... to here, so that they can be checked.
11191
a884fdcc
PE
11192 * fns.c (get_random, seed_random): Move extern decls from here ...
11193 * lisp.h: ... to here, so that they can be checked.
11194
604efe86 11195 * sysdep.c (reset_io): Now static.
b8950c94 11196 (wait_for_termination_signal): Remove; unused.
604efe86 11197
38fc62d9
PE
11198 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11199 (copy_keymap_item, append_key, push_text_char_description):
11200 Now static.
1004a21a 11201 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11202 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11203 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11204 (describe_map_tree):
11205 Rename locals to avoid shadowing.
38fc62d9 11206
2f2650da
PE
11207 * keyboard.c: Declare functions static if they are not used elsewhere.
11208 (echo_char, echo_dash, cmd_error, top_level_2):
11209 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11210 (read_char, kbd_buffer_get_event, make_lispy_position):
11211 (make_lispy_event, make_lispy_movement, apply_modifiers):
11212 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11213 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11214 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11215 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11216 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11217
a053e86c 11218 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11219 (mark_kboards): Move decl here ...
11220 * alloc.c (mark_kboards): ... from here.
a053e86c 11221
4752793e
PE
11222 * lisp.h (force_auto_save_soon): New decl.
11223
74f10ca7 11224 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11225 (DEFINE_DUMMY_FUNCTION): New macro.
11226 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11227 Use it.
c03cd23f
PE
11228 (main): Add casts to avoid warnings
11229 if GCC considers string literals to be constants.
74f10ca7 11230
022e70d4
PE
11231 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11232
59d6fe83
PE
11233 * dbusbind.c: Pointer signedness fixes.
11234 (xd_signature, xd_append_arg, xd_initialize):
11235 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11236 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11237 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11238 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11239
78320123
PE
11240 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11241 if GCC considers string literals to be constants.
49cebcca 11242 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11243
35ac2a97
SM
112442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11245
fb103ca9
SM
11246 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11247 (print_preprocess, print_object): New macro to fix last change.
11248
35ac2a97
SM
11249 * print.c (print_preprocess): Don't forget font objects.
11250
62973b41
JB
112512011-03-16 Juanma Barranquero <lekktu@gmail.com>
11252
11253 * emacs.c (USAGE3): Doc fixes.
11254
0e48bb22
AS
112552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11256
11257 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11258 structure.
11259
7684e57b
JB
112602011-03-14 Juanma Barranquero <lekktu@gmail.com>
11261
11262 * lisp.h (VWindow_system, Qfile_name_history):
11263 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11264 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11265 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11266
11267 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11268 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11269
11270 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11271 * w32console.c (detect_input_pending, read_input_pending)
11272 (encode_terminal_code):
11273 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11274 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11275 (w32_system_caret_y, Qfile_name_history):
11276 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11277 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11278 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11279 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11280 * w32proc.c (Qlocal, report_file_error):
11281 * w32term.c (Vwindow_system, updating_frame):
11282 * w32uniscribe.c (initialized, uniscribe_font_driver):
11283 Remove unneeded extern declarations.
11284
2aa46d6c
CY
112852011-03-14 Chong Yidong <cyd@stupidchicken.com>
11286
c96bbc66 11287 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11288
cffc6f3b
CY
112892011-03-13 Chong Yidong <cyd@stupidchicken.com>
11290
11291 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11292 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11293 These macros can no longer be used for assignment.
11294
44f230aa
SM
11295 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11296 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11297 (record_buffer_markers, fetch_buffer_markers): New functions for
11298 recording and fetching special buffer markers.
11299 (set_buffer_internal_1, set_buffer_temp): Use them.
11300
11301 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11302
11303 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11304
11305 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11306 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11307
11308 * xdisp.c (hscroll_window_tree):
11309 (reconsider_clip_changes): Use PT instead of BUF_PT.
11310
d251f04b
EZ
113112011-03-13 Eli Zaretskii <eliz@gnu.org>
11312
11313 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11314 $(EMACS_ROOT)/lib/intprops.h.
11315
f0c77cd1
PE
113162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11317
3eca4629
PE
11318 Fix more problems found by GCC 4.5.2's static checks.
11319
7c86ee98
PE
11320 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11321 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11322 (xg_free_frame_widgets): Make it clear that a local variable is
11323 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11324 (gdk_window_get_screen): Make it clear that this macro is needed
11325 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11326 (int_gtk_range_get_value): New function, which avoids a diagnostic
11327 from gcc -Wbad-function-cast.
11328 (xg_set_toolkit_scroll_bar_thumb): Use it.
11329 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11330 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11331 (get_utf8_string, xg_get_file_with_chooser):
11332 Rename locals to avoid shadowing.
11333 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11334
41729b81
PE
11335 * xgselect.c (xg_select): Remove unused var.
11336
f0c77cd1
PE
11337 * image.c (four_corners_best): Mark locals as initialized.
11338 (gif_load): Initialize transparent_p to zero (Bug#8238).
11339 Mark another local as initialized.
ec6cf4c6 11340 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11341
ce0ad53d 11342 * image.c (clear_image_cache): Now static.
d5d5a617 11343 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11344 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11345 (x_edge_detection): Remove unnecessary cast that
11346 gcc -Wbad-function-cast diagnoses.
2037898d 11347 (gif_load): Fix pointer signedness.
6ae141d6
PE
11348 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11349 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11350
33383987 113512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11352
d32df629
PE
11353 Improve quality of tests for time stamp overflow.
11354 For example, without this patch (encode-time 0 0 0 1 1
11355 1152921504606846976) returns the obviously-bogus value (-948597
11356 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11357 reports time overflow. See
11358 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11359 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11360 * editfns.c: Include limits.h and intprops.h.
11361 (TIME_T_MIN, TIME_T_MAX): New macros.
11362 (time_overflow): Move earlier, to before first use.
11363 (hi_time, lo_time): New functions, for an accurate test for
11364 out-of-range times.
11365 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11366 (Fget_internal_run_time): Don't assume time_t fits in int.
11367 (make_time): Use list2 instead of Fcons twice.
11368 (Fdecode_time): More accurate test for out-of-range times.
11369 (check_tm_member): New function.
11370 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11371 (lisp_time_argument): Don't rely on undefined left-shift and
11372 right-shift behavior when checking for time stamp overflow.
8be6f318 11373
fe31d94c
PE
11374 * editfns.c (time_overflow): New function, refactoring common code.
11375 (Fformat_time_string, Fdecode_time, Fencode_time):
11376 (Fcurrent_time_string): Use it.
11377
8be6f318
PE
11378 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11379 * dired.c (make_time): Move to ...
11380 * editfns.c (make_time): ... here.
11381 * systime.h: Note the move.
11382
09d9db2c 113832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11384
126bc0dc
YM
11385 * fringe.c (update_window_fringes): Remove unused variables.
11386
c47cbdfd
YM
11387 * unexmacosx.c (copy_data_segment): Also copy __got section.
11388 (Bug#8223)
11389
7ac80be9
EZ
113902011-03-12 Eli Zaretskii <eliz@gnu.org>
11391
c96bbc66 11392 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11393 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11394 Constify `char *' arguments and their references according to
11395 prototypes in tparam.h.
11396
ecb0f94d 11397 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11398
7ac80be9
EZ
11399 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11400 Adapt all references accordingly.
11401
11402 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11403
ef1fd07e
TT
114042011-03-11 Tom Tromey <tromey@redhat.com>
11405
11406 * buffer.c (syms_of_buffer): Remove obsolete comment.
11407
7ef4b50c
EZ
114082011-03-11 Eli Zaretskii <eliz@gnu.org>
11409
11410 * termhooks.h (encode_terminal_code): Declare prototype.
11411
11412 * msdos.c (encode_terminal_code): Don't declare prototype.
11413
11414 * term.c (encode_terminal_code): Now external again, used by
11415 w32console.c and msdos.c.
11416
44f230aa
SM
11417 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11418 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11419
4b1ec863 114202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11421
1714f52b 11422 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11423
4b1ec863
PE
11424 * fringe.c (update_window_fringes): Mark locals as initialized
11425 (Bug#8227).
11426 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11427
524c7aa6
PE
11428 * alloc.c (mark_fringe_data): Move decl from here ...
11429 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11430 to check its interface.
11431 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11432
a5c0af81 11433 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11434 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11435 (fontset_font): Mark local as initialized.
a9a06e0b 11436 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11437
b4716021
PE
11438 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11439
811e9bac 11440 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11441 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11442 (x_own_selection, Fx_disown_selection_internal): Rename locals
11443 to avoid shadowing.
11444 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11445
7e3ab302
PE
11446 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11447 so that the caller can use some name other than gcpro1.
11448 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11449 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11450 (Fx_backspace_delete_keys_p):
11451 Use them to avoid shadowing, and rename vars to avoid shadowing.
11452 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11453 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11454 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11455 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11456 Remove unused locals.
7e3ab302
PE
11457 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11458 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11459 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11460 macros.
f78faa98 11461
e2b13473
PE
11462 * xterm.h (x_mouse_leave): New decl.
11463
77f23912
PE
11464 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11465 Remove unused functions.
cdf4ba58
PE
11466 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11467 (x_calc_absolute_position): Now static.
7411c686 11468 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11469 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11470 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11471 unless they are used.
38d0b34a
PE
11472 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11473 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11474 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11475 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11476 (x_error_catcher, x_connection_closed, x_error_handler):
11477 (x_error_quitter, xembed_send_message, x_iconify_frame):
11478 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11479 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11480 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11481
44f230aa
SM
11482 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11483 Rename or move locals to avoid shadowing.
6b463e58 11484 (tty_defined_color, merge_face_heights): Now static.
5967d051 11485 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11486 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11487 does not deduce is never used uninitialized.
73719eba
PE
11488 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11489 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11490
426994c3 11491 * terminal.c (store_terminal_param): Now static.
5489860b 11492
032f1620 11493 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11494 (set_frame_menubar): Remove unused local.
d4323972 11495 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11496 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11497 since they might point to immutable storage.
281585b0
PE
11498 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11499 since it's unused otherwise.
032f1620 11500
367c19e5 11501 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11502 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11503 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11504 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11505 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11506 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11507 does not deduce are never used uninitialized.
70739cbe 11508
07b48fa9
PE
11509 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11510
8868a238 11511 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11512 * window.c (window_loop, size_window):
11513 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11514
7e5cf297 11515 * window.c (display_buffer): Now static.
d6550a9f
PE
11516 (size_window): Mark variables that gcc -Wuninitialized
11517 does not deduce are never used uninitialized.
a586633d
PE
11518 * window.h (check_all_windows): New decl, to forestall
11519 gcc -Wmissing-prototypes diagnostic.
5b555da1 11520 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11521
f6095868
PE
11522 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11523 shadowing.
11524 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11525 Include <limits.h>.
11526 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11527 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11528 (load_charset_map): Mark variables that gcc -Wuninitialized
11529 does not deduce are never used uninitialized.
53df7c11 11530 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11531
f38b440c
PE
11532 * coding.c (coding_set_source, coding_set_destination):
11533 Use "else { /* comment */ }" rather than "else /* comment */;"
11534 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11535 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11536 a block, when the outer 'i' will do.
11537 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11538 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11539 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11540 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11541 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11542 Rename locals to avoid shadowing.
11543 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11544 * coding.c (emacs_mule_char, encode_invocation_designation):
11545 Now static, since they're not used elsewhere.
413bb2db 11546 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11547 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11548 (decode_coding_emacs_mule): Mark variables that gcc
11549 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11550 (detect_coding_iso_2022): Initialize a local variable that might
11551 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11552 this initialization is needed. (Bug#8211)
5f58e762
PE
11553 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11554 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11555 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11556 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11557 Remove unused macros.
f38b440c 11558
232b38b9 11559 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11560 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11561 * character.c (string_count_byte8): Likewise.
232b38b9 11562
fb90da1b
PE
11563 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11564 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11565
fb93dbc2
PE
11566 * chartab.c (copy_sub_char_table): Now static, since it's not used
11567 elsewhere.
5c156ace
PE
11568 (sub_char_table_ref_and_range, char_table_ref_and_range):
11569 Rename locals to avoid shadowing.
bbcd0949 11570 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11571
7d3b3862 11572 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11573 (BIDI_BOB): Remove unused macro.
7d3b3862 11574
6be7d3da
PE
11575 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11576 deduce are never used uninitialized.
c2ed9c8b 11577 * term.c (encode_terminal_code): Likewise.
6be7d3da 11578
75f8807f 11579 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11580
50938595
PE
11581 * tparam.h: New file.
11582 * term.c, tparam.h: Include it.
11583 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11584 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11585 Move these decls to tparam.h, and make them agree with what
11586 is actually in tparam.c. The previous trick of using incompatible
11587 decls in different modules does not conform to the C standard.
11588 All callers of tparam changed to use tparam's actual API.
11589 * tparam.c (tparam1, tparam, tgoto):
11590 Use const pointers where appropriate.
11591
fbceeba2
PE
11592 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11593 * cm.h (struct cm): Likewise.
11594 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11595 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11596 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11597 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11598 (turn_on_face, init_tty): Likewise.
11599 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11600
7f3f1250
PE
11601 * term.c (term_mouse_position): Rename local to avoid shadowing.
11602
e6ca6543
PE
11603 * alloc.c (mark_ttys): Move decl from here ...
11604 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11605
c40f8d15
AS
116062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11607
11608 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11609
cfe0661d
JB
116102011-03-09 Juanma Barranquero <lekktu@gmail.com>
11611
11612 * search.c (compile_pattern_1): Remove argument regp, unused since
11613 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11614 (compile_pattern): Don't pass it.
11615
0afb4571
J
116162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11617
11618 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11619 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11620 for ! HAVE_GTK3.
11621 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11622
11623 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11624
11625 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11626 gdk_window_get_screen, gdk_window_get_geometry,
11627 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11628 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11629 (xg_get_pixbuf_from_pixmap): New function.
11630 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11631 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11632 Call xg_get_pixbuf_from_pixmap instead of
11633 gdk_pixbuf_get_from_drawable.
11634 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11635 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11636 (xg_check_special_colors): Use GtkStyleContext and its functions
11637 for HAVE_GTK3.
11638 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11639 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11640 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11641 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11642 Call gtk_widget_get_preferred_size.
0afb4571
J
11643 (xg_frame_resized): gdk_window_get_geometry only takes 5
11644 parameters.
44f230aa
SM
11645 (xg_win_to_widget, xg_event_is_for_menubar):
11646 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11647 (xg_set_widget_bg): New function.
11648 (delete_cb): New function.
895009e1 11649 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11650 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11651 (xg_set_background_color): Call xg_set_widget_bg.
11652 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11653 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11654 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11655 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11656 if ! HAVE_GTK3.
11657 (update_frame_tool_bar): Call gtk_widget_hide.
11658 (xg_initialize): Use GDK_KEY_g.
11659
11660 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11661 if ! HAVE_GTK3
11662 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11663
11664 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11665 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11666 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11667
1c2cc4ef
JB
116682011-03-08 Juanma Barranquero <lekktu@gmail.com>
11669
11670 * w32xfns.c (select_palette): Check success of RealizePalette against
11671 GDI_ERROR, not zero.
11672
33383987 11673See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11674
11675;; Local Variables:
11676;; coding: utf-8
aac0c6e3
MR
11677;; End:
11678
2f097256 11679 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11680
11681 This file is part of GNU Emacs.
11682
11683 GNU Emacs is free software: you can redistribute it and/or modify
11684 it under the terms of the GNU General Public License as published by
11685 the Free Software Foundation, either version 3 of the License, or
11686 (at your option) any later version.
11687
11688 GNU Emacs is distributed in the hope that it will be useful,
11689 but WITHOUT ANY WARRANTY; without even the implied warranty of
11690 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11691 GNU General Public License for more details.
11692
11693 You should have received a copy of the GNU General Public License
11694 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.