Check for overflow when converting integer to cons and back.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0c671da6 12011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2
be44ca6c
PE
3 Check for overflow when converting integer to cons and back.
4 * charset.c (Fdefine_charset_internal, Fdecode_char):
5 Use cons_to_unsigned to catch overflow.
6 (Fencode_char): Use INTEGER_TO_CONS.
7 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9 * data.c (long_to_cons, cons_to_long): Remove.
10 (cons_to_unsigned, cons_to_signed): New functions.
11 These signal an error for invalid or out-of-range values.
12 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14 * font.c (Ffont_variation_glyphs):
15 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
16 * lisp.h: Include <intprops.h>.
17 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
18 (cons_to_signed, cons_to_unsigned): New decls.
19 (long_to_cons, cons_to_long): Remove decls.
20 * undo.c (record_first_change): Use INTEGER_TO_CONS.
21 (Fprimitive_undo): Use CONS_TO_INTEGER.
22 * xfns.c (Fx_window_property): Likewise.
23 * xselect.c: Include <limits.h>.
24 (x_own_selection, selection_data_to_lisp_data):
25 Use INTEGER_TO_CONS.
26 (x_handle_selection_request, x_handle_selection_clear)
27 (x_get_foreign_selection, Fx_disown_selection_internal)
28 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
29 (lisp_data_to_selection_data): Use cons_to_unsigned.
30 (x_fill_property_data): Use cons_to_signed.
31 Report values out of range.
32
d1f3d2af
PE
33 Check for buffer and string overflow more precisely.
34 * buffer.h (BUF_BYTES_MAX): New macro.
35 * lisp.h (STRING_BYTES_MAX): New macro.
36 * alloc.c (Fmake_string):
37 * character.c (string_escape_byte8):
38 * coding.c (coding_alloc_by_realloc):
39 * doprnt.c (doprnt):
40 * editfns.c (Fformat):
41 * eval.c (verror):
42 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
43 since they may not be the same number.
44 * editfns.c (Finsert_char):
45 * fileio.c (Finsert_file_contents):
46 Likewise for BUF_BYTES_MAX.
47
dd52fcea
PE
48 * image.c: Use ptrdiff_t, not int, for sizes.
49 (slurp_file): Switch from int to ptrdiff_t.
50 All uses changed.
51 (slurp_file): Check that file size fits in both size_t (for
52 malloc) and ptrdiff_t (for sanity and safety).
53
7f9bbdbb
PE
54 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
55 if b->modtime has its maximal value.
56
dfe18f82
PE
57 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
58
84acfcf0
PE
59 Don't assume time_t can fit into int.
60 * buffer.h (struct buffer.modtime): Now time_t, not int.
61 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
62 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
63
ccd9a01a
PE
64 Minor fixes for signed vs unsigned integers.
65 * character.h (MAYBE_UNIFY_CHAR):
66 * charset.c (maybe_unify_char):
67 * keyboard.c (read_char, reorder_modifiers):
68 XINT -> XFASTINT, since the integer must be nonnegative.
69 * ftfont.c (ftfont_spec_pattern):
70 * keymap.c (access_keymap, silly_event_symbol_error):
71 XUINT -> XFASTINT, since the integer must be nonnegative.
72 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
73 since it makes no difference and we prefer signed.
74 * keyboard.c (record_char): Use XUINT when all the neighbors do.
75 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
76 nonnegative.
77
4d09bcf6
PE
782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
79
80 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
81 Do not assume that spare memory exists; that assumption is valid
82 only if SYSTEM_MALLOC.
83 (LARGE_REQUEST): New macro, so that the issue of large requests
84 is separated from the issue of spare memory.
85
810928a2
AS
862011-06-05 Andreas Schwab <schwab@linux-m68k.org>
87
172418ad
AS
88 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
89 format. (Bug#8806)
90
43f862f7
AS
91 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
92
810928a2
AS
93 * xfns.c (x_set_scroll_bar_default_width): Move declarations
94 before statements.
95
a059fe24
JD
962011-06-05 Jan Djärv <jan.h.d@swipnet.se>
97
98 * gtkutil.c (xg_get_default_scrollbar_width): New function.
99
100 * gtkutil.h: Declare xg_get_default_scrollbar_width.
101
102 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
103 min width by calling x_set_scroll_bar_default_width (Bug#8505).
104
989bf368
JB
1052011-06-05 Juanma Barranquero <lekktu@gmail.com>
106
107 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
108
4b80f674
CY
1092011-06-04 Chong Yidong <cyd@stupidchicken.com>
110
111 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
112 (x_clipboard_manager_save): Add return value.
113 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
114 error handlers.
115 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
116 Obey Vx_select_enable_clipboard_manager. Catch errors in
117 x_clipboard_manager_save (Bug#8779).
118 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 119 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 120
99a33b77 1212011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
122
123 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
124
99a33b77 1252011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
126
127 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
128 in the current matrix if keep_current_p is non-zero.
129
8264569d
EZ
1302011-06-04 Eli Zaretskii <eliz@gnu.org>
131
132 * bidi.c (bidi_level_of_next_char): Fix last change.
133
57f97249
EZ
1342011-06-03 Eli Zaretskii <eliz@gnu.org>
135
fec2107c 136 Support bidi reordering of text covered by display properties.
57f97249 137
fec2107c
EZ
138 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
139 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
140 (bidi_cache_search, bidi_cache_iterator_state)
141 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
142 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
143 character positions inside a run of characters covered by a
144 display string.
145 (bidi_paragraph_init, bidi_resolve_explicit_1)
146 (bidi_level_of_next_char): Call bidi_fetch_char and
147 bidi_fetch_char_advance instead of FETCH_CHAR and
148 FETCH_CHAR_ADVANCE.
149 (bidi_init_it): Initialize new members.
150 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
151 definitions.
152 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
153 instead of using explicit *_CHAR codes.
154 (bidi_resolve_explicit, bidi_resolve_weak): Use
155 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
156 bidirectional text is supported only in multibyte buffers.
157 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
158 it to initialize the frame_window_p member of struct bidi_it.
159 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
160 (bidi_resolve_explicit, bidi_resolve_weak)
161 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
162 bidi_it->nchars is non-positive.
163 (bidi_level_of_next_char): Don't try to lookup the cache for the
164 next/previous character if nothing is cached there yet, or if we
165 were just reseat()'ed to a new position.
c40e2fb2 166
0e14fe90
EZ
167 * xdisp.c (set_cursor_from_row): Set start and stop points
168 according to the row's direction when priming the loop that looks
169 for the glyph on which to display cursor.
170 (single_display_spec_intangible_p): Function deleted.
171 (display_prop_intangible_p): Reimplement to call
172 handle_display_spec instead of single_display_spec_intangible_p.
173 Accept 3 additional arguments needed by handle_display_spec. This
174 fixes incorrect cursor motion across display property with complex
175 values: lists, `(when COND...)' forms, etc.
176 (single_display_spec_string_p): Support property values that are
177 lists with the argument STRING its top-level element.
178 (display_prop_string_p): Fix the condition for processing a
179 property that is a list to be consistent with handle_display_spec.
fec2107c 180 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
181 last portion of handle_display_prop.
182 (compute_display_string_pos): Accept additional argument
183 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
184 value of a `display' property is a "replacing spec".
185 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
186 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
187 the display property, but just return a value indicating whether
188 the display property will replace the characters it covers.
189 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
190 frame_window_p members of struct bidi_it.
fec2107c
EZ
191 (compute_display_string_pos, compute_display_string_end): New
192 functions.
193 (push_it): Accept second argument POSITION, where pop_it should
194 jump to continue iteration.
195 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 196
fec2107c
EZ
197 * keyboard.c (adjust_point_for_property): Adjust the call to
198 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
199
200 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
201 (bidi_init_it): Update prototypes.
202 (display_prop_intangible_p): Update prototype.
203 (compute_display_string_pos, compute_display_string_end): Declare
204 prototypes.
205 (struct bidi_it): New members nchars and disp_pos. ch_len is now
206 EMACS_INT.
fc6f18ce 207
40087514 2082011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 209
57f53182
PE
210 Malloc failure behavior now depends on size of allocation.
211 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
212 * lisp.h: Change signatures accordingly.
213 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
214 All callers changed. (Bug#8762)
215
216 * gnutls.c: Use Emacs's memory allocators.
217 Without this change, the gnutls library would invoke malloc etc.
218 directly, which causes problems on non-SYNC_INPUT hosts, and which
219 runs afoul of improving memory_full behavior. (Bug#8761)
220 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
221 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
222 xfree instead of the default malloc, realloc, free.
223 (Fgnutls_boot): No need to check for memory allocation failure,
224 since xmalloc does that for us.
225
ac32cd99 226 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
227 * category.c (hash_get_category_set):
228 * ccl.c (ccl_driver):
229 * charset.c (Fdefine_charset_internal):
230 * charset.h (struct charset.hash_index):
231 * composite.c (get_composition_id, gstring_lookup_cache)
232 (composition_gstring_put_cache):
233 * composite.h (struct composition.hash_index):
234 * dispextern.h (struct image.hash):
235 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
236 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
237 (hashfn_equal, hashfn_user_defined, make_hash_table)
238 (maybe_resize_hash_table, hash_lookup, hash_put)
239 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
240 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
241 (Fsxhash, Fgethash, Fputhash, Fmaphash):
242 * image.c (make_image, search_image_cache, lookup_image)
243 (xpm_put_color_table_h):
244 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 245 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
246 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
247 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
248 * alloc.c (allocate_vectorlike):
249 Check for overflow in vector size calculations.
250 * ccl.c (ccl_driver):
251 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
252 * fns.c, image.c: Remove unnecessary static decls that would otherwise
253 need to be updated by these changes.
40087514
PE
254 * fns.c (make_hash_table, maybe_resize_hash_table):
255 Check for integer overflow with large hash tables.
0de4bb68
PE
256 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
257 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
258 (SXHASH_REDUCE): New macro.
259 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
260 Use it instead of discarding useful hash info with large hash values.
261 (sxhash_float): New function.
262 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
263 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
264 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
265 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
266 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
267 Adjust signatures to match updated version of code.
268 (consing_since_gc): Now EMACS_INT, since a single hash table can
269 use more than INT_MAX bytes.
270
698d32e2
DN
2712011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
272
273 Make it possible to build with GCC-4.6+ -O2 -flto.
274
275 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
276
fd6fa53f
SM
2772011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
278
279 * minibuf.c (get_minibuffer, read_minibuf_unwind):
280 Call minibuffer-inactive-mode.
281
864db017
JB
2822011-05-31 Juanma Barranquero <lekktu@gmail.com>
283
284 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
285 Update dependencies.
286
2ad0baf4
DN
2872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
288
289 * data.c (init_data): Remove code for UTS, this system is not
290 supported anymore.
291
4fcc2638
DN
2922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
293
294 Don't force ./temacs to start in terminal mode.
295
296 * frame.c (make_initial_frame): Initialize faces in all cases, not
297 only when CANNOT_DUMP is defined.
298 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
299
c56e0fd5
DN
3002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
301
302 * dispnew.c (add_window_display_history): Use const for the string
303 pointer. Remove declaration, not needed.
304
333d54da 3052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 306
55d4c1b2 307 Use 'inline', not 'INLINE'.
333d54da 308 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
309 * alloc.c, fontset.c (INLINE): Remove.
310 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
311 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
312 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
313 * gmalloc.c (register_heapinfo): Use inline unconditionally.
314 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
315
738db178
DN
3162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
317
318 Make it possible to run ./temacs.
319
320 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
321 syms_of_callproc does the same thing. Remove test for
322 "initialized", do it in the caller.
323 * emacs.c (main): Avoid calling set_initial_environment when dumping.
324
620c53a6
SM
3252011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
326
327 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
328 (read_minibuf): Use get_minibuffer.
329 (syms_of_minibuf): Use DEFSYM.
330 (Qmetadata): New var.
331 * data.c (Qbuffer): Don't make it static.
332 (syms_of_data): Use DEFSYM.
333
e003a292
PE
3342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
335
336 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
337 (CCL_CODE_MIN): New macro.
338
ed008a6d
PE
3392011-05-30 Paul Eggert <eggert@cs.ucla.edu>
340
3687c2ef
PE
341 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
342
ed008a6d
PE
343 * eval.c (Qdebug): Now static.
344 * lisp.h (Qdebug): Remove decl. This reverts a part of the
345 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
346 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
347
d66c4c7c
CY
3482011-05-29 Chong Yidong <cyd@stupidchicken.com>
349
350 * image.c: Various fixes to ImageMagick code comments.
351 (Fimagemagick_types): Doc fix.
352
5fbc2025
PE
3532011-05-29 Paul Eggert <eggert@cs.ucla.edu>
354
0196f88a
PE
355 Minor fixes prompted by GCC 4.6.0 warnings.
356
357 * xselect.c (converted_selections, conversion_fail_tag): Now static.
358
5fbc2025
PE
359 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
360 (x_clipboard_manager_save_all): Move extern decl to ...
361 * xterm.h: ... here, so that it can be checked for consistency.
362
1dd3c2d9
CY
3632011-05-29 Chong Yidong <cyd@stupidchicken.com>
364
365 * xselect.c (x_clipboard_manager_save_frame)
366 (x_clipboard_manager_save_all): New functions.
367 (Fx_clipboard_manager_save): Lisp function deleted.
368
369 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
370 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
371
372 * xterm.h: Update prototype.
373
5ba6571d
WX
3742011-05-28 William Xu <william.xwl@gmail.com>
375
376 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
377 exiting (Bug#8239).
378
3eaff834
JM
3792011-05-28 Jim Meyering <meyering@redhat.com>
380
e1900994 381 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
382 * fns.c (to_uchar): Define.
383 (crypto_hash_function): Use it to convert some newly-signed
384 variables to unsigned, to avoid sign-extension bugs. For example,
385 without this change, (md5 "truc") would evaluate to
386 45723a2aff78ff4fff7fff1114760e62 rather than the expected
387 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 388 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 389
0f6990a7
PE
3902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
391
392 Integer overflow fixes.
c8a9ca5a 393
08686060
PE
394 * dbusbind.c: Serial number integer overflow fixes.
395 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
396 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
397 to hold a serial number that is too large for a fixnum.
398 (Fdbus_method_return_internal, Fdbus_method_error_internal):
399 Check for serial numbers out of range. Decode any serial number
59568bf0 400 that was so large that it became a float. (Bug#8722)
08686060 401
2d1fc3c7
PE
402 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
403 (Fdbus_call_method, Fdbus_call_method_asynchronously):
404 Use XFASTINT rather than XUINT when numbers are nonnegative.
405 (xd_append_arg, Fdbus_method_return_internal):
406 (Fdbus_method_error_internal): Likewise. Also, for unsigned
407 arguments, check that Lisp number is nonnegative, rather than
59568bf0 408 silently wrapping negative numbers around. (Bug#8722)
30217ff0 409 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 410 (Bug#8722)
2d1fc3c7 411
c8a9ca5a
PE
412 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
413
519e1d69
PE
414 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
415
30569699
PE
416 ccl: add integer overflow checks
417 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
418 (IN_INT_RANGE): New macros.
419 (ccl_driver): Use them to check for integer overflow when
420 decoding a CCL program. Many of the new checks are whether XINT (x)
421 fits in int; it doesn't always, on 64-bit hosts. The new version
422 doesn't catch all possible integer overflows, but it's an
847044ea 423 improvement. (Bug#8719)
30569699 424
c11285dc
PE
425 * alloc.c (make_event_array): Use XINT, not XUINT.
426 There's no need for unsigned here.
427
fdccd48e
PE
428 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
429 This follows up to the 2011-05-06 change that substituted uintptr_t
430 for EMACS_INT. This case wasn't caught back then.
431
37910ab2
PE
432 Rework Fformat to avoid integer overflow issues.
433 * editfns.c: Include <float.h> unconditionally, as it's everywhere
434 now (part of C89). Include <verify.h>.
435 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
436 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
437 (Fformat): Avoid the prepass trying to compute sizes; it was only
438 approximate and thus did not catch overflow reliably. Instead, walk
439 through the format just once, formatting and computing sizes as we go,
440 checking for integer overflow at every step, and allocating a larger
441 buffer as needed. Keep track separately whether the format is
442 multibyte. Keep only the most-recently calculated precision, rather
443 than them all. Record whether each argument has been converted to
444 string. Use EMACS_INT, not int, for byte and char and arg counts.
445 Support field widths and precisions larger than INT_MAX. Avoid
446 sprintf's undefined behavior with conversion specifications such as %#d
447 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
448 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
449 formatting out-of-range floating point numbers with int
450 formats. (Bug#8668)
451
2e6578fb
PE
452 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
453
0ae6bdee
PE
454 * data.c: Avoid integer truncation in expressions involving floats.
455 * data.c: Include <intprops.h>.
456 (arith_driver): When there's an integer overflow in an expression
457 involving floating point, convert the integers to floating point
458 so that the resulting value does not suffer from catastrophic
459 integer truncation. For example, on a 64-bit host (* 4
460 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
461 Do not rely on undefined behavior after integer overflow.
462
de883a70
PE
463 merge count_size_as_multibyte, parse_str_to_multibyte
464 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 465 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
466 Check for integer overflow.
467 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
468 since it's now a duplicate of the other. This is more of
469 a character than a buffer op, so better that it's in character.c.
470 * fns.c, print.c: Adjust to above changes.
471
2ff916cb
PE
4722011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
473
474 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
475
f1b54466
PE
4762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
477
fb1ac845
PE
478 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
479 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
480 (x_clipboard_manager_save): Now static.
481 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
482
f1b54466
PE
483 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
484 (crypto_hash_function): Now static.
485 Fix pointer signedness problems. Avoid unnecessary initializations.
486
a9f737ee
CY
4872011-05-27 Chong Yidong <cyd@stupidchicken.com>
488
489 * termhooks.h (Vselection_alist): Make it terminal-local.
490
491 * terminal.c (create_terminal): Initialize it.
492
493 * xselect.c: Support for clipboard managers.
494 (Vselection_alist): Move to termhooks.h as terminal-local var.
495 (LOCAL_SELECTION): New macro.
496 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
497 (symbol_to_x_atom): Remove gratuitous arg.
498 (x_handle_selection_request, lisp_data_to_selection_data)
499 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
500 (x_own_selection, x_get_local_selection, x_convert_selection):
501 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
502 (some_frame_on_display): Delete unused function.
503 (Fx_own_selection_internal, Fx_get_selection_internal)
504 (Fx_disown_selection_internal, Fx_selection_owner_p)
505 (Fx_selection_exists_p): New optional frame arg.
506 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
507 (x_handle_selection_clear): Don't treat other terminals with the
508 same keyboard specially. Use the terminal-local Vselection_alist.
509 (x_clear_frame_selections): Use Frun_hook_with_args.
510
511 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
512
513 * xterm.h: Add support for those atoms.
514
e067f0c1
CY
5152011-05-26 Chong Yidong <cyd@stupidchicken.com>
516
517 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
518 (converted_selections, conversion_fail_tag): New global variables.
519 (x_selection_request_lisp_error): Free the above.
520 (x_get_local_selection): Remove unnecessary code.
521 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
522 of converted selections stored in converted_selections.
523 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
524 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
525 (x_convert_selection): New function.
526 (x_handle_selection_event): Simplify.
527 (x_get_foreign_selection): Don't ignore incoming requests while
528 waiting for an answer; this will fail when we implement
529 SAVE_TARGETS, and seems unnecessary anyway.
530 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
531 (Vx_sent_selection_functions): Doc fix.
532
0f4aebc0
LL
5332011-05-26 Leo Liu <sdl.web@gmail.com>
534
535 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
536
e61124cd
YM
5372011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
538
539 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
540
541 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
542 for fringe update if it has periodic bitmap.
543 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
544 and fringe_bitmap_periodic_p.
545
546 * fringe.c (get_fringe_bitmap_data): New function.
547 (draw_fringe_bitmap_1, update_window_fringes): Use it.
548 (update_window_fringes): Record periodicity of fringe bitmap in glyph
549 row. Mark glyph row for fringe update if periodicity changed.
550
551 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
552 for fringe update unless it has periodic bitmap.
553
f16d9837
KH
5542011-05-25 Kenichi Handa <handa@m17n.org>
555
556 * xdisp.c (get_next_display_element): Set correct it->face_id for
557 a static composition.
558
e1b90ef6
LL
5592011-05-24 Leo Liu <sdl.web@gmail.com>
560
561 * deps.mk (fns.o):
562 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
563
564 * fns.c (crypto_hash_function, Fsha1): New function.
565 (Fmd5): Use crypto_hash_function.
566 (syms_of_fns): Add Ssha1.
567
7400048f
PE
5682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
569
570 * gnutls.c: Remove unused macros.
571 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
572 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
573 Remove macros that are defined and never used.
574 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
575
abb71cf4
CY
5762011-05-22 Chong Yidong <cyd@stupidchicken.com>
577
578 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
579 (Fx_get_selection_internal): Minor cleanup.
580 (Fx_own_selection_internal): Rename arguments for consistency with
581 select.el.
582
6307db39
PE
5832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
584
585 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
586
f3d4e0a4
CY
5872011-05-22 Chong Yidong <cyd@stupidchicken.com>
588
589 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
590
4d8ade89
YM
5912011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
592
593 * dispnew.c (scrolling_window): Don't exclude the case that the
594 last enabled row in the desired matrix touches the bottom boundary.
595
32078c8d
GM
5962011-05-21 Glenn Morris <rgm@gnu.org>
597
598 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
599 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
600 and add some more files.
32078c8d 601
7285dc67
EZ
6022011-05-20 Eli Zaretskii <eliz@gnu.org>
603
604 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
605 report_file_error introduced by the change from 2011-05-07.
606
89d1bd22
PE
6072011-05-20 Paul Eggert <eggert@cs.ucla.edu>
608
609 * systime.h (Time): Define only if emacs is defined.
610 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
611 where the include path doesn't have X11/X.h by default. See
612 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
613
e23640bb 6142011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
615
616 * composite.c (find_automatic_composition): Fix previous change.
617
b9704ad9
GM
6182011-05-20 Glenn Morris <rgm@gnu.org>
619
620 * lisp.mk: New file, split from Makefile.in.
621 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
622 (shortlisp): Remove.
623 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
624
4a720484
GM
6252011-05-19 Glenn Morris <rgm@gnu.org>
626
627 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
628 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
629 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
630 (lisp): Set the order to that of loadup.el.
631 (shortlisp): Make it a copy of $lisp.
632 (SOME_MACHINE_LISP): Remove.
633 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
634 Use just $shortlisp, not $SOME_MACHINE_LISP too.
635
a28d4396
KH
6362011-05-18 Kenichi Handa <handa@m17n.org>
637
638 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
639 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
640 (find_automatic_composition): Mostly rewrite for efficiency.
641
a2b1fa8e
JB
6422011-05-18 Juanma Barranquero <lekktu@gmail.com>
643
644 * makefile.w32-in: Update dependencies.
645
8e1f5610
CS
6462011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
647
648 * menu.c: Include limits.h (fixes the MS-Windows build broken by
649 revision 104625).
650
7025ee00 6512011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 652
cdfa6eab
PE
653 Fix some integer overflow issues, such as string length overflow.
654
06d6db33
PE
655 * insdel.c (count_size_as_multibyte): Check for string overflow.
656
2b4560a8
PE
657 * character.c (lisp_string_width): Check for string overflow.
658 Use EMACS_INT, not int, for string indexes and lengths; in
659 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
660 the resulting string length overflows an EMACS_INT; instead,
661 report a string overflow if no precision given. When checking for
662 precision exhaustion, use a check that cannot possibly have
663 integer overflow. (Bug#8675)
664 * character.h (lisp_string_width): Adjust to new signature.
665
cb93f9be
PE
666 * alloc.c (string_overflow): New function.
667 (Fmake_string): Use it. This doesn't change behavior, but saves
668 a few bytes and will simplify future changes.
669 * character.c (string_escape_byte8): Likewise.
670 * lisp.h (string_overflow): New decl.
671
1a1f3366
PE
672 Fixups, following up to the user-interface timestamp change.
673 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
674 for UI timestamps, instead of unsigned long.
9fbd6841
PE
675 * msdos.c (mouse_get_pos): Likewise.
676 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
677 * w32gui.h (Time): Define by including "systime.h" rather than by
678 declaring it ourselves. (Bug#8664)
679
d4e3e4d3
PE
680 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
681 * image.c (clear_image_cache): Likewise.
682
f6a24d19
PE
683 * term.c (term_mouse_position): Don't assume time_t wraparound.
684
08dc5ae6
PE
685 Be more systematic about user-interface timestamps.
686 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
687 and sometimes 'EMACS_UINT', to represent these timestamps.
688 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
689 This makes the code easier to follow, and makes it easier to catch
690 integer overflow bugs such as Bug#8664.
691 * frame.c (Fmouse_position, Fmouse_pixel_position):
692 Use Time, not unsigned long, for user-interface timestamps.
693 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
694 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
695 * keyboard.h (last_event_timestamp): Likewise.
696 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
697 * menu.h (xmenu_show): Likewise.
698 * term.c (term_mouse_position): Likewise.
699 * termhooks.h (struct input_event.timestamp): Likewise.
700 (struct terminal.mouse_position_hook): Likewise.
701 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
702 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
703 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
704 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
705 what it was before.
706 * menu.h, termhooks.h: Include "systime.h", for Time.
707
8e55734a
PE
708 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
709 Don't assume that the difference between two unsigned long values
710 can fit into an integer. At this point, we know button_down_time
711 <= event->timestamp, so the difference must be nonnegative, so
712 there's no need to cast the result if double-click-time is
713 nonnegative, as it should be; check that it's nonnegative, just in
714 case. This bug is triggered when events are more than 2**31 ms
86db42d2 715 apart (about 25 days). (Bug#8664)
8e55734a 716
841f1b75 717 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 718 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 719
3e26f69c
PE
720 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
721 that always fit in int. Use a sentinel instead of a counter, to
722 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
723 * frame.h (struct frame): Use int for menu_bar_items_used
724 instead of EMACS_INT, since it always fits in int.
3e26f69c 725
5cc152c0
PE
726 * menu.c (grow_menu_items): Check for int overflow.
727
d89eb65e
PE
728 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
729
5235bd3e
PE
730 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
731 Before, the code was not consistent. These values cannot exceed
732 2**31 - 1 so there's no need to make them unsigned.
733 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
734 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
735 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
736 as modifiers.
737 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
738
bc827e23
PE
739 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
740 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
741 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
742 presumably because the widths might not match.
743
78eb494e
PE
744 * window.c (size_window): Avoid needless test at loop start.
745
04f2d78b
CB
7462011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
747
748 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
749
d2fc7e3d 7502011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
751
752 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
753
d2fc7e3d 7542011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
755
756 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
757 `width' to `bar_area_x' and `bar_area_width', respectively.
758 (x_scroll_run): Take account of fringe background extension.
759
04f2d78b
CB
760 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
761 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
762 `bar_area_width', respectively.
763 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
764 background extension.
765
79b70037
GM
7662011-05-10 Jim Meyering <meyering@redhat.com>
767
768 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
769
2f142cc5
JB
7702011-05-10 Juanma Barranquero <lekktu@gmail.com>
771
772 * image.c (Finit_image_library): Return t for built-in image types,
773 like pbm and xbm. (Bug#8640)
774
57679c86
AS
7752011-05-09 Andreas Schwab <schwab@linux-m68k.org>
776
777 * w32menu.c (set_frame_menubar): Fix submenu allocation.
778
888c9e86
EZ
7792011-05-07 Eli Zaretskii <eliz@gnu.org>
780
b0512a1d
EZ
781 * w32console.c (Fset_screen_color): Doc fix.
782 (Fget_screen_color): New function.
783 (syms_of_ntterm): Defsubr it.
784
7285dc67
EZ
785 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
786 unlink the temporary file if Fcall_process didn't create it in the
787 first place.
788 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
789 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
790 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
791 cue to call_process_cleanup not to close that handle.
792
4d3fcc8e
BK
7932011-05-07 Ben Key <bkey76@gmail.com>
794
795 * makefile.w32-in: The bootstrap-temacs rule now makes use of
796 one of two shell specific rules, either bootstrap-temacs-CMD or
797 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
798 to the previous implementation of the bootstrap-temacs rule.
799 The bootstrap-temacs-CMD rule is similar to the previous
800 implementation of the bootstrap-temacs rule except that it
801 makes use of the ESC_CFLAGS variable instead of the CFLAGS
802 variable.
803
804 These changes, along with some changes to nt/configure.bat,
805 nt/gmake.defs, and nt/nmake.defs, are required to extend my
806 earlier fix to add support for --cflags and --ldflags options
807 that include quotes so that it works whether make uses cmd or
808 sh as the shell.
809
b4289b64
MA
8102011-05-06 Michael Albinus <michael.albinus@gmx.de>
811
812 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
813 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
814 is a constant.
815 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
816 a string. Handle both cases.
817 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
818 (Fdbus_register_method): Use Qinvalid_function.
819
af4c0e28
JB
8202011-05-06 Juanma Barranquero <lekktu@gmail.com>
821
822 * makefile.w32-in: Update dependencies.
823 (LISP_H): Add inttypes.h and stdin.h.
824 (PROCESS_H): Add unistd.h.
825
c51453d9
EZ
8262011-05-06 Eli Zaretskii <eliz@gnu.org>
827
828 * lread.c: Include limits.h (fixes the MS-Windows build broken by
829 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
830
8ff0ac3c 8312011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 832
4c4b566b
PE
833 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
834
aab2b9b5
PE
835 * term.c (vfatal): Remove stray call to va_end.
836 It's not needed and the C Standard doesn't allow it here anyway.
837
c378da0b
PE
838 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
839 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
840
288b08c7
PE
841 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
842 bytes.
843
e3601888
PE
844 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
845
db6c0e74
PE
846 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
847
dd5963ea
PE
848 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
849
88c9450f
PE
850 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
851
2f9442b8
PE
852 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
853
c032b5f8
PE
854 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
855 * charset.c (Fdefine_charset_internal): Don't initialize
856 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 857 32-bit int (Bug#8600).
a108c10b
PE
858
859 * lread.c (read_integer): Be more consistent with string-to-number.
860 Use string_to_number to do the actual conversion; this avoids
861 rounding errors and fixes some other screwups. Without this fix,
862 for example, #x1fffffffffffffff was misread as -2305843009213693952.
863 (digit_to_number): Move earlier, for benefit of read_integer.
864 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 865 not a digit in any supported base. (Bug#8602)
a108c10b 866
ad5f9eea
PE
867 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
868
aec1708a
PE
869 * dispnew.c (scrolling_window): Return 1 if we scrolled,
870 to match comment at start of function. This also removes a
871 GCC warning about overflow in a 32+64-bit port.
872
47be4ab5
PE
873 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
874
371cac43
PE
875 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
876 Reported by Stefan Monnier in
877 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
878 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
879 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 880
d01a7826
PE
881 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
882 (EMACS_UINTPTR): Likewise, with uintptr_t.
883
7fd47d5c
PE
884 * lisp.h: Prefer 64-bit EMACS_INT if available.
885 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
886 on 32-bit hosts that have 64-bit int, so that they can access
887 large files.
122b0c86
PE
888 However, temporarily disable this change unless the temporary
889 symbol WIDE_EMACS_INT is defined.
7fd47d5c 890
8727937b
PE
891 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
892
8ac068ac
PE
893 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
894 This removes an assumption that EMACS_INT and long are the same
895 width as pointers. The assumption is true for Emacs porting targets
896 now, but we want to make other targets possible.
897 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
898 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
899 In the rest of the code, change types of integers that hold casted
900 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
901 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
902 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
903 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
904 No need to cast type when ORing.
905 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
906 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
907 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
908 assume EMACS_INT is the same width as char *.
909 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
910 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
911 Remove no-longer-needed casts.
912 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
913 (xg_tool_bar_help_callback, xg_make_tool_item):
914 Use EMACS_INTPTR to hold an integer
915 that will be cast to void *; this can avoid a GCC warning
916 if EMACS_INT is not the same width as void *.
917 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
918 * xdisp.c (display_echo_area_1, resize_mini_window_1):
919 (current_message_1, set_message_1):
920 Use a local to convert to proper width without a cast.
921 * xmenu.c (dialog_selection_callback): Likewise.
922
ede49d71
PE
923 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
924 Also, don't assume VALBITS / RAND_BITS is less than 5,
925 and don't rely on undefined behavior when shifting a 1 left into
926 the sign bit.
927 * lisp.h (get_random): Change signature to match.
928
2f30ecd0
PE
929 * lread.c (hash_string): Use size_t, not int, for hash computation.
930 Normally we prefer signed values; but hashing is special, because
931 it's better to use unsigned division on hash table sizes so that
932 the remainder is nonnegative. Also, size_t is the natural width
933 for hashing into memory. The previous code used 'int', which doesn't
934 retain enough info to hash well into very large tables.
935 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
936
2a866e7b
PE
937 * dbusbind.c: Don't possibly lose pointer info when converting.
938 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
939 Use XPNTR rather than XHASH, so that the high-order bits of
940 the pointer aren't lost when converting through void *.
941
51639eac
PE
942 * eval.c (Fautoload): Don't double-shift a pointer.
943
92394119
PE
944 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
945
dbdb9a7c
JB
9462011-05-06 Juanma Barranquero <lekktu@gmail.com>
947
948 * gnutls.c (DEF_GNUTLS_FN):
949 * image.c (DEF_IMGLIB_FN): Make function pointers static.
950
db7a0b4f
AS
9512011-05-05 Andreas Schwab <schwab@linux-m68k.org>
952
953 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
954 marker. (Bug#8610)
955
f7ff1b0f 9562011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
957
958 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
959 New version that can reserve upto 2GB of heap space.
960
f7ff1b0f 9612011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
962
963 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
964
639c109b
TZ
9652011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
966
967 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
968 `gnutls_certificate_set_x509_key_file'.
969
d2127135
JB
9702011-05-05 Juanma Barranquero <lekktu@gmail.com>
971
972 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
973 Update dependencies.
974
e968f4f3
JB
9752011-05-04 Juanma Barranquero <lekktu@gmail.com>
976
977 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
978 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
979 Remove unused parameter `fildes'.
980 * process.c (read_process_output, send_process): Don't pass it.
981
84d358f0
JB
9822011-05-04 Juanma Barranquero <lekktu@gmail.com>
983
984 Fix previous change: the library cache is defined in w32.c.
985 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
986 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
987
0898ca10
JB
9882011-05-04 Juanma Barranquero <lekktu@gmail.com>
989
990 Implement dynamic loading of GnuTLS on Windows.
991
992 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
993 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
994 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
995 Declare.
996
997 * gnutls.c (Qgnutls_dll): Define.
998 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
999 (gnutls_*): Declare function pointers.
1000 (init_gnutls_functions): New function to initialize function pointers.
1001 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1002 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1003 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1004 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1005 (emacs_gnutls_write, emacs_gnutls_read)
1006 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1007 (Fgnutls_available_p): New function.
1008 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1009 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1010 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1011
1012 * image.c: Include w32.h.
1013 (Vimage_type_cache): Delete.
1014 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1015 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1016 (w32_delayed_load): Move to w32.c.
1017
1018 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1019
1020 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1021 (w32_delayed_load): Move from image.c. When loading a library, record
1022 its filename in the :loaded-from property of the library id.
1023 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1024 Initialize and staticpro them.
1025 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1026
1027 * process.c: Include lisp.h before w32.h, not after.
1028 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1029 instead of gnutls_record_check_pending.
1030
1031 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1032
ff4de4aa
TZ
10332011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1034
1035 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1036 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1037 as passed in.
1038
abe95abb
JD
10392011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1040
1041 * xterm.c (x_set_frame_alpha): Do not set property on anything
1042 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1043
e16e55d4
JB
10442011-05-02 Juanma Barranquero <lekktu@gmail.com>
1045
1046 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1047
bafcf6a5
JB
10482011-05-02 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1051 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1052 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1053 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1054 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1055 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1056 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1057 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1058 (Qgnutls_bootprop_callbacks_verify): Make static.
1059
e7a6747f
AS
10602011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1061
19ed11ba
AS
1062 * callproc.c: Indentation fixup.
1063
e7a6747f 1064 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1065 (wait_for_termination, interruptible_wait_for_termination):
1066 Move after wait_for_termination_1.
e7a6747f 1067
1ef14cb4
LMI
10682011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1069
1070 * sysdep.c (interruptible_wait_for_termination): New function
1071 which is like wait_for_termination, but allows keyboard
1072 interruptions.
1073
1074 * callproc.c (Fcall_process): Add (:file "file") as an option for
1075 the STDOUT buffer.
1076 (Fcall_process_region): Ditto.
1077
330d880c
EZ
10782011-04-30 Eli Zaretskii <eliz@gnu.org>
1079
8db90b73
EZ
1080 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1081 rather than `XVECTOR (FOO)->size'.
1082
330d880c
EZ
1083 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1084 inttypes.h, as a gnulib replacement is used if it not available in
1085 system headers.
1086
15cbd324
EZ
10872011-04-21 Eli Zaretskii <eliz@gnu.org>
1088
1089 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1090 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1091 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1092
1093 * coding.c (coding_alloc_by_realloc): Error out if destination
1094 will grow beyond MOST_POSITIVE_FIXNUM.
1095 (decode_coding_emacs_mule): Abort if there isn't enough place in
1096 charbuf for the composition carryover bytes. Reserve an extra
1097 space for up to 2 characters produced in a loop.
1098 (decode_coding_iso_2022): Abort if there isn't enough place in
1099 charbuf for the composition carryover bytes.
1100
11012011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1102
ae940cca
EZ
1103 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1104 aborting when %lld or %lll format is passed.
1105 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1106 %llo or %llx format is passed. (Bug#8545)
1107
03ab8921
EZ
1108 * window.c (window_scroll_line_based): Use a marker instead of
1109 simple variables to record original value of point. (Bug#7952)
1110
afda1437
EZ
1111 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1112 produced by %s or %c overflows available buffer space. (Bug#8545)
1113
f76dee0c
PE
11142011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1117 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1118
fdc5744d
JB
11192011-04-28 Juanma Barranquero <lekktu@gmail.com>
1120
1121 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1122
638f053a
JB
11232011-04-28 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * keyboard.c (Qdelayed_warnings_hook): Define.
1126 (command_loop_1): Run `delayed-warnings-hook'
1127 if Vdelayed_warnings_list is non-nil.
1128 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1129 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1130
d178f871
EZ
11312011-04-28 Eli Zaretskii <eliz@gnu.org>
1132
1133 * doprnt.c (doprnt): Don't return value smaller than the buffer
1134 size if the message was truncated. (Bug#8545).
1135
b124fd93
JB
11362011-04-28 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1139 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1140
e810457d
PE
11412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1144
ea51cceb
JB
11452011-04-27 Juanma Barranquero <lekktu@gmail.com>
1146
1147 * makefile.w32-in: Update dependencies.
1148
94dcfacf
EZ
11492011-04-27 Eli Zaretskii <eliz@gnu.org>
1150
1151 Improve `doprnt' and its usage. (Bug#8545)
1152 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1153 `format_end'. Remove support for %l as a conversion specifier.
1154 Don't use xrealloc. Improve diagnostics when the %l size modifier
1155 is used. Update the commentary.
1156
1157 * eval.c (verror): Simplify calculation of size_t.
1158
1159 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1160 messages.
1161
f61f41d7
PE
11622011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1163
1164 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1165 change.
1166
96fb4434
PE
11672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1170 This makes this file independent of the recent pseudovector change.
1171
671875da 11722011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1173
69e9b5a3
PE
1174 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1175
b5f869a7 1176 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1177 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1178 Remove unused local.
c8926152 1179 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1180
841a1577 1181 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1182 GCC 4.6.0 optimizes based on type-based alias analysis.
1183 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1184 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1185 != &v->size, and therefore "v->size = 1; b->size = 2; return
1186 v->size;" must therefore return 1. This assumption is incorrect
1187 for Emacs, since it type-puns struct Lisp_Vector * with many other
1188 types. To fix this problem, this patch adds a new type struct
f904488f 1189 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1190 and pseudovectors, and helps optimizing compilers not get fooled
1191 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1192 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1193 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1194 the size member.
eab3844f
PE
1195 (XSETPVECTYPE): Rewrite in terms of new macro.
1196 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1197 This is a bit clearer, and further avoids the possibility of
1198 undesirable aliasing.
1199 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1200 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1201 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1202 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1203 (ASIZE): Now uses header.size rather than size.
1204 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1205 to avoid the hassle of writing XVECTOR (foo)->header.size.
1206 (struct vectorlike_header): New type.
eab3844f
PE
1207 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1208 object, to help avoid aliasing.
1209 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1210 (SUBRP): Likewise, since Lisp_Subr is a special case.
1211 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1212 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1213 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1214 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1215 changed to be "header.size" and "header.next".
1216 * buffer.h (struct buffer): Likewise.
1217 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1218 * frame.h (struct frame): Likewise.
1219 * process.h (struct Lisp_Process): Likewise.
1220 * termhooks.h (struct terminal): Likewise.
1221 * window.c (struct save_window_data, struct saved_window): Likewise.
1222 * window.h (struct window): Likewise.
1223 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1224 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1225 * buffer.c (init_buffer_once): Likewise.
1226 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1227 special case.
1228 * process.c (Fformat_network_address): Use local var for size,
1229 for brevity.
1230
0df1eac5
PE
1231 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1232
847ab9d1 1233 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1234 * data.c (atof): Remove decl; no longer used or needed.
1235 (digit_to_number): Move to lread.c.
1236 (Fstring_to_number): Use new string_to_number function, to be
1237 consistent with how the Lisp reader treats infinities and NaNs.
1238 Do not assume that floating-point numbers represent EMACS_INT
1239 without losing information; this is not true on most 64-bit hosts.
1240 Avoid double-rounding errors, by insisting on integers when
1241 parsing non-base-10 numbers, as the documentation specifies.
1242 * lisp.h (string_to_number): New decl, replacing ...
1243 (isfloat_string): Remove.
bc0a5c13 1244 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1245 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1246 appears to have been a coding error. Similarly, do not accept
1247 strings like +-1e0 as floating point numbers. Do not report
1248 overflow for integer overflows unless the base is not 10 which
1249 means we have no simple and reliable way to continue.
1250 Break out the floating-point parsing into a new
1251 function string_to_number, so that Fstring_to_number parses
1252 floating point numbers consistently with the Lisp reader.
04f2d78b 1253 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1254 (E_CHAR, EXP_INT): Remove, replacing with ...
1255 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1256 (string_to_number): New function, replacing isfloat_string.
1257 This function checks for valid syntax and produces the resulting
1258 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1259 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1260 so that overflow for non-base-10 numbers is reported only when
1261 there's no portable and simple way to convert to floating point.
452f4150 1262
67769ffc
PE
1263 * textprop.c (set_text_properties_1): Rewrite for clarity,
1264 and to avoid GCC warning about integer overflow.
1265
c20db43f
PE
1266 * intervals.h (struct interval): Use EMACS_INT for members
1267 where EMACS_UINT might cause problems. See
1268 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1269 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1270 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1271 All uses changed.
37aa2f85
PE
1272 (offset_intervals): Tell GCC not to worry about length overflow
1273 when negating a negative length.
c20db43f 1274
2538aa2f
PE
1275 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1276 (overrun_check_free): Likewise.
1277
f2d3008d
PE
1278 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1279 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1280 word size.
1281
ec8df744
PE
1282 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1283 (gnutls_make_error): Rename local to avoid shadowing.
1284 (gnutls_emacs_global_deinit): ifdef out; not used.
1285 (Fgnutls_boot): Use const for pointer to readonly storage.
1286 Comment out unused local. Fix pointer signedness problems.
1287
640ee02d
PE
1288 * lread.c (openp): Don't stuff size_t into an 'int'.
1289 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1290 about possible signed overflow.
1291
6048fb2a
PE
1292 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1293 (GDK_KEY_g): Don't define if already defined.
1294 (xg_prepare_tooltip): Avoid pointer signedness problem.
1295 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1296
fa3c87e1
PE
1297 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1298 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1299
2172544b
PE
1300 * xfns.c (Fx_window_property): Simplify a bit,
1301 to make a bit faster and to avoid GCC 4.6.0 warning.
1302 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1303
9b821a21
PE
1304 * fns.c (internal_equal): Don't assume size_t fits in int.
1305
3c616cfa
PE
1306 * alloc.c (compact_small_strings): Tighten assertion a little.
1307
c2982e87
PE
1308 Replace pEd with more-general pI, and fix some printf arg casts.
1309 * lisp.h (pI): New macro, generalizing old pEd macro to other
1310 conversion specifiers. For example, use "...%"pI"d..." rather
1311 than "...%"pEd"...".
1312 (pEd): Remove. All uses replaced with similar uses of pI.
1313 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1314 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1315 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1316 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1317 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1318 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1319 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1320 64-bit hosts.
1321 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1322 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1323 * print.c (safe_debug_print, print_object): Likewise.
1324 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1325 to int.
6f04d126
PE
1326 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1327 avoiding the 0 flag, which is not portable.
c2982e87
PE
1328 * process.c (Fmake_network_process): Use pI to avoid cast.
1329 * region-cache.c (pp_cache): Likewise.
1330 * xdisp.c (decode_mode_spec): Likewise.
1331 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1332 behavior on 64-bit hosts with printf arg.
6f04d126 1333 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1334 (x_stop_queuing_selection_requests): Likewise.
1335 (x_get_window_property): Don't truncate byte count to an 'int'
1336 when tracing.
0b432f21 1337
5e073ec7
PE
1338 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1339 here, since it parses constructs like leading '-' and spaces,
1340 which are not wanted; and it overflows with large numbers.
1341 Instead, simply match F[0-9]+, which is what is wanted anyway.
1342
36372bf9
PE
1343 * alloc.c: Remove unportable assumptions about struct layout.
1344 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1345 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1346 (allocate_vectorlike, make_pure_vector): Use the new macros,
1347 plus offsetof, to remove unportable assumptions about struct layout.
1348 These assumptions hold on all porting targets that I know of, but
1349 they are not guaranteed, they're easy to remove, and removing them
1350 makes further changes easier.
1351
0b432f21
PE
1352 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1353 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1354 (string_overrun_cookie): Now const. Use initializers that
1355 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1356 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1357 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1358 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1359 multiple of sizeof (EMACS_INT); it need not be, if
1360 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1361 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1362
895009e1
JB
13632011-04-26 Juanma Barranquero <lekktu@gmail.com>
1364
1365 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1366
6a7a1b0b
TZ
13672011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1368
1369 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1370 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1371 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1372
841a1577 13732011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1374
1375 * lisp.h (Qdebug): List symbol.
895009e1 1376 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1377 * keyboard.c (debug-on-event): New variable.
1378 (handle_user_signal): Break into debugger when debug-on-event
1379 matches the current signal symbol.
1380
f2d3ba6f
DN
13812011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1382
1383 * alloc.c (check_sblock, check_string_bytes)
1384 (check_string_free_list): Convert to standard C.
1385
42ce4c63
TZ
13862011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1387
1388 * w32.c (emacs_gnutls_push): Fix typo.
1389
825cd63c
EZ
13902011-04-25 Eli Zaretskii <eliz@gnu.org>
1391
fb11d64d
EZ
1392 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1393 "cast to pointer from integer of different size".
1394
825cd63c
EZ
1395 Improve doprnt and its use in verror. (Bug#8545)
1396 * doprnt.c (doprnt): Document the set of format control sequences
1397 supported by the function. Use SAFE_ALLOCA instead of always
1398 using `alloca'.
1399
1400 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1401 is one byte too soon. Don't use xrealloc; instead xfree and
1402 xmalloc anew.
1403
e061a11b
TZ
14042011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1405
1406 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1407 callbacks stage.
1408
1409 * gnutls.c: Renamed global_initialized to
1410 gnutls_global_initialized. Added internals for the
1411 :verify-hostname-error, :verify-error, and :verify-flags
1412 parameters of `gnutls-boot' and documented those parameters in the
1413 docstring. Start callback support.
1414 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1415 unless a fatal error occured. Call gnutls_alert_send_appropriate
1416 on error. Return error code.
1417 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1418 (emacs_gnutls_read): Likewise.
1419 (Fgnutls_boot): Return handshake error code.
1420 (emacs_gnutls_handle_error): New function.
1421 (wsaerror_to_errno): Likewise.
1422
1423 * w32.h (emacs_gnutls_pull): Add prototype.
1424 (emacs_gnutls_push): Likewise.
1425
1426 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1427 (emacs_gnutls_push): Likewise.
1428
14292011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1430
1431 * process.c (wait_reading_process_output): Check if GnuTLS
1432 buffered some data internally if no FDs are set for TLS
1433 connections.
1434
1435 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1436 (LIBS): Link to USER_LIBS.
1437 ($(BLD)/gnutls.$(0)): New target.
1438
fa6996bc
EZ
14392011-04-24 Eli Zaretskii <eliz@gnu.org>
1440
eb35682e
EZ
1441 * xdisp.c (handle_single_display_spec): Rename the
1442 display_replaced_before_p argument into display_replaced_p, to
1443 make it consistent with the commentary. Fix typos in the
1444 commentary.
1445
e2ad650c
EZ
1446 * textprop.c (syms_of_textprop): Remove dead code.
1447 (copy_text_properties): Delete obsolete commentary about an
1448 interface that was deleted long ago. Fix typos in the description
1449 of arguments.
1450
1b2de274
EZ
1451 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1452 to changes in oldXMenu/XMenu.h from 2011-04-16.
1453 <menu_help_message, prev_menu_help_message>: Constify.
1454 (IT_menu_make_room): menu->help_text is now `const char **';
1455 adjust.
1456
1457 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1458 to changes in oldXMenu/XMenu.h from 2011-04-16.
1459 (struct XMenu): Declare `help_text' `const char **'.
1460
1461 * xfaces.c <Qunspecified>: Make extern again.
1462
1463 * syntax.c: Include sys/types.h before including regex.h, as
1464 required by Posix.
1465
762b15be
EZ
1466 * doc.c (get_doc_string): Improve the format passed to `error'.
1467
1468 * doprnt.c (doprnt): Improve commentary.
1469
1470 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1471
1472 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1473 them with etags.
1474
f1052e5d
EZ
1475 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1476 changes in globals.h immediately force recompilation.
762b15be
EZ
1477 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1478 $(CURDIR)/s/ms-w32.h.
1479 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1480
fa6996bc
EZ
1481 * character.c (Fchar_direction): Function deleted.
1482 (syms_of_character): Don't defsubr it.
1483 <char-direction-table>: Deleted.
1484
e6c3da20
EZ
14852011-04-23 Eli Zaretskii <eliz@gnu.org>
1486
1487 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1488 * doprnt.c: Include limits.h.
1489 (SIZE_MAX): New macro.
04f2d78b
CB
1490 (doprnt): Return a size_t value. 2nd arg is now size_t.
1491 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1492 Improve overflow protection. Support `l' modifier for integer
1493 conversions. Support %l conversion. Don't assume an EMACS_INT
1494 argument for integer conversions and for %c.
1495
1496 * lisp.h (doprnt): Restore prototype.
1497
1498 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1499 $(SRC)/character.h.
1500
1501 * Makefile.in (base_obj): Add back doprnt.o.
1502
1503 * deps.mk (doprnt.o): Add back prerequisites.
1504 (callint.o): Depend on character.h.
1505
1506 * eval.c (internal_lisp_condition_case): Include the handler
1507 representation in the error message.
1508 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1509 when breaking from the loop.
1510
1511 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1512
1513 * callint.c (Fcall_interactively): When displaying error message
1514 about invalid control letter, pass the character's codepoint, not
1515 a pointer to its multibyte form. Improve display of the character
1516 in octal and display also its hex code.
1517
1518 * character.c (char_string): Use %x to display the (unsigned)
1519 codepoint of an invalid character, to avoid displaying a bogus
1520 negative value.
1521
1522 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1523 `error', not SYMBOL_NAME itself.
1524
1525 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1526 character arguments to `error'.
1527
1528 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1529 to `error' in error message about FINAL_CHAR argument. Make sure
1530 FINAL_CHAR is a character, and use %c when it is passed as
1531 argument to `error'.
1532
4ffd0d6b 15332011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1534
1535 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1536
1537 * w32.c: Include <time.h>.
1538 (sys_localtime): New function.
1539
4ffd0d6b 15402011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1541
1542 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1543
4ffd0d6b 1544 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1545
4ffd0d6b 15462011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1547
4ffd0d6b
GM
1548 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1549 zombies (Bug#8467).
aac0c6e3 1550
04c56954
EZ
15512011-04-19 Eli Zaretskii <eliz@gnu.org>
1552
1553 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1554 gl_state.e_property when gl_state.object is Qt.
1555
1556 * insdel.c (make_gap_larger): Remove limitation of buffer size
1557 to <= INT_MAX.
1558
16a43933
CY
15592011-04-18 Chong Yidong <cyd@stupidchicken.com>
1560
1561 * xdisp.c (lookup_glyphless_char_display)
1562 (produce_glyphless_glyph): Handle cons cell entry in
1563 glyphless-char-display.
1564 (Vglyphless_char_display): Document it.
1565
1566 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1567 glyphless-char-display.
1568
4581706e
CY
15692011-04-17 Chong Yidong <cyd@stupidchicken.com>
1570
1571 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1572
1573 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1574
1575 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1576 definition for no-X builds.
1577
4887c6e2 15782011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1579
fd35b6f9
PE
1580 Static checks with GCC 4.6.0 and non-default toolkits.
1581
5c1ccb01
PE
1582 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1583
006c5daa
PE
1584 * process.c (keyboard_bit_set): Define only if SIGIO.
1585 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1586 (send_process): Repair possible setjmp clobbering.
1587
efc736d3
PE
1588 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1589
4e2fe2e6
PE
1590 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1591
f97334a2
PE
1592 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1593
4e75f29d
PE
1594 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1595 Define only if needed.
1596
90efadd1
PE
1597 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1598 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1599 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1600
3c647824
PE
1601 * dispextern.h (struct redisplay_interface): Rename param
1602 to avoid shadowing.
e264f262 1603 * termhooks.h (struct terminal): Likewise.
761383f4 1604 * xterm.c (xembed_send_message): Likewise.
3c647824 1605
b58c5c4a
PE
1606 * insdel.c (make_gap_smaller): Define only if
1607 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1608
cad59032
PE
1609 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1610 it.
1611
c339dc2e
PE
1612 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1613 so that we aren't warned about unused symbols.
1614
91a3e27b
PE
1615 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1616
399c71d3 1617 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1618
8ffc96f5
PE
1619 * xfns.c (x_real_positions): Mark locals as initialized.
1620
eef9bc79
PE
1621 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1622
098db9dd
PE
1623 * xterm.c: Fix problems found by static analysis with other toolkits.
1624 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1625 (x_dispatch_event): Declare static if USE_GTK, and
1626 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1627 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1628 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1629 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1630 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1631
eb18f6cc
PE
1632 * xmenu.c (menu_help_callback): Pointer type fixes.
1633 Use const pointers when pointing at readonly data. Avoid pointer
1634 signedness clashes.
1635 (FALSE): Remove unused macro.
1636 (update_frame_menubar): Remove unused decl.
1637
1fe72bf8
PE
1638 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1639
60d9e1db
PE
1640 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1641 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1642 (single_menu_item): Rename local to avoid shadowing.
1643
39261c26
PE
1644 * keyboard.c (make_lispy_event): Remove unused local var.
1645
018c5e19
PE
1646 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1647 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1648
63d2b86e
PE
1649 * bitmaps: Change bitmaps from unsigned char back to the X11
1650 compatible char. Avoid the old compiler warnings about
1651 out-of-range initializers by using, for example, '\xab' rather
1652 than 0xab.
1653
aefd87e1
PE
1654 * xgselect.c (xgselect_initialize): Check vs interface
1655 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1656
bf501fb9
PE
1657 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1658
e9829fdf
PE
1659 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1660 to read-only memory.
1661
1086c095
PE
1662 * fns.c (vector): Remove; this old hack is no longer needed.
1663
2baccd04 1664 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1665 Remove unused var.
dde42981 1666 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1667
72391843 1668 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1669
436c16df 1670 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1671 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1672 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1673
92bb796d 1674 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1675 (x_term_init): Remove local to avoid shadowing.
92bb796d 1676
764430a3 1677 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1678
1679 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1680 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1681
d1dfb56c
EZ
16822011-04-16 Eli Zaretskii <eliz@gnu.org>
1683
c4354cb4
EZ
1684 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1685
d1dfb56c
EZ
1686 Fix regex.c, syntax.c and friends for buffers > 2GB.
1687 * syntax.h (struct gl_state_s): Declare character position members
1688 EMACS_INT.
1689
1690 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1691
04f2d78b
CB
1692 * textprop.c (verify_interval_modification, interval_of):
1693 Declare arguments EMACS_INT.
d1dfb56c
EZ
1694
1695 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1696 EMACS_INT.
1697
1698 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1699
1700 * indent.c (Fvertical_motion): Local variable it_start is now
1701 EMACS_INT.
1702
1703 * regex.c (re_match, re_match_2, re_match_2_internal)
1704 (bcmp_translate, regcomp, regexec, print_double_string)
1705 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1706 (re_compile_pattern, re_exec): Declare arguments and local
1707 variables `size_t' and `ssize_t' and return values `regoff_t', as
1708 appropriate.
1709 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1710 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1711 <compile_stack_type>: `size' and `avail' are now `size_t'.
1712
1713 * regex.h <regoff_t>: Use ssize_t, not int.
1714 (re_search, re_search_2, re_match, re_match_2): Arguments that
1715 specify buffer/string position and length are now ssize_t and
1716 size_t. Return type is regoff_t.
1717
613052cd
BK
17182011-04-16 Ben Key <bkey76@gmail.com>
1719
1720 * nsfont.m: Fixed bugs in ns_get_family and
1721 ns_descriptor_to_entity that were caused by using free to
1722 deallocate memory blocks that were allocated by xmalloc (via
1723 xstrdup). This caused Emacs to crash when compiled with
1724 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1725 --enable-checking=xmallocoverrun). xfree is now used to
1726 deallocate these memory blocks.
1727
4170f62f 17282011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1729
71b41406
PE
1730 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1731
9587a89d
PE
1732 emacs_write: Accept and return EMACS_INT for sizes.
1733 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1734 et seq.
1735 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1736 Accept and return EMACS_INT.
1737 (emacs_gnutls_write): Return the number of bytes written on
1738 partial writes.
1739 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1740 (emacs_read, emacs_write): Remove check for negative size, as the
1741 Emacs source code has been audited now.
9587a89d
PE
1742 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1743 (emacs_read, emacs_write): Use it.
273a5f82
PE
1744 * process.c (send_process): Adjust to the new signatures of
1745 emacs_write and emacs_gnutls_write. Do not attempt to store
1746 a byte offset into an 'int'; it might overflow.
9587a89d 1747 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1748
3e047f51
PE
1749 * sound.c: Don't assume sizes fit in 'int'.
1750 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1751 Return EMACS_INT, not int.
3e047f51 1752 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1753 Accept EMACS_INT, not int.
1754 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1755 record read return values.
1756
cc39a9db
BK
17572011-04-15 Ben Key <bkey76@gmail.com>
1758
c9d0ec6d
JB
1759 * keyboard.c (Qundefined): Don't declare static since it is used
1760 in nsfns.m.
1761 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1762 static since they are used in nsfont.m.
cc39a9db 1763
6c60eb9f
SM
17642011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1765
1766 * process.c (Qprocessp): Don't declare static.
1767 * lisp.h (Qprocessp): Declare again.
1768
7990b61a
JB
17692011-04-15 Juanma Barranquero <lekktu@gmail.com>
1770
1771 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1772
5d4cb038
PE
17732011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1774
8bd7b830 1775 Improve C-level modularity by making more things 'static'.
cd64ea1d 1776
e3b27b31
PE
1777 Don't publish debugger-only interfaces to other modules.
1778 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1779 (verify_bytepos, count_markers): Move decls to the only modules
1780 that need them.
1781 * region-cache.h (pp_cache): Likewise.
1782 * window.h (check_all_windows): Likewise.
1783 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1784
5d4cb038
PE
1785 * sysdep.c (croak): Now static, if
1786 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1787 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1788
1789 * alloc.c (refill_memory_reserve): Now static if
1790 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1791 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1792
e87b6180
PE
1793 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1794 Define only if USE_LUCID.
1795
ac64929e
PE
1796 * xrdb.c (x_customization_string, x_rm_string): Now static.
1797
6f37259d
PE
1798 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1799 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1800
1683e3ab
PE
1801 * xdisp.c (draw_row_with_mouse_face): Now static.
1802 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1803
de9c2632
PE
1804 * window.h (check_all_windows): Mark externally visible.
1805
2b96acb7
PE
1806 * window.c (window_deletion_count): Now static.
1807
1808 * undo.c: Make symbols static if they're not exported.
1809 (last_undo_buffer, last_boundary_position, pending_boundary):
1810 Now static.
1811
50436f33
PE
1812 * textprop.c (interval_insert_behind_hooks): Now static.
1813 (interval_insert_in_front_hooks): Likewise.
1814
64520e5c
PE
1815 * term.c: Make symbols static if they're not exported.
1816 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1817 (max_frame_lines, tty_set_terminal_modes):
1818 (tty_reset_terminal_modes, tty_turn_off_highlight):
1819 (get_tty_terminal): Now static.
1820 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1821 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1822 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1823 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1824 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1825
1fa53021
PE
1826 * sysdep.c: Make symbols static if they're not exported.
1827 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1828 Now static.
1829 (sigprocmask_set, full_mask): Remove; unused.
1830 (wait_debugging): Mark as visible.
1831 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1832 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1833
d4b43b22
PE
1834 * syntax.c (syntax_temp): Define only if !__GNUC__.
1835
b7c513d0
PE
1836 * sound.c (current_sound_device, current_sound): Now static.
1837
989b29ad
PE
1838 * search.c (searchbufs, searchbuf_head): Now static.
1839
13a55a78
PE
1840 * scroll.c (scroll_cost): Remove; unused.
1841 * dispextern.h (scroll_cost): Remove decl.
1842
de68a1fc
PE
1843 * region-cache.h (pp_cache): Mark as externally visible.
1844
40ccffa6
PE
1845 * process.c: Make symbols static if they're not exported.
1846 (process_tick, update_tick, create_process, chan_process):
1847 (Vprocess_alist, proc_buffered_char, datagram_access):
1848 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1849 (deactivate_process): Mark defn as static, as well as decl.
1850 * lisp.h (create_process): Remove decl.
1851 * process.h (chan_process, Vprocess_alist): Remove decls.
1852
ad64fc97
PE
1853 * print.c: Make symbols static if they're not exported.
1854 (print_depth, new_backquote_output, being_printed, print_buffer):
1855 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1856 (print_interval, print_number_index, initial_stderr_stream):
1857 Now static.
1858 * lisp.h (Fprinc): Remove decl.
1859 (debug_output_compilation_hack): Mark as externally visible.
1860
adddb265
PE
1861 * sysdep.c (croak): Move decl from here to syssignal.h.
1862 * syssignal.h (croak): Put it here, so the API can be checked when
1863 'croak' is called from dissociate_if_controlling_tty.
1864
1717ede2
PE
1865 * minibuf.c: Make symbols static if they're not exported.
1866 (minibuf_save_list, choose_minibuf_frame): Now static.
1867 * lisp.h (choose_minibuf_frame): Remove decl.
1868
fa5fb2bc
PE
1869 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1870
1e3890d1
PE
1871 * lread.c: Make symbols static if they're not exported.
1872 (read_objects, initial_obarray, oblookup_last_bucket_number):
1873 Now static.
1874 (make_symbol): Remove; unused.
1875 * lisp.h (initial_obarray, make_symbol): Remove decls.
1876
8a1414fa
PE
1877 * keyboard.c: Make symbols static if they're not exported.
1878 (single_kboard, recent_keys_index, total_keys, recent_keys):
1879 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1880 (this_single_command_key_start, echoing, last_auto_save):
1881 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1882 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1883 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1884 (Vlispy_mouse_stem, double_click_count):
1885 Now static.
1886 (force_auto_save_soon): Define only if SIGDANGER.
1887 (ignore_mouse_drag_p): Now static if
1888 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1889 (print_help): Remove; unused.
1890 (stop_character, last_timer_event): Mark as externally visible.
1891 * keyboard.h (ignore_mouse_drag_p): Declare only if
1892 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1893 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1894 * lisp.h (echoing): Remove decl.
1895 (force_auto_save_soon): Declare only if SIGDANGER.
1896 * xdisp.c (redisplay_window): Simplify code, to make it more
1897 obvious that ignore_mouse_drag_p is not accessed if !defined
1898 USE_GTK && !defined HAVE_NS.
1899
93ea6e8f
PE
1900 * intervals.c: Make symbols static if they're not exported.
1901 (merge_properties_sticky, merge_interval_right, delete_interval):
1902 Now static.
1903 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1904
77382fcc
PE
1905 * insdel.c: Make symbols static if they're not exported.
1906 However, leave prepare_to_modify_buffer alone. It's never
1907 called from outside this function, but that appears to be a bug.
1908 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1909 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1910 (adjust_after_replace_noundo): Remove; unused.
1911 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1912 (signal_before_change): Remove decls.
77382fcc 1913
9306c32e
PE
1914 * indent.c (val_compute_motion, val_vmotion): Now static.
1915
cd44d2eb
PE
1916 * image.c: Make symbols static if they're not exported.
1917 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1918 if USE_GTK.
1919 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1920 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1921
ad9a7a06
PE
1922 * fringe.c (standard_bitmaps): Now static.
1923 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1924
81626931
PE
1925 * frame.c: Make symbols static if they're not exported.
1926 (x_report_frame_params, make_terminal_frame): Now static.
1927 (get_frame_param): Now static, unless HAVE_NS.
1928 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1929 (x_get_resource_string): Remove; not used.
1930 * frame.h (make_terminal_frame, x_report_frame_params):
1931 (x_get_resource_string); Remove decls.
1932 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1933 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1934
239f9db9
PE
1935 * font.c, fontset.c: Make symbols static if they're not exported.
1936 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1937 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1938 * font.c (font_close_object): Now static.
1939 * font.h (font_close_object): Remove.
1940 * fontset.c (FONTSET_OBJLIST): Remove.
1941 (free_realized_fontset) #if-0 the body, which does nothing.
1942 (face_suitable_for_char_p): #if-0, as it's never called.
1943 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1944 * xfaces.c (face_at_string_position):
1945 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1946 since 0 is always ASCII.
1947
dfcf3579
PE
1948 * fns.c (weak_hash_tables): Now static.
1949
5045092b
PE
1950 * fileio.c: Make symbols static if they're not exported.
1951 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1952 (Vwrite_region_annotation_buffers): Now static.
1953
57a96f5c
PE
1954 * eval.c: Make symbols static if they're not exported.
1955 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1956 * lisp.h (backtrace_list): Remove decl.
1957
35f08c38
PE
1958 * emacs.c: Make symbols static if they're not exported.
1959 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1960 (fatal_error_code, fatal_error_signal_hook, standard_args):
1961 Now static.
1962 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1963 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1964 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1965 * lisp.h (fatal_error_signal_hook): Remove decl.
1966 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1967
f44bd759
PE
1968 * editfns.c: Move a (normally-unused) function to its only use.
1969 * editfns.c, lisp.h (get_operating_system_release): Remove.
1970 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1971 worth the hassle of breaking this out.
1972
b532497d
PE
1973 * xterm.c: Make symbols static if they're not exported.
1974 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1975 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1976 (x_destroy_window, x_delete_display):
1977 Now static.
1978 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1979 (x_mouse_leave): Remove; unused.
1980 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1981 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1982 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1983 Remove decls.
1984 (x_mouse_leave): Declare only if WINDOWSNT.
1985 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1986 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1987 USE_X_TOOLKIT.
1988
1675728f
PE
1989 * ftxfont.c: Make symbols static if they're not exported.
1990 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1991 HAVE_FREETYPE.
1992 * font.h (ftxfont_driver): Likewise.
1993
e4cebfca
PE
1994 * xfns.c: Make symbols static if they're not exported.
1995 (x_last_font_name, x_display_info_for_name):
1996 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1997 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1998 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1999 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2000 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2001 (last_show_tip_args): Now static.
2002 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2003 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2004 (x_screen_planes): Remove; unused.
2005 * dispextern.h (x_screen_planes): Remove decl.
2006
5bf46f05
PE
2007 * dispnew.c: Make symbols static if they're not exported.
2008 * dispextern.h (redraw_garbaged_frames, scrolling):
2009 (increment_row_positions): Remove.
2010 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2011 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2012 Now static.
2013 (redraw_garbaged_frames): Remove; unused.
2014
435f4c28
PE
2015 * xfaces.c: Make symbols static if they're not exported.
2016 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2017 Remove decls.
2018 * xterm.h (defined_color): Remove decls.
2019 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2020 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2021 (menu_face_changed_default, defined_color, free_realized_face):
2022 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2023 (ascii_face_of_lisp_face): Remove; unused.
2024
8524aef3
PE
2025 * xdisp.c: Make symbols static if they're not exported.
2026 * dispextern.h (scratch_glyph_row, window_box_edges):
2027 (glyph_to_pixel_coords, set_cursor_from_row):
2028 (get_next_display_element, set_iterator_to_next):
2029 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2030 (show_mouse_face): Remove decls
2031 * frame.h (message_buf_print): Likewise.
2032 * lisp.h (pop_message, set_message, check_point_in_composition):
2033 Likewise.
2034 * xterm.h (set_vertical_scroll_bar): Likewise.
2035 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2036 (message_buf_print, scratch_glyph_row, displayed_buffer):
2037 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2038 (get_next_display_element, show_mouse_face, window_box_edges):
2039 (frame_to_window_pixel_xy, check_point_in_composition):
2040 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2041 (glyph_to_pixel_coords): Remove; unused.
2042
16390cd2
PE
2043 * dired.c (file_name_completion): Now static.
2044
2045 * dbusbind.c (xd_in_read_queued_messages): Now static.
2046
a25f4dfa
PE
2047 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2048 * data.c (circular_list_error): Remove.
2049
14a9c8df
PE
2050 * commands.h (last_point_position, last_point_position_buffer):
2051 (last_point_position_window): Remove decls.
2052 * keyboard.c: Make these variables static.
2053
04f2d78b
CB
2054 * coding.h (coding, code_convert_region, encode_coding_gap):
2055 Remove decls.
74ab6df5
PE
2056 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2057 (iso_code_class, detect_coding, code_convert_region): Now static.
2058 (encode_coding_gap): Remove; unused.
2059
38dfbee1
PE
2060 * chartab.c (chartab_chars, chartab_bits): Now static.
2061
a2cb4e63
PE
2062 * charset.h (charset_iso_8859_1): Remove decl.
2063 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2064 Now static.
2065
127198fd
PE
2066 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2067 * ccl.c (Vccl_program_table): Now static.
2068 (check_ccl_update): Remove; unused.
2069
d85b608f
PE
2070 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2071 * category.h: ... from here.
2072 * category.c (check_category_table, set_category_set): Now static.
2073
31cd66f3
PE
2074 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2075 * lisp.h: Remove these decls.
2076
c358e587
PE
2077 * buffer.c (buffer_count): Remove unused var.
2078
e78aecca
PE
2079 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2080 so that it's not optimized away.
2081 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2082 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2083 exported only to the debugger.
2084
e192d7d3 2085 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2086 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2087
92470028
PE
2088 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2089 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2090 was inaccessible from Lisp.
2091 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2092 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2093
244ed907
PE
2094 alloc.c: Import and export fewer symbols, and remove unused items.
2095 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2096 is defined.
2097 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2098 it's not optimized away by whole-program optimization.
2099 (message_enable_multibyte, free_misc): Remove.
2100 (catchlist, handlerlist, mark_backtrace):
2101 Declare only if BYTE_MARK_STACK.
2102 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2103 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2104 (message_enable_multibyte): Remove decl.
2105 (free_misc, interval_free_list, float_block, float_block_index):
2106 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2107 (cons_free_list, last_marked_index):
2108 Now static.
2109 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2110 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2111 (mark_backtrace): Define only if BYTE_MARK_STACK.
2112 * xdisp.c (message_enable_multibyte): Now static.
2113
61c2b50e 2114 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2115 This makes it easier for human readers (and static analyzers)
2116 to see whether these variables are used from other modules.
2117 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2118 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2119 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2120 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2121 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2122 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2123 * xmenu.c, xselect.c:
2124 Declare Q* vars static if they are not used in other modules.
2125 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2126 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2127 Remove decls of unexported vars.
2128 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2129
95c82688
PE
2130 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2131
16a97296
PE
2132 Make Emacs functions such as Fatom 'static' by default.
2133 This makes it easier for human readers (and static analyzers)
2134 to see whether these functions can be called from other modules.
2135 DEFUN now defines a static function. To make the function external
2136 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2137 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2138 (Finit_image_library):
16a97296
PE
2139 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2140 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2141 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2142 Remove decls, since these functions are now static.
2143 (Funintern, Fget_internal_run_time): New decls, since these functions
2144 were already external.
95c82688 2145
16a97296
PE
2146 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2147 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2148 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2149 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2150 * keyboard.c, keymap.c, lread.c:
2151 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2152 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2153 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2154 Mark functions with DEFUE instead of DEFUN,
2155 if they are used in other modules.
2156 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2157 decls for now-static functions.
2158 * buffer.h (Fdelete_overlay): Remove decl.
2159 * callproc.c (Fgetenv_internal): Mark as internal.
2160 * composite.c (Fremove_list_of_text_properties): Remove decl.
2161 (Fcomposition_get_gstring): New forward static decl.
2162 * composite.h (Fcomposite_get_gstring): Remove decl.
2163 * dired.c (Ffile_attributes): New forward static decl.
2164 * doc.c (Fdocumntation_property): New forward static decl.
2165 * eval.c (Ffetch_bytecode): New forward static decl.
2166 (Funintern): Remove extern decl; now in .h file where it belongs.
2167 * fileio.c (Fmake_symbolic_link): New forward static decl.
2168 * image.c (Finit_image_library): New forward static decl.
2169 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2170 * intervals.h (Fprevious_property_change):
2171 (Fremove_list_of_text_properties): Remove decls.
2172 * keyboard.c (Fthis_command_keys): Remove decl.
2173 (Fcommand_execute): New forward static decl.
2174 * keymap.c (Flookup_key): New forward static decl.
2175 (Fcopy_keymap): Now static.
2176 * keymap.h (Flookup_key): Remove decl.
2177 * process.c (Fget_process): New forward static decl.
2178 (Fprocess_datagram_address): Mark as internal.
2179 * syntax.c (Fsyntax_table_p): New forward static decl.
2180 (skip_chars): Remove duplicate decl.
2181 * textprop.c (Fprevious_property_change): New forward static decl.
2182 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2183 Now internal.
2184 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2185 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2186
785bbd42
PE
2187 * editfns.c (Fformat): Remove unreachable code.
2188
8b913b57
AS
21892011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2190
2191 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2192 change. (Bug#8496)
2193
a6744a35
EZ
21942011-04-13 Eli Zaretskii <eliz@gnu.org>
2195
2196 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2197 when at ZV. (Bug#8487)
2198
e7974947
AS
21992011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2200
baad03f0
AS
2201 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2202 (Bug#8437)
2203 * keyboard.c (parse_tool_bar_item): Likewise.
2204 * sound.c (sound_cleanup, alsa_close): Likewise.
2205 * termcap.c (tgetent): Likewise.
2206 * xfns.c (x_default_font_parameter): Likewise.
2207 * xsettings.c (read_and_apply_settings): Likewise.
2208
e7974947
AS
2209 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2210 (overrun_check_free): Protoize.
2211
28272684
PE
22122011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2215 since callers should never pass a negative size.
2216 Change the signature to match that of plain 'read' and 'write'; see
2217 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2218 * lisp.h: Update prototypes of emacs_write and emacs_read.
2219
11997c76
EZ
22202011-04-11 Eli Zaretskii <eliz@gnu.org>
2221
2222 * xdisp.c (redisplay_window): Don't try to determine the character
2223 position of the scroll margin if the window start point w->startp
e896f03c 2224 is outside the buffer's accessible region. (Bug#8468)
11997c76 2225
8a2cbd72
EZ
22262011-04-10 Eli Zaretskii <eliz@gnu.org>
2227
2228 Fix write-region and its subroutines for buffers > 2GB.
2229 * fileio.c (a_write, e_write): Modify declaration of arguments and
2230 local variables to support buffers larger than 2GB.
2231 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2232
2233 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2234 argument, local variables, and return value.
2235
2236 * lisp.h: Update prototypes of emacs_write and emacs_read.
2237
2238 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2239
4073e537 22402011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2241
1ebfdcb6
PE
2242 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2243
b2ded58d
PE
2244 Fix more problems found by GCC 4.6.0's static checks.
2245
7d66342c
PE
2246 * xdisp.c (vmessage): Use a better test for character truncation.
2247
bbf47d44
PE
2248 * charset.c (load_charset_map): <, not <=, for optimization,
2249 and to avoid potential problems with integer overflow.
9248994d 2250 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2251 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2252 * editfns.c (Fformat): Likewise.
1e69125e 2253 * syntax.c (skip_chars): Likewise.
3befa583 2254
e3019616
PE
2255 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2256 This also lets GCC 4.6.0 generate slightly better loop code.
2257
becfa255
PE
2258 * callint.c (Fcall_interactively): <, not <=, for optimization.
2259 (Fcall_interactively): Count the number of arguments produced,
2260 not the number of arguments given. This is simpler and lets GCC
2261 4.6.0 generate slightly better code.
2262
dae0cd48
PE
2263 * ftfont.c: Distingish more carefully between FcChar8 and char.
2264 The previous code passed unsigned char * to a functions like
2265 strlen and xstrcasecmp that expect char *, which does not
2266 conform to the C standard.
2267 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2268 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2269 char * when the C standard requires it.
2270
76032d70
PE
2271 * keyboard.c (read_char): Remove unused var.
2272
eb3f1cc8
PE
2273 * eval.c: Port to Windows vsnprintf (Bug#8435).
2274 Include <limits.h>.
2275 (SIZE_MAX): Define if the headers do not.
2276 (verror): Do not give up if vsnprintf returns a negative count.
2277 Instead, grow the buffer. This ports to Windows vsnprintf, which
2278 does not conform to C99. Problem reported by Eli Zaretskii.
2279 Also, simplify the allocation scheme, by avoiding the need for
2280 calling realloc, and removing the ALLOCATED variable.
2281
70476b54
PE
2282 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2283
12020a9e
PE
2284 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2285 But keep the doprint source code for now, as we might revamp it
2286 and use it again (Bug#8435).
ea6c7ae6
PE
2287 * lisp.h (doprnt): Remove.
2288 * Makefile.in (base_obj): Remove doprnt.o.
2289 * deps.mk (doprnt.o): Remove.
2290
5fdb398c
PE
2291 error: Print 32- and 64-bit integers portably (Bug#8435).
2292 Without this change, on typical 64-bit hosts error ("...%d...", N)
2293 was used to print both 32- and 64-bit integers N, which relied on
2294 undefined behavior.
2295 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2296 New macro.
2297 * lisp.h (error, verror): Mark as printf-like functions.
2298 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2299 Report overflow in size calculations when allocating printf buffer.
2300 Do not truncate output string at its first null byte.
2301 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2302 Truncate the output at a character boundary, since vsnprintf does not
2303 do that.
2304 * charset.c (check_iso_charset_parameter): Convert internal
2305 character to string before calling 'error', since %c now has the
2306 printf meaning.
2307 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2308 overflow when computing char to be passed to 'error'. Do not
2309 pass Lisp_Object to 'error'; pass the integer instead.
2310 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2311 formatted with plain %d.
2312
b189fa66
PE
2313 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2314
bff87ef0
PE
2315 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2316
7e2cac20
PE
2317 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2318
ce4d90b5
PE
2319 * xterm.c (x_catch_errors): Remove duplicate declaration.
2320
266c9547
PE
2321 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2322
79c49ad2
PE
2323 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2324
368f4090
JM
23252011-04-10 Jim Meyering <meyering@redhat.com>
2326
2327 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2328 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2329 return ssize_t not "int", and use size_t as the buffer length.
2330 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2331 * gnutls.h: Update declarations.
2332 * process.c (read_process_output): Use ssize_t, to match.
2333 (send_process): Likewise.
2334
a32d4040
CY
23352011-04-09 Chong Yidong <cyd@stupidchicken.com>
2336
2337 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2338
8546720e 23392011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2340
04f2d78b
CB
2341 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2342 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2343
8546720e
GM
2344 * xterm.c (handle_one_xevent):
2345 * xmenu.c (create_and_show_popup_menu):
2346 * xselect.c (x_decline_selection_request)
2347 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2348
0a2f5c1a 23492011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2350
2351 Fix some uses of `int' instead of EMACS_INT.
2352 * search.c (string_match_1, fast_string_match)
2353 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2354 (scan_buffer, find_next_newline_no_quit)
2355 (find_before_next_newline, search_command, Freplace_match)
2356 (Fmatch_data): Make some `int' variables be EMACS_INT.
2357
2358 * xdisp.c (display_count_lines): 3rd argument and return value now
2359 EMACS_INT. All callers changed.
2360 (pint2hrstr): Last argument is now EMACS_INT.
2361
2362 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2363 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2364 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2365 (decode_coding_utf_16, decode_coding_emacs_mule)
2366 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2367 (decode_coding_ccl, decode_coding_charset)
2368 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2369 (decode_coding_iso_2022, decode_coding_emacs_mule)
2370 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2371 <char_offset, last_offset>: Declare EMACS_INT.
2372 (encode_coding_utf_8, encode_coding_utf_16)
2373 (encode_coding_emacs_mule, encode_invocation_designation)
2374 (encode_designation_at_bol, encode_coding_iso_2022)
2375 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2376 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2377 Declare EMACS_INT.
2378 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2379 (encode_invocation_designation): Last argument P_NCHARS is now
2380 EMACS_INT.
2381 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2382 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2383
2384 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2385 All users changed.
2386
2387 * ccl.c (Fccl_execute_on_string): Declare some variables
2388 EMACS_INT.
2389
8546720e 23902011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2391
2392 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2393
4e19a977
CS
23942011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2395
2396 * process.c (Fformat_network_address): Doc fix.
2397
87302331
R
23982011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2399
2400 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2401
cbb59342
CY
24022011-04-08 Chong Yidong <cyd@stupidchicken.com>
2403
2404 * keyboard.c (read_char): Call Lisp function help-form-show,
2405 instead of using internal_with_output_to_temp_buffer.
2406 (Qhelp_form_show): New var.
e0d38eeb 2407 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2408
2409 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2410
2411 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2412
e67a13ab
CY
24132011-04-06 Chong Yidong <cyd@stupidchicken.com>
2414
04f2d78b
CB
2415 * process.c (Flist_processes): Remove to Lisp.
2416 (list_processes_1): Delete.
e67a13ab 2417
973f782d
EZ
24182011-04-06 Eli Zaretskii <eliz@gnu.org>
2419
7c106b1e
EZ
2420 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2421
973f782d
EZ
2422 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2423
41cf7d1a 24242011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2425
ca23cc88
PE
2426 Fix more problems found by GCC 4.6.0's static checks.
2427
f390e2d5
PE
2428 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2429
42eea0d0
PE
2430 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2431
b69769da 2432 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2433
f9541e84
PE
2434 * xdisp.c (vmessage): Mark as a printf-like function.
2435
13841b55
PE
2436 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2437
c136c10f
PE
2438 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2439
5e2d4a30
PE
2440 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2441 printf-like functions.
2442 (tiff_load): Add casts to remove these marks before passing them
2443 to system-supplied API.
2444
583f48b9
PE
2445 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2446
b25d760e
PE
2447 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2448 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2449 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2450 directly, rather than having caller test rule sign. This avoids
2451 some unnecessary tests.
2452 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2453 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2454 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2455
bc7b6697 2456 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2457 (xfont_open): Avoid unnecessary tests.
bc7b6697 2458
27ccc379
PE
2459 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2460
dcd5c89a
PE
2461 * composite.h, composite.c (composition_gstring_put_cache):
2462 Use EMACS_INT, not int, for length.
2463
b13a45c6
PE
2464 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2465 breaking out part of COMPOSITION_DECODE_RULE.
2466 (COMPOSITION_DECODE_RULE): Use it.
2467 * composite.c (get_composition_id): Remove unused local vars,
2468 by using the new macro.
2469
1e792e4d
PE
2470 * textprop.c (set_text_properties_1): Change while to do-while,
2471 since the condition is always true at first.
2472
dc6c6455 2473 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2474 (interval_deletion_adjustment): Return unsigned value.
2475 All uses changed.
dc6c6455 2476
aba7731a
PE
2477 * process.c (list_processes_1, create_pty, read_process_output):
2478 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2479 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2480 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2481 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2482 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2483
fdfc4bf3
PE
2484 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2485
fca8fe46 2486 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2487 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2488
06a0259a 2489 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2490 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2491 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2492
e7b9e80f
PE
2493 * print.c (print_error_message): Avoid int overflow.
2494
56201685
PE
2495 * font.c (font_list_entities): Redo for clarity,
2496 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2497
78834453 2498 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2499 (font_score): Avoid potential overflow in diff calculation.
78834453 2500
0bc0b309 2501 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2502 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2503
e610eaca
PE
2504 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2505
b895abce
PE
2506 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2507 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2508 can always succeed if overflow has undefined behavior.
2509
1f1d9321 2510 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2511 (wordify): Omit three unnecessary tests.
1f1d9321 2512
c59478bc
PE
2513 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2514 All callers changed. This avoids the need for an unused var.
2515
79b73827
PE
2516 * casefiddle.c (casify_region): Remove var that is set but not used.
2517
a4db5dfe
PE
2518 * dired.c (file_name_completion): Remove var that is set but not used.
2519
43aae36e
PE
2520 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2521
2a47c44d 2522 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2523 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2524
a37c69bf
PE
2525 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2526 Check for integer overflow on size calculations.
2527
328ab8e7
PE
2528 * buffer.c (Fprevious_overlay_change): Remove var that is set
2529 but not used.
2530
e5a2a5cb
PE
2531 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2532 Remove vars that are set but not used.
8d84a6eb 2533 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2534 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2535
a60e5f68
PE
2536 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2537
f661cb61 2538 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2539 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2540
f0397f5a
PE
2541 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2542 that are set but not used.
2543
8664db06 2544 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2545 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2546
6abdaa4a
PE
2547 * xselect.c (x_get_local_selection, x_handle_property_notify):
2548 Remove vars that are set but not used.
2549
0ce7538d 2550 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2551 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2552
9ae848fc
PE
2553 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2554 Remove var that is set but not used.
0b918413
PE
2555 (scroll_bar_windows_size): Now size_t, not int.
2556 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2557 Check for overflow.
9ae848fc 2558
a5a62657
PE
2559 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2560 (map_tty_color) [!defined MSDOS]: Likewise.
2561
5c5cdd39
PE
2562 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2563
66ebf983
PE
2564 * coding.c: Remove vars that are set but not used.
2565 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2566 All callers changed.
2567 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2568 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2569 (decode_coding_charset): Remove vars that are set but not used.
2570
1be4d761
PE
2571 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2572 that is set but not used.
2573
47553fa8
PE
2574 * print.c (print_object): Remove var that is set but not used.
2575
1f7196bf 2576 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2577 The gnulib version avoids calling malloc in the usual case,
2578 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2579 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2580 * filelock.c (current_lock_owner): Likewise.
2581 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2582 * sysdep.c: Include allocator.h, careadlinkat.h.
2583 (emacs_no_realloc_allocator): New static constant.
2584 (emacs_readlink): New function.
fdb61804
PE
2585 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2586 ../lib/careadlinkat.h.
d1fdcab7 2587
f84c17c7
SM
25882011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2589
2590 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2591 first non-nil return value).
2592
ef3862ad
JD
25932011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2594
2595 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2596 if not defined (Bug#8403).
2597
376a7006
JB
25982011-04-02 Juanma Barranquero <lekktu@gmail.com>
2599
2600 * xdisp.c (display_count_lines): Remove parameter `start',
2601 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2602 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2603 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2604 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2605 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2606 and thereabouts. All callers changed.
2607 (get_per_char_metric): Remove parameter `f', unused since
2608 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2609
6ca3801d
JM
26102011-04-02 Jim Meyering <meyering@redhat.com>
2611
2612 do not dereference NULL upon failed strdup
2613 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2614 (ns_get_family): Likewise.
2615
d8e2b5ba
JB
26162011-04-02 Juanma Barranquero <lekktu@gmail.com>
2617
2618 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2619
8c74fcbd
JD
26202011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2621
2622 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2623 later (Bug#8403).
2624
7200d79c
SM
26252011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2626
03408648 2627 Add lexical binding.
7200d79c 2628
03408648
SM
2629 * window.c (Ftemp_output_buffer_show): New fun.
2630 (Fsave_window_excursion):
2631 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2632
2633 * lread.c (lisp_file_lexically_bound_p): New function.
2634 (Fload): Bind Qlexical_binding.
2635 (readevalloop): Remove `evalfun' arg.
2636 Bind Qinternal_interpreter_environment.
2637 (Feval_buffer): Bind Qlexical_binding.
2638 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2639 Mark as dynamic.
2640 (syms_of_lread): Declare `lexical-binding'.
2641
2642 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2643
2644 * keyboard.c (eval_dyn): New fun.
2645 (menu_item_eval_property): Use it.
ca105506
SM
2646
2647 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2648
03408648
SM
2649 * fns.c (concat, mapcar1): Accept byte-code-functions.
2650
2651 * eval.c (Fsetq): Handle lexical vars.
2652 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2653 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2654 (FletX, Flet): Obey lexical binding.
2655 (Fcommandp): Handle closures.
2656 (Feval): New `lexical' arg.
2657 (eval_sub): New function extracted from Feval. Use it almost
2658 everywhere where Feval was used. Look up vars in lexical env.
2659 Handle closures.
2660 (Ffunctionp): Move from subr.el.
2661 (Ffuncall): Handle closures.
2662 (apply_lambda): Remove `eval_flags'.
2663 (funcall_lambda): Handle closures and new byte-code-functions.
2664 (Fspecial_variable_p): New function.
2665 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2666 but without exporting it to Lisp.
23aba0ea 2667
23aba0ea 2668 * doc.c (Fdocumentation, store_function_docstring):
03408648 2669 * data.c (Finteractive_form): Handle closures.
23aba0ea 2670
03408648
SM
2671 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2672 interactive spec.
ba83908c 2673
04f2d78b
CB
2674 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2675 New byte-codes.
03408648
SM
2676 (exec_byte_code): New function extracted from Fbyte_code to handle new
2677 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2678
03408648 2679 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2680
03408648 2681 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2682
e2abce01
JB
26832011-03-31 Juanma Barranquero <lekktu@gmail.com>
2684
2685 * xdisp.c (redisplay_internal): Fix prototype.
2686
63696a73 26872011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2688
63696a73 2689 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2690 (try_scrolling): Use it when setting scroll_limit.
2691 Limit scrolling to 100 screen lines.
63696a73
EZ
2692 (redisplay_window): Even when falling back on "recentering",
2693 position point in the window according to scroll-conservatively,
2694 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2695
2696 (try_scrolling): When point is above the window, allow searching
2697 as far as scroll_max, or one screenful, to compute vertical
2698 distance from PT to the scroll margin position. This prevents
2699 try_scrolling from unnecessarily failing when
2700 scroll-conservatively is set to a value slightly larger than the
2701 window height. Clean up the case of PT below the margin at bottom
2702 of window: scroll_max can no longer be INT_MAX. When aggressive
2703 scrolling is in use, don't let point enter the opposite scroll
2704 margin as result of the scroll.
2705 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2706 threshold of 100 lines for never-recentering scrolling.
2707
e4cc2dfc
JB
27082011-03-31 Juanma Barranquero <lekktu@gmail.com>
2709
2710 * dispextern.h (move_it_by_lines):
2711 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2712 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2713 (message_log_check_duplicate): Remove parameters `prev_bol' and
2714 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2715 (redisplay_internal): Remove parameter `preserve_echo_area',
2716 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2717
2718 * indent.c (Fvertical_motion):
2719 * window.c (window_scroll_pixel_based, Frecenter):
2720 Don't pass `need_y_p' to `move_it_by_lines'.
2721
1c470562
SM
27222011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2723
44f230aa
SM
2724 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2725 steal a few bits to be more compact.
2726 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2727 Remove unneeded casts.
2728
1c470562
SM
2729 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2730
888adce9
ZK
27312011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2732
2733 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2734 binding" message (bug#7967).
2735
f838ed7b
PE
27362011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2737
77861b95
PE
2738 Fix more problems found by GCC 4.6.0's static checks.
2739
de6dbc14
PE
2740 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2741 Remove unused local var.
2742
f838ed7b
PE
2743 * editfns.c (Fmessage_box): Remove unused local var.
2744
792c7b2b
PE
2745 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2746 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2747 Omit unused local vars.
c499e557 2748 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2749 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2750 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2751 Omit unused local var.
2752
ba0165e1
PE
2753 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2754 Don't assume string length fits in int.
32ad8845 2755 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2756 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2757
3c59b4c9
PE
2758 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2759 instead of alloca (Bug#8344).
2760
a3eed478 2761 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2762 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2763
eb4d412d
PE
2764 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2765
1658b401
PE
2766 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2767 concerns.
2768
2769 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2770
2771 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2772
9a2c6e05
PE
2773 * keyboard.c (syms_of_keyboard): Use the same style as later
2774 in this function when indexing through an array. This also
2775 works around GCC bug 48267.
2776
03d0a109
PE
2777 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2778
44f730c8
PE
2779 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2780
fe75f926
PE
2781 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2782 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2783
ffa8c828
PE
2784 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2785 This avoids undefined behavior on integer overflow, and is a bit
2786 more convenient anyway since it is compared to a size_t variable.
2787
c5101a77
PE
2788 Variadic C functions now count arguments with size_t, not int.
2789 This avoids an unnecessary limitation on 64-bit machines, which
2790 caused (substring ...) to crash on large vectors (Bug#8344).
2791 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2792 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2793 All variadic functions and their callers changed accordingly.
c5101a77
PE
2794 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2795 * data.c (arith_driver, float_arith_driver): Likewise.
2796 * editfns.c (general_insert_function): Likewise.
2797 * eval.c (struct backtrace.nargs, interactive_p)
2798 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2799 (funcall_lambda, mark_backtrace): Likewise.
2800 * fns.c (concat): Likewise.
2801 * frame.c (x_set_frame_parameters): Likewise.
2802 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2803 0 if not found, not -1. All callers changed.
2804
dd3f25f7
PE
2805 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2806 (stack_copy_size): Now size_t, not int.
2807 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2808
461c2ab9
JB
28092011-03-28 Juanma Barranquero <lekktu@gmail.com>
2810
2811 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2812 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2813 All callers changed.
2814
2815 * lisp.h (multibyte_char_to_unibyte):
2816 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2817 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2818 * character.h (CHAR_TO_BYTE8):
2819 * cmds.c (internal_self_insert):
2820 * editfns.c (general_insert_function):
2821 * keymap.c (push_key_description):
2822 * search.c (Freplace_match):
2823 * xdisp.c (message_dolog, set_message_1): All callers changed.
2824
f6d62986
SM
28252011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2826
2827 * keyboard.c (safe_run_hook_funcall): New function.
2828 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2829 don't set the hook to nil, but remove the offending function instead.
2830 (Qcommand_hook_internal): Remove, unused.
2831 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2832 Vcommand_hook_internal.
2833
2834 * eval.c (enum run_hooks_condition): Remove.
2835 (funcall_nil, funcall_not): New functions.
2836 (run_hook_with_args): Call each function through a `funcall' argument.
2837 Remove `cond' argument, now redundant.
2838 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2839 (Frun_hook_with_args_until_failure): Adjust accordingly.
2840 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2841
1db5b1ad
JB
28422011-03-28 Juanma Barranquero <lekktu@gmail.com>
2843
2844 * dispextern.h (string_buffer_position): Remove declaration.
2845
2846 * print.c (strout): Remove parameter `multibyte', unused since
2847 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2848
2849 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2850 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2851 All callers changed.
2852
2853 * w32.c (_wsa_errlist): Use braces for struct initializers.
2854
2855 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2856 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2857 All callers changed.
2858 (string_buffer_position): Likewise. Also, make static (it's never
2859 used outside xdisp.c).
2860 (cursor_row_p): Remove parameter `w', unused since
2861 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2862 (decode_mode_spec): Remove parameter `precision', introduced during
2863 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2864 All callers changed.
2865
5ffb62aa
JD
28662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2867
2868 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2869
461c2ab9 28702011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2871
2872 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2873 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2874 (ns_update_auto_hide_menu_bar): New functions.
2875 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2876 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2877 ns_constrain_all_frames.
2878 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2879 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2880
5c380ffb
JD
28812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2882
2883 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2884
9af30bdf
GM
28852011-03-27 Glenn Morris <rgm@gnu.org>
2886
2887 * syssignal.h: Replace RETSIGTYPE with void.
2888 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2889 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2890 Replace SIGTYPE with void everywhere.
2891 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2892 * s/template.h (SIGTYPE): Remove commented out definition.
2893
e2abce01
JB
28942011-03-26 Eli Zaretskii <eliz@gnu.org>
2895
2896 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2897 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2898
f868cd8a
JB
28992011-03-26 Juanma Barranquero <lekktu@gmail.com>
2900
59eb0929
JB
2901 * w32.c (read_unc_volume): Use parameter `henum', instead of
2902 global variable `wget_enum_handle'.
2903
2904 * keymap.c (describe_vector): Remove parameters `indices' and
2905 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2906 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2907
f868cd8a
JB
2908 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2909
2910 * keyboard.c (timer_check): Remove parameter `do_it_now',
2911 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2912 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2913 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2914
2915 * keyboard.c (read_char):
2916 * w32menu.c (w32_menu_display_help):
2917 * xmenu.c (show_help_event, menu_help_callback):
2918 Adjust calls to `show_help_echo'.
2919
2920 * gtkutil.c (xg_maybe_add_timer):
2921 * keyboard.c (readable_events):
2922 * process.c (wait_reading_process_output):
2923 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2924
2925 * insdel.c (adjust_markers_gap_motion):
2926 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2927 (gap_left, gap_right): Don't call it.
2928
2ecf6fdb
CY
29292011-03-25 Chong Yidong <cyd@stupidchicken.com>
2930
2931 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2932 incurred during fontification.
2933
6b1f9ba4
JB
29342011-03-25 Juanma Barranquero <lekktu@gmail.com>
2935
2936 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2937 (DEFVAR_PER_BUFFER): Don't pass it.
2938
2939 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2940 (scrolling_window): Don't pass it.
2941
0f4a96b5
JB
29422011-03-25 Juanma Barranquero <lekktu@gmail.com>
2943
2944 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2945
2946 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2947 and `suffix'.
2948 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2949 of variables specific to SELinux and computation of `encoded_absname'.
2950
2951 * image.c (XPutPixel): Remove unused variable `height'.
2952
2953 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2954
2955 * unexw32.c (get_section_info): Remove unused variable `section'.
2956
2957 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2958 (system_process_attributes): Remove unused variable `sess'.
2959 (sys_read): Remove unused variable `err'.
2960
2961 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2962 (w32_wnd_proc): Remove unused variable `isdead'.
2963 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2964 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2965 (x_create_tip_frame): Remove unused variable `tem'.
2966
2967 * w32inevt.c (w32_console_read_socket):
2968 Remove unused variable `no_events'.
2969
2970 * w32term.c (x_draw_composite_glyph_string_foreground):
2971 Remove unused variable `width'.
2972
1149507c
JB
29732011-03-24 Juanma Barranquero <lekktu@gmail.com>
2974
2975 * w32term.c (x_set_glyph_string_clipping):
2976 Don't pass uninitialized region to CombineRgn.
2977
9c88f339
JB
29782011-03-23 Juanma Barranquero <lekktu@gmail.com>
2979
2980 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2981 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2982 (Fx_close_connection): Remove unused variable `i'.
2983
2984 * w32font.c (w32font_draw): Return number of glyphs.
2985 (w32font_open_internal): Remove unused variable `i'.
2986 (w32font_driver): Add missing initializer.
2987
2988 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2989 (fill_in_menu): Remove unused variable `items_added'.
2990
2991 * w32term.c (last_mouse_press_frame): Remove static global variable.
2992 (w32_clip_to_row): Remove unused variable `f'.
2993 (x_delete_terminal): Remove unused variable `i'.
2994
2995 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2996 (NOTHING): Remove unused static global variable.
2997 (uniscribe_check_otf): Remove unused variable `table'.
2998 (uniscribe_font_driver): Add missing initializers.
2999
dee091a3
JD
30002011-03-23 Julien Danjou <julien@danjou.info>
3001
3002 * term.c (Fsuspend_tty, Fresume_tty):
3003 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3004 * window.c (temp_output_buffer_show):
3005 * insdel.c (signal_before_change):
3006 * frame.c (Fhandle_switch_frame):
3007 * fileio.c (Fdo_auto_save):
3008 * emacs.c (Fkill_emacs):
3009 * editfns.c (save_excursion_restore):
3010 * cmds.c (internal_self_insert):
3011 * callint.c (Fcall_interactively):
3012 * buffer.c (Fkill_all_local_variables):
3013 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3014 Use Frun_hooks.
0f4a96b5 3015 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3016 unconditionnaly since it does the check itself.
3017
2c520ab5 30182011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3019
c9c49752
PE
3020 Fix more problems found by GCC 4.5.2's static checks.
3021
8abc3f12
PE
3022 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3023 the first time through the loop, since we know p0 < p1 then.
3024 This also avoids a gcc -Wstrict-overflow warning.
3025
a2d26660
PE
3026 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3027 leading to a memory leak, possible in functions like
3028 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3029 of objects (Bug#8318).
a2d26660 3030
916c72e9
PE
3031 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3032 that could (at least in theory) be that large.
3033
19ab8a18
PE
3034 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3035 This is less likely to overflow, and avoids undefined behavior if
3036 overflow does occur. All callers changed. Use strtoul to scan
3037 for the unsigned long integer.
b7cbbd6f
PE
3038 (pint2hrstr): Simplify and tune code slightly.
3039 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3040
f0641eff
PE
3041 * scroll.c (do_scrolling): Work around GCC bug 48228.
3042 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3043
7f650bb9
PE
3044 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3045 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3046 (validate_x_resource_name): Simplify count usage.
3047 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3048
37dd57d1
PE
3049 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3050 fail (Bug#8306).
81e56e61 3051
699979fc 3052 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3053
401bf9b4
PE
3054 * process.c (Fmake_network_process): Use socklen_t, not int,
3055 where POSIX says socklen_t is required in portable programs.
3056 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3057 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3058 (Fmake_network_process, server_accept_connection):
3059 (wait_reading_process_output, read_process_output):
3060 Likewise.
3061
b93aacde
PE
3062 * process.c: Rename or move locals to avoid shadowing.
3063 (list_processes_1, Fmake_network_process):
3064 (read_process_output_error_handler, exec_sentinel_error_handler):
3065 Rename or move locals.
4dc343ee 3066 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3067 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3068 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3069 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3070 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3071
af8a867c 3072 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3073 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3074 Include tparam.h instead, since it declares them.
af8a867c
PE
3075 * cm.h (PC): Remove extern decl; tparam.h now does this.
3076 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3077 * terminfo.c: Include tparam.h, to check interfaces.
3078 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3079 (tparam): Adjust signature to match interface in tparam.h;
3080 this removes some undefined behavior. Check that outstring and len
3081 are zero, which they always are with Emacs.
3082 * tparam.h (PC, BC, UP): New extern decls.
3083
0248044d 3084 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3085 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3086
8ff096c1 3087 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3088 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3089 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3090 (ftfont_list): Remove unused local.
49eaafba
PE
3091 (get_adstyle_property, ftfont_pattern_entity):
3092 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3093 Rename locals to avoid shadowing.
8ff096c1 3094
e2be39f6
PE
3095 * xfont.c (xfont_list_family): Mark var as initialized.
3096
c9735e30
PE
3097 * xml.c (make_dom): Now static.
3098
8f5201ae
PE
3099 * composite.c (composition_compute_stop_pos): Rename local to
3100 avoid shadowing.
b246f932
PE
3101 (composition_reseat_it): Remove unused locals.
3102 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3103 (composition_update_it): Mark var as initialized.
11b61122
PE
3104 (find_automatic_composition): Mark vars as initialized,
3105 with a FIXME (Bug#8290).
8f5201ae 3106
760fbc2c
PE
3107 character.h: Rename locals to avoid shadowing.
3108 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3109 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3110 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3111 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3112 to avoid shadowing.
3113
ff08eb85
PE
3114 * textprop.c (property_change_between_p): Remove; unused.
3115
fc7bf025
PE
3116 * intervals.c (interval_start_pos): Now static.
3117
235d7abc
PE
3118 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3119
44f230aa
SM
3120 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3121 Rename locals to avoid shadowing.
3e7d6594 3122
50060332
PE
3123 * sound.c (wav_play, au_play, Fplay_sound_internal):
3124 Fix pointer signedness.
d01f234b 3125 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3126 (wav_play): Initialize a variable to 0, to prevent undefined
3127 behavior (Bug#8278).
50060332 3128
c4fc4e30
PE
3129 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3130
918436ed
PE
3131 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3132
c939f91b
PE
3133 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3134 clobbering (Bug#8298).
b9c7f648
PE
3135 * sysdep.c (sys_subshell): Likewise.
3136 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3137
6bd8c144
PE
3138 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3139 This should get cleaned up, so that child_setup has the
3140 same signature on all platforms.
3141
7710357c 3142 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3143 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3144
c59da222
CY
31452011-03-22 Chong Yidong <cyd@stupidchicken.com>
3146
3147 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3148 not to be necessary, and produces flickering.
3149
66b87493
GM
31502011-03-20 Glenn Morris <rgm@gnu.org>
3151
3152 * config.in: Remove file.
3153
45b6f6d5
JB
31542011-03-20 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3157 are now in src/globals.h.
3158 (syms_of_minibuf): Remove spurious & from previous change.
3159
3ec03f7e
LL
31602011-03-20 Leo <sdl.web@gmail.com>
3161
3162 * minibuf.c (completing-read-function): New variable.
3163 (completing-read-default): Rename from completing-read.
3164 (completing-read): Call completing-read-function.
3165
b14e3e21
CY
31662011-03-19 Juanma Barranquero <lekktu@gmail.com>
3167
3168 * xfaces.c (Fx_load_color_file):
3169 Read color file from absolute filename (bug#8250).
3170
f2b726e6
JB
31712011-03-19 Juanma Barranquero <lekktu@gmail.com>
3172
3173 * makefile.w32-in: Update dependencies.
3174
09f6ff02
EZ
31752011-03-17 Eli Zaretskii <eliz@gnu.org>
3176
3177 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3178
29a6015a
PE
31792011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3180
a3a6c54e
PE
3181 Fix more problems found by GCC 4.5.2's static checks.
3182
b766f867
PE
3183 * process.c (make_serial_process_unwind, send_process_trap):
3184 (sigchld_handler): Now static.
3185
be02381c
PE
3186 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3187 That way, the code declares only the vars that it needs.
3188 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3189 * s/cygwin.h (PTY_ITERATION): Likewise.
3190 * s/darwin.h (PTY_ITERATION): Likewise.
3191 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3192
57048744
PE
3193 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3194 * process.c (allocate_pty): Don't declare stb unless it's needed.
3195
7914961c 3196 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3197 (CONSTANTLIM): Remove; unused.
3198 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3199 Define only if needed.
7914961c 3200
b3967b18
PE
3201 * unexelf.c (unexec): Name an expression,
3202 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3203 Use a different way to cause a compilation error if anyone uses
3204 n rather than nn, a way that does not involve shadowing.
73366a00 3205 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3206
29a6015a
PE
3207 * deps.mk (unexalpha.o): Remove; unused.
3208
43cfc33e 3209 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3210 * unexec.h: New file.
ce701a33
PE
3211 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3212 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3213 Depend on unexec.h.
3214 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3215 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3216 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3217 Change as necessary to match prototype in unexec.h.
ce701a33 3218
01f44d5a
PE
3219 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3220 shadowing.
4f63c6bb 3221 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3222
a6670b0b
PE
3223 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3224 Rename locals to avoid shadowing.
3225
cef2010d 3226 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3227 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3228
d4d7173a
PE
3229 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3230
f08b802a
PE
3231 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3232 warning when compiling print.c.
3233
3ddb0639
PE
3234 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3235 instead of using an uninitialized var.
5ad03b97 3236 (font_sort_entities): Mark var as initialized.
3ddb0639 3237
170a2692
PE
3238 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3239
e663c700
PE
3240 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3241 pointers to constants.
89bc529a 3242 (font_parse_fcname): Remove unused vars.
7b81e2d0 3243 (font_delete_unmatched): Now static.
ea838e10 3244 (font_get_spec): Remove; unused.
13a547c6
PE
3245 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3246 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3247 Rename or move locals to avoid shadowing.
e663c700 3248
2a80c887 3249 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3250 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3251
1384fa33 3252 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3253 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3254
8b2c52e9
PE
3255 * alloc.c (mark_backtrace): Move decl from here ...
3256 * lisp.h: ... to here, so that it can be checked.
3257
475545b5 3258 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3259 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3260 (lisp_indirect_variable): Name an expression,
3261 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3262 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3263
b1349114 3264 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3265 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3266 Use const pointer when appropriate.
b1349114 3267
a2928364
PE
3268 * lisp.h (get_system_name, get_operating_system_release):
3269 Move decls here, to check interfaces.
3270 * process.c (get_operating_system_release): Move decl to lisp.h.
3271 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3272 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3273 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3274 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3275 (Fformat_time_string, Fencode_time, Finsert_char):
3276 (Ftranslate_region_internal, Fformat):
3277 Rename or remove local vars to avoid shadowing.
9710023e 3278 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3279
a415e694
PE
3280 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3281 avoid shadowing.
3282
8ef4622d
PE
3283 * lisp.h (eassert): Check that the argument compiles, even if
3284 ENABLE_CHECKING is not defined.
3285
946f9a5b
PE
3286 * data.c (Findirect_variable): Name an expression, to avoid
3287 gcc -Wbad-function-cast warning.
112396d6 3288 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3289 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3290 (Fmake_variable_buffer_local, Fmake_local_variable):
3291 Mark variables as initialized.
52746918 3292 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3293
e5aab7e7 3294 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3295 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3296 Rename locals to avoid shadowing.
dff45157
PE
3297 (mark_stack): Move local variables into the #ifdef region where
3298 they're used.
7bc26fdb
PE
3299 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3300 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3301 needed otherwise.
3302 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3303 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3304 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3305
e5aab7e7
PE
3306 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3307 avoids undefined behavior in theory.
3308
4da60324
PE
3309 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3310
88043301
PE
3311 Use functions, not macros, for up- and down-casing (Bug#8254).
3312 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3313 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3314 to use the following functions instead of these macros.
3315 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3316 EMACS_INT, since callers assume the returned value fits in int.
3317 (upcase1): Likewise, for UPCASE_TABLE.
3318 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3319 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3320 the race-condition problem in the old DOWNCASE.
88043301 3321
19ed5445
PE
3322 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3323 Rename locals to avoid shadowing.
3324 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3325 (regex_compile, re_search_2, re_match_2_internal):
3326 Remove unused local vars.
952db0d7
PE
3327 (FREE_VAR): Rewrite so as not to use empty "else",
3328 which gcc can warn about.
da053e48 3329 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3330 (RETALLOC_IF): Define only if needed.
3331 (WORDCHAR_P): Likewise. This one is never needed, but is used
3332 only in a comment talking about a compiler bug, so put inside
3333 the #if 0 of that comment.
3334 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3335 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3336 Remove; unused.
19ed5445 3337
1f3561e4 3338 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3339 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3340 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3341
ded6f8f7
PE
3342 * search.c (simple_search): Remove unused var.
3343
dbd37a95
PE
3344 * dired.c (compile_pattern): Move decl from here ...
3345 * lisp.h: ... to here, so that it can be checked.
3346 (struct re_registers): New forward decl.
3347
7e47afad
PE
3348 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3349
85f24f61
PE
3350 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3351 All uses changed.
3352 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3353 Rename locals to avoid shadowing.
5671df8f 3354 (Fvertical_motion): Mark locals as initialized.
85f24f61 3355
181aa2be 3356 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3357 (casify_region): Mark local as initialized.
181aa2be 3358
930d429c
PE
3359 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3360
7082eac6
PE
3361 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3362 New macros, so that the caller can use some names other than
3363 gcpro1, gcpro2, etc.
3364 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3365 of the new macros.
3366 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3367 argument, for consistency with GCPRO2_VAR, etc: it is now the
3368 prefix of the variable, not the variable itself. All uses
3369 changed.
38b2c076
PE
3370 * dired.c (directory_files_internal, file_name_completion):
3371 Rename locals to avoid shadowing.
3372
15206ed9
PE
3373 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3374 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3375 dired.c's scmp function, had undefined behavior.
3376 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3377 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3378 * buffer.h: ... to here, because these macros use current_buffer,
3379 and the new implementation with inline functions needs to have
3380 current_buffer in scope now, rather than later when the macros
3381 are used.
3382 (downcase, upcase1): New static inline functions.
3383 (DOWNCASE, UPCASE1): Reimplement using these functions.
3384 This avoids undefined behavior in expressions like
3385 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3386 from race conditions in accessing the global variables
3387 case_temp1 and case_temp2.
3388 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3389 * lisp.h (case_temp1, case_temp2): Remove their decls.
3390 * character.h (ASCII_CHAR_P): Move from here ...
3391 * lisp.h: ... to here, so that the inline functions mentioned
3392 above can use them.
3393
4a6bea26
PE
3394 * dired.c (directory_files_internal_unwind): Now static.
3395
f14b7e14
PE
3396 * fileio.c (file_name_as_directory, directory_file_name):
3397 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3398 Now static.
2893f146
PE
3399 (file_name_as_directory): Use const pointers when appropriate.
3400 (Fexpand_file_name): Likewise. In particular, newdir might
3401 point at constant storage, so make it a const pointer.
fd4ead52 3402 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3403 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3404 signedness issues.
f839df0c
PE
3405 (Fset_file_times, Finsert_file_contents, auto_save_error):
3406 Rename locals to avoid shadowing.
f14b7e14 3407
5716756e 3408 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3409 (Ftry_completion, Fall_completions): Rename or remove locals
3410 to avoid shadowing.
5716756e 3411
b4c3046a
PE
3412 * marker.c (bytepos_to_charpos): Remove; unused.
3413
b45db522
PE
3414 * lisp.h (verify_bytepos, count_markers): New decls,
3415 so that gcc does not warn that these functions aren't declared.
3416
85876d07
PE
3417 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3418 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3419 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3420 (copy_text): Remove unused local var.
85876d07 3421
03d78a21 3422 * filelock.c (within_one_second): Now static.
b3dd38ab 3423 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3424
5df8f01b
PE
3425 * buffer.c (fix_overlays_before): Mark locals as initialized.
3426 (fix_start_end_in_overlays): Likewise. This function should be
3427 simplified by using pointers-to-pointers, but that's a different
3428 matter.
b1d876f1 3429 (switch_to_buffer_1): Now static.
8f54f30a
PE
3430 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3431 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3432
a70072c9 3433 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3434 Fix pointer signedness issue.
edced198
PE
3435 (sys_subshell): Mark local as volatile if checking for lint,
3436 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3437 (MAXPATHLEN): Define only if needed.
a70072c9 3438
a0977c44
PE
3439 * process.c (serial_open, serial_configure): Move decls from here ...
3440 * systty.h: ... to here, so that they can be checked.
3441
a884fdcc
PE
3442 * fns.c (get_random, seed_random): Move extern decls from here ...
3443 * lisp.h: ... to here, so that they can be checked.
3444
604efe86 3445 * sysdep.c (reset_io): Now static.
b8950c94 3446 (wait_for_termination_signal): Remove; unused.
604efe86 3447
38fc62d9
PE
3448 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3449 (copy_keymap_item, append_key, push_text_char_description):
3450 Now static.
1004a21a 3451 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3452 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3453 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3454 (describe_map_tree):
3455 Rename locals to avoid shadowing.
38fc62d9 3456
2f2650da
PE
3457 * keyboard.c: Declare functions static if they are not used elsewhere.
3458 (echo_char, echo_dash, cmd_error, top_level_2):
3459 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3460 (read_char, kbd_buffer_get_event, make_lispy_position):
3461 (make_lispy_event, make_lispy_movement, apply_modifiers):
3462 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3463 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3464 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3465 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3466 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3467
a053e86c 3468 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3469 (mark_kboards): Move decl here ...
3470 * alloc.c (mark_kboards): ... from here.
a053e86c 3471
4752793e
PE
3472 * lisp.h (force_auto_save_soon): New decl.
3473
74f10ca7 3474 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3475 (DEFINE_DUMMY_FUNCTION): New macro.
3476 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3477 Use it.
c03cd23f
PE
3478 (main): Add casts to avoid warnings
3479 if GCC considers string literals to be constants.
74f10ca7 3480
022e70d4
PE
3481 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3482
59d6fe83
PE
3483 * dbusbind.c: Pointer signedness fixes.
3484 (xd_signature, xd_append_arg, xd_initialize):
3485 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3486 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3487 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3488 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3489
78320123
PE
3490 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3491 if GCC considers string literals to be constants.
49cebcca 3492 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3493
35ac2a97
SM
34942011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3495
fb103ca9
SM
3496 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3497 (print_preprocess, print_object): New macro to fix last change.
3498
35ac2a97
SM
3499 * print.c (print_preprocess): Don't forget font objects.
3500
62973b41
JB
35012011-03-16 Juanma Barranquero <lekktu@gmail.com>
3502
3503 * emacs.c (USAGE3): Doc fixes.
3504
0e48bb22
AS
35052011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3506
3507 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3508 structure.
3509
7684e57b
JB
35102011-03-14 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * lisp.h (VWindow_system, Qfile_name_history):
3513 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3514 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3515 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3516
3517 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3518 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3519
3520 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3521 * w32console.c (detect_input_pending, read_input_pending)
3522 (encode_terminal_code):
3523 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3524 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3525 (w32_system_caret_y, Qfile_name_history):
3526 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3527 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3528 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3529 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3530 * w32proc.c (Qlocal, report_file_error):
3531 * w32term.c (Vwindow_system, updating_frame):
3532 * w32uniscribe.c (initialized, uniscribe_font_driver):
3533 Remove unneeded extern declarations.
3534
2aa46d6c
CY
35352011-03-14 Chong Yidong <cyd@stupidchicken.com>
3536
c96bbc66 3537 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3538
cffc6f3b
CY
35392011-03-13 Chong Yidong <cyd@stupidchicken.com>
3540
3541 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3542 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3543 These macros can no longer be used for assignment.
3544
44f230aa
SM
3545 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3546 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3547 (record_buffer_markers, fetch_buffer_markers): New functions for
3548 recording and fetching special buffer markers.
3549 (set_buffer_internal_1, set_buffer_temp): Use them.
3550
3551 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3552
3553 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3554
3555 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3556 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3557
3558 * xdisp.c (hscroll_window_tree):
3559 (reconsider_clip_changes): Use PT instead of BUF_PT.
3560
d251f04b
EZ
35612011-03-13 Eli Zaretskii <eliz@gnu.org>
3562
3563 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3564 $(EMACS_ROOT)/lib/intprops.h.
3565
f0c77cd1
PE
35662011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3567
3eca4629
PE
3568 Fix more problems found by GCC 4.5.2's static checks.
3569
7c86ee98
PE
3570 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3571 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3572 (xg_free_frame_widgets): Make it clear that a local variable is
3573 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3574 (gdk_window_get_screen): Make it clear that this macro is needed
3575 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3576 (int_gtk_range_get_value): New function, which avoids a diagnostic
3577 from gcc -Wbad-function-cast.
3578 (xg_set_toolkit_scroll_bar_thumb): Use it.
3579 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3580 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3581 (get_utf8_string, xg_get_file_with_chooser):
3582 Rename locals to avoid shadowing.
3583 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3584
41729b81
PE
3585 * xgselect.c (xg_select): Remove unused var.
3586
f0c77cd1
PE
3587 * image.c (four_corners_best): Mark locals as initialized.
3588 (gif_load): Initialize transparent_p to zero (Bug#8238).
3589 Mark another local as initialized.
ec6cf4c6 3590 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3591
ce0ad53d 3592 * image.c (clear_image_cache): Now static.
d5d5a617 3593 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3594 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3595 (x_edge_detection): Remove unnecessary cast that
3596 gcc -Wbad-function-cast diagnoses.
2037898d 3597 (gif_load): Fix pointer signedness.
6ae141d6
PE
3598 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3599 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3600
33383987 36012011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3602
d32df629
PE
3603 Improve quality of tests for time stamp overflow.
3604 For example, without this patch (encode-time 0 0 0 1 1
3605 1152921504606846976) returns the obviously-bogus value (-948597
3606 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3607 reports time overflow. See
3608 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3609 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3610 * editfns.c: Include limits.h and intprops.h.
3611 (TIME_T_MIN, TIME_T_MAX): New macros.
3612 (time_overflow): Move earlier, to before first use.
3613 (hi_time, lo_time): New functions, for an accurate test for
3614 out-of-range times.
3615 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3616 (Fget_internal_run_time): Don't assume time_t fits in int.
3617 (make_time): Use list2 instead of Fcons twice.
3618 (Fdecode_time): More accurate test for out-of-range times.
3619 (check_tm_member): New function.
3620 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3621 (lisp_time_argument): Don't rely on undefined left-shift and
3622 right-shift behavior when checking for time stamp overflow.
8be6f318 3623
fe31d94c
PE
3624 * editfns.c (time_overflow): New function, refactoring common code.
3625 (Fformat_time_string, Fdecode_time, Fencode_time):
3626 (Fcurrent_time_string): Use it.
3627
8be6f318
PE
3628 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3629 * dired.c (make_time): Move to ...
3630 * editfns.c (make_time): ... here.
3631 * systime.h: Note the move.
3632
09d9db2c 36332011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3634
126bc0dc
YM
3635 * fringe.c (update_window_fringes): Remove unused variables.
3636
c47cbdfd
YM
3637 * unexmacosx.c (copy_data_segment): Also copy __got section.
3638 (Bug#8223)
3639
7ac80be9
EZ
36402011-03-12 Eli Zaretskii <eliz@gnu.org>
3641
c96bbc66 3642 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3643 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3644 Constify `char *' arguments and their references according to
3645 prototypes in tparam.h.
3646
ecb0f94d 3647 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3648
7ac80be9
EZ
3649 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3650 Adapt all references accordingly.
3651
3652 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3653
ef1fd07e
TT
36542011-03-11 Tom Tromey <tromey@redhat.com>
3655
3656 * buffer.c (syms_of_buffer): Remove obsolete comment.
3657
7ef4b50c
EZ
36582011-03-11 Eli Zaretskii <eliz@gnu.org>
3659
3660 * termhooks.h (encode_terminal_code): Declare prototype.
3661
3662 * msdos.c (encode_terminal_code): Don't declare prototype.
3663
3664 * term.c (encode_terminal_code): Now external again, used by
3665 w32console.c and msdos.c.
3666
44f230aa
SM
3667 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3668 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3669
4b1ec863 36702011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3671
1714f52b 3672 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3673
4b1ec863
PE
3674 * fringe.c (update_window_fringes): Mark locals as initialized
3675 (Bug#8227).
3676 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3677
524c7aa6
PE
3678 * alloc.c (mark_fringe_data): Move decl from here ...
3679 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3680 to check its interface.
3681 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3682
a5c0af81 3683 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3684 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3685 (fontset_font): Mark local as initialized.
a9a06e0b 3686 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3687
b4716021
PE
3688 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3689
811e9bac 3690 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3691 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3692 (x_own_selection, Fx_disown_selection_internal): Rename locals
3693 to avoid shadowing.
3694 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3695
7e3ab302
PE
3696 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3697 so that the caller can use some name other than gcpro1.
3698 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3699 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3700 (Fx_backspace_delete_keys_p):
3701 Use them to avoid shadowing, and rename vars to avoid shadowing.
3702 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3703 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3704 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3705 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3706 Remove unused locals.
7e3ab302
PE
3707 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3708 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3709 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3710 macros.
f78faa98 3711
e2b13473
PE
3712 * xterm.h (x_mouse_leave): New decl.
3713
77f23912
PE
3714 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3715 Remove unused functions.
cdf4ba58
PE
3716 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3717 (x_calc_absolute_position): Now static.
7411c686 3718 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3719 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3720 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3721 unless they are used.
38d0b34a
PE
3722 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3723 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3724 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3725 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3726 (x_error_catcher, x_connection_closed, x_error_handler):
3727 (x_error_quitter, xembed_send_message, x_iconify_frame):
3728 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3729 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3730 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3731
44f230aa
SM
3732 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3733 Rename or move locals to avoid shadowing.
6b463e58 3734 (tty_defined_color, merge_face_heights): Now static.
5967d051 3735 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3736 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3737 does not deduce is never used uninitialized.
73719eba
PE
3738 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3739 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3740
426994c3 3741 * terminal.c (store_terminal_param): Now static.
5489860b 3742
032f1620 3743 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3744 (set_frame_menubar): Remove unused local.
d4323972 3745 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3746 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3747 since they might point to immutable storage.
281585b0
PE
3748 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3749 since it's unused otherwise.
032f1620 3750
367c19e5 3751 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3752 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3753 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3754 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3755 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3756 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3757 does not deduce are never used uninitialized.
70739cbe 3758
07b48fa9
PE
3759 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3760
8868a238 3761 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3762 * window.c (window_loop, size_window):
3763 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3764
7e5cf297 3765 * window.c (display_buffer): Now static.
d6550a9f
PE
3766 (size_window): Mark variables that gcc -Wuninitialized
3767 does not deduce are never used uninitialized.
a586633d
PE
3768 * window.h (check_all_windows): New decl, to forestall
3769 gcc -Wmissing-prototypes diagnostic.
5b555da1 3770 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3771
f6095868
PE
3772 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3773 shadowing.
3774 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3775 Include <limits.h>.
3776 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3777 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3778 (load_charset_map): Mark variables that gcc -Wuninitialized
3779 does not deduce are never used uninitialized.
53df7c11 3780 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3781
f38b440c
PE
3782 * coding.c (coding_set_source, coding_set_destination):
3783 Use "else { /* comment */ }" rather than "else /* comment */;"
3784 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3785 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3786 a block, when the outer 'i' will do.
3787 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3788 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3789 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3790 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3791 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3792 Rename locals to avoid shadowing.
3793 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3794 * coding.c (emacs_mule_char, encode_invocation_designation):
3795 Now static, since they're not used elsewhere.
413bb2db 3796 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3797 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3798 (decode_coding_emacs_mule): Mark variables that gcc
3799 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3800 (detect_coding_iso_2022): Initialize a local variable that might
3801 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3802 this initialization is needed. (Bug#8211)
5f58e762
PE
3803 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3804 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3805 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3806 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3807 Remove unused macros.
f38b440c 3808
232b38b9 3809 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3810 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3811 * character.c (string_count_byte8): Likewise.
232b38b9 3812
fb90da1b
PE
3813 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3814 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3815
fb93dbc2
PE
3816 * chartab.c (copy_sub_char_table): Now static, since it's not used
3817 elsewhere.
5c156ace
PE
3818 (sub_char_table_ref_and_range, char_table_ref_and_range):
3819 Rename locals to avoid shadowing.
bbcd0949 3820 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3821
7d3b3862 3822 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3823 (BIDI_BOB): Remove unused macro.
7d3b3862 3824
6be7d3da
PE
3825 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3826 deduce are never used uninitialized.
c2ed9c8b 3827 * term.c (encode_terminal_code): Likewise.
6be7d3da 3828
75f8807f 3829 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3830
50938595
PE
3831 * tparam.h: New file.
3832 * term.c, tparam.h: Include it.
3833 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3834 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3835 Move these decls to tparam.h, and make them agree with what
3836 is actually in tparam.c. The previous trick of using incompatible
3837 decls in different modules does not conform to the C standard.
3838 All callers of tparam changed to use tparam's actual API.
3839 * tparam.c (tparam1, tparam, tgoto):
3840 Use const pointers where appropriate.
3841
fbceeba2
PE
3842 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3843 * cm.h (struct cm): Likewise.
3844 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3845 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3846 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3847 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3848 (turn_on_face, init_tty): Likewise.
3849 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3850
7f3f1250
PE
3851 * term.c (term_mouse_position): Rename local to avoid shadowing.
3852
e6ca6543
PE
3853 * alloc.c (mark_ttys): Move decl from here ...
3854 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3855
c40f8d15
AS
38562011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3857
3858 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3859
cfe0661d
JB
38602011-03-09 Juanma Barranquero <lekktu@gmail.com>
3861
3862 * search.c (compile_pattern_1): Remove argument regp, unused since
3863 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3864 (compile_pattern): Don't pass it.
3865
0afb4571
J
38662011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3867
3868 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3869 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3870 for ! HAVE_GTK3.
3871 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3872
3873 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3874
3875 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3876 gdk_window_get_screen, gdk_window_get_geometry,
3877 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3878 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3879 (xg_get_pixbuf_from_pixmap): New function.
3880 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3881 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3882 Call xg_get_pixbuf_from_pixmap instead of
3883 gdk_pixbuf_get_from_drawable.
3884 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3885 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3886 (xg_check_special_colors): Use GtkStyleContext and its functions
3887 for HAVE_GTK3.
3888 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3889 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3890 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3891 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3892 Call gtk_widget_get_preferred_size.
0afb4571
J
3893 (xg_frame_resized): gdk_window_get_geometry only takes 5
3894 parameters.
44f230aa
SM
3895 (xg_win_to_widget, xg_event_is_for_menubar):
3896 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3897 (xg_set_widget_bg): New function.
3898 (delete_cb): New function.
895009e1 3899 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3900 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3901 (xg_set_background_color): Call xg_set_widget_bg.
3902 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3903 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3904 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3905 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3906 if ! HAVE_GTK3.
3907 (update_frame_tool_bar): Call gtk_widget_hide.
3908 (xg_initialize): Use GDK_KEY_g.
3909
3910 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3911 if ! HAVE_GTK3
3912 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3913
3914 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3915 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3916 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3917
1c2cc4ef
JB
39182011-03-08 Juanma Barranquero <lekktu@gmail.com>
3919
3920 * w32xfns.c (select_palette): Check success of RealizePalette against
3921 GDI_ERROR, not zero.
3922
33383987 3923See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3924
3925;; Local Variables:
3926;; coding: utf-8
aac0c6e3
MR
3927;; End:
3928
33383987 3929 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3930
3931 This file is part of GNU Emacs.
3932
3933 GNU Emacs is free software: you can redistribute it and/or modify
3934 it under the terms of the GNU General Public License as published by
3935 the Free Software Foundation, either version 3 of the License, or
3936 (at your option) any later version.
3937
3938 GNU Emacs is distributed in the hope that it will be useful,
3939 but WITHOUT ANY WARRANTY; without even the implied warranty of
3940 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3941 GNU General Public License for more details.
3942
3943 You should have received a copy of the GNU General Public License
3944 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.