* etags.c (Pascal_functions): Fix parenthesization typo.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f2045622
CY
12012-08-15 Chong Yidong <cyd@gnu.org>
2
3 * gtkutil.c (xg_get_font): Rename from xg_get_font_name. When
4 using the new font chooser, use gtk_font_chooser_get_font_desc to
5 extract the font descriptor instead of just the font name. In
6 that case, return a font spec instead of a string.
7 (x_last_font_name): Move to this file from xfns.c.
8
9 * xfns.c (Fx_select_font): The return value can also be a font
10 spec. Move x_last_font_name management to gtkutil.c.
11
12 * xfaces.c: Make font weight and style symbols non-static.
13
7f6feb56
SM
142012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
15
16 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
17 (bug#12117).
18
fecbd8ff
SM
192012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
20
21 * alloc.c (Fgarbage_collect): Use plural form consistently.
22
9b8d5165
EZ
232012-08-14 Eli Zaretskii <eliz@gnu.org>
24
25 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
26 iteration through the command loop. Fixes a problem whereby mouse
27 movements are ignored until the first mouse click.
28
f5d9e83a
PE
292012-08-14 Paul Eggert <eggert@cs.ucla.edu>
30
31 Use bool, not int, for Lisp booleans.
32 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
33 makes Emacs a bit smaller and presumably a bit faster.
34 * lisp.h: Include <stdbool.h>.
35 (struct Lisp_Boolfwd, defvar_bool):
36 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
37 * regex.c [!emacs]: Include <stdbool.h>.
38 (false, true): Remove; <stdbool.h> does this for us now.
39
55802e4a
CY
402012-08-14 Chong Yidong <cyd@gnu.org>
41
4abcdac8
CY
42 * character.c (Fcharacterp): Doc fix (Bug#12076).
43
44 * data.c (Findirect_variable): Doc fix (Bug#11040).
45
55802e4a
CY
46 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
47
48 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 49 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 50
8e99d072
BR
512012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
52
53 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
54 (bug#12022).
55
08908aca
MR
562012-08-14 Martin Rudalics <rudalics@gmx.at>
57
58 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
59 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
60 * minibuf.c (choose_minibuf_frame, read_minibuf):
61 * w32fns.c (x_create_tip_frame):
62 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
63 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
64
56120d6f
PE
652012-08-14 Paul Eggert <eggert@cs.ucla.edu>
66
67 * intervals.c (offset_intervals): Remove obsolete comment.
68
67b77c0b
AS
692012-08-14 Andreas Schwab <schwab@linux-m68k.org>
70
71 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
72
f48b82fd
GR
732012-08-14 Gergely Risko <gergely@risko.hu>
74
75 * coding.c (decode_coding): Record buffer modification before
76 disabling undo_list (Bug#11773).
77
fd318b54
DA
782012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
79
80 Revert and cleanup some recent overlay changes.
81 * buffer.h (enum overlay_type): Remove.
82 (buffer_get_overlays, buffer_set_overlays): Likewise.
83 (buffer_set_overlays_before, buffer_set_overlays_after):
84 New function. Adjust users.
85 (unchain_both): Add eassert.
86
41a62dd9
DA
872012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
88
89 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
90
5884c324
PE
912012-08-14 Paul Eggert <eggert@cs.ucla.edu>
92
93 * gtkutil.c (xg_mark_data): Don't assume C99.
94
ca06f160
JD
952012-08-13 Jan Djärv <jan.h.d@swipnet.se>
96
97 * gtkutil.c (xg_frame_tb_info): New struct.
98 (TB_INFO_KEY): New define.
99 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
100 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
101 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
102 if not present.
103 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
104 is up to date. Otherwise store new data.
105 (free_frame_tool_bar): Free xg_frame_tb_info if present.
106
7864a3f7
DA
1072012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
108
109 Use KSET for write access to Lisp_Object members of struct kboard.
110 * keyboard.h (KSET): New macro.
111 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
112 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
113 * xterm.c: Adjust users.
114
4c31be61
DA
1152012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
116
117 Use BSET for write access to Lisp_Object members of struct buffer.
118 * buffer.h (BSET): New macro.
119 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
120 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
121 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
122 * window.c, xdisp.c, xfns.c: Adjust users.
123
14ae4239
BT
1242012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
125
126 * lread.c (syms_of_lread): Initialize Vlexical_binding.
127
32bcadb4
JD
1282012-08-11 Jan Djärv <jan.h.d@swipnet.se>
129
3d29b2ce
JD
130 * nsterm.m (not_in_argv): New function.
131 (application:openFile, application:openTempFile:):
132 (application:openFileWithoutUI:, application:openFiles:): Open file
133 if not_in_argv returns non-zero (bug#12171).
134
32bcadb4 135 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
136 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
137 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
138 (xg_get_font_name): Use those functions/macros here.
139 Reported by Frans Oilinki <moilinki@gmail.com>.
140
9ff9402d 1412012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
142
143 * unexmacosx.c (copy_data_segment): Copy initialized data in
144 statically linked libraries from input file rather than memory.
145
db74a5fc
YM
146 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
147 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
148 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
149
25e65510
GM
1502012-08-10 Glenn Morris <rgm@gnu.org>
151
152 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
153 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
154
7961135c
DA
1552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
156
157 Fix last change to allow compilation with low optimization levels.
158 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
159 Reported by Jan Djärv <jan.h.d@swipnet.se>.
160
42b3a444
DA
1612012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
162
163 Use common inline syntax in intervals.h.
164 * intervals.h (INTERVALS_INLINE): New macro.
165 Change all users from LISP_INLINE.
166
9fb0c957
DA
1672012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
168
169 Define Qnone once for all platforms.
170 * frame.c (Qnone): Define here.
171 (syms_of_frame): DEFSYM it.
172 * lisp.h (Qnone): New declaration.
173 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
174 * xfns.c: Remove duplication. Adjust users.
175
65e8ee52
DA
1762012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
177
178 Remove unused macros from intervals.h.
179 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
180 * intervals.c: Adjust comment.
181
9b855fd6
EZ
1822012-08-10 Eli Zaretskii <eliz@gnu.org>
183
184 * w32fns.c <w32_unicode_gui>: New static variable.
185 (globals_of_w32fns): Initialize it according to os_subtype.
186 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
187 testing os_subtype.
188
39cb9e56 1892012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
190 Eli Zaretskii <eliz@gnu.org>
191
192 Fix bug #10299 with Unicode characters sent by customized
193 keyboards created by MSKLC.
194 * w32fns.c (INIT_WINDOW_CLASS): New macro.
195 (w32_init_class): Use it to initialize the Emacs class with either
196 ANSI or Unicode API calls.
197 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
198 later.
199 (w32_wnd_proc): If the character code sent by WM_CHAR or
200 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
201 original message. Call DefWindowProcW on NT and later.
202
9374581a
GM
2032012-08-10 Glenn Morris <rgm@gnu.org>
204
4b94e8cf
GM
205 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
206
9374581a
GM
207 * lisp.h (DIRECTORY_SEP): Let configure set it.
208
a2752828
DA
2092012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
210
211 Use TSET for write access to Lisp_Object slots of struct terminal.
212 * termhooks.h (TSET): New macro.
213 * coding.c, terminal.c, xselect.c: Adjust users.
214
cc92c454
SM
2152012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
216
217 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
218 the failing expression, include them in the error message.
219 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
220 * lisp.h (internal_condition_case_n): Update declaration.
221
4cb3e6b3
DA
2222012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
223
224 Inline functions to examine and change buffer overlays.
225 * buffer.c (unchain_both): New function.
226 * buffer.h (buffer_get_overlays, buffer_set_overlays):
227 (buffer_has_overlays): New function.
228 (enum overlay_type): New enum.
229 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
230 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
231
8707c1e5
DA
2322012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
233
234 Inline functions to examine and change buffer intervals.
235 * alloc.c (mark_interval_tree): Remove.
236 (MARK_INTERVAL_TREE): Simplify.
237 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
238 * intervals.c (buffer_balance_intervals): New function.
239 (graft_intervals_into_buffer): Adjust indentation.
240 (set_intervals_multibyte): Simplify.
241 * buffer.h (BUF_INTERVALS): Remove.
242 (buffer_get_intervals, buffer_set_intervals): New function.
243 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
244 * intervals.c, textprop.c: Adjust users.
245
ad8c997f
DA
2462012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
247
248 Inline functions to examine and change string intervals.
249 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
250 (string_get_intervals, string_set_intervals): New function.
251 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
252 * lread.c, print.c, textprop.c: Adjust users.
253
32ac3a6b
GM
2542012-08-08 Glenn Morris <rgm@gnu.org>
255
256 * lisp.mk (lisp): Remove language/persian.elc.
257
77c7bcb1
DA
2582012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Cleanup intervals.
261 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
262 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
263 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
264 Adjust comment. Move under #if 0.
77c7bcb1
DA
265 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
266 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
267
9c08a8d4
DA
2682012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
269
270 Check total length of intervals with eassert.
271 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
272 * intervals.c: Change all users to eassert.
273
26d16b35
EZ
2742012-08-07 Eli Zaretskii <eliz@gnu.org>
275
14ae4239
BT
276 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
277 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
278 INTERNAL_FIELD in Lisp_Cons.
279
c644523b
DA
2802012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
283 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
284 name since all xname users are fixed long time ago. Do not
285 use INTERNAL_FIELD.
286 (set_symbol_name, set_symbol_function, set_symbol_plist):
287 (set_symbol_next, set_overlay_plist): New function.
288 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
289 (struct Lisp_Overlay): Likewise.
290 (CVAR, MVAR, SVAR): Remove.
291 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
292 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
293 * xterm.c: Adjust users.
294 * .gdbinit: Change to use name field of struct Lisp_Symbol
295 where appropriate.
296
6a3d20cc
DA
2972012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
298
299 Basic functions to set Lisp_Object and pointer slots of intervals.
300 * intervals.h (interval_set_parent, interval_set_object):
301 (interval_set_left, interval_set_right, interval_set_plist):
302 (interval_copy_parent): New function.
303 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
304 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
305 Adjust indentation.
6a3d20cc
DA
306 (INTERVAL_SIZE): Remove. Adjust users.
307 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
308
4d2b044c
DA
3092012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
310
311 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
312 * process.h (PGET): Remove.
313 (struct Lisp_Process): Do not use INTERNAL_FIELD.
314 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
315
d3d50620
DA
3162012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
317
318 Drop WGET and revert read access to Lisp_Objects slots of struct window.
319 * window.h (WGET): Remove.
320 (struct window): Do not use INTERNAL_FIELD.
321 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
322 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
323 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
324 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
325 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
326 Adjust users.
327
d10a51dc
CY
3282012-08-07 Chong Yidong <cyd@gnu.org>
329
330 * window.c (Fwindow_edges, Fwindow_pixel_edges)
331 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
332 (Fdelete_window_internal): Signal an error if the window is not on
333 a live frame (Bug#12025).
334
e69b0960
DA
3352012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
336
337 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
338 * frame.h (FGET): Remove.
339 (struct frame): Do not use INTERNAL_FIELD.
340 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
341 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
342 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
343 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
344
25a20a3a
JB
3452012-08-06 Juanma Barranquero <lekktu@gmail.com>
346
347 * w32.c: Silence compiler warnings.
348 (map_w32_filename): Remove unused variable `is_fat'.
349 (chase_symlinks): Add parentheses around expression.
350
1c6f11f4
GM
3512012-08-06 Glenn Morris <rgm@gnu.org>
352
1db4583a
GM
353 * sysdep.c: Respect BROKEN_GETWD.
354
1c6f11f4
GM
355 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
356 Let configure handle it.
357 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
358
2b90362b
DA
3592012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
360
361 Use GCALIGNMENT where appropriate.
362 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
363 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
364 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
365
5f50daf2
EZ
3662012-08-06 Eli Zaretskii <eliz@gnu.org>
367
14ae4239
BT
368 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
369 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 370
cbcc7007
SM
3712012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
372
373 * buffer.h (struct buffer): Revert `indirections' to a simple int;
374 that should be sufficient for everyone.
375
4d365fa4
JD
3762012-08-06 Jan Djärv <jan.h.d@swipnet.se>
377
378 * keyboard.c (timer_check_2): Add break so timer_check returns next
379 timeout.
380
dd86bd82
DA
3812012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
382
383 Fix Windows build errors introduced after converting to WGET and WSET.
384 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
385 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
386
054e1668
JD
3872012-08-06 Jan Djärv <jan.h.d@swipnet.se>
388
389 * nsterm.m (ns_frame_rehighlight): Use FSET.
390
391 * nsmenu.m (ns_update_menubar): Use FSET.
392
21238f11
DA
3932012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
394
395 Separate read and write access to Lisp_Object slots of Lisp_Process.
396 * process.h (PGET, PSET): New macros similar to AREF and ASET.
397 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
398
077288cf
DA
3992012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
400
401 Separate read and write access to Lisp_Object slots of struct window.
402 * window.h (WGET, WSET): New macros similar to AREF and ASET.
403 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
404 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
405 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
406 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
407 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
408 Adjust users.
409
71688bd7
DA
4102012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
411
412 Fix Windows build errors introduced after converting to FGET and FSET.
413 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
414 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
415 (w32_judge_scroll_bars): Change to use FSET.
416 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
417
f99bac93
DA
4182012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
419
420 Fix replacement typo.
421 * window.c (replace_window): Set root_window instead of
422 selected_window. This fixes a total window subsystem
423 malfunction reported by Bastien Guerry <bzg@gnu.org>.
424
8c2a0f2d
GM
4252012-08-06 Glenn Morris <rgm@gnu.org>
426
427 * lisp.mk (lisp): Add language/persian.elc.
428
edd74c35
DA
4292012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
430
431 Separate read and write access to Lisp_Object slots of struct frame.
432 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
433 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
434 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
435 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
436 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
437
8671676c
AS
4382012-08-05 Andreas Schwab <schwab@linux-m68k.org>
439
440 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
441
663e2b3f
DA
4422012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
443
444 Generalize common compile-time constants.
445 * lisp.h (header_size, bool_header_size, word_size): Now here.
446 (struct Lisp_Vector): Add comment.
447 (struct Lisp_Bool_Vector): Move up to define handy constants.
448 (VECSIZE, PSEUDOVECSIZE): Simplify.
449 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
450 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
451 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
452 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
453 * xfont.c, xmenu.c: Use word_size where appropriate.
454
d32e47af
LM
4552012-08-05 Lawrence Mitchell <wence@gmx.li>
456
457 * search.c (Freplace_match): Treat \? in the replacement text
458 literally (Bug#8161).
459
e5d9c0d1
CY
4602012-08-05 Chong Yidong <cyd@gnu.org>
461
462 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
463 * frame.c (Vdelete_frame_functions):
464 * emacs.c (Vkill_emacs_hook): Doc fix.
465
8da0576b
EZ
4662012-08-04 Eli Zaretskii <eliz@gnu.org>
467
468 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
469 --with-x-toolkit=no builds.
470 Reported by Carsten Mattner <carstenmattner@gmail.com>.
471
02676e5d
CY
4722012-08-04 Chong Yidong <cyd@gnu.org>
473
474 * syntax.c (Fmodify_syntax_entry): Doc fix.
475
97147da9
EZ
4762012-08-04 Eli Zaretskii <eliz@gnu.org>
477
76151e2c
EZ
478 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
479 * w32.c (init_environment): Change the default values of many
480 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
481 them into environment when they were not already defined.
482 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 483 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
484 (check_windows_init_file): Now external, not static.
485 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
486 called when Vload_path is already set up.
487
488 * w32.h (check_windows_init_file): Add prototype.
489
490 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
491 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
492 compatibility with Posix platforms.
493 (main): Move the call to check_windows_init_file to here from
494 w32.c.
495 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
496 any, in the DEFALT argument into the root of the Emacs build or
497 installation tree, as appropriate.
498
499 * callproc.c (init_callproc_1): Call decode_env_path instead of
500 doing its equivalent by hand.
501 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
502 the code that sets Vexec_path run on MS-Windows.
503
504 * lread.c (init_lread): Add comments to #ifdef's.
505
97147da9
EZ
506 * msdos.c (dos_set_window_size, IT_update_begin)
507 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
508 instead of direct references.
509
185ee146
PE
5102012-08-04 Paul Eggert <eggert@cs.ucla.edu>
511
512 Export DEFAULT_REHASH_* to GDB.
513 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
514 Now constants, not macros.
515
8834c57a
PE
5162012-08-03 Paul Eggert <eggert@cs.ucla.edu>
517
98c6f1e3
PE
518 Remove unnecessary casts involving pointers.
519 These casts are no longer needed now that we assume C89 or later,
520 since they involve casting to or from void *.
521 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
522 (make_pure_float, make_pure_vector):
523 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
524 * macros.c (Fstart_kbd_macro):
525 * menu.c (find_and_return_menu_selection):
526 * minibuf.c (read_minibuf_noninteractive):
527 * sysdep.c (closedir):
528 * xdisp.c (x_produce_glyphs):
529 * xfaces.c (compare_fonts_by_sort_order):
530 * xfns.c (x_real_positions, select_visual):
531 * xselect.c (x_stop_queuing_selection_requests)
532 (x_get_window_property, x_get_window_property_as_lisp_data):
533 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
534 Remove unnecessary pointer casts.
535 * alloc.c (record_xmalloc): New function.
536 * lisp.h (record_xmalloc): New decl.
537 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
538 more like a function. This is because the pointer cast is not
539 needed. All uses changed.
540 * print.c (print_string, print_error_message): Avoid length recalc.
541
8834c57a
PE
542 Improve fix for macroexp crash with debugging (Bug#12118).
543 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
544 ARRAY_MARK_FLAG when checking subscripts, because ASET is
545 not supposed to be invoked from the garbage collector.
546 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
547 (gc_aset): New function, which is like ASET but can be
548 used in the garbage collector.
549 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
550 (set_hash_index): Use it instead of ASET.
551
6dad7178
EZ
5522012-08-03 Eli Zaretskii <eliz@gnu.org>
553
554 Support symlinks on latest versions of MS-Windows.
555 * w32.c: Include winioctl.h and aclapi.h.
556 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
557 (revert_to_self): Forward declarations of static functions.
558 <static BOOL g_b_init_get_security_info>:
559 <g_b_init_create_symbolic_link>: New static flags.
560 (globals_of_w32): Initialize them to zero.
561 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
562 (map_w32_filename): Improve commentary. Simplify switch.
563 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
564 headers (most versions of MinGW w32api don't).
565 (get_security_info, create_symbolic_link)
566 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
567 New functions.
568 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
569 in the argument file name.
570 (sys_access): Call unc_volume_file_attributes only if
571 GetFileAttributes fails with network-related error codes.
572 (sys_rename): Diagnose renaming of a symlink when the user doesn't
573 have the required privileges.
14ae4239 574 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
575 get_file_security_desc.
576 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
577 with addition of handling of symlinks and support for 'lstat'.
578 If possible, get file's attributes and security information by
6dad7178
EZ
579 handle, not by name. Produce S_IFLNK bit for symlinks, when
580 called from 'lstat'.
581 (stat, lstat): New functions, call 'stat_worker'.
582 (symlink, readlink, careadlinkat): Rewritten to create and resolve
583 symlinks when the underlying filesystem supports them.
584
f162bcc3
PE
5852012-08-02 Paul Eggert <eggert@cs.ucla.edu>
586
79ea6c20
PE
587 Fix macroexp crash on Windows with debugging (Bug#12118).
588 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
589 checking subscripts; problem introduced with the recent
590 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
591 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
592 since it's used in non-static inline functions now.
593
c0ce93fd
PE
594 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
595 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 596
f162bcc3
PE
597 Use C99-style 'extern inline' if available.
598 * buffer.h (BUFFER_INLINE):
599 * category.h (CATEGORY_INLINE):
600 * character.h (CHARACTER_INLINE):
601 * charset.h (CHARSET_INLINE):
602 * composite.h (COMPOSITE_INLINE):
603 * dispextern.h (DISPEXTERN_INLINE):
604 * lisp.h (LISP_INLINE):
605 * systime.h (SYSTIME_INLINE):
606 New macro, replacing 'static inline' in this header.
607 * buffer.h, category.h, character.h, charset.h, composite.h:
608 * dispextern.h, lisp.h, systime.h:
609 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
610 * alloc.c (LISP_INLINE):
611 * buffer.c (BUFFER_INLINE):
612 * category.c (CATEGORY_INLINE):
613 * character.c (CHARACTER_INLINE):
614 * charset.c (CHARSET_INLINE):
615 * composite.c (COMPOSITE_INLINE):
616 * dispnew.c (DISPEXTERN_INLINE):
617 * sysdep.c (SYSTIME_INLINE):
618 Define to EXTERN_INLINE, so that the corresponding functions
619 are compiled into code.
620 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
621 (INLINE_HEADER_END): New macros.
622 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
623 since it's used in non-static inline functions now.
a8333d03 624 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 625
837b365b
GM
6262012-08-02 Glenn Morris <rgm@gnu.org>
627
d66b744d
GM
628 * s/: Remove empty directory.
629
837b365b
GM
630 * s/ms-w32.h: Move to ../nt/inc.
631 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
632 Update for new ms-w32.h location.
633
13294f95
PE
6342012-08-02 Paul Eggert <eggert@cs.ucla.edu>
635
636 Port to Solaris 8.
637 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
638
90df0db3
GM
6392012-08-02 Glenn Morris <rgm@gnu.org>
640
641 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
642 hard-coding the path separator.
643
4939150c
PE
6442012-08-01 Paul Eggert <eggert@cs.ucla.edu>
645
646 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
647 This how ASET and AREF are supposed to work, and makes
648 it easier to think about future improvements. See
649 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
650 * charset.h (set_charset_attr): New function.
651 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
652 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
653 (aref_addr): New function. All uses of &AREF(...) changed.
654 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
655 (set_hash_index): New functions. All lvalue-style uses of
656 HASH_KEY etc. changed.
657 * keyboard.c (set_prop): New function. All lvalue-style uses
658 of PROP changed.
659
947b2afd
AA
6602012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
661
662 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
663 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
664 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
665 * nsfns.m (ns_set_name_as_filename): Likewise.
666 * nsmenu.m (ns_update_menubar): Likewise.
667 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
668
4f5d0325
EZ
6692012-08-01 Eli Zaretskii <eliz@gnu.org>
670
2008beae
EZ
671 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
672 Adapt to latest changes in field names of the corresponding Lisp
288479f6 673 objects.
2008beae 674
4f5d0325
EZ
675 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
676
fe3cc771
GM
6772012-08-01 Glenn Morris <rgm@gnu.org>
678
679 * s/msdos.h: Remove file.
680 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
681 * Makefile.in (S_FILE): Remove.
682 (config_h): Remove S_FILE.
683
c90acc54
JB
6842012-08-01 Juanma Barranquero <lekktu@gmail.com>
685
686 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
687 Remove; moved to nt/config.nt.
688
d8a05828
DA
6892012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
690
691 Use INTERNAL_FIELD for conses and overlays.
692 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
693 Remove obsolete comment.
694 (MVAR): New macro.
695 (struct Lisp_Overlay): Use INTERNAL_FIELD.
696 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
697
8271d590
DA
6982012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
699
700 Use INTERNAL_FIELD for symbols.
701 * lisp.h (SVAR): New macro. Adjust users.
702 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
703 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
704
3193acd2
DA
7052012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
706
707 Use INTERNAL_FIELD for processes.
708 * process.h (PVAR): New macro. Adjust style.
709 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
710 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
711
3a45383a
DA
7122012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
713
714 Use INTERNAL_FIELD for windows.
715 * window.h (WVAR): New macro.
716 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
717 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
718 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
719 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
720 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
721 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
722
c1dbc63c
PE
7232012-08-01 Paul Eggert <eggert@cs.ucla.edu>
724
725 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
726
5c0c0e8a
GM
7272012-08-01 Glenn Morris <rgm@gnu.org>
728
729 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
730 Move to configure.ac.
731
552a99b4
JB
7322012-08-01 Juanma Barranquero <lekktu@gmail.com>
733
734 * makefile.w32-in (CONFIG_H): Update dependencies.
735 (CONF_POST_H): New macro.
736
737 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
738
8d8e2dfe
GM
7392012-07-31 Glenn Morris <rgm@gnu.org>
740
bc96620a
GM
741 * Makefile.in (S_FILE): No longer set by configure.
742
476b1b2d
GM
743 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
744 is available.
745 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
746
b2c7a106
GM
747 * process.h (NULL_DEVICE):
748 * emacs.c (SEPCHAR):
749 * editfns.c (USER_FULL_NAME): Let configure set them.
750
d53d062a
GM
751 * s/README, s/template.h: Remove files.
752
4515017f
GM
753 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
754
8d8e2dfe
GM
755 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
756 Move to configure.ac.
757
5b20b3cc
EZ
7582012-07-31 Eli Zaretskii <eliz@gnu.org>
759
1e0afd9a
EZ
760 * .gdbinit (xframe): Adapt to introduction of FVAR and the
761 resulting renaming of 'struct frame' members.
762
5b20b3cc
EZ
763 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
764
765 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
766 after introduction of FVAR.
767
f1310128
JD
7682012-07-31 Jan Djärv <jan.h.d@swipnet.se>
769
79e721e0
JD
770 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
771
772 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
773 instead of compositeToPoint.
774 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
775
8d7c7eed 776 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 777
e34f7f79
DA
7782012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
779
780 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
781 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 782 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
783 (BVAR): Change to use INTERNAL_FIELD.
784 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
785 (KVAR): Change to use INTERNAL_FIELD.
786 * frame.h (FVAR): New macro.
787 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
788 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
789 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
790 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
791 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
792
c09bfb2f
DA
7932012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
794
795 Miscellaneous fixes for non-default X toolkits.
796 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
797 * xterm.c (x_frame_of_widget): Remove redundant prototype.
798 Move under #ifdef USE_LUCID.
799 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
800 definition and usage to avoid warnings.
801
14c114ae
JD
8022012-07-31 Jan Djärv <jan.h.d@swipnet.se>
803
804 * nsterm.m (openFiles): Fix previous checkin.
805
3bd21e82
PE
8062012-07-31 Paul Eggert <eggert@cs.ucla.edu>
807
808 * indent.c (compute_motion): Remove unused local.
809
c1529ded
GM
8102012-07-31 Glenn Morris <rgm@gnu.org>
811
400d5621
GM
812 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
813
268e2432
GM
814 * conf_post.h [USG5_4]:
815 Move remaining contents of s/usg5-4-common.h here.
816 * s/usg5-4-common.h: Remove file.
817
7552f3ee
GM
818 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
819 * s/irix6-5.h: Remove file.
820
6a381852
GM
821 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
822 * s/darwin.h: Remove file.
823
c1529ded
GM
824 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
825 * s/hpux10-20.h: Remove file, which is now empty.
826
b429a4ee
GM
8272012-07-30 Glenn Morris <rgm@gnu.org>
828
829 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
830 * Makefile.in (config_h): Add conf_post.h.
831 * makefile.w32-in (CONFIG_H): Add conf_post.h.
832
adff3182
JD
8332012-07-30 Jan Djärv <jan.h.d@swipnet.se>
834
835 * nsterm.m (ns_do_open_file): New variable.
b9031d69 836 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
837 (openFile, openTempFile, openFileWithoutUI, openFiles):
838 Open files only if ns_do_open_file.
adff3182 839
c32af1e4
PE
8402012-07-30 Paul Eggert <eggert@cs.ucla.edu>
841
7393bcbb
PE
842 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
843 This no-op macro hasn't been needed for many years.
844 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
845
c32af1e4
PE
846 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
847 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
848 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
849 gdb_make_enums_visible.
850 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
851 (DIRECTORY_SEP): Now a constant, not a macro.
852
302fc036
EZ
8532012-07-30 Eli Zaretskii <eliz@gnu.org>
854
855 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
856 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
857
858 * w32term.c <w32_keyboard_codepage>: Renamed from
859 keyboard_codepage and now external. All users changed.
860
861 * w32term.h: Add declaration of w32_keyboard_codepage.
862
863 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
864 the codepage to translate keys to Unicode. If this argument is
865 -1, use the value returned by GetConsoleCP. All callers changed.
866
88fb40b4
PE
8672012-07-30 Paul Eggert <eggert@cs.ucla.edu>
868
0aee6912
PE
869 Update .PHONY listings in makefiles.
870 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
871 bootstrap-clean, distclean, maintainer-clean, versioclean,
872 extraclean, frc.
873
88fb40b4
PE
874 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
875 This is a bit clearer. Fix some commentary typos.
876
0a763bd1
GM
8772012-07-30 Glenn Morris <rgm@gnu.org>
878
32bac6d6
GM
879 * s/netbsd.h: Let configure include signal.h if needed.
880 Remove file, which is now empty.
881
b65e7c46
GM
882 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
883 Let configure set them.
884 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
885 No more need to undefine.
0a763bd1 886
169304bd
AS
8872012-07-30 Andreas Schwab <schwab@linux-m68k.org>
888
889 * keymap.c (Fkey_description): Don't remove 0x80 bit from
890 non-single-byte char when adding meta modifier. (Bug#12090)
891
6cd7a139
DA
8922012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
893
894 Convert safe_call to use variable number of arguments.
895 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
896 (safe_call2): Fix comment.
897 * lisp.h (safe_call): Adjust prototype.
898 * coding.c (encode_coding_object): Change to use safe_call2.
899 * xfaces.c (merge_face_heights): Change to use safe_call1.
900
d34d6ffc
GM
9012012-07-30 Glenn Morris <rgm@gnu.org>
902
7b8a48e4 903 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 904 does that unconditionally. Remove file, which is now empty.
7b8a48e4 905
d34d6ffc
GM
906 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
907 Remove empty files.
908
03a660a6
PE
9092012-07-30 Paul Eggert <eggert@cs.ucla.edu>
910
911 Export to GDB most of lisp.h's remaining object-like macros.
912 * lisp.h (min, max): Move earlier, because they're used earlier now.
913 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
914 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
915 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
916 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
917 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
918 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
919 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
920 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
921 Now constants, for GDB. They need not be macros.
922 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
923 Now constants, for GDB, as well as macros, for static initializers.
924 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
925 Move to after the definition of struct Lisp_Char_Table,
926 since the former now needs that type defined.
927 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
928 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
929 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
930 New enums, for gdb_make_enums_visible.
931 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 932 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
933 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
934 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
935 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
936 enum maxargs, enum MAX_ALLOCA.
937 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
938 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
939 no longer needed, now that they are done in lisp.h.
940
e499d0ee
DA
9412012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
942
943 Cleanup string bytes checking.
944 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
945 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
946 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
947 (check_sblock, compact_small_strings): Simplify.
948
d5040d2d
PE
9492012-07-29 Paul Eggert <eggert@cs.ucla.edu>
950
951 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
952 These macros are confusing and no longer need to be defined, as
953 the enum values now suffice. All uses replaced with definiens.
954 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
955
7f259ae6
JB
9562012-07-29 Juanma Barranquero <lekktu@gmail.com>
957
958 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
959 ($(BLD)/w32console.$(O)): Update dependencies.
960
7e63e0c3
DA
9612012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
962
963 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
964 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
965 time. Adjust users.
966 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
967
ffd817eb
JD
9682012-07-29 Jan Djärv <jan.h.d@swipnet.se>
969
970 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
971 setting sitelisp (Bug#12010).
972
417a7a0e
EZ
9732012-07-29 Eli Zaretskii <eliz@gnu.org>
974
14ae4239 975 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
976
977 * w32heap.c (cache_system_info):
978 * w32.c (sys_rename):
979 * w32proc.c (find_child_console, sys_kill): All users changed.
980
387d4d92
PE
9812012-07-29 Paul Eggert <eggert@cs.ucla.edu>
982
983 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
984
55a6cca6
EZ
9852012-07-29 Eli Zaretskii <eliz@gnu.org>
986
987 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
988
dbcf001c
DA
9892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
990
991 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
992 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
993 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 994
e2688e4a
DA
9952012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
996
997 Generalize marker debugging code under MARKER_DEBUG and use eassert.
998 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
999 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1000 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1001 (replace_range, replace_range_2, del_range_2): Change to eassert.
1002 * marker.c (byte_char_debug_check): Adjust style.
1003
b46a6a83
PE
10042012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1007 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1008 long-ago-commented-out code that talks about "WIN32".
1009 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1010 All uses changed.
1011
e32a5799
PE
10122012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1013
1014 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1015 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1016 Simplify by using alignof.
1017 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1018 * lisp.h: Include <stdalign.h>.
1019 (GCALIGNMENT): New macro and constant.
1020 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1021 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1022 (stdalign): New macro, if not already defined.
1023
df81cd29
EZ
10242012-07-28 Eli Zaretskii <eliz@gnu.org>
1025
01bd1b0d
EZ
1026 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1027 * w32inevt.c: Include w32inevt.h.
1028 (w32_read_console_input): New inline function, calls either
1029 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1030 w32_console_unicode_input.
1031 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1032 (w32_kbd_patch_key, key_event): Use the codepage returned by
1033 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1034 (key_event): use uChar.UnicodeChar only if
1035 w32_console_unicode_input is non-zero.
1036
1037 * w32console.c: Include w32heap.h.
1038 <w32_console_unicode_input>: New global variable.
1039 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1040 family of Windows, zero otherwise.
1041
1042 * w32inevt.h: Declare w32_console_unicode_input.
1043
df81cd29
EZ
1044 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1045 --without-x. (Bug#11742)
1046
c20fdd9e
PE
10472012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 Adjust GDB to reflect pvec_type changes (Bug#12036).
1050 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1051 2012-07-04 changes to pseudovector representation.
1052 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1053
32770973 10542012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1055
1056 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1057 bus address.
1058 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1059
3438fe21
EZ
10602012-07-27 Eli Zaretskii <eliz@gnu.org>
1061
bcfbc9de
EZ
1062 * alloc.c (listn): Fix the order the arguments are consed onto the
1063 list.
1064
3438fe21
EZ
1065 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1066 enumeration constants, as PURE and HEAP are too general, and clash
1067 with other headers and sources, such as gmalloc.c and the
1068 MS-Windows system headers. All users changed.
1069
eeaea515
DA
10702012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1071
1072 Revert last save_excursion_save and save_excursion_restore changes.
1073 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1074 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1075
073c88c2
DA
10762012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Fix recently-introduced typos in Windows port.
1079 Reported by Martin Rudalics <rudalics@gmx.at>.
1080 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1081 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1082
4706125e
PE
10832012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 Improve GDB symbol export (Bug#12036).
1086 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1087 arms of an 'if', not using conditional expressions; otherwise GDB
1088 complains about the types in the unevaluated arm when the argument
1089 is an integer literal.
1090 (xgetint): Simplify expression.
1091 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1092 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1093 Zaretskii in <http://bugs.gnu.org/12036#13>.
1094 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1095 needed now that we have gdb_make_enums_visible.
1096 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1097 (enum enum_USE_LSB_TAG):
1098 New enum types, packaging up enums that need to be exported to GDB.
1099
694b6c97
DA
11002012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1101
1102 Utility function to make a list from specified amount of objects.
1103 * lisp.h (enum constype): New datatype.
1104 (listn): New prototype.
1105 * alloc.c (listn): New function.
1106 (Fmemory_use_count, syms_of_alloc): Use it.
1107 * buffer.c (syms_of_buffer): Likewise.
1108 * callint.c (syms_of_callint): Likewise.
1109 * charset.c (define_charset_internal): Likewise.
1110 * coding.c (syms_of_coding): Likewise.
1111 * keymap.c (syms_of_keymap): Likewise.
1112 * search.c (syms_of_search): Likewise.
1113 * syntax.c (syms_of_syntax): Likewise.
1114 * w32.c (init_environment): Likewise.
1115 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1116 * xdisp.c (syms_of_xdisp): Likewise.
1117 * xfns.c (syms_of_xfns): Likewise.
1118
6195f384
DA
11192012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 Fast save_excursion_save and save_excursion_restore.
1122 * lisp.h (struct Lisp_Excursion): New data type.
1123 (PVEC_EXCURSION): New pseudovector type.
1124 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1125 to deal with it. Adjust comments.
1126 (init_marker, attach_marker): New prototype.
1127 (unchain_marker): Adjust prototype.
1128 * marker.c (attach_marker): Change to global.
1129 (init_marker): New function.
1130 * alloc.c (Fmake_marker, build_marker): Use it.
1131 (build_marker): More easserts.
1132 (mark_object): Handle struct Lisp_Excursion.
1133 * editfns.c (save_excursion_save, save_excursion_restore):
1134 Reimplement to use struct Lisp_Excursion. Add comments.
1135
5eceb8fb
PE
11362012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1137
1138 Fix export of symbols to GDB (Bug#12036).
1139 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1140 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1141 emacs.c, as this is a more-suitable home. Had this been done earlier
1142 the fix for 12036 would have avoided some of the problems noted in
1143 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1144 would have been more obvious.
562157c8
PE
1145 * emacs.c: Do not include <verify.h>; no longer needed.
1146 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1147 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1148 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1149 Remove; now done in lisp.h.
1150 * lisp.h (PUBLISH_TO_GDB): New macro.
1151 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1152 (DATA_SEG_BITS): Use it.
1153 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1154 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1155 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1156 not be usable in #if. This simplifies things.
1157
d6749401
JB
11582012-07-26 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1161
1781b9e9
PE
11622012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1163
d89518db 1164 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1165 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1166 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1167 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1168 Adjust to changes in lisp.h and emacs.c, by using
1169 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1170 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1171 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1172 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1173 instead of gdb_valbits.
1174 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1175 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1176 instead of gdb_array_mark_flag.
1177 (xboolvector): Get size from $->size, not $->header.size.
1178 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1179 (xreload, hook-run, hookpost-run): Remove.
1180 * emacs.c: Include <verify.h>.
1181 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1182 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1183 Remove.
1184 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1185 (gdb_USE_LSB_TAG): New enum constants.
1186 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1187 Also define these as enum constants, so they're visible to GDB.
1188 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1189 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1190 as constants, so they're visible to GDB.
1191 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1192 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1193 Now enum constants, not macros, so they're visible to GDB.
1194 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1195 more convenient now. All uses changed.
1196 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1197 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1198
3628596a
DA
11992012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 Explicitly free restriction data that are not needed anymore.
1202 * editfns.c (save_restriction_restore): Free restriction data.
1203
7abaf5cc
SM
12042012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1205
1206 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1207 add argument, tune behavior, and adjust all callers.
1208
71f88e00
PE
12092012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1210
1211 Use typedef for EMACS_INT, EMACS_UINT.
1212 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1213 than macros. This simplifies debugging in the usual case, since
1214 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1215 and it allows expressions involving EMACS_INT casts.
1216 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1217
57ec3034
JD
12182012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1219
1220 * nsterm.m (ns_read_socket): Return early if there is a modal
1221 window (Bug#12043).
1222
8137e7b3
MR
12232012-07-25 Martin Rudalics <rudalics@gmx.at>
1224
1225 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1226 that FOCUS-FRAME can be omitted.
1227
04e9897c
DA
12282012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1229
1230 Adjust buffer text indirection counters at the end of Fkill_buffer.
1231 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1232 buffer is definitely dead. This should really fix an issue reported
1233 by Christoph Scholtes again. (Bug#12007).
1234 (init_buffer_once): Initialize indirection counters of
1235 buffer_defaults and buffer_local_symbols (for sanity and safety).
1236
8a0484e1
EZ
12372012-07-24 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1240 and continuation glyphs on tooltip frames, leave them at zero.
1241 Avoids continued lines in tooltips. (Bug#11832)
1242
fa691a83
DA
12432012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1244
1245 Simplify copy_overlay.
04e9897c 1246 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1247 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1248
436bc8e0
EZ
12492012-07-23 Eli Zaretskii <eliz@gnu.org>
1250
1251 * print.c (print_object): Don't crash when a frame's name is nil
1252 or invalid. (Bug#12025)
1253
1254 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1255 it signals an error when a tooltip frame is being created.
1256
d7a7fda3
DA
12572012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1258
1259 Cleanup miscellaneous objects allocation and initialization.
1260 * alloc.c (allocate_misc): Change to static. Add argument to
1261 specify the subtype. Adjust comment and users.
1262 (build_overlay): New function.
1263 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1264 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1265 (allocate_misc): Remove prototype.
1266 (build_overlay): Add prototype.
1267
12682012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1269
1270 Swap buffer text indirection counters in Fbuffer_swap_text.
1271 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1272 This avoids crash reported by Christoph Scholtes at
1273 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1274
9d7fa573
JD
12752012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1276
1277 * nsmenu.m (Popdown_data): New struct.
1278 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1279 free Popdown_data.
1280 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1281 (initWithContentRect): Make imgView and contentView non-static
1282 and autorelease them. Also autorelease img and matrix (Bug#12005).
1283 (dealloc): Remove (Bug#12005).
1284
0dd6d66d
DA
12852012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1286
1287 Adjust consing_since_gc when objects are explicitly freed.
1288 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1289 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1290 (free_cons, free_misc): Subtract object size from consing_since_gc.
1291
d36d71df
DA
12922012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 Simplify and cleanup markers positioning code.
1295 * marker.c (attach_marker): More useful eassert.
1296 (live_buffer, set_marker_internal): New function.
1297 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1298 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1299
fb9ea40f
PE
13002012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1303 as it's limited by the amount of memory, not by INT_MAX.
1304
2d5c5f7d
EZ
13052012-07-21 Eli Zaretskii <eliz@gnu.org>
1306
07fb592e
EZ
1307 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1308 in special-event-map. See the discussion at
1309 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1310 for the reasons.
1311
37a9eac8 1312 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1313 info.dwItemData. Fixes crashes on 64-bit Windows.
1314 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1315
c4328746
JD
13162012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1317
1318 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1319 (conversationIdentifier): Return value is NSInteger.
784051c4 1320 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1321
6e5d1c12
CY
13222012-07-21 Chong Yidong <cyd@gnu.org>
1323
1324 * window.c (decode_any_window): Signal an error if the window is
1325 on a dead frame (Bug#11984).
1326
9928463d
DA
13272012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1328
1329 Add indirection counting to speed up Fkill_buffer.
1330 * buffer.h (struct buffer): New member.
1331 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1332 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1333 base buffer indirection counter.
1334 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1335 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1336 through buffer list if indirection counter is 0.
1337
f8643a6b
DA
13382012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1339
1340 Extend the value returned by Fgarbage_collect with heap statistics.
1341 * alloc.c (Qheap): New symbol.
1342 (syms_of_alloc): DEFSYM it.
1343 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1344 (Fmemory_free): Remove.
1345 (syms_of_alloc): Don't defsubr it.
1346 * buffer.c (Fcompact_buffer): Remove.
1347 (syms_of_buffer): Don't defsubr it.
1348
dac616ff
DA
13492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 Make maybe_gc inline.
1352 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1353 * lisp.h (consing_since_gc, gc_relative_threshold)
1354 (memory_full_cons_threshold): Revert declaration.
1355 (maybe_gc): Remove prototype, define as inline.
1356 * alloc.c: Remove old commented-out code.
1357 (consing_since_gc, gc_relative_threshold)
1358 (memory_full_cons_threshold): Revert to global.
1359 (maybe_gc): Remove.
1360
d7ea76b4
DA
13612012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1362
1363 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1364 * lisp.h (build_unibyte_string): New function.
1365 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1366 * sysdep.c, w32fns.c, xfns.c: Use it.
1367 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1368 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1369 Adjust users accordingly.
1370 * font.h (font_open_by_name): Adjust prototype.
1371
765e61e3
DA
13722012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 Cleanup calls to Fgarbage_collect.
1375 * lisp.h (maybe_gc): New prototype.
1376 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1377 Remove declarations.
1378 * alloc.c (maybe_gc): New function.
1379 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1380 Make them static.
1381 * bytecode.c (MAYBE_GC): Use maybe_gc.
1382 * eval.c (eval_sub, Ffuncall): Likewise.
1383 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1384 to avoid dependency from auto-save feature.
1385
52b852c7
PE
13862012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1389 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1390 'for_each_per_buffer_object_at'.
1391 All uses changed. It's better to use upper-case for macros that
1392 cannot be implemented as functions, to give the reader a clue
1393 that they're special.
1394
5db81e33
SM
13952012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1396
1397 * alloc.c (Fgarbage_collect): Tweak docstring.
1398
5b835e1d
DA
13992012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1400
1401 Tweak the value returned from Fgarbage_collect again.
1402 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1403 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1404 Adjust documentation.
1405 (total_vector_bytes): Rename to total_vector_slots, adjust
1406 accounting.
1407 (total_free_vector_bytes): Rename to total_free_vector_slots,
1408 adjust accounting.
1409 (Qstring_bytes, Qvector_slots): New symbols.
1410 (syms_of_alloc): DEFSYM them.
1411
9cd47b72
DA
14122012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1413
1414 Buffer compaction primitive which may be used from Lisp.
1415 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1416 (syms_of_buffer): Register Fcompact_buffer.
1417 * alloc.c (Fgarbage_collect): Use compact_buffer.
1418 * buffer.h (compact_buffer): New prototype.
1419 (struct buffer_text): New member.
1420
d17337e5
DA
14212012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1422
1423 New macro to iterate over all buffers, miscellaneous cleanups.
1424 * lisp.h (all_buffers): Remove declaration.
1425 * buffer.h (all_buffers): Add declaration, with comment.
1426 (for_each_buffer): New macro.
1427 * alloc.c (Fgarbage_collect, mark_object): Use it.
1428 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1429 (init_buffer): Likewise.
1430 * data.c (Fset_default): Likewise.
1431 * coding.c (code_conversion_restore): Remove redundant check
1432 for dead buffer.
1433 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1434
60cfd278
AS
14352012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1436
1437 Fix bug that created negative-length intervals.
1438 * intervals.c (merge_interval_right, merge_interval_left):
1439 Do not zero out this interval if it is absorbed by its children,
1440 as this interval's total length doesn't change in that case. See
1441 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1442
d06714cb
PE
14432012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1444
83713154
PE
1445 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1446 when invoking (make-bool-vector N t) and N is a positive
1447 multiple of 8 -- the last 8 bits were mistakenly cleared.
1448
d06714cb
PE
1449 Remove some struct layout assumptions in bool vectors.
1450 * alloc.c (bool_header_size): New constant.
1451 (header_size, word_size): Move earlier, as they're now used earlier.
1452 Use 'word_size' in a few more places, where it's appropriate.
1453 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1454 padding before the data member of a bool vector.
1455 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1456 than doing the check by hand with an abort ().
1457
464d5a5e
SM
14582012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1459
5fbc0409
SM
1460 * eval.c (Fdefvar): Don't check constants since we only set the var if
1461 it's not yet defined anyway (bug#11904).
1462
464d5a5e
SM
1463 * lisp.h (last_undo_boundary): Declare new var.
1464 * keyboard.c (command_loop_1): Set it.
1465 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1466 were auto-added by the command loop (bug#11774).
1467
8dc2e44a
AS
14682012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1469
1470 * w32font.c (Qsymbol): Remove local definition.
1471 (syms_of_w32font): Don't DEFSYM it.
1472
169925ec
DA
14732012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 Fix sweep_vectors to handle large bool vectors correctly.
1476 * alloc.c (sweep_vectors): Account total_vector_bytes for
1477 bool vectors larger than VBLOCK_BYTES_MAX.
1478
5fbfb018
CY
14792012-07-18 Chong Yidong <cyd@gnu.org>
1480
1481 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1482 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1483
3ab6e069
DA
14842012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1485
1486 Return more descriptive data from Fgarbage_collect.
1487 Suggested by Stefan Monnier in
1488 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1489 * alloc.c (bounded_number): New function.
1490 (total_buffers, total_vectors): New variable.
1491 (total_string_size): Rename to total_string_bytes, adjust users.
1492 (total_vector_size): Rename to total_vector_bytes, adjust users.
1493 (sweep_vectors): Account total_vectors and total_vector_bytes.
1494 (Fgarbage_collect): New return value. Adjust documentation.
1495 (gc_sweep): Account total_buffers.
1496 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1497 (VECTOR_SIZE): Remove.
1498 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1499 (Qinterval, Qmisc): New symbols.
1500 (syms_of_data): Initialize them.
1501 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1502 (Qcons, Qbuffer): New declarations.
1503
6d02fe5b
PE
15042012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1507 Round up, not down. Improve doc.
1508
b7ffe040
DA
15092012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1510
1511 Restore old code in allocate_string_data to avoid Faset breakage.
1512 Reported by Julien Danjou <julien@danjou.info> in
1513 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1514 * alloc.c (allocate_string_data): Restore old code with minor
1515 adjustments, fix comment to explain this subtle issue.
1516
4dc7c8d5
SM
15172012-07-17 Eli Zaretskii <eliz@gnu.org>
1518
1519 Remove FILE_SYSTEM_CASE.
1520 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1521
1522 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1523 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1524 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1525 call-process-region passes it through expand-file-name.
1526
1527 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1528
15292012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 Fix crash when creating indirect buffer (Bug#11917)
1532 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1533 Don't handle unbound variables specially if non-zero.
1534 (Fbuffer_local_variables): Pass zero.
1535 (clone_per_buffer_values): Pass non-zero.
1536
15372012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1538
1539 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1540 to make the loop interruptible.
1541
15422012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1543
1544 * gnutls.c (emacs_gnutls_handshake): Only retry if
1545 GNUTLS_E_INTERRUPTED.
1546
cce7fefc
DA
15472012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1548
1549 Cleanup and convert miscellaneous checks to eassert.
1550 * alloc.c (mark_interval): Fix comment, partially rephrase
1551 old comment from intervals.h (see below).
1552 * intervals.c (find_interval, adjust_intervals_for_insertion)
1553 (delete_interval, adjust_intervals_for_deletion)
1554 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1555 Convert to eassert.
1556 (adjust_intervals_for_insertion, make_new_interval):
1557 Remove obsolete and unused code.
1558 * intervals.h (struct interval): Remove obsolete comment.
1559 * textprotp.c (erase_properties): Remove unused code.
1560 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1561 (Fremove_list_of_text_properties): Convert to eassert.
1562
9ea10cc3
CY
15632012-07-17 Chong Yidong <cyd@gnu.org>
1564
1565 * editfns.c (Finsert_char): Doc fix.
1566
3900d5de
DA
15672012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1568
1569 Fix previous change to make Fmemory_free always accurate.
1570 * alloc.c (make_interval): Update total_free_intervals.
1571 (make_float): Likewise for total_free_floats.
1572 (free_cons, Fcons): Likewise for total_free_conses.
1573 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1574 Likewise for total_free_vector_bytes.
1575 (Fmake_symbol): Likewise for total_free_symbols.
1576 (bytes_free): Remove.
1577
7098646f
DA
15782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1579
1580 Simple free memory accounting feature.
1581 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1582 (sweep_vectors): Accumulate size of free vectors.
1583 (Fgarbage_collect): Setup bytes_free.
1584 (Fmemory_free): New function.
1585 (syms_of_alloc): Register it.
1586
22657b40
DA
15872012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1588
1589 Cleanup overlays checking.
1590 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1591 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1592 eassert and OVERLAYP.
1593 (sort_overlays): Change to use OVERLAYP.
1594
ddfc8813
RK
15952012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1596
1597 * editfns.c (Finsert_char): Make it interactive, and make the
1598 second arg optional. Copy interactive spec and docstring from
1599 ucs-insert.
1600
7c26cf3c
PE
16012012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1602
1603 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1604 Unlike the other wrapped functions, fabs has an unspecified
1605 effect on errno.
1606
5d127af9
JD
16072012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1608
1609 * nsterm.m (keyDown): Interpret flags without left/right bits
1610 as the left key (Bug#11670).
1611
6a0dd1d7
DA
16122012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1613
1614 Remove empty and useless init functions.
1615 * lisp.h (init_character_once, init_fns, init_image)
1616 (init_filelock, init_sound): Remove prototype.
1617 * character.c (init_character_once): Remove.
1618 * filelock.c (init_filelock): Likewise.
1619 * fns.c (init_fns): Likewise.
1620 * image.c (init_image): Likewise.
1621 * sound.c (init_sound): Likewise.
1622 * emacs.c (main): Adjust accordingly.
1623
7a6136fd
DA
16242012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 * gtkutil.h: Tiny cleanups.
1627 (use_old_gtk_file_dialog): Remove useless declaration.
1628 (xg_uses_old_file_dialog): Add suggested const attribute.
1629
ce811ad9
EZ
16302012-07-15 Eli Zaretskii <eliz@gnu.org>
1631
1632 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1633 (bidi_paragraph_init): Use it to limit search forward for a strong
1634 directional character in abnormally large paragraphs full of
1635 neutral or weak characters. (Bug#11943)
1636
c9adfeaa
SF
16372012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1638
1639 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1640 the toolbar (Bug#9451).
1641 (xg_make_tool_item): Give the widget event box a transparent
1642 background.
1643
fff62aa9
DA
16442012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1645
1646 Cleanup basic allocation variables and functions.
1647 * alloc.c (ignore_warnings, init_intervals, init_float)
1648 (init_cons, init_symbol, init_marker): Remove.
1649 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1650 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1651 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1652 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1653 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1654 (staticidx, init_alloc_once, init_strings, free_ablock):
1655 Remove redundant initialization.
1656 * fns.c (init_weak_hash_tables): Remove.
1657 * lisp.h (init_weak_hash_tables): Remove prototype.
1658
9730daca
DA
16592012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1660
1661 Use zero_vector where appropriate.
1662 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1663 accordingly.
1664 * lisp.h (zero_vector): New declaration.
1665 * font.c (null_vector): Remove.
1666 (syms_of_font): Remove initialization and staticpro.
1667 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1668 * keymap.c (Faccessible_keymaps): Likewise.
1669
2e2d2a13
LL
16702012-07-15 Leo Liu <sdl.web@gmail.com>
1671
1672 * fringe.c: Fix typo in comments.
1673
cd276f6e
LL
16742012-07-14 Leo Liu <sdl.web@gmail.com>
1675
1676 * fringe.c: Add a new bitmap exclamation-mark.
1677
5a1131d9
EZ
16782012-07-14 Eli Zaretskii <eliz@gnu.org>
1679
1680 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1681
1682 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1683 (HAVE_MENUS): Don't define, defined by editing config.in with
1684 msdos/sed2v2.inp.
1685 (GMALLOC_INHIBIT_VALLOC): Don't define.
1686 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1687
22e983b7
JB
16882012-07-14 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1691
5b3f250f
GM
16922012-07-14 Glenn Morris <rgm@gnu.org>
1693
1694 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1695 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1696 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1697
33d63ff4
GM
16982012-07-13 Glenn Morris <rgm@gnu.org>
1699
5b633342
GM
1700 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1701
33d63ff4
GM
1702 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1703 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1704
b55b9f85
JD
17052012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1706
0dc8cf50
JD
1707 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1708 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1709 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1710 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1711 where appropriate.
1712 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1713 as boolean expression.
1714 (x_set_window_size): Remove unused variable toolbar.
1715 (ns_get_color_default, ns_mod_to_lisp): Remove.
1716 (ns_mouse_position): Remove unused variables xchar and ychar.
1717 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1718 (ns_set_vertical_scroll_bar): Remove unused variable count.
1719 (ns_delete_terminal): Remove unused variable i.
1720 (ns_term_init): Remove unused variables r, g and b.
1721 (mouseDown): Remove unused variable window.
1722 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1723 (initFrameFromEmacs): Remove unused variable vbextra.
1724 (mouseEntered): Remove unused variables p and dpyinfo.
1725 (mouseExited): Remove unused variables p and r.
1726 (ns_define_frame_cursor, ns_clear_frame_area)
1727 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1728 (menuDown): Assign [sender tag] to variable and cast the variable.
1729
1730 * nsterm.h (menuDown): Add id as type to argument sender.
1731 (ns_display_info_for_name): Add Lisp_Object argument.
1732 (ns_term_init): Add Lisp_Object argument.
1733 (ns_map_event_to_object): Add void argument.
1734 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1735 prototype with arguments and only declare if __OBJC__.
1736 (nxatoms_of_nsselect): Add void argument.
1737 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1738 (ns_alloc_autorelease_pool): Add void argument.
1739 (ns_release_autorelease_pool): Add void* argument.
1740 (ns_get_defaults_value): Add const char* argument.
1741
1742 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1743 (initFromContents): Use SSDATA where appropriate.
1744 (ns_update_menubar): Add braces to ambigous if-else.
1745 (initWithTitle): Put () around assignment in if statement.
1746 (ns_menu_show): Remove unused variables window and keymap.
1747 (update_frame_tool_bar): Remove unused variable selected_p.
1748 (initWithContentRect): Remove unused variable this_cmd_name.
1749
1750 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1751 appropriate.
1752 (setXBMColor): Remove unused variable len.
1753 (setPixmapData): Put () around assignment in loop statement.
1754
1755 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1756 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1757 where appropriate.
1758 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1759 around assignment in loop statement.
1760 (nsfont_open): Remove unused variable i.
1761 (nsfont_open): Remove unused variable len.
1762 (nsfont_draw): Remove unused variable cs.
1763
1764 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1765 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1766 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1767 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1768 (Fns_font_name, Fns_perform_service)
1769 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1770 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1771 (ns_set_name): Remove unused variable view.
1772 (x_set_menu_bar_lines): Remove unused variable olines.
1773 (x_set_tool_bar_lines): Remove unused variable root_window.
1774 (Fns_list_colors): Put () around assignment in while statement.
1775 (Fns_perform_service): Remove unused variable len.
1776 (Fns_display_usable_bounds): Remove unused variable top.
1777 (syms_of_nsfns): Remove unused variable i.
1778
b55b9f85
JD
1779 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1780 memcpy (Bug#11907).
1781
ed9265fc 17822012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1783
1784 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1785 and free it with DestroyExceptionInfo (Bug#11558).
1786
ef099b57
JB
17872012-07-13 Juanma Barranquero <lekktu@gmail.com>
1788
1789 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1790 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1791 Set here, not in nt/config.nt.
1792
ea814a5d
EZ
17932012-07-13 Eli Zaretskii <eliz@gnu.org>
1794
1795 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1796 cursor overflow into the last glyph on display line when the right
1797 fringe is off. (Bug#11832)
1798
1a952767
PE
17992012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * xdisp.c (produce_special_glyphs): Now static.
1802 * dispextern.h (produce_special_glyphs): Remove decl.
1803
983188fd
GM
18042012-07-13 Glenn Morris <rgm@gnu.org>
1805
8d7c7eed 1806 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1807 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1808
983188fd
GM
1809 * s/usg5-4-common.h (USG, USG5):
1810 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1811 * s/sol2-6.h (SOLARIS2):
1812 * s/irix6-5.h (IRIX6_5):
1813 * s/hpux10-20.h (USG, USG5, HPUX):
1814 * s/gnu-linux.h (USG, GNU_LINUX):
1815 * s/freebsd.h (BSD_SYSTEM):
1816 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1817 * s/cygwin.h (CYGWIN):
1818 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1819 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1820
d1e68667 18212012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1822
1823 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1824
6de0e799
GM
18252012-07-13 Glenn Morris <rgm@gnu.org>
1826
739ae010
GM
1827 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1828
dbee5793
GM
1829 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1830
6de0e799
GM
1831 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1832 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1833
b82da769
GM
18342012-07-12 Glenn Morris <rgm@gnu.org>
1835
4fae5a7a 1836 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1837
1838 * process.c (init_process_emacs): Rename from init_process.
1839 The old name is also the name of a Mach system call.
1840 * lisp.h, emacs.c: Update for this name change.
1841 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1842 longer needed.
1843
5a979817
EZ
18442012-07-12 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1847 memmove call that removes glyphs covered by the left truncation
1848 glyph. Improve commentary.
1849 (display_line): Fix display of continuation glyphs on GUI frames
1850 when the right fringe is turned off and variable-size fonts are
1851 used in the window. Move the code that appends a stretch glyph to
1852 produce_special_glyphs, so that it could be used for truncation
1853 and continuation glyphs alike.
1854 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1855 glyph of a suitably computed width, to align the special glyphs at
1856 the window margin. Code moved from display_line. (Bug#11832)
1857
3e91a053
GM
18582012-07-12 Glenn Morris <rgm@gnu.org>
1859
ba9e4b84
GM
1860 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1861
1862 * s/gnu-linux.h, s/hpux10-20.h:
1863 Do not unconditionally define HAVE_XRMSETDATABASE.
1864
3e91a053
GM
1865 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1866
b300b1f4
PE
18672012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 Fix typos that broke OS X build.
1870 Reported by Randal L. Schwartz in
1871 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1872 * nsterm.m (ns_timeout): Add missing local decl.
1873 (ns_get_color): snprintf -> sprintf, to fix typo.
1874
6e777848
GM
18752012-07-12 Glenn Morris <rgm@gnu.org>
1876
3f922c37
GM
1877 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1878 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1879 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1880 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1881
0ab7b23a
GM
1882 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1883 Move PTY_OPEN to configure.
1884
6e777848
GM
1885 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1886 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1887 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1888
4a7edc24
DA
18892012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1890
1891 Use empty_unibyte_string where applicable.
1892 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1893 * lread.c (read1): Likewise.
1894 * xsettings.c (syms_of_xsettings): Likewise.
1895
308aab79
GM
18962012-07-12 Glenn Morris <rgm@gnu.org>
1897
42bd1719
GM
1898 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1899 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1900 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1901 * s/hpux10-20.h (RUN_TIME_REMAP):
1902 * s/bsd-common.h (TABDLY): Move to configure.
1903
1904 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1905
1906 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1907
ea0bbd17 1908 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1909 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1910
1911 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1912
308aab79
GM
1913 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1914 * s/template.h: Move NARROWPROTO to configure.
1915
ee1cf5cf
GM
19162012-07-11 Glenn Morris <rgm@gnu.org>
1917
30fe9bf4
GM
1918 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1919 unused since 2011-01-17 change to systty.h.
1920
ee1cf5cf
GM
1921 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1922 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1923 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1924
63e47e07
PE
19252012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1928
c43fb4c3
GM
19292012-07-11 Glenn Morris <rgm@gnu.org>
1930
1931 * s/darwin.h, s/gnu-linux.h, s/template.h:
1932 Move INTERRUPT_INPUT to configure.
1933
e8df9267
DA
19342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1935
1936 Minor adjustments to interning code.
1937 * lisp.h (intern, intern_c_string): Redefine as static inline
1938 wrappers for intern_1 and intern_c_string_1, respectively.
1939 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1940 * lread.c (intern_1, intern_c_string_1, oblookup):
1941 Simplify Vobarray checking.
e8df9267
DA
1942 * font.c (font_intern_prop): Likewise. Adjust comment.
1943 * w32font.c (intern_font_name): Likewise.
1944
34348bd4
AS
19452012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1946
d96a1e0c
AS
1947 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1948
34348bd4
AS
1949 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1950 of Fcar/Fcdr if possible.
1951 * font.c (check_otf_features): Likewise.
1952 * fontset.c (Fnew_fontset): Likewise.
1953 * gnutls.c (Fgnutls_boot): Likewise.
1954 * minibuf.c (read_minibuf): Likewise.
1955 * msdos.c (IT_set_frame_parameters): Likewise.
1956 * xmenu.c (Fx_popup_dialog): Likewise.
1957 * w32menu.c (Fx_popup_dialog): Likewise.
1958
c8add24e
GM
19592012-07-11 Glenn Morris <rgm@gnu.org>
1960
4b575b3c
GM
1961 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1962 since nothing has defined it on these platforms.
1963
09f4e3b0
GM
1964 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1965 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1966
172bedef
GM
1967 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1968 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1969 Move CLASH_DETECTION to configure.
1970
249685df
GM
1971 * s/gnu.h: Remove file, which is now empty.
1972
c8add24e
GM
1973 * s/gnu.h, s/gnu-linux.h:
1974 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1975
b41253a3
JW
19762012-07-11 John Wiegley <johnw@newartisans.com>
1977
1978 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1979 function attribute, so we only use it if it exists in the
1980 compiler.
1981
d923b542
DA
19822012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1983
1984 Avoid call to strlen in fast_c_string_match_ignore_case.
1985 * search.c (fast_c_string_match_ignore_case): Change to use
1986 length argument. Adjust users accordingly.
1987 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1988
5ebbef1d
PE
19892012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1990
bb352260
PE
1991 Assume mkdir, rmdir.
1992 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1993 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1994
57054ddd
PE
1995 Assume rename.
1996 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1997
b747d3f7
PE
1998 Assume perror.
1999 * s/hpux10-20.h (HAVE_PERROR): Remove.
2000 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2001 Remove dummy definition, as this problem was obsolete long ago.
2002
5ebbef1d
PE
2003 Assume strerror.
2004 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2005
984e7f30
DA
20062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2007
2008 Avoid calls to strlen in font processing functions.
2009 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2010 (font_open_by_name): Change to use length argument.
2011 Adjust users accordingly.
d923b542
DA
2012 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2013 Adjust prototypes.
2014 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2015 Change to return ptrdiff_t.
984e7f30
DA
2016 (xfont_list_pattern, xfont_match): Use length returned by
2017 xfont_decode_coding_xlfd.
2018 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2019
20e94fdd
GM
20202012-07-11 Glenn Morris <rgm@gnu.org>
2021
9d596af3
GM
2022 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2023 Move DONT_REOPEN_PTY to configure.
2024
20e94fdd
GM
2025 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2026 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2027
e99a530f
PE
20282012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2029
22ffb973
PE
2030 Remove "#define unix" that is no longer needed (Bug#11905).
2031 * s/aix4-2.h (unix): Remove; no longer needed.
2032
e9a9ae03
PE
2033 EMACS_TIME simplification (Bug#11875).
2034 This replaces macros (which typically do not work in GDB)
2035 with functions, typedefs and enums, making the code easier to debug.
2036 The functional style also makes code easier to read and maintain.
2037 * systime.h: Include <sys/time.h> on all hosts, not just if
2038 WINDOWSNT, since 'struct timeval' is needed in general.
2039 (EMACS_TIME): Now a typedef, not a macro.
2040 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2041 not macros.
2042 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2043 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2044 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2045 (EMACS_TIME_LE): Now functions, not macros.
2046 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2047 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2048 which are not functions. All uses rewritten to use:
2049 (make_emacs_time): New function.
2050 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2051 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2052 not functions. All uses rewritten to use the following, respectively:
2053 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2054 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2055 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2056 * fileio.c (Fcopy_file):
2057 * xterm.c (XTflash): Get the current time closer to when it's used.
2058 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2059
ffacb126
PE
2060 * bytecode.c (targets): Suppress -Woverride-init warnings.
2061
e99a530f
PE
2062 Simplify by avoiding confusing use of strncpy etc.
2063 * doc.c (Fsnarf_documentation):
2064 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2065 * frame.c (Fmake_terminal_frame):
2066 * gtkutil.c (get_utf8_string):
2067 * lread.c (openp):
2068 * nsmenu.m (ns_update_menubar):
2069 * regex.c (regerror):
2070 Prefer memcpy to strncpy and strncat when either will do.
2071 * fileio.c (Fsubstitute_in_file_name):
2072 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2073 (menu_separator_name_p):
2074 * nsmenu.m (ns_update_menubar):
2075 Prefer memcmp to strncmp when either will do.
2076 * nsterm.m: Include <ftoastr.h>.
2077 (ns_get_color):
2078 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2079 Prefer snprintf to strncpy.
2080 * nsterm.m (ns_term_init):
2081 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2082 * nsterm.m (ns_term_init):
2083 Avoid the need for strncpy, by using build_string or
2084 make_unibyte_string directly. Use dtoastr, not snprintf.
2085 * process.c (Fmake_network_process): Diagnose service names that
2086 are too long, rather than silently truncating them or creating
2087 non-null-terminated names.
2088 (Fnetwork_interface_info): Likewise, for interface names.
2089 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2090 Prefer sprintf to strncat.
2091 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2092 Prefer vsnprintf to vsprintf + strncpy.
2093
c59592b3
GM
20942012-07-10 Glenn Morris <rgm@gnu.org>
2095
2096 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2097 Clarify fallback case.
2098
7d7bbefd
DA
20992012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2100
2101 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2102 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2103 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2104 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2105 where argument type is known to be a Lisp_Cons.
2106
3a4c8000
TT
21072012-07-10 Tom Tromey <tromey@redhat.com>
2108
2109 * bytecode.c (BYTE_CODE_THREADED): New macro.
2110 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2111 (enum byte_code_op): New type.
2112 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2113 (exec_byte_code): Use them. Use token threading when applicable.
2114
2a0213a6
DA
21152012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2116
2117 Optimize pure C strings initialization.
2118 * lisp.h (make_pure_string): Fix prototype.
2119 (build_pure_c_string): New function, defined as static inline. This
2120 provides a better opportunity to optimize away calls to strlen when
2121 the function is called with compile-time constant argument.
2122 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2123 argument, adjust users accordingly. Use build_pure_c_string where
2124 appropriate.
2125 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2126 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2127 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2128
cb1caeaf
DA
21292012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2130
2131 Avoid calls to strlen in miscellaneous functions.
2132 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2133 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2134 * lread.c (openp): Likewise.
2135
c293e30c
DA
21362012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 Avoid calls to strlen in path processing functions.
2139 * fileio.c (file_name_as_directory): Add comment. Change to add
2140 srclen argument and return the length of result. Adjust users
2141 accordingly.
2142 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2143 swap 1st and 2nd arguments to obey the common convention.
2144 Adjust users accordingly.
c293e30c
DA
2145 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2146
9e059e3f
GM
21472012-07-10 Glenn Morris <rgm@gnu.org>
2148
d02eb359
GM
2149 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2150 Move PENDING_OUTPUT_COUNT definition to configure.
2151
882cf227
GM
2152 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2153 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2154 * s/gnu.h (DATA_START): Move definitions to configure.
2155
af6e839f
GM
2156 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2157 We include usg5-4-common.h, which defines them both.
2158
40289a12
GM
2159 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2160 O_RDONLY already includes it).
2161
9e059e3f
GM
2162 Stop ns builds setting the EMACSLOADPATH environment variable.
2163 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2164 Now it does not set EMACSLOADPATH, just returns the load-path string.
2165 * nsterm.h: Update accordingly.
2166 * lread.c [HAVE_NS]: Include nsterm.h.
2167 (init_lread) [HAVE_NS]: Use ns_load_path.
2168 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2169
7c4e8ec0
GM
21702012-07-09 Glenn Morris <rgm@gnu.org>
2171
d4f600ff
GM
2172 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2173 since the included bsd-common.h does so.
2174
cbb31951
GM
2175 Stop ns builds setting the EMACSPATH environment variable.
2176 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2177 (ns_init_paths): Do not set EMACSPATH.
2178 * nsterm.h (ns_exec_path): Add it.
2179 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2180 Use ns_exec_path.
2181
7c4e8ec0
GM
2182 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2183
26bccfae
PE
21842012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2185
a0bee46f
PE
2186 * process.c (wait_reading_process_output): 'waitchannels' was unset
2187 when read_kbd || !NILP (wait_for_cell); fix this.
2188
5994c183
PE
2189 Add GCC-style 'const' attribute to functions that can use it.
2190 * character.h (char_resolve_modifier_mask):
2191 * keyboard.h (make_ctrl_char):
2192 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2193 (init_character_once, next_almost_prime, init_fns, init_image)
2194 (flush_pending_output, init_sound):
2195 * mem-limits.h (start_of_data):
2196 * menu.h (finish_menu_items):
2197 Add ATTRIBUTE_CONST.
2198 * emacs.c (DEFINE_DUMMY_FUNCTION):
2199 Declare the dummy function with ATTRIBUTE_CONST.
2200 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2201 Add decls with ATTRIBUTE_CONST.
2202
26bccfae
PE
2203 Minor improvements to make_formatted_string.
2204 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2205 where int is good enough, as vsprintf returns an int.
2206 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2207
a8290ec3
DA
22082012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2209
2210 Use make_formatted_string to avoid double length calculation.
2211 * lisp.h (make_formatted_string): New prototype.
2212 * alloc.c (make_formatted_string): New function.
2213 * buffer.c (Fgenerate_new_buffer_name): Use it.
2214 * dbus.c (syms_of_dbusbind): Likewise.
2215 * editfns.c (Fcurrent_time_zone): Likewise.
2216 * filelock.c (get_boot_time): Likewise.
2217 * frame.c (make_terminal_frame, set_term_frame_name)
2218 (x_report_frame_params): Likewise.
2219 * image.c (gs_load): Likewise.
2220 * minibuf.c (get_minibuffer): Likewise.
2221 * msdos.c (dos_set_window_size): Likewise.
2222 * process.c (make_process): Likewise.
2223 * xdisp.c (ensure_echo_area_buffers): Likewise.
2224 * xsettings.c (apply_xft_settings): Likewise.
2225
d01ba2f1
GM
22262012-07-09 Glenn Morris <rgm@gnu.org>
2227
2228 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2229 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2230 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2231 * nsterm.h (ns_etc_directory): Add it.
2232 * callproc.c [HAVE_NS]: Include nsterm.h.
2233 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2234
f1f924b6
DA
22352012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2236
2237 Move marker debugging code under MARKER_DEBUG.
2238 * marker.c (MARKER_DEBUG): Move marker debugging code under
2239 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2240 for bootstrap with --enable-checking (~3x slowdown reported
2241 by Juanma Barranquero <lekktu@gmail.com>).
2242 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2243
ab531b66
PE
22442012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2247 See <http://bugs.gnu.org/11825#29>.
2248
c4b3bc8a
EZ
22492012-07-08 Eli Zaretskii <eliz@gnu.org>
2250
2251 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2252 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2253 (display_line): Add commentary about displaying truncation glyphs
2254 on GUI frames.
2255 (produce_special_glyphs): Move here from term.c.
2256
2257 * term.c (produce_special_glyphs): Move to xdisp.c.
2258
2259 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2260 section.
c4b3bc8a 2261
b676b881
AS
22622012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2263
f17c5273
AS
2264 * xdisp.c (display_line): Avoid warning about implicit declaration
2265 of FRAME_FONT.
2266
298819b9
AS
2267 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2268
b676b881
AS
2269 * lisp.h: Remove empty conditional.
2270
6045c4fd
PE
22712012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2272
b3350bf9
PE
2273 * lread.c (load_path_check): Now static.
2274
6045c4fd
PE
2275 Fix some minor --with-ns problems found by static checking.
2276 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2277 (x_set_font) [!HAVE_X_WINDOWS]:
2278 * image.c (xpm_load_image) [HAVE_NS]:
2279 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2280 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2281 Remove unused local.
2282 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2283 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2284 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2285 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2286 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2287 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2288 Fix pointer signedness problem.
2289 * xfaces.c (FRAME_X_FONT_TABLE):
2290 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2291
929e7845
GM
22922012-07-07 Glenn Morris <rgm@gnu.org>
2293
2294 * lread.c (load_path_check): New function, split from init_lread.
2295 (init_lread): Reorganize. Motivation:
2296 If EMACSLOADPATH is set, check/warn about that rather than the
2297 defaults, which we are not going to use. Hence we can remove
2298 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2299 Don't warn if site-lisp directories are missing.
2300 If not installed, start from a blank load-path, since
2301 PATH_LOADSEARCH refers to the eventual installation directories.
2302
58dd0aa4
EZ
23032012-07-07 Eli Zaretskii <eliz@gnu.org>
2304
2305 Support truncation and continuation glyphs on GUI frames, when
2306 fringes are disabled. (Bug#11832)
2307 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2308 continuation glyphs even if on GUI frames.
2309 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2310 or both, are absent.
2311 (start_display, move_it_in_display_line_to): Handle the case of a
2312 GUI frame without a fringe to display continuation or truncation
2313 glyphs.
2314 (insert_left_trunc_glyphs): Support GUI frames: make sure
2315 truncation glyphs overwrite enough glyphs from the current line to
2316 have sufficient space in pixels.
2317 (display_line): Support truncation and continuation glyphs on GUI
2318 frames. If some spare pixels are left on the line after inserting
2319 the truncation glyphs, fill that space with a stretch glyph of a
2320 suitably computed width.
2321
2322 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2323 produce_glyphs, to support GUI sessions.
2324
31571fd7
PE
23252012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2326
5a16b9bc
PE
2327 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2328
f3047c75
PE
2329 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2330
31571fd7
PE
2331 Do not require float-time's arg to fit in time_t (Bug#11825).
2332 This works better on hosts where time_t is unsigned, and where
2333 float-time is applied to the (negative) difference between two times.
2334 * editfns.c (decode_time_components): Last arg is now double *,
2335 not int *, and means to store all the result as a double, without
2336 worrying about whether the seconds part fits in time_t.
2337 All callers changed.
2338 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2339 All callers changed.
2340 (Ffloat_time): Do not fail merely because the specified time falls
2341 outside of time_t range.
2342
4516fbef
GM
23432012-07-07 Glenn Morris <rgm@gnu.org>
2344
2345 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2346 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2347 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2348
07adc2c6
JB
23492012-07-07 Juanma Barranquero <lekktu@gmail.com>
2350
2351 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2352 Update dependencies.
2353
2354 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2355
fd573f31
PE
23562012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2357
fee5959d
PE
2358 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2359 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2360 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2361 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2362 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2363 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2364
fd573f31
PE
2365 * xfont.c (compare_font_names): Redo to omit the need for casts.
2366
ddadbc0e
AS
23672012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2368
fca8d6b6
AS
2369 * xfns.c (Fx_change_window_property): Doc fix.
2370 * w32fns.c (Fx_change_window_property): Doc fix.
2371
ddadbc0e
AS
2372 * w32fns.c (Fx_window_property): Accept the same arguments as the
2373 X Windows version. Doc fix.
2374 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2375
ed9265fc 23762012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2377 Eli Zaretskii <eliz@gnu.org>
2378
2379 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2380 Windows-specific code from nt/config.nt moved here.
2381 Obsolete settings removed.
2382
216ee680
PE
23832012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 * process.c: Avoid unnecessary calls to gettime.
2386 (wait_reading_process_output): Don't get the time of day
2387 when gobbling data immediately and not waiting, as there's no need
2388 for it in that case. This removes a FIXME.
2389
bdd091e4
JD
23902012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2391
2392 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2393 is defined (Bug#11768).
2394
9d44f8ce
DA
23952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2396
2397 Fix marker debugging code.
2398 * marker.c (byte_char_debug_check): Do not perform the check
2399 if buffer is not multibyte.
090bd7cb
JB
2400 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2401 Call byte_char_debug_check with correct arguments.
9d44f8ce 2402
90fc4786
DA
24032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2404
2405 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2406 * marker.c (byte_char_debug_check, count_markers):
2407 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2408 (byte_debug_flag): Remove.
2409 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2410 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2411
7b7ae965
DA
24122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2413
4e57b342
DA
2414 Avoid code repetition in marker-related functions.
2415 * marker.c (attach_marker): New function.
2416 (Fset_marker, set_marker_restricted, set_marker_both)
2417 (set_marker_restricted_both): Use it.
2418 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2419 Consistently rename charno to charpos.
2420 (marker_position): Add eassert.
2421 (marker_byte_position): Convert to eassert.
2422
24232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2424
2425 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2426 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2427 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2428
657924ff
DA
24292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2430
2431 Introduce fast path for the widely used marker operation.
2432 * alloc.c (build_marker): New function.
2433 * lisp.h (build_marker): New prototype.
2434 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2435 * composite.c (autocmp_chars): Likewise.
2436 * editfns.c (buildmark): Remove.
2437 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2438 (save_restriction_save): Use build_marker.
2439 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2440 * window.c (save_window_save): Likewise.
2441
041a49a6
DA
24422012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2443
2444 Do not use Fdelete_overlay in delete_all_overlays
2445 to avoid redundant calls to unchain_overlay.
2446 * buffer.c (drop_overlay): New function.
2447 (delete_all_overlays, Fdelete_overlay): Use it.
2448 * minibuf.c (get_minibuffer): Fix comment.
2449
7dca65a4
PE
24502012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 Port to OpenBSD 5.1 amd64.
2453 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2454 This is needed for OpenBSD, and should be harmless on all BSD systems.
2455 Also, include <sys/sysctl.h>, as it should be available on all
2456 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2457 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2458 use p_pid member, not kp_proc.pid.
2459
8eb876e2
GM
24602012-07-06 Glenn Morris <rgm@gnu.org>
2461
2462 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2463
38182d90
PE
24642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 More xmalloc and related cleanup.
2467 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2468 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2469 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2470 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2471 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2472 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2473 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2474 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2475 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2476 * xterm.c:
2477 Omit needless casts involving void * pointers and allocation.
2478 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2479 as the former is more robust if P's type is changed.
2480 Prefer xzalloc to xmalloc + memset 0.
2481 Simplify malloc-or-realloc to realloc.
2482 Don't worry about xmalloc returning a null pointer.
2483 Prefer xstrdup to xmalloc + strcpy.
2484 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2485 growing it.
2486 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2487 alloca of a constant.
2488
6dd5a677
EZ
24892012-07-05 Eli Zaretskii <eliz@gnu.org>
2490
2491 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2492 hscroll is larger than the line width. Fixes long and futile
2493 looping inside extend_face_to_end_of_line (on a TTY) producing
2494 glyphs that are not needed and thrown away.
2495
6b312f0f
DA
24962012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2497
2498 * marker.c (set_marker_restricted_both): Simplify by using
2499 clip_to_bounds.
2500
f520ef9b
PE
25012012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2504
383b7c95
JD
25052012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2506
2507 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2508 not defined (Bug#11768).
2509 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2510 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2511 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2512 followed by gtk_box_set_homogeneous (Bug#11768).
2513 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2514 (update_theme_scrollbar_width, xg_create_scroll_bar):
2515 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2516 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2517 (is_box_type): New function (Bug#11768).
2518 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2519 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2520 with default display (Bug#11768).
2521
d6e7bf45
EZ
25222012-07-05 Eli Zaretskii <eliz@gnu.org>
2523
2524 * xdisp.c (window_hscroll_limited): New function.
2525 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2526 coordinates when window's hscroll is set to insanely large
2527 values. (Bug#11857)
2528
431391ec
JB
25292012-07-05 Juanma Barranquero <lekktu@gmail.com>
2530
2531 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2532 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2533
23f86fce
DA
25342012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2535
2536 Cleanup xmalloc.
2537 * lisp.h (xzalloc): New prototype. Omit needless casts.
2538 * alloc.c (xzalloc): New function. Omit needless casts.
2539 * charset.c: Omit needless casts. Convert all calls to
2540 xmalloc with following memset to xzalloc.
2541 * dispnew.c: Likewise.
2542 * fringe.c: Likewise.
2543 * image.c: Likewise.
2544 * sound.c: Likewise.
2545 * term.c: Likewise.
2546 * w32fns.c: Likewise.
2547 * w32font.c: Likewise.
2548 * w32term.c: Likewise.
2549 * xfaces.c: Likewise.
2550 * xfns.c: Likewise.
2551 * xterm.c: Likewise.
2552 * atimer.c: Omit needless casts.
2553 * buffer.c: Likewise.
2554 * callproc.c: Likewise.
2555 * ccl.c: Likewise.
2556 * coding.c: Likewise.
2557 * composite.c: Likewise.
2558 * doc.c: Likewise.
2559 * doprnt.c: Likewise.
2560 * editfns.c: Likewise.
2561 * emacs.c: Likewise.
2562 * eval.c: Likewise.
2563 * filelock.c: Likewise.
2564 * fns.c: Likewise.
2565 * gtkutil.c: Likewise.
2566 * keyboard.c: Likewise.
2567 * lisp.h: Likewise.
2568 * lread.c: Likewise.
2569 * minibuf.c: Likewise.
2570 * msdos.c: Likewise.
2571 * print.c: Likewise.
2572 * process.c: Likewise.
2573 * region-cache.c: Likewise.
2574 * search.c: Likewise.
2575 * sysdep.c: Likewise.
2576 * termcap.c: Likewise.
2577 * terminal.c: Likewise.
2578 * tparam.c: Likewise.
2579 * w16select.c: Likewise.
2580 * w32.c: Likewise.
2581 * w32reg.c: Likewise.
2582 * w32select.c: Likewise.
2583 * w32uniscribe.c: Likewise.
2584 * widget.c: Likewise.
2585 * xdisp.c: Likewise.
2586 * xmenu.c: Likewise.
2587 * xrdb.c: Likewise.
2588 * xselect.c: Likewise.
2589
0497dc44
PE
25902012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * fileio.c (time_error_value): Check the right error number.
2593 Problem reported by Troels Nielsen in
2594 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2595
356e7178
PE
25962012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2597
4e71fd89
PE
2598 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2599 This should be fixed in a better way; see Eli Zaretskii in
2600 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2601 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2602
f0941253
PE
2603 * fileio.c (time_error_value): Rename from special_mtime.
2604 The old name's problems were noted by Eli Zaretskii in
2605 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2606
065c9eb4
PE
2607 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2608 This variable's comment says Emacs needs at least one GDB-visible
2609 symbol of type enum pvec_type, to work around GDB problems.
2610 The symbol's value doesn't matter.
2611
356e7178
PE
2612 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2613 that causes compilation to fail on pre-C99 compilers.
2614
ed9265fc 26152012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2616
2617 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2618 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2619
3884d954
DA
26202012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2621
d209e2fb 2622 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2623 headers for buffer_defaults and buffer_local_symbols.
2624 Reported by Juanma Barranquero <lekktu@gmail.com>.
2625
ee28be33
SM
26262012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2627
2628 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2629 * lisp.h (enum pvec_type): Use fewer bits.
2630 (PSEUDOVECTOR_SIZE_BITS): New constant.
2631 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2632 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2633 change in pvec_type.
2634 (PSEUDOVECTOR_TYPEP): New macro.
2635 (TYPED_PSEUDOVECTORP): Use it.
2636 * fns.c (internal_equal): Adapt code to extract pvectype.
2637 * emacs.c (gdb_pvec_type): Update type.
2638 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2639 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2640 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2641 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2642 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2643 abusing vector->header.next.nbytes.
2644 (live_vector_p): Use PVEC_TYPE.
2645 (mark_object): Adapt code to extract pvectype. Use switch.
2646
c7f2cd7f
PE
26472012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2650 Tighten new eassert a bit.
2651
8ce70ed2
DA
26522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2653
2654 Fix compilation with --enable-gcc-warnings and -O1
2655 optimization level.
2656 * doprnt.c (doprnt): Change type of tem to int, initialize
2657 to avoid compiler warning. Add eassert.
2658 * search.c (simple_search): Initialize match_byte to avoid
2659 compiler warning. Add eassert.
2660
dea7f1e5
PE
26612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2662
24a212eb
PE
2663 Avoid weird behavior with large horizontal scrolls.
2664 Without this change, for example, large hscroll values would
2665 mess up Emacs's display on Fedora 15 x86, presumably due to
2666 overflows in int calculations in the display code.
2667 Also, if buffers had long lines, Emacs would freeze.
2668 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2669 (set_window_hscroll): New function, containing the old guts of
2670 Fset_window_hscroll. Return the clipped value.
2671 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2672 This avoids the need to check against PTRDIFF_MAX.
2673
dea7f1e5
PE
2674 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2675
76046526
DA
26762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2677
2678 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2679
39adff0d
PE
26802012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2681
63807d47
PE
2682 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2683 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2684 since GCC 4.4.6 issues a bogus warning for them.
2685
39adff0d
PE
2686 Fix bugs in file timestamp newness comparisons.
2687 * fileio.c (Ffile_newer_than_file_p):
2688 * lread.c (Fload): Use full timestamp resolution of files,
2689 not just the 1-second resolution, so that files that are only
2690 slightly newer still count as newer.
2691 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2692 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2693
dbeed9a6
PE
26942012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2695
2696 * fileio.c: Improve handling of file time marker. (Bug#11852)
2697 (special_mtime): New function.
2698 (Finsert_file_contents, Fverify_visited_file_modtime):
2699 Use it to set special mtime values consistently.
2700
636334d6
AS
27012012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2702
2703 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2704 marker for non-existing file. (Bug#11852)
2705
e2017fe2
GM
27062012-07-03 Glenn Morris <rgm@gnu.org>
2707
2708 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2709 and did not make it into globals.h).
2710
404dbd37
TT
27112012-07-03 Tom Tromey <tromey@redhat.com>
2712
2713 * window.c (Fset_window_margins, Fset_window_fringes)
2714 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2715 * textprop.c (Fprevious_property_change): No longer static.
2716 * syntax.c (Fsyntax_table_p): No longer static.
2717 * process.c (Fget_process, Fprocess_datagram_address): No longer
2718 static.
2719 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2720 * keyboard.c (Fcommand_execute): No longer static.
2721 Remove EXFUN.
2722 * insdel.c (Fcombine_after_change_execute): No longer static.
2723 * image.c (Finit_image_library): No longer static.
2724 * fileio.c (Fmake_symbolic_link): No longer static.
2725 * eval.c (Ffetch_bytecode): No longer static.
2726 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2727 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2728 No longer static.
404dbd37
TT
2729 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2730 static.
2731 * dired.c (Ffile_attributes): No longer static.
2732 * composite.c (Fcomposition_get_gstring): No longer static.
2733 * callproc.c (Fgetenv_internal): No longer static.
2734
2735 * ccl.h: Remove EXFUNs.
2736 * buffer.h: Remove EXFUNs.
2737 * dispextern.h: Remove EXFUNs.
2738 * intervals.h: Remove EXFUNs.
2739 * fontset.h: Remove EXFUN.
2740 * font.h: Remove EXFUNs.
2741 * dosfns.c (system_process_attributes): Remove EXFUN.
2742 * keymap.h: Remove EXFUNs.
2743 * lisp.h: Remove EXFUNs.
2744 * w32term.h: Remove EXFUNs.
2745 * window.h: Remove EXFUNs.
2746 * xsettings.h: Remove EXFUN.
2747 * xterm.h: Remove EXFUN.
2748
8e4fd1e1
GM
27492012-07-03 Glenn Morris <rgm@gnu.org>
2750
2751 * lisp.h (Frandom): Make it visible to C.
2752 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2753 buffer for invisible buffers. (Bug#1229)
2754
ca95b3eb
DA
27552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2756
2757 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2758 values which aren't power of 2.
14ae4239
BT
2759 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2760 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2761 accordingly.
2762
7555c33f
SM
27632012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2764
2765 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2766
2767 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2768
d12e8f5a
DA
27692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2770
2771 * alloc.c (allocate_vector_block): Remove redundant
2772 calls to mallopt if DOUG_LEA_MALLOC is defined.
2773 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2774 avoid calls to mallopt if zero_vector is returned.
2775
296094c3
DA
27762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2777
2778 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2779 is enabled, avoid dereferencing NULL current_sblock if
2780 running undumped.
2781
36429c89
DA
27822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2783
2784 Cleanup basic buffer management.
2785 * buffer.h (struct buffer): Change layout to use generic vector
2786 marking code. Fix some comments. Change type of 'clip_changed'
2787 to bitfield. Remove unused #ifndef old.
2788 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2789 (GET_OVERLAYS_AT): Fix indentation.
2790 (for_each_per_buffer_object_at): New macro.
2791 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2792 (Fbuffer_local_variables): Use it.
2793 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2794 * alloc.c (allocate_buffer): Adjust to match new layout of
2795 struct buffer. Fix comment.
2796 (mark_overlay): New function.
2797 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2798 Lisp area of struct buffer.
2799 (mark_object): Use it. Adjust marking of misc objects
2800 and related comments.
2801
3b3e4cac
PE
28022012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2805 wrapper that is not needed because the wrapped code is a no-op (zero
2806 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2807 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2808
cf5c0175
DA
28092012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2810
2811 * alloc.c (mark_buffer): Simplify. Remove prototype.
2812 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2813 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2814 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2815 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2816
ca26824c
GM
28172012-06-30 Glenn Morris <rgm@gnu.org>
2818
2e4c5312
GM
2819 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2820
ca26824c
GM
2821 * epaths.in (PATH_SITELOADSEARCH): New.
2822 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2823 This is rather than relying on --enable-locallisppath elements
2824 having "site-lisp" in their names. (Bug#10208#25, 11658)
2825
0d23c240
EZ
28262012-06-30 Eli Zaretskii <eliz@gnu.org>
2827
c9240d7a
EZ
2828 * w32proc.c (sys_select): Accept and ignore one more argument.
2829
2830 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2831
0d23c240 2832 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2833 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2834
2835 * sysdep.c: Don't include dos.h and dosfns.h.
2836
2837 * process.c (sys_select):
2838 * msdos.c (sys_select): Accept one more argument and ignore it.
2839
2840 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2841 adapt data types and code to that.
2842
2843 * dosfns.c:
2844 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2845 which clashes with the gnulib function of the same name.
2846
af5a5a98
AS
28472012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2848
c5e4379c
AS
2849 * font.c (font_style_to_value, font_style_symbolic)
2850 (font_prop_validate_style): Add type checks for values in
2851 font_style_table.
2852
af5a5a98
AS
2853 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2854 argument.
2855 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2856 uses.
2857
8d38f461
EZ
28582012-06-29 Eli Zaretskii <eliz@gnu.org>
2859
2e5a6631
EZ
2860 * xdisp.c (try_window_id): Undo last change.
2861
8d38f461
EZ
2862 * w32.c (getwd): Adjust commentary about startup_dir.
2863 (init_environment): Always call sys_access, even in non-MSVC
2864 builds. Don't chdir to the directory of the Emacs executable.
2865 This undoes code from 1997 which was justified by the need to
2866 "avoid conflicts when removing and renaming directories". But its
2867 downside was that every relative file name was being interpreted
2868 relative to the directory of the Emacs executable, which can never
2869 be TRT. In particular, it broke sys_access when called with
2870 relative file names.
2871 (sys_access): Map GetLastError to errno.
2872
2af3565e
DA
28732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2874
2875 * window.h (struct window): Change type of 'fringes_outside_margins'
2876 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2877 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2878 Adjust comment.
2879 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2880 to ptrdiff_t.
2881
c8d3a25c 28822012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2883
c8d3a25c
GM
2884 * gnutls.c (emacs_gnutls_handshake):
2885 Add QUIT to make the loop interruptible.
57570cd3 2886
c8d3a25c 28872012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2888
c8d3a25c
GM
2889 * charset.c (init_charset): Make lack of etc/charsets fatal.
2890
3e984ee8
DA
28912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2892
2893 * editfns.c (region_limit): Fix type mismatch.
2894
ef884f23
DA
28952012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2896
2897 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2898 undefined. Convert from xassert to eassert.
2899 * nsmenu.m: Convert from xassert to eassert.
2900 * nsterm.m: Likewise.
2901
7d7e0027
SM
29022012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2903
2904 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2905
aa754e6a
PE
29062012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 Avoid integer overflow on scroll-left and scroll-right.
2909 * window.c (HSCROLL_MAX): New macro.
2910 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2911 overflow when requested scroll falls outside ptrdiff_t range.
2912
80b00b08
DA
29132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2914
2915 * window.h (struct window): Change type of 'hscroll',
2916 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2917 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2918 Adjust users accordingly.
2919 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2920 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2921 from EMACS_INT to ptrdiff_t.
2922 (make_window): Omit redundant initialization.
2923
62b2bcf6
JB
29242012-06-28 Juanma Barranquero <lekktu@gmail.com>
2925
2926 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2927
45942c7d
DA
29282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2929
2930 * window.h (struct window): Change type of 'use_time' and
2931 'sequence_number' from Lisp_Object to int.
2932 * frame.c (make_frame): Adjust users accordingly.
2933 * print.c (print_object): Likewise.
2934 * window.c (select_window, Fwindow_use_time, make_parent_window)
2935 (make_window): Likewise.
2936
e509cfa6
DA
29372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2938
2939 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2940 enabled with --enable-checking=[all,glyphs] configure option.
2941 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2942 adjust comments accordingly.
2943 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2944 undefined, adjust comments accordingly.
2945 * image.c: Likewise.
2946 * scroll.c: Likewise.
2947 * w32fns.c: Likewise.
2948 * w32term.c: Likewise.
2949 * xdisp.c: Likewise.
2950 * xfaces.c: Likewise.
2951 * xfns.c: Likewise.
2952 * xterm.c: Likewise.
2953
a54e2c05
DA
29542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2955
2956 Generalize run-time debugging checks.
2957 * dispextern.h (XASSERTS): Remove.
2958 * fontset.c (xassert): Remove.
2959 Convert from xassert to eassert.
2960 * alloc.c: Convert from xassert to eassert.
2961 * bidi.c: Likewise.
2962 * dispnew.c: Likewise.
2963 * fns.c: Likewise.
2964 * fringe.c: Likewise.
2965 * ftfont.c: Likewise.
2966 * gtkutil.c: Likewise.
2967 * image.c: Likewise.
2968 * keyboard.c: Likewise.
2969 * menu.c: Likewise.
2970 * process.c: Likewise.
2971 * scroll.c: Likewise.
2972 * sound.c: Likewise.
2973 * term.c: Likewise.
2974 * w32console.c: Likewise.
2975 * w32fns.c: Likewise.
2976 * w32term.c: Likewise.
2977 * window.c: Likewise.
2978 * xdisp.c: Likewise.
2979 * xfaces.c: Likewise.
2980 * xfns.c: Likewise.
2981 * xselect.c: Likewise.
2982 * xterm.c: Likewise.
2983
1ec4b7b2
SM
29842012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2985
2986 * fns.c (maybe_resize_hash_table): Output message when growing the
2987 purify-hashtable.
2988
2014308a
DA
29892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2990
2991 * alloc.c (allocate_string_data): Remove dead code.
2992 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2993 avoid GCC warning about unused macro.
2994
246155eb
DA
29952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2996
2997 * alloc.c (allocate_string): Omit intervals initialization.
2998 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2999 as in make_pure_string and make_pure_c_string.
3000
43184b7b
DA
30012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3002
d209e2fb 3003 * alloc.c (allocate_string): Fix last change.
43184b7b 3004
3fe6dd74
DA
30052012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3006
d209e2fb 3007 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3008 to memset, add explicit initialization where appropriate.
3009
1ba6038a
GM
30102012-06-27 Glenn Morris <rgm@gnu.org>
3011
3012 * lisp.mk (lisp): Remove paths.elc.
3013
c89926a5
CY
30142012-06-27 Chong Yidong <cyd@gnu.org>
3015
3016 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3017
ed6b3510
JW
30182012-06-26 John Wiegley <johnw@newartisans.com>
3019
1ec4b7b2 3020 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3021 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3022
ed6b3510
JW
3023 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3024 when building with Clang.
3025
8edd4a2b
SM
30262012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3027
3028 * eval.c (Fapply): Allow calling it with a single argument.
3029
f6f62d1b
EZ
30302012-06-26 Eli Zaretskii <eliz@gnu.org>
3031
3032 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3033 _stricmp and _strnicmp.
3034 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3035
62efea5e
DA
30362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3037
3038 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3039 allocated window.
3040 (allocate_process): Likewise for new process.
8edd4a2b 3041 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3042 (allocate_frame): Likewise.
3043 * frame.c (make_frame): Omit redundant initialization.
3044 * window.c (make_parent_window): Use memset.
3045 (make_window): Omit redundant initialization.
3046 * process.c (make_process): Omit redundant initialization.
3047 * terminal.c (create_terminal): Likewise.
3048
42997f4d
DA
30492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3050
3051 * term.c (delete_tty): Remove redundant call to memset.
3052
1130ecfc
DA
30532012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3054
3055 * alloc.c: Remove build_string.
3056 * lisp.h: Define build_string as static inline. This provides
3057 a better opportunity to optimize away calls to strlen when the
3058 function is called with compile-time constant argument.
3059 * image.c (imagemagick_error): Convert to build_string.
3060 * w32proc.c (sys_spawnve): Likewise.
3061 * xterm.c (x_term_init): Likewise.
3062
cf38a720
PE
30632012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3064
99027bdd
PE
3065 Use sprintf return value instead of invoking strlen on result.
3066 In the old days this wasn't portable, since some sprintf
3067 implementations returned char *. But they died out years ago and
3068 Emacs already assumes sprintf returns int.
3069 Similarly for float_to_string.
3070 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3071 * ccl.c (ccl_driver):
3072 * character.c (string_escape_byte8):
3073 * data.c (Fnumber_to_string):
3074 * doprnt.c (doprnt):
3075 * print.c (print_object):
3076 * xdisp.c (message_dolog):
3077 * xfns.c (syms_of_xfns):
3078 Use sprintf or float_to_string result to avoid need to call strlen.
3079 * data.c (Fnumber_to_string):
3080 Use make_unibyte_string, since the string must be ASCII.
3081 * lisp.h, print.c (float_to_string): Now returns int length.
3082 * term.c (produce_glyphless_glyph):
3083 Use sprintf result rather than recomputing it.
3084
cf38a720
PE
3085 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3086 * Makefile.in (ALL_CFLAGS):
3087 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3088 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3089
3511c784
DA
30902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3091
0a08eb21 3092 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3093 strcasecmp if available.
3094 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3095
fb7da12e
AS
30962012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3097
3098 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3099 Avoid comma operator.
3100 * menu.c (push_submenu_start, push_submenu_end)
3101 (push_left_right_boundary, push_menu_pane): Likewise.
3102 * msdos.c (dos_rawgetc): Likewise.
3103
afa2ffd8
DA
31042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3105
3106 * xfns.c (xic_create_fontsetname): Remove redundant calls
3107 to memset.
3108
b3b4476b
PE
31092012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3110
4495ff38
PE
3111 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3112 sprintf already null-terminates its output.
3113
b3b4476b
PE
3114 * xfns.c (x_window): Remove redundant cast.
3115
b00876c9
DA
31162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3117
3118 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3119 `const char *' to `char *' to avoid compiler warning.
3120
d188e26b
PE
31212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3122
885d1d74
PE
3123 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3124 instead of truncating it to 63 (admittedly a generous limit).
3125
d188e26b
PE
3126 * process.c: Fix spelling and caps in comments.
3127
e2f560b1
DN
31282012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3129
e86db54b 3130 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3131 * sysdep.c (setpgrp): Remove definition, not used in this file.
3132
7583a3a1
JB
31332012-06-24 Juanma Barranquero <lekktu@gmail.com>
3134
3135 * makefile.w32-in: Update dependencies.
3136
696056c2
EZ
31372012-06-24 Eli Zaretskii <eliz@gnu.org>
3138
3139 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3140 (SYSTIME_H): Add nt/inc/sys/time.h.
3141
3142 * systime.h [WINDOWSNT]: Include sys/time.h.
3143
3144 * s/ms-w32.h (struct timespec): Definition moved from
3145 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3146
845ca893
PE
31472012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3150 * buffer.h (buffer_slot_type_mismatch):
3151 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3152 * eval.c (unwind_to_catch):
3153 * image.c (my_png_error, my_error_exit):
3154 * keyboard.c (quit_throw_to_read_char, user_error)
3155 (Fexit_recursive_edit, Fabort_recursive_edit):
3156 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3157 (wrong_type_argument, buffer_overflow, __executable_start)
3158 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3159 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3160 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3161 (fatal):
3162 (child_setup) [!DOS_NT]:
3163 * lread.c (end_of_file_error, invalid_syntax):
3164 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3165 * puresize.h (pure_write_error):
3166 * search.c (matcher_overflow):
3167 * sound.c (sound_perror, alsa_sound_perror):
3168 * sysdep.c, syssignal.h (croak):
3169 * term.c (maybe_fatal, vfatal):
3170 * textprop.c (text_read_only):
3171 * undo.c (user_error):
3172 * unexmacosx.c (unexec_error):
3173 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3174 Use _Noreturn rather than NO_RETURN.
3175 No need for separate decl merely because of _Noreturn.
3176 * sound.c (sound_warning, parse_sound):
3177 Remove unnecessary forward decls.
3178
f1dd8073
PE
31792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3182 * lisp.h (WAIT_READING_MAX): New macro.
3183 * dispnew.c (Fsleep_for, sit_for):
3184 * keyboard.c (kbd_buffer_get_event):
3185 * process.c (Faccept_process_output):
3186 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3187 This improves on the previous patch, which introduced a bug
3188 when time_t is unsigned and as wide as intmax_t.
3189 See <http://bugs.gnu.org/9000#51>.
3190
b82c1755
EZ
31912012-06-23 Eli Zaretskii <eliz@gnu.org>
3192
3193 * dispnew.c (sit_for, Fsleep_for):
3194 * keyboard.c (kbd_buffer_get_event):
3195 * process.c (Faccept_process_output): Avoid compiler warnings when
3196 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3197
ca300656
JB
31982012-06-23 Juanma Barranquero <lekktu@gmail.com>
3199
049ec95b
JB
3200 * makefile.w32-in: Update dependencies.
3201
ca300656
JB
3202 * w32.c (ltime): Add return type and declare static.
3203 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3204
db7b8d06
PE
32052012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3206
3207 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3208 Privately reported by Herbert J. Skuhra.
3209 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3210 All uses changed.
3211 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3212 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3213
0bd8297f
EZ
32142012-06-23 Eli Zaretskii <eliz@gnu.org>
3215
96512555
EZ
3216 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3217 last argument of make_unibyte_string.
3218
0bd8297f
EZ
3219 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3220 language ID in the event parameters.
3221
3222 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3223 event.code, not the obscure "character set ID".
3224
63def6b6
CY
32252012-06-23 Chong Yidong <cyd@gnu.org>
3226
3227 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3228
e8a02204
EZ
32292012-06-23 Eli Zaretskii <eliz@gnu.org>
3230
388cdec0
EZ
3231 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3232 * w32.c (fdutimens): New function.
3233
3234 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3235
3236 * s/ms-w32.h (pselect): Redirect to sys_select.
3237
3238 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3239
e8a02204
EZ
3240 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3241 in the logic of incrementing and decrementing the value of
3242 use_relocatable_buffers.
3243
d054f3fb
PE
32442012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3245
3246 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3247 Privately reported by Herbert J. Skuhra.
3248 [__FreeBSD__]: Remove "*/" typo after "#include".
3249 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3250 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3251 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3252 Don't assume EMACS_TIME and struct timeval are the same type.
3253
d35af63c
PE
32542012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 Support higher-resolution time stamps (Bug#9000).
3257 The time stamps are only nanosecond-resolution at the C level,
3258 since that's the best that any real-world system supports now.
3259 But they are picosecond-resolution at the Lisp level, as that's
3260 easy, and leaves room for future OS improvements.
3261
3262 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3263 (LIBES): Use it.
3264
3265 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3266 Don't get current time unless it's needed.
3267
3268 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3269 now provides it if it's absent.
3270 (start_atimer): Port to higher-res time stamps.
3271 Check for time stamp overflow. Don't get current time more
3272 often than is needed.
3273
3274 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3275 Include systime.h, not time.h.
3276 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3277
3278 * dired.c: Include stat-time.h.
3279 (Ffile-attributes): File times now have higher resolution.
3280
3281 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3282 (struct image): Timestamp now has higher resolution.
3283
3284 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3285 has at least microseconds now. All uses removed.
3286 (update_frame, update_single_window, update_window, update_frame_1)
3287 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3288
3289 * editfns.c (time_overflow): Now extern.
3290 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3291 (float-time, Fformat_time_string, Fcurrent_time_string)
3292 (Fcurrent_time_zone): Accept and generate higher-resolution
3293 time stamps.
3294 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3295 (decode_time_components, lisp_seconds_argument): New functions.
3296 (make_time): Now static.
3297 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3298 Report an error if the time is invalid, rather than having the caller
3299 do that.
3300
3301 * fileio.c: Include <stat-time.h>
3302 (Fcopy_file): Copy higher-resolution time stamps.
3303 Prefer to set the time stamp via a file descriptor if that works.
3304 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3305 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3306 (Fvisited_file_modtime, Fset_visited_file_modtime):
3307 Support higher-resolution time stamps.
3308
3309 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3310
3311 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3312
3313 * image.c (prepare_image_for_display, clear_image_cache)
3314 (lookup_image): Port to higer-resolution time stamps.
3315
3316 * keyboard.c (start_polling, bind_polling_period):
3317 Check for time stamp overflow.
3318 (read_char, kbd_buffer_get_event, timer_start_idle)
3319 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3320 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3321 Port to higher-resolution time stamps. Do not assume time_t is signed.
3322 (decode_timer): New function. Timers are now vectors of length 9,
3323 not 8, to accommodate the picosecond component.
3324 (timer_check_2): Use it.
3325
3326 * nsterm.m (select_timeout, timeval_subtract): Remove.
3327 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3328 as they're a bit more accurate and handle overflow better.
3329 (ns_select): Change prototype to be compatible with pselect.
3330 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3331 * nsterm.h (ns_select): Adjust prototype.
3332
3333 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3334 us-resolution time stamps.
3335 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3336
3337 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3338
3339 * lisp.h (time_overflow): New decl.
3340 (wait_reading_process_output): First arg is now intmax_t, not int,
3341 to accommodate larger waits.
3342
3343 * process.h (struct Lisp_Process.read_output_delay):
3344 Now counts nanoseconds, not microseconds.
3345 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3346 EMACS_HAS_USECS.
3347 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3348 (wait_reading_process_output):
3349 Port to ns-resolution time stamps.
3350 (Faccept_process_output, wait_reading_process_output):
3351 Check for time stamp overflow. Do not assume time_t is signed.
3352 (select_wrapper): Remove; we now use pselect.
3353 (Fprocess_attributes): Now generates ns-resolution time stamps.
3354
3355 * sysdep.c: Include utimens.h. Don't include utime.h
3356 or worry about struct utimbuf; gnulib does that for us now.
3357 (gettimeofday): Remove; gnulib provides a substitute.
3358 (make_timeval): New function.
3359 (set_file_times): Now sets ns-resolution time stamps.
3360 New arg FD; all uses changed.
3361 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3362 (system_process_attributes):
3363 Now returns ns-resolution time stamp. All uses changed.
3364 Check for time stamp overflow.
3365
3366 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3367 provides a substitute now.
3368
3369 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3370 since it guarantees struct timespec.
3371 (EMACS_TIME): Now struct timespec, so that we can support
3372 ns-resolution time stamps.
3373 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3374 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3375 (EMACS_USECS): Remove.
3376 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3377 so multiply the arg by 1000 before storing it.
3378 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3379 New macros.
3380 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3381 Port to ns-resolution time stamps.
3382 (EMACS_TIME_NEG_P): Remove; replaced by....
3383 (EMACS_TIME_SIGN): New macro.
3384 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3385 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3386 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3387 (make_timeval, make_lisp_time, decode_time_components): New decls.
3388 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3389 that it mishandled time_t overflow. You can't compare by subtracting!
3390 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3391 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3392
3393 * term.c: Include <sys/time.h>.
3394 (timeval_to_Time): New function, for proper overflow wraparound.
3395 (term_mouse_position, term_mouse_click): Use it.
3396
3397 * undo.c (record_first_change): Support higher-resolution time stamps
3398 in the undo buffer.
3399 (Fprimitive_undo): Use them when restoring time stamps.
3400
3401 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3402 (w32_get_internal_run_time):
3403 Port to higher-resolution Emacs time stamps.
3404 (ltime): Now accepts single 64-bit integer, as that's more convenient
3405 for callers.
3406
3407 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3408
3409 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3410 for compatibility with pselect. Support ns-resolution time stamps.
3411
3412 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3413
3414 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3415 Check for time stamp overflow, and support ns-resolution time stamps.
3416
3417 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3418 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3419 (timeval_subtract): Remove; no longer needed.
3420 (XTflash, XTring_bell, x_wait_for_event):
3421 Port to ns-resolution time stamps. Don't assume time_t is signed.
3422
b6a92dfe
CY
34232012-06-22 Chong Yidong <cyd@gnu.org>
3424
3425 * xdisp.c (x_consider_frame_title): Revert last change.
3426
d251c37c
EZ
34272012-06-22 Eli Zaretskii <eliz@gnu.org>
3428
3429 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3430 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3431 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3432 staticidx goes up to 1597 out of 1600 = 0x640.)
3433
f10deafb
PE
34342012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3435
3436 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3437 Otherwise, the umask might be mistakenly 0 while handling input signals.
3438
ec6de1e2
SM
34392012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3440
3441 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3442
28be1ada
DA
34432012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3444
3445 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3446 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3447 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3448 access to `contents' member of Lisp_Vector objects with AREF and ASET
3449 where appropriate.
3450
c6bf3022
CY
34512012-06-19 Chong Yidong <cyd@gnu.org>
3452
3453 * frame.c (delete_frame): When selecting a frame on a different
3454 text terminal, do not alter the terminal's top-frame.
3455
3456 * xdisp.c (format_mode_line_unwind_data): Record the target
3457 frame's selected window and its terminal's top-frame.
3458 (unwind_format_mode_line): Restore them.
3459 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3460 Callers changed.
3461 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3462 since tty frames can be explicitly named.
3463 (prepare_menu_bars): Likewise.
3464
3465 * term.c (Ftty_top_frame): New function.
3466
defd4196
PE
34672012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3468
3469 Port byte-code-meter to modern targets.
3470 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3471 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3472 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3473 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3474 (METER_1, METER_2): Simplify.
3475
1053a871
SM
34762012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3477
3478 * data.c (Fdefalias): Return `symbol' (bug#11686).
3479
b7e8d081
MR
34802012-06-18 Martin Rudalics <rudalics@gmx.at>
3481
3482 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3483 gets killed during executing of this function (Bug#11665).
3484 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3485 (Vkill_buffer_query_functions): In doc-string say that functions
3486 run by this hook should not change the current buffer.
3487
7ea2b339
PE
34882012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 Fix recently-introduced process.c problems found by static checking.
3491 * process.c (write_queue_push, write_queue_pop, send_process):
3492 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3493 (write_queue_pop): Fix pointer signedness problem.
3494 (send_process): Remove unused local.
3495
96a313a1
CY
34962012-06-17 Chong Yidong <cyd@gnu.org>
3497
3498 * xdisp.c (redisplay_internal): No need to redisplay terminal
3499 frames that are not on top.
3500
20ca2e94
TN
35012012-06-17 Troels Nielsen <bn.troels@gmail.com>
3502
3503 * process.c (make_process): Initialize write_queue.
3504 (write_queue_push, write_queue_pop): New functions.
3505 (send_process): Use them to maintain correct ordering of process
3506 writes (Bug#10815).
3507
9a900ca9
PE
35082012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3509
310fbfa8
PE
3510 * lisp.h (eassert): Assume C89 or later.
3511 This removes the need for CHECK.
3512 (CHECK): Remove. Its comments about always evaluating its
3513 argument were confusing, as 'eassert' typically does not evaluate
3514 its argument.
3515
27bb1ca4
PE
3516 * coding.c (produce_chars): Use ptrdiff_t, not int.
3517
9a900ca9
PE
3518 * xterm.c (x_draw_underwave): Check for integer overflow.
3519 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3520
41b7f8bc 35212012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3522
3523 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3524 referenced (Bug#11583).
3525
9b0e3eba
AA
35262012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3527
3528 Implement wave-style variant of underlining.
3529 * dispextern.h (face_underline_type): New enum.
3530 (face): Add field for underline type.
3531 * nsterm.m (ns_draw_underwave): New function.
3532 (ns_draw_text_decoration): Use it.
3533 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3534 New functions.
3535 (x_draw_glyph_string): Use them.
3536 * xfaces.c (Qline, Qwave): New Lisp objects.
3537 (check_lface_attrs, merge_face_ref)
1053a871
SM
3538 (Finternal_set_lisp_face_attribute, realize_x_face):
3539 Handle wave-style underline face attributes.
9b0e3eba
AA
3540 * xterm.c (x_draw_underwave): New function.
3541 (x_draw_glyph_string): Use it.
3542
0fb52f11
JB
35432012-06-16 Juanma Barranquero <lekktu@gmail.com>
3544
3545 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3546 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3547 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3548 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3549 ($(BLD)/w32select.$(O)): Update dependencies.
3550
e5560ff7
AS
35512012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3552
3553 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3554 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3555 * character.c (_fetch_multibyte_char_p): Remove.
3556 * alloc.c: Include "character.h" before "buffer.h".
3557 * bidi.c: Likewise.
3558 * buffer.c: Likewise.
3559 * bytecode.c: Likewise.
3560 * callint.c: Likewise.
3561 * callproc.c: Likewise.
3562 * casefiddle.c: Likewise.
3563 * casetab.c: Likewise.
3564 * category.c: Likewise.
3565 * cmds.c: Likewise.
3566 * coding.c: Likewise.
3567 * composite.c: Likewise.
3568 * dired.c: Likewise.
3569 * dispnew.c: Likewise.
3570 * doc.c: Likewise.
3571 * dosfns.c: Likewise.
3572 * editfns.c: Likewise.
3573 * emacs.c: Likewise.
3574 * fileio.c: Likewise.
3575 * filelock.c: Likewise.
3576 * font.c: Likewise.
3577 * fontset.c: Likewise.
3578 * fringe.c: Likewise.
3579 * indent.c: Likewise.
3580 * insdel.c: Likewise.
3581 * intervals.c: Likewise.
3582 * keyboard.c: Likewise.
3583 * keymap.c: Likewise.
3584 * lread.c: Likewise.
3585 * macros.c: Likewise.
3586 * marker.c: Likewise.
3587 * minibuf.c: Likewise.
3588 * nsfns.m: Likewise.
3589 * nsmenu.m: Likewise.
3590 * print.c: Likewise.
3591 * process.c: Likewise.
3592 * regex.c: Likewise.
3593 * region-cache.c: Likewise.
3594 * search.c: Likewise.
3595 * syntax.c: Likewise.
3596 * term.c: Likewise.
3597 * textprop.c: Likewise.
3598 * undo.c: Likewise.
3599 * unexsol.c: Likewise.
3600 * w16select.c: Likewise.
3601 * w32fns.c: Likewise.
3602 * w32menu.c: Likewise.
3603 * window.c: Likewise.
3604 * xdisp.c: Likewise.
3605 * xfns.c: Likewise.
3606 * xmenu.c: Likewise.
3607 * xml.c: Likewise.
3608 * xselect.c: Likewise.
3609
2f07e6af
EZ
36102012-06-16 Eli Zaretskii <eliz@gnu.org>
3611
1053a871
SM
3612 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3613 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3614 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3615 row.
3616 (handle_face_prop): Use chunk-relative overlay string index when
3617 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3618 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3619 the rightmost. (Bug#11720)
2f07e6af 3620
29b83cec
AS
36212012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3622
3623 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3624 (CATEGORY_MEMBER): Enforce 1/0 value.
3625 * category.c (_temp_category_set): Remove.
3626
4c5501e9
EZ
36272012-06-16 Eli Zaretskii <eliz@gnu.org>
3628
3629 * window.c (Fdelete_other_windows_internal)
3630 (Fdelete_window_internal): Don't access frame's mouse highlight
3631 info of the initial frame. (Bug#11677)
3632
2b570124
PE
36332012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3634
e93864f9
PE
3635 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3636 Assume USE_2_TAGS_FOR_INTS.
3637 (xreload): Adjust $tagmask width to match recent lisp.h change.
3638
2b570124
PE
3639 Simplify lisp.h in minor ways that should not affect code.
3640 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3641 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3642 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3643 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3644 (INTTYPEBITS): New macro, for clarity.
3645 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3646 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3647 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3648 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3649 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3650
81755f69
JB
36512012-06-13 Juanma Barranquero <lekktu@gmail.com>
3652
3653 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3654
16192a57
GM
36552012-06-13 Glenn Morris <rgm@gnu.org>
3656
3657 * s/bsd-common.h (BSD4_3):
3658 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3659
646b5f55
AS
36602012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3661
3662 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3663 instead of union.
3664 (XLI, XIL): Define.
1053a871
SM
3665 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3666 Use them.
3667 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3668 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3669 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3670 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3671 * frame.c (delete_frame): Remove outdated comment.
3672 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3673 USE_LISP_UNION_TYPE.
3674 (Fw32_unregister_hot_key): Likewise.
3675 (Fw32_toggle_lock_key): Likewise.
3676 * w32menu.c (add_menu_item): Likewise.
3677 (w32_menu_display_help): Use XIL instead of checking
3678 USE_LISP_UNION_TYPE.
3679 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3680 (init_heap): Likewise.
3681 * w32term.c (w32_read_socket): Update comment.
3682
1d3823c9
GM
36832012-06-13 Glenn Morris <rgm@gnu.org>
3684
c62ff706
GM
3685 * s/usg5-4-common.h, src/s/unixware.h:
3686 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3687
1d3823c9
GM
3688 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3689
bfe3e0a2
PE
36902012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3691
3692 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3693 * alloc.c (make_number) [!defined make_number]:
3694 Remove, as lisp.h always defines this now.
3695 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3696 (roundup_size): Verify that it is a power of 2.
3697 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3698 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3699 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3700 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3701 USE_LSB_TAG now is always defined to be either 0 or 1.
3702 All uses changed.
3703 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3704 code works fine either way, and efficiency is not a concern here,
3705 as the union type is for debugging, not for production.
3706 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3707 Use an inline function on all platforms when using the union type,
3708 since this is simpler and 'static inline' can be used portably
3709 within Emacs now.
3710 (LISP_INITIALLY_ZERO): New macro.
3711 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3712 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3713
45fa9c0f
GM
37142012-06-12 Glenn Morris <rgm@gnu.org>
3715
b4492cba
GM
3716 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3717
3718 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3719
45fa9c0f
GM
3720 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3721 Move BROKEN_SIGIO to configure.
3722
3723 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3724 Move NO_TERMIO to configure.
3725
0e25d334
CY
37262012-06-12 Chong Yidong <cyd@gnu.org>
3727
3728 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3729 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3730 MagickExportImagePixels is undefined.
3731
43682bb6
PE
37322012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 * image.c (imagemagick_load_image): Remove unused label.
3735
a9be7d2b
GM
37362012-06-11 Glenn Morris <rgm@gnu.org>
3737
3738 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3739 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3740 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3741 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3742
3017f87f
SM
37432012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3744
3745 * alloc.c (make_byte_code): New function.
3746 (Fmake_byte_code): Use it. Don't purify here.
3747 * lread.c (read1): Use it as well to avoid extra allocation.
3748
1b9b4cf4
CY
37492012-06-11 Chong Yidong <cyd@gnu.org>
3750
3751 * image.c (imagemagick_load_image): Implement transparency.
3752
95988fcf
AS
37532012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3754
3755 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3756 account for preceding backslashes. (Bug#11663)
3757
cd4eb164
CY
37582012-06-09 Chong Yidong <cyd@gnu.org>
3759
3760 * term.c: Support italics in capable terminals (Bug#9652).
3761 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3762 (turn_on_face): Output using TS_enter_italic_mode if available.
3763 Don't handle unused blinking and alt-charset cases.
3764 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3765 and tty_alt_charset_p cases.
3766 (tty_capable_p, init_tty): Support italics.
3767
3768 * termchar.h (struct tty_display_info): Add field for italics.
3769 Remove unused blink field.
3770
3771 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3772 Handle slant.
3773
3774 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3775 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3776 tty_alt_charset_p. Add tty_italic_p.
3777
ff88beb8
MA
37782012-06-09 Michael Albinus <michael.albinus@gmx.de>
3779
3780 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3781 dbus_type_is_basic if available.
3782 (xd_extract_signed, xd_extract_unsigned): Rename from
3783 extract_signed and extract_unsigned, respectively. Adapt callers.
3784
44286096
CY
37852012-06-09 Chong Yidong <cyd@gnu.org>
3786
1682701f
CY
3787 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3788
44286096
CY
3789 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3790 case (Bug#9752).
3791
d86feb17
PE
37922012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 * xdisp.c (vmessage): Treat frame message as multibyte.
3795 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3796 would generate the diagnostic "Making \302\247 buffer-local while
3797 let-bound!".
3798
d5c20fe8
EZ
37992012-06-08 Eli Zaretskii <eliz@gnu.org>
3800
3801 * dispnew.c (showing_window_margins_p): Undo last change, which
3802 was done due to an inadvertent commit.
3803 (adjust_frame_glyphs_for_frame_redisplay): Do call
3804 showing_window_margins_p.
3805
513749ee
SM
38062012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3807
3808 * eval.c (Fmake_var_non_special): New primitive.
3809 (syms_of_eval): Defsubr it.
3810 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3811
d4a8f5c1
JB
38122012-06-08 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3815 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3816
8bbbc977
EZ
38172012-06-08 Eli Zaretskii <eliz@gnu.org>
3818
3819 * alloc.c (allocate_vectorlike): Fix last change.
3820
f3372c87
DA
38212012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3822
3823 Block-based vector allocation of small vectors.
3824 * lisp.h (struct vectorlike_header): New field `nbytes',
3825 adjust comment accordingly.
3826 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3827 to denote vector blocks. Adjust users (live_vector_p,
3828 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3829 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3830 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3831 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3832 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3833 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3834 (roundup_size): New constant.
3835 (struct vector_block): New data type.
3836 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3837 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3838 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3839 (sweep_vectors): New functions.
3840 (allocate_vectorlike): Return `zero_vector' as the only vector of
3841 0 items. Allocate new vector from block if vector size is less than
3842 or equal to VBLOCK_BYTES_MAX.
3843 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3844 (init_alloc_once): Add call to init_vectors.
3845
4f18a4ed
SM
38462012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3847
3848 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3849
86f158bc
PE
38502012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3851
3852 * doprnt.c (doprnt): Truncate multibyte char correctly.
3853 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3854 would mishandle a string argument "Xc" if X was a multibyte
3855 character of length 2: it would truncate after X's first byte
3856 rather than including all of X.
3857
c5cfcbe0
CY
38582012-06-06 Chong Yidong <cyd@gnu.org>
3859
3860 * buffer.c (word_wrap): Doc fix.
3861
c05cf390
PE
38622012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3865
0c3461de
GM
38662012-06-03 Glenn Morris <rgm@gnu.org>
3867
3868 * xdisp.c (tool-bar-style): Doc fix.
3869
c71232db
UM
38702012-06-03 Ulrich Müller <ulm@gentoo.org>
3871
3872 * Makefile.in (PAXCTL): Define.
3873 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3874 binary via PaX flags if the paxctl utility is available.
3875 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3876 Restore PaX flags to their default. (Bug#11398)
3877
383f7350
CY
38782012-06-03 Chong Yidong <cyd@gnu.org>
3879
3880 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3881 buffer (Bug#11226).
3882
5f2c76c6
CY
38832012-06-03 Chong Yidong <cyd@gnu.org>
3884
3885 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3886 (note_mode_line_or_margin_highlight): If there is no help echo,
3887 use mode-line-default-help-echo. Handle the case where the mouse
3888 position is past the end of the mode line string.
3889
3890 * buffer.c (buffer_local_value_1): New function, split from
3891 Fbuffer_local_value; can return Qunbound.
3892 (Fbuffer_local_value): Use it.
3893 (Vmode_line_format): Docstring tweaks.
3894
773d47f6
PE
38952012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 * sysdep.c (system_process_attributes): Improve comment.
3898
f2d6a3df
SM
38992012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3900
3901 * keyboard.c: Export real-this-command to Elisp.
3902 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3903 and DEFVAR it. Update all users.
3904
63810350
PE
39052012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3906
7bd5c1f4
PE
3907 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3908
63810350
PE
3909 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3910 Convert pctcpu and pctmem to Lisp float properly.
3911 Let the compiler fold better, as 100.0/0x8000 is exact.
3912
a2821611
AS
39132012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3914
3915 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3916 cons_block.
3917
5fceba1d
PE
39182012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3919
3920 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3921
c98ff5dd
DA
39222012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3923
3924 For a 'struct window', replace some Lisp_Object fields to
3925 bitfields where appropriate, remove unused fields.
3926 * window.h (struct window): Remove unused 'last_mark_x' and
3927 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3928 change it's type from Lisp_Object to bitfield.
3929 Change type of 'force_start', 'optional_new_start',
3930 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3931 fields from Lisp_Object to bitfield. Adjust users accordingly.
3932
ca34e0be
PE
39332012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 Pacify gcc -Wdouble-precision when using Xaw.
3936 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3937 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3938 Use 'float' consistently, rather than 'float' in most places
3939 and 'double' in a couple of places.
3940
efc00ab1 39412012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3942
3943 * xdisp.c (handle_stop): Detect whether we have overlay strings
3944 loaded by testing it->current.overlay_string_index to be
3945 non-negative, instead of checking whether n_overlay_strings is
3946 positive. (Bug#11587)
3947
efc00ab1 39482012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3949
3950 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3951
3952 * doc.c (Fsubstitute_command_keys): Doc fix.
3953
efc00ab1 39542012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3955
3956 * search.c (search_buffer): Remove calls to
3957 r_alloc_inhibit_buffer_relocation, as it is now called by
3958 maybe_unify_char, which was the cause of relocation of buffer text
3959 in bug#11519.
3960
efc00ab1 39612012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3962
3963 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3964 for the duration of call to load_charset, to avoid problems with
3965 callers of maybe_unify_char that access buffer text through C
3966 pointers.
3967
3968 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3969 decrement the inhibition flag, instead of just setting or
3970 resetting it.
3971
ba93a187
PE
39722012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 Remove obsolete '#define static' cruft.
3975 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3976 This #undef was "temporary" in 2000; it is no longer needed
3977 now that '#define static' has gone away.
3978 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3979 (gray_bitmap_bits): Remove; no longer needed.
3980 All uses replaced with definiens.
3981 * xterm.c: Include "bitmaps/gray.xbm".
3982
9e4bf381
PE
39832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 Clean up __executable_start, monstartup when --enable-profiling.
3986 The following changes affect the code only when profiling.
3987 * dispnew.c (__executable_start): Rename from safe_bcopy.
3988 Define only on platforms that need it.
3989 * emacs.c: Include <sys/gmon.h> when profiling.
3990 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3991 (__executable_start): Remove decl, since lisp.h does it now.
3992 (safe_bcopy): Remove decl; no longer has that name.
3993 (main): Coalesce #if into single bit of code, for simplicity.
3994 Cast pointers to uintptr_t, since standard libraries want integers
3995 and not pointers.
3996 * lisp.h (__executable_start): New decl.
3997
32d72c2f
GM
39982012-05-31 Glenn Morris <rgm@gnu.org>
3999
4000 * image.c (Fimagemagick_types): Doc fix.
4001
baac5bc7
JM
40022012-05-30 Jim Meyering <meyering@redhat.com>
4003
4004 * callproc.c (Fcall_process_region): Include directory component
4005 in mkstemp error message (Bug#11586).
4006
72cb32cf
PE
40072012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4008
4009 * alloc.c, lisp.h (make_pure_vector): Now static.
4010
61b108cc
SM
40112012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4012
4013 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4014 Move to byte-run.el.
4015 (Fautoload): Do the hash-doc more carefully.
4016 * data.c (Fdefalias): Purify definition, except for keymaps.
4017 (Qdefun): Move from eval.c.
4018 * lisp.h (Qdefun): Remove.
4019 * lread.c (read1): Tiny simplification.
4020
471fe23d
TN
40212012-05-29 Troels Nielsen <bn.troels@gmail.com>
4022
934f3f58 4023 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4024 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4025 Bug#9642, but explicitly check that the buffer the overlay would
4026 be moved to is live and rearrange lines to make sure that errors
4027 will not put the overlay in an inconsistent state.
4028 (Fdelete_overlay): Cosmetics.
4029
85d0efd1
EZ
40302012-05-28 Eli Zaretskii <eliz@gnu.org>
4031
4032 * w32term.c (my_bring_window_to_top): New function.
4033 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4034 could be different from the original one.
4035 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4036 (Bug#11513)
4037
4038 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4039 by calling BringWindowToTop.
4040
4041 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4042 (WM_EMACS_END): Increase by one.
4043
da92a98c
PE
40442012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4047 This avoids undefined behavior that might cause the eassert
4048 to not catch an out-of-range value.
4049
74d1f848
JB
40502012-05-28 Juanma Barranquero <lekktu@gmail.com>
4051
4052 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4053 Update dependencies.
4054
9e1a06fc
EZ
40552012-05-27 Eli Zaretskii <eliz@gnu.org>
4056
4057 * bidi.c (bidi_mirror_char): Fix last change.
4058
f3dd7312
AS
40592012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4060
4061 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4062 when referring to sectname field in printf format.
4063
81899c91
PE
40642012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4065
57b81a9f
PE
4066 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4067 Only r_alloc_inhibit_buffer_relocation needed to be added;
4068 the others were already declared.
4069
81899c91
PE
4070 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4071 before checking whether it's out of range. Put the check inside
4072 eassert. See
4073 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4074
33017faf 40752012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4076
4077 * callproc.c (Fcall_process): Restore a line that was accidentally
4078 commented out in the 2011-02-13 change (bug#11547).
4079
33017faf 40802012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4081
4082 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4083 defined on ralloc.c.
4084
4085 * buffer.c [REL_ALLOC]: Remove prototypes of
4086 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4087 they are now on lisp.h.
4088
4089 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4090
4091 * search.c (search_buffer): Use it to inhibit relocation of buffer
4092 text while re_search_2 is doing its job, because re_search_2 is
4093 passed C pointers to buffer text. (Bug#11519)
4094
23415acf
EZ
4095 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4096 Update value to 24.
4097
44e27368
EZ
4098 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4099 state after an additional call to move_it_in_display_line_to, keep
4100 the values of it->max_ascent and it->max_descent found for the
4101 entire line.
4102 (pos_visible_p): Revert the comparison against bottom_y to what it
4103 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4104 (Bug#11464)
4105
c1892f11
PE
41062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4107
4108 Fix coding-related core dumps with gcc -ftrapv.
4109 The code was computing A - B, where A and B are pointers, and B is
4110 random garbage. This can lead to core dumps on platforms that
4111 have special pointer registers, and it also leads to core dumps on
4112 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4113 A - B only when B is initialized properly.
4114 * coding.c (coding_set_source, coding_set_destination): Return void.
4115 (coding_change_source, coding_change_destinations): New functions,
4116 with the old behaviors of coding_set_source and coding_set_destination.
4117 All callers that need an offset changed to use these new functions.
4118
eb7afdad
GM
41192012-05-26 Glenn Morris <rgm@gnu.org>
4120
4121 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4122
f12fdf02
EZ
41232012-05-26 Eli Zaretskii <eliz@gnu.org>
4124
53a63be6 4125 Extend mouse support on W32 text-mode console.
61b108cc
SM
4126 * xdisp.c (draw_row_with_mouse_face):
4127 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4128
eb3f6f01 4129 * w32console.c: Include window.h.
61b108cc
SM
4130 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4131 New functions.
eb3f6f01
EZ
4132 (initialize_w32_display): Initialize mouse-highlight data.
4133
53a63be6
EZ
4134 * w32inevt.c: Include termchar.h and window.h.
4135 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4136 moves, call note_mouse_highlight. If help_echo changed, call
4137 gen_help_event to produce help-echo message in the echo area.
4138 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4139 highlight info.
4140
4cfd81f6
PE
41412012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4142
4143 * lread.c (read1): Simplify slightly to avoid an overflow warning
4144 with GCC 4.7.0 on x86-64.
4145
4446092a
EZ
41462012-05-26 Eli Zaretskii <eliz@gnu.org>
4147
4148 * bidi.c (bidi_mirror_char): Revert last change: an int is
4149 definitely wide enough here.
4150
42b2a986 41512012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4152
42b2a986 4153 Fix integer width and related bugs (Bug#9874).
eb106a49 4154 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4155 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4156 (string_bytes, check_sblock, allocate_string_data):
4157 (compact_small_strings, Fmake_bool_vector, make_string)
4158 (make_unibyte_string, make_multibyte_string)
4159 (make_string_from_bytes, make_specified_string)
4160 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4161 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4162 (mark_vectorlike):
4163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4164 (allocate_pseudovector):
4165 Use int, not EMACS_INT, where int is wide enough.
4166 (inhibit_garbage_collection, Fgarbage_collect):
4167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4168 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4169 int might not be wide enough.
4170 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4171 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4172 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4173 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4174 (bidi_level_of_next_char, bidi_move_to_visually_next):
4175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4176 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4177 (Fkill_buffer, Fset_buffer_major_mode)
4178 (advance_to_char_boundary, Fbuffer_swap_text)
4179 (Fset_buffer_multibyte, overlays_at, overlays_in)
4180 (overlay_touches_p, struct sortvec, record_overlay_string)
4181 (overlay_strings, recenter_overlay_lists)
4182 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4183 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4184 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4185 (Foverlay_recenter, last_overlay_modification_hooks_used)
4186 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4188 (validate_region): Omit unnecessary test for b <= e,
4189 since that's guaranteed by the previous test.
d311d28c
PE
4190 (adjust_overlays_for_delete): Avoid pos + length overflow.
4191 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4192 (report_overlay_modification):
4193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4194 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4195 Omit pointer cast, which isn't needed anyway, and doesn't work
4196 after the EMACS_INT -> ptrdiff_t change.
02481186 4197 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4198 * buffer.h: Adjust decls to match defn changes elsewhere.
4199 (struct buffer_text, struct buffer):
4200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4201 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4202 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4203 not int, to avoid needless 32-bit limit on 64-bit hosts.
4204 (exec_byte_code): Use tighter memory-full test, one that checks
4205 for alloca overflow. Don't compute the address of the object just
4206 before an array, as that's not portable. Use EMACS_INT, not
4207 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4208 * callint.c (Fcall_interactively):
4209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4210 * callproc.c (call_process_kill, Fcall_process):
4211 Don't assume pid_t fits into an Emacs fixnum.
4212 (call_process_cleanup, Fcall_process, child_setup):
4213 Don't assume pid_t fits into int.
4214 (call_process_cleanup, Fcall_process, delete_temp_file)
4215 (Fcall_process_region):
4216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4217 (Fcall_process): Simplify handling of volatile integers.
4218 Use int, not EMACS_INT, where int will do.
4219 * casefiddle.c (casify_object, casify_region, operate_on_word)
4220 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4222 (casify_object): Avoid integer overflow when overallocating buffer.
4223 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4224 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4225 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4226 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4227 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4228 integers are now checked earlier. All uses replaced with XINT.
4229 (ccl_driver):
4230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4231 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4232 (ccl_driver, Fregister_code_conversion_map):
4233 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4234 (resolve_symbol_ccl_program): Check that vector header is in range.
4235 Always copy the vector, so that we can check its contents reliably
4236 now rather than having to recheck each instruction as it's being
4237 executed. Check that vector words fit in 'int'.
4238 (ccl_get_compiled_code, Fregister_ccl_program)
4239 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4240 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4241 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4242 contents are in range.
4243 (Fccl_execute_on_string): Check that status is in range.
4244 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4245 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4246 Accept and return EMACS_INT, not int, because callers can pass values
4247 out of 'int' range.
4248 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4249 (multibyte_chars_in_text, parse_str_as_multibyte)
4250 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4251 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4252 (string_escape_byte8, Fget_byte):
4253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4254 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4255 avoid mishandling large integers.
4256 * character.h: Adjust decls to match defn changes elsewhere.
4257 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4258 (Ffind_charset_region):
4259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4260 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4261 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4262 Don't assume fixnum fits in int.
d311d28c
PE
4263 (load_charset_map_from_vector, Fmap_charset_chars):
4264 Remove now-unnecessary CHECK_NATNUMs.
4265 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4266 Don't rely on undefined behavior with signed left shift overflow.
4267 Don't assume unsigned int fits into fixnum, or that fixnum fits
4268 into unsigned int. Don't require max_code to be a valid fixnum;
4269 that's not true for gb10830 4-byte on a 32-bit host. Allow
4270 invalid_code to be a cons, for the same reason. Require code_offset
4271 to be a character. Avoid int overflow if max_char is close
4272 to INT_MAX.
4273 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4274 this is intended anyway and avoids some undefined behavior.
4275 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4276 INDEX_TO_CODE_POINT, as that's what it expects.
4277 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4278 * charset.h (DECODE_CHAR): Return int, not unsigned;
4279 this is what was intended anyway, and it avoids undefined behavior.
4280 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4281 integer-overflow issues.
4282 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4283 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4284 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4285 * chartab.c (Fmake_char_table, Fset_char_table_range)
4286 (uniprop_get_decoder, uniprop_get_encoder):
4287 Don't assume fixnum fits in int.
4288 * cmds.c (move_point): New function, that does the gist of
4289 Fforward_char and Fbackward_char, but does so while checking
4290 for integer overflow more accurately.
c96e5d6a 4291 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4292 (Fforward_line, Fend_of_line, internal_self_insert)
4293 (internal_self_insert):
4294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4295 Fix a FIXME, by checking for integer overflow when calculating
4296 target_clm and actual_clm.
4297 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4298 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4299 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4300 (coding_alloc_by_making_gap, alloc_destination)
4301 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4302 (encode_coding_utf_16, detect_coding_emacs_mule)
4303 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4304 (detect_coding_iso_2022, decode_coding_iso_2022)
4305 (encode_invocation_designation, encode_designation_at_bol)
4306 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4307 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4308 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4309 (encode_coding_ccl, encode_coding_raw_text)
4310 (detect_coding_charset, decode_coding_charset)
4311 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4312 (produce_composition, produce_charset, produce_annotation)
4313 (decode_coding, handle_composition_annotation)
4314 (handle_charset_annotation, consume_chars, decode_coding_gap)
4315 (decode_coding_object, encode_coding_object, detect_coding_system)
4316 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4317 (code_convert_region, code_convert_string)
8f50130c
PE
4318 (Fdefine_coding_system_internal)
4319 (coding_set_source, coding_set_destination):
d311d28c
PE
4320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4321 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4322 (Fdefine_coding_system_internal):
4323 Don't assume fixnums fit in int.
4324 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4325 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4326 (Funencodable_char_position, Fcheck_coding_systems_region)
4327 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4329 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4330 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4331 Don't access memory outside of the args array.
d311d28c 4332 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4333 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4334 result of ENCODE_CHAR.
d311d28c
PE
4335 * coding.h: Adjust decls to match defn changes elsewhere.
4336 (struct coding_system):
4337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4338 * composite.c (get_composition_id, find_composition)
4339 (run_composition_function, update_compositions)
4340 (compose_text, composition_gstring_put_cache)
4341 (composition_gstring_p, composition_gstring_width)
4342 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4343 (composition_compute_stop_pos, composition_reseat_it)
4344 (composition_update_it, struct position_record)
4345 (find_automatic_composition, composition_adjust_point)
4346 (Fcomposition_get_gstring, Ffind_composition_internal):
4347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4348 (update_compositions):
4349 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4350 * composite.h: Adjust decls to match defn changes elsewhere.
4351 (struct composition):
4352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4353 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4354 Do not attempt to compute the address of the object just before a
4355 buffer; this is not portable.
4356 (Faref, Faset):
4357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4358 (Faset): Use int, not EMACS_INT, where int is wide enough.
4359 (Fstring_to_number): Don't assume fixnums fit in int.
4360 (Frem): Don't assume arg is nonnegative.
4361 * dbusbind.c (xd_append_arg): Check for integers out of range.
4362 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4363 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4364 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4365 (xd_get_connection_references): Return ptrdiff_t, not int.
4366 All uses changed.
4367 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4368 (xd_read_message_1):
4369 Use int, not unsigned, where the dbus API uses int.
4370 (Fdbus_message_internal): Don't overflow mtype.
4371 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4372 * dired.c (directory_files_internal, file_name_completion, scmp)
4373 (file_name_completion_stat):
4374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4375 (file_name_completion): Don't overflow matchcount.
4376 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4377 * dispextern.h: Adjust decls to match defn changes elsewhere.
4378 (struct text_pos, struct glyph, struct bidi_saved_info)
4379 (struct bidi_string_data, struct bidi_it, struct composition_it)
4380 (struct it):
4381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4382 (struct display_pos, struct composition_it, struct it):
4383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4384 * dispnew.c (increment_matrix_positions)
4385 (increment_row_positions, mode_line_string)
4386 (marginal_area_string):
4387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4388 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4390 (duration_to_sec_usec): New function, to check for overflow better.
4391 (Fsleep_for, sit_for): Use it.
4392 * doc.c (get_doc_string, store_function_docstring):
4393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4394 (get_doc_string, Fsnarf_documentation):
4395 Use int, not EMACS_INT, where int is wide enough.
4396 (get_doc_string):
4397 Use SAFE_ALLOCA, not alloca.
4398 Check for overflow when converting EMACS_INT to off_t.
4399 * doprnt.c (doprnt):
4400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4401 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4402 Don't assume uid_t fits into fixnum.
4403 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4404 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4405 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4406 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4407 (general_insert_function)
4408 (Finsert_char, make_buffer_string, make_buffer_string_both)
4409 (update_buffer_properties, Fbuffer_substring)
4410 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4411 (Fsubst_char_in_region, check_translation)
4412 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4413 (transpose_markers, Ftranspose_regions):
4414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4415 (clip_to_bounds): Move to lisp.h as an inline function).
4416 (Fconstrain_to_field): Don't assume integers are nonnegative.
4417 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4418 (Fsubst_char_in_region, Fsave_restriction):
4419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4420 (Femacs_pid): Don't assume pid_t fits into fixnum.
4421 (lo_time): Use int, not EMACS_INT, when int suffices.
4422 (lisp_time_argument): Check for usec out of range.
4423 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4424 (Fuser_login_name, Fuser_full_name): Signal an error
4425 if a uid argument is out of range, rather than relying on
4426 undefined behavior.
c8d5c857
PE
4427 (Fformat_time_string): Remove now-unnecessary check.
4428 lisp_time_argument checks for out-of-range usec now.
243e0530 4429 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4430 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4431 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4432 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4433 (init_cmdargs, Fdump_emacs):
4434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4435 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4436 the bottom (typically) 32 bits of the fixnum.
4437 * eval.c (specpdl_size, call_debugger):
4438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4439 (when_entered_debugger, Fbacktrace_debug):
4440 Don't assume fixnum can fit in int.
4441 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4442 the object just before a buffer; this is not portable.
4443 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4444 (grow_specpdl, unbind_to):
4445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4446 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4447 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4448 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4449 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4450 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4452 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4453 (a_write, e_write):
4454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4455 (Fcopy_file, non_regular_nbytes, read_non_regular)
4456 (Finsert_file_contents):
4457 Use int, not EMACS_INT, where int is wide enough.
4458 (READ_BUF_SIZE): Verify that it fits in int.
4459 (Finsert_file_contents): Check that counts are in proper range,
4460 rather than assuming fixnums fit into ptrdiff_t etc.
4461 Don't assume fixnums fit into int.
125b3835 4462 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4463 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4464 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4465 (string_char_to_byte, string_byte_to_char)
4466 (string_make_multibyte, string_to_multibyte)
4467 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4468 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4469 (substring_both, Fdelete, internal_equal, Ffillarray)
4470 (Fclear_string, mapcar1)
4471 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4472 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4473 (larger_vector, make_hash_table, maybe_resize_hash_table)
4474 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4475 (Fmaphash, secure_hash):
4476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4477 (concat): Check for string index and length overflow.
4478 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4479 (Frequire):
4480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4481 (larger_vector): New API (vec, incr_min, size_max) replaces old
4482 one (vec, new_size, init). This catches size overflow.
4483 INIT was removed because it was always Qnil.
4484 All callers changed.
4485 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4486 the upper bound on a hash table index size.
4487 (make_hash_table, maybe_resize_hash_table): Use it.
4488 (secure_hash): Computer start_byte and end_byte only after
4489 they're known to be in ptrdiff_t range.
4490 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4491 (Ffont_get_glyphs, Ffont_at):
4492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4493 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4494 (Flist_fonts, Fopen_font):
4495 Don't assume fixnum can fit in int.
4496 (check_gstring): Don't assume index can fit in int.
4497 (font_match_p): Check that fixnum is a character, not a nonnegative
4498 fixnum, since the later code needs to stuff it into an int.
4499 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4500 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4501 conversion overflow issues.
4502 (Fopen_font): Check for integer out of range.
4503 (Ffont_get_glyphs): Don't assume index can fit in int.
4504 * font.h: Adjust decls to match defn changes elsewhere.
4505 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4506 integer overflow.
4507 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4508 printmax_t, where ptrdiff_t is wide enough.
4509 (Finternal_char_font):
4510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4511 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4512 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4513 (Fset_frame_position, x_set_frame_parameters)
4514 (x_set_line_spacing, x_set_border_width)
4515 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4516 Check that fixnums are in proper range for system types.
4517 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4519 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4520 Use SAFE_ALLOCA_LISP, not alloca.
4521 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4522 intptr_t is wide enough.
4523 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4524 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4525 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4526 Check for fixnum out of range.
4527 * ftfont.c (ftfont_list): Don't assume index fits in int.
4528 Check that fixnums are in proper range for system types.
4529 (ftfont_shape_by_flt):
4530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4531 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4533 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4534 Check that fixnums are in proper range for system types.
4535 * gnutls.h: Adjust decls to match defn changes elsewhere.
4536 * gtkutil.c (xg_dialog_run):
4537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4538 (update_frame_tool_bar):
4539 Check that fixnums are in proper range for system types.
4540 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4541 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4542 * indent.c (last_known_column, last_known_column_point):
4543 (current_column_bol_cache):
4544 (skip_invisible, current_column, check_display_width):
4545 (check_display_width, scan_for_column, current_column_1)
4546 (Findent_to, Fcurrent_indentation, position_indentation)
4547 (indented_beyond_p, Fmove_to_column, compute_motion):
4548 (Fcompute_motion, Fvertical_motion):
4549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4550 (last_known_column_modified): Use EMACS_INT, not int.
4551 (check_display_width):
4552 (Fcompute_motion):
4553 Check that fixnums and floats are in proper range for system types.
4554 (compute_motion): Don't assume index or fixnum fits in int.
4555 (compute_motion, Fcompute_motion):
4556 Use int, not EMACS_INT, when it is wide enough.
4557 (vmotion): Omit local var start_hpos that is always 0; that way
4558 we don't need to worry about overflow in expressions involving it.
4559 * indent.h: Adjust decls to match defn changes elsewhere.
4560 (struct position):
4561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4562 Use int, not EMACS_INT, where int is wide enough.
4563 Remove unused members ovstring_chars_done and tab_offset;
4564 all uses removed.
4565 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4566 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4567 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4568 (make_gap, copy_text, insert, insert_and_inherit)
4569 (insert_before_markers, insert_before_markers_and_inherit)
4570 (insert_1, count_combining_before, count_combining_after)
4571 (insert_1_both, insert_from_string)
4572 (insert_from_string_before_markers, insert_from_string_1)
4573 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4574 (adjust_after_replace, adjust_after_insert, replace_range)
4575 (replace_range_2, del_range, del_range_1, del_range_byte)
4576 (del_range_both, del_range_2, modify_region)
4577 (prepare_to_modify_buffer, signal_before_change)
4578 (signal_after_change, Fcombine_after_change_execute):
4579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4580 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4581 (balance_an_interval, split_interval_right, split_interval_left)
4582 (find_interval, next_interval, update_interval)
4583 (adjust_intervals_for_insertion, delete_node, delete_interval)
4584 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4585 (static_offset_intervals, offset_intervals)
4586 (merge_interval_right, merge_interval_left, make_new_interval)
4587 (graft_intervals_into_buffer, temp_set_point_both)
4588 (temp_set_point, set_point, adjust_for_invis_intang)
4589 (set_point_both, move_if_not_intangible, get_property_and_range)
4590 (get_local_map, copy_intervals, copy_intervals_to_string)
4591 (compare_string_intervals, set_intervals_multibyte_1):
4592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4593 * intervals.h: Adjust decls to match defn changes elsewhere.
4594 (struct interval):
4595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4596 * keyboard.c (this_command_key_count, this_single_command_key_start)
4597 (before_command_key_count, before_command_echo_length, echo_now)
4598 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4599 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4600 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4601 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4603 (last_non_minibuf_size, last_point_position, echo_truncate)
4604 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4605 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4606 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4607 (stuff_buffered_input):
4608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4609 (last_auto_save, command_loop_1, read_char):
4610 Use EMACS_INT, not int, to avoid integer overflow.
4611 (record_char): Avoid overflow in total_keys computation.
4612 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4613 * keyboard.h: Adjust decls to match defn changes elsewhere.
4614 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4615 (Fkey_description, Fdescribe_vector, Flookup_key):
4616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4617 (click_position): New function, to check that positions are in range.
4618 (Fcurrent_active_maps):
4619 (describe_command):
4620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4621 (Faccessible_keymaps, Fkey_description):
4622 (preferred_sequence_p):
4623 Don't assume fixnum can fit into int.
4624 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4625 Check for integer overflow in size calculations.
4626 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4627 avoid mishandling large integers.
4628 * lisp.h: Adjust decls to match defn changes elsewhere.
4629 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4630 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4631 (struct Lisp_Marker):
4632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4633 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4634 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4635 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4636 All callers changed.
4637 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4638 Assume the arg has valid form, since it always does.
4639 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4640 unsigned integer system type.
4641 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4642 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4644 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4645 (duration_to_sec_usec): New decl.
4646 * lread.c (read_from_string_index, read_from_string_index_byte)
4647 (read_from_string_limit, readchar, unreadchar, openp)
4648 (read_internal_start, read1, oblookup):
4649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4650 (Fload, readevalloop, Feval_buffer, Feval_region):
4651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4652 (openp): Check for out-of-range argument to 'access'.
4653 (read1): Use int, not EMACS_INT, where int is wide enough.
4654 Don't assume fixnum fits into int.
6efdadfd 4655 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4656 (read_filtered_event): Use duration_to_sec_usec
4657 to do proper overflow checking on durations.
d311d28c
PE
4658 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4659 in size calculation.
4660 (Fexecute_kbd_macro):
4661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4662 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4663 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4664 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4665 (set_marker_both, set_marker_restricted_both, marker_position)
4666 (marker_byte_position, Fbuffer_has_markers_at):
4667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4668 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4669 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4670 It now merely ensures that the menu is large enough, without
4671 necessarily growing it, as this avoids some integer overflow issues.
4672 All callers changed.
4673 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4675 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4676 Use SAFE_ALLOCA_LISP, not alloca.
4677 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4678 to EMACS_INT. Check that fixnums are in proper range for system types.
4679 * minibuf.c (minibuf_prompt_width, string_to_object)
4680 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4681 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4683 (get_minibuffer, read_minibuf_unwind):
4684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4685 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4686 this simplifies overflow checking. All callers changed.
4687 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4688 (Ftest_completion):
4689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4690 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4691 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4692 Check that fixnums are in proper range for system types.
4693 (Fx_create_frame, Fx_show_tip):
4694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4695 * nsfont.m (ns_findfonts, nsfont_list_family):
4696 Don't assume fixnum fits in long.
4697 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4699 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4700 wide enough.
17fdb222 4701 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4703 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4704 (PRINTDECLARE, PRINTPREPARE):
4705 (strout, print_string):
4706 (print, print_preprocess, print_check_string_charset_prop)
4707 (print_object):
4708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4709 (PRINTDECLARE):
4710 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4712 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4713 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4714 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4715 (print_error_message): Use SAFE_ALLOCA, not alloca.
4716 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4717 (print_depth, new_backquote_output, print_number_index):
4718 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4719 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4720 (Fset_process_window_size, Fformat_network_address)
4721 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4722 (sigchld_handler):
d311d28c 4723 Check that fixnums are in proper range for system types.
d44287d4 4724 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4725 Check for process-ids out of pid_t range rather than relying on
4726 undefined behavior.
e4d81efc 4727 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4728 (Fformat_network_address, read_process_output, send_process)
4729 (Fprocess_send_region, status_notify):
4730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4731 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4732 (wait_reading_process_output, read_process_output, exec_sentinel):
4733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4734 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4735 (Faccept_process_output): Use duration_to_sec_usec to do proper
4736 overflow checking on durations.
dde14581
PE
4737 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4738 Don't assume pid_t fits in int.
02481186
PE
4739 * process.h (struct Lisp_Process): Members tick and update_tick
4740 are now of type EMACS_INT, not int.
b62b53e8
PE
4741 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4742 configured --with-wide-int.
d311d28c
PE
4743 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4744 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4745 * search.c (looking_at_1, string_match_1):
4746 (fast_string_match, fast_c_string_match_ignore_case)
4747 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4748 (scan_newline, find_before_next_newline, search_command)
4749 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4750 (set_search_regs, wordify):
4751 (Freplace_match):
4752 (Fmatch_data):
4753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4754 (string_match_1, search_buffer, set_search_regs):
4755 (Fmatch_data):
4756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4757 (wordify): Check for overflow in size calculation.
4758 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4759 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4760 Check that fixnums are in proper range for system types.
4761 * sound.c (struct sound_device)
4762 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4764 (Fplay_sound_internal):
4765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4766 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4767 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4768 (Fparse_partial_sexp):
4769 Don't assume fixnums can fit in int.
4770 (struct lisp_parse_state, find_start_pos, find_start_value)
4771 (find_start_value_byte, find_start_begv)
4772 (update_syntax_table, char_quoted, dec_bytepos)
4773 (find_defun_start, prev_char_comend_first, back_comment):
4774 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4775 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4777 (Finternal_describe_syntax_value): Check that match_lisp is a
4778 character, not an integer, since the code stuffs it into int.
4779 (scan_words, scan_sexps_forward):
4780 Check that fixnums are in proper range for system types.
4781 (Fforward_word):
4782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4783 (scan_sexps_forward):
4784 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4785 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4786 * syntax.h: Adjust decls to match defn changes elsewhere.
4787 (struct gl_state_s):
4788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4789 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4790 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4791 * sysdep.c (wait_for_termination_1, wait_for_termination)
4792 (interruptible_wait_for_termination, mkdir):
4793 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4794 (emacs_read, emacs_write):
4795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4796 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4797 and double all fit in int.
d311d28c
PE
4798 * term.c (set_tty_color_mode):
4799 Check that fixnums are in proper range for system types.
4800 * termhooks.h (struct input_event):
4801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4802 * textprop.c (validate_interval_range, interval_of)
4803 (Fadd_text_properties, set_text_properties_1)
4804 (Fremove_text_properties, Fremove_list_of_text_properties)
4805 (Ftext_property_any, Ftext_property_not_all)
4806 (copy_text_properties, text_property_list, extend_property_ranges)
4807 (verify_interval_modification):
4808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4809 (Fnext_single_char_property_change)
4810 (Fprevious_single_char_property_change):
4811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4812 (copy_text_properties):
4813 Check for integer overflow in index calculation.
d311d28c
PE
4814 * undo.c (last_boundary_position, record_point, record_insert)
4815 (record_delete, record_marker_adjustment, record_change)
4816 (record_property_change):
4817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4818 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4820 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4821 (Fx_hide_tip, Fx_file_dialog):
4822 * w32menu.c (set_frame_menubar):
4823 Use ptrdiff_t, not int, for consistency with rest of code.
4824 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4825 (select_window, Fdelete_other_windows_internal)
4826 (window_scroll_pixel_based, window_scroll_line_based)
4827 (Frecenter, Fset_window_configuration):
4828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4829 (Fset_window_hscroll, run_window_configuration_change_hook)
4830 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4831 (Fscroll_other_window, Frecenter):
d311d28c
PE
4832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4833 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4834 Don't assume fixnum fits in int.
4835 (Fset_window_scroll_bars):
4836 Check that fixnums are in proper range for system types.
4837 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4838 (string_pos, c_string_pos, number_of_chars, init_iterator)
4839 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4840 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4841 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4842 (face_before_or_after_it_pos, handle_invisible_prop)
4843 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4844 (display_prop_intangible_p, string_buffer_position_lim)
4845 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4846 (get_overlay_strings_1, get_overlay_strings)
4847 (iterate_out_of_display_property, forward_to_next_line_start)
4848 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4849 (get_next_display_element, set_iterator_to_next)
4850 (get_visually_first_element, compute_stop_pos_backwards)
4851 (handle_stop_backwards, next_element_from_buffer)
4852 (move_it_in_display_line_to, move_it_in_display_line)
4853 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4854 (add_to_log, message_dolog, message_log_check_duplicate)
4855 (message2, message2_nolog, message3, message3_nolog
4856 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4857 (current_message_1, truncate_echo_area, truncate_message_1)
4858 (set_message, set_message_1, store_mode_line_noprop)
4859 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4860 (text_outside_line_unchanged_p, check_point_in_composition)
4861 (reconsider_clip_changes)
4862 (redisplay_internal, set_cursor_from_row, try_scrolling)
4863 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4864 (redisplay_window, find_last_unchanged_at_beg_row)
4865 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4866 (trailing_whitespace_p, find_row_edges, display_line)
4867 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4868 (display_mode_element, store_mode_line_string)
4869 (pint2str, pint2hrstr, decode_mode_spec)
4870 (display_count_lines, display_string, draw_glyphs)
4871 (x_produce_glyphs, x_insert_glyphs)
4872 (rows_from_pos_range, mouse_face_from_buffer_pos)
4873 (fast_find_string_pos, mouse_face_from_string_pos)
4874 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4876 (safe_call, init_from_display_pos, handle_fontified_prop)
4877 (handle_single_display_spec, load_overlay_strings)
4878 (with_echo_area_buffer, setup_echo_area_for_printing)
4879 (display_echo_area, echo_area_display)
4880 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4881 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4882 (redisplay_window, dump_glyph_row, display_mode_line)
4883 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4884 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4886 (handle_single_display_spec, build_desired_tool_bar_string)
4887 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4888 (get_specified_cursor_type):
4889 Check that fixnums are in proper range for system types.
4890 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4891 (Flookup_image_map):
4892 Don't assume fixnums fit in int.
4893 (compare_overlay_entries):
4894 Avoid mishandling comparisons due to subtraction overflow.
4895 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4896 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4897 (handle_tool_bar_click):
4898 Use int, not unsigned, since we prefer signed and the signedness
4899 doesn't matter here.
4900 (get_next_display_element, next_element_from_display_vector):
4901 Use int, not EMACS_INT, when int is wide enough.
4902 (start_hourglass): Use duration_to_sec_usec to do proper
4903 overflow checking on durations.
4904 * xfaces.c (Fbitmap_spec_p):
4905 Check that fixnums are in proper range for system types.
4906 (compare_fonts_by_sort_order):
4907 Avoid mishandling comparisons due to subtraction overflow.
4908 (Fx_family_fonts, realize_basic_faces):
4909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4910 (Fx_family_fonts):
4911 Don't assume fixnum fits in int.
4912 Use SAFE_ALLOCA_LISP, not alloca.
4913 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4914 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4915 (face_at_buffer_position, face_for_overlay_string)
4916 (face_at_string_position):
4917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4918 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4919 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4920 (Fx_show_tip):
4921 Check that fixnums are in proper range for system types.
4922 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4923 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4925 (Fx_change_window_property): Don't assume fixnums fit in int.
4926 * xfont.c (xfont_chars_supported):
4927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4928 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4929 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4931 * xml.c (parse_region):
4932 * xrdb.c (magic_file_p):
4933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4934 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4935 (x_get_local_selection, x_reply_selection_request)
4936 (x_handle_selection_request, wait_for_property_change):
4937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4938 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4939 short is wide enough.
4940 (x_send_client_event): Don't assume fixnum fits in int.
4941 * xterm.c (x_x_to_emacs_modifiers):
4942 Don't assume EMACS_INT overflows nicely into int.
4943 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4944 may come from Lisp.
4945 (handle_one_xevent): NATNUMP can eval its arg twice.
4946 (x_connection_closed):
4947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4948 * xterm.h: Adjust decls to match defn changes elsewhere.
4949 (struct scroll_bar): Use struct vectorlike_header
4950 rather than rolling our own approximation.
4951 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4952
c6574eb5
GM
49532012-05-25 Glenn Morris <rgm@gnu.org>
4954
4955 * lisp.mk (lisp): Update for more files being compiled now.
4956
e8d32c7e
SM
49572012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4958
48def666
SM
4959 * lread.c: Remove `read_pure' which makes no difference.
4960 (read_pure): Remove var.
4961 (unreadpure): Remove function.
4962 (readevalloop): Don't call read_list with -1 flag.
4963 (read1, read_vector): Don't test read_pure any more.
4964 (read_list): Simplify.
4965
e8d32c7e
SM
4966 * fileio.c, character.h: Minor style tweaks.
4967
4b2addb7
DA
49682012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4969
4970 * window.h (clip_changed): Remove useless declaration.
4971
584461b2
JB
49722012-05-22 Juanma Barranquero <lekktu@gmail.com>
4973
4974 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4975 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4976
34374650
PE
49772012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 Remove src/m/*.
4980 This directory predates autoconf and is no longer needed nowadays.
4981 Move its few remaining bits of functionality to where they're needed.
4982 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4983 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4984 * m/template.h: Remove.
4985 * Makefile.in (M_FILE): Remove. All uses removed.
4986 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4987 * lisp.h (USE_LSB_TAG):
4988 * mem-limits.h (EXCEEDS_LISP_PTR):
4989 Use VAL_MAX, not VALBITS, in #if.
4990 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4991 (EMACS_UINT): Define unconditionally now.
4992 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4993 (BITS_PER_EMACS_INT): New constants, replacing
4994 what used to be in config.h, but not useful in #if.
4995 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4996 define them any more.
4997 (VAL_MAX): New macro.
4998 (VALMASK): Use it.
4999 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5000 BITS_PER_EMACS_INT, in #if.
5001 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5002 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5003 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5004 * s/ms-w32.h (DATA_START):
5005 Move here from removed file m/intel386.h.
5006 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5007 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5008
261cb4bb
PE
50092012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5010
5011 Assume C89 or later.
5012 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5013 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5014 (xrealloc):
5015 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5016 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5017 * textprop.c, tparam.c (NULL): Remove.
5018 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5019 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5020 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5021 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5022 * xterm.c (input_signal_count): Assume volatile works.
5023
ff23cd9f
KB
50242012-05-21 Ken Brown <kbrown@cornell.edu>
5025
5026 * xgselect.c (xg_select): Fix first argument in call to 'select'
5027 (bug#11508).
5028
1b170bc6
KB
50292012-05-20 Ken Brown <kbrown@cornell.edu>
5030
5031 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5032 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5033
b2f4d39f
KB
50342012-05-19 Ken Brown <kbrown@cornell.edu>
5035
5036 * xfns.c (x_in_use): Remove `static' qualifier.
5037 * xterm.h (x_in_use): Declare.
5038 * xgselect.c: Include xterm.h.
5039 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5040 and `display_arg' (bug#9754).
5041
003fdae2
PE
50422012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5043
9232a6d9
PE
5044 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5045
003fdae2
PE
5046 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5047 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5048
784b56e2
EZ
50492012-05-18 Eli Zaretskii <eliz@gnu.org>
5050
5051 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5052
5053 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5054 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5055
5056 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5057 reference to image_cache->refcount.
5058 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5059
a0a79cde
JL
50602012-05-17 Juri Linkov <juri@jurta.org>
5061
5062 * search.c (Fword_search_regexp, Fword_search_backward)
5063 (Fword_search_forward, Fword_search_backward_lax)
5064 (Fword_search_forward_lax): Move functions to isearch.el
5065 (bug#10145, bug#11381).
5066
b0572523
PE
50672012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5070
9660f5fc
SM
50712012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5072
5073 * lread.c (init_obarray): Declare Qt and Qnil as special.
5074
4374de83
GM
50752012-05-14 Glenn Morris <rgm@gnu.org>
5076
5077 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5078 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5079
dc44c39a
PE
50802012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5081
078c97cb
PE
5082 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5083
dc44c39a
PE
5084 * unexaix.c: Port to more-recent AIX compilers.
5085 (report_error, report_error_1, make_hdr, copy_sym)
5086 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5087 Make arguments const char *, not char *, to avoid violations of C
5088 standard and to fix some AIX warnings reported by Gilles Pion.
5089
e18afed7 50902012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5091
5092 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5093 already have overlays loaded.
5094 (handle_single_display_spec): Before returning without displaying
5095 fringe bitmap, synchronize the bidi iterator with the main display
5096 iterator, by calling iterate_out_of_display_property.
5097 (iterate_out_of_display_property): Detect buffer iteration by
5098 testing that it->string is a Lisp string.
5099 (get_next_display_element): When the current object is exhausted,
5100 and there's something on it->stack, call set_iterator_to_next to
5101 proceed with what's on the stack, instead of returning zero.
5102 (set_iterator_to_next): If called at the end of a Lisp string,
5103 proceed to consider_string_end without incrementing string
5104 position. Don't increment display vector index past the end of
5105 the display vector. (Bug#11417)
c8fb9dc6
EZ
5106 (pos_visible_p): Don't report a position visible when move_it_to
5107 stopped at the last line of window, which happens to be scanned
5108 backwards by the bidi iteration. (Bug#11464)
ac268e67 5109
e18afed7 51102012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5111
5112 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5113 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5114 are on a TTY, and thus unable to display on the fringes.
5115 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5116 so we need to signal to the caller that this is a "replacing"
5117 display spec. This fixes display when the spec is invalid or we
5118 are on a TTY.
5119
e18afed7 51202012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5121
5122 * unexaix.c (make_hdr): Fix typo in prototype.
5123 This bug broke the build on AIX. Problem reported by Gilles Pion.
5124
9d0a235a
MA
51252012-05-14 Michael Albinus <michael.albinus@gmx.de>
5126
5127 * keyboard.c (kbd_buffer_get_event): Read special events also in
5128 batch mode. (Bug#11415)
5129
9e6b06ed
GM
51302012-05-12 Glenn Morris <rgm@gnu.org>
5131
5132 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5133
c1a1d7a3
EZ
51342012-05-12 Eli Zaretskii <eliz@gnu.org>
5135
5136 * lisp.mk (lisp): Add newcomment.elc.
5137
3fe7cdc8
GM
51382012-05-12 Glenn Morris <rgm@gnu.org>
5139
5140 * Makefile.in (MKDIR_P): New, set by configure.
5141 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5142
53f7d2c0
PE
51432012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5144
5145 Remove unused function hourglass_started.
5146 * dispextern.h (hourglass_started):
5147 * w32fns.c (hourglass_started):
5148 * xdisp.c (hourglass_started): Remove.
5149
75aafb17
JB
51502012-05-10 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5153 Update dependencies.
5154
12959e8e
PE
51552012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5156
97107e2e
PE
5157 * xgselect.c (xg_select): Put maxfds+1 into a var.
5158 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5159
12959e8e
PE
5160 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5161
836d29b3
DA
51622012-05-10 Dave Abrahams <dave@boostpro.com>
5163
5164 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5165 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5166
5cb67954
MA
51672012-05-09 Michael Albinus <michael.albinus@gmx.de>
5168
5169 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5170 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5171 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5172 Initialize xd_registered_buses.
5173
3478ec45
PE
51742012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5175
b263a6b0
PE
5176 Untag more efficiently if USE_LSB_TAG.
5177 This is based on a proposal by YAMAMOTO Mitsuharu in
5178 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5179 For an admittedly artificial (nth 8000 longlist) benchmark on
5180 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5181 Emacs's overall text size by 1%.
5182 * lisp.h (XUNTAG): New macro.
5183 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5184 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5185 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5186 * eval.c (Fautoload):
5187 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5188 * frame.h (XFRAME): Use XUNTAG.
5189
3478ec45
PE
5190 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5191 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5192 Remove unportable assumptions about print widths of types like
5193 dbus_uint32_t.
5194 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5195 intptr_t when converting between pointer and integer, to avoid GCC
5196 warnings about wrong width.
5197
666b903b 51982012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5199
5200 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5201 stack for each reader_thread, instead of defaulting to 8MB
5202 determined by the linker. This avoids failures in creating
5203 subprocesses on Windows 7, see the discussion in this thread:
5204 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5205
b120cc17
JC
52062012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5207
5208 Fix up display of the *Minibuf-0* buffer in the mini window.
5209 * keyboard.c (read_char): Don't clear the echo area if there's no
5210 message to clear.
5211 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5212 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5213
9a4b36f8
MA
52142012-05-07 Michael Albinus <michael.albinus@gmx.de>
5215
5216 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5217 batch mode.
5218
e5f9458f
CY
52192012-05-06 Chong Yidong <cyd@gnu.org>
5220
5221 * lisp.mk (lisp): Update.
5222
eceeb5fc 52232012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5224
5225 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5226
71873e2b
SM
52272012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5228
5229 * data.c (PUT_ERROR): New macro.
5230 (syms_of_data): Use it. Add new error type `user-error'.
5231 * undo.c (user_error): New function.
5232 (Fprimitive_undo): Use it.
5233 * print.c (print_error_message): Adjust print style for `user-error'.
5234 * keyboard.c (user_error): New function.
5235 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5236
ab0fa4e4
PE
52372012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5238
5239 Do not limit current-time-string to years 1000..9999.
5240 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5241 (Fcurrent_time_string): Support any year that is supported by the
5242 underlying localtime representation. Don't use asctime, as it
5243 has undefined behavior for years outside the range -999..9999.
5244
7ed806a7
PE
52452012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 Fix race conditions involving setenv, gmtime, localtime, asctime.
5248 Without this fix, interrupts could mess up code that uses these
5249 nonreentrant functions, since setting TZ invalidates existing
5250 tm_zone or tzname values, and since most of these functions return
5251 pointers to static storage.
5252 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5253 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5254 Grow the critical sections to include not just invoking
5255 localtime/gmtime, but also accessing these functions' results
5256 including their tm_zone values if any, and any related TZ setting.
5257 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5258 so that the struct tm is saved in the critical section.
5259 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5260 motivated by the fact that memory allocation needs to be outside
5261 the critical section.
5262
0c16dfed
DA
52632012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5264
5265 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5266 with RESET_INTERVAL.
5267
5268 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5269 Remove duplicated buffer name initialization.
5270
3f83ace8
JM
52712012-05-02 Jim Meyering <jim@meyering.net>
5272
5273 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5274
c7b8541e
JM
5275 * xfns.c (x_window): Use xstrdup (Bug#11375).
5276
90207a15 52772012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5278
5279 * xdisp.c (pos_visible_p): If already at a newline from the
5280 display string before the 'while' loop, don't walk back the glyphs
5281 from it3.glyph_row. Solves assertion violation when the display
5282 string begins with a newline (egg.el). (Bug#11367)
5283
b593d6a9
AH
52842012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5285
5286 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5287 Move to simple.el.
5288
4737362e
GM
52892012-05-01 Glenn Morris <rgm@gnu.org>
5290
99cf43f9
GM
5291 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5292 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5293 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5294 All were removed before 23.1.
5295
9311dcff
GM
5296 * dispnew.c: Remove HAVE_LIBNCURSES test;
5297 it is always true on relevant platforms.
5298
4d5c6349
GM
5299 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5300 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5301
4737362e
GM
5302 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5303
74dd3a6b
AS
53042012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5305
5306 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5307 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5308 Remove.
5309
13c379ee
PE
53102012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5311
5312 Do not avoid creating empty evaporating overlays (Bug#9642).
5313 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5314 That is, do not delete an evaporating overlay if it becomes
5315 empty after its bounds are adjusted to fit within its buffer.
5316 This fix caused other problems, and I'm reverting it until we get
5317 to the bottom of them.
5318
a8e7d6d7 53192012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5320
5321 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5322
a8e7d6d7 53232012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5324
5325 * xdisp.c (pos_visible_p): If the window start position is beyond
5326 ZV, start the display from buffer beginning. Prevents assertion
5327 violation in init_iterator when the minibuffer window is scrolled
5328 via the scroll bar.
5329
5330 * window.c (window_scroll_pixel_based): Likewise.
5331
a8e7d6d7 53322012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5333
5334 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5335
a8e7d6d7 53362012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5337
5338 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5339 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5340
a8e7d6d7 53412012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5342
b593d6a9
AH
5343 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5344 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5345
1c6900d9
EZ
53462012-04-26 Eli Zaretskii <eliz@gnu.org>
5347
4c3fa1d9
EZ
5348 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5349 display element, check also the underlying string or buffer
5350 character. (Bug#11341)
5351
1c6900d9
EZ
5352 * w32menu.c: Include w32heap.h.
5353 (add_menu_item): If the call to AppendMenuW (via
5354 unicode_append_menu) fails, disable Unicode menus only if we are
5355 running on Windows 9X/Me.
5356
42bf8205
AS
53572012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5358
5359 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5360 (xgetint): Add missing shift for LSB tags.
5361
b1bac16e
MR
53622012-04-24 Martin Rudalics <rudalics@gmx.at>
5363
5364 * keyboard.c (read_char): Don't wipe echo area for select window
5365 events: These might get delayed via `mouse-autoselect-window'
5366 (Bug#11304).
5367
d69621cc
JB
53682012-04-24 Juanma Barranquero <lekktu@gmail.com>
5369
5370 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5371 manipulation of :loaded-from data.
5372
02fd101b
JB
53732012-04-23 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5376 now a cons (bug#11311).
5377
888bec30
PE
53782012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5379
89a438bd
PE
5380 Do not create empty overlays with the evaporate property (Bug#9642).
5381 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5382 if it becomes empty after its bounds are adjusted to fit within
5383 its buffer. Without this fix, in a nonempty buffer (let ((o
5384 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5385 yields an empty overlay that has the evaporate property, which is
5386 not supposed to happen.
5387
1068fe4d
PE
5388 Fix minor GTK3 problems found by static checking.
5389 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5390 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5391 (struct _EmacsFixedClass, emacs_fixed_get_type):
5392 Move decls here from emacsgtkfixed.h, since they needn't be public.
5393 (emacs_fixed_get_type): Now static.
5394 (emacs_fixed_class_init): Omit unused local.
5395 (emacs_fixed_child_type): Remove; unused.
5396 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5397 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5398 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5399 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5400 (EMACS_FIXED_GET_CLASS): Remove; unused.
5401 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5402
888bec30
PE
5403 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5404 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5405
de85e130
PE
54062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5407
d0baac98 5408 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5409 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5410 (__malloc_size_t, __malloc_ptrdiff_t):
5411 Remove. All uses removed, replaced by the definiens if needed,
5412 since we can assume C89 or better now.
5413 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5414 (protect_malloc_state, align, get_contiguous_space)
5415 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5416 (malloc_atfork_handler_child, malloc_enable_thread)
5417 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5418 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5419 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5420 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5421 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5422 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5423 Define using prototypes, not old style.
5424 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5425 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5426 (align): Don't assume that signed integer overflow wraps around.
5427 Omit unused local var.
5428 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5429 (_free_internal_nolock, memalign, mallochook, reallochook):
5430 Omit no-longer-needed casts.
5431 (valloc): Use getpagesize, not __getpagesize.
5432 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5433 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5434
de85e130
PE
5435 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5436
dcbf5805
MA
54372012-04-22 Michael Albinus <michael.albinus@gmx.de>
5438
5439 Move functions from C to Lisp. Make non-blocking method calls
5440 the default. Implement further D-Bus standard interfaces.
5441
5442 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5443 (QCdbus_request_name_allow_replacement)
5444 (QCdbus_request_name_replace_existing)
5445 (QCdbus_request_name_do_not_queue)
5446 (QCdbus_request_name_reply_primary_owner)
5447 (QCdbus_request_name_reply_in_queue)
5448 (QCdbus_request_name_reply_exists)
5449 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5450 (QCdbus_registered_serial, QCdbus_registered_method)
5451 (QCdbus_registered_signal): New Lisp objects.
5452 (XD_DEBUG_MESSAGE): Use sizeof.
5453 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5454 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5455 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5456 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5457 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5458 (xd_signature, xd_append_arg): Allow float for integer types.
5459 (xd_get_connection_references): New function.
b593d6a9
AH
5460 (xd_get_connection_address): Rename from xd_initialize.
5461 Return cached address.
dcbf5805
MA
5462 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5463 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5464 level.
5465 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5466 Return number of refcounts.
dcbf5805
MA
5467 (Fdbus_get_unique_name): Make stronger parameter check.
5468 (Fdbus_message_internal): New defun.
5469 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5470 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5471 (Fdbus_send_signal, Fdbus_register_service)
5472 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5473 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5474 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5475 (Vdbus_compiled_version, Vdbus_runtime_version)
5476 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5477 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5478 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5479 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5480 Adapt docstring.
dcbf5805 5481
52828e02
PE
54822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5483
da05bc4c
PE
5484 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5485 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5486 Do not assume ptrdiff_t is the same width as 'int'.
5487
52828e02
PE
5488 * alloc.c: Handle unusual debugging option combinations.
5489 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5490 since the two debugging options are incompatible.
5491 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5492 is defined.
5493 (mem_init, mem_insert, mem_insert_fixup):
5494 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5495 (NEED_MEM_INSERT): Remove; no longer needed.
5496
f01769f9
LL
54972012-04-22 Leo Liu <sdl.web@gmail.com>
5498
5499 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5500
5790543d
PE
55012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5502
5503 * sysdep.c [__FreeBSD__]: Minor cleanups.
5504 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5505 Use Emacs indenting style more consistently. Avoid some casts.
5506 Use 'double' consistently rather than mixing 'float' and 'double'.
5507
b91b7e4d
EW
55082012-04-21 Eduard Wiebe <usenet@pusto.de>
5509
b593d6a9
AH
5510 * sysdep.c (list_system_processes, system_process_attributes):
5511 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5512
6114eb15
AS
55132012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5514
5515 * lisp.mk (lisp): Update.
5516
2f38dff7
PE
55172012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5518
5519 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5520 It is never used otherwise.
5521
4ae29f89
SM
55222012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5523
5524 * print.c (print_preprocess): Only check print_depth if print-circle
5525 is nil.
5526 (print_object): Check for cycles even when print-circle is nil and
5527 print-gensym is t, but only check print_depth if print-circle is nil.
5528
f30d612a
CY
55292012-04-20 Chong Yidong <cyd@gnu.org>
5530
5531 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5532 set the status to "failed" and ensure that sentinel is run.
5533
c07a4c0b 55342012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5535
5536 * process.c (Fset_process_inherit_coding_system_flag)
5537 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5538 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5539
c07a4c0b 55402012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5541
5542 * xdisp.c (string_buffer_position_lim): Limit starting position to
5543 BEGV.
5544 (set_cursor_from_row): If called for a mode-line or header-line
5545 row, return zero immediately.
5546 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5547 farther than the first row after the header line, if any.
5548 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5549 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5550
c07a4c0b 55512012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5552
4ae29f89
SM
5553 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5554 (bug#11238).
ad3a2b41 5555
c07a4c0b 55562012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 55572012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5558
5559 configure: new option --enable-gcc-warnings (Bug#11207)
5560 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5561 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5562 (ALL_CFLAGS): Use new macros rather than old.
5563 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5564 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5565 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5566 -Wunused-result, -Wunused-variable. This should go away once
5567 the Emacs and Gnulib regex code is merged.
5568 (xmalloc, xrealloc): Now static.
5569
aba027e8
PE
55702012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 * dired.c (Fsystem_groups): Remove unused local.
5573
e5a36063
GM
55742012-04-17 Glenn Morris <rgm@gnu.org>
5575
5576 * dired.c (Fsystem_users): Doc fix.
5577
316411f0
DA
55782012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5579
5580 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5581 (syms_of_dired): Add them.
5582
9426aba4
PE
55832012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5584
b62a57be
PE
5585 Fix minor alloc.c problems found by static checking.
5586 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5587 New extern decls, to avoid calling undeclared functions.
5588 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5589 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5590 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5591 (NEED_MEM_INSERT): New macro.
5592 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5593 Remove one incorrect comment and fix another.
b62a57be 5594
3539f31f
PE
5595 Fix minor ralloc.c problems found by static checking.
5596 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5597 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5598 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5599 (r_alloc_sbrk): Now static.
5600
a041960a
PE
5601 Improve ralloc.c interface checking.
5602 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5603 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5604 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5605 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5606 [REL_ALLOC]: ... to here, to check interface.
5607 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5608 Remove decls. This fixes an "It stinks!".
5609
9426aba4
PE
5610 * alloc.c (which_symbols): Fix alignment issue / type clash.
5611
d55c12ed
AS
56122012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5613
5614 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5615 (struct Lisp_Misc_Any): Likewise.
5616 (struct Lisp_Free): Likewise.
5617 * alloc.c (union aligned_Lisp_Symbol): Define.
5618 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5619 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5620 (union aligned_Lisp_Misc): Define.
5621 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5622 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5623 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5624
b948ce8b
PE
56252012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5626
5627 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5628 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5629 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5630 * s/netbsd.h, s/sol2-6.h:
5631 Remove definition of GC_MARK_STACK, since the default now works.
5632 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5633 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5634 no longer the default.
5635 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5636
35dc09a1 56372012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5638
35dc09a1
GM
5639 * lread.c (lisp_file_lexically_bound_p):
5640 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5641
35dc09a1
GM
56422012-04-14 Eli Zaretskii <eliz@gnu.org>
5643
5644 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5645 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5646
56472012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5648
5649 * nsterm.m (constrainFrameRect): Always constrain when there is only
5650 one screen (Bug#10962).
5651
bcd86815
KB
56522012-04-13 Ken Brown <kbrown@cornell.edu>
5653
5654 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5655
c25df26e
RT
56562012-04-13 Reuben Thomas <rrt@sc3d.org>
5657
5658 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5659
0fc59f1e
DC
56602012-04-11 Daniel Colascione <dancol@dancol.org>
5661
5662 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5663 against is gone. It's better to use vfork now so that when Cygwin
5664 gains a new, working vfork, we use it automatically (bug#10398).
5665
de8c03dc
SM
56662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5667
5668 * window.c (save_window_save): Obey window-point-insertion-type.
5669
2f097256
GM
56702012-04-11 Glenn Morris <rgm@gnu.org>
5671
5672 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5673
453b951e
SM
56742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5675
5676 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5677
75f1671a 56782012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5679
5680 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5681 (force_quit_count): New var.
5682 (handle_interrupt): Use it.
5683
2a8ce227
JB
56842012-04-10 Juanma Barranquero <lekktu@gmail.com>
5685
5686 * w32.c (w32_delayed_load): Record the full path of the library
5687 being loaded (bug#10424).
5688
935396c0
GM
56892012-04-09 Glenn Morris <rgm@gnu.org>
5690
05920a43
GM
5691 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5692 not just in the obarray, before snarfing them. (Bug#11036)
5693
935396c0
GM
5694 * Makefile.in ($(leimdir)/leim-list.el):
5695 Pass EMACS rather than BUILT_EMACS.
5696
a18ecafa
TZ
56972012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5698
5699 * process.c (make_process):
5700 * process.h: Add integer `gnutls_handshakes_tried' member to
5701 process struct.
5702
6bbef4e5
JC
5703 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5704 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5705
5706 * gnutls.c (gnutls_log_function2i): Convenience log function.
5707 (emacs_gnutls_read): Use new log functions,
5708 `gnutls_handshakes_tried' process member, and
5709 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5710 attempts per process (connection).
5711
b4d3bc10
CY
57122012-04-09 Chong Yidong <cyd@gnu.org>
5713
5714 * eval.c (Fuser_variable_p, user_variable_p_eh)
5715 (lisp_indirect_variable): Functions deleted.
5716 (Fdefvar): Caller changed.
5717
5718 * callint.c (Finteractive, Fcall_interactively):
5719 * minibuf.c (Fread_variable): Callers changed.
5720
70f4d973
EZ
57212012-04-09 Eli Zaretskii <eliz@gnu.org>
5722
5723 * xdisp.c (set_cursor_from_row): If the display string appears in
5724 the buffer at position that is closer to point than the position
5725 after the display string, display the cursor on the first glyph of
5726 the display string. Fixes cursor display when a 'display' text
5727 property immediately follows invisible text. (Bug#11094)
5728
cb3c2e3e
PE
57292012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 composite.c: use 'double' consistently
5732 * composite.c (get_composition_id): Use 'double' consistently
5733 instead of converting 'float' to 'double' and vice versa; this is
5734 easier to understand and avoids a GCC warning.
5735
fd06db5d
GM
57362012-04-09 Glenn Morris <rgm@gnu.org>
5737
50fe702a
GM
5738 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5739 preparation for dumping it with emacs. (Bug#4789)
5740 (leimdir): New variable.
5741 ($(leimdir)/leim-list.el): New rule.
5742 (emacs$(EXEEXT)): Depend on leim-list.el.
5743
fd06db5d
GM
5744 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5745 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5746 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5747
55c131ee
AS
57482012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5749
5750 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5751 proper alignment.
5752
9209588f
JB
57532012-04-07 Juanma Barranquero <lekktu@gmail.com>
5754
5755 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5756 Remove unused local variable.
5757
e3fb2efb
PE
57582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5759
5760 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5761 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5762 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5763 objects, as mark_maybe_pointer will catch them otherwise.
5764 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5765 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5766
b5385551
PE
57672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5768
5769 Fix typo that broke non-Windows builds.
5770 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5771
9078ead6
EZ
57722012-04-07 Eli Zaretskii <eliz@gnu.org>
5773
5774 Support building on MS-Windows with libxml2.
5775
5776 * makefile.w32-in (OBJ2): Add xml.$(O).
5777 (GLOBAL_SOURCES): Add xml.c.
5778 ($(BLD)/xml.$(O)): New dependency list.
5779
5780 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5781 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5782 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5783 [!WINDOWSNT]: New macros.
5784 (init_libxml2_functions, libxml2_loaded_p): New functions.
5785 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5786 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5787 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5788 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5789 linked in).
6bbef4e5
JC
5790 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5791 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5792 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5793
5794 * emacs.c: Don't include libxml/parser.h.
5795 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5796 xmlCleanupParser directly.
5797
5798 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5799
3811fdf3
EZ
58002012-04-07 Eli Zaretskii <eliz@gnu.org>
5801
5802 * indent.c (Fvertical_motion): If there is a display string at
5803 point, use it.vpos to compute how many lines to backtrack after
5804 move_it_to point. (Bug#11133)
5805
2f8e16b2
EZ
58062012-04-06 Eli Zaretskii <eliz@gnu.org>
5807
5808 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5809 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5810 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5811 macros related to unification of CJK characters. For the details,
5812 see the discussion following the message here:
5813 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5814
3d439cd1
CY
58152012-04-04 Chong Yidong <cyd@gnu.org>
5816
5817 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5818
8bc53d00
EZ
58192012-04-01 Eli Zaretskii <eliz@gnu.org>
5820
5821 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5822 instead of alloca. (Bug#11138)
5823
3b0512a3
AS
58242012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5825
5826 * w32menu.c (is_simple_dialog): Properly check lisp types.
5827 (Bug#11141)
5828
8427ddd2
EZ
58292012-03-31 Eli Zaretskii <eliz@gnu.org>
5830
979022ef
EZ
5831 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5832 position we get to after a call to move_it_to fails the
5833 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5834 only if we wind up in a string from display property. (Bug#11063)
5835
a6b1c7cc
EZ
5836 * window.c (Fdelete_other_windows_internal): Invalidate the row
5837 and column information about mouse highlight, so that redisplay
5838 restores it after reallocating the glyph matrices. (Bug#7464)
5839
8427ddd2
EZ
5840 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5841 string comes from a `display' text property, use the buffer
5842 position of that property as if we actually saw that position in
5843 the row's glyphs.
697ba24b
EZ
5844 (move_it_by_lines): Remove the assertion that
5845 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5846 violated when there's a before-string at the beginning of a line.
5847 (Bug#11063)
8427ddd2 5848
65a0a738
EZ
58492012-03-30 Eli Zaretskii <eliz@gnu.org>
5850
5851 * xdisp.c (append_space_for_newline): If the default face was
5852 remapped, use the remapped face for the appended newline.
5853 (extend_face_to_end_of_line): Use the remapped default face for
5854 extending the face to the end of the line.
5855 (display_line): Call extend_face_to_end_of_line when the default
5856 face was remapped. (Bug#11068)
5857
581355cc
EZ
58582012-03-29 Eli Zaretskii <eliz@gnu.org>
5859
5860 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5861
e8fc049f
SM
58622012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5863
5864 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5865
4fb9a543
GM
58662012-03-27 Glenn Morris <rgm@gnu.org>
5867
5868 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5869 Doc fixes.
5870
679910f1
KH
58712012-03-26 Kenichi Handa <handa@m17n.org>
5872
5873 * dispextern.h (struct glyph): Fix previous change. Change the
5874 bit length of glyphless.ch to 25 (Bug#11082).
5875
90d49b7f
CY
58762012-03-26 Chong Yidong <cyd@gnu.org>
5877
5878 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5879 (command_loop_1): Use it; inhibit selection update for
5880 handle-select-window too (Bug#8996).
5881
f514f6f0
FP
58822012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5883
e8fc049f 5884 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5885
bf43fa51
KH
58862012-03-25 Kenichi Handa <handa@m17n.org>
5887
5888 * dispextern.h (struct glyph): Change the bit length of
5889 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5890
8a0c01dd
EZ
58912012-03-24 Eli Zaretskii <eliz@gnu.org>
5892
5893 * s/ms-w32.h (tzname): Include time.h before redirecting to
5894 _tzname. Fixes the MSVC build. (Bug#9960)
5895
7d1c3a76
AS
58962012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5897
8ed79523
AS
5898 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5899 characters.
5900
7d1c3a76
AS
5901 * xterm.c (XTread_socket): Only modify handling_signal if
5902 !SYNC_INPUT. (Bug#11080)
5903
e99a9b8b
EZ
59042012-03-23 Eli Zaretskii <eliz@gnu.org>
5905
5906 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5907 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5908 when fetching a multibyte character consumes more bytes than
5909 CHAR_BYTES returns, due to unification of CJK characters in
5910 string_char. (Bug#11073)
5911
5063c0e1
TN
59122012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5913
5914 * process.c (wait_reading_process_output): Handle pty disconnect
5915 by refraining from sending oneself a SIGCHLD (bug#10933).
5916
9f851fbd
CY
59172012-03-22 Chong Yidong <cyd@gnu.org>
5918
5919 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5920
5063c0e1 5921 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5922 Mark string as coming from a prefix property.
5923 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5924 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5925
fb5b8aca
CY
59262012-03-21 Chong Yidong <cyd@gnu.org>
5927
5928 * xfaces.c (Vface_remapping_alist): Doc fix.
5929
62356a1b
EZ
59302012-03-20 Eli Zaretskii <eliz@gnu.org>
5931
5932 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5933 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5934 Doc fixes.
62356a1b 5935
025de85b
CY
59362012-03-20 Chong Yidong <cyd@gnu.org>
5937
5938 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5939 to reflect default non-nil value of redisplay-dont-pause.
5940
4827f94e
KH
59412012-03-19 Kenichi Handa <handa@m17n.org>
5942
5943 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5944 it fit in a valid range (Bug#11003).
5945
e50a24a2
EZ
59462012-03-18 Eli Zaretskii <eliz@gnu.org>
5947
5948 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5949 that is not from display property, accept the row as a "cursor
5950 row" if one of the string's character has a non-nil `cursor'
5951 property. Fixes cursor positioning when there are newlines in
5952 overlay strings, e.g. in icomplete.el. (Bug#11035)
5953
9af5ed87
PE
59542012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5955
5956 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5957
d1f55f16
CY
59582012-03-12 Chong Yidong <cyd@gnu.org>
5959
5960 * eval.c (inhibit_lisp_code): Rename from
5961 inhibit_window_configuration_change_hook; move from window.c.
5962
5963 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5964 * window.c (run_window_configuration_change_hook)
5965 (syms_of_window): Callers changed.
5966
66c5eebd
CY
59672012-03-11 Chong Yidong <cyd@gnu.org>
5968
413df973
CY
5969 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5970
66c5eebd
CY
5971 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5972
1de11f56
CY
59732012-03-10 Chong Yidong <cyd@gnu.org>
5974
5975 * frame.c (other_visible_frames): Don't assume the selected frame
5976 is visible (Bug#10955).
5977
cae07000
SM
59782012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5979
5980 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5981
89c94350
JD
59822012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5983
5984 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5985 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5986 zero (Bug#10954).
5987
999dd333
GM
59882012-03-03 Glenn Morris <rgm@gnu.org>
5989
01a6dcc8 5990 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5991
de0100f2
EZ
59922012-03-02 Eli Zaretskii <eliz@gnu.org>
5993
5994 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5995 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5996 (redisplay_window, next_element_from_string): Fix typos in
5997 comments.
3e441275
EZ
5998 (redisplay_window): Pass to move_it_vertically the margin in
5999 pixels, not in screen lines.
de0100f2 6000
96a72ee9
GM
60012012-03-02 Glenn Morris <rgm@gnu.org>
6002
6003 * buffer.c (buffer-list-update-hook): Doc fix.
6004
312508d7
EZ
60052012-02-29 Eli Zaretskii <eliz@gnu.org>
6006
6007 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6008 push_it before setting up the iterator for the first overlay
6009 string, even if we have an empty string loaded.
6010 (next_overlay_string): If there's an empty string on the iterator
6011 stack, pop the stack. (Bug#10903)
6012
27f3c637
PE
60132012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6014
6015 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6016 Suggested by Stefan Monnier in
6017 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6018 * alloc.c (widen_to_Lisp_Object): New static function.
6019 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6020 and widening them to Lisp_Objects. This would work even if
6021 USE_LSB_TAG is defined and wide integers are used, which might
6022 happen in a future version of Emacs.
6023
3c9dfce6
CY
60242012-02-25 Chong Yidong <cyd@gnu.org>
6025
fa74b241
CY
6026 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6027 Doc fix.
6028
3c9dfce6
CY
6029 * xselect.c (Fx_selection_exists_p): Doc fix.
6030 (x_clipboard_manager_save_all): Print an informative message
6031 before saving to clipboard manager.
6032
9486df08
CY
60332012-02-24 Chong Yidong <cyd@gnu.org>
6034
6035 * keyboard.c (process_special_events): Handle all X selection
6036 requests in kbd_buffer, not just the next one (Bug#8869).
6037
f01d3321
CY
60382012-02-23 Chong Yidong <cyd@gnu.org>
6039
6040 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6041 call when setting menu-bar-lines and tool-bar-lines parameters.
6042 (unwind_create_frame_1): New helper function.
6043
6044 * window.c (inhibit_window_configuration_change_hook): New var.
6045 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6046 (syms_of_window): Initialize it.
f01d3321 6047
86b847b6
CY
60482012-02-22 Chong Yidong <cyd@gnu.org>
6049
6050 * xterm.c (x_draw_image_relief): Add missing type check for
6051 Vtool_bar_button_margin (Bug#10743).
6052
a59225b1
CY
60532012-02-21 Chong Yidong <cyd@gnu.org>
6054
6055 * fileio.c (Vfile_name_handler_alist): Doc fix.
6056
6057 * buffer.c (Fget_file_buffer): Protect against invalid file
6058 handler return value.
6059
310f5bd4
PE
60602012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6061
cb3a28cc
PE
6062 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6063 when computing $valmask.
6064
310f5bd4
PE
6065 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6066 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6067 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6068 It's useless in that case, and it can cause problems on hosts
6069 that allocate halves of EMACS_INT values separately.
6070 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6071 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6072 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6073 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6074 it avoids undefined behavior on hosts where shifting right by more
6075 than the word width has undefined behavior.
6076
2375c96a
CY
60772012-02-19 Chong Yidong <cyd@gnu.org>
6078
6079 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6080 (Funhandled_file_name_directory, Ffile_name_as_directory)
6081 (Fdirectory_file_name, Fexpand_file_name)
6082 (Fsubstitute_in_file_name): Protect against invalid file handler
6083 return values (Bug#10845).
6084
3eb49e71
EZ
60852012-02-18 Eli Zaretskii <eliz@gnu.org>
6086
6087 * .gdbinit (pitx): Fix incorrect references to fields of the
6088 iterator stack.
6089
7b926f3f
CY
60902012-02-17 Chong Yidong <cyd@gnu.org>
6091
6092 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6093
11273115
PE
60942012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6095
6096 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6097 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6098
c3a70e2b
CY
60992012-02-15 Chong Yidong <cyd@gnu.org>
6100
6101 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6102 marked as special. Also, starting docstrings with * is obsolete.
6103
0ca43699
AS
61042012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6105
6106 * gnutls.c (emacs_gnutls_write): Fix last change.
6107
2e8f3c56
LI
61082012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6109
6110 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6111 send_process.
6112
af70074f
SM
61132012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6114
6115 * keymap.c (Fsingle_key_description): Handle char ranges.
6116
95986d52
CY
61172012-02-12 Chong Yidong <cyd@gnu.org>
6118
afd83bd1
CY
6119 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6120 as that creates a dangerous corner case.
6121
95986d52
CY
6122 * window.c (Fdelete_window_internal): Invalidate the mouse
6123 highlight (Bug#9904).
6124
bd7da63e
GM
61252012-02-12 Glenn Morris <rgm@gnu.org>
6126
6127 * xselect.c (Fx_own_selection_internal)
6128 (Fx_get_selection_internal, Fx_disown_selection_internal)
6129 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6130 * nsselect.m (Fx_own_selection_internal)
6131 (Fx_disown_selection_internal, Fx_selection_exists_p)
6132 (Fx_selection_owner_p, Fx_get_selection_internal):
6133 Sync docs and argument specs with the xselect.c versions.
6134
77abcbc2
LI
61352012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6136
6137 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6138
90b671e2
EZ
61392012-02-11 Eli Zaretskii <eliz@gnu.org>
6140
1c0ca0b7
EZ
6141 * w32select.c (Fx_selection_exists_p): Sync doc string and
6142 argument list with xselect.c. (Bug#10783)
6143
6144 * w16select.c (Fx_selection_exists_p): Sync doc string and
6145 argument list with xselect.c. (Bug#10783)
90b671e2 6146
49241268
GM
61472012-02-10 Glenn Morris <rgm@gnu.org>
6148
6149 * fns.c (Fsecure_hash): Doc fix.
6150
f998bbe7 61512012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6152
6153 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6154
0992bd9c
CY
61552012-02-07 Chong Yidong <cyd@gnu.org>
6156
6157 * buffer.c (Fbuffer_local_variables)
6158 (buffer_lisp_local_variables): Handle unbound vars correctly;
6159 don't let Qunbound leak into Lisp.
6160
af008560
GM
61612012-02-07 Glenn Morris <rgm@gnu.org>
6162
dd605cc4
GM
6163 * image.c (Fimagemagick_types): Doc fix.
6164
af008560
GM
6165 * image.c (imagemagick-render-type): Change it from a lisp object
6166 to an integer. Move the doc here from the lisp manual.
6167 Treat all values not equal to 0 the same.
6168
1449fa1d
CY
61692012-02-06 Chong Yidong <cyd@gnu.org>
6170
6171 * doc.c (store_function_docstring): Avoid applying docstring of
6172 alias to base function (Bug#2603).
6173
3723ec07
AS
61742012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6175
6176 * .gdbinit (pp1, pv1): Remove redundant defines.
6177 (pr): Use pp.
6178
79c1cc1e
CY
61792012-02-04 Chong Yidong <cyd@gnu.org>
6180
6181 * nsterm.m: Declare a global (Bug#10694).
6182
d7f29f8e
EZ
61832012-02-04 Eli Zaretskii <eliz@gnu.org>
6184
cae07000
SM
6185 * w32.c (get_emacs_configuration_options):
6186 Include --enable-checking, if specified, in the return value.
d7f29f8e 6187
3b95a6f9
MR
61882012-02-04 Martin Rudalics <rudalics@gmx.at>
6189
6190 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6191 after rounding frame sizes. (Bug#9723)
6192
d6fa96a6
EZ
61932012-02-04 Eli Zaretskii <eliz@gnu.org>
6194
6195 * keyboard.c (adjust_point_for_property): Don't position point
6196 before BEGV. (Bug#10696)
6197
df0b2940
PE
61982012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6199
6200 Handle overflow when computing char display width (Bug#9496).
6201 * character.c (char_width): Return EMACS_INT, not int.
6202 (char_width, c_string_width): Check for overflow when
6203 computing the width; this is possible now that individual
6204 characters can have unbounded width. Problem introduced
6205 by merge from Emacs 23 on 2012-01-19.
6206
6bee44d6
MA
62072012-02-02 Michael Albinus <michael.albinus@gmx.de>
6208
6209 * dbusbind.c (Fdbus_register_method): Mention the return value
6210 :ignore in the docstring.
6211
44f92739
GM
62122012-02-02 Glenn Morris <rgm@gnu.org>
6213
1b9f60cc
GM
6214 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6215
44f92739
GM
6216 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6217 Unconditionally set to t. (Bug#10673)
6218 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6219 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6220 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6221
c5d3843c
KH
62222012-02-02 Kenichi Handa <handa@m17n.org>
6223
6224 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6225 0, do not call append_composite_glyph.
6226
159462d4 62272012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6228
6229 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6230 NULL (Bug#6988).
6231 (x_produce_glyphs): If the component of a composition is a null
6232 string, set it->pixel_width to 1 to avoid zero-width glyph.
6233
78cef877
EZ
62342012-02-01 Eli Zaretskii <eliz@gnu.org>
6235
6236 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6237 first 2 arguments are identical. This makes inserting large
6238 output from a subprocess an order of magnitude faster on
6239 MS-Windows, where all sbrk'ed memory is always contiguous.
6240
97897668
GM
62412012-01-31 Glenn Morris <rgm@gnu.org>
6242
6243 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6244 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6245 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6246
31fd3586
GM
62472012-01-29 Glenn Morris <rgm@gnu.org>
6248
6249 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6250
0e24a8b2
CY
62512012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6252
6253 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6254
cc0adcb0
CY
62552012-01-28 Chong Yidong <cyd@gnu.org>
6256
6257 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6258
acc28cb9
CY
62592012-01-26 Chong Yidong <cyd@gnu.org>
6260
9c69cfb7
CY
6261 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6262
acc28cb9
CY
6263 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6264 repeat counts (Bug#10507).
6265
48da7392
GM
62662012-01-26 Glenn Morris <rgm@gnu.org>
6267
6268 * lread.c (syms_of_lread): Doc fix.
6269
14af5f7f
CY
62702012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6271
6272 * coding.c (encode_designation_at_bol): Change return value to
6273 EMACS_INT.
6274
0b21c100
CY
62752012-01-25 Chong Yidong <cyd@gnu.org>
6276
6277 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6278
3c2907f7
CY
62792012-01-21 Chong Yidong <cyd@gnu.org>
6280
6281 * floatfns.c (Fcopysign): Make the second argument non-optional,
6282 since nil is not allowed anyway.
6283
959ad23f
AS
62842012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6285
6286 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6287 (send_process): Likewise.
6288
34a02f46
MR
62892012-01-19 Martin Rudalics <rudalics@gmx.at>
6290
6291 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6292 (Vwindow_persistent_parameters): Do not use Qstate.
6293 Rewrite doc-strings.
34a02f46 6294
1259009a 62952012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6296
6297 * character.c (char_width): New function.
70d4fdf6
GM
6298 (Fchar_width, c_string_width, lisp_string_width):
6299 Use char_width (Bug#9496).
25ed9e61 6300
6a6ee00d
MR
63012012-01-16 Martin Rudalics <rudalics@gmx.at>
6302
6303 * window.c (Vwindow_persistent_parameters): New variable.
6304 (Fset_window_configuration, save_window_save): Handle persistent
6305 window parameters.
6306
c85efaf7
EZ
63072012-01-14 Eli Zaretskii <eliz@gnu.org>
6308
6309 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6310 thrashing the stack of the thread. (Bug#9087)
6311
5944709e
PE
63122012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6313
6314 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6315
e71f5d99
EZ
63162012-01-11 Eli Zaretskii <eliz@gnu.org>
6317
6318 * xdisp.c (rows_from_pos_range): Handle the case where the
6319 highlight ends on a newline. (Bug#10464)
6320 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6321 he end column for display of highlight that ends on a newline
6322 before a R2L line.
6323
ce316182
GM
63242012-01-11 Glenn Morris <rgm@gnu.org>
6325
6326 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6327 from load-path also when installation-directory is nil. (Bug#10208)
6328
5b43da69
GM
63292012-01-10 Glenn Morris <rgm@gnu.org>
6330
74cc8ff9
GM
6331 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6332
7d8d6e4e
GM
6333 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6334 Update template values to be closer to their typical values these days.
5b43da69 6335
a0db8d43
EZ
63362012-01-09 Eli Zaretskii <eliz@gnu.org>
6337
6338 * xdisp.c (rows_from_pos_range): Accept additional argument
6339 DISP_STRING, and accept any glyph in a row whose object is that
6340 string as eligible for mouse highlight. Fixes mouse highlight of
6341 display strings from overlays. (Bug#10464)
6342
9a0115ab 63432012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6344
b9110d6a 6345 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6346 * fileio.c (auto_saving_dir_umask): New static var.
6347 (Fmake_directory_internal): Use it.
6348 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6349 creating the directory. The old code temporarily assigns
6350 too-generous permissions to the directory.
6351 (do_auto_save_eh): Clear it.
b9110d6a 6352 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6353 that the var is always cleared.
6354
6c1bd3f3
EZ
63552012-01-07 Eli Zaretskii <eliz@gnu.org>
6356
6357 * search.c (scan_buffer): Pass character positions to
6358 know_region_cache, not byte positions. (Bug#6540)
6359
069d2b50
L
63602012-01-07 LynX <_LynX@bk.ru> (tiny change)
6361
6362 * w32.c (sys_rename): Report EXDEV when rename of a directory
6363 fails because the target is on another logical disk. (Bug#10284)
6364
75bf0d33
DB
63652012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6366
6367 * xterm.c (x_embed_request_focus): New function.
6368
6369 * xterm.h: Add prototype.
6370
6371 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6372
1c6e5a32
GM
63732012-01-05 Glenn Morris <rgm@gnu.org>
6374
6375 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6376
651e947e
EZ
63772012-01-01 Eli Zaretskii <eliz@gnu.org>
6378
6379 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6380 Load gnutls_transport_set_lowat only if GnuTLS version is below
6381 2.11.1.
6382 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6383 GnuTLS versions below 2.11.1.
6384
3778cdd8
AL
63852011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6386
6387 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6388 to the doc string advising against its use for altering the way
6389 windows are scrolled.
6390
0e5317f7
KH
63912011-12-28 Kenichi Handa <handa@m17n.org>
6392
6393 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6394 coding-system ASCII compatible only when it does not produce BOM
6395 on encoding (Bug#10383).
6396
93d5ca1f
JD
63972011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6398
6399 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6400 can scroll.
6401 (create_and_show_popup_menu): Always use menu_position_func for
6402 Gtk3 (Bug#10361).
6403
ca22b785
AS
64042011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6405
6406 * callint.c (Fcall_interactively): Don't truncate prompt string.
6407
d048e1e6
EZ
64082011-12-23 Eli Zaretskii <eliz@gnu.org>
6409
6410 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6411 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6412 resumed from there (after widening). (Bug#10360)
d048e1e6 6413
5ccaba1f
JD
64142011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6415
6416 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6417
204ee57f
JD
64182011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6419
b81d40f0
JB
6420 * nsterm.m (x_free_frame_resources):
6421 Release f->output_data.ns->miniimage.
204ee57f
JD
6422 (ns_index_color): Fix indentation. Do not retain
6423 color_table->colors[i].
6424
6425 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6426 before returning.
6427
6428 * nsfns.m (x_set_background_color): Assign return value from
6429 ns_index_color to face-background instead of NSColor*.
6430 (ns_implicitly_set_icon_type): Fix indentation.
6431 Change assignment in for loop to comparison.
6432
6433 * emacs.c (ns_pool): New variable.
6434 (main): Assign ns_pool.
6435 (Fkill_emacs): Call ns_release_autorelease_pool.
6436
6437 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6438 autorelease fdesc, release fdAttrs and tdict.
6439 (ns_get_covering_families): Release charset.
6440 (ns_findfonts): Release NSFontDescriptor created with new.
6441 (ns_uni_to_glyphs): Fix indentation.
6442 (setString): Release attrStr before assigning new value.
6443
c803b2b7
JD
64442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6445
678f4426
JD
6446 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6447 and NS_IMPL_COCOA.
6448 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6449 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6450
cd394be1 64512011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6452
5fecd5fc
JD
6453 * nsterm.m (ns_term_init): Subscribe for notifications
6454 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6455 to method trackingNotification in EmacsMenu.
6456
6457 * nsmenu.m (trackingMenu): New variable.
3771cb17 6458 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6459 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6460 from Aquamacs (Bug#7030).
678f4426
JD
6461
64622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6463
c803b2b7
JD
6464 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6465 (symbol_to_nsstring): Fix indentation.
6466 (ns_symbol_to_pb): New function.
cae07000
SM
6467 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6468 (Fns_rotate_cut_buffers_internal): Remove.
6469 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6470 Fns_store_cut_buffer_internal.
6471 (ns_get_foreign_selection, Fx_own_selection_internal)
6472 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6473 (Fns_get_selection_internal, Fns_store_selection_internal):
6474 Use ns_symbol_to_pb and check if return value is nil.
6475 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6476 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6477 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6478 renamed to Sns_store_selection_internal.
6479 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6480 and remove this function.
6481 (ns_handle_selection_clear): Remove, never used.
6482 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6483 here.
6484
e1b01a3a
KB
64852011-12-17 Ken Brown <kbrown@cornell.edu>
6486
6487 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6488 GID is unknown (Bug#10257).
6489
2adb6e85
PE
64902011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6491
6492 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6493 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6494 which caused a build failure on GNU/Linux IA-64. This problem was
6495 introduced by my 2011-10-07 patch.
6496
d1d7b339
JL
64972011-12-15 Juri Linkov <juri@jurta.org>
6498
6499 * image.c (imagemagick_error): New function. (Bug#10112)
6500 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6501 Use `imagemagick_error' where ImageMagick functions return
6502 `MagickFalse'.
6503 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6504 proper order.
6505
100d5755
KH
65062011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6507
6508 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6509 fill background (Bug#8992).
6510
454592a6
MR
65112011-12-13 Martin Rudalics <rudalics@gmx.at>
6512
6513 * window.c (Vwindow_combination_resize)
6514 (Vwindow_combination_limit): Use t instead of non-nil in
6515 doc-strings.
61d4b438
MR
6516 (Vrecenter_redisplay): Add first sentence of doc-string on
6517 separate line.
53524d93 6518 (Frecenter): Fix doc-string typo.
454592a6 6519
3633e3aa
KH
65202011-12-11 Kenichi Handa <handa@m17n.org>
6521
6522 * coding.c (Funencodable_char_position): Pay attention to the
6523 buffer text relocation (Bug#9389).
6524
7b9d523a 65252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6526
7b9d523a
JD
6527 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6528 gtk_init (Bug#10100).
6529
b73189c6
EZ
65302011-12-10 Eli Zaretskii <eliz@gnu.org>
6531
6532 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6533 IT->string is nil. (Bug#10263)
6534
f7dfe5d6
JD
65352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6536
83faebb4
JD
6537 * nsterm.h (x_free_frame_resources): Declare.
6538
f7dfe5d6
JD
6539 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6540 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6541
6542 * nsterm.h (ns_get_defaults_value): Declare.
6543
6544 * nsterm.m (ns_default): Call ns_get_defaults_value.
6545
7cd4e72c
EZ
65462011-12-09 Eli Zaretskii <eliz@gnu.org>
6547
6548 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6549 (Bug#10170)
6550
b34d7317
YM
65512011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6552
6553 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6554 that where the value of an _OBJC_* symbol points to is in the .bss
6555 section (Bug#10240).
6556
76470ad1
KH
65572011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6558
6559 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6560 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6561
745fff94
KH
65622011-12-08 Kenichi Handa <handa@m17n.org>
6563
6564 * ftfont.c (get_adstyle_property): Fix previous change
6565 (Bug#10233).
6566
6e44397c
JB
65672011-12-07 Juanma Barranquero <lekktu@gmail.com>
6568
6569 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6570 dirs from the default value of EMACSLOADPATH (bug#10208).
6571
7efa6272
GM
65722011-12-07 Glenn Morris <rgm@gnu.org>
6573
6574 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6575 installation and source directories as well. (Bug#10208)
6576
f6fc4d87
CY
65772011-12-06 Chong Yidong <cyd@gnu.org>
6578
6579 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6580
2bf26180
GM
65812011-12-06 Glenn Morris <rgm@gnu.org>
6582
6583 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6584 as an error, not just -1. (Bug#10217)
6585
3a6ad4f0
CY
65862011-12-05 Chong Yidong <cyd@gnu.org>
6587
6588 * keyboard.c (process_special_events): New function.
6589 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6590
75a3b399
PE
65912011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6592
6593 * coding.c (encode_designation_at_bol): Don't use uninitialized
6594 local variable (Bug#9318).
6595
c3c9e25e
KH
65962011-12-05 Kenichi Handa <handa@m17n.org>
6597
6598 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6599 return Qnil (Bug#8046, Bug#10193).
6600
5eb05ea3
KH
66012011-12-05 Kenichi Handa <handa@m17n.org>
6602
6603 * coding.c (encode_designation_at_bol): New args charbuf_end and
6604 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6605 (coding_set_source): Return how many bytes coding->source was
6606 relocated.
6607 (coding_set_destination): Return how many bytes
6608 coding->destination was relocated.
6609 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6610 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6611
66122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6613
6614 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6615 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6616 macro (Bug#9318).
6617
66182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6619
6620 The following changes are to fix Bug#9318.
6621
a79703f5 6622 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6623 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6624 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6625 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6626
7dbda6df
JB
66272011-12-05 Juanma Barranquero <lekktu@gmail.com>
6628
6629 * lisp.h (process_quit_flag): Fix external declaration.
6630
6d5eb5b0
SM
66312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6632
6633 Don't macro-inline non-performance-critical code.
6634 * eval.c (process_quit_flag): New function.
6635 * lisp.h (QUIT): Use it.
6636
a0c3fad0
JD
66372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6638
6639 * nsfns.m (get_geometry_from_preferences): New function.
6640 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6641
6c07aac2
AS
66422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6643
6644 * emacs.c (Qkill_emacs): Define.
6645 (syms_of_emacs): Initialize it.
6646 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6647 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6648 (quit_throw_to_read_char): Add parameter `from_signal'.
6649 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6650 * lisp.h (QUIT): Call Fkill_emacs if requested.
6651
c052ead4
JD
66522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6653
6654 * widget.c (update_wm_hints): Return if wmshell is null.
6655 (widget_update_wm_size_hints): New function.
6656
6657 * widget.h (widget_update_wm_size_hints): Declare.
6658
6659 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6660 widget_update_wm_size_hints (Bug#10104).
6661
9e49252b
EZ
66622011-12-03 Eli Zaretskii <eliz@gnu.org>
6663
6664 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6665 before a newline, prepare the bidi iterator for consuming the
6666 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6667 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6668
02b16839
JL
66692011-12-02 Juri Linkov <juri@jurta.org>
6670
6671 * search.c (Fword_search_regexp): New Lisp function created from
6672 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6673 (Fword_search_backward, Fword_search_forward)
6674 (Fword_search_backward_lax, Fword_search_forward_lax):
6675 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6676 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6677
0068070e
SM
66782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6679
6680 * fileio.c (Finsert_file_contents): Move after-change-function call
6681 to before the "handled:" label, since all "goto handled" appear in
6682 cases where the *-change-functions have already been properly called
6683 (bug#10117).
6684
3360a3fc
AS
66852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6686
6687 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6688 waiting for input. (Bug#10169)
6689
73d6c093
EZ
66902011-11-30 Eli Zaretskii <eliz@gnu.org>
6691
6692 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6693 verifies glyph row's hash code--we have just reallocated the
6694 glyphs, so their contents can be complete garbage. (Bug#10164)
6695
febe6bea
JB
66962011-11-30 Juanma Barranquero <lekktu@gmail.com>
6697
6698 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6699
801a4313
EZ
67002011-11-30 Eli Zaretskii <eliz@gnu.org>
6701
6702 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6703 attributes are tested _before_ calling verify_row_hash, to protect
6704 against GCC re-ordering of the tests. (Bug#10164)
6705
2b56b87e
JD
67062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6707
6708 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6709
6710 * xterm.c (handle_one_xevent): Only set async_visible and friends
6711 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6712 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6713 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6714
dbf31225
PE
67152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6716
6717 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6718 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6719 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6720 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6721 All uses changed to use GCPRO1 etc.
6722 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6723 Revert to old implementation (i.e., before 2011-03-11).
6724
1305621b
YM
67252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6726
6727 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6728 of scroll runs so as to avoid assigning disabled bogus rows and
6729 unnecessary graphics copy operations.
6730
8c9afb46
EZ
67312011-11-27 Eli Zaretskii <eliz@gnu.org>
6732
6733 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6734 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6735 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6736 (malloc, free, realloc, calloc): Redirect to e_* only when
6737 compiling Emacs.
6738
6739 * lisp.h (GCTYPEBITS): Move before first use.
6740 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6741 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6742 this macro definition.
6743
6744 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6745 _MSC_VER.
6746
54e9e3bf
JD
67472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6748
6d5eb5b0
SM
6749 * gtkutil.c (xg_create_frame_widgets):
6750 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6751 present with Gtk+ 2.0.
6752
83aca1cb
PE
67532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6754
6755 * fileio.c (Finsert_file_contents): Undo previous change; see
6756 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6757
5b76caa4
PE
67582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6759
6760 Rename locals to avoid shadowing.
6761 * fileio.c (Finsert_file_contents):
6762 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6763 * process.c (wait_reading_process_output):
6764 Rename inner 'proc' to 'p' to avoid shadowing.
6765 Indent for consistency with usual Emacs style.
6766
8c535114
EZ
67672011-11-25 Eli Zaretskii <eliz@gnu.org>
6768
6769 * xdisp.c (redisplay_window): If cursor row is not fully visible
6770 after recentering, and scroll-conservatively is set to a large
6771 number, scroll window by a few more lines to make the cursor fully
6772 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6773 (start_display): Don't move to the next line if the display should
6774 start at a newline that is part of a display vector or an overlay
6775 string. (Bug#10119)
8c535114 6776
fa4fdb5c
JL
67772011-11-24 Juri Linkov <juri@jurta.org>
6778
6779 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6780 after the `MagickPingImage' call. (Bug#10112)
6781
90ec88df
CY
67822011-11-23 Chong Yidong <cyd@gnu.org>
6783
6784 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6785
56e2e794
MR
67862011-11-23 Martin Rudalics <rudalics@gmx.at>
6787
6788 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6789 making another buffer current. (Bug#10114)
6790
b6e64c41
GM
67912011-11-23 Glenn Morris <rgm@gnu.org>
6792
6793 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6794
6b21de18
CY
67952011-11-23 Chong Yidong <cyd@gnu.org>
6796
6797 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6798 using it (Bug#5984).
6799
b12cd789
EZ
68002011-11-22 Eli Zaretskii <eliz@gnu.org>
6801
6802 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6803 and header-lines, as they don't have one computed for them.
6804 (Bug#10098)
6805
6806 * .gdbinit (prow): Make displayed values more self-explaining.
6807 Add row's hash code.
6808
261b6fd4
LMI
68092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6810
6811 * process.c (wait_reading_process_output): Fix asynchrounous
6812 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6813 (wait_reading_process_output): Add comment and URL.
261b6fd4 6814
e7cfd277
JD
68152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6816
6817 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6818
a9b9b7f5
CY
68192011-11-21 Chong Yidong <cyd@gnu.org>
6820
6821 * window.c (Fnext_window, Fprevious_window): Doc fix.
6822
b0d15b4f
SM
68232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6824
6825 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6826
fe7a3057
JB
68272011-11-20 Juanma Barranquero <lekktu@gmail.com>
6828
6829 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6830
d2999b1a
MR
68312011-11-20 Martin Rudalics <rudalics@gmx.at>
6832
6833 * window.c (Fset_window_combination_limit): Rename argument
6834 STATUS to LIMIT.
6835 (Vwindow_combination_limit): Remove "status" from doc-string.
6836
d5ff9cd0
AS
68372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6838
6839 * m/ibms390.h: Remove.
6840 * m/ibms390x.h: Don't include "ibms390.h".
6841
a5bb9bd3
SM
68422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6843
6844 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6845 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6846
cd1181db
JB
68472011-11-20 Juanma Barranquero <lekktu@gmail.com>
6848
6849 * casetab.c (Fset_case_table):
6850 * charset.c (Fcharset_after): Fix typos.
6851
615a3b8d 68522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6853
17e845af
PE
6854 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6855 Otherwise, valgrind does not work on some platforms.
6856 Problem reported by Andreas Schwab in
6a0bf43d
PE
6857 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6858 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6859 is set, removing the need for VIRT_ADDRESS_VARIES.
6860 (PURE_P): Use a more-efficient implementation that needs just one
6861 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6862 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6863 to 4 (xorl, subq, cmpq, setbe).
6864 * alloc.c (pure): Always extern now, since that's the
6865 VIRT_ADDR_VARIES behavior.
6866 (PURE_POINTER_P): Use a single comparison, not two, for
6867 consistency with the new puresize.h.
6868 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6869 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6870 Remove VIRT_ADDR_VARIES no longer needed.
6871
f8fe6f96
EZ
68722011-11-19 Eli Zaretskii <eliz@gnu.org>
6873
6874 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6875 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6876 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6877 behave as if the cursor position were at the window margin.
6878
6879 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6880 and the cursor position is out of bounds, behave as if the cursor
6881 position were at the window margin. (Bug#10075)
6882
df05a53c
CY
68832011-11-18 Chong Yidong <cyd@gnu.org>
6884
6885 * window.c (Fwindow_combination_limit): Make first argument
6886 non-optional, since it is meaningless for live windows like the
6887 selected window.
61ccba97 6888
2071918e
DA
68892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6890
6891 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6892
b50a28de
SM
68932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6894
6895 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6896 (graft_intervals_into_buffer): Simplify.
6897
015137db
EZ
68982011-11-18 Eli Zaretskii <eliz@gnu.org>
6899
6900 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6901 hash values of the two rows.
6902 (copy_row_except_pointers): Preserve the used[] arrays and the
6903 hash values of the two rows. (Bug#10035)
68c95424 6904 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6905
6906 * xdisp.c (row_hash): New function, body extracted from
6907 compute_line_metrics.
6908 (compute_line_metrics): Call row_hash, instead of computing the
6909 hash code inline.
6910
6911 * dispnew.c (verify_row_hash): Call row_hash for computing the
6912 hash code of a row, instead of duplicating code from xdisp.c.
6913
6914 * dispextern.h (row_hash): Add prototype.
6915
a2addb04
TH
69162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6917
6918 * frame.c (delete_frame): Don't delete the terminal when the last
6919 X frame is closed if emacs is built with GTK toolkit.
6920
df85d315
JB
69212011-11-17 Juanma Barranquero <lekktu@gmail.com>
6922
6923 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6924
a0c2d0ae
MR
69252011-11-17 Martin Rudalics <rudalics@gmx.at>
6926
6927 * window.c (Vwindow_splits): Rename to
6928 Vwindow_combination_resize. Suggested by Juri Linkov.
6929 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6930 of Vwindow_splits.
6931
58179cce
JB
69322011-11-16 Juanma Barranquero <lekktu@gmail.com>
6933
7877f373
JB
6934 * nsfns.m (Fns_font_name):
6935 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6936
b6f67890
MR
69372011-11-16 Martin Rudalics <rudalics@gmx.at>
6938
6939 * window.h (window): Rename slot "nest" to "combination_limit".
6940 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6941 (Fset_window_nest): Rename to Fset_window_combination_limit.
6942 (Vwindow_nest): Rename to Vwindow_combination_limit.
6943 (recombine_windows, make_parent_window, make_window)
6944 (Fsplit_window_internal, saved_window)
6945 (Fset_window_configuration, save_window_save): Rename all
6946 occurrences of window_nest to window_combination_limit.
6947
c7015153
JB
69482011-11-15 Juanma Barranquero <lekktu@gmail.com>
6949
6950 * image.c (imagemagick_load_image): Fix typo.
6951
322ad6ec
EZ
69522011-11-14 Eli Zaretskii <eliz@gnu.org>
6953
6954 * xdisp.c (display_line): Move the call to
6955 highlight_trailing_whitespace before the call to
6956 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6957 faces of all the glyphs to compute ROW's hash value.
6958 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6959
f067b8ec
JB
69602011-11-14 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6963 just return (bug#10044).
6964
1e5b2111
EZ
69652011-11-12 Eli Zaretskii <eliz@gnu.org>
6966
7ef3cbd5
EZ
6967 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6968 with user-defined heap size. Bump the default size of the temacs
6969 heap to 27MB, to avoid memory warning when running temacs.
6970 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6971
1e5b2111
EZ
6972 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6973 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6974 (verify_row_hash) [XASSERTS]: New function.
6975 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6976 that the hash value of glyph rows is correct.
1e5b2111 6977
89d61221
MR
69782011-11-12 Martin Rudalics <rudalics@gmx.at>
6979
6980 * window.h (window): Remove splits slot.
6981 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6982 (Fdelete_other_windows_internal, make_parent_window)
6983 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6984 (Fset_window_configuration, save_window_save): Don't deal with
6985 split status of windows.
6986 (saved_window): Remove splits slot.
6987 (Vwindow_splits): Rewrite doc-string.
6988
97f18cc8
JD
69892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6990
6991 * xfns.c (unwind_create_frame):
6992 * nsfns.m (unwind_create_frame):
6993 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6994 Vframe_list (Bug#9999).
6995
22a648b4
DA
69962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6997
0b381c7e 6998 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6999
659afede
KH
70002011-11-11 Kenichi Handa <handa@m17n.org>
7001
7002 * callproc.c (Fcall_process): Set the member dst_multibyte of
7003 process_coding.
7004
9ac0394b
KH
70052011-11-11 Johan Bockgård <bojohan@gnu.org>
7006
7007 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7008 avoid a crash (bug#9496).
7009
2fbdc249
CY
70102011-11-09 Chong Yidong <cyd@gnu.org>
7011
7012 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7013 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7014
ac6b1f81
PE
70152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7016
7017 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7018
09db192c
PE
70192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7020
7021 Avoid some portability problems by eschewing 'extern inline' functions.
7022 The trivial performance wins aren't worth the portability hassles; see
7023 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7024 et seq.
7025 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7026 (window_box_width, window_box_left, window_box_left_offset)
7027 (window_box_right, window_box_right_offset): Undo previous change,
7028 by removing the "extern"s.
7029 * intervals.c (adjust_intervals_for_insertion)
7030 (adjust_intervals_for_deletion): Undo previous change,
7031 making these static again.
7032 (offset_intervals, temp_set_point_both, temp_set_point)
7033 (copy_intervals_to_string): No longer inline.
7034 * xdisp.c (window_text_bottom_y, window_box_width)
7035 (window_box_height, window_box_left_offset)
7036 (window_box_right_offset, window_box_left, window_box_right)
7037 (window_box): No longer inline.
7038
105216ed
CY
70392011-11-08 Chong Yidong <cyd@gnu.org>
7040
7041 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7042 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7043 Signal an error if not a live window.
105216ed
CY
7044 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7045 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7046
ae9e237f
JB
70472011-11-07 Juanma Barranquero <lekktu@gmail.com>
7048
7049 * lisp.h (syms_of_abbrev): Remove declaration.
7050 Reported by CHENG Gao <chenggao@royau.me>.
7051
c7aa8333
EZ
70522011-11-07 Eli Zaretskii <eliz@gnu.org>
7053
7054 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7055 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7056 of temacs in GUI mode.
7057
be7f5545
MR
70582011-11-07 Martin Rudalics <rudalics@gmx.at>
7059
7060 * window.h: Declare delete_all_child_windows instead of
7061 delete_all_subwindows.
7062 * window.c (Fwindow_nest, Fset_window_nest)
7063 (Fset_window_new_total, Fset_window_new_normal)
7064 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7065 (delete_all_subwindows): Rename to delete_all_child_windows.
7066 (Fdelete_other_windows_internal, Fset_window_configuration):
7067 Call delete_all_child_windows instead of delete_all_subwindows.
7068 * frame.c (delete_frame): Call delete_all_child_windows instead
7069 of delete_all_subwindows.
7070
ca78dc43
PE
70712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7072
7073 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7074 This is also needed for porting to any host where GC_MARK_STACK is
7075 not GC_MAKE_GCPROS_NOOPS.
7076 (which_symbols): Use it.
7077
a0241d01
KH
70782011-11-07 Kenichi Handa <handa@m17n.org>
7079
7080 * coding.c (coding_set_destination): Check coding->src_pos only
7081 when coding->src_object is a buffer (bug#9910).
7082
7083 * process.c (send_process): Set the member src_multibyte of coding
7084 to 0 (bug#9911) when sending a unibyte text.
7085
7086 * callproc.c (Fcall_process): Set the member src_multibyte of
7087 process_coding to 0 (bug#9912).
7088
a64bfdfa 70892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7090
7091 * xmenu.c (cleanup_widget_value_tree): New function.
7092 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7093 calling free_menubar_widget_value_tree directly (Bug#9830).
7094
cb41b32a
PE
70952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7096
7097 Fix some portability problems with 'inline'.
7098 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7099 (window_box_width, window_box_left, window_box_left_offset)
7100 (window_box_right, window_box_right_offset): Declare extern.
7101 Otherwise, these inline functions do not conform to C99 and
7102 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7103 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7104 * intervals.c (adjust_intervals_for_insertion)
7105 (adjust_intervals_for_deletion): Now extern, because otherwise the
7106 extern inline functions 'offset_intervals' couldn't refer to it.
7107 (static_offset_intervals): Remove.
7108 (offset_intervals): Rewrite using the old contents of
7109 static_offset_intervals. The old version didn't conform to C99
7110 because an extern inline function contained a reference to an
7111 identifier with static linkage.
7112
b7041366
AS
71132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7114
7115 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7116 GC.
7117
88a37c4d
EZ
71182011-11-06 Eli Zaretskii <eliz@gnu.org>
7119
7120 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7121 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7122 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7123 return Qleft_to_right.
7124
49745b39
CY
71252011-11-06 Chong Yidong <cyd@gnu.org>
7126
7127 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7128 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7129 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7130 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7131 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7132 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7133 (Fwindow_vscroll): Doc fix.
7134 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7135 argument, since it makes no sense to pass a live window and for
7136 consistency with window-child.
7137
1f05cd82
CS
71382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7139
7140 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7141 support MSVC.
7142
22610910
JR
71432011-11-05 Jason Rumney <jasonr@gnu.org>
7144
7145 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7146 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7147 fonts (Bug#6029).
7148 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7149 bitwise arithmetic preventing use of unicode-sip and non-truetype
7150 opentype fonts.
7151
a06776b2
EZ
71522011-11-05 Eli Zaretskii <eliz@gnu.org>
7153
3ad924ba
EZ
7154 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7155 "emacs"-only part.
7156
a06776b2
EZ
7157 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7158 initialization code to keep similarity to xfns.c after changes
7159 from 2011-11-05.
7160
c9e7db78
JD
71612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7162
a97f8f3f
JD
7163 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7164 (unwind_create_frame): New function (Bug#9943).
7165 (Fx_create_frame): Restructure code to be more similar to the one in
7166 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7167 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7168 Move terminal->reference_count++ just before making the frame official
7169 (Bug#9943).
7170
7171 * nsterm.m (x_free_frame_resources): New function.
7172 (x_destroy_window): Move code to x_free_frame_resources.
7173
c9e7db78 7174 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7175 (Fx_create_frame, x_create_tip_frame):
7176 Move terminal->reference_count++ just before making the frame
75f1671a 7177 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7178 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7179
a6fc3b5c
EZ
71802011-11-05 Eli Zaretskii <eliz@gnu.org>
7181
7182 Support MSVC build with newer versions of Visual Studio.
7183 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7184 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7185 nt/gmake.defs.
7186
7187 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7188 which are not supported by MSVC.
7189 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7190 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7191 bitfields.
7192 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7193 types in bitfields.
7194 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7195
7196 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7197
58179cce 71982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7199
7200 Support MSVC build with newer versions of Visual Studio.
7201 * w32.c: Don't include w32api.h for MSVC.
7202 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7203
7204 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7205 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7206 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7207 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7208 e_* cousins.
7209 (alloca) [_MSC_VER]: Define to _alloca.
7210
7211 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7212
7213 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7214
a58c13ed
EZ
72152011-11-04 Eli Zaretskii <eliz@gnu.org>
7216
7217 * xdisp.c (note_mouse_highlight): If either of
7218 previous/next-single-property-change returns nil, treat that as
7219 the beginning or the end of the buffer. (Bug#9955)
7220
fe0b6370
JD
72212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7222
a58c13ed 7223 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7224 label is not null (Bug#9951).
7225 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7226 may be NULL.
7227
89bd5ee1
EZ
72282011-11-04 Eli Zaretskii <eliz@gnu.org>
7229
7230 * window.c (Fwindow_body_size): Mention in the doc string that the
7231 return value is in frame's canonical units. (Bug#9949)
7232
84c3edb9
EZ
72332011-11-03 Eli Zaretskii <eliz@gnu.org>
7234
4e2fb5c7
EZ
7235 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7236
84c3edb9 7237 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7238 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7239 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7240
bc17a887
EZ
72412011-11-01 Eli Zaretskii <eliz@gnu.org>
7242
7243 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7244 Don't stop backward scan on the continuation glyph, even though
7245 its CHARPOS is positive.
6d5eb5b0
SM
7246 (mouse_face_from_buffer_pos, note_mouse_highlight):
7247 Rename cover_string to disp_string.
bc17a887 7248
4ee88440
MR
72492011-11-01 Martin Rudalics <rudalics@gmx.at>
7250
7251 * window.c (temp_output_buffer_show): Don't use
7252 Vtemp_buffer_show_specifiers.
7253 (Vtemp_buffer_show_specifiers): Remove unused variable.
7254
c2ff3c02
EZ
72552011-10-30 Eli Zaretskii <eliz@gnu.org>
7256
7257 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7258 past the beginning of the current glyph matrix.
7259
58179cce 72602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7261
7262 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7263 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7264 HAVE_GTK3 (Bug#9869).
b77a6a7f 7265
3b574623
JD
7266 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7267 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7268
b77a6a7f
JD
7269 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7270
7271 * xterm.c: Declare x_handle_net_wm_state to return int.
7272 (handle_one_xevent): Check if we are iconified but don't have
7273 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7274 (get_current_wm_state): Return non-zero if not hidden,
7275 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7276 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7277 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7278 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7279
196e41e4
PE
72802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7281
7282 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7283 so that this new function doesn't get optimized away by a
7284 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7285
021f2e1a
AS
72862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7287
7288 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7289
8b058d44
EZ
72902011-10-29 Eli Zaretskii <eliz@gnu.org>
7291
7292 Fix the `xbytecode' command.
7293 * .gdbinit (xprintbytestr): New command.
b50a28de 7294 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7295 (xbytecode): Print the byte-code string as well.
7296
4452fb80
EZ
72972011-10-29 Kim Storm <storm@cua.dk>
7298
8b058d44
EZ
7299 * alloc.c (which_symbols): New function.
7300
21b72067
AS
73012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7302
7303 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7304 line. (Bug#9903)
7305
83ed7b5c
GM
73062011-10-29 Glenn Morris <rgm@gnu.org>
7307
7308 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7309 Not clear what it was for, and it causes various bugs. (Bug#9839)
7310
5a7a728b
EZ
73112011-10-28 Eli Zaretskii <eliz@gnu.org>
7312
7313 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7314 possible random value that matches one of those tested as
7315 condition to clear the mouse face.
7316
d3d0842f
CY
73172011-10-28 Chong Yidong <cyd@gnu.org>
7318
7319 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7320
31b39d13
DN
73212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7322
7323 * window.c (make_window): Initialize phys_cursor_on_p.
7324
9aba6043
SM
73252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7326
7327 * lisp.h (struct Lisp_Symbol): Update comments.
7328
c20992f4
JB
73292011-10-28 Juanma Barranquero <lekktu@gmail.com>
7330
7331 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7332
db4f02f2
EZ
73332011-10-28 Eli Zaretskii <eliz@gnu.org>
7334
7335 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7336 <oslsachem@gmail.com> for helping to debug this.
7337
7338 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7339 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7340 (g_b_init_get_glyph_outline_w): New static variables.
7341 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7342 (GetGlyphOutlineW_Proc): New typedefs.
7343 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7344 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7345 New functions.
7346 (w32font_open_internal, compute_metrics):
7347 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7348 instead of calling the "wide" APIs directly.
7349
7350 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7351
7352 * w32.h (syms_of_w32font): Add prototype.
7353
87e68db4
JB
73542011-10-27 Juanma Barranquero <lekktu@gmail.com>
7355
7356 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7357 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7358 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7359 (Fmove_to_window_line): Doc fix.
7360
435c1d67
CY
73612011-10-27 Chong Yidong <cyd@gnu.org>
7362
7363 * process.c (make_process): Set gnutls_state to NULL.
7364
7365 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7366 non-NULL, regardless of GNUTLS_INITSTAGE.
7367 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7368 an error. Set process slots as soon as we allocate them.
7369
7370 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7371
9c6c6f49
CY
73722011-10-27 Chong Yidong <cyd@gnu.org>
7373
9aba6043
SM
7374 * gnutls.c (emacs_gnutls_deinit): New function.
7375 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7376 (Fgnutls_deinit, Fgnutls_boot): Use it.
7377
7378 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7379 (deactivate_process): Call emacs_gnutls_deinit.
7380
657d08d3
JB
73812011-10-27 Juanma Barranquero <lekktu@gmail.com>
7382
7383 * image.c (x_create_x_image_and_pixmap):
7384 * w32.c (sys_rename, w32_delayed_load):
7385 * w32font.c (fill_in_logfont):
7386 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7387
5430d399
JB
73882011-10-26 Juanma Barranquero <lekktu@gmail.com>
7389
7390 * w32fns.c (w32_default_color_map): New function,
7391 extracted from Fw32_default_color_map.
a7ef684b 7392 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7393
fe0055fa
PE
73942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7395
7396 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7397
e6346438
SM
73982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7399
7400 * keyboard.c (test_undefined): New function (bug#9751).
7401 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7402
e112cc37
ET
74032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7404
7405 * sysdep.c (init_sys_modes): Fix the check for the controlling
7406 terminal (Bug#6649).
7407
7b5d6677
EZ
74082011-10-20 Eli Zaretskii <eliz@gnu.org>
7409
7410 * dispextern.h (struct bidi_it): New member next_en_type.
7411
7412 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7413 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7414 current character, check also for next_en_type being WEAK_EN.
7415 (bidi_resolve_weak): Don't enter the expensive loop if the current
7416 position is before next_en_pos. Record the bidi type of the first
7417 non-ET, non-BN character we find, in addition to its position.
7418 (bidi_level_of_next_char): Invalidate next_en_type when
7419 next_en_pos is over-stepped.
7420
7da0b018
PE
74212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7422
7423 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7424 * editfns.c: Rewrite current-time-zone so that it invokes
7425 the equivalent of (format-time-string "%Z") to get the time zone name.
7426 This fixes a bug when the time zone name contains characters that
7427 need converting from the system time locale to Emacs internal format.
7428 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7429 that patch fixed format-time-string to do the conversion, but
7430 I forgot to fix current-time-zone.
7431 (format_time_string): New function, containing most of
7432 what Fformat_time_string used to contain.
7433 (Fformat_time_string): Rewrite in terms of format_time_string.
7434 This doesn't change this function's behavior.
7435 (current-time-zone): Rewrite to use format_time_string.
7436 This fixes the bug reported by Michael Schierl in
7437 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7438 Jason Rumney's 2007-06-07 change worked around this bug, but
7439 didn't fix it.
7440 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7441
8547b010
EZ
74422011-10-19 Eli Zaretskii <eliz@gnu.org>
7443
7444 * xdisp.c (start_display): If the character at POS is displayed
7445 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7446 (try_window_reusing_current_matrix): If a line ends in a display
7447 vector or the next line starts in a display vector, continue
7448 redrawing the window even though the character position of
7449 start_row was reached.
8547b010
EZ
7450 (Bug#9771, part 2)
7451
4e948d15
CY
74522011-10-18 Chong Yidong <cyd@gnu.org>
7453
7454 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7455 with nobreak-char-display too.
7456
4787455f
EZ
74572011-10-18 Eli Zaretskii <eliz@gnu.org>
7458
7459 Fix part 3 of bug#9771.
7460 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7461 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7462 non-neutral characters if the current character is a paragraph
7463 separator (a.k.a. Newline). This avoids running the same
7464 expensive loop twice, once when we consume the preceding newline
7465 and the other time when the line actually needs to be displayed.
7466 Avoid the loop when we see neutrals on the base embedding level
7467 following a character whose directionality is the same as the
7468 paragraph's. This avoids running the expensive loop when a line
7469 ends in a long sequence of neutrals, like control characters.
7470 Add assertion against STRONG_AL type. Slightly rearrange code
7471 that determines the type of a neutral given the first non-neutral
7472 that follows it.
7473 (bidi_level_of_next_char): Set next_en_pos to zero when
7474 invalidating its info.
7475
2c91f553
EZ
74762011-10-17 Eli Zaretskii <eliz@gnu.org>
7477
7478 * xdisp.c (push_display_prop): Determine whether to record string
7479 or buffer position by IT->string, not by IT->method. Allow
7480 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7481 (move_it_vertically_backward): Don't look for character position
7482 immediately after the newline when in a continuation line.
7483 (Bug#9771, part 1)
2c91f553 7484
c7b08b0d
MR
74852011-10-15 Martin Rudalics <rudalics@gmx.at>
7486
7487 * window.c (coordinates_in_window): Rewrite and delabelize
7488 vertical border check. (Bug#5357) (Bug#9618)
7489
6b02f655
SM
74902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7491
7492 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7493 errors in XSetWindowBorder (bug#9310).
7494
81d40c92
DA
74952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7496
7497 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7498 avoid crash when xmalloc overrun checking is enabled.
7499
d4172c3b
EZ
75002011-10-13 Eli Zaretskii <eliz@gnu.org>
7501
7502 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7503 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7504 cursor motion with <left> and <right> arrow keys.
7505
7506 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7507 some callers set that themselves.
7508
b00eea75
EZ
75092011-10-12 Eli Zaretskii <eliz@gnu.org>
7510
7511 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7512 display string and the previous row comes from the same string and
7513 is empty. (Bug#9739) (Bug#9738)
7514
8fe012c4
SM
75152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7516
7517 * doc.c (get_doc_string): Encode file name (bug#9735).
7518
0074aef2
EZ
75192011-10-12 Eli Zaretskii <eliz@gnu.org>
7520
79beb178
EZ
7521 * bidi.c (bidi_level_of_next_char):
7522 * xdisp.c (get_visually_first_element): Remove old incorrect
7523 comments regarding the Unicode Line Separator character.
7524
0074aef2
EZ
7525 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7526
6e4b3fbe
DA
75272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7528
7529 * alloc.c (Fgc_status): Do not access beyond zombies array
7530 boundary if nzombies > MAX_ZOMBIES.
7531 * alloc.c (dump_zombies): Add missing format specifier.
7532
0324f3af
PE
75332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7534
b5525cac
PE
7535 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7536 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7537
0324f3af
PE
7538 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7539 Some packages use them to denote characters with modifiers.
7540
e9b5f888
AS
75412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7542
7543 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7544 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7545 matching a pp-number. Rename parameter var to var1.
7546
127827c0
SM
75472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7548
7549 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7550
c8fd3bd0
GM
75512011-10-08 Glenn Morris <rgm@gnu.org>
7552
7553 * callint.c (Fcall_interactively): Give a more explicit error for the
7554 'c' case with a non-character input. (Bug#8479)
7555
352ec8ff
EZ
75562011-10-08 Eli Zaretskii <eliz@gnu.org>
7557
03669ccb
EZ
7558 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7559 lines.
7061c986
EZ
7560 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7561 lines that are hscrolled on the left.
03669ccb 7562
352ec8ff
EZ
7563 * dispnew.c (buffer_posn_from_coords): Account for a possible
7564 presence of header-line. (Bug#4426)
7565
a66cfb1c
SM
75662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7567
6b02f655
SM
7568 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7569 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7570
7c5ee88e
PE
75712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7572
7573 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7574 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7575 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7576 this makes Emacs dump core during garbage collection on rare
7577 occasions. sizeof is obviously inferior to offsetof here, so
7578 stick with offsetof.
7579 (GC_POINTER_ALIGNMENT): New macro.
7580 (mark_memory): Omit 3rd (offset) arg; caller changed.
7581 Don't assume EMACS_INT alignment is the same as pointer alignment.
7582
df1bbe5b
SM
75832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7584
7585 * keyboard.c (read_key_sequence_remapped): New var.
7586 (read_key_sequence): Compute remapping in the right buffer.
7587 (command_loop_1): Use read_key_sequence's remapping directly.
7588
51553db6
SM
75892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7590
32c1fffd
SM
7591 * dired.c (file_name_completion): Don't expand file name.
7592 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7593 before checking file name handler.
7594
51553db6
SM
7595 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7596 they've been requested explicitly (bug#9591).
7597
b6bd1599 75982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7599
7600 * keymap.c (Fsingle_key_description): Use make_specified_string
7601 instead of build_string to build string from push_key_description.
7602 (Bug#5193)
7603
f701dc2a
PE
76042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7605
4222c55d
PE
7606 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7607 This fixes a Y2038 bug on 64-bit hosts.
7608 * buffer.c (reset_buffer):
7609 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7610 (Fclear_buffer_auto_save_failure):
7611 Use 0, not -1, to represent an unset failure time, since time_t
7612 might not be signed.
7613
f701dc2a
PE
7614 Remove dependency on glibc malloc internals.
7615 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7616 Move back here from lisp.h, but with their new implementations.
7617 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7618 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7619 * charset.c (charset_table_init): New static var.
7620 (syms_of_charset): Use it instead of xmalloc. This removes a
7621 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7622 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7623 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7624 Move back to alloc.c.
7625 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7626 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7627
9ceebf39
JD
76282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7629
7630 * nsterm.m (windowDidResize): Call x_set_window_size only when
7631 ns_in_resize is true. Otherwise set pixelwidth/height and
7632 call change_frame_size (Bug#9628).
7633
cb993c58
PE
76342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7635
3930c88b
PE
7636 Port --enable-checking=all to Fedora 14 x86-64.
7637 * charset.c (syms_of_charset): Also account for glibc malloc's
7638 internal overhead when calculating the initial malloc maximum.
7639
cb993c58
PE
7640 Port --enable-checking=all to Fedora 14 x86.
7641 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7642 Move to lisp.h.
7643 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7644 (overrun_check_realloc, overrun_check_free):
7645 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7646 That way, xmalloc returns a properly-aligned pointer even if
7647 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7648 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7649 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7650 into account when calculating the initial malloc maximum.
7651 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7652 Move here from alloc.c, so that charset.c can use it too.
7653 Properly align; the old code wasn't right for common 32-bit hosts
7654 when configured with --enable-checking=all.
7655 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7656 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7657
31bed486
EZ
76582011-09-29 Eli Zaretskii <eliz@gnu.org>
7659
04c70788 7660 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7661 use EDOM.
7662
fbcaa2f3
EZ
76632011-09-28 Eli Zaretskii <eliz@gnu.org>
7664
7665 * xdisp.c (compute_display_string_end): If there's no display
7666 string at CHARPOS, return -1.
7667
7668 * bidi.c (bidi_fetch_char): When compute_display_string_end
7669 returns a negative value, treat the character as a normal
7670 character not covered by a display string. (Bug#9624)
7671
a239d4e9
JB
76722011-09-28 Juanma Barranquero <lekktu@gmail.com>
7673
7674 * lread.c (Fread_from_string): Fix typo in docstring.
7675
88652fd5
EZ
76762011-09-27 Eli Zaretskii <eliz@gnu.org>
7677
7678 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7679 newline, reseat the iterator instead of bidi-iterating there one
7680 character at a time. (Bug#9610)
32c1fffd
SM
7681 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7682 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7683
ed497dd4
AS
76842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7685
7686 * lread.c (readevalloop): Use correct code for NBSP.
7687 (read1): Likewise. (Bug#9608)
7688
b2bf61aa
MA
76892011-09-25 Michael Albinus <michael.albinus@gmx.de>
7690
7691 * dbusbind.c (Fdbus_register_signal): When service is not
7692 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7693
32bbb17c
GM
76942011-09-25 Glenn Morris <rgm@gnu.org>
7695
7696 * buffer.c (truncate-lines): Doc fix.
7697
94e0933e
CY
76982011-09-24 Chong Yidong <cyd@stupidchicken.com>
7699
7700 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7701 (Fset_window_next_buffers): Doc fix.
7702
cddde921
GM
77032011-09-24 Glenn Morris <rgm@gnu.org>
7704
7705 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7706
1260aef1
PE
77072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7708
25b4bfa0
PE
7709 Fix minor problems found by static checking.
7710 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7711 * indent.c (Fvertical_motion): Fix == vs = typo.
7712
e3cbd34b
EZ
77132011-09-24 Eli Zaretskii <eliz@gnu.org>
7714
a66cfb1c
SM
7715 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7716 Default value is now t. Doc fix.
6bf7006f 7717
e3cbd34b 7718 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7719 logic when moving up, not only when moving down. Fix the
e3cbd34b 7720 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7721 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7722
7723 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7724 CHARPOS is covered by a display string which includes newlines.
7725 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7726 is covered by a display string with embedded newlines.
7727
a3de0cbd
MA
77282011-09-24 Michael Albinus <michael.albinus@gmx.de>
7729
7730 * dbusbind.c (Fdbus_register_signal): Add match rule to
7731 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7732 (Fdbus_register_method, Vdbus_registered_objects_table):
7733 Fix docstring.
a3de0cbd 7734
b260039d
JM
77352011-09-24 Jim Meyering <meyering@redhat.com>
7736
32c1fffd 7737 do not ignore write error for any output size
b260039d
JM
7738 The previous change was incomplete.
7739 While it makes emacs --batch detect the vast majority of stdout
7740 write failures, errors were still ignored whenever the output size is
7741 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7742 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7743 && echo FAIL: ignored write error
7744 FAIL: ignored write error
7745 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7746 && echo FAIL: ignored write error
7747 FAIL: ignored write error
7748 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7749
8eca8a7c
AS
77502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7751
7752 * emacs.c (Fkill_emacs): In noninteractive mode exit
7753 non-successfully if a write error occurred on stdout. (Bug#9574)
7754
3341db62
EZ
77552011-09-21 Eli Zaretskii <eliz@gnu.org>
7756
7757 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7758 the xassert test.
7759
7760 * dispextern.h (struct it): Update the comment documenting what
7761 can it->OBJECT be.
7762
8c203dbf
EZ
77632011-09-20 Eli Zaretskii <eliz@gnu.org>
7764
7765 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7766 a display string, extend search for cursor position to end of row.
7767 (find_row_edges): If the row ends in a newline from a display
7768 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7769 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7770 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7771 non-empty line. Fixes confusing cursor motion with arrow keys at
7772 the beginning of a line that starts with whitespace.
8c203dbf 7773
a4824228
LMI
77742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7775
7776 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7777 (bug#9493).
7778
33ed493b
CY
77792011-09-18 Chong Yidong <cyd@stupidchicken.com>
7780
7781 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7782 boolean (Bug#9154).
7783
56cd55c8
EZ
77842011-09-18 Eli Zaretskii <eliz@gnu.org>
7785
7786 * xdisp.c (display_line): Record maximum and minimum buffer
7787 positions even if no glyphs were produced (e.g., by a zero-width
7788 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7789 buffer positions that will be removed from the glyph row because
7790 they don't fit.
c02dcedf
EZ
7791 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7792 column is beyond frame width: don't subtract 1 "pixel" when
7793 computing width of the stretch.
3e62b7e0
EZ
7794 (reseat_at_next_visible_line_start): Undo the change made on
7795 2011-09-17 that saved paragraph information and restored it after
7796 the call to `reseat'. (Bug#9545)
56cd55c8 7797
5ed99d36 77982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7799
7800 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7801 and turn window cursor on if cleared (Bug#9415).
7802
5ed99d36 78032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7804
7805 * search.c (boyer_moore): Take unibyte characters from pattern
7806 literally. (Bug#9458)
7807
9bade7b2
EZ
78082011-09-18 Eli Zaretskii <eliz@gnu.org>
7809
7810 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7811
e5e9d610
PE
78122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7813
87e4427a
PE
7814 Fix minor problem found by static checking.
7815 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7816 initialized, to pacify gcc -Wuninitialized.
7817
e5e9d610
PE
7818 * fileio.c: Report proper errno when syscall falls.
7819 (Finsert_file_contents): Save and restore errno,
7820 so that report_file_error outputs the correct diagnostic.
7821 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7822
a1674f0b
EZ
78232011-09-18 Eli Zaretskii <eliz@gnu.org>
7824
7825 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7826
fbfb6dd4
EZ
78272011-09-17 Eli Zaretskii <eliz@gnu.org>
7828
7829 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7830 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7831
bb187662
EZ
78322011-09-17 Eli Zaretskii <eliz@gnu.org>
7833
1137e8b8 7834 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7835 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7836
7837 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7838 (bidi_find_paragraph_start): Search back for paragraph beginning
7839 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7840 (bidi_move_to_visually_next): Only trigger paragraph-related
7841 computations when the last character is a newline or at EOB, not
7842 just any NEUTRAL_B. (Bug#9470)
7843
bb187662
EZ
7844 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7845 truncated lines if point is covered by a display string. (Bug#9524)
7846
2e621251
PE
78472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7848
7849 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7850 (cons_to_x_long): New function.
7851 (lisp_data_to_selection_data): Use it. Correct the test for
7852 short-versus-long data; it was negated. Break out of vector
7853 loop, for efficiency, when a long datum is discovered.
7854
91a15bc6
SM
78552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7856
7857 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7858
b41c3a35
EZ
78592011-09-16 Eli Zaretskii <eliz@gnu.org>
7860
7861 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7862 GCC PR/17406) by declaring this function with external scope.
7863
7812ba2d
PE
78642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7865
7866 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7867 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7868
cf7edc2a
AS
78692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7870
7871 * editfns.c (Fformat): Correctly handle text properties on "%%".
7872
bd01620e
EZ
78732011-09-15 Eli Zaretskii <eliz@gnu.org>
7874
7875 * xterm.c (x_draw_composite_glyph_string_foreground):
7876 * w32term.c (x_draw_composite_glyph_string_foreground):
7877 * term.c (encode_terminal_code):
7878 * composite.c (composition_update_it, get_composition_id):
7879 * xdisp.c (get_next_display_element)
7880 (fill_composite_glyph_string): Add comments about special meaning
7881 of TAB characters in a composition.
7882
a02719a3
PE
78832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7884
7885 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7886 This occurs when processing a multibyte format.
7887 Problem reported by Wolfgang Jenker.
a02719a3 7888
72589a3c
JB
78892011-09-15 Johan Bockgård <bojohan@gnu.org>
7890
7891 * xdisp.c (try_cursor_movement): Only check for exact match if
7892 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7893
1c14176c
PE
78942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7895
7896 Remove unused external symbols.
7897 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7898 * xdisp.c (calc_pixel_width_or_height): Now static.
7899 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7900 * indent.c (check_display_width):
7901 * w32term.c: Fix comment to match code.
7902 * xterm.c, xterm.h (x_catching_errors): Remove.
7903
d2eea5b5
PE
79042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7905
7906 * xselect.c: Use signed conversions more consistently (Bug#9498).
7907 (selection_data_to_lisp_data): Assume incoming selection data are
7908 signed integers, not unsigned. This is to be consistent with
7909 outgoing selection data, which was modified to use signed integers
7910 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7911 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7912 expects long, not unsigned long.
7913
46888499
EZ
79142011-09-14 Eli Zaretskii <eliz@gnu.org>
7915
7916 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7917 computation of loop end. Reported by Johan Bockgård
7918 <bojohan@gnu.org>.
7919
ef8ef9fb
CY
79202011-09-13 Chong Yidong <cyd@stupidchicken.com>
7921
7922 * frame.c (Fother_visible_frames_p): Function deleted.
7923
fa819fed
EZ
79242011-09-12 Eli Zaretskii <eliz@gnu.org>
7925
7926 * indent.c (compute_motion): Process display vector front to back
7927 rather than the other way around. (Bug#2496)
7928
2ba8e008
SM
79292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7930
7931 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7932
20f53c69
CY
79332011-09-11 Chong Yidong <cyd@stupidchicken.com>
7934
7935 * minibuf.c (Fread_from_minibuffer): Doc fix.
7936
d562d7a4
EZ
79372011-09-11 Eli Zaretskii <eliz@gnu.org>
7938
7939 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7940 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7941
1c4d7f3d
LMI
79422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7943
7944 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7945 value for non-existent files.
7946
b885bf36
EZ
79472011-09-11 Eli Zaretskii <eliz@gnu.org>
7948
7949 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7950 set its "size" to -1. This will set the modtime_size field of
7951 the corresponding buffer to -1, which is what
7952 verify-visited-file-modtime expects for files that do not exist.
7953 (Bug#9139)
7954
6612f0bf
PE
79552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7956
7957 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7958 here ...
7959 * lisp.h: ... from here. push_key_description is no longer
7960 defined in keyboard.c, so its declaration should not be in
7961 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7962 logically belongs with push_key_description.
7963
dfb3f755
PE
79642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7965
7966 * buffer.h: Include <sys/types.h> instead of <time.h>.
7967 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7968 Problem reported by Herbert J. Skuhra.
7969
3134906c
LMI
79702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7971
7972 * xml.c (parse_region): Make the parsing work for
7973 non-comment-starting XML files again (bug#9144).
7974
8d903f4e
AS
79752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7976
7977 * image.c (gif_load): Fix calculation of bottom and right corner.
7978 (Bug#9468)
7979
80ad64f4
EZ
79802011-09-10 Eli Zaretskii <eliz@gnu.org>
7981
7982 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7983 redisplay in small windows.
7984
208a048d
EZ
79852011-09-09 Eli Zaretskii <eliz@gnu.org>
7986
7987 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7988
9b1c252e
MR
79892011-09-08 Martin Rudalics <rudalics@gmx.at>
7990
7991 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7992 Operate on live windows only.
7993
2949f33b
JB
79942011-09-08 Juanma Barranquero <lekktu@gmail.com>
7995
7996 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7997
e08dcafd
EZ
79982011-09-07 Eli Zaretskii <eliz@gnu.org>
7999
8000 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8001 only under bidi iteration.
8002
115b96bd
JD
80032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8004
8005 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8006
c8199d0f
PE
80072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8008
8009 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8010 Without this fix, the command to link temacs failed due to an
8011 undefined symbol __builtin_isnan. This is because
8012 /usr/include/iso/math_c99.h #defines isnan(x) to
8013 __builtin_isnan(x), but the bundled gcc, which identifies itself
8014 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8015 a __builtin_isnan.
8016 * floatfns.c (isnan): #undef, and then #define to a clone of
8017 what's in data.c.
8018 (Fisnan): Always define, since it's always available now.
8019 (syms_of_floatfns): Always define isnan at the Lisp level.
8020
e39b275c 80212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8022
8023 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8024
b2db44d9 80252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8026
f4af5137 8027 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8028 The previous code assumed that file offsets (off_t values) fit in
8029 EMACS_INT variables, which is not true on typical 32-bit hosts.
8030 The code messed up by falsely reporting buffer overflow in cases
8031 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8032 when "big" contains more than 2**29 bytes, even though this
8033 inserts just one byte and does not overflow the buffer.
8034 (Finsert_file_contents): Store file offsets as off_t
8035 values, not as EMACS_INT values. Check for overflow when
8036 converting between EMACS_INT and off_t. When checking for
8037 buffer overflow or for overlap, take the offsets into account.
8038 Don't use EMACS_INT for small values where int suffices.
8039 When checking for overlap, fix a typo: ZV was used where
8040 ZV_BYTE was intended.
8041 (Fwrite_region): Don't assume off_t fits into 'long'.
8042 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8043
ecfc0a49
MA
80442011-09-05 Michael Albinus <michael.albinus@gmx.de>
8045
8046 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8047
6511acf2 80482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8049
0999621a 8050 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8051
8052 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8053 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8054 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8055 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8056 (modify_event_symbol): Do not assume that the length of
8057 name_alist_or_stem is safe to alloca and fits in int.
8058 (Fexecute_extended_command): Likewise for function name and binding.
8059 (Frecursion_depth): Wrap around reliably on integer overflow.
8060 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8061 since some callers pass EMACS_INT values.
8062 (Fsingle_key_description): Don't crash if symbol name contains more
8063 than MAX_ALLOCA bytes.
8064 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8065 (get_minibuffer): Arg is now EMACS_INT, not int.
8066 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8067 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8068 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8069
2be7d702
PE
8070 * dbusbind.c (signature_cat): New function.
8071 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8072 Do not overrun buffer; instead, report string overflow.
8073
9d1df220
PE
8074 * dispnew.c (add_window_display_history): Don't overrun buffer.
8075 Truncate instead; this is OK since it's just a log.
8076
33ef5c64
PE
8077 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8078 even if the time zone offset is outlandishly large.
8079 Don't mishandle offset == INT_MIN.
8080
66c6fdd5
PE
8081 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8082 when creating daemon; the previous buffer-overflow check was incorrect.
8083
d749b01b
PE
8084 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8085 which has the guts of the old verror function.
8086
b5cd1905
PE
8087 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8088 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8089
6e1a67fb
PE
8090 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8091 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8092 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8093 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8094 length of string rather than counting it via multiple sprintfs;
8095 that's simpler and more reliable.
c21721cc
PE
8096 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8097 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8098 sprintf, in case result does not fit in int.
8099
c57b67fc
PE
8100 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8101 (fontset_from_font): Print it.
8102
8a401434
PE
8103 * frame.c (tty_frame_count): Now printmax_t, not int.
8104 (make_terminal_frame, set_term_frame_name): Print it.
8105 (x_report_frame_params): In X, window IDs are unsigned long,
8106 not signed long, so print them as unsigned.
8107 (validate_x_resource_name): Check for implausibly long names,
8108 and don't assume name length fits in 'int'.
8109 (x_get_resource_string): Don't blindly alloca invocation name;
8110 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8111 not fit in int.
8112
6e1a67fb
PE
8113 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8114 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8115 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8116
0df02bf3
PE
8117 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8118 Use esprintf, not sprintf, in case result does not fit in int.
8119
48e30793
PE
8120 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8121 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8122 it as a large positive number.
8123 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8124 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8125
a66ff6d8
PE
8126 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8127 in case result does not fit in int.
8128
aca216ff
PE
8129 * print.c (float_to_string): Detect width overflow more reliably.
8130 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8131 buffer overrun. Don't assume list length fits in 'int'. Treat
8132 print length of 0 as 0, not as infinity; to be consistent with other
8133 uses of print length in this function. Don't overflow print length
8134 index. Don't assume hash table size fits in 'long', or that
8135 vectorlike size fits in 'unsigned long'.
8136
31c286f7
PE
8137 * process.c (make_process): Use printmax_t, not int, to format
8138 process-name gensyms.
8139
55e5faa1
PE
8140 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8141
80f2e268
PE
8142 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8143 to avoid potential buffer overrun.
8144
670741ab
PE
8145 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8146 if X resource line is longer than 512 bytes.
8147
b7163a50
PE
8148 * xfns.c (x_window): Make sprintf buffer a bit bigger
8149 to avoid potential buffer overrun.
8150
ae58ff1f
PE
8151 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8152
c43c8a6a
PE
8153 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8154
3f8236f4
PE
81552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8156
53e9fe90 8157 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8158 Without these, Emacs silently mishandles large integers sometimes.
8159 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8160 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8161
6511acf2
PE
8162 * xdisp.c (try_window_id): Check Emacs fixnum range before
8163 converting to 'int'.
806add1d 8164
6511acf2 8165 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8166 Check that an Emacs fixnum is in range before assigning it to 'int'.
8167 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8168 values converted from Emacs fixnums.
8169 (Frecenter): Don't wrap around a line count if it is out of 'int'
8170 range; instead, treat it as an extreme value.
8171 (Fset_window_configuration, compare_window_configurations):
8172 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8173
6511acf2
PE
8174 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8175 that can exceed INT_MAX. Check that EMACS_INT value is in range
8176 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8177 (match_limit): Don't assume that a fixnum can fit in 'int'.
8178
6511acf2 8179 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8180 exceed INT_MAX.
8181
6511acf2 8182 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8183 (Fvertical_motion): Don't wrap around LINES values that don't fit
8184 in 'int'. Instead, treat them as extreme values. This is good
8185 enough for windows, which can't have more than INT_MAX lines anyway.
8186
fcb901a7
LMI
81872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8188
0f2f6b6d
LMI
8189 * Require libxml/parser.h to avoid compilation warning.
8190
fcb901a7
LMI
8191 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8192
8193 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8194 since this reportedly can destroy thread storage.
8195
6e20a0d4
CY
81962011-08-30 Chong Yidong <cyd@stupidchicken.com>
8197
8198 * syntax.c (find_defun_start): Update all cache variables if
8199 exiting early (Bug#9401).
8200
148ae00e
EZ
82012011-08-30 Eli Zaretskii <eliz@gnu.org>
8202
f6cfbd8f
EZ
8203 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8204
148ae00e
EZ
8205 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8206 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8207 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8208
8209 * term.c (tty_append_glyph): New function.
8210 (produce_stretch_glyph): Static function and its prototype deleted.
8211
a66cfb1c
SM
8212 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8213 Add prototypes.
148ae00e 8214
c4a07a4c
PE
82152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8216
8217 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8218 when checking :margin (Bug#9390).
8219 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8220 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8221 so that the name doesn't mislead. All uses changed.
8222
6bc8cd65
JB
82232011-08-28 Johan Bockgård <bojohan@gnu.org>
8224
8225 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8226 set_tty_hooks.
8227
dca4927e
EZ
82282011-08-27 Eli Zaretskii <eliz@gnu.org>
8229
8230 * xdisp.c (move_it_to): Don't bail out early when reaching
8231 position beyond to_charpos, if we are scanning backwards.
8232 (move_it_vertically_backward): When DY == 0, make sure we get to
8233 the first character in the line after the newline.
8234
f2cad773
PE
82352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8236
8237 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8238 (ccl_driver): Do not generate an out-of-range pointer.
8239 (Fccl_execute_on_string): Remove unnecessary check for
8240 integer overflow, noted by Stefan Monnier in
8241 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8242 Remove a FIXME that didn't need fixing.
8243 Simplify the newly-introduced buffer reallocation code.
8244
0cae2cdb
JB
82452011-08-27 Juanma Barranquero <lekktu@gmail.com>
8246
8247 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8248
5fc295a4 82492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8250
70c60eb2 8251 Integer and memory overflow issues (Bug#9196).
726e0ab1 8252
d31850da
PE
8253 * doc.c (get_doc_string): Rework so that
8254 get_doc_string_buffer_size is the actual buffer size, rather than
8255 being 1 less than the actual buffer size; this makes xpalloc more
8256 convenient.
8257
a69fbedb
PE
8258 * image.c (x_allocate_bitmap_record, cache_image):
8259 * xselect.c (Fx_register_dnd_atom):
8260 Simplify previous changes by using xpalloc.
8261
fe5c5d37
PE
8262 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8263 since either will do and ptrdiff_t is convenient with xpalloc.
8264
0065d054
PE
8265 * charset.c (charset_table_size)
8266 (struct charset_sort_data.priority): Now ptrdiff_t.
8267 (charset_compare): Don't overflow if priorities differ greatly.
8268 (Fsort_charsets): Don't assume list length fits in int.
8269 Check for size-calculation overflow when allocating sort data.
8270 (syms_of_charset): Allocate an initial charset table that is
8271 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8272
8273 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8274
8275 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8276 The actual value is always <= INT_MAX, and leaving it unsigned made
8277 overflow checking harder.
8278
8279 * dispextern.h (struct glyph_matrix.rows_allocated)
8280 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8281 with xpalloc. The values are still always <= INT_MAX.
8282
8283 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8284
8285 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8286 (SAFE_NALLOCA): New macro.
8287
8288 * region-cache.c (struct boundary.pos, find_cache_boundary)
8289 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8290 (set_cache_region, invalidate_region_cache)
8291 (revalidate_region_cache, know_region_cache, region_cache_forward)
8292 (region_cache_backward, pp_cache):
8293 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8294 so that ptrdiff_t * can be passed to xpalloc.
8295 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8296 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8297 (pp_cache): Don't assume cache_len fits in int.
8298 * region-cache.h: Adjust extern decls to match.
8299
8300 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8301 EMACS_INT, since either will do, for xpalloc.
8302
8303 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8304 (xnmalloc, xnrealloc, xpalloc): New functions.
8305
726e0ab1
PE
8306 * bidi.c (bidi_shelve_header_size): New constant.
8307 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8308 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8309
51f30bc5 8310 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8311 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8312 (overlay_strings):
8313 Don't update size of array until after memory allocation succeeds,
8314 because xmalloc/xrealloc may not return.
0065d054
PE
8315 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8316 now that we have proper integer overflow checking.
8317 (record_overlay_string, overlay_strings): Catch overflows when
8318 calculating size of overlay_str_buf.
726e0ab1 8319
0065d054
PE
8320 * callproc.c (Fcall_process): Check for size overflow when
8321 calculating size of args2.
8322 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8323 Normally we prefer signed values, but sticking with ptrdiff_t would
8324 require adding more-complicated checks.
726e0ab1
PE
8325
8326 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8327 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8328 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8329 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8330
8331 * character.c (Fstring): Check for size-calculation overflow.
8332
8333 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8334 unnecessary integer overflow. Check for size overflow.
8335 (encode_coding_object): Don't update size until xmalloc succeeds.
8336
8337 * composite.c (get_composition_id): Check for overflow in glyph
8338 length calculations.
8339
8340 Integer and memory overflow fixes for display code.
8341 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8342 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8343 (scrolling_window): Check for overflow in size calculations.
8344 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8345 Don't assume glyph table len fits in int.
8346 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8347 (row_table_size): Now ptrdiff_t, not int.
8348 (scrolling_window): Avoid overflow in size calculations.
8349 Don't update size until allocation succeeds.
8350 * fns.c (concat): Check for overflow in size calculations.
8351 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8352 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8353 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8354
8355 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8356 (get_doc_string): Check for size calculation overflow.
8357 Don't update size until allocation succeeds.
8358 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8359 EMACS_INT, where ptrdiff_t will do.
8360 (Fsubstitute_command_keys): Check for string overflow.
8361
8362 * editfns.c (set_time_zone_rule): Don't assume environment length
8363 fits in int.
8364 (message_length): Now ptrdiff_t, not int.
8365 (Fmessage_box): Don't update size until allocation succeeds.
8366 Don't assume message length fits in int.
8367 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8368
0065d054
PE
8369 * emacs.c (main): Do not reallocate argv, since there is a null at
8370 the end that can be overwritten, and this way there's no need to
8371 worry about size-calculation overflow.
8372 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8373
8374 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8375 alloc succeeds.
8376 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8377
8378 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8379 (x_set_scroll_bar_width, x_figure_window_size):
8380 Check for integer overflow.
8381 (x_set_alpha): Do not assume XINT fits in int.
8382
8383 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8384 This is for the members text_lines, text_cols, total_lines, total_cols,
8385 where the system imposes an 'int' limit.
8386
8387 * fringe.c (Fdefine_fringe_bitmap):
8388 Don't update size until alloc works.
8389
8390 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8391 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8392
8393 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8394 Check for size-calculation overflow.
8395 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8396 do, as we prefer signed integers.
8397 (id_to_widget.max_size, id_to_widget.used)
8398 (xg_store_widget_in_map, xg_remove_widget_from_map)
8399 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8400 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8401 Use and return ptrdiff_t, not int.
8402 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8403 * gtkutil.h: Change prototypes to match the above.
8404
8405 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8406 are duplicate now that they've been promoted to lisp.h.
8407 (x_allocate_bitmap_record, x_alloc_image_color)
8408 (make_image_cache, cache_image, xpm_load):
8409 Don't update size until alloc is done.
8410 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8411 (x_detect_edges):
3256efce 8412 Check for size calculation overflow.
726e0ab1
PE
8413 (ct_colors_allocated_max): New constant.
8414 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8415 overflow.
3256efce 8416
726e0ab1
PE
8417 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8418 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8419 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8420 Use ptrdiff_t, not int, to count maps.
8421 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8422 calculations. Don't update size until allocation succeeds.
8423 Redo calculations to avoid overflow.
726e0ab1
PE
8424 * keyboard.h: Change prototypes to match the above.
8425
8426 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8427 to count maps.
8428 (current_minor_maps): Check for size calculation overflow.
8429 * keymap.h: Change prototypes to match the above.
8430
8431 * lread.c (read1, init_obarray): Don't update size until alloc done.
8432
8433 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8434 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8435
726e0ab1
PE
8436 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8437 Now ptrdiff_t, not int.
8438 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8439 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8440
8441 * process.c (Fnetwork_interface_list): Check for overflow
8442 in size calculation.
8443
8444 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8445
8446 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8447 overflow. Don't bother calling xmalloc when xrealloc will do.
8448
8449 * search.c (Freplace_match): Check for size calculation overflow.
8450 (Fset_match_data): Don't assume list lengths fit in 'int'.
8451
8452 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8453 for command line length. Do not attempt to address one before the
8454 beginning of an array, as that's not portable.
8455
8456 * term.c (max_frame_lines): Remove; unused.
8457 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8458 not int.
8459 (encode_terminal_code, calculate_costs): Check for size
8460 calculation overflow.
8461 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8462 table lengths and related sizes. Don't update size until alloc
8463 done. Redo calculations to avoid overflow.
8464 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8465
8466 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8467 subtracting pointers.
8468 (gobble_line): Check for overflow more carefully. Don't update size
8469 until alloc done.
8470
8471 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8472 Don't update size until alloc done.
8473 Redo size calculations to avoid overflow.
8474 Check for size calculation overflow.
0065d054 8475 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8476
8477 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8478 Use ptrdiff_t, not int, for sizes.
8479 (store_mode_line_noprop_char): Don't update size until alloc done.
8480
0065d054
PE
8481 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8482 Use ptrdiff_t, not int, for sizes.
8483 (Finternal_make_lisp_face, cache_face):
8484 Check for size calculation overflow.
8485 (cache_face): Treat size calculation overflows as if they were
8486 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8487
8488 * xfns.c (x_encode_text, x_set_name_internal)
8489 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8490 sizes, since they can exceed INT_MAX in size. Check for size
8491 calculation overflow.
8492
0065d054
PE
8493 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8494 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8495 Don't update size until alloc done.
8496
0065d054 8497 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8498 as sprintf is limited to int lengths.
1d526e2f 8499
252c5ee1
PE
8500 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8501 (X_LONG_MIN): New macros.
864d7ce7
PE
8502 Use them to make the following changes clearer.
8503 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8504 This change doesn't affect the value now, but it may help remind
8505 future maintainers not to raise the value too much later.
8506 (SELECTION_QUANTUM): Remove, replacing with ...
8507 (selection_quantum): ... new function, which avoids overflow.
8508 All uses changed.
8509 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8510 assumption that selection length fits in 'int'.
8511 (x_reply_selection_request, x_handle_selection_request)
8512 (x_get_window_property, receive_incremental_selection)
8513 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8514 (lisp_data_to_selection_data, clean_local_selection_data):
8515 Use ptrdiff_t, not int, to record length of selection.
8516 (x_reply_selection_request, x_get_window_property)
8517 (receive_incremental_selection, x_property_data_to_lisp):
8518 Redo calculations to avoid overflow.
8519 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8520 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8521 something.
8522 (x_get_window_property, receive_incremental_selection)
8523 (lisp_data_to_selection_data, x_property_data_to_lisp):
8524 Check for size-calculation overflow.
8525 (x_get_window_property, receive_incremental_selection)
8526 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8527 Don't store size until memory allocation succeeds.
8528 (x_get_window_property): Plug memory leak on memory exhaustion.
8529 Don't double-block input; malloc is safe here. Don't assume 2**34
8530 - 4 fits in unsigned long. Add an xassert to check
8531 XGetWindowProperty overflow. Be more careful about overflow
8532 calculations, and distinguish size from memory overflow better.
8533 (receive_incremental_selection): When tracing, don't assume
8534 unsigned int is less than INT_MAX.
8535 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8536 harmful) conversions of unsigned short to int.
8537 (lisp_data_to_selection_data): Don't assume that integers
8538 in the range -65535 through -1 fit in an X unsigned short.
8539 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8540 result parameters unless successful. Rely on cons_to_unsigned
8541 to report problems with elements; the old code wasn't right anyway.
8542 (x_check_property_data): Check for int overflow; we cannot use
8543 a wider type due to X limits.
8544 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8545
726e0ab1 8546 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8547
0065d054
PE
8548 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8549 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8550 (x_color_cells): Don't store size until memory allocation succeeds.
8551 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8552 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8553 (x_term_init): Don't assume length fits in int (sprintf is limited
8554 to int size).
bc18e09d 8555
ebfa62c0
PE
8556 Use ptrdiff_t for composition IDs.
8557 * character.c (lisp_string_width):
8558 * composite.c (composition_table_size, n_compositions)
8559 (get_composition_id, composition_gstring_from_id):
8560 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8561 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8562 * window.c (Frecenter):
8563 Use ptrdiff_t, not int, for composition IDs.
8564 * composite.c (get_composition_id): Check for integer overflow.
8565 * composite.h: Adjust prototypes to match the above changes.
8566
d3411f89
PE
8567 Use ptrdiff_t for hash table indexes.
8568 * category.c (hash_get_category_set):
8569 * ccl.c (ccl_driver):
8570 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8571 * coding.c (coding_system_charset_list, detect_coding_system):
8572 * coding.h (struct coding_system.id):
8573 * composite.c (get_composition_id, gstring_lookup_cache):
8574 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8575 * image.c (xpm_get_color_table_h):
8576 * lisp.h (hash_lookup, hash_put):
8577 * minibuf.c (Ftest_completion):
8578 Use ptrdiff_t for hash table indexes, not int (which is too
8579 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8580 32-bit --with-wide-int hosts).
8581
e097a6fa
PE
8582 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8583 Add a FIXME comment about memory leaks.
8584 (syms_of_charset): Don't assume xmalloc returns.
8585
5637687f
PE
8586 Don't assume that stated character widths fit in int.
8587 * character.c (Fchar_width, c_string_width, lisp_string_width):
8588 * character.h (CHAR_WIDTH):
8589 * indent.c (MULTIBYTE_BYTES_WIDTH):
8590 Use sanitize_char_width to avoid undefined and/or bad behavior
8591 with outlandish widths.
a66cfb1c 8592 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8593 now that we have two such functions. All uses changed.
8594 (sanitize_char_width): New inline function.
8595
a2271ba2
PE
8596 Don't assume that tab-width fits in int.
8597 * character.h (sanitize_width): New inline function.
8598 (SANE_TAB_WIDTH): New macro.
8599 (ASCII_CHAR_WIDTH): Use it.
8600 * indent.c (sane_tab_width): Remove. All uses replaced by
8601 SANE_TAB_WIDTH (current_buffer).
8602 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8603
18c52557
PE
8604 * fileio.c: Integer overflow issues with file modes.
8605 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8606
caeeedc1
PE
8607 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8608 Remove unreachable code.
8609 (read_hex, load_charset_map_from_file): Check for integer overflow.
8610
6df6ae42 8611 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8612 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8613 (x_send_scroll_bar_event): Likewise. Check that the size does not
8614 exceed limits imposed by XClientMessageEvent, as well as the usual
8615 ptrdiff_t and size_t limits.
8616
b13995db
PE
8617 * keyboard.c: Overflow, signedness and related fixes.
8618 (make_lispy_movement): Use same integer type in forward decl
8619 that is used in the definition.
8620 (read_key_sequence, keyremap_step):
8621 Change bufsize argument back to int, undoing my 2011-03-30 change.
8622 We prefer signed types, and int is wide enough here.
8623 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8624 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8625 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8626 length, not size_t. Use ptrdiff_t for index, not int.
8627 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8628 possibility of integer overflow.
8629
13464394
PE
8630 Overflow, signedness and related fixes for images.
8631
8632 * dispextern.h (struct it.stack[0].u.image.image_id)
8633 (struct_it.image_id, struct image.id, struct image_cache.size)
8634 (struct image_cache.used, struct image_cache.ref_count):
8635 * gtkutil.c (update_frame_tool_bar):
8636 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8637 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8638 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8639 * nsmenu.m (update_frame_tool_bar):
8640 * xdisp.c (calc_pixel_width_or_height):
8641 * xfns.c (image_cache_refcount):
8642 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8643 on typical 64-bit hosts.
8644
8645 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8646 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8647 Omit unnecessary casts to int.
8648 (parse_image_spec): Check that integers fall into 'int' range
8649 when the callers expect that.
8650 (image_ascent): Redo ascent calculation to avoid int overflow.
8651 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8652 (lookup_image): Remove unnecessary tests.
8653 (xbm_image_p): Locals are now of int, not EMACS_INT,
8654 since parse_image_check makes sure they fit into int.
8655 (png_load, gif_load, svg_load_image):
8656 Prefer int to unsigned where either will do.
8657 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8658 old tiff_error_handler and tiff_warning_handler.
8659 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8660 stack buffer overflows. It uses only the features of vsnprintf
8661 that are common to both POSIX and native Microsoft.
8662 (tiff_error_handler, tiff_warning_handler): Use it.
8663 (tiff_load, gif_load, imagemagick_load_image):
8664 Don't assume :index value fits in 'int'.
8665 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8666 (imagemagick_load_image): Check that crop parameters fit into
8667 the integer types that MagickCropImage accepts. Don't assume
8668 Vimagemagick_render_type has a nonnegative value. Don't assume
8669 size_t fits in 'long'.
8670 (gs_load): Use printmax_t to print the widest integers possible.
8671 Check for integer overflow when computing image height and width.
8672
c11821d4
EZ
86732011-08-26 Eli Zaretskii <eliz@gnu.org>
8674
8675 * xdisp.c (redisplay_window): Don't force window start if point
8676 will be invisible in the resulting window. (Bug#9324)
8677
0c95fcf7
EZ
86782011-08-25 Eli Zaretskii <eliz@gnu.org>
8679
8680 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8681 the display spec is of the form `(space ...)'.
8682 (handle_display_spec): Return the value returned by
8683 handle_single_display_spec, not just 1 or zero.
8684 (handle_single_display_spec): If the display spec is of the form
8685 `(space ...)', and specifies display in the text area, return 2
8686 rather than 1.
fee65a97 8687 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8688 accurately, and prefer exact match for point under bidi.
8689 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8690
8691 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8692 into disp_prop; all users changed.
8693
8694 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8695 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8696 for the text covered by the display property.
8697
e4ed06f1
CY
86982011-08-25 Chong Yidong <cyd@stupidchicken.com>
8699
8700 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8701 Change return value to nil.
8702 (Frecord_buffer): Delete unused function.
8703
f67cdd7f
EZ
87042011-08-24 Eli Zaretskii <eliz@gnu.org>
8705
5980d4c6
EZ
8706 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8707 buffers, return left-to-right.
8610fe8b
EZ
8708 (set_cursor_from_row): Consider candidate row a win if its glyph
8709 represents a newline and point is on that newline. Fixes cursor
8710 positioning on the newline at EOL of R2L text within L2R
8711 paragraph, and vice versa.
8712 (try_cursor_movement): Check continued rows, in addition to
8713 continuation rows. Fixes unwarranted scroll when point enters a
8714 continued line of R2L text within an L2R paragraph, or vice versa.
8715 (cursor_row_p): Consider the case of point being equal to
8716 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8717 from the end of a short line to the beginning of a continued line
8718 of R2L text within L2R paragraph.
8719 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8720 composed characters.
5980d4c6 8721
f67cdd7f
EZ
8722 * bidi.c (bidi_check_type): Use xassert.
8723 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8724 members.
8725
bca633fb
EZ
87262011-08-23 Eli Zaretskii <eliz@gnu.org>
8727
8728 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8729 a character.
8730
4a5885a7
CY
87312011-08-23 Chong Yidong <cyd@stupidchicken.com>
8732
8733 * nsfont.m (ns_otf_to_script): Fix typo.
8734
0902a04e
KH
87352011-08-22 Kenichi Handa <handa@m17n.org>
8736
8737 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8738 extra slot even if the purpose is char-code-property-table.
8739
1a2e6670
EZ
87402011-08-23 Eli Zaretskii <eliz@gnu.org>
8741
8ddde651
EZ
8742 * xdisp.c (redisplay_window): When computing centering_position,
8743 account for the height of the header line. (Bug#8874)
8744
425cc014
EZ
8745 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8746 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8747 candidate is selected by the mouse, and that candidate has a
8748 composed character under the mouse.
8749
1a2e6670
EZ
8750 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8751 coordinates reported by pos-visible-in-window-p for a composed
8752 character in column zero.
8753
8b76d6f8
SM
87542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8755
8756 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8757
dac347dd
EZ
87582011-08-22 Eli Zaretskii <eliz@gnu.org>
8759
8760 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8761 consider it a hit if to_charpos is anywhere in the range of the
8762 composed buffer positions.
8763
e013fb34
CY
87642011-08-22 Chong Yidong <cyd@stupidchicken.com>
8765
8766 * image.c (gif_load): Don't assume that each subimage has the same
8767 dimensions as the base image. Handle disposal method that is
8768 "undefined" by the gif spec (Bug#9335).
8769
bd1ba3e8
CY
87702011-08-20 Chong Yidong <cyd@stupidchicken.com>
8771
8772 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8773 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8774
54a1215b
EZ
87752011-08-19 Eli Zaretskii <eliz@gnu.org>
8776
823564e5
EZ
8777 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8778 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8779 from an Org mode buffer to a Speedbar frame.
8780
54a1215b
EZ
8781 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8782 a composition, take its buffer position from IT->cmp_it.charpos.
8783 Fixes cursor positioning at the beginning of a line that begins
8784 with a composed character.
8785
9778ebcc
EZ
87862011-08-18 Eli Zaretskii <eliz@gnu.org>
8787
0be6ee06
EZ
8788 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8789 character bidirectional type, use STRONG_L instead. Fixes crashes
8790 in a buffer produced by `describe-categories'.
8791
9778ebcc
EZ
8792 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8793 members before the level stack, so they would be saved and
8794 restored when copying iterator state. Fixes incorrect reordering
8795 around TABs covered by display properties.
8796
156bffbe
AS
87972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8798
6b02f655 8799 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8800
72ad093b
CY
88012011-08-17 Chong Yidong <cyd@stupidchicken.com>
8802
8803 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8804 (internal_condition_case_2, internal_condition_case_n):
8805 Remove unnecessary aborts (Bug#9081).
72ad093b 8806
35774242
EZ
88072011-08-17 Eli Zaretskii <eliz@gnu.org>
8808
8809 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8810 has no `load' handler, try opening the file locally. (Bug#9311)
8811
db76dd85
KB
88122011-08-16 Ken Brown <kbrown@cornell.edu>
8813
8814 * gmalloc.c: Expand comment.
8815
b215eee5
EZ
88162011-08-16 Eli Zaretskii <eliz@gnu.org>
8817
8818 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8819 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8820
a4579d33
KB
88212011-08-16 Ken Brown <kbrown@cornell.edu>
8822
8823 Fix memory allocation problems in Cygwin build (Bug#9273).
8824
8825 * unexcw.c ( __malloc_initialized): Declare external variable.
8826 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8827
8b76d6f8
SM
8828 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8829 New variables.
a4579d33
KB
8830 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8831 dumped emacs.
8832 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8833 in the static heap.
8834 [CYGWIN] (special_realloc): New function.
8835 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8836 requests to realloc storage in the static heap.
8837
3ebec551
PE
88382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8839
8840 * bidi.c (bidi_initialize): Remove unused local.
8841
9fd8be00
EZ
88422011-08-15 Eli Zaretskii <eliz@gnu.org>
8843
6b02f655
SM
8844 * bidimirror.h:
8845 * biditype.h: Remove file.
8846 * makefile.w32-in ($(BLD)/bidi.$(O)):
8847 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8848
8849 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8850
8851 * chartab.c: Improve commentary for the uniprop_table API.
8852
32413314
EZ
8853 * bidi.c (bidi_paragraph_init): Support zero value of
8854 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8855 (bidi_initialize): Use uniprop_table instead of including
8856 biditype.h and bidimirror.h.
32413314 8857
9fd8be00
EZ
8858 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8859 coordinates of the iterator when restoring from ppos_it.
8860 (Bug#9296)
8861
5cf2b69b
KH
88622011-08-14 Kenichi Handa <handa@m17n.org>
8863
8864 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8865 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8866
daf17d00
EZ
88672011-08-14 Eli Zaretskii <eliz@gnu.org>
8868
8869 * xdisp.c (move_it_in_display_line_to): Don't invoke
8870 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8871 ppos_it. Fixes vertical cursor motion when line beginning is
8872 covered by an image. (Bug#9296)
8873
08e3161a
JD
88742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8875
8876 * nsterm.h (ns_run_ascript): Declare.
8877 (NSAPP_DATA2_RUNASSCRIPT): Define.
8878
8879 * nsfns.m (as_script, as_result, as_status): New static variables.
8880 (ns_run_ascript): New function.
5e617bc2 8881 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8882 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8883 the event loop. Get status from as_status (Bug#7276).
8884
8885 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8886 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8887 the event loop (Bug#7276).
8888
a3720aa2
AS
88892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8890
8891 * gnutls.c (QCgnutls_bootprop_priority)
8892 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8893 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8894 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8895 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8896 (QCgnutls_bootprop_verify_hostname_error)
8897 (QCgnutls_bootprop_callbacks_verify): Rename from
8898 Qgnutls_bootprop_..., all uses changed.
8899
8900 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8901 uses changed.
8902
0a0d27fb
PE
89032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8904
19d5c50c
PE
8905 * xfaces.c (Qframe_set_background_mode): Now static.
8906 * dispextern.h (Qframe_set_background_mode): Remove decl.
8907
0a0d27fb
PE
8908 * process.c (Fnetwork_interface_info): Declare local only if needed.
8909
377538cb
JD
89102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8911
8912 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8913 (Fnetwork_interface_list): Allocate in increments of bytes instead
8914 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8915 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8916 sockaddr.
8917 (struct ifflag_def): notrailers is smart on OSX.
8918 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8919 Get hardware address with getifaddrs if available.
8920
08fff70c
EZ
89212011-08-12 Eli Zaretskii <eliz@gnu.org>
8922
8923 * xdisp.c (iterate_out_of_display_property): xassert that
8924 IT->position is set to within IT->object's boundaries. Break from
8925 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8926 when IT->position is set up wrongly due to some bug.
8927 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8928 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8929 entry. Force push_it to save on the stack the current
8930 buffer/string position, to be restored by pop_it. Fix flags in
8931 the iterator structure wrt the object coming from a display
8932 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8933 properties. (Bug#9284)
8934
7be1c708 89352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8936
7be1c708
CY
8937 * fontset.c (fontset_get_font_group): Add proper type checks.
8938 (Bug#9172)
aac0c6e3 8939
7be1c708 89402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8941
7be1c708
CY
8942 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8943 and LC_VERSION_MIN_MACOSX.
8944 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8945 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8946
97bb72a6
EZ
89472011-08-08 Eli Zaretskii <eliz@gnu.org>
8948
8949 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8950 no-display-properties-and-no-overlays under bidi display.
8951 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8952 properties and overlays.
97bb72a6 8953
d5617611
CY
89542011-08-08 Chong Yidong <cyd@stupidchicken.com>
8955
37e11a63
CY
8956 * editfns.c (Fset_time_zone_rule): Document relationship with the
8957 setenv function.
8958
d5617611
CY
8959 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8960 the font entity extracted from the cache (Bug#8109).
8961
58872834
CY
89622011-08-07 Chong Yidong <cyd@stupidchicken.com>
8963
8964 * composite.c (autocmp_chars): Don't reset point. That is done by
8965 restore_point_unwind (Bug#5984).
8966
75bfc667
JL
89672011-08-07 Juri Linkov <juri@jurta.org>
8968
8969 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8970 to show the arg `TIME' instead of `TIMEVAL'.
8971
d1410150
EZ
89722011-08-06 Eli Zaretskii <eliz@gnu.org>
8973
8974 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8975 display property strides EOL and includes a newline, as in
8976 longlines-mode. (Bug#9254)
75b771e4
EZ
8977 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8978 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8979
8980 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8981 is non-zero, even if the data buffer is NULL. Fixes a crash in
8982 vertical-motion with longlines-mode. (Bug#9254)
8983
35928349
EZ
89842011-08-05 Eli Zaretskii <eliz@gnu.org>
8985
ec7cc85b
EZ
8986 * bidi.c <bidi_cache_total_alloc>: Now static.
8987 (bidi_initialize): Initialize bidi_cache_total_alloc.
8988
8b76d6f8 8989 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8990 cache. (Bug#9221)
8991
8992 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8993 amount allocated this far in `bidi_cache_total_alloc'.
8994 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8995 non-zero, only free the data buffer without restoring the cache
8996 contents. All callers changed.
8997
8998 * dispextern.h (bidi_unshelve_cache): Update prototype.
8999
9000 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9001 (move_it_in_display_line, move_it_to)
9002 (move_it_vertically_backward, move_it_by_lines): Replace the call
9003 to xfree to an equivalent call to bidi_unshelve_cache.
9004 (move_it_in_display_line_to): Fix logic of returning
412b6358 9005 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9006
e2e2423b
EZ
90072011-08-05 Eli Zaretskii <eliz@gnu.org>
9008
9009 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9010 came from a string character with a `cursor' property. (Bug#9229)
9011
ae9e757a
JD
90122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9013
9014 * Makefile.in (LIB_PTHREAD): New variable.
9015 (LIBES): Add LIB_PTHREAD (Bug#9216).
9016
9017 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9018 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9019
213bd7f2
AS
90202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9021
6b02f655 9022 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9023
99aaf75f
JD
90242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9025
9026 * xterm.c (x_find_topmost_parent): New function.
9027 (x_set_frame_alpha): Find topmost parent window with
9028 x_find_topmost_parent and set the property there also (bug#9181).
9029 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9030
c74e9d86
PE
90312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9032
9033 * callproc.c (Fcall_process): Avoid vfork clobbering
9034 the local vars buffer, coding_systems, current_dir.
9035
640c8776
SM
90362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9037
9038 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9039
f26d0e4c
PE
90402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9041
8a10d76c
PE
9042 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9043 so that it is not optimized away.
9044
f26d0e4c
PE
9045 * xdisp.c (compute_display_string_pos): Remove unused local.
9046
55439c61
EZ
90472011-08-02 Eli Zaretskii <eliz@gnu.org>
9048
9049 Fix slow cursor motion and scrolling in large buffers with
9050 selective display, like Org Mode buffers. (Bug#9218)
9051
9052 * dispextern.h (struct bidi_it): New member disp_prop_p.
9053
9054 * xdisp.c: Remove one-slot cache of display string positions.
9055 (compute_display_string_pos): Accept an additional argument
5e617bc2 9056 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9057 for a display string or property. If found, set DISP_PROP_P
9058 non-zero.
9059
9060 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9061 DISP_PROP_P, and pass it to compute_display_string_pos.
9062 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9063 non-zero. All callers of bidi_fetch_char changed.
9064
fb33fa43
SM
90652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9066
9067 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9068
b099e063
DM
90692010-12-03 Don March <don@ohspite.net>
9070
9071 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9072 last character M-[char] is translated to ESC [char] (bug#7541).
9073
5cc7f7af
KH
90742011-08-02 Kenichi Handa <handa@m17n.org>
9075
d0fffa3f 9076 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9077
9078 * chartab.c (uniprop_table): Make it non-static.
9079
525d5e6e
EZ
90802011-08-01 Eli Zaretskii <eliz@gnu.org>
9081
9082 * xdisp.c (forward_to_next_line_start): Accept additional argument
9083 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9084 on the newline.
9085 (reseat_at_next_visible_line_start): Use the bidi iterator state
9086 returned by forward_to_next_line_start to restore the state of
9087 it->bidi_it after backing up to previous newline. (Bug#9212)
9088
31011111
AS
90892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9090
9091 * regex.c (re_comp): Protoize.
9092 (re_exec): Fix return type.
9093 (regexec): Fix type of `ret'. (Bug#9203)
9094
476371c4
PE
90952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9096
e5d76069
PE
9097 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9098 This is needed if max-image-size is a floating-point number.
9099
9a79b20c
AS
91002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9101
9102 * print.c (print_object): Print empty symbol as ##.
9103
9104 * lread.c (read1): Read ## as empty symbol.
9105
d8c2fa78
AA
91062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9107
9108 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9109 setting frame foreground color (Bug#9175).
9110 (x_set_background_color): Likewise.
9111
ffe57a7a
AA
9112 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9113 contents (Bug#9176).
9114 (EmacsTooltip -init): Remove bezels and add shadows to
9115 tooltip windows.
9116
bf3492a5
AA
9117 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9118 or scroll bar (Bug#8470).
9119
d55e9c53
AA
9120 * nsfont.m (nsfont_open): Remove assignment to voffset and
9121 unnecessary vars hshink, expand, hd, full_height, min_height.
9122 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9123
9124 * nsterm.h (nsfont_info): Remove voffset field.
9125
d8c2fa78 91262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9127
9128 Implement strike-through and overline on NextStep (Bug#8863).
9129
9130 * nsfont.m (nsfont_open): Use underline position provided by font,
9131 instead of hard-coded value of 2.
9132 (nsfont_draw): Call ns_draw_text_decoration instead.
9133
9134 * nsterm.h: Add declaration for ns_draw_text_decoration.
9135
9136 * nsterm.m (ns_draw_text_decoration): New function for drawing
9137 underline, overline, and strike-through.
9138 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9139 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9140 accommodate underlining, etc.
4843aac3 9141
4cc60b9b
EZ
91422011-07-28 Eli Zaretskii <eliz@gnu.org>
9143
bc7ece87
EZ
9144 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9145 default.
4cc60b9b 9146
476371c4
PE
91472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9148
66606eea
PE
9149 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9150 Without this fix, if a signal arrives just after memory fills up,
9151 'malloc' might be invoked reentrantly.
9152
476371c4
PE
9153 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9154 In other words, assume that every image size is allowed, on non-X
9155 hosts. This assumption is probably wrong, but it lets Emacs compile.
9156
f3fcc40d
AS
91572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9158
9159 * regex.c (re_iswctype): Convert return values to boolean.
9160
350c992f
EZ
91612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9162
9163 * xdisp.c (compute_display_string_pos): Don't use cached display
9164 string position if the buffer had its restriction changed.
9165 (Bug#9184)
9166
5266b4bb
PE
91672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9168
9169 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9170
2573a837 91712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9172
41f55ccd 9173 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9174
39e378da
PE
9175 * bidi.c: Integer size and overflow fixes.
9176 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9177 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9178 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9179 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9180 (bidi_find_other_level_edge):
9181 Use ptrdiff_t instead of EMACS_INT where either will do.
9182 This works better on 32-bit hosts configured --with-wide-int.
9183 (bidi_cache_ensure_space): Check for size-calculation overflow.
9184 Use % rather than repeated addition, for better worst-case speed.
9185 Don't set bidi_cache_size until after xrealloc returns, because it
9186 might not return.
9187 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9188 (bidi_cache_ensure_space): Also check that the bidi cache size
9189 does not exceed that of the largest Lisp string or buffer. See Eli
9190 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9191
5e927815
PE
9192 * alloc.c (__malloc_size_t): Remove.
9193 All uses replaced by size_t. See Andreas Schwab's note
9194 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9195
ca4aa935
PE
9196 * image.c: Improve checking for integer overflow.
9197 (check_image_size): Assume that f is nonnull, since
9198 it is always nonnull in practice. This is one less thing to
9199 worry about when checking for integer overflow later.
9200 (x_check_image_size): New function, which checks for integer
9201 overflow issues inside X.
9202 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9203 This removes the need for a memory_full check.
9204 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9205 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9206 (xbm_read_bitmap_data): Change locals back to 'int', since
9207 their values must fit in 'int'.
9208 (xpm_load_image, png_load, tiff_load):
9209 Invoke x_create_x_image_and_pixmap earlier,
9210 to avoid much needless work if the image is too large.
9211 (tiff_load): Treat overly large images as if
9212 x_create_x_image_and_pixmap failed, not as malloc failures.
9213 (gs_load): Use x_check_image_size.
9214
5f8f9cc2
PE
9215 * gtkutil.c: Omit integer casts.
9216 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9217 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9218
5adf60bc
PE
9219 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9220
c8907a93
PE
9221 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9222 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9223 would wrongly return t on a 64-bit host.
9224
e3c25c68
PE
9225 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9226 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9227 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9228 and therefore cause GCC to emit a bogus diagnostic in some cases.
9229
3f791afe
PE
9230 * image.c: Integer signedness and overflow and related fixes.
9231 This is not an exhaustive set of fixes, but it's time to
9232 record what I've got.
9233 (lookup_pixel_color, check_image_size): Remove redundant decls.
9234 (check_image_size): Don't assume that arbitrary EMACS_INT values
9235 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9236 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9237 (tiff_load, imagemagick_load_image):
9238 Check for overflow in size calculations.
9239 (x_create_x_image_and_pixmap): Remove unnecessary test for
9240 xmalloc returning NULL; that can't happen.
9241 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9242 (xpm_color_bucket): Use better integer hashing function.
9243 (xpm_cache_color): Don't possibly over-allocate memory.
9244 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9245 (gif_memory_source):
9246 Use ptrdiff_t, not int or size_t, to record sizes.
9247 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9248 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9249 either works, as we prefer signed integers.
9250 (tiff_read_from_memory, tiff_write_from_memory):
9251 Return tsize_t, not size_t, since that's what the TIFF API wants.
9252 (tiff_read_from_memory): Don't fail simply because the read would
9253 go past EOF; instead, return a short read.
9254 (tiff_load): Omit no-longer-needed casts.
9255 (Fimagemagick_types): Don't assume size fits into 'int'.
9256
3cc5a532
PE
9257 Improve hashing quality when configured --with-wide-int.
9258 * fns.c (hash_string): New function, taken from sxhash_string.
9259 Do not discard information about ASCII character case; this
9260 discarding is no longer needed.
9261 (sxhash-string): Use it. Change sig to match it. Caller changed.
9262 * lisp.h: Declare it.
9263 * lread.c (hash_string): Remove, since we now use fns.c's version.
9264 The fns.c version returns a wider integer if --with-wide-int is
9265 specified, so this should help the quality of the hashing a bit.
9266
b312a492
PE
9267 * emacs.c: Integer overflow minor fix.
9268 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9269 Define only if GNU_LINUX.
9270 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9271
dfd153ae
PE
9272 * dispnew.c: Integer signedness and overflow fixes.
9273 Remove unnecessary forward decls, that were a maintenance hassle.
9274 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9275 All uses changed.
9276 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9277 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9278 (prepare_desired_row, line_draw_cost):
9279 Use int, not unsigned, where either works.
9280 (save_current_matrix, restore_current_matrix):
9281 Use ptrdiff_t, not size_t, where either works.
9282 (init_display): Check for overflow more accurately, and without
9283 relying on undefined behavior.
9284
a81d11a3
PE
9285 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9286 Remove, replacing with the new symbols in lisp.h. All uses changed.
9287 * fileio.c (make_temp_name):
9288 * filelock.c (lock_file_1, lock_file):
9289 * xdisp.c (message_dolog):
9290 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9291 Use pMd etc. instead.
9292 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9293 replacing the pWIDE etc. symbols removed from editfns.c.
9294
3300e6fd
PE
9295 * keyboard.h (num_input_events): Now uintmax_t.
9296 This is (very slightly) less likely to mess up due to wraparound.
9297 All uses changed.
9298
fd05c7e9
PE
9299 * buffer.c: Integer signedness fixes.
9300 (alloc_buffer_text, enlarge_buffer_text):
9301 Use ptrdiff_t rather than size_t when either will do, as we prefer
9302 signed integers.
9303
903fe15d
PE
9304 * alloc.c: Integer signedness and overflow fixes.
9305 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9306 (__malloc_size_t): Default to size_t, not to int.
9307 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9308 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9309 Prefer ptrdiff_t to size_t when either would do, as we prefer
9310 signed integers.
9311 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9312 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9313 Now const. Initialize with values that are in range even if char
9314 is signed.
9315 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9316 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9317 These functions do the right thing with sizes > 2**32.
9318 (check_depth): Now ptrdiff_t, not int.
9319 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9320 Adjust to new way of storing sizes. Check for size overflow bugs
9321 in rest of code.
9322 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9323 slightly wrong anyway, as it missed one instance of
9324 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9325 (refill_memory_reserve): Omit needless cast to size_t.
9326 (mark_object_loop_halt): Mark as externally visible.
9327
ac82cc6a
PE
9328 * xselect.c: Integer signedness and overflow fixes.
9329 (Fx_register_dnd_atom, x_handle_dnd_message):
9330 Use ptrdiff_t, not size_t, since we prefer signed.
9331 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9332 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9333 x_dnd_atoms_size and x_dnd_atoms_length.
9334
c2d1e36d
PE
9335 * doprnt.c: Prefer signed to unsigned when either works.
9336 * eval.c (verror):
9337 * doprnt.c (doprnt):
9338 * lisp.h (doprnt):
9339 * xdisp.c (vmessage):
9340 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9341 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9342 prefer signed arithmetic to avoid comparison confusion.
9343 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9344 but is a bit tricky.
9345
0e926e56
PE
9346 Assume freestanding C89 headers, string.h, stdlib.h.
9347 * data.c, doprnt.c, floatfns.c, print.c:
9348 Include float.h unconditionally.
9349 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9350 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9351 * regex.c: Likewise for stddef.h, string.h.
9352 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9353 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9354 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9355 (STDC_HEADERS): Remove obsolete defines.
9356 * sysdep.c: Include limits.h unconditionally.
9357
9cfdb3ec
PE
9358 Assume support for memcmp, memcpy, memmove, memset.
9359 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9360 * regex.c (memcmp, memcpy):
9361 Remove; we assume C89 now.
9362
9363 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9364 (__malloc_safe_bcopy): Remove; no longer needed.
9365
cf950e6b 9366 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9367 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9368 well either way, and we prefer signed to unsigned.
9369
dbf38e02
LMI
93702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9371
9372 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9373 closes the connection while we're reading (bug#9182).
9374
d6f0886c 93752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9376
d6f0886c
JD
9377 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9378 are specified (Bug#9168).
24e0f6b1 9379
2eb1f9e6
PE
93802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9381
9382 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9383 Found by GCC static checking and --with-wide-int on a 32-bit host.
9384
22381272 93852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9386
9387 * xdisp.c (compute_display_string_pos): Fix logic of caching
9388 previous display string position. Initialize cached_prev_pos to
9389 -1. Fixes slow-down at the beginning of a buffer.
9390
f25e39b4
EZ
93912011-07-24 Eli Zaretskii <eliz@gnu.org>
9392
9393 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9394 for attrs[LFACE_FONTSET_INDEX].
9395
04c4b52e
PE
93962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9397
9398 * xml.c (parse_region): Remove unused local
9399 that was recently introduced.
9400
c1734fbd
EZ
94012011-07-23 Eli Zaretskii <eliz@gnu.org>
9402
be18c5a5
EZ
9403 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9404 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9405
c1734fbd
EZ
9406 * xdisp.c (move_it_in_display_line_to): Record the best matching
9407 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9408 exit if none of the characters scanned was an exact match.
9409 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9410 when exact match is impossible due to invisible text, and the
9411 lines are truncated.
9412
a258d627
JD
94132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9414
9415 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9416 for OSX >= 10.7.
9417
b6d5a689
EZ
94182011-07-22 Eli Zaretskii <eliz@gnu.org>
9419
0f74f785
EZ
9420 Fix a significant slow-down of cursor motion with C-n, C-p,
9421 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9422 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9423 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9424 (next_element_from_buffer): Call compute_stop_pos_backwards to
9425 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9426 base_level_stop.
9427 (reseat): Don't look for prev_stop, as that could mean a very long
9428 run.
9429 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9430 <cached_disp_overlay_modiff>: Cache for last found display string
9431 position.
551918c1 9432 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9433 about the same buffer in the same area of character positions, and
9434 the buffer wasn't changed since the time the display string
9435 position was cached.
551918c1 9436
b2d0c91a
EZ
94372011-07-22 Eli Zaretskii <eliz@gnu.org>
9438
9439 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9440 is an integer, which is important for empty lines. (Bug#9149)
9441
043604ee
CY
94422011-07-22 Chong Yidong <cyd@stupidchicken.com>
9443
9444 * frame.c (Fmodify_frame_parameters): In tty case, update the
9445 default face if necessary (Bug#4238).
9446
da4adb04
CY
94472011-07-21 Chong Yidong <cyd@stupidchicken.com>
9448
9449 * editfns.c (Fstring_to_char): No need to explain what a character
9450 is in the docstring (Bug#6576).
9451
9abd0532
LMI
94522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9453
9454 * xml.c (parse_region): Make sure we always return a tree.
9455
36881d16
HK
94562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9457
9458 * xml.c (parse_region): If a document contains only comments,
9459 return that, too.
9460
1e98674d
LMI
94612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9462
9463 * xml.c (make_dom): Return comments, too.
9464
590bd467
PE
94652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9466
9467 Port to OpenBSD.
9468 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9469 and the surrounding thread.
9470 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9471 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9472 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9473 timer goes off.
9474 * s/openbsd.h (BROKEN_SIGIO): Define.
9475 * unexelf.c (unexec) [__OpenBSD__]:
9476 Don't update the .mdebug section of the Alpha COFF symbol table.
9477
f41628b2
LMI
94782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9479
9480 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9481 (bug#8460).
9482
b59b67c5
PE
94832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9484
15e3a074
PE
9485 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9486 This fixes some race conditions on the permissions of any newly
9487 created file.
9488
41bed37d
PE
9489 * alloc.c (valid_pointer_p): Use pipe, not open.
9490 This fixes some permissions issues when debugging.
9491
b59b67c5
PE
9492 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9493 If fchown fails to set both uid and gid, try to set just gid,
9494 as that is sometimes allowed. Adjust the file's mode to eliminate
9495 setuid or setgid bits that are inappropriate if fchown fails.
9496
925a6be7
SM
94972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9498
9499 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9500 to compare Lisp_Objects.
9501 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9502 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9503 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9504
52968808
AS
95052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9506
0a6a104b
AS
9507 * lread.c (read_integer): Unread even EOF character.
9508 (read1): Likewise. Properly record start position of symbol.
9509
52968808
AS
9510 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9511 symbol character follows.
9512
9e381cdd
PE
95132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9514
9515 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9516 This works around a problem with the previous change to Fcopy_file.
9517 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9518 and without this change, GCC might complain about discarding
9519 fchown's return value.
9520
b5641435
JB
95212011-07-16 Juanma Barranquero <lekktu@gmail.com>
9522
9523 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9524
a8031457
PE
95252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9526
9527 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9528
dd889327
LMI
95292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9530
750c33f7
LMI
9531 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9532 it's used from the C level.
9533
dd889327
LMI
9534 * process.c: Use the same condition for POLL_FOR_INPUT in both
9535 keyboard.c and process.c (bug#1858).
9536
87e86684
LM
95372011-07-09 Lawrence Mitchell <wence@gmx.li>
9538
9539 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9540 (Fgnutls_boot): Use it.
9541
64348f40
AS
95422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9543
9544 * doc.c (Fsubstitute_command_keys): Revert last change.
9545
1d698799
LMI
95462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9547
f863868c
LMI
9548 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9549 quotes the next character, and doesn't affect other longer
9550 sequences (bug#8935).
9551
1d698799
LMI
9552 * lread.c (syms_of_lread): Clarify that is isn't only
9553 `eval-buffer' and `eval-defun' that's affected by
9554 `lexical-binding' (bug#8460).
9555
aa4b6df6
EZ
95562011-07-15 Eli Zaretskii <eliz@gnu.org>
9557
9558 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9559 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9560
5d856da6
PE
95612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9562
ad6042bb
PE
9563 Fix minor problems found by static checking.
9564 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9565 (elsz): Now a signed constant, not a size_t var. We prefer signed
9566 types to unsigned, to avoid integer comparison confusion. Without
9567 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9568 "cannot optimize loop, the loop counter may overflow", a symptom
9569 of the confusion.
f00bbb22 9570 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9571 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9572
6468f31c
LMI
95732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9574
49080b10
LMI
9575 * search.c (Fre_search_backward): Mention `case-fold-search' in
9576 all the re_search_* functions (bug#8138).
9577
6468f31c
LMI
9578 * keyboard.c (Fopen_dribble_file): Document when the file is
9579 closed (bug#8056).
9580
c965adc5
EZ
95812011-07-14 Eli Zaretskii <eliz@gnu.org>
9582
df9733bf
EZ
9583 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9584 bidi_cache_idx.
9585
0bb23927
EZ
9586 Support bidi reordering of display and overlay strings.
9587 * xdisp.c (compute_display_string_pos)
9588 (compute_display_string_end): Accept additional argument STRING.
9589 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9590 (reseat_to_string): Initialize bidi_it->string.s and
9591 bidi_it->string.schars.
9592 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9593 NULL (avoids a crash in bidi_paragraph_init).
9594 Initialize itb.string.lstring.
0bb23927
EZ
9595 (init_iterator): Call bidi_init_it only of a valid
9596 buffer position was specified. Initialize paragraph_embedding to
9597 L2R.
9598 (reseat_to_string): Initialize the bidi iterator.
9599 (display_string): If we need to ignore text properties of
9600 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9601 original value of -1 will not work with bidi.)
9602 (compute_display_string_pos): First arg is now struct
9603 `text_pos *'; all callers changed. Support display properties on
9604 Lisp strings.
9605 (compute_display_string_end): Support display properties on Lisp
9606 strings.
9607 (init_iterator, reseat_1, reseat_to_string): Initialize the
9608 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9609 when iterating on a string not from display properties).
640c8776
SM
9610 (compute_display_string_pos, compute_display_string_end):
9611 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9612 arrow keys.
9613 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9614 base_level_stop; instead, set base_level_stop to BEGV.
9615 Fixes crashes in vertical-motion.
0bb23927
EZ
9616 (next_element_from_buffer): Improve commentary for when
9617 the iterator is before prev_stop.
9618 (init_iterator): Initialize bidi_p from the default value of
9619 bidi-display-reordering, not from buffer-local value. Use the
9620 buffer-local value only if initializing for buffer iteration.
9621 (handle_invisible_prop): Support invisible properties on strings
9622 that are being bidi-reordered.
9623 (set_iterator_to_next): Support bidi reordering of C strings and
9624 Lisp strings.
9625 (next_element_from_string): Support bidi reordering of Lisp
9626 strings.
9627 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9628 (display_string): Support display of R2L glyph rows.
9629 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9630 (init_iterator): Don't initialize it->bidi_p for strings
9631 here.
9632 (reseat_to_string): Initialize it->bidi_p for strings here.
9633 (next_element_from_string, next_element_from_c_string)
9634 (next_element_from_buffer): Add xassert's for correspondence
9635 between IT's object being iterated and it->bidi_it.string
9636 structure.
9637 (face_before_or_after_it_pos): Support bidi iteration.
9638 (next_element_from_c_string): Handle the case of the first string
9639 character that is not the first one in the visual order.
9640 (get_visually_first_element): New function, refactored from common
9641 parts of next_element_from_buffer, next_element_from_string, and
9642 next_element_from_c_string.
9643 (tool_bar_lines_needed, redisplay_tool_bar)
9644 (display_menu_bar): Force left-to-right direction. Add a FIXME
9645 comment for making that be controlled by a user option.
9646 (push_it, pop_it): Save and restore the state of the
9647 bidi iterator. Save and restore the bidi_p flag.
9648 (pop_it): Iterate out of display property for string iteration as
9649 well.
9650 (iterate_out_of_display_property): Support iteration over strings.
9651 (handle_single_display_spec): Set up it->bidi_it for iteration
9652 over a display string, and call bidi_init_it.
9653 (handle_single_display_spec, next_overlay_string)
9654 (get_overlay_strings_1, push_display_prop): Set up the bidi
9655 iterator for displaying display or overlay strings.
9656 (forward_to_next_line_start): Don't use the shortcut if
9657 bidi-iterating.
9658 (back_to_previous_visible_line_start): If handle_display_prop
9659 pushed the iterator stack, restore the internal state of the bidi
9660 iterator by calling bidi_pop_it same number of times.
9661 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9662 and we are bidi-iterating, don't decrement the iterator position;
9663 instead, set the first_elt flag in the bidi iterator, to produce
9664 the same effect.
9665 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9666 (push_display_prop): xassert that we are iterating a buffer.
9667 (push_it, pop_it): Save and restore paragraph_embedding member.
9668 (handle_single_display_spec, next_overlay_string)
9669 (get_overlay_strings_1, reseat_1, reseat_to_string)
9670 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9671 correctly. Don't assume unibyte strings are not bidi-reordered.
9672 (compute_display_string_pos)
9673 (compute_display_string_end): Fix handling the case of C string.
9674 (push_it, pop_it): Save and restore from_disp_prop_p.
9675 (handle_single_display_spec, push_display_prop): Set the
9676 from_disp_prop_p flag.
9677 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9678 (pop_it): Call iterate_out_of_display_property only if we are
9679 popping after iteration over a string that came from a display
9680 property. Fix a typo in popping stretch info. Add an assertion
9681 for verifying that the iterator position is in sync with the bidi
9682 iterator.
9683 (handle_single_display_spec, get_overlay_strings_1)
9684 (push_display_prop): Fix initialization of paragraph direction for
9685 string when that of the parent object is not yet determined.
9686 (reseat_1): Call bidi_init_it to resync the bidi
9687 iterator with IT's position. (Bug#7616)
9688 (find_row_edges): If ROW->start.pos gives position
9689 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9690 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9691 Reset the from_disp_prop_p flag.
9692 (SAVE_IT, RESTORE_IT): New macros.
9693 (pos_visible_p, face_before_or_after_it_pos)
9694 (back_to_previous_visible_line_start)
9695 (move_it_in_display_line_to, move_it_in_display_line)
9696 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9697 (try_scrolling, redisplay_window, display_line): Use them when
9698 saving a temporary copy of the iterator and restoring it back.
9699 (back_to_previous_visible_line_start, reseat_1)
9700 (init_iterator): Empty the bidi cache "stack".
9701 (move_it_in_display_line_to): If iterator ended up at
9702 EOL, but we never saw any buffer positions smaller than
9703 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9704 motion in bidi-reordered lines.
9705 (move_it_in_display_line_to): Record prev_method and prev_pos
9706 immediately before the call to set_iterator_to_next. Fixes cursor
9707 motion in bidi-reordered lines with stretch glyphs and strings
9708 displayed in margins. (Bug#8133) (Bug#8867)
9709 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9710 TO_CHARPOS.
640c8776
SM
9711 (pos_visible_p): Support positions in bidi-reordered lines.
9712 Save and restore bidi cache.
0bb23927
EZ
9713
9714 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9715 (bidi_paragraph_info): Delete unused struct.
9716 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9717 (bidi_cache_start): New variable.
9718 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9719 to zero.
9720 (bidi_cache_fetch_state, bidi_cache_search)
9721 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9722 (bidi_cache_find, bidi_peek_at_next_level)
9723 (bidi_level_of_next_char, bidi_find_other_level_edge)
9724 (bidi_move_to_visually_next): Compare cache index with
9725 bidi_cache_start rather than with zero.
9726 (bidi_fetch_char): Accept new argument STRING; all callers
9727 changed. Support iteration over a string. Support strings with
9728 display properties. Support unibyte strings. Fix the type of
9729 `len' according to what STRING_CHAR_AND_LENGTH expects.
9730 (bidi_paragraph_init, bidi_resolve_explicit_1)
9731 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9732 (bidi_level_of_next_char, bidi_move_to_visually_next):
9733 Support iteration over a string.
0bb23927
EZ
9734 (bidi_set_sor_type, bidi_resolve_explicit_1)
9735 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9736 can now be zero (for strings); special values 0 and -1 were
9737 changed to -1 and -2, respectively.
9738 (bidi_char_at_pos): New function.
9739 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9740 Call it instead of FETCH_MULTIBYTE_CHAR.
9741 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9742 initialized to valid values.
9743 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9744 values.
9745 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9746 the test for valid cached positions. Fix the logic for looking up
9747 the sentinel state in the cache. GCPRO the Lisp string we are
9748 iterating.
9749 (bidi_push_it, bidi_pop_it): New functions.
9750 (bidi_initialize): Initialize the bidi cache start stack pointer.
9751 (bidi_cache_ensure_space): New function, refactored from part of
9752 bidi_cache_iterator_state. Don't assume the required size is just
9753 one BIDI_CACHE_CHUNK away.
9754 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9755 (bidi_count_bytes, bidi_char_at_pos): New functions.
9756 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9757 always valid if bidi_cache_idx is valid.
9758 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9759 is valid if it's going to be used.
9760 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9761 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9762 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9763 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9764 (bidi_find_other_level_edge, bidi_cache_start_stack):
9765 All variables related to cache indices are now EMACS_INT.
c965adc5 9766
0bb23927
EZ
9767 * dispextern.h (struct bidi_string_data): New structure.
9768 (struct bidi_it): New member `string'. Make flag members be 1-bit
9769 fields, and put them last in the struct.
640c8776
SM
9770 (compute_display_string_pos, compute_display_string_end):
9771 Update prototypes.
0bb23927
EZ
9772 (bidi_push_it, bidi_pop_it): Add prototypes.
9773 (struct iterator_stack_entry): New members bidi_p,
9774 paragraph_embedding, and from_disp_prop_p.
9775 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9776 (bidi_shelve_cache, bidi_unshelve_cache):
9777 Declare prototypes.
0bb23927
EZ
9778
9779 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9780 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9781 and vector-like objects.
9782
9783 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9784 cache around display iteration.
9785
9786 * window.c (Fwindow_end, window_scroll_pixel_based)
9787 (displayed_window_lines, Frecenter): Save and restore the bidi
9788 cache around display iteration.
9789
3bbd2265
LMI
97902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9791
9792 * editfns.c (Fdelete_region): Clarify the use of the named
9793 parameters (bug#6788).
9794
adc47434
MR
97952011-07-14 Martin Rudalics <rudalics@gmx.at>
9796
9797 * indent.c (Fvertical_motion): Set and restore w->pointm when
9798 saving and restoring the window's buffer (Bug#9006).
9799
837c31f8
LMI
98002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9801
9802 * editfns.c (Fstring_to_char): Clarify just what is returned
9803 (bug#6576). Text by Eli Zaretskii.
9804
ac389d0c
JB
98052011-07-13 Juanma Barranquero <lekktu@gmail.com>
9806
9807 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9808
0be0ce47
EZ
98092011-07-13 Eli Zaretskii <eliz@gnu.org>
9810
9811 * buffer.c (mmap_find): Fix a typo.
9812
cd18e7e3
JB
98132011-07-13 Johan Bockgård <bojohan@gnu.org>
9814
9815 Fix execution of x selection hooks.
9816 * xselect.c (Qx_lost_selection_functions)
9817 (Qx_sent_selection_functions): New vars.
9818 (syms_of_xselect): DEFSYM them.
9819 (x_handle_selection_request): Pass Qx_sent_selection_functions
9820 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9821 (x_handle_selection_clear,x_clear_frame_selections):
9822 Pass Qx_lost_selection_functions rather than
9823 Vx_lost_selection_functions to Frun_hook_with_args.
9824
47ea7f44
PE
98252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9826
ac389d0c 9827 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9828 The old code sometimes used this field without initializing it.
9829
47ea7f44
PE
9830 * alloc.c (gc_sweep): Don't read past end of array.
9831 In theory, the old code could also have corrupted Emacs internals,
9832 though it'd be very unlikely.
9833
bc985c87
AS
98342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9835
9836 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9837 argument. (Bug#4026)
bc985c87 9838
0cf34688
LMI
98392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9840
b3dadd76
LMI
9841 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9842 key" (bug#4257).
9843
0cf34688
LMI
9844 * window.c (Fset_window_start): Doc fix (bug#4199).
9845 (Fset_window_hscroll): Ditto.
9846
270768cd
PE
98472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9848
077e3dda 9849 Fix minor new problems caught by GCC 4.6.1.
270768cd 9850 * term.c (init_tty): Remove unused local.
490011a6 9851 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9852 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9853 not used otherwise.
270768cd 9854
b1f58454
CY
98552011-07-12 Chong Yidong <cyd@stupidchicken.com>
9856
9857 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9858
22b9578d
LMI
98592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9860
6e70ab07
LMI
9861 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9862 are the mini-buffer and the echo area (bug#3320).
9863
22b9578d
LMI
9864 * term.c (init_tty): Remove support for supdup, c10 and perq
9865 terminals, which are no longer supported (bug#1482).
9866
8974cc9f
JB
98672011-07-10 Johan Bockgård <bojohan@gnu.org>
9868
9869 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9870
a560d974
JD
98712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9872
9873 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9874 for non-popups (Bug#3642).
9875
1dae0f0a
AS
98762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9877
268c2c36 9878 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9879 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9880 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9881 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9882 * data.c (fmod): Likewise.
9883 * dispnew.c (swap_glyphs_in_rows): Likewise.
9884 * emacs.c (memory_warning_signal): Likewise.
9885 * floatfns.c (float_error): Likewise.
9886 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9887 (otf_open, font_otf_capability, generate_otf_features)
9888 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9889 Likewise.
9890 * image.c (pbm_read_file): Likewise.
9891 * indent.c (string_display_width): Likewise.
9892 * intervals.c (check_for_interval, search_for_interval)
9893 (inc_interval_count, count_intervals, root_interval)
9894 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9895 * lread.c (defalias): Likewise.
268c2c36 9896 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9897 * regex.c (set_image_of_range_1, set_image_of_range)
9898 (regex_grow_registers): Likewise.
9899 * sysdep.c (strerror): Likewise.
9900 * termcap.c (valid_filename_p, tprint, main): Likewise.
9901 * tparam.c (main): Likewise.
9902 * unexhp9k800.c (run_time_remap, save_data_space)
9903 (update_file_ptrs, read_header, write_header, calculate_checksum)
9904 (copy_file, copy_rest, display_header): Likewise.
9905 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9906 Likewise.
9907 * xdisp.c (check_it): Likewise.
9908 * xfaces.c (register_color, unregister_color, unregister_colors):
9909 Likewise.
9910 * xfns.c (print_fontset_result): Likewise.
9911 * xrdb.c (member, fatal, main): Likewise.
9912
99033785
PE
99132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9914
9915 Fix minor problems found by static checking (Bug#9031).
9916 * chartab.c (char_table_set_range, map_sub_char_table):
9917 Remove unused locals.
9918 (uniprop_table): Now static.
9919 * composite.c (_work_char): Remove unused static var.
9920
9cb2ac56
JB
99212011-07-09 Juanma Barranquero <lekktu@gmail.com>
9922
9923 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9924
f25661f0
JD
99252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9926
9927 * gtkutil.c (qttip_cb): Remove code without function.
9928
8278c4fe
EZ
99292011-07-09 Eli Zaretskii <eliz@gnu.org>
9930
9931 * w32.c (pthread_sigmask): New stub.
9932
1692ae2d 99332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9934
8a6ebd58 9935 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9936 sigprocmask is portable only for single-threaded applications, and
9937 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9938 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9939 (LIBES): Use it.
9940 * callproc.c (Fcall_process):
9941 * process.c (create_process):
9942 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9943 Use pthread_sigmask, not sigprocmask.
123403e4 9944
1b854618
JD
99452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9946
9947 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9948 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9949 wrong (Bug#8591).
9950
3fe4b549
JD
99512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9952
0ce7e563
JD
9953 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9954 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9955 (xg_hide_tooltip): Fix comment.
9956
3fe4b549
JD
9957 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9958 in registerServicesMenuSendTypes.
9959 (validRequestorForSendType): Don't check ns_return_types.
9960
9961 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9962 ns_return_type.
9963
5df75e47
JR
99642011-07-08 Jason Rumney <jasonr@gnu.org>
9965
22610910
JR
9966 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9967 SH_SHOW for hidden windows (Bug#5482).
9968
5df75e47
JR
9969 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9970 frame struct members of non-existent frames (Bug#6284).
9971
699c10bd
JD
99722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9973
4393663b
JD
9974 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9975 variable firstTime not needed on OSX >= 10.6.
9976 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9977 >= 10.5. Use setKnobProportion, setDoubleValue.
9978
9979 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9980 (MAC_OS_X_VERSION_10_5): Define if not defined.
9981 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9982 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9983 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9984
9985 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9986 cString and lossyCString on OSX >= 10.4.
4393663b 9987
58179cce 9988 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9989 sizeToFit on OSX >= 10.2.
9990
9991 * nsimage.m (allocInitFromFile): Don't use deprecated method
9992 bestRepresentationForDevice on OSX >= 10.6.
9993
9994 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9995 to avoid warning.
9996
9997 * emacs.c: Declare unexec_init_emacs_zone.
9998
a63e0781
JD
9999 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10000
699c10bd
JD
10001 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10002
10003 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10004 on svcsMenu (Bug#8842).
10005
10006 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10007 ns_return_types.
10008 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10009
10010 * nsterm.m (QUTF8_STRING): Declare.
10011 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10012 (validRequestorForSendType): Return type is (id).
10013 Change indexOfObjectIdenticalTo to indexOfObject.
10014 Check if we have local selection before returning self (Bug#8842).
10015 (writeSelectionToPasteboard): Put local selection into paste board
10016 if we have a local selection (Bug#8842).
10017 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10018
10019 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10020 (ns_get_local_selection): Declare.
10021
54e10184
LMI
100222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10023
9888ff71
LMI
10024 * keymap.c (describe_map_tree): Don't insert a double newline at
10025 the end of the buffer (bug#1169) and return whether we inserted
10026 something.
10027
54e10184
LMI
10028 * callint.c (Fcall_interactively): Change "reading args" to
10029 "providing args" to try to clarify what it does (bug#1010).
10030
15fa4783
KH
100312011-07-07 Kenichi Handa <handa@m17n.org>
10032
10033 * composite.c (composition_compute_stop_pos): Ignore a static
10034 composition starting before CHARPOS (Bug#8915).
10035
10036 * xdisp.c (handle_composition_prop): Likewise.
10037
a8815b00
EZ
100382011-07-07 Eli Zaretskii <eliz@gnu.org>
10039
10040 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10041 (Bug#9015)
10042
ef7b981d 100432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10044
10045 * character.h (unicode_category_t): New enum type.
10046
10047 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10048 (Qchar_code_property_table): New variable.
10049 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10050 (UNIPROP_COMPRESSED_FORM_P): New macros.
10051 (char_table_ascii): Uncompress the compressed values.
10052 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10053 Uncompress the compressed values.
ac389d0c 10054 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10055 (char_table_ref_and_range): Uncompress the compressed values.
10056 (sub_char_table_set): New arg is_uniprop. Callers changed.
10057 Uncompress the compressed values.
10058 (sub_char_table_set_range): Args changed. Callers changed.
10059 (char_table_set_range): Adjuted for the above change.
10060 (map_sub_char_table): Delete args default_val and parent. Add arg
10061 top. Give decoded values to a Lisp function.
640c8776 10062 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10063 values to a Lisp function. Gcpro more variables.
10064 (uniprop_table_uncompress)
10065 (uniprop_decode_value_run_length): New functions.
10066 (uniprop_decoder, uniprop_decoder_count): New variables.
10067 (uniprop_get_decoder, uniprop_encode_value_character)
10068 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10069 New functions.
10070 (uniprop_encoder, uniprop_encoder_count): New variables.
10071 (uniprop_get_encoder, uniprop_table)
10072 (Funicode_property_table_internal, Fget_unicode_property_internal)
10073 (Fput_unicode_property_internal): New functions.
10074 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10075 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10076 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10077 char-code-property-alist.
10078
640c8776 10079 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10080 Vunicode_category_table.
10081
640c8776 10082 * font.c (font_range): Adjust for the change of
c805dec0
KH
10083 Vunicode_category_table.
10084
76b397fb
DN
100852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10086
10087 * m/iris4d.h: Remove file, move contents ...
10088 * s/irix6-5.h: ... here.
10089
22b4128e
PE
100902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10091
10092 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10093 * alloc.c (mark_buffer):
10094 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10095 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10096 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10097 This isn't true in general, and it's particularly not true
10098 if Emacs is configured with --with-wide-int.
10099 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10100 New macros, used in the buffer.c change.
10101
869795d6
JD
101022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10103
10104 * xsettings.c: Use both GConf and GSettings if both are available.
10105 (store_config_changed_event): Add comment.
10106 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10107 (store_tool_bar_style_changed): New functions.
5e617bc2 10108 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10109 (struct xsettings): Move font inside HAVE_XFT.
10110 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10111 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10112 Move inside HAVE_XFT.
640c8776 10113 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10114 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10115 also.
10116 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10117 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10118 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10119 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10120 (parse_settings): Move check for font inside HAVE_XFT.
10121 (read_settings, apply_xft_settings): Add comment.
10122 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10123 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10124 call store_font_name_changed.
10125 (xft_settings_event): Add comment.
10126 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10127 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10128 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10129 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10130 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10131 (xsettings_get_system_font, xsettings_get_system_normal_font):
10132 Add comment.
869795d6 10133
d8ed26bd
PE
101342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10135
10136 Random fixes. E.g., (random) never returned negative values.
10137 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10138 subseconds part to the entropy, as that's a bit more random.
10139 Prefer signed to unsigned, since the signedness doesn't matter and
10140 in general we prefer signed. When given a limit, use a
10141 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10142 latter isn't right if USE_2_TAGS_FOR_INTS.
10143 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10144 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10145
cabf1cac
SM
101462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10147
10148 * textprop.c (text_property_stickiness):
10149 Obey Vtext_property_default_nonsticky.
10150 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10151 * w32fns.c (syms_of_w32fns):
10152 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10153
6e9b2be9
PE
101542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10155
10156 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10157 This is more efficient than Ffile_directory_p and avoids a minor race.
10158
90186c68
LMI
101592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10160
7c301272
LMI
10161 * buffer.c (Foverlay_put): Say what the return value is
10162 (bug#7835).
10163
c4f2d8d4
LMI
10164 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10165 is a directory before asking whether to use the file name
10166 (bug#7564).
ad637907
LMI
10167 (barf_or_query_if_file_exists): Make the "File is a directory"
10168 error be more correct.
c4f2d8d4 10169
90186c68
LMI
10170 * fns.c (Frequire): Remove the mention of the .gz files, since
10171 that's installation-specific, but keep the mention of
10172 `get-load-suffixes'.
10173
da64016e
PE
101742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10175
10176 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10177 Report string overflow if the output is too long.
10178
7d47b580
JB
101792011-07-04 Juanma Barranquero <lekktu@gmail.com>
10180
a555cb87
JB
10181 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10182 (syms_of_gnutls): Remove duplicate DEFSYM for
10183 Qgnutls_bootprop_verify_hostname_error, an error for
10184 Qgnutls_bootprop_verify_error (which is no longer used).
10185
7d47b580
JB
10186 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10187 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10188 Also (re)move comments that are misplaced or no longer relevant.
10189
1e49bfab
LMI
101902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10191
10192 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10193
1485f4c0
CY
101942011-07-03 Chong Yidong <cyd@stupidchicken.com>
10195
10196 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10197 and background color parameters if they have been changed.
10198
a9ab721e
LMI
101992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10200
10201 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10202
cf7cff57
PE
102032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10204
2e13213d
PE
10205 * xsettings.c (SYSTEM_FONT): Define only when used.
10206 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10207
cf7cff57
PE
10208 * keymap.c (access_keymap_1): Now static.
10209
7a8e04f7
CY
102102011-07-02 Chong Yidong <cyd@stupidchicken.com>
10211
10212 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10213 leave any prefix arg for the up event (Bug#1586).
10214
61352f62
LMI
102152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10216
69bb1ef7
LMI
10217 * lread.c (syms_of_lread): Mention single symbols defined by
10218 `defvar' or `defconst' (bug#7154).
10219
61352f62 10220 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10221 (Frequire): Mention get-load-suffixes.
61352f62 10222
28545e04
MR
102232011-07-02 Martin Rudalics <rudalics@gmx.at>
10224
10225 * window.h (window): Remove clone_number slot.
10226 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10227 Remove.
10228 (make_parent_window, make_window, saved_window)
10229 (Fset_window_configuration, save_window_save): Don't deal with
10230 clone numbers.
10231 * buffer.c (Qclone_number): Remove declaration.
10232 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10233
3349e122
SM
102342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10235
10236 Add multiple inheritance to keymaps.
10237 * keymap.c (Fmake_composed_keymap): New function.
10238 (Fset_keymap_parent): Simplify.
10239 (fix_submap_inheritance): Remove.
10240 (access_keymap_1): New function extracted from access_keymap to handle
10241 embedded parents and handle lists of maps.
10242 (access_keymap): Use it.
10243 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10244 (Fcopy_keymap): Handle embedded parents.
10245 (Fcommand_remapping, define_as_prefix): Simplify.
10246 (Fkey_binding): Simplify.
10247 (syms_of_keymap): Move minibuffer-local-completion-map,
10248 minibuffer-local-filename-completion-map,
10249 minibuffer-local-must-match-map, and
10250 minibuffer-local-filename-must-match-map to Elisp.
10251 (syms_of_keymap): Defsubr make-composed-keymap.
10252 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10253 (parse_menu_item): Trivial simplification.
10254
3279eb87
GM
102552011-07-01 Glenn Morris <rgm@gnu.org>
10256
10257 * Makefile.in (SETTINGS_LIBS): Fix typo.
10258
39cb9e56 102592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10260
10261 * coding.c (Fencode_coding_string): Record the last coding system
10262 used, as the function doc string says (bug#8738).
10263
0949d2b6
JD
102642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10265
10266 * xsettings.c (store_monospaced_changed): Take new font as arg and
10267 check for change against current_mono_font.
10268 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10269 (emacs_settings_constructor, emacs_settings_get_property)
10270 (emacs_settings_set_property, emacs_settings_class_init)
10271 (emacs_settings_init, gsettings_obj): Remove.
10272 (something_changedCB): New function for HAVE_GSETTINGS.
10273 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10274 with value as argument.
10275 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10276 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10277 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10278 "changed".
10279
10280 * xgselect.c: Add defined (HAVE_GSETTINGS).
10281 (xgselect_initialize): Ditto.
10282
10283 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10284 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10285 xg_select.
10286
bbc6b304
PE
102872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10288
10289 * eval.c (struct backtrace): Simplify and port the data structure.
10290 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10291 signed bit field, as this assumption is not portable and it makes
10292 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10293 "char debug_on_exit : 1" as this is not portable either; instead,
10294 use the portable "unsigned int debug_on_exit : 1". Remove unused
10295 member evalargs. Remove obsolete comments about cc bombing out.
10296
9851bfc5
JD
102972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10298
51bb811f 10299 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10300 Let HAVE_GSETTINGS override HAVE_GCONF.
10301 (store_monospaced_changed): New function.
10302 (EMACS_SETTINGS): A new type derived from GObject to handle
10303 GSettings notifications.
10304 (emacs_settings_constructor, emacs_settings_get_property)
10305 (emacs_settings_set_property, emacs_settings_class_init):
10306 New functions.
10307 (gsettings_client, gsettings_obj): New variables.
10308 (GSETTINGS_SCHEMA): New define.
10309 (something_changedCB): Call store_monospaced_changed.
10310 (init_gsettings): New function.
10311 (xsettings_initialize): Call init_gsettings.
10312 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10313 to NULL.
10314
640c8776 10315 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10316 GCONF_CFLAGS/LIBS.
10317
5386012d
MR
103182011-06-29 Martin Rudalics <rudalics@gmx.at>
10319
10320 * window.c (resize_root_window, grow_mini_window)
10321 (shrink_mini_window): Rename Qresize_root_window to
10322 Qwindow_resize_root_window and Qresize_root_window_vertically to
10323 Qwindow_resize_root_window_vertically.
10324
f13e0b08
PE
103252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10326
10327 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10328
94515237
JB
103292011-06-27 Juanma Barranquero <lekktu@gmail.com>
10330
10331 * makefile.w32-in: Redesign dependencies so they reflect more
10332 clearly which files are directly included by each source file,
10333 and not through other includes.
10334
e43b6e43
MR
103352011-06-27 Martin Rudalics <rudalics@gmx.at>
10336
10337 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10338 (sort_overlays, overlay_strings): When an overlay's clone number
10339 matches the window's clone number process the overlay even if
10340 the overlay's window property doesn't match the current window.
10341
d68443dc
MR
10342 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10343 (Fwindow_hchild): Rename to Fwindow_left_child.
10344 (Fwindow_next): Rename to Fwindow_next_sibling.
10345 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10346 (resize_window_check): Rename to window_resize_check.
10347 (resize_window_apply): Rename to window_resize_apply.
10348 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10349 (Fdelete_other_windows_internal, resize_frame_windows)
10350 (Fsplit_window_internal, Fdelete_window_internal)
10351 (grow_mini_window, shrink_mini_window)
10352 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10353
c7e73be5
JD
103542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10355
10356 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10357 (emacs_fixed_set_min_size): Remove.
10358 (emacs_fixed_new): Take frame as argument.
10359
10360 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10361 (_EmacsFixedPrivate): Remove minwidth/height.
10362 Add struct frame *f.
10363 (emacs_fixed_init): Initialize priv->f.
10364 (get_parent_class, emacs_fixed_set_min_size): Remove.
10365 (emacs_fixed_new): Set priv->f to argument.
10366 (emacs_fixed_get_preferred_width)
10367 (emacs_fixed_get_preferred_height): Use min_width/height from
10368 frames size_hint to set minimum and natural (Bug#8919).
10369 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10370 and use min_width/height from frames size_hint to set
10371 min_width/height (Bug#8919).
10372
10373 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10374 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10375 Fix indentation.
c7e73be5 10376
cf99dcf8
EZ
103772011-06-26 Eli Zaretskii <eliz@gnu.org>
10378
10379 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10380 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10381 called at ZV.
10382
029529ac
CY
103832011-06-26 Chong Yidong <cyd@stupidchicken.com>
10384
10385 * process.c (wait_reading_process_output): Bypass select if
10386 waiting for a cell while ignoring keyboard input, and input is
10387 pending. Suggested by Jan Djärv (Bug#8869).
10388
7a7ef429
PE
103892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10390
10391 Use gnulib's dup2 module instead of rolling our own.
10392 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10393
11fdef7d 103942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10395
10396 * dispnew.c (scrolling_window): Before scrolling, turn off a
10397 mouse-highlight in the window being scrolled.
10398
cd3520a4
JB
103992011-06-24 Juanma Barranquero <lekktu@gmail.com>
10400
10401 Move DEFSYM to lisp.h and use everywhere.
10402
10403 * character.h (DEFSYM): Move declaration...
10404 * lisp.h (DEFSYM): ...here.
10405
10406 * gnutls.c:
10407 * minibuf.c:
10408 * w32menu.c:
10409 * w32proc.c:
10410 * w32select.c: Don't include character.h.
10411
10412 * alloc.c (syms_of_alloc):
10413 * buffer.c (syms_of_buffer):
10414 * bytecode.c (syms_of_bytecode):
10415 * callint.c (syms_of_callint):
10416 * casefiddle.c (syms_of_casefiddle):
10417 * casetab.c (init_casetab_once):
10418 * category.c (init_category_once, syms_of_category):
10419 * ccl.c (syms_of_ccl):
10420 * cmds.c (syms_of_cmds):
10421 * composite.c (syms_of_composite):
10422 * dbusbind.c (syms_of_dbusbind):
10423 * dired.c (syms_of_dired):
10424 * dispnew.c (syms_of_display):
10425 * doc.c (syms_of_doc):
10426 * editfns.c (syms_of_editfns):
10427 * emacs.c (syms_of_emacs):
10428 * eval.c (syms_of_eval):
10429 * fileio.c (syms_of_fileio):
10430 * fns.c (syms_of_fns):
10431 * frame.c (syms_of_frame):
10432 * fringe.c (syms_of_fringe):
10433 * insdel.c (syms_of_insdel):
10434 * keymap.c (syms_of_keymap):
10435 * lread.c (init_obarray, syms_of_lread):
10436 * macros.c (syms_of_macros):
10437 * msdos.c (syms_of_msdos):
10438 * print.c (syms_of_print):
10439 * process.c (syms_of_process):
10440 * search.c (syms_of_search):
10441 * sound.c (syms_of_sound):
10442 * syntax.c (init_syntax_once, syms_of_syntax):
10443 * terminal.c (syms_of_terminal):
10444 * textprop.c (syms_of_textprop):
10445 * undo.c (syms_of_undo):
10446 * w32.c (globals_of_w32):
10447 * window.c (syms_of_window):
10448 * xdisp.c (syms_of_xdisp):
10449 * xfaces.c (syms_of_xfaces):
10450 * xfns.c (syms_of_xfns):
10451 * xmenu.c (syms_of_xmenu):
10452 * xsettings.c (syms_of_xsettings):
10453 * xterm.c (syms_of_xterm): Use DEFSYM.
10454
4228cf16
TZ
104552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10456
cd3520a4 10457 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10458
7fcccf1e
PE
104592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10460
7efb4e0e
PE
10461 Integer and buffer overflow fixes (Bug#8873).
10462
ff5844ad
PE
10463 * print.c (printchar, strout): Check for string overflow.
10464 (PRINTPREPARE, printchar, strout):
10465 Don't set size unless allocation succeeds.
10466
90532f02
PE
10467 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10468 for sizes. Check for string overflow more accurately.
10469 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10470
6d84508d
PE
10471 * macros.c: Integer and buffer overflow fixes.
10472 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10473 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10474 Use ptrdiff_t, not int, for sizes.
10475 Don't increment bufsize until after realloc succeeds.
10476 Check for size-calculation overflow.
10477 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10478
437b2cb4
PE
10479 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10480
8b9ac8b4
PE
10481 * lread.c: Integer overflow fixes.
10482 (read_integer): Radix is now EMACS_INT, not int,
10483 to improve quality of diagnostics for out-of-range radices.
10484 Calculate buffer size correctly for out-of-range radices.
10485 (read1): Check for integer overflow in radices, and in
10486 read-circle numbers.
82cb60d3
PE
10487 (read_escape): Avoid int overflow.
10488 (Fload, openp, read_buffer_size, read1)
10489 (substitute_object_recurse, read_vector, read_list, map_obarray):
10490 Use ptrdiff_t, not int, for sizes.
10491 (read1): Use EMACS_INT, not int, for sizes.
20270765 10492 Check for size overflow.
8b9ac8b4 10493
7fcccf1e
PE
10494 * image.c (cache_image): Check for size arithmetic overflow.
10495
bfbbd7e7
PE
10496 * lread.c: Integer overflow issues.
10497 (saved_doc_string_size, saved_doc_string_length)
10498 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10499 Now ptrdiff_t, not int.
10500 (read1): Don't assume doc string length fits in int. Check for
10501 out-of-range doc string lengths.
10502 (read_list): Don't assume file position fits in int.
39019e54 10503 (read_escape): Check for hex character overflow.
bfbbd7e7 10504
4e323265
LL
105052011-06-22 Leo Liu <sdl.web@gmail.com>
10506
10507 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10508 Move to minibuffer.el.
10509
85fece3e
PE
105102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10511
20b84ce9 10512 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10513 The following patches are for when GLYPH_DEBUG && !XASSERT.
10514 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10515 * dispnew.c (flush_stdout):
10516 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10517 Mark as externally visible.
10518 * dispnew.c (check_window_matrix_pointers): Now static.
10519 * dispnew.c (window_to_frame_vpos):
10520 * xfns.c (unwind_create_frame):
10521 * xterm.c (x_check_font): Remove unused local.
10522 * scroll.c (CHECK_BOUNDS):
10523 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10524 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10525 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10526 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10527 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10528 Now static.
10529 (debug_method_add): Use va_list and vsprintf rather than relying
10530 on undefined behavior with wrong number of arguments.
10531 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10532 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10533 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10534 since we're not interested in debugging glyphs with old libraries.
10535 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10536 GCC 4.6.0's static checking.
10537
0766b489
PE
105382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10539
31fd4b32
PE
10540 Integer overflow and signedness fixes (Bug#8873).
10541 A few related buffer overrun fixes, too.
10542
b79e8648
PE
10543 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10544
0766b489
PE
10545 * dispextern.h (struct face.stipple):
10546 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10547 (x_bitmap_mask, x_allocate_bitmap_record)
10548 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10549 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10550 (x_create_bitmap_from_xpm_data):
10551 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10552 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10553 (.bitmaps_last):
10554 * xfaces.c (load_pixmap):
10555 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10556 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10557 (.bitmaps_last, struct x_output.icon_bitmap):
10558 Use ptrdiff_t, not int, for bitmap indexes.
10559 (x_allocate_bitmap_record): Check for size overflow.
10560 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10561
b081724f
PE
10562 Use ptrdiff_t, not int, for overlay counts.
10563 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10564 * editfns.c (overlays_around, get_pos_property):
10565 * textprop.c (get_char_property_and_overlay):
10566 * xdisp.c (next_overlay_change, note_mouse_highlight):
10567 * xfaces.c (face_at_buffer_position):
21514da7
PE
10568 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10569 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10570 (Fnext_overlay_change, Fprevious_overlay_change)
10571 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10572 Use ptrdiff_t, not int, for sizes.
21514da7 10573 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10574
3de73e5e
PE
10575 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10576
2606c57b
PE
10577 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10578 (x_session_initialize): Do not assume string length fits in int.
10579
aaafe47a
PE
10580 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10581 This is unlikely, but can occur if DPI is outlandish.
10582
2674ddc8 10583 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10584 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10585
28154962
PE
10586 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10587 * xrdb.c (magic_file_p, search_magic_path):
10588 Omit last arg SUFFIX; it was always 0. All callers changed.
10589 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10590
7de51af5
PE
10591 * xfont.c (xfont_match): Avoid need for strlen.
10592
25ed6cc3
PE
10593 * xfns.c: Don't assume strlen fits in int.
10594 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10595
4eab31dd
PE
10596 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10597 not unsigned long, as we prefer signed integers. All callers changed.
10598 Detect integer overflow in repeat count.
10599 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10600 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10601
171e2a58
PE
10602 * termcap.c: Don't assume sizes fit in int and never overflow.
10603 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10604 (gobble_line): Check for size-calculation overflow.
10605
ad39faca 10606 * minibuf.c (Fread_buffer):
6e5bb2dc 10607 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10608 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10609 Don't assume string length fits in int.
10610
52c61c22 10611 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10612 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10613
b5b8c9e5
PE
10614 * font.c: Don't assume string length fits in int.
10615 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10616 Use ptrdiff_t, not int.
ccd6111c
PE
10617 (font_intern_prop): Don't assume string length fits in int.
10618 Don't assume integer property fits in fixnum.
10619 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10620
882f0d81 10621 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10622 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10623 Reformulate so as not to need the command string.
10624 Invoke gzip -cd rather than gunzip, as it's more portable.
10625 (lock_info_type, lock_file_1, lock_file):
10626 Don't assume pid_t and time_t fit in unsigned long.
10627 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10628 (current_lock_owner): Prefer signed type for sizes.
10629 Use memcpy, not strncpy, where memcpy is what is really wanted.
10630 Don't assume (via atoi) that time_t and pid_t fit in int.
10631 Check for time_t and/or pid_t out of range, e.g., via a network share.
10632 Don't alloca where an auto var works fine.
10633
93f4cf88
PE
10634 * fileio.c: Fix some integer overflow issues.
10635 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10636 Don't assume string length fits in int.
10637 (directory_file_name): Don't assume string length fits in long.
10638 (make_temp_name): Don't assume pid fits in int, or that its print
10639 length is less than 20.
10640
f3e92b69
PE
10641 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10642
1bfdaf10
PE
10643 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10644
35016e9a
PE
10645 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10646
3d1e65a1
PE
10647 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10648 We prefer signed integers, even for size calculations.
10649
0b963a93
PE
10650 * emacs.c: Don't assume string length fits in 'int'.
10651 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10652 (main): Don't invoke strlen when not needed.
10653
573f4b54
PE
10654 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10655 (XD_DEBUG_MESSAGE): Don't waste a byte.
10656
989f33ba
PE
10657 * callproc.c (getenv_internal_1, getenv_internal)
10658 (Fgetenv_internal):
965d34eb
PE
10659 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10660
e4d29b33
PE
10661 * lread.c (invalid_syntax): Omit length argument.
10662 All uses changed. This doesn't fix a bug, but it simplifies the
10663 code away from its former Hollerith-constant appearance, and it's
10664 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10665 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10666
eb49b136
PE
10667 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10668 This didn't break anything, but it didn't help either.
10669 It's confusing to put a bogus integer in a place where the actual
10670 value does not matter.
9f62aeb1 10671 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10672 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10673
15375a22
PE
10674 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10675 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10676 implementation.
b61cc01c
PE
10677 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10678 We prefer signed types, and the value cannot exceed the EMACS_INT
10679 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10680 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10681 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10682 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10683
53b2623d
PE
10684 * indent.c (sane_tab_width): New function.
10685 (current_column, scan_for_column, Findent_to, position_indentation)
10686 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10687 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10688
51cab52b 10689 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10690
f2ed8a70
PE
10691 * lisp.h (lint_assume): New macro.
10692 * composite.c (composition_gstring_put_cache):
10693 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10694
abe80cc6
PE
10695 * editfns.c, insdel.c:
10696 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10697
b02c740e
PE
10698 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10699
ebc96716
PE
10700 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10701
b4e50fa0 10702 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10703 Use much-faster test for byte-length change.
311d5d7c 10704 Don't assume string byte-length fits in 'int'.
a4cf38e4 10705 Check that character arg fits in 'int'.
85461888 10706 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10707
c0c1ee9f
PE
10708 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10709
a498d7f4
PE
10710 * fns.c (concat): Catch string overflow earlier.
10711 Do not rely on integer wraparound.
10712
51cab52b
PE
10713 * dispextern.h (struct it.overlay_strings_charpos)
10714 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10715 * xdisp.c (forward_to_next_line_start)
10716 (back_to_previous_visible_line_start)
10717 (reseat_at_next_visible_line_start, next_element_from_buffer):
10718 Don't arbitrarily truncate the value of 'selective' to int.
10719
76031fad
PE
10720 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10721
5eb55db9
PE
10722 * composite.c: Don't truncate sizes to 'int'.
10723 (composition_gstring_p, composition_reseat_it)
10724 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10725 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10726 not EMACS_UINT, for indexes.
5eb55db9 10727
0703a717
PE
10728 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10729
d6202519
PE
10730 * buffer.c: Include <verify.h>.
10731 (struct sortvec.priority, struct sortstr.priority):
8961a454 10732 Now EMACS_INT, not int.
c20998a7 10733 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10734 (struct sortstr.size, record_overlay_string)
10735 (struct sortstrlist.size, struct sortlist.used):
10736 Don't truncate size to int.
10737 (record_overlay_string): Check for size-calculation overflow.
d6202519 10738 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10739
d5a19415
JM
107402011-06-22 Jim Meyering <meyering@redhat.com>
10741
029529ac 10742 Don't leak an XBM-image-sized buffer
d5a19415
JM
10743 * image.c (xbm_load): Free the image buffer after using it.
10744
a9041e6c
PE
107452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10746
10747 Port to Sun C.
10748 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10749 that Sun C diagnosed.
10750 * fns.c (secure_hash): Fix pointer signedness issue.
10751 * intervals.c (static_offset_intervals): New function.
10752 (offset_intervals): Use it.
10753
7f3f739f
LL
107542011-06-21 Leo Liu <sdl.web@gmail.com>
10755
10756 * deps.mk (fns.o):
10757 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10758 sha512.h.
10759
10760 * fns.c (secure_hash): Rename from crypto_hash_function and change
10761 the first arg to accept symbols.
5b66d427 10762 (Fsecure_hash): New primitive.
7f3f739f
LL
10763 (syms_of_fns): New symbols.
10764
76147d94
DD
107652011-06-20 Deniz Dogan <deniz@dogan.se>
10766
10767 * process.c (Fset_process_buffer): Clarify return value in
10768 docstring.
10769
7d7d0045
CY
107702011-06-18 Chong Yidong <cyd@stupidchicken.com>
10771
10772 * dispnew.c (add_window_display_history): Use BVAR.
10773
10774 * xdisp.c (debug_method_add): Use BVAR.
10775 (check_window_end, dump_glyph_matrix, dump_glyph)
10776 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10777
10778 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10779 Likewise.
10780
10781 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10782 check till after the cache is created in init_frame_faces.
10783
ff2bc410
SM
107842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10785
10786 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10787
28177add
PE
107882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10789
dd3482fe
PE
10790 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10791 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10792 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10793
393d71f3 10794 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10795 * fileio.c (Finsert_file_contents):
10796 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10797 Remove the old (too-loose) buffer overflow checks.
10798 They weren't needed, since make_gap checks for buffer overflow.
10799 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10800 The old code merely checked for Emacs fixnum overflow, and relied
10801 on undefined (wraparound) behavior. The new code avoids undefined
10802 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10803
2e6813b0 10804 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10805 Tune. Don't use wider integers than needed. Don't use alloca.
10806 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10807
599a9e4f
PE
10808 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10809
99561444
PE
10810 * insdel.c, lisp.h (buffer_overflow): New function.
10811 (insert_from_buffer_1, replace_range, replace_range_2):
10812 * insdel.c (make_gap_larger):
10813 * editfns.c (Finsert_char):
10814 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10815
28177add
PE
10816 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10817
e69dafad
PE
108182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10819
4baa020d 10820 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10821
b1c46f02
PE
10822 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10823 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10824
e69dafad
PE
10825 * fileio.c: Don't assume EMACS_INT fits in off_t.
10826 (emacs_lseek): New static function.
10827 (Finsert_file_contents, Fwrite_region): Use it.
10828 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10829
566684ea
PE
10830 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10831
e6966cd6
PE
10832 * fns.c: Don't overflow int when computing a list length.
10833 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10834 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10835 truncation on 64-bit hosts. Check for QUIT every
10836 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10837 faster and is responsive enough.
10838 (Flength): Report an error instead of overflowing an integer.
10839 (Fsafe_length): Return a float if the value is not representable
10840 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10841 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10842 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10843
dd0b0efb
PE
10844 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10845 (header_size, word_size): New constants.
10846 (allocate_vectorlike): Don't check size overflow here.
10847 (allocate_vector): Check it here instead, since this is the only
10848 caller of allocate_vectorlike that could cause overflow.
10849 Check that the new vector's length is representable as a fixnum.
10850
86fe5cfe
PE
10851 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10852 The previous code was bogus. For example, next_almost_prime (32)
10853 returned 39, which is undesirable as it is a multiple of 3; and
10854 next_almost_prime (24) returned 25, which is a multiple of 5 so
10855 why was the code bothering to check for multiples of 7?
10856
80e88859
PE
10857 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10858
4a2f0ad6
PE
10859 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10860
f66c7cf8
PE
10861 Variadic C functions now count arguments with ptrdiff_t.
10862 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10863 Back then I didn't know that the Emacs coding style prefers signed int.
10864 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10865 were being counted with int, which may truncate counts on 64-bit
10866 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10867 * lisp.h (struct Lisp_Subr.function.aMANY)
10868 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10869 Arg counts are now ptrdiff_t, not size_t.
10870 All variadic functions and their callers changed accordingly.
10871 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10872 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10873 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10874 * callint.c (Fcall_interactively): Check arg count for overflow,
10875 to avoid potential buffer overrun. Use signed char, not 'int',
10876 for 'varies' array, so that we needn't bother to check its size
10877 calculation for overflow.
10878 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10879 * eval.c (apply_lambda):
10880 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10881 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10882 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10883
a1759b76
PE
10884 * callint.c (Fcall_interactively): Don't use index var as event count.
10885
d96be9fc
PE
10886 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10887 * mem-limits.h (SIZE): Remove; no longer used.
10888
a690a978 10889 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10890
578c21e6
PE
10891 Remove unnecessary casts.
10892 * xterm.c (x_term_init):
10893 * xfns.c (x_set_border_pixel):
10894 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10895 These aren't needed now that we assume ANSI C.
10896
96f53c6c
PE
10897 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10898 It's more likely to cause problems (due to unsigned overflow)
10899 than to cure them.
10900
83c77d31
PE
10901 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10902
ee2079f1
PE
10903 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10904
6da65536
PE
10905 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10906
7147c4a4
PE
10907 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10908
193e32d9
PE
10909 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10910
e5533da6
PE
10911 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10912
9910e595
PE
10913 GLYPH_CODE_FACE returns EMACS_INT, not int.
10914 * dispextern.h (merge_faces):
10915 * xfaces.c (merge_faces):
01103c44
PE
10916 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10917 Don't assume EMACS_INT fits in int.
9910e595 10918
2638320e
PE
10919 * character.h (CHAR_VALID_P): Remove unused parameter.
10920 * fontset.c, lisp.h, xdisp.c: All uses changed.
10921
045eb8d9
PE
10922 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10923
c1f134b5
PE
10924 * fns.c (concat): Minor tuning based on overflow analysis.
10925 This doesn't fix any bugs. Use int to hold character, instead
10926 of constantly refetching from Emacs object. Use XFASTINT, not
10927 XINT, for value known to be a character. Don't bother comparing
10928 a single byte to 0400, as it's always less.
10929
395fcb93 10930 * floatfns.c (Fexpt):
327eeec8
PE
10931 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10932
abbd3d23
PE
10933 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10934 for characters.
10935
684a03ef
PE
10936 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10937
0fed43f3
PE
10938 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10939 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10940 incorrectly succeed when S was a string, because 4294967386 was
10941 truncated before it was used.
10942
8fd02eb7
PE
10943 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10944 Otherwise, an out-of-range integer could cause undefined behavior
10945 on a 64-bit host.
10946
f8c86b69
PE
10947 * composite.c: Use int, not EMACS_INT, for characters.
10948 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10949 EMACS_INT, for values that are known to be in character range.
10950 This doesn't fix any bugs but is the usual style inside Emacs and
10951 may generate better code on 32-bit machines.
10952
34206dd2
PE
10953 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10954 This is for reasons similar to the recent CHAR_STRING fix.
10955 * charset.c (Fencode_char): Check that character arg is actually
10956 a character. Pass an int to ENCODE_CHAR.
10957 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10958 wider than 'int', as a compile-time check to prevent future regressions
10959 in this area.
10960
c5958d4c 10961 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10962
10963 Make sure a 64-bit char is never passed to CHAR_STRING.
10964 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10965 by silently ignoring the top 32 bits, allowing some values
10966 that were far too large to be valid characters.
10967 * character.h: Include <verify.h>.
10968 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10969 arguments are no wider than unsigned, as a compile-time check
10970 to prevent future regressions in this area.
10971 * data.c (Faset):
01103c44 10972 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10973 (Fsubst_char_in_region):
10974 * fns.c (concat):
10975 * xdisp.c (decode_mode_spec_coding):
10976 Adjust to CHAR_STRING's new requirement.
10977 * editfns.c (Finsert_char, Fsubst_char_in_region):
10978 * fns.c (concat): Check that character args are actually
10979 characters. Without this test, these functions did the wrong
10980 thing with wildly out-of-range values on 64-bit hosts.
10981
d37ca623
PE
10982 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10983 These casts should not be needed on 32-bit hosts, either.
10984 * keyboard.c (read_char):
10985 * lread.c (Fload): Remove casts to unsigned.
10986
ea204efb
PE
10987 * lisp.h (UNSIGNED_CMP): New macro.
10988 This fixes comparison bugs on 64-bit hosts.
10989 (ASCII_CHAR_P): Use it.
10990 * casefiddle.c (casify_object):
01103c44 10991 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10992 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10993 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10994 * dispextern.h (FACE_FROM_ID):
10995 * keyboard.c (read_char): Use UNSIGNED_CMP.
10996
41cb286c
PE
10997 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10998 not to EMACS_INT, to avoid GCC warning.
10999
4a1b9832
PE
11000 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11001
55daad71
PE
11002 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11003 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11004 isn't needed on 32-bit machines.
8f95c75c 11005
01103c44
PE
11006 * buffer.c (Fgenerate_new_buffer_name):
11007 Use EMACS_INT for count, not int.
0ceccced 11008 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11009
11010 * data.c (Qcompiled_function): Now static.
11011
c6f072e7
PE
11012 * window.c (window_body_lines): Now static.
11013
20ce5912
PE
11014 * image.c (gif_load): Rename local to avoid shadowing.
11015
9c4c5f81
PE
11016 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11017 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11018 * alloc.c (make_save_value): Integer argument is now of type
11019 ptrdiff_t, not int.
11020 (mark_object): Use ptrdiff_t, not int.
11021 * lisp.h (pD): New macro.
11022 * print.c (print_object): Use it.
11023
c0c5c8ae
PE
11024 * alloc.c: Use EMACS_INT, not int, to count objects.
11025 (total_conses, total_markers, total_symbols, total_vector_size)
11026 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11027 (total_free_floats, total_floats, total_free_intervals)
11028 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11029 Now EMACS_INT, not int. All uses changed.
11030 (Fgarbage_collect): Compute overall total using a double, so that
11031 integer overflow is less likely to be a problem. Check for overflow
11032 when converting back to an integer.
5a25e253
PE
11033 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11034 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11035 These were 'int' variables that could overflow on 64-bit hosts;
11036 they were never used, so remove them instead of repairing them.
211a0b2a 11037 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11038 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11039 Previously, this ceilinged at INT_MAX, but that doesn't work on
11040 64-bit machines.
e46bb31a 11041 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11042
c78baabf 11043 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11044 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11045 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11046 when a (possibly-narrower) signed value would do just as well.
11047 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11048
c9d624c6
PE
11049 * alloc.c: Catch some string size overflows that we were missing.
11050 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11051 for convenience in STRING_BYTES_MAX.
11052 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11053 The definition here is exact; the one in lisp.h was approximate.
11054 (allocate_string_data): Check for string overflow. This catches
11055 some instances we weren't catching before. Also, it catches
11056 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11057 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11058 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11059
c9d624c6
PE
11060 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11061 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11062 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11063
353032ce
PE
11064 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11065
2bccce07
PE
11066 * alloc.c (Fmake_string): Check for out-of-range init.
11067
0ac30604
SM
110682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11069
11070 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11071
c195f2de
JD
110722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11073
11074 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11075 xg_get_default_scrollbar_width.
11076
11077 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11078 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11079 (style_changed_cb): Call update_theme_scrollbar_width and call
11080 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11081 all frames (Bug#8505).
11082 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11083 Call gtk_window_set_resizable if HAVE_GTK3.
11084 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11085 and height if HAVE_GTK3 (Bug#8505).
11086 (scroll_bar_width_for_theme): New variable.
11087 (update_theme_scrollbar_width): New function.
11088 (xg_get_default_scrollbar_width): Move code to
11089 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11090 (xg_initialize): Call update_theme_scrollbar_width.
11091
11092 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11093
11094 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11095
e10ac9f1
MR
110962011-06-12 Martin Rudalics <rudalics@gmx.at>
11097
11098 * frame.c (make_frame): Call other_buffer_safely instead of
11099 other_buffer.
11100
11101 * window.c (temp_output_buffer_show): Call display_buffer with
11102 second argument Vtemp_buffer_show_specifiers and reset latter
11103 immediately after the call.
11104 (Vtemp_buffer_show_specifiers): New variable.
11105 (auto_window_vscroll_p, next_screen_context_lines)
11106 (Vscroll_preserve_screen_position): Remove leading asterisks from
11107 doc-strings.
11108
2d3c217e 111092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11110
7b7f97e8 11111 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11112 * buffer.c (Qclone_number): Remove for now, as it's unused.
11113 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11114 (record_buffer): Remove unused local.
11115 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11116 (set_frame_buffer_list): Remove; unused.
11117 * frame.h (other_visible_frames): Remove decl.
11118 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11119 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11120 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11121 if HAVE_GPM.
11122 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11123 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11124 Define only if HAVE_GPM.
11125 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11126 (update_hints_inhibit): Remove; never set. All uses removed.
11127 * widgetprv.h (emacsFrameClassRec): Remove decl.
11128 * window.c (delete_deletable_window): Now returns void, since it
11129 wasn't returning anything.
11130 (compare_window_configurations): Remove unused locals.
11131 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11132 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11133 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11134 the same widths as pointers. This follows up on the 2011-05-06 patch.
11135 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11136 * xterm.h: Likewise.
11137 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11138
1384b89e
JB
111392011-06-12 Juanma Barranquero <lekktu@gmail.com>
11140
11141 * makefile.w32-in: Update dependencies.
11142 (LISP_H): Add lib/intprops.h.
11143
1100a63c
CY
111442011-06-11 Chong Yidong <cyd@stupidchicken.com>
11145
11146 * image.c (gif_load): Add animation frame delay to the metadata.
11147 (syms_of_image): Use DEFSYM. New symbol `delay'.
11148
6198ccd0
MR
111492011-06-11 Martin Rudalics <rudalics@gmx.at>
11150
11151 * window.c (delete_deletable_window): Re-add.
11152 (Fset_window_configuration): Rewrite to handle dead buffers and
11153 consequently deletable windows.
11154 (window_tree, Fwindow_tree): Remove. Supply functionality in
11155 window.el.
11156 (compare_window_configurations): Simplify code.
11157
b6e3633c
AS
111582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11159
1ab0dee5
AS
11160 * image.c (imagemagick_load_image): Fix type mismatch.
11161 (Fimagemagick_types): Likewise.
11162
b6e3633c
AS
11163 * window.h (replace_buffer_in_windows): Declare.
11164
9397e56f
MR
111652011-06-11 Martin Rudalics <rudalics@gmx.at>
11166
11167 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11168 Qclone_number. Remove external declaration of Qdelete_window.
11169 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11170 code.
640c8776
SM
11171 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11172 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11173 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11174 buffer list implementation.
11175 (other_buffer_safely): New function.
11176 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11177 calls to replace_buffer_in_windows and
11178 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11179 if allowed.
11180 (record_buffer): Inhibit quitting and rewrite using quittable
11181 functions. Run Qbuffer_list_update_hook if allowed.
11182 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11183 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11184 Move switch-to-buffer to window.el.
9397e56f
MR
11185 (bury-buffer): Move to window.el.
11186 (Vbuffer_list_update_hook): New variable.
11187
11188 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11189 section.
11190
11191 * window.h (resize_frame_windows): Move up in code.
11192 (Fwindow_frame): Remove EXFUN.
11193 (replace_buffer_in_all_windows): Remove prototype.
11194 (replace_buffer_in_windows_safely): Add prototype.
11195
11196 * window.c: Declare Qdelete_window static again. Move down
11197 declaration of select_count.
11198 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11199 (Fother_window): Move to window.el.
11200 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11201 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11202 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11203 window.el.
11204 (replace_buffer_in_windows): Implement by calling
11205 Qreplace_buffer_in_windows.
11206 (replace_buffer_in_all_windows): Remove with some functionality
11207 moved into replace_buffer_in_windows_safely.
11208 (replace_buffer_in_windows_safely): New function.
11209 (select_window_norecord, select_frame_norecord): Move in front
11210 of run_window_configuration_change_hook. Remove now obsolete
11211 declarations.
640c8776
SM
11212 (Fset_window_buffer): Rewrite doc-string.
11213 Call Qrecord_window_buffer.
9397e56f
MR
11214 (keys_of_window): Move binding for other-window to window.el.
11215
b50691aa
CY
112162011-06-11 Chong Yidong <cyd@stupidchicken.com>
11217
11218 * dispextern.h (struct image): Replace data member, whose int_val
11219 and ptr_val fields were not used by anything, with a single
11220 lisp_val object.
11221
11222 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11223 (gif_clear_image, gif_load, imagemagick_load_image)
11224 (gs_clear_image, gs_load): Callers changed.
11225
3f754b86
PE
112262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11227
cca69397
PE
11228 * buffer.h: Include <time.h>, for time_t.
11229 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11230
109e28d0
PE
11231 Fix minor problems found by static checking.
11232
60737f02
PE
11233 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11234
4b66faf3
PE
11235 Make identifiers static if they are not used in other modules.
11236 * data.c (Qcompiled_function, Qframe, Qvector):
11237 * image.c (QimageMagick, Qsvg):
11238 * minibuf.c (Qmetadata):
11239 * window.c (resize_window_check, resize_root_window): Now static.
11240 * window.h (resize_window_check, resize_root_window): Remove decls.
11241
109e28d0
PE
11242 * window.c (window_deletion_count, delete_deletable_window):
11243 Remove; unused.
46a4ce9e
PE
11244 (window_body_lines): Now static.
11245 (Fdelete_other_windows_internal): Mark vars as initialized.
11246 Make sure 'resize_failed' is initialized.
11247 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11248 (resize_window_apply): Remove unused local.
11249 * window.h (delete_deletable_window): Remove decl.
11250
109e28d0 11251 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11252 (imagemagick_load_image): Fix pointer signedness problem by changing
11253 last arg from unsigned char * to char *. All uses changed.
11254 Also, fix a local for similar reasons.
11255 Remove unused locals. Remove locals to avoid shadowing.
11256 (fn_rsvg_handle_free): Remove; unused.
11257 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11258 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11259
3f754b86
PE
11260 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11261
2547adb1
CY
112622011-06-10 Chong Yidong <cyd@stupidchicken.com>
11263
11264 * image.c (gif_load): Fix omitted cast error introduced by
11265 2011-06-06 change.
11266
2c8e37d4
MR
112672011-06-10 Martin Rudalics <rudalics@gmx.at>
11268
11269 * window.h (resize_proportionally, orig_total_lines)
11270 (orig_top_line): Remove from window structure.
11271 (set_window_height, set_window_width, change_window_heights)
11272 (Fdelete_window): Remove prototypes.
11273 (resize_frame_windows): Remove duplicate declaration.
11274
440a42e3
EZ
112752011-06-10 Eli Zaretskii <eliz@gnu.org>
11276
11277 * window.h (resize_frame_windows, resize_window_check)
11278 (delete_deletable_window, resize_root_window)
11279 (resize_frame_windows): Declare prototypes.
11280
11281 * window.c (resize_window_apply): Make definition be "static" to
11282 match the prototype.
11283
562dd5e9
MR
112842011-06-10 Martin Rudalics <rudalics@gmx.at>
11285
11286 * window.c: Remove declarations of Qwindow_size_fixed,
11287 window_min_size_1, window_min_size_2, window_min_size,
11288 size_window, window_fixed_size_p, enlarge_window, delete_window.
11289 Remove static from declaration of Qdelete_window, it's
11290 temporarily needed by Fbury_buffer.
11291 (replace_window): Don't assign orig_top_line and
11292 orig_total_lines.
11293 (Fdelete_window, delete_window): Remove. Window deletion is
11294 handled by window.el.
640c8776
SM
11295 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11296 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11297 (Fdelete_other_windows): Remove. Deleting other windows is
11298 handled by window.el.
11299 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11300 handled in window.el.
11301 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11302 Window minimum sizes are handled in window.el.
11303 (shrink_windows, size_window, set_window_height)
11304 (set_window_width, change_window_heights, window_height)
11305 (window_width, CURBEG, CURSIZE, enlarge_window)
11306 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11307 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11308 handled in window.el.
11309 (make_dummy_parent): Rename to make_parent_window and give it a
11310 second argument horflag.
11311 (make_window): Don't set resize_proportionally any more.
11312 (Fsplit_window): Remove. Windows are split in window.el.
11313 (save_restore_action, save_restore_orig_size)
11314 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11315 Resize mini windows in window.el.
11316 (grow_mini_window, shrink_mini_window): Implement by calling
11317 Qresize_root_window_vertically, resize_window_check and
11318 resize_window_apply.
640c8776
SM
11319 (saved_window, Fset_window_configuration, save_window_save):
11320 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11321 resize_proportionally.
11322 (window_min_height, window_min_width): Move to window.el.
11323 (keys_of_window): Move bindings for delete-other-windows,
11324 split-window, delete-window and enlarge-window to window.el.
11325
11326 * buffer.c: Temporarily extern Qdelete_window.
11327 (Fbury_buffer): Temporarily call Qdelete_window instead of
11328 Fdelete_window (Fbury_buffer will move to window.el soon).
11329
11330 * frame.c (set_menu_bar_lines_1): Remove code handling
11331 orig_top_line and orig_total_lines.
11332
11333 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11334 set_window_height but set heights directly.
11335 (change_frame_size_1): Use resize_frame_windows.
11336
11337 * xdisp.c (init_xdisp): Don't use set_window_height but set
11338 heights directly.
11339
640c8776
SM
11340 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11341 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11342 run_window_configuration_change_hook.
11343
11344 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11345 instead of change_window_heights and run
11346 run_window_configuration_change_hook.
11347
1a13852e
MR
113482011-06-09 Martin Rudalics <rudalics@gmx.at>
11349
11350 * window.c (replace_window): Rename second argument REPLACEMENT to
11351 NEW. New third argument SETFLAG. Rewrite.
11352 (delete_window, make_dummy_parent): Call replace_window with
11353 third argument 1.
11354 (window_list_1): Move down in code.
11355 (run_window_configuration_change_hook): Move set_buffer part
11356 before select_frame_norecord part in order to unwind correctly.
11357 Rename count1 to count.
11358 (recombine_windows, delete_deletable_window, resize_root_window)
11359 (Fdelete_other_windows_internal)
11360 (Frun_window_configuration_change_hook, make_parent_window)
11361 (resize_window_check, resize_window_apply, Fresize_window_apply)
11362 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11363 (Fdelete_window_internal, Fresize_mini_window_internal):
11364 New functions.
1a13852e
MR
11365 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11366
f3d1777e
MR
113672011-06-08 Martin Rudalics <rudalics@gmx.at>
11368
496e208e
MR
11369 * window.h (window): Add some new members to window structure -
11370 normal_lines, normal_cols, new_total, new_normal, clone_number,
11371 splits, nest, prev_buffers, next_buffers.
11372 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11373 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11374
f3d1777e
MR
11375 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11376 Remove.
496e208e
MR
11377 (make_dummy_parent): Set new members of windows structure.
11378 (make_window): Move down in code. Handle new members of window
11379 structure.
11380 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11381 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11382 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11383 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11384 (Fset_window_next_buffers, Fset_window_clone_number):
11385 New functions.
496e208e
MR
11386 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11387 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11388 Doc-string fixes.
11389 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11390 Argument WINDOW can be now internal window too.
11391 (Fwindow_use_time): Move up in code.
11392 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11393 Rewrite doc-string.
11394 (Fset_window_configuration, saved_window)
11395 (Fcurrent_window_configuration, save_window_save): Handle new
11396 members of window structure.
b9e809c2
MR
11397 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11398 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11399 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11400 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11401 Qget_mru_window, Qresize_root_window,
11402 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11403 Qauto_buffer_name; staticpro them.
f3d1777e 11404
abde8f8c
MR
114052011-06-07 Martin Rudalics <rudalics@gmx.at>
11406
11407 * window.c (Fwindow_total_size, Fwindow_left_column)
11408 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11409 (Fwindow_list_1): New functions.
11410 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11411 (Fwindow_width, Fscroll_left, Fscroll_right):
11412 Use window_body_cols instead of window_box_text_cols.
11413 (delete_window, Fset_window_configuration):
11414 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11415 (delete_all_subwindows): Take a window as argument and not a
11416 structure. Rewrite.
190b47e6
MR
11417 (window_loop): Remove handling of GET_LRU_WINDOW and
11418 GET_LARGEST_WINDOW.
11419 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11420
11421 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11422 window_box_text_cols. delete_all_subwindows now takes a
11423 Lisp_Object as argument.
abde8f8c 11424
640c8776
SM
11425 * indent.c (compute_motion, Fcompute_motion):
11426 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11427
fa8a67e6
MR
11428 * frame.c (delete_frame): Call delete_all_subwindows with root
11429 window as argument.
11430
a54e3482
DC
114312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11432
11433 * fns.c (Fputhash): Document return value.
11434
60002bf5
CY
114352011-06-06 Chong Yidong <cyd@stupidchicken.com>
11436
11437 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11438
0c671da6 114392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11440
b862a52a 11441 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11442
be44ca6c
PE
11443 Check for overflow when converting integer to cons and back.
11444 * charset.c (Fdefine_charset_internal, Fdecode_char):
11445 Use cons_to_unsigned to catch overflow.
11446 (Fencode_char): Use INTEGER_TO_CONS.
11447 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11448 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11449 * data.c (long_to_cons, cons_to_long): Remove.
11450 (cons_to_unsigned, cons_to_signed): New functions.
11451 These signal an error for invalid or out-of-range values.
11452 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11453 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11454 * font.c (Ffont_variation_glyphs):
11455 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11456 * lisp.h: Include <intprops.h>.
11457 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11458 (cons_to_signed, cons_to_unsigned): New decls.
11459 (long_to_cons, cons_to_long): Remove decls.
11460 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11461 (Fprimitive_undo): Use CONS_TO_INTEGER.
11462 * xfns.c (Fx_window_property): Likewise.
11463 * xselect.c: Include <limits.h>.
11464 (x_own_selection, selection_data_to_lisp_data):
11465 Use INTEGER_TO_CONS.
11466 (x_handle_selection_request, x_handle_selection_clear)
11467 (x_get_foreign_selection, Fx_disown_selection_internal)
11468 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11469 (lisp_data_to_selection_data): Use cons_to_unsigned.
11470 (x_fill_property_data): Use cons_to_signed.
11471 Report values out of range.
11472
d1f3d2af
PE
11473 Check for buffer and string overflow more precisely.
11474 * buffer.h (BUF_BYTES_MAX): New macro.
11475 * lisp.h (STRING_BYTES_MAX): New macro.
11476 * alloc.c (Fmake_string):
11477 * character.c (string_escape_byte8):
11478 * coding.c (coding_alloc_by_realloc):
11479 * doprnt.c (doprnt):
11480 * editfns.c (Fformat):
11481 * eval.c (verror):
11482 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11483 since they may not be the same number.
11484 * editfns.c (Finsert_char):
11485 * fileio.c (Finsert_file_contents):
11486 Likewise for BUF_BYTES_MAX.
11487
dd52fcea
PE
11488 * image.c: Use ptrdiff_t, not int, for sizes.
11489 (slurp_file): Switch from int to ptrdiff_t.
11490 All uses changed.
11491 (slurp_file): Check that file size fits in both size_t (for
11492 malloc) and ptrdiff_t (for sanity and safety).
11493
7f9bbdbb
PE
11494 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11495 if b->modtime has its maximal value.
11496
dfe18f82
PE
11497 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11498
84acfcf0
PE
11499 Don't assume time_t can fit into int.
11500 * buffer.h (struct buffer.modtime): Now time_t, not int.
11501 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11502 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11503
ccd9a01a
PE
11504 Minor fixes for signed vs unsigned integers.
11505 * character.h (MAYBE_UNIFY_CHAR):
11506 * charset.c (maybe_unify_char):
11507 * keyboard.c (read_char, reorder_modifiers):
11508 XINT -> XFASTINT, since the integer must be nonnegative.
11509 * ftfont.c (ftfont_spec_pattern):
11510 * keymap.c (access_keymap, silly_event_symbol_error):
11511 XUINT -> XFASTINT, since the integer must be nonnegative.
11512 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11513 since it makes no difference and we prefer signed.
11514 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11515 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11516 nonnegative.
11517
d6d100dd
SM
115182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11519
11520 * window.h (Fwindow_frame): Declare.
11521
2b6148e4
PE
115222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11523
11524 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11525 (SPARE_MEMORY): Always define.
11526 (LARGE_REQUEST): Remove.
11527 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11528
f230ecc9
MR
115292011-06-06 Martin Rudalics <rudalics@gmx.at>
11530
727e958e
MR
11531 * lisp.h: Move EXFUNS for Fframe_root_window,
11532 Fframe_first_window and Fset_frame_selected_window to window.h.
11533
11534 * window.h: Move EXFUNS for Fframe_root_window,
11535 Fframe_first_window and Fset_frame_selected_window here from
11536 lisp.h.
11537
11538 * frame.c (Fwindow_frame, Fframe_first_window)
11539 (Fframe_root_window, Fframe_selected_window)
11540 (Fset_frame_selected_window): Move to window.c.
11541 (Factive_minibuffer_window): Move to minibuf.c.
11542 (Fother_visible_frames_p): New function.
11543
11544 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11545
f230ecc9
MR
11546 * window.c (decode_window, decode_any_window): Move up in code.
11547 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11548 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11549 (Fwindow_buffer): Move up and rewrite doc-string.
11550 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11551 (Fwindow_prev): New functions.
727e958e
MR
11552 (Fwindow_frame): Move here from frame.c. Accept any window as
11553 argument.
11554 (Fframe_root_window, Fframe_first_window)
11555 (Fframe_selected_window): Move here from frame.c. Accept frame
11556 or arbitrary window as argument. Update doc-strings.
11557 (Fminibuffer_window): Move up in code.
11558 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11559 (Fset_frame_selected_window): Move here from frame.c.
11560 Marginal rewrite.
727e958e
MR
11561 (Fselected_window, select_window, Fselect_window): Move up in
11562 code. Minor doc-string fixes.
f230ecc9 11563
4d09bcf6
PE
115642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11565
11566 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11567 Do not assume that spare memory exists; that assumption is valid
11568 only if SYSTEM_MALLOC.
11569 (LARGE_REQUEST): New macro, so that the issue of large requests
11570 is separated from the issue of spare memory.
11571
810928a2
AS
115722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11573
172418ad
AS
11574 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11575 format. (Bug#8806)
11576
43f862f7
AS
11577 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11578
810928a2
AS
11579 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11580 before statements.
11581
a059fe24
JD
115822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11583
11584 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11585
11586 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11587
11588 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11589 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11590
989bf368
JB
115912011-06-05 Juanma Barranquero <lekktu@gmail.com>
11592
11593 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11594
4b80f674
CY
115952011-06-04 Chong Yidong <cyd@stupidchicken.com>
11596
11597 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11598 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11599 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11600 New error handlers.
4b80f674
CY
11601 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11602 Obey Vx_select_enable_clipboard_manager. Catch errors in
11603 x_clipboard_manager_save (Bug#8779).
11604 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11605 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11606
99a33b77 116072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11608
11609 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11610
99a33b77 116112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11612
11613 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11614 in the current matrix if keep_current_p is non-zero.
11615
8264569d
EZ
116162011-06-04 Eli Zaretskii <eliz@gnu.org>
11617
11618 * bidi.c (bidi_level_of_next_char): Fix last change.
11619
57f97249
EZ
116202011-06-03 Eli Zaretskii <eliz@gnu.org>
11621
fec2107c 11622 Support bidi reordering of text covered by display properties.
57f97249 11623
fec2107c
EZ
11624 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11625 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11626 (bidi_cache_search, bidi_cache_iterator_state)
11627 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11628 (bidi_level_of_next_char, bidi_move_to_visually_next):
11629 Support character positions inside a run of characters covered by a
fec2107c
EZ
11630 display string.
11631 (bidi_paragraph_init, bidi_resolve_explicit_1)
11632 (bidi_level_of_next_char): Call bidi_fetch_char and
11633 bidi_fetch_char_advance instead of FETCH_CHAR and
11634 FETCH_CHAR_ADVANCE.
11635 (bidi_init_it): Initialize new members.
11636 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11637 definitions.
11638 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11639 instead of using explicit *_CHAR codes.
d6d100dd
SM
11640 (bidi_resolve_explicit, bidi_resolve_weak):
11641 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11642 bidirectional text is supported only in multibyte buffers.
11643 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11644 it to initialize the frame_window_p member of struct bidi_it.
11645 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11646 (bidi_resolve_explicit, bidi_resolve_weak)
11647 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11648 bidi_it->nchars is non-positive.
11649 (bidi_level_of_next_char): Don't try to lookup the cache for the
11650 next/previous character if nothing is cached there yet, or if we
11651 were just reseat()'ed to a new position.
c40e2fb2 11652
0e14fe90
EZ
11653 * xdisp.c (set_cursor_from_row): Set start and stop points
11654 according to the row's direction when priming the loop that looks
11655 for the glyph on which to display cursor.
11656 (single_display_spec_intangible_p): Function deleted.
11657 (display_prop_intangible_p): Reimplement to call
11658 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11659 Accept 3 additional arguments needed by handle_display_spec.
11660 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11661 values: lists, `(when COND...)' forms, etc.
11662 (single_display_spec_string_p): Support property values that are
11663 lists with the argument STRING its top-level element.
11664 (display_prop_string_p): Fix the condition for processing a
11665 property that is a list to be consistent with handle_display_spec.
fec2107c 11666 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11667 last portion of handle_display_prop.
11668 (compute_display_string_pos): Accept additional argument
11669 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11670 value of a `display' property is a "replacing spec".
11671 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11672 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11673 the display property, but just return a value indicating whether
11674 the display property will replace the characters it covers.
11675 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11676 frame_window_p members of struct bidi_it.
d6d100dd
SM
11677 (compute_display_string_pos, compute_display_string_end):
11678 New functions.
fec2107c
EZ
11679 (push_it): Accept second argument POSITION, where pop_it should
11680 jump to continue iteration.
11681 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11682
fec2107c
EZ
11683 * keyboard.c (adjust_point_for_property): Adjust the call to
11684 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11685
11686 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11687 (bidi_init_it): Update prototypes.
11688 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11689 (compute_display_string_pos, compute_display_string_end):
11690 Declare prototypes.
fec2107c
EZ
11691 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11692 EMACS_INT.
fc6f18ce 11693
40087514 116942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11695
57f53182
PE
11696 Malloc failure behavior now depends on size of allocation.
11697 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11698 * lisp.h: Change signatures accordingly.
11699 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11700 All callers changed. (Bug#8762)
11701
11702 * gnutls.c: Use Emacs's memory allocators.
11703 Without this change, the gnutls library would invoke malloc etc.
11704 directly, which causes problems on non-SYNC_INPUT hosts, and which
11705 runs afoul of improving memory_full behavior. (Bug#8761)
11706 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11707 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11708 xfree instead of the default malloc, realloc, free.
11709 (Fgnutls_boot): No need to check for memory allocation failure,
11710 since xmalloc does that for us.
11711
ac32cd99 11712 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11713 * category.c (hash_get_category_set):
11714 * ccl.c (ccl_driver):
11715 * charset.c (Fdefine_charset_internal):
11716 * charset.h (struct charset.hash_index):
11717 * composite.c (get_composition_id, gstring_lookup_cache)
11718 (composition_gstring_put_cache):
11719 * composite.h (struct composition.hash_index):
11720 * dispextern.h (struct image.hash):
11721 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11722 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11723 (hashfn_equal, hashfn_user_defined, make_hash_table)
11724 (maybe_resize_hash_table, hash_lookup, hash_put)
11725 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11726 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11727 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11728 * image.c (make_image, search_image_cache, lookup_image)
11729 (xpm_put_color_table_h):
11730 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11731 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11732 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11733 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11734 * alloc.c (allocate_vectorlike):
11735 Check for overflow in vector size calculations.
11736 * ccl.c (ccl_driver):
11737 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11738 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11739 need to be updated by these changes.
40087514
PE
11740 * fns.c (make_hash_table, maybe_resize_hash_table):
11741 Check for integer overflow with large hash tables.
0de4bb68
PE
11742 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11743 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11744 (SXHASH_REDUCE): New macro.
11745 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11746 Use it instead of discarding useful hash info with large hash values.
11747 (sxhash_float): New function.
11748 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11749 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11750 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11751 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11752 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11753 Adjust signatures to match updated version of code.
11754 (consing_since_gc): Now EMACS_INT, since a single hash table can
11755 use more than INT_MAX bytes.
11756
698d32e2
DN
117572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11758
11759 Make it possible to build with GCC-4.6+ -O2 -flto.
11760
11761 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11762
fd6fa53f
SM
117632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11764
11765 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11766 Call minibuffer-inactive-mode.
11767
864db017
JB
117682011-05-31 Juanma Barranquero <lekktu@gmail.com>
11769
11770 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11771 Update dependencies.
11772
2ad0baf4
DN
117732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11774
11775 * data.c (init_data): Remove code for UTS, this system is not
11776 supported anymore.
11777
4fcc2638
DN
117782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11779
11780 Don't force ./temacs to start in terminal mode.
11781
11782 * frame.c (make_initial_frame): Initialize faces in all cases, not
11783 only when CANNOT_DUMP is defined.
11784 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11785
c56e0fd5
DN
117862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11787
11788 * dispnew.c (add_window_display_history): Use const for the string
11789 pointer. Remove declaration, not needed.
11790
333d54da 117912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11792
55d4c1b2 11793 Use 'inline', not 'INLINE'.
333d54da 11794 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11795 * alloc.c, fontset.c (INLINE): Remove.
11796 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11797 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11798 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11799 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11800 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11801
738db178
DN
118022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11803
11804 Make it possible to run ./temacs.
11805
11806 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11807 syms_of_callproc does the same thing. Remove test for
11808 "initialized", do it in the caller.
11809 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11810
620c53a6
SM
118112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11812
11813 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11814 (read_minibuf): Use get_minibuffer.
11815 (syms_of_minibuf): Use DEFSYM.
11816 (Qmetadata): New var.
11817 * data.c (Qbuffer): Don't make it static.
11818 (syms_of_data): Use DEFSYM.
11819
e003a292
PE
118202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11821
11822 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11823 (CCL_CODE_MIN): New macro.
11824
ed008a6d
PE
118252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11826
3687c2ef
PE
11827 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11828
ed008a6d
PE
11829 * eval.c (Qdebug): Now static.
11830 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11831 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11832 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11833
d66c4c7c
CY
118342011-05-29 Chong Yidong <cyd@stupidchicken.com>
11835
11836 * image.c: Various fixes to ImageMagick code comments.
11837 (Fimagemagick_types): Doc fix.
11838
5fbc2025
PE
118392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11840
0196f88a
PE
11841 Minor fixes prompted by GCC 4.6.0 warnings.
11842
11843 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11844
5fbc2025
PE
11845 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11846 (x_clipboard_manager_save_all): Move extern decl to ...
11847 * xterm.h: ... here, so that it can be checked for consistency.
11848
1dd3c2d9
CY
118492011-05-29 Chong Yidong <cyd@stupidchicken.com>
11850
11851 * xselect.c (x_clipboard_manager_save_frame)
11852 (x_clipboard_manager_save_all): New functions.
11853 (Fx_clipboard_manager_save): Lisp function deleted.
11854
11855 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11856 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11857
11858 * xterm.h: Update prototype.
11859
5ba6571d
WX
118602011-05-28 William Xu <william.xwl@gmail.com>
11861
11862 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11863 exiting (Bug#8239).
11864
3eaff834
JM
118652011-05-28 Jim Meyering <meyering@redhat.com>
11866
e1900994 11867 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11868 * fns.c (to_uchar): Define.
11869 (crypto_hash_function): Use it to convert some newly-signed
11870 variables to unsigned, to avoid sign-extension bugs. For example,
11871 without this change, (md5 "truc") would evaluate to
11872 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11873 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11874 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11875
0f6990a7
PE
118762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11877
11878 Integer overflow fixes.
c8a9ca5a 11879
08686060
PE
11880 * dbusbind.c: Serial number integer overflow fixes.
11881 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11882 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11883 to hold a serial number that is too large for a fixnum.
11884 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11885 Check for serial numbers out of range. Decode any serial number
59568bf0 11886 that was so large that it became a float. (Bug#8722)
08686060 11887
2d1fc3c7
PE
11888 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11889 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11890 Use XFASTINT rather than XUINT when numbers are nonnegative.
11891 (xd_append_arg, Fdbus_method_return_internal):
11892 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11893 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11894 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11895 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11896 (Bug#8722)
2d1fc3c7 11897
c8a9ca5a
PE
11898 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11899
519e1d69
PE
11900 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11901
6df6ae42 11902 ccl: Add integer overflow checks.
30569699
PE
11903 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11904 (IN_INT_RANGE): New macros.
11905 (ccl_driver): Use them to check for integer overflow when
11906 decoding a CCL program. Many of the new checks are whether XINT (x)
11907 fits in int; it doesn't always, on 64-bit hosts. The new version
11908 doesn't catch all possible integer overflows, but it's an
847044ea 11909 improvement. (Bug#8719)
30569699 11910
c11285dc
PE
11911 * alloc.c (make_event_array): Use XINT, not XUINT.
11912 There's no need for unsigned here.
11913
fdccd48e
PE
11914 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11915 This follows up to the 2011-05-06 change that substituted uintptr_t
11916 for EMACS_INT. This case wasn't caught back then.
11917
37910ab2
PE
11918 Rework Fformat to avoid integer overflow issues.
11919 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11920 now (part of C89). Include <verify.h>.
11921 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11922 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11923 (Fformat): Avoid the prepass trying to compute sizes; it was only
11924 approximate and thus did not catch overflow reliably. Instead, walk
11925 through the format just once, formatting and computing sizes as we go,
11926 checking for integer overflow at every step, and allocating a larger
11927 buffer as needed. Keep track separately whether the format is
11928 multibyte. Keep only the most-recently calculated precision, rather
11929 than them all. Record whether each argument has been converted to
11930 string. Use EMACS_INT, not int, for byte and char and arg counts.
11931 Support field widths and precisions larger than INT_MAX. Avoid
11932 sprintf's undefined behavior with conversion specifications such as %#d
11933 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11934 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11935 formatting out-of-range floating point numbers with int
9173deec 11936 formats. (Bug#8668)
37910ab2 11937
2e6578fb
PE
11938 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11939
0ae6bdee
PE
11940 * data.c: Avoid integer truncation in expressions involving floats.
11941 * data.c: Include <intprops.h>.
11942 (arith_driver): When there's an integer overflow in an expression
11943 involving floating point, convert the integers to floating point
11944 so that the resulting value does not suffer from catastrophic
11945 integer truncation. For example, on a 64-bit host (* 4
11946 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11947 Do not rely on undefined behavior after integer overflow.
11948
de883a70
PE
11949 merge count_size_as_multibyte, parse_str_to_multibyte
11950 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11951 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11952 Check for integer overflow.
11953 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11954 since it's now a duplicate of the other. This is more of
11955 a character than a buffer op, so better that it's in character.c.
11956 * fns.c, print.c: Adjust to above changes.
11957
2ff916cb
PE
119582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11959
11960 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11961
f1b54466
PE
119622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11963
fb1ac845
PE
11964 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11965 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11966 (x_clipboard_manager_save): Now static.
11967 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11968
f1b54466
PE
11969 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11970 (crypto_hash_function): Now static.
11971 Fix pointer signedness problems. Avoid unnecessary initializations.
11972
a9f737ee
CY
119732011-05-27 Chong Yidong <cyd@stupidchicken.com>
11974
11975 * termhooks.h (Vselection_alist): Make it terminal-local.
11976
11977 * terminal.c (create_terminal): Initialize it.
11978
11979 * xselect.c: Support for clipboard managers.
11980 (Vselection_alist): Move to termhooks.h as terminal-local var.
11981 (LOCAL_SELECTION): New macro.
11982 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11983 (symbol_to_x_atom): Remove gratuitous arg.
11984 (x_handle_selection_request, lisp_data_to_selection_data)
11985 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11986 (x_own_selection, x_get_local_selection, x_convert_selection):
11987 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11988 (some_frame_on_display): Delete unused function.
11989 (Fx_own_selection_internal, Fx_get_selection_internal)
11990 (Fx_disown_selection_internal, Fx_selection_owner_p)
11991 (Fx_selection_exists_p): New optional frame arg.
11992 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11993 (x_handle_selection_clear): Don't treat other terminals with the
11994 same keyboard specially. Use the terminal-local Vselection_alist.
11995 (x_clear_frame_selections): Use Frun_hook_with_args.
11996
11997 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11998
11999 * xterm.h: Add support for those atoms.
12000
e067f0c1
CY
120012011-05-26 Chong Yidong <cyd@stupidchicken.com>
12002
12003 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12004 (converted_selections, conversion_fail_tag): New global variables.
12005 (x_selection_request_lisp_error): Free the above.
12006 (x_get_local_selection): Remove unnecessary code.
12007 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12008 of converted selections stored in converted_selections.
12009 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12010 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12011 (x_convert_selection): New function.
12012 (x_handle_selection_event): Simplify.
12013 (x_get_foreign_selection): Don't ignore incoming requests while
12014 waiting for an answer; this will fail when we implement
12015 SAVE_TARGETS, and seems unnecessary anyway.
12016 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12017 (Vx_sent_selection_functions): Doc fix.
12018
0f4aebc0
LL
120192011-05-26 Leo Liu <sdl.web@gmail.com>
12020
12021 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12022
e61124cd
YM
120232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12024
12025 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12026
12027 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12028 for fringe update if it has periodic bitmap.
ac389d0c 12029 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12030 and fringe_bitmap_periodic_p.
12031
12032 * fringe.c (get_fringe_bitmap_data): New function.
12033 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12034 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12035 row. Mark glyph row for fringe update if periodicity changed.
12036
12037 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12038 for fringe update unless it has periodic bitmap.
12039
f16d9837
KH
120402011-05-25 Kenichi Handa <handa@m17n.org>
12041
12042 * xdisp.c (get_next_display_element): Set correct it->face_id for
12043 a static composition.
12044
e1b90ef6
LL
120452011-05-24 Leo Liu <sdl.web@gmail.com>
12046
12047 * deps.mk (fns.o):
12048 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12049
12050 * fns.c (crypto_hash_function, Fsha1): New function.
12051 (Fmd5): Use crypto_hash_function.
12052 (syms_of_fns): Add Ssha1.
12053
7400048f
PE
120542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12055
12056 * gnutls.c: Remove unused macros.
12057 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12058 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12059 Remove macros that are defined and never used.
12060 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12061
abb71cf4
CY
120622011-05-22 Chong Yidong <cyd@stupidchicken.com>
12063
12064 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12065 (Fx_get_selection_internal): Minor cleanup.
12066 (Fx_own_selection_internal): Rename arguments for consistency with
12067 select.el.
12068
6307db39
PE
120692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12070
12071 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12072
f3d4e0a4
CY
120732011-05-22 Chong Yidong <cyd@stupidchicken.com>
12074
12075 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12076
4d8ade89
YM
120772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12078
12079 * dispnew.c (scrolling_window): Don't exclude the case that the
12080 last enabled row in the desired matrix touches the bottom boundary.
12081
32078c8d
GM
120822011-05-21 Glenn Morris <rgm@gnu.org>
12083
12084 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12085 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12086 and add some more files.
32078c8d 12087
7285dc67
EZ
120882011-05-20 Eli Zaretskii <eliz@gnu.org>
12089
12090 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12091 report_file_error introduced by the change from 2011-05-07.
12092
89d1bd22
PE
120932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12094
12095 * systime.h (Time): Define only if emacs is defined.
12096 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12097 where the include path doesn't have X11/X.h by default. See
12098 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12099
cd394be1 121002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12101
12102 * composite.c (find_automatic_composition): Fix previous change.
12103
b9704ad9
GM
121042011-05-20 Glenn Morris <rgm@gnu.org>
12105
12106 * lisp.mk: New file, split from Makefile.in.
12107 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12108 (shortlisp): Remove.
12109 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12110
4a720484
GM
121112011-05-19 Glenn Morris <rgm@gnu.org>
12112
12113 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12114 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12115 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12116 (lisp): Set the order to that of loadup.el.
12117 (shortlisp): Make it a copy of $lisp.
12118 (SOME_MACHINE_LISP): Remove.
12119 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12120 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12121
a28d4396
KH
121222011-05-18 Kenichi Handa <handa@m17n.org>
12123
12124 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12125 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12126 (find_automatic_composition): Mostly rewrite for efficiency.
12127
a2b1fa8e
JB
121282011-05-18 Juanma Barranquero <lekktu@gmail.com>
12129
12130 * makefile.w32-in: Update dependencies.
12131
8e1f5610
CS
121322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12133
12134 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12135 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12136
7025ee00 121372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12138
cdfa6eab
PE
12139 Fix some integer overflow issues, such as string length overflow.
12140
06d6db33
PE
12141 * insdel.c (count_size_as_multibyte): Check for string overflow.
12142
2b4560a8
PE
12143 * character.c (lisp_string_width): Check for string overflow.
12144 Use EMACS_INT, not int, for string indexes and lengths; in
12145 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12146 the resulting string length overflows an EMACS_INT; instead,
12147 report a string overflow if no precision given. When checking for
12148 precision exhaustion, use a check that cannot possibly have
12149 integer overflow. (Bug#8675)
12150 * character.h (lisp_string_width): Adjust to new signature.
12151
cb93f9be
PE
12152 * alloc.c (string_overflow): New function.
12153 (Fmake_string): Use it. This doesn't change behavior, but saves
12154 a few bytes and will simplify future changes.
12155 * character.c (string_escape_byte8): Likewise.
12156 * lisp.h (string_overflow): New decl.
12157
1a1f3366
PE
12158 Fixups, following up to the user-interface timestamp change.
12159 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12160 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12161 * msdos.c (mouse_get_pos): Likewise.
12162 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12163 * w32gui.h (Time): Define by including "systime.h" rather than by
12164 declaring it ourselves. (Bug#8664)
12165
d4e3e4d3
PE
12166 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12167 * image.c (clear_image_cache): Likewise.
12168
f6a24d19
PE
12169 * term.c (term_mouse_position): Don't assume time_t wraparound.
12170
08dc5ae6
PE
12171 Be more systematic about user-interface timestamps.
12172 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12173 and sometimes 'EMACS_UINT', to represent these timestamps.
12174 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12175 This makes the code easier to follow, and makes it easier to catch
12176 integer overflow bugs such as Bug#8664.
12177 * frame.c (Fmouse_position, Fmouse_pixel_position):
12178 Use Time, not unsigned long, for user-interface timestamps.
12179 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12180 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12181 * keyboard.h (last_event_timestamp): Likewise.
12182 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12183 * menu.h (xmenu_show): Likewise.
12184 * term.c (term_mouse_position): Likewise.
12185 * termhooks.h (struct input_event.timestamp): Likewise.
12186 (struct terminal.mouse_position_hook): Likewise.
12187 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12188 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12189 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12190 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12191 what it was before.
12192 * menu.h, termhooks.h: Include "systime.h", for Time.
12193
8e55734a
PE
12194 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12195 Don't assume that the difference between two unsigned long values
12196 can fit into an integer. At this point, we know button_down_time
12197 <= event->timestamp, so the difference must be nonnegative, so
12198 there's no need to cast the result if double-click-time is
12199 nonnegative, as it should be; check that it's nonnegative, just in
12200 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12201 apart (about 25 days). (Bug#8664)
8e55734a 12202
841f1b75 12203 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12204 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12205
3e26f69c
PE
12206 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12207 that always fit in int. Use a sentinel instead of a counter, to
12208 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12209 * frame.h (struct frame): Use int for menu_bar_items_used
12210 instead of EMACS_INT, since it always fits in int.
3e26f69c 12211
5cc152c0
PE
12212 * menu.c (grow_menu_items): Check for int overflow.
12213
d89eb65e
PE
12214 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12215
5235bd3e
PE
12216 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12217 Before, the code was not consistent. These values cannot exceed
12218 2**31 - 1 so there's no need to make them unsigned.
12219 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12220 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12221 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12222 as modifiers.
12223 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12224
bc827e23
PE
12225 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12226 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12227 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12228 presumably because the widths might not match.
12229
78eb494e
PE
12230 * window.c (size_window): Avoid needless test at loop start.
12231
04f2d78b
CB
122322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12233
12234 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12235
d2fc7e3d 122362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12237
12238 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12239
d2fc7e3d 122402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12241
12242 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12243 `width' to `bar_area_x' and `bar_area_width', respectively.
12244 (x_scroll_run): Take account of fringe background extension.
12245
04f2d78b
CB
12246 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12247 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12248 `bar_area_width', respectively.
12249 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12250 background extension.
12251
79b70037
GM
122522011-05-10 Jim Meyering <meyering@redhat.com>
12253
12254 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12255
2f142cc5
JB
122562011-05-10 Juanma Barranquero <lekktu@gmail.com>
12257
12258 * image.c (Finit_image_library): Return t for built-in image types,
12259 like pbm and xbm. (Bug#8640)
12260
57679c86
AS
122612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12262
12263 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12264
888c9e86
EZ
122652011-05-07 Eli Zaretskii <eliz@gnu.org>
12266
b0512a1d
EZ
12267 * w32console.c (Fset_screen_color): Doc fix.
12268 (Fget_screen_color): New function.
12269 (syms_of_ntterm): Defsubr it.
12270
7285dc67
EZ
12271 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12272 unlink the temporary file if Fcall_process didn't create it in the
12273 first place.
12274 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12275 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12276 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12277 cue to call_process_cleanup not to close that handle.
12278
4d3fcc8e
BK
122792011-05-07 Ben Key <bkey76@gmail.com>
12280
12281 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12282 one of two shell specific rules, either bootstrap-temacs-CMD or
12283 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12284 to the previous implementation of the bootstrap-temacs rule.
12285 The bootstrap-temacs-CMD rule is similar to the previous
12286 implementation of the bootstrap-temacs rule except that it
12287 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12288 variable.
12289
12290 These changes, along with some changes to nt/configure.bat,
12291 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12292 earlier fix to add support for --cflags and --ldflags options
12293 that include quotes so that it works whether make uses cmd or
12294 sh as the shell.
12295
b4289b64
MA
122962011-05-06 Michael Albinus <michael.albinus@gmx.de>
12297
12298 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12299 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12300 is a constant.
12301 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12302 a string. Handle both cases.
12303 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12304 (Fdbus_register_method): Use Qinvalid_function.
12305
af4c0e28
JB
123062011-05-06 Juanma Barranquero <lekktu@gmail.com>
12307
12308 * makefile.w32-in: Update dependencies.
12309 (LISP_H): Add inttypes.h and stdin.h.
12310 (PROCESS_H): Add unistd.h.
12311
c51453d9
EZ
123122011-05-06 Eli Zaretskii <eliz@gnu.org>
12313
12314 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12315 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12316
8ff0ac3c 123172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12318
4c4b566b
PE
12319 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12320
aab2b9b5
PE
12321 * term.c (vfatal): Remove stray call to va_end.
12322 It's not needed and the C Standard doesn't allow it here anyway.
12323
c378da0b
PE
12324 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12325 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12326
288b08c7
PE
12327 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12328 bytes.
12329
e3601888
PE
12330 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12331
db6c0e74
PE
12332 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12333
dd5963ea
PE
12334 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12335
88c9450f
PE
12336 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12337
2f9442b8
PE
12338 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12339
c032b5f8
PE
12340 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12341 * charset.c (Fdefine_charset_internal): Don't initialize
12342 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12343 32-bit int (Bug#8600).
a108c10b
PE
12344
12345 * lread.c (read_integer): Be more consistent with string-to-number.
12346 Use string_to_number to do the actual conversion; this avoids
12347 rounding errors and fixes some other screwups. Without this fix,
12348 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12349 (digit_to_number): Move earlier, for benefit of read_integer.
12350 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12351 not a digit in any supported base. (Bug#8602)
a108c10b 12352
ad5f9eea
PE
12353 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12354
aec1708a
PE
12355 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12356 to match comment at start of function. This also removes a
12357 GCC warning about overflow in a 32+64-bit port.
12358
47be4ab5
PE
12359 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12360
371cac43
PE
12361 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12362 Reported by Stefan Monnier in
12363 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12364 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12365 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12366
d01a7826
PE
12367 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12368 (EMACS_UINTPTR): Likewise, with uintptr_t.
12369
7fd47d5c
PE
12370 * lisp.h: Prefer 64-bit EMACS_INT if available.
12371 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12372 on 32-bit hosts that have 64-bit int, so that they can access
12373 large files.
122b0c86
PE
12374 However, temporarily disable this change unless the temporary
12375 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12376
8727937b
PE
12377 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12378
8ac068ac
PE
12379 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12380 This removes an assumption that EMACS_INT and long are the same
12381 width as pointers. The assumption is true for Emacs porting targets
12382 now, but we want to make other targets possible.
12383 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12384 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12385 In the rest of the code, change types of integers that hold casted
12386 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12387 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12388 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12389 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12390 No need to cast type when ORing.
12391 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12392 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12393 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12394 assume EMACS_INT is the same width as char *.
12395 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12396 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12397 Remove no-longer-needed casts.
12398 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12399 (xg_tool_bar_help_callback, xg_make_tool_item):
12400 Use EMACS_INTPTR to hold an integer
12401 that will be cast to void *; this can avoid a GCC warning
12402 if EMACS_INT is not the same width as void *.
12403 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12404 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12405 (current_message_1, set_message_1):
12406 Use a local to convert to proper width without a cast.
12407 * xmenu.c (dialog_selection_callback): Likewise.
12408
ede49d71
PE
12409 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12410 Also, don't assume VALBITS / RAND_BITS is less than 5,
12411 and don't rely on undefined behavior when shifting a 1 left into
12412 the sign bit.
12413 * lisp.h (get_random): Change signature to match.
12414
2f30ecd0
PE
12415 * lread.c (hash_string): Use size_t, not int, for hash computation.
12416 Normally we prefer signed values; but hashing is special, because
12417 it's better to use unsigned division on hash table sizes so that
12418 the remainder is nonnegative. Also, size_t is the natural width
12419 for hashing into memory. The previous code used 'int', which doesn't
12420 retain enough info to hash well into very large tables.
12421 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12422
2a866e7b
PE
12423 * dbusbind.c: Don't possibly lose pointer info when converting.
12424 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12425 Use XPNTR rather than XHASH, so that the high-order bits of
12426 the pointer aren't lost when converting through void *.
12427
51639eac
PE
12428 * eval.c (Fautoload): Don't double-shift a pointer.
12429
92394119
PE
12430 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12431
dbdb9a7c
JB
124322011-05-06 Juanma Barranquero <lekktu@gmail.com>
12433
12434 * gnutls.c (DEF_GNUTLS_FN):
12435 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12436
db7a0b4f
AS
124372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12438
12439 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12440 marker. (Bug#8610)
12441
cd394be1 124422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12443
12444 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12445 New version that can reserve upto 2GB of heap space.
12446
f7ff1b0f 124472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12448
12449 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12450
639c109b
TZ
124512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12452
12453 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12454 `gnutls_certificate_set_x509_key_file'.
12455
d2127135
JB
124562011-05-05 Juanma Barranquero <lekktu@gmail.com>
12457
12458 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12459 Update dependencies.
12460
e968f4f3
JB
124612011-05-04 Juanma Barranquero <lekktu@gmail.com>
12462
12463 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12464 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12465 Remove unused parameter `fildes'.
12466 * process.c (read_process_output, send_process): Don't pass it.
12467
84d358f0
JB
124682011-05-04 Juanma Barranquero <lekktu@gmail.com>
12469
12470 Fix previous change: the library cache is defined in w32.c.
12471 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12472 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12473
0898ca10
JB
124742011-05-04 Juanma Barranquero <lekktu@gmail.com>
12475
12476 Implement dynamic loading of GnuTLS on Windows.
12477
12478 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12479 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12480 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12481 Declare.
12482
12483 * gnutls.c (Qgnutls_dll): Define.
12484 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12485 (gnutls_*): Declare function pointers.
12486 (init_gnutls_functions): New function to initialize function pointers.
12487 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12488 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12489 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12490 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12491 (emacs_gnutls_write, emacs_gnutls_read)
12492 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12493 (Fgnutls_available_p): New function.
12494 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12495 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12496 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12497
12498 * image.c: Include w32.h.
12499 (Vimage_type_cache): Delete.
12500 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12501 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12502 (w32_delayed_load): Move to w32.c.
12503
12504 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12505
12506 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12507 (w32_delayed_load): Move from image.c. When loading a library, record
12508 its filename in the :loaded-from property of the library id.
12509 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12510 Initialize and staticpro them.
12511 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12512
12513 * process.c: Include lisp.h before w32.h, not after.
12514 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12515 instead of gnutls_record_check_pending.
12516
12517 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12518
ff4de4aa
TZ
125192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12520
12521 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12522 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12523 as passed in.
12524
abe95abb
JD
125252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12526
12527 * xterm.c (x_set_frame_alpha): Do not set property on anything
12528 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12529
e16e55d4
JB
125302011-05-02 Juanma Barranquero <lekktu@gmail.com>
12531
12532 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12533
bafcf6a5
JB
125342011-05-02 Juanma Barranquero <lekktu@gmail.com>
12535
12536 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12537 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12538 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12539 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12540 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12541 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12542 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12543 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12544 (Qgnutls_bootprop_callbacks_verify): Make static.
12545
e7a6747f
AS
125462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12547
19ed11ba
AS
12548 * callproc.c: Indentation fixup.
12549
e7a6747f 12550 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12551 (wait_for_termination, interruptible_wait_for_termination):
12552 Move after wait_for_termination_1.
e7a6747f 12553
1ef14cb4
LMI
125542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12555
12556 * sysdep.c (interruptible_wait_for_termination): New function
12557 which is like wait_for_termination, but allows keyboard
12558 interruptions.
12559
12560 * callproc.c (Fcall_process): Add (:file "file") as an option for
12561 the STDOUT buffer.
12562 (Fcall_process_region): Ditto.
12563
330d880c
EZ
125642011-04-30 Eli Zaretskii <eliz@gnu.org>
12565
8db90b73
EZ
12566 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12567 rather than `XVECTOR (FOO)->size'.
12568
330d880c
EZ
12569 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12570 inttypes.h, as a gnulib replacement is used if it not available in
12571 system headers.
12572
15cbd324
EZ
125732011-04-21 Eli Zaretskii <eliz@gnu.org>
12574
12575 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12576 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12577 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12578
12579 * coding.c (coding_alloc_by_realloc): Error out if destination
12580 will grow beyond MOST_POSITIVE_FIXNUM.
12581 (decode_coding_emacs_mule): Abort if there isn't enough place in
12582 charbuf for the composition carryover bytes. Reserve an extra
12583 space for up to 2 characters produced in a loop.
12584 (decode_coding_iso_2022): Abort if there isn't enough place in
12585 charbuf for the composition carryover bytes.
12586
125872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12588
ae940cca
EZ
12589 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12590 aborting when %lld or %lll format is passed.
12591 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12592 %llo or %llx format is passed. (Bug#8545)
12593
03ab8921
EZ
12594 * window.c (window_scroll_line_based): Use a marker instead of
12595 simple variables to record original value of point. (Bug#7952)
12596
afda1437
EZ
12597 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12598 produced by %s or %c overflows available buffer space. (Bug#8545)
12599
f76dee0c
PE
126002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12601
12602 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12603 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12604
fdc5744d
JB
126052011-04-28 Juanma Barranquero <lekktu@gmail.com>
12606
12607 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12608
638f053a
JB
126092011-04-28 Juanma Barranquero <lekktu@gmail.com>
12610
12611 * keyboard.c (Qdelayed_warnings_hook): Define.
12612 (command_loop_1): Run `delayed-warnings-hook'
12613 if Vdelayed_warnings_list is non-nil.
12614 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12615 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12616
d178f871
EZ
126172011-04-28 Eli Zaretskii <eliz@gnu.org>
12618
12619 * doprnt.c (doprnt): Don't return value smaller than the buffer
12620 size if the message was truncated. (Bug#8545).
12621
b124fd93
JB
126222011-04-28 Juanma Barranquero <lekktu@gmail.com>
12623
12624 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12625 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12626
e810457d
PE
126272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12628
12629 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12630
ea51cceb
JB
126312011-04-27 Juanma Barranquero <lekktu@gmail.com>
12632
12633 * makefile.w32-in: Update dependencies.
12634
94dcfacf
EZ
126352011-04-27 Eli Zaretskii <eliz@gnu.org>
12636
12637 Improve `doprnt' and its usage. (Bug#8545)
12638 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12639 `format_end'. Remove support for %l as a conversion specifier.
12640 Don't use xrealloc. Improve diagnostics when the %l size modifier
12641 is used. Update the commentary.
12642
12643 * eval.c (verror): Simplify calculation of size_t.
12644
12645 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12646 messages.
12647
f61f41d7
PE
126482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12649
12650 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12651 change.
12652
96fb4434
PE
126532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12654
12655 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12656 This makes this file independent of the recent pseudovector change.
12657
671875da 126582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12659
69e9b5a3
PE
12660 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12661
b5f869a7 12662 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12663 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12664 Remove unused local.
c8926152 12665 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12666
841a1577 12667 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12668 GCC 4.6.0 optimizes based on type-based alias analysis.
12669 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12670 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12671 != &v->size, and therefore "v->size = 1; b->size = 2; return
12672 v->size;" must therefore return 1. This assumption is incorrect
12673 for Emacs, since it type-puns struct Lisp_Vector * with many other
12674 types. To fix this problem, this patch adds a new type struct
f904488f 12675 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12676 and pseudovectors, and helps optimizing compilers not get fooled
12677 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12678 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12679 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12680 the size member.
eab3844f
PE
12681 (XSETPVECTYPE): Rewrite in terms of new macro.
12682 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12683 This is a bit clearer, and further avoids the possibility of
12684 undesirable aliasing.
12685 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12686 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12687 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12688 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12689 (ASIZE): Now uses header.size rather than size.
12690 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12691 to avoid the hassle of writing XVECTOR (foo)->header.size.
12692 (struct vectorlike_header): New type.
eab3844f
PE
12693 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12694 object, to help avoid aliasing.
12695 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12696 (SUBRP): Likewise, since Lisp_Subr is a special case.
12697 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12698 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12699 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12700 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12701 changed to be "header.size" and "header.next".
12702 * buffer.h (struct buffer): Likewise.
12703 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12704 * frame.h (struct frame): Likewise.
12705 * process.h (struct Lisp_Process): Likewise.
12706 * termhooks.h (struct terminal): Likewise.
12707 * window.c (struct save_window_data, struct saved_window): Likewise.
12708 * window.h (struct window): Likewise.
12709 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12710 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12711 * buffer.c (init_buffer_once): Likewise.
12712 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12713 special case.
12714 * process.c (Fformat_network_address): Use local var for size,
12715 for brevity.
12716
0df1eac5
PE
12717 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12718
847ab9d1 12719 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12720 * data.c (atof): Remove decl; no longer used or needed.
12721 (digit_to_number): Move to lread.c.
12722 (Fstring_to_number): Use new string_to_number function, to be
12723 consistent with how the Lisp reader treats infinities and NaNs.
12724 Do not assume that floating-point numbers represent EMACS_INT
12725 without losing information; this is not true on most 64-bit hosts.
12726 Avoid double-rounding errors, by insisting on integers when
12727 parsing non-base-10 numbers, as the documentation specifies.
12728 * lisp.h (string_to_number): New decl, replacing ...
12729 (isfloat_string): Remove.
bc0a5c13 12730 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12731 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12732 appears to have been a coding error. Similarly, do not accept
12733 strings like +-1e0 as floating point numbers. Do not report
12734 overflow for integer overflows unless the base is not 10 which
12735 means we have no simple and reliable way to continue.
12736 Break out the floating-point parsing into a new
12737 function string_to_number, so that Fstring_to_number parses
12738 floating point numbers consistently with the Lisp reader.
04f2d78b 12739 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12740 (E_CHAR, EXP_INT): Remove, replacing with ...
12741 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12742 (string_to_number): New function, replacing isfloat_string.
12743 This function checks for valid syntax and produces the resulting
12744 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12745 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12746 so that overflow for non-base-10 numbers is reported only when
12747 there's no portable and simple way to convert to floating point.
452f4150 12748
67769ffc
PE
12749 * textprop.c (set_text_properties_1): Rewrite for clarity,
12750 and to avoid GCC warning about integer overflow.
12751
c20db43f
PE
12752 * intervals.h (struct interval): Use EMACS_INT for members
12753 where EMACS_UINT might cause problems. See
12754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12755 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12756 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12757 All uses changed.
37aa2f85
PE
12758 (offset_intervals): Tell GCC not to worry about length overflow
12759 when negating a negative length.
c20db43f 12760
2538aa2f
PE
12761 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12762 (overrun_check_free): Likewise.
12763
f2d3008d
PE
12764 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12765 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12766 word size.
12767
ec8df744
PE
12768 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12769 (gnutls_make_error): Rename local to avoid shadowing.
12770 (gnutls_emacs_global_deinit): ifdef out; not used.
12771 (Fgnutls_boot): Use const for pointer to readonly storage.
12772 Comment out unused local. Fix pointer signedness problems.
12773
640ee02d
PE
12774 * lread.c (openp): Don't stuff size_t into an 'int'.
12775 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12776 about possible signed overflow.
12777
6048fb2a
PE
12778 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12779 (GDK_KEY_g): Don't define if already defined.
12780 (xg_prepare_tooltip): Avoid pointer signedness problem.
12781 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12782
fa3c87e1
PE
12783 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12784 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12785
2172544b
PE
12786 * xfns.c (Fx_window_property): Simplify a bit,
12787 to make a bit faster and to avoid GCC 4.6.0 warning.
12788 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12789
9b821a21
PE
12790 * fns.c (internal_equal): Don't assume size_t fits in int.
12791
3c616cfa
PE
12792 * alloc.c (compact_small_strings): Tighten assertion a little.
12793
c2982e87
PE
12794 Replace pEd with more-general pI, and fix some printf arg casts.
12795 * lisp.h (pI): New macro, generalizing old pEd macro to other
12796 conversion specifiers. For example, use "...%"pI"d..." rather
12797 than "...%"pEd"...".
12798 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12799 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12800 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12801 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12802 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12803 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12804 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12805 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12806 64-bit hosts.
12807 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12808 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12809 * print.c (safe_debug_print, print_object): Likewise.
12810 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12811 to int.
6f04d126
PE
12812 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12813 avoiding the 0 flag, which is not portable.
c2982e87
PE
12814 * process.c (Fmake_network_process): Use pI to avoid cast.
12815 * region-cache.c (pp_cache): Likewise.
12816 * xdisp.c (decode_mode_spec): Likewise.
12817 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12818 behavior on 64-bit hosts with printf arg.
6f04d126 12819 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12820 (x_stop_queuing_selection_requests): Likewise.
12821 (x_get_window_property): Don't truncate byte count to an 'int'
12822 when tracing.
0b432f21 12823
5e073ec7
PE
12824 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12825 here, since it parses constructs like leading '-' and spaces,
12826 which are not wanted; and it overflows with large numbers.
12827 Instead, simply match F[0-9]+, which is what is wanted anyway.
12828
36372bf9
PE
12829 * alloc.c: Remove unportable assumptions about struct layout.
12830 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12831 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12832 (allocate_vectorlike, make_pure_vector): Use the new macros,
12833 plus offsetof, to remove unportable assumptions about struct layout.
12834 These assumptions hold on all porting targets that I know of, but
12835 they are not guaranteed, they're easy to remove, and removing them
12836 makes further changes easier.
12837
0b432f21
PE
12838 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12839 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12840 (string_overrun_cookie): Now const. Use initializers that
12841 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12842 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12843 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12844 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12845 multiple of sizeof (EMACS_INT); it need not be, if
12846 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12847 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12848
895009e1
JB
128492011-04-26 Juanma Barranquero <lekktu@gmail.com>
12850
12851 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12852
6a7a1b0b
TZ
128532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12854
12855 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12856 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12857 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12858
841a1577 128592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12860
12861 * lisp.h (Qdebug): List symbol.
895009e1 12862 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12863 * keyboard.c (debug-on-event): New variable.
12864 (handle_user_signal): Break into debugger when debug-on-event
12865 matches the current signal symbol.
12866
f2d3ba6f
DN
128672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12868
12869 * alloc.c (check_sblock, check_string_bytes)
12870 (check_string_free_list): Convert to standard C.
12871
42ce4c63
TZ
128722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12873
12874 * w32.c (emacs_gnutls_push): Fix typo.
12875
825cd63c
EZ
128762011-04-25 Eli Zaretskii <eliz@gnu.org>
12877
fb11d64d
EZ
12878 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12879 "cast to pointer from integer of different size".
12880
825cd63c
EZ
12881 Improve doprnt and its use in verror. (Bug#8545)
12882 * doprnt.c (doprnt): Document the set of format control sequences
12883 supported by the function. Use SAFE_ALLOCA instead of always
12884 using `alloca'.
12885
12886 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12887 is one byte too soon. Don't use xrealloc; instead xfree and
12888 xmalloc anew.
12889
e061a11b
TZ
128902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12891
12892 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12893 callbacks stage.
12894
12895 * gnutls.c: Renamed global_initialized to
12896 gnutls_global_initialized. Added internals for the
12897 :verify-hostname-error, :verify-error, and :verify-flags
12898 parameters of `gnutls-boot' and documented those parameters in the
12899 docstring. Start callback support.
9173deec
JB
12900 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12901 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12902 on error. Return error code.
e061a11b
TZ
12903 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12904 (emacs_gnutls_read): Likewise.
12905 (Fgnutls_boot): Return handshake error code.
12906 (emacs_gnutls_handle_error): New function.
12907 (wsaerror_to_errno): Likewise.
12908
12909 * w32.h (emacs_gnutls_pull): Add prototype.
12910 (emacs_gnutls_push): Likewise.
12911
12912 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12913 (emacs_gnutls_push): Likewise.
12914
129152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12916
12917 * process.c (wait_reading_process_output): Check if GnuTLS
12918 buffered some data internally if no FDs are set for TLS
12919 connections.
12920
12921 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12922 (LIBS): Link to USER_LIBS.
12923 ($(BLD)/gnutls.$(0)): New target.
12924
fa6996bc
EZ
129252011-04-24 Eli Zaretskii <eliz@gnu.org>
12926
eb35682e
EZ
12927 * xdisp.c (handle_single_display_spec): Rename the
12928 display_replaced_before_p argument into display_replaced_p, to
12929 make it consistent with the commentary. Fix typos in the
12930 commentary.
12931
e2ad650c
EZ
12932 * textprop.c (syms_of_textprop): Remove dead code.
12933 (copy_text_properties): Delete obsolete commentary about an
12934 interface that was deleted long ago. Fix typos in the description
12935 of arguments.
12936
1b2de274
EZ
12937 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12938 to changes in oldXMenu/XMenu.h from 2011-04-16.
12939 <menu_help_message, prev_menu_help_message>: Constify.
12940 (IT_menu_make_room): menu->help_text is now `const char **';
12941 adjust.
12942
12943 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12944 to changes in oldXMenu/XMenu.h from 2011-04-16.
12945 (struct XMenu): Declare `help_text' `const char **'.
12946
12947 * xfaces.c <Qunspecified>: Make extern again.
12948
12949 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12950 required by POSIX.
1b2de274 12951
762b15be
EZ
12952 * doc.c (get_doc_string): Improve the format passed to `error'.
12953
12954 * doprnt.c (doprnt): Improve commentary.
12955
12956 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12957
12958 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12959 them with etags.
12960
f1052e5d
EZ
12961 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12962 changes in globals.h immediately force recompilation.
762b15be
EZ
12963 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12964 $(CURDIR)/s/ms-w32.h.
12965 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12966
fa6996bc
EZ
12967 * character.c (Fchar_direction): Function deleted.
12968 (syms_of_character): Don't defsubr it.
12969 <char-direction-table>: Deleted.
12970
e6c3da20
EZ
129712011-04-23 Eli Zaretskii <eliz@gnu.org>
12972
12973 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12974 * doprnt.c: Include limits.h.
12975 (SIZE_MAX): New macro.
04f2d78b
CB
12976 (doprnt): Return a size_t value. 2nd arg is now size_t.
12977 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12978 Improve overflow protection. Support `l' modifier for integer
12979 conversions. Support %l conversion. Don't assume an EMACS_INT
12980 argument for integer conversions and for %c.
12981
12982 * lisp.h (doprnt): Restore prototype.
12983
12984 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12985 $(SRC)/character.h.
12986
12987 * Makefile.in (base_obj): Add back doprnt.o.
12988
12989 * deps.mk (doprnt.o): Add back prerequisites.
12990 (callint.o): Depend on character.h.
12991
12992 * eval.c (internal_lisp_condition_case): Include the handler
12993 representation in the error message.
12994 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12995 when breaking from the loop.
12996
12997 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12998
12999 * callint.c (Fcall_interactively): When displaying error message
13000 about invalid control letter, pass the character's codepoint, not
13001 a pointer to its multibyte form. Improve display of the character
13002 in octal and display also its hex code.
13003
13004 * character.c (char_string): Use %x to display the (unsigned)
13005 codepoint of an invalid character, to avoid displaying a bogus
13006 negative value.
13007
13008 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13009 `error', not SYMBOL_NAME itself.
13010
13011 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13012 character arguments to `error'.
13013
13014 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13015 to `error' in error message about FINAL_CHAR argument. Make sure
13016 FINAL_CHAR is a character, and use %c when it is passed as
13017 argument to `error'.
13018
4ffd0d6b 130192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13020
13021 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13022
13023 * w32.c: Include <time.h>.
13024 (sys_localtime): New function.
13025
4ffd0d6b 130262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13027
13028 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13029
4ffd0d6b 13030 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13031
4ffd0d6b 130322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13033
4ffd0d6b
GM
13034 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13035 zombies (Bug#8467).
aac0c6e3 13036
04c56954
EZ
130372011-04-19 Eli Zaretskii <eliz@gnu.org>
13038
13039 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13040 gl_state.e_property when gl_state.object is Qt.
13041
13042 * insdel.c (make_gap_larger): Remove limitation of buffer size
13043 to <= INT_MAX.
13044
16a43933
CY
130452011-04-18 Chong Yidong <cyd@stupidchicken.com>
13046
13047 * xdisp.c (lookup_glyphless_char_display)
13048 (produce_glyphless_glyph): Handle cons cell entry in
13049 glyphless-char-display.
13050 (Vglyphless_char_display): Document it.
13051
13052 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13053 glyphless-char-display.
13054
4581706e
CY
130552011-04-17 Chong Yidong <cyd@stupidchicken.com>
13056
13057 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13058
13059 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13060
13061 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13062 definition for no-X builds.
13063
4887c6e2 130642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13065
fd35b6f9
PE
13066 Static checks with GCC 4.6.0 and non-default toolkits.
13067
5c1ccb01
PE
13068 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13069
006c5daa
PE
13070 * process.c (keyboard_bit_set): Define only if SIGIO.
13071 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13072 (send_process): Repair possible setjmp clobbering.
13073
efc736d3
PE
13074 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13075
4e2fe2e6
PE
13076 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13077
f97334a2
PE
13078 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13079
4e75f29d
PE
13080 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13081 Define only if needed.
13082
90efadd1
PE
13083 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13084 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13085 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13086
3c647824
PE
13087 * dispextern.h (struct redisplay_interface): Rename param
13088 to avoid shadowing.
e264f262 13089 * termhooks.h (struct terminal): Likewise.
761383f4 13090 * xterm.c (xembed_send_message): Likewise.
3c647824 13091
b58c5c4a
PE
13092 * insdel.c (make_gap_smaller): Define only if
13093 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13094
cad59032
PE
13095 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13096 it.
13097
c339dc2e
PE
13098 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13099 so that we aren't warned about unused symbols.
13100
91a3e27b
PE
13101 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13102
399c71d3 13103 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13104
8ffc96f5
PE
13105 * xfns.c (x_real_positions): Mark locals as initialized.
13106
eef9bc79
PE
13107 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13108
098db9dd
PE
13109 * xterm.c: Fix problems found by static analysis with other toolkits.
13110 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13111 (x_dispatch_event): Declare static if USE_GTK, and
13112 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13113 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13114 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13115 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13116 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13117
eb18f6cc
PE
13118 * xmenu.c (menu_help_callback): Pointer type fixes.
13119 Use const pointers when pointing at readonly data. Avoid pointer
13120 signedness clashes.
13121 (FALSE): Remove unused macro.
13122 (update_frame_menubar): Remove unused decl.
13123
1fe72bf8
PE
13124 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13125
60d9e1db
PE
13126 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13127 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13128 (single_menu_item): Rename local to avoid shadowing.
13129
39261c26
PE
13130 * keyboard.c (make_lispy_event): Remove unused local var.
13131
018c5e19
PE
13132 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13133 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13134
63d2b86e
PE
13135 * bitmaps: Change bitmaps from unsigned char back to the X11
13136 compatible char. Avoid the old compiler warnings about
13137 out-of-range initializers by using, for example, '\xab' rather
13138 than 0xab.
13139
aefd87e1
PE
13140 * xgselect.c (xgselect_initialize): Check vs interface
13141 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13142
bf501fb9
PE
13143 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13144
e9829fdf
PE
13145 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13146 to read-only memory.
13147
1086c095
PE
13148 * fns.c (vector): Remove; this old hack is no longer needed.
13149
2baccd04 13150 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13151 Remove unused var.
dde42981 13152 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13153
72391843 13154 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13155
436c16df 13156 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13157 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13158 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13159
92bb796d 13160 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13161 (x_term_init): Remove local to avoid shadowing.
92bb796d 13162
764430a3 13163 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13164
13165 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13166 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13167
d1dfb56c
EZ
131682011-04-16 Eli Zaretskii <eliz@gnu.org>
13169
c4354cb4
EZ
13170 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13171
d1dfb56c
EZ
13172 Fix regex.c, syntax.c and friends for buffers > 2GB.
13173 * syntax.h (struct gl_state_s): Declare character position members
13174 EMACS_INT.
13175
13176 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13177
04f2d78b
CB
13178 * textprop.c (verify_interval_modification, interval_of):
13179 Declare arguments EMACS_INT.
d1dfb56c
EZ
13180
13181 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13182 EMACS_INT.
13183
13184 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13185
13186 * indent.c (Fvertical_motion): Local variable it_start is now
13187 EMACS_INT.
13188
13189 * regex.c (re_match, re_match_2, re_match_2_internal)
13190 (bcmp_translate, regcomp, regexec, print_double_string)
13191 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13192 (re_compile_pattern, re_exec): Declare arguments and local
13193 variables `size_t' and `ssize_t' and return values `regoff_t', as
13194 appropriate.
13195 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13196 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13197 <compile_stack_type>: `size' and `avail' are now `size_t'.
13198
13199 * regex.h <regoff_t>: Use ssize_t, not int.
13200 (re_search, re_search_2, re_match, re_match_2): Arguments that
13201 specify buffer/string position and length are now ssize_t and
13202 size_t. Return type is regoff_t.
13203
613052cd
BK
132042011-04-16 Ben Key <bkey76@gmail.com>
13205
13206 * nsfont.m: Fixed bugs in ns_get_family and
13207 ns_descriptor_to_entity that were caused by using free to
13208 deallocate memory blocks that were allocated by xmalloc (via
13209 xstrdup). This caused Emacs to crash when compiled with
13210 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13211 --enable-checking=xmallocoverrun). xfree is now used to
13212 deallocate these memory blocks.
13213
4170f62f 132142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13215
71b41406
PE
13216 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13217
9587a89d
PE
13218 emacs_write: Accept and return EMACS_INT for sizes.
13219 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13220 et seq.
13221 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13222 Accept and return EMACS_INT.
13223 (emacs_gnutls_write): Return the number of bytes written on
13224 partial writes.
13225 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13226 (emacs_read, emacs_write): Remove check for negative size, as the
13227 Emacs source code has been audited now.
9587a89d
PE
13228 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13229 (emacs_read, emacs_write): Use it.
273a5f82
PE
13230 * process.c (send_process): Adjust to the new signatures of
13231 emacs_write and emacs_gnutls_write. Do not attempt to store
13232 a byte offset into an 'int'; it might overflow.
9587a89d 13233 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13234
3e047f51
PE
13235 * sound.c: Don't assume sizes fit in 'int'.
13236 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13237 Return EMACS_INT, not int.
3e047f51 13238 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13239 Accept EMACS_INT, not int.
13240 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13241 record read return values.
13242
cc39a9db
BK
132432011-04-15 Ben Key <bkey76@gmail.com>
13244
c9d0ec6d
JB
13245 * keyboard.c (Qundefined): Don't declare static since it is used
13246 in nsfns.m.
13247 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13248 static since they are used in nsfont.m.
cc39a9db 13249
6c60eb9f
SM
132502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13251
13252 * process.c (Qprocessp): Don't declare static.
13253 * lisp.h (Qprocessp): Declare again.
13254
7990b61a
JB
132552011-04-15 Juanma Barranquero <lekktu@gmail.com>
13256
13257 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13258
5d4cb038
PE
132592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13260
8bd7b830 13261 Improve C-level modularity by making more things 'static'.
cd64ea1d 13262
e3b27b31
PE
13263 Don't publish debugger-only interfaces to other modules.
13264 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13265 (verify_bytepos, count_markers): Move decls to the only modules
13266 that need them.
13267 * region-cache.h (pp_cache): Likewise.
13268 * window.h (check_all_windows): Likewise.
13269 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13270
5d4cb038
PE
13271 * sysdep.c (croak): Now static, if
13272 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13273 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13274
13275 * alloc.c (refill_memory_reserve): Now static if
13276 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13277 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13278
e87b6180
PE
13279 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13280 Define only if USE_LUCID.
13281
ac64929e
PE
13282 * xrdb.c (x_customization_string, x_rm_string): Now static.
13283
6f37259d
PE
13284 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13285 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13286
1683e3ab
PE
13287 * xdisp.c (draw_row_with_mouse_face): Now static.
13288 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13289
de9c2632
PE
13290 * window.h (check_all_windows): Mark externally visible.
13291
2b96acb7
PE
13292 * window.c (window_deletion_count): Now static.
13293
13294 * undo.c: Make symbols static if they're not exported.
13295 (last_undo_buffer, last_boundary_position, pending_boundary):
13296 Now static.
13297
50436f33
PE
13298 * textprop.c (interval_insert_behind_hooks): Now static.
13299 (interval_insert_in_front_hooks): Likewise.
13300
64520e5c
PE
13301 * term.c: Make symbols static if they're not exported.
13302 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13303 (max_frame_lines, tty_set_terminal_modes):
13304 (tty_reset_terminal_modes, tty_turn_off_highlight):
13305 (get_tty_terminal): Now static.
13306 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13307 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13308 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13309 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13310 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13311
1fa53021
PE
13312 * sysdep.c: Make symbols static if they're not exported.
13313 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13314 Now static.
13315 (sigprocmask_set, full_mask): Remove; unused.
13316 (wait_debugging): Mark as visible.
13317 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13318 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13319
d4b43b22
PE
13320 * syntax.c (syntax_temp): Define only if !__GNUC__.
13321
b7c513d0
PE
13322 * sound.c (current_sound_device, current_sound): Now static.
13323
989b29ad
PE
13324 * search.c (searchbufs, searchbuf_head): Now static.
13325
13a55a78
PE
13326 * scroll.c (scroll_cost): Remove; unused.
13327 * dispextern.h (scroll_cost): Remove decl.
13328
de68a1fc
PE
13329 * region-cache.h (pp_cache): Mark as externally visible.
13330
40ccffa6
PE
13331 * process.c: Make symbols static if they're not exported.
13332 (process_tick, update_tick, create_process, chan_process):
13333 (Vprocess_alist, proc_buffered_char, datagram_access):
13334 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13335 (deactivate_process): Mark defn as static, as well as decl.
13336 * lisp.h (create_process): Remove decl.
13337 * process.h (chan_process, Vprocess_alist): Remove decls.
13338
ad64fc97
PE
13339 * print.c: Make symbols static if they're not exported.
13340 (print_depth, new_backquote_output, being_printed, print_buffer):
13341 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13342 (print_interval, print_number_index, initial_stderr_stream):
13343 Now static.
13344 * lisp.h (Fprinc): Remove decl.
13345 (debug_output_compilation_hack): Mark as externally visible.
13346
adddb265
PE
13347 * sysdep.c (croak): Move decl from here to syssignal.h.
13348 * syssignal.h (croak): Put it here, so the API can be checked when
13349 'croak' is called from dissociate_if_controlling_tty.
13350
1717ede2
PE
13351 * minibuf.c: Make symbols static if they're not exported.
13352 (minibuf_save_list, choose_minibuf_frame): Now static.
13353 * lisp.h (choose_minibuf_frame): Remove decl.
13354
fa5fb2bc
PE
13355 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13356
1e3890d1
PE
13357 * lread.c: Make symbols static if they're not exported.
13358 (read_objects, initial_obarray, oblookup_last_bucket_number):
13359 Now static.
13360 (make_symbol): Remove; unused.
13361 * lisp.h (initial_obarray, make_symbol): Remove decls.
13362
8a1414fa
PE
13363 * keyboard.c: Make symbols static if they're not exported.
13364 (single_kboard, recent_keys_index, total_keys, recent_keys):
13365 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13366 (this_single_command_key_start, echoing, last_auto_save):
13367 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13368 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13369 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13370 (Vlispy_mouse_stem, double_click_count):
13371 Now static.
13372 (force_auto_save_soon): Define only if SIGDANGER.
13373 (ignore_mouse_drag_p): Now static if
13374 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13375 (print_help): Remove; unused.
13376 (stop_character, last_timer_event): Mark as externally visible.
13377 * keyboard.h (ignore_mouse_drag_p): Declare only if
13378 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13379 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13380 * lisp.h (echoing): Remove decl.
13381 (force_auto_save_soon): Declare only if SIGDANGER.
13382 * xdisp.c (redisplay_window): Simplify code, to make it more
13383 obvious that ignore_mouse_drag_p is not accessed if !defined
13384 USE_GTK && !defined HAVE_NS.
13385
93ea6e8f
PE
13386 * intervals.c: Make symbols static if they're not exported.
13387 (merge_properties_sticky, merge_interval_right, delete_interval):
13388 Now static.
13389 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13390
77382fcc
PE
13391 * insdel.c: Make symbols static if they're not exported.
13392 However, leave prepare_to_modify_buffer alone. It's never
13393 called from outside this function, but that appears to be a bug.
13394 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13395 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13396 (adjust_after_replace_noundo): Remove; unused.
13397 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13398 (signal_before_change): Remove decls.
77382fcc 13399
9306c32e
PE
13400 * indent.c (val_compute_motion, val_vmotion): Now static.
13401
cd44d2eb
PE
13402 * image.c: Make symbols static if they're not exported.
13403 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13404 if USE_GTK.
13405 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13406 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13407
ad9a7a06
PE
13408 * fringe.c (standard_bitmaps): Now static.
13409 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13410
81626931
PE
13411 * frame.c: Make symbols static if they're not exported.
13412 (x_report_frame_params, make_terminal_frame): Now static.
13413 (get_frame_param): Now static, unless HAVE_NS.
13414 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13415 (x_get_resource_string): Remove; not used.
13416 * frame.h (make_terminal_frame, x_report_frame_params):
13417 (x_get_resource_string); Remove decls.
13418 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13419 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13420
239f9db9
PE
13421 * font.c, fontset.c: Make symbols static if they're not exported.
13422 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13423 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13424 * font.c (font_close_object): Now static.
13425 * font.h (font_close_object): Remove.
13426 * fontset.c (FONTSET_OBJLIST): Remove.
13427 (free_realized_fontset) #if-0 the body, which does nothing.
13428 (face_suitable_for_char_p): #if-0, as it's never called.
13429 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13430 * xfaces.c (face_at_string_position):
13431 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13432 since 0 is always ASCII.
13433
dfcf3579
PE
13434 * fns.c (weak_hash_tables): Now static.
13435
5045092b
PE
13436 * fileio.c: Make symbols static if they're not exported.
13437 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13438 (Vwrite_region_annotation_buffers): Now static.
13439
57a96f5c
PE
13440 * eval.c: Make symbols static if they're not exported.
13441 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13442 * lisp.h (backtrace_list): Remove decl.
13443
35f08c38
PE
13444 * emacs.c: Make symbols static if they're not exported.
13445 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13446 (fatal_error_code, fatal_error_signal_hook, standard_args):
13447 Now static.
13448 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13449 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13450 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13451 * lisp.h (fatal_error_signal_hook): Remove decl.
13452 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13453
f44bd759
PE
13454 * editfns.c: Move a (normally-unused) function to its only use.
13455 * editfns.c, lisp.h (get_operating_system_release): Remove.
13456 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13457 worth the hassle of breaking this out.
13458
b532497d
PE
13459 * xterm.c: Make symbols static if they're not exported.
13460 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13461 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13462 (x_destroy_window, x_delete_display):
13463 Now static.
13464 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13465 (x_mouse_leave): Remove; unused.
13466 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13467 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13468 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13469 Remove decls.
13470 (x_mouse_leave): Declare only if WINDOWSNT.
13471 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13472 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13473 USE_X_TOOLKIT.
13474
1675728f
PE
13475 * ftxfont.c: Make symbols static if they're not exported.
13476 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13477 HAVE_FREETYPE.
13478 * font.h (ftxfont_driver): Likewise.
13479
e4cebfca
PE
13480 * xfns.c: Make symbols static if they're not exported.
13481 (x_last_font_name, x_display_info_for_name):
13482 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13483 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13484 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13485 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13486 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13487 (last_show_tip_args): Now static.
13488 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13489 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13490 (x_screen_planes): Remove; unused.
13491 * dispextern.h (x_screen_planes): Remove decl.
13492
5bf46f05
PE
13493 * dispnew.c: Make symbols static if they're not exported.
13494 * dispextern.h (redraw_garbaged_frames, scrolling):
13495 (increment_row_positions): Remove.
13496 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13497 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13498 Now static.
13499 (redraw_garbaged_frames): Remove; unused.
13500
435f4c28
PE
13501 * xfaces.c: Make symbols static if they're not exported.
13502 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13503 Remove decls.
13504 * xterm.h (defined_color): Remove decls.
13505 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13506 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13507 (menu_face_changed_default, defined_color, free_realized_face):
13508 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13509 (ascii_face_of_lisp_face): Remove; unused.
13510
8524aef3
PE
13511 * xdisp.c: Make symbols static if they're not exported.
13512 * dispextern.h (scratch_glyph_row, window_box_edges):
13513 (glyph_to_pixel_coords, set_cursor_from_row):
13514 (get_next_display_element, set_iterator_to_next):
13515 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13516 (show_mouse_face): Remove decls
13517 * frame.h (message_buf_print): Likewise.
13518 * lisp.h (pop_message, set_message, check_point_in_composition):
13519 Likewise.
13520 * xterm.h (set_vertical_scroll_bar): Likewise.
13521 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13522 (message_buf_print, scratch_glyph_row, displayed_buffer):
13523 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13524 (get_next_display_element, show_mouse_face, window_box_edges):
13525 (frame_to_window_pixel_xy, check_point_in_composition):
13526 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13527 (glyph_to_pixel_coords): Remove; unused.
13528
16390cd2
PE
13529 * dired.c (file_name_completion): Now static.
13530
13531 * dbusbind.c (xd_in_read_queued_messages): Now static.
13532
a25f4dfa
PE
13533 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13534 * data.c (circular_list_error): Remove.
13535
14a9c8df
PE
13536 * commands.h (last_point_position, last_point_position_buffer):
13537 (last_point_position_window): Remove decls.
13538 * keyboard.c: Make these variables static.
13539
04f2d78b
CB
13540 * coding.h (coding, code_convert_region, encode_coding_gap):
13541 Remove decls.
74ab6df5
PE
13542 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13543 (iso_code_class, detect_coding, code_convert_region): Now static.
13544 (encode_coding_gap): Remove; unused.
13545
38dfbee1
PE
13546 * chartab.c (chartab_chars, chartab_bits): Now static.
13547
a2cb4e63
PE
13548 * charset.h (charset_iso_8859_1): Remove decl.
13549 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13550 Now static.
13551
127198fd
PE
13552 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13553 * ccl.c (Vccl_program_table): Now static.
13554 (check_ccl_update): Remove; unused.
13555
d85b608f
PE
13556 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13557 * category.h: ... from here.
13558 * category.c (check_category_table, set_category_set): Now static.
13559
31cd66f3
PE
13560 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13561 * lisp.h: Remove these decls.
13562
c358e587
PE
13563 * buffer.c (buffer_count): Remove unused var.
13564
e78aecca
PE
13565 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13566 so that it's not optimized away.
13567 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13568 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13569 exported only to the debugger.
13570
e192d7d3 13571 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13572 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13573
92470028
PE
13574 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13575 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13576 was inaccessible from Lisp.
13577 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13578 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13579
244ed907
PE
13580 alloc.c: Import and export fewer symbols, and remove unused items.
13581 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13582 is defined.
13583 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13584 it's not optimized away by whole-program optimization.
13585 (message_enable_multibyte, free_misc): Remove.
13586 (catchlist, handlerlist, mark_backtrace):
13587 Declare only if BYTE_MARK_STACK.
13588 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13589 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13590 (message_enable_multibyte): Remove decl.
13591 (free_misc, interval_free_list, float_block, float_block_index):
13592 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13593 (cons_free_list, last_marked_index):
13594 Now static.
13595 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13596 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13597 (mark_backtrace): Define only if BYTE_MARK_STACK.
13598 * xdisp.c (message_enable_multibyte): Now static.
13599
61c2b50e 13600 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13601 This makes it easier for human readers (and static analyzers)
13602 to see whether these variables are used from other modules.
13603 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13604 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13605 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13606 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13607 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13608 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13609 * xmenu.c, xselect.c:
13610 Declare Q* vars static if they are not used in other modules.
13611 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13612 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13613 Remove decls of unexported vars.
13614 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13615
95c82688
PE
13616 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13617
16a97296
PE
13618 Make Emacs functions such as Fatom 'static' by default.
13619 This makes it easier for human readers (and static analyzers)
13620 to see whether these functions can be called from other modules.
13621 DEFUN now defines a static function. To make the function external
13622 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13623 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13624 (Finit_image_library):
16a97296
PE
13625 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13626 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13627 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13628 Remove decls, since these functions are now static.
13629 (Funintern, Fget_internal_run_time): New decls, since these functions
13630 were already external.
95c82688 13631
16a97296
PE
13632 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13633 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13634 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13635 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13636 * keyboard.c, keymap.c, lread.c:
13637 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13638 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13639 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13640 Mark functions with DEFUE instead of DEFUN,
13641 if they are used in other modules.
13642 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13643 decls for now-static functions.
13644 * buffer.h (Fdelete_overlay): Remove decl.
13645 * callproc.c (Fgetenv_internal): Mark as internal.
13646 * composite.c (Fremove_list_of_text_properties): Remove decl.
13647 (Fcomposition_get_gstring): New forward static decl.
13648 * composite.h (Fcomposite_get_gstring): Remove decl.
13649 * dired.c (Ffile_attributes): New forward static decl.
13650 * doc.c (Fdocumntation_property): New forward static decl.
13651 * eval.c (Ffetch_bytecode): New forward static decl.
13652 (Funintern): Remove extern decl; now in .h file where it belongs.
13653 * fileio.c (Fmake_symbolic_link): New forward static decl.
13654 * image.c (Finit_image_library): New forward static decl.
13655 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13656 * intervals.h (Fprevious_property_change):
13657 (Fremove_list_of_text_properties): Remove decls.
13658 * keyboard.c (Fthis_command_keys): Remove decl.
13659 (Fcommand_execute): New forward static decl.
13660 * keymap.c (Flookup_key): New forward static decl.
13661 (Fcopy_keymap): Now static.
13662 * keymap.h (Flookup_key): Remove decl.
13663 * process.c (Fget_process): New forward static decl.
13664 (Fprocess_datagram_address): Mark as internal.
13665 * syntax.c (Fsyntax_table_p): New forward static decl.
13666 (skip_chars): Remove duplicate decl.
13667 * textprop.c (Fprevious_property_change): New forward static decl.
13668 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13669 Now internal.
13670 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13671 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13672
785bbd42
PE
13673 * editfns.c (Fformat): Remove unreachable code.
13674
8b913b57
AS
136752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13676
13677 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13678 change. (Bug#8496)
13679
a6744a35
EZ
136802011-04-13 Eli Zaretskii <eliz@gnu.org>
13681
13682 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13683 when at ZV. (Bug#8487)
13684
e7974947
AS
136852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13686
baad03f0
AS
13687 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13688 (Bug#8437)
13689 * keyboard.c (parse_tool_bar_item): Likewise.
13690 * sound.c (sound_cleanup, alsa_close): Likewise.
13691 * termcap.c (tgetent): Likewise.
13692 * xfns.c (x_default_font_parameter): Likewise.
13693 * xsettings.c (read_and_apply_settings): Likewise.
13694
e7974947
AS
13695 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13696 (overrun_check_free): Protoize.
13697
28272684
PE
136982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13699
13700 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13701 since callers should never pass a negative size.
13702 Change the signature to match that of plain 'read' and 'write'; see
13703 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13704 * lisp.h: Update prototypes of emacs_write and emacs_read.
13705
11997c76
EZ
137062011-04-11 Eli Zaretskii <eliz@gnu.org>
13707
13708 * xdisp.c (redisplay_window): Don't try to determine the character
13709 position of the scroll margin if the window start point w->startp
e896f03c 13710 is outside the buffer's accessible region. (Bug#8468)
11997c76 13711
8a2cbd72
EZ
137122011-04-10 Eli Zaretskii <eliz@gnu.org>
13713
13714 Fix write-region and its subroutines for buffers > 2GB.
13715 * fileio.c (a_write, e_write): Modify declaration of arguments and
13716 local variables to support buffers larger than 2GB.
13717 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13718
13719 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13720 argument, local variables, and return value.
13721
13722 * lisp.h: Update prototypes of emacs_write and emacs_read.
13723
13724 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13725
4073e537 137262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13727
1ebfdcb6
PE
13728 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13729
b2ded58d
PE
13730 Fix more problems found by GCC 4.6.0's static checks.
13731
7d66342c
PE
13732 * xdisp.c (vmessage): Use a better test for character truncation.
13733
bbf47d44
PE
13734 * charset.c (load_charset_map): <, not <=, for optimization,
13735 and to avoid potential problems with integer overflow.
9248994d 13736 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13737 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13738 * editfns.c (Fformat): Likewise.
1e69125e 13739 * syntax.c (skip_chars): Likewise.
3befa583 13740
e3019616
PE
13741 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13742 This also lets GCC 4.6.0 generate slightly better loop code.
13743
becfa255
PE
13744 * callint.c (Fcall_interactively): <, not <=, for optimization.
13745 (Fcall_interactively): Count the number of arguments produced,
13746 not the number of arguments given. This is simpler and lets GCC
13747 4.6.0 generate slightly better code.
13748
dae0cd48
PE
13749 * ftfont.c: Distingish more carefully between FcChar8 and char.
13750 The previous code passed unsigned char * to a functions like
13751 strlen and xstrcasecmp that expect char *, which does not
13752 conform to the C standard.
13753 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13754 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13755 char * when the C standard requires it.
13756
76032d70
PE
13757 * keyboard.c (read_char): Remove unused var.
13758
eb3f1cc8
PE
13759 * eval.c: Port to Windows vsnprintf (Bug#8435).
13760 Include <limits.h>.
13761 (SIZE_MAX): Define if the headers do not.
13762 (verror): Do not give up if vsnprintf returns a negative count.
13763 Instead, grow the buffer. This ports to Windows vsnprintf, which
13764 does not conform to C99. Problem reported by Eli Zaretskii.
13765 Also, simplify the allocation scheme, by avoiding the need for
13766 calling realloc, and removing the ALLOCATED variable.
13767
70476b54
PE
13768 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13769
12020a9e
PE
13770 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13771 But keep the doprint source code for now, as we might revamp it
13772 and use it again (Bug#8435).
ea6c7ae6
PE
13773 * lisp.h (doprnt): Remove.
13774 * Makefile.in (base_obj): Remove doprnt.o.
13775 * deps.mk (doprnt.o): Remove.
13776
5fdb398c
PE
13777 error: Print 32- and 64-bit integers portably (Bug#8435).
13778 Without this change, on typical 64-bit hosts error ("...%d...", N)
13779 was used to print both 32- and 64-bit integers N, which relied on
13780 undefined behavior.
61bdb816 13781 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13782 * lisp.h (error, verror): Mark as printf-like functions.
13783 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13784 Report overflow in size calculations when allocating printf buffer.
13785 Do not truncate output string at its first null byte.
13786 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13787 Truncate the output at a character boundary, since vsnprintf does not
13788 do that.
13789 * charset.c (check_iso_charset_parameter): Convert internal
13790 character to string before calling 'error', since %c now has the
13791 printf meaning.
13792 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13793 overflow when computing char to be passed to 'error'. Do not
13794 pass Lisp_Object to 'error'; pass the integer instead.
13795 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13796 formatted with plain %d.
13797
b189fa66
PE
13798 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13799
bff87ef0
PE
13800 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13801
7e2cac20
PE
13802 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13803
ce4d90b5
PE
13804 * xterm.c (x_catch_errors): Remove duplicate declaration.
13805
266c9547
PE
13806 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13807
79c49ad2
PE
13808 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13809
368f4090
JM
138102011-04-10 Jim Meyering <meyering@redhat.com>
13811
13812 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13813 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13814 return ssize_t not "int", and use size_t as the buffer length.
13815 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13816 * gnutls.h: Update declarations.
13817 * process.c (read_process_output): Use ssize_t, to match.
13818 (send_process): Likewise.
13819
a32d4040
CY
138202011-04-09 Chong Yidong <cyd@stupidchicken.com>
13821
13822 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13823
8546720e 138242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13825
04f2d78b
CB
13826 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13827 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13828
8546720e
GM
13829 * xterm.c (handle_one_xevent):
13830 * xmenu.c (create_and_show_popup_menu):
13831 * xselect.c (x_decline_selection_request)
13832 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13833
0a2f5c1a 138342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13835
13836 Fix some uses of `int' instead of EMACS_INT.
13837 * search.c (string_match_1, fast_string_match)
13838 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13839 (scan_buffer, find_next_newline_no_quit)
13840 (find_before_next_newline, search_command, Freplace_match)
13841 (Fmatch_data): Make some `int' variables be EMACS_INT.
13842
13843 * xdisp.c (display_count_lines): 3rd argument and return value now
13844 EMACS_INT. All callers changed.
13845 (pint2hrstr): Last argument is now EMACS_INT.
13846
13847 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13848 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13849 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13850 (decode_coding_utf_16, decode_coding_emacs_mule)
13851 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13852 (decode_coding_ccl, decode_coding_charset)
13853 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13854 (decode_coding_iso_2022, decode_coding_emacs_mule)
13855 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13856 <char_offset, last_offset>: Declare EMACS_INT.
13857 (encode_coding_utf_8, encode_coding_utf_16)
13858 (encode_coding_emacs_mule, encode_invocation_designation)
13859 (encode_designation_at_bol, encode_coding_iso_2022)
13860 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13861 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13862 Declare EMACS_INT.
13863 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13864 (encode_invocation_designation): Last argument P_NCHARS is now
13865 EMACS_INT.
13866 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13867 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13868
13869 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13870 All users changed.
13871
13872 * ccl.c (Fccl_execute_on_string): Declare some variables
13873 EMACS_INT.
13874
8546720e 138752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13876
13877 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13878
4e19a977
CS
138792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13880
13881 * process.c (Fformat_network_address): Doc fix.
13882
87302331
R
138832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13884
ee7683eb 13885 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13886
cbb59342
CY
138872011-04-08 Chong Yidong <cyd@stupidchicken.com>
13888
13889 * keyboard.c (read_char): Call Lisp function help-form-show,
13890 instead of using internal_with_output_to_temp_buffer.
13891 (Qhelp_form_show): New var.
e0d38eeb 13892 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13893
13894 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13895
13896 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13897
e67a13ab
CY
138982011-04-06 Chong Yidong <cyd@stupidchicken.com>
13899
04f2d78b
CB
13900 * process.c (Flist_processes): Remove to Lisp.
13901 (list_processes_1): Delete.
e67a13ab 13902
973f782d
EZ
139032011-04-06 Eli Zaretskii <eliz@gnu.org>
13904
7c106b1e
EZ
13905 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13906
973f782d
EZ
13907 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13908
41cf7d1a 139092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13910
ca23cc88
PE
13911 Fix more problems found by GCC 4.6.0's static checks.
13912
f390e2d5
PE
13913 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13914
42eea0d0
PE
13915 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13916
b69769da 13917 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13918
f9541e84
PE
13919 * xdisp.c (vmessage): Mark as a printf-like function.
13920
13841b55
PE
13921 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13922
c136c10f
PE
13923 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13924
5e2d4a30
PE
13925 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13926 printf-like functions.
13927 (tiff_load): Add casts to remove these marks before passing them
13928 to system-supplied API.
13929
583f48b9
PE
13930 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13931
b25d760e
PE
13932 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13933 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13934 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13935 directly, rather than having caller test rule sign. This avoids
13936 some unnecessary tests.
13937 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13938 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13939 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13940
bc7b6697 13941 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13942 (xfont_open): Avoid unnecessary tests.
bc7b6697 13943
27ccc379
PE
13944 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13945
dcd5c89a
PE
13946 * composite.h, composite.c (composition_gstring_put_cache):
13947 Use EMACS_INT, not int, for length.
13948
b13a45c6
PE
13949 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13950 breaking out part of COMPOSITION_DECODE_RULE.
13951 (COMPOSITION_DECODE_RULE): Use it.
13952 * composite.c (get_composition_id): Remove unused local vars,
13953 by using the new macro.
13954
1e792e4d
PE
13955 * textprop.c (set_text_properties_1): Change while to do-while,
13956 since the condition is always true at first.
13957
dc6c6455 13958 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13959 (interval_deletion_adjustment): Return unsigned value.
13960 All uses changed.
dc6c6455 13961
aba7731a
PE
13962 * process.c (list_processes_1, create_pty, read_process_output):
13963 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13964 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13965 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13966 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13967 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13968
fdfc4bf3
PE
13969 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13970
fca8fe46 13971 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13972 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13973
06a0259a 13974 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13975 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13976 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13977
e7b9e80f
PE
13978 * print.c (print_error_message): Avoid int overflow.
13979
56201685
PE
13980 * font.c (font_list_entities): Redo for clarity,
13981 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13982
78834453 13983 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13984 (font_score): Avoid potential overflow in diff calculation.
78834453 13985
0bc0b309 13986 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13987 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13988
e610eaca
PE
13989 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13990
b895abce
PE
13991 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13992 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13993 can always succeed if overflow has undefined behavior.
13994
1f1d9321 13995 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13996 (wordify): Omit three unnecessary tests.
1f1d9321 13997
c59478bc
PE
13998 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13999 All callers changed. This avoids the need for an unused var.
14000
79b73827
PE
14001 * casefiddle.c (casify_region): Remove var that is set but not used.
14002
a4db5dfe
PE
14003 * dired.c (file_name_completion): Remove var that is set but not used.
14004
43aae36e
PE
14005 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14006
2a47c44d 14007 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14008 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14009
a37c69bf
PE
14010 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14011 Check for integer overflow on size calculations.
14012
328ab8e7
PE
14013 * buffer.c (Fprevious_overlay_change): Remove var that is set
14014 but not used.
14015
e5a2a5cb
PE
14016 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14017 Remove vars that are set but not used.
8d84a6eb 14018 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14019 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14020
a60e5f68
PE
14021 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14022
f661cb61 14023 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14024 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14025
f0397f5a
PE
14026 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14027 that are set but not used.
14028
8664db06 14029 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14030 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14031
6abdaa4a
PE
14032 * xselect.c (x_get_local_selection, x_handle_property_notify):
14033 Remove vars that are set but not used.
14034
0ce7538d 14035 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14036 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14037
9ae848fc
PE
14038 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14039 Remove var that is set but not used.
0b918413
PE
14040 (scroll_bar_windows_size): Now size_t, not int.
14041 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14042 Check for overflow.
9ae848fc 14043
a5a62657
PE
14044 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14045 (map_tty_color) [!defined MSDOS]: Likewise.
14046
5c5cdd39
PE
14047 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14048
66ebf983
PE
14049 * coding.c: Remove vars that are set but not used.
14050 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14051 All callers changed.
14052 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14053 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14054 (decode_coding_charset): Remove vars that are set but not used.
14055
1be4d761
PE
14056 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14057 that is set but not used.
14058
47553fa8
PE
14059 * print.c (print_object): Remove var that is set but not used.
14060
1f7196bf 14061 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14062 The gnulib version avoids calling malloc in the usual case,
14063 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14064 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14065 * filelock.c (current_lock_owner): Likewise.
14066 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14067 * sysdep.c: Include allocator.h, careadlinkat.h.
14068 (emacs_no_realloc_allocator): New static constant.
14069 (emacs_readlink): New function.
fdb61804
PE
14070 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14071 ../lib/careadlinkat.h.
d1fdcab7 14072
f84c17c7
SM
140732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14074
14075 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14076 first non-nil return value).
14077
ef3862ad
JD
140782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14079
14080 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14081 if not defined (Bug#8403).
14082
376a7006
JB
140832011-04-02 Juanma Barranquero <lekktu@gmail.com>
14084
14085 * xdisp.c (display_count_lines): Remove parameter `start',
14086 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14087 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14088 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14089 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14090 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14091 and thereabouts. All callers changed.
14092 (get_per_char_metric): Remove parameter `f', unused since
14093 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14094
6ca3801d
JM
140952011-04-02 Jim Meyering <meyering@redhat.com>
14096
14097 do not dereference NULL upon failed strdup
14098 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14099 (ns_get_family): Likewise.
14100
d8e2b5ba
JB
141012011-04-02 Juanma Barranquero <lekktu@gmail.com>
14102
14103 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14104
8c74fcbd
JD
141052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14106
14107 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14108 later (Bug#8403).
14109
7200d79c
SM
141102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14111
03408648 14112 Add lexical binding.
7200d79c 14113
03408648
SM
14114 * window.c (Ftemp_output_buffer_show): New fun.
14115 (Fsave_window_excursion):
14116 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14117
14118 * lread.c (lisp_file_lexically_bound_p): New function.
14119 (Fload): Bind Qlexical_binding.
14120 (readevalloop): Remove `evalfun' arg.
14121 Bind Qinternal_interpreter_environment.
14122 (Feval_buffer): Bind Qlexical_binding.
14123 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14124 Mark as dynamic.
14125 (syms_of_lread): Declare `lexical-binding'.
14126
14127 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14128
14129 * keyboard.c (eval_dyn): New fun.
14130 (menu_item_eval_property): Use it.
ca105506
SM
14131
14132 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14133
03408648
SM
14134 * fns.c (concat, mapcar1): Accept byte-code-functions.
14135
14136 * eval.c (Fsetq): Handle lexical vars.
14137 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14138 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14139 (FletX, Flet): Obey lexical binding.
14140 (Fcommandp): Handle closures.
14141 (Feval): New `lexical' arg.
14142 (eval_sub): New function extracted from Feval. Use it almost
14143 everywhere where Feval was used. Look up vars in lexical env.
14144 Handle closures.
14145 (Ffunctionp): Move from subr.el.
14146 (Ffuncall): Handle closures.
14147 (apply_lambda): Remove `eval_flags'.
14148 (funcall_lambda): Handle closures and new byte-code-functions.
14149 (Fspecial_variable_p): New function.
14150 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14151 but without exporting it to Lisp.
23aba0ea 14152
23aba0ea 14153 * doc.c (Fdocumentation, store_function_docstring):
03408648 14154 * data.c (Finteractive_form): Handle closures.
23aba0ea 14155
03408648
SM
14156 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14157 interactive spec.
ba83908c 14158
04f2d78b
CB
14159 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14160 New byte-codes.
03408648
SM
14161 (exec_byte_code): New function extracted from Fbyte_code to handle new
14162 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14163
03408648 14164 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14165
03408648 14166 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14167
e2abce01
JB
141682011-03-31 Juanma Barranquero <lekktu@gmail.com>
14169
14170 * xdisp.c (redisplay_internal): Fix prototype.
14171
63696a73 141722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14173
63696a73 14174 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14175 (try_scrolling): Use it when setting scroll_limit.
14176 Limit scrolling to 100 screen lines.
63696a73
EZ
14177 (redisplay_window): Even when falling back on "recentering",
14178 position point in the window according to scroll-conservatively,
14179 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14180
14181 (try_scrolling): When point is above the window, allow searching
14182 as far as scroll_max, or one screenful, to compute vertical
14183 distance from PT to the scroll margin position. This prevents
14184 try_scrolling from unnecessarily failing when
14185 scroll-conservatively is set to a value slightly larger than the
14186 window height. Clean up the case of PT below the margin at bottom
14187 of window: scroll_max can no longer be INT_MAX. When aggressive
14188 scrolling is in use, don't let point enter the opposite scroll
14189 margin as result of the scroll.
14190 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14191 threshold of 100 lines for never-recentering scrolling.
14192
e4cc2dfc
JB
141932011-03-31 Juanma Barranquero <lekktu@gmail.com>
14194
14195 * dispextern.h (move_it_by_lines):
14196 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14197 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14198 (message_log_check_duplicate): Remove parameters `prev_bol' and
14199 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14200 (redisplay_internal): Remove parameter `preserve_echo_area',
14201 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14202
14203 * indent.c (Fvertical_motion):
14204 * window.c (window_scroll_pixel_based, Frecenter):
14205 Don't pass `need_y_p' to `move_it_by_lines'.
14206
1c470562
SM
142072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14208
44f230aa
SM
14209 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14210 steal a few bits to be more compact.
14211 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14212 Remove unneeded casts.
14213
1c470562
SM
14214 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14215
888adce9
ZK
142162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14217
14218 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14219 binding" message (bug#7967).
14220
f838ed7b
PE
142212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14222
77861b95
PE
14223 Fix more problems found by GCC 4.6.0's static checks.
14224
de6dbc14
PE
14225 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14226 Remove unused local var.
14227
f838ed7b
PE
14228 * editfns.c (Fmessage_box): Remove unused local var.
14229
792c7b2b
PE
14230 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14231 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14232 Omit unused local vars.
c499e557 14233 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14234 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14235 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14236 Omit unused local var.
14237
ba0165e1
PE
14238 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14239 Don't assume string length fits in int.
32ad8845 14240 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14241 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14242
3c59b4c9
PE
14243 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14244 instead of alloca (Bug#8344).
14245
a3eed478 14246 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14247 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14248
eb4d412d
PE
14249 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14250
1658b401
PE
14251 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14252 concerns.
14253
14254 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14255
14256 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14257
9a2c6e05
PE
14258 * keyboard.c (syms_of_keyboard): Use the same style as later
14259 in this function when indexing through an array. This also
14260 works around GCC bug 48267.
14261
03d0a109
PE
14262 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14263
44f730c8
PE
14264 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14265
fe75f926
PE
14266 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14267 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14268
ffa8c828
PE
14269 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14270 This avoids undefined behavior on integer overflow, and is a bit
14271 more convenient anyway since it is compared to a size_t variable.
14272
c5101a77
PE
14273 Variadic C functions now count arguments with size_t, not int.
14274 This avoids an unnecessary limitation on 64-bit machines, which
14275 caused (substring ...) to crash on large vectors (Bug#8344).
14276 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14277 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14278 All variadic functions and their callers changed accordingly.
c5101a77
PE
14279 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14280 * data.c (arith_driver, float_arith_driver): Likewise.
14281 * editfns.c (general_insert_function): Likewise.
14282 * eval.c (struct backtrace.nargs, interactive_p)
14283 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14284 (funcall_lambda, mark_backtrace): Likewise.
14285 * fns.c (concat): Likewise.
14286 * frame.c (x_set_frame_parameters): Likewise.
14287 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14288 0 if not found, not -1. All callers changed.
14289
dd3f25f7
PE
14290 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14291 (stack_copy_size): Now size_t, not int.
14292 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14293
461c2ab9
JB
142942011-03-28 Juanma Barranquero <lekktu@gmail.com>
14295
14296 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14297 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14298 All callers changed.
14299
14300 * lisp.h (multibyte_char_to_unibyte):
14301 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14302 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14303 * character.h (CHAR_TO_BYTE8):
14304 * cmds.c (internal_self_insert):
14305 * editfns.c (general_insert_function):
14306 * keymap.c (push_key_description):
14307 * search.c (Freplace_match):
14308 * xdisp.c (message_dolog, set_message_1): All callers changed.
14309
f6d62986
SM
143102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14311
14312 * keyboard.c (safe_run_hook_funcall): New function.
14313 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14314 don't set the hook to nil, but remove the offending function instead.
14315 (Qcommand_hook_internal): Remove, unused.
14316 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14317 Vcommand_hook_internal.
14318
14319 * eval.c (enum run_hooks_condition): Remove.
14320 (funcall_nil, funcall_not): New functions.
14321 (run_hook_with_args): Call each function through a `funcall' argument.
14322 Remove `cond' argument, now redundant.
14323 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14324 (Frun_hook_with_args_until_failure): Adjust accordingly.
14325 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14326
1db5b1ad
JB
143272011-03-28 Juanma Barranquero <lekktu@gmail.com>
14328
14329 * dispextern.h (string_buffer_position): Remove declaration.
14330
14331 * print.c (strout): Remove parameter `multibyte', unused since
14332 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14333
14334 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14335 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14336 All callers changed.
14337
14338 * w32.c (_wsa_errlist): Use braces for struct initializers.
14339
14340 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14341 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14342 All callers changed.
14343 (string_buffer_position): Likewise. Also, make static (it's never
14344 used outside xdisp.c).
14345 (cursor_row_p): Remove parameter `w', unused since
14346 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14347 (decode_mode_spec): Remove parameter `precision', introduced during
14348 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14349 All callers changed.
14350
5ffb62aa
JD
143512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14352
14353 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14354
461c2ab9 143552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14356
14357 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14358 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14359 (ns_update_auto_hide_menu_bar): New functions.
14360 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14361 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14362 ns_constrain_all_frames.
14363 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14364 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14365
5c380ffb
JD
143662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14367
14368 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14369
9af30bdf
GM
143702011-03-27 Glenn Morris <rgm@gnu.org>
14371
14372 * syssignal.h: Replace RETSIGTYPE with void.
14373 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14374 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14375 Replace SIGTYPE with void everywhere.
14376 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14377 * s/template.h (SIGTYPE): Remove commented out definition.
14378
e2abce01
JB
143792011-03-26 Eli Zaretskii <eliz@gnu.org>
14380
14381 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14382 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14383
f868cd8a
JB
143842011-03-26 Juanma Barranquero <lekktu@gmail.com>
14385
59eb0929
JB
14386 * w32.c (read_unc_volume): Use parameter `henum', instead of
14387 global variable `wget_enum_handle'.
14388
14389 * keymap.c (describe_vector): Remove parameters `indices' and
14390 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14391 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14392
f868cd8a
JB
14393 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14394
14395 * keyboard.c (timer_check): Remove parameter `do_it_now',
14396 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14397 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14398 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14399
14400 * keyboard.c (read_char):
14401 * w32menu.c (w32_menu_display_help):
14402 * xmenu.c (show_help_event, menu_help_callback):
14403 Adjust calls to `show_help_echo'.
14404
14405 * gtkutil.c (xg_maybe_add_timer):
14406 * keyboard.c (readable_events):
14407 * process.c (wait_reading_process_output):
14408 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14409
14410 * insdel.c (adjust_markers_gap_motion):
14411 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14412 (gap_left, gap_right): Don't call it.
14413
2ecf6fdb
CY
144142011-03-25 Chong Yidong <cyd@stupidchicken.com>
14415
14416 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14417 incurred during fontification.
14418
6b1f9ba4
JB
144192011-03-25 Juanma Barranquero <lekktu@gmail.com>
14420
14421 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14422 (DEFVAR_PER_BUFFER): Don't pass it.
14423
14424 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14425 (scrolling_window): Don't pass it.
14426
0f4a96b5
JB
144272011-03-25 Juanma Barranquero <lekktu@gmail.com>
14428
14429 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14430
14431 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14432 and `suffix'.
14433 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14434 of variables specific to SELinux and computation of `encoded_absname'.
14435
14436 * image.c (XPutPixel): Remove unused variable `height'.
14437
14438 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14439
14440 * unexw32.c (get_section_info): Remove unused variable `section'.
14441
14442 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14443 (system_process_attributes): Remove unused variable `sess'.
14444 (sys_read): Remove unused variable `err'.
14445
14446 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14447 (w32_wnd_proc): Remove unused variable `isdead'.
14448 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14449 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14450 (x_create_tip_frame): Remove unused variable `tem'.
14451
14452 * w32inevt.c (w32_console_read_socket):
14453 Remove unused variable `no_events'.
14454
14455 * w32term.c (x_draw_composite_glyph_string_foreground):
14456 Remove unused variable `width'.
14457
1149507c
JB
144582011-03-24 Juanma Barranquero <lekktu@gmail.com>
14459
14460 * w32term.c (x_set_glyph_string_clipping):
14461 Don't pass uninitialized region to CombineRgn.
14462
9c88f339
JB
144632011-03-23 Juanma Barranquero <lekktu@gmail.com>
14464
14465 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14466 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14467 (Fx_close_connection): Remove unused variable `i'.
14468
14469 * w32font.c (w32font_draw): Return number of glyphs.
14470 (w32font_open_internal): Remove unused variable `i'.
14471 (w32font_driver): Add missing initializer.
14472
14473 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14474 (fill_in_menu): Remove unused variable `items_added'.
14475
14476 * w32term.c (last_mouse_press_frame): Remove static global variable.
14477 (w32_clip_to_row): Remove unused variable `f'.
14478 (x_delete_terminal): Remove unused variable `i'.
14479
14480 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14481 (NOTHING): Remove unused static global variable.
14482 (uniscribe_check_otf): Remove unused variable `table'.
14483 (uniscribe_font_driver): Add missing initializers.
14484
dee091a3
JD
144852011-03-23 Julien Danjou <julien@danjou.info>
14486
14487 * term.c (Fsuspend_tty, Fresume_tty):
14488 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14489 * window.c (temp_output_buffer_show):
14490 * insdel.c (signal_before_change):
14491 * frame.c (Fhandle_switch_frame):
14492 * fileio.c (Fdo_auto_save):
14493 * emacs.c (Fkill_emacs):
14494 * editfns.c (save_excursion_restore):
14495 * cmds.c (internal_self_insert):
14496 * callint.c (Fcall_interactively):
14497 * buffer.c (Fkill_all_local_variables):
14498 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14499 Use Frun_hooks.
0f4a96b5 14500 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14501 unconditionally since it does the check itself.
dee091a3 14502
2c520ab5 145032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14504
c9c49752
PE
14505 Fix more problems found by GCC 4.5.2's static checks.
14506
8abc3f12
PE
14507 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14508 the first time through the loop, since we know p0 < p1 then.
14509 This also avoids a gcc -Wstrict-overflow warning.
14510
a2d26660
PE
14511 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14512 leading to a memory leak, possible in functions like
14513 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14514 of objects (Bug#8318).
a2d26660 14515
916c72e9
PE
14516 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14517 that could (at least in theory) be that large.
14518
19ab8a18
PE
14519 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14520 This is less likely to overflow, and avoids undefined behavior if
14521 overflow does occur. All callers changed. Use strtoul to scan
14522 for the unsigned long integer.
b7cbbd6f
PE
14523 (pint2hrstr): Simplify and tune code slightly.
14524 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14525
f0641eff
PE
14526 * scroll.c (do_scrolling): Work around GCC bug 48228.
14527 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14528
7f650bb9
PE
14529 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14530 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14531 (validate_x_resource_name): Simplify count usage.
14532 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14533
37dd57d1
PE
14534 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14535 fail (Bug#8306).
81e56e61 14536
699979fc 14537 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14538
401bf9b4
PE
14539 * process.c (Fmake_network_process): Use socklen_t, not int,
14540 where POSIX says socklen_t is required in portable programs.
14541 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14542 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14543 (Fmake_network_process, server_accept_connection):
14544 (wait_reading_process_output, read_process_output):
14545 Likewise.
14546
b93aacde
PE
14547 * process.c: Rename or move locals to avoid shadowing.
14548 (list_processes_1, Fmake_network_process):
14549 (read_process_output_error_handler, exec_sentinel_error_handler):
14550 Rename or move locals.
4dc343ee 14551 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14552 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14553 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14554 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14555 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14556
af8a867c 14557 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14558 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14559 Include tparam.h instead, since it declares them.
af8a867c
PE
14560 * cm.h (PC): Remove extern decl; tparam.h now does this.
14561 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14562 * terminfo.c: Include tparam.h, to check interfaces.
14563 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14564 (tparam): Adjust signature to match interface in tparam.h;
14565 this removes some undefined behavior. Check that outstring and len
14566 are zero, which they always are with Emacs.
14567 * tparam.h (PC, BC, UP): New extern decls.
14568
0248044d 14569 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14570 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14571
8ff096c1 14572 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14573 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14574 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14575 (ftfont_list): Remove unused local.
49eaafba
PE
14576 (get_adstyle_property, ftfont_pattern_entity):
14577 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14578 Rename locals to avoid shadowing.
8ff096c1 14579
e2be39f6
PE
14580 * xfont.c (xfont_list_family): Mark var as initialized.
14581
c9735e30
PE
14582 * xml.c (make_dom): Now static.
14583
8f5201ae
PE
14584 * composite.c (composition_compute_stop_pos): Rename local to
14585 avoid shadowing.
b246f932
PE
14586 (composition_reseat_it): Remove unused locals.
14587 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14588 (composition_update_it): Mark var as initialized.
11b61122
PE
14589 (find_automatic_composition): Mark vars as initialized,
14590 with a FIXME (Bug#8290).
8f5201ae 14591
760fbc2c
PE
14592 character.h: Rename locals to avoid shadowing.
14593 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14594 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14595 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14596 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14597 to avoid shadowing.
14598
ff08eb85
PE
14599 * textprop.c (property_change_between_p): Remove; unused.
14600
fc7bf025
PE
14601 * intervals.c (interval_start_pos): Now static.
14602
235d7abc
PE
14603 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14604
44f230aa
SM
14605 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14606 Rename locals to avoid shadowing.
3e7d6594 14607
50060332
PE
14608 * sound.c (wav_play, au_play, Fplay_sound_internal):
14609 Fix pointer signedness.
d01f234b 14610 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14611 (wav_play): Initialize a variable to 0, to prevent undefined
14612 behavior (Bug#8278).
50060332 14613
c4fc4e30
PE
14614 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14615
918436ed
PE
14616 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14617
c939f91b
PE
14618 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14619 clobbering (Bug#8298).
b9c7f648
PE
14620 * sysdep.c (sys_subshell): Likewise.
14621 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14622
6bd8c144
PE
14623 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14624 This should get cleaned up, so that child_setup has the
14625 same signature on all platforms.
14626
7710357c 14627 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14628 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14629
c59da222
CY
146302011-03-22 Chong Yidong <cyd@stupidchicken.com>
14631
14632 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14633 not to be necessary, and produces flickering.
14634
66b87493
GM
146352011-03-20 Glenn Morris <rgm@gnu.org>
14636
14637 * config.in: Remove file.
14638
45b6f6d5
JB
146392011-03-20 Juanma Barranquero <lekktu@gmail.com>
14640
14641 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14642 are now in src/globals.h.
14643 (syms_of_minibuf): Remove spurious & from previous change.
14644
cd394be1 146452011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14646
14647 * minibuf.c (completing-read-function): New variable.
14648 (completing-read-default): Rename from completing-read.
14649 (completing-read): Call completing-read-function.
14650
b14e3e21
CY
146512011-03-19 Juanma Barranquero <lekktu@gmail.com>
14652
14653 * xfaces.c (Fx_load_color_file):
14654 Read color file from absolute filename (bug#8250).
14655
f2b726e6
JB
146562011-03-19 Juanma Barranquero <lekktu@gmail.com>
14657
14658 * makefile.w32-in: Update dependencies.
14659
09f6ff02
EZ
146602011-03-17 Eli Zaretskii <eliz@gnu.org>
14661
14662 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14663
29a6015a
PE
146642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14665
a3a6c54e
PE
14666 Fix more problems found by GCC 4.5.2's static checks.
14667
b766f867
PE
14668 * process.c (make_serial_process_unwind, send_process_trap):
14669 (sigchld_handler): Now static.
14670
be02381c
PE
14671 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14672 That way, the code declares only the vars that it needs.
14673 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14674 * s/cygwin.h (PTY_ITERATION): Likewise.
14675 * s/darwin.h (PTY_ITERATION): Likewise.
14676 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14677
57048744
PE
14678 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14679 * process.c (allocate_pty): Don't declare stb unless it's needed.
14680
7914961c 14681 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14682 (CONSTANTLIM): Remove; unused.
14683 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14684 Define only if needed.
7914961c 14685
b3967b18
PE
14686 * unexelf.c (unexec): Name an expression,
14687 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14688 Use a different way to cause a compilation error if anyone uses
14689 n rather than nn, a way that does not involve shadowing.
73366a00 14690 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14691
29a6015a
PE
14692 * deps.mk (unexalpha.o): Remove; unused.
14693
43cfc33e 14694 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14695 * unexec.h: New file.
ce701a33
PE
14696 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14697 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14698 Depend on unexec.h.
14699 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14700 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14701 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14702 Change as necessary to match prototype in unexec.h.
ce701a33 14703
01f44d5a
PE
14704 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14705 shadowing.
4f63c6bb 14706 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14707
a6670b0b
PE
14708 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14709 Rename locals to avoid shadowing.
14710
cef2010d 14711 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14712 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14713
d4d7173a
PE
14714 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14715
f08b802a
PE
14716 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14717 warning when compiling print.c.
14718
3ddb0639
PE
14719 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14720 instead of using an uninitialized var.
5ad03b97 14721 (font_sort_entities): Mark var as initialized.
3ddb0639 14722
170a2692
PE
14723 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14724
e663c700
PE
14725 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14726 pointers to constants.
89bc529a 14727 (font_parse_fcname): Remove unused vars.
7b81e2d0 14728 (font_delete_unmatched): Now static.
ea838e10 14729 (font_get_spec): Remove; unused.
13a547c6
PE
14730 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14731 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14732 Rename or move locals to avoid shadowing.
e663c700 14733
2a80c887 14734 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14735 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14736
1384fa33 14737 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14738 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14739
8b2c52e9
PE
14740 * alloc.c (mark_backtrace): Move decl from here ...
14741 * lisp.h: ... to here, so that it can be checked.
14742
475545b5 14743 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14744 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14745 (lisp_indirect_variable): Name an expression,
14746 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14747 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14748
b1349114 14749 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14750 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14751 Use const pointer when appropriate.
b1349114 14752
a2928364
PE
14753 * lisp.h (get_system_name, get_operating_system_release):
14754 Move decls here, to check interfaces.
14755 * process.c (get_operating_system_release): Move decl to lisp.h.
14756 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14757 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14758 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14759 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14760 (Fformat_time_string, Fencode_time, Finsert_char):
14761 (Ftranslate_region_internal, Fformat):
14762 Rename or remove local vars to avoid shadowing.
9710023e 14763 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14764
a415e694
PE
14765 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14766 avoid shadowing.
14767
8ef4622d
PE
14768 * lisp.h (eassert): Check that the argument compiles, even if
14769 ENABLE_CHECKING is not defined.
14770
946f9a5b
PE
14771 * data.c (Findirect_variable): Name an expression, to avoid
14772 gcc -Wbad-function-cast warning.
112396d6 14773 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14774 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14775 (Fmake_variable_buffer_local, Fmake_local_variable):
14776 Mark variables as initialized.
52746918 14777 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14778
e5aab7e7 14779 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14780 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14781 Rename locals to avoid shadowing.
dff45157
PE
14782 (mark_stack): Move local variables into the #ifdef region where
14783 they're used.
7bc26fdb
PE
14784 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14785 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14786 needed otherwise.
14787 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14788 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14789 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14790
e5aab7e7
PE
14791 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14792 avoids undefined behavior in theory.
14793
4da60324
PE
14794 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14795
88043301
PE
14796 Use functions, not macros, for up- and down-casing (Bug#8254).
14797 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14798 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14799 to use the following functions instead of these macros.
14800 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14801 EMACS_INT, since callers assume the returned value fits in int.
14802 (upcase1): Likewise, for UPCASE_TABLE.
14803 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14804 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14805 the race-condition problem in the old DOWNCASE.
88043301 14806
19ed5445
PE
14807 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14808 Rename locals to avoid shadowing.
14809 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14810 (regex_compile, re_search_2, re_match_2_internal):
14811 Remove unused local vars.
952db0d7
PE
14812 (FREE_VAR): Rewrite so as not to use empty "else",
14813 which gcc can warn about.
da053e48 14814 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14815 (RETALLOC_IF): Define only if needed.
14816 (WORDCHAR_P): Likewise. This one is never needed, but is used
14817 only in a comment talking about a compiler bug, so put inside
14818 the #if 0 of that comment.
14819 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14820 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14821 Remove; unused.
19ed5445 14822
1f3561e4 14823 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14824 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14825 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14826
ded6f8f7
PE
14827 * search.c (simple_search): Remove unused var.
14828
dbd37a95
PE
14829 * dired.c (compile_pattern): Move decl from here ...
14830 * lisp.h: ... to here, so that it can be checked.
14831 (struct re_registers): New forward decl.
14832
7e47afad
PE
14833 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14834
85f24f61
PE
14835 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14836 All uses changed.
14837 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14838 Rename locals to avoid shadowing.
5671df8f 14839 (Fvertical_motion): Mark locals as initialized.
85f24f61 14840
181aa2be 14841 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14842 (casify_region): Mark local as initialized.
181aa2be 14843
930d429c
PE
14844 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14845
7082eac6
PE
14846 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14847 New macros, so that the caller can use some names other than
14848 gcpro1, gcpro2, etc.
14849 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14850 of the new macros.
14851 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14852 argument, for consistency with GCPRO2_VAR, etc: it is now the
14853 prefix of the variable, not the variable itself. All uses
14854 changed.
38b2c076
PE
14855 * dired.c (directory_files_internal, file_name_completion):
14856 Rename locals to avoid shadowing.
14857
15206ed9
PE
14858 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14859 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14860 dired.c's scmp function, had undefined behavior.
14861 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14862 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14863 * buffer.h: ... to here, because these macros use current_buffer,
14864 and the new implementation with inline functions needs to have
14865 current_buffer in scope now, rather than later when the macros
14866 are used.
14867 (downcase, upcase1): New static inline functions.
14868 (DOWNCASE, UPCASE1): Reimplement using these functions.
14869 This avoids undefined behavior in expressions like
14870 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14871 from race conditions in accessing the global variables
14872 case_temp1 and case_temp2.
14873 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14874 * lisp.h (case_temp1, case_temp2): Remove their decls.
14875 * character.h (ASCII_CHAR_P): Move from here ...
14876 * lisp.h: ... to here, so that the inline functions mentioned
14877 above can use them.
14878
4a6bea26
PE
14879 * dired.c (directory_files_internal_unwind): Now static.
14880
f14b7e14
PE
14881 * fileio.c (file_name_as_directory, directory_file_name):
14882 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14883 Now static.
2893f146
PE
14884 (file_name_as_directory): Use const pointers when appropriate.
14885 (Fexpand_file_name): Likewise. In particular, newdir might
14886 point at constant storage, so make it a const pointer.
fd4ead52 14887 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14888 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14889 signedness issues.
f839df0c
PE
14890 (Fset_file_times, Finsert_file_contents, auto_save_error):
14891 Rename locals to avoid shadowing.
f14b7e14 14892
5716756e 14893 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14894 (Ftry_completion, Fall_completions): Rename or remove locals
14895 to avoid shadowing.
5716756e 14896
b4c3046a
PE
14897 * marker.c (bytepos_to_charpos): Remove; unused.
14898
b45db522
PE
14899 * lisp.h (verify_bytepos, count_markers): New decls,
14900 so that gcc does not warn that these functions aren't declared.
14901
85876d07
PE
14902 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14903 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14904 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14905 (copy_text): Remove unused local var.
85876d07 14906
03d78a21 14907 * filelock.c (within_one_second): Now static.
b3dd38ab 14908 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14909
5df8f01b
PE
14910 * buffer.c (fix_overlays_before): Mark locals as initialized.
14911 (fix_start_end_in_overlays): Likewise. This function should be
14912 simplified by using pointers-to-pointers, but that's a different
14913 matter.
b1d876f1 14914 (switch_to_buffer_1): Now static.
8f54f30a
PE
14915 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14916 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14917
a70072c9 14918 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14919 Fix pointer signedness issue.
edced198
PE
14920 (sys_subshell): Mark local as volatile if checking for lint,
14921 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14922 (MAXPATHLEN): Define only if needed.
a70072c9 14923
a0977c44
PE
14924 * process.c (serial_open, serial_configure): Move decls from here ...
14925 * systty.h: ... to here, so that they can be checked.
14926
a884fdcc
PE
14927 * fns.c (get_random, seed_random): Move extern decls from here ...
14928 * lisp.h: ... to here, so that they can be checked.
14929
604efe86 14930 * sysdep.c (reset_io): Now static.
b8950c94 14931 (wait_for_termination_signal): Remove; unused.
604efe86 14932
38fc62d9
PE
14933 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14934 (copy_keymap_item, append_key, push_text_char_description):
14935 Now static.
1004a21a 14936 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14937 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14938 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14939 (describe_map_tree):
14940 Rename locals to avoid shadowing.
38fc62d9 14941
2f2650da
PE
14942 * keyboard.c: Declare functions static if they are not used elsewhere.
14943 (echo_char, echo_dash, cmd_error, top_level_2):
14944 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14945 (read_char, kbd_buffer_get_event, make_lispy_position):
14946 (make_lispy_event, make_lispy_movement, apply_modifiers):
14947 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14948 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14949 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14950 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14951 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14952
a053e86c 14953 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14954 (mark_kboards): Move decl here ...
14955 * alloc.c (mark_kboards): ... from here.
a053e86c 14956
4752793e
PE
14957 * lisp.h (force_auto_save_soon): New decl.
14958
74f10ca7 14959 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14960 (DEFINE_DUMMY_FUNCTION): New macro.
14961 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14962 Use it.
c03cd23f
PE
14963 (main): Add casts to avoid warnings
14964 if GCC considers string literals to be constants.
74f10ca7 14965
022e70d4
PE
14966 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14967
59d6fe83
PE
14968 * dbusbind.c: Pointer signedness fixes.
14969 (xd_signature, xd_append_arg, xd_initialize):
14970 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14971 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14972 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14973 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14974
78320123
PE
14975 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14976 if GCC considers string literals to be constants.
49cebcca 14977 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14978
35ac2a97
SM
149792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14980
fb103ca9
SM
14981 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14982 (print_preprocess, print_object): New macro to fix last change.
14983
35ac2a97
SM
14984 * print.c (print_preprocess): Don't forget font objects.
14985
62973b41
JB
149862011-03-16 Juanma Barranquero <lekktu@gmail.com>
14987
14988 * emacs.c (USAGE3): Doc fixes.
14989
0e48bb22
AS
149902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14991
14992 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14993 structure.
14994
7684e57b
JB
149952011-03-14 Juanma Barranquero <lekktu@gmail.com>
14996
14997 * lisp.h (VWindow_system, Qfile_name_history):
14998 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14999 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15000 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15001
15002 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15003 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15004
15005 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15006 * w32console.c (detect_input_pending, read_input_pending)
15007 (encode_terminal_code):
15008 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15009 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15010 (w32_system_caret_y, Qfile_name_history):
15011 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15012 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15013 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15014 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15015 * w32proc.c (Qlocal, report_file_error):
15016 * w32term.c (Vwindow_system, updating_frame):
15017 * w32uniscribe.c (initialized, uniscribe_font_driver):
15018 Remove unneeded extern declarations.
15019
2aa46d6c
CY
150202011-03-14 Chong Yidong <cyd@stupidchicken.com>
15021
c96bbc66 15022 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15023
cffc6f3b
CY
150242011-03-13 Chong Yidong <cyd@stupidchicken.com>
15025
15026 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15027 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15028 These macros can no longer be used for assignment.
15029
44f230aa
SM
15030 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15031 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15032 (record_buffer_markers, fetch_buffer_markers): New functions for
15033 recording and fetching special buffer markers.
15034 (set_buffer_internal_1, set_buffer_temp): Use them.
15035
15036 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15037
15038 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15039
15040 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15041 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15042
15043 * xdisp.c (hscroll_window_tree):
15044 (reconsider_clip_changes): Use PT instead of BUF_PT.
15045
d251f04b
EZ
150462011-03-13 Eli Zaretskii <eliz@gnu.org>
15047
15048 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15049 $(EMACS_ROOT)/lib/intprops.h.
15050
f0c77cd1
PE
150512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15052
3eca4629
PE
15053 Fix more problems found by GCC 4.5.2's static checks.
15054
7c86ee98
PE
15055 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15056 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15057 (xg_free_frame_widgets): Make it clear that a local variable is
15058 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15059 (gdk_window_get_screen): Make it clear that this macro is needed
15060 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15061 (int_gtk_range_get_value): New function, which avoids a diagnostic
15062 from gcc -Wbad-function-cast.
15063 (xg_set_toolkit_scroll_bar_thumb): Use it.
15064 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15065 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15066 (get_utf8_string, xg_get_file_with_chooser):
15067 Rename locals to avoid shadowing.
15068 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15069
41729b81
PE
15070 * xgselect.c (xg_select): Remove unused var.
15071
f0c77cd1
PE
15072 * image.c (four_corners_best): Mark locals as initialized.
15073 (gif_load): Initialize transparent_p to zero (Bug#8238).
15074 Mark another local as initialized.
ec6cf4c6 15075 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15076
ce0ad53d 15077 * image.c (clear_image_cache): Now static.
d5d5a617 15078 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15079 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15080 (x_edge_detection): Remove unnecessary cast that
15081 gcc -Wbad-function-cast diagnoses.
2037898d 15082 (gif_load): Fix pointer signedness.
6ae141d6
PE
15083 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15084 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15085
33383987 150862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15087
d32df629
PE
15088 Improve quality of tests for time stamp overflow.
15089 For example, without this patch (encode-time 0 0 0 1 1
15090 1152921504606846976) returns the obviously-bogus value (-948597
15091 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15092 reports time overflow. See
15093 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15094 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15095 * editfns.c: Include limits.h and intprops.h.
15096 (TIME_T_MIN, TIME_T_MAX): New macros.
15097 (time_overflow): Move earlier, to before first use.
15098 (hi_time, lo_time): New functions, for an accurate test for
15099 out-of-range times.
15100 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15101 (Fget_internal_run_time): Don't assume time_t fits in int.
15102 (make_time): Use list2 instead of Fcons twice.
15103 (Fdecode_time): More accurate test for out-of-range times.
15104 (check_tm_member): New function.
15105 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15106 (lisp_time_argument): Don't rely on undefined left-shift and
15107 right-shift behavior when checking for time stamp overflow.
8be6f318 15108
fe31d94c
PE
15109 * editfns.c (time_overflow): New function, refactoring common code.
15110 (Fformat_time_string, Fdecode_time, Fencode_time):
15111 (Fcurrent_time_string): Use it.
15112
8be6f318
PE
15113 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15114 * dired.c (make_time): Move to ...
15115 * editfns.c (make_time): ... here.
15116 * systime.h: Note the move.
15117
09d9db2c 151182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15119
126bc0dc
YM
15120 * fringe.c (update_window_fringes): Remove unused variables.
15121
c47cbdfd
YM
15122 * unexmacosx.c (copy_data_segment): Also copy __got section.
15123 (Bug#8223)
15124
7ac80be9
EZ
151252011-03-12 Eli Zaretskii <eliz@gnu.org>
15126
c96bbc66 15127 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15128 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15129 Constify `char *' arguments and their references according to
15130 prototypes in tparam.h.
15131
ecb0f94d 15132 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15133
7ac80be9
EZ
15134 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15135 Adapt all references accordingly.
15136
15137 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15138
ef1fd07e
TT
151392011-03-11 Tom Tromey <tromey@redhat.com>
15140
15141 * buffer.c (syms_of_buffer): Remove obsolete comment.
15142
7ef4b50c
EZ
151432011-03-11 Eli Zaretskii <eliz@gnu.org>
15144
15145 * termhooks.h (encode_terminal_code): Declare prototype.
15146
15147 * msdos.c (encode_terminal_code): Don't declare prototype.
15148
15149 * term.c (encode_terminal_code): Now external again, used by
15150 w32console.c and msdos.c.
15151
44f230aa
SM
15152 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15153 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15154
4b1ec863 151552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15156
1714f52b 15157 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15158
4b1ec863
PE
15159 * fringe.c (update_window_fringes): Mark locals as initialized
15160 (Bug#8227).
15161 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15162
524c7aa6
PE
15163 * alloc.c (mark_fringe_data): Move decl from here ...
15164 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15165 to check its interface.
15166 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15167
a5c0af81 15168 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15169 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15170 (fontset_font): Mark local as initialized.
a9a06e0b 15171 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15172
b4716021
PE
15173 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15174
811e9bac 15175 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15176 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15177 (x_own_selection, Fx_disown_selection_internal): Rename locals
15178 to avoid shadowing.
15179 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15180
7e3ab302
PE
15181 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15182 so that the caller can use some name other than gcpro1.
15183 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15184 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15185 (Fx_backspace_delete_keys_p):
15186 Use them to avoid shadowing, and rename vars to avoid shadowing.
15187 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15188 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15189 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15190 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15191 Remove unused locals.
7e3ab302
PE
15192 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15193 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15194 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15195 macros.
f78faa98 15196
e2b13473
PE
15197 * xterm.h (x_mouse_leave): New decl.
15198
77f23912
PE
15199 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15200 Remove unused functions.
cdf4ba58
PE
15201 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15202 (x_calc_absolute_position): Now static.
7411c686 15203 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15204 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15205 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15206 unless they are used.
38d0b34a
PE
15207 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15208 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15209 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15210 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15211 (x_error_catcher, x_connection_closed, x_error_handler):
15212 (x_error_quitter, xembed_send_message, x_iconify_frame):
15213 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15214 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15215 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15216
44f230aa
SM
15217 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15218 Rename or move locals to avoid shadowing.
6b463e58 15219 (tty_defined_color, merge_face_heights): Now static.
5967d051 15220 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15221 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15222 does not deduce is never used uninitialized.
73719eba
PE
15223 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15224 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15225
426994c3 15226 * terminal.c (store_terminal_param): Now static.
5489860b 15227
032f1620 15228 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15229 (set_frame_menubar): Remove unused local.
d4323972 15230 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15231 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15232 since they might point to immutable storage.
281585b0
PE
15233 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15234 since it's unused otherwise.
032f1620 15235
367c19e5 15236 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15237 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15238 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15239 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15240 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15241 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15242 does not deduce are never used uninitialized.
70739cbe 15243
07b48fa9
PE
15244 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15245
8868a238 15246 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15247 * window.c (window_loop, size_window):
15248 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15249
7e5cf297 15250 * window.c (display_buffer): Now static.
d6550a9f
PE
15251 (size_window): Mark variables that gcc -Wuninitialized
15252 does not deduce are never used uninitialized.
a586633d
PE
15253 * window.h (check_all_windows): New decl, to forestall
15254 gcc -Wmissing-prototypes diagnostic.
5b555da1 15255 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15256
f6095868
PE
15257 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15258 shadowing.
15259 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15260 Include <limits.h>.
15261 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15262 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15263 (load_charset_map): Mark variables that gcc -Wuninitialized
15264 does not deduce are never used uninitialized.
53df7c11 15265 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15266
f38b440c
PE
15267 * coding.c (coding_set_source, coding_set_destination):
15268 Use "else { /* comment */ }" rather than "else /* comment */;"
15269 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15270 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15271 a block, when the outer 'i' will do.
15272 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15273 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15274 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15275 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15276 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15277 Rename locals to avoid shadowing.
15278 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15279 * coding.c (emacs_mule_char, encode_invocation_designation):
15280 Now static, since they're not used elsewhere.
413bb2db 15281 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15282 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15283 (decode_coding_emacs_mule): Mark variables that gcc
15284 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15285 (detect_coding_iso_2022): Initialize a local variable that might
15286 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15287 this initialization is needed. (Bug#8211)
5f58e762
PE
15288 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15289 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15290 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15291 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15292 Remove unused macros.
f38b440c 15293
232b38b9 15294 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15295 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15296 * character.c (string_count_byte8): Likewise.
232b38b9 15297
fb90da1b
PE
15298 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15299 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15300
fb93dbc2
PE
15301 * chartab.c (copy_sub_char_table): Now static, since it's not used
15302 elsewhere.
5c156ace
PE
15303 (sub_char_table_ref_and_range, char_table_ref_and_range):
15304 Rename locals to avoid shadowing.
bbcd0949 15305 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15306
7d3b3862 15307 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15308 (BIDI_BOB): Remove unused macro.
7d3b3862 15309
6be7d3da
PE
15310 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15311 deduce are never used uninitialized.
c2ed9c8b 15312 * term.c (encode_terminal_code): Likewise.
6be7d3da 15313
75f8807f 15314 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15315
50938595
PE
15316 * tparam.h: New file.
15317 * term.c, tparam.h: Include it.
15318 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15319 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15320 Move these decls to tparam.h, and make them agree with what
15321 is actually in tparam.c. The previous trick of using incompatible
15322 decls in different modules does not conform to the C standard.
15323 All callers of tparam changed to use tparam's actual API.
15324 * tparam.c (tparam1, tparam, tgoto):
15325 Use const pointers where appropriate.
15326
fbceeba2
PE
15327 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15328 * cm.h (struct cm): Likewise.
15329 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15330 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15331 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15332 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15333 (turn_on_face, init_tty): Likewise.
15334 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15335
7f3f1250
PE
15336 * term.c (term_mouse_position): Rename local to avoid shadowing.
15337
e6ca6543
PE
15338 * alloc.c (mark_ttys): Move decl from here ...
15339 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15340
c40f8d15
AS
153412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15342
15343 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15344
cfe0661d
JB
153452011-03-09 Juanma Barranquero <lekktu@gmail.com>
15346
15347 * search.c (compile_pattern_1): Remove argument regp, unused since
15348 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15349 (compile_pattern): Don't pass it.
15350
0afb4571
J
153512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15352
15353 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15354 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15355 for ! HAVE_GTK3.
15356 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15357
15358 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15359
15360 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15361 gdk_window_get_screen, gdk_window_get_geometry,
15362 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15363 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15364 (xg_get_pixbuf_from_pixmap): New function.
15365 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15366 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15367 Call xg_get_pixbuf_from_pixmap instead of
15368 gdk_pixbuf_get_from_drawable.
15369 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15370 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15371 (xg_check_special_colors): Use GtkStyleContext and its functions
15372 for HAVE_GTK3.
15373 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15374 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15375 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15376 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15377 Call gtk_widget_get_preferred_size.
0afb4571
J
15378 (xg_frame_resized): gdk_window_get_geometry only takes 5
15379 parameters.
44f230aa
SM
15380 (xg_win_to_widget, xg_event_is_for_menubar):
15381 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15382 (xg_set_widget_bg): New function.
15383 (delete_cb): New function.
895009e1 15384 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15385 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15386 (xg_set_background_color): Call xg_set_widget_bg.
15387 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15388 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15389 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15390 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15391 if ! HAVE_GTK3.
15392 (update_frame_tool_bar): Call gtk_widget_hide.
15393 (xg_initialize): Use GDK_KEY_g.
15394
15395 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15396 if ! HAVE_GTK3
15397 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15398
15399 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15400 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15401 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15402
1c2cc4ef
JB
154032011-03-08 Juanma Barranquero <lekktu@gmail.com>
15404
15405 * w32xfns.c (select_palette): Check success of RealizePalette against
15406 GDI_ERROR, not zero.
15407
33383987 15408See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15409
15410;; Local Variables:
15411;; coding: utf-8
aac0c6e3
MR
15412;; End:
15413
2f097256 15414 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15415
15416 This file is part of GNU Emacs.
15417
15418 GNU Emacs is free software: you can redistribute it and/or modify
15419 it under the terms of the GNU General Public License as published by
15420 the Free Software Foundation, either version 3 of the License, or
15421 (at your option) any later version.
15422
15423 GNU Emacs is distributed in the hope that it will be useful,
15424 but WITHOUT ANY WARRANTY; without even the implied warranty of
15425 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15426 GNU General Public License for more details.
15427
15428 You should have received a copy of the GNU General Public License
15429 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.