Replace some src/s undefs by never even checking on relevant platforms
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4516fbef
GM
12012-07-07 Glenn Morris <rgm@gnu.org>
2
3 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
5 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
6
07adc2c6
JB
72012-07-07 Juanma Barranquero <lekktu@gmail.com>
8
9 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
10 Update dependencies.
11
12 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
13
fd573f31
PE
142012-07-06 Paul Eggert <eggert@cs.ucla.edu>
15
fee5959d
PE
16 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
17 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
18 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
19 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
20 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
21 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
22
fd573f31
PE
23 * xfont.c (compare_font_names): Redo to omit the need for casts.
24
ddadbc0e
AS
252012-07-06 Andreas Schwab <schwab@linux-m68k.org>
26
fca8d6b6
AS
27 * xfns.c (Fx_change_window_property): Doc fix.
28 * w32fns.c (Fx_change_window_property): Doc fix.
29
ddadbc0e
AS
30 * w32fns.c (Fx_window_property): Accept the same arguments as the
31 X Windows version. Doc fix.
32 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
33
f247498e
JB
342012-07-06 Juanma Barranquero <lekktu@gmail.com>
35 Eli Zaretskii <eliz@gnu.org>
36
37 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
38 Windows-specific code from nt/config.nt moved here.
39 Obsolete settings removed.
40
216ee680
PE
412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
42
43 * process.c: Avoid unnecessary calls to gettime.
44 (wait_reading_process_output): Don't get the time of day
45 when gobbling data immediately and not waiting, as there's no need
46 for it in that case. This removes a FIXME.
47
bdd091e4
JD
482012-07-06 Jan Djärv <jan.h.d@swipnet.se>
49
50 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
51 is defined (Bug#11768).
52
9d44f8ce
DA
532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Fix marker debugging code.
56 * marker.c (byte_char_debug_check): Do not perform the check
57 if buffer is not multibyte.
58 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
59 byte_char_debug_check with correct arguments.
60
90fc4786
DA
612012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
62
63 Compile marker debugging code only if ENABLE_CHECKING is defined.
64 * marker.c (byte_char_debug_check, count_markers): Use
65 only if ENABLE_CHECKING is defined.
66 (byte_debug_flag): Remove.
67 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
68 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
69
7b7ae965
DA
702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
71
4e57b342
DA
72 Avoid code repetition in marker-related functions.
73 * marker.c (attach_marker): New function.
74 (Fset_marker, set_marker_restricted, set_marker_both)
75 (set_marker_restricted_both): Use it.
76 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
77 Consistently rename charno to charpos.
78 (marker_position): Add eassert.
79 (marker_byte_position): Convert to eassert.
80
812012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
82
83 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 84 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 85 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 86
657924ff
DA
872012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
88
89 Introduce fast path for the widely used marker operation.
90 * alloc.c (build_marker): New function.
91 * lisp.h (build_marker): New prototype.
92 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
93 * composite.c (autocmp_chars): Likewise.
94 * editfns.c (buildmark): Remove.
95 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
96 (save_restriction_save): Use build_marker.
97 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
98 * window.c (save_window_save): Likewise.
99
041a49a6
DA
1002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
101
102 Do not use Fdelete_overlay in delete_all_overlays
103 to avoid redundant calls to unchain_overlay.
104 * buffer.c (drop_overlay): New function.
105 (delete_all_overlays, Fdelete_overlay): Use it.
106 * minibuf.c (get_minibuffer): Fix comment.
107
7dca65a4
PE
1082012-07-06 Paul Eggert <eggert@cs.ucla.edu>
109
110 Port to OpenBSD 5.1 amd64.
111 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
112 This is needed for OpenBSD, and should be harmless on all BSD systems.
113 Also, include <sys/sysctl.h>, as it should be available on all
114 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
115 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
116 use p_pid member, not kp_proc.pid.
117
8eb876e2
GM
1182012-07-06 Glenn Morris <rgm@gnu.org>
119
120 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
121
38182d90
PE
1222012-07-05 Paul Eggert <eggert@cs.ucla.edu>
123
124 More xmalloc and related cleanup.
125 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
126 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
127 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
128 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
129 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
130 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
131 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
132 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
133 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
134 * xterm.c:
135 Omit needless casts involving void * pointers and allocation.
136 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
137 as the former is more robust if P's type is changed.
138 Prefer xzalloc to xmalloc + memset 0.
139 Simplify malloc-or-realloc to realloc.
140 Don't worry about xmalloc returning a null pointer.
141 Prefer xstrdup to xmalloc + strcpy.
142 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
143 growing it.
144 * keyboard.c (apply_modifiers_uncached): Prefer local array to
145 alloca of a constant.
146
6dd5a677
EZ
1472012-07-05 Eli Zaretskii <eliz@gnu.org>
148
149 * xdisp.c (display_line): Fix horizontal pixel coordinates when
150 hscroll is larger than the line width. Fixes long and futile
151 looping inside extend_face_to_end_of_line (on a TTY) producing
152 glyphs that are not needed and thrown away.
153
6b312f0f
DA
1542012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
155
156 * marker.c (set_marker_restricted_both): Simplify by using
157 clip_to_bounds.
158
f520ef9b
PE
1592012-07-05 Paul Eggert <eggert@cs.ucla.edu>
160
161 * editfns.c (region_limit): Simplify by using clip_to_bounds.
162
383b7c95
JD
1632012-07-05 Jan Djärv <jan.h.d@swipnet.se>
164
165 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
166 not defined (Bug#11768).
167 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
168 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
169 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
170 followed by gtk_box_set_homogeneous (Bug#11768).
171 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
172 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
173 gtk_scrollbar_new (Bug#11768).
174 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
175 (is_box_type): New function (Bug#11768).
176 (xg_tool_item_stale_p): Call is_box_type.
5293d758 177 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
178 with default display (Bug#11768).
179
d6e7bf45
EZ
1802012-07-05 Eli Zaretskii <eliz@gnu.org>
181
182 * xdisp.c (window_hscroll_limited): New function.
183 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
184 coordinates when window's hscroll is set to insanely large
185 values. (Bug#11857)
186
431391ec
JB
1872012-07-05 Juanma Barranquero <lekktu@gmail.com>
188
189 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
190 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
191
23f86fce
DA
1922012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
193
194 Cleanup xmalloc.
195 * lisp.h (xzalloc): New prototype. Omit needless casts.
196 * alloc.c (xzalloc): New function. Omit needless casts.
197 * charset.c: Omit needless casts. Convert all calls to
198 xmalloc with following memset to xzalloc.
199 * dispnew.c: Likewise.
200 * fringe.c: Likewise.
201 * image.c: Likewise.
202 * sound.c: Likewise.
203 * term.c: Likewise.
204 * w32fns.c: Likewise.
205 * w32font.c: Likewise.
206 * w32term.c: Likewise.
207 * xfaces.c: Likewise.
208 * xfns.c: Likewise.
209 * xterm.c: Likewise.
210 * atimer.c: Omit needless casts.
211 * buffer.c: Likewise.
212 * callproc.c: Likewise.
213 * ccl.c: Likewise.
214 * coding.c: Likewise.
215 * composite.c: Likewise.
216 * doc.c: Likewise.
217 * doprnt.c: Likewise.
218 * editfns.c: Likewise.
219 * emacs.c: Likewise.
220 * eval.c: Likewise.
221 * filelock.c: Likewise.
222 * fns.c: Likewise.
223 * gtkutil.c: Likewise.
224 * keyboard.c: Likewise.
225 * lisp.h: Likewise.
226 * lread.c: Likewise.
227 * minibuf.c: Likewise.
228 * msdos.c: Likewise.
229 * print.c: Likewise.
230 * process.c: Likewise.
231 * region-cache.c: Likewise.
232 * search.c: Likewise.
233 * sysdep.c: Likewise.
234 * termcap.c: Likewise.
235 * terminal.c: Likewise.
236 * tparam.c: Likewise.
237 * w16select.c: Likewise.
238 * w32.c: Likewise.
239 * w32reg.c: Likewise.
240 * w32select.c: Likewise.
241 * w32uniscribe.c: Likewise.
242 * widget.c: Likewise.
243 * xdisp.c: Likewise.
244 * xmenu.c: Likewise.
245 * xrdb.c: Likewise.
246 * xselect.c: Likewise.
247
0497dc44
PE
2482012-07-05 Paul Eggert <eggert@cs.ucla.edu>
249
250 * fileio.c (time_error_value): Check the right error number.
251 Problem reported by Troels Nielsen in
252 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
253
356e7178
PE
2542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
255
4e71fd89
PE
256 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
257 This should be fixed in a better way; see Eli Zaretskii in
258 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
259 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
260
f0941253
PE
261 * fileio.c (time_error_value): Rename from special_mtime.
262 The old name's problems were noted by Eli Zaretskii in
263 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
264
065c9eb4
PE
265 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
266 This variable's comment says Emacs needs at least one GDB-visible
267 symbol of type enum pvec_type, to work around GDB problems.
268 The symbol's value doesn't matter.
269
356e7178
PE
270 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
271 that causes compilation to fail on pre-C99 compilers.
272
95f61aa2
JB
2732012-07-04 Juanma Barranquero <lekktu@gmail.com>
274
275 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
276 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
277
3884d954
DA
2782012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
279
d209e2fb 280 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
281 headers for buffer_defaults and buffer_local_symbols.
282 Reported by Juanma Barranquero <lekktu@gmail.com>.
283
ee28be33
SM
2842012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
285
286 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
287 * lisp.h (enum pvec_type): Use fewer bits.
288 (PSEUDOVECTOR_SIZE_BITS): New constant.
289 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
290 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
291 change in pvec_type.
292 (PSEUDOVECTOR_TYPEP): New macro.
293 (TYPED_PSEUDOVECTORP): Use it.
294 * fns.c (internal_equal): Adapt code to extract pvectype.
295 * emacs.c (gdb_pvec_type): Update type.
296 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
297 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
298 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
299 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
300 (sweep_vectors): Use it. Use local var `total_bytes' instead of
301 abusing vector->header.next.nbytes.
302 (live_vector_p): Use PVEC_TYPE.
303 (mark_object): Adapt code to extract pvectype. Use switch.
304
c7f2cd7f
PE
3052012-07-04 Paul Eggert <eggert@cs.ucla.edu>
306
307 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
308 Tighten new eassert a bit.
309
8ce70ed2
DA
3102012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
311
312 Fix compilation with --enable-gcc-warnings and -O1
313 optimization level.
314 * doprnt.c (doprnt): Change type of tem to int, initialize
315 to avoid compiler warning. Add eassert.
316 * search.c (simple_search): Initialize match_byte to avoid
317 compiler warning. Add eassert.
318
dea7f1e5
PE
3192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
320
24a212eb
PE
321 Avoid weird behavior with large horizontal scrolls.
322 Without this change, for example, large hscroll values would
323 mess up Emacs's display on Fedora 15 x86, presumably due to
324 overflows in int calculations in the display code.
325 Also, if buffers had long lines, Emacs would freeze.
326 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
327 (set_window_hscroll): New function, containing the old guts of
328 Fset_window_hscroll. Return the clipped value.
329 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
330 This avoids the need to check against PTRDIFF_MAX.
331
dea7f1e5
PE
332 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
333
76046526
DA
3342012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
335
336 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
337
39adff0d
PE
3382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
339
63807d47
PE
340 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
341 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
342 since GCC 4.4.6 issues a bogus warning for them.
343
39adff0d
PE
344 Fix bugs in file timestamp newness comparisons.
345 * fileio.c (Ffile_newer_than_file_p):
346 * lread.c (Fload): Use full timestamp resolution of files,
347 not just the 1-second resolution, so that files that are only
348 slightly newer still count as newer.
349 * fileio.c (Ffile_newer_than_file_p): Don't assume file
350 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
351
dbeed9a6
PE
3522012-07-03 Paul Eggert <eggert@cs.ucla.edu>
353
354 * fileio.c: Improve handling of file time marker. (Bug#11852)
355 (special_mtime): New function.
356 (Finsert_file_contents, Fverify_visited_file_modtime):
357 Use it to set special mtime values consistently.
358
636334d6
AS
3592012-07-03 Andreas Schwab <schwab@linux-m68k.org>
360
361 * fileio.c (Finsert_file_contents): Properly handle st_mtime
362 marker for non-existing file. (Bug#11852)
363
e2017fe2
GM
3642012-07-03 Glenn Morris <rgm@gnu.org>
365
366 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
367 and did not make it into globals.h).
368
404dbd37
TT
3692012-07-03 Tom Tromey <tromey@redhat.com>
370
371 * window.c (Fset_window_margins, Fset_window_fringes)
372 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
373 * textprop.c (Fprevious_property_change): No longer static.
374 * syntax.c (Fsyntax_table_p): No longer static.
375 * process.c (Fget_process, Fprocess_datagram_address): No longer
376 static.
377 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
378 * keyboard.c (Fcommand_execute): No longer static.
379 Remove EXFUN.
380 * insdel.c (Fcombine_after_change_execute): No longer static.
381 * image.c (Finit_image_library): No longer static.
382 * fileio.c (Fmake_symbolic_link): No longer static.
383 * eval.c (Ffetch_bytecode): No longer static.
384 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
385 * doc.c (Fdocumentation_property, Fsnarf_documentation):
386 No longer static.
404dbd37
TT
387 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
388 static.
389 * dired.c (Ffile_attributes): No longer static.
390 * composite.c (Fcomposition_get_gstring): No longer static.
391 * callproc.c (Fgetenv_internal): No longer static.
392
393 * ccl.h: Remove EXFUNs.
394 * buffer.h: Remove EXFUNs.
395 * dispextern.h: Remove EXFUNs.
396 * intervals.h: Remove EXFUNs.
397 * fontset.h: Remove EXFUN.
398 * font.h: Remove EXFUNs.
399 * dosfns.c (system_process_attributes): Remove EXFUN.
400 * keymap.h: Remove EXFUNs.
401 * lisp.h: Remove EXFUNs.
402 * w32term.h: Remove EXFUNs.
403 * window.h: Remove EXFUNs.
404 * xsettings.h: Remove EXFUN.
405 * xterm.h: Remove EXFUN.
406
8e4fd1e1
GM
4072012-07-03 Glenn Morris <rgm@gnu.org>
408
409 * lisp.h (Frandom): Make it visible to C.
410 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
411 buffer for invisible buffers. (Bug#1229)
412
ca95b3eb
DA
4132012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
414
415 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
416 values which aren't power of 2.
417 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
418 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
419 accordingly.
420
7555c33f
SM
4212012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
422
423 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
424
425 * alloc.c (mark_object): Revert part of last patch to use `switch'.
426
d12e8f5a
DA
4272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
428
429 * alloc.c (allocate_vector_block): Remove redundant
430 calls to mallopt if DOUG_LEA_MALLOC is defined.
431 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
432 avoid calls to mallopt if zero_vector is returned.
433
296094c3
DA
4342012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
435
436 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
437 is enabled, avoid dereferencing NULL current_sblock if
438 running undumped.
439
36429c89
DA
4402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Cleanup basic buffer management.
443 * buffer.h (struct buffer): Change layout to use generic vector
444 marking code. Fix some comments. Change type of 'clip_changed'
445 to bitfield. Remove unused #ifndef old.
446 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
447 (GET_OVERLAYS_AT): Fix indentation.
448 (for_each_per_buffer_object_at): New macro.
449 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
450 (Fbuffer_local_variables): Use it.
451 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
452 * alloc.c (allocate_buffer): Adjust to match new layout of
453 struct buffer. Fix comment.
454 (mark_overlay): New function.
455 (mark_buffer): Use it. Use mark_vectorlike to mark normal
456 Lisp area of struct buffer.
457 (mark_object): Use it. Adjust marking of misc objects
458 and related comments.
459
3b3e4cac
PE
4602012-07-02 Paul Eggert <eggert@cs.ucla.edu>
461
462 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
463 wrapper that is not needed because the wrapped code is a no-op (zero
464 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
465 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
466
cf5c0175
DA
4672012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
468
469 * alloc.c (mark_buffer): Simplify. Remove prototype.
470 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 471 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
472 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
473 redundant calls to mark_vectorlike for bool vectors.
474
ca26824c
GM
4752012-06-30 Glenn Morris <rgm@gnu.org>
476
2e4c5312
GM
477 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
478
ca26824c
GM
479 * epaths.in (PATH_SITELOADSEARCH): New.
480 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
481 This is rather than relying on --enable-locallisppath elements
482 having "site-lisp" in their names. (Bug#10208#25, 11658)
483
0d23c240
EZ
4842012-06-30 Eli Zaretskii <eliz@gnu.org>
485
c9240d7a
EZ
486 * w32proc.c (sys_select): Accept and ignore one more argument.
487
488 * w32.c (emacs_gnutls_pull): Call select with one more argument.
489
0d23c240 490 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 491 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
492
493 * sysdep.c: Don't include dos.h and dosfns.h.
494
495 * process.c (sys_select):
496 * msdos.c (sys_select): Accept one more argument and ignore it.
497
498 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
499 adapt data types and code to that.
500
501 * dosfns.c:
502 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
503 which clashes with the gnulib function of the same name.
504
af5a5a98
AS
5052012-06-30 Andreas Schwab <schwab@linux-m68k.org>
506
c5e4379c
AS
507 * font.c (font_style_to_value, font_style_symbolic)
508 (font_prop_validate_style): Add type checks for values in
509 font_style_table.
510
af5a5a98
AS
511 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
512 argument.
513 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
514 uses.
515
8d38f461
EZ
5162012-06-29 Eli Zaretskii <eliz@gnu.org>
517
2e5a6631
EZ
518 * xdisp.c (try_window_id): Undo last change.
519
8d38f461
EZ
520 * w32.c (getwd): Adjust commentary about startup_dir.
521 (init_environment): Always call sys_access, even in non-MSVC
522 builds. Don't chdir to the directory of the Emacs executable.
523 This undoes code from 1997 which was justified by the need to
524 "avoid conflicts when removing and renaming directories". But its
525 downside was that every relative file name was being interpreted
526 relative to the directory of the Emacs executable, which can never
527 be TRT. In particular, it broke sys_access when called with
528 relative file names.
529 (sys_access): Map GetLastError to errno.
530
2af3565e
DA
5312012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
532
533 * window.h (struct window): Change type of 'fringes_outside_margins'
534 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 535 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
536 Adjust comment.
537 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
538 to ptrdiff_t.
539
c8d3a25c 5402012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 541
c8d3a25c
GM
542 * gnutls.c (emacs_gnutls_handshake):
543 Add QUIT to make the loop interruptible.
57570cd3 544
c8d3a25c 5452012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 546
c8d3a25c
GM
547 * charset.c (init_charset): Make lack of etc/charsets fatal.
548
3e984ee8
DA
5492012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
550
551 * editfns.c (region_limit): Fix type mismatch.
552
ef884f23
DA
5532012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
554
555 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
556 undefined. Convert from xassert to eassert.
557 * nsmenu.m: Convert from xassert to eassert.
558 * nsterm.m: Likewise.
559
7d7e0027
SM
5602012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
561
562 * editfns.c (region_limit): Clip to narrowing (bug#11770).
563
aa754e6a
PE
5642012-06-28 Paul Eggert <eggert@cs.ucla.edu>
565
566 Avoid integer overflow on scroll-left and scroll-right.
567 * window.c (HSCROLL_MAX): New macro.
568 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
569 overflow when requested scroll falls outside ptrdiff_t range.
570
80b00b08
DA
5712012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
572
573 * window.h (struct window): Change type of 'hscroll',
574 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
575 'last_modified' and 'last_overlay_modified' to EMACS_INT.
576 Adjust users accordingly.
577 * xdisp.c (try_cursor_movement): Replace type check with eassert.
578 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
579 from EMACS_INT to ptrdiff_t.
580 (make_window): Omit redundant initialization.
581
62b2bcf6
JB
5822012-06-28 Juanma Barranquero <lekktu@gmail.com>
583
584 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
585
45942c7d
DA
5862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
587
588 * window.h (struct window): Change type of 'use_time' and
589 'sequence_number' from Lisp_Object to int.
590 * frame.c (make_frame): Adjust users accordingly.
591 * print.c (print_object): Likewise.
592 * window.c (select_window, Fwindow_use_time, make_parent_window)
593 (make_window): Likewise.
594
e509cfa6
DA
5952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
596
597 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
598 enabled with --enable-checking=[all,glyphs] configure option.
599 Fix GLYPH_DEBUG usage assuming that it may be undefined,
600 adjust comments accordingly.
601 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
602 undefined, adjust comments accordingly.
603 * image.c: Likewise.
604 * scroll.c: Likewise.
605 * w32fns.c: Likewise.
606 * w32term.c: Likewise.
607 * xdisp.c: Likewise.
608 * xfaces.c: Likewise.
609 * xfns.c: Likewise.
610 * xterm.c: Likewise.
611
a54e2c05
DA
6122012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
613
614 Generalize run-time debugging checks.
615 * dispextern.h (XASSERTS): Remove.
616 * fontset.c (xassert): Remove.
617 Convert from xassert to eassert.
618 * alloc.c: Convert from xassert to eassert.
619 * bidi.c: Likewise.
620 * dispnew.c: Likewise.
621 * fns.c: Likewise.
622 * fringe.c: Likewise.
623 * ftfont.c: Likewise.
624 * gtkutil.c: Likewise.
625 * image.c: Likewise.
626 * keyboard.c: Likewise.
627 * menu.c: Likewise.
628 * process.c: Likewise.
629 * scroll.c: Likewise.
630 * sound.c: Likewise.
631 * term.c: Likewise.
632 * w32console.c: Likewise.
633 * w32fns.c: Likewise.
634 * w32term.c: Likewise.
635 * window.c: Likewise.
636 * xdisp.c: Likewise.
637 * xfaces.c: Likewise.
638 * xfns.c: Likewise.
639 * xselect.c: Likewise.
640 * xterm.c: Likewise.
641
1ec4b7b2
SM
6422012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
643
644 * fns.c (maybe_resize_hash_table): Output message when growing the
645 purify-hashtable.
646
2014308a
DA
6472012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
648
649 * alloc.c (allocate_string_data): Remove dead code.
650 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
651 avoid GCC warning about unused macro.
652
246155eb
DA
6532012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
654
655 * alloc.c (allocate_string): Omit intervals initialization.
656 * alloc.c (make_uninit_multibyte_string): Initialize intervals
657 as in make_pure_string and make_pure_c_string.
658
43184b7b
DA
6592012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
660
d209e2fb 661 * alloc.c (allocate_string): Fix last change.
43184b7b 662
3fe6dd74
DA
6632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
664
d209e2fb 665 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
666 to memset, add explicit initialization where appropriate.
667
1ba6038a
GM
6682012-06-27 Glenn Morris <rgm@gnu.org>
669
670 * lisp.mk (lisp): Remove paths.elc.
671
c89926a5
CY
6722012-06-27 Chong Yidong <cyd@gnu.org>
673
674 * doc.c (Fsubstitute_command_keys): Fix punctuation.
675
ed6b3510
JW
6762012-06-26 John Wiegley <johnw@newartisans.com>
677
1ec4b7b2 678 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
679 on Mac OS X Lion: __mod_init_func and __mod_term_func.
680
ed6b3510
JW
681 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
682 when building with Clang.
683
8edd4a2b
SM
6842012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
685
686 * eval.c (Fapply): Allow calling it with a single argument.
687
f6f62d1b
EZ
6882012-06-26 Eli Zaretskii <eliz@gnu.org>
689
690 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
691 _stricmp and _strnicmp.
692 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
693
62efea5e
DA
6942012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
695
696 * alloc.c (allocate_window): Zero out non-Lisp part of newly
697 allocated window.
698 (allocate_process): Likewise for new process.
8edd4a2b 699 (allocate_terminal): Change to use offsetof.
62efea5e
DA
700 (allocate_frame): Likewise.
701 * frame.c (make_frame): Omit redundant initialization.
702 * window.c (make_parent_window): Use memset.
703 (make_window): Omit redundant initialization.
704 * process.c (make_process): Omit redundant initialization.
705 * terminal.c (create_terminal): Likewise.
706
42997f4d
DA
7072012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
708
709 * term.c (delete_tty): Remove redundant call to memset.
710
1130ecfc
DA
7112012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
712
713 * alloc.c: Remove build_string.
714 * lisp.h: Define build_string as static inline. This provides
715 a better opportunity to optimize away calls to strlen when the
716 function is called with compile-time constant argument.
717 * image.c (imagemagick_error): Convert to build_string.
718 * w32proc.c (sys_spawnve): Likewise.
719 * xterm.c (x_term_init): Likewise.
720
cf38a720
PE
7212012-06-26 Paul Eggert <eggert@cs.ucla.edu>
722
99027bdd
PE
723 Use sprintf return value instead of invoking strlen on result.
724 In the old days this wasn't portable, since some sprintf
725 implementations returned char *. But they died out years ago and
726 Emacs already assumes sprintf returns int.
727 Similarly for float_to_string.
728 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
729 * ccl.c (ccl_driver):
730 * character.c (string_escape_byte8):
731 * data.c (Fnumber_to_string):
732 * doprnt.c (doprnt):
733 * print.c (print_object):
734 * xdisp.c (message_dolog):
735 * xfns.c (syms_of_xfns):
736 Use sprintf or float_to_string result to avoid need to call strlen.
737 * data.c (Fnumber_to_string):
738 Use make_unibyte_string, since the string must be ASCII.
739 * lisp.h, print.c (float_to_string): Now returns int length.
740 * term.c (produce_glyphless_glyph):
741 Use sprintf result rather than recomputing it.
742
cf38a720
PE
743 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
744 * Makefile.in (ALL_CFLAGS):
745 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
746 * gmalloc.c, regex.c: Include <config.h> unconditionally.
747
3511c784
DA
7482012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
749
0a08eb21 750 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
751 strcasecmp if available.
752 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
753
fb7da12e
AS
7542012-06-25 Andreas Schwab <schwab@linux-m68k.org>
755
756 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
757 Avoid comma operator.
758 * menu.c (push_submenu_start, push_submenu_end)
759 (push_left_right_boundary, push_menu_pane): Likewise.
760 * msdos.c (dos_rawgetc): Likewise.
761
afa2ffd8
DA
7622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
763
764 * xfns.c (xic_create_fontsetname): Remove redundant calls
765 to memset.
766
b3b4476b
PE
7672012-06-25 Paul Eggert <eggert@cs.ucla.edu>
768
4495ff38
PE
769 * gtkutil.c (get_utf8_string): Remove redundant assignment.
770 sprintf already null-terminates its output.
771
b3b4476b
PE
772 * xfns.c (x_window): Remove redundant cast.
773
b00876c9
DA
7742012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
775
776 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
777 `const char *' to `char *' to avoid compiler warning.
778
d188e26b
PE
7792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
780
885d1d74
PE
781 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
782 instead of truncating it to 63 (admittedly a generous limit).
783
d188e26b
PE
784 * process.c: Fix spelling and caps in comments.
785
e2f560b1
DN
7862012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
787
e86db54b 788 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
789 * sysdep.c (setpgrp): Remove definition, not used in this file.
790
7583a3a1
JB
7912012-06-24 Juanma Barranquero <lekktu@gmail.com>
792
793 * makefile.w32-in: Update dependencies.
794
696056c2
EZ
7952012-06-24 Eli Zaretskii <eliz@gnu.org>
796
797 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
798 (SYSTIME_H): Add nt/inc/sys/time.h.
799
800 * systime.h [WINDOWSNT]: Include sys/time.h.
801
802 * s/ms-w32.h (struct timespec): Definition moved from
803 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
804
845ca893
PE
8052012-06-24 Paul Eggert <eggert@cs.ucla.edu>
806
807 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
808 * buffer.h (buffer_slot_type_mismatch):
809 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
810 * eval.c (unwind_to_catch):
811 * image.c (my_png_error, my_error_exit):
812 * keyboard.c (quit_throw_to_read_char, user_error)
813 (Fexit_recursive_edit, Fabort_recursive_edit):
814 * lisp.h (die, args_out_of_range, args_out_of_range_3)
815 (wrong_type_argument, buffer_overflow, __executable_start)
816 (memory_full, buffer_memory_full, string_overflow, Fthrow)
817 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
818 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
819 (fatal):
820 (child_setup) [!DOS_NT]:
821 * lread.c (end_of_file_error, invalid_syntax):
822 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
823 * puresize.h (pure_write_error):
824 * search.c (matcher_overflow):
825 * sound.c (sound_perror, alsa_sound_perror):
826 * sysdep.c, syssignal.h (croak):
827 * term.c (maybe_fatal, vfatal):
828 * textprop.c (text_read_only):
829 * undo.c (user_error):
830 * unexmacosx.c (unexec_error):
831 * xterm.c (x_ins_del_lines, x_delete_glyphs):
832 Use _Noreturn rather than NO_RETURN.
833 No need for separate decl merely because of _Noreturn.
834 * sound.c (sound_warning, parse_sound):
835 Remove unnecessary forward decls.
836
f1dd8073
PE
8372012-06-24 Paul Eggert <eggert@cs.ucla.edu>
838
839 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
840 * lisp.h (WAIT_READING_MAX): New macro.
841 * dispnew.c (Fsleep_for, sit_for):
842 * keyboard.c (kbd_buffer_get_event):
843 * process.c (Faccept_process_output):
844 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
845 This improves on the previous patch, which introduced a bug
846 when time_t is unsigned and as wide as intmax_t.
847 See <http://bugs.gnu.org/9000#51>.
848
b82c1755
EZ
8492012-06-23 Eli Zaretskii <eliz@gnu.org>
850
851 * dispnew.c (sit_for, Fsleep_for):
852 * keyboard.c (kbd_buffer_get_event):
853 * process.c (Faccept_process_output): Avoid compiler warnings when
854 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
855
ca300656
JB
8562012-06-23 Juanma Barranquero <lekktu@gmail.com>
857
049ec95b
JB
858 * makefile.w32-in: Update dependencies.
859
ca300656
JB
860 * w32.c (ltime): Add return type and declare static.
861 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
862
db7b8d06
PE
8632012-06-23 Paul Eggert <eggert@cs.ucla.edu>
864
865 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
866 Privately reported by Herbert J. Skuhra.
867 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
868 All uses changed.
869 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
870 not make_lisp_timeval, when the argument is of type EMACS_TIME.
871
0bd8297f
EZ
8722012-06-23 Eli Zaretskii <eliz@gnu.org>
873
96512555
EZ
874 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
875 last argument of make_unibyte_string.
876
0bd8297f
EZ
877 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
878 language ID in the event parameters.
879
880 * w32term.c (w32_read_socket): Put the new keyboard codepage into
881 event.code, not the obscure "character set ID".
882
63def6b6
CY
8832012-06-23 Chong Yidong <cyd@gnu.org>
884
885 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
886
e8a02204
EZ
8872012-06-23 Eli Zaretskii <eliz@gnu.org>
888
388cdec0
EZ
889 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
890 * w32.c (fdutimens): New function.
891
892 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
893
894 * s/ms-w32.h (pselect): Redirect to sys_select.
895
896 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
897
e8a02204
EZ
898 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
899 in the logic of incrementing and decrementing the value of
900 use_relocatable_buffers.
901
d054f3fb
PE
9022012-06-23 Paul Eggert <eggert@cs.ucla.edu>
903
904 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
905 Privately reported by Herbert J. Skuhra.
906 [__FreeBSD__]: Remove "*/" typo after "#include".
907 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
908 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
909 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
910 Don't assume EMACS_TIME and struct timeval are the same type.
911
d35af63c
PE
9122012-06-22 Paul Eggert <eggert@cs.ucla.edu>
913
914 Support higher-resolution time stamps (Bug#9000).
915 The time stamps are only nanosecond-resolution at the C level,
916 since that's the best that any real-world system supports now.
917 But they are picosecond-resolution at the Lisp level, as that's
918 easy, and leaves room for future OS improvements.
919
920 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
921 (LIBES): Use it.
922
923 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
924 Don't get current time unless it's needed.
925
926 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
927 now provides it if it's absent.
928 (start_atimer): Port to higher-res time stamps.
929 Check for time stamp overflow. Don't get current time more
930 often than is needed.
931
932 * buffer.h (struct buffer): Buffer modtime now has high resolution.
933 Include systime.h, not time.h.
934 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
935
936 * dired.c: Include stat-time.h.
937 (Ffile-attributes): File times now have higher resolution.
938
939 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
940 (struct image): Timestamp now has higher resolution.
941
942 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
943 has at least microseconds now. All uses removed.
944 (update_frame, update_single_window, update_window, update_frame_1)
945 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
946
947 * editfns.c (time_overflow): Now extern.
948 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
949 (float-time, Fformat_time_string, Fcurrent_time_string)
950 (Fcurrent_time_zone): Accept and generate higher-resolution
951 time stamps.
952 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
953 (decode_time_components, lisp_seconds_argument): New functions.
954 (make_time): Now static.
955 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
956 Report an error if the time is invalid, rather than having the caller
957 do that.
958
959 * fileio.c: Include <stat-time.h>
960 (Fcopy_file): Copy higher-resolution time stamps.
961 Prefer to set the time stamp via a file descriptor if that works.
962 (Fset_file_times, Finsert_file_contents, Fwrite_region)
963 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
964 (Fvisited_file_modtime, Fset_visited_file_modtime):
965 Support higher-resolution time stamps.
966
967 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
968
969 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
970
971 * image.c (prepare_image_for_display, clear_image_cache)
972 (lookup_image): Port to higer-resolution time stamps.
973
974 * keyboard.c (start_polling, bind_polling_period):
975 Check for time stamp overflow.
976 (read_char, kbd_buffer_get_event, timer_start_idle)
977 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
978 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
979 Port to higher-resolution time stamps. Do not assume time_t is signed.
980 (decode_timer): New function. Timers are now vectors of length 9,
981 not 8, to accommodate the picosecond component.
982 (timer_check_2): Use it.
983
984 * nsterm.m (select_timeout, timeval_subtract): Remove.
985 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
986 as they're a bit more accurate and handle overflow better.
987 (ns_select): Change prototype to be compatible with pselect.
988 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
989 * nsterm.h (ns_select): Adjust prototype.
990
991 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
992 us-resolution time stamps.
993 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
994
995 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
996
997 * lisp.h (time_overflow): New decl.
998 (wait_reading_process_output): First arg is now intmax_t, not int,
999 to accommodate larger waits.
1000
1001 * process.h (struct Lisp_Process.read_output_delay):
1002 Now counts nanoseconds, not microseconds.
1003 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1004 EMACS_HAS_USECS.
1005 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1006 (wait_reading_process_output):
1007 Port to ns-resolution time stamps.
1008 (Faccept_process_output, wait_reading_process_output):
1009 Check for time stamp overflow. Do not assume time_t is signed.
1010 (select_wrapper): Remove; we now use pselect.
1011 (Fprocess_attributes): Now generates ns-resolution time stamps.
1012
1013 * sysdep.c: Include utimens.h. Don't include utime.h
1014 or worry about struct utimbuf; gnulib does that for us now.
1015 (gettimeofday): Remove; gnulib provides a substitute.
1016 (make_timeval): New function.
1017 (set_file_times): Now sets ns-resolution time stamps.
1018 New arg FD; all uses changed.
1019 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1020 (system_process_attributes):
1021 Now returns ns-resolution time stamp. All uses changed.
1022 Check for time stamp overflow.
1023
1024 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1025 provides a substitute now.
1026
1027 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1028 since it guarantees struct timespec.
1029 (EMACS_TIME): Now struct timespec, so that we can support
1030 ns-resolution time stamps.
1031 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1032 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1033 (EMACS_USECS): Remove.
1034 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1035 so multiply the arg by 1000 before storing it.
1036 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1037 New macros.
1038 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1039 Port to ns-resolution time stamps.
1040 (EMACS_TIME_NEG_P): Remove; replaced by....
1041 (EMACS_TIME_SIGN): New macro.
1042 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1043 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1044 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1045 (make_timeval, make_lisp_time, decode_time_components): New decls.
1046 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1047 that it mishandled time_t overflow. You can't compare by subtracting!
1048 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1049 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1050
1051 * term.c: Include <sys/time.h>.
1052 (timeval_to_Time): New function, for proper overflow wraparound.
1053 (term_mouse_position, term_mouse_click): Use it.
1054
1055 * undo.c (record_first_change): Support higher-resolution time stamps
1056 in the undo buffer.
1057 (Fprimitive_undo): Use them when restoring time stamps.
1058
1059 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1060 (w32_get_internal_run_time):
1061 Port to higher-resolution Emacs time stamps.
1062 (ltime): Now accepts single 64-bit integer, as that's more convenient
1063 for callers.
1064
1065 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1066
1067 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1068 for compatibility with pselect. Support ns-resolution time stamps.
1069
1070 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1071
1072 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1073 Check for time stamp overflow, and support ns-resolution time stamps.
1074
1075 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1076 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1077 (timeval_subtract): Remove; no longer needed.
1078 (XTflash, XTring_bell, x_wait_for_event):
1079 Port to ns-resolution time stamps. Don't assume time_t is signed.
1080
b6a92dfe
CY
10812012-06-22 Chong Yidong <cyd@gnu.org>
1082
1083 * xdisp.c (x_consider_frame_title): Revert last change.
1084
d251c37c
EZ
10852012-06-22 Eli Zaretskii <eliz@gnu.org>
1086
1087 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1088 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1089 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1090 staticidx goes up to 1597 out of 1600 = 0x640.)
1091
f10deafb
PE
10922012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1095 Otherwise, the umask might be mistakenly 0 while handling input signals.
1096
ec6de1e2
SM
10972012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1098
1099 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1100
28be1ada
DA
11012012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1104 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1105 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1106 access to `contents' member of Lisp_Vector objects with AREF and ASET
1107 where appropriate.
1108
c6bf3022
CY
11092012-06-19 Chong Yidong <cyd@gnu.org>
1110
1111 * frame.c (delete_frame): When selecting a frame on a different
1112 text terminal, do not alter the terminal's top-frame.
1113
1114 * xdisp.c (format_mode_line_unwind_data): Record the target
1115 frame's selected window and its terminal's top-frame.
1116 (unwind_format_mode_line): Restore them.
1117 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1118 Callers changed.
1119 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1120 since tty frames can be explicitly named.
1121 (prepare_menu_bars): Likewise.
1122
1123 * term.c (Ftty_top_frame): New function.
1124
defd4196
PE
11252012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 Port byte-code-meter to modern targets.
1128 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1129 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1130 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1131 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1132 (METER_1, METER_2): Simplify.
1133
1053a871
SM
11342012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * data.c (Fdefalias): Return `symbol' (bug#11686).
1137
b7e8d081
MR
11382012-06-18 Martin Rudalics <rudalics@gmx.at>
1139
1140 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1141 gets killed during executing of this function (Bug#11665).
1142 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1143 (Vkill_buffer_query_functions): In doc-string say that functions
1144 run by this hook should not change the current buffer.
1145
7ea2b339
PE
11462012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 Fix recently-introduced process.c problems found by static checking.
1149 * process.c (write_queue_push, write_queue_pop, send_process):
1150 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1151 (write_queue_pop): Fix pointer signedness problem.
1152 (send_process): Remove unused local.
1153
96a313a1
CY
11542012-06-17 Chong Yidong <cyd@gnu.org>
1155
1156 * xdisp.c (redisplay_internal): No need to redisplay terminal
1157 frames that are not on top.
1158
20ca2e94
TN
11592012-06-17 Troels Nielsen <bn.troels@gmail.com>
1160
1161 * process.c (make_process): Initialize write_queue.
1162 (write_queue_push, write_queue_pop): New functions.
1163 (send_process): Use them to maintain correct ordering of process
1164 writes (Bug#10815).
1165
9a900ca9
PE
11662012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1167
310fbfa8
PE
1168 * lisp.h (eassert): Assume C89 or later.
1169 This removes the need for CHECK.
1170 (CHECK): Remove. Its comments about always evaluating its
1171 argument were confusing, as 'eassert' typically does not evaluate
1172 its argument.
1173
27bb1ca4
PE
1174 * coding.c (produce_chars): Use ptrdiff_t, not int.
1175
9a900ca9
PE
1176 * xterm.c (x_draw_underwave): Check for integer overflow.
1177 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1178
41b7f8bc 11792012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1180
1181 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1182 referenced (Bug#11583).
1183
9b0e3eba
AA
11842012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1185
1186 Implement wave-style variant of underlining.
1187 * dispextern.h (face_underline_type): New enum.
1188 (face): Add field for underline type.
1189 * nsterm.m (ns_draw_underwave): New function.
1190 (ns_draw_text_decoration): Use it.
1191 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1192 New functions.
1193 (x_draw_glyph_string): Use them.
1194 * xfaces.c (Qline, Qwave): New Lisp objects.
1195 (check_lface_attrs, merge_face_ref)
1053a871
SM
1196 (Finternal_set_lisp_face_attribute, realize_x_face):
1197 Handle wave-style underline face attributes.
9b0e3eba
AA
1198 * xterm.c (x_draw_underwave): New function.
1199 (x_draw_glyph_string): Use it.
1200
0fb52f11
JB
12012012-06-16 Juanma Barranquero <lekktu@gmail.com>
1202
1203 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1204 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1205 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1206 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1207 ($(BLD)/w32select.$(O)): Update dependencies.
1208
e5560ff7
AS
12092012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1210
1211 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1212 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1213 * character.c (_fetch_multibyte_char_p): Remove.
1214 * alloc.c: Include "character.h" before "buffer.h".
1215 * bidi.c: Likewise.
1216 * buffer.c: Likewise.
1217 * bytecode.c: Likewise.
1218 * callint.c: Likewise.
1219 * callproc.c: Likewise.
1220 * casefiddle.c: Likewise.
1221 * casetab.c: Likewise.
1222 * category.c: Likewise.
1223 * cmds.c: Likewise.
1224 * coding.c: Likewise.
1225 * composite.c: Likewise.
1226 * dired.c: Likewise.
1227 * dispnew.c: Likewise.
1228 * doc.c: Likewise.
1229 * dosfns.c: Likewise.
1230 * editfns.c: Likewise.
1231 * emacs.c: Likewise.
1232 * fileio.c: Likewise.
1233 * filelock.c: Likewise.
1234 * font.c: Likewise.
1235 * fontset.c: Likewise.
1236 * fringe.c: Likewise.
1237 * indent.c: Likewise.
1238 * insdel.c: Likewise.
1239 * intervals.c: Likewise.
1240 * keyboard.c: Likewise.
1241 * keymap.c: Likewise.
1242 * lread.c: Likewise.
1243 * macros.c: Likewise.
1244 * marker.c: Likewise.
1245 * minibuf.c: Likewise.
1246 * nsfns.m: Likewise.
1247 * nsmenu.m: Likewise.
1248 * print.c: Likewise.
1249 * process.c: Likewise.
1250 * regex.c: Likewise.
1251 * region-cache.c: Likewise.
1252 * search.c: Likewise.
1253 * syntax.c: Likewise.
1254 * term.c: Likewise.
1255 * textprop.c: Likewise.
1256 * undo.c: Likewise.
1257 * unexsol.c: Likewise.
1258 * w16select.c: Likewise.
1259 * w32fns.c: Likewise.
1260 * w32menu.c: Likewise.
1261 * window.c: Likewise.
1262 * xdisp.c: Likewise.
1263 * xfns.c: Likewise.
1264 * xmenu.c: Likewise.
1265 * xml.c: Likewise.
1266 * xselect.c: Likewise.
1267
2f07e6af
EZ
12682012-06-16 Eli Zaretskii <eliz@gnu.org>
1269
1053a871
SM
1270 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1271 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1272 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1273 row.
1274 (handle_face_prop): Use chunk-relative overlay string index when
1275 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1276 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1277 the rightmost. (Bug#11720)
2f07e6af 1278
29b83cec
AS
12792012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1280
1281 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1282 (CATEGORY_MEMBER): Enforce 1/0 value.
1283 * category.c (_temp_category_set): Remove.
1284
4c5501e9
EZ
12852012-06-16 Eli Zaretskii <eliz@gnu.org>
1286
1287 * window.c (Fdelete_other_windows_internal)
1288 (Fdelete_window_internal): Don't access frame's mouse highlight
1289 info of the initial frame. (Bug#11677)
1290
2b570124
PE
12912012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1292
e93864f9
PE
1293 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1294 Assume USE_2_TAGS_FOR_INTS.
1295 (xreload): Adjust $tagmask width to match recent lisp.h change.
1296
2b570124
PE
1297 Simplify lisp.h in minor ways that should not affect code.
1298 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1299 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1300 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1301 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1302 (INTTYPEBITS): New macro, for clarity.
1303 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1304 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1305 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1306 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1307 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1308
81755f69
JB
13092012-06-13 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1312
16192a57
GM
13132012-06-13 Glenn Morris <rgm@gnu.org>
1314
1315 * s/bsd-common.h (BSD4_3):
1316 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1317
646b5f55
AS
13182012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1321 instead of union.
1322 (XLI, XIL): Define.
1053a871
SM
1323 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1324 Use them.
1325 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1326 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1327 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1328 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1329 * frame.c (delete_frame): Remove outdated comment.
1330 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1331 USE_LISP_UNION_TYPE.
1332 (Fw32_unregister_hot_key): Likewise.
1333 (Fw32_toggle_lock_key): Likewise.
1334 * w32menu.c (add_menu_item): Likewise.
1335 (w32_menu_display_help): Use XIL instead of checking
1336 USE_LISP_UNION_TYPE.
1337 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1338 (init_heap): Likewise.
1339 * w32term.c (w32_read_socket): Update comment.
1340
1d3823c9
GM
13412012-06-13 Glenn Morris <rgm@gnu.org>
1342
c62ff706
GM
1343 * s/usg5-4-common.h, src/s/unixware.h:
1344 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1345
1d3823c9
GM
1346 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1347
bfe3e0a2
PE
13482012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1351 * alloc.c (make_number) [!defined make_number]:
1352 Remove, as lisp.h always defines this now.
1353 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1354 (roundup_size): Verify that it is a power of 2.
1355 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1356 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1357 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1358 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1359 USE_LSB_TAG now is always defined to be either 0 or 1.
1360 All uses changed.
1361 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1362 code works fine either way, and efficiency is not a concern here,
1363 as the union type is for debugging, not for production.
1364 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1365 Use an inline function on all platforms when using the union type,
1366 since this is simpler and 'static inline' can be used portably
1367 within Emacs now.
1368 (LISP_INITIALLY_ZERO): New macro.
1369 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1370 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1371
45fa9c0f
GM
13722012-06-12 Glenn Morris <rgm@gnu.org>
1373
b4492cba
GM
1374 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1375
1376 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1377
45fa9c0f
GM
1378 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1379 Move BROKEN_SIGIO to configure.
1380
1381 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1382 Move NO_TERMIO to configure.
1383
0e25d334
CY
13842012-06-12 Chong Yidong <cyd@gnu.org>
1385
1386 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1387 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1388 MagickExportImagePixels is undefined.
1389
43682bb6
PE
13902012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 * image.c (imagemagick_load_image): Remove unused label.
1393
a9be7d2b
GM
13942012-06-11 Glenn Morris <rgm@gnu.org>
1395
1396 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1397 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1398 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1399 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1400
3017f87f
SM
14012012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1402
1403 * alloc.c (make_byte_code): New function.
1404 (Fmake_byte_code): Use it. Don't purify here.
1405 * lread.c (read1): Use it as well to avoid extra allocation.
1406
1b9b4cf4
CY
14072012-06-11 Chong Yidong <cyd@gnu.org>
1408
1409 * image.c (imagemagick_load_image): Implement transparency.
1410
95988fcf
AS
14112012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1412
1413 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1414 account for preceding backslashes. (Bug#11663)
1415
cd4eb164
CY
14162012-06-09 Chong Yidong <cyd@gnu.org>
1417
1418 * term.c: Support italics in capable terminals (Bug#9652).
1419 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1420 (turn_on_face): Output using TS_enter_italic_mode if available.
1421 Don't handle unused blinking and alt-charset cases.
1422 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1423 and tty_alt_charset_p cases.
1424 (tty_capable_p, init_tty): Support italics.
1425
1426 * termchar.h (struct tty_display_info): Add field for italics.
1427 Remove unused blink field.
1428
1429 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1430 Handle slant.
1431
1432 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1433 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1434 tty_alt_charset_p. Add tty_italic_p.
1435
ff88beb8
MA
14362012-06-09 Michael Albinus <michael.albinus@gmx.de>
1437
1438 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1439 dbus_type_is_basic if available.
1440 (xd_extract_signed, xd_extract_unsigned): Rename from
1441 extract_signed and extract_unsigned, respectively. Adapt callers.
1442
44286096
CY
14432012-06-09 Chong Yidong <cyd@gnu.org>
1444
1682701f
CY
1445 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1446
44286096
CY
1447 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1448 case (Bug#9752).
1449
d86feb17
PE
14502012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 * xdisp.c (vmessage): Treat frame message as multibyte.
1453 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1454 would generate the diagnostic "Making \302\247 buffer-local while
1455 let-bound!".
1456
d5c20fe8
EZ
14572012-06-08 Eli Zaretskii <eliz@gnu.org>
1458
1459 * dispnew.c (showing_window_margins_p): Undo last change, which
1460 was done due to an inadvertent commit.
1461 (adjust_frame_glyphs_for_frame_redisplay): Do call
1462 showing_window_margins_p.
1463
513749ee
SM
14642012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1465
1466 * eval.c (Fmake_var_non_special): New primitive.
1467 (syms_of_eval): Defsubr it.
1468 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1469
d4a8f5c1
JB
14702012-06-08 Juanma Barranquero <lekktu@gmail.com>
1471
1472 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1473 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1474
8bbbc977
EZ
14752012-06-08 Eli Zaretskii <eliz@gnu.org>
1476
1477 * alloc.c (allocate_vectorlike): Fix last change.
1478
f3372c87
DA
14792012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1480
1481 Block-based vector allocation of small vectors.
1482 * lisp.h (struct vectorlike_header): New field `nbytes',
1483 adjust comment accordingly.
1484 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1485 to denote vector blocks. Adjust users (live_vector_p,
1486 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1487 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1488 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1489 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1490 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1491 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1492 (roundup_size): New constant.
1493 (struct vector_block): New data type.
1494 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1495 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1496 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1497 (sweep_vectors): New functions.
1498 (allocate_vectorlike): Return `zero_vector' as the only vector of
1499 0 items. Allocate new vector from block if vector size is less than
1500 or equal to VBLOCK_BYTES_MAX.
1501 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1502 (init_alloc_once): Add call to init_vectors.
1503
4f18a4ed
SM
15042012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1505
1506 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1507
86f158bc
PE
15082012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * doprnt.c (doprnt): Truncate multibyte char correctly.
1511 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1512 would mishandle a string argument "Xc" if X was a multibyte
1513 character of length 2: it would truncate after X's first byte
1514 rather than including all of X.
1515
c5cfcbe0
CY
15162012-06-06 Chong Yidong <cyd@gnu.org>
1517
1518 * buffer.c (word_wrap): Doc fix.
1519
c05cf390
PE
15202012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1523
0c3461de
GM
15242012-06-03 Glenn Morris <rgm@gnu.org>
1525
1526 * xdisp.c (tool-bar-style): Doc fix.
1527
c71232db
UM
15282012-06-03 Ulrich Müller <ulm@gentoo.org>
1529
1530 * Makefile.in (PAXCTL): Define.
1531 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1532 binary via PaX flags if the paxctl utility is available.
1533 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1534 Restore PaX flags to their default. (Bug#11398)
1535
383f7350
CY
15362012-06-03 Chong Yidong <cyd@gnu.org>
1537
1538 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1539 buffer (Bug#11226).
1540
5f2c76c6
CY
15412012-06-03 Chong Yidong <cyd@gnu.org>
1542
1543 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1544 (note_mode_line_or_margin_highlight): If there is no help echo,
1545 use mode-line-default-help-echo. Handle the case where the mouse
1546 position is past the end of the mode line string.
1547
1548 * buffer.c (buffer_local_value_1): New function, split from
1549 Fbuffer_local_value; can return Qunbound.
1550 (Fbuffer_local_value): Use it.
1551 (Vmode_line_format): Docstring tweaks.
1552
773d47f6
PE
15532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * sysdep.c (system_process_attributes): Improve comment.
1556
f2d6a3df
SM
15572012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1558
1559 * keyboard.c: Export real-this-command to Elisp.
1560 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1561 and DEFVAR it. Update all users.
1562
63810350
PE
15632012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1564
7bd5c1f4
PE
1565 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1566
63810350
PE
1567 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1568 Convert pctcpu and pctmem to Lisp float properly.
1569 Let the compiler fold better, as 100.0/0x8000 is exact.
1570
a2821611
AS
15712012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1572
1573 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1574 cons_block.
1575
5fceba1d
PE
15762012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1579
c98ff5dd
DA
15802012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1581
1582 For a 'struct window', replace some Lisp_Object fields to
1583 bitfields where appropriate, remove unused fields.
1584 * window.h (struct window): Remove unused 'last_mark_x' and
1585 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1586 change it's type from Lisp_Object to bitfield.
1587 Change type of 'force_start', 'optional_new_start',
1588 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1589 fields from Lisp_Object to bitfield. Adjust users accordingly.
1590
ca34e0be
PE
15912012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1592
1593 Pacify gcc -Wdouble-precision when using Xaw.
1594 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1595 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1596 Use 'float' consistently, rather than 'float' in most places
1597 and 'double' in a couple of places.
1598
efc00ab1 15992012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1600
1601 * xdisp.c (handle_stop): Detect whether we have overlay strings
1602 loaded by testing it->current.overlay_string_index to be
1603 non-negative, instead of checking whether n_overlay_strings is
1604 positive. (Bug#11587)
1605
efc00ab1 16062012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1607
1608 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1609
1610 * doc.c (Fsubstitute_command_keys): Doc fix.
1611
efc00ab1 16122012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1613
1614 * search.c (search_buffer): Remove calls to
1615 r_alloc_inhibit_buffer_relocation, as it is now called by
1616 maybe_unify_char, which was the cause of relocation of buffer text
1617 in bug#11519.
1618
efc00ab1 16192012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1620
1621 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1622 for the duration of call to load_charset, to avoid problems with
1623 callers of maybe_unify_char that access buffer text through C
1624 pointers.
1625
1626 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1627 decrement the inhibition flag, instead of just setting or
1628 resetting it.
1629
ba93a187
PE
16302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 Remove obsolete '#define static' cruft.
1633 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1634 This #undef was "temporary" in 2000; it is no longer needed
1635 now that '#define static' has gone away.
1636 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1637 (gray_bitmap_bits): Remove; no longer needed.
1638 All uses replaced with definiens.
1639 * xterm.c: Include "bitmaps/gray.xbm".
1640
9e4bf381
PE
16412012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 Clean up __executable_start, monstartup when --enable-profiling.
1644 The following changes affect the code only when profiling.
1645 * dispnew.c (__executable_start): Rename from safe_bcopy.
1646 Define only on platforms that need it.
1647 * emacs.c: Include <sys/gmon.h> when profiling.
1648 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1649 (__executable_start): Remove decl, since lisp.h does it now.
1650 (safe_bcopy): Remove decl; no longer has that name.
1651 (main): Coalesce #if into single bit of code, for simplicity.
1652 Cast pointers to uintptr_t, since standard libraries want integers
1653 and not pointers.
1654 * lisp.h (__executable_start): New decl.
1655
32d72c2f
GM
16562012-05-31 Glenn Morris <rgm@gnu.org>
1657
1658 * image.c (Fimagemagick_types): Doc fix.
1659
baac5bc7
JM
16602012-05-30 Jim Meyering <meyering@redhat.com>
1661
1662 * callproc.c (Fcall_process_region): Include directory component
1663 in mkstemp error message (Bug#11586).
1664
72cb32cf
PE
16652012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 * alloc.c, lisp.h (make_pure_vector): Now static.
1668
61b108cc
SM
16692012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1670
1671 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1672 Move to byte-run.el.
1673 (Fautoload): Do the hash-doc more carefully.
1674 * data.c (Fdefalias): Purify definition, except for keymaps.
1675 (Qdefun): Move from eval.c.
1676 * lisp.h (Qdefun): Remove.
1677 * lread.c (read1): Tiny simplification.
1678
471fe23d
TN
16792012-05-29 Troels Nielsen <bn.troels@gmail.com>
1680
934f3f58 1681 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1682 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1683 Bug#9642, but explicitly check that the buffer the overlay would
1684 be moved to is live and rearrange lines to make sure that errors
1685 will not put the overlay in an inconsistent state.
1686 (Fdelete_overlay): Cosmetics.
1687
85d0efd1
EZ
16882012-05-28 Eli Zaretskii <eliz@gnu.org>
1689
1690 * w32term.c (my_bring_window_to_top): New function.
1691 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1692 could be different from the original one.
1693 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1694 (Bug#11513)
1695
1696 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1697 by calling BringWindowToTop.
1698
1699 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1700 (WM_EMACS_END): Increase by one.
1701
da92a98c
PE
17022012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1705 This avoids undefined behavior that might cause the eassert
1706 to not catch an out-of-range value.
1707
74d1f848
JB
17082012-05-28 Juanma Barranquero <lekktu@gmail.com>
1709
1710 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1711 Update dependencies.
1712
9e1a06fc
EZ
17132012-05-27 Eli Zaretskii <eliz@gnu.org>
1714
1715 * bidi.c (bidi_mirror_char): Fix last change.
1716
f3dd7312
AS
17172012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1718
1719 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1720 when referring to sectname field in printf format.
1721
81899c91
PE
17222012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1723
57b81a9f
PE
1724 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1725 Only r_alloc_inhibit_buffer_relocation needed to be added;
1726 the others were already declared.
1727
81899c91
PE
1728 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1729 before checking whether it's out of range. Put the check inside
1730 eassert. See
1731 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1732
33017faf 17332012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1734
1735 * callproc.c (Fcall_process): Restore a line that was accidentally
1736 commented out in the 2011-02-13 change (bug#11547).
1737
33017faf 17382012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1739
1740 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1741 defined on ralloc.c.
1742
1743 * buffer.c [REL_ALLOC]: Remove prototypes of
1744 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1745 they are now on lisp.h.
1746
1747 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1748
1749 * search.c (search_buffer): Use it to inhibit relocation of buffer
1750 text while re_search_2 is doing its job, because re_search_2 is
1751 passed C pointers to buffer text. (Bug#11519)
1752
23415acf
EZ
1753 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1754 Update value to 24.
1755
44e27368
EZ
1756 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1757 state after an additional call to move_it_in_display_line_to, keep
1758 the values of it->max_ascent and it->max_descent found for the
1759 entire line.
1760 (pos_visible_p): Revert the comparison against bottom_y to what it
1761 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1762 (Bug#11464)
1763
c1892f11
PE
17642012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 Fix coding-related core dumps with gcc -ftrapv.
1767 The code was computing A - B, where A and B are pointers, and B is
1768 random garbage. This can lead to core dumps on platforms that
1769 have special pointer registers, and it also leads to core dumps on
1770 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1771 A - B only when B is initialized properly.
1772 * coding.c (coding_set_source, coding_set_destination): Return void.
1773 (coding_change_source, coding_change_destinations): New functions,
1774 with the old behaviors of coding_set_source and coding_set_destination.
1775 All callers that need an offset changed to use these new functions.
1776
eb7afdad
GM
17772012-05-26 Glenn Morris <rgm@gnu.org>
1778
1779 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1780
f12fdf02
EZ
17812012-05-26 Eli Zaretskii <eliz@gnu.org>
1782
53a63be6 1783 Extend mouse support on W32 text-mode console.
61b108cc
SM
1784 * xdisp.c (draw_row_with_mouse_face):
1785 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1786
eb3f6f01 1787 * w32console.c: Include window.h.
61b108cc
SM
1788 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1789 New functions.
eb3f6f01
EZ
1790 (initialize_w32_display): Initialize mouse-highlight data.
1791
53a63be6
EZ
1792 * w32inevt.c: Include termchar.h and window.h.
1793 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1794 moves, call note_mouse_highlight. If help_echo changed, call
1795 gen_help_event to produce help-echo message in the echo area.
1796 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1797 highlight info.
1798
4cfd81f6
PE
17992012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * lread.c (read1): Simplify slightly to avoid an overflow warning
1802 with GCC 4.7.0 on x86-64.
1803
4446092a
EZ
18042012-05-26 Eli Zaretskii <eliz@gnu.org>
1805
1806 * bidi.c (bidi_mirror_char): Revert last change: an int is
1807 definitely wide enough here.
1808
42b2a986 18092012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1810
42b2a986 1811 Fix integer width and related bugs (Bug#9874).
eb106a49 1812 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1813 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1814 (string_bytes, check_sblock, allocate_string_data):
1815 (compact_small_strings, Fmake_bool_vector, make_string)
1816 (make_unibyte_string, make_multibyte_string)
1817 (make_string_from_bytes, make_specified_string)
1818 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1819 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1820 (mark_vectorlike):
1821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1822 (allocate_pseudovector):
1823 Use int, not EMACS_INT, where int is wide enough.
1824 (inhibit_garbage_collection, Fgarbage_collect):
1825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1826 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1827 int might not be wide enough.
1828 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1829 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1830 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1831 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1832 (bidi_level_of_next_char, bidi_move_to_visually_next):
1833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1834 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1835 (Fkill_buffer, Fset_buffer_major_mode)
1836 (advance_to_char_boundary, Fbuffer_swap_text)
1837 (Fset_buffer_multibyte, overlays_at, overlays_in)
1838 (overlay_touches_p, struct sortvec, record_overlay_string)
1839 (overlay_strings, recenter_overlay_lists)
1840 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1841 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1842 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1843 (Foverlay_recenter, last_overlay_modification_hooks_used)
1844 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1846 (validate_region): Omit unnecessary test for b <= e,
1847 since that's guaranteed by the previous test.
d311d28c
PE
1848 (adjust_overlays_for_delete): Avoid pos + length overflow.
1849 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1850 (report_overlay_modification):
1851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1852 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1853 Omit pointer cast, which isn't needed anyway, and doesn't work
1854 after the EMACS_INT -> ptrdiff_t change.
02481186 1855 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1856 * buffer.h: Adjust decls to match defn changes elsewhere.
1857 (struct buffer_text, struct buffer):
1858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1859 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1860 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1861 not int, to avoid needless 32-bit limit on 64-bit hosts.
1862 (exec_byte_code): Use tighter memory-full test, one that checks
1863 for alloca overflow. Don't compute the address of the object just
1864 before an array, as that's not portable. Use EMACS_INT, not
1865 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1866 * callint.c (Fcall_interactively):
1867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1868 * callproc.c (call_process_kill, Fcall_process):
1869 Don't assume pid_t fits into an Emacs fixnum.
1870 (call_process_cleanup, Fcall_process, child_setup):
1871 Don't assume pid_t fits into int.
1872 (call_process_cleanup, Fcall_process, delete_temp_file)
1873 (Fcall_process_region):
1874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1875 (Fcall_process): Simplify handling of volatile integers.
1876 Use int, not EMACS_INT, where int will do.
1877 * casefiddle.c (casify_object, casify_region, operate_on_word)
1878 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1880 (casify_object): Avoid integer overflow when overallocating buffer.
1881 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1882 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1883 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1884 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1885 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1886 integers are now checked earlier. All uses replaced with XINT.
1887 (ccl_driver):
1888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1889 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1890 (ccl_driver, Fregister_code_conversion_map):
1891 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1892 (resolve_symbol_ccl_program): Check that vector header is in range.
1893 Always copy the vector, so that we can check its contents reliably
1894 now rather than having to recheck each instruction as it's being
1895 executed. Check that vector words fit in 'int'.
1896 (ccl_get_compiled_code, Fregister_ccl_program)
1897 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1898 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1899 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1900 contents are in range.
1901 (Fccl_execute_on_string): Check that status is in range.
1902 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1903 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1904 Accept and return EMACS_INT, not int, because callers can pass values
1905 out of 'int' range.
1906 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1907 (multibyte_chars_in_text, parse_str_as_multibyte)
1908 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1909 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1910 (string_escape_byte8, Fget_byte):
1911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1912 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1913 avoid mishandling large integers.
1914 * character.h: Adjust decls to match defn changes elsewhere.
1915 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1916 (Ffind_charset_region):
1917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1918 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1919 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1920 Don't assume fixnum fits in int.
d311d28c
PE
1921 (load_charset_map_from_vector, Fmap_charset_chars):
1922 Remove now-unnecessary CHECK_NATNUMs.
1923 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1924 Don't rely on undefined behavior with signed left shift overflow.
1925 Don't assume unsigned int fits into fixnum, or that fixnum fits
1926 into unsigned int. Don't require max_code to be a valid fixnum;
1927 that's not true for gb10830 4-byte on a 32-bit host. Allow
1928 invalid_code to be a cons, for the same reason. Require code_offset
1929 to be a character. Avoid int overflow if max_char is close
1930 to INT_MAX.
1931 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1932 this is intended anyway and avoids some undefined behavior.
1933 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1934 INDEX_TO_CODE_POINT, as that's what it expects.
1935 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1936 * charset.h (DECODE_CHAR): Return int, not unsigned;
1937 this is what was intended anyway, and it avoids undefined behavior.
1938 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1939 integer-overflow issues.
1940 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1941 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1942 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1943 * chartab.c (Fmake_char_table, Fset_char_table_range)
1944 (uniprop_get_decoder, uniprop_get_encoder):
1945 Don't assume fixnum fits in int.
1946 * cmds.c (move_point): New function, that does the gist of
1947 Fforward_char and Fbackward_char, but does so while checking
1948 for integer overflow more accurately.
c96e5d6a 1949 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1950 (Fforward_line, Fend_of_line, internal_self_insert)
1951 (internal_self_insert):
1952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1953 Fix a FIXME, by checking for integer overflow when calculating
1954 target_clm and actual_clm.
1955 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1956 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1957 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1958 (coding_alloc_by_making_gap, alloc_destination)
1959 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1960 (encode_coding_utf_16, detect_coding_emacs_mule)
1961 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1962 (detect_coding_iso_2022, decode_coding_iso_2022)
1963 (encode_invocation_designation, encode_designation_at_bol)
1964 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1965 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1966 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1967 (encode_coding_ccl, encode_coding_raw_text)
1968 (detect_coding_charset, decode_coding_charset)
1969 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1970 (produce_composition, produce_charset, produce_annotation)
1971 (decode_coding, handle_composition_annotation)
1972 (handle_charset_annotation, consume_chars, decode_coding_gap)
1973 (decode_coding_object, encode_coding_object, detect_coding_system)
1974 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1975 (code_convert_region, code_convert_string)
8f50130c
PE
1976 (Fdefine_coding_system_internal)
1977 (coding_set_source, coding_set_destination):
d311d28c
PE
1978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1979 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1980 (Fdefine_coding_system_internal):
1981 Don't assume fixnums fit in int.
1982 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1983 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1984 (Funencodable_char_position, Fcheck_coding_systems_region)
1985 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1987 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1988 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1989 Don't access memory outside of the args array.
d311d28c 1990 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1991 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1992 result of ENCODE_CHAR.
d311d28c
PE
1993 * coding.h: Adjust decls to match defn changes elsewhere.
1994 (struct coding_system):
1995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1996 * composite.c (get_composition_id, find_composition)
1997 (run_composition_function, update_compositions)
1998 (compose_text, composition_gstring_put_cache)
1999 (composition_gstring_p, composition_gstring_width)
2000 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2001 (composition_compute_stop_pos, composition_reseat_it)
2002 (composition_update_it, struct position_record)
2003 (find_automatic_composition, composition_adjust_point)
2004 (Fcomposition_get_gstring, Ffind_composition_internal):
2005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2006 (update_compositions):
2007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2008 * composite.h: Adjust decls to match defn changes elsewhere.
2009 (struct composition):
2010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2011 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2012 Do not attempt to compute the address of the object just before a
2013 buffer; this is not portable.
2014 (Faref, Faset):
2015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2016 (Faset): Use int, not EMACS_INT, where int is wide enough.
2017 (Fstring_to_number): Don't assume fixnums fit in int.
2018 (Frem): Don't assume arg is nonnegative.
2019 * dbusbind.c (xd_append_arg): Check for integers out of range.
2020 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2021 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2022 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2023 (xd_get_connection_references): Return ptrdiff_t, not int.
2024 All uses changed.
2025 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2026 (xd_read_message_1):
2027 Use int, not unsigned, where the dbus API uses int.
2028 (Fdbus_message_internal): Don't overflow mtype.
2029 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2030 * dired.c (directory_files_internal, file_name_completion, scmp)
2031 (file_name_completion_stat):
2032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2033 (file_name_completion): Don't overflow matchcount.
2034 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2035 * dispextern.h: Adjust decls to match defn changes elsewhere.
2036 (struct text_pos, struct glyph, struct bidi_saved_info)
2037 (struct bidi_string_data, struct bidi_it, struct composition_it)
2038 (struct it):
2039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2040 (struct display_pos, struct composition_it, struct it):
2041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2042 * dispnew.c (increment_matrix_positions)
2043 (increment_row_positions, mode_line_string)
2044 (marginal_area_string):
2045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2046 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2048 (duration_to_sec_usec): New function, to check for overflow better.
2049 (Fsleep_for, sit_for): Use it.
2050 * doc.c (get_doc_string, store_function_docstring):
2051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2052 (get_doc_string, Fsnarf_documentation):
2053 Use int, not EMACS_INT, where int is wide enough.
2054 (get_doc_string):
2055 Use SAFE_ALLOCA, not alloca.
2056 Check for overflow when converting EMACS_INT to off_t.
2057 * doprnt.c (doprnt):
2058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2059 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2060 Don't assume uid_t fits into fixnum.
2061 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2062 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2063 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2064 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2065 (general_insert_function)
2066 (Finsert_char, make_buffer_string, make_buffer_string_both)
2067 (update_buffer_properties, Fbuffer_substring)
2068 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2069 (Fsubst_char_in_region, check_translation)
2070 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2071 (transpose_markers, Ftranspose_regions):
2072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2073 (clip_to_bounds): Move to lisp.h as an inline function).
2074 (Fconstrain_to_field): Don't assume integers are nonnegative.
2075 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2076 (Fsubst_char_in_region, Fsave_restriction):
2077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2078 (Femacs_pid): Don't assume pid_t fits into fixnum.
2079 (lo_time): Use int, not EMACS_INT, when int suffices.
2080 (lisp_time_argument): Check for usec out of range.
2081 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2082 (Fuser_login_name, Fuser_full_name): Signal an error
2083 if a uid argument is out of range, rather than relying on
2084 undefined behavior.
c8d5c857
PE
2085 (Fformat_time_string): Remove now-unnecessary check.
2086 lisp_time_argument checks for out-of-range usec now.
243e0530 2087 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2088 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2089 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2090 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2091 (init_cmdargs, Fdump_emacs):
2092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2093 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2094 the bottom (typically) 32 bits of the fixnum.
2095 * eval.c (specpdl_size, call_debugger):
2096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2097 (when_entered_debugger, Fbacktrace_debug):
2098 Don't assume fixnum can fit in int.
2099 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2100 the object just before a buffer; this is not portable.
2101 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2102 (grow_specpdl, unbind_to):
2103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2104 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2105 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2106 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2107 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2108 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2110 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2111 (a_write, e_write):
2112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2113 (Fcopy_file, non_regular_nbytes, read_non_regular)
2114 (Finsert_file_contents):
2115 Use int, not EMACS_INT, where int is wide enough.
2116 (READ_BUF_SIZE): Verify that it fits in int.
2117 (Finsert_file_contents): Check that counts are in proper range,
2118 rather than assuming fixnums fit into ptrdiff_t etc.
2119 Don't assume fixnums fit into int.
125b3835 2120 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2121 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2122 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2123 (string_char_to_byte, string_byte_to_char)
2124 (string_make_multibyte, string_to_multibyte)
2125 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2126 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2127 (substring_both, Fdelete, internal_equal, Ffillarray)
2128 (Fclear_string, mapcar1)
2129 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2130 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2131 (larger_vector, make_hash_table, maybe_resize_hash_table)
2132 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2133 (Fmaphash, secure_hash):
2134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2135 (concat): Check for string index and length overflow.
2136 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2137 (Frequire):
2138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2139 (larger_vector): New API (vec, incr_min, size_max) replaces old
2140 one (vec, new_size, init). This catches size overflow.
2141 INIT was removed because it was always Qnil.
2142 All callers changed.
2143 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2144 the upper bound on a hash table index size.
2145 (make_hash_table, maybe_resize_hash_table): Use it.
2146 (secure_hash): Computer start_byte and end_byte only after
2147 they're known to be in ptrdiff_t range.
2148 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2149 (Ffont_get_glyphs, Ffont_at):
2150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2151 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2152 (Flist_fonts, Fopen_font):
2153 Don't assume fixnum can fit in int.
2154 (check_gstring): Don't assume index can fit in int.
2155 (font_match_p): Check that fixnum is a character, not a nonnegative
2156 fixnum, since the later code needs to stuff it into an int.
2157 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2158 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2159 conversion overflow issues.
2160 (Fopen_font): Check for integer out of range.
2161 (Ffont_get_glyphs): Don't assume index can fit in int.
2162 * font.h: Adjust decls to match defn changes elsewhere.
2163 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2164 integer overflow.
2165 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2166 printmax_t, where ptrdiff_t is wide enough.
2167 (Finternal_char_font):
2168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2169 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2170 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2171 (Fset_frame_position, x_set_frame_parameters)
2172 (x_set_line_spacing, x_set_border_width)
2173 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2174 Check that fixnums are in proper range for system types.
2175 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2177 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2178 Use SAFE_ALLOCA_LISP, not alloca.
2179 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2180 intptr_t is wide enough.
2181 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2182 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2183 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2184 Check for fixnum out of range.
2185 * ftfont.c (ftfont_list): Don't assume index fits in int.
2186 Check that fixnums are in proper range for system types.
2187 (ftfont_shape_by_flt):
2188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2189 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2191 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2192 Check that fixnums are in proper range for system types.
2193 * gnutls.h: Adjust decls to match defn changes elsewhere.
2194 * gtkutil.c (xg_dialog_run):
2195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2196 (update_frame_tool_bar):
2197 Check that fixnums are in proper range for system types.
2198 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2199 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2200 * indent.c (last_known_column, last_known_column_point):
2201 (current_column_bol_cache):
2202 (skip_invisible, current_column, check_display_width):
2203 (check_display_width, scan_for_column, current_column_1)
2204 (Findent_to, Fcurrent_indentation, position_indentation)
2205 (indented_beyond_p, Fmove_to_column, compute_motion):
2206 (Fcompute_motion, Fvertical_motion):
2207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2208 (last_known_column_modified): Use EMACS_INT, not int.
2209 (check_display_width):
2210 (Fcompute_motion):
2211 Check that fixnums and floats are in proper range for system types.
2212 (compute_motion): Don't assume index or fixnum fits in int.
2213 (compute_motion, Fcompute_motion):
2214 Use int, not EMACS_INT, when it is wide enough.
2215 (vmotion): Omit local var start_hpos that is always 0; that way
2216 we don't need to worry about overflow in expressions involving it.
2217 * indent.h: Adjust decls to match defn changes elsewhere.
2218 (struct position):
2219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2220 Use int, not EMACS_INT, where int is wide enough.
2221 Remove unused members ovstring_chars_done and tab_offset;
2222 all uses removed.
2223 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2224 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2225 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2226 (make_gap, copy_text, insert, insert_and_inherit)
2227 (insert_before_markers, insert_before_markers_and_inherit)
2228 (insert_1, count_combining_before, count_combining_after)
2229 (insert_1_both, insert_from_string)
2230 (insert_from_string_before_markers, insert_from_string_1)
2231 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2232 (adjust_after_replace, adjust_after_insert, replace_range)
2233 (replace_range_2, del_range, del_range_1, del_range_byte)
2234 (del_range_both, del_range_2, modify_region)
2235 (prepare_to_modify_buffer, signal_before_change)
2236 (signal_after_change, Fcombine_after_change_execute):
2237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2238 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2239 (balance_an_interval, split_interval_right, split_interval_left)
2240 (find_interval, next_interval, update_interval)
2241 (adjust_intervals_for_insertion, delete_node, delete_interval)
2242 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2243 (static_offset_intervals, offset_intervals)
2244 (merge_interval_right, merge_interval_left, make_new_interval)
2245 (graft_intervals_into_buffer, temp_set_point_both)
2246 (temp_set_point, set_point, adjust_for_invis_intang)
2247 (set_point_both, move_if_not_intangible, get_property_and_range)
2248 (get_local_map, copy_intervals, copy_intervals_to_string)
2249 (compare_string_intervals, set_intervals_multibyte_1):
2250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2251 * intervals.h: Adjust decls to match defn changes elsewhere.
2252 (struct interval):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 * keyboard.c (this_command_key_count, this_single_command_key_start)
2255 (before_command_key_count, before_command_echo_length, echo_now)
2256 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2257 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2258 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2259 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2261 (last_non_minibuf_size, last_point_position, echo_truncate)
2262 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2263 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2264 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2265 (stuff_buffered_input):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (last_auto_save, command_loop_1, read_char):
2268 Use EMACS_INT, not int, to avoid integer overflow.
2269 (record_char): Avoid overflow in total_keys computation.
2270 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2271 * keyboard.h: Adjust decls to match defn changes elsewhere.
2272 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2273 (Fkey_description, Fdescribe_vector, Flookup_key):
2274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2275 (click_position): New function, to check that positions are in range.
2276 (Fcurrent_active_maps):
2277 (describe_command):
2278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2279 (Faccessible_keymaps, Fkey_description):
2280 (preferred_sequence_p):
2281 Don't assume fixnum can fit into int.
2282 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2283 Check for integer overflow in size calculations.
2284 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2285 avoid mishandling large integers.
2286 * lisp.h: Adjust decls to match defn changes elsewhere.
2287 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2288 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2289 (struct Lisp_Marker):
2290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2291 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2292 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2293 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2294 All callers changed.
2295 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2296 Assume the arg has valid form, since it always does.
2297 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2298 unsigned integer system type.
2299 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2300 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2302 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2303 (duration_to_sec_usec): New decl.
2304 * lread.c (read_from_string_index, read_from_string_index_byte)
2305 (read_from_string_limit, readchar, unreadchar, openp)
2306 (read_internal_start, read1, oblookup):
2307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2308 (Fload, readevalloop, Feval_buffer, Feval_region):
2309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2310 (openp): Check for out-of-range argument to 'access'.
2311 (read1): Use int, not EMACS_INT, where int is wide enough.
2312 Don't assume fixnum fits into int.
6efdadfd 2313 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2314 (read_filtered_event): Use duration_to_sec_usec
2315 to do proper overflow checking on durations.
d311d28c
PE
2316 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2317 in size calculation.
2318 (Fexecute_kbd_macro):
2319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2320 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2321 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2322 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2323 (set_marker_both, set_marker_restricted_both, marker_position)
2324 (marker_byte_position, Fbuffer_has_markers_at):
2325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2326 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2327 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2328 It now merely ensures that the menu is large enough, without
2329 necessarily growing it, as this avoids some integer overflow issues.
2330 All callers changed.
2331 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2333 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2334 Use SAFE_ALLOCA_LISP, not alloca.
2335 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2336 to EMACS_INT. Check that fixnums are in proper range for system types.
2337 * minibuf.c (minibuf_prompt_width, string_to_object)
2338 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2339 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2341 (get_minibuffer, read_minibuf_unwind):
2342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2343 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2344 this simplifies overflow checking. All callers changed.
2345 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2346 (Ftest_completion):
2347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2348 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2349 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2350 Check that fixnums are in proper range for system types.
2351 (Fx_create_frame, Fx_show_tip):
2352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2353 * nsfont.m (ns_findfonts, nsfont_list_family):
2354 Don't assume fixnum fits in long.
2355 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2357 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2358 wide enough.
17fdb222 2359 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2361 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2362 (PRINTDECLARE, PRINTPREPARE):
2363 (strout, print_string):
2364 (print, print_preprocess, print_check_string_charset_prop)
2365 (print_object):
2366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2367 (PRINTDECLARE):
2368 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2370 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2371 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2372 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2373 (print_error_message): Use SAFE_ALLOCA, not alloca.
2374 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2375 (print_depth, new_backquote_output, print_number_index):
2376 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2377 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2378 (Fset_process_window_size, Fformat_network_address)
2379 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2380 (sigchld_handler):
d311d28c 2381 Check that fixnums are in proper range for system types.
d44287d4 2382 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2383 Check for process-ids out of pid_t range rather than relying on
2384 undefined behavior.
e4d81efc 2385 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2386 (Fformat_network_address, read_process_output, send_process)
2387 (Fprocess_send_region, status_notify):
2388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2389 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2390 (wait_reading_process_output, read_process_output, exec_sentinel):
2391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2392 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2393 (Faccept_process_output): Use duration_to_sec_usec to do proper
2394 overflow checking on durations.
dde14581
PE
2395 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2396 Don't assume pid_t fits in int.
02481186
PE
2397 * process.h (struct Lisp_Process): Members tick and update_tick
2398 are now of type EMACS_INT, not int.
b62b53e8
PE
2399 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2400 configured --with-wide-int.
d311d28c
PE
2401 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2402 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2403 * search.c (looking_at_1, string_match_1):
2404 (fast_string_match, fast_c_string_match_ignore_case)
2405 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2406 (scan_newline, find_before_next_newline, search_command)
2407 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2408 (set_search_regs, wordify):
2409 (Freplace_match):
2410 (Fmatch_data):
2411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2412 (string_match_1, search_buffer, set_search_regs):
2413 (Fmatch_data):
2414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2415 (wordify): Check for overflow in size calculation.
2416 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2417 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2418 Check that fixnums are in proper range for system types.
2419 * sound.c (struct sound_device)
2420 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2422 (Fplay_sound_internal):
2423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2424 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2425 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2426 (Fparse_partial_sexp):
2427 Don't assume fixnums can fit in int.
2428 (struct lisp_parse_state, find_start_pos, find_start_value)
2429 (find_start_value_byte, find_start_begv)
2430 (update_syntax_table, char_quoted, dec_bytepos)
2431 (find_defun_start, prev_char_comend_first, back_comment):
2432 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2433 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2435 (Finternal_describe_syntax_value): Check that match_lisp is a
2436 character, not an integer, since the code stuffs it into int.
2437 (scan_words, scan_sexps_forward):
2438 Check that fixnums are in proper range for system types.
2439 (Fforward_word):
2440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2441 (scan_sexps_forward):
2442 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2443 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2444 * syntax.h: Adjust decls to match defn changes elsewhere.
2445 (struct gl_state_s):
2446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2447 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2448 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2449 * sysdep.c (wait_for_termination_1, wait_for_termination)
2450 (interruptible_wait_for_termination, mkdir):
2451 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2452 (emacs_read, emacs_write):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2454 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2455 and double all fit in int.
d311d28c
PE
2456 * term.c (set_tty_color_mode):
2457 Check that fixnums are in proper range for system types.
2458 * termhooks.h (struct input_event):
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2460 * textprop.c (validate_interval_range, interval_of)
2461 (Fadd_text_properties, set_text_properties_1)
2462 (Fremove_text_properties, Fremove_list_of_text_properties)
2463 (Ftext_property_any, Ftext_property_not_all)
2464 (copy_text_properties, text_property_list, extend_property_ranges)
2465 (verify_interval_modification):
2466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2467 (Fnext_single_char_property_change)
2468 (Fprevious_single_char_property_change):
2469 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2470 (copy_text_properties):
2471 Check for integer overflow in index calculation.
d311d28c
PE
2472 * undo.c (last_boundary_position, record_point, record_insert)
2473 (record_delete, record_marker_adjustment, record_change)
2474 (record_property_change):
2475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2476 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2478 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2479 (Fx_hide_tip, Fx_file_dialog):
2480 * w32menu.c (set_frame_menubar):
2481 Use ptrdiff_t, not int, for consistency with rest of code.
2482 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2483 (select_window, Fdelete_other_windows_internal)
2484 (window_scroll_pixel_based, window_scroll_line_based)
2485 (Frecenter, Fset_window_configuration):
2486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2487 (Fset_window_hscroll, run_window_configuration_change_hook)
2488 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2489 (Fscroll_other_window, Frecenter):
d311d28c
PE
2490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2491 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2492 Don't assume fixnum fits in int.
2493 (Fset_window_scroll_bars):
2494 Check that fixnums are in proper range for system types.
2495 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2496 (string_pos, c_string_pos, number_of_chars, init_iterator)
2497 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2498 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2499 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2500 (face_before_or_after_it_pos, handle_invisible_prop)
2501 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2502 (display_prop_intangible_p, string_buffer_position_lim)
2503 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2504 (get_overlay_strings_1, get_overlay_strings)
2505 (iterate_out_of_display_property, forward_to_next_line_start)
2506 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2507 (get_next_display_element, set_iterator_to_next)
2508 (get_visually_first_element, compute_stop_pos_backwards)
2509 (handle_stop_backwards, next_element_from_buffer)
2510 (move_it_in_display_line_to, move_it_in_display_line)
2511 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2512 (add_to_log, message_dolog, message_log_check_duplicate)
2513 (message2, message2_nolog, message3, message3_nolog
2514 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2515 (current_message_1, truncate_echo_area, truncate_message_1)
2516 (set_message, set_message_1, store_mode_line_noprop)
2517 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2518 (text_outside_line_unchanged_p, check_point_in_composition)
2519 (reconsider_clip_changes)
2520 (redisplay_internal, set_cursor_from_row, try_scrolling)
2521 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2522 (redisplay_window, find_last_unchanged_at_beg_row)
2523 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2524 (trailing_whitespace_p, find_row_edges, display_line)
2525 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2526 (display_mode_element, store_mode_line_string)
2527 (pint2str, pint2hrstr, decode_mode_spec)
2528 (display_count_lines, display_string, draw_glyphs)
2529 (x_produce_glyphs, x_insert_glyphs)
2530 (rows_from_pos_range, mouse_face_from_buffer_pos)
2531 (fast_find_string_pos, mouse_face_from_string_pos)
2532 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2534 (safe_call, init_from_display_pos, handle_fontified_prop)
2535 (handle_single_display_spec, load_overlay_strings)
2536 (with_echo_area_buffer, setup_echo_area_for_printing)
2537 (display_echo_area, echo_area_display)
2538 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2539 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2540 (redisplay_window, dump_glyph_row, display_mode_line)
2541 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2542 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2544 (handle_single_display_spec, build_desired_tool_bar_string)
2545 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2546 (get_specified_cursor_type):
2547 Check that fixnums are in proper range for system types.
2548 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2549 (Flookup_image_map):
2550 Don't assume fixnums fit in int.
2551 (compare_overlay_entries):
2552 Avoid mishandling comparisons due to subtraction overflow.
2553 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2554 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2555 (handle_tool_bar_click):
2556 Use int, not unsigned, since we prefer signed and the signedness
2557 doesn't matter here.
2558 (get_next_display_element, next_element_from_display_vector):
2559 Use int, not EMACS_INT, when int is wide enough.
2560 (start_hourglass): Use duration_to_sec_usec to do proper
2561 overflow checking on durations.
2562 * xfaces.c (Fbitmap_spec_p):
2563 Check that fixnums are in proper range for system types.
2564 (compare_fonts_by_sort_order):
2565 Avoid mishandling comparisons due to subtraction overflow.
2566 (Fx_family_fonts, realize_basic_faces):
2567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2568 (Fx_family_fonts):
2569 Don't assume fixnum fits in int.
2570 Use SAFE_ALLOCA_LISP, not alloca.
2571 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2572 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2573 (face_at_buffer_position, face_for_overlay_string)
2574 (face_at_string_position):
2575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2576 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2577 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2578 (Fx_show_tip):
2579 Check that fixnums are in proper range for system types.
2580 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2581 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2583 (Fx_change_window_property): Don't assume fixnums fit in int.
2584 * xfont.c (xfont_chars_supported):
2585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2586 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2587 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2589 * xml.c (parse_region):
2590 * xrdb.c (magic_file_p):
2591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2592 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2593 (x_get_local_selection, x_reply_selection_request)
2594 (x_handle_selection_request, wait_for_property_change):
2595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2596 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2597 short is wide enough.
2598 (x_send_client_event): Don't assume fixnum fits in int.
2599 * xterm.c (x_x_to_emacs_modifiers):
2600 Don't assume EMACS_INT overflows nicely into int.
2601 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2602 may come from Lisp.
2603 (handle_one_xevent): NATNUMP can eval its arg twice.
2604 (x_connection_closed):
2605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2606 * xterm.h: Adjust decls to match defn changes elsewhere.
2607 (struct scroll_bar): Use struct vectorlike_header
2608 rather than rolling our own approximation.
2609 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2610
c6574eb5
GM
26112012-05-25 Glenn Morris <rgm@gnu.org>
2612
2613 * lisp.mk (lisp): Update for more files being compiled now.
2614
e8d32c7e
SM
26152012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2616
48def666
SM
2617 * lread.c: Remove `read_pure' which makes no difference.
2618 (read_pure): Remove var.
2619 (unreadpure): Remove function.
2620 (readevalloop): Don't call read_list with -1 flag.
2621 (read1, read_vector): Don't test read_pure any more.
2622 (read_list): Simplify.
2623
e8d32c7e
SM
2624 * fileio.c, character.h: Minor style tweaks.
2625
4b2addb7
DA
26262012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2627
2628 * window.h (clip_changed): Remove useless declaration.
2629
584461b2
JB
26302012-05-22 Juanma Barranquero <lekktu@gmail.com>
2631
2632 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2633 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2634
34374650
PE
26352012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2636
2637 Remove src/m/*.
2638 This directory predates autoconf and is no longer needed nowadays.
2639 Move its few remaining bits of functionality to where they're needed.
2640 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2641 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2642 * m/template.h: Remove.
2643 * Makefile.in (M_FILE): Remove. All uses removed.
2644 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2645 * lisp.h (USE_LSB_TAG):
2646 * mem-limits.h (EXCEEDS_LISP_PTR):
2647 Use VAL_MAX, not VALBITS, in #if.
2648 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2649 (EMACS_UINT): Define unconditionally now.
2650 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2651 (BITS_PER_EMACS_INT): New constants, replacing
2652 what used to be in config.h, but not useful in #if.
2653 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2654 define them any more.
2655 (VAL_MAX): New macro.
2656 (VALMASK): Use it.
2657 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2658 BITS_PER_EMACS_INT, in #if.
2659 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2660 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2661 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2662 * s/ms-w32.h (DATA_START):
2663 Move here from removed file m/intel386.h.
2664 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2665 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2666
261cb4bb
PE
26672012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 Assume C89 or later.
2670 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2671 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2672 (xrealloc):
2673 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2674 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2675 * textprop.c, tparam.c (NULL): Remove.
2676 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2677 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2678 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2679 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2680 * xterm.c (input_signal_count): Assume volatile works.
2681
ff23cd9f
KB
26822012-05-21 Ken Brown <kbrown@cornell.edu>
2683
2684 * xgselect.c (xg_select): Fix first argument in call to 'select'
2685 (bug#11508).
2686
1b170bc6
KB
26872012-05-20 Ken Brown <kbrown@cornell.edu>
2688
2689 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2690 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2691
b2f4d39f
KB
26922012-05-19 Ken Brown <kbrown@cornell.edu>
2693
2694 * xfns.c (x_in_use): Remove `static' qualifier.
2695 * xterm.h (x_in_use): Declare.
2696 * xgselect.c: Include xterm.h.
2697 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2698 and `display_arg' (bug#9754).
2699
003fdae2
PE
27002012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2701
9232a6d9
PE
2702 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2703
003fdae2
PE
2704 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2705 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2706
784b56e2
EZ
27072012-05-18 Eli Zaretskii <eliz@gnu.org>
2708
2709 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2710
2711 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2712 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2713
2714 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2715 reference to image_cache->refcount.
2716 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2717
a0a79cde
JL
27182012-05-17 Juri Linkov <juri@jurta.org>
2719
2720 * search.c (Fword_search_regexp, Fword_search_backward)
2721 (Fword_search_forward, Fword_search_backward_lax)
2722 (Fword_search_forward_lax): Move functions to isearch.el
2723 (bug#10145, bug#11381).
2724
b0572523
PE
27252012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2726
2727 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2728
9660f5fc
SM
27292012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2730
2731 * lread.c (init_obarray): Declare Qt and Qnil as special.
2732
4374de83
GM
27332012-05-14 Glenn Morris <rgm@gnu.org>
2734
2735 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2736 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2737
dc44c39a
PE
27382012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2739
078c97cb
PE
2740 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2741
dc44c39a
PE
2742 * unexaix.c: Port to more-recent AIX compilers.
2743 (report_error, report_error_1, make_hdr, copy_sym)
2744 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2745 Make arguments const char *, not char *, to avoid violations of C
2746 standard and to fix some AIX warnings reported by Gilles Pion.
2747
e18afed7 27482012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2749
2750 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2751 already have overlays loaded.
2752 (handle_single_display_spec): Before returning without displaying
2753 fringe bitmap, synchronize the bidi iterator with the main display
2754 iterator, by calling iterate_out_of_display_property.
2755 (iterate_out_of_display_property): Detect buffer iteration by
2756 testing that it->string is a Lisp string.
2757 (get_next_display_element): When the current object is exhausted,
2758 and there's something on it->stack, call set_iterator_to_next to
2759 proceed with what's on the stack, instead of returning zero.
2760 (set_iterator_to_next): If called at the end of a Lisp string,
2761 proceed to consider_string_end without incrementing string
2762 position. Don't increment display vector index past the end of
2763 the display vector. (Bug#11417)
c8fb9dc6
EZ
2764 (pos_visible_p): Don't report a position visible when move_it_to
2765 stopped at the last line of window, which happens to be scanned
2766 backwards by the bidi iteration. (Bug#11464)
ac268e67 2767
e18afed7 27682012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2769
2770 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2771 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2772 are on a TTY, and thus unable to display on the fringes.
2773 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2774 so we need to signal to the caller that this is a "replacing"
2775 display spec. This fixes display when the spec is invalid or we
2776 are on a TTY.
2777
e18afed7 27782012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2779
2780 * unexaix.c (make_hdr): Fix typo in prototype.
2781 This bug broke the build on AIX. Problem reported by Gilles Pion.
2782
9d0a235a
MA
27832012-05-14 Michael Albinus <michael.albinus@gmx.de>
2784
2785 * keyboard.c (kbd_buffer_get_event): Read special events also in
2786 batch mode. (Bug#11415)
2787
9e6b06ed
GM
27882012-05-12 Glenn Morris <rgm@gnu.org>
2789
2790 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2791
c1a1d7a3
EZ
27922012-05-12 Eli Zaretskii <eliz@gnu.org>
2793
2794 * lisp.mk (lisp): Add newcomment.elc.
2795
3fe7cdc8
GM
27962012-05-12 Glenn Morris <rgm@gnu.org>
2797
2798 * Makefile.in (MKDIR_P): New, set by configure.
2799 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2800
53f7d2c0
PE
28012012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 Remove unused function hourglass_started.
2804 * dispextern.h (hourglass_started):
2805 * w32fns.c (hourglass_started):
2806 * xdisp.c (hourglass_started): Remove.
2807
75aafb17
JB
28082012-05-10 Juanma Barranquero <lekktu@gmail.com>
2809
2810 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2811 Update dependencies.
2812
12959e8e
PE
28132012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2814
97107e2e
PE
2815 * xgselect.c (xg_select): Put maxfds+1 into a var.
2816 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2817
12959e8e
PE
2818 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2819
836d29b3
DA
28202012-05-10 Dave Abrahams <dave@boostpro.com>
2821
2822 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2823 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2824
5cb67954
MA
28252012-05-09 Michael Albinus <michael.albinus@gmx.de>
2826
2827 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2828 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2829 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2830 Initialize xd_registered_buses.
2831
3478ec45
PE
28322012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2833
b263a6b0
PE
2834 Untag more efficiently if USE_LSB_TAG.
2835 This is based on a proposal by YAMAMOTO Mitsuharu in
2836 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2837 For an admittedly artificial (nth 8000 longlist) benchmark on
2838 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2839 Emacs's overall text size by 1%.
2840 * lisp.h (XUNTAG): New macro.
2841 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2842 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2843 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2844 * eval.c (Fautoload):
2845 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2846 * frame.h (XFRAME): Use XUNTAG.
2847
3478ec45
PE
2848 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2849 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2850 Remove unportable assumptions about print widths of types like
2851 dbus_uint32_t.
2852 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2853 intptr_t when converting between pointer and integer, to avoid GCC
2854 warnings about wrong width.
2855
666b903b 28562012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2857
2858 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2859 stack for each reader_thread, instead of defaulting to 8MB
2860 determined by the linker. This avoids failures in creating
2861 subprocesses on Windows 7, see the discussion in this thread:
2862 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2863
b120cc17
JC
28642012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2865
2866 Fix up display of the *Minibuf-0* buffer in the mini window.
2867 * keyboard.c (read_char): Don't clear the echo area if there's no
2868 message to clear.
2869 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2870 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2871
9a4b36f8
MA
28722012-05-07 Michael Albinus <michael.albinus@gmx.de>
2873
2874 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2875 batch mode.
2876
e5f9458f
CY
28772012-05-06 Chong Yidong <cyd@gnu.org>
2878
2879 * lisp.mk (lisp): Update.
2880
eceeb5fc 28812012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2882
2883 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2884
71873e2b
SM
28852012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * data.c (PUT_ERROR): New macro.
2888 (syms_of_data): Use it. Add new error type `user-error'.
2889 * undo.c (user_error): New function.
2890 (Fprimitive_undo): Use it.
2891 * print.c (print_error_message): Adjust print style for `user-error'.
2892 * keyboard.c (user_error): New function.
2893 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2894
ab0fa4e4
PE
28952012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 Do not limit current-time-string to years 1000..9999.
2898 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2899 (Fcurrent_time_string): Support any year that is supported by the
2900 underlying localtime representation. Don't use asctime, as it
2901 has undefined behavior for years outside the range -999..9999.
2902
7ed806a7
PE
29032012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2904
2905 Fix race conditions involving setenv, gmtime, localtime, asctime.
2906 Without this fix, interrupts could mess up code that uses these
2907 nonreentrant functions, since setting TZ invalidates existing
2908 tm_zone or tzname values, and since most of these functions return
2909 pointers to static storage.
2910 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2911 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2912 Grow the critical sections to include not just invoking
2913 localtime/gmtime, but also accessing these functions' results
2914 including their tm_zone values if any, and any related TZ setting.
2915 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2916 so that the struct tm is saved in the critical section.
2917 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2918 motivated by the fact that memory allocation needs to be outside
2919 the critical section.
2920
0c16dfed
DA
29212012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2922
2923 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2924 with RESET_INTERVAL.
2925
2926 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2927 Remove duplicated buffer name initialization.
2928
3f83ace8
JM
29292012-05-02 Jim Meyering <jim@meyering.net>
2930
2931 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2932
c7b8541e
JM
2933 * xfns.c (x_window): Use xstrdup (Bug#11375).
2934
90207a15 29352012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2936
2937 * xdisp.c (pos_visible_p): If already at a newline from the
2938 display string before the 'while' loop, don't walk back the glyphs
2939 from it3.glyph_row. Solves assertion violation when the display
2940 string begins with a newline (egg.el). (Bug#11367)
2941
b593d6a9
AH
29422012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2943
2944 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2945 Move to simple.el.
2946
4737362e
GM
29472012-05-01 Glenn Morris <rgm@gnu.org>
2948
99cf43f9
GM
2949 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2950 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2951 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2952 All were removed before 23.1.
2953
9311dcff
GM
2954 * dispnew.c: Remove HAVE_LIBNCURSES test;
2955 it is always true on relevant platforms.
2956
4d5c6349
GM
2957 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2958 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2959
4737362e
GM
2960 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2961
74dd3a6b
AS
29622012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2963
2964 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2965 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2966 Remove.
2967
13c379ee
PE
29682012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 Do not avoid creating empty evaporating overlays (Bug#9642).
2971 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2972 That is, do not delete an evaporating overlay if it becomes
2973 empty after its bounds are adjusted to fit within its buffer.
2974 This fix caused other problems, and I'm reverting it until we get
2975 to the bottom of them.
2976
a8e7d6d7 29772012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2978
2979 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2980
a8e7d6d7 29812012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2982
2983 * xdisp.c (pos_visible_p): If the window start position is beyond
2984 ZV, start the display from buffer beginning. Prevents assertion
2985 violation in init_iterator when the minibuffer window is scrolled
2986 via the scroll bar.
2987
2988 * window.c (window_scroll_pixel_based): Likewise.
2989
a8e7d6d7 29902012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2991
2992 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2993
a8e7d6d7 29942012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2995
2996 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2997 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2998
a8e7d6d7 29992012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3000
b593d6a9
AH
3001 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3002 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3003
1c6900d9
EZ
30042012-04-26 Eli Zaretskii <eliz@gnu.org>
3005
4c3fa1d9
EZ
3006 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3007 display element, check also the underlying string or buffer
3008 character. (Bug#11341)
3009
1c6900d9
EZ
3010 * w32menu.c: Include w32heap.h.
3011 (add_menu_item): If the call to AppendMenuW (via
3012 unicode_append_menu) fails, disable Unicode menus only if we are
3013 running on Windows 9X/Me.
3014
42bf8205
AS
30152012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3016
3017 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3018 (xgetint): Add missing shift for LSB tags.
3019
b1bac16e
MR
30202012-04-24 Martin Rudalics <rudalics@gmx.at>
3021
3022 * keyboard.c (read_char): Don't wipe echo area for select window
3023 events: These might get delayed via `mouse-autoselect-window'
3024 (Bug#11304).
3025
d69621cc
JB
30262012-04-24 Juanma Barranquero <lekktu@gmail.com>
3027
3028 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3029 manipulation of :loaded-from data.
3030
02fd101b
JB
30312012-04-23 Juanma Barranquero <lekktu@gmail.com>
3032
3033 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3034 now a cons (bug#11311).
3035
888bec30
PE
30362012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3037
89a438bd
PE
3038 Do not create empty overlays with the evaporate property (Bug#9642).
3039 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3040 if it becomes empty after its bounds are adjusted to fit within
3041 its buffer. Without this fix, in a nonempty buffer (let ((o
3042 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3043 yields an empty overlay that has the evaporate property, which is
3044 not supposed to happen.
3045
1068fe4d
PE
3046 Fix minor GTK3 problems found by static checking.
3047 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3048 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3049 (struct _EmacsFixedClass, emacs_fixed_get_type):
3050 Move decls here from emacsgtkfixed.h, since they needn't be public.
3051 (emacs_fixed_get_type): Now static.
3052 (emacs_fixed_class_init): Omit unused local.
3053 (emacs_fixed_child_type): Remove; unused.
3054 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3055 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3056 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3057 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3058 (EMACS_FIXED_GET_CLASS): Remove; unused.
3059 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3060
888bec30
PE
3061 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3062 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3063
de85e130
PE
30642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3065
d0baac98 3066 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3067 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3068 (__malloc_size_t, __malloc_ptrdiff_t):
3069 Remove. All uses removed, replaced by the definiens if needed,
3070 since we can assume C89 or better now.
3071 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3072 (protect_malloc_state, align, get_contiguous_space)
3073 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3074 (malloc_atfork_handler_child, malloc_enable_thread)
3075 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3076 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3077 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3078 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3079 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3080 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3081 Define using prototypes, not old style.
3082 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3083 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3084 (align): Don't assume that signed integer overflow wraps around.
3085 Omit unused local var.
3086 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3087 (_free_internal_nolock, memalign, mallochook, reallochook):
3088 Omit no-longer-needed casts.
3089 (valloc): Use getpagesize, not __getpagesize.
3090 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3091 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3092
de85e130
PE
3093 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3094
dcbf5805
MA
30952012-04-22 Michael Albinus <michael.albinus@gmx.de>
3096
3097 Move functions from C to Lisp. Make non-blocking method calls
3098 the default. Implement further D-Bus standard interfaces.
3099
3100 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3101 (QCdbus_request_name_allow_replacement)
3102 (QCdbus_request_name_replace_existing)
3103 (QCdbus_request_name_do_not_queue)
3104 (QCdbus_request_name_reply_primary_owner)
3105 (QCdbus_request_name_reply_in_queue)
3106 (QCdbus_request_name_reply_exists)
3107 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3108 (QCdbus_registered_serial, QCdbus_registered_method)
3109 (QCdbus_registered_signal): New Lisp objects.
3110 (XD_DEBUG_MESSAGE): Use sizeof.
3111 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3112 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3113 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3114 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3115 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3116 (xd_signature, xd_append_arg): Allow float for integer types.
3117 (xd_get_connection_references): New function.
b593d6a9
AH
3118 (xd_get_connection_address): Rename from xd_initialize.
3119 Return cached address.
dcbf5805
MA
3120 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3121 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3122 level.
3123 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3124 Return number of refcounts.
dcbf5805
MA
3125 (Fdbus_get_unique_name): Make stronger parameter check.
3126 (Fdbus_message_internal): New defun.
3127 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3128 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3129 (Fdbus_send_signal, Fdbus_register_service)
3130 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3131 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3132 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3133 (Vdbus_compiled_version, Vdbus_runtime_version)
3134 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3135 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3136 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3137 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3138 Adapt docstring.
dcbf5805 3139
52828e02
PE
31402012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3141
da05bc4c
PE
3142 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3143 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3144 Do not assume ptrdiff_t is the same width as 'int'.
3145
52828e02
PE
3146 * alloc.c: Handle unusual debugging option combinations.
3147 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3148 since the two debugging options are incompatible.
3149 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3150 is defined.
3151 (mem_init, mem_insert, mem_insert_fixup):
3152 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3153 (NEED_MEM_INSERT): Remove; no longer needed.
3154
f01769f9
LL
31552012-04-22 Leo Liu <sdl.web@gmail.com>
3156
3157 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3158
5790543d
PE
31592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 * sysdep.c [__FreeBSD__]: Minor cleanups.
3162 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3163 Use Emacs indenting style more consistently. Avoid some casts.
3164 Use 'double' consistently rather than mixing 'float' and 'double'.
3165
b91b7e4d
EW
31662012-04-21 Eduard Wiebe <usenet@pusto.de>
3167
b593d6a9
AH
3168 * sysdep.c (list_system_processes, system_process_attributes):
3169 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3170
6114eb15
AS
31712012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3172
3173 * lisp.mk (lisp): Update.
3174
2f38dff7
PE
31752012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3178 It is never used otherwise.
3179
4ae29f89
SM
31802012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3181
3182 * print.c (print_preprocess): Only check print_depth if print-circle
3183 is nil.
3184 (print_object): Check for cycles even when print-circle is nil and
3185 print-gensym is t, but only check print_depth if print-circle is nil.
3186
f30d612a
CY
31872012-04-20 Chong Yidong <cyd@gnu.org>
3188
3189 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3190 set the status to "failed" and ensure that sentinel is run.
3191
c07a4c0b 31922012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3193
3194 * process.c (Fset_process_inherit_coding_system_flag)
3195 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3196 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3197
c07a4c0b 31982012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3199
3200 * xdisp.c (string_buffer_position_lim): Limit starting position to
3201 BEGV.
3202 (set_cursor_from_row): If called for a mode-line or header-line
3203 row, return zero immediately.
3204 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3205 farther than the first row after the header line, if any.
3206 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3207 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3208
c07a4c0b 32092012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3210
4ae29f89
SM
3211 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3212 (bug#11238).
ad3a2b41 3213
c07a4c0b 32142012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 32152012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3216
3217 configure: new option --enable-gcc-warnings (Bug#11207)
3218 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3219 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3220 (ALL_CFLAGS): Use new macros rather than old.
3221 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3222 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3223 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3224 -Wunused-result, -Wunused-variable. This should go away once
3225 the Emacs and Gnulib regex code is merged.
3226 (xmalloc, xrealloc): Now static.
3227
aba027e8
PE
32282012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3229
3230 * dired.c (Fsystem_groups): Remove unused local.
3231
e5a36063
GM
32322012-04-17 Glenn Morris <rgm@gnu.org>
3233
3234 * dired.c (Fsystem_users): Doc fix.
3235
316411f0
DA
32362012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3237
3238 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3239 (syms_of_dired): Add them.
3240
9426aba4
PE
32412012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3242
b62a57be
PE
3243 Fix minor alloc.c problems found by static checking.
3244 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3245 New extern decls, to avoid calling undeclared functions.
3246 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3247 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3248 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3249 (NEED_MEM_INSERT): New macro.
3250 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3251 Remove one incorrect comment and fix another.
b62a57be 3252
3539f31f
PE
3253 Fix minor ralloc.c problems found by static checking.
3254 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3255 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3256 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3257 (r_alloc_sbrk): Now static.
3258
a041960a
PE
3259 Improve ralloc.c interface checking.
3260 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3261 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3262 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3263 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3264 [REL_ALLOC]: ... to here, to check interface.
3265 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3266 Remove decls. This fixes an "It stinks!".
3267
9426aba4
PE
3268 * alloc.c (which_symbols): Fix alignment issue / type clash.
3269
d55c12ed
AS
32702012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3271
3272 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3273 (struct Lisp_Misc_Any): Likewise.
3274 (struct Lisp_Free): Likewise.
3275 * alloc.c (union aligned_Lisp_Symbol): Define.
3276 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3277 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3278 (union aligned_Lisp_Misc): Define.
3279 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3280 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3281 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3282
b948ce8b
PE
32832012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3286 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3287 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3288 * s/netbsd.h, s/sol2-6.h:
3289 Remove definition of GC_MARK_STACK, since the default now works.
3290 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3291 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3292 no longer the default.
3293 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3294
35dc09a1 32952012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3296
35dc09a1
GM
3297 * lread.c (lisp_file_lexically_bound_p):
3298 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3299
35dc09a1
GM
33002012-04-14 Eli Zaretskii <eliz@gnu.org>
3301
3302 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3303 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3304
33052012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3306
3307 * nsterm.m (constrainFrameRect): Always constrain when there is only
3308 one screen (Bug#10962).
3309
bcd86815
KB
33102012-04-13 Ken Brown <kbrown@cornell.edu>
3311
3312 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3313
c25df26e
RT
33142012-04-13 Reuben Thomas <rrt@sc3d.org>
3315
3316 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3317
0fc59f1e
DC
33182012-04-11 Daniel Colascione <dancol@dancol.org>
3319
3320 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3321 against is gone. It's better to use vfork now so that when Cygwin
3322 gains a new, working vfork, we use it automatically (bug#10398).
3323
de8c03dc
SM
33242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3325
3326 * window.c (save_window_save): Obey window-point-insertion-type.
3327
2f097256
GM
33282012-04-11 Glenn Morris <rgm@gnu.org>
3329
3330 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3331
453b951e
SM
33322012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3333
3334 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3335
75f1671a 33362012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3337
3338 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3339 (force_quit_count): New var.
3340 (handle_interrupt): Use it.
3341
2a8ce227
JB
33422012-04-10 Juanma Barranquero <lekktu@gmail.com>
3343
3344 * w32.c (w32_delayed_load): Record the full path of the library
3345 being loaded (bug#10424).
3346
935396c0
GM
33472012-04-09 Glenn Morris <rgm@gnu.org>
3348
05920a43
GM
3349 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3350 not just in the obarray, before snarfing them. (Bug#11036)
3351
935396c0
GM
3352 * Makefile.in ($(leimdir)/leim-list.el):
3353 Pass EMACS rather than BUILT_EMACS.
3354
a18ecafa
TZ
33552012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3356
3357 * process.c (make_process):
3358 * process.h: Add integer `gnutls_handshakes_tried' member to
3359 process struct.
3360
6bbef4e5
JC
3361 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3362 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3363
3364 * gnutls.c (gnutls_log_function2i): Convenience log function.
3365 (emacs_gnutls_read): Use new log functions,
3366 `gnutls_handshakes_tried' process member, and
3367 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3368 attempts per process (connection).
3369
b4d3bc10
CY
33702012-04-09 Chong Yidong <cyd@gnu.org>
3371
3372 * eval.c (Fuser_variable_p, user_variable_p_eh)
3373 (lisp_indirect_variable): Functions deleted.
3374 (Fdefvar): Caller changed.
3375
3376 * callint.c (Finteractive, Fcall_interactively):
3377 * minibuf.c (Fread_variable): Callers changed.
3378
70f4d973
EZ
33792012-04-09 Eli Zaretskii <eliz@gnu.org>
3380
3381 * xdisp.c (set_cursor_from_row): If the display string appears in
3382 the buffer at position that is closer to point than the position
3383 after the display string, display the cursor on the first glyph of
3384 the display string. Fixes cursor display when a 'display' text
3385 property immediately follows invisible text. (Bug#11094)
3386
cb3c2e3e
PE
33872012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 composite.c: use 'double' consistently
3390 * composite.c (get_composition_id): Use 'double' consistently
3391 instead of converting 'float' to 'double' and vice versa; this is
3392 easier to understand and avoids a GCC warning.
3393
fd06db5d
GM
33942012-04-09 Glenn Morris <rgm@gnu.org>
3395
50fe702a
GM
3396 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3397 preparation for dumping it with emacs. (Bug#4789)
3398 (leimdir): New variable.
3399 ($(leimdir)/leim-list.el): New rule.
3400 (emacs$(EXEEXT)): Depend on leim-list.el.
3401
fd06db5d
GM
3402 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3403 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3404 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3405
55c131ee
AS
34062012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3407
3408 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3409 proper alignment.
3410
9209588f
JB
34112012-04-07 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3414 Remove unused local variable.
3415
e3fb2efb
PE
34162012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3419 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3420 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3421 objects, as mark_maybe_pointer will catch them otherwise.
3422 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3423 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3424
b5385551
PE
34252012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3426
3427 Fix typo that broke non-Windows builds.
3428 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3429
9078ead6
EZ
34302012-04-07 Eli Zaretskii <eliz@gnu.org>
3431
3432 Support building on MS-Windows with libxml2.
3433
3434 * makefile.w32-in (OBJ2): Add xml.$(O).
3435 (GLOBAL_SOURCES): Add xml.c.
3436 ($(BLD)/xml.$(O)): New dependency list.
3437
3438 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3439 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3440 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3441 [!WINDOWSNT]: New macros.
3442 (init_libxml2_functions, libxml2_loaded_p): New functions.
3443 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3444 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3445 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3446 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3447 linked in).
6bbef4e5
JC
3448 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3449 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3450 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3451
3452 * emacs.c: Don't include libxml/parser.h.
3453 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3454 xmlCleanupParser directly.
3455
3456 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3457
3811fdf3
EZ
34582012-04-07 Eli Zaretskii <eliz@gnu.org>
3459
3460 * indent.c (Fvertical_motion): If there is a display string at
3461 point, use it.vpos to compute how many lines to backtrack after
3462 move_it_to point. (Bug#11133)
3463
2f8e16b2
EZ
34642012-04-06 Eli Zaretskii <eliz@gnu.org>
3465
3466 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3467 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3468 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3469 macros related to unification of CJK characters. For the details,
3470 see the discussion following the message here:
3471 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3472
3d439cd1
CY
34732012-04-04 Chong Yidong <cyd@gnu.org>
3474
3475 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3476
8bc53d00
EZ
34772012-04-01 Eli Zaretskii <eliz@gnu.org>
3478
3479 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3480 instead of alloca. (Bug#11138)
3481
3b0512a3
AS
34822012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3483
3484 * w32menu.c (is_simple_dialog): Properly check lisp types.
3485 (Bug#11141)
3486
8427ddd2
EZ
34872012-03-31 Eli Zaretskii <eliz@gnu.org>
3488
979022ef
EZ
3489 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3490 position we get to after a call to move_it_to fails the
3491 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3492 only if we wind up in a string from display property. (Bug#11063)
3493
a6b1c7cc
EZ
3494 * window.c (Fdelete_other_windows_internal): Invalidate the row
3495 and column information about mouse highlight, so that redisplay
3496 restores it after reallocating the glyph matrices. (Bug#7464)
3497
8427ddd2
EZ
3498 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3499 string comes from a `display' text property, use the buffer
3500 position of that property as if we actually saw that position in
3501 the row's glyphs.
697ba24b
EZ
3502 (move_it_by_lines): Remove the assertion that
3503 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3504 violated when there's a before-string at the beginning of a line.
3505 (Bug#11063)
8427ddd2 3506
65a0a738
EZ
35072012-03-30 Eli Zaretskii <eliz@gnu.org>
3508
3509 * xdisp.c (append_space_for_newline): If the default face was
3510 remapped, use the remapped face for the appended newline.
3511 (extend_face_to_end_of_line): Use the remapped default face for
3512 extending the face to the end of the line.
3513 (display_line): Call extend_face_to_end_of_line when the default
3514 face was remapped. (Bug#11068)
3515
581355cc
EZ
35162012-03-29 Eli Zaretskii <eliz@gnu.org>
3517
3518 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3519
e8fc049f
SM
35202012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3523
4fb9a543
GM
35242012-03-27 Glenn Morris <rgm@gnu.org>
3525
3526 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3527 Doc fixes.
3528
679910f1
KH
35292012-03-26 Kenichi Handa <handa@m17n.org>
3530
3531 * dispextern.h (struct glyph): Fix previous change. Change the
3532 bit length of glyphless.ch to 25 (Bug#11082).
3533
90d49b7f
CY
35342012-03-26 Chong Yidong <cyd@gnu.org>
3535
3536 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3537 (command_loop_1): Use it; inhibit selection update for
3538 handle-select-window too (Bug#8996).
3539
f514f6f0
FP
35402012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3541
e8fc049f 3542 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3543
bf43fa51
KH
35442012-03-25 Kenichi Handa <handa@m17n.org>
3545
3546 * dispextern.h (struct glyph): Change the bit length of
3547 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3548
8a0c01dd
EZ
35492012-03-24 Eli Zaretskii <eliz@gnu.org>
3550
3551 * s/ms-w32.h (tzname): Include time.h before redirecting to
3552 _tzname. Fixes the MSVC build. (Bug#9960)
3553
7d1c3a76
AS
35542012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3555
8ed79523
AS
3556 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3557 characters.
3558
7d1c3a76
AS
3559 * xterm.c (XTread_socket): Only modify handling_signal if
3560 !SYNC_INPUT. (Bug#11080)
3561
e99a9b8b
EZ
35622012-03-23 Eli Zaretskii <eliz@gnu.org>
3563
3564 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3565 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3566 when fetching a multibyte character consumes more bytes than
3567 CHAR_BYTES returns, due to unification of CJK characters in
3568 string_char. (Bug#11073)
3569
5063c0e1
TN
35702012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3571
3572 * process.c (wait_reading_process_output): Handle pty disconnect
3573 by refraining from sending oneself a SIGCHLD (bug#10933).
3574
9f851fbd
CY
35752012-03-22 Chong Yidong <cyd@gnu.org>
3576
3577 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3578
5063c0e1 3579 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3580 Mark string as coming from a prefix property.
3581 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3582 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3583
fb5b8aca
CY
35842012-03-21 Chong Yidong <cyd@gnu.org>
3585
3586 * xfaces.c (Vface_remapping_alist): Doc fix.
3587
62356a1b
EZ
35882012-03-20 Eli Zaretskii <eliz@gnu.org>
3589
3590 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3591 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3592 Doc fixes.
62356a1b 3593
025de85b
CY
35942012-03-20 Chong Yidong <cyd@gnu.org>
3595
3596 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3597 to reflect default non-nil value of redisplay-dont-pause.
3598
4827f94e
KH
35992012-03-19 Kenichi Handa <handa@m17n.org>
3600
3601 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3602 it fit in a valid range (Bug#11003).
3603
e50a24a2
EZ
36042012-03-18 Eli Zaretskii <eliz@gnu.org>
3605
3606 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3607 that is not from display property, accept the row as a "cursor
3608 row" if one of the string's character has a non-nil `cursor'
3609 property. Fixes cursor positioning when there are newlines in
3610 overlay strings, e.g. in icomplete.el. (Bug#11035)
3611
9af5ed87
PE
36122012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3615
d1f55f16
CY
36162012-03-12 Chong Yidong <cyd@gnu.org>
3617
3618 * eval.c (inhibit_lisp_code): Rename from
3619 inhibit_window_configuration_change_hook; move from window.c.
3620
3621 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3622 * window.c (run_window_configuration_change_hook)
3623 (syms_of_window): Callers changed.
3624
66c5eebd
CY
36252012-03-11 Chong Yidong <cyd@gnu.org>
3626
413df973
CY
3627 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3628
66c5eebd
CY
3629 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3630
1de11f56
CY
36312012-03-10 Chong Yidong <cyd@gnu.org>
3632
3633 * frame.c (other_visible_frames): Don't assume the selected frame
3634 is visible (Bug#10955).
3635
cae07000
SM
36362012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3637
3638 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3639
89c94350
JD
36402012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3641
3642 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3643 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3644 zero (Bug#10954).
3645
999dd333
GM
36462012-03-03 Glenn Morris <rgm@gnu.org>
3647
01a6dcc8 3648 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3649
de0100f2
EZ
36502012-03-02 Eli Zaretskii <eliz@gnu.org>
3651
3652 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3653 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3654 (redisplay_window, next_element_from_string): Fix typos in
3655 comments.
3e441275
EZ
3656 (redisplay_window): Pass to move_it_vertically the margin in
3657 pixels, not in screen lines.
de0100f2 3658
96a72ee9
GM
36592012-03-02 Glenn Morris <rgm@gnu.org>
3660
3661 * buffer.c (buffer-list-update-hook): Doc fix.
3662
312508d7
EZ
36632012-02-29 Eli Zaretskii <eliz@gnu.org>
3664
3665 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3666 push_it before setting up the iterator for the first overlay
3667 string, even if we have an empty string loaded.
3668 (next_overlay_string): If there's an empty string on the iterator
3669 stack, pop the stack. (Bug#10903)
3670
27f3c637
PE
36712012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3674 Suggested by Stefan Monnier in
3675 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3676 * alloc.c (widen_to_Lisp_Object): New static function.
3677 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3678 and widening them to Lisp_Objects. This would work even if
3679 USE_LSB_TAG is defined and wide integers are used, which might
3680 happen in a future version of Emacs.
3681
3c9dfce6
CY
36822012-02-25 Chong Yidong <cyd@gnu.org>
3683
fa74b241
CY
3684 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3685 Doc fix.
3686
3c9dfce6
CY
3687 * xselect.c (Fx_selection_exists_p): Doc fix.
3688 (x_clipboard_manager_save_all): Print an informative message
3689 before saving to clipboard manager.
3690
9486df08
CY
36912012-02-24 Chong Yidong <cyd@gnu.org>
3692
3693 * keyboard.c (process_special_events): Handle all X selection
3694 requests in kbd_buffer, not just the next one (Bug#8869).
3695
f01d3321
CY
36962012-02-23 Chong Yidong <cyd@gnu.org>
3697
3698 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3699 call when setting menu-bar-lines and tool-bar-lines parameters.
3700 (unwind_create_frame_1): New helper function.
3701
3702 * window.c (inhibit_window_configuration_change_hook): New var.
3703 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3704 (syms_of_window): Initialize it.
f01d3321 3705
86b847b6
CY
37062012-02-22 Chong Yidong <cyd@gnu.org>
3707
3708 * xterm.c (x_draw_image_relief): Add missing type check for
3709 Vtool_bar_button_margin (Bug#10743).
3710
a59225b1
CY
37112012-02-21 Chong Yidong <cyd@gnu.org>
3712
3713 * fileio.c (Vfile_name_handler_alist): Doc fix.
3714
3715 * buffer.c (Fget_file_buffer): Protect against invalid file
3716 handler return value.
3717
310f5bd4
PE
37182012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3719
cb3a28cc
PE
3720 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3721 when computing $valmask.
3722
310f5bd4
PE
3723 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3724 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3725 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3726 It's useless in that case, and it can cause problems on hosts
3727 that allocate halves of EMACS_INT values separately.
3728 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3729 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3730 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3731 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3732 it avoids undefined behavior on hosts where shifting right by more
3733 than the word width has undefined behavior.
3734
2375c96a
CY
37352012-02-19 Chong Yidong <cyd@gnu.org>
3736
3737 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3738 (Funhandled_file_name_directory, Ffile_name_as_directory)
3739 (Fdirectory_file_name, Fexpand_file_name)
3740 (Fsubstitute_in_file_name): Protect against invalid file handler
3741 return values (Bug#10845).
3742
3eb49e71
EZ
37432012-02-18 Eli Zaretskii <eliz@gnu.org>
3744
3745 * .gdbinit (pitx): Fix incorrect references to fields of the
3746 iterator stack.
3747
7b926f3f
CY
37482012-02-17 Chong Yidong <cyd@gnu.org>
3749
3750 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3751
11273115
PE
37522012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3753
3754 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3755 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3756
c3a70e2b
CY
37572012-02-15 Chong Yidong <cyd@gnu.org>
3758
3759 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3760 marked as special. Also, starting docstrings with * is obsolete.
3761
0ca43699
AS
37622012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3763
3764 * gnutls.c (emacs_gnutls_write): Fix last change.
3765
2e8f3c56
LI
37662012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3767
3768 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3769 send_process.
3770
af70074f
SM
37712012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3772
3773 * keymap.c (Fsingle_key_description): Handle char ranges.
3774
95986d52
CY
37752012-02-12 Chong Yidong <cyd@gnu.org>
3776
afd83bd1
CY
3777 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3778 as that creates a dangerous corner case.
3779
95986d52
CY
3780 * window.c (Fdelete_window_internal): Invalidate the mouse
3781 highlight (Bug#9904).
3782
bd7da63e
GM
37832012-02-12 Glenn Morris <rgm@gnu.org>
3784
3785 * xselect.c (Fx_own_selection_internal)
3786 (Fx_get_selection_internal, Fx_disown_selection_internal)
3787 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3788 * nsselect.m (Fx_own_selection_internal)
3789 (Fx_disown_selection_internal, Fx_selection_exists_p)
3790 (Fx_selection_owner_p, Fx_get_selection_internal):
3791 Sync docs and argument specs with the xselect.c versions.
3792
77abcbc2
LI
37932012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3794
3795 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3796
90b671e2
EZ
37972012-02-11 Eli Zaretskii <eliz@gnu.org>
3798
1c0ca0b7
EZ
3799 * w32select.c (Fx_selection_exists_p): Sync doc string and
3800 argument list with xselect.c. (Bug#10783)
3801
3802 * w16select.c (Fx_selection_exists_p): Sync doc string and
3803 argument list with xselect.c. (Bug#10783)
90b671e2 3804
49241268
GM
38052012-02-10 Glenn Morris <rgm@gnu.org>
3806
3807 * fns.c (Fsecure_hash): Doc fix.
3808
f998bbe7 38092012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3810
3811 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3812
0992bd9c
CY
38132012-02-07 Chong Yidong <cyd@gnu.org>
3814
3815 * buffer.c (Fbuffer_local_variables)
3816 (buffer_lisp_local_variables): Handle unbound vars correctly;
3817 don't let Qunbound leak into Lisp.
3818
af008560
GM
38192012-02-07 Glenn Morris <rgm@gnu.org>
3820
dd605cc4
GM
3821 * image.c (Fimagemagick_types): Doc fix.
3822
af008560
GM
3823 * image.c (imagemagick-render-type): Change it from a lisp object
3824 to an integer. Move the doc here from the lisp manual.
3825 Treat all values not equal to 0 the same.
3826
1449fa1d
CY
38272012-02-06 Chong Yidong <cyd@gnu.org>
3828
3829 * doc.c (store_function_docstring): Avoid applying docstring of
3830 alias to base function (Bug#2603).
3831
3723ec07
AS
38322012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3833
3834 * .gdbinit (pp1, pv1): Remove redundant defines.
3835 (pr): Use pp.
3836
79c1cc1e
CY
38372012-02-04 Chong Yidong <cyd@gnu.org>
3838
3839 * nsterm.m: Declare a global (Bug#10694).
3840
d7f29f8e
EZ
38412012-02-04 Eli Zaretskii <eliz@gnu.org>
3842
cae07000
SM
3843 * w32.c (get_emacs_configuration_options):
3844 Include --enable-checking, if specified, in the return value.
d7f29f8e 3845
3b95a6f9
MR
38462012-02-04 Martin Rudalics <rudalics@gmx.at>
3847
3848 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3849 after rounding frame sizes. (Bug#9723)
3850
d6fa96a6
EZ
38512012-02-04 Eli Zaretskii <eliz@gnu.org>
3852
3853 * keyboard.c (adjust_point_for_property): Don't position point
3854 before BEGV. (Bug#10696)
3855
df0b2940
PE
38562012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 Handle overflow when computing char display width (Bug#9496).
3859 * character.c (char_width): Return EMACS_INT, not int.
3860 (char_width, c_string_width): Check for overflow when
3861 computing the width; this is possible now that individual
3862 characters can have unbounded width. Problem introduced
3863 by merge from Emacs 23 on 2012-01-19.
3864
6bee44d6
MA
38652012-02-02 Michael Albinus <michael.albinus@gmx.de>
3866
3867 * dbusbind.c (Fdbus_register_method): Mention the return value
3868 :ignore in the docstring.
3869
44f92739
GM
38702012-02-02 Glenn Morris <rgm@gnu.org>
3871
1b9f60cc
GM
3872 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3873
44f92739
GM
3874 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3875 Unconditionally set to t. (Bug#10673)
3876 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3877 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3878 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3879
c5d3843c
KH
38802012-02-02 Kenichi Handa <handa@m17n.org>
3881
3882 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3883 0, do not call append_composite_glyph.
3884
159462d4 38852012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3886
3887 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3888 NULL (Bug#6988).
3889 (x_produce_glyphs): If the component of a composition is a null
3890 string, set it->pixel_width to 1 to avoid zero-width glyph.
3891
78cef877
EZ
38922012-02-01 Eli Zaretskii <eliz@gnu.org>
3893
3894 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3895 first 2 arguments are identical. This makes inserting large
3896 output from a subprocess an order of magnitude faster on
3897 MS-Windows, where all sbrk'ed memory is always contiguous.
3898
97897668
GM
38992012-01-31 Glenn Morris <rgm@gnu.org>
3900
3901 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3902 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3903 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3904
31fd3586
GM
39052012-01-29 Glenn Morris <rgm@gnu.org>
3906
3907 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3908
0e24a8b2
CY
39092012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3910
3911 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3912
cc0adcb0
CY
39132012-01-28 Chong Yidong <cyd@gnu.org>
3914
3915 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3916
acc28cb9
CY
39172012-01-26 Chong Yidong <cyd@gnu.org>
3918
9c69cfb7
CY
3919 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3920
acc28cb9
CY
3921 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3922 repeat counts (Bug#10507).
3923
48da7392
GM
39242012-01-26 Glenn Morris <rgm@gnu.org>
3925
3926 * lread.c (syms_of_lread): Doc fix.
3927
14af5f7f
CY
39282012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3929
3930 * coding.c (encode_designation_at_bol): Change return value to
3931 EMACS_INT.
3932
0b21c100
CY
39332012-01-25 Chong Yidong <cyd@gnu.org>
3934
3935 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3936
3c2907f7
CY
39372012-01-21 Chong Yidong <cyd@gnu.org>
3938
3939 * floatfns.c (Fcopysign): Make the second argument non-optional,
3940 since nil is not allowed anyway.
3941
959ad23f
AS
39422012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3943
3944 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3945 (send_process): Likewise.
3946
34a02f46
MR
39472012-01-19 Martin Rudalics <rudalics@gmx.at>
3948
3949 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3950 (Vwindow_persistent_parameters): Do not use Qstate.
3951 Rewrite doc-strings.
34a02f46 3952
1259009a 39532012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3954
3955 * character.c (char_width): New function.
70d4fdf6
GM
3956 (Fchar_width, c_string_width, lisp_string_width):
3957 Use char_width (Bug#9496).
25ed9e61 3958
6a6ee00d
MR
39592012-01-16 Martin Rudalics <rudalics@gmx.at>
3960
3961 * window.c (Vwindow_persistent_parameters): New variable.
3962 (Fset_window_configuration, save_window_save): Handle persistent
3963 window parameters.
3964
c85efaf7
EZ
39652012-01-14 Eli Zaretskii <eliz@gnu.org>
3966
3967 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3968 thrashing the stack of the thread. (Bug#9087)
3969
5944709e
PE
39702012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3973
e71f5d99
EZ
39742012-01-11 Eli Zaretskii <eliz@gnu.org>
3975
3976 * xdisp.c (rows_from_pos_range): Handle the case where the
3977 highlight ends on a newline. (Bug#10464)
3978 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3979 he end column for display of highlight that ends on a newline
3980 before a R2L line.
3981
ce316182
GM
39822012-01-11 Glenn Morris <rgm@gnu.org>
3983
3984 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3985 from load-path also when installation-directory is nil. (Bug#10208)
3986
5b43da69
GM
39872012-01-10 Glenn Morris <rgm@gnu.org>
3988
74cc8ff9
GM
3989 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3990
7d8d6e4e
GM
3991 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3992 Update template values to be closer to their typical values these days.
5b43da69 3993
a0db8d43
EZ
39942012-01-09 Eli Zaretskii <eliz@gnu.org>
3995
3996 * xdisp.c (rows_from_pos_range): Accept additional argument
3997 DISP_STRING, and accept any glyph in a row whose object is that
3998 string as eligible for mouse highlight. Fixes mouse highlight of
3999 display strings from overlays. (Bug#10464)
4000
9a0115ab 40012012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4002
b9110d6a 4003 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4004 * fileio.c (auto_saving_dir_umask): New static var.
4005 (Fmake_directory_internal): Use it.
4006 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4007 creating the directory. The old code temporarily assigns
4008 too-generous permissions to the directory.
4009 (do_auto_save_eh): Clear it.
b9110d6a 4010 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4011 that the var is always cleared.
4012
6c1bd3f3
EZ
40132012-01-07 Eli Zaretskii <eliz@gnu.org>
4014
4015 * search.c (scan_buffer): Pass character positions to
4016 know_region_cache, not byte positions. (Bug#6540)
4017
069d2b50
L
40182012-01-07 LynX <_LynX@bk.ru> (tiny change)
4019
4020 * w32.c (sys_rename): Report EXDEV when rename of a directory
4021 fails because the target is on another logical disk. (Bug#10284)
4022
75bf0d33
DB
40232012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4024
4025 * xterm.c (x_embed_request_focus): New function.
4026
4027 * xterm.h: Add prototype.
4028
4029 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4030
1c6e5a32
GM
40312012-01-05 Glenn Morris <rgm@gnu.org>
4032
4033 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4034
651e947e
EZ
40352012-01-01 Eli Zaretskii <eliz@gnu.org>
4036
4037 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4038 Load gnutls_transport_set_lowat only if GnuTLS version is below
4039 2.11.1.
4040 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4041 GnuTLS versions below 2.11.1.
4042
3778cdd8
AL
40432011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4044
4045 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4046 to the doc string advising against its use for altering the way
4047 windows are scrolled.
4048
0e5317f7
KH
40492011-12-28 Kenichi Handa <handa@m17n.org>
4050
4051 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4052 coding-system ASCII compatible only when it does not produce BOM
4053 on encoding (Bug#10383).
4054
93d5ca1f
JD
40552011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4056
4057 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4058 can scroll.
4059 (create_and_show_popup_menu): Always use menu_position_func for
4060 Gtk3 (Bug#10361).
4061
ca22b785
AS
40622011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4063
4064 * callint.c (Fcall_interactively): Don't truncate prompt string.
4065
d048e1e6
EZ
40662011-12-23 Eli Zaretskii <eliz@gnu.org>
4067
4068 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4069 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4070 resumed from there (after widening). (Bug#10360)
d048e1e6 4071
5ccaba1f
JD
40722011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4073
4074 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4075
204ee57f
JD
40762011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4077
b81d40f0
JB
4078 * nsterm.m (x_free_frame_resources):
4079 Release f->output_data.ns->miniimage.
204ee57f
JD
4080 (ns_index_color): Fix indentation. Do not retain
4081 color_table->colors[i].
4082
4083 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4084 before returning.
4085
4086 * nsfns.m (x_set_background_color): Assign return value from
4087 ns_index_color to face-background instead of NSColor*.
4088 (ns_implicitly_set_icon_type): Fix indentation.
4089 Change assignment in for loop to comparison.
4090
4091 * emacs.c (ns_pool): New variable.
4092 (main): Assign ns_pool.
4093 (Fkill_emacs): Call ns_release_autorelease_pool.
4094
4095 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4096 autorelease fdesc, release fdAttrs and tdict.
4097 (ns_get_covering_families): Release charset.
4098 (ns_findfonts): Release NSFontDescriptor created with new.
4099 (ns_uni_to_glyphs): Fix indentation.
4100 (setString): Release attrStr before assigning new value.
4101
c803b2b7
JD
41022011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4103
678f4426
JD
4104 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4105 and NS_IMPL_COCOA.
4106 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4107 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4108
cd394be1 41092011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4110
5fecd5fc
JD
4111 * nsterm.m (ns_term_init): Subscribe for notifications
4112 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4113 to method trackingNotification in EmacsMenu.
4114
4115 * nsmenu.m (trackingMenu): New variable.
3771cb17 4116 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4117 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4118 from Aquamacs (Bug#7030).
678f4426
JD
4119
41202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4121
c803b2b7
JD
4122 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4123 (symbol_to_nsstring): Fix indentation.
4124 (ns_symbol_to_pb): New function.
cae07000
SM
4125 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4126 (Fns_rotate_cut_buffers_internal): Remove.
4127 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4128 Fns_store_cut_buffer_internal.
4129 (ns_get_foreign_selection, Fx_own_selection_internal)
4130 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4131 (Fns_get_selection_internal, Fns_store_selection_internal):
4132 Use ns_symbol_to_pb and check if return value is nil.
4133 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4134 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4135 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4136 renamed to Sns_store_selection_internal.
4137 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4138 and remove this function.
4139 (ns_handle_selection_clear): Remove, never used.
4140 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4141 here.
4142
e1b01a3a
KB
41432011-12-17 Ken Brown <kbrown@cornell.edu>
4144
4145 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4146 GID is unknown (Bug#10257).
4147
2adb6e85
PE
41482011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4151 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4152 which caused a build failure on GNU/Linux IA-64. This problem was
4153 introduced by my 2011-10-07 patch.
4154
d1d7b339
JL
41552011-12-15 Juri Linkov <juri@jurta.org>
4156
4157 * image.c (imagemagick_error): New function. (Bug#10112)
4158 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4159 Use `imagemagick_error' where ImageMagick functions return
4160 `MagickFalse'.
4161 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4162 proper order.
4163
100d5755
KH
41642011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4165
4166 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4167 fill background (Bug#8992).
4168
454592a6
MR
41692011-12-13 Martin Rudalics <rudalics@gmx.at>
4170
4171 * window.c (Vwindow_combination_resize)
4172 (Vwindow_combination_limit): Use t instead of non-nil in
4173 doc-strings.
61d4b438
MR
4174 (Vrecenter_redisplay): Add first sentence of doc-string on
4175 separate line.
53524d93 4176 (Frecenter): Fix doc-string typo.
454592a6 4177
3633e3aa
KH
41782011-12-11 Kenichi Handa <handa@m17n.org>
4179
4180 * coding.c (Funencodable_char_position): Pay attention to the
4181 buffer text relocation (Bug#9389).
4182
7b9d523a 41832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4184
7b9d523a
JD
4185 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4186 gtk_init (Bug#10100).
4187
b73189c6
EZ
41882011-12-10 Eli Zaretskii <eliz@gnu.org>
4189
4190 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4191 IT->string is nil. (Bug#10263)
4192
f7dfe5d6
JD
41932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4194
83faebb4
JD
4195 * nsterm.h (x_free_frame_resources): Declare.
4196
f7dfe5d6
JD
4197 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4198 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4199
4200 * nsterm.h (ns_get_defaults_value): Declare.
4201
4202 * nsterm.m (ns_default): Call ns_get_defaults_value.
4203
7cd4e72c
EZ
42042011-12-09 Eli Zaretskii <eliz@gnu.org>
4205
4206 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4207 (Bug#10170)
4208
b34d7317
YM
42092011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4210
4211 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4212 that where the value of an _OBJC_* symbol points to is in the .bss
4213 section (Bug#10240).
4214
76470ad1
KH
42152011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4216
4217 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4218 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4219
745fff94
KH
42202011-12-08 Kenichi Handa <handa@m17n.org>
4221
4222 * ftfont.c (get_adstyle_property): Fix previous change
4223 (Bug#10233).
4224
6e44397c
JB
42252011-12-07 Juanma Barranquero <lekktu@gmail.com>
4226
4227 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4228 dirs from the default value of EMACSLOADPATH (bug#10208).
4229
7efa6272
GM
42302011-12-07 Glenn Morris <rgm@gnu.org>
4231
4232 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4233 installation and source directories as well. (Bug#10208)
4234
f6fc4d87
CY
42352011-12-06 Chong Yidong <cyd@gnu.org>
4236
4237 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4238
2bf26180
GM
42392011-12-06 Glenn Morris <rgm@gnu.org>
4240
4241 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4242 as an error, not just -1. (Bug#10217)
4243
3a6ad4f0
CY
42442011-12-05 Chong Yidong <cyd@gnu.org>
4245
4246 * keyboard.c (process_special_events): New function.
4247 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4248
75a3b399
PE
42492011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * coding.c (encode_designation_at_bol): Don't use uninitialized
4252 local variable (Bug#9318).
4253
c3c9e25e
KH
42542011-12-05 Kenichi Handa <handa@m17n.org>
4255
4256 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4257 return Qnil (Bug#8046, Bug#10193).
4258
5eb05ea3
KH
42592011-12-05 Kenichi Handa <handa@m17n.org>
4260
4261 * coding.c (encode_designation_at_bol): New args charbuf_end and
4262 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4263 (coding_set_source): Return how many bytes coding->source was
4264 relocated.
4265 (coding_set_destination): Return how many bytes
4266 coding->destination was relocated.
4267 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4268 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4269
42702011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4271
4272 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4273 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4274 macro (Bug#9318).
4275
42762011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4277
4278 The following changes are to fix Bug#9318.
4279
a79703f5 4280 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4281 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4282 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4283 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4284
7dbda6df
JB
42852011-12-05 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * lisp.h (process_quit_flag): Fix external declaration.
4288
6d5eb5b0
SM
42892011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4290
4291 Don't macro-inline non-performance-critical code.
4292 * eval.c (process_quit_flag): New function.
4293 * lisp.h (QUIT): Use it.
4294
a0c3fad0
JD
42952011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4296
4297 * nsfns.m (get_geometry_from_preferences): New function.
4298 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4299
6c07aac2
AS
43002011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4301
4302 * emacs.c (Qkill_emacs): Define.
4303 (syms_of_emacs): Initialize it.
4304 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4305 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4306 (quit_throw_to_read_char): Add parameter `from_signal'.
4307 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4308 * lisp.h (QUIT): Call Fkill_emacs if requested.
4309
c052ead4
JD
43102011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4311
4312 * widget.c (update_wm_hints): Return if wmshell is null.
4313 (widget_update_wm_size_hints): New function.
4314
4315 * widget.h (widget_update_wm_size_hints): Declare.
4316
4317 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4318 widget_update_wm_size_hints (Bug#10104).
4319
9e49252b
EZ
43202011-12-03 Eli Zaretskii <eliz@gnu.org>
4321
4322 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4323 before a newline, prepare the bidi iterator for consuming the
4324 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4325 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4326
02b16839
JL
43272011-12-02 Juri Linkov <juri@jurta.org>
4328
4329 * search.c (Fword_search_regexp): New Lisp function created from
4330 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4331 (Fword_search_backward, Fword_search_forward)
4332 (Fword_search_backward_lax, Fword_search_forward_lax):
4333 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4334 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4335
0068070e
SM
43362011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4337
4338 * fileio.c (Finsert_file_contents): Move after-change-function call
4339 to before the "handled:" label, since all "goto handled" appear in
4340 cases where the *-change-functions have already been properly called
4341 (bug#10117).
4342
3360a3fc
AS
43432011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4344
4345 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4346 waiting for input. (Bug#10169)
4347
73d6c093
EZ
43482011-11-30 Eli Zaretskii <eliz@gnu.org>
4349
4350 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4351 verifies glyph row's hash code--we have just reallocated the
4352 glyphs, so their contents can be complete garbage. (Bug#10164)
4353
febe6bea
JB
43542011-11-30 Juanma Barranquero <lekktu@gmail.com>
4355
4356 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4357
801a4313
EZ
43582011-11-30 Eli Zaretskii <eliz@gnu.org>
4359
4360 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4361 attributes are tested _before_ calling verify_row_hash, to protect
4362 against GCC re-ordering of the tests. (Bug#10164)
4363
2b56b87e
JD
43642011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4365
4366 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4367
4368 * xterm.c (handle_one_xevent): Only set async_visible and friends
4369 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4370 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4371 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4372
dbf31225
PE
43732011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4374
4375 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4376 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4377 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4378 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4379 All uses changed to use GCPRO1 etc.
4380 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4381 Revert to old implementation (i.e., before 2011-03-11).
4382
1305621b
YM
43832011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4384
4385 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4386 of scroll runs so as to avoid assigning disabled bogus rows and
4387 unnecessary graphics copy operations.
4388
8c9afb46
EZ
43892011-11-27 Eli Zaretskii <eliz@gnu.org>
4390
4391 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4392 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4393 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4394 (malloc, free, realloc, calloc): Redirect to e_* only when
4395 compiling Emacs.
4396
4397 * lisp.h (GCTYPEBITS): Move before first use.
4398 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4399 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4400 this macro definition.
4401
4402 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4403 _MSC_VER.
4404
54e9e3bf
JD
44052011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4406
6d5eb5b0
SM
4407 * gtkutil.c (xg_create_frame_widgets):
4408 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4409 present with Gtk+ 2.0.
4410
83aca1cb
PE
44112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 * fileio.c (Finsert_file_contents): Undo previous change; see
4414 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4415
5b76caa4
PE
44162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4417
4418 Rename locals to avoid shadowing.
4419 * fileio.c (Finsert_file_contents):
4420 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4421 * process.c (wait_reading_process_output):
4422 Rename inner 'proc' to 'p' to avoid shadowing.
4423 Indent for consistency with usual Emacs style.
4424
8c535114
EZ
44252011-11-25 Eli Zaretskii <eliz@gnu.org>
4426
4427 * xdisp.c (redisplay_window): If cursor row is not fully visible
4428 after recentering, and scroll-conservatively is set to a large
4429 number, scroll window by a few more lines to make the cursor fully
4430 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4431 (start_display): Don't move to the next line if the display should
4432 start at a newline that is part of a display vector or an overlay
4433 string. (Bug#10119)
8c535114 4434
fa4fdb5c
JL
44352011-11-24 Juri Linkov <juri@jurta.org>
4436
4437 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4438 after the `MagickPingImage' call. (Bug#10112)
4439
90ec88df
CY
44402011-11-23 Chong Yidong <cyd@gnu.org>
4441
4442 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4443
56e2e794
MR
44442011-11-23 Martin Rudalics <rudalics@gmx.at>
4445
4446 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4447 making another buffer current. (Bug#10114)
4448
b6e64c41
GM
44492011-11-23 Glenn Morris <rgm@gnu.org>
4450
4451 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4452
6b21de18
CY
44532011-11-23 Chong Yidong <cyd@gnu.org>
4454
4455 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4456 using it (Bug#5984).
4457
b12cd789
EZ
44582011-11-22 Eli Zaretskii <eliz@gnu.org>
4459
4460 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4461 and header-lines, as they don't have one computed for them.
4462 (Bug#10098)
4463
4464 * .gdbinit (prow): Make displayed values more self-explaining.
4465 Add row's hash code.
4466
261b6fd4
LMI
44672011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4468
4469 * process.c (wait_reading_process_output): Fix asynchrounous
4470 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4471 (wait_reading_process_output): Add comment and URL.
261b6fd4 4472
e7cfd277
JD
44732011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4474
4475 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4476
a9b9b7f5
CY
44772011-11-21 Chong Yidong <cyd@gnu.org>
4478
4479 * window.c (Fnext_window, Fprevious_window): Doc fix.
4480
b0d15b4f
SM
44812011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4482
4483 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4484
fe7a3057
JB
44852011-11-20 Juanma Barranquero <lekktu@gmail.com>
4486
4487 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4488
d2999b1a
MR
44892011-11-20 Martin Rudalics <rudalics@gmx.at>
4490
4491 * window.c (Fset_window_combination_limit): Rename argument
4492 STATUS to LIMIT.
4493 (Vwindow_combination_limit): Remove "status" from doc-string.
4494
d5ff9cd0
AS
44952011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4496
4497 * m/ibms390.h: Remove.
4498 * m/ibms390x.h: Don't include "ibms390.h".
4499
a5bb9bd3
SM
45002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4501
4502 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4503 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4504
cd1181db
JB
45052011-11-20 Juanma Barranquero <lekktu@gmail.com>
4506
4507 * casetab.c (Fset_case_table):
4508 * charset.c (Fcharset_after): Fix typos.
4509
615a3b8d 45102011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4511
17e845af
PE
4512 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4513 Otherwise, valgrind does not work on some platforms.
4514 Problem reported by Andreas Schwab in
6a0bf43d
PE
4515 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4516 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4517 is set, removing the need for VIRT_ADDRESS_VARIES.
4518 (PURE_P): Use a more-efficient implementation that needs just one
4519 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4520 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4521 to 4 (xorl, subq, cmpq, setbe).
4522 * alloc.c (pure): Always extern now, since that's the
4523 VIRT_ADDR_VARIES behavior.
4524 (PURE_POINTER_P): Use a single comparison, not two, for
4525 consistency with the new puresize.h.
4526 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4527 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4528 Remove VIRT_ADDR_VARIES no longer needed.
4529
f8fe6f96
EZ
45302011-11-19 Eli Zaretskii <eliz@gnu.org>
4531
4532 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4533 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4534 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4535 behave as if the cursor position were at the window margin.
4536
4537 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4538 and the cursor position is out of bounds, behave as if the cursor
4539 position were at the window margin. (Bug#10075)
4540
df05a53c
CY
45412011-11-18 Chong Yidong <cyd@gnu.org>
4542
4543 * window.c (Fwindow_combination_limit): Make first argument
4544 non-optional, since it is meaningless for live windows like the
4545 selected window.
61ccba97 4546
2071918e
DA
45472011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4548
4549 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4550
b50a28de
SM
45512011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4552
4553 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4554 (graft_intervals_into_buffer): Simplify.
4555
015137db
EZ
45562011-11-18 Eli Zaretskii <eliz@gnu.org>
4557
4558 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4559 hash values of the two rows.
4560 (copy_row_except_pointers): Preserve the used[] arrays and the
4561 hash values of the two rows. (Bug#10035)
68c95424 4562 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4563
4564 * xdisp.c (row_hash): New function, body extracted from
4565 compute_line_metrics.
4566 (compute_line_metrics): Call row_hash, instead of computing the
4567 hash code inline.
4568
4569 * dispnew.c (verify_row_hash): Call row_hash for computing the
4570 hash code of a row, instead of duplicating code from xdisp.c.
4571
4572 * dispextern.h (row_hash): Add prototype.
4573
a2addb04
TH
45742011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4575
4576 * frame.c (delete_frame): Don't delete the terminal when the last
4577 X frame is closed if emacs is built with GTK toolkit.
4578
df85d315
JB
45792011-11-17 Juanma Barranquero <lekktu@gmail.com>
4580
4581 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4582
a0c2d0ae
MR
45832011-11-17 Martin Rudalics <rudalics@gmx.at>
4584
4585 * window.c (Vwindow_splits): Rename to
4586 Vwindow_combination_resize. Suggested by Juri Linkov.
4587 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4588 of Vwindow_splits.
4589
58179cce
JB
45902011-11-16 Juanma Barranquero <lekktu@gmail.com>
4591
7877f373
JB
4592 * nsfns.m (Fns_font_name):
4593 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4594
b6f67890
MR
45952011-11-16 Martin Rudalics <rudalics@gmx.at>
4596
4597 * window.h (window): Rename slot "nest" to "combination_limit".
4598 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4599 (Fset_window_nest): Rename to Fset_window_combination_limit.
4600 (Vwindow_nest): Rename to Vwindow_combination_limit.
4601 (recombine_windows, make_parent_window, make_window)
4602 (Fsplit_window_internal, saved_window)
4603 (Fset_window_configuration, save_window_save): Rename all
4604 occurrences of window_nest to window_combination_limit.
4605
c7015153
JB
46062011-11-15 Juanma Barranquero <lekktu@gmail.com>
4607
4608 * image.c (imagemagick_load_image): Fix typo.
4609
322ad6ec
EZ
46102011-11-14 Eli Zaretskii <eliz@gnu.org>
4611
4612 * xdisp.c (display_line): Move the call to
4613 highlight_trailing_whitespace before the call to
4614 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4615 faces of all the glyphs to compute ROW's hash value.
4616 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4617
f067b8ec
JB
46182011-11-14 Juanma Barranquero <lekktu@gmail.com>
4619
4620 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4621 just return (bug#10044).
4622
1e5b2111
EZ
46232011-11-12 Eli Zaretskii <eliz@gnu.org>
4624
7ef3cbd5
EZ
4625 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4626 with user-defined heap size. Bump the default size of the temacs
4627 heap to 27MB, to avoid memory warning when running temacs.
4628 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4629
1e5b2111
EZ
4630 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4631 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4632 (verify_row_hash) [XASSERTS]: New function.
4633 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4634 that the hash value of glyph rows is correct.
1e5b2111 4635
89d61221
MR
46362011-11-12 Martin Rudalics <rudalics@gmx.at>
4637
4638 * window.h (window): Remove splits slot.
4639 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4640 (Fdelete_other_windows_internal, make_parent_window)
4641 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4642 (Fset_window_configuration, save_window_save): Don't deal with
4643 split status of windows.
4644 (saved_window): Remove splits slot.
4645 (Vwindow_splits): Rewrite doc-string.
4646
97f18cc8
JD
46472011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4648
4649 * xfns.c (unwind_create_frame):
4650 * nsfns.m (unwind_create_frame):
4651 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4652 Vframe_list (Bug#9999).
4653
22a648b4
DA
46542011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4655
0b381c7e 4656 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4657
659afede
KH
46582011-11-11 Kenichi Handa <handa@m17n.org>
4659
4660 * callproc.c (Fcall_process): Set the member dst_multibyte of
4661 process_coding.
4662
9ac0394b
KH
46632011-11-11 Johan Bockgård <bojohan@gnu.org>
4664
4665 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4666 avoid a crash (bug#9496).
4667
2fbdc249
CY
46682011-11-09 Chong Yidong <cyd@gnu.org>
4669
4670 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4671 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4672
ac6b1f81
PE
46732011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4674
4675 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4676
09db192c
PE
46772011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4678
4679 Avoid some portability problems by eschewing 'extern inline' functions.
4680 The trivial performance wins aren't worth the portability hassles; see
4681 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4682 et seq.
4683 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4684 (window_box_width, window_box_left, window_box_left_offset)
4685 (window_box_right, window_box_right_offset): Undo previous change,
4686 by removing the "extern"s.
4687 * intervals.c (adjust_intervals_for_insertion)
4688 (adjust_intervals_for_deletion): Undo previous change,
4689 making these static again.
4690 (offset_intervals, temp_set_point_both, temp_set_point)
4691 (copy_intervals_to_string): No longer inline.
4692 * xdisp.c (window_text_bottom_y, window_box_width)
4693 (window_box_height, window_box_left_offset)
4694 (window_box_right_offset, window_box_left, window_box_right)
4695 (window_box): No longer inline.
4696
105216ed
CY
46972011-11-08 Chong Yidong <cyd@gnu.org>
4698
4699 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4700 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4701 Signal an error if not a live window.
105216ed
CY
4702 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4703 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4704
ae9e237f
JB
47052011-11-07 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * lisp.h (syms_of_abbrev): Remove declaration.
4708 Reported by CHENG Gao <chenggao@royau.me>.
4709
c7aa8333
EZ
47102011-11-07 Eli Zaretskii <eliz@gnu.org>
4711
4712 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4713 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4714 of temacs in GUI mode.
4715
be7f5545
MR
47162011-11-07 Martin Rudalics <rudalics@gmx.at>
4717
4718 * window.h: Declare delete_all_child_windows instead of
4719 delete_all_subwindows.
4720 * window.c (Fwindow_nest, Fset_window_nest)
4721 (Fset_window_new_total, Fset_window_new_normal)
4722 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4723 (delete_all_subwindows): Rename to delete_all_child_windows.
4724 (Fdelete_other_windows_internal, Fset_window_configuration):
4725 Call delete_all_child_windows instead of delete_all_subwindows.
4726 * frame.c (delete_frame): Call delete_all_child_windows instead
4727 of delete_all_subwindows.
4728
ca78dc43
PE
47292011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4730
4731 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4732 This is also needed for porting to any host where GC_MARK_STACK is
4733 not GC_MAKE_GCPROS_NOOPS.
4734 (which_symbols): Use it.
4735
a0241d01
KH
47362011-11-07 Kenichi Handa <handa@m17n.org>
4737
4738 * coding.c (coding_set_destination): Check coding->src_pos only
4739 when coding->src_object is a buffer (bug#9910).
4740
4741 * process.c (send_process): Set the member src_multibyte of coding
4742 to 0 (bug#9911) when sending a unibyte text.
4743
4744 * callproc.c (Fcall_process): Set the member src_multibyte of
4745 process_coding to 0 (bug#9912).
4746
a64bfdfa 47472011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4748
4749 * xmenu.c (cleanup_widget_value_tree): New function.
4750 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4751 calling free_menubar_widget_value_tree directly (Bug#9830).
4752
cb41b32a
PE
47532011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4754
4755 Fix some portability problems with 'inline'.
4756 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4757 (window_box_width, window_box_left, window_box_left_offset)
4758 (window_box_right, window_box_right_offset): Declare extern.
4759 Otherwise, these inline functions do not conform to C99 and
4760 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4761 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4762 * intervals.c (adjust_intervals_for_insertion)
4763 (adjust_intervals_for_deletion): Now extern, because otherwise the
4764 extern inline functions 'offset_intervals' couldn't refer to it.
4765 (static_offset_intervals): Remove.
4766 (offset_intervals): Rewrite using the old contents of
4767 static_offset_intervals. The old version didn't conform to C99
4768 because an extern inline function contained a reference to an
4769 identifier with static linkage.
4770
b7041366
AS
47712011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4772
4773 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4774 GC.
4775
88a37c4d
EZ
47762011-11-06 Eli Zaretskii <eliz@gnu.org>
4777
4778 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4779 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4780 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4781 return Qleft_to_right.
4782
49745b39
CY
47832011-11-06 Chong Yidong <cyd@gnu.org>
4784
4785 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4786 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4787 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4788 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4789 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4790 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4791 (Fwindow_vscroll): Doc fix.
4792 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4793 argument, since it makes no sense to pass a live window and for
4794 consistency with window-child.
4795
1f05cd82
CS
47962011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4797
4798 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4799 support MSVC.
4800
22610910
JR
48012011-11-05 Jason Rumney <jasonr@gnu.org>
4802
4803 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4804 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4805 fonts (Bug#6029).
4806 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4807 bitwise arithmetic preventing use of unicode-sip and non-truetype
4808 opentype fonts.
4809
a06776b2
EZ
48102011-11-05 Eli Zaretskii <eliz@gnu.org>
4811
3ad924ba
EZ
4812 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4813 "emacs"-only part.
4814
a06776b2
EZ
4815 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4816 initialization code to keep similarity to xfns.c after changes
4817 from 2011-11-05.
4818
c9e7db78
JD
48192011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4820
a97f8f3f
JD
4821 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4822 (unwind_create_frame): New function (Bug#9943).
4823 (Fx_create_frame): Restructure code to be more similar to the one in
4824 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4825 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4826 Move terminal->reference_count++ just before making the frame official
4827 (Bug#9943).
4828
4829 * nsterm.m (x_free_frame_resources): New function.
4830 (x_destroy_window): Move code to x_free_frame_resources.
4831
c9e7db78 4832 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4833 (Fx_create_frame, x_create_tip_frame):
4834 Move terminal->reference_count++ just before making the frame
75f1671a 4835 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4836 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4837
a6fc3b5c
EZ
48382011-11-05 Eli Zaretskii <eliz@gnu.org>
4839
4840 Support MSVC build with newer versions of Visual Studio.
4841 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4842 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4843 nt/gmake.defs.
4844
4845 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4846 which are not supported by MSVC.
4847 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4848 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4849 bitfields.
4850 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4851 types in bitfields.
4852 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4853
4854 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4855
58179cce 48562011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4857
4858 Support MSVC build with newer versions of Visual Studio.
4859 * w32.c: Don't include w32api.h for MSVC.
4860 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4861
4862 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4863 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4864 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4865 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4866 e_* cousins.
4867 (alloca) [_MSC_VER]: Define to _alloca.
4868
4869 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4870
4871 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4872
a58c13ed
EZ
48732011-11-04 Eli Zaretskii <eliz@gnu.org>
4874
4875 * xdisp.c (note_mouse_highlight): If either of
4876 previous/next-single-property-change returns nil, treat that as
4877 the beginning or the end of the buffer. (Bug#9955)
4878
fe0b6370
JD
48792011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4880
a58c13ed 4881 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4882 label is not null (Bug#9951).
4883 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4884 may be NULL.
4885
89bd5ee1
EZ
48862011-11-04 Eli Zaretskii <eliz@gnu.org>
4887
4888 * window.c (Fwindow_body_size): Mention in the doc string that the
4889 return value is in frame's canonical units. (Bug#9949)
4890
84c3edb9
EZ
48912011-11-03 Eli Zaretskii <eliz@gnu.org>
4892
4e2fb5c7
EZ
4893 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4894
84c3edb9 4895 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4896 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4897 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4898
bc17a887
EZ
48992011-11-01 Eli Zaretskii <eliz@gnu.org>
4900
4901 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4902 Don't stop backward scan on the continuation glyph, even though
4903 its CHARPOS is positive.
6d5eb5b0
SM
4904 (mouse_face_from_buffer_pos, note_mouse_highlight):
4905 Rename cover_string to disp_string.
bc17a887 4906
4ee88440
MR
49072011-11-01 Martin Rudalics <rudalics@gmx.at>
4908
4909 * window.c (temp_output_buffer_show): Don't use
4910 Vtemp_buffer_show_specifiers.
4911 (Vtemp_buffer_show_specifiers): Remove unused variable.
4912
c2ff3c02
EZ
49132011-10-30 Eli Zaretskii <eliz@gnu.org>
4914
4915 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4916 past the beginning of the current glyph matrix.
4917
58179cce 49182011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4919
4920 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4921 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4922 HAVE_GTK3 (Bug#9869).
b77a6a7f 4923
3b574623
JD
4924 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4925 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4926
b77a6a7f
JD
4927 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4928
4929 * xterm.c: Declare x_handle_net_wm_state to return int.
4930 (handle_one_xevent): Check if we are iconified but don't have
4931 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4932 (get_current_wm_state): Return non-zero if not hidden,
4933 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4934 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4935 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4936 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4937
196e41e4
PE
49382011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4939
4940 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4941 so that this new function doesn't get optimized away by a
4942 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4943
021f2e1a
AS
49442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4945
4946 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4947
8b058d44
EZ
49482011-10-29 Eli Zaretskii <eliz@gnu.org>
4949
4950 Fix the `xbytecode' command.
4951 * .gdbinit (xprintbytestr): New command.
b50a28de 4952 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4953 (xbytecode): Print the byte-code string as well.
4954
4452fb80
EZ
49552011-10-29 Kim Storm <storm@cua.dk>
4956
8b058d44
EZ
4957 * alloc.c (which_symbols): New function.
4958
21b72067
AS
49592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4960
4961 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4962 line. (Bug#9903)
4963
83ed7b5c
GM
49642011-10-29 Glenn Morris <rgm@gnu.org>
4965
4966 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4967 Not clear what it was for, and it causes various bugs. (Bug#9839)
4968
5a7a728b
EZ
49692011-10-28 Eli Zaretskii <eliz@gnu.org>
4970
4971 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4972 possible random value that matches one of those tested as
4973 condition to clear the mouse face.
4974
d3d0842f
CY
49752011-10-28 Chong Yidong <cyd@gnu.org>
4976
4977 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4978
31b39d13
DN
49792011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4980
4981 * window.c (make_window): Initialize phys_cursor_on_p.
4982
9aba6043
SM
49832011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4984
4985 * lisp.h (struct Lisp_Symbol): Update comments.
4986
c20992f4
JB
49872011-10-28 Juanma Barranquero <lekktu@gmail.com>
4988
4989 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4990
db4f02f2
EZ
49912011-10-28 Eli Zaretskii <eliz@gnu.org>
4992
4993 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4994 <oslsachem@gmail.com> for helping to debug this.
4995
4996 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4997 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4998 (g_b_init_get_glyph_outline_w): New static variables.
4999 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5000 (GetGlyphOutlineW_Proc): New typedefs.
5001 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5002 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5003 New functions.
5004 (w32font_open_internal, compute_metrics):
5005 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5006 instead of calling the "wide" APIs directly.
5007
5008 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5009
5010 * w32.h (syms_of_w32font): Add prototype.
5011
87e68db4
JB
50122011-10-27 Juanma Barranquero <lekktu@gmail.com>
5013
5014 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5015 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5016 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5017 (Fmove_to_window_line): Doc fix.
5018
435c1d67
CY
50192011-10-27 Chong Yidong <cyd@gnu.org>
5020
5021 * process.c (make_process): Set gnutls_state to NULL.
5022
5023 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5024 non-NULL, regardless of GNUTLS_INITSTAGE.
5025 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5026 an error. Set process slots as soon as we allocate them.
5027
5028 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5029
9c6c6f49
CY
50302011-10-27 Chong Yidong <cyd@gnu.org>
5031
9aba6043
SM
5032 * gnutls.c (emacs_gnutls_deinit): New function.
5033 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5034 (Fgnutls_deinit, Fgnutls_boot): Use it.
5035
5036 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5037 (deactivate_process): Call emacs_gnutls_deinit.
5038
657d08d3
JB
50392011-10-27 Juanma Barranquero <lekktu@gmail.com>
5040
5041 * image.c (x_create_x_image_and_pixmap):
5042 * w32.c (sys_rename, w32_delayed_load):
5043 * w32font.c (fill_in_logfont):
5044 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5045
5430d399
JB
50462011-10-26 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * w32fns.c (w32_default_color_map): New function,
5049 extracted from Fw32_default_color_map.
a7ef684b 5050 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5051
fe0055fa
PE
50522011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5053
5054 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5055
e6346438
SM
50562011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5057
5058 * keyboard.c (test_undefined): New function (bug#9751).
5059 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5060
e112cc37
ET
50612011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5062
5063 * sysdep.c (init_sys_modes): Fix the check for the controlling
5064 terminal (Bug#6649).
5065
7b5d6677
EZ
50662011-10-20 Eli Zaretskii <eliz@gnu.org>
5067
5068 * dispextern.h (struct bidi_it): New member next_en_type.
5069
5070 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5071 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5072 current character, check also for next_en_type being WEAK_EN.
5073 (bidi_resolve_weak): Don't enter the expensive loop if the current
5074 position is before next_en_pos. Record the bidi type of the first
5075 non-ET, non-BN character we find, in addition to its position.
5076 (bidi_level_of_next_char): Invalidate next_en_type when
5077 next_en_pos is over-stepped.
5078
7da0b018
PE
50792011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5080
5081 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5082 * editfns.c: Rewrite current-time-zone so that it invokes
5083 the equivalent of (format-time-string "%Z") to get the time zone name.
5084 This fixes a bug when the time zone name contains characters that
5085 need converting from the system time locale to Emacs internal format.
5086 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5087 that patch fixed format-time-string to do the conversion, but
5088 I forgot to fix current-time-zone.
5089 (format_time_string): New function, containing most of
5090 what Fformat_time_string used to contain.
5091 (Fformat_time_string): Rewrite in terms of format_time_string.
5092 This doesn't change this function's behavior.
5093 (current-time-zone): Rewrite to use format_time_string.
5094 This fixes the bug reported by Michael Schierl in
5095 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5096 Jason Rumney's 2007-06-07 change worked around this bug, but
5097 didn't fix it.
5098 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5099
8547b010
EZ
51002011-10-19 Eli Zaretskii <eliz@gnu.org>
5101
5102 * xdisp.c (start_display): If the character at POS is displayed
5103 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5104 (try_window_reusing_current_matrix): If a line ends in a display
5105 vector or the next line starts in a display vector, continue
5106 redrawing the window even though the character position of
5107 start_row was reached.
8547b010
EZ
5108 (Bug#9771, part 2)
5109
4e948d15
CY
51102011-10-18 Chong Yidong <cyd@gnu.org>
5111
5112 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5113 with nobreak-char-display too.
5114
4787455f
EZ
51152011-10-18 Eli Zaretskii <eliz@gnu.org>
5116
5117 Fix part 3 of bug#9771.
5118 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5119 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5120 non-neutral characters if the current character is a paragraph
5121 separator (a.k.a. Newline). This avoids running the same
5122 expensive loop twice, once when we consume the preceding newline
5123 and the other time when the line actually needs to be displayed.
5124 Avoid the loop when we see neutrals on the base embedding level
5125 following a character whose directionality is the same as the
5126 paragraph's. This avoids running the expensive loop when a line
5127 ends in a long sequence of neutrals, like control characters.
5128 Add assertion against STRONG_AL type. Slightly rearrange code
5129 that determines the type of a neutral given the first non-neutral
5130 that follows it.
5131 (bidi_level_of_next_char): Set next_en_pos to zero when
5132 invalidating its info.
5133
2c91f553
EZ
51342011-10-17 Eli Zaretskii <eliz@gnu.org>
5135
5136 * xdisp.c (push_display_prop): Determine whether to record string
5137 or buffer position by IT->string, not by IT->method. Allow
5138 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5139 (move_it_vertically_backward): Don't look for character position
5140 immediately after the newline when in a continuation line.
5141 (Bug#9771, part 1)
2c91f553 5142
c7b08b0d
MR
51432011-10-15 Martin Rudalics <rudalics@gmx.at>
5144
5145 * window.c (coordinates_in_window): Rewrite and delabelize
5146 vertical border check. (Bug#5357) (Bug#9618)
5147
6b02f655
SM
51482011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5149
5150 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5151 errors in XSetWindowBorder (bug#9310).
5152
81d40c92
DA
51532011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5154
5155 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5156 avoid crash when xmalloc overrun checking is enabled.
5157
d4172c3b
EZ
51582011-10-13 Eli Zaretskii <eliz@gnu.org>
5159
5160 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5161 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5162 cursor motion with <left> and <right> arrow keys.
5163
5164 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5165 some callers set that themselves.
5166
b00eea75
EZ
51672011-10-12 Eli Zaretskii <eliz@gnu.org>
5168
5169 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5170 display string and the previous row comes from the same string and
5171 is empty. (Bug#9739) (Bug#9738)
5172
8fe012c4
SM
51732011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5174
5175 * doc.c (get_doc_string): Encode file name (bug#9735).
5176
0074aef2
EZ
51772011-10-12 Eli Zaretskii <eliz@gnu.org>
5178
79beb178
EZ
5179 * bidi.c (bidi_level_of_next_char):
5180 * xdisp.c (get_visually_first_element): Remove old incorrect
5181 comments regarding the Unicode Line Separator character.
5182
0074aef2
EZ
5183 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5184
6e4b3fbe
DA
51852011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5186
5187 * alloc.c (Fgc_status): Do not access beyond zombies array
5188 boundary if nzombies > MAX_ZOMBIES.
5189 * alloc.c (dump_zombies): Add missing format specifier.
5190
0324f3af
PE
51912011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5192
b5525cac
PE
5193 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5194 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5195
0324f3af
PE
5196 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5197 Some packages use them to denote characters with modifiers.
5198
e9b5f888
AS
51992011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5200
5201 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5202 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5203 matching a pp-number. Rename parameter var to var1.
5204
127827c0
SM
52052011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5206
5207 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5208
c8fd3bd0
GM
52092011-10-08 Glenn Morris <rgm@gnu.org>
5210
5211 * callint.c (Fcall_interactively): Give a more explicit error for the
5212 'c' case with a non-character input. (Bug#8479)
5213
352ec8ff
EZ
52142011-10-08 Eli Zaretskii <eliz@gnu.org>
5215
03669ccb
EZ
5216 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5217 lines.
7061c986
EZ
5218 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5219 lines that are hscrolled on the left.
03669ccb 5220
352ec8ff
EZ
5221 * dispnew.c (buffer_posn_from_coords): Account for a possible
5222 presence of header-line. (Bug#4426)
5223
a66cfb1c
SM
52242011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5225
6b02f655
SM
5226 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5227 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5228
7c5ee88e
PE
52292011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5230
5231 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5232 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5233 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5234 this makes Emacs dump core during garbage collection on rare
5235 occasions. sizeof is obviously inferior to offsetof here, so
5236 stick with offsetof.
5237 (GC_POINTER_ALIGNMENT): New macro.
5238 (mark_memory): Omit 3rd (offset) arg; caller changed.
5239 Don't assume EMACS_INT alignment is the same as pointer alignment.
5240
df1bbe5b
SM
52412011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5242
5243 * keyboard.c (read_key_sequence_remapped): New var.
5244 (read_key_sequence): Compute remapping in the right buffer.
5245 (command_loop_1): Use read_key_sequence's remapping directly.
5246
51553db6
SM
52472011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5248
32c1fffd
SM
5249 * dired.c (file_name_completion): Don't expand file name.
5250 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5251 before checking file name handler.
5252
51553db6
SM
5253 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5254 they've been requested explicitly (bug#9591).
5255
b6bd1599 52562011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5257
5258 * keymap.c (Fsingle_key_description): Use make_specified_string
5259 instead of build_string to build string from push_key_description.
5260 (Bug#5193)
5261
f701dc2a
PE
52622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5263
4222c55d
PE
5264 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5265 This fixes a Y2038 bug on 64-bit hosts.
5266 * buffer.c (reset_buffer):
5267 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5268 (Fclear_buffer_auto_save_failure):
5269 Use 0, not -1, to represent an unset failure time, since time_t
5270 might not be signed.
5271
f701dc2a
PE
5272 Remove dependency on glibc malloc internals.
5273 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5274 Move back here from lisp.h, but with their new implementations.
5275 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5276 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5277 * charset.c (charset_table_init): New static var.
5278 (syms_of_charset): Use it instead of xmalloc. This removes a
5279 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5280 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5281 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5282 Move back to alloc.c.
5283 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5284 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5285
9ceebf39
JD
52862011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5287
5288 * nsterm.m (windowDidResize): Call x_set_window_size only when
5289 ns_in_resize is true. Otherwise set pixelwidth/height and
5290 call change_frame_size (Bug#9628).
5291
cb993c58
PE
52922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5293
3930c88b
PE
5294 Port --enable-checking=all to Fedora 14 x86-64.
5295 * charset.c (syms_of_charset): Also account for glibc malloc's
5296 internal overhead when calculating the initial malloc maximum.
5297
cb993c58
PE
5298 Port --enable-checking=all to Fedora 14 x86.
5299 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5300 Move to lisp.h.
5301 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5302 (overrun_check_realloc, overrun_check_free):
5303 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5304 That way, xmalloc returns a properly-aligned pointer even if
5305 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5306 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5307 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5308 into account when calculating the initial malloc maximum.
5309 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5310 Move here from alloc.c, so that charset.c can use it too.
5311 Properly align; the old code wasn't right for common 32-bit hosts
5312 when configured with --enable-checking=all.
5313 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5314 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5315
31bed486
EZ
53162011-09-29 Eli Zaretskii <eliz@gnu.org>
5317
04c70788 5318 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5319 use EDOM.
5320
fbcaa2f3
EZ
53212011-09-28 Eli Zaretskii <eliz@gnu.org>
5322
5323 * xdisp.c (compute_display_string_end): If there's no display
5324 string at CHARPOS, return -1.
5325
5326 * bidi.c (bidi_fetch_char): When compute_display_string_end
5327 returns a negative value, treat the character as a normal
5328 character not covered by a display string. (Bug#9624)
5329
a239d4e9
JB
53302011-09-28 Juanma Barranquero <lekktu@gmail.com>
5331
5332 * lread.c (Fread_from_string): Fix typo in docstring.
5333
88652fd5
EZ
53342011-09-27 Eli Zaretskii <eliz@gnu.org>
5335
5336 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5337 newline, reseat the iterator instead of bidi-iterating there one
5338 character at a time. (Bug#9610)
32c1fffd
SM
5339 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5340 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5341
ed497dd4
AS
53422011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5343
5344 * lread.c (readevalloop): Use correct code for NBSP.
5345 (read1): Likewise. (Bug#9608)
5346
b2bf61aa
MA
53472011-09-25 Michael Albinus <michael.albinus@gmx.de>
5348
5349 * dbusbind.c (Fdbus_register_signal): When service is not
5350 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5351
32bbb17c
GM
53522011-09-25 Glenn Morris <rgm@gnu.org>
5353
5354 * buffer.c (truncate-lines): Doc fix.
5355
94e0933e
CY
53562011-09-24 Chong Yidong <cyd@stupidchicken.com>
5357
5358 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5359 (Fset_window_next_buffers): Doc fix.
5360
cddde921
GM
53612011-09-24 Glenn Morris <rgm@gnu.org>
5362
5363 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5364
1260aef1
PE
53652011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5366
25b4bfa0
PE
5367 Fix minor problems found by static checking.
5368 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5369 * indent.c (Fvertical_motion): Fix == vs = typo.
5370
e3cbd34b
EZ
53712011-09-24 Eli Zaretskii <eliz@gnu.org>
5372
a66cfb1c
SM
5373 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5374 Default value is now t. Doc fix.
6bf7006f 5375
e3cbd34b 5376 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5377 logic when moving up, not only when moving down. Fix the
e3cbd34b 5378 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5379 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5380
5381 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5382 CHARPOS is covered by a display string which includes newlines.
5383 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5384 is covered by a display string with embedded newlines.
5385
a3de0cbd
MA
53862011-09-24 Michael Albinus <michael.albinus@gmx.de>
5387
5388 * dbusbind.c (Fdbus_register_signal): Add match rule to
5389 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5390 (Fdbus_register_method, Vdbus_registered_objects_table):
5391 Fix docstring.
a3de0cbd 5392
b260039d
JM
53932011-09-24 Jim Meyering <meyering@redhat.com>
5394
32c1fffd 5395 do not ignore write error for any output size
b260039d
JM
5396 The previous change was incomplete.
5397 While it makes emacs --batch detect the vast majority of stdout
5398 write failures, errors were still ignored whenever the output size is
5399 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5400 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5401 && echo FAIL: ignored write error
5402 FAIL: ignored write error
5403 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5404 && echo FAIL: ignored write error
5405 FAIL: ignored write error
5406 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5407
8eca8a7c
AS
54082011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5409
5410 * emacs.c (Fkill_emacs): In noninteractive mode exit
5411 non-successfully if a write error occurred on stdout. (Bug#9574)
5412
3341db62
EZ
54132011-09-21 Eli Zaretskii <eliz@gnu.org>
5414
5415 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5416 the xassert test.
5417
5418 * dispextern.h (struct it): Update the comment documenting what
5419 can it->OBJECT be.
5420
8c203dbf
EZ
54212011-09-20 Eli Zaretskii <eliz@gnu.org>
5422
5423 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5424 a display string, extend search for cursor position to end of row.
5425 (find_row_edges): If the row ends in a newline from a display
5426 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5427 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5428 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5429 non-empty line. Fixes confusing cursor motion with arrow keys at
5430 the beginning of a line that starts with whitespace.
8c203dbf 5431
a4824228
LMI
54322011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5433
5434 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5435 (bug#9493).
5436
33ed493b
CY
54372011-09-18 Chong Yidong <cyd@stupidchicken.com>
5438
5439 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5440 boolean (Bug#9154).
5441
56cd55c8
EZ
54422011-09-18 Eli Zaretskii <eliz@gnu.org>
5443
5444 * xdisp.c (display_line): Record maximum and minimum buffer
5445 positions even if no glyphs were produced (e.g., by a zero-width
5446 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5447 buffer positions that will be removed from the glyph row because
5448 they don't fit.
c02dcedf
EZ
5449 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5450 column is beyond frame width: don't subtract 1 "pixel" when
5451 computing width of the stretch.
3e62b7e0
EZ
5452 (reseat_at_next_visible_line_start): Undo the change made on
5453 2011-09-17 that saved paragraph information and restored it after
5454 the call to `reseat'. (Bug#9545)
56cd55c8 5455
5ed99d36 54562011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5457
5458 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5459 and turn window cursor on if cleared (Bug#9415).
5460
5ed99d36 54612011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5462
5463 * search.c (boyer_moore): Take unibyte characters from pattern
5464 literally. (Bug#9458)
5465
9bade7b2
EZ
54662011-09-18 Eli Zaretskii <eliz@gnu.org>
5467
5468 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5469
e5e9d610
PE
54702011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5471
87e4427a
PE
5472 Fix minor problem found by static checking.
5473 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5474 initialized, to pacify gcc -Wuninitialized.
5475
e5e9d610
PE
5476 * fileio.c: Report proper errno when syscall falls.
5477 (Finsert_file_contents): Save and restore errno,
5478 so that report_file_error outputs the correct diagnostic.
5479 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5480
a1674f0b
EZ
54812011-09-18 Eli Zaretskii <eliz@gnu.org>
5482
5483 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5484
fbfb6dd4
EZ
54852011-09-17 Eli Zaretskii <eliz@gnu.org>
5486
5487 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5488 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5489
bb187662
EZ
54902011-09-17 Eli Zaretskii <eliz@gnu.org>
5491
1137e8b8 5492 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5493 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5494
5495 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5496 (bidi_find_paragraph_start): Search back for paragraph beginning
5497 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5498 (bidi_move_to_visually_next): Only trigger paragraph-related
5499 computations when the last character is a newline or at EOB, not
5500 just any NEUTRAL_B. (Bug#9470)
5501
bb187662
EZ
5502 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5503 truncated lines if point is covered by a display string. (Bug#9524)
5504
2e621251
PE
55052011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5508 (cons_to_x_long): New function.
5509 (lisp_data_to_selection_data): Use it. Correct the test for
5510 short-versus-long data; it was negated. Break out of vector
5511 loop, for efficiency, when a long datum is discovered.
5512
91a15bc6
SM
55132011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5514
5515 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5516
b41c3a35
EZ
55172011-09-16 Eli Zaretskii <eliz@gnu.org>
5518
5519 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5520 GCC PR/17406) by declaring this function with external scope.
5521
7812ba2d
PE
55222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5523
5524 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5525 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5526
cf7edc2a
AS
55272011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5528
5529 * editfns.c (Fformat): Correctly handle text properties on "%%".
5530
bd01620e
EZ
55312011-09-15 Eli Zaretskii <eliz@gnu.org>
5532
5533 * xterm.c (x_draw_composite_glyph_string_foreground):
5534 * w32term.c (x_draw_composite_glyph_string_foreground):
5535 * term.c (encode_terminal_code):
5536 * composite.c (composition_update_it, get_composition_id):
5537 * xdisp.c (get_next_display_element)
5538 (fill_composite_glyph_string): Add comments about special meaning
5539 of TAB characters in a composition.
5540
a02719a3
PE
55412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5542
5543 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5544 This occurs when processing a multibyte format.
5545 Problem reported by Wolfgang Jenker.
a02719a3 5546
72589a3c
JB
55472011-09-15 Johan Bockgård <bojohan@gnu.org>
5548
5549 * xdisp.c (try_cursor_movement): Only check for exact match if
5550 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5551
1c14176c
PE
55522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5553
5554 Remove unused external symbols.
5555 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5556 * xdisp.c (calc_pixel_width_or_height): Now static.
5557 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5558 * indent.c (check_display_width):
5559 * w32term.c: Fix comment to match code.
5560 * xterm.c, xterm.h (x_catching_errors): Remove.
5561
d2eea5b5
PE
55622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5563
5564 * xselect.c: Use signed conversions more consistently (Bug#9498).
5565 (selection_data_to_lisp_data): Assume incoming selection data are
5566 signed integers, not unsigned. This is to be consistent with
5567 outgoing selection data, which was modified to use signed integers
5568 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5569 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5570 expects long, not unsigned long.
5571
46888499
EZ
55722011-09-14 Eli Zaretskii <eliz@gnu.org>
5573
5574 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5575 computation of loop end. Reported by Johan Bockgård
5576 <bojohan@gnu.org>.
5577
ef8ef9fb
CY
55782011-09-13 Chong Yidong <cyd@stupidchicken.com>
5579
5580 * frame.c (Fother_visible_frames_p): Function deleted.
5581
fa819fed
EZ
55822011-09-12 Eli Zaretskii <eliz@gnu.org>
5583
5584 * indent.c (compute_motion): Process display vector front to back
5585 rather than the other way around. (Bug#2496)
5586
2ba8e008
SM
55872011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5588
5589 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5590
20f53c69
CY
55912011-09-11 Chong Yidong <cyd@stupidchicken.com>
5592
5593 * minibuf.c (Fread_from_minibuffer): Doc fix.
5594
d562d7a4
EZ
55952011-09-11 Eli Zaretskii <eliz@gnu.org>
5596
5597 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5598 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5599
1c4d7f3d
LMI
56002011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5601
5602 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5603 value for non-existent files.
5604
b885bf36
EZ
56052011-09-11 Eli Zaretskii <eliz@gnu.org>
5606
5607 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5608 set its "size" to -1. This will set the modtime_size field of
5609 the corresponding buffer to -1, which is what
5610 verify-visited-file-modtime expects for files that do not exist.
5611 (Bug#9139)
5612
6612f0bf
PE
56132011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5614
5615 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5616 here ...
5617 * lisp.h: ... from here. push_key_description is no longer
5618 defined in keyboard.c, so its declaration should not be in
5619 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5620 logically belongs with push_key_description.
5621
dfb3f755
PE
56222011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5623
5624 * buffer.h: Include <sys/types.h> instead of <time.h>.
5625 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5626 Problem reported by Herbert J. Skuhra.
5627
3134906c
LMI
56282011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5629
5630 * xml.c (parse_region): Make the parsing work for
5631 non-comment-starting XML files again (bug#9144).
5632
8d903f4e
AS
56332011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5634
5635 * image.c (gif_load): Fix calculation of bottom and right corner.
5636 (Bug#9468)
5637
80ad64f4
EZ
56382011-09-10 Eli Zaretskii <eliz@gnu.org>
5639
5640 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5641 redisplay in small windows.
5642
208a048d
EZ
56432011-09-09 Eli Zaretskii <eliz@gnu.org>
5644
5645 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5646
9b1c252e
MR
56472011-09-08 Martin Rudalics <rudalics@gmx.at>
5648
5649 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5650 Operate on live windows only.
5651
2949f33b
JB
56522011-09-08 Juanma Barranquero <lekktu@gmail.com>
5653
5654 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5655
e08dcafd
EZ
56562011-09-07 Eli Zaretskii <eliz@gnu.org>
5657
5658 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5659 only under bidi iteration.
5660
115b96bd
JD
56612011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5662
5663 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5664
c8199d0f
PE
56652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5668 Without this fix, the command to link temacs failed due to an
5669 undefined symbol __builtin_isnan. This is because
5670 /usr/include/iso/math_c99.h #defines isnan(x) to
5671 __builtin_isnan(x), but the bundled gcc, which identifies itself
5672 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5673 a __builtin_isnan.
5674 * floatfns.c (isnan): #undef, and then #define to a clone of
5675 what's in data.c.
5676 (Fisnan): Always define, since it's always available now.
5677 (syms_of_floatfns): Always define isnan at the Lisp level.
5678
e39b275c 56792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5680
5681 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5682
b2db44d9 56832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5684
f4af5137 5685 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5686 The previous code assumed that file offsets (off_t values) fit in
5687 EMACS_INT variables, which is not true on typical 32-bit hosts.
5688 The code messed up by falsely reporting buffer overflow in cases
5689 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5690 when "big" contains more than 2**29 bytes, even though this
5691 inserts just one byte and does not overflow the buffer.
5692 (Finsert_file_contents): Store file offsets as off_t
5693 values, not as EMACS_INT values. Check for overflow when
5694 converting between EMACS_INT and off_t. When checking for
5695 buffer overflow or for overlap, take the offsets into account.
5696 Don't use EMACS_INT for small values where int suffices.
5697 When checking for overlap, fix a typo: ZV was used where
5698 ZV_BYTE was intended.
5699 (Fwrite_region): Don't assume off_t fits into 'long'.
5700 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5701
ecfc0a49
MA
57022011-09-05 Michael Albinus <michael.albinus@gmx.de>
5703
5704 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5705
6511acf2 57062011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5707
0999621a 5708 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5709
5710 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5711 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5712 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5713 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5714 (modify_event_symbol): Do not assume that the length of
5715 name_alist_or_stem is safe to alloca and fits in int.
5716 (Fexecute_extended_command): Likewise for function name and binding.
5717 (Frecursion_depth): Wrap around reliably on integer overflow.
5718 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5719 since some callers pass EMACS_INT values.
5720 (Fsingle_key_description): Don't crash if symbol name contains more
5721 than MAX_ALLOCA bytes.
5722 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5723 (get_minibuffer): Arg is now EMACS_INT, not int.
5724 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5725 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5726 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5727
2be7d702
PE
5728 * dbusbind.c (signature_cat): New function.
5729 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5730 Do not overrun buffer; instead, report string overflow.
5731
9d1df220
PE
5732 * dispnew.c (add_window_display_history): Don't overrun buffer.
5733 Truncate instead; this is OK since it's just a log.
5734
33ef5c64
PE
5735 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5736 even if the time zone offset is outlandishly large.
5737 Don't mishandle offset == INT_MIN.
5738
66c6fdd5
PE
5739 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5740 when creating daemon; the previous buffer-overflow check was incorrect.
5741
d749b01b
PE
5742 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5743 which has the guts of the old verror function.
5744
b5cd1905
PE
5745 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5746 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5747
6e1a67fb
PE
5748 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5749 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5750 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5751 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5752 length of string rather than counting it via multiple sprintfs;
5753 that's simpler and more reliable.
c21721cc
PE
5754 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5755 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5756 sprintf, in case result does not fit in int.
5757
c57b67fc
PE
5758 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5759 (fontset_from_font): Print it.
5760
8a401434
PE
5761 * frame.c (tty_frame_count): Now printmax_t, not int.
5762 (make_terminal_frame, set_term_frame_name): Print it.
5763 (x_report_frame_params): In X, window IDs are unsigned long,
5764 not signed long, so print them as unsigned.
5765 (validate_x_resource_name): Check for implausibly long names,
5766 and don't assume name length fits in 'int'.
5767 (x_get_resource_string): Don't blindly alloca invocation name;
5768 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5769 not fit in int.
5770
6e1a67fb
PE
5771 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5772 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5773 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5774
0df02bf3
PE
5775 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5776 Use esprintf, not sprintf, in case result does not fit in int.
5777
48e30793
PE
5778 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5779 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5780 it as a large positive number.
5781 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5782 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5783
a66ff6d8
PE
5784 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5785 in case result does not fit in int.
5786
aca216ff
PE
5787 * print.c (float_to_string): Detect width overflow more reliably.
5788 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5789 buffer overrun. Don't assume list length fits in 'int'. Treat
5790 print length of 0 as 0, not as infinity; to be consistent with other
5791 uses of print length in this function. Don't overflow print length
5792 index. Don't assume hash table size fits in 'long', or that
5793 vectorlike size fits in 'unsigned long'.
5794
31c286f7
PE
5795 * process.c (make_process): Use printmax_t, not int, to format
5796 process-name gensyms.
5797
55e5faa1
PE
5798 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5799
80f2e268
PE
5800 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5801 to avoid potential buffer overrun.
5802
670741ab
PE
5803 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5804 if X resource line is longer than 512 bytes.
5805
b7163a50
PE
5806 * xfns.c (x_window): Make sprintf buffer a bit bigger
5807 to avoid potential buffer overrun.
5808
ae58ff1f
PE
5809 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5810
c43c8a6a
PE
5811 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5812
3f8236f4
PE
58132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5814
53e9fe90 5815 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5816 Without these, Emacs silently mishandles large integers sometimes.
5817 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5818 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5819
6511acf2
PE
5820 * xdisp.c (try_window_id): Check Emacs fixnum range before
5821 converting to 'int'.
806add1d 5822
6511acf2 5823 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5824 Check that an Emacs fixnum is in range before assigning it to 'int'.
5825 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5826 values converted from Emacs fixnums.
5827 (Frecenter): Don't wrap around a line count if it is out of 'int'
5828 range; instead, treat it as an extreme value.
5829 (Fset_window_configuration, compare_window_configurations):
5830 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5831
6511acf2
PE
5832 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5833 that can exceed INT_MAX. Check that EMACS_INT value is in range
5834 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5835 (match_limit): Don't assume that a fixnum can fit in 'int'.
5836
6511acf2 5837 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5838 exceed INT_MAX.
5839
6511acf2 5840 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5841 (Fvertical_motion): Don't wrap around LINES values that don't fit
5842 in 'int'. Instead, treat them as extreme values. This is good
5843 enough for windows, which can't have more than INT_MAX lines anyway.
5844
fcb901a7
LMI
58452011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5846
0f2f6b6d
LMI
5847 * Require libxml/parser.h to avoid compilation warning.
5848
fcb901a7
LMI
5849 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5850
5851 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5852 since this reportedly can destroy thread storage.
5853
6e20a0d4
CY
58542011-08-30 Chong Yidong <cyd@stupidchicken.com>
5855
5856 * syntax.c (find_defun_start): Update all cache variables if
5857 exiting early (Bug#9401).
5858
148ae00e
EZ
58592011-08-30 Eli Zaretskii <eliz@gnu.org>
5860
f6cfbd8f
EZ
5861 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5862
148ae00e
EZ
5863 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5864 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5865 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5866
5867 * term.c (tty_append_glyph): New function.
5868 (produce_stretch_glyph): Static function and its prototype deleted.
5869
a66cfb1c
SM
5870 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5871 Add prototypes.
148ae00e 5872
c4a07a4c
PE
58732011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5874
5875 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5876 when checking :margin (Bug#9390).
5877 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5878 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5879 so that the name doesn't mislead. All uses changed.
5880
6bc8cd65
JB
58812011-08-28 Johan Bockgård <bojohan@gnu.org>
5882
5883 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5884 set_tty_hooks.
5885
dca4927e
EZ
58862011-08-27 Eli Zaretskii <eliz@gnu.org>
5887
5888 * xdisp.c (move_it_to): Don't bail out early when reaching
5889 position beyond to_charpos, if we are scanning backwards.
5890 (move_it_vertically_backward): When DY == 0, make sure we get to
5891 the first character in the line after the newline.
5892
f2cad773
PE
58932011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5894
5895 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5896 (ccl_driver): Do not generate an out-of-range pointer.
5897 (Fccl_execute_on_string): Remove unnecessary check for
5898 integer overflow, noted by Stefan Monnier in
5899 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5900 Remove a FIXME that didn't need fixing.
5901 Simplify the newly-introduced buffer reallocation code.
5902
0cae2cdb
JB
59032011-08-27 Juanma Barranquero <lekktu@gmail.com>
5904
5905 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5906
5fc295a4 59072011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5908
70c60eb2 5909 Integer and memory overflow issues (Bug#9196).
726e0ab1 5910
d31850da
PE
5911 * doc.c (get_doc_string): Rework so that
5912 get_doc_string_buffer_size is the actual buffer size, rather than
5913 being 1 less than the actual buffer size; this makes xpalloc more
5914 convenient.
5915
a69fbedb
PE
5916 * image.c (x_allocate_bitmap_record, cache_image):
5917 * xselect.c (Fx_register_dnd_atom):
5918 Simplify previous changes by using xpalloc.
5919
fe5c5d37
PE
5920 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5921 since either will do and ptrdiff_t is convenient with xpalloc.
5922
0065d054
PE
5923 * charset.c (charset_table_size)
5924 (struct charset_sort_data.priority): Now ptrdiff_t.
5925 (charset_compare): Don't overflow if priorities differ greatly.
5926 (Fsort_charsets): Don't assume list length fits in int.
5927 Check for size-calculation overflow when allocating sort data.
5928 (syms_of_charset): Allocate an initial charset table that is
5929 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5930
5931 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5932
5933 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5934 The actual value is always <= INT_MAX, and leaving it unsigned made
5935 overflow checking harder.
5936
5937 * dispextern.h (struct glyph_matrix.rows_allocated)
5938 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5939 with xpalloc. The values are still always <= INT_MAX.
5940
5941 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5942
5943 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5944 (SAFE_NALLOCA): New macro.
5945
5946 * region-cache.c (struct boundary.pos, find_cache_boundary)
5947 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5948 (set_cache_region, invalidate_region_cache)
5949 (revalidate_region_cache, know_region_cache, region_cache_forward)
5950 (region_cache_backward, pp_cache):
5951 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5952 so that ptrdiff_t * can be passed to xpalloc.
5953 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5954 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5955 (pp_cache): Don't assume cache_len fits in int.
5956 * region-cache.h: Adjust extern decls to match.
5957
5958 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5959 EMACS_INT, since either will do, for xpalloc.
5960
5961 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5962 (xnmalloc, xnrealloc, xpalloc): New functions.
5963
726e0ab1
PE
5964 * bidi.c (bidi_shelve_header_size): New constant.
5965 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5966 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5967
51f30bc5 5968 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5969 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5970 (overlay_strings):
5971 Don't update size of array until after memory allocation succeeds,
5972 because xmalloc/xrealloc may not return.
0065d054
PE
5973 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5974 now that we have proper integer overflow checking.
5975 (record_overlay_string, overlay_strings): Catch overflows when
5976 calculating size of overlay_str_buf.
726e0ab1 5977
0065d054
PE
5978 * callproc.c (Fcall_process): Check for size overflow when
5979 calculating size of args2.
5980 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5981 Normally we prefer signed values, but sticking with ptrdiff_t would
5982 require adding more-complicated checks.
726e0ab1
PE
5983
5984 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5985 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5986 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5987 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5988
5989 * character.c (Fstring): Check for size-calculation overflow.
5990
5991 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5992 unnecessary integer overflow. Check for size overflow.
5993 (encode_coding_object): Don't update size until xmalloc succeeds.
5994
5995 * composite.c (get_composition_id): Check for overflow in glyph
5996 length calculations.
5997
5998 Integer and memory overflow fixes for display code.
5999 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6000 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6001 (scrolling_window): Check for overflow in size calculations.
6002 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6003 Don't assume glyph table len fits in int.
6004 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6005 (row_table_size): Now ptrdiff_t, not int.
6006 (scrolling_window): Avoid overflow in size calculations.
6007 Don't update size until allocation succeeds.
6008 * fns.c (concat): Check for overflow in size calculations.
6009 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6010 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6011 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6012
6013 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6014 (get_doc_string): Check for size calculation overflow.
6015 Don't update size until allocation succeeds.
6016 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6017 EMACS_INT, where ptrdiff_t will do.
6018 (Fsubstitute_command_keys): Check for string overflow.
6019
6020 * editfns.c (set_time_zone_rule): Don't assume environment length
6021 fits in int.
6022 (message_length): Now ptrdiff_t, not int.
6023 (Fmessage_box): Don't update size until allocation succeeds.
6024 Don't assume message length fits in int.
6025 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6026
0065d054
PE
6027 * emacs.c (main): Do not reallocate argv, since there is a null at
6028 the end that can be overwritten, and this way there's no need to
6029 worry about size-calculation overflow.
6030 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6031
6032 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6033 alloc succeeds.
6034 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6035
6036 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6037 (x_set_scroll_bar_width, x_figure_window_size):
6038 Check for integer overflow.
6039 (x_set_alpha): Do not assume XINT fits in int.
6040
6041 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6042 This is for the members text_lines, text_cols, total_lines, total_cols,
6043 where the system imposes an 'int' limit.
6044
6045 * fringe.c (Fdefine_fringe_bitmap):
6046 Don't update size until alloc works.
6047
6048 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6049 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6050
6051 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6052 Check for size-calculation overflow.
6053 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6054 do, as we prefer signed integers.
6055 (id_to_widget.max_size, id_to_widget.used)
6056 (xg_store_widget_in_map, xg_remove_widget_from_map)
6057 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6058 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6059 Use and return ptrdiff_t, not int.
6060 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6061 * gtkutil.h: Change prototypes to match the above.
6062
6063 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6064 are duplicate now that they've been promoted to lisp.h.
6065 (x_allocate_bitmap_record, x_alloc_image_color)
6066 (make_image_cache, cache_image, xpm_load):
6067 Don't update size until alloc is done.
6068 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6069 (x_detect_edges):
3256efce 6070 Check for size calculation overflow.
726e0ab1
PE
6071 (ct_colors_allocated_max): New constant.
6072 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6073 overflow.
3256efce 6074
726e0ab1
PE
6075 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6076 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6077 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6078 Use ptrdiff_t, not int, to count maps.
6079 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6080 calculations. Don't update size until allocation succeeds.
6081 Redo calculations to avoid overflow.
726e0ab1
PE
6082 * keyboard.h: Change prototypes to match the above.
6083
6084 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6085 to count maps.
6086 (current_minor_maps): Check for size calculation overflow.
6087 * keymap.h: Change prototypes to match the above.
6088
6089 * lread.c (read1, init_obarray): Don't update size until alloc done.
6090
6091 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6092 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6093
726e0ab1
PE
6094 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6095 Now ptrdiff_t, not int.
6096 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6097 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6098
6099 * process.c (Fnetwork_interface_list): Check for overflow
6100 in size calculation.
6101
6102 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6103
6104 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6105 overflow. Don't bother calling xmalloc when xrealloc will do.
6106
6107 * search.c (Freplace_match): Check for size calculation overflow.
6108 (Fset_match_data): Don't assume list lengths fit in 'int'.
6109
6110 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6111 for command line length. Do not attempt to address one before the
6112 beginning of an array, as that's not portable.
6113
6114 * term.c (max_frame_lines): Remove; unused.
6115 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6116 not int.
6117 (encode_terminal_code, calculate_costs): Check for size
6118 calculation overflow.
6119 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6120 table lengths and related sizes. Don't update size until alloc
6121 done. Redo calculations to avoid overflow.
6122 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6123
6124 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6125 subtracting pointers.
6126 (gobble_line): Check for overflow more carefully. Don't update size
6127 until alloc done.
6128
6129 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6130 Don't update size until alloc done.
6131 Redo size calculations to avoid overflow.
6132 Check for size calculation overflow.
0065d054 6133 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6134
6135 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6136 Use ptrdiff_t, not int, for sizes.
6137 (store_mode_line_noprop_char): Don't update size until alloc done.
6138
0065d054
PE
6139 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6140 Use ptrdiff_t, not int, for sizes.
6141 (Finternal_make_lisp_face, cache_face):
6142 Check for size calculation overflow.
6143 (cache_face): Treat size calculation overflows as if they were
6144 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6145
6146 * xfns.c (x_encode_text, x_set_name_internal)
6147 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6148 sizes, since they can exceed INT_MAX in size. Check for size
6149 calculation overflow.
6150
0065d054
PE
6151 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6152 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6153 Don't update size until alloc done.
6154
0065d054 6155 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6156 as sprintf is limited to int lengths.
1d526e2f 6157
252c5ee1
PE
6158 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6159 (X_LONG_MIN): New macros.
864d7ce7
PE
6160 Use them to make the following changes clearer.
6161 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6162 This change doesn't affect the value now, but it may help remind
6163 future maintainers not to raise the value too much later.
6164 (SELECTION_QUANTUM): Remove, replacing with ...
6165 (selection_quantum): ... new function, which avoids overflow.
6166 All uses changed.
6167 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6168 assumption that selection length fits in 'int'.
6169 (x_reply_selection_request, x_handle_selection_request)
6170 (x_get_window_property, receive_incremental_selection)
6171 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6172 (lisp_data_to_selection_data, clean_local_selection_data):
6173 Use ptrdiff_t, not int, to record length of selection.
6174 (x_reply_selection_request, x_get_window_property)
6175 (receive_incremental_selection, x_property_data_to_lisp):
6176 Redo calculations to avoid overflow.
6177 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6178 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6179 something.
6180 (x_get_window_property, receive_incremental_selection)
6181 (lisp_data_to_selection_data, x_property_data_to_lisp):
6182 Check for size-calculation overflow.
6183 (x_get_window_property, receive_incremental_selection)
6184 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6185 Don't store size until memory allocation succeeds.
6186 (x_get_window_property): Plug memory leak on memory exhaustion.
6187 Don't double-block input; malloc is safe here. Don't assume 2**34
6188 - 4 fits in unsigned long. Add an xassert to check
6189 XGetWindowProperty overflow. Be more careful about overflow
6190 calculations, and distinguish size from memory overflow better.
6191 (receive_incremental_selection): When tracing, don't assume
6192 unsigned int is less than INT_MAX.
6193 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6194 harmful) conversions of unsigned short to int.
6195 (lisp_data_to_selection_data): Don't assume that integers
6196 in the range -65535 through -1 fit in an X unsigned short.
6197 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6198 result parameters unless successful. Rely on cons_to_unsigned
6199 to report problems with elements; the old code wasn't right anyway.
6200 (x_check_property_data): Check for int overflow; we cannot use
6201 a wider type due to X limits.
6202 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6203
726e0ab1 6204 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6205
0065d054
PE
6206 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6207 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6208 (x_color_cells): Don't store size until memory allocation succeeds.
6209 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6210 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6211 (x_term_init): Don't assume length fits in int (sprintf is limited
6212 to int size).
bc18e09d 6213
ebfa62c0
PE
6214 Use ptrdiff_t for composition IDs.
6215 * character.c (lisp_string_width):
6216 * composite.c (composition_table_size, n_compositions)
6217 (get_composition_id, composition_gstring_from_id):
6218 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6219 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6220 * window.c (Frecenter):
6221 Use ptrdiff_t, not int, for composition IDs.
6222 * composite.c (get_composition_id): Check for integer overflow.
6223 * composite.h: Adjust prototypes to match the above changes.
6224
d3411f89
PE
6225 Use ptrdiff_t for hash table indexes.
6226 * category.c (hash_get_category_set):
6227 * ccl.c (ccl_driver):
6228 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6229 * coding.c (coding_system_charset_list, detect_coding_system):
6230 * coding.h (struct coding_system.id):
6231 * composite.c (get_composition_id, gstring_lookup_cache):
6232 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6233 * image.c (xpm_get_color_table_h):
6234 * lisp.h (hash_lookup, hash_put):
6235 * minibuf.c (Ftest_completion):
6236 Use ptrdiff_t for hash table indexes, not int (which is too
6237 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6238 32-bit --with-wide-int hosts).
6239
e097a6fa
PE
6240 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6241 Add a FIXME comment about memory leaks.
6242 (syms_of_charset): Don't assume xmalloc returns.
6243
5637687f
PE
6244 Don't assume that stated character widths fit in int.
6245 * character.c (Fchar_width, c_string_width, lisp_string_width):
6246 * character.h (CHAR_WIDTH):
6247 * indent.c (MULTIBYTE_BYTES_WIDTH):
6248 Use sanitize_char_width to avoid undefined and/or bad behavior
6249 with outlandish widths.
a66cfb1c 6250 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6251 now that we have two such functions. All uses changed.
6252 (sanitize_char_width): New inline function.
6253
a2271ba2
PE
6254 Don't assume that tab-width fits in int.
6255 * character.h (sanitize_width): New inline function.
6256 (SANE_TAB_WIDTH): New macro.
6257 (ASCII_CHAR_WIDTH): Use it.
6258 * indent.c (sane_tab_width): Remove. All uses replaced by
6259 SANE_TAB_WIDTH (current_buffer).
6260 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6261
18c52557
PE
6262 * fileio.c: Integer overflow issues with file modes.
6263 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6264
caeeedc1
PE
6265 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6266 Remove unreachable code.
6267 (read_hex, load_charset_map_from_file): Check for integer overflow.
6268
6df6ae42 6269 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6270 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6271 (x_send_scroll_bar_event): Likewise. Check that the size does not
6272 exceed limits imposed by XClientMessageEvent, as well as the usual
6273 ptrdiff_t and size_t limits.
6274
b13995db
PE
6275 * keyboard.c: Overflow, signedness and related fixes.
6276 (make_lispy_movement): Use same integer type in forward decl
6277 that is used in the definition.
6278 (read_key_sequence, keyremap_step):
6279 Change bufsize argument back to int, undoing my 2011-03-30 change.
6280 We prefer signed types, and int is wide enough here.
6281 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6282 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6283 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6284 length, not size_t. Use ptrdiff_t for index, not int.
6285 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6286 possibility of integer overflow.
6287
13464394
PE
6288 Overflow, signedness and related fixes for images.
6289
6290 * dispextern.h (struct it.stack[0].u.image.image_id)
6291 (struct_it.image_id, struct image.id, struct image_cache.size)
6292 (struct image_cache.used, struct image_cache.ref_count):
6293 * gtkutil.c (update_frame_tool_bar):
6294 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6295 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6296 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6297 * nsmenu.m (update_frame_tool_bar):
6298 * xdisp.c (calc_pixel_width_or_height):
6299 * xfns.c (image_cache_refcount):
6300 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6301 on typical 64-bit hosts.
6302
6303 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6304 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6305 Omit unnecessary casts to int.
6306 (parse_image_spec): Check that integers fall into 'int' range
6307 when the callers expect that.
6308 (image_ascent): Redo ascent calculation to avoid int overflow.
6309 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6310 (lookup_image): Remove unnecessary tests.
6311 (xbm_image_p): Locals are now of int, not EMACS_INT,
6312 since parse_image_check makes sure they fit into int.
6313 (png_load, gif_load, svg_load_image):
6314 Prefer int to unsigned where either will do.
6315 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6316 old tiff_error_handler and tiff_warning_handler.
6317 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6318 stack buffer overflows. It uses only the features of vsnprintf
6319 that are common to both POSIX and native Microsoft.
6320 (tiff_error_handler, tiff_warning_handler): Use it.
6321 (tiff_load, gif_load, imagemagick_load_image):
6322 Don't assume :index value fits in 'int'.
6323 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6324 (imagemagick_load_image): Check that crop parameters fit into
6325 the integer types that MagickCropImage accepts. Don't assume
6326 Vimagemagick_render_type has a nonnegative value. Don't assume
6327 size_t fits in 'long'.
6328 (gs_load): Use printmax_t to print the widest integers possible.
6329 Check for integer overflow when computing image height and width.
6330
c11821d4
EZ
63312011-08-26 Eli Zaretskii <eliz@gnu.org>
6332
6333 * xdisp.c (redisplay_window): Don't force window start if point
6334 will be invisible in the resulting window. (Bug#9324)
6335
0c95fcf7
EZ
63362011-08-25 Eli Zaretskii <eliz@gnu.org>
6337
6338 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6339 the display spec is of the form `(space ...)'.
6340 (handle_display_spec): Return the value returned by
6341 handle_single_display_spec, not just 1 or zero.
6342 (handle_single_display_spec): If the display spec is of the form
6343 `(space ...)', and specifies display in the text area, return 2
6344 rather than 1.
fee65a97 6345 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6346 accurately, and prefer exact match for point under bidi.
6347 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6348
6349 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6350 into disp_prop; all users changed.
6351
6352 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6353 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6354 for the text covered by the display property.
6355
e4ed06f1
CY
63562011-08-25 Chong Yidong <cyd@stupidchicken.com>
6357
6358 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6359 Change return value to nil.
6360 (Frecord_buffer): Delete unused function.
6361
f67cdd7f
EZ
63622011-08-24 Eli Zaretskii <eliz@gnu.org>
6363
5980d4c6
EZ
6364 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6365 buffers, return left-to-right.
8610fe8b
EZ
6366 (set_cursor_from_row): Consider candidate row a win if its glyph
6367 represents a newline and point is on that newline. Fixes cursor
6368 positioning on the newline at EOL of R2L text within L2R
6369 paragraph, and vice versa.
6370 (try_cursor_movement): Check continued rows, in addition to
6371 continuation rows. Fixes unwarranted scroll when point enters a
6372 continued line of R2L text within an L2R paragraph, or vice versa.
6373 (cursor_row_p): Consider the case of point being equal to
6374 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6375 from the end of a short line to the beginning of a continued line
6376 of R2L text within L2R paragraph.
6377 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6378 composed characters.
5980d4c6 6379
f67cdd7f
EZ
6380 * bidi.c (bidi_check_type): Use xassert.
6381 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6382 members.
6383
bca633fb
EZ
63842011-08-23 Eli Zaretskii <eliz@gnu.org>
6385
6386 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6387 a character.
6388
4a5885a7
CY
63892011-08-23 Chong Yidong <cyd@stupidchicken.com>
6390
6391 * nsfont.m (ns_otf_to_script): Fix typo.
6392
0902a04e
KH
63932011-08-22 Kenichi Handa <handa@m17n.org>
6394
6395 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6396 extra slot even if the purpose is char-code-property-table.
6397
1a2e6670
EZ
63982011-08-23 Eli Zaretskii <eliz@gnu.org>
6399
8ddde651
EZ
6400 * xdisp.c (redisplay_window): When computing centering_position,
6401 account for the height of the header line. (Bug#8874)
6402
425cc014
EZ
6403 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6404 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6405 candidate is selected by the mouse, and that candidate has a
6406 composed character under the mouse.
6407
1a2e6670
EZ
6408 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6409 coordinates reported by pos-visible-in-window-p for a composed
6410 character in column zero.
6411
8b76d6f8
SM
64122011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6413
6414 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6415
dac347dd
EZ
64162011-08-22 Eli Zaretskii <eliz@gnu.org>
6417
6418 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6419 consider it a hit if to_charpos is anywhere in the range of the
6420 composed buffer positions.
6421
e013fb34
CY
64222011-08-22 Chong Yidong <cyd@stupidchicken.com>
6423
6424 * image.c (gif_load): Don't assume that each subimage has the same
6425 dimensions as the base image. Handle disposal method that is
6426 "undefined" by the gif spec (Bug#9335).
6427
bd1ba3e8
CY
64282011-08-20 Chong Yidong <cyd@stupidchicken.com>
6429
6430 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6431 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6432
54a1215b
EZ
64332011-08-19 Eli Zaretskii <eliz@gnu.org>
6434
823564e5
EZ
6435 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6436 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6437 from an Org mode buffer to a Speedbar frame.
6438
54a1215b
EZ
6439 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6440 a composition, take its buffer position from IT->cmp_it.charpos.
6441 Fixes cursor positioning at the beginning of a line that begins
6442 with a composed character.
6443
9778ebcc
EZ
64442011-08-18 Eli Zaretskii <eliz@gnu.org>
6445
0be6ee06
EZ
6446 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6447 character bidirectional type, use STRONG_L instead. Fixes crashes
6448 in a buffer produced by `describe-categories'.
6449
9778ebcc
EZ
6450 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6451 members before the level stack, so they would be saved and
6452 restored when copying iterator state. Fixes incorrect reordering
6453 around TABs covered by display properties.
6454
156bffbe
AS
64552011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6456
6b02f655 6457 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6458
72ad093b
CY
64592011-08-17 Chong Yidong <cyd@stupidchicken.com>
6460
6461 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6462 (internal_condition_case_2, internal_condition_case_n):
6463 Remove unnecessary aborts (Bug#9081).
72ad093b 6464
35774242
EZ
64652011-08-17 Eli Zaretskii <eliz@gnu.org>
6466
6467 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6468 has no `load' handler, try opening the file locally. (Bug#9311)
6469
db76dd85
KB
64702011-08-16 Ken Brown <kbrown@cornell.edu>
6471
6472 * gmalloc.c: Expand comment.
6473
b215eee5
EZ
64742011-08-16 Eli Zaretskii <eliz@gnu.org>
6475
6476 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6477 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6478
a4579d33
KB
64792011-08-16 Ken Brown <kbrown@cornell.edu>
6480
6481 Fix memory allocation problems in Cygwin build (Bug#9273).
6482
6483 * unexcw.c ( __malloc_initialized): Declare external variable.
6484 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6485
8b76d6f8
SM
6486 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6487 New variables.
a4579d33
KB
6488 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6489 dumped emacs.
6490 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6491 in the static heap.
6492 [CYGWIN] (special_realloc): New function.
6493 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6494 requests to realloc storage in the static heap.
6495
3ebec551
PE
64962011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6497
6498 * bidi.c (bidi_initialize): Remove unused local.
6499
9fd8be00
EZ
65002011-08-15 Eli Zaretskii <eliz@gnu.org>
6501
6b02f655
SM
6502 * bidimirror.h:
6503 * biditype.h: Remove file.
6504 * makefile.w32-in ($(BLD)/bidi.$(O)):
6505 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6506
6507 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6508
6509 * chartab.c: Improve commentary for the uniprop_table API.
6510
32413314
EZ
6511 * bidi.c (bidi_paragraph_init): Support zero value of
6512 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6513 (bidi_initialize): Use uniprop_table instead of including
6514 biditype.h and bidimirror.h.
32413314 6515
9fd8be00
EZ
6516 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6517 coordinates of the iterator when restoring from ppos_it.
6518 (Bug#9296)
6519
5cf2b69b
KH
65202011-08-14 Kenichi Handa <handa@m17n.org>
6521
6522 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6523 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6524
daf17d00
EZ
65252011-08-14 Eli Zaretskii <eliz@gnu.org>
6526
6527 * xdisp.c (move_it_in_display_line_to): Don't invoke
6528 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6529 ppos_it. Fixes vertical cursor motion when line beginning is
6530 covered by an image. (Bug#9296)
6531
08e3161a
JD
65322011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6533
6534 * nsterm.h (ns_run_ascript): Declare.
6535 (NSAPP_DATA2_RUNASSCRIPT): Define.
6536
6537 * nsfns.m (as_script, as_result, as_status): New static variables.
6538 (ns_run_ascript): New function.
5e617bc2 6539 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6540 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6541 the event loop. Get status from as_status (Bug#7276).
6542
6543 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6544 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6545 the event loop (Bug#7276).
6546
a3720aa2
AS
65472011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6548
6549 * gnutls.c (QCgnutls_bootprop_priority)
6550 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6551 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6552 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6553 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6554 (QCgnutls_bootprop_verify_hostname_error)
6555 (QCgnutls_bootprop_callbacks_verify): Rename from
6556 Qgnutls_bootprop_..., all uses changed.
6557
6558 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6559 uses changed.
6560
0a0d27fb
PE
65612011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6562
19d5c50c
PE
6563 * xfaces.c (Qframe_set_background_mode): Now static.
6564 * dispextern.h (Qframe_set_background_mode): Remove decl.
6565
0a0d27fb
PE
6566 * process.c (Fnetwork_interface_info): Declare local only if needed.
6567
377538cb
JD
65682011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6569
6570 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6571 (Fnetwork_interface_list): Allocate in increments of bytes instead
6572 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6573 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6574 sockaddr.
6575 (struct ifflag_def): notrailers is smart on OSX.
6576 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6577 Get hardware address with getifaddrs if available.
6578
08fff70c
EZ
65792011-08-12 Eli Zaretskii <eliz@gnu.org>
6580
6581 * xdisp.c (iterate_out_of_display_property): xassert that
6582 IT->position is set to within IT->object's boundaries. Break from
6583 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6584 when IT->position is set up wrongly due to some bug.
6585 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6586 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6587 entry. Force push_it to save on the stack the current
6588 buffer/string position, to be restored by pop_it. Fix flags in
6589 the iterator structure wrt the object coming from a display
6590 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6591 properties. (Bug#9284)
6592
7be1c708 65932011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6594
7be1c708
CY
6595 * fontset.c (fontset_get_font_group): Add proper type checks.
6596 (Bug#9172)
aac0c6e3 6597
7be1c708 65982011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6599
7be1c708
CY
6600 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6601 and LC_VERSION_MIN_MACOSX.
6602 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6603 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6604
97bb72a6
EZ
66052011-08-08 Eli Zaretskii <eliz@gnu.org>
6606
6607 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6608 no-display-properties-and-no-overlays under bidi display.
6609 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6610 properties and overlays.
97bb72a6 6611
d5617611
CY
66122011-08-08 Chong Yidong <cyd@stupidchicken.com>
6613
37e11a63
CY
6614 * editfns.c (Fset_time_zone_rule): Document relationship with the
6615 setenv function.
6616
d5617611
CY
6617 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6618 the font entity extracted from the cache (Bug#8109).
6619
58872834
CY
66202011-08-07 Chong Yidong <cyd@stupidchicken.com>
6621
6622 * composite.c (autocmp_chars): Don't reset point. That is done by
6623 restore_point_unwind (Bug#5984).
6624
75bfc667
JL
66252011-08-07 Juri Linkov <juri@jurta.org>
6626
6627 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6628 to show the arg `TIME' instead of `TIMEVAL'.
6629
d1410150
EZ
66302011-08-06 Eli Zaretskii <eliz@gnu.org>
6631
6632 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6633 display property strides EOL and includes a newline, as in
6634 longlines-mode. (Bug#9254)
75b771e4
EZ
6635 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6636 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6637
6638 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6639 is non-zero, even if the data buffer is NULL. Fixes a crash in
6640 vertical-motion with longlines-mode. (Bug#9254)
6641
35928349
EZ
66422011-08-05 Eli Zaretskii <eliz@gnu.org>
6643
ec7cc85b
EZ
6644 * bidi.c <bidi_cache_total_alloc>: Now static.
6645 (bidi_initialize): Initialize bidi_cache_total_alloc.
6646
8b76d6f8 6647 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6648 cache. (Bug#9221)
6649
6650 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6651 amount allocated this far in `bidi_cache_total_alloc'.
6652 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6653 non-zero, only free the data buffer without restoring the cache
6654 contents. All callers changed.
6655
6656 * dispextern.h (bidi_unshelve_cache): Update prototype.
6657
6658 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6659 (move_it_in_display_line, move_it_to)
6660 (move_it_vertically_backward, move_it_by_lines): Replace the call
6661 to xfree to an equivalent call to bidi_unshelve_cache.
6662 (move_it_in_display_line_to): Fix logic of returning
412b6358 6663 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6664
e2e2423b
EZ
66652011-08-05 Eli Zaretskii <eliz@gnu.org>
6666
6667 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6668 came from a string character with a `cursor' property. (Bug#9229)
6669
ae9e757a
JD
66702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6671
6672 * Makefile.in (LIB_PTHREAD): New variable.
6673 (LIBES): Add LIB_PTHREAD (Bug#9216).
6674
6675 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6676 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6677
213bd7f2
AS
66782011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6679
6b02f655 6680 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6681
99aaf75f
JD
66822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6683
6684 * xterm.c (x_find_topmost_parent): New function.
6685 (x_set_frame_alpha): Find topmost parent window with
6686 x_find_topmost_parent and set the property there also (bug#9181).
6687 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6688
c74e9d86
PE
66892011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6690
6691 * callproc.c (Fcall_process): Avoid vfork clobbering
6692 the local vars buffer, coding_systems, current_dir.
6693
640c8776
SM
66942011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6695
6696 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6697
f26d0e4c
PE
66982011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6699
8a10d76c
PE
6700 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6701 so that it is not optimized away.
6702
f26d0e4c
PE
6703 * xdisp.c (compute_display_string_pos): Remove unused local.
6704
55439c61
EZ
67052011-08-02 Eli Zaretskii <eliz@gnu.org>
6706
6707 Fix slow cursor motion and scrolling in large buffers with
6708 selective display, like Org Mode buffers. (Bug#9218)
6709
6710 * dispextern.h (struct bidi_it): New member disp_prop_p.
6711
6712 * xdisp.c: Remove one-slot cache of display string positions.
6713 (compute_display_string_pos): Accept an additional argument
5e617bc2 6714 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6715 for a display string or property. If found, set DISP_PROP_P
6716 non-zero.
6717
6718 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6719 DISP_PROP_P, and pass it to compute_display_string_pos.
6720 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6721 non-zero. All callers of bidi_fetch_char changed.
6722
fb33fa43
SM
67232011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6724
6725 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6726
b099e063
DM
67272010-12-03 Don March <don@ohspite.net>
6728
6729 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6730 last character M-[char] is translated to ESC [char] (bug#7541).
6731
5cc7f7af
KH
67322011-08-02 Kenichi Handa <handa@m17n.org>
6733
d0fffa3f 6734 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6735
6736 * chartab.c (uniprop_table): Make it non-static.
6737
525d5e6e
EZ
67382011-08-01 Eli Zaretskii <eliz@gnu.org>
6739
6740 * xdisp.c (forward_to_next_line_start): Accept additional argument
6741 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6742 on the newline.
6743 (reseat_at_next_visible_line_start): Use the bidi iterator state
6744 returned by forward_to_next_line_start to restore the state of
6745 it->bidi_it after backing up to previous newline. (Bug#9212)
6746
31011111
AS
67472011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6748
6749 * regex.c (re_comp): Protoize.
6750 (re_exec): Fix return type.
6751 (regexec): Fix type of `ret'. (Bug#9203)
6752
476371c4
PE
67532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6754
e5d76069
PE
6755 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6756 This is needed if max-image-size is a floating-point number.
6757
9a79b20c
AS
67582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6759
6760 * print.c (print_object): Print empty symbol as ##.
6761
6762 * lread.c (read1): Read ## as empty symbol.
6763
d8c2fa78
AA
67642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6765
6766 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6767 setting frame foreground color (Bug#9175).
6768 (x_set_background_color): Likewise.
6769
ffe57a7a
AA
6770 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6771 contents (Bug#9176).
6772 (EmacsTooltip -init): Remove bezels and add shadows to
6773 tooltip windows.
6774
bf3492a5
AA
6775 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6776 or scroll bar (Bug#8470).
6777
d55e9c53
AA
6778 * nsfont.m (nsfont_open): Remove assignment to voffset and
6779 unnecessary vars hshink, expand, hd, full_height, min_height.
6780 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6781
6782 * nsterm.h (nsfont_info): Remove voffset field.
6783
d8c2fa78 67842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6785
6786 Implement strike-through and overline on NextStep (Bug#8863).
6787
6788 * nsfont.m (nsfont_open): Use underline position provided by font,
6789 instead of hard-coded value of 2.
6790 (nsfont_draw): Call ns_draw_text_decoration instead.
6791
6792 * nsterm.h: Add declaration for ns_draw_text_decoration.
6793
6794 * nsterm.m (ns_draw_text_decoration): New function for drawing
6795 underline, overline, and strike-through.
6796 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6797 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6798 accommodate underlining, etc.
4843aac3 6799
4cc60b9b
EZ
68002011-07-28 Eli Zaretskii <eliz@gnu.org>
6801
bc7ece87
EZ
6802 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6803 default.
4cc60b9b 6804
476371c4
PE
68052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6806
66606eea
PE
6807 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6808 Without this fix, if a signal arrives just after memory fills up,
6809 'malloc' might be invoked reentrantly.
6810
476371c4
PE
6811 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6812 In other words, assume that every image size is allowed, on non-X
6813 hosts. This assumption is probably wrong, but it lets Emacs compile.
6814
f3fcc40d
AS
68152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6816
6817 * regex.c (re_iswctype): Convert return values to boolean.
6818
350c992f
EZ
68192011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6820
6821 * xdisp.c (compute_display_string_pos): Don't use cached display
6822 string position if the buffer had its restriction changed.
6823 (Bug#9184)
6824
5266b4bb
PE
68252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6826
6827 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6828
2573a837 68292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6830
41f55ccd 6831 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6832
39e378da
PE
6833 * bidi.c: Integer size and overflow fixes.
6834 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6835 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6836 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6837 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6838 (bidi_find_other_level_edge):
6839 Use ptrdiff_t instead of EMACS_INT where either will do.
6840 This works better on 32-bit hosts configured --with-wide-int.
6841 (bidi_cache_ensure_space): Check for size-calculation overflow.
6842 Use % rather than repeated addition, for better worst-case speed.
6843 Don't set bidi_cache_size until after xrealloc returns, because it
6844 might not return.
6845 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6846 (bidi_cache_ensure_space): Also check that the bidi cache size
6847 does not exceed that of the largest Lisp string or buffer. See Eli
6848 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6849
5e927815
PE
6850 * alloc.c (__malloc_size_t): Remove.
6851 All uses replaced by size_t. See Andreas Schwab's note
6852 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6853
ca4aa935
PE
6854 * image.c: Improve checking for integer overflow.
6855 (check_image_size): Assume that f is nonnull, since
6856 it is always nonnull in practice. This is one less thing to
6857 worry about when checking for integer overflow later.
6858 (x_check_image_size): New function, which checks for integer
6859 overflow issues inside X.
6860 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6861 This removes the need for a memory_full check.
6862 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6863 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6864 (xbm_read_bitmap_data): Change locals back to 'int', since
6865 their values must fit in 'int'.
6866 (xpm_load_image, png_load, tiff_load):
6867 Invoke x_create_x_image_and_pixmap earlier,
6868 to avoid much needless work if the image is too large.
6869 (tiff_load): Treat overly large images as if
6870 x_create_x_image_and_pixmap failed, not as malloc failures.
6871 (gs_load): Use x_check_image_size.
6872
5f8f9cc2
PE
6873 * gtkutil.c: Omit integer casts.
6874 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6875 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6876
5adf60bc
PE
6877 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6878
c8907a93
PE
6879 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6880 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6881 would wrongly return t on a 64-bit host.
6882
e3c25c68
PE
6883 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6884 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6885 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6886 and therefore cause GCC to emit a bogus diagnostic in some cases.
6887
3f791afe
PE
6888 * image.c: Integer signedness and overflow and related fixes.
6889 This is not an exhaustive set of fixes, but it's time to
6890 record what I've got.
6891 (lookup_pixel_color, check_image_size): Remove redundant decls.
6892 (check_image_size): Don't assume that arbitrary EMACS_INT values
6893 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6894 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6895 (tiff_load, imagemagick_load_image):
6896 Check for overflow in size calculations.
6897 (x_create_x_image_and_pixmap): Remove unnecessary test for
6898 xmalloc returning NULL; that can't happen.
6899 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6900 (xpm_color_bucket): Use better integer hashing function.
6901 (xpm_cache_color): Don't possibly over-allocate memory.
6902 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6903 (gif_memory_source):
6904 Use ptrdiff_t, not int or size_t, to record sizes.
6905 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6906 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6907 either works, as we prefer signed integers.
6908 (tiff_read_from_memory, tiff_write_from_memory):
6909 Return tsize_t, not size_t, since that's what the TIFF API wants.
6910 (tiff_read_from_memory): Don't fail simply because the read would
6911 go past EOF; instead, return a short read.
6912 (tiff_load): Omit no-longer-needed casts.
6913 (Fimagemagick_types): Don't assume size fits into 'int'.
6914
3cc5a532
PE
6915 Improve hashing quality when configured --with-wide-int.
6916 * fns.c (hash_string): New function, taken from sxhash_string.
6917 Do not discard information about ASCII character case; this
6918 discarding is no longer needed.
6919 (sxhash-string): Use it. Change sig to match it. Caller changed.
6920 * lisp.h: Declare it.
6921 * lread.c (hash_string): Remove, since we now use fns.c's version.
6922 The fns.c version returns a wider integer if --with-wide-int is
6923 specified, so this should help the quality of the hashing a bit.
6924
b312a492
PE
6925 * emacs.c: Integer overflow minor fix.
6926 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6927 Define only if GNU_LINUX.
6928 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6929
dfd153ae
PE
6930 * dispnew.c: Integer signedness and overflow fixes.
6931 Remove unnecessary forward decls, that were a maintenance hassle.
6932 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6933 All uses changed.
6934 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6935 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6936 (prepare_desired_row, line_draw_cost):
6937 Use int, not unsigned, where either works.
6938 (save_current_matrix, restore_current_matrix):
6939 Use ptrdiff_t, not size_t, where either works.
6940 (init_display): Check for overflow more accurately, and without
6941 relying on undefined behavior.
6942
a81d11a3
PE
6943 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6944 Remove, replacing with the new symbols in lisp.h. All uses changed.
6945 * fileio.c (make_temp_name):
6946 * filelock.c (lock_file_1, lock_file):
6947 * xdisp.c (message_dolog):
6948 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6949 Use pMd etc. instead.
6950 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6951 replacing the pWIDE etc. symbols removed from editfns.c.
6952
3300e6fd
PE
6953 * keyboard.h (num_input_events): Now uintmax_t.
6954 This is (very slightly) less likely to mess up due to wraparound.
6955 All uses changed.
6956
fd05c7e9
PE
6957 * buffer.c: Integer signedness fixes.
6958 (alloc_buffer_text, enlarge_buffer_text):
6959 Use ptrdiff_t rather than size_t when either will do, as we prefer
6960 signed integers.
6961
903fe15d
PE
6962 * alloc.c: Integer signedness and overflow fixes.
6963 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6964 (__malloc_size_t): Default to size_t, not to int.
6965 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6966 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6967 Prefer ptrdiff_t to size_t when either would do, as we prefer
6968 signed integers.
6969 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6970 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6971 Now const. Initialize with values that are in range even if char
6972 is signed.
6973 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6974 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6975 These functions do the right thing with sizes > 2**32.
6976 (check_depth): Now ptrdiff_t, not int.
6977 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6978 Adjust to new way of storing sizes. Check for size overflow bugs
6979 in rest of code.
6980 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6981 slightly wrong anyway, as it missed one instance of
6982 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6983 (refill_memory_reserve): Omit needless cast to size_t.
6984 (mark_object_loop_halt): Mark as externally visible.
6985
ac82cc6a
PE
6986 * xselect.c: Integer signedness and overflow fixes.
6987 (Fx_register_dnd_atom, x_handle_dnd_message):
6988 Use ptrdiff_t, not size_t, since we prefer signed.
6989 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6990 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6991 x_dnd_atoms_size and x_dnd_atoms_length.
6992
c2d1e36d
PE
6993 * doprnt.c: Prefer signed to unsigned when either works.
6994 * eval.c (verror):
6995 * doprnt.c (doprnt):
6996 * lisp.h (doprnt):
6997 * xdisp.c (vmessage):
6998 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6999 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7000 prefer signed arithmetic to avoid comparison confusion.
7001 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7002 but is a bit tricky.
7003
0e926e56
PE
7004 Assume freestanding C89 headers, string.h, stdlib.h.
7005 * data.c, doprnt.c, floatfns.c, print.c:
7006 Include float.h unconditionally.
7007 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7008 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7009 * regex.c: Likewise for stddef.h, string.h.
7010 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7011 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7012 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7013 (STDC_HEADERS): Remove obsolete defines.
7014 * sysdep.c: Include limits.h unconditionally.
7015
9cfdb3ec
PE
7016 Assume support for memcmp, memcpy, memmove, memset.
7017 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7018 * regex.c (memcmp, memcpy):
7019 Remove; we assume C89 now.
7020
7021 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7022 (__malloc_safe_bcopy): Remove; no longer needed.
7023
cf950e6b 7024 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7025 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7026 well either way, and we prefer signed to unsigned.
7027
dbf38e02
LMI
70282011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7029
7030 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7031 closes the connection while we're reading (bug#9182).
7032
d6f0886c 70332011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7034
d6f0886c
JD
7035 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7036 are specified (Bug#9168).
24e0f6b1 7037
2eb1f9e6
PE
70382011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7039
7040 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7041 Found by GCC static checking and --with-wide-int on a 32-bit host.
7042
22381272 70432011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7044
7045 * xdisp.c (compute_display_string_pos): Fix logic of caching
7046 previous display string position. Initialize cached_prev_pos to
7047 -1. Fixes slow-down at the beginning of a buffer.
7048
f25e39b4
EZ
70492011-07-24 Eli Zaretskii <eliz@gnu.org>
7050
7051 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7052 for attrs[LFACE_FONTSET_INDEX].
7053
04c4b52e
PE
70542011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7055
7056 * xml.c (parse_region): Remove unused local
7057 that was recently introduced.
7058
c1734fbd
EZ
70592011-07-23 Eli Zaretskii <eliz@gnu.org>
7060
be18c5a5
EZ
7061 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7062 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7063
c1734fbd
EZ
7064 * xdisp.c (move_it_in_display_line_to): Record the best matching
7065 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7066 exit if none of the characters scanned was an exact match.
7067 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7068 when exact match is impossible due to invisible text, and the
7069 lines are truncated.
7070
a258d627
JD
70712011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7072
7073 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7074 for OSX >= 10.7.
7075
b6d5a689
EZ
70762011-07-22 Eli Zaretskii <eliz@gnu.org>
7077
0f74f785
EZ
7078 Fix a significant slow-down of cursor motion with C-n, C-p,
7079 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7080 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7081 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7082 (next_element_from_buffer): Call compute_stop_pos_backwards to
7083 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7084 base_level_stop.
7085 (reseat): Don't look for prev_stop, as that could mean a very long
7086 run.
7087 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7088 <cached_disp_overlay_modiff>: Cache for last found display string
7089 position.
551918c1 7090 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7091 about the same buffer in the same area of character positions, and
7092 the buffer wasn't changed since the time the display string
7093 position was cached.
551918c1 7094
b2d0c91a
EZ
70952011-07-22 Eli Zaretskii <eliz@gnu.org>
7096
7097 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7098 is an integer, which is important for empty lines. (Bug#9149)
7099
043604ee
CY
71002011-07-22 Chong Yidong <cyd@stupidchicken.com>
7101
7102 * frame.c (Fmodify_frame_parameters): In tty case, update the
7103 default face if necessary (Bug#4238).
7104
da4adb04
CY
71052011-07-21 Chong Yidong <cyd@stupidchicken.com>
7106
7107 * editfns.c (Fstring_to_char): No need to explain what a character
7108 is in the docstring (Bug#6576).
7109
9abd0532
LMI
71102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7111
7112 * xml.c (parse_region): Make sure we always return a tree.
7113
36881d16
HK
71142011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7115
7116 * xml.c (parse_region): If a document contains only comments,
7117 return that, too.
7118
1e98674d
LMI
71192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7120
7121 * xml.c (make_dom): Return comments, too.
7122
590bd467
PE
71232011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7124
7125 Port to OpenBSD.
7126 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7127 and the surrounding thread.
7128 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7129 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7130 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7131 timer goes off.
7132 * s/openbsd.h (BROKEN_SIGIO): Define.
7133 * unexelf.c (unexec) [__OpenBSD__]:
7134 Don't update the .mdebug section of the Alpha COFF symbol table.
7135
f41628b2
LMI
71362011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7137
7138 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7139 (bug#8460).
7140
b59b67c5
PE
71412011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7142
15e3a074
PE
7143 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7144 This fixes some race conditions on the permissions of any newly
7145 created file.
7146
41bed37d
PE
7147 * alloc.c (valid_pointer_p): Use pipe, not open.
7148 This fixes some permissions issues when debugging.
7149
b59b67c5
PE
7150 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7151 If fchown fails to set both uid and gid, try to set just gid,
7152 as that is sometimes allowed. Adjust the file's mode to eliminate
7153 setuid or setgid bits that are inappropriate if fchown fails.
7154
925a6be7
SM
71552011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7156
7157 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7158 to compare Lisp_Objects.
7159 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7160 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7161 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7162
52968808
AS
71632011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7164
0a6a104b
AS
7165 * lread.c (read_integer): Unread even EOF character.
7166 (read1): Likewise. Properly record start position of symbol.
7167
52968808
AS
7168 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7169 symbol character follows.
7170
9e381cdd
PE
71712011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7172
7173 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7174 This works around a problem with the previous change to Fcopy_file.
7175 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7176 and without this change, GCC might complain about discarding
7177 fchown's return value.
7178
b5641435
JB
71792011-07-16 Juanma Barranquero <lekktu@gmail.com>
7180
7181 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7182
a8031457
PE
71832011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7184
7185 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7186
dd889327
LMI
71872011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7188
750c33f7
LMI
7189 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7190 it's used from the C level.
7191
dd889327
LMI
7192 * process.c: Use the same condition for POLL_FOR_INPUT in both
7193 keyboard.c and process.c (bug#1858).
7194
87e86684
LM
71952011-07-09 Lawrence Mitchell <wence@gmx.li>
7196
7197 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7198 (Fgnutls_boot): Use it.
7199
64348f40
AS
72002011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7201
7202 * doc.c (Fsubstitute_command_keys): Revert last change.
7203
1d698799
LMI
72042011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7205
f863868c
LMI
7206 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7207 quotes the next character, and doesn't affect other longer
7208 sequences (bug#8935).
7209
1d698799
LMI
7210 * lread.c (syms_of_lread): Clarify that is isn't only
7211 `eval-buffer' and `eval-defun' that's affected by
7212 `lexical-binding' (bug#8460).
7213
aa4b6df6
EZ
72142011-07-15 Eli Zaretskii <eliz@gnu.org>
7215
7216 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7217 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7218
5d856da6
PE
72192011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7220
ad6042bb
PE
7221 Fix minor problems found by static checking.
7222 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7223 (elsz): Now a signed constant, not a size_t var. We prefer signed
7224 types to unsigned, to avoid integer comparison confusion. Without
7225 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7226 "cannot optimize loop, the loop counter may overflow", a symptom
7227 of the confusion.
f00bbb22 7228 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7229 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7230
6468f31c
LMI
72312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7232
49080b10
LMI
7233 * search.c (Fre_search_backward): Mention `case-fold-search' in
7234 all the re_search_* functions (bug#8138).
7235
6468f31c
LMI
7236 * keyboard.c (Fopen_dribble_file): Document when the file is
7237 closed (bug#8056).
7238
c965adc5
EZ
72392011-07-14 Eli Zaretskii <eliz@gnu.org>
7240
df9733bf
EZ
7241 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7242 bidi_cache_idx.
7243
0bb23927
EZ
7244 Support bidi reordering of display and overlay strings.
7245 * xdisp.c (compute_display_string_pos)
7246 (compute_display_string_end): Accept additional argument STRING.
7247 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7248 (reseat_to_string): Initialize bidi_it->string.s and
7249 bidi_it->string.schars.
7250 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7251 NULL (avoids a crash in bidi_paragraph_init).
7252 Initialize itb.string.lstring.
0bb23927
EZ
7253 (init_iterator): Call bidi_init_it only of a valid
7254 buffer position was specified. Initialize paragraph_embedding to
7255 L2R.
7256 (reseat_to_string): Initialize the bidi iterator.
7257 (display_string): If we need to ignore text properties of
7258 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7259 original value of -1 will not work with bidi.)
7260 (compute_display_string_pos): First arg is now struct
7261 `text_pos *'; all callers changed. Support display properties on
7262 Lisp strings.
7263 (compute_display_string_end): Support display properties on Lisp
7264 strings.
7265 (init_iterator, reseat_1, reseat_to_string): Initialize the
7266 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7267 when iterating on a string not from display properties).
640c8776
SM
7268 (compute_display_string_pos, compute_display_string_end):
7269 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7270 arrow keys.
7271 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7272 base_level_stop; instead, set base_level_stop to BEGV.
7273 Fixes crashes in vertical-motion.
0bb23927
EZ
7274 (next_element_from_buffer): Improve commentary for when
7275 the iterator is before prev_stop.
7276 (init_iterator): Initialize bidi_p from the default value of
7277 bidi-display-reordering, not from buffer-local value. Use the
7278 buffer-local value only if initializing for buffer iteration.
7279 (handle_invisible_prop): Support invisible properties on strings
7280 that are being bidi-reordered.
7281 (set_iterator_to_next): Support bidi reordering of C strings and
7282 Lisp strings.
7283 (next_element_from_string): Support bidi reordering of Lisp
7284 strings.
7285 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7286 (display_string): Support display of R2L glyph rows.
7287 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7288 (init_iterator): Don't initialize it->bidi_p for strings
7289 here.
7290 (reseat_to_string): Initialize it->bidi_p for strings here.
7291 (next_element_from_string, next_element_from_c_string)
7292 (next_element_from_buffer): Add xassert's for correspondence
7293 between IT's object being iterated and it->bidi_it.string
7294 structure.
7295 (face_before_or_after_it_pos): Support bidi iteration.
7296 (next_element_from_c_string): Handle the case of the first string
7297 character that is not the first one in the visual order.
7298 (get_visually_first_element): New function, refactored from common
7299 parts of next_element_from_buffer, next_element_from_string, and
7300 next_element_from_c_string.
7301 (tool_bar_lines_needed, redisplay_tool_bar)
7302 (display_menu_bar): Force left-to-right direction. Add a FIXME
7303 comment for making that be controlled by a user option.
7304 (push_it, pop_it): Save and restore the state of the
7305 bidi iterator. Save and restore the bidi_p flag.
7306 (pop_it): Iterate out of display property for string iteration as
7307 well.
7308 (iterate_out_of_display_property): Support iteration over strings.
7309 (handle_single_display_spec): Set up it->bidi_it for iteration
7310 over a display string, and call bidi_init_it.
7311 (handle_single_display_spec, next_overlay_string)
7312 (get_overlay_strings_1, push_display_prop): Set up the bidi
7313 iterator for displaying display or overlay strings.
7314 (forward_to_next_line_start): Don't use the shortcut if
7315 bidi-iterating.
7316 (back_to_previous_visible_line_start): If handle_display_prop
7317 pushed the iterator stack, restore the internal state of the bidi
7318 iterator by calling bidi_pop_it same number of times.
7319 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7320 and we are bidi-iterating, don't decrement the iterator position;
7321 instead, set the first_elt flag in the bidi iterator, to produce
7322 the same effect.
7323 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7324 (push_display_prop): xassert that we are iterating a buffer.
7325 (push_it, pop_it): Save and restore paragraph_embedding member.
7326 (handle_single_display_spec, next_overlay_string)
7327 (get_overlay_strings_1, reseat_1, reseat_to_string)
7328 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7329 correctly. Don't assume unibyte strings are not bidi-reordered.
7330 (compute_display_string_pos)
7331 (compute_display_string_end): Fix handling the case of C string.
7332 (push_it, pop_it): Save and restore from_disp_prop_p.
7333 (handle_single_display_spec, push_display_prop): Set the
7334 from_disp_prop_p flag.
7335 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7336 (pop_it): Call iterate_out_of_display_property only if we are
7337 popping after iteration over a string that came from a display
7338 property. Fix a typo in popping stretch info. Add an assertion
7339 for verifying that the iterator position is in sync with the bidi
7340 iterator.
7341 (handle_single_display_spec, get_overlay_strings_1)
7342 (push_display_prop): Fix initialization of paragraph direction for
7343 string when that of the parent object is not yet determined.
7344 (reseat_1): Call bidi_init_it to resync the bidi
7345 iterator with IT's position. (Bug#7616)
7346 (find_row_edges): If ROW->start.pos gives position
7347 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7348 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7349 Reset the from_disp_prop_p flag.
7350 (SAVE_IT, RESTORE_IT): New macros.
7351 (pos_visible_p, face_before_or_after_it_pos)
7352 (back_to_previous_visible_line_start)
7353 (move_it_in_display_line_to, move_it_in_display_line)
7354 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7355 (try_scrolling, redisplay_window, display_line): Use them when
7356 saving a temporary copy of the iterator and restoring it back.
7357 (back_to_previous_visible_line_start, reseat_1)
7358 (init_iterator): Empty the bidi cache "stack".
7359 (move_it_in_display_line_to): If iterator ended up at
7360 EOL, but we never saw any buffer positions smaller than
7361 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7362 motion in bidi-reordered lines.
7363 (move_it_in_display_line_to): Record prev_method and prev_pos
7364 immediately before the call to set_iterator_to_next. Fixes cursor
7365 motion in bidi-reordered lines with stretch glyphs and strings
7366 displayed in margins. (Bug#8133) (Bug#8867)
7367 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7368 TO_CHARPOS.
640c8776
SM
7369 (pos_visible_p): Support positions in bidi-reordered lines.
7370 Save and restore bidi cache.
0bb23927
EZ
7371
7372 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7373 (bidi_paragraph_info): Delete unused struct.
7374 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7375 (bidi_cache_start): New variable.
7376 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7377 to zero.
7378 (bidi_cache_fetch_state, bidi_cache_search)
7379 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7380 (bidi_cache_find, bidi_peek_at_next_level)
7381 (bidi_level_of_next_char, bidi_find_other_level_edge)
7382 (bidi_move_to_visually_next): Compare cache index with
7383 bidi_cache_start rather than with zero.
7384 (bidi_fetch_char): Accept new argument STRING; all callers
7385 changed. Support iteration over a string. Support strings with
7386 display properties. Support unibyte strings. Fix the type of
7387 `len' according to what STRING_CHAR_AND_LENGTH expects.
7388 (bidi_paragraph_init, bidi_resolve_explicit_1)
7389 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7390 (bidi_level_of_next_char, bidi_move_to_visually_next):
7391 Support iteration over a string.
0bb23927
EZ
7392 (bidi_set_sor_type, bidi_resolve_explicit_1)
7393 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7394 can now be zero (for strings); special values 0 and -1 were
7395 changed to -1 and -2, respectively.
7396 (bidi_char_at_pos): New function.
7397 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7398 Call it instead of FETCH_MULTIBYTE_CHAR.
7399 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7400 initialized to valid values.
7401 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7402 values.
7403 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7404 the test for valid cached positions. Fix the logic for looking up
7405 the sentinel state in the cache. GCPRO the Lisp string we are
7406 iterating.
7407 (bidi_push_it, bidi_pop_it): New functions.
7408 (bidi_initialize): Initialize the bidi cache start stack pointer.
7409 (bidi_cache_ensure_space): New function, refactored from part of
7410 bidi_cache_iterator_state. Don't assume the required size is just
7411 one BIDI_CACHE_CHUNK away.
7412 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7413 (bidi_count_bytes, bidi_char_at_pos): New functions.
7414 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7415 always valid if bidi_cache_idx is valid.
7416 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7417 is valid if it's going to be used.
7418 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7419 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7420 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7421 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7422 (bidi_find_other_level_edge, bidi_cache_start_stack):
7423 All variables related to cache indices are now EMACS_INT.
c965adc5 7424
0bb23927
EZ
7425 * dispextern.h (struct bidi_string_data): New structure.
7426 (struct bidi_it): New member `string'. Make flag members be 1-bit
7427 fields, and put them last in the struct.
640c8776
SM
7428 (compute_display_string_pos, compute_display_string_end):
7429 Update prototypes.
0bb23927
EZ
7430 (bidi_push_it, bidi_pop_it): Add prototypes.
7431 (struct iterator_stack_entry): New members bidi_p,
7432 paragraph_embedding, and from_disp_prop_p.
7433 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7434 (bidi_shelve_cache, bidi_unshelve_cache):
7435 Declare prototypes.
0bb23927
EZ
7436
7437 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7438 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7439 and vector-like objects.
7440
7441 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7442 cache around display iteration.
7443
7444 * window.c (Fwindow_end, window_scroll_pixel_based)
7445 (displayed_window_lines, Frecenter): Save and restore the bidi
7446 cache around display iteration.
7447
3bbd2265
LMI
74482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7449
7450 * editfns.c (Fdelete_region): Clarify the use of the named
7451 parameters (bug#6788).
7452
adc47434
MR
74532011-07-14 Martin Rudalics <rudalics@gmx.at>
7454
7455 * indent.c (Fvertical_motion): Set and restore w->pointm when
7456 saving and restoring the window's buffer (Bug#9006).
7457
837c31f8
LMI
74582011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7459
7460 * editfns.c (Fstring_to_char): Clarify just what is returned
7461 (bug#6576). Text by Eli Zaretskii.
7462
ac389d0c
JB
74632011-07-13 Juanma Barranquero <lekktu@gmail.com>
7464
7465 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7466
0be0ce47
EZ
74672011-07-13 Eli Zaretskii <eliz@gnu.org>
7468
7469 * buffer.c (mmap_find): Fix a typo.
7470
cd18e7e3
JB
74712011-07-13 Johan Bockgård <bojohan@gnu.org>
7472
7473 Fix execution of x selection hooks.
7474 * xselect.c (Qx_lost_selection_functions)
7475 (Qx_sent_selection_functions): New vars.
7476 (syms_of_xselect): DEFSYM them.
7477 (x_handle_selection_request): Pass Qx_sent_selection_functions
7478 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7479 (x_handle_selection_clear,x_clear_frame_selections):
7480 Pass Qx_lost_selection_functions rather than
7481 Vx_lost_selection_functions to Frun_hook_with_args.
7482
47ea7f44
PE
74832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7484
ac389d0c 7485 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7486 The old code sometimes used this field without initializing it.
7487
47ea7f44
PE
7488 * alloc.c (gc_sweep): Don't read past end of array.
7489 In theory, the old code could also have corrupted Emacs internals,
7490 though it'd be very unlikely.
7491
bc985c87
AS
74922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7493
7494 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7495 argument. (Bug#4026)
bc985c87 7496
0cf34688
LMI
74972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7498
b3dadd76
LMI
7499 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7500 key" (bug#4257).
7501
0cf34688
LMI
7502 * window.c (Fset_window_start): Doc fix (bug#4199).
7503 (Fset_window_hscroll): Ditto.
7504
270768cd
PE
75052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7506
077e3dda 7507 Fix minor new problems caught by GCC 4.6.1.
270768cd 7508 * term.c (init_tty): Remove unused local.
490011a6 7509 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7510 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7511 not used otherwise.
270768cd 7512
b1f58454
CY
75132011-07-12 Chong Yidong <cyd@stupidchicken.com>
7514
7515 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7516
22b9578d
LMI
75172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7518
6e70ab07
LMI
7519 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7520 are the mini-buffer and the echo area (bug#3320).
7521
22b9578d
LMI
7522 * term.c (init_tty): Remove support for supdup, c10 and perq
7523 terminals, which are no longer supported (bug#1482).
7524
8974cc9f
JB
75252011-07-10 Johan Bockgård <bojohan@gnu.org>
7526
7527 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7528
a560d974
JD
75292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7530
7531 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7532 for non-popups (Bug#3642).
7533
1dae0f0a
AS
75342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7535
268c2c36 7536 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7537 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7538 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7539 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7540 * data.c (fmod): Likewise.
7541 * dispnew.c (swap_glyphs_in_rows): Likewise.
7542 * emacs.c (memory_warning_signal): Likewise.
7543 * floatfns.c (float_error): Likewise.
7544 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7545 (otf_open, font_otf_capability, generate_otf_features)
7546 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7547 Likewise.
7548 * image.c (pbm_read_file): Likewise.
7549 * indent.c (string_display_width): Likewise.
7550 * intervals.c (check_for_interval, search_for_interval)
7551 (inc_interval_count, count_intervals, root_interval)
7552 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7553 * lread.c (defalias): Likewise.
268c2c36 7554 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7555 * regex.c (set_image_of_range_1, set_image_of_range)
7556 (regex_grow_registers): Likewise.
7557 * sysdep.c (strerror): Likewise.
7558 * termcap.c (valid_filename_p, tprint, main): Likewise.
7559 * tparam.c (main): Likewise.
7560 * unexhp9k800.c (run_time_remap, save_data_space)
7561 (update_file_ptrs, read_header, write_header, calculate_checksum)
7562 (copy_file, copy_rest, display_header): Likewise.
7563 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7564 Likewise.
7565 * xdisp.c (check_it): Likewise.
7566 * xfaces.c (register_color, unregister_color, unregister_colors):
7567 Likewise.
7568 * xfns.c (print_fontset_result): Likewise.
7569 * xrdb.c (member, fatal, main): Likewise.
7570
99033785
PE
75712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7572
7573 Fix minor problems found by static checking (Bug#9031).
7574 * chartab.c (char_table_set_range, map_sub_char_table):
7575 Remove unused locals.
7576 (uniprop_table): Now static.
7577 * composite.c (_work_char): Remove unused static var.
7578
9cb2ac56
JB
75792011-07-09 Juanma Barranquero <lekktu@gmail.com>
7580
7581 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7582
f25661f0
JD
75832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7584
7585 * gtkutil.c (qttip_cb): Remove code without function.
7586
8278c4fe
EZ
75872011-07-09 Eli Zaretskii <eliz@gnu.org>
7588
7589 * w32.c (pthread_sigmask): New stub.
7590
1692ae2d 75912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7592
8a6ebd58 7593 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7594 sigprocmask is portable only for single-threaded applications, and
7595 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7596 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7597 (LIBES): Use it.
7598 * callproc.c (Fcall_process):
7599 * process.c (create_process):
7600 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7601 Use pthread_sigmask, not sigprocmask.
123403e4 7602
1b854618
JD
76032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7604
7605 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7606 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7607 wrong (Bug#8591).
7608
3fe4b549
JD
76092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7610
0ce7e563
JD
7611 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7612 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7613 (xg_hide_tooltip): Fix comment.
7614
3fe4b549
JD
7615 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7616 in registerServicesMenuSendTypes.
7617 (validRequestorForSendType): Don't check ns_return_types.
7618
7619 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7620 ns_return_type.
7621
5df75e47
JR
76222011-07-08 Jason Rumney <jasonr@gnu.org>
7623
22610910
JR
7624 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7625 SH_SHOW for hidden windows (Bug#5482).
7626
5df75e47
JR
7627 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7628 frame struct members of non-existent frames (Bug#6284).
7629
699c10bd
JD
76302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7631
4393663b
JD
7632 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7633 variable firstTime not needed on OSX >= 10.6.
7634 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7635 >= 10.5. Use setKnobProportion, setDoubleValue.
7636
7637 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7638 (MAC_OS_X_VERSION_10_5): Define if not defined.
7639 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7640 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7641 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7642
7643 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7644 cString and lossyCString on OSX >= 10.4
7645
58179cce 7646 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7647 sizeToFit on OSX >= 10.2.
7648
7649 * nsimage.m (allocInitFromFile): Don't use deprecated method
7650 bestRepresentationForDevice on OSX >= 10.6.
7651
7652 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7653 to avoid warning.
7654
7655 * emacs.c: Declare unexec_init_emacs_zone.
7656
a63e0781
JD
7657 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7658
699c10bd
JD
7659 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7660
7661 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7662 on svcsMenu (Bug#8842).
7663
7664 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7665 ns_return_types.
7666 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7667
7668 * nsterm.m (QUTF8_STRING): Declare.
7669 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7670 (validRequestorForSendType): Return type is (id).
7671 Change indexOfObjectIdenticalTo to indexOfObject.
7672 Check if we have local selection before returning self (Bug#8842).
7673 (writeSelectionToPasteboard): Put local selection into paste board
7674 if we have a local selection (Bug#8842).
7675 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7676
7677 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7678 (ns_get_local_selection): Declare.
7679
54e10184
LMI
76802011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7681
9888ff71
LMI
7682 * keymap.c (describe_map_tree): Don't insert a double newline at
7683 the end of the buffer (bug#1169) and return whether we inserted
7684 something.
7685
54e10184
LMI
7686 * callint.c (Fcall_interactively): Change "reading args" to
7687 "providing args" to try to clarify what it does (bug#1010).
7688
15fa4783
KH
76892011-07-07 Kenichi Handa <handa@m17n.org>
7690
7691 * composite.c (composition_compute_stop_pos): Ignore a static
7692 composition starting before CHARPOS (Bug#8915).
7693
7694 * xdisp.c (handle_composition_prop): Likewise.
7695
a8815b00
EZ
76962011-07-07 Eli Zaretskii <eliz@gnu.org>
7697
7698 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7699 (Bug#9015)
7700
ef7b981d 77012011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7702
7703 * character.h (unicode_category_t): New enum type.
7704
7705 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7706 (Qchar_code_property_table): New variable.
7707 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7708 (UNIPROP_COMPRESSED_FORM_P): New macros.
7709 (char_table_ascii): Uncompress the compressed values.
7710 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7711 Uncompress the compressed values.
ac389d0c 7712 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7713 (char_table_ref_and_range): Uncompress the compressed values.
7714 (sub_char_table_set): New arg is_uniprop. Callers changed.
7715 Uncompress the compressed values.
7716 (sub_char_table_set_range): Args changed. Callers changed.
7717 (char_table_set_range): Adjuted for the above change.
7718 (map_sub_char_table): Delete args default_val and parent. Add arg
7719 top. Give decoded values to a Lisp function.
640c8776 7720 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7721 values to a Lisp function. Gcpro more variables.
7722 (uniprop_table_uncompress)
7723 (uniprop_decode_value_run_length): New functions.
7724 (uniprop_decoder, uniprop_decoder_count): New variables.
7725 (uniprop_get_decoder, uniprop_encode_value_character)
7726 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7727 New functions.
7728 (uniprop_encoder, uniprop_encoder_count): New variables.
7729 (uniprop_get_encoder, uniprop_table)
7730 (Funicode_property_table_internal, Fget_unicode_property_internal)
7731 (Fput_unicode_property_internal): New functions.
7732 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7733 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7734 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7735 char-code-property-alist.
7736
640c8776 7737 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7738 Vunicode_category_table.
7739
640c8776 7740 * font.c (font_range): Adjust for the change of
c805dec0
KH
7741 Vunicode_category_table.
7742
76b397fb
DN
77432011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7744
7745 * m/iris4d.h: Remove file, move contents ...
7746 * s/irix6-5.h: ... here.
7747
22b4128e
PE
77482011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7749
7750 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7751 * alloc.c (mark_buffer):
7752 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7753 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7754 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7755 This isn't true in general, and it's particularly not true
7756 if Emacs is configured with --with-wide-int.
7757 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7758 New macros, used in the buffer.c change.
7759
869795d6
JD
77602011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7761
7762 * xsettings.c: Use both GConf and GSettings if both are available.
7763 (store_config_changed_event): Add comment.
7764 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7765 (store_tool_bar_style_changed): New functions.
5e617bc2 7766 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7767 (struct xsettings): Move font inside HAVE_XFT.
7768 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7769 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7770 Move inside HAVE_XFT.
640c8776 7771 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7772 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7773 also.
7774 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7775 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7776 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7777 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7778 (parse_settings): Move check for font inside HAVE_XFT.
7779 (read_settings, apply_xft_settings): Add comment.
7780 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7781 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7782 call store_font_name_changed.
7783 (xft_settings_event): Add comment.
7784 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7785 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7786 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7787 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7788 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7789 (xsettings_get_system_font, xsettings_get_system_normal_font):
7790 Add comment.
869795d6 7791
d8ed26bd
PE
77922011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7793
7794 Random fixes. E.g., (random) never returned negative values.
7795 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7796 subseconds part to the entropy, as that's a bit more random.
7797 Prefer signed to unsigned, since the signedness doesn't matter and
7798 in general we prefer signed. When given a limit, use a
7799 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7800 latter isn't right if USE_2_TAGS_FOR_INTS.
7801 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7802 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7803
cabf1cac
SM
78042011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7805
7806 * textprop.c (text_property_stickiness):
7807 Obey Vtext_property_default_nonsticky.
7808 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7809 * w32fns.c (syms_of_w32fns):
7810 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7811
6e9b2be9
PE
78122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7813
7814 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7815 This is more efficient than Ffile_directory_p and avoids a minor race.
7816
90186c68
LMI
78172011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7818
7c301272
LMI
7819 * buffer.c (Foverlay_put): Say what the return value is
7820 (bug#7835).
7821
c4f2d8d4
LMI
7822 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7823 is a directory before asking whether to use the file name
7824 (bug#7564).
ad637907
LMI
7825 (barf_or_query_if_file_exists): Make the "File is a directory"
7826 error be more correct.
c4f2d8d4 7827
90186c68
LMI
7828 * fns.c (Frequire): Remove the mention of the .gz files, since
7829 that's installation-specific, but keep the mention of
7830 `get-load-suffixes'.
7831
da64016e
PE
78322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7833
7834 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7835 Report string overflow if the output is too long.
7836
7d47b580
JB
78372011-07-04 Juanma Barranquero <lekktu@gmail.com>
7838
a555cb87
JB
7839 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7840 (syms_of_gnutls): Remove duplicate DEFSYM for
7841 Qgnutls_bootprop_verify_hostname_error, an error for
7842 Qgnutls_bootprop_verify_error (which is no longer used).
7843
7d47b580
JB
7844 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7845 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7846 Also (re)move comments that are misplaced or no longer relevant.
7847
1e49bfab
LMI
78482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7849
7850 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7851
1485f4c0
CY
78522011-07-03 Chong Yidong <cyd@stupidchicken.com>
7853
7854 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7855 and background color parameters if they have been changed.
7856
a9ab721e
LMI
78572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7858
7859 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7860
cf7cff57
PE
78612011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7862
2e13213d
PE
7863 * xsettings.c (SYSTEM_FONT): Define only when used.
7864 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7865
cf7cff57
PE
7866 * keymap.c (access_keymap_1): Now static.
7867
7a8e04f7
CY
78682011-07-02 Chong Yidong <cyd@stupidchicken.com>
7869
7870 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7871 leave any prefix arg for the up event (Bug#1586).
7872
61352f62
LMI
78732011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7874
69bb1ef7
LMI
7875 * lread.c (syms_of_lread): Mention single symbols defined by
7876 `defvar' or `defconst' (bug#7154).
7877
61352f62 7878 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7879 (Frequire): Mention get-load-suffixes.
61352f62 7880
28545e04
MR
78812011-07-02 Martin Rudalics <rudalics@gmx.at>
7882
7883 * window.h (window): Remove clone_number slot.
7884 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7885 Remove.
7886 (make_parent_window, make_window, saved_window)
7887 (Fset_window_configuration, save_window_save): Don't deal with
7888 clone numbers.
7889 * buffer.c (Qclone_number): Remove declaration.
7890 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7891
3349e122
SM
78922011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7893
7894 Add multiple inheritance to keymaps.
7895 * keymap.c (Fmake_composed_keymap): New function.
7896 (Fset_keymap_parent): Simplify.
7897 (fix_submap_inheritance): Remove.
7898 (access_keymap_1): New function extracted from access_keymap to handle
7899 embedded parents and handle lists of maps.
7900 (access_keymap): Use it.
7901 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7902 (Fcopy_keymap): Handle embedded parents.
7903 (Fcommand_remapping, define_as_prefix): Simplify.
7904 (Fkey_binding): Simplify.
7905 (syms_of_keymap): Move minibuffer-local-completion-map,
7906 minibuffer-local-filename-completion-map,
7907 minibuffer-local-must-match-map, and
7908 minibuffer-local-filename-must-match-map to Elisp.
7909 (syms_of_keymap): Defsubr make-composed-keymap.
7910 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7911 (parse_menu_item): Trivial simplification.
7912
3279eb87
GM
79132011-07-01 Glenn Morris <rgm@gnu.org>
7914
7915 * Makefile.in (SETTINGS_LIBS): Fix typo.
7916
4550efdf
KI
79172011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7918
7919 * coding.c (Fencode_coding_string): Record the last coding system
7920 used, as the function doc string says (bug#8738).
7921
0949d2b6
JD
79222011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7923
7924 * xsettings.c (store_monospaced_changed): Take new font as arg and
7925 check for change against current_mono_font.
7926 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7927 (emacs_settings_constructor, emacs_settings_get_property)
7928 (emacs_settings_set_property, emacs_settings_class_init)
7929 (emacs_settings_init, gsettings_obj): Remove.
7930 (something_changedCB): New function for HAVE_GSETTINGS.
7931 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7932 with value as argument.
7933 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7934 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7935 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7936 "changed".
7937
7938 * xgselect.c: Add defined (HAVE_GSETTINGS).
7939 (xgselect_initialize): Ditto.
7940
7941 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7942 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7943 xg_select.
7944
bbc6b304
PE
79452011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7946
7947 * eval.c (struct backtrace): Simplify and port the data structure.
7948 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7949 signed bit field, as this assumption is not portable and it makes
7950 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7951 "char debug_on_exit : 1" as this is not portable either; instead,
7952 use the portable "unsigned int debug_on_exit : 1". Remove unused
7953 member evalargs. Remove obsolete comments about cc bombing out.
7954
9851bfc5
JD
79552011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7956
51bb811f 7957 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7958 Let HAVE_GSETTINGS override HAVE_GCONF.
7959 (store_monospaced_changed): New function.
7960 (EMACS_SETTINGS): A new type derived from GObject to handle
7961 GSettings notifications.
7962 (emacs_settings_constructor, emacs_settings_get_property)
7963 (emacs_settings_set_property, emacs_settings_class_init):
7964 New functions.
7965 (gsettings_client, gsettings_obj): New variables.
7966 (GSETTINGS_SCHEMA): New define.
7967 (something_changedCB): Call store_monospaced_changed.
7968 (init_gsettings): New function.
7969 (xsettings_initialize): Call init_gsettings.
7970 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7971 to NULL.
7972
640c8776 7973 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7974 GCONF_CFLAGS/LIBS.
7975
5386012d
MR
79762011-06-29 Martin Rudalics <rudalics@gmx.at>
7977
7978 * window.c (resize_root_window, grow_mini_window)
7979 (shrink_mini_window): Rename Qresize_root_window to
7980 Qwindow_resize_root_window and Qresize_root_window_vertically to
7981 Qwindow_resize_root_window_vertically.
7982
f13e0b08
PE
79832011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7984
7985 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7986
94515237
JB
79872011-06-27 Juanma Barranquero <lekktu@gmail.com>
7988
7989 * makefile.w32-in: Redesign dependencies so they reflect more
7990 clearly which files are directly included by each source file,
7991 and not through other includes.
7992
e43b6e43
MR
79932011-06-27 Martin Rudalics <rudalics@gmx.at>
7994
7995 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7996 (sort_overlays, overlay_strings): When an overlay's clone number
7997 matches the window's clone number process the overlay even if
7998 the overlay's window property doesn't match the current window.
7999
d68443dc
MR
8000 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8001 (Fwindow_hchild): Rename to Fwindow_left_child.
8002 (Fwindow_next): Rename to Fwindow_next_sibling.
8003 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8004 (resize_window_check): Rename to window_resize_check.
8005 (resize_window_apply): Rename to window_resize_apply.
8006 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8007 (Fdelete_other_windows_internal, resize_frame_windows)
8008 (Fsplit_window_internal, Fdelete_window_internal)
8009 (grow_mini_window, shrink_mini_window)
8010 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8011
c7e73be5
JD
80122011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8013
8014 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8015 (emacs_fixed_set_min_size): Remove.
8016 (emacs_fixed_new): Take frame as argument.
8017
8018 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8019 (_EmacsFixedPrivate): Remove minwidth/height.
8020 Add struct frame *f.
8021 (emacs_fixed_init): Initialize priv->f.
8022 (get_parent_class, emacs_fixed_set_min_size): Remove.
8023 (emacs_fixed_new): Set priv->f to argument.
8024 (emacs_fixed_get_preferred_width)
8025 (emacs_fixed_get_preferred_height): Use min_width/height from
8026 frames size_hint to set minimum and natural (Bug#8919).
8027 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8028 and use min_width/height from frames size_hint to set
8029 min_width/height (Bug#8919).
8030
8031 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8032 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8033 Fix indentation.
c7e73be5 8034
cf99dcf8
EZ
80352011-06-26 Eli Zaretskii <eliz@gnu.org>
8036
8037 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8038 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8039 called at ZV.
8040
029529ac
CY
80412011-06-26 Chong Yidong <cyd@stupidchicken.com>
8042
8043 * process.c (wait_reading_process_output): Bypass select if
8044 waiting for a cell while ignoring keyboard input, and input is
8045 pending. Suggested by Jan Djärv (Bug#8869).
8046
7a7ef429
PE
80472011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8048
8049 Use gnulib's dup2 module instead of rolling our own.
8050 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8051
11fdef7d 80522011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8053
8054 * dispnew.c (scrolling_window): Before scrolling, turn off a
8055 mouse-highlight in the window being scrolled.
8056
cd3520a4
JB
80572011-06-24 Juanma Barranquero <lekktu@gmail.com>
8058
8059 Move DEFSYM to lisp.h and use everywhere.
8060
8061 * character.h (DEFSYM): Move declaration...
8062 * lisp.h (DEFSYM): ...here.
8063
8064 * gnutls.c:
8065 * minibuf.c:
8066 * w32menu.c:
8067 * w32proc.c:
8068 * w32select.c: Don't include character.h.
8069
8070 * alloc.c (syms_of_alloc):
8071 * buffer.c (syms_of_buffer):
8072 * bytecode.c (syms_of_bytecode):
8073 * callint.c (syms_of_callint):
8074 * casefiddle.c (syms_of_casefiddle):
8075 * casetab.c (init_casetab_once):
8076 * category.c (init_category_once, syms_of_category):
8077 * ccl.c (syms_of_ccl):
8078 * cmds.c (syms_of_cmds):
8079 * composite.c (syms_of_composite):
8080 * dbusbind.c (syms_of_dbusbind):
8081 * dired.c (syms_of_dired):
8082 * dispnew.c (syms_of_display):
8083 * doc.c (syms_of_doc):
8084 * editfns.c (syms_of_editfns):
8085 * emacs.c (syms_of_emacs):
8086 * eval.c (syms_of_eval):
8087 * fileio.c (syms_of_fileio):
8088 * fns.c (syms_of_fns):
8089 * frame.c (syms_of_frame):
8090 * fringe.c (syms_of_fringe):
8091 * insdel.c (syms_of_insdel):
8092 * keymap.c (syms_of_keymap):
8093 * lread.c (init_obarray, syms_of_lread):
8094 * macros.c (syms_of_macros):
8095 * msdos.c (syms_of_msdos):
8096 * print.c (syms_of_print):
8097 * process.c (syms_of_process):
8098 * search.c (syms_of_search):
8099 * sound.c (syms_of_sound):
8100 * syntax.c (init_syntax_once, syms_of_syntax):
8101 * terminal.c (syms_of_terminal):
8102 * textprop.c (syms_of_textprop):
8103 * undo.c (syms_of_undo):
8104 * w32.c (globals_of_w32):
8105 * window.c (syms_of_window):
8106 * xdisp.c (syms_of_xdisp):
8107 * xfaces.c (syms_of_xfaces):
8108 * xfns.c (syms_of_xfns):
8109 * xmenu.c (syms_of_xmenu):
8110 * xsettings.c (syms_of_xsettings):
8111 * xterm.c (syms_of_xterm): Use DEFSYM.
8112
4228cf16
TZ
81132011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8114
cd3520a4 8115 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8116
7fcccf1e
PE
81172011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8118
7efb4e0e
PE
8119 Integer and buffer overflow fixes (Bug#8873).
8120
ff5844ad
PE
8121 * print.c (printchar, strout): Check for string overflow.
8122 (PRINTPREPARE, printchar, strout):
8123 Don't set size unless allocation succeeds.
8124
90532f02
PE
8125 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8126 for sizes. Check for string overflow more accurately.
8127 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8128
6d84508d
PE
8129 * macros.c: Integer and buffer overflow fixes.
8130 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8131 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8132 Use ptrdiff_t, not int, for sizes.
8133 Don't increment bufsize until after realloc succeeds.
8134 Check for size-calculation overflow.
8135 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8136
437b2cb4
PE
8137 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8138
8b9ac8b4
PE
8139 * lread.c: Integer overflow fixes.
8140 (read_integer): Radix is now EMACS_INT, not int,
8141 to improve quality of diagnostics for out-of-range radices.
8142 Calculate buffer size correctly for out-of-range radices.
8143 (read1): Check for integer overflow in radices, and in
8144 read-circle numbers.
82cb60d3
PE
8145 (read_escape): Avoid int overflow.
8146 (Fload, openp, read_buffer_size, read1)
8147 (substitute_object_recurse, read_vector, read_list, map_obarray):
8148 Use ptrdiff_t, not int, for sizes.
8149 (read1): Use EMACS_INT, not int, for sizes.
20270765 8150 Check for size overflow.
8b9ac8b4 8151
7fcccf1e
PE
8152 * image.c (cache_image): Check for size arithmetic overflow.
8153
bfbbd7e7
PE
8154 * lread.c: Integer overflow issues.
8155 (saved_doc_string_size, saved_doc_string_length)
8156 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8157 Now ptrdiff_t, not int.
8158 (read1): Don't assume doc string length fits in int. Check for
8159 out-of-range doc string lengths.
8160 (read_list): Don't assume file position fits in int.
39019e54 8161 (read_escape): Check for hex character overflow.
bfbbd7e7 8162
4e323265
LL
81632011-06-22 Leo Liu <sdl.web@gmail.com>
8164
8165 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8166 Move to minibuffer.el.
8167
85fece3e
PE
81682011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8169
20b84ce9 8170 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8171 The following patches are for when GLYPH_DEBUG && !XASSERT.
8172 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8173 * dispnew.c (flush_stdout):
8174 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8175 Mark as externally visible.
8176 * dispnew.c (check_window_matrix_pointers): Now static.
8177 * dispnew.c (window_to_frame_vpos):
8178 * xfns.c (unwind_create_frame):
8179 * xterm.c (x_check_font): Remove unused local.
8180 * scroll.c (CHECK_BOUNDS):
8181 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8182 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8183 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8184 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8185 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8186 Now static.
8187 (debug_method_add): Use va_list and vsprintf rather than relying
8188 on undefined behavior with wrong number of arguments.
8189 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8190 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8191 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8192 since we're not interested in debugging glyphs with old libraries.
8193 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8194 GCC 4.6.0's static checking.
8195
0766b489
PE
81962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8197
31fd4b32
PE
8198 Integer overflow and signedness fixes (Bug#8873).
8199 A few related buffer overrun fixes, too.
8200
b79e8648
PE
8201 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8202
0766b489
PE
8203 * dispextern.h (struct face.stipple):
8204 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8205 (x_bitmap_mask, x_allocate_bitmap_record)
8206 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8207 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8208 (x_create_bitmap_from_xpm_data):
8209 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8210 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8211 (.bitmaps_last):
8212 * xfaces.c (load_pixmap):
8213 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8214 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8215 (.bitmaps_last, struct x_output.icon_bitmap):
8216 Use ptrdiff_t, not int, for bitmap indexes.
8217 (x_allocate_bitmap_record): Check for size overflow.
8218 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8219
b081724f
PE
8220 Use ptrdiff_t, not int, for overlay counts.
8221 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8222 * editfns.c (overlays_around, get_pos_property):
8223 * textprop.c (get_char_property_and_overlay):
8224 * xdisp.c (next_overlay_change, note_mouse_highlight):
8225 * xfaces.c (face_at_buffer_position):
21514da7
PE
8226 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8227 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8228 (Fnext_overlay_change, Fprevious_overlay_change)
8229 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8230 Use ptrdiff_t, not int, for sizes.
21514da7 8231 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8232
3de73e5e
PE
8233 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8234
2606c57b
PE
8235 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8236 (x_session_initialize): Do not assume string length fits in int.
8237
aaafe47a
PE
8238 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8239 This is unlikely, but can occur if DPI is outlandish.
8240
2674ddc8 8241 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8242 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8243
28154962
PE
8244 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8245 * xrdb.c (magic_file_p, search_magic_path):
8246 Omit last arg SUFFIX; it was always 0. All callers changed.
8247 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8248
7de51af5
PE
8249 * xfont.c (xfont_match): Avoid need for strlen.
8250
25ed6cc3
PE
8251 * xfns.c: Don't assume strlen fits in int.
8252 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8253
4eab31dd
PE
8254 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8255 not unsigned long, as we prefer signed integers. All callers changed.
8256 Detect integer overflow in repeat count.
8257 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8258 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8259
171e2a58
PE
8260 * termcap.c: Don't assume sizes fit in int and never overflow.
8261 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8262 (gobble_line): Check for size-calculation overflow.
8263
ad39faca 8264 * minibuf.c (Fread_buffer):
6e5bb2dc 8265 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8266 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8267 Don't assume string length fits in int.
8268
52c61c22 8269 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8270 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8271
b5b8c9e5
PE
8272 * font.c: Don't assume string length fits in int.
8273 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8274 Use ptrdiff_t, not int.
ccd6111c
PE
8275 (font_intern_prop): Don't assume string length fits in int.
8276 Don't assume integer property fits in fixnum.
8277 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8278
882f0d81 8279 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8280 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8281 Reformulate so as not to need the command string.
8282 Invoke gzip -cd rather than gunzip, as it's more portable.
8283 (lock_info_type, lock_file_1, lock_file):
8284 Don't assume pid_t and time_t fit in unsigned long.
8285 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8286 (current_lock_owner): Prefer signed type for sizes.
8287 Use memcpy, not strncpy, where memcpy is what is really wanted.
8288 Don't assume (via atoi) that time_t and pid_t fit in int.
8289 Check for time_t and/or pid_t out of range, e.g., via a network share.
8290 Don't alloca where an auto var works fine.
8291
93f4cf88
PE
8292 * fileio.c: Fix some integer overflow issues.
8293 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8294 Don't assume string length fits in int.
8295 (directory_file_name): Don't assume string length fits in long.
8296 (make_temp_name): Don't assume pid fits in int, or that its print
8297 length is less than 20.
8298
f3e92b69
PE
8299 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8300
1bfdaf10
PE
8301 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8302
35016e9a
PE
8303 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8304
3d1e65a1
PE
8305 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8306 We prefer signed integers, even for size calculations.
8307
0b963a93
PE
8308 * emacs.c: Don't assume string length fits in 'int'.
8309 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8310 (main): Don't invoke strlen when not needed.
8311
573f4b54
PE
8312 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8313 (XD_DEBUG_MESSAGE): Don't waste a byte.
8314
989f33ba
PE
8315 * callproc.c (getenv_internal_1, getenv_internal)
8316 (Fgetenv_internal):
965d34eb
PE
8317 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8318
e4d29b33
PE
8319 * lread.c (invalid_syntax): Omit length argument.
8320 All uses changed. This doesn't fix a bug, but it simplifies the
8321 code away from its former Hollerith-constant appearance, and it's
8322 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8323 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8324
eb49b136
PE
8325 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8326 This didn't break anything, but it didn't help either.
8327 It's confusing to put a bogus integer in a place where the actual
8328 value does not matter.
9f62aeb1 8329 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8330 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8331
15375a22
PE
8332 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8333 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8334 implementation.
b61cc01c
PE
8335 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8336 We prefer signed types, and the value cannot exceed the EMACS_INT
8337 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8338 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8339 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8340 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8341
53b2623d
PE
8342 * indent.c (sane_tab_width): New function.
8343 (current_column, scan_for_column, Findent_to, position_indentation)
8344 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8345 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8346
51cab52b 8347 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8348
f2ed8a70
PE
8349 * lisp.h (lint_assume): New macro.
8350 * composite.c (composition_gstring_put_cache):
8351 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8352
abe80cc6
PE
8353 * editfns.c, insdel.c:
8354 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8355
b02c740e
PE
8356 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8357
ebc96716
PE
8358 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8359
b4e50fa0 8360 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8361 Use much-faster test for byte-length change.
311d5d7c 8362 Don't assume string byte-length fits in 'int'.
a4cf38e4 8363 Check that character arg fits in 'int'.
85461888 8364 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8365
c0c1ee9f
PE
8366 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8367
a498d7f4
PE
8368 * fns.c (concat): Catch string overflow earlier.
8369 Do not rely on integer wraparound.
8370
51cab52b
PE
8371 * dispextern.h (struct it.overlay_strings_charpos)
8372 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8373 * xdisp.c (forward_to_next_line_start)
8374 (back_to_previous_visible_line_start)
8375 (reseat_at_next_visible_line_start, next_element_from_buffer):
8376 Don't arbitrarily truncate the value of 'selective' to int.
8377
76031fad
PE
8378 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8379
5eb55db9
PE
8380 * composite.c: Don't truncate sizes to 'int'.
8381 (composition_gstring_p, composition_reseat_it)
8382 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8383 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8384 not EMACS_UINT, for indexes.
5eb55db9 8385
0703a717
PE
8386 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8387
d6202519
PE
8388 * buffer.c: Include <verify.h>.
8389 (struct sortvec.priority, struct sortstr.priority):
8961a454 8390 Now EMACS_INT, not int.
c20998a7 8391 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8392 (struct sortstr.size, record_overlay_string)
8393 (struct sortstrlist.size, struct sortlist.used):
8394 Don't truncate size to int.
8395 (record_overlay_string): Check for size-calculation overflow.
d6202519 8396 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8397
d5a19415
JM
83982011-06-22 Jim Meyering <meyering@redhat.com>
8399
029529ac 8400 Don't leak an XBM-image-sized buffer
d5a19415
JM
8401 * image.c (xbm_load): Free the image buffer after using it.
8402
a9041e6c
PE
84032011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8404
8405 Port to Sun C.
8406 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8407 that Sun C diagnosed.
8408 * fns.c (secure_hash): Fix pointer signedness issue.
8409 * intervals.c (static_offset_intervals): New function.
8410 (offset_intervals): Use it.
8411
7f3f739f
LL
84122011-06-21 Leo Liu <sdl.web@gmail.com>
8413
8414 * deps.mk (fns.o):
8415 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8416 sha512.h.
8417
8418 * fns.c (secure_hash): Rename from crypto_hash_function and change
8419 the first arg to accept symbols.
5b66d427 8420 (Fsecure_hash): New primitive.
7f3f739f
LL
8421 (syms_of_fns): New symbols.
8422
76147d94
DD
84232011-06-20 Deniz Dogan <deniz@dogan.se>
8424
8425 * process.c (Fset_process_buffer): Clarify return value in
8426 docstring.
8427
7d7d0045
CY
84282011-06-18 Chong Yidong <cyd@stupidchicken.com>
8429
8430 * dispnew.c (add_window_display_history): Use BVAR.
8431
8432 * xdisp.c (debug_method_add): Use BVAR.
8433 (check_window_end, dump_glyph_matrix, dump_glyph)
8434 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8435
8436 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8437 Likewise.
8438
8439 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8440 check till after the cache is created in init_frame_faces.
8441
ff2bc410
SM
84422011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8443
8444 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8445
28177add
PE
84462011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8447
dd3482fe
PE
8448 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8449 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8450 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8451
393d71f3 8452 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8453 * fileio.c (Finsert_file_contents):
8454 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8455 Remove the old (too-loose) buffer overflow checks.
8456 They weren't needed, since make_gap checks for buffer overflow.
8457 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8458 The old code merely checked for Emacs fixnum overflow, and relied
8459 on undefined (wraparound) behavior. The new code avoids undefined
8460 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8461
2e6813b0 8462 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8463 Tune. Don't use wider integers than needed. Don't use alloca.
8464 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8465
599a9e4f
PE
8466 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8467
99561444
PE
8468 * insdel.c, lisp.h (buffer_overflow): New function.
8469 (insert_from_buffer_1, replace_range, replace_range_2):
8470 * insdel.c (make_gap_larger):
8471 * editfns.c (Finsert_char):
8472 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8473
28177add
PE
8474 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8475
e69dafad
PE
84762011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8477
4baa020d 8478 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8479
b1c46f02
PE
8480 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8481 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8482
e69dafad
PE
8483 * fileio.c: Don't assume EMACS_INT fits in off_t.
8484 (emacs_lseek): New static function.
8485 (Finsert_file_contents, Fwrite_region): Use it.
8486 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8487
566684ea
PE
8488 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8489
e6966cd6
PE
8490 * fns.c: Don't overflow int when computing a list length.
8491 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8492 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8493 truncation on 64-bit hosts. Check for QUIT every
8494 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8495 faster and is responsive enough.
8496 (Flength): Report an error instead of overflowing an integer.
8497 (Fsafe_length): Return a float if the value is not representable
8498 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8499 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8500 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8501
dd0b0efb
PE
8502 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8503 (header_size, word_size): New constants.
8504 (allocate_vectorlike): Don't check size overflow here.
8505 (allocate_vector): Check it here instead, since this is the only
8506 caller of allocate_vectorlike that could cause overflow.
8507 Check that the new vector's length is representable as a fixnum.
8508
86fe5cfe
PE
8509 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8510 The previous code was bogus. For example, next_almost_prime (32)
8511 returned 39, which is undesirable as it is a multiple of 3; and
8512 next_almost_prime (24) returned 25, which is a multiple of 5 so
8513 why was the code bothering to check for multiples of 7?
8514
80e88859
PE
8515 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8516
4a2f0ad6
PE
8517 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8518
f66c7cf8
PE
8519 Variadic C functions now count arguments with ptrdiff_t.
8520 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8521 Back then I didn't know that the Emacs coding style prefers signed int.
8522 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8523 were being counted with int, which may truncate counts on 64-bit
8524 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8525 * lisp.h (struct Lisp_Subr.function.aMANY)
8526 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8527 Arg counts are now ptrdiff_t, not size_t.
8528 All variadic functions and their callers changed accordingly.
8529 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8530 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8531 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8532 * callint.c (Fcall_interactively): Check arg count for overflow,
8533 to avoid potential buffer overrun. Use signed char, not 'int',
8534 for 'varies' array, so that we needn't bother to check its size
8535 calculation for overflow.
8536 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8537 * eval.c (apply_lambda):
8538 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8539 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8540 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8541
a1759b76
PE
8542 * callint.c (Fcall_interactively): Don't use index var as event count.
8543
d96be9fc
PE
8544 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8545 * mem-limits.h (SIZE): Remove; no longer used.
8546
a690a978 8547 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8548
578c21e6
PE
8549 Remove unnecessary casts.
8550 * xterm.c (x_term_init):
8551 * xfns.c (x_set_border_pixel):
8552 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8553 These aren't needed now that we assume ANSI C.
8554
96f53c6c
PE
8555 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8556 It's more likely to cause problems (due to unsigned overflow)
8557 than to cure them.
8558
83c77d31
PE
8559 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8560
ee2079f1
PE
8561 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8562
6da65536
PE
8563 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8564
7147c4a4
PE
8565 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8566
193e32d9
PE
8567 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8568
e5533da6
PE
8569 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8570
9910e595
PE
8571 GLYPH_CODE_FACE returns EMACS_INT, not int.
8572 * dispextern.h (merge_faces):
8573 * xfaces.c (merge_faces):
01103c44
PE
8574 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8575 Don't assume EMACS_INT fits in int.
9910e595 8576
2638320e
PE
8577 * character.h (CHAR_VALID_P): Remove unused parameter.
8578 * fontset.c, lisp.h, xdisp.c: All uses changed.
8579
045eb8d9
PE
8580 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8581
c1f134b5
PE
8582 * fns.c (concat): Minor tuning based on overflow analysis.
8583 This doesn't fix any bugs. Use int to hold character, instead
8584 of constantly refetching from Emacs object. Use XFASTINT, not
8585 XINT, for value known to be a character. Don't bother comparing
8586 a single byte to 0400, as it's always less.
8587
395fcb93 8588 * floatfns.c (Fexpt):
327eeec8
PE
8589 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8590
abbd3d23
PE
8591 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8592 for characters.
8593
684a03ef
PE
8594 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8595
0fed43f3
PE
8596 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8597 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8598 incorrectly succeed when S was a string, because 4294967386 was
8599 truncated before it was used.
8600
8fd02eb7
PE
8601 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8602 Otherwise, an out-of-range integer could cause undefined behavior
8603 on a 64-bit host.
8604
f8c86b69
PE
8605 * composite.c: Use int, not EMACS_INT, for characters.
8606 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8607 EMACS_INT, for values that are known to be in character range.
8608 This doesn't fix any bugs but is the usual style inside Emacs and
8609 may generate better code on 32-bit machines.
8610
34206dd2
PE
8611 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8612 This is for reasons similar to the recent CHAR_STRING fix.
8613 * charset.c (Fencode_char): Check that character arg is actually
8614 a character. Pass an int to ENCODE_CHAR.
8615 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8616 wider than 'int', as a compile-time check to prevent future regressions
8617 in this area.
8618
c5958d4c 8619 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8620
8621 Make sure a 64-bit char is never passed to CHAR_STRING.
8622 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8623 by silently ignoring the top 32 bits, allowing some values
8624 that were far too large to be valid characters.
8625 * character.h: Include <verify.h>.
8626 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8627 arguments are no wider than unsigned, as a compile-time check
8628 to prevent future regressions in this area.
8629 * data.c (Faset):
01103c44 8630 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8631 (Fsubst_char_in_region):
8632 * fns.c (concat):
8633 * xdisp.c (decode_mode_spec_coding):
8634 Adjust to CHAR_STRING's new requirement.
8635 * editfns.c (Finsert_char, Fsubst_char_in_region):
8636 * fns.c (concat): Check that character args are actually
8637 characters. Without this test, these functions did the wrong
8638 thing with wildly out-of-range values on 64-bit hosts.
8639
d37ca623
PE
8640 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8641 These casts should not be needed on 32-bit hosts, either.
8642 * keyboard.c (read_char):
8643 * lread.c (Fload): Remove casts to unsigned.
8644
ea204efb
PE
8645 * lisp.h (UNSIGNED_CMP): New macro.
8646 This fixes comparison bugs on 64-bit hosts.
8647 (ASCII_CHAR_P): Use it.
8648 * casefiddle.c (casify_object):
01103c44 8649 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8650 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8651 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8652 * dispextern.h (FACE_FROM_ID):
8653 * keyboard.c (read_char): Use UNSIGNED_CMP.
8654
41cb286c
PE
8655 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8656 not to EMACS_INT, to avoid GCC warning.
8657
4a1b9832
PE
8658 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8659
55daad71
PE
8660 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8661 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8662 isn't needed on 32-bit machines.
8f95c75c 8663
01103c44
PE
8664 * buffer.c (Fgenerate_new_buffer_name):
8665 Use EMACS_INT for count, not int.
0ceccced 8666 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8667
8668 * data.c (Qcompiled_function): Now static.
8669
c6f072e7
PE
8670 * window.c (window_body_lines): Now static.
8671
20ce5912
PE
8672 * image.c (gif_load): Rename local to avoid shadowing.
8673
9c4c5f81
PE
8674 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8675 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8676 * alloc.c (make_save_value): Integer argument is now of type
8677 ptrdiff_t, not int.
8678 (mark_object): Use ptrdiff_t, not int.
8679 * lisp.h (pD): New macro.
8680 * print.c (print_object): Use it.
8681
c0c5c8ae
PE
8682 * alloc.c: Use EMACS_INT, not int, to count objects.
8683 (total_conses, total_markers, total_symbols, total_vector_size)
8684 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8685 (total_free_floats, total_floats, total_free_intervals)
8686 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8687 Now EMACS_INT, not int. All uses changed.
8688 (Fgarbage_collect): Compute overall total using a double, so that
8689 integer overflow is less likely to be a problem. Check for overflow
8690 when converting back to an integer.
5a25e253
PE
8691 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8692 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8693 These were 'int' variables that could overflow on 64-bit hosts;
8694 they were never used, so remove them instead of repairing them.
211a0b2a 8695 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8696 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8697 Previously, this ceilinged at INT_MAX, but that doesn't work on
8698 64-bit machines.
e46bb31a 8699 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8700
c78baabf 8701 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8702 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8703 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8704 when a (possibly-narrower) signed value would do just as well.
8705 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8706
c9d624c6
PE
8707 * alloc.c: Catch some string size overflows that we were missing.
8708 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8709 for convenience in STRING_BYTES_MAX.
8710 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8711 The definition here is exact; the one in lisp.h was approximate.
8712 (allocate_string_data): Check for string overflow. This catches
8713 some instances we weren't catching before. Also, it catches
8714 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8715 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8716 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8717
c9d624c6
PE
8718 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8719 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8720 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8721
353032ce
PE
8722 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8723
2bccce07
PE
8724 * alloc.c (Fmake_string): Check for out-of-range init.
8725
0ac30604
SM
87262011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8727
8728 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8729
c195f2de
JD
87302011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8731
8732 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8733 xg_get_default_scrollbar_width.
8734
8735 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8736 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8737 (style_changed_cb): Call update_theme_scrollbar_width and call
8738 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8739 all frames (Bug#8505).
8740 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8741 Call gtk_window_set_resizable if HAVE_GTK3.
8742 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8743 and height if HAVE_GTK3 (Bug#8505).
8744 (scroll_bar_width_for_theme): New variable.
8745 (update_theme_scrollbar_width): New function.
8746 (xg_get_default_scrollbar_width): Move code to
8747 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8748 (xg_initialize): Call update_theme_scrollbar_width.
8749
8750 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8751
8752 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8753
e10ac9f1
MR
87542011-06-12 Martin Rudalics <rudalics@gmx.at>
8755
8756 * frame.c (make_frame): Call other_buffer_safely instead of
8757 other_buffer.
8758
8759 * window.c (temp_output_buffer_show): Call display_buffer with
8760 second argument Vtemp_buffer_show_specifiers and reset latter
8761 immediately after the call.
8762 (Vtemp_buffer_show_specifiers): New variable.
8763 (auto_window_vscroll_p, next_screen_context_lines)
8764 (Vscroll_preserve_screen_position): Remove leading asterisks from
8765 doc-strings.
8766
2d3c217e 87672011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8768
7b7f97e8 8769 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8770 * buffer.c (Qclone_number): Remove for now, as it's unused.
8771 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8772 (record_buffer): Remove unused local.
8773 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8774 (set_frame_buffer_list): Remove; unused.
8775 * frame.h (other_visible_frames): Remove decl.
8776 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8777 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8778 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8779 if HAVE_GPM.
8780 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8781 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8782 Define only if HAVE_GPM.
8783 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8784 (update_hints_inhibit): Remove; never set. All uses removed.
8785 * widgetprv.h (emacsFrameClassRec): Remove decl.
8786 * window.c (delete_deletable_window): Now returns void, since it
8787 wasn't returning anything.
8788 (compare_window_configurations): Remove unused locals.
8789 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8790 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8791 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8792 the same widths as pointers. This follows up on the 2011-05-06 patch.
8793 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8794 * xterm.h: Likewise.
8795 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8796
1384b89e
JB
87972011-06-12 Juanma Barranquero <lekktu@gmail.com>
8798
8799 * makefile.w32-in: Update dependencies.
8800 (LISP_H): Add lib/intprops.h.
8801
1100a63c
CY
88022011-06-11 Chong Yidong <cyd@stupidchicken.com>
8803
8804 * image.c (gif_load): Add animation frame delay to the metadata.
8805 (syms_of_image): Use DEFSYM. New symbol `delay'.
8806
6198ccd0
MR
88072011-06-11 Martin Rudalics <rudalics@gmx.at>
8808
8809 * window.c (delete_deletable_window): Re-add.
8810 (Fset_window_configuration): Rewrite to handle dead buffers and
8811 consequently deletable windows.
8812 (window_tree, Fwindow_tree): Remove. Supply functionality in
8813 window.el.
8814 (compare_window_configurations): Simplify code.
8815
b6e3633c
AS
88162011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8817
1ab0dee5
AS
8818 * image.c (imagemagick_load_image): Fix type mismatch.
8819 (Fimagemagick_types): Likewise.
8820
b6e3633c
AS
8821 * window.h (replace_buffer_in_windows): Declare.
8822
9397e56f
MR
88232011-06-11 Martin Rudalics <rudalics@gmx.at>
8824
8825 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8826 Qclone_number. Remove external declaration of Qdelete_window.
8827 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8828 code.
640c8776
SM
8829 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8830 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8831 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8832 buffer list implementation.
8833 (other_buffer_safely): New function.
8834 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8835 calls to replace_buffer_in_windows and
8836 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8837 if allowed.
8838 (record_buffer): Inhibit quitting and rewrite using quittable
8839 functions. Run Qbuffer_list_update_hook if allowed.
8840 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8841 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8842 Move switch-to-buffer to window.el.
9397e56f
MR
8843 (bury-buffer): Move to window.el.
8844 (Vbuffer_list_update_hook): New variable.
8845
8846 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8847 section.
8848
8849 * window.h (resize_frame_windows): Move up in code.
8850 (Fwindow_frame): Remove EXFUN.
8851 (replace_buffer_in_all_windows): Remove prototype.
8852 (replace_buffer_in_windows_safely): Add prototype.
8853
8854 * window.c: Declare Qdelete_window static again. Move down
8855 declaration of select_count.
8856 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8857 (Fother_window): Move to window.el.
8858 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8859 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8860 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8861 window.el.
8862 (replace_buffer_in_windows): Implement by calling
8863 Qreplace_buffer_in_windows.
8864 (replace_buffer_in_all_windows): Remove with some functionality
8865 moved into replace_buffer_in_windows_safely.
8866 (replace_buffer_in_windows_safely): New function.
8867 (select_window_norecord, select_frame_norecord): Move in front
8868 of run_window_configuration_change_hook. Remove now obsolete
8869 declarations.
640c8776
SM
8870 (Fset_window_buffer): Rewrite doc-string.
8871 Call Qrecord_window_buffer.
9397e56f
MR
8872 (keys_of_window): Move binding for other-window to window.el.
8873
b50691aa
CY
88742011-06-11 Chong Yidong <cyd@stupidchicken.com>
8875
8876 * dispextern.h (struct image): Replace data member, whose int_val
8877 and ptr_val fields were not used by anything, with a single
8878 lisp_val object.
8879
8880 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8881 (gif_clear_image, gif_load, imagemagick_load_image)
8882 (gs_clear_image, gs_load): Callers changed.
8883
3f754b86
PE
88842011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8885
cca69397
PE
8886 * buffer.h: Include <time.h>, for time_t.
8887 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8888
109e28d0
PE
8889 Fix minor problems found by static checking.
8890
60737f02
PE
8891 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8892
4b66faf3
PE
8893 Make identifiers static if they are not used in other modules.
8894 * data.c (Qcompiled_function, Qframe, Qvector):
8895 * image.c (QimageMagick, Qsvg):
8896 * minibuf.c (Qmetadata):
8897 * window.c (resize_window_check, resize_root_window): Now static.
8898 * window.h (resize_window_check, resize_root_window): Remove decls.
8899
109e28d0
PE
8900 * window.c (window_deletion_count, delete_deletable_window):
8901 Remove; unused.
46a4ce9e
PE
8902 (window_body_lines): Now static.
8903 (Fdelete_other_windows_internal): Mark vars as initialized.
8904 Make sure 'resize_failed' is initialized.
8905 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8906 (resize_window_apply): Remove unused local.
8907 * window.h (delete_deletable_window): Remove decl.
8908
109e28d0 8909 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8910 (imagemagick_load_image): Fix pointer signedness problem by changing
8911 last arg from unsigned char * to char *. All uses changed.
8912 Also, fix a local for similar reasons.
8913 Remove unused locals. Remove locals to avoid shadowing.
8914 (fn_rsvg_handle_free): Remove; unused.
8915 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8916 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8917
3f754b86
PE
8918 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8919
2547adb1
CY
89202011-06-10 Chong Yidong <cyd@stupidchicken.com>
8921
8922 * image.c (gif_load): Fix omitted cast error introduced by
8923 2011-06-06 change.
8924
2c8e37d4
MR
89252011-06-10 Martin Rudalics <rudalics@gmx.at>
8926
8927 * window.h (resize_proportionally, orig_total_lines)
8928 (orig_top_line): Remove from window structure.
8929 (set_window_height, set_window_width, change_window_heights)
8930 (Fdelete_window): Remove prototypes.
8931 (resize_frame_windows): Remove duplicate declaration.
8932
440a42e3
EZ
89332011-06-10 Eli Zaretskii <eliz@gnu.org>
8934
8935 * window.h (resize_frame_windows, resize_window_check)
8936 (delete_deletable_window, resize_root_window)
8937 (resize_frame_windows): Declare prototypes.
8938
8939 * window.c (resize_window_apply): Make definition be "static" to
8940 match the prototype.
8941
562dd5e9
MR
89422011-06-10 Martin Rudalics <rudalics@gmx.at>
8943
8944 * window.c: Remove declarations of Qwindow_size_fixed,
8945 window_min_size_1, window_min_size_2, window_min_size,
8946 size_window, window_fixed_size_p, enlarge_window, delete_window.
8947 Remove static from declaration of Qdelete_window, it's
8948 temporarily needed by Fbury_buffer.
8949 (replace_window): Don't assign orig_top_line and
8950 orig_total_lines.
8951 (Fdelete_window, delete_window): Remove. Window deletion is
8952 handled by window.el.
640c8776
SM
8953 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8954 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8955 (Fdelete_other_windows): Remove. Deleting other windows is
8956 handled by window.el.
8957 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8958 handled in window.el.
8959 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8960 Window minimum sizes are handled in window.el.
8961 (shrink_windows, size_window, set_window_height)
8962 (set_window_width, change_window_heights, window_height)
8963 (window_width, CURBEG, CURSIZE, enlarge_window)
8964 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8965 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8966 handled in window.el.
8967 (make_dummy_parent): Rename to make_parent_window and give it a
8968 second argument horflag.
8969 (make_window): Don't set resize_proportionally any more.
8970 (Fsplit_window): Remove. Windows are split in window.el.
8971 (save_restore_action, save_restore_orig_size)
8972 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8973 Resize mini windows in window.el.
8974 (grow_mini_window, shrink_mini_window): Implement by calling
8975 Qresize_root_window_vertically, resize_window_check and
8976 resize_window_apply.
640c8776
SM
8977 (saved_window, Fset_window_configuration, save_window_save):
8978 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8979 resize_proportionally.
8980 (window_min_height, window_min_width): Move to window.el.
8981 (keys_of_window): Move bindings for delete-other-windows,
8982 split-window, delete-window and enlarge-window to window.el.
8983
8984 * buffer.c: Temporarily extern Qdelete_window.
8985 (Fbury_buffer): Temporarily call Qdelete_window instead of
8986 Fdelete_window (Fbury_buffer will move to window.el soon).
8987
8988 * frame.c (set_menu_bar_lines_1): Remove code handling
8989 orig_top_line and orig_total_lines.
8990
8991 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8992 set_window_height but set heights directly.
8993 (change_frame_size_1): Use resize_frame_windows.
8994
8995 * xdisp.c (init_xdisp): Don't use set_window_height but set
8996 heights directly.
8997
640c8776
SM
8998 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8999 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9000 run_window_configuration_change_hook.
9001
9002 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9003 instead of change_window_heights and run
9004 run_window_configuration_change_hook.
9005
1a13852e
MR
90062011-06-09 Martin Rudalics <rudalics@gmx.at>
9007
9008 * window.c (replace_window): Rename second argument REPLACEMENT to
9009 NEW. New third argument SETFLAG. Rewrite.
9010 (delete_window, make_dummy_parent): Call replace_window with
9011 third argument 1.
9012 (window_list_1): Move down in code.
9013 (run_window_configuration_change_hook): Move set_buffer part
9014 before select_frame_norecord part in order to unwind correctly.
9015 Rename count1 to count.
9016 (recombine_windows, delete_deletable_window, resize_root_window)
9017 (Fdelete_other_windows_internal)
9018 (Frun_window_configuration_change_hook, make_parent_window)
9019 (resize_window_check, resize_window_apply, Fresize_window_apply)
9020 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9021 (Fdelete_window_internal, Fresize_mini_window_internal):
9022 New functions.
1a13852e
MR
9023 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9024
f3d1777e
MR
90252011-06-08 Martin Rudalics <rudalics@gmx.at>
9026
496e208e
MR
9027 * window.h (window): Add some new members to window structure -
9028 normal_lines, normal_cols, new_total, new_normal, clone_number,
9029 splits, nest, prev_buffers, next_buffers.
9030 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9031 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9032
f3d1777e
MR
9033 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9034 Remove.
496e208e
MR
9035 (make_dummy_parent): Set new members of windows structure.
9036 (make_window): Move down in code. Handle new members of window
9037 structure.
9038 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9039 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9040 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9041 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9042 (Fset_window_next_buffers, Fset_window_clone_number):
9043 New functions.
496e208e
MR
9044 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9045 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9046 Doc-string fixes.
9047 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9048 Argument WINDOW can be now internal window too.
9049 (Fwindow_use_time): Move up in code.
9050 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9051 Rewrite doc-string.
9052 (Fset_window_configuration, saved_window)
9053 (Fcurrent_window_configuration, save_window_save): Handle new
9054 members of window structure.
b9e809c2
MR
9055 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9056 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9057 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9058 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9059 Qget_mru_window, Qresize_root_window,
9060 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9061 Qauto_buffer_name; staticpro them.
f3d1777e 9062
abde8f8c
MR
90632011-06-07 Martin Rudalics <rudalics@gmx.at>
9064
9065 * window.c (Fwindow_total_size, Fwindow_left_column)
9066 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9067 (Fwindow_list_1): New functions.
9068 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9069 (Fwindow_width, Fscroll_left, Fscroll_right):
9070 Use window_body_cols instead of window_box_text_cols.
9071 (delete_window, Fset_window_configuration):
9072 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9073 (delete_all_subwindows): Take a window as argument and not a
9074 structure. Rewrite.
190b47e6
MR
9075 (window_loop): Remove handling of GET_LRU_WINDOW and
9076 GET_LARGEST_WINDOW.
9077 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9078
9079 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9080 window_box_text_cols. delete_all_subwindows now takes a
9081 Lisp_Object as argument.
abde8f8c 9082
640c8776
SM
9083 * indent.c (compute_motion, Fcompute_motion):
9084 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9085
fa8a67e6
MR
9086 * frame.c (delete_frame): Call delete_all_subwindows with root
9087 window as argument.
9088
a54e3482
DC
90892011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9090
9091 * fns.c (Fputhash): Document return value.
9092
60002bf5
CY
90932011-06-06 Chong Yidong <cyd@stupidchicken.com>
9094
9095 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9096
0c671da6 90972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9098
b862a52a 9099 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9100
be44ca6c
PE
9101 Check for overflow when converting integer to cons and back.
9102 * charset.c (Fdefine_charset_internal, Fdecode_char):
9103 Use cons_to_unsigned to catch overflow.
9104 (Fencode_char): Use INTEGER_TO_CONS.
9105 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9106 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9107 * data.c (long_to_cons, cons_to_long): Remove.
9108 (cons_to_unsigned, cons_to_signed): New functions.
9109 These signal an error for invalid or out-of-range values.
9110 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9111 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9112 * font.c (Ffont_variation_glyphs):
9113 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9114 * lisp.h: Include <intprops.h>.
9115 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9116 (cons_to_signed, cons_to_unsigned): New decls.
9117 (long_to_cons, cons_to_long): Remove decls.
9118 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9119 (Fprimitive_undo): Use CONS_TO_INTEGER.
9120 * xfns.c (Fx_window_property): Likewise.
9121 * xselect.c: Include <limits.h>.
9122 (x_own_selection, selection_data_to_lisp_data):
9123 Use INTEGER_TO_CONS.
9124 (x_handle_selection_request, x_handle_selection_clear)
9125 (x_get_foreign_selection, Fx_disown_selection_internal)
9126 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9127 (lisp_data_to_selection_data): Use cons_to_unsigned.
9128 (x_fill_property_data): Use cons_to_signed.
9129 Report values out of range.
9130
d1f3d2af
PE
9131 Check for buffer and string overflow more precisely.
9132 * buffer.h (BUF_BYTES_MAX): New macro.
9133 * lisp.h (STRING_BYTES_MAX): New macro.
9134 * alloc.c (Fmake_string):
9135 * character.c (string_escape_byte8):
9136 * coding.c (coding_alloc_by_realloc):
9137 * doprnt.c (doprnt):
9138 * editfns.c (Fformat):
9139 * eval.c (verror):
9140 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9141 since they may not be the same number.
9142 * editfns.c (Finsert_char):
9143 * fileio.c (Finsert_file_contents):
9144 Likewise for BUF_BYTES_MAX.
9145
dd52fcea
PE
9146 * image.c: Use ptrdiff_t, not int, for sizes.
9147 (slurp_file): Switch from int to ptrdiff_t.
9148 All uses changed.
9149 (slurp_file): Check that file size fits in both size_t (for
9150 malloc) and ptrdiff_t (for sanity and safety).
9151
7f9bbdbb
PE
9152 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9153 if b->modtime has its maximal value.
9154
dfe18f82
PE
9155 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9156
84acfcf0
PE
9157 Don't assume time_t can fit into int.
9158 * buffer.h (struct buffer.modtime): Now time_t, not int.
9159 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9160 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9161
ccd9a01a
PE
9162 Minor fixes for signed vs unsigned integers.
9163 * character.h (MAYBE_UNIFY_CHAR):
9164 * charset.c (maybe_unify_char):
9165 * keyboard.c (read_char, reorder_modifiers):
9166 XINT -> XFASTINT, since the integer must be nonnegative.
9167 * ftfont.c (ftfont_spec_pattern):
9168 * keymap.c (access_keymap, silly_event_symbol_error):
9169 XUINT -> XFASTINT, since the integer must be nonnegative.
9170 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9171 since it makes no difference and we prefer signed.
9172 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9173 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9174 nonnegative.
9175
d6d100dd
SM
91762011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9177
9178 * window.h (Fwindow_frame): Declare.
9179
2b6148e4
PE
91802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9181
9182 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9183 (SPARE_MEMORY): Always define.
9184 (LARGE_REQUEST): Remove.
9185 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9186
f230ecc9
MR
91872011-06-06 Martin Rudalics <rudalics@gmx.at>
9188
727e958e
MR
9189 * lisp.h: Move EXFUNS for Fframe_root_window,
9190 Fframe_first_window and Fset_frame_selected_window to window.h.
9191
9192 * window.h: Move EXFUNS for Fframe_root_window,
9193 Fframe_first_window and Fset_frame_selected_window here from
9194 lisp.h.
9195
9196 * frame.c (Fwindow_frame, Fframe_first_window)
9197 (Fframe_root_window, Fframe_selected_window)
9198 (Fset_frame_selected_window): Move to window.c.
9199 (Factive_minibuffer_window): Move to minibuf.c.
9200 (Fother_visible_frames_p): New function.
9201
9202 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9203
f230ecc9
MR
9204 * window.c (decode_window, decode_any_window): Move up in code.
9205 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9206 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9207 (Fwindow_buffer): Move up and rewrite doc-string.
9208 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9209 (Fwindow_prev): New functions.
727e958e
MR
9210 (Fwindow_frame): Move here from frame.c. Accept any window as
9211 argument.
9212 (Fframe_root_window, Fframe_first_window)
9213 (Fframe_selected_window): Move here from frame.c. Accept frame
9214 or arbitrary window as argument. Update doc-strings.
9215 (Fminibuffer_window): Move up in code.
9216 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9217 (Fset_frame_selected_window): Move here from frame.c.
9218 Marginal rewrite.
727e958e
MR
9219 (Fselected_window, select_window, Fselect_window): Move up in
9220 code. Minor doc-string fixes.
f230ecc9 9221
4d09bcf6
PE
92222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9223
9224 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9225 Do not assume that spare memory exists; that assumption is valid
9226 only if SYSTEM_MALLOC.
9227 (LARGE_REQUEST): New macro, so that the issue of large requests
9228 is separated from the issue of spare memory.
9229
810928a2
AS
92302011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9231
172418ad
AS
9232 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9233 format. (Bug#8806)
9234
43f862f7
AS
9235 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9236
810928a2
AS
9237 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9238 before statements.
9239
a059fe24
JD
92402011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9241
9242 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9243
9244 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9245
9246 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9247 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9248
989bf368
JB
92492011-06-05 Juanma Barranquero <lekktu@gmail.com>
9250
9251 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9252
4b80f674
CY
92532011-06-04 Chong Yidong <cyd@stupidchicken.com>
9254
9255 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9256 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9257 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9258 New error handlers.
4b80f674
CY
9259 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9260 Obey Vx_select_enable_clipboard_manager. Catch errors in
9261 x_clipboard_manager_save (Bug#8779).
9262 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9263 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9264
99a33b77 92652011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9266
9267 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9268
99a33b77 92692011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9270
9271 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9272 in the current matrix if keep_current_p is non-zero.
9273
8264569d
EZ
92742011-06-04 Eli Zaretskii <eliz@gnu.org>
9275
9276 * bidi.c (bidi_level_of_next_char): Fix last change.
9277
57f97249
EZ
92782011-06-03 Eli Zaretskii <eliz@gnu.org>
9279
fec2107c 9280 Support bidi reordering of text covered by display properties.
57f97249 9281
fec2107c
EZ
9282 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9283 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9284 (bidi_cache_search, bidi_cache_iterator_state)
9285 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9286 (bidi_level_of_next_char, bidi_move_to_visually_next):
9287 Support character positions inside a run of characters covered by a
fec2107c
EZ
9288 display string.
9289 (bidi_paragraph_init, bidi_resolve_explicit_1)
9290 (bidi_level_of_next_char): Call bidi_fetch_char and
9291 bidi_fetch_char_advance instead of FETCH_CHAR and
9292 FETCH_CHAR_ADVANCE.
9293 (bidi_init_it): Initialize new members.
9294 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9295 definitions.
9296 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9297 instead of using explicit *_CHAR codes.
d6d100dd
SM
9298 (bidi_resolve_explicit, bidi_resolve_weak):
9299 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9300 bidirectional text is supported only in multibyte buffers.
9301 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9302 it to initialize the frame_window_p member of struct bidi_it.
9303 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9304 (bidi_resolve_explicit, bidi_resolve_weak)
9305 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9306 bidi_it->nchars is non-positive.
9307 (bidi_level_of_next_char): Don't try to lookup the cache for the
9308 next/previous character if nothing is cached there yet, or if we
9309 were just reseat()'ed to a new position.
c40e2fb2 9310
0e14fe90
EZ
9311 * xdisp.c (set_cursor_from_row): Set start and stop points
9312 according to the row's direction when priming the loop that looks
9313 for the glyph on which to display cursor.
9314 (single_display_spec_intangible_p): Function deleted.
9315 (display_prop_intangible_p): Reimplement to call
9316 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9317 Accept 3 additional arguments needed by handle_display_spec.
9318 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9319 values: lists, `(when COND...)' forms, etc.
9320 (single_display_spec_string_p): Support property values that are
9321 lists with the argument STRING its top-level element.
9322 (display_prop_string_p): Fix the condition for processing a
9323 property that is a list to be consistent with handle_display_spec.
fec2107c 9324 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9325 last portion of handle_display_prop.
9326 (compute_display_string_pos): Accept additional argument
9327 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9328 value of a `display' property is a "replacing spec".
9329 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9330 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9331 the display property, but just return a value indicating whether
9332 the display property will replace the characters it covers.
9333 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9334 frame_window_p members of struct bidi_it.
d6d100dd
SM
9335 (compute_display_string_pos, compute_display_string_end):
9336 New functions.
fec2107c
EZ
9337 (push_it): Accept second argument POSITION, where pop_it should
9338 jump to continue iteration.
9339 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9340
fec2107c
EZ
9341 * keyboard.c (adjust_point_for_property): Adjust the call to
9342 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9343
9344 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9345 (bidi_init_it): Update prototypes.
9346 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9347 (compute_display_string_pos, compute_display_string_end):
9348 Declare prototypes.
fec2107c
EZ
9349 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9350 EMACS_INT.
fc6f18ce 9351
40087514 93522011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9353
57f53182
PE
9354 Malloc failure behavior now depends on size of allocation.
9355 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9356 * lisp.h: Change signatures accordingly.
9357 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9358 All callers changed. (Bug#8762)
9359
9360 * gnutls.c: Use Emacs's memory allocators.
9361 Without this change, the gnutls library would invoke malloc etc.
9362 directly, which causes problems on non-SYNC_INPUT hosts, and which
9363 runs afoul of improving memory_full behavior. (Bug#8761)
9364 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9365 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9366 xfree instead of the default malloc, realloc, free.
9367 (Fgnutls_boot): No need to check for memory allocation failure,
9368 since xmalloc does that for us.
9369
ac32cd99 9370 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9371 * category.c (hash_get_category_set):
9372 * ccl.c (ccl_driver):
9373 * charset.c (Fdefine_charset_internal):
9374 * charset.h (struct charset.hash_index):
9375 * composite.c (get_composition_id, gstring_lookup_cache)
9376 (composition_gstring_put_cache):
9377 * composite.h (struct composition.hash_index):
9378 * dispextern.h (struct image.hash):
9379 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9380 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9381 (hashfn_equal, hashfn_user_defined, make_hash_table)
9382 (maybe_resize_hash_table, hash_lookup, hash_put)
9383 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9384 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9385 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9386 * image.c (make_image, search_image_cache, lookup_image)
9387 (xpm_put_color_table_h):
9388 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9389 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9390 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9391 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9392 * alloc.c (allocate_vectorlike):
9393 Check for overflow in vector size calculations.
9394 * ccl.c (ccl_driver):
9395 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9396 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9397 need to be updated by these changes.
40087514
PE
9398 * fns.c (make_hash_table, maybe_resize_hash_table):
9399 Check for integer overflow with large hash tables.
0de4bb68
PE
9400 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9401 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9402 (SXHASH_REDUCE): New macro.
9403 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9404 Use it instead of discarding useful hash info with large hash values.
9405 (sxhash_float): New function.
9406 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9407 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9408 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9409 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9410 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9411 Adjust signatures to match updated version of code.
9412 (consing_since_gc): Now EMACS_INT, since a single hash table can
9413 use more than INT_MAX bytes.
9414
698d32e2
DN
94152011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9416
9417 Make it possible to build with GCC-4.6+ -O2 -flto.
9418
9419 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9420
fd6fa53f
SM
94212011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9422
9423 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9424 Call minibuffer-inactive-mode.
9425
864db017
JB
94262011-05-31 Juanma Barranquero <lekktu@gmail.com>
9427
9428 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9429 Update dependencies.
9430
2ad0baf4
DN
94312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9432
9433 * data.c (init_data): Remove code for UTS, this system is not
9434 supported anymore.
9435
4fcc2638
DN
94362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9437
9438 Don't force ./temacs to start in terminal mode.
9439
9440 * frame.c (make_initial_frame): Initialize faces in all cases, not
9441 only when CANNOT_DUMP is defined.
9442 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9443
c56e0fd5
DN
94442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9445
9446 * dispnew.c (add_window_display_history): Use const for the string
9447 pointer. Remove declaration, not needed.
9448
333d54da 94492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9450
55d4c1b2 9451 Use 'inline', not 'INLINE'.
333d54da 9452 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9453 * alloc.c, fontset.c (INLINE): Remove.
9454 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9455 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9456 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9457 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9458 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9459
738db178
DN
94602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9461
9462 Make it possible to run ./temacs.
9463
9464 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9465 syms_of_callproc does the same thing. Remove test for
9466 "initialized", do it in the caller.
9467 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9468
620c53a6
SM
94692011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9470
9471 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9472 (read_minibuf): Use get_minibuffer.
9473 (syms_of_minibuf): Use DEFSYM.
9474 (Qmetadata): New var.
9475 * data.c (Qbuffer): Don't make it static.
9476 (syms_of_data): Use DEFSYM.
9477
e003a292
PE
94782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9479
9480 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9481 (CCL_CODE_MIN): New macro.
9482
ed008a6d
PE
94832011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9484
3687c2ef
PE
9485 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9486
ed008a6d
PE
9487 * eval.c (Qdebug): Now static.
9488 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9489 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9490 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9491
d66c4c7c
CY
94922011-05-29 Chong Yidong <cyd@stupidchicken.com>
9493
9494 * image.c: Various fixes to ImageMagick code comments.
9495 (Fimagemagick_types): Doc fix.
9496
5fbc2025
PE
94972011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9498
0196f88a
PE
9499 Minor fixes prompted by GCC 4.6.0 warnings.
9500
9501 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9502
5fbc2025
PE
9503 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9504 (x_clipboard_manager_save_all): Move extern decl to ...
9505 * xterm.h: ... here, so that it can be checked for consistency.
9506
1dd3c2d9
CY
95072011-05-29 Chong Yidong <cyd@stupidchicken.com>
9508
9509 * xselect.c (x_clipboard_manager_save_frame)
9510 (x_clipboard_manager_save_all): New functions.
9511 (Fx_clipboard_manager_save): Lisp function deleted.
9512
9513 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9514 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9515
9516 * xterm.h: Update prototype.
9517
5ba6571d
WX
95182011-05-28 William Xu <william.xwl@gmail.com>
9519
9520 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9521 exiting (Bug#8239).
9522
3eaff834
JM
95232011-05-28 Jim Meyering <meyering@redhat.com>
9524
e1900994 9525 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9526 * fns.c (to_uchar): Define.
9527 (crypto_hash_function): Use it to convert some newly-signed
9528 variables to unsigned, to avoid sign-extension bugs. For example,
9529 without this change, (md5 "truc") would evaluate to
9530 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9531 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9532 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9533
0f6990a7
PE
95342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9535
9536 Integer overflow fixes.
c8a9ca5a 9537
08686060
PE
9538 * dbusbind.c: Serial number integer overflow fixes.
9539 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9540 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9541 to hold a serial number that is too large for a fixnum.
9542 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9543 Check for serial numbers out of range. Decode any serial number
59568bf0 9544 that was so large that it became a float. (Bug#8722)
08686060 9545
2d1fc3c7
PE
9546 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9547 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9548 Use XFASTINT rather than XUINT when numbers are nonnegative.
9549 (xd_append_arg, Fdbus_method_return_internal):
9550 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9551 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9552 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9553 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9554 (Bug#8722)
2d1fc3c7 9555
c8a9ca5a
PE
9556 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9557
519e1d69
PE
9558 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9559
6df6ae42 9560 ccl: Add integer overflow checks.
30569699
PE
9561 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9562 (IN_INT_RANGE): New macros.
9563 (ccl_driver): Use them to check for integer overflow when
9564 decoding a CCL program. Many of the new checks are whether XINT (x)
9565 fits in int; it doesn't always, on 64-bit hosts. The new version
9566 doesn't catch all possible integer overflows, but it's an
847044ea 9567 improvement. (Bug#8719)
30569699 9568
c11285dc
PE
9569 * alloc.c (make_event_array): Use XINT, not XUINT.
9570 There's no need for unsigned here.
9571
fdccd48e
PE
9572 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9573 This follows up to the 2011-05-06 change that substituted uintptr_t
9574 for EMACS_INT. This case wasn't caught back then.
9575
37910ab2
PE
9576 Rework Fformat to avoid integer overflow issues.
9577 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9578 now (part of C89). Include <verify.h>.
9579 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9580 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9581 (Fformat): Avoid the prepass trying to compute sizes; it was only
9582 approximate and thus did not catch overflow reliably. Instead, walk
9583 through the format just once, formatting and computing sizes as we go,
9584 checking for integer overflow at every step, and allocating a larger
9585 buffer as needed. Keep track separately whether the format is
9586 multibyte. Keep only the most-recently calculated precision, rather
9587 than them all. Record whether each argument has been converted to
9588 string. Use EMACS_INT, not int, for byte and char and arg counts.
9589 Support field widths and precisions larger than INT_MAX. Avoid
9590 sprintf's undefined behavior with conversion specifications such as %#d
9591 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9592 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9593 formatting out-of-range floating point numbers with int
9173deec 9594 formats. (Bug#8668)
37910ab2 9595
2e6578fb
PE
9596 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9597
0ae6bdee
PE
9598 * data.c: Avoid integer truncation in expressions involving floats.
9599 * data.c: Include <intprops.h>.
9600 (arith_driver): When there's an integer overflow in an expression
9601 involving floating point, convert the integers to floating point
9602 so that the resulting value does not suffer from catastrophic
9603 integer truncation. For example, on a 64-bit host (* 4
9604 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9605 Do not rely on undefined behavior after integer overflow.
9606
de883a70
PE
9607 merge count_size_as_multibyte, parse_str_to_multibyte
9608 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9609 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9610 Check for integer overflow.
9611 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9612 since it's now a duplicate of the other. This is more of
9613 a character than a buffer op, so better that it's in character.c.
9614 * fns.c, print.c: Adjust to above changes.
9615
2ff916cb
PE
96162011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9617
9618 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9619
f1b54466
PE
96202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9621
fb1ac845
PE
9622 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9623 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9624 (x_clipboard_manager_save): Now static.
9625 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9626
f1b54466
PE
9627 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9628 (crypto_hash_function): Now static.
9629 Fix pointer signedness problems. Avoid unnecessary initializations.
9630
a9f737ee
CY
96312011-05-27 Chong Yidong <cyd@stupidchicken.com>
9632
9633 * termhooks.h (Vselection_alist): Make it terminal-local.
9634
9635 * terminal.c (create_terminal): Initialize it.
9636
9637 * xselect.c: Support for clipboard managers.
9638 (Vselection_alist): Move to termhooks.h as terminal-local var.
9639 (LOCAL_SELECTION): New macro.
9640 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9641 (symbol_to_x_atom): Remove gratuitous arg.
9642 (x_handle_selection_request, lisp_data_to_selection_data)
9643 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9644 (x_own_selection, x_get_local_selection, x_convert_selection):
9645 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9646 (some_frame_on_display): Delete unused function.
9647 (Fx_own_selection_internal, Fx_get_selection_internal)
9648 (Fx_disown_selection_internal, Fx_selection_owner_p)
9649 (Fx_selection_exists_p): New optional frame arg.
9650 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9651 (x_handle_selection_clear): Don't treat other terminals with the
9652 same keyboard specially. Use the terminal-local Vselection_alist.
9653 (x_clear_frame_selections): Use Frun_hook_with_args.
9654
9655 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9656
9657 * xterm.h: Add support for those atoms.
9658
e067f0c1
CY
96592011-05-26 Chong Yidong <cyd@stupidchicken.com>
9660
9661 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9662 (converted_selections, conversion_fail_tag): New global variables.
9663 (x_selection_request_lisp_error): Free the above.
9664 (x_get_local_selection): Remove unnecessary code.
9665 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9666 of converted selections stored in converted_selections.
9667 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9668 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9669 (x_convert_selection): New function.
9670 (x_handle_selection_event): Simplify.
9671 (x_get_foreign_selection): Don't ignore incoming requests while
9672 waiting for an answer; this will fail when we implement
9673 SAVE_TARGETS, and seems unnecessary anyway.
9674 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9675 (Vx_sent_selection_functions): Doc fix.
9676
0f4aebc0
LL
96772011-05-26 Leo Liu <sdl.web@gmail.com>
9678
9679 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9680
e61124cd
YM
96812011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9682
9683 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9684
9685 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9686 for fringe update if it has periodic bitmap.
ac389d0c 9687 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9688 and fringe_bitmap_periodic_p.
9689
9690 * fringe.c (get_fringe_bitmap_data): New function.
9691 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9692 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9693 row. Mark glyph row for fringe update if periodicity changed.
9694
9695 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9696 for fringe update unless it has periodic bitmap.
9697
f16d9837
KH
96982011-05-25 Kenichi Handa <handa@m17n.org>
9699
9700 * xdisp.c (get_next_display_element): Set correct it->face_id for
9701 a static composition.
9702
e1b90ef6
LL
97032011-05-24 Leo Liu <sdl.web@gmail.com>
9704
9705 * deps.mk (fns.o):
9706 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9707
9708 * fns.c (crypto_hash_function, Fsha1): New function.
9709 (Fmd5): Use crypto_hash_function.
9710 (syms_of_fns): Add Ssha1.
9711
7400048f
PE
97122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9713
9714 * gnutls.c: Remove unused macros.
9715 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9716 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9717 Remove macros that are defined and never used.
9718 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9719
abb71cf4
CY
97202011-05-22 Chong Yidong <cyd@stupidchicken.com>
9721
9722 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9723 (Fx_get_selection_internal): Minor cleanup.
9724 (Fx_own_selection_internal): Rename arguments for consistency with
9725 select.el.
9726
6307db39
PE
97272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9728
9729 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9730
f3d4e0a4
CY
97312011-05-22 Chong Yidong <cyd@stupidchicken.com>
9732
9733 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9734
4d8ade89
YM
97352011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9736
9737 * dispnew.c (scrolling_window): Don't exclude the case that the
9738 last enabled row in the desired matrix touches the bottom boundary.
9739
32078c8d
GM
97402011-05-21 Glenn Morris <rgm@gnu.org>
9741
9742 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9743 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9744 and add some more files.
32078c8d 9745
7285dc67
EZ
97462011-05-20 Eli Zaretskii <eliz@gnu.org>
9747
9748 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9749 report_file_error introduced by the change from 2011-05-07.
9750
89d1bd22
PE
97512011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9752
9753 * systime.h (Time): Define only if emacs is defined.
9754 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9755 where the include path doesn't have X11/X.h by default. See
9756 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9757
cd394be1 97582011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9759
9760 * composite.c (find_automatic_composition): Fix previous change.
9761
b9704ad9
GM
97622011-05-20 Glenn Morris <rgm@gnu.org>
9763
9764 * lisp.mk: New file, split from Makefile.in.
9765 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9766 (shortlisp): Remove.
9767 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9768
4a720484
GM
97692011-05-19 Glenn Morris <rgm@gnu.org>
9770
9771 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9772 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9773 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9774 (lisp): Set the order to that of loadup.el.
9775 (shortlisp): Make it a copy of $lisp.
9776 (SOME_MACHINE_LISP): Remove.
9777 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9778 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9779
a28d4396
KH
97802011-05-18 Kenichi Handa <handa@m17n.org>
9781
9782 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9783 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9784 (find_automatic_composition): Mostly rewrite for efficiency.
9785
a2b1fa8e
JB
97862011-05-18 Juanma Barranquero <lekktu@gmail.com>
9787
9788 * makefile.w32-in: Update dependencies.
9789
8e1f5610
CS
97902011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9791
9792 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9793 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9794
7025ee00 97952011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9796
cdfa6eab
PE
9797 Fix some integer overflow issues, such as string length overflow.
9798
06d6db33
PE
9799 * insdel.c (count_size_as_multibyte): Check for string overflow.
9800
2b4560a8
PE
9801 * character.c (lisp_string_width): Check for string overflow.
9802 Use EMACS_INT, not int, for string indexes and lengths; in
9803 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9804 the resulting string length overflows an EMACS_INT; instead,
9805 report a string overflow if no precision given. When checking for
9806 precision exhaustion, use a check that cannot possibly have
9807 integer overflow. (Bug#8675)
9808 * character.h (lisp_string_width): Adjust to new signature.
9809
cb93f9be
PE
9810 * alloc.c (string_overflow): New function.
9811 (Fmake_string): Use it. This doesn't change behavior, but saves
9812 a few bytes and will simplify future changes.
9813 * character.c (string_escape_byte8): Likewise.
9814 * lisp.h (string_overflow): New decl.
9815
1a1f3366
PE
9816 Fixups, following up to the user-interface timestamp change.
9817 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9818 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9819 * msdos.c (mouse_get_pos): Likewise.
9820 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9821 * w32gui.h (Time): Define by including "systime.h" rather than by
9822 declaring it ourselves. (Bug#8664)
9823
d4e3e4d3
PE
9824 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9825 * image.c (clear_image_cache): Likewise.
9826
f6a24d19
PE
9827 * term.c (term_mouse_position): Don't assume time_t wraparound.
9828
08dc5ae6
PE
9829 Be more systematic about user-interface timestamps.
9830 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9831 and sometimes 'EMACS_UINT', to represent these timestamps.
9832 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9833 This makes the code easier to follow, and makes it easier to catch
9834 integer overflow bugs such as Bug#8664.
9835 * frame.c (Fmouse_position, Fmouse_pixel_position):
9836 Use Time, not unsigned long, for user-interface timestamps.
9837 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9838 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9839 * keyboard.h (last_event_timestamp): Likewise.
9840 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9841 * menu.h (xmenu_show): Likewise.
9842 * term.c (term_mouse_position): Likewise.
9843 * termhooks.h (struct input_event.timestamp): Likewise.
9844 (struct terminal.mouse_position_hook): Likewise.
9845 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9846 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9847 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9848 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9849 what it was before.
9850 * menu.h, termhooks.h: Include "systime.h", for Time.
9851
8e55734a
PE
9852 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9853 Don't assume that the difference between two unsigned long values
9854 can fit into an integer. At this point, we know button_down_time
9855 <= event->timestamp, so the difference must be nonnegative, so
9856 there's no need to cast the result if double-click-time is
9857 nonnegative, as it should be; check that it's nonnegative, just in
9858 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9859 apart (about 25 days). (Bug#8664)
8e55734a 9860
841f1b75 9861 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9862 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9863
3e26f69c
PE
9864 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9865 that always fit in int. Use a sentinel instead of a counter, to
9866 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9867 * frame.h (struct frame): Use int for menu_bar_items_used
9868 instead of EMACS_INT, since it always fits in int.
3e26f69c 9869
5cc152c0
PE
9870 * menu.c (grow_menu_items): Check for int overflow.
9871
d89eb65e
PE
9872 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9873
5235bd3e
PE
9874 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9875 Before, the code was not consistent. These values cannot exceed
9876 2**31 - 1 so there's no need to make them unsigned.
9877 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9878 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9879 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9880 as modifiers.
9881 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9882
bc827e23
PE
9883 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9884 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9885 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9886 presumably because the widths might not match.
9887
78eb494e
PE
9888 * window.c (size_window): Avoid needless test at loop start.
9889
04f2d78b
CB
98902011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9891
9892 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9893
d2fc7e3d 98942011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9895
9896 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9897
d2fc7e3d 98982011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9899
9900 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9901 `width' to `bar_area_x' and `bar_area_width', respectively.
9902 (x_scroll_run): Take account of fringe background extension.
9903
04f2d78b
CB
9904 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9905 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9906 `bar_area_width', respectively.
9907 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9908 background extension.
9909
79b70037
GM
99102011-05-10 Jim Meyering <meyering@redhat.com>
9911
9912 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9913
2f142cc5
JB
99142011-05-10 Juanma Barranquero <lekktu@gmail.com>
9915
9916 * image.c (Finit_image_library): Return t for built-in image types,
9917 like pbm and xbm. (Bug#8640)
9918
57679c86
AS
99192011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9920
9921 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9922
888c9e86
EZ
99232011-05-07 Eli Zaretskii <eliz@gnu.org>
9924
b0512a1d
EZ
9925 * w32console.c (Fset_screen_color): Doc fix.
9926 (Fget_screen_color): New function.
9927 (syms_of_ntterm): Defsubr it.
9928
7285dc67
EZ
9929 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9930 unlink the temporary file if Fcall_process didn't create it in the
9931 first place.
9932 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9933 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9934 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9935 cue to call_process_cleanup not to close that handle.
9936
4d3fcc8e
BK
99372011-05-07 Ben Key <bkey76@gmail.com>
9938
9939 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9940 one of two shell specific rules, either bootstrap-temacs-CMD or
9941 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9942 to the previous implementation of the bootstrap-temacs rule.
9943 The bootstrap-temacs-CMD rule is similar to the previous
9944 implementation of the bootstrap-temacs rule except that it
9945 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9946 variable.
9947
9948 These changes, along with some changes to nt/configure.bat,
9949 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9950 earlier fix to add support for --cflags and --ldflags options
9951 that include quotes so that it works whether make uses cmd or
9952 sh as the shell.
9953
b4289b64
MA
99542011-05-06 Michael Albinus <michael.albinus@gmx.de>
9955
9956 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9957 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9958 is a constant.
9959 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9960 a string. Handle both cases.
9961 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9962 (Fdbus_register_method): Use Qinvalid_function.
9963
af4c0e28
JB
99642011-05-06 Juanma Barranquero <lekktu@gmail.com>
9965
9966 * makefile.w32-in: Update dependencies.
9967 (LISP_H): Add inttypes.h and stdin.h.
9968 (PROCESS_H): Add unistd.h.
9969
c51453d9
EZ
99702011-05-06 Eli Zaretskii <eliz@gnu.org>
9971
9972 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9973 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9974
8ff0ac3c 99752011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9976
4c4b566b
PE
9977 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9978
aab2b9b5
PE
9979 * term.c (vfatal): Remove stray call to va_end.
9980 It's not needed and the C Standard doesn't allow it here anyway.
9981
c378da0b
PE
9982 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9983 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9984
288b08c7
PE
9985 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9986 bytes.
9987
e3601888
PE
9988 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9989
db6c0e74
PE
9990 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9991
dd5963ea
PE
9992 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9993
88c9450f
PE
9994 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9995
2f9442b8
PE
9996 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9997
c032b5f8
PE
9998 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9999 * charset.c (Fdefine_charset_internal): Don't initialize
10000 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10001 32-bit int (Bug#8600).
a108c10b
PE
10002
10003 * lread.c (read_integer): Be more consistent with string-to-number.
10004 Use string_to_number to do the actual conversion; this avoids
10005 rounding errors and fixes some other screwups. Without this fix,
10006 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10007 (digit_to_number): Move earlier, for benefit of read_integer.
10008 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10009 not a digit in any supported base. (Bug#8602)
a108c10b 10010
ad5f9eea
PE
10011 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10012
aec1708a
PE
10013 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10014 to match comment at start of function. This also removes a
10015 GCC warning about overflow in a 32+64-bit port.
10016
47be4ab5
PE
10017 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10018
371cac43
PE
10019 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10020 Reported by Stefan Monnier in
10021 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10022 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10023 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10024
d01a7826
PE
10025 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10026 (EMACS_UINTPTR): Likewise, with uintptr_t.
10027
7fd47d5c
PE
10028 * lisp.h: Prefer 64-bit EMACS_INT if available.
10029 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10030 on 32-bit hosts that have 64-bit int, so that they can access
10031 large files.
122b0c86
PE
10032 However, temporarily disable this change unless the temporary
10033 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10034
8727937b
PE
10035 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10036
8ac068ac
PE
10037 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10038 This removes an assumption that EMACS_INT and long are the same
10039 width as pointers. The assumption is true for Emacs porting targets
10040 now, but we want to make other targets possible.
10041 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10042 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10043 In the rest of the code, change types of integers that hold casted
10044 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10045 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10046 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10047 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10048 No need to cast type when ORing.
10049 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10050 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10051 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10052 assume EMACS_INT is the same width as char *.
10053 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10054 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10055 Remove no-longer-needed casts.
10056 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10057 (xg_tool_bar_help_callback, xg_make_tool_item):
10058 Use EMACS_INTPTR to hold an integer
10059 that will be cast to void *; this can avoid a GCC warning
10060 if EMACS_INT is not the same width as void *.
10061 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10062 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10063 (current_message_1, set_message_1):
10064 Use a local to convert to proper width without a cast.
10065 * xmenu.c (dialog_selection_callback): Likewise.
10066
ede49d71
PE
10067 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10068 Also, don't assume VALBITS / RAND_BITS is less than 5,
10069 and don't rely on undefined behavior when shifting a 1 left into
10070 the sign bit.
10071 * lisp.h (get_random): Change signature to match.
10072
2f30ecd0
PE
10073 * lread.c (hash_string): Use size_t, not int, for hash computation.
10074 Normally we prefer signed values; but hashing is special, because
10075 it's better to use unsigned division on hash table sizes so that
10076 the remainder is nonnegative. Also, size_t is the natural width
10077 for hashing into memory. The previous code used 'int', which doesn't
10078 retain enough info to hash well into very large tables.
10079 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10080
2a866e7b
PE
10081 * dbusbind.c: Don't possibly lose pointer info when converting.
10082 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10083 Use XPNTR rather than XHASH, so that the high-order bits of
10084 the pointer aren't lost when converting through void *.
10085
51639eac
PE
10086 * eval.c (Fautoload): Don't double-shift a pointer.
10087
92394119
PE
10088 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10089
dbdb9a7c
JB
100902011-05-06 Juanma Barranquero <lekktu@gmail.com>
10091
10092 * gnutls.c (DEF_GNUTLS_FN):
10093 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10094
db7a0b4f
AS
100952011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10096
10097 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10098 marker. (Bug#8610)
10099
cd394be1 101002011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10101
10102 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10103 New version that can reserve upto 2GB of heap space.
10104
f7ff1b0f 101052011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10106
10107 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10108
639c109b
TZ
101092011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10110
10111 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10112 `gnutls_certificate_set_x509_key_file'.
10113
d2127135
JB
101142011-05-05 Juanma Barranquero <lekktu@gmail.com>
10115
10116 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10117 Update dependencies.
10118
e968f4f3
JB
101192011-05-04 Juanma Barranquero <lekktu@gmail.com>
10120
10121 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10122 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10123 Remove unused parameter `fildes'.
10124 * process.c (read_process_output, send_process): Don't pass it.
10125
84d358f0
JB
101262011-05-04 Juanma Barranquero <lekktu@gmail.com>
10127
10128 Fix previous change: the library cache is defined in w32.c.
10129 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10130 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10131
0898ca10
JB
101322011-05-04 Juanma Barranquero <lekktu@gmail.com>
10133
10134 Implement dynamic loading of GnuTLS on Windows.
10135
10136 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10137 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10138 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10139 Declare.
10140
10141 * gnutls.c (Qgnutls_dll): Define.
10142 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10143 (gnutls_*): Declare function pointers.
10144 (init_gnutls_functions): New function to initialize function pointers.
10145 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10146 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10147 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10148 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10149 (emacs_gnutls_write, emacs_gnutls_read)
10150 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10151 (Fgnutls_available_p): New function.
10152 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10153 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10154 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10155
10156 * image.c: Include w32.h.
10157 (Vimage_type_cache): Delete.
10158 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10159 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10160 (w32_delayed_load): Move to w32.c.
10161
10162 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10163
10164 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10165 (w32_delayed_load): Move from image.c. When loading a library, record
10166 its filename in the :loaded-from property of the library id.
10167 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10168 Initialize and staticpro them.
10169 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10170
10171 * process.c: Include lisp.h before w32.h, not after.
10172 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10173 instead of gnutls_record_check_pending.
10174
10175 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10176
ff4de4aa
TZ
101772011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10178
10179 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10180 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10181 as passed in.
10182
abe95abb
JD
101832011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10184
10185 * xterm.c (x_set_frame_alpha): Do not set property on anything
10186 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10187
e16e55d4
JB
101882011-05-02 Juanma Barranquero <lekktu@gmail.com>
10189
10190 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10191
bafcf6a5
JB
101922011-05-02 Juanma Barranquero <lekktu@gmail.com>
10193
10194 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10195 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10196 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10197 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10198 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10199 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10200 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10201 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10202 (Qgnutls_bootprop_callbacks_verify): Make static.
10203
e7a6747f
AS
102042011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10205
19ed11ba
AS
10206 * callproc.c: Indentation fixup.
10207
e7a6747f 10208 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10209 (wait_for_termination, interruptible_wait_for_termination):
10210 Move after wait_for_termination_1.
e7a6747f 10211
1ef14cb4
LMI
102122011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10213
10214 * sysdep.c (interruptible_wait_for_termination): New function
10215 which is like wait_for_termination, but allows keyboard
10216 interruptions.
10217
10218 * callproc.c (Fcall_process): Add (:file "file") as an option for
10219 the STDOUT buffer.
10220 (Fcall_process_region): Ditto.
10221
330d880c
EZ
102222011-04-30 Eli Zaretskii <eliz@gnu.org>
10223
8db90b73
EZ
10224 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10225 rather than `XVECTOR (FOO)->size'.
10226
330d880c
EZ
10227 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10228 inttypes.h, as a gnulib replacement is used if it not available in
10229 system headers.
10230
15cbd324
EZ
102312011-04-21 Eli Zaretskii <eliz@gnu.org>
10232
10233 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10234 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10235 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10236
10237 * coding.c (coding_alloc_by_realloc): Error out if destination
10238 will grow beyond MOST_POSITIVE_FIXNUM.
10239 (decode_coding_emacs_mule): Abort if there isn't enough place in
10240 charbuf for the composition carryover bytes. Reserve an extra
10241 space for up to 2 characters produced in a loop.
10242 (decode_coding_iso_2022): Abort if there isn't enough place in
10243 charbuf for the composition carryover bytes.
10244
102452011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10246
ae940cca
EZ
10247 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10248 aborting when %lld or %lll format is passed.
10249 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10250 %llo or %llx format is passed. (Bug#8545)
10251
03ab8921
EZ
10252 * window.c (window_scroll_line_based): Use a marker instead of
10253 simple variables to record original value of point. (Bug#7952)
10254
afda1437
EZ
10255 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10256 produced by %s or %c overflows available buffer space. (Bug#8545)
10257
f76dee0c
PE
102582011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10259
10260 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10261 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10262
fdc5744d
JB
102632011-04-28 Juanma Barranquero <lekktu@gmail.com>
10264
10265 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10266
638f053a
JB
102672011-04-28 Juanma Barranquero <lekktu@gmail.com>
10268
10269 * keyboard.c (Qdelayed_warnings_hook): Define.
10270 (command_loop_1): Run `delayed-warnings-hook'
10271 if Vdelayed_warnings_list is non-nil.
10272 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10273 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10274
d178f871
EZ
102752011-04-28 Eli Zaretskii <eliz@gnu.org>
10276
10277 * doprnt.c (doprnt): Don't return value smaller than the buffer
10278 size if the message was truncated. (Bug#8545).
10279
b124fd93
JB
102802011-04-28 Juanma Barranquero <lekktu@gmail.com>
10281
10282 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10283 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10284
e810457d
PE
102852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10286
10287 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10288
ea51cceb
JB
102892011-04-27 Juanma Barranquero <lekktu@gmail.com>
10290
10291 * makefile.w32-in: Update dependencies.
10292
94dcfacf
EZ
102932011-04-27 Eli Zaretskii <eliz@gnu.org>
10294
10295 Improve `doprnt' and its usage. (Bug#8545)
10296 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10297 `format_end'. Remove support for %l as a conversion specifier.
10298 Don't use xrealloc. Improve diagnostics when the %l size modifier
10299 is used. Update the commentary.
10300
10301 * eval.c (verror): Simplify calculation of size_t.
10302
10303 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10304 messages.
10305
f61f41d7
PE
103062011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10307
10308 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10309 change.
10310
96fb4434
PE
103112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10312
10313 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10314 This makes this file independent of the recent pseudovector change.
10315
671875da 103162011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10317
69e9b5a3
PE
10318 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10319
b5f869a7 10320 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10321 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10322 Remove unused local.
c8926152 10323 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10324
841a1577 10325 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10326 GCC 4.6.0 optimizes based on type-based alias analysis.
10327 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10328 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10329 != &v->size, and therefore "v->size = 1; b->size = 2; return
10330 v->size;" must therefore return 1. This assumption is incorrect
10331 for Emacs, since it type-puns struct Lisp_Vector * with many other
10332 types. To fix this problem, this patch adds a new type struct
f904488f 10333 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10334 and pseudovectors, and helps optimizing compilers not get fooled
10335 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10336 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10337 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10338 the size member.
eab3844f
PE
10339 (XSETPVECTYPE): Rewrite in terms of new macro.
10340 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10341 This is a bit clearer, and further avoids the possibility of
10342 undesirable aliasing.
10343 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10344 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10345 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10346 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10347 (ASIZE): Now uses header.size rather than size.
10348 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10349 to avoid the hassle of writing XVECTOR (foo)->header.size.
10350 (struct vectorlike_header): New type.
eab3844f
PE
10351 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10352 object, to help avoid aliasing.
10353 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10354 (SUBRP): Likewise, since Lisp_Subr is a special case.
10355 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10356 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10357 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10358 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10359 changed to be "header.size" and "header.next".
10360 * buffer.h (struct buffer): Likewise.
10361 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10362 * frame.h (struct frame): Likewise.
10363 * process.h (struct Lisp_Process): Likewise.
10364 * termhooks.h (struct terminal): Likewise.
10365 * window.c (struct save_window_data, struct saved_window): Likewise.
10366 * window.h (struct window): Likewise.
10367 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10368 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10369 * buffer.c (init_buffer_once): Likewise.
10370 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10371 special case.
10372 * process.c (Fformat_network_address): Use local var for size,
10373 for brevity.
10374
0df1eac5
PE
10375 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10376
847ab9d1 10377 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10378 * data.c (atof): Remove decl; no longer used or needed.
10379 (digit_to_number): Move to lread.c.
10380 (Fstring_to_number): Use new string_to_number function, to be
10381 consistent with how the Lisp reader treats infinities and NaNs.
10382 Do not assume that floating-point numbers represent EMACS_INT
10383 without losing information; this is not true on most 64-bit hosts.
10384 Avoid double-rounding errors, by insisting on integers when
10385 parsing non-base-10 numbers, as the documentation specifies.
10386 * lisp.h (string_to_number): New decl, replacing ...
10387 (isfloat_string): Remove.
bc0a5c13 10388 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10389 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10390 appears to have been a coding error. Similarly, do not accept
10391 strings like +-1e0 as floating point numbers. Do not report
10392 overflow for integer overflows unless the base is not 10 which
10393 means we have no simple and reliable way to continue.
10394 Break out the floating-point parsing into a new
10395 function string_to_number, so that Fstring_to_number parses
10396 floating point numbers consistently with the Lisp reader.
04f2d78b 10397 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10398 (E_CHAR, EXP_INT): Remove, replacing with ...
10399 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10400 (string_to_number): New function, replacing isfloat_string.
10401 This function checks for valid syntax and produces the resulting
10402 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10403 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10404 so that overflow for non-base-10 numbers is reported only when
10405 there's no portable and simple way to convert to floating point.
452f4150 10406
67769ffc
PE
10407 * textprop.c (set_text_properties_1): Rewrite for clarity,
10408 and to avoid GCC warning about integer overflow.
10409
c20db43f
PE
10410 * intervals.h (struct interval): Use EMACS_INT for members
10411 where EMACS_UINT might cause problems. See
10412 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10413 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10414 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10415 All uses changed.
37aa2f85
PE
10416 (offset_intervals): Tell GCC not to worry about length overflow
10417 when negating a negative length.
c20db43f 10418
2538aa2f
PE
10419 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10420 (overrun_check_free): Likewise.
10421
f2d3008d
PE
10422 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10423 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10424 word size.
10425
ec8df744
PE
10426 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10427 (gnutls_make_error): Rename local to avoid shadowing.
10428 (gnutls_emacs_global_deinit): ifdef out; not used.
10429 (Fgnutls_boot): Use const for pointer to readonly storage.
10430 Comment out unused local. Fix pointer signedness problems.
10431
640ee02d
PE
10432 * lread.c (openp): Don't stuff size_t into an 'int'.
10433 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10434 about possible signed overflow.
10435
6048fb2a
PE
10436 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10437 (GDK_KEY_g): Don't define if already defined.
10438 (xg_prepare_tooltip): Avoid pointer signedness problem.
10439 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10440
fa3c87e1
PE
10441 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10442 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10443
2172544b
PE
10444 * xfns.c (Fx_window_property): Simplify a bit,
10445 to make a bit faster and to avoid GCC 4.6.0 warning.
10446 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10447
9b821a21
PE
10448 * fns.c (internal_equal): Don't assume size_t fits in int.
10449
3c616cfa
PE
10450 * alloc.c (compact_small_strings): Tighten assertion a little.
10451
c2982e87
PE
10452 Replace pEd with more-general pI, and fix some printf arg casts.
10453 * lisp.h (pI): New macro, generalizing old pEd macro to other
10454 conversion specifiers. For example, use "...%"pI"d..." rather
10455 than "...%"pEd"...".
10456 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10457 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10458 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10459 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10460 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10461 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10462 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10463 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10464 64-bit hosts.
10465 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10466 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10467 * print.c (safe_debug_print, print_object): Likewise.
10468 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10469 to int.
6f04d126
PE
10470 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10471 avoiding the 0 flag, which is not portable.
c2982e87
PE
10472 * process.c (Fmake_network_process): Use pI to avoid cast.
10473 * region-cache.c (pp_cache): Likewise.
10474 * xdisp.c (decode_mode_spec): Likewise.
10475 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10476 behavior on 64-bit hosts with printf arg.
6f04d126 10477 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10478 (x_stop_queuing_selection_requests): Likewise.
10479 (x_get_window_property): Don't truncate byte count to an 'int'
10480 when tracing.
0b432f21 10481
5e073ec7
PE
10482 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10483 here, since it parses constructs like leading '-' and spaces,
10484 which are not wanted; and it overflows with large numbers.
10485 Instead, simply match F[0-9]+, which is what is wanted anyway.
10486
36372bf9
PE
10487 * alloc.c: Remove unportable assumptions about struct layout.
10488 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10489 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10490 (allocate_vectorlike, make_pure_vector): Use the new macros,
10491 plus offsetof, to remove unportable assumptions about struct layout.
10492 These assumptions hold on all porting targets that I know of, but
10493 they are not guaranteed, they're easy to remove, and removing them
10494 makes further changes easier.
10495
0b432f21
PE
10496 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10497 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10498 (string_overrun_cookie): Now const. Use initializers that
10499 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10500 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10501 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10502 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10503 multiple of sizeof (EMACS_INT); it need not be, if
10504 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10505 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10506
895009e1
JB
105072011-04-26 Juanma Barranquero <lekktu@gmail.com>
10508
10509 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10510
6a7a1b0b
TZ
105112011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10512
10513 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10514 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10515 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10516
841a1577 105172011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10518
10519 * lisp.h (Qdebug): List symbol.
895009e1 10520 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10521 * keyboard.c (debug-on-event): New variable.
10522 (handle_user_signal): Break into debugger when debug-on-event
10523 matches the current signal symbol.
10524
f2d3ba6f
DN
105252011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10526
10527 * alloc.c (check_sblock, check_string_bytes)
10528 (check_string_free_list): Convert to standard C.
10529
42ce4c63
TZ
105302011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10531
10532 * w32.c (emacs_gnutls_push): Fix typo.
10533
825cd63c
EZ
105342011-04-25 Eli Zaretskii <eliz@gnu.org>
10535
fb11d64d
EZ
10536 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10537 "cast to pointer from integer of different size".
10538
825cd63c
EZ
10539 Improve doprnt and its use in verror. (Bug#8545)
10540 * doprnt.c (doprnt): Document the set of format control sequences
10541 supported by the function. Use SAFE_ALLOCA instead of always
10542 using `alloca'.
10543
10544 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10545 is one byte too soon. Don't use xrealloc; instead xfree and
10546 xmalloc anew.
10547
e061a11b
TZ
105482011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10549
10550 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10551 callbacks stage.
10552
10553 * gnutls.c: Renamed global_initialized to
10554 gnutls_global_initialized. Added internals for the
10555 :verify-hostname-error, :verify-error, and :verify-flags
10556 parameters of `gnutls-boot' and documented those parameters in the
10557 docstring. Start callback support.
9173deec
JB
10558 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10559 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10560 on error. Return error code.
e061a11b
TZ
10561 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10562 (emacs_gnutls_read): Likewise.
10563 (Fgnutls_boot): Return handshake error code.
10564 (emacs_gnutls_handle_error): New function.
10565 (wsaerror_to_errno): Likewise.
10566
10567 * w32.h (emacs_gnutls_pull): Add prototype.
10568 (emacs_gnutls_push): Likewise.
10569
10570 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10571 (emacs_gnutls_push): Likewise.
10572
105732011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10574
10575 * process.c (wait_reading_process_output): Check if GnuTLS
10576 buffered some data internally if no FDs are set for TLS
10577 connections.
10578
10579 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10580 (LIBS): Link to USER_LIBS.
10581 ($(BLD)/gnutls.$(0)): New target.
10582
fa6996bc
EZ
105832011-04-24 Eli Zaretskii <eliz@gnu.org>
10584
eb35682e
EZ
10585 * xdisp.c (handle_single_display_spec): Rename the
10586 display_replaced_before_p argument into display_replaced_p, to
10587 make it consistent with the commentary. Fix typos in the
10588 commentary.
10589
e2ad650c
EZ
10590 * textprop.c (syms_of_textprop): Remove dead code.
10591 (copy_text_properties): Delete obsolete commentary about an
10592 interface that was deleted long ago. Fix typos in the description
10593 of arguments.
10594
1b2de274
EZ
10595 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10596 to changes in oldXMenu/XMenu.h from 2011-04-16.
10597 <menu_help_message, prev_menu_help_message>: Constify.
10598 (IT_menu_make_room): menu->help_text is now `const char **';
10599 adjust.
10600
10601 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10602 to changes in oldXMenu/XMenu.h from 2011-04-16.
10603 (struct XMenu): Declare `help_text' `const char **'.
10604
10605 * xfaces.c <Qunspecified>: Make extern again.
10606
10607 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10608 required by POSIX.
1b2de274 10609
762b15be
EZ
10610 * doc.c (get_doc_string): Improve the format passed to `error'.
10611
10612 * doprnt.c (doprnt): Improve commentary.
10613
10614 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10615
10616 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10617 them with etags.
10618
f1052e5d
EZ
10619 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10620 changes in globals.h immediately force recompilation.
762b15be
EZ
10621 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10622 $(CURDIR)/s/ms-w32.h.
10623 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10624
fa6996bc
EZ
10625 * character.c (Fchar_direction): Function deleted.
10626 (syms_of_character): Don't defsubr it.
10627 <char-direction-table>: Deleted.
10628
e6c3da20
EZ
106292011-04-23 Eli Zaretskii <eliz@gnu.org>
10630
10631 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10632 * doprnt.c: Include limits.h.
10633 (SIZE_MAX): New macro.
04f2d78b
CB
10634 (doprnt): Return a size_t value. 2nd arg is now size_t.
10635 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10636 Improve overflow protection. Support `l' modifier for integer
10637 conversions. Support %l conversion. Don't assume an EMACS_INT
10638 argument for integer conversions and for %c.
10639
10640 * lisp.h (doprnt): Restore prototype.
10641
10642 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10643 $(SRC)/character.h.
10644
10645 * Makefile.in (base_obj): Add back doprnt.o.
10646
10647 * deps.mk (doprnt.o): Add back prerequisites.
10648 (callint.o): Depend on character.h.
10649
10650 * eval.c (internal_lisp_condition_case): Include the handler
10651 representation in the error message.
10652 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10653 when breaking from the loop.
10654
10655 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10656
10657 * callint.c (Fcall_interactively): When displaying error message
10658 about invalid control letter, pass the character's codepoint, not
10659 a pointer to its multibyte form. Improve display of the character
10660 in octal and display also its hex code.
10661
10662 * character.c (char_string): Use %x to display the (unsigned)
10663 codepoint of an invalid character, to avoid displaying a bogus
10664 negative value.
10665
10666 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10667 `error', not SYMBOL_NAME itself.
10668
10669 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10670 character arguments to `error'.
10671
10672 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10673 to `error' in error message about FINAL_CHAR argument. Make sure
10674 FINAL_CHAR is a character, and use %c when it is passed as
10675 argument to `error'.
10676
4ffd0d6b 106772011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10678
10679 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10680
10681 * w32.c: Include <time.h>.
10682 (sys_localtime): New function.
10683
4ffd0d6b 106842011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10685
10686 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10687
4ffd0d6b 10688 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10689
4ffd0d6b 106902011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10691
4ffd0d6b
GM
10692 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10693 zombies (Bug#8467).
aac0c6e3 10694
04c56954
EZ
106952011-04-19 Eli Zaretskii <eliz@gnu.org>
10696
10697 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10698 gl_state.e_property when gl_state.object is Qt.
10699
10700 * insdel.c (make_gap_larger): Remove limitation of buffer size
10701 to <= INT_MAX.
10702
16a43933
CY
107032011-04-18 Chong Yidong <cyd@stupidchicken.com>
10704
10705 * xdisp.c (lookup_glyphless_char_display)
10706 (produce_glyphless_glyph): Handle cons cell entry in
10707 glyphless-char-display.
10708 (Vglyphless_char_display): Document it.
10709
10710 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10711 glyphless-char-display.
10712
4581706e
CY
107132011-04-17 Chong Yidong <cyd@stupidchicken.com>
10714
10715 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10716
10717 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10718
10719 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10720 definition for no-X builds.
10721
4887c6e2 107222011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10723
fd35b6f9
PE
10724 Static checks with GCC 4.6.0 and non-default toolkits.
10725
5c1ccb01
PE
10726 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10727
006c5daa
PE
10728 * process.c (keyboard_bit_set): Define only if SIGIO.
10729 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10730 (send_process): Repair possible setjmp clobbering.
10731
efc736d3
PE
10732 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10733
4e2fe2e6
PE
10734 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10735
f97334a2
PE
10736 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10737
4e75f29d
PE
10738 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10739 Define only if needed.
10740
90efadd1
PE
10741 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10742 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10743 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10744
3c647824
PE
10745 * dispextern.h (struct redisplay_interface): Rename param
10746 to avoid shadowing.
e264f262 10747 * termhooks.h (struct terminal): Likewise.
761383f4 10748 * xterm.c (xembed_send_message): Likewise.
3c647824 10749
b58c5c4a
PE
10750 * insdel.c (make_gap_smaller): Define only if
10751 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10752
cad59032
PE
10753 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10754 it.
10755
c339dc2e
PE
10756 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10757 so that we aren't warned about unused symbols.
10758
91a3e27b
PE
10759 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10760
399c71d3 10761 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10762
8ffc96f5
PE
10763 * xfns.c (x_real_positions): Mark locals as initialized.
10764
eef9bc79
PE
10765 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10766
098db9dd
PE
10767 * xterm.c: Fix problems found by static analysis with other toolkits.
10768 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10769 (x_dispatch_event): Declare static if USE_GTK, and
10770 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10771 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10772 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10773 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10774 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10775
eb18f6cc
PE
10776 * xmenu.c (menu_help_callback): Pointer type fixes.
10777 Use const pointers when pointing at readonly data. Avoid pointer
10778 signedness clashes.
10779 (FALSE): Remove unused macro.
10780 (update_frame_menubar): Remove unused decl.
10781
1fe72bf8
PE
10782 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10783
60d9e1db
PE
10784 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10785 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10786 (single_menu_item): Rename local to avoid shadowing.
10787
39261c26
PE
10788 * keyboard.c (make_lispy_event): Remove unused local var.
10789
018c5e19
PE
10790 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10791 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10792
63d2b86e
PE
10793 * bitmaps: Change bitmaps from unsigned char back to the X11
10794 compatible char. Avoid the old compiler warnings about
10795 out-of-range initializers by using, for example, '\xab' rather
10796 than 0xab.
10797
aefd87e1
PE
10798 * xgselect.c (xgselect_initialize): Check vs interface
10799 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10800
bf501fb9
PE
10801 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10802
e9829fdf
PE
10803 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10804 to read-only memory.
10805
1086c095
PE
10806 * fns.c (vector): Remove; this old hack is no longer needed.
10807
2baccd04 10808 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10809 Remove unused var.
dde42981 10810 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10811
72391843 10812 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10813
436c16df 10814 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10815 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10816 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10817
92bb796d 10818 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10819 (x_term_init): Remove local to avoid shadowing.
92bb796d 10820
764430a3 10821 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10822
10823 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10824 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10825
d1dfb56c
EZ
108262011-04-16 Eli Zaretskii <eliz@gnu.org>
10827
c4354cb4
EZ
10828 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10829
d1dfb56c
EZ
10830 Fix regex.c, syntax.c and friends for buffers > 2GB.
10831 * syntax.h (struct gl_state_s): Declare character position members
10832 EMACS_INT.
10833
10834 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10835
04f2d78b
CB
10836 * textprop.c (verify_interval_modification, interval_of):
10837 Declare arguments EMACS_INT.
d1dfb56c
EZ
10838
10839 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10840 EMACS_INT.
10841
10842 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10843
10844 * indent.c (Fvertical_motion): Local variable it_start is now
10845 EMACS_INT.
10846
10847 * regex.c (re_match, re_match_2, re_match_2_internal)
10848 (bcmp_translate, regcomp, regexec, print_double_string)
10849 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10850 (re_compile_pattern, re_exec): Declare arguments and local
10851 variables `size_t' and `ssize_t' and return values `regoff_t', as
10852 appropriate.
10853 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10854 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10855 <compile_stack_type>: `size' and `avail' are now `size_t'.
10856
10857 * regex.h <regoff_t>: Use ssize_t, not int.
10858 (re_search, re_search_2, re_match, re_match_2): Arguments that
10859 specify buffer/string position and length are now ssize_t and
10860 size_t. Return type is regoff_t.
10861
613052cd
BK
108622011-04-16 Ben Key <bkey76@gmail.com>
10863
10864 * nsfont.m: Fixed bugs in ns_get_family and
10865 ns_descriptor_to_entity that were caused by using free to
10866 deallocate memory blocks that were allocated by xmalloc (via
10867 xstrdup). This caused Emacs to crash when compiled with
10868 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10869 --enable-checking=xmallocoverrun). xfree is now used to
10870 deallocate these memory blocks.
10871
4170f62f 108722011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10873
71b41406
PE
10874 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10875
9587a89d
PE
10876 emacs_write: Accept and return EMACS_INT for sizes.
10877 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10878 et seq.
10879 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10880 Accept and return EMACS_INT.
10881 (emacs_gnutls_write): Return the number of bytes written on
10882 partial writes.
10883 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10884 (emacs_read, emacs_write): Remove check for negative size, as the
10885 Emacs source code has been audited now.
9587a89d
PE
10886 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10887 (emacs_read, emacs_write): Use it.
273a5f82
PE
10888 * process.c (send_process): Adjust to the new signatures of
10889 emacs_write and emacs_gnutls_write. Do not attempt to store
10890 a byte offset into an 'int'; it might overflow.
9587a89d 10891 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10892
3e047f51
PE
10893 * sound.c: Don't assume sizes fit in 'int'.
10894 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10895 Return EMACS_INT, not int.
3e047f51 10896 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10897 Accept EMACS_INT, not int.
10898 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10899 record read return values.
10900
cc39a9db
BK
109012011-04-15 Ben Key <bkey76@gmail.com>
10902
c9d0ec6d
JB
10903 * keyboard.c (Qundefined): Don't declare static since it is used
10904 in nsfns.m.
10905 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10906 static since they are used in nsfont.m.
cc39a9db 10907
6c60eb9f
SM
109082011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10909
10910 * process.c (Qprocessp): Don't declare static.
10911 * lisp.h (Qprocessp): Declare again.
10912
7990b61a
JB
109132011-04-15 Juanma Barranquero <lekktu@gmail.com>
10914
10915 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10916
5d4cb038
PE
109172011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10918
8bd7b830 10919 Improve C-level modularity by making more things 'static'.
cd64ea1d 10920
e3b27b31
PE
10921 Don't publish debugger-only interfaces to other modules.
10922 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10923 (verify_bytepos, count_markers): Move decls to the only modules
10924 that need them.
10925 * region-cache.h (pp_cache): Likewise.
10926 * window.h (check_all_windows): Likewise.
10927 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10928
5d4cb038
PE
10929 * sysdep.c (croak): Now static, if
10930 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10931 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10932
10933 * alloc.c (refill_memory_reserve): Now static if
10934 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10935 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10936
e87b6180
PE
10937 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10938 Define only if USE_LUCID.
10939
ac64929e
PE
10940 * xrdb.c (x_customization_string, x_rm_string): Now static.
10941
6f37259d
PE
10942 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10943 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10944
1683e3ab
PE
10945 * xdisp.c (draw_row_with_mouse_face): Now static.
10946 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10947
de9c2632
PE
10948 * window.h (check_all_windows): Mark externally visible.
10949
2b96acb7
PE
10950 * window.c (window_deletion_count): Now static.
10951
10952 * undo.c: Make symbols static if they're not exported.
10953 (last_undo_buffer, last_boundary_position, pending_boundary):
10954 Now static.
10955
50436f33
PE
10956 * textprop.c (interval_insert_behind_hooks): Now static.
10957 (interval_insert_in_front_hooks): Likewise.
10958
64520e5c
PE
10959 * term.c: Make symbols static if they're not exported.
10960 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10961 (max_frame_lines, tty_set_terminal_modes):
10962 (tty_reset_terminal_modes, tty_turn_off_highlight):
10963 (get_tty_terminal): Now static.
10964 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10965 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10966 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10967 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10968 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10969
1fa53021
PE
10970 * sysdep.c: Make symbols static if they're not exported.
10971 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10972 Now static.
10973 (sigprocmask_set, full_mask): Remove; unused.
10974 (wait_debugging): Mark as visible.
10975 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10976 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10977
d4b43b22
PE
10978 * syntax.c (syntax_temp): Define only if !__GNUC__.
10979
b7c513d0
PE
10980 * sound.c (current_sound_device, current_sound): Now static.
10981
989b29ad
PE
10982 * search.c (searchbufs, searchbuf_head): Now static.
10983
13a55a78
PE
10984 * scroll.c (scroll_cost): Remove; unused.
10985 * dispextern.h (scroll_cost): Remove decl.
10986
de68a1fc
PE
10987 * region-cache.h (pp_cache): Mark as externally visible.
10988
40ccffa6
PE
10989 * process.c: Make symbols static if they're not exported.
10990 (process_tick, update_tick, create_process, chan_process):
10991 (Vprocess_alist, proc_buffered_char, datagram_access):
10992 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10993 (deactivate_process): Mark defn as static, as well as decl.
10994 * lisp.h (create_process): Remove decl.
10995 * process.h (chan_process, Vprocess_alist): Remove decls.
10996
ad64fc97
PE
10997 * print.c: Make symbols static if they're not exported.
10998 (print_depth, new_backquote_output, being_printed, print_buffer):
10999 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11000 (print_interval, print_number_index, initial_stderr_stream):
11001 Now static.
11002 * lisp.h (Fprinc): Remove decl.
11003 (debug_output_compilation_hack): Mark as externally visible.
11004
adddb265
PE
11005 * sysdep.c (croak): Move decl from here to syssignal.h.
11006 * syssignal.h (croak): Put it here, so the API can be checked when
11007 'croak' is called from dissociate_if_controlling_tty.
11008
1717ede2
PE
11009 * minibuf.c: Make symbols static if they're not exported.
11010 (minibuf_save_list, choose_minibuf_frame): Now static.
11011 * lisp.h (choose_minibuf_frame): Remove decl.
11012
fa5fb2bc
PE
11013 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11014
1e3890d1
PE
11015 * lread.c: Make symbols static if they're not exported.
11016 (read_objects, initial_obarray, oblookup_last_bucket_number):
11017 Now static.
11018 (make_symbol): Remove; unused.
11019 * lisp.h (initial_obarray, make_symbol): Remove decls.
11020
8a1414fa
PE
11021 * keyboard.c: Make symbols static if they're not exported.
11022 (single_kboard, recent_keys_index, total_keys, recent_keys):
11023 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11024 (this_single_command_key_start, echoing, last_auto_save):
11025 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11026 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11027 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11028 (Vlispy_mouse_stem, double_click_count):
11029 Now static.
11030 (force_auto_save_soon): Define only if SIGDANGER.
11031 (ignore_mouse_drag_p): Now static if
11032 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11033 (print_help): Remove; unused.
11034 (stop_character, last_timer_event): Mark as externally visible.
11035 * keyboard.h (ignore_mouse_drag_p): Declare only if
11036 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11037 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11038 * lisp.h (echoing): Remove decl.
11039 (force_auto_save_soon): Declare only if SIGDANGER.
11040 * xdisp.c (redisplay_window): Simplify code, to make it more
11041 obvious that ignore_mouse_drag_p is not accessed if !defined
11042 USE_GTK && !defined HAVE_NS.
11043
93ea6e8f
PE
11044 * intervals.c: Make symbols static if they're not exported.
11045 (merge_properties_sticky, merge_interval_right, delete_interval):
11046 Now static.
11047 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11048
77382fcc
PE
11049 * insdel.c: Make symbols static if they're not exported.
11050 However, leave prepare_to_modify_buffer alone. It's never
11051 called from outside this function, but that appears to be a bug.
11052 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11053 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11054 (adjust_after_replace_noundo): Remove; unused.
11055 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11056 (signal_before_change): Remove decls.
77382fcc 11057
9306c32e
PE
11058 * indent.c (val_compute_motion, val_vmotion): Now static.
11059
cd44d2eb
PE
11060 * image.c: Make symbols static if they're not exported.
11061 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11062 if USE_GTK.
11063 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11064 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11065
ad9a7a06
PE
11066 * fringe.c (standard_bitmaps): Now static.
11067 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11068
81626931
PE
11069 * frame.c: Make symbols static if they're not exported.
11070 (x_report_frame_params, make_terminal_frame): Now static.
11071 (get_frame_param): Now static, unless HAVE_NS.
11072 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11073 (x_get_resource_string): Remove; not used.
11074 * frame.h (make_terminal_frame, x_report_frame_params):
11075 (x_get_resource_string); Remove decls.
11076 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11077 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11078
239f9db9
PE
11079 * font.c, fontset.c: Make symbols static if they're not exported.
11080 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11081 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11082 * font.c (font_close_object): Now static.
11083 * font.h (font_close_object): Remove.
11084 * fontset.c (FONTSET_OBJLIST): Remove.
11085 (free_realized_fontset) #if-0 the body, which does nothing.
11086 (face_suitable_for_char_p): #if-0, as it's never called.
11087 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11088 * xfaces.c (face_at_string_position):
11089 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11090 since 0 is always ASCII.
11091
dfcf3579
PE
11092 * fns.c (weak_hash_tables): Now static.
11093
5045092b
PE
11094 * fileio.c: Make symbols static if they're not exported.
11095 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11096 (Vwrite_region_annotation_buffers): Now static.
11097
57a96f5c
PE
11098 * eval.c: Make symbols static if they're not exported.
11099 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11100 * lisp.h (backtrace_list): Remove decl.
11101
35f08c38
PE
11102 * emacs.c: Make symbols static if they're not exported.
11103 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11104 (fatal_error_code, fatal_error_signal_hook, standard_args):
11105 Now static.
11106 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11107 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11108 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11109 * lisp.h (fatal_error_signal_hook): Remove decl.
11110 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11111
f44bd759
PE
11112 * editfns.c: Move a (normally-unused) function to its only use.
11113 * editfns.c, lisp.h (get_operating_system_release): Remove.
11114 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11115 worth the hassle of breaking this out.
11116
b532497d
PE
11117 * xterm.c: Make symbols static if they're not exported.
11118 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11119 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11120 (x_destroy_window, x_delete_display):
11121 Now static.
11122 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11123 (x_mouse_leave): Remove; unused.
11124 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11125 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11126 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11127 Remove decls.
11128 (x_mouse_leave): Declare only if WINDOWSNT.
11129 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11130 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11131 USE_X_TOOLKIT.
11132
1675728f
PE
11133 * ftxfont.c: Make symbols static if they're not exported.
11134 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11135 HAVE_FREETYPE.
11136 * font.h (ftxfont_driver): Likewise.
11137
e4cebfca
PE
11138 * xfns.c: Make symbols static if they're not exported.
11139 (x_last_font_name, x_display_info_for_name):
11140 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11141 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11142 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11143 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11144 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11145 (last_show_tip_args): Now static.
11146 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11147 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11148 (x_screen_planes): Remove; unused.
11149 * dispextern.h (x_screen_planes): Remove decl.
11150
5bf46f05
PE
11151 * dispnew.c: Make symbols static if they're not exported.
11152 * dispextern.h (redraw_garbaged_frames, scrolling):
11153 (increment_row_positions): Remove.
11154 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11155 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11156 Now static.
11157 (redraw_garbaged_frames): Remove; unused.
11158
435f4c28
PE
11159 * xfaces.c: Make symbols static if they're not exported.
11160 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11161 Remove decls.
11162 * xterm.h (defined_color): Remove decls.
11163 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11164 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11165 (menu_face_changed_default, defined_color, free_realized_face):
11166 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11167 (ascii_face_of_lisp_face): Remove; unused.
11168
8524aef3
PE
11169 * xdisp.c: Make symbols static if they're not exported.
11170 * dispextern.h (scratch_glyph_row, window_box_edges):
11171 (glyph_to_pixel_coords, set_cursor_from_row):
11172 (get_next_display_element, set_iterator_to_next):
11173 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11174 (show_mouse_face): Remove decls
11175 * frame.h (message_buf_print): Likewise.
11176 * lisp.h (pop_message, set_message, check_point_in_composition):
11177 Likewise.
11178 * xterm.h (set_vertical_scroll_bar): Likewise.
11179 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11180 (message_buf_print, scratch_glyph_row, displayed_buffer):
11181 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11182 (get_next_display_element, show_mouse_face, window_box_edges):
11183 (frame_to_window_pixel_xy, check_point_in_composition):
11184 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11185 (glyph_to_pixel_coords): Remove; unused.
11186
16390cd2
PE
11187 * dired.c (file_name_completion): Now static.
11188
11189 * dbusbind.c (xd_in_read_queued_messages): Now static.
11190
a25f4dfa
PE
11191 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11192 * data.c (circular_list_error): Remove.
11193
14a9c8df
PE
11194 * commands.h (last_point_position, last_point_position_buffer):
11195 (last_point_position_window): Remove decls.
11196 * keyboard.c: Make these variables static.
11197
04f2d78b
CB
11198 * coding.h (coding, code_convert_region, encode_coding_gap):
11199 Remove decls.
74ab6df5
PE
11200 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11201 (iso_code_class, detect_coding, code_convert_region): Now static.
11202 (encode_coding_gap): Remove; unused.
11203
38dfbee1
PE
11204 * chartab.c (chartab_chars, chartab_bits): Now static.
11205
a2cb4e63
PE
11206 * charset.h (charset_iso_8859_1): Remove decl.
11207 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11208 Now static.
11209
127198fd
PE
11210 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11211 * ccl.c (Vccl_program_table): Now static.
11212 (check_ccl_update): Remove; unused.
11213
d85b608f
PE
11214 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11215 * category.h: ... from here.
11216 * category.c (check_category_table, set_category_set): Now static.
11217
31cd66f3
PE
11218 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11219 * lisp.h: Remove these decls.
11220
c358e587
PE
11221 * buffer.c (buffer_count): Remove unused var.
11222
e78aecca
PE
11223 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11224 so that it's not optimized away.
11225 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11226 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11227 exported only to the debugger.
11228
e192d7d3 11229 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11230 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11231
92470028
PE
11232 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11233 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11234 was inaccessible from Lisp.
11235 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11236 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11237
244ed907
PE
11238 alloc.c: Import and export fewer symbols, and remove unused items.
11239 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11240 is defined.
11241 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11242 it's not optimized away by whole-program optimization.
11243 (message_enable_multibyte, free_misc): Remove.
11244 (catchlist, handlerlist, mark_backtrace):
11245 Declare only if BYTE_MARK_STACK.
11246 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11247 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11248 (message_enable_multibyte): Remove decl.
11249 (free_misc, interval_free_list, float_block, float_block_index):
11250 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11251 (cons_free_list, last_marked_index):
11252 Now static.
11253 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11254 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11255 (mark_backtrace): Define only if BYTE_MARK_STACK.
11256 * xdisp.c (message_enable_multibyte): Now static.
11257
61c2b50e 11258 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11259 This makes it easier for human readers (and static analyzers)
11260 to see whether these variables are used from other modules.
11261 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11262 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11263 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11264 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11265 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11266 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11267 * xmenu.c, xselect.c:
11268 Declare Q* vars static if they are not used in other modules.
11269 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11270 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11271 Remove decls of unexported vars.
11272 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11273
95c82688
PE
11274 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11275
16a97296
PE
11276 Make Emacs functions such as Fatom 'static' by default.
11277 This makes it easier for human readers (and static analyzers)
11278 to see whether these functions can be called from other modules.
11279 DEFUN now defines a static function. To make the function external
11280 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11281 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11282 (Finit_image_library):
16a97296
PE
11283 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11284 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11285 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11286 Remove decls, since these functions are now static.
11287 (Funintern, Fget_internal_run_time): New decls, since these functions
11288 were already external.
95c82688 11289
16a97296
PE
11290 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11291 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11292 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11293 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11294 * keyboard.c, keymap.c, lread.c:
11295 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11296 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11297 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11298 Mark functions with DEFUE instead of DEFUN,
11299 if they are used in other modules.
11300 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11301 decls for now-static functions.
11302 * buffer.h (Fdelete_overlay): Remove decl.
11303 * callproc.c (Fgetenv_internal): Mark as internal.
11304 * composite.c (Fremove_list_of_text_properties): Remove decl.
11305 (Fcomposition_get_gstring): New forward static decl.
11306 * composite.h (Fcomposite_get_gstring): Remove decl.
11307 * dired.c (Ffile_attributes): New forward static decl.
11308 * doc.c (Fdocumntation_property): New forward static decl.
11309 * eval.c (Ffetch_bytecode): New forward static decl.
11310 (Funintern): Remove extern decl; now in .h file where it belongs.
11311 * fileio.c (Fmake_symbolic_link): New forward static decl.
11312 * image.c (Finit_image_library): New forward static decl.
11313 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11314 * intervals.h (Fprevious_property_change):
11315 (Fremove_list_of_text_properties): Remove decls.
11316 * keyboard.c (Fthis_command_keys): Remove decl.
11317 (Fcommand_execute): New forward static decl.
11318 * keymap.c (Flookup_key): New forward static decl.
11319 (Fcopy_keymap): Now static.
11320 * keymap.h (Flookup_key): Remove decl.
11321 * process.c (Fget_process): New forward static decl.
11322 (Fprocess_datagram_address): Mark as internal.
11323 * syntax.c (Fsyntax_table_p): New forward static decl.
11324 (skip_chars): Remove duplicate decl.
11325 * textprop.c (Fprevious_property_change): New forward static decl.
11326 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11327 Now internal.
11328 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11329 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11330
785bbd42
PE
11331 * editfns.c (Fformat): Remove unreachable code.
11332
8b913b57
AS
113332011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11334
11335 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11336 change. (Bug#8496)
11337
a6744a35
EZ
113382011-04-13 Eli Zaretskii <eliz@gnu.org>
11339
11340 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11341 when at ZV. (Bug#8487)
11342
e7974947
AS
113432011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11344
baad03f0
AS
11345 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11346 (Bug#8437)
11347 * keyboard.c (parse_tool_bar_item): Likewise.
11348 * sound.c (sound_cleanup, alsa_close): Likewise.
11349 * termcap.c (tgetent): Likewise.
11350 * xfns.c (x_default_font_parameter): Likewise.
11351 * xsettings.c (read_and_apply_settings): Likewise.
11352
e7974947
AS
11353 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11354 (overrun_check_free): Protoize.
11355
28272684
PE
113562011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11357
11358 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11359 since callers should never pass a negative size.
11360 Change the signature to match that of plain 'read' and 'write'; see
11361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11362 * lisp.h: Update prototypes of emacs_write and emacs_read.
11363
11997c76
EZ
113642011-04-11 Eli Zaretskii <eliz@gnu.org>
11365
11366 * xdisp.c (redisplay_window): Don't try to determine the character
11367 position of the scroll margin if the window start point w->startp
e896f03c 11368 is outside the buffer's accessible region. (Bug#8468)
11997c76 11369
8a2cbd72
EZ
113702011-04-10 Eli Zaretskii <eliz@gnu.org>
11371
11372 Fix write-region and its subroutines for buffers > 2GB.
11373 * fileio.c (a_write, e_write): Modify declaration of arguments and
11374 local variables to support buffers larger than 2GB.
11375 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11376
11377 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11378 argument, local variables, and return value.
11379
11380 * lisp.h: Update prototypes of emacs_write and emacs_read.
11381
11382 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11383
4073e537 113842011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11385
1ebfdcb6
PE
11386 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11387
b2ded58d
PE
11388 Fix more problems found by GCC 4.6.0's static checks.
11389
7d66342c
PE
11390 * xdisp.c (vmessage): Use a better test for character truncation.
11391
bbf47d44
PE
11392 * charset.c (load_charset_map): <, not <=, for optimization,
11393 and to avoid potential problems with integer overflow.
9248994d 11394 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11395 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11396 * editfns.c (Fformat): Likewise.
1e69125e 11397 * syntax.c (skip_chars): Likewise.
3befa583 11398
e3019616
PE
11399 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11400 This also lets GCC 4.6.0 generate slightly better loop code.
11401
becfa255
PE
11402 * callint.c (Fcall_interactively): <, not <=, for optimization.
11403 (Fcall_interactively): Count the number of arguments produced,
11404 not the number of arguments given. This is simpler and lets GCC
11405 4.6.0 generate slightly better code.
11406
dae0cd48
PE
11407 * ftfont.c: Distingish more carefully between FcChar8 and char.
11408 The previous code passed unsigned char * to a functions like
11409 strlen and xstrcasecmp that expect char *, which does not
11410 conform to the C standard.
11411 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11412 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11413 char * when the C standard requires it.
11414
76032d70
PE
11415 * keyboard.c (read_char): Remove unused var.
11416
eb3f1cc8
PE
11417 * eval.c: Port to Windows vsnprintf (Bug#8435).
11418 Include <limits.h>.
11419 (SIZE_MAX): Define if the headers do not.
11420 (verror): Do not give up if vsnprintf returns a negative count.
11421 Instead, grow the buffer. This ports to Windows vsnprintf, which
11422 does not conform to C99. Problem reported by Eli Zaretskii.
11423 Also, simplify the allocation scheme, by avoiding the need for
11424 calling realloc, and removing the ALLOCATED variable.
11425
70476b54
PE
11426 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11427
12020a9e
PE
11428 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11429 But keep the doprint source code for now, as we might revamp it
11430 and use it again (Bug#8435).
ea6c7ae6
PE
11431 * lisp.h (doprnt): Remove.
11432 * Makefile.in (base_obj): Remove doprnt.o.
11433 * deps.mk (doprnt.o): Remove.
11434
5fdb398c
PE
11435 error: Print 32- and 64-bit integers portably (Bug#8435).
11436 Without this change, on typical 64-bit hosts error ("...%d...", N)
11437 was used to print both 32- and 64-bit integers N, which relied on
11438 undefined behavior.
61bdb816 11439 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11440 * lisp.h (error, verror): Mark as printf-like functions.
11441 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11442 Report overflow in size calculations when allocating printf buffer.
11443 Do not truncate output string at its first null byte.
11444 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11445 Truncate the output at a character boundary, since vsnprintf does not
11446 do that.
11447 * charset.c (check_iso_charset_parameter): Convert internal
11448 character to string before calling 'error', since %c now has the
11449 printf meaning.
11450 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11451 overflow when computing char to be passed to 'error'. Do not
11452 pass Lisp_Object to 'error'; pass the integer instead.
11453 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11454 formatted with plain %d.
11455
b189fa66
PE
11456 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11457
bff87ef0
PE
11458 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11459
7e2cac20
PE
11460 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11461
ce4d90b5
PE
11462 * xterm.c (x_catch_errors): Remove duplicate declaration.
11463
266c9547
PE
11464 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11465
79c49ad2
PE
11466 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11467
368f4090
JM
114682011-04-10 Jim Meyering <meyering@redhat.com>
11469
11470 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11471 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11472 return ssize_t not "int", and use size_t as the buffer length.
11473 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11474 * gnutls.h: Update declarations.
11475 * process.c (read_process_output): Use ssize_t, to match.
11476 (send_process): Likewise.
11477
a32d4040
CY
114782011-04-09 Chong Yidong <cyd@stupidchicken.com>
11479
11480 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11481
8546720e 114822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11483
04f2d78b
CB
11484 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11485 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11486
8546720e
GM
11487 * xterm.c (handle_one_xevent):
11488 * xmenu.c (create_and_show_popup_menu):
11489 * xselect.c (x_decline_selection_request)
11490 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11491
0a2f5c1a 114922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11493
11494 Fix some uses of `int' instead of EMACS_INT.
11495 * search.c (string_match_1, fast_string_match)
11496 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11497 (scan_buffer, find_next_newline_no_quit)
11498 (find_before_next_newline, search_command, Freplace_match)
11499 (Fmatch_data): Make some `int' variables be EMACS_INT.
11500
11501 * xdisp.c (display_count_lines): 3rd argument and return value now
11502 EMACS_INT. All callers changed.
11503 (pint2hrstr): Last argument is now EMACS_INT.
11504
11505 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11506 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11507 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11508 (decode_coding_utf_16, decode_coding_emacs_mule)
11509 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11510 (decode_coding_ccl, decode_coding_charset)
11511 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11512 (decode_coding_iso_2022, decode_coding_emacs_mule)
11513 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11514 <char_offset, last_offset>: Declare EMACS_INT.
11515 (encode_coding_utf_8, encode_coding_utf_16)
11516 (encode_coding_emacs_mule, encode_invocation_designation)
11517 (encode_designation_at_bol, encode_coding_iso_2022)
11518 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11519 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11520 Declare EMACS_INT.
11521 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11522 (encode_invocation_designation): Last argument P_NCHARS is now
11523 EMACS_INT.
11524 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11525 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11526
11527 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11528 All users changed.
11529
11530 * ccl.c (Fccl_execute_on_string): Declare some variables
11531 EMACS_INT.
11532
8546720e 115332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11534
11535 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11536
4e19a977
CS
115372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11538
11539 * process.c (Fformat_network_address): Doc fix.
11540
87302331
R
115412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11542
ee7683eb 11543 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11544
cbb59342
CY
115452011-04-08 Chong Yidong <cyd@stupidchicken.com>
11546
11547 * keyboard.c (read_char): Call Lisp function help-form-show,
11548 instead of using internal_with_output_to_temp_buffer.
11549 (Qhelp_form_show): New var.
e0d38eeb 11550 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11551
11552 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11553
11554 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11555
e67a13ab
CY
115562011-04-06 Chong Yidong <cyd@stupidchicken.com>
11557
04f2d78b
CB
11558 * process.c (Flist_processes): Remove to Lisp.
11559 (list_processes_1): Delete.
e67a13ab 11560
973f782d
EZ
115612011-04-06 Eli Zaretskii <eliz@gnu.org>
11562
7c106b1e
EZ
11563 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11564
973f782d
EZ
11565 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11566
41cf7d1a 115672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11568
ca23cc88
PE
11569 Fix more problems found by GCC 4.6.0's static checks.
11570
f390e2d5
PE
11571 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11572
42eea0d0
PE
11573 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11574
b69769da 11575 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11576
f9541e84
PE
11577 * xdisp.c (vmessage): Mark as a printf-like function.
11578
13841b55
PE
11579 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11580
c136c10f
PE
11581 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11582
5e2d4a30
PE
11583 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11584 printf-like functions.
11585 (tiff_load): Add casts to remove these marks before passing them
11586 to system-supplied API.
11587
583f48b9
PE
11588 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11589
b25d760e
PE
11590 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11591 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11592 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11593 directly, rather than having caller test rule sign. This avoids
11594 some unnecessary tests.
11595 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11596 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11597 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11598
bc7b6697 11599 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11600 (xfont_open): Avoid unnecessary tests.
bc7b6697 11601
27ccc379
PE
11602 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11603
dcd5c89a
PE
11604 * composite.h, composite.c (composition_gstring_put_cache):
11605 Use EMACS_INT, not int, for length.
11606
b13a45c6
PE
11607 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11608 breaking out part of COMPOSITION_DECODE_RULE.
11609 (COMPOSITION_DECODE_RULE): Use it.
11610 * composite.c (get_composition_id): Remove unused local vars,
11611 by using the new macro.
11612
1e792e4d
PE
11613 * textprop.c (set_text_properties_1): Change while to do-while,
11614 since the condition is always true at first.
11615
dc6c6455 11616 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11617 (interval_deletion_adjustment): Return unsigned value.
11618 All uses changed.
dc6c6455 11619
aba7731a
PE
11620 * process.c (list_processes_1, create_pty, read_process_output):
11621 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11622 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11623 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11624 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11625 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11626
fdfc4bf3
PE
11627 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11628
fca8fe46 11629 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11630 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11631
06a0259a 11632 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11633 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11634 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11635
e7b9e80f
PE
11636 * print.c (print_error_message): Avoid int overflow.
11637
56201685
PE
11638 * font.c (font_list_entities): Redo for clarity,
11639 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11640
78834453 11641 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11642 (font_score): Avoid potential overflow in diff calculation.
78834453 11643
0bc0b309 11644 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11645 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11646
e610eaca
PE
11647 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11648
b895abce
PE
11649 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11650 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11651 can always succeed if overflow has undefined behavior.
11652
1f1d9321 11653 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11654 (wordify): Omit three unnecessary tests.
1f1d9321 11655
c59478bc
PE
11656 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11657 All callers changed. This avoids the need for an unused var.
11658
79b73827
PE
11659 * casefiddle.c (casify_region): Remove var that is set but not used.
11660
a4db5dfe
PE
11661 * dired.c (file_name_completion): Remove var that is set but not used.
11662
43aae36e
PE
11663 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11664
2a47c44d 11665 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11666 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11667
a37c69bf
PE
11668 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11669 Check for integer overflow on size calculations.
11670
328ab8e7
PE
11671 * buffer.c (Fprevious_overlay_change): Remove var that is set
11672 but not used.
11673
e5a2a5cb
PE
11674 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11675 Remove vars that are set but not used.
8d84a6eb 11676 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11677 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11678
a60e5f68
PE
11679 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11680
f661cb61 11681 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11682 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11683
f0397f5a
PE
11684 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11685 that are set but not used.
11686
8664db06 11687 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11688 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11689
6abdaa4a
PE
11690 * xselect.c (x_get_local_selection, x_handle_property_notify):
11691 Remove vars that are set but not used.
11692
0ce7538d 11693 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11694 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11695
9ae848fc
PE
11696 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11697 Remove var that is set but not used.
0b918413
PE
11698 (scroll_bar_windows_size): Now size_t, not int.
11699 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11700 Check for overflow.
9ae848fc 11701
a5a62657
PE
11702 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11703 (map_tty_color) [!defined MSDOS]: Likewise.
11704
5c5cdd39
PE
11705 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11706
66ebf983
PE
11707 * coding.c: Remove vars that are set but not used.
11708 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11709 All callers changed.
11710 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11711 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11712 (decode_coding_charset): Remove vars that are set but not used.
11713
1be4d761
PE
11714 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11715 that is set but not used.
11716
47553fa8
PE
11717 * print.c (print_object): Remove var that is set but not used.
11718
1f7196bf 11719 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11720 The gnulib version avoids calling malloc in the usual case,
11721 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11722 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11723 * filelock.c (current_lock_owner): Likewise.
11724 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11725 * sysdep.c: Include allocator.h, careadlinkat.h.
11726 (emacs_no_realloc_allocator): New static constant.
11727 (emacs_readlink): New function.
fdb61804
PE
11728 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11729 ../lib/careadlinkat.h.
d1fdcab7 11730
f84c17c7
SM
117312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11732
11733 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11734 first non-nil return value).
11735
ef3862ad
JD
117362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11737
11738 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11739 if not defined (Bug#8403).
11740
376a7006
JB
117412011-04-02 Juanma Barranquero <lekktu@gmail.com>
11742
11743 * xdisp.c (display_count_lines): Remove parameter `start',
11744 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11745 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11746 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11747 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11748 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11749 and thereabouts. All callers changed.
11750 (get_per_char_metric): Remove parameter `f', unused since
11751 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11752
6ca3801d
JM
117532011-04-02 Jim Meyering <meyering@redhat.com>
11754
11755 do not dereference NULL upon failed strdup
11756 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11757 (ns_get_family): Likewise.
11758
d8e2b5ba
JB
117592011-04-02 Juanma Barranquero <lekktu@gmail.com>
11760
11761 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11762
8c74fcbd
JD
117632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11764
11765 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11766 later (Bug#8403).
11767
7200d79c
SM
117682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11769
03408648 11770 Add lexical binding.
7200d79c 11771
03408648
SM
11772 * window.c (Ftemp_output_buffer_show): New fun.
11773 (Fsave_window_excursion):
11774 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11775
11776 * lread.c (lisp_file_lexically_bound_p): New function.
11777 (Fload): Bind Qlexical_binding.
11778 (readevalloop): Remove `evalfun' arg.
11779 Bind Qinternal_interpreter_environment.
11780 (Feval_buffer): Bind Qlexical_binding.
11781 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11782 Mark as dynamic.
11783 (syms_of_lread): Declare `lexical-binding'.
11784
11785 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11786
11787 * keyboard.c (eval_dyn): New fun.
11788 (menu_item_eval_property): Use it.
ca105506
SM
11789
11790 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11791
03408648
SM
11792 * fns.c (concat, mapcar1): Accept byte-code-functions.
11793
11794 * eval.c (Fsetq): Handle lexical vars.
11795 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11796 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11797 (FletX, Flet): Obey lexical binding.
11798 (Fcommandp): Handle closures.
11799 (Feval): New `lexical' arg.
11800 (eval_sub): New function extracted from Feval. Use it almost
11801 everywhere where Feval was used. Look up vars in lexical env.
11802 Handle closures.
11803 (Ffunctionp): Move from subr.el.
11804 (Ffuncall): Handle closures.
11805 (apply_lambda): Remove `eval_flags'.
11806 (funcall_lambda): Handle closures and new byte-code-functions.
11807 (Fspecial_variable_p): New function.
11808 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11809 but without exporting it to Lisp.
23aba0ea 11810
23aba0ea 11811 * doc.c (Fdocumentation, store_function_docstring):
03408648 11812 * data.c (Finteractive_form): Handle closures.
23aba0ea 11813
03408648
SM
11814 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11815 interactive spec.
ba83908c 11816
04f2d78b
CB
11817 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11818 New byte-codes.
03408648
SM
11819 (exec_byte_code): New function extracted from Fbyte_code to handle new
11820 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11821
03408648 11822 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11823
03408648 11824 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11825
e2abce01
JB
118262011-03-31 Juanma Barranquero <lekktu@gmail.com>
11827
11828 * xdisp.c (redisplay_internal): Fix prototype.
11829
63696a73 118302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11831
63696a73 11832 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11833 (try_scrolling): Use it when setting scroll_limit.
11834 Limit scrolling to 100 screen lines.
63696a73
EZ
11835 (redisplay_window): Even when falling back on "recentering",
11836 position point in the window according to scroll-conservatively,
11837 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11838
11839 (try_scrolling): When point is above the window, allow searching
11840 as far as scroll_max, or one screenful, to compute vertical
11841 distance from PT to the scroll margin position. This prevents
11842 try_scrolling from unnecessarily failing when
11843 scroll-conservatively is set to a value slightly larger than the
11844 window height. Clean up the case of PT below the margin at bottom
11845 of window: scroll_max can no longer be INT_MAX. When aggressive
11846 scrolling is in use, don't let point enter the opposite scroll
11847 margin as result of the scroll.
11848 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11849 threshold of 100 lines for never-recentering scrolling.
11850
e4cc2dfc
JB
118512011-03-31 Juanma Barranquero <lekktu@gmail.com>
11852
11853 * dispextern.h (move_it_by_lines):
11854 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11855 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11856 (message_log_check_duplicate): Remove parameters `prev_bol' and
11857 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11858 (redisplay_internal): Remove parameter `preserve_echo_area',
11859 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11860
11861 * indent.c (Fvertical_motion):
11862 * window.c (window_scroll_pixel_based, Frecenter):
11863 Don't pass `need_y_p' to `move_it_by_lines'.
11864
1c470562
SM
118652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11866
44f230aa
SM
11867 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11868 steal a few bits to be more compact.
11869 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11870 Remove unneeded casts.
11871
1c470562
SM
11872 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11873
888adce9
ZK
118742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11875
11876 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11877 binding" message (bug#7967).
11878
f838ed7b
PE
118792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11880
77861b95
PE
11881 Fix more problems found by GCC 4.6.0's static checks.
11882
de6dbc14
PE
11883 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11884 Remove unused local var.
11885
f838ed7b
PE
11886 * editfns.c (Fmessage_box): Remove unused local var.
11887
792c7b2b
PE
11888 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11889 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11890 Omit unused local vars.
c499e557 11891 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11892 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11893 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11894 Omit unused local var.
11895
ba0165e1
PE
11896 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11897 Don't assume string length fits in int.
32ad8845 11898 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11899 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11900
3c59b4c9
PE
11901 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11902 instead of alloca (Bug#8344).
11903
a3eed478 11904 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11905 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11906
eb4d412d
PE
11907 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11908
1658b401
PE
11909 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11910 concerns.
11911
11912 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11913
11914 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11915
9a2c6e05
PE
11916 * keyboard.c (syms_of_keyboard): Use the same style as later
11917 in this function when indexing through an array. This also
11918 works around GCC bug 48267.
11919
03d0a109
PE
11920 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11921
44f730c8
PE
11922 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11923
fe75f926
PE
11924 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11925 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11926
ffa8c828
PE
11927 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11928 This avoids undefined behavior on integer overflow, and is a bit
11929 more convenient anyway since it is compared to a size_t variable.
11930
c5101a77
PE
11931 Variadic C functions now count arguments with size_t, not int.
11932 This avoids an unnecessary limitation on 64-bit machines, which
11933 caused (substring ...) to crash on large vectors (Bug#8344).
11934 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11935 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11936 All variadic functions and their callers changed accordingly.
c5101a77
PE
11937 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11938 * data.c (arith_driver, float_arith_driver): Likewise.
11939 * editfns.c (general_insert_function): Likewise.
11940 * eval.c (struct backtrace.nargs, interactive_p)
11941 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11942 (funcall_lambda, mark_backtrace): Likewise.
11943 * fns.c (concat): Likewise.
11944 * frame.c (x_set_frame_parameters): Likewise.
11945 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11946 0 if not found, not -1. All callers changed.
11947
dd3f25f7
PE
11948 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11949 (stack_copy_size): Now size_t, not int.
11950 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11951
461c2ab9
JB
119522011-03-28 Juanma Barranquero <lekktu@gmail.com>
11953
11954 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11955 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11956 All callers changed.
11957
11958 * lisp.h (multibyte_char_to_unibyte):
11959 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11960 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11961 * character.h (CHAR_TO_BYTE8):
11962 * cmds.c (internal_self_insert):
11963 * editfns.c (general_insert_function):
11964 * keymap.c (push_key_description):
11965 * search.c (Freplace_match):
11966 * xdisp.c (message_dolog, set_message_1): All callers changed.
11967
f6d62986
SM
119682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11969
11970 * keyboard.c (safe_run_hook_funcall): New function.
11971 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11972 don't set the hook to nil, but remove the offending function instead.
11973 (Qcommand_hook_internal): Remove, unused.
11974 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11975 Vcommand_hook_internal.
11976
11977 * eval.c (enum run_hooks_condition): Remove.
11978 (funcall_nil, funcall_not): New functions.
11979 (run_hook_with_args): Call each function through a `funcall' argument.
11980 Remove `cond' argument, now redundant.
11981 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11982 (Frun_hook_with_args_until_failure): Adjust accordingly.
11983 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11984
1db5b1ad
JB
119852011-03-28 Juanma Barranquero <lekktu@gmail.com>
11986
11987 * dispextern.h (string_buffer_position): Remove declaration.
11988
11989 * print.c (strout): Remove parameter `multibyte', unused since
11990 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11991
11992 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11993 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11994 All callers changed.
11995
11996 * w32.c (_wsa_errlist): Use braces for struct initializers.
11997
11998 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11999 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12000 All callers changed.
12001 (string_buffer_position): Likewise. Also, make static (it's never
12002 used outside xdisp.c).
12003 (cursor_row_p): Remove parameter `w', unused since
12004 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12005 (decode_mode_spec): Remove parameter `precision', introduced during
12006 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12007 All callers changed.
12008
5ffb62aa
JD
120092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12010
12011 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12012
461c2ab9 120132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12014
12015 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12016 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12017 (ns_update_auto_hide_menu_bar): New functions.
12018 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12019 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12020 ns_constrain_all_frames.
12021 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12022 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12023
5c380ffb
JD
120242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12025
12026 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12027
9af30bdf
GM
120282011-03-27 Glenn Morris <rgm@gnu.org>
12029
12030 * syssignal.h: Replace RETSIGTYPE with void.
12031 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12032 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12033 Replace SIGTYPE with void everywhere.
12034 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12035 * s/template.h (SIGTYPE): Remove commented out definition.
12036
e2abce01
JB
120372011-03-26 Eli Zaretskii <eliz@gnu.org>
12038
12039 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12040 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12041
f868cd8a
JB
120422011-03-26 Juanma Barranquero <lekktu@gmail.com>
12043
59eb0929
JB
12044 * w32.c (read_unc_volume): Use parameter `henum', instead of
12045 global variable `wget_enum_handle'.
12046
12047 * keymap.c (describe_vector): Remove parameters `indices' and
12048 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12049 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12050
f868cd8a
JB
12051 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12052
12053 * keyboard.c (timer_check): Remove parameter `do_it_now',
12054 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12055 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12056 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12057
12058 * keyboard.c (read_char):
12059 * w32menu.c (w32_menu_display_help):
12060 * xmenu.c (show_help_event, menu_help_callback):
12061 Adjust calls to `show_help_echo'.
12062
12063 * gtkutil.c (xg_maybe_add_timer):
12064 * keyboard.c (readable_events):
12065 * process.c (wait_reading_process_output):
12066 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12067
12068 * insdel.c (adjust_markers_gap_motion):
12069 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12070 (gap_left, gap_right): Don't call it.
12071
2ecf6fdb
CY
120722011-03-25 Chong Yidong <cyd@stupidchicken.com>
12073
12074 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12075 incurred during fontification.
12076
6b1f9ba4
JB
120772011-03-25 Juanma Barranquero <lekktu@gmail.com>
12078
12079 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12080 (DEFVAR_PER_BUFFER): Don't pass it.
12081
12082 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12083 (scrolling_window): Don't pass it.
12084
0f4a96b5
JB
120852011-03-25 Juanma Barranquero <lekktu@gmail.com>
12086
12087 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12088
12089 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12090 and `suffix'.
12091 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12092 of variables specific to SELinux and computation of `encoded_absname'.
12093
12094 * image.c (XPutPixel): Remove unused variable `height'.
12095
12096 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12097
12098 * unexw32.c (get_section_info): Remove unused variable `section'.
12099
12100 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12101 (system_process_attributes): Remove unused variable `sess'.
12102 (sys_read): Remove unused variable `err'.
12103
12104 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12105 (w32_wnd_proc): Remove unused variable `isdead'.
12106 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12107 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12108 (x_create_tip_frame): Remove unused variable `tem'.
12109
12110 * w32inevt.c (w32_console_read_socket):
12111 Remove unused variable `no_events'.
12112
12113 * w32term.c (x_draw_composite_glyph_string_foreground):
12114 Remove unused variable `width'.
12115
1149507c
JB
121162011-03-24 Juanma Barranquero <lekktu@gmail.com>
12117
12118 * w32term.c (x_set_glyph_string_clipping):
12119 Don't pass uninitialized region to CombineRgn.
12120
9c88f339
JB
121212011-03-23 Juanma Barranquero <lekktu@gmail.com>
12122
12123 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12124 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12125 (Fx_close_connection): Remove unused variable `i'.
12126
12127 * w32font.c (w32font_draw): Return number of glyphs.
12128 (w32font_open_internal): Remove unused variable `i'.
12129 (w32font_driver): Add missing initializer.
12130
12131 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12132 (fill_in_menu): Remove unused variable `items_added'.
12133
12134 * w32term.c (last_mouse_press_frame): Remove static global variable.
12135 (w32_clip_to_row): Remove unused variable `f'.
12136 (x_delete_terminal): Remove unused variable `i'.
12137
12138 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12139 (NOTHING): Remove unused static global variable.
12140 (uniscribe_check_otf): Remove unused variable `table'.
12141 (uniscribe_font_driver): Add missing initializers.
12142
dee091a3
JD
121432011-03-23 Julien Danjou <julien@danjou.info>
12144
12145 * term.c (Fsuspend_tty, Fresume_tty):
12146 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12147 * window.c (temp_output_buffer_show):
12148 * insdel.c (signal_before_change):
12149 * frame.c (Fhandle_switch_frame):
12150 * fileio.c (Fdo_auto_save):
12151 * emacs.c (Fkill_emacs):
12152 * editfns.c (save_excursion_restore):
12153 * cmds.c (internal_self_insert):
12154 * callint.c (Fcall_interactively):
12155 * buffer.c (Fkill_all_local_variables):
12156 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12157 Use Frun_hooks.
0f4a96b5 12158 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12159 unconditionally since it does the check itself.
dee091a3 12160
2c520ab5 121612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12162
c9c49752
PE
12163 Fix more problems found by GCC 4.5.2's static checks.
12164
8abc3f12
PE
12165 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12166 the first time through the loop, since we know p0 < p1 then.
12167 This also avoids a gcc -Wstrict-overflow warning.
12168
a2d26660
PE
12169 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12170 leading to a memory leak, possible in functions like
12171 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12172 of objects (Bug#8318).
a2d26660 12173
916c72e9
PE
12174 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12175 that could (at least in theory) be that large.
12176
19ab8a18
PE
12177 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12178 This is less likely to overflow, and avoids undefined behavior if
12179 overflow does occur. All callers changed. Use strtoul to scan
12180 for the unsigned long integer.
b7cbbd6f
PE
12181 (pint2hrstr): Simplify and tune code slightly.
12182 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12183
f0641eff
PE
12184 * scroll.c (do_scrolling): Work around GCC bug 48228.
12185 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12186
7f650bb9
PE
12187 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12188 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12189 (validate_x_resource_name): Simplify count usage.
12190 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12191
37dd57d1
PE
12192 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12193 fail (Bug#8306).
81e56e61 12194
699979fc 12195 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12196
401bf9b4
PE
12197 * process.c (Fmake_network_process): Use socklen_t, not int,
12198 where POSIX says socklen_t is required in portable programs.
12199 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12200 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12201 (Fmake_network_process, server_accept_connection):
12202 (wait_reading_process_output, read_process_output):
12203 Likewise.
12204
b93aacde
PE
12205 * process.c: Rename or move locals to avoid shadowing.
12206 (list_processes_1, Fmake_network_process):
12207 (read_process_output_error_handler, exec_sentinel_error_handler):
12208 Rename or move locals.
4dc343ee 12209 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12210 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12211 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12212 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12213 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12214
af8a867c 12215 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12216 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12217 Include tparam.h instead, since it declares them.
af8a867c
PE
12218 * cm.h (PC): Remove extern decl; tparam.h now does this.
12219 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12220 * terminfo.c: Include tparam.h, to check interfaces.
12221 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12222 (tparam): Adjust signature to match interface in tparam.h;
12223 this removes some undefined behavior. Check that outstring and len
12224 are zero, which they always are with Emacs.
12225 * tparam.h (PC, BC, UP): New extern decls.
12226
0248044d 12227 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12228 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12229
8ff096c1 12230 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12231 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12232 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12233 (ftfont_list): Remove unused local.
49eaafba
PE
12234 (get_adstyle_property, ftfont_pattern_entity):
12235 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12236 Rename locals to avoid shadowing.
8ff096c1 12237
e2be39f6
PE
12238 * xfont.c (xfont_list_family): Mark var as initialized.
12239
c9735e30
PE
12240 * xml.c (make_dom): Now static.
12241
8f5201ae
PE
12242 * composite.c (composition_compute_stop_pos): Rename local to
12243 avoid shadowing.
b246f932
PE
12244 (composition_reseat_it): Remove unused locals.
12245 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12246 (composition_update_it): Mark var as initialized.
11b61122
PE
12247 (find_automatic_composition): Mark vars as initialized,
12248 with a FIXME (Bug#8290).
8f5201ae 12249
760fbc2c
PE
12250 character.h: Rename locals to avoid shadowing.
12251 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12252 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12253 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12254 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12255 to avoid shadowing.
12256
ff08eb85
PE
12257 * textprop.c (property_change_between_p): Remove; unused.
12258
fc7bf025
PE
12259 * intervals.c (interval_start_pos): Now static.
12260
235d7abc
PE
12261 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12262
44f230aa
SM
12263 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12264 Rename locals to avoid shadowing.
3e7d6594 12265
50060332
PE
12266 * sound.c (wav_play, au_play, Fplay_sound_internal):
12267 Fix pointer signedness.
d01f234b 12268 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12269 (wav_play): Initialize a variable to 0, to prevent undefined
12270 behavior (Bug#8278).
50060332 12271
c4fc4e30
PE
12272 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12273
918436ed
PE
12274 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12275
c939f91b
PE
12276 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12277 clobbering (Bug#8298).
b9c7f648
PE
12278 * sysdep.c (sys_subshell): Likewise.
12279 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12280
6bd8c144
PE
12281 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12282 This should get cleaned up, so that child_setup has the
12283 same signature on all platforms.
12284
7710357c 12285 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12286 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12287
c59da222
CY
122882011-03-22 Chong Yidong <cyd@stupidchicken.com>
12289
12290 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12291 not to be necessary, and produces flickering.
12292
66b87493
GM
122932011-03-20 Glenn Morris <rgm@gnu.org>
12294
12295 * config.in: Remove file.
12296
45b6f6d5
JB
122972011-03-20 Juanma Barranquero <lekktu@gmail.com>
12298
12299 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12300 are now in src/globals.h.
12301 (syms_of_minibuf): Remove spurious & from previous change.
12302
cd394be1 123032011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12304
12305 * minibuf.c (completing-read-function): New variable.
12306 (completing-read-default): Rename from completing-read.
12307 (completing-read): Call completing-read-function.
12308
b14e3e21
CY
123092011-03-19 Juanma Barranquero <lekktu@gmail.com>
12310
12311 * xfaces.c (Fx_load_color_file):
12312 Read color file from absolute filename (bug#8250).
12313
f2b726e6
JB
123142011-03-19 Juanma Barranquero <lekktu@gmail.com>
12315
12316 * makefile.w32-in: Update dependencies.
12317
09f6ff02
EZ
123182011-03-17 Eli Zaretskii <eliz@gnu.org>
12319
12320 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12321
29a6015a
PE
123222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12323
a3a6c54e
PE
12324 Fix more problems found by GCC 4.5.2's static checks.
12325
b766f867
PE
12326 * process.c (make_serial_process_unwind, send_process_trap):
12327 (sigchld_handler): Now static.
12328
be02381c
PE
12329 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12330 That way, the code declares only the vars that it needs.
12331 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12332 * s/cygwin.h (PTY_ITERATION): Likewise.
12333 * s/darwin.h (PTY_ITERATION): Likewise.
12334 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12335
57048744
PE
12336 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12337 * process.c (allocate_pty): Don't declare stb unless it's needed.
12338
7914961c 12339 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12340 (CONSTANTLIM): Remove; unused.
12341 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12342 Define only if needed.
7914961c 12343
b3967b18
PE
12344 * unexelf.c (unexec): Name an expression,
12345 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12346 Use a different way to cause a compilation error if anyone uses
12347 n rather than nn, a way that does not involve shadowing.
73366a00 12348 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12349
29a6015a
PE
12350 * deps.mk (unexalpha.o): Remove; unused.
12351
43cfc33e 12352 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12353 * unexec.h: New file.
ce701a33
PE
12354 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12355 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12356 Depend on unexec.h.
12357 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12358 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12359 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12360 Change as necessary to match prototype in unexec.h.
ce701a33 12361
01f44d5a
PE
12362 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12363 shadowing.
4f63c6bb 12364 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12365
a6670b0b
PE
12366 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12367 Rename locals to avoid shadowing.
12368
cef2010d 12369 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12370 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12371
d4d7173a
PE
12372 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12373
f08b802a
PE
12374 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12375 warning when compiling print.c.
12376
3ddb0639
PE
12377 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12378 instead of using an uninitialized var.
5ad03b97 12379 (font_sort_entities): Mark var as initialized.
3ddb0639 12380
170a2692
PE
12381 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12382
e663c700
PE
12383 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12384 pointers to constants.
89bc529a 12385 (font_parse_fcname): Remove unused vars.
7b81e2d0 12386 (font_delete_unmatched): Now static.
ea838e10 12387 (font_get_spec): Remove; unused.
13a547c6
PE
12388 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12389 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12390 Rename or move locals to avoid shadowing.
e663c700 12391
2a80c887 12392 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12393 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12394
1384fa33 12395 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12396 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12397
8b2c52e9
PE
12398 * alloc.c (mark_backtrace): Move decl from here ...
12399 * lisp.h: ... to here, so that it can be checked.
12400
475545b5 12401 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12402 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12403 (lisp_indirect_variable): Name an expression,
12404 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12405 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12406
b1349114 12407 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12408 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12409 Use const pointer when appropriate.
b1349114 12410
a2928364
PE
12411 * lisp.h (get_system_name, get_operating_system_release):
12412 Move decls here, to check interfaces.
12413 * process.c (get_operating_system_release): Move decl to lisp.h.
12414 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12415 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12416 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12417 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12418 (Fformat_time_string, Fencode_time, Finsert_char):
12419 (Ftranslate_region_internal, Fformat):
12420 Rename or remove local vars to avoid shadowing.
9710023e 12421 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12422
a415e694
PE
12423 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12424 avoid shadowing.
12425
8ef4622d
PE
12426 * lisp.h (eassert): Check that the argument compiles, even if
12427 ENABLE_CHECKING is not defined.
12428
946f9a5b
PE
12429 * data.c (Findirect_variable): Name an expression, to avoid
12430 gcc -Wbad-function-cast warning.
112396d6 12431 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12432 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12433 (Fmake_variable_buffer_local, Fmake_local_variable):
12434 Mark variables as initialized.
52746918 12435 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12436
e5aab7e7 12437 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12438 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12439 Rename locals to avoid shadowing.
dff45157
PE
12440 (mark_stack): Move local variables into the #ifdef region where
12441 they're used.
7bc26fdb
PE
12442 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12443 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12444 needed otherwise.
12445 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12446 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12447 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12448
e5aab7e7
PE
12449 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12450 avoids undefined behavior in theory.
12451
4da60324
PE
12452 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12453
88043301
PE
12454 Use functions, not macros, for up- and down-casing (Bug#8254).
12455 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12456 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12457 to use the following functions instead of these macros.
12458 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12459 EMACS_INT, since callers assume the returned value fits in int.
12460 (upcase1): Likewise, for UPCASE_TABLE.
12461 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12462 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12463 the race-condition problem in the old DOWNCASE.
88043301 12464
19ed5445
PE
12465 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12466 Rename locals to avoid shadowing.
12467 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12468 (regex_compile, re_search_2, re_match_2_internal):
12469 Remove unused local vars.
952db0d7
PE
12470 (FREE_VAR): Rewrite so as not to use empty "else",
12471 which gcc can warn about.
da053e48 12472 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12473 (RETALLOC_IF): Define only if needed.
12474 (WORDCHAR_P): Likewise. This one is never needed, but is used
12475 only in a comment talking about a compiler bug, so put inside
12476 the #if 0 of that comment.
12477 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12478 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12479 Remove; unused.
19ed5445 12480
1f3561e4 12481 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12482 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12483 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12484
ded6f8f7
PE
12485 * search.c (simple_search): Remove unused var.
12486
dbd37a95
PE
12487 * dired.c (compile_pattern): Move decl from here ...
12488 * lisp.h: ... to here, so that it can be checked.
12489 (struct re_registers): New forward decl.
12490
7e47afad
PE
12491 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12492
85f24f61
PE
12493 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12494 All uses changed.
12495 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12496 Rename locals to avoid shadowing.
5671df8f 12497 (Fvertical_motion): Mark locals as initialized.
85f24f61 12498
181aa2be 12499 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12500 (casify_region): Mark local as initialized.
181aa2be 12501
930d429c
PE
12502 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12503
7082eac6
PE
12504 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12505 New macros, so that the caller can use some names other than
12506 gcpro1, gcpro2, etc.
12507 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12508 of the new macros.
12509 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12510 argument, for consistency with GCPRO2_VAR, etc: it is now the
12511 prefix of the variable, not the variable itself. All uses
12512 changed.
38b2c076
PE
12513 * dired.c (directory_files_internal, file_name_completion):
12514 Rename locals to avoid shadowing.
12515
15206ed9
PE
12516 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12517 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12518 dired.c's scmp function, had undefined behavior.
12519 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12520 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12521 * buffer.h: ... to here, because these macros use current_buffer,
12522 and the new implementation with inline functions needs to have
12523 current_buffer in scope now, rather than later when the macros
12524 are used.
12525 (downcase, upcase1): New static inline functions.
12526 (DOWNCASE, UPCASE1): Reimplement using these functions.
12527 This avoids undefined behavior in expressions like
12528 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12529 from race conditions in accessing the global variables
12530 case_temp1 and case_temp2.
12531 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12532 * lisp.h (case_temp1, case_temp2): Remove their decls.
12533 * character.h (ASCII_CHAR_P): Move from here ...
12534 * lisp.h: ... to here, so that the inline functions mentioned
12535 above can use them.
12536
4a6bea26
PE
12537 * dired.c (directory_files_internal_unwind): Now static.
12538
f14b7e14
PE
12539 * fileio.c (file_name_as_directory, directory_file_name):
12540 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12541 Now static.
2893f146
PE
12542 (file_name_as_directory): Use const pointers when appropriate.
12543 (Fexpand_file_name): Likewise. In particular, newdir might
12544 point at constant storage, so make it a const pointer.
fd4ead52 12545 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12546 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12547 signedness issues.
f839df0c
PE
12548 (Fset_file_times, Finsert_file_contents, auto_save_error):
12549 Rename locals to avoid shadowing.
f14b7e14 12550
5716756e 12551 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12552 (Ftry_completion, Fall_completions): Rename or remove locals
12553 to avoid shadowing.
5716756e 12554
b4c3046a
PE
12555 * marker.c (bytepos_to_charpos): Remove; unused.
12556
b45db522
PE
12557 * lisp.h (verify_bytepos, count_markers): New decls,
12558 so that gcc does not warn that these functions aren't declared.
12559
85876d07
PE
12560 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12561 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12562 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12563 (copy_text): Remove unused local var.
85876d07 12564
03d78a21 12565 * filelock.c (within_one_second): Now static.
b3dd38ab 12566 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12567
5df8f01b
PE
12568 * buffer.c (fix_overlays_before): Mark locals as initialized.
12569 (fix_start_end_in_overlays): Likewise. This function should be
12570 simplified by using pointers-to-pointers, but that's a different
12571 matter.
b1d876f1 12572 (switch_to_buffer_1): Now static.
8f54f30a
PE
12573 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12574 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12575
a70072c9 12576 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12577 Fix pointer signedness issue.
edced198
PE
12578 (sys_subshell): Mark local as volatile if checking for lint,
12579 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12580 (MAXPATHLEN): Define only if needed.
a70072c9 12581
a0977c44
PE
12582 * process.c (serial_open, serial_configure): Move decls from here ...
12583 * systty.h: ... to here, so that they can be checked.
12584
a884fdcc
PE
12585 * fns.c (get_random, seed_random): Move extern decls from here ...
12586 * lisp.h: ... to here, so that they can be checked.
12587
604efe86 12588 * sysdep.c (reset_io): Now static.
b8950c94 12589 (wait_for_termination_signal): Remove; unused.
604efe86 12590
38fc62d9
PE
12591 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12592 (copy_keymap_item, append_key, push_text_char_description):
12593 Now static.
1004a21a 12594 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12595 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12596 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12597 (describe_map_tree):
12598 Rename locals to avoid shadowing.
38fc62d9 12599
2f2650da
PE
12600 * keyboard.c: Declare functions static if they are not used elsewhere.
12601 (echo_char, echo_dash, cmd_error, top_level_2):
12602 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12603 (read_char, kbd_buffer_get_event, make_lispy_position):
12604 (make_lispy_event, make_lispy_movement, apply_modifiers):
12605 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12606 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12607 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12608 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12609 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12610
a053e86c 12611 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12612 (mark_kboards): Move decl here ...
12613 * alloc.c (mark_kboards): ... from here.
a053e86c 12614
4752793e
PE
12615 * lisp.h (force_auto_save_soon): New decl.
12616
74f10ca7 12617 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12618 (DEFINE_DUMMY_FUNCTION): New macro.
12619 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12620 Use it.
c03cd23f
PE
12621 (main): Add casts to avoid warnings
12622 if GCC considers string literals to be constants.
74f10ca7 12623
022e70d4
PE
12624 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12625
59d6fe83
PE
12626 * dbusbind.c: Pointer signedness fixes.
12627 (xd_signature, xd_append_arg, xd_initialize):
12628 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12629 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12630 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12631 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12632
78320123
PE
12633 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12634 if GCC considers string literals to be constants.
49cebcca 12635 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12636
35ac2a97
SM
126372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12638
fb103ca9
SM
12639 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12640 (print_preprocess, print_object): New macro to fix last change.
12641
35ac2a97
SM
12642 * print.c (print_preprocess): Don't forget font objects.
12643
62973b41
JB
126442011-03-16 Juanma Barranquero <lekktu@gmail.com>
12645
12646 * emacs.c (USAGE3): Doc fixes.
12647
0e48bb22
AS
126482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12649
12650 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12651 structure.
12652
7684e57b
JB
126532011-03-14 Juanma Barranquero <lekktu@gmail.com>
12654
12655 * lisp.h (VWindow_system, Qfile_name_history):
12656 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12657 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12658 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12659
12660 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12661 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12662
12663 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12664 * w32console.c (detect_input_pending, read_input_pending)
12665 (encode_terminal_code):
12666 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12667 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12668 (w32_system_caret_y, Qfile_name_history):
12669 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12670 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12671 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12672 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12673 * w32proc.c (Qlocal, report_file_error):
12674 * w32term.c (Vwindow_system, updating_frame):
12675 * w32uniscribe.c (initialized, uniscribe_font_driver):
12676 Remove unneeded extern declarations.
12677
2aa46d6c
CY
126782011-03-14 Chong Yidong <cyd@stupidchicken.com>
12679
c96bbc66 12680 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12681
cffc6f3b
CY
126822011-03-13 Chong Yidong <cyd@stupidchicken.com>
12683
12684 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12685 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12686 These macros can no longer be used for assignment.
12687
44f230aa
SM
12688 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12689 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12690 (record_buffer_markers, fetch_buffer_markers): New functions for
12691 recording and fetching special buffer markers.
12692 (set_buffer_internal_1, set_buffer_temp): Use them.
12693
12694 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12695
12696 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12697
12698 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12699 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12700
12701 * xdisp.c (hscroll_window_tree):
12702 (reconsider_clip_changes): Use PT instead of BUF_PT.
12703
d251f04b
EZ
127042011-03-13 Eli Zaretskii <eliz@gnu.org>
12705
12706 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12707 $(EMACS_ROOT)/lib/intprops.h.
12708
f0c77cd1
PE
127092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12710
3eca4629
PE
12711 Fix more problems found by GCC 4.5.2's static checks.
12712
7c86ee98
PE
12713 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12714 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12715 (xg_free_frame_widgets): Make it clear that a local variable is
12716 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12717 (gdk_window_get_screen): Make it clear that this macro is needed
12718 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12719 (int_gtk_range_get_value): New function, which avoids a diagnostic
12720 from gcc -Wbad-function-cast.
12721 (xg_set_toolkit_scroll_bar_thumb): Use it.
12722 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12723 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12724 (get_utf8_string, xg_get_file_with_chooser):
12725 Rename locals to avoid shadowing.
12726 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12727
41729b81
PE
12728 * xgselect.c (xg_select): Remove unused var.
12729
f0c77cd1
PE
12730 * image.c (four_corners_best): Mark locals as initialized.
12731 (gif_load): Initialize transparent_p to zero (Bug#8238).
12732 Mark another local as initialized.
ec6cf4c6 12733 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12734
ce0ad53d 12735 * image.c (clear_image_cache): Now static.
d5d5a617 12736 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12737 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12738 (x_edge_detection): Remove unnecessary cast that
12739 gcc -Wbad-function-cast diagnoses.
2037898d 12740 (gif_load): Fix pointer signedness.
6ae141d6
PE
12741 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12742 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12743
33383987 127442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12745
d32df629
PE
12746 Improve quality of tests for time stamp overflow.
12747 For example, without this patch (encode-time 0 0 0 1 1
12748 1152921504606846976) returns the obviously-bogus value (-948597
12749 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12750 reports time overflow. See
12751 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12752 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12753 * editfns.c: Include limits.h and intprops.h.
12754 (TIME_T_MIN, TIME_T_MAX): New macros.
12755 (time_overflow): Move earlier, to before first use.
12756 (hi_time, lo_time): New functions, for an accurate test for
12757 out-of-range times.
12758 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12759 (Fget_internal_run_time): Don't assume time_t fits in int.
12760 (make_time): Use list2 instead of Fcons twice.
12761 (Fdecode_time): More accurate test for out-of-range times.
12762 (check_tm_member): New function.
12763 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12764 (lisp_time_argument): Don't rely on undefined left-shift and
12765 right-shift behavior when checking for time stamp overflow.
8be6f318 12766
fe31d94c
PE
12767 * editfns.c (time_overflow): New function, refactoring common code.
12768 (Fformat_time_string, Fdecode_time, Fencode_time):
12769 (Fcurrent_time_string): Use it.
12770
8be6f318
PE
12771 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12772 * dired.c (make_time): Move to ...
12773 * editfns.c (make_time): ... here.
12774 * systime.h: Note the move.
12775
09d9db2c 127762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12777
126bc0dc
YM
12778 * fringe.c (update_window_fringes): Remove unused variables.
12779
c47cbdfd
YM
12780 * unexmacosx.c (copy_data_segment): Also copy __got section.
12781 (Bug#8223)
12782
7ac80be9
EZ
127832011-03-12 Eli Zaretskii <eliz@gnu.org>
12784
c96bbc66 12785 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12786 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12787 Constify `char *' arguments and their references according to
12788 prototypes in tparam.h.
12789
ecb0f94d 12790 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12791
7ac80be9
EZ
12792 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12793 Adapt all references accordingly.
12794
12795 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12796
ef1fd07e
TT
127972011-03-11 Tom Tromey <tromey@redhat.com>
12798
12799 * buffer.c (syms_of_buffer): Remove obsolete comment.
12800
7ef4b50c
EZ
128012011-03-11 Eli Zaretskii <eliz@gnu.org>
12802
12803 * termhooks.h (encode_terminal_code): Declare prototype.
12804
12805 * msdos.c (encode_terminal_code): Don't declare prototype.
12806
12807 * term.c (encode_terminal_code): Now external again, used by
12808 w32console.c and msdos.c.
12809
44f230aa
SM
12810 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12811 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12812
4b1ec863 128132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12814
1714f52b 12815 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12816
4b1ec863
PE
12817 * fringe.c (update_window_fringes): Mark locals as initialized
12818 (Bug#8227).
12819 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12820
524c7aa6
PE
12821 * alloc.c (mark_fringe_data): Move decl from here ...
12822 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12823 to check its interface.
12824 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12825
a5c0af81 12826 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12827 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12828 (fontset_font): Mark local as initialized.
a9a06e0b 12829 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12830
b4716021
PE
12831 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12832
811e9bac 12833 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12834 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12835 (x_own_selection, Fx_disown_selection_internal): Rename locals
12836 to avoid shadowing.
12837 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12838
7e3ab302
PE
12839 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12840 so that the caller can use some name other than gcpro1.
12841 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12842 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12843 (Fx_backspace_delete_keys_p):
12844 Use them to avoid shadowing, and rename vars to avoid shadowing.
12845 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12846 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12847 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12848 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12849 Remove unused locals.
7e3ab302
PE
12850 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12851 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12852 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12853 macros.
f78faa98 12854
e2b13473
PE
12855 * xterm.h (x_mouse_leave): New decl.
12856
77f23912
PE
12857 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12858 Remove unused functions.
cdf4ba58
PE
12859 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12860 (x_calc_absolute_position): Now static.
7411c686 12861 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12862 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12863 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12864 unless they are used.
38d0b34a
PE
12865 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12866 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12867 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12868 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12869 (x_error_catcher, x_connection_closed, x_error_handler):
12870 (x_error_quitter, xembed_send_message, x_iconify_frame):
12871 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12872 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12873 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12874
44f230aa
SM
12875 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12876 Rename or move locals to avoid shadowing.
6b463e58 12877 (tty_defined_color, merge_face_heights): Now static.
5967d051 12878 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12879 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12880 does not deduce is never used uninitialized.
73719eba
PE
12881 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12882 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12883
426994c3 12884 * terminal.c (store_terminal_param): Now static.
5489860b 12885
032f1620 12886 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12887 (set_frame_menubar): Remove unused local.
d4323972 12888 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12889 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12890 since they might point to immutable storage.
281585b0
PE
12891 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12892 since it's unused otherwise.
032f1620 12893
367c19e5 12894 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12895 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12896 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12897 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12898 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12899 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12900 does not deduce are never used uninitialized.
70739cbe 12901
07b48fa9
PE
12902 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12903
8868a238 12904 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12905 * window.c (window_loop, size_window):
12906 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12907
7e5cf297 12908 * window.c (display_buffer): Now static.
d6550a9f
PE
12909 (size_window): Mark variables that gcc -Wuninitialized
12910 does not deduce are never used uninitialized.
a586633d
PE
12911 * window.h (check_all_windows): New decl, to forestall
12912 gcc -Wmissing-prototypes diagnostic.
5b555da1 12913 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12914
f6095868
PE
12915 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12916 shadowing.
12917 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12918 Include <limits.h>.
12919 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12920 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12921 (load_charset_map): Mark variables that gcc -Wuninitialized
12922 does not deduce are never used uninitialized.
53df7c11 12923 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12924
f38b440c
PE
12925 * coding.c (coding_set_source, coding_set_destination):
12926 Use "else { /* comment */ }" rather than "else /* comment */;"
12927 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12928 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12929 a block, when the outer 'i' will do.
12930 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12931 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12932 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12933 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12934 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12935 Rename locals to avoid shadowing.
12936 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12937 * coding.c (emacs_mule_char, encode_invocation_designation):
12938 Now static, since they're not used elsewhere.
413bb2db 12939 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12940 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12941 (decode_coding_emacs_mule): Mark variables that gcc
12942 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12943 (detect_coding_iso_2022): Initialize a local variable that might
12944 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12945 this initialization is needed. (Bug#8211)
5f58e762
PE
12946 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12947 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12948 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12949 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12950 Remove unused macros.
f38b440c 12951
232b38b9 12952 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12953 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12954 * character.c (string_count_byte8): Likewise.
232b38b9 12955
fb90da1b
PE
12956 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12957 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12958
fb93dbc2
PE
12959 * chartab.c (copy_sub_char_table): Now static, since it's not used
12960 elsewhere.
5c156ace
PE
12961 (sub_char_table_ref_and_range, char_table_ref_and_range):
12962 Rename locals to avoid shadowing.
bbcd0949 12963 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12964
7d3b3862 12965 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12966 (BIDI_BOB): Remove unused macro.
7d3b3862 12967
6be7d3da
PE
12968 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12969 deduce are never used uninitialized.
c2ed9c8b 12970 * term.c (encode_terminal_code): Likewise.
6be7d3da 12971
75f8807f 12972 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12973
50938595
PE
12974 * tparam.h: New file.
12975 * term.c, tparam.h: Include it.
12976 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12977 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12978 Move these decls to tparam.h, and make them agree with what
12979 is actually in tparam.c. The previous trick of using incompatible
12980 decls in different modules does not conform to the C standard.
12981 All callers of tparam changed to use tparam's actual API.
12982 * tparam.c (tparam1, tparam, tgoto):
12983 Use const pointers where appropriate.
12984
fbceeba2
PE
12985 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12986 * cm.h (struct cm): Likewise.
12987 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12988 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12989 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12990 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12991 (turn_on_face, init_tty): Likewise.
12992 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12993
7f3f1250
PE
12994 * term.c (term_mouse_position): Rename local to avoid shadowing.
12995
e6ca6543
PE
12996 * alloc.c (mark_ttys): Move decl from here ...
12997 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12998
c40f8d15
AS
129992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13000
13001 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13002
cfe0661d
JB
130032011-03-09 Juanma Barranquero <lekktu@gmail.com>
13004
13005 * search.c (compile_pattern_1): Remove argument regp, unused since
13006 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13007 (compile_pattern): Don't pass it.
13008
0afb4571
J
130092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13010
13011 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13012 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13013 for ! HAVE_GTK3.
13014 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13015
13016 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13017
13018 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13019 gdk_window_get_screen, gdk_window_get_geometry,
13020 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13021 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13022 (xg_get_pixbuf_from_pixmap): New function.
13023 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13024 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13025 Call xg_get_pixbuf_from_pixmap instead of
13026 gdk_pixbuf_get_from_drawable.
13027 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13028 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13029 (xg_check_special_colors): Use GtkStyleContext and its functions
13030 for HAVE_GTK3.
13031 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13032 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13033 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13034 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13035 Call gtk_widget_get_preferred_size.
0afb4571
J
13036 (xg_frame_resized): gdk_window_get_geometry only takes 5
13037 parameters.
44f230aa
SM
13038 (xg_win_to_widget, xg_event_is_for_menubar):
13039 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13040 (xg_set_widget_bg): New function.
13041 (delete_cb): New function.
895009e1 13042 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13043 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13044 (xg_set_background_color): Call xg_set_widget_bg.
13045 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13046 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13047 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13048 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13049 if ! HAVE_GTK3.
13050 (update_frame_tool_bar): Call gtk_widget_hide.
13051 (xg_initialize): Use GDK_KEY_g.
13052
13053 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13054 if ! HAVE_GTK3
13055 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13056
13057 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13058 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13059 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13060
1c2cc4ef
JB
130612011-03-08 Juanma Barranquero <lekktu@gmail.com>
13062
13063 * w32xfns.c (select_palette): Check success of RealizePalette against
13064 GDI_ERROR, not zero.
13065
33383987 13066See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13067
13068;; Local Variables:
13069;; coding: utf-8
aac0c6e3
MR
13070;; End:
13071
2f097256 13072 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13073
13074 This file is part of GNU Emacs.
13075
13076 GNU Emacs is free software: you can redistribute it and/or modify
13077 it under the terms of the GNU General Public License as published by
13078 the Free Software Foundation, either version 3 of the License, or
13079 (at your option) any later version.
13080
13081 GNU Emacs is distributed in the hope that it will be useful,
13082 but WITHOUT ANY WARRANTY; without even the implied warranty of
13083 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13084 GNU General Public License for more details.
13085
13086 You should have received a copy of the GNU General Public License
13087 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.