compile/grep fix for bug#10594
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3c2907f7
CY
12012-01-21 Chong Yidong <cyd@gnu.org>
2
3 * floatfns.c (Fcopysign): Make the second argument non-optional,
4 since nil is not allowed anyway.
5
959ad23f
AS
62012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7
8 * process.c (read_process_output): Use p instead of XPROCESS (proc).
9 (send_process): Likewise.
10
34a02f46
MR
112012-01-19 Martin Rudalics <rudalics@gmx.at>
12
13 * window.c (save_window_save, Fcurrent_window_configuration)
14 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
15 doc-strings.
16
1259009a 172012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
18
19 * character.c (char_width): New function.
70d4fdf6
GM
20 (Fchar_width, c_string_width, lisp_string_width):
21 Use char_width (Bug#9496).
25ed9e61 22
6a6ee00d
MR
232012-01-16 Martin Rudalics <rudalics@gmx.at>
24
25 * window.c (Vwindow_persistent_parameters): New variable.
26 (Fset_window_configuration, save_window_save): Handle persistent
27 window parameters.
28
c85efaf7
EZ
292012-01-14 Eli Zaretskii <eliz@gnu.org>
30
31 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
32 thrashing the stack of the thread. (Bug#9087)
33
5944709e
PE
342012-01-12 Paul Eggert <eggert@cs.ucla.edu>
35
36 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
37
e71f5d99
EZ
382012-01-11 Eli Zaretskii <eliz@gnu.org>
39
40 * xdisp.c (rows_from_pos_range): Handle the case where the
41 highlight ends on a newline. (Bug#10464)
42 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
43 he end column for display of highlight that ends on a newline
44 before a R2L line.
45
ce316182
GM
462012-01-11 Glenn Morris <rgm@gnu.org>
47
48 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
49 from load-path also when installation-directory is nil. (Bug#10208)
50
5b43da69
GM
512012-01-10 Glenn Morris <rgm@gnu.org>
52
74cc8ff9
GM
53 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
54
7d8d6e4e
GM
55 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
56 Update template values to be closer to their typical values these days.
5b43da69 57
a0db8d43
EZ
582012-01-09 Eli Zaretskii <eliz@gnu.org>
59
60 * xdisp.c (rows_from_pos_range): Accept additional argument
61 DISP_STRING, and accept any glyph in a row whose object is that
62 string as eligible for mouse highlight. Fixes mouse highlight of
63 display strings from overlays. (Bug#10464)
64
9a0115ab 652012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 66
b9110d6a 67 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
68 * fileio.c (auto_saving_dir_umask): New static var.
69 (Fmake_directory_internal): Use it.
70 (do_auto_save_make_dir): Set it, instead of invoking chmod after
71 creating the directory. The old code temporarily assigns
72 too-generous permissions to the directory.
73 (do_auto_save_eh): Clear it.
b9110d6a 74 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
75 that the var is always cleared.
76
6c1bd3f3
EZ
772012-01-07 Eli Zaretskii <eliz@gnu.org>
78
79 * search.c (scan_buffer): Pass character positions to
80 know_region_cache, not byte positions. (Bug#6540)
81
069d2b50
L
822012-01-07 LynX <_LynX@bk.ru> (tiny change)
83
84 * w32.c (sys_rename): Report EXDEV when rename of a directory
85 fails because the target is on another logical disk. (Bug#10284)
86
75bf0d33
DB
872012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
88
89 * xterm.c (x_embed_request_focus): New function.
90
91 * xterm.h: Add prototype.
92
93 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
94
1c6e5a32
GM
952012-01-05 Glenn Morris <rgm@gnu.org>
96
97 * emacs.c (emacs_copyright): Update short copyright year to 2012.
98
651e947e
EZ
992012-01-01 Eli Zaretskii <eliz@gnu.org>
100
101 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
102 Load gnutls_transport_set_lowat only if GnuTLS version is below
103 2.11.1.
104 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
105 GnuTLS versions below 2.11.1.
106
3778cdd8
AL
1072011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
108
109 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
110 to the doc string advising against its use for altering the way
111 windows are scrolled.
112
0e5317f7
KH
1132011-12-28 Kenichi Handa <handa@m17n.org>
114
115 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
116 coding-system ASCII compatible only when it does not produce BOM
117 on encoding (Bug#10383).
118
93d5ca1f
JD
1192011-12-26 Jan Djärv <jan.h.d@swipnet.se>
120
121 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
122 can scroll.
123 (create_and_show_popup_menu): Always use menu_position_func for
124 Gtk3 (Bug#10361).
125
ca22b785
AS
1262011-12-24 Andreas Schwab <schwab@linux-m68k.org>
127
128 * callint.c (Fcall_interactively): Don't truncate prompt string.
129
d048e1e6
EZ
1302011-12-23 Eli Zaretskii <eliz@gnu.org>
131
132 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
133 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 134 resumed from there (after widening). (Bug#10360)
d048e1e6 135
5ccaba1f
JD
1362011-12-22 Jan Djärv <jan.h.d@swipnet.se>
137
138 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
139
204ee57f
JD
1402011-12-21 Jan Djärv <jan.h.d@swipnet.se>
141
b81d40f0
JB
142 * nsterm.m (x_free_frame_resources):
143 Release f->output_data.ns->miniimage.
204ee57f
JD
144 (ns_index_color): Fix indentation. Do not retain
145 color_table->colors[i].
146
147 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
148 before returning.
149
150 * nsfns.m (x_set_background_color): Assign return value from
151 ns_index_color to face-background instead of NSColor*.
152 (ns_implicitly_set_icon_type): Fix indentation.
153 Change assignment in for loop to comparison.
154
155 * emacs.c (ns_pool): New variable.
156 (main): Assign ns_pool.
157 (Fkill_emacs): Call ns_release_autorelease_pool.
158
159 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
160 autorelease fdesc, release fdAttrs and tdict.
161 (ns_get_covering_families): Release charset.
162 (ns_findfonts): Release NSFontDescriptor created with new.
163 (ns_uni_to_glyphs): Fix indentation.
164 (setString): Release attrStr before assigning new value.
165
c803b2b7
JD
1662011-12-18 Jan Djärv <jan.h.d@swipnet.se>
167
678f4426
JD
168 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
169 and NS_IMPL_COCOA.
170 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
171 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
172
cd394be1 1732011-12-18 David Reitter <reitter@cmu.edu>
678f4426 174
5fecd5fc
JD
175 * nsterm.m (ns_term_init): Subscribe for notifications
176 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
177 to method trackingNotification in EmacsMenu.
178
179 * nsmenu.m (trackingMenu): New variable.
3771cb17 180 (trackingNotification): New method (from Aquamacs).
5fecd5fc 181 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 182 from Aquamacs (Bug#7030).
678f4426
JD
183
1842011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 185
c803b2b7
JD
186 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
187 (symbol_to_nsstring): Fix indentation.
188 (ns_symbol_to_pb): New function.
189 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
190 (Fns_rotate_cut_buffers_internal): Removed.
191 (Fns_store_selection_internal): Renamed from
192 Fns_store_cut_buffer_internal.
193 (ns_get_foreign_selection, Fx_own_selection_internal)
194 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
195 (Fns_get_selection_internal, Fns_store_selection_internal):
196 Use ns_symbol_to_pb and check if return value is nil.
197 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
198 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
199 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
200 renamed to Sns_store_selection_internal.
201 (ns_handle_selection_request): Move code to Fx_own_selection_internal
202 and remove this function.
203 (ns_handle_selection_clear): Remove, never used.
204 (Fx_own_selection_internal): Move code from ns_handle_selection_request
205 here.
206
e1b01a3a
KB
2072011-12-17 Ken Brown <kbrown@cornell.edu>
208
209 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
210 GID is unknown (Bug#10257).
211
2adb6e85
PE
2122011-12-17 Paul Eggert <eggert@cs.ucla.edu>
213
214 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
215 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
216 which caused a build failure on GNU/Linux IA-64. This problem was
217 introduced by my 2011-10-07 patch.
218
d1d7b339
JL
2192011-12-15 Juri Linkov <juri@jurta.org>
220
221 * image.c (imagemagick_error): New function. (Bug#10112)
222 (imagemagick_load_image): Comment out `MagickSetResolution' call.
223 Use `imagemagick_error' where ImageMagick functions return
224 `MagickFalse'.
225 (Fimagemagick_types): Add `Fnreverse' to return the list in the
226 proper order.
227
100d5755
KH
2282011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
229
230 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
231 fill background (Bug#8992).
232
454592a6
MR
2332011-12-13 Martin Rudalics <rudalics@gmx.at>
234
235 * window.c (Vwindow_combination_resize)
236 (Vwindow_combination_limit): Use t instead of non-nil in
237 doc-strings.
61d4b438
MR
238 (Vrecenter_redisplay): Add first sentence of doc-string on
239 separate line.
53524d93 240 (Frecenter): Fix doc-string typo.
454592a6 241
3633e3aa
KH
2422011-12-11 Kenichi Handa <handa@m17n.org>
243
244 * coding.c (Funencodable_char_position): Pay attention to the
245 buffer text relocation (Bug#9389).
246
7b9d523a
JD
2472011-12-10 Jan Djärv <jan.h.d@swipnet.se>
248
249 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
250 gtk_init (Bug#10100).
251
b73189c6
EZ
2522011-12-10 Eli Zaretskii <eliz@gnu.org>
253
254 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
255 IT->string is nil. (Bug#10263)
256
f7dfe5d6
JD
2572011-12-10 Jan Djärv <jan.h.d@swipnet.se>
258
83faebb4
JD
259 * nsterm.h (x_free_frame_resources): Declare.
260
f7dfe5d6
JD
261 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
262 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
263
264 * nsterm.h (ns_get_defaults_value): Declare.
265
266 * nsterm.m (ns_default): Call ns_get_defaults_value.
267
7cd4e72c
EZ
2682011-12-09 Eli Zaretskii <eliz@gnu.org>
269
270 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
271 (Bug#10170)
272
b34d7317
YM
2732011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
274
275 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
276 that where the value of an _OBJC_* symbol points to is in the .bss
277 section (Bug#10240).
278
76470ad1
KH
2792011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
280
281 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 282 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 283
745fff94
KH
2842011-12-08 Kenichi Handa <handa@m17n.org>
285
286 * ftfont.c (get_adstyle_property): Fix previous change
287 (Bug#10233).
288
6e44397c
JB
2892011-12-07 Juanma Barranquero <lekktu@gmail.com>
290
291 * w32.c (init_environment): If no_site_lisp, remove site-lisp
292 dirs from the default value of EMACSLOADPATH (bug#10208).
293
7efa6272
GM
2942011-12-07 Glenn Morris <rgm@gnu.org>
295
296 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
297 installation and source directories as well. (Bug#10208)
298
f6fc4d87
CY
2992011-12-06 Chong Yidong <cyd@gnu.org>
300
301 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
302
2bf26180
GM
3032011-12-06 Glenn Morris <rgm@gnu.org>
304
305 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
306 as an error, not just -1. (Bug#10217)
307
3a6ad4f0
CY
3082011-12-05 Chong Yidong <cyd@gnu.org>
309
310 * keyboard.c (process_special_events): New function.
311 (swallow_events, Finput_pending_p): Use it (Bug#10195).
312
75a3b399
PE
3132011-12-05 Paul Eggert <eggert@cs.ucla.edu>
314
315 * coding.c (encode_designation_at_bol): Don't use uninitialized
316 local variable (Bug#9318).
317
c3c9e25e
KH
3182011-12-05 Kenichi Handa <handa@m17n.org>
319
320 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
321 return Qnil (Bug#8046, Bug#10193).
322
5eb05ea3
KH
3232011-12-05 Kenichi Handa <handa@m17n.org>
324
325 * coding.c (encode_designation_at_bol): New args charbuf_end and
326 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
327 (coding_set_source): Return how many bytes coding->source was
328 relocated.
329 (coding_set_destination): Return how many bytes
330 coding->destination was relocated.
331 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
332 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
333
3342011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
335
336 * coding.c (CODING_CHAR_CHARSET_P): New macro.
337 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
338 macro (Bug#9318).
339
3402011-12-05 Andreas Schwab <schwab@linux-m68k.org>
341
342 The following changes are to fix Bug#9318.
343
a79703f5 344 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
345 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
346 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 347 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 348
7dbda6df
JB
3492011-12-05 Juanma Barranquero <lekktu@gmail.com>
350
351 * lisp.h (process_quit_flag): Fix external declaration.
352
6d5eb5b0
SM
3532011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
354
355 Don't macro-inline non-performance-critical code.
356 * eval.c (process_quit_flag): New function.
357 * lisp.h (QUIT): Use it.
358
a0c3fad0
JD
3592011-12-04 Jan Djärv <jan.h.d@swipnet.se>
360
361 * nsfns.m (get_geometry_from_preferences): New function.
362 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
363
6c07aac2
AS
3642011-12-04 Andreas Schwab <schwab@linux-m68k.org>
365
366 * emacs.c (Qkill_emacs): Define.
367 (syms_of_emacs): Initialize it.
368 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
369 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
370 (quit_throw_to_read_char): Add parameter `from_signal'.
371 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
372 * lisp.h (QUIT): Call Fkill_emacs if requested.
373
c052ead4
JD
3742011-12-03 Jan Djärv <jan.h.d@swipnet.se>
375
376 * widget.c (update_wm_hints): Return if wmshell is null.
377 (widget_update_wm_size_hints): New function.
378
379 * widget.h (widget_update_wm_size_hints): Declare.
380
381 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
382 widget_update_wm_size_hints (Bug#10104).
383
9e49252b
EZ
3842011-12-03 Eli Zaretskii <eliz@gnu.org>
385
386 * xdisp.c (handle_invisible_prop): If the invisible text ends just
387 before a newline, prepare the bidi iterator for consuming the
388 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 389 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 390
02b16839
JL
3912011-12-02 Juri Linkov <juri@jurta.org>
392
393 * search.c (Fword_search_regexp): New Lisp function created from
394 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
395 (Fword_search_backward, Fword_search_forward)
396 (Fword_search_backward_lax, Fword_search_forward_lax):
397 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
398 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
399
0068070e
SM
4002011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
401
402 * fileio.c (Finsert_file_contents): Move after-change-function call
403 to before the "handled:" label, since all "goto handled" appear in
404 cases where the *-change-functions have already been properly called
405 (bug#10117).
406
3360a3fc
AS
4072011-12-01 Andreas Schwab <schwab@linux-m68k.org>
408
409 * keyboard.c (interrupt_signal): Don't call kill-emacs when
410 waiting for input. (Bug#10169)
411
73d6c093
EZ
4122011-11-30 Eli Zaretskii <eliz@gnu.org>
413
414 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
415 verifies glyph row's hash code--we have just reallocated the
416 glyphs, so their contents can be complete garbage. (Bug#10164)
417
febe6bea
JB
4182011-11-30 Juanma Barranquero <lekktu@gmail.com>
419
420 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
421
801a4313
EZ
4222011-11-30 Eli Zaretskii <eliz@gnu.org>
423
424 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
425 attributes are tested _before_ calling verify_row_hash, to protect
426 against GCC re-ordering of the tests. (Bug#10164)
427
2b56b87e
JD
4282011-11-29 Jan Djärv <jan.h.d@swipnet.se>
429
430 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
431
432 * xterm.c (handle_one_xevent): Only set async_visible and friends
433 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 434 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
435 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
436
dbf31225
PE
4372011-11-28 Paul Eggert <eggert@cs.ucla.edu>
438
439 Remove GCPRO-related macros that exist only to avoid shadowing locals.
440 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
441 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
442 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
443 All uses changed to use GCPRO1 etc.
444 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
445 Revert to old implementation (i.e., before 2011-03-11).
446
1305621b
YM
4472011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
448
449 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
450 of scroll runs so as to avoid assigning disabled bogus rows and
451 unnecessary graphics copy operations.
452
8c9afb46
EZ
4532011-11-27 Eli Zaretskii <eliz@gnu.org>
454
455 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
456 (snprintf) [_MSC_VER]: Redirect to _snprintf.
457 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
458 (malloc, free, realloc, calloc): Redirect to e_* only when
459 compiling Emacs.
460
461 * lisp.h (GCTYPEBITS): Move before first use.
462 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
463 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
464 this macro definition.
465
466 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
467 _MSC_VER.
468
54e9e3bf
JD
4692011-11-27 Jan Djärv <jan.h.d@swipnet.se>
470
6d5eb5b0
SM
471 * gtkutil.c (xg_create_frame_widgets):
472 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
473 present with Gtk+ 2.0.
474
83aca1cb
PE
4752011-11-26 Paul Eggert <eggert@cs.ucla.edu>
476
477 * fileio.c (Finsert_file_contents): Undo previous change; see
478 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
479
5b76caa4
PE
4802011-11-26 Paul Eggert <eggert@cs.ucla.edu>
481
482 Rename locals to avoid shadowing.
483 * fileio.c (Finsert_file_contents):
484 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
485 * process.c (wait_reading_process_output):
486 Rename inner 'proc' to 'p' to avoid shadowing.
487 Indent for consistency with usual Emacs style.
488
8c535114
EZ
4892011-11-25 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (redisplay_window): If cursor row is not fully visible
492 after recentering, and scroll-conservatively is set to a large
493 number, scroll window by a few more lines to make the cursor fully
494 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
495 (start_display): Don't move to the next line if the display should
496 start at a newline that is part of a display vector or an overlay
497 string. (Bug#10119)
8c535114 498
fa4fdb5c
JL
4992011-11-24 Juri Linkov <juri@jurta.org>
500
501 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
502 after the `MagickPingImage' call. (Bug#10112)
503
90ec88df
CY
5042011-11-23 Chong Yidong <cyd@gnu.org>
505
506 * window.c (Fcoordinates_in_window_p): Accept only live windows.
507
56e2e794
MR
5082011-11-23 Martin Rudalics <rudalics@gmx.at>
509
510 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
511 making another buffer current. (Bug#10114)
512
b6e64c41
GM
5132011-11-23 Glenn Morris <rgm@gnu.org>
514
515 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
516
6b21de18
CY
5172011-11-23 Chong Yidong <cyd@gnu.org>
518
519 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
520 using it (Bug#5984).
521
b12cd789
EZ
5222011-11-22 Eli Zaretskii <eliz@gnu.org>
523
524 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
525 and header-lines, as they don't have one computed for them.
526 (Bug#10098)
527
528 * .gdbinit (prow): Make displayed values more self-explaining.
529 Add row's hash code.
530
261b6fd4
LMI
5312011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
532
533 * process.c (wait_reading_process_output): Fix asynchrounous
534 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 535 (wait_reading_process_output): Add comment and URL.
261b6fd4 536
e7cfd277
JD
5372011-11-21 Jan Djärv <jan.h.d@swipnet.se>
538
539 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
540
a9b9b7f5
CY
5412011-11-21 Chong Yidong <cyd@gnu.org>
542
543 * window.c (Fnext_window, Fprevious_window): Doc fix.
544
b0d15b4f
SM
5452011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
546
547 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
548
fe7a3057
JB
5492011-11-20 Juanma Barranquero <lekktu@gmail.com>
550
551 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
552
d2999b1a
MR
5532011-11-20 Martin Rudalics <rudalics@gmx.at>
554
555 * window.c (Fset_window_combination_limit): Rename argument
556 STATUS to LIMIT.
557 (Vwindow_combination_limit): Remove "status" from doc-string.
558
d5ff9cd0
AS
5592011-11-20 Andreas Schwab <schwab@linux-m68k.org>
560
561 * m/ibms390.h: Remove.
562 * m/ibms390x.h: Don't include "ibms390.h".
563
a5bb9bd3
SM
5642011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
565
566 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
567 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
568
cd1181db
JB
5692011-11-20 Juanma Barranquero <lekktu@gmail.com>
570
571 * casetab.c (Fset_case_table):
572 * charset.c (Fcharset_after): Fix typos.
573
615a3b8d 5742011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 575
17e845af
PE
576 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
577 Otherwise, valgrind does not work on some platforms.
578 Problem reported by Andreas Schwab in
6a0bf43d
PE
579 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
580 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
581 is set, removing the need for VIRT_ADDRESS_VARIES.
582 (PURE_P): Use a more-efficient implementation that needs just one
583 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
584 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
585 to 4 (xorl, subq, cmpq, setbe).
586 * alloc.c (pure): Always extern now, since that's the
587 VIRT_ADDR_VARIES behavior.
588 (PURE_POINTER_P): Use a single comparison, not two, for
589 consistency with the new puresize.h.
590 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
591 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
592 Remove VIRT_ADDR_VARIES no longer needed.
593
f8fe6f96
EZ
5942011-11-19 Eli Zaretskii <eliz@gnu.org>
595
596 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
597 (erase_phys_cursor, update_window_cursor, show_mouse_face)
598 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
599 behave as if the cursor position were at the window margin.
600
601 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
602 and the cursor position is out of bounds, behave as if the cursor
603 position were at the window margin. (Bug#10075)
604
df05a53c
CY
6052011-11-18 Chong Yidong <cyd@gnu.org>
606
607 * window.c (Fwindow_combination_limit): Make first argument
608 non-optional, since it is meaningless for live windows like the
609 selected window.
610
2071918e
DA
6112011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
612
613 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
614
b50a28de
SM
6152011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
616
617 * intervals.c: Fix grafting over the whole buffer (bug#10071).
618 (graft_intervals_into_buffer): Simplify.
619
015137db
EZ
6202011-11-18 Eli Zaretskii <eliz@gnu.org>
621
622 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
623 hash values of the two rows.
624 (copy_row_except_pointers): Preserve the used[] arrays and the
625 hash values of the two rows. (Bug#10035)
68c95424 626 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
627
628 * xdisp.c (row_hash): New function, body extracted from
629 compute_line_metrics.
630 (compute_line_metrics): Call row_hash, instead of computing the
631 hash code inline.
632
633 * dispnew.c (verify_row_hash): Call row_hash for computing the
634 hash code of a row, instead of duplicating code from xdisp.c.
635
636 * dispextern.h (row_hash): Add prototype.
637
a2addb04
TH
6382011-11-18 Tassilo Horn <tassilo@member.fsf.org>
639
640 * frame.c (delete_frame): Don't delete the terminal when the last
641 X frame is closed if emacs is built with GTK toolkit.
642
df85d315
JB
6432011-11-17 Juanma Barranquero <lekktu@gmail.com>
644
645 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
646
a0c2d0ae
MR
6472011-11-17 Martin Rudalics <rudalics@gmx.at>
648
649 * window.c (Vwindow_splits): Rename to
650 Vwindow_combination_resize. Suggested by Juri Linkov.
651 (Fsplit_window_internal): Use Vwindow_combination_resize instead
652 of Vwindow_splits.
653
58179cce
JB
6542011-11-16 Juanma Barranquero <lekktu@gmail.com>
655
7877f373
JB
656 * nsfns.m (Fns_font_name):
657 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 658
b6f67890
MR
6592011-11-16 Martin Rudalics <rudalics@gmx.at>
660
661 * window.h (window): Rename slot "nest" to "combination_limit".
662 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
663 (Fset_window_nest): Rename to Fset_window_combination_limit.
664 (Vwindow_nest): Rename to Vwindow_combination_limit.
665 (recombine_windows, make_parent_window, make_window)
666 (Fsplit_window_internal, saved_window)
667 (Fset_window_configuration, save_window_save): Rename all
668 occurrences of window_nest to window_combination_limit.
669
c7015153
JB
6702011-11-15 Juanma Barranquero <lekktu@gmail.com>
671
672 * image.c (imagemagick_load_image): Fix typo.
673
322ad6ec
EZ
6742011-11-14 Eli Zaretskii <eliz@gnu.org>
675
676 * xdisp.c (display_line): Move the call to
677 highlight_trailing_whitespace before the call to
678 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
679 faces of all the glyphs to compute ROW's hash value.
680 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 681
f067b8ec
JB
6822011-11-14 Juanma Barranquero <lekktu@gmail.com>
683
684 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
685 just return (bug#10044).
686
1e5b2111
EZ
6872011-11-12 Eli Zaretskii <eliz@gnu.org>
688
7ef3cbd5
EZ
689 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
690 with user-defined heap size. Bump the default size of the temacs
691 heap to 27MB, to avoid memory warning when running temacs.
692 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
693
1e5b2111
EZ
694 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
695 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
696 (verify_row_hash) [XASSERTS]: New function.
697 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
698 that the hash value of glyph rows is correct.
1e5b2111 699
89d61221
MR
7002011-11-12 Martin Rudalics <rudalics@gmx.at>
701
702 * window.h (window): Remove splits slot.
703 * window.c (Fwindow_splits, Fset_window_splits): Remove.
704 (Fdelete_other_windows_internal, make_parent_window)
705 (make_window, Fsplit_window_internal, Fdelete_window_internal)
706 (Fset_window_configuration, save_window_save): Don't deal with
707 split status of windows.
708 (saved_window): Remove splits slot.
709 (Vwindow_splits): Rewrite doc-string.
710
97f18cc8
JD
7112011-11-11 Jan Djärv <jan.h.d@swipnet.se>
712
713 * xfns.c (unwind_create_frame):
714 * nsfns.m (unwind_create_frame):
715 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
716 Vframe_list (Bug#9999).
717
22a648b4
DA
7182011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
719
0b381c7e 720 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 721
659afede
KH
7222011-11-11 Kenichi Handa <handa@m17n.org>
723
724 * callproc.c (Fcall_process): Set the member dst_multibyte of
725 process_coding.
726
9ac0394b
KH
7272011-11-11 Johan Bockgård <bojohan@gnu.org>
728
729 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
730 avoid a crash (bug#9496).
731
2fbdc249
CY
7322011-11-09 Chong Yidong <cyd@gnu.org>
733
734 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
735 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
736
ac6b1f81
PE
7372011-11-08 Paul Eggert <eggert@cs.ucla.edu>
738
739 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
740
09db192c
PE
7412011-11-08 Paul Eggert <eggert@cs.ucla.edu>
742
743 Avoid some portability problems by eschewing 'extern inline' functions.
744 The trivial performance wins aren't worth the portability hassles; see
745 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
746 et seq.
747 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
748 (window_box_width, window_box_left, window_box_left_offset)
749 (window_box_right, window_box_right_offset): Undo previous change,
750 by removing the "extern"s.
751 * intervals.c (adjust_intervals_for_insertion)
752 (adjust_intervals_for_deletion): Undo previous change,
753 making these static again.
754 (offset_intervals, temp_set_point_both, temp_set_point)
755 (copy_intervals_to_string): No longer inline.
756 * xdisp.c (window_text_bottom_y, window_box_width)
757 (window_box_height, window_box_left_offset)
758 (window_box_right_offset, window_box_left, window_box_right)
759 (window_box): No longer inline.
760
105216ed
CY
7612011-11-08 Chong Yidong <cyd@gnu.org>
762
763 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
764 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
765 Signal an error if not a live window.
105216ed
CY
766 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
767 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
768
ae9e237f
JB
7692011-11-07 Juanma Barranquero <lekktu@gmail.com>
770
771 * lisp.h (syms_of_abbrev): Remove declaration.
772 Reported by CHENG Gao <chenggao@royau.me>.
773
c7aa8333
EZ
7742011-11-07 Eli Zaretskii <eliz@gnu.org>
775
776 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
777 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
778 of temacs in GUI mode.
779
be7f5545
MR
7802011-11-07 Martin Rudalics <rudalics@gmx.at>
781
782 * window.h: Declare delete_all_child_windows instead of
783 delete_all_subwindows.
784 * window.c (Fwindow_nest, Fset_window_nest)
785 (Fset_window_new_total, Fset_window_new_normal)
786 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
787 (delete_all_subwindows): Rename to delete_all_child_windows.
788 (Fdelete_other_windows_internal, Fset_window_configuration):
789 Call delete_all_child_windows instead of delete_all_subwindows.
790 * frame.c (delete_frame): Call delete_all_child_windows instead
791 of delete_all_subwindows.
792
ca78dc43
PE
7932011-11-07 Paul Eggert <eggert@cs.ucla.edu>
794
795 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
796 This is also needed for porting to any host where GC_MARK_STACK is
797 not GC_MAKE_GCPROS_NOOPS.
798 (which_symbols): Use it.
799
a0241d01
KH
8002011-11-07 Kenichi Handa <handa@m17n.org>
801
802 * coding.c (coding_set_destination): Check coding->src_pos only
803 when coding->src_object is a buffer (bug#9910).
804
805 * process.c (send_process): Set the member src_multibyte of coding
806 to 0 (bug#9911) when sending a unibyte text.
807
808 * callproc.c (Fcall_process): Set the member src_multibyte of
809 process_coding to 0 (bug#9912).
810
a64bfdfa 8112011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
812
813 * xmenu.c (cleanup_widget_value_tree): New function.
814 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
815 calling free_menubar_widget_value_tree directly (Bug#9830).
816
cb41b32a
PE
8172011-11-06 Paul Eggert <eggert@cs.ucla.edu>
818
819 Fix some portability problems with 'inline'.
820 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
821 (window_box_width, window_box_left, window_box_left_offset)
822 (window_box_right, window_box_right_offset): Declare extern.
823 Otherwise, these inline functions do not conform to C99 and
824 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
825 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
826 * intervals.c (adjust_intervals_for_insertion)
827 (adjust_intervals_for_deletion): Now extern, because otherwise the
828 extern inline functions 'offset_intervals' couldn't refer to it.
829 (static_offset_intervals): Remove.
830 (offset_intervals): Rewrite using the old contents of
831 static_offset_intervals. The old version didn't conform to C99
832 because an extern inline function contained a reference to an
833 identifier with static linkage.
834
b7041366
AS
8352011-11-06 Andreas Schwab <schwab@linux-m68k.org>
836
837 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
838 GC.
839
88a37c4d
EZ
8402011-11-06 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (init_iterator, reseat_to_string): Don't set the
843 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
844 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
845 return Qleft_to_right.
846
49745b39
CY
8472011-11-06 Chong Yidong <cyd@gnu.org>
848
849 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
850 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
851 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
852 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
853 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
854 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
855 (Fwindow_vscroll): Doc fix.
856 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
857 argument, since it makes no sense to pass a live window and for
858 consistency with window-child.
859
1f05cd82
CS
8602011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
861
862 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
863 support MSVC.
864
22610910
JR
8652011-11-05 Jason Rumney <jasonr@gnu.org>
866
867 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
868 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
869 fonts (Bug#6029).
870 (add_font_entity_to_list): Fix logic errors in mixed boolean and
871 bitwise arithmetic preventing use of unicode-sip and non-truetype
872 opentype fonts.
873
a06776b2
EZ
8742011-11-05 Eli Zaretskii <eliz@gnu.org>
875
3ad924ba
EZ
876 * s/ms-w32.h (fstat, stat, utime): Move redirections to
877 "emacs"-only part.
878
a06776b2
EZ
879 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
880 initialization code to keep similarity to xfns.c after changes
881 from 2011-11-05.
882
c9e7db78
JD
8832011-11-05 Jan Djärv <jan.h.d@swipnet.se>
884
a97f8f3f
JD
885 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
886 (unwind_create_frame): New function (Bug#9943).
887 (Fx_create_frame): Restructure code to be more similar to the one in
888 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
889 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
890 Move terminal->reference_count++ just before making the frame official
891 (Bug#9943).
892
893 * nsterm.m (x_free_frame_resources): New function.
894 (x_destroy_window): Move code to x_free_frame_resources.
895
c9e7db78 896 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
897 (Fx_create_frame, x_create_tip_frame):
898 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
899 official. Move initialization of image_cache_refcount and
900 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
901
a6fc3b5c
EZ
9022011-11-05 Eli Zaretskii <eliz@gnu.org>
903
904 Support MSVC build with newer versions of Visual Studio.
905 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
906 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
907 nt/gmake.defs.
908
909 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
910 which are not supported by MSVC.
911 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
912 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
913 bitfields.
914 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
915 types in bitfields.
916 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
917
918 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
919
58179cce 9202011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
921
922 Support MSVC build with newer versions of Visual Studio.
923 * w32.c: Don't include w32api.h for MSVC.
924 (init_environment) [_MSC_VER]: Call sys_access, not _access.
925
926 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
927 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
928 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
929 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
930 e_* cousins.
931 (alloca) [_MSC_VER]: Define to _alloca.
932
933 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
934
935 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
936
a58c13ed
EZ
9372011-11-04 Eli Zaretskii <eliz@gnu.org>
938
939 * xdisp.c (note_mouse_highlight): If either of
940 previous/next-single-property-change returns nil, treat that as
941 the beginning or the end of the buffer. (Bug#9955)
942
fe0b6370
JD
9432011-11-04 Jan Djärv <jan.h.d@swipnet.se>
944
a58c13ed 945 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
946 label is not null (Bug#9951).
947 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
948 may be NULL.
949
89bd5ee1
EZ
9502011-11-04 Eli Zaretskii <eliz@gnu.org>
951
952 * window.c (Fwindow_body_size): Mention in the doc string that the
953 return value is in frame's canonical units. (Bug#9949)
954
84c3edb9
EZ
9552011-11-03 Eli Zaretskii <eliz@gnu.org>
956
4e2fb5c7
EZ
957 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
958
84c3edb9 959 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 960 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 961 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 962
bc17a887
EZ
9632011-11-01 Eli Zaretskii <eliz@gnu.org>
964
965 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
966 Don't stop backward scan on the continuation glyph, even though
967 its CHARPOS is positive.
6d5eb5b0
SM
968 (mouse_face_from_buffer_pos, note_mouse_highlight):
969 Rename cover_string to disp_string.
bc17a887 970
4ee88440
MR
9712011-11-01 Martin Rudalics <rudalics@gmx.at>
972
973 * window.c (temp_output_buffer_show): Don't use
974 Vtemp_buffer_show_specifiers.
975 (Vtemp_buffer_show_specifiers): Remove unused variable.
976
c2ff3c02
EZ
9772011-10-30 Eli Zaretskii <eliz@gnu.org>
978
979 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
980 past the beginning of the current glyph matrix.
981
58179cce 9822011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
983
984 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
985 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
986 HAVE_GTK3 (Bug#9869).
b77a6a7f 987
3b574623
JD
988 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
989 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
990
b77a6a7f
JD
991 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
992
993 * xterm.c: Declare x_handle_net_wm_state to return int.
994 (handle_one_xevent): Check if we are iconified but don't have
995 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
996 (get_current_wm_state): Return non-zero if not hidden,
997 check for _NET_WM_STATE_HIDDEN (Bug#9893).
998 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
999 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1000 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1001
196e41e4
PE
10022011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1003
1004 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1005 so that this new function doesn't get optimized away by a
1006 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1007
021f2e1a
AS
10082011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1009
1010 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1011
8b058d44
EZ
10122011-10-29 Eli Zaretskii <eliz@gnu.org>
1013
1014 Fix the `xbytecode' command.
1015 * .gdbinit (xprintbytestr): New command.
b50a28de 1016 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1017 (xbytecode): Print the byte-code string as well.
1018
4452fb80
EZ
10192011-10-29 Kim Storm <storm@cua.dk>
1020
8b058d44
EZ
1021 * alloc.c (which_symbols): New function.
1022
21b72067
AS
10232011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1024
1025 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1026 line. (Bug#9903)
1027
83ed7b5c
GM
10282011-10-29 Glenn Morris <rgm@gnu.org>
1029
1030 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1031 Not clear what it was for, and it causes various bugs. (Bug#9839)
1032
5a7a728b
EZ
10332011-10-28 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1036 possible random value that matches one of those tested as
1037 condition to clear the mouse face.
1038
d3d0842f
CY
10392011-10-28 Chong Yidong <cyd@gnu.org>
1040
1041 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1042
31b39d13
DN
10432011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1044
1045 * window.c (make_window): Initialize phys_cursor_on_p.
1046
9aba6043
SM
10472011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * lisp.h (struct Lisp_Symbol): Update comments.
1050
c20992f4
JB
10512011-10-28 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1054
db4f02f2
EZ
10552011-10-28 Eli Zaretskii <eliz@gnu.org>
1056
1057 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1058 <oslsachem@gmail.com> for helping to debug this.
1059
1060 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1061 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1062 (g_b_init_get_glyph_outline_w): New static variables.
1063 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1064 (GetGlyphOutlineW_Proc): New typedefs.
1065 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1066 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1067 New functions.
1068 (w32font_open_internal, compute_metrics):
1069 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1070 instead of calling the "wide" APIs directly.
1071
1072 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1073
1074 * w32.h (syms_of_w32font): Add prototype.
1075
87e68db4
JB
10762011-10-27 Juanma Barranquero <lekktu@gmail.com>
1077
1078 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1079 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1080 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1081 (Fmove_to_window_line): Doc fix.
1082
435c1d67
CY
10832011-10-27 Chong Yidong <cyd@gnu.org>
1084
1085 * process.c (make_process): Set gnutls_state to NULL.
1086
1087 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1088 non-NULL, regardless of GNUTLS_INITSTAGE.
1089 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1090 an error. Set process slots as soon as we allocate them.
1091
1092 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1093
9c6c6f49
CY
10942011-10-27 Chong Yidong <cyd@gnu.org>
1095
9aba6043
SM
1096 * gnutls.c (emacs_gnutls_deinit): New function.
1097 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1098 (Fgnutls_deinit, Fgnutls_boot): Use it.
1099
1100 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1101 (deactivate_process): Call emacs_gnutls_deinit.
1102
657d08d3
JB
11032011-10-27 Juanma Barranquero <lekktu@gmail.com>
1104
1105 * image.c (x_create_x_image_and_pixmap):
1106 * w32.c (sys_rename, w32_delayed_load):
1107 * w32font.c (fill_in_logfont):
1108 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1109
5430d399
JB
11102011-10-26 Juanma Barranquero <lekktu@gmail.com>
1111
1112 * w32fns.c (w32_default_color_map): New function,
1113 extracted from Fw32_default_color_map.
a7ef684b 1114 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1115
fe0055fa
PE
11162011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1119
e6346438
SM
11202011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1121
1122 * keyboard.c (test_undefined): New function (bug#9751).
1123 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1124
e112cc37
ET
11252011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1126
1127 * sysdep.c (init_sys_modes): Fix the check for the controlling
1128 terminal (Bug#6649).
1129
7b5d6677
EZ
11302011-10-20 Eli Zaretskii <eliz@gnu.org>
1131
1132 * dispextern.h (struct bidi_it): New member next_en_type.
1133
1134 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1135 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1136 current character, check also for next_en_type being WEAK_EN.
1137 (bidi_resolve_weak): Don't enter the expensive loop if the current
1138 position is before next_en_pos. Record the bidi type of the first
1139 non-ET, non-BN character we find, in addition to its position.
1140 (bidi_level_of_next_char): Invalidate next_en_type when
1141 next_en_pos is over-stepped.
1142
7da0b018
PE
11432011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1146 * editfns.c: Rewrite current-time-zone so that it invokes
1147 the equivalent of (format-time-string "%Z") to get the time zone name.
1148 This fixes a bug when the time zone name contains characters that
1149 need converting from the system time locale to Emacs internal format.
1150 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1151 that patch fixed format-time-string to do the conversion, but
1152 I forgot to fix current-time-zone.
1153 (format_time_string): New function, containing most of
1154 what Fformat_time_string used to contain.
1155 (Fformat_time_string): Rewrite in terms of format_time_string.
1156 This doesn't change this function's behavior.
1157 (current-time-zone): Rewrite to use format_time_string.
1158 This fixes the bug reported by Michael Schierl in
1159 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1160 Jason Rumney's 2007-06-07 change worked around this bug, but
1161 didn't fix it.
1162 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1163
8547b010
EZ
11642011-10-19 Eli Zaretskii <eliz@gnu.org>
1165
1166 * xdisp.c (start_display): If the character at POS is displayed
1167 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1168 (try_window_reusing_current_matrix): If a line ends in a display
1169 vector or the next line starts in a display vector, continue
1170 redrawing the window even though the character position of
1171 start_row was reached.
8547b010
EZ
1172 (Bug#9771, part 2)
1173
4e948d15
CY
11742011-10-18 Chong Yidong <cyd@gnu.org>
1175
1176 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1177 with nobreak-char-display too.
1178
4787455f
EZ
11792011-10-18 Eli Zaretskii <eliz@gnu.org>
1180
1181 Fix part 3 of bug#9771.
1182 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1183 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1184 non-neutral characters if the current character is a paragraph
1185 separator (a.k.a. Newline). This avoids running the same
1186 expensive loop twice, once when we consume the preceding newline
1187 and the other time when the line actually needs to be displayed.
1188 Avoid the loop when we see neutrals on the base embedding level
1189 following a character whose directionality is the same as the
1190 paragraph's. This avoids running the expensive loop when a line
1191 ends in a long sequence of neutrals, like control characters.
1192 Add assertion against STRONG_AL type. Slightly rearrange code
1193 that determines the type of a neutral given the first non-neutral
1194 that follows it.
1195 (bidi_level_of_next_char): Set next_en_pos to zero when
1196 invalidating its info.
1197
2c91f553
EZ
11982011-10-17 Eli Zaretskii <eliz@gnu.org>
1199
1200 * xdisp.c (push_display_prop): Determine whether to record string
1201 or buffer position by IT->string, not by IT->method. Allow
1202 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1203 (move_it_vertically_backward): Don't look for character position
1204 immediately after the newline when in a continuation line.
1205 (Bug#9771, part 1)
2c91f553 1206
c7b08b0d
MR
12072011-10-15 Martin Rudalics <rudalics@gmx.at>
1208
1209 * window.c (coordinates_in_window): Rewrite and delabelize
1210 vertical border check. (Bug#5357) (Bug#9618)
1211
6b02f655
SM
12122011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1213
1214 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1215 errors in XSetWindowBorder (bug#9310).
1216
81d40c92
DA
12172011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1218
1219 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1220 avoid crash when xmalloc overrun checking is enabled.
1221
d4172c3b
EZ
12222011-10-13 Eli Zaretskii <eliz@gnu.org>
1223
1224 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1225 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1226 cursor motion with <left> and <right> arrow keys.
1227
1228 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1229 some callers set that themselves.
1230
b00eea75
EZ
12312011-10-12 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1234 display string and the previous row comes from the same string and
1235 is empty. (Bug#9739) (Bug#9738)
1236
8fe012c4
SM
12372011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1238
1239 * doc.c (get_doc_string): Encode file name (bug#9735).
1240
0074aef2
EZ
12412011-10-12 Eli Zaretskii <eliz@gnu.org>
1242
79beb178
EZ
1243 * bidi.c (bidi_level_of_next_char):
1244 * xdisp.c (get_visually_first_element): Remove old incorrect
1245 comments regarding the Unicode Line Separator character.
1246
0074aef2
EZ
1247 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1248
6e4b3fbe
DA
12492011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1250
1251 * alloc.c (Fgc_status): Do not access beyond zombies array
1252 boundary if nzombies > MAX_ZOMBIES.
1253 * alloc.c (dump_zombies): Add missing format specifier.
1254
0324f3af
PE
12552011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1256
b5525cac
PE
1257 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1258 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1259
0324f3af
PE
1260 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1261 Some packages use them to denote characters with modifiers.
1262
e9b5f888
AS
12632011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1264
1265 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1266 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1267 matching a pp-number. Rename parameter var to var1.
1268
127827c0
SM
12692011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1270
1271 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1272
c8fd3bd0
GM
12732011-10-08 Glenn Morris <rgm@gnu.org>
1274
1275 * callint.c (Fcall_interactively): Give a more explicit error for the
1276 'c' case with a non-character input. (Bug#8479)
1277
352ec8ff
EZ
12782011-10-08 Eli Zaretskii <eliz@gnu.org>
1279
03669ccb
EZ
1280 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1281 lines.
7061c986
EZ
1282 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1283 lines that are hscrolled on the left.
03669ccb 1284
352ec8ff
EZ
1285 * dispnew.c (buffer_posn_from_coords): Account for a possible
1286 presence of header-line. (Bug#4426)
1287
a66cfb1c
SM
12882011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1289
6b02f655
SM
1290 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1291 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1292
7c5ee88e
PE
12932011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1296 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1297 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1298 this makes Emacs dump core during garbage collection on rare
1299 occasions. sizeof is obviously inferior to offsetof here, so
1300 stick with offsetof.
1301 (GC_POINTER_ALIGNMENT): New macro.
1302 (mark_memory): Omit 3rd (offset) arg; caller changed.
1303 Don't assume EMACS_INT alignment is the same as pointer alignment.
1304
df1bbe5b
SM
13052011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1306
1307 * keyboard.c (read_key_sequence_remapped): New var.
1308 (read_key_sequence): Compute remapping in the right buffer.
1309 (command_loop_1): Use read_key_sequence's remapping directly.
1310
51553db6
SM
13112011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1312
32c1fffd
SM
1313 * dired.c (file_name_completion): Don't expand file name.
1314 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1315 before checking file name handler.
1316
51553db6
SM
1317 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1318 they've been requested explicitly (bug#9591).
1319
b6bd1599 13202011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1321
1322 * keymap.c (Fsingle_key_description): Use make_specified_string
1323 instead of build_string to build string from push_key_description.
1324 (Bug#5193)
1325
f701dc2a
PE
13262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1327
4222c55d
PE
1328 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1329 This fixes a Y2038 bug on 64-bit hosts.
1330 * buffer.c (reset_buffer):
1331 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1332 (Fclear_buffer_auto_save_failure):
1333 Use 0, not -1, to represent an unset failure time, since time_t
1334 might not be signed.
1335
f701dc2a
PE
1336 Remove dependency on glibc malloc internals.
1337 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1338 Move back here from lisp.h, but with their new implementations.
1339 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1340 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1341 * charset.c (charset_table_init): New static var.
1342 (syms_of_charset): Use it instead of xmalloc. This removes a
1343 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1344 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1345 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1346 Move back to alloc.c.
1347 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1348 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1349
9ceebf39
JD
13502011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1351
1352 * nsterm.m (windowDidResize): Call x_set_window_size only when
1353 ns_in_resize is true. Otherwise set pixelwidth/height and
1354 call change_frame_size (Bug#9628).
1355
cb993c58
PE
13562011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1357
3930c88b
PE
1358 Port --enable-checking=all to Fedora 14 x86-64.
1359 * charset.c (syms_of_charset): Also account for glibc malloc's
1360 internal overhead when calculating the initial malloc maximum.
1361
cb993c58
PE
1362 Port --enable-checking=all to Fedora 14 x86.
1363 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1364 Move to lisp.h.
1365 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1366 (overrun_check_realloc, overrun_check_free):
1367 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1368 That way, xmalloc returns a properly-aligned pointer even if
1369 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1370 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1371 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1372 into account when calculating the initial malloc maximum.
1373 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1374 Move here from alloc.c, so that charset.c can use it too.
1375 Properly align; the old code wasn't right for common 32-bit hosts
1376 when configured with --enable-checking=all.
1377 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1378 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1379
31bed486
EZ
13802011-09-29 Eli Zaretskii <eliz@gnu.org>
1381
04c70788 1382 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1383 use EDOM.
1384
fbcaa2f3
EZ
13852011-09-28 Eli Zaretskii <eliz@gnu.org>
1386
1387 * xdisp.c (compute_display_string_end): If there's no display
1388 string at CHARPOS, return -1.
1389
1390 * bidi.c (bidi_fetch_char): When compute_display_string_end
1391 returns a negative value, treat the character as a normal
1392 character not covered by a display string. (Bug#9624)
1393
a239d4e9
JB
13942011-09-28 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * lread.c (Fread_from_string): Fix typo in docstring.
1397
88652fd5
EZ
13982011-09-27 Eli Zaretskii <eliz@gnu.org>
1399
1400 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1401 newline, reseat the iterator instead of bidi-iterating there one
1402 character at a time. (Bug#9610)
32c1fffd
SM
1403 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1404 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1405
ed497dd4
AS
14062011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1407
1408 * lread.c (readevalloop): Use correct code for NBSP.
1409 (read1): Likewise. (Bug#9608)
1410
b2bf61aa
MA
14112011-09-25 Michael Albinus <michael.albinus@gmx.de>
1412
1413 * dbusbind.c (Fdbus_register_signal): When service is not
1414 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1415
32bbb17c
GM
14162011-09-25 Glenn Morris <rgm@gnu.org>
1417
1418 * buffer.c (truncate-lines): Doc fix.
1419
94e0933e
CY
14202011-09-24 Chong Yidong <cyd@stupidchicken.com>
1421
1422 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1423 (Fset_window_next_buffers): Doc fix.
1424
cddde921
GM
14252011-09-24 Glenn Morris <rgm@gnu.org>
1426
1427 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1428
1260aef1
PE
14292011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1430
25b4bfa0
PE
1431 Fix minor problems found by static checking.
1432 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1433 * indent.c (Fvertical_motion): Fix == vs = typo.
1434
e3cbd34b
EZ
14352011-09-24 Eli Zaretskii <eliz@gnu.org>
1436
a66cfb1c
SM
1437 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1438 Default value is now t. Doc fix.
6bf7006f 1439
e3cbd34b 1440 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1441 logic when moving up, not only when moving down. Fix the
e3cbd34b 1442 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1443 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1444
1445 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1446 CHARPOS is covered by a display string which includes newlines.
1447 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1448 is covered by a display string with embedded newlines.
1449
a3de0cbd
MA
14502011-09-24 Michael Albinus <michael.albinus@gmx.de>
1451
1452 * dbusbind.c (Fdbus_register_signal): Add match rule to
1453 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1454 (Fdbus_register_method, Vdbus_registered_objects_table):
1455 Fix docstring.
a3de0cbd 1456
b260039d
JM
14572011-09-24 Jim Meyering <meyering@redhat.com>
1458
32c1fffd 1459 do not ignore write error for any output size
b260039d
JM
1460 The previous change was incomplete.
1461 While it makes emacs --batch detect the vast majority of stdout
1462 write failures, errors were still ignored whenever the output size is
1463 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1464 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1465 && echo FAIL: ignored write error
1466 FAIL: ignored write error
1467 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1468 && echo FAIL: ignored write error
1469 FAIL: ignored write error
1470 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1471
8eca8a7c
AS
14722011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1473
1474 * emacs.c (Fkill_emacs): In noninteractive mode exit
1475 non-successfully if a write error occurred on stdout. (Bug#9574)
1476
3341db62
EZ
14772011-09-21 Eli Zaretskii <eliz@gnu.org>
1478
1479 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1480 the xassert test.
1481
1482 * dispextern.h (struct it): Update the comment documenting what
1483 can it->OBJECT be.
1484
8c203dbf
EZ
14852011-09-20 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1488 a display string, extend search for cursor position to end of row.
1489 (find_row_edges): If the row ends in a newline from a display
1490 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1491 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1492 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1493 non-empty line. Fixes confusing cursor motion with arrow keys at
1494 the beginning of a line that starts with whitespace.
8c203dbf 1495
a4824228
LMI
14962011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1497
1498 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1499 (bug#9493).
1500
33ed493b
CY
15012011-09-18 Chong Yidong <cyd@stupidchicken.com>
1502
1503 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1504 boolean (Bug#9154).
1505
56cd55c8
EZ
15062011-09-18 Eli Zaretskii <eliz@gnu.org>
1507
1508 * xdisp.c (display_line): Record maximum and minimum buffer
1509 positions even if no glyphs were produced (e.g., by a zero-width
1510 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1511 buffer positions that will be removed from the glyph row because
1512 they don't fit.
c02dcedf
EZ
1513 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1514 column is beyond frame width: don't subtract 1 "pixel" when
1515 computing width of the stretch.
3e62b7e0
EZ
1516 (reseat_at_next_visible_line_start): Undo the change made on
1517 2011-09-17 that saved paragraph information and restored it after
1518 the call to `reseat'. (Bug#9545)
56cd55c8 1519
5ed99d36 15202011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1521
1522 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1523 and turn window cursor on if cleared (Bug#9415).
1524
5ed99d36 15252011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1526
1527 * search.c (boyer_moore): Take unibyte characters from pattern
1528 literally. (Bug#9458)
1529
9bade7b2
EZ
15302011-09-18 Eli Zaretskii <eliz@gnu.org>
1531
1532 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1533
e5e9d610
PE
15342011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1535
87e4427a
PE
1536 Fix minor problem found by static checking.
1537 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1538 initialized, to pacify gcc -Wuninitialized.
1539
e5e9d610
PE
1540 * fileio.c: Report proper errno when syscall falls.
1541 (Finsert_file_contents): Save and restore errno,
1542 so that report_file_error outputs the correct diagnostic.
1543 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1544
a1674f0b
EZ
15452011-09-18 Eli Zaretskii <eliz@gnu.org>
1546
1547 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1548
fbfb6dd4
EZ
15492011-09-17 Eli Zaretskii <eliz@gnu.org>
1550
1551 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1552 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1553
bb187662
EZ
15542011-09-17 Eli Zaretskii <eliz@gnu.org>
1555
1137e8b8 1556 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1557 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1558
1559 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1560 (bidi_find_paragraph_start): Search back for paragraph beginning
1561 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1562 (bidi_move_to_visually_next): Only trigger paragraph-related
1563 computations when the last character is a newline or at EOB, not
1564 just any NEUTRAL_B. (Bug#9470)
1565
bb187662
EZ
1566 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1567 truncated lines if point is covered by a display string. (Bug#9524)
1568
2e621251
PE
15692011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1572 (cons_to_x_long): New function.
1573 (lisp_data_to_selection_data): Use it. Correct the test for
1574 short-versus-long data; it was negated. Break out of vector
1575 loop, for efficiency, when a long datum is discovered.
1576
91a15bc6
SM
15772011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1578
1579 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1580
b41c3a35
EZ
15812011-09-16 Eli Zaretskii <eliz@gnu.org>
1582
1583 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1584 GCC PR/17406) by declaring this function with external scope.
1585
7812ba2d
PE
15862011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1587
1588 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1589 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1590
cf7edc2a
AS
15912011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1592
1593 * editfns.c (Fformat): Correctly handle text properties on "%%".
1594
bd01620e
EZ
15952011-09-15 Eli Zaretskii <eliz@gnu.org>
1596
1597 * xterm.c (x_draw_composite_glyph_string_foreground):
1598 * w32term.c (x_draw_composite_glyph_string_foreground):
1599 * term.c (encode_terminal_code):
1600 * composite.c (composition_update_it, get_composition_id):
1601 * xdisp.c (get_next_display_element)
1602 (fill_composite_glyph_string): Add comments about special meaning
1603 of TAB characters in a composition.
1604
a02719a3
PE
16052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1608 This occurs when processing a multibyte format.
1609 Problem reported by Wolfgang Jenker.
a02719a3 1610
72589a3c
JB
16112011-09-15 Johan Bockgård <bojohan@gnu.org>
1612
1613 * xdisp.c (try_cursor_movement): Only check for exact match if
1614 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1615
1c14176c
PE
16162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1617
1618 Remove unused external symbols.
1619 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1620 * xdisp.c (calc_pixel_width_or_height): Now static.
1621 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1622 * indent.c (check_display_width):
1623 * w32term.c: Fix comment to match code.
1624 * xterm.c, xterm.h (x_catching_errors): Remove.
1625
d2eea5b5
PE
16262011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * xselect.c: Use signed conversions more consistently (Bug#9498).
1629 (selection_data_to_lisp_data): Assume incoming selection data are
1630 signed integers, not unsigned. This is to be consistent with
1631 outgoing selection data, which was modified to use signed integers
1632 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1633 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1634 expects long, not unsigned long.
1635
46888499
EZ
16362011-09-14 Eli Zaretskii <eliz@gnu.org>
1637
1638 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1639 computation of loop end. Reported by Johan Bockgård
1640 <bojohan@gnu.org>.
1641
ef8ef9fb
CY
16422011-09-13 Chong Yidong <cyd@stupidchicken.com>
1643
1644 * frame.c (Fother_visible_frames_p): Function deleted.
1645
fa819fed
EZ
16462011-09-12 Eli Zaretskii <eliz@gnu.org>
1647
1648 * indent.c (compute_motion): Process display vector front to back
1649 rather than the other way around. (Bug#2496)
1650
2ba8e008
SM
16512011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1652
1653 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1654
20f53c69
CY
16552011-09-11 Chong Yidong <cyd@stupidchicken.com>
1656
1657 * minibuf.c (Fread_from_minibuffer): Doc fix.
1658
d562d7a4
EZ
16592011-09-11 Eli Zaretskii <eliz@gnu.org>
1660
1661 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1662 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1663
1c4d7f3d
LMI
16642011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1665
1666 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1667 value for non-existent files.
1668
b885bf36
EZ
16692011-09-11 Eli Zaretskii <eliz@gnu.org>
1670
1671 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1672 set its "size" to -1. This will set the modtime_size field of
1673 the corresponding buffer to -1, which is what
1674 verify-visited-file-modtime expects for files that do not exist.
1675 (Bug#9139)
1676
6612f0bf
PE
16772011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1680 here ...
1681 * lisp.h: ... from here. push_key_description is no longer
1682 defined in keyboard.c, so its declaration should not be in
1683 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1684 logically belongs with push_key_description.
1685
dfb3f755
PE
16862011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * buffer.h: Include <sys/types.h> instead of <time.h>.
1689 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1690 Problem reported by Herbert J. Skuhra.
1691
3134906c
LMI
16922011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1693
1694 * xml.c (parse_region): Make the parsing work for
1695 non-comment-starting XML files again (bug#9144).
1696
8d903f4e
AS
16972011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1698
1699 * image.c (gif_load): Fix calculation of bottom and right corner.
1700 (Bug#9468)
1701
80ad64f4
EZ
17022011-09-10 Eli Zaretskii <eliz@gnu.org>
1703
1704 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1705 redisplay in small windows.
1706
208a048d
EZ
17072011-09-09 Eli Zaretskii <eliz@gnu.org>
1708
1709 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1710
9b1c252e
MR
17112011-09-08 Martin Rudalics <rudalics@gmx.at>
1712
1713 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1714 Operate on live windows only.
1715
2949f33b
JB
17162011-09-08 Juanma Barranquero <lekktu@gmail.com>
1717
1718 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1719
e08dcafd
EZ
17202011-09-07 Eli Zaretskii <eliz@gnu.org>
1721
1722 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1723 only under bidi iteration.
1724
115b96bd
JD
17252011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1726
1727 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1728
c8199d0f
PE
17292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1732 Without this fix, the command to link temacs failed due to an
1733 undefined symbol __builtin_isnan. This is because
1734 /usr/include/iso/math_c99.h #defines isnan(x) to
1735 __builtin_isnan(x), but the bundled gcc, which identifies itself
1736 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1737 a __builtin_isnan.
1738 * floatfns.c (isnan): #undef, and then #define to a clone of
1739 what's in data.c.
1740 (Fisnan): Always define, since it's always available now.
1741 (syms_of_floatfns): Always define isnan at the Lisp level.
1742
e39b275c 17432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1744
1745 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1746
b2db44d9 17472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1748
f4af5137 1749 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1750 The previous code assumed that file offsets (off_t values) fit in
1751 EMACS_INT variables, which is not true on typical 32-bit hosts.
1752 The code messed up by falsely reporting buffer overflow in cases
1753 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1754 when "big" contains more than 2**29 bytes, even though this
1755 inserts just one byte and does not overflow the buffer.
1756 (Finsert_file_contents): Store file offsets as off_t
1757 values, not as EMACS_INT values. Check for overflow when
1758 converting between EMACS_INT and off_t. When checking for
1759 buffer overflow or for overlap, take the offsets into account.
1760 Don't use EMACS_INT for small values where int suffices.
1761 When checking for overlap, fix a typo: ZV was used where
1762 ZV_BYTE was intended.
1763 (Fwrite_region): Don't assume off_t fits into 'long'.
1764 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1765
ecfc0a49
MA
17662011-09-05 Michael Albinus <michael.albinus@gmx.de>
1767
1768 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1769
6511acf2 17702011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1771
0999621a 1772 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1773
1774 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1775 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1776 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1777 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1778 (modify_event_symbol): Do not assume that the length of
1779 name_alist_or_stem is safe to alloca and fits in int.
1780 (Fexecute_extended_command): Likewise for function name and binding.
1781 (Frecursion_depth): Wrap around reliably on integer overflow.
1782 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1783 since some callers pass EMACS_INT values.
1784 (Fsingle_key_description): Don't crash if symbol name contains more
1785 than MAX_ALLOCA bytes.
1786 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1787 (get_minibuffer): Arg is now EMACS_INT, not int.
1788 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1789 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1790 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1791
2be7d702
PE
1792 * dbusbind.c (signature_cat): New function.
1793 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1794 Do not overrun buffer; instead, report string overflow.
1795
9d1df220
PE
1796 * dispnew.c (add_window_display_history): Don't overrun buffer.
1797 Truncate instead; this is OK since it's just a log.
1798
33ef5c64
PE
1799 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1800 even if the time zone offset is outlandishly large.
1801 Don't mishandle offset == INT_MIN.
1802
66c6fdd5
PE
1803 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1804 when creating daemon; the previous buffer-overflow check was incorrect.
1805
d749b01b
PE
1806 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1807 which has the guts of the old verror function.
1808
b5cd1905
PE
1809 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1810 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1811
6e1a67fb
PE
1812 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1813 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1814 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1815 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1816 length of string rather than counting it via multiple sprintfs;
1817 that's simpler and more reliable.
c21721cc
PE
1818 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1819 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1820 sprintf, in case result does not fit in int.
1821
c57b67fc
PE
1822 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1823 (fontset_from_font): Print it.
1824
8a401434
PE
1825 * frame.c (tty_frame_count): Now printmax_t, not int.
1826 (make_terminal_frame, set_term_frame_name): Print it.
1827 (x_report_frame_params): In X, window IDs are unsigned long,
1828 not signed long, so print them as unsigned.
1829 (validate_x_resource_name): Check for implausibly long names,
1830 and don't assume name length fits in 'int'.
1831 (x_get_resource_string): Don't blindly alloca invocation name;
1832 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1833 not fit in int.
1834
6e1a67fb
PE
1835 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1836 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1837 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1838
0df02bf3
PE
1839 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1840 Use esprintf, not sprintf, in case result does not fit in int.
1841
48e30793
PE
1842 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1843 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1844 it as a large positive number.
1845 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1846 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1847
a66ff6d8
PE
1848 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1849 in case result does not fit in int.
1850
aca216ff
PE
1851 * print.c (float_to_string): Detect width overflow more reliably.
1852 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1853 buffer overrun. Don't assume list length fits in 'int'. Treat
1854 print length of 0 as 0, not as infinity; to be consistent with other
1855 uses of print length in this function. Don't overflow print length
1856 index. Don't assume hash table size fits in 'long', or that
1857 vectorlike size fits in 'unsigned long'.
1858
31c286f7
PE
1859 * process.c (make_process): Use printmax_t, not int, to format
1860 process-name gensyms.
1861
55e5faa1
PE
1862 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1863
80f2e268
PE
1864 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1865 to avoid potential buffer overrun.
1866
670741ab
PE
1867 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1868 if X resource line is longer than 512 bytes.
1869
b7163a50
PE
1870 * xfns.c (x_window): Make sprintf buffer a bit bigger
1871 to avoid potential buffer overrun.
1872
ae58ff1f
PE
1873 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1874
c43c8a6a
PE
1875 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1876
3f8236f4
PE
18772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1878
53e9fe90 1879 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1880 Without these, Emacs silently mishandles large integers sometimes.
1881 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1882 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1883
6511acf2
PE
1884 * xdisp.c (try_window_id): Check Emacs fixnum range before
1885 converting to 'int'.
806add1d 1886
6511acf2 1887 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1888 Check that an Emacs fixnum is in range before assigning it to 'int'.
1889 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1890 values converted from Emacs fixnums.
1891 (Frecenter): Don't wrap around a line count if it is out of 'int'
1892 range; instead, treat it as an extreme value.
1893 (Fset_window_configuration, compare_window_configurations):
1894 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1895
6511acf2
PE
1896 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1897 that can exceed INT_MAX. Check that EMACS_INT value is in range
1898 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1899 (match_limit): Don't assume that a fixnum can fit in 'int'.
1900
6511acf2 1901 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1902 exceed INT_MAX.
1903
6511acf2 1904 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1905 (Fvertical_motion): Don't wrap around LINES values that don't fit
1906 in 'int'. Instead, treat them as extreme values. This is good
1907 enough for windows, which can't have more than INT_MAX lines anyway.
1908
fcb901a7
LMI
19092011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1910
0f2f6b6d
LMI
1911 * Require libxml/parser.h to avoid compilation warning.
1912
fcb901a7
LMI
1913 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1914
1915 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1916 since this reportedly can destroy thread storage.
1917
6e20a0d4
CY
19182011-08-30 Chong Yidong <cyd@stupidchicken.com>
1919
1920 * syntax.c (find_defun_start): Update all cache variables if
1921 exiting early (Bug#9401).
1922
148ae00e
EZ
19232011-08-30 Eli Zaretskii <eliz@gnu.org>
1924
f6cfbd8f
EZ
1925 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1926
148ae00e
EZ
1927 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1928 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1929 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1930
1931 * term.c (tty_append_glyph): New function.
1932 (produce_stretch_glyph): Static function and its prototype deleted.
1933
a66cfb1c
SM
1934 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1935 Add prototypes.
148ae00e 1936
c4a07a4c
PE
19372011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1940 when checking :margin (Bug#9390).
1941 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1942 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1943 so that the name doesn't mislead. All uses changed.
1944
6bc8cd65
JB
19452011-08-28 Johan Bockgård <bojohan@gnu.org>
1946
1947 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1948 set_tty_hooks.
1949
dca4927e
EZ
19502011-08-27 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xdisp.c (move_it_to): Don't bail out early when reaching
1953 position beyond to_charpos, if we are scanning backwards.
1954 (move_it_vertically_backward): When DY == 0, make sure we get to
1955 the first character in the line after the newline.
1956
f2cad773
PE
19572011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1958
1959 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1960 (ccl_driver): Do not generate an out-of-range pointer.
1961 (Fccl_execute_on_string): Remove unnecessary check for
1962 integer overflow, noted by Stefan Monnier in
1963 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1964 Remove a FIXME that didn't need fixing.
1965 Simplify the newly-introduced buffer reallocation code.
1966
0cae2cdb
JB
19672011-08-27 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1970
5fc295a4 19712011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1972
70c60eb2 1973 Integer and memory overflow issues (Bug#9196).
726e0ab1 1974
d31850da
PE
1975 * doc.c (get_doc_string): Rework so that
1976 get_doc_string_buffer_size is the actual buffer size, rather than
1977 being 1 less than the actual buffer size; this makes xpalloc more
1978 convenient.
1979
a69fbedb
PE
1980 * image.c (x_allocate_bitmap_record, cache_image):
1981 * xselect.c (Fx_register_dnd_atom):
1982 Simplify previous changes by using xpalloc.
1983
fe5c5d37
PE
1984 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1985 since either will do and ptrdiff_t is convenient with xpalloc.
1986
0065d054
PE
1987 * charset.c (charset_table_size)
1988 (struct charset_sort_data.priority): Now ptrdiff_t.
1989 (charset_compare): Don't overflow if priorities differ greatly.
1990 (Fsort_charsets): Don't assume list length fits in int.
1991 Check for size-calculation overflow when allocating sort data.
1992 (syms_of_charset): Allocate an initial charset table that is
1993 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1994
1995 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1996
1997 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1998 The actual value is always <= INT_MAX, and leaving it unsigned made
1999 overflow checking harder.
2000
2001 * dispextern.h (struct glyph_matrix.rows_allocated)
2002 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2003 with xpalloc. The values are still always <= INT_MAX.
2004
2005 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2006
2007 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2008 (SAFE_NALLOCA): New macro.
2009
2010 * region-cache.c (struct boundary.pos, find_cache_boundary)
2011 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2012 (set_cache_region, invalidate_region_cache)
2013 (revalidate_region_cache, know_region_cache, region_cache_forward)
2014 (region_cache_backward, pp_cache):
2015 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2016 so that ptrdiff_t * can be passed to xpalloc.
2017 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2018 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2019 (pp_cache): Don't assume cache_len fits in int.
2020 * region-cache.h: Adjust extern decls to match.
2021
2022 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2023 EMACS_INT, since either will do, for xpalloc.
2024
2025 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2026 (xnmalloc, xnrealloc, xpalloc): New functions.
2027
726e0ab1
PE
2028 * bidi.c (bidi_shelve_header_size): New constant.
2029 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2030 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2031
51f30bc5 2032 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2033 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2034 (overlay_strings):
2035 Don't update size of array until after memory allocation succeeds,
2036 because xmalloc/xrealloc may not return.
0065d054
PE
2037 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2038 now that we have proper integer overflow checking.
2039 (record_overlay_string, overlay_strings): Catch overflows when
2040 calculating size of overlay_str_buf.
726e0ab1 2041
0065d054
PE
2042 * callproc.c (Fcall_process): Check for size overflow when
2043 calculating size of args2.
2044 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2045 Normally we prefer signed values, but sticking with ptrdiff_t would
2046 require adding more-complicated checks.
726e0ab1
PE
2047
2048 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2049 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2050 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2051 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2052
2053 * character.c (Fstring): Check for size-calculation overflow.
2054
2055 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2056 unnecessary integer overflow. Check for size overflow.
2057 (encode_coding_object): Don't update size until xmalloc succeeds.
2058
2059 * composite.c (get_composition_id): Check for overflow in glyph
2060 length calculations.
2061
2062 Integer and memory overflow fixes for display code.
2063 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2064 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2065 (scrolling_window): Check for overflow in size calculations.
2066 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2067 Don't assume glyph table len fits in int.
2068 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2069 (row_table_size): Now ptrdiff_t, not int.
2070 (scrolling_window): Avoid overflow in size calculations.
2071 Don't update size until allocation succeeds.
2072 * fns.c (concat): Check for overflow in size calculations.
2073 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2074 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2075 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2076
2077 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2078 (get_doc_string): Check for size calculation overflow.
2079 Don't update size until allocation succeeds.
2080 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2081 EMACS_INT, where ptrdiff_t will do.
2082 (Fsubstitute_command_keys): Check for string overflow.
2083
2084 * editfns.c (set_time_zone_rule): Don't assume environment length
2085 fits in int.
2086 (message_length): Now ptrdiff_t, not int.
2087 (Fmessage_box): Don't update size until allocation succeeds.
2088 Don't assume message length fits in int.
2089 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2090
0065d054
PE
2091 * emacs.c (main): Do not reallocate argv, since there is a null at
2092 the end that can be overwritten, and this way there's no need to
2093 worry about size-calculation overflow.
2094 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2095
2096 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2097 alloc succeeds.
2098 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2099
2100 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2101 (x_set_scroll_bar_width, x_figure_window_size):
2102 Check for integer overflow.
2103 (x_set_alpha): Do not assume XINT fits in int.
2104
2105 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2106 This is for the members text_lines, text_cols, total_lines, total_cols,
2107 where the system imposes an 'int' limit.
2108
2109 * fringe.c (Fdefine_fringe_bitmap):
2110 Don't update size until alloc works.
2111
2112 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2113 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2114
2115 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2116 Check for size-calculation overflow.
2117 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2118 do, as we prefer signed integers.
2119 (id_to_widget.max_size, id_to_widget.used)
2120 (xg_store_widget_in_map, xg_remove_widget_from_map)
2121 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2122 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2123 Use and return ptrdiff_t, not int.
2124 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2125 * gtkutil.h: Change prototypes to match the above.
2126
2127 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2128 are duplicate now that they've been promoted to lisp.h.
2129 (x_allocate_bitmap_record, x_alloc_image_color)
2130 (make_image_cache, cache_image, xpm_load):
2131 Don't update size until alloc is done.
2132 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2133 (x_detect_edges):
3256efce 2134 Check for size calculation overflow.
726e0ab1
PE
2135 (ct_colors_allocated_max): New constant.
2136 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2137 overflow.
3256efce 2138
726e0ab1
PE
2139 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2140 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2141 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2142 Use ptrdiff_t, not int, to count maps.
2143 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2144 calculations. Don't update size until allocation succeeds.
2145 Redo calculations to avoid overflow.
726e0ab1
PE
2146 * keyboard.h: Change prototypes to match the above.
2147
2148 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2149 to count maps.
2150 (current_minor_maps): Check for size calculation overflow.
2151 * keymap.h: Change prototypes to match the above.
2152
2153 * lread.c (read1, init_obarray): Don't update size until alloc done.
2154
2155 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2156 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2157
726e0ab1
PE
2158 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2159 Now ptrdiff_t, not int.
2160 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2161 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2162
2163 * process.c (Fnetwork_interface_list): Check for overflow
2164 in size calculation.
2165
2166 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2167
2168 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2169 overflow. Don't bother calling xmalloc when xrealloc will do.
2170
2171 * search.c (Freplace_match): Check for size calculation overflow.
2172 (Fset_match_data): Don't assume list lengths fit in 'int'.
2173
2174 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2175 for command line length. Do not attempt to address one before the
2176 beginning of an array, as that's not portable.
2177
2178 * term.c (max_frame_lines): Remove; unused.
2179 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2180 not int.
2181 (encode_terminal_code, calculate_costs): Check for size
2182 calculation overflow.
2183 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2184 table lengths and related sizes. Don't update size until alloc
2185 done. Redo calculations to avoid overflow.
2186 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2187
2188 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2189 subtracting pointers.
2190 (gobble_line): Check for overflow more carefully. Don't update size
2191 until alloc done.
2192
2193 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2194 Don't update size until alloc done.
2195 Redo size calculations to avoid overflow.
2196 Check for size calculation overflow.
0065d054 2197 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2198
2199 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2200 Use ptrdiff_t, not int, for sizes.
2201 (store_mode_line_noprop_char): Don't update size until alloc done.
2202
0065d054
PE
2203 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2204 Use ptrdiff_t, not int, for sizes.
2205 (Finternal_make_lisp_face, cache_face):
2206 Check for size calculation overflow.
2207 (cache_face): Treat size calculation overflows as if they were
2208 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2209
2210 * xfns.c (x_encode_text, x_set_name_internal)
2211 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2212 sizes, since they can exceed INT_MAX in size. Check for size
2213 calculation overflow.
2214
0065d054
PE
2215 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2216 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2217 Don't update size until alloc done.
2218
0065d054 2219 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2220 as sprintf is limited to int lengths.
1d526e2f 2221
252c5ee1
PE
2222 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2223 (X_LONG_MIN): New macros.
864d7ce7
PE
2224 Use them to make the following changes clearer.
2225 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2226 This change doesn't affect the value now, but it may help remind
2227 future maintainers not to raise the value too much later.
2228 (SELECTION_QUANTUM): Remove, replacing with ...
2229 (selection_quantum): ... new function, which avoids overflow.
2230 All uses changed.
2231 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2232 assumption that selection length fits in 'int'.
2233 (x_reply_selection_request, x_handle_selection_request)
2234 (x_get_window_property, receive_incremental_selection)
2235 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2236 (lisp_data_to_selection_data, clean_local_selection_data):
2237 Use ptrdiff_t, not int, to record length of selection.
2238 (x_reply_selection_request, x_get_window_property)
2239 (receive_incremental_selection, x_property_data_to_lisp):
2240 Redo calculations to avoid overflow.
2241 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2242 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2243 something.
2244 (x_get_window_property, receive_incremental_selection)
2245 (lisp_data_to_selection_data, x_property_data_to_lisp):
2246 Check for size-calculation overflow.
2247 (x_get_window_property, receive_incremental_selection)
2248 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2249 Don't store size until memory allocation succeeds.
2250 (x_get_window_property): Plug memory leak on memory exhaustion.
2251 Don't double-block input; malloc is safe here. Don't assume 2**34
2252 - 4 fits in unsigned long. Add an xassert to check
2253 XGetWindowProperty overflow. Be more careful about overflow
2254 calculations, and distinguish size from memory overflow better.
2255 (receive_incremental_selection): When tracing, don't assume
2256 unsigned int is less than INT_MAX.
2257 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2258 harmful) conversions of unsigned short to int.
2259 (lisp_data_to_selection_data): Don't assume that integers
2260 in the range -65535 through -1 fit in an X unsigned short.
2261 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2262 result parameters unless successful. Rely on cons_to_unsigned
2263 to report problems with elements; the old code wasn't right anyway.
2264 (x_check_property_data): Check for int overflow; we cannot use
2265 a wider type due to X limits.
2266 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2267
726e0ab1 2268 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2269
0065d054
PE
2270 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2271 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2272 (x_color_cells): Don't store size until memory allocation succeeds.
2273 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2274 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2275 (x_term_init): Don't assume length fits in int (sprintf is limited
2276 to int size).
bc18e09d 2277
ebfa62c0
PE
2278 Use ptrdiff_t for composition IDs.
2279 * character.c (lisp_string_width):
2280 * composite.c (composition_table_size, n_compositions)
2281 (get_composition_id, composition_gstring_from_id):
2282 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2283 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2284 * window.c (Frecenter):
2285 Use ptrdiff_t, not int, for composition IDs.
2286 * composite.c (get_composition_id): Check for integer overflow.
2287 * composite.h: Adjust prototypes to match the above changes.
2288
d3411f89
PE
2289 Use ptrdiff_t for hash table indexes.
2290 * category.c (hash_get_category_set):
2291 * ccl.c (ccl_driver):
2292 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2293 * coding.c (coding_system_charset_list, detect_coding_system):
2294 * coding.h (struct coding_system.id):
2295 * composite.c (get_composition_id, gstring_lookup_cache):
2296 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2297 * image.c (xpm_get_color_table_h):
2298 * lisp.h (hash_lookup, hash_put):
2299 * minibuf.c (Ftest_completion):
2300 Use ptrdiff_t for hash table indexes, not int (which is too
2301 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2302 32-bit --with-wide-int hosts).
2303
e097a6fa
PE
2304 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2305 Add a FIXME comment about memory leaks.
2306 (syms_of_charset): Don't assume xmalloc returns.
2307
5637687f
PE
2308 Don't assume that stated character widths fit in int.
2309 * character.c (Fchar_width, c_string_width, lisp_string_width):
2310 * character.h (CHAR_WIDTH):
2311 * indent.c (MULTIBYTE_BYTES_WIDTH):
2312 Use sanitize_char_width to avoid undefined and/or bad behavior
2313 with outlandish widths.
a66cfb1c 2314 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2315 now that we have two such functions. All uses changed.
2316 (sanitize_char_width): New inline function.
2317
a2271ba2
PE
2318 Don't assume that tab-width fits in int.
2319 * character.h (sanitize_width): New inline function.
2320 (SANE_TAB_WIDTH): New macro.
2321 (ASCII_CHAR_WIDTH): Use it.
2322 * indent.c (sane_tab_width): Remove. All uses replaced by
2323 SANE_TAB_WIDTH (current_buffer).
2324 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2325
18c52557
PE
2326 * fileio.c: Integer overflow issues with file modes.
2327 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2328
caeeedc1
PE
2329 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2330 Remove unreachable code.
2331 (read_hex, load_charset_map_from_file): Check for integer overflow.
2332
50849c52
PE
2333 * xterm.c: don't go over XClientMessageEvent limit
2334 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2335 (x_send_scroll_bar_event): Likewise. Check that the size does not
2336 exceed limits imposed by XClientMessageEvent, as well as the usual
2337 ptrdiff_t and size_t limits.
2338
b13995db
PE
2339 * keyboard.c: Overflow, signedness and related fixes.
2340 (make_lispy_movement): Use same integer type in forward decl
2341 that is used in the definition.
2342 (read_key_sequence, keyremap_step):
2343 Change bufsize argument back to int, undoing my 2011-03-30 change.
2344 We prefer signed types, and int is wide enough here.
2345 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2346 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2347 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2348 length, not size_t. Use ptrdiff_t for index, not int.
2349 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2350 possibility of integer overflow.
2351
13464394
PE
2352 Overflow, signedness and related fixes for images.
2353
2354 * dispextern.h (struct it.stack[0].u.image.image_id)
2355 (struct_it.image_id, struct image.id, struct image_cache.size)
2356 (struct image_cache.used, struct image_cache.ref_count):
2357 * gtkutil.c (update_frame_tool_bar):
2358 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2359 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2360 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2361 * nsmenu.m (update_frame_tool_bar):
2362 * xdisp.c (calc_pixel_width_or_height):
2363 * xfns.c (image_cache_refcount):
2364 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2365 on typical 64-bit hosts.
2366
2367 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2368 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2369 Omit unnecessary casts to int.
2370 (parse_image_spec): Check that integers fall into 'int' range
2371 when the callers expect that.
2372 (image_ascent): Redo ascent calculation to avoid int overflow.
2373 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2374 (lookup_image): Remove unnecessary tests.
2375 (xbm_image_p): Locals are now of int, not EMACS_INT,
2376 since parse_image_check makes sure they fit into int.
2377 (png_load, gif_load, svg_load_image):
2378 Prefer int to unsigned where either will do.
2379 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2380 old tiff_error_handler and tiff_warning_handler.
2381 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2382 stack buffer overflows. It uses only the features of vsnprintf
2383 that are common to both POSIX and native Microsoft.
2384 (tiff_error_handler, tiff_warning_handler): Use it.
2385 (tiff_load, gif_load, imagemagick_load_image):
2386 Don't assume :index value fits in 'int'.
2387 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2388 (imagemagick_load_image): Check that crop parameters fit into
2389 the integer types that MagickCropImage accepts. Don't assume
2390 Vimagemagick_render_type has a nonnegative value. Don't assume
2391 size_t fits in 'long'.
2392 (gs_load): Use printmax_t to print the widest integers possible.
2393 Check for integer overflow when computing image height and width.
2394
c11821d4
EZ
23952011-08-26 Eli Zaretskii <eliz@gnu.org>
2396
2397 * xdisp.c (redisplay_window): Don't force window start if point
2398 will be invisible in the resulting window. (Bug#9324)
2399
0c95fcf7
EZ
24002011-08-25 Eli Zaretskii <eliz@gnu.org>
2401
2402 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2403 the display spec is of the form `(space ...)'.
2404 (handle_display_spec): Return the value returned by
2405 handle_single_display_spec, not just 1 or zero.
2406 (handle_single_display_spec): If the display spec is of the form
2407 `(space ...)', and specifies display in the text area, return 2
2408 rather than 1.
fee65a97 2409 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2410 accurately, and prefer exact match for point under bidi.
2411 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2412
2413 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2414 into disp_prop; all users changed.
2415
2416 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2417 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2418 for the text covered by the display property.
2419
e4ed06f1
CY
24202011-08-25 Chong Yidong <cyd@stupidchicken.com>
2421
2422 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2423 Change return value to nil.
2424 (Frecord_buffer): Delete unused function.
2425
f67cdd7f
EZ
24262011-08-24 Eli Zaretskii <eliz@gnu.org>
2427
5980d4c6
EZ
2428 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2429 buffers, return left-to-right.
8610fe8b
EZ
2430 (set_cursor_from_row): Consider candidate row a win if its glyph
2431 represents a newline and point is on that newline. Fixes cursor
2432 positioning on the newline at EOL of R2L text within L2R
2433 paragraph, and vice versa.
2434 (try_cursor_movement): Check continued rows, in addition to
2435 continuation rows. Fixes unwarranted scroll when point enters a
2436 continued line of R2L text within an L2R paragraph, or vice versa.
2437 (cursor_row_p): Consider the case of point being equal to
2438 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2439 from the end of a short line to the beginning of a continued line
2440 of R2L text within L2R paragraph.
2441 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2442 composed characters.
5980d4c6 2443
f67cdd7f
EZ
2444 * bidi.c (bidi_check_type): Use xassert.
2445 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2446 members.
2447
bca633fb
EZ
24482011-08-23 Eli Zaretskii <eliz@gnu.org>
2449
2450 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2451 a character.
2452
4a5885a7
CY
24532011-08-23 Chong Yidong <cyd@stupidchicken.com>
2454
2455 * nsfont.m (ns_otf_to_script): Fix typo.
2456
0902a04e
KH
24572011-08-22 Kenichi Handa <handa@m17n.org>
2458
2459 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2460 extra slot even if the purpose is char-code-property-table.
2461
1a2e6670
EZ
24622011-08-23 Eli Zaretskii <eliz@gnu.org>
2463
8ddde651
EZ
2464 * xdisp.c (redisplay_window): When computing centering_position,
2465 account for the height of the header line. (Bug#8874)
2466
425cc014
EZ
2467 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2468 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2469 candidate is selected by the mouse, and that candidate has a
2470 composed character under the mouse.
2471
1a2e6670
EZ
2472 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2473 coordinates reported by pos-visible-in-window-p for a composed
2474 character in column zero.
2475
8b76d6f8
SM
24762011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2477
2478 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2479
dac347dd
EZ
24802011-08-22 Eli Zaretskii <eliz@gnu.org>
2481
2482 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2483 consider it a hit if to_charpos is anywhere in the range of the
2484 composed buffer positions.
2485
e013fb34
CY
24862011-08-22 Chong Yidong <cyd@stupidchicken.com>
2487
2488 * image.c (gif_load): Don't assume that each subimage has the same
2489 dimensions as the base image. Handle disposal method that is
2490 "undefined" by the gif spec (Bug#9335).
2491
bd1ba3e8
CY
24922011-08-20 Chong Yidong <cyd@stupidchicken.com>
2493
2494 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2495 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2496
54a1215b
EZ
24972011-08-19 Eli Zaretskii <eliz@gnu.org>
2498
823564e5
EZ
2499 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2500 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2501 from an Org mode buffer to a Speedbar frame.
2502
54a1215b
EZ
2503 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2504 a composition, take its buffer position from IT->cmp_it.charpos.
2505 Fixes cursor positioning at the beginning of a line that begins
2506 with a composed character.
2507
9778ebcc
EZ
25082011-08-18 Eli Zaretskii <eliz@gnu.org>
2509
0be6ee06
EZ
2510 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2511 character bidirectional type, use STRONG_L instead. Fixes crashes
2512 in a buffer produced by `describe-categories'.
2513
9778ebcc
EZ
2514 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2515 members before the level stack, so they would be saved and
2516 restored when copying iterator state. Fixes incorrect reordering
2517 around TABs covered by display properties.
2518
156bffbe
AS
25192011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2520
6b02f655 2521 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2522
72ad093b
CY
25232011-08-17 Chong Yidong <cyd@stupidchicken.com>
2524
2525 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2526 (internal_condition_case_2, internal_condition_case_n):
2527 Remove unnecessary aborts (Bug#9081).
72ad093b 2528
35774242
EZ
25292011-08-17 Eli Zaretskii <eliz@gnu.org>
2530
2531 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2532 has no `load' handler, try opening the file locally. (Bug#9311)
2533
db76dd85
KB
25342011-08-16 Ken Brown <kbrown@cornell.edu>
2535
2536 * gmalloc.c: Expand comment.
2537
b215eee5
EZ
25382011-08-16 Eli Zaretskii <eliz@gnu.org>
2539
2540 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2541 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2542
a4579d33
KB
25432011-08-16 Ken Brown <kbrown@cornell.edu>
2544
2545 Fix memory allocation problems in Cygwin build (Bug#9273).
2546
2547 * unexcw.c ( __malloc_initialized): Declare external variable.
2548 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2549
8b76d6f8
SM
2550 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2551 New variables.
a4579d33
KB
2552 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2553 dumped emacs.
2554 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2555 in the static heap.
2556 [CYGWIN] (special_realloc): New function.
2557 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2558 requests to realloc storage in the static heap.
2559
3ebec551
PE
25602011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2561
2562 * bidi.c (bidi_initialize): Remove unused local.
2563
9fd8be00
EZ
25642011-08-15 Eli Zaretskii <eliz@gnu.org>
2565
6b02f655
SM
2566 * bidimirror.h:
2567 * biditype.h: Remove file.
2568 * makefile.w32-in ($(BLD)/bidi.$(O)):
2569 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2570
2571 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2572
2573 * chartab.c: Improve commentary for the uniprop_table API.
2574
32413314
EZ
2575 * bidi.c (bidi_paragraph_init): Support zero value of
2576 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2577 (bidi_initialize): Use uniprop_table instead of including
2578 biditype.h and bidimirror.h.
32413314 2579
9fd8be00
EZ
2580 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2581 coordinates of the iterator when restoring from ppos_it.
2582 (Bug#9296)
2583
5cf2b69b
KH
25842011-08-14 Kenichi Handa <handa@m17n.org>
2585
2586 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2587 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2588
daf17d00
EZ
25892011-08-14 Eli Zaretskii <eliz@gnu.org>
2590
2591 * xdisp.c (move_it_in_display_line_to): Don't invoke
2592 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2593 ppos_it. Fixes vertical cursor motion when line beginning is
2594 covered by an image. (Bug#9296)
2595
08e3161a
JD
25962011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2597
2598 * nsterm.h (ns_run_ascript): Declare.
2599 (NSAPP_DATA2_RUNASSCRIPT): Define.
2600
2601 * nsfns.m (as_script, as_result, as_status): New static variables.
2602 (ns_run_ascript): New function.
5e617bc2 2603 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2604 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2605 the event loop. Get status from as_status (Bug#7276).
2606
2607 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2608 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2609 the event loop (Bug#7276).
2610
a3720aa2
AS
26112011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2612
2613 * gnutls.c (QCgnutls_bootprop_priority)
2614 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2615 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2616 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2617 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2618 (QCgnutls_bootprop_verify_hostname_error)
2619 (QCgnutls_bootprop_callbacks_verify): Rename from
2620 Qgnutls_bootprop_..., all uses changed.
2621
2622 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2623 uses changed.
2624
0a0d27fb
PE
26252011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2626
19d5c50c
PE
2627 * xfaces.c (Qframe_set_background_mode): Now static.
2628 * dispextern.h (Qframe_set_background_mode): Remove decl.
2629
0a0d27fb
PE
2630 * process.c (Fnetwork_interface_info): Declare local only if needed.
2631
377538cb
JD
26322011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2633
2634 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2635 (Fnetwork_interface_list): Allocate in increments of bytes instead
2636 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2637 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2638 sockaddr.
2639 (struct ifflag_def): notrailers is smart on OSX.
2640 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2641 Get hardware address with getifaddrs if available.
2642
08fff70c
EZ
26432011-08-12 Eli Zaretskii <eliz@gnu.org>
2644
2645 * xdisp.c (iterate_out_of_display_property): xassert that
2646 IT->position is set to within IT->object's boundaries. Break from
2647 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2648 when IT->position is set up wrongly due to some bug.
2649 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2650 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2651 entry. Force push_it to save on the stack the current
2652 buffer/string position, to be restored by pop_it. Fix flags in
2653 the iterator structure wrt the object coming from a display
2654 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2655 properties. (Bug#9284)
2656
7be1c708 26572011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2658
7be1c708
CY
2659 * fontset.c (fontset_get_font_group): Add proper type checks.
2660 (Bug#9172)
aac0c6e3 2661
7be1c708 26622011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2663
7be1c708
CY
2664 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2665 and LC_VERSION_MIN_MACOSX.
2666 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2667 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2668
97bb72a6
EZ
26692011-08-08 Eli Zaretskii <eliz@gnu.org>
2670
2671 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2672 no-display-properties-and-no-overlays under bidi display.
2673 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2674 properties and overlays.
97bb72a6 2675
d5617611
CY
26762011-08-08 Chong Yidong <cyd@stupidchicken.com>
2677
37e11a63
CY
2678 * editfns.c (Fset_time_zone_rule): Document relationship with the
2679 setenv function.
2680
d5617611
CY
2681 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2682 the font entity extracted from the cache (Bug#8109).
2683
58872834
CY
26842011-08-07 Chong Yidong <cyd@stupidchicken.com>
2685
2686 * composite.c (autocmp_chars): Don't reset point. That is done by
2687 restore_point_unwind (Bug#5984).
2688
75bfc667
JL
26892011-08-07 Juri Linkov <juri@jurta.org>
2690
2691 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2692 to show the arg `TIME' instead of `TIMEVAL'.
2693
d1410150
EZ
26942011-08-06 Eli Zaretskii <eliz@gnu.org>
2695
2696 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2697 display property strides EOL and includes a newline, as in
2698 longlines-mode. (Bug#9254)
75b771e4
EZ
2699 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2700 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2701
2702 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2703 is non-zero, even if the data buffer is NULL. Fixes a crash in
2704 vertical-motion with longlines-mode. (Bug#9254)
2705
35928349
EZ
27062011-08-05 Eli Zaretskii <eliz@gnu.org>
2707
ec7cc85b
EZ
2708 * bidi.c <bidi_cache_total_alloc>: Now static.
2709 (bidi_initialize): Initialize bidi_cache_total_alloc.
2710
8b76d6f8 2711 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2712 cache. (Bug#9221)
2713
2714 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2715 amount allocated this far in `bidi_cache_total_alloc'.
2716 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2717 non-zero, only free the data buffer without restoring the cache
2718 contents. All callers changed.
2719
2720 * dispextern.h (bidi_unshelve_cache): Update prototype.
2721
2722 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2723 (move_it_in_display_line, move_it_to)
2724 (move_it_vertically_backward, move_it_by_lines): Replace the call
2725 to xfree to an equivalent call to bidi_unshelve_cache.
2726 (move_it_in_display_line_to): Fix logic of returning
412b6358 2727 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2728
e2e2423b
EZ
27292011-08-05 Eli Zaretskii <eliz@gnu.org>
2730
2731 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2732 came from a string character with a `cursor' property. (Bug#9229)
2733
ae9e757a
JD
27342011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2735
2736 * Makefile.in (LIB_PTHREAD): New variable.
2737 (LIBES): Add LIB_PTHREAD (Bug#9216).
2738
2739 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2740 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2741
213bd7f2
AS
27422011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2743
6b02f655 2744 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2745
99aaf75f
JD
27462011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2747
2748 * xterm.c (x_find_topmost_parent): New function.
2749 (x_set_frame_alpha): Find topmost parent window with
2750 x_find_topmost_parent and set the property there also (bug#9181).
2751 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2752
c74e9d86
PE
27532011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2754
2755 * callproc.c (Fcall_process): Avoid vfork clobbering
2756 the local vars buffer, coding_systems, current_dir.
2757
640c8776
SM
27582011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2759
2760 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2761
f26d0e4c
PE
27622011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2763
8a10d76c
PE
2764 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2765 so that it is not optimized away.
2766
f26d0e4c
PE
2767 * xdisp.c (compute_display_string_pos): Remove unused local.
2768
55439c61
EZ
27692011-08-02 Eli Zaretskii <eliz@gnu.org>
2770
2771 Fix slow cursor motion and scrolling in large buffers with
2772 selective display, like Org Mode buffers. (Bug#9218)
2773
2774 * dispextern.h (struct bidi_it): New member disp_prop_p.
2775
2776 * xdisp.c: Remove one-slot cache of display string positions.
2777 (compute_display_string_pos): Accept an additional argument
5e617bc2 2778 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2779 for a display string or property. If found, set DISP_PROP_P
2780 non-zero.
2781
2782 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2783 DISP_PROP_P, and pass it to compute_display_string_pos.
2784 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2785 non-zero. All callers of bidi_fetch_char changed.
2786
fb33fa43
SM
27872011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2788
2789 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2790
b099e063
DM
27912010-12-03 Don March <don@ohspite.net>
2792
2793 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2794 last character M-[char] is translated to ESC [char] (bug#7541).
2795
5cc7f7af
KH
27962011-08-02 Kenichi Handa <handa@m17n.org>
2797
d0fffa3f 2798 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2799
2800 * chartab.c (uniprop_table): Make it non-static.
2801
525d5e6e
EZ
28022011-08-01 Eli Zaretskii <eliz@gnu.org>
2803
2804 * xdisp.c (forward_to_next_line_start): Accept additional argument
2805 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2806 on the newline.
2807 (reseat_at_next_visible_line_start): Use the bidi iterator state
2808 returned by forward_to_next_line_start to restore the state of
2809 it->bidi_it after backing up to previous newline. (Bug#9212)
2810
31011111
AS
28112011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2812
2813 * regex.c (re_comp): Protoize.
2814 (re_exec): Fix return type.
2815 (regexec): Fix type of `ret'. (Bug#9203)
2816
476371c4
PE
28172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2818
e5d76069
PE
2819 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2820 This is needed if max-image-size is a floating-point number.
2821
9a79b20c
AS
28222011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2823
2824 * print.c (print_object): Print empty symbol as ##.
2825
2826 * lread.c (read1): Read ## as empty symbol.
2827
d8c2fa78
AA
28282011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2829
2830 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2831 setting frame foreground color (Bug#9175).
2832 (x_set_background_color): Likewise.
2833
ffe57a7a
AA
2834 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2835 contents (Bug#9176).
2836 (EmacsTooltip -init): Remove bezels and add shadows to
2837 tooltip windows.
2838
bf3492a5
AA
2839 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2840 or scroll bar (Bug#8470).
2841
d55e9c53
AA
2842 * nsfont.m (nsfont_open): Remove assignment to voffset and
2843 unnecessary vars hshink, expand, hd, full_height, min_height.
2844 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2845
2846 * nsterm.h (nsfont_info): Remove voffset field.
2847
d8c2fa78 28482011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2849
2850 Implement strike-through and overline on NextStep (Bug#8863).
2851
2852 * nsfont.m (nsfont_open): Use underline position provided by font,
2853 instead of hard-coded value of 2.
2854 (nsfont_draw): Call ns_draw_text_decoration instead.
2855
2856 * nsterm.h: Add declaration for ns_draw_text_decoration.
2857
2858 * nsterm.m (ns_draw_text_decoration): New function for drawing
2859 underline, overline, and strike-through.
2860 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2861 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2862 accommodate underlining, etc.
4843aac3 2863
4cc60b9b
EZ
28642011-07-28 Eli Zaretskii <eliz@gnu.org>
2865
bc7ece87
EZ
2866 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2867 default.
4cc60b9b 2868
476371c4
PE
28692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2870
66606eea
PE
2871 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2872 Without this fix, if a signal arrives just after memory fills up,
2873 'malloc' might be invoked reentrantly.
2874
476371c4
PE
2875 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2876 In other words, assume that every image size is allowed, on non-X
2877 hosts. This assumption is probably wrong, but it lets Emacs compile.
2878
f3fcc40d
AS
28792011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2880
2881 * regex.c (re_iswctype): Convert return values to boolean.
2882
350c992f
EZ
28832011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2884
2885 * xdisp.c (compute_display_string_pos): Don't use cached display
2886 string position if the buffer had its restriction changed.
2887 (Bug#9184)
2888
5266b4bb
PE
28892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2892
2573a837 28932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2894
41f55ccd 2895 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2896
39e378da
PE
2897 * bidi.c: Integer size and overflow fixes.
2898 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2899 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2900 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2901 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2902 (bidi_find_other_level_edge):
2903 Use ptrdiff_t instead of EMACS_INT where either will do.
2904 This works better on 32-bit hosts configured --with-wide-int.
2905 (bidi_cache_ensure_space): Check for size-calculation overflow.
2906 Use % rather than repeated addition, for better worst-case speed.
2907 Don't set bidi_cache_size until after xrealloc returns, because it
2908 might not return.
2909 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2910 (bidi_cache_ensure_space): Also check that the bidi cache size
2911 does not exceed that of the largest Lisp string or buffer. See Eli
2912 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2913
5e927815
PE
2914 * alloc.c (__malloc_size_t): Remove.
2915 All uses replaced by size_t. See Andreas Schwab's note
2916 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2917
ca4aa935
PE
2918 * image.c: Improve checking for integer overflow.
2919 (check_image_size): Assume that f is nonnull, since
2920 it is always nonnull in practice. This is one less thing to
2921 worry about when checking for integer overflow later.
2922 (x_check_image_size): New function, which checks for integer
2923 overflow issues inside X.
2924 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2925 This removes the need for a memory_full check.
2926 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2927 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2928 (xbm_read_bitmap_data): Change locals back to 'int', since
2929 their values must fit in 'int'.
2930 (xpm_load_image, png_load, tiff_load):
2931 Invoke x_create_x_image_and_pixmap earlier,
2932 to avoid much needless work if the image is too large.
2933 (tiff_load): Treat overly large images as if
2934 x_create_x_image_and_pixmap failed, not as malloc failures.
2935 (gs_load): Use x_check_image_size.
2936
5f8f9cc2
PE
2937 * gtkutil.c: Omit integer casts.
2938 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2939 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2940
5adf60bc
PE
2941 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2942
c8907a93
PE
2943 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2944 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2945 would wrongly return t on a 64-bit host.
2946
e3c25c68
PE
2947 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2948 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2949 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2950 and therefore cause GCC to emit a bogus diagnostic in some cases.
2951
3f791afe
PE
2952 * image.c: Integer signedness and overflow and related fixes.
2953 This is not an exhaustive set of fixes, but it's time to
2954 record what I've got.
2955 (lookup_pixel_color, check_image_size): Remove redundant decls.
2956 (check_image_size): Don't assume that arbitrary EMACS_INT values
2957 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2958 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2959 (tiff_load, imagemagick_load_image):
2960 Check for overflow in size calculations.
2961 (x_create_x_image_and_pixmap): Remove unnecessary test for
2962 xmalloc returning NULL; that can't happen.
2963 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2964 (xpm_color_bucket): Use better integer hashing function.
2965 (xpm_cache_color): Don't possibly over-allocate memory.
2966 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2967 (gif_memory_source):
2968 Use ptrdiff_t, not int or size_t, to record sizes.
2969 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2970 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2971 either works, as we prefer signed integers.
2972 (tiff_read_from_memory, tiff_write_from_memory):
2973 Return tsize_t, not size_t, since that's what the TIFF API wants.
2974 (tiff_read_from_memory): Don't fail simply because the read would
2975 go past EOF; instead, return a short read.
2976 (tiff_load): Omit no-longer-needed casts.
2977 (Fimagemagick_types): Don't assume size fits into 'int'.
2978
3cc5a532
PE
2979 Improve hashing quality when configured --with-wide-int.
2980 * fns.c (hash_string): New function, taken from sxhash_string.
2981 Do not discard information about ASCII character case; this
2982 discarding is no longer needed.
2983 (sxhash-string): Use it. Change sig to match it. Caller changed.
2984 * lisp.h: Declare it.
2985 * lread.c (hash_string): Remove, since we now use fns.c's version.
2986 The fns.c version returns a wider integer if --with-wide-int is
2987 specified, so this should help the quality of the hashing a bit.
2988
b312a492
PE
2989 * emacs.c: Integer overflow minor fix.
2990 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2991 Define only if GNU_LINUX.
2992 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2993
dfd153ae
PE
2994 * dispnew.c: Integer signedness and overflow fixes.
2995 Remove unnecessary forward decls, that were a maintenance hassle.
2996 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2997 All uses changed.
2998 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2999 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3000 (prepare_desired_row, line_draw_cost):
3001 Use int, not unsigned, where either works.
3002 (save_current_matrix, restore_current_matrix):
3003 Use ptrdiff_t, not size_t, where either works.
3004 (init_display): Check for overflow more accurately, and without
3005 relying on undefined behavior.
3006
a81d11a3
PE
3007 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3008 Remove, replacing with the new symbols in lisp.h. All uses changed.
3009 * fileio.c (make_temp_name):
3010 * filelock.c (lock_file_1, lock_file):
3011 * xdisp.c (message_dolog):
3012 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3013 Use pMd etc. instead.
3014 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3015 replacing the pWIDE etc. symbols removed from editfns.c.
3016
3300e6fd
PE
3017 * keyboard.h (num_input_events): Now uintmax_t.
3018 This is (very slightly) less likely to mess up due to wraparound.
3019 All uses changed.
3020
fd05c7e9
PE
3021 * buffer.c: Integer signedness fixes.
3022 (alloc_buffer_text, enlarge_buffer_text):
3023 Use ptrdiff_t rather than size_t when either will do, as we prefer
3024 signed integers.
3025
903fe15d
PE
3026 * alloc.c: Integer signedness and overflow fixes.
3027 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3028 (__malloc_size_t): Default to size_t, not to int.
3029 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3030 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3031 Prefer ptrdiff_t to size_t when either would do, as we prefer
3032 signed integers.
3033 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3034 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3035 Now const. Initialize with values that are in range even if char
3036 is signed.
3037 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3038 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3039 These functions do the right thing with sizes > 2**32.
3040 (check_depth): Now ptrdiff_t, not int.
3041 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3042 Adjust to new way of storing sizes. Check for size overflow bugs
3043 in rest of code.
3044 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3045 slightly wrong anyway, as it missed one instance of
3046 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3047 (refill_memory_reserve): Omit needless cast to size_t.
3048 (mark_object_loop_halt): Mark as externally visible.
3049
ac82cc6a
PE
3050 * xselect.c: Integer signedness and overflow fixes.
3051 (Fx_register_dnd_atom, x_handle_dnd_message):
3052 Use ptrdiff_t, not size_t, since we prefer signed.
3053 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3054 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3055 x_dnd_atoms_size and x_dnd_atoms_length.
3056
c2d1e36d
PE
3057 * doprnt.c: Prefer signed to unsigned when either works.
3058 * eval.c (verror):
3059 * doprnt.c (doprnt):
3060 * lisp.h (doprnt):
3061 * xdisp.c (vmessage):
3062 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3063 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3064 prefer signed arithmetic to avoid comparison confusion.
3065 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3066 but is a bit tricky.
3067
0e926e56
PE
3068 Assume freestanding C89 headers, string.h, stdlib.h.
3069 * data.c, doprnt.c, floatfns.c, print.c:
3070 Include float.h unconditionally.
3071 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3072 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3073 * regex.c: Likewise for stddef.h, string.h.
3074 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3075 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3076 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3077 (STDC_HEADERS): Remove obsolete defines.
3078 * sysdep.c: Include limits.h unconditionally.
3079
9cfdb3ec
PE
3080 Assume support for memcmp, memcpy, memmove, memset.
3081 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3082 * regex.c (memcmp, memcpy):
3083 Remove; we assume C89 now.
3084
3085 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3086 (__malloc_safe_bcopy): Remove; no longer needed.
3087
cf950e6b 3088 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3089 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3090 well either way, and we prefer signed to unsigned.
3091
dbf38e02
LMI
30922011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3093
3094 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3095 closes the connection while we're reading (bug#9182).
3096
d6f0886c 30972011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3098
d6f0886c
JD
3099 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3100 are specified (Bug#9168).
24e0f6b1 3101
2eb1f9e6
PE
31022011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3105 Found by GCC static checking and --with-wide-int on a 32-bit host.
3106
22381272 31072011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3108
3109 * xdisp.c (compute_display_string_pos): Fix logic of caching
3110 previous display string position. Initialize cached_prev_pos to
3111 -1. Fixes slow-down at the beginning of a buffer.
3112
f25e39b4
EZ
31132011-07-24 Eli Zaretskii <eliz@gnu.org>
3114
3115 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3116 for attrs[LFACE_FONTSET_INDEX].
3117
04c4b52e
PE
31182011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3119
3120 * xml.c (parse_region): Remove unused local
3121 that was recently introduced.
3122
c1734fbd
EZ
31232011-07-23 Eli Zaretskii <eliz@gnu.org>
3124
be18c5a5
EZ
3125 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3126 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3127
c1734fbd
EZ
3128 * xdisp.c (move_it_in_display_line_to): Record the best matching
3129 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3130 exit if none of the characters scanned was an exact match.
3131 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3132 when exact match is impossible due to invisible text, and the
3133 lines are truncated.
3134
a258d627
JD
31352011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3136
3137 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3138 for OSX >= 10.7.
3139
b6d5a689
EZ
31402011-07-22 Eli Zaretskii <eliz@gnu.org>
3141
0f74f785
EZ
3142 Fix a significant slow-down of cursor motion with C-n, C-p,
3143 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3144 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3145 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3146 (next_element_from_buffer): Call compute_stop_pos_backwards to
3147 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3148 base_level_stop.
3149 (reseat): Don't look for prev_stop, as that could mean a very long
3150 run.
3151 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3152 <cached_disp_overlay_modiff>: Cache for last found display string
3153 position.
551918c1 3154 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3155 about the same buffer in the same area of character positions, and
3156 the buffer wasn't changed since the time the display string
3157 position was cached.
551918c1 3158
b2d0c91a
EZ
31592011-07-22 Eli Zaretskii <eliz@gnu.org>
3160
3161 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3162 is an integer, which is important for empty lines. (Bug#9149)
3163
043604ee
CY
31642011-07-22 Chong Yidong <cyd@stupidchicken.com>
3165
3166 * frame.c (Fmodify_frame_parameters): In tty case, update the
3167 default face if necessary (Bug#4238).
3168
da4adb04
CY
31692011-07-21 Chong Yidong <cyd@stupidchicken.com>
3170
3171 * editfns.c (Fstring_to_char): No need to explain what a character
3172 is in the docstring (Bug#6576).
3173
9abd0532
LMI
31742011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3175
3176 * xml.c (parse_region): Make sure we always return a tree.
3177
36881d16
HK
31782011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3179
3180 * xml.c (parse_region): If a document contains only comments,
3181 return that, too.
3182
1e98674d
LMI
31832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3184
3185 * xml.c (make_dom): Return comments, too.
3186
590bd467
PE
31872011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3188
3189 Port to OpenBSD.
3190 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3191 and the surrounding thread.
3192 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3193 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3194 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3195 timer goes off.
3196 * s/openbsd.h (BROKEN_SIGIO): Define.
3197 * unexelf.c (unexec) [__OpenBSD__]:
3198 Don't update the .mdebug section of the Alpha COFF symbol table.
3199
f41628b2
LMI
32002011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3201
3202 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3203 (bug#8460).
3204
b59b67c5
PE
32052011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3206
15e3a074
PE
3207 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3208 This fixes some race conditions on the permissions of any newly
3209 created file.
3210
41bed37d
PE
3211 * alloc.c (valid_pointer_p): Use pipe, not open.
3212 This fixes some permissions issues when debugging.
3213
b59b67c5
PE
3214 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3215 If fchown fails to set both uid and gid, try to set just gid,
3216 as that is sometimes allowed. Adjust the file's mode to eliminate
3217 setuid or setgid bits that are inappropriate if fchown fails.
3218
925a6be7
SM
32192011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3220
3221 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3222 to compare Lisp_Objects.
3223 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3224 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3225 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3226
52968808
AS
32272011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3228
0a6a104b
AS
3229 * lread.c (read_integer): Unread even EOF character.
3230 (read1): Likewise. Properly record start position of symbol.
3231
52968808
AS
3232 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3233 symbol character follows.
3234
9e381cdd
PE
32352011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3238 This works around a problem with the previous change to Fcopy_file.
3239 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3240 and without this change, GCC might complain about discarding
3241 fchown's return value.
3242
b5641435
JB
32432011-07-16 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3246
a8031457
PE
32472011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3248
3249 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3250
dd889327
LMI
32512011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3252
750c33f7
LMI
3253 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3254 it's used from the C level.
3255
dd889327
LMI
3256 * process.c: Use the same condition for POLL_FOR_INPUT in both
3257 keyboard.c and process.c (bug#1858).
3258
87e86684
LM
32592011-07-09 Lawrence Mitchell <wence@gmx.li>
3260
3261 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3262 (Fgnutls_boot): Use it.
3263
64348f40
AS
32642011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3265
3266 * doc.c (Fsubstitute_command_keys): Revert last change.
3267
1d698799
LMI
32682011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3269
f863868c
LMI
3270 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3271 quotes the next character, and doesn't affect other longer
3272 sequences (bug#8935).
3273
1d698799
LMI
3274 * lread.c (syms_of_lread): Clarify that is isn't only
3275 `eval-buffer' and `eval-defun' that's affected by
3276 `lexical-binding' (bug#8460).
3277
aa4b6df6
EZ
32782011-07-15 Eli Zaretskii <eliz@gnu.org>
3279
3280 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3281 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3282
5d856da6
PE
32832011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3284
ad6042bb
PE
3285 Fix minor problems found by static checking.
3286 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3287 (elsz): Now a signed constant, not a size_t var. We prefer signed
3288 types to unsigned, to avoid integer comparison confusion. Without
3289 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3290 "cannot optimize loop, the loop counter may overflow", a symptom
3291 of the confusion.
f00bbb22 3292 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3293 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3294
6468f31c
LMI
32952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3296
49080b10
LMI
3297 * search.c (Fre_search_backward): Mention `case-fold-search' in
3298 all the re_search_* functions (bug#8138).
3299
6468f31c
LMI
3300 * keyboard.c (Fopen_dribble_file): Document when the file is
3301 closed (bug#8056).
3302
c965adc5
EZ
33032011-07-14 Eli Zaretskii <eliz@gnu.org>
3304
df9733bf
EZ
3305 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3306 bidi_cache_idx.
3307
0bb23927
EZ
3308 Support bidi reordering of display and overlay strings.
3309 * xdisp.c (compute_display_string_pos)
3310 (compute_display_string_end): Accept additional argument STRING.
3311 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3312 (reseat_to_string): Initialize bidi_it->string.s and
3313 bidi_it->string.schars.
3314 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3315 NULL (avoids a crash in bidi_paragraph_init).
3316 Initialize itb.string.lstring.
0bb23927
EZ
3317 (init_iterator): Call bidi_init_it only of a valid
3318 buffer position was specified. Initialize paragraph_embedding to
3319 L2R.
3320 (reseat_to_string): Initialize the bidi iterator.
3321 (display_string): If we need to ignore text properties of
3322 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3323 original value of -1 will not work with bidi.)
3324 (compute_display_string_pos): First arg is now struct
3325 `text_pos *'; all callers changed. Support display properties on
3326 Lisp strings.
3327 (compute_display_string_end): Support display properties on Lisp
3328 strings.
3329 (init_iterator, reseat_1, reseat_to_string): Initialize the
3330 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3331 when iterating on a string not from display properties).
640c8776
SM
3332 (compute_display_string_pos, compute_display_string_end):
3333 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3334 arrow keys.
3335 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3336 base_level_stop; instead, set base_level_stop to BEGV.
3337 Fixes crashes in vertical-motion.
0bb23927
EZ
3338 (next_element_from_buffer): Improve commentary for when
3339 the iterator is before prev_stop.
3340 (init_iterator): Initialize bidi_p from the default value of
3341 bidi-display-reordering, not from buffer-local value. Use the
3342 buffer-local value only if initializing for buffer iteration.
3343 (handle_invisible_prop): Support invisible properties on strings
3344 that are being bidi-reordered.
3345 (set_iterator_to_next): Support bidi reordering of C strings and
3346 Lisp strings.
3347 (next_element_from_string): Support bidi reordering of Lisp
3348 strings.
3349 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3350 (display_string): Support display of R2L glyph rows.
3351 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3352 (init_iterator): Don't initialize it->bidi_p for strings
3353 here.
3354 (reseat_to_string): Initialize it->bidi_p for strings here.
3355 (next_element_from_string, next_element_from_c_string)
3356 (next_element_from_buffer): Add xassert's for correspondence
3357 between IT's object being iterated and it->bidi_it.string
3358 structure.
3359 (face_before_or_after_it_pos): Support bidi iteration.
3360 (next_element_from_c_string): Handle the case of the first string
3361 character that is not the first one in the visual order.
3362 (get_visually_first_element): New function, refactored from common
3363 parts of next_element_from_buffer, next_element_from_string, and
3364 next_element_from_c_string.
3365 (tool_bar_lines_needed, redisplay_tool_bar)
3366 (display_menu_bar): Force left-to-right direction. Add a FIXME
3367 comment for making that be controlled by a user option.
3368 (push_it, pop_it): Save and restore the state of the
3369 bidi iterator. Save and restore the bidi_p flag.
3370 (pop_it): Iterate out of display property for string iteration as
3371 well.
3372 (iterate_out_of_display_property): Support iteration over strings.
3373 (handle_single_display_spec): Set up it->bidi_it for iteration
3374 over a display string, and call bidi_init_it.
3375 (handle_single_display_spec, next_overlay_string)
3376 (get_overlay_strings_1, push_display_prop): Set up the bidi
3377 iterator for displaying display or overlay strings.
3378 (forward_to_next_line_start): Don't use the shortcut if
3379 bidi-iterating.
3380 (back_to_previous_visible_line_start): If handle_display_prop
3381 pushed the iterator stack, restore the internal state of the bidi
3382 iterator by calling bidi_pop_it same number of times.
3383 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3384 and we are bidi-iterating, don't decrement the iterator position;
3385 instead, set the first_elt flag in the bidi iterator, to produce
3386 the same effect.
3387 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3388 (push_display_prop): xassert that we are iterating a buffer.
3389 (push_it, pop_it): Save and restore paragraph_embedding member.
3390 (handle_single_display_spec, next_overlay_string)
3391 (get_overlay_strings_1, reseat_1, reseat_to_string)
3392 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3393 correctly. Don't assume unibyte strings are not bidi-reordered.
3394 (compute_display_string_pos)
3395 (compute_display_string_end): Fix handling the case of C string.
3396 (push_it, pop_it): Save and restore from_disp_prop_p.
3397 (handle_single_display_spec, push_display_prop): Set the
3398 from_disp_prop_p flag.
3399 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3400 (pop_it): Call iterate_out_of_display_property only if we are
3401 popping after iteration over a string that came from a display
3402 property. Fix a typo in popping stretch info. Add an assertion
3403 for verifying that the iterator position is in sync with the bidi
3404 iterator.
3405 (handle_single_display_spec, get_overlay_strings_1)
3406 (push_display_prop): Fix initialization of paragraph direction for
3407 string when that of the parent object is not yet determined.
3408 (reseat_1): Call bidi_init_it to resync the bidi
3409 iterator with IT's position. (Bug#7616)
3410 (find_row_edges): If ROW->start.pos gives position
3411 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3412 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3413 Reset the from_disp_prop_p flag.
3414 (SAVE_IT, RESTORE_IT): New macros.
3415 (pos_visible_p, face_before_or_after_it_pos)
3416 (back_to_previous_visible_line_start)
3417 (move_it_in_display_line_to, move_it_in_display_line)
3418 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3419 (try_scrolling, redisplay_window, display_line): Use them when
3420 saving a temporary copy of the iterator and restoring it back.
3421 (back_to_previous_visible_line_start, reseat_1)
3422 (init_iterator): Empty the bidi cache "stack".
3423 (move_it_in_display_line_to): If iterator ended up at
3424 EOL, but we never saw any buffer positions smaller than
3425 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3426 motion in bidi-reordered lines.
3427 (move_it_in_display_line_to): Record prev_method and prev_pos
3428 immediately before the call to set_iterator_to_next. Fixes cursor
3429 motion in bidi-reordered lines with stretch glyphs and strings
3430 displayed in margins. (Bug#8133) (Bug#8867)
3431 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3432 TO_CHARPOS.
640c8776
SM
3433 (pos_visible_p): Support positions in bidi-reordered lines.
3434 Save and restore bidi cache.
0bb23927
EZ
3435
3436 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3437 (bidi_paragraph_info): Delete unused struct.
3438 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3439 (bidi_cache_start): New variable.
3440 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3441 to zero.
3442 (bidi_cache_fetch_state, bidi_cache_search)
3443 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3444 (bidi_cache_find, bidi_peek_at_next_level)
3445 (bidi_level_of_next_char, bidi_find_other_level_edge)
3446 (bidi_move_to_visually_next): Compare cache index with
3447 bidi_cache_start rather than with zero.
3448 (bidi_fetch_char): Accept new argument STRING; all callers
3449 changed. Support iteration over a string. Support strings with
3450 display properties. Support unibyte strings. Fix the type of
3451 `len' according to what STRING_CHAR_AND_LENGTH expects.
3452 (bidi_paragraph_init, bidi_resolve_explicit_1)
3453 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3454 (bidi_level_of_next_char, bidi_move_to_visually_next):
3455 Support iteration over a string.
0bb23927
EZ
3456 (bidi_set_sor_type, bidi_resolve_explicit_1)
3457 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3458 can now be zero (for strings); special values 0 and -1 were
3459 changed to -1 and -2, respectively.
3460 (bidi_char_at_pos): New function.
3461 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3462 Call it instead of FETCH_MULTIBYTE_CHAR.
3463 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3464 initialized to valid values.
3465 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3466 values.
3467 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3468 the test for valid cached positions. Fix the logic for looking up
3469 the sentinel state in the cache. GCPRO the Lisp string we are
3470 iterating.
3471 (bidi_push_it, bidi_pop_it): New functions.
3472 (bidi_initialize): Initialize the bidi cache start stack pointer.
3473 (bidi_cache_ensure_space): New function, refactored from part of
3474 bidi_cache_iterator_state. Don't assume the required size is just
3475 one BIDI_CACHE_CHUNK away.
3476 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3477 (bidi_count_bytes, bidi_char_at_pos): New functions.
3478 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3479 always valid if bidi_cache_idx is valid.
3480 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3481 is valid if it's going to be used.
3482 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3483 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3484 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3485 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3486 (bidi_find_other_level_edge, bidi_cache_start_stack):
3487 All variables related to cache indices are now EMACS_INT.
c965adc5 3488
0bb23927
EZ
3489 * dispextern.h (struct bidi_string_data): New structure.
3490 (struct bidi_it): New member `string'. Make flag members be 1-bit
3491 fields, and put them last in the struct.
640c8776
SM
3492 (compute_display_string_pos, compute_display_string_end):
3493 Update prototypes.
0bb23927
EZ
3494 (bidi_push_it, bidi_pop_it): Add prototypes.
3495 (struct iterator_stack_entry): New members bidi_p,
3496 paragraph_embedding, and from_disp_prop_p.
3497 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3498 (bidi_shelve_cache, bidi_unshelve_cache):
3499 Declare prototypes.
0bb23927
EZ
3500
3501 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3502 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3503 and vector-like objects.
3504
3505 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3506 cache around display iteration.
3507
3508 * window.c (Fwindow_end, window_scroll_pixel_based)
3509 (displayed_window_lines, Frecenter): Save and restore the bidi
3510 cache around display iteration.
3511
3bbd2265
LMI
35122011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3513
3514 * editfns.c (Fdelete_region): Clarify the use of the named
3515 parameters (bug#6788).
3516
adc47434
MR
35172011-07-14 Martin Rudalics <rudalics@gmx.at>
3518
3519 * indent.c (Fvertical_motion): Set and restore w->pointm when
3520 saving and restoring the window's buffer (Bug#9006).
3521
837c31f8
LMI
35222011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3523
3524 * editfns.c (Fstring_to_char): Clarify just what is returned
3525 (bug#6576). Text by Eli Zaretskii.
3526
ac389d0c
JB
35272011-07-13 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3530
0be0ce47
EZ
35312011-07-13 Eli Zaretskii <eliz@gnu.org>
3532
3533 * buffer.c (mmap_find): Fix a typo.
3534
cd18e7e3
JB
35352011-07-13 Johan Bockgård <bojohan@gnu.org>
3536
3537 Fix execution of x selection hooks.
3538 * xselect.c (Qx_lost_selection_functions)
3539 (Qx_sent_selection_functions): New vars.
3540 (syms_of_xselect): DEFSYM them.
3541 (x_handle_selection_request): Pass Qx_sent_selection_functions
3542 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3543 (x_handle_selection_clear,x_clear_frame_selections):
3544 Pass Qx_lost_selection_functions rather than
3545 Vx_lost_selection_functions to Frun_hook_with_args.
3546
47ea7f44
PE
35472011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3548
ac389d0c 3549 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3550 The old code sometimes used this field without initializing it.
3551
47ea7f44
PE
3552 * alloc.c (gc_sweep): Don't read past end of array.
3553 In theory, the old code could also have corrupted Emacs internals,
3554 though it'd be very unlikely.
3555
bc985c87
AS
35562011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3557
3558 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3559 argument. (Bug#4026)
bc985c87 3560
0cf34688
LMI
35612011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3562
b3dadd76
LMI
3563 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3564 key" (bug#4257).
3565
0cf34688
LMI
3566 * window.c (Fset_window_start): Doc fix (bug#4199).
3567 (Fset_window_hscroll): Ditto.
3568
270768cd
PE
35692011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3570
077e3dda 3571 Fix minor new problems caught by GCC 4.6.1.
270768cd 3572 * term.c (init_tty): Remove unused local.
490011a6 3573 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3574 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3575 not used otherwise.
270768cd 3576
b1f58454
CY
35772011-07-12 Chong Yidong <cyd@stupidchicken.com>
3578
3579 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3580
22b9578d
LMI
35812011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3582
6e70ab07
LMI
3583 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3584 are the mini-buffer and the echo area (bug#3320).
3585
22b9578d
LMI
3586 * term.c (init_tty): Remove support for supdup, c10 and perq
3587 terminals, which are no longer supported (bug#1482).
3588
8974cc9f
JB
35892011-07-10 Johan Bockgård <bojohan@gnu.org>
3590
3591 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3592
a560d974
JD
35932011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3594
3595 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3596 for non-popups (Bug#3642).
3597
1dae0f0a
AS
35982011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3599
268c2c36 3600 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3601 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3602 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3603 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3604 * data.c (fmod): Likewise.
3605 * dispnew.c (swap_glyphs_in_rows): Likewise.
3606 * emacs.c (memory_warning_signal): Likewise.
3607 * floatfns.c (float_error): Likewise.
3608 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3609 (otf_open, font_otf_capability, generate_otf_features)
3610 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3611 Likewise.
3612 * image.c (pbm_read_file): Likewise.
3613 * indent.c (string_display_width): Likewise.
3614 * intervals.c (check_for_interval, search_for_interval)
3615 (inc_interval_count, count_intervals, root_interval)
3616 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3617 * lread.c (defalias): Likewise.
268c2c36 3618 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3619 * regex.c (set_image_of_range_1, set_image_of_range)
3620 (regex_grow_registers): Likewise.
3621 * sysdep.c (strerror): Likewise.
3622 * termcap.c (valid_filename_p, tprint, main): Likewise.
3623 * tparam.c (main): Likewise.
3624 * unexhp9k800.c (run_time_remap, save_data_space)
3625 (update_file_ptrs, read_header, write_header, calculate_checksum)
3626 (copy_file, copy_rest, display_header): Likewise.
3627 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3628 Likewise.
3629 * xdisp.c (check_it): Likewise.
3630 * xfaces.c (register_color, unregister_color, unregister_colors):
3631 Likewise.
3632 * xfns.c (print_fontset_result): Likewise.
3633 * xrdb.c (member, fatal, main): Likewise.
3634
99033785
PE
36352011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 Fix minor problems found by static checking (Bug#9031).
3638 * chartab.c (char_table_set_range, map_sub_char_table):
3639 Remove unused locals.
3640 (uniprop_table): Now static.
3641 * composite.c (_work_char): Remove unused static var.
3642
9cb2ac56
JB
36432011-07-09 Juanma Barranquero <lekktu@gmail.com>
3644
3645 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3646
f25661f0
JD
36472011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3648
3649 * gtkutil.c (qttip_cb): Remove code without function.
3650
8278c4fe
EZ
36512011-07-09 Eli Zaretskii <eliz@gnu.org>
3652
3653 * w32.c (pthread_sigmask): New stub.
3654
1692ae2d 36552011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3656
8a6ebd58 3657 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3658 sigprocmask is portable only for single-threaded applications, and
3659 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3660 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3661 (LIBES): Use it.
3662 * callproc.c (Fcall_process):
3663 * process.c (create_process):
3664 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3665 Use pthread_sigmask, not sigprocmask.
123403e4 3666
1b854618
JD
36672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3668
3669 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3670 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3671 wrong (Bug#8591).
3672
3fe4b549
JD
36732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3674
0ce7e563
JD
3675 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3676 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3677 (xg_hide_tooltip): Fix comment.
3678
3fe4b549
JD
3679 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3680 in registerServicesMenuSendTypes.
3681 (validRequestorForSendType): Don't check ns_return_types.
3682
3683 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3684 ns_return_type.
3685
5df75e47
JR
36862011-07-08 Jason Rumney <jasonr@gnu.org>
3687
22610910
JR
3688 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3689 SH_SHOW for hidden windows (Bug#5482).
3690
5df75e47
JR
3691 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3692 frame struct members of non-existent frames (Bug#6284).
3693
699c10bd
JD
36942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3695
4393663b
JD
3696 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3697 variable firstTime not needed on OSX >= 10.6.
3698 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3699 >= 10.5. Use setKnobProportion, setDoubleValue.
3700
3701 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3702 (MAC_OS_X_VERSION_10_5): Define if not defined.
3703 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3704 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3705 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3706
3707 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3708 cString and lossyCString on OSX >= 10.4
3709
58179cce 3710 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3711 sizeToFit on OSX >= 10.2.
3712
3713 * nsimage.m (allocInitFromFile): Don't use deprecated method
3714 bestRepresentationForDevice on OSX >= 10.6.
3715
3716 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3717 to avoid warning.
3718
3719 * emacs.c: Declare unexec_init_emacs_zone.
3720
a63e0781
JD
3721 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3722
699c10bd
JD
3723 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3724
3725 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3726 on svcsMenu (Bug#8842).
3727
3728 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3729 ns_return_types.
3730 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3731
3732 * nsterm.m (QUTF8_STRING): Declare.
3733 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3734 (validRequestorForSendType): Return type is (id).
3735 Change indexOfObjectIdenticalTo to indexOfObject.
3736 Check if we have local selection before returning self (Bug#8842).
3737 (writeSelectionToPasteboard): Put local selection into paste board
3738 if we have a local selection (Bug#8842).
3739 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3740
3741 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3742 (ns_get_local_selection): Declare.
3743
54e10184
LMI
37442011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3745
9888ff71
LMI
3746 * keymap.c (describe_map_tree): Don't insert a double newline at
3747 the end of the buffer (bug#1169) and return whether we inserted
3748 something.
3749
54e10184
LMI
3750 * callint.c (Fcall_interactively): Change "reading args" to
3751 "providing args" to try to clarify what it does (bug#1010).
3752
15fa4783
KH
37532011-07-07 Kenichi Handa <handa@m17n.org>
3754
3755 * composite.c (composition_compute_stop_pos): Ignore a static
3756 composition starting before CHARPOS (Bug#8915).
3757
3758 * xdisp.c (handle_composition_prop): Likewise.
3759
a8815b00
EZ
37602011-07-07 Eli Zaretskii <eliz@gnu.org>
3761
3762 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3763 (Bug#9015)
3764
ef7b981d 37652011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3766
3767 * character.h (unicode_category_t): New enum type.
3768
3769 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3770 (Qchar_code_property_table): New variable.
3771 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3772 (UNIPROP_COMPRESSED_FORM_P): New macros.
3773 (char_table_ascii): Uncompress the compressed values.
3774 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3775 Uncompress the compressed values.
ac389d0c 3776 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3777 (char_table_ref_and_range): Uncompress the compressed values.
3778 (sub_char_table_set): New arg is_uniprop. Callers changed.
3779 Uncompress the compressed values.
3780 (sub_char_table_set_range): Args changed. Callers changed.
3781 (char_table_set_range): Adjuted for the above change.
3782 (map_sub_char_table): Delete args default_val and parent. Add arg
3783 top. Give decoded values to a Lisp function.
640c8776 3784 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3785 values to a Lisp function. Gcpro more variables.
3786 (uniprop_table_uncompress)
3787 (uniprop_decode_value_run_length): New functions.
3788 (uniprop_decoder, uniprop_decoder_count): New variables.
3789 (uniprop_get_decoder, uniprop_encode_value_character)
3790 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3791 New functions.
3792 (uniprop_encoder, uniprop_encoder_count): New variables.
3793 (uniprop_get_encoder, uniprop_table)
3794 (Funicode_property_table_internal, Fget_unicode_property_internal)
3795 (Fput_unicode_property_internal): New functions.
3796 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3797 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3798 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3799 char-code-property-alist.
3800
640c8776 3801 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3802 Vunicode_category_table.
3803
640c8776 3804 * font.c (font_range): Adjust for the change of
c805dec0
KH
3805 Vunicode_category_table.
3806
76b397fb
DN
38072011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3808
3809 * m/iris4d.h: Remove file, move contents ...
3810 * s/irix6-5.h: ... here.
3811
22b4128e
PE
38122011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3815 * alloc.c (mark_buffer):
3816 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3817 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3818 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3819 This isn't true in general, and it's particularly not true
3820 if Emacs is configured with --with-wide-int.
3821 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3822 New macros, used in the buffer.c change.
3823
869795d6
JD
38242011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3825
3826 * xsettings.c: Use both GConf and GSettings if both are available.
3827 (store_config_changed_event): Add comment.
3828 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3829 (store_tool_bar_style_changed): New functions.
5e617bc2 3830 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3831 (struct xsettings): Move font inside HAVE_XFT.
3832 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3833 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3834 Move inside HAVE_XFT.
640c8776 3835 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3836 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3837 also.
3838 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3839 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3840 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3841 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3842 (parse_settings): Move check for font inside HAVE_XFT.
3843 (read_settings, apply_xft_settings): Add comment.
3844 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3845 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3846 call store_font_name_changed.
3847 (xft_settings_event): Add comment.
3848 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3849 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3850 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3851 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3852 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3853 (xsettings_get_system_font, xsettings_get_system_normal_font):
3854 Add comment.
869795d6 3855
d8ed26bd
PE
38562011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 Random fixes. E.g., (random) never returned negative values.
3859 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3860 subseconds part to the entropy, as that's a bit more random.
3861 Prefer signed to unsigned, since the signedness doesn't matter and
3862 in general we prefer signed. When given a limit, use a
3863 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3864 latter isn't right if USE_2_TAGS_FOR_INTS.
3865 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3866 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3867
cabf1cac
SM
38682011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3869
3870 * textprop.c (text_property_stickiness):
3871 Obey Vtext_property_default_nonsticky.
3872 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3873 * w32fns.c (syms_of_w32fns):
3874 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3875
6e9b2be9
PE
38762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3877
3878 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3879 This is more efficient than Ffile_directory_p and avoids a minor race.
3880
90186c68
LMI
38812011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3882
7c301272
LMI
3883 * buffer.c (Foverlay_put): Say what the return value is
3884 (bug#7835).
3885
c4f2d8d4
LMI
3886 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3887 is a directory before asking whether to use the file name
3888 (bug#7564).
ad637907
LMI
3889 (barf_or_query_if_file_exists): Make the "File is a directory"
3890 error be more correct.
c4f2d8d4 3891
90186c68
LMI
3892 * fns.c (Frequire): Remove the mention of the .gz files, since
3893 that's installation-specific, but keep the mention of
3894 `get-load-suffixes'.
3895
da64016e
PE
38962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3897
3898 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3899 Report string overflow if the output is too long.
3900
7d47b580
JB
39012011-07-04 Juanma Barranquero <lekktu@gmail.com>
3902
a555cb87
JB
3903 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3904 (syms_of_gnutls): Remove duplicate DEFSYM for
3905 Qgnutls_bootprop_verify_hostname_error, an error for
3906 Qgnutls_bootprop_verify_error (which is no longer used).
3907
7d47b580
JB
3908 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3909 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3910 Also (re)move comments that are misplaced or no longer relevant.
3911
1e49bfab
LMI
39122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3913
3914 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3915
1485f4c0
CY
39162011-07-03 Chong Yidong <cyd@stupidchicken.com>
3917
3918 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3919 and background color parameters if they have been changed.
3920
a9ab721e
LMI
39212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3922
3923 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3924
cf7cff57
PE
39252011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3926
2e13213d
PE
3927 * xsettings.c (SYSTEM_FONT): Define only when used.
3928 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3929
cf7cff57
PE
3930 * keymap.c (access_keymap_1): Now static.
3931
7a8e04f7
CY
39322011-07-02 Chong Yidong <cyd@stupidchicken.com>
3933
3934 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3935 leave any prefix arg for the up event (Bug#1586).
3936
61352f62
LMI
39372011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3938
69bb1ef7
LMI
3939 * lread.c (syms_of_lread): Mention single symbols defined by
3940 `defvar' or `defconst' (bug#7154).
3941
61352f62 3942 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3943 (Frequire): Mention get-load-suffixes.
61352f62 3944
28545e04
MR
39452011-07-02 Martin Rudalics <rudalics@gmx.at>
3946
3947 * window.h (window): Remove clone_number slot.
3948 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3949 Remove.
3950 (make_parent_window, make_window, saved_window)
3951 (Fset_window_configuration, save_window_save): Don't deal with
3952 clone numbers.
3953 * buffer.c (Qclone_number): Remove declaration.
3954 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3955
3349e122
SM
39562011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3957
3958 Add multiple inheritance to keymaps.
3959 * keymap.c (Fmake_composed_keymap): New function.
3960 (Fset_keymap_parent): Simplify.
3961 (fix_submap_inheritance): Remove.
3962 (access_keymap_1): New function extracted from access_keymap to handle
3963 embedded parents and handle lists of maps.
3964 (access_keymap): Use it.
3965 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3966 (Fcopy_keymap): Handle embedded parents.
3967 (Fcommand_remapping, define_as_prefix): Simplify.
3968 (Fkey_binding): Simplify.
3969 (syms_of_keymap): Move minibuffer-local-completion-map,
3970 minibuffer-local-filename-completion-map,
3971 minibuffer-local-must-match-map, and
3972 minibuffer-local-filename-must-match-map to Elisp.
3973 (syms_of_keymap): Defsubr make-composed-keymap.
3974 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3975 (parse_menu_item): Trivial simplification.
3976
3279eb87
GM
39772011-07-01 Glenn Morris <rgm@gnu.org>
3978
3979 * Makefile.in (SETTINGS_LIBS): Fix typo.
3980
4550efdf
KI
39812011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3982
3983 * coding.c (Fencode_coding_string): Record the last coding system
3984 used, as the function doc string says (bug#8738).
3985
0949d2b6
JD
39862011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3987
3988 * xsettings.c (store_monospaced_changed): Take new font as arg and
3989 check for change against current_mono_font.
3990 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3991 (emacs_settings_constructor, emacs_settings_get_property)
3992 (emacs_settings_set_property, emacs_settings_class_init)
3993 (emacs_settings_init, gsettings_obj): Remove.
3994 (something_changedCB): New function for HAVE_GSETTINGS.
3995 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3996 with value as argument.
3997 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3998 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3999 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4000 "changed".
4001
4002 * xgselect.c: Add defined (HAVE_GSETTINGS).
4003 (xgselect_initialize): Ditto.
4004
4005 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4006 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4007 xg_select.
4008
bbc6b304
PE
40092011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4010
4011 * eval.c (struct backtrace): Simplify and port the data structure.
4012 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4013 signed bit field, as this assumption is not portable and it makes
4014 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4015 "char debug_on_exit : 1" as this is not portable either; instead,
4016 use the portable "unsigned int debug_on_exit : 1". Remove unused
4017 member evalargs. Remove obsolete comments about cc bombing out.
4018
9851bfc5
JD
40192011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4020
51bb811f 4021 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4022 Let HAVE_GSETTINGS override HAVE_GCONF.
4023 (store_monospaced_changed): New function.
4024 (EMACS_SETTINGS): A new type derived from GObject to handle
4025 GSettings notifications.
4026 (emacs_settings_constructor, emacs_settings_get_property)
4027 (emacs_settings_set_property, emacs_settings_class_init):
4028 New functions.
4029 (gsettings_client, gsettings_obj): New variables.
4030 (GSETTINGS_SCHEMA): New define.
4031 (something_changedCB): Call store_monospaced_changed.
4032 (init_gsettings): New function.
4033 (xsettings_initialize): Call init_gsettings.
4034 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4035 to NULL.
4036
640c8776 4037 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4038 GCONF_CFLAGS/LIBS.
4039
5386012d
MR
40402011-06-29 Martin Rudalics <rudalics@gmx.at>
4041
4042 * window.c (resize_root_window, grow_mini_window)
4043 (shrink_mini_window): Rename Qresize_root_window to
4044 Qwindow_resize_root_window and Qresize_root_window_vertically to
4045 Qwindow_resize_root_window_vertically.
4046
f13e0b08
PE
40472011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4048
4049 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4050
94515237
JB
40512011-06-27 Juanma Barranquero <lekktu@gmail.com>
4052
4053 * makefile.w32-in: Redesign dependencies so they reflect more
4054 clearly which files are directly included by each source file,
4055 and not through other includes.
4056
e43b6e43
MR
40572011-06-27 Martin Rudalics <rudalics@gmx.at>
4058
4059 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4060 (sort_overlays, overlay_strings): When an overlay's clone number
4061 matches the window's clone number process the overlay even if
4062 the overlay's window property doesn't match the current window.
4063
d68443dc
MR
4064 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4065 (Fwindow_hchild): Rename to Fwindow_left_child.
4066 (Fwindow_next): Rename to Fwindow_next_sibling.
4067 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4068 (resize_window_check): Rename to window_resize_check.
4069 (resize_window_apply): Rename to window_resize_apply.
4070 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4071 (Fdelete_other_windows_internal, resize_frame_windows)
4072 (Fsplit_window_internal, Fdelete_window_internal)
4073 (grow_mini_window, shrink_mini_window)
4074 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4075
c7e73be5
JD
40762011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4077
4078 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4079 (emacs_fixed_set_min_size): Remove.
4080 (emacs_fixed_new): Take frame as argument.
4081
4082 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4083 (_EmacsFixedPrivate): Remove minwidth/height.
4084 Add struct frame *f.
4085 (emacs_fixed_init): Initialize priv->f.
4086 (get_parent_class, emacs_fixed_set_min_size): Remove.
4087 (emacs_fixed_new): Set priv->f to argument.
4088 (emacs_fixed_get_preferred_width)
4089 (emacs_fixed_get_preferred_height): Use min_width/height from
4090 frames size_hint to set minimum and natural (Bug#8919).
4091 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4092 and use min_width/height from frames size_hint to set
4093 min_width/height (Bug#8919).
4094
4095 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4096 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4097 Fix indentation.
c7e73be5 4098
cf99dcf8
EZ
40992011-06-26 Eli Zaretskii <eliz@gnu.org>
4100
4101 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4102 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4103 called at ZV.
4104
029529ac
CY
41052011-06-26 Chong Yidong <cyd@stupidchicken.com>
4106
4107 * process.c (wait_reading_process_output): Bypass select if
4108 waiting for a cell while ignoring keyboard input, and input is
4109 pending. Suggested by Jan Djärv (Bug#8869).
4110
7a7ef429
PE
41112011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 Use gnulib's dup2 module instead of rolling our own.
4114 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4115
11fdef7d 41162011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4117
4118 * dispnew.c (scrolling_window): Before scrolling, turn off a
4119 mouse-highlight in the window being scrolled.
4120
cd3520a4
JB
41212011-06-24 Juanma Barranquero <lekktu@gmail.com>
4122
4123 Move DEFSYM to lisp.h and use everywhere.
4124
4125 * character.h (DEFSYM): Move declaration...
4126 * lisp.h (DEFSYM): ...here.
4127
4128 * gnutls.c:
4129 * minibuf.c:
4130 * w32menu.c:
4131 * w32proc.c:
4132 * w32select.c: Don't include character.h.
4133
4134 * alloc.c (syms_of_alloc):
4135 * buffer.c (syms_of_buffer):
4136 * bytecode.c (syms_of_bytecode):
4137 * callint.c (syms_of_callint):
4138 * casefiddle.c (syms_of_casefiddle):
4139 * casetab.c (init_casetab_once):
4140 * category.c (init_category_once, syms_of_category):
4141 * ccl.c (syms_of_ccl):
4142 * cmds.c (syms_of_cmds):
4143 * composite.c (syms_of_composite):
4144 * dbusbind.c (syms_of_dbusbind):
4145 * dired.c (syms_of_dired):
4146 * dispnew.c (syms_of_display):
4147 * doc.c (syms_of_doc):
4148 * editfns.c (syms_of_editfns):
4149 * emacs.c (syms_of_emacs):
4150 * eval.c (syms_of_eval):
4151 * fileio.c (syms_of_fileio):
4152 * fns.c (syms_of_fns):
4153 * frame.c (syms_of_frame):
4154 * fringe.c (syms_of_fringe):
4155 * insdel.c (syms_of_insdel):
4156 * keymap.c (syms_of_keymap):
4157 * lread.c (init_obarray, syms_of_lread):
4158 * macros.c (syms_of_macros):
4159 * msdos.c (syms_of_msdos):
4160 * print.c (syms_of_print):
4161 * process.c (syms_of_process):
4162 * search.c (syms_of_search):
4163 * sound.c (syms_of_sound):
4164 * syntax.c (init_syntax_once, syms_of_syntax):
4165 * terminal.c (syms_of_terminal):
4166 * textprop.c (syms_of_textprop):
4167 * undo.c (syms_of_undo):
4168 * w32.c (globals_of_w32):
4169 * window.c (syms_of_window):
4170 * xdisp.c (syms_of_xdisp):
4171 * xfaces.c (syms_of_xfaces):
4172 * xfns.c (syms_of_xfns):
4173 * xmenu.c (syms_of_xmenu):
4174 * xsettings.c (syms_of_xsettings):
4175 * xterm.c (syms_of_xterm): Use DEFSYM.
4176
4228cf16
TZ
41772011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4178
cd3520a4 4179 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4180
7fcccf1e
PE
41812011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4182
7efb4e0e
PE
4183 Integer and buffer overflow fixes (Bug#8873).
4184
ff5844ad
PE
4185 * print.c (printchar, strout): Check for string overflow.
4186 (PRINTPREPARE, printchar, strout):
4187 Don't set size unless allocation succeeds.
4188
90532f02
PE
4189 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4190 for sizes. Check for string overflow more accurately.
4191 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4192
6d84508d
PE
4193 * macros.c: Integer and buffer overflow fixes.
4194 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4195 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4196 Use ptrdiff_t, not int, for sizes.
4197 Don't increment bufsize until after realloc succeeds.
4198 Check for size-calculation overflow.
4199 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4200
437b2cb4
PE
4201 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4202
8b9ac8b4
PE
4203 * lread.c: Integer overflow fixes.
4204 (read_integer): Radix is now EMACS_INT, not int,
4205 to improve quality of diagnostics for out-of-range radices.
4206 Calculate buffer size correctly for out-of-range radices.
4207 (read1): Check for integer overflow in radices, and in
4208 read-circle numbers.
82cb60d3
PE
4209 (read_escape): Avoid int overflow.
4210 (Fload, openp, read_buffer_size, read1)
4211 (substitute_object_recurse, read_vector, read_list, map_obarray):
4212 Use ptrdiff_t, not int, for sizes.
4213 (read1): Use EMACS_INT, not int, for sizes.
20270765 4214 Check for size overflow.
8b9ac8b4 4215
7fcccf1e
PE
4216 * image.c (cache_image): Check for size arithmetic overflow.
4217
bfbbd7e7
PE
4218 * lread.c: Integer overflow issues.
4219 (saved_doc_string_size, saved_doc_string_length)
4220 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4221 Now ptrdiff_t, not int.
4222 (read1): Don't assume doc string length fits in int. Check for
4223 out-of-range doc string lengths.
4224 (read_list): Don't assume file position fits in int.
39019e54 4225 (read_escape): Check for hex character overflow.
bfbbd7e7 4226
4e323265
LL
42272011-06-22 Leo Liu <sdl.web@gmail.com>
4228
4229 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4230 Move to minibuffer.el.
4231
85fece3e
PE
42322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4233
20b84ce9 4234 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4235 The following patches are for when GLYPH_DEBUG && !XASSERT.
4236 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4237 * dispnew.c (flush_stdout):
4238 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4239 Mark as externally visible.
4240 * dispnew.c (check_window_matrix_pointers): Now static.
4241 * dispnew.c (window_to_frame_vpos):
4242 * xfns.c (unwind_create_frame):
4243 * xterm.c (x_check_font): Remove unused local.
4244 * scroll.c (CHECK_BOUNDS):
4245 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4246 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4247 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4248 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4249 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4250 Now static.
4251 (debug_method_add): Use va_list and vsprintf rather than relying
4252 on undefined behavior with wrong number of arguments.
4253 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4254 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4255 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4256 since we're not interested in debugging glyphs with old libraries.
4257 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4258 GCC 4.6.0's static checking.
4259
0766b489
PE
42602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4261
31fd4b32
PE
4262 Integer overflow and signedness fixes (Bug#8873).
4263 A few related buffer overrun fixes, too.
4264
b79e8648
PE
4265 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4266
0766b489
PE
4267 * dispextern.h (struct face.stipple):
4268 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4269 (x_bitmap_mask, x_allocate_bitmap_record)
4270 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4271 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4272 (x_create_bitmap_from_xpm_data):
4273 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4274 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4275 (.bitmaps_last):
4276 * xfaces.c (load_pixmap):
4277 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4278 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4279 (.bitmaps_last, struct x_output.icon_bitmap):
4280 Use ptrdiff_t, not int, for bitmap indexes.
4281 (x_allocate_bitmap_record): Check for size overflow.
4282 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4283
b081724f
PE
4284 Use ptrdiff_t, not int, for overlay counts.
4285 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4286 * editfns.c (overlays_around, get_pos_property):
4287 * textprop.c (get_char_property_and_overlay):
4288 * xdisp.c (next_overlay_change, note_mouse_highlight):
4289 * xfaces.c (face_at_buffer_position):
21514da7
PE
4290 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4291 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4292 (Fnext_overlay_change, Fprevious_overlay_change)
4293 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4294 Use ptrdiff_t, not int, for sizes.
21514da7 4295 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4296
3de73e5e
PE
4297 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4298
2606c57b
PE
4299 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4300 (x_session_initialize): Do not assume string length fits in int.
4301
aaafe47a
PE
4302 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4303 This is unlikely, but can occur if DPI is outlandish.
4304
2674ddc8 4305 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4306 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4307
28154962
PE
4308 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4309 * xrdb.c (magic_file_p, search_magic_path):
4310 Omit last arg SUFFIX; it was always 0. All callers changed.
4311 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4312
7de51af5
PE
4313 * xfont.c (xfont_match): Avoid need for strlen.
4314
25ed6cc3
PE
4315 * xfns.c: Don't assume strlen fits in int.
4316 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4317
4eab31dd
PE
4318 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4319 not unsigned long, as we prefer signed integers. All callers changed.
4320 Detect integer overflow in repeat count.
4321 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4322 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4323
171e2a58
PE
4324 * termcap.c: Don't assume sizes fit in int and never overflow.
4325 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4326 (gobble_line): Check for size-calculation overflow.
4327
ad39faca 4328 * minibuf.c (Fread_buffer):
6e5bb2dc 4329 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4330 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4331 Don't assume string length fits in int.
4332
52c61c22 4333 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4334 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4335
b5b8c9e5
PE
4336 * font.c: Don't assume string length fits in int.
4337 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4338 Use ptrdiff_t, not int.
ccd6111c
PE
4339 (font_intern_prop): Don't assume string length fits in int.
4340 Don't assume integer property fits in fixnum.
4341 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4342
882f0d81 4343 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4344 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4345 Reformulate so as not to need the command string.
4346 Invoke gzip -cd rather than gunzip, as it's more portable.
4347 (lock_info_type, lock_file_1, lock_file):
4348 Don't assume pid_t and time_t fit in unsigned long.
4349 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4350 (current_lock_owner): Prefer signed type for sizes.
4351 Use memcpy, not strncpy, where memcpy is what is really wanted.
4352 Don't assume (via atoi) that time_t and pid_t fit in int.
4353 Check for time_t and/or pid_t out of range, e.g., via a network share.
4354 Don't alloca where an auto var works fine.
4355
93f4cf88
PE
4356 * fileio.c: Fix some integer overflow issues.
4357 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4358 Don't assume string length fits in int.
4359 (directory_file_name): Don't assume string length fits in long.
4360 (make_temp_name): Don't assume pid fits in int, or that its print
4361 length is less than 20.
4362
f3e92b69
PE
4363 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4364
1bfdaf10
PE
4365 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4366
35016e9a
PE
4367 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4368
3d1e65a1
PE
4369 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4370 We prefer signed integers, even for size calculations.
4371
0b963a93
PE
4372 * emacs.c: Don't assume string length fits in 'int'.
4373 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4374 (main): Don't invoke strlen when not needed.
4375
573f4b54
PE
4376 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4377 (XD_DEBUG_MESSAGE): Don't waste a byte.
4378
989f33ba
PE
4379 * callproc.c (getenv_internal_1, getenv_internal)
4380 (Fgetenv_internal):
965d34eb
PE
4381 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4382
e4d29b33
PE
4383 * lread.c (invalid_syntax): Omit length argument.
4384 All uses changed. This doesn't fix a bug, but it simplifies the
4385 code away from its former Hollerith-constant appearance, and it's
4386 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4387 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4388
eb49b136
PE
4389 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4390 This didn't break anything, but it didn't help either.
4391 It's confusing to put a bogus integer in a place where the actual
4392 value does not matter.
9f62aeb1 4393 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4394 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4395
15375a22
PE
4396 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4397 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4398 implementation.
b61cc01c
PE
4399 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4400 We prefer signed types, and the value cannot exceed the EMACS_INT
4401 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4402 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4403 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4404 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4405
53b2623d
PE
4406 * indent.c (sane_tab_width): New function.
4407 (current_column, scan_for_column, Findent_to, position_indentation)
4408 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4409 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4410
51cab52b 4411 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4412
f2ed8a70
PE
4413 * lisp.h (lint_assume): New macro.
4414 * composite.c (composition_gstring_put_cache):
4415 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4416
abe80cc6
PE
4417 * editfns.c, insdel.c:
4418 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4419
b02c740e
PE
4420 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4421
ebc96716
PE
4422 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4423
b4e50fa0 4424 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4425 Use much-faster test for byte-length change.
311d5d7c 4426 Don't assume string byte-length fits in 'int'.
a4cf38e4 4427 Check that character arg fits in 'int'.
85461888 4428 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4429
c0c1ee9f
PE
4430 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4431
a498d7f4
PE
4432 * fns.c (concat): Catch string overflow earlier.
4433 Do not rely on integer wraparound.
4434
51cab52b
PE
4435 * dispextern.h (struct it.overlay_strings_charpos)
4436 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4437 * xdisp.c (forward_to_next_line_start)
4438 (back_to_previous_visible_line_start)
4439 (reseat_at_next_visible_line_start, next_element_from_buffer):
4440 Don't arbitrarily truncate the value of 'selective' to int.
4441
76031fad
PE
4442 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4443
5eb55db9
PE
4444 * composite.c: Don't truncate sizes to 'int'.
4445 (composition_gstring_p, composition_reseat_it)
4446 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4447 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4448 not EMACS_UINT, for indexes.
5eb55db9 4449
0703a717
PE
4450 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4451
d6202519
PE
4452 * buffer.c: Include <verify.h>.
4453 (struct sortvec.priority, struct sortstr.priority):
8961a454 4454 Now EMACS_INT, not int.
c20998a7 4455 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4456 (struct sortstr.size, record_overlay_string)
4457 (struct sortstrlist.size, struct sortlist.used):
4458 Don't truncate size to int.
4459 (record_overlay_string): Check for size-calculation overflow.
d6202519 4460 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4461
d5a19415
JM
44622011-06-22 Jim Meyering <meyering@redhat.com>
4463
029529ac 4464 Don't leak an XBM-image-sized buffer
d5a19415
JM
4465 * image.c (xbm_load): Free the image buffer after using it.
4466
a9041e6c
PE
44672011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4468
4469 Port to Sun C.
4470 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4471 that Sun C diagnosed.
4472 * fns.c (secure_hash): Fix pointer signedness issue.
4473 * intervals.c (static_offset_intervals): New function.
4474 (offset_intervals): Use it.
4475
7f3f739f
LL
44762011-06-21 Leo Liu <sdl.web@gmail.com>
4477
4478 * deps.mk (fns.o):
4479 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4480 sha512.h.
4481
4482 * fns.c (secure_hash): Rename from crypto_hash_function and change
4483 the first arg to accept symbols.
5b66d427 4484 (Fsecure_hash): New primitive.
7f3f739f
LL
4485 (syms_of_fns): New symbols.
4486
76147d94
DD
44872011-06-20 Deniz Dogan <deniz@dogan.se>
4488
4489 * process.c (Fset_process_buffer): Clarify return value in
4490 docstring.
4491
7d7d0045
CY
44922011-06-18 Chong Yidong <cyd@stupidchicken.com>
4493
4494 * dispnew.c (add_window_display_history): Use BVAR.
4495
4496 * xdisp.c (debug_method_add): Use BVAR.
4497 (check_window_end, dump_glyph_matrix, dump_glyph)
4498 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4499
4500 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4501 Likewise.
4502
4503 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4504 check till after the cache is created in init_frame_faces.
4505
ff2bc410
SM
45062011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4507
4508 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4509
28177add
PE
45102011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4511
dd3482fe
PE
4512 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4513 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4514 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4515
393d71f3 4516 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4517 * fileio.c (Finsert_file_contents):
4518 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4519 Remove the old (too-loose) buffer overflow checks.
4520 They weren't needed, since make_gap checks for buffer overflow.
4521 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4522 The old code merely checked for Emacs fixnum overflow, and relied
4523 on undefined (wraparound) behavior. The new code avoids undefined
4524 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4525
2e6813b0 4526 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4527 Tune. Don't use wider integers than needed. Don't use alloca.
4528 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4529
599a9e4f
PE
4530 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4531
99561444
PE
4532 * insdel.c, lisp.h (buffer_overflow): New function.
4533 (insert_from_buffer_1, replace_range, replace_range_2):
4534 * insdel.c (make_gap_larger):
4535 * editfns.c (Finsert_char):
4536 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4537
28177add
PE
4538 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4539
e69dafad
PE
45402011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4541
4baa020d 4542 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4543
b1c46f02
PE
4544 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4545 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4546
e69dafad
PE
4547 * fileio.c: Don't assume EMACS_INT fits in off_t.
4548 (emacs_lseek): New static function.
4549 (Finsert_file_contents, Fwrite_region): Use it.
4550 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4551
566684ea
PE
4552 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4553
e6966cd6
PE
4554 * fns.c: Don't overflow int when computing a list length.
4555 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4556 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4557 truncation on 64-bit hosts. Check for QUIT every
4558 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4559 faster and is responsive enough.
4560 (Flength): Report an error instead of overflowing an integer.
4561 (Fsafe_length): Return a float if the value is not representable
4562 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4563 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4564 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4565
dd0b0efb
PE
4566 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4567 (header_size, word_size): New constants.
4568 (allocate_vectorlike): Don't check size overflow here.
4569 (allocate_vector): Check it here instead, since this is the only
4570 caller of allocate_vectorlike that could cause overflow.
4571 Check that the new vector's length is representable as a fixnum.
4572
86fe5cfe
PE
4573 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4574 The previous code was bogus. For example, next_almost_prime (32)
4575 returned 39, which is undesirable as it is a multiple of 3; and
4576 next_almost_prime (24) returned 25, which is a multiple of 5 so
4577 why was the code bothering to check for multiples of 7?
4578
80e88859
PE
4579 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4580
4a2f0ad6
PE
4581 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4582
f66c7cf8
PE
4583 Variadic C functions now count arguments with ptrdiff_t.
4584 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4585 Back then I didn't know that the Emacs coding style prefers signed int.
4586 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4587 were being counted with int, which may truncate counts on 64-bit
4588 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4589 * lisp.h (struct Lisp_Subr.function.aMANY)
4590 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4591 Arg counts are now ptrdiff_t, not size_t.
4592 All variadic functions and their callers changed accordingly.
4593 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4594 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4595 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4596 * callint.c (Fcall_interactively): Check arg count for overflow,
4597 to avoid potential buffer overrun. Use signed char, not 'int',
4598 for 'varies' array, so that we needn't bother to check its size
4599 calculation for overflow.
4600 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4601 * eval.c (apply_lambda):
4602 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4603 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4604 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4605
a1759b76
PE
4606 * callint.c (Fcall_interactively): Don't use index var as event count.
4607
d96be9fc
PE
4608 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4609 * mem-limits.h (SIZE): Remove; no longer used.
4610
a690a978 4611 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4612
578c21e6
PE
4613 Remove unnecessary casts.
4614 * xterm.c (x_term_init):
4615 * xfns.c (x_set_border_pixel):
4616 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4617 These aren't needed now that we assume ANSI C.
4618
96f53c6c
PE
4619 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4620 It's more likely to cause problems (due to unsigned overflow)
4621 than to cure them.
4622
83c77d31
PE
4623 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4624
ee2079f1
PE
4625 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4626
6da65536
PE
4627 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4628
7147c4a4
PE
4629 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4630
193e32d9
PE
4631 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4632
e5533da6
PE
4633 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4634
9910e595
PE
4635 GLYPH_CODE_FACE returns EMACS_INT, not int.
4636 * dispextern.h (merge_faces):
4637 * xfaces.c (merge_faces):
01103c44
PE
4638 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4639 Don't assume EMACS_INT fits in int.
9910e595 4640
2638320e
PE
4641 * character.h (CHAR_VALID_P): Remove unused parameter.
4642 * fontset.c, lisp.h, xdisp.c: All uses changed.
4643
045eb8d9
PE
4644 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4645
c1f134b5
PE
4646 * fns.c (concat): Minor tuning based on overflow analysis.
4647 This doesn't fix any bugs. Use int to hold character, instead
4648 of constantly refetching from Emacs object. Use XFASTINT, not
4649 XINT, for value known to be a character. Don't bother comparing
4650 a single byte to 0400, as it's always less.
4651
395fcb93 4652 * floatfns.c (Fexpt):
327eeec8
PE
4653 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4654
abbd3d23
PE
4655 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4656 for characters.
4657
684a03ef
PE
4658 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4659
0fed43f3
PE
4660 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4661 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4662 incorrectly succeed when S was a string, because 4294967386 was
4663 truncated before it was used.
4664
8fd02eb7
PE
4665 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4666 Otherwise, an out-of-range integer could cause undefined behavior
4667 on a 64-bit host.
4668
f8c86b69
PE
4669 * composite.c: Use int, not EMACS_INT, for characters.
4670 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4671 EMACS_INT, for values that are known to be in character range.
4672 This doesn't fix any bugs but is the usual style inside Emacs and
4673 may generate better code on 32-bit machines.
4674
34206dd2
PE
4675 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4676 This is for reasons similar to the recent CHAR_STRING fix.
4677 * charset.c (Fencode_char): Check that character arg is actually
4678 a character. Pass an int to ENCODE_CHAR.
4679 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4680 wider than 'int', as a compile-time check to prevent future regressions
4681 in this area.
4682
c5958d4c 4683 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4684
4685 Make sure a 64-bit char is never passed to CHAR_STRING.
4686 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4687 by silently ignoring the top 32 bits, allowing some values
4688 that were far too large to be valid characters.
4689 * character.h: Include <verify.h>.
4690 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4691 arguments are no wider than unsigned, as a compile-time check
4692 to prevent future regressions in this area.
4693 * data.c (Faset):
01103c44 4694 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4695 (Fsubst_char_in_region):
4696 * fns.c (concat):
4697 * xdisp.c (decode_mode_spec_coding):
4698 Adjust to CHAR_STRING's new requirement.
4699 * editfns.c (Finsert_char, Fsubst_char_in_region):
4700 * fns.c (concat): Check that character args are actually
4701 characters. Without this test, these functions did the wrong
4702 thing with wildly out-of-range values on 64-bit hosts.
4703
d37ca623
PE
4704 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4705 These casts should not be needed on 32-bit hosts, either.
4706 * keyboard.c (read_char):
4707 * lread.c (Fload): Remove casts to unsigned.
4708
ea204efb
PE
4709 * lisp.h (UNSIGNED_CMP): New macro.
4710 This fixes comparison bugs on 64-bit hosts.
4711 (ASCII_CHAR_P): Use it.
4712 * casefiddle.c (casify_object):
01103c44 4713 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4714 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4715 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4716 * dispextern.h (FACE_FROM_ID):
4717 * keyboard.c (read_char): Use UNSIGNED_CMP.
4718
41cb286c
PE
4719 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4720 not to EMACS_INT, to avoid GCC warning.
4721
4a1b9832
PE
4722 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4723
55daad71
PE
4724 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4725 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4726 isn't needed on 32-bit machines.
8f95c75c 4727
01103c44
PE
4728 * buffer.c (Fgenerate_new_buffer_name):
4729 Use EMACS_INT for count, not int.
0ceccced 4730 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4731
4732 * data.c (Qcompiled_function): Now static.
4733
c6f072e7
PE
4734 * window.c (window_body_lines): Now static.
4735
20ce5912
PE
4736 * image.c (gif_load): Rename local to avoid shadowing.
4737
9c4c5f81
PE
4738 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4739 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4740 * alloc.c (make_save_value): Integer argument is now of type
4741 ptrdiff_t, not int.
4742 (mark_object): Use ptrdiff_t, not int.
4743 * lisp.h (pD): New macro.
4744 * print.c (print_object): Use it.
4745
c0c5c8ae
PE
4746 * alloc.c: Use EMACS_INT, not int, to count objects.
4747 (total_conses, total_markers, total_symbols, total_vector_size)
4748 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4749 (total_free_floats, total_floats, total_free_intervals)
4750 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4751 Now EMACS_INT, not int. All uses changed.
4752 (Fgarbage_collect): Compute overall total using a double, so that
4753 integer overflow is less likely to be a problem. Check for overflow
4754 when converting back to an integer.
5a25e253
PE
4755 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4756 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4757 These were 'int' variables that could overflow on 64-bit hosts;
4758 they were never used, so remove them instead of repairing them.
211a0b2a 4759 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4760 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4761 Previously, this ceilinged at INT_MAX, but that doesn't work on
4762 64-bit machines.
e46bb31a 4763 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4764
c78baabf 4765 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4766 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4767 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4768 when a (possibly-narrower) signed value would do just as well.
4769 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4770
c9d624c6
PE
4771 * alloc.c: Catch some string size overflows that we were missing.
4772 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4773 for convenience in STRING_BYTES_MAX.
4774 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4775 The definition here is exact; the one in lisp.h was approximate.
4776 (allocate_string_data): Check for string overflow. This catches
4777 some instances we weren't catching before. Also, it catches
4778 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4779 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4780 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4781
c9d624c6
PE
4782 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4783 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4784 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4785
353032ce
PE
4786 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4787
2bccce07
PE
4788 * alloc.c (Fmake_string): Check for out-of-range init.
4789
0ac30604
SM
47902011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4791
4792 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4793
c195f2de
JD
47942011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4795
4796 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4797 xg_get_default_scrollbar_width.
4798
4799 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4800 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4801 (style_changed_cb): Call update_theme_scrollbar_width and call
4802 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4803 all frames (Bug#8505).
4804 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4805 Call gtk_window_set_resizable if HAVE_GTK3.
4806 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4807 and height if HAVE_GTK3 (Bug#8505).
4808 (scroll_bar_width_for_theme): New variable.
4809 (update_theme_scrollbar_width): New function.
4810 (xg_get_default_scrollbar_width): Move code to
4811 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4812 (xg_initialize): Call update_theme_scrollbar_width.
4813
4814 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4815
4816 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4817
e10ac9f1
MR
48182011-06-12 Martin Rudalics <rudalics@gmx.at>
4819
4820 * frame.c (make_frame): Call other_buffer_safely instead of
4821 other_buffer.
4822
4823 * window.c (temp_output_buffer_show): Call display_buffer with
4824 second argument Vtemp_buffer_show_specifiers and reset latter
4825 immediately after the call.
4826 (Vtemp_buffer_show_specifiers): New variable.
4827 (auto_window_vscroll_p, next_screen_context_lines)
4828 (Vscroll_preserve_screen_position): Remove leading asterisks from
4829 doc-strings.
4830
2d3c217e 48312011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4832
7b7f97e8 4833 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4834 * buffer.c (Qclone_number): Remove for now, as it's unused.
4835 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4836 (record_buffer): Remove unused local.
4837 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4838 (set_frame_buffer_list): Remove; unused.
4839 * frame.h (other_visible_frames): Remove decl.
4840 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4841 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4842 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4843 if HAVE_GPM.
4844 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4845 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4846 Define only if HAVE_GPM.
4847 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4848 (update_hints_inhibit): Remove; never set. All uses removed.
4849 * widgetprv.h (emacsFrameClassRec): Remove decl.
4850 * window.c (delete_deletable_window): Now returns void, since it
4851 wasn't returning anything.
4852 (compare_window_configurations): Remove unused locals.
4853 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4854 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4855 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4856 the same widths as pointers. This follows up on the 2011-05-06 patch.
4857 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4858 * xterm.h: Likewise.
4859 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4860
1384b89e
JB
48612011-06-12 Juanma Barranquero <lekktu@gmail.com>
4862
4863 * makefile.w32-in: Update dependencies.
4864 (LISP_H): Add lib/intprops.h.
4865
1100a63c
CY
48662011-06-11 Chong Yidong <cyd@stupidchicken.com>
4867
4868 * image.c (gif_load): Add animation frame delay to the metadata.
4869 (syms_of_image): Use DEFSYM. New symbol `delay'.
4870
6198ccd0
MR
48712011-06-11 Martin Rudalics <rudalics@gmx.at>
4872
4873 * window.c (delete_deletable_window): Re-add.
4874 (Fset_window_configuration): Rewrite to handle dead buffers and
4875 consequently deletable windows.
4876 (window_tree, Fwindow_tree): Remove. Supply functionality in
4877 window.el.
4878 (compare_window_configurations): Simplify code.
4879
b6e3633c
AS
48802011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4881
1ab0dee5
AS
4882 * image.c (imagemagick_load_image): Fix type mismatch.
4883 (Fimagemagick_types): Likewise.
4884
b6e3633c
AS
4885 * window.h (replace_buffer_in_windows): Declare.
4886
9397e56f
MR
48872011-06-11 Martin Rudalics <rudalics@gmx.at>
4888
4889 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4890 Qclone_number. Remove external declaration of Qdelete_window.
4891 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4892 code.
640c8776
SM
4893 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4894 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4895 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4896 buffer list implementation.
4897 (other_buffer_safely): New function.
4898 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4899 calls to replace_buffer_in_windows and
4900 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4901 if allowed.
4902 (record_buffer): Inhibit quitting and rewrite using quittable
4903 functions. Run Qbuffer_list_update_hook if allowed.
4904 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4905 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4906 Move switch-to-buffer to window.el.
9397e56f
MR
4907 (bury-buffer): Move to window.el.
4908 (Vbuffer_list_update_hook): New variable.
4909
4910 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4911 section.
4912
4913 * window.h (resize_frame_windows): Move up in code.
4914 (Fwindow_frame): Remove EXFUN.
4915 (replace_buffer_in_all_windows): Remove prototype.
4916 (replace_buffer_in_windows_safely): Add prototype.
4917
4918 * window.c: Declare Qdelete_window static again. Move down
4919 declaration of select_count.
4920 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4921 (Fother_window): Move to window.el.
4922 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4923 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4924 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4925 window.el.
4926 (replace_buffer_in_windows): Implement by calling
4927 Qreplace_buffer_in_windows.
4928 (replace_buffer_in_all_windows): Remove with some functionality
4929 moved into replace_buffer_in_windows_safely.
4930 (replace_buffer_in_windows_safely): New function.
4931 (select_window_norecord, select_frame_norecord): Move in front
4932 of run_window_configuration_change_hook. Remove now obsolete
4933 declarations.
640c8776
SM
4934 (Fset_window_buffer): Rewrite doc-string.
4935 Call Qrecord_window_buffer.
9397e56f
MR
4936 (keys_of_window): Move binding for other-window to window.el.
4937
b50691aa
CY
49382011-06-11 Chong Yidong <cyd@stupidchicken.com>
4939
4940 * dispextern.h (struct image): Replace data member, whose int_val
4941 and ptr_val fields were not used by anything, with a single
4942 lisp_val object.
4943
4944 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4945 (gif_clear_image, gif_load, imagemagick_load_image)
4946 (gs_clear_image, gs_load): Callers changed.
4947
3f754b86
PE
49482011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4949
cca69397
PE
4950 * buffer.h: Include <time.h>, for time_t.
4951 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4952
109e28d0
PE
4953 Fix minor problems found by static checking.
4954
60737f02
PE
4955 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4956
4b66faf3
PE
4957 Make identifiers static if they are not used in other modules.
4958 * data.c (Qcompiled_function, Qframe, Qvector):
4959 * image.c (QimageMagick, Qsvg):
4960 * minibuf.c (Qmetadata):
4961 * window.c (resize_window_check, resize_root_window): Now static.
4962 * window.h (resize_window_check, resize_root_window): Remove decls.
4963
109e28d0
PE
4964 * window.c (window_deletion_count, delete_deletable_window):
4965 Remove; unused.
46a4ce9e
PE
4966 (window_body_lines): Now static.
4967 (Fdelete_other_windows_internal): Mark vars as initialized.
4968 Make sure 'resize_failed' is initialized.
4969 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4970 (resize_window_apply): Remove unused local.
4971 * window.h (delete_deletable_window): Remove decl.
4972
109e28d0 4973 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4974 (imagemagick_load_image): Fix pointer signedness problem by changing
4975 last arg from unsigned char * to char *. All uses changed.
4976 Also, fix a local for similar reasons.
4977 Remove unused locals. Remove locals to avoid shadowing.
4978 (fn_rsvg_handle_free): Remove; unused.
4979 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4980 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4981
3f754b86
PE
4982 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4983
2547adb1
CY
49842011-06-10 Chong Yidong <cyd@stupidchicken.com>
4985
4986 * image.c (gif_load): Fix omitted cast error introduced by
4987 2011-06-06 change.
4988
2c8e37d4
MR
49892011-06-10 Martin Rudalics <rudalics@gmx.at>
4990
4991 * window.h (resize_proportionally, orig_total_lines)
4992 (orig_top_line): Remove from window structure.
4993 (set_window_height, set_window_width, change_window_heights)
4994 (Fdelete_window): Remove prototypes.
4995 (resize_frame_windows): Remove duplicate declaration.
4996
440a42e3
EZ
49972011-06-10 Eli Zaretskii <eliz@gnu.org>
4998
4999 * window.h (resize_frame_windows, resize_window_check)
5000 (delete_deletable_window, resize_root_window)
5001 (resize_frame_windows): Declare prototypes.
5002
5003 * window.c (resize_window_apply): Make definition be "static" to
5004 match the prototype.
5005
562dd5e9
MR
50062011-06-10 Martin Rudalics <rudalics@gmx.at>
5007
5008 * window.c: Remove declarations of Qwindow_size_fixed,
5009 window_min_size_1, window_min_size_2, window_min_size,
5010 size_window, window_fixed_size_p, enlarge_window, delete_window.
5011 Remove static from declaration of Qdelete_window, it's
5012 temporarily needed by Fbury_buffer.
5013 (replace_window): Don't assign orig_top_line and
5014 orig_total_lines.
5015 (Fdelete_window, delete_window): Remove. Window deletion is
5016 handled by window.el.
640c8776
SM
5017 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5018 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5019 (Fdelete_other_windows): Remove. Deleting other windows is
5020 handled by window.el.
5021 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5022 handled in window.el.
5023 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5024 Window minimum sizes are handled in window.el.
5025 (shrink_windows, size_window, set_window_height)
5026 (set_window_width, change_window_heights, window_height)
5027 (window_width, CURBEG, CURSIZE, enlarge_window)
5028 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5029 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5030 handled in window.el.
5031 (make_dummy_parent): Rename to make_parent_window and give it a
5032 second argument horflag.
5033 (make_window): Don't set resize_proportionally any more.
5034 (Fsplit_window): Remove. Windows are split in window.el.
5035 (save_restore_action, save_restore_orig_size)
5036 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5037 Resize mini windows in window.el.
5038 (grow_mini_window, shrink_mini_window): Implement by calling
5039 Qresize_root_window_vertically, resize_window_check and
5040 resize_window_apply.
640c8776
SM
5041 (saved_window, Fset_window_configuration, save_window_save):
5042 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5043 resize_proportionally.
5044 (window_min_height, window_min_width): Move to window.el.
5045 (keys_of_window): Move bindings for delete-other-windows,
5046 split-window, delete-window and enlarge-window to window.el.
5047
5048 * buffer.c: Temporarily extern Qdelete_window.
5049 (Fbury_buffer): Temporarily call Qdelete_window instead of
5050 Fdelete_window (Fbury_buffer will move to window.el soon).
5051
5052 * frame.c (set_menu_bar_lines_1): Remove code handling
5053 orig_top_line and orig_total_lines.
5054
5055 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5056 set_window_height but set heights directly.
5057 (change_frame_size_1): Use resize_frame_windows.
5058
5059 * xdisp.c (init_xdisp): Don't use set_window_height but set
5060 heights directly.
5061
640c8776
SM
5062 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5063 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5064 run_window_configuration_change_hook.
5065
5066 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5067 instead of change_window_heights and run
5068 run_window_configuration_change_hook.
5069
1a13852e
MR
50702011-06-09 Martin Rudalics <rudalics@gmx.at>
5071
5072 * window.c (replace_window): Rename second argument REPLACEMENT to
5073 NEW. New third argument SETFLAG. Rewrite.
5074 (delete_window, make_dummy_parent): Call replace_window with
5075 third argument 1.
5076 (window_list_1): Move down in code.
5077 (run_window_configuration_change_hook): Move set_buffer part
5078 before select_frame_norecord part in order to unwind correctly.
5079 Rename count1 to count.
5080 (recombine_windows, delete_deletable_window, resize_root_window)
5081 (Fdelete_other_windows_internal)
5082 (Frun_window_configuration_change_hook, make_parent_window)
5083 (resize_window_check, resize_window_apply, Fresize_window_apply)
5084 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5085 (Fdelete_window_internal, Fresize_mini_window_internal):
5086 New functions.
1a13852e
MR
5087 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5088
f3d1777e
MR
50892011-06-08 Martin Rudalics <rudalics@gmx.at>
5090
496e208e
MR
5091 * window.h (window): Add some new members to window structure -
5092 normal_lines, normal_cols, new_total, new_normal, clone_number,
5093 splits, nest, prev_buffers, next_buffers.
5094 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5095 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5096
f3d1777e
MR
5097 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5098 Remove.
496e208e
MR
5099 (make_dummy_parent): Set new members of windows structure.
5100 (make_window): Move down in code. Handle new members of window
5101 structure.
5102 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5103 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5104 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5105 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5106 (Fset_window_next_buffers, Fset_window_clone_number):
5107 New functions.
496e208e
MR
5108 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5109 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5110 Doc-string fixes.
5111 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5112 Argument WINDOW can be now internal window too.
5113 (Fwindow_use_time): Move up in code.
5114 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5115 Rewrite doc-string.
5116 (Fset_window_configuration, saved_window)
5117 (Fcurrent_window_configuration, save_window_save): Handle new
5118 members of window structure.
b9e809c2
MR
5119 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5120 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5121 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5122 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5123 Qget_mru_window, Qresize_root_window,
5124 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5125 Qauto_buffer_name; staticpro them.
f3d1777e 5126
abde8f8c
MR
51272011-06-07 Martin Rudalics <rudalics@gmx.at>
5128
5129 * window.c (Fwindow_total_size, Fwindow_left_column)
5130 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5131 (Fwindow_list_1): New functions.
5132 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5133 (Fwindow_width, Fscroll_left, Fscroll_right):
5134 Use window_body_cols instead of window_box_text_cols.
5135 (delete_window, Fset_window_configuration):
5136 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5137 (delete_all_subwindows): Take a window as argument and not a
5138 structure. Rewrite.
190b47e6
MR
5139 (window_loop): Remove handling of GET_LRU_WINDOW and
5140 GET_LARGEST_WINDOW.
5141 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5142
5143 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5144 window_box_text_cols. delete_all_subwindows now takes a
5145 Lisp_Object as argument.
abde8f8c 5146
640c8776
SM
5147 * indent.c (compute_motion, Fcompute_motion):
5148 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5149
fa8a67e6
MR
5150 * frame.c (delete_frame): Call delete_all_subwindows with root
5151 window as argument.
5152
a54e3482
DC
51532011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5154
5155 * fns.c (Fputhash): Document return value.
5156
60002bf5
CY
51572011-06-06 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5160
0c671da6 51612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5162
b862a52a 5163 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5164
be44ca6c
PE
5165 Check for overflow when converting integer to cons and back.
5166 * charset.c (Fdefine_charset_internal, Fdecode_char):
5167 Use cons_to_unsigned to catch overflow.
5168 (Fencode_char): Use INTEGER_TO_CONS.
5169 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5170 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5171 * data.c (long_to_cons, cons_to_long): Remove.
5172 (cons_to_unsigned, cons_to_signed): New functions.
5173 These signal an error for invalid or out-of-range values.
5174 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5175 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5176 * font.c (Ffont_variation_glyphs):
5177 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5178 * lisp.h: Include <intprops.h>.
5179 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5180 (cons_to_signed, cons_to_unsigned): New decls.
5181 (long_to_cons, cons_to_long): Remove decls.
5182 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5183 (Fprimitive_undo): Use CONS_TO_INTEGER.
5184 * xfns.c (Fx_window_property): Likewise.
5185 * xselect.c: Include <limits.h>.
5186 (x_own_selection, selection_data_to_lisp_data):
5187 Use INTEGER_TO_CONS.
5188 (x_handle_selection_request, x_handle_selection_clear)
5189 (x_get_foreign_selection, Fx_disown_selection_internal)
5190 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5191 (lisp_data_to_selection_data): Use cons_to_unsigned.
5192 (x_fill_property_data): Use cons_to_signed.
5193 Report values out of range.
5194
d1f3d2af
PE
5195 Check for buffer and string overflow more precisely.
5196 * buffer.h (BUF_BYTES_MAX): New macro.
5197 * lisp.h (STRING_BYTES_MAX): New macro.
5198 * alloc.c (Fmake_string):
5199 * character.c (string_escape_byte8):
5200 * coding.c (coding_alloc_by_realloc):
5201 * doprnt.c (doprnt):
5202 * editfns.c (Fformat):
5203 * eval.c (verror):
5204 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5205 since they may not be the same number.
5206 * editfns.c (Finsert_char):
5207 * fileio.c (Finsert_file_contents):
5208 Likewise for BUF_BYTES_MAX.
5209
dd52fcea
PE
5210 * image.c: Use ptrdiff_t, not int, for sizes.
5211 (slurp_file): Switch from int to ptrdiff_t.
5212 All uses changed.
5213 (slurp_file): Check that file size fits in both size_t (for
5214 malloc) and ptrdiff_t (for sanity and safety).
5215
7f9bbdbb
PE
5216 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5217 if b->modtime has its maximal value.
5218
dfe18f82
PE
5219 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5220
84acfcf0
PE
5221 Don't assume time_t can fit into int.
5222 * buffer.h (struct buffer.modtime): Now time_t, not int.
5223 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5224 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5225
ccd9a01a
PE
5226 Minor fixes for signed vs unsigned integers.
5227 * character.h (MAYBE_UNIFY_CHAR):
5228 * charset.c (maybe_unify_char):
5229 * keyboard.c (read_char, reorder_modifiers):
5230 XINT -> XFASTINT, since the integer must be nonnegative.
5231 * ftfont.c (ftfont_spec_pattern):
5232 * keymap.c (access_keymap, silly_event_symbol_error):
5233 XUINT -> XFASTINT, since the integer must be nonnegative.
5234 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5235 since it makes no difference and we prefer signed.
5236 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5237 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5238 nonnegative.
5239
d6d100dd
SM
52402011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5241
5242 * window.h (Fwindow_frame): Declare.
5243
2b6148e4
PE
52442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5245
5246 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5247 (SPARE_MEMORY): Always define.
5248 (LARGE_REQUEST): Remove.
5249 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5250
f230ecc9
MR
52512011-06-06 Martin Rudalics <rudalics@gmx.at>
5252
727e958e
MR
5253 * lisp.h: Move EXFUNS for Fframe_root_window,
5254 Fframe_first_window and Fset_frame_selected_window to window.h.
5255
5256 * window.h: Move EXFUNS for Fframe_root_window,
5257 Fframe_first_window and Fset_frame_selected_window here from
5258 lisp.h.
5259
5260 * frame.c (Fwindow_frame, Fframe_first_window)
5261 (Fframe_root_window, Fframe_selected_window)
5262 (Fset_frame_selected_window): Move to window.c.
5263 (Factive_minibuffer_window): Move to minibuf.c.
5264 (Fother_visible_frames_p): New function.
5265
5266 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5267
f230ecc9
MR
5268 * window.c (decode_window, decode_any_window): Move up in code.
5269 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5270 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5271 (Fwindow_buffer): Move up and rewrite doc-string.
5272 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5273 (Fwindow_prev): New functions.
727e958e
MR
5274 (Fwindow_frame): Move here from frame.c. Accept any window as
5275 argument.
5276 (Fframe_root_window, Fframe_first_window)
5277 (Fframe_selected_window): Move here from frame.c. Accept frame
5278 or arbitrary window as argument. Update doc-strings.
5279 (Fminibuffer_window): Move up in code.
5280 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5281 (Fset_frame_selected_window): Move here from frame.c.
5282 Marginal rewrite.
727e958e
MR
5283 (Fselected_window, select_window, Fselect_window): Move up in
5284 code. Minor doc-string fixes.
f230ecc9 5285
4d09bcf6
PE
52862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5289 Do not assume that spare memory exists; that assumption is valid
5290 only if SYSTEM_MALLOC.
5291 (LARGE_REQUEST): New macro, so that the issue of large requests
5292 is separated from the issue of spare memory.
5293
810928a2
AS
52942011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5295
172418ad
AS
5296 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5297 format. (Bug#8806)
5298
43f862f7
AS
5299 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5300
810928a2
AS
5301 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5302 before statements.
5303
a059fe24
JD
53042011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5305
5306 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5307
5308 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5309
5310 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5311 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5312
989bf368
JB
53132011-06-05 Juanma Barranquero <lekktu@gmail.com>
5314
5315 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5316
4b80f674
CY
53172011-06-04 Chong Yidong <cyd@stupidchicken.com>
5318
5319 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5320 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5321 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5322 New error handlers.
4b80f674
CY
5323 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5324 Obey Vx_select_enable_clipboard_manager. Catch errors in
5325 x_clipboard_manager_save (Bug#8779).
5326 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5327 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5328
99a33b77 53292011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5330
5331 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5332
99a33b77 53332011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5334
5335 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5336 in the current matrix if keep_current_p is non-zero.
5337
8264569d
EZ
53382011-06-04 Eli Zaretskii <eliz@gnu.org>
5339
5340 * bidi.c (bidi_level_of_next_char): Fix last change.
5341
57f97249
EZ
53422011-06-03 Eli Zaretskii <eliz@gnu.org>
5343
fec2107c 5344 Support bidi reordering of text covered by display properties.
57f97249 5345
fec2107c
EZ
5346 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5347 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5348 (bidi_cache_search, bidi_cache_iterator_state)
5349 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5350 (bidi_level_of_next_char, bidi_move_to_visually_next):
5351 Support character positions inside a run of characters covered by a
fec2107c
EZ
5352 display string.
5353 (bidi_paragraph_init, bidi_resolve_explicit_1)
5354 (bidi_level_of_next_char): Call bidi_fetch_char and
5355 bidi_fetch_char_advance instead of FETCH_CHAR and
5356 FETCH_CHAR_ADVANCE.
5357 (bidi_init_it): Initialize new members.
5358 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5359 definitions.
5360 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5361 instead of using explicit *_CHAR codes.
d6d100dd
SM
5362 (bidi_resolve_explicit, bidi_resolve_weak):
5363 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5364 bidirectional text is supported only in multibyte buffers.
5365 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5366 it to initialize the frame_window_p member of struct bidi_it.
5367 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5368 (bidi_resolve_explicit, bidi_resolve_weak)
5369 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5370 bidi_it->nchars is non-positive.
5371 (bidi_level_of_next_char): Don't try to lookup the cache for the
5372 next/previous character if nothing is cached there yet, or if we
5373 were just reseat()'ed to a new position.
c40e2fb2 5374
0e14fe90
EZ
5375 * xdisp.c (set_cursor_from_row): Set start and stop points
5376 according to the row's direction when priming the loop that looks
5377 for the glyph on which to display cursor.
5378 (single_display_spec_intangible_p): Function deleted.
5379 (display_prop_intangible_p): Reimplement to call
5380 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5381 Accept 3 additional arguments needed by handle_display_spec.
5382 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5383 values: lists, `(when COND...)' forms, etc.
5384 (single_display_spec_string_p): Support property values that are
5385 lists with the argument STRING its top-level element.
5386 (display_prop_string_p): Fix the condition for processing a
5387 property that is a list to be consistent with handle_display_spec.
fec2107c 5388 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5389 last portion of handle_display_prop.
5390 (compute_display_string_pos): Accept additional argument
5391 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5392 value of a `display' property is a "replacing spec".
5393 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5394 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5395 the display property, but just return a value indicating whether
5396 the display property will replace the characters it covers.
5397 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5398 frame_window_p members of struct bidi_it.
d6d100dd
SM
5399 (compute_display_string_pos, compute_display_string_end):
5400 New functions.
fec2107c
EZ
5401 (push_it): Accept second argument POSITION, where pop_it should
5402 jump to continue iteration.
5403 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5404
fec2107c
EZ
5405 * keyboard.c (adjust_point_for_property): Adjust the call to
5406 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5407
5408 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5409 (bidi_init_it): Update prototypes.
5410 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5411 (compute_display_string_pos, compute_display_string_end):
5412 Declare prototypes.
fec2107c
EZ
5413 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5414 EMACS_INT.
fc6f18ce 5415
40087514 54162011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5417
57f53182
PE
5418 Malloc failure behavior now depends on size of allocation.
5419 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5420 * lisp.h: Change signatures accordingly.
5421 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5422 All callers changed. (Bug#8762)
5423
5424 * gnutls.c: Use Emacs's memory allocators.
5425 Without this change, the gnutls library would invoke malloc etc.
5426 directly, which causes problems on non-SYNC_INPUT hosts, and which
5427 runs afoul of improving memory_full behavior. (Bug#8761)
5428 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5429 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5430 xfree instead of the default malloc, realloc, free.
5431 (Fgnutls_boot): No need to check for memory allocation failure,
5432 since xmalloc does that for us.
5433
ac32cd99 5434 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5435 * category.c (hash_get_category_set):
5436 * ccl.c (ccl_driver):
5437 * charset.c (Fdefine_charset_internal):
5438 * charset.h (struct charset.hash_index):
5439 * composite.c (get_composition_id, gstring_lookup_cache)
5440 (composition_gstring_put_cache):
5441 * composite.h (struct composition.hash_index):
5442 * dispextern.h (struct image.hash):
5443 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5444 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5445 (hashfn_equal, hashfn_user_defined, make_hash_table)
5446 (maybe_resize_hash_table, hash_lookup, hash_put)
5447 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5448 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5449 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5450 * image.c (make_image, search_image_cache, lookup_image)
5451 (xpm_put_color_table_h):
5452 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5453 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5454 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5455 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5456 * alloc.c (allocate_vectorlike):
5457 Check for overflow in vector size calculations.
5458 * ccl.c (ccl_driver):
5459 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5460 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5461 need to be updated by these changes.
40087514
PE
5462 * fns.c (make_hash_table, maybe_resize_hash_table):
5463 Check for integer overflow with large hash tables.
0de4bb68
PE
5464 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5465 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5466 (SXHASH_REDUCE): New macro.
5467 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5468 Use it instead of discarding useful hash info with large hash values.
5469 (sxhash_float): New function.
5470 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5471 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5472 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5473 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5474 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5475 Adjust signatures to match updated version of code.
5476 (consing_since_gc): Now EMACS_INT, since a single hash table can
5477 use more than INT_MAX bytes.
5478
698d32e2
DN
54792011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5480
5481 Make it possible to build with GCC-4.6+ -O2 -flto.
5482
5483 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5484
fd6fa53f
SM
54852011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5486
5487 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5488 Call minibuffer-inactive-mode.
5489
864db017
JB
54902011-05-31 Juanma Barranquero <lekktu@gmail.com>
5491
5492 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5493 Update dependencies.
5494
2ad0baf4
DN
54952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5496
5497 * data.c (init_data): Remove code for UTS, this system is not
5498 supported anymore.
5499
4fcc2638
DN
55002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5501
5502 Don't force ./temacs to start in terminal mode.
5503
5504 * frame.c (make_initial_frame): Initialize faces in all cases, not
5505 only when CANNOT_DUMP is defined.
5506 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5507
c56e0fd5
DN
55082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5509
5510 * dispnew.c (add_window_display_history): Use const for the string
5511 pointer. Remove declaration, not needed.
5512
333d54da 55132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5514
55d4c1b2 5515 Use 'inline', not 'INLINE'.
333d54da 5516 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5517 * alloc.c, fontset.c (INLINE): Remove.
5518 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5519 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5520 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5521 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5522 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5523
738db178
DN
55242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5525
5526 Make it possible to run ./temacs.
5527
5528 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5529 syms_of_callproc does the same thing. Remove test for
5530 "initialized", do it in the caller.
5531 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5532
620c53a6
SM
55332011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5534
5535 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5536 (read_minibuf): Use get_minibuffer.
5537 (syms_of_minibuf): Use DEFSYM.
5538 (Qmetadata): New var.
5539 * data.c (Qbuffer): Don't make it static.
5540 (syms_of_data): Use DEFSYM.
5541
e003a292
PE
55422011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5543
5544 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5545 (CCL_CODE_MIN): New macro.
5546
ed008a6d
PE
55472011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5548
3687c2ef
PE
5549 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5550
ed008a6d
PE
5551 * eval.c (Qdebug): Now static.
5552 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5553 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5554 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5555
d66c4c7c
CY
55562011-05-29 Chong Yidong <cyd@stupidchicken.com>
5557
5558 * image.c: Various fixes to ImageMagick code comments.
5559 (Fimagemagick_types): Doc fix.
5560
5fbc2025
PE
55612011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5562
0196f88a
PE
5563 Minor fixes prompted by GCC 4.6.0 warnings.
5564
5565 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5566
5fbc2025
PE
5567 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5568 (x_clipboard_manager_save_all): Move extern decl to ...
5569 * xterm.h: ... here, so that it can be checked for consistency.
5570
1dd3c2d9
CY
55712011-05-29 Chong Yidong <cyd@stupidchicken.com>
5572
5573 * xselect.c (x_clipboard_manager_save_frame)
5574 (x_clipboard_manager_save_all): New functions.
5575 (Fx_clipboard_manager_save): Lisp function deleted.
5576
5577 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5578 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5579
5580 * xterm.h: Update prototype.
5581
5ba6571d
WX
55822011-05-28 William Xu <william.xwl@gmail.com>
5583
5584 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5585 exiting (Bug#8239).
5586
3eaff834
JM
55872011-05-28 Jim Meyering <meyering@redhat.com>
5588
e1900994 5589 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5590 * fns.c (to_uchar): Define.
5591 (crypto_hash_function): Use it to convert some newly-signed
5592 variables to unsigned, to avoid sign-extension bugs. For example,
5593 without this change, (md5 "truc") would evaluate to
5594 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5595 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5596 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5597
0f6990a7
PE
55982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5599
5600 Integer overflow fixes.
c8a9ca5a 5601
08686060
PE
5602 * dbusbind.c: Serial number integer overflow fixes.
5603 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5604 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5605 to hold a serial number that is too large for a fixnum.
5606 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5607 Check for serial numbers out of range. Decode any serial number
59568bf0 5608 that was so large that it became a float. (Bug#8722)
08686060 5609
2d1fc3c7
PE
5610 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5611 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5612 Use XFASTINT rather than XUINT when numbers are nonnegative.
5613 (xd_append_arg, Fdbus_method_return_internal):
5614 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5615 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5616 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5617 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5618 (Bug#8722)
2d1fc3c7 5619
c8a9ca5a
PE
5620 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5621
519e1d69
PE
5622 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5623
30569699
PE
5624 ccl: add integer overflow checks
5625 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5626 (IN_INT_RANGE): New macros.
5627 (ccl_driver): Use them to check for integer overflow when
5628 decoding a CCL program. Many of the new checks are whether XINT (x)
5629 fits in int; it doesn't always, on 64-bit hosts. The new version
5630 doesn't catch all possible integer overflows, but it's an
847044ea 5631 improvement. (Bug#8719)
30569699 5632
c11285dc
PE
5633 * alloc.c (make_event_array): Use XINT, not XUINT.
5634 There's no need for unsigned here.
5635
fdccd48e
PE
5636 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5637 This follows up to the 2011-05-06 change that substituted uintptr_t
5638 for EMACS_INT. This case wasn't caught back then.
5639
37910ab2
PE
5640 Rework Fformat to avoid integer overflow issues.
5641 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5642 now (part of C89). Include <verify.h>.
5643 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5644 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5645 (Fformat): Avoid the prepass trying to compute sizes; it was only
5646 approximate and thus did not catch overflow reliably. Instead, walk
5647 through the format just once, formatting and computing sizes as we go,
5648 checking for integer overflow at every step, and allocating a larger
5649 buffer as needed. Keep track separately whether the format is
5650 multibyte. Keep only the most-recently calculated precision, rather
5651 than them all. Record whether each argument has been converted to
5652 string. Use EMACS_INT, not int, for byte and char and arg counts.
5653 Support field widths and precisions larger than INT_MAX. Avoid
5654 sprintf's undefined behavior with conversion specifications such as %#d
5655 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5656 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5657 formatting out-of-range floating point numbers with int
9173deec 5658 formats. (Bug#8668)
37910ab2 5659
2e6578fb
PE
5660 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5661
0ae6bdee
PE
5662 * data.c: Avoid integer truncation in expressions involving floats.
5663 * data.c: Include <intprops.h>.
5664 (arith_driver): When there's an integer overflow in an expression
5665 involving floating point, convert the integers to floating point
5666 so that the resulting value does not suffer from catastrophic
5667 integer truncation. For example, on a 64-bit host (* 4
5668 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5669 Do not rely on undefined behavior after integer overflow.
5670
de883a70
PE
5671 merge count_size_as_multibyte, parse_str_to_multibyte
5672 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5673 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5674 Check for integer overflow.
5675 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5676 since it's now a duplicate of the other. This is more of
5677 a character than a buffer op, so better that it's in character.c.
5678 * fns.c, print.c: Adjust to above changes.
5679
2ff916cb
PE
56802011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5681
5682 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5683
f1b54466
PE
56842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5685
fb1ac845
PE
5686 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5687 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5688 (x_clipboard_manager_save): Now static.
5689 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5690
f1b54466
PE
5691 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5692 (crypto_hash_function): Now static.
5693 Fix pointer signedness problems. Avoid unnecessary initializations.
5694
a9f737ee
CY
56952011-05-27 Chong Yidong <cyd@stupidchicken.com>
5696
5697 * termhooks.h (Vselection_alist): Make it terminal-local.
5698
5699 * terminal.c (create_terminal): Initialize it.
5700
5701 * xselect.c: Support for clipboard managers.
5702 (Vselection_alist): Move to termhooks.h as terminal-local var.
5703 (LOCAL_SELECTION): New macro.
5704 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5705 (symbol_to_x_atom): Remove gratuitous arg.
5706 (x_handle_selection_request, lisp_data_to_selection_data)
5707 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5708 (x_own_selection, x_get_local_selection, x_convert_selection):
5709 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5710 (some_frame_on_display): Delete unused function.
5711 (Fx_own_selection_internal, Fx_get_selection_internal)
5712 (Fx_disown_selection_internal, Fx_selection_owner_p)
5713 (Fx_selection_exists_p): New optional frame arg.
5714 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5715 (x_handle_selection_clear): Don't treat other terminals with the
5716 same keyboard specially. Use the terminal-local Vselection_alist.
5717 (x_clear_frame_selections): Use Frun_hook_with_args.
5718
5719 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5720
5721 * xterm.h: Add support for those atoms.
5722
e067f0c1
CY
57232011-05-26 Chong Yidong <cyd@stupidchicken.com>
5724
5725 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5726 (converted_selections, conversion_fail_tag): New global variables.
5727 (x_selection_request_lisp_error): Free the above.
5728 (x_get_local_selection): Remove unnecessary code.
5729 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5730 of converted selections stored in converted_selections.
5731 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5732 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5733 (x_convert_selection): New function.
5734 (x_handle_selection_event): Simplify.
5735 (x_get_foreign_selection): Don't ignore incoming requests while
5736 waiting for an answer; this will fail when we implement
5737 SAVE_TARGETS, and seems unnecessary anyway.
5738 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5739 (Vx_sent_selection_functions): Doc fix.
5740
0f4aebc0
LL
57412011-05-26 Leo Liu <sdl.web@gmail.com>
5742
5743 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5744
e61124cd
YM
57452011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5746
5747 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5748
5749 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5750 for fringe update if it has periodic bitmap.
ac389d0c 5751 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5752 and fringe_bitmap_periodic_p.
5753
5754 * fringe.c (get_fringe_bitmap_data): New function.
5755 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5756 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5757 row. Mark glyph row for fringe update if periodicity changed.
5758
5759 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5760 for fringe update unless it has periodic bitmap.
5761
f16d9837
KH
57622011-05-25 Kenichi Handa <handa@m17n.org>
5763
5764 * xdisp.c (get_next_display_element): Set correct it->face_id for
5765 a static composition.
5766
e1b90ef6
LL
57672011-05-24 Leo Liu <sdl.web@gmail.com>
5768
5769 * deps.mk (fns.o):
5770 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5771
5772 * fns.c (crypto_hash_function, Fsha1): New function.
5773 (Fmd5): Use crypto_hash_function.
5774 (syms_of_fns): Add Ssha1.
5775
7400048f
PE
57762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5777
5778 * gnutls.c: Remove unused macros.
5779 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5780 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5781 Remove macros that are defined and never used.
5782 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5783
abb71cf4
CY
57842011-05-22 Chong Yidong <cyd@stupidchicken.com>
5785
5786 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5787 (Fx_get_selection_internal): Minor cleanup.
5788 (Fx_own_selection_internal): Rename arguments for consistency with
5789 select.el.
5790
6307db39
PE
57912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5792
5793 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5794
f3d4e0a4
CY
57952011-05-22 Chong Yidong <cyd@stupidchicken.com>
5796
5797 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5798
4d8ade89
YM
57992011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5800
5801 * dispnew.c (scrolling_window): Don't exclude the case that the
5802 last enabled row in the desired matrix touches the bottom boundary.
5803
32078c8d
GM
58042011-05-21 Glenn Morris <rgm@gnu.org>
5805
5806 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5807 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5808 and add some more files.
32078c8d 5809
7285dc67
EZ
58102011-05-20 Eli Zaretskii <eliz@gnu.org>
5811
5812 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5813 report_file_error introduced by the change from 2011-05-07.
5814
89d1bd22
PE
58152011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 * systime.h (Time): Define only if emacs is defined.
5818 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5819 where the include path doesn't have X11/X.h by default. See
5820 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5821
cd394be1 58222011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5823
5824 * composite.c (find_automatic_composition): Fix previous change.
5825
b9704ad9
GM
58262011-05-20 Glenn Morris <rgm@gnu.org>
5827
5828 * lisp.mk: New file, split from Makefile.in.
5829 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5830 (shortlisp): Remove.
5831 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5832
4a720484
GM
58332011-05-19 Glenn Morris <rgm@gnu.org>
5834
5835 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5836 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5837 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5838 (lisp): Set the order to that of loadup.el.
5839 (shortlisp): Make it a copy of $lisp.
5840 (SOME_MACHINE_LISP): Remove.
5841 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5842 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5843
a28d4396
KH
58442011-05-18 Kenichi Handa <handa@m17n.org>
5845
5846 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5847 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5848 (find_automatic_composition): Mostly rewrite for efficiency.
5849
a2b1fa8e
JB
58502011-05-18 Juanma Barranquero <lekktu@gmail.com>
5851
5852 * makefile.w32-in: Update dependencies.
5853
8e1f5610
CS
58542011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5855
5856 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5857 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5858
7025ee00 58592011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5860
cdfa6eab
PE
5861 Fix some integer overflow issues, such as string length overflow.
5862
06d6db33
PE
5863 * insdel.c (count_size_as_multibyte): Check for string overflow.
5864
2b4560a8
PE
5865 * character.c (lisp_string_width): Check for string overflow.
5866 Use EMACS_INT, not int, for string indexes and lengths; in
5867 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5868 the resulting string length overflows an EMACS_INT; instead,
5869 report a string overflow if no precision given. When checking for
5870 precision exhaustion, use a check that cannot possibly have
5871 integer overflow. (Bug#8675)
5872 * character.h (lisp_string_width): Adjust to new signature.
5873
cb93f9be
PE
5874 * alloc.c (string_overflow): New function.
5875 (Fmake_string): Use it. This doesn't change behavior, but saves
5876 a few bytes and will simplify future changes.
5877 * character.c (string_escape_byte8): Likewise.
5878 * lisp.h (string_overflow): New decl.
5879
1a1f3366
PE
5880 Fixups, following up to the user-interface timestamp change.
5881 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5882 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5883 * msdos.c (mouse_get_pos): Likewise.
5884 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5885 * w32gui.h (Time): Define by including "systime.h" rather than by
5886 declaring it ourselves. (Bug#8664)
5887
d4e3e4d3
PE
5888 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5889 * image.c (clear_image_cache): Likewise.
5890
f6a24d19
PE
5891 * term.c (term_mouse_position): Don't assume time_t wraparound.
5892
08dc5ae6
PE
5893 Be more systematic about user-interface timestamps.
5894 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5895 and sometimes 'EMACS_UINT', to represent these timestamps.
5896 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5897 This makes the code easier to follow, and makes it easier to catch
5898 integer overflow bugs such as Bug#8664.
5899 * frame.c (Fmouse_position, Fmouse_pixel_position):
5900 Use Time, not unsigned long, for user-interface timestamps.
5901 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5902 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5903 * keyboard.h (last_event_timestamp): Likewise.
5904 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5905 * menu.h (xmenu_show): Likewise.
5906 * term.c (term_mouse_position): Likewise.
5907 * termhooks.h (struct input_event.timestamp): Likewise.
5908 (struct terminal.mouse_position_hook): Likewise.
5909 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5910 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5911 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5912 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5913 what it was before.
5914 * menu.h, termhooks.h: Include "systime.h", for Time.
5915
8e55734a
PE
5916 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5917 Don't assume that the difference between two unsigned long values
5918 can fit into an integer. At this point, we know button_down_time
5919 <= event->timestamp, so the difference must be nonnegative, so
5920 there's no need to cast the result if double-click-time is
5921 nonnegative, as it should be; check that it's nonnegative, just in
5922 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5923 apart (about 25 days). (Bug#8664)
8e55734a 5924
841f1b75 5925 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5926 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5927
3e26f69c
PE
5928 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5929 that always fit in int. Use a sentinel instead of a counter, to
5930 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5931 * frame.h (struct frame): Use int for menu_bar_items_used
5932 instead of EMACS_INT, since it always fits in int.
3e26f69c 5933
5cc152c0
PE
5934 * menu.c (grow_menu_items): Check for int overflow.
5935
d89eb65e
PE
5936 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5937
5235bd3e
PE
5938 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5939 Before, the code was not consistent. These values cannot exceed
5940 2**31 - 1 so there's no need to make them unsigned.
5941 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5942 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5943 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5944 as modifiers.
5945 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5946
bc827e23
PE
5947 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5948 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5949 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5950 presumably because the widths might not match.
5951
78eb494e
PE
5952 * window.c (size_window): Avoid needless test at loop start.
5953
04f2d78b
CB
59542011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5955
5956 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5957
d2fc7e3d 59582011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5959
5960 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5961
d2fc7e3d 59622011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5963
5964 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5965 `width' to `bar_area_x' and `bar_area_width', respectively.
5966 (x_scroll_run): Take account of fringe background extension.
5967
04f2d78b
CB
5968 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5969 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5970 `bar_area_width', respectively.
5971 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5972 background extension.
5973
79b70037
GM
59742011-05-10 Jim Meyering <meyering@redhat.com>
5975
5976 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5977
2f142cc5
JB
59782011-05-10 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * image.c (Finit_image_library): Return t for built-in image types,
5981 like pbm and xbm. (Bug#8640)
5982
57679c86
AS
59832011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5984
5985 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5986
888c9e86
EZ
59872011-05-07 Eli Zaretskii <eliz@gnu.org>
5988
b0512a1d
EZ
5989 * w32console.c (Fset_screen_color): Doc fix.
5990 (Fget_screen_color): New function.
5991 (syms_of_ntterm): Defsubr it.
5992
7285dc67
EZ
5993 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5994 unlink the temporary file if Fcall_process didn't create it in the
5995 first place.
5996 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5997 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5998 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5999 cue to call_process_cleanup not to close that handle.
6000
4d3fcc8e
BK
60012011-05-07 Ben Key <bkey76@gmail.com>
6002
6003 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6004 one of two shell specific rules, either bootstrap-temacs-CMD or
6005 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6006 to the previous implementation of the bootstrap-temacs rule.
6007 The bootstrap-temacs-CMD rule is similar to the previous
6008 implementation of the bootstrap-temacs rule except that it
6009 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6010 variable.
6011
6012 These changes, along with some changes to nt/configure.bat,
6013 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6014 earlier fix to add support for --cflags and --ldflags options
6015 that include quotes so that it works whether make uses cmd or
6016 sh as the shell.
6017
b4289b64
MA
60182011-05-06 Michael Albinus <michael.albinus@gmx.de>
6019
6020 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6021 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6022 is a constant.
6023 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6024 a string. Handle both cases.
6025 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6026 (Fdbus_register_method): Use Qinvalid_function.
6027
af4c0e28
JB
60282011-05-06 Juanma Barranquero <lekktu@gmail.com>
6029
6030 * makefile.w32-in: Update dependencies.
6031 (LISP_H): Add inttypes.h and stdin.h.
6032 (PROCESS_H): Add unistd.h.
6033
c51453d9
EZ
60342011-05-06 Eli Zaretskii <eliz@gnu.org>
6035
6036 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6037 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6038
8ff0ac3c 60392011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6040
4c4b566b
PE
6041 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6042
aab2b9b5
PE
6043 * term.c (vfatal): Remove stray call to va_end.
6044 It's not needed and the C Standard doesn't allow it here anyway.
6045
c378da0b
PE
6046 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6047 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6048
288b08c7
PE
6049 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6050 bytes.
6051
e3601888
PE
6052 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6053
db6c0e74
PE
6054 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6055
dd5963ea
PE
6056 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6057
88c9450f
PE
6058 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6059
2f9442b8
PE
6060 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6061
c032b5f8
PE
6062 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6063 * charset.c (Fdefine_charset_internal): Don't initialize
6064 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6065 32-bit int (Bug#8600).
a108c10b
PE
6066
6067 * lread.c (read_integer): Be more consistent with string-to-number.
6068 Use string_to_number to do the actual conversion; this avoids
6069 rounding errors and fixes some other screwups. Without this fix,
6070 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6071 (digit_to_number): Move earlier, for benefit of read_integer.
6072 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6073 not a digit in any supported base. (Bug#8602)
a108c10b 6074
ad5f9eea
PE
6075 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6076
aec1708a
PE
6077 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6078 to match comment at start of function. This also removes a
6079 GCC warning about overflow in a 32+64-bit port.
6080
47be4ab5
PE
6081 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6082
371cac43
PE
6083 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6084 Reported by Stefan Monnier in
6085 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6086 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6087 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6088
d01a7826
PE
6089 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6090 (EMACS_UINTPTR): Likewise, with uintptr_t.
6091
7fd47d5c
PE
6092 * lisp.h: Prefer 64-bit EMACS_INT if available.
6093 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6094 on 32-bit hosts that have 64-bit int, so that they can access
6095 large files.
122b0c86
PE
6096 However, temporarily disable this change unless the temporary
6097 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6098
8727937b
PE
6099 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6100
8ac068ac
PE
6101 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6102 This removes an assumption that EMACS_INT and long are the same
6103 width as pointers. The assumption is true for Emacs porting targets
6104 now, but we want to make other targets possible.
6105 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6106 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6107 In the rest of the code, change types of integers that hold casted
6108 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6109 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6110 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6111 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6112 No need to cast type when ORing.
6113 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6114 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6115 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6116 assume EMACS_INT is the same width as char *.
6117 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6118 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6119 Remove no-longer-needed casts.
6120 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6121 (xg_tool_bar_help_callback, xg_make_tool_item):
6122 Use EMACS_INTPTR to hold an integer
6123 that will be cast to void *; this can avoid a GCC warning
6124 if EMACS_INT is not the same width as void *.
6125 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6126 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6127 (current_message_1, set_message_1):
6128 Use a local to convert to proper width without a cast.
6129 * xmenu.c (dialog_selection_callback): Likewise.
6130
ede49d71
PE
6131 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6132 Also, don't assume VALBITS / RAND_BITS is less than 5,
6133 and don't rely on undefined behavior when shifting a 1 left into
6134 the sign bit.
6135 * lisp.h (get_random): Change signature to match.
6136
2f30ecd0
PE
6137 * lread.c (hash_string): Use size_t, not int, for hash computation.
6138 Normally we prefer signed values; but hashing is special, because
6139 it's better to use unsigned division on hash table sizes so that
6140 the remainder is nonnegative. Also, size_t is the natural width
6141 for hashing into memory. The previous code used 'int', which doesn't
6142 retain enough info to hash well into very large tables.
6143 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6144
2a866e7b
PE
6145 * dbusbind.c: Don't possibly lose pointer info when converting.
6146 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6147 Use XPNTR rather than XHASH, so that the high-order bits of
6148 the pointer aren't lost when converting through void *.
6149
51639eac
PE
6150 * eval.c (Fautoload): Don't double-shift a pointer.
6151
92394119
PE
6152 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6153
dbdb9a7c
JB
61542011-05-06 Juanma Barranquero <lekktu@gmail.com>
6155
6156 * gnutls.c (DEF_GNUTLS_FN):
6157 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6158
db7a0b4f
AS
61592011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6160
6161 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6162 marker. (Bug#8610)
6163
cd394be1 61642011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6165
6166 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6167 New version that can reserve upto 2GB of heap space.
6168
f7ff1b0f 61692011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6170
6171 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6172
639c109b
TZ
61732011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6174
6175 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6176 `gnutls_certificate_set_x509_key_file'.
6177
d2127135
JB
61782011-05-05 Juanma Barranquero <lekktu@gmail.com>
6179
6180 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6181 Update dependencies.
6182
e968f4f3
JB
61832011-05-04 Juanma Barranquero <lekktu@gmail.com>
6184
6185 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6186 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6187 Remove unused parameter `fildes'.
6188 * process.c (read_process_output, send_process): Don't pass it.
6189
84d358f0
JB
61902011-05-04 Juanma Barranquero <lekktu@gmail.com>
6191
6192 Fix previous change: the library cache is defined in w32.c.
6193 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6194 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6195
0898ca10
JB
61962011-05-04 Juanma Barranquero <lekktu@gmail.com>
6197
6198 Implement dynamic loading of GnuTLS on Windows.
6199
6200 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6201 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6202 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6203 Declare.
6204
6205 * gnutls.c (Qgnutls_dll): Define.
6206 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6207 (gnutls_*): Declare function pointers.
6208 (init_gnutls_functions): New function to initialize function pointers.
6209 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6210 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6211 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6212 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6213 (emacs_gnutls_write, emacs_gnutls_read)
6214 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6215 (Fgnutls_available_p): New function.
6216 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6217 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6218 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6219
6220 * image.c: Include w32.h.
6221 (Vimage_type_cache): Delete.
6222 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6223 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6224 (w32_delayed_load): Move to w32.c.
6225
6226 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6227
6228 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6229 (w32_delayed_load): Move from image.c. When loading a library, record
6230 its filename in the :loaded-from property of the library id.
6231 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6232 Initialize and staticpro them.
6233 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6234
6235 * process.c: Include lisp.h before w32.h, not after.
6236 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6237 instead of gnutls_record_check_pending.
6238
6239 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6240
ff4de4aa
TZ
62412011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6242
6243 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6244 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6245 as passed in.
6246
abe95abb
JD
62472011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6248
6249 * xterm.c (x_set_frame_alpha): Do not set property on anything
6250 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6251
e16e55d4
JB
62522011-05-02 Juanma Barranquero <lekktu@gmail.com>
6253
6254 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6255
bafcf6a5
JB
62562011-05-02 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6259 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6260 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6261 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6262 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6263 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6264 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6265 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6266 (Qgnutls_bootprop_callbacks_verify): Make static.
6267
e7a6747f
AS
62682011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6269
19ed11ba
AS
6270 * callproc.c: Indentation fixup.
6271
e7a6747f 6272 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6273 (wait_for_termination, interruptible_wait_for_termination):
6274 Move after wait_for_termination_1.
e7a6747f 6275
1ef14cb4
LMI
62762011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6277
6278 * sysdep.c (interruptible_wait_for_termination): New function
6279 which is like wait_for_termination, but allows keyboard
6280 interruptions.
6281
6282 * callproc.c (Fcall_process): Add (:file "file") as an option for
6283 the STDOUT buffer.
6284 (Fcall_process_region): Ditto.
6285
330d880c
EZ
62862011-04-30 Eli Zaretskii <eliz@gnu.org>
6287
8db90b73
EZ
6288 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6289 rather than `XVECTOR (FOO)->size'.
6290
330d880c
EZ
6291 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6292 inttypes.h, as a gnulib replacement is used if it not available in
6293 system headers.
6294
15cbd324
EZ
62952011-04-21 Eli Zaretskii <eliz@gnu.org>
6296
6297 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6298 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6299 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6300
6301 * coding.c (coding_alloc_by_realloc): Error out if destination
6302 will grow beyond MOST_POSITIVE_FIXNUM.
6303 (decode_coding_emacs_mule): Abort if there isn't enough place in
6304 charbuf for the composition carryover bytes. Reserve an extra
6305 space for up to 2 characters produced in a loop.
6306 (decode_coding_iso_2022): Abort if there isn't enough place in
6307 charbuf for the composition carryover bytes.
6308
63092011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6310
ae940cca
EZ
6311 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6312 aborting when %lld or %lll format is passed.
6313 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6314 %llo or %llx format is passed. (Bug#8545)
6315
03ab8921
EZ
6316 * window.c (window_scroll_line_based): Use a marker instead of
6317 simple variables to record original value of point. (Bug#7952)
6318
afda1437
EZ
6319 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6320 produced by %s or %c overflows available buffer space. (Bug#8545)
6321
f76dee0c
PE
63222011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6323
6324 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6325 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6326
fdc5744d
JB
63272011-04-28 Juanma Barranquero <lekktu@gmail.com>
6328
6329 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6330
638f053a
JB
63312011-04-28 Juanma Barranquero <lekktu@gmail.com>
6332
6333 * keyboard.c (Qdelayed_warnings_hook): Define.
6334 (command_loop_1): Run `delayed-warnings-hook'
6335 if Vdelayed_warnings_list is non-nil.
6336 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6337 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6338
d178f871
EZ
63392011-04-28 Eli Zaretskii <eliz@gnu.org>
6340
6341 * doprnt.c (doprnt): Don't return value smaller than the buffer
6342 size if the message was truncated. (Bug#8545).
6343
b124fd93
JB
63442011-04-28 Juanma Barranquero <lekktu@gmail.com>
6345
6346 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6347 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6348
e810457d
PE
63492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6350
6351 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6352
ea51cceb
JB
63532011-04-27 Juanma Barranquero <lekktu@gmail.com>
6354
6355 * makefile.w32-in: Update dependencies.
6356
94dcfacf
EZ
63572011-04-27 Eli Zaretskii <eliz@gnu.org>
6358
6359 Improve `doprnt' and its usage. (Bug#8545)
6360 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6361 `format_end'. Remove support for %l as a conversion specifier.
6362 Don't use xrealloc. Improve diagnostics when the %l size modifier
6363 is used. Update the commentary.
6364
6365 * eval.c (verror): Simplify calculation of size_t.
6366
6367 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6368 messages.
6369
f61f41d7
PE
63702011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6371
6372 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6373 change.
6374
96fb4434
PE
63752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6376
6377 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6378 This makes this file independent of the recent pseudovector change.
6379
671875da 63802011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6381
69e9b5a3
PE
6382 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6383
b5f869a7 6384 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6385 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6386 Remove unused local.
c8926152 6387 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6388
841a1577 6389 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6390 GCC 4.6.0 optimizes based on type-based alias analysis.
6391 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6392 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6393 != &v->size, and therefore "v->size = 1; b->size = 2; return
6394 v->size;" must therefore return 1. This assumption is incorrect
6395 for Emacs, since it type-puns struct Lisp_Vector * with many other
6396 types. To fix this problem, this patch adds a new type struct
f904488f 6397 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6398 and pseudovectors, and helps optimizing compilers not get fooled
6399 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6400 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6401 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6402 the size member.
eab3844f
PE
6403 (XSETPVECTYPE): Rewrite in terms of new macro.
6404 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6405 This is a bit clearer, and further avoids the possibility of
6406 undesirable aliasing.
6407 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6408 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6409 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6410 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6411 (ASIZE): Now uses header.size rather than size.
6412 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6413 to avoid the hassle of writing XVECTOR (foo)->header.size.
6414 (struct vectorlike_header): New type.
eab3844f
PE
6415 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6416 object, to help avoid aliasing.
6417 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6418 (SUBRP): Likewise, since Lisp_Subr is a special case.
6419 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6420 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6421 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6422 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6423 changed to be "header.size" and "header.next".
6424 * buffer.h (struct buffer): Likewise.
6425 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6426 * frame.h (struct frame): Likewise.
6427 * process.h (struct Lisp_Process): Likewise.
6428 * termhooks.h (struct terminal): Likewise.
6429 * window.c (struct save_window_data, struct saved_window): Likewise.
6430 * window.h (struct window): Likewise.
6431 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6432 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6433 * buffer.c (init_buffer_once): Likewise.
6434 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6435 special case.
6436 * process.c (Fformat_network_address): Use local var for size,
6437 for brevity.
6438
0df1eac5
PE
6439 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6440
847ab9d1 6441 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6442 * data.c (atof): Remove decl; no longer used or needed.
6443 (digit_to_number): Move to lread.c.
6444 (Fstring_to_number): Use new string_to_number function, to be
6445 consistent with how the Lisp reader treats infinities and NaNs.
6446 Do not assume that floating-point numbers represent EMACS_INT
6447 without losing information; this is not true on most 64-bit hosts.
6448 Avoid double-rounding errors, by insisting on integers when
6449 parsing non-base-10 numbers, as the documentation specifies.
6450 * lisp.h (string_to_number): New decl, replacing ...
6451 (isfloat_string): Remove.
bc0a5c13 6452 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6453 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6454 appears to have been a coding error. Similarly, do not accept
6455 strings like +-1e0 as floating point numbers. Do not report
6456 overflow for integer overflows unless the base is not 10 which
6457 means we have no simple and reliable way to continue.
6458 Break out the floating-point parsing into a new
6459 function string_to_number, so that Fstring_to_number parses
6460 floating point numbers consistently with the Lisp reader.
04f2d78b 6461 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6462 (E_CHAR, EXP_INT): Remove, replacing with ...
6463 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6464 (string_to_number): New function, replacing isfloat_string.
6465 This function checks for valid syntax and produces the resulting
6466 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6467 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6468 so that overflow for non-base-10 numbers is reported only when
6469 there's no portable and simple way to convert to floating point.
452f4150 6470
67769ffc
PE
6471 * textprop.c (set_text_properties_1): Rewrite for clarity,
6472 and to avoid GCC warning about integer overflow.
6473
c20db43f
PE
6474 * intervals.h (struct interval): Use EMACS_INT for members
6475 where EMACS_UINT might cause problems. See
6476 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6477 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6478 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6479 All uses changed.
37aa2f85
PE
6480 (offset_intervals): Tell GCC not to worry about length overflow
6481 when negating a negative length.
c20db43f 6482
2538aa2f
PE
6483 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6484 (overrun_check_free): Likewise.
6485
f2d3008d
PE
6486 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6487 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6488 word size.
6489
ec8df744
PE
6490 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6491 (gnutls_make_error): Rename local to avoid shadowing.
6492 (gnutls_emacs_global_deinit): ifdef out; not used.
6493 (Fgnutls_boot): Use const for pointer to readonly storage.
6494 Comment out unused local. Fix pointer signedness problems.
6495
640ee02d
PE
6496 * lread.c (openp): Don't stuff size_t into an 'int'.
6497 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6498 about possible signed overflow.
6499
6048fb2a
PE
6500 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6501 (GDK_KEY_g): Don't define if already defined.
6502 (xg_prepare_tooltip): Avoid pointer signedness problem.
6503 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6504
fa3c87e1
PE
6505 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6506 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6507
2172544b
PE
6508 * xfns.c (Fx_window_property): Simplify a bit,
6509 to make a bit faster and to avoid GCC 4.6.0 warning.
6510 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6511
9b821a21
PE
6512 * fns.c (internal_equal): Don't assume size_t fits in int.
6513
3c616cfa
PE
6514 * alloc.c (compact_small_strings): Tighten assertion a little.
6515
c2982e87
PE
6516 Replace pEd with more-general pI, and fix some printf arg casts.
6517 * lisp.h (pI): New macro, generalizing old pEd macro to other
6518 conversion specifiers. For example, use "...%"pI"d..." rather
6519 than "...%"pEd"...".
6520 (pEd): Remove. All uses replaced with similar uses of pI.
6521 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6522 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6523 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6524 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6525 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6526 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6527 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6528 64-bit hosts.
6529 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6530 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6531 * print.c (safe_debug_print, print_object): Likewise.
6532 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6533 to int.
6f04d126
PE
6534 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6535 avoiding the 0 flag, which is not portable.
c2982e87
PE
6536 * process.c (Fmake_network_process): Use pI to avoid cast.
6537 * region-cache.c (pp_cache): Likewise.
6538 * xdisp.c (decode_mode_spec): Likewise.
6539 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6540 behavior on 64-bit hosts with printf arg.
6f04d126 6541 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6542 (x_stop_queuing_selection_requests): Likewise.
6543 (x_get_window_property): Don't truncate byte count to an 'int'
6544 when tracing.
0b432f21 6545
5e073ec7
PE
6546 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6547 here, since it parses constructs like leading '-' and spaces,
6548 which are not wanted; and it overflows with large numbers.
6549 Instead, simply match F[0-9]+, which is what is wanted anyway.
6550
36372bf9
PE
6551 * alloc.c: Remove unportable assumptions about struct layout.
6552 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6553 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6554 (allocate_vectorlike, make_pure_vector): Use the new macros,
6555 plus offsetof, to remove unportable assumptions about struct layout.
6556 These assumptions hold on all porting targets that I know of, but
6557 they are not guaranteed, they're easy to remove, and removing them
6558 makes further changes easier.
6559
0b432f21
PE
6560 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6561 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6562 (string_overrun_cookie): Now const. Use initializers that
6563 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6564 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6565 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6566 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6567 multiple of sizeof (EMACS_INT); it need not be, if
6568 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6569 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6570
895009e1
JB
65712011-04-26 Juanma Barranquero <lekktu@gmail.com>
6572
6573 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6574
6a7a1b0b
TZ
65752011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6576
6577 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6578 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6579 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6580
841a1577 65812011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6582
6583 * lisp.h (Qdebug): List symbol.
895009e1 6584 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6585 * keyboard.c (debug-on-event): New variable.
6586 (handle_user_signal): Break into debugger when debug-on-event
6587 matches the current signal symbol.
6588
f2d3ba6f
DN
65892011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6590
6591 * alloc.c (check_sblock, check_string_bytes)
6592 (check_string_free_list): Convert to standard C.
6593
42ce4c63
TZ
65942011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6595
6596 * w32.c (emacs_gnutls_push): Fix typo.
6597
825cd63c
EZ
65982011-04-25 Eli Zaretskii <eliz@gnu.org>
6599
fb11d64d
EZ
6600 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6601 "cast to pointer from integer of different size".
6602
825cd63c
EZ
6603 Improve doprnt and its use in verror. (Bug#8545)
6604 * doprnt.c (doprnt): Document the set of format control sequences
6605 supported by the function. Use SAFE_ALLOCA instead of always
6606 using `alloca'.
6607
6608 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6609 is one byte too soon. Don't use xrealloc; instead xfree and
6610 xmalloc anew.
6611
e061a11b
TZ
66122011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6613
6614 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6615 callbacks stage.
6616
6617 * gnutls.c: Renamed global_initialized to
6618 gnutls_global_initialized. Added internals for the
6619 :verify-hostname-error, :verify-error, and :verify-flags
6620 parameters of `gnutls-boot' and documented those parameters in the
6621 docstring. Start callback support.
9173deec
JB
6622 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6623 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6624 on error. Return error code.
e061a11b
TZ
6625 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6626 (emacs_gnutls_read): Likewise.
6627 (Fgnutls_boot): Return handshake error code.
6628 (emacs_gnutls_handle_error): New function.
6629 (wsaerror_to_errno): Likewise.
6630
6631 * w32.h (emacs_gnutls_pull): Add prototype.
6632 (emacs_gnutls_push): Likewise.
6633
6634 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6635 (emacs_gnutls_push): Likewise.
6636
66372011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6638
6639 * process.c (wait_reading_process_output): Check if GnuTLS
6640 buffered some data internally if no FDs are set for TLS
6641 connections.
6642
6643 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6644 (LIBS): Link to USER_LIBS.
6645 ($(BLD)/gnutls.$(0)): New target.
6646
fa6996bc
EZ
66472011-04-24 Eli Zaretskii <eliz@gnu.org>
6648
eb35682e
EZ
6649 * xdisp.c (handle_single_display_spec): Rename the
6650 display_replaced_before_p argument into display_replaced_p, to
6651 make it consistent with the commentary. Fix typos in the
6652 commentary.
6653
e2ad650c
EZ
6654 * textprop.c (syms_of_textprop): Remove dead code.
6655 (copy_text_properties): Delete obsolete commentary about an
6656 interface that was deleted long ago. Fix typos in the description
6657 of arguments.
6658
1b2de274
EZ
6659 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6660 to changes in oldXMenu/XMenu.h from 2011-04-16.
6661 <menu_help_message, prev_menu_help_message>: Constify.
6662 (IT_menu_make_room): menu->help_text is now `const char **';
6663 adjust.
6664
6665 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6666 to changes in oldXMenu/XMenu.h from 2011-04-16.
6667 (struct XMenu): Declare `help_text' `const char **'.
6668
6669 * xfaces.c <Qunspecified>: Make extern again.
6670
6671 * syntax.c: Include sys/types.h before including regex.h, as
6672 required by Posix.
6673
762b15be
EZ
6674 * doc.c (get_doc_string): Improve the format passed to `error'.
6675
6676 * doprnt.c (doprnt): Improve commentary.
6677
6678 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6679
6680 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6681 them with etags.
6682
f1052e5d
EZ
6683 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6684 changes in globals.h immediately force recompilation.
762b15be
EZ
6685 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6686 $(CURDIR)/s/ms-w32.h.
6687 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6688
fa6996bc
EZ
6689 * character.c (Fchar_direction): Function deleted.
6690 (syms_of_character): Don't defsubr it.
6691 <char-direction-table>: Deleted.
6692
e6c3da20
EZ
66932011-04-23 Eli Zaretskii <eliz@gnu.org>
6694
6695 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6696 * doprnt.c: Include limits.h.
6697 (SIZE_MAX): New macro.
04f2d78b
CB
6698 (doprnt): Return a size_t value. 2nd arg is now size_t.
6699 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6700 Improve overflow protection. Support `l' modifier for integer
6701 conversions. Support %l conversion. Don't assume an EMACS_INT
6702 argument for integer conversions and for %c.
6703
6704 * lisp.h (doprnt): Restore prototype.
6705
6706 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6707 $(SRC)/character.h.
6708
6709 * Makefile.in (base_obj): Add back doprnt.o.
6710
6711 * deps.mk (doprnt.o): Add back prerequisites.
6712 (callint.o): Depend on character.h.
6713
6714 * eval.c (internal_lisp_condition_case): Include the handler
6715 representation in the error message.
6716 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6717 when breaking from the loop.
6718
6719 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6720
6721 * callint.c (Fcall_interactively): When displaying error message
6722 about invalid control letter, pass the character's codepoint, not
6723 a pointer to its multibyte form. Improve display of the character
6724 in octal and display also its hex code.
6725
6726 * character.c (char_string): Use %x to display the (unsigned)
6727 codepoint of an invalid character, to avoid displaying a bogus
6728 negative value.
6729
6730 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6731 `error', not SYMBOL_NAME itself.
6732
6733 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6734 character arguments to `error'.
6735
6736 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6737 to `error' in error message about FINAL_CHAR argument. Make sure
6738 FINAL_CHAR is a character, and use %c when it is passed as
6739 argument to `error'.
6740
4ffd0d6b 67412011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6742
6743 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6744
6745 * w32.c: Include <time.h>.
6746 (sys_localtime): New function.
6747
4ffd0d6b 67482011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6749
6750 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6751
4ffd0d6b 6752 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6753
4ffd0d6b 67542011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6755
4ffd0d6b
GM
6756 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6757 zombies (Bug#8467).
aac0c6e3 6758
04c56954
EZ
67592011-04-19 Eli Zaretskii <eliz@gnu.org>
6760
6761 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6762 gl_state.e_property when gl_state.object is Qt.
6763
6764 * insdel.c (make_gap_larger): Remove limitation of buffer size
6765 to <= INT_MAX.
6766
16a43933
CY
67672011-04-18 Chong Yidong <cyd@stupidchicken.com>
6768
6769 * xdisp.c (lookup_glyphless_char_display)
6770 (produce_glyphless_glyph): Handle cons cell entry in
6771 glyphless-char-display.
6772 (Vglyphless_char_display): Document it.
6773
6774 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6775 glyphless-char-display.
6776
4581706e
CY
67772011-04-17 Chong Yidong <cyd@stupidchicken.com>
6778
6779 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6780
6781 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6782
6783 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6784 definition for no-X builds.
6785
4887c6e2 67862011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6787
fd35b6f9
PE
6788 Static checks with GCC 4.6.0 and non-default toolkits.
6789
5c1ccb01
PE
6790 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6791
006c5daa
PE
6792 * process.c (keyboard_bit_set): Define only if SIGIO.
6793 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6794 (send_process): Repair possible setjmp clobbering.
6795
efc736d3
PE
6796 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6797
4e2fe2e6
PE
6798 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6799
f97334a2
PE
6800 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6801
4e75f29d
PE
6802 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6803 Define only if needed.
6804
90efadd1
PE
6805 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6806 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6807 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6808
3c647824
PE
6809 * dispextern.h (struct redisplay_interface): Rename param
6810 to avoid shadowing.
e264f262 6811 * termhooks.h (struct terminal): Likewise.
761383f4 6812 * xterm.c (xembed_send_message): Likewise.
3c647824 6813
b58c5c4a
PE
6814 * insdel.c (make_gap_smaller): Define only if
6815 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6816
cad59032
PE
6817 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6818 it.
6819
c339dc2e
PE
6820 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6821 so that we aren't warned about unused symbols.
6822
91a3e27b
PE
6823 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6824
399c71d3 6825 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6826
8ffc96f5
PE
6827 * xfns.c (x_real_positions): Mark locals as initialized.
6828
eef9bc79
PE
6829 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6830
098db9dd
PE
6831 * xterm.c: Fix problems found by static analysis with other toolkits.
6832 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6833 (x_dispatch_event): Declare static if USE_GTK, and
6834 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6835 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6836 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6837 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6838 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6839
eb18f6cc
PE
6840 * xmenu.c (menu_help_callback): Pointer type fixes.
6841 Use const pointers when pointing at readonly data. Avoid pointer
6842 signedness clashes.
6843 (FALSE): Remove unused macro.
6844 (update_frame_menubar): Remove unused decl.
6845
1fe72bf8
PE
6846 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6847
60d9e1db
PE
6848 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6849 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6850 (single_menu_item): Rename local to avoid shadowing.
6851
39261c26
PE
6852 * keyboard.c (make_lispy_event): Remove unused local var.
6853
018c5e19
PE
6854 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6855 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6856
63d2b86e
PE
6857 * bitmaps: Change bitmaps from unsigned char back to the X11
6858 compatible char. Avoid the old compiler warnings about
6859 out-of-range initializers by using, for example, '\xab' rather
6860 than 0xab.
6861
aefd87e1
PE
6862 * xgselect.c (xgselect_initialize): Check vs interface
6863 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6864
bf501fb9
PE
6865 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6866
e9829fdf
PE
6867 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6868 to read-only memory.
6869
1086c095
PE
6870 * fns.c (vector): Remove; this old hack is no longer needed.
6871
2baccd04 6872 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6873 Remove unused var.
dde42981 6874 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6875
72391843 6876 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6877
436c16df 6878 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6879 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6880 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6881
92bb796d 6882 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6883 (x_term_init): Remove local to avoid shadowing.
92bb796d 6884
764430a3 6885 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6886
6887 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6888 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6889
d1dfb56c
EZ
68902011-04-16 Eli Zaretskii <eliz@gnu.org>
6891
c4354cb4
EZ
6892 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6893
d1dfb56c
EZ
6894 Fix regex.c, syntax.c and friends for buffers > 2GB.
6895 * syntax.h (struct gl_state_s): Declare character position members
6896 EMACS_INT.
6897
6898 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6899
04f2d78b
CB
6900 * textprop.c (verify_interval_modification, interval_of):
6901 Declare arguments EMACS_INT.
d1dfb56c
EZ
6902
6903 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6904 EMACS_INT.
6905
6906 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6907
6908 * indent.c (Fvertical_motion): Local variable it_start is now
6909 EMACS_INT.
6910
6911 * regex.c (re_match, re_match_2, re_match_2_internal)
6912 (bcmp_translate, regcomp, regexec, print_double_string)
6913 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6914 (re_compile_pattern, re_exec): Declare arguments and local
6915 variables `size_t' and `ssize_t' and return values `regoff_t', as
6916 appropriate.
6917 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6918 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6919 <compile_stack_type>: `size' and `avail' are now `size_t'.
6920
6921 * regex.h <regoff_t>: Use ssize_t, not int.
6922 (re_search, re_search_2, re_match, re_match_2): Arguments that
6923 specify buffer/string position and length are now ssize_t and
6924 size_t. Return type is regoff_t.
6925
613052cd
BK
69262011-04-16 Ben Key <bkey76@gmail.com>
6927
6928 * nsfont.m: Fixed bugs in ns_get_family and
6929 ns_descriptor_to_entity that were caused by using free to
6930 deallocate memory blocks that were allocated by xmalloc (via
6931 xstrdup). This caused Emacs to crash when compiled with
6932 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6933 --enable-checking=xmallocoverrun). xfree is now used to
6934 deallocate these memory blocks.
6935
4170f62f 69362011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6937
71b41406
PE
6938 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6939
9587a89d
PE
6940 emacs_write: Accept and return EMACS_INT for sizes.
6941 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6942 et seq.
6943 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6944 Accept and return EMACS_INT.
6945 (emacs_gnutls_write): Return the number of bytes written on
6946 partial writes.
6947 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6948 (emacs_read, emacs_write): Remove check for negative size, as the
6949 Emacs source code has been audited now.
9587a89d
PE
6950 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6951 (emacs_read, emacs_write): Use it.
273a5f82
PE
6952 * process.c (send_process): Adjust to the new signatures of
6953 emacs_write and emacs_gnutls_write. Do not attempt to store
6954 a byte offset into an 'int'; it might overflow.
9587a89d 6955 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6956
3e047f51
PE
6957 * sound.c: Don't assume sizes fit in 'int'.
6958 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6959 Return EMACS_INT, not int.
3e047f51 6960 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6961 Accept EMACS_INT, not int.
6962 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6963 record read return values.
6964
cc39a9db
BK
69652011-04-15 Ben Key <bkey76@gmail.com>
6966
c9d0ec6d
JB
6967 * keyboard.c (Qundefined): Don't declare static since it is used
6968 in nsfns.m.
6969 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6970 static since they are used in nsfont.m.
cc39a9db 6971
6c60eb9f
SM
69722011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6973
6974 * process.c (Qprocessp): Don't declare static.
6975 * lisp.h (Qprocessp): Declare again.
6976
7990b61a
JB
69772011-04-15 Juanma Barranquero <lekktu@gmail.com>
6978
6979 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6980
5d4cb038
PE
69812011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6982
8bd7b830 6983 Improve C-level modularity by making more things 'static'.
cd64ea1d 6984
e3b27b31
PE
6985 Don't publish debugger-only interfaces to other modules.
6986 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6987 (verify_bytepos, count_markers): Move decls to the only modules
6988 that need them.
6989 * region-cache.h (pp_cache): Likewise.
6990 * window.h (check_all_windows): Likewise.
6991 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6992
5d4cb038
PE
6993 * sysdep.c (croak): Now static, if
6994 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6995 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6996
6997 * alloc.c (refill_memory_reserve): Now static if
6998 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6999 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7000
e87b6180
PE
7001 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7002 Define only if USE_LUCID.
7003
ac64929e
PE
7004 * xrdb.c (x_customization_string, x_rm_string): Now static.
7005
6f37259d
PE
7006 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7007 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7008
1683e3ab
PE
7009 * xdisp.c (draw_row_with_mouse_face): Now static.
7010 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7011
de9c2632
PE
7012 * window.h (check_all_windows): Mark externally visible.
7013
2b96acb7
PE
7014 * window.c (window_deletion_count): Now static.
7015
7016 * undo.c: Make symbols static if they're not exported.
7017 (last_undo_buffer, last_boundary_position, pending_boundary):
7018 Now static.
7019
50436f33
PE
7020 * textprop.c (interval_insert_behind_hooks): Now static.
7021 (interval_insert_in_front_hooks): Likewise.
7022
64520e5c
PE
7023 * term.c: Make symbols static if they're not exported.
7024 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7025 (max_frame_lines, tty_set_terminal_modes):
7026 (tty_reset_terminal_modes, tty_turn_off_highlight):
7027 (get_tty_terminal): Now static.
7028 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7029 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7030 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7031 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7032 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7033
1fa53021
PE
7034 * sysdep.c: Make symbols static if they're not exported.
7035 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7036 Now static.
7037 (sigprocmask_set, full_mask): Remove; unused.
7038 (wait_debugging): Mark as visible.
7039 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7040 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7041
d4b43b22
PE
7042 * syntax.c (syntax_temp): Define only if !__GNUC__.
7043
b7c513d0
PE
7044 * sound.c (current_sound_device, current_sound): Now static.
7045
989b29ad
PE
7046 * search.c (searchbufs, searchbuf_head): Now static.
7047
13a55a78
PE
7048 * scroll.c (scroll_cost): Remove; unused.
7049 * dispextern.h (scroll_cost): Remove decl.
7050
de68a1fc
PE
7051 * region-cache.h (pp_cache): Mark as externally visible.
7052
40ccffa6
PE
7053 * process.c: Make symbols static if they're not exported.
7054 (process_tick, update_tick, create_process, chan_process):
7055 (Vprocess_alist, proc_buffered_char, datagram_access):
7056 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7057 (deactivate_process): Mark defn as static, as well as decl.
7058 * lisp.h (create_process): Remove decl.
7059 * process.h (chan_process, Vprocess_alist): Remove decls.
7060
ad64fc97
PE
7061 * print.c: Make symbols static if they're not exported.
7062 (print_depth, new_backquote_output, being_printed, print_buffer):
7063 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7064 (print_interval, print_number_index, initial_stderr_stream):
7065 Now static.
7066 * lisp.h (Fprinc): Remove decl.
7067 (debug_output_compilation_hack): Mark as externally visible.
7068
adddb265
PE
7069 * sysdep.c (croak): Move decl from here to syssignal.h.
7070 * syssignal.h (croak): Put it here, so the API can be checked when
7071 'croak' is called from dissociate_if_controlling_tty.
7072
1717ede2
PE
7073 * minibuf.c: Make symbols static if they're not exported.
7074 (minibuf_save_list, choose_minibuf_frame): Now static.
7075 * lisp.h (choose_minibuf_frame): Remove decl.
7076
fa5fb2bc
PE
7077 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7078
1e3890d1
PE
7079 * lread.c: Make symbols static if they're not exported.
7080 (read_objects, initial_obarray, oblookup_last_bucket_number):
7081 Now static.
7082 (make_symbol): Remove; unused.
7083 * lisp.h (initial_obarray, make_symbol): Remove decls.
7084
8a1414fa
PE
7085 * keyboard.c: Make symbols static if they're not exported.
7086 (single_kboard, recent_keys_index, total_keys, recent_keys):
7087 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7088 (this_single_command_key_start, echoing, last_auto_save):
7089 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7090 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7091 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7092 (Vlispy_mouse_stem, double_click_count):
7093 Now static.
7094 (force_auto_save_soon): Define only if SIGDANGER.
7095 (ignore_mouse_drag_p): Now static if
7096 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7097 (print_help): Remove; unused.
7098 (stop_character, last_timer_event): Mark as externally visible.
7099 * keyboard.h (ignore_mouse_drag_p): Declare only if
7100 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7101 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7102 * lisp.h (echoing): Remove decl.
7103 (force_auto_save_soon): Declare only if SIGDANGER.
7104 * xdisp.c (redisplay_window): Simplify code, to make it more
7105 obvious that ignore_mouse_drag_p is not accessed if !defined
7106 USE_GTK && !defined HAVE_NS.
7107
93ea6e8f
PE
7108 * intervals.c: Make symbols static if they're not exported.
7109 (merge_properties_sticky, merge_interval_right, delete_interval):
7110 Now static.
7111 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7112
77382fcc
PE
7113 * insdel.c: Make symbols static if they're not exported.
7114 However, leave prepare_to_modify_buffer alone. It's never
7115 called from outside this function, but that appears to be a bug.
7116 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7117 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7118 (adjust_after_replace_noundo): Remove; unused.
7119 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7120 (signal_before_change): Remove decls.
77382fcc 7121
9306c32e
PE
7122 * indent.c (val_compute_motion, val_vmotion): Now static.
7123
cd44d2eb
PE
7124 * image.c: Make symbols static if they're not exported.
7125 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7126 if USE_GTK.
7127 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7128 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7129
ad9a7a06
PE
7130 * fringe.c (standard_bitmaps): Now static.
7131 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7132
81626931
PE
7133 * frame.c: Make symbols static if they're not exported.
7134 (x_report_frame_params, make_terminal_frame): Now static.
7135 (get_frame_param): Now static, unless HAVE_NS.
7136 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7137 (x_get_resource_string): Remove; not used.
7138 * frame.h (make_terminal_frame, x_report_frame_params):
7139 (x_get_resource_string); Remove decls.
7140 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7141 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7142
239f9db9
PE
7143 * font.c, fontset.c: Make symbols static if they're not exported.
7144 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7145 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7146 * font.c (font_close_object): Now static.
7147 * font.h (font_close_object): Remove.
7148 * fontset.c (FONTSET_OBJLIST): Remove.
7149 (free_realized_fontset) #if-0 the body, which does nothing.
7150 (face_suitable_for_char_p): #if-0, as it's never called.
7151 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7152 * xfaces.c (face_at_string_position):
7153 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7154 since 0 is always ASCII.
7155
dfcf3579
PE
7156 * fns.c (weak_hash_tables): Now static.
7157
5045092b
PE
7158 * fileio.c: Make symbols static if they're not exported.
7159 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7160 (Vwrite_region_annotation_buffers): Now static.
7161
57a96f5c
PE
7162 * eval.c: Make symbols static if they're not exported.
7163 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7164 * lisp.h (backtrace_list): Remove decl.
7165
35f08c38
PE
7166 * emacs.c: Make symbols static if they're not exported.
7167 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7168 (fatal_error_code, fatal_error_signal_hook, standard_args):
7169 Now static.
7170 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7171 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7172 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7173 * lisp.h (fatal_error_signal_hook): Remove decl.
7174 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7175
f44bd759
PE
7176 * editfns.c: Move a (normally-unused) function to its only use.
7177 * editfns.c, lisp.h (get_operating_system_release): Remove.
7178 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7179 worth the hassle of breaking this out.
7180
b532497d
PE
7181 * xterm.c: Make symbols static if they're not exported.
7182 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7183 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7184 (x_destroy_window, x_delete_display):
7185 Now static.
7186 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7187 (x_mouse_leave): Remove; unused.
7188 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7189 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7190 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7191 Remove decls.
7192 (x_mouse_leave): Declare only if WINDOWSNT.
7193 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7194 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7195 USE_X_TOOLKIT.
7196
1675728f
PE
7197 * ftxfont.c: Make symbols static if they're not exported.
7198 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7199 HAVE_FREETYPE.
7200 * font.h (ftxfont_driver): Likewise.
7201
e4cebfca
PE
7202 * xfns.c: Make symbols static if they're not exported.
7203 (x_last_font_name, x_display_info_for_name):
7204 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7205 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7206 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7207 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7208 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7209 (last_show_tip_args): Now static.
7210 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7211 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7212 (x_screen_planes): Remove; unused.
7213 * dispextern.h (x_screen_planes): Remove decl.
7214
5bf46f05
PE
7215 * dispnew.c: Make symbols static if they're not exported.
7216 * dispextern.h (redraw_garbaged_frames, scrolling):
7217 (increment_row_positions): Remove.
7218 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7219 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7220 Now static.
7221 (redraw_garbaged_frames): Remove; unused.
7222
435f4c28
PE
7223 * xfaces.c: Make symbols static if they're not exported.
7224 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7225 Remove decls.
7226 * xterm.h (defined_color): Remove decls.
7227 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7228 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7229 (menu_face_changed_default, defined_color, free_realized_face):
7230 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7231 (ascii_face_of_lisp_face): Remove; unused.
7232
8524aef3
PE
7233 * xdisp.c: Make symbols static if they're not exported.
7234 * dispextern.h (scratch_glyph_row, window_box_edges):
7235 (glyph_to_pixel_coords, set_cursor_from_row):
7236 (get_next_display_element, set_iterator_to_next):
7237 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7238 (show_mouse_face): Remove decls
7239 * frame.h (message_buf_print): Likewise.
7240 * lisp.h (pop_message, set_message, check_point_in_composition):
7241 Likewise.
7242 * xterm.h (set_vertical_scroll_bar): Likewise.
7243 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7244 (message_buf_print, scratch_glyph_row, displayed_buffer):
7245 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7246 (get_next_display_element, show_mouse_face, window_box_edges):
7247 (frame_to_window_pixel_xy, check_point_in_composition):
7248 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7249 (glyph_to_pixel_coords): Remove; unused.
7250
16390cd2
PE
7251 * dired.c (file_name_completion): Now static.
7252
7253 * dbusbind.c (xd_in_read_queued_messages): Now static.
7254
a25f4dfa
PE
7255 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7256 * data.c (circular_list_error): Remove.
7257
14a9c8df
PE
7258 * commands.h (last_point_position, last_point_position_buffer):
7259 (last_point_position_window): Remove decls.
7260 * keyboard.c: Make these variables static.
7261
04f2d78b
CB
7262 * coding.h (coding, code_convert_region, encode_coding_gap):
7263 Remove decls.
74ab6df5
PE
7264 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7265 (iso_code_class, detect_coding, code_convert_region): Now static.
7266 (encode_coding_gap): Remove; unused.
7267
38dfbee1
PE
7268 * chartab.c (chartab_chars, chartab_bits): Now static.
7269
a2cb4e63
PE
7270 * charset.h (charset_iso_8859_1): Remove decl.
7271 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7272 Now static.
7273
127198fd
PE
7274 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7275 * ccl.c (Vccl_program_table): Now static.
7276 (check_ccl_update): Remove; unused.
7277
d85b608f
PE
7278 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7279 * category.h: ... from here.
7280 * category.c (check_category_table, set_category_set): Now static.
7281
31cd66f3
PE
7282 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7283 * lisp.h: Remove these decls.
7284
c358e587
PE
7285 * buffer.c (buffer_count): Remove unused var.
7286
e78aecca
PE
7287 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7288 so that it's not optimized away.
7289 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7290 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7291 exported only to the debugger.
7292
e192d7d3 7293 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7294 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7295
92470028
PE
7296 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7297 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7298 was inaccessible from Lisp.
7299 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7300 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7301
244ed907
PE
7302 alloc.c: Import and export fewer symbols, and remove unused items.
7303 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7304 is defined.
7305 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7306 it's not optimized away by whole-program optimization.
7307 (message_enable_multibyte, free_misc): Remove.
7308 (catchlist, handlerlist, mark_backtrace):
7309 Declare only if BYTE_MARK_STACK.
7310 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7311 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7312 (message_enable_multibyte): Remove decl.
7313 (free_misc, interval_free_list, float_block, float_block_index):
7314 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7315 (cons_free_list, last_marked_index):
7316 Now static.
7317 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7318 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7319 (mark_backtrace): Define only if BYTE_MARK_STACK.
7320 * xdisp.c (message_enable_multibyte): Now static.
7321
61c2b50e 7322 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7323 This makes it easier for human readers (and static analyzers)
7324 to see whether these variables are used from other modules.
7325 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7326 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7327 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7328 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7329 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7330 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7331 * xmenu.c, xselect.c:
7332 Declare Q* vars static if they are not used in other modules.
7333 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7334 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7335 Remove decls of unexported vars.
7336 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7337
95c82688
PE
7338 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7339
16a97296
PE
7340 Make Emacs functions such as Fatom 'static' by default.
7341 This makes it easier for human readers (and static analyzers)
7342 to see whether these functions can be called from other modules.
7343 DEFUN now defines a static function. To make the function external
7344 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7345 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7346 (Finit_image_library):
16a97296
PE
7347 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7348 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7349 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7350 Remove decls, since these functions are now static.
7351 (Funintern, Fget_internal_run_time): New decls, since these functions
7352 were already external.
95c82688 7353
16a97296
PE
7354 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7355 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7356 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7357 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7358 * keyboard.c, keymap.c, lread.c:
7359 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7360 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7361 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7362 Mark functions with DEFUE instead of DEFUN,
7363 if they are used in other modules.
7364 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7365 decls for now-static functions.
7366 * buffer.h (Fdelete_overlay): Remove decl.
7367 * callproc.c (Fgetenv_internal): Mark as internal.
7368 * composite.c (Fremove_list_of_text_properties): Remove decl.
7369 (Fcomposition_get_gstring): New forward static decl.
7370 * composite.h (Fcomposite_get_gstring): Remove decl.
7371 * dired.c (Ffile_attributes): New forward static decl.
7372 * doc.c (Fdocumntation_property): New forward static decl.
7373 * eval.c (Ffetch_bytecode): New forward static decl.
7374 (Funintern): Remove extern decl; now in .h file where it belongs.
7375 * fileio.c (Fmake_symbolic_link): New forward static decl.
7376 * image.c (Finit_image_library): New forward static decl.
7377 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7378 * intervals.h (Fprevious_property_change):
7379 (Fremove_list_of_text_properties): Remove decls.
7380 * keyboard.c (Fthis_command_keys): Remove decl.
7381 (Fcommand_execute): New forward static decl.
7382 * keymap.c (Flookup_key): New forward static decl.
7383 (Fcopy_keymap): Now static.
7384 * keymap.h (Flookup_key): Remove decl.
7385 * process.c (Fget_process): New forward static decl.
7386 (Fprocess_datagram_address): Mark as internal.
7387 * syntax.c (Fsyntax_table_p): New forward static decl.
7388 (skip_chars): Remove duplicate decl.
7389 * textprop.c (Fprevious_property_change): New forward static decl.
7390 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7391 Now internal.
7392 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7393 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7394
785bbd42
PE
7395 * editfns.c (Fformat): Remove unreachable code.
7396
8b913b57
AS
73972011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7398
7399 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7400 change. (Bug#8496)
7401
a6744a35
EZ
74022011-04-13 Eli Zaretskii <eliz@gnu.org>
7403
7404 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7405 when at ZV. (Bug#8487)
7406
e7974947
AS
74072011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7408
baad03f0
AS
7409 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7410 (Bug#8437)
7411 * keyboard.c (parse_tool_bar_item): Likewise.
7412 * sound.c (sound_cleanup, alsa_close): Likewise.
7413 * termcap.c (tgetent): Likewise.
7414 * xfns.c (x_default_font_parameter): Likewise.
7415 * xsettings.c (read_and_apply_settings): Likewise.
7416
e7974947
AS
7417 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7418 (overrun_check_free): Protoize.
7419
28272684
PE
74202011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7421
7422 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7423 since callers should never pass a negative size.
7424 Change the signature to match that of plain 'read' and 'write'; see
7425 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7426 * lisp.h: Update prototypes of emacs_write and emacs_read.
7427
11997c76
EZ
74282011-04-11 Eli Zaretskii <eliz@gnu.org>
7429
7430 * xdisp.c (redisplay_window): Don't try to determine the character
7431 position of the scroll margin if the window start point w->startp
e896f03c 7432 is outside the buffer's accessible region. (Bug#8468)
11997c76 7433
8a2cbd72
EZ
74342011-04-10 Eli Zaretskii <eliz@gnu.org>
7435
7436 Fix write-region and its subroutines for buffers > 2GB.
7437 * fileio.c (a_write, e_write): Modify declaration of arguments and
7438 local variables to support buffers larger than 2GB.
7439 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7440
7441 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7442 argument, local variables, and return value.
7443
7444 * lisp.h: Update prototypes of emacs_write and emacs_read.
7445
7446 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7447
4073e537 74482011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7449
1ebfdcb6
PE
7450 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7451
b2ded58d
PE
7452 Fix more problems found by GCC 4.6.0's static checks.
7453
7d66342c
PE
7454 * xdisp.c (vmessage): Use a better test for character truncation.
7455
bbf47d44
PE
7456 * charset.c (load_charset_map): <, not <=, for optimization,
7457 and to avoid potential problems with integer overflow.
9248994d 7458 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7459 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7460 * editfns.c (Fformat): Likewise.
1e69125e 7461 * syntax.c (skip_chars): Likewise.
3befa583 7462
e3019616
PE
7463 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7464 This also lets GCC 4.6.0 generate slightly better loop code.
7465
becfa255
PE
7466 * callint.c (Fcall_interactively): <, not <=, for optimization.
7467 (Fcall_interactively): Count the number of arguments produced,
7468 not the number of arguments given. This is simpler and lets GCC
7469 4.6.0 generate slightly better code.
7470
dae0cd48
PE
7471 * ftfont.c: Distingish more carefully between FcChar8 and char.
7472 The previous code passed unsigned char * to a functions like
7473 strlen and xstrcasecmp that expect char *, which does not
7474 conform to the C standard.
7475 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7476 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7477 char * when the C standard requires it.
7478
76032d70
PE
7479 * keyboard.c (read_char): Remove unused var.
7480
eb3f1cc8
PE
7481 * eval.c: Port to Windows vsnprintf (Bug#8435).
7482 Include <limits.h>.
7483 (SIZE_MAX): Define if the headers do not.
7484 (verror): Do not give up if vsnprintf returns a negative count.
7485 Instead, grow the buffer. This ports to Windows vsnprintf, which
7486 does not conform to C99. Problem reported by Eli Zaretskii.
7487 Also, simplify the allocation scheme, by avoiding the need for
7488 calling realloc, and removing the ALLOCATED variable.
7489
70476b54
PE
7490 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7491
12020a9e
PE
7492 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7493 But keep the doprint source code for now, as we might revamp it
7494 and use it again (Bug#8435).
ea6c7ae6
PE
7495 * lisp.h (doprnt): Remove.
7496 * Makefile.in (base_obj): Remove doprnt.o.
7497 * deps.mk (doprnt.o): Remove.
7498
5fdb398c
PE
7499 error: Print 32- and 64-bit integers portably (Bug#8435).
7500 Without this change, on typical 64-bit hosts error ("...%d...", N)
7501 was used to print both 32- and 64-bit integers N, which relied on
7502 undefined behavior.
7503 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7504 New macro.
7505 * lisp.h (error, verror): Mark as printf-like functions.
7506 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7507 Report overflow in size calculations when allocating printf buffer.
7508 Do not truncate output string at its first null byte.
7509 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7510 Truncate the output at a character boundary, since vsnprintf does not
7511 do that.
7512 * charset.c (check_iso_charset_parameter): Convert internal
7513 character to string before calling 'error', since %c now has the
7514 printf meaning.
7515 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7516 overflow when computing char to be passed to 'error'. Do not
7517 pass Lisp_Object to 'error'; pass the integer instead.
7518 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7519 formatted with plain %d.
7520
b189fa66
PE
7521 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7522
bff87ef0
PE
7523 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7524
7e2cac20
PE
7525 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7526
ce4d90b5
PE
7527 * xterm.c (x_catch_errors): Remove duplicate declaration.
7528
266c9547
PE
7529 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7530
79c49ad2
PE
7531 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7532
368f4090
JM
75332011-04-10 Jim Meyering <meyering@redhat.com>
7534
7535 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7536 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7537 return ssize_t not "int", and use size_t as the buffer length.
7538 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7539 * gnutls.h: Update declarations.
7540 * process.c (read_process_output): Use ssize_t, to match.
7541 (send_process): Likewise.
7542
a32d4040
CY
75432011-04-09 Chong Yidong <cyd@stupidchicken.com>
7544
7545 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7546
8546720e 75472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7548
04f2d78b
CB
7549 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7550 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7551
8546720e
GM
7552 * xterm.c (handle_one_xevent):
7553 * xmenu.c (create_and_show_popup_menu):
7554 * xselect.c (x_decline_selection_request)
7555 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7556
0a2f5c1a 75572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7558
7559 Fix some uses of `int' instead of EMACS_INT.
7560 * search.c (string_match_1, fast_string_match)
7561 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7562 (scan_buffer, find_next_newline_no_quit)
7563 (find_before_next_newline, search_command, Freplace_match)
7564 (Fmatch_data): Make some `int' variables be EMACS_INT.
7565
7566 * xdisp.c (display_count_lines): 3rd argument and return value now
7567 EMACS_INT. All callers changed.
7568 (pint2hrstr): Last argument is now EMACS_INT.
7569
7570 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7571 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7572 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7573 (decode_coding_utf_16, decode_coding_emacs_mule)
7574 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7575 (decode_coding_ccl, decode_coding_charset)
7576 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7577 (decode_coding_iso_2022, decode_coding_emacs_mule)
7578 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7579 <char_offset, last_offset>: Declare EMACS_INT.
7580 (encode_coding_utf_8, encode_coding_utf_16)
7581 (encode_coding_emacs_mule, encode_invocation_designation)
7582 (encode_designation_at_bol, encode_coding_iso_2022)
7583 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7584 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7585 Declare EMACS_INT.
7586 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7587 (encode_invocation_designation): Last argument P_NCHARS is now
7588 EMACS_INT.
7589 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7590 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7591
7592 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7593 All users changed.
7594
7595 * ccl.c (Fccl_execute_on_string): Declare some variables
7596 EMACS_INT.
7597
8546720e 75982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7599
7600 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7601
4e19a977
CS
76022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7603
7604 * process.c (Fformat_network_address): Doc fix.
7605
87302331
R
76062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7607
ee7683eb 7608 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7609
cbb59342
CY
76102011-04-08 Chong Yidong <cyd@stupidchicken.com>
7611
7612 * keyboard.c (read_char): Call Lisp function help-form-show,
7613 instead of using internal_with_output_to_temp_buffer.
7614 (Qhelp_form_show): New var.
e0d38eeb 7615 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7616
7617 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7618
7619 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7620
e67a13ab
CY
76212011-04-06 Chong Yidong <cyd@stupidchicken.com>
7622
04f2d78b
CB
7623 * process.c (Flist_processes): Remove to Lisp.
7624 (list_processes_1): Delete.
e67a13ab 7625
973f782d
EZ
76262011-04-06 Eli Zaretskii <eliz@gnu.org>
7627
7c106b1e
EZ
7628 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7629
973f782d
EZ
7630 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7631
41cf7d1a 76322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7633
ca23cc88
PE
7634 Fix more problems found by GCC 4.6.0's static checks.
7635
f390e2d5
PE
7636 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7637
42eea0d0
PE
7638 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7639
b69769da 7640 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7641
f9541e84
PE
7642 * xdisp.c (vmessage): Mark as a printf-like function.
7643
13841b55
PE
7644 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7645
c136c10f
PE
7646 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7647
5e2d4a30
PE
7648 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7649 printf-like functions.
7650 (tiff_load): Add casts to remove these marks before passing them
7651 to system-supplied API.
7652
583f48b9
PE
7653 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7654
b25d760e
PE
7655 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7656 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7657 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7658 directly, rather than having caller test rule sign. This avoids
7659 some unnecessary tests.
7660 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7661 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7662 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7663
bc7b6697 7664 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7665 (xfont_open): Avoid unnecessary tests.
bc7b6697 7666
27ccc379
PE
7667 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7668
dcd5c89a
PE
7669 * composite.h, composite.c (composition_gstring_put_cache):
7670 Use EMACS_INT, not int, for length.
7671
b13a45c6
PE
7672 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7673 breaking out part of COMPOSITION_DECODE_RULE.
7674 (COMPOSITION_DECODE_RULE): Use it.
7675 * composite.c (get_composition_id): Remove unused local vars,
7676 by using the new macro.
7677
1e792e4d
PE
7678 * textprop.c (set_text_properties_1): Change while to do-while,
7679 since the condition is always true at first.
7680
dc6c6455 7681 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7682 (interval_deletion_adjustment): Return unsigned value.
7683 All uses changed.
dc6c6455 7684
aba7731a
PE
7685 * process.c (list_processes_1, create_pty, read_process_output):
7686 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7687 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7688 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7689 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7690 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7691
fdfc4bf3
PE
7692 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7693
fca8fe46 7694 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7695 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7696
06a0259a 7697 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7698 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7699 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7700
e7b9e80f
PE
7701 * print.c (print_error_message): Avoid int overflow.
7702
56201685
PE
7703 * font.c (font_list_entities): Redo for clarity,
7704 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7705
78834453 7706 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7707 (font_score): Avoid potential overflow in diff calculation.
78834453 7708
0bc0b309 7709 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7710 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7711
e610eaca
PE
7712 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7713
b895abce
PE
7714 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7715 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7716 can always succeed if overflow has undefined behavior.
7717
1f1d9321 7718 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7719 (wordify): Omit three unnecessary tests.
1f1d9321 7720
c59478bc
PE
7721 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7722 All callers changed. This avoids the need for an unused var.
7723
79b73827
PE
7724 * casefiddle.c (casify_region): Remove var that is set but not used.
7725
a4db5dfe
PE
7726 * dired.c (file_name_completion): Remove var that is set but not used.
7727
43aae36e
PE
7728 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7729
2a47c44d 7730 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7731 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7732
a37c69bf
PE
7733 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7734 Check for integer overflow on size calculations.
7735
328ab8e7
PE
7736 * buffer.c (Fprevious_overlay_change): Remove var that is set
7737 but not used.
7738
e5a2a5cb
PE
7739 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7740 Remove vars that are set but not used.
8d84a6eb 7741 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7742 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7743
a60e5f68
PE
7744 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7745
f661cb61 7746 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7747 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7748
f0397f5a
PE
7749 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7750 that are set but not used.
7751
8664db06 7752 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7753 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7754
6abdaa4a
PE
7755 * xselect.c (x_get_local_selection, x_handle_property_notify):
7756 Remove vars that are set but not used.
7757
0ce7538d 7758 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7759 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7760
9ae848fc
PE
7761 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7762 Remove var that is set but not used.
0b918413
PE
7763 (scroll_bar_windows_size): Now size_t, not int.
7764 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7765 Check for overflow.
9ae848fc 7766
a5a62657
PE
7767 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7768 (map_tty_color) [!defined MSDOS]: Likewise.
7769
5c5cdd39
PE
7770 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7771
66ebf983
PE
7772 * coding.c: Remove vars that are set but not used.
7773 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7774 All callers changed.
7775 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7776 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7777 (decode_coding_charset): Remove vars that are set but not used.
7778
1be4d761
PE
7779 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7780 that is set but not used.
7781
47553fa8
PE
7782 * print.c (print_object): Remove var that is set but not used.
7783
1f7196bf 7784 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7785 The gnulib version avoids calling malloc in the usual case,
7786 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7787 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7788 * filelock.c (current_lock_owner): Likewise.
7789 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7790 * sysdep.c: Include allocator.h, careadlinkat.h.
7791 (emacs_no_realloc_allocator): New static constant.
7792 (emacs_readlink): New function.
fdb61804
PE
7793 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7794 ../lib/careadlinkat.h.
d1fdcab7 7795
f84c17c7
SM
77962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7797
7798 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7799 first non-nil return value).
7800
ef3862ad
JD
78012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7802
7803 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7804 if not defined (Bug#8403).
7805
376a7006
JB
78062011-04-02 Juanma Barranquero <lekktu@gmail.com>
7807
7808 * xdisp.c (display_count_lines): Remove parameter `start',
7809 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7810 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7811 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7812 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7813 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7814 and thereabouts. All callers changed.
7815 (get_per_char_metric): Remove parameter `f', unused since
7816 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7817
6ca3801d
JM
78182011-04-02 Jim Meyering <meyering@redhat.com>
7819
7820 do not dereference NULL upon failed strdup
7821 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7822 (ns_get_family): Likewise.
7823
d8e2b5ba
JB
78242011-04-02 Juanma Barranquero <lekktu@gmail.com>
7825
7826 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7827
8c74fcbd
JD
78282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7829
7830 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7831 later (Bug#8403).
7832
7200d79c
SM
78332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7834
03408648 7835 Add lexical binding.
7200d79c 7836
03408648
SM
7837 * window.c (Ftemp_output_buffer_show): New fun.
7838 (Fsave_window_excursion):
7839 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7840
7841 * lread.c (lisp_file_lexically_bound_p): New function.
7842 (Fload): Bind Qlexical_binding.
7843 (readevalloop): Remove `evalfun' arg.
7844 Bind Qinternal_interpreter_environment.
7845 (Feval_buffer): Bind Qlexical_binding.
7846 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7847 Mark as dynamic.
7848 (syms_of_lread): Declare `lexical-binding'.
7849
7850 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7851
7852 * keyboard.c (eval_dyn): New fun.
7853 (menu_item_eval_property): Use it.
ca105506
SM
7854
7855 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7856
03408648
SM
7857 * fns.c (concat, mapcar1): Accept byte-code-functions.
7858
7859 * eval.c (Fsetq): Handle lexical vars.
7860 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7861 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7862 (FletX, Flet): Obey lexical binding.
7863 (Fcommandp): Handle closures.
7864 (Feval): New `lexical' arg.
7865 (eval_sub): New function extracted from Feval. Use it almost
7866 everywhere where Feval was used. Look up vars in lexical env.
7867 Handle closures.
7868 (Ffunctionp): Move from subr.el.
7869 (Ffuncall): Handle closures.
7870 (apply_lambda): Remove `eval_flags'.
7871 (funcall_lambda): Handle closures and new byte-code-functions.
7872 (Fspecial_variable_p): New function.
7873 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7874 but without exporting it to Lisp.
23aba0ea 7875
23aba0ea 7876 * doc.c (Fdocumentation, store_function_docstring):
03408648 7877 * data.c (Finteractive_form): Handle closures.
23aba0ea 7878
03408648
SM
7879 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7880 interactive spec.
ba83908c 7881
04f2d78b
CB
7882 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7883 New byte-codes.
03408648
SM
7884 (exec_byte_code): New function extracted from Fbyte_code to handle new
7885 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7886
03408648 7887 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7888
03408648 7889 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7890
e2abce01
JB
78912011-03-31 Juanma Barranquero <lekktu@gmail.com>
7892
7893 * xdisp.c (redisplay_internal): Fix prototype.
7894
63696a73 78952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7896
63696a73 7897 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7898 (try_scrolling): Use it when setting scroll_limit.
7899 Limit scrolling to 100 screen lines.
63696a73
EZ
7900 (redisplay_window): Even when falling back on "recentering",
7901 position point in the window according to scroll-conservatively,
7902 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7903
7904 (try_scrolling): When point is above the window, allow searching
7905 as far as scroll_max, or one screenful, to compute vertical
7906 distance from PT to the scroll margin position. This prevents
7907 try_scrolling from unnecessarily failing when
7908 scroll-conservatively is set to a value slightly larger than the
7909 window height. Clean up the case of PT below the margin at bottom
7910 of window: scroll_max can no longer be INT_MAX. When aggressive
7911 scrolling is in use, don't let point enter the opposite scroll
7912 margin as result of the scroll.
7913 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7914 threshold of 100 lines for never-recentering scrolling.
7915
e4cc2dfc
JB
79162011-03-31 Juanma Barranquero <lekktu@gmail.com>
7917
7918 * dispextern.h (move_it_by_lines):
7919 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7920 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7921 (message_log_check_duplicate): Remove parameters `prev_bol' and
7922 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7923 (redisplay_internal): Remove parameter `preserve_echo_area',
7924 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7925
7926 * indent.c (Fvertical_motion):
7927 * window.c (window_scroll_pixel_based, Frecenter):
7928 Don't pass `need_y_p' to `move_it_by_lines'.
7929
1c470562
SM
79302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7931
44f230aa
SM
7932 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7933 steal a few bits to be more compact.
7934 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7935 Remove unneeded casts.
7936
1c470562
SM
7937 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7938
888adce9
ZK
79392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7940
7941 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7942 binding" message (bug#7967).
7943
f838ed7b
PE
79442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7945
77861b95
PE
7946 Fix more problems found by GCC 4.6.0's static checks.
7947
de6dbc14
PE
7948 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7949 Remove unused local var.
7950
f838ed7b
PE
7951 * editfns.c (Fmessage_box): Remove unused local var.
7952
792c7b2b
PE
7953 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7954 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7955 Omit unused local vars.
c499e557 7956 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7957 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7958 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7959 Omit unused local var.
7960
ba0165e1
PE
7961 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7962 Don't assume string length fits in int.
32ad8845 7963 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7964 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7965
3c59b4c9
PE
7966 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7967 instead of alloca (Bug#8344).
7968
a3eed478 7969 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7970 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7971
eb4d412d
PE
7972 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7973
1658b401
PE
7974 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7975 concerns.
7976
7977 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7978
7979 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7980
9a2c6e05
PE
7981 * keyboard.c (syms_of_keyboard): Use the same style as later
7982 in this function when indexing through an array. This also
7983 works around GCC bug 48267.
7984
03d0a109
PE
7985 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7986
44f730c8
PE
7987 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7988
fe75f926
PE
7989 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7990 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7991
ffa8c828
PE
7992 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7993 This avoids undefined behavior on integer overflow, and is a bit
7994 more convenient anyway since it is compared to a size_t variable.
7995
c5101a77
PE
7996 Variadic C functions now count arguments with size_t, not int.
7997 This avoids an unnecessary limitation on 64-bit machines, which
7998 caused (substring ...) to crash on large vectors (Bug#8344).
7999 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8000 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8001 All variadic functions and their callers changed accordingly.
c5101a77
PE
8002 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8003 * data.c (arith_driver, float_arith_driver): Likewise.
8004 * editfns.c (general_insert_function): Likewise.
8005 * eval.c (struct backtrace.nargs, interactive_p)
8006 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8007 (funcall_lambda, mark_backtrace): Likewise.
8008 * fns.c (concat): Likewise.
8009 * frame.c (x_set_frame_parameters): Likewise.
8010 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8011 0 if not found, not -1. All callers changed.
8012
dd3f25f7
PE
8013 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8014 (stack_copy_size): Now size_t, not int.
8015 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8016
461c2ab9
JB
80172011-03-28 Juanma Barranquero <lekktu@gmail.com>
8018
8019 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8020 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8021 All callers changed.
8022
8023 * lisp.h (multibyte_char_to_unibyte):
8024 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8025 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8026 * character.h (CHAR_TO_BYTE8):
8027 * cmds.c (internal_self_insert):
8028 * editfns.c (general_insert_function):
8029 * keymap.c (push_key_description):
8030 * search.c (Freplace_match):
8031 * xdisp.c (message_dolog, set_message_1): All callers changed.
8032
f6d62986
SM
80332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8034
8035 * keyboard.c (safe_run_hook_funcall): New function.
8036 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8037 don't set the hook to nil, but remove the offending function instead.
8038 (Qcommand_hook_internal): Remove, unused.
8039 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8040 Vcommand_hook_internal.
8041
8042 * eval.c (enum run_hooks_condition): Remove.
8043 (funcall_nil, funcall_not): New functions.
8044 (run_hook_with_args): Call each function through a `funcall' argument.
8045 Remove `cond' argument, now redundant.
8046 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8047 (Frun_hook_with_args_until_failure): Adjust accordingly.
8048 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8049
1db5b1ad
JB
80502011-03-28 Juanma Barranquero <lekktu@gmail.com>
8051
8052 * dispextern.h (string_buffer_position): Remove declaration.
8053
8054 * print.c (strout): Remove parameter `multibyte', unused since
8055 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8056
8057 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8058 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8059 All callers changed.
8060
8061 * w32.c (_wsa_errlist): Use braces for struct initializers.
8062
8063 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8064 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8065 All callers changed.
8066 (string_buffer_position): Likewise. Also, make static (it's never
8067 used outside xdisp.c).
8068 (cursor_row_p): Remove parameter `w', unused since
8069 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8070 (decode_mode_spec): Remove parameter `precision', introduced during
8071 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8072 All callers changed.
8073
5ffb62aa
JD
80742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8075
8076 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8077
461c2ab9 80782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8079
8080 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8081 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8082 (ns_update_auto_hide_menu_bar): New functions.
8083 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8084 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8085 ns_constrain_all_frames.
8086 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8087 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8088
5c380ffb
JD
80892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8090
8091 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8092
9af30bdf
GM
80932011-03-27 Glenn Morris <rgm@gnu.org>
8094
8095 * syssignal.h: Replace RETSIGTYPE with void.
8096 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8097 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8098 Replace SIGTYPE with void everywhere.
8099 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8100 * s/template.h (SIGTYPE): Remove commented out definition.
8101
e2abce01
JB
81022011-03-26 Eli Zaretskii <eliz@gnu.org>
8103
8104 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8105 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8106
f868cd8a
JB
81072011-03-26 Juanma Barranquero <lekktu@gmail.com>
8108
59eb0929
JB
8109 * w32.c (read_unc_volume): Use parameter `henum', instead of
8110 global variable `wget_enum_handle'.
8111
8112 * keymap.c (describe_vector): Remove parameters `indices' and
8113 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8114 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8115
f868cd8a
JB
8116 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8117
8118 * keyboard.c (timer_check): Remove parameter `do_it_now',
8119 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8120 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8121 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8122
8123 * keyboard.c (read_char):
8124 * w32menu.c (w32_menu_display_help):
8125 * xmenu.c (show_help_event, menu_help_callback):
8126 Adjust calls to `show_help_echo'.
8127
8128 * gtkutil.c (xg_maybe_add_timer):
8129 * keyboard.c (readable_events):
8130 * process.c (wait_reading_process_output):
8131 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8132
8133 * insdel.c (adjust_markers_gap_motion):
8134 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8135 (gap_left, gap_right): Don't call it.
8136
2ecf6fdb
CY
81372011-03-25 Chong Yidong <cyd@stupidchicken.com>
8138
8139 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8140 incurred during fontification.
8141
6b1f9ba4
JB
81422011-03-25 Juanma Barranquero <lekktu@gmail.com>
8143
8144 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8145 (DEFVAR_PER_BUFFER): Don't pass it.
8146
8147 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8148 (scrolling_window): Don't pass it.
8149
0f4a96b5
JB
81502011-03-25 Juanma Barranquero <lekktu@gmail.com>
8151
8152 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8153
8154 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8155 and `suffix'.
8156 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8157 of variables specific to SELinux and computation of `encoded_absname'.
8158
8159 * image.c (XPutPixel): Remove unused variable `height'.
8160
8161 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8162
8163 * unexw32.c (get_section_info): Remove unused variable `section'.
8164
8165 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8166 (system_process_attributes): Remove unused variable `sess'.
8167 (sys_read): Remove unused variable `err'.
8168
8169 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8170 (w32_wnd_proc): Remove unused variable `isdead'.
8171 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8172 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8173 (x_create_tip_frame): Remove unused variable `tem'.
8174
8175 * w32inevt.c (w32_console_read_socket):
8176 Remove unused variable `no_events'.
8177
8178 * w32term.c (x_draw_composite_glyph_string_foreground):
8179 Remove unused variable `width'.
8180
1149507c
JB
81812011-03-24 Juanma Barranquero <lekktu@gmail.com>
8182
8183 * w32term.c (x_set_glyph_string_clipping):
8184 Don't pass uninitialized region to CombineRgn.
8185
9c88f339
JB
81862011-03-23 Juanma Barranquero <lekktu@gmail.com>
8187
8188 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8189 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8190 (Fx_close_connection): Remove unused variable `i'.
8191
8192 * w32font.c (w32font_draw): Return number of glyphs.
8193 (w32font_open_internal): Remove unused variable `i'.
8194 (w32font_driver): Add missing initializer.
8195
8196 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8197 (fill_in_menu): Remove unused variable `items_added'.
8198
8199 * w32term.c (last_mouse_press_frame): Remove static global variable.
8200 (w32_clip_to_row): Remove unused variable `f'.
8201 (x_delete_terminal): Remove unused variable `i'.
8202
8203 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8204 (NOTHING): Remove unused static global variable.
8205 (uniscribe_check_otf): Remove unused variable `table'.
8206 (uniscribe_font_driver): Add missing initializers.
8207
dee091a3
JD
82082011-03-23 Julien Danjou <julien@danjou.info>
8209
8210 * term.c (Fsuspend_tty, Fresume_tty):
8211 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8212 * window.c (temp_output_buffer_show):
8213 * insdel.c (signal_before_change):
8214 * frame.c (Fhandle_switch_frame):
8215 * fileio.c (Fdo_auto_save):
8216 * emacs.c (Fkill_emacs):
8217 * editfns.c (save_excursion_restore):
8218 * cmds.c (internal_self_insert):
8219 * callint.c (Fcall_interactively):
8220 * buffer.c (Fkill_all_local_variables):
8221 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8222 Use Frun_hooks.
0f4a96b5 8223 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8224 unconditionally since it does the check itself.
dee091a3 8225
2c520ab5 82262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8227
c9c49752
PE
8228 Fix more problems found by GCC 4.5.2's static checks.
8229
8abc3f12
PE
8230 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8231 the first time through the loop, since we know p0 < p1 then.
8232 This also avoids a gcc -Wstrict-overflow warning.
8233
a2d26660
PE
8234 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8235 leading to a memory leak, possible in functions like
8236 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8237 of objects (Bug#8318).
a2d26660 8238
916c72e9
PE
8239 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8240 that could (at least in theory) be that large.
8241
19ab8a18
PE
8242 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8243 This is less likely to overflow, and avoids undefined behavior if
8244 overflow does occur. All callers changed. Use strtoul to scan
8245 for the unsigned long integer.
b7cbbd6f
PE
8246 (pint2hrstr): Simplify and tune code slightly.
8247 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8248
f0641eff
PE
8249 * scroll.c (do_scrolling): Work around GCC bug 48228.
8250 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8251
7f650bb9
PE
8252 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8253 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8254 (validate_x_resource_name): Simplify count usage.
8255 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8256
37dd57d1
PE
8257 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8258 fail (Bug#8306).
81e56e61 8259
699979fc 8260 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8261
401bf9b4
PE
8262 * process.c (Fmake_network_process): Use socklen_t, not int,
8263 where POSIX says socklen_t is required in portable programs.
8264 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8265 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8266 (Fmake_network_process, server_accept_connection):
8267 (wait_reading_process_output, read_process_output):
8268 Likewise.
8269
b93aacde
PE
8270 * process.c: Rename or move locals to avoid shadowing.
8271 (list_processes_1, Fmake_network_process):
8272 (read_process_output_error_handler, exec_sentinel_error_handler):
8273 Rename or move locals.
4dc343ee 8274 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8275 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8276 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8277 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8278 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8279
af8a867c 8280 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8281 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8282 Include tparam.h instead, since it declares them.
af8a867c
PE
8283 * cm.h (PC): Remove extern decl; tparam.h now does this.
8284 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8285 * terminfo.c: Include tparam.h, to check interfaces.
8286 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8287 (tparam): Adjust signature to match interface in tparam.h;
8288 this removes some undefined behavior. Check that outstring and len
8289 are zero, which they always are with Emacs.
8290 * tparam.h (PC, BC, UP): New extern decls.
8291
0248044d 8292 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8293 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8294
8ff096c1 8295 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8296 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8297 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8298 (ftfont_list): Remove unused local.
49eaafba
PE
8299 (get_adstyle_property, ftfont_pattern_entity):
8300 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8301 Rename locals to avoid shadowing.
8ff096c1 8302
e2be39f6
PE
8303 * xfont.c (xfont_list_family): Mark var as initialized.
8304
c9735e30
PE
8305 * xml.c (make_dom): Now static.
8306
8f5201ae
PE
8307 * composite.c (composition_compute_stop_pos): Rename local to
8308 avoid shadowing.
b246f932
PE
8309 (composition_reseat_it): Remove unused locals.
8310 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8311 (composition_update_it): Mark var as initialized.
11b61122
PE
8312 (find_automatic_composition): Mark vars as initialized,
8313 with a FIXME (Bug#8290).
8f5201ae 8314
760fbc2c
PE
8315 character.h: Rename locals to avoid shadowing.
8316 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8317 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8318 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8319 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8320 to avoid shadowing.
8321
ff08eb85
PE
8322 * textprop.c (property_change_between_p): Remove; unused.
8323
fc7bf025
PE
8324 * intervals.c (interval_start_pos): Now static.
8325
235d7abc
PE
8326 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8327
44f230aa
SM
8328 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8329 Rename locals to avoid shadowing.
3e7d6594 8330
50060332
PE
8331 * sound.c (wav_play, au_play, Fplay_sound_internal):
8332 Fix pointer signedness.
d01f234b 8333 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8334 (wav_play): Initialize a variable to 0, to prevent undefined
8335 behavior (Bug#8278).
50060332 8336
c4fc4e30
PE
8337 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8338
918436ed
PE
8339 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8340
c939f91b
PE
8341 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8342 clobbering (Bug#8298).
b9c7f648
PE
8343 * sysdep.c (sys_subshell): Likewise.
8344 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8345
6bd8c144
PE
8346 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8347 This should get cleaned up, so that child_setup has the
8348 same signature on all platforms.
8349
7710357c 8350 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8351 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8352
c59da222
CY
83532011-03-22 Chong Yidong <cyd@stupidchicken.com>
8354
8355 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8356 not to be necessary, and produces flickering.
8357
66b87493
GM
83582011-03-20 Glenn Morris <rgm@gnu.org>
8359
8360 * config.in: Remove file.
8361
45b6f6d5
JB
83622011-03-20 Juanma Barranquero <lekktu@gmail.com>
8363
8364 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8365 are now in src/globals.h.
8366 (syms_of_minibuf): Remove spurious & from previous change.
8367
cd394be1 83682011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8369
8370 * minibuf.c (completing-read-function): New variable.
8371 (completing-read-default): Rename from completing-read.
8372 (completing-read): Call completing-read-function.
8373
b14e3e21
CY
83742011-03-19 Juanma Barranquero <lekktu@gmail.com>
8375
8376 * xfaces.c (Fx_load_color_file):
8377 Read color file from absolute filename (bug#8250).
8378
f2b726e6
JB
83792011-03-19 Juanma Barranquero <lekktu@gmail.com>
8380
8381 * makefile.w32-in: Update dependencies.
8382
09f6ff02
EZ
83832011-03-17 Eli Zaretskii <eliz@gnu.org>
8384
8385 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8386
29a6015a
PE
83872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8388
a3a6c54e
PE
8389 Fix more problems found by GCC 4.5.2's static checks.
8390
b766f867
PE
8391 * process.c (make_serial_process_unwind, send_process_trap):
8392 (sigchld_handler): Now static.
8393
be02381c
PE
8394 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8395 That way, the code declares only the vars that it needs.
8396 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8397 * s/cygwin.h (PTY_ITERATION): Likewise.
8398 * s/darwin.h (PTY_ITERATION): Likewise.
8399 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8400
57048744
PE
8401 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8402 * process.c (allocate_pty): Don't declare stb unless it's needed.
8403
7914961c 8404 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8405 (CONSTANTLIM): Remove; unused.
8406 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8407 Define only if needed.
7914961c 8408
b3967b18
PE
8409 * unexelf.c (unexec): Name an expression,
8410 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8411 Use a different way to cause a compilation error if anyone uses
8412 n rather than nn, a way that does not involve shadowing.
73366a00 8413 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8414
29a6015a
PE
8415 * deps.mk (unexalpha.o): Remove; unused.
8416
43cfc33e 8417 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8418 * unexec.h: New file.
ce701a33
PE
8419 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8420 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8421 Depend on unexec.h.
8422 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8423 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8424 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8425 Change as necessary to match prototype in unexec.h.
ce701a33 8426
01f44d5a
PE
8427 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8428 shadowing.
4f63c6bb 8429 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8430
a6670b0b
PE
8431 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8432 Rename locals to avoid shadowing.
8433
cef2010d 8434 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8435 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8436
d4d7173a
PE
8437 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8438
f08b802a
PE
8439 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8440 warning when compiling print.c.
8441
3ddb0639
PE
8442 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8443 instead of using an uninitialized var.
5ad03b97 8444 (font_sort_entities): Mark var as initialized.
3ddb0639 8445
170a2692
PE
8446 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8447
e663c700
PE
8448 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8449 pointers to constants.
89bc529a 8450 (font_parse_fcname): Remove unused vars.
7b81e2d0 8451 (font_delete_unmatched): Now static.
ea838e10 8452 (font_get_spec): Remove; unused.
13a547c6
PE
8453 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8454 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8455 Rename or move locals to avoid shadowing.
e663c700 8456
2a80c887 8457 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8458 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8459
1384fa33 8460 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8461 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8462
8b2c52e9
PE
8463 * alloc.c (mark_backtrace): Move decl from here ...
8464 * lisp.h: ... to here, so that it can be checked.
8465
475545b5 8466 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8467 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8468 (lisp_indirect_variable): Name an expression,
8469 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8470 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8471
b1349114 8472 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8473 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8474 Use const pointer when appropriate.
b1349114 8475
a2928364
PE
8476 * lisp.h (get_system_name, get_operating_system_release):
8477 Move decls here, to check interfaces.
8478 * process.c (get_operating_system_release): Move decl to lisp.h.
8479 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8480 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8481 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8482 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8483 (Fformat_time_string, Fencode_time, Finsert_char):
8484 (Ftranslate_region_internal, Fformat):
8485 Rename or remove local vars to avoid shadowing.
9710023e 8486 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8487
a415e694
PE
8488 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8489 avoid shadowing.
8490
8ef4622d
PE
8491 * lisp.h (eassert): Check that the argument compiles, even if
8492 ENABLE_CHECKING is not defined.
8493
946f9a5b
PE
8494 * data.c (Findirect_variable): Name an expression, to avoid
8495 gcc -Wbad-function-cast warning.
112396d6 8496 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8497 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8498 (Fmake_variable_buffer_local, Fmake_local_variable):
8499 Mark variables as initialized.
52746918 8500 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8501
e5aab7e7 8502 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8503 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8504 Rename locals to avoid shadowing.
dff45157
PE
8505 (mark_stack): Move local variables into the #ifdef region where
8506 they're used.
7bc26fdb
PE
8507 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8508 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8509 needed otherwise.
8510 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8511 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8512 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8513
e5aab7e7
PE
8514 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8515 avoids undefined behavior in theory.
8516
4da60324
PE
8517 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8518
88043301
PE
8519 Use functions, not macros, for up- and down-casing (Bug#8254).
8520 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8521 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8522 to use the following functions instead of these macros.
8523 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8524 EMACS_INT, since callers assume the returned value fits in int.
8525 (upcase1): Likewise, for UPCASE_TABLE.
8526 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8527 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8528 the race-condition problem in the old DOWNCASE.
88043301 8529
19ed5445
PE
8530 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8531 Rename locals to avoid shadowing.
8532 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8533 (regex_compile, re_search_2, re_match_2_internal):
8534 Remove unused local vars.
952db0d7
PE
8535 (FREE_VAR): Rewrite so as not to use empty "else",
8536 which gcc can warn about.
da053e48 8537 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8538 (RETALLOC_IF): Define only if needed.
8539 (WORDCHAR_P): Likewise. This one is never needed, but is used
8540 only in a comment talking about a compiler bug, so put inside
8541 the #if 0 of that comment.
8542 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8543 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8544 Remove; unused.
19ed5445 8545
1f3561e4 8546 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8547 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8548 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8549
ded6f8f7
PE
8550 * search.c (simple_search): Remove unused var.
8551
dbd37a95
PE
8552 * dired.c (compile_pattern): Move decl from here ...
8553 * lisp.h: ... to here, so that it can be checked.
8554 (struct re_registers): New forward decl.
8555
7e47afad
PE
8556 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8557
85f24f61
PE
8558 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8559 All uses changed.
8560 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8561 Rename locals to avoid shadowing.
5671df8f 8562 (Fvertical_motion): Mark locals as initialized.
85f24f61 8563
181aa2be 8564 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8565 (casify_region): Mark local as initialized.
181aa2be 8566
930d429c
PE
8567 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8568
7082eac6
PE
8569 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8570 New macros, so that the caller can use some names other than
8571 gcpro1, gcpro2, etc.
8572 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8573 of the new macros.
8574 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8575 argument, for consistency with GCPRO2_VAR, etc: it is now the
8576 prefix of the variable, not the variable itself. All uses
8577 changed.
38b2c076
PE
8578 * dired.c (directory_files_internal, file_name_completion):
8579 Rename locals to avoid shadowing.
8580
15206ed9
PE
8581 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8582 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8583 dired.c's scmp function, had undefined behavior.
8584 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8585 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8586 * buffer.h: ... to here, because these macros use current_buffer,
8587 and the new implementation with inline functions needs to have
8588 current_buffer in scope now, rather than later when the macros
8589 are used.
8590 (downcase, upcase1): New static inline functions.
8591 (DOWNCASE, UPCASE1): Reimplement using these functions.
8592 This avoids undefined behavior in expressions like
8593 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8594 from race conditions in accessing the global variables
8595 case_temp1 and case_temp2.
8596 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8597 * lisp.h (case_temp1, case_temp2): Remove their decls.
8598 * character.h (ASCII_CHAR_P): Move from here ...
8599 * lisp.h: ... to here, so that the inline functions mentioned
8600 above can use them.
8601
4a6bea26
PE
8602 * dired.c (directory_files_internal_unwind): Now static.
8603
f14b7e14
PE
8604 * fileio.c (file_name_as_directory, directory_file_name):
8605 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8606 Now static.
2893f146
PE
8607 (file_name_as_directory): Use const pointers when appropriate.
8608 (Fexpand_file_name): Likewise. In particular, newdir might
8609 point at constant storage, so make it a const pointer.
fd4ead52 8610 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8611 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8612 signedness issues.
f839df0c
PE
8613 (Fset_file_times, Finsert_file_contents, auto_save_error):
8614 Rename locals to avoid shadowing.
f14b7e14 8615
5716756e 8616 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8617 (Ftry_completion, Fall_completions): Rename or remove locals
8618 to avoid shadowing.
5716756e 8619
b4c3046a
PE
8620 * marker.c (bytepos_to_charpos): Remove; unused.
8621
b45db522
PE
8622 * lisp.h (verify_bytepos, count_markers): New decls,
8623 so that gcc does not warn that these functions aren't declared.
8624
85876d07
PE
8625 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8626 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8627 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8628 (copy_text): Remove unused local var.
85876d07 8629
03d78a21 8630 * filelock.c (within_one_second): Now static.
b3dd38ab 8631 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8632
5df8f01b
PE
8633 * buffer.c (fix_overlays_before): Mark locals as initialized.
8634 (fix_start_end_in_overlays): Likewise. This function should be
8635 simplified by using pointers-to-pointers, but that's a different
8636 matter.
b1d876f1 8637 (switch_to_buffer_1): Now static.
8f54f30a
PE
8638 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8639 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8640
a70072c9 8641 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8642 Fix pointer signedness issue.
edced198
PE
8643 (sys_subshell): Mark local as volatile if checking for lint,
8644 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8645 (MAXPATHLEN): Define only if needed.
a70072c9 8646
a0977c44
PE
8647 * process.c (serial_open, serial_configure): Move decls from here ...
8648 * systty.h: ... to here, so that they can be checked.
8649
a884fdcc
PE
8650 * fns.c (get_random, seed_random): Move extern decls from here ...
8651 * lisp.h: ... to here, so that they can be checked.
8652
604efe86 8653 * sysdep.c (reset_io): Now static.
b8950c94 8654 (wait_for_termination_signal): Remove; unused.
604efe86 8655
38fc62d9
PE
8656 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8657 (copy_keymap_item, append_key, push_text_char_description):
8658 Now static.
1004a21a 8659 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8660 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8661 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8662 (describe_map_tree):
8663 Rename locals to avoid shadowing.
38fc62d9 8664
2f2650da
PE
8665 * keyboard.c: Declare functions static if they are not used elsewhere.
8666 (echo_char, echo_dash, cmd_error, top_level_2):
8667 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8668 (read_char, kbd_buffer_get_event, make_lispy_position):
8669 (make_lispy_event, make_lispy_movement, apply_modifiers):
8670 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8671 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8672 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8673 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8674 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8675
a053e86c 8676 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8677 (mark_kboards): Move decl here ...
8678 * alloc.c (mark_kboards): ... from here.
a053e86c 8679
4752793e
PE
8680 * lisp.h (force_auto_save_soon): New decl.
8681
74f10ca7 8682 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8683 (DEFINE_DUMMY_FUNCTION): New macro.
8684 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8685 Use it.
c03cd23f
PE
8686 (main): Add casts to avoid warnings
8687 if GCC considers string literals to be constants.
74f10ca7 8688
022e70d4
PE
8689 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8690
59d6fe83
PE
8691 * dbusbind.c: Pointer signedness fixes.
8692 (xd_signature, xd_append_arg, xd_initialize):
8693 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8694 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8695 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8696 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8697
78320123
PE
8698 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8699 if GCC considers string literals to be constants.
49cebcca 8700 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8701
35ac2a97
SM
87022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8703
fb103ca9
SM
8704 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8705 (print_preprocess, print_object): New macro to fix last change.
8706
35ac2a97
SM
8707 * print.c (print_preprocess): Don't forget font objects.
8708
62973b41
JB
87092011-03-16 Juanma Barranquero <lekktu@gmail.com>
8710
8711 * emacs.c (USAGE3): Doc fixes.
8712
0e48bb22
AS
87132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8714
8715 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8716 structure.
8717
7684e57b
JB
87182011-03-14 Juanma Barranquero <lekktu@gmail.com>
8719
8720 * lisp.h (VWindow_system, Qfile_name_history):
8721 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8722 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8723 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8724
8725 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8726 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8727
8728 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8729 * w32console.c (detect_input_pending, read_input_pending)
8730 (encode_terminal_code):
8731 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8732 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8733 (w32_system_caret_y, Qfile_name_history):
8734 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8735 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8736 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8737 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8738 * w32proc.c (Qlocal, report_file_error):
8739 * w32term.c (Vwindow_system, updating_frame):
8740 * w32uniscribe.c (initialized, uniscribe_font_driver):
8741 Remove unneeded extern declarations.
8742
2aa46d6c
CY
87432011-03-14 Chong Yidong <cyd@stupidchicken.com>
8744
c96bbc66 8745 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8746
cffc6f3b
CY
87472011-03-13 Chong Yidong <cyd@stupidchicken.com>
8748
8749 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8750 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8751 These macros can no longer be used for assignment.
8752
44f230aa
SM
8753 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8754 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8755 (record_buffer_markers, fetch_buffer_markers): New functions for
8756 recording and fetching special buffer markers.
8757 (set_buffer_internal_1, set_buffer_temp): Use them.
8758
8759 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8760
8761 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8762
8763 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8764 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8765
8766 * xdisp.c (hscroll_window_tree):
8767 (reconsider_clip_changes): Use PT instead of BUF_PT.
8768
d251f04b
EZ
87692011-03-13 Eli Zaretskii <eliz@gnu.org>
8770
8771 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8772 $(EMACS_ROOT)/lib/intprops.h.
8773
f0c77cd1
PE
87742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8775
3eca4629
PE
8776 Fix more problems found by GCC 4.5.2's static checks.
8777
7c86ee98
PE
8778 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8779 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8780 (xg_free_frame_widgets): Make it clear that a local variable is
8781 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8782 (gdk_window_get_screen): Make it clear that this macro is needed
8783 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8784 (int_gtk_range_get_value): New function, which avoids a diagnostic
8785 from gcc -Wbad-function-cast.
8786 (xg_set_toolkit_scroll_bar_thumb): Use it.
8787 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8788 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8789 (get_utf8_string, xg_get_file_with_chooser):
8790 Rename locals to avoid shadowing.
8791 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8792
41729b81
PE
8793 * xgselect.c (xg_select): Remove unused var.
8794
f0c77cd1
PE
8795 * image.c (four_corners_best): Mark locals as initialized.
8796 (gif_load): Initialize transparent_p to zero (Bug#8238).
8797 Mark another local as initialized.
ec6cf4c6 8798 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8799
ce0ad53d 8800 * image.c (clear_image_cache): Now static.
d5d5a617 8801 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8802 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8803 (x_edge_detection): Remove unnecessary cast that
8804 gcc -Wbad-function-cast diagnoses.
2037898d 8805 (gif_load): Fix pointer signedness.
6ae141d6
PE
8806 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8807 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8808
33383987 88092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8810
d32df629
PE
8811 Improve quality of tests for time stamp overflow.
8812 For example, without this patch (encode-time 0 0 0 1 1
8813 1152921504606846976) returns the obviously-bogus value (-948597
8814 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8815 reports time overflow. See
8816 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8817 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8818 * editfns.c: Include limits.h and intprops.h.
8819 (TIME_T_MIN, TIME_T_MAX): New macros.
8820 (time_overflow): Move earlier, to before first use.
8821 (hi_time, lo_time): New functions, for an accurate test for
8822 out-of-range times.
8823 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8824 (Fget_internal_run_time): Don't assume time_t fits in int.
8825 (make_time): Use list2 instead of Fcons twice.
8826 (Fdecode_time): More accurate test for out-of-range times.
8827 (check_tm_member): New function.
8828 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8829 (lisp_time_argument): Don't rely on undefined left-shift and
8830 right-shift behavior when checking for time stamp overflow.
8be6f318 8831
fe31d94c
PE
8832 * editfns.c (time_overflow): New function, refactoring common code.
8833 (Fformat_time_string, Fdecode_time, Fencode_time):
8834 (Fcurrent_time_string): Use it.
8835
8be6f318
PE
8836 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8837 * dired.c (make_time): Move to ...
8838 * editfns.c (make_time): ... here.
8839 * systime.h: Note the move.
8840
09d9db2c 88412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8842
126bc0dc
YM
8843 * fringe.c (update_window_fringes): Remove unused variables.
8844
c47cbdfd
YM
8845 * unexmacosx.c (copy_data_segment): Also copy __got section.
8846 (Bug#8223)
8847
7ac80be9
EZ
88482011-03-12 Eli Zaretskii <eliz@gnu.org>
8849
c96bbc66 8850 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8851 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8852 Constify `char *' arguments and their references according to
8853 prototypes in tparam.h.
8854
ecb0f94d 8855 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8856
7ac80be9
EZ
8857 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8858 Adapt all references accordingly.
8859
8860 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8861
ef1fd07e
TT
88622011-03-11 Tom Tromey <tromey@redhat.com>
8863
8864 * buffer.c (syms_of_buffer): Remove obsolete comment.
8865
7ef4b50c
EZ
88662011-03-11 Eli Zaretskii <eliz@gnu.org>
8867
8868 * termhooks.h (encode_terminal_code): Declare prototype.
8869
8870 * msdos.c (encode_terminal_code): Don't declare prototype.
8871
8872 * term.c (encode_terminal_code): Now external again, used by
8873 w32console.c and msdos.c.
8874
44f230aa
SM
8875 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8876 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8877
4b1ec863 88782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8879
1714f52b 8880 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8881
4b1ec863
PE
8882 * fringe.c (update_window_fringes): Mark locals as initialized
8883 (Bug#8227).
8884 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8885
524c7aa6
PE
8886 * alloc.c (mark_fringe_data): Move decl from here ...
8887 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8888 to check its interface.
8889 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8890
a5c0af81 8891 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8892 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8893 (fontset_font): Mark local as initialized.
a9a06e0b 8894 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8895
b4716021
PE
8896 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8897
811e9bac 8898 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8899 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8900 (x_own_selection, Fx_disown_selection_internal): Rename locals
8901 to avoid shadowing.
8902 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8903
7e3ab302
PE
8904 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8905 so that the caller can use some name other than gcpro1.
8906 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8907 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8908 (Fx_backspace_delete_keys_p):
8909 Use them to avoid shadowing, and rename vars to avoid shadowing.
8910 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8911 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8912 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8913 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8914 Remove unused locals.
7e3ab302
PE
8915 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8916 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8917 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8918 macros.
f78faa98 8919
e2b13473
PE
8920 * xterm.h (x_mouse_leave): New decl.
8921
77f23912
PE
8922 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8923 Remove unused functions.
cdf4ba58
PE
8924 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8925 (x_calc_absolute_position): Now static.
7411c686 8926 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8927 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8928 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8929 unless they are used.
38d0b34a
PE
8930 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8931 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8932 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8933 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8934 (x_error_catcher, x_connection_closed, x_error_handler):
8935 (x_error_quitter, xembed_send_message, x_iconify_frame):
8936 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8937 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8938 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8939
44f230aa
SM
8940 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8941 Rename or move locals to avoid shadowing.
6b463e58 8942 (tty_defined_color, merge_face_heights): Now static.
5967d051 8943 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8944 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8945 does not deduce is never used uninitialized.
73719eba
PE
8946 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8947 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8948
426994c3 8949 * terminal.c (store_terminal_param): Now static.
5489860b 8950
032f1620 8951 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8952 (set_frame_menubar): Remove unused local.
d4323972 8953 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8954 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8955 since they might point to immutable storage.
281585b0
PE
8956 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8957 since it's unused otherwise.
032f1620 8958
367c19e5 8959 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8960 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8961 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8962 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8963 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8964 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8965 does not deduce are never used uninitialized.
70739cbe 8966
07b48fa9
PE
8967 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8968
8868a238 8969 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8970 * window.c (window_loop, size_window):
8971 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8972
7e5cf297 8973 * window.c (display_buffer): Now static.
d6550a9f
PE
8974 (size_window): Mark variables that gcc -Wuninitialized
8975 does not deduce are never used uninitialized.
a586633d
PE
8976 * window.h (check_all_windows): New decl, to forestall
8977 gcc -Wmissing-prototypes diagnostic.
5b555da1 8978 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8979
f6095868
PE
8980 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8981 shadowing.
8982 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8983 Include <limits.h>.
8984 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8985 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8986 (load_charset_map): Mark variables that gcc -Wuninitialized
8987 does not deduce are never used uninitialized.
53df7c11 8988 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8989
f38b440c
PE
8990 * coding.c (coding_set_source, coding_set_destination):
8991 Use "else { /* comment */ }" rather than "else /* comment */;"
8992 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8993 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8994 a block, when the outer 'i' will do.
8995 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8996 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8997 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8998 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8999 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9000 Rename locals to avoid shadowing.
9001 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9002 * coding.c (emacs_mule_char, encode_invocation_designation):
9003 Now static, since they're not used elsewhere.
413bb2db 9004 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9005 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9006 (decode_coding_emacs_mule): Mark variables that gcc
9007 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9008 (detect_coding_iso_2022): Initialize a local variable that might
9009 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9010 this initialization is needed. (Bug#8211)
5f58e762
PE
9011 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9012 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9013 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9014 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9015 Remove unused macros.
f38b440c 9016
232b38b9 9017 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9018 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9019 * character.c (string_count_byte8): Likewise.
232b38b9 9020
fb90da1b
PE
9021 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9022 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9023
fb93dbc2
PE
9024 * chartab.c (copy_sub_char_table): Now static, since it's not used
9025 elsewhere.
5c156ace
PE
9026 (sub_char_table_ref_and_range, char_table_ref_and_range):
9027 Rename locals to avoid shadowing.
bbcd0949 9028 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9029
7d3b3862 9030 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9031 (BIDI_BOB): Remove unused macro.
7d3b3862 9032
6be7d3da
PE
9033 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9034 deduce are never used uninitialized.
c2ed9c8b 9035 * term.c (encode_terminal_code): Likewise.
6be7d3da 9036
75f8807f 9037 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9038
50938595
PE
9039 * tparam.h: New file.
9040 * term.c, tparam.h: Include it.
9041 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9042 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9043 Move these decls to tparam.h, and make them agree with what
9044 is actually in tparam.c. The previous trick of using incompatible
9045 decls in different modules does not conform to the C standard.
9046 All callers of tparam changed to use tparam's actual API.
9047 * tparam.c (tparam1, tparam, tgoto):
9048 Use const pointers where appropriate.
9049
fbceeba2
PE
9050 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9051 * cm.h (struct cm): Likewise.
9052 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9053 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9054 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9055 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9056 (turn_on_face, init_tty): Likewise.
9057 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9058
7f3f1250
PE
9059 * term.c (term_mouse_position): Rename local to avoid shadowing.
9060
e6ca6543
PE
9061 * alloc.c (mark_ttys): Move decl from here ...
9062 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9063
c40f8d15
AS
90642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9065
9066 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9067
cfe0661d
JB
90682011-03-09 Juanma Barranquero <lekktu@gmail.com>
9069
9070 * search.c (compile_pattern_1): Remove argument regp, unused since
9071 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9072 (compile_pattern): Don't pass it.
9073
0afb4571
J
90742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9075
9076 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9077 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9078 for ! HAVE_GTK3.
9079 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9080
9081 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9082
9083 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9084 gdk_window_get_screen, gdk_window_get_geometry,
9085 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9086 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9087 (xg_get_pixbuf_from_pixmap): New function.
9088 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9089 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9090 Call xg_get_pixbuf_from_pixmap instead of
9091 gdk_pixbuf_get_from_drawable.
9092 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9093 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9094 (xg_check_special_colors): Use GtkStyleContext and its functions
9095 for HAVE_GTK3.
9096 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9097 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9098 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9099 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9100 Call gtk_widget_get_preferred_size.
0afb4571
J
9101 (xg_frame_resized): gdk_window_get_geometry only takes 5
9102 parameters.
44f230aa
SM
9103 (xg_win_to_widget, xg_event_is_for_menubar):
9104 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9105 (xg_set_widget_bg): New function.
9106 (delete_cb): New function.
895009e1 9107 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9108 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9109 (xg_set_background_color): Call xg_set_widget_bg.
9110 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9111 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9112 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9113 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9114 if ! HAVE_GTK3.
9115 (update_frame_tool_bar): Call gtk_widget_hide.
9116 (xg_initialize): Use GDK_KEY_g.
9117
9118 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9119 if ! HAVE_GTK3
9120 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9121
9122 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9123 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9124 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9125
1c2cc4ef
JB
91262011-03-08 Juanma Barranquero <lekktu@gmail.com>
9127
9128 * w32xfns.c (select_palette): Check success of RealizePalette against
9129 GDI_ERROR, not zero.
9130
33383987 9131See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9132
9133;; Local Variables:
9134;; coding: utf-8
aac0c6e3
MR
9135;; End:
9136
acaf905b 9137 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9138
9139 This file is part of GNU Emacs.
9140
9141 GNU Emacs is free software: you can redistribute it and/or modify
9142 it under the terms of the GNU General Public License as published by
9143 the Free Software Foundation, either version 3 of the License, or
9144 (at your option) any later version.
9145
9146 GNU Emacs is distributed in the hope that it will be useful,
9147 but WITHOUT ANY WARRANTY; without even the implied warranty of
9148 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9149 GNU General Public License for more details.
9150
9151 You should have received a copy of the GNU General Public License
9152 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.