* data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c8a9ca5a
PE
12011-05-24 Paul Eggert <eggert@cs.ucla.edu>
2
3 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4
fdccd48e
PE
52011-05-23 Paul Eggert <eggert@cs.ucla.edu>
6
519e1d69
PE
7 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8
30569699
PE
9 ccl: add integer overflow checks
10 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11 (IN_INT_RANGE): New macros.
12 (ccl_driver): Use them to check for integer overflow when
13 decoding a CCL program. Many of the new checks are whether XINT (x)
14 fits in int; it doesn't always, on 64-bit hosts. The new version
15 doesn't catch all possible integer overflows, but it's an
847044ea 16 improvement. (Bug#8719)
30569699 17
c11285dc
PE
18 * alloc.c (make_event_array): Use XINT, not XUINT.
19 There's no need for unsigned here.
20
fdccd48e
PE
21 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
22 This follows up to the 2011-05-06 change that substituted uintptr_t
23 for EMACS_INT. This case wasn't caught back then.
24
2e6578fb
PE
252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
26
37910ab2
PE
27 Rework Fformat to avoid integer overflow issues.
28 * editfns.c: Include <float.h> unconditionally, as it's everywhere
29 now (part of C89). Include <verify.h>.
30 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
31 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
32 (Fformat): Avoid the prepass trying to compute sizes; it was only
33 approximate and thus did not catch overflow reliably. Instead, walk
34 through the format just once, formatting and computing sizes as we go,
35 checking for integer overflow at every step, and allocating a larger
36 buffer as needed. Keep track separately whether the format is
37 multibyte. Keep only the most-recently calculated precision, rather
38 than them all. Record whether each argument has been converted to
39 string. Use EMACS_INT, not int, for byte and char and arg counts.
40 Support field widths and precisions larger than INT_MAX. Avoid
41 sprintf's undefined behavior with conversion specifications such as %#d
42 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
43 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
44 formatting out-of-range floating point numbers with int
45 formats. (Bug#8668)
46
2e6578fb
PE
47 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
48
0ae6bdee
PE
49 * data.c: Avoid integer truncation in expressions involving floats.
50 * data.c: Include <intprops.h>.
51 (arith_driver): When there's an integer overflow in an expression
52 involving floating point, convert the integers to floating point
53 so that the resulting value does not suffer from catastrophic
54 integer truncation. For example, on a 64-bit host (* 4
55 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
56 Do not rely on undefined behavior after integer overflow.
57
de883a70
PE
58 merge count_size_as_multibyte, parse_str_to_multibyte
59 * character.c, character.h (count_size_as_multibyte):
60 Renamed from parse_str_to_multibyte; all uses changed.
61 Check for integer overflow.
62 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
63 since it's now a duplicate of the other. This is more of
64 a character than a buffer op, so better that it's in character.c.
65 * fns.c, print.c: Adjust to above changes.
66
7400048f
PE
672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
68
69 * gnutls.c: Remove unused macros.
70 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
71 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
72 Remove macros that are defined and never used.
73 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
74
abb71cf4
CY
752011-05-22 Chong Yidong <cyd@stupidchicken.com>
76
77 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
78 (Fx_get_selection_internal): Minor cleanup.
79 (Fx_own_selection_internal): Rename arguments for consistency with
80 select.el.
81
6307db39
PE
822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
83
84 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
85
f3d4e0a4
CY
862011-05-22 Chong Yidong <cyd@stupidchicken.com>
87
88 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
89
4d8ade89
YM
902011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
91
92 * dispnew.c (scrolling_window): Don't exclude the case that the
93 last enabled row in the desired matrix touches the bottom boundary.
94
32078c8d
GM
952011-05-21 Glenn Morris <rgm@gnu.org>
96
97 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
98 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
99 and add some more files.
32078c8d 100
7285dc67
EZ
1012011-05-20 Eli Zaretskii <eliz@gnu.org>
102
103 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
104 report_file_error introduced by the change from 2011-05-07.
105
89d1bd22
PE
1062011-05-20 Paul Eggert <eggert@cs.ucla.edu>
107
108 * systime.h (Time): Define only if emacs is defined.
109 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
110 where the include path doesn't have X11/X.h by default. See
111 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
112
e23640bb 1132011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
114
115 * composite.c (find_automatic_composition): Fix previous change.
116
b9704ad9
GM
1172011-05-20 Glenn Morris <rgm@gnu.org>
118
119 * lisp.mk: New file, split from Makefile.in.
120 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
121 (shortlisp): Remove.
122 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
123
4a720484
GM
1242011-05-19 Glenn Morris <rgm@gnu.org>
125
126 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
127 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
128 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
129 (lisp): Set the order to that of loadup.el.
130 (shortlisp): Make it a copy of $lisp.
131 (SOME_MACHINE_LISP): Remove.
132 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
133 Use just $shortlisp, not $SOME_MACHINE_LISP too.
134
a28d4396
KH
1352011-05-18 Kenichi Handa <handa@m17n.org>
136
137 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
138 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
139 (find_automatic_composition): Mostly rewrite for efficiency.
140
a2b1fa8e
JB
1412011-05-18 Juanma Barranquero <lekktu@gmail.com>
142
143 * makefile.w32-in: Update dependencies.
144
8e1f5610
CS
1452011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
146
147 * menu.c: Include limits.h (fixes the MS-Windows build broken by
148 revision 104625).
149
7025ee00 1502011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 151
cdfa6eab
PE
152 Fix some integer overflow issues, such as string length overflow.
153
06d6db33
PE
154 * insdel.c (count_size_as_multibyte): Check for string overflow.
155
2b4560a8
PE
156 * character.c (lisp_string_width): Check for string overflow.
157 Use EMACS_INT, not int, for string indexes and lengths; in
158 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
159 the resulting string length overflows an EMACS_INT; instead,
160 report a string overflow if no precision given. When checking for
161 precision exhaustion, use a check that cannot possibly have
162 integer overflow. (Bug#8675)
163 * character.h (lisp_string_width): Adjust to new signature.
164
cb93f9be
PE
165 * alloc.c (string_overflow): New function.
166 (Fmake_string): Use it. This doesn't change behavior, but saves
167 a few bytes and will simplify future changes.
168 * character.c (string_escape_byte8): Likewise.
169 * lisp.h (string_overflow): New decl.
170
1a1f3366
PE
171 Fixups, following up to the user-interface timestamp change.
172 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
173 for UI timestamps, instead of unsigned long.
9fbd6841
PE
174 * msdos.c (mouse_get_pos): Likewise.
175 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
176 * w32gui.h (Time): Define by including "systime.h" rather than by
177 declaring it ourselves. (Bug#8664)
178
d4e3e4d3
PE
179 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
180 * image.c (clear_image_cache): Likewise.
181
f6a24d19
PE
182 * term.c (term_mouse_position): Don't assume time_t wraparound.
183
08dc5ae6
PE
184 Be more systematic about user-interface timestamps.
185 Before, the code sometimes used 'Time', sometimes 'unsigned long',
186 and sometimes 'EMACS_UINT', to represent these timestamps. This
187 change causes it to use 'Time' uniformly, as that's what X uses.
188 This makes the code easier to follow, and makes it easier to catch
189 integer overflow bugs such as Bug#8664.
190 * frame.c (Fmouse_position, Fmouse_pixel_position):
191 Use Time, not unsigned long, for user-interface timestamps.
192 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
193 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
194 * keyboard.h (last_event_timestamp): Likewise.
195 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
196 * menu.h (xmenu_show): Likewise.
197 * term.c (term_mouse_position): Likewise.
198 * termhooks.h (struct input_event.timestamp): Likewise.
199 (struct terminal.mouse_position_hook): Likewise.
200 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
201 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
202 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
203 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
204 what it was before.
205 * menu.h, termhooks.h: Include "systime.h", for Time.
206
8e55734a
PE
207 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
208 Don't assume that the difference between two unsigned long values
209 can fit into an integer. At this point, we know button_down_time
210 <= event->timestamp, so the difference must be nonnegative, so
211 there's no need to cast the result if double-click-time is
212 nonnegative, as it should be; check that it's nonnegative, just in
213 case. This bug is triggered when events are more than 2**31 ms
86db42d2 214 apart (about 25 days). (Bug#8664)
8e55734a 215
841f1b75 216 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 217 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 218
3e26f69c
PE
219 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
220 that always fit in int. Use a sentinel instead of a counter, to
221 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
222 * frame.h (struct frame): Use int for menu_bar_items_used
223 instead of EMACS_INT, since it always fits in int.
3e26f69c 224
5cc152c0
PE
225 * menu.c (grow_menu_items): Check for int overflow.
226
d89eb65e
PE
227 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
228
5235bd3e
PE
229 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
230 Before, the code was not consistent. These values cannot exceed
231 2**31 - 1 so there's no need to make them unsigned.
232 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
233 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
234 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
235 as modifiers.
236 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
237
bc827e23
PE
238 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
239 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
240 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
241 presumably because the widths might not match.
242
78eb494e
PE
243 * window.c (size_window): Avoid needless test at loop start.
244
04f2d78b
CB
2452011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
246
247 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
248
d2fc7e3d 2492011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
250
251 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
252
d2fc7e3d 2532011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
254
255 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
256 `width' to `bar_area_x' and `bar_area_width', respectively.
257 (x_scroll_run): Take account of fringe background extension.
258
04f2d78b
CB
259 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
260 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
261 `bar_area_width', respectively.
262 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
263 background extension.
264
79b70037
GM
2652011-05-10 Jim Meyering <meyering@redhat.com>
266
267 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
268
2f142cc5
JB
2692011-05-10 Juanma Barranquero <lekktu@gmail.com>
270
271 * image.c (Finit_image_library): Return t for built-in image types,
272 like pbm and xbm. (Bug#8640)
273
57679c86
AS
2742011-05-09 Andreas Schwab <schwab@linux-m68k.org>
275
276 * w32menu.c (set_frame_menubar): Fix submenu allocation.
277
888c9e86
EZ
2782011-05-07 Eli Zaretskii <eliz@gnu.org>
279
b0512a1d
EZ
280 * w32console.c (Fset_screen_color): Doc fix.
281 (Fget_screen_color): New function.
282 (syms_of_ntterm): Defsubr it.
283
7285dc67
EZ
284 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
285 unlink the temporary file if Fcall_process didn't create it in the
286 first place.
287 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
288 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
289 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
290 cue to call_process_cleanup not to close that handle.
291
4d3fcc8e
BK
2922011-05-07 Ben Key <bkey76@gmail.com>
293
294 * makefile.w32-in: The bootstrap-temacs rule now makes use of
295 one of two shell specific rules, either bootstrap-temacs-CMD or
296 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
297 to the previous implementation of the bootstrap-temacs rule.
298 The bootstrap-temacs-CMD rule is similar to the previous
299 implementation of the bootstrap-temacs rule except that it
300 makes use of the ESC_CFLAGS variable instead of the CFLAGS
301 variable.
302
303 These changes, along with some changes to nt/configure.bat,
304 nt/gmake.defs, and nt/nmake.defs, are required to extend my
305 earlier fix to add support for --cflags and --ldflags options
306 that include quotes so that it works whether make uses cmd or
307 sh as the shell.
308
b4289b64
MA
3092011-05-06 Michael Albinus <michael.albinus@gmx.de>
310
311 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
312 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
313 is a constant.
314 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
315 a string. Handle both cases.
316 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
317 (Fdbus_register_method): Use Qinvalid_function.
318
af4c0e28
JB
3192011-05-06 Juanma Barranquero <lekktu@gmail.com>
320
321 * makefile.w32-in: Update dependencies.
322 (LISP_H): Add inttypes.h and stdin.h.
323 (PROCESS_H): Add unistd.h.
324
c51453d9
EZ
3252011-05-06 Eli Zaretskii <eliz@gnu.org>
326
327 * lread.c: Include limits.h (fixes the MS-Windows build broken by
328 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
329
8ff0ac3c 3302011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 331
4c4b566b
PE
332 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
333
aab2b9b5
PE
334 * term.c (vfatal): Remove stray call to va_end.
335 It's not needed and the C Standard doesn't allow it here anyway.
336
c378da0b
PE
337 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
338 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
339
288b08c7
PE
340 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
341 bytes.
342
e3601888
PE
343 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
344
db6c0e74
PE
345 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
346
dd5963ea
PE
347 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
348
88c9450f
PE
349 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
350
2f9442b8
PE
351 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
352
c032b5f8
PE
353 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
354 * charset.c (Fdefine_charset_internal): Don't initialize
355 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 356 32-bit int (Bug#8600).
a108c10b
PE
357
358 * lread.c (read_integer): Be more consistent with string-to-number.
359 Use string_to_number to do the actual conversion; this avoids
360 rounding errors and fixes some other screwups. Without this fix,
361 for example, #x1fffffffffffffff was misread as -2305843009213693952.
362 (digit_to_number): Move earlier, for benefit of read_integer.
363 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 364 not a digit in any supported base. (Bug#8602)
a108c10b 365
ad5f9eea
PE
366 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
367
aec1708a
PE
368 * dispnew.c (scrolling_window): Return 1 if we scrolled,
369 to match comment at start of function. This also removes a
370 GCC warning about overflow in a 32+64-bit port.
371
47be4ab5
PE
372 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
373
371cac43
PE
374 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
375 Reported by Stefan Monnier in
376 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
377 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
378 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 379
d01a7826
PE
380 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
381 (EMACS_UINTPTR): Likewise, with uintptr_t.
382
7fd47d5c
PE
383 * lisp.h: Prefer 64-bit EMACS_INT if available.
384 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
385 on 32-bit hosts that have 64-bit int, so that they can access
386 large files.
122b0c86
PE
387 However, temporarily disable this change unless the temporary
388 symbol WIDE_EMACS_INT is defined.
7fd47d5c 389
8727937b
PE
390 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
391
8ac068ac
PE
392 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
393 This removes an assumption that EMACS_INT and long are the same
394 width as pointers. The assumption is true for Emacs porting targets
395 now, but we want to make other targets possible.
396 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
397 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
398 In the rest of the code, change types of integers that hold casted
399 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
400 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
401 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
402 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
403 No need to cast type when ORing.
404 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
405 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
406 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
407 assume EMACS_INT is the same width as char *.
408 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
409 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
410 Remove no-longer-needed casts.
411 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
412 (xg_tool_bar_help_callback, xg_make_tool_item):
413 Use EMACS_INTPTR to hold an integer
414 that will be cast to void *; this can avoid a GCC warning
415 if EMACS_INT is not the same width as void *.
416 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
417 * xdisp.c (display_echo_area_1, resize_mini_window_1):
418 (current_message_1, set_message_1):
419 Use a local to convert to proper width without a cast.
420 * xmenu.c (dialog_selection_callback): Likewise.
421
ede49d71
PE
422 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
423 Also, don't assume VALBITS / RAND_BITS is less than 5,
424 and don't rely on undefined behavior when shifting a 1 left into
425 the sign bit.
426 * lisp.h (get_random): Change signature to match.
427
2f30ecd0
PE
428 * lread.c (hash_string): Use size_t, not int, for hash computation.
429 Normally we prefer signed values; but hashing is special, because
430 it's better to use unsigned division on hash table sizes so that
431 the remainder is nonnegative. Also, size_t is the natural width
432 for hashing into memory. The previous code used 'int', which doesn't
433 retain enough info to hash well into very large tables.
434 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
435
2a866e7b
PE
436 * dbusbind.c: Don't possibly lose pointer info when converting.
437 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
438 Use XPNTR rather than XHASH, so that the high-order bits of
439 the pointer aren't lost when converting through void *.
440
51639eac
PE
441 * eval.c (Fautoload): Don't double-shift a pointer.
442
92394119
PE
443 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
444
dbdb9a7c
JB
4452011-05-06 Juanma Barranquero <lekktu@gmail.com>
446
447 * gnutls.c (DEF_GNUTLS_FN):
448 * image.c (DEF_IMGLIB_FN): Make function pointers static.
449
db7a0b4f
AS
4502011-05-05 Andreas Schwab <schwab@linux-m68k.org>
451
452 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
453 marker. (Bug#8610)
454
f7ff1b0f 4552011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
456
457 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
458 New version that can reserve upto 2GB of heap space.
459
f7ff1b0f 4602011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
461
462 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
463
639c109b
TZ
4642011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
465
466 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
467 `gnutls_certificate_set_x509_key_file'.
468
d2127135
JB
4692011-05-05 Juanma Barranquero <lekktu@gmail.com>
470
471 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
472 Update dependencies.
473
e968f4f3
JB
4742011-05-04 Juanma Barranquero <lekktu@gmail.com>
475
476 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
477 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
478 Remove unused parameter `fildes'.
479 * process.c (read_process_output, send_process): Don't pass it.
480
84d358f0
JB
4812011-05-04 Juanma Barranquero <lekktu@gmail.com>
482
483 Fix previous change: the library cache is defined in w32.c.
484 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
485 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
486
0898ca10
JB
4872011-05-04 Juanma Barranquero <lekktu@gmail.com>
488
489 Implement dynamic loading of GnuTLS on Windows.
490
491 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
492 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
493 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
494 Declare.
495
496 * gnutls.c (Qgnutls_dll): Define.
497 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
498 (gnutls_*): Declare function pointers.
499 (init_gnutls_functions): New function to initialize function pointers.
500 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
501 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
502 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
503 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
504 (emacs_gnutls_write, emacs_gnutls_read)
505 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
506 (Fgnutls_available_p): New function.
507 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
508 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
509 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
510
511 * image.c: Include w32.h.
512 (Vimage_type_cache): Delete.
513 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
514 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
515 (w32_delayed_load): Move to w32.c.
516
517 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
518
519 * w32.c (QCloaded_from, Vlibrary_cache): Define.
520 (w32_delayed_load): Move from image.c. When loading a library, record
521 its filename in the :loaded-from property of the library id.
522 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
523 Initialize and staticpro them.
524 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
525
526 * process.c: Include lisp.h before w32.h, not after.
527 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
528 instead of gnutls_record_check_pending.
529
530 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
531
ff4de4aa
TZ
5322011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
533
534 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
535 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
536 as passed in.
537
abe95abb
JD
5382011-05-03 Jan Djärv <jan.h.d@swipnet.se>
539
540 * xterm.c (x_set_frame_alpha): Do not set property on anything
541 else than FRAME_X_OUTER_WINDOW (Bug#8608).
542
e16e55d4
JB
5432011-05-02 Juanma Barranquero <lekktu@gmail.com>
544
545 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
546
bafcf6a5
JB
5472011-05-02 Juanma Barranquero <lekktu@gmail.com>
548
549 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
550 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
551 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
552 (gnutls_global_initialized, Qgnutls_bootprop_priority)
553 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
554 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
555 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
556 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
557 (Qgnutls_bootprop_callbacks_verify): Make static.
558
e7a6747f
AS
5592011-05-01 Andreas Schwab <schwab@linux-m68k.org>
560
19ed11ba
AS
561 * callproc.c: Indentation fixup.
562
e7a6747f 563 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
564 (wait_for_termination, interruptible_wait_for_termination):
565 Move after wait_for_termination_1.
e7a6747f 566
1ef14cb4
LMI
5672011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
568
569 * sysdep.c (interruptible_wait_for_termination): New function
570 which is like wait_for_termination, but allows keyboard
571 interruptions.
572
573 * callproc.c (Fcall_process): Add (:file "file") as an option for
574 the STDOUT buffer.
575 (Fcall_process_region): Ditto.
576
330d880c
EZ
5772011-04-30 Eli Zaretskii <eliz@gnu.org>
578
8db90b73
EZ
579 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
580 rather than `XVECTOR (FOO)->size'.
581
330d880c
EZ
582 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
583 inttypes.h, as a gnulib replacement is used if it not available in
584 system headers.
585
15cbd324
EZ
5862011-04-21 Eli Zaretskii <eliz@gnu.org>
587
588 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
589 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
590 of MOST_POSITIVE_FIXNUM. (Bug#8528)
591
592 * coding.c (coding_alloc_by_realloc): Error out if destination
593 will grow beyond MOST_POSITIVE_FIXNUM.
594 (decode_coding_emacs_mule): Abort if there isn't enough place in
595 charbuf for the composition carryover bytes. Reserve an extra
596 space for up to 2 characters produced in a loop.
597 (decode_coding_iso_2022): Abort if there isn't enough place in
598 charbuf for the composition carryover bytes.
599
6002011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 601
ae940cca
EZ
602 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
603 aborting when %lld or %lll format is passed.
604 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
605 %llo or %llx format is passed. (Bug#8545)
606
03ab8921
EZ
607 * window.c (window_scroll_line_based): Use a marker instead of
608 simple variables to record original value of point. (Bug#7952)
609
afda1437
EZ
610 * doprnt.c (doprnt): Fix the case where a multibyte sequence
611 produced by %s or %c overflows available buffer space. (Bug#8545)
612
f76dee0c
PE
6132011-04-28 Paul Eggert <eggert@cs.ucla.edu>
614
615 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 616 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 617
fdc5744d
JB
6182011-04-28 Juanma Barranquero <lekktu@gmail.com>
619
620 * w32.c (init_environment): Warn about defaulting HOME to C:\.
621
638f053a
JB
6222011-04-28 Juanma Barranquero <lekktu@gmail.com>
623
624 * keyboard.c (Qdelayed_warnings_hook): Define.
625 (command_loop_1): Run `delayed-warnings-hook'
626 if Vdelayed_warnings_list is non-nil.
627 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
628 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
629
d178f871
EZ
6302011-04-28 Eli Zaretskii <eliz@gnu.org>
631
632 * doprnt.c (doprnt): Don't return value smaller than the buffer
633 size if the message was truncated. (Bug#8545).
634
b124fd93
JB
6352011-04-28 Juanma Barranquero <lekktu@gmail.com>
636
637 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
638 (Fx_window_property): #if-0 the whole functions, not just the bodies.
639
e810457d
PE
6402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
641
642 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
643
ea51cceb
JB
6442011-04-27 Juanma Barranquero <lekktu@gmail.com>
645
646 * makefile.w32-in: Update dependencies.
647
94dcfacf
EZ
6482011-04-27 Eli Zaretskii <eliz@gnu.org>
649
650 Improve `doprnt' and its usage. (Bug#8545)
651 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
652 `format_end'. Remove support for %l as a conversion specifier.
653 Don't use xrealloc. Improve diagnostics when the %l size modifier
654 is used. Update the commentary.
655
656 * eval.c (verror): Simplify calculation of size_t.
657
658 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
659 messages.
660
f61f41d7
PE
6612011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
662
663 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
664 change.
665
96fb4434
PE
6662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
667
668 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
669 This makes this file independent of the recent pseudovector change.
670
671875da 6712011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 672
69e9b5a3
PE
673 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
674
b5f869a7 675 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 676 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 677 Remove unused local.
c8926152 678 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 679
841a1577 680 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
681 GCC 4.6.0 optimizes based on type-based alias analysis.
682 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
683 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
684 != &v->size, and therefore "v->size = 1; b->size = 2; return
685 v->size;" must therefore return 1. This assumption is incorrect
686 for Emacs, since it type-puns struct Lisp_Vector * with many other
687 types. To fix this problem, this patch adds a new type struct
f904488f 688 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
689 and pseudovectors, and helps optimizing compilers not get fooled
690 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
691 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
692 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
693 the size member.
eab3844f
PE
694 (XSETPVECTYPE): Rewrite in terms of new macro.
695 (XSETPVECTYPESIZE): New macro, specifying both type and size.
696 This is a bit clearer, and further avoids the possibility of
697 undesirable aliasing.
698 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 699 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
700 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
701 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
702 (ASIZE): Now uses header.size rather than size.
703 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
704 to avoid the hassle of writing XVECTOR (foo)->header.size.
705 (struct vectorlike_header): New type.
eab3844f
PE
706 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
707 object, to help avoid aliasing.
708 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
709 (SUBRP): Likewise, since Lisp_Subr is a special case.
710 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
711 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
712 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 713 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
714 changed to be "header.size" and "header.next".
715 * buffer.h (struct buffer): Likewise.
716 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
717 * frame.h (struct frame): Likewise.
718 * process.h (struct Lisp_Process): Likewise.
719 * termhooks.h (struct terminal): Likewise.
720 * window.c (struct save_window_data, struct saved_window): Likewise.
721 * window.h (struct window): Likewise.
722 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
723 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
724 * buffer.c (init_buffer_once): Likewise.
725 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
726 special case.
727 * process.c (Fformat_network_address): Use local var for size,
728 for brevity.
729
0df1eac5
PE
730 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
731
847ab9d1 732 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
733 * data.c (atof): Remove decl; no longer used or needed.
734 (digit_to_number): Move to lread.c.
735 (Fstring_to_number): Use new string_to_number function, to be
736 consistent with how the Lisp reader treats infinities and NaNs.
737 Do not assume that floating-point numbers represent EMACS_INT
738 without losing information; this is not true on most 64-bit hosts.
739 Avoid double-rounding errors, by insisting on integers when
740 parsing non-base-10 numbers, as the documentation specifies.
741 * lisp.h (string_to_number): New decl, replacing ...
742 (isfloat_string): Remove.
bc0a5c13 743 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 744 (read1): Do not accept +. and -. as integers; this
452f4150
PE
745 appears to have been a coding error. Similarly, do not accept
746 strings like +-1e0 as floating point numbers. Do not report
747 overflow for integer overflows unless the base is not 10 which
748 means we have no simple and reliable way to continue.
749 Break out the floating-point parsing into a new
750 function string_to_number, so that Fstring_to_number parses
751 floating point numbers consistently with the Lisp reader.
04f2d78b 752 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
753 (E_CHAR, EXP_INT): Remove, replacing with ...
754 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
755 (string_to_number): New function, replacing isfloat_string.
756 This function checks for valid syntax and produces the resulting
757 Lisp float number too. Rework it so that string-to-number
bc0a5c13 758 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
759 so that overflow for non-base-10 numbers is reported only when
760 there's no portable and simple way to convert to floating point.
452f4150 761
67769ffc
PE
762 * textprop.c (set_text_properties_1): Rewrite for clarity,
763 and to avoid GCC warning about integer overflow.
764
c20db43f
PE
765 * intervals.h (struct interval): Use EMACS_INT for members
766 where EMACS_UINT might cause problems. See
767 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
768 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
769 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
770 All uses changed.
37aa2f85
PE
771 (offset_intervals): Tell GCC not to worry about length overflow
772 when negating a negative length.
c20db43f 773
2538aa2f
PE
774 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
775 (overrun_check_free): Likewise.
776
f2d3008d
PE
777 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
778 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
779 word size.
780
ec8df744
PE
781 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
782 (gnutls_make_error): Rename local to avoid shadowing.
783 (gnutls_emacs_global_deinit): ifdef out; not used.
784 (Fgnutls_boot): Use const for pointer to readonly storage.
785 Comment out unused local. Fix pointer signedness problems.
786
640ee02d
PE
787 * lread.c (openp): Don't stuff size_t into an 'int'.
788 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
789 about possible signed overflow.
790
6048fb2a
PE
791 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
792 (GDK_KEY_g): Don't define if already defined.
793 (xg_prepare_tooltip): Avoid pointer signedness problem.
794 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
795
fa3c87e1
PE
796 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
797 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
798
2172544b
PE
799 * xfns.c (Fx_window_property): Simplify a bit,
800 to make a bit faster and to avoid GCC 4.6.0 warning.
801 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
802
9b821a21
PE
803 * fns.c (internal_equal): Don't assume size_t fits in int.
804
3c616cfa
PE
805 * alloc.c (compact_small_strings): Tighten assertion a little.
806
c2982e87
PE
807 Replace pEd with more-general pI, and fix some printf arg casts.
808 * lisp.h (pI): New macro, generalizing old pEd macro to other
809 conversion specifiers. For example, use "...%"pI"d..." rather
810 than "...%"pEd"...".
811 (pEd): Remove. All uses replaced with similar uses of pI.
812 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
813 * alloc.c (check_pure_size): Don't overflow by converting size to int.
814 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
815 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
816 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
817 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
818 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
819 64-bit hosts.
820 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
821 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
822 * print.c (safe_debug_print, print_object): Likewise.
823 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
824 to int.
6f04d126
PE
825 Use pI instead of if-then-else-abort. Use %p to avoid casts,
826 avoiding the 0 flag, which is not portable.
c2982e87
PE
827 * process.c (Fmake_network_process): Use pI to avoid cast.
828 * region-cache.c (pp_cache): Likewise.
829 * xdisp.c (decode_mode_spec): Likewise.
830 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
831 behavior on 64-bit hosts with printf arg.
6f04d126 832 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
833 (x_stop_queuing_selection_requests): Likewise.
834 (x_get_window_property): Don't truncate byte count to an 'int'
835 when tracing.
0b432f21 836
5e073ec7
PE
837 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
838 here, since it parses constructs like leading '-' and spaces,
839 which are not wanted; and it overflows with large numbers.
840 Instead, simply match F[0-9]+, which is what is wanted anyway.
841
36372bf9
PE
842 * alloc.c: Remove unportable assumptions about struct layout.
843 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
844 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
845 (allocate_vectorlike, make_pure_vector): Use the new macros,
846 plus offsetof, to remove unportable assumptions about struct layout.
847 These assumptions hold on all porting targets that I know of, but
848 they are not guaranteed, they're easy to remove, and removing them
849 makes further changes easier.
850
0b432f21
PE
851 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
852 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
853 (string_overrun_cookie): Now const. Use initializers that
854 don't formally overflow signed char, to avoid warnings.
000098c1
PE
855 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
856 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
857 (allocate_buffer): Don't assume sizeof (struct buffer) is a
858 multiple of sizeof (EMACS_INT); it need not be, if
859 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 860 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 861
895009e1
JB
8622011-04-26 Juanma Barranquero <lekktu@gmail.com>
863
864 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
865
6a7a1b0b
TZ
8662011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
867
868 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 869 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
870 Reported by Paul Eggert <eggert@cs.ucla.edu>.
871
841a1577 8722011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
873
874 * lisp.h (Qdebug): List symbol.
895009e1 875 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
876 * keyboard.c (debug-on-event): New variable.
877 (handle_user_signal): Break into debugger when debug-on-event
878 matches the current signal symbol.
879
f2d3ba6f
DN
8802011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
881
882 * alloc.c (check_sblock, check_string_bytes)
883 (check_string_free_list): Convert to standard C.
884
42ce4c63
TZ
8852011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
886
887 * w32.c (emacs_gnutls_push): Fix typo.
888
825cd63c
EZ
8892011-04-25 Eli Zaretskii <eliz@gnu.org>
890
fb11d64d
EZ
891 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
892 "cast to pointer from integer of different size".
893
825cd63c
EZ
894 Improve doprnt and its use in verror. (Bug#8545)
895 * doprnt.c (doprnt): Document the set of format control sequences
896 supported by the function. Use SAFE_ALLOCA instead of always
897 using `alloca'.
898
899 * eval.c (verror): Don't limit the buffer size at size_max-1, that
900 is one byte too soon. Don't use xrealloc; instead xfree and
901 xmalloc anew.
902
e061a11b
TZ
9032011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
904
905 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
906 callbacks stage.
907
908 * gnutls.c: Renamed global_initialized to
909 gnutls_global_initialized. Added internals for the
910 :verify-hostname-error, :verify-error, and :verify-flags
911 parameters of `gnutls-boot' and documented those parameters in the
912 docstring. Start callback support.
913 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
914 unless a fatal error occured. Call gnutls_alert_send_appropriate
915 on error. Return error code.
916 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
917 (emacs_gnutls_read): Likewise.
918 (Fgnutls_boot): Return handshake error code.
919 (emacs_gnutls_handle_error): New function.
920 (wsaerror_to_errno): Likewise.
921
922 * w32.h (emacs_gnutls_pull): Add prototype.
923 (emacs_gnutls_push): Likewise.
924
925 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
926 (emacs_gnutls_push): Likewise.
927
9282011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
929
930 * process.c (wait_reading_process_output): Check if GnuTLS
931 buffered some data internally if no FDs are set for TLS
932 connections.
933
934 * makefile.w32-in (OBJ2): Add gnutls.$(O).
935 (LIBS): Link to USER_LIBS.
936 ($(BLD)/gnutls.$(0)): New target.
937
fa6996bc
EZ
9382011-04-24 Eli Zaretskii <eliz@gnu.org>
939
eb35682e
EZ
940 * xdisp.c (handle_single_display_spec): Rename the
941 display_replaced_before_p argument into display_replaced_p, to
942 make it consistent with the commentary. Fix typos in the
943 commentary.
944
e2ad650c
EZ
945 * textprop.c (syms_of_textprop): Remove dead code.
946 (copy_text_properties): Delete obsolete commentary about an
947 interface that was deleted long ago. Fix typos in the description
948 of arguments.
949
1b2de274
EZ
950 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
951 to changes in oldXMenu/XMenu.h from 2011-04-16.
952 <menu_help_message, prev_menu_help_message>: Constify.
953 (IT_menu_make_room): menu->help_text is now `const char **';
954 adjust.
955
956 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
957 to changes in oldXMenu/XMenu.h from 2011-04-16.
958 (struct XMenu): Declare `help_text' `const char **'.
959
960 * xfaces.c <Qunspecified>: Make extern again.
961
962 * syntax.c: Include sys/types.h before including regex.h, as
963 required by Posix.
964
762b15be
EZ
965 * doc.c (get_doc_string): Improve the format passed to `error'.
966
967 * doprnt.c (doprnt): Improve commentary.
968
969 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
970
971 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
972 them with etags.
973
f1052e5d
EZ
974 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
975 changes in globals.h immediately force recompilation.
762b15be
EZ
976 (TAGS): Depend on $(CURDIR)/m/intel386.h and
977 $(CURDIR)/s/ms-w32.h.
978 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 979
fa6996bc
EZ
980 * character.c (Fchar_direction): Function deleted.
981 (syms_of_character): Don't defsubr it.
982 <char-direction-table>: Deleted.
983
e6c3da20
EZ
9842011-04-23 Eli Zaretskii <eliz@gnu.org>
985
986 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
987 * doprnt.c: Include limits.h.
988 (SIZE_MAX): New macro.
04f2d78b
CB
989 (doprnt): Return a size_t value. 2nd arg is now size_t.
990 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
991 Improve overflow protection. Support `l' modifier for integer
992 conversions. Support %l conversion. Don't assume an EMACS_INT
993 argument for integer conversions and for %c.
994
995 * lisp.h (doprnt): Restore prototype.
996
997 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
998 $(SRC)/character.h.
999
1000 * Makefile.in (base_obj): Add back doprnt.o.
1001
1002 * deps.mk (doprnt.o): Add back prerequisites.
1003 (callint.o): Depend on character.h.
1004
1005 * eval.c (internal_lisp_condition_case): Include the handler
1006 representation in the error message.
1007 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1008 when breaking from the loop.
1009
1010 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1011
1012 * callint.c (Fcall_interactively): When displaying error message
1013 about invalid control letter, pass the character's codepoint, not
1014 a pointer to its multibyte form. Improve display of the character
1015 in octal and display also its hex code.
1016
1017 * character.c (char_string): Use %x to display the (unsigned)
1018 codepoint of an invalid character, to avoid displaying a bogus
1019 negative value.
1020
1021 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1022 `error', not SYMBOL_NAME itself.
1023
1024 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1025 character arguments to `error'.
1026
1027 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1028 to `error' in error message about FINAL_CHAR argument. Make sure
1029 FINAL_CHAR is a character, and use %c when it is passed as
1030 argument to `error'.
1031
4ffd0d6b 10322011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1033
1034 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1035
1036 * w32.c: Include <time.h>.
1037 (sys_localtime): New function.
1038
4ffd0d6b 10392011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1040
1041 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1042
4ffd0d6b 1043 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1044
4ffd0d6b 10452011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1046
4ffd0d6b
GM
1047 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1048 zombies (Bug#8467).
aac0c6e3 1049
04c56954
EZ
10502011-04-19 Eli Zaretskii <eliz@gnu.org>
1051
1052 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1053 gl_state.e_property when gl_state.object is Qt.
1054
1055 * insdel.c (make_gap_larger): Remove limitation of buffer size
1056 to <= INT_MAX.
1057
16a43933
CY
10582011-04-18 Chong Yidong <cyd@stupidchicken.com>
1059
1060 * xdisp.c (lookup_glyphless_char_display)
1061 (produce_glyphless_glyph): Handle cons cell entry in
1062 glyphless-char-display.
1063 (Vglyphless_char_display): Document it.
1064
1065 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1066 glyphless-char-display.
1067
4581706e
CY
10682011-04-17 Chong Yidong <cyd@stupidchicken.com>
1069
1070 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1071
1072 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1073
1074 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1075 definition for no-X builds.
1076
4887c6e2 10772011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1078
fd35b6f9
PE
1079 Static checks with GCC 4.6.0 and non-default toolkits.
1080
5c1ccb01
PE
1081 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1082
006c5daa
PE
1083 * process.c (keyboard_bit_set): Define only if SIGIO.
1084 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1085 (send_process): Repair possible setjmp clobbering.
1086
efc736d3
PE
1087 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1088
4e2fe2e6
PE
1089 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1090
f97334a2
PE
1091 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1092
4e75f29d
PE
1093 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1094 Define only if needed.
1095
90efadd1
PE
1096 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1097 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1098 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1099
3c647824
PE
1100 * dispextern.h (struct redisplay_interface): Rename param
1101 to avoid shadowing.
e264f262 1102 * termhooks.h (struct terminal): Likewise.
761383f4 1103 * xterm.c (xembed_send_message): Likewise.
3c647824 1104
b58c5c4a
PE
1105 * insdel.c (make_gap_smaller): Define only if
1106 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1107
cad59032
PE
1108 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1109 it.
1110
c339dc2e
PE
1111 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1112 so that we aren't warned about unused symbols.
1113
91a3e27b
PE
1114 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1115
399c71d3 1116 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1117
8ffc96f5
PE
1118 * xfns.c (x_real_positions): Mark locals as initialized.
1119
eef9bc79
PE
1120 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1121
098db9dd
PE
1122 * xterm.c: Fix problems found by static analysis with other toolkits.
1123 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1124 (x_dispatch_event): Declare static if USE_GTK, and
1125 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1126 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1127 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1128 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1129 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1130
eb18f6cc
PE
1131 * xmenu.c (menu_help_callback): Pointer type fixes.
1132 Use const pointers when pointing at readonly data. Avoid pointer
1133 signedness clashes.
1134 (FALSE): Remove unused macro.
1135 (update_frame_menubar): Remove unused decl.
1136
1fe72bf8
PE
1137 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1138
60d9e1db
PE
1139 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1140 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1141 (single_menu_item): Rename local to avoid shadowing.
1142
39261c26
PE
1143 * keyboard.c (make_lispy_event): Remove unused local var.
1144
018c5e19
PE
1145 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1146 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1147
63d2b86e
PE
1148 * bitmaps: Change bitmaps from unsigned char back to the X11
1149 compatible char. Avoid the old compiler warnings about
1150 out-of-range initializers by using, for example, '\xab' rather
1151 than 0xab.
1152
aefd87e1
PE
1153 * xgselect.c (xgselect_initialize): Check vs interface
1154 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1155
bf501fb9
PE
1156 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1157
e9829fdf
PE
1158 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1159 to read-only memory.
1160
1086c095
PE
1161 * fns.c (vector): Remove; this old hack is no longer needed.
1162
2baccd04 1163 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1164 Remove unused var.
dde42981 1165 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1166
72391843 1167 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1168
436c16df 1169 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1170 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1171 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1172
92bb796d 1173 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1174 (x_term_init): Remove local to avoid shadowing.
92bb796d 1175
764430a3 1176 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1177
1178 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1179 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1180
d1dfb56c
EZ
11812011-04-16 Eli Zaretskii <eliz@gnu.org>
1182
c4354cb4
EZ
1183 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1184
d1dfb56c
EZ
1185 Fix regex.c, syntax.c and friends for buffers > 2GB.
1186 * syntax.h (struct gl_state_s): Declare character position members
1187 EMACS_INT.
1188
1189 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1190
04f2d78b
CB
1191 * textprop.c (verify_interval_modification, interval_of):
1192 Declare arguments EMACS_INT.
d1dfb56c
EZ
1193
1194 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1195 EMACS_INT.
1196
1197 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1198
1199 * indent.c (Fvertical_motion): Local variable it_start is now
1200 EMACS_INT.
1201
1202 * regex.c (re_match, re_match_2, re_match_2_internal)
1203 (bcmp_translate, regcomp, regexec, print_double_string)
1204 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1205 (re_compile_pattern, re_exec): Declare arguments and local
1206 variables `size_t' and `ssize_t' and return values `regoff_t', as
1207 appropriate.
1208 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1209 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1210 <compile_stack_type>: `size' and `avail' are now `size_t'.
1211
1212 * regex.h <regoff_t>: Use ssize_t, not int.
1213 (re_search, re_search_2, re_match, re_match_2): Arguments that
1214 specify buffer/string position and length are now ssize_t and
1215 size_t. Return type is regoff_t.
1216
613052cd
BK
12172011-04-16 Ben Key <bkey76@gmail.com>
1218
1219 * nsfont.m: Fixed bugs in ns_get_family and
1220 ns_descriptor_to_entity that were caused by using free to
1221 deallocate memory blocks that were allocated by xmalloc (via
1222 xstrdup). This caused Emacs to crash when compiled with
1223 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1224 --enable-checking=xmallocoverrun). xfree is now used to
1225 deallocate these memory blocks.
1226
4170f62f 12272011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1228
71b41406
PE
1229 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1230
9587a89d
PE
1231 emacs_write: Accept and return EMACS_INT for sizes.
1232 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1233 et seq.
1234 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1235 Accept and return EMACS_INT.
1236 (emacs_gnutls_write): Return the number of bytes written on
1237 partial writes.
1238 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1239 (emacs_read, emacs_write): Remove check for negative size, as the
1240 Emacs source code has been audited now.
9587a89d
PE
1241 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1242 (emacs_read, emacs_write): Use it.
273a5f82
PE
1243 * process.c (send_process): Adjust to the new signatures of
1244 emacs_write and emacs_gnutls_write. Do not attempt to store
1245 a byte offset into an 'int'; it might overflow.
9587a89d 1246 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1247
3e047f51
PE
1248 * sound.c: Don't assume sizes fit in 'int'.
1249 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1250 Return EMACS_INT, not int.
3e047f51 1251 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1252 Accept EMACS_INT, not int.
1253 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1254 record read return values.
1255
cc39a9db
BK
12562011-04-15 Ben Key <bkey76@gmail.com>
1257
c9d0ec6d
JB
1258 * keyboard.c (Qundefined): Don't declare static since it is used
1259 in nsfns.m.
1260 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1261 static since they are used in nsfont.m.
cc39a9db 1262
6c60eb9f
SM
12632011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1264
1265 * process.c (Qprocessp): Don't declare static.
1266 * lisp.h (Qprocessp): Declare again.
1267
7990b61a
JB
12682011-04-15 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1271
5d4cb038
PE
12722011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1273
8bd7b830 1274 Improve C-level modularity by making more things 'static'.
cd64ea1d 1275
e3b27b31
PE
1276 Don't publish debugger-only interfaces to other modules.
1277 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1278 (verify_bytepos, count_markers): Move decls to the only modules
1279 that need them.
1280 * region-cache.h (pp_cache): Likewise.
1281 * window.h (check_all_windows): Likewise.
1282 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1283
5d4cb038
PE
1284 * sysdep.c (croak): Now static, if
1285 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1286 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1287
1288 * alloc.c (refill_memory_reserve): Now static if
1289 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1290 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1291
e87b6180
PE
1292 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1293 Define only if USE_LUCID.
1294
ac64929e
PE
1295 * xrdb.c (x_customization_string, x_rm_string): Now static.
1296
6f37259d
PE
1297 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1298 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1299
1683e3ab
PE
1300 * xdisp.c (draw_row_with_mouse_face): Now static.
1301 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1302
de9c2632
PE
1303 * window.h (check_all_windows): Mark externally visible.
1304
2b96acb7
PE
1305 * window.c (window_deletion_count): Now static.
1306
1307 * undo.c: Make symbols static if they're not exported.
1308 (last_undo_buffer, last_boundary_position, pending_boundary):
1309 Now static.
1310
50436f33
PE
1311 * textprop.c (interval_insert_behind_hooks): Now static.
1312 (interval_insert_in_front_hooks): Likewise.
1313
64520e5c
PE
1314 * term.c: Make symbols static if they're not exported.
1315 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1316 (max_frame_lines, tty_set_terminal_modes):
1317 (tty_reset_terminal_modes, tty_turn_off_highlight):
1318 (get_tty_terminal): Now static.
1319 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1320 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1321 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1322 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1323 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1324
1fa53021
PE
1325 * sysdep.c: Make symbols static if they're not exported.
1326 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1327 Now static.
1328 (sigprocmask_set, full_mask): Remove; unused.
1329 (wait_debugging): Mark as visible.
1330 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1331 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1332
d4b43b22
PE
1333 * syntax.c (syntax_temp): Define only if !__GNUC__.
1334
b7c513d0
PE
1335 * sound.c (current_sound_device, current_sound): Now static.
1336
989b29ad
PE
1337 * search.c (searchbufs, searchbuf_head): Now static.
1338
13a55a78
PE
1339 * scroll.c (scroll_cost): Remove; unused.
1340 * dispextern.h (scroll_cost): Remove decl.
1341
de68a1fc
PE
1342 * region-cache.h (pp_cache): Mark as externally visible.
1343
40ccffa6
PE
1344 * process.c: Make symbols static if they're not exported.
1345 (process_tick, update_tick, create_process, chan_process):
1346 (Vprocess_alist, proc_buffered_char, datagram_access):
1347 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1348 (deactivate_process): Mark defn as static, as well as decl.
1349 * lisp.h (create_process): Remove decl.
1350 * process.h (chan_process, Vprocess_alist): Remove decls.
1351
ad64fc97
PE
1352 * print.c: Make symbols static if they're not exported.
1353 (print_depth, new_backquote_output, being_printed, print_buffer):
1354 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1355 (print_interval, print_number_index, initial_stderr_stream):
1356 Now static.
1357 * lisp.h (Fprinc): Remove decl.
1358 (debug_output_compilation_hack): Mark as externally visible.
1359
adddb265
PE
1360 * sysdep.c (croak): Move decl from here to syssignal.h.
1361 * syssignal.h (croak): Put it here, so the API can be checked when
1362 'croak' is called from dissociate_if_controlling_tty.
1363
1717ede2
PE
1364 * minibuf.c: Make symbols static if they're not exported.
1365 (minibuf_save_list, choose_minibuf_frame): Now static.
1366 * lisp.h (choose_minibuf_frame): Remove decl.
1367
fa5fb2bc
PE
1368 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1369
1e3890d1
PE
1370 * lread.c: Make symbols static if they're not exported.
1371 (read_objects, initial_obarray, oblookup_last_bucket_number):
1372 Now static.
1373 (make_symbol): Remove; unused.
1374 * lisp.h (initial_obarray, make_symbol): Remove decls.
1375
8a1414fa
PE
1376 * keyboard.c: Make symbols static if they're not exported.
1377 (single_kboard, recent_keys_index, total_keys, recent_keys):
1378 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1379 (this_single_command_key_start, echoing, last_auto_save):
1380 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1381 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1382 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1383 (Vlispy_mouse_stem, double_click_count):
1384 Now static.
1385 (force_auto_save_soon): Define only if SIGDANGER.
1386 (ignore_mouse_drag_p): Now static if
1387 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1388 (print_help): Remove; unused.
1389 (stop_character, last_timer_event): Mark as externally visible.
1390 * keyboard.h (ignore_mouse_drag_p): Declare only if
1391 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1392 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1393 * lisp.h (echoing): Remove decl.
1394 (force_auto_save_soon): Declare only if SIGDANGER.
1395 * xdisp.c (redisplay_window): Simplify code, to make it more
1396 obvious that ignore_mouse_drag_p is not accessed if !defined
1397 USE_GTK && !defined HAVE_NS.
1398
93ea6e8f
PE
1399 * intervals.c: Make symbols static if they're not exported.
1400 (merge_properties_sticky, merge_interval_right, delete_interval):
1401 Now static.
1402 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1403
77382fcc
PE
1404 * insdel.c: Make symbols static if they're not exported.
1405 However, leave prepare_to_modify_buffer alone. It's never
1406 called from outside this function, but that appears to be a bug.
1407 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1408 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1409 (adjust_after_replace_noundo): Remove; unused.
1410 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1411 (signal_before_change): Remove decls.
77382fcc 1412
9306c32e
PE
1413 * indent.c (val_compute_motion, val_vmotion): Now static.
1414
cd44d2eb
PE
1415 * image.c: Make symbols static if they're not exported.
1416 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1417 if USE_GTK.
1418 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1419 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1420
ad9a7a06
PE
1421 * fringe.c (standard_bitmaps): Now static.
1422 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1423
81626931
PE
1424 * frame.c: Make symbols static if they're not exported.
1425 (x_report_frame_params, make_terminal_frame): Now static.
1426 (get_frame_param): Now static, unless HAVE_NS.
1427 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1428 (x_get_resource_string): Remove; not used.
1429 * frame.h (make_terminal_frame, x_report_frame_params):
1430 (x_get_resource_string); Remove decls.
1431 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1432 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1433
239f9db9
PE
1434 * font.c, fontset.c: Make symbols static if they're not exported.
1435 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1436 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1437 * font.c (font_close_object): Now static.
1438 * font.h (font_close_object): Remove.
1439 * fontset.c (FONTSET_OBJLIST): Remove.
1440 (free_realized_fontset) #if-0 the body, which does nothing.
1441 (face_suitable_for_char_p): #if-0, as it's never called.
1442 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1443 * xfaces.c (face_at_string_position):
1444 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1445 since 0 is always ASCII.
1446
dfcf3579
PE
1447 * fns.c (weak_hash_tables): Now static.
1448
5045092b
PE
1449 * fileio.c: Make symbols static if they're not exported.
1450 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1451 (Vwrite_region_annotation_buffers): Now static.
1452
57a96f5c
PE
1453 * eval.c: Make symbols static if they're not exported.
1454 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1455 * lisp.h (backtrace_list): Remove decl.
1456
35f08c38
PE
1457 * emacs.c: Make symbols static if they're not exported.
1458 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1459 (fatal_error_code, fatal_error_signal_hook, standard_args):
1460 Now static.
1461 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1462 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1463 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1464 * lisp.h (fatal_error_signal_hook): Remove decl.
1465 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1466
f44bd759
PE
1467 * editfns.c: Move a (normally-unused) function to its only use.
1468 * editfns.c, lisp.h (get_operating_system_release): Remove.
1469 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1470 worth the hassle of breaking this out.
1471
b532497d
PE
1472 * xterm.c: Make symbols static if they're not exported.
1473 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1474 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1475 (x_destroy_window, x_delete_display):
1476 Now static.
1477 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1478 (x_mouse_leave): Remove; unused.
1479 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1480 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1481 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1482 Remove decls.
1483 (x_mouse_leave): Declare only if WINDOWSNT.
1484 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1485 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1486 USE_X_TOOLKIT.
1487
1675728f
PE
1488 * ftxfont.c: Make symbols static if they're not exported.
1489 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1490 HAVE_FREETYPE.
1491 * font.h (ftxfont_driver): Likewise.
1492
e4cebfca
PE
1493 * xfns.c: Make symbols static if they're not exported.
1494 (x_last_font_name, x_display_info_for_name):
1495 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1496 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1497 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1498 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1499 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1500 (last_show_tip_args): Now static.
1501 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1502 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1503 (x_screen_planes): Remove; unused.
1504 * dispextern.h (x_screen_planes): Remove decl.
1505
5bf46f05
PE
1506 * dispnew.c: Make symbols static if they're not exported.
1507 * dispextern.h (redraw_garbaged_frames, scrolling):
1508 (increment_row_positions): Remove.
1509 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1510 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1511 Now static.
1512 (redraw_garbaged_frames): Remove; unused.
1513
435f4c28
PE
1514 * xfaces.c: Make symbols static if they're not exported.
1515 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1516 Remove decls.
1517 * xterm.h (defined_color): Remove decls.
1518 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1519 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1520 (menu_face_changed_default, defined_color, free_realized_face):
1521 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1522 (ascii_face_of_lisp_face): Remove; unused.
1523
8524aef3
PE
1524 * xdisp.c: Make symbols static if they're not exported.
1525 * dispextern.h (scratch_glyph_row, window_box_edges):
1526 (glyph_to_pixel_coords, set_cursor_from_row):
1527 (get_next_display_element, set_iterator_to_next):
1528 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1529 (show_mouse_face): Remove decls
1530 * frame.h (message_buf_print): Likewise.
1531 * lisp.h (pop_message, set_message, check_point_in_composition):
1532 Likewise.
1533 * xterm.h (set_vertical_scroll_bar): Likewise.
1534 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1535 (message_buf_print, scratch_glyph_row, displayed_buffer):
1536 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1537 (get_next_display_element, show_mouse_face, window_box_edges):
1538 (frame_to_window_pixel_xy, check_point_in_composition):
1539 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1540 (glyph_to_pixel_coords): Remove; unused.
1541
16390cd2
PE
1542 * dired.c (file_name_completion): Now static.
1543
1544 * dbusbind.c (xd_in_read_queued_messages): Now static.
1545
a25f4dfa
PE
1546 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1547 * data.c (circular_list_error): Remove.
1548
14a9c8df
PE
1549 * commands.h (last_point_position, last_point_position_buffer):
1550 (last_point_position_window): Remove decls.
1551 * keyboard.c: Make these variables static.
1552
04f2d78b
CB
1553 * coding.h (coding, code_convert_region, encode_coding_gap):
1554 Remove decls.
74ab6df5
PE
1555 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1556 (iso_code_class, detect_coding, code_convert_region): Now static.
1557 (encode_coding_gap): Remove; unused.
1558
38dfbee1
PE
1559 * chartab.c (chartab_chars, chartab_bits): Now static.
1560
a2cb4e63
PE
1561 * charset.h (charset_iso_8859_1): Remove decl.
1562 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1563 Now static.
1564
127198fd
PE
1565 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1566 * ccl.c (Vccl_program_table): Now static.
1567 (check_ccl_update): Remove; unused.
1568
d85b608f
PE
1569 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1570 * category.h: ... from here.
1571 * category.c (check_category_table, set_category_set): Now static.
1572
31cd66f3
PE
1573 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1574 * lisp.h: Remove these decls.
1575
c358e587
PE
1576 * buffer.c (buffer_count): Remove unused var.
1577
e78aecca
PE
1578 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1579 so that it's not optimized away.
1580 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1581 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1582 exported only to the debugger.
1583
e192d7d3 1584 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1585 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1586
92470028
PE
1587 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1588 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1589 was inaccessible from Lisp.
1590 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1591 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1592
244ed907
PE
1593 alloc.c: Import and export fewer symbols, and remove unused items.
1594 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1595 is defined.
1596 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1597 it's not optimized away by whole-program optimization.
1598 (message_enable_multibyte, free_misc): Remove.
1599 (catchlist, handlerlist, mark_backtrace):
1600 Declare only if BYTE_MARK_STACK.
1601 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1602 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1603 (message_enable_multibyte): Remove decl.
1604 (free_misc, interval_free_list, float_block, float_block_index):
1605 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1606 (cons_free_list, last_marked_index):
1607 Now static.
1608 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1609 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1610 (mark_backtrace): Define only if BYTE_MARK_STACK.
1611 * xdisp.c (message_enable_multibyte): Now static.
1612
61c2b50e 1613 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1614 This makes it easier for human readers (and static analyzers)
1615 to see whether these variables are used from other modules.
1616 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1617 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1618 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1619 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1620 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1621 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1622 * xmenu.c, xselect.c:
1623 Declare Q* vars static if they are not used in other modules.
1624 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1625 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1626 Remove decls of unexported vars.
1627 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1628
95c82688
PE
1629 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1630
16a97296
PE
1631 Make Emacs functions such as Fatom 'static' by default.
1632 This makes it easier for human readers (and static analyzers)
1633 to see whether these functions can be called from other modules.
1634 DEFUN now defines a static function. To make the function external
1635 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1636 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1637 (Finit_image_library):
16a97296
PE
1638 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1639 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1640 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1641 Remove decls, since these functions are now static.
1642 (Funintern, Fget_internal_run_time): New decls, since these functions
1643 were already external.
95c82688 1644
16a97296
PE
1645 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1646 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1647 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1648 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1649 * keyboard.c, keymap.c, lread.c:
1650 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1651 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1652 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1653 Mark functions with DEFUE instead of DEFUN,
1654 if they are used in other modules.
1655 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1656 decls for now-static functions.
1657 * buffer.h (Fdelete_overlay): Remove decl.
1658 * callproc.c (Fgetenv_internal): Mark as internal.
1659 * composite.c (Fremove_list_of_text_properties): Remove decl.
1660 (Fcomposition_get_gstring): New forward static decl.
1661 * composite.h (Fcomposite_get_gstring): Remove decl.
1662 * dired.c (Ffile_attributes): New forward static decl.
1663 * doc.c (Fdocumntation_property): New forward static decl.
1664 * eval.c (Ffetch_bytecode): New forward static decl.
1665 (Funintern): Remove extern decl; now in .h file where it belongs.
1666 * fileio.c (Fmake_symbolic_link): New forward static decl.
1667 * image.c (Finit_image_library): New forward static decl.
1668 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1669 * intervals.h (Fprevious_property_change):
1670 (Fremove_list_of_text_properties): Remove decls.
1671 * keyboard.c (Fthis_command_keys): Remove decl.
1672 (Fcommand_execute): New forward static decl.
1673 * keymap.c (Flookup_key): New forward static decl.
1674 (Fcopy_keymap): Now static.
1675 * keymap.h (Flookup_key): Remove decl.
1676 * process.c (Fget_process): New forward static decl.
1677 (Fprocess_datagram_address): Mark as internal.
1678 * syntax.c (Fsyntax_table_p): New forward static decl.
1679 (skip_chars): Remove duplicate decl.
1680 * textprop.c (Fprevious_property_change): New forward static decl.
1681 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1682 Now internal.
1683 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1684 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1685
785bbd42
PE
1686 * editfns.c (Fformat): Remove unreachable code.
1687
8b913b57
AS
16882011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1689
1690 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1691 change. (Bug#8496)
1692
a6744a35
EZ
16932011-04-13 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1696 when at ZV. (Bug#8487)
1697
e7974947
AS
16982011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1699
baad03f0
AS
1700 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1701 (Bug#8437)
1702 * keyboard.c (parse_tool_bar_item): Likewise.
1703 * sound.c (sound_cleanup, alsa_close): Likewise.
1704 * termcap.c (tgetent): Likewise.
1705 * xfns.c (x_default_font_parameter): Likewise.
1706 * xsettings.c (read_and_apply_settings): Likewise.
1707
e7974947
AS
1708 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1709 (overrun_check_free): Protoize.
1710
28272684
PE
17112011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1714 since callers should never pass a negative size.
1715 Change the signature to match that of plain 'read' and 'write'; see
1716 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1717 * lisp.h: Update prototypes of emacs_write and emacs_read.
1718
11997c76
EZ
17192011-04-11 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (redisplay_window): Don't try to determine the character
1722 position of the scroll margin if the window start point w->startp
e896f03c 1723 is outside the buffer's accessible region. (Bug#8468)
11997c76 1724
8a2cbd72
EZ
17252011-04-10 Eli Zaretskii <eliz@gnu.org>
1726
1727 Fix write-region and its subroutines for buffers > 2GB.
1728 * fileio.c (a_write, e_write): Modify declaration of arguments and
1729 local variables to support buffers larger than 2GB.
1730 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1731
1732 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1733 argument, local variables, and return value.
1734
1735 * lisp.h: Update prototypes of emacs_write and emacs_read.
1736
1737 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1738
4073e537 17392011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1740
1ebfdcb6
PE
1741 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1742
b2ded58d
PE
1743 Fix more problems found by GCC 4.6.0's static checks.
1744
7d66342c
PE
1745 * xdisp.c (vmessage): Use a better test for character truncation.
1746
bbf47d44
PE
1747 * charset.c (load_charset_map): <, not <=, for optimization,
1748 and to avoid potential problems with integer overflow.
9248994d 1749 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1750 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1751 * editfns.c (Fformat): Likewise.
1e69125e 1752 * syntax.c (skip_chars): Likewise.
3befa583 1753
e3019616
PE
1754 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1755 This also lets GCC 4.6.0 generate slightly better loop code.
1756
becfa255
PE
1757 * callint.c (Fcall_interactively): <, not <=, for optimization.
1758 (Fcall_interactively): Count the number of arguments produced,
1759 not the number of arguments given. This is simpler and lets GCC
1760 4.6.0 generate slightly better code.
1761
dae0cd48
PE
1762 * ftfont.c: Distingish more carefully between FcChar8 and char.
1763 The previous code passed unsigned char * to a functions like
1764 strlen and xstrcasecmp that expect char *, which does not
1765 conform to the C standard.
1766 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1767 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1768 char * when the C standard requires it.
1769
76032d70
PE
1770 * keyboard.c (read_char): Remove unused var.
1771
eb3f1cc8
PE
1772 * eval.c: Port to Windows vsnprintf (Bug#8435).
1773 Include <limits.h>.
1774 (SIZE_MAX): Define if the headers do not.
1775 (verror): Do not give up if vsnprintf returns a negative count.
1776 Instead, grow the buffer. This ports to Windows vsnprintf, which
1777 does not conform to C99. Problem reported by Eli Zaretskii.
1778 Also, simplify the allocation scheme, by avoiding the need for
1779 calling realloc, and removing the ALLOCATED variable.
1780
70476b54
PE
1781 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1782
12020a9e
PE
1783 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1784 But keep the doprint source code for now, as we might revamp it
1785 and use it again (Bug#8435).
ea6c7ae6
PE
1786 * lisp.h (doprnt): Remove.
1787 * Makefile.in (base_obj): Remove doprnt.o.
1788 * deps.mk (doprnt.o): Remove.
1789
5fdb398c
PE
1790 error: Print 32- and 64-bit integers portably (Bug#8435).
1791 Without this change, on typical 64-bit hosts error ("...%d...", N)
1792 was used to print both 32- and 64-bit integers N, which relied on
1793 undefined behavior.
1794 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1795 New macro.
1796 * lisp.h (error, verror): Mark as printf-like functions.
1797 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1798 Report overflow in size calculations when allocating printf buffer.
1799 Do not truncate output string at its first null byte.
1800 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1801 Truncate the output at a character boundary, since vsnprintf does not
1802 do that.
1803 * charset.c (check_iso_charset_parameter): Convert internal
1804 character to string before calling 'error', since %c now has the
1805 printf meaning.
1806 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1807 overflow when computing char to be passed to 'error'. Do not
1808 pass Lisp_Object to 'error'; pass the integer instead.
1809 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1810 formatted with plain %d.
1811
b189fa66
PE
1812 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1813
bff87ef0
PE
1814 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1815
7e2cac20
PE
1816 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1817
ce4d90b5
PE
1818 * xterm.c (x_catch_errors): Remove duplicate declaration.
1819
266c9547
PE
1820 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1821
79c49ad2
PE
1822 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1823
368f4090
JM
18242011-04-10 Jim Meyering <meyering@redhat.com>
1825
1826 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1827 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1828 return ssize_t not "int", and use size_t as the buffer length.
1829 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1830 * gnutls.h: Update declarations.
1831 * process.c (read_process_output): Use ssize_t, to match.
1832 (send_process): Likewise.
1833
a32d4040
CY
18342011-04-09 Chong Yidong <cyd@stupidchicken.com>
1835
1836 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1837
8546720e 18382011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1839
04f2d78b
CB
1840 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1841 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1842
8546720e
GM
1843 * xterm.c (handle_one_xevent):
1844 * xmenu.c (create_and_show_popup_menu):
1845 * xselect.c (x_decline_selection_request)
1846 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1847
0a2f5c1a 18482011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1849
1850 Fix some uses of `int' instead of EMACS_INT.
1851 * search.c (string_match_1, fast_string_match)
1852 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1853 (scan_buffer, find_next_newline_no_quit)
1854 (find_before_next_newline, search_command, Freplace_match)
1855 (Fmatch_data): Make some `int' variables be EMACS_INT.
1856
1857 * xdisp.c (display_count_lines): 3rd argument and return value now
1858 EMACS_INT. All callers changed.
1859 (pint2hrstr): Last argument is now EMACS_INT.
1860
1861 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1862 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1863 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1864 (decode_coding_utf_16, decode_coding_emacs_mule)
1865 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1866 (decode_coding_ccl, decode_coding_charset)
1867 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1868 (decode_coding_iso_2022, decode_coding_emacs_mule)
1869 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1870 <char_offset, last_offset>: Declare EMACS_INT.
1871 (encode_coding_utf_8, encode_coding_utf_16)
1872 (encode_coding_emacs_mule, encode_invocation_designation)
1873 (encode_designation_at_bol, encode_coding_iso_2022)
1874 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1875 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1876 Declare EMACS_INT.
1877 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1878 (encode_invocation_designation): Last argument P_NCHARS is now
1879 EMACS_INT.
1880 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1881 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1882
1883 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1884 All users changed.
1885
1886 * ccl.c (Fccl_execute_on_string): Declare some variables
1887 EMACS_INT.
1888
8546720e 18892011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1890
1891 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1892
4e19a977
CS
18932011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1894
1895 * process.c (Fformat_network_address): Doc fix.
1896
87302331
R
18972011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1898
1899 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1900
cbb59342
CY
19012011-04-08 Chong Yidong <cyd@stupidchicken.com>
1902
1903 * keyboard.c (read_char): Call Lisp function help-form-show,
1904 instead of using internal_with_output_to_temp_buffer.
1905 (Qhelp_form_show): New var.
e0d38eeb 1906 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1907
1908 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1909
1910 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1911
e67a13ab
CY
19122011-04-06 Chong Yidong <cyd@stupidchicken.com>
1913
04f2d78b
CB
1914 * process.c (Flist_processes): Remove to Lisp.
1915 (list_processes_1): Delete.
e67a13ab 1916
973f782d
EZ
19172011-04-06 Eli Zaretskii <eliz@gnu.org>
1918
7c106b1e
EZ
1919 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1920
973f782d
EZ
1921 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1922
41cf7d1a 19232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1924
ca23cc88
PE
1925 Fix more problems found by GCC 4.6.0's static checks.
1926
f390e2d5
PE
1927 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1928
42eea0d0
PE
1929 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1930
b69769da 1931 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1932
f9541e84
PE
1933 * xdisp.c (vmessage): Mark as a printf-like function.
1934
13841b55
PE
1935 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1936
c136c10f
PE
1937 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1938
5e2d4a30
PE
1939 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1940 printf-like functions.
1941 (tiff_load): Add casts to remove these marks before passing them
1942 to system-supplied API.
1943
583f48b9
PE
1944 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1945
b25d760e
PE
1946 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1947 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1948 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1949 directly, rather than having caller test rule sign. This avoids
1950 some unnecessary tests.
1951 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1952 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1953 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1954
bc7b6697 1955 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1956 (xfont_open): Avoid unnecessary tests.
bc7b6697 1957
27ccc379
PE
1958 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1959
dcd5c89a
PE
1960 * composite.h, composite.c (composition_gstring_put_cache):
1961 Use EMACS_INT, not int, for length.
1962
b13a45c6
PE
1963 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1964 breaking out part of COMPOSITION_DECODE_RULE.
1965 (COMPOSITION_DECODE_RULE): Use it.
1966 * composite.c (get_composition_id): Remove unused local vars,
1967 by using the new macro.
1968
1e792e4d
PE
1969 * textprop.c (set_text_properties_1): Change while to do-while,
1970 since the condition is always true at first.
1971
dc6c6455 1972 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1973 (interval_deletion_adjustment): Return unsigned value.
1974 All uses changed.
dc6c6455 1975
aba7731a
PE
1976 * process.c (list_processes_1, create_pty, read_process_output):
1977 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1978 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1979 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1980 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1981 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1982
fdfc4bf3
PE
1983 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1984
fca8fe46 1985 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1986 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1987
06a0259a 1988 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1989 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1990 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1991
e7b9e80f
PE
1992 * print.c (print_error_message): Avoid int overflow.
1993
56201685
PE
1994 * font.c (font_list_entities): Redo for clarity,
1995 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1996
78834453 1997 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1998 (font_score): Avoid potential overflow in diff calculation.
78834453 1999
0bc0b309 2000 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2001 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2002
e610eaca
PE
2003 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2004
b895abce
PE
2005 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2006 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2007 can always succeed if overflow has undefined behavior.
2008
1f1d9321 2009 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2010 (wordify): Omit three unnecessary tests.
1f1d9321 2011
c59478bc
PE
2012 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2013 All callers changed. This avoids the need for an unused var.
2014
79b73827
PE
2015 * casefiddle.c (casify_region): Remove var that is set but not used.
2016
a4db5dfe
PE
2017 * dired.c (file_name_completion): Remove var that is set but not used.
2018
43aae36e
PE
2019 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2020
2a47c44d 2021 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2022 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2023
a37c69bf
PE
2024 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2025 Check for integer overflow on size calculations.
2026
328ab8e7
PE
2027 * buffer.c (Fprevious_overlay_change): Remove var that is set
2028 but not used.
2029
e5a2a5cb
PE
2030 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2031 Remove vars that are set but not used.
8d84a6eb 2032 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2033 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2034
a60e5f68
PE
2035 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2036
f661cb61 2037 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2038 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2039
f0397f5a
PE
2040 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2041 that are set but not used.
2042
8664db06 2043 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2044 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2045
6abdaa4a
PE
2046 * xselect.c (x_get_local_selection, x_handle_property_notify):
2047 Remove vars that are set but not used.
2048
0ce7538d 2049 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2050 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2051
9ae848fc
PE
2052 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2053 Remove var that is set but not used.
0b918413
PE
2054 (scroll_bar_windows_size): Now size_t, not int.
2055 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2056 Check for overflow.
9ae848fc 2057
a5a62657
PE
2058 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2059 (map_tty_color) [!defined MSDOS]: Likewise.
2060
5c5cdd39
PE
2061 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2062
66ebf983
PE
2063 * coding.c: Remove vars that are set but not used.
2064 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2065 All callers changed.
2066 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2067 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2068 (decode_coding_charset): Remove vars that are set but not used.
2069
1be4d761
PE
2070 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2071 that is set but not used.
2072
47553fa8
PE
2073 * print.c (print_object): Remove var that is set but not used.
2074
1f7196bf 2075 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2076 The gnulib version avoids calling malloc in the usual case,
2077 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2078 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2079 * filelock.c (current_lock_owner): Likewise.
2080 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2081 * sysdep.c: Include allocator.h, careadlinkat.h.
2082 (emacs_no_realloc_allocator): New static constant.
2083 (emacs_readlink): New function.
fdb61804
PE
2084 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2085 ../lib/careadlinkat.h.
d1fdcab7 2086
f84c17c7
SM
20872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2090 first non-nil return value).
2091
ef3862ad
JD
20922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2093
2094 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2095 if not defined (Bug#8403).
2096
376a7006
JB
20972011-04-02 Juanma Barranquero <lekktu@gmail.com>
2098
2099 * xdisp.c (display_count_lines): Remove parameter `start',
2100 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2101 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2102 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2103 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2104 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2105 and thereabouts. All callers changed.
2106 (get_per_char_metric): Remove parameter `f', unused since
2107 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2108
6ca3801d
JM
21092011-04-02 Jim Meyering <meyering@redhat.com>
2110
2111 do not dereference NULL upon failed strdup
2112 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2113 (ns_get_family): Likewise.
2114
d8e2b5ba
JB
21152011-04-02 Juanma Barranquero <lekktu@gmail.com>
2116
2117 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2118
8c74fcbd
JD
21192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2120
2121 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2122 later (Bug#8403).
2123
7200d79c
SM
21242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2125
03408648 2126 Add lexical binding.
7200d79c 2127
03408648
SM
2128 * window.c (Ftemp_output_buffer_show): New fun.
2129 (Fsave_window_excursion):
2130 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2131
2132 * lread.c (lisp_file_lexically_bound_p): New function.
2133 (Fload): Bind Qlexical_binding.
2134 (readevalloop): Remove `evalfun' arg.
2135 Bind Qinternal_interpreter_environment.
2136 (Feval_buffer): Bind Qlexical_binding.
2137 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2138 Mark as dynamic.
2139 (syms_of_lread): Declare `lexical-binding'.
2140
2141 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2142
2143 * keyboard.c (eval_dyn): New fun.
2144 (menu_item_eval_property): Use it.
ca105506
SM
2145
2146 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2147
03408648
SM
2148 * fns.c (concat, mapcar1): Accept byte-code-functions.
2149
2150 * eval.c (Fsetq): Handle lexical vars.
2151 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2152 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2153 (FletX, Flet): Obey lexical binding.
2154 (Fcommandp): Handle closures.
2155 (Feval): New `lexical' arg.
2156 (eval_sub): New function extracted from Feval. Use it almost
2157 everywhere where Feval was used. Look up vars in lexical env.
2158 Handle closures.
2159 (Ffunctionp): Move from subr.el.
2160 (Ffuncall): Handle closures.
2161 (apply_lambda): Remove `eval_flags'.
2162 (funcall_lambda): Handle closures and new byte-code-functions.
2163 (Fspecial_variable_p): New function.
2164 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2165 but without exporting it to Lisp.
23aba0ea 2166
23aba0ea 2167 * doc.c (Fdocumentation, store_function_docstring):
03408648 2168 * data.c (Finteractive_form): Handle closures.
23aba0ea 2169
03408648
SM
2170 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2171 interactive spec.
ba83908c 2172
04f2d78b
CB
2173 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2174 New byte-codes.
03408648
SM
2175 (exec_byte_code): New function extracted from Fbyte_code to handle new
2176 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2177
03408648 2178 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2179
03408648 2180 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2181
e2abce01
JB
21822011-03-31 Juanma Barranquero <lekktu@gmail.com>
2183
2184 * xdisp.c (redisplay_internal): Fix prototype.
2185
63696a73 21862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2187
63696a73 2188 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2189 (try_scrolling): Use it when setting scroll_limit.
2190 Limit scrolling to 100 screen lines.
63696a73
EZ
2191 (redisplay_window): Even when falling back on "recentering",
2192 position point in the window according to scroll-conservatively,
2193 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2194
2195 (try_scrolling): When point is above the window, allow searching
2196 as far as scroll_max, or one screenful, to compute vertical
2197 distance from PT to the scroll margin position. This prevents
2198 try_scrolling from unnecessarily failing when
2199 scroll-conservatively is set to a value slightly larger than the
2200 window height. Clean up the case of PT below the margin at bottom
2201 of window: scroll_max can no longer be INT_MAX. When aggressive
2202 scrolling is in use, don't let point enter the opposite scroll
2203 margin as result of the scroll.
2204 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2205 threshold of 100 lines for never-recentering scrolling.
2206
e4cc2dfc
JB
22072011-03-31 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * dispextern.h (move_it_by_lines):
2210 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2211 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2212 (message_log_check_duplicate): Remove parameters `prev_bol' and
2213 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2214 (redisplay_internal): Remove parameter `preserve_echo_area',
2215 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2216
2217 * indent.c (Fvertical_motion):
2218 * window.c (window_scroll_pixel_based, Frecenter):
2219 Don't pass `need_y_p' to `move_it_by_lines'.
2220
1c470562
SM
22212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2222
44f230aa
SM
2223 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2224 steal a few bits to be more compact.
2225 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2226 Remove unneeded casts.
2227
1c470562
SM
2228 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2229
888adce9
ZK
22302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2231
2232 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2233 binding" message (bug#7967).
2234
f838ed7b
PE
22352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2236
77861b95
PE
2237 Fix more problems found by GCC 4.6.0's static checks.
2238
de6dbc14
PE
2239 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2240 Remove unused local var.
2241
f838ed7b
PE
2242 * editfns.c (Fmessage_box): Remove unused local var.
2243
792c7b2b
PE
2244 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2245 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2246 Omit unused local vars.
c499e557 2247 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2248 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2249 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2250 Omit unused local var.
2251
ba0165e1
PE
2252 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2253 Don't assume string length fits in int.
32ad8845 2254 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2255 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2256
3c59b4c9
PE
2257 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2258 instead of alloca (Bug#8344).
2259
a3eed478 2260 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2261 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2262
eb4d412d
PE
2263 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2264
1658b401
PE
2265 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2266 concerns.
2267
2268 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2269
2270 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2271
9a2c6e05
PE
2272 * keyboard.c (syms_of_keyboard): Use the same style as later
2273 in this function when indexing through an array. This also
2274 works around GCC bug 48267.
2275
03d0a109
PE
2276 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2277
44f730c8
PE
2278 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2279
fe75f926
PE
2280 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2281 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2282
ffa8c828
PE
2283 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2284 This avoids undefined behavior on integer overflow, and is a bit
2285 more convenient anyway since it is compared to a size_t variable.
2286
c5101a77
PE
2287 Variadic C functions now count arguments with size_t, not int.
2288 This avoids an unnecessary limitation on 64-bit machines, which
2289 caused (substring ...) to crash on large vectors (Bug#8344).
2290 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2291 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2292 All variadic functions and their callers changed accordingly.
c5101a77
PE
2293 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2294 * data.c (arith_driver, float_arith_driver): Likewise.
2295 * editfns.c (general_insert_function): Likewise.
2296 * eval.c (struct backtrace.nargs, interactive_p)
2297 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2298 (funcall_lambda, mark_backtrace): Likewise.
2299 * fns.c (concat): Likewise.
2300 * frame.c (x_set_frame_parameters): Likewise.
2301 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2302 0 if not found, not -1. All callers changed.
2303
dd3f25f7
PE
2304 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2305 (stack_copy_size): Now size_t, not int.
2306 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2307
461c2ab9
JB
23082011-03-28 Juanma Barranquero <lekktu@gmail.com>
2309
2310 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2311 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2312 All callers changed.
2313
2314 * lisp.h (multibyte_char_to_unibyte):
2315 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2316 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2317 * character.h (CHAR_TO_BYTE8):
2318 * cmds.c (internal_self_insert):
2319 * editfns.c (general_insert_function):
2320 * keymap.c (push_key_description):
2321 * search.c (Freplace_match):
2322 * xdisp.c (message_dolog, set_message_1): All callers changed.
2323
f6d62986
SM
23242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2325
2326 * keyboard.c (safe_run_hook_funcall): New function.
2327 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2328 don't set the hook to nil, but remove the offending function instead.
2329 (Qcommand_hook_internal): Remove, unused.
2330 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2331 Vcommand_hook_internal.
2332
2333 * eval.c (enum run_hooks_condition): Remove.
2334 (funcall_nil, funcall_not): New functions.
2335 (run_hook_with_args): Call each function through a `funcall' argument.
2336 Remove `cond' argument, now redundant.
2337 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2338 (Frun_hook_with_args_until_failure): Adjust accordingly.
2339 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2340
1db5b1ad
JB
23412011-03-28 Juanma Barranquero <lekktu@gmail.com>
2342
2343 * dispextern.h (string_buffer_position): Remove declaration.
2344
2345 * print.c (strout): Remove parameter `multibyte', unused since
2346 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2347
2348 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2349 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2350 All callers changed.
2351
2352 * w32.c (_wsa_errlist): Use braces for struct initializers.
2353
2354 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2355 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2356 All callers changed.
2357 (string_buffer_position): Likewise. Also, make static (it's never
2358 used outside xdisp.c).
2359 (cursor_row_p): Remove parameter `w', unused since
2360 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2361 (decode_mode_spec): Remove parameter `precision', introduced during
2362 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2363 All callers changed.
2364
5ffb62aa
JD
23652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2366
2367 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2368
461c2ab9 23692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2370
2371 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2372 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2373 (ns_update_auto_hide_menu_bar): New functions.
2374 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2375 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2376 ns_constrain_all_frames.
2377 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2378 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2379
5c380ffb
JD
23802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2381
2382 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2383
9af30bdf
GM
23842011-03-27 Glenn Morris <rgm@gnu.org>
2385
2386 * syssignal.h: Replace RETSIGTYPE with void.
2387 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2388 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2389 Replace SIGTYPE with void everywhere.
2390 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2391 * s/template.h (SIGTYPE): Remove commented out definition.
2392
e2abce01
JB
23932011-03-26 Eli Zaretskii <eliz@gnu.org>
2394
2395 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2396 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2397
f868cd8a
JB
23982011-03-26 Juanma Barranquero <lekktu@gmail.com>
2399
59eb0929
JB
2400 * w32.c (read_unc_volume): Use parameter `henum', instead of
2401 global variable `wget_enum_handle'.
2402
2403 * keymap.c (describe_vector): Remove parameters `indices' and
2404 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2405 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2406
f868cd8a
JB
2407 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2408
2409 * keyboard.c (timer_check): Remove parameter `do_it_now',
2410 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2411 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2412 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2413
2414 * keyboard.c (read_char):
2415 * w32menu.c (w32_menu_display_help):
2416 * xmenu.c (show_help_event, menu_help_callback):
2417 Adjust calls to `show_help_echo'.
2418
2419 * gtkutil.c (xg_maybe_add_timer):
2420 * keyboard.c (readable_events):
2421 * process.c (wait_reading_process_output):
2422 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2423
2424 * insdel.c (adjust_markers_gap_motion):
2425 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2426 (gap_left, gap_right): Don't call it.
2427
2ecf6fdb
CY
24282011-03-25 Chong Yidong <cyd@stupidchicken.com>
2429
2430 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2431 incurred during fontification.
2432
6b1f9ba4
JB
24332011-03-25 Juanma Barranquero <lekktu@gmail.com>
2434
2435 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2436 (DEFVAR_PER_BUFFER): Don't pass it.
2437
2438 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2439 (scrolling_window): Don't pass it.
2440
0f4a96b5
JB
24412011-03-25 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2444
2445 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2446 and `suffix'.
2447 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2448 of variables specific to SELinux and computation of `encoded_absname'.
2449
2450 * image.c (XPutPixel): Remove unused variable `height'.
2451
2452 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2453
2454 * unexw32.c (get_section_info): Remove unused variable `section'.
2455
2456 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2457 (system_process_attributes): Remove unused variable `sess'.
2458 (sys_read): Remove unused variable `err'.
2459
2460 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2461 (w32_wnd_proc): Remove unused variable `isdead'.
2462 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2463 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2464 (x_create_tip_frame): Remove unused variable `tem'.
2465
2466 * w32inevt.c (w32_console_read_socket):
2467 Remove unused variable `no_events'.
2468
2469 * w32term.c (x_draw_composite_glyph_string_foreground):
2470 Remove unused variable `width'.
2471
1149507c
JB
24722011-03-24 Juanma Barranquero <lekktu@gmail.com>
2473
2474 * w32term.c (x_set_glyph_string_clipping):
2475 Don't pass uninitialized region to CombineRgn.
2476
9c88f339
JB
24772011-03-23 Juanma Barranquero <lekktu@gmail.com>
2478
2479 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2480 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2481 (Fx_close_connection): Remove unused variable `i'.
2482
2483 * w32font.c (w32font_draw): Return number of glyphs.
2484 (w32font_open_internal): Remove unused variable `i'.
2485 (w32font_driver): Add missing initializer.
2486
2487 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2488 (fill_in_menu): Remove unused variable `items_added'.
2489
2490 * w32term.c (last_mouse_press_frame): Remove static global variable.
2491 (w32_clip_to_row): Remove unused variable `f'.
2492 (x_delete_terminal): Remove unused variable `i'.
2493
2494 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2495 (NOTHING): Remove unused static global variable.
2496 (uniscribe_check_otf): Remove unused variable `table'.
2497 (uniscribe_font_driver): Add missing initializers.
2498
dee091a3
JD
24992011-03-23 Julien Danjou <julien@danjou.info>
2500
2501 * term.c (Fsuspend_tty, Fresume_tty):
2502 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2503 * window.c (temp_output_buffer_show):
2504 * insdel.c (signal_before_change):
2505 * frame.c (Fhandle_switch_frame):
2506 * fileio.c (Fdo_auto_save):
2507 * emacs.c (Fkill_emacs):
2508 * editfns.c (save_excursion_restore):
2509 * cmds.c (internal_self_insert):
2510 * callint.c (Fcall_interactively):
2511 * buffer.c (Fkill_all_local_variables):
2512 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2513 Use Frun_hooks.
0f4a96b5 2514 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2515 unconditionnaly since it does the check itself.
2516
2c520ab5 25172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2518
c9c49752
PE
2519 Fix more problems found by GCC 4.5.2's static checks.
2520
8abc3f12
PE
2521 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2522 the first time through the loop, since we know p0 < p1 then.
2523 This also avoids a gcc -Wstrict-overflow warning.
2524
a2d26660
PE
2525 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2526 leading to a memory leak, possible in functions like
2527 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2528 of objects (Bug#8318).
a2d26660 2529
916c72e9
PE
2530 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2531 that could (at least in theory) be that large.
2532
19ab8a18
PE
2533 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2534 This is less likely to overflow, and avoids undefined behavior if
2535 overflow does occur. All callers changed. Use strtoul to scan
2536 for the unsigned long integer.
b7cbbd6f
PE
2537 (pint2hrstr): Simplify and tune code slightly.
2538 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2539
f0641eff
PE
2540 * scroll.c (do_scrolling): Work around GCC bug 48228.
2541 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2542
7f650bb9
PE
2543 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2544 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2545 (validate_x_resource_name): Simplify count usage.
2546 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2547
37dd57d1
PE
2548 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2549 fail (Bug#8306).
81e56e61 2550
699979fc 2551 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2552
401bf9b4
PE
2553 * process.c (Fmake_network_process): Use socklen_t, not int,
2554 where POSIX says socklen_t is required in portable programs.
2555 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2556 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2557 (Fmake_network_process, server_accept_connection):
2558 (wait_reading_process_output, read_process_output):
2559 Likewise.
2560
b93aacde
PE
2561 * process.c: Rename or move locals to avoid shadowing.
2562 (list_processes_1, Fmake_network_process):
2563 (read_process_output_error_handler, exec_sentinel_error_handler):
2564 Rename or move locals.
4dc343ee 2565 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2566 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2567 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2568 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2569 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2570
af8a867c 2571 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2572 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2573 Include tparam.h instead, since it declares them.
af8a867c
PE
2574 * cm.h (PC): Remove extern decl; tparam.h now does this.
2575 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2576 * terminfo.c: Include tparam.h, to check interfaces.
2577 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2578 (tparam): Adjust signature to match interface in tparam.h;
2579 this removes some undefined behavior. Check that outstring and len
2580 are zero, which they always are with Emacs.
2581 * tparam.h (PC, BC, UP): New extern decls.
2582
0248044d 2583 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2584 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2585
8ff096c1 2586 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2587 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2588 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2589 (ftfont_list): Remove unused local.
49eaafba
PE
2590 (get_adstyle_property, ftfont_pattern_entity):
2591 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2592 Rename locals to avoid shadowing.
8ff096c1 2593
e2be39f6
PE
2594 * xfont.c (xfont_list_family): Mark var as initialized.
2595
c9735e30
PE
2596 * xml.c (make_dom): Now static.
2597
8f5201ae
PE
2598 * composite.c (composition_compute_stop_pos): Rename local to
2599 avoid shadowing.
b246f932
PE
2600 (composition_reseat_it): Remove unused locals.
2601 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2602 (composition_update_it): Mark var as initialized.
11b61122
PE
2603 (find_automatic_composition): Mark vars as initialized,
2604 with a FIXME (Bug#8290).
8f5201ae 2605
760fbc2c
PE
2606 character.h: Rename locals to avoid shadowing.
2607 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2608 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2609 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2610 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2611 to avoid shadowing.
2612
ff08eb85
PE
2613 * textprop.c (property_change_between_p): Remove; unused.
2614
fc7bf025
PE
2615 * intervals.c (interval_start_pos): Now static.
2616
235d7abc
PE
2617 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2618
44f230aa
SM
2619 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2620 Rename locals to avoid shadowing.
3e7d6594 2621
50060332
PE
2622 * sound.c (wav_play, au_play, Fplay_sound_internal):
2623 Fix pointer signedness.
d01f234b 2624 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2625 (wav_play): Initialize a variable to 0, to prevent undefined
2626 behavior (Bug#8278).
50060332 2627
c4fc4e30
PE
2628 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2629
918436ed
PE
2630 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2631
c939f91b
PE
2632 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2633 clobbering (Bug#8298).
b9c7f648
PE
2634 * sysdep.c (sys_subshell): Likewise.
2635 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2636
6bd8c144
PE
2637 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2638 This should get cleaned up, so that child_setup has the
2639 same signature on all platforms.
2640
7710357c 2641 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2642 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2643
c59da222
CY
26442011-03-22 Chong Yidong <cyd@stupidchicken.com>
2645
2646 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2647 not to be necessary, and produces flickering.
2648
66b87493
GM
26492011-03-20 Glenn Morris <rgm@gnu.org>
2650
2651 * config.in: Remove file.
2652
45b6f6d5
JB
26532011-03-20 Juanma Barranquero <lekktu@gmail.com>
2654
2655 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2656 are now in src/globals.h.
2657 (syms_of_minibuf): Remove spurious & from previous change.
2658
3ec03f7e
LL
26592011-03-20 Leo <sdl.web@gmail.com>
2660
2661 * minibuf.c (completing-read-function): New variable.
2662 (completing-read-default): Rename from completing-read.
2663 (completing-read): Call completing-read-function.
2664
b14e3e21
CY
26652011-03-19 Juanma Barranquero <lekktu@gmail.com>
2666
2667 * xfaces.c (Fx_load_color_file):
2668 Read color file from absolute filename (bug#8250).
2669
f2b726e6
JB
26702011-03-19 Juanma Barranquero <lekktu@gmail.com>
2671
2672 * makefile.w32-in: Update dependencies.
2673
09f6ff02
EZ
26742011-03-17 Eli Zaretskii <eliz@gnu.org>
2675
2676 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2677
29a6015a
PE
26782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2679
a3a6c54e
PE
2680 Fix more problems found by GCC 4.5.2's static checks.
2681
b766f867
PE
2682 * process.c (make_serial_process_unwind, send_process_trap):
2683 (sigchld_handler): Now static.
2684
be02381c
PE
2685 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2686 That way, the code declares only the vars that it needs.
2687 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2688 * s/cygwin.h (PTY_ITERATION): Likewise.
2689 * s/darwin.h (PTY_ITERATION): Likewise.
2690 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2691
57048744
PE
2692 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2693 * process.c (allocate_pty): Don't declare stb unless it's needed.
2694
7914961c 2695 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2696 (CONSTANTLIM): Remove; unused.
2697 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2698 Define only if needed.
7914961c 2699
b3967b18
PE
2700 * unexelf.c (unexec): Name an expression,
2701 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2702 Use a different way to cause a compilation error if anyone uses
2703 n rather than nn, a way that does not involve shadowing.
73366a00 2704 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2705
29a6015a
PE
2706 * deps.mk (unexalpha.o): Remove; unused.
2707
43cfc33e 2708 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2709 * unexec.h: New file.
ce701a33
PE
2710 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2711 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2712 Depend on unexec.h.
2713 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2714 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2715 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2716 Change as necessary to match prototype in unexec.h.
ce701a33 2717
01f44d5a
PE
2718 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2719 shadowing.
4f63c6bb 2720 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2721
a6670b0b
PE
2722 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2723 Rename locals to avoid shadowing.
2724
cef2010d 2725 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2726 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2727
d4d7173a
PE
2728 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2729
f08b802a
PE
2730 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2731 warning when compiling print.c.
2732
3ddb0639
PE
2733 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2734 instead of using an uninitialized var.
5ad03b97 2735 (font_sort_entities): Mark var as initialized.
3ddb0639 2736
170a2692
PE
2737 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2738
e663c700
PE
2739 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2740 pointers to constants.
89bc529a 2741 (font_parse_fcname): Remove unused vars.
7b81e2d0 2742 (font_delete_unmatched): Now static.
ea838e10 2743 (font_get_spec): Remove; unused.
13a547c6
PE
2744 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2745 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2746 Rename or move locals to avoid shadowing.
e663c700 2747
2a80c887 2748 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2749 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2750
1384fa33 2751 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2752 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2753
8b2c52e9
PE
2754 * alloc.c (mark_backtrace): Move decl from here ...
2755 * lisp.h: ... to here, so that it can be checked.
2756
475545b5 2757 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2758 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2759 (lisp_indirect_variable): Name an expression,
2760 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2761 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2762
b1349114 2763 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2764 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2765 Use const pointer when appropriate.
b1349114 2766
a2928364
PE
2767 * lisp.h (get_system_name, get_operating_system_release):
2768 Move decls here, to check interfaces.
2769 * process.c (get_operating_system_release): Move decl to lisp.h.
2770 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2771 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2772 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2773 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2774 (Fformat_time_string, Fencode_time, Finsert_char):
2775 (Ftranslate_region_internal, Fformat):
2776 Rename or remove local vars to avoid shadowing.
9710023e 2777 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2778
a415e694
PE
2779 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2780 avoid shadowing.
2781
8ef4622d
PE
2782 * lisp.h (eassert): Check that the argument compiles, even if
2783 ENABLE_CHECKING is not defined.
2784
946f9a5b
PE
2785 * data.c (Findirect_variable): Name an expression, to avoid
2786 gcc -Wbad-function-cast warning.
112396d6 2787 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2788 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2789 (Fmake_variable_buffer_local, Fmake_local_variable):
2790 Mark variables as initialized.
52746918 2791 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2792
e5aab7e7 2793 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2794 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2795 Rename locals to avoid shadowing.
dff45157
PE
2796 (mark_stack): Move local variables into the #ifdef region where
2797 they're used.
7bc26fdb
PE
2798 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2799 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2800 needed otherwise.
2801 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2802 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2803 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2804
e5aab7e7
PE
2805 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2806 avoids undefined behavior in theory.
2807
4da60324
PE
2808 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2809
88043301
PE
2810 Use functions, not macros, for up- and down-casing (Bug#8254).
2811 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2812 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2813 to use the following functions instead of these macros.
2814 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2815 EMACS_INT, since callers assume the returned value fits in int.
2816 (upcase1): Likewise, for UPCASE_TABLE.
2817 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2818 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2819 the race-condition problem in the old DOWNCASE.
88043301 2820
19ed5445
PE
2821 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2822 Rename locals to avoid shadowing.
2823 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2824 (regex_compile, re_search_2, re_match_2_internal):
2825 Remove unused local vars.
952db0d7
PE
2826 (FREE_VAR): Rewrite so as not to use empty "else",
2827 which gcc can warn about.
da053e48 2828 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2829 (RETALLOC_IF): Define only if needed.
2830 (WORDCHAR_P): Likewise. This one is never needed, but is used
2831 only in a comment talking about a compiler bug, so put inside
2832 the #if 0 of that comment.
2833 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2834 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2835 Remove; unused.
19ed5445 2836
1f3561e4 2837 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2838 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2839 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2840
ded6f8f7
PE
2841 * search.c (simple_search): Remove unused var.
2842
dbd37a95
PE
2843 * dired.c (compile_pattern): Move decl from here ...
2844 * lisp.h: ... to here, so that it can be checked.
2845 (struct re_registers): New forward decl.
2846
7e47afad
PE
2847 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2848
85f24f61
PE
2849 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2850 All uses changed.
2851 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2852 Rename locals to avoid shadowing.
5671df8f 2853 (Fvertical_motion): Mark locals as initialized.
85f24f61 2854
181aa2be 2855 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2856 (casify_region): Mark local as initialized.
181aa2be 2857
930d429c
PE
2858 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2859
7082eac6
PE
2860 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2861 New macros, so that the caller can use some names other than
2862 gcpro1, gcpro2, etc.
2863 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2864 of the new macros.
2865 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2866 argument, for consistency with GCPRO2_VAR, etc: it is now the
2867 prefix of the variable, not the variable itself. All uses
2868 changed.
38b2c076
PE
2869 * dired.c (directory_files_internal, file_name_completion):
2870 Rename locals to avoid shadowing.
2871
15206ed9
PE
2872 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2873 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2874 dired.c's scmp function, had undefined behavior.
2875 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2876 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2877 * buffer.h: ... to here, because these macros use current_buffer,
2878 and the new implementation with inline functions needs to have
2879 current_buffer in scope now, rather than later when the macros
2880 are used.
2881 (downcase, upcase1): New static inline functions.
2882 (DOWNCASE, UPCASE1): Reimplement using these functions.
2883 This avoids undefined behavior in expressions like
2884 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2885 from race conditions in accessing the global variables
2886 case_temp1 and case_temp2.
2887 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2888 * lisp.h (case_temp1, case_temp2): Remove their decls.
2889 * character.h (ASCII_CHAR_P): Move from here ...
2890 * lisp.h: ... to here, so that the inline functions mentioned
2891 above can use them.
2892
4a6bea26
PE
2893 * dired.c (directory_files_internal_unwind): Now static.
2894
f14b7e14
PE
2895 * fileio.c (file_name_as_directory, directory_file_name):
2896 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2897 Now static.
2893f146
PE
2898 (file_name_as_directory): Use const pointers when appropriate.
2899 (Fexpand_file_name): Likewise. In particular, newdir might
2900 point at constant storage, so make it a const pointer.
fd4ead52 2901 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2902 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2903 signedness issues.
f839df0c
PE
2904 (Fset_file_times, Finsert_file_contents, auto_save_error):
2905 Rename locals to avoid shadowing.
f14b7e14 2906
5716756e 2907 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2908 (Ftry_completion, Fall_completions): Rename or remove locals
2909 to avoid shadowing.
5716756e 2910
b4c3046a
PE
2911 * marker.c (bytepos_to_charpos): Remove; unused.
2912
b45db522
PE
2913 * lisp.h (verify_bytepos, count_markers): New decls,
2914 so that gcc does not warn that these functions aren't declared.
2915
85876d07
PE
2916 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2917 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2918 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2919 (copy_text): Remove unused local var.
85876d07 2920
03d78a21 2921 * filelock.c (within_one_second): Now static.
b3dd38ab 2922 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2923
5df8f01b
PE
2924 * buffer.c (fix_overlays_before): Mark locals as initialized.
2925 (fix_start_end_in_overlays): Likewise. This function should be
2926 simplified by using pointers-to-pointers, but that's a different
2927 matter.
b1d876f1 2928 (switch_to_buffer_1): Now static.
8f54f30a
PE
2929 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2930 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2931
a70072c9 2932 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2933 Fix pointer signedness issue.
edced198
PE
2934 (sys_subshell): Mark local as volatile if checking for lint,
2935 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2936 (MAXPATHLEN): Define only if needed.
a70072c9 2937
a0977c44
PE
2938 * process.c (serial_open, serial_configure): Move decls from here ...
2939 * systty.h: ... to here, so that they can be checked.
2940
a884fdcc
PE
2941 * fns.c (get_random, seed_random): Move extern decls from here ...
2942 * lisp.h: ... to here, so that they can be checked.
2943
604efe86 2944 * sysdep.c (reset_io): Now static.
b8950c94 2945 (wait_for_termination_signal): Remove; unused.
604efe86 2946
38fc62d9
PE
2947 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2948 (copy_keymap_item, append_key, push_text_char_description):
2949 Now static.
1004a21a 2950 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2951 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2952 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2953 (describe_map_tree):
2954 Rename locals to avoid shadowing.
38fc62d9 2955
2f2650da
PE
2956 * keyboard.c: Declare functions static if they are not used elsewhere.
2957 (echo_char, echo_dash, cmd_error, top_level_2):
2958 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2959 (read_char, kbd_buffer_get_event, make_lispy_position):
2960 (make_lispy_event, make_lispy_movement, apply_modifiers):
2961 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2962 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2963 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2964 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2965 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2966
a053e86c 2967 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2968 (mark_kboards): Move decl here ...
2969 * alloc.c (mark_kboards): ... from here.
a053e86c 2970
4752793e
PE
2971 * lisp.h (force_auto_save_soon): New decl.
2972
74f10ca7 2973 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2974 (DEFINE_DUMMY_FUNCTION): New macro.
2975 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2976 Use it.
c03cd23f
PE
2977 (main): Add casts to avoid warnings
2978 if GCC considers string literals to be constants.
74f10ca7 2979
022e70d4
PE
2980 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2981
59d6fe83
PE
2982 * dbusbind.c: Pointer signedness fixes.
2983 (xd_signature, xd_append_arg, xd_initialize):
2984 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2985 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2986 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2987 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2988
78320123
PE
2989 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2990 if GCC considers string literals to be constants.
49cebcca 2991 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2992
35ac2a97
SM
29932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2994
fb103ca9
SM
2995 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2996 (print_preprocess, print_object): New macro to fix last change.
2997
35ac2a97
SM
2998 * print.c (print_preprocess): Don't forget font objects.
2999
62973b41
JB
30002011-03-16 Juanma Barranquero <lekktu@gmail.com>
3001
3002 * emacs.c (USAGE3): Doc fixes.
3003
0e48bb22
AS
30042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3005
3006 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3007 structure.
3008
7684e57b
JB
30092011-03-14 Juanma Barranquero <lekktu@gmail.com>
3010
3011 * lisp.h (VWindow_system, Qfile_name_history):
3012 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3013 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3014 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3015
3016 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3017 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3018
3019 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3020 * w32console.c (detect_input_pending, read_input_pending)
3021 (encode_terminal_code):
3022 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3023 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3024 (w32_system_caret_y, Qfile_name_history):
3025 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3026 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3027 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3028 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3029 * w32proc.c (Qlocal, report_file_error):
3030 * w32term.c (Vwindow_system, updating_frame):
3031 * w32uniscribe.c (initialized, uniscribe_font_driver):
3032 Remove unneeded extern declarations.
3033
2aa46d6c
CY
30342011-03-14 Chong Yidong <cyd@stupidchicken.com>
3035
c96bbc66 3036 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3037
cffc6f3b
CY
30382011-03-13 Chong Yidong <cyd@stupidchicken.com>
3039
3040 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3041 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3042 These macros can no longer be used for assignment.
3043
44f230aa
SM
3044 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3045 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3046 (record_buffer_markers, fetch_buffer_markers): New functions for
3047 recording and fetching special buffer markers.
3048 (set_buffer_internal_1, set_buffer_temp): Use them.
3049
3050 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3051
3052 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3053
3054 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3055 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3056
3057 * xdisp.c (hscroll_window_tree):
3058 (reconsider_clip_changes): Use PT instead of BUF_PT.
3059
d251f04b
EZ
30602011-03-13 Eli Zaretskii <eliz@gnu.org>
3061
3062 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3063 $(EMACS_ROOT)/lib/intprops.h.
3064
f0c77cd1
PE
30652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3066
3eca4629
PE
3067 Fix more problems found by GCC 4.5.2's static checks.
3068
7c86ee98
PE
3069 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3070 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3071 (xg_free_frame_widgets): Make it clear that a local variable is
3072 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3073 (gdk_window_get_screen): Make it clear that this macro is needed
3074 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3075 (int_gtk_range_get_value): New function, which avoids a diagnostic
3076 from gcc -Wbad-function-cast.
3077 (xg_set_toolkit_scroll_bar_thumb): Use it.
3078 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3079 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3080 (get_utf8_string, xg_get_file_with_chooser):
3081 Rename locals to avoid shadowing.
3082 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3083
41729b81
PE
3084 * xgselect.c (xg_select): Remove unused var.
3085
f0c77cd1
PE
3086 * image.c (four_corners_best): Mark locals as initialized.
3087 (gif_load): Initialize transparent_p to zero (Bug#8238).
3088 Mark another local as initialized.
ec6cf4c6 3089 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3090
ce0ad53d 3091 * image.c (clear_image_cache): Now static.
d5d5a617 3092 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3093 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3094 (x_edge_detection): Remove unnecessary cast that
3095 gcc -Wbad-function-cast diagnoses.
2037898d 3096 (gif_load): Fix pointer signedness.
6ae141d6
PE
3097 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3098 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3099
33383987 31002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3101
d32df629
PE
3102 Improve quality of tests for time stamp overflow.
3103 For example, without this patch (encode-time 0 0 0 1 1
3104 1152921504606846976) returns the obviously-bogus value (-948597
3105 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3106 reports time overflow. See
3107 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3108 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3109 * editfns.c: Include limits.h and intprops.h.
3110 (TIME_T_MIN, TIME_T_MAX): New macros.
3111 (time_overflow): Move earlier, to before first use.
3112 (hi_time, lo_time): New functions, for an accurate test for
3113 out-of-range times.
3114 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3115 (Fget_internal_run_time): Don't assume time_t fits in int.
3116 (make_time): Use list2 instead of Fcons twice.
3117 (Fdecode_time): More accurate test for out-of-range times.
3118 (check_tm_member): New function.
3119 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3120 (lisp_time_argument): Don't rely on undefined left-shift and
3121 right-shift behavior when checking for time stamp overflow.
8be6f318 3122
fe31d94c
PE
3123 * editfns.c (time_overflow): New function, refactoring common code.
3124 (Fformat_time_string, Fdecode_time, Fencode_time):
3125 (Fcurrent_time_string): Use it.
3126
8be6f318
PE
3127 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3128 * dired.c (make_time): Move to ...
3129 * editfns.c (make_time): ... here.
3130 * systime.h: Note the move.
3131
09d9db2c 31322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3133
126bc0dc
YM
3134 * fringe.c (update_window_fringes): Remove unused variables.
3135
c47cbdfd
YM
3136 * unexmacosx.c (copy_data_segment): Also copy __got section.
3137 (Bug#8223)
3138
7ac80be9
EZ
31392011-03-12 Eli Zaretskii <eliz@gnu.org>
3140
c96bbc66 3141 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3142 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3143 Constify `char *' arguments and their references according to
3144 prototypes in tparam.h.
3145
ecb0f94d 3146 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3147
7ac80be9
EZ
3148 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3149 Adapt all references accordingly.
3150
3151 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3152
ef1fd07e
TT
31532011-03-11 Tom Tromey <tromey@redhat.com>
3154
3155 * buffer.c (syms_of_buffer): Remove obsolete comment.
3156
7ef4b50c
EZ
31572011-03-11 Eli Zaretskii <eliz@gnu.org>
3158
3159 * termhooks.h (encode_terminal_code): Declare prototype.
3160
3161 * msdos.c (encode_terminal_code): Don't declare prototype.
3162
3163 * term.c (encode_terminal_code): Now external again, used by
3164 w32console.c and msdos.c.
3165
44f230aa
SM
3166 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3167 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3168
4b1ec863 31692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3170
1714f52b 3171 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3172
4b1ec863
PE
3173 * fringe.c (update_window_fringes): Mark locals as initialized
3174 (Bug#8227).
3175 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3176
524c7aa6
PE
3177 * alloc.c (mark_fringe_data): Move decl from here ...
3178 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3179 to check its interface.
3180 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3181
a5c0af81 3182 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3183 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3184 (fontset_font): Mark local as initialized.
a9a06e0b 3185 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3186
b4716021
PE
3187 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3188
811e9bac 3189 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3190 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3191 (x_own_selection, Fx_disown_selection_internal): Rename locals
3192 to avoid shadowing.
3193 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3194
7e3ab302
PE
3195 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3196 so that the caller can use some name other than gcpro1.
3197 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3198 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3199 (Fx_backspace_delete_keys_p):
3200 Use them to avoid shadowing, and rename vars to avoid shadowing.
3201 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3202 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3203 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3204 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3205 Remove unused locals.
7e3ab302
PE
3206 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3207 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3208 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3209 macros.
f78faa98 3210
e2b13473
PE
3211 * xterm.h (x_mouse_leave): New decl.
3212
77f23912
PE
3213 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3214 Remove unused functions.
cdf4ba58
PE
3215 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3216 (x_calc_absolute_position): Now static.
7411c686 3217 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3218 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3219 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3220 unless they are used.
38d0b34a
PE
3221 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3222 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3223 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3224 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3225 (x_error_catcher, x_connection_closed, x_error_handler):
3226 (x_error_quitter, xembed_send_message, x_iconify_frame):
3227 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3228 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3229 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3230
44f230aa
SM
3231 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3232 Rename or move locals to avoid shadowing.
6b463e58 3233 (tty_defined_color, merge_face_heights): Now static.
5967d051 3234 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3235 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3236 does not deduce is never used uninitialized.
73719eba
PE
3237 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3238 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3239
426994c3 3240 * terminal.c (store_terminal_param): Now static.
5489860b 3241
032f1620 3242 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3243 (set_frame_menubar): Remove unused local.
d4323972 3244 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3245 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3246 since they might point to immutable storage.
281585b0
PE
3247 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3248 since it's unused otherwise.
032f1620 3249
367c19e5 3250 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3251 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3252 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3253 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3254 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3255 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3256 does not deduce are never used uninitialized.
70739cbe 3257
07b48fa9
PE
3258 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3259
8868a238 3260 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3261 * window.c (window_loop, size_window):
3262 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3263
7e5cf297 3264 * window.c (display_buffer): Now static.
d6550a9f
PE
3265 (size_window): Mark variables that gcc -Wuninitialized
3266 does not deduce are never used uninitialized.
a586633d
PE
3267 * window.h (check_all_windows): New decl, to forestall
3268 gcc -Wmissing-prototypes diagnostic.
5b555da1 3269 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3270
f6095868
PE
3271 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3272 shadowing.
3273 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3274 Include <limits.h>.
3275 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3276 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3277 (load_charset_map): Mark variables that gcc -Wuninitialized
3278 does not deduce are never used uninitialized.
53df7c11 3279 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3280
f38b440c
PE
3281 * coding.c (coding_set_source, coding_set_destination):
3282 Use "else { /* comment */ }" rather than "else /* comment */;"
3283 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3284 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3285 a block, when the outer 'i' will do.
3286 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3287 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3288 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3289 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3290 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3291 Rename locals to avoid shadowing.
3292 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3293 * coding.c (emacs_mule_char, encode_invocation_designation):
3294 Now static, since they're not used elsewhere.
413bb2db 3295 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3296 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3297 (decode_coding_emacs_mule): Mark variables that gcc
3298 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3299 (detect_coding_iso_2022): Initialize a local variable that might
3300 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3301 this initialization is needed. (Bug#8211)
5f58e762
PE
3302 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3303 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3304 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3305 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3306 Remove unused macros.
f38b440c 3307
232b38b9 3308 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3309 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3310 * character.c (string_count_byte8): Likewise.
232b38b9 3311
fb90da1b
PE
3312 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3313 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3314
fb93dbc2
PE
3315 * chartab.c (copy_sub_char_table): Now static, since it's not used
3316 elsewhere.
5c156ace
PE
3317 (sub_char_table_ref_and_range, char_table_ref_and_range):
3318 Rename locals to avoid shadowing.
bbcd0949 3319 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3320
7d3b3862 3321 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3322 (BIDI_BOB): Remove unused macro.
7d3b3862 3323
6be7d3da
PE
3324 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3325 deduce are never used uninitialized.
c2ed9c8b 3326 * term.c (encode_terminal_code): Likewise.
6be7d3da 3327
75f8807f 3328 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3329
50938595
PE
3330 * tparam.h: New file.
3331 * term.c, tparam.h: Include it.
3332 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3333 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3334 Move these decls to tparam.h, and make them agree with what
3335 is actually in tparam.c. The previous trick of using incompatible
3336 decls in different modules does not conform to the C standard.
3337 All callers of tparam changed to use tparam's actual API.
3338 * tparam.c (tparam1, tparam, tgoto):
3339 Use const pointers where appropriate.
3340
fbceeba2
PE
3341 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3342 * cm.h (struct cm): Likewise.
3343 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3344 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3345 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3346 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3347 (turn_on_face, init_tty): Likewise.
3348 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3349
7f3f1250
PE
3350 * term.c (term_mouse_position): Rename local to avoid shadowing.
3351
e6ca6543
PE
3352 * alloc.c (mark_ttys): Move decl from here ...
3353 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3354
c40f8d15
AS
33552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3356
3357 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3358
cfe0661d
JB
33592011-03-09 Juanma Barranquero <lekktu@gmail.com>
3360
3361 * search.c (compile_pattern_1): Remove argument regp, unused since
3362 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3363 (compile_pattern): Don't pass it.
3364
0afb4571
J
33652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3366
3367 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3368 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3369 for ! HAVE_GTK3.
3370 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3371
3372 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3373
3374 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3375 gdk_window_get_screen, gdk_window_get_geometry,
3376 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3377 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3378 (xg_get_pixbuf_from_pixmap): New function.
3379 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3380 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3381 Call xg_get_pixbuf_from_pixmap instead of
3382 gdk_pixbuf_get_from_drawable.
3383 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3384 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3385 (xg_check_special_colors): Use GtkStyleContext and its functions
3386 for HAVE_GTK3.
3387 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3388 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3389 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3390 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3391 Call gtk_widget_get_preferred_size.
0afb4571
J
3392 (xg_frame_resized): gdk_window_get_geometry only takes 5
3393 parameters.
44f230aa
SM
3394 (xg_win_to_widget, xg_event_is_for_menubar):
3395 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3396 (xg_set_widget_bg): New function.
3397 (delete_cb): New function.
895009e1 3398 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3399 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3400 (xg_set_background_color): Call xg_set_widget_bg.
3401 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3402 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3403 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3404 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3405 if ! HAVE_GTK3.
3406 (update_frame_tool_bar): Call gtk_widget_hide.
3407 (xg_initialize): Use GDK_KEY_g.
3408
3409 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3410 if ! HAVE_GTK3
3411 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3412
3413 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3414 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3415 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3416
1c2cc4ef
JB
34172011-03-08 Juanma Barranquero <lekktu@gmail.com>
3418
3419 * w32xfns.c (select_palette): Check success of RealizePalette against
3420 GDI_ERROR, not zero.
3421
33383987 3422See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3423
3424;; Local Variables:
3425;; coding: utf-8
aac0c6e3
MR
3426;; End:
3427
33383987 3428 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3429
3430 This file is part of GNU Emacs.
3431
3432 GNU Emacs is free software: you can redistribute it and/or modify
3433 it under the terms of the GNU General Public License as published by
3434 the Free Software Foundation, either version 3 of the License, or
3435 (at your option) any later version.
3436
3437 GNU Emacs is distributed in the hope that it will be useful,
3438 but WITHOUT ANY WARRANTY; without even the implied warranty of
3439 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3440 GNU General Public License for more details.
3441
3442 You should have received a copy of the GNU General Public License
3443 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.