* src/xfns.c (x_set_scroll_bar_default_width): Move declarations
[bpt/emacs.git] / src / ChangeLog
CommitLineData
810928a2
AS
12011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2
3 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4 before statements.
5
a059fe24
JD
62011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7
8 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9
10 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11
12 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
13 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14
989bf368
JB
152011-06-05 Juanma Barranquero <lekktu@gmail.com>
16
17 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
18
4b80f674
CY
192011-06-04 Chong Yidong <cyd@stupidchicken.com>
20
21 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
22 (x_clipboard_manager_save): Add return value.
23 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
24 error handlers.
25 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
26 Obey Vx_select_enable_clipboard_manager. Catch errors in
27 x_clipboard_manager_save (Bug#8779).
28 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 29 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 30
99a33b77 312011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
32
33 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
34
99a33b77 352011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
36
37 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
38 in the current matrix if keep_current_p is non-zero.
39
8264569d
EZ
402011-06-04 Eli Zaretskii <eliz@gnu.org>
41
42 * bidi.c (bidi_level_of_next_char): Fix last change.
43
57f97249
EZ
442011-06-03 Eli Zaretskii <eliz@gnu.org>
45
fec2107c 46 Support bidi reordering of text covered by display properties.
57f97249 47
fec2107c
EZ
48 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
49 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
50 (bidi_cache_search, bidi_cache_iterator_state)
51 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
52 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
53 character positions inside a run of characters covered by a
54 display string.
55 (bidi_paragraph_init, bidi_resolve_explicit_1)
56 (bidi_level_of_next_char): Call bidi_fetch_char and
57 bidi_fetch_char_advance instead of FETCH_CHAR and
58 FETCH_CHAR_ADVANCE.
59 (bidi_init_it): Initialize new members.
60 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
61 definitions.
62 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
63 instead of using explicit *_CHAR codes.
64 (bidi_resolve_explicit, bidi_resolve_weak): Use
65 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
66 bidirectional text is supported only in multibyte buffers.
67 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
68 it to initialize the frame_window_p member of struct bidi_it.
69 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
70 (bidi_resolve_explicit, bidi_resolve_weak)
71 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
72 bidi_it->nchars is non-positive.
73 (bidi_level_of_next_char): Don't try to lookup the cache for the
74 next/previous character if nothing is cached there yet, or if we
75 were just reseat()'ed to a new position.
c40e2fb2 76
0e14fe90
EZ
77 * xdisp.c (set_cursor_from_row): Set start and stop points
78 according to the row's direction when priming the loop that looks
79 for the glyph on which to display cursor.
80 (single_display_spec_intangible_p): Function deleted.
81 (display_prop_intangible_p): Reimplement to call
82 handle_display_spec instead of single_display_spec_intangible_p.
83 Accept 3 additional arguments needed by handle_display_spec. This
84 fixes incorrect cursor motion across display property with complex
85 values: lists, `(when COND...)' forms, etc.
86 (single_display_spec_string_p): Support property values that are
87 lists with the argument STRING its top-level element.
88 (display_prop_string_p): Fix the condition for processing a
89 property that is a list to be consistent with handle_display_spec.
fec2107c 90 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
91 last portion of handle_display_prop.
92 (compute_display_string_pos): Accept additional argument
93 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
94 value of a `display' property is a "replacing spec".
95 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
96 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
97 the display property, but just return a value indicating whether
98 the display property will replace the characters it covers.
99 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
100 frame_window_p members of struct bidi_it.
fec2107c
EZ
101 (compute_display_string_pos, compute_display_string_end): New
102 functions.
103 (push_it): Accept second argument POSITION, where pop_it should
104 jump to continue iteration.
105 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 106
fec2107c
EZ
107 * keyboard.c (adjust_point_for_property): Adjust the call to
108 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
109
110 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
111 (bidi_init_it): Update prototypes.
112 (display_prop_intangible_p): Update prototype.
113 (compute_display_string_pos, compute_display_string_end): Declare
114 prototypes.
115 (struct bidi_it): New members nchars and disp_pos. ch_len is now
116 EMACS_INT.
fc6f18ce 117
40087514 1182011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 119
57f53182
PE
120 Malloc failure behavior now depends on size of allocation.
121 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
122 * lisp.h: Change signatures accordingly.
123 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
124 All callers changed. (Bug#8762)
125
126 * gnutls.c: Use Emacs's memory allocators.
127 Without this change, the gnutls library would invoke malloc etc.
128 directly, which causes problems on non-SYNC_INPUT hosts, and which
129 runs afoul of improving memory_full behavior. (Bug#8761)
130 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
131 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
132 xfree instead of the default malloc, realloc, free.
133 (Fgnutls_boot): No need to check for memory allocation failure,
134 since xmalloc does that for us.
135
ac32cd99 136 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
137 * category.c (hash_get_category_set):
138 * ccl.c (ccl_driver):
139 * charset.c (Fdefine_charset_internal):
140 * charset.h (struct charset.hash_index):
141 * composite.c (get_composition_id, gstring_lookup_cache)
142 (composition_gstring_put_cache):
143 * composite.h (struct composition.hash_index):
144 * dispextern.h (struct image.hash):
145 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
146 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
147 (hashfn_equal, hashfn_user_defined, make_hash_table)
148 (maybe_resize_hash_table, hash_lookup, hash_put)
149 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
150 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
151 (Fsxhash, Fgethash, Fputhash, Fmaphash):
152 * image.c (make_image, search_image_cache, lookup_image)
153 (xpm_put_color_table_h):
154 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 155 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
156 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
157 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
158 * alloc.c (allocate_vectorlike):
159 Check for overflow in vector size calculations.
160 * ccl.c (ccl_driver):
161 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
162 * fns.c, image.c: Remove unnecessary static decls that would otherwise
163 need to be updated by these changes.
40087514
PE
164 * fns.c (make_hash_table, maybe_resize_hash_table):
165 Check for integer overflow with large hash tables.
0de4bb68
PE
166 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
167 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
168 (SXHASH_REDUCE): New macro.
169 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
170 Use it instead of discarding useful hash info with large hash values.
171 (sxhash_float): New function.
172 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
173 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
174 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
175 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
176 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
177 Adjust signatures to match updated version of code.
178 (consing_since_gc): Now EMACS_INT, since a single hash table can
179 use more than INT_MAX bytes.
180
698d32e2
DN
1812011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
182
183 Make it possible to build with GCC-4.6+ -O2 -flto.
184
185 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
186
fd6fa53f
SM
1872011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * minibuf.c (get_minibuffer, read_minibuf_unwind):
190 Call minibuffer-inactive-mode.
191
864db017
JB
1922011-05-31 Juanma Barranquero <lekktu@gmail.com>
193
194 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
195 Update dependencies.
196
2ad0baf4
DN
1972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
198
199 * data.c (init_data): Remove code for UTS, this system is not
200 supported anymore.
201
4fcc2638
DN
2022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
203
204 Don't force ./temacs to start in terminal mode.
205
206 * frame.c (make_initial_frame): Initialize faces in all cases, not
207 only when CANNOT_DUMP is defined.
208 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
209
c56e0fd5
DN
2102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
211
212 * dispnew.c (add_window_display_history): Use const for the string
213 pointer. Remove declaration, not needed.
214
333d54da 2152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 216
55d4c1b2 217 Use 'inline', not 'INLINE'.
333d54da 218 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
219 * alloc.c, fontset.c (INLINE): Remove.
220 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
221 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
222 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
223 * gmalloc.c (register_heapinfo): Use inline unconditionally.
224 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
225
738db178
DN
2262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
227
228 Make it possible to run ./temacs.
229
230 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
231 syms_of_callproc does the same thing. Remove test for
232 "initialized", do it in the caller.
233 * emacs.c (main): Avoid calling set_initial_environment when dumping.
234
620c53a6
SM
2352011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
236
237 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
238 (read_minibuf): Use get_minibuffer.
239 (syms_of_minibuf): Use DEFSYM.
240 (Qmetadata): New var.
241 * data.c (Qbuffer): Don't make it static.
242 (syms_of_data): Use DEFSYM.
243
e003a292
PE
2442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
245
246 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
247 (CCL_CODE_MIN): New macro.
248
ed008a6d
PE
2492011-05-30 Paul Eggert <eggert@cs.ucla.edu>
250
3687c2ef
PE
251 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
252
ed008a6d
PE
253 * eval.c (Qdebug): Now static.
254 * lisp.h (Qdebug): Remove decl. This reverts a part of the
255 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
256 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
257
d66c4c7c
CY
2582011-05-29 Chong Yidong <cyd@stupidchicken.com>
259
260 * image.c: Various fixes to ImageMagick code comments.
261 (Fimagemagick_types): Doc fix.
262
5fbc2025
PE
2632011-05-29 Paul Eggert <eggert@cs.ucla.edu>
264
0196f88a
PE
265 Minor fixes prompted by GCC 4.6.0 warnings.
266
267 * xselect.c (converted_selections, conversion_fail_tag): Now static.
268
5fbc2025
PE
269 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
270 (x_clipboard_manager_save_all): Move extern decl to ...
271 * xterm.h: ... here, so that it can be checked for consistency.
272
1dd3c2d9
CY
2732011-05-29 Chong Yidong <cyd@stupidchicken.com>
274
275 * xselect.c (x_clipboard_manager_save_frame)
276 (x_clipboard_manager_save_all): New functions.
277 (Fx_clipboard_manager_save): Lisp function deleted.
278
279 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
280 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
281
282 * xterm.h: Update prototype.
283
5ba6571d
WX
2842011-05-28 William Xu <william.xwl@gmail.com>
285
286 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
287 exiting (Bug#8239).
288
3eaff834
JM
2892011-05-28 Jim Meyering <meyering@redhat.com>
290
e1900994 291 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
292 * fns.c (to_uchar): Define.
293 (crypto_hash_function): Use it to convert some newly-signed
294 variables to unsigned, to avoid sign-extension bugs. For example,
295 without this change, (md5 "truc") would evaluate to
296 45723a2aff78ff4fff7fff1114760e62 rather than the expected
297 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 298 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 299
0f6990a7
PE
3002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
301
302 Integer overflow fixes.
c8a9ca5a 303
08686060
PE
304 * dbusbind.c: Serial number integer overflow fixes.
305 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
306 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
307 to hold a serial number that is too large for a fixnum.
308 (Fdbus_method_return_internal, Fdbus_method_error_internal):
309 Check for serial numbers out of range. Decode any serial number
59568bf0 310 that was so large that it became a float. (Bug#8722)
08686060 311
2d1fc3c7
PE
312 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
313 (Fdbus_call_method, Fdbus_call_method_asynchronously):
314 Use XFASTINT rather than XUINT when numbers are nonnegative.
315 (xd_append_arg, Fdbus_method_return_internal):
316 (Fdbus_method_error_internal): Likewise. Also, for unsigned
317 arguments, check that Lisp number is nonnegative, rather than
59568bf0 318 silently wrapping negative numbers around. (Bug#8722)
30217ff0 319 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 320 (Bug#8722)
2d1fc3c7 321
c8a9ca5a
PE
322 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
323
519e1d69
PE
324 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
325
30569699
PE
326 ccl: add integer overflow checks
327 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
328 (IN_INT_RANGE): New macros.
329 (ccl_driver): Use them to check for integer overflow when
330 decoding a CCL program. Many of the new checks are whether XINT (x)
331 fits in int; it doesn't always, on 64-bit hosts. The new version
332 doesn't catch all possible integer overflows, but it's an
847044ea 333 improvement. (Bug#8719)
30569699 334
c11285dc
PE
335 * alloc.c (make_event_array): Use XINT, not XUINT.
336 There's no need for unsigned here.
337
fdccd48e
PE
338 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
339 This follows up to the 2011-05-06 change that substituted uintptr_t
340 for EMACS_INT. This case wasn't caught back then.
341
37910ab2
PE
342 Rework Fformat to avoid integer overflow issues.
343 * editfns.c: Include <float.h> unconditionally, as it's everywhere
344 now (part of C89). Include <verify.h>.
345 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
346 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
347 (Fformat): Avoid the prepass trying to compute sizes; it was only
348 approximate and thus did not catch overflow reliably. Instead, walk
349 through the format just once, formatting and computing sizes as we go,
350 checking for integer overflow at every step, and allocating a larger
351 buffer as needed. Keep track separately whether the format is
352 multibyte. Keep only the most-recently calculated precision, rather
353 than them all. Record whether each argument has been converted to
354 string. Use EMACS_INT, not int, for byte and char and arg counts.
355 Support field widths and precisions larger than INT_MAX. Avoid
356 sprintf's undefined behavior with conversion specifications such as %#d
357 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
358 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
359 formatting out-of-range floating point numbers with int
360 formats. (Bug#8668)
361
2e6578fb
PE
362 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
363
0ae6bdee
PE
364 * data.c: Avoid integer truncation in expressions involving floats.
365 * data.c: Include <intprops.h>.
366 (arith_driver): When there's an integer overflow in an expression
367 involving floating point, convert the integers to floating point
368 so that the resulting value does not suffer from catastrophic
369 integer truncation. For example, on a 64-bit host (* 4
370 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
371 Do not rely on undefined behavior after integer overflow.
372
de883a70
PE
373 merge count_size_as_multibyte, parse_str_to_multibyte
374 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 375 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
376 Check for integer overflow.
377 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
378 since it's now a duplicate of the other. This is more of
379 a character than a buffer op, so better that it's in character.c.
380 * fns.c, print.c: Adjust to above changes.
381
2ff916cb
PE
3822011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
383
384 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
385
f1b54466
PE
3862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
387
fb1ac845
PE
388 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
389 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
390 (x_clipboard_manager_save): Now static.
391 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
392
f1b54466
PE
393 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
394 (crypto_hash_function): Now static.
395 Fix pointer signedness problems. Avoid unnecessary initializations.
396
a9f737ee
CY
3972011-05-27 Chong Yidong <cyd@stupidchicken.com>
398
399 * termhooks.h (Vselection_alist): Make it terminal-local.
400
401 * terminal.c (create_terminal): Initialize it.
402
403 * xselect.c: Support for clipboard managers.
404 (Vselection_alist): Move to termhooks.h as terminal-local var.
405 (LOCAL_SELECTION): New macro.
406 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
407 (symbol_to_x_atom): Remove gratuitous arg.
408 (x_handle_selection_request, lisp_data_to_selection_data)
409 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
410 (x_own_selection, x_get_local_selection, x_convert_selection):
411 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
412 (some_frame_on_display): Delete unused function.
413 (Fx_own_selection_internal, Fx_get_selection_internal)
414 (Fx_disown_selection_internal, Fx_selection_owner_p)
415 (Fx_selection_exists_p): New optional frame arg.
416 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
417 (x_handle_selection_clear): Don't treat other terminals with the
418 same keyboard specially. Use the terminal-local Vselection_alist.
419 (x_clear_frame_selections): Use Frun_hook_with_args.
420
421 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
422
423 * xterm.h: Add support for those atoms.
424
e067f0c1
CY
4252011-05-26 Chong Yidong <cyd@stupidchicken.com>
426
427 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
428 (converted_selections, conversion_fail_tag): New global variables.
429 (x_selection_request_lisp_error): Free the above.
430 (x_get_local_selection): Remove unnecessary code.
431 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
432 of converted selections stored in converted_selections.
433 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
434 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
435 (x_convert_selection): New function.
436 (x_handle_selection_event): Simplify.
437 (x_get_foreign_selection): Don't ignore incoming requests while
438 waiting for an answer; this will fail when we implement
439 SAVE_TARGETS, and seems unnecessary anyway.
440 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
441 (Vx_sent_selection_functions): Doc fix.
442
0f4aebc0
LL
4432011-05-26 Leo Liu <sdl.web@gmail.com>
444
445 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
446
e61124cd
YM
4472011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
448
449 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
450
451 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
452 for fringe update if it has periodic bitmap.
453 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
454 and fringe_bitmap_periodic_p.
455
456 * fringe.c (get_fringe_bitmap_data): New function.
457 (draw_fringe_bitmap_1, update_window_fringes): Use it.
458 (update_window_fringes): Record periodicity of fringe bitmap in glyph
459 row. Mark glyph row for fringe update if periodicity changed.
460
461 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
462 for fringe update unless it has periodic bitmap.
463
f16d9837
KH
4642011-05-25 Kenichi Handa <handa@m17n.org>
465
466 * xdisp.c (get_next_display_element): Set correct it->face_id for
467 a static composition.
468
e1b90ef6
LL
4692011-05-24 Leo Liu <sdl.web@gmail.com>
470
471 * deps.mk (fns.o):
472 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
473
474 * fns.c (crypto_hash_function, Fsha1): New function.
475 (Fmd5): Use crypto_hash_function.
476 (syms_of_fns): Add Ssha1.
477
7400048f
PE
4782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
479
480 * gnutls.c: Remove unused macros.
481 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
482 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
483 Remove macros that are defined and never used.
484 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
485
abb71cf4
CY
4862011-05-22 Chong Yidong <cyd@stupidchicken.com>
487
488 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
489 (Fx_get_selection_internal): Minor cleanup.
490 (Fx_own_selection_internal): Rename arguments for consistency with
491 select.el.
492
6307db39
PE
4932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
494
495 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
496
f3d4e0a4
CY
4972011-05-22 Chong Yidong <cyd@stupidchicken.com>
498
499 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
500
4d8ade89
YM
5012011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
502
503 * dispnew.c (scrolling_window): Don't exclude the case that the
504 last enabled row in the desired matrix touches the bottom boundary.
505
32078c8d
GM
5062011-05-21 Glenn Morris <rgm@gnu.org>
507
508 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
509 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
510 and add some more files.
32078c8d 511
7285dc67
EZ
5122011-05-20 Eli Zaretskii <eliz@gnu.org>
513
514 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
515 report_file_error introduced by the change from 2011-05-07.
516
89d1bd22
PE
5172011-05-20 Paul Eggert <eggert@cs.ucla.edu>
518
519 * systime.h (Time): Define only if emacs is defined.
520 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
521 where the include path doesn't have X11/X.h by default. See
522 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
523
e23640bb 5242011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
525
526 * composite.c (find_automatic_composition): Fix previous change.
527
b9704ad9
GM
5282011-05-20 Glenn Morris <rgm@gnu.org>
529
530 * lisp.mk: New file, split from Makefile.in.
531 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
532 (shortlisp): Remove.
533 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
534
4a720484
GM
5352011-05-19 Glenn Morris <rgm@gnu.org>
536
537 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
538 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
539 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
540 (lisp): Set the order to that of loadup.el.
541 (shortlisp): Make it a copy of $lisp.
542 (SOME_MACHINE_LISP): Remove.
543 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
544 Use just $shortlisp, not $SOME_MACHINE_LISP too.
545
a28d4396
KH
5462011-05-18 Kenichi Handa <handa@m17n.org>
547
548 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
549 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
550 (find_automatic_composition): Mostly rewrite for efficiency.
551
a2b1fa8e
JB
5522011-05-18 Juanma Barranquero <lekktu@gmail.com>
553
554 * makefile.w32-in: Update dependencies.
555
8e1f5610
CS
5562011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
557
558 * menu.c: Include limits.h (fixes the MS-Windows build broken by
559 revision 104625).
560
7025ee00 5612011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 562
cdfa6eab
PE
563 Fix some integer overflow issues, such as string length overflow.
564
06d6db33
PE
565 * insdel.c (count_size_as_multibyte): Check for string overflow.
566
2b4560a8
PE
567 * character.c (lisp_string_width): Check for string overflow.
568 Use EMACS_INT, not int, for string indexes and lengths; in
569 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
570 the resulting string length overflows an EMACS_INT; instead,
571 report a string overflow if no precision given. When checking for
572 precision exhaustion, use a check that cannot possibly have
573 integer overflow. (Bug#8675)
574 * character.h (lisp_string_width): Adjust to new signature.
575
cb93f9be
PE
576 * alloc.c (string_overflow): New function.
577 (Fmake_string): Use it. This doesn't change behavior, but saves
578 a few bytes and will simplify future changes.
579 * character.c (string_escape_byte8): Likewise.
580 * lisp.h (string_overflow): New decl.
581
1a1f3366
PE
582 Fixups, following up to the user-interface timestamp change.
583 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
584 for UI timestamps, instead of unsigned long.
9fbd6841
PE
585 * msdos.c (mouse_get_pos): Likewise.
586 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
587 * w32gui.h (Time): Define by including "systime.h" rather than by
588 declaring it ourselves. (Bug#8664)
589
d4e3e4d3
PE
590 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
591 * image.c (clear_image_cache): Likewise.
592
f6a24d19
PE
593 * term.c (term_mouse_position): Don't assume time_t wraparound.
594
08dc5ae6
PE
595 Be more systematic about user-interface timestamps.
596 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
597 and sometimes 'EMACS_UINT', to represent these timestamps.
598 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
599 This makes the code easier to follow, and makes it easier to catch
600 integer overflow bugs such as Bug#8664.
601 * frame.c (Fmouse_position, Fmouse_pixel_position):
602 Use Time, not unsigned long, for user-interface timestamps.
603 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
604 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
605 * keyboard.h (last_event_timestamp): Likewise.
606 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
607 * menu.h (xmenu_show): Likewise.
608 * term.c (term_mouse_position): Likewise.
609 * termhooks.h (struct input_event.timestamp): Likewise.
610 (struct terminal.mouse_position_hook): Likewise.
611 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
612 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
613 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
614 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
615 what it was before.
616 * menu.h, termhooks.h: Include "systime.h", for Time.
617
8e55734a
PE
618 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
619 Don't assume that the difference between two unsigned long values
620 can fit into an integer. At this point, we know button_down_time
621 <= event->timestamp, so the difference must be nonnegative, so
622 there's no need to cast the result if double-click-time is
623 nonnegative, as it should be; check that it's nonnegative, just in
624 case. This bug is triggered when events are more than 2**31 ms
86db42d2 625 apart (about 25 days). (Bug#8664)
8e55734a 626
841f1b75 627 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 628 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 629
3e26f69c
PE
630 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
631 that always fit in int. Use a sentinel instead of a counter, to
632 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
633 * frame.h (struct frame): Use int for menu_bar_items_used
634 instead of EMACS_INT, since it always fits in int.
3e26f69c 635
5cc152c0
PE
636 * menu.c (grow_menu_items): Check for int overflow.
637
d89eb65e
PE
638 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
639
5235bd3e
PE
640 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
641 Before, the code was not consistent. These values cannot exceed
642 2**31 - 1 so there's no need to make them unsigned.
643 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
644 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
645 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
646 as modifiers.
647 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
648
bc827e23
PE
649 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
650 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
651 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
652 presumably because the widths might not match.
653
78eb494e
PE
654 * window.c (size_window): Avoid needless test at loop start.
655
04f2d78b
CB
6562011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
657
658 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
659
d2fc7e3d 6602011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
661
662 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
663
d2fc7e3d 6642011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
665
666 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
667 `width' to `bar_area_x' and `bar_area_width', respectively.
668 (x_scroll_run): Take account of fringe background extension.
669
04f2d78b
CB
670 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
671 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
672 `bar_area_width', respectively.
673 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
674 background extension.
675
79b70037
GM
6762011-05-10 Jim Meyering <meyering@redhat.com>
677
678 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
679
2f142cc5
JB
6802011-05-10 Juanma Barranquero <lekktu@gmail.com>
681
682 * image.c (Finit_image_library): Return t for built-in image types,
683 like pbm and xbm. (Bug#8640)
684
57679c86
AS
6852011-05-09 Andreas Schwab <schwab@linux-m68k.org>
686
687 * w32menu.c (set_frame_menubar): Fix submenu allocation.
688
888c9e86
EZ
6892011-05-07 Eli Zaretskii <eliz@gnu.org>
690
b0512a1d
EZ
691 * w32console.c (Fset_screen_color): Doc fix.
692 (Fget_screen_color): New function.
693 (syms_of_ntterm): Defsubr it.
694
7285dc67
EZ
695 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
696 unlink the temporary file if Fcall_process didn't create it in the
697 first place.
698 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
699 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
700 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
701 cue to call_process_cleanup not to close that handle.
702
4d3fcc8e
BK
7032011-05-07 Ben Key <bkey76@gmail.com>
704
705 * makefile.w32-in: The bootstrap-temacs rule now makes use of
706 one of two shell specific rules, either bootstrap-temacs-CMD or
707 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
708 to the previous implementation of the bootstrap-temacs rule.
709 The bootstrap-temacs-CMD rule is similar to the previous
710 implementation of the bootstrap-temacs rule except that it
711 makes use of the ESC_CFLAGS variable instead of the CFLAGS
712 variable.
713
714 These changes, along with some changes to nt/configure.bat,
715 nt/gmake.defs, and nt/nmake.defs, are required to extend my
716 earlier fix to add support for --cflags and --ldflags options
717 that include quotes so that it works whether make uses cmd or
718 sh as the shell.
719
b4289b64
MA
7202011-05-06 Michael Albinus <michael.albinus@gmx.de>
721
722 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
723 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
724 is a constant.
725 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
726 a string. Handle both cases.
727 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
728 (Fdbus_register_method): Use Qinvalid_function.
729
af4c0e28
JB
7302011-05-06 Juanma Barranquero <lekktu@gmail.com>
731
732 * makefile.w32-in: Update dependencies.
733 (LISP_H): Add inttypes.h and stdin.h.
734 (PROCESS_H): Add unistd.h.
735
c51453d9
EZ
7362011-05-06 Eli Zaretskii <eliz@gnu.org>
737
738 * lread.c: Include limits.h (fixes the MS-Windows build broken by
739 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
740
8ff0ac3c 7412011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 742
4c4b566b
PE
743 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
744
aab2b9b5
PE
745 * term.c (vfatal): Remove stray call to va_end.
746 It's not needed and the C Standard doesn't allow it here anyway.
747
c378da0b
PE
748 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
749 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
750
288b08c7
PE
751 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
752 bytes.
753
e3601888
PE
754 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
755
db6c0e74
PE
756 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
757
dd5963ea
PE
758 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
759
88c9450f
PE
760 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
761
2f9442b8
PE
762 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
763
c032b5f8
PE
764 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
765 * charset.c (Fdefine_charset_internal): Don't initialize
766 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 767 32-bit int (Bug#8600).
a108c10b
PE
768
769 * lread.c (read_integer): Be more consistent with string-to-number.
770 Use string_to_number to do the actual conversion; this avoids
771 rounding errors and fixes some other screwups. Without this fix,
772 for example, #x1fffffffffffffff was misread as -2305843009213693952.
773 (digit_to_number): Move earlier, for benefit of read_integer.
774 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 775 not a digit in any supported base. (Bug#8602)
a108c10b 776
ad5f9eea
PE
777 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
778
aec1708a
PE
779 * dispnew.c (scrolling_window): Return 1 if we scrolled,
780 to match comment at start of function. This also removes a
781 GCC warning about overflow in a 32+64-bit port.
782
47be4ab5
PE
783 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
784
371cac43
PE
785 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
786 Reported by Stefan Monnier in
787 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
788 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
789 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 790
d01a7826
PE
791 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
792 (EMACS_UINTPTR): Likewise, with uintptr_t.
793
7fd47d5c
PE
794 * lisp.h: Prefer 64-bit EMACS_INT if available.
795 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
796 on 32-bit hosts that have 64-bit int, so that they can access
797 large files.
122b0c86
PE
798 However, temporarily disable this change unless the temporary
799 symbol WIDE_EMACS_INT is defined.
7fd47d5c 800
8727937b
PE
801 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
802
8ac068ac
PE
803 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
804 This removes an assumption that EMACS_INT and long are the same
805 width as pointers. The assumption is true for Emacs porting targets
806 now, but we want to make other targets possible.
807 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
808 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
809 In the rest of the code, change types of integers that hold casted
810 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
811 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
812 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
813 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
814 No need to cast type when ORing.
815 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
816 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
817 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
818 assume EMACS_INT is the same width as char *.
819 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
820 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
821 Remove no-longer-needed casts.
822 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
823 (xg_tool_bar_help_callback, xg_make_tool_item):
824 Use EMACS_INTPTR to hold an integer
825 that will be cast to void *; this can avoid a GCC warning
826 if EMACS_INT is not the same width as void *.
827 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
828 * xdisp.c (display_echo_area_1, resize_mini_window_1):
829 (current_message_1, set_message_1):
830 Use a local to convert to proper width without a cast.
831 * xmenu.c (dialog_selection_callback): Likewise.
832
ede49d71
PE
833 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
834 Also, don't assume VALBITS / RAND_BITS is less than 5,
835 and don't rely on undefined behavior when shifting a 1 left into
836 the sign bit.
837 * lisp.h (get_random): Change signature to match.
838
2f30ecd0
PE
839 * lread.c (hash_string): Use size_t, not int, for hash computation.
840 Normally we prefer signed values; but hashing is special, because
841 it's better to use unsigned division on hash table sizes so that
842 the remainder is nonnegative. Also, size_t is the natural width
843 for hashing into memory. The previous code used 'int', which doesn't
844 retain enough info to hash well into very large tables.
845 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
846
2a866e7b
PE
847 * dbusbind.c: Don't possibly lose pointer info when converting.
848 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
849 Use XPNTR rather than XHASH, so that the high-order bits of
850 the pointer aren't lost when converting through void *.
851
51639eac
PE
852 * eval.c (Fautoload): Don't double-shift a pointer.
853
92394119
PE
854 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
855
dbdb9a7c
JB
8562011-05-06 Juanma Barranquero <lekktu@gmail.com>
857
858 * gnutls.c (DEF_GNUTLS_FN):
859 * image.c (DEF_IMGLIB_FN): Make function pointers static.
860
db7a0b4f
AS
8612011-05-05 Andreas Schwab <schwab@linux-m68k.org>
862
863 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
864 marker. (Bug#8610)
865
f7ff1b0f 8662011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
867
868 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
869 New version that can reserve upto 2GB of heap space.
870
f7ff1b0f 8712011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
872
873 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
874
639c109b
TZ
8752011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
876
877 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
878 `gnutls_certificate_set_x509_key_file'.
879
d2127135
JB
8802011-05-05 Juanma Barranquero <lekktu@gmail.com>
881
882 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
883 Update dependencies.
884
e968f4f3
JB
8852011-05-04 Juanma Barranquero <lekktu@gmail.com>
886
887 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
888 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
889 Remove unused parameter `fildes'.
890 * process.c (read_process_output, send_process): Don't pass it.
891
84d358f0
JB
8922011-05-04 Juanma Barranquero <lekktu@gmail.com>
893
894 Fix previous change: the library cache is defined in w32.c.
895 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
896 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
897
0898ca10
JB
8982011-05-04 Juanma Barranquero <lekktu@gmail.com>
899
900 Implement dynamic loading of GnuTLS on Windows.
901
902 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
903 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
904 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
905 Declare.
906
907 * gnutls.c (Qgnutls_dll): Define.
908 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
909 (gnutls_*): Declare function pointers.
910 (init_gnutls_functions): New function to initialize function pointers.
911 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
912 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
913 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
914 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
915 (emacs_gnutls_write, emacs_gnutls_read)
916 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
917 (Fgnutls_available_p): New function.
918 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
919 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
920 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
921
922 * image.c: Include w32.h.
923 (Vimage_type_cache): Delete.
924 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
925 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
926 (w32_delayed_load): Move to w32.c.
927
928 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
929
930 * w32.c (QCloaded_from, Vlibrary_cache): Define.
931 (w32_delayed_load): Move from image.c. When loading a library, record
932 its filename in the :loaded-from property of the library id.
933 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
934 Initialize and staticpro them.
935 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
936
937 * process.c: Include lisp.h before w32.h, not after.
938 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
939 instead of gnutls_record_check_pending.
940
941 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
942
ff4de4aa
TZ
9432011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
944
945 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
946 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
947 as passed in.
948
abe95abb
JD
9492011-05-03 Jan Djärv <jan.h.d@swipnet.se>
950
951 * xterm.c (x_set_frame_alpha): Do not set property on anything
952 else than FRAME_X_OUTER_WINDOW (Bug#8608).
953
e16e55d4
JB
9542011-05-02 Juanma Barranquero <lekktu@gmail.com>
955
956 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
957
bafcf6a5
JB
9582011-05-02 Juanma Barranquero <lekktu@gmail.com>
959
960 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
961 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
962 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
963 (gnutls_global_initialized, Qgnutls_bootprop_priority)
964 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
965 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
966 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
967 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
968 (Qgnutls_bootprop_callbacks_verify): Make static.
969
e7a6747f
AS
9702011-05-01 Andreas Schwab <schwab@linux-m68k.org>
971
19ed11ba
AS
972 * callproc.c: Indentation fixup.
973
e7a6747f 974 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
975 (wait_for_termination, interruptible_wait_for_termination):
976 Move after wait_for_termination_1.
e7a6747f 977
1ef14cb4
LMI
9782011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
979
980 * sysdep.c (interruptible_wait_for_termination): New function
981 which is like wait_for_termination, but allows keyboard
982 interruptions.
983
984 * callproc.c (Fcall_process): Add (:file "file") as an option for
985 the STDOUT buffer.
986 (Fcall_process_region): Ditto.
987
330d880c
EZ
9882011-04-30 Eli Zaretskii <eliz@gnu.org>
989
8db90b73
EZ
990 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
991 rather than `XVECTOR (FOO)->size'.
992
330d880c
EZ
993 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
994 inttypes.h, as a gnulib replacement is used if it not available in
995 system headers.
996
15cbd324
EZ
9972011-04-21 Eli Zaretskii <eliz@gnu.org>
998
999 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1000 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1001 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1002
1003 * coding.c (coding_alloc_by_realloc): Error out if destination
1004 will grow beyond MOST_POSITIVE_FIXNUM.
1005 (decode_coding_emacs_mule): Abort if there isn't enough place in
1006 charbuf for the composition carryover bytes. Reserve an extra
1007 space for up to 2 characters produced in a loop.
1008 (decode_coding_iso_2022): Abort if there isn't enough place in
1009 charbuf for the composition carryover bytes.
1010
10112011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1012
ae940cca
EZ
1013 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1014 aborting when %lld or %lll format is passed.
1015 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1016 %llo or %llx format is passed. (Bug#8545)
1017
03ab8921
EZ
1018 * window.c (window_scroll_line_based): Use a marker instead of
1019 simple variables to record original value of point. (Bug#7952)
1020
afda1437
EZ
1021 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1022 produced by %s or %c overflows available buffer space. (Bug#8545)
1023
f76dee0c
PE
10242011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1027 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1028
fdc5744d
JB
10292011-04-28 Juanma Barranquero <lekktu@gmail.com>
1030
1031 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1032
638f053a
JB
10332011-04-28 Juanma Barranquero <lekktu@gmail.com>
1034
1035 * keyboard.c (Qdelayed_warnings_hook): Define.
1036 (command_loop_1): Run `delayed-warnings-hook'
1037 if Vdelayed_warnings_list is non-nil.
1038 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1039 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1040
d178f871
EZ
10412011-04-28 Eli Zaretskii <eliz@gnu.org>
1042
1043 * doprnt.c (doprnt): Don't return value smaller than the buffer
1044 size if the message was truncated. (Bug#8545).
1045
b124fd93
JB
10462011-04-28 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1049 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1050
e810457d
PE
10512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1052
1053 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1054
ea51cceb
JB
10552011-04-27 Juanma Barranquero <lekktu@gmail.com>
1056
1057 * makefile.w32-in: Update dependencies.
1058
94dcfacf
EZ
10592011-04-27 Eli Zaretskii <eliz@gnu.org>
1060
1061 Improve `doprnt' and its usage. (Bug#8545)
1062 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1063 `format_end'. Remove support for %l as a conversion specifier.
1064 Don't use xrealloc. Improve diagnostics when the %l size modifier
1065 is used. Update the commentary.
1066
1067 * eval.c (verror): Simplify calculation of size_t.
1068
1069 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1070 messages.
1071
f61f41d7
PE
10722011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1073
1074 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1075 change.
1076
96fb4434
PE
10772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1078
1079 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1080 This makes this file independent of the recent pseudovector change.
1081
671875da 10822011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1083
69e9b5a3
PE
1084 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1085
b5f869a7 1086 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1087 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1088 Remove unused local.
c8926152 1089 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1090
841a1577 1091 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1092 GCC 4.6.0 optimizes based on type-based alias analysis.
1093 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1094 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1095 != &v->size, and therefore "v->size = 1; b->size = 2; return
1096 v->size;" must therefore return 1. This assumption is incorrect
1097 for Emacs, since it type-puns struct Lisp_Vector * with many other
1098 types. To fix this problem, this patch adds a new type struct
f904488f 1099 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1100 and pseudovectors, and helps optimizing compilers not get fooled
1101 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1102 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1103 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1104 the size member.
eab3844f
PE
1105 (XSETPVECTYPE): Rewrite in terms of new macro.
1106 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1107 This is a bit clearer, and further avoids the possibility of
1108 undesirable aliasing.
1109 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1110 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1111 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1112 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1113 (ASIZE): Now uses header.size rather than size.
1114 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1115 to avoid the hassle of writing XVECTOR (foo)->header.size.
1116 (struct vectorlike_header): New type.
eab3844f
PE
1117 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1118 object, to help avoid aliasing.
1119 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1120 (SUBRP): Likewise, since Lisp_Subr is a special case.
1121 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1122 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1123 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1124 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1125 changed to be "header.size" and "header.next".
1126 * buffer.h (struct buffer): Likewise.
1127 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1128 * frame.h (struct frame): Likewise.
1129 * process.h (struct Lisp_Process): Likewise.
1130 * termhooks.h (struct terminal): Likewise.
1131 * window.c (struct save_window_data, struct saved_window): Likewise.
1132 * window.h (struct window): Likewise.
1133 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1134 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1135 * buffer.c (init_buffer_once): Likewise.
1136 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1137 special case.
1138 * process.c (Fformat_network_address): Use local var for size,
1139 for brevity.
1140
0df1eac5
PE
1141 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1142
847ab9d1 1143 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1144 * data.c (atof): Remove decl; no longer used or needed.
1145 (digit_to_number): Move to lread.c.
1146 (Fstring_to_number): Use new string_to_number function, to be
1147 consistent with how the Lisp reader treats infinities and NaNs.
1148 Do not assume that floating-point numbers represent EMACS_INT
1149 without losing information; this is not true on most 64-bit hosts.
1150 Avoid double-rounding errors, by insisting on integers when
1151 parsing non-base-10 numbers, as the documentation specifies.
1152 * lisp.h (string_to_number): New decl, replacing ...
1153 (isfloat_string): Remove.
bc0a5c13 1154 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1155 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1156 appears to have been a coding error. Similarly, do not accept
1157 strings like +-1e0 as floating point numbers. Do not report
1158 overflow for integer overflows unless the base is not 10 which
1159 means we have no simple and reliable way to continue.
1160 Break out the floating-point parsing into a new
1161 function string_to_number, so that Fstring_to_number parses
1162 floating point numbers consistently with the Lisp reader.
04f2d78b 1163 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1164 (E_CHAR, EXP_INT): Remove, replacing with ...
1165 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1166 (string_to_number): New function, replacing isfloat_string.
1167 This function checks for valid syntax and produces the resulting
1168 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1169 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1170 so that overflow for non-base-10 numbers is reported only when
1171 there's no portable and simple way to convert to floating point.
452f4150 1172
67769ffc
PE
1173 * textprop.c (set_text_properties_1): Rewrite for clarity,
1174 and to avoid GCC warning about integer overflow.
1175
c20db43f
PE
1176 * intervals.h (struct interval): Use EMACS_INT for members
1177 where EMACS_UINT might cause problems. See
1178 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1179 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1180 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1181 All uses changed.
37aa2f85
PE
1182 (offset_intervals): Tell GCC not to worry about length overflow
1183 when negating a negative length.
c20db43f 1184
2538aa2f
PE
1185 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1186 (overrun_check_free): Likewise.
1187
f2d3008d
PE
1188 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1189 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1190 word size.
1191
ec8df744
PE
1192 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1193 (gnutls_make_error): Rename local to avoid shadowing.
1194 (gnutls_emacs_global_deinit): ifdef out; not used.
1195 (Fgnutls_boot): Use const for pointer to readonly storage.
1196 Comment out unused local. Fix pointer signedness problems.
1197
640ee02d
PE
1198 * lread.c (openp): Don't stuff size_t into an 'int'.
1199 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1200 about possible signed overflow.
1201
6048fb2a
PE
1202 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1203 (GDK_KEY_g): Don't define if already defined.
1204 (xg_prepare_tooltip): Avoid pointer signedness problem.
1205 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1206
fa3c87e1
PE
1207 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1208 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1209
2172544b
PE
1210 * xfns.c (Fx_window_property): Simplify a bit,
1211 to make a bit faster and to avoid GCC 4.6.0 warning.
1212 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1213
9b821a21
PE
1214 * fns.c (internal_equal): Don't assume size_t fits in int.
1215
3c616cfa
PE
1216 * alloc.c (compact_small_strings): Tighten assertion a little.
1217
c2982e87
PE
1218 Replace pEd with more-general pI, and fix some printf arg casts.
1219 * lisp.h (pI): New macro, generalizing old pEd macro to other
1220 conversion specifiers. For example, use "...%"pI"d..." rather
1221 than "...%"pEd"...".
1222 (pEd): Remove. All uses replaced with similar uses of pI.
1223 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1224 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1225 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1226 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1227 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1228 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1229 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1230 64-bit hosts.
1231 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1232 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1233 * print.c (safe_debug_print, print_object): Likewise.
1234 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1235 to int.
6f04d126
PE
1236 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1237 avoiding the 0 flag, which is not portable.
c2982e87
PE
1238 * process.c (Fmake_network_process): Use pI to avoid cast.
1239 * region-cache.c (pp_cache): Likewise.
1240 * xdisp.c (decode_mode_spec): Likewise.
1241 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1242 behavior on 64-bit hosts with printf arg.
6f04d126 1243 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1244 (x_stop_queuing_selection_requests): Likewise.
1245 (x_get_window_property): Don't truncate byte count to an 'int'
1246 when tracing.
0b432f21 1247
5e073ec7
PE
1248 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1249 here, since it parses constructs like leading '-' and spaces,
1250 which are not wanted; and it overflows with large numbers.
1251 Instead, simply match F[0-9]+, which is what is wanted anyway.
1252
36372bf9
PE
1253 * alloc.c: Remove unportable assumptions about struct layout.
1254 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1255 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1256 (allocate_vectorlike, make_pure_vector): Use the new macros,
1257 plus offsetof, to remove unportable assumptions about struct layout.
1258 These assumptions hold on all porting targets that I know of, but
1259 they are not guaranteed, they're easy to remove, and removing them
1260 makes further changes easier.
1261
0b432f21
PE
1262 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1263 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1264 (string_overrun_cookie): Now const. Use initializers that
1265 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1266 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1267 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1268 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1269 multiple of sizeof (EMACS_INT); it need not be, if
1270 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1271 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1272
895009e1
JB
12732011-04-26 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1276
6a7a1b0b
TZ
12772011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1278
1279 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1280 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1281 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1282
841a1577 12832011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1284
1285 * lisp.h (Qdebug): List symbol.
895009e1 1286 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1287 * keyboard.c (debug-on-event): New variable.
1288 (handle_user_signal): Break into debugger when debug-on-event
1289 matches the current signal symbol.
1290
f2d3ba6f
DN
12912011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1292
1293 * alloc.c (check_sblock, check_string_bytes)
1294 (check_string_free_list): Convert to standard C.
1295
42ce4c63
TZ
12962011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1297
1298 * w32.c (emacs_gnutls_push): Fix typo.
1299
825cd63c
EZ
13002011-04-25 Eli Zaretskii <eliz@gnu.org>
1301
fb11d64d
EZ
1302 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1303 "cast to pointer from integer of different size".
1304
825cd63c
EZ
1305 Improve doprnt and its use in verror. (Bug#8545)
1306 * doprnt.c (doprnt): Document the set of format control sequences
1307 supported by the function. Use SAFE_ALLOCA instead of always
1308 using `alloca'.
1309
1310 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1311 is one byte too soon. Don't use xrealloc; instead xfree and
1312 xmalloc anew.
1313
e061a11b
TZ
13142011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1315
1316 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1317 callbacks stage.
1318
1319 * gnutls.c: Renamed global_initialized to
1320 gnutls_global_initialized. Added internals for the
1321 :verify-hostname-error, :verify-error, and :verify-flags
1322 parameters of `gnutls-boot' and documented those parameters in the
1323 docstring. Start callback support.
1324 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1325 unless a fatal error occured. Call gnutls_alert_send_appropriate
1326 on error. Return error code.
1327 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1328 (emacs_gnutls_read): Likewise.
1329 (Fgnutls_boot): Return handshake error code.
1330 (emacs_gnutls_handle_error): New function.
1331 (wsaerror_to_errno): Likewise.
1332
1333 * w32.h (emacs_gnutls_pull): Add prototype.
1334 (emacs_gnutls_push): Likewise.
1335
1336 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1337 (emacs_gnutls_push): Likewise.
1338
13392011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1340
1341 * process.c (wait_reading_process_output): Check if GnuTLS
1342 buffered some data internally if no FDs are set for TLS
1343 connections.
1344
1345 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1346 (LIBS): Link to USER_LIBS.
1347 ($(BLD)/gnutls.$(0)): New target.
1348
fa6996bc
EZ
13492011-04-24 Eli Zaretskii <eliz@gnu.org>
1350
eb35682e
EZ
1351 * xdisp.c (handle_single_display_spec): Rename the
1352 display_replaced_before_p argument into display_replaced_p, to
1353 make it consistent with the commentary. Fix typos in the
1354 commentary.
1355
e2ad650c
EZ
1356 * textprop.c (syms_of_textprop): Remove dead code.
1357 (copy_text_properties): Delete obsolete commentary about an
1358 interface that was deleted long ago. Fix typos in the description
1359 of arguments.
1360
1b2de274
EZ
1361 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1362 to changes in oldXMenu/XMenu.h from 2011-04-16.
1363 <menu_help_message, prev_menu_help_message>: Constify.
1364 (IT_menu_make_room): menu->help_text is now `const char **';
1365 adjust.
1366
1367 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1368 to changes in oldXMenu/XMenu.h from 2011-04-16.
1369 (struct XMenu): Declare `help_text' `const char **'.
1370
1371 * xfaces.c <Qunspecified>: Make extern again.
1372
1373 * syntax.c: Include sys/types.h before including regex.h, as
1374 required by Posix.
1375
762b15be
EZ
1376 * doc.c (get_doc_string): Improve the format passed to `error'.
1377
1378 * doprnt.c (doprnt): Improve commentary.
1379
1380 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1381
1382 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1383 them with etags.
1384
f1052e5d
EZ
1385 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1386 changes in globals.h immediately force recompilation.
762b15be
EZ
1387 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1388 $(CURDIR)/s/ms-w32.h.
1389 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1390
fa6996bc
EZ
1391 * character.c (Fchar_direction): Function deleted.
1392 (syms_of_character): Don't defsubr it.
1393 <char-direction-table>: Deleted.
1394
e6c3da20
EZ
13952011-04-23 Eli Zaretskii <eliz@gnu.org>
1396
1397 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1398 * doprnt.c: Include limits.h.
1399 (SIZE_MAX): New macro.
04f2d78b
CB
1400 (doprnt): Return a size_t value. 2nd arg is now size_t.
1401 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1402 Improve overflow protection. Support `l' modifier for integer
1403 conversions. Support %l conversion. Don't assume an EMACS_INT
1404 argument for integer conversions and for %c.
1405
1406 * lisp.h (doprnt): Restore prototype.
1407
1408 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1409 $(SRC)/character.h.
1410
1411 * Makefile.in (base_obj): Add back doprnt.o.
1412
1413 * deps.mk (doprnt.o): Add back prerequisites.
1414 (callint.o): Depend on character.h.
1415
1416 * eval.c (internal_lisp_condition_case): Include the handler
1417 representation in the error message.
1418 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1419 when breaking from the loop.
1420
1421 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1422
1423 * callint.c (Fcall_interactively): When displaying error message
1424 about invalid control letter, pass the character's codepoint, not
1425 a pointer to its multibyte form. Improve display of the character
1426 in octal and display also its hex code.
1427
1428 * character.c (char_string): Use %x to display the (unsigned)
1429 codepoint of an invalid character, to avoid displaying a bogus
1430 negative value.
1431
1432 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1433 `error', not SYMBOL_NAME itself.
1434
1435 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1436 character arguments to `error'.
1437
1438 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1439 to `error' in error message about FINAL_CHAR argument. Make sure
1440 FINAL_CHAR is a character, and use %c when it is passed as
1441 argument to `error'.
1442
4ffd0d6b 14432011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1444
1445 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1446
1447 * w32.c: Include <time.h>.
1448 (sys_localtime): New function.
1449
4ffd0d6b 14502011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1451
1452 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1453
4ffd0d6b 1454 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1455
4ffd0d6b 14562011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1457
4ffd0d6b
GM
1458 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1459 zombies (Bug#8467).
aac0c6e3 1460
04c56954
EZ
14612011-04-19 Eli Zaretskii <eliz@gnu.org>
1462
1463 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1464 gl_state.e_property when gl_state.object is Qt.
1465
1466 * insdel.c (make_gap_larger): Remove limitation of buffer size
1467 to <= INT_MAX.
1468
16a43933
CY
14692011-04-18 Chong Yidong <cyd@stupidchicken.com>
1470
1471 * xdisp.c (lookup_glyphless_char_display)
1472 (produce_glyphless_glyph): Handle cons cell entry in
1473 glyphless-char-display.
1474 (Vglyphless_char_display): Document it.
1475
1476 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1477 glyphless-char-display.
1478
4581706e
CY
14792011-04-17 Chong Yidong <cyd@stupidchicken.com>
1480
1481 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1482
1483 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1484
1485 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1486 definition for no-X builds.
1487
4887c6e2 14882011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1489
fd35b6f9
PE
1490 Static checks with GCC 4.6.0 and non-default toolkits.
1491
5c1ccb01
PE
1492 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1493
006c5daa
PE
1494 * process.c (keyboard_bit_set): Define only if SIGIO.
1495 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1496 (send_process): Repair possible setjmp clobbering.
1497
efc736d3
PE
1498 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1499
4e2fe2e6
PE
1500 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1501
f97334a2
PE
1502 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1503
4e75f29d
PE
1504 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1505 Define only if needed.
1506
90efadd1
PE
1507 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1508 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1509 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1510
3c647824
PE
1511 * dispextern.h (struct redisplay_interface): Rename param
1512 to avoid shadowing.
e264f262 1513 * termhooks.h (struct terminal): Likewise.
761383f4 1514 * xterm.c (xembed_send_message): Likewise.
3c647824 1515
b58c5c4a
PE
1516 * insdel.c (make_gap_smaller): Define only if
1517 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1518
cad59032
PE
1519 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1520 it.
1521
c339dc2e
PE
1522 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1523 so that we aren't warned about unused symbols.
1524
91a3e27b
PE
1525 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1526
399c71d3 1527 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1528
8ffc96f5
PE
1529 * xfns.c (x_real_positions): Mark locals as initialized.
1530
eef9bc79
PE
1531 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1532
098db9dd
PE
1533 * xterm.c: Fix problems found by static analysis with other toolkits.
1534 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1535 (x_dispatch_event): Declare static if USE_GTK, and
1536 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1537 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1538 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1539 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1540 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1541
eb18f6cc
PE
1542 * xmenu.c (menu_help_callback): Pointer type fixes.
1543 Use const pointers when pointing at readonly data. Avoid pointer
1544 signedness clashes.
1545 (FALSE): Remove unused macro.
1546 (update_frame_menubar): Remove unused decl.
1547
1fe72bf8
PE
1548 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1549
60d9e1db
PE
1550 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1551 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1552 (single_menu_item): Rename local to avoid shadowing.
1553
39261c26
PE
1554 * keyboard.c (make_lispy_event): Remove unused local var.
1555
018c5e19
PE
1556 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1557 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1558
63d2b86e
PE
1559 * bitmaps: Change bitmaps from unsigned char back to the X11
1560 compatible char. Avoid the old compiler warnings about
1561 out-of-range initializers by using, for example, '\xab' rather
1562 than 0xab.
1563
aefd87e1
PE
1564 * xgselect.c (xgselect_initialize): Check vs interface
1565 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1566
bf501fb9
PE
1567 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1568
e9829fdf
PE
1569 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1570 to read-only memory.
1571
1086c095
PE
1572 * fns.c (vector): Remove; this old hack is no longer needed.
1573
2baccd04 1574 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1575 Remove unused var.
dde42981 1576 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1577
72391843 1578 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1579
436c16df 1580 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1581 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1582 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1583
92bb796d 1584 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1585 (x_term_init): Remove local to avoid shadowing.
92bb796d 1586
764430a3 1587 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1588
1589 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1590 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1591
d1dfb56c
EZ
15922011-04-16 Eli Zaretskii <eliz@gnu.org>
1593
c4354cb4
EZ
1594 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1595
d1dfb56c
EZ
1596 Fix regex.c, syntax.c and friends for buffers > 2GB.
1597 * syntax.h (struct gl_state_s): Declare character position members
1598 EMACS_INT.
1599
1600 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1601
04f2d78b
CB
1602 * textprop.c (verify_interval_modification, interval_of):
1603 Declare arguments EMACS_INT.
d1dfb56c
EZ
1604
1605 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1606 EMACS_INT.
1607
1608 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1609
1610 * indent.c (Fvertical_motion): Local variable it_start is now
1611 EMACS_INT.
1612
1613 * regex.c (re_match, re_match_2, re_match_2_internal)
1614 (bcmp_translate, regcomp, regexec, print_double_string)
1615 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1616 (re_compile_pattern, re_exec): Declare arguments and local
1617 variables `size_t' and `ssize_t' and return values `regoff_t', as
1618 appropriate.
1619 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1620 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1621 <compile_stack_type>: `size' and `avail' are now `size_t'.
1622
1623 * regex.h <regoff_t>: Use ssize_t, not int.
1624 (re_search, re_search_2, re_match, re_match_2): Arguments that
1625 specify buffer/string position and length are now ssize_t and
1626 size_t. Return type is regoff_t.
1627
613052cd
BK
16282011-04-16 Ben Key <bkey76@gmail.com>
1629
1630 * nsfont.m: Fixed bugs in ns_get_family and
1631 ns_descriptor_to_entity that were caused by using free to
1632 deallocate memory blocks that were allocated by xmalloc (via
1633 xstrdup). This caused Emacs to crash when compiled with
1634 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1635 --enable-checking=xmallocoverrun). xfree is now used to
1636 deallocate these memory blocks.
1637
4170f62f 16382011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1639
71b41406
PE
1640 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1641
9587a89d
PE
1642 emacs_write: Accept and return EMACS_INT for sizes.
1643 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1644 et seq.
1645 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1646 Accept and return EMACS_INT.
1647 (emacs_gnutls_write): Return the number of bytes written on
1648 partial writes.
1649 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1650 (emacs_read, emacs_write): Remove check for negative size, as the
1651 Emacs source code has been audited now.
9587a89d
PE
1652 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1653 (emacs_read, emacs_write): Use it.
273a5f82
PE
1654 * process.c (send_process): Adjust to the new signatures of
1655 emacs_write and emacs_gnutls_write. Do not attempt to store
1656 a byte offset into an 'int'; it might overflow.
9587a89d 1657 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1658
3e047f51
PE
1659 * sound.c: Don't assume sizes fit in 'int'.
1660 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1661 Return EMACS_INT, not int.
3e047f51 1662 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1663 Accept EMACS_INT, not int.
1664 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1665 record read return values.
1666
cc39a9db
BK
16672011-04-15 Ben Key <bkey76@gmail.com>
1668
c9d0ec6d
JB
1669 * keyboard.c (Qundefined): Don't declare static since it is used
1670 in nsfns.m.
1671 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1672 static since they are used in nsfont.m.
cc39a9db 1673
6c60eb9f
SM
16742011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1675
1676 * process.c (Qprocessp): Don't declare static.
1677 * lisp.h (Qprocessp): Declare again.
1678
7990b61a
JB
16792011-04-15 Juanma Barranquero <lekktu@gmail.com>
1680
1681 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1682
5d4cb038
PE
16832011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1684
8bd7b830 1685 Improve C-level modularity by making more things 'static'.
cd64ea1d 1686
e3b27b31
PE
1687 Don't publish debugger-only interfaces to other modules.
1688 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1689 (verify_bytepos, count_markers): Move decls to the only modules
1690 that need them.
1691 * region-cache.h (pp_cache): Likewise.
1692 * window.h (check_all_windows): Likewise.
1693 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1694
5d4cb038
PE
1695 * sysdep.c (croak): Now static, if
1696 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1697 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1698
1699 * alloc.c (refill_memory_reserve): Now static if
1700 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1701 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1702
e87b6180
PE
1703 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1704 Define only if USE_LUCID.
1705
ac64929e
PE
1706 * xrdb.c (x_customization_string, x_rm_string): Now static.
1707
6f37259d
PE
1708 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1709 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1710
1683e3ab
PE
1711 * xdisp.c (draw_row_with_mouse_face): Now static.
1712 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1713
de9c2632
PE
1714 * window.h (check_all_windows): Mark externally visible.
1715
2b96acb7
PE
1716 * window.c (window_deletion_count): Now static.
1717
1718 * undo.c: Make symbols static if they're not exported.
1719 (last_undo_buffer, last_boundary_position, pending_boundary):
1720 Now static.
1721
50436f33
PE
1722 * textprop.c (interval_insert_behind_hooks): Now static.
1723 (interval_insert_in_front_hooks): Likewise.
1724
64520e5c
PE
1725 * term.c: Make symbols static if they're not exported.
1726 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1727 (max_frame_lines, tty_set_terminal_modes):
1728 (tty_reset_terminal_modes, tty_turn_off_highlight):
1729 (get_tty_terminal): Now static.
1730 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1731 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1732 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1733 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1734 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1735
1fa53021
PE
1736 * sysdep.c: Make symbols static if they're not exported.
1737 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1738 Now static.
1739 (sigprocmask_set, full_mask): Remove; unused.
1740 (wait_debugging): Mark as visible.
1741 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1742 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1743
d4b43b22
PE
1744 * syntax.c (syntax_temp): Define only if !__GNUC__.
1745
b7c513d0
PE
1746 * sound.c (current_sound_device, current_sound): Now static.
1747
989b29ad
PE
1748 * search.c (searchbufs, searchbuf_head): Now static.
1749
13a55a78
PE
1750 * scroll.c (scroll_cost): Remove; unused.
1751 * dispextern.h (scroll_cost): Remove decl.
1752
de68a1fc
PE
1753 * region-cache.h (pp_cache): Mark as externally visible.
1754
40ccffa6
PE
1755 * process.c: Make symbols static if they're not exported.
1756 (process_tick, update_tick, create_process, chan_process):
1757 (Vprocess_alist, proc_buffered_char, datagram_access):
1758 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1759 (deactivate_process): Mark defn as static, as well as decl.
1760 * lisp.h (create_process): Remove decl.
1761 * process.h (chan_process, Vprocess_alist): Remove decls.
1762
ad64fc97
PE
1763 * print.c: Make symbols static if they're not exported.
1764 (print_depth, new_backquote_output, being_printed, print_buffer):
1765 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1766 (print_interval, print_number_index, initial_stderr_stream):
1767 Now static.
1768 * lisp.h (Fprinc): Remove decl.
1769 (debug_output_compilation_hack): Mark as externally visible.
1770
adddb265
PE
1771 * sysdep.c (croak): Move decl from here to syssignal.h.
1772 * syssignal.h (croak): Put it here, so the API can be checked when
1773 'croak' is called from dissociate_if_controlling_tty.
1774
1717ede2
PE
1775 * minibuf.c: Make symbols static if they're not exported.
1776 (minibuf_save_list, choose_minibuf_frame): Now static.
1777 * lisp.h (choose_minibuf_frame): Remove decl.
1778
fa5fb2bc
PE
1779 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1780
1e3890d1
PE
1781 * lread.c: Make symbols static if they're not exported.
1782 (read_objects, initial_obarray, oblookup_last_bucket_number):
1783 Now static.
1784 (make_symbol): Remove; unused.
1785 * lisp.h (initial_obarray, make_symbol): Remove decls.
1786
8a1414fa
PE
1787 * keyboard.c: Make symbols static if they're not exported.
1788 (single_kboard, recent_keys_index, total_keys, recent_keys):
1789 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1790 (this_single_command_key_start, echoing, last_auto_save):
1791 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1792 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1793 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1794 (Vlispy_mouse_stem, double_click_count):
1795 Now static.
1796 (force_auto_save_soon): Define only if SIGDANGER.
1797 (ignore_mouse_drag_p): Now static if
1798 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1799 (print_help): Remove; unused.
1800 (stop_character, last_timer_event): Mark as externally visible.
1801 * keyboard.h (ignore_mouse_drag_p): Declare only if
1802 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1803 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1804 * lisp.h (echoing): Remove decl.
1805 (force_auto_save_soon): Declare only if SIGDANGER.
1806 * xdisp.c (redisplay_window): Simplify code, to make it more
1807 obvious that ignore_mouse_drag_p is not accessed if !defined
1808 USE_GTK && !defined HAVE_NS.
1809
93ea6e8f
PE
1810 * intervals.c: Make symbols static if they're not exported.
1811 (merge_properties_sticky, merge_interval_right, delete_interval):
1812 Now static.
1813 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1814
77382fcc
PE
1815 * insdel.c: Make symbols static if they're not exported.
1816 However, leave prepare_to_modify_buffer alone. It's never
1817 called from outside this function, but that appears to be a bug.
1818 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1819 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1820 (adjust_after_replace_noundo): Remove; unused.
1821 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1822 (signal_before_change): Remove decls.
77382fcc 1823
9306c32e
PE
1824 * indent.c (val_compute_motion, val_vmotion): Now static.
1825
cd44d2eb
PE
1826 * image.c: Make symbols static if they're not exported.
1827 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1828 if USE_GTK.
1829 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1830 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1831
ad9a7a06
PE
1832 * fringe.c (standard_bitmaps): Now static.
1833 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1834
81626931
PE
1835 * frame.c: Make symbols static if they're not exported.
1836 (x_report_frame_params, make_terminal_frame): Now static.
1837 (get_frame_param): Now static, unless HAVE_NS.
1838 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1839 (x_get_resource_string): Remove; not used.
1840 * frame.h (make_terminal_frame, x_report_frame_params):
1841 (x_get_resource_string); Remove decls.
1842 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1843 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1844
239f9db9
PE
1845 * font.c, fontset.c: Make symbols static if they're not exported.
1846 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1847 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1848 * font.c (font_close_object): Now static.
1849 * font.h (font_close_object): Remove.
1850 * fontset.c (FONTSET_OBJLIST): Remove.
1851 (free_realized_fontset) #if-0 the body, which does nothing.
1852 (face_suitable_for_char_p): #if-0, as it's never called.
1853 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1854 * xfaces.c (face_at_string_position):
1855 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1856 since 0 is always ASCII.
1857
dfcf3579
PE
1858 * fns.c (weak_hash_tables): Now static.
1859
5045092b
PE
1860 * fileio.c: Make symbols static if they're not exported.
1861 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1862 (Vwrite_region_annotation_buffers): Now static.
1863
57a96f5c
PE
1864 * eval.c: Make symbols static if they're not exported.
1865 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1866 * lisp.h (backtrace_list): Remove decl.
1867
35f08c38
PE
1868 * emacs.c: Make symbols static if they're not exported.
1869 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1870 (fatal_error_code, fatal_error_signal_hook, standard_args):
1871 Now static.
1872 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1873 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1874 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1875 * lisp.h (fatal_error_signal_hook): Remove decl.
1876 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1877
f44bd759
PE
1878 * editfns.c: Move a (normally-unused) function to its only use.
1879 * editfns.c, lisp.h (get_operating_system_release): Remove.
1880 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1881 worth the hassle of breaking this out.
1882
b532497d
PE
1883 * xterm.c: Make symbols static if they're not exported.
1884 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1885 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1886 (x_destroy_window, x_delete_display):
1887 Now static.
1888 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1889 (x_mouse_leave): Remove; unused.
1890 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1891 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1892 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1893 Remove decls.
1894 (x_mouse_leave): Declare only if WINDOWSNT.
1895 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1896 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1897 USE_X_TOOLKIT.
1898
1675728f
PE
1899 * ftxfont.c: Make symbols static if they're not exported.
1900 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1901 HAVE_FREETYPE.
1902 * font.h (ftxfont_driver): Likewise.
1903
e4cebfca
PE
1904 * xfns.c: Make symbols static if they're not exported.
1905 (x_last_font_name, x_display_info_for_name):
1906 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1907 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1908 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1909 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1910 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1911 (last_show_tip_args): Now static.
1912 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1913 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1914 (x_screen_planes): Remove; unused.
1915 * dispextern.h (x_screen_planes): Remove decl.
1916
5bf46f05
PE
1917 * dispnew.c: Make symbols static if they're not exported.
1918 * dispextern.h (redraw_garbaged_frames, scrolling):
1919 (increment_row_positions): Remove.
1920 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1921 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1922 Now static.
1923 (redraw_garbaged_frames): Remove; unused.
1924
435f4c28
PE
1925 * xfaces.c: Make symbols static if they're not exported.
1926 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1927 Remove decls.
1928 * xterm.h (defined_color): Remove decls.
1929 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1930 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1931 (menu_face_changed_default, defined_color, free_realized_face):
1932 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1933 (ascii_face_of_lisp_face): Remove; unused.
1934
8524aef3
PE
1935 * xdisp.c: Make symbols static if they're not exported.
1936 * dispextern.h (scratch_glyph_row, window_box_edges):
1937 (glyph_to_pixel_coords, set_cursor_from_row):
1938 (get_next_display_element, set_iterator_to_next):
1939 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1940 (show_mouse_face): Remove decls
1941 * frame.h (message_buf_print): Likewise.
1942 * lisp.h (pop_message, set_message, check_point_in_composition):
1943 Likewise.
1944 * xterm.h (set_vertical_scroll_bar): Likewise.
1945 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1946 (message_buf_print, scratch_glyph_row, displayed_buffer):
1947 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1948 (get_next_display_element, show_mouse_face, window_box_edges):
1949 (frame_to_window_pixel_xy, check_point_in_composition):
1950 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1951 (glyph_to_pixel_coords): Remove; unused.
1952
16390cd2
PE
1953 * dired.c (file_name_completion): Now static.
1954
1955 * dbusbind.c (xd_in_read_queued_messages): Now static.
1956
a25f4dfa
PE
1957 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1958 * data.c (circular_list_error): Remove.
1959
14a9c8df
PE
1960 * commands.h (last_point_position, last_point_position_buffer):
1961 (last_point_position_window): Remove decls.
1962 * keyboard.c: Make these variables static.
1963
04f2d78b
CB
1964 * coding.h (coding, code_convert_region, encode_coding_gap):
1965 Remove decls.
74ab6df5
PE
1966 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1967 (iso_code_class, detect_coding, code_convert_region): Now static.
1968 (encode_coding_gap): Remove; unused.
1969
38dfbee1
PE
1970 * chartab.c (chartab_chars, chartab_bits): Now static.
1971
a2cb4e63
PE
1972 * charset.h (charset_iso_8859_1): Remove decl.
1973 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1974 Now static.
1975
127198fd
PE
1976 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1977 * ccl.c (Vccl_program_table): Now static.
1978 (check_ccl_update): Remove; unused.
1979
d85b608f
PE
1980 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1981 * category.h: ... from here.
1982 * category.c (check_category_table, set_category_set): Now static.
1983
31cd66f3
PE
1984 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1985 * lisp.h: Remove these decls.
1986
c358e587
PE
1987 * buffer.c (buffer_count): Remove unused var.
1988
e78aecca
PE
1989 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1990 so that it's not optimized away.
1991 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1992 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1993 exported only to the debugger.
1994
e192d7d3 1995 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1996 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1997
92470028
PE
1998 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1999 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2000 was inaccessible from Lisp.
2001 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2002 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2003
244ed907
PE
2004 alloc.c: Import and export fewer symbols, and remove unused items.
2005 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2006 is defined.
2007 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2008 it's not optimized away by whole-program optimization.
2009 (message_enable_multibyte, free_misc): Remove.
2010 (catchlist, handlerlist, mark_backtrace):
2011 Declare only if BYTE_MARK_STACK.
2012 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2013 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2014 (message_enable_multibyte): Remove decl.
2015 (free_misc, interval_free_list, float_block, float_block_index):
2016 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2017 (cons_free_list, last_marked_index):
2018 Now static.
2019 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2020 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2021 (mark_backtrace): Define only if BYTE_MARK_STACK.
2022 * xdisp.c (message_enable_multibyte): Now static.
2023
61c2b50e 2024 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2025 This makes it easier for human readers (and static analyzers)
2026 to see whether these variables are used from other modules.
2027 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2028 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2029 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2030 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2031 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2032 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2033 * xmenu.c, xselect.c:
2034 Declare Q* vars static if they are not used in other modules.
2035 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2036 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2037 Remove decls of unexported vars.
2038 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2039
95c82688
PE
2040 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2041
16a97296
PE
2042 Make Emacs functions such as Fatom 'static' by default.
2043 This makes it easier for human readers (and static analyzers)
2044 to see whether these functions can be called from other modules.
2045 DEFUN now defines a static function. To make the function external
2046 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2047 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2048 (Finit_image_library):
16a97296
PE
2049 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2050 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2051 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2052 Remove decls, since these functions are now static.
2053 (Funintern, Fget_internal_run_time): New decls, since these functions
2054 were already external.
95c82688 2055
16a97296
PE
2056 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2057 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2058 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2059 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2060 * keyboard.c, keymap.c, lread.c:
2061 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2062 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2063 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2064 Mark functions with DEFUE instead of DEFUN,
2065 if they are used in other modules.
2066 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2067 decls for now-static functions.
2068 * buffer.h (Fdelete_overlay): Remove decl.
2069 * callproc.c (Fgetenv_internal): Mark as internal.
2070 * composite.c (Fremove_list_of_text_properties): Remove decl.
2071 (Fcomposition_get_gstring): New forward static decl.
2072 * composite.h (Fcomposite_get_gstring): Remove decl.
2073 * dired.c (Ffile_attributes): New forward static decl.
2074 * doc.c (Fdocumntation_property): New forward static decl.
2075 * eval.c (Ffetch_bytecode): New forward static decl.
2076 (Funintern): Remove extern decl; now in .h file where it belongs.
2077 * fileio.c (Fmake_symbolic_link): New forward static decl.
2078 * image.c (Finit_image_library): New forward static decl.
2079 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2080 * intervals.h (Fprevious_property_change):
2081 (Fremove_list_of_text_properties): Remove decls.
2082 * keyboard.c (Fthis_command_keys): Remove decl.
2083 (Fcommand_execute): New forward static decl.
2084 * keymap.c (Flookup_key): New forward static decl.
2085 (Fcopy_keymap): Now static.
2086 * keymap.h (Flookup_key): Remove decl.
2087 * process.c (Fget_process): New forward static decl.
2088 (Fprocess_datagram_address): Mark as internal.
2089 * syntax.c (Fsyntax_table_p): New forward static decl.
2090 (skip_chars): Remove duplicate decl.
2091 * textprop.c (Fprevious_property_change): New forward static decl.
2092 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2093 Now internal.
2094 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2095 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2096
785bbd42
PE
2097 * editfns.c (Fformat): Remove unreachable code.
2098
8b913b57
AS
20992011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2100
2101 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2102 change. (Bug#8496)
2103
a6744a35
EZ
21042011-04-13 Eli Zaretskii <eliz@gnu.org>
2105
2106 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2107 when at ZV. (Bug#8487)
2108
e7974947
AS
21092011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2110
baad03f0
AS
2111 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2112 (Bug#8437)
2113 * keyboard.c (parse_tool_bar_item): Likewise.
2114 * sound.c (sound_cleanup, alsa_close): Likewise.
2115 * termcap.c (tgetent): Likewise.
2116 * xfns.c (x_default_font_parameter): Likewise.
2117 * xsettings.c (read_and_apply_settings): Likewise.
2118
e7974947
AS
2119 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2120 (overrun_check_free): Protoize.
2121
28272684
PE
21222011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2125 since callers should never pass a negative size.
2126 Change the signature to match that of plain 'read' and 'write'; see
2127 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2128 * lisp.h: Update prototypes of emacs_write and emacs_read.
2129
11997c76
EZ
21302011-04-11 Eli Zaretskii <eliz@gnu.org>
2131
2132 * xdisp.c (redisplay_window): Don't try to determine the character
2133 position of the scroll margin if the window start point w->startp
e896f03c 2134 is outside the buffer's accessible region. (Bug#8468)
11997c76 2135
8a2cbd72
EZ
21362011-04-10 Eli Zaretskii <eliz@gnu.org>
2137
2138 Fix write-region and its subroutines for buffers > 2GB.
2139 * fileio.c (a_write, e_write): Modify declaration of arguments and
2140 local variables to support buffers larger than 2GB.
2141 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2142
2143 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2144 argument, local variables, and return value.
2145
2146 * lisp.h: Update prototypes of emacs_write and emacs_read.
2147
2148 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2149
4073e537 21502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2151
1ebfdcb6
PE
2152 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2153
b2ded58d
PE
2154 Fix more problems found by GCC 4.6.0's static checks.
2155
7d66342c
PE
2156 * xdisp.c (vmessage): Use a better test for character truncation.
2157
bbf47d44
PE
2158 * charset.c (load_charset_map): <, not <=, for optimization,
2159 and to avoid potential problems with integer overflow.
9248994d 2160 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2161 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2162 * editfns.c (Fformat): Likewise.
1e69125e 2163 * syntax.c (skip_chars): Likewise.
3befa583 2164
e3019616
PE
2165 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2166 This also lets GCC 4.6.0 generate slightly better loop code.
2167
becfa255
PE
2168 * callint.c (Fcall_interactively): <, not <=, for optimization.
2169 (Fcall_interactively): Count the number of arguments produced,
2170 not the number of arguments given. This is simpler and lets GCC
2171 4.6.0 generate slightly better code.
2172
dae0cd48
PE
2173 * ftfont.c: Distingish more carefully between FcChar8 and char.
2174 The previous code passed unsigned char * to a functions like
2175 strlen and xstrcasecmp that expect char *, which does not
2176 conform to the C standard.
2177 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2178 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2179 char * when the C standard requires it.
2180
76032d70
PE
2181 * keyboard.c (read_char): Remove unused var.
2182
eb3f1cc8
PE
2183 * eval.c: Port to Windows vsnprintf (Bug#8435).
2184 Include <limits.h>.
2185 (SIZE_MAX): Define if the headers do not.
2186 (verror): Do not give up if vsnprintf returns a negative count.
2187 Instead, grow the buffer. This ports to Windows vsnprintf, which
2188 does not conform to C99. Problem reported by Eli Zaretskii.
2189 Also, simplify the allocation scheme, by avoiding the need for
2190 calling realloc, and removing the ALLOCATED variable.
2191
70476b54
PE
2192 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2193
12020a9e
PE
2194 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2195 But keep the doprint source code for now, as we might revamp it
2196 and use it again (Bug#8435).
ea6c7ae6
PE
2197 * lisp.h (doprnt): Remove.
2198 * Makefile.in (base_obj): Remove doprnt.o.
2199 * deps.mk (doprnt.o): Remove.
2200
5fdb398c
PE
2201 error: Print 32- and 64-bit integers portably (Bug#8435).
2202 Without this change, on typical 64-bit hosts error ("...%d...", N)
2203 was used to print both 32- and 64-bit integers N, which relied on
2204 undefined behavior.
2205 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2206 New macro.
2207 * lisp.h (error, verror): Mark as printf-like functions.
2208 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2209 Report overflow in size calculations when allocating printf buffer.
2210 Do not truncate output string at its first null byte.
2211 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2212 Truncate the output at a character boundary, since vsnprintf does not
2213 do that.
2214 * charset.c (check_iso_charset_parameter): Convert internal
2215 character to string before calling 'error', since %c now has the
2216 printf meaning.
2217 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2218 overflow when computing char to be passed to 'error'. Do not
2219 pass Lisp_Object to 'error'; pass the integer instead.
2220 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2221 formatted with plain %d.
2222
b189fa66
PE
2223 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2224
bff87ef0
PE
2225 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2226
7e2cac20
PE
2227 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2228
ce4d90b5
PE
2229 * xterm.c (x_catch_errors): Remove duplicate declaration.
2230
266c9547
PE
2231 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2232
79c49ad2
PE
2233 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2234
368f4090
JM
22352011-04-10 Jim Meyering <meyering@redhat.com>
2236
2237 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2238 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2239 return ssize_t not "int", and use size_t as the buffer length.
2240 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2241 * gnutls.h: Update declarations.
2242 * process.c (read_process_output): Use ssize_t, to match.
2243 (send_process): Likewise.
2244
a32d4040
CY
22452011-04-09 Chong Yidong <cyd@stupidchicken.com>
2246
2247 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2248
8546720e 22492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2250
04f2d78b
CB
2251 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2252 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2253
8546720e
GM
2254 * xterm.c (handle_one_xevent):
2255 * xmenu.c (create_and_show_popup_menu):
2256 * xselect.c (x_decline_selection_request)
2257 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2258
0a2f5c1a 22592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2260
2261 Fix some uses of `int' instead of EMACS_INT.
2262 * search.c (string_match_1, fast_string_match)
2263 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2264 (scan_buffer, find_next_newline_no_quit)
2265 (find_before_next_newline, search_command, Freplace_match)
2266 (Fmatch_data): Make some `int' variables be EMACS_INT.
2267
2268 * xdisp.c (display_count_lines): 3rd argument and return value now
2269 EMACS_INT. All callers changed.
2270 (pint2hrstr): Last argument is now EMACS_INT.
2271
2272 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2273 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2274 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2275 (decode_coding_utf_16, decode_coding_emacs_mule)
2276 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2277 (decode_coding_ccl, decode_coding_charset)
2278 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2279 (decode_coding_iso_2022, decode_coding_emacs_mule)
2280 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2281 <char_offset, last_offset>: Declare EMACS_INT.
2282 (encode_coding_utf_8, encode_coding_utf_16)
2283 (encode_coding_emacs_mule, encode_invocation_designation)
2284 (encode_designation_at_bol, encode_coding_iso_2022)
2285 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2286 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2287 Declare EMACS_INT.
2288 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2289 (encode_invocation_designation): Last argument P_NCHARS is now
2290 EMACS_INT.
2291 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2292 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2293
2294 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2295 All users changed.
2296
2297 * ccl.c (Fccl_execute_on_string): Declare some variables
2298 EMACS_INT.
2299
8546720e 23002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2301
2302 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2303
4e19a977
CS
23042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2305
2306 * process.c (Fformat_network_address): Doc fix.
2307
87302331
R
23082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2309
2310 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2311
cbb59342
CY
23122011-04-08 Chong Yidong <cyd@stupidchicken.com>
2313
2314 * keyboard.c (read_char): Call Lisp function help-form-show,
2315 instead of using internal_with_output_to_temp_buffer.
2316 (Qhelp_form_show): New var.
e0d38eeb 2317 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2318
2319 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2320
2321 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2322
e67a13ab
CY
23232011-04-06 Chong Yidong <cyd@stupidchicken.com>
2324
04f2d78b
CB
2325 * process.c (Flist_processes): Remove to Lisp.
2326 (list_processes_1): Delete.
e67a13ab 2327
973f782d
EZ
23282011-04-06 Eli Zaretskii <eliz@gnu.org>
2329
7c106b1e
EZ
2330 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2331
973f782d
EZ
2332 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2333
41cf7d1a 23342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2335
ca23cc88
PE
2336 Fix more problems found by GCC 4.6.0's static checks.
2337
f390e2d5
PE
2338 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2339
42eea0d0
PE
2340 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2341
b69769da 2342 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2343
f9541e84
PE
2344 * xdisp.c (vmessage): Mark as a printf-like function.
2345
13841b55
PE
2346 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2347
c136c10f
PE
2348 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2349
5e2d4a30
PE
2350 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2351 printf-like functions.
2352 (tiff_load): Add casts to remove these marks before passing them
2353 to system-supplied API.
2354
583f48b9
PE
2355 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2356
b25d760e
PE
2357 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2358 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2359 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2360 directly, rather than having caller test rule sign. This avoids
2361 some unnecessary tests.
2362 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2363 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2364 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2365
bc7b6697 2366 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2367 (xfont_open): Avoid unnecessary tests.
bc7b6697 2368
27ccc379
PE
2369 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2370
dcd5c89a
PE
2371 * composite.h, composite.c (composition_gstring_put_cache):
2372 Use EMACS_INT, not int, for length.
2373
b13a45c6
PE
2374 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2375 breaking out part of COMPOSITION_DECODE_RULE.
2376 (COMPOSITION_DECODE_RULE): Use it.
2377 * composite.c (get_composition_id): Remove unused local vars,
2378 by using the new macro.
2379
1e792e4d
PE
2380 * textprop.c (set_text_properties_1): Change while to do-while,
2381 since the condition is always true at first.
2382
dc6c6455 2383 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2384 (interval_deletion_adjustment): Return unsigned value.
2385 All uses changed.
dc6c6455 2386
aba7731a
PE
2387 * process.c (list_processes_1, create_pty, read_process_output):
2388 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2389 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2390 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2391 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2392 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2393
fdfc4bf3
PE
2394 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2395
fca8fe46 2396 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2397 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2398
06a0259a 2399 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2400 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2401 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2402
e7b9e80f
PE
2403 * print.c (print_error_message): Avoid int overflow.
2404
56201685
PE
2405 * font.c (font_list_entities): Redo for clarity,
2406 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2407
78834453 2408 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2409 (font_score): Avoid potential overflow in diff calculation.
78834453 2410
0bc0b309 2411 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2412 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2413
e610eaca
PE
2414 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2415
b895abce
PE
2416 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2417 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2418 can always succeed if overflow has undefined behavior.
2419
1f1d9321 2420 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2421 (wordify): Omit three unnecessary tests.
1f1d9321 2422
c59478bc
PE
2423 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2424 All callers changed. This avoids the need for an unused var.
2425
79b73827
PE
2426 * casefiddle.c (casify_region): Remove var that is set but not used.
2427
a4db5dfe
PE
2428 * dired.c (file_name_completion): Remove var that is set but not used.
2429
43aae36e
PE
2430 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2431
2a47c44d 2432 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2433 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2434
a37c69bf
PE
2435 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2436 Check for integer overflow on size calculations.
2437
328ab8e7
PE
2438 * buffer.c (Fprevious_overlay_change): Remove var that is set
2439 but not used.
2440
e5a2a5cb
PE
2441 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2442 Remove vars that are set but not used.
8d84a6eb 2443 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2444 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2445
a60e5f68
PE
2446 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2447
f661cb61 2448 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2449 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2450
f0397f5a
PE
2451 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2452 that are set but not used.
2453
8664db06 2454 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2455 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2456
6abdaa4a
PE
2457 * xselect.c (x_get_local_selection, x_handle_property_notify):
2458 Remove vars that are set but not used.
2459
0ce7538d 2460 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2461 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2462
9ae848fc
PE
2463 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2464 Remove var that is set but not used.
0b918413
PE
2465 (scroll_bar_windows_size): Now size_t, not int.
2466 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2467 Check for overflow.
9ae848fc 2468
a5a62657
PE
2469 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2470 (map_tty_color) [!defined MSDOS]: Likewise.
2471
5c5cdd39
PE
2472 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2473
66ebf983
PE
2474 * coding.c: Remove vars that are set but not used.
2475 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2476 All callers changed.
2477 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2478 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2479 (decode_coding_charset): Remove vars that are set but not used.
2480
1be4d761
PE
2481 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2482 that is set but not used.
2483
47553fa8
PE
2484 * print.c (print_object): Remove var that is set but not used.
2485
1f7196bf 2486 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2487 The gnulib version avoids calling malloc in the usual case,
2488 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2489 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2490 * filelock.c (current_lock_owner): Likewise.
2491 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2492 * sysdep.c: Include allocator.h, careadlinkat.h.
2493 (emacs_no_realloc_allocator): New static constant.
2494 (emacs_readlink): New function.
fdb61804
PE
2495 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2496 ../lib/careadlinkat.h.
d1fdcab7 2497
f84c17c7
SM
24982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2499
2500 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2501 first non-nil return value).
2502
ef3862ad
JD
25032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2504
2505 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2506 if not defined (Bug#8403).
2507
376a7006
JB
25082011-04-02 Juanma Barranquero <lekktu@gmail.com>
2509
2510 * xdisp.c (display_count_lines): Remove parameter `start',
2511 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2512 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2513 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2514 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2515 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2516 and thereabouts. All callers changed.
2517 (get_per_char_metric): Remove parameter `f', unused since
2518 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2519
6ca3801d
JM
25202011-04-02 Jim Meyering <meyering@redhat.com>
2521
2522 do not dereference NULL upon failed strdup
2523 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2524 (ns_get_family): Likewise.
2525
d8e2b5ba
JB
25262011-04-02 Juanma Barranquero <lekktu@gmail.com>
2527
2528 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2529
8c74fcbd
JD
25302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2531
2532 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2533 later (Bug#8403).
2534
7200d79c
SM
25352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2536
03408648 2537 Add lexical binding.
7200d79c 2538
03408648
SM
2539 * window.c (Ftemp_output_buffer_show): New fun.
2540 (Fsave_window_excursion):
2541 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2542
2543 * lread.c (lisp_file_lexically_bound_p): New function.
2544 (Fload): Bind Qlexical_binding.
2545 (readevalloop): Remove `evalfun' arg.
2546 Bind Qinternal_interpreter_environment.
2547 (Feval_buffer): Bind Qlexical_binding.
2548 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2549 Mark as dynamic.
2550 (syms_of_lread): Declare `lexical-binding'.
2551
2552 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2553
2554 * keyboard.c (eval_dyn): New fun.
2555 (menu_item_eval_property): Use it.
ca105506
SM
2556
2557 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2558
03408648
SM
2559 * fns.c (concat, mapcar1): Accept byte-code-functions.
2560
2561 * eval.c (Fsetq): Handle lexical vars.
2562 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2563 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2564 (FletX, Flet): Obey lexical binding.
2565 (Fcommandp): Handle closures.
2566 (Feval): New `lexical' arg.
2567 (eval_sub): New function extracted from Feval. Use it almost
2568 everywhere where Feval was used. Look up vars in lexical env.
2569 Handle closures.
2570 (Ffunctionp): Move from subr.el.
2571 (Ffuncall): Handle closures.
2572 (apply_lambda): Remove `eval_flags'.
2573 (funcall_lambda): Handle closures and new byte-code-functions.
2574 (Fspecial_variable_p): New function.
2575 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2576 but without exporting it to Lisp.
23aba0ea 2577
23aba0ea 2578 * doc.c (Fdocumentation, store_function_docstring):
03408648 2579 * data.c (Finteractive_form): Handle closures.
23aba0ea 2580
03408648
SM
2581 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2582 interactive spec.
ba83908c 2583
04f2d78b
CB
2584 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2585 New byte-codes.
03408648
SM
2586 (exec_byte_code): New function extracted from Fbyte_code to handle new
2587 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2588
03408648 2589 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2590
03408648 2591 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2592
e2abce01
JB
25932011-03-31 Juanma Barranquero <lekktu@gmail.com>
2594
2595 * xdisp.c (redisplay_internal): Fix prototype.
2596
63696a73 25972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2598
63696a73 2599 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2600 (try_scrolling): Use it when setting scroll_limit.
2601 Limit scrolling to 100 screen lines.
63696a73
EZ
2602 (redisplay_window): Even when falling back on "recentering",
2603 position point in the window according to scroll-conservatively,
2604 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2605
2606 (try_scrolling): When point is above the window, allow searching
2607 as far as scroll_max, or one screenful, to compute vertical
2608 distance from PT to the scroll margin position. This prevents
2609 try_scrolling from unnecessarily failing when
2610 scroll-conservatively is set to a value slightly larger than the
2611 window height. Clean up the case of PT below the margin at bottom
2612 of window: scroll_max can no longer be INT_MAX. When aggressive
2613 scrolling is in use, don't let point enter the opposite scroll
2614 margin as result of the scroll.
2615 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2616 threshold of 100 lines for never-recentering scrolling.
2617
e4cc2dfc
JB
26182011-03-31 Juanma Barranquero <lekktu@gmail.com>
2619
2620 * dispextern.h (move_it_by_lines):
2621 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2622 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2623 (message_log_check_duplicate): Remove parameters `prev_bol' and
2624 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2625 (redisplay_internal): Remove parameter `preserve_echo_area',
2626 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2627
2628 * indent.c (Fvertical_motion):
2629 * window.c (window_scroll_pixel_based, Frecenter):
2630 Don't pass `need_y_p' to `move_it_by_lines'.
2631
1c470562
SM
26322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2633
44f230aa
SM
2634 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2635 steal a few bits to be more compact.
2636 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2637 Remove unneeded casts.
2638
1c470562
SM
2639 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2640
888adce9
ZK
26412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2642
2643 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2644 binding" message (bug#7967).
2645
f838ed7b
PE
26462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2647
77861b95
PE
2648 Fix more problems found by GCC 4.6.0's static checks.
2649
de6dbc14
PE
2650 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2651 Remove unused local var.
2652
f838ed7b
PE
2653 * editfns.c (Fmessage_box): Remove unused local var.
2654
792c7b2b
PE
2655 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2656 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2657 Omit unused local vars.
c499e557 2658 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2659 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2660 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2661 Omit unused local var.
2662
ba0165e1
PE
2663 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2664 Don't assume string length fits in int.
32ad8845 2665 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2666 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2667
3c59b4c9
PE
2668 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2669 instead of alloca (Bug#8344).
2670
a3eed478 2671 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2672 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2673
eb4d412d
PE
2674 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2675
1658b401
PE
2676 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2677 concerns.
2678
2679 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2680
2681 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2682
9a2c6e05
PE
2683 * keyboard.c (syms_of_keyboard): Use the same style as later
2684 in this function when indexing through an array. This also
2685 works around GCC bug 48267.
2686
03d0a109
PE
2687 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2688
44f730c8
PE
2689 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2690
fe75f926
PE
2691 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2692 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2693
ffa8c828
PE
2694 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2695 This avoids undefined behavior on integer overflow, and is a bit
2696 more convenient anyway since it is compared to a size_t variable.
2697
c5101a77
PE
2698 Variadic C functions now count arguments with size_t, not int.
2699 This avoids an unnecessary limitation on 64-bit machines, which
2700 caused (substring ...) to crash on large vectors (Bug#8344).
2701 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2702 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2703 All variadic functions and their callers changed accordingly.
c5101a77
PE
2704 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2705 * data.c (arith_driver, float_arith_driver): Likewise.
2706 * editfns.c (general_insert_function): Likewise.
2707 * eval.c (struct backtrace.nargs, interactive_p)
2708 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2709 (funcall_lambda, mark_backtrace): Likewise.
2710 * fns.c (concat): Likewise.
2711 * frame.c (x_set_frame_parameters): Likewise.
2712 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2713 0 if not found, not -1. All callers changed.
2714
dd3f25f7
PE
2715 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2716 (stack_copy_size): Now size_t, not int.
2717 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2718
461c2ab9
JB
27192011-03-28 Juanma Barranquero <lekktu@gmail.com>
2720
2721 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2722 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2723 All callers changed.
2724
2725 * lisp.h (multibyte_char_to_unibyte):
2726 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2727 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2728 * character.h (CHAR_TO_BYTE8):
2729 * cmds.c (internal_self_insert):
2730 * editfns.c (general_insert_function):
2731 * keymap.c (push_key_description):
2732 * search.c (Freplace_match):
2733 * xdisp.c (message_dolog, set_message_1): All callers changed.
2734
f6d62986
SM
27352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2736
2737 * keyboard.c (safe_run_hook_funcall): New function.
2738 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2739 don't set the hook to nil, but remove the offending function instead.
2740 (Qcommand_hook_internal): Remove, unused.
2741 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2742 Vcommand_hook_internal.
2743
2744 * eval.c (enum run_hooks_condition): Remove.
2745 (funcall_nil, funcall_not): New functions.
2746 (run_hook_with_args): Call each function through a `funcall' argument.
2747 Remove `cond' argument, now redundant.
2748 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2749 (Frun_hook_with_args_until_failure): Adjust accordingly.
2750 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2751
1db5b1ad
JB
27522011-03-28 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * dispextern.h (string_buffer_position): Remove declaration.
2755
2756 * print.c (strout): Remove parameter `multibyte', unused since
2757 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2758
2759 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2760 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2761 All callers changed.
2762
2763 * w32.c (_wsa_errlist): Use braces for struct initializers.
2764
2765 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2766 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2767 All callers changed.
2768 (string_buffer_position): Likewise. Also, make static (it's never
2769 used outside xdisp.c).
2770 (cursor_row_p): Remove parameter `w', unused since
2771 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2772 (decode_mode_spec): Remove parameter `precision', introduced during
2773 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2774 All callers changed.
2775
5ffb62aa
JD
27762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2777
2778 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2779
461c2ab9 27802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2781
2782 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2783 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2784 (ns_update_auto_hide_menu_bar): New functions.
2785 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2786 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2787 ns_constrain_all_frames.
2788 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2789 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2790
5c380ffb
JD
27912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2792
2793 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2794
9af30bdf
GM
27952011-03-27 Glenn Morris <rgm@gnu.org>
2796
2797 * syssignal.h: Replace RETSIGTYPE with void.
2798 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2799 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2800 Replace SIGTYPE with void everywhere.
2801 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2802 * s/template.h (SIGTYPE): Remove commented out definition.
2803
e2abce01
JB
28042011-03-26 Eli Zaretskii <eliz@gnu.org>
2805
2806 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2807 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2808
f868cd8a
JB
28092011-03-26 Juanma Barranquero <lekktu@gmail.com>
2810
59eb0929
JB
2811 * w32.c (read_unc_volume): Use parameter `henum', instead of
2812 global variable `wget_enum_handle'.
2813
2814 * keymap.c (describe_vector): Remove parameters `indices' and
2815 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2816 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2817
f868cd8a
JB
2818 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2819
2820 * keyboard.c (timer_check): Remove parameter `do_it_now',
2821 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2822 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2823 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2824
2825 * keyboard.c (read_char):
2826 * w32menu.c (w32_menu_display_help):
2827 * xmenu.c (show_help_event, menu_help_callback):
2828 Adjust calls to `show_help_echo'.
2829
2830 * gtkutil.c (xg_maybe_add_timer):
2831 * keyboard.c (readable_events):
2832 * process.c (wait_reading_process_output):
2833 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2834
2835 * insdel.c (adjust_markers_gap_motion):
2836 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2837 (gap_left, gap_right): Don't call it.
2838
2ecf6fdb
CY
28392011-03-25 Chong Yidong <cyd@stupidchicken.com>
2840
2841 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2842 incurred during fontification.
2843
6b1f9ba4
JB
28442011-03-25 Juanma Barranquero <lekktu@gmail.com>
2845
2846 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2847 (DEFVAR_PER_BUFFER): Don't pass it.
2848
2849 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2850 (scrolling_window): Don't pass it.
2851
0f4a96b5
JB
28522011-03-25 Juanma Barranquero <lekktu@gmail.com>
2853
2854 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2855
2856 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2857 and `suffix'.
2858 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2859 of variables specific to SELinux and computation of `encoded_absname'.
2860
2861 * image.c (XPutPixel): Remove unused variable `height'.
2862
2863 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2864
2865 * unexw32.c (get_section_info): Remove unused variable `section'.
2866
2867 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2868 (system_process_attributes): Remove unused variable `sess'.
2869 (sys_read): Remove unused variable `err'.
2870
2871 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2872 (w32_wnd_proc): Remove unused variable `isdead'.
2873 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2874 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2875 (x_create_tip_frame): Remove unused variable `tem'.
2876
2877 * w32inevt.c (w32_console_read_socket):
2878 Remove unused variable `no_events'.
2879
2880 * w32term.c (x_draw_composite_glyph_string_foreground):
2881 Remove unused variable `width'.
2882
1149507c
JB
28832011-03-24 Juanma Barranquero <lekktu@gmail.com>
2884
2885 * w32term.c (x_set_glyph_string_clipping):
2886 Don't pass uninitialized region to CombineRgn.
2887
9c88f339
JB
28882011-03-23 Juanma Barranquero <lekktu@gmail.com>
2889
2890 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2891 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2892 (Fx_close_connection): Remove unused variable `i'.
2893
2894 * w32font.c (w32font_draw): Return number of glyphs.
2895 (w32font_open_internal): Remove unused variable `i'.
2896 (w32font_driver): Add missing initializer.
2897
2898 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2899 (fill_in_menu): Remove unused variable `items_added'.
2900
2901 * w32term.c (last_mouse_press_frame): Remove static global variable.
2902 (w32_clip_to_row): Remove unused variable `f'.
2903 (x_delete_terminal): Remove unused variable `i'.
2904
2905 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2906 (NOTHING): Remove unused static global variable.
2907 (uniscribe_check_otf): Remove unused variable `table'.
2908 (uniscribe_font_driver): Add missing initializers.
2909
dee091a3
JD
29102011-03-23 Julien Danjou <julien@danjou.info>
2911
2912 * term.c (Fsuspend_tty, Fresume_tty):
2913 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2914 * window.c (temp_output_buffer_show):
2915 * insdel.c (signal_before_change):
2916 * frame.c (Fhandle_switch_frame):
2917 * fileio.c (Fdo_auto_save):
2918 * emacs.c (Fkill_emacs):
2919 * editfns.c (save_excursion_restore):
2920 * cmds.c (internal_self_insert):
2921 * callint.c (Fcall_interactively):
2922 * buffer.c (Fkill_all_local_variables):
2923 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2924 Use Frun_hooks.
0f4a96b5 2925 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2926 unconditionnaly since it does the check itself.
2927
2c520ab5 29282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2929
c9c49752
PE
2930 Fix more problems found by GCC 4.5.2's static checks.
2931
8abc3f12
PE
2932 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2933 the first time through the loop, since we know p0 < p1 then.
2934 This also avoids a gcc -Wstrict-overflow warning.
2935
a2d26660
PE
2936 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2937 leading to a memory leak, possible in functions like
2938 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2939 of objects (Bug#8318).
a2d26660 2940
916c72e9
PE
2941 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2942 that could (at least in theory) be that large.
2943
19ab8a18
PE
2944 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2945 This is less likely to overflow, and avoids undefined behavior if
2946 overflow does occur. All callers changed. Use strtoul to scan
2947 for the unsigned long integer.
b7cbbd6f
PE
2948 (pint2hrstr): Simplify and tune code slightly.
2949 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2950
f0641eff
PE
2951 * scroll.c (do_scrolling): Work around GCC bug 48228.
2952 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2953
7f650bb9
PE
2954 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2955 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2956 (validate_x_resource_name): Simplify count usage.
2957 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2958
37dd57d1
PE
2959 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2960 fail (Bug#8306).
81e56e61 2961
699979fc 2962 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2963
401bf9b4
PE
2964 * process.c (Fmake_network_process): Use socklen_t, not int,
2965 where POSIX says socklen_t is required in portable programs.
2966 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2967 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2968 (Fmake_network_process, server_accept_connection):
2969 (wait_reading_process_output, read_process_output):
2970 Likewise.
2971
b93aacde
PE
2972 * process.c: Rename or move locals to avoid shadowing.
2973 (list_processes_1, Fmake_network_process):
2974 (read_process_output_error_handler, exec_sentinel_error_handler):
2975 Rename or move locals.
4dc343ee 2976 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2977 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2978 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2979 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2980 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2981
af8a867c 2982 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2983 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2984 Include tparam.h instead, since it declares them.
af8a867c
PE
2985 * cm.h (PC): Remove extern decl; tparam.h now does this.
2986 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2987 * terminfo.c: Include tparam.h, to check interfaces.
2988 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2989 (tparam): Adjust signature to match interface in tparam.h;
2990 this removes some undefined behavior. Check that outstring and len
2991 are zero, which they always are with Emacs.
2992 * tparam.h (PC, BC, UP): New extern decls.
2993
0248044d 2994 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2995 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2996
8ff096c1 2997 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2998 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2999 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3000 (ftfont_list): Remove unused local.
49eaafba
PE
3001 (get_adstyle_property, ftfont_pattern_entity):
3002 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3003 Rename locals to avoid shadowing.
8ff096c1 3004
e2be39f6
PE
3005 * xfont.c (xfont_list_family): Mark var as initialized.
3006
c9735e30
PE
3007 * xml.c (make_dom): Now static.
3008
8f5201ae
PE
3009 * composite.c (composition_compute_stop_pos): Rename local to
3010 avoid shadowing.
b246f932
PE
3011 (composition_reseat_it): Remove unused locals.
3012 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3013 (composition_update_it): Mark var as initialized.
11b61122
PE
3014 (find_automatic_composition): Mark vars as initialized,
3015 with a FIXME (Bug#8290).
8f5201ae 3016
760fbc2c
PE
3017 character.h: Rename locals to avoid shadowing.
3018 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3019 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3020 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3021 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3022 to avoid shadowing.
3023
ff08eb85
PE
3024 * textprop.c (property_change_between_p): Remove; unused.
3025
fc7bf025
PE
3026 * intervals.c (interval_start_pos): Now static.
3027
235d7abc
PE
3028 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3029
44f230aa
SM
3030 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3031 Rename locals to avoid shadowing.
3e7d6594 3032
50060332
PE
3033 * sound.c (wav_play, au_play, Fplay_sound_internal):
3034 Fix pointer signedness.
d01f234b 3035 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3036 (wav_play): Initialize a variable to 0, to prevent undefined
3037 behavior (Bug#8278).
50060332 3038
c4fc4e30
PE
3039 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3040
918436ed
PE
3041 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3042
c939f91b
PE
3043 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3044 clobbering (Bug#8298).
b9c7f648
PE
3045 * sysdep.c (sys_subshell): Likewise.
3046 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3047
6bd8c144
PE
3048 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3049 This should get cleaned up, so that child_setup has the
3050 same signature on all platforms.
3051
7710357c 3052 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3053 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3054
c59da222
CY
30552011-03-22 Chong Yidong <cyd@stupidchicken.com>
3056
3057 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3058 not to be necessary, and produces flickering.
3059
66b87493
GM
30602011-03-20 Glenn Morris <rgm@gnu.org>
3061
3062 * config.in: Remove file.
3063
45b6f6d5
JB
30642011-03-20 Juanma Barranquero <lekktu@gmail.com>
3065
3066 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3067 are now in src/globals.h.
3068 (syms_of_minibuf): Remove spurious & from previous change.
3069
3ec03f7e
LL
30702011-03-20 Leo <sdl.web@gmail.com>
3071
3072 * minibuf.c (completing-read-function): New variable.
3073 (completing-read-default): Rename from completing-read.
3074 (completing-read): Call completing-read-function.
3075
b14e3e21
CY
30762011-03-19 Juanma Barranquero <lekktu@gmail.com>
3077
3078 * xfaces.c (Fx_load_color_file):
3079 Read color file from absolute filename (bug#8250).
3080
f2b726e6
JB
30812011-03-19 Juanma Barranquero <lekktu@gmail.com>
3082
3083 * makefile.w32-in: Update dependencies.
3084
09f6ff02
EZ
30852011-03-17 Eli Zaretskii <eliz@gnu.org>
3086
3087 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3088
29a6015a
PE
30892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3090
a3a6c54e
PE
3091 Fix more problems found by GCC 4.5.2's static checks.
3092
b766f867
PE
3093 * process.c (make_serial_process_unwind, send_process_trap):
3094 (sigchld_handler): Now static.
3095
be02381c
PE
3096 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3097 That way, the code declares only the vars that it needs.
3098 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3099 * s/cygwin.h (PTY_ITERATION): Likewise.
3100 * s/darwin.h (PTY_ITERATION): Likewise.
3101 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3102
57048744
PE
3103 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3104 * process.c (allocate_pty): Don't declare stb unless it's needed.
3105
7914961c 3106 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3107 (CONSTANTLIM): Remove; unused.
3108 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3109 Define only if needed.
7914961c 3110
b3967b18
PE
3111 * unexelf.c (unexec): Name an expression,
3112 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3113 Use a different way to cause a compilation error if anyone uses
3114 n rather than nn, a way that does not involve shadowing.
73366a00 3115 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3116
29a6015a
PE
3117 * deps.mk (unexalpha.o): Remove; unused.
3118
43cfc33e 3119 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3120 * unexec.h: New file.
ce701a33
PE
3121 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3122 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3123 Depend on unexec.h.
3124 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3125 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3126 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3127 Change as necessary to match prototype in unexec.h.
ce701a33 3128
01f44d5a
PE
3129 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3130 shadowing.
4f63c6bb 3131 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3132
a6670b0b
PE
3133 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3134 Rename locals to avoid shadowing.
3135
cef2010d 3136 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3137 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3138
d4d7173a
PE
3139 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3140
f08b802a
PE
3141 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3142 warning when compiling print.c.
3143
3ddb0639
PE
3144 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3145 instead of using an uninitialized var.
5ad03b97 3146 (font_sort_entities): Mark var as initialized.
3ddb0639 3147
170a2692
PE
3148 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3149
e663c700
PE
3150 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3151 pointers to constants.
89bc529a 3152 (font_parse_fcname): Remove unused vars.
7b81e2d0 3153 (font_delete_unmatched): Now static.
ea838e10 3154 (font_get_spec): Remove; unused.
13a547c6
PE
3155 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3156 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3157 Rename or move locals to avoid shadowing.
e663c700 3158
2a80c887 3159 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3160 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3161
1384fa33 3162 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3163 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3164
8b2c52e9
PE
3165 * alloc.c (mark_backtrace): Move decl from here ...
3166 * lisp.h: ... to here, so that it can be checked.
3167
475545b5 3168 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3169 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3170 (lisp_indirect_variable): Name an expression,
3171 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3172 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3173
b1349114 3174 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3175 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3176 Use const pointer when appropriate.
b1349114 3177
a2928364
PE
3178 * lisp.h (get_system_name, get_operating_system_release):
3179 Move decls here, to check interfaces.
3180 * process.c (get_operating_system_release): Move decl to lisp.h.
3181 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3182 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3183 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3184 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3185 (Fformat_time_string, Fencode_time, Finsert_char):
3186 (Ftranslate_region_internal, Fformat):
3187 Rename or remove local vars to avoid shadowing.
9710023e 3188 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3189
a415e694
PE
3190 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3191 avoid shadowing.
3192
8ef4622d
PE
3193 * lisp.h (eassert): Check that the argument compiles, even if
3194 ENABLE_CHECKING is not defined.
3195
946f9a5b
PE
3196 * data.c (Findirect_variable): Name an expression, to avoid
3197 gcc -Wbad-function-cast warning.
112396d6 3198 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3199 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3200 (Fmake_variable_buffer_local, Fmake_local_variable):
3201 Mark variables as initialized.
52746918 3202 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3203
e5aab7e7 3204 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3205 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3206 Rename locals to avoid shadowing.
dff45157
PE
3207 (mark_stack): Move local variables into the #ifdef region where
3208 they're used.
7bc26fdb
PE
3209 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3210 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3211 needed otherwise.
3212 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3213 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3214 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3215
e5aab7e7
PE
3216 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3217 avoids undefined behavior in theory.
3218
4da60324
PE
3219 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3220
88043301
PE
3221 Use functions, not macros, for up- and down-casing (Bug#8254).
3222 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3223 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3224 to use the following functions instead of these macros.
3225 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3226 EMACS_INT, since callers assume the returned value fits in int.
3227 (upcase1): Likewise, for UPCASE_TABLE.
3228 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3229 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3230 the race-condition problem in the old DOWNCASE.
88043301 3231
19ed5445
PE
3232 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3233 Rename locals to avoid shadowing.
3234 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3235 (regex_compile, re_search_2, re_match_2_internal):
3236 Remove unused local vars.
952db0d7
PE
3237 (FREE_VAR): Rewrite so as not to use empty "else",
3238 which gcc can warn about.
da053e48 3239 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3240 (RETALLOC_IF): Define only if needed.
3241 (WORDCHAR_P): Likewise. This one is never needed, but is used
3242 only in a comment talking about a compiler bug, so put inside
3243 the #if 0 of that comment.
3244 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3245 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3246 Remove; unused.
19ed5445 3247
1f3561e4 3248 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3249 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3250 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3251
ded6f8f7
PE
3252 * search.c (simple_search): Remove unused var.
3253
dbd37a95
PE
3254 * dired.c (compile_pattern): Move decl from here ...
3255 * lisp.h: ... to here, so that it can be checked.
3256 (struct re_registers): New forward decl.
3257
7e47afad
PE
3258 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3259
85f24f61
PE
3260 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3261 All uses changed.
3262 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3263 Rename locals to avoid shadowing.
5671df8f 3264 (Fvertical_motion): Mark locals as initialized.
85f24f61 3265
181aa2be 3266 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3267 (casify_region): Mark local as initialized.
181aa2be 3268
930d429c
PE
3269 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3270
7082eac6
PE
3271 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3272 New macros, so that the caller can use some names other than
3273 gcpro1, gcpro2, etc.
3274 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3275 of the new macros.
3276 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3277 argument, for consistency with GCPRO2_VAR, etc: it is now the
3278 prefix of the variable, not the variable itself. All uses
3279 changed.
38b2c076
PE
3280 * dired.c (directory_files_internal, file_name_completion):
3281 Rename locals to avoid shadowing.
3282
15206ed9
PE
3283 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3284 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3285 dired.c's scmp function, had undefined behavior.
3286 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3287 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3288 * buffer.h: ... to here, because these macros use current_buffer,
3289 and the new implementation with inline functions needs to have
3290 current_buffer in scope now, rather than later when the macros
3291 are used.
3292 (downcase, upcase1): New static inline functions.
3293 (DOWNCASE, UPCASE1): Reimplement using these functions.
3294 This avoids undefined behavior in expressions like
3295 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3296 from race conditions in accessing the global variables
3297 case_temp1 and case_temp2.
3298 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3299 * lisp.h (case_temp1, case_temp2): Remove their decls.
3300 * character.h (ASCII_CHAR_P): Move from here ...
3301 * lisp.h: ... to here, so that the inline functions mentioned
3302 above can use them.
3303
4a6bea26
PE
3304 * dired.c (directory_files_internal_unwind): Now static.
3305
f14b7e14
PE
3306 * fileio.c (file_name_as_directory, directory_file_name):
3307 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3308 Now static.
2893f146
PE
3309 (file_name_as_directory): Use const pointers when appropriate.
3310 (Fexpand_file_name): Likewise. In particular, newdir might
3311 point at constant storage, so make it a const pointer.
fd4ead52 3312 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3313 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3314 signedness issues.
f839df0c
PE
3315 (Fset_file_times, Finsert_file_contents, auto_save_error):
3316 Rename locals to avoid shadowing.
f14b7e14 3317
5716756e 3318 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3319 (Ftry_completion, Fall_completions): Rename or remove locals
3320 to avoid shadowing.
5716756e 3321
b4c3046a
PE
3322 * marker.c (bytepos_to_charpos): Remove; unused.
3323
b45db522
PE
3324 * lisp.h (verify_bytepos, count_markers): New decls,
3325 so that gcc does not warn that these functions aren't declared.
3326
85876d07
PE
3327 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3328 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3329 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3330 (copy_text): Remove unused local var.
85876d07 3331
03d78a21 3332 * filelock.c (within_one_second): Now static.
b3dd38ab 3333 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3334
5df8f01b
PE
3335 * buffer.c (fix_overlays_before): Mark locals as initialized.
3336 (fix_start_end_in_overlays): Likewise. This function should be
3337 simplified by using pointers-to-pointers, but that's a different
3338 matter.
b1d876f1 3339 (switch_to_buffer_1): Now static.
8f54f30a
PE
3340 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3341 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3342
a70072c9 3343 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3344 Fix pointer signedness issue.
edced198
PE
3345 (sys_subshell): Mark local as volatile if checking for lint,
3346 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3347 (MAXPATHLEN): Define only if needed.
a70072c9 3348
a0977c44
PE
3349 * process.c (serial_open, serial_configure): Move decls from here ...
3350 * systty.h: ... to here, so that they can be checked.
3351
a884fdcc
PE
3352 * fns.c (get_random, seed_random): Move extern decls from here ...
3353 * lisp.h: ... to here, so that they can be checked.
3354
604efe86 3355 * sysdep.c (reset_io): Now static.
b8950c94 3356 (wait_for_termination_signal): Remove; unused.
604efe86 3357
38fc62d9
PE
3358 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3359 (copy_keymap_item, append_key, push_text_char_description):
3360 Now static.
1004a21a 3361 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3362 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3363 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3364 (describe_map_tree):
3365 Rename locals to avoid shadowing.
38fc62d9 3366
2f2650da
PE
3367 * keyboard.c: Declare functions static if they are not used elsewhere.
3368 (echo_char, echo_dash, cmd_error, top_level_2):
3369 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3370 (read_char, kbd_buffer_get_event, make_lispy_position):
3371 (make_lispy_event, make_lispy_movement, apply_modifiers):
3372 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3373 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3374 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3375 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3376 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3377
a053e86c 3378 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3379 (mark_kboards): Move decl here ...
3380 * alloc.c (mark_kboards): ... from here.
a053e86c 3381
4752793e
PE
3382 * lisp.h (force_auto_save_soon): New decl.
3383
74f10ca7 3384 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3385 (DEFINE_DUMMY_FUNCTION): New macro.
3386 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3387 Use it.
c03cd23f
PE
3388 (main): Add casts to avoid warnings
3389 if GCC considers string literals to be constants.
74f10ca7 3390
022e70d4
PE
3391 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3392
59d6fe83
PE
3393 * dbusbind.c: Pointer signedness fixes.
3394 (xd_signature, xd_append_arg, xd_initialize):
3395 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3396 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3397 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3398 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3399
78320123
PE
3400 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3401 if GCC considers string literals to be constants.
49cebcca 3402 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3403
35ac2a97
SM
34042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3405
fb103ca9
SM
3406 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3407 (print_preprocess, print_object): New macro to fix last change.
3408
35ac2a97
SM
3409 * print.c (print_preprocess): Don't forget font objects.
3410
62973b41
JB
34112011-03-16 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * emacs.c (USAGE3): Doc fixes.
3414
0e48bb22
AS
34152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3416
3417 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3418 structure.
3419
7684e57b
JB
34202011-03-14 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * lisp.h (VWindow_system, Qfile_name_history):
3423 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3424 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3425 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3426
3427 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3428 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3429
3430 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3431 * w32console.c (detect_input_pending, read_input_pending)
3432 (encode_terminal_code):
3433 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3434 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3435 (w32_system_caret_y, Qfile_name_history):
3436 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3437 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3438 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3439 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3440 * w32proc.c (Qlocal, report_file_error):
3441 * w32term.c (Vwindow_system, updating_frame):
3442 * w32uniscribe.c (initialized, uniscribe_font_driver):
3443 Remove unneeded extern declarations.
3444
2aa46d6c
CY
34452011-03-14 Chong Yidong <cyd@stupidchicken.com>
3446
c96bbc66 3447 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3448
cffc6f3b
CY
34492011-03-13 Chong Yidong <cyd@stupidchicken.com>
3450
3451 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3452 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3453 These macros can no longer be used for assignment.
3454
44f230aa
SM
3455 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3456 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3457 (record_buffer_markers, fetch_buffer_markers): New functions for
3458 recording and fetching special buffer markers.
3459 (set_buffer_internal_1, set_buffer_temp): Use them.
3460
3461 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3462
3463 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3464
3465 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3466 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3467
3468 * xdisp.c (hscroll_window_tree):
3469 (reconsider_clip_changes): Use PT instead of BUF_PT.
3470
d251f04b
EZ
34712011-03-13 Eli Zaretskii <eliz@gnu.org>
3472
3473 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3474 $(EMACS_ROOT)/lib/intprops.h.
3475
f0c77cd1
PE
34762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3477
3eca4629
PE
3478 Fix more problems found by GCC 4.5.2's static checks.
3479
7c86ee98
PE
3480 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3481 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3482 (xg_free_frame_widgets): Make it clear that a local variable is
3483 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3484 (gdk_window_get_screen): Make it clear that this macro is needed
3485 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3486 (int_gtk_range_get_value): New function, which avoids a diagnostic
3487 from gcc -Wbad-function-cast.
3488 (xg_set_toolkit_scroll_bar_thumb): Use it.
3489 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3490 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3491 (get_utf8_string, xg_get_file_with_chooser):
3492 Rename locals to avoid shadowing.
3493 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3494
41729b81
PE
3495 * xgselect.c (xg_select): Remove unused var.
3496
f0c77cd1
PE
3497 * image.c (four_corners_best): Mark locals as initialized.
3498 (gif_load): Initialize transparent_p to zero (Bug#8238).
3499 Mark another local as initialized.
ec6cf4c6 3500 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3501
ce0ad53d 3502 * image.c (clear_image_cache): Now static.
d5d5a617 3503 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3504 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3505 (x_edge_detection): Remove unnecessary cast that
3506 gcc -Wbad-function-cast diagnoses.
2037898d 3507 (gif_load): Fix pointer signedness.
6ae141d6
PE
3508 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3509 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3510
33383987 35112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3512
d32df629
PE
3513 Improve quality of tests for time stamp overflow.
3514 For example, without this patch (encode-time 0 0 0 1 1
3515 1152921504606846976) returns the obviously-bogus value (-948597
3516 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3517 reports time overflow. See
3518 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3519 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3520 * editfns.c: Include limits.h and intprops.h.
3521 (TIME_T_MIN, TIME_T_MAX): New macros.
3522 (time_overflow): Move earlier, to before first use.
3523 (hi_time, lo_time): New functions, for an accurate test for
3524 out-of-range times.
3525 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3526 (Fget_internal_run_time): Don't assume time_t fits in int.
3527 (make_time): Use list2 instead of Fcons twice.
3528 (Fdecode_time): More accurate test for out-of-range times.
3529 (check_tm_member): New function.
3530 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3531 (lisp_time_argument): Don't rely on undefined left-shift and
3532 right-shift behavior when checking for time stamp overflow.
8be6f318 3533
fe31d94c
PE
3534 * editfns.c (time_overflow): New function, refactoring common code.
3535 (Fformat_time_string, Fdecode_time, Fencode_time):
3536 (Fcurrent_time_string): Use it.
3537
8be6f318
PE
3538 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3539 * dired.c (make_time): Move to ...
3540 * editfns.c (make_time): ... here.
3541 * systime.h: Note the move.
3542
09d9db2c 35432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3544
126bc0dc
YM
3545 * fringe.c (update_window_fringes): Remove unused variables.
3546
c47cbdfd
YM
3547 * unexmacosx.c (copy_data_segment): Also copy __got section.
3548 (Bug#8223)
3549
7ac80be9
EZ
35502011-03-12 Eli Zaretskii <eliz@gnu.org>
3551
c96bbc66 3552 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3553 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3554 Constify `char *' arguments and their references according to
3555 prototypes in tparam.h.
3556
ecb0f94d 3557 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3558
7ac80be9
EZ
3559 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3560 Adapt all references accordingly.
3561
3562 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3563
ef1fd07e
TT
35642011-03-11 Tom Tromey <tromey@redhat.com>
3565
3566 * buffer.c (syms_of_buffer): Remove obsolete comment.
3567
7ef4b50c
EZ
35682011-03-11 Eli Zaretskii <eliz@gnu.org>
3569
3570 * termhooks.h (encode_terminal_code): Declare prototype.
3571
3572 * msdos.c (encode_terminal_code): Don't declare prototype.
3573
3574 * term.c (encode_terminal_code): Now external again, used by
3575 w32console.c and msdos.c.
3576
44f230aa
SM
3577 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3578 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3579
4b1ec863 35802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3581
1714f52b 3582 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3583
4b1ec863
PE
3584 * fringe.c (update_window_fringes): Mark locals as initialized
3585 (Bug#8227).
3586 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3587
524c7aa6
PE
3588 * alloc.c (mark_fringe_data): Move decl from here ...
3589 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3590 to check its interface.
3591 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3592
a5c0af81 3593 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3594 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3595 (fontset_font): Mark local as initialized.
a9a06e0b 3596 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3597
b4716021
PE
3598 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3599
811e9bac 3600 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3601 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3602 (x_own_selection, Fx_disown_selection_internal): Rename locals
3603 to avoid shadowing.
3604 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3605
7e3ab302
PE
3606 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3607 so that the caller can use some name other than gcpro1.
3608 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3609 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3610 (Fx_backspace_delete_keys_p):
3611 Use them to avoid shadowing, and rename vars to avoid shadowing.
3612 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3613 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3614 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3615 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3616 Remove unused locals.
7e3ab302
PE
3617 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3618 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3619 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3620 macros.
f78faa98 3621
e2b13473
PE
3622 * xterm.h (x_mouse_leave): New decl.
3623
77f23912
PE
3624 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3625 Remove unused functions.
cdf4ba58
PE
3626 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3627 (x_calc_absolute_position): Now static.
7411c686 3628 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3629 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3630 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3631 unless they are used.
38d0b34a
PE
3632 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3633 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3634 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3635 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3636 (x_error_catcher, x_connection_closed, x_error_handler):
3637 (x_error_quitter, xembed_send_message, x_iconify_frame):
3638 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3639 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3640 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3641
44f230aa
SM
3642 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3643 Rename or move locals to avoid shadowing.
6b463e58 3644 (tty_defined_color, merge_face_heights): Now static.
5967d051 3645 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3646 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3647 does not deduce is never used uninitialized.
73719eba
PE
3648 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3649 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3650
426994c3 3651 * terminal.c (store_terminal_param): Now static.
5489860b 3652
032f1620 3653 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3654 (set_frame_menubar): Remove unused local.
d4323972 3655 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3656 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3657 since they might point to immutable storage.
281585b0
PE
3658 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3659 since it's unused otherwise.
032f1620 3660
367c19e5 3661 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3662 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3663 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3664 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3665 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3666 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3667 does not deduce are never used uninitialized.
70739cbe 3668
07b48fa9
PE
3669 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3670
8868a238 3671 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3672 * window.c (window_loop, size_window):
3673 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3674
7e5cf297 3675 * window.c (display_buffer): Now static.
d6550a9f
PE
3676 (size_window): Mark variables that gcc -Wuninitialized
3677 does not deduce are never used uninitialized.
a586633d
PE
3678 * window.h (check_all_windows): New decl, to forestall
3679 gcc -Wmissing-prototypes diagnostic.
5b555da1 3680 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3681
f6095868
PE
3682 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3683 shadowing.
3684 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3685 Include <limits.h>.
3686 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3687 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3688 (load_charset_map): Mark variables that gcc -Wuninitialized
3689 does not deduce are never used uninitialized.
53df7c11 3690 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3691
f38b440c
PE
3692 * coding.c (coding_set_source, coding_set_destination):
3693 Use "else { /* comment */ }" rather than "else /* comment */;"
3694 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3695 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3696 a block, when the outer 'i' will do.
3697 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3698 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3699 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3700 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3701 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3702 Rename locals to avoid shadowing.
3703 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3704 * coding.c (emacs_mule_char, encode_invocation_designation):
3705 Now static, since they're not used elsewhere.
413bb2db 3706 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3707 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3708 (decode_coding_emacs_mule): Mark variables that gcc
3709 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3710 (detect_coding_iso_2022): Initialize a local variable that might
3711 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3712 this initialization is needed. (Bug#8211)
5f58e762
PE
3713 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3714 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3715 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3716 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3717 Remove unused macros.
f38b440c 3718
232b38b9 3719 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3720 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3721 * character.c (string_count_byte8): Likewise.
232b38b9 3722
fb90da1b
PE
3723 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3724 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3725
fb93dbc2
PE
3726 * chartab.c (copy_sub_char_table): Now static, since it's not used
3727 elsewhere.
5c156ace
PE
3728 (sub_char_table_ref_and_range, char_table_ref_and_range):
3729 Rename locals to avoid shadowing.
bbcd0949 3730 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3731
7d3b3862 3732 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3733 (BIDI_BOB): Remove unused macro.
7d3b3862 3734
6be7d3da
PE
3735 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3736 deduce are never used uninitialized.
c2ed9c8b 3737 * term.c (encode_terminal_code): Likewise.
6be7d3da 3738
75f8807f 3739 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3740
50938595
PE
3741 * tparam.h: New file.
3742 * term.c, tparam.h: Include it.
3743 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3744 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3745 Move these decls to tparam.h, and make them agree with what
3746 is actually in tparam.c. The previous trick of using incompatible
3747 decls in different modules does not conform to the C standard.
3748 All callers of tparam changed to use tparam's actual API.
3749 * tparam.c (tparam1, tparam, tgoto):
3750 Use const pointers where appropriate.
3751
fbceeba2
PE
3752 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3753 * cm.h (struct cm): Likewise.
3754 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3755 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3756 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3757 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3758 (turn_on_face, init_tty): Likewise.
3759 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3760
7f3f1250
PE
3761 * term.c (term_mouse_position): Rename local to avoid shadowing.
3762
e6ca6543
PE
3763 * alloc.c (mark_ttys): Move decl from here ...
3764 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3765
c40f8d15
AS
37662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3767
3768 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3769
cfe0661d
JB
37702011-03-09 Juanma Barranquero <lekktu@gmail.com>
3771
3772 * search.c (compile_pattern_1): Remove argument regp, unused since
3773 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3774 (compile_pattern): Don't pass it.
3775
0afb4571
J
37762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3777
3778 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3779 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3780 for ! HAVE_GTK3.
3781 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3782
3783 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3784
3785 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3786 gdk_window_get_screen, gdk_window_get_geometry,
3787 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3788 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3789 (xg_get_pixbuf_from_pixmap): New function.
3790 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3791 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3792 Call xg_get_pixbuf_from_pixmap instead of
3793 gdk_pixbuf_get_from_drawable.
3794 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3795 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3796 (xg_check_special_colors): Use GtkStyleContext and its functions
3797 for HAVE_GTK3.
3798 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3799 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3800 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3801 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3802 Call gtk_widget_get_preferred_size.
0afb4571
J
3803 (xg_frame_resized): gdk_window_get_geometry only takes 5
3804 parameters.
44f230aa
SM
3805 (xg_win_to_widget, xg_event_is_for_menubar):
3806 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3807 (xg_set_widget_bg): New function.
3808 (delete_cb): New function.
895009e1 3809 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3810 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3811 (xg_set_background_color): Call xg_set_widget_bg.
3812 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3813 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3814 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3815 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3816 if ! HAVE_GTK3.
3817 (update_frame_tool_bar): Call gtk_widget_hide.
3818 (xg_initialize): Use GDK_KEY_g.
3819
3820 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3821 if ! HAVE_GTK3
3822 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3823
3824 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3825 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3826 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3827
1c2cc4ef
JB
38282011-03-08 Juanma Barranquero <lekktu@gmail.com>
3829
3830 * w32xfns.c (select_palette): Check success of RealizePalette against
3831 GDI_ERROR, not zero.
3832
33383987 3833See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3834
3835;; Local Variables:
3836;; coding: utf-8
aac0c6e3
MR
3837;; End:
3838
33383987 3839 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3840
3841 This file is part of GNU Emacs.
3842
3843 GNU Emacs is free software: you can redistribute it and/or modify
3844 it under the terms of the GNU General Public License as published by
3845 the Free Software Foundation, either version 3 of the License, or
3846 (at your option) any later version.
3847
3848 GNU Emacs is distributed in the hope that it will be useful,
3849 but WITHOUT ANY WARRANTY; without even the implied warranty of
3850 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3851 GNU General Public License for more details.
3852
3853 You should have received a copy of the GNU General Public License
3854 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.