* insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
28177add
PE
12011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2
599a9e4f
PE
3 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4
99561444
PE
5 * insdel.c, lisp.h (buffer_overflow): New function.
6 (insert_from_buffer_1, replace_range, replace_range_2):
7 * insdel.c (make_gap_larger):
8 * editfns.c (Finsert_char):
9 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10
28177add
PE
11 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12
e69dafad
PE
132011-06-15 Paul Eggert <eggert@cs.ucla.edu>
14
a7af7fde 15 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 16
b1c46f02
PE
17 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
18 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
19
e69dafad
PE
20 * fileio.c: Don't assume EMACS_INT fits in off_t.
21 (emacs_lseek): New static function.
22 (Finsert_file_contents, Fwrite_region): Use it.
23 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
24
566684ea
PE
25 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
26
e6966cd6
PE
27 * fns.c: Don't overflow int when computing a list length.
28 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
29 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
30 truncation on 64-bit hosts. Check for QUIT every
31 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
32 faster and is responsive enough.
33 (Flength): Report an error instead of overflowing an integer.
34 (Fsafe_length): Return a float if the value is not representable
35 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 36 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 37 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 38
dd0b0efb
PE
39 * alloc.c: Check that resized vectors' lengths fit in fixnums.
40 (header_size, word_size): New constants.
41 (allocate_vectorlike): Don't check size overflow here.
42 (allocate_vector): Check it here instead, since this is the only
43 caller of allocate_vectorlike that could cause overflow.
44 Check that the new vector's length is representable as a fixnum.
45
86fe5cfe
PE
46 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
47 The previous code was bogus. For example, next_almost_prime (32)
48 returned 39, which is undesirable as it is a multiple of 3; and
49 next_almost_prime (24) returned 25, which is a multiple of 5 so
50 why was the code bothering to check for multiples of 7?
51
80e88859
PE
52 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
53
4a2f0ad6
PE
54 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
55
f66c7cf8
PE
56 Variadic C functions now count arguments with ptrdiff_t.
57 This partly undoes my 2011-03-30 change, which replaced int with size_t.
58 Back then I didn't know that the Emacs coding style prefers signed int.
59 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
60 were being counted with int, which may truncate counts on 64-bit
61 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
62 * lisp.h (struct Lisp_Subr.function.aMANY)
63 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
64 Arg counts are now ptrdiff_t, not size_t.
65 All variadic functions and their callers changed accordingly.
66 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
67 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
68 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
69 * callint.c (Fcall_interactively): Check arg count for overflow,
70 to avoid potential buffer overrun. Use signed char, not 'int',
71 for 'varies' array, so that we needn't bother to check its size
72 calculation for overflow.
73 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
74 * eval.c (apply_lambda):
75 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
76 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
77 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
78
a1759b76
PE
79 * callint.c (Fcall_interactively): Don't use index var as event count.
80
d96be9fc
PE
81 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
82 * mem-limits.h (SIZE): Remove; no longer used.
83
a690a978 84 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 85
578c21e6
PE
86 Remove unnecessary casts.
87 * xterm.c (x_term_init):
88 * xfns.c (x_set_border_pixel):
89 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
90 These aren't needed now that we assume ANSI C.
91
96f53c6c
PE
92 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
93 It's more likely to cause problems (due to unsigned overflow)
94 than to cure them.
95
83c77d31
PE
96 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
97
ee2079f1
PE
98 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
99
6da65536
PE
100 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
101
7147c4a4
PE
102 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
103
193e32d9
PE
104 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
105
e5533da6
PE
106 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
107
9910e595
PE
108 GLYPH_CODE_FACE returns EMACS_INT, not int.
109 * dispextern.h (merge_faces):
110 * xfaces.c (merge_faces):
01103c44
PE
111 * xdisp.c (get_next_display_element, next_element_from_display_vector):
112 Don't assume EMACS_INT fits in int.
9910e595 113
2638320e
PE
114 * character.h (CHAR_VALID_P): Remove unused parameter.
115 * fontset.c, lisp.h, xdisp.c: All uses changed.
116
045eb8d9
PE
117 * editfns.c (Ftranslate_region_internal): Omit redundant test.
118
c1f134b5
PE
119 * fns.c (concat): Minor tuning based on overflow analysis.
120 This doesn't fix any bugs. Use int to hold character, instead
121 of constantly refetching from Emacs object. Use XFASTINT, not
122 XINT, for value known to be a character. Don't bother comparing
123 a single byte to 0400, as it's always less.
124
395fcb93 125 * floatfns.c (Fexpt):
327eeec8
PE
126 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
127
abbd3d23
PE
128 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
129 for characters.
130
684a03ef
PE
131 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
132
0fed43f3
PE
133 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
134 Without this fix, on a 64-bit host (aset S 0 4294967386) would
135 incorrectly succeed when S was a string, because 4294967386 was
136 truncated before it was used.
137
8fd02eb7
PE
138 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
139 Otherwise, an out-of-range integer could cause undefined behavior
140 on a 64-bit host.
141
f8c86b69
PE
142 * composite.c: Use int, not EMACS_INT, for characters.
143 (fill_gstring_body, composition_compute_stop_pos): Use int, not
144 EMACS_INT, for values that are known to be in character range.
145 This doesn't fix any bugs but is the usual style inside Emacs and
146 may generate better code on 32-bit machines.
147
34206dd2
PE
148 Make sure a 64-bit char is never passed to ENCODE_CHAR.
149 This is for reasons similar to the recent CHAR_STRING fix.
150 * charset.c (Fencode_char): Check that character arg is actually
151 a character. Pass an int to ENCODE_CHAR.
152 * charset.h (ENCODE_CHAR): Verify that the character argument is no
153 wider than 'int', as a compile-time check to prevent future regressions
154 in this area.
155
c5958d4c 156 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
157
158 Make sure a 64-bit char is never passed to CHAR_STRING.
159 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
160 by silently ignoring the top 32 bits, allowing some values
161 that were far too large to be valid characters.
162 * character.h: Include <verify.h>.
163 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
164 arguments are no wider than unsigned, as a compile-time check
165 to prevent future regressions in this area.
166 * data.c (Faset):
01103c44 167 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
168 (Fsubst_char_in_region):
169 * fns.c (concat):
170 * xdisp.c (decode_mode_spec_coding):
171 Adjust to CHAR_STRING's new requirement.
172 * editfns.c (Finsert_char, Fsubst_char_in_region):
173 * fns.c (concat): Check that character args are actually
174 characters. Without this test, these functions did the wrong
175 thing with wildly out-of-range values on 64-bit hosts.
176
d37ca623
PE
177 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
178 These casts should not be needed on 32-bit hosts, either.
179 * keyboard.c (read_char):
180 * lread.c (Fload): Remove casts to unsigned.
181
ea204efb
PE
182 * lisp.h (UNSIGNED_CMP): New macro.
183 This fixes comparison bugs on 64-bit hosts.
184 (ASCII_CHAR_P): Use it.
185 * casefiddle.c (casify_object):
01103c44 186 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
187 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
188 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
189 * dispextern.h (FACE_FROM_ID):
190 * keyboard.c (read_char): Use UNSIGNED_CMP.
191
41cb286c
PE
192 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
193 not to EMACS_INT, to avoid GCC warning.
194
4a1b9832
PE
195 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
196
55daad71
PE
197 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
198 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
199 isn't needed on 32-bit machines.
8f95c75c 200
01103c44
PE
201 * buffer.c (Fgenerate_new_buffer_name):
202 Use EMACS_INT for count, not int.
0ceccced 203 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
204
205 * data.c (Qcompiled_function): Now static.
206
c6f072e7
PE
207 * window.c (window_body_lines): Now static.
208
20ce5912
PE
209 * image.c (gif_load): Rename local to avoid shadowing.
210
9c4c5f81
PE
211 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
212 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
213 * alloc.c (make_save_value): Integer argument is now of type
214 ptrdiff_t, not int.
215 (mark_object): Use ptrdiff_t, not int.
216 * lisp.h (pD): New macro.
217 * print.c (print_object): Use it.
218
c0c5c8ae
PE
219 * alloc.c: Use EMACS_INT, not int, to count objects.
220 (total_conses, total_markers, total_symbols, total_vector_size)
221 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
222 (total_free_floats, total_floats, total_free_intervals)
223 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
224 Now EMACS_INT, not int. All uses changed.
225 (Fgarbage_collect): Compute overall total using a double, so that
226 integer overflow is less likely to be a problem. Check for overflow
227 when converting back to an integer.
5a25e253
PE
228 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
229 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
230 These were 'int' variables that could overflow on 64-bit hosts;
231 they were never used, so remove them instead of repairing them.
211a0b2a 232 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
233 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
234 Previously, this ceilinged at INT_MAX, but that doesn't work on
235 64-bit machines.
e46bb31a 236 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 237
c78baabf 238 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 239 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
240 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
241 when a (possibly-narrower) signed value would do just as well.
242 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 243
c9d624c6
PE
244 * alloc.c: Catch some string size overflows that we were missing.
245 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
246 for convenience in STRING_BYTES_MAX.
247 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
248 The definition here is exact; the one in lisp.h was approximate.
249 (allocate_string_data): Check for string overflow. This catches
250 some instances we weren't catching before. Also, it catches
251 size_t overflow on (unusual) hosts where SIZE_MAX <= min
252 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
253 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 254
c9d624c6
PE
255 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
256 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
257 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
258
353032ce
PE
259 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
260
2bccce07
PE
261 * alloc.c (Fmake_string): Check for out-of-range init.
262
0ac30604
SM
2632011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
264
265 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
266
c195f2de
JD
2672011-06-14 Jan Djärv <jan.h.d@swipnet.se>
268
269 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
270 xg_get_default_scrollbar_width.
271
272 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
273 (int_gtk_range_get_value): Move to the scroll bar part of the file.
274 (style_changed_cb): Call update_theme_scrollbar_width and call
275 x_set_scroll_bar_default_width and xg_frame_set_char_size for
276 all frames (Bug#8505).
277 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
278 Call gtk_window_set_resizable if HAVE_GTK3.
279 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
280 and height if HAVE_GTK3 (Bug#8505).
281 (scroll_bar_width_for_theme): New variable.
282 (update_theme_scrollbar_width): New function.
283 (xg_get_default_scrollbar_width): Move code to
284 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
285 (xg_initialize): Call update_theme_scrollbar_width.
286
287 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
288
289 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
290
e10ac9f1
MR
2912011-06-12 Martin Rudalics <rudalics@gmx.at>
292
293 * frame.c (make_frame): Call other_buffer_safely instead of
294 other_buffer.
295
296 * window.c (temp_output_buffer_show): Call display_buffer with
297 second argument Vtemp_buffer_show_specifiers and reset latter
298 immediately after the call.
299 (Vtemp_buffer_show_specifiers): New variable.
300 (auto_window_vscroll_p, next_screen_context_lines)
301 (Vscroll_preserve_screen_position): Remove leading asterisks from
302 doc-strings.
303
2d3c217e 3042011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 305
7b7f97e8 306 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
307 * buffer.c (Qclone_number): Remove for now, as it's unused.
308 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
309 (record_buffer): Remove unused local.
310 * frame.c (other_visible_frames, frame_buffer_list): Now static.
311 (set_frame_buffer_list): Remove; unused.
312 * frame.h (other_visible_frames): Remove decl.
313 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
314 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
315 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
316 if HAVE_GPM.
317 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
318 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
319 Define only if HAVE_GPM.
320 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
321 (update_hints_inhibit): Remove; never set. All uses removed.
322 * widgetprv.h (emacsFrameClassRec): Remove decl.
323 * window.c (delete_deletable_window): Now returns void, since it
324 wasn't returning anything.
325 (compare_window_configurations): Remove unused locals.
326 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
327 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
328 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
329 the same widths as pointers. This follows up on the 2011-05-06 patch.
330 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
331 * xterm.h: Likewise.
332 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
333
1384b89e
JB
3342011-06-12 Juanma Barranquero <lekktu@gmail.com>
335
336 * makefile.w32-in: Update dependencies.
337 (LISP_H): Add lib/intprops.h.
338
1100a63c
CY
3392011-06-11 Chong Yidong <cyd@stupidchicken.com>
340
341 * image.c (gif_load): Add animation frame delay to the metadata.
342 (syms_of_image): Use DEFSYM. New symbol `delay'.
343
6198ccd0
MR
3442011-06-11 Martin Rudalics <rudalics@gmx.at>
345
346 * window.c (delete_deletable_window): Re-add.
347 (Fset_window_configuration): Rewrite to handle dead buffers and
348 consequently deletable windows.
349 (window_tree, Fwindow_tree): Remove. Supply functionality in
350 window.el.
351 (compare_window_configurations): Simplify code.
352
b6e3633c
AS
3532011-06-11 Andreas Schwab <schwab@linux-m68k.org>
354
1ab0dee5
AS
355 * image.c (imagemagick_load_image): Fix type mismatch.
356 (Fimagemagick_types): Likewise.
357
b6e3633c
AS
358 * window.h (replace_buffer_in_windows): Declare.
359
9397e56f
MR
3602011-06-11 Martin Rudalics <rudalics@gmx.at>
361
362 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
363 Qclone_number. Remove external declaration of Qdelete_window.
364 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
365 code.
366 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
367 Qbuffer_list_update_hook if allowed.
368 (Fother_buffer): Rewrite doc-string. Major rewrite for new
369 buffer list implementation.
370 (other_buffer_safely): New function.
371 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
372 calls to replace_buffer_in_windows and
373 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
374 if allowed.
375 (record_buffer): Inhibit quitting and rewrite using quittable
376 functions. Run Qbuffer_list_update_hook if allowed.
377 (Frecord_buffer, Funrecord_buffer): New functions.
378 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
379 switch-to-buffer to window.el.
380 (bury-buffer): Move to window.el.
381 (Vbuffer_list_update_hook): New variable.
382
383 * lisp.h (other_buffer_safely): Add prototype in buffer.c
384 section.
385
386 * window.h (resize_frame_windows): Move up in code.
387 (Fwindow_frame): Remove EXFUN.
388 (replace_buffer_in_all_windows): Remove prototype.
389 (replace_buffer_in_windows_safely): Add prototype.
390
391 * window.c: Declare Qdelete_window static again. Move down
392 declaration of select_count.
393 (Fnext_window, Fprevious_window): Rewrite doc-strings.
394 (Fother_window): Move to window.el.
395 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
396 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
397 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
398 window.el.
399 (replace_buffer_in_windows): Implement by calling
400 Qreplace_buffer_in_windows.
401 (replace_buffer_in_all_windows): Remove with some functionality
402 moved into replace_buffer_in_windows_safely.
403 (replace_buffer_in_windows_safely): New function.
404 (select_window_norecord, select_frame_norecord): Move in front
405 of run_window_configuration_change_hook. Remove now obsolete
406 declarations.
407 (Fset_window_buffer): Rewrite doc-string. Call
408 Qrecord_window_buffer.
409 (keys_of_window): Move binding for other-window to window.el.
410
b50691aa
CY
4112011-06-11 Chong Yidong <cyd@stupidchicken.com>
412
413 * dispextern.h (struct image): Replace data member, whose int_val
414 and ptr_val fields were not used by anything, with a single
415 lisp_val object.
416
417 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
418 (gif_clear_image, gif_load, imagemagick_load_image)
419 (gs_clear_image, gs_load): Callers changed.
420
3f754b86
PE
4212011-06-10 Paul Eggert <eggert@cs.ucla.edu>
422
cca69397
PE
423 * buffer.h: Include <time.h>, for time_t.
424 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
425
109e28d0
PE
426 Fix minor problems found by static checking.
427
60737f02
PE
428 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
429
4b66faf3
PE
430 Make identifiers static if they are not used in other modules.
431 * data.c (Qcompiled_function, Qframe, Qvector):
432 * image.c (QimageMagick, Qsvg):
433 * minibuf.c (Qmetadata):
434 * window.c (resize_window_check, resize_root_window): Now static.
435 * window.h (resize_window_check, resize_root_window): Remove decls.
436
109e28d0
PE
437 * window.c (window_deletion_count, delete_deletable_window):
438 Remove; unused.
46a4ce9e
PE
439 (window_body_lines): Now static.
440 (Fdelete_other_windows_internal): Mark vars as initialized.
441 Make sure 'resize_failed' is initialized.
442 (run_window_configuration_change_hook): Rename local to avoid shadowing.
443 (resize_window_apply): Remove unused local.
444 * window.h (delete_deletable_window): Remove decl.
445
109e28d0 446 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
447 (imagemagick_load_image): Fix pointer signedness problem by changing
448 last arg from unsigned char * to char *. All uses changed.
449 Also, fix a local for similar reasons.
450 Remove unused locals. Remove locals to avoid shadowing.
451 (fn_rsvg_handle_free): Remove; unused.
452 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 453 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 454
3f754b86
PE
455 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
456
2547adb1
CY
4572011-06-10 Chong Yidong <cyd@stupidchicken.com>
458
459 * image.c (gif_load): Fix omitted cast error introduced by
460 2011-06-06 change.
461
2c8e37d4
MR
4622011-06-10 Martin Rudalics <rudalics@gmx.at>
463
464 * window.h (resize_proportionally, orig_total_lines)
465 (orig_top_line): Remove from window structure.
466 (set_window_height, set_window_width, change_window_heights)
467 (Fdelete_window): Remove prototypes.
468 (resize_frame_windows): Remove duplicate declaration.
469
440a42e3
EZ
4702011-06-10 Eli Zaretskii <eliz@gnu.org>
471
472 * window.h (resize_frame_windows, resize_window_check)
473 (delete_deletable_window, resize_root_window)
474 (resize_frame_windows): Declare prototypes.
475
476 * window.c (resize_window_apply): Make definition be "static" to
477 match the prototype.
478
562dd5e9
MR
4792011-06-10 Martin Rudalics <rudalics@gmx.at>
480
481 * window.c: Remove declarations of Qwindow_size_fixed,
482 window_min_size_1, window_min_size_2, window_min_size,
483 size_window, window_fixed_size_p, enlarge_window, delete_window.
484 Remove static from declaration of Qdelete_window, it's
485 temporarily needed by Fbury_buffer.
486 (replace_window): Don't assign orig_top_line and
487 orig_total_lines.
488 (Fdelete_window, delete_window): Remove. Window deletion is
489 handled by window.el.
490 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
491 Fdelete_window calls with calls to Qdelete_window.
492 (Fdelete_other_windows): Remove. Deleting other windows is
493 handled by window.el.
494 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
495 handled in window.el.
496 (window_min_size_2, window_min_size_1, window_min_size): Remove.
497 Window minimum sizes are handled in window.el.
498 (shrink_windows, size_window, set_window_height)
499 (set_window_width, change_window_heights, window_height)
500 (window_width, CURBEG, CURSIZE, enlarge_window)
501 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
502 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
503 handled in window.el.
504 (make_dummy_parent): Rename to make_parent_window and give it a
505 second argument horflag.
506 (make_window): Don't set resize_proportionally any more.
507 (Fsplit_window): Remove. Windows are split in window.el.
508 (save_restore_action, save_restore_orig_size)
509 (shrink_window_lowest_first, save_restore_orig_size): Remove.
510 Resize mini windows in window.el.
511 (grow_mini_window, shrink_mini_window): Implement by calling
512 Qresize_root_window_vertically, resize_window_check and
513 resize_window_apply.
514 (saved_window, Fset_window_configuration, save_window_save): Do
515 not handle orig_top_line, orig_total_lines, and
516 resize_proportionally.
517 (window_min_height, window_min_width): Move to window.el.
518 (keys_of_window): Move bindings for delete-other-windows,
519 split-window, delete-window and enlarge-window to window.el.
520
521 * buffer.c: Temporarily extern Qdelete_window.
522 (Fbury_buffer): Temporarily call Qdelete_window instead of
523 Fdelete_window (Fbury_buffer will move to window.el soon).
524
525 * frame.c (set_menu_bar_lines_1): Remove code handling
526 orig_top_line and orig_total_lines.
527
528 * dispnew.c (adjust_frame_glyphs_initially): Don't use
529 set_window_height but set heights directly.
530 (change_frame_size_1): Use resize_frame_windows.
531
532 * xdisp.c (init_xdisp): Don't use set_window_height but set
533 heights directly.
534
535 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
536 resize_frame_windows instead of change_window_heights and run
537 run_window_configuration_change_hook.
538
539 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
540 instead of change_window_heights and run
541 run_window_configuration_change_hook.
542
1a13852e
MR
5432011-06-09 Martin Rudalics <rudalics@gmx.at>
544
545 * window.c (replace_window): Rename second argument REPLACEMENT to
546 NEW. New third argument SETFLAG. Rewrite.
547 (delete_window, make_dummy_parent): Call replace_window with
548 third argument 1.
549 (window_list_1): Move down in code.
550 (run_window_configuration_change_hook): Move set_buffer part
551 before select_frame_norecord part in order to unwind correctly.
552 Rename count1 to count.
553 (recombine_windows, delete_deletable_window, resize_root_window)
554 (Fdelete_other_windows_internal)
555 (Frun_window_configuration_change_hook, make_parent_window)
556 (resize_window_check, resize_window_apply, Fresize_window_apply)
557 (resize_frame_windows, Fsplit_window_internal)
558 (Fdelete_window_internal, Fresize_mini_window_internal): New
559 functions.
560 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
561
f3d1777e
MR
5622011-06-08 Martin Rudalics <rudalics@gmx.at>
563
496e208e
MR
564 * window.h (window): Add some new members to window structure -
565 normal_lines, normal_cols, new_total, new_normal, clone_number,
566 splits, nest, prev_buffers, next_buffers.
567 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 568 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 569
f3d1777e
MR
570 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
571 Remove.
496e208e
MR
572 (make_dummy_parent): Set new members of windows structure.
573 (make_window): Move down in code. Handle new members of window
574 structure.
575 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
576 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
577 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
578 (Fset_window_prev_buffers, Fwindow_next_buffers)
579 (Fset_window_next_buffers, Fset_window_clone_number): New
580 functions.
581 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
582 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
583 Doc-string fixes.
584 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
585 Argument WINDOW can be now internal window too.
586 (Fwindow_use_time): Move up in code.
587 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
588 Rewrite doc-string.
589 (Fset_window_configuration, saved_window)
590 (Fcurrent_window_configuration, save_window_save): Handle new
591 members of window structure.
b9e809c2
MR
592 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
593 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
594 (syms_of_window): New Lisp objects Qrecord_window_buffer,
595 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
596 Qget_mru_window, Qresize_root_window,
597 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
598 Qauto_buffer_name; staticpro them.
f3d1777e 599
abde8f8c
MR
6002011-06-07 Martin Rudalics <rudalics@gmx.at>
601
602 * window.c (Fwindow_total_size, Fwindow_left_column)
603 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
604 (Fwindow_list_1): New functions.
605 (window_box_text_cols): Replace with window_body_cols.
606 (Fwindow_width, Fscroll_left, Fscroll_right): Use
607 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
608 (delete_window, Fset_window_configuration): Call
609 delete_all_subwindows with window as argument.
610 (delete_all_subwindows): Take a window as argument and not a
611 structure. Rewrite.
190b47e6
MR
612 (window_loop): Remove handling of GET_LRU_WINDOW and
613 GET_LARGEST_WINDOW.
614 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
615
616 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
617 window_box_text_cols. delete_all_subwindows now takes a
618 Lisp_Object as argument.
abde8f8c
MR
619
620 * indent.c (compute_motion, Fcompute_motion): Use
621 window_body_cols instead of window_box_text_cols.
622
fa8a67e6
MR
623 * frame.c (delete_frame): Call delete_all_subwindows with root
624 window as argument.
625
a54e3482
DC
6262011-06-07 Daniel Colascione <dan.colascione@gmail.com>
627
628 * fns.c (Fputhash): Document return value.
629
60002bf5
CY
6302011-06-06 Chong Yidong <cyd@stupidchicken.com>
631
632 * image.c (gif_load): Implement gif89a spec "no disposal" method.
633
0c671da6 6342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 635
b862a52a 636 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 637
be44ca6c
PE
638 Check for overflow when converting integer to cons and back.
639 * charset.c (Fdefine_charset_internal, Fdecode_char):
640 Use cons_to_unsigned to catch overflow.
641 (Fencode_char): Use INTEGER_TO_CONS.
642 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
643 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
644 * data.c (long_to_cons, cons_to_long): Remove.
645 (cons_to_unsigned, cons_to_signed): New functions.
646 These signal an error for invalid or out-of-range values.
647 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
648 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
649 * font.c (Ffont_variation_glyphs):
650 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
651 * lisp.h: Include <intprops.h>.
652 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
653 (cons_to_signed, cons_to_unsigned): New decls.
654 (long_to_cons, cons_to_long): Remove decls.
655 * undo.c (record_first_change): Use INTEGER_TO_CONS.
656 (Fprimitive_undo): Use CONS_TO_INTEGER.
657 * xfns.c (Fx_window_property): Likewise.
658 * xselect.c: Include <limits.h>.
659 (x_own_selection, selection_data_to_lisp_data):
660 Use INTEGER_TO_CONS.
661 (x_handle_selection_request, x_handle_selection_clear)
662 (x_get_foreign_selection, Fx_disown_selection_internal)
663 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
664 (lisp_data_to_selection_data): Use cons_to_unsigned.
665 (x_fill_property_data): Use cons_to_signed.
666 Report values out of range.
667
d1f3d2af
PE
668 Check for buffer and string overflow more precisely.
669 * buffer.h (BUF_BYTES_MAX): New macro.
670 * lisp.h (STRING_BYTES_MAX): New macro.
671 * alloc.c (Fmake_string):
672 * character.c (string_escape_byte8):
673 * coding.c (coding_alloc_by_realloc):
674 * doprnt.c (doprnt):
675 * editfns.c (Fformat):
676 * eval.c (verror):
677 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
678 since they may not be the same number.
679 * editfns.c (Finsert_char):
680 * fileio.c (Finsert_file_contents):
681 Likewise for BUF_BYTES_MAX.
682
dd52fcea
PE
683 * image.c: Use ptrdiff_t, not int, for sizes.
684 (slurp_file): Switch from int to ptrdiff_t.
685 All uses changed.
686 (slurp_file): Check that file size fits in both size_t (for
687 malloc) and ptrdiff_t (for sanity and safety).
688
7f9bbdbb
PE
689 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
690 if b->modtime has its maximal value.
691
dfe18f82
PE
692 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
693
84acfcf0
PE
694 Don't assume time_t can fit into int.
695 * buffer.h (struct buffer.modtime): Now time_t, not int.
696 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
697 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
698
ccd9a01a
PE
699 Minor fixes for signed vs unsigned integers.
700 * character.h (MAYBE_UNIFY_CHAR):
701 * charset.c (maybe_unify_char):
702 * keyboard.c (read_char, reorder_modifiers):
703 XINT -> XFASTINT, since the integer must be nonnegative.
704 * ftfont.c (ftfont_spec_pattern):
705 * keymap.c (access_keymap, silly_event_symbol_error):
706 XUINT -> XFASTINT, since the integer must be nonnegative.
707 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
708 since it makes no difference and we prefer signed.
709 * keyboard.c (record_char): Use XUINT when all the neighbors do.
710 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
711 nonnegative.
712
d6d100dd
SM
7132011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
714
715 * window.h (Fwindow_frame): Declare.
716
2b6148e4
PE
7172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
718
719 * alloc.c: Simplify handling of large-request failures (Bug#8800).
720 (SPARE_MEMORY): Always define.
721 (LARGE_REQUEST): Remove.
722 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
723
f230ecc9
MR
7242011-06-06 Martin Rudalics <rudalics@gmx.at>
725
727e958e
MR
726 * lisp.h: Move EXFUNS for Fframe_root_window,
727 Fframe_first_window and Fset_frame_selected_window to window.h.
728
729 * window.h: Move EXFUNS for Fframe_root_window,
730 Fframe_first_window and Fset_frame_selected_window here from
731 lisp.h.
732
733 * frame.c (Fwindow_frame, Fframe_first_window)
734 (Fframe_root_window, Fframe_selected_window)
735 (Fset_frame_selected_window): Move to window.c.
736 (Factive_minibuffer_window): Move to minibuf.c.
737 (Fother_visible_frames_p): New function.
738
739 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
740
f230ecc9
MR
741 * window.c (decode_window, decode_any_window): Move up in code.
742 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
743 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
744 (Fwindow_buffer): Move up and rewrite doc-string.
745 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
746 (Fwindow_prev): New functions.
727e958e
MR
747 (Fwindow_frame): Move here from frame.c. Accept any window as
748 argument.
749 (Fframe_root_window, Fframe_first_window)
750 (Fframe_selected_window): Move here from frame.c. Accept frame
751 or arbitrary window as argument. Update doc-strings.
752 (Fminibuffer_window): Move up in code.
753 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
754 (Fset_frame_selected_window): Move here from frame.c.
755 Marginal rewrite.
727e958e
MR
756 (Fselected_window, select_window, Fselect_window): Move up in
757 code. Minor doc-string fixes.
f230ecc9 758
4d09bcf6
PE
7592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
760
761 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
762 Do not assume that spare memory exists; that assumption is valid
763 only if SYSTEM_MALLOC.
764 (LARGE_REQUEST): New macro, so that the issue of large requests
765 is separated from the issue of spare memory.
766
810928a2
AS
7672011-06-05 Andreas Schwab <schwab@linux-m68k.org>
768
172418ad
AS
769 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
770 format. (Bug#8806)
771
43f862f7
AS
772 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
773
810928a2
AS
774 * xfns.c (x_set_scroll_bar_default_width): Move declarations
775 before statements.
776
a059fe24
JD
7772011-06-05 Jan Djärv <jan.h.d@swipnet.se>
778
779 * gtkutil.c (xg_get_default_scrollbar_width): New function.
780
781 * gtkutil.h: Declare xg_get_default_scrollbar_width.
782
783 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
784 min width by calling x_set_scroll_bar_default_width (Bug#8505).
785
989bf368
JB
7862011-06-05 Juanma Barranquero <lekktu@gmail.com>
787
788 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
789
4b80f674
CY
7902011-06-04 Chong Yidong <cyd@stupidchicken.com>
791
792 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
793 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
794 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
795 New error handlers.
4b80f674
CY
796 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
797 Obey Vx_select_enable_clipboard_manager. Catch errors in
798 x_clipboard_manager_save (Bug#8779).
799 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 800 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 801
99a33b77 8022011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
803
804 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
805
99a33b77 8062011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
807
808 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
809 in the current matrix if keep_current_p is non-zero.
810
8264569d
EZ
8112011-06-04 Eli Zaretskii <eliz@gnu.org>
812
813 * bidi.c (bidi_level_of_next_char): Fix last change.
814
57f97249
EZ
8152011-06-03 Eli Zaretskii <eliz@gnu.org>
816
fec2107c 817 Support bidi reordering of text covered by display properties.
57f97249 818
fec2107c
EZ
819 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
820 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
821 (bidi_cache_search, bidi_cache_iterator_state)
822 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
823 (bidi_level_of_next_char, bidi_move_to_visually_next):
824 Support character positions inside a run of characters covered by a
fec2107c
EZ
825 display string.
826 (bidi_paragraph_init, bidi_resolve_explicit_1)
827 (bidi_level_of_next_char): Call bidi_fetch_char and
828 bidi_fetch_char_advance instead of FETCH_CHAR and
829 FETCH_CHAR_ADVANCE.
830 (bidi_init_it): Initialize new members.
831 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
832 definitions.
833 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
834 instead of using explicit *_CHAR codes.
d6d100dd
SM
835 (bidi_resolve_explicit, bidi_resolve_weak):
836 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
837 bidirectional text is supported only in multibyte buffers.
838 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
839 it to initialize the frame_window_p member of struct bidi_it.
840 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
841 (bidi_resolve_explicit, bidi_resolve_weak)
842 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
843 bidi_it->nchars is non-positive.
844 (bidi_level_of_next_char): Don't try to lookup the cache for the
845 next/previous character if nothing is cached there yet, or if we
846 were just reseat()'ed to a new position.
c40e2fb2 847
0e14fe90
EZ
848 * xdisp.c (set_cursor_from_row): Set start and stop points
849 according to the row's direction when priming the loop that looks
850 for the glyph on which to display cursor.
851 (single_display_spec_intangible_p): Function deleted.
852 (display_prop_intangible_p): Reimplement to call
853 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
854 Accept 3 additional arguments needed by handle_display_spec.
855 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
856 values: lists, `(when COND...)' forms, etc.
857 (single_display_spec_string_p): Support property values that are
858 lists with the argument STRING its top-level element.
859 (display_prop_string_p): Fix the condition for processing a
860 property that is a list to be consistent with handle_display_spec.
fec2107c 861 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
862 last portion of handle_display_prop.
863 (compute_display_string_pos): Accept additional argument
864 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
865 value of a `display' property is a "replacing spec".
866 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
867 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
868 the display property, but just return a value indicating whether
869 the display property will replace the characters it covers.
870 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
871 frame_window_p members of struct bidi_it.
d6d100dd
SM
872 (compute_display_string_pos, compute_display_string_end):
873 New functions.
fec2107c
EZ
874 (push_it): Accept second argument POSITION, where pop_it should
875 jump to continue iteration.
876 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 877
fec2107c
EZ
878 * keyboard.c (adjust_point_for_property): Adjust the call to
879 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
880
881 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
882 (bidi_init_it): Update prototypes.
883 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
884 (compute_display_string_pos, compute_display_string_end):
885 Declare prototypes.
fec2107c
EZ
886 (struct bidi_it): New members nchars and disp_pos. ch_len is now
887 EMACS_INT.
fc6f18ce 888
40087514 8892011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 890
57f53182
PE
891 Malloc failure behavior now depends on size of allocation.
892 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
893 * lisp.h: Change signatures accordingly.
894 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
895 All callers changed. (Bug#8762)
896
897 * gnutls.c: Use Emacs's memory allocators.
898 Without this change, the gnutls library would invoke malloc etc.
899 directly, which causes problems on non-SYNC_INPUT hosts, and which
900 runs afoul of improving memory_full behavior. (Bug#8761)
901 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
902 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
903 xfree instead of the default malloc, realloc, free.
904 (Fgnutls_boot): No need to check for memory allocation failure,
905 since xmalloc does that for us.
906
ac32cd99 907 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
908 * category.c (hash_get_category_set):
909 * ccl.c (ccl_driver):
910 * charset.c (Fdefine_charset_internal):
911 * charset.h (struct charset.hash_index):
912 * composite.c (get_composition_id, gstring_lookup_cache)
913 (composition_gstring_put_cache):
914 * composite.h (struct composition.hash_index):
915 * dispextern.h (struct image.hash):
916 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
917 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
918 (hashfn_equal, hashfn_user_defined, make_hash_table)
919 (maybe_resize_hash_table, hash_lookup, hash_put)
920 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
921 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
922 (Fsxhash, Fgethash, Fputhash, Fmaphash):
923 * image.c (make_image, search_image_cache, lookup_image)
924 (xpm_put_color_table_h):
925 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 926 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
927 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
928 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
929 * alloc.c (allocate_vectorlike):
930 Check for overflow in vector size calculations.
931 * ccl.c (ccl_driver):
932 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
933 * fns.c, image.c: Remove unnecessary static decls that would otherwise
934 need to be updated by these changes.
40087514
PE
935 * fns.c (make_hash_table, maybe_resize_hash_table):
936 Check for integer overflow with large hash tables.
0de4bb68
PE
937 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
938 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
939 (SXHASH_REDUCE): New macro.
940 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
941 Use it instead of discarding useful hash info with large hash values.
942 (sxhash_float): New function.
943 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
944 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
945 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
946 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
947 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
948 Adjust signatures to match updated version of code.
949 (consing_since_gc): Now EMACS_INT, since a single hash table can
950 use more than INT_MAX bytes.
951
698d32e2
DN
9522011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
953
954 Make it possible to build with GCC-4.6+ -O2 -flto.
955
956 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
957
fd6fa53f
SM
9582011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
959
960 * minibuf.c (get_minibuffer, read_minibuf_unwind):
961 Call minibuffer-inactive-mode.
962
864db017
JB
9632011-05-31 Juanma Barranquero <lekktu@gmail.com>
964
965 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
966 Update dependencies.
967
2ad0baf4
DN
9682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
969
970 * data.c (init_data): Remove code for UTS, this system is not
971 supported anymore.
972
4fcc2638
DN
9732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
974
975 Don't force ./temacs to start in terminal mode.
976
977 * frame.c (make_initial_frame): Initialize faces in all cases, not
978 only when CANNOT_DUMP is defined.
979 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
980
c56e0fd5
DN
9812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
982
983 * dispnew.c (add_window_display_history): Use const for the string
984 pointer. Remove declaration, not needed.
985
333d54da 9862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 987
55d4c1b2 988 Use 'inline', not 'INLINE'.
333d54da 989 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
990 * alloc.c, fontset.c (INLINE): Remove.
991 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
992 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
993 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
994 * gmalloc.c (register_heapinfo): Use inline unconditionally.
995 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
996
738db178
DN
9972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
998
999 Make it possible to run ./temacs.
1000
1001 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1002 syms_of_callproc does the same thing. Remove test for
1003 "initialized", do it in the caller.
1004 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1005
620c53a6
SM
10062011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1007
1008 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1009 (read_minibuf): Use get_minibuffer.
1010 (syms_of_minibuf): Use DEFSYM.
1011 (Qmetadata): New var.
1012 * data.c (Qbuffer): Don't make it static.
1013 (syms_of_data): Use DEFSYM.
1014
e003a292
PE
10152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1018 (CCL_CODE_MIN): New macro.
1019
ed008a6d
PE
10202011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1021
3687c2ef
PE
1022 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1023
ed008a6d
PE
1024 * eval.c (Qdebug): Now static.
1025 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1026 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1027 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1028
d66c4c7c
CY
10292011-05-29 Chong Yidong <cyd@stupidchicken.com>
1030
1031 * image.c: Various fixes to ImageMagick code comments.
1032 (Fimagemagick_types): Doc fix.
1033
5fbc2025
PE
10342011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1035
0196f88a
PE
1036 Minor fixes prompted by GCC 4.6.0 warnings.
1037
1038 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1039
5fbc2025
PE
1040 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1041 (x_clipboard_manager_save_all): Move extern decl to ...
1042 * xterm.h: ... here, so that it can be checked for consistency.
1043
1dd3c2d9
CY
10442011-05-29 Chong Yidong <cyd@stupidchicken.com>
1045
1046 * xselect.c (x_clipboard_manager_save_frame)
1047 (x_clipboard_manager_save_all): New functions.
1048 (Fx_clipboard_manager_save): Lisp function deleted.
1049
1050 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1051 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1052
1053 * xterm.h: Update prototype.
1054
5ba6571d
WX
10552011-05-28 William Xu <william.xwl@gmail.com>
1056
1057 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1058 exiting (Bug#8239).
1059
3eaff834
JM
10602011-05-28 Jim Meyering <meyering@redhat.com>
1061
e1900994 1062 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1063 * fns.c (to_uchar): Define.
1064 (crypto_hash_function): Use it to convert some newly-signed
1065 variables to unsigned, to avoid sign-extension bugs. For example,
1066 without this change, (md5 "truc") would evaluate to
1067 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1068 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1069 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1070
0f6990a7
PE
10712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 Integer overflow fixes.
c8a9ca5a 1074
08686060
PE
1075 * dbusbind.c: Serial number integer overflow fixes.
1076 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1077 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1078 to hold a serial number that is too large for a fixnum.
1079 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1080 Check for serial numbers out of range. Decode any serial number
59568bf0 1081 that was so large that it became a float. (Bug#8722)
08686060 1082
2d1fc3c7
PE
1083 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1084 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1085 Use XFASTINT rather than XUINT when numbers are nonnegative.
1086 (xd_append_arg, Fdbus_method_return_internal):
1087 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1088 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1089 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1090 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1091 (Bug#8722)
2d1fc3c7 1092
c8a9ca5a
PE
1093 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1094
519e1d69
PE
1095 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1096
30569699
PE
1097 ccl: add integer overflow checks
1098 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1099 (IN_INT_RANGE): New macros.
1100 (ccl_driver): Use them to check for integer overflow when
1101 decoding a CCL program. Many of the new checks are whether XINT (x)
1102 fits in int; it doesn't always, on 64-bit hosts. The new version
1103 doesn't catch all possible integer overflows, but it's an
847044ea 1104 improvement. (Bug#8719)
30569699 1105
c11285dc
PE
1106 * alloc.c (make_event_array): Use XINT, not XUINT.
1107 There's no need for unsigned here.
1108
fdccd48e
PE
1109 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1110 This follows up to the 2011-05-06 change that substituted uintptr_t
1111 for EMACS_INT. This case wasn't caught back then.
1112
37910ab2
PE
1113 Rework Fformat to avoid integer overflow issues.
1114 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1115 now (part of C89). Include <verify.h>.
1116 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1117 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1118 (Fformat): Avoid the prepass trying to compute sizes; it was only
1119 approximate and thus did not catch overflow reliably. Instead, walk
1120 through the format just once, formatting and computing sizes as we go,
1121 checking for integer overflow at every step, and allocating a larger
1122 buffer as needed. Keep track separately whether the format is
1123 multibyte. Keep only the most-recently calculated precision, rather
1124 than them all. Record whether each argument has been converted to
1125 string. Use EMACS_INT, not int, for byte and char and arg counts.
1126 Support field widths and precisions larger than INT_MAX. Avoid
1127 sprintf's undefined behavior with conversion specifications such as %#d
1128 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1129 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1130 formatting out-of-range floating point numbers with int
1131 formats. (Bug#8668)
1132
2e6578fb
PE
1133 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1134
0ae6bdee
PE
1135 * data.c: Avoid integer truncation in expressions involving floats.
1136 * data.c: Include <intprops.h>.
1137 (arith_driver): When there's an integer overflow in an expression
1138 involving floating point, convert the integers to floating point
1139 so that the resulting value does not suffer from catastrophic
1140 integer truncation. For example, on a 64-bit host (* 4
1141 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1142 Do not rely on undefined behavior after integer overflow.
1143
de883a70
PE
1144 merge count_size_as_multibyte, parse_str_to_multibyte
1145 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1146 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1147 Check for integer overflow.
1148 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1149 since it's now a duplicate of the other. This is more of
1150 a character than a buffer op, so better that it's in character.c.
1151 * fns.c, print.c: Adjust to above changes.
1152
2ff916cb
PE
11532011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1154
1155 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1156
f1b54466
PE
11572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1158
fb1ac845
PE
1159 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1160 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1161 (x_clipboard_manager_save): Now static.
1162 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1163
f1b54466
PE
1164 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1165 (crypto_hash_function): Now static.
1166 Fix pointer signedness problems. Avoid unnecessary initializations.
1167
a9f737ee
CY
11682011-05-27 Chong Yidong <cyd@stupidchicken.com>
1169
1170 * termhooks.h (Vselection_alist): Make it terminal-local.
1171
1172 * terminal.c (create_terminal): Initialize it.
1173
1174 * xselect.c: Support for clipboard managers.
1175 (Vselection_alist): Move to termhooks.h as terminal-local var.
1176 (LOCAL_SELECTION): New macro.
1177 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1178 (symbol_to_x_atom): Remove gratuitous arg.
1179 (x_handle_selection_request, lisp_data_to_selection_data)
1180 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1181 (x_own_selection, x_get_local_selection, x_convert_selection):
1182 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1183 (some_frame_on_display): Delete unused function.
1184 (Fx_own_selection_internal, Fx_get_selection_internal)
1185 (Fx_disown_selection_internal, Fx_selection_owner_p)
1186 (Fx_selection_exists_p): New optional frame arg.
1187 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1188 (x_handle_selection_clear): Don't treat other terminals with the
1189 same keyboard specially. Use the terminal-local Vselection_alist.
1190 (x_clear_frame_selections): Use Frun_hook_with_args.
1191
1192 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1193
1194 * xterm.h: Add support for those atoms.
1195
e067f0c1
CY
11962011-05-26 Chong Yidong <cyd@stupidchicken.com>
1197
1198 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1199 (converted_selections, conversion_fail_tag): New global variables.
1200 (x_selection_request_lisp_error): Free the above.
1201 (x_get_local_selection): Remove unnecessary code.
1202 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1203 of converted selections stored in converted_selections.
1204 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1205 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1206 (x_convert_selection): New function.
1207 (x_handle_selection_event): Simplify.
1208 (x_get_foreign_selection): Don't ignore incoming requests while
1209 waiting for an answer; this will fail when we implement
1210 SAVE_TARGETS, and seems unnecessary anyway.
1211 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1212 (Vx_sent_selection_functions): Doc fix.
1213
0f4aebc0
LL
12142011-05-26 Leo Liu <sdl.web@gmail.com>
1215
1216 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1217
e61124cd
YM
12182011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1219
1220 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1221
1222 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1223 for fringe update if it has periodic bitmap.
1224 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1225 and fringe_bitmap_periodic_p.
1226
1227 * fringe.c (get_fringe_bitmap_data): New function.
1228 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1229 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1230 row. Mark glyph row for fringe update if periodicity changed.
1231
1232 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1233 for fringe update unless it has periodic bitmap.
1234
f16d9837
KH
12352011-05-25 Kenichi Handa <handa@m17n.org>
1236
1237 * xdisp.c (get_next_display_element): Set correct it->face_id for
1238 a static composition.
1239
e1b90ef6
LL
12402011-05-24 Leo Liu <sdl.web@gmail.com>
1241
1242 * deps.mk (fns.o):
1243 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1244
1245 * fns.c (crypto_hash_function, Fsha1): New function.
1246 (Fmd5): Use crypto_hash_function.
1247 (syms_of_fns): Add Ssha1.
1248
7400048f
PE
12492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1250
1251 * gnutls.c: Remove unused macros.
1252 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1253 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1254 Remove macros that are defined and never used.
1255 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1256
abb71cf4
CY
12572011-05-22 Chong Yidong <cyd@stupidchicken.com>
1258
1259 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1260 (Fx_get_selection_internal): Minor cleanup.
1261 (Fx_own_selection_internal): Rename arguments for consistency with
1262 select.el.
1263
6307db39
PE
12642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1267
f3d4e0a4
CY
12682011-05-22 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1271
4d8ade89
YM
12722011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1273
1274 * dispnew.c (scrolling_window): Don't exclude the case that the
1275 last enabled row in the desired matrix touches the bottom boundary.
1276
32078c8d
GM
12772011-05-21 Glenn Morris <rgm@gnu.org>
1278
1279 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1280 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1281 and add some more files.
32078c8d 1282
7285dc67
EZ
12832011-05-20 Eli Zaretskii <eliz@gnu.org>
1284
1285 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1286 report_file_error introduced by the change from 2011-05-07.
1287
89d1bd22
PE
12882011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * systime.h (Time): Define only if emacs is defined.
1291 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1292 where the include path doesn't have X11/X.h by default. See
1293 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1294
e23640bb 12952011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1296
1297 * composite.c (find_automatic_composition): Fix previous change.
1298
b9704ad9
GM
12992011-05-20 Glenn Morris <rgm@gnu.org>
1300
1301 * lisp.mk: New file, split from Makefile.in.
1302 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1303 (shortlisp): Remove.
1304 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1305
4a720484
GM
13062011-05-19 Glenn Morris <rgm@gnu.org>
1307
1308 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1309 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1310 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1311 (lisp): Set the order to that of loadup.el.
1312 (shortlisp): Make it a copy of $lisp.
1313 (SOME_MACHINE_LISP): Remove.
1314 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1315 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1316
a28d4396
KH
13172011-05-18 Kenichi Handa <handa@m17n.org>
1318
1319 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1320 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1321 (find_automatic_composition): Mostly rewrite for efficiency.
1322
a2b1fa8e
JB
13232011-05-18 Juanma Barranquero <lekktu@gmail.com>
1324
1325 * makefile.w32-in: Update dependencies.
1326
8e1f5610
CS
13272011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1328
1329 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1330 revision 104625).
1331
7025ee00 13322011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1333
cdfa6eab
PE
1334 Fix some integer overflow issues, such as string length overflow.
1335
06d6db33
PE
1336 * insdel.c (count_size_as_multibyte): Check for string overflow.
1337
2b4560a8
PE
1338 * character.c (lisp_string_width): Check for string overflow.
1339 Use EMACS_INT, not int, for string indexes and lengths; in
1340 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1341 the resulting string length overflows an EMACS_INT; instead,
1342 report a string overflow if no precision given. When checking for
1343 precision exhaustion, use a check that cannot possibly have
1344 integer overflow. (Bug#8675)
1345 * character.h (lisp_string_width): Adjust to new signature.
1346
cb93f9be
PE
1347 * alloc.c (string_overflow): New function.
1348 (Fmake_string): Use it. This doesn't change behavior, but saves
1349 a few bytes and will simplify future changes.
1350 * character.c (string_escape_byte8): Likewise.
1351 * lisp.h (string_overflow): New decl.
1352
1a1f3366
PE
1353 Fixups, following up to the user-interface timestamp change.
1354 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1355 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1356 * msdos.c (mouse_get_pos): Likewise.
1357 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1358 * w32gui.h (Time): Define by including "systime.h" rather than by
1359 declaring it ourselves. (Bug#8664)
1360
d4e3e4d3
PE
1361 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1362 * image.c (clear_image_cache): Likewise.
1363
f6a24d19
PE
1364 * term.c (term_mouse_position): Don't assume time_t wraparound.
1365
08dc5ae6
PE
1366 Be more systematic about user-interface timestamps.
1367 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1368 and sometimes 'EMACS_UINT', to represent these timestamps.
1369 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1370 This makes the code easier to follow, and makes it easier to catch
1371 integer overflow bugs such as Bug#8664.
1372 * frame.c (Fmouse_position, Fmouse_pixel_position):
1373 Use Time, not unsigned long, for user-interface timestamps.
1374 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1375 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1376 * keyboard.h (last_event_timestamp): Likewise.
1377 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1378 * menu.h (xmenu_show): Likewise.
1379 * term.c (term_mouse_position): Likewise.
1380 * termhooks.h (struct input_event.timestamp): Likewise.
1381 (struct terminal.mouse_position_hook): Likewise.
1382 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1383 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1384 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1385 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1386 what it was before.
1387 * menu.h, termhooks.h: Include "systime.h", for Time.
1388
8e55734a
PE
1389 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1390 Don't assume that the difference between two unsigned long values
1391 can fit into an integer. At this point, we know button_down_time
1392 <= event->timestamp, so the difference must be nonnegative, so
1393 there's no need to cast the result if double-click-time is
1394 nonnegative, as it should be; check that it's nonnegative, just in
1395 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1396 apart (about 25 days). (Bug#8664)
8e55734a 1397
841f1b75 1398 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1399 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1400
3e26f69c
PE
1401 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1402 that always fit in int. Use a sentinel instead of a counter, to
1403 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1404 * frame.h (struct frame): Use int for menu_bar_items_used
1405 instead of EMACS_INT, since it always fits in int.
3e26f69c 1406
5cc152c0
PE
1407 * menu.c (grow_menu_items): Check for int overflow.
1408
d89eb65e
PE
1409 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1410
5235bd3e
PE
1411 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1412 Before, the code was not consistent. These values cannot exceed
1413 2**31 - 1 so there's no need to make them unsigned.
1414 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1415 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1416 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1417 as modifiers.
1418 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1419
bc827e23
PE
1420 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1421 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1422 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1423 presumably because the widths might not match.
1424
78eb494e
PE
1425 * window.c (size_window): Avoid needless test at loop start.
1426
04f2d78b
CB
14272011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1428
1429 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1430
d2fc7e3d 14312011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1432
1433 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1434
d2fc7e3d 14352011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1436
1437 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1438 `width' to `bar_area_x' and `bar_area_width', respectively.
1439 (x_scroll_run): Take account of fringe background extension.
1440
04f2d78b
CB
1441 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1442 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1443 `bar_area_width', respectively.
1444 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1445 background extension.
1446
79b70037
GM
14472011-05-10 Jim Meyering <meyering@redhat.com>
1448
1449 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1450
2f142cc5
JB
14512011-05-10 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * image.c (Finit_image_library): Return t for built-in image types,
1454 like pbm and xbm. (Bug#8640)
1455
57679c86
AS
14562011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1457
1458 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1459
888c9e86
EZ
14602011-05-07 Eli Zaretskii <eliz@gnu.org>
1461
b0512a1d
EZ
1462 * w32console.c (Fset_screen_color): Doc fix.
1463 (Fget_screen_color): New function.
1464 (syms_of_ntterm): Defsubr it.
1465
7285dc67
EZ
1466 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1467 unlink the temporary file if Fcall_process didn't create it in the
1468 first place.
1469 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1470 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1471 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1472 cue to call_process_cleanup not to close that handle.
1473
4d3fcc8e
BK
14742011-05-07 Ben Key <bkey76@gmail.com>
1475
1476 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1477 one of two shell specific rules, either bootstrap-temacs-CMD or
1478 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1479 to the previous implementation of the bootstrap-temacs rule.
1480 The bootstrap-temacs-CMD rule is similar to the previous
1481 implementation of the bootstrap-temacs rule except that it
1482 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1483 variable.
1484
1485 These changes, along with some changes to nt/configure.bat,
1486 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1487 earlier fix to add support for --cflags and --ldflags options
1488 that include quotes so that it works whether make uses cmd or
1489 sh as the shell.
1490
b4289b64
MA
14912011-05-06 Michael Albinus <michael.albinus@gmx.de>
1492
1493 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1494 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1495 is a constant.
1496 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1497 a string. Handle both cases.
1498 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1499 (Fdbus_register_method): Use Qinvalid_function.
1500
af4c0e28
JB
15012011-05-06 Juanma Barranquero <lekktu@gmail.com>
1502
1503 * makefile.w32-in: Update dependencies.
1504 (LISP_H): Add inttypes.h and stdin.h.
1505 (PROCESS_H): Add unistd.h.
1506
c51453d9
EZ
15072011-05-06 Eli Zaretskii <eliz@gnu.org>
1508
1509 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1510 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1511
8ff0ac3c 15122011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1513
4c4b566b
PE
1514 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1515
aab2b9b5
PE
1516 * term.c (vfatal): Remove stray call to va_end.
1517 It's not needed and the C Standard doesn't allow it here anyway.
1518
c378da0b
PE
1519 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1520 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1521
288b08c7
PE
1522 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1523 bytes.
1524
e3601888
PE
1525 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1526
db6c0e74
PE
1527 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1528
dd5963ea
PE
1529 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1530
88c9450f
PE
1531 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1532
2f9442b8
PE
1533 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1534
c032b5f8
PE
1535 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1536 * charset.c (Fdefine_charset_internal): Don't initialize
1537 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1538 32-bit int (Bug#8600).
a108c10b
PE
1539
1540 * lread.c (read_integer): Be more consistent with string-to-number.
1541 Use string_to_number to do the actual conversion; this avoids
1542 rounding errors and fixes some other screwups. Without this fix,
1543 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1544 (digit_to_number): Move earlier, for benefit of read_integer.
1545 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1546 not a digit in any supported base. (Bug#8602)
a108c10b 1547
ad5f9eea
PE
1548 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1549
aec1708a
PE
1550 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1551 to match comment at start of function. This also removes a
1552 GCC warning about overflow in a 32+64-bit port.
1553
47be4ab5
PE
1554 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1555
371cac43
PE
1556 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1557 Reported by Stefan Monnier in
1558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1559 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1560 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1561
d01a7826
PE
1562 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1563 (EMACS_UINTPTR): Likewise, with uintptr_t.
1564
7fd47d5c
PE
1565 * lisp.h: Prefer 64-bit EMACS_INT if available.
1566 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1567 on 32-bit hosts that have 64-bit int, so that they can access
1568 large files.
122b0c86
PE
1569 However, temporarily disable this change unless the temporary
1570 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1571
8727937b
PE
1572 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1573
8ac068ac
PE
1574 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1575 This removes an assumption that EMACS_INT and long are the same
1576 width as pointers. The assumption is true for Emacs porting targets
1577 now, but we want to make other targets possible.
1578 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1579 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1580 In the rest of the code, change types of integers that hold casted
1581 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1582 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1583 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1584 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1585 No need to cast type when ORing.
1586 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1587 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1588 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1589 assume EMACS_INT is the same width as char *.
1590 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1591 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1592 Remove no-longer-needed casts.
1593 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1594 (xg_tool_bar_help_callback, xg_make_tool_item):
1595 Use EMACS_INTPTR to hold an integer
1596 that will be cast to void *; this can avoid a GCC warning
1597 if EMACS_INT is not the same width as void *.
1598 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1599 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1600 (current_message_1, set_message_1):
1601 Use a local to convert to proper width without a cast.
1602 * xmenu.c (dialog_selection_callback): Likewise.
1603
ede49d71
PE
1604 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1605 Also, don't assume VALBITS / RAND_BITS is less than 5,
1606 and don't rely on undefined behavior when shifting a 1 left into
1607 the sign bit.
1608 * lisp.h (get_random): Change signature to match.
1609
2f30ecd0
PE
1610 * lread.c (hash_string): Use size_t, not int, for hash computation.
1611 Normally we prefer signed values; but hashing is special, because
1612 it's better to use unsigned division on hash table sizes so that
1613 the remainder is nonnegative. Also, size_t is the natural width
1614 for hashing into memory. The previous code used 'int', which doesn't
1615 retain enough info to hash well into very large tables.
1616 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1617
2a866e7b
PE
1618 * dbusbind.c: Don't possibly lose pointer info when converting.
1619 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1620 Use XPNTR rather than XHASH, so that the high-order bits of
1621 the pointer aren't lost when converting through void *.
1622
51639eac
PE
1623 * eval.c (Fautoload): Don't double-shift a pointer.
1624
92394119
PE
1625 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1626
dbdb9a7c
JB
16272011-05-06 Juanma Barranquero <lekktu@gmail.com>
1628
1629 * gnutls.c (DEF_GNUTLS_FN):
1630 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1631
db7a0b4f
AS
16322011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1633
1634 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1635 marker. (Bug#8610)
1636
f7ff1b0f 16372011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1638
1639 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1640 New version that can reserve upto 2GB of heap space.
1641
f7ff1b0f 16422011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1643
1644 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1645
639c109b
TZ
16462011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1647
1648 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1649 `gnutls_certificate_set_x509_key_file'.
1650
d2127135
JB
16512011-05-05 Juanma Barranquero <lekktu@gmail.com>
1652
1653 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1654 Update dependencies.
1655
e968f4f3
JB
16562011-05-04 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1659 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1660 Remove unused parameter `fildes'.
1661 * process.c (read_process_output, send_process): Don't pass it.
1662
84d358f0
JB
16632011-05-04 Juanma Barranquero <lekktu@gmail.com>
1664
1665 Fix previous change: the library cache is defined in w32.c.
1666 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1667 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1668
0898ca10
JB
16692011-05-04 Juanma Barranquero <lekktu@gmail.com>
1670
1671 Implement dynamic loading of GnuTLS on Windows.
1672
1673 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1674 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1675 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1676 Declare.
1677
1678 * gnutls.c (Qgnutls_dll): Define.
1679 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1680 (gnutls_*): Declare function pointers.
1681 (init_gnutls_functions): New function to initialize function pointers.
1682 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1683 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1684 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1685 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1686 (emacs_gnutls_write, emacs_gnutls_read)
1687 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1688 (Fgnutls_available_p): New function.
1689 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1690 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1691 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1692
1693 * image.c: Include w32.h.
1694 (Vimage_type_cache): Delete.
1695 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1696 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1697 (w32_delayed_load): Move to w32.c.
1698
1699 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1700
1701 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1702 (w32_delayed_load): Move from image.c. When loading a library, record
1703 its filename in the :loaded-from property of the library id.
1704 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1705 Initialize and staticpro them.
1706 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1707
1708 * process.c: Include lisp.h before w32.h, not after.
1709 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1710 instead of gnutls_record_check_pending.
1711
1712 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1713
ff4de4aa
TZ
17142011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1715
1716 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1717 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1718 as passed in.
1719
abe95abb
JD
17202011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1721
1722 * xterm.c (x_set_frame_alpha): Do not set property on anything
1723 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1724
e16e55d4
JB
17252011-05-02 Juanma Barranquero <lekktu@gmail.com>
1726
1727 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1728
bafcf6a5
JB
17292011-05-02 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1732 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1733 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1734 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1735 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1736 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1737 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1738 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1739 (Qgnutls_bootprop_callbacks_verify): Make static.
1740
e7a6747f
AS
17412011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1742
19ed11ba
AS
1743 * callproc.c: Indentation fixup.
1744
e7a6747f 1745 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1746 (wait_for_termination, interruptible_wait_for_termination):
1747 Move after wait_for_termination_1.
e7a6747f 1748
1ef14cb4
LMI
17492011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1750
1751 * sysdep.c (interruptible_wait_for_termination): New function
1752 which is like wait_for_termination, but allows keyboard
1753 interruptions.
1754
1755 * callproc.c (Fcall_process): Add (:file "file") as an option for
1756 the STDOUT buffer.
1757 (Fcall_process_region): Ditto.
1758
330d880c
EZ
17592011-04-30 Eli Zaretskii <eliz@gnu.org>
1760
8db90b73
EZ
1761 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1762 rather than `XVECTOR (FOO)->size'.
1763
330d880c
EZ
1764 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1765 inttypes.h, as a gnulib replacement is used if it not available in
1766 system headers.
1767
15cbd324
EZ
17682011-04-21 Eli Zaretskii <eliz@gnu.org>
1769
1770 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1771 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1772 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1773
1774 * coding.c (coding_alloc_by_realloc): Error out if destination
1775 will grow beyond MOST_POSITIVE_FIXNUM.
1776 (decode_coding_emacs_mule): Abort if there isn't enough place in
1777 charbuf for the composition carryover bytes. Reserve an extra
1778 space for up to 2 characters produced in a loop.
1779 (decode_coding_iso_2022): Abort if there isn't enough place in
1780 charbuf for the composition carryover bytes.
1781
17822011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1783
ae940cca
EZ
1784 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1785 aborting when %lld or %lll format is passed.
1786 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1787 %llo or %llx format is passed. (Bug#8545)
1788
03ab8921
EZ
1789 * window.c (window_scroll_line_based): Use a marker instead of
1790 simple variables to record original value of point. (Bug#7952)
1791
afda1437
EZ
1792 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1793 produced by %s or %c overflows available buffer space. (Bug#8545)
1794
f76dee0c
PE
17952011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1798 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1799
fdc5744d
JB
18002011-04-28 Juanma Barranquero <lekktu@gmail.com>
1801
1802 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1803
638f053a
JB
18042011-04-28 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * keyboard.c (Qdelayed_warnings_hook): Define.
1807 (command_loop_1): Run `delayed-warnings-hook'
1808 if Vdelayed_warnings_list is non-nil.
1809 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1810 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1811
d178f871
EZ
18122011-04-28 Eli Zaretskii <eliz@gnu.org>
1813
1814 * doprnt.c (doprnt): Don't return value smaller than the buffer
1815 size if the message was truncated. (Bug#8545).
1816
b124fd93
JB
18172011-04-28 Juanma Barranquero <lekktu@gmail.com>
1818
1819 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1820 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1821
e810457d
PE
18222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1823
1824 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1825
ea51cceb
JB
18262011-04-27 Juanma Barranquero <lekktu@gmail.com>
1827
1828 * makefile.w32-in: Update dependencies.
1829
94dcfacf
EZ
18302011-04-27 Eli Zaretskii <eliz@gnu.org>
1831
1832 Improve `doprnt' and its usage. (Bug#8545)
1833 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1834 `format_end'. Remove support for %l as a conversion specifier.
1835 Don't use xrealloc. Improve diagnostics when the %l size modifier
1836 is used. Update the commentary.
1837
1838 * eval.c (verror): Simplify calculation of size_t.
1839
1840 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1841 messages.
1842
f61f41d7
PE
18432011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1844
1845 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1846 change.
1847
96fb4434
PE
18482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1851 This makes this file independent of the recent pseudovector change.
1852
671875da 18532011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1854
69e9b5a3
PE
1855 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1856
b5f869a7 1857 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1858 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1859 Remove unused local.
c8926152 1860 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1861
841a1577 1862 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1863 GCC 4.6.0 optimizes based on type-based alias analysis.
1864 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1865 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1866 != &v->size, and therefore "v->size = 1; b->size = 2; return
1867 v->size;" must therefore return 1. This assumption is incorrect
1868 for Emacs, since it type-puns struct Lisp_Vector * with many other
1869 types. To fix this problem, this patch adds a new type struct
f904488f 1870 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1871 and pseudovectors, and helps optimizing compilers not get fooled
1872 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1873 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1874 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1875 the size member.
eab3844f
PE
1876 (XSETPVECTYPE): Rewrite in terms of new macro.
1877 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1878 This is a bit clearer, and further avoids the possibility of
1879 undesirable aliasing.
1880 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1881 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1882 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1883 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1884 (ASIZE): Now uses header.size rather than size.
1885 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1886 to avoid the hassle of writing XVECTOR (foo)->header.size.
1887 (struct vectorlike_header): New type.
eab3844f
PE
1888 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1889 object, to help avoid aliasing.
1890 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1891 (SUBRP): Likewise, since Lisp_Subr is a special case.
1892 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1893 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1894 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1895 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1896 changed to be "header.size" and "header.next".
1897 * buffer.h (struct buffer): Likewise.
1898 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1899 * frame.h (struct frame): Likewise.
1900 * process.h (struct Lisp_Process): Likewise.
1901 * termhooks.h (struct terminal): Likewise.
1902 * window.c (struct save_window_data, struct saved_window): Likewise.
1903 * window.h (struct window): Likewise.
1904 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1905 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1906 * buffer.c (init_buffer_once): Likewise.
1907 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1908 special case.
1909 * process.c (Fformat_network_address): Use local var for size,
1910 for brevity.
1911
0df1eac5
PE
1912 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1913
847ab9d1 1914 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1915 * data.c (atof): Remove decl; no longer used or needed.
1916 (digit_to_number): Move to lread.c.
1917 (Fstring_to_number): Use new string_to_number function, to be
1918 consistent with how the Lisp reader treats infinities and NaNs.
1919 Do not assume that floating-point numbers represent EMACS_INT
1920 without losing information; this is not true on most 64-bit hosts.
1921 Avoid double-rounding errors, by insisting on integers when
1922 parsing non-base-10 numbers, as the documentation specifies.
1923 * lisp.h (string_to_number): New decl, replacing ...
1924 (isfloat_string): Remove.
bc0a5c13 1925 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1926 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1927 appears to have been a coding error. Similarly, do not accept
1928 strings like +-1e0 as floating point numbers. Do not report
1929 overflow for integer overflows unless the base is not 10 which
1930 means we have no simple and reliable way to continue.
1931 Break out the floating-point parsing into a new
1932 function string_to_number, so that Fstring_to_number parses
1933 floating point numbers consistently with the Lisp reader.
04f2d78b 1934 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1935 (E_CHAR, EXP_INT): Remove, replacing with ...
1936 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1937 (string_to_number): New function, replacing isfloat_string.
1938 This function checks for valid syntax and produces the resulting
1939 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1940 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1941 so that overflow for non-base-10 numbers is reported only when
1942 there's no portable and simple way to convert to floating point.
452f4150 1943
67769ffc
PE
1944 * textprop.c (set_text_properties_1): Rewrite for clarity,
1945 and to avoid GCC warning about integer overflow.
1946
c20db43f
PE
1947 * intervals.h (struct interval): Use EMACS_INT for members
1948 where EMACS_UINT might cause problems. See
1949 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1950 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1951 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1952 All uses changed.
37aa2f85
PE
1953 (offset_intervals): Tell GCC not to worry about length overflow
1954 when negating a negative length.
c20db43f 1955
2538aa2f
PE
1956 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1957 (overrun_check_free): Likewise.
1958
f2d3008d
PE
1959 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1960 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1961 word size.
1962
ec8df744
PE
1963 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1964 (gnutls_make_error): Rename local to avoid shadowing.
1965 (gnutls_emacs_global_deinit): ifdef out; not used.
1966 (Fgnutls_boot): Use const for pointer to readonly storage.
1967 Comment out unused local. Fix pointer signedness problems.
1968
640ee02d
PE
1969 * lread.c (openp): Don't stuff size_t into an 'int'.
1970 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1971 about possible signed overflow.
1972
6048fb2a
PE
1973 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1974 (GDK_KEY_g): Don't define if already defined.
1975 (xg_prepare_tooltip): Avoid pointer signedness problem.
1976 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1977
fa3c87e1
PE
1978 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1979 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1980
2172544b
PE
1981 * xfns.c (Fx_window_property): Simplify a bit,
1982 to make a bit faster and to avoid GCC 4.6.0 warning.
1983 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1984
9b821a21
PE
1985 * fns.c (internal_equal): Don't assume size_t fits in int.
1986
3c616cfa
PE
1987 * alloc.c (compact_small_strings): Tighten assertion a little.
1988
c2982e87
PE
1989 Replace pEd with more-general pI, and fix some printf arg casts.
1990 * lisp.h (pI): New macro, generalizing old pEd macro to other
1991 conversion specifiers. For example, use "...%"pI"d..." rather
1992 than "...%"pEd"...".
1993 (pEd): Remove. All uses replaced with similar uses of pI.
1994 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1995 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1996 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1997 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1998 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1999 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2000 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2001 64-bit hosts.
2002 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2003 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2004 * print.c (safe_debug_print, print_object): Likewise.
2005 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2006 to int.
6f04d126
PE
2007 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2008 avoiding the 0 flag, which is not portable.
c2982e87
PE
2009 * process.c (Fmake_network_process): Use pI to avoid cast.
2010 * region-cache.c (pp_cache): Likewise.
2011 * xdisp.c (decode_mode_spec): Likewise.
2012 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2013 behavior on 64-bit hosts with printf arg.
6f04d126 2014 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2015 (x_stop_queuing_selection_requests): Likewise.
2016 (x_get_window_property): Don't truncate byte count to an 'int'
2017 when tracing.
0b432f21 2018
5e073ec7
PE
2019 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2020 here, since it parses constructs like leading '-' and spaces,
2021 which are not wanted; and it overflows with large numbers.
2022 Instead, simply match F[0-9]+, which is what is wanted anyway.
2023
36372bf9
PE
2024 * alloc.c: Remove unportable assumptions about struct layout.
2025 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2026 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2027 (allocate_vectorlike, make_pure_vector): Use the new macros,
2028 plus offsetof, to remove unportable assumptions about struct layout.
2029 These assumptions hold on all porting targets that I know of, but
2030 they are not guaranteed, they're easy to remove, and removing them
2031 makes further changes easier.
2032
0b432f21
PE
2033 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2034 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2035 (string_overrun_cookie): Now const. Use initializers that
2036 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2037 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2038 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2039 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2040 multiple of sizeof (EMACS_INT); it need not be, if
2041 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2042 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2043
895009e1
JB
20442011-04-26 Juanma Barranquero <lekktu@gmail.com>
2045
2046 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2047
6a7a1b0b
TZ
20482011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2049
2050 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2051 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2052 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2053
841a1577 20542011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2055
2056 * lisp.h (Qdebug): List symbol.
895009e1 2057 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2058 * keyboard.c (debug-on-event): New variable.
2059 (handle_user_signal): Break into debugger when debug-on-event
2060 matches the current signal symbol.
2061
f2d3ba6f
DN
20622011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2063
2064 * alloc.c (check_sblock, check_string_bytes)
2065 (check_string_free_list): Convert to standard C.
2066
42ce4c63
TZ
20672011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2068
2069 * w32.c (emacs_gnutls_push): Fix typo.
2070
825cd63c
EZ
20712011-04-25 Eli Zaretskii <eliz@gnu.org>
2072
fb11d64d
EZ
2073 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2074 "cast to pointer from integer of different size".
2075
825cd63c
EZ
2076 Improve doprnt and its use in verror. (Bug#8545)
2077 * doprnt.c (doprnt): Document the set of format control sequences
2078 supported by the function. Use SAFE_ALLOCA instead of always
2079 using `alloca'.
2080
2081 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2082 is one byte too soon. Don't use xrealloc; instead xfree and
2083 xmalloc anew.
2084
e061a11b
TZ
20852011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2086
2087 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2088 callbacks stage.
2089
2090 * gnutls.c: Renamed global_initialized to
2091 gnutls_global_initialized. Added internals for the
2092 :verify-hostname-error, :verify-error, and :verify-flags
2093 parameters of `gnutls-boot' and documented those parameters in the
2094 docstring. Start callback support.
2095 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2096 unless a fatal error occured. Call gnutls_alert_send_appropriate
2097 on error. Return error code.
2098 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2099 (emacs_gnutls_read): Likewise.
2100 (Fgnutls_boot): Return handshake error code.
2101 (emacs_gnutls_handle_error): New function.
2102 (wsaerror_to_errno): Likewise.
2103
2104 * w32.h (emacs_gnutls_pull): Add prototype.
2105 (emacs_gnutls_push): Likewise.
2106
2107 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2108 (emacs_gnutls_push): Likewise.
2109
21102011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2111
2112 * process.c (wait_reading_process_output): Check if GnuTLS
2113 buffered some data internally if no FDs are set for TLS
2114 connections.
2115
2116 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2117 (LIBS): Link to USER_LIBS.
2118 ($(BLD)/gnutls.$(0)): New target.
2119
fa6996bc
EZ
21202011-04-24 Eli Zaretskii <eliz@gnu.org>
2121
eb35682e
EZ
2122 * xdisp.c (handle_single_display_spec): Rename the
2123 display_replaced_before_p argument into display_replaced_p, to
2124 make it consistent with the commentary. Fix typos in the
2125 commentary.
2126
e2ad650c
EZ
2127 * textprop.c (syms_of_textprop): Remove dead code.
2128 (copy_text_properties): Delete obsolete commentary about an
2129 interface that was deleted long ago. Fix typos in the description
2130 of arguments.
2131
1b2de274
EZ
2132 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2133 to changes in oldXMenu/XMenu.h from 2011-04-16.
2134 <menu_help_message, prev_menu_help_message>: Constify.
2135 (IT_menu_make_room): menu->help_text is now `const char **';
2136 adjust.
2137
2138 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2139 to changes in oldXMenu/XMenu.h from 2011-04-16.
2140 (struct XMenu): Declare `help_text' `const char **'.
2141
2142 * xfaces.c <Qunspecified>: Make extern again.
2143
2144 * syntax.c: Include sys/types.h before including regex.h, as
2145 required by Posix.
2146
762b15be
EZ
2147 * doc.c (get_doc_string): Improve the format passed to `error'.
2148
2149 * doprnt.c (doprnt): Improve commentary.
2150
2151 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2152
2153 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2154 them with etags.
2155
f1052e5d
EZ
2156 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2157 changes in globals.h immediately force recompilation.
762b15be
EZ
2158 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2159 $(CURDIR)/s/ms-w32.h.
2160 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2161
fa6996bc
EZ
2162 * character.c (Fchar_direction): Function deleted.
2163 (syms_of_character): Don't defsubr it.
2164 <char-direction-table>: Deleted.
2165
e6c3da20
EZ
21662011-04-23 Eli Zaretskii <eliz@gnu.org>
2167
2168 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2169 * doprnt.c: Include limits.h.
2170 (SIZE_MAX): New macro.
04f2d78b
CB
2171 (doprnt): Return a size_t value. 2nd arg is now size_t.
2172 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2173 Improve overflow protection. Support `l' modifier for integer
2174 conversions. Support %l conversion. Don't assume an EMACS_INT
2175 argument for integer conversions and for %c.
2176
2177 * lisp.h (doprnt): Restore prototype.
2178
2179 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2180 $(SRC)/character.h.
2181
2182 * Makefile.in (base_obj): Add back doprnt.o.
2183
2184 * deps.mk (doprnt.o): Add back prerequisites.
2185 (callint.o): Depend on character.h.
2186
2187 * eval.c (internal_lisp_condition_case): Include the handler
2188 representation in the error message.
2189 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2190 when breaking from the loop.
2191
2192 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2193
2194 * callint.c (Fcall_interactively): When displaying error message
2195 about invalid control letter, pass the character's codepoint, not
2196 a pointer to its multibyte form. Improve display of the character
2197 in octal and display also its hex code.
2198
2199 * character.c (char_string): Use %x to display the (unsigned)
2200 codepoint of an invalid character, to avoid displaying a bogus
2201 negative value.
2202
2203 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2204 `error', not SYMBOL_NAME itself.
2205
2206 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2207 character arguments to `error'.
2208
2209 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2210 to `error' in error message about FINAL_CHAR argument. Make sure
2211 FINAL_CHAR is a character, and use %c when it is passed as
2212 argument to `error'.
2213
4ffd0d6b 22142011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2215
2216 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2217
2218 * w32.c: Include <time.h>.
2219 (sys_localtime): New function.
2220
4ffd0d6b 22212011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2222
2223 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2224
4ffd0d6b 2225 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2226
4ffd0d6b 22272011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2228
4ffd0d6b
GM
2229 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2230 zombies (Bug#8467).
aac0c6e3 2231
04c56954
EZ
22322011-04-19 Eli Zaretskii <eliz@gnu.org>
2233
2234 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2235 gl_state.e_property when gl_state.object is Qt.
2236
2237 * insdel.c (make_gap_larger): Remove limitation of buffer size
2238 to <= INT_MAX.
2239
16a43933
CY
22402011-04-18 Chong Yidong <cyd@stupidchicken.com>
2241
2242 * xdisp.c (lookup_glyphless_char_display)
2243 (produce_glyphless_glyph): Handle cons cell entry in
2244 glyphless-char-display.
2245 (Vglyphless_char_display): Document it.
2246
2247 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2248 glyphless-char-display.
2249
4581706e
CY
22502011-04-17 Chong Yidong <cyd@stupidchicken.com>
2251
2252 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2253
2254 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2255
2256 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2257 definition for no-X builds.
2258
4887c6e2 22592011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2260
fd35b6f9
PE
2261 Static checks with GCC 4.6.0 and non-default toolkits.
2262
5c1ccb01
PE
2263 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2264
006c5daa
PE
2265 * process.c (keyboard_bit_set): Define only if SIGIO.
2266 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2267 (send_process): Repair possible setjmp clobbering.
2268
efc736d3
PE
2269 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2270
4e2fe2e6
PE
2271 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2272
f97334a2
PE
2273 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2274
4e75f29d
PE
2275 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2276 Define only if needed.
2277
90efadd1
PE
2278 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2279 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2280 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2281
3c647824
PE
2282 * dispextern.h (struct redisplay_interface): Rename param
2283 to avoid shadowing.
e264f262 2284 * termhooks.h (struct terminal): Likewise.
761383f4 2285 * xterm.c (xembed_send_message): Likewise.
3c647824 2286
b58c5c4a
PE
2287 * insdel.c (make_gap_smaller): Define only if
2288 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2289
cad59032
PE
2290 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2291 it.
2292
c339dc2e
PE
2293 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2294 so that we aren't warned about unused symbols.
2295
91a3e27b
PE
2296 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2297
399c71d3 2298 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2299
8ffc96f5
PE
2300 * xfns.c (x_real_positions): Mark locals as initialized.
2301
eef9bc79
PE
2302 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2303
098db9dd
PE
2304 * xterm.c: Fix problems found by static analysis with other toolkits.
2305 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2306 (x_dispatch_event): Declare static if USE_GTK, and
2307 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2308 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2309 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2310 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2311 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2312
eb18f6cc
PE
2313 * xmenu.c (menu_help_callback): Pointer type fixes.
2314 Use const pointers when pointing at readonly data. Avoid pointer
2315 signedness clashes.
2316 (FALSE): Remove unused macro.
2317 (update_frame_menubar): Remove unused decl.
2318
1fe72bf8
PE
2319 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2320
60d9e1db
PE
2321 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2322 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2323 (single_menu_item): Rename local to avoid shadowing.
2324
39261c26
PE
2325 * keyboard.c (make_lispy_event): Remove unused local var.
2326
018c5e19
PE
2327 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2328 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2329
63d2b86e
PE
2330 * bitmaps: Change bitmaps from unsigned char back to the X11
2331 compatible char. Avoid the old compiler warnings about
2332 out-of-range initializers by using, for example, '\xab' rather
2333 than 0xab.
2334
aefd87e1
PE
2335 * xgselect.c (xgselect_initialize): Check vs interface
2336 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2337
bf501fb9
PE
2338 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2339
e9829fdf
PE
2340 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2341 to read-only memory.
2342
1086c095
PE
2343 * fns.c (vector): Remove; this old hack is no longer needed.
2344
2baccd04 2345 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2346 Remove unused var.
dde42981 2347 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2348
72391843 2349 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2350
436c16df 2351 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2352 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2353 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2354
92bb796d 2355 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2356 (x_term_init): Remove local to avoid shadowing.
92bb796d 2357
764430a3 2358 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2359
2360 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2361 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2362
d1dfb56c
EZ
23632011-04-16 Eli Zaretskii <eliz@gnu.org>
2364
c4354cb4
EZ
2365 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2366
d1dfb56c
EZ
2367 Fix regex.c, syntax.c and friends for buffers > 2GB.
2368 * syntax.h (struct gl_state_s): Declare character position members
2369 EMACS_INT.
2370
2371 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2372
04f2d78b
CB
2373 * textprop.c (verify_interval_modification, interval_of):
2374 Declare arguments EMACS_INT.
d1dfb56c
EZ
2375
2376 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2377 EMACS_INT.
2378
2379 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2380
2381 * indent.c (Fvertical_motion): Local variable it_start is now
2382 EMACS_INT.
2383
2384 * regex.c (re_match, re_match_2, re_match_2_internal)
2385 (bcmp_translate, regcomp, regexec, print_double_string)
2386 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2387 (re_compile_pattern, re_exec): Declare arguments and local
2388 variables `size_t' and `ssize_t' and return values `regoff_t', as
2389 appropriate.
2390 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2391 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2392 <compile_stack_type>: `size' and `avail' are now `size_t'.
2393
2394 * regex.h <regoff_t>: Use ssize_t, not int.
2395 (re_search, re_search_2, re_match, re_match_2): Arguments that
2396 specify buffer/string position and length are now ssize_t and
2397 size_t. Return type is regoff_t.
2398
613052cd
BK
23992011-04-16 Ben Key <bkey76@gmail.com>
2400
2401 * nsfont.m: Fixed bugs in ns_get_family and
2402 ns_descriptor_to_entity that were caused by using free to
2403 deallocate memory blocks that were allocated by xmalloc (via
2404 xstrdup). This caused Emacs to crash when compiled with
2405 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2406 --enable-checking=xmallocoverrun). xfree is now used to
2407 deallocate these memory blocks.
2408
4170f62f 24092011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2410
71b41406
PE
2411 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2412
9587a89d
PE
2413 emacs_write: Accept and return EMACS_INT for sizes.
2414 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2415 et seq.
2416 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2417 Accept and return EMACS_INT.
2418 (emacs_gnutls_write): Return the number of bytes written on
2419 partial writes.
2420 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2421 (emacs_read, emacs_write): Remove check for negative size, as the
2422 Emacs source code has been audited now.
9587a89d
PE
2423 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2424 (emacs_read, emacs_write): Use it.
273a5f82
PE
2425 * process.c (send_process): Adjust to the new signatures of
2426 emacs_write and emacs_gnutls_write. Do not attempt to store
2427 a byte offset into an 'int'; it might overflow.
9587a89d 2428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2429
3e047f51
PE
2430 * sound.c: Don't assume sizes fit in 'int'.
2431 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2432 Return EMACS_INT, not int.
3e047f51 2433 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2434 Accept EMACS_INT, not int.
2435 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2436 record read return values.
2437
cc39a9db
BK
24382011-04-15 Ben Key <bkey76@gmail.com>
2439
c9d0ec6d
JB
2440 * keyboard.c (Qundefined): Don't declare static since it is used
2441 in nsfns.m.
2442 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2443 static since they are used in nsfont.m.
cc39a9db 2444
6c60eb9f
SM
24452011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2446
2447 * process.c (Qprocessp): Don't declare static.
2448 * lisp.h (Qprocessp): Declare again.
2449
7990b61a
JB
24502011-04-15 Juanma Barranquero <lekktu@gmail.com>
2451
2452 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2453
5d4cb038
PE
24542011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2455
8bd7b830 2456 Improve C-level modularity by making more things 'static'.
cd64ea1d 2457
e3b27b31
PE
2458 Don't publish debugger-only interfaces to other modules.
2459 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2460 (verify_bytepos, count_markers): Move decls to the only modules
2461 that need them.
2462 * region-cache.h (pp_cache): Likewise.
2463 * window.h (check_all_windows): Likewise.
2464 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2465
5d4cb038
PE
2466 * sysdep.c (croak): Now static, if
2467 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2468 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2469
2470 * alloc.c (refill_memory_reserve): Now static if
2471 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2472 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2473
e87b6180
PE
2474 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2475 Define only if USE_LUCID.
2476
ac64929e
PE
2477 * xrdb.c (x_customization_string, x_rm_string): Now static.
2478
6f37259d
PE
2479 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2480 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2481
1683e3ab
PE
2482 * xdisp.c (draw_row_with_mouse_face): Now static.
2483 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2484
de9c2632
PE
2485 * window.h (check_all_windows): Mark externally visible.
2486
2b96acb7
PE
2487 * window.c (window_deletion_count): Now static.
2488
2489 * undo.c: Make symbols static if they're not exported.
2490 (last_undo_buffer, last_boundary_position, pending_boundary):
2491 Now static.
2492
50436f33
PE
2493 * textprop.c (interval_insert_behind_hooks): Now static.
2494 (interval_insert_in_front_hooks): Likewise.
2495
64520e5c
PE
2496 * term.c: Make symbols static if they're not exported.
2497 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2498 (max_frame_lines, tty_set_terminal_modes):
2499 (tty_reset_terminal_modes, tty_turn_off_highlight):
2500 (get_tty_terminal): Now static.
2501 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2502 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2503 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2504 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2505 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2506
1fa53021
PE
2507 * sysdep.c: Make symbols static if they're not exported.
2508 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2509 Now static.
2510 (sigprocmask_set, full_mask): Remove; unused.
2511 (wait_debugging): Mark as visible.
2512 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2513 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2514
d4b43b22
PE
2515 * syntax.c (syntax_temp): Define only if !__GNUC__.
2516
b7c513d0
PE
2517 * sound.c (current_sound_device, current_sound): Now static.
2518
989b29ad
PE
2519 * search.c (searchbufs, searchbuf_head): Now static.
2520
13a55a78
PE
2521 * scroll.c (scroll_cost): Remove; unused.
2522 * dispextern.h (scroll_cost): Remove decl.
2523
de68a1fc
PE
2524 * region-cache.h (pp_cache): Mark as externally visible.
2525
40ccffa6
PE
2526 * process.c: Make symbols static if they're not exported.
2527 (process_tick, update_tick, create_process, chan_process):
2528 (Vprocess_alist, proc_buffered_char, datagram_access):
2529 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2530 (deactivate_process): Mark defn as static, as well as decl.
2531 * lisp.h (create_process): Remove decl.
2532 * process.h (chan_process, Vprocess_alist): Remove decls.
2533
ad64fc97
PE
2534 * print.c: Make symbols static if they're not exported.
2535 (print_depth, new_backquote_output, being_printed, print_buffer):
2536 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2537 (print_interval, print_number_index, initial_stderr_stream):
2538 Now static.
2539 * lisp.h (Fprinc): Remove decl.
2540 (debug_output_compilation_hack): Mark as externally visible.
2541
adddb265
PE
2542 * sysdep.c (croak): Move decl from here to syssignal.h.
2543 * syssignal.h (croak): Put it here, so the API can be checked when
2544 'croak' is called from dissociate_if_controlling_tty.
2545
1717ede2
PE
2546 * minibuf.c: Make symbols static if they're not exported.
2547 (minibuf_save_list, choose_minibuf_frame): Now static.
2548 * lisp.h (choose_minibuf_frame): Remove decl.
2549
fa5fb2bc
PE
2550 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2551
1e3890d1
PE
2552 * lread.c: Make symbols static if they're not exported.
2553 (read_objects, initial_obarray, oblookup_last_bucket_number):
2554 Now static.
2555 (make_symbol): Remove; unused.
2556 * lisp.h (initial_obarray, make_symbol): Remove decls.
2557
8a1414fa
PE
2558 * keyboard.c: Make symbols static if they're not exported.
2559 (single_kboard, recent_keys_index, total_keys, recent_keys):
2560 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2561 (this_single_command_key_start, echoing, last_auto_save):
2562 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2563 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2564 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2565 (Vlispy_mouse_stem, double_click_count):
2566 Now static.
2567 (force_auto_save_soon): Define only if SIGDANGER.
2568 (ignore_mouse_drag_p): Now static if
2569 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2570 (print_help): Remove; unused.
2571 (stop_character, last_timer_event): Mark as externally visible.
2572 * keyboard.h (ignore_mouse_drag_p): Declare only if
2573 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2574 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2575 * lisp.h (echoing): Remove decl.
2576 (force_auto_save_soon): Declare only if SIGDANGER.
2577 * xdisp.c (redisplay_window): Simplify code, to make it more
2578 obvious that ignore_mouse_drag_p is not accessed if !defined
2579 USE_GTK && !defined HAVE_NS.
2580
93ea6e8f
PE
2581 * intervals.c: Make symbols static if they're not exported.
2582 (merge_properties_sticky, merge_interval_right, delete_interval):
2583 Now static.
2584 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2585
77382fcc
PE
2586 * insdel.c: Make symbols static if they're not exported.
2587 However, leave prepare_to_modify_buffer alone. It's never
2588 called from outside this function, but that appears to be a bug.
2589 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2590 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2591 (adjust_after_replace_noundo): Remove; unused.
2592 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2593 (signal_before_change): Remove decls.
77382fcc 2594
9306c32e
PE
2595 * indent.c (val_compute_motion, val_vmotion): Now static.
2596
cd44d2eb
PE
2597 * image.c: Make symbols static if they're not exported.
2598 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2599 if USE_GTK.
2600 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2601 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2602
ad9a7a06
PE
2603 * fringe.c (standard_bitmaps): Now static.
2604 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2605
81626931
PE
2606 * frame.c: Make symbols static if they're not exported.
2607 (x_report_frame_params, make_terminal_frame): Now static.
2608 (get_frame_param): Now static, unless HAVE_NS.
2609 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2610 (x_get_resource_string): Remove; not used.
2611 * frame.h (make_terminal_frame, x_report_frame_params):
2612 (x_get_resource_string); Remove decls.
2613 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2614 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2615
239f9db9
PE
2616 * font.c, fontset.c: Make symbols static if they're not exported.
2617 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2618 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2619 * font.c (font_close_object): Now static.
2620 * font.h (font_close_object): Remove.
2621 * fontset.c (FONTSET_OBJLIST): Remove.
2622 (free_realized_fontset) #if-0 the body, which does nothing.
2623 (face_suitable_for_char_p): #if-0, as it's never called.
2624 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2625 * xfaces.c (face_at_string_position):
2626 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2627 since 0 is always ASCII.
2628
dfcf3579
PE
2629 * fns.c (weak_hash_tables): Now static.
2630
5045092b
PE
2631 * fileio.c: Make symbols static if they're not exported.
2632 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2633 (Vwrite_region_annotation_buffers): Now static.
2634
57a96f5c
PE
2635 * eval.c: Make symbols static if they're not exported.
2636 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2637 * lisp.h (backtrace_list): Remove decl.
2638
35f08c38
PE
2639 * emacs.c: Make symbols static if they're not exported.
2640 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2641 (fatal_error_code, fatal_error_signal_hook, standard_args):
2642 Now static.
2643 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2644 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2645 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2646 * lisp.h (fatal_error_signal_hook): Remove decl.
2647 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2648
f44bd759
PE
2649 * editfns.c: Move a (normally-unused) function to its only use.
2650 * editfns.c, lisp.h (get_operating_system_release): Remove.
2651 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2652 worth the hassle of breaking this out.
2653
b532497d
PE
2654 * xterm.c: Make symbols static if they're not exported.
2655 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2656 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2657 (x_destroy_window, x_delete_display):
2658 Now static.
2659 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2660 (x_mouse_leave): Remove; unused.
2661 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2662 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2663 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2664 Remove decls.
2665 (x_mouse_leave): Declare only if WINDOWSNT.
2666 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2667 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2668 USE_X_TOOLKIT.
2669
1675728f
PE
2670 * ftxfont.c: Make symbols static if they're not exported.
2671 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2672 HAVE_FREETYPE.
2673 * font.h (ftxfont_driver): Likewise.
2674
e4cebfca
PE
2675 * xfns.c: Make symbols static if they're not exported.
2676 (x_last_font_name, x_display_info_for_name):
2677 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2678 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2679 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2680 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2681 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2682 (last_show_tip_args): Now static.
2683 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2684 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2685 (x_screen_planes): Remove; unused.
2686 * dispextern.h (x_screen_planes): Remove decl.
2687
5bf46f05
PE
2688 * dispnew.c: Make symbols static if they're not exported.
2689 * dispextern.h (redraw_garbaged_frames, scrolling):
2690 (increment_row_positions): Remove.
2691 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2692 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2693 Now static.
2694 (redraw_garbaged_frames): Remove; unused.
2695
435f4c28
PE
2696 * xfaces.c: Make symbols static if they're not exported.
2697 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2698 Remove decls.
2699 * xterm.h (defined_color): Remove decls.
2700 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2701 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2702 (menu_face_changed_default, defined_color, free_realized_face):
2703 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2704 (ascii_face_of_lisp_face): Remove; unused.
2705
8524aef3
PE
2706 * xdisp.c: Make symbols static if they're not exported.
2707 * dispextern.h (scratch_glyph_row, window_box_edges):
2708 (glyph_to_pixel_coords, set_cursor_from_row):
2709 (get_next_display_element, set_iterator_to_next):
2710 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2711 (show_mouse_face): Remove decls
2712 * frame.h (message_buf_print): Likewise.
2713 * lisp.h (pop_message, set_message, check_point_in_composition):
2714 Likewise.
2715 * xterm.h (set_vertical_scroll_bar): Likewise.
2716 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2717 (message_buf_print, scratch_glyph_row, displayed_buffer):
2718 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2719 (get_next_display_element, show_mouse_face, window_box_edges):
2720 (frame_to_window_pixel_xy, check_point_in_composition):
2721 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2722 (glyph_to_pixel_coords): Remove; unused.
2723
16390cd2
PE
2724 * dired.c (file_name_completion): Now static.
2725
2726 * dbusbind.c (xd_in_read_queued_messages): Now static.
2727
a25f4dfa
PE
2728 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2729 * data.c (circular_list_error): Remove.
2730
14a9c8df
PE
2731 * commands.h (last_point_position, last_point_position_buffer):
2732 (last_point_position_window): Remove decls.
2733 * keyboard.c: Make these variables static.
2734
04f2d78b
CB
2735 * coding.h (coding, code_convert_region, encode_coding_gap):
2736 Remove decls.
74ab6df5
PE
2737 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2738 (iso_code_class, detect_coding, code_convert_region): Now static.
2739 (encode_coding_gap): Remove; unused.
2740
38dfbee1
PE
2741 * chartab.c (chartab_chars, chartab_bits): Now static.
2742
a2cb4e63
PE
2743 * charset.h (charset_iso_8859_1): Remove decl.
2744 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2745 Now static.
2746
127198fd
PE
2747 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2748 * ccl.c (Vccl_program_table): Now static.
2749 (check_ccl_update): Remove; unused.
2750
d85b608f
PE
2751 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2752 * category.h: ... from here.
2753 * category.c (check_category_table, set_category_set): Now static.
2754
31cd66f3
PE
2755 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2756 * lisp.h: Remove these decls.
2757
c358e587
PE
2758 * buffer.c (buffer_count): Remove unused var.
2759
e78aecca
PE
2760 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2761 so that it's not optimized away.
2762 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2763 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2764 exported only to the debugger.
2765
e192d7d3 2766 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2767 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2768
92470028
PE
2769 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2770 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2771 was inaccessible from Lisp.
2772 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2773 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2774
244ed907
PE
2775 alloc.c: Import and export fewer symbols, and remove unused items.
2776 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2777 is defined.
2778 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2779 it's not optimized away by whole-program optimization.
2780 (message_enable_multibyte, free_misc): Remove.
2781 (catchlist, handlerlist, mark_backtrace):
2782 Declare only if BYTE_MARK_STACK.
2783 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2784 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2785 (message_enable_multibyte): Remove decl.
2786 (free_misc, interval_free_list, float_block, float_block_index):
2787 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2788 (cons_free_list, last_marked_index):
2789 Now static.
2790 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2791 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2792 (mark_backtrace): Define only if BYTE_MARK_STACK.
2793 * xdisp.c (message_enable_multibyte): Now static.
2794
61c2b50e 2795 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2796 This makes it easier for human readers (and static analyzers)
2797 to see whether these variables are used from other modules.
2798 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2799 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2800 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2801 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2802 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2803 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2804 * xmenu.c, xselect.c:
2805 Declare Q* vars static if they are not used in other modules.
2806 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2807 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2808 Remove decls of unexported vars.
2809 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2810
95c82688
PE
2811 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2812
16a97296
PE
2813 Make Emacs functions such as Fatom 'static' by default.
2814 This makes it easier for human readers (and static analyzers)
2815 to see whether these functions can be called from other modules.
2816 DEFUN now defines a static function. To make the function external
2817 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2818 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2819 (Finit_image_library):
16a97296
PE
2820 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2821 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2822 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2823 Remove decls, since these functions are now static.
2824 (Funintern, Fget_internal_run_time): New decls, since these functions
2825 were already external.
95c82688 2826
16a97296
PE
2827 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2828 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2829 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2830 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2831 * keyboard.c, keymap.c, lread.c:
2832 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2833 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2834 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2835 Mark functions with DEFUE instead of DEFUN,
2836 if they are used in other modules.
2837 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2838 decls for now-static functions.
2839 * buffer.h (Fdelete_overlay): Remove decl.
2840 * callproc.c (Fgetenv_internal): Mark as internal.
2841 * composite.c (Fremove_list_of_text_properties): Remove decl.
2842 (Fcomposition_get_gstring): New forward static decl.
2843 * composite.h (Fcomposite_get_gstring): Remove decl.
2844 * dired.c (Ffile_attributes): New forward static decl.
2845 * doc.c (Fdocumntation_property): New forward static decl.
2846 * eval.c (Ffetch_bytecode): New forward static decl.
2847 (Funintern): Remove extern decl; now in .h file where it belongs.
2848 * fileio.c (Fmake_symbolic_link): New forward static decl.
2849 * image.c (Finit_image_library): New forward static decl.
2850 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2851 * intervals.h (Fprevious_property_change):
2852 (Fremove_list_of_text_properties): Remove decls.
2853 * keyboard.c (Fthis_command_keys): Remove decl.
2854 (Fcommand_execute): New forward static decl.
2855 * keymap.c (Flookup_key): New forward static decl.
2856 (Fcopy_keymap): Now static.
2857 * keymap.h (Flookup_key): Remove decl.
2858 * process.c (Fget_process): New forward static decl.
2859 (Fprocess_datagram_address): Mark as internal.
2860 * syntax.c (Fsyntax_table_p): New forward static decl.
2861 (skip_chars): Remove duplicate decl.
2862 * textprop.c (Fprevious_property_change): New forward static decl.
2863 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2864 Now internal.
2865 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2866 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2867
785bbd42
PE
2868 * editfns.c (Fformat): Remove unreachable code.
2869
8b913b57
AS
28702011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2871
2872 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2873 change. (Bug#8496)
2874
a6744a35
EZ
28752011-04-13 Eli Zaretskii <eliz@gnu.org>
2876
2877 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2878 when at ZV. (Bug#8487)
2879
e7974947
AS
28802011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2881
baad03f0
AS
2882 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2883 (Bug#8437)
2884 * keyboard.c (parse_tool_bar_item): Likewise.
2885 * sound.c (sound_cleanup, alsa_close): Likewise.
2886 * termcap.c (tgetent): Likewise.
2887 * xfns.c (x_default_font_parameter): Likewise.
2888 * xsettings.c (read_and_apply_settings): Likewise.
2889
e7974947
AS
2890 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2891 (overrun_check_free): Protoize.
2892
28272684
PE
28932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2894
2895 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2896 since callers should never pass a negative size.
2897 Change the signature to match that of plain 'read' and 'write'; see
2898 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2899 * lisp.h: Update prototypes of emacs_write and emacs_read.
2900
11997c76
EZ
29012011-04-11 Eli Zaretskii <eliz@gnu.org>
2902
2903 * xdisp.c (redisplay_window): Don't try to determine the character
2904 position of the scroll margin if the window start point w->startp
e896f03c 2905 is outside the buffer's accessible region. (Bug#8468)
11997c76 2906
8a2cbd72
EZ
29072011-04-10 Eli Zaretskii <eliz@gnu.org>
2908
2909 Fix write-region and its subroutines for buffers > 2GB.
2910 * fileio.c (a_write, e_write): Modify declaration of arguments and
2911 local variables to support buffers larger than 2GB.
2912 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2913
2914 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2915 argument, local variables, and return value.
2916
2917 * lisp.h: Update prototypes of emacs_write and emacs_read.
2918
2919 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2920
4073e537 29212011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2922
1ebfdcb6
PE
2923 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2924
b2ded58d
PE
2925 Fix more problems found by GCC 4.6.0's static checks.
2926
7d66342c
PE
2927 * xdisp.c (vmessage): Use a better test for character truncation.
2928
bbf47d44
PE
2929 * charset.c (load_charset_map): <, not <=, for optimization,
2930 and to avoid potential problems with integer overflow.
9248994d 2931 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2932 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2933 * editfns.c (Fformat): Likewise.
1e69125e 2934 * syntax.c (skip_chars): Likewise.
3befa583 2935
e3019616
PE
2936 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2937 This also lets GCC 4.6.0 generate slightly better loop code.
2938
becfa255
PE
2939 * callint.c (Fcall_interactively): <, not <=, for optimization.
2940 (Fcall_interactively): Count the number of arguments produced,
2941 not the number of arguments given. This is simpler and lets GCC
2942 4.6.0 generate slightly better code.
2943
dae0cd48
PE
2944 * ftfont.c: Distingish more carefully between FcChar8 and char.
2945 The previous code passed unsigned char * to a functions like
2946 strlen and xstrcasecmp that expect char *, which does not
2947 conform to the C standard.
2948 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2949 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2950 char * when the C standard requires it.
2951
76032d70
PE
2952 * keyboard.c (read_char): Remove unused var.
2953
eb3f1cc8
PE
2954 * eval.c: Port to Windows vsnprintf (Bug#8435).
2955 Include <limits.h>.
2956 (SIZE_MAX): Define if the headers do not.
2957 (verror): Do not give up if vsnprintf returns a negative count.
2958 Instead, grow the buffer. This ports to Windows vsnprintf, which
2959 does not conform to C99. Problem reported by Eli Zaretskii.
2960 Also, simplify the allocation scheme, by avoiding the need for
2961 calling realloc, and removing the ALLOCATED variable.
2962
70476b54
PE
2963 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2964
12020a9e
PE
2965 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2966 But keep the doprint source code for now, as we might revamp it
2967 and use it again (Bug#8435).
ea6c7ae6
PE
2968 * lisp.h (doprnt): Remove.
2969 * Makefile.in (base_obj): Remove doprnt.o.
2970 * deps.mk (doprnt.o): Remove.
2971
5fdb398c
PE
2972 error: Print 32- and 64-bit integers portably (Bug#8435).
2973 Without this change, on typical 64-bit hosts error ("...%d...", N)
2974 was used to print both 32- and 64-bit integers N, which relied on
2975 undefined behavior.
2976 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2977 New macro.
2978 * lisp.h (error, verror): Mark as printf-like functions.
2979 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2980 Report overflow in size calculations when allocating printf buffer.
2981 Do not truncate output string at its first null byte.
2982 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2983 Truncate the output at a character boundary, since vsnprintf does not
2984 do that.
2985 * charset.c (check_iso_charset_parameter): Convert internal
2986 character to string before calling 'error', since %c now has the
2987 printf meaning.
2988 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2989 overflow when computing char to be passed to 'error'. Do not
2990 pass Lisp_Object to 'error'; pass the integer instead.
2991 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2992 formatted with plain %d.
2993
b189fa66
PE
2994 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2995
bff87ef0
PE
2996 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2997
7e2cac20
PE
2998 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2999
ce4d90b5
PE
3000 * xterm.c (x_catch_errors): Remove duplicate declaration.
3001
266c9547
PE
3002 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3003
79c49ad2
PE
3004 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3005
368f4090
JM
30062011-04-10 Jim Meyering <meyering@redhat.com>
3007
3008 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3009 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3010 return ssize_t not "int", and use size_t as the buffer length.
3011 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3012 * gnutls.h: Update declarations.
3013 * process.c (read_process_output): Use ssize_t, to match.
3014 (send_process): Likewise.
3015
a32d4040
CY
30162011-04-09 Chong Yidong <cyd@stupidchicken.com>
3017
3018 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3019
8546720e 30202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3021
04f2d78b
CB
3022 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3023 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3024
8546720e
GM
3025 * xterm.c (handle_one_xevent):
3026 * xmenu.c (create_and_show_popup_menu):
3027 * xselect.c (x_decline_selection_request)
3028 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3029
0a2f5c1a 30302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3031
3032 Fix some uses of `int' instead of EMACS_INT.
3033 * search.c (string_match_1, fast_string_match)
3034 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3035 (scan_buffer, find_next_newline_no_quit)
3036 (find_before_next_newline, search_command, Freplace_match)
3037 (Fmatch_data): Make some `int' variables be EMACS_INT.
3038
3039 * xdisp.c (display_count_lines): 3rd argument and return value now
3040 EMACS_INT. All callers changed.
3041 (pint2hrstr): Last argument is now EMACS_INT.
3042
3043 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3044 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3045 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3046 (decode_coding_utf_16, decode_coding_emacs_mule)
3047 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3048 (decode_coding_ccl, decode_coding_charset)
3049 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3050 (decode_coding_iso_2022, decode_coding_emacs_mule)
3051 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3052 <char_offset, last_offset>: Declare EMACS_INT.
3053 (encode_coding_utf_8, encode_coding_utf_16)
3054 (encode_coding_emacs_mule, encode_invocation_designation)
3055 (encode_designation_at_bol, encode_coding_iso_2022)
3056 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3057 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3058 Declare EMACS_INT.
3059 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3060 (encode_invocation_designation): Last argument P_NCHARS is now
3061 EMACS_INT.
3062 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3063 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3064
3065 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3066 All users changed.
3067
3068 * ccl.c (Fccl_execute_on_string): Declare some variables
3069 EMACS_INT.
3070
8546720e 30712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3072
3073 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3074
4e19a977
CS
30752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3076
3077 * process.c (Fformat_network_address): Doc fix.
3078
87302331
R
30792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3080
3081 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3082
cbb59342
CY
30832011-04-08 Chong Yidong <cyd@stupidchicken.com>
3084
3085 * keyboard.c (read_char): Call Lisp function help-form-show,
3086 instead of using internal_with_output_to_temp_buffer.
3087 (Qhelp_form_show): New var.
e0d38eeb 3088 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3089
3090 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3091
3092 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3093
e67a13ab
CY
30942011-04-06 Chong Yidong <cyd@stupidchicken.com>
3095
04f2d78b
CB
3096 * process.c (Flist_processes): Remove to Lisp.
3097 (list_processes_1): Delete.
e67a13ab 3098
973f782d
EZ
30992011-04-06 Eli Zaretskii <eliz@gnu.org>
3100
7c106b1e
EZ
3101 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3102
973f782d
EZ
3103 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3104
41cf7d1a 31052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3106
ca23cc88
PE
3107 Fix more problems found by GCC 4.6.0's static checks.
3108
f390e2d5
PE
3109 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3110
42eea0d0
PE
3111 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3112
b69769da 3113 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3114
f9541e84
PE
3115 * xdisp.c (vmessage): Mark as a printf-like function.
3116
13841b55
PE
3117 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3118
c136c10f
PE
3119 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3120
5e2d4a30
PE
3121 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3122 printf-like functions.
3123 (tiff_load): Add casts to remove these marks before passing them
3124 to system-supplied API.
3125
583f48b9
PE
3126 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3127
b25d760e
PE
3128 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3129 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3130 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3131 directly, rather than having caller test rule sign. This avoids
3132 some unnecessary tests.
3133 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3134 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3135 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3136
bc7b6697 3137 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3138 (xfont_open): Avoid unnecessary tests.
bc7b6697 3139
27ccc379
PE
3140 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3141
dcd5c89a
PE
3142 * composite.h, composite.c (composition_gstring_put_cache):
3143 Use EMACS_INT, not int, for length.
3144
b13a45c6
PE
3145 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3146 breaking out part of COMPOSITION_DECODE_RULE.
3147 (COMPOSITION_DECODE_RULE): Use it.
3148 * composite.c (get_composition_id): Remove unused local vars,
3149 by using the new macro.
3150
1e792e4d
PE
3151 * textprop.c (set_text_properties_1): Change while to do-while,
3152 since the condition is always true at first.
3153
dc6c6455 3154 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3155 (interval_deletion_adjustment): Return unsigned value.
3156 All uses changed.
dc6c6455 3157
aba7731a
PE
3158 * process.c (list_processes_1, create_pty, read_process_output):
3159 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3160 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3161 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3162 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3163 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3164
fdfc4bf3
PE
3165 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3166
fca8fe46 3167 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3168 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3169
06a0259a 3170 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3171 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3172 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3173
e7b9e80f
PE
3174 * print.c (print_error_message): Avoid int overflow.
3175
56201685
PE
3176 * font.c (font_list_entities): Redo for clarity,
3177 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3178
78834453 3179 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3180 (font_score): Avoid potential overflow in diff calculation.
78834453 3181
0bc0b309 3182 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3183 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3184
e610eaca
PE
3185 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3186
b895abce
PE
3187 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3188 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3189 can always succeed if overflow has undefined behavior.
3190
1f1d9321 3191 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3192 (wordify): Omit three unnecessary tests.
1f1d9321 3193
c59478bc
PE
3194 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3195 All callers changed. This avoids the need for an unused var.
3196
79b73827
PE
3197 * casefiddle.c (casify_region): Remove var that is set but not used.
3198
a4db5dfe
PE
3199 * dired.c (file_name_completion): Remove var that is set but not used.
3200
43aae36e
PE
3201 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3202
2a47c44d 3203 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3204 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3205
a37c69bf
PE
3206 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3207 Check for integer overflow on size calculations.
3208
328ab8e7
PE
3209 * buffer.c (Fprevious_overlay_change): Remove var that is set
3210 but not used.
3211
e5a2a5cb
PE
3212 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3213 Remove vars that are set but not used.
8d84a6eb 3214 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3215 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3216
a60e5f68
PE
3217 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3218
f661cb61 3219 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3220 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3221
f0397f5a
PE
3222 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3223 that are set but not used.
3224
8664db06 3225 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3226 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3227
6abdaa4a
PE
3228 * xselect.c (x_get_local_selection, x_handle_property_notify):
3229 Remove vars that are set but not used.
3230
0ce7538d 3231 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3232 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3233
9ae848fc
PE
3234 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3235 Remove var that is set but not used.
0b918413
PE
3236 (scroll_bar_windows_size): Now size_t, not int.
3237 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3238 Check for overflow.
9ae848fc 3239
a5a62657
PE
3240 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3241 (map_tty_color) [!defined MSDOS]: Likewise.
3242
5c5cdd39
PE
3243 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3244
66ebf983
PE
3245 * coding.c: Remove vars that are set but not used.
3246 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3247 All callers changed.
3248 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3249 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3250 (decode_coding_charset): Remove vars that are set but not used.
3251
1be4d761
PE
3252 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3253 that is set but not used.
3254
47553fa8
PE
3255 * print.c (print_object): Remove var that is set but not used.
3256
1f7196bf 3257 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3258 The gnulib version avoids calling malloc in the usual case,
3259 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3260 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3261 * filelock.c (current_lock_owner): Likewise.
3262 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3263 * sysdep.c: Include allocator.h, careadlinkat.h.
3264 (emacs_no_realloc_allocator): New static constant.
3265 (emacs_readlink): New function.
fdb61804
PE
3266 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3267 ../lib/careadlinkat.h.
d1fdcab7 3268
f84c17c7
SM
32692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3270
3271 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3272 first non-nil return value).
3273
ef3862ad
JD
32742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3275
3276 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3277 if not defined (Bug#8403).
3278
376a7006
JB
32792011-04-02 Juanma Barranquero <lekktu@gmail.com>
3280
3281 * xdisp.c (display_count_lines): Remove parameter `start',
3282 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3283 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3284 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3285 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3286 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3287 and thereabouts. All callers changed.
3288 (get_per_char_metric): Remove parameter `f', unused since
3289 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3290
6ca3801d
JM
32912011-04-02 Jim Meyering <meyering@redhat.com>
3292
3293 do not dereference NULL upon failed strdup
3294 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3295 (ns_get_family): Likewise.
3296
d8e2b5ba
JB
32972011-04-02 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3300
8c74fcbd
JD
33012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3302
3303 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3304 later (Bug#8403).
3305
7200d79c
SM
33062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3307
03408648 3308 Add lexical binding.
7200d79c 3309
03408648
SM
3310 * window.c (Ftemp_output_buffer_show): New fun.
3311 (Fsave_window_excursion):
3312 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3313
3314 * lread.c (lisp_file_lexically_bound_p): New function.
3315 (Fload): Bind Qlexical_binding.
3316 (readevalloop): Remove `evalfun' arg.
3317 Bind Qinternal_interpreter_environment.
3318 (Feval_buffer): Bind Qlexical_binding.
3319 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3320 Mark as dynamic.
3321 (syms_of_lread): Declare `lexical-binding'.
3322
3323 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3324
3325 * keyboard.c (eval_dyn): New fun.
3326 (menu_item_eval_property): Use it.
ca105506
SM
3327
3328 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3329
03408648
SM
3330 * fns.c (concat, mapcar1): Accept byte-code-functions.
3331
3332 * eval.c (Fsetq): Handle lexical vars.
3333 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3334 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3335 (FletX, Flet): Obey lexical binding.
3336 (Fcommandp): Handle closures.
3337 (Feval): New `lexical' arg.
3338 (eval_sub): New function extracted from Feval. Use it almost
3339 everywhere where Feval was used. Look up vars in lexical env.
3340 Handle closures.
3341 (Ffunctionp): Move from subr.el.
3342 (Ffuncall): Handle closures.
3343 (apply_lambda): Remove `eval_flags'.
3344 (funcall_lambda): Handle closures and new byte-code-functions.
3345 (Fspecial_variable_p): New function.
3346 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3347 but without exporting it to Lisp.
23aba0ea 3348
23aba0ea 3349 * doc.c (Fdocumentation, store_function_docstring):
03408648 3350 * data.c (Finteractive_form): Handle closures.
23aba0ea 3351
03408648
SM
3352 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3353 interactive spec.
ba83908c 3354
04f2d78b
CB
3355 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3356 New byte-codes.
03408648
SM
3357 (exec_byte_code): New function extracted from Fbyte_code to handle new
3358 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3359
03408648 3360 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3361
03408648 3362 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3363
e2abce01
JB
33642011-03-31 Juanma Barranquero <lekktu@gmail.com>
3365
3366 * xdisp.c (redisplay_internal): Fix prototype.
3367
63696a73 33682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3369
63696a73 3370 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3371 (try_scrolling): Use it when setting scroll_limit.
3372 Limit scrolling to 100 screen lines.
63696a73
EZ
3373 (redisplay_window): Even when falling back on "recentering",
3374 position point in the window according to scroll-conservatively,
3375 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3376
3377 (try_scrolling): When point is above the window, allow searching
3378 as far as scroll_max, or one screenful, to compute vertical
3379 distance from PT to the scroll margin position. This prevents
3380 try_scrolling from unnecessarily failing when
3381 scroll-conservatively is set to a value slightly larger than the
3382 window height. Clean up the case of PT below the margin at bottom
3383 of window: scroll_max can no longer be INT_MAX. When aggressive
3384 scrolling is in use, don't let point enter the opposite scroll
3385 margin as result of the scroll.
3386 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3387 threshold of 100 lines for never-recentering scrolling.
3388
e4cc2dfc
JB
33892011-03-31 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * dispextern.h (move_it_by_lines):
3392 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3393 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3394 (message_log_check_duplicate): Remove parameters `prev_bol' and
3395 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3396 (redisplay_internal): Remove parameter `preserve_echo_area',
3397 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3398
3399 * indent.c (Fvertical_motion):
3400 * window.c (window_scroll_pixel_based, Frecenter):
3401 Don't pass `need_y_p' to `move_it_by_lines'.
3402
1c470562
SM
34032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3404
44f230aa
SM
3405 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3406 steal a few bits to be more compact.
3407 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3408 Remove unneeded casts.
3409
1c470562
SM
3410 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3411
888adce9
ZK
34122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3413
3414 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3415 binding" message (bug#7967).
3416
f838ed7b
PE
34172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3418
77861b95
PE
3419 Fix more problems found by GCC 4.6.0's static checks.
3420
de6dbc14
PE
3421 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3422 Remove unused local var.
3423
f838ed7b
PE
3424 * editfns.c (Fmessage_box): Remove unused local var.
3425
792c7b2b
PE
3426 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3427 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3428 Omit unused local vars.
c499e557 3429 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3430 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3431 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3432 Omit unused local var.
3433
ba0165e1
PE
3434 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3435 Don't assume string length fits in int.
32ad8845 3436 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3437 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3438
3c59b4c9
PE
3439 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3440 instead of alloca (Bug#8344).
3441
a3eed478 3442 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3443 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3444
eb4d412d
PE
3445 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3446
1658b401
PE
3447 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3448 concerns.
3449
3450 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3451
3452 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3453
9a2c6e05
PE
3454 * keyboard.c (syms_of_keyboard): Use the same style as later
3455 in this function when indexing through an array. This also
3456 works around GCC bug 48267.
3457
03d0a109
PE
3458 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3459
44f730c8
PE
3460 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3461
fe75f926
PE
3462 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3463 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3464
ffa8c828
PE
3465 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3466 This avoids undefined behavior on integer overflow, and is a bit
3467 more convenient anyway since it is compared to a size_t variable.
3468
c5101a77
PE
3469 Variadic C functions now count arguments with size_t, not int.
3470 This avoids an unnecessary limitation on 64-bit machines, which
3471 caused (substring ...) to crash on large vectors (Bug#8344).
3472 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3473 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3474 All variadic functions and their callers changed accordingly.
c5101a77
PE
3475 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3476 * data.c (arith_driver, float_arith_driver): Likewise.
3477 * editfns.c (general_insert_function): Likewise.
3478 * eval.c (struct backtrace.nargs, interactive_p)
3479 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3480 (funcall_lambda, mark_backtrace): Likewise.
3481 * fns.c (concat): Likewise.
3482 * frame.c (x_set_frame_parameters): Likewise.
3483 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3484 0 if not found, not -1. All callers changed.
3485
dd3f25f7
PE
3486 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3487 (stack_copy_size): Now size_t, not int.
3488 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3489
461c2ab9
JB
34902011-03-28 Juanma Barranquero <lekktu@gmail.com>
3491
3492 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3493 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3494 All callers changed.
3495
3496 * lisp.h (multibyte_char_to_unibyte):
3497 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3498 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3499 * character.h (CHAR_TO_BYTE8):
3500 * cmds.c (internal_self_insert):
3501 * editfns.c (general_insert_function):
3502 * keymap.c (push_key_description):
3503 * search.c (Freplace_match):
3504 * xdisp.c (message_dolog, set_message_1): All callers changed.
3505
f6d62986
SM
35062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3507
3508 * keyboard.c (safe_run_hook_funcall): New function.
3509 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3510 don't set the hook to nil, but remove the offending function instead.
3511 (Qcommand_hook_internal): Remove, unused.
3512 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3513 Vcommand_hook_internal.
3514
3515 * eval.c (enum run_hooks_condition): Remove.
3516 (funcall_nil, funcall_not): New functions.
3517 (run_hook_with_args): Call each function through a `funcall' argument.
3518 Remove `cond' argument, now redundant.
3519 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3520 (Frun_hook_with_args_until_failure): Adjust accordingly.
3521 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3522
1db5b1ad
JB
35232011-03-28 Juanma Barranquero <lekktu@gmail.com>
3524
3525 * dispextern.h (string_buffer_position): Remove declaration.
3526
3527 * print.c (strout): Remove parameter `multibyte', unused since
3528 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3529
3530 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3531 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3532 All callers changed.
3533
3534 * w32.c (_wsa_errlist): Use braces for struct initializers.
3535
3536 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3537 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3538 All callers changed.
3539 (string_buffer_position): Likewise. Also, make static (it's never
3540 used outside xdisp.c).
3541 (cursor_row_p): Remove parameter `w', unused since
3542 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3543 (decode_mode_spec): Remove parameter `precision', introduced during
3544 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3545 All callers changed.
3546
5ffb62aa
JD
35472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3548
3549 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3550
461c2ab9 35512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3552
3553 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3554 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3555 (ns_update_auto_hide_menu_bar): New functions.
3556 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3557 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3558 ns_constrain_all_frames.
3559 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3560 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3561
5c380ffb
JD
35622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3563
3564 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3565
9af30bdf
GM
35662011-03-27 Glenn Morris <rgm@gnu.org>
3567
3568 * syssignal.h: Replace RETSIGTYPE with void.
3569 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3570 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3571 Replace SIGTYPE with void everywhere.
3572 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3573 * s/template.h (SIGTYPE): Remove commented out definition.
3574
e2abce01
JB
35752011-03-26 Eli Zaretskii <eliz@gnu.org>
3576
3577 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3578 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3579
f868cd8a
JB
35802011-03-26 Juanma Barranquero <lekktu@gmail.com>
3581
59eb0929
JB
3582 * w32.c (read_unc_volume): Use parameter `henum', instead of
3583 global variable `wget_enum_handle'.
3584
3585 * keymap.c (describe_vector): Remove parameters `indices' and
3586 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3587 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3588
f868cd8a
JB
3589 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3590
3591 * keyboard.c (timer_check): Remove parameter `do_it_now',
3592 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3593 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3594 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3595
3596 * keyboard.c (read_char):
3597 * w32menu.c (w32_menu_display_help):
3598 * xmenu.c (show_help_event, menu_help_callback):
3599 Adjust calls to `show_help_echo'.
3600
3601 * gtkutil.c (xg_maybe_add_timer):
3602 * keyboard.c (readable_events):
3603 * process.c (wait_reading_process_output):
3604 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3605
3606 * insdel.c (adjust_markers_gap_motion):
3607 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3608 (gap_left, gap_right): Don't call it.
3609
2ecf6fdb
CY
36102011-03-25 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3613 incurred during fontification.
3614
6b1f9ba4
JB
36152011-03-25 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3618 (DEFVAR_PER_BUFFER): Don't pass it.
3619
3620 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3621 (scrolling_window): Don't pass it.
3622
0f4a96b5
JB
36232011-03-25 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3626
3627 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3628 and `suffix'.
3629 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3630 of variables specific to SELinux and computation of `encoded_absname'.
3631
3632 * image.c (XPutPixel): Remove unused variable `height'.
3633
3634 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3635
3636 * unexw32.c (get_section_info): Remove unused variable `section'.
3637
3638 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3639 (system_process_attributes): Remove unused variable `sess'.
3640 (sys_read): Remove unused variable `err'.
3641
3642 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3643 (w32_wnd_proc): Remove unused variable `isdead'.
3644 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3645 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3646 (x_create_tip_frame): Remove unused variable `tem'.
3647
3648 * w32inevt.c (w32_console_read_socket):
3649 Remove unused variable `no_events'.
3650
3651 * w32term.c (x_draw_composite_glyph_string_foreground):
3652 Remove unused variable `width'.
3653
1149507c
JB
36542011-03-24 Juanma Barranquero <lekktu@gmail.com>
3655
3656 * w32term.c (x_set_glyph_string_clipping):
3657 Don't pass uninitialized region to CombineRgn.
3658
9c88f339
JB
36592011-03-23 Juanma Barranquero <lekktu@gmail.com>
3660
3661 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3662 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3663 (Fx_close_connection): Remove unused variable `i'.
3664
3665 * w32font.c (w32font_draw): Return number of glyphs.
3666 (w32font_open_internal): Remove unused variable `i'.
3667 (w32font_driver): Add missing initializer.
3668
3669 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3670 (fill_in_menu): Remove unused variable `items_added'.
3671
3672 * w32term.c (last_mouse_press_frame): Remove static global variable.
3673 (w32_clip_to_row): Remove unused variable `f'.
3674 (x_delete_terminal): Remove unused variable `i'.
3675
3676 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3677 (NOTHING): Remove unused static global variable.
3678 (uniscribe_check_otf): Remove unused variable `table'.
3679 (uniscribe_font_driver): Add missing initializers.
3680
dee091a3
JD
36812011-03-23 Julien Danjou <julien@danjou.info>
3682
3683 * term.c (Fsuspend_tty, Fresume_tty):
3684 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3685 * window.c (temp_output_buffer_show):
3686 * insdel.c (signal_before_change):
3687 * frame.c (Fhandle_switch_frame):
3688 * fileio.c (Fdo_auto_save):
3689 * emacs.c (Fkill_emacs):
3690 * editfns.c (save_excursion_restore):
3691 * cmds.c (internal_self_insert):
3692 * callint.c (Fcall_interactively):
3693 * buffer.c (Fkill_all_local_variables):
3694 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3695 Use Frun_hooks.
0f4a96b5 3696 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3697 unconditionnaly since it does the check itself.
3698
2c520ab5 36992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3700
c9c49752
PE
3701 Fix more problems found by GCC 4.5.2's static checks.
3702
8abc3f12
PE
3703 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3704 the first time through the loop, since we know p0 < p1 then.
3705 This also avoids a gcc -Wstrict-overflow warning.
3706
a2d26660
PE
3707 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3708 leading to a memory leak, possible in functions like
3709 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3710 of objects (Bug#8318).
a2d26660 3711
916c72e9
PE
3712 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3713 that could (at least in theory) be that large.
3714
19ab8a18
PE
3715 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3716 This is less likely to overflow, and avoids undefined behavior if
3717 overflow does occur. All callers changed. Use strtoul to scan
3718 for the unsigned long integer.
b7cbbd6f
PE
3719 (pint2hrstr): Simplify and tune code slightly.
3720 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3721
f0641eff
PE
3722 * scroll.c (do_scrolling): Work around GCC bug 48228.
3723 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3724
7f650bb9
PE
3725 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3726 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3727 (validate_x_resource_name): Simplify count usage.
3728 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3729
37dd57d1
PE
3730 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3731 fail (Bug#8306).
81e56e61 3732
699979fc 3733 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3734
401bf9b4
PE
3735 * process.c (Fmake_network_process): Use socklen_t, not int,
3736 where POSIX says socklen_t is required in portable programs.
3737 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3738 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3739 (Fmake_network_process, server_accept_connection):
3740 (wait_reading_process_output, read_process_output):
3741 Likewise.
3742
b93aacde
PE
3743 * process.c: Rename or move locals to avoid shadowing.
3744 (list_processes_1, Fmake_network_process):
3745 (read_process_output_error_handler, exec_sentinel_error_handler):
3746 Rename or move locals.
4dc343ee 3747 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3748 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3749 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3750 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3751 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3752
af8a867c 3753 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3754 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3755 Include tparam.h instead, since it declares them.
af8a867c
PE
3756 * cm.h (PC): Remove extern decl; tparam.h now does this.
3757 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3758 * terminfo.c: Include tparam.h, to check interfaces.
3759 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3760 (tparam): Adjust signature to match interface in tparam.h;
3761 this removes some undefined behavior. Check that outstring and len
3762 are zero, which they always are with Emacs.
3763 * tparam.h (PC, BC, UP): New extern decls.
3764
0248044d 3765 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3766 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3767
8ff096c1 3768 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3769 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3770 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3771 (ftfont_list): Remove unused local.
49eaafba
PE
3772 (get_adstyle_property, ftfont_pattern_entity):
3773 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3774 Rename locals to avoid shadowing.
8ff096c1 3775
e2be39f6
PE
3776 * xfont.c (xfont_list_family): Mark var as initialized.
3777
c9735e30
PE
3778 * xml.c (make_dom): Now static.
3779
8f5201ae
PE
3780 * composite.c (composition_compute_stop_pos): Rename local to
3781 avoid shadowing.
b246f932
PE
3782 (composition_reseat_it): Remove unused locals.
3783 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3784 (composition_update_it): Mark var as initialized.
11b61122
PE
3785 (find_automatic_composition): Mark vars as initialized,
3786 with a FIXME (Bug#8290).
8f5201ae 3787
760fbc2c
PE
3788 character.h: Rename locals to avoid shadowing.
3789 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3790 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3791 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3792 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3793 to avoid shadowing.
3794
ff08eb85
PE
3795 * textprop.c (property_change_between_p): Remove; unused.
3796
fc7bf025
PE
3797 * intervals.c (interval_start_pos): Now static.
3798
235d7abc
PE
3799 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3800
44f230aa
SM
3801 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3802 Rename locals to avoid shadowing.
3e7d6594 3803
50060332
PE
3804 * sound.c (wav_play, au_play, Fplay_sound_internal):
3805 Fix pointer signedness.
d01f234b 3806 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3807 (wav_play): Initialize a variable to 0, to prevent undefined
3808 behavior (Bug#8278).
50060332 3809
c4fc4e30
PE
3810 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3811
918436ed
PE
3812 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3813
c939f91b
PE
3814 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3815 clobbering (Bug#8298).
b9c7f648
PE
3816 * sysdep.c (sys_subshell): Likewise.
3817 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3818
6bd8c144
PE
3819 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3820 This should get cleaned up, so that child_setup has the
3821 same signature on all platforms.
3822
7710357c 3823 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3824 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3825
c59da222
CY
38262011-03-22 Chong Yidong <cyd@stupidchicken.com>
3827
3828 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3829 not to be necessary, and produces flickering.
3830
66b87493
GM
38312011-03-20 Glenn Morris <rgm@gnu.org>
3832
3833 * config.in: Remove file.
3834
45b6f6d5
JB
38352011-03-20 Juanma Barranquero <lekktu@gmail.com>
3836
3837 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3838 are now in src/globals.h.
3839 (syms_of_minibuf): Remove spurious & from previous change.
3840
3ec03f7e
LL
38412011-03-20 Leo <sdl.web@gmail.com>
3842
3843 * minibuf.c (completing-read-function): New variable.
3844 (completing-read-default): Rename from completing-read.
3845 (completing-read): Call completing-read-function.
3846
b14e3e21
CY
38472011-03-19 Juanma Barranquero <lekktu@gmail.com>
3848
3849 * xfaces.c (Fx_load_color_file):
3850 Read color file from absolute filename (bug#8250).
3851
f2b726e6
JB
38522011-03-19 Juanma Barranquero <lekktu@gmail.com>
3853
3854 * makefile.w32-in: Update dependencies.
3855
09f6ff02
EZ
38562011-03-17 Eli Zaretskii <eliz@gnu.org>
3857
3858 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3859
29a6015a
PE
38602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3861
a3a6c54e
PE
3862 Fix more problems found by GCC 4.5.2's static checks.
3863
b766f867
PE
3864 * process.c (make_serial_process_unwind, send_process_trap):
3865 (sigchld_handler): Now static.
3866
be02381c
PE
3867 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3868 That way, the code declares only the vars that it needs.
3869 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3870 * s/cygwin.h (PTY_ITERATION): Likewise.
3871 * s/darwin.h (PTY_ITERATION): Likewise.
3872 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3873
57048744
PE
3874 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3875 * process.c (allocate_pty): Don't declare stb unless it's needed.
3876
7914961c 3877 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3878 (CONSTANTLIM): Remove; unused.
3879 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3880 Define only if needed.
7914961c 3881
b3967b18
PE
3882 * unexelf.c (unexec): Name an expression,
3883 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3884 Use a different way to cause a compilation error if anyone uses
3885 n rather than nn, a way that does not involve shadowing.
73366a00 3886 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3887
29a6015a
PE
3888 * deps.mk (unexalpha.o): Remove; unused.
3889
43cfc33e 3890 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3891 * unexec.h: New file.
ce701a33
PE
3892 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3893 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3894 Depend on unexec.h.
3895 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3896 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3897 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3898 Change as necessary to match prototype in unexec.h.
ce701a33 3899
01f44d5a
PE
3900 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3901 shadowing.
4f63c6bb 3902 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3903
a6670b0b
PE
3904 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3905 Rename locals to avoid shadowing.
3906
cef2010d 3907 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3908 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3909
d4d7173a
PE
3910 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3911
f08b802a
PE
3912 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3913 warning when compiling print.c.
3914
3ddb0639
PE
3915 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3916 instead of using an uninitialized var.
5ad03b97 3917 (font_sort_entities): Mark var as initialized.
3ddb0639 3918
170a2692
PE
3919 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3920
e663c700
PE
3921 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3922 pointers to constants.
89bc529a 3923 (font_parse_fcname): Remove unused vars.
7b81e2d0 3924 (font_delete_unmatched): Now static.
ea838e10 3925 (font_get_spec): Remove; unused.
13a547c6
PE
3926 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3927 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3928 Rename or move locals to avoid shadowing.
e663c700 3929
2a80c887 3930 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3931 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3932
1384fa33 3933 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3934 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3935
8b2c52e9
PE
3936 * alloc.c (mark_backtrace): Move decl from here ...
3937 * lisp.h: ... to here, so that it can be checked.
3938
475545b5 3939 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3940 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3941 (lisp_indirect_variable): Name an expression,
3942 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3943 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3944
b1349114 3945 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3946 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3947 Use const pointer when appropriate.
b1349114 3948
a2928364
PE
3949 * lisp.h (get_system_name, get_operating_system_release):
3950 Move decls here, to check interfaces.
3951 * process.c (get_operating_system_release): Move decl to lisp.h.
3952 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3953 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3954 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3955 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3956 (Fformat_time_string, Fencode_time, Finsert_char):
3957 (Ftranslate_region_internal, Fformat):
3958 Rename or remove local vars to avoid shadowing.
9710023e 3959 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3960
a415e694
PE
3961 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3962 avoid shadowing.
3963
8ef4622d
PE
3964 * lisp.h (eassert): Check that the argument compiles, even if
3965 ENABLE_CHECKING is not defined.
3966
946f9a5b
PE
3967 * data.c (Findirect_variable): Name an expression, to avoid
3968 gcc -Wbad-function-cast warning.
112396d6 3969 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3970 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3971 (Fmake_variable_buffer_local, Fmake_local_variable):
3972 Mark variables as initialized.
52746918 3973 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3974
e5aab7e7 3975 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3976 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3977 Rename locals to avoid shadowing.
dff45157
PE
3978 (mark_stack): Move local variables into the #ifdef region where
3979 they're used.
7bc26fdb
PE
3980 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3981 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3982 needed otherwise.
3983 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3984 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3985 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3986
e5aab7e7
PE
3987 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3988 avoids undefined behavior in theory.
3989
4da60324
PE
3990 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3991
88043301
PE
3992 Use functions, not macros, for up- and down-casing (Bug#8254).
3993 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3994 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3995 to use the following functions instead of these macros.
3996 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3997 EMACS_INT, since callers assume the returned value fits in int.
3998 (upcase1): Likewise, for UPCASE_TABLE.
3999 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4000 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4001 the race-condition problem in the old DOWNCASE.
88043301 4002
19ed5445
PE
4003 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4004 Rename locals to avoid shadowing.
4005 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4006 (regex_compile, re_search_2, re_match_2_internal):
4007 Remove unused local vars.
952db0d7
PE
4008 (FREE_VAR): Rewrite so as not to use empty "else",
4009 which gcc can warn about.
da053e48 4010 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4011 (RETALLOC_IF): Define only if needed.
4012 (WORDCHAR_P): Likewise. This one is never needed, but is used
4013 only in a comment talking about a compiler bug, so put inside
4014 the #if 0 of that comment.
4015 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4016 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4017 Remove; unused.
19ed5445 4018
1f3561e4 4019 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4020 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4021 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4022
ded6f8f7
PE
4023 * search.c (simple_search): Remove unused var.
4024
dbd37a95
PE
4025 * dired.c (compile_pattern): Move decl from here ...
4026 * lisp.h: ... to here, so that it can be checked.
4027 (struct re_registers): New forward decl.
4028
7e47afad
PE
4029 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4030
85f24f61
PE
4031 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4032 All uses changed.
4033 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4034 Rename locals to avoid shadowing.
5671df8f 4035 (Fvertical_motion): Mark locals as initialized.
85f24f61 4036
181aa2be 4037 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4038 (casify_region): Mark local as initialized.
181aa2be 4039
930d429c
PE
4040 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4041
7082eac6
PE
4042 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4043 New macros, so that the caller can use some names other than
4044 gcpro1, gcpro2, etc.
4045 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4046 of the new macros.
4047 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4048 argument, for consistency with GCPRO2_VAR, etc: it is now the
4049 prefix of the variable, not the variable itself. All uses
4050 changed.
38b2c076
PE
4051 * dired.c (directory_files_internal, file_name_completion):
4052 Rename locals to avoid shadowing.
4053
15206ed9
PE
4054 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4055 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4056 dired.c's scmp function, had undefined behavior.
4057 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4058 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4059 * buffer.h: ... to here, because these macros use current_buffer,
4060 and the new implementation with inline functions needs to have
4061 current_buffer in scope now, rather than later when the macros
4062 are used.
4063 (downcase, upcase1): New static inline functions.
4064 (DOWNCASE, UPCASE1): Reimplement using these functions.
4065 This avoids undefined behavior in expressions like
4066 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4067 from race conditions in accessing the global variables
4068 case_temp1 and case_temp2.
4069 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4070 * lisp.h (case_temp1, case_temp2): Remove their decls.
4071 * character.h (ASCII_CHAR_P): Move from here ...
4072 * lisp.h: ... to here, so that the inline functions mentioned
4073 above can use them.
4074
4a6bea26
PE
4075 * dired.c (directory_files_internal_unwind): Now static.
4076
f14b7e14
PE
4077 * fileio.c (file_name_as_directory, directory_file_name):
4078 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4079 Now static.
2893f146
PE
4080 (file_name_as_directory): Use const pointers when appropriate.
4081 (Fexpand_file_name): Likewise. In particular, newdir might
4082 point at constant storage, so make it a const pointer.
fd4ead52 4083 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4084 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4085 signedness issues.
f839df0c
PE
4086 (Fset_file_times, Finsert_file_contents, auto_save_error):
4087 Rename locals to avoid shadowing.
f14b7e14 4088
5716756e 4089 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4090 (Ftry_completion, Fall_completions): Rename or remove locals
4091 to avoid shadowing.
5716756e 4092
b4c3046a
PE
4093 * marker.c (bytepos_to_charpos): Remove; unused.
4094
b45db522
PE
4095 * lisp.h (verify_bytepos, count_markers): New decls,
4096 so that gcc does not warn that these functions aren't declared.
4097
85876d07
PE
4098 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4099 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4100 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4101 (copy_text): Remove unused local var.
85876d07 4102
03d78a21 4103 * filelock.c (within_one_second): Now static.
b3dd38ab 4104 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4105
5df8f01b
PE
4106 * buffer.c (fix_overlays_before): Mark locals as initialized.
4107 (fix_start_end_in_overlays): Likewise. This function should be
4108 simplified by using pointers-to-pointers, but that's a different
4109 matter.
b1d876f1 4110 (switch_to_buffer_1): Now static.
8f54f30a
PE
4111 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4112 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4113
a70072c9 4114 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4115 Fix pointer signedness issue.
edced198
PE
4116 (sys_subshell): Mark local as volatile if checking for lint,
4117 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4118 (MAXPATHLEN): Define only if needed.
a70072c9 4119
a0977c44
PE
4120 * process.c (serial_open, serial_configure): Move decls from here ...
4121 * systty.h: ... to here, so that they can be checked.
4122
a884fdcc
PE
4123 * fns.c (get_random, seed_random): Move extern decls from here ...
4124 * lisp.h: ... to here, so that they can be checked.
4125
604efe86 4126 * sysdep.c (reset_io): Now static.
b8950c94 4127 (wait_for_termination_signal): Remove; unused.
604efe86 4128
38fc62d9
PE
4129 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4130 (copy_keymap_item, append_key, push_text_char_description):
4131 Now static.
1004a21a 4132 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4133 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4134 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4135 (describe_map_tree):
4136 Rename locals to avoid shadowing.
38fc62d9 4137
2f2650da
PE
4138 * keyboard.c: Declare functions static if they are not used elsewhere.
4139 (echo_char, echo_dash, cmd_error, top_level_2):
4140 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4141 (read_char, kbd_buffer_get_event, make_lispy_position):
4142 (make_lispy_event, make_lispy_movement, apply_modifiers):
4143 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4144 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4145 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4146 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4147 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4148
a053e86c 4149 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4150 (mark_kboards): Move decl here ...
4151 * alloc.c (mark_kboards): ... from here.
a053e86c 4152
4752793e
PE
4153 * lisp.h (force_auto_save_soon): New decl.
4154
74f10ca7 4155 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4156 (DEFINE_DUMMY_FUNCTION): New macro.
4157 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4158 Use it.
c03cd23f
PE
4159 (main): Add casts to avoid warnings
4160 if GCC considers string literals to be constants.
74f10ca7 4161
022e70d4
PE
4162 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4163
59d6fe83
PE
4164 * dbusbind.c: Pointer signedness fixes.
4165 (xd_signature, xd_append_arg, xd_initialize):
4166 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4167 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4168 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4169 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4170
78320123
PE
4171 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4172 if GCC considers string literals to be constants.
49cebcca 4173 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4174
35ac2a97
SM
41752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4176
fb103ca9
SM
4177 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4178 (print_preprocess, print_object): New macro to fix last change.
4179
35ac2a97
SM
4180 * print.c (print_preprocess): Don't forget font objects.
4181
62973b41
JB
41822011-03-16 Juanma Barranquero <lekktu@gmail.com>
4183
4184 * emacs.c (USAGE3): Doc fixes.
4185
0e48bb22
AS
41862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4187
4188 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4189 structure.
4190
7684e57b
JB
41912011-03-14 Juanma Barranquero <lekktu@gmail.com>
4192
4193 * lisp.h (VWindow_system, Qfile_name_history):
4194 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4195 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4196 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4197
4198 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4199 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4200
4201 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4202 * w32console.c (detect_input_pending, read_input_pending)
4203 (encode_terminal_code):
4204 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4205 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4206 (w32_system_caret_y, Qfile_name_history):
4207 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4208 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4209 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4210 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4211 * w32proc.c (Qlocal, report_file_error):
4212 * w32term.c (Vwindow_system, updating_frame):
4213 * w32uniscribe.c (initialized, uniscribe_font_driver):
4214 Remove unneeded extern declarations.
4215
2aa46d6c
CY
42162011-03-14 Chong Yidong <cyd@stupidchicken.com>
4217
c96bbc66 4218 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4219
cffc6f3b
CY
42202011-03-13 Chong Yidong <cyd@stupidchicken.com>
4221
4222 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4223 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4224 These macros can no longer be used for assignment.
4225
44f230aa
SM
4226 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4227 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4228 (record_buffer_markers, fetch_buffer_markers): New functions for
4229 recording and fetching special buffer markers.
4230 (set_buffer_internal_1, set_buffer_temp): Use them.
4231
4232 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4233
4234 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4235
4236 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4237 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4238
4239 * xdisp.c (hscroll_window_tree):
4240 (reconsider_clip_changes): Use PT instead of BUF_PT.
4241
d251f04b
EZ
42422011-03-13 Eli Zaretskii <eliz@gnu.org>
4243
4244 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4245 $(EMACS_ROOT)/lib/intprops.h.
4246
f0c77cd1
PE
42472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4248
3eca4629
PE
4249 Fix more problems found by GCC 4.5.2's static checks.
4250
7c86ee98
PE
4251 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4252 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4253 (xg_free_frame_widgets): Make it clear that a local variable is
4254 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4255 (gdk_window_get_screen): Make it clear that this macro is needed
4256 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4257 (int_gtk_range_get_value): New function, which avoids a diagnostic
4258 from gcc -Wbad-function-cast.
4259 (xg_set_toolkit_scroll_bar_thumb): Use it.
4260 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4261 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4262 (get_utf8_string, xg_get_file_with_chooser):
4263 Rename locals to avoid shadowing.
4264 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4265
41729b81
PE
4266 * xgselect.c (xg_select): Remove unused var.
4267
f0c77cd1
PE
4268 * image.c (four_corners_best): Mark locals as initialized.
4269 (gif_load): Initialize transparent_p to zero (Bug#8238).
4270 Mark another local as initialized.
ec6cf4c6 4271 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4272
ce0ad53d 4273 * image.c (clear_image_cache): Now static.
d5d5a617 4274 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4275 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4276 (x_edge_detection): Remove unnecessary cast that
4277 gcc -Wbad-function-cast diagnoses.
2037898d 4278 (gif_load): Fix pointer signedness.
6ae141d6
PE
4279 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4280 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4281
33383987 42822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4283
d32df629
PE
4284 Improve quality of tests for time stamp overflow.
4285 For example, without this patch (encode-time 0 0 0 1 1
4286 1152921504606846976) returns the obviously-bogus value (-948597
4287 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4288 reports time overflow. See
4289 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4290 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4291 * editfns.c: Include limits.h and intprops.h.
4292 (TIME_T_MIN, TIME_T_MAX): New macros.
4293 (time_overflow): Move earlier, to before first use.
4294 (hi_time, lo_time): New functions, for an accurate test for
4295 out-of-range times.
4296 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4297 (Fget_internal_run_time): Don't assume time_t fits in int.
4298 (make_time): Use list2 instead of Fcons twice.
4299 (Fdecode_time): More accurate test for out-of-range times.
4300 (check_tm_member): New function.
4301 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4302 (lisp_time_argument): Don't rely on undefined left-shift and
4303 right-shift behavior when checking for time stamp overflow.
8be6f318 4304
fe31d94c
PE
4305 * editfns.c (time_overflow): New function, refactoring common code.
4306 (Fformat_time_string, Fdecode_time, Fencode_time):
4307 (Fcurrent_time_string): Use it.
4308
8be6f318
PE
4309 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4310 * dired.c (make_time): Move to ...
4311 * editfns.c (make_time): ... here.
4312 * systime.h: Note the move.
4313
09d9db2c 43142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4315
126bc0dc
YM
4316 * fringe.c (update_window_fringes): Remove unused variables.
4317
c47cbdfd
YM
4318 * unexmacosx.c (copy_data_segment): Also copy __got section.
4319 (Bug#8223)
4320
7ac80be9
EZ
43212011-03-12 Eli Zaretskii <eliz@gnu.org>
4322
c96bbc66 4323 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4324 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4325 Constify `char *' arguments and their references according to
4326 prototypes in tparam.h.
4327
ecb0f94d 4328 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4329
7ac80be9
EZ
4330 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4331 Adapt all references accordingly.
4332
4333 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4334
ef1fd07e
TT
43352011-03-11 Tom Tromey <tromey@redhat.com>
4336
4337 * buffer.c (syms_of_buffer): Remove obsolete comment.
4338
7ef4b50c
EZ
43392011-03-11 Eli Zaretskii <eliz@gnu.org>
4340
4341 * termhooks.h (encode_terminal_code): Declare prototype.
4342
4343 * msdos.c (encode_terminal_code): Don't declare prototype.
4344
4345 * term.c (encode_terminal_code): Now external again, used by
4346 w32console.c and msdos.c.
4347
44f230aa
SM
4348 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4349 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4350
4b1ec863 43512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4352
1714f52b 4353 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4354
4b1ec863
PE
4355 * fringe.c (update_window_fringes): Mark locals as initialized
4356 (Bug#8227).
4357 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4358
524c7aa6
PE
4359 * alloc.c (mark_fringe_data): Move decl from here ...
4360 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4361 to check its interface.
4362 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4363
a5c0af81 4364 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4365 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4366 (fontset_font): Mark local as initialized.
a9a06e0b 4367 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4368
b4716021
PE
4369 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4370
811e9bac 4371 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4372 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4373 (x_own_selection, Fx_disown_selection_internal): Rename locals
4374 to avoid shadowing.
4375 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4376
7e3ab302
PE
4377 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4378 so that the caller can use some name other than gcpro1.
4379 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4380 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4381 (Fx_backspace_delete_keys_p):
4382 Use them to avoid shadowing, and rename vars to avoid shadowing.
4383 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4384 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4385 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4386 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4387 Remove unused locals.
7e3ab302
PE
4388 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4389 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4390 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4391 macros.
f78faa98 4392
e2b13473
PE
4393 * xterm.h (x_mouse_leave): New decl.
4394
77f23912
PE
4395 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4396 Remove unused functions.
cdf4ba58
PE
4397 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4398 (x_calc_absolute_position): Now static.
7411c686 4399 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4400 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4401 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4402 unless they are used.
38d0b34a
PE
4403 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4404 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4405 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4406 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4407 (x_error_catcher, x_connection_closed, x_error_handler):
4408 (x_error_quitter, xembed_send_message, x_iconify_frame):
4409 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4410 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4411 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4412
44f230aa
SM
4413 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4414 Rename or move locals to avoid shadowing.
6b463e58 4415 (tty_defined_color, merge_face_heights): Now static.
5967d051 4416 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4417 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4418 does not deduce is never used uninitialized.
73719eba
PE
4419 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4420 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4421
426994c3 4422 * terminal.c (store_terminal_param): Now static.
5489860b 4423
032f1620 4424 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4425 (set_frame_menubar): Remove unused local.
d4323972 4426 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4427 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4428 since they might point to immutable storage.
281585b0
PE
4429 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4430 since it's unused otherwise.
032f1620 4431
367c19e5 4432 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4433 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4434 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4435 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4436 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4437 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4438 does not deduce are never used uninitialized.
70739cbe 4439
07b48fa9
PE
4440 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4441
8868a238 4442 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4443 * window.c (window_loop, size_window):
4444 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4445
7e5cf297 4446 * window.c (display_buffer): Now static.
d6550a9f
PE
4447 (size_window): Mark variables that gcc -Wuninitialized
4448 does not deduce are never used uninitialized.
a586633d
PE
4449 * window.h (check_all_windows): New decl, to forestall
4450 gcc -Wmissing-prototypes diagnostic.
5b555da1 4451 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4452
f6095868
PE
4453 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4454 shadowing.
4455 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4456 Include <limits.h>.
4457 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4458 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4459 (load_charset_map): Mark variables that gcc -Wuninitialized
4460 does not deduce are never used uninitialized.
53df7c11 4461 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4462
f38b440c
PE
4463 * coding.c (coding_set_source, coding_set_destination):
4464 Use "else { /* comment */ }" rather than "else /* comment */;"
4465 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4466 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4467 a block, when the outer 'i' will do.
4468 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4469 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4470 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4471 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4472 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4473 Rename locals to avoid shadowing.
4474 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4475 * coding.c (emacs_mule_char, encode_invocation_designation):
4476 Now static, since they're not used elsewhere.
413bb2db 4477 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4478 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4479 (decode_coding_emacs_mule): Mark variables that gcc
4480 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4481 (detect_coding_iso_2022): Initialize a local variable that might
4482 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4483 this initialization is needed. (Bug#8211)
5f58e762
PE
4484 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4485 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4486 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4487 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4488 Remove unused macros.
f38b440c 4489
232b38b9 4490 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4491 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4492 * character.c (string_count_byte8): Likewise.
232b38b9 4493
fb90da1b
PE
4494 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4495 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4496
fb93dbc2
PE
4497 * chartab.c (copy_sub_char_table): Now static, since it's not used
4498 elsewhere.
5c156ace
PE
4499 (sub_char_table_ref_and_range, char_table_ref_and_range):
4500 Rename locals to avoid shadowing.
bbcd0949 4501 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4502
7d3b3862 4503 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4504 (BIDI_BOB): Remove unused macro.
7d3b3862 4505
6be7d3da
PE
4506 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4507 deduce are never used uninitialized.
c2ed9c8b 4508 * term.c (encode_terminal_code): Likewise.
6be7d3da 4509
75f8807f 4510 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4511
50938595
PE
4512 * tparam.h: New file.
4513 * term.c, tparam.h: Include it.
4514 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4515 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4516 Move these decls to tparam.h, and make them agree with what
4517 is actually in tparam.c. The previous trick of using incompatible
4518 decls in different modules does not conform to the C standard.
4519 All callers of tparam changed to use tparam's actual API.
4520 * tparam.c (tparam1, tparam, tgoto):
4521 Use const pointers where appropriate.
4522
fbceeba2
PE
4523 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4524 * cm.h (struct cm): Likewise.
4525 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4526 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4527 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4528 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4529 (turn_on_face, init_tty): Likewise.
4530 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4531
7f3f1250
PE
4532 * term.c (term_mouse_position): Rename local to avoid shadowing.
4533
e6ca6543
PE
4534 * alloc.c (mark_ttys): Move decl from here ...
4535 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4536
c40f8d15
AS
45372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4538
4539 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4540
cfe0661d
JB
45412011-03-09 Juanma Barranquero <lekktu@gmail.com>
4542
4543 * search.c (compile_pattern_1): Remove argument regp, unused since
4544 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4545 (compile_pattern): Don't pass it.
4546
0afb4571
J
45472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4548
4549 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4550 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4551 for ! HAVE_GTK3.
4552 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4553
4554 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4555
4556 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4557 gdk_window_get_screen, gdk_window_get_geometry,
4558 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4559 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4560 (xg_get_pixbuf_from_pixmap): New function.
4561 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4562 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4563 Call xg_get_pixbuf_from_pixmap instead of
4564 gdk_pixbuf_get_from_drawable.
4565 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4566 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4567 (xg_check_special_colors): Use GtkStyleContext and its functions
4568 for HAVE_GTK3.
4569 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4570 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4571 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4572 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4573 Call gtk_widget_get_preferred_size.
0afb4571
J
4574 (xg_frame_resized): gdk_window_get_geometry only takes 5
4575 parameters.
44f230aa
SM
4576 (xg_win_to_widget, xg_event_is_for_menubar):
4577 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4578 (xg_set_widget_bg): New function.
4579 (delete_cb): New function.
895009e1 4580 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4581 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4582 (xg_set_background_color): Call xg_set_widget_bg.
4583 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4584 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4585 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4586 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4587 if ! HAVE_GTK3.
4588 (update_frame_tool_bar): Call gtk_widget_hide.
4589 (xg_initialize): Use GDK_KEY_g.
4590
4591 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4592 if ! HAVE_GTK3
4593 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4594
4595 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4596 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4597 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4598
1c2cc4ef
JB
45992011-03-08 Juanma Barranquero <lekktu@gmail.com>
4600
4601 * w32xfns.c (select_palette): Check success of RealizePalette against
4602 GDI_ERROR, not zero.
4603
33383987 4604See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4605
4606;; Local Variables:
4607;; coding: utf-8
aac0c6e3
MR
4608;; End:
4609
33383987 4610 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4611
4612 This file is part of GNU Emacs.
4613
4614 GNU Emacs is free software: you can redistribute it and/or modify
4615 it under the terms of the GNU General Public License as published by
4616 the Free Software Foundation, either version 3 of the License, or
4617 (at your option) any later version.
4618
4619 GNU Emacs is distributed in the hope that it will be useful,
4620 but WITHOUT ANY WARRANTY; without even the implied warranty of
4621 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4622 GNU General Public License for more details.
4623
4624 You should have received a copy of the GNU General Public License
4625 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.