Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8e1f5610
CS
12011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2
3 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4 revision 104625).
5
7025ee00 62011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7
cdfa6eab
PE
8 Fix some integer overflow issues, such as string length overflow.
9
06d6db33
PE
10 * insdel.c (count_size_as_multibyte): Check for string overflow.
11
2b4560a8
PE
12 * character.c (lisp_string_width): Check for string overflow.
13 Use EMACS_INT, not int, for string indexes and lengths; in
14 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
15 the resulting string length overflows an EMACS_INT; instead,
16 report a string overflow if no precision given. When checking for
17 precision exhaustion, use a check that cannot possibly have
18 integer overflow. (Bug#8675)
19 * character.h (lisp_string_width): Adjust to new signature.
20
cb93f9be
PE
21 * alloc.c (string_overflow): New function.
22 (Fmake_string): Use it. This doesn't change behavior, but saves
23 a few bytes and will simplify future changes.
24 * character.c (string_escape_byte8): Likewise.
25 * lisp.h (string_overflow): New decl.
26
1a1f3366
PE
27 Fixups, following up to the user-interface timestamp change.
28 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
29 for UI timestamps, instead of unsigned long.
9fbd6841
PE
30 * msdos.c (mouse_get_pos): Likewise.
31 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
32 * w32gui.h (Time): Define by including "systime.h" rather than by
33 declaring it ourselves. (Bug#8664)
34
d4e3e4d3
PE
35 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
36 * image.c (clear_image_cache): Likewise.
37
f6a24d19
PE
38 * term.c (term_mouse_position): Don't assume time_t wraparound.
39
08dc5ae6
PE
40 Be more systematic about user-interface timestamps.
41 Before, the code sometimes used 'Time', sometimes 'unsigned long',
42 and sometimes 'EMACS_UINT', to represent these timestamps. This
43 change causes it to use 'Time' uniformly, as that's what X uses.
44 This makes the code easier to follow, and makes it easier to catch
45 integer overflow bugs such as Bug#8664.
46 * frame.c (Fmouse_position, Fmouse_pixel_position):
47 Use Time, not unsigned long, for user-interface timestamps.
48 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
49 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
50 * keyboard.h (last_event_timestamp): Likewise.
51 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
52 * menu.h (xmenu_show): Likewise.
53 * term.c (term_mouse_position): Likewise.
54 * termhooks.h (struct input_event.timestamp): Likewise.
55 (struct terminal.mouse_position_hook): Likewise.
56 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
57 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
58 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
59 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
60 what it was before.
61 * menu.h, termhooks.h: Include "systime.h", for Time.
62
8e55734a
PE
63 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
64 Don't assume that the difference between two unsigned long values
65 can fit into an integer. At this point, we know button_down_time
66 <= event->timestamp, so the difference must be nonnegative, so
67 there's no need to cast the result if double-click-time is
68 nonnegative, as it should be; check that it's nonnegative, just in
69 case. This bug is triggered when events are more than 2**31 ms
86db42d2 70 apart (about 25 days). (Bug#8664)
8e55734a 71
841f1b75 72 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 73 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 74
3e26f69c
PE
75 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
76 that always fit in int. Use a sentinel instead of a counter, to
77 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
78 * frame.h (struct frame): Use int for menu_bar_items_used
79 instead of EMACS_INT, since it always fits in int.
3e26f69c 80
5cc152c0
PE
81 * menu.c (grow_menu_items): Check for int overflow.
82
d89eb65e
PE
83 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
84
5235bd3e
PE
85 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
86 Before, the code was not consistent. These values cannot exceed
87 2**31 - 1 so there's no need to make them unsigned.
88 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
89 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
90 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
91 as modifiers.
92 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
93
bc827e23
PE
94 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
95 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
96 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
97 presumably because the widths might not match.
98
78eb494e
PE
99 * window.c (size_window): Avoid needless test at loop start.
100
04f2d78b
CB
1012011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
102
103 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
104
d2fc7e3d 1052011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
106
107 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
108
d2fc7e3d 1092011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
110
111 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
112 `width' to `bar_area_x' and `bar_area_width', respectively.
113 (x_scroll_run): Take account of fringe background extension.
114
04f2d78b
CB
115 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
116 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
117 `bar_area_width', respectively.
118 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
119 background extension.
120
79b70037
GM
1212011-05-10 Jim Meyering <meyering@redhat.com>
122
123 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
124
2f142cc5
JB
1252011-05-10 Juanma Barranquero <lekktu@gmail.com>
126
127 * image.c (Finit_image_library): Return t for built-in image types,
128 like pbm and xbm. (Bug#8640)
129
57679c86
AS
1302011-05-09 Andreas Schwab <schwab@linux-m68k.org>
131
132 * w32menu.c (set_frame_menubar): Fix submenu allocation.
133
888c9e86
EZ
1342011-05-07 Eli Zaretskii <eliz@gnu.org>
135
b0512a1d
EZ
136 * w32console.c (Fset_screen_color): Doc fix.
137 (Fget_screen_color): New function.
138 (syms_of_ntterm): Defsubr it.
139
888c9e86
EZ
140 * callproc.c (call_process_cleanup): Don't close and unlink the
141 temporary file if Fcall_process didn't create it in the first
142 place.
143 (Fcall_process): Don't create tempfile if stdout of the child
144 process will be redirected to a file specified with `:file'.
145 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
146 cue to call_process_cleanup not to close that handle.
147
4d3fcc8e
BK
1482011-05-07 Ben Key <bkey76@gmail.com>
149
150 * makefile.w32-in: The bootstrap-temacs rule now makes use of
151 one of two shell specific rules, either bootstrap-temacs-CMD or
152 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
153 to the previous implementation of the bootstrap-temacs rule.
154 The bootstrap-temacs-CMD rule is similar to the previous
155 implementation of the bootstrap-temacs rule except that it
156 makes use of the ESC_CFLAGS variable instead of the CFLAGS
157 variable.
158
159 These changes, along with some changes to nt/configure.bat,
160 nt/gmake.defs, and nt/nmake.defs, are required to extend my
161 earlier fix to add support for --cflags and --ldflags options
162 that include quotes so that it works whether make uses cmd or
163 sh as the shell.
164
b4289b64
MA
1652011-05-06 Michael Albinus <michael.albinus@gmx.de>
166
167 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
168 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
169 is a constant.
170 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
171 a string. Handle both cases.
172 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
173 (Fdbus_register_method): Use Qinvalid_function.
174
af4c0e28
JB
1752011-05-06 Juanma Barranquero <lekktu@gmail.com>
176
177 * makefile.w32-in: Update dependencies.
178 (LISP_H): Add inttypes.h and stdin.h.
179 (PROCESS_H): Add unistd.h.
180
c51453d9
EZ
1812011-05-06 Eli Zaretskii <eliz@gnu.org>
182
183 * lread.c: Include limits.h (fixes the MS-Windows build broken by
184 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
185
8ff0ac3c 1862011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 187
4c4b566b
PE
188 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
189
aab2b9b5
PE
190 * term.c (vfatal): Remove stray call to va_end.
191 It's not needed and the C Standard doesn't allow it here anyway.
192
c378da0b
PE
193 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
194 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
195
288b08c7
PE
196 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
197 bytes.
198
e3601888
PE
199 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
200
db6c0e74
PE
201 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
202
dd5963ea
PE
203 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
204
88c9450f
PE
205 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
206
2f9442b8
PE
207 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
208
c032b5f8
PE
209 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
210 * charset.c (Fdefine_charset_internal): Don't initialize
211 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 212 32-bit int (Bug#8600).
a108c10b
PE
213
214 * lread.c (read_integer): Be more consistent with string-to-number.
215 Use string_to_number to do the actual conversion; this avoids
216 rounding errors and fixes some other screwups. Without this fix,
217 for example, #x1fffffffffffffff was misread as -2305843009213693952.
218 (digit_to_number): Move earlier, for benefit of read_integer.
219 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 220 not a digit in any supported base. (Bug#8602)
a108c10b 221
ad5f9eea
PE
222 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
223
aec1708a
PE
224 * dispnew.c (scrolling_window): Return 1 if we scrolled,
225 to match comment at start of function. This also removes a
226 GCC warning about overflow in a 32+64-bit port.
227
47be4ab5
PE
228 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
229
371cac43
PE
230 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
231 Reported by Stefan Monnier in
232 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
233 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
234 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 235
d01a7826
PE
236 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
237 (EMACS_UINTPTR): Likewise, with uintptr_t.
238
7fd47d5c
PE
239 * lisp.h: Prefer 64-bit EMACS_INT if available.
240 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
241 on 32-bit hosts that have 64-bit int, so that they can access
242 large files.
122b0c86
PE
243 However, temporarily disable this change unless the temporary
244 symbol WIDE_EMACS_INT is defined.
7fd47d5c 245
8727937b
PE
246 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
247
8ac068ac
PE
248 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
249 This removes an assumption that EMACS_INT and long are the same
250 width as pointers. The assumption is true for Emacs porting targets
251 now, but we want to make other targets possible.
252 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
253 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
254 In the rest of the code, change types of integers that hold casted
255 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
256 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
257 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
258 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
259 No need to cast type when ORing.
260 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
261 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
262 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
263 assume EMACS_INT is the same width as char *.
264 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
265 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
266 Remove no-longer-needed casts.
267 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
268 (xg_tool_bar_help_callback, xg_make_tool_item):
269 Use EMACS_INTPTR to hold an integer
270 that will be cast to void *; this can avoid a GCC warning
271 if EMACS_INT is not the same width as void *.
272 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
273 * xdisp.c (display_echo_area_1, resize_mini_window_1):
274 (current_message_1, set_message_1):
275 Use a local to convert to proper width without a cast.
276 * xmenu.c (dialog_selection_callback): Likewise.
277
ede49d71
PE
278 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
279 Also, don't assume VALBITS / RAND_BITS is less than 5,
280 and don't rely on undefined behavior when shifting a 1 left into
281 the sign bit.
282 * lisp.h (get_random): Change signature to match.
283
2f30ecd0
PE
284 * lread.c (hash_string): Use size_t, not int, for hash computation.
285 Normally we prefer signed values; but hashing is special, because
286 it's better to use unsigned division on hash table sizes so that
287 the remainder is nonnegative. Also, size_t is the natural width
288 for hashing into memory. The previous code used 'int', which doesn't
289 retain enough info to hash well into very large tables.
290 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
291
2a866e7b
PE
292 * dbusbind.c: Don't possibly lose pointer info when converting.
293 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
294 Use XPNTR rather than XHASH, so that the high-order bits of
295 the pointer aren't lost when converting through void *.
296
51639eac
PE
297 * eval.c (Fautoload): Don't double-shift a pointer.
298
92394119
PE
299 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
300
dbdb9a7c
JB
3012011-05-06 Juanma Barranquero <lekktu@gmail.com>
302
303 * gnutls.c (DEF_GNUTLS_FN):
304 * image.c (DEF_IMGLIB_FN): Make function pointers static.
305
db7a0b4f
AS
3062011-05-05 Andreas Schwab <schwab@linux-m68k.org>
307
308 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
309 marker. (Bug#8610)
310
f7ff1b0f 3112011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
312
313 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
314 New version that can reserve upto 2GB of heap space.
315
f7ff1b0f 3162011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
317
318 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
319
639c109b
TZ
3202011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
321
322 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
323 `gnutls_certificate_set_x509_key_file'.
324
d2127135
JB
3252011-05-05 Juanma Barranquero <lekktu@gmail.com>
326
327 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
328 Update dependencies.
329
e968f4f3
JB
3302011-05-04 Juanma Barranquero <lekktu@gmail.com>
331
332 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
333 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
334 Remove unused parameter `fildes'.
335 * process.c (read_process_output, send_process): Don't pass it.
336
84d358f0
JB
3372011-05-04 Juanma Barranquero <lekktu@gmail.com>
338
339 Fix previous change: the library cache is defined in w32.c.
340 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
341 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
342
0898ca10
JB
3432011-05-04 Juanma Barranquero <lekktu@gmail.com>
344
345 Implement dynamic loading of GnuTLS on Windows.
346
347 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
348 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
349 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
350 Declare.
351
352 * gnutls.c (Qgnutls_dll): Define.
353 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
354 (gnutls_*): Declare function pointers.
355 (init_gnutls_functions): New function to initialize function pointers.
356 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
357 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
358 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
359 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
360 (emacs_gnutls_write, emacs_gnutls_read)
361 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
362 (Fgnutls_available_p): New function.
363 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
364 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
365 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
366
367 * image.c: Include w32.h.
368 (Vimage_type_cache): Delete.
369 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
370 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
371 (w32_delayed_load): Move to w32.c.
372
373 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
374
375 * w32.c (QCloaded_from, Vlibrary_cache): Define.
376 (w32_delayed_load): Move from image.c. When loading a library, record
377 its filename in the :loaded-from property of the library id.
378 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
379 Initialize and staticpro them.
380 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
381
382 * process.c: Include lisp.h before w32.h, not after.
383 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
384 instead of gnutls_record_check_pending.
385
386 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
387
ff4de4aa
TZ
3882011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
389
390 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
391 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
392 as passed in.
393
abe95abb
JD
3942011-05-03 Jan Djärv <jan.h.d@swipnet.se>
395
396 * xterm.c (x_set_frame_alpha): Do not set property on anything
397 else than FRAME_X_OUTER_WINDOW (Bug#8608).
398
e16e55d4
JB
3992011-05-02 Juanma Barranquero <lekktu@gmail.com>
400
401 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
402
bafcf6a5
JB
4032011-05-02 Juanma Barranquero <lekktu@gmail.com>
404
405 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
406 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
407 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
408 (gnutls_global_initialized, Qgnutls_bootprop_priority)
409 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
410 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
411 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
412 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
413 (Qgnutls_bootprop_callbacks_verify): Make static.
414
e7a6747f
AS
4152011-05-01 Andreas Schwab <schwab@linux-m68k.org>
416
19ed11ba
AS
417 * callproc.c: Indentation fixup.
418
e7a6747f 419 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
420 (wait_for_termination, interruptible_wait_for_termination):
421 Move after wait_for_termination_1.
e7a6747f 422
1ef14cb4
LMI
4232011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
424
425 * sysdep.c (interruptible_wait_for_termination): New function
426 which is like wait_for_termination, but allows keyboard
427 interruptions.
428
429 * callproc.c (Fcall_process): Add (:file "file") as an option for
430 the STDOUT buffer.
431 (Fcall_process_region): Ditto.
432
330d880c
EZ
4332011-04-30 Eli Zaretskii <eliz@gnu.org>
434
8db90b73
EZ
435 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
436 rather than `XVECTOR (FOO)->size'.
437
330d880c
EZ
438 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
439 inttypes.h, as a gnulib replacement is used if it not available in
440 system headers.
441
15cbd324
EZ
4422011-04-21 Eli Zaretskii <eliz@gnu.org>
443
444 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
445 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
446 of MOST_POSITIVE_FIXNUM. (Bug#8528)
447
448 * coding.c (coding_alloc_by_realloc): Error out if destination
449 will grow beyond MOST_POSITIVE_FIXNUM.
450 (decode_coding_emacs_mule): Abort if there isn't enough place in
451 charbuf for the composition carryover bytes. Reserve an extra
452 space for up to 2 characters produced in a loop.
453 (decode_coding_iso_2022): Abort if there isn't enough place in
454 charbuf for the composition carryover bytes.
455
4562011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 457
ae940cca
EZ
458 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
459 aborting when %lld or %lll format is passed.
460 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
461 %llo or %llx format is passed. (Bug#8545)
462
03ab8921
EZ
463 * window.c (window_scroll_line_based): Use a marker instead of
464 simple variables to record original value of point. (Bug#7952)
465
afda1437
EZ
466 * doprnt.c (doprnt): Fix the case where a multibyte sequence
467 produced by %s or %c overflows available buffer space. (Bug#8545)
468
f76dee0c
PE
4692011-04-28 Paul Eggert <eggert@cs.ucla.edu>
470
471 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 472 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 473
fdc5744d
JB
4742011-04-28 Juanma Barranquero <lekktu@gmail.com>
475
476 * w32.c (init_environment): Warn about defaulting HOME to C:\.
477
638f053a
JB
4782011-04-28 Juanma Barranquero <lekktu@gmail.com>
479
480 * keyboard.c (Qdelayed_warnings_hook): Define.
481 (command_loop_1): Run `delayed-warnings-hook'
482 if Vdelayed_warnings_list is non-nil.
483 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
484 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
485
d178f871
EZ
4862011-04-28 Eli Zaretskii <eliz@gnu.org>
487
488 * doprnt.c (doprnt): Don't return value smaller than the buffer
489 size if the message was truncated. (Bug#8545).
490
b124fd93
JB
4912011-04-28 Juanma Barranquero <lekktu@gmail.com>
492
493 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
494 (Fx_window_property): #if-0 the whole functions, not just the bodies.
495
e810457d
PE
4962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
497
498 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
499
ea51cceb
JB
5002011-04-27 Juanma Barranquero <lekktu@gmail.com>
501
502 * makefile.w32-in: Update dependencies.
503
94dcfacf
EZ
5042011-04-27 Eli Zaretskii <eliz@gnu.org>
505
506 Improve `doprnt' and its usage. (Bug#8545)
507 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
508 `format_end'. Remove support for %l as a conversion specifier.
509 Don't use xrealloc. Improve diagnostics when the %l size modifier
510 is used. Update the commentary.
511
512 * eval.c (verror): Simplify calculation of size_t.
513
514 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
515 messages.
516
f61f41d7
PE
5172011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
518
519 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
520 change.
521
96fb4434
PE
5222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
523
524 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
525 This makes this file independent of the recent pseudovector change.
526
671875da 5272011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 528
69e9b5a3
PE
529 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
530
b5f869a7 531 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 532 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 533 Remove unused local.
c8926152 534 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 535
841a1577 536 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
537 GCC 4.6.0 optimizes based on type-based alias analysis.
538 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
539 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
540 != &v->size, and therefore "v->size = 1; b->size = 2; return
541 v->size;" must therefore return 1. This assumption is incorrect
542 for Emacs, since it type-puns struct Lisp_Vector * with many other
543 types. To fix this problem, this patch adds a new type struct
f904488f 544 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
545 and pseudovectors, and helps optimizing compilers not get fooled
546 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
547 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
548 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
549 the size member.
eab3844f
PE
550 (XSETPVECTYPE): Rewrite in terms of new macro.
551 (XSETPVECTYPESIZE): New macro, specifying both type and size.
552 This is a bit clearer, and further avoids the possibility of
553 undesirable aliasing.
554 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 555 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
556 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
557 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
558 (ASIZE): Now uses header.size rather than size.
559 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
560 to avoid the hassle of writing XVECTOR (foo)->header.size.
561 (struct vectorlike_header): New type.
eab3844f
PE
562 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
563 object, to help avoid aliasing.
564 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
565 (SUBRP): Likewise, since Lisp_Subr is a special case.
566 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
567 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
568 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 569 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
570 changed to be "header.size" and "header.next".
571 * buffer.h (struct buffer): Likewise.
572 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
573 * frame.h (struct frame): Likewise.
574 * process.h (struct Lisp_Process): Likewise.
575 * termhooks.h (struct terminal): Likewise.
576 * window.c (struct save_window_data, struct saved_window): Likewise.
577 * window.h (struct window): Likewise.
578 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
579 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
580 * buffer.c (init_buffer_once): Likewise.
581 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
582 special case.
583 * process.c (Fformat_network_address): Use local var for size,
584 for brevity.
585
0df1eac5
PE
586 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
587
847ab9d1 588 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
589 * data.c (atof): Remove decl; no longer used or needed.
590 (digit_to_number): Move to lread.c.
591 (Fstring_to_number): Use new string_to_number function, to be
592 consistent with how the Lisp reader treats infinities and NaNs.
593 Do not assume that floating-point numbers represent EMACS_INT
594 without losing information; this is not true on most 64-bit hosts.
595 Avoid double-rounding errors, by insisting on integers when
596 parsing non-base-10 numbers, as the documentation specifies.
597 * lisp.h (string_to_number): New decl, replacing ...
598 (isfloat_string): Remove.
bc0a5c13 599 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 600 (read1): Do not accept +. and -. as integers; this
452f4150
PE
601 appears to have been a coding error. Similarly, do not accept
602 strings like +-1e0 as floating point numbers. Do not report
603 overflow for integer overflows unless the base is not 10 which
604 means we have no simple and reliable way to continue.
605 Break out the floating-point parsing into a new
606 function string_to_number, so that Fstring_to_number parses
607 floating point numbers consistently with the Lisp reader.
04f2d78b 608 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
609 (E_CHAR, EXP_INT): Remove, replacing with ...
610 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
611 (string_to_number): New function, replacing isfloat_string.
612 This function checks for valid syntax and produces the resulting
613 Lisp float number too. Rework it so that string-to-number
bc0a5c13 614 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
615 so that overflow for non-base-10 numbers is reported only when
616 there's no portable and simple way to convert to floating point.
452f4150 617
67769ffc
PE
618 * textprop.c (set_text_properties_1): Rewrite for clarity,
619 and to avoid GCC warning about integer overflow.
620
c20db43f
PE
621 * intervals.h (struct interval): Use EMACS_INT for members
622 where EMACS_UINT might cause problems. See
623 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
624 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
625 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
626 All uses changed.
37aa2f85
PE
627 (offset_intervals): Tell GCC not to worry about length overflow
628 when negating a negative length.
c20db43f 629
2538aa2f
PE
630 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
631 (overrun_check_free): Likewise.
632
f2d3008d
PE
633 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
634 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
635 word size.
636
ec8df744
PE
637 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
638 (gnutls_make_error): Rename local to avoid shadowing.
639 (gnutls_emacs_global_deinit): ifdef out; not used.
640 (Fgnutls_boot): Use const for pointer to readonly storage.
641 Comment out unused local. Fix pointer signedness problems.
642
640ee02d
PE
643 * lread.c (openp): Don't stuff size_t into an 'int'.
644 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
645 about possible signed overflow.
646
6048fb2a
PE
647 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
648 (GDK_KEY_g): Don't define if already defined.
649 (xg_prepare_tooltip): Avoid pointer signedness problem.
650 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
651
fa3c87e1
PE
652 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
653 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
654
2172544b
PE
655 * xfns.c (Fx_window_property): Simplify a bit,
656 to make a bit faster and to avoid GCC 4.6.0 warning.
657 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
658
9b821a21
PE
659 * fns.c (internal_equal): Don't assume size_t fits in int.
660
3c616cfa
PE
661 * alloc.c (compact_small_strings): Tighten assertion a little.
662
c2982e87
PE
663 Replace pEd with more-general pI, and fix some printf arg casts.
664 * lisp.h (pI): New macro, generalizing old pEd macro to other
665 conversion specifiers. For example, use "...%"pI"d..." rather
666 than "...%"pEd"...".
667 (pEd): Remove. All uses replaced with similar uses of pI.
668 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
669 * alloc.c (check_pure_size): Don't overflow by converting size to int.
670 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
671 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
672 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
673 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
674 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
675 64-bit hosts.
676 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
677 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
678 * print.c (safe_debug_print, print_object): Likewise.
679 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
680 to int.
6f04d126
PE
681 Use pI instead of if-then-else-abort. Use %p to avoid casts,
682 avoiding the 0 flag, which is not portable.
c2982e87
PE
683 * process.c (Fmake_network_process): Use pI to avoid cast.
684 * region-cache.c (pp_cache): Likewise.
685 * xdisp.c (decode_mode_spec): Likewise.
686 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
687 behavior on 64-bit hosts with printf arg.
6f04d126 688 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
689 (x_stop_queuing_selection_requests): Likewise.
690 (x_get_window_property): Don't truncate byte count to an 'int'
691 when tracing.
0b432f21 692
5e073ec7
PE
693 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
694 here, since it parses constructs like leading '-' and spaces,
695 which are not wanted; and it overflows with large numbers.
696 Instead, simply match F[0-9]+, which is what is wanted anyway.
697
36372bf9
PE
698 * alloc.c: Remove unportable assumptions about struct layout.
699 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
700 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
701 (allocate_vectorlike, make_pure_vector): Use the new macros,
702 plus offsetof, to remove unportable assumptions about struct layout.
703 These assumptions hold on all porting targets that I know of, but
704 they are not guaranteed, they're easy to remove, and removing them
705 makes further changes easier.
706
0b432f21
PE
707 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
708 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
709 (string_overrun_cookie): Now const. Use initializers that
710 don't formally overflow signed char, to avoid warnings.
000098c1
PE
711 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
712 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
713 (allocate_buffer): Don't assume sizeof (struct buffer) is a
714 multiple of sizeof (EMACS_INT); it need not be, if
715 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 716 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 717
895009e1
JB
7182011-04-26 Juanma Barranquero <lekktu@gmail.com>
719
720 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
721
6a7a1b0b
TZ
7222011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
723
724 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 725 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
726 Reported by Paul Eggert <eggert@cs.ucla.edu>.
727
841a1577 7282011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
729
730 * lisp.h (Qdebug): List symbol.
895009e1 731 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
732 * keyboard.c (debug-on-event): New variable.
733 (handle_user_signal): Break into debugger when debug-on-event
734 matches the current signal symbol.
735
f2d3ba6f
DN
7362011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
737
738 * alloc.c (check_sblock, check_string_bytes)
739 (check_string_free_list): Convert to standard C.
740
42ce4c63
TZ
7412011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
742
743 * w32.c (emacs_gnutls_push): Fix typo.
744
825cd63c
EZ
7452011-04-25 Eli Zaretskii <eliz@gnu.org>
746
fb11d64d
EZ
747 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
748 "cast to pointer from integer of different size".
749
825cd63c
EZ
750 Improve doprnt and its use in verror. (Bug#8545)
751 * doprnt.c (doprnt): Document the set of format control sequences
752 supported by the function. Use SAFE_ALLOCA instead of always
753 using `alloca'.
754
755 * eval.c (verror): Don't limit the buffer size at size_max-1, that
756 is one byte too soon. Don't use xrealloc; instead xfree and
757 xmalloc anew.
758
e061a11b
TZ
7592011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
760
761 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
762 callbacks stage.
763
764 * gnutls.c: Renamed global_initialized to
765 gnutls_global_initialized. Added internals for the
766 :verify-hostname-error, :verify-error, and :verify-flags
767 parameters of `gnutls-boot' and documented those parameters in the
768 docstring. Start callback support.
769 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
770 unless a fatal error occured. Call gnutls_alert_send_appropriate
771 on error. Return error code.
772 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
773 (emacs_gnutls_read): Likewise.
774 (Fgnutls_boot): Return handshake error code.
775 (emacs_gnutls_handle_error): New function.
776 (wsaerror_to_errno): Likewise.
777
778 * w32.h (emacs_gnutls_pull): Add prototype.
779 (emacs_gnutls_push): Likewise.
780
781 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
782 (emacs_gnutls_push): Likewise.
783
7842011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
785
786 * process.c (wait_reading_process_output): Check if GnuTLS
787 buffered some data internally if no FDs are set for TLS
788 connections.
789
790 * makefile.w32-in (OBJ2): Add gnutls.$(O).
791 (LIBS): Link to USER_LIBS.
792 ($(BLD)/gnutls.$(0)): New target.
793
fa6996bc
EZ
7942011-04-24 Eli Zaretskii <eliz@gnu.org>
795
eb35682e
EZ
796 * xdisp.c (handle_single_display_spec): Rename the
797 display_replaced_before_p argument into display_replaced_p, to
798 make it consistent with the commentary. Fix typos in the
799 commentary.
800
e2ad650c
EZ
801 * textprop.c (syms_of_textprop): Remove dead code.
802 (copy_text_properties): Delete obsolete commentary about an
803 interface that was deleted long ago. Fix typos in the description
804 of arguments.
805
1b2de274
EZ
806 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
807 to changes in oldXMenu/XMenu.h from 2011-04-16.
808 <menu_help_message, prev_menu_help_message>: Constify.
809 (IT_menu_make_room): menu->help_text is now `const char **';
810 adjust.
811
812 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
813 to changes in oldXMenu/XMenu.h from 2011-04-16.
814 (struct XMenu): Declare `help_text' `const char **'.
815
816 * xfaces.c <Qunspecified>: Make extern again.
817
818 * syntax.c: Include sys/types.h before including regex.h, as
819 required by Posix.
820
762b15be
EZ
821 * doc.c (get_doc_string): Improve the format passed to `error'.
822
823 * doprnt.c (doprnt): Improve commentary.
824
825 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
826
827 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
828 them with etags.
829
f1052e5d
EZ
830 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
831 changes in globals.h immediately force recompilation.
762b15be
EZ
832 (TAGS): Depend on $(CURDIR)/m/intel386.h and
833 $(CURDIR)/s/ms-w32.h.
834 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 835
fa6996bc
EZ
836 * character.c (Fchar_direction): Function deleted.
837 (syms_of_character): Don't defsubr it.
838 <char-direction-table>: Deleted.
839
e6c3da20
EZ
8402011-04-23 Eli Zaretskii <eliz@gnu.org>
841
842 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
843 * doprnt.c: Include limits.h.
844 (SIZE_MAX): New macro.
04f2d78b
CB
845 (doprnt): Return a size_t value. 2nd arg is now size_t.
846 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
847 Improve overflow protection. Support `l' modifier for integer
848 conversions. Support %l conversion. Don't assume an EMACS_INT
849 argument for integer conversions and for %c.
850
851 * lisp.h (doprnt): Restore prototype.
852
853 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
854 $(SRC)/character.h.
855
856 * Makefile.in (base_obj): Add back doprnt.o.
857
858 * deps.mk (doprnt.o): Add back prerequisites.
859 (callint.o): Depend on character.h.
860
861 * eval.c (internal_lisp_condition_case): Include the handler
862 representation in the error message.
863 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
864 when breaking from the loop.
865
866 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
867
868 * callint.c (Fcall_interactively): When displaying error message
869 about invalid control letter, pass the character's codepoint, not
870 a pointer to its multibyte form. Improve display of the character
871 in octal and display also its hex code.
872
873 * character.c (char_string): Use %x to display the (unsigned)
874 codepoint of an invalid character, to avoid displaying a bogus
875 negative value.
876
877 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
878 `error', not SYMBOL_NAME itself.
879
880 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
881 character arguments to `error'.
882
883 * charset.c (check_iso_charset_parameter): Fix incorrect argument
884 to `error' in error message about FINAL_CHAR argument. Make sure
885 FINAL_CHAR is a character, and use %c when it is passed as
886 argument to `error'.
887
4ffd0d6b 8882011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
889
890 * s/ms-w32.h (localtime): Redirect to sys_localtime.
891
892 * w32.c: Include <time.h>.
893 (sys_localtime): New function.
894
4ffd0d6b 8952011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
896
897 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
898
4ffd0d6b 899 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 900
4ffd0d6b 9012011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 902
4ffd0d6b
GM
903 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
904 zombies (Bug#8467).
aac0c6e3 905
04c56954
EZ
9062011-04-19 Eli Zaretskii <eliz@gnu.org>
907
908 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
909 gl_state.e_property when gl_state.object is Qt.
910
911 * insdel.c (make_gap_larger): Remove limitation of buffer size
912 to <= INT_MAX.
913
16a43933
CY
9142011-04-18 Chong Yidong <cyd@stupidchicken.com>
915
916 * xdisp.c (lookup_glyphless_char_display)
917 (produce_glyphless_glyph): Handle cons cell entry in
918 glyphless-char-display.
919 (Vglyphless_char_display): Document it.
920
921 * term.c (produce_glyphless_glyph): Handle cons cell entry in
922 glyphless-char-display.
923
4581706e
CY
9242011-04-17 Chong Yidong <cyd@stupidchicken.com>
925
926 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
927
928 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
929
930 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
931 definition for no-X builds.
932
4887c6e2 9332011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 934
fd35b6f9
PE
935 Static checks with GCC 4.6.0 and non-default toolkits.
936
5c1ccb01
PE
937 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
938
006c5daa
PE
939 * process.c (keyboard_bit_set): Define only if SIGIO.
940 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
941 (send_process): Repair possible setjmp clobbering.
942
efc736d3
PE
943 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
944
4e2fe2e6
PE
945 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
946
f97334a2
PE
947 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
948
4e75f29d
PE
949 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
950 Define only if needed.
951
90efadd1
PE
952 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
953 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 954 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 955
3c647824
PE
956 * dispextern.h (struct redisplay_interface): Rename param
957 to avoid shadowing.
e264f262 958 * termhooks.h (struct terminal): Likewise.
761383f4 959 * xterm.c (xembed_send_message): Likewise.
3c647824 960
b58c5c4a
PE
961 * insdel.c (make_gap_smaller): Define only if
962 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
963
cad59032
PE
964 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
965 it.
966
c339dc2e
PE
967 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
968 so that we aren't warned about unused symbols.
969
91a3e27b
PE
970 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
971
399c71d3 972 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 973
8ffc96f5
PE
974 * xfns.c (x_real_positions): Mark locals as initialized.
975
eef9bc79
PE
976 * xmenu.c (xmenu_show): Don't use uninitialized vars.
977
098db9dd
PE
978 * xterm.c: Fix problems found by static analysis with other toolkits.
979 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
980 (x_dispatch_event): Declare static if USE_GTK, and
981 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 982 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 983 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
984 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
985 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 986
eb18f6cc
PE
987 * xmenu.c (menu_help_callback): Pointer type fixes.
988 Use const pointers when pointing at readonly data. Avoid pointer
989 signedness clashes.
990 (FALSE): Remove unused macro.
991 (update_frame_menubar): Remove unused decl.
992
1fe72bf8
PE
993 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
994
60d9e1db
PE
995 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
996 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
997 (single_menu_item): Rename local to avoid shadowing.
998
39261c26
PE
999 * keyboard.c (make_lispy_event): Remove unused local var.
1000
018c5e19
PE
1001 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1002 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1003
63d2b86e
PE
1004 * bitmaps: Change bitmaps from unsigned char back to the X11
1005 compatible char. Avoid the old compiler warnings about
1006 out-of-range initializers by using, for example, '\xab' rather
1007 than 0xab.
1008
aefd87e1
PE
1009 * xgselect.c (xgselect_initialize): Check vs interface
1010 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1011
bf501fb9
PE
1012 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1013
e9829fdf
PE
1014 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1015 to read-only memory.
1016
1086c095
PE
1017 * fns.c (vector): Remove; this old hack is no longer needed.
1018
2baccd04 1019 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1020 Remove unused var.
dde42981 1021 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1022
72391843 1023 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1024
436c16df 1025 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1026 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1027 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1028
92bb796d 1029 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1030 (x_term_init): Remove local to avoid shadowing.
92bb796d 1031
764430a3 1032 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1033
1034 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1035 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1036
d1dfb56c
EZ
10372011-04-16 Eli Zaretskii <eliz@gnu.org>
1038
c4354cb4
EZ
1039 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1040
d1dfb56c
EZ
1041 Fix regex.c, syntax.c and friends for buffers > 2GB.
1042 * syntax.h (struct gl_state_s): Declare character position members
1043 EMACS_INT.
1044
1045 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1046
04f2d78b
CB
1047 * textprop.c (verify_interval_modification, interval_of):
1048 Declare arguments EMACS_INT.
d1dfb56c
EZ
1049
1050 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1051 EMACS_INT.
1052
1053 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1054
1055 * indent.c (Fvertical_motion): Local variable it_start is now
1056 EMACS_INT.
1057
1058 * regex.c (re_match, re_match_2, re_match_2_internal)
1059 (bcmp_translate, regcomp, regexec, print_double_string)
1060 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1061 (re_compile_pattern, re_exec): Declare arguments and local
1062 variables `size_t' and `ssize_t' and return values `regoff_t', as
1063 appropriate.
1064 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1065 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1066 <compile_stack_type>: `size' and `avail' are now `size_t'.
1067
1068 * regex.h <regoff_t>: Use ssize_t, not int.
1069 (re_search, re_search_2, re_match, re_match_2): Arguments that
1070 specify buffer/string position and length are now ssize_t and
1071 size_t. Return type is regoff_t.
1072
613052cd
BK
10732011-04-16 Ben Key <bkey76@gmail.com>
1074
1075 * nsfont.m: Fixed bugs in ns_get_family and
1076 ns_descriptor_to_entity that were caused by using free to
1077 deallocate memory blocks that were allocated by xmalloc (via
1078 xstrdup). This caused Emacs to crash when compiled with
1079 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1080 --enable-checking=xmallocoverrun). xfree is now used to
1081 deallocate these memory blocks.
1082
4170f62f 10832011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1084
71b41406
PE
1085 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1086
9587a89d
PE
1087 emacs_write: Accept and return EMACS_INT for sizes.
1088 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1089 et seq.
1090 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1091 Accept and return EMACS_INT.
1092 (emacs_gnutls_write): Return the number of bytes written on
1093 partial writes.
1094 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1095 (emacs_read, emacs_write): Remove check for negative size, as the
1096 Emacs source code has been audited now.
9587a89d
PE
1097 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1098 (emacs_read, emacs_write): Use it.
273a5f82
PE
1099 * process.c (send_process): Adjust to the new signatures of
1100 emacs_write and emacs_gnutls_write. Do not attempt to store
1101 a byte offset into an 'int'; it might overflow.
9587a89d 1102 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1103
3e047f51
PE
1104 * sound.c: Don't assume sizes fit in 'int'.
1105 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1106 Return EMACS_INT, not int.
3e047f51 1107 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1108 Accept EMACS_INT, not int.
1109 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1110 record read return values.
1111
cc39a9db
BK
11122011-04-15 Ben Key <bkey76@gmail.com>
1113
c9d0ec6d
JB
1114 * keyboard.c (Qundefined): Don't declare static since it is used
1115 in nsfns.m.
1116 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1117 static since they are used in nsfont.m.
cc39a9db 1118
6c60eb9f
SM
11192011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1120
1121 * process.c (Qprocessp): Don't declare static.
1122 * lisp.h (Qprocessp): Declare again.
1123
7990b61a
JB
11242011-04-15 Juanma Barranquero <lekktu@gmail.com>
1125
1126 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1127
5d4cb038
PE
11282011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1129
8bd7b830 1130 Improve C-level modularity by making more things 'static'.
cd64ea1d 1131
e3b27b31
PE
1132 Don't publish debugger-only interfaces to other modules.
1133 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1134 (verify_bytepos, count_markers): Move decls to the only modules
1135 that need them.
1136 * region-cache.h (pp_cache): Likewise.
1137 * window.h (check_all_windows): Likewise.
1138 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1139
5d4cb038
PE
1140 * sysdep.c (croak): Now static, if
1141 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1142 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1143
1144 * alloc.c (refill_memory_reserve): Now static if
1145 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1146 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1147
e87b6180
PE
1148 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1149 Define only if USE_LUCID.
1150
ac64929e
PE
1151 * xrdb.c (x_customization_string, x_rm_string): Now static.
1152
6f37259d
PE
1153 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1154 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1155
1683e3ab
PE
1156 * xdisp.c (draw_row_with_mouse_face): Now static.
1157 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1158
de9c2632
PE
1159 * window.h (check_all_windows): Mark externally visible.
1160
2b96acb7
PE
1161 * window.c (window_deletion_count): Now static.
1162
1163 * undo.c: Make symbols static if they're not exported.
1164 (last_undo_buffer, last_boundary_position, pending_boundary):
1165 Now static.
1166
50436f33
PE
1167 * textprop.c (interval_insert_behind_hooks): Now static.
1168 (interval_insert_in_front_hooks): Likewise.
1169
64520e5c
PE
1170 * term.c: Make symbols static if they're not exported.
1171 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1172 (max_frame_lines, tty_set_terminal_modes):
1173 (tty_reset_terminal_modes, tty_turn_off_highlight):
1174 (get_tty_terminal): Now static.
1175 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1176 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1177 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1178 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1179 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1180
1fa53021
PE
1181 * sysdep.c: Make symbols static if they're not exported.
1182 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1183 Now static.
1184 (sigprocmask_set, full_mask): Remove; unused.
1185 (wait_debugging): Mark as visible.
1186 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1187 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1188
d4b43b22
PE
1189 * syntax.c (syntax_temp): Define only if !__GNUC__.
1190
b7c513d0
PE
1191 * sound.c (current_sound_device, current_sound): Now static.
1192
989b29ad
PE
1193 * search.c (searchbufs, searchbuf_head): Now static.
1194
13a55a78
PE
1195 * scroll.c (scroll_cost): Remove; unused.
1196 * dispextern.h (scroll_cost): Remove decl.
1197
de68a1fc
PE
1198 * region-cache.h (pp_cache): Mark as externally visible.
1199
40ccffa6
PE
1200 * process.c: Make symbols static if they're not exported.
1201 (process_tick, update_tick, create_process, chan_process):
1202 (Vprocess_alist, proc_buffered_char, datagram_access):
1203 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1204 (deactivate_process): Mark defn as static, as well as decl.
1205 * lisp.h (create_process): Remove decl.
1206 * process.h (chan_process, Vprocess_alist): Remove decls.
1207
ad64fc97
PE
1208 * print.c: Make symbols static if they're not exported.
1209 (print_depth, new_backquote_output, being_printed, print_buffer):
1210 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1211 (print_interval, print_number_index, initial_stderr_stream):
1212 Now static.
1213 * lisp.h (Fprinc): Remove decl.
1214 (debug_output_compilation_hack): Mark as externally visible.
1215
adddb265
PE
1216 * sysdep.c (croak): Move decl from here to syssignal.h.
1217 * syssignal.h (croak): Put it here, so the API can be checked when
1218 'croak' is called from dissociate_if_controlling_tty.
1219
1717ede2
PE
1220 * minibuf.c: Make symbols static if they're not exported.
1221 (minibuf_save_list, choose_minibuf_frame): Now static.
1222 * lisp.h (choose_minibuf_frame): Remove decl.
1223
fa5fb2bc
PE
1224 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1225
1e3890d1
PE
1226 * lread.c: Make symbols static if they're not exported.
1227 (read_objects, initial_obarray, oblookup_last_bucket_number):
1228 Now static.
1229 (make_symbol): Remove; unused.
1230 * lisp.h (initial_obarray, make_symbol): Remove decls.
1231
8a1414fa
PE
1232 * keyboard.c: Make symbols static if they're not exported.
1233 (single_kboard, recent_keys_index, total_keys, recent_keys):
1234 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1235 (this_single_command_key_start, echoing, last_auto_save):
1236 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1237 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1238 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1239 (Vlispy_mouse_stem, double_click_count):
1240 Now static.
1241 (force_auto_save_soon): Define only if SIGDANGER.
1242 (ignore_mouse_drag_p): Now static if
1243 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1244 (print_help): Remove; unused.
1245 (stop_character, last_timer_event): Mark as externally visible.
1246 * keyboard.h (ignore_mouse_drag_p): Declare only if
1247 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1248 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1249 * lisp.h (echoing): Remove decl.
1250 (force_auto_save_soon): Declare only if SIGDANGER.
1251 * xdisp.c (redisplay_window): Simplify code, to make it more
1252 obvious that ignore_mouse_drag_p is not accessed if !defined
1253 USE_GTK && !defined HAVE_NS.
1254
93ea6e8f
PE
1255 * intervals.c: Make symbols static if they're not exported.
1256 (merge_properties_sticky, merge_interval_right, delete_interval):
1257 Now static.
1258 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1259
77382fcc
PE
1260 * insdel.c: Make symbols static if they're not exported.
1261 However, leave prepare_to_modify_buffer alone. It's never
1262 called from outside this function, but that appears to be a bug.
1263 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1264 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1265 (adjust_after_replace_noundo): Remove; unused.
1266 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1267 (signal_before_change): Remove decls.
77382fcc 1268
9306c32e
PE
1269 * indent.c (val_compute_motion, val_vmotion): Now static.
1270
cd44d2eb
PE
1271 * image.c: Make symbols static if they're not exported.
1272 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1273 if USE_GTK.
1274 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1275 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1276
ad9a7a06
PE
1277 * fringe.c (standard_bitmaps): Now static.
1278 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1279
81626931
PE
1280 * frame.c: Make symbols static if they're not exported.
1281 (x_report_frame_params, make_terminal_frame): Now static.
1282 (get_frame_param): Now static, unless HAVE_NS.
1283 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1284 (x_get_resource_string): Remove; not used.
1285 * frame.h (make_terminal_frame, x_report_frame_params):
1286 (x_get_resource_string); Remove decls.
1287 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1288 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1289
239f9db9
PE
1290 * font.c, fontset.c: Make symbols static if they're not exported.
1291 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1292 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1293 * font.c (font_close_object): Now static.
1294 * font.h (font_close_object): Remove.
1295 * fontset.c (FONTSET_OBJLIST): Remove.
1296 (free_realized_fontset) #if-0 the body, which does nothing.
1297 (face_suitable_for_char_p): #if-0, as it's never called.
1298 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1299 * xfaces.c (face_at_string_position):
1300 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1301 since 0 is always ASCII.
1302
dfcf3579
PE
1303 * fns.c (weak_hash_tables): Now static.
1304
5045092b
PE
1305 * fileio.c: Make symbols static if they're not exported.
1306 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1307 (Vwrite_region_annotation_buffers): Now static.
1308
57a96f5c
PE
1309 * eval.c: Make symbols static if they're not exported.
1310 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1311 * lisp.h (backtrace_list): Remove decl.
1312
35f08c38
PE
1313 * emacs.c: Make symbols static if they're not exported.
1314 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1315 (fatal_error_code, fatal_error_signal_hook, standard_args):
1316 Now static.
1317 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1318 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1319 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1320 * lisp.h (fatal_error_signal_hook): Remove decl.
1321 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1322
f44bd759
PE
1323 * editfns.c: Move a (normally-unused) function to its only use.
1324 * editfns.c, lisp.h (get_operating_system_release): Remove.
1325 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1326 worth the hassle of breaking this out.
1327
b532497d
PE
1328 * xterm.c: Make symbols static if they're not exported.
1329 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1330 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1331 (x_destroy_window, x_delete_display):
1332 Now static.
1333 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1334 (x_mouse_leave): Remove; unused.
1335 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1336 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1337 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1338 Remove decls.
1339 (x_mouse_leave): Declare only if WINDOWSNT.
1340 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1341 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1342 USE_X_TOOLKIT.
1343
1675728f
PE
1344 * ftxfont.c: Make symbols static if they're not exported.
1345 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1346 HAVE_FREETYPE.
1347 * font.h (ftxfont_driver): Likewise.
1348
e4cebfca
PE
1349 * xfns.c: Make symbols static if they're not exported.
1350 (x_last_font_name, x_display_info_for_name):
1351 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1352 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1353 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1354 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1355 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1356 (last_show_tip_args): Now static.
1357 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1358 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1359 (x_screen_planes): Remove; unused.
1360 * dispextern.h (x_screen_planes): Remove decl.
1361
5bf46f05
PE
1362 * dispnew.c: Make symbols static if they're not exported.
1363 * dispextern.h (redraw_garbaged_frames, scrolling):
1364 (increment_row_positions): Remove.
1365 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1366 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1367 Now static.
1368 (redraw_garbaged_frames): Remove; unused.
1369
435f4c28
PE
1370 * xfaces.c: Make symbols static if they're not exported.
1371 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1372 Remove decls.
1373 * xterm.h (defined_color): Remove decls.
1374 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1375 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1376 (menu_face_changed_default, defined_color, free_realized_face):
1377 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1378 (ascii_face_of_lisp_face): Remove; unused.
1379
8524aef3
PE
1380 * xdisp.c: Make symbols static if they're not exported.
1381 * dispextern.h (scratch_glyph_row, window_box_edges):
1382 (glyph_to_pixel_coords, set_cursor_from_row):
1383 (get_next_display_element, set_iterator_to_next):
1384 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1385 (show_mouse_face): Remove decls
1386 * frame.h (message_buf_print): Likewise.
1387 * lisp.h (pop_message, set_message, check_point_in_composition):
1388 Likewise.
1389 * xterm.h (set_vertical_scroll_bar): Likewise.
1390 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1391 (message_buf_print, scratch_glyph_row, displayed_buffer):
1392 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1393 (get_next_display_element, show_mouse_face, window_box_edges):
1394 (frame_to_window_pixel_xy, check_point_in_composition):
1395 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1396 (glyph_to_pixel_coords): Remove; unused.
1397
16390cd2
PE
1398 * dired.c (file_name_completion): Now static.
1399
1400 * dbusbind.c (xd_in_read_queued_messages): Now static.
1401
a25f4dfa
PE
1402 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1403 * data.c (circular_list_error): Remove.
1404
14a9c8df
PE
1405 * commands.h (last_point_position, last_point_position_buffer):
1406 (last_point_position_window): Remove decls.
1407 * keyboard.c: Make these variables static.
1408
04f2d78b
CB
1409 * coding.h (coding, code_convert_region, encode_coding_gap):
1410 Remove decls.
74ab6df5
PE
1411 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1412 (iso_code_class, detect_coding, code_convert_region): Now static.
1413 (encode_coding_gap): Remove; unused.
1414
38dfbee1
PE
1415 * chartab.c (chartab_chars, chartab_bits): Now static.
1416
a2cb4e63
PE
1417 * charset.h (charset_iso_8859_1): Remove decl.
1418 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1419 Now static.
1420
127198fd
PE
1421 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1422 * ccl.c (Vccl_program_table): Now static.
1423 (check_ccl_update): Remove; unused.
1424
d85b608f
PE
1425 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1426 * category.h: ... from here.
1427 * category.c (check_category_table, set_category_set): Now static.
1428
31cd66f3
PE
1429 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1430 * lisp.h: Remove these decls.
1431
c358e587
PE
1432 * buffer.c (buffer_count): Remove unused var.
1433
e78aecca
PE
1434 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1435 so that it's not optimized away.
1436 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1437 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1438 exported only to the debugger.
1439
e192d7d3 1440 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1441 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1442
92470028
PE
1443 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1444 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1445 was inaccessible from Lisp.
1446 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1447 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1448
244ed907
PE
1449 alloc.c: Import and export fewer symbols, and remove unused items.
1450 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1451 is defined.
1452 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1453 it's not optimized away by whole-program optimization.
1454 (message_enable_multibyte, free_misc): Remove.
1455 (catchlist, handlerlist, mark_backtrace):
1456 Declare only if BYTE_MARK_STACK.
1457 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1458 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1459 (message_enable_multibyte): Remove decl.
1460 (free_misc, interval_free_list, float_block, float_block_index):
1461 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1462 (cons_free_list, last_marked_index):
1463 Now static.
1464 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1465 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1466 (mark_backtrace): Define only if BYTE_MARK_STACK.
1467 * xdisp.c (message_enable_multibyte): Now static.
1468
61c2b50e 1469 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1470 This makes it easier for human readers (and static analyzers)
1471 to see whether these variables are used from other modules.
1472 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1473 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1474 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1475 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1476 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1477 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1478 * xmenu.c, xselect.c:
1479 Declare Q* vars static if they are not used in other modules.
1480 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1481 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1482 Remove decls of unexported vars.
1483 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1484
95c82688
PE
1485 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1486
16a97296
PE
1487 Make Emacs functions such as Fatom 'static' by default.
1488 This makes it easier for human readers (and static analyzers)
1489 to see whether these functions can be called from other modules.
1490 DEFUN now defines a static function. To make the function external
1491 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1492 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1493 (Finit_image_library):
16a97296
PE
1494 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1495 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1496 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1497 Remove decls, since these functions are now static.
1498 (Funintern, Fget_internal_run_time): New decls, since these functions
1499 were already external.
95c82688 1500
16a97296
PE
1501 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1502 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1503 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1504 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1505 * keyboard.c, keymap.c, lread.c:
1506 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1507 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1508 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1509 Mark functions with DEFUE instead of DEFUN,
1510 if they are used in other modules.
1511 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1512 decls for now-static functions.
1513 * buffer.h (Fdelete_overlay): Remove decl.
1514 * callproc.c (Fgetenv_internal): Mark as internal.
1515 * composite.c (Fremove_list_of_text_properties): Remove decl.
1516 (Fcomposition_get_gstring): New forward static decl.
1517 * composite.h (Fcomposite_get_gstring): Remove decl.
1518 * dired.c (Ffile_attributes): New forward static decl.
1519 * doc.c (Fdocumntation_property): New forward static decl.
1520 * eval.c (Ffetch_bytecode): New forward static decl.
1521 (Funintern): Remove extern decl; now in .h file where it belongs.
1522 * fileio.c (Fmake_symbolic_link): New forward static decl.
1523 * image.c (Finit_image_library): New forward static decl.
1524 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1525 * intervals.h (Fprevious_property_change):
1526 (Fremove_list_of_text_properties): Remove decls.
1527 * keyboard.c (Fthis_command_keys): Remove decl.
1528 (Fcommand_execute): New forward static decl.
1529 * keymap.c (Flookup_key): New forward static decl.
1530 (Fcopy_keymap): Now static.
1531 * keymap.h (Flookup_key): Remove decl.
1532 * process.c (Fget_process): New forward static decl.
1533 (Fprocess_datagram_address): Mark as internal.
1534 * syntax.c (Fsyntax_table_p): New forward static decl.
1535 (skip_chars): Remove duplicate decl.
1536 * textprop.c (Fprevious_property_change): New forward static decl.
1537 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1538 Now internal.
1539 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1540 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1541
785bbd42
PE
1542 * editfns.c (Fformat): Remove unreachable code.
1543
8b913b57
AS
15442011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1545
1546 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1547 change. (Bug#8496)
1548
a6744a35
EZ
15492011-04-13 Eli Zaretskii <eliz@gnu.org>
1550
1551 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1552 when at ZV. (Bug#8487)
1553
e7974947
AS
15542011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1555
baad03f0
AS
1556 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1557 (Bug#8437)
1558 * keyboard.c (parse_tool_bar_item): Likewise.
1559 * sound.c (sound_cleanup, alsa_close): Likewise.
1560 * termcap.c (tgetent): Likewise.
1561 * xfns.c (x_default_font_parameter): Likewise.
1562 * xsettings.c (read_and_apply_settings): Likewise.
1563
e7974947
AS
1564 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1565 (overrun_check_free): Protoize.
1566
28272684
PE
15672011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1570 since callers should never pass a negative size.
1571 Change the signature to match that of plain 'read' and 'write'; see
1572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1573 * lisp.h: Update prototypes of emacs_write and emacs_read.
1574
11997c76
EZ
15752011-04-11 Eli Zaretskii <eliz@gnu.org>
1576
1577 * xdisp.c (redisplay_window): Don't try to determine the character
1578 position of the scroll margin if the window start point w->startp
e896f03c 1579 is outside the buffer's accessible region. (Bug#8468)
11997c76 1580
8a2cbd72
EZ
15812011-04-10 Eli Zaretskii <eliz@gnu.org>
1582
1583 Fix write-region and its subroutines for buffers > 2GB.
1584 * fileio.c (a_write, e_write): Modify declaration of arguments and
1585 local variables to support buffers larger than 2GB.
1586 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1587
1588 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1589 argument, local variables, and return value.
1590
1591 * lisp.h: Update prototypes of emacs_write and emacs_read.
1592
1593 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1594
4073e537 15952011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1596
1ebfdcb6
PE
1597 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1598
b2ded58d
PE
1599 Fix more problems found by GCC 4.6.0's static checks.
1600
7d66342c
PE
1601 * xdisp.c (vmessage): Use a better test for character truncation.
1602
bbf47d44
PE
1603 * charset.c (load_charset_map): <, not <=, for optimization,
1604 and to avoid potential problems with integer overflow.
9248994d 1605 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1606 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1607 * editfns.c (Fformat): Likewise.
1e69125e 1608 * syntax.c (skip_chars): Likewise.
3befa583 1609
e3019616
PE
1610 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1611 This also lets GCC 4.6.0 generate slightly better loop code.
1612
becfa255
PE
1613 * callint.c (Fcall_interactively): <, not <=, for optimization.
1614 (Fcall_interactively): Count the number of arguments produced,
1615 not the number of arguments given. This is simpler and lets GCC
1616 4.6.0 generate slightly better code.
1617
dae0cd48
PE
1618 * ftfont.c: Distingish more carefully between FcChar8 and char.
1619 The previous code passed unsigned char * to a functions like
1620 strlen and xstrcasecmp that expect char *, which does not
1621 conform to the C standard.
1622 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1623 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1624 char * when the C standard requires it.
1625
76032d70
PE
1626 * keyboard.c (read_char): Remove unused var.
1627
eb3f1cc8
PE
1628 * eval.c: Port to Windows vsnprintf (Bug#8435).
1629 Include <limits.h>.
1630 (SIZE_MAX): Define if the headers do not.
1631 (verror): Do not give up if vsnprintf returns a negative count.
1632 Instead, grow the buffer. This ports to Windows vsnprintf, which
1633 does not conform to C99. Problem reported by Eli Zaretskii.
1634 Also, simplify the allocation scheme, by avoiding the need for
1635 calling realloc, and removing the ALLOCATED variable.
1636
70476b54
PE
1637 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1638
12020a9e
PE
1639 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1640 But keep the doprint source code for now, as we might revamp it
1641 and use it again (Bug#8435).
ea6c7ae6
PE
1642 * lisp.h (doprnt): Remove.
1643 * Makefile.in (base_obj): Remove doprnt.o.
1644 * deps.mk (doprnt.o): Remove.
1645
5fdb398c
PE
1646 error: Print 32- and 64-bit integers portably (Bug#8435).
1647 Without this change, on typical 64-bit hosts error ("...%d...", N)
1648 was used to print both 32- and 64-bit integers N, which relied on
1649 undefined behavior.
1650 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1651 New macro.
1652 * lisp.h (error, verror): Mark as printf-like functions.
1653 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1654 Report overflow in size calculations when allocating printf buffer.
1655 Do not truncate output string at its first null byte.
1656 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1657 Truncate the output at a character boundary, since vsnprintf does not
1658 do that.
1659 * charset.c (check_iso_charset_parameter): Convert internal
1660 character to string before calling 'error', since %c now has the
1661 printf meaning.
1662 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1663 overflow when computing char to be passed to 'error'. Do not
1664 pass Lisp_Object to 'error'; pass the integer instead.
1665 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1666 formatted with plain %d.
1667
b189fa66
PE
1668 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1669
bff87ef0
PE
1670 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1671
7e2cac20
PE
1672 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1673
ce4d90b5
PE
1674 * xterm.c (x_catch_errors): Remove duplicate declaration.
1675
266c9547
PE
1676 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1677
79c49ad2
PE
1678 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1679
368f4090
JM
16802011-04-10 Jim Meyering <meyering@redhat.com>
1681
1682 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1683 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1684 return ssize_t not "int", and use size_t as the buffer length.
1685 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1686 * gnutls.h: Update declarations.
1687 * process.c (read_process_output): Use ssize_t, to match.
1688 (send_process): Likewise.
1689
a32d4040
CY
16902011-04-09 Chong Yidong <cyd@stupidchicken.com>
1691
1692 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1693
8546720e 16942011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1695
04f2d78b
CB
1696 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1697 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1698
8546720e
GM
1699 * xterm.c (handle_one_xevent):
1700 * xmenu.c (create_and_show_popup_menu):
1701 * xselect.c (x_decline_selection_request)
1702 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1703
0a2f5c1a 17042011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1705
1706 Fix some uses of `int' instead of EMACS_INT.
1707 * search.c (string_match_1, fast_string_match)
1708 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1709 (scan_buffer, find_next_newline_no_quit)
1710 (find_before_next_newline, search_command, Freplace_match)
1711 (Fmatch_data): Make some `int' variables be EMACS_INT.
1712
1713 * xdisp.c (display_count_lines): 3rd argument and return value now
1714 EMACS_INT. All callers changed.
1715 (pint2hrstr): Last argument is now EMACS_INT.
1716
1717 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1718 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1719 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1720 (decode_coding_utf_16, decode_coding_emacs_mule)
1721 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1722 (decode_coding_ccl, decode_coding_charset)
1723 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1724 (decode_coding_iso_2022, decode_coding_emacs_mule)
1725 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1726 <char_offset, last_offset>: Declare EMACS_INT.
1727 (encode_coding_utf_8, encode_coding_utf_16)
1728 (encode_coding_emacs_mule, encode_invocation_designation)
1729 (encode_designation_at_bol, encode_coding_iso_2022)
1730 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1731 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1732 Declare EMACS_INT.
1733 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1734 (encode_invocation_designation): Last argument P_NCHARS is now
1735 EMACS_INT.
1736 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1737 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1738
1739 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1740 All users changed.
1741
1742 * ccl.c (Fccl_execute_on_string): Declare some variables
1743 EMACS_INT.
1744
8546720e 17452011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1746
1747 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1748
4e19a977
CS
17492011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1750
1751 * process.c (Fformat_network_address): Doc fix.
1752
87302331
R
17532011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1754
1755 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1756
cbb59342
CY
17572011-04-08 Chong Yidong <cyd@stupidchicken.com>
1758
1759 * keyboard.c (read_char): Call Lisp function help-form-show,
1760 instead of using internal_with_output_to_temp_buffer.
1761 (Qhelp_form_show): New var.
e0d38eeb 1762 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1763
1764 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1765
1766 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1767
e67a13ab
CY
17682011-04-06 Chong Yidong <cyd@stupidchicken.com>
1769
04f2d78b
CB
1770 * process.c (Flist_processes): Remove to Lisp.
1771 (list_processes_1): Delete.
e67a13ab 1772
973f782d
EZ
17732011-04-06 Eli Zaretskii <eliz@gnu.org>
1774
7c106b1e
EZ
1775 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1776
973f782d
EZ
1777 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1778
41cf7d1a 17792011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1780
ca23cc88
PE
1781 Fix more problems found by GCC 4.6.0's static checks.
1782
f390e2d5
PE
1783 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1784
42eea0d0
PE
1785 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1786
b69769da 1787 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1788
f9541e84
PE
1789 * xdisp.c (vmessage): Mark as a printf-like function.
1790
13841b55
PE
1791 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1792
c136c10f
PE
1793 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1794
5e2d4a30
PE
1795 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1796 printf-like functions.
1797 (tiff_load): Add casts to remove these marks before passing them
1798 to system-supplied API.
1799
583f48b9
PE
1800 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1801
b25d760e
PE
1802 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1803 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1804 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1805 directly, rather than having caller test rule sign. This avoids
1806 some unnecessary tests.
1807 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1808 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1809 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1810
bc7b6697 1811 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1812 (xfont_open): Avoid unnecessary tests.
bc7b6697 1813
27ccc379
PE
1814 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1815
dcd5c89a
PE
1816 * composite.h, composite.c (composition_gstring_put_cache):
1817 Use EMACS_INT, not int, for length.
1818
b13a45c6
PE
1819 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1820 breaking out part of COMPOSITION_DECODE_RULE.
1821 (COMPOSITION_DECODE_RULE): Use it.
1822 * composite.c (get_composition_id): Remove unused local vars,
1823 by using the new macro.
1824
1e792e4d
PE
1825 * textprop.c (set_text_properties_1): Change while to do-while,
1826 since the condition is always true at first.
1827
dc6c6455 1828 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1829 (interval_deletion_adjustment): Return unsigned value.
1830 All uses changed.
dc6c6455 1831
aba7731a
PE
1832 * process.c (list_processes_1, create_pty, read_process_output):
1833 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1834 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1835 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1836 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1837 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1838
fdfc4bf3
PE
1839 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1840
fca8fe46 1841 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1842 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1843
06a0259a 1844 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1845 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1846 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1847
e7b9e80f
PE
1848 * print.c (print_error_message): Avoid int overflow.
1849
56201685
PE
1850 * font.c (font_list_entities): Redo for clarity,
1851 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1852
78834453 1853 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1854 (font_score): Avoid potential overflow in diff calculation.
78834453 1855
0bc0b309 1856 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1857 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1858
e610eaca
PE
1859 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1860
b895abce
PE
1861 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1862 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1863 can always succeed if overflow has undefined behavior.
1864
1f1d9321 1865 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1866 (wordify): Omit three unnecessary tests.
1f1d9321 1867
c59478bc
PE
1868 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1869 All callers changed. This avoids the need for an unused var.
1870
79b73827
PE
1871 * casefiddle.c (casify_region): Remove var that is set but not used.
1872
a4db5dfe
PE
1873 * dired.c (file_name_completion): Remove var that is set but not used.
1874
43aae36e
PE
1875 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1876
2a47c44d 1877 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1878 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1879
a37c69bf
PE
1880 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1881 Check for integer overflow on size calculations.
1882
328ab8e7
PE
1883 * buffer.c (Fprevious_overlay_change): Remove var that is set
1884 but not used.
1885
e5a2a5cb
PE
1886 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1887 Remove vars that are set but not used.
8d84a6eb 1888 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1889 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1890
a60e5f68
PE
1891 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1892
f661cb61 1893 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1894 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1895
f0397f5a
PE
1896 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1897 that are set but not used.
1898
8664db06 1899 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1900 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1901
6abdaa4a
PE
1902 * xselect.c (x_get_local_selection, x_handle_property_notify):
1903 Remove vars that are set but not used.
1904
0ce7538d 1905 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1906 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1907
9ae848fc
PE
1908 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1909 Remove var that is set but not used.
0b918413
PE
1910 (scroll_bar_windows_size): Now size_t, not int.
1911 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1912 Check for overflow.
9ae848fc 1913
a5a62657
PE
1914 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1915 (map_tty_color) [!defined MSDOS]: Likewise.
1916
5c5cdd39
PE
1917 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1918
66ebf983
PE
1919 * coding.c: Remove vars that are set but not used.
1920 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1921 All callers changed.
1922 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1923 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1924 (decode_coding_charset): Remove vars that are set but not used.
1925
1be4d761
PE
1926 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1927 that is set but not used.
1928
47553fa8
PE
1929 * print.c (print_object): Remove var that is set but not used.
1930
1f7196bf 1931 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1932 The gnulib version avoids calling malloc in the usual case,
1933 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1934 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1935 * filelock.c (current_lock_owner): Likewise.
1936 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1937 * sysdep.c: Include allocator.h, careadlinkat.h.
1938 (emacs_no_realloc_allocator): New static constant.
1939 (emacs_readlink): New function.
fdb61804
PE
1940 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1941 ../lib/careadlinkat.h.
d1fdcab7 1942
f84c17c7
SM
19432011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1944
1945 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1946 first non-nil return value).
1947
ef3862ad
JD
19482011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1949
1950 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1951 if not defined (Bug#8403).
1952
376a7006
JB
19532011-04-02 Juanma Barranquero <lekktu@gmail.com>
1954
1955 * xdisp.c (display_count_lines): Remove parameter `start',
1956 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1957 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1958 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1959 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1960 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1961 and thereabouts. All callers changed.
1962 (get_per_char_metric): Remove parameter `f', unused since
1963 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1964
6ca3801d
JM
19652011-04-02 Jim Meyering <meyering@redhat.com>
1966
1967 do not dereference NULL upon failed strdup
1968 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1969 (ns_get_family): Likewise.
1970
d8e2b5ba
JB
19712011-04-02 Juanma Barranquero <lekktu@gmail.com>
1972
1973 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1974
8c74fcbd
JD
19752011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1976
1977 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1978 later (Bug#8403).
1979
7200d79c
SM
19802011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1981
03408648 1982 Add lexical binding.
7200d79c 1983
03408648
SM
1984 * window.c (Ftemp_output_buffer_show): New fun.
1985 (Fsave_window_excursion):
1986 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1987
1988 * lread.c (lisp_file_lexically_bound_p): New function.
1989 (Fload): Bind Qlexical_binding.
1990 (readevalloop): Remove `evalfun' arg.
1991 Bind Qinternal_interpreter_environment.
1992 (Feval_buffer): Bind Qlexical_binding.
1993 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1994 Mark as dynamic.
1995 (syms_of_lread): Declare `lexical-binding'.
1996
1997 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1998
1999 * keyboard.c (eval_dyn): New fun.
2000 (menu_item_eval_property): Use it.
ca105506
SM
2001
2002 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2003
03408648
SM
2004 * fns.c (concat, mapcar1): Accept byte-code-functions.
2005
2006 * eval.c (Fsetq): Handle lexical vars.
2007 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2008 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2009 (FletX, Flet): Obey lexical binding.
2010 (Fcommandp): Handle closures.
2011 (Feval): New `lexical' arg.
2012 (eval_sub): New function extracted from Feval. Use it almost
2013 everywhere where Feval was used. Look up vars in lexical env.
2014 Handle closures.
2015 (Ffunctionp): Move from subr.el.
2016 (Ffuncall): Handle closures.
2017 (apply_lambda): Remove `eval_flags'.
2018 (funcall_lambda): Handle closures and new byte-code-functions.
2019 (Fspecial_variable_p): New function.
2020 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2021 but without exporting it to Lisp.
23aba0ea 2022
23aba0ea 2023 * doc.c (Fdocumentation, store_function_docstring):
03408648 2024 * data.c (Finteractive_form): Handle closures.
23aba0ea 2025
03408648
SM
2026 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2027 interactive spec.
ba83908c 2028
04f2d78b
CB
2029 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2030 New byte-codes.
03408648
SM
2031 (exec_byte_code): New function extracted from Fbyte_code to handle new
2032 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2033
03408648 2034 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2035
03408648 2036 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2037
e2abce01
JB
20382011-03-31 Juanma Barranquero <lekktu@gmail.com>
2039
2040 * xdisp.c (redisplay_internal): Fix prototype.
2041
63696a73 20422011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2043
63696a73 2044 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2045 (try_scrolling): Use it when setting scroll_limit.
2046 Limit scrolling to 100 screen lines.
63696a73
EZ
2047 (redisplay_window): Even when falling back on "recentering",
2048 position point in the window according to scroll-conservatively,
2049 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2050
2051 (try_scrolling): When point is above the window, allow searching
2052 as far as scroll_max, or one screenful, to compute vertical
2053 distance from PT to the scroll margin position. This prevents
2054 try_scrolling from unnecessarily failing when
2055 scroll-conservatively is set to a value slightly larger than the
2056 window height. Clean up the case of PT below the margin at bottom
2057 of window: scroll_max can no longer be INT_MAX. When aggressive
2058 scrolling is in use, don't let point enter the opposite scroll
2059 margin as result of the scroll.
2060 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2061 threshold of 100 lines for never-recentering scrolling.
2062
e4cc2dfc
JB
20632011-03-31 Juanma Barranquero <lekktu@gmail.com>
2064
2065 * dispextern.h (move_it_by_lines):
2066 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2067 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2068 (message_log_check_duplicate): Remove parameters `prev_bol' and
2069 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2070 (redisplay_internal): Remove parameter `preserve_echo_area',
2071 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2072
2073 * indent.c (Fvertical_motion):
2074 * window.c (window_scroll_pixel_based, Frecenter):
2075 Don't pass `need_y_p' to `move_it_by_lines'.
2076
1c470562
SM
20772011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2078
44f230aa
SM
2079 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2080 steal a few bits to be more compact.
2081 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2082 Remove unneeded casts.
2083
1c470562
SM
2084 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2085
888adce9
ZK
20862011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2087
2088 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2089 binding" message (bug#7967).
2090
f838ed7b
PE
20912011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2092
77861b95
PE
2093 Fix more problems found by GCC 4.6.0's static checks.
2094
de6dbc14
PE
2095 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2096 Remove unused local var.
2097
f838ed7b
PE
2098 * editfns.c (Fmessage_box): Remove unused local var.
2099
792c7b2b
PE
2100 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2101 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2102 Omit unused local vars.
c499e557 2103 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2104 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2105 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2106 Omit unused local var.
2107
ba0165e1
PE
2108 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2109 Don't assume string length fits in int.
32ad8845 2110 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2111 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2112
3c59b4c9
PE
2113 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2114 instead of alloca (Bug#8344).
2115
a3eed478 2116 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2117 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2118
eb4d412d
PE
2119 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2120
1658b401
PE
2121 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2122 concerns.
2123
2124 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2125
2126 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2127
9a2c6e05
PE
2128 * keyboard.c (syms_of_keyboard): Use the same style as later
2129 in this function when indexing through an array. This also
2130 works around GCC bug 48267.
2131
03d0a109
PE
2132 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2133
44f730c8
PE
2134 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2135
fe75f926
PE
2136 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2137 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2138
ffa8c828
PE
2139 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2140 This avoids undefined behavior on integer overflow, and is a bit
2141 more convenient anyway since it is compared to a size_t variable.
2142
c5101a77
PE
2143 Variadic C functions now count arguments with size_t, not int.
2144 This avoids an unnecessary limitation on 64-bit machines, which
2145 caused (substring ...) to crash on large vectors (Bug#8344).
2146 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2147 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2148 All variadic functions and their callers changed accordingly.
c5101a77
PE
2149 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2150 * data.c (arith_driver, float_arith_driver): Likewise.
2151 * editfns.c (general_insert_function): Likewise.
2152 * eval.c (struct backtrace.nargs, interactive_p)
2153 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2154 (funcall_lambda, mark_backtrace): Likewise.
2155 * fns.c (concat): Likewise.
2156 * frame.c (x_set_frame_parameters): Likewise.
2157 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2158 0 if not found, not -1. All callers changed.
2159
dd3f25f7
PE
2160 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2161 (stack_copy_size): Now size_t, not int.
2162 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2163
461c2ab9
JB
21642011-03-28 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2167 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2168 All callers changed.
2169
2170 * lisp.h (multibyte_char_to_unibyte):
2171 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2172 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2173 * character.h (CHAR_TO_BYTE8):
2174 * cmds.c (internal_self_insert):
2175 * editfns.c (general_insert_function):
2176 * keymap.c (push_key_description):
2177 * search.c (Freplace_match):
2178 * xdisp.c (message_dolog, set_message_1): All callers changed.
2179
f6d62986
SM
21802011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2181
2182 * keyboard.c (safe_run_hook_funcall): New function.
2183 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2184 don't set the hook to nil, but remove the offending function instead.
2185 (Qcommand_hook_internal): Remove, unused.
2186 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2187 Vcommand_hook_internal.
2188
2189 * eval.c (enum run_hooks_condition): Remove.
2190 (funcall_nil, funcall_not): New functions.
2191 (run_hook_with_args): Call each function through a `funcall' argument.
2192 Remove `cond' argument, now redundant.
2193 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2194 (Frun_hook_with_args_until_failure): Adjust accordingly.
2195 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2196
1db5b1ad
JB
21972011-03-28 Juanma Barranquero <lekktu@gmail.com>
2198
2199 * dispextern.h (string_buffer_position): Remove declaration.
2200
2201 * print.c (strout): Remove parameter `multibyte', unused since
2202 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2203
2204 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2205 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2206 All callers changed.
2207
2208 * w32.c (_wsa_errlist): Use braces for struct initializers.
2209
2210 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2211 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2212 All callers changed.
2213 (string_buffer_position): Likewise. Also, make static (it's never
2214 used outside xdisp.c).
2215 (cursor_row_p): Remove parameter `w', unused since
2216 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2217 (decode_mode_spec): Remove parameter `precision', introduced during
2218 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2219 All callers changed.
2220
5ffb62aa
JD
22212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2222
2223 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2224
461c2ab9 22252011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2226
2227 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2228 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2229 (ns_update_auto_hide_menu_bar): New functions.
2230 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2231 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2232 ns_constrain_all_frames.
2233 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2234 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2235
5c380ffb
JD
22362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2237
2238 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2239
9af30bdf
GM
22402011-03-27 Glenn Morris <rgm@gnu.org>
2241
2242 * syssignal.h: Replace RETSIGTYPE with void.
2243 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2244 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2245 Replace SIGTYPE with void everywhere.
2246 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2247 * s/template.h (SIGTYPE): Remove commented out definition.
2248
e2abce01
JB
22492011-03-26 Eli Zaretskii <eliz@gnu.org>
2250
2251 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2252 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2253
f868cd8a
JB
22542011-03-26 Juanma Barranquero <lekktu@gmail.com>
2255
59eb0929
JB
2256 * w32.c (read_unc_volume): Use parameter `henum', instead of
2257 global variable `wget_enum_handle'.
2258
2259 * keymap.c (describe_vector): Remove parameters `indices' and
2260 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2261 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2262
f868cd8a
JB
2263 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2264
2265 * keyboard.c (timer_check): Remove parameter `do_it_now',
2266 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2267 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2268 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2269
2270 * keyboard.c (read_char):
2271 * w32menu.c (w32_menu_display_help):
2272 * xmenu.c (show_help_event, menu_help_callback):
2273 Adjust calls to `show_help_echo'.
2274
2275 * gtkutil.c (xg_maybe_add_timer):
2276 * keyboard.c (readable_events):
2277 * process.c (wait_reading_process_output):
2278 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2279
2280 * insdel.c (adjust_markers_gap_motion):
2281 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2282 (gap_left, gap_right): Don't call it.
2283
2ecf6fdb
CY
22842011-03-25 Chong Yidong <cyd@stupidchicken.com>
2285
2286 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2287 incurred during fontification.
2288
6b1f9ba4
JB
22892011-03-25 Juanma Barranquero <lekktu@gmail.com>
2290
2291 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2292 (DEFVAR_PER_BUFFER): Don't pass it.
2293
2294 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2295 (scrolling_window): Don't pass it.
2296
0f4a96b5
JB
22972011-03-25 Juanma Barranquero <lekktu@gmail.com>
2298
2299 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2300
2301 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2302 and `suffix'.
2303 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2304 of variables specific to SELinux and computation of `encoded_absname'.
2305
2306 * image.c (XPutPixel): Remove unused variable `height'.
2307
2308 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2309
2310 * unexw32.c (get_section_info): Remove unused variable `section'.
2311
2312 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2313 (system_process_attributes): Remove unused variable `sess'.
2314 (sys_read): Remove unused variable `err'.
2315
2316 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2317 (w32_wnd_proc): Remove unused variable `isdead'.
2318 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2319 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2320 (x_create_tip_frame): Remove unused variable `tem'.
2321
2322 * w32inevt.c (w32_console_read_socket):
2323 Remove unused variable `no_events'.
2324
2325 * w32term.c (x_draw_composite_glyph_string_foreground):
2326 Remove unused variable `width'.
2327
1149507c
JB
23282011-03-24 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * w32term.c (x_set_glyph_string_clipping):
2331 Don't pass uninitialized region to CombineRgn.
2332
9c88f339
JB
23332011-03-23 Juanma Barranquero <lekktu@gmail.com>
2334
2335 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2336 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2337 (Fx_close_connection): Remove unused variable `i'.
2338
2339 * w32font.c (w32font_draw): Return number of glyphs.
2340 (w32font_open_internal): Remove unused variable `i'.
2341 (w32font_driver): Add missing initializer.
2342
2343 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2344 (fill_in_menu): Remove unused variable `items_added'.
2345
2346 * w32term.c (last_mouse_press_frame): Remove static global variable.
2347 (w32_clip_to_row): Remove unused variable `f'.
2348 (x_delete_terminal): Remove unused variable `i'.
2349
2350 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2351 (NOTHING): Remove unused static global variable.
2352 (uniscribe_check_otf): Remove unused variable `table'.
2353 (uniscribe_font_driver): Add missing initializers.
2354
dee091a3
JD
23552011-03-23 Julien Danjou <julien@danjou.info>
2356
2357 * term.c (Fsuspend_tty, Fresume_tty):
2358 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2359 * window.c (temp_output_buffer_show):
2360 * insdel.c (signal_before_change):
2361 * frame.c (Fhandle_switch_frame):
2362 * fileio.c (Fdo_auto_save):
2363 * emacs.c (Fkill_emacs):
2364 * editfns.c (save_excursion_restore):
2365 * cmds.c (internal_self_insert):
2366 * callint.c (Fcall_interactively):
2367 * buffer.c (Fkill_all_local_variables):
2368 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2369 Use Frun_hooks.
0f4a96b5 2370 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2371 unconditionnaly since it does the check itself.
2372
2c520ab5 23732011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2374
c9c49752
PE
2375 Fix more problems found by GCC 4.5.2's static checks.
2376
8abc3f12
PE
2377 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2378 the first time through the loop, since we know p0 < p1 then.
2379 This also avoids a gcc -Wstrict-overflow warning.
2380
a2d26660
PE
2381 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2382 leading to a memory leak, possible in functions like
2383 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2384 of objects (Bug#8318).
a2d26660 2385
916c72e9
PE
2386 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2387 that could (at least in theory) be that large.
2388
19ab8a18
PE
2389 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2390 This is less likely to overflow, and avoids undefined behavior if
2391 overflow does occur. All callers changed. Use strtoul to scan
2392 for the unsigned long integer.
b7cbbd6f
PE
2393 (pint2hrstr): Simplify and tune code slightly.
2394 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2395
f0641eff
PE
2396 * scroll.c (do_scrolling): Work around GCC bug 48228.
2397 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2398
7f650bb9
PE
2399 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2400 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2401 (validate_x_resource_name): Simplify count usage.
2402 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2403
37dd57d1
PE
2404 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2405 fail (Bug#8306).
81e56e61 2406
699979fc 2407 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2408
401bf9b4
PE
2409 * process.c (Fmake_network_process): Use socklen_t, not int,
2410 where POSIX says socklen_t is required in portable programs.
2411 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2412 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2413 (Fmake_network_process, server_accept_connection):
2414 (wait_reading_process_output, read_process_output):
2415 Likewise.
2416
b93aacde
PE
2417 * process.c: Rename or move locals to avoid shadowing.
2418 (list_processes_1, Fmake_network_process):
2419 (read_process_output_error_handler, exec_sentinel_error_handler):
2420 Rename or move locals.
4dc343ee 2421 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2422 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2423 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2424 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2425 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2426
af8a867c 2427 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2428 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2429 Include tparam.h instead, since it declares them.
af8a867c
PE
2430 * cm.h (PC): Remove extern decl; tparam.h now does this.
2431 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2432 * terminfo.c: Include tparam.h, to check interfaces.
2433 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2434 (tparam): Adjust signature to match interface in tparam.h;
2435 this removes some undefined behavior. Check that outstring and len
2436 are zero, which they always are with Emacs.
2437 * tparam.h (PC, BC, UP): New extern decls.
2438
0248044d 2439 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2440 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2441
8ff096c1 2442 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2443 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2444 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2445 (ftfont_list): Remove unused local.
49eaafba
PE
2446 (get_adstyle_property, ftfont_pattern_entity):
2447 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2448 Rename locals to avoid shadowing.
8ff096c1 2449
e2be39f6
PE
2450 * xfont.c (xfont_list_family): Mark var as initialized.
2451
c9735e30
PE
2452 * xml.c (make_dom): Now static.
2453
8f5201ae
PE
2454 * composite.c (composition_compute_stop_pos): Rename local to
2455 avoid shadowing.
b246f932
PE
2456 (composition_reseat_it): Remove unused locals.
2457 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2458 (composition_update_it): Mark var as initialized.
11b61122
PE
2459 (find_automatic_composition): Mark vars as initialized,
2460 with a FIXME (Bug#8290).
8f5201ae 2461
760fbc2c
PE
2462 character.h: Rename locals to avoid shadowing.
2463 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2464 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2465 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2466 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2467 to avoid shadowing.
2468
ff08eb85
PE
2469 * textprop.c (property_change_between_p): Remove; unused.
2470
fc7bf025
PE
2471 * intervals.c (interval_start_pos): Now static.
2472
235d7abc
PE
2473 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2474
44f230aa
SM
2475 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2476 Rename locals to avoid shadowing.
3e7d6594 2477
50060332
PE
2478 * sound.c (wav_play, au_play, Fplay_sound_internal):
2479 Fix pointer signedness.
d01f234b 2480 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2481 (wav_play): Initialize a variable to 0, to prevent undefined
2482 behavior (Bug#8278).
50060332 2483
c4fc4e30
PE
2484 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2485
918436ed
PE
2486 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2487
c939f91b
PE
2488 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2489 clobbering (Bug#8298).
b9c7f648
PE
2490 * sysdep.c (sys_subshell): Likewise.
2491 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2492
6bd8c144
PE
2493 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2494 This should get cleaned up, so that child_setup has the
2495 same signature on all platforms.
2496
7710357c 2497 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2498 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2499
c59da222
CY
25002011-03-22 Chong Yidong <cyd@stupidchicken.com>
2501
2502 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2503 not to be necessary, and produces flickering.
2504
66b87493
GM
25052011-03-20 Glenn Morris <rgm@gnu.org>
2506
2507 * config.in: Remove file.
2508
45b6f6d5
JB
25092011-03-20 Juanma Barranquero <lekktu@gmail.com>
2510
2511 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2512 are now in src/globals.h.
2513 (syms_of_minibuf): Remove spurious & from previous change.
2514
3ec03f7e
LL
25152011-03-20 Leo <sdl.web@gmail.com>
2516
2517 * minibuf.c (completing-read-function): New variable.
2518 (completing-read-default): Rename from completing-read.
2519 (completing-read): Call completing-read-function.
2520
b14e3e21
CY
25212011-03-19 Juanma Barranquero <lekktu@gmail.com>
2522
2523 * xfaces.c (Fx_load_color_file):
2524 Read color file from absolute filename (bug#8250).
2525
f2b726e6
JB
25262011-03-19 Juanma Barranquero <lekktu@gmail.com>
2527
2528 * makefile.w32-in: Update dependencies.
2529
09f6ff02
EZ
25302011-03-17 Eli Zaretskii <eliz@gnu.org>
2531
2532 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2533
29a6015a
PE
25342011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2535
a3a6c54e
PE
2536 Fix more problems found by GCC 4.5.2's static checks.
2537
b766f867
PE
2538 * process.c (make_serial_process_unwind, send_process_trap):
2539 (sigchld_handler): Now static.
2540
be02381c
PE
2541 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2542 That way, the code declares only the vars that it needs.
2543 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2544 * s/cygwin.h (PTY_ITERATION): Likewise.
2545 * s/darwin.h (PTY_ITERATION): Likewise.
2546 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2547
57048744
PE
2548 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2549 * process.c (allocate_pty): Don't declare stb unless it's needed.
2550
7914961c 2551 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2552 (CONSTANTLIM): Remove; unused.
2553 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2554 Define only if needed.
7914961c 2555
b3967b18
PE
2556 * unexelf.c (unexec): Name an expression,
2557 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2558 Use a different way to cause a compilation error if anyone uses
2559 n rather than nn, a way that does not involve shadowing.
73366a00 2560 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2561
29a6015a
PE
2562 * deps.mk (unexalpha.o): Remove; unused.
2563
43cfc33e 2564 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2565 * unexec.h: New file.
ce701a33
PE
2566 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2567 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2568 Depend on unexec.h.
2569 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2570 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2571 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2572 Change as necessary to match prototype in unexec.h.
ce701a33 2573
01f44d5a
PE
2574 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2575 shadowing.
4f63c6bb 2576 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2577
a6670b0b
PE
2578 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2579 Rename locals to avoid shadowing.
2580
cef2010d 2581 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2582 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2583
d4d7173a
PE
2584 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2585
f08b802a
PE
2586 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2587 warning when compiling print.c.
2588
3ddb0639
PE
2589 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2590 instead of using an uninitialized var.
5ad03b97 2591 (font_sort_entities): Mark var as initialized.
3ddb0639 2592
170a2692
PE
2593 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2594
e663c700
PE
2595 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2596 pointers to constants.
89bc529a 2597 (font_parse_fcname): Remove unused vars.
7b81e2d0 2598 (font_delete_unmatched): Now static.
ea838e10 2599 (font_get_spec): Remove; unused.
13a547c6
PE
2600 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2601 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2602 Rename or move locals to avoid shadowing.
e663c700 2603
2a80c887 2604 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2605 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2606
1384fa33 2607 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2608 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2609
8b2c52e9
PE
2610 * alloc.c (mark_backtrace): Move decl from here ...
2611 * lisp.h: ... to here, so that it can be checked.
2612
475545b5 2613 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2614 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2615 (lisp_indirect_variable): Name an expression,
2616 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2617 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2618
b1349114 2619 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2620 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2621 Use const pointer when appropriate.
b1349114 2622
a2928364
PE
2623 * lisp.h (get_system_name, get_operating_system_release):
2624 Move decls here, to check interfaces.
2625 * process.c (get_operating_system_release): Move decl to lisp.h.
2626 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2627 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2628 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2629 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2630 (Fformat_time_string, Fencode_time, Finsert_char):
2631 (Ftranslate_region_internal, Fformat):
2632 Rename or remove local vars to avoid shadowing.
9710023e 2633 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2634
a415e694
PE
2635 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2636 avoid shadowing.
2637
8ef4622d
PE
2638 * lisp.h (eassert): Check that the argument compiles, even if
2639 ENABLE_CHECKING is not defined.
2640
946f9a5b
PE
2641 * data.c (Findirect_variable): Name an expression, to avoid
2642 gcc -Wbad-function-cast warning.
112396d6 2643 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2644 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2645 (Fmake_variable_buffer_local, Fmake_local_variable):
2646 Mark variables as initialized.
52746918 2647 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2648
e5aab7e7 2649 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2650 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2651 Rename locals to avoid shadowing.
dff45157
PE
2652 (mark_stack): Move local variables into the #ifdef region where
2653 they're used.
7bc26fdb
PE
2654 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2655 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2656 needed otherwise.
2657 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2658 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2659 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2660
e5aab7e7
PE
2661 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2662 avoids undefined behavior in theory.
2663
4da60324
PE
2664 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2665
88043301
PE
2666 Use functions, not macros, for up- and down-casing (Bug#8254).
2667 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2668 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2669 to use the following functions instead of these macros.
2670 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2671 EMACS_INT, since callers assume the returned value fits in int.
2672 (upcase1): Likewise, for UPCASE_TABLE.
2673 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2674 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2675 the race-condition problem in the old DOWNCASE.
88043301 2676
19ed5445
PE
2677 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2678 Rename locals to avoid shadowing.
2679 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2680 (regex_compile, re_search_2, re_match_2_internal):
2681 Remove unused local vars.
952db0d7
PE
2682 (FREE_VAR): Rewrite so as not to use empty "else",
2683 which gcc can warn about.
da053e48 2684 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2685 (RETALLOC_IF): Define only if needed.
2686 (WORDCHAR_P): Likewise. This one is never needed, but is used
2687 only in a comment talking about a compiler bug, so put inside
2688 the #if 0 of that comment.
2689 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2690 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2691 Remove; unused.
19ed5445 2692
1f3561e4 2693 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2694 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2695 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2696
ded6f8f7
PE
2697 * search.c (simple_search): Remove unused var.
2698
dbd37a95
PE
2699 * dired.c (compile_pattern): Move decl from here ...
2700 * lisp.h: ... to here, so that it can be checked.
2701 (struct re_registers): New forward decl.
2702
7e47afad
PE
2703 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2704
85f24f61
PE
2705 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2706 All uses changed.
2707 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2708 Rename locals to avoid shadowing.
5671df8f 2709 (Fvertical_motion): Mark locals as initialized.
85f24f61 2710
181aa2be 2711 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2712 (casify_region): Mark local as initialized.
181aa2be 2713
930d429c
PE
2714 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2715
7082eac6
PE
2716 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2717 New macros, so that the caller can use some names other than
2718 gcpro1, gcpro2, etc.
2719 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2720 of the new macros.
2721 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2722 argument, for consistency with GCPRO2_VAR, etc: it is now the
2723 prefix of the variable, not the variable itself. All uses
2724 changed.
38b2c076
PE
2725 * dired.c (directory_files_internal, file_name_completion):
2726 Rename locals to avoid shadowing.
2727
15206ed9
PE
2728 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2729 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2730 dired.c's scmp function, had undefined behavior.
2731 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2732 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2733 * buffer.h: ... to here, because these macros use current_buffer,
2734 and the new implementation with inline functions needs to have
2735 current_buffer in scope now, rather than later when the macros
2736 are used.
2737 (downcase, upcase1): New static inline functions.
2738 (DOWNCASE, UPCASE1): Reimplement using these functions.
2739 This avoids undefined behavior in expressions like
2740 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2741 from race conditions in accessing the global variables
2742 case_temp1 and case_temp2.
2743 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2744 * lisp.h (case_temp1, case_temp2): Remove their decls.
2745 * character.h (ASCII_CHAR_P): Move from here ...
2746 * lisp.h: ... to here, so that the inline functions mentioned
2747 above can use them.
2748
4a6bea26
PE
2749 * dired.c (directory_files_internal_unwind): Now static.
2750
f14b7e14
PE
2751 * fileio.c (file_name_as_directory, directory_file_name):
2752 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2753 Now static.
2893f146
PE
2754 (file_name_as_directory): Use const pointers when appropriate.
2755 (Fexpand_file_name): Likewise. In particular, newdir might
2756 point at constant storage, so make it a const pointer.
fd4ead52 2757 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2758 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2759 signedness issues.
f839df0c
PE
2760 (Fset_file_times, Finsert_file_contents, auto_save_error):
2761 Rename locals to avoid shadowing.
f14b7e14 2762
5716756e 2763 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2764 (Ftry_completion, Fall_completions): Rename or remove locals
2765 to avoid shadowing.
5716756e 2766
b4c3046a
PE
2767 * marker.c (bytepos_to_charpos): Remove; unused.
2768
b45db522
PE
2769 * lisp.h (verify_bytepos, count_markers): New decls,
2770 so that gcc does not warn that these functions aren't declared.
2771
85876d07
PE
2772 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2773 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2774 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2775 (copy_text): Remove unused local var.
85876d07 2776
03d78a21 2777 * filelock.c (within_one_second): Now static.
b3dd38ab 2778 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2779
5df8f01b
PE
2780 * buffer.c (fix_overlays_before): Mark locals as initialized.
2781 (fix_start_end_in_overlays): Likewise. This function should be
2782 simplified by using pointers-to-pointers, but that's a different
2783 matter.
b1d876f1 2784 (switch_to_buffer_1): Now static.
8f54f30a
PE
2785 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2786 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2787
a70072c9 2788 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2789 Fix pointer signedness issue.
edced198
PE
2790 (sys_subshell): Mark local as volatile if checking for lint,
2791 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2792 (MAXPATHLEN): Define only if needed.
a70072c9 2793
a0977c44
PE
2794 * process.c (serial_open, serial_configure): Move decls from here ...
2795 * systty.h: ... to here, so that they can be checked.
2796
a884fdcc
PE
2797 * fns.c (get_random, seed_random): Move extern decls from here ...
2798 * lisp.h: ... to here, so that they can be checked.
2799
604efe86 2800 * sysdep.c (reset_io): Now static.
b8950c94 2801 (wait_for_termination_signal): Remove; unused.
604efe86 2802
38fc62d9
PE
2803 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2804 (copy_keymap_item, append_key, push_text_char_description):
2805 Now static.
1004a21a 2806 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2807 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2808 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2809 (describe_map_tree):
2810 Rename locals to avoid shadowing.
38fc62d9 2811
2f2650da
PE
2812 * keyboard.c: Declare functions static if they are not used elsewhere.
2813 (echo_char, echo_dash, cmd_error, top_level_2):
2814 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2815 (read_char, kbd_buffer_get_event, make_lispy_position):
2816 (make_lispy_event, make_lispy_movement, apply_modifiers):
2817 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2818 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2819 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2820 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2821 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2822
a053e86c 2823 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2824 (mark_kboards): Move decl here ...
2825 * alloc.c (mark_kboards): ... from here.
a053e86c 2826
4752793e
PE
2827 * lisp.h (force_auto_save_soon): New decl.
2828
74f10ca7 2829 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2830 (DEFINE_DUMMY_FUNCTION): New macro.
2831 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2832 Use it.
c03cd23f
PE
2833 (main): Add casts to avoid warnings
2834 if GCC considers string literals to be constants.
74f10ca7 2835
022e70d4
PE
2836 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2837
59d6fe83
PE
2838 * dbusbind.c: Pointer signedness fixes.
2839 (xd_signature, xd_append_arg, xd_initialize):
2840 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2841 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2842 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2843 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2844
78320123
PE
2845 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2846 if GCC considers string literals to be constants.
49cebcca 2847 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2848
35ac2a97
SM
28492011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2850
fb103ca9
SM
2851 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2852 (print_preprocess, print_object): New macro to fix last change.
2853
35ac2a97
SM
2854 * print.c (print_preprocess): Don't forget font objects.
2855
62973b41
JB
28562011-03-16 Juanma Barranquero <lekktu@gmail.com>
2857
2858 * emacs.c (USAGE3): Doc fixes.
2859
0e48bb22
AS
28602011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2861
2862 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2863 structure.
2864
7684e57b
JB
28652011-03-14 Juanma Barranquero <lekktu@gmail.com>
2866
2867 * lisp.h (VWindow_system, Qfile_name_history):
2868 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2869 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2870 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2871
2872 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2873 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2874
2875 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2876 * w32console.c (detect_input_pending, read_input_pending)
2877 (encode_terminal_code):
2878 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2879 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2880 (w32_system_caret_y, Qfile_name_history):
2881 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2882 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2883 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2884 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2885 * w32proc.c (Qlocal, report_file_error):
2886 * w32term.c (Vwindow_system, updating_frame):
2887 * w32uniscribe.c (initialized, uniscribe_font_driver):
2888 Remove unneeded extern declarations.
2889
2aa46d6c
CY
28902011-03-14 Chong Yidong <cyd@stupidchicken.com>
2891
c96bbc66 2892 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2893
cffc6f3b
CY
28942011-03-13 Chong Yidong <cyd@stupidchicken.com>
2895
2896 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2897 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2898 These macros can no longer be used for assignment.
2899
44f230aa
SM
2900 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2901 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2902 (record_buffer_markers, fetch_buffer_markers): New functions for
2903 recording and fetching special buffer markers.
2904 (set_buffer_internal_1, set_buffer_temp): Use them.
2905
2906 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2907
2908 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2909
2910 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2911 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2912
2913 * xdisp.c (hscroll_window_tree):
2914 (reconsider_clip_changes): Use PT instead of BUF_PT.
2915
d251f04b
EZ
29162011-03-13 Eli Zaretskii <eliz@gnu.org>
2917
2918 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2919 $(EMACS_ROOT)/lib/intprops.h.
2920
f0c77cd1
PE
29212011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2922
3eca4629
PE
2923 Fix more problems found by GCC 4.5.2's static checks.
2924
7c86ee98
PE
2925 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2926 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2927 (xg_free_frame_widgets): Make it clear that a local variable is
2928 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2929 (gdk_window_get_screen): Make it clear that this macro is needed
2930 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2931 (int_gtk_range_get_value): New function, which avoids a diagnostic
2932 from gcc -Wbad-function-cast.
2933 (xg_set_toolkit_scroll_bar_thumb): Use it.
2934 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2935 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2936 (get_utf8_string, xg_get_file_with_chooser):
2937 Rename locals to avoid shadowing.
2938 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2939
41729b81
PE
2940 * xgselect.c (xg_select): Remove unused var.
2941
f0c77cd1
PE
2942 * image.c (four_corners_best): Mark locals as initialized.
2943 (gif_load): Initialize transparent_p to zero (Bug#8238).
2944 Mark another local as initialized.
ec6cf4c6 2945 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2946
ce0ad53d 2947 * image.c (clear_image_cache): Now static.
d5d5a617 2948 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2949 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2950 (x_edge_detection): Remove unnecessary cast that
2951 gcc -Wbad-function-cast diagnoses.
2037898d 2952 (gif_load): Fix pointer signedness.
6ae141d6
PE
2953 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2954 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2955
33383987 29562011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2957
d32df629
PE
2958 Improve quality of tests for time stamp overflow.
2959 For example, without this patch (encode-time 0 0 0 1 1
2960 1152921504606846976) returns the obviously-bogus value (-948597
2961 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2962 reports time overflow. See
2963 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2964 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2965 * editfns.c: Include limits.h and intprops.h.
2966 (TIME_T_MIN, TIME_T_MAX): New macros.
2967 (time_overflow): Move earlier, to before first use.
2968 (hi_time, lo_time): New functions, for an accurate test for
2969 out-of-range times.
2970 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2971 (Fget_internal_run_time): Don't assume time_t fits in int.
2972 (make_time): Use list2 instead of Fcons twice.
2973 (Fdecode_time): More accurate test for out-of-range times.
2974 (check_tm_member): New function.
2975 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2976 (lisp_time_argument): Don't rely on undefined left-shift and
2977 right-shift behavior when checking for time stamp overflow.
8be6f318 2978
fe31d94c
PE
2979 * editfns.c (time_overflow): New function, refactoring common code.
2980 (Fformat_time_string, Fdecode_time, Fencode_time):
2981 (Fcurrent_time_string): Use it.
2982
8be6f318
PE
2983 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2984 * dired.c (make_time): Move to ...
2985 * editfns.c (make_time): ... here.
2986 * systime.h: Note the move.
2987
09d9db2c 29882011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2989
126bc0dc
YM
2990 * fringe.c (update_window_fringes): Remove unused variables.
2991
c47cbdfd
YM
2992 * unexmacosx.c (copy_data_segment): Also copy __got section.
2993 (Bug#8223)
2994
7ac80be9
EZ
29952011-03-12 Eli Zaretskii <eliz@gnu.org>
2996
c96bbc66 2997 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2998 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2999 Constify `char *' arguments and their references according to
3000 prototypes in tparam.h.
3001
ecb0f94d 3002 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3003
7ac80be9
EZ
3004 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3005 Adapt all references accordingly.
3006
3007 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3008
ef1fd07e
TT
30092011-03-11 Tom Tromey <tromey@redhat.com>
3010
3011 * buffer.c (syms_of_buffer): Remove obsolete comment.
3012
7ef4b50c
EZ
30132011-03-11 Eli Zaretskii <eliz@gnu.org>
3014
3015 * termhooks.h (encode_terminal_code): Declare prototype.
3016
3017 * msdos.c (encode_terminal_code): Don't declare prototype.
3018
3019 * term.c (encode_terminal_code): Now external again, used by
3020 w32console.c and msdos.c.
3021
44f230aa
SM
3022 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3023 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3024
4b1ec863 30252011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3026
1714f52b 3027 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3028
4b1ec863
PE
3029 * fringe.c (update_window_fringes): Mark locals as initialized
3030 (Bug#8227).
3031 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3032
524c7aa6
PE
3033 * alloc.c (mark_fringe_data): Move decl from here ...
3034 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3035 to check its interface.
3036 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3037
a5c0af81 3038 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3039 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3040 (fontset_font): Mark local as initialized.
a9a06e0b 3041 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3042
b4716021
PE
3043 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3044
811e9bac 3045 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3046 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3047 (x_own_selection, Fx_disown_selection_internal): Rename locals
3048 to avoid shadowing.
3049 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3050
7e3ab302
PE
3051 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3052 so that the caller can use some name other than gcpro1.
3053 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3054 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3055 (Fx_backspace_delete_keys_p):
3056 Use them to avoid shadowing, and rename vars to avoid shadowing.
3057 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3058 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3059 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3060 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3061 Remove unused locals.
7e3ab302
PE
3062 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3063 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3064 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3065 macros.
f78faa98 3066
e2b13473
PE
3067 * xterm.h (x_mouse_leave): New decl.
3068
77f23912
PE
3069 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3070 Remove unused functions.
cdf4ba58
PE
3071 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3072 (x_calc_absolute_position): Now static.
7411c686 3073 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3074 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3075 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3076 unless they are used.
38d0b34a
PE
3077 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3078 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3079 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3080 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3081 (x_error_catcher, x_connection_closed, x_error_handler):
3082 (x_error_quitter, xembed_send_message, x_iconify_frame):
3083 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3084 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3085 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3086
44f230aa
SM
3087 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3088 Rename or move locals to avoid shadowing.
6b463e58 3089 (tty_defined_color, merge_face_heights): Now static.
5967d051 3090 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3091 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3092 does not deduce is never used uninitialized.
73719eba
PE
3093 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3094 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3095
426994c3 3096 * terminal.c (store_terminal_param): Now static.
5489860b 3097
032f1620 3098 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3099 (set_frame_menubar): Remove unused local.
d4323972 3100 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3101 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3102 since they might point to immutable storage.
281585b0
PE
3103 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3104 since it's unused otherwise.
032f1620 3105
367c19e5 3106 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3107 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3108 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3109 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3110 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3111 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3112 does not deduce are never used uninitialized.
70739cbe 3113
07b48fa9
PE
3114 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3115
8868a238 3116 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3117 * window.c (window_loop, size_window):
3118 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3119
7e5cf297 3120 * window.c (display_buffer): Now static.
d6550a9f
PE
3121 (size_window): Mark variables that gcc -Wuninitialized
3122 does not deduce are never used uninitialized.
a586633d
PE
3123 * window.h (check_all_windows): New decl, to forestall
3124 gcc -Wmissing-prototypes diagnostic.
5b555da1 3125 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3126
f6095868
PE
3127 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3128 shadowing.
3129 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3130 Include <limits.h>.
3131 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3132 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3133 (load_charset_map): Mark variables that gcc -Wuninitialized
3134 does not deduce are never used uninitialized.
53df7c11 3135 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3136
f38b440c
PE
3137 * coding.c (coding_set_source, coding_set_destination):
3138 Use "else { /* comment */ }" rather than "else /* comment */;"
3139 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3140 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3141 a block, when the outer 'i' will do.
3142 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3143 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3144 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3145 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3146 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3147 Rename locals to avoid shadowing.
3148 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3149 * coding.c (emacs_mule_char, encode_invocation_designation):
3150 Now static, since they're not used elsewhere.
413bb2db 3151 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3152 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3153 (decode_coding_emacs_mule): Mark variables that gcc
3154 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3155 (detect_coding_iso_2022): Initialize a local variable that might
3156 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3157 this initialization is needed. (Bug#8211)
5f58e762
PE
3158 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3159 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3160 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3161 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3162 Remove unused macros.
f38b440c 3163
232b38b9 3164 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3165 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3166 * character.c (string_count_byte8): Likewise.
232b38b9 3167
fb90da1b
PE
3168 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3169 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3170
fb93dbc2
PE
3171 * chartab.c (copy_sub_char_table): Now static, since it's not used
3172 elsewhere.
5c156ace
PE
3173 (sub_char_table_ref_and_range, char_table_ref_and_range):
3174 Rename locals to avoid shadowing.
bbcd0949 3175 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3176
7d3b3862 3177 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3178 (BIDI_BOB): Remove unused macro.
7d3b3862 3179
6be7d3da
PE
3180 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3181 deduce are never used uninitialized.
c2ed9c8b 3182 * term.c (encode_terminal_code): Likewise.
6be7d3da 3183
75f8807f 3184 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3185
50938595
PE
3186 * tparam.h: New file.
3187 * term.c, tparam.h: Include it.
3188 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3189 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3190 Move these decls to tparam.h, and make them agree with what
3191 is actually in tparam.c. The previous trick of using incompatible
3192 decls in different modules does not conform to the C standard.
3193 All callers of tparam changed to use tparam's actual API.
3194 * tparam.c (tparam1, tparam, tgoto):
3195 Use const pointers where appropriate.
3196
fbceeba2
PE
3197 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3198 * cm.h (struct cm): Likewise.
3199 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3200 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3201 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3202 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3203 (turn_on_face, init_tty): Likewise.
3204 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3205
7f3f1250
PE
3206 * term.c (term_mouse_position): Rename local to avoid shadowing.
3207
e6ca6543
PE
3208 * alloc.c (mark_ttys): Move decl from here ...
3209 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3210
c40f8d15
AS
32112011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3212
3213 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3214
cfe0661d
JB
32152011-03-09 Juanma Barranquero <lekktu@gmail.com>
3216
3217 * search.c (compile_pattern_1): Remove argument regp, unused since
3218 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3219 (compile_pattern): Don't pass it.
3220
0afb4571
J
32212011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3222
3223 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3224 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3225 for ! HAVE_GTK3.
3226 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3227
3228 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3229
3230 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3231 gdk_window_get_screen, gdk_window_get_geometry,
3232 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3233 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3234 (xg_get_pixbuf_from_pixmap): New function.
3235 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3236 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3237 Call xg_get_pixbuf_from_pixmap instead of
3238 gdk_pixbuf_get_from_drawable.
3239 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3240 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3241 (xg_check_special_colors): Use GtkStyleContext and its functions
3242 for HAVE_GTK3.
3243 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3244 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3245 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3246 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3247 Call gtk_widget_get_preferred_size.
0afb4571
J
3248 (xg_frame_resized): gdk_window_get_geometry only takes 5
3249 parameters.
44f230aa
SM
3250 (xg_win_to_widget, xg_event_is_for_menubar):
3251 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3252 (xg_set_widget_bg): New function.
3253 (delete_cb): New function.
895009e1 3254 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3255 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3256 (xg_set_background_color): Call xg_set_widget_bg.
3257 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3258 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3259 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3260 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3261 if ! HAVE_GTK3.
3262 (update_frame_tool_bar): Call gtk_widget_hide.
3263 (xg_initialize): Use GDK_KEY_g.
3264
3265 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3266 if ! HAVE_GTK3
3267 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3268
3269 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3270 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3271 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3272
1c2cc4ef
JB
32732011-03-08 Juanma Barranquero <lekktu@gmail.com>
3274
3275 * w32xfns.c (select_palette): Check success of RealizePalette against
3276 GDI_ERROR, not zero.
3277
33383987 3278See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3279
3280;; Local Variables:
3281;; coding: utf-8
aac0c6e3
MR
3282;; End:
3283
33383987 3284 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3285
3286 This file is part of GNU Emacs.
3287
3288 GNU Emacs is free software: you can redistribute it and/or modify
3289 it under the terms of the GNU General Public License as published by
3290 the Free Software Foundation, either version 3 of the License, or
3291 (at your option) any later version.
3292
3293 GNU Emacs is distributed in the hope that it will be useful,
3294 but WITHOUT ANY WARRANTY; without even the implied warranty of
3295 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3296 GNU General Public License for more details.
3297
3298 You should have received a copy of the GNU General Public License
3299 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.