* lread.c (openp): Don't stuff size_t into an 'int'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c2982e87
PE
12011-04-19 Paul Eggert <eggert@cs.ucla.edu>
2
640ee02d
PE
3 * lread.c (openp): Don't stuff size_t into an 'int'.
4 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5 about possible signed overflow.
6
6048fb2a
PE
7 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8 (GDK_KEY_g): Don't define if already defined.
9 (xg_prepare_tooltip): Avoid pointer signedness problem.
10 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11
fa3c87e1
PE
12 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
14
2172544b
PE
15 * xfns.c (Fx_window_property): Simplify a bit,
16 to make a bit faster and to avoid GCC 4.6.0 warning.
17 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
18
9b821a21
PE
19 * fns.c (internal_equal): Don't assume size_t fits in int.
20
3c616cfa
PE
21 * alloc.c (compact_small_strings): Tighten assertion a little.
22
c2982e87
PE
23 Replace pEd with more-general pI, and fix some printf arg casts.
24 * lisp.h (pI): New macro, generalizing old pEd macro to other
25 conversion specifiers. For example, use "...%"pI"d..." rather
26 than "...%"pEd"...".
27 (pEd): Remove. All uses replaced with similar uses of pI.
28 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
29 * alloc.c (check_pure_size): Don't overflow by converting size to int.
30 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
31 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
32 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
33 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
34 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
35 64-bit hosts.
36 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
37 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
38 * print.c (safe_debug_print, print_object): Likewise.
39 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
40 to int.
6f04d126
PE
41 Use pI instead of if-then-else-abort. Use %p to avoid casts,
42 avoiding the 0 flag, which is not portable.
c2982e87
PE
43 * process.c (Fmake_network_process): Use pI to avoid cast.
44 * region-cache.c (pp_cache): Likewise.
45 * xdisp.c (decode_mode_spec): Likewise.
46 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
47 behavior on 64-bit hosts with printf arg.
6f04d126 48 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
49 (x_stop_queuing_selection_requests): Likewise.
50 (x_get_window_property): Don't truncate byte count to an 'int'
51 when tracing.
0b432f21 52
5e073ec7
PE
53 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
54 here, since it parses constructs like leading '-' and spaces,
55 which are not wanted; and it overflows with large numbers.
56 Instead, simply match F[0-9]+, which is what is wanted anyway.
57
36372bf9
PE
58 * alloc.c: Remove unportable assumptions about struct layout.
59 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
60 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
61 (allocate_vectorlike, make_pure_vector): Use the new macros,
62 plus offsetof, to remove unportable assumptions about struct layout.
63 These assumptions hold on all porting targets that I know of, but
64 they are not guaranteed, they're easy to remove, and removing them
65 makes further changes easier.
66
0b432f21
PE
67 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
68 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
69 (string_overrun_cookie): Now const. Use initializers that
70 don't formally overflow signed char, to avoid warnings.
000098c1
PE
71 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
72 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
73 (allocate_buffer): Don't assume sizeof (struct buffer) is a
74 multiple of sizeof (EMACS_INT); it need not be, if
75 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 76 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 77
16a43933
CY
782011-04-18 Chong Yidong <cyd@stupidchicken.com>
79
80 * xdisp.c (lookup_glyphless_char_display)
81 (produce_glyphless_glyph): Handle cons cell entry in
82 glyphless-char-display.
83 (Vglyphless_char_display): Document it.
84
85 * term.c (produce_glyphless_glyph): Handle cons cell entry in
86 glyphless-char-display.
87
4581706e
CY
882011-04-17 Chong Yidong <cyd@stupidchicken.com>
89
90 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
91
92 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
93
94 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
95 definition for no-X builds.
96
4887c6e2 972011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 98
fd35b6f9
PE
99 Static checks with GCC 4.6.0 and non-default toolkits.
100
5c1ccb01
PE
101 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
102
006c5daa
PE
103 * process.c (keyboard_bit_set): Define only if SIGIO.
104 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
105 (send_process): Repair possible setjmp clobbering.
106
efc736d3
PE
107 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
108
4e2fe2e6
PE
109 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
110
f97334a2
PE
111 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
112
4e75f29d
PE
113 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
114 Define only if needed.
115
90efadd1
PE
116 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
117 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 118 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 119
3c647824
PE
120 * dispextern.h (struct redisplay_interface): Rename param
121 to avoid shadowing.
e264f262 122 * termhooks.h (struct terminal): Likewise.
761383f4 123 * xterm.c (xembed_send_message): Likewise.
3c647824 124
b58c5c4a
PE
125 * insdel.c (make_gap_smaller): Define only if
126 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
127
cad59032
PE
128 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
129 it.
130
c339dc2e
PE
131 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
132 so that we aren't warned about unused symbols.
133
91a3e27b
PE
134 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
135
399c71d3 136 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 137
8ffc96f5
PE
138 * xfns.c (x_real_positions): Mark locals as initialized.
139
eef9bc79
PE
140 * xmenu.c (xmenu_show): Don't use uninitialized vars.
141
098db9dd
PE
142 * xterm.c: Fix problems found by static analysis with other toolkits.
143 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
144 (x_dispatch_event): Declare static if USE_GTK, and
145 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 146 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 147 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
148 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
149 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
150
eb18f6cc
PE
151 * xmenu.c (menu_help_callback): Pointer type fixes.
152 Use const pointers when pointing at readonly data. Avoid pointer
153 signedness clashes.
154 (FALSE): Remove unused macro.
155 (update_frame_menubar): Remove unused decl.
156
1fe72bf8
PE
157 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
158
60d9e1db
PE
159 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
160 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
161 (single_menu_item): Rename local to avoid shadowing.
162
39261c26
PE
163 * keyboard.c (make_lispy_event): Remove unused local var.
164
018c5e19
PE
165 * frame.c, frame.h (x_get_resource_string): Bring this back, but
166 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
167
63d2b86e
PE
168 * bitmaps: Change bitmaps from unsigned char back to the X11
169 compatible char. Avoid the old compiler warnings about
170 out-of-range initializers by using, for example, '\xab' rather
171 than 0xab.
172
aefd87e1
PE
173 * xgselect.c (xgselect_initialize): Check vs interface
174 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
175
bf501fb9
PE
176 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
177
e9829fdf
PE
178 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
179 to read-only memory.
180
1086c095
PE
181 * fns.c (vector): Remove; this old hack is no longer needed.
182
2baccd04 183 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 184 Remove unused var.
dde42981 185 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 186
72391843 187 * xrdb.c (x_load_resources): Omit unused local.
3565b346 188
436c16df 189 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 190 (x_window): Rename locals to avoid shadowing.
dc5ddd85 191 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 192
92bb796d 193 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 194 (x_term_init): Remove local to avoid shadowing.
92bb796d 195
764430a3 196 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
197
198 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
199 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
200
d1dfb56c
EZ
2012011-04-16 Eli Zaretskii <eliz@gnu.org>
202
c4354cb4
EZ
203 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
204
d1dfb56c
EZ
205 Fix regex.c, syntax.c and friends for buffers > 2GB.
206 * syntax.h (struct gl_state_s): Declare character position members
207 EMACS_INT.
208
209 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
210
211 * textprop.c (verify_interval_modification, interval_of): Declare
212 arguments EMACS_INT.
213
214 * intervals.c (adjust_intervals_for_insertion): Declare arguments
215 EMACS_INT.
216
217 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
218
219 * indent.c (Fvertical_motion): Local variable it_start is now
220 EMACS_INT.
221
222 * regex.c (re_match, re_match_2, re_match_2_internal)
223 (bcmp_translate, regcomp, regexec, print_double_string)
224 (group_in_compile_stack, re_search, re_search_2, regex_compile)
225 (re_compile_pattern, re_exec): Declare arguments and local
226 variables `size_t' and `ssize_t' and return values `regoff_t', as
227 appropriate.
228 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
229 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
230 <compile_stack_type>: `size' and `avail' are now `size_t'.
231
232 * regex.h <regoff_t>: Use ssize_t, not int.
233 (re_search, re_search_2, re_match, re_match_2): Arguments that
234 specify buffer/string position and length are now ssize_t and
235 size_t. Return type is regoff_t.
236
613052cd
BK
2372011-04-16 Ben Key <bkey76@gmail.com>
238
239 * nsfont.m: Fixed bugs in ns_get_family and
240 ns_descriptor_to_entity that were caused by using free to
241 deallocate memory blocks that were allocated by xmalloc (via
242 xstrdup). This caused Emacs to crash when compiled with
243 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
244 --enable-checking=xmallocoverrun). xfree is now used to
245 deallocate these memory blocks.
246
4170f62f 2472011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 248
71b41406
PE
249 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
250
9587a89d
PE
251 emacs_write: Accept and return EMACS_INT for sizes.
252 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
253 et seq.
254 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
255 Accept and return EMACS_INT.
256 (emacs_gnutls_write): Return the number of bytes written on
257 partial writes.
258 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
259 (emacs_read, emacs_write): Remove check for negative size, as the
260 Emacs source code has been audited now.
9587a89d
PE
261 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
262 (emacs_read, emacs_write): Use it.
273a5f82
PE
263 * process.c (send_process): Adjust to the new signatures of
264 emacs_write and emacs_gnutls_write. Do not attempt to store
265 a byte offset into an 'int'; it might overflow.
9587a89d 266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 267
3e047f51
PE
268 * sound.c: Don't assume sizes fit in 'int'.
269 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 270 Return EMACS_INT, not int.
3e047f51 271 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
272 Accept EMACS_INT, not int.
273 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
274 record read return values.
275
cc39a9db
BK
2762011-04-15 Ben Key <bkey76@gmail.com>
277
c9d0ec6d
JB
278 * keyboard.c (Qundefined): Don't declare static since it is used
279 in nsfns.m.
280 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
281 static since they are used in nsfont.m.
cc39a9db 282
6c60eb9f
SM
2832011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
284
285 * process.c (Qprocessp): Don't declare static.
286 * lisp.h (Qprocessp): Declare again.
287
7990b61a
JB
2882011-04-15 Juanma Barranquero <lekktu@gmail.com>
289
290 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
291
5d4cb038
PE
2922011-04-14 Paul Eggert <eggert@cs.ucla.edu>
293
8bd7b830 294 Improve C-level modularity by making more things 'static'.
cd64ea1d 295
e3b27b31
PE
296 Don't publish debugger-only interfaces to other modules.
297 * lisp.h (safe_debug_print, debug_output_compilation_hack):
298 (verify_bytepos, count_markers): Move decls to the only modules
299 that need them.
300 * region-cache.h (pp_cache): Likewise.
301 * window.h (check_all_windows): Likewise.
302 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
303
5d4cb038
PE
304 * sysdep.c (croak): Now static, if
305 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
306 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
307
308 * alloc.c (refill_memory_reserve): Now static if
309 !defined REL_ALLOC || defined SYSTEM_MALLOC.
310 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 311
e87b6180
PE
312 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
313 Define only if USE_LUCID.
314
ac64929e
PE
315 * xrdb.c (x_customization_string, x_rm_string): Now static.
316
6f37259d
PE
317 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
318 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
319
1683e3ab
PE
320 * xdisp.c (draw_row_with_mouse_face): Now static.
321 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
322
de9c2632
PE
323 * window.h (check_all_windows): Mark externally visible.
324
2b96acb7
PE
325 * window.c (window_deletion_count): Now static.
326
327 * undo.c: Make symbols static if they're not exported.
328 (last_undo_buffer, last_boundary_position, pending_boundary):
329 Now static.
330
50436f33
PE
331 * textprop.c (interval_insert_behind_hooks): Now static.
332 (interval_insert_in_front_hooks): Likewise.
333
64520e5c
PE
334 * term.c: Make symbols static if they're not exported.
335 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
336 (max_frame_lines, tty_set_terminal_modes):
337 (tty_reset_terminal_modes, tty_turn_off_highlight):
338 (get_tty_terminal): Now static.
339 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
340 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 341 HAVE_WINDOW_SYSTEM.
64520e5c
PE
342 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
343 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
344
1fa53021
PE
345 * sysdep.c: Make symbols static if they're not exported.
346 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
347 Now static.
348 (sigprocmask_set, full_mask): Remove; unused.
349 (wait_debugging): Mark as visible.
350 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
351 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
352
d4b43b22
PE
353 * syntax.c (syntax_temp): Define only if !__GNUC__.
354
b7c513d0
PE
355 * sound.c (current_sound_device, current_sound): Now static.
356
989b29ad
PE
357 * search.c (searchbufs, searchbuf_head): Now static.
358
13a55a78
PE
359 * scroll.c (scroll_cost): Remove; unused.
360 * dispextern.h (scroll_cost): Remove decl.
361
de68a1fc
PE
362 * region-cache.h (pp_cache): Mark as externally visible.
363
40ccffa6
PE
364 * process.c: Make symbols static if they're not exported.
365 (process_tick, update_tick, create_process, chan_process):
366 (Vprocess_alist, proc_buffered_char, datagram_access):
367 (fd_callback_data, send_process_frame, process_sent_to): Now static.
368 (deactivate_process): Mark defn as static, as well as decl.
369 * lisp.h (create_process): Remove decl.
370 * process.h (chan_process, Vprocess_alist): Remove decls.
371
ad64fc97
PE
372 * print.c: Make symbols static if they're not exported.
373 (print_depth, new_backquote_output, being_printed, print_buffer):
374 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
375 (print_interval, print_number_index, initial_stderr_stream):
376 Now static.
377 * lisp.h (Fprinc): Remove decl.
378 (debug_output_compilation_hack): Mark as externally visible.
379
adddb265
PE
380 * sysdep.c (croak): Move decl from here to syssignal.h.
381 * syssignal.h (croak): Put it here, so the API can be checked when
382 'croak' is called from dissociate_if_controlling_tty.
383
1717ede2
PE
384 * minibuf.c: Make symbols static if they're not exported.
385 (minibuf_save_list, choose_minibuf_frame): Now static.
386 * lisp.h (choose_minibuf_frame): Remove decl.
387
fa5fb2bc
PE
388 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
389
1e3890d1
PE
390 * lread.c: Make symbols static if they're not exported.
391 (read_objects, initial_obarray, oblookup_last_bucket_number):
392 Now static.
393 (make_symbol): Remove; unused.
394 * lisp.h (initial_obarray, make_symbol): Remove decls.
395
8a1414fa
PE
396 * keyboard.c: Make symbols static if they're not exported.
397 (single_kboard, recent_keys_index, total_keys, recent_keys):
398 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
399 (this_single_command_key_start, echoing, last_auto_save):
400 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
401 (command_loop, echo_now, keyboard_init_hook, help_char_p):
402 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
403 (Vlispy_mouse_stem, double_click_count):
404 Now static.
405 (force_auto_save_soon): Define only if SIGDANGER.
406 (ignore_mouse_drag_p): Now static if
407 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
408 (print_help): Remove; unused.
409 (stop_character, last_timer_event): Mark as externally visible.
410 * keyboard.h (ignore_mouse_drag_p): Declare only if
411 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
412 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
413 * lisp.h (echoing): Remove decl.
414 (force_auto_save_soon): Declare only if SIGDANGER.
415 * xdisp.c (redisplay_window): Simplify code, to make it more
416 obvious that ignore_mouse_drag_p is not accessed if !defined
417 USE_GTK && !defined HAVE_NS.
418
93ea6e8f
PE
419 * intervals.c: Make symbols static if they're not exported.
420 (merge_properties_sticky, merge_interval_right, delete_interval):
421 Now static.
422 * intervals.h (merge_interval_right, delete_interval): Remove decls.
423
77382fcc
PE
424 * insdel.c: Make symbols static if they're not exported.
425 However, leave prepare_to_modify_buffer alone. It's never
426 called from outside this function, but that appears to be a bug.
427 (combine_after_change_list, combine_after_change_buffer):
4889fc82 428 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
429 (adjust_after_replace_noundo): Remove; unused.
430 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 431 (signal_before_change): Remove decls.
77382fcc 432
9306c32e
PE
433 * indent.c (val_compute_motion, val_vmotion): Now static.
434
cd44d2eb
PE
435 * image.c: Make symbols static if they're not exported.
436 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
437 if USE_GTK.
438 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
439 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
440
ad9a7a06
PE
441 * fringe.c (standard_bitmaps): Now static.
442 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
443
81626931
PE
444 * frame.c: Make symbols static if they're not exported.
445 (x_report_frame_params, make_terminal_frame): Now static.
446 (get_frame_param): Now static, unless HAVE_NS.
447 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
448 (x_get_resource_string): Remove; not used.
449 * frame.h (make_terminal_frame, x_report_frame_params):
450 (x_get_resource_string); Remove decls.
451 (x_fullscreen_adjust): Declare only if WINDOWSNT.
452 * lisp.h (get_frame_param): Declare only if HAVE_NS.
453
239f9db9
PE
454 * font.c, fontset.c: Make symbols static if they're not exported.
455 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
456 (FACE_SUITABLE_FOR_CHAR_P): Use it.
457 * font.c (font_close_object): Now static.
458 * font.h (font_close_object): Remove.
459 * fontset.c (FONTSET_OBJLIST): Remove.
460 (free_realized_fontset) #if-0 the body, which does nothing.
461 (face_suitable_for_char_p): #if-0, as it's never called.
462 * fontset.h (face_suitable_for_char_p): Remove decl.
463 * xfaces.c (face_at_string_position): Use
464 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
465 since 0 is always ASCII.
466
dfcf3579
PE
467 * fns.c (weak_hash_tables): Now static.
468
5045092b
PE
469 * fileio.c: Make symbols static if they're not exported.
470 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
471 (Vwrite_region_annotation_buffers): Now static.
472
57a96f5c
PE
473 * eval.c: Make symbols static if they're not exported.
474 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
475 * lisp.h (backtrace_list): Remove decl.
476
35f08c38
PE
477 * emacs.c: Make symbols static if they're not exported.
478 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
479 (fatal_error_code, fatal_error_signal_hook, standard_args):
480 Now static.
481 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
482 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
483 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
484 * lisp.h (fatal_error_signal_hook): Remove decl.
485 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
486
f44bd759
PE
487 * editfns.c: Move a (normally-unused) function to its only use.
488 * editfns.c, lisp.h (get_operating_system_release): Remove.
489 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
490 worth the hassle of breaking this out.
491
b532497d
PE
492 * xterm.c: Make symbols static if they're not exported.
493 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
494 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
495 (x_destroy_window, x_delete_display):
496 Now static.
497 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
498 (x_mouse_leave): Remove; unused.
499 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
500 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
501 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
502 Remove decls.
503 (x_mouse_leave): Declare only if WINDOWSNT.
504 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
505 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
506 USE_X_TOOLKIT.
507
1675728f
PE
508 * ftxfont.c: Make symbols static if they're not exported.
509 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
510 HAVE_FREETYPE.
511 * font.h (ftxfont_driver): Likewise.
512
e4cebfca
PE
513 * xfns.c: Make symbols static if they're not exported.
514 (x_last_font_name, x_display_info_for_name):
515 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
516 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
517 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
518 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
519 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
520 (last_show_tip_args): Now static.
521 (xic_defaut_fontset, xic_create_fontsetname): Define only if
522 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
523 (x_screen_planes): Remove; unused.
524 * dispextern.h (x_screen_planes): Remove decl.
525
5bf46f05
PE
526 * dispnew.c: Make symbols static if they're not exported.
527 * dispextern.h (redraw_garbaged_frames, scrolling):
528 (increment_row_positions): Remove.
529 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
530 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
531 Now static.
532 (redraw_garbaged_frames): Remove; unused.
533
435f4c28
PE
534 * xfaces.c: Make symbols static if they're not exported.
535 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
536 Remove decls.
537 * xterm.h (defined_color): Remove decls.
538 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
539 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
540 (menu_face_changed_default, defined_color, free_realized_face):
541 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
542 (ascii_face_of_lisp_face): Remove; unused.
543
8524aef3
PE
544 * xdisp.c: Make symbols static if they're not exported.
545 * dispextern.h (scratch_glyph_row, window_box_edges):
546 (glyph_to_pixel_coords, set_cursor_from_row):
547 (get_next_display_element, set_iterator_to_next):
548 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
549 (show_mouse_face): Remove decls
550 * frame.h (message_buf_print): Likewise.
551 * lisp.h (pop_message, set_message, check_point_in_composition):
552 Likewise.
553 * xterm.h (set_vertical_scroll_bar): Likewise.
554 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
555 (message_buf_print, scratch_glyph_row, displayed_buffer):
556 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
557 (get_next_display_element, show_mouse_face, window_box_edges):
558 (frame_to_window_pixel_xy, check_point_in_composition):
559 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
560 (glyph_to_pixel_coords): Remove; unused.
561
16390cd2
PE
562 * dired.c (file_name_completion): Now static.
563
564 * dbusbind.c (xd_in_read_queued_messages): Now static.
565
a25f4dfa
PE
566 * lisp.h (circular_list_error, FOREACH): Remove; unused.
567 * data.c (circular_list_error): Remove.
568
14a9c8df
PE
569 * commands.h (last_point_position, last_point_position_buffer):
570 (last_point_position_window): Remove decls.
571 * keyboard.c: Make these variables static.
572
74ab6df5
PE
573 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
574 decls.
575 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
576 (iso_code_class, detect_coding, code_convert_region): Now static.
577 (encode_coding_gap): Remove; unused.
578
38dfbee1
PE
579 * chartab.c (chartab_chars, chartab_bits): Now static.
580
a2cb4e63
PE
581 * charset.h (charset_iso_8859_1): Remove decl.
582 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
583 Now static.
584
127198fd
PE
585 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
586 * ccl.c (Vccl_program_table): Now static.
587 (check_ccl_update): Remove; unused.
588
d85b608f
PE
589 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
590 * category.h: ... from here.
591 * category.c (check_category_table, set_category_set): Now static.
592
31cd66f3
PE
593 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
594 * lisp.h: Remove these decls.
595
c358e587
PE
596 * buffer.c (buffer_count): Remove unused var.
597
e78aecca
PE
598 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
599 so that it's not optimized away.
600 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
601 * dispextern.h (bidi_dump_cached_states): Remove, since it's
602 exported only to the debugger.
603
e192d7d3
PE
604 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
605 * atimer.h (run_all_atimers): Removed; not exported.
606
92470028
PE
607 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
608 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
609 was inaccessible from Lisp.
610 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
611 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
612
244ed907
PE
613 alloc.c: Import and export fewer symbols, and remove unused items.
614 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
615 is defined.
616 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
617 it's not optimized away by whole-program optimization.
618 (message_enable_multibyte, free_misc): Remove.
619 (catchlist, handlerlist, mark_backtrace):
620 Declare only if BYTE_MARK_STACK.
621 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
622 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
623 (message_enable_multibyte): Remove decl.
624 (free_misc, interval_free_list, float_block, float_block_index):
625 (n_float_blocks, float_free_list, cons_block, cons_block_index):
626 (cons_free_list, last_marked_index):
627 Now static.
628 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
629 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
630 (mark_backtrace): Define only if BYTE_MARK_STACK.
631 * xdisp.c (message_enable_multibyte): Now static.
632
61c2b50e 633 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
634 This makes it easier for human readers (and static analyzers)
635 to see whether these variables are used from other modules.
636 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
637 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
638 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
639 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
640 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
641 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
642 * xmenu.c, xselect.c:
643 Declare Q* vars static if they are not used in other modules.
644 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
645 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
646 Remove decls of unexported vars.
647 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
648
95c82688
PE
649 * lisp.h (DEFINE_FUNC): Make sname 'static'.
650
16a97296
PE
651 Make Emacs functions such as Fatom 'static' by default.
652 This makes it easier for human readers (and static analyzers)
653 to see whether these functions can be called from other modules.
654 DEFUN now defines a static function. To make the function external
655 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
656 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
657 (Finit_image_library):
16a97296
PE
658 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
659 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
660 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
661 Remove decls, since these functions are now static.
662 (Funintern, Fget_internal_run_time): New decls, since these functions
663 were already external.
95c82688 664
16a97296
PE
665 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
666 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
667 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
668 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
669 * keyboard.c, keymap.c, lread.c:
670 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
671 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
672 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
673 Mark functions with DEFUE instead of DEFUN,
674 if they are used in other modules.
675 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
676 decls for now-static functions.
677 * buffer.h (Fdelete_overlay): Remove decl.
678 * callproc.c (Fgetenv_internal): Mark as internal.
679 * composite.c (Fremove_list_of_text_properties): Remove decl.
680 (Fcomposition_get_gstring): New forward static decl.
681 * composite.h (Fcomposite_get_gstring): Remove decl.
682 * dired.c (Ffile_attributes): New forward static decl.
683 * doc.c (Fdocumntation_property): New forward static decl.
684 * eval.c (Ffetch_bytecode): New forward static decl.
685 (Funintern): Remove extern decl; now in .h file where it belongs.
686 * fileio.c (Fmake_symbolic_link): New forward static decl.
687 * image.c (Finit_image_library): New forward static decl.
688 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
689 * intervals.h (Fprevious_property_change):
690 (Fremove_list_of_text_properties): Remove decls.
691 * keyboard.c (Fthis_command_keys): Remove decl.
692 (Fcommand_execute): New forward static decl.
693 * keymap.c (Flookup_key): New forward static decl.
694 (Fcopy_keymap): Now static.
695 * keymap.h (Flookup_key): Remove decl.
696 * process.c (Fget_process): New forward static decl.
697 (Fprocess_datagram_address): Mark as internal.
698 * syntax.c (Fsyntax_table_p): New forward static decl.
699 (skip_chars): Remove duplicate decl.
700 * textprop.c (Fprevious_property_change): New forward static decl.
701 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
702 Now internal.
703 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
704 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
705
785bbd42
PE
706 * editfns.c (Fformat): Remove unreachable code.
707
8b913b57
AS
7082011-04-14 Andreas Schwab <schwab@linux-m68k.org>
709
710 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
711 change. (Bug#8496)
712
a6744a35
EZ
7132011-04-13 Eli Zaretskii <eliz@gnu.org>
714
715 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
716 when at ZV. (Bug#8487)
717
e7974947
AS
7182011-04-12 Andreas Schwab <schwab@linux-m68k.org>
719
baad03f0
AS
720 * charset.c (Fclear_charset_maps): Use xfree instead of free.
721 (Bug#8437)
722 * keyboard.c (parse_tool_bar_item): Likewise.
723 * sound.c (sound_cleanup, alsa_close): Likewise.
724 * termcap.c (tgetent): Likewise.
725 * xfns.c (x_default_font_parameter): Likewise.
726 * xsettings.c (read_and_apply_settings): Likewise.
727
e7974947
AS
728 * alloc.c (overrun_check_malloc, overrun_check_realloc)
729 (overrun_check_free): Protoize.
730
28272684
PE
7312011-04-12 Paul Eggert <eggert@cs.ucla.edu>
732
733 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
734 since callers should never pass a negative size.
735 Change the signature to match that of plain 'read' and 'write'; see
736 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
737 * lisp.h: Update prototypes of emacs_write and emacs_read.
738
11997c76
EZ
7392011-04-11 Eli Zaretskii <eliz@gnu.org>
740
741 * xdisp.c (redisplay_window): Don't try to determine the character
742 position of the scroll margin if the window start point w->startp
e896f03c 743 is outside the buffer's accessible region. (Bug#8468)
11997c76 744
8a2cbd72
EZ
7452011-04-10 Eli Zaretskii <eliz@gnu.org>
746
747 Fix write-region and its subroutines for buffers > 2GB.
748 * fileio.c (a_write, e_write): Modify declaration of arguments and
749 local variables to support buffers larger than 2GB.
750 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
751
752 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
753 argument, local variables, and return value.
754
755 * lisp.h: Update prototypes of emacs_write and emacs_read.
756
757 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
758
4073e537 7592011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 760
1ebfdcb6
PE
761 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
762
b2ded58d
PE
763 Fix more problems found by GCC 4.6.0's static checks.
764
7d66342c
PE
765 * xdisp.c (vmessage): Use a better test for character truncation.
766
bbf47d44
PE
767 * charset.c (load_charset_map): <, not <=, for optimization,
768 and to avoid potential problems with integer overflow.
9248994d 769 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 770 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 771 * editfns.c (Fformat): Likewise.
1e69125e 772 * syntax.c (skip_chars): Likewise.
3befa583 773
e3019616
PE
774 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
775 This also lets GCC 4.6.0 generate slightly better loop code.
776
becfa255
PE
777 * callint.c (Fcall_interactively): <, not <=, for optimization.
778 (Fcall_interactively): Count the number of arguments produced,
779 not the number of arguments given. This is simpler and lets GCC
780 4.6.0 generate slightly better code.
781
dae0cd48
PE
782 * ftfont.c: Distingish more carefully between FcChar8 and char.
783 The previous code passed unsigned char * to a functions like
784 strlen and xstrcasecmp that expect char *, which does not
785 conform to the C standard.
786 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
787 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
788 char * when the C standard requires it.
789
76032d70
PE
790 * keyboard.c (read_char): Remove unused var.
791
eb3f1cc8
PE
792 * eval.c: Port to Windows vsnprintf (Bug#8435).
793 Include <limits.h>.
794 (SIZE_MAX): Define if the headers do not.
795 (verror): Do not give up if vsnprintf returns a negative count.
796 Instead, grow the buffer. This ports to Windows vsnprintf, which
797 does not conform to C99. Problem reported by Eli Zaretskii.
798 Also, simplify the allocation scheme, by avoiding the need for
799 calling realloc, and removing the ALLOCATED variable.
800
70476b54
PE
801 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
802
12020a9e
PE
803 Remove invocations of doprnt, as Emacs now uses vsnprintf.
804 But keep the doprint source code for now, as we might revamp it
805 and use it again (Bug#8435).
ea6c7ae6
PE
806 * lisp.h (doprnt): Remove.
807 * Makefile.in (base_obj): Remove doprnt.o.
808 * deps.mk (doprnt.o): Remove.
809
5fdb398c
PE
810 error: Print 32- and 64-bit integers portably (Bug#8435).
811 Without this change, on typical 64-bit hosts error ("...%d...", N)
812 was used to print both 32- and 64-bit integers N, which relied on
813 undefined behavior.
814 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
815 New macro.
816 * lisp.h (error, verror): Mark as printf-like functions.
817 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
818 Report overflow in size calculations when allocating printf buffer.
819 Do not truncate output string at its first null byte.
820 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
821 Truncate the output at a character boundary, since vsnprintf does not
822 do that.
823 * charset.c (check_iso_charset_parameter): Convert internal
824 character to string before calling 'error', since %c now has the
825 printf meaning.
826 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
827 overflow when computing char to be passed to 'error'. Do not
828 pass Lisp_Object to 'error'; pass the integer instead.
829 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
830 formatted with plain %d.
831
b189fa66
PE
832 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
833
bff87ef0
PE
834 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
835
7e2cac20
PE
836 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
837
ce4d90b5
PE
838 * xterm.c (x_catch_errors): Remove duplicate declaration.
839
266c9547
PE
840 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
841
79c49ad2
PE
842 * xdisp.c, lisp.h (message_nolog): Remove; unused.
843
368f4090
JM
8442011-04-10 Jim Meyering <meyering@redhat.com>
845
846 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
847 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
848 return ssize_t not "int", and use size_t as the buffer length.
849 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
850 * gnutls.h: Update declarations.
851 * process.c (read_process_output): Use ssize_t, to match.
852 (send_process): Likewise.
853
a32d4040
CY
8542011-04-09 Chong Yidong <cyd@stupidchicken.com>
855
856 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
857
8546720e 8582011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 859
8546720e
GM
860 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
861 unsigned char, to match FcChar8 type definition.
aac0c6e3 862
8546720e
GM
863 * xterm.c (handle_one_xevent):
864 * xmenu.c (create_and_show_popup_menu):
865 * xselect.c (x_decline_selection_request)
866 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 867
0a2f5c1a 8682011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
869
870 Fix some uses of `int' instead of EMACS_INT.
871 * search.c (string_match_1, fast_string_match)
872 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
873 (scan_buffer, find_next_newline_no_quit)
874 (find_before_next_newline, search_command, Freplace_match)
875 (Fmatch_data): Make some `int' variables be EMACS_INT.
876
877 * xdisp.c (display_count_lines): 3rd argument and return value now
878 EMACS_INT. All callers changed.
879 (pint2hrstr): Last argument is now EMACS_INT.
880
881 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
882 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
883 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
884 (decode_coding_utf_16, decode_coding_emacs_mule)
885 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
886 (decode_coding_ccl, decode_coding_charset)
887 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
888 (decode_coding_iso_2022, decode_coding_emacs_mule)
889 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
890 <char_offset, last_offset>: Declare EMACS_INT.
891 (encode_coding_utf_8, encode_coding_utf_16)
892 (encode_coding_emacs_mule, encode_invocation_designation)
893 (encode_designation_at_bol, encode_coding_iso_2022)
894 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
895 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
896 Declare EMACS_INT.
897 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
898 (encode_invocation_designation): Last argument P_NCHARS is now
899 EMACS_INT.
900 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
901 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
902
903 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
904 All users changed.
905
906 * ccl.c (Fccl_execute_on_string): Declare some variables
907 EMACS_INT.
908
8546720e 9092011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
910
911 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
912
4e19a977
CS
9132011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
914
915 * process.c (Fformat_network_address): Doc fix.
916
87302331
R
9172011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
918
919 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
920
cbb59342
CY
9212011-04-08 Chong Yidong <cyd@stupidchicken.com>
922
923 * keyboard.c (read_char): Call Lisp function help-form-show,
924 instead of using internal_with_output_to_temp_buffer.
925 (Qhelp_form_show): New var.
e0d38eeb 926 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
927
928 * print.c (internal_with_output_to_temp_buffer): Function deleted.
929
930 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
931
e67a13ab
CY
9322011-04-06 Chong Yidong <cyd@stupidchicken.com>
933
934 * process.c (Flist_processes): Removed to Lisp.
935 (list_processes_1): Deleted.
936
973f782d
EZ
9372011-04-06 Eli Zaretskii <eliz@gnu.org>
938
7c106b1e
EZ
939 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
940
973f782d
EZ
941 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
942
41cf7d1a 9432011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 944
ca23cc88
PE
945 Fix more problems found by GCC 4.6.0's static checks.
946
f390e2d5
PE
947 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
948
42eea0d0
PE
949 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
950
b69769da 951 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 952
f9541e84
PE
953 * xdisp.c (vmessage): Mark as a printf-like function.
954
13841b55
PE
955 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
956
c136c10f
PE
957 * sound.c (sound_warning): Don't crash if arg contains a printf format.
958
5e2d4a30
PE
959 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
960 printf-like functions.
961 (tiff_load): Add casts to remove these marks before passing them
962 to system-supplied API.
963
583f48b9
PE
964 * eval.c (Fsignal): Remove excess argument to 'fatal'.
965
b25d760e
PE
966 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
967 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
968 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
969 directly, rather than having caller test rule sign. This avoids
970 some unnecessary tests.
971 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
972 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
973 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 974
bc7b6697 975 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 976 (xfont_open): Avoid unnecessary tests.
bc7b6697 977
27ccc379
PE
978 * composite.c (composition_gstring_put_cache): Use unsigned integer.
979
dcd5c89a
PE
980 * composite.h, composite.c (composition_gstring_put_cache):
981 Use EMACS_INT, not int, for length.
982
b13a45c6
PE
983 * composite.h (COMPOSITION_DECODE_REFS): New macro,
984 breaking out part of COMPOSITION_DECODE_RULE.
985 (COMPOSITION_DECODE_RULE): Use it.
986 * composite.c (get_composition_id): Remove unused local vars,
987 by using the new macro.
988
1e792e4d
PE
989 * textprop.c (set_text_properties_1): Change while to do-while,
990 since the condition is always true at first.
991
dc6c6455 992 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
993 (interval_deletion_adjustment): Return unsigned value.
994 All uses changed.
dc6c6455 995
aba7731a
PE
996 * process.c (list_processes_1, create_pty, read_process_output):
997 (exec_sentinel): Remove vars that were set but not used.
afd4052b 998 (create_pty): Remove unnecessary "volatile"s.
bc57d757 999 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1000 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1001 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1002
fdfc4bf3
PE
1003 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1004
fca8fe46 1005 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1006 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1007
06a0259a 1008 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1009 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1010 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1011
e7b9e80f
PE
1012 * print.c (print_error_message): Avoid int overflow.
1013
56201685
PE
1014 * font.c (font_list_entities): Redo for clarity,
1015 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1016
78834453 1017 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1018 (font_score): Avoid potential overflow in diff calculation.
78834453 1019
0bc0b309 1020 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1021 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1022
e610eaca
PE
1023 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1024
b895abce
PE
1025 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1026 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1027 can always succeed if overflow has undefined behavior.
1028
1f1d9321 1029 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1030 (wordify): Omit three unnecessary tests.
1f1d9321 1031
c59478bc
PE
1032 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1033 All callers changed. This avoids the need for an unused var.
1034
79b73827
PE
1035 * casefiddle.c (casify_region): Remove var that is set but not used.
1036
a4db5dfe
PE
1037 * dired.c (file_name_completion): Remove var that is set but not used.
1038
43aae36e
PE
1039 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1040
2a47c44d 1041 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1042 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1043
a37c69bf
PE
1044 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1045 Check for integer overflow on size calculations.
1046
328ab8e7
PE
1047 * buffer.c (Fprevious_overlay_change): Remove var that is set
1048 but not used.
1049
e5a2a5cb
PE
1050 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1051 Remove vars that are set but not used.
8d84a6eb 1052 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1053 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1054
a60e5f68
PE
1055 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1056
f661cb61 1057 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1058 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1059
f0397f5a
PE
1060 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1061 that are set but not used.
1062
8664db06 1063 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1064 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1065
6abdaa4a
PE
1066 * xselect.c (x_get_local_selection, x_handle_property_notify):
1067 Remove vars that are set but not used.
1068
0ce7538d 1069 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1070 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1071
9ae848fc
PE
1072 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1073 Remove var that is set but not used.
0b918413
PE
1074 (scroll_bar_windows_size): Now size_t, not int.
1075 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1076 Check for overflow.
9ae848fc 1077
a5a62657
PE
1078 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1079 (map_tty_color) [!defined MSDOS]: Likewise.
1080
5c5cdd39
PE
1081 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1082
66ebf983
PE
1083 * coding.c: Remove vars that are set but not used.
1084 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1085 All callers changed.
1086 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1087 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1088 (decode_coding_charset): Remove vars that are set but not used.
1089
1be4d761
PE
1090 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1091 that is set but not used.
1092
47553fa8
PE
1093 * print.c (print_object): Remove var that is set but not used.
1094
1f7196bf 1095 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1096 The gnulib version avoids calling malloc in the usual case,
1097 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1098 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1099 * filelock.c (current_lock_owner): Likewise.
1100 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1101 * sysdep.c: Include allocator.h, careadlinkat.h.
1102 (emacs_no_realloc_allocator): New static constant.
1103 (emacs_readlink): New function.
fdb61804
PE
1104 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1105 ../lib/careadlinkat.h.
d1fdcab7 1106
f84c17c7
SM
11072011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1108
1109 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1110 first non-nil return value).
1111
ef3862ad
JD
11122011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1113
1114 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1115 if not defined (Bug#8403).
1116
376a7006
JB
11172011-04-02 Juanma Barranquero <lekktu@gmail.com>
1118
1119 * xdisp.c (display_count_lines): Remove parameter `start',
1120 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1121 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1122 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1123 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1124 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1125 and thereabouts. All callers changed.
1126 (get_per_char_metric): Remove parameter `f', unused since
1127 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1128
6ca3801d
JM
11292011-04-02 Jim Meyering <meyering@redhat.com>
1130
1131 do not dereference NULL upon failed strdup
1132 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1133 (ns_get_family): Likewise.
1134
d8e2b5ba
JB
11352011-04-02 Juanma Barranquero <lekktu@gmail.com>
1136
1137 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1138
8c74fcbd
JD
11392011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1140
1141 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1142 later (Bug#8403).
1143
7200d79c
SM
11442011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1145
03408648 1146 Add lexical binding.
7200d79c 1147
03408648
SM
1148 * window.c (Ftemp_output_buffer_show): New fun.
1149 (Fsave_window_excursion):
1150 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1151
1152 * lread.c (lisp_file_lexically_bound_p): New function.
1153 (Fload): Bind Qlexical_binding.
1154 (readevalloop): Remove `evalfun' arg.
1155 Bind Qinternal_interpreter_environment.
1156 (Feval_buffer): Bind Qlexical_binding.
1157 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1158 Mark as dynamic.
1159 (syms_of_lread): Declare `lexical-binding'.
1160
1161 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1162
1163 * keyboard.c (eval_dyn): New fun.
1164 (menu_item_eval_property): Use it.
ca105506
SM
1165
1166 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1167
03408648
SM
1168 * fns.c (concat, mapcar1): Accept byte-code-functions.
1169
1170 * eval.c (Fsetq): Handle lexical vars.
1171 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1172 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1173 (FletX, Flet): Obey lexical binding.
1174 (Fcommandp): Handle closures.
1175 (Feval): New `lexical' arg.
1176 (eval_sub): New function extracted from Feval. Use it almost
1177 everywhere where Feval was used. Look up vars in lexical env.
1178 Handle closures.
1179 (Ffunctionp): Move from subr.el.
1180 (Ffuncall): Handle closures.
1181 (apply_lambda): Remove `eval_flags'.
1182 (funcall_lambda): Handle closures and new byte-code-functions.
1183 (Fspecial_variable_p): New function.
1184 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1185 but without exporting it to Lisp.
23aba0ea 1186
23aba0ea 1187 * doc.c (Fdocumentation, store_function_docstring):
03408648 1188 * data.c (Finteractive_form): Handle closures.
23aba0ea 1189
03408648
SM
1190 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1191 interactive spec.
ba83908c 1192
03408648
SM
1193 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1194 byte-codes.
1195 (exec_byte_code): New function extracted from Fbyte_code to handle new
1196 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1197
03408648 1198 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1199
03408648 1200 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1201
e2abce01
JB
12022011-03-31 Juanma Barranquero <lekktu@gmail.com>
1203
1204 * xdisp.c (redisplay_internal): Fix prototype.
1205
63696a73 12062011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1207
63696a73
EZ
1208 * xdisp.c (SCROLL_LIMIT): New macro.
1209 (try_scrolling): Use it when setting scroll_limit. Limit
1210 scrolling to 100 screen lines.
1211 (redisplay_window): Even when falling back on "recentering",
1212 position point in the window according to scroll-conservatively,
1213 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1214
1215 (try_scrolling): When point is above the window, allow searching
1216 as far as scroll_max, or one screenful, to compute vertical
1217 distance from PT to the scroll margin position. This prevents
1218 try_scrolling from unnecessarily failing when
1219 scroll-conservatively is set to a value slightly larger than the
1220 window height. Clean up the case of PT below the margin at bottom
1221 of window: scroll_max can no longer be INT_MAX. When aggressive
1222 scrolling is in use, don't let point enter the opposite scroll
1223 margin as result of the scroll.
1224 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1225 threshold of 100 lines for never-recentering scrolling.
1226
e4cc2dfc
JB
12272011-03-31 Juanma Barranquero <lekktu@gmail.com>
1228
1229 * dispextern.h (move_it_by_lines):
1230 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1231 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1232 (message_log_check_duplicate): Remove parameters `prev_bol' and
1233 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1234 (redisplay_internal): Remove parameter `preserve_echo_area',
1235 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1236
1237 * indent.c (Fvertical_motion):
1238 * window.c (window_scroll_pixel_based, Frecenter):
1239 Don't pass `need_y_p' to `move_it_by_lines'.
1240
1c470562
SM
12412011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1242
44f230aa
SM
1243 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1244 steal a few bits to be more compact.
1245 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1246 Remove unneeded casts.
1247
1c470562
SM
1248 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1249
888adce9
ZK
12502011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1251
1252 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1253 binding" message (bug#7967).
1254
f838ed7b
PE
12552011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1256
77861b95
PE
1257 Fix more problems found by GCC 4.6.0's static checks.
1258
de6dbc14
PE
1259 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1260 Remove unused local var.
1261
f838ed7b
PE
1262 * editfns.c (Fmessage_box): Remove unused local var.
1263
792c7b2b
PE
1264 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1265 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1266 Omit unused local vars.
c499e557 1267 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1268 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1269 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1270 Omit unused local var.
1271
ba0165e1
PE
1272 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1273 Don't assume string length fits in int.
32ad8845 1274 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1275 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1276
3c59b4c9
PE
1277 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1278 instead of alloca (Bug#8344).
1279
a3eed478 1280 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1281 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1282
eb4d412d
PE
1283 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1284
1658b401
PE
1285 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1286 concerns.
1287
1288 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1289
1290 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1291
9a2c6e05
PE
1292 * keyboard.c (syms_of_keyboard): Use the same style as later
1293 in this function when indexing through an array. This also
1294 works around GCC bug 48267.
1295
03d0a109
PE
1296 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1297
44f730c8
PE
1298 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1299
fe75f926
PE
1300 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1301 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1302
ffa8c828
PE
1303 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1304 This avoids undefined behavior on integer overflow, and is a bit
1305 more convenient anyway since it is compared to a size_t variable.
1306
c5101a77
PE
1307 Variadic C functions now count arguments with size_t, not int.
1308 This avoids an unnecessary limitation on 64-bit machines, which
1309 caused (substring ...) to crash on large vectors (Bug#8344).
1310 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1311 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1312 All variadic functions and their callers changed accordingly.
c5101a77
PE
1313 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1314 * data.c (arith_driver, float_arith_driver): Likewise.
1315 * editfns.c (general_insert_function): Likewise.
1316 * eval.c (struct backtrace.nargs, interactive_p)
1317 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1318 (funcall_lambda, mark_backtrace): Likewise.
1319 * fns.c (concat): Likewise.
1320 * frame.c (x_set_frame_parameters): Likewise.
1321 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1322 0 if not found, not -1. All callers changed.
1323
dd3f25f7
PE
1324 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1325 (stack_copy_size): Now size_t, not int.
1326 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1327
461c2ab9
JB
13282011-03-28 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1331 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1332 All callers changed.
1333
1334 * lisp.h (multibyte_char_to_unibyte):
1335 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1336 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1337 * character.h (CHAR_TO_BYTE8):
1338 * cmds.c (internal_self_insert):
1339 * editfns.c (general_insert_function):
1340 * keymap.c (push_key_description):
1341 * search.c (Freplace_match):
1342 * xdisp.c (message_dolog, set_message_1): All callers changed.
1343
f6d62986
SM
13442011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1345
1346 * keyboard.c (safe_run_hook_funcall): New function.
1347 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1348 don't set the hook to nil, but remove the offending function instead.
1349 (Qcommand_hook_internal): Remove, unused.
1350 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1351 Vcommand_hook_internal.
1352
1353 * eval.c (enum run_hooks_condition): Remove.
1354 (funcall_nil, funcall_not): New functions.
1355 (run_hook_with_args): Call each function through a `funcall' argument.
1356 Remove `cond' argument, now redundant.
1357 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1358 (Frun_hook_with_args_until_failure): Adjust accordingly.
1359 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1360
1db5b1ad
JB
13612011-03-28 Juanma Barranquero <lekktu@gmail.com>
1362
1363 * dispextern.h (string_buffer_position): Remove declaration.
1364
1365 * print.c (strout): Remove parameter `multibyte', unused since
1366 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1367
1368 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1369 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1370 All callers changed.
1371
1372 * w32.c (_wsa_errlist): Use braces for struct initializers.
1373
1374 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1375 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1376 All callers changed.
1377 (string_buffer_position): Likewise. Also, make static (it's never
1378 used outside xdisp.c).
1379 (cursor_row_p): Remove parameter `w', unused since
1380 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1381 (decode_mode_spec): Remove parameter `precision', introduced during
1382 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1383 All callers changed.
1384
5ffb62aa
JD
13852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1386
1387 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1388
461c2ab9 13892011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1390
1391 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1392 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1393 (ns_update_auto_hide_menu_bar): New functions.
1394 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1395 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1396 ns_constrain_all_frames.
1397 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1398 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1399
5c380ffb
JD
14002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1401
1402 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1403
9af30bdf
GM
14042011-03-27 Glenn Morris <rgm@gnu.org>
1405
1406 * syssignal.h: Replace RETSIGTYPE with void.
1407 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1408 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1409 Replace SIGTYPE with void everywhere.
1410 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1411 * s/template.h (SIGTYPE): Remove commented out definition.
1412
e2abce01
JB
14132011-03-26 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1416 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1417
f868cd8a
JB
14182011-03-26 Juanma Barranquero <lekktu@gmail.com>
1419
59eb0929
JB
1420 * w32.c (read_unc_volume): Use parameter `henum', instead of
1421 global variable `wget_enum_handle'.
1422
1423 * keymap.c (describe_vector): Remove parameters `indices' and
1424 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1425 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1426
f868cd8a
JB
1427 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1428
1429 * keyboard.c (timer_check): Remove parameter `do_it_now',
1430 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1431 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1432 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1433
1434 * keyboard.c (read_char):
1435 * w32menu.c (w32_menu_display_help):
1436 * xmenu.c (show_help_event, menu_help_callback):
1437 Adjust calls to `show_help_echo'.
1438
1439 * gtkutil.c (xg_maybe_add_timer):
1440 * keyboard.c (readable_events):
1441 * process.c (wait_reading_process_output):
1442 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1443
1444 * insdel.c (adjust_markers_gap_motion):
1445 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1446 (gap_left, gap_right): Don't call it.
1447
2ecf6fdb
CY
14482011-03-25 Chong Yidong <cyd@stupidchicken.com>
1449
1450 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1451 incurred during fontification.
1452
6b1f9ba4
JB
14532011-03-25 Juanma Barranquero <lekktu@gmail.com>
1454
1455 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1456 (DEFVAR_PER_BUFFER): Don't pass it.
1457
1458 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1459 (scrolling_window): Don't pass it.
1460
0f4a96b5
JB
14612011-03-25 Juanma Barranquero <lekktu@gmail.com>
1462
1463 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1464
1465 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1466 and `suffix'.
1467 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1468 of variables specific to SELinux and computation of `encoded_absname'.
1469
1470 * image.c (XPutPixel): Remove unused variable `height'.
1471
1472 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1473
1474 * unexw32.c (get_section_info): Remove unused variable `section'.
1475
1476 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1477 (system_process_attributes): Remove unused variable `sess'.
1478 (sys_read): Remove unused variable `err'.
1479
1480 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1481 (w32_wnd_proc): Remove unused variable `isdead'.
1482 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1483 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1484 (x_create_tip_frame): Remove unused variable `tem'.
1485
1486 * w32inevt.c (w32_console_read_socket):
1487 Remove unused variable `no_events'.
1488
1489 * w32term.c (x_draw_composite_glyph_string_foreground):
1490 Remove unused variable `width'.
1491
1149507c
JB
14922011-03-24 Juanma Barranquero <lekktu@gmail.com>
1493
1494 * w32term.c (x_set_glyph_string_clipping):
1495 Don't pass uninitialized region to CombineRgn.
1496
9c88f339
JB
14972011-03-23 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1500 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1501 (Fx_close_connection): Remove unused variable `i'.
1502
1503 * w32font.c (w32font_draw): Return number of glyphs.
1504 (w32font_open_internal): Remove unused variable `i'.
1505 (w32font_driver): Add missing initializer.
1506
1507 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1508 (fill_in_menu): Remove unused variable `items_added'.
1509
1510 * w32term.c (last_mouse_press_frame): Remove static global variable.
1511 (w32_clip_to_row): Remove unused variable `f'.
1512 (x_delete_terminal): Remove unused variable `i'.
1513
1514 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1515 (NOTHING): Remove unused static global variable.
1516 (uniscribe_check_otf): Remove unused variable `table'.
1517 (uniscribe_font_driver): Add missing initializers.
1518
dee091a3
JD
15192011-03-23 Julien Danjou <julien@danjou.info>
1520
1521 * term.c (Fsuspend_tty, Fresume_tty):
1522 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1523 * window.c (temp_output_buffer_show):
1524 * insdel.c (signal_before_change):
1525 * frame.c (Fhandle_switch_frame):
1526 * fileio.c (Fdo_auto_save):
1527 * emacs.c (Fkill_emacs):
1528 * editfns.c (save_excursion_restore):
1529 * cmds.c (internal_self_insert):
1530 * callint.c (Fcall_interactively):
1531 * buffer.c (Fkill_all_local_variables):
1532 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1533 Use Frun_hooks.
0f4a96b5 1534 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1535 unconditionnaly since it does the check itself.
1536
2c520ab5 15372011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1538
c9c49752
PE
1539 Fix more problems found by GCC 4.5.2's static checks.
1540
8abc3f12
PE
1541 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1542 the first time through the loop, since we know p0 < p1 then.
1543 This also avoids a gcc -Wstrict-overflow warning.
1544
a2d26660
PE
1545 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1546 leading to a memory leak, possible in functions like
1547 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1548 of objects (Bug#8318).
a2d26660 1549
916c72e9
PE
1550 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1551 that could (at least in theory) be that large.
1552
19ab8a18
PE
1553 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1554 This is less likely to overflow, and avoids undefined behavior if
1555 overflow does occur. All callers changed. Use strtoul to scan
1556 for the unsigned long integer.
b7cbbd6f
PE
1557 (pint2hrstr): Simplify and tune code slightly.
1558 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1559
f0641eff
PE
1560 * scroll.c (do_scrolling): Work around GCC bug 48228.
1561 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1562
7f650bb9
PE
1563 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1564 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1565 (validate_x_resource_name): Simplify count usage.
1566 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1567
37dd57d1
PE
1568 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1569 fail (Bug#8306).
81e56e61 1570
699979fc 1571 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1572
401bf9b4
PE
1573 * process.c (Fmake_network_process): Use socklen_t, not int,
1574 where POSIX says socklen_t is required in portable programs.
1575 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1576 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1577 (Fmake_network_process, server_accept_connection):
1578 (wait_reading_process_output, read_process_output):
1579 Likewise.
1580
b93aacde
PE
1581 * process.c: Rename or move locals to avoid shadowing.
1582 (list_processes_1, Fmake_network_process):
1583 (read_process_output_error_handler, exec_sentinel_error_handler):
1584 Rename or move locals.
4dc343ee 1585 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1586 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1587 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1588 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1589 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1590
af8a867c 1591 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1592 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1593 Include tparam.h instead, since it declares them.
af8a867c
PE
1594 * cm.h (PC): Remove extern decl; tparam.h now does this.
1595 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1596 * terminfo.c: Include tparam.h, to check interfaces.
1597 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1598 (tparam): Adjust signature to match interface in tparam.h;
1599 this removes some undefined behavior. Check that outstring and len
1600 are zero, which they always are with Emacs.
1601 * tparam.h (PC, BC, UP): New extern decls.
1602
0248044d 1603 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1604 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1605
8ff096c1 1606 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1607 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1608 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1609 (ftfont_list): Remove unused local.
49eaafba
PE
1610 (get_adstyle_property, ftfont_pattern_entity):
1611 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1612 Rename locals to avoid shadowing.
8ff096c1 1613
e2be39f6
PE
1614 * xfont.c (xfont_list_family): Mark var as initialized.
1615
c9735e30
PE
1616 * xml.c (make_dom): Now static.
1617
8f5201ae
PE
1618 * composite.c (composition_compute_stop_pos): Rename local to
1619 avoid shadowing.
b246f932
PE
1620 (composition_reseat_it): Remove unused locals.
1621 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1622 (composition_update_it): Mark var as initialized.
11b61122
PE
1623 (find_automatic_composition): Mark vars as initialized,
1624 with a FIXME (Bug#8290).
8f5201ae 1625
760fbc2c
PE
1626 character.h: Rename locals to avoid shadowing.
1627 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1628 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1629 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1630 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1631 to avoid shadowing.
1632
ff08eb85
PE
1633 * textprop.c (property_change_between_p): Remove; unused.
1634
fc7bf025
PE
1635 * intervals.c (interval_start_pos): Now static.
1636
235d7abc
PE
1637 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1638
44f230aa
SM
1639 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1640 Rename locals to avoid shadowing.
3e7d6594 1641
50060332
PE
1642 * sound.c (wav_play, au_play, Fplay_sound_internal):
1643 Fix pointer signedness.
d01f234b 1644 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1645 (wav_play): Initialize a variable to 0, to prevent undefined
1646 behavior (Bug#8278).
50060332 1647
c4fc4e30
PE
1648 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1649
918436ed
PE
1650 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1651
c939f91b
PE
1652 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1653 clobbering (Bug#8298).
b9c7f648
PE
1654 * sysdep.c (sys_subshell): Likewise.
1655 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1656
6bd8c144
PE
1657 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1658 This should get cleaned up, so that child_setup has the
1659 same signature on all platforms.
1660
7710357c 1661 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1662 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1663
c59da222
CY
16642011-03-22 Chong Yidong <cyd@stupidchicken.com>
1665
1666 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1667 not to be necessary, and produces flickering.
1668
66b87493
GM
16692011-03-20 Glenn Morris <rgm@gnu.org>
1670
1671 * config.in: Remove file.
1672
45b6f6d5
JB
16732011-03-20 Juanma Barranquero <lekktu@gmail.com>
1674
1675 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1676 are now in src/globals.h.
1677 (syms_of_minibuf): Remove spurious & from previous change.
1678
3ec03f7e
LL
16792011-03-20 Leo <sdl.web@gmail.com>
1680
1681 * minibuf.c (completing-read-function): New variable.
1682 (completing-read-default): Rename from completing-read.
1683 (completing-read): Call completing-read-function.
1684
b14e3e21
CY
16852011-03-19 Juanma Barranquero <lekktu@gmail.com>
1686
1687 * xfaces.c (Fx_load_color_file):
1688 Read color file from absolute filename (bug#8250).
1689
f2b726e6
JB
16902011-03-19 Juanma Barranquero <lekktu@gmail.com>
1691
1692 * makefile.w32-in: Update dependencies.
1693
09f6ff02
EZ
16942011-03-17 Eli Zaretskii <eliz@gnu.org>
1695
1696 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1697
29a6015a
PE
16982011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1699
a3a6c54e
PE
1700 Fix more problems found by GCC 4.5.2's static checks.
1701
b766f867
PE
1702 * process.c (make_serial_process_unwind, send_process_trap):
1703 (sigchld_handler): Now static.
1704
be02381c
PE
1705 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1706 That way, the code declares only the vars that it needs.
1707 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1708 * s/cygwin.h (PTY_ITERATION): Likewise.
1709 * s/darwin.h (PTY_ITERATION): Likewise.
1710 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1711
57048744
PE
1712 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1713 * process.c (allocate_pty): Don't declare stb unless it's needed.
1714
7914961c 1715 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1716 (CONSTANTLIM): Remove; unused.
1717 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1718 Define only if needed.
7914961c 1719
b3967b18
PE
1720 * unexelf.c (unexec): Name an expression,
1721 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1722 Use a different way to cause a compilation error if anyone uses
1723 n rather than nn, a way that does not involve shadowing.
73366a00 1724 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1725
29a6015a
PE
1726 * deps.mk (unexalpha.o): Remove; unused.
1727
43cfc33e 1728 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1729 * unexec.h: New file.
ce701a33
PE
1730 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1731 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1732 Depend on unexec.h.
1733 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1734 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1735 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1736 Change as necessary to match prototype in unexec.h.
ce701a33 1737
01f44d5a
PE
1738 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1739 shadowing.
4f63c6bb 1740 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1741
a6670b0b
PE
1742 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1743 Rename locals to avoid shadowing.
1744
cef2010d 1745 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1746 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1747
d4d7173a
PE
1748 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1749
f08b802a
PE
1750 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1751 warning when compiling print.c.
1752
3ddb0639
PE
1753 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1754 instead of using an uninitialized var.
5ad03b97 1755 (font_sort_entities): Mark var as initialized.
3ddb0639 1756
170a2692
PE
1757 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1758
e663c700
PE
1759 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1760 pointers to constants.
89bc529a 1761 (font_parse_fcname): Remove unused vars.
7b81e2d0 1762 (font_delete_unmatched): Now static.
ea838e10 1763 (font_get_spec): Remove; unused.
13a547c6
PE
1764 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1765 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1766 Rename or move locals to avoid shadowing.
e663c700 1767
2a80c887 1768 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1769 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1770
1384fa33 1771 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1772 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1773
8b2c52e9
PE
1774 * alloc.c (mark_backtrace): Move decl from here ...
1775 * lisp.h: ... to here, so that it can be checked.
1776
475545b5 1777 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1778 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1779 (lisp_indirect_variable): Name an expression,
1780 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1781 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1782
b1349114 1783 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1784 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1785 Use const pointer when appropriate.
b1349114 1786
a2928364
PE
1787 * lisp.h (get_system_name, get_operating_system_release):
1788 Move decls here, to check interfaces.
1789 * process.c (get_operating_system_release): Move decl to lisp.h.
1790 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1791 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1792 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1793 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1794 (Fformat_time_string, Fencode_time, Finsert_char):
1795 (Ftranslate_region_internal, Fformat):
1796 Rename or remove local vars to avoid shadowing.
9710023e 1797 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1798
a415e694
PE
1799 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1800 avoid shadowing.
1801
8ef4622d
PE
1802 * lisp.h (eassert): Check that the argument compiles, even if
1803 ENABLE_CHECKING is not defined.
1804
946f9a5b
PE
1805 * data.c (Findirect_variable): Name an expression, to avoid
1806 gcc -Wbad-function-cast warning.
112396d6 1807 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1808 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1809 (Fmake_variable_buffer_local, Fmake_local_variable):
1810 Mark variables as initialized.
52746918 1811 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1812
e5aab7e7 1813 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1814 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1815 Rename locals to avoid shadowing.
dff45157
PE
1816 (mark_stack): Move local variables into the #ifdef region where
1817 they're used.
7bc26fdb
PE
1818 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1819 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1820 needed otherwise.
1821 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1822 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1823 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1824
e5aab7e7
PE
1825 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1826 avoids undefined behavior in theory.
1827
4da60324
PE
1828 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1829
88043301
PE
1830 Use functions, not macros, for up- and down-casing (Bug#8254).
1831 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1832 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1833 to use the following functions instead of these macros.
1834 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1835 EMACS_INT, since callers assume the returned value fits in int.
1836 (upcase1): Likewise, for UPCASE_TABLE.
1837 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1838 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1839 the race-condition problem in the old DOWNCASE.
88043301 1840
19ed5445
PE
1841 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1842 Rename locals to avoid shadowing.
1843 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1844 (regex_compile, re_search_2, re_match_2_internal):
1845 Remove unused local vars.
952db0d7
PE
1846 (FREE_VAR): Rewrite so as not to use empty "else",
1847 which gcc can warn about.
da053e48 1848 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1849 (RETALLOC_IF): Define only if needed.
1850 (WORDCHAR_P): Likewise. This one is never needed, but is used
1851 only in a comment talking about a compiler bug, so put inside
1852 the #if 0 of that comment.
1853 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1854 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1855 Remove; unused.
19ed5445 1856
1f3561e4 1857 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1858 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1859 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1860
ded6f8f7
PE
1861 * search.c (simple_search): Remove unused var.
1862
dbd37a95
PE
1863 * dired.c (compile_pattern): Move decl from here ...
1864 * lisp.h: ... to here, so that it can be checked.
1865 (struct re_registers): New forward decl.
1866
7e47afad
PE
1867 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1868
85f24f61
PE
1869 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1870 All uses changed.
1871 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1872 Rename locals to avoid shadowing.
5671df8f 1873 (Fvertical_motion): Mark locals as initialized.
85f24f61 1874
181aa2be 1875 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1876 (casify_region): Mark local as initialized.
181aa2be 1877
930d429c
PE
1878 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1879
7082eac6
PE
1880 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1881 New macros, so that the caller can use some names other than
1882 gcpro1, gcpro2, etc.
1883 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1884 of the new macros.
1885 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1886 argument, for consistency with GCPRO2_VAR, etc: it is now the
1887 prefix of the variable, not the variable itself. All uses
1888 changed.
38b2c076
PE
1889 * dired.c (directory_files_internal, file_name_completion):
1890 Rename locals to avoid shadowing.
1891
15206ed9
PE
1892 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1893 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1894 dired.c's scmp function, had undefined behavior.
1895 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1896 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1897 * buffer.h: ... to here, because these macros use current_buffer,
1898 and the new implementation with inline functions needs to have
1899 current_buffer in scope now, rather than later when the macros
1900 are used.
1901 (downcase, upcase1): New static inline functions.
1902 (DOWNCASE, UPCASE1): Reimplement using these functions.
1903 This avoids undefined behavior in expressions like
1904 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1905 from race conditions in accessing the global variables
1906 case_temp1 and case_temp2.
1907 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1908 * lisp.h (case_temp1, case_temp2): Remove their decls.
1909 * character.h (ASCII_CHAR_P): Move from here ...
1910 * lisp.h: ... to here, so that the inline functions mentioned
1911 above can use them.
1912
4a6bea26
PE
1913 * dired.c (directory_files_internal_unwind): Now static.
1914
f14b7e14
PE
1915 * fileio.c (file_name_as_directory, directory_file_name):
1916 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1917 Now static.
2893f146
PE
1918 (file_name_as_directory): Use const pointers when appropriate.
1919 (Fexpand_file_name): Likewise. In particular, newdir might
1920 point at constant storage, so make it a const pointer.
fd4ead52 1921 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1922 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1923 signedness issues.
f839df0c
PE
1924 (Fset_file_times, Finsert_file_contents, auto_save_error):
1925 Rename locals to avoid shadowing.
f14b7e14 1926
5716756e 1927 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1928 (Ftry_completion, Fall_completions): Rename or remove locals
1929 to avoid shadowing.
5716756e 1930
b4c3046a
PE
1931 * marker.c (bytepos_to_charpos): Remove; unused.
1932
b45db522
PE
1933 * lisp.h (verify_bytepos, count_markers): New decls,
1934 so that gcc does not warn that these functions aren't declared.
1935
85876d07
PE
1936 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1937 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1938 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1939 (copy_text): Remove unused local var.
85876d07 1940
03d78a21 1941 * filelock.c (within_one_second): Now static.
b3dd38ab 1942 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1943
5df8f01b
PE
1944 * buffer.c (fix_overlays_before): Mark locals as initialized.
1945 (fix_start_end_in_overlays): Likewise. This function should be
1946 simplified by using pointers-to-pointers, but that's a different
1947 matter.
b1d876f1 1948 (switch_to_buffer_1): Now static.
8f54f30a
PE
1949 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1950 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1951
a70072c9 1952 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1953 Fix pointer signedness issue.
edced198
PE
1954 (sys_subshell): Mark local as volatile if checking for lint,
1955 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1956 (MAXPATHLEN): Define only if needed.
a70072c9 1957
a0977c44
PE
1958 * process.c (serial_open, serial_configure): Move decls from here ...
1959 * systty.h: ... to here, so that they can be checked.
1960
a884fdcc
PE
1961 * fns.c (get_random, seed_random): Move extern decls from here ...
1962 * lisp.h: ... to here, so that they can be checked.
1963
604efe86 1964 * sysdep.c (reset_io): Now static.
b8950c94 1965 (wait_for_termination_signal): Remove; unused.
604efe86 1966
38fc62d9
PE
1967 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1968 (copy_keymap_item, append_key, push_text_char_description):
1969 Now static.
1004a21a 1970 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1971 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1972 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1973 (describe_map_tree):
1974 Rename locals to avoid shadowing.
38fc62d9 1975
2f2650da
PE
1976 * keyboard.c: Declare functions static if they are not used elsewhere.
1977 (echo_char, echo_dash, cmd_error, top_level_2):
1978 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1979 (read_char, kbd_buffer_get_event, make_lispy_position):
1980 (make_lispy_event, make_lispy_movement, apply_modifiers):
1981 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1982 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1983 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1984 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1985 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1986
a053e86c 1987 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1988 (mark_kboards): Move decl here ...
1989 * alloc.c (mark_kboards): ... from here.
a053e86c 1990
4752793e
PE
1991 * lisp.h (force_auto_save_soon): New decl.
1992
74f10ca7 1993 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1994 (DEFINE_DUMMY_FUNCTION): New macro.
1995 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1996 Use it.
c03cd23f
PE
1997 (main): Add casts to avoid warnings
1998 if GCC considers string literals to be constants.
74f10ca7 1999
022e70d4
PE
2000 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2001
59d6fe83
PE
2002 * dbusbind.c: Pointer signedness fixes.
2003 (xd_signature, xd_append_arg, xd_initialize):
2004 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2005 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2006 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2007 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2008
78320123
PE
2009 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2010 if GCC considers string literals to be constants.
49cebcca 2011 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2012
35ac2a97
SM
20132011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2014
fb103ca9
SM
2015 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2016 (print_preprocess, print_object): New macro to fix last change.
2017
35ac2a97
SM
2018 * print.c (print_preprocess): Don't forget font objects.
2019
62973b41
JB
20202011-03-16 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * emacs.c (USAGE3): Doc fixes.
2023
0e48bb22
AS
20242011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2025
2026 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2027 structure.
2028
7684e57b
JB
20292011-03-14 Juanma Barranquero <lekktu@gmail.com>
2030
2031 * lisp.h (VWindow_system, Qfile_name_history):
2032 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2033 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2034 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2035
2036 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2037 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2038
2039 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2040 * w32console.c (detect_input_pending, read_input_pending)
2041 (encode_terminal_code):
2042 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2043 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2044 (w32_system_caret_y, Qfile_name_history):
2045 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2046 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2047 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2048 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2049 * w32proc.c (Qlocal, report_file_error):
2050 * w32term.c (Vwindow_system, updating_frame):
2051 * w32uniscribe.c (initialized, uniscribe_font_driver):
2052 Remove unneeded extern declarations.
2053
2aa46d6c
CY
20542011-03-14 Chong Yidong <cyd@stupidchicken.com>
2055
c96bbc66 2056 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2057
cffc6f3b
CY
20582011-03-13 Chong Yidong <cyd@stupidchicken.com>
2059
2060 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2061 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2062 These macros can no longer be used for assignment.
2063
44f230aa
SM
2064 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2065 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2066 (record_buffer_markers, fetch_buffer_markers): New functions for
2067 recording and fetching special buffer markers.
2068 (set_buffer_internal_1, set_buffer_temp): Use them.
2069
2070 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2071
2072 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2073
2074 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2075 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2076
2077 * xdisp.c (hscroll_window_tree):
2078 (reconsider_clip_changes): Use PT instead of BUF_PT.
2079
d251f04b
EZ
20802011-03-13 Eli Zaretskii <eliz@gnu.org>
2081
2082 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2083 $(EMACS_ROOT)/lib/intprops.h.
2084
f0c77cd1
PE
20852011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2086
3eca4629
PE
2087 Fix more problems found by GCC 4.5.2's static checks.
2088
7c86ee98
PE
2089 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2090 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2091 (xg_free_frame_widgets): Make it clear that a local variable is
2092 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2093 (gdk_window_get_screen): Make it clear that this macro is needed
2094 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2095 (int_gtk_range_get_value): New function, which avoids a diagnostic
2096 from gcc -Wbad-function-cast.
2097 (xg_set_toolkit_scroll_bar_thumb): Use it.
2098 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2099 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2100 (get_utf8_string, xg_get_file_with_chooser):
2101 Rename locals to avoid shadowing.
2102 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2103
41729b81
PE
2104 * xgselect.c (xg_select): Remove unused var.
2105
f0c77cd1
PE
2106 * image.c (four_corners_best): Mark locals as initialized.
2107 (gif_load): Initialize transparent_p to zero (Bug#8238).
2108 Mark another local as initialized.
ec6cf4c6 2109 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2110
ce0ad53d 2111 * image.c (clear_image_cache): Now static.
d5d5a617 2112 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2113 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2114 (x_edge_detection): Remove unnecessary cast that
2115 gcc -Wbad-function-cast diagnoses.
2037898d 2116 (gif_load): Fix pointer signedness.
6ae141d6
PE
2117 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2118 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2119
33383987 21202011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2121
d32df629
PE
2122 Improve quality of tests for time stamp overflow.
2123 For example, without this patch (encode-time 0 0 0 1 1
2124 1152921504606846976) returns the obviously-bogus value (-948597
2125 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2126 reports time overflow. See
2127 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2128 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2129 * editfns.c: Include limits.h and intprops.h.
2130 (TIME_T_MIN, TIME_T_MAX): New macros.
2131 (time_overflow): Move earlier, to before first use.
2132 (hi_time, lo_time): New functions, for an accurate test for
2133 out-of-range times.
2134 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2135 (Fget_internal_run_time): Don't assume time_t fits in int.
2136 (make_time): Use list2 instead of Fcons twice.
2137 (Fdecode_time): More accurate test for out-of-range times.
2138 (check_tm_member): New function.
2139 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2140 (lisp_time_argument): Don't rely on undefined left-shift and
2141 right-shift behavior when checking for time stamp overflow.
8be6f318 2142
fe31d94c
PE
2143 * editfns.c (time_overflow): New function, refactoring common code.
2144 (Fformat_time_string, Fdecode_time, Fencode_time):
2145 (Fcurrent_time_string): Use it.
2146
8be6f318
PE
2147 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2148 * dired.c (make_time): Move to ...
2149 * editfns.c (make_time): ... here.
2150 * systime.h: Note the move.
2151
09d9db2c 21522011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2153
126bc0dc
YM
2154 * fringe.c (update_window_fringes): Remove unused variables.
2155
c47cbdfd
YM
2156 * unexmacosx.c (copy_data_segment): Also copy __got section.
2157 (Bug#8223)
2158
7ac80be9
EZ
21592011-03-12 Eli Zaretskii <eliz@gnu.org>
2160
c96bbc66 2161 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2162 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2163 Constify `char *' arguments and their references according to
2164 prototypes in tparam.h.
2165
ecb0f94d 2166 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2167
7ac80be9
EZ
2168 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2169 Adapt all references accordingly.
2170
2171 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2172
ef1fd07e
TT
21732011-03-11 Tom Tromey <tromey@redhat.com>
2174
2175 * buffer.c (syms_of_buffer): Remove obsolete comment.
2176
7ef4b50c
EZ
21772011-03-11 Eli Zaretskii <eliz@gnu.org>
2178
2179 * termhooks.h (encode_terminal_code): Declare prototype.
2180
2181 * msdos.c (encode_terminal_code): Don't declare prototype.
2182
2183 * term.c (encode_terminal_code): Now external again, used by
2184 w32console.c and msdos.c.
2185
44f230aa
SM
2186 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2187 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2188
4b1ec863 21892011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2190
1714f52b 2191 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2192
4b1ec863
PE
2193 * fringe.c (update_window_fringes): Mark locals as initialized
2194 (Bug#8227).
2195 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2196
524c7aa6
PE
2197 * alloc.c (mark_fringe_data): Move decl from here ...
2198 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2199 to check its interface.
2200 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2201
a5c0af81 2202 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2203 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2204 (fontset_font): Mark local as initialized.
a9a06e0b 2205 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2206
b4716021
PE
2207 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2208
811e9bac 2209 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2210 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2211 (x_own_selection, Fx_disown_selection_internal): Rename locals
2212 to avoid shadowing.
2213 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2214
7e3ab302
PE
2215 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2216 so that the caller can use some name other than gcpro1.
2217 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2218 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2219 (Fx_backspace_delete_keys_p):
2220 Use them to avoid shadowing, and rename vars to avoid shadowing.
2221 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2222 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2223 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2224 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2225 Remove unused locals.
7e3ab302
PE
2226 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2227 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2228 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2229 macros.
f78faa98 2230
e2b13473
PE
2231 * xterm.h (x_mouse_leave): New decl.
2232
77f23912
PE
2233 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2234 Remove unused functions.
cdf4ba58
PE
2235 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2236 (x_calc_absolute_position): Now static.
7411c686 2237 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2238 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2239 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2240 unless they are used.
38d0b34a
PE
2241 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2242 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2243 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2244 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2245 (x_error_catcher, x_connection_closed, x_error_handler):
2246 (x_error_quitter, xembed_send_message, x_iconify_frame):
2247 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2248 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2249 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2250
44f230aa
SM
2251 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2252 Rename or move locals to avoid shadowing.
6b463e58 2253 (tty_defined_color, merge_face_heights): Now static.
5967d051 2254 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2255 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2256 does not deduce is never used uninitialized.
73719eba
PE
2257 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2258 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2259
426994c3 2260 * terminal.c (store_terminal_param): Now static.
5489860b 2261
032f1620 2262 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2263 (set_frame_menubar): Remove unused local.
d4323972 2264 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2265 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2266 since they might point to immutable storage.
281585b0
PE
2267 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2268 since it's unused otherwise.
032f1620 2269
367c19e5 2270 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2271 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2272 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2273 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2274 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2275 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2276 does not deduce are never used uninitialized.
70739cbe 2277
07b48fa9
PE
2278 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2279
8868a238 2280 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2281 * window.c (window_loop, size_window):
2282 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2283
7e5cf297 2284 * window.c (display_buffer): Now static.
d6550a9f
PE
2285 (size_window): Mark variables that gcc -Wuninitialized
2286 does not deduce are never used uninitialized.
a586633d
PE
2287 * window.h (check_all_windows): New decl, to forestall
2288 gcc -Wmissing-prototypes diagnostic.
5b555da1 2289 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2290
f6095868
PE
2291 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2292 shadowing.
2293 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2294 Include <limits.h>.
2295 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2296 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2297 (load_charset_map): Mark variables that gcc -Wuninitialized
2298 does not deduce are never used uninitialized.
53df7c11 2299 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2300
f38b440c
PE
2301 * coding.c (coding_set_source, coding_set_destination):
2302 Use "else { /* comment */ }" rather than "else /* comment */;"
2303 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2304 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2305 a block, when the outer 'i' will do.
2306 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2307 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2308 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2309 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2310 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2311 Rename locals to avoid shadowing.
2312 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2313 * coding.c (emacs_mule_char, encode_invocation_designation):
2314 Now static, since they're not used elsewhere.
413bb2db 2315 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2316 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2317 (decode_coding_emacs_mule): Mark variables that gcc
2318 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2319 (detect_coding_iso_2022): Initialize a local variable that might
2320 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2321 this initialization is needed. (Bug#8211)
5f58e762
PE
2322 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2323 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2324 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2325 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2326 Remove unused macros.
f38b440c 2327
232b38b9 2328 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2329 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2330 * character.c (string_count_byte8): Likewise.
232b38b9 2331
fb90da1b
PE
2332 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2333 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2334
fb93dbc2
PE
2335 * chartab.c (copy_sub_char_table): Now static, since it's not used
2336 elsewhere.
5c156ace
PE
2337 (sub_char_table_ref_and_range, char_table_ref_and_range):
2338 Rename locals to avoid shadowing.
bbcd0949 2339 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2340
7d3b3862 2341 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2342 (BIDI_BOB): Remove unused macro.
7d3b3862 2343
6be7d3da
PE
2344 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2345 deduce are never used uninitialized.
c2ed9c8b 2346 * term.c (encode_terminal_code): Likewise.
6be7d3da 2347
75f8807f 2348 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2349
50938595
PE
2350 * tparam.h: New file.
2351 * term.c, tparam.h: Include it.
2352 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2353 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2354 Move these decls to tparam.h, and make them agree with what
2355 is actually in tparam.c. The previous trick of using incompatible
2356 decls in different modules does not conform to the C standard.
2357 All callers of tparam changed to use tparam's actual API.
2358 * tparam.c (tparam1, tparam, tgoto):
2359 Use const pointers where appropriate.
2360
fbceeba2
PE
2361 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2362 * cm.h (struct cm): Likewise.
2363 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2364 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2365 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2366 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2367 (turn_on_face, init_tty): Likewise.
2368 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2369
7f3f1250
PE
2370 * term.c (term_mouse_position): Rename local to avoid shadowing.
2371
e6ca6543
PE
2372 * alloc.c (mark_ttys): Move decl from here ...
2373 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2374
c40f8d15
AS
23752011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2376
2377 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2378
cfe0661d
JB
23792011-03-09 Juanma Barranquero <lekktu@gmail.com>
2380
2381 * search.c (compile_pattern_1): Remove argument regp, unused since
2382 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2383 (compile_pattern): Don't pass it.
2384
0afb4571
J
23852011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2386
2387 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2388 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2389 for ! HAVE_GTK3.
2390 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2391
2392 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2393
2394 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2395 gdk_window_get_screen, gdk_window_get_geometry,
2396 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2397 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2398 (xg_get_pixbuf_from_pixmap): New function.
2399 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2400 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2401 Call xg_get_pixbuf_from_pixmap instead of
2402 gdk_pixbuf_get_from_drawable.
2403 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2404 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2405 (xg_check_special_colors): Use GtkStyleContext and its functions
2406 for HAVE_GTK3.
2407 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2408 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2409 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2410 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2411 Call gtk_widget_get_preferred_size.
0afb4571
J
2412 (xg_frame_resized): gdk_window_get_geometry only takes 5
2413 parameters.
44f230aa
SM
2414 (xg_win_to_widget, xg_event_is_for_menubar):
2415 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2416 (xg_set_widget_bg): New function.
2417 (delete_cb): New function.
2418 (xg_create_frame_widgets): connect delete-event to delete_cb.
2419 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2420 (xg_set_background_color): Call xg_set_widget_bg.
2421 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2422 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2423 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2424 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2425 if ! HAVE_GTK3.
2426 (update_frame_tool_bar): Call gtk_widget_hide.
2427 (xg_initialize): Use GDK_KEY_g.
2428
2429 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2430 if ! HAVE_GTK3
2431 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2432
2433 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2434 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2435 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2436
1c2cc4ef
JB
24372011-03-08 Juanma Barranquero <lekktu@gmail.com>
2438
2439 * w32xfns.c (select_palette): Check success of RealizePalette against
2440 GDI_ERROR, not zero.
2441
33383987 2442See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2443
2444;; Local Variables:
2445;; coding: utf-8
aac0c6e3
MR
2446;; End:
2447
33383987 2448 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2449
2450 This file is part of GNU Emacs.
2451
2452 GNU Emacs is free software: you can redistribute it and/or modify
2453 it under the terms of the GNU General Public License as published by
2454 the Free Software Foundation, either version 3 of the License, or
2455 (at your option) any later version.
2456
2457 GNU Emacs is distributed in the hope that it will be useful,
2458 but WITHOUT ANY WARRANTY; without even the implied warranty of
2459 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2460 GNU General Public License for more details.
2461
2462 You should have received a copy of the GNU General Public License
2463 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.