Add a bug number to a ChangeLog entry.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
76470ad1
KH
12011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2
3 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5
745fff94
KH
62011-12-08 Kenichi Handa <handa@m17n.org>
7
8 * ftfont.c (get_adstyle_property): Fix previous change
9 (Bug#10233).
10
6e44397c
JB
112011-12-07 Juanma Barranquero <lekktu@gmail.com>
12
13 * w32.c (init_environment): If no_site_lisp, remove site-lisp
14 dirs from the default value of EMACSLOADPATH (bug#10208).
15
7efa6272
GM
162011-12-07 Glenn Morris <rgm@gnu.org>
17
18 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
19 installation and source directories as well. (Bug#10208)
20
f6fc4d87
CY
212011-12-06 Chong Yidong <cyd@gnu.org>
22
23 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
24
2bf26180
GM
252011-12-06 Glenn Morris <rgm@gnu.org>
26
27 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
28 as an error, not just -1. (Bug#10217)
29
3a6ad4f0
CY
302011-12-05 Chong Yidong <cyd@gnu.org>
31
32 * keyboard.c (process_special_events): New function.
33 (swallow_events, Finput_pending_p): Use it (Bug#10195).
34
75a3b399
PE
352011-12-05 Paul Eggert <eggert@cs.ucla.edu>
36
37 * coding.c (encode_designation_at_bol): Don't use uninitialized
38 local variable (Bug#9318).
39
c3c9e25e
KH
402011-12-05 Kenichi Handa <handa@m17n.org>
41
42 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
43 return Qnil (Bug#8046, Bug#10193).
44
5eb05ea3
KH
452011-12-05 Kenichi Handa <handa@m17n.org>
46
47 * coding.c (encode_designation_at_bol): New args charbuf_end and
48 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
49 (coding_set_source): Return how many bytes coding->source was
50 relocated.
51 (coding_set_destination): Return how many bytes
52 coding->destination was relocated.
53 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
54 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
55
562011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
57
58 * coding.c (CODING_CHAR_CHARSET_P): New macro.
59 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
60 macro (Bug#9318).
61
622011-12-05 Andreas Schwab <schwab@linux-m68k.org>
63
64 The following changes are to fix Bug#9318.
65
a79703f5 66 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
67 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
68 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 69 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 70
7dbda6df
JB
712011-12-05 Juanma Barranquero <lekktu@gmail.com>
72
73 * lisp.h (process_quit_flag): Fix external declaration.
74
6d5eb5b0
SM
752011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
76
77 Don't macro-inline non-performance-critical code.
78 * eval.c (process_quit_flag): New function.
79 * lisp.h (QUIT): Use it.
80
a0c3fad0
JD
812011-12-04 Jan Djärv <jan.h.d@swipnet.se>
82
83 * nsfns.m (get_geometry_from_preferences): New function.
84 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
85
6c07aac2
AS
862011-12-04 Andreas Schwab <schwab@linux-m68k.org>
87
88 * emacs.c (Qkill_emacs): Define.
89 (syms_of_emacs): Initialize it.
90 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
91 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
92 (quit_throw_to_read_char): Add parameter `from_signal'.
93 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
94 * lisp.h (QUIT): Call Fkill_emacs if requested.
95
c052ead4
JD
962011-12-03 Jan Djärv <jan.h.d@swipnet.se>
97
98 * widget.c (update_wm_hints): Return if wmshell is null.
99 (widget_update_wm_size_hints): New function.
100
101 * widget.h (widget_update_wm_size_hints): Declare.
102
103 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
104 widget_update_wm_size_hints (Bug#10104).
105
9e49252b
EZ
1062011-12-03 Eli Zaretskii <eliz@gnu.org>
107
108 * xdisp.c (handle_invisible_prop): If the invisible text ends just
109 before a newline, prepare the bidi iterator for consuming the
110 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 111 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 112
02b16839
JL
1132011-12-02 Juri Linkov <juri@jurta.org>
114
115 * search.c (Fword_search_regexp): New Lisp function created from
116 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
117 (Fword_search_backward, Fword_search_forward)
118 (Fword_search_backward_lax, Fword_search_forward_lax):
119 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
120 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
121
0068070e
SM
1222011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
123
124 * fileio.c (Finsert_file_contents): Move after-change-function call
125 to before the "handled:" label, since all "goto handled" appear in
126 cases where the *-change-functions have already been properly called
127 (bug#10117).
128
3360a3fc
AS
1292011-12-01 Andreas Schwab <schwab@linux-m68k.org>
130
131 * keyboard.c (interrupt_signal): Don't call kill-emacs when
132 waiting for input. (Bug#10169)
133
73d6c093
EZ
1342011-11-30 Eli Zaretskii <eliz@gnu.org>
135
136 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
137 verifies glyph row's hash code--we have just reallocated the
138 glyphs, so their contents can be complete garbage. (Bug#10164)
139
febe6bea
JB
1402011-11-30 Juanma Barranquero <lekktu@gmail.com>
141
142 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
143
801a4313
EZ
1442011-11-30 Eli Zaretskii <eliz@gnu.org>
145
146 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
147 attributes are tested _before_ calling verify_row_hash, to protect
148 against GCC re-ordering of the tests. (Bug#10164)
149
2b56b87e
JD
1502011-11-29 Jan Djärv <jan.h.d@swipnet.se>
151
152 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
153
154 * xterm.c (handle_one_xevent): Only set async_visible and friends
155 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 156 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
157 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
158
dbf31225
PE
1592011-11-28 Paul Eggert <eggert@cs.ucla.edu>
160
161 Remove GCPRO-related macros that exist only to avoid shadowing locals.
162 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
163 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
164 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
165 All uses changed to use GCPRO1 etc.
166 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
167 Revert to old implementation (i.e., before 2011-03-11).
168
1305621b
YM
1692011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
170
171 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
172 of scroll runs so as to avoid assigning disabled bogus rows and
173 unnecessary graphics copy operations.
174
8c9afb46
EZ
1752011-11-27 Eli Zaretskii <eliz@gnu.org>
176
177 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
178 (snprintf) [_MSC_VER]: Redirect to _snprintf.
179 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
180 (malloc, free, realloc, calloc): Redirect to e_* only when
181 compiling Emacs.
182
183 * lisp.h (GCTYPEBITS): Move before first use.
184 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
185 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
186 this macro definition.
187
188 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
189 _MSC_VER.
190
54e9e3bf
JD
1912011-11-27 Jan Djärv <jan.h.d@swipnet.se>
192
6d5eb5b0
SM
193 * gtkutil.c (xg_create_frame_widgets):
194 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
195 present with Gtk+ 2.0.
196
83aca1cb
PE
1972011-11-26 Paul Eggert <eggert@cs.ucla.edu>
198
199 * fileio.c (Finsert_file_contents): Undo previous change; see
200 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
201
5b76caa4
PE
2022011-11-26 Paul Eggert <eggert@cs.ucla.edu>
203
204 Rename locals to avoid shadowing.
205 * fileio.c (Finsert_file_contents):
206 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
207 * process.c (wait_reading_process_output):
208 Rename inner 'proc' to 'p' to avoid shadowing.
209 Indent for consistency with usual Emacs style.
210
8c535114
EZ
2112011-11-25 Eli Zaretskii <eliz@gnu.org>
212
213 * xdisp.c (redisplay_window): If cursor row is not fully visible
214 after recentering, and scroll-conservatively is set to a large
215 number, scroll window by a few more lines to make the cursor fully
216 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
217 (start_display): Don't move to the next line if the display should
218 start at a newline that is part of a display vector or an overlay
219 string. (Bug#10119)
8c535114 220
fa4fdb5c
JL
2212011-11-24 Juri Linkov <juri@jurta.org>
222
223 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
224 after the `MagickPingImage' call. (Bug#10112)
225
90ec88df
CY
2262011-11-23 Chong Yidong <cyd@gnu.org>
227
228 * window.c (Fcoordinates_in_window_p): Accept only live windows.
229
56e2e794
MR
2302011-11-23 Martin Rudalics <rudalics@gmx.at>
231
232 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
233 making another buffer current. (Bug#10114)
234
b6e64c41
GM
2352011-11-23 Glenn Morris <rgm@gnu.org>
236
237 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
238
6b21de18
CY
2392011-11-23 Chong Yidong <cyd@gnu.org>
240
241 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
242 using it (Bug#5984).
243
b12cd789
EZ
2442011-11-22 Eli Zaretskii <eliz@gnu.org>
245
246 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
247 and header-lines, as they don't have one computed for them.
248 (Bug#10098)
249
250 * .gdbinit (prow): Make displayed values more self-explaining.
251 Add row's hash code.
252
261b6fd4
LMI
2532011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
254
255 * process.c (wait_reading_process_output): Fix asynchrounous
256 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 257 (wait_reading_process_output): Add comment and URL.
261b6fd4 258
e7cfd277
JD
2592011-11-21 Jan Djärv <jan.h.d@swipnet.se>
260
261 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
262
a9b9b7f5
CY
2632011-11-21 Chong Yidong <cyd@gnu.org>
264
265 * window.c (Fnext_window, Fprevious_window): Doc fix.
266
b0d15b4f
SM
2672011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
268
269 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
270
fe7a3057
JB
2712011-11-20 Juanma Barranquero <lekktu@gmail.com>
272
273 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
274
d2999b1a
MR
2752011-11-20 Martin Rudalics <rudalics@gmx.at>
276
277 * window.c (Fset_window_combination_limit): Rename argument
278 STATUS to LIMIT.
279 (Vwindow_combination_limit): Remove "status" from doc-string.
280
d5ff9cd0
AS
2812011-11-20 Andreas Schwab <schwab@linux-m68k.org>
282
283 * m/ibms390.h: Remove.
284 * m/ibms390x.h: Don't include "ibms390.h".
285
a5bb9bd3
SM
2862011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
287
288 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
289 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
290
cd1181db
JB
2912011-11-20 Juanma Barranquero <lekktu@gmail.com>
292
293 * casetab.c (Fset_case_table):
294 * charset.c (Fcharset_after): Fix typos.
295
615a3b8d 2962011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 297
17e845af
PE
298 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
299 Otherwise, valgrind does not work on some platforms.
300 Problem reported by Andreas Schwab in
6a0bf43d
PE
301 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
302 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
303 is set, removing the need for VIRT_ADDRESS_VARIES.
304 (PURE_P): Use a more-efficient implementation that needs just one
305 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
306 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
307 to 4 (xorl, subq, cmpq, setbe).
308 * alloc.c (pure): Always extern now, since that's the
309 VIRT_ADDR_VARIES behavior.
310 (PURE_POINTER_P): Use a single comparison, not two, for
311 consistency with the new puresize.h.
312 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
313 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
314 Remove VIRT_ADDR_VARIES no longer needed.
315
f8fe6f96
EZ
3162011-11-19 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
319 (erase_phys_cursor, update_window_cursor, show_mouse_face)
320 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
321 behave as if the cursor position were at the window margin.
322
323 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
324 and the cursor position is out of bounds, behave as if the cursor
325 position were at the window margin. (Bug#10075)
326
df05a53c
CY
3272011-11-18 Chong Yidong <cyd@gnu.org>
328
329 * window.c (Fwindow_combination_limit): Make first argument
330 non-optional, since it is meaningless for live windows like the
331 selected window.
332
2071918e
DA
3332011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
334
335 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
336
b50a28de
SM
3372011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
338
339 * intervals.c: Fix grafting over the whole buffer (bug#10071).
340 (graft_intervals_into_buffer): Simplify.
341
015137db
EZ
3422011-11-18 Eli Zaretskii <eliz@gnu.org>
343
344 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
345 hash values of the two rows.
346 (copy_row_except_pointers): Preserve the used[] arrays and the
347 hash values of the two rows. (Bug#10035)
68c95424 348 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
349
350 * xdisp.c (row_hash): New function, body extracted from
351 compute_line_metrics.
352 (compute_line_metrics): Call row_hash, instead of computing the
353 hash code inline.
354
355 * dispnew.c (verify_row_hash): Call row_hash for computing the
356 hash code of a row, instead of duplicating code from xdisp.c.
357
358 * dispextern.h (row_hash): Add prototype.
359
a2addb04
TH
3602011-11-18 Tassilo Horn <tassilo@member.fsf.org>
361
362 * frame.c (delete_frame): Don't delete the terminal when the last
363 X frame is closed if emacs is built with GTK toolkit.
364
df85d315
JB
3652011-11-17 Juanma Barranquero <lekktu@gmail.com>
366
367 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
368
a0c2d0ae
MR
3692011-11-17 Martin Rudalics <rudalics@gmx.at>
370
371 * window.c (Vwindow_splits): Rename to
372 Vwindow_combination_resize. Suggested by Juri Linkov.
373 (Fsplit_window_internal): Use Vwindow_combination_resize instead
374 of Vwindow_splits.
375
58179cce
JB
3762011-11-16 Juanma Barranquero <lekktu@gmail.com>
377
7877f373
JB
378 * nsfns.m (Fns_font_name):
379 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 380
b6f67890
MR
3812011-11-16 Martin Rudalics <rudalics@gmx.at>
382
383 * window.h (window): Rename slot "nest" to "combination_limit".
384 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
385 (Fset_window_nest): Rename to Fset_window_combination_limit.
386 (Vwindow_nest): Rename to Vwindow_combination_limit.
387 (recombine_windows, make_parent_window, make_window)
388 (Fsplit_window_internal, saved_window)
389 (Fset_window_configuration, save_window_save): Rename all
390 occurrences of window_nest to window_combination_limit.
391
c7015153
JB
3922011-11-15 Juanma Barranquero <lekktu@gmail.com>
393
394 * image.c (imagemagick_load_image): Fix typo.
395
322ad6ec
EZ
3962011-11-14 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (display_line): Move the call to
399 highlight_trailing_whitespace before the call to
400 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
401 faces of all the glyphs to compute ROW's hash value.
402 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 403
f067b8ec
JB
4042011-11-14 Juanma Barranquero <lekktu@gmail.com>
405
406 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
407 just return (bug#10044).
408
1e5b2111
EZ
4092011-11-12 Eli Zaretskii <eliz@gnu.org>
410
7ef3cbd5
EZ
411 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
412 with user-defined heap size. Bump the default size of the temacs
413 heap to 27MB, to avoid memory warning when running temacs.
414 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
415
1e5b2111
EZ
416 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
417 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
418 (verify_row_hash) [XASSERTS]: New function.
419 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
420 that the hash value of glyph rows is correct.
1e5b2111 421
89d61221
MR
4222011-11-12 Martin Rudalics <rudalics@gmx.at>
423
424 * window.h (window): Remove splits slot.
425 * window.c (Fwindow_splits, Fset_window_splits): Remove.
426 (Fdelete_other_windows_internal, make_parent_window)
427 (make_window, Fsplit_window_internal, Fdelete_window_internal)
428 (Fset_window_configuration, save_window_save): Don't deal with
429 split status of windows.
430 (saved_window): Remove splits slot.
431 (Vwindow_splits): Rewrite doc-string.
432
97f18cc8
JD
4332011-11-11 Jan Djärv <jan.h.d@swipnet.se>
434
435 * xfns.c (unwind_create_frame):
436 * nsfns.m (unwind_create_frame):
437 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
438 Vframe_list (Bug#9999).
439
22a648b4
DA
4402011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
441
0b381c7e 442 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 443
659afede
KH
4442011-11-11 Kenichi Handa <handa@m17n.org>
445
446 * callproc.c (Fcall_process): Set the member dst_multibyte of
447 process_coding.
448
9ac0394b
KH
4492011-11-11 Johan Bockgård <bojohan@gnu.org>
450
451 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
452 avoid a crash (bug#9496).
453
2fbdc249
CY
4542011-11-09 Chong Yidong <cyd@gnu.org>
455
456 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
457 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
458
ac6b1f81
PE
4592011-11-08 Paul Eggert <eggert@cs.ucla.edu>
460
461 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
462
09db192c
PE
4632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
464
465 Avoid some portability problems by eschewing 'extern inline' functions.
466 The trivial performance wins aren't worth the portability hassles; see
467 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
468 et seq.
469 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
470 (window_box_width, window_box_left, window_box_left_offset)
471 (window_box_right, window_box_right_offset): Undo previous change,
472 by removing the "extern"s.
473 * intervals.c (adjust_intervals_for_insertion)
474 (adjust_intervals_for_deletion): Undo previous change,
475 making these static again.
476 (offset_intervals, temp_set_point_both, temp_set_point)
477 (copy_intervals_to_string): No longer inline.
478 * xdisp.c (window_text_bottom_y, window_box_width)
479 (window_box_height, window_box_left_offset)
480 (window_box_right_offset, window_box_left, window_box_right)
481 (window_box): No longer inline.
482
105216ed
CY
4832011-11-08 Chong Yidong <cyd@gnu.org>
484
485 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
486 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
487 Signal an error if not a live window.
105216ed
CY
488 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
489 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
490
ae9e237f
JB
4912011-11-07 Juanma Barranquero <lekktu@gmail.com>
492
493 * lisp.h (syms_of_abbrev): Remove declaration.
494 Reported by CHENG Gao <chenggao@royau.me>.
495
c7aa8333
EZ
4962011-11-07 Eli Zaretskii <eliz@gnu.org>
497
498 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
499 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
500 of temacs in GUI mode.
501
be7f5545
MR
5022011-11-07 Martin Rudalics <rudalics@gmx.at>
503
504 * window.h: Declare delete_all_child_windows instead of
505 delete_all_subwindows.
506 * window.c (Fwindow_nest, Fset_window_nest)
507 (Fset_window_new_total, Fset_window_new_normal)
508 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
509 (delete_all_subwindows): Rename to delete_all_child_windows.
510 (Fdelete_other_windows_internal, Fset_window_configuration):
511 Call delete_all_child_windows instead of delete_all_subwindows.
512 * frame.c (delete_frame): Call delete_all_child_windows instead
513 of delete_all_subwindows.
514
ca78dc43
PE
5152011-11-07 Paul Eggert <eggert@cs.ucla.edu>
516
517 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
518 This is also needed for porting to any host where GC_MARK_STACK is
519 not GC_MAKE_GCPROS_NOOPS.
520 (which_symbols): Use it.
521
a0241d01
KH
5222011-11-07 Kenichi Handa <handa@m17n.org>
523
524 * coding.c (coding_set_destination): Check coding->src_pos only
525 when coding->src_object is a buffer (bug#9910).
526
527 * process.c (send_process): Set the member src_multibyte of coding
528 to 0 (bug#9911) when sending a unibyte text.
529
530 * callproc.c (Fcall_process): Set the member src_multibyte of
531 process_coding to 0 (bug#9912).
532
a64bfdfa 5332011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
534
535 * xmenu.c (cleanup_widget_value_tree): New function.
536 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
537 calling free_menubar_widget_value_tree directly (Bug#9830).
538
cb41b32a
PE
5392011-11-06 Paul Eggert <eggert@cs.ucla.edu>
540
541 Fix some portability problems with 'inline'.
542 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
543 (window_box_width, window_box_left, window_box_left_offset)
544 (window_box_right, window_box_right_offset): Declare extern.
545 Otherwise, these inline functions do not conform to C99 and
546 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
547 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
548 * intervals.c (adjust_intervals_for_insertion)
549 (adjust_intervals_for_deletion): Now extern, because otherwise the
550 extern inline functions 'offset_intervals' couldn't refer to it.
551 (static_offset_intervals): Remove.
552 (offset_intervals): Rewrite using the old contents of
553 static_offset_intervals. The old version didn't conform to C99
554 because an extern inline function contained a reference to an
555 identifier with static linkage.
556
b7041366
AS
5572011-11-06 Andreas Schwab <schwab@linux-m68k.org>
558
559 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
560 GC.
561
88a37c4d
EZ
5622011-11-06 Eli Zaretskii <eliz@gnu.org>
563
564 * xdisp.c (init_iterator, reseat_to_string): Don't set the
565 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
566 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
567 return Qleft_to_right.
568
49745b39
CY
5692011-11-06 Chong Yidong <cyd@gnu.org>
570
571 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
572 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
573 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
574 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
575 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
576 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
577 (Fwindow_vscroll): Doc fix.
578 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
579 argument, since it makes no sense to pass a live window and for
580 consistency with window-child.
581
1f05cd82
CS
5822011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
583
584 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
585 support MSVC.
586
22610910
JR
5872011-11-05 Jason Rumney <jasonr@gnu.org>
588
589 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
590 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
591 fonts (Bug#6029).
592 (add_font_entity_to_list): Fix logic errors in mixed boolean and
593 bitwise arithmetic preventing use of unicode-sip and non-truetype
594 opentype fonts.
595
a06776b2
EZ
5962011-11-05 Eli Zaretskii <eliz@gnu.org>
597
3ad924ba
EZ
598 * s/ms-w32.h (fstat, stat, utime): Move redirections to
599 "emacs"-only part.
600
a06776b2
EZ
601 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
602 initialization code to keep similarity to xfns.c after changes
603 from 2011-11-05.
604
c9e7db78
JD
6052011-11-05 Jan Djärv <jan.h.d@swipnet.se>
606
a97f8f3f
JD
607 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
608 (unwind_create_frame): New function (Bug#9943).
609 (Fx_create_frame): Restructure code to be more similar to the one in
610 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
611 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
612 Move terminal->reference_count++ just before making the frame official
613 (Bug#9943).
614
615 * nsterm.m (x_free_frame_resources): New function.
616 (x_destroy_window): Move code to x_free_frame_resources.
617
c9e7db78 618 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
619 (Fx_create_frame, x_create_tip_frame):
620 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
621 official. Move initialization of image_cache_refcount and
622 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
623
a6fc3b5c
EZ
6242011-11-05 Eli Zaretskii <eliz@gnu.org>
625
626 Support MSVC build with newer versions of Visual Studio.
627 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
628 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
629 nt/gmake.defs.
630
631 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
632 which are not supported by MSVC.
633 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
634 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
635 bitfields.
636 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
637 types in bitfields.
638 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
639
640 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
641
58179cce 6422011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
643
644 Support MSVC build with newer versions of Visual Studio.
645 * w32.c: Don't include w32api.h for MSVC.
646 (init_environment) [_MSC_VER]: Call sys_access, not _access.
647
648 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
649 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
650 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
651 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
652 e_* cousins.
653 (alloca) [_MSC_VER]: Define to _alloca.
654
655 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
656
657 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
658
a58c13ed
EZ
6592011-11-04 Eli Zaretskii <eliz@gnu.org>
660
661 * xdisp.c (note_mouse_highlight): If either of
662 previous/next-single-property-change returns nil, treat that as
663 the beginning or the end of the buffer. (Bug#9955)
664
fe0b6370
JD
6652011-11-04 Jan Djärv <jan.h.d@swipnet.se>
666
a58c13ed 667 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
668 label is not null (Bug#9951).
669 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
670 may be NULL.
671
89bd5ee1
EZ
6722011-11-04 Eli Zaretskii <eliz@gnu.org>
673
674 * window.c (Fwindow_body_size): Mention in the doc string that the
675 return value is in frame's canonical units. (Bug#9949)
676
84c3edb9
EZ
6772011-11-03 Eli Zaretskii <eliz@gnu.org>
678
4e2fb5c7
EZ
679 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
680
84c3edb9 681 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 682 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 683 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 684
bc17a887
EZ
6852011-11-01 Eli Zaretskii <eliz@gnu.org>
686
687 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
688 Don't stop backward scan on the continuation glyph, even though
689 its CHARPOS is positive.
6d5eb5b0
SM
690 (mouse_face_from_buffer_pos, note_mouse_highlight):
691 Rename cover_string to disp_string.
bc17a887 692
4ee88440
MR
6932011-11-01 Martin Rudalics <rudalics@gmx.at>
694
695 * window.c (temp_output_buffer_show): Don't use
696 Vtemp_buffer_show_specifiers.
697 (Vtemp_buffer_show_specifiers): Remove unused variable.
698
c2ff3c02
EZ
6992011-10-30 Eli Zaretskii <eliz@gnu.org>
700
701 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
702 past the beginning of the current glyph matrix.
703
58179cce 7042011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
705
706 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
707 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
708 HAVE_GTK3 (Bug#9869).
b77a6a7f 709
3b574623
JD
710 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
711 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
712
b77a6a7f
JD
713 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
714
715 * xterm.c: Declare x_handle_net_wm_state to return int.
716 (handle_one_xevent): Check if we are iconified but don't have
717 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
718 (get_current_wm_state): Return non-zero if not hidden,
719 check for _NET_WM_STATE_HIDDEN (Bug#9893).
720 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
721 (x_handle_net_wm_state): Return what get_current_wm_state returns.
722 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
723
196e41e4
PE
7242011-10-29 Paul Eggert <eggert@cs.ucla.edu>
725
726 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
727 so that this new function doesn't get optimized away by a
728 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
729
021f2e1a
AS
7302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
731
732 * frame.h (MOUSE_HL_INFO): Remove excess parens.
733
8b058d44
EZ
7342011-10-29 Eli Zaretskii <eliz@gnu.org>
735
736 Fix the `xbytecode' command.
737 * .gdbinit (xprintbytestr): New command.
b50a28de 738 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
739 (xbytecode): Print the byte-code string as well.
740
4452fb80
EZ
7412011-10-29 Kim Storm <storm@cua.dk>
742
8b058d44
EZ
743 * alloc.c (which_symbols): New function.
744
21b72067
AS
7452011-10-29 Andreas Schwab <schwab@linux-m68k.org>
746
747 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
748 line. (Bug#9903)
749
83ed7b5c
GM
7502011-10-29 Glenn Morris <rgm@gnu.org>
751
752 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
753 Not clear what it was for, and it causes various bugs. (Bug#9839)
754
5a7a728b
EZ
7552011-10-28 Eli Zaretskii <eliz@gnu.org>
756
757 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
758 possible random value that matches one of those tested as
759 condition to clear the mouse face.
760
d3d0842f
CY
7612011-10-28 Chong Yidong <cyd@gnu.org>
762
763 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
764
31b39d13
DN
7652011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
766
767 * window.c (make_window): Initialize phys_cursor_on_p.
768
9aba6043
SM
7692011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
770
771 * lisp.h (struct Lisp_Symbol): Update comments.
772
c20992f4
JB
7732011-10-28 Juanma Barranquero <lekktu@gmail.com>
774
775 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
776
db4f02f2
EZ
7772011-10-28 Eli Zaretskii <eliz@gnu.org>
778
779 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
780 <oslsachem@gmail.com> for helping to debug this.
781
782 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
783 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
784 (g_b_init_get_glyph_outline_w): New static variables.
785 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
786 (GetGlyphOutlineW_Proc): New typedefs.
787 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
788 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
789 New functions.
790 (w32font_open_internal, compute_metrics):
791 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
792 instead of calling the "wide" APIs directly.
793
794 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
795
796 * w32.h (syms_of_w32font): Add prototype.
797
87e68db4
JB
7982011-10-27 Juanma Barranquero <lekktu@gmail.com>
799
800 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
801 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
802 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
803 (Fmove_to_window_line): Doc fix.
804
435c1d67
CY
8052011-10-27 Chong Yidong <cyd@gnu.org>
806
807 * process.c (make_process): Set gnutls_state to NULL.
808
809 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
810 non-NULL, regardless of GNUTLS_INITSTAGE.
811 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
812 an error. Set process slots as soon as we allocate them.
813
814 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
815
9c6c6f49
CY
8162011-10-27 Chong Yidong <cyd@gnu.org>
817
9aba6043
SM
818 * gnutls.c (emacs_gnutls_deinit): New function.
819 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
820 (Fgnutls_deinit, Fgnutls_boot): Use it.
821
822 * process.c (make_process): Initialize GnuTLS credentials to NULL.
823 (deactivate_process): Call emacs_gnutls_deinit.
824
657d08d3
JB
8252011-10-27 Juanma Barranquero <lekktu@gmail.com>
826
827 * image.c (x_create_x_image_and_pixmap):
828 * w32.c (sys_rename, w32_delayed_load):
829 * w32font.c (fill_in_logfont):
830 * w32reg.c (x_get_string_resource): Silence compiler warnings.
831
5430d399
JB
8322011-10-26 Juanma Barranquero <lekktu@gmail.com>
833
834 * w32fns.c (w32_default_color_map): New function,
835 extracted from Fw32_default_color_map.
a7ef684b 836 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 837
fe0055fa
PE
8382011-10-25 Paul Eggert <eggert@cs.ucla.edu>
839
840 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
841
e6346438
SM
8422011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * keyboard.c (test_undefined): New function (bug#9751).
845 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
846
e112cc37
ET
8472011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
848
849 * sysdep.c (init_sys_modes): Fix the check for the controlling
850 terminal (Bug#6649).
851
7b5d6677
EZ
8522011-10-20 Eli Zaretskii <eliz@gnu.org>
853
854 * dispextern.h (struct bidi_it): New member next_en_type.
855
856 * bidi.c (bidi_line_init): Initialize the next_en_type member.
857 (bidi_resolve_explicit_1): When next_en_pos is valid for the
858 current character, check also for next_en_type being WEAK_EN.
859 (bidi_resolve_weak): Don't enter the expensive loop if the current
860 position is before next_en_pos. Record the bidi type of the first
861 non-ET, non-BN character we find, in addition to its position.
862 (bidi_level_of_next_char): Invalidate next_en_type when
863 next_en_pos is over-stepped.
864
7da0b018
PE
8652011-10-20 Paul Eggert <eggert@cs.ucla.edu>
866
867 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
868 * editfns.c: Rewrite current-time-zone so that it invokes
869 the equivalent of (format-time-string "%Z") to get the time zone name.
870 This fixes a bug when the time zone name contains characters that
871 need converting from the system time locale to Emacs internal format.
872 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
873 that patch fixed format-time-string to do the conversion, but
874 I forgot to fix current-time-zone.
875 (format_time_string): New function, containing most of
876 what Fformat_time_string used to contain.
877 (Fformat_time_string): Rewrite in terms of format_time_string.
878 This doesn't change this function's behavior.
879 (current-time-zone): Rewrite to use format_time_string.
880 This fixes the bug reported by Michael Schierl in
881 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
882 Jason Rumney's 2007-06-07 change worked around this bug, but
883 didn't fix it.
884 * systime.h (tzname, timezone): Remove no-longer-used declarations.
885
8547b010
EZ
8862011-10-19 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (start_display): If the character at POS is displayed
889 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
890 (try_window_reusing_current_matrix): If a line ends in a display
891 vector or the next line starts in a display vector, continue
892 redrawing the window even though the character position of
893 start_row was reached.
8547b010
EZ
894 (Bug#9771, part 2)
895
4e948d15
CY
8962011-10-18 Chong Yidong <cyd@gnu.org>
897
898 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
899 with nobreak-char-display too.
900
4787455f
EZ
9012011-10-18 Eli Zaretskii <eliz@gnu.org>
902
903 Fix part 3 of bug#9771.
904 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
905 (bidi_resolve_neutral): Don't enter the expensive loop looking for
906 non-neutral characters if the current character is a paragraph
907 separator (a.k.a. Newline). This avoids running the same
908 expensive loop twice, once when we consume the preceding newline
909 and the other time when the line actually needs to be displayed.
910 Avoid the loop when we see neutrals on the base embedding level
911 following a character whose directionality is the same as the
912 paragraph's. This avoids running the expensive loop when a line
913 ends in a long sequence of neutrals, like control characters.
914 Add assertion against STRONG_AL type. Slightly rearrange code
915 that determines the type of a neutral given the first non-neutral
916 that follows it.
917 (bidi_level_of_next_char): Set next_en_pos to zero when
918 invalidating its info.
919
2c91f553
EZ
9202011-10-17 Eli Zaretskii <eliz@gnu.org>
921
922 * xdisp.c (push_display_prop): Determine whether to record string
923 or buffer position by IT->string, not by IT->method. Allow
924 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
925 (move_it_vertically_backward): Don't look for character position
926 immediately after the newline when in a continuation line.
927 (Bug#9771, part 1)
2c91f553 928
c7b08b0d
MR
9292011-10-15 Martin Rudalics <rudalics@gmx.at>
930
931 * window.c (coordinates_in_window): Rewrite and delabelize
932 vertical border check. (Bug#5357) (Bug#9618)
933
6b02f655
SM
9342011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
935
936 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
937 errors in XSetWindowBorder (bug#9310).
938
81d40c92
DA
9392011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
942 avoid crash when xmalloc overrun checking is enabled.
943
d4172c3b
EZ
9442011-10-13 Eli Zaretskii <eliz@gnu.org>
945
946 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
947 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
948 cursor motion with <left> and <right> arrow keys.
949
950 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
951 some callers set that themselves.
952
b00eea75
EZ
9532011-10-12 Eli Zaretskii <eliz@gnu.org>
954
955 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
956 display string and the previous row comes from the same string and
957 is empty. (Bug#9739) (Bug#9738)
958
8fe012c4
SM
9592011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
960
961 * doc.c (get_doc_string): Encode file name (bug#9735).
962
0074aef2
EZ
9632011-10-12 Eli Zaretskii <eliz@gnu.org>
964
79beb178
EZ
965 * bidi.c (bidi_level_of_next_char):
966 * xdisp.c (get_visually_first_element): Remove old incorrect
967 comments regarding the Unicode Line Separator character.
968
0074aef2
EZ
969 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
970
6e4b3fbe
DA
9712011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
972
973 * alloc.c (Fgc_status): Do not access beyond zombies array
974 boundary if nzombies > MAX_ZOMBIES.
975 * alloc.c (dump_zombies): Add missing format specifier.
976
0324f3af
PE
9772011-10-12 Paul Eggert <eggert@cs.ucla.edu>
978
b5525cac
PE
979 * xdisp.c (set_cursor_from_row): Simplify conditionals,
980 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
981
0324f3af
PE
982 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
983 Some packages use them to denote characters with modifiers.
984
e9b5f888
AS
9852011-10-11 Andreas Schwab <schwab@linux-m68k.org>
986
987 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
988 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
989 matching a pp-number. Rename parameter var to var1.
990
127827c0
SM
9912011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
992
993 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
994
c8fd3bd0
GM
9952011-10-08 Glenn Morris <rgm@gnu.org>
996
997 * callint.c (Fcall_interactively): Give a more explicit error for the
998 'c' case with a non-character input. (Bug#8479)
999
352ec8ff
EZ
10002011-10-08 Eli Zaretskii <eliz@gnu.org>
1001
03669ccb
EZ
1002 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1003 lines.
7061c986
EZ
1004 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1005 lines that are hscrolled on the left.
03669ccb 1006
352ec8ff
EZ
1007 * dispnew.c (buffer_posn_from_coords): Account for a possible
1008 presence of header-line. (Bug#4426)
1009
a66cfb1c
SM
10102011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1011
6b02f655
SM
1012 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1013 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1014
7c5ee88e
PE
10152011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1018 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1019 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1020 this makes Emacs dump core during garbage collection on rare
1021 occasions. sizeof is obviously inferior to offsetof here, so
1022 stick with offsetof.
1023 (GC_POINTER_ALIGNMENT): New macro.
1024 (mark_memory): Omit 3rd (offset) arg; caller changed.
1025 Don't assume EMACS_INT alignment is the same as pointer alignment.
1026
df1bbe5b
SM
10272011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1028
1029 * keyboard.c (read_key_sequence_remapped): New var.
1030 (read_key_sequence): Compute remapping in the right buffer.
1031 (command_loop_1): Use read_key_sequence's remapping directly.
1032
51553db6
SM
10332011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1034
32c1fffd
SM
1035 * dired.c (file_name_completion): Don't expand file name.
1036 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1037 before checking file name handler.
1038
51553db6
SM
1039 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1040 they've been requested explicitly (bug#9591).
1041
b6bd1599 10422011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1043
1044 * keymap.c (Fsingle_key_description): Use make_specified_string
1045 instead of build_string to build string from push_key_description.
1046 (Bug#5193)
1047
f701dc2a
PE
10482011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1049
4222c55d
PE
1050 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1051 This fixes a Y2038 bug on 64-bit hosts.
1052 * buffer.c (reset_buffer):
1053 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1054 (Fclear_buffer_auto_save_failure):
1055 Use 0, not -1, to represent an unset failure time, since time_t
1056 might not be signed.
1057
f701dc2a
PE
1058 Remove dependency on glibc malloc internals.
1059 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1060 Move back here from lisp.h, but with their new implementations.
1061 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1062 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1063 * charset.c (charset_table_init): New static var.
1064 (syms_of_charset): Use it instead of xmalloc. This removes a
1065 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1066 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1067 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1068 Move back to alloc.c.
1069 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1070 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1071
9ceebf39
JD
10722011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1073
1074 * nsterm.m (windowDidResize): Call x_set_window_size only when
1075 ns_in_resize is true. Otherwise set pixelwidth/height and
1076 call change_frame_size (Bug#9628).
1077
cb993c58
PE
10782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1079
3930c88b
PE
1080 Port --enable-checking=all to Fedora 14 x86-64.
1081 * charset.c (syms_of_charset): Also account for glibc malloc's
1082 internal overhead when calculating the initial malloc maximum.
1083
cb993c58
PE
1084 Port --enable-checking=all to Fedora 14 x86.
1085 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1086 Move to lisp.h.
1087 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1088 (overrun_check_realloc, overrun_check_free):
1089 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1090 That way, xmalloc returns a properly-aligned pointer even if
1091 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1092 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1093 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1094 into account when calculating the initial malloc maximum.
1095 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1096 Move here from alloc.c, so that charset.c can use it too.
1097 Properly align; the old code wasn't right for common 32-bit hosts
1098 when configured with --enable-checking=all.
1099 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1100 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1101
31bed486
EZ
11022011-09-29 Eli Zaretskii <eliz@gnu.org>
1103
04c70788 1104 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1105 use EDOM.
1106
fbcaa2f3
EZ
11072011-09-28 Eli Zaretskii <eliz@gnu.org>
1108
1109 * xdisp.c (compute_display_string_end): If there's no display
1110 string at CHARPOS, return -1.
1111
1112 * bidi.c (bidi_fetch_char): When compute_display_string_end
1113 returns a negative value, treat the character as a normal
1114 character not covered by a display string. (Bug#9624)
1115
a239d4e9
JB
11162011-09-28 Juanma Barranquero <lekktu@gmail.com>
1117
1118 * lread.c (Fread_from_string): Fix typo in docstring.
1119
88652fd5
EZ
11202011-09-27 Eli Zaretskii <eliz@gnu.org>
1121
1122 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1123 newline, reseat the iterator instead of bidi-iterating there one
1124 character at a time. (Bug#9610)
32c1fffd
SM
1125 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1126 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1127
ed497dd4
AS
11282011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * lread.c (readevalloop): Use correct code for NBSP.
1131 (read1): Likewise. (Bug#9608)
1132
b2bf61aa
MA
11332011-09-25 Michael Albinus <michael.albinus@gmx.de>
1134
1135 * dbusbind.c (Fdbus_register_signal): When service is not
1136 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1137
32bbb17c
GM
11382011-09-25 Glenn Morris <rgm@gnu.org>
1139
1140 * buffer.c (truncate-lines): Doc fix.
1141
94e0933e
CY
11422011-09-24 Chong Yidong <cyd@stupidchicken.com>
1143
1144 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1145 (Fset_window_next_buffers): Doc fix.
1146
cddde921
GM
11472011-09-24 Glenn Morris <rgm@gnu.org>
1148
1149 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1150
1260aef1
PE
11512011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1152
25b4bfa0
PE
1153 Fix minor problems found by static checking.
1154 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1155 * indent.c (Fvertical_motion): Fix == vs = typo.
1156
e3cbd34b
EZ
11572011-09-24 Eli Zaretskii <eliz@gnu.org>
1158
a66cfb1c
SM
1159 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1160 Default value is now t. Doc fix.
6bf7006f 1161
e3cbd34b 1162 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1163 logic when moving up, not only when moving down. Fix the
e3cbd34b 1164 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1165 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1166
1167 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1168 CHARPOS is covered by a display string which includes newlines.
1169 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1170 is covered by a display string with embedded newlines.
1171
a3de0cbd
MA
11722011-09-24 Michael Albinus <michael.albinus@gmx.de>
1173
1174 * dbusbind.c (Fdbus_register_signal): Add match rule to
1175 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1176 (Fdbus_register_method, Vdbus_registered_objects_table):
1177 Fix docstring.
a3de0cbd 1178
b260039d
JM
11792011-09-24 Jim Meyering <meyering@redhat.com>
1180
32c1fffd 1181 do not ignore write error for any output size
b260039d
JM
1182 The previous change was incomplete.
1183 While it makes emacs --batch detect the vast majority of stdout
1184 write failures, errors were still ignored whenever the output size is
1185 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1186 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1187 && echo FAIL: ignored write error
1188 FAIL: ignored write error
1189 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1190 && echo FAIL: ignored write error
1191 FAIL: ignored write error
1192 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1193
8eca8a7c
AS
11942011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1195
1196 * emacs.c (Fkill_emacs): In noninteractive mode exit
1197 non-successfully if a write error occurred on stdout. (Bug#9574)
1198
3341db62
EZ
11992011-09-21 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1202 the xassert test.
1203
1204 * dispextern.h (struct it): Update the comment documenting what
1205 can it->OBJECT be.
1206
8c203dbf
EZ
12072011-09-20 Eli Zaretskii <eliz@gnu.org>
1208
1209 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1210 a display string, extend search for cursor position to end of row.
1211 (find_row_edges): If the row ends in a newline from a display
1212 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1213 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1214 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1215 non-empty line. Fixes confusing cursor motion with arrow keys at
1216 the beginning of a line that starts with whitespace.
8c203dbf 1217
a4824228
LMI
12182011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1219
1220 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1221 (bug#9493).
1222
33ed493b
CY
12232011-09-18 Chong Yidong <cyd@stupidchicken.com>
1224
1225 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1226 boolean (Bug#9154).
1227
56cd55c8
EZ
12282011-09-18 Eli Zaretskii <eliz@gnu.org>
1229
1230 * xdisp.c (display_line): Record maximum and minimum buffer
1231 positions even if no glyphs were produced (e.g., by a zero-width
1232 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1233 buffer positions that will be removed from the glyph row because
1234 they don't fit.
c02dcedf
EZ
1235 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1236 column is beyond frame width: don't subtract 1 "pixel" when
1237 computing width of the stretch.
3e62b7e0
EZ
1238 (reseat_at_next_visible_line_start): Undo the change made on
1239 2011-09-17 that saved paragraph information and restored it after
1240 the call to `reseat'. (Bug#9545)
56cd55c8 1241
5ed99d36 12422011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1243
1244 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1245 and turn window cursor on if cleared (Bug#9415).
1246
5ed99d36 12472011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1248
1249 * search.c (boyer_moore): Take unibyte characters from pattern
1250 literally. (Bug#9458)
1251
9bade7b2
EZ
12522011-09-18 Eli Zaretskii <eliz@gnu.org>
1253
1254 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1255
e5e9d610
PE
12562011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1257
87e4427a
PE
1258 Fix minor problem found by static checking.
1259 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1260 initialized, to pacify gcc -Wuninitialized.
1261
e5e9d610
PE
1262 * fileio.c: Report proper errno when syscall falls.
1263 (Finsert_file_contents): Save and restore errno,
1264 so that report_file_error outputs the correct diagnostic.
1265 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1266
a1674f0b
EZ
12672011-09-18 Eli Zaretskii <eliz@gnu.org>
1268
1269 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1270
fbfb6dd4
EZ
12712011-09-17 Eli Zaretskii <eliz@gnu.org>
1272
1273 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1274 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1275
bb187662
EZ
12762011-09-17 Eli Zaretskii <eliz@gnu.org>
1277
1137e8b8 1278 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1279 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1280
1281 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1282 (bidi_find_paragraph_start): Search back for paragraph beginning
1283 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1284 (bidi_move_to_visually_next): Only trigger paragraph-related
1285 computations when the last character is a newline or at EOB, not
1286 just any NEUTRAL_B. (Bug#9470)
1287
bb187662
EZ
1288 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1289 truncated lines if point is covered by a display string. (Bug#9524)
1290
2e621251
PE
12912011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1294 (cons_to_x_long): New function.
1295 (lisp_data_to_selection_data): Use it. Correct the test for
1296 short-versus-long data; it was negated. Break out of vector
1297 loop, for efficiency, when a long datum is discovered.
1298
91a15bc6
SM
12992011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1300
1301 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1302
b41c3a35
EZ
13032011-09-16 Eli Zaretskii <eliz@gnu.org>
1304
1305 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1306 GCC PR/17406) by declaring this function with external scope.
1307
7812ba2d
PE
13082011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1311 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1312
cf7edc2a
AS
13132011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1314
1315 * editfns.c (Fformat): Correctly handle text properties on "%%".
1316
bd01620e
EZ
13172011-09-15 Eli Zaretskii <eliz@gnu.org>
1318
1319 * xterm.c (x_draw_composite_glyph_string_foreground):
1320 * w32term.c (x_draw_composite_glyph_string_foreground):
1321 * term.c (encode_terminal_code):
1322 * composite.c (composition_update_it, get_composition_id):
1323 * xdisp.c (get_next_display_element)
1324 (fill_composite_glyph_string): Add comments about special meaning
1325 of TAB characters in a composition.
1326
a02719a3
PE
13272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1330 This occurs when processing a multibyte format.
1331 Problem reported by Wolfgang Jenker.
a02719a3 1332
72589a3c
JB
13332011-09-15 Johan Bockgård <bojohan@gnu.org>
1334
1335 * xdisp.c (try_cursor_movement): Only check for exact match if
1336 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1337
1c14176c
PE
13382011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Remove unused external symbols.
1341 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1342 * xdisp.c (calc_pixel_width_or_height): Now static.
1343 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1344 * indent.c (check_display_width):
1345 * w32term.c: Fix comment to match code.
1346 * xterm.c, xterm.h (x_catching_errors): Remove.
1347
d2eea5b5
PE
13482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 * xselect.c: Use signed conversions more consistently (Bug#9498).
1351 (selection_data_to_lisp_data): Assume incoming selection data are
1352 signed integers, not unsigned. This is to be consistent with
1353 outgoing selection data, which was modified to use signed integers
1354 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1355 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1356 expects long, not unsigned long.
1357
46888499
EZ
13582011-09-14 Eli Zaretskii <eliz@gnu.org>
1359
1360 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1361 computation of loop end. Reported by Johan Bockgård
1362 <bojohan@gnu.org>.
1363
ef8ef9fb
CY
13642011-09-13 Chong Yidong <cyd@stupidchicken.com>
1365
1366 * frame.c (Fother_visible_frames_p): Function deleted.
1367
fa819fed
EZ
13682011-09-12 Eli Zaretskii <eliz@gnu.org>
1369
1370 * indent.c (compute_motion): Process display vector front to back
1371 rather than the other way around. (Bug#2496)
1372
2ba8e008
SM
13732011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1374
1375 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1376
20f53c69
CY
13772011-09-11 Chong Yidong <cyd@stupidchicken.com>
1378
1379 * minibuf.c (Fread_from_minibuffer): Doc fix.
1380
d562d7a4
EZ
13812011-09-11 Eli Zaretskii <eliz@gnu.org>
1382
1383 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1384 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1385
1c4d7f3d
LMI
13862011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1387
1388 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1389 value for non-existent files.
1390
b885bf36
EZ
13912011-09-11 Eli Zaretskii <eliz@gnu.org>
1392
1393 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1394 set its "size" to -1. This will set the modtime_size field of
1395 the corresponding buffer to -1, which is what
1396 verify-visited-file-modtime expects for files that do not exist.
1397 (Bug#9139)
1398
6612f0bf
PE
13992011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1402 here ...
1403 * lisp.h: ... from here. push_key_description is no longer
1404 defined in keyboard.c, so its declaration should not be in
1405 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1406 logically belongs with push_key_description.
1407
dfb3f755
PE
14082011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * buffer.h: Include <sys/types.h> instead of <time.h>.
1411 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1412 Problem reported by Herbert J. Skuhra.
1413
3134906c
LMI
14142011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1415
1416 * xml.c (parse_region): Make the parsing work for
1417 non-comment-starting XML files again (bug#9144).
1418
8d903f4e
AS
14192011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1420
1421 * image.c (gif_load): Fix calculation of bottom and right corner.
1422 (Bug#9468)
1423
80ad64f4
EZ
14242011-09-10 Eli Zaretskii <eliz@gnu.org>
1425
1426 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1427 redisplay in small windows.
1428
208a048d
EZ
14292011-09-09 Eli Zaretskii <eliz@gnu.org>
1430
1431 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1432
9b1c252e
MR
14332011-09-08 Martin Rudalics <rudalics@gmx.at>
1434
1435 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1436 Operate on live windows only.
1437
2949f33b
JB
14382011-09-08 Juanma Barranquero <lekktu@gmail.com>
1439
1440 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1441
e08dcafd
EZ
14422011-09-07 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1445 only under bidi iteration.
1446
115b96bd
JD
14472011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1448
1449 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1450
c8199d0f
PE
14512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1454 Without this fix, the command to link temacs failed due to an
1455 undefined symbol __builtin_isnan. This is because
1456 /usr/include/iso/math_c99.h #defines isnan(x) to
1457 __builtin_isnan(x), but the bundled gcc, which identifies itself
1458 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1459 a __builtin_isnan.
1460 * floatfns.c (isnan): #undef, and then #define to a clone of
1461 what's in data.c.
1462 (Fisnan): Always define, since it's always available now.
1463 (syms_of_floatfns): Always define isnan at the Lisp level.
1464
e39b275c 14652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1466
1467 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1468
b2db44d9 14692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1470
f4af5137 1471 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1472 The previous code assumed that file offsets (off_t values) fit in
1473 EMACS_INT variables, which is not true on typical 32-bit hosts.
1474 The code messed up by falsely reporting buffer overflow in cases
1475 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1476 when "big" contains more than 2**29 bytes, even though this
1477 inserts just one byte and does not overflow the buffer.
1478 (Finsert_file_contents): Store file offsets as off_t
1479 values, not as EMACS_INT values. Check for overflow when
1480 converting between EMACS_INT and off_t. When checking for
1481 buffer overflow or for overlap, take the offsets into account.
1482 Don't use EMACS_INT for small values where int suffices.
1483 When checking for overlap, fix a typo: ZV was used where
1484 ZV_BYTE was intended.
1485 (Fwrite_region): Don't assume off_t fits into 'long'.
1486 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1487
ecfc0a49
MA
14882011-09-05 Michael Albinus <michael.albinus@gmx.de>
1489
1490 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1491
6511acf2 14922011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1493
0999621a 1494 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1495
1496 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1497 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1498 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1499 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1500 (modify_event_symbol): Do not assume that the length of
1501 name_alist_or_stem is safe to alloca and fits in int.
1502 (Fexecute_extended_command): Likewise for function name and binding.
1503 (Frecursion_depth): Wrap around reliably on integer overflow.
1504 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1505 since some callers pass EMACS_INT values.
1506 (Fsingle_key_description): Don't crash if symbol name contains more
1507 than MAX_ALLOCA bytes.
1508 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1509 (get_minibuffer): Arg is now EMACS_INT, not int.
1510 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1511 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1512 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1513
2be7d702
PE
1514 * dbusbind.c (signature_cat): New function.
1515 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1516 Do not overrun buffer; instead, report string overflow.
1517
9d1df220
PE
1518 * dispnew.c (add_window_display_history): Don't overrun buffer.
1519 Truncate instead; this is OK since it's just a log.
1520
33ef5c64
PE
1521 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1522 even if the time zone offset is outlandishly large.
1523 Don't mishandle offset == INT_MIN.
1524
66c6fdd5
PE
1525 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1526 when creating daemon; the previous buffer-overflow check was incorrect.
1527
d749b01b
PE
1528 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1529 which has the guts of the old verror function.
1530
b5cd1905
PE
1531 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1532 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1533
6e1a67fb
PE
1534 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1535 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1536 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1537 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1538 length of string rather than counting it via multiple sprintfs;
1539 that's simpler and more reliable.
c21721cc
PE
1540 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1541 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1542 sprintf, in case result does not fit in int.
1543
c57b67fc
PE
1544 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1545 (fontset_from_font): Print it.
1546
8a401434
PE
1547 * frame.c (tty_frame_count): Now printmax_t, not int.
1548 (make_terminal_frame, set_term_frame_name): Print it.
1549 (x_report_frame_params): In X, window IDs are unsigned long,
1550 not signed long, so print them as unsigned.
1551 (validate_x_resource_name): Check for implausibly long names,
1552 and don't assume name length fits in 'int'.
1553 (x_get_resource_string): Don't blindly alloca invocation name;
1554 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1555 not fit in int.
1556
6e1a67fb
PE
1557 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1558 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1559 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1560
0df02bf3
PE
1561 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1562 Use esprintf, not sprintf, in case result does not fit in int.
1563
48e30793
PE
1564 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1565 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1566 it as a large positive number.
1567 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1568 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1569
a66ff6d8
PE
1570 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1571 in case result does not fit in int.
1572
aca216ff
PE
1573 * print.c (float_to_string): Detect width overflow more reliably.
1574 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1575 buffer overrun. Don't assume list length fits in 'int'. Treat
1576 print length of 0 as 0, not as infinity; to be consistent with other
1577 uses of print length in this function. Don't overflow print length
1578 index. Don't assume hash table size fits in 'long', or that
1579 vectorlike size fits in 'unsigned long'.
1580
31c286f7
PE
1581 * process.c (make_process): Use printmax_t, not int, to format
1582 process-name gensyms.
1583
55e5faa1
PE
1584 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1585
80f2e268
PE
1586 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1587 to avoid potential buffer overrun.
1588
670741ab
PE
1589 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1590 if X resource line is longer than 512 bytes.
1591
b7163a50
PE
1592 * xfns.c (x_window): Make sprintf buffer a bit bigger
1593 to avoid potential buffer overrun.
1594
ae58ff1f
PE
1595 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1596
c43c8a6a
PE
1597 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1598
3f8236f4
PE
15992011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1600
53e9fe90 1601 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1602 Without these, Emacs silently mishandles large integers sometimes.
1603 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1604 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1605
6511acf2
PE
1606 * xdisp.c (try_window_id): Check Emacs fixnum range before
1607 converting to 'int'.
806add1d 1608
6511acf2 1609 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1610 Check that an Emacs fixnum is in range before assigning it to 'int'.
1611 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1612 values converted from Emacs fixnums.
1613 (Frecenter): Don't wrap around a line count if it is out of 'int'
1614 range; instead, treat it as an extreme value.
1615 (Fset_window_configuration, compare_window_configurations):
1616 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1617
6511acf2
PE
1618 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1619 that can exceed INT_MAX. Check that EMACS_INT value is in range
1620 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1621 (match_limit): Don't assume that a fixnum can fit in 'int'.
1622
6511acf2 1623 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1624 exceed INT_MAX.
1625
6511acf2 1626 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1627 (Fvertical_motion): Don't wrap around LINES values that don't fit
1628 in 'int'. Instead, treat them as extreme values. This is good
1629 enough for windows, which can't have more than INT_MAX lines anyway.
1630
fcb901a7
LMI
16312011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1632
0f2f6b6d
LMI
1633 * Require libxml/parser.h to avoid compilation warning.
1634
fcb901a7
LMI
1635 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1636
1637 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1638 since this reportedly can destroy thread storage.
1639
6e20a0d4
CY
16402011-08-30 Chong Yidong <cyd@stupidchicken.com>
1641
1642 * syntax.c (find_defun_start): Update all cache variables if
1643 exiting early (Bug#9401).
1644
148ae00e
EZ
16452011-08-30 Eli Zaretskii <eliz@gnu.org>
1646
f6cfbd8f
EZ
1647 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1648
148ae00e
EZ
1649 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1650 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1651 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1652
1653 * term.c (tty_append_glyph): New function.
1654 (produce_stretch_glyph): Static function and its prototype deleted.
1655
a66cfb1c
SM
1656 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1657 Add prototypes.
148ae00e 1658
c4a07a4c
PE
16592011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1660
1661 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1662 when checking :margin (Bug#9390).
1663 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1664 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1665 so that the name doesn't mislead. All uses changed.
1666
6bc8cd65
JB
16672011-08-28 Johan Bockgård <bojohan@gnu.org>
1668
1669 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1670 set_tty_hooks.
1671
dca4927e
EZ
16722011-08-27 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (move_it_to): Don't bail out early when reaching
1675 position beyond to_charpos, if we are scanning backwards.
1676 (move_it_vertically_backward): When DY == 0, make sure we get to
1677 the first character in the line after the newline.
1678
f2cad773
PE
16792011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1682 (ccl_driver): Do not generate an out-of-range pointer.
1683 (Fccl_execute_on_string): Remove unnecessary check for
1684 integer overflow, noted by Stefan Monnier in
1685 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1686 Remove a FIXME that didn't need fixing.
1687 Simplify the newly-introduced buffer reallocation code.
1688
0cae2cdb
JB
16892011-08-27 Juanma Barranquero <lekktu@gmail.com>
1690
1691 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1692
5fc295a4 16932011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1694
70c60eb2 1695 Integer and memory overflow issues (Bug#9196).
726e0ab1 1696
d31850da
PE
1697 * doc.c (get_doc_string): Rework so that
1698 get_doc_string_buffer_size is the actual buffer size, rather than
1699 being 1 less than the actual buffer size; this makes xpalloc more
1700 convenient.
1701
a69fbedb
PE
1702 * image.c (x_allocate_bitmap_record, cache_image):
1703 * xselect.c (Fx_register_dnd_atom):
1704 Simplify previous changes by using xpalloc.
1705
fe5c5d37
PE
1706 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1707 since either will do and ptrdiff_t is convenient with xpalloc.
1708
0065d054
PE
1709 * charset.c (charset_table_size)
1710 (struct charset_sort_data.priority): Now ptrdiff_t.
1711 (charset_compare): Don't overflow if priorities differ greatly.
1712 (Fsort_charsets): Don't assume list length fits in int.
1713 Check for size-calculation overflow when allocating sort data.
1714 (syms_of_charset): Allocate an initial charset table that is
1715 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1716
1717 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1718
1719 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1720 The actual value is always <= INT_MAX, and leaving it unsigned made
1721 overflow checking harder.
1722
1723 * dispextern.h (struct glyph_matrix.rows_allocated)
1724 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1725 with xpalloc. The values are still always <= INT_MAX.
1726
1727 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1728
1729 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1730 (SAFE_NALLOCA): New macro.
1731
1732 * region-cache.c (struct boundary.pos, find_cache_boundary)
1733 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1734 (set_cache_region, invalidate_region_cache)
1735 (revalidate_region_cache, know_region_cache, region_cache_forward)
1736 (region_cache_backward, pp_cache):
1737 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1738 so that ptrdiff_t * can be passed to xpalloc.
1739 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1740 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1741 (pp_cache): Don't assume cache_len fits in int.
1742 * region-cache.h: Adjust extern decls to match.
1743
1744 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1745 EMACS_INT, since either will do, for xpalloc.
1746
1747 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1748 (xnmalloc, xnrealloc, xpalloc): New functions.
1749
726e0ab1
PE
1750 * bidi.c (bidi_shelve_header_size): New constant.
1751 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1752 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1753
51f30bc5 1754 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1755 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1756 (overlay_strings):
1757 Don't update size of array until after memory allocation succeeds,
1758 because xmalloc/xrealloc may not return.
0065d054
PE
1759 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1760 now that we have proper integer overflow checking.
1761 (record_overlay_string, overlay_strings): Catch overflows when
1762 calculating size of overlay_str_buf.
726e0ab1 1763
0065d054
PE
1764 * callproc.c (Fcall_process): Check for size overflow when
1765 calculating size of args2.
1766 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1767 Normally we prefer signed values, but sticking with ptrdiff_t would
1768 require adding more-complicated checks.
726e0ab1
PE
1769
1770 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1771 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1772 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1773 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1774
1775 * character.c (Fstring): Check for size-calculation overflow.
1776
1777 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1778 unnecessary integer overflow. Check for size overflow.
1779 (encode_coding_object): Don't update size until xmalloc succeeds.
1780
1781 * composite.c (get_composition_id): Check for overflow in glyph
1782 length calculations.
1783
1784 Integer and memory overflow fixes for display code.
1785 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1786 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1787 (scrolling_window): Check for overflow in size calculations.
1788 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1789 Don't assume glyph table len fits in int.
1790 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1791 (row_table_size): Now ptrdiff_t, not int.
1792 (scrolling_window): Avoid overflow in size calculations.
1793 Don't update size until allocation succeeds.
1794 * fns.c (concat): Check for overflow in size calculations.
1795 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1796 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1797 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1798
1799 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1800 (get_doc_string): Check for size calculation overflow.
1801 Don't update size until allocation succeeds.
1802 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1803 EMACS_INT, where ptrdiff_t will do.
1804 (Fsubstitute_command_keys): Check for string overflow.
1805
1806 * editfns.c (set_time_zone_rule): Don't assume environment length
1807 fits in int.
1808 (message_length): Now ptrdiff_t, not int.
1809 (Fmessage_box): Don't update size until allocation succeeds.
1810 Don't assume message length fits in int.
1811 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1812
0065d054
PE
1813 * emacs.c (main): Do not reallocate argv, since there is a null at
1814 the end that can be overwritten, and this way there's no need to
1815 worry about size-calculation overflow.
1816 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1817
1818 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1819 alloc succeeds.
1820 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1821
1822 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1823 (x_set_scroll_bar_width, x_figure_window_size):
1824 Check for integer overflow.
1825 (x_set_alpha): Do not assume XINT fits in int.
1826
1827 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1828 This is for the members text_lines, text_cols, total_lines, total_cols,
1829 where the system imposes an 'int' limit.
1830
1831 * fringe.c (Fdefine_fringe_bitmap):
1832 Don't update size until alloc works.
1833
1834 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1835 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1836
1837 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1838 Check for size-calculation overflow.
1839 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1840 do, as we prefer signed integers.
1841 (id_to_widget.max_size, id_to_widget.used)
1842 (xg_store_widget_in_map, xg_remove_widget_from_map)
1843 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1844 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1845 Use and return ptrdiff_t, not int.
1846 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1847 * gtkutil.h: Change prototypes to match the above.
1848
1849 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1850 are duplicate now that they've been promoted to lisp.h.
1851 (x_allocate_bitmap_record, x_alloc_image_color)
1852 (make_image_cache, cache_image, xpm_load):
1853 Don't update size until alloc is done.
1854 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1855 (x_detect_edges):
3256efce 1856 Check for size calculation overflow.
726e0ab1
PE
1857 (ct_colors_allocated_max): New constant.
1858 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1859 overflow.
3256efce 1860
726e0ab1
PE
1861 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1862 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1863 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1864 Use ptrdiff_t, not int, to count maps.
1865 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1866 calculations. Don't update size until allocation succeeds.
1867 Redo calculations to avoid overflow.
726e0ab1
PE
1868 * keyboard.h: Change prototypes to match the above.
1869
1870 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1871 to count maps.
1872 (current_minor_maps): Check for size calculation overflow.
1873 * keymap.h: Change prototypes to match the above.
1874
1875 * lread.c (read1, init_obarray): Don't update size until alloc done.
1876
1877 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1878 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1879
726e0ab1
PE
1880 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1881 Now ptrdiff_t, not int.
1882 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1883 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1884
1885 * process.c (Fnetwork_interface_list): Check for overflow
1886 in size calculation.
1887
1888 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1889
1890 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1891 overflow. Don't bother calling xmalloc when xrealloc will do.
1892
1893 * search.c (Freplace_match): Check for size calculation overflow.
1894 (Fset_match_data): Don't assume list lengths fit in 'int'.
1895
1896 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1897 for command line length. Do not attempt to address one before the
1898 beginning of an array, as that's not portable.
1899
1900 * term.c (max_frame_lines): Remove; unused.
1901 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1902 not int.
1903 (encode_terminal_code, calculate_costs): Check for size
1904 calculation overflow.
1905 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1906 table lengths and related sizes. Don't update size until alloc
1907 done. Redo calculations to avoid overflow.
1908 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1909
1910 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1911 subtracting pointers.
1912 (gobble_line): Check for overflow more carefully. Don't update size
1913 until alloc done.
1914
1915 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1916 Don't update size until alloc done.
1917 Redo size calculations to avoid overflow.
1918 Check for size calculation overflow.
0065d054 1919 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1920
1921 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1922 Use ptrdiff_t, not int, for sizes.
1923 (store_mode_line_noprop_char): Don't update size until alloc done.
1924
0065d054
PE
1925 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1926 Use ptrdiff_t, not int, for sizes.
1927 (Finternal_make_lisp_face, cache_face):
1928 Check for size calculation overflow.
1929 (cache_face): Treat size calculation overflows as if they were
1930 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1931
1932 * xfns.c (x_encode_text, x_set_name_internal)
1933 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1934 sizes, since they can exceed INT_MAX in size. Check for size
1935 calculation overflow.
1936
0065d054
PE
1937 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1938 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1939 Don't update size until alloc done.
1940
0065d054 1941 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1942 as sprintf is limited to int lengths.
1d526e2f 1943
252c5ee1
PE
1944 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1945 (X_LONG_MIN): New macros.
864d7ce7
PE
1946 Use them to make the following changes clearer.
1947 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1948 This change doesn't affect the value now, but it may help remind
1949 future maintainers not to raise the value too much later.
1950 (SELECTION_QUANTUM): Remove, replacing with ...
1951 (selection_quantum): ... new function, which avoids overflow.
1952 All uses changed.
1953 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1954 assumption that selection length fits in 'int'.
1955 (x_reply_selection_request, x_handle_selection_request)
1956 (x_get_window_property, receive_incremental_selection)
1957 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1958 (lisp_data_to_selection_data, clean_local_selection_data):
1959 Use ptrdiff_t, not int, to record length of selection.
1960 (x_reply_selection_request, x_get_window_property)
1961 (receive_incremental_selection, x_property_data_to_lisp):
1962 Redo calculations to avoid overflow.
1963 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1964 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1965 something.
1966 (x_get_window_property, receive_incremental_selection)
1967 (lisp_data_to_selection_data, x_property_data_to_lisp):
1968 Check for size-calculation overflow.
1969 (x_get_window_property, receive_incremental_selection)
1970 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1971 Don't store size until memory allocation succeeds.
1972 (x_get_window_property): Plug memory leak on memory exhaustion.
1973 Don't double-block input; malloc is safe here. Don't assume 2**34
1974 - 4 fits in unsigned long. Add an xassert to check
1975 XGetWindowProperty overflow. Be more careful about overflow
1976 calculations, and distinguish size from memory overflow better.
1977 (receive_incremental_selection): When tracing, don't assume
1978 unsigned int is less than INT_MAX.
1979 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1980 harmful) conversions of unsigned short to int.
1981 (lisp_data_to_selection_data): Don't assume that integers
1982 in the range -65535 through -1 fit in an X unsigned short.
1983 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1984 result parameters unless successful. Rely on cons_to_unsigned
1985 to report problems with elements; the old code wasn't right anyway.
1986 (x_check_property_data): Check for int overflow; we cannot use
1987 a wider type due to X limits.
1988 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1989
726e0ab1 1990 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1991
0065d054
PE
1992 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1993 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1994 (x_color_cells): Don't store size until memory allocation succeeds.
1995 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1996 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1997 (x_term_init): Don't assume length fits in int (sprintf is limited
1998 to int size).
bc18e09d 1999
ebfa62c0
PE
2000 Use ptrdiff_t for composition IDs.
2001 * character.c (lisp_string_width):
2002 * composite.c (composition_table_size, n_compositions)
2003 (get_composition_id, composition_gstring_from_id):
2004 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2005 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2006 * window.c (Frecenter):
2007 Use ptrdiff_t, not int, for composition IDs.
2008 * composite.c (get_composition_id): Check for integer overflow.
2009 * composite.h: Adjust prototypes to match the above changes.
2010
d3411f89
PE
2011 Use ptrdiff_t for hash table indexes.
2012 * category.c (hash_get_category_set):
2013 * ccl.c (ccl_driver):
2014 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2015 * coding.c (coding_system_charset_list, detect_coding_system):
2016 * coding.h (struct coding_system.id):
2017 * composite.c (get_composition_id, gstring_lookup_cache):
2018 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2019 * image.c (xpm_get_color_table_h):
2020 * lisp.h (hash_lookup, hash_put):
2021 * minibuf.c (Ftest_completion):
2022 Use ptrdiff_t for hash table indexes, not int (which is too
2023 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2024 32-bit --with-wide-int hosts).
2025
e097a6fa
PE
2026 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2027 Add a FIXME comment about memory leaks.
2028 (syms_of_charset): Don't assume xmalloc returns.
2029
5637687f
PE
2030 Don't assume that stated character widths fit in int.
2031 * character.c (Fchar_width, c_string_width, lisp_string_width):
2032 * character.h (CHAR_WIDTH):
2033 * indent.c (MULTIBYTE_BYTES_WIDTH):
2034 Use sanitize_char_width to avoid undefined and/or bad behavior
2035 with outlandish widths.
a66cfb1c 2036 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2037 now that we have two such functions. All uses changed.
2038 (sanitize_char_width): New inline function.
2039
a2271ba2
PE
2040 Don't assume that tab-width fits in int.
2041 * character.h (sanitize_width): New inline function.
2042 (SANE_TAB_WIDTH): New macro.
2043 (ASCII_CHAR_WIDTH): Use it.
2044 * indent.c (sane_tab_width): Remove. All uses replaced by
2045 SANE_TAB_WIDTH (current_buffer).
2046 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2047
18c52557
PE
2048 * fileio.c: Integer overflow issues with file modes.
2049 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2050
caeeedc1
PE
2051 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2052 Remove unreachable code.
2053 (read_hex, load_charset_map_from_file): Check for integer overflow.
2054
50849c52
PE
2055 * xterm.c: don't go over XClientMessageEvent limit
2056 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2057 (x_send_scroll_bar_event): Likewise. Check that the size does not
2058 exceed limits imposed by XClientMessageEvent, as well as the usual
2059 ptrdiff_t and size_t limits.
2060
b13995db
PE
2061 * keyboard.c: Overflow, signedness and related fixes.
2062 (make_lispy_movement): Use same integer type in forward decl
2063 that is used in the definition.
2064 (read_key_sequence, keyremap_step):
2065 Change bufsize argument back to int, undoing my 2011-03-30 change.
2066 We prefer signed types, and int is wide enough here.
2067 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2068 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2069 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2070 length, not size_t. Use ptrdiff_t for index, not int.
2071 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2072 possibility of integer overflow.
2073
13464394
PE
2074 Overflow, signedness and related fixes for images.
2075
2076 * dispextern.h (struct it.stack[0].u.image.image_id)
2077 (struct_it.image_id, struct image.id, struct image_cache.size)
2078 (struct image_cache.used, struct image_cache.ref_count):
2079 * gtkutil.c (update_frame_tool_bar):
2080 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2081 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2082 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2083 * nsmenu.m (update_frame_tool_bar):
2084 * xdisp.c (calc_pixel_width_or_height):
2085 * xfns.c (image_cache_refcount):
2086 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2087 on typical 64-bit hosts.
2088
2089 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2090 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2091 Omit unnecessary casts to int.
2092 (parse_image_spec): Check that integers fall into 'int' range
2093 when the callers expect that.
2094 (image_ascent): Redo ascent calculation to avoid int overflow.
2095 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2096 (lookup_image): Remove unnecessary tests.
2097 (xbm_image_p): Locals are now of int, not EMACS_INT,
2098 since parse_image_check makes sure they fit into int.
2099 (png_load, gif_load, svg_load_image):
2100 Prefer int to unsigned where either will do.
2101 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2102 old tiff_error_handler and tiff_warning_handler.
2103 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2104 stack buffer overflows. It uses only the features of vsnprintf
2105 that are common to both POSIX and native Microsoft.
2106 (tiff_error_handler, tiff_warning_handler): Use it.
2107 (tiff_load, gif_load, imagemagick_load_image):
2108 Don't assume :index value fits in 'int'.
2109 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2110 (imagemagick_load_image): Check that crop parameters fit into
2111 the integer types that MagickCropImage accepts. Don't assume
2112 Vimagemagick_render_type has a nonnegative value. Don't assume
2113 size_t fits in 'long'.
2114 (gs_load): Use printmax_t to print the widest integers possible.
2115 Check for integer overflow when computing image height and width.
2116
c11821d4
EZ
21172011-08-26 Eli Zaretskii <eliz@gnu.org>
2118
2119 * xdisp.c (redisplay_window): Don't force window start if point
2120 will be invisible in the resulting window. (Bug#9324)
2121
0c95fcf7
EZ
21222011-08-25 Eli Zaretskii <eliz@gnu.org>
2123
2124 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2125 the display spec is of the form `(space ...)'.
2126 (handle_display_spec): Return the value returned by
2127 handle_single_display_spec, not just 1 or zero.
2128 (handle_single_display_spec): If the display spec is of the form
2129 `(space ...)', and specifies display in the text area, return 2
2130 rather than 1.
fee65a97 2131 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2132 accurately, and prefer exact match for point under bidi.
2133 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2134
2135 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2136 into disp_prop; all users changed.
2137
2138 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2139 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2140 for the text covered by the display property.
2141
e4ed06f1
CY
21422011-08-25 Chong Yidong <cyd@stupidchicken.com>
2143
2144 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2145 Change return value to nil.
2146 (Frecord_buffer): Delete unused function.
2147
f67cdd7f
EZ
21482011-08-24 Eli Zaretskii <eliz@gnu.org>
2149
5980d4c6
EZ
2150 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2151 buffers, return left-to-right.
8610fe8b
EZ
2152 (set_cursor_from_row): Consider candidate row a win if its glyph
2153 represents a newline and point is on that newline. Fixes cursor
2154 positioning on the newline at EOL of R2L text within L2R
2155 paragraph, and vice versa.
2156 (try_cursor_movement): Check continued rows, in addition to
2157 continuation rows. Fixes unwarranted scroll when point enters a
2158 continued line of R2L text within an L2R paragraph, or vice versa.
2159 (cursor_row_p): Consider the case of point being equal to
2160 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2161 from the end of a short line to the beginning of a continued line
2162 of R2L text within L2R paragraph.
2163 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2164 composed characters.
5980d4c6 2165
f67cdd7f
EZ
2166 * bidi.c (bidi_check_type): Use xassert.
2167 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2168 members.
2169
bca633fb
EZ
21702011-08-23 Eli Zaretskii <eliz@gnu.org>
2171
2172 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2173 a character.
2174
4a5885a7
CY
21752011-08-23 Chong Yidong <cyd@stupidchicken.com>
2176
2177 * nsfont.m (ns_otf_to_script): Fix typo.
2178
0902a04e
KH
21792011-08-22 Kenichi Handa <handa@m17n.org>
2180
2181 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2182 extra slot even if the purpose is char-code-property-table.
2183
1a2e6670
EZ
21842011-08-23 Eli Zaretskii <eliz@gnu.org>
2185
8ddde651
EZ
2186 * xdisp.c (redisplay_window): When computing centering_position,
2187 account for the height of the header line. (Bug#8874)
2188
425cc014
EZ
2189 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2190 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2191 candidate is selected by the mouse, and that candidate has a
2192 composed character under the mouse.
2193
1a2e6670
EZ
2194 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2195 coordinates reported by pos-visible-in-window-p for a composed
2196 character in column zero.
2197
8b76d6f8
SM
21982011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2199
2200 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2201
dac347dd
EZ
22022011-08-22 Eli Zaretskii <eliz@gnu.org>
2203
2204 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2205 consider it a hit if to_charpos is anywhere in the range of the
2206 composed buffer positions.
2207
e013fb34
CY
22082011-08-22 Chong Yidong <cyd@stupidchicken.com>
2209
2210 * image.c (gif_load): Don't assume that each subimage has the same
2211 dimensions as the base image. Handle disposal method that is
2212 "undefined" by the gif spec (Bug#9335).
2213
bd1ba3e8
CY
22142011-08-20 Chong Yidong <cyd@stupidchicken.com>
2215
2216 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2217 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2218
54a1215b
EZ
22192011-08-19 Eli Zaretskii <eliz@gnu.org>
2220
823564e5
EZ
2221 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2222 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2223 from an Org mode buffer to a Speedbar frame.
2224
54a1215b
EZ
2225 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2226 a composition, take its buffer position from IT->cmp_it.charpos.
2227 Fixes cursor positioning at the beginning of a line that begins
2228 with a composed character.
2229
9778ebcc
EZ
22302011-08-18 Eli Zaretskii <eliz@gnu.org>
2231
0be6ee06
EZ
2232 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2233 character bidirectional type, use STRONG_L instead. Fixes crashes
2234 in a buffer produced by `describe-categories'.
2235
9778ebcc
EZ
2236 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2237 members before the level stack, so they would be saved and
2238 restored when copying iterator state. Fixes incorrect reordering
2239 around TABs covered by display properties.
2240
156bffbe
AS
22412011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2242
6b02f655 2243 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2244
72ad093b
CY
22452011-08-17 Chong Yidong <cyd@stupidchicken.com>
2246
2247 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2248 (internal_condition_case_2, internal_condition_case_n):
2249 Remove unnecessary aborts (Bug#9081).
72ad093b 2250
35774242
EZ
22512011-08-17 Eli Zaretskii <eliz@gnu.org>
2252
2253 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2254 has no `load' handler, try opening the file locally. (Bug#9311)
2255
db76dd85
KB
22562011-08-16 Ken Brown <kbrown@cornell.edu>
2257
2258 * gmalloc.c: Expand comment.
2259
b215eee5
EZ
22602011-08-16 Eli Zaretskii <eliz@gnu.org>
2261
2262 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2263 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2264
a4579d33
KB
22652011-08-16 Ken Brown <kbrown@cornell.edu>
2266
2267 Fix memory allocation problems in Cygwin build (Bug#9273).
2268
2269 * unexcw.c ( __malloc_initialized): Declare external variable.
2270 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2271
8b76d6f8
SM
2272 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2273 New variables.
a4579d33
KB
2274 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2275 dumped emacs.
2276 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2277 in the static heap.
2278 [CYGWIN] (special_realloc): New function.
2279 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2280 requests to realloc storage in the static heap.
2281
3ebec551
PE
22822011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 * bidi.c (bidi_initialize): Remove unused local.
2285
9fd8be00
EZ
22862011-08-15 Eli Zaretskii <eliz@gnu.org>
2287
6b02f655
SM
2288 * bidimirror.h:
2289 * biditype.h: Remove file.
2290 * makefile.w32-in ($(BLD)/bidi.$(O)):
2291 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2292
2293 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2294
2295 * chartab.c: Improve commentary for the uniprop_table API.
2296
32413314
EZ
2297 * bidi.c (bidi_paragraph_init): Support zero value of
2298 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2299 (bidi_initialize): Use uniprop_table instead of including
2300 biditype.h and bidimirror.h.
32413314 2301
9fd8be00
EZ
2302 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2303 coordinates of the iterator when restoring from ppos_it.
2304 (Bug#9296)
2305
5cf2b69b
KH
23062011-08-14 Kenichi Handa <handa@m17n.org>
2307
2308 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2309 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2310
daf17d00
EZ
23112011-08-14 Eli Zaretskii <eliz@gnu.org>
2312
2313 * xdisp.c (move_it_in_display_line_to): Don't invoke
2314 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2315 ppos_it. Fixes vertical cursor motion when line beginning is
2316 covered by an image. (Bug#9296)
2317
08e3161a
JD
23182011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2319
2320 * nsterm.h (ns_run_ascript): Declare.
2321 (NSAPP_DATA2_RUNASSCRIPT): Define.
2322
2323 * nsfns.m (as_script, as_result, as_status): New static variables.
2324 (ns_run_ascript): New function.
5e617bc2 2325 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2326 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2327 the event loop. Get status from as_status (Bug#7276).
2328
2329 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2330 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2331 the event loop (Bug#7276).
2332
a3720aa2
AS
23332011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2334
2335 * gnutls.c (QCgnutls_bootprop_priority)
2336 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2337 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2338 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2339 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2340 (QCgnutls_bootprop_verify_hostname_error)
2341 (QCgnutls_bootprop_callbacks_verify): Rename from
2342 Qgnutls_bootprop_..., all uses changed.
2343
2344 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2345 uses changed.
2346
0a0d27fb
PE
23472011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2348
19d5c50c
PE
2349 * xfaces.c (Qframe_set_background_mode): Now static.
2350 * dispextern.h (Qframe_set_background_mode): Remove decl.
2351
0a0d27fb
PE
2352 * process.c (Fnetwork_interface_info): Declare local only if needed.
2353
377538cb
JD
23542011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2355
2356 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2357 (Fnetwork_interface_list): Allocate in increments of bytes instead
2358 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2359 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2360 sockaddr.
2361 (struct ifflag_def): notrailers is smart on OSX.
2362 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2363 Get hardware address with getifaddrs if available.
2364
08fff70c
EZ
23652011-08-12 Eli Zaretskii <eliz@gnu.org>
2366
2367 * xdisp.c (iterate_out_of_display_property): xassert that
2368 IT->position is set to within IT->object's boundaries. Break from
2369 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2370 when IT->position is set up wrongly due to some bug.
2371 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2372 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2373 entry. Force push_it to save on the stack the current
2374 buffer/string position, to be restored by pop_it. Fix flags in
2375 the iterator structure wrt the object coming from a display
2376 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2377 properties. (Bug#9284)
2378
7be1c708 23792011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2380
7be1c708
CY
2381 * fontset.c (fontset_get_font_group): Add proper type checks.
2382 (Bug#9172)
aac0c6e3 2383
7be1c708 23842011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2385
7be1c708
CY
2386 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2387 and LC_VERSION_MIN_MACOSX.
2388 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2389 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2390
97bb72a6
EZ
23912011-08-08 Eli Zaretskii <eliz@gnu.org>
2392
2393 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2394 no-display-properties-and-no-overlays under bidi display.
2395 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2396 properties and overlays.
97bb72a6 2397
d5617611
CY
23982011-08-08 Chong Yidong <cyd@stupidchicken.com>
2399
37e11a63
CY
2400 * editfns.c (Fset_time_zone_rule): Document relationship with the
2401 setenv function.
2402
d5617611
CY
2403 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2404 the font entity extracted from the cache (Bug#8109).
2405
58872834
CY
24062011-08-07 Chong Yidong <cyd@stupidchicken.com>
2407
2408 * composite.c (autocmp_chars): Don't reset point. That is done by
2409 restore_point_unwind (Bug#5984).
2410
75bfc667
JL
24112011-08-07 Juri Linkov <juri@jurta.org>
2412
2413 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2414 to show the arg `TIME' instead of `TIMEVAL'.
2415
d1410150
EZ
24162011-08-06 Eli Zaretskii <eliz@gnu.org>
2417
2418 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2419 display property strides EOL and includes a newline, as in
2420 longlines-mode. (Bug#9254)
75b771e4
EZ
2421 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2422 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2423
2424 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2425 is non-zero, even if the data buffer is NULL. Fixes a crash in
2426 vertical-motion with longlines-mode. (Bug#9254)
2427
35928349
EZ
24282011-08-05 Eli Zaretskii <eliz@gnu.org>
2429
ec7cc85b
EZ
2430 * bidi.c <bidi_cache_total_alloc>: Now static.
2431 (bidi_initialize): Initialize bidi_cache_total_alloc.
2432
8b76d6f8 2433 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2434 cache. (Bug#9221)
2435
2436 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2437 amount allocated this far in `bidi_cache_total_alloc'.
2438 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2439 non-zero, only free the data buffer without restoring the cache
2440 contents. All callers changed.
2441
2442 * dispextern.h (bidi_unshelve_cache): Update prototype.
2443
2444 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2445 (move_it_in_display_line, move_it_to)
2446 (move_it_vertically_backward, move_it_by_lines): Replace the call
2447 to xfree to an equivalent call to bidi_unshelve_cache.
2448 (move_it_in_display_line_to): Fix logic of returning
412b6358 2449 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2450
e2e2423b
EZ
24512011-08-05 Eli Zaretskii <eliz@gnu.org>
2452
2453 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2454 came from a string character with a `cursor' property. (Bug#9229)
2455
ae9e757a
JD
24562011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2457
2458 * Makefile.in (LIB_PTHREAD): New variable.
2459 (LIBES): Add LIB_PTHREAD (Bug#9216).
2460
2461 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2462 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2463
213bd7f2
AS
24642011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2465
6b02f655 2466 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2467
99aaf75f
JD
24682011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2469
2470 * xterm.c (x_find_topmost_parent): New function.
2471 (x_set_frame_alpha): Find topmost parent window with
2472 x_find_topmost_parent and set the property there also (bug#9181).
2473 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2474
c74e9d86
PE
24752011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 * callproc.c (Fcall_process): Avoid vfork clobbering
2478 the local vars buffer, coding_systems, current_dir.
2479
640c8776
SM
24802011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2481
2482 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2483
f26d0e4c
PE
24842011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2485
8a10d76c
PE
2486 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2487 so that it is not optimized away.
2488
f26d0e4c
PE
2489 * xdisp.c (compute_display_string_pos): Remove unused local.
2490
55439c61
EZ
24912011-08-02 Eli Zaretskii <eliz@gnu.org>
2492
2493 Fix slow cursor motion and scrolling in large buffers with
2494 selective display, like Org Mode buffers. (Bug#9218)
2495
2496 * dispextern.h (struct bidi_it): New member disp_prop_p.
2497
2498 * xdisp.c: Remove one-slot cache of display string positions.
2499 (compute_display_string_pos): Accept an additional argument
5e617bc2 2500 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2501 for a display string or property. If found, set DISP_PROP_P
2502 non-zero.
2503
2504 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2505 DISP_PROP_P, and pass it to compute_display_string_pos.
2506 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2507 non-zero. All callers of bidi_fetch_char changed.
2508
fb33fa43
SM
25092011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2512
b099e063
DM
25132010-12-03 Don March <don@ohspite.net>
2514
2515 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2516 last character M-[char] is translated to ESC [char] (bug#7541).
2517
5cc7f7af
KH
25182011-08-02 Kenichi Handa <handa@m17n.org>
2519
d0fffa3f 2520 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2521
2522 * chartab.c (uniprop_table): Make it non-static.
2523
525d5e6e
EZ
25242011-08-01 Eli Zaretskii <eliz@gnu.org>
2525
2526 * xdisp.c (forward_to_next_line_start): Accept additional argument
2527 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2528 on the newline.
2529 (reseat_at_next_visible_line_start): Use the bidi iterator state
2530 returned by forward_to_next_line_start to restore the state of
2531 it->bidi_it after backing up to previous newline. (Bug#9212)
2532
31011111
AS
25332011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2534
2535 * regex.c (re_comp): Protoize.
2536 (re_exec): Fix return type.
2537 (regexec): Fix type of `ret'. (Bug#9203)
2538
476371c4
PE
25392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2540
e5d76069
PE
2541 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2542 This is needed if max-image-size is a floating-point number.
2543
9a79b20c
AS
25442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2545
2546 * print.c (print_object): Print empty symbol as ##.
2547
2548 * lread.c (read1): Read ## as empty symbol.
2549
d8c2fa78
AA
25502011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2551
2552 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2553 setting frame foreground color (Bug#9175).
2554 (x_set_background_color): Likewise.
2555
ffe57a7a
AA
2556 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2557 contents (Bug#9176).
2558 (EmacsTooltip -init): Remove bezels and add shadows to
2559 tooltip windows.
2560
bf3492a5
AA
2561 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2562 or scroll bar (Bug#8470).
2563
d55e9c53
AA
2564 * nsfont.m (nsfont_open): Remove assignment to voffset and
2565 unnecessary vars hshink, expand, hd, full_height, min_height.
2566 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2567
2568 * nsterm.h (nsfont_info): Remove voffset field.
2569
d8c2fa78 25702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2571
2572 Implement strike-through and overline on NextStep (Bug#8863).
2573
2574 * nsfont.m (nsfont_open): Use underline position provided by font,
2575 instead of hard-coded value of 2.
2576 (nsfont_draw): Call ns_draw_text_decoration instead.
2577
2578 * nsterm.h: Add declaration for ns_draw_text_decoration.
2579
2580 * nsterm.m (ns_draw_text_decoration): New function for drawing
2581 underline, overline, and strike-through.
2582 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2583 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2584 accommodate underlining, etc.
4843aac3 2585
4cc60b9b
EZ
25862011-07-28 Eli Zaretskii <eliz@gnu.org>
2587
bc7ece87
EZ
2588 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2589 default.
4cc60b9b 2590
476371c4
PE
25912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2592
66606eea
PE
2593 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2594 Without this fix, if a signal arrives just after memory fills up,
2595 'malloc' might be invoked reentrantly.
2596
476371c4
PE
2597 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2598 In other words, assume that every image size is allowed, on non-X
2599 hosts. This assumption is probably wrong, but it lets Emacs compile.
2600
f3fcc40d
AS
26012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2602
2603 * regex.c (re_iswctype): Convert return values to boolean.
2604
350c992f
EZ
26052011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2606
2607 * xdisp.c (compute_display_string_pos): Don't use cached display
2608 string position if the buffer had its restriction changed.
2609 (Bug#9184)
2610
5266b4bb
PE
26112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2614
2573a837 26152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2616
41f55ccd 2617 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2618
39e378da
PE
2619 * bidi.c: Integer size and overflow fixes.
2620 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2621 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2622 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2623 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2624 (bidi_find_other_level_edge):
2625 Use ptrdiff_t instead of EMACS_INT where either will do.
2626 This works better on 32-bit hosts configured --with-wide-int.
2627 (bidi_cache_ensure_space): Check for size-calculation overflow.
2628 Use % rather than repeated addition, for better worst-case speed.
2629 Don't set bidi_cache_size until after xrealloc returns, because it
2630 might not return.
2631 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2632 (bidi_cache_ensure_space): Also check that the bidi cache size
2633 does not exceed that of the largest Lisp string or buffer. See Eli
2634 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2635
5e927815
PE
2636 * alloc.c (__malloc_size_t): Remove.
2637 All uses replaced by size_t. See Andreas Schwab's note
2638 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2639
ca4aa935
PE
2640 * image.c: Improve checking for integer overflow.
2641 (check_image_size): Assume that f is nonnull, since
2642 it is always nonnull in practice. This is one less thing to
2643 worry about when checking for integer overflow later.
2644 (x_check_image_size): New function, which checks for integer
2645 overflow issues inside X.
2646 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2647 This removes the need for a memory_full check.
2648 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2649 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2650 (xbm_read_bitmap_data): Change locals back to 'int', since
2651 their values must fit in 'int'.
2652 (xpm_load_image, png_load, tiff_load):
2653 Invoke x_create_x_image_and_pixmap earlier,
2654 to avoid much needless work if the image is too large.
2655 (tiff_load): Treat overly large images as if
2656 x_create_x_image_and_pixmap failed, not as malloc failures.
2657 (gs_load): Use x_check_image_size.
2658
5f8f9cc2
PE
2659 * gtkutil.c: Omit integer casts.
2660 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2661 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2662
5adf60bc
PE
2663 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2664
c8907a93
PE
2665 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2666 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2667 would wrongly return t on a 64-bit host.
2668
e3c25c68
PE
2669 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2670 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2671 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2672 and therefore cause GCC to emit a bogus diagnostic in some cases.
2673
3f791afe
PE
2674 * image.c: Integer signedness and overflow and related fixes.
2675 This is not an exhaustive set of fixes, but it's time to
2676 record what I've got.
2677 (lookup_pixel_color, check_image_size): Remove redundant decls.
2678 (check_image_size): Don't assume that arbitrary EMACS_INT values
2679 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2680 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2681 (tiff_load, imagemagick_load_image):
2682 Check for overflow in size calculations.
2683 (x_create_x_image_and_pixmap): Remove unnecessary test for
2684 xmalloc returning NULL; that can't happen.
2685 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2686 (xpm_color_bucket): Use better integer hashing function.
2687 (xpm_cache_color): Don't possibly over-allocate memory.
2688 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2689 (gif_memory_source):
2690 Use ptrdiff_t, not int or size_t, to record sizes.
2691 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2692 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2693 either works, as we prefer signed integers.
2694 (tiff_read_from_memory, tiff_write_from_memory):
2695 Return tsize_t, not size_t, since that's what the TIFF API wants.
2696 (tiff_read_from_memory): Don't fail simply because the read would
2697 go past EOF; instead, return a short read.
2698 (tiff_load): Omit no-longer-needed casts.
2699 (Fimagemagick_types): Don't assume size fits into 'int'.
2700
3cc5a532
PE
2701 Improve hashing quality when configured --with-wide-int.
2702 * fns.c (hash_string): New function, taken from sxhash_string.
2703 Do not discard information about ASCII character case; this
2704 discarding is no longer needed.
2705 (sxhash-string): Use it. Change sig to match it. Caller changed.
2706 * lisp.h: Declare it.
2707 * lread.c (hash_string): Remove, since we now use fns.c's version.
2708 The fns.c version returns a wider integer if --with-wide-int is
2709 specified, so this should help the quality of the hashing a bit.
2710
b312a492
PE
2711 * emacs.c: Integer overflow minor fix.
2712 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2713 Define only if GNU_LINUX.
2714 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2715
dfd153ae
PE
2716 * dispnew.c: Integer signedness and overflow fixes.
2717 Remove unnecessary forward decls, that were a maintenance hassle.
2718 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2719 All uses changed.
2720 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2721 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2722 (prepare_desired_row, line_draw_cost):
2723 Use int, not unsigned, where either works.
2724 (save_current_matrix, restore_current_matrix):
2725 Use ptrdiff_t, not size_t, where either works.
2726 (init_display): Check for overflow more accurately, and without
2727 relying on undefined behavior.
2728
a81d11a3
PE
2729 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2730 Remove, replacing with the new symbols in lisp.h. All uses changed.
2731 * fileio.c (make_temp_name):
2732 * filelock.c (lock_file_1, lock_file):
2733 * xdisp.c (message_dolog):
2734 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2735 Use pMd etc. instead.
2736 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2737 replacing the pWIDE etc. symbols removed from editfns.c.
2738
3300e6fd
PE
2739 * keyboard.h (num_input_events): Now uintmax_t.
2740 This is (very slightly) less likely to mess up due to wraparound.
2741 All uses changed.
2742
fd05c7e9
PE
2743 * buffer.c: Integer signedness fixes.
2744 (alloc_buffer_text, enlarge_buffer_text):
2745 Use ptrdiff_t rather than size_t when either will do, as we prefer
2746 signed integers.
2747
903fe15d
PE
2748 * alloc.c: Integer signedness and overflow fixes.
2749 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2750 (__malloc_size_t): Default to size_t, not to int.
2751 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2752 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2753 Prefer ptrdiff_t to size_t when either would do, as we prefer
2754 signed integers.
2755 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2756 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2757 Now const. Initialize with values that are in range even if char
2758 is signed.
2759 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2760 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2761 These functions do the right thing with sizes > 2**32.
2762 (check_depth): Now ptrdiff_t, not int.
2763 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2764 Adjust to new way of storing sizes. Check for size overflow bugs
2765 in rest of code.
2766 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2767 slightly wrong anyway, as it missed one instance of
2768 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2769 (refill_memory_reserve): Omit needless cast to size_t.
2770 (mark_object_loop_halt): Mark as externally visible.
2771
ac82cc6a
PE
2772 * xselect.c: Integer signedness and overflow fixes.
2773 (Fx_register_dnd_atom, x_handle_dnd_message):
2774 Use ptrdiff_t, not size_t, since we prefer signed.
2775 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2776 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2777 x_dnd_atoms_size and x_dnd_atoms_length.
2778
c2d1e36d
PE
2779 * doprnt.c: Prefer signed to unsigned when either works.
2780 * eval.c (verror):
2781 * doprnt.c (doprnt):
2782 * lisp.h (doprnt):
2783 * xdisp.c (vmessage):
2784 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2785 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2786 prefer signed arithmetic to avoid comparison confusion.
2787 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2788 but is a bit tricky.
2789
0e926e56
PE
2790 Assume freestanding C89 headers, string.h, stdlib.h.
2791 * data.c, doprnt.c, floatfns.c, print.c:
2792 Include float.h unconditionally.
2793 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2794 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2795 * regex.c: Likewise for stddef.h, string.h.
2796 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2797 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2798 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2799 (STDC_HEADERS): Remove obsolete defines.
2800 * sysdep.c: Include limits.h unconditionally.
2801
9cfdb3ec
PE
2802 Assume support for memcmp, memcpy, memmove, memset.
2803 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2804 * regex.c (memcmp, memcpy):
2805 Remove; we assume C89 now.
2806
2807 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2808 (__malloc_safe_bcopy): Remove; no longer needed.
2809
cf950e6b 2810 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2811 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2812 well either way, and we prefer signed to unsigned.
2813
dbf38e02
LMI
28142011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2815
2816 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2817 closes the connection while we're reading (bug#9182).
2818
d6f0886c 28192011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2820
d6f0886c
JD
2821 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2822 are specified (Bug#9168).
24e0f6b1 2823
2eb1f9e6
PE
28242011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2827 Found by GCC static checking and --with-wide-int on a 32-bit host.
2828
22381272 28292011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2830
2831 * xdisp.c (compute_display_string_pos): Fix logic of caching
2832 previous display string position. Initialize cached_prev_pos to
2833 -1. Fixes slow-down at the beginning of a buffer.
2834
f25e39b4
EZ
28352011-07-24 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2838 for attrs[LFACE_FONTSET_INDEX].
2839
04c4b52e
PE
28402011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 * xml.c (parse_region): Remove unused local
2843 that was recently introduced.
2844
c1734fbd
EZ
28452011-07-23 Eli Zaretskii <eliz@gnu.org>
2846
be18c5a5
EZ
2847 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2848 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2849
c1734fbd
EZ
2850 * xdisp.c (move_it_in_display_line_to): Record the best matching
2851 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2852 exit if none of the characters scanned was an exact match.
2853 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2854 when exact match is impossible due to invisible text, and the
2855 lines are truncated.
2856
a258d627
JD
28572011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2858
2859 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2860 for OSX >= 10.7.
2861
b6d5a689
EZ
28622011-07-22 Eli Zaretskii <eliz@gnu.org>
2863
0f74f785
EZ
2864 Fix a significant slow-down of cursor motion with C-n, C-p,
2865 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2866 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2867 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2868 (next_element_from_buffer): Call compute_stop_pos_backwards to
2869 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2870 base_level_stop.
2871 (reseat): Don't look for prev_stop, as that could mean a very long
2872 run.
2873 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2874 <cached_disp_overlay_modiff>: Cache for last found display string
2875 position.
551918c1 2876 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2877 about the same buffer in the same area of character positions, and
2878 the buffer wasn't changed since the time the display string
2879 position was cached.
551918c1 2880
b2d0c91a
EZ
28812011-07-22 Eli Zaretskii <eliz@gnu.org>
2882
2883 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2884 is an integer, which is important for empty lines. (Bug#9149)
2885
043604ee
CY
28862011-07-22 Chong Yidong <cyd@stupidchicken.com>
2887
2888 * frame.c (Fmodify_frame_parameters): In tty case, update the
2889 default face if necessary (Bug#4238).
2890
da4adb04
CY
28912011-07-21 Chong Yidong <cyd@stupidchicken.com>
2892
2893 * editfns.c (Fstring_to_char): No need to explain what a character
2894 is in the docstring (Bug#6576).
2895
9abd0532
LMI
28962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2897
2898 * xml.c (parse_region): Make sure we always return a tree.
2899
36881d16
HK
29002011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2901
2902 * xml.c (parse_region): If a document contains only comments,
2903 return that, too.
2904
1e98674d
LMI
29052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2906
2907 * xml.c (make_dom): Return comments, too.
2908
590bd467
PE
29092011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 Port to OpenBSD.
2912 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2913 and the surrounding thread.
2914 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2915 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2916 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2917 timer goes off.
2918 * s/openbsd.h (BROKEN_SIGIO): Define.
2919 * unexelf.c (unexec) [__OpenBSD__]:
2920 Don't update the .mdebug section of the Alpha COFF symbol table.
2921
f41628b2
LMI
29222011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2923
2924 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2925 (bug#8460).
2926
b59b67c5
PE
29272011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2928
15e3a074
PE
2929 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2930 This fixes some race conditions on the permissions of any newly
2931 created file.
2932
41bed37d
PE
2933 * alloc.c (valid_pointer_p): Use pipe, not open.
2934 This fixes some permissions issues when debugging.
2935
b59b67c5
PE
2936 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2937 If fchown fails to set both uid and gid, try to set just gid,
2938 as that is sometimes allowed. Adjust the file's mode to eliminate
2939 setuid or setgid bits that are inappropriate if fchown fails.
2940
925a6be7
SM
29412011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2942
2943 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2944 to compare Lisp_Objects.
2945 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2946 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2947 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2948
52968808
AS
29492011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2950
0a6a104b
AS
2951 * lread.c (read_integer): Unread even EOF character.
2952 (read1): Likewise. Properly record start position of symbol.
2953
52968808
AS
2954 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2955 symbol character follows.
2956
9e381cdd
PE
29572011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2958
2959 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2960 This works around a problem with the previous change to Fcopy_file.
2961 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2962 and without this change, GCC might complain about discarding
2963 fchown's return value.
2964
b5641435
JB
29652011-07-16 Juanma Barranquero <lekktu@gmail.com>
2966
2967 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2968
a8031457
PE
29692011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2972
dd889327
LMI
29732011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2974
750c33f7
LMI
2975 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2976 it's used from the C level.
2977
dd889327
LMI
2978 * process.c: Use the same condition for POLL_FOR_INPUT in both
2979 keyboard.c and process.c (bug#1858).
2980
87e86684
LM
29812011-07-09 Lawrence Mitchell <wence@gmx.li>
2982
2983 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2984 (Fgnutls_boot): Use it.
2985
64348f40
AS
29862011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2987
2988 * doc.c (Fsubstitute_command_keys): Revert last change.
2989
1d698799
LMI
29902011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2991
f863868c
LMI
2992 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2993 quotes the next character, and doesn't affect other longer
2994 sequences (bug#8935).
2995
1d698799
LMI
2996 * lread.c (syms_of_lread): Clarify that is isn't only
2997 `eval-buffer' and `eval-defun' that's affected by
2998 `lexical-binding' (bug#8460).
2999
aa4b6df6
EZ
30002011-07-15 Eli Zaretskii <eliz@gnu.org>
3001
3002 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3003 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3004
5d856da6
PE
30052011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3006
ad6042bb
PE
3007 Fix minor problems found by static checking.
3008 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3009 (elsz): Now a signed constant, not a size_t var. We prefer signed
3010 types to unsigned, to avoid integer comparison confusion. Without
3011 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3012 "cannot optimize loop, the loop counter may overflow", a symptom
3013 of the confusion.
f00bbb22 3014 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3015 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3016
6468f31c
LMI
30172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3018
49080b10
LMI
3019 * search.c (Fre_search_backward): Mention `case-fold-search' in
3020 all the re_search_* functions (bug#8138).
3021
6468f31c
LMI
3022 * keyboard.c (Fopen_dribble_file): Document when the file is
3023 closed (bug#8056).
3024
c965adc5
EZ
30252011-07-14 Eli Zaretskii <eliz@gnu.org>
3026
df9733bf
EZ
3027 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3028 bidi_cache_idx.
3029
0bb23927
EZ
3030 Support bidi reordering of display and overlay strings.
3031 * xdisp.c (compute_display_string_pos)
3032 (compute_display_string_end): Accept additional argument STRING.
3033 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3034 (reseat_to_string): Initialize bidi_it->string.s and
3035 bidi_it->string.schars.
3036 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3037 NULL (avoids a crash in bidi_paragraph_init).
3038 Initialize itb.string.lstring.
0bb23927
EZ
3039 (init_iterator): Call bidi_init_it only of a valid
3040 buffer position was specified. Initialize paragraph_embedding to
3041 L2R.
3042 (reseat_to_string): Initialize the bidi iterator.
3043 (display_string): If we need to ignore text properties of
3044 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3045 original value of -1 will not work with bidi.)
3046 (compute_display_string_pos): First arg is now struct
3047 `text_pos *'; all callers changed. Support display properties on
3048 Lisp strings.
3049 (compute_display_string_end): Support display properties on Lisp
3050 strings.
3051 (init_iterator, reseat_1, reseat_to_string): Initialize the
3052 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3053 when iterating on a string not from display properties).
640c8776
SM
3054 (compute_display_string_pos, compute_display_string_end):
3055 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3056 arrow keys.
3057 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3058 base_level_stop; instead, set base_level_stop to BEGV.
3059 Fixes crashes in vertical-motion.
0bb23927
EZ
3060 (next_element_from_buffer): Improve commentary for when
3061 the iterator is before prev_stop.
3062 (init_iterator): Initialize bidi_p from the default value of
3063 bidi-display-reordering, not from buffer-local value. Use the
3064 buffer-local value only if initializing for buffer iteration.
3065 (handle_invisible_prop): Support invisible properties on strings
3066 that are being bidi-reordered.
3067 (set_iterator_to_next): Support bidi reordering of C strings and
3068 Lisp strings.
3069 (next_element_from_string): Support bidi reordering of Lisp
3070 strings.
3071 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3072 (display_string): Support display of R2L glyph rows.
3073 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3074 (init_iterator): Don't initialize it->bidi_p for strings
3075 here.
3076 (reseat_to_string): Initialize it->bidi_p for strings here.
3077 (next_element_from_string, next_element_from_c_string)
3078 (next_element_from_buffer): Add xassert's for correspondence
3079 between IT's object being iterated and it->bidi_it.string
3080 structure.
3081 (face_before_or_after_it_pos): Support bidi iteration.
3082 (next_element_from_c_string): Handle the case of the first string
3083 character that is not the first one in the visual order.
3084 (get_visually_first_element): New function, refactored from common
3085 parts of next_element_from_buffer, next_element_from_string, and
3086 next_element_from_c_string.
3087 (tool_bar_lines_needed, redisplay_tool_bar)
3088 (display_menu_bar): Force left-to-right direction. Add a FIXME
3089 comment for making that be controlled by a user option.
3090 (push_it, pop_it): Save and restore the state of the
3091 bidi iterator. Save and restore the bidi_p flag.
3092 (pop_it): Iterate out of display property for string iteration as
3093 well.
3094 (iterate_out_of_display_property): Support iteration over strings.
3095 (handle_single_display_spec): Set up it->bidi_it for iteration
3096 over a display string, and call bidi_init_it.
3097 (handle_single_display_spec, next_overlay_string)
3098 (get_overlay_strings_1, push_display_prop): Set up the bidi
3099 iterator for displaying display or overlay strings.
3100 (forward_to_next_line_start): Don't use the shortcut if
3101 bidi-iterating.
3102 (back_to_previous_visible_line_start): If handle_display_prop
3103 pushed the iterator stack, restore the internal state of the bidi
3104 iterator by calling bidi_pop_it same number of times.
3105 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3106 and we are bidi-iterating, don't decrement the iterator position;
3107 instead, set the first_elt flag in the bidi iterator, to produce
3108 the same effect.
3109 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3110 (push_display_prop): xassert that we are iterating a buffer.
3111 (push_it, pop_it): Save and restore paragraph_embedding member.
3112 (handle_single_display_spec, next_overlay_string)
3113 (get_overlay_strings_1, reseat_1, reseat_to_string)
3114 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3115 correctly. Don't assume unibyte strings are not bidi-reordered.
3116 (compute_display_string_pos)
3117 (compute_display_string_end): Fix handling the case of C string.
3118 (push_it, pop_it): Save and restore from_disp_prop_p.
3119 (handle_single_display_spec, push_display_prop): Set the
3120 from_disp_prop_p flag.
3121 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3122 (pop_it): Call iterate_out_of_display_property only if we are
3123 popping after iteration over a string that came from a display
3124 property. Fix a typo in popping stretch info. Add an assertion
3125 for verifying that the iterator position is in sync with the bidi
3126 iterator.
3127 (handle_single_display_spec, get_overlay_strings_1)
3128 (push_display_prop): Fix initialization of paragraph direction for
3129 string when that of the parent object is not yet determined.
3130 (reseat_1): Call bidi_init_it to resync the bidi
3131 iterator with IT's position. (Bug#7616)
3132 (find_row_edges): If ROW->start.pos gives position
3133 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3134 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3135 Reset the from_disp_prop_p flag.
3136 (SAVE_IT, RESTORE_IT): New macros.
3137 (pos_visible_p, face_before_or_after_it_pos)
3138 (back_to_previous_visible_line_start)
3139 (move_it_in_display_line_to, move_it_in_display_line)
3140 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3141 (try_scrolling, redisplay_window, display_line): Use them when
3142 saving a temporary copy of the iterator and restoring it back.
3143 (back_to_previous_visible_line_start, reseat_1)
3144 (init_iterator): Empty the bidi cache "stack".
3145 (move_it_in_display_line_to): If iterator ended up at
3146 EOL, but we never saw any buffer positions smaller than
3147 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3148 motion in bidi-reordered lines.
3149 (move_it_in_display_line_to): Record prev_method and prev_pos
3150 immediately before the call to set_iterator_to_next. Fixes cursor
3151 motion in bidi-reordered lines with stretch glyphs and strings
3152 displayed in margins. (Bug#8133) (Bug#8867)
3153 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3154 TO_CHARPOS.
640c8776
SM
3155 (pos_visible_p): Support positions in bidi-reordered lines.
3156 Save and restore bidi cache.
0bb23927
EZ
3157
3158 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3159 (bidi_paragraph_info): Delete unused struct.
3160 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3161 (bidi_cache_start): New variable.
3162 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3163 to zero.
3164 (bidi_cache_fetch_state, bidi_cache_search)
3165 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3166 (bidi_cache_find, bidi_peek_at_next_level)
3167 (bidi_level_of_next_char, bidi_find_other_level_edge)
3168 (bidi_move_to_visually_next): Compare cache index with
3169 bidi_cache_start rather than with zero.
3170 (bidi_fetch_char): Accept new argument STRING; all callers
3171 changed. Support iteration over a string. Support strings with
3172 display properties. Support unibyte strings. Fix the type of
3173 `len' according to what STRING_CHAR_AND_LENGTH expects.
3174 (bidi_paragraph_init, bidi_resolve_explicit_1)
3175 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3176 (bidi_level_of_next_char, bidi_move_to_visually_next):
3177 Support iteration over a string.
0bb23927
EZ
3178 (bidi_set_sor_type, bidi_resolve_explicit_1)
3179 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3180 can now be zero (for strings); special values 0 and -1 were
3181 changed to -1 and -2, respectively.
3182 (bidi_char_at_pos): New function.
3183 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3184 Call it instead of FETCH_MULTIBYTE_CHAR.
3185 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3186 initialized to valid values.
3187 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3188 values.
3189 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3190 the test for valid cached positions. Fix the logic for looking up
3191 the sentinel state in the cache. GCPRO the Lisp string we are
3192 iterating.
3193 (bidi_push_it, bidi_pop_it): New functions.
3194 (bidi_initialize): Initialize the bidi cache start stack pointer.
3195 (bidi_cache_ensure_space): New function, refactored from part of
3196 bidi_cache_iterator_state. Don't assume the required size is just
3197 one BIDI_CACHE_CHUNK away.
3198 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3199 (bidi_count_bytes, bidi_char_at_pos): New functions.
3200 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3201 always valid if bidi_cache_idx is valid.
3202 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3203 is valid if it's going to be used.
3204 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3205 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3206 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3207 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3208 (bidi_find_other_level_edge, bidi_cache_start_stack):
3209 All variables related to cache indices are now EMACS_INT.
c965adc5 3210
0bb23927
EZ
3211 * dispextern.h (struct bidi_string_data): New structure.
3212 (struct bidi_it): New member `string'. Make flag members be 1-bit
3213 fields, and put them last in the struct.
640c8776
SM
3214 (compute_display_string_pos, compute_display_string_end):
3215 Update prototypes.
0bb23927
EZ
3216 (bidi_push_it, bidi_pop_it): Add prototypes.
3217 (struct iterator_stack_entry): New members bidi_p,
3218 paragraph_embedding, and from_disp_prop_p.
3219 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3220 (bidi_shelve_cache, bidi_unshelve_cache):
3221 Declare prototypes.
0bb23927
EZ
3222
3223 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3224 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3225 and vector-like objects.
3226
3227 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3228 cache around display iteration.
3229
3230 * window.c (Fwindow_end, window_scroll_pixel_based)
3231 (displayed_window_lines, Frecenter): Save and restore the bidi
3232 cache around display iteration.
3233
3bbd2265
LMI
32342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3235
3236 * editfns.c (Fdelete_region): Clarify the use of the named
3237 parameters (bug#6788).
3238
adc47434
MR
32392011-07-14 Martin Rudalics <rudalics@gmx.at>
3240
3241 * indent.c (Fvertical_motion): Set and restore w->pointm when
3242 saving and restoring the window's buffer (Bug#9006).
3243
837c31f8
LMI
32442011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3245
3246 * editfns.c (Fstring_to_char): Clarify just what is returned
3247 (bug#6576). Text by Eli Zaretskii.
3248
ac389d0c
JB
32492011-07-13 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3252
0be0ce47
EZ
32532011-07-13 Eli Zaretskii <eliz@gnu.org>
3254
3255 * buffer.c (mmap_find): Fix a typo.
3256
cd18e7e3
JB
32572011-07-13 Johan Bockgård <bojohan@gnu.org>
3258
3259 Fix execution of x selection hooks.
3260 * xselect.c (Qx_lost_selection_functions)
3261 (Qx_sent_selection_functions): New vars.
3262 (syms_of_xselect): DEFSYM them.
3263 (x_handle_selection_request): Pass Qx_sent_selection_functions
3264 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3265 (x_handle_selection_clear,x_clear_frame_selections):
3266 Pass Qx_lost_selection_functions rather than
3267 Vx_lost_selection_functions to Frun_hook_with_args.
3268
47ea7f44
PE
32692011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3270
ac389d0c 3271 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3272 The old code sometimes used this field without initializing it.
3273
47ea7f44
PE
3274 * alloc.c (gc_sweep): Don't read past end of array.
3275 In theory, the old code could also have corrupted Emacs internals,
3276 though it'd be very unlikely.
3277
bc985c87
AS
32782011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3279
3280 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3281 argument. (Bug#4026)
bc985c87 3282
0cf34688
LMI
32832011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3284
b3dadd76
LMI
3285 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3286 key" (bug#4257).
3287
0cf34688
LMI
3288 * window.c (Fset_window_start): Doc fix (bug#4199).
3289 (Fset_window_hscroll): Ditto.
3290
270768cd
PE
32912011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3292
077e3dda 3293 Fix minor new problems caught by GCC 4.6.1.
270768cd 3294 * term.c (init_tty): Remove unused local.
490011a6 3295 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3296 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3297 not used otherwise.
270768cd 3298
b1f58454
CY
32992011-07-12 Chong Yidong <cyd@stupidchicken.com>
3300
3301 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3302
22b9578d
LMI
33032011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3304
6e70ab07
LMI
3305 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3306 are the mini-buffer and the echo area (bug#3320).
3307
22b9578d
LMI
3308 * term.c (init_tty): Remove support for supdup, c10 and perq
3309 terminals, which are no longer supported (bug#1482).
3310
8974cc9f
JB
33112011-07-10 Johan Bockgård <bojohan@gnu.org>
3312
3313 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3314
a560d974
JD
33152011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3316
3317 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3318 for non-popups (Bug#3642).
3319
1dae0f0a
AS
33202011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3321
268c2c36 3322 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3323 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3324 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3325 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3326 * data.c (fmod): Likewise.
3327 * dispnew.c (swap_glyphs_in_rows): Likewise.
3328 * emacs.c (memory_warning_signal): Likewise.
3329 * floatfns.c (float_error): Likewise.
3330 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3331 (otf_open, font_otf_capability, generate_otf_features)
3332 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3333 Likewise.
3334 * image.c (pbm_read_file): Likewise.
3335 * indent.c (string_display_width): Likewise.
3336 * intervals.c (check_for_interval, search_for_interval)
3337 (inc_interval_count, count_intervals, root_interval)
3338 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3339 * lread.c (defalias): Likewise.
268c2c36 3340 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3341 * regex.c (set_image_of_range_1, set_image_of_range)
3342 (regex_grow_registers): Likewise.
3343 * sysdep.c (strerror): Likewise.
3344 * termcap.c (valid_filename_p, tprint, main): Likewise.
3345 * tparam.c (main): Likewise.
3346 * unexhp9k800.c (run_time_remap, save_data_space)
3347 (update_file_ptrs, read_header, write_header, calculate_checksum)
3348 (copy_file, copy_rest, display_header): Likewise.
3349 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3350 Likewise.
3351 * xdisp.c (check_it): Likewise.
3352 * xfaces.c (register_color, unregister_color, unregister_colors):
3353 Likewise.
3354 * xfns.c (print_fontset_result): Likewise.
3355 * xrdb.c (member, fatal, main): Likewise.
3356
99033785
PE
33572011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3358
3359 Fix minor problems found by static checking (Bug#9031).
3360 * chartab.c (char_table_set_range, map_sub_char_table):
3361 Remove unused locals.
3362 (uniprop_table): Now static.
3363 * composite.c (_work_char): Remove unused static var.
3364
9cb2ac56
JB
33652011-07-09 Juanma Barranquero <lekktu@gmail.com>
3366
3367 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3368
f25661f0
JD
33692011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3370
3371 * gtkutil.c (qttip_cb): Remove code without function.
3372
8278c4fe
EZ
33732011-07-09 Eli Zaretskii <eliz@gnu.org>
3374
3375 * w32.c (pthread_sigmask): New stub.
3376
1692ae2d 33772011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3378
8a6ebd58 3379 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3380 sigprocmask is portable only for single-threaded applications, and
3381 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3382 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3383 (LIBES): Use it.
3384 * callproc.c (Fcall_process):
3385 * process.c (create_process):
3386 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3387 Use pthread_sigmask, not sigprocmask.
123403e4 3388
1b854618
JD
33892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3390
3391 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3392 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3393 wrong (Bug#8591).
3394
3fe4b549
JD
33952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3396
0ce7e563
JD
3397 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3398 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3399 (xg_hide_tooltip): Fix comment.
3400
3fe4b549
JD
3401 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3402 in registerServicesMenuSendTypes.
3403 (validRequestorForSendType): Don't check ns_return_types.
3404
3405 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3406 ns_return_type.
3407
5df75e47
JR
34082011-07-08 Jason Rumney <jasonr@gnu.org>
3409
22610910
JR
3410 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3411 SH_SHOW for hidden windows (Bug#5482).
3412
5df75e47
JR
3413 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3414 frame struct members of non-existent frames (Bug#6284).
3415
699c10bd
JD
34162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3417
4393663b
JD
3418 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3419 variable firstTime not needed on OSX >= 10.6.
3420 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3421 >= 10.5. Use setKnobProportion, setDoubleValue.
3422
3423 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3424 (MAC_OS_X_VERSION_10_5): Define if not defined.
3425 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3426 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3427 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3428
3429 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3430 cString and lossyCString on OSX >= 10.4
3431
58179cce 3432 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3433 sizeToFit on OSX >= 10.2.
3434
3435 * nsimage.m (allocInitFromFile): Don't use deprecated method
3436 bestRepresentationForDevice on OSX >= 10.6.
3437
3438 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3439 to avoid warning.
3440
3441 * emacs.c: Declare unexec_init_emacs_zone.
3442
a63e0781
JD
3443 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3444
699c10bd
JD
3445 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3446
3447 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3448 on svcsMenu (Bug#8842).
3449
3450 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3451 ns_return_types.
3452 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3453
3454 * nsterm.m (QUTF8_STRING): Declare.
3455 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3456 (validRequestorForSendType): Return type is (id).
3457 Change indexOfObjectIdenticalTo to indexOfObject.
3458 Check if we have local selection before returning self (Bug#8842).
3459 (writeSelectionToPasteboard): Put local selection into paste board
3460 if we have a local selection (Bug#8842).
3461 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3462
3463 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3464 (ns_get_local_selection): Declare.
3465
54e10184
LMI
34662011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3467
9888ff71
LMI
3468 * keymap.c (describe_map_tree): Don't insert a double newline at
3469 the end of the buffer (bug#1169) and return whether we inserted
3470 something.
3471
54e10184
LMI
3472 * callint.c (Fcall_interactively): Change "reading args" to
3473 "providing args" to try to clarify what it does (bug#1010).
3474
15fa4783
KH
34752011-07-07 Kenichi Handa <handa@m17n.org>
3476
3477 * composite.c (composition_compute_stop_pos): Ignore a static
3478 composition starting before CHARPOS (Bug#8915).
3479
3480 * xdisp.c (handle_composition_prop): Likewise.
3481
a8815b00
EZ
34822011-07-07 Eli Zaretskii <eliz@gnu.org>
3483
3484 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3485 (Bug#9015)
3486
ef7b981d 34872011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3488
3489 * character.h (unicode_category_t): New enum type.
3490
3491 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3492 (Qchar_code_property_table): New variable.
3493 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3494 (UNIPROP_COMPRESSED_FORM_P): New macros.
3495 (char_table_ascii): Uncompress the compressed values.
3496 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3497 Uncompress the compressed values.
ac389d0c 3498 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3499 (char_table_ref_and_range): Uncompress the compressed values.
3500 (sub_char_table_set): New arg is_uniprop. Callers changed.
3501 Uncompress the compressed values.
3502 (sub_char_table_set_range): Args changed. Callers changed.
3503 (char_table_set_range): Adjuted for the above change.
3504 (map_sub_char_table): Delete args default_val and parent. Add arg
3505 top. Give decoded values to a Lisp function.
640c8776 3506 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3507 values to a Lisp function. Gcpro more variables.
3508 (uniprop_table_uncompress)
3509 (uniprop_decode_value_run_length): New functions.
3510 (uniprop_decoder, uniprop_decoder_count): New variables.
3511 (uniprop_get_decoder, uniprop_encode_value_character)
3512 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3513 New functions.
3514 (uniprop_encoder, uniprop_encoder_count): New variables.
3515 (uniprop_get_encoder, uniprop_table)
3516 (Funicode_property_table_internal, Fget_unicode_property_internal)
3517 (Fput_unicode_property_internal): New functions.
3518 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3519 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3520 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3521 char-code-property-alist.
3522
640c8776 3523 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3524 Vunicode_category_table.
3525
640c8776 3526 * font.c (font_range): Adjust for the change of
c805dec0
KH
3527 Vunicode_category_table.
3528
76b397fb
DN
35292011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3530
3531 * m/iris4d.h: Remove file, move contents ...
3532 * s/irix6-5.h: ... here.
3533
22b4128e
PE
35342011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3537 * alloc.c (mark_buffer):
3538 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3539 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3540 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3541 This isn't true in general, and it's particularly not true
3542 if Emacs is configured with --with-wide-int.
3543 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3544 New macros, used in the buffer.c change.
3545
869795d6
JD
35462011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3547
3548 * xsettings.c: Use both GConf and GSettings if both are available.
3549 (store_config_changed_event): Add comment.
3550 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3551 (store_tool_bar_style_changed): New functions.
5e617bc2 3552 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3553 (struct xsettings): Move font inside HAVE_XFT.
3554 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3555 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3556 Move inside HAVE_XFT.
640c8776 3557 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3558 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3559 also.
3560 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3561 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3562 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3563 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3564 (parse_settings): Move check for font inside HAVE_XFT.
3565 (read_settings, apply_xft_settings): Add comment.
3566 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3567 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3568 call store_font_name_changed.
3569 (xft_settings_event): Add comment.
3570 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3571 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3572 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3573 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3574 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3575 (xsettings_get_system_font, xsettings_get_system_normal_font):
3576 Add comment.
869795d6 3577
d8ed26bd
PE
35782011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3579
3580 Random fixes. E.g., (random) never returned negative values.
3581 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3582 subseconds part to the entropy, as that's a bit more random.
3583 Prefer signed to unsigned, since the signedness doesn't matter and
3584 in general we prefer signed. When given a limit, use a
3585 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3586 latter isn't right if USE_2_TAGS_FOR_INTS.
3587 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3588 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3589
cabf1cac
SM
35902011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3591
3592 * textprop.c (text_property_stickiness):
3593 Obey Vtext_property_default_nonsticky.
3594 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3595 * w32fns.c (syms_of_w32fns):
3596 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3597
6e9b2be9
PE
35982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3601 This is more efficient than Ffile_directory_p and avoids a minor race.
3602
90186c68
LMI
36032011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3604
7c301272
LMI
3605 * buffer.c (Foverlay_put): Say what the return value is
3606 (bug#7835).
3607
c4f2d8d4
LMI
3608 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3609 is a directory before asking whether to use the file name
3610 (bug#7564).
ad637907
LMI
3611 (barf_or_query_if_file_exists): Make the "File is a directory"
3612 error be more correct.
c4f2d8d4 3613
90186c68
LMI
3614 * fns.c (Frequire): Remove the mention of the .gz files, since
3615 that's installation-specific, but keep the mention of
3616 `get-load-suffixes'.
3617
da64016e
PE
36182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3621 Report string overflow if the output is too long.
3622
7d47b580
JB
36232011-07-04 Juanma Barranquero <lekktu@gmail.com>
3624
a555cb87
JB
3625 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3626 (syms_of_gnutls): Remove duplicate DEFSYM for
3627 Qgnutls_bootprop_verify_hostname_error, an error for
3628 Qgnutls_bootprop_verify_error (which is no longer used).
3629
7d47b580
JB
3630 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3631 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3632 Also (re)move comments that are misplaced or no longer relevant.
3633
1e49bfab
LMI
36342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3635
3636 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3637
1485f4c0
CY
36382011-07-03 Chong Yidong <cyd@stupidchicken.com>
3639
3640 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3641 and background color parameters if they have been changed.
3642
a9ab721e
LMI
36432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3644
3645 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3646
cf7cff57
PE
36472011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3648
2e13213d
PE
3649 * xsettings.c (SYSTEM_FONT): Define only when used.
3650 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3651
cf7cff57
PE
3652 * keymap.c (access_keymap_1): Now static.
3653
7a8e04f7
CY
36542011-07-02 Chong Yidong <cyd@stupidchicken.com>
3655
3656 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3657 leave any prefix arg for the up event (Bug#1586).
3658
61352f62
LMI
36592011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3660
69bb1ef7
LMI
3661 * lread.c (syms_of_lread): Mention single symbols defined by
3662 `defvar' or `defconst' (bug#7154).
3663
61352f62 3664 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3665 (Frequire): Mention get-load-suffixes.
61352f62 3666
28545e04
MR
36672011-07-02 Martin Rudalics <rudalics@gmx.at>
3668
3669 * window.h (window): Remove clone_number slot.
3670 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3671 Remove.
3672 (make_parent_window, make_window, saved_window)
3673 (Fset_window_configuration, save_window_save): Don't deal with
3674 clone numbers.
3675 * buffer.c (Qclone_number): Remove declaration.
3676 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3677
3349e122
SM
36782011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3679
3680 Add multiple inheritance to keymaps.
3681 * keymap.c (Fmake_composed_keymap): New function.
3682 (Fset_keymap_parent): Simplify.
3683 (fix_submap_inheritance): Remove.
3684 (access_keymap_1): New function extracted from access_keymap to handle
3685 embedded parents and handle lists of maps.
3686 (access_keymap): Use it.
3687 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3688 (Fcopy_keymap): Handle embedded parents.
3689 (Fcommand_remapping, define_as_prefix): Simplify.
3690 (Fkey_binding): Simplify.
3691 (syms_of_keymap): Move minibuffer-local-completion-map,
3692 minibuffer-local-filename-completion-map,
3693 minibuffer-local-must-match-map, and
3694 minibuffer-local-filename-must-match-map to Elisp.
3695 (syms_of_keymap): Defsubr make-composed-keymap.
3696 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3697 (parse_menu_item): Trivial simplification.
3698
3279eb87
GM
36992011-07-01 Glenn Morris <rgm@gnu.org>
3700
3701 * Makefile.in (SETTINGS_LIBS): Fix typo.
3702
4550efdf
KI
37032011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3704
3705 * coding.c (Fencode_coding_string): Record the last coding system
3706 used, as the function doc string says (bug#8738).
3707
0949d2b6
JD
37082011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3709
3710 * xsettings.c (store_monospaced_changed): Take new font as arg and
3711 check for change against current_mono_font.
3712 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3713 (emacs_settings_constructor, emacs_settings_get_property)
3714 (emacs_settings_set_property, emacs_settings_class_init)
3715 (emacs_settings_init, gsettings_obj): Remove.
3716 (something_changedCB): New function for HAVE_GSETTINGS.
3717 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3718 with value as argument.
3719 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3720 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3721 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3722 "changed".
3723
3724 * xgselect.c: Add defined (HAVE_GSETTINGS).
3725 (xgselect_initialize): Ditto.
3726
3727 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3728 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3729 xg_select.
3730
bbc6b304
PE
37312011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 * eval.c (struct backtrace): Simplify and port the data structure.
3734 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3735 signed bit field, as this assumption is not portable and it makes
3736 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3737 "char debug_on_exit : 1" as this is not portable either; instead,
3738 use the portable "unsigned int debug_on_exit : 1". Remove unused
3739 member evalargs. Remove obsolete comments about cc bombing out.
3740
9851bfc5
JD
37412011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3742
51bb811f 3743 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3744 Let HAVE_GSETTINGS override HAVE_GCONF.
3745 (store_monospaced_changed): New function.
3746 (EMACS_SETTINGS): A new type derived from GObject to handle
3747 GSettings notifications.
3748 (emacs_settings_constructor, emacs_settings_get_property)
3749 (emacs_settings_set_property, emacs_settings_class_init):
3750 New functions.
3751 (gsettings_client, gsettings_obj): New variables.
3752 (GSETTINGS_SCHEMA): New define.
3753 (something_changedCB): Call store_monospaced_changed.
3754 (init_gsettings): New function.
3755 (xsettings_initialize): Call init_gsettings.
3756 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3757 to NULL.
3758
640c8776 3759 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3760 GCONF_CFLAGS/LIBS.
3761
5386012d
MR
37622011-06-29 Martin Rudalics <rudalics@gmx.at>
3763
3764 * window.c (resize_root_window, grow_mini_window)
3765 (shrink_mini_window): Rename Qresize_root_window to
3766 Qwindow_resize_root_window and Qresize_root_window_vertically to
3767 Qwindow_resize_root_window_vertically.
3768
f13e0b08
PE
37692011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3770
3771 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3772
94515237
JB
37732011-06-27 Juanma Barranquero <lekktu@gmail.com>
3774
3775 * makefile.w32-in: Redesign dependencies so they reflect more
3776 clearly which files are directly included by each source file,
3777 and not through other includes.
3778
e43b6e43
MR
37792011-06-27 Martin Rudalics <rudalics@gmx.at>
3780
3781 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3782 (sort_overlays, overlay_strings): When an overlay's clone number
3783 matches the window's clone number process the overlay even if
3784 the overlay's window property doesn't match the current window.
3785
d68443dc
MR
3786 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3787 (Fwindow_hchild): Rename to Fwindow_left_child.
3788 (Fwindow_next): Rename to Fwindow_next_sibling.
3789 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3790 (resize_window_check): Rename to window_resize_check.
3791 (resize_window_apply): Rename to window_resize_apply.
3792 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3793 (Fdelete_other_windows_internal, resize_frame_windows)
3794 (Fsplit_window_internal, Fdelete_window_internal)
3795 (grow_mini_window, shrink_mini_window)
3796 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3797
c7e73be5
JD
37982011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3799
3800 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3801 (emacs_fixed_set_min_size): Remove.
3802 (emacs_fixed_new): Take frame as argument.
3803
3804 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3805 (_EmacsFixedPrivate): Remove minwidth/height.
3806 Add struct frame *f.
3807 (emacs_fixed_init): Initialize priv->f.
3808 (get_parent_class, emacs_fixed_set_min_size): Remove.
3809 (emacs_fixed_new): Set priv->f to argument.
3810 (emacs_fixed_get_preferred_width)
3811 (emacs_fixed_get_preferred_height): Use min_width/height from
3812 frames size_hint to set minimum and natural (Bug#8919).
3813 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3814 and use min_width/height from frames size_hint to set
3815 min_width/height (Bug#8919).
3816
3817 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3818 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3819 Fix indentation.
c7e73be5 3820
cf99dcf8
EZ
38212011-06-26 Eli Zaretskii <eliz@gnu.org>
3822
3823 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3824 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3825 called at ZV.
3826
029529ac
CY
38272011-06-26 Chong Yidong <cyd@stupidchicken.com>
3828
3829 * process.c (wait_reading_process_output): Bypass select if
3830 waiting for a cell while ignoring keyboard input, and input is
3831 pending. Suggested by Jan Djärv (Bug#8869).
3832
7a7ef429
PE
38332011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 Use gnulib's dup2 module instead of rolling our own.
3836 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3837
11fdef7d 38382011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3839
3840 * dispnew.c (scrolling_window): Before scrolling, turn off a
3841 mouse-highlight in the window being scrolled.
3842
cd3520a4
JB
38432011-06-24 Juanma Barranquero <lekktu@gmail.com>
3844
3845 Move DEFSYM to lisp.h and use everywhere.
3846
3847 * character.h (DEFSYM): Move declaration...
3848 * lisp.h (DEFSYM): ...here.
3849
3850 * gnutls.c:
3851 * minibuf.c:
3852 * w32menu.c:
3853 * w32proc.c:
3854 * w32select.c: Don't include character.h.
3855
3856 * alloc.c (syms_of_alloc):
3857 * buffer.c (syms_of_buffer):
3858 * bytecode.c (syms_of_bytecode):
3859 * callint.c (syms_of_callint):
3860 * casefiddle.c (syms_of_casefiddle):
3861 * casetab.c (init_casetab_once):
3862 * category.c (init_category_once, syms_of_category):
3863 * ccl.c (syms_of_ccl):
3864 * cmds.c (syms_of_cmds):
3865 * composite.c (syms_of_composite):
3866 * dbusbind.c (syms_of_dbusbind):
3867 * dired.c (syms_of_dired):
3868 * dispnew.c (syms_of_display):
3869 * doc.c (syms_of_doc):
3870 * editfns.c (syms_of_editfns):
3871 * emacs.c (syms_of_emacs):
3872 * eval.c (syms_of_eval):
3873 * fileio.c (syms_of_fileio):
3874 * fns.c (syms_of_fns):
3875 * frame.c (syms_of_frame):
3876 * fringe.c (syms_of_fringe):
3877 * insdel.c (syms_of_insdel):
3878 * keymap.c (syms_of_keymap):
3879 * lread.c (init_obarray, syms_of_lread):
3880 * macros.c (syms_of_macros):
3881 * msdos.c (syms_of_msdos):
3882 * print.c (syms_of_print):
3883 * process.c (syms_of_process):
3884 * search.c (syms_of_search):
3885 * sound.c (syms_of_sound):
3886 * syntax.c (init_syntax_once, syms_of_syntax):
3887 * terminal.c (syms_of_terminal):
3888 * textprop.c (syms_of_textprop):
3889 * undo.c (syms_of_undo):
3890 * w32.c (globals_of_w32):
3891 * window.c (syms_of_window):
3892 * xdisp.c (syms_of_xdisp):
3893 * xfaces.c (syms_of_xfaces):
3894 * xfns.c (syms_of_xfns):
3895 * xmenu.c (syms_of_xmenu):
3896 * xsettings.c (syms_of_xsettings):
3897 * xterm.c (syms_of_xterm): Use DEFSYM.
3898
4228cf16
TZ
38992011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3900
cd3520a4 3901 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3902
7fcccf1e
PE
39032011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3904
7efb4e0e
PE
3905 Integer and buffer overflow fixes (Bug#8873).
3906
ff5844ad
PE
3907 * print.c (printchar, strout): Check for string overflow.
3908 (PRINTPREPARE, printchar, strout):
3909 Don't set size unless allocation succeeds.
3910
90532f02
PE
3911 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3912 for sizes. Check for string overflow more accurately.
3913 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3914
6d84508d
PE
3915 * macros.c: Integer and buffer overflow fixes.
3916 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3917 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3918 Use ptrdiff_t, not int, for sizes.
3919 Don't increment bufsize until after realloc succeeds.
3920 Check for size-calculation overflow.
3921 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3922
437b2cb4
PE
3923 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3924
8b9ac8b4
PE
3925 * lread.c: Integer overflow fixes.
3926 (read_integer): Radix is now EMACS_INT, not int,
3927 to improve quality of diagnostics for out-of-range radices.
3928 Calculate buffer size correctly for out-of-range radices.
3929 (read1): Check for integer overflow in radices, and in
3930 read-circle numbers.
82cb60d3
PE
3931 (read_escape): Avoid int overflow.
3932 (Fload, openp, read_buffer_size, read1)
3933 (substitute_object_recurse, read_vector, read_list, map_obarray):
3934 Use ptrdiff_t, not int, for sizes.
3935 (read1): Use EMACS_INT, not int, for sizes.
20270765 3936 Check for size overflow.
8b9ac8b4 3937
7fcccf1e
PE
3938 * image.c (cache_image): Check for size arithmetic overflow.
3939
bfbbd7e7
PE
3940 * lread.c: Integer overflow issues.
3941 (saved_doc_string_size, saved_doc_string_length)
3942 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3943 Now ptrdiff_t, not int.
3944 (read1): Don't assume doc string length fits in int. Check for
3945 out-of-range doc string lengths.
3946 (read_list): Don't assume file position fits in int.
39019e54 3947 (read_escape): Check for hex character overflow.
bfbbd7e7 3948
4e323265
LL
39492011-06-22 Leo Liu <sdl.web@gmail.com>
3950
3951 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3952 Move to minibuffer.el.
3953
85fece3e
PE
39542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3955
20b84ce9 3956 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3957 The following patches are for when GLYPH_DEBUG && !XASSERT.
3958 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3959 * dispnew.c (flush_stdout):
3960 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3961 Mark as externally visible.
3962 * dispnew.c (check_window_matrix_pointers): Now static.
3963 * dispnew.c (window_to_frame_vpos):
3964 * xfns.c (unwind_create_frame):
3965 * xterm.c (x_check_font): Remove unused local.
3966 * scroll.c (CHECK_BOUNDS):
3967 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3968 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3969 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3970 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3971 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3972 Now static.
3973 (debug_method_add): Use va_list and vsprintf rather than relying
3974 on undefined behavior with wrong number of arguments.
3975 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3976 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3977 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3978 since we're not interested in debugging glyphs with old libraries.
3979 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3980 GCC 4.6.0's static checking.
3981
0766b489
PE
39822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3983
31fd4b32
PE
3984 Integer overflow and signedness fixes (Bug#8873).
3985 A few related buffer overrun fixes, too.
3986
b79e8648
PE
3987 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3988
0766b489
PE
3989 * dispextern.h (struct face.stipple):
3990 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3991 (x_bitmap_mask, x_allocate_bitmap_record)
3992 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3993 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3994 (x_create_bitmap_from_xpm_data):
3995 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3996 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3997 (.bitmaps_last):
3998 * xfaces.c (load_pixmap):
3999 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4000 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4001 (.bitmaps_last, struct x_output.icon_bitmap):
4002 Use ptrdiff_t, not int, for bitmap indexes.
4003 (x_allocate_bitmap_record): Check for size overflow.
4004 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4005
b081724f
PE
4006 Use ptrdiff_t, not int, for overlay counts.
4007 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4008 * editfns.c (overlays_around, get_pos_property):
4009 * textprop.c (get_char_property_and_overlay):
4010 * xdisp.c (next_overlay_change, note_mouse_highlight):
4011 * xfaces.c (face_at_buffer_position):
21514da7
PE
4012 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4013 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4014 (Fnext_overlay_change, Fprevious_overlay_change)
4015 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4016 Use ptrdiff_t, not int, for sizes.
21514da7 4017 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4018
3de73e5e
PE
4019 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4020
2606c57b
PE
4021 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4022 (x_session_initialize): Do not assume string length fits in int.
4023
aaafe47a
PE
4024 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4025 This is unlikely, but can occur if DPI is outlandish.
4026
2674ddc8 4027 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4028 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4029
28154962
PE
4030 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4031 * xrdb.c (magic_file_p, search_magic_path):
4032 Omit last arg SUFFIX; it was always 0. All callers changed.
4033 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4034
7de51af5
PE
4035 * xfont.c (xfont_match): Avoid need for strlen.
4036
25ed6cc3
PE
4037 * xfns.c: Don't assume strlen fits in int.
4038 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4039
4eab31dd
PE
4040 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4041 not unsigned long, as we prefer signed integers. All callers changed.
4042 Detect integer overflow in repeat count.
4043 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4044 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4045
171e2a58
PE
4046 * termcap.c: Don't assume sizes fit in int and never overflow.
4047 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4048 (gobble_line): Check for size-calculation overflow.
4049
ad39faca 4050 * minibuf.c (Fread_buffer):
6e5bb2dc 4051 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4052 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4053 Don't assume string length fits in int.
4054
52c61c22 4055 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4056 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4057
b5b8c9e5
PE
4058 * font.c: Don't assume string length fits in int.
4059 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4060 Use ptrdiff_t, not int.
ccd6111c
PE
4061 (font_intern_prop): Don't assume string length fits in int.
4062 Don't assume integer property fits in fixnum.
4063 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4064
882f0d81 4065 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4066 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4067 Reformulate so as not to need the command string.
4068 Invoke gzip -cd rather than gunzip, as it's more portable.
4069 (lock_info_type, lock_file_1, lock_file):
4070 Don't assume pid_t and time_t fit in unsigned long.
4071 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4072 (current_lock_owner): Prefer signed type for sizes.
4073 Use memcpy, not strncpy, where memcpy is what is really wanted.
4074 Don't assume (via atoi) that time_t and pid_t fit in int.
4075 Check for time_t and/or pid_t out of range, e.g., via a network share.
4076 Don't alloca where an auto var works fine.
4077
93f4cf88
PE
4078 * fileio.c: Fix some integer overflow issues.
4079 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4080 Don't assume string length fits in int.
4081 (directory_file_name): Don't assume string length fits in long.
4082 (make_temp_name): Don't assume pid fits in int, or that its print
4083 length is less than 20.
4084
f3e92b69
PE
4085 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4086
1bfdaf10
PE
4087 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4088
35016e9a
PE
4089 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4090
3d1e65a1
PE
4091 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4092 We prefer signed integers, even for size calculations.
4093
0b963a93
PE
4094 * emacs.c: Don't assume string length fits in 'int'.
4095 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4096 (main): Don't invoke strlen when not needed.
4097
573f4b54
PE
4098 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4099 (XD_DEBUG_MESSAGE): Don't waste a byte.
4100
989f33ba
PE
4101 * callproc.c (getenv_internal_1, getenv_internal)
4102 (Fgetenv_internal):
965d34eb
PE
4103 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4104
e4d29b33
PE
4105 * lread.c (invalid_syntax): Omit length argument.
4106 All uses changed. This doesn't fix a bug, but it simplifies the
4107 code away from its former Hollerith-constant appearance, and it's
4108 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4109 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4110
eb49b136
PE
4111 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4112 This didn't break anything, but it didn't help either.
4113 It's confusing to put a bogus integer in a place where the actual
4114 value does not matter.
9f62aeb1 4115 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4116 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4117
15375a22
PE
4118 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4119 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4120 implementation.
b61cc01c
PE
4121 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4122 We prefer signed types, and the value cannot exceed the EMACS_INT
4123 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4124 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4125 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4126 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4127
53b2623d
PE
4128 * indent.c (sane_tab_width): New function.
4129 (current_column, scan_for_column, Findent_to, position_indentation)
4130 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4131 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4132
51cab52b 4133 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4134
f2ed8a70
PE
4135 * lisp.h (lint_assume): New macro.
4136 * composite.c (composition_gstring_put_cache):
4137 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4138
abe80cc6
PE
4139 * editfns.c, insdel.c:
4140 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4141
b02c740e
PE
4142 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4143
ebc96716
PE
4144 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4145
b4e50fa0 4146 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4147 Use much-faster test for byte-length change.
311d5d7c 4148 Don't assume string byte-length fits in 'int'.
a4cf38e4 4149 Check that character arg fits in 'int'.
85461888 4150 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4151
c0c1ee9f
PE
4152 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4153
a498d7f4
PE
4154 * fns.c (concat): Catch string overflow earlier.
4155 Do not rely on integer wraparound.
4156
51cab52b
PE
4157 * dispextern.h (struct it.overlay_strings_charpos)
4158 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4159 * xdisp.c (forward_to_next_line_start)
4160 (back_to_previous_visible_line_start)
4161 (reseat_at_next_visible_line_start, next_element_from_buffer):
4162 Don't arbitrarily truncate the value of 'selective' to int.
4163
76031fad
PE
4164 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4165
5eb55db9
PE
4166 * composite.c: Don't truncate sizes to 'int'.
4167 (composition_gstring_p, composition_reseat_it)
4168 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4169 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4170 not EMACS_UINT, for indexes.
5eb55db9 4171
0703a717
PE
4172 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4173
d6202519
PE
4174 * buffer.c: Include <verify.h>.
4175 (struct sortvec.priority, struct sortstr.priority):
8961a454 4176 Now EMACS_INT, not int.
c20998a7 4177 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4178 (struct sortstr.size, record_overlay_string)
4179 (struct sortstrlist.size, struct sortlist.used):
4180 Don't truncate size to int.
4181 (record_overlay_string): Check for size-calculation overflow.
d6202519 4182 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4183
d5a19415
JM
41842011-06-22 Jim Meyering <meyering@redhat.com>
4185
029529ac 4186 Don't leak an XBM-image-sized buffer
d5a19415
JM
4187 * image.c (xbm_load): Free the image buffer after using it.
4188
a9041e6c
PE
41892011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 Port to Sun C.
4192 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4193 that Sun C diagnosed.
4194 * fns.c (secure_hash): Fix pointer signedness issue.
4195 * intervals.c (static_offset_intervals): New function.
4196 (offset_intervals): Use it.
4197
7f3f739f
LL
41982011-06-21 Leo Liu <sdl.web@gmail.com>
4199
4200 * deps.mk (fns.o):
4201 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4202 sha512.h.
4203
4204 * fns.c (secure_hash): Rename from crypto_hash_function and change
4205 the first arg to accept symbols.
5b66d427 4206 (Fsecure_hash): New primitive.
7f3f739f
LL
4207 (syms_of_fns): New symbols.
4208
76147d94
DD
42092011-06-20 Deniz Dogan <deniz@dogan.se>
4210
4211 * process.c (Fset_process_buffer): Clarify return value in
4212 docstring.
4213
7d7d0045
CY
42142011-06-18 Chong Yidong <cyd@stupidchicken.com>
4215
4216 * dispnew.c (add_window_display_history): Use BVAR.
4217
4218 * xdisp.c (debug_method_add): Use BVAR.
4219 (check_window_end, dump_glyph_matrix, dump_glyph)
4220 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4221
4222 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4223 Likewise.
4224
4225 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4226 check till after the cache is created in init_frame_faces.
4227
ff2bc410
SM
42282011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4229
4230 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4231
28177add
PE
42322011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4233
dd3482fe
PE
4234 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4235 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4236 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4237
393d71f3 4238 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4239 * fileio.c (Finsert_file_contents):
4240 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4241 Remove the old (too-loose) buffer overflow checks.
4242 They weren't needed, since make_gap checks for buffer overflow.
4243 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4244 The old code merely checked for Emacs fixnum overflow, and relied
4245 on undefined (wraparound) behavior. The new code avoids undefined
4246 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4247
2e6813b0 4248 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4249 Tune. Don't use wider integers than needed. Don't use alloca.
4250 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4251
599a9e4f
PE
4252 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4253
99561444
PE
4254 * insdel.c, lisp.h (buffer_overflow): New function.
4255 (insert_from_buffer_1, replace_range, replace_range_2):
4256 * insdel.c (make_gap_larger):
4257 * editfns.c (Finsert_char):
4258 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4259
28177add
PE
4260 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4261
e69dafad
PE
42622011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4263
a7af7fde 4264 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4265
b1c46f02
PE
4266 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4267 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4268
e69dafad
PE
4269 * fileio.c: Don't assume EMACS_INT fits in off_t.
4270 (emacs_lseek): New static function.
4271 (Finsert_file_contents, Fwrite_region): Use it.
4272 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4273
566684ea
PE
4274 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4275
e6966cd6
PE
4276 * fns.c: Don't overflow int when computing a list length.
4277 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4278 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4279 truncation on 64-bit hosts. Check for QUIT every
4280 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4281 faster and is responsive enough.
4282 (Flength): Report an error instead of overflowing an integer.
4283 (Fsafe_length): Return a float if the value is not representable
4284 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4285 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4286 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4287
dd0b0efb
PE
4288 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4289 (header_size, word_size): New constants.
4290 (allocate_vectorlike): Don't check size overflow here.
4291 (allocate_vector): Check it here instead, since this is the only
4292 caller of allocate_vectorlike that could cause overflow.
4293 Check that the new vector's length is representable as a fixnum.
4294
86fe5cfe
PE
4295 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4296 The previous code was bogus. For example, next_almost_prime (32)
4297 returned 39, which is undesirable as it is a multiple of 3; and
4298 next_almost_prime (24) returned 25, which is a multiple of 5 so
4299 why was the code bothering to check for multiples of 7?
4300
80e88859
PE
4301 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4302
4a2f0ad6
PE
4303 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4304
f66c7cf8
PE
4305 Variadic C functions now count arguments with ptrdiff_t.
4306 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4307 Back then I didn't know that the Emacs coding style prefers signed int.
4308 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4309 were being counted with int, which may truncate counts on 64-bit
4310 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4311 * lisp.h (struct Lisp_Subr.function.aMANY)
4312 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4313 Arg counts are now ptrdiff_t, not size_t.
4314 All variadic functions and their callers changed accordingly.
4315 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4316 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4317 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4318 * callint.c (Fcall_interactively): Check arg count for overflow,
4319 to avoid potential buffer overrun. Use signed char, not 'int',
4320 for 'varies' array, so that we needn't bother to check its size
4321 calculation for overflow.
4322 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4323 * eval.c (apply_lambda):
4324 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4325 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4326 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4327
a1759b76
PE
4328 * callint.c (Fcall_interactively): Don't use index var as event count.
4329
d96be9fc
PE
4330 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4331 * mem-limits.h (SIZE): Remove; no longer used.
4332
a690a978 4333 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4334
578c21e6
PE
4335 Remove unnecessary casts.
4336 * xterm.c (x_term_init):
4337 * xfns.c (x_set_border_pixel):
4338 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4339 These aren't needed now that we assume ANSI C.
4340
96f53c6c
PE
4341 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4342 It's more likely to cause problems (due to unsigned overflow)
4343 than to cure them.
4344
83c77d31
PE
4345 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4346
ee2079f1
PE
4347 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4348
6da65536
PE
4349 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4350
7147c4a4
PE
4351 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4352
193e32d9
PE
4353 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4354
e5533da6
PE
4355 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4356
9910e595
PE
4357 GLYPH_CODE_FACE returns EMACS_INT, not int.
4358 * dispextern.h (merge_faces):
4359 * xfaces.c (merge_faces):
01103c44
PE
4360 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4361 Don't assume EMACS_INT fits in int.
9910e595 4362
2638320e
PE
4363 * character.h (CHAR_VALID_P): Remove unused parameter.
4364 * fontset.c, lisp.h, xdisp.c: All uses changed.
4365
045eb8d9
PE
4366 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4367
c1f134b5
PE
4368 * fns.c (concat): Minor tuning based on overflow analysis.
4369 This doesn't fix any bugs. Use int to hold character, instead
4370 of constantly refetching from Emacs object. Use XFASTINT, not
4371 XINT, for value known to be a character. Don't bother comparing
4372 a single byte to 0400, as it's always less.
4373
395fcb93 4374 * floatfns.c (Fexpt):
327eeec8
PE
4375 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4376
abbd3d23
PE
4377 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4378 for characters.
4379
684a03ef
PE
4380 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4381
0fed43f3
PE
4382 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4383 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4384 incorrectly succeed when S was a string, because 4294967386 was
4385 truncated before it was used.
4386
8fd02eb7
PE
4387 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4388 Otherwise, an out-of-range integer could cause undefined behavior
4389 on a 64-bit host.
4390
f8c86b69
PE
4391 * composite.c: Use int, not EMACS_INT, for characters.
4392 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4393 EMACS_INT, for values that are known to be in character range.
4394 This doesn't fix any bugs but is the usual style inside Emacs and
4395 may generate better code on 32-bit machines.
4396
34206dd2
PE
4397 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4398 This is for reasons similar to the recent CHAR_STRING fix.
4399 * charset.c (Fencode_char): Check that character arg is actually
4400 a character. Pass an int to ENCODE_CHAR.
4401 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4402 wider than 'int', as a compile-time check to prevent future regressions
4403 in this area.
4404
c5958d4c 4405 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4406
4407 Make sure a 64-bit char is never passed to CHAR_STRING.
4408 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4409 by silently ignoring the top 32 bits, allowing some values
4410 that were far too large to be valid characters.
4411 * character.h: Include <verify.h>.
4412 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4413 arguments are no wider than unsigned, as a compile-time check
4414 to prevent future regressions in this area.
4415 * data.c (Faset):
01103c44 4416 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4417 (Fsubst_char_in_region):
4418 * fns.c (concat):
4419 * xdisp.c (decode_mode_spec_coding):
4420 Adjust to CHAR_STRING's new requirement.
4421 * editfns.c (Finsert_char, Fsubst_char_in_region):
4422 * fns.c (concat): Check that character args are actually
4423 characters. Without this test, these functions did the wrong
4424 thing with wildly out-of-range values on 64-bit hosts.
4425
d37ca623
PE
4426 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4427 These casts should not be needed on 32-bit hosts, either.
4428 * keyboard.c (read_char):
4429 * lread.c (Fload): Remove casts to unsigned.
4430
ea204efb
PE
4431 * lisp.h (UNSIGNED_CMP): New macro.
4432 This fixes comparison bugs on 64-bit hosts.
4433 (ASCII_CHAR_P): Use it.
4434 * casefiddle.c (casify_object):
01103c44 4435 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4436 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4437 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4438 * dispextern.h (FACE_FROM_ID):
4439 * keyboard.c (read_char): Use UNSIGNED_CMP.
4440
41cb286c
PE
4441 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4442 not to EMACS_INT, to avoid GCC warning.
4443
4a1b9832
PE
4444 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4445
55daad71
PE
4446 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4447 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4448 isn't needed on 32-bit machines.
8f95c75c 4449
01103c44
PE
4450 * buffer.c (Fgenerate_new_buffer_name):
4451 Use EMACS_INT for count, not int.
0ceccced 4452 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4453
4454 * data.c (Qcompiled_function): Now static.
4455
c6f072e7
PE
4456 * window.c (window_body_lines): Now static.
4457
20ce5912
PE
4458 * image.c (gif_load): Rename local to avoid shadowing.
4459
9c4c5f81
PE
4460 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4461 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4462 * alloc.c (make_save_value): Integer argument is now of type
4463 ptrdiff_t, not int.
4464 (mark_object): Use ptrdiff_t, not int.
4465 * lisp.h (pD): New macro.
4466 * print.c (print_object): Use it.
4467
c0c5c8ae
PE
4468 * alloc.c: Use EMACS_INT, not int, to count objects.
4469 (total_conses, total_markers, total_symbols, total_vector_size)
4470 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4471 (total_free_floats, total_floats, total_free_intervals)
4472 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4473 Now EMACS_INT, not int. All uses changed.
4474 (Fgarbage_collect): Compute overall total using a double, so that
4475 integer overflow is less likely to be a problem. Check for overflow
4476 when converting back to an integer.
5a25e253
PE
4477 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4478 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4479 These were 'int' variables that could overflow on 64-bit hosts;
4480 they were never used, so remove them instead of repairing them.
211a0b2a 4481 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4482 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4483 Previously, this ceilinged at INT_MAX, but that doesn't work on
4484 64-bit machines.
e46bb31a 4485 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4486
c78baabf 4487 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4488 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4489 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4490 when a (possibly-narrower) signed value would do just as well.
4491 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4492
c9d624c6
PE
4493 * alloc.c: Catch some string size overflows that we were missing.
4494 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4495 for convenience in STRING_BYTES_MAX.
4496 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4497 The definition here is exact; the one in lisp.h was approximate.
4498 (allocate_string_data): Check for string overflow. This catches
4499 some instances we weren't catching before. Also, it catches
4500 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4501 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4502 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4503
c9d624c6
PE
4504 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4505 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4506 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4507
353032ce
PE
4508 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4509
2bccce07
PE
4510 * alloc.c (Fmake_string): Check for out-of-range init.
4511
0ac30604
SM
45122011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4513
4514 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4515
c195f2de
JD
45162011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4517
4518 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4519 xg_get_default_scrollbar_width.
4520
4521 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4522 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4523 (style_changed_cb): Call update_theme_scrollbar_width and call
4524 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4525 all frames (Bug#8505).
4526 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4527 Call gtk_window_set_resizable if HAVE_GTK3.
4528 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4529 and height if HAVE_GTK3 (Bug#8505).
4530 (scroll_bar_width_for_theme): New variable.
4531 (update_theme_scrollbar_width): New function.
4532 (xg_get_default_scrollbar_width): Move code to
4533 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4534 (xg_initialize): Call update_theme_scrollbar_width.
4535
4536 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4537
4538 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4539
e10ac9f1
MR
45402011-06-12 Martin Rudalics <rudalics@gmx.at>
4541
4542 * frame.c (make_frame): Call other_buffer_safely instead of
4543 other_buffer.
4544
4545 * window.c (temp_output_buffer_show): Call display_buffer with
4546 second argument Vtemp_buffer_show_specifiers and reset latter
4547 immediately after the call.
4548 (Vtemp_buffer_show_specifiers): New variable.
4549 (auto_window_vscroll_p, next_screen_context_lines)
4550 (Vscroll_preserve_screen_position): Remove leading asterisks from
4551 doc-strings.
4552
2d3c217e 45532011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4554
7b7f97e8 4555 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4556 * buffer.c (Qclone_number): Remove for now, as it's unused.
4557 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4558 (record_buffer): Remove unused local.
4559 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4560 (set_frame_buffer_list): Remove; unused.
4561 * frame.h (other_visible_frames): Remove decl.
4562 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4563 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4564 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4565 if HAVE_GPM.
4566 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4567 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4568 Define only if HAVE_GPM.
4569 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4570 (update_hints_inhibit): Remove; never set. All uses removed.
4571 * widgetprv.h (emacsFrameClassRec): Remove decl.
4572 * window.c (delete_deletable_window): Now returns void, since it
4573 wasn't returning anything.
4574 (compare_window_configurations): Remove unused locals.
4575 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4576 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4577 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4578 the same widths as pointers. This follows up on the 2011-05-06 patch.
4579 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4580 * xterm.h: Likewise.
4581 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4582
1384b89e
JB
45832011-06-12 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * makefile.w32-in: Update dependencies.
4586 (LISP_H): Add lib/intprops.h.
4587
1100a63c
CY
45882011-06-11 Chong Yidong <cyd@stupidchicken.com>
4589
4590 * image.c (gif_load): Add animation frame delay to the metadata.
4591 (syms_of_image): Use DEFSYM. New symbol `delay'.
4592
6198ccd0
MR
45932011-06-11 Martin Rudalics <rudalics@gmx.at>
4594
4595 * window.c (delete_deletable_window): Re-add.
4596 (Fset_window_configuration): Rewrite to handle dead buffers and
4597 consequently deletable windows.
4598 (window_tree, Fwindow_tree): Remove. Supply functionality in
4599 window.el.
4600 (compare_window_configurations): Simplify code.
4601
b6e3633c
AS
46022011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4603
1ab0dee5
AS
4604 * image.c (imagemagick_load_image): Fix type mismatch.
4605 (Fimagemagick_types): Likewise.
4606
b6e3633c
AS
4607 * window.h (replace_buffer_in_windows): Declare.
4608
9397e56f
MR
46092011-06-11 Martin Rudalics <rudalics@gmx.at>
4610
4611 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4612 Qclone_number. Remove external declaration of Qdelete_window.
4613 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4614 code.
640c8776
SM
4615 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4616 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4617 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4618 buffer list implementation.
4619 (other_buffer_safely): New function.
4620 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4621 calls to replace_buffer_in_windows and
4622 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4623 if allowed.
4624 (record_buffer): Inhibit quitting and rewrite using quittable
4625 functions. Run Qbuffer_list_update_hook if allowed.
4626 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4627 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4628 Move switch-to-buffer to window.el.
9397e56f
MR
4629 (bury-buffer): Move to window.el.
4630 (Vbuffer_list_update_hook): New variable.
4631
4632 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4633 section.
4634
4635 * window.h (resize_frame_windows): Move up in code.
4636 (Fwindow_frame): Remove EXFUN.
4637 (replace_buffer_in_all_windows): Remove prototype.
4638 (replace_buffer_in_windows_safely): Add prototype.
4639
4640 * window.c: Declare Qdelete_window static again. Move down
4641 declaration of select_count.
4642 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4643 (Fother_window): Move to window.el.
4644 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4645 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4646 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4647 window.el.
4648 (replace_buffer_in_windows): Implement by calling
4649 Qreplace_buffer_in_windows.
4650 (replace_buffer_in_all_windows): Remove with some functionality
4651 moved into replace_buffer_in_windows_safely.
4652 (replace_buffer_in_windows_safely): New function.
4653 (select_window_norecord, select_frame_norecord): Move in front
4654 of run_window_configuration_change_hook. Remove now obsolete
4655 declarations.
640c8776
SM
4656 (Fset_window_buffer): Rewrite doc-string.
4657 Call Qrecord_window_buffer.
9397e56f
MR
4658 (keys_of_window): Move binding for other-window to window.el.
4659
b50691aa
CY
46602011-06-11 Chong Yidong <cyd@stupidchicken.com>
4661
4662 * dispextern.h (struct image): Replace data member, whose int_val
4663 and ptr_val fields were not used by anything, with a single
4664 lisp_val object.
4665
4666 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4667 (gif_clear_image, gif_load, imagemagick_load_image)
4668 (gs_clear_image, gs_load): Callers changed.
4669
3f754b86
PE
46702011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4671
cca69397
PE
4672 * buffer.h: Include <time.h>, for time_t.
4673 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4674
109e28d0
PE
4675 Fix minor problems found by static checking.
4676
60737f02
PE
4677 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4678
4b66faf3
PE
4679 Make identifiers static if they are not used in other modules.
4680 * data.c (Qcompiled_function, Qframe, Qvector):
4681 * image.c (QimageMagick, Qsvg):
4682 * minibuf.c (Qmetadata):
4683 * window.c (resize_window_check, resize_root_window): Now static.
4684 * window.h (resize_window_check, resize_root_window): Remove decls.
4685
109e28d0
PE
4686 * window.c (window_deletion_count, delete_deletable_window):
4687 Remove; unused.
46a4ce9e
PE
4688 (window_body_lines): Now static.
4689 (Fdelete_other_windows_internal): Mark vars as initialized.
4690 Make sure 'resize_failed' is initialized.
4691 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4692 (resize_window_apply): Remove unused local.
4693 * window.h (delete_deletable_window): Remove decl.
4694
109e28d0 4695 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4696 (imagemagick_load_image): Fix pointer signedness problem by changing
4697 last arg from unsigned char * to char *. All uses changed.
4698 Also, fix a local for similar reasons.
4699 Remove unused locals. Remove locals to avoid shadowing.
4700 (fn_rsvg_handle_free): Remove; unused.
4701 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4702 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4703
3f754b86
PE
4704 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4705
2547adb1
CY
47062011-06-10 Chong Yidong <cyd@stupidchicken.com>
4707
4708 * image.c (gif_load): Fix omitted cast error introduced by
4709 2011-06-06 change.
4710
2c8e37d4
MR
47112011-06-10 Martin Rudalics <rudalics@gmx.at>
4712
4713 * window.h (resize_proportionally, orig_total_lines)
4714 (orig_top_line): Remove from window structure.
4715 (set_window_height, set_window_width, change_window_heights)
4716 (Fdelete_window): Remove prototypes.
4717 (resize_frame_windows): Remove duplicate declaration.
4718
440a42e3
EZ
47192011-06-10 Eli Zaretskii <eliz@gnu.org>
4720
4721 * window.h (resize_frame_windows, resize_window_check)
4722 (delete_deletable_window, resize_root_window)
4723 (resize_frame_windows): Declare prototypes.
4724
4725 * window.c (resize_window_apply): Make definition be "static" to
4726 match the prototype.
4727
562dd5e9
MR
47282011-06-10 Martin Rudalics <rudalics@gmx.at>
4729
4730 * window.c: Remove declarations of Qwindow_size_fixed,
4731 window_min_size_1, window_min_size_2, window_min_size,
4732 size_window, window_fixed_size_p, enlarge_window, delete_window.
4733 Remove static from declaration of Qdelete_window, it's
4734 temporarily needed by Fbury_buffer.
4735 (replace_window): Don't assign orig_top_line and
4736 orig_total_lines.
4737 (Fdelete_window, delete_window): Remove. Window deletion is
4738 handled by window.el.
640c8776
SM
4739 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4740 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4741 (Fdelete_other_windows): Remove. Deleting other windows is
4742 handled by window.el.
4743 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4744 handled in window.el.
4745 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4746 Window minimum sizes are handled in window.el.
4747 (shrink_windows, size_window, set_window_height)
4748 (set_window_width, change_window_heights, window_height)
4749 (window_width, CURBEG, CURSIZE, enlarge_window)
4750 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4751 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4752 handled in window.el.
4753 (make_dummy_parent): Rename to make_parent_window and give it a
4754 second argument horflag.
4755 (make_window): Don't set resize_proportionally any more.
4756 (Fsplit_window): Remove. Windows are split in window.el.
4757 (save_restore_action, save_restore_orig_size)
4758 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4759 Resize mini windows in window.el.
4760 (grow_mini_window, shrink_mini_window): Implement by calling
4761 Qresize_root_window_vertically, resize_window_check and
4762 resize_window_apply.
640c8776
SM
4763 (saved_window, Fset_window_configuration, save_window_save):
4764 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4765 resize_proportionally.
4766 (window_min_height, window_min_width): Move to window.el.
4767 (keys_of_window): Move bindings for delete-other-windows,
4768 split-window, delete-window and enlarge-window to window.el.
4769
4770 * buffer.c: Temporarily extern Qdelete_window.
4771 (Fbury_buffer): Temporarily call Qdelete_window instead of
4772 Fdelete_window (Fbury_buffer will move to window.el soon).
4773
4774 * frame.c (set_menu_bar_lines_1): Remove code handling
4775 orig_top_line and orig_total_lines.
4776
4777 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4778 set_window_height but set heights directly.
4779 (change_frame_size_1): Use resize_frame_windows.
4780
4781 * xdisp.c (init_xdisp): Don't use set_window_height but set
4782 heights directly.
4783
640c8776
SM
4784 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4785 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4786 run_window_configuration_change_hook.
4787
4788 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4789 instead of change_window_heights and run
4790 run_window_configuration_change_hook.
4791
1a13852e
MR
47922011-06-09 Martin Rudalics <rudalics@gmx.at>
4793
4794 * window.c (replace_window): Rename second argument REPLACEMENT to
4795 NEW. New third argument SETFLAG. Rewrite.
4796 (delete_window, make_dummy_parent): Call replace_window with
4797 third argument 1.
4798 (window_list_1): Move down in code.
4799 (run_window_configuration_change_hook): Move set_buffer part
4800 before select_frame_norecord part in order to unwind correctly.
4801 Rename count1 to count.
4802 (recombine_windows, delete_deletable_window, resize_root_window)
4803 (Fdelete_other_windows_internal)
4804 (Frun_window_configuration_change_hook, make_parent_window)
4805 (resize_window_check, resize_window_apply, Fresize_window_apply)
4806 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4807 (Fdelete_window_internal, Fresize_mini_window_internal):
4808 New functions.
1a13852e
MR
4809 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4810
f3d1777e
MR
48112011-06-08 Martin Rudalics <rudalics@gmx.at>
4812
496e208e
MR
4813 * window.h (window): Add some new members to window structure -
4814 normal_lines, normal_cols, new_total, new_normal, clone_number,
4815 splits, nest, prev_buffers, next_buffers.
4816 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4817 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4818
f3d1777e
MR
4819 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4820 Remove.
496e208e
MR
4821 (make_dummy_parent): Set new members of windows structure.
4822 (make_window): Move down in code. Handle new members of window
4823 structure.
4824 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4825 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4826 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4827 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4828 (Fset_window_next_buffers, Fset_window_clone_number):
4829 New functions.
496e208e
MR
4830 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4831 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4832 Doc-string fixes.
4833 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4834 Argument WINDOW can be now internal window too.
4835 (Fwindow_use_time): Move up in code.
4836 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4837 Rewrite doc-string.
4838 (Fset_window_configuration, saved_window)
4839 (Fcurrent_window_configuration, save_window_save): Handle new
4840 members of window structure.
b9e809c2
MR
4841 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4842 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4843 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4844 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4845 Qget_mru_window, Qresize_root_window,
4846 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4847 Qauto_buffer_name; staticpro them.
f3d1777e 4848
abde8f8c
MR
48492011-06-07 Martin Rudalics <rudalics@gmx.at>
4850
4851 * window.c (Fwindow_total_size, Fwindow_left_column)
4852 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4853 (Fwindow_list_1): New functions.
4854 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4855 (Fwindow_width, Fscroll_left, Fscroll_right):
4856 Use window_body_cols instead of window_box_text_cols.
4857 (delete_window, Fset_window_configuration):
4858 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4859 (delete_all_subwindows): Take a window as argument and not a
4860 structure. Rewrite.
190b47e6
MR
4861 (window_loop): Remove handling of GET_LRU_WINDOW and
4862 GET_LARGEST_WINDOW.
4863 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4864
4865 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4866 window_box_text_cols. delete_all_subwindows now takes a
4867 Lisp_Object as argument.
abde8f8c 4868
640c8776
SM
4869 * indent.c (compute_motion, Fcompute_motion):
4870 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4871
fa8a67e6
MR
4872 * frame.c (delete_frame): Call delete_all_subwindows with root
4873 window as argument.
4874
a54e3482
DC
48752011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4876
4877 * fns.c (Fputhash): Document return value.
4878
60002bf5
CY
48792011-06-06 Chong Yidong <cyd@stupidchicken.com>
4880
4881 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4882
0c671da6 48832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4884
b862a52a 4885 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4886
be44ca6c
PE
4887 Check for overflow when converting integer to cons and back.
4888 * charset.c (Fdefine_charset_internal, Fdecode_char):
4889 Use cons_to_unsigned to catch overflow.
4890 (Fencode_char): Use INTEGER_TO_CONS.
4891 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4892 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4893 * data.c (long_to_cons, cons_to_long): Remove.
4894 (cons_to_unsigned, cons_to_signed): New functions.
4895 These signal an error for invalid or out-of-range values.
4896 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4897 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4898 * font.c (Ffont_variation_glyphs):
4899 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4900 * lisp.h: Include <intprops.h>.
4901 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4902 (cons_to_signed, cons_to_unsigned): New decls.
4903 (long_to_cons, cons_to_long): Remove decls.
4904 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4905 (Fprimitive_undo): Use CONS_TO_INTEGER.
4906 * xfns.c (Fx_window_property): Likewise.
4907 * xselect.c: Include <limits.h>.
4908 (x_own_selection, selection_data_to_lisp_data):
4909 Use INTEGER_TO_CONS.
4910 (x_handle_selection_request, x_handle_selection_clear)
4911 (x_get_foreign_selection, Fx_disown_selection_internal)
4912 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4913 (lisp_data_to_selection_data): Use cons_to_unsigned.
4914 (x_fill_property_data): Use cons_to_signed.
4915 Report values out of range.
4916
d1f3d2af
PE
4917 Check for buffer and string overflow more precisely.
4918 * buffer.h (BUF_BYTES_MAX): New macro.
4919 * lisp.h (STRING_BYTES_MAX): New macro.
4920 * alloc.c (Fmake_string):
4921 * character.c (string_escape_byte8):
4922 * coding.c (coding_alloc_by_realloc):
4923 * doprnt.c (doprnt):
4924 * editfns.c (Fformat):
4925 * eval.c (verror):
4926 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4927 since they may not be the same number.
4928 * editfns.c (Finsert_char):
4929 * fileio.c (Finsert_file_contents):
4930 Likewise for BUF_BYTES_MAX.
4931
dd52fcea
PE
4932 * image.c: Use ptrdiff_t, not int, for sizes.
4933 (slurp_file): Switch from int to ptrdiff_t.
4934 All uses changed.
4935 (slurp_file): Check that file size fits in both size_t (for
4936 malloc) and ptrdiff_t (for sanity and safety).
4937
7f9bbdbb
PE
4938 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4939 if b->modtime has its maximal value.
4940
dfe18f82
PE
4941 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4942
84acfcf0
PE
4943 Don't assume time_t can fit into int.
4944 * buffer.h (struct buffer.modtime): Now time_t, not int.
4945 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4946 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4947
ccd9a01a
PE
4948 Minor fixes for signed vs unsigned integers.
4949 * character.h (MAYBE_UNIFY_CHAR):
4950 * charset.c (maybe_unify_char):
4951 * keyboard.c (read_char, reorder_modifiers):
4952 XINT -> XFASTINT, since the integer must be nonnegative.
4953 * ftfont.c (ftfont_spec_pattern):
4954 * keymap.c (access_keymap, silly_event_symbol_error):
4955 XUINT -> XFASTINT, since the integer must be nonnegative.
4956 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4957 since it makes no difference and we prefer signed.
4958 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4959 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4960 nonnegative.
4961
d6d100dd
SM
49622011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4963
4964 * window.h (Fwindow_frame): Declare.
4965
2b6148e4
PE
49662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4969 (SPARE_MEMORY): Always define.
4970 (LARGE_REQUEST): Remove.
4971 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4972
f230ecc9
MR
49732011-06-06 Martin Rudalics <rudalics@gmx.at>
4974
727e958e
MR
4975 * lisp.h: Move EXFUNS for Fframe_root_window,
4976 Fframe_first_window and Fset_frame_selected_window to window.h.
4977
4978 * window.h: Move EXFUNS for Fframe_root_window,
4979 Fframe_first_window and Fset_frame_selected_window here from
4980 lisp.h.
4981
4982 * frame.c (Fwindow_frame, Fframe_first_window)
4983 (Fframe_root_window, Fframe_selected_window)
4984 (Fset_frame_selected_window): Move to window.c.
4985 (Factive_minibuffer_window): Move to minibuf.c.
4986 (Fother_visible_frames_p): New function.
4987
4988 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4989
f230ecc9
MR
4990 * window.c (decode_window, decode_any_window): Move up in code.
4991 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4992 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4993 (Fwindow_buffer): Move up and rewrite doc-string.
4994 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4995 (Fwindow_prev): New functions.
727e958e
MR
4996 (Fwindow_frame): Move here from frame.c. Accept any window as
4997 argument.
4998 (Fframe_root_window, Fframe_first_window)
4999 (Fframe_selected_window): Move here from frame.c. Accept frame
5000 or arbitrary window as argument. Update doc-strings.
5001 (Fminibuffer_window): Move up in code.
5002 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5003 (Fset_frame_selected_window): Move here from frame.c.
5004 Marginal rewrite.
727e958e
MR
5005 (Fselected_window, select_window, Fselect_window): Move up in
5006 code. Minor doc-string fixes.
f230ecc9 5007
4d09bcf6
PE
50082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5011 Do not assume that spare memory exists; that assumption is valid
5012 only if SYSTEM_MALLOC.
5013 (LARGE_REQUEST): New macro, so that the issue of large requests
5014 is separated from the issue of spare memory.
5015
810928a2
AS
50162011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5017
172418ad
AS
5018 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5019 format. (Bug#8806)
5020
43f862f7
AS
5021 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5022
810928a2
AS
5023 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5024 before statements.
5025
a059fe24
JD
50262011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5027
5028 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5029
5030 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5031
5032 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5033 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5034
989bf368
JB
50352011-06-05 Juanma Barranquero <lekktu@gmail.com>
5036
5037 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5038
4b80f674
CY
50392011-06-04 Chong Yidong <cyd@stupidchicken.com>
5040
5041 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5042 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5043 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5044 New error handlers.
4b80f674
CY
5045 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5046 Obey Vx_select_enable_clipboard_manager. Catch errors in
5047 x_clipboard_manager_save (Bug#8779).
5048 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5049 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5050
99a33b77 50512011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5052
5053 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5054
99a33b77 50552011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5056
5057 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5058 in the current matrix if keep_current_p is non-zero.
5059
8264569d
EZ
50602011-06-04 Eli Zaretskii <eliz@gnu.org>
5061
5062 * bidi.c (bidi_level_of_next_char): Fix last change.
5063
57f97249
EZ
50642011-06-03 Eli Zaretskii <eliz@gnu.org>
5065
fec2107c 5066 Support bidi reordering of text covered by display properties.
57f97249 5067
fec2107c
EZ
5068 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5069 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5070 (bidi_cache_search, bidi_cache_iterator_state)
5071 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5072 (bidi_level_of_next_char, bidi_move_to_visually_next):
5073 Support character positions inside a run of characters covered by a
fec2107c
EZ
5074 display string.
5075 (bidi_paragraph_init, bidi_resolve_explicit_1)
5076 (bidi_level_of_next_char): Call bidi_fetch_char and
5077 bidi_fetch_char_advance instead of FETCH_CHAR and
5078 FETCH_CHAR_ADVANCE.
5079 (bidi_init_it): Initialize new members.
5080 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5081 definitions.
5082 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5083 instead of using explicit *_CHAR codes.
d6d100dd
SM
5084 (bidi_resolve_explicit, bidi_resolve_weak):
5085 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5086 bidirectional text is supported only in multibyte buffers.
5087 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5088 it to initialize the frame_window_p member of struct bidi_it.
5089 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5090 (bidi_resolve_explicit, bidi_resolve_weak)
5091 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5092 bidi_it->nchars is non-positive.
5093 (bidi_level_of_next_char): Don't try to lookup the cache for the
5094 next/previous character if nothing is cached there yet, or if we
5095 were just reseat()'ed to a new position.
c40e2fb2 5096
0e14fe90
EZ
5097 * xdisp.c (set_cursor_from_row): Set start and stop points
5098 according to the row's direction when priming the loop that looks
5099 for the glyph on which to display cursor.
5100 (single_display_spec_intangible_p): Function deleted.
5101 (display_prop_intangible_p): Reimplement to call
5102 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5103 Accept 3 additional arguments needed by handle_display_spec.
5104 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5105 values: lists, `(when COND...)' forms, etc.
5106 (single_display_spec_string_p): Support property values that are
5107 lists with the argument STRING its top-level element.
5108 (display_prop_string_p): Fix the condition for processing a
5109 property that is a list to be consistent with handle_display_spec.
fec2107c 5110 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5111 last portion of handle_display_prop.
5112 (compute_display_string_pos): Accept additional argument
5113 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5114 value of a `display' property is a "replacing spec".
5115 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5116 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5117 the display property, but just return a value indicating whether
5118 the display property will replace the characters it covers.
5119 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5120 frame_window_p members of struct bidi_it.
d6d100dd
SM
5121 (compute_display_string_pos, compute_display_string_end):
5122 New functions.
fec2107c
EZ
5123 (push_it): Accept second argument POSITION, where pop_it should
5124 jump to continue iteration.
5125 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5126
fec2107c
EZ
5127 * keyboard.c (adjust_point_for_property): Adjust the call to
5128 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5129
5130 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5131 (bidi_init_it): Update prototypes.
5132 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5133 (compute_display_string_pos, compute_display_string_end):
5134 Declare prototypes.
fec2107c
EZ
5135 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5136 EMACS_INT.
fc6f18ce 5137
40087514 51382011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5139
57f53182
PE
5140 Malloc failure behavior now depends on size of allocation.
5141 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5142 * lisp.h: Change signatures accordingly.
5143 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5144 All callers changed. (Bug#8762)
5145
5146 * gnutls.c: Use Emacs's memory allocators.
5147 Without this change, the gnutls library would invoke malloc etc.
5148 directly, which causes problems on non-SYNC_INPUT hosts, and which
5149 runs afoul of improving memory_full behavior. (Bug#8761)
5150 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5151 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5152 xfree instead of the default malloc, realloc, free.
5153 (Fgnutls_boot): No need to check for memory allocation failure,
5154 since xmalloc does that for us.
5155
ac32cd99 5156 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5157 * category.c (hash_get_category_set):
5158 * ccl.c (ccl_driver):
5159 * charset.c (Fdefine_charset_internal):
5160 * charset.h (struct charset.hash_index):
5161 * composite.c (get_composition_id, gstring_lookup_cache)
5162 (composition_gstring_put_cache):
5163 * composite.h (struct composition.hash_index):
5164 * dispextern.h (struct image.hash):
5165 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5166 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5167 (hashfn_equal, hashfn_user_defined, make_hash_table)
5168 (maybe_resize_hash_table, hash_lookup, hash_put)
5169 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5170 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5171 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5172 * image.c (make_image, search_image_cache, lookup_image)
5173 (xpm_put_color_table_h):
5174 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5175 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5176 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5177 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5178 * alloc.c (allocate_vectorlike):
5179 Check for overflow in vector size calculations.
5180 * ccl.c (ccl_driver):
5181 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5182 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5183 need to be updated by these changes.
40087514
PE
5184 * fns.c (make_hash_table, maybe_resize_hash_table):
5185 Check for integer overflow with large hash tables.
0de4bb68
PE
5186 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5187 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5188 (SXHASH_REDUCE): New macro.
5189 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5190 Use it instead of discarding useful hash info with large hash values.
5191 (sxhash_float): New function.
5192 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5193 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5194 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5195 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5196 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5197 Adjust signatures to match updated version of code.
5198 (consing_since_gc): Now EMACS_INT, since a single hash table can
5199 use more than INT_MAX bytes.
5200
698d32e2
DN
52012011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5202
5203 Make it possible to build with GCC-4.6+ -O2 -flto.
5204
5205 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5206
fd6fa53f
SM
52072011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5208
5209 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5210 Call minibuffer-inactive-mode.
5211
864db017
JB
52122011-05-31 Juanma Barranquero <lekktu@gmail.com>
5213
5214 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5215 Update dependencies.
5216
2ad0baf4
DN
52172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5218
5219 * data.c (init_data): Remove code for UTS, this system is not
5220 supported anymore.
5221
4fcc2638
DN
52222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5223
5224 Don't force ./temacs to start in terminal mode.
5225
5226 * frame.c (make_initial_frame): Initialize faces in all cases, not
5227 only when CANNOT_DUMP is defined.
5228 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5229
c56e0fd5
DN
52302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5231
5232 * dispnew.c (add_window_display_history): Use const for the string
5233 pointer. Remove declaration, not needed.
5234
333d54da 52352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5236
55d4c1b2 5237 Use 'inline', not 'INLINE'.
333d54da 5238 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5239 * alloc.c, fontset.c (INLINE): Remove.
5240 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5241 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5242 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5243 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5244 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5245
738db178
DN
52462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5247
5248 Make it possible to run ./temacs.
5249
5250 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5251 syms_of_callproc does the same thing. Remove test for
5252 "initialized", do it in the caller.
5253 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5254
620c53a6
SM
52552011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5256
5257 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5258 (read_minibuf): Use get_minibuffer.
5259 (syms_of_minibuf): Use DEFSYM.
5260 (Qmetadata): New var.
5261 * data.c (Qbuffer): Don't make it static.
5262 (syms_of_data): Use DEFSYM.
5263
e003a292
PE
52642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5265
5266 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5267 (CCL_CODE_MIN): New macro.
5268
ed008a6d
PE
52692011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5270
3687c2ef
PE
5271 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5272
ed008a6d
PE
5273 * eval.c (Qdebug): Now static.
5274 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5275 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5276 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5277
d66c4c7c
CY
52782011-05-29 Chong Yidong <cyd@stupidchicken.com>
5279
5280 * image.c: Various fixes to ImageMagick code comments.
5281 (Fimagemagick_types): Doc fix.
5282
5fbc2025
PE
52832011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5284
0196f88a
PE
5285 Minor fixes prompted by GCC 4.6.0 warnings.
5286
5287 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5288
5fbc2025
PE
5289 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5290 (x_clipboard_manager_save_all): Move extern decl to ...
5291 * xterm.h: ... here, so that it can be checked for consistency.
5292
1dd3c2d9
CY
52932011-05-29 Chong Yidong <cyd@stupidchicken.com>
5294
5295 * xselect.c (x_clipboard_manager_save_frame)
5296 (x_clipboard_manager_save_all): New functions.
5297 (Fx_clipboard_manager_save): Lisp function deleted.
5298
5299 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5300 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5301
5302 * xterm.h: Update prototype.
5303
5ba6571d
WX
53042011-05-28 William Xu <william.xwl@gmail.com>
5305
5306 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5307 exiting (Bug#8239).
5308
3eaff834
JM
53092011-05-28 Jim Meyering <meyering@redhat.com>
5310
e1900994 5311 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5312 * fns.c (to_uchar): Define.
5313 (crypto_hash_function): Use it to convert some newly-signed
5314 variables to unsigned, to avoid sign-extension bugs. For example,
5315 without this change, (md5 "truc") would evaluate to
5316 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5317 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5318 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5319
0f6990a7
PE
53202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5321
5322 Integer overflow fixes.
c8a9ca5a 5323
08686060
PE
5324 * dbusbind.c: Serial number integer overflow fixes.
5325 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5326 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5327 to hold a serial number that is too large for a fixnum.
5328 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5329 Check for serial numbers out of range. Decode any serial number
59568bf0 5330 that was so large that it became a float. (Bug#8722)
08686060 5331
2d1fc3c7
PE
5332 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5333 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5334 Use XFASTINT rather than XUINT when numbers are nonnegative.
5335 (xd_append_arg, Fdbus_method_return_internal):
5336 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5337 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5338 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5339 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5340 (Bug#8722)
2d1fc3c7 5341
c8a9ca5a
PE
5342 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5343
519e1d69
PE
5344 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5345
30569699
PE
5346 ccl: add integer overflow checks
5347 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5348 (IN_INT_RANGE): New macros.
5349 (ccl_driver): Use them to check for integer overflow when
5350 decoding a CCL program. Many of the new checks are whether XINT (x)
5351 fits in int; it doesn't always, on 64-bit hosts. The new version
5352 doesn't catch all possible integer overflows, but it's an
847044ea 5353 improvement. (Bug#8719)
30569699 5354
c11285dc
PE
5355 * alloc.c (make_event_array): Use XINT, not XUINT.
5356 There's no need for unsigned here.
5357
fdccd48e
PE
5358 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5359 This follows up to the 2011-05-06 change that substituted uintptr_t
5360 for EMACS_INT. This case wasn't caught back then.
5361
37910ab2
PE
5362 Rework Fformat to avoid integer overflow issues.
5363 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5364 now (part of C89). Include <verify.h>.
5365 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5366 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5367 (Fformat): Avoid the prepass trying to compute sizes; it was only
5368 approximate and thus did not catch overflow reliably. Instead, walk
5369 through the format just once, formatting and computing sizes as we go,
5370 checking for integer overflow at every step, and allocating a larger
5371 buffer as needed. Keep track separately whether the format is
5372 multibyte. Keep only the most-recently calculated precision, rather
5373 than them all. Record whether each argument has been converted to
5374 string. Use EMACS_INT, not int, for byte and char and arg counts.
5375 Support field widths and precisions larger than INT_MAX. Avoid
5376 sprintf's undefined behavior with conversion specifications such as %#d
5377 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5378 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5379 formatting out-of-range floating point numbers with int
9173deec 5380 formats. (Bug#8668)
37910ab2 5381
2e6578fb
PE
5382 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5383
0ae6bdee
PE
5384 * data.c: Avoid integer truncation in expressions involving floats.
5385 * data.c: Include <intprops.h>.
5386 (arith_driver): When there's an integer overflow in an expression
5387 involving floating point, convert the integers to floating point
5388 so that the resulting value does not suffer from catastrophic
5389 integer truncation. For example, on a 64-bit host (* 4
5390 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5391 Do not rely on undefined behavior after integer overflow.
5392
de883a70
PE
5393 merge count_size_as_multibyte, parse_str_to_multibyte
5394 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5395 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5396 Check for integer overflow.
5397 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5398 since it's now a duplicate of the other. This is more of
5399 a character than a buffer op, so better that it's in character.c.
5400 * fns.c, print.c: Adjust to above changes.
5401
2ff916cb
PE
54022011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5403
5404 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5405
f1b54466
PE
54062011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5407
fb1ac845
PE
5408 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5409 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5410 (x_clipboard_manager_save): Now static.
5411 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5412
f1b54466
PE
5413 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5414 (crypto_hash_function): Now static.
5415 Fix pointer signedness problems. Avoid unnecessary initializations.
5416
a9f737ee
CY
54172011-05-27 Chong Yidong <cyd@stupidchicken.com>
5418
5419 * termhooks.h (Vselection_alist): Make it terminal-local.
5420
5421 * terminal.c (create_terminal): Initialize it.
5422
5423 * xselect.c: Support for clipboard managers.
5424 (Vselection_alist): Move to termhooks.h as terminal-local var.
5425 (LOCAL_SELECTION): New macro.
5426 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5427 (symbol_to_x_atom): Remove gratuitous arg.
5428 (x_handle_selection_request, lisp_data_to_selection_data)
5429 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5430 (x_own_selection, x_get_local_selection, x_convert_selection):
5431 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5432 (some_frame_on_display): Delete unused function.
5433 (Fx_own_selection_internal, Fx_get_selection_internal)
5434 (Fx_disown_selection_internal, Fx_selection_owner_p)
5435 (Fx_selection_exists_p): New optional frame arg.
5436 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5437 (x_handle_selection_clear): Don't treat other terminals with the
5438 same keyboard specially. Use the terminal-local Vselection_alist.
5439 (x_clear_frame_selections): Use Frun_hook_with_args.
5440
5441 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5442
5443 * xterm.h: Add support for those atoms.
5444
e067f0c1
CY
54452011-05-26 Chong Yidong <cyd@stupidchicken.com>
5446
5447 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5448 (converted_selections, conversion_fail_tag): New global variables.
5449 (x_selection_request_lisp_error): Free the above.
5450 (x_get_local_selection): Remove unnecessary code.
5451 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5452 of converted selections stored in converted_selections.
5453 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5454 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5455 (x_convert_selection): New function.
5456 (x_handle_selection_event): Simplify.
5457 (x_get_foreign_selection): Don't ignore incoming requests while
5458 waiting for an answer; this will fail when we implement
5459 SAVE_TARGETS, and seems unnecessary anyway.
5460 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5461 (Vx_sent_selection_functions): Doc fix.
5462
0f4aebc0
LL
54632011-05-26 Leo Liu <sdl.web@gmail.com>
5464
5465 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5466
e61124cd
YM
54672011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5468
5469 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5470
5471 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5472 for fringe update if it has periodic bitmap.
ac389d0c 5473 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5474 and fringe_bitmap_periodic_p.
5475
5476 * fringe.c (get_fringe_bitmap_data): New function.
5477 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5478 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5479 row. Mark glyph row for fringe update if periodicity changed.
5480
5481 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5482 for fringe update unless it has periodic bitmap.
5483
f16d9837
KH
54842011-05-25 Kenichi Handa <handa@m17n.org>
5485
5486 * xdisp.c (get_next_display_element): Set correct it->face_id for
5487 a static composition.
5488
e1b90ef6
LL
54892011-05-24 Leo Liu <sdl.web@gmail.com>
5490
5491 * deps.mk (fns.o):
5492 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5493
5494 * fns.c (crypto_hash_function, Fsha1): New function.
5495 (Fmd5): Use crypto_hash_function.
5496 (syms_of_fns): Add Ssha1.
5497
7400048f
PE
54982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 * gnutls.c: Remove unused macros.
5501 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5502 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5503 Remove macros that are defined and never used.
5504 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5505
abb71cf4
CY
55062011-05-22 Chong Yidong <cyd@stupidchicken.com>
5507
5508 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5509 (Fx_get_selection_internal): Minor cleanup.
5510 (Fx_own_selection_internal): Rename arguments for consistency with
5511 select.el.
5512
6307db39
PE
55132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5514
5515 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5516
f3d4e0a4
CY
55172011-05-22 Chong Yidong <cyd@stupidchicken.com>
5518
5519 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5520
4d8ade89
YM
55212011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5522
5523 * dispnew.c (scrolling_window): Don't exclude the case that the
5524 last enabled row in the desired matrix touches the bottom boundary.
5525
32078c8d
GM
55262011-05-21 Glenn Morris <rgm@gnu.org>
5527
5528 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5529 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5530 and add some more files.
32078c8d 5531
7285dc67
EZ
55322011-05-20 Eli Zaretskii <eliz@gnu.org>
5533
5534 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5535 report_file_error introduced by the change from 2011-05-07.
5536
89d1bd22
PE
55372011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5538
5539 * systime.h (Time): Define only if emacs is defined.
5540 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5541 where the include path doesn't have X11/X.h by default. See
5542 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5543
e23640bb 55442011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5545
5546 * composite.c (find_automatic_composition): Fix previous change.
5547
b9704ad9
GM
55482011-05-20 Glenn Morris <rgm@gnu.org>
5549
5550 * lisp.mk: New file, split from Makefile.in.
5551 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5552 (shortlisp): Remove.
5553 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5554
4a720484
GM
55552011-05-19 Glenn Morris <rgm@gnu.org>
5556
5557 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5558 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5559 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5560 (lisp): Set the order to that of loadup.el.
5561 (shortlisp): Make it a copy of $lisp.
5562 (SOME_MACHINE_LISP): Remove.
5563 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5564 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5565
a28d4396
KH
55662011-05-18 Kenichi Handa <handa@m17n.org>
5567
5568 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5569 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5570 (find_automatic_composition): Mostly rewrite for efficiency.
5571
a2b1fa8e
JB
55722011-05-18 Juanma Barranquero <lekktu@gmail.com>
5573
5574 * makefile.w32-in: Update dependencies.
5575
8e1f5610
CS
55762011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5577
5578 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5579 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5580
7025ee00 55812011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5582
cdfa6eab
PE
5583 Fix some integer overflow issues, such as string length overflow.
5584
06d6db33
PE
5585 * insdel.c (count_size_as_multibyte): Check for string overflow.
5586
2b4560a8
PE
5587 * character.c (lisp_string_width): Check for string overflow.
5588 Use EMACS_INT, not int, for string indexes and lengths; in
5589 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5590 the resulting string length overflows an EMACS_INT; instead,
5591 report a string overflow if no precision given. When checking for
5592 precision exhaustion, use a check that cannot possibly have
5593 integer overflow. (Bug#8675)
5594 * character.h (lisp_string_width): Adjust to new signature.
5595
cb93f9be
PE
5596 * alloc.c (string_overflow): New function.
5597 (Fmake_string): Use it. This doesn't change behavior, but saves
5598 a few bytes and will simplify future changes.
5599 * character.c (string_escape_byte8): Likewise.
5600 * lisp.h (string_overflow): New decl.
5601
1a1f3366
PE
5602 Fixups, following up to the user-interface timestamp change.
5603 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5604 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5605 * msdos.c (mouse_get_pos): Likewise.
5606 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5607 * w32gui.h (Time): Define by including "systime.h" rather than by
5608 declaring it ourselves. (Bug#8664)
5609
d4e3e4d3
PE
5610 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5611 * image.c (clear_image_cache): Likewise.
5612
f6a24d19
PE
5613 * term.c (term_mouse_position): Don't assume time_t wraparound.
5614
08dc5ae6
PE
5615 Be more systematic about user-interface timestamps.
5616 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5617 and sometimes 'EMACS_UINT', to represent these timestamps.
5618 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5619 This makes the code easier to follow, and makes it easier to catch
5620 integer overflow bugs such as Bug#8664.
5621 * frame.c (Fmouse_position, Fmouse_pixel_position):
5622 Use Time, not unsigned long, for user-interface timestamps.
5623 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5624 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5625 * keyboard.h (last_event_timestamp): Likewise.
5626 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5627 * menu.h (xmenu_show): Likewise.
5628 * term.c (term_mouse_position): Likewise.
5629 * termhooks.h (struct input_event.timestamp): Likewise.
5630 (struct terminal.mouse_position_hook): Likewise.
5631 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5632 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5633 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5634 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5635 what it was before.
5636 * menu.h, termhooks.h: Include "systime.h", for Time.
5637
8e55734a
PE
5638 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5639 Don't assume that the difference between two unsigned long values
5640 can fit into an integer. At this point, we know button_down_time
5641 <= event->timestamp, so the difference must be nonnegative, so
5642 there's no need to cast the result if double-click-time is
5643 nonnegative, as it should be; check that it's nonnegative, just in
5644 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5645 apart (about 25 days). (Bug#8664)
8e55734a 5646
841f1b75 5647 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5648 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5649
3e26f69c
PE
5650 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5651 that always fit in int. Use a sentinel instead of a counter, to
5652 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5653 * frame.h (struct frame): Use int for menu_bar_items_used
5654 instead of EMACS_INT, since it always fits in int.
3e26f69c 5655
5cc152c0
PE
5656 * menu.c (grow_menu_items): Check for int overflow.
5657
d89eb65e
PE
5658 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5659
5235bd3e
PE
5660 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5661 Before, the code was not consistent. These values cannot exceed
5662 2**31 - 1 so there's no need to make them unsigned.
5663 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5664 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5665 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5666 as modifiers.
5667 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5668
bc827e23
PE
5669 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5670 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5671 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5672 presumably because the widths might not match.
5673
78eb494e
PE
5674 * window.c (size_window): Avoid needless test at loop start.
5675
04f2d78b
CB
56762011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5677
5678 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5679
d2fc7e3d 56802011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5681
5682 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5683
d2fc7e3d 56842011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5685
5686 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5687 `width' to `bar_area_x' and `bar_area_width', respectively.
5688 (x_scroll_run): Take account of fringe background extension.
5689
04f2d78b
CB
5690 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5691 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5692 `bar_area_width', respectively.
5693 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5694 background extension.
5695
79b70037
GM
56962011-05-10 Jim Meyering <meyering@redhat.com>
5697
5698 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5699
2f142cc5
JB
57002011-05-10 Juanma Barranquero <lekktu@gmail.com>
5701
5702 * image.c (Finit_image_library): Return t for built-in image types,
5703 like pbm and xbm. (Bug#8640)
5704
57679c86
AS
57052011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5706
5707 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5708
888c9e86
EZ
57092011-05-07 Eli Zaretskii <eliz@gnu.org>
5710
b0512a1d
EZ
5711 * w32console.c (Fset_screen_color): Doc fix.
5712 (Fget_screen_color): New function.
5713 (syms_of_ntterm): Defsubr it.
5714
7285dc67
EZ
5715 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5716 unlink the temporary file if Fcall_process didn't create it in the
5717 first place.
5718 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5719 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5720 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5721 cue to call_process_cleanup not to close that handle.
5722
4d3fcc8e
BK
57232011-05-07 Ben Key <bkey76@gmail.com>
5724
5725 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5726 one of two shell specific rules, either bootstrap-temacs-CMD or
5727 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5728 to the previous implementation of the bootstrap-temacs rule.
5729 The bootstrap-temacs-CMD rule is similar to the previous
5730 implementation of the bootstrap-temacs rule except that it
5731 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5732 variable.
5733
5734 These changes, along with some changes to nt/configure.bat,
5735 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5736 earlier fix to add support for --cflags and --ldflags options
5737 that include quotes so that it works whether make uses cmd or
5738 sh as the shell.
5739
b4289b64
MA
57402011-05-06 Michael Albinus <michael.albinus@gmx.de>
5741
5742 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5743 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5744 is a constant.
5745 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5746 a string. Handle both cases.
5747 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5748 (Fdbus_register_method): Use Qinvalid_function.
5749
af4c0e28
JB
57502011-05-06 Juanma Barranquero <lekktu@gmail.com>
5751
5752 * makefile.w32-in: Update dependencies.
5753 (LISP_H): Add inttypes.h and stdin.h.
5754 (PROCESS_H): Add unistd.h.
5755
c51453d9
EZ
57562011-05-06 Eli Zaretskii <eliz@gnu.org>
5757
5758 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5759 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5760
8ff0ac3c 57612011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5762
4c4b566b
PE
5763 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5764
aab2b9b5
PE
5765 * term.c (vfatal): Remove stray call to va_end.
5766 It's not needed and the C Standard doesn't allow it here anyway.
5767
c378da0b
PE
5768 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5769 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5770
288b08c7
PE
5771 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5772 bytes.
5773
e3601888
PE
5774 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5775
db6c0e74
PE
5776 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5777
dd5963ea
PE
5778 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5779
88c9450f
PE
5780 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5781
2f9442b8
PE
5782 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5783
c032b5f8
PE
5784 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5785 * charset.c (Fdefine_charset_internal): Don't initialize
5786 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5787 32-bit int (Bug#8600).
a108c10b
PE
5788
5789 * lread.c (read_integer): Be more consistent with string-to-number.
5790 Use string_to_number to do the actual conversion; this avoids
5791 rounding errors and fixes some other screwups. Without this fix,
5792 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5793 (digit_to_number): Move earlier, for benefit of read_integer.
5794 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5795 not a digit in any supported base. (Bug#8602)
a108c10b 5796
ad5f9eea
PE
5797 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5798
aec1708a
PE
5799 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5800 to match comment at start of function. This also removes a
5801 GCC warning about overflow in a 32+64-bit port.
5802
47be4ab5
PE
5803 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5804
371cac43
PE
5805 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5806 Reported by Stefan Monnier in
5807 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5808 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5809 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5810
d01a7826
PE
5811 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5812 (EMACS_UINTPTR): Likewise, with uintptr_t.
5813
7fd47d5c
PE
5814 * lisp.h: Prefer 64-bit EMACS_INT if available.
5815 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5816 on 32-bit hosts that have 64-bit int, so that they can access
5817 large files.
122b0c86
PE
5818 However, temporarily disable this change unless the temporary
5819 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5820
8727937b
PE
5821 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5822
8ac068ac
PE
5823 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5824 This removes an assumption that EMACS_INT and long are the same
5825 width as pointers. The assumption is true for Emacs porting targets
5826 now, but we want to make other targets possible.
5827 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5828 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5829 In the rest of the code, change types of integers that hold casted
5830 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5831 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5832 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5833 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5834 No need to cast type when ORing.
5835 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5836 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5837 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5838 assume EMACS_INT is the same width as char *.
5839 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5840 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5841 Remove no-longer-needed casts.
5842 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5843 (xg_tool_bar_help_callback, xg_make_tool_item):
5844 Use EMACS_INTPTR to hold an integer
5845 that will be cast to void *; this can avoid a GCC warning
5846 if EMACS_INT is not the same width as void *.
5847 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5848 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5849 (current_message_1, set_message_1):
5850 Use a local to convert to proper width without a cast.
5851 * xmenu.c (dialog_selection_callback): Likewise.
5852
ede49d71
PE
5853 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5854 Also, don't assume VALBITS / RAND_BITS is less than 5,
5855 and don't rely on undefined behavior when shifting a 1 left into
5856 the sign bit.
5857 * lisp.h (get_random): Change signature to match.
5858
2f30ecd0
PE
5859 * lread.c (hash_string): Use size_t, not int, for hash computation.
5860 Normally we prefer signed values; but hashing is special, because
5861 it's better to use unsigned division on hash table sizes so that
5862 the remainder is nonnegative. Also, size_t is the natural width
5863 for hashing into memory. The previous code used 'int', which doesn't
5864 retain enough info to hash well into very large tables.
5865 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5866
2a866e7b
PE
5867 * dbusbind.c: Don't possibly lose pointer info when converting.
5868 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5869 Use XPNTR rather than XHASH, so that the high-order bits of
5870 the pointer aren't lost when converting through void *.
5871
51639eac
PE
5872 * eval.c (Fautoload): Don't double-shift a pointer.
5873
92394119
PE
5874 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5875
dbdb9a7c
JB
58762011-05-06 Juanma Barranquero <lekktu@gmail.com>
5877
5878 * gnutls.c (DEF_GNUTLS_FN):
5879 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5880
db7a0b4f
AS
58812011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5882
5883 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5884 marker. (Bug#8610)
5885
f7ff1b0f 58862011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5887
5888 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5889 New version that can reserve upto 2GB of heap space.
5890
f7ff1b0f 58912011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5892
5893 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5894
639c109b
TZ
58952011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5896
5897 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5898 `gnutls_certificate_set_x509_key_file'.
5899
d2127135
JB
59002011-05-05 Juanma Barranquero <lekktu@gmail.com>
5901
5902 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5903 Update dependencies.
5904
e968f4f3
JB
59052011-05-04 Juanma Barranquero <lekktu@gmail.com>
5906
5907 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5908 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5909 Remove unused parameter `fildes'.
5910 * process.c (read_process_output, send_process): Don't pass it.
5911
84d358f0
JB
59122011-05-04 Juanma Barranquero <lekktu@gmail.com>
5913
5914 Fix previous change: the library cache is defined in w32.c.
5915 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5916 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5917
0898ca10
JB
59182011-05-04 Juanma Barranquero <lekktu@gmail.com>
5919
5920 Implement dynamic loading of GnuTLS on Windows.
5921
5922 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5923 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5924 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5925 Declare.
5926
5927 * gnutls.c (Qgnutls_dll): Define.
5928 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5929 (gnutls_*): Declare function pointers.
5930 (init_gnutls_functions): New function to initialize function pointers.
5931 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5932 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5933 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5934 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5935 (emacs_gnutls_write, emacs_gnutls_read)
5936 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5937 (Fgnutls_available_p): New function.
5938 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5939 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5940 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5941
5942 * image.c: Include w32.h.
5943 (Vimage_type_cache): Delete.
5944 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5945 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5946 (w32_delayed_load): Move to w32.c.
5947
5948 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5949
5950 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5951 (w32_delayed_load): Move from image.c. When loading a library, record
5952 its filename in the :loaded-from property of the library id.
5953 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5954 Initialize and staticpro them.
5955 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5956
5957 * process.c: Include lisp.h before w32.h, not after.
5958 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5959 instead of gnutls_record_check_pending.
5960
5961 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5962
ff4de4aa
TZ
59632011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5964
5965 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5966 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5967 as passed in.
5968
abe95abb
JD
59692011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5970
5971 * xterm.c (x_set_frame_alpha): Do not set property on anything
5972 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5973
e16e55d4
JB
59742011-05-02 Juanma Barranquero <lekktu@gmail.com>
5975
5976 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5977
bafcf6a5
JB
59782011-05-02 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5981 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5982 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5983 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5984 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5985 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5986 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5987 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5988 (Qgnutls_bootprop_callbacks_verify): Make static.
5989
e7a6747f
AS
59902011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5991
19ed11ba
AS
5992 * callproc.c: Indentation fixup.
5993
e7a6747f 5994 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5995 (wait_for_termination, interruptible_wait_for_termination):
5996 Move after wait_for_termination_1.
e7a6747f 5997
1ef14cb4
LMI
59982011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5999
6000 * sysdep.c (interruptible_wait_for_termination): New function
6001 which is like wait_for_termination, but allows keyboard
6002 interruptions.
6003
6004 * callproc.c (Fcall_process): Add (:file "file") as an option for
6005 the STDOUT buffer.
6006 (Fcall_process_region): Ditto.
6007
330d880c
EZ
60082011-04-30 Eli Zaretskii <eliz@gnu.org>
6009
8db90b73
EZ
6010 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6011 rather than `XVECTOR (FOO)->size'.
6012
330d880c
EZ
6013 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6014 inttypes.h, as a gnulib replacement is used if it not available in
6015 system headers.
6016
15cbd324
EZ
60172011-04-21 Eli Zaretskii <eliz@gnu.org>
6018
6019 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6020 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6021 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6022
6023 * coding.c (coding_alloc_by_realloc): Error out if destination
6024 will grow beyond MOST_POSITIVE_FIXNUM.
6025 (decode_coding_emacs_mule): Abort if there isn't enough place in
6026 charbuf for the composition carryover bytes. Reserve an extra
6027 space for up to 2 characters produced in a loop.
6028 (decode_coding_iso_2022): Abort if there isn't enough place in
6029 charbuf for the composition carryover bytes.
6030
60312011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6032
ae940cca
EZ
6033 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6034 aborting when %lld or %lll format is passed.
6035 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6036 %llo or %llx format is passed. (Bug#8545)
6037
03ab8921
EZ
6038 * window.c (window_scroll_line_based): Use a marker instead of
6039 simple variables to record original value of point. (Bug#7952)
6040
afda1437
EZ
6041 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6042 produced by %s or %c overflows available buffer space. (Bug#8545)
6043
f76dee0c
PE
60442011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6047 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6048
fdc5744d
JB
60492011-04-28 Juanma Barranquero <lekktu@gmail.com>
6050
6051 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6052
638f053a
JB
60532011-04-28 Juanma Barranquero <lekktu@gmail.com>
6054
6055 * keyboard.c (Qdelayed_warnings_hook): Define.
6056 (command_loop_1): Run `delayed-warnings-hook'
6057 if Vdelayed_warnings_list is non-nil.
6058 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6059 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6060
d178f871
EZ
60612011-04-28 Eli Zaretskii <eliz@gnu.org>
6062
6063 * doprnt.c (doprnt): Don't return value smaller than the buffer
6064 size if the message was truncated. (Bug#8545).
6065
b124fd93
JB
60662011-04-28 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6069 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6070
e810457d
PE
60712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6072
6073 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6074
ea51cceb
JB
60752011-04-27 Juanma Barranquero <lekktu@gmail.com>
6076
6077 * makefile.w32-in: Update dependencies.
6078
94dcfacf
EZ
60792011-04-27 Eli Zaretskii <eliz@gnu.org>
6080
6081 Improve `doprnt' and its usage. (Bug#8545)
6082 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6083 `format_end'. Remove support for %l as a conversion specifier.
6084 Don't use xrealloc. Improve diagnostics when the %l size modifier
6085 is used. Update the commentary.
6086
6087 * eval.c (verror): Simplify calculation of size_t.
6088
6089 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6090 messages.
6091
f61f41d7
PE
60922011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6093
6094 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6095 change.
6096
96fb4434
PE
60972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6098
6099 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6100 This makes this file independent of the recent pseudovector change.
6101
671875da 61022011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6103
69e9b5a3
PE
6104 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6105
b5f869a7 6106 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6107 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6108 Remove unused local.
c8926152 6109 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6110
841a1577 6111 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6112 GCC 4.6.0 optimizes based on type-based alias analysis.
6113 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6114 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6115 != &v->size, and therefore "v->size = 1; b->size = 2; return
6116 v->size;" must therefore return 1. This assumption is incorrect
6117 for Emacs, since it type-puns struct Lisp_Vector * with many other
6118 types. To fix this problem, this patch adds a new type struct
f904488f 6119 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6120 and pseudovectors, and helps optimizing compilers not get fooled
6121 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6122 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6123 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6124 the size member.
eab3844f
PE
6125 (XSETPVECTYPE): Rewrite in terms of new macro.
6126 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6127 This is a bit clearer, and further avoids the possibility of
6128 undesirable aliasing.
6129 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6130 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6131 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6132 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6133 (ASIZE): Now uses header.size rather than size.
6134 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6135 to avoid the hassle of writing XVECTOR (foo)->header.size.
6136 (struct vectorlike_header): New type.
eab3844f
PE
6137 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6138 object, to help avoid aliasing.
6139 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6140 (SUBRP): Likewise, since Lisp_Subr is a special case.
6141 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6142 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6143 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6144 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6145 changed to be "header.size" and "header.next".
6146 * buffer.h (struct buffer): Likewise.
6147 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6148 * frame.h (struct frame): Likewise.
6149 * process.h (struct Lisp_Process): Likewise.
6150 * termhooks.h (struct terminal): Likewise.
6151 * window.c (struct save_window_data, struct saved_window): Likewise.
6152 * window.h (struct window): Likewise.
6153 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6154 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6155 * buffer.c (init_buffer_once): Likewise.
6156 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6157 special case.
6158 * process.c (Fformat_network_address): Use local var for size,
6159 for brevity.
6160
0df1eac5
PE
6161 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6162
847ab9d1 6163 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6164 * data.c (atof): Remove decl; no longer used or needed.
6165 (digit_to_number): Move to lread.c.
6166 (Fstring_to_number): Use new string_to_number function, to be
6167 consistent with how the Lisp reader treats infinities and NaNs.
6168 Do not assume that floating-point numbers represent EMACS_INT
6169 without losing information; this is not true on most 64-bit hosts.
6170 Avoid double-rounding errors, by insisting on integers when
6171 parsing non-base-10 numbers, as the documentation specifies.
6172 * lisp.h (string_to_number): New decl, replacing ...
6173 (isfloat_string): Remove.
bc0a5c13 6174 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6175 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6176 appears to have been a coding error. Similarly, do not accept
6177 strings like +-1e0 as floating point numbers. Do not report
6178 overflow for integer overflows unless the base is not 10 which
6179 means we have no simple and reliable way to continue.
6180 Break out the floating-point parsing into a new
6181 function string_to_number, so that Fstring_to_number parses
6182 floating point numbers consistently with the Lisp reader.
04f2d78b 6183 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6184 (E_CHAR, EXP_INT): Remove, replacing with ...
6185 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6186 (string_to_number): New function, replacing isfloat_string.
6187 This function checks for valid syntax and produces the resulting
6188 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6189 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6190 so that overflow for non-base-10 numbers is reported only when
6191 there's no portable and simple way to convert to floating point.
452f4150 6192
67769ffc
PE
6193 * textprop.c (set_text_properties_1): Rewrite for clarity,
6194 and to avoid GCC warning about integer overflow.
6195
c20db43f
PE
6196 * intervals.h (struct interval): Use EMACS_INT for members
6197 where EMACS_UINT might cause problems. See
6198 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6199 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6200 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6201 All uses changed.
37aa2f85
PE
6202 (offset_intervals): Tell GCC not to worry about length overflow
6203 when negating a negative length.
c20db43f 6204
2538aa2f
PE
6205 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6206 (overrun_check_free): Likewise.
6207
f2d3008d
PE
6208 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6209 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6210 word size.
6211
ec8df744
PE
6212 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6213 (gnutls_make_error): Rename local to avoid shadowing.
6214 (gnutls_emacs_global_deinit): ifdef out; not used.
6215 (Fgnutls_boot): Use const for pointer to readonly storage.
6216 Comment out unused local. Fix pointer signedness problems.
6217
640ee02d
PE
6218 * lread.c (openp): Don't stuff size_t into an 'int'.
6219 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6220 about possible signed overflow.
6221
6048fb2a
PE
6222 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6223 (GDK_KEY_g): Don't define if already defined.
6224 (xg_prepare_tooltip): Avoid pointer signedness problem.
6225 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6226
fa3c87e1
PE
6227 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6228 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6229
2172544b
PE
6230 * xfns.c (Fx_window_property): Simplify a bit,
6231 to make a bit faster and to avoid GCC 4.6.0 warning.
6232 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6233
9b821a21
PE
6234 * fns.c (internal_equal): Don't assume size_t fits in int.
6235
3c616cfa
PE
6236 * alloc.c (compact_small_strings): Tighten assertion a little.
6237
c2982e87
PE
6238 Replace pEd with more-general pI, and fix some printf arg casts.
6239 * lisp.h (pI): New macro, generalizing old pEd macro to other
6240 conversion specifiers. For example, use "...%"pI"d..." rather
6241 than "...%"pEd"...".
6242 (pEd): Remove. All uses replaced with similar uses of pI.
6243 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6244 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6245 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6246 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6247 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6248 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6249 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6250 64-bit hosts.
6251 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6252 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6253 * print.c (safe_debug_print, print_object): Likewise.
6254 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6255 to int.
6f04d126
PE
6256 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6257 avoiding the 0 flag, which is not portable.
c2982e87
PE
6258 * process.c (Fmake_network_process): Use pI to avoid cast.
6259 * region-cache.c (pp_cache): Likewise.
6260 * xdisp.c (decode_mode_spec): Likewise.
6261 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6262 behavior on 64-bit hosts with printf arg.
6f04d126 6263 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6264 (x_stop_queuing_selection_requests): Likewise.
6265 (x_get_window_property): Don't truncate byte count to an 'int'
6266 when tracing.
0b432f21 6267
5e073ec7
PE
6268 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6269 here, since it parses constructs like leading '-' and spaces,
6270 which are not wanted; and it overflows with large numbers.
6271 Instead, simply match F[0-9]+, which is what is wanted anyway.
6272
36372bf9
PE
6273 * alloc.c: Remove unportable assumptions about struct layout.
6274 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6275 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6276 (allocate_vectorlike, make_pure_vector): Use the new macros,
6277 plus offsetof, to remove unportable assumptions about struct layout.
6278 These assumptions hold on all porting targets that I know of, but
6279 they are not guaranteed, they're easy to remove, and removing them
6280 makes further changes easier.
6281
0b432f21
PE
6282 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6283 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6284 (string_overrun_cookie): Now const. Use initializers that
6285 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6286 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6287 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6288 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6289 multiple of sizeof (EMACS_INT); it need not be, if
6290 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6291 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6292
895009e1
JB
62932011-04-26 Juanma Barranquero <lekktu@gmail.com>
6294
6295 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6296
6a7a1b0b
TZ
62972011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6298
6299 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6300 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6301 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6302
841a1577 63032011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6304
6305 * lisp.h (Qdebug): List symbol.
895009e1 6306 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6307 * keyboard.c (debug-on-event): New variable.
6308 (handle_user_signal): Break into debugger when debug-on-event
6309 matches the current signal symbol.
6310
f2d3ba6f
DN
63112011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6312
6313 * alloc.c (check_sblock, check_string_bytes)
6314 (check_string_free_list): Convert to standard C.
6315
42ce4c63
TZ
63162011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6317
6318 * w32.c (emacs_gnutls_push): Fix typo.
6319
825cd63c
EZ
63202011-04-25 Eli Zaretskii <eliz@gnu.org>
6321
fb11d64d
EZ
6322 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6323 "cast to pointer from integer of different size".
6324
825cd63c
EZ
6325 Improve doprnt and its use in verror. (Bug#8545)
6326 * doprnt.c (doprnt): Document the set of format control sequences
6327 supported by the function. Use SAFE_ALLOCA instead of always
6328 using `alloca'.
6329
6330 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6331 is one byte too soon. Don't use xrealloc; instead xfree and
6332 xmalloc anew.
6333
e061a11b
TZ
63342011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6335
6336 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6337 callbacks stage.
6338
6339 * gnutls.c: Renamed global_initialized to
6340 gnutls_global_initialized. Added internals for the
6341 :verify-hostname-error, :verify-error, and :verify-flags
6342 parameters of `gnutls-boot' and documented those parameters in the
6343 docstring. Start callback support.
9173deec
JB
6344 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6345 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6346 on error. Return error code.
e061a11b
TZ
6347 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6348 (emacs_gnutls_read): Likewise.
6349 (Fgnutls_boot): Return handshake error code.
6350 (emacs_gnutls_handle_error): New function.
6351 (wsaerror_to_errno): Likewise.
6352
6353 * w32.h (emacs_gnutls_pull): Add prototype.
6354 (emacs_gnutls_push): Likewise.
6355
6356 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6357 (emacs_gnutls_push): Likewise.
6358
63592011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6360
6361 * process.c (wait_reading_process_output): Check if GnuTLS
6362 buffered some data internally if no FDs are set for TLS
6363 connections.
6364
6365 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6366 (LIBS): Link to USER_LIBS.
6367 ($(BLD)/gnutls.$(0)): New target.
6368
fa6996bc
EZ
63692011-04-24 Eli Zaretskii <eliz@gnu.org>
6370
eb35682e
EZ
6371 * xdisp.c (handle_single_display_spec): Rename the
6372 display_replaced_before_p argument into display_replaced_p, to
6373 make it consistent with the commentary. Fix typos in the
6374 commentary.
6375
e2ad650c
EZ
6376 * textprop.c (syms_of_textprop): Remove dead code.
6377 (copy_text_properties): Delete obsolete commentary about an
6378 interface that was deleted long ago. Fix typos in the description
6379 of arguments.
6380
1b2de274
EZ
6381 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6382 to changes in oldXMenu/XMenu.h from 2011-04-16.
6383 <menu_help_message, prev_menu_help_message>: Constify.
6384 (IT_menu_make_room): menu->help_text is now `const char **';
6385 adjust.
6386
6387 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6388 to changes in oldXMenu/XMenu.h from 2011-04-16.
6389 (struct XMenu): Declare `help_text' `const char **'.
6390
6391 * xfaces.c <Qunspecified>: Make extern again.
6392
6393 * syntax.c: Include sys/types.h before including regex.h, as
6394 required by Posix.
6395
762b15be
EZ
6396 * doc.c (get_doc_string): Improve the format passed to `error'.
6397
6398 * doprnt.c (doprnt): Improve commentary.
6399
6400 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6401
6402 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6403 them with etags.
6404
f1052e5d
EZ
6405 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6406 changes in globals.h immediately force recompilation.
762b15be
EZ
6407 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6408 $(CURDIR)/s/ms-w32.h.
6409 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6410
fa6996bc
EZ
6411 * character.c (Fchar_direction): Function deleted.
6412 (syms_of_character): Don't defsubr it.
6413 <char-direction-table>: Deleted.
6414
e6c3da20
EZ
64152011-04-23 Eli Zaretskii <eliz@gnu.org>
6416
6417 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6418 * doprnt.c: Include limits.h.
6419 (SIZE_MAX): New macro.
04f2d78b
CB
6420 (doprnt): Return a size_t value. 2nd arg is now size_t.
6421 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6422 Improve overflow protection. Support `l' modifier for integer
6423 conversions. Support %l conversion. Don't assume an EMACS_INT
6424 argument for integer conversions and for %c.
6425
6426 * lisp.h (doprnt): Restore prototype.
6427
6428 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6429 $(SRC)/character.h.
6430
6431 * Makefile.in (base_obj): Add back doprnt.o.
6432
6433 * deps.mk (doprnt.o): Add back prerequisites.
6434 (callint.o): Depend on character.h.
6435
6436 * eval.c (internal_lisp_condition_case): Include the handler
6437 representation in the error message.
6438 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6439 when breaking from the loop.
6440
6441 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6442
6443 * callint.c (Fcall_interactively): When displaying error message
6444 about invalid control letter, pass the character's codepoint, not
6445 a pointer to its multibyte form. Improve display of the character
6446 in octal and display also its hex code.
6447
6448 * character.c (char_string): Use %x to display the (unsigned)
6449 codepoint of an invalid character, to avoid displaying a bogus
6450 negative value.
6451
6452 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6453 `error', not SYMBOL_NAME itself.
6454
6455 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6456 character arguments to `error'.
6457
6458 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6459 to `error' in error message about FINAL_CHAR argument. Make sure
6460 FINAL_CHAR is a character, and use %c when it is passed as
6461 argument to `error'.
6462
4ffd0d6b 64632011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6464
6465 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6466
6467 * w32.c: Include <time.h>.
6468 (sys_localtime): New function.
6469
4ffd0d6b 64702011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6471
6472 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6473
4ffd0d6b 6474 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6475
4ffd0d6b 64762011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6477
4ffd0d6b
GM
6478 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6479 zombies (Bug#8467).
aac0c6e3 6480
04c56954
EZ
64812011-04-19 Eli Zaretskii <eliz@gnu.org>
6482
6483 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6484 gl_state.e_property when gl_state.object is Qt.
6485
6486 * insdel.c (make_gap_larger): Remove limitation of buffer size
6487 to <= INT_MAX.
6488
16a43933
CY
64892011-04-18 Chong Yidong <cyd@stupidchicken.com>
6490
6491 * xdisp.c (lookup_glyphless_char_display)
6492 (produce_glyphless_glyph): Handle cons cell entry in
6493 glyphless-char-display.
6494 (Vglyphless_char_display): Document it.
6495
6496 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6497 glyphless-char-display.
6498
4581706e
CY
64992011-04-17 Chong Yidong <cyd@stupidchicken.com>
6500
6501 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6502
6503 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6504
6505 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6506 definition for no-X builds.
6507
4887c6e2 65082011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6509
fd35b6f9
PE
6510 Static checks with GCC 4.6.0 and non-default toolkits.
6511
5c1ccb01
PE
6512 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6513
006c5daa
PE
6514 * process.c (keyboard_bit_set): Define only if SIGIO.
6515 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6516 (send_process): Repair possible setjmp clobbering.
6517
efc736d3
PE
6518 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6519
4e2fe2e6
PE
6520 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6521
f97334a2
PE
6522 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6523
4e75f29d
PE
6524 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6525 Define only if needed.
6526
90efadd1
PE
6527 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6528 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6529 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6530
3c647824
PE
6531 * dispextern.h (struct redisplay_interface): Rename param
6532 to avoid shadowing.
e264f262 6533 * termhooks.h (struct terminal): Likewise.
761383f4 6534 * xterm.c (xembed_send_message): Likewise.
3c647824 6535
b58c5c4a
PE
6536 * insdel.c (make_gap_smaller): Define only if
6537 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6538
cad59032
PE
6539 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6540 it.
6541
c339dc2e
PE
6542 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6543 so that we aren't warned about unused symbols.
6544
91a3e27b
PE
6545 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6546
399c71d3 6547 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6548
8ffc96f5
PE
6549 * xfns.c (x_real_positions): Mark locals as initialized.
6550
eef9bc79
PE
6551 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6552
098db9dd
PE
6553 * xterm.c: Fix problems found by static analysis with other toolkits.
6554 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6555 (x_dispatch_event): Declare static if USE_GTK, and
6556 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6557 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6558 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6559 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6560 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6561
eb18f6cc
PE
6562 * xmenu.c (menu_help_callback): Pointer type fixes.
6563 Use const pointers when pointing at readonly data. Avoid pointer
6564 signedness clashes.
6565 (FALSE): Remove unused macro.
6566 (update_frame_menubar): Remove unused decl.
6567
1fe72bf8
PE
6568 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6569
60d9e1db
PE
6570 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6571 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6572 (single_menu_item): Rename local to avoid shadowing.
6573
39261c26
PE
6574 * keyboard.c (make_lispy_event): Remove unused local var.
6575
018c5e19
PE
6576 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6577 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6578
63d2b86e
PE
6579 * bitmaps: Change bitmaps from unsigned char back to the X11
6580 compatible char. Avoid the old compiler warnings about
6581 out-of-range initializers by using, for example, '\xab' rather
6582 than 0xab.
6583
aefd87e1
PE
6584 * xgselect.c (xgselect_initialize): Check vs interface
6585 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6586
bf501fb9
PE
6587 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6588
e9829fdf
PE
6589 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6590 to read-only memory.
6591
1086c095
PE
6592 * fns.c (vector): Remove; this old hack is no longer needed.
6593
2baccd04 6594 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6595 Remove unused var.
dde42981 6596 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6597
72391843 6598 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6599
436c16df 6600 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6601 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6602 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6603
92bb796d 6604 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6605 (x_term_init): Remove local to avoid shadowing.
92bb796d 6606
764430a3 6607 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6608
6609 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6610 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6611
d1dfb56c
EZ
66122011-04-16 Eli Zaretskii <eliz@gnu.org>
6613
c4354cb4
EZ
6614 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6615
d1dfb56c
EZ
6616 Fix regex.c, syntax.c and friends for buffers > 2GB.
6617 * syntax.h (struct gl_state_s): Declare character position members
6618 EMACS_INT.
6619
6620 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6621
04f2d78b
CB
6622 * textprop.c (verify_interval_modification, interval_of):
6623 Declare arguments EMACS_INT.
d1dfb56c
EZ
6624
6625 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6626 EMACS_INT.
6627
6628 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6629
6630 * indent.c (Fvertical_motion): Local variable it_start is now
6631 EMACS_INT.
6632
6633 * regex.c (re_match, re_match_2, re_match_2_internal)
6634 (bcmp_translate, regcomp, regexec, print_double_string)
6635 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6636 (re_compile_pattern, re_exec): Declare arguments and local
6637 variables `size_t' and `ssize_t' and return values `regoff_t', as
6638 appropriate.
6639 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6640 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6641 <compile_stack_type>: `size' and `avail' are now `size_t'.
6642
6643 * regex.h <regoff_t>: Use ssize_t, not int.
6644 (re_search, re_search_2, re_match, re_match_2): Arguments that
6645 specify buffer/string position and length are now ssize_t and
6646 size_t. Return type is regoff_t.
6647
613052cd
BK
66482011-04-16 Ben Key <bkey76@gmail.com>
6649
6650 * nsfont.m: Fixed bugs in ns_get_family and
6651 ns_descriptor_to_entity that were caused by using free to
6652 deallocate memory blocks that were allocated by xmalloc (via
6653 xstrdup). This caused Emacs to crash when compiled with
6654 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6655 --enable-checking=xmallocoverrun). xfree is now used to
6656 deallocate these memory blocks.
6657
4170f62f 66582011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6659
71b41406
PE
6660 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6661
9587a89d
PE
6662 emacs_write: Accept and return EMACS_INT for sizes.
6663 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6664 et seq.
6665 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6666 Accept and return EMACS_INT.
6667 (emacs_gnutls_write): Return the number of bytes written on
6668 partial writes.
6669 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6670 (emacs_read, emacs_write): Remove check for negative size, as the
6671 Emacs source code has been audited now.
9587a89d
PE
6672 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6673 (emacs_read, emacs_write): Use it.
273a5f82
PE
6674 * process.c (send_process): Adjust to the new signatures of
6675 emacs_write and emacs_gnutls_write. Do not attempt to store
6676 a byte offset into an 'int'; it might overflow.
9587a89d 6677 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6678
3e047f51
PE
6679 * sound.c: Don't assume sizes fit in 'int'.
6680 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6681 Return EMACS_INT, not int.
3e047f51 6682 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6683 Accept EMACS_INT, not int.
6684 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6685 record read return values.
6686
cc39a9db
BK
66872011-04-15 Ben Key <bkey76@gmail.com>
6688
c9d0ec6d
JB
6689 * keyboard.c (Qundefined): Don't declare static since it is used
6690 in nsfns.m.
6691 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6692 static since they are used in nsfont.m.
cc39a9db 6693
6c60eb9f
SM
66942011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6695
6696 * process.c (Qprocessp): Don't declare static.
6697 * lisp.h (Qprocessp): Declare again.
6698
7990b61a
JB
66992011-04-15 Juanma Barranquero <lekktu@gmail.com>
6700
6701 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6702
5d4cb038
PE
67032011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6704
8bd7b830 6705 Improve C-level modularity by making more things 'static'.
cd64ea1d 6706
e3b27b31
PE
6707 Don't publish debugger-only interfaces to other modules.
6708 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6709 (verify_bytepos, count_markers): Move decls to the only modules
6710 that need them.
6711 * region-cache.h (pp_cache): Likewise.
6712 * window.h (check_all_windows): Likewise.
6713 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6714
5d4cb038
PE
6715 * sysdep.c (croak): Now static, if
6716 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6717 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6718
6719 * alloc.c (refill_memory_reserve): Now static if
6720 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6721 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6722
e87b6180
PE
6723 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6724 Define only if USE_LUCID.
6725
ac64929e
PE
6726 * xrdb.c (x_customization_string, x_rm_string): Now static.
6727
6f37259d
PE
6728 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6729 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6730
1683e3ab
PE
6731 * xdisp.c (draw_row_with_mouse_face): Now static.
6732 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6733
de9c2632
PE
6734 * window.h (check_all_windows): Mark externally visible.
6735
2b96acb7
PE
6736 * window.c (window_deletion_count): Now static.
6737
6738 * undo.c: Make symbols static if they're not exported.
6739 (last_undo_buffer, last_boundary_position, pending_boundary):
6740 Now static.
6741
50436f33
PE
6742 * textprop.c (interval_insert_behind_hooks): Now static.
6743 (interval_insert_in_front_hooks): Likewise.
6744
64520e5c
PE
6745 * term.c: Make symbols static if they're not exported.
6746 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6747 (max_frame_lines, tty_set_terminal_modes):
6748 (tty_reset_terminal_modes, tty_turn_off_highlight):
6749 (get_tty_terminal): Now static.
6750 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6751 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6752 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6753 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6754 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6755
1fa53021
PE
6756 * sysdep.c: Make symbols static if they're not exported.
6757 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6758 Now static.
6759 (sigprocmask_set, full_mask): Remove; unused.
6760 (wait_debugging): Mark as visible.
6761 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6762 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6763
d4b43b22
PE
6764 * syntax.c (syntax_temp): Define only if !__GNUC__.
6765
b7c513d0
PE
6766 * sound.c (current_sound_device, current_sound): Now static.
6767
989b29ad
PE
6768 * search.c (searchbufs, searchbuf_head): Now static.
6769
13a55a78
PE
6770 * scroll.c (scroll_cost): Remove; unused.
6771 * dispextern.h (scroll_cost): Remove decl.
6772
de68a1fc
PE
6773 * region-cache.h (pp_cache): Mark as externally visible.
6774
40ccffa6
PE
6775 * process.c: Make symbols static if they're not exported.
6776 (process_tick, update_tick, create_process, chan_process):
6777 (Vprocess_alist, proc_buffered_char, datagram_access):
6778 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6779 (deactivate_process): Mark defn as static, as well as decl.
6780 * lisp.h (create_process): Remove decl.
6781 * process.h (chan_process, Vprocess_alist): Remove decls.
6782
ad64fc97
PE
6783 * print.c: Make symbols static if they're not exported.
6784 (print_depth, new_backquote_output, being_printed, print_buffer):
6785 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6786 (print_interval, print_number_index, initial_stderr_stream):
6787 Now static.
6788 * lisp.h (Fprinc): Remove decl.
6789 (debug_output_compilation_hack): Mark as externally visible.
6790
adddb265
PE
6791 * sysdep.c (croak): Move decl from here to syssignal.h.
6792 * syssignal.h (croak): Put it here, so the API can be checked when
6793 'croak' is called from dissociate_if_controlling_tty.
6794
1717ede2
PE
6795 * minibuf.c: Make symbols static if they're not exported.
6796 (minibuf_save_list, choose_minibuf_frame): Now static.
6797 * lisp.h (choose_minibuf_frame): Remove decl.
6798
fa5fb2bc
PE
6799 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6800
1e3890d1
PE
6801 * lread.c: Make symbols static if they're not exported.
6802 (read_objects, initial_obarray, oblookup_last_bucket_number):
6803 Now static.
6804 (make_symbol): Remove; unused.
6805 * lisp.h (initial_obarray, make_symbol): Remove decls.
6806
8a1414fa
PE
6807 * keyboard.c: Make symbols static if they're not exported.
6808 (single_kboard, recent_keys_index, total_keys, recent_keys):
6809 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6810 (this_single_command_key_start, echoing, last_auto_save):
6811 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6812 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6813 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6814 (Vlispy_mouse_stem, double_click_count):
6815 Now static.
6816 (force_auto_save_soon): Define only if SIGDANGER.
6817 (ignore_mouse_drag_p): Now static if
6818 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6819 (print_help): Remove; unused.
6820 (stop_character, last_timer_event): Mark as externally visible.
6821 * keyboard.h (ignore_mouse_drag_p): Declare only if
6822 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6823 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6824 * lisp.h (echoing): Remove decl.
6825 (force_auto_save_soon): Declare only if SIGDANGER.
6826 * xdisp.c (redisplay_window): Simplify code, to make it more
6827 obvious that ignore_mouse_drag_p is not accessed if !defined
6828 USE_GTK && !defined HAVE_NS.
6829
93ea6e8f
PE
6830 * intervals.c: Make symbols static if they're not exported.
6831 (merge_properties_sticky, merge_interval_right, delete_interval):
6832 Now static.
6833 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6834
77382fcc
PE
6835 * insdel.c: Make symbols static if they're not exported.
6836 However, leave prepare_to_modify_buffer alone. It's never
6837 called from outside this function, but that appears to be a bug.
6838 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6839 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6840 (adjust_after_replace_noundo): Remove; unused.
6841 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6842 (signal_before_change): Remove decls.
77382fcc 6843
9306c32e
PE
6844 * indent.c (val_compute_motion, val_vmotion): Now static.
6845
cd44d2eb
PE
6846 * image.c: Make symbols static if they're not exported.
6847 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6848 if USE_GTK.
6849 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6850 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6851
ad9a7a06
PE
6852 * fringe.c (standard_bitmaps): Now static.
6853 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6854
81626931
PE
6855 * frame.c: Make symbols static if they're not exported.
6856 (x_report_frame_params, make_terminal_frame): Now static.
6857 (get_frame_param): Now static, unless HAVE_NS.
6858 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6859 (x_get_resource_string): Remove; not used.
6860 * frame.h (make_terminal_frame, x_report_frame_params):
6861 (x_get_resource_string); Remove decls.
6862 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6863 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6864
239f9db9
PE
6865 * font.c, fontset.c: Make symbols static if they're not exported.
6866 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6867 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6868 * font.c (font_close_object): Now static.
6869 * font.h (font_close_object): Remove.
6870 * fontset.c (FONTSET_OBJLIST): Remove.
6871 (free_realized_fontset) #if-0 the body, which does nothing.
6872 (face_suitable_for_char_p): #if-0, as it's never called.
6873 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6874 * xfaces.c (face_at_string_position):
6875 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6876 since 0 is always ASCII.
6877
dfcf3579
PE
6878 * fns.c (weak_hash_tables): Now static.
6879
5045092b
PE
6880 * fileio.c: Make symbols static if they're not exported.
6881 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6882 (Vwrite_region_annotation_buffers): Now static.
6883
57a96f5c
PE
6884 * eval.c: Make symbols static if they're not exported.
6885 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6886 * lisp.h (backtrace_list): Remove decl.
6887
35f08c38
PE
6888 * emacs.c: Make symbols static if they're not exported.
6889 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6890 (fatal_error_code, fatal_error_signal_hook, standard_args):
6891 Now static.
6892 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6893 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6894 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6895 * lisp.h (fatal_error_signal_hook): Remove decl.
6896 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6897
f44bd759
PE
6898 * editfns.c: Move a (normally-unused) function to its only use.
6899 * editfns.c, lisp.h (get_operating_system_release): Remove.
6900 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6901 worth the hassle of breaking this out.
6902
b532497d
PE
6903 * xterm.c: Make symbols static if they're not exported.
6904 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6905 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6906 (x_destroy_window, x_delete_display):
6907 Now static.
6908 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6909 (x_mouse_leave): Remove; unused.
6910 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6911 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6912 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6913 Remove decls.
6914 (x_mouse_leave): Declare only if WINDOWSNT.
6915 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6916 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6917 USE_X_TOOLKIT.
6918
1675728f
PE
6919 * ftxfont.c: Make symbols static if they're not exported.
6920 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6921 HAVE_FREETYPE.
6922 * font.h (ftxfont_driver): Likewise.
6923
e4cebfca
PE
6924 * xfns.c: Make symbols static if they're not exported.
6925 (x_last_font_name, x_display_info_for_name):
6926 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6927 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6928 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6929 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6930 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6931 (last_show_tip_args): Now static.
6932 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6933 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6934 (x_screen_planes): Remove; unused.
6935 * dispextern.h (x_screen_planes): Remove decl.
6936
5bf46f05
PE
6937 * dispnew.c: Make symbols static if they're not exported.
6938 * dispextern.h (redraw_garbaged_frames, scrolling):
6939 (increment_row_positions): Remove.
6940 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6941 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6942 Now static.
6943 (redraw_garbaged_frames): Remove; unused.
6944
435f4c28
PE
6945 * xfaces.c: Make symbols static if they're not exported.
6946 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6947 Remove decls.
6948 * xterm.h (defined_color): Remove decls.
6949 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6950 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6951 (menu_face_changed_default, defined_color, free_realized_face):
6952 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6953 (ascii_face_of_lisp_face): Remove; unused.
6954
8524aef3
PE
6955 * xdisp.c: Make symbols static if they're not exported.
6956 * dispextern.h (scratch_glyph_row, window_box_edges):
6957 (glyph_to_pixel_coords, set_cursor_from_row):
6958 (get_next_display_element, set_iterator_to_next):
6959 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6960 (show_mouse_face): Remove decls
6961 * frame.h (message_buf_print): Likewise.
6962 * lisp.h (pop_message, set_message, check_point_in_composition):
6963 Likewise.
6964 * xterm.h (set_vertical_scroll_bar): Likewise.
6965 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6966 (message_buf_print, scratch_glyph_row, displayed_buffer):
6967 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6968 (get_next_display_element, show_mouse_face, window_box_edges):
6969 (frame_to_window_pixel_xy, check_point_in_composition):
6970 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6971 (glyph_to_pixel_coords): Remove; unused.
6972
16390cd2
PE
6973 * dired.c (file_name_completion): Now static.
6974
6975 * dbusbind.c (xd_in_read_queued_messages): Now static.
6976
a25f4dfa
PE
6977 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6978 * data.c (circular_list_error): Remove.
6979
14a9c8df
PE
6980 * commands.h (last_point_position, last_point_position_buffer):
6981 (last_point_position_window): Remove decls.
6982 * keyboard.c: Make these variables static.
6983
04f2d78b
CB
6984 * coding.h (coding, code_convert_region, encode_coding_gap):
6985 Remove decls.
74ab6df5
PE
6986 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6987 (iso_code_class, detect_coding, code_convert_region): Now static.
6988 (encode_coding_gap): Remove; unused.
6989
38dfbee1
PE
6990 * chartab.c (chartab_chars, chartab_bits): Now static.
6991
a2cb4e63
PE
6992 * charset.h (charset_iso_8859_1): Remove decl.
6993 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6994 Now static.
6995
127198fd
PE
6996 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6997 * ccl.c (Vccl_program_table): Now static.
6998 (check_ccl_update): Remove; unused.
6999
d85b608f
PE
7000 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7001 * category.h: ... from here.
7002 * category.c (check_category_table, set_category_set): Now static.
7003
31cd66f3
PE
7004 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7005 * lisp.h: Remove these decls.
7006
c358e587
PE
7007 * buffer.c (buffer_count): Remove unused var.
7008
e78aecca
PE
7009 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7010 so that it's not optimized away.
7011 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7012 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7013 exported only to the debugger.
7014
e192d7d3 7015 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7016 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7017
92470028
PE
7018 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7019 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7020 was inaccessible from Lisp.
7021 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7022 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7023
244ed907
PE
7024 alloc.c: Import and export fewer symbols, and remove unused items.
7025 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7026 is defined.
7027 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7028 it's not optimized away by whole-program optimization.
7029 (message_enable_multibyte, free_misc): Remove.
7030 (catchlist, handlerlist, mark_backtrace):
7031 Declare only if BYTE_MARK_STACK.
7032 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7033 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7034 (message_enable_multibyte): Remove decl.
7035 (free_misc, interval_free_list, float_block, float_block_index):
7036 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7037 (cons_free_list, last_marked_index):
7038 Now static.
7039 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7040 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7041 (mark_backtrace): Define only if BYTE_MARK_STACK.
7042 * xdisp.c (message_enable_multibyte): Now static.
7043
61c2b50e 7044 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7045 This makes it easier for human readers (and static analyzers)
7046 to see whether these variables are used from other modules.
7047 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7048 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7049 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7050 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7051 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7052 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7053 * xmenu.c, xselect.c:
7054 Declare Q* vars static if they are not used in other modules.
7055 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7056 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7057 Remove decls of unexported vars.
7058 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7059
95c82688
PE
7060 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7061
16a97296
PE
7062 Make Emacs functions such as Fatom 'static' by default.
7063 This makes it easier for human readers (and static analyzers)
7064 to see whether these functions can be called from other modules.
7065 DEFUN now defines a static function. To make the function external
7066 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7067 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7068 (Finit_image_library):
16a97296
PE
7069 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7070 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7071 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7072 Remove decls, since these functions are now static.
7073 (Funintern, Fget_internal_run_time): New decls, since these functions
7074 were already external.
95c82688 7075
16a97296
PE
7076 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7077 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7078 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7079 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7080 * keyboard.c, keymap.c, lread.c:
7081 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7082 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7083 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7084 Mark functions with DEFUE instead of DEFUN,
7085 if they are used in other modules.
7086 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7087 decls for now-static functions.
7088 * buffer.h (Fdelete_overlay): Remove decl.
7089 * callproc.c (Fgetenv_internal): Mark as internal.
7090 * composite.c (Fremove_list_of_text_properties): Remove decl.
7091 (Fcomposition_get_gstring): New forward static decl.
7092 * composite.h (Fcomposite_get_gstring): Remove decl.
7093 * dired.c (Ffile_attributes): New forward static decl.
7094 * doc.c (Fdocumntation_property): New forward static decl.
7095 * eval.c (Ffetch_bytecode): New forward static decl.
7096 (Funintern): Remove extern decl; now in .h file where it belongs.
7097 * fileio.c (Fmake_symbolic_link): New forward static decl.
7098 * image.c (Finit_image_library): New forward static decl.
7099 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7100 * intervals.h (Fprevious_property_change):
7101 (Fremove_list_of_text_properties): Remove decls.
7102 * keyboard.c (Fthis_command_keys): Remove decl.
7103 (Fcommand_execute): New forward static decl.
7104 * keymap.c (Flookup_key): New forward static decl.
7105 (Fcopy_keymap): Now static.
7106 * keymap.h (Flookup_key): Remove decl.
7107 * process.c (Fget_process): New forward static decl.
7108 (Fprocess_datagram_address): Mark as internal.
7109 * syntax.c (Fsyntax_table_p): New forward static decl.
7110 (skip_chars): Remove duplicate decl.
7111 * textprop.c (Fprevious_property_change): New forward static decl.
7112 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7113 Now internal.
7114 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7115 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7116
785bbd42
PE
7117 * editfns.c (Fformat): Remove unreachable code.
7118
8b913b57
AS
71192011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7120
7121 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7122 change. (Bug#8496)
7123
a6744a35
EZ
71242011-04-13 Eli Zaretskii <eliz@gnu.org>
7125
7126 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7127 when at ZV. (Bug#8487)
7128
e7974947
AS
71292011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7130
baad03f0
AS
7131 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7132 (Bug#8437)
7133 * keyboard.c (parse_tool_bar_item): Likewise.
7134 * sound.c (sound_cleanup, alsa_close): Likewise.
7135 * termcap.c (tgetent): Likewise.
7136 * xfns.c (x_default_font_parameter): Likewise.
7137 * xsettings.c (read_and_apply_settings): Likewise.
7138
e7974947
AS
7139 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7140 (overrun_check_free): Protoize.
7141
28272684
PE
71422011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7143
7144 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7145 since callers should never pass a negative size.
7146 Change the signature to match that of plain 'read' and 'write'; see
7147 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7148 * lisp.h: Update prototypes of emacs_write and emacs_read.
7149
11997c76
EZ
71502011-04-11 Eli Zaretskii <eliz@gnu.org>
7151
7152 * xdisp.c (redisplay_window): Don't try to determine the character
7153 position of the scroll margin if the window start point w->startp
e896f03c 7154 is outside the buffer's accessible region. (Bug#8468)
11997c76 7155
8a2cbd72
EZ
71562011-04-10 Eli Zaretskii <eliz@gnu.org>
7157
7158 Fix write-region and its subroutines for buffers > 2GB.
7159 * fileio.c (a_write, e_write): Modify declaration of arguments and
7160 local variables to support buffers larger than 2GB.
7161 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7162
7163 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7164 argument, local variables, and return value.
7165
7166 * lisp.h: Update prototypes of emacs_write and emacs_read.
7167
7168 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7169
4073e537 71702011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7171
1ebfdcb6
PE
7172 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7173
b2ded58d
PE
7174 Fix more problems found by GCC 4.6.0's static checks.
7175
7d66342c
PE
7176 * xdisp.c (vmessage): Use a better test for character truncation.
7177
bbf47d44
PE
7178 * charset.c (load_charset_map): <, not <=, for optimization,
7179 and to avoid potential problems with integer overflow.
9248994d 7180 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7181 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7182 * editfns.c (Fformat): Likewise.
1e69125e 7183 * syntax.c (skip_chars): Likewise.
3befa583 7184
e3019616
PE
7185 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7186 This also lets GCC 4.6.0 generate slightly better loop code.
7187
becfa255
PE
7188 * callint.c (Fcall_interactively): <, not <=, for optimization.
7189 (Fcall_interactively): Count the number of arguments produced,
7190 not the number of arguments given. This is simpler and lets GCC
7191 4.6.0 generate slightly better code.
7192
dae0cd48
PE
7193 * ftfont.c: Distingish more carefully between FcChar8 and char.
7194 The previous code passed unsigned char * to a functions like
7195 strlen and xstrcasecmp that expect char *, which does not
7196 conform to the C standard.
7197 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7198 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7199 char * when the C standard requires it.
7200
76032d70
PE
7201 * keyboard.c (read_char): Remove unused var.
7202
eb3f1cc8
PE
7203 * eval.c: Port to Windows vsnprintf (Bug#8435).
7204 Include <limits.h>.
7205 (SIZE_MAX): Define if the headers do not.
7206 (verror): Do not give up if vsnprintf returns a negative count.
7207 Instead, grow the buffer. This ports to Windows vsnprintf, which
7208 does not conform to C99. Problem reported by Eli Zaretskii.
7209 Also, simplify the allocation scheme, by avoiding the need for
7210 calling realloc, and removing the ALLOCATED variable.
7211
70476b54
PE
7212 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7213
12020a9e
PE
7214 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7215 But keep the doprint source code for now, as we might revamp it
7216 and use it again (Bug#8435).
ea6c7ae6
PE
7217 * lisp.h (doprnt): Remove.
7218 * Makefile.in (base_obj): Remove doprnt.o.
7219 * deps.mk (doprnt.o): Remove.
7220
5fdb398c
PE
7221 error: Print 32- and 64-bit integers portably (Bug#8435).
7222 Without this change, on typical 64-bit hosts error ("...%d...", N)
7223 was used to print both 32- and 64-bit integers N, which relied on
7224 undefined behavior.
7225 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7226 New macro.
7227 * lisp.h (error, verror): Mark as printf-like functions.
7228 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7229 Report overflow in size calculations when allocating printf buffer.
7230 Do not truncate output string at its first null byte.
7231 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7232 Truncate the output at a character boundary, since vsnprintf does not
7233 do that.
7234 * charset.c (check_iso_charset_parameter): Convert internal
7235 character to string before calling 'error', since %c now has the
7236 printf meaning.
7237 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7238 overflow when computing char to be passed to 'error'. Do not
7239 pass Lisp_Object to 'error'; pass the integer instead.
7240 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7241 formatted with plain %d.
7242
b189fa66
PE
7243 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7244
bff87ef0
PE
7245 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7246
7e2cac20
PE
7247 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7248
ce4d90b5
PE
7249 * xterm.c (x_catch_errors): Remove duplicate declaration.
7250
266c9547
PE
7251 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7252
79c49ad2
PE
7253 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7254
368f4090
JM
72552011-04-10 Jim Meyering <meyering@redhat.com>
7256
7257 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7258 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7259 return ssize_t not "int", and use size_t as the buffer length.
7260 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7261 * gnutls.h: Update declarations.
7262 * process.c (read_process_output): Use ssize_t, to match.
7263 (send_process): Likewise.
7264
a32d4040
CY
72652011-04-09 Chong Yidong <cyd@stupidchicken.com>
7266
7267 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7268
8546720e 72692011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7270
04f2d78b
CB
7271 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7272 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7273
8546720e
GM
7274 * xterm.c (handle_one_xevent):
7275 * xmenu.c (create_and_show_popup_menu):
7276 * xselect.c (x_decline_selection_request)
7277 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7278
0a2f5c1a 72792011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7280
7281 Fix some uses of `int' instead of EMACS_INT.
7282 * search.c (string_match_1, fast_string_match)
7283 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7284 (scan_buffer, find_next_newline_no_quit)
7285 (find_before_next_newline, search_command, Freplace_match)
7286 (Fmatch_data): Make some `int' variables be EMACS_INT.
7287
7288 * xdisp.c (display_count_lines): 3rd argument and return value now
7289 EMACS_INT. All callers changed.
7290 (pint2hrstr): Last argument is now EMACS_INT.
7291
7292 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7293 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7294 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7295 (decode_coding_utf_16, decode_coding_emacs_mule)
7296 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7297 (decode_coding_ccl, decode_coding_charset)
7298 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7299 (decode_coding_iso_2022, decode_coding_emacs_mule)
7300 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7301 <char_offset, last_offset>: Declare EMACS_INT.
7302 (encode_coding_utf_8, encode_coding_utf_16)
7303 (encode_coding_emacs_mule, encode_invocation_designation)
7304 (encode_designation_at_bol, encode_coding_iso_2022)
7305 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7306 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7307 Declare EMACS_INT.
7308 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7309 (encode_invocation_designation): Last argument P_NCHARS is now
7310 EMACS_INT.
7311 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7312 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7313
7314 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7315 All users changed.
7316
7317 * ccl.c (Fccl_execute_on_string): Declare some variables
7318 EMACS_INT.
7319
8546720e 73202011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7321
7322 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7323
4e19a977
CS
73242011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7325
7326 * process.c (Fformat_network_address): Doc fix.
7327
87302331
R
73282011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7329
ee7683eb 7330 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7331
cbb59342
CY
73322011-04-08 Chong Yidong <cyd@stupidchicken.com>
7333
7334 * keyboard.c (read_char): Call Lisp function help-form-show,
7335 instead of using internal_with_output_to_temp_buffer.
7336 (Qhelp_form_show): New var.
e0d38eeb 7337 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7338
7339 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7340
7341 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7342
e67a13ab
CY
73432011-04-06 Chong Yidong <cyd@stupidchicken.com>
7344
04f2d78b
CB
7345 * process.c (Flist_processes): Remove to Lisp.
7346 (list_processes_1): Delete.
e67a13ab 7347
973f782d
EZ
73482011-04-06 Eli Zaretskii <eliz@gnu.org>
7349
7c106b1e
EZ
7350 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7351
973f782d
EZ
7352 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7353
41cf7d1a 73542011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7355
ca23cc88
PE
7356 Fix more problems found by GCC 4.6.0's static checks.
7357
f390e2d5
PE
7358 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7359
42eea0d0
PE
7360 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7361
b69769da 7362 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7363
f9541e84
PE
7364 * xdisp.c (vmessage): Mark as a printf-like function.
7365
13841b55
PE
7366 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7367
c136c10f
PE
7368 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7369
5e2d4a30
PE
7370 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7371 printf-like functions.
7372 (tiff_load): Add casts to remove these marks before passing them
7373 to system-supplied API.
7374
583f48b9
PE
7375 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7376
b25d760e
PE
7377 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7378 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7379 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7380 directly, rather than having caller test rule sign. This avoids
7381 some unnecessary tests.
7382 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7383 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7384 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7385
bc7b6697 7386 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7387 (xfont_open): Avoid unnecessary tests.
bc7b6697 7388
27ccc379
PE
7389 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7390
dcd5c89a
PE
7391 * composite.h, composite.c (composition_gstring_put_cache):
7392 Use EMACS_INT, not int, for length.
7393
b13a45c6
PE
7394 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7395 breaking out part of COMPOSITION_DECODE_RULE.
7396 (COMPOSITION_DECODE_RULE): Use it.
7397 * composite.c (get_composition_id): Remove unused local vars,
7398 by using the new macro.
7399
1e792e4d
PE
7400 * textprop.c (set_text_properties_1): Change while to do-while,
7401 since the condition is always true at first.
7402
dc6c6455 7403 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7404 (interval_deletion_adjustment): Return unsigned value.
7405 All uses changed.
dc6c6455 7406
aba7731a
PE
7407 * process.c (list_processes_1, create_pty, read_process_output):
7408 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7409 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7410 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7411 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7412 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7413
fdfc4bf3
PE
7414 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7415
fca8fe46 7416 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7417 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7418
06a0259a 7419 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7420 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7421 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7422
e7b9e80f
PE
7423 * print.c (print_error_message): Avoid int overflow.
7424
56201685
PE
7425 * font.c (font_list_entities): Redo for clarity,
7426 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7427
78834453 7428 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7429 (font_score): Avoid potential overflow in diff calculation.
78834453 7430
0bc0b309 7431 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7432 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7433
e610eaca
PE
7434 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7435
b895abce
PE
7436 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7437 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7438 can always succeed if overflow has undefined behavior.
7439
1f1d9321 7440 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7441 (wordify): Omit three unnecessary tests.
1f1d9321 7442
c59478bc
PE
7443 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7444 All callers changed. This avoids the need for an unused var.
7445
79b73827
PE
7446 * casefiddle.c (casify_region): Remove var that is set but not used.
7447
a4db5dfe
PE
7448 * dired.c (file_name_completion): Remove var that is set but not used.
7449
43aae36e
PE
7450 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7451
2a47c44d 7452 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7453 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7454
a37c69bf
PE
7455 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7456 Check for integer overflow on size calculations.
7457
328ab8e7
PE
7458 * buffer.c (Fprevious_overlay_change): Remove var that is set
7459 but not used.
7460
e5a2a5cb
PE
7461 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7462 Remove vars that are set but not used.
8d84a6eb 7463 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7464 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7465
a60e5f68
PE
7466 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7467
f661cb61 7468 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7469 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7470
f0397f5a
PE
7471 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7472 that are set but not used.
7473
8664db06 7474 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7475 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7476
6abdaa4a
PE
7477 * xselect.c (x_get_local_selection, x_handle_property_notify):
7478 Remove vars that are set but not used.
7479
0ce7538d 7480 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7481 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7482
9ae848fc
PE
7483 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7484 Remove var that is set but not used.
0b918413
PE
7485 (scroll_bar_windows_size): Now size_t, not int.
7486 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7487 Check for overflow.
9ae848fc 7488
a5a62657
PE
7489 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7490 (map_tty_color) [!defined MSDOS]: Likewise.
7491
5c5cdd39
PE
7492 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7493
66ebf983
PE
7494 * coding.c: Remove vars that are set but not used.
7495 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7496 All callers changed.
7497 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7498 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7499 (decode_coding_charset): Remove vars that are set but not used.
7500
1be4d761
PE
7501 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7502 that is set but not used.
7503
47553fa8
PE
7504 * print.c (print_object): Remove var that is set but not used.
7505
1f7196bf 7506 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7507 The gnulib version avoids calling malloc in the usual case,
7508 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7509 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7510 * filelock.c (current_lock_owner): Likewise.
7511 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7512 * sysdep.c: Include allocator.h, careadlinkat.h.
7513 (emacs_no_realloc_allocator): New static constant.
7514 (emacs_readlink): New function.
fdb61804
PE
7515 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7516 ../lib/careadlinkat.h.
d1fdcab7 7517
f84c17c7
SM
75182011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7519
7520 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7521 first non-nil return value).
7522
ef3862ad
JD
75232011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7524
7525 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7526 if not defined (Bug#8403).
7527
376a7006
JB
75282011-04-02 Juanma Barranquero <lekktu@gmail.com>
7529
7530 * xdisp.c (display_count_lines): Remove parameter `start',
7531 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7532 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7533 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7534 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7535 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7536 and thereabouts. All callers changed.
7537 (get_per_char_metric): Remove parameter `f', unused since
7538 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7539
6ca3801d
JM
75402011-04-02 Jim Meyering <meyering@redhat.com>
7541
7542 do not dereference NULL upon failed strdup
7543 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7544 (ns_get_family): Likewise.
7545
d8e2b5ba
JB
75462011-04-02 Juanma Barranquero <lekktu@gmail.com>
7547
7548 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7549
8c74fcbd
JD
75502011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7551
7552 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7553 later (Bug#8403).
7554
7200d79c
SM
75552011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7556
03408648 7557 Add lexical binding.
7200d79c 7558
03408648
SM
7559 * window.c (Ftemp_output_buffer_show): New fun.
7560 (Fsave_window_excursion):
7561 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7562
7563 * lread.c (lisp_file_lexically_bound_p): New function.
7564 (Fload): Bind Qlexical_binding.
7565 (readevalloop): Remove `evalfun' arg.
7566 Bind Qinternal_interpreter_environment.
7567 (Feval_buffer): Bind Qlexical_binding.
7568 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7569 Mark as dynamic.
7570 (syms_of_lread): Declare `lexical-binding'.
7571
7572 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7573
7574 * keyboard.c (eval_dyn): New fun.
7575 (menu_item_eval_property): Use it.
ca105506
SM
7576
7577 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7578
03408648
SM
7579 * fns.c (concat, mapcar1): Accept byte-code-functions.
7580
7581 * eval.c (Fsetq): Handle lexical vars.
7582 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7583 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7584 (FletX, Flet): Obey lexical binding.
7585 (Fcommandp): Handle closures.
7586 (Feval): New `lexical' arg.
7587 (eval_sub): New function extracted from Feval. Use it almost
7588 everywhere where Feval was used. Look up vars in lexical env.
7589 Handle closures.
7590 (Ffunctionp): Move from subr.el.
7591 (Ffuncall): Handle closures.
7592 (apply_lambda): Remove `eval_flags'.
7593 (funcall_lambda): Handle closures and new byte-code-functions.
7594 (Fspecial_variable_p): New function.
7595 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7596 but without exporting it to Lisp.
23aba0ea 7597
23aba0ea 7598 * doc.c (Fdocumentation, store_function_docstring):
03408648 7599 * data.c (Finteractive_form): Handle closures.
23aba0ea 7600
03408648
SM
7601 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7602 interactive spec.
ba83908c 7603
04f2d78b
CB
7604 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7605 New byte-codes.
03408648
SM
7606 (exec_byte_code): New function extracted from Fbyte_code to handle new
7607 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7608
03408648 7609 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7610
03408648 7611 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7612
e2abce01
JB
76132011-03-31 Juanma Barranquero <lekktu@gmail.com>
7614
7615 * xdisp.c (redisplay_internal): Fix prototype.
7616
63696a73 76172011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7618
63696a73 7619 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7620 (try_scrolling): Use it when setting scroll_limit.
7621 Limit scrolling to 100 screen lines.
63696a73
EZ
7622 (redisplay_window): Even when falling back on "recentering",
7623 position point in the window according to scroll-conservatively,
7624 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7625
7626 (try_scrolling): When point is above the window, allow searching
7627 as far as scroll_max, or one screenful, to compute vertical
7628 distance from PT to the scroll margin position. This prevents
7629 try_scrolling from unnecessarily failing when
7630 scroll-conservatively is set to a value slightly larger than the
7631 window height. Clean up the case of PT below the margin at bottom
7632 of window: scroll_max can no longer be INT_MAX. When aggressive
7633 scrolling is in use, don't let point enter the opposite scroll
7634 margin as result of the scroll.
7635 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7636 threshold of 100 lines for never-recentering scrolling.
7637
e4cc2dfc
JB
76382011-03-31 Juanma Barranquero <lekktu@gmail.com>
7639
7640 * dispextern.h (move_it_by_lines):
7641 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7642 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7643 (message_log_check_duplicate): Remove parameters `prev_bol' and
7644 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7645 (redisplay_internal): Remove parameter `preserve_echo_area',
7646 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7647
7648 * indent.c (Fvertical_motion):
7649 * window.c (window_scroll_pixel_based, Frecenter):
7650 Don't pass `need_y_p' to `move_it_by_lines'.
7651
1c470562
SM
76522011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7653
44f230aa
SM
7654 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7655 steal a few bits to be more compact.
7656 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7657 Remove unneeded casts.
7658
1c470562
SM
7659 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7660
888adce9
ZK
76612011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7662
7663 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7664 binding" message (bug#7967).
7665
f838ed7b
PE
76662011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7667
77861b95
PE
7668 Fix more problems found by GCC 4.6.0's static checks.
7669
de6dbc14
PE
7670 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7671 Remove unused local var.
7672
f838ed7b
PE
7673 * editfns.c (Fmessage_box): Remove unused local var.
7674
792c7b2b
PE
7675 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7676 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7677 Omit unused local vars.
c499e557 7678 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7679 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7680 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7681 Omit unused local var.
7682
ba0165e1
PE
7683 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7684 Don't assume string length fits in int.
32ad8845 7685 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7686 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7687
3c59b4c9
PE
7688 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7689 instead of alloca (Bug#8344).
7690
a3eed478 7691 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7692 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7693
eb4d412d
PE
7694 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7695
1658b401
PE
7696 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7697 concerns.
7698
7699 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7700
7701 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7702
9a2c6e05
PE
7703 * keyboard.c (syms_of_keyboard): Use the same style as later
7704 in this function when indexing through an array. This also
7705 works around GCC bug 48267.
7706
03d0a109
PE
7707 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7708
44f730c8
PE
7709 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7710
fe75f926
PE
7711 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7712 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7713
ffa8c828
PE
7714 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7715 This avoids undefined behavior on integer overflow, and is a bit
7716 more convenient anyway since it is compared to a size_t variable.
7717
c5101a77
PE
7718 Variadic C functions now count arguments with size_t, not int.
7719 This avoids an unnecessary limitation on 64-bit machines, which
7720 caused (substring ...) to crash on large vectors (Bug#8344).
7721 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7722 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7723 All variadic functions and their callers changed accordingly.
c5101a77
PE
7724 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7725 * data.c (arith_driver, float_arith_driver): Likewise.
7726 * editfns.c (general_insert_function): Likewise.
7727 * eval.c (struct backtrace.nargs, interactive_p)
7728 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7729 (funcall_lambda, mark_backtrace): Likewise.
7730 * fns.c (concat): Likewise.
7731 * frame.c (x_set_frame_parameters): Likewise.
7732 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7733 0 if not found, not -1. All callers changed.
7734
dd3f25f7
PE
7735 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7736 (stack_copy_size): Now size_t, not int.
7737 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7738
461c2ab9
JB
77392011-03-28 Juanma Barranquero <lekktu@gmail.com>
7740
7741 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7742 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7743 All callers changed.
7744
7745 * lisp.h (multibyte_char_to_unibyte):
7746 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7747 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7748 * character.h (CHAR_TO_BYTE8):
7749 * cmds.c (internal_self_insert):
7750 * editfns.c (general_insert_function):
7751 * keymap.c (push_key_description):
7752 * search.c (Freplace_match):
7753 * xdisp.c (message_dolog, set_message_1): All callers changed.
7754
f6d62986
SM
77552011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7756
7757 * keyboard.c (safe_run_hook_funcall): New function.
7758 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7759 don't set the hook to nil, but remove the offending function instead.
7760 (Qcommand_hook_internal): Remove, unused.
7761 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7762 Vcommand_hook_internal.
7763
7764 * eval.c (enum run_hooks_condition): Remove.
7765 (funcall_nil, funcall_not): New functions.
7766 (run_hook_with_args): Call each function through a `funcall' argument.
7767 Remove `cond' argument, now redundant.
7768 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7769 (Frun_hook_with_args_until_failure): Adjust accordingly.
7770 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7771
1db5b1ad
JB
77722011-03-28 Juanma Barranquero <lekktu@gmail.com>
7773
7774 * dispextern.h (string_buffer_position): Remove declaration.
7775
7776 * print.c (strout): Remove parameter `multibyte', unused since
7777 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7778
7779 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7780 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7781 All callers changed.
7782
7783 * w32.c (_wsa_errlist): Use braces for struct initializers.
7784
7785 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7786 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7787 All callers changed.
7788 (string_buffer_position): Likewise. Also, make static (it's never
7789 used outside xdisp.c).
7790 (cursor_row_p): Remove parameter `w', unused since
7791 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7792 (decode_mode_spec): Remove parameter `precision', introduced during
7793 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7794 All callers changed.
7795
5ffb62aa
JD
77962011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7797
7798 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7799
461c2ab9 78002011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7801
7802 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7803 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7804 (ns_update_auto_hide_menu_bar): New functions.
7805 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7806 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7807 ns_constrain_all_frames.
7808 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7809 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7810
5c380ffb
JD
78112011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7812
7813 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7814
9af30bdf
GM
78152011-03-27 Glenn Morris <rgm@gnu.org>
7816
7817 * syssignal.h: Replace RETSIGTYPE with void.
7818 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7819 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7820 Replace SIGTYPE with void everywhere.
7821 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7822 * s/template.h (SIGTYPE): Remove commented out definition.
7823
e2abce01
JB
78242011-03-26 Eli Zaretskii <eliz@gnu.org>
7825
7826 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7827 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7828
f868cd8a
JB
78292011-03-26 Juanma Barranquero <lekktu@gmail.com>
7830
59eb0929
JB
7831 * w32.c (read_unc_volume): Use parameter `henum', instead of
7832 global variable `wget_enum_handle'.
7833
7834 * keymap.c (describe_vector): Remove parameters `indices' and
7835 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7836 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7837
f868cd8a
JB
7838 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7839
7840 * keyboard.c (timer_check): Remove parameter `do_it_now',
7841 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7842 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7843 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7844
7845 * keyboard.c (read_char):
7846 * w32menu.c (w32_menu_display_help):
7847 * xmenu.c (show_help_event, menu_help_callback):
7848 Adjust calls to `show_help_echo'.
7849
7850 * gtkutil.c (xg_maybe_add_timer):
7851 * keyboard.c (readable_events):
7852 * process.c (wait_reading_process_output):
7853 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7854
7855 * insdel.c (adjust_markers_gap_motion):
7856 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7857 (gap_left, gap_right): Don't call it.
7858
2ecf6fdb
CY
78592011-03-25 Chong Yidong <cyd@stupidchicken.com>
7860
7861 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7862 incurred during fontification.
7863
6b1f9ba4
JB
78642011-03-25 Juanma Barranquero <lekktu@gmail.com>
7865
7866 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7867 (DEFVAR_PER_BUFFER): Don't pass it.
7868
7869 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7870 (scrolling_window): Don't pass it.
7871
0f4a96b5
JB
78722011-03-25 Juanma Barranquero <lekktu@gmail.com>
7873
7874 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7875
7876 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7877 and `suffix'.
7878 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7879 of variables specific to SELinux and computation of `encoded_absname'.
7880
7881 * image.c (XPutPixel): Remove unused variable `height'.
7882
7883 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7884
7885 * unexw32.c (get_section_info): Remove unused variable `section'.
7886
7887 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7888 (system_process_attributes): Remove unused variable `sess'.
7889 (sys_read): Remove unused variable `err'.
7890
7891 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7892 (w32_wnd_proc): Remove unused variable `isdead'.
7893 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7894 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7895 (x_create_tip_frame): Remove unused variable `tem'.
7896
7897 * w32inevt.c (w32_console_read_socket):
7898 Remove unused variable `no_events'.
7899
7900 * w32term.c (x_draw_composite_glyph_string_foreground):
7901 Remove unused variable `width'.
7902
1149507c
JB
79032011-03-24 Juanma Barranquero <lekktu@gmail.com>
7904
7905 * w32term.c (x_set_glyph_string_clipping):
7906 Don't pass uninitialized region to CombineRgn.
7907
9c88f339
JB
79082011-03-23 Juanma Barranquero <lekktu@gmail.com>
7909
7910 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7911 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7912 (Fx_close_connection): Remove unused variable `i'.
7913
7914 * w32font.c (w32font_draw): Return number of glyphs.
7915 (w32font_open_internal): Remove unused variable `i'.
7916 (w32font_driver): Add missing initializer.
7917
7918 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7919 (fill_in_menu): Remove unused variable `items_added'.
7920
7921 * w32term.c (last_mouse_press_frame): Remove static global variable.
7922 (w32_clip_to_row): Remove unused variable `f'.
7923 (x_delete_terminal): Remove unused variable `i'.
7924
7925 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7926 (NOTHING): Remove unused static global variable.
7927 (uniscribe_check_otf): Remove unused variable `table'.
7928 (uniscribe_font_driver): Add missing initializers.
7929
dee091a3
JD
79302011-03-23 Julien Danjou <julien@danjou.info>
7931
7932 * term.c (Fsuspend_tty, Fresume_tty):
7933 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7934 * window.c (temp_output_buffer_show):
7935 * insdel.c (signal_before_change):
7936 * frame.c (Fhandle_switch_frame):
7937 * fileio.c (Fdo_auto_save):
7938 * emacs.c (Fkill_emacs):
7939 * editfns.c (save_excursion_restore):
7940 * cmds.c (internal_self_insert):
7941 * callint.c (Fcall_interactively):
7942 * buffer.c (Fkill_all_local_variables):
7943 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7944 Use Frun_hooks.
0f4a96b5 7945 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7946 unconditionally since it does the check itself.
dee091a3 7947
2c520ab5 79482011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7949
c9c49752
PE
7950 Fix more problems found by GCC 4.5.2's static checks.
7951
8abc3f12
PE
7952 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7953 the first time through the loop, since we know p0 < p1 then.
7954 This also avoids a gcc -Wstrict-overflow warning.
7955
a2d26660
PE
7956 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7957 leading to a memory leak, possible in functions like
7958 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7959 of objects (Bug#8318).
a2d26660 7960
916c72e9
PE
7961 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7962 that could (at least in theory) be that large.
7963
19ab8a18
PE
7964 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7965 This is less likely to overflow, and avoids undefined behavior if
7966 overflow does occur. All callers changed. Use strtoul to scan
7967 for the unsigned long integer.
b7cbbd6f
PE
7968 (pint2hrstr): Simplify and tune code slightly.
7969 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7970
f0641eff
PE
7971 * scroll.c (do_scrolling): Work around GCC bug 48228.
7972 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7973
7f650bb9
PE
7974 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7975 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7976 (validate_x_resource_name): Simplify count usage.
7977 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7978
37dd57d1
PE
7979 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7980 fail (Bug#8306).
81e56e61 7981
699979fc 7982 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7983
401bf9b4
PE
7984 * process.c (Fmake_network_process): Use socklen_t, not int,
7985 where POSIX says socklen_t is required in portable programs.
7986 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7987 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7988 (Fmake_network_process, server_accept_connection):
7989 (wait_reading_process_output, read_process_output):
7990 Likewise.
7991
b93aacde
PE
7992 * process.c: Rename or move locals to avoid shadowing.
7993 (list_processes_1, Fmake_network_process):
7994 (read_process_output_error_handler, exec_sentinel_error_handler):
7995 Rename or move locals.
4dc343ee 7996 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7997 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7998 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7999 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8000 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8001
af8a867c 8002 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8003 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8004 Include tparam.h instead, since it declares them.
af8a867c
PE
8005 * cm.h (PC): Remove extern decl; tparam.h now does this.
8006 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8007 * terminfo.c: Include tparam.h, to check interfaces.
8008 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8009 (tparam): Adjust signature to match interface in tparam.h;
8010 this removes some undefined behavior. Check that outstring and len
8011 are zero, which they always are with Emacs.
8012 * tparam.h (PC, BC, UP): New extern decls.
8013
0248044d 8014 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8015 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8016
8ff096c1 8017 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8018 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8019 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8020 (ftfont_list): Remove unused local.
49eaafba
PE
8021 (get_adstyle_property, ftfont_pattern_entity):
8022 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8023 Rename locals to avoid shadowing.
8ff096c1 8024
e2be39f6
PE
8025 * xfont.c (xfont_list_family): Mark var as initialized.
8026
c9735e30
PE
8027 * xml.c (make_dom): Now static.
8028
8f5201ae
PE
8029 * composite.c (composition_compute_stop_pos): Rename local to
8030 avoid shadowing.
b246f932
PE
8031 (composition_reseat_it): Remove unused locals.
8032 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8033 (composition_update_it): Mark var as initialized.
11b61122
PE
8034 (find_automatic_composition): Mark vars as initialized,
8035 with a FIXME (Bug#8290).
8f5201ae 8036
760fbc2c
PE
8037 character.h: Rename locals to avoid shadowing.
8038 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8039 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8040 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8041 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8042 to avoid shadowing.
8043
ff08eb85
PE
8044 * textprop.c (property_change_between_p): Remove; unused.
8045
fc7bf025
PE
8046 * intervals.c (interval_start_pos): Now static.
8047
235d7abc
PE
8048 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8049
44f230aa
SM
8050 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8051 Rename locals to avoid shadowing.
3e7d6594 8052
50060332
PE
8053 * sound.c (wav_play, au_play, Fplay_sound_internal):
8054 Fix pointer signedness.
d01f234b 8055 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8056 (wav_play): Initialize a variable to 0, to prevent undefined
8057 behavior (Bug#8278).
50060332 8058
c4fc4e30
PE
8059 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8060
918436ed
PE
8061 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8062
c939f91b
PE
8063 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8064 clobbering (Bug#8298).
b9c7f648
PE
8065 * sysdep.c (sys_subshell): Likewise.
8066 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8067
6bd8c144
PE
8068 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8069 This should get cleaned up, so that child_setup has the
8070 same signature on all platforms.
8071
7710357c 8072 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8073 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8074
c59da222
CY
80752011-03-22 Chong Yidong <cyd@stupidchicken.com>
8076
8077 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8078 not to be necessary, and produces flickering.
8079
66b87493
GM
80802011-03-20 Glenn Morris <rgm@gnu.org>
8081
8082 * config.in: Remove file.
8083
45b6f6d5
JB
80842011-03-20 Juanma Barranquero <lekktu@gmail.com>
8085
8086 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8087 are now in src/globals.h.
8088 (syms_of_minibuf): Remove spurious & from previous change.
8089
3ec03f7e
LL
80902011-03-20 Leo <sdl.web@gmail.com>
8091
8092 * minibuf.c (completing-read-function): New variable.
8093 (completing-read-default): Rename from completing-read.
8094 (completing-read): Call completing-read-function.
8095
b14e3e21
CY
80962011-03-19 Juanma Barranquero <lekktu@gmail.com>
8097
8098 * xfaces.c (Fx_load_color_file):
8099 Read color file from absolute filename (bug#8250).
8100
f2b726e6
JB
81012011-03-19 Juanma Barranquero <lekktu@gmail.com>
8102
8103 * makefile.w32-in: Update dependencies.
8104
09f6ff02
EZ
81052011-03-17 Eli Zaretskii <eliz@gnu.org>
8106
8107 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8108
29a6015a
PE
81092011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8110
a3a6c54e
PE
8111 Fix more problems found by GCC 4.5.2's static checks.
8112
b766f867
PE
8113 * process.c (make_serial_process_unwind, send_process_trap):
8114 (sigchld_handler): Now static.
8115
be02381c
PE
8116 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8117 That way, the code declares only the vars that it needs.
8118 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8119 * s/cygwin.h (PTY_ITERATION): Likewise.
8120 * s/darwin.h (PTY_ITERATION): Likewise.
8121 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8122
57048744
PE
8123 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8124 * process.c (allocate_pty): Don't declare stb unless it's needed.
8125
7914961c 8126 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8127 (CONSTANTLIM): Remove; unused.
8128 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8129 Define only if needed.
7914961c 8130
b3967b18
PE
8131 * unexelf.c (unexec): Name an expression,
8132 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8133 Use a different way to cause a compilation error if anyone uses
8134 n rather than nn, a way that does not involve shadowing.
73366a00 8135 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8136
29a6015a
PE
8137 * deps.mk (unexalpha.o): Remove; unused.
8138
43cfc33e 8139 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8140 * unexec.h: New file.
ce701a33
PE
8141 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8142 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8143 Depend on unexec.h.
8144 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8145 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8146 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8147 Change as necessary to match prototype in unexec.h.
ce701a33 8148
01f44d5a
PE
8149 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8150 shadowing.
4f63c6bb 8151 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8152
a6670b0b
PE
8153 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8154 Rename locals to avoid shadowing.
8155
cef2010d 8156 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8157 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8158
d4d7173a
PE
8159 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8160
f08b802a
PE
8161 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8162 warning when compiling print.c.
8163
3ddb0639
PE
8164 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8165 instead of using an uninitialized var.
5ad03b97 8166 (font_sort_entities): Mark var as initialized.
3ddb0639 8167
170a2692
PE
8168 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8169
e663c700
PE
8170 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8171 pointers to constants.
89bc529a 8172 (font_parse_fcname): Remove unused vars.
7b81e2d0 8173 (font_delete_unmatched): Now static.
ea838e10 8174 (font_get_spec): Remove; unused.
13a547c6
PE
8175 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8176 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8177 Rename or move locals to avoid shadowing.
e663c700 8178
2a80c887 8179 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8180 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8181
1384fa33 8182 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8183 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8184
8b2c52e9
PE
8185 * alloc.c (mark_backtrace): Move decl from here ...
8186 * lisp.h: ... to here, so that it can be checked.
8187
475545b5 8188 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8189 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8190 (lisp_indirect_variable): Name an expression,
8191 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8192 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8193
b1349114 8194 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8195 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8196 Use const pointer when appropriate.
b1349114 8197
a2928364
PE
8198 * lisp.h (get_system_name, get_operating_system_release):
8199 Move decls here, to check interfaces.
8200 * process.c (get_operating_system_release): Move decl to lisp.h.
8201 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8202 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8203 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8204 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8205 (Fformat_time_string, Fencode_time, Finsert_char):
8206 (Ftranslate_region_internal, Fformat):
8207 Rename or remove local vars to avoid shadowing.
9710023e 8208 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8209
a415e694
PE
8210 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8211 avoid shadowing.
8212
8ef4622d
PE
8213 * lisp.h (eassert): Check that the argument compiles, even if
8214 ENABLE_CHECKING is not defined.
8215
946f9a5b
PE
8216 * data.c (Findirect_variable): Name an expression, to avoid
8217 gcc -Wbad-function-cast warning.
112396d6 8218 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8219 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8220 (Fmake_variable_buffer_local, Fmake_local_variable):
8221 Mark variables as initialized.
52746918 8222 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8223
e5aab7e7 8224 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8225 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8226 Rename locals to avoid shadowing.
dff45157
PE
8227 (mark_stack): Move local variables into the #ifdef region where
8228 they're used.
7bc26fdb
PE
8229 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8230 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8231 needed otherwise.
8232 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8233 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8234 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8235
e5aab7e7
PE
8236 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8237 avoids undefined behavior in theory.
8238
4da60324
PE
8239 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8240
88043301
PE
8241 Use functions, not macros, for up- and down-casing (Bug#8254).
8242 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8243 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8244 to use the following functions instead of these macros.
8245 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8246 EMACS_INT, since callers assume the returned value fits in int.
8247 (upcase1): Likewise, for UPCASE_TABLE.
8248 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8249 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8250 the race-condition problem in the old DOWNCASE.
88043301 8251
19ed5445
PE
8252 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8253 Rename locals to avoid shadowing.
8254 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8255 (regex_compile, re_search_2, re_match_2_internal):
8256 Remove unused local vars.
952db0d7
PE
8257 (FREE_VAR): Rewrite so as not to use empty "else",
8258 which gcc can warn about.
da053e48 8259 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8260 (RETALLOC_IF): Define only if needed.
8261 (WORDCHAR_P): Likewise. This one is never needed, but is used
8262 only in a comment talking about a compiler bug, so put inside
8263 the #if 0 of that comment.
8264 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8265 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8266 Remove; unused.
19ed5445 8267
1f3561e4 8268 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8269 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8270 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8271
ded6f8f7
PE
8272 * search.c (simple_search): Remove unused var.
8273
dbd37a95
PE
8274 * dired.c (compile_pattern): Move decl from here ...
8275 * lisp.h: ... to here, so that it can be checked.
8276 (struct re_registers): New forward decl.
8277
7e47afad
PE
8278 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8279
85f24f61
PE
8280 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8281 All uses changed.
8282 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8283 Rename locals to avoid shadowing.
5671df8f 8284 (Fvertical_motion): Mark locals as initialized.
85f24f61 8285
181aa2be 8286 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8287 (casify_region): Mark local as initialized.
181aa2be 8288
930d429c
PE
8289 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8290
7082eac6
PE
8291 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8292 New macros, so that the caller can use some names other than
8293 gcpro1, gcpro2, etc.
8294 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8295 of the new macros.
8296 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8297 argument, for consistency with GCPRO2_VAR, etc: it is now the
8298 prefix of the variable, not the variable itself. All uses
8299 changed.
38b2c076
PE
8300 * dired.c (directory_files_internal, file_name_completion):
8301 Rename locals to avoid shadowing.
8302
15206ed9
PE
8303 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8304 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8305 dired.c's scmp function, had undefined behavior.
8306 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8307 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8308 * buffer.h: ... to here, because these macros use current_buffer,
8309 and the new implementation with inline functions needs to have
8310 current_buffer in scope now, rather than later when the macros
8311 are used.
8312 (downcase, upcase1): New static inline functions.
8313 (DOWNCASE, UPCASE1): Reimplement using these functions.
8314 This avoids undefined behavior in expressions like
8315 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8316 from race conditions in accessing the global variables
8317 case_temp1 and case_temp2.
8318 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8319 * lisp.h (case_temp1, case_temp2): Remove their decls.
8320 * character.h (ASCII_CHAR_P): Move from here ...
8321 * lisp.h: ... to here, so that the inline functions mentioned
8322 above can use them.
8323
4a6bea26
PE
8324 * dired.c (directory_files_internal_unwind): Now static.
8325
f14b7e14
PE
8326 * fileio.c (file_name_as_directory, directory_file_name):
8327 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8328 Now static.
2893f146
PE
8329 (file_name_as_directory): Use const pointers when appropriate.
8330 (Fexpand_file_name): Likewise. In particular, newdir might
8331 point at constant storage, so make it a const pointer.
fd4ead52 8332 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8333 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8334 signedness issues.
f839df0c
PE
8335 (Fset_file_times, Finsert_file_contents, auto_save_error):
8336 Rename locals to avoid shadowing.
f14b7e14 8337
5716756e 8338 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8339 (Ftry_completion, Fall_completions): Rename or remove locals
8340 to avoid shadowing.
5716756e 8341
b4c3046a
PE
8342 * marker.c (bytepos_to_charpos): Remove; unused.
8343
b45db522
PE
8344 * lisp.h (verify_bytepos, count_markers): New decls,
8345 so that gcc does not warn that these functions aren't declared.
8346
85876d07
PE
8347 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8348 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8349 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8350 (copy_text): Remove unused local var.
85876d07 8351
03d78a21 8352 * filelock.c (within_one_second): Now static.
b3dd38ab 8353 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8354
5df8f01b
PE
8355 * buffer.c (fix_overlays_before): Mark locals as initialized.
8356 (fix_start_end_in_overlays): Likewise. This function should be
8357 simplified by using pointers-to-pointers, but that's a different
8358 matter.
b1d876f1 8359 (switch_to_buffer_1): Now static.
8f54f30a
PE
8360 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8361 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8362
a70072c9 8363 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8364 Fix pointer signedness issue.
edced198
PE
8365 (sys_subshell): Mark local as volatile if checking for lint,
8366 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8367 (MAXPATHLEN): Define only if needed.
a70072c9 8368
a0977c44
PE
8369 * process.c (serial_open, serial_configure): Move decls from here ...
8370 * systty.h: ... to here, so that they can be checked.
8371
a884fdcc
PE
8372 * fns.c (get_random, seed_random): Move extern decls from here ...
8373 * lisp.h: ... to here, so that they can be checked.
8374
604efe86 8375 * sysdep.c (reset_io): Now static.
b8950c94 8376 (wait_for_termination_signal): Remove; unused.
604efe86 8377
38fc62d9
PE
8378 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8379 (copy_keymap_item, append_key, push_text_char_description):
8380 Now static.
1004a21a 8381 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8382 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8383 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8384 (describe_map_tree):
8385 Rename locals to avoid shadowing.
38fc62d9 8386
2f2650da
PE
8387 * keyboard.c: Declare functions static if they are not used elsewhere.
8388 (echo_char, echo_dash, cmd_error, top_level_2):
8389 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8390 (read_char, kbd_buffer_get_event, make_lispy_position):
8391 (make_lispy_event, make_lispy_movement, apply_modifiers):
8392 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8393 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8394 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8395 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8396 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8397
a053e86c 8398 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8399 (mark_kboards): Move decl here ...
8400 * alloc.c (mark_kboards): ... from here.
a053e86c 8401
4752793e
PE
8402 * lisp.h (force_auto_save_soon): New decl.
8403
74f10ca7 8404 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8405 (DEFINE_DUMMY_FUNCTION): New macro.
8406 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8407 Use it.
c03cd23f
PE
8408 (main): Add casts to avoid warnings
8409 if GCC considers string literals to be constants.
74f10ca7 8410
022e70d4
PE
8411 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8412
59d6fe83
PE
8413 * dbusbind.c: Pointer signedness fixes.
8414 (xd_signature, xd_append_arg, xd_initialize):
8415 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8416 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8417 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8418 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8419
78320123
PE
8420 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8421 if GCC considers string literals to be constants.
49cebcca 8422 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8423
35ac2a97
SM
84242011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8425
fb103ca9
SM
8426 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8427 (print_preprocess, print_object): New macro to fix last change.
8428
35ac2a97
SM
8429 * print.c (print_preprocess): Don't forget font objects.
8430
62973b41
JB
84312011-03-16 Juanma Barranquero <lekktu@gmail.com>
8432
8433 * emacs.c (USAGE3): Doc fixes.
8434
0e48bb22
AS
84352011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8436
8437 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8438 structure.
8439
7684e57b
JB
84402011-03-14 Juanma Barranquero <lekktu@gmail.com>
8441
8442 * lisp.h (VWindow_system, Qfile_name_history):
8443 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8444 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8445 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8446
8447 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8448 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8449
8450 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8451 * w32console.c (detect_input_pending, read_input_pending)
8452 (encode_terminal_code):
8453 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8454 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8455 (w32_system_caret_y, Qfile_name_history):
8456 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8457 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8458 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8459 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8460 * w32proc.c (Qlocal, report_file_error):
8461 * w32term.c (Vwindow_system, updating_frame):
8462 * w32uniscribe.c (initialized, uniscribe_font_driver):
8463 Remove unneeded extern declarations.
8464
2aa46d6c
CY
84652011-03-14 Chong Yidong <cyd@stupidchicken.com>
8466
c96bbc66 8467 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8468
cffc6f3b
CY
84692011-03-13 Chong Yidong <cyd@stupidchicken.com>
8470
8471 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8472 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8473 These macros can no longer be used for assignment.
8474
44f230aa
SM
8475 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8476 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8477 (record_buffer_markers, fetch_buffer_markers): New functions for
8478 recording and fetching special buffer markers.
8479 (set_buffer_internal_1, set_buffer_temp): Use them.
8480
8481 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8482
8483 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8484
8485 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8486 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8487
8488 * xdisp.c (hscroll_window_tree):
8489 (reconsider_clip_changes): Use PT instead of BUF_PT.
8490
d251f04b
EZ
84912011-03-13 Eli Zaretskii <eliz@gnu.org>
8492
8493 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8494 $(EMACS_ROOT)/lib/intprops.h.
8495
f0c77cd1
PE
84962011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8497
3eca4629
PE
8498 Fix more problems found by GCC 4.5.2's static checks.
8499
7c86ee98
PE
8500 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8501 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8502 (xg_free_frame_widgets): Make it clear that a local variable is
8503 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8504 (gdk_window_get_screen): Make it clear that this macro is needed
8505 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8506 (int_gtk_range_get_value): New function, which avoids a diagnostic
8507 from gcc -Wbad-function-cast.
8508 (xg_set_toolkit_scroll_bar_thumb): Use it.
8509 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8510 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8511 (get_utf8_string, xg_get_file_with_chooser):
8512 Rename locals to avoid shadowing.
8513 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8514
41729b81
PE
8515 * xgselect.c (xg_select): Remove unused var.
8516
f0c77cd1
PE
8517 * image.c (four_corners_best): Mark locals as initialized.
8518 (gif_load): Initialize transparent_p to zero (Bug#8238).
8519 Mark another local as initialized.
ec6cf4c6 8520 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8521
ce0ad53d 8522 * image.c (clear_image_cache): Now static.
d5d5a617 8523 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8524 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8525 (x_edge_detection): Remove unnecessary cast that
8526 gcc -Wbad-function-cast diagnoses.
2037898d 8527 (gif_load): Fix pointer signedness.
6ae141d6
PE
8528 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8529 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8530
33383987 85312011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8532
d32df629
PE
8533 Improve quality of tests for time stamp overflow.
8534 For example, without this patch (encode-time 0 0 0 1 1
8535 1152921504606846976) returns the obviously-bogus value (-948597
8536 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8537 reports time overflow. See
8538 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8539 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8540 * editfns.c: Include limits.h and intprops.h.
8541 (TIME_T_MIN, TIME_T_MAX): New macros.
8542 (time_overflow): Move earlier, to before first use.
8543 (hi_time, lo_time): New functions, for an accurate test for
8544 out-of-range times.
8545 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8546 (Fget_internal_run_time): Don't assume time_t fits in int.
8547 (make_time): Use list2 instead of Fcons twice.
8548 (Fdecode_time): More accurate test for out-of-range times.
8549 (check_tm_member): New function.
8550 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8551 (lisp_time_argument): Don't rely on undefined left-shift and
8552 right-shift behavior when checking for time stamp overflow.
8be6f318 8553
fe31d94c
PE
8554 * editfns.c (time_overflow): New function, refactoring common code.
8555 (Fformat_time_string, Fdecode_time, Fencode_time):
8556 (Fcurrent_time_string): Use it.
8557
8be6f318
PE
8558 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8559 * dired.c (make_time): Move to ...
8560 * editfns.c (make_time): ... here.
8561 * systime.h: Note the move.
8562
09d9db2c 85632011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8564
126bc0dc
YM
8565 * fringe.c (update_window_fringes): Remove unused variables.
8566
c47cbdfd
YM
8567 * unexmacosx.c (copy_data_segment): Also copy __got section.
8568 (Bug#8223)
8569
7ac80be9
EZ
85702011-03-12 Eli Zaretskii <eliz@gnu.org>
8571
c96bbc66 8572 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8573 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8574 Constify `char *' arguments and their references according to
8575 prototypes in tparam.h.
8576
ecb0f94d 8577 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8578
7ac80be9
EZ
8579 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8580 Adapt all references accordingly.
8581
8582 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8583
ef1fd07e
TT
85842011-03-11 Tom Tromey <tromey@redhat.com>
8585
8586 * buffer.c (syms_of_buffer): Remove obsolete comment.
8587
7ef4b50c
EZ
85882011-03-11 Eli Zaretskii <eliz@gnu.org>
8589
8590 * termhooks.h (encode_terminal_code): Declare prototype.
8591
8592 * msdos.c (encode_terminal_code): Don't declare prototype.
8593
8594 * term.c (encode_terminal_code): Now external again, used by
8595 w32console.c and msdos.c.
8596
44f230aa
SM
8597 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8598 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8599
4b1ec863 86002011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8601
1714f52b 8602 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8603
4b1ec863
PE
8604 * fringe.c (update_window_fringes): Mark locals as initialized
8605 (Bug#8227).
8606 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8607
524c7aa6
PE
8608 * alloc.c (mark_fringe_data): Move decl from here ...
8609 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8610 to check its interface.
8611 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8612
a5c0af81 8613 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8614 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8615 (fontset_font): Mark local as initialized.
a9a06e0b 8616 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8617
b4716021
PE
8618 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8619
811e9bac 8620 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8621 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8622 (x_own_selection, Fx_disown_selection_internal): Rename locals
8623 to avoid shadowing.
8624 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8625
7e3ab302
PE
8626 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8627 so that the caller can use some name other than gcpro1.
8628 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8629 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8630 (Fx_backspace_delete_keys_p):
8631 Use them to avoid shadowing, and rename vars to avoid shadowing.
8632 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8633 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8634 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8635 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8636 Remove unused locals.
7e3ab302
PE
8637 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8638 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8639 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8640 macros.
f78faa98 8641
e2b13473
PE
8642 * xterm.h (x_mouse_leave): New decl.
8643
77f23912
PE
8644 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8645 Remove unused functions.
cdf4ba58
PE
8646 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8647 (x_calc_absolute_position): Now static.
7411c686 8648 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8649 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8650 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8651 unless they are used.
38d0b34a
PE
8652 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8653 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8654 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8655 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8656 (x_error_catcher, x_connection_closed, x_error_handler):
8657 (x_error_quitter, xembed_send_message, x_iconify_frame):
8658 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8659 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8660 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8661
44f230aa
SM
8662 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8663 Rename or move locals to avoid shadowing.
6b463e58 8664 (tty_defined_color, merge_face_heights): Now static.
5967d051 8665 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8666 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8667 does not deduce is never used uninitialized.
73719eba
PE
8668 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8669 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8670
426994c3 8671 * terminal.c (store_terminal_param): Now static.
5489860b 8672
032f1620 8673 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8674 (set_frame_menubar): Remove unused local.
d4323972 8675 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8676 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8677 since they might point to immutable storage.
281585b0
PE
8678 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8679 since it's unused otherwise.
032f1620 8680
367c19e5 8681 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8682 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8683 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8684 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8685 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8686 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8687 does not deduce are never used uninitialized.
70739cbe 8688
07b48fa9
PE
8689 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8690
8868a238 8691 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8692 * window.c (window_loop, size_window):
8693 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8694
7e5cf297 8695 * window.c (display_buffer): Now static.
d6550a9f
PE
8696 (size_window): Mark variables that gcc -Wuninitialized
8697 does not deduce are never used uninitialized.
a586633d
PE
8698 * window.h (check_all_windows): New decl, to forestall
8699 gcc -Wmissing-prototypes diagnostic.
5b555da1 8700 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8701
f6095868
PE
8702 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8703 shadowing.
8704 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8705 Include <limits.h>.
8706 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8707 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8708 (load_charset_map): Mark variables that gcc -Wuninitialized
8709 does not deduce are never used uninitialized.
53df7c11 8710 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8711
f38b440c
PE
8712 * coding.c (coding_set_source, coding_set_destination):
8713 Use "else { /* comment */ }" rather than "else /* comment */;"
8714 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8715 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8716 a block, when the outer 'i' will do.
8717 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8718 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8719 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8720 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8721 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8722 Rename locals to avoid shadowing.
8723 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8724 * coding.c (emacs_mule_char, encode_invocation_designation):
8725 Now static, since they're not used elsewhere.
413bb2db 8726 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8727 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8728 (decode_coding_emacs_mule): Mark variables that gcc
8729 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8730 (detect_coding_iso_2022): Initialize a local variable that might
8731 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8732 this initialization is needed. (Bug#8211)
5f58e762
PE
8733 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8734 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8735 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8736 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8737 Remove unused macros.
f38b440c 8738
232b38b9 8739 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8740 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8741 * character.c (string_count_byte8): Likewise.
232b38b9 8742
fb90da1b
PE
8743 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8744 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8745
fb93dbc2
PE
8746 * chartab.c (copy_sub_char_table): Now static, since it's not used
8747 elsewhere.
5c156ace
PE
8748 (sub_char_table_ref_and_range, char_table_ref_and_range):
8749 Rename locals to avoid shadowing.
bbcd0949 8750 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8751
7d3b3862 8752 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8753 (BIDI_BOB): Remove unused macro.
7d3b3862 8754
6be7d3da
PE
8755 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8756 deduce are never used uninitialized.
c2ed9c8b 8757 * term.c (encode_terminal_code): Likewise.
6be7d3da 8758
75f8807f 8759 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8760
50938595
PE
8761 * tparam.h: New file.
8762 * term.c, tparam.h: Include it.
8763 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8764 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8765 Move these decls to tparam.h, and make them agree with what
8766 is actually in tparam.c. The previous trick of using incompatible
8767 decls in different modules does not conform to the C standard.
8768 All callers of tparam changed to use tparam's actual API.
8769 * tparam.c (tparam1, tparam, tgoto):
8770 Use const pointers where appropriate.
8771
fbceeba2
PE
8772 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8773 * cm.h (struct cm): Likewise.
8774 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8775 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8776 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8777 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8778 (turn_on_face, init_tty): Likewise.
8779 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8780
7f3f1250
PE
8781 * term.c (term_mouse_position): Rename local to avoid shadowing.
8782
e6ca6543
PE
8783 * alloc.c (mark_ttys): Move decl from here ...
8784 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8785
c40f8d15
AS
87862011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8787
8788 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8789
cfe0661d
JB
87902011-03-09 Juanma Barranquero <lekktu@gmail.com>
8791
8792 * search.c (compile_pattern_1): Remove argument regp, unused since
8793 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8794 (compile_pattern): Don't pass it.
8795
0afb4571
J
87962011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8797
8798 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8799 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8800 for ! HAVE_GTK3.
8801 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8802
8803 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8804
8805 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8806 gdk_window_get_screen, gdk_window_get_geometry,
8807 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8808 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8809 (xg_get_pixbuf_from_pixmap): New function.
8810 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8811 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8812 Call xg_get_pixbuf_from_pixmap instead of
8813 gdk_pixbuf_get_from_drawable.
8814 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8815 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8816 (xg_check_special_colors): Use GtkStyleContext and its functions
8817 for HAVE_GTK3.
8818 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8819 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8820 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8821 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8822 Call gtk_widget_get_preferred_size.
0afb4571
J
8823 (xg_frame_resized): gdk_window_get_geometry only takes 5
8824 parameters.
44f230aa
SM
8825 (xg_win_to_widget, xg_event_is_for_menubar):
8826 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8827 (xg_set_widget_bg): New function.
8828 (delete_cb): New function.
895009e1 8829 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8830 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8831 (xg_set_background_color): Call xg_set_widget_bg.
8832 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8833 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8834 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8835 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8836 if ! HAVE_GTK3.
8837 (update_frame_tool_bar): Call gtk_widget_hide.
8838 (xg_initialize): Use GDK_KEY_g.
8839
8840 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8841 if ! HAVE_GTK3
8842 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8843
8844 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8845 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8846 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8847
1c2cc4ef
JB
88482011-03-08 Juanma Barranquero <lekktu@gmail.com>
8849
8850 * w32xfns.c (select_palette): Check success of RealizePalette against
8851 GDI_ERROR, not zero.
8852
33383987 8853See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8854
8855;; Local Variables:
8856;; coding: utf-8
aac0c6e3
MR
8857;; End:
8858
33383987 8859 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8860
8861 This file is part of GNU Emacs.
8862
8863 GNU Emacs is free software: you can redistribute it and/or modify
8864 it under the terms of the GNU General Public License as published by
8865 the Free Software Foundation, either version 3 of the License, or
8866 (at your option) any later version.
8867
8868 GNU Emacs is distributed in the hope that it will be useful,
8869 but WITHOUT ANY WARRANTY; without even the implied warranty of
8870 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8871 GNU General Public License for more details.
8872
8873 You should have received a copy of the GNU General Public License
8874 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.