* movemail.c: Fix race condition and related bugs (Bug#8836).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2547adb1
CY
12011-06-10 Chong Yidong <cyd@stupidchicken.com>
2
3 * image.c (gif_load): Fix omitted cast error introduced by
4 2011-06-06 change.
5
2c8e37d4
MR
62011-06-10 Martin Rudalics <rudalics@gmx.at>
7
8 * window.h (resize_proportionally, orig_total_lines)
9 (orig_top_line): Remove from window structure.
10 (set_window_height, set_window_width, change_window_heights)
11 (Fdelete_window): Remove prototypes.
12 (resize_frame_windows): Remove duplicate declaration.
13
440a42e3
EZ
142011-06-10 Eli Zaretskii <eliz@gnu.org>
15
16 * window.h (resize_frame_windows, resize_window_check)
17 (delete_deletable_window, resize_root_window)
18 (resize_frame_windows): Declare prototypes.
19
20 * window.c (resize_window_apply): Make definition be "static" to
21 match the prototype.
22
562dd5e9
MR
232011-06-10 Martin Rudalics <rudalics@gmx.at>
24
25 * window.c: Remove declarations of Qwindow_size_fixed,
26 window_min_size_1, window_min_size_2, window_min_size,
27 size_window, window_fixed_size_p, enlarge_window, delete_window.
28 Remove static from declaration of Qdelete_window, it's
29 temporarily needed by Fbury_buffer.
30 (replace_window): Don't assign orig_top_line and
31 orig_total_lines.
32 (Fdelete_window, delete_window): Remove. Window deletion is
33 handled by window.el.
34 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
35 Fdelete_window calls with calls to Qdelete_window.
36 (Fdelete_other_windows): Remove. Deleting other windows is
37 handled by window.el.
38 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
39 handled in window.el.
40 (window_min_size_2, window_min_size_1, window_min_size): Remove.
41 Window minimum sizes are handled in window.el.
42 (shrink_windows, size_window, set_window_height)
43 (set_window_width, change_window_heights, window_height)
44 (window_width, CURBEG, CURSIZE, enlarge_window)
45 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
46 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
47 handled in window.el.
48 (make_dummy_parent): Rename to make_parent_window and give it a
49 second argument horflag.
50 (make_window): Don't set resize_proportionally any more.
51 (Fsplit_window): Remove. Windows are split in window.el.
52 (save_restore_action, save_restore_orig_size)
53 (shrink_window_lowest_first, save_restore_orig_size): Remove.
54 Resize mini windows in window.el.
55 (grow_mini_window, shrink_mini_window): Implement by calling
56 Qresize_root_window_vertically, resize_window_check and
57 resize_window_apply.
58 (saved_window, Fset_window_configuration, save_window_save): Do
59 not handle orig_top_line, orig_total_lines, and
60 resize_proportionally.
61 (window_min_height, window_min_width): Move to window.el.
62 (keys_of_window): Move bindings for delete-other-windows,
63 split-window, delete-window and enlarge-window to window.el.
64
65 * buffer.c: Temporarily extern Qdelete_window.
66 (Fbury_buffer): Temporarily call Qdelete_window instead of
67 Fdelete_window (Fbury_buffer will move to window.el soon).
68
69 * frame.c (set_menu_bar_lines_1): Remove code handling
70 orig_top_line and orig_total_lines.
71
72 * dispnew.c (adjust_frame_glyphs_initially): Don't use
73 set_window_height but set heights directly.
74 (change_frame_size_1): Use resize_frame_windows.
75
76 * xdisp.c (init_xdisp): Don't use set_window_height but set
77 heights directly.
78
79 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
80 resize_frame_windows instead of change_window_heights and run
81 run_window_configuration_change_hook.
82
83 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
84 instead of change_window_heights and run
85 run_window_configuration_change_hook.
86
1a13852e
MR
872011-06-09 Martin Rudalics <rudalics@gmx.at>
88
89 * window.c (replace_window): Rename second argument REPLACEMENT to
90 NEW. New third argument SETFLAG. Rewrite.
91 (delete_window, make_dummy_parent): Call replace_window with
92 third argument 1.
93 (window_list_1): Move down in code.
94 (run_window_configuration_change_hook): Move set_buffer part
95 before select_frame_norecord part in order to unwind correctly.
96 Rename count1 to count.
97 (recombine_windows, delete_deletable_window, resize_root_window)
98 (Fdelete_other_windows_internal)
99 (Frun_window_configuration_change_hook, make_parent_window)
100 (resize_window_check, resize_window_apply, Fresize_window_apply)
101 (resize_frame_windows, Fsplit_window_internal)
102 (Fdelete_window_internal, Fresize_mini_window_internal): New
103 functions.
104 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
105
f3d1777e
MR
1062011-06-08 Martin Rudalics <rudalics@gmx.at>
107
496e208e
MR
108 * window.h (window): Add some new members to window structure -
109 normal_lines, normal_cols, new_total, new_normal, clone_number,
110 splits, nest, prev_buffers, next_buffers.
111 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 112 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 113
f3d1777e
MR
114 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
115 Remove.
496e208e
MR
116 (make_dummy_parent): Set new members of windows structure.
117 (make_window): Move down in code. Handle new members of window
118 structure.
119 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
120 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
121 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
122 (Fset_window_prev_buffers, Fwindow_next_buffers)
123 (Fset_window_next_buffers, Fset_window_clone_number): New
124 functions.
125 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
126 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
127 Doc-string fixes.
128 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
129 Argument WINDOW can be now internal window too.
130 (Fwindow_use_time): Move up in code.
131 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
132 Rewrite doc-string.
133 (Fset_window_configuration, saved_window)
134 (Fcurrent_window_configuration, save_window_save): Handle new
135 members of window structure.
b9e809c2
MR
136 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
137 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
138 (syms_of_window): New Lisp objects Qrecord_window_buffer,
139 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
140 Qget_mru_window, Qresize_root_window,
141 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
142 Qauto_buffer_name; staticpro them.
f3d1777e 143
abde8f8c
MR
1442011-06-07 Martin Rudalics <rudalics@gmx.at>
145
146 * window.c (Fwindow_total_size, Fwindow_left_column)
147 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
148 (Fwindow_list_1): New functions.
149 (window_box_text_cols): Replace with window_body_cols.
150 (Fwindow_width, Fscroll_left, Fscroll_right): Use
151 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
152 (delete_window, Fset_window_configuration): Call
153 delete_all_subwindows with window as argument.
154 (delete_all_subwindows): Take a window as argument and not a
155 structure. Rewrite.
190b47e6
MR
156 (window_loop): Remove handling of GET_LRU_WINDOW and
157 GET_LARGEST_WINDOW.
158 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
159
160 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
161 window_box_text_cols. delete_all_subwindows now takes a
162 Lisp_Object as argument.
abde8f8c
MR
163
164 * indent.c (compute_motion, Fcompute_motion): Use
165 window_body_cols instead of window_box_text_cols.
166
fa8a67e6
MR
167 * frame.c (delete_frame): Call delete_all_subwindows with root
168 window as argument.
169
a54e3482
DC
1702011-06-07 Daniel Colascione <dan.colascione@gmail.com>
171
172 * fns.c (Fputhash): Document return value.
173
60002bf5
CY
1742011-06-06 Chong Yidong <cyd@stupidchicken.com>
175
176 * image.c (gif_load): Implement gif89a spec "no disposal" method.
177
0c671da6 1782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 179
b862a52a 180 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 181
be44ca6c
PE
182 Check for overflow when converting integer to cons and back.
183 * charset.c (Fdefine_charset_internal, Fdecode_char):
184 Use cons_to_unsigned to catch overflow.
185 (Fencode_char): Use INTEGER_TO_CONS.
186 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
187 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
188 * data.c (long_to_cons, cons_to_long): Remove.
189 (cons_to_unsigned, cons_to_signed): New functions.
190 These signal an error for invalid or out-of-range values.
191 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
192 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
193 * font.c (Ffont_variation_glyphs):
194 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
195 * lisp.h: Include <intprops.h>.
196 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
197 (cons_to_signed, cons_to_unsigned): New decls.
198 (long_to_cons, cons_to_long): Remove decls.
199 * undo.c (record_first_change): Use INTEGER_TO_CONS.
200 (Fprimitive_undo): Use CONS_TO_INTEGER.
201 * xfns.c (Fx_window_property): Likewise.
202 * xselect.c: Include <limits.h>.
203 (x_own_selection, selection_data_to_lisp_data):
204 Use INTEGER_TO_CONS.
205 (x_handle_selection_request, x_handle_selection_clear)
206 (x_get_foreign_selection, Fx_disown_selection_internal)
207 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
208 (lisp_data_to_selection_data): Use cons_to_unsigned.
209 (x_fill_property_data): Use cons_to_signed.
210 Report values out of range.
211
d1f3d2af
PE
212 Check for buffer and string overflow more precisely.
213 * buffer.h (BUF_BYTES_MAX): New macro.
214 * lisp.h (STRING_BYTES_MAX): New macro.
215 * alloc.c (Fmake_string):
216 * character.c (string_escape_byte8):
217 * coding.c (coding_alloc_by_realloc):
218 * doprnt.c (doprnt):
219 * editfns.c (Fformat):
220 * eval.c (verror):
221 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
222 since they may not be the same number.
223 * editfns.c (Finsert_char):
224 * fileio.c (Finsert_file_contents):
225 Likewise for BUF_BYTES_MAX.
226
dd52fcea
PE
227 * image.c: Use ptrdiff_t, not int, for sizes.
228 (slurp_file): Switch from int to ptrdiff_t.
229 All uses changed.
230 (slurp_file): Check that file size fits in both size_t (for
231 malloc) and ptrdiff_t (for sanity and safety).
232
7f9bbdbb
PE
233 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
234 if b->modtime has its maximal value.
235
dfe18f82
PE
236 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
237
84acfcf0
PE
238 Don't assume time_t can fit into int.
239 * buffer.h (struct buffer.modtime): Now time_t, not int.
240 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
241 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
242
ccd9a01a
PE
243 Minor fixes for signed vs unsigned integers.
244 * character.h (MAYBE_UNIFY_CHAR):
245 * charset.c (maybe_unify_char):
246 * keyboard.c (read_char, reorder_modifiers):
247 XINT -> XFASTINT, since the integer must be nonnegative.
248 * ftfont.c (ftfont_spec_pattern):
249 * keymap.c (access_keymap, silly_event_symbol_error):
250 XUINT -> XFASTINT, since the integer must be nonnegative.
251 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
252 since it makes no difference and we prefer signed.
253 * keyboard.c (record_char): Use XUINT when all the neighbors do.
254 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
255 nonnegative.
256
d6d100dd
SM
2572011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
258
259 * window.h (Fwindow_frame): Declare.
260
2b6148e4
PE
2612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
262
263 * alloc.c: Simplify handling of large-request failures (Bug#8800).
264 (SPARE_MEMORY): Always define.
265 (LARGE_REQUEST): Remove.
266 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
267
f230ecc9
MR
2682011-06-06 Martin Rudalics <rudalics@gmx.at>
269
727e958e
MR
270 * lisp.h: Move EXFUNS for Fframe_root_window,
271 Fframe_first_window and Fset_frame_selected_window to window.h.
272
273 * window.h: Move EXFUNS for Fframe_root_window,
274 Fframe_first_window and Fset_frame_selected_window here from
275 lisp.h.
276
277 * frame.c (Fwindow_frame, Fframe_first_window)
278 (Fframe_root_window, Fframe_selected_window)
279 (Fset_frame_selected_window): Move to window.c.
280 (Factive_minibuffer_window): Move to minibuf.c.
281 (Fother_visible_frames_p): New function.
282
283 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
284
f230ecc9
MR
285 * window.c (decode_window, decode_any_window): Move up in code.
286 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
287 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
288 (Fwindow_buffer): Move up and rewrite doc-string.
289 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
290 (Fwindow_prev): New functions.
727e958e
MR
291 (Fwindow_frame): Move here from frame.c. Accept any window as
292 argument.
293 (Fframe_root_window, Fframe_first_window)
294 (Fframe_selected_window): Move here from frame.c. Accept frame
295 or arbitrary window as argument. Update doc-strings.
296 (Fminibuffer_window): Move up in code.
297 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
298 (Fset_frame_selected_window): Move here from frame.c.
299 Marginal rewrite.
727e958e
MR
300 (Fselected_window, select_window, Fselect_window): Move up in
301 code. Minor doc-string fixes.
f230ecc9 302
4d09bcf6
PE
3032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
304
305 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
306 Do not assume that spare memory exists; that assumption is valid
307 only if SYSTEM_MALLOC.
308 (LARGE_REQUEST): New macro, so that the issue of large requests
309 is separated from the issue of spare memory.
310
810928a2
AS
3112011-06-05 Andreas Schwab <schwab@linux-m68k.org>
312
172418ad
AS
313 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
314 format. (Bug#8806)
315
43f862f7
AS
316 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
317
810928a2
AS
318 * xfns.c (x_set_scroll_bar_default_width): Move declarations
319 before statements.
320
a059fe24
JD
3212011-06-05 Jan Djärv <jan.h.d@swipnet.se>
322
323 * gtkutil.c (xg_get_default_scrollbar_width): New function.
324
325 * gtkutil.h: Declare xg_get_default_scrollbar_width.
326
327 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
328 min width by calling x_set_scroll_bar_default_width (Bug#8505).
329
989bf368
JB
3302011-06-05 Juanma Barranquero <lekktu@gmail.com>
331
332 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
333
4b80f674
CY
3342011-06-04 Chong Yidong <cyd@stupidchicken.com>
335
336 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
337 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
338 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
339 New error handlers.
4b80f674
CY
340 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
341 Obey Vx_select_enable_clipboard_manager. Catch errors in
342 x_clipboard_manager_save (Bug#8779).
343 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 344 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 345
99a33b77 3462011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
347
348 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
349
99a33b77 3502011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
351
352 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
353 in the current matrix if keep_current_p is non-zero.
354
8264569d
EZ
3552011-06-04 Eli Zaretskii <eliz@gnu.org>
356
357 * bidi.c (bidi_level_of_next_char): Fix last change.
358
57f97249
EZ
3592011-06-03 Eli Zaretskii <eliz@gnu.org>
360
fec2107c 361 Support bidi reordering of text covered by display properties.
57f97249 362
fec2107c
EZ
363 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
364 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
365 (bidi_cache_search, bidi_cache_iterator_state)
366 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
367 (bidi_level_of_next_char, bidi_move_to_visually_next):
368 Support character positions inside a run of characters covered by a
fec2107c
EZ
369 display string.
370 (bidi_paragraph_init, bidi_resolve_explicit_1)
371 (bidi_level_of_next_char): Call bidi_fetch_char and
372 bidi_fetch_char_advance instead of FETCH_CHAR and
373 FETCH_CHAR_ADVANCE.
374 (bidi_init_it): Initialize new members.
375 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
376 definitions.
377 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
378 instead of using explicit *_CHAR codes.
d6d100dd
SM
379 (bidi_resolve_explicit, bidi_resolve_weak):
380 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
381 bidirectional text is supported only in multibyte buffers.
382 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
383 it to initialize the frame_window_p member of struct bidi_it.
384 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
385 (bidi_resolve_explicit, bidi_resolve_weak)
386 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
387 bidi_it->nchars is non-positive.
388 (bidi_level_of_next_char): Don't try to lookup the cache for the
389 next/previous character if nothing is cached there yet, or if we
390 were just reseat()'ed to a new position.
c40e2fb2 391
0e14fe90
EZ
392 * xdisp.c (set_cursor_from_row): Set start and stop points
393 according to the row's direction when priming the loop that looks
394 for the glyph on which to display cursor.
395 (single_display_spec_intangible_p): Function deleted.
396 (display_prop_intangible_p): Reimplement to call
397 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
398 Accept 3 additional arguments needed by handle_display_spec.
399 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
400 values: lists, `(when COND...)' forms, etc.
401 (single_display_spec_string_p): Support property values that are
402 lists with the argument STRING its top-level element.
403 (display_prop_string_p): Fix the condition for processing a
404 property that is a list to be consistent with handle_display_spec.
fec2107c 405 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
406 last portion of handle_display_prop.
407 (compute_display_string_pos): Accept additional argument
408 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
409 value of a `display' property is a "replacing spec".
410 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
411 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
412 the display property, but just return a value indicating whether
413 the display property will replace the characters it covers.
414 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
415 frame_window_p members of struct bidi_it.
d6d100dd
SM
416 (compute_display_string_pos, compute_display_string_end):
417 New functions.
fec2107c
EZ
418 (push_it): Accept second argument POSITION, where pop_it should
419 jump to continue iteration.
420 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 421
fec2107c
EZ
422 * keyboard.c (adjust_point_for_property): Adjust the call to
423 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
424
425 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
426 (bidi_init_it): Update prototypes.
427 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
428 (compute_display_string_pos, compute_display_string_end):
429 Declare prototypes.
fec2107c
EZ
430 (struct bidi_it): New members nchars and disp_pos. ch_len is now
431 EMACS_INT.
fc6f18ce 432
40087514 4332011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 434
57f53182
PE
435 Malloc failure behavior now depends on size of allocation.
436 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
437 * lisp.h: Change signatures accordingly.
438 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
439 All callers changed. (Bug#8762)
440
441 * gnutls.c: Use Emacs's memory allocators.
442 Without this change, the gnutls library would invoke malloc etc.
443 directly, which causes problems on non-SYNC_INPUT hosts, and which
444 runs afoul of improving memory_full behavior. (Bug#8761)
445 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
446 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
447 xfree instead of the default malloc, realloc, free.
448 (Fgnutls_boot): No need to check for memory allocation failure,
449 since xmalloc does that for us.
450
ac32cd99 451 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
452 * category.c (hash_get_category_set):
453 * ccl.c (ccl_driver):
454 * charset.c (Fdefine_charset_internal):
455 * charset.h (struct charset.hash_index):
456 * composite.c (get_composition_id, gstring_lookup_cache)
457 (composition_gstring_put_cache):
458 * composite.h (struct composition.hash_index):
459 * dispextern.h (struct image.hash):
460 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
461 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
462 (hashfn_equal, hashfn_user_defined, make_hash_table)
463 (maybe_resize_hash_table, hash_lookup, hash_put)
464 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
465 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
466 (Fsxhash, Fgethash, Fputhash, Fmaphash):
467 * image.c (make_image, search_image_cache, lookup_image)
468 (xpm_put_color_table_h):
469 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 470 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
471 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
472 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
473 * alloc.c (allocate_vectorlike):
474 Check for overflow in vector size calculations.
475 * ccl.c (ccl_driver):
476 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
477 * fns.c, image.c: Remove unnecessary static decls that would otherwise
478 need to be updated by these changes.
40087514
PE
479 * fns.c (make_hash_table, maybe_resize_hash_table):
480 Check for integer overflow with large hash tables.
0de4bb68
PE
481 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
482 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
483 (SXHASH_REDUCE): New macro.
484 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
485 Use it instead of discarding useful hash info with large hash values.
486 (sxhash_float): New function.
487 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
488 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
489 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
490 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
491 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
492 Adjust signatures to match updated version of code.
493 (consing_since_gc): Now EMACS_INT, since a single hash table can
494 use more than INT_MAX bytes.
495
698d32e2
DN
4962011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
497
498 Make it possible to build with GCC-4.6+ -O2 -flto.
499
500 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
501
fd6fa53f
SM
5022011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
503
504 * minibuf.c (get_minibuffer, read_minibuf_unwind):
505 Call minibuffer-inactive-mode.
506
864db017
JB
5072011-05-31 Juanma Barranquero <lekktu@gmail.com>
508
509 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
510 Update dependencies.
511
2ad0baf4
DN
5122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
513
514 * data.c (init_data): Remove code for UTS, this system is not
515 supported anymore.
516
4fcc2638
DN
5172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
518
519 Don't force ./temacs to start in terminal mode.
520
521 * frame.c (make_initial_frame): Initialize faces in all cases, not
522 only when CANNOT_DUMP is defined.
523 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
524
c56e0fd5
DN
5252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
526
527 * dispnew.c (add_window_display_history): Use const for the string
528 pointer. Remove declaration, not needed.
529
333d54da 5302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 531
55d4c1b2 532 Use 'inline', not 'INLINE'.
333d54da 533 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
534 * alloc.c, fontset.c (INLINE): Remove.
535 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
536 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
537 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
538 * gmalloc.c (register_heapinfo): Use inline unconditionally.
539 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
540
738db178
DN
5412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
542
543 Make it possible to run ./temacs.
544
545 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
546 syms_of_callproc does the same thing. Remove test for
547 "initialized", do it in the caller.
548 * emacs.c (main): Avoid calling set_initial_environment when dumping.
549
620c53a6
SM
5502011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
551
552 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
553 (read_minibuf): Use get_minibuffer.
554 (syms_of_minibuf): Use DEFSYM.
555 (Qmetadata): New var.
556 * data.c (Qbuffer): Don't make it static.
557 (syms_of_data): Use DEFSYM.
558
e003a292
PE
5592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
560
561 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
562 (CCL_CODE_MIN): New macro.
563
ed008a6d
PE
5642011-05-30 Paul Eggert <eggert@cs.ucla.edu>
565
3687c2ef
PE
566 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
567
ed008a6d
PE
568 * eval.c (Qdebug): Now static.
569 * lisp.h (Qdebug): Remove decl. This reverts a part of the
570 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
571 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
572
d66c4c7c
CY
5732011-05-29 Chong Yidong <cyd@stupidchicken.com>
574
575 * image.c: Various fixes to ImageMagick code comments.
576 (Fimagemagick_types): Doc fix.
577
5fbc2025
PE
5782011-05-29 Paul Eggert <eggert@cs.ucla.edu>
579
0196f88a
PE
580 Minor fixes prompted by GCC 4.6.0 warnings.
581
582 * xselect.c (converted_selections, conversion_fail_tag): Now static.
583
5fbc2025
PE
584 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
585 (x_clipboard_manager_save_all): Move extern decl to ...
586 * xterm.h: ... here, so that it can be checked for consistency.
587
1dd3c2d9
CY
5882011-05-29 Chong Yidong <cyd@stupidchicken.com>
589
590 * xselect.c (x_clipboard_manager_save_frame)
591 (x_clipboard_manager_save_all): New functions.
592 (Fx_clipboard_manager_save): Lisp function deleted.
593
594 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
595 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
596
597 * xterm.h: Update prototype.
598
5ba6571d
WX
5992011-05-28 William Xu <william.xwl@gmail.com>
600
601 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
602 exiting (Bug#8239).
603
3eaff834
JM
6042011-05-28 Jim Meyering <meyering@redhat.com>
605
e1900994 606 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
607 * fns.c (to_uchar): Define.
608 (crypto_hash_function): Use it to convert some newly-signed
609 variables to unsigned, to avoid sign-extension bugs. For example,
610 without this change, (md5 "truc") would evaluate to
611 45723a2aff78ff4fff7fff1114760e62 rather than the expected
612 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 613 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 614
0f6990a7
PE
6152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
616
617 Integer overflow fixes.
c8a9ca5a 618
08686060
PE
619 * dbusbind.c: Serial number integer overflow fixes.
620 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
621 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
622 to hold a serial number that is too large for a fixnum.
623 (Fdbus_method_return_internal, Fdbus_method_error_internal):
624 Check for serial numbers out of range. Decode any serial number
59568bf0 625 that was so large that it became a float. (Bug#8722)
08686060 626
2d1fc3c7
PE
627 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
628 (Fdbus_call_method, Fdbus_call_method_asynchronously):
629 Use XFASTINT rather than XUINT when numbers are nonnegative.
630 (xd_append_arg, Fdbus_method_return_internal):
631 (Fdbus_method_error_internal): Likewise. Also, for unsigned
632 arguments, check that Lisp number is nonnegative, rather than
59568bf0 633 silently wrapping negative numbers around. (Bug#8722)
30217ff0 634 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 635 (Bug#8722)
2d1fc3c7 636
c8a9ca5a
PE
637 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
638
519e1d69
PE
639 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
640
30569699
PE
641 ccl: add integer overflow checks
642 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
643 (IN_INT_RANGE): New macros.
644 (ccl_driver): Use them to check for integer overflow when
645 decoding a CCL program. Many of the new checks are whether XINT (x)
646 fits in int; it doesn't always, on 64-bit hosts. The new version
647 doesn't catch all possible integer overflows, but it's an
847044ea 648 improvement. (Bug#8719)
30569699 649
c11285dc
PE
650 * alloc.c (make_event_array): Use XINT, not XUINT.
651 There's no need for unsigned here.
652
fdccd48e
PE
653 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
654 This follows up to the 2011-05-06 change that substituted uintptr_t
655 for EMACS_INT. This case wasn't caught back then.
656
37910ab2
PE
657 Rework Fformat to avoid integer overflow issues.
658 * editfns.c: Include <float.h> unconditionally, as it's everywhere
659 now (part of C89). Include <verify.h>.
660 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
661 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
662 (Fformat): Avoid the prepass trying to compute sizes; it was only
663 approximate and thus did not catch overflow reliably. Instead, walk
664 through the format just once, formatting and computing sizes as we go,
665 checking for integer overflow at every step, and allocating a larger
666 buffer as needed. Keep track separately whether the format is
667 multibyte. Keep only the most-recently calculated precision, rather
668 than them all. Record whether each argument has been converted to
669 string. Use EMACS_INT, not int, for byte and char and arg counts.
670 Support field widths and precisions larger than INT_MAX. Avoid
671 sprintf's undefined behavior with conversion specifications such as %#d
672 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
673 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
674 formatting out-of-range floating point numbers with int
675 formats. (Bug#8668)
676
2e6578fb
PE
677 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
678
0ae6bdee
PE
679 * data.c: Avoid integer truncation in expressions involving floats.
680 * data.c: Include <intprops.h>.
681 (arith_driver): When there's an integer overflow in an expression
682 involving floating point, convert the integers to floating point
683 so that the resulting value does not suffer from catastrophic
684 integer truncation. For example, on a 64-bit host (* 4
685 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
686 Do not rely on undefined behavior after integer overflow.
687
de883a70
PE
688 merge count_size_as_multibyte, parse_str_to_multibyte
689 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 690 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
691 Check for integer overflow.
692 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
693 since it's now a duplicate of the other. This is more of
694 a character than a buffer op, so better that it's in character.c.
695 * fns.c, print.c: Adjust to above changes.
696
2ff916cb
PE
6972011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
698
699 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
700
f1b54466
PE
7012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
702
fb1ac845
PE
703 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
704 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
705 (x_clipboard_manager_save): Now static.
706 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
707
f1b54466
PE
708 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
709 (crypto_hash_function): Now static.
710 Fix pointer signedness problems. Avoid unnecessary initializations.
711
a9f737ee
CY
7122011-05-27 Chong Yidong <cyd@stupidchicken.com>
713
714 * termhooks.h (Vselection_alist): Make it terminal-local.
715
716 * terminal.c (create_terminal): Initialize it.
717
718 * xselect.c: Support for clipboard managers.
719 (Vselection_alist): Move to termhooks.h as terminal-local var.
720 (LOCAL_SELECTION): New macro.
721 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
722 (symbol_to_x_atom): Remove gratuitous arg.
723 (x_handle_selection_request, lisp_data_to_selection_data)
724 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
725 (x_own_selection, x_get_local_selection, x_convert_selection):
726 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
727 (some_frame_on_display): Delete unused function.
728 (Fx_own_selection_internal, Fx_get_selection_internal)
729 (Fx_disown_selection_internal, Fx_selection_owner_p)
730 (Fx_selection_exists_p): New optional frame arg.
731 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
732 (x_handle_selection_clear): Don't treat other terminals with the
733 same keyboard specially. Use the terminal-local Vselection_alist.
734 (x_clear_frame_selections): Use Frun_hook_with_args.
735
736 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
737
738 * xterm.h: Add support for those atoms.
739
e067f0c1
CY
7402011-05-26 Chong Yidong <cyd@stupidchicken.com>
741
742 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
743 (converted_selections, conversion_fail_tag): New global variables.
744 (x_selection_request_lisp_error): Free the above.
745 (x_get_local_selection): Remove unnecessary code.
746 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
747 of converted selections stored in converted_selections.
748 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
749 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
750 (x_convert_selection): New function.
751 (x_handle_selection_event): Simplify.
752 (x_get_foreign_selection): Don't ignore incoming requests while
753 waiting for an answer; this will fail when we implement
754 SAVE_TARGETS, and seems unnecessary anyway.
755 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
756 (Vx_sent_selection_functions): Doc fix.
757
0f4aebc0
LL
7582011-05-26 Leo Liu <sdl.web@gmail.com>
759
760 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
761
e61124cd
YM
7622011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
763
764 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
765
766 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
767 for fringe update if it has periodic bitmap.
768 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
769 and fringe_bitmap_periodic_p.
770
771 * fringe.c (get_fringe_bitmap_data): New function.
772 (draw_fringe_bitmap_1, update_window_fringes): Use it.
773 (update_window_fringes): Record periodicity of fringe bitmap in glyph
774 row. Mark glyph row for fringe update if periodicity changed.
775
776 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
777 for fringe update unless it has periodic bitmap.
778
f16d9837
KH
7792011-05-25 Kenichi Handa <handa@m17n.org>
780
781 * xdisp.c (get_next_display_element): Set correct it->face_id for
782 a static composition.
783
e1b90ef6
LL
7842011-05-24 Leo Liu <sdl.web@gmail.com>
785
786 * deps.mk (fns.o):
787 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
788
789 * fns.c (crypto_hash_function, Fsha1): New function.
790 (Fmd5): Use crypto_hash_function.
791 (syms_of_fns): Add Ssha1.
792
7400048f
PE
7932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
794
795 * gnutls.c: Remove unused macros.
796 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
797 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
798 Remove macros that are defined and never used.
799 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
800
abb71cf4
CY
8012011-05-22 Chong Yidong <cyd@stupidchicken.com>
802
803 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
804 (Fx_get_selection_internal): Minor cleanup.
805 (Fx_own_selection_internal): Rename arguments for consistency with
806 select.el.
807
6307db39
PE
8082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
809
810 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
811
f3d4e0a4
CY
8122011-05-22 Chong Yidong <cyd@stupidchicken.com>
813
814 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
815
4d8ade89
YM
8162011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
817
818 * dispnew.c (scrolling_window): Don't exclude the case that the
819 last enabled row in the desired matrix touches the bottom boundary.
820
32078c8d
GM
8212011-05-21 Glenn Morris <rgm@gnu.org>
822
823 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
824 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
825 and add some more files.
32078c8d 826
7285dc67
EZ
8272011-05-20 Eli Zaretskii <eliz@gnu.org>
828
829 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
830 report_file_error introduced by the change from 2011-05-07.
831
89d1bd22
PE
8322011-05-20 Paul Eggert <eggert@cs.ucla.edu>
833
834 * systime.h (Time): Define only if emacs is defined.
835 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
836 where the include path doesn't have X11/X.h by default. See
837 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
838
e23640bb 8392011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
840
841 * composite.c (find_automatic_composition): Fix previous change.
842
b9704ad9
GM
8432011-05-20 Glenn Morris <rgm@gnu.org>
844
845 * lisp.mk: New file, split from Makefile.in.
846 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
847 (shortlisp): Remove.
848 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
849
4a720484
GM
8502011-05-19 Glenn Morris <rgm@gnu.org>
851
852 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
853 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
854 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
855 (lisp): Set the order to that of loadup.el.
856 (shortlisp): Make it a copy of $lisp.
857 (SOME_MACHINE_LISP): Remove.
858 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
859 Use just $shortlisp, not $SOME_MACHINE_LISP too.
860
a28d4396
KH
8612011-05-18 Kenichi Handa <handa@m17n.org>
862
863 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
864 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
865 (find_automatic_composition): Mostly rewrite for efficiency.
866
a2b1fa8e
JB
8672011-05-18 Juanma Barranquero <lekktu@gmail.com>
868
869 * makefile.w32-in: Update dependencies.
870
8e1f5610
CS
8712011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
872
873 * menu.c: Include limits.h (fixes the MS-Windows build broken by
874 revision 104625).
875
7025ee00 8762011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 877
cdfa6eab
PE
878 Fix some integer overflow issues, such as string length overflow.
879
06d6db33
PE
880 * insdel.c (count_size_as_multibyte): Check for string overflow.
881
2b4560a8
PE
882 * character.c (lisp_string_width): Check for string overflow.
883 Use EMACS_INT, not int, for string indexes and lengths; in
884 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
885 the resulting string length overflows an EMACS_INT; instead,
886 report a string overflow if no precision given. When checking for
887 precision exhaustion, use a check that cannot possibly have
888 integer overflow. (Bug#8675)
889 * character.h (lisp_string_width): Adjust to new signature.
890
cb93f9be
PE
891 * alloc.c (string_overflow): New function.
892 (Fmake_string): Use it. This doesn't change behavior, but saves
893 a few bytes and will simplify future changes.
894 * character.c (string_escape_byte8): Likewise.
895 * lisp.h (string_overflow): New decl.
896
1a1f3366
PE
897 Fixups, following up to the user-interface timestamp change.
898 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
899 for UI timestamps, instead of unsigned long.
9fbd6841
PE
900 * msdos.c (mouse_get_pos): Likewise.
901 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
902 * w32gui.h (Time): Define by including "systime.h" rather than by
903 declaring it ourselves. (Bug#8664)
904
d4e3e4d3
PE
905 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
906 * image.c (clear_image_cache): Likewise.
907
f6a24d19
PE
908 * term.c (term_mouse_position): Don't assume time_t wraparound.
909
08dc5ae6
PE
910 Be more systematic about user-interface timestamps.
911 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
912 and sometimes 'EMACS_UINT', to represent these timestamps.
913 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
914 This makes the code easier to follow, and makes it easier to catch
915 integer overflow bugs such as Bug#8664.
916 * frame.c (Fmouse_position, Fmouse_pixel_position):
917 Use Time, not unsigned long, for user-interface timestamps.
918 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
919 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
920 * keyboard.h (last_event_timestamp): Likewise.
921 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
922 * menu.h (xmenu_show): Likewise.
923 * term.c (term_mouse_position): Likewise.
924 * termhooks.h (struct input_event.timestamp): Likewise.
925 (struct terminal.mouse_position_hook): Likewise.
926 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
927 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
928 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
929 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
930 what it was before.
931 * menu.h, termhooks.h: Include "systime.h", for Time.
932
8e55734a
PE
933 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
934 Don't assume that the difference between two unsigned long values
935 can fit into an integer. At this point, we know button_down_time
936 <= event->timestamp, so the difference must be nonnegative, so
937 there's no need to cast the result if double-click-time is
938 nonnegative, as it should be; check that it's nonnegative, just in
939 case. This bug is triggered when events are more than 2**31 ms
86db42d2 940 apart (about 25 days). (Bug#8664)
8e55734a 941
841f1b75 942 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 943 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 944
3e26f69c
PE
945 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
946 that always fit in int. Use a sentinel instead of a counter, to
947 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
948 * frame.h (struct frame): Use int for menu_bar_items_used
949 instead of EMACS_INT, since it always fits in int.
3e26f69c 950
5cc152c0
PE
951 * menu.c (grow_menu_items): Check for int overflow.
952
d89eb65e
PE
953 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
954
5235bd3e
PE
955 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
956 Before, the code was not consistent. These values cannot exceed
957 2**31 - 1 so there's no need to make them unsigned.
958 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
959 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
960 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
961 as modifiers.
962 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
963
bc827e23
PE
964 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
965 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
966 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
967 presumably because the widths might not match.
968
78eb494e
PE
969 * window.c (size_window): Avoid needless test at loop start.
970
04f2d78b
CB
9712011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
972
973 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
974
d2fc7e3d 9752011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
976
977 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
978
d2fc7e3d 9792011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
980
981 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
982 `width' to `bar_area_x' and `bar_area_width', respectively.
983 (x_scroll_run): Take account of fringe background extension.
984
04f2d78b
CB
985 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
986 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
987 `bar_area_width', respectively.
988 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
989 background extension.
990
79b70037
GM
9912011-05-10 Jim Meyering <meyering@redhat.com>
992
993 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
994
2f142cc5
JB
9952011-05-10 Juanma Barranquero <lekktu@gmail.com>
996
997 * image.c (Finit_image_library): Return t for built-in image types,
998 like pbm and xbm. (Bug#8640)
999
57679c86
AS
10002011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1001
1002 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1003
888c9e86
EZ
10042011-05-07 Eli Zaretskii <eliz@gnu.org>
1005
b0512a1d
EZ
1006 * w32console.c (Fset_screen_color): Doc fix.
1007 (Fget_screen_color): New function.
1008 (syms_of_ntterm): Defsubr it.
1009
7285dc67
EZ
1010 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1011 unlink the temporary file if Fcall_process didn't create it in the
1012 first place.
1013 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1014 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1015 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1016 cue to call_process_cleanup not to close that handle.
1017
4d3fcc8e
BK
10182011-05-07 Ben Key <bkey76@gmail.com>
1019
1020 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1021 one of two shell specific rules, either bootstrap-temacs-CMD or
1022 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1023 to the previous implementation of the bootstrap-temacs rule.
1024 The bootstrap-temacs-CMD rule is similar to the previous
1025 implementation of the bootstrap-temacs rule except that it
1026 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1027 variable.
1028
1029 These changes, along with some changes to nt/configure.bat,
1030 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1031 earlier fix to add support for --cflags and --ldflags options
1032 that include quotes so that it works whether make uses cmd or
1033 sh as the shell.
1034
b4289b64
MA
10352011-05-06 Michael Albinus <michael.albinus@gmx.de>
1036
1037 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1038 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1039 is a constant.
1040 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1041 a string. Handle both cases.
1042 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1043 (Fdbus_register_method): Use Qinvalid_function.
1044
af4c0e28
JB
10452011-05-06 Juanma Barranquero <lekktu@gmail.com>
1046
1047 * makefile.w32-in: Update dependencies.
1048 (LISP_H): Add inttypes.h and stdin.h.
1049 (PROCESS_H): Add unistd.h.
1050
c51453d9
EZ
10512011-05-06 Eli Zaretskii <eliz@gnu.org>
1052
1053 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1054 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1055
8ff0ac3c 10562011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1057
4c4b566b
PE
1058 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1059
aab2b9b5
PE
1060 * term.c (vfatal): Remove stray call to va_end.
1061 It's not needed and the C Standard doesn't allow it here anyway.
1062
c378da0b
PE
1063 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1064 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1065
288b08c7
PE
1066 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1067 bytes.
1068
e3601888
PE
1069 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1070
db6c0e74
PE
1071 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1072
dd5963ea
PE
1073 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1074
88c9450f
PE
1075 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1076
2f9442b8
PE
1077 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1078
c032b5f8
PE
1079 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1080 * charset.c (Fdefine_charset_internal): Don't initialize
1081 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1082 32-bit int (Bug#8600).
a108c10b
PE
1083
1084 * lread.c (read_integer): Be more consistent with string-to-number.
1085 Use string_to_number to do the actual conversion; this avoids
1086 rounding errors and fixes some other screwups. Without this fix,
1087 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1088 (digit_to_number): Move earlier, for benefit of read_integer.
1089 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1090 not a digit in any supported base. (Bug#8602)
a108c10b 1091
ad5f9eea
PE
1092 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1093
aec1708a
PE
1094 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1095 to match comment at start of function. This also removes a
1096 GCC warning about overflow in a 32+64-bit port.
1097
47be4ab5
PE
1098 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1099
371cac43
PE
1100 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1101 Reported by Stefan Monnier in
1102 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1103 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1104 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1105
d01a7826
PE
1106 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1107 (EMACS_UINTPTR): Likewise, with uintptr_t.
1108
7fd47d5c
PE
1109 * lisp.h: Prefer 64-bit EMACS_INT if available.
1110 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1111 on 32-bit hosts that have 64-bit int, so that they can access
1112 large files.
122b0c86
PE
1113 However, temporarily disable this change unless the temporary
1114 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1115
8727937b
PE
1116 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1117
8ac068ac
PE
1118 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1119 This removes an assumption that EMACS_INT and long are the same
1120 width as pointers. The assumption is true for Emacs porting targets
1121 now, but we want to make other targets possible.
1122 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1123 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1124 In the rest of the code, change types of integers that hold casted
1125 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1126 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1127 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1128 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1129 No need to cast type when ORing.
1130 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1131 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1132 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1133 assume EMACS_INT is the same width as char *.
1134 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1135 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1136 Remove no-longer-needed casts.
1137 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1138 (xg_tool_bar_help_callback, xg_make_tool_item):
1139 Use EMACS_INTPTR to hold an integer
1140 that will be cast to void *; this can avoid a GCC warning
1141 if EMACS_INT is not the same width as void *.
1142 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1143 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1144 (current_message_1, set_message_1):
1145 Use a local to convert to proper width without a cast.
1146 * xmenu.c (dialog_selection_callback): Likewise.
1147
ede49d71
PE
1148 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1149 Also, don't assume VALBITS / RAND_BITS is less than 5,
1150 and don't rely on undefined behavior when shifting a 1 left into
1151 the sign bit.
1152 * lisp.h (get_random): Change signature to match.
1153
2f30ecd0
PE
1154 * lread.c (hash_string): Use size_t, not int, for hash computation.
1155 Normally we prefer signed values; but hashing is special, because
1156 it's better to use unsigned division on hash table sizes so that
1157 the remainder is nonnegative. Also, size_t is the natural width
1158 for hashing into memory. The previous code used 'int', which doesn't
1159 retain enough info to hash well into very large tables.
1160 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1161
2a866e7b
PE
1162 * dbusbind.c: Don't possibly lose pointer info when converting.
1163 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1164 Use XPNTR rather than XHASH, so that the high-order bits of
1165 the pointer aren't lost when converting through void *.
1166
51639eac
PE
1167 * eval.c (Fautoload): Don't double-shift a pointer.
1168
92394119
PE
1169 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1170
dbdb9a7c
JB
11712011-05-06 Juanma Barranquero <lekktu@gmail.com>
1172
1173 * gnutls.c (DEF_GNUTLS_FN):
1174 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1175
db7a0b4f
AS
11762011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1177
1178 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1179 marker. (Bug#8610)
1180
f7ff1b0f 11812011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1182
1183 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1184 New version that can reserve upto 2GB of heap space.
1185
f7ff1b0f 11862011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1187
1188 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1189
639c109b
TZ
11902011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1191
1192 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1193 `gnutls_certificate_set_x509_key_file'.
1194
d2127135
JB
11952011-05-05 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1198 Update dependencies.
1199
e968f4f3
JB
12002011-05-04 Juanma Barranquero <lekktu@gmail.com>
1201
1202 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1203 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1204 Remove unused parameter `fildes'.
1205 * process.c (read_process_output, send_process): Don't pass it.
1206
84d358f0
JB
12072011-05-04 Juanma Barranquero <lekktu@gmail.com>
1208
1209 Fix previous change: the library cache is defined in w32.c.
1210 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1211 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1212
0898ca10
JB
12132011-05-04 Juanma Barranquero <lekktu@gmail.com>
1214
1215 Implement dynamic loading of GnuTLS on Windows.
1216
1217 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1218 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1219 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1220 Declare.
1221
1222 * gnutls.c (Qgnutls_dll): Define.
1223 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1224 (gnutls_*): Declare function pointers.
1225 (init_gnutls_functions): New function to initialize function pointers.
1226 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1227 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1228 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1229 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1230 (emacs_gnutls_write, emacs_gnutls_read)
1231 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1232 (Fgnutls_available_p): New function.
1233 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1234 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1235 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1236
1237 * image.c: Include w32.h.
1238 (Vimage_type_cache): Delete.
1239 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1240 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1241 (w32_delayed_load): Move to w32.c.
1242
1243 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1244
1245 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1246 (w32_delayed_load): Move from image.c. When loading a library, record
1247 its filename in the :loaded-from property of the library id.
1248 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1249 Initialize and staticpro them.
1250 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1251
1252 * process.c: Include lisp.h before w32.h, not after.
1253 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1254 instead of gnutls_record_check_pending.
1255
1256 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1257
ff4de4aa
TZ
12582011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1259
1260 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1261 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1262 as passed in.
1263
abe95abb
JD
12642011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1265
1266 * xterm.c (x_set_frame_alpha): Do not set property on anything
1267 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1268
e16e55d4
JB
12692011-05-02 Juanma Barranquero <lekktu@gmail.com>
1270
1271 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1272
bafcf6a5
JB
12732011-05-02 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1276 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1277 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1278 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1279 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1280 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1281 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1282 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1283 (Qgnutls_bootprop_callbacks_verify): Make static.
1284
e7a6747f
AS
12852011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1286
19ed11ba
AS
1287 * callproc.c: Indentation fixup.
1288
e7a6747f 1289 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1290 (wait_for_termination, interruptible_wait_for_termination):
1291 Move after wait_for_termination_1.
e7a6747f 1292
1ef14cb4
LMI
12932011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1294
1295 * sysdep.c (interruptible_wait_for_termination): New function
1296 which is like wait_for_termination, but allows keyboard
1297 interruptions.
1298
1299 * callproc.c (Fcall_process): Add (:file "file") as an option for
1300 the STDOUT buffer.
1301 (Fcall_process_region): Ditto.
1302
330d880c
EZ
13032011-04-30 Eli Zaretskii <eliz@gnu.org>
1304
8db90b73
EZ
1305 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1306 rather than `XVECTOR (FOO)->size'.
1307
330d880c
EZ
1308 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1309 inttypes.h, as a gnulib replacement is used if it not available in
1310 system headers.
1311
15cbd324
EZ
13122011-04-21 Eli Zaretskii <eliz@gnu.org>
1313
1314 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1315 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1316 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1317
1318 * coding.c (coding_alloc_by_realloc): Error out if destination
1319 will grow beyond MOST_POSITIVE_FIXNUM.
1320 (decode_coding_emacs_mule): Abort if there isn't enough place in
1321 charbuf for the composition carryover bytes. Reserve an extra
1322 space for up to 2 characters produced in a loop.
1323 (decode_coding_iso_2022): Abort if there isn't enough place in
1324 charbuf for the composition carryover bytes.
1325
13262011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1327
ae940cca
EZ
1328 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1329 aborting when %lld or %lll format is passed.
1330 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1331 %llo or %llx format is passed. (Bug#8545)
1332
03ab8921
EZ
1333 * window.c (window_scroll_line_based): Use a marker instead of
1334 simple variables to record original value of point. (Bug#7952)
1335
afda1437
EZ
1336 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1337 produced by %s or %c overflows available buffer space. (Bug#8545)
1338
f76dee0c
PE
13392011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1340
1341 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1342 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1343
fdc5744d
JB
13442011-04-28 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1347
638f053a
JB
13482011-04-28 Juanma Barranquero <lekktu@gmail.com>
1349
1350 * keyboard.c (Qdelayed_warnings_hook): Define.
1351 (command_loop_1): Run `delayed-warnings-hook'
1352 if Vdelayed_warnings_list is non-nil.
1353 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1354 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1355
d178f871
EZ
13562011-04-28 Eli Zaretskii <eliz@gnu.org>
1357
1358 * doprnt.c (doprnt): Don't return value smaller than the buffer
1359 size if the message was truncated. (Bug#8545).
1360
b124fd93
JB
13612011-04-28 Juanma Barranquero <lekktu@gmail.com>
1362
1363 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1364 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1365
e810457d
PE
13662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1369
ea51cceb
JB
13702011-04-27 Juanma Barranquero <lekktu@gmail.com>
1371
1372 * makefile.w32-in: Update dependencies.
1373
94dcfacf
EZ
13742011-04-27 Eli Zaretskii <eliz@gnu.org>
1375
1376 Improve `doprnt' and its usage. (Bug#8545)
1377 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1378 `format_end'. Remove support for %l as a conversion specifier.
1379 Don't use xrealloc. Improve diagnostics when the %l size modifier
1380 is used. Update the commentary.
1381
1382 * eval.c (verror): Simplify calculation of size_t.
1383
1384 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1385 messages.
1386
f61f41d7
PE
13872011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1388
1389 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1390 change.
1391
96fb4434
PE
13922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1395 This makes this file independent of the recent pseudovector change.
1396
671875da 13972011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1398
69e9b5a3
PE
1399 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1400
b5f869a7 1401 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1402 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1403 Remove unused local.
c8926152 1404 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1405
841a1577 1406 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1407 GCC 4.6.0 optimizes based on type-based alias analysis.
1408 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1409 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1410 != &v->size, and therefore "v->size = 1; b->size = 2; return
1411 v->size;" must therefore return 1. This assumption is incorrect
1412 for Emacs, since it type-puns struct Lisp_Vector * with many other
1413 types. To fix this problem, this patch adds a new type struct
f904488f 1414 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1415 and pseudovectors, and helps optimizing compilers not get fooled
1416 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1417 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1418 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1419 the size member.
eab3844f
PE
1420 (XSETPVECTYPE): Rewrite in terms of new macro.
1421 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1422 This is a bit clearer, and further avoids the possibility of
1423 undesirable aliasing.
1424 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1425 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1426 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1427 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1428 (ASIZE): Now uses header.size rather than size.
1429 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1430 to avoid the hassle of writing XVECTOR (foo)->header.size.
1431 (struct vectorlike_header): New type.
eab3844f
PE
1432 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1433 object, to help avoid aliasing.
1434 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1435 (SUBRP): Likewise, since Lisp_Subr is a special case.
1436 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1437 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1438 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1439 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1440 changed to be "header.size" and "header.next".
1441 * buffer.h (struct buffer): Likewise.
1442 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1443 * frame.h (struct frame): Likewise.
1444 * process.h (struct Lisp_Process): Likewise.
1445 * termhooks.h (struct terminal): Likewise.
1446 * window.c (struct save_window_data, struct saved_window): Likewise.
1447 * window.h (struct window): Likewise.
1448 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1449 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1450 * buffer.c (init_buffer_once): Likewise.
1451 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1452 special case.
1453 * process.c (Fformat_network_address): Use local var for size,
1454 for brevity.
1455
0df1eac5
PE
1456 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1457
847ab9d1 1458 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1459 * data.c (atof): Remove decl; no longer used or needed.
1460 (digit_to_number): Move to lread.c.
1461 (Fstring_to_number): Use new string_to_number function, to be
1462 consistent with how the Lisp reader treats infinities and NaNs.
1463 Do not assume that floating-point numbers represent EMACS_INT
1464 without losing information; this is not true on most 64-bit hosts.
1465 Avoid double-rounding errors, by insisting on integers when
1466 parsing non-base-10 numbers, as the documentation specifies.
1467 * lisp.h (string_to_number): New decl, replacing ...
1468 (isfloat_string): Remove.
bc0a5c13 1469 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1470 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1471 appears to have been a coding error. Similarly, do not accept
1472 strings like +-1e0 as floating point numbers. Do not report
1473 overflow for integer overflows unless the base is not 10 which
1474 means we have no simple and reliable way to continue.
1475 Break out the floating-point parsing into a new
1476 function string_to_number, so that Fstring_to_number parses
1477 floating point numbers consistently with the Lisp reader.
04f2d78b 1478 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1479 (E_CHAR, EXP_INT): Remove, replacing with ...
1480 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1481 (string_to_number): New function, replacing isfloat_string.
1482 This function checks for valid syntax and produces the resulting
1483 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1484 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1485 so that overflow for non-base-10 numbers is reported only when
1486 there's no portable and simple way to convert to floating point.
452f4150 1487
67769ffc
PE
1488 * textprop.c (set_text_properties_1): Rewrite for clarity,
1489 and to avoid GCC warning about integer overflow.
1490
c20db43f
PE
1491 * intervals.h (struct interval): Use EMACS_INT for members
1492 where EMACS_UINT might cause problems. See
1493 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1494 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1495 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1496 All uses changed.
37aa2f85
PE
1497 (offset_intervals): Tell GCC not to worry about length overflow
1498 when negating a negative length.
c20db43f 1499
2538aa2f
PE
1500 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1501 (overrun_check_free): Likewise.
1502
f2d3008d
PE
1503 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1504 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1505 word size.
1506
ec8df744
PE
1507 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1508 (gnutls_make_error): Rename local to avoid shadowing.
1509 (gnutls_emacs_global_deinit): ifdef out; not used.
1510 (Fgnutls_boot): Use const for pointer to readonly storage.
1511 Comment out unused local. Fix pointer signedness problems.
1512
640ee02d
PE
1513 * lread.c (openp): Don't stuff size_t into an 'int'.
1514 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1515 about possible signed overflow.
1516
6048fb2a
PE
1517 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1518 (GDK_KEY_g): Don't define if already defined.
1519 (xg_prepare_tooltip): Avoid pointer signedness problem.
1520 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1521
fa3c87e1
PE
1522 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1523 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1524
2172544b
PE
1525 * xfns.c (Fx_window_property): Simplify a bit,
1526 to make a bit faster and to avoid GCC 4.6.0 warning.
1527 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1528
9b821a21
PE
1529 * fns.c (internal_equal): Don't assume size_t fits in int.
1530
3c616cfa
PE
1531 * alloc.c (compact_small_strings): Tighten assertion a little.
1532
c2982e87
PE
1533 Replace pEd with more-general pI, and fix some printf arg casts.
1534 * lisp.h (pI): New macro, generalizing old pEd macro to other
1535 conversion specifiers. For example, use "...%"pI"d..." rather
1536 than "...%"pEd"...".
1537 (pEd): Remove. All uses replaced with similar uses of pI.
1538 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1539 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1540 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1541 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1542 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1543 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1544 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1545 64-bit hosts.
1546 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1547 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1548 * print.c (safe_debug_print, print_object): Likewise.
1549 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1550 to int.
6f04d126
PE
1551 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1552 avoiding the 0 flag, which is not portable.
c2982e87
PE
1553 * process.c (Fmake_network_process): Use pI to avoid cast.
1554 * region-cache.c (pp_cache): Likewise.
1555 * xdisp.c (decode_mode_spec): Likewise.
1556 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1557 behavior on 64-bit hosts with printf arg.
6f04d126 1558 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1559 (x_stop_queuing_selection_requests): Likewise.
1560 (x_get_window_property): Don't truncate byte count to an 'int'
1561 when tracing.
0b432f21 1562
5e073ec7
PE
1563 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1564 here, since it parses constructs like leading '-' and spaces,
1565 which are not wanted; and it overflows with large numbers.
1566 Instead, simply match F[0-9]+, which is what is wanted anyway.
1567
36372bf9
PE
1568 * alloc.c: Remove unportable assumptions about struct layout.
1569 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1570 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1571 (allocate_vectorlike, make_pure_vector): Use the new macros,
1572 plus offsetof, to remove unportable assumptions about struct layout.
1573 These assumptions hold on all porting targets that I know of, but
1574 they are not guaranteed, they're easy to remove, and removing them
1575 makes further changes easier.
1576
0b432f21
PE
1577 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1578 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1579 (string_overrun_cookie): Now const. Use initializers that
1580 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1581 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1582 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1583 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1584 multiple of sizeof (EMACS_INT); it need not be, if
1585 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1586 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1587
895009e1
JB
15882011-04-26 Juanma Barranquero <lekktu@gmail.com>
1589
1590 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1591
6a7a1b0b
TZ
15922011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1593
1594 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1595 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1596 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1597
841a1577 15982011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1599
1600 * lisp.h (Qdebug): List symbol.
895009e1 1601 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1602 * keyboard.c (debug-on-event): New variable.
1603 (handle_user_signal): Break into debugger when debug-on-event
1604 matches the current signal symbol.
1605
f2d3ba6f
DN
16062011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1607
1608 * alloc.c (check_sblock, check_string_bytes)
1609 (check_string_free_list): Convert to standard C.
1610
42ce4c63
TZ
16112011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1612
1613 * w32.c (emacs_gnutls_push): Fix typo.
1614
825cd63c
EZ
16152011-04-25 Eli Zaretskii <eliz@gnu.org>
1616
fb11d64d
EZ
1617 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1618 "cast to pointer from integer of different size".
1619
825cd63c
EZ
1620 Improve doprnt and its use in verror. (Bug#8545)
1621 * doprnt.c (doprnt): Document the set of format control sequences
1622 supported by the function. Use SAFE_ALLOCA instead of always
1623 using `alloca'.
1624
1625 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1626 is one byte too soon. Don't use xrealloc; instead xfree and
1627 xmalloc anew.
1628
e061a11b
TZ
16292011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1630
1631 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1632 callbacks stage.
1633
1634 * gnutls.c: Renamed global_initialized to
1635 gnutls_global_initialized. Added internals for the
1636 :verify-hostname-error, :verify-error, and :verify-flags
1637 parameters of `gnutls-boot' and documented those parameters in the
1638 docstring. Start callback support.
1639 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1640 unless a fatal error occured. Call gnutls_alert_send_appropriate
1641 on error. Return error code.
1642 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1643 (emacs_gnutls_read): Likewise.
1644 (Fgnutls_boot): Return handshake error code.
1645 (emacs_gnutls_handle_error): New function.
1646 (wsaerror_to_errno): Likewise.
1647
1648 * w32.h (emacs_gnutls_pull): Add prototype.
1649 (emacs_gnutls_push): Likewise.
1650
1651 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1652 (emacs_gnutls_push): Likewise.
1653
16542011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1655
1656 * process.c (wait_reading_process_output): Check if GnuTLS
1657 buffered some data internally if no FDs are set for TLS
1658 connections.
1659
1660 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1661 (LIBS): Link to USER_LIBS.
1662 ($(BLD)/gnutls.$(0)): New target.
1663
fa6996bc
EZ
16642011-04-24 Eli Zaretskii <eliz@gnu.org>
1665
eb35682e
EZ
1666 * xdisp.c (handle_single_display_spec): Rename the
1667 display_replaced_before_p argument into display_replaced_p, to
1668 make it consistent with the commentary. Fix typos in the
1669 commentary.
1670
e2ad650c
EZ
1671 * textprop.c (syms_of_textprop): Remove dead code.
1672 (copy_text_properties): Delete obsolete commentary about an
1673 interface that was deleted long ago. Fix typos in the description
1674 of arguments.
1675
1b2de274
EZ
1676 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1677 to changes in oldXMenu/XMenu.h from 2011-04-16.
1678 <menu_help_message, prev_menu_help_message>: Constify.
1679 (IT_menu_make_room): menu->help_text is now `const char **';
1680 adjust.
1681
1682 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1683 to changes in oldXMenu/XMenu.h from 2011-04-16.
1684 (struct XMenu): Declare `help_text' `const char **'.
1685
1686 * xfaces.c <Qunspecified>: Make extern again.
1687
1688 * syntax.c: Include sys/types.h before including regex.h, as
1689 required by Posix.
1690
762b15be
EZ
1691 * doc.c (get_doc_string): Improve the format passed to `error'.
1692
1693 * doprnt.c (doprnt): Improve commentary.
1694
1695 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1696
1697 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1698 them with etags.
1699
f1052e5d
EZ
1700 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1701 changes in globals.h immediately force recompilation.
762b15be
EZ
1702 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1703 $(CURDIR)/s/ms-w32.h.
1704 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1705
fa6996bc
EZ
1706 * character.c (Fchar_direction): Function deleted.
1707 (syms_of_character): Don't defsubr it.
1708 <char-direction-table>: Deleted.
1709
e6c3da20
EZ
17102011-04-23 Eli Zaretskii <eliz@gnu.org>
1711
1712 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1713 * doprnt.c: Include limits.h.
1714 (SIZE_MAX): New macro.
04f2d78b
CB
1715 (doprnt): Return a size_t value. 2nd arg is now size_t.
1716 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1717 Improve overflow protection. Support `l' modifier for integer
1718 conversions. Support %l conversion. Don't assume an EMACS_INT
1719 argument for integer conversions and for %c.
1720
1721 * lisp.h (doprnt): Restore prototype.
1722
1723 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1724 $(SRC)/character.h.
1725
1726 * Makefile.in (base_obj): Add back doprnt.o.
1727
1728 * deps.mk (doprnt.o): Add back prerequisites.
1729 (callint.o): Depend on character.h.
1730
1731 * eval.c (internal_lisp_condition_case): Include the handler
1732 representation in the error message.
1733 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1734 when breaking from the loop.
1735
1736 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1737
1738 * callint.c (Fcall_interactively): When displaying error message
1739 about invalid control letter, pass the character's codepoint, not
1740 a pointer to its multibyte form. Improve display of the character
1741 in octal and display also its hex code.
1742
1743 * character.c (char_string): Use %x to display the (unsigned)
1744 codepoint of an invalid character, to avoid displaying a bogus
1745 negative value.
1746
1747 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1748 `error', not SYMBOL_NAME itself.
1749
1750 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1751 character arguments to `error'.
1752
1753 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1754 to `error' in error message about FINAL_CHAR argument. Make sure
1755 FINAL_CHAR is a character, and use %c when it is passed as
1756 argument to `error'.
1757
4ffd0d6b 17582011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1759
1760 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1761
1762 * w32.c: Include <time.h>.
1763 (sys_localtime): New function.
1764
4ffd0d6b 17652011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1766
1767 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1768
4ffd0d6b 1769 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1770
4ffd0d6b 17712011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1772
4ffd0d6b
GM
1773 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1774 zombies (Bug#8467).
aac0c6e3 1775
04c56954
EZ
17762011-04-19 Eli Zaretskii <eliz@gnu.org>
1777
1778 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1779 gl_state.e_property when gl_state.object is Qt.
1780
1781 * insdel.c (make_gap_larger): Remove limitation of buffer size
1782 to <= INT_MAX.
1783
16a43933
CY
17842011-04-18 Chong Yidong <cyd@stupidchicken.com>
1785
1786 * xdisp.c (lookup_glyphless_char_display)
1787 (produce_glyphless_glyph): Handle cons cell entry in
1788 glyphless-char-display.
1789 (Vglyphless_char_display): Document it.
1790
1791 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1792 glyphless-char-display.
1793
4581706e
CY
17942011-04-17 Chong Yidong <cyd@stupidchicken.com>
1795
1796 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1797
1798 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1799
1800 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1801 definition for no-X builds.
1802
4887c6e2 18032011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1804
fd35b6f9
PE
1805 Static checks with GCC 4.6.0 and non-default toolkits.
1806
5c1ccb01
PE
1807 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1808
006c5daa
PE
1809 * process.c (keyboard_bit_set): Define only if SIGIO.
1810 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1811 (send_process): Repair possible setjmp clobbering.
1812
efc736d3
PE
1813 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1814
4e2fe2e6
PE
1815 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1816
f97334a2
PE
1817 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1818
4e75f29d
PE
1819 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1820 Define only if needed.
1821
90efadd1
PE
1822 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1823 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1824 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1825
3c647824
PE
1826 * dispextern.h (struct redisplay_interface): Rename param
1827 to avoid shadowing.
e264f262 1828 * termhooks.h (struct terminal): Likewise.
761383f4 1829 * xterm.c (xembed_send_message): Likewise.
3c647824 1830
b58c5c4a
PE
1831 * insdel.c (make_gap_smaller): Define only if
1832 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1833
cad59032
PE
1834 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1835 it.
1836
c339dc2e
PE
1837 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1838 so that we aren't warned about unused symbols.
1839
91a3e27b
PE
1840 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1841
399c71d3 1842 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1843
8ffc96f5
PE
1844 * xfns.c (x_real_positions): Mark locals as initialized.
1845
eef9bc79
PE
1846 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1847
098db9dd
PE
1848 * xterm.c: Fix problems found by static analysis with other toolkits.
1849 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1850 (x_dispatch_event): Declare static if USE_GTK, and
1851 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1852 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1853 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1854 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1855 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1856
eb18f6cc
PE
1857 * xmenu.c (menu_help_callback): Pointer type fixes.
1858 Use const pointers when pointing at readonly data. Avoid pointer
1859 signedness clashes.
1860 (FALSE): Remove unused macro.
1861 (update_frame_menubar): Remove unused decl.
1862
1fe72bf8
PE
1863 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1864
60d9e1db
PE
1865 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1866 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1867 (single_menu_item): Rename local to avoid shadowing.
1868
39261c26
PE
1869 * keyboard.c (make_lispy_event): Remove unused local var.
1870
018c5e19
PE
1871 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1872 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1873
63d2b86e
PE
1874 * bitmaps: Change bitmaps from unsigned char back to the X11
1875 compatible char. Avoid the old compiler warnings about
1876 out-of-range initializers by using, for example, '\xab' rather
1877 than 0xab.
1878
aefd87e1
PE
1879 * xgselect.c (xgselect_initialize): Check vs interface
1880 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1881
bf501fb9
PE
1882 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1883
e9829fdf
PE
1884 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1885 to read-only memory.
1886
1086c095
PE
1887 * fns.c (vector): Remove; this old hack is no longer needed.
1888
2baccd04 1889 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1890 Remove unused var.
dde42981 1891 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1892
72391843 1893 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1894
436c16df 1895 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1896 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1897 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1898
92bb796d 1899 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1900 (x_term_init): Remove local to avoid shadowing.
92bb796d 1901
764430a3 1902 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1903
1904 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1905 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1906
d1dfb56c
EZ
19072011-04-16 Eli Zaretskii <eliz@gnu.org>
1908
c4354cb4
EZ
1909 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1910
d1dfb56c
EZ
1911 Fix regex.c, syntax.c and friends for buffers > 2GB.
1912 * syntax.h (struct gl_state_s): Declare character position members
1913 EMACS_INT.
1914
1915 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1916
04f2d78b
CB
1917 * textprop.c (verify_interval_modification, interval_of):
1918 Declare arguments EMACS_INT.
d1dfb56c
EZ
1919
1920 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1921 EMACS_INT.
1922
1923 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1924
1925 * indent.c (Fvertical_motion): Local variable it_start is now
1926 EMACS_INT.
1927
1928 * regex.c (re_match, re_match_2, re_match_2_internal)
1929 (bcmp_translate, regcomp, regexec, print_double_string)
1930 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1931 (re_compile_pattern, re_exec): Declare arguments and local
1932 variables `size_t' and `ssize_t' and return values `regoff_t', as
1933 appropriate.
1934 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1935 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1936 <compile_stack_type>: `size' and `avail' are now `size_t'.
1937
1938 * regex.h <regoff_t>: Use ssize_t, not int.
1939 (re_search, re_search_2, re_match, re_match_2): Arguments that
1940 specify buffer/string position and length are now ssize_t and
1941 size_t. Return type is regoff_t.
1942
613052cd
BK
19432011-04-16 Ben Key <bkey76@gmail.com>
1944
1945 * nsfont.m: Fixed bugs in ns_get_family and
1946 ns_descriptor_to_entity that were caused by using free to
1947 deallocate memory blocks that were allocated by xmalloc (via
1948 xstrdup). This caused Emacs to crash when compiled with
1949 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1950 --enable-checking=xmallocoverrun). xfree is now used to
1951 deallocate these memory blocks.
1952
4170f62f 19532011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1954
71b41406
PE
1955 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1956
9587a89d
PE
1957 emacs_write: Accept and return EMACS_INT for sizes.
1958 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1959 et seq.
1960 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1961 Accept and return EMACS_INT.
1962 (emacs_gnutls_write): Return the number of bytes written on
1963 partial writes.
1964 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1965 (emacs_read, emacs_write): Remove check for negative size, as the
1966 Emacs source code has been audited now.
9587a89d
PE
1967 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1968 (emacs_read, emacs_write): Use it.
273a5f82
PE
1969 * process.c (send_process): Adjust to the new signatures of
1970 emacs_write and emacs_gnutls_write. Do not attempt to store
1971 a byte offset into an 'int'; it might overflow.
9587a89d 1972 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1973
3e047f51
PE
1974 * sound.c: Don't assume sizes fit in 'int'.
1975 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1976 Return EMACS_INT, not int.
3e047f51 1977 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1978 Accept EMACS_INT, not int.
1979 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1980 record read return values.
1981
cc39a9db
BK
19822011-04-15 Ben Key <bkey76@gmail.com>
1983
c9d0ec6d
JB
1984 * keyboard.c (Qundefined): Don't declare static since it is used
1985 in nsfns.m.
1986 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1987 static since they are used in nsfont.m.
cc39a9db 1988
6c60eb9f
SM
19892011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1990
1991 * process.c (Qprocessp): Don't declare static.
1992 * lisp.h (Qprocessp): Declare again.
1993
7990b61a
JB
19942011-04-15 Juanma Barranquero <lekktu@gmail.com>
1995
1996 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1997
5d4cb038
PE
19982011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1999
8bd7b830 2000 Improve C-level modularity by making more things 'static'.
cd64ea1d 2001
e3b27b31
PE
2002 Don't publish debugger-only interfaces to other modules.
2003 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2004 (verify_bytepos, count_markers): Move decls to the only modules
2005 that need them.
2006 * region-cache.h (pp_cache): Likewise.
2007 * window.h (check_all_windows): Likewise.
2008 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2009
5d4cb038
PE
2010 * sysdep.c (croak): Now static, if
2011 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2012 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2013
2014 * alloc.c (refill_memory_reserve): Now static if
2015 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2016 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2017
e87b6180
PE
2018 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2019 Define only if USE_LUCID.
2020
ac64929e
PE
2021 * xrdb.c (x_customization_string, x_rm_string): Now static.
2022
6f37259d
PE
2023 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2024 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2025
1683e3ab
PE
2026 * xdisp.c (draw_row_with_mouse_face): Now static.
2027 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2028
de9c2632
PE
2029 * window.h (check_all_windows): Mark externally visible.
2030
2b96acb7
PE
2031 * window.c (window_deletion_count): Now static.
2032
2033 * undo.c: Make symbols static if they're not exported.
2034 (last_undo_buffer, last_boundary_position, pending_boundary):
2035 Now static.
2036
50436f33
PE
2037 * textprop.c (interval_insert_behind_hooks): Now static.
2038 (interval_insert_in_front_hooks): Likewise.
2039
64520e5c
PE
2040 * term.c: Make symbols static if they're not exported.
2041 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2042 (max_frame_lines, tty_set_terminal_modes):
2043 (tty_reset_terminal_modes, tty_turn_off_highlight):
2044 (get_tty_terminal): Now static.
2045 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2046 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2047 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2048 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2049 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2050
1fa53021
PE
2051 * sysdep.c: Make symbols static if they're not exported.
2052 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2053 Now static.
2054 (sigprocmask_set, full_mask): Remove; unused.
2055 (wait_debugging): Mark as visible.
2056 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2057 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2058
d4b43b22
PE
2059 * syntax.c (syntax_temp): Define only if !__GNUC__.
2060
b7c513d0
PE
2061 * sound.c (current_sound_device, current_sound): Now static.
2062
989b29ad
PE
2063 * search.c (searchbufs, searchbuf_head): Now static.
2064
13a55a78
PE
2065 * scroll.c (scroll_cost): Remove; unused.
2066 * dispextern.h (scroll_cost): Remove decl.
2067
de68a1fc
PE
2068 * region-cache.h (pp_cache): Mark as externally visible.
2069
40ccffa6
PE
2070 * process.c: Make symbols static if they're not exported.
2071 (process_tick, update_tick, create_process, chan_process):
2072 (Vprocess_alist, proc_buffered_char, datagram_access):
2073 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2074 (deactivate_process): Mark defn as static, as well as decl.
2075 * lisp.h (create_process): Remove decl.
2076 * process.h (chan_process, Vprocess_alist): Remove decls.
2077
ad64fc97
PE
2078 * print.c: Make symbols static if they're not exported.
2079 (print_depth, new_backquote_output, being_printed, print_buffer):
2080 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2081 (print_interval, print_number_index, initial_stderr_stream):
2082 Now static.
2083 * lisp.h (Fprinc): Remove decl.
2084 (debug_output_compilation_hack): Mark as externally visible.
2085
adddb265
PE
2086 * sysdep.c (croak): Move decl from here to syssignal.h.
2087 * syssignal.h (croak): Put it here, so the API can be checked when
2088 'croak' is called from dissociate_if_controlling_tty.
2089
1717ede2
PE
2090 * minibuf.c: Make symbols static if they're not exported.
2091 (minibuf_save_list, choose_minibuf_frame): Now static.
2092 * lisp.h (choose_minibuf_frame): Remove decl.
2093
fa5fb2bc
PE
2094 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2095
1e3890d1
PE
2096 * lread.c: Make symbols static if they're not exported.
2097 (read_objects, initial_obarray, oblookup_last_bucket_number):
2098 Now static.
2099 (make_symbol): Remove; unused.
2100 * lisp.h (initial_obarray, make_symbol): Remove decls.
2101
8a1414fa
PE
2102 * keyboard.c: Make symbols static if they're not exported.
2103 (single_kboard, recent_keys_index, total_keys, recent_keys):
2104 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2105 (this_single_command_key_start, echoing, last_auto_save):
2106 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2107 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2108 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2109 (Vlispy_mouse_stem, double_click_count):
2110 Now static.
2111 (force_auto_save_soon): Define only if SIGDANGER.
2112 (ignore_mouse_drag_p): Now static if
2113 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2114 (print_help): Remove; unused.
2115 (stop_character, last_timer_event): Mark as externally visible.
2116 * keyboard.h (ignore_mouse_drag_p): Declare only if
2117 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2118 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2119 * lisp.h (echoing): Remove decl.
2120 (force_auto_save_soon): Declare only if SIGDANGER.
2121 * xdisp.c (redisplay_window): Simplify code, to make it more
2122 obvious that ignore_mouse_drag_p is not accessed if !defined
2123 USE_GTK && !defined HAVE_NS.
2124
93ea6e8f
PE
2125 * intervals.c: Make symbols static if they're not exported.
2126 (merge_properties_sticky, merge_interval_right, delete_interval):
2127 Now static.
2128 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2129
77382fcc
PE
2130 * insdel.c: Make symbols static if they're not exported.
2131 However, leave prepare_to_modify_buffer alone. It's never
2132 called from outside this function, but that appears to be a bug.
2133 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2134 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2135 (adjust_after_replace_noundo): Remove; unused.
2136 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2137 (signal_before_change): Remove decls.
77382fcc 2138
9306c32e
PE
2139 * indent.c (val_compute_motion, val_vmotion): Now static.
2140
cd44d2eb
PE
2141 * image.c: Make symbols static if they're not exported.
2142 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2143 if USE_GTK.
2144 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2145 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2146
ad9a7a06
PE
2147 * fringe.c (standard_bitmaps): Now static.
2148 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2149
81626931
PE
2150 * frame.c: Make symbols static if they're not exported.
2151 (x_report_frame_params, make_terminal_frame): Now static.
2152 (get_frame_param): Now static, unless HAVE_NS.
2153 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2154 (x_get_resource_string): Remove; not used.
2155 * frame.h (make_terminal_frame, x_report_frame_params):
2156 (x_get_resource_string); Remove decls.
2157 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2158 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2159
239f9db9
PE
2160 * font.c, fontset.c: Make symbols static if they're not exported.
2161 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2162 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2163 * font.c (font_close_object): Now static.
2164 * font.h (font_close_object): Remove.
2165 * fontset.c (FONTSET_OBJLIST): Remove.
2166 (free_realized_fontset) #if-0 the body, which does nothing.
2167 (face_suitable_for_char_p): #if-0, as it's never called.
2168 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2169 * xfaces.c (face_at_string_position):
2170 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2171 since 0 is always ASCII.
2172
dfcf3579
PE
2173 * fns.c (weak_hash_tables): Now static.
2174
5045092b
PE
2175 * fileio.c: Make symbols static if they're not exported.
2176 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2177 (Vwrite_region_annotation_buffers): Now static.
2178
57a96f5c
PE
2179 * eval.c: Make symbols static if they're not exported.
2180 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2181 * lisp.h (backtrace_list): Remove decl.
2182
35f08c38
PE
2183 * emacs.c: Make symbols static if they're not exported.
2184 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2185 (fatal_error_code, fatal_error_signal_hook, standard_args):
2186 Now static.
2187 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2188 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2189 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2190 * lisp.h (fatal_error_signal_hook): Remove decl.
2191 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2192
f44bd759
PE
2193 * editfns.c: Move a (normally-unused) function to its only use.
2194 * editfns.c, lisp.h (get_operating_system_release): Remove.
2195 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2196 worth the hassle of breaking this out.
2197
b532497d
PE
2198 * xterm.c: Make symbols static if they're not exported.
2199 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2200 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2201 (x_destroy_window, x_delete_display):
2202 Now static.
2203 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2204 (x_mouse_leave): Remove; unused.
2205 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2206 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2207 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2208 Remove decls.
2209 (x_mouse_leave): Declare only if WINDOWSNT.
2210 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2211 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2212 USE_X_TOOLKIT.
2213
1675728f
PE
2214 * ftxfont.c: Make symbols static if they're not exported.
2215 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2216 HAVE_FREETYPE.
2217 * font.h (ftxfont_driver): Likewise.
2218
e4cebfca
PE
2219 * xfns.c: Make symbols static if they're not exported.
2220 (x_last_font_name, x_display_info_for_name):
2221 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2222 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2223 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2224 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2225 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2226 (last_show_tip_args): Now static.
2227 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2228 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2229 (x_screen_planes): Remove; unused.
2230 * dispextern.h (x_screen_planes): Remove decl.
2231
5bf46f05
PE
2232 * dispnew.c: Make symbols static if they're not exported.
2233 * dispextern.h (redraw_garbaged_frames, scrolling):
2234 (increment_row_positions): Remove.
2235 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2236 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2237 Now static.
2238 (redraw_garbaged_frames): Remove; unused.
2239
435f4c28
PE
2240 * xfaces.c: Make symbols static if they're not exported.
2241 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2242 Remove decls.
2243 * xterm.h (defined_color): Remove decls.
2244 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2245 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2246 (menu_face_changed_default, defined_color, free_realized_face):
2247 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2248 (ascii_face_of_lisp_face): Remove; unused.
2249
8524aef3
PE
2250 * xdisp.c: Make symbols static if they're not exported.
2251 * dispextern.h (scratch_glyph_row, window_box_edges):
2252 (glyph_to_pixel_coords, set_cursor_from_row):
2253 (get_next_display_element, set_iterator_to_next):
2254 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2255 (show_mouse_face): Remove decls
2256 * frame.h (message_buf_print): Likewise.
2257 * lisp.h (pop_message, set_message, check_point_in_composition):
2258 Likewise.
2259 * xterm.h (set_vertical_scroll_bar): Likewise.
2260 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2261 (message_buf_print, scratch_glyph_row, displayed_buffer):
2262 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2263 (get_next_display_element, show_mouse_face, window_box_edges):
2264 (frame_to_window_pixel_xy, check_point_in_composition):
2265 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2266 (glyph_to_pixel_coords): Remove; unused.
2267
16390cd2
PE
2268 * dired.c (file_name_completion): Now static.
2269
2270 * dbusbind.c (xd_in_read_queued_messages): Now static.
2271
a25f4dfa
PE
2272 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2273 * data.c (circular_list_error): Remove.
2274
14a9c8df
PE
2275 * commands.h (last_point_position, last_point_position_buffer):
2276 (last_point_position_window): Remove decls.
2277 * keyboard.c: Make these variables static.
2278
04f2d78b
CB
2279 * coding.h (coding, code_convert_region, encode_coding_gap):
2280 Remove decls.
74ab6df5
PE
2281 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2282 (iso_code_class, detect_coding, code_convert_region): Now static.
2283 (encode_coding_gap): Remove; unused.
2284
38dfbee1
PE
2285 * chartab.c (chartab_chars, chartab_bits): Now static.
2286
a2cb4e63
PE
2287 * charset.h (charset_iso_8859_1): Remove decl.
2288 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2289 Now static.
2290
127198fd
PE
2291 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2292 * ccl.c (Vccl_program_table): Now static.
2293 (check_ccl_update): Remove; unused.
2294
d85b608f
PE
2295 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2296 * category.h: ... from here.
2297 * category.c (check_category_table, set_category_set): Now static.
2298
31cd66f3
PE
2299 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2300 * lisp.h: Remove these decls.
2301
c358e587
PE
2302 * buffer.c (buffer_count): Remove unused var.
2303
e78aecca
PE
2304 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2305 so that it's not optimized away.
2306 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2307 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2308 exported only to the debugger.
2309
e192d7d3 2310 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2311 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2312
92470028
PE
2313 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2314 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2315 was inaccessible from Lisp.
2316 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2317 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2318
244ed907
PE
2319 alloc.c: Import and export fewer symbols, and remove unused items.
2320 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2321 is defined.
2322 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2323 it's not optimized away by whole-program optimization.
2324 (message_enable_multibyte, free_misc): Remove.
2325 (catchlist, handlerlist, mark_backtrace):
2326 Declare only if BYTE_MARK_STACK.
2327 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2328 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2329 (message_enable_multibyte): Remove decl.
2330 (free_misc, interval_free_list, float_block, float_block_index):
2331 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2332 (cons_free_list, last_marked_index):
2333 Now static.
2334 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2335 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2336 (mark_backtrace): Define only if BYTE_MARK_STACK.
2337 * xdisp.c (message_enable_multibyte): Now static.
2338
61c2b50e 2339 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2340 This makes it easier for human readers (and static analyzers)
2341 to see whether these variables are used from other modules.
2342 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2343 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2344 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2345 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2346 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2347 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2348 * xmenu.c, xselect.c:
2349 Declare Q* vars static if they are not used in other modules.
2350 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2351 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2352 Remove decls of unexported vars.
2353 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2354
95c82688
PE
2355 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2356
16a97296
PE
2357 Make Emacs functions such as Fatom 'static' by default.
2358 This makes it easier for human readers (and static analyzers)
2359 to see whether these functions can be called from other modules.
2360 DEFUN now defines a static function. To make the function external
2361 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2362 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2363 (Finit_image_library):
16a97296
PE
2364 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2365 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2366 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2367 Remove decls, since these functions are now static.
2368 (Funintern, Fget_internal_run_time): New decls, since these functions
2369 were already external.
95c82688 2370
16a97296
PE
2371 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2372 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2373 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2374 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2375 * keyboard.c, keymap.c, lread.c:
2376 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2377 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2378 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2379 Mark functions with DEFUE instead of DEFUN,
2380 if they are used in other modules.
2381 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2382 decls for now-static functions.
2383 * buffer.h (Fdelete_overlay): Remove decl.
2384 * callproc.c (Fgetenv_internal): Mark as internal.
2385 * composite.c (Fremove_list_of_text_properties): Remove decl.
2386 (Fcomposition_get_gstring): New forward static decl.
2387 * composite.h (Fcomposite_get_gstring): Remove decl.
2388 * dired.c (Ffile_attributes): New forward static decl.
2389 * doc.c (Fdocumntation_property): New forward static decl.
2390 * eval.c (Ffetch_bytecode): New forward static decl.
2391 (Funintern): Remove extern decl; now in .h file where it belongs.
2392 * fileio.c (Fmake_symbolic_link): New forward static decl.
2393 * image.c (Finit_image_library): New forward static decl.
2394 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2395 * intervals.h (Fprevious_property_change):
2396 (Fremove_list_of_text_properties): Remove decls.
2397 * keyboard.c (Fthis_command_keys): Remove decl.
2398 (Fcommand_execute): New forward static decl.
2399 * keymap.c (Flookup_key): New forward static decl.
2400 (Fcopy_keymap): Now static.
2401 * keymap.h (Flookup_key): Remove decl.
2402 * process.c (Fget_process): New forward static decl.
2403 (Fprocess_datagram_address): Mark as internal.
2404 * syntax.c (Fsyntax_table_p): New forward static decl.
2405 (skip_chars): Remove duplicate decl.
2406 * textprop.c (Fprevious_property_change): New forward static decl.
2407 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2408 Now internal.
2409 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2410 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2411
785bbd42
PE
2412 * editfns.c (Fformat): Remove unreachable code.
2413
8b913b57
AS
24142011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2415
2416 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2417 change. (Bug#8496)
2418
a6744a35
EZ
24192011-04-13 Eli Zaretskii <eliz@gnu.org>
2420
2421 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2422 when at ZV. (Bug#8487)
2423
e7974947
AS
24242011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2425
baad03f0
AS
2426 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2427 (Bug#8437)
2428 * keyboard.c (parse_tool_bar_item): Likewise.
2429 * sound.c (sound_cleanup, alsa_close): Likewise.
2430 * termcap.c (tgetent): Likewise.
2431 * xfns.c (x_default_font_parameter): Likewise.
2432 * xsettings.c (read_and_apply_settings): Likewise.
2433
e7974947
AS
2434 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2435 (overrun_check_free): Protoize.
2436
28272684
PE
24372011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2440 since callers should never pass a negative size.
2441 Change the signature to match that of plain 'read' and 'write'; see
2442 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2443 * lisp.h: Update prototypes of emacs_write and emacs_read.
2444
11997c76
EZ
24452011-04-11 Eli Zaretskii <eliz@gnu.org>
2446
2447 * xdisp.c (redisplay_window): Don't try to determine the character
2448 position of the scroll margin if the window start point w->startp
e896f03c 2449 is outside the buffer's accessible region. (Bug#8468)
11997c76 2450
8a2cbd72
EZ
24512011-04-10 Eli Zaretskii <eliz@gnu.org>
2452
2453 Fix write-region and its subroutines for buffers > 2GB.
2454 * fileio.c (a_write, e_write): Modify declaration of arguments and
2455 local variables to support buffers larger than 2GB.
2456 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2457
2458 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2459 argument, local variables, and return value.
2460
2461 * lisp.h: Update prototypes of emacs_write and emacs_read.
2462
2463 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2464
4073e537 24652011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2466
1ebfdcb6
PE
2467 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2468
b2ded58d
PE
2469 Fix more problems found by GCC 4.6.0's static checks.
2470
7d66342c
PE
2471 * xdisp.c (vmessage): Use a better test for character truncation.
2472
bbf47d44
PE
2473 * charset.c (load_charset_map): <, not <=, for optimization,
2474 and to avoid potential problems with integer overflow.
9248994d 2475 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2476 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2477 * editfns.c (Fformat): Likewise.
1e69125e 2478 * syntax.c (skip_chars): Likewise.
3befa583 2479
e3019616
PE
2480 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2481 This also lets GCC 4.6.0 generate slightly better loop code.
2482
becfa255
PE
2483 * callint.c (Fcall_interactively): <, not <=, for optimization.
2484 (Fcall_interactively): Count the number of arguments produced,
2485 not the number of arguments given. This is simpler and lets GCC
2486 4.6.0 generate slightly better code.
2487
dae0cd48
PE
2488 * ftfont.c: Distingish more carefully between FcChar8 and char.
2489 The previous code passed unsigned char * to a functions like
2490 strlen and xstrcasecmp that expect char *, which does not
2491 conform to the C standard.
2492 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2493 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2494 char * when the C standard requires it.
2495
76032d70
PE
2496 * keyboard.c (read_char): Remove unused var.
2497
eb3f1cc8
PE
2498 * eval.c: Port to Windows vsnprintf (Bug#8435).
2499 Include <limits.h>.
2500 (SIZE_MAX): Define if the headers do not.
2501 (verror): Do not give up if vsnprintf returns a negative count.
2502 Instead, grow the buffer. This ports to Windows vsnprintf, which
2503 does not conform to C99. Problem reported by Eli Zaretskii.
2504 Also, simplify the allocation scheme, by avoiding the need for
2505 calling realloc, and removing the ALLOCATED variable.
2506
70476b54
PE
2507 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2508
12020a9e
PE
2509 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2510 But keep the doprint source code for now, as we might revamp it
2511 and use it again (Bug#8435).
ea6c7ae6
PE
2512 * lisp.h (doprnt): Remove.
2513 * Makefile.in (base_obj): Remove doprnt.o.
2514 * deps.mk (doprnt.o): Remove.
2515
5fdb398c
PE
2516 error: Print 32- and 64-bit integers portably (Bug#8435).
2517 Without this change, on typical 64-bit hosts error ("...%d...", N)
2518 was used to print both 32- and 64-bit integers N, which relied on
2519 undefined behavior.
2520 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2521 New macro.
2522 * lisp.h (error, verror): Mark as printf-like functions.
2523 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2524 Report overflow in size calculations when allocating printf buffer.
2525 Do not truncate output string at its first null byte.
2526 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2527 Truncate the output at a character boundary, since vsnprintf does not
2528 do that.
2529 * charset.c (check_iso_charset_parameter): Convert internal
2530 character to string before calling 'error', since %c now has the
2531 printf meaning.
2532 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2533 overflow when computing char to be passed to 'error'. Do not
2534 pass Lisp_Object to 'error'; pass the integer instead.
2535 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2536 formatted with plain %d.
2537
b189fa66
PE
2538 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2539
bff87ef0
PE
2540 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2541
7e2cac20
PE
2542 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2543
ce4d90b5
PE
2544 * xterm.c (x_catch_errors): Remove duplicate declaration.
2545
266c9547
PE
2546 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2547
79c49ad2
PE
2548 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2549
368f4090
JM
25502011-04-10 Jim Meyering <meyering@redhat.com>
2551
2552 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2553 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2554 return ssize_t not "int", and use size_t as the buffer length.
2555 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2556 * gnutls.h: Update declarations.
2557 * process.c (read_process_output): Use ssize_t, to match.
2558 (send_process): Likewise.
2559
a32d4040
CY
25602011-04-09 Chong Yidong <cyd@stupidchicken.com>
2561
2562 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2563
8546720e 25642011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2565
04f2d78b
CB
2566 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2567 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2568
8546720e
GM
2569 * xterm.c (handle_one_xevent):
2570 * xmenu.c (create_and_show_popup_menu):
2571 * xselect.c (x_decline_selection_request)
2572 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2573
0a2f5c1a 25742011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2575
2576 Fix some uses of `int' instead of EMACS_INT.
2577 * search.c (string_match_1, fast_string_match)
2578 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2579 (scan_buffer, find_next_newline_no_quit)
2580 (find_before_next_newline, search_command, Freplace_match)
2581 (Fmatch_data): Make some `int' variables be EMACS_INT.
2582
2583 * xdisp.c (display_count_lines): 3rd argument and return value now
2584 EMACS_INT. All callers changed.
2585 (pint2hrstr): Last argument is now EMACS_INT.
2586
2587 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2588 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2589 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2590 (decode_coding_utf_16, decode_coding_emacs_mule)
2591 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2592 (decode_coding_ccl, decode_coding_charset)
2593 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2594 (decode_coding_iso_2022, decode_coding_emacs_mule)
2595 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2596 <char_offset, last_offset>: Declare EMACS_INT.
2597 (encode_coding_utf_8, encode_coding_utf_16)
2598 (encode_coding_emacs_mule, encode_invocation_designation)
2599 (encode_designation_at_bol, encode_coding_iso_2022)
2600 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2601 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2602 Declare EMACS_INT.
2603 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2604 (encode_invocation_designation): Last argument P_NCHARS is now
2605 EMACS_INT.
2606 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2607 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2608
2609 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2610 All users changed.
2611
2612 * ccl.c (Fccl_execute_on_string): Declare some variables
2613 EMACS_INT.
2614
8546720e 26152011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2616
2617 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2618
4e19a977
CS
26192011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2620
2621 * process.c (Fformat_network_address): Doc fix.
2622
87302331
R
26232011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2624
2625 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2626
cbb59342
CY
26272011-04-08 Chong Yidong <cyd@stupidchicken.com>
2628
2629 * keyboard.c (read_char): Call Lisp function help-form-show,
2630 instead of using internal_with_output_to_temp_buffer.
2631 (Qhelp_form_show): New var.
e0d38eeb 2632 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2633
2634 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2635
2636 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2637
e67a13ab
CY
26382011-04-06 Chong Yidong <cyd@stupidchicken.com>
2639
04f2d78b
CB
2640 * process.c (Flist_processes): Remove to Lisp.
2641 (list_processes_1): Delete.
e67a13ab 2642
973f782d
EZ
26432011-04-06 Eli Zaretskii <eliz@gnu.org>
2644
7c106b1e
EZ
2645 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2646
973f782d
EZ
2647 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2648
41cf7d1a 26492011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2650
ca23cc88
PE
2651 Fix more problems found by GCC 4.6.0's static checks.
2652
f390e2d5
PE
2653 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2654
42eea0d0
PE
2655 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2656
b69769da 2657 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2658
f9541e84
PE
2659 * xdisp.c (vmessage): Mark as a printf-like function.
2660
13841b55
PE
2661 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2662
c136c10f
PE
2663 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2664
5e2d4a30
PE
2665 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2666 printf-like functions.
2667 (tiff_load): Add casts to remove these marks before passing them
2668 to system-supplied API.
2669
583f48b9
PE
2670 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2671
b25d760e
PE
2672 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2673 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2674 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2675 directly, rather than having caller test rule sign. This avoids
2676 some unnecessary tests.
2677 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2678 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2679 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2680
bc7b6697 2681 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2682 (xfont_open): Avoid unnecessary tests.
bc7b6697 2683
27ccc379
PE
2684 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2685
dcd5c89a
PE
2686 * composite.h, composite.c (composition_gstring_put_cache):
2687 Use EMACS_INT, not int, for length.
2688
b13a45c6
PE
2689 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2690 breaking out part of COMPOSITION_DECODE_RULE.
2691 (COMPOSITION_DECODE_RULE): Use it.
2692 * composite.c (get_composition_id): Remove unused local vars,
2693 by using the new macro.
2694
1e792e4d
PE
2695 * textprop.c (set_text_properties_1): Change while to do-while,
2696 since the condition is always true at first.
2697
dc6c6455 2698 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2699 (interval_deletion_adjustment): Return unsigned value.
2700 All uses changed.
dc6c6455 2701
aba7731a
PE
2702 * process.c (list_processes_1, create_pty, read_process_output):
2703 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2704 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2705 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2706 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2707 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2708
fdfc4bf3
PE
2709 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2710
fca8fe46 2711 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2712 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2713
06a0259a 2714 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2715 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2716 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2717
e7b9e80f
PE
2718 * print.c (print_error_message): Avoid int overflow.
2719
56201685
PE
2720 * font.c (font_list_entities): Redo for clarity,
2721 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2722
78834453 2723 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2724 (font_score): Avoid potential overflow in diff calculation.
78834453 2725
0bc0b309 2726 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2727 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2728
e610eaca
PE
2729 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2730
b895abce
PE
2731 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2732 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2733 can always succeed if overflow has undefined behavior.
2734
1f1d9321 2735 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2736 (wordify): Omit three unnecessary tests.
1f1d9321 2737
c59478bc
PE
2738 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2739 All callers changed. This avoids the need for an unused var.
2740
79b73827
PE
2741 * casefiddle.c (casify_region): Remove var that is set but not used.
2742
a4db5dfe
PE
2743 * dired.c (file_name_completion): Remove var that is set but not used.
2744
43aae36e
PE
2745 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2746
2a47c44d 2747 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2748 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2749
a37c69bf
PE
2750 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2751 Check for integer overflow on size calculations.
2752
328ab8e7
PE
2753 * buffer.c (Fprevious_overlay_change): Remove var that is set
2754 but not used.
2755
e5a2a5cb
PE
2756 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2757 Remove vars that are set but not used.
8d84a6eb 2758 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2759 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2760
a60e5f68
PE
2761 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2762
f661cb61 2763 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2764 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2765
f0397f5a
PE
2766 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2767 that are set but not used.
2768
8664db06 2769 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2770 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2771
6abdaa4a
PE
2772 * xselect.c (x_get_local_selection, x_handle_property_notify):
2773 Remove vars that are set but not used.
2774
0ce7538d 2775 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2776 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2777
9ae848fc
PE
2778 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2779 Remove var that is set but not used.
0b918413
PE
2780 (scroll_bar_windows_size): Now size_t, not int.
2781 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2782 Check for overflow.
9ae848fc 2783
a5a62657
PE
2784 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2785 (map_tty_color) [!defined MSDOS]: Likewise.
2786
5c5cdd39
PE
2787 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2788
66ebf983
PE
2789 * coding.c: Remove vars that are set but not used.
2790 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2791 All callers changed.
2792 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2793 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2794 (decode_coding_charset): Remove vars that are set but not used.
2795
1be4d761
PE
2796 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2797 that is set but not used.
2798
47553fa8
PE
2799 * print.c (print_object): Remove var that is set but not used.
2800
1f7196bf 2801 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2802 The gnulib version avoids calling malloc in the usual case,
2803 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2804 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2805 * filelock.c (current_lock_owner): Likewise.
2806 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2807 * sysdep.c: Include allocator.h, careadlinkat.h.
2808 (emacs_no_realloc_allocator): New static constant.
2809 (emacs_readlink): New function.
fdb61804
PE
2810 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2811 ../lib/careadlinkat.h.
d1fdcab7 2812
f84c17c7
SM
28132011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2814
2815 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2816 first non-nil return value).
2817
ef3862ad
JD
28182011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2819
2820 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2821 if not defined (Bug#8403).
2822
376a7006
JB
28232011-04-02 Juanma Barranquero <lekktu@gmail.com>
2824
2825 * xdisp.c (display_count_lines): Remove parameter `start',
2826 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2827 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2828 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2829 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2830 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2831 and thereabouts. All callers changed.
2832 (get_per_char_metric): Remove parameter `f', unused since
2833 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2834
6ca3801d
JM
28352011-04-02 Jim Meyering <meyering@redhat.com>
2836
2837 do not dereference NULL upon failed strdup
2838 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2839 (ns_get_family): Likewise.
2840
d8e2b5ba
JB
28412011-04-02 Juanma Barranquero <lekktu@gmail.com>
2842
2843 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2844
8c74fcbd
JD
28452011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2846
2847 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2848 later (Bug#8403).
2849
7200d79c
SM
28502011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2851
03408648 2852 Add lexical binding.
7200d79c 2853
03408648
SM
2854 * window.c (Ftemp_output_buffer_show): New fun.
2855 (Fsave_window_excursion):
2856 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2857
2858 * lread.c (lisp_file_lexically_bound_p): New function.
2859 (Fload): Bind Qlexical_binding.
2860 (readevalloop): Remove `evalfun' arg.
2861 Bind Qinternal_interpreter_environment.
2862 (Feval_buffer): Bind Qlexical_binding.
2863 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2864 Mark as dynamic.
2865 (syms_of_lread): Declare `lexical-binding'.
2866
2867 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2868
2869 * keyboard.c (eval_dyn): New fun.
2870 (menu_item_eval_property): Use it.
ca105506
SM
2871
2872 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2873
03408648
SM
2874 * fns.c (concat, mapcar1): Accept byte-code-functions.
2875
2876 * eval.c (Fsetq): Handle lexical vars.
2877 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2878 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2879 (FletX, Flet): Obey lexical binding.
2880 (Fcommandp): Handle closures.
2881 (Feval): New `lexical' arg.
2882 (eval_sub): New function extracted from Feval. Use it almost
2883 everywhere where Feval was used. Look up vars in lexical env.
2884 Handle closures.
2885 (Ffunctionp): Move from subr.el.
2886 (Ffuncall): Handle closures.
2887 (apply_lambda): Remove `eval_flags'.
2888 (funcall_lambda): Handle closures and new byte-code-functions.
2889 (Fspecial_variable_p): New function.
2890 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2891 but without exporting it to Lisp.
23aba0ea 2892
23aba0ea 2893 * doc.c (Fdocumentation, store_function_docstring):
03408648 2894 * data.c (Finteractive_form): Handle closures.
23aba0ea 2895
03408648
SM
2896 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2897 interactive spec.
ba83908c 2898
04f2d78b
CB
2899 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2900 New byte-codes.
03408648
SM
2901 (exec_byte_code): New function extracted from Fbyte_code to handle new
2902 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2903
03408648 2904 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2905
03408648 2906 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2907
e2abce01
JB
29082011-03-31 Juanma Barranquero <lekktu@gmail.com>
2909
2910 * xdisp.c (redisplay_internal): Fix prototype.
2911
63696a73 29122011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2913
63696a73 2914 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2915 (try_scrolling): Use it when setting scroll_limit.
2916 Limit scrolling to 100 screen lines.
63696a73
EZ
2917 (redisplay_window): Even when falling back on "recentering",
2918 position point in the window according to scroll-conservatively,
2919 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2920
2921 (try_scrolling): When point is above the window, allow searching
2922 as far as scroll_max, or one screenful, to compute vertical
2923 distance from PT to the scroll margin position. This prevents
2924 try_scrolling from unnecessarily failing when
2925 scroll-conservatively is set to a value slightly larger than the
2926 window height. Clean up the case of PT below the margin at bottom
2927 of window: scroll_max can no longer be INT_MAX. When aggressive
2928 scrolling is in use, don't let point enter the opposite scroll
2929 margin as result of the scroll.
2930 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2931 threshold of 100 lines for never-recentering scrolling.
2932
e4cc2dfc
JB
29332011-03-31 Juanma Barranquero <lekktu@gmail.com>
2934
2935 * dispextern.h (move_it_by_lines):
2936 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2937 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2938 (message_log_check_duplicate): Remove parameters `prev_bol' and
2939 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2940 (redisplay_internal): Remove parameter `preserve_echo_area',
2941 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2942
2943 * indent.c (Fvertical_motion):
2944 * window.c (window_scroll_pixel_based, Frecenter):
2945 Don't pass `need_y_p' to `move_it_by_lines'.
2946
1c470562
SM
29472011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2948
44f230aa
SM
2949 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2950 steal a few bits to be more compact.
2951 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2952 Remove unneeded casts.
2953
1c470562
SM
2954 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2955
888adce9
ZK
29562011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2957
2958 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2959 binding" message (bug#7967).
2960
f838ed7b
PE
29612011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2962
77861b95
PE
2963 Fix more problems found by GCC 4.6.0's static checks.
2964
de6dbc14
PE
2965 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2966 Remove unused local var.
2967
f838ed7b
PE
2968 * editfns.c (Fmessage_box): Remove unused local var.
2969
792c7b2b
PE
2970 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2971 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2972 Omit unused local vars.
c499e557 2973 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2974 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2975 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2976 Omit unused local var.
2977
ba0165e1
PE
2978 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2979 Don't assume string length fits in int.
32ad8845 2980 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2981 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2982
3c59b4c9
PE
2983 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2984 instead of alloca (Bug#8344).
2985
a3eed478 2986 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2987 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2988
eb4d412d
PE
2989 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2990
1658b401
PE
2991 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2992 concerns.
2993
2994 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2995
2996 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2997
9a2c6e05
PE
2998 * keyboard.c (syms_of_keyboard): Use the same style as later
2999 in this function when indexing through an array. This also
3000 works around GCC bug 48267.
3001
03d0a109
PE
3002 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3003
44f730c8
PE
3004 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3005
fe75f926
PE
3006 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3007 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3008
ffa8c828
PE
3009 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3010 This avoids undefined behavior on integer overflow, and is a bit
3011 more convenient anyway since it is compared to a size_t variable.
3012
c5101a77
PE
3013 Variadic C functions now count arguments with size_t, not int.
3014 This avoids an unnecessary limitation on 64-bit machines, which
3015 caused (substring ...) to crash on large vectors (Bug#8344).
3016 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3017 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3018 All variadic functions and their callers changed accordingly.
c5101a77
PE
3019 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3020 * data.c (arith_driver, float_arith_driver): Likewise.
3021 * editfns.c (general_insert_function): Likewise.
3022 * eval.c (struct backtrace.nargs, interactive_p)
3023 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3024 (funcall_lambda, mark_backtrace): Likewise.
3025 * fns.c (concat): Likewise.
3026 * frame.c (x_set_frame_parameters): Likewise.
3027 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3028 0 if not found, not -1. All callers changed.
3029
dd3f25f7
PE
3030 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3031 (stack_copy_size): Now size_t, not int.
3032 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3033
461c2ab9
JB
30342011-03-28 Juanma Barranquero <lekktu@gmail.com>
3035
3036 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3037 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3038 All callers changed.
3039
3040 * lisp.h (multibyte_char_to_unibyte):
3041 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3042 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3043 * character.h (CHAR_TO_BYTE8):
3044 * cmds.c (internal_self_insert):
3045 * editfns.c (general_insert_function):
3046 * keymap.c (push_key_description):
3047 * search.c (Freplace_match):
3048 * xdisp.c (message_dolog, set_message_1): All callers changed.
3049
f6d62986
SM
30502011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3051
3052 * keyboard.c (safe_run_hook_funcall): New function.
3053 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3054 don't set the hook to nil, but remove the offending function instead.
3055 (Qcommand_hook_internal): Remove, unused.
3056 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3057 Vcommand_hook_internal.
3058
3059 * eval.c (enum run_hooks_condition): Remove.
3060 (funcall_nil, funcall_not): New functions.
3061 (run_hook_with_args): Call each function through a `funcall' argument.
3062 Remove `cond' argument, now redundant.
3063 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3064 (Frun_hook_with_args_until_failure): Adjust accordingly.
3065 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3066
1db5b1ad
JB
30672011-03-28 Juanma Barranquero <lekktu@gmail.com>
3068
3069 * dispextern.h (string_buffer_position): Remove declaration.
3070
3071 * print.c (strout): Remove parameter `multibyte', unused since
3072 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3073
3074 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3075 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3076 All callers changed.
3077
3078 * w32.c (_wsa_errlist): Use braces for struct initializers.
3079
3080 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3081 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3082 All callers changed.
3083 (string_buffer_position): Likewise. Also, make static (it's never
3084 used outside xdisp.c).
3085 (cursor_row_p): Remove parameter `w', unused since
3086 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3087 (decode_mode_spec): Remove parameter `precision', introduced during
3088 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3089 All callers changed.
3090
5ffb62aa
JD
30912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3092
3093 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3094
461c2ab9 30952011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3096
3097 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3098 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3099 (ns_update_auto_hide_menu_bar): New functions.
3100 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3101 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3102 ns_constrain_all_frames.
3103 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3104 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3105
5c380ffb
JD
31062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3107
3108 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3109
9af30bdf
GM
31102011-03-27 Glenn Morris <rgm@gnu.org>
3111
3112 * syssignal.h: Replace RETSIGTYPE with void.
3113 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3114 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3115 Replace SIGTYPE with void everywhere.
3116 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3117 * s/template.h (SIGTYPE): Remove commented out definition.
3118
e2abce01
JB
31192011-03-26 Eli Zaretskii <eliz@gnu.org>
3120
3121 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3122 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3123
f868cd8a
JB
31242011-03-26 Juanma Barranquero <lekktu@gmail.com>
3125
59eb0929
JB
3126 * w32.c (read_unc_volume): Use parameter `henum', instead of
3127 global variable `wget_enum_handle'.
3128
3129 * keymap.c (describe_vector): Remove parameters `indices' and
3130 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3131 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3132
f868cd8a
JB
3133 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3134
3135 * keyboard.c (timer_check): Remove parameter `do_it_now',
3136 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3137 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3138 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3139
3140 * keyboard.c (read_char):
3141 * w32menu.c (w32_menu_display_help):
3142 * xmenu.c (show_help_event, menu_help_callback):
3143 Adjust calls to `show_help_echo'.
3144
3145 * gtkutil.c (xg_maybe_add_timer):
3146 * keyboard.c (readable_events):
3147 * process.c (wait_reading_process_output):
3148 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3149
3150 * insdel.c (adjust_markers_gap_motion):
3151 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3152 (gap_left, gap_right): Don't call it.
3153
2ecf6fdb
CY
31542011-03-25 Chong Yidong <cyd@stupidchicken.com>
3155
3156 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3157 incurred during fontification.
3158
6b1f9ba4
JB
31592011-03-25 Juanma Barranquero <lekktu@gmail.com>
3160
3161 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3162 (DEFVAR_PER_BUFFER): Don't pass it.
3163
3164 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3165 (scrolling_window): Don't pass it.
3166
0f4a96b5
JB
31672011-03-25 Juanma Barranquero <lekktu@gmail.com>
3168
3169 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3170
3171 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3172 and `suffix'.
3173 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3174 of variables specific to SELinux and computation of `encoded_absname'.
3175
3176 * image.c (XPutPixel): Remove unused variable `height'.
3177
3178 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3179
3180 * unexw32.c (get_section_info): Remove unused variable `section'.
3181
3182 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3183 (system_process_attributes): Remove unused variable `sess'.
3184 (sys_read): Remove unused variable `err'.
3185
3186 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3187 (w32_wnd_proc): Remove unused variable `isdead'.
3188 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3189 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3190 (x_create_tip_frame): Remove unused variable `tem'.
3191
3192 * w32inevt.c (w32_console_read_socket):
3193 Remove unused variable `no_events'.
3194
3195 * w32term.c (x_draw_composite_glyph_string_foreground):
3196 Remove unused variable `width'.
3197
1149507c
JB
31982011-03-24 Juanma Barranquero <lekktu@gmail.com>
3199
3200 * w32term.c (x_set_glyph_string_clipping):
3201 Don't pass uninitialized region to CombineRgn.
3202
9c88f339
JB
32032011-03-23 Juanma Barranquero <lekktu@gmail.com>
3204
3205 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3206 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3207 (Fx_close_connection): Remove unused variable `i'.
3208
3209 * w32font.c (w32font_draw): Return number of glyphs.
3210 (w32font_open_internal): Remove unused variable `i'.
3211 (w32font_driver): Add missing initializer.
3212
3213 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3214 (fill_in_menu): Remove unused variable `items_added'.
3215
3216 * w32term.c (last_mouse_press_frame): Remove static global variable.
3217 (w32_clip_to_row): Remove unused variable `f'.
3218 (x_delete_terminal): Remove unused variable `i'.
3219
3220 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3221 (NOTHING): Remove unused static global variable.
3222 (uniscribe_check_otf): Remove unused variable `table'.
3223 (uniscribe_font_driver): Add missing initializers.
3224
dee091a3
JD
32252011-03-23 Julien Danjou <julien@danjou.info>
3226
3227 * term.c (Fsuspend_tty, Fresume_tty):
3228 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3229 * window.c (temp_output_buffer_show):
3230 * insdel.c (signal_before_change):
3231 * frame.c (Fhandle_switch_frame):
3232 * fileio.c (Fdo_auto_save):
3233 * emacs.c (Fkill_emacs):
3234 * editfns.c (save_excursion_restore):
3235 * cmds.c (internal_self_insert):
3236 * callint.c (Fcall_interactively):
3237 * buffer.c (Fkill_all_local_variables):
3238 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3239 Use Frun_hooks.
0f4a96b5 3240 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3241 unconditionnaly since it does the check itself.
3242
2c520ab5 32432011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3244
c9c49752
PE
3245 Fix more problems found by GCC 4.5.2's static checks.
3246
8abc3f12
PE
3247 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3248 the first time through the loop, since we know p0 < p1 then.
3249 This also avoids a gcc -Wstrict-overflow warning.
3250
a2d26660
PE
3251 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3252 leading to a memory leak, possible in functions like
3253 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3254 of objects (Bug#8318).
a2d26660 3255
916c72e9
PE
3256 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3257 that could (at least in theory) be that large.
3258
19ab8a18
PE
3259 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3260 This is less likely to overflow, and avoids undefined behavior if
3261 overflow does occur. All callers changed. Use strtoul to scan
3262 for the unsigned long integer.
b7cbbd6f
PE
3263 (pint2hrstr): Simplify and tune code slightly.
3264 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3265
f0641eff
PE
3266 * scroll.c (do_scrolling): Work around GCC bug 48228.
3267 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3268
7f650bb9
PE
3269 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3270 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3271 (validate_x_resource_name): Simplify count usage.
3272 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3273
37dd57d1
PE
3274 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3275 fail (Bug#8306).
81e56e61 3276
699979fc 3277 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3278
401bf9b4
PE
3279 * process.c (Fmake_network_process): Use socklen_t, not int,
3280 where POSIX says socklen_t is required in portable programs.
3281 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3282 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3283 (Fmake_network_process, server_accept_connection):
3284 (wait_reading_process_output, read_process_output):
3285 Likewise.
3286
b93aacde
PE
3287 * process.c: Rename or move locals to avoid shadowing.
3288 (list_processes_1, Fmake_network_process):
3289 (read_process_output_error_handler, exec_sentinel_error_handler):
3290 Rename or move locals.
4dc343ee 3291 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3292 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3293 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3294 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3295 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3296
af8a867c 3297 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3298 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3299 Include tparam.h instead, since it declares them.
af8a867c
PE
3300 * cm.h (PC): Remove extern decl; tparam.h now does this.
3301 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3302 * terminfo.c: Include tparam.h, to check interfaces.
3303 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3304 (tparam): Adjust signature to match interface in tparam.h;
3305 this removes some undefined behavior. Check that outstring and len
3306 are zero, which they always are with Emacs.
3307 * tparam.h (PC, BC, UP): New extern decls.
3308
0248044d 3309 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3310 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3311
8ff096c1 3312 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3313 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3314 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3315 (ftfont_list): Remove unused local.
49eaafba
PE
3316 (get_adstyle_property, ftfont_pattern_entity):
3317 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3318 Rename locals to avoid shadowing.
8ff096c1 3319
e2be39f6
PE
3320 * xfont.c (xfont_list_family): Mark var as initialized.
3321
c9735e30
PE
3322 * xml.c (make_dom): Now static.
3323
8f5201ae
PE
3324 * composite.c (composition_compute_stop_pos): Rename local to
3325 avoid shadowing.
b246f932
PE
3326 (composition_reseat_it): Remove unused locals.
3327 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3328 (composition_update_it): Mark var as initialized.
11b61122
PE
3329 (find_automatic_composition): Mark vars as initialized,
3330 with a FIXME (Bug#8290).
8f5201ae 3331
760fbc2c
PE
3332 character.h: Rename locals to avoid shadowing.
3333 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3334 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3335 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3336 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3337 to avoid shadowing.
3338
ff08eb85
PE
3339 * textprop.c (property_change_between_p): Remove; unused.
3340
fc7bf025
PE
3341 * intervals.c (interval_start_pos): Now static.
3342
235d7abc
PE
3343 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3344
44f230aa
SM
3345 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3346 Rename locals to avoid shadowing.
3e7d6594 3347
50060332
PE
3348 * sound.c (wav_play, au_play, Fplay_sound_internal):
3349 Fix pointer signedness.
d01f234b 3350 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3351 (wav_play): Initialize a variable to 0, to prevent undefined
3352 behavior (Bug#8278).
50060332 3353
c4fc4e30
PE
3354 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3355
918436ed
PE
3356 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3357
c939f91b
PE
3358 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3359 clobbering (Bug#8298).
b9c7f648
PE
3360 * sysdep.c (sys_subshell): Likewise.
3361 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3362
6bd8c144
PE
3363 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3364 This should get cleaned up, so that child_setup has the
3365 same signature on all platforms.
3366
7710357c 3367 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3368 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3369
c59da222
CY
33702011-03-22 Chong Yidong <cyd@stupidchicken.com>
3371
3372 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3373 not to be necessary, and produces flickering.
3374
66b87493
GM
33752011-03-20 Glenn Morris <rgm@gnu.org>
3376
3377 * config.in: Remove file.
3378
45b6f6d5
JB
33792011-03-20 Juanma Barranquero <lekktu@gmail.com>
3380
3381 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3382 are now in src/globals.h.
3383 (syms_of_minibuf): Remove spurious & from previous change.
3384
3ec03f7e
LL
33852011-03-20 Leo <sdl.web@gmail.com>
3386
3387 * minibuf.c (completing-read-function): New variable.
3388 (completing-read-default): Rename from completing-read.
3389 (completing-read): Call completing-read-function.
3390
b14e3e21
CY
33912011-03-19 Juanma Barranquero <lekktu@gmail.com>
3392
3393 * xfaces.c (Fx_load_color_file):
3394 Read color file from absolute filename (bug#8250).
3395
f2b726e6
JB
33962011-03-19 Juanma Barranquero <lekktu@gmail.com>
3397
3398 * makefile.w32-in: Update dependencies.
3399
09f6ff02
EZ
34002011-03-17 Eli Zaretskii <eliz@gnu.org>
3401
3402 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3403
29a6015a
PE
34042011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3405
a3a6c54e
PE
3406 Fix more problems found by GCC 4.5.2's static checks.
3407
b766f867
PE
3408 * process.c (make_serial_process_unwind, send_process_trap):
3409 (sigchld_handler): Now static.
3410
be02381c
PE
3411 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3412 That way, the code declares only the vars that it needs.
3413 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3414 * s/cygwin.h (PTY_ITERATION): Likewise.
3415 * s/darwin.h (PTY_ITERATION): Likewise.
3416 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3417
57048744
PE
3418 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3419 * process.c (allocate_pty): Don't declare stb unless it's needed.
3420
7914961c 3421 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3422 (CONSTANTLIM): Remove; unused.
3423 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3424 Define only if needed.
7914961c 3425
b3967b18
PE
3426 * unexelf.c (unexec): Name an expression,
3427 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3428 Use a different way to cause a compilation error if anyone uses
3429 n rather than nn, a way that does not involve shadowing.
73366a00 3430 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3431
29a6015a
PE
3432 * deps.mk (unexalpha.o): Remove; unused.
3433
43cfc33e 3434 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3435 * unexec.h: New file.
ce701a33
PE
3436 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3437 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3438 Depend on unexec.h.
3439 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3440 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3441 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3442 Change as necessary to match prototype in unexec.h.
ce701a33 3443
01f44d5a
PE
3444 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3445 shadowing.
4f63c6bb 3446 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3447
a6670b0b
PE
3448 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3449 Rename locals to avoid shadowing.
3450
cef2010d 3451 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3452 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3453
d4d7173a
PE
3454 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3455
f08b802a
PE
3456 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3457 warning when compiling print.c.
3458
3ddb0639
PE
3459 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3460 instead of using an uninitialized var.
5ad03b97 3461 (font_sort_entities): Mark var as initialized.
3ddb0639 3462
170a2692
PE
3463 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3464
e663c700
PE
3465 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3466 pointers to constants.
89bc529a 3467 (font_parse_fcname): Remove unused vars.
7b81e2d0 3468 (font_delete_unmatched): Now static.
ea838e10 3469 (font_get_spec): Remove; unused.
13a547c6
PE
3470 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3471 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3472 Rename or move locals to avoid shadowing.
e663c700 3473
2a80c887 3474 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3475 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3476
1384fa33 3477 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3478 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3479
8b2c52e9
PE
3480 * alloc.c (mark_backtrace): Move decl from here ...
3481 * lisp.h: ... to here, so that it can be checked.
3482
475545b5 3483 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3484 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3485 (lisp_indirect_variable): Name an expression,
3486 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3487 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3488
b1349114 3489 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3490 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3491 Use const pointer when appropriate.
b1349114 3492
a2928364
PE
3493 * lisp.h (get_system_name, get_operating_system_release):
3494 Move decls here, to check interfaces.
3495 * process.c (get_operating_system_release): Move decl to lisp.h.
3496 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3497 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3498 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3499 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3500 (Fformat_time_string, Fencode_time, Finsert_char):
3501 (Ftranslate_region_internal, Fformat):
3502 Rename or remove local vars to avoid shadowing.
9710023e 3503 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3504
a415e694
PE
3505 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3506 avoid shadowing.
3507
8ef4622d
PE
3508 * lisp.h (eassert): Check that the argument compiles, even if
3509 ENABLE_CHECKING is not defined.
3510
946f9a5b
PE
3511 * data.c (Findirect_variable): Name an expression, to avoid
3512 gcc -Wbad-function-cast warning.
112396d6 3513 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3514 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3515 (Fmake_variable_buffer_local, Fmake_local_variable):
3516 Mark variables as initialized.
52746918 3517 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3518
e5aab7e7 3519 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3520 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3521 Rename locals to avoid shadowing.
dff45157
PE
3522 (mark_stack): Move local variables into the #ifdef region where
3523 they're used.
7bc26fdb
PE
3524 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3525 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3526 needed otherwise.
3527 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3528 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3529 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3530
e5aab7e7
PE
3531 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3532 avoids undefined behavior in theory.
3533
4da60324
PE
3534 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3535
88043301
PE
3536 Use functions, not macros, for up- and down-casing (Bug#8254).
3537 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3538 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3539 to use the following functions instead of these macros.
3540 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3541 EMACS_INT, since callers assume the returned value fits in int.
3542 (upcase1): Likewise, for UPCASE_TABLE.
3543 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3544 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3545 the race-condition problem in the old DOWNCASE.
88043301 3546
19ed5445
PE
3547 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3548 Rename locals to avoid shadowing.
3549 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3550 (regex_compile, re_search_2, re_match_2_internal):
3551 Remove unused local vars.
952db0d7
PE
3552 (FREE_VAR): Rewrite so as not to use empty "else",
3553 which gcc can warn about.
da053e48 3554 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3555 (RETALLOC_IF): Define only if needed.
3556 (WORDCHAR_P): Likewise. This one is never needed, but is used
3557 only in a comment talking about a compiler bug, so put inside
3558 the #if 0 of that comment.
3559 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3560 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3561 Remove; unused.
19ed5445 3562
1f3561e4 3563 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3564 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3565 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3566
ded6f8f7
PE
3567 * search.c (simple_search): Remove unused var.
3568
dbd37a95
PE
3569 * dired.c (compile_pattern): Move decl from here ...
3570 * lisp.h: ... to here, so that it can be checked.
3571 (struct re_registers): New forward decl.
3572
7e47afad
PE
3573 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3574
85f24f61
PE
3575 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3576 All uses changed.
3577 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3578 Rename locals to avoid shadowing.
5671df8f 3579 (Fvertical_motion): Mark locals as initialized.
85f24f61 3580
181aa2be 3581 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3582 (casify_region): Mark local as initialized.
181aa2be 3583
930d429c
PE
3584 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3585
7082eac6
PE
3586 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3587 New macros, so that the caller can use some names other than
3588 gcpro1, gcpro2, etc.
3589 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3590 of the new macros.
3591 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3592 argument, for consistency with GCPRO2_VAR, etc: it is now the
3593 prefix of the variable, not the variable itself. All uses
3594 changed.
38b2c076
PE
3595 * dired.c (directory_files_internal, file_name_completion):
3596 Rename locals to avoid shadowing.
3597
15206ed9
PE
3598 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3599 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3600 dired.c's scmp function, had undefined behavior.
3601 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3602 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3603 * buffer.h: ... to here, because these macros use current_buffer,
3604 and the new implementation with inline functions needs to have
3605 current_buffer in scope now, rather than later when the macros
3606 are used.
3607 (downcase, upcase1): New static inline functions.
3608 (DOWNCASE, UPCASE1): Reimplement using these functions.
3609 This avoids undefined behavior in expressions like
3610 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3611 from race conditions in accessing the global variables
3612 case_temp1 and case_temp2.
3613 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3614 * lisp.h (case_temp1, case_temp2): Remove their decls.
3615 * character.h (ASCII_CHAR_P): Move from here ...
3616 * lisp.h: ... to here, so that the inline functions mentioned
3617 above can use them.
3618
4a6bea26
PE
3619 * dired.c (directory_files_internal_unwind): Now static.
3620
f14b7e14
PE
3621 * fileio.c (file_name_as_directory, directory_file_name):
3622 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3623 Now static.
2893f146
PE
3624 (file_name_as_directory): Use const pointers when appropriate.
3625 (Fexpand_file_name): Likewise. In particular, newdir might
3626 point at constant storage, so make it a const pointer.
fd4ead52 3627 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3628 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3629 signedness issues.
f839df0c
PE
3630 (Fset_file_times, Finsert_file_contents, auto_save_error):
3631 Rename locals to avoid shadowing.
f14b7e14 3632
5716756e 3633 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3634 (Ftry_completion, Fall_completions): Rename or remove locals
3635 to avoid shadowing.
5716756e 3636
b4c3046a
PE
3637 * marker.c (bytepos_to_charpos): Remove; unused.
3638
b45db522
PE
3639 * lisp.h (verify_bytepos, count_markers): New decls,
3640 so that gcc does not warn that these functions aren't declared.
3641
85876d07
PE
3642 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3643 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3644 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3645 (copy_text): Remove unused local var.
85876d07 3646
03d78a21 3647 * filelock.c (within_one_second): Now static.
b3dd38ab 3648 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3649
5df8f01b
PE
3650 * buffer.c (fix_overlays_before): Mark locals as initialized.
3651 (fix_start_end_in_overlays): Likewise. This function should be
3652 simplified by using pointers-to-pointers, but that's a different
3653 matter.
b1d876f1 3654 (switch_to_buffer_1): Now static.
8f54f30a
PE
3655 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3656 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3657
a70072c9 3658 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3659 Fix pointer signedness issue.
edced198
PE
3660 (sys_subshell): Mark local as volatile if checking for lint,
3661 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3662 (MAXPATHLEN): Define only if needed.
a70072c9 3663
a0977c44
PE
3664 * process.c (serial_open, serial_configure): Move decls from here ...
3665 * systty.h: ... to here, so that they can be checked.
3666
a884fdcc
PE
3667 * fns.c (get_random, seed_random): Move extern decls from here ...
3668 * lisp.h: ... to here, so that they can be checked.
3669
604efe86 3670 * sysdep.c (reset_io): Now static.
b8950c94 3671 (wait_for_termination_signal): Remove; unused.
604efe86 3672
38fc62d9
PE
3673 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3674 (copy_keymap_item, append_key, push_text_char_description):
3675 Now static.
1004a21a 3676 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3677 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3678 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3679 (describe_map_tree):
3680 Rename locals to avoid shadowing.
38fc62d9 3681
2f2650da
PE
3682 * keyboard.c: Declare functions static if they are not used elsewhere.
3683 (echo_char, echo_dash, cmd_error, top_level_2):
3684 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3685 (read_char, kbd_buffer_get_event, make_lispy_position):
3686 (make_lispy_event, make_lispy_movement, apply_modifiers):
3687 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3688 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3689 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3690 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3691 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3692
a053e86c 3693 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3694 (mark_kboards): Move decl here ...
3695 * alloc.c (mark_kboards): ... from here.
a053e86c 3696
4752793e
PE
3697 * lisp.h (force_auto_save_soon): New decl.
3698
74f10ca7 3699 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3700 (DEFINE_DUMMY_FUNCTION): New macro.
3701 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3702 Use it.
c03cd23f
PE
3703 (main): Add casts to avoid warnings
3704 if GCC considers string literals to be constants.
74f10ca7 3705
022e70d4
PE
3706 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3707
59d6fe83
PE
3708 * dbusbind.c: Pointer signedness fixes.
3709 (xd_signature, xd_append_arg, xd_initialize):
3710 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3711 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3712 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3713 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3714
78320123
PE
3715 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3716 if GCC considers string literals to be constants.
49cebcca 3717 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3718
35ac2a97
SM
37192011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3720
fb103ca9
SM
3721 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3722 (print_preprocess, print_object): New macro to fix last change.
3723
35ac2a97
SM
3724 * print.c (print_preprocess): Don't forget font objects.
3725
62973b41
JB
37262011-03-16 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * emacs.c (USAGE3): Doc fixes.
3729
0e48bb22
AS
37302011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3731
3732 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3733 structure.
3734
7684e57b
JB
37352011-03-14 Juanma Barranquero <lekktu@gmail.com>
3736
3737 * lisp.h (VWindow_system, Qfile_name_history):
3738 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3739 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3740 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3741
3742 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3743 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3744
3745 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3746 * w32console.c (detect_input_pending, read_input_pending)
3747 (encode_terminal_code):
3748 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3749 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3750 (w32_system_caret_y, Qfile_name_history):
3751 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3752 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3753 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3754 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3755 * w32proc.c (Qlocal, report_file_error):
3756 * w32term.c (Vwindow_system, updating_frame):
3757 * w32uniscribe.c (initialized, uniscribe_font_driver):
3758 Remove unneeded extern declarations.
3759
2aa46d6c
CY
37602011-03-14 Chong Yidong <cyd@stupidchicken.com>
3761
c96bbc66 3762 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3763
cffc6f3b
CY
37642011-03-13 Chong Yidong <cyd@stupidchicken.com>
3765
3766 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3767 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3768 These macros can no longer be used for assignment.
3769
44f230aa
SM
3770 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3771 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3772 (record_buffer_markers, fetch_buffer_markers): New functions for
3773 recording and fetching special buffer markers.
3774 (set_buffer_internal_1, set_buffer_temp): Use them.
3775
3776 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3777
3778 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3779
3780 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3781 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3782
3783 * xdisp.c (hscroll_window_tree):
3784 (reconsider_clip_changes): Use PT instead of BUF_PT.
3785
d251f04b
EZ
37862011-03-13 Eli Zaretskii <eliz@gnu.org>
3787
3788 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3789 $(EMACS_ROOT)/lib/intprops.h.
3790
f0c77cd1
PE
37912011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3792
3eca4629
PE
3793 Fix more problems found by GCC 4.5.2's static checks.
3794
7c86ee98
PE
3795 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3796 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3797 (xg_free_frame_widgets): Make it clear that a local variable is
3798 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3799 (gdk_window_get_screen): Make it clear that this macro is needed
3800 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3801 (int_gtk_range_get_value): New function, which avoids a diagnostic
3802 from gcc -Wbad-function-cast.
3803 (xg_set_toolkit_scroll_bar_thumb): Use it.
3804 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3805 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3806 (get_utf8_string, xg_get_file_with_chooser):
3807 Rename locals to avoid shadowing.
3808 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3809
41729b81
PE
3810 * xgselect.c (xg_select): Remove unused var.
3811
f0c77cd1
PE
3812 * image.c (four_corners_best): Mark locals as initialized.
3813 (gif_load): Initialize transparent_p to zero (Bug#8238).
3814 Mark another local as initialized.
ec6cf4c6 3815 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3816
ce0ad53d 3817 * image.c (clear_image_cache): Now static.
d5d5a617 3818 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3819 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3820 (x_edge_detection): Remove unnecessary cast that
3821 gcc -Wbad-function-cast diagnoses.
2037898d 3822 (gif_load): Fix pointer signedness.
6ae141d6
PE
3823 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3824 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3825
33383987 38262011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3827
d32df629
PE
3828 Improve quality of tests for time stamp overflow.
3829 For example, without this patch (encode-time 0 0 0 1 1
3830 1152921504606846976) returns the obviously-bogus value (-948597
3831 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3832 reports time overflow. See
3833 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3834 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3835 * editfns.c: Include limits.h and intprops.h.
3836 (TIME_T_MIN, TIME_T_MAX): New macros.
3837 (time_overflow): Move earlier, to before first use.
3838 (hi_time, lo_time): New functions, for an accurate test for
3839 out-of-range times.
3840 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3841 (Fget_internal_run_time): Don't assume time_t fits in int.
3842 (make_time): Use list2 instead of Fcons twice.
3843 (Fdecode_time): More accurate test for out-of-range times.
3844 (check_tm_member): New function.
3845 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3846 (lisp_time_argument): Don't rely on undefined left-shift and
3847 right-shift behavior when checking for time stamp overflow.
8be6f318 3848
fe31d94c
PE
3849 * editfns.c (time_overflow): New function, refactoring common code.
3850 (Fformat_time_string, Fdecode_time, Fencode_time):
3851 (Fcurrent_time_string): Use it.
3852
8be6f318
PE
3853 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3854 * dired.c (make_time): Move to ...
3855 * editfns.c (make_time): ... here.
3856 * systime.h: Note the move.
3857
09d9db2c 38582011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3859
126bc0dc
YM
3860 * fringe.c (update_window_fringes): Remove unused variables.
3861
c47cbdfd
YM
3862 * unexmacosx.c (copy_data_segment): Also copy __got section.
3863 (Bug#8223)
3864
7ac80be9
EZ
38652011-03-12 Eli Zaretskii <eliz@gnu.org>
3866
c96bbc66 3867 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3868 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3869 Constify `char *' arguments and their references according to
3870 prototypes in tparam.h.
3871
ecb0f94d 3872 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3873
7ac80be9
EZ
3874 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3875 Adapt all references accordingly.
3876
3877 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3878
ef1fd07e
TT
38792011-03-11 Tom Tromey <tromey@redhat.com>
3880
3881 * buffer.c (syms_of_buffer): Remove obsolete comment.
3882
7ef4b50c
EZ
38832011-03-11 Eli Zaretskii <eliz@gnu.org>
3884
3885 * termhooks.h (encode_terminal_code): Declare prototype.
3886
3887 * msdos.c (encode_terminal_code): Don't declare prototype.
3888
3889 * term.c (encode_terminal_code): Now external again, used by
3890 w32console.c and msdos.c.
3891
44f230aa
SM
3892 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3893 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3894
4b1ec863 38952011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3896
1714f52b 3897 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3898
4b1ec863
PE
3899 * fringe.c (update_window_fringes): Mark locals as initialized
3900 (Bug#8227).
3901 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3902
524c7aa6
PE
3903 * alloc.c (mark_fringe_data): Move decl from here ...
3904 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3905 to check its interface.
3906 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3907
a5c0af81 3908 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3909 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3910 (fontset_font): Mark local as initialized.
a9a06e0b 3911 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3912
b4716021
PE
3913 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3914
811e9bac 3915 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3916 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3917 (x_own_selection, Fx_disown_selection_internal): Rename locals
3918 to avoid shadowing.
3919 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3920
7e3ab302
PE
3921 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3922 so that the caller can use some name other than gcpro1.
3923 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3924 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3925 (Fx_backspace_delete_keys_p):
3926 Use them to avoid shadowing, and rename vars to avoid shadowing.
3927 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3928 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3929 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3930 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3931 Remove unused locals.
7e3ab302
PE
3932 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3933 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3934 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3935 macros.
f78faa98 3936
e2b13473
PE
3937 * xterm.h (x_mouse_leave): New decl.
3938
77f23912
PE
3939 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3940 Remove unused functions.
cdf4ba58
PE
3941 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3942 (x_calc_absolute_position): Now static.
7411c686 3943 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3944 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3945 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3946 unless they are used.
38d0b34a
PE
3947 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3948 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3949 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3950 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3951 (x_error_catcher, x_connection_closed, x_error_handler):
3952 (x_error_quitter, xembed_send_message, x_iconify_frame):
3953 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3954 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3955 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3956
44f230aa
SM
3957 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3958 Rename or move locals to avoid shadowing.
6b463e58 3959 (tty_defined_color, merge_face_heights): Now static.
5967d051 3960 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3961 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3962 does not deduce is never used uninitialized.
73719eba
PE
3963 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3964 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3965
426994c3 3966 * terminal.c (store_terminal_param): Now static.
5489860b 3967
032f1620 3968 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3969 (set_frame_menubar): Remove unused local.
d4323972 3970 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3971 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3972 since they might point to immutable storage.
281585b0
PE
3973 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3974 since it's unused otherwise.
032f1620 3975
367c19e5 3976 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3977 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3978 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3979 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3980 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3981 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3982 does not deduce are never used uninitialized.
70739cbe 3983
07b48fa9
PE
3984 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3985
8868a238 3986 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3987 * window.c (window_loop, size_window):
3988 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3989
7e5cf297 3990 * window.c (display_buffer): Now static.
d6550a9f
PE
3991 (size_window): Mark variables that gcc -Wuninitialized
3992 does not deduce are never used uninitialized.
a586633d
PE
3993 * window.h (check_all_windows): New decl, to forestall
3994 gcc -Wmissing-prototypes diagnostic.
5b555da1 3995 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3996
f6095868
PE
3997 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3998 shadowing.
3999 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4000 Include <limits.h>.
4001 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4002 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4003 (load_charset_map): Mark variables that gcc -Wuninitialized
4004 does not deduce are never used uninitialized.
53df7c11 4005 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4006
f38b440c
PE
4007 * coding.c (coding_set_source, coding_set_destination):
4008 Use "else { /* comment */ }" rather than "else /* comment */;"
4009 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4010 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4011 a block, when the outer 'i' will do.
4012 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4013 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4014 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4015 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4016 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4017 Rename locals to avoid shadowing.
4018 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4019 * coding.c (emacs_mule_char, encode_invocation_designation):
4020 Now static, since they're not used elsewhere.
413bb2db 4021 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4022 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4023 (decode_coding_emacs_mule): Mark variables that gcc
4024 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4025 (detect_coding_iso_2022): Initialize a local variable that might
4026 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4027 this initialization is needed. (Bug#8211)
5f58e762
PE
4028 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4029 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4030 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4031 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4032 Remove unused macros.
f38b440c 4033
232b38b9 4034 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4035 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4036 * character.c (string_count_byte8): Likewise.
232b38b9 4037
fb90da1b
PE
4038 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4039 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4040
fb93dbc2
PE
4041 * chartab.c (copy_sub_char_table): Now static, since it's not used
4042 elsewhere.
5c156ace
PE
4043 (sub_char_table_ref_and_range, char_table_ref_and_range):
4044 Rename locals to avoid shadowing.
bbcd0949 4045 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4046
7d3b3862 4047 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4048 (BIDI_BOB): Remove unused macro.
7d3b3862 4049
6be7d3da
PE
4050 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4051 deduce are never used uninitialized.
c2ed9c8b 4052 * term.c (encode_terminal_code): Likewise.
6be7d3da 4053
75f8807f 4054 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4055
50938595
PE
4056 * tparam.h: New file.
4057 * term.c, tparam.h: Include it.
4058 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4059 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4060 Move these decls to tparam.h, and make them agree with what
4061 is actually in tparam.c. The previous trick of using incompatible
4062 decls in different modules does not conform to the C standard.
4063 All callers of tparam changed to use tparam's actual API.
4064 * tparam.c (tparam1, tparam, tgoto):
4065 Use const pointers where appropriate.
4066
fbceeba2
PE
4067 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4068 * cm.h (struct cm): Likewise.
4069 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4070 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4071 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4072 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4073 (turn_on_face, init_tty): Likewise.
4074 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4075
7f3f1250
PE
4076 * term.c (term_mouse_position): Rename local to avoid shadowing.
4077
e6ca6543
PE
4078 * alloc.c (mark_ttys): Move decl from here ...
4079 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4080
c40f8d15
AS
40812011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4082
4083 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4084
cfe0661d
JB
40852011-03-09 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * search.c (compile_pattern_1): Remove argument regp, unused since
4088 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4089 (compile_pattern): Don't pass it.
4090
0afb4571
J
40912011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4092
4093 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4094 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4095 for ! HAVE_GTK3.
4096 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4097
4098 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4099
4100 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4101 gdk_window_get_screen, gdk_window_get_geometry,
4102 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4103 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4104 (xg_get_pixbuf_from_pixmap): New function.
4105 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4106 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4107 Call xg_get_pixbuf_from_pixmap instead of
4108 gdk_pixbuf_get_from_drawable.
4109 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4110 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4111 (xg_check_special_colors): Use GtkStyleContext and its functions
4112 for HAVE_GTK3.
4113 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4114 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4115 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4116 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4117 Call gtk_widget_get_preferred_size.
0afb4571
J
4118 (xg_frame_resized): gdk_window_get_geometry only takes 5
4119 parameters.
44f230aa
SM
4120 (xg_win_to_widget, xg_event_is_for_menubar):
4121 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4122 (xg_set_widget_bg): New function.
4123 (delete_cb): New function.
895009e1 4124 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4125 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4126 (xg_set_background_color): Call xg_set_widget_bg.
4127 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4128 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4129 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4130 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4131 if ! HAVE_GTK3.
4132 (update_frame_tool_bar): Call gtk_widget_hide.
4133 (xg_initialize): Use GDK_KEY_g.
4134
4135 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4136 if ! HAVE_GTK3
4137 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4138
4139 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4140 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4141 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4142
1c2cc4ef
JB
41432011-03-08 Juanma Barranquero <lekktu@gmail.com>
4144
4145 * w32xfns.c (select_palette): Check success of RealizePalette against
4146 GDI_ERROR, not zero.
4147
33383987 4148See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4149
4150;; Local Variables:
4151;; coding: utf-8
aac0c6e3
MR
4152;; End:
4153
33383987 4154 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4155
4156 This file is part of GNU Emacs.
4157
4158 GNU Emacs is free software: you can redistribute it and/or modify
4159 it under the terms of the GNU General Public License as published by
4160 the Free Software Foundation, either version 3 of the License, or
4161 (at your option) any later version.
4162
4163 GNU Emacs is distributed in the hope that it will be useful,
4164 but WITHOUT ANY WARRANTY; without even the implied warranty of
4165 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4166 GNU General Public License for more details.
4167
4168 You should have received a copy of the GNU General Public License
4169 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.